3a0e636d20dcbfa86d318a7381de7c2c830b6c41
[WebKit-https.git] / Tools / ChangeLog
1 2019-03-05  Brady Eidson  <beidson@apple.com>
2
3         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
4         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
5
6         Reviewed by Tim Horton.
7
8         Loading a file: URL into a WKWebView and then loading another file: url from a completely
9         different directory into that same WKWebView should work.
10
11         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
12         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
13
14 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
15
16         Add WeakHashSet
17         https://bugs.webkit.org/show_bug.cgi?id=195152
18
19         Reviewed by Antti Koivisto.
20
21         Added tests for WeakHashSet.
22
23         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
24         (TestWebKitAPI::Base::Base): Moved.
25         (TestWebKitAPI::Derived::foo): Moved.
26         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
27         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
28         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
29         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
30
31 2019-03-04  Chris Dumez  <cdumez@apple.com>
32
33         Do not share WebProcesses between private and regular sessions
34         https://bugs.webkit.org/show_bug.cgi?id=195189
35         <rdar://problem/48421064>
36
37         Reviewed by Alex Christensen.
38
39         Add API test coverage.
40
41         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
42         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
43
44 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
45
46         [WPE] Enable web process sandbox
47         https://bugs.webkit.org/show_bug.cgi?id=195169
48
49         Reviewed by Daniel Bates.
50
51         * wpe/install-dependencies:
52         * wpe/jhbuild.modules:
53
54 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
55
56         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
57         https://bugs.webkit.org/show_bug.cgi?id=195206
58
59         Reviewed by Žan Doberšek.
60
61         Add a new test case.
62
63         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
64         (testJSCClass):
65
66 2019-03-04  Charlie Turner  <cturner@igalia.com>
67
68         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
69         https://bugs.webkit.org/show_bug.cgi?id=194898
70
71         Reviewed by Žan Doberšek.
72
73         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
74         a GCC extension that permits arithmetic on void* pointer. Inline
75         the macro until this issue is fixed upstream.
76
77 2019-03-03  Tim Horton  <timothy_horton@apple.com>
78
79         Rid the world of WK_API_ENABLED
80         https://bugs.webkit.org/show_bug.cgi?id=195263
81
82         Reviewed by Dan Bernstein.
83
84         List of changed files elided because it's useless.
85
86 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
87
88         Unreviewed follow-up to r242292.
89
90         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
91
92         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
93         (TestWebKitAPI::testStrip): Renamed from strip.
94         (TestWebKitAPI::TEST):
95
96 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
97
98         Unreviewed, remove accidentally-committed URLHelpers.cpp test
99
100         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
101         and bug #194272 for details.
102
103         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
104
105 2019-03-03  Tim Horton  <timothy_horton@apple.com>
106
107         Remove some more unused 32-bit code
108         https://bugs.webkit.org/show_bug.cgi?id=195255
109
110         Reviewed by Darin Adler.
111
112         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
113         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
114         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
115         (NPP_New):
116         (NPP_HandleEvent):
117         (handleEventCarbon): Deleted.
118
119 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
120
121         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
122
123         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
124         (TestWebKitAPI::TEST):
125
126 2019-03-01  Darin Adler  <darin@apple.com>
127
128         Finish removing String::format
129         https://bugs.webkit.org/show_bug.cgi?id=194893
130
131         Reviewed by Daniel Bates.
132 '
133         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
134
135 2019-03-01  Alex Christensen  <achristensen@webkit.org>
136
137         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
138         https://bugs.webkit.org/show_bug.cgi?id=195229
139         <rdar://problem/48520362>
140
141         Reviewed by Chris Dumez.
142
143         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
144         (TEST):
145
146 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
147
148         Add a system trace scope for event region building
149         https://bugs.webkit.org/show_bug.cgi?id=195226
150
151         Reviewed by Jon Lee.
152
153         This trace scope measures the time spend converting element rects into Region objects,
154         which can be large on some pages.
155
156         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
157
158         * Tracing/SystemTracePoints.plist:
159
160 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
161
162         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
163         https://bugs.webkit.org/show_bug.cgi?id=194612
164
165         Reviewed by Alex Christensen.
166
167         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
168         Just test the new string-processing function and don't touch the actual environment.
169         (Test cases are all as before, but based on operator== instead of strcmp.)
170
171 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
172
173         [ews-app] Update primary keys for handling multiple Buildbot instances
174         https://bugs.webkit.org/show_bug.cgi?id=195120
175
176         Reviewed by Stephanie Lewis.
177
178         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
179         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
180         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
181
182         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
183         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
184         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
185         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
186         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
187         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
188
189 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
190
191         [WinCairo] Enable service worker
192         https://bugs.webkit.org/show_bug.cgi?id=188318
193
194         Reviewed by Youenn Fablet.
195
196         * DumpRenderTree/DumpRenderTreePrefix.h:
197         * TestWebKitAPI/PlatformWin.cmake:
198         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
199         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
200         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
201
202 2019-03-01  Justin Fan  <justin_fan@apple.com>
203
204         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
205         https://bugs.webkit.org/show_bug.cgi?id=195191
206
207         Rubber-stamped by Dean Jackson.
208
209         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
210
211         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
212
213 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
214
215         Unreviewed, fix lldb webkitpy tests
216         https://bugs.webkit.org/show_bug.cgi?id=194375
217
218         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
219
220         * lldb/lldb_webkit.py:
221         (WTFStringImplProvider.is_8bit):
222
223 2019-02-28  David Quesada  <david_quesada@apple.com>
224
225         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
226         https://bugs.webkit.org/show_bug.cgi?id=195121
227         rdar://problem/48450302
228
229         Reviewed by Alex Christensen.
230
231         Add API tests for -WKNavigationAction._shouldPerformDownload in various
232         configurations where the 'download' attribute is absent, blank, or populated
233         with a filename, and where the anchor element is same-origin or cross-origin
234         (meaning the 'download' attribute shouldn't be honored).
235
236         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
237         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
238         (-[NavigationActionTestDelegate init]):
239         (-[NavigationActionTestDelegate navigationAction]):
240         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
241         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
242         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
243         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
244         (TEST):
245
246 2019-02-28  Antoine Quint  <graouts@apple.com>
247
248         Enable the Pointer Events runtime flag by default
249         https://bugs.webkit.org/show_bug.cgi?id=195156
250
251         Reviewed by Dean Jackson.
252
253         * DumpRenderTree/mac/DumpRenderTree.mm:
254         (enableExperimentalFeatures):
255
256 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
257
258         Several PasteImage API tests are flaky
259         https://bugs.webkit.org/show_bug.cgi?id=195160
260
261         Reviewed by Tim Horton.
262
263         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
264         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
265         listening for a "load" event after image load is already complete.
266
267         To address this, make these tests first register a "load" event handler, then run script to insert an image
268         element into the document, and finally wait until the load event is observed before checking image size.
269
270         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
271
272 2019-02-28  Chris Dumez  <cdumez@apple.com>
273
274         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
275         https://bugs.webkit.org/show_bug.cgi?id=195107
276
277         Reviewed by Alex Christensen.
278
279         Give some time for the zoom level to get restored.
280
281         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
282
283 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
284
285         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
286         https://bugs.webkit.org/show_bug.cgi?id=194958
287
288         Reviewed by Geoffrey Garen.
289
290         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
291         (TEST):
292
293 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
294
295         [ews-app] Update method to save build to handle builder_display_name
296         https://bugs.webkit.org/show_bug.cgi?id=195047
297
298         Reviewed by Dewei Zhu.
299
300         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
301         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
302
303 2019-02-28  Justin Fan  <justin_fan@apple.com>
304
305         [Web GPU] Enable Web GPU only on 64-bit
306         https://bugs.webkit.org/show_bug.cgi?id=195139
307
308         Because Metal is only supported on 64 bit apps.
309
310         Unreviewed build fix.
311
312         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
313
314 2019-02-27  Youenn Fablet  <youenn@apple.com>
315
316         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
317         https://bugs.webkit.org/show_bug.cgi?id=194959
318
319         Reviewed by Chris Dumez.
320
321         Spin loop until getting the condition to remove flakiness.
322
323         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
324
325 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
326
327         [ews-build] Buildbot should include builder_display_name in the build events
328         https://bugs.webkit.org/show_bug.cgi?id=195045
329
330         Reviewed by Dewei Zhu.
331
332         * BuildSlaveSupport/ews-build/events.py:
333         (Events.buildStarted): Included builder_display_name in event data. Also renamed
334         buildername to builder_name to be consistent in naming style.
335         (Events.buildFinished): Ditto.
336
337 2019-02-27  Chris Dumez  <cdumez@apple.com>
338
339         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
340         https://bugs.webkit.org/show_bug.cgi?id=194480
341
342         Reviewed by Brady Eidson.
343
344         Update existing API test to make it more likely to reproduce the issue.
345
346         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
347
348 2019-02-27  Brady Eidson  <beidson@apple.com>
349
350         Universal links from Google search results pages don't open the app.
351         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
352
353         Reviewed by Geoffrey Garen.
354
355         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
356         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
357         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
358         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
359
360 2019-02-27  Chris Dumez  <cdumez@apple.com>
361
362         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
363         https://bugs.webkit.org/show_bug.cgi?id=195102
364
365         Reviewed by Geoffrey Garen.
366
367         If the number of processes is not yet what we expect, wait a bit and check again to give
368         processes some time to exit.
369
370         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
371
372 2019-02-27  Chris Dumez  <cdumez@apple.com>
373
374         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
375         https://bugs.webkit.org/show_bug.cgi?id=194545
376
377         Reviewed by Brady Eidson.
378
379         Make sure the test navigates forward and then back only once. Previously, navigating
380         back would trigger a navigation again in a timer.
381
382         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
383
384 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
385
386         High Sierra Debug JSC test queue should use faster hardware
387         https://bugs.webkit.org/show_bug.cgi?id=194603
388
389         Rubber-stamped by Alexey Proskuryakov.
390
391         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
392
393         * BuildSlaveSupport/build.webkit.org-config/config.json:
394         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
395         (BubbleQueueServer):
396         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
397         (WebKitBuildbot):
398         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
399         * QueueStatusServer/config/queues.py:
400         * Scripts/webkitpy/common/config/ews.json:
401         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
402         (test_ews_name):
403
404 2019-02-27  John Wilander  <wilander@apple.com>
405
406         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
407         https://bugs.webkit.org/show_bug.cgi?id=195071
408         <rdar://problem/48417690>
409
410         Reviewed by Alex Christensen and Brent Fulgham.
411
412         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
413         (TestWebKitAPI::createURL):
414             Convenience function.
415         (TestWebKitAPI::TEST):
416             WebCore::AdClickAttribution now takes a URL when creating Source and
417             Destination.
418         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
419         (TestWebKitAPI::TEST):
420             WebCore::AdClickAttribution now takes a URL when creating Source and
421             Destination.
422
423 2019-02-27  Antoine Quint  <graouts@apple.com>
424
425         Support Pointer Events on macOS
426         https://bugs.webkit.org/show_bug.cgi?id=195008
427         <rdar://problem/47454419>
428
429         Reviewed by Dean Jackson.
430
431         * DumpRenderTree/mac/DumpRenderTree.mm:
432         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
433         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
434
435 2019-02-26  Mark Lam  <mark.lam@apple.com>
436
437         Remove remaining poisoning code.
438         https://bugs.webkit.org/show_bug.cgi?id=194138
439
440         Reviewed by Saam Barati.
441
442         * TestWebKitAPI/CMakeLists.txt:
443         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
444         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
445         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
446         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
447         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
448         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
449         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
450
451 2019-02-26  Alex Christensen  <achristensen@webkit.org>
452
453         Move ephemeral local storage from WebProcess to UIProcess
454         https://bugs.webkit.org/show_bug.cgi?id=195074
455         <rdar://problem/47937975>
456
457         Reviewed by Geoff Garen.
458
459         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
460
461 2019-02-20  Jer Noble  <jer.noble@apple.com>
462
463         [Cocoa] Media elements will restart network buffering just before suspending
464         https://bugs.webkit.org/show_bug.cgi?id=193691
465
466         Reviewed by Eric Carlson.
467
468         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
469         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
470         (TEST):
471
472 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
473
474         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
475         https://bugs.webkit.org/show_bug.cgi?id=191652
476
477         Reviewed by Alex Christensen.
478
479         Fix WinCairo MiniBrowser behavior of authentication dialog.
480
481         * MiniBrowser/win/WebKitBrowserWindow.cpp:
482         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
483
484 2019-02-26  Youenn Fablet  <youenn@apple.com>
485
486         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
487         https://bugs.webkit.org/show_bug.cgi?id=195028
488         <rdar://problem/48243733>
489
490         Reviewed by Eric Carlson.
491
492         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
493
494 2019-02-26  Philippe Normand  <pnormand@igalia.com>
495
496         [WPE] Add API for webview background color configuration
497         https://bugs.webkit.org/show_bug.cgi?id=192305
498
499         Reviewed by Michael Catanzaro.
500
501         * MiniBrowser/wpe/main.cpp:
502         (main): Add a new option to configure the webview background
503         color. Example: --bg-color=transparent.
504         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
505         (testWebViewBackgroundColor): Enable background color API tests for WPE.
506         (beforeAll): Ditto.
507
508 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
509
510         scalableNativeWebpageParameters() is not preserved on new page navigation.
511         https://bugs.webkit.org/show_bug.cgi?id=194892
512         <rdar://problem/47538280>
513
514         Reviewed by Wenson Hsieh.
515         
516         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
517
518         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
519         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
520         * DumpRenderTree/mac/UIScriptControllerMac.mm:
521         (WTR::UIScriptController::allowsViewportShrinkToFit):
522         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
523         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
524         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
525         * TestRunnerShared/UIScriptContext/UIScriptController.h:
526         * WebKitTestRunner/UIScriptControllerCocoa.mm:
527         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
528
529 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
530
531         [ews-app] Add model for handling multiple Buildbot instances
532         https://bugs.webkit.org/show_bug.cgi?id=194863
533
534         Reviewed by Stephanie Lewis.
535
536         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
537
538 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
539
540         [ews-app] Remove BuilderMapping table
541         https://bugs.webkit.org/show_bug.cgi?id=194961
542
543         Reviewed by Stephanie Lewis.
544
545         Store builder name directly in build table, instead of having a separate
546         table for it.
547
548         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
549         * BuildSlaveSupport/ews-app/ews/models/build.py:
550         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
551         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
552
553 2019-02-25  John Wilander  <wilander@apple.com>
554
555         Introduce and adopt new class RegistrableDomain for eTLD+1
556         https://bugs.webkit.org/show_bug.cgi?id=194791
557         <rdar://problem/48179240>
558
559         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
560
561         This patch adds an API test and replaces two instances of
562         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
563
564         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
565         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
566         (TestWebKitAPI::TEST):
567             Changed two strings to make sure the registrable domains are still considered
568             invalid and pass the test.
569         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
570         (TestWebKitAPI::TEST):
571         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
572         (WTR::InjectedBundle::didReceiveMessageToPage):
573
574 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
575
576         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
577         https://bugs.webkit.org/show_bug.cgi?id=195001
578
579         Reviewed by Carlos Garcia Campos.
580
581         API version 1.0 always includes the functionality previously guarded with
582         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
583         unconditionally.
584
585         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
586         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
587         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
588         (WebViewTest::showInWindow): Ditto.
589         (WebViewTest::hideView): Ditto.
590         * wpe/backends/HeadlessViewBackend.cpp:
591         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
592         * wpe/backends/ViewBackend.cpp:
593         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
594         * wpe/backends/WindowViewBackend.cpp:
595         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
596         WPE_BACKEND_CHECK_VERSION().
597         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
598
599 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
600
601         [Flatpak] Add support for flatpak > 1.1.2
602         https://bugs.webkit.org/show_bug.cgi?id=194088
603
604         Flatpak 1.2 is now out so we need to support that
605         version now.
606
607         Reviewed by Michael Catanzaro.
608
609         * flatpak/flatpakutils.py:
610         (check_flatpak):
611         (FlatpakPackages.__init__):
612         (FlatpakPackages.__detect_packages):
613         (FlatpakPackages.__detect_packages.in):
614         (FlatpakRepos.update):
615
616 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
617
618         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
619         https://bugs.webkit.org/show_bug.cgi?id=194998
620
621         Reviewed by Carlos Garcia Campos.
622
623         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
624         to a Git checkout and using the latest commit containing various fixes
625         and improvements.
626
627 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
628
629         [WPE][GTK] Remove user agent quirk for washingtonpost.com
630         https://bugs.webkit.org/show_bug.cgi?id=194981
631
632         Reviewed by Žan Doberšek.
633
634         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
635         (TestWebKitAPI::TEST):
636
637 2019-02-23  Keith Miller  <keith_miller@apple.com>
638
639         Add new mac target numbers
640         https://bugs.webkit.org/show_bug.cgi?id=194955
641
642         Reviewed by Tim Horton.
643
644         * DumpRenderTree/mac/Configurations/Base.xcconfig:
645         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
646         * MiniBrowser/Configurations/Base.xcconfig:
647         * TestWebKitAPI/Configurations/Base.xcconfig:
648         * WebKitTestRunner/Configurations/Base.xcconfig:
649
650 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
651
652         [WinCairo] Enable wk1/wk2 suffix for platform search path.
653         https://bugs.webkit.org/show_bug.cgi?id=194846
654
655         Reviewed by Don Olmstead.
656
657         Added _search_paths() and _port_specific_expectations_files() for
658         WinCairoPort.
659
660         * Scripts/webkitpy/port/win.py:
661         (WinCairoPort.default_baseline_search_path):
662         (WinCairoPort):
663         (WinCairoPort._port_specific_expectations_files):
664         (WinCairoPort._search_paths):
665
666 2019-02-22  Tim Horton  <timothy_horton@apple.com>
667
668         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
669         https://bugs.webkit.org/show_bug.cgi?id=194963
670
671         Reviewed by Dean Jackson.
672
673         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
674         Do a `contains` check instead of `equals`, because in debug builds we
675         put the GraphicsLayer pointer in a prefix.
676
677 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
678
679         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
680         https://bugs.webkit.org/show_bug.cgi?id=194873
681         <rdar://problem/46701974>
682
683         Reviewed by Tim Horton.
684
685         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
686
687         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
688         (WTR::UIScriptController::menuRect const):
689         (WTR::UIScriptController::isShowingMenu const):
690         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
691         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
692         (WTR::UIScriptController::menuRect const):
693
694         Add a function to query the bounds of the callout menu in content coordinates.
695
696         (WTR::UIScriptController::isShowingMenu const):
697
698         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
699
700         * TestRunnerShared/UIScriptContext/UIScriptController.h:
701         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
702         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
703         (WTR::UIScriptController::rectForMenuAction const):
704         (WTR::UIScriptController::menuRect const):
705         (WTR::UIScriptController::isShowingMenu const):
706         (WTR::findViewInHierarchyOfType): Deleted.
707
708 2019-02-22  Chris Dumez  <cdumez@apple.com>
709
710         Regression(PSON) Unable to preview password-protected documents on iCloud.com
711         https://bugs.webkit.org/show_bug.cgi?id=194954
712         <rdar://problem/48127957>
713
714         Reviewed by Alex Christensen.
715
716         Add API test coverage.
717
718         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
719         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
720         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
721         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
722
723 2019-02-22  Chris Dumez  <cdumez@apple.com>
724
725         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
726         https://bugs.webkit.org/show_bug.cgi?id=194924
727         <rdar://problem/48216125>
728
729         Reviewed by Geoffrey Garen.
730
731         Add API test coverage.
732
733         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
734
735 2019-02-22  Chris Dumez  <cdumez@apple.com>
736
737         Unreviewed, disable API test added in r241928 on iOS.
738
739         The cache is not enabled on devices with less than 3GB of RAM.
740
741         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
742
743 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
744
745         Hardcode Visual Viewports on everywhere except iOS WK1
746         https://bugs.webkit.org/show_bug.cgi?id=194928
747
748         Reviewed by Zalan Bujtas.
749
750         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
751         change the default value of the Setting to 'true', and hardcode WebView on iOS to
752         set it to false. The setting has shipped for several years and there's no need to turn
753         it off now.
754
755         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
756         Visual Viewports are not enabled.
757         
758         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
759         that only runs in WK2
760
761         * MiniBrowser/mac/SettingsController.h:
762         * MiniBrowser/mac/SettingsController.m:
763         (-[SettingsController init]):
764         (-[SettingsController _populateMenu]):
765         (-[SettingsController validateMenuItem:]):
766         (-[SettingsController visualViewportEnabled]): Deleted.
767         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
768         * MiniBrowser/mac/WK1BrowserWindowController.m:
769         (-[WK1BrowserWindowController didChangeSettings]):
770         * MiniBrowser/mac/WK2BrowserWindowController.m:
771         (-[WK2BrowserWindowController didChangeSettings]):
772
773 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
774
775         Discard cached processes when clearing website data store
776         https://bugs.webkit.org/show_bug.cgi?id=194894
777
778         Reviewed by Chris Dumez.
779
780         Added a test case.
781
782         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
783         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
784
785 2019-02-21  Alex Christensen  <achristensen@webkit.org>
786
787         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
788         https://bugs.webkit.org/show_bug.cgi?id=194914
789         <rdar://problem/47586889>
790
791         Reviewed by Geoffrey Garen.
792
793         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
794         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
795         (TEST):
796         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
797
798 2019-02-21  David Kilzer  <ddkilzer@apple.com>
799
800         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
801         <https://webkit.org/b/194761>
802
803         Reviewed by Myles Maxfield.
804
805         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
806         (WTR::activateSystemCoreWebFonts): Log `error` to console if
807         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
808         to use ARC-compliant cast.
809         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
810         ARC-compliant cast.
811         (WTR::installFakeHelvetica): Log `error` to console if
812         CTFontManagerRegisterFontsForURL() fails, but only on supported
813         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
814         Call CFRelease() on `error` to fix the leak.  Update to use
815         ARC-compliant cast.
816         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
817         cast.
818
819 2019-02-21  Chris Dumez  <cdumez@apple.com>
820
821         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
822         https://bugs.webkit.org/show_bug.cgi?id=194481
823
824         Reviewed by Alex Christensen.
825
826         Give the processes a chance to shutdown and wait until we reached the expected number
827         of processes.
828
829         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
830
831 2019-02-21  Tim Horton  <timothy_horton@apple.com>
832
833         Fix the macOS build
834
835         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
836
837 2019-02-21  Tim Horton  <timothy_horton@apple.com>
838
839         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
840
841         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
842         I am a backwards.
843
844 2019-02-21  Tim Horton  <timothy_horton@apple.com>
845
846         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
847
848         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
849         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
850         We could force on UI-side compositing, but I feel like the test might be more
851         valuable exercising the normal path on each platform (though the original
852         bug was also UI-side specific). Though we can't validate that the overlay
853         layer was installed successfully, there are layout tests that do that.
854
855 2019-02-21  Tim Horton  <timothy_horton@apple.com>
856
857         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
858         https://bugs.webkit.org/show_bug.cgi?id=194845
859         <rdar://problem/47944579>
860
861         Reviewed by Antti Koivisto.
862
863         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
864         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
865
866 2019-02-21  Zalan Bujtas  <zalan@apple.com>
867
868         [LFC][Floats] Add support for placing formatting roots in-between floats.
869         https://bugs.webkit.org/show_bug.cgi?id=194902
870
871         Reviewed by Antti Koivisto.
872
873         * LayoutReloaded/misc/LFC-passing-tests.txt:
874
875 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
876
877         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
878         https://bugs.webkit.org/show_bug.cgi?id=194901
879
880         Unreviewed build fix.
881
882         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
883         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
884         WPEBackend-fdo-0.1 as library name.
885
886 2019-02-21  Rob Buis  <rbuis@igalia.com>
887
888         Update MIME type parser
889         https://bugs.webkit.org/show_bug.cgi?id=180526
890
891         Reviewed by Darin Adler.
892
893         Add tests involving leading and trailing whitespace, non-token
894         characters and quoted strings.
895
896         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
897         (TestWebKitAPI::TEST):
898
899 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
900
901         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
902         https://bugs.webkit.org/show_bug.cgi?id=194884
903
904         Reviewed by Michael Catanzaro.
905
906         * PlatformWin.cmake:
907
908 2019-02-20  Chris Dumez  <cdumez@apple.com>
909
910         Add API test for <rdar://problem/47471222>
911         https://bugs.webkit.org/show_bug.cgi?id=194847
912
913         Reviewed by Alex Christensen.
914
915         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
916
917 2019-02-20  Chris Dumez  <cdumez@apple.com>
918
919         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
920         https://bugs.webkit.org/show_bug.cgi?id=194872
921         <rdar://problem/47924500>
922
923         Reviewed by Alex Christensen.
924
925         Add API test coverage.
926
927         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
928
929 2019-02-20  Jer Noble  <jer.noble@apple.com>
930
931         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
932         https://bugs.webkit.org/show_bug.cgi?id=191332
933
934         Reviewed by Dean Jackson.
935
936         * Scripts/git-is-in-range: Added.
937
938 2019-02-20  Andy Estes  <aestes@apple.com>
939
940         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
941         https://bugs.webkit.org/show_bug.cgi?id=194869
942
943         Rubber-stamped by Jer Noble.
944
945         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
946         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
947         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
948         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
949         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
950         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
951
952 2019-02-20  Chris Dumez  <cdumez@apple.com>
953
954         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
955         https://bugs.webkit.org/show_bug.cgi?id=194857
956         <rdar://problem/47759323>
957
958         Reviewed by Alex Christensen.
959
960         Add API test coverage.
961
962         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
963
964 2019-02-20  Chris Dumez  <cdumez@apple.com>
965
966         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
967         https://bugs.webkit.org/show_bug.cgi?id=194829
968         <rdar://problem/47889906>
969
970         Reviewed by Alexey Proskuryakov.
971
972         Every time the TestOptions were changing we were creating both a new Web view and
973         a new WKContext, which would start a new Network process. In most cases, we only
974         need to contruct a new Web view and we do can keep reusing the same WKContext.
975         This patch implements this optimization and thus avoids spinning a lot of new
976         Network processes while running the layout tests.
977
978         * WebKitTestRunner/TestController.cpp:
979         (WTR::TestController::generateContextConfiguration const):
980         (WTR::TestController::generatePageConfiguration):
981         (WTR::TestController::createWebViewWithOptions):
982         (WTR::TestController::resetPreferencesToConsistentValues):
983         (WTR::updateTestOptionsFromTestHeader):
984         * WebKitTestRunner/TestController.h:
985         * WebKitTestRunner/TestOptions.h:
986         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
987         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
988         (WTR::TestOptions::hasSameInitializationOptions const):
989         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
990         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
991         (WTR::TestController::platformAddTestOptions const):
992
993 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
994
995         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
996         https://bugs.webkit.org/show_bug.cgi?id=167941
997
998         Reviewed by Carlos Garcia Campos.
999
1000         * MiniBrowser/gtk/main.c:
1001         (filterSavedCallback): Added.
1002         (main): Support loading a JSON rule set file for content filtering.
1003         * MiniBrowser/wpe/main.cpp:
1004         (filterSavedCallback): Added.
1005         (main): Support loading a JSON rule set file for content filtering.
1006         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
1007         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
1008         (WTF::derefGPtr): Ditto.
1009         (testEmptyStore):
1010         (testSaveInvalidFilter):
1011         (testSaveLoadFilter):
1012         (testSavedFilterIdentifierMatch):
1013         (testRemoveFilter):
1014         (testSaveMultipleFilters):
1015         (testSaveFilterFromFile):
1016         (testFilterPersistence):
1017         (beforeAll):
1018         (afterAll):
1019         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
1020         (removeOldInjectedContentAndResetLists): Also reset content filters.
1021         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
1022         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
1023         the element affected by the style sheet.
1024         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
1025         and returns it to be used by tests.
1026         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
1027         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
1028         (serverCallback): Add support for serving a CSS style sheet for testing.
1029         (beforeAll): Add call to testUserContentManagerContentFilter().
1030         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
1031
1032 2019-02-19  Keith Rollin  <krollin@apple.com>
1033
1034         Add timing information to build output
1035         https://bugs.webkit.org/show_bug.cgi?id=194839
1036         <rdar://problem/48219609>
1037
1038         Reviewed by Alexey Proskuryakov.
1039
1040         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
1041         emit each project's build time to its output. E.g.,
1042
1043             ** BUILD SUCCEEDED ** [0.132 sec]
1044
1045         * Scripts/webkitdirs.pm:
1046         (XcodeOptions):
1047
1048 2019-02-19  Truitt Savell  <tsavell@apple.com>
1049
1050         Unreviewed, rolling out r241784.
1051
1052         Broke all OpenSource builds.
1053
1054         Reverted changeset:
1055
1056         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
1057         instances view"
1058         https://bugs.webkit.org/show_bug.cgi?id=172848
1059         https://trac.webkit.org/changeset/241784
1060
1061 2019-02-19  Zalan Bujtas  <zalan@apple.com>
1062
1063         [LFC][Floats] Remove redundant intersecting logic
1064         https://bugs.webkit.org/show_bug.cgi?id=194804
1065
1066         Reviewed by Antti Koivisto.
1067
1068         * LayoutReloaded/misc/LFC-passing-tests.txt:
1069
1070 2019-02-19  Dean Jackson  <dino@apple.com>
1071
1072         Clean-up output from generate-xcfilelists so it can be filtered
1073         https://bugs.webkit.org/show_bug.cgi?id=194795
1074
1075         Reviewed by Joseph Pecoraro (and Keith Rollin).
1076
1077         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
1078         make a slight tweak to filter-build-webkit so such lines are marked
1079         as plain.
1080
1081         * Scripts/filter-build-webkit:
1082         * Scripts/generate-xcfilelists:
1083
1084 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
1085
1086         pytest is not correctly auto-installed
1087         https://bugs.webkit.org/show_bug.cgi?id=194707
1088
1089         Reviewed by Carlos Garcia Campos.
1090
1091         * Scripts/webkitpy/thirdparty/__init__.py:
1092         (AutoinstallImportHook._install_pytest):
1093
1094 2019-02-18  Chris Dumez  <cdumez@apple.com>
1095
1096         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
1097         https://bugs.webkit.org/show_bug.cgi?id=194797
1098         <rdar://problem/48055151>
1099
1100         Reviewed by Geoffrey Garen.
1101
1102         Add API test coverage.
1103
1104         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1105
1106 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1107
1108         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
1109         https://bugs.webkit.org/show_bug.cgi?id=194670
1110         <rdar://problem/39066529>
1111
1112         Reviewed by Tim Horton.
1113
1114         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
1115         pasted in an editable area as attachment elements.
1116
1117         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
1118         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1119         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
1120         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1121         (TestWebKitAPI::TEST):
1122         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1123         (WTR::InjectedBundlePage::InjectedBundlePage):
1124
1125 2019-02-18  Alex Christensen  <achristensen@webkit.org>
1126
1127         Fix API test after r241728
1128        ​https://bugs.webkit.org/show_bug.cgi?id=194723
1129
1130         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1131         (TEST):
1132         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
1133
1134 2019-02-18  Daniel Bates  <dabates@apple.com>
1135
1136         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
1137         https://bugs.webkit.org/show_bug.cgi?id=192824
1138         <rdar://problem/47100332>
1139
1140         Reviewed by Wenson Hsieh.
1141
1142         Fix a bug where the wrong usage code was used for F13 thru F24.
1143
1144         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1145         (keyCodeForDOMFunctionKey):
1146
1147 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
1148
1149         Bytecode cache should a have a boot-specific validation
1150         https://bugs.webkit.org/show_bug.cgi?id=194769
1151         <rdar://problem/48149509>
1152
1153         Reviewed by Keith Miller.
1154
1155         Add test for WTF::bootSessionUUIDString()
1156
1157         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1158         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
1159         (TEST):
1160
1161 2019-02-18  Alex Christensen  <achristensen@webkit.org>
1162
1163         Disable safe browsing in WKWebView and remove its WKPreferences API
1164         https://bugs.webkit.org/show_bug.cgi?id=194723
1165         <rdar://problem/48122993>
1166
1167         Reviewed by Geoffrey Garen.
1168
1169         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1170         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1171         (TEST):
1172         (safeBrowsingView):
1173         Make tests use SPI instead of API.
1174
1175 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
1176
1177         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
1178         https://bugs.webkit.org/show_bug.cgi?id=194586
1179
1180         Reviewed by Ross Kirsling.
1181
1182         * DumpRenderTree/win/DumpRenderTree.cpp:
1183         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
1184         * Scripts/webkitpy/port/driver.py:
1185         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
1186
1187 2019-02-17  David Kilzer  <ddkilzer@apple.com>
1188
1189         Unreviewed, rolling out r241620.
1190
1191         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
1192         (Requested by ddkilzer on #webkit.)
1193
1194         Reverted changeset:
1195
1196         "[WTF] Add environment variable helpers"
1197         https://bugs.webkit.org/show_bug.cgi?id=192405
1198         https://trac.webkit.org/changeset/241620
1199
1200 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1201
1202         [LFC] RenderImage's default intrinsic size is 0.
1203         https://bugs.webkit.org/show_bug.cgi?id=194745
1204
1205         Reviewed by Antti Koivisto.
1206
1207         * LayoutReloaded/misc/LFC-passing-tests.txt:
1208
1209 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1210
1211         [LFC][BFC] Add support for block replaced intrinsic width.
1212         https://bugs.webkit.org/show_bug.cgi?id=194705
1213
1214         Reviewed by Simon Fraser.
1215
1216         * LayoutReloaded/misc/LFC-passing-tests.txt:
1217
1218 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1219
1220         [LFC] Apply min/max width constraints to preferred width computation
1221         https://bugs.webkit.org/show_bug.cgi?id=194739
1222
1223         Reviewed by Simon Fraser.
1224
1225         * LayoutReloaded/misc/LFC-passing-tests.txt:
1226
1227 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
1228
1229         [WTF] Add environment variable helpers
1230         https://bugs.webkit.org/show_bug.cgi?id=192405
1231
1232         Reviewed by Michael Catanzaro.
1233
1234         * DumpRenderTree/mac/DumpRenderTree.mm:
1235         (libraryPathForDumpRenderTree):
1236         * DumpRenderTree/win/DumpRenderTree.cpp:
1237         (libraryPathForDumpRenderTree):
1238         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
1239         (setUpIOSLayoutTestCommunication):
1240         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1241         (beforeAll):
1242         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1243         (main):
1244         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1245         (WebKitTestBus::run):
1246         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1247         (WTR::getOutputDir):
1248         (WTR::initializeFontConfigSetting):
1249         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
1250         (WTR::InjectedBundle::platformInitialize):
1251         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1252         (WTR::topLevelPath):
1253         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
1254         (WTR::topLevelPath):
1255         (WTR::getOutputDir):
1256         (WTR::activateFonts):
1257         * WebKitTestRunner/TestController.cpp:
1258         (WTR::TestController::libraryPathForTesting):
1259         (WTR::TestController::generateContextConfiguration const):
1260         (WTR::TestController::generatePageConfiguration):
1261         (WTR::TestController::decideDestinationWithSuggestedFilename):
1262         (WTR::TestController::platformAdjustContext):
1263         * WebKitTestRunner/TestController.h:
1264         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1265         (WTR::TestController::cocoaPlatformInitialize):
1266         (WTR::TestController::platformAdjustContext):
1267         * WebKitTestRunner/gtk/main.cpp:
1268         (main):
1269         * WebKitTestRunner/mac/TestControllerMac.mm:
1270         (WTR::TestController::configureContentExtensionForTest):
1271         * WebKitTestRunner/wpe/main.cpp:
1272         (main):
1273         Utilize WTF::Environment where possible.
1274
1275 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1276
1277         [iOS] WKWebView callout bar is missing Change Writing Direction item
1278         https://bugs.webkit.org/show_bug.cgi?id=190015
1279         <rdar://problem/44810366>
1280
1281         Reviewed by Tim Horton.
1282
1283         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
1284         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
1285
1286         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
1287         (TestWebKitAPI::TEST):
1288
1289 2019-02-15  Chris Dumez  <cdumez@apple.com>
1290
1291         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
1292         https://bugs.webkit.org/show_bug.cgi?id=194717
1293         <rdar://problem/47884404>
1294
1295         Reviewed by Brady Eidson.
1296
1297         Add API test coverage.
1298
1299         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1300
1301 2019-02-15  Youenn Fablet  <youenn@apple.com>
1302
1303         Make navigator.mediaDevices SecureContext
1304         https://bugs.webkit.org/show_bug.cgi?id=194666
1305
1306         Reviewed by Eric Carlson.
1307
1308         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
1309         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
1310         (TEST_F):
1311
1312 2019-02-15  Brian Burg  <bburg@apple.com>
1313
1314         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
1315         https://bugs.webkit.org/show_bug.cgi?id=194411
1316         <rdar://problem/47787614>
1317
1318         Reviewed by Joseph Pecoraro.
1319
1320         Remove unnecessary soft linking macro usage.
1321
1322         * DumpRenderTree/mac/TestRunnerMac.mm:
1323         (TestRunner::inspectorTestStubURL):
1324         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
1325         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1326         (WTR::TestRunner::inspectorTestStubURL):
1327
1328 2019-02-15  Commit Queue  <commit-queue@webkit.org>
1329
1330         Unreviewed, rolling out r241559 and r241566.
1331         https://bugs.webkit.org/show_bug.cgi?id=194710
1332
1333         Causes layout test crashes under GuardMalloc (Requested by
1334         ryanhaddad on #webkit).
1335
1336         Reverted changesets:
1337
1338         "[WTF] Add environment variable helpers"
1339         https://bugs.webkit.org/show_bug.cgi?id=192405
1340         https://trac.webkit.org/changeset/241559
1341
1342         "Unreviewed build fix for WinCairo Debug after r241559."
1343         https://trac.webkit.org/changeset/241566
1344
1345 2019-02-15  Zalan Bujtas  <zalan@apple.com>
1346
1347         [LFC] Out-of-flow box is never a float box
1348         https://bugs.webkit.org/show_bug.cgi?id=194704
1349
1350         Reviewed by Antti Koivisto.
1351
1352         * LayoutReloaded/misc/LFC-passing-tests.txt:
1353
1354 2019-02-10  Darin Adler  <darin@apple.com>
1355
1356         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
1357         https://bugs.webkit.org/show_bug.cgi?id=194487
1358
1359         Reviewed by Daniel Bates.
1360
1361         * DumpRenderTree/win/DumpRenderTree.cpp:
1362         (applicationId): Use makeString instead of String::format.
1363         (main): Ditto.
1364         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1365         (TestWebKitAPI::Util::createURLForResource): Ditto.
1366         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1367         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
1368
1369         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1370         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
1371         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
1372         (WTR::createStringWithAttributes): Use appendLiteral.
1373         (WTR::AccessibilityUIElement::helpText const): Ditto.
1374         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
1375         directly instead of using String::format.
1376         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
1377         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
1378
1379 2019-02-15  Truitt Savell  <tsavell@apple.com>
1380
1381         Unreviewed, rolling out r241564.
1382
1383         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
1384
1385         Reverted changeset:
1386
1387         "[Mac] WebInspectorUI.framework does not need to be soft-
1388         linked anymore"
1389         https://bugs.webkit.org/show_bug.cgi?id=194411
1390         https://trac.webkit.org/changeset/241564
1391
1392 2019-02-15  Saam barati  <sbarati@apple.com>
1393
1394         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
1395         https://bugs.webkit.org/show_bug.cgi?id=194036
1396
1397         Reviewed by Yusuke Suzuki.
1398
1399         * Scripts/run-jsc-stress-tests:
1400
1401 2019-02-14  Tim Horton  <timothy_horton@apple.com>
1402
1403         Fix the build.
1404
1405         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1406         (WTR::UIScriptController::drawSquareInEditableImage):
1407         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1408         (TestWebKitAPI::drawSquareInEditableImage):
1409
1410 2019-02-14  Tim Horton  <timothy_horton@apple.com>
1411
1412         Fix the build.
1413
1414         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1415         (WTR::UIScriptController::drawSquareInEditableImage):
1416         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1417         (TestWebKitAPI::drawSquareInEditableImage):
1418
1419 2019-02-14  Brian Burg  <bburg@apple.com>
1420
1421         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
1422         https://bugs.webkit.org/show_bug.cgi?id=194411
1423         <rdar://problem/47787614>
1424
1425         Reviewed by Joseph Pecoraro.
1426
1427         Remove unnecessary soft linking macro usage.
1428
1429         * DumpRenderTree/mac/TestRunnerMac.mm:
1430         (TestRunner::inspectorTestStubURL):
1431         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
1432         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1433         (WTR::TestRunner::inspectorTestStubURL):
1434
1435 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
1436
1437         [ews-app] status bubble should fetch builder name info from BuilderMapping table
1438         https://bugs.webkit.org/show_bug.cgi?id=194599
1439
1440         Reviewed by Lucas Forschler.
1441
1442         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1443         (StatusBubble._build_bubble):
1444
1445 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
1446
1447         [ews-app] Set Foreign Key in Django build model
1448         https://bugs.webkit.org/show_bug.cgi?id=194667
1449
1450         Reviewed by Lucas Forschler.
1451
1452         * BuildSlaveSupport/ews-app/ews/models/build.py:
1453         (Build):
1454
1455 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
1456
1457         [WTF] Add environment variable helpers
1458         https://bugs.webkit.org/show_bug.cgi?id=192405
1459
1460         Reviewed by Michael Catanzaro.
1461
1462         * DumpRenderTree/mac/DumpRenderTree.mm:
1463         (libraryPathForDumpRenderTree):
1464         * DumpRenderTree/win/DumpRenderTree.cpp:
1465         (libraryPathForDumpRenderTree):
1466         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
1467         (setUpIOSLayoutTestCommunication):
1468         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
1469         (TestWebKitAPI::strip):
1470         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1471         (beforeAll):
1472         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1473         (main):
1474         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1475         (WebKitTestBus::run):
1476         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1477         (WTR::getOutputDir):
1478         (WTR::initializeFontConfigSetting):
1479         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
1480         (WTR::InjectedBundle::platformInitialize):
1481         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1482         (WTR::topLevelPath):
1483         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
1484         (WTR::topLevelPath):
1485         (WTR::getOutputDir):
1486         (WTR::activateFonts):
1487         * WebKitTestRunner/TestController.cpp:
1488         (WTR::TestController::libraryPathForTesting):
1489         (WTR::TestController::generateContextConfiguration const):
1490         (WTR::TestController::generatePageConfiguration):
1491         (WTR::TestController::decideDestinationWithSuggestedFilename):
1492         (WTR::TestController::platformAdjustContext):
1493         * WebKitTestRunner/TestController.h:
1494         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1495         (WTR::TestController::cocoaPlatformInitialize):
1496         (WTR::TestController::platformAdjustContext):
1497         * WebKitTestRunner/gtk/main.cpp:
1498         (main):
1499         * WebKitTestRunner/mac/TestControllerMac.mm:
1500         (WTR::TestController::configureContentExtensionForTest):
1501         * WebKitTestRunner/wpe/main.cpp:
1502         (main):
1503         Utilize WTF::Environment where possible.
1504
1505 2019-02-14  Chris Dumez  <cdumez@apple.com>
1506
1507         [PSON] Introduce a WebContent Process cache
1508         https://bugs.webkit.org/show_bug.cgi?id=194594
1509         <rdar://problem/46793397>
1510
1511         Reviewed by Geoff Garen.
1512
1513         Update API tests to turn on the WebContent Process cache.
1514
1515         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1516
1517 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
1518
1519         Unreviewed, build fix after r241480
1520
1521         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1522         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
1523         (-[DragAndDropSimulator initWithWebView:]):
1524
1525 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
1526
1527         AX: ARIA Reflection was disabled in error
1528         https://bugs.webkit.org/show_bug.cgi?id=194647
1529         <rdar://problem/48068336>
1530
1531         Reviewed by Ryosuke Niwa.
1532
1533         Remove test override now that this feature should be enabled by default.
1534
1535         * WebKitTestRunner/TestController.cpp:
1536         (WTR::TestController::resetPreferencesToConsistentValues):
1537
1538 2019-02-14  Commit Queue  <commit-queue@webkit.org>
1539
1540         Unreviewed, rolling out r241486.
1541         https://bugs.webkit.org/show_bug.cgi?id=194655
1542
1543         causing API failures in builds (Requested by ShawnRoberts on
1544         #webkit).
1545
1546         Reverted changeset:
1547
1548         "[Cocoa] Media elements will restart network buffering just
1549         before suspending"
1550         https://bugs.webkit.org/show_bug.cgi?id=193691
1551         https://trac.webkit.org/changeset/241486
1552
1553 2019-02-14  Zalan Bujtas  <zalan@apple.com>
1554
1555         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
1556         https://bugs.webkit.org/show_bug.cgi?id=194622
1557
1558         Reviewed by Antti Koivisto.
1559
1560         * LayoutReloaded/misc/LFC-passing-tests.txt:
1561
1562 2019-02-14  Zalan Bujtas  <zalan@apple.com>
1563
1564         [LFC] Shrink-to-fit-width should be constrained by min/max width
1565         https://bugs.webkit.org/show_bug.cgi?id=194653
1566
1567         Reviewed by Antti Koivisto.
1568
1569         * LayoutReloaded/misc/LFC-passing-tests.txt:
1570
1571 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
1572
1573         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
1574         https://bugs.webkit.org/show_bug.cgi?id=194641
1575
1576         Reviewed by Geoffrey Garen.
1577
1578         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
1579         so that the test would fail without this fix.
1580
1581         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
1582         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
1583
1584 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1585
1586         [ews-app] Change log level for a log statement
1587
1588         Unreviewed minor fix.
1589
1590         * BuildSlaveSupport/ews-app/ews/models/patch.py:
1591         (Patch.save_patch):
1592
1593 2019-02-13  Jer Noble  <jer.noble@apple.com>
1594
1595         [Cocoa] Media elements will restart network buffering just before suspending
1596         https://bugs.webkit.org/show_bug.cgi?id=193691
1597
1598         Reviewed by Eric Carlson.
1599
1600         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1601         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
1602         (TEST):
1603
1604 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1605
1606         [ews-app] Fetch builder id to name mapping
1607         https://bugs.webkit.org/show_bug.cgi?id=194355
1608
1609         Reviewed by Lucas Forschler.
1610
1611         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
1612         (Buildbot.get_builder_id_to_name_mapping):
1613         (Buildbot._get_display_name_from_builder_name):
1614
1615 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
1616
1617         Further restricting webarchive loads
1618         https://bugs.webkit.org/show_bug.cgi?id=194567
1619         <rdar://problem/47610130>
1620
1621         Reviewed by Youenn Fablet.
1622
1623         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
1624         navigations on drop.
1625
1626         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1627         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
1628         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
1629         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
1630         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1631         (TestWebKitAPI::TEST):
1632         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
1633         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
1634         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
1635         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1636         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
1637         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
1638         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
1639
1640 2019-02-13  John Wilander  <wilander@apple.com>
1641
1642         Store Ad Click Attribution requests in the network process
1643         https://bugs.webkit.org/show_bug.cgi?id=194510
1644         <rdar://problem/47650118>
1645
1646         Reviewed by Alex Christensen and Daniel Bates.
1647
1648         This patch adds two TestRunner functions:
1649         - dumpAdClickAttribution()
1650         - clearAdClickAttribution()
1651
1652         They call into the network process to dump and clear Ad Click
1653         Attribution state, respectively.
1654
1655         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1656         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1657         (WTR::TestRunner::dumpAdClickAttribution):
1658         (WTR::TestRunner::clearAdClickAttribution):
1659         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1660         * WebKitTestRunner/TestController.cpp:
1661         (WTR::TestController::resetStateToConsistentValues):
1662         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
1663         (WTR::adClickAttributionStringResultCallback):
1664         (WTR::TestController::dumpAdClickAttribution):
1665         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
1666         (WTR::adClickAttributionVoidCallback):
1667         (WTR::TestController::clearAdClickAttribution):
1668         * WebKitTestRunner/TestController.h:
1669         * WebKitTestRunner/TestInvocation.cpp:
1670         (WTR::TestInvocation::dumpResults):
1671         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1672         (WTR::TestInvocation::dumpAdClickAttribution):
1673         * WebKitTestRunner/TestInvocation.h:
1674
1675 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1676
1677         [ews-app] Generate status-bubble
1678         https://bugs.webkit.org/show_bug.cgi?id=194572
1679
1680         Reviewed by Lucas Forschler.
1681
1682         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1683         (StatusBubble._build_bubble):
1684         (StatusBubble._should_show_bubble_for):
1685         (StatusBubble._build_bubbles_for_patch):
1686
1687 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1688
1689         [ews-app] Add status bubble html template
1690         https://bugs.webkit.org/show_bug.cgi?id=194571
1691
1692         Reviewed by Lucas Forschler.
1693
1694         * BuildSlaveSupport/ews-app/ews/templates: Added.
1695         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
1696
1697 2019-02-12  Chris Dumez  <cdumez@apple.com>
1698
1699         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
1700         https://bugs.webkit.org/show_bug.cgi?id=194568
1701         <rdar://problem/47944490>
1702
1703         Reviewed by Ryosuke Niwa.
1704
1705         Add API test coverage.
1706
1707         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1708         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
1709
1710 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
1711
1712         webkitpy: Remove bug_dummy from parsed test expectations
1713         https://bugs.webkit.org/show_bug.cgi?id=194562
1714         <rdar://problem/47853999>
1715
1716         Reviewed by Lucas Forschler.
1717
1718         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1719         (TestExpectationParser):
1720         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
1721         skipped tests.
1722         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1723
1724 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
1725
1726         [ews-app] Add method to fetch patch
1727         https://bugs.webkit.org/show_bug.cgi?id=194518
1728
1729         Reviewed by Lucas Forschler.
1730
1731         * BuildSlaveSupport/ews-app/ews/models/patch.py:
1732         (Patch.get_patch):
1733
1734 2019-02-12  Zalan Bujtas  <zalan@apple.com>
1735
1736         [LFC] Expand tests coverage (60 new tests -> 860)
1737
1738         Unreviewed test gardening (run-singly, --child-processes=1).
1739
1740         * LayoutReloaded/misc/LFC-passing-tests.txt:
1741
1742 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1743
1744         Allow pages to trigger programmatic paste from script on iOS
1745         https://bugs.webkit.org/show_bug.cgi?id=194271
1746         <rdar://problem/47808810>
1747
1748         Reviewed by Tim Horton.
1749
1750         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
1751
1752         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1753         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1754         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1755         (WTR::UIScriptController::rectForMenuAction const):
1756
1757         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
1758         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
1759         for when the menu is shown or hidden.
1760
1761         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1762         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1763         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1764         (WTR::UIScriptController::setDidShowMenuCallback):
1765         (WTR::UIScriptController::didShowMenuCallback const):
1766         (WTR::UIScriptController::setDidHideMenuCallback):
1767         (WTR::UIScriptController::didHideMenuCallback const):
1768         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1769         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1770         (WTR::UIScriptController::rectForMenuAction const):
1771         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1772         * WebKitTestRunner/TestController.cpp:
1773         (WTR::TestController::resetPreferencesToConsistentValues):
1774         (WTR::updateTestOptionsFromTestHeader):
1775         * WebKitTestRunner/TestOptions.h:
1776
1777         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
1778         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
1779
1780         (WTR::TestOptions::hasSameInitializationOptions const):
1781         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1782         (WTR::UIScriptController::calendarType const):
1783         (WTR::UIScriptController::platformUndoManager const):
1784         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1785         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1786         (-[TestRunnerWKWebView initWithFrame:configuration:]):
1787         (-[TestRunnerWKWebView dealloc]):
1788         (-[TestRunnerWKWebView _didShowMenu]):
1789         (-[TestRunnerWKWebView _didHideMenu]):
1790
1791         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
1792
1793         * WebKitTestRunner/ios/TestControllerIOS.mm:
1794         (WTR::handleMenuWillHideNotification):
1795         (WTR::handleMenuDidHideNotification):
1796         (WTR::TestController::platformInitialize):
1797         (WTR::TestController::platformDestroy):
1798         (WTR::TestController::platformResetStateToConsistentValues):
1799
1800         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
1801         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
1802
1803         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1804         (WTR::forEachViewInHierarchy):
1805         (WTR::findViewInHierarchyOfType):
1806
1807         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
1808         functions that dig through a given view's hierarchy in search of a view of a given class.
1809
1810         (WTR::UIScriptController::selectionStartGrabberViewRect const):
1811         (WTR::UIScriptController::selectionEndGrabberViewRect const):
1812         (WTR::UIScriptController::selectionCaretViewRect const):
1813         (WTR::UIScriptController::selectionRangeViewRects const):
1814         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1815         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1816
1817         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
1818
1819         (WTR::UIScriptController::rectForMenuAction const):
1820
1821         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
1822         callout bar) whose label matches the given string.
1823
1824         (WTR::UIScriptController::platformContentView const):
1825
1826         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
1827         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
1828         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
1829
1830         (WTR::UIScriptController::platformUndoManager const): Deleted.
1831         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1832         (WTR::UIScriptController::platformContentView const):
1833         (WTR::UIScriptController::platformUndoManager const): Deleted.
1834
1835 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
1836
1837         webkitpy: No option to only show unexpected failures in results.html for iPad
1838         https://bugs.webkit.org/show_bug.cgi?id=194554
1839         <rdar://problem/47922442>
1840
1841         Rubber-stamped by Aakash Jain.
1842
1843         Just because a TestExpecations file does not exist for a specific platform does not mean that
1844         TestExpecations are not being used, given that platforms inherit test expectations.
1845
1846         * Scripts/webkitpy/port/base.py:
1847         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
1848         * Scripts/webkitpy/port/base_unittest.py:
1849         (PortTest.test_uses_test_expectations_file):
1850
1851 2019-02-12  Alex Christensen  <achristensen@webkit.org>
1852
1853         Remove setDefersLoading infrastructure from WebKit2
1854         https://bugs.webkit.org/show_bug.cgi?id=194506
1855
1856         Reviewed by Brady Eidson.
1857
1858         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1859         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1860         (WTR::TestRunner::setDefersLoading): Deleted.
1861         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1862
1863 2019-02-12  Alex Christensen  <achristensen@webkit.org>
1864
1865         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
1866         https://bugs.webkit.org/show_bug.cgi?id=194522
1867         <rdar://problem/47789393>
1868
1869         Reviewed by Chris Dumez.
1870
1871         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1872         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
1873         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1874         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1875
1876 2019-02-12  Andy Estes  <aestes@apple.com>
1877
1878         [iOSMac] Enable Parental Controls Content Filtering
1879         https://bugs.webkit.org/show_bug.cgi?id=194521
1880         <rdar://39732376>
1881
1882         Reviewed by Tim Horton.
1883
1884         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1885
1886 2019-02-12  Zalan Bujtas  <zalan@apple.com>
1887
1888         [LFC][IFC] Add intrinsic width support for float boxes.
1889         https://bugs.webkit.org/show_bug.cgi?id=194528
1890
1891         Reviewed by Antti Koivisto.
1892
1893         Expand tests coverage (2 new tests -> 800).
1894         (This is the correct test ordering --runs-singly --child-processes=1)
1895
1896         * LayoutReloaded/misc/LFC-passing-tests.txt:
1897
1898 2019-02-12  Rob Buis  <rbuis@igalia.com>
1899
1900         Implement serializing in MIME type parser
1901         https://bugs.webkit.org/show_bug.cgi?id=193909
1902
1903         Reviewed by Darin Adler.
1904
1905         Add various tests involving upper case, non-ASCII, control/null characters,
1906         various HTTP whitespace, single quotes and an unpaired surrogate.
1907
1908         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1909         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
1910         (TestWebKitAPI::serializeIfValid):
1911         (TestWebKitAPI::TEST):
1912
1913 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
1914
1915         [Cocoa] Ask platform for generic font family mappings
1916         https://bugs.webkit.org/show_bug.cgi?id=187723
1917         <rdar://problem/41892438>
1918
1919         Reviewed by Brent Fulgham.
1920
1921         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
1922
1923         * DumpRenderTree/mac/DumpRenderTree.mm:
1924         (allowedFontFamilySet):
1925         * WebKitTestRunner/mac/TestControllerMac.mm:
1926         (WTR::allowedFontFamilySet):
1927
1928 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
1929
1930         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
1931         https://bugs.webkit.org/show_bug.cgi?id=193622
1932
1933         Reviewed by Michael Catanzaro.
1934
1935         This adds support for loading content extension rule sets from the JSON files which
1936         accompany the corresponding layout test, using the C API. The Cocoa specific parts
1937         of WKTR for this could be removed, but that is left for a follow-up patch with
1938         cleanups.
1939
1940         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
1941         * WebKitTestRunner/TestController.cpp:
1942         (WTR::testPath): Subtract one from the length when constructing the result std::string to
1943         avoid having the null-terminator copied into the result.
1944         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
1945         part of the preparations to run a test.
1946         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
1947         (WTR::contentExtensionStoreCallback): Added.
1948         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
1949         used for content extensions test.
1950         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
1951         extensions and compiling the JSON rule set for tests involving content extensions.
1952         (WTR::TestController::resetContentExtensions): Removes the content extension built for
1953         testing and disables content extensions.
1954         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
1955         resetContentExtensions().
1956         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
1957         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
1958         configureContentExtensionForTest(), and userContentController().
1959
1960 2019-02-11  Daniel Bates  <dabates@apple.com>
1961
1962         [iOS] Mouse/Touch/Pointer events are missing modifier keys
1963         https://bugs.webkit.org/show_bug.cgi?id=191446
1964         <rdar://problem/45929460>
1965
1966         Reviewed by Tim Horton.
1967
1968         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
1969
1970         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1971         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1972         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1973         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1974         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1975         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1976         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1977         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1978         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1979         (WTR::arrayLength):
1980         (WTR::parseModifierArray):
1981         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
1982         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1983         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
1984         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1985
1986 2019-02-11  Commit Queue  <commit-queue@webkit.org>
1987
1988         Unreviewed, rolling out r241272 and r241276.
1989         https://bugs.webkit.org/show_bug.cgi?id=194514
1990
1991         Broke the Apple Internal build and the fix requires human
1992         intervention :( (Requested by dydz on #webkit).
1993
1994         Reverted changesets:
1995
1996         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
1997         https://bugs.webkit.org/show_bug.cgi?id=191446
1998         https://trac.webkit.org/changeset/241272
1999
2000         "Fix internal iOS build after r241272"
2001         https://bugs.webkit.org/show_bug.cgi?id=191446
2002         https://trac.webkit.org/changeset/241276
2003
2004 2019-02-11  Truitt Savell  <tsavell@apple.com>
2005
2006         Unreviewed, rolling out r241269.
2007
2008         Caused 5 layout tests crashes on Mac WK1
2009
2010         Reverted changeset:
2011
2012         "DumpRenderTree should report unknown options"
2013         https://bugs.webkit.org/show_bug.cgi?id=191303
2014         https://trac.webkit.org/changeset/241269
2015
2016 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2017
2018         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
2019         https://bugs.webkit.org/show_bug.cgi?id=194313
2020
2021         Reviewed by Tim Horton.
2022
2023         Add a helper to determine whether the web view is presenting modal UI.
2024
2025         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2026         (WTR::UIScriptController::isPresentingModally const):
2027         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2028         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2029         (WTR::UIScriptController::isPresentingModally const):
2030         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2031         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2032         (WTR::UIScriptController::calendarType const): Deleted.
2033         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2034         (WTR::UIScriptController::isPresentingModally const):
2035         (WTR::UIScriptController::calendarType const):
2036         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2037         (WTR::UIScriptController::calendarType const):
2038
2039 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
2040
2041         GCHeapInspector: Show the retained sizes in more places
2042         https://bugs.webkit.org/show_bug.cgi?id=194464
2043
2044         Reviewed by Simon Fraser.
2045
2046         * GCHeapInspector/gc-heap-inspector.html:
2047         * GCHeapInspector/script/interface.js:
2048         (HeapInspectorUtils.humanReadableSize):
2049         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
2050         (HeapInspectorUtils.spanForNode.span.span):
2051         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
2052         (HeapSnapshotInspector.prototype.buildRoots):
2053
2054 2019-02-11  Daniel Bates  <dabates@apple.com>
2055
2056         [iOS] Mouse/Touch/Pointer events are missing modifier keys
2057         https://bugs.webkit.org/show_bug.cgi?id=191446
2058         <rdar://problem/45929460>
2059
2060         Reviewed by Tim Horton.
2061
2062         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
2063
2064         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2065         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2066         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2067         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2068         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2069         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2070         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2071         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2072         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2073         (WTR::arrayLength):
2074         (WTR::parseModifierArray):
2075         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
2076         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2077         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
2078         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2079
2080 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
2081
2082         DumpRenderTree should report unknown options
2083         https://bugs.webkit.org/show_bug.cgi?id=191303
2084
2085         Reviewed by Frédéric Wang.
2086
2087         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
2088         to report unknown options.
2089         Added and assigned test options which are currently used in tests.
2090
2091         * DumpRenderTree/TestOptions.cpp:
2092         (TestOptions::TestOptions):
2093
2094 2019-02-11  Truitt Savell  <tsavell@apple.com>
2095
2096         Unreviewed, rolling out r241229.
2097
2098         Revision broke internal builds for watchOS.
2099
2100         Reverted changeset:
2101
2102         "[Cocoa] Ask platform for generic font family mappings"
2103         https://bugs.webkit.org/show_bug.cgi?id=187723
2104         https://trac.webkit.org/changeset/241229
2105
2106 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
2107
2108         [WinCairo][MiniBrowser] Basic authentication always fails.
2109         https://bugs.webkit.org/show_bug.cgi?id=194496
2110
2111         Reviewed by Don Olmstead.
2112
2113         * MiniBrowser/win/DialogHelper.h:
2114         (Dialog::getText):
2115
2116 2019-02-11  Philippe Normand  <pnormand@igalia.com>
2117
2118         [GStreamer] GstMappedBuffer testsuite build fails
2119         https://bugs.webkit.org/show_bug.cgi?id=194495
2120
2121         Reviewed by Carlos Garcia Campos.
2122
2123         Fix the build by explicitely adding the gstreamer1.0-audio include
2124         directories to the include path.
2125
2126         * TestWebKitAPI/PlatformGTK.cmake:
2127         * TestWebKitAPI/PlatformWPE.cmake:
2128
2129 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2130
2131         [GTK][WPE] Add enable-javascript-markup setting
2132         https://bugs.webkit.org/show_bug.cgi?id=193439
2133
2134         Reviewed by Michael Catanzaro.
2135
2136         Add test cases to check the new setting.
2137
2138         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2139         (testWebKitSettings):
2140         (testWebKitSettingsJavaScriptMarkup):
2141         (beforeAll):
2142
2143 2019-02-10  Darin Adler  <darin@apple.com>
2144
2145         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
2146         https://bugs.webkit.org/show_bug.cgi?id=194485
2147
2148         Reviewed by Daniel Bates.
2149
2150         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
2151
2152 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
2153
2154         Add more tests for clampTo<>()
2155         https://bugs.webkit.org/show_bug.cgi?id=194462
2156
2157         Reviewed by Geoffrey Garen.
2158
2159         Darin suggested to test the very last floating point number
2160         at the boundaries when truncating to integer.
2161         I added test for max/min and max-1/min-1.
2162
2163         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2164         (TestWebKitAPI::TEST):
2165
2166 2019-02-09  Darin Adler  <darin@apple.com>
2167
2168         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
2169         https://bugs.webkit.org/show_bug.cgi?id=194021
2170
2171         Reviewed by Geoffrey Garen.
2172
2173         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
2174         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
2175         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
2176
2177 2019-02-09  Zalan Bujtas  <zalan@apple.com>
2178
2179         [LFC][IFC] Add intrinsic width support for basic inline containers
2180         https://bugs.webkit.org/show_bug.cgi?id=194473
2181
2182         Reviewed by Antti Koivisto.
2183
2184         Expand tests coverage (11 new tests -> 798)
2185
2186         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
2187
2188 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
2189
2190         Fix MiniBrowser's entitlements
2191         https://bugs.webkit.org/show_bug.cgi?id=192431
2192
2193         Reviewed by Joseph Pecoraro.
2194
2195         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
2196         files, making it impossible to load any extension.
2197
2198         * MiniBrowser/MiniBrowser.entitlements:
2199
2200 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
2201
2202         [Cocoa] Ask platform for generic font family mappings
2203         https://bugs.webkit.org/show_bug.cgi?id=187723
2204         <rdar://problem/41892438>
2205
2206         Reviewed by Brent Fulgham.
2207
2208         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
2209
2210         * DumpRenderTree/mac/DumpRenderTree.mm:
2211         (allowedFontFamilySet):
2212         * WebKitTestRunner/mac/TestControllerMac.mm:
2213         (WTR::allowedFontFamilySet):
2214
2215 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
2216
2217         [GTK] Implement back/forward touchpad gesture
2218         https://bugs.webkit.org/show_bug.cgi?id=193919
2219
2220         Reviewed by Michael Catanzaro.
2221
2222         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2223         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
2224
2225 2019-02-08  Alex Christensen  <achristensen@webkit.org>
2226
2227         Add SPI to use networking daemon instead of XPC service
2228         https://bugs.webkit.org/show_bug.cgi?id=194427
2229
2230         Reviewed by Geoffrey Garen
2231
2232         * MiniBrowser/MiniBrowser.entitlements:
2233
2234 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
2235
2236         [ews-build] Ensure that every builder in config.json has short name
2237         https://bugs.webkit.org/show_bug.cgi?id=194461
2238
2239         Reviewed by Lucas Forschler.
2240
2241         * BuildSlaveSupport/ews-build/loadConfig.py:
2242         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
2243
2244 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
2245
2246         [ews-build] Add short name to config.json
2247         https://bugs.webkit.org/show_bug.cgi?id=194456
2248
2249         Reviewed by Lucas Forschler.
2250
2251         * BuildSlaveSupport/ews-build/config.json: Added short name.
2252         * BuildSlaveSupport/ews-build/loadConfig.py:
2253         (loadBuilderConfig): Set the short name as the builder description.
2254
2255 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
2256
2257         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
2258         https://bugs.webkit.org/show_bug.cgi?id=194418
2259
2260         Reviewed by Lucas Forschler.
2261
2262         Do not include errors trying when finding crashlogs at the end of
2263         a run-webkit-tests run since we don't process those errors.
2264
2265         * Scripts/webkitpy/port/darwin.py:
2266         (DarwinPort._look_for_all_crash_logs_in_log_dir):
2267         * Scripts/webkitpy/port/ios_device.py:
2268         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
2269         * Scripts/webkitpy/port/watch_device.py:
2270         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
2271
2272 2019-02-08  Beth Dakin  <bdakin@apple.com>
2273
2274         Add afterScreenUpdates to WKSnapshotConfiguration
2275         https://bugs.webkit.org/show_bug.cgi?id=194362
2276         -and corresponding-
2277         <rdar://problem/40655528> Please add an "after screen updates" property to 
2278         WKSnapshotConfiguration (to solve blank snapshots)
2279
2280         Reviewed by Tim Horton.
2281
2282         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
2283         (TEST):
2284
2285 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
2286
2287         clampTo(): do not convert the input to double when dealing with integers
2288         https://bugs.webkit.org/show_bug.cgi?id=194263
2289         <rdar://problem/47692312>
2290
2291         Reviewed by Darin Adler.
2292
2293         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2294         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
2295         (TestWebKitAPI::testClampFloatingPointToInteger):
2296         (TestWebKitAPI::testClampSameSignIntegers):
2297         (TestWebKitAPI::testClampUnsignedToSigned):
2298         (TestWebKitAPI::testClampSignedToUnsigned):
2299
2300 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
2301
2302         webkitpy: Respect --dedicated-simulators flag
2303         https://bugs.webkit.org/show_bug.cgi?id=194416
2304         <rdar://problem/47894722>
2305
2306         Reviewed by Lucas Forschler.
2307
2308         * Scripts/webkitpy/port/device_port.py:
2309         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
2310         available devices can be safely ignored.
2311
2312 2019-02-07  Keith Rollin  <krollin@apple.com>
2313
2314         Remove extra copy of 100x100-red.tga
2315         https://bugs.webkit.org/show_bug.cgi?id=194371
2316         <rdar://problem/47873465>
2317
2318         Reviewed by Said Abou-Hallawa.
2319
2320         In order to help it pass its tests, Bug 194190 added a second copy of
2321         the file 100x100-red.tga. However, it turns out that this additional
2322         file wasn't actually needed, and that that sole previous copy was
2323         sufficient. At the same time, this second copy -- which was copied to
2324         the same location in the build output as the first copy -- now caused
2325         XCBuild to complain because there were two production rules for the
2326         same output file. Address this by removing the newly-added extra copy.
2327
2328         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2329         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
2330
2331 2019-02-07  Alex Christensen  <achristensen@webkit.org>
2332
2333         Deprecate WKBundlePageSetDefersLoading
2334         https://bugs.webkit.org/show_bug.cgi?id=191394
2335
2336         Reviewed by Dean Jackson.
2337
2338         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2339         (WTR::TestRunner::setDefersLoading):
2340
2341 2019-02-07  Zalan Bujtas  <zalan@apple.com>
2342
2343         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
2344         https://bugs.webkit.org/show_bug.cgi?id=194391
2345
2346         Reviewed by Antti Koivisto.
2347
2348         * LayoutReloaded/misc/LFC-passing-tests.txt:
2349
2350 2019-02-06  Keith Rollin  <krollin@apple.com>
2351
2352         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
2353         https://bugs.webkit.org/show_bug.cgi?id=193975
2354         <rdar://problem/47643306>
2355
2356         Reviewed by Tim Horton.
2357
2358         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
2359         the Info.plist file into the bundle. This step is not necessary as the
2360         implicit "bundle up all the build products into a framework" build
2361         phase does this already. Having the Copy Bundle Resources phase do
2362         this causes a conflict under XCBuild, which objects to two build
2363         phases producing the same file (Info.plist). Address this by removing
2364         Info.plist from the Copy Bundle Resources phase.
2365
2366         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
2367
2368 2019-02-06  Keith Rollin  <krollin@apple.com>
2369
2370         Really enable the automatic checking and regenerations of .xcfilelists during builds
2371         https://bugs.webkit.org/show_bug.cgi?id=194357
2372         <rdar://problem/47861231>
2373
2374         Reviewed by Chris Dumez.
2375
2376         Bug 194124 was supposed to enable the automatic checking and
2377         regenerating of .xcfilelist files during the build. While related
2378         changes were included in that patch, the change to actually enable the
2379         operation somehow was omitted. This patch actually enables the
2380         operation. The check-xcfilelist.sh scripts now check
2381         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
2382         from the checking.
2383
2384         * DumpRenderTree/Scripts/check-xcfilelists.sh:
2385         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
2386
2387 2019-02-06  David Kilzer  <ddkilzer@apple.com>
2388
2389         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
2390         <https://webkit.org/b/194286>
2391         <rdar://problem/47815558>
2392
2393         Reviewed by Alexey Proskuryakov.
2394
2395         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2396         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
2397         WKRetainPtr<> to avoid leaking the WKDataRef.
2398
2399 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
2400
2401         Unreviewed, fix a typo
2402
2403         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2404
2405 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
2406
2407         [GTK][WPE] force libpsl build to use ICU in jhbuild
2408         https://bugs.webkit.org/show_bug.cgi?id=194288
2409
2410         Reviewed by Carlos Garcia Campos.
2411
2412         * gtk/jhbuild.modules:
2413         Require ICU for libpsl build in jhbuild, like done in WPE.
2414
2415 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
2416
2417         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
2418         https://bugs.webkit.org/show_bug.cgi?id=194209
2419
2420         Reviewed by Carlos Garcia Campos.
2421
2422         Enhance TestCookieManager to ensure this doesn't happen again.
2423
2424         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2425         (testCookieManagerPersistentStorage):
2426         (beforeAll):
2427
2428 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2429
2430         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
2431         https://bugs.webkit.org/show_bug.cgi?id=194324
2432
2433         Reviewed by Andy Estes.
2434
2435         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
2436         part of the name is already implicit, since this is in testing code in TestOptions.
2437
2438         * WebKitTestRunner/TestController.cpp:
2439         (WTR::TestController::generateContextConfiguration const):
2440         (WTR::updateTestOptionsFromTestHeader):
2441         * WebKitTestRunner/TestOptions.h:
2442         (WTR::TestOptions::hasSameInitializationOptions const):
2443
2444 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2445
2446         [ews-build] Allow * as platform for builders and workers
2447         https://bugs.webkit.org/show_bug.cgi?id=188533
2448
2449         Reviewed by Lucas Forschler.
2450
2451         * BuildSlaveSupport/ews-build/loadConfig.py:
2452         (checkWorkersAndBuildersForConsistency):
2453
2454 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2455
2456         [ews-build] Add few bots to config.json
2457         https://bugs.webkit.org/show_bug.cgi?id=194304
2458
2459         Reviewed by Lucas Forschler.
2460
2461         * BuildSlaveSupport/ews-build/config.json:
2462
2463 2019-02-05  Keith Rollin  <krollin@apple.com>
2464
2465         Enable the automatic checking and regenerations of .xcfilelists during builds
2466         https://bugs.webkit.org/show_bug.cgi?id=194124
2467         <rdar://problem/47721277>
2468
2469         Reviewed by Tim Horton.
2470
2471         Bug 193790 add a facility for checking -- during build time -- that
2472         any needed .xcfilelist files are up-to-date and for updating them if
2473         they are not. This facility was initially opt-in by setting
2474         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
2475         the process seemed robust. Its now time to enable this facility and
2476         make it opt-out. If there is a need to disable this facility, set and
2477         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
2478         running `make` or `build-webkit`, or before running Xcode from the
2479         command line.
2480
2481         Additionally, remove the step that generates a list of source files
2482         going into the UnifiedSources build step. It's only necessarily to
2483         specify Sources.txt and SourcesCocoa.txt as inputs.
2484
2485         * Scripts/generate-xcfilelists:
2486
2487 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
2488
2489         [GTK][WPE] force libpsl build to use ICU in jhbuild
2490         https://bugs.webkit.org/show_bug.cgi?id=194288
2491
2492         Reviewed by Philippe Normand.
2493
2494         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
2495         This can cause build failures if libidn is detected but libunistring is not available.
2496
2497         Make sure that ICU is used for runtime and builtin PSL data.
2498
2499         * gtk/jhbuild.modules:
2500         * wpe/jhbuild.modules:
2501
2502 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2503
2504         [ews-app] Modified timestamp should be updated on updating data
2505         https://bugs.webkit.org/show_bug.cgi?id=194295
2506
2507         Reviewed by Lucas Forschler.
2508
2509         * BuildSlaveSupport/ews-app/ews/models/build.py:
2510         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2511         * BuildSlaveSupport/ews-app/ews/models/step.py:
2512
2513 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
2514
2515         Unreviewed, rolling out r240742.
2516
2517         Causes crashes on iOS simulator.
2518
2519         Reverted changeset:
2520
2521         "[iOS] Keyups for non-modifier keys identified as "Dead" when
2522         not focused in a content-editable element"
2523         https://bugs.webkit.org/show_bug.cgi?id=192824
2524         https://trac.webkit.org/changeset/240742
2525
2526 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
2527
2528         run-webkit-tests emits message "...running None" when running tests
2529         https://bugs.webkit.org/show_bug.cgi?id=194133
2530         <rdar://problem/47724738>
2531
2532         Reviewed by Lucas Forschler.
2533
2534         * Scripts/webkitpy/xcode/device_type.py:
2535         (DeviceType.__str__): Use both version mapping tables and use just the variant
2536         name if no version name is available.
2537         * Scripts/webkitpy/xcode/device_type_unittest.py:
2538         (DeviceTypeTest):
2539         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
2540         an associated named.
2541
2542 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
2543
2544         [WPE] require python3-setuptools for meson build in jhbuild
2545         https://bugs.webkit.org/show_bug.cgi?id=194287
2546
2547         Reviewed by Philippe Normand.
2548
2549         python3-setuptools is needed to build meson in jhbuild.
2550         It is already required by the GTK port.
2551
2552         * wpe/install-dependencies:
2553
2554 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2555
2556         [ews-app] Add method to save BuilderMapping to database
2557         https://bugs.webkit.org/show_bug.cgi?id=194264
2558
2559         Reviewed by Lucas Forschler.
2560
2561         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2562         (BuilderMapping.__str__):
2563         (BuilderMapping):
2564         (BuilderMapping.save_mapping):
2565         (BuilderMapping.update_mapping):
2566         (BuilderMapping.get_existing_mapping):
2567         (BuilderMapping.is_valid_mapping):
2568
2569 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2570
2571         [ews-app] Add timestamp fields for BuilderMappings
2572         https://bugs.webkit.org/show_bug.cgi?id=194266
2573
2574         Reviewed by Lucas Forschler.
2575
2576         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2577         (BuilderMapping):
2578
2579 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
2580
2581         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
2582         https://bugs.webkit.org/show_bug.cgi?id=174816
2583
2584         Reviewed by Michael Catanzaro.
2585
2586         Add tests for webkit_uri_for_display().
2587
2588         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
2589         (testURIForDisplayUnaffected):
2590         (testURIForDisplayAffected):
2591         (beforeAll):
2592         (afterAll):
2593         * TestWebKitAPI/glib/CMakeLists.txt:
2594
2595 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
2596
2597         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
2598         https://bugs.webkit.org/show_bug.cgi?id=194158
2599         <rdar://problem/47737268>
2600
2601         Rubber-stamped by Aakash Jain.
2602
2603         * Scripts/webkitpy/port/device_port.py:
2604         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
2605
2606 2019-02-04  Said Abou-Hallawa  <said@apple.com>
2607
2608         [CG] Enable setAdditionalSupportedImageTypes for WK1
2609         https://bugs.webkit.org/show_bug.cgi?id=194190
2610
2611         Reviewed by Tim Horton.
2612
2613         Add a test similar to the one under WebKit Cocoa but make it create a
2614         WebView instead of a WKWebView.
2615
2616         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2617         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
2618         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
2619         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
2620         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
2621         (TestWebKitAPI::runTest):
2622         (TestWebKitAPI::TEST):
2623
2624 2019-02-04  Zalan Bujtas  <zalan@apple.com>
2625
2626         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
2627         https://bugs.webkit.org/show_bug.cgi?id=194168
2628
2629         Reviewed by Simon Fraser.
2630
2631         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
2632
2633         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2634         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
2635         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
2636         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
2637         (TEST):
2638         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
2639         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
2640
2641 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
2642
2643         REGRESSION (r237269): webkit-patch what-broke is broken 
2644         https://bugs.webkit.org/show_bug.cgi?id=193025
2645
2646         Reviewed by Aakash Jain.
2647
2648         * Scripts/webkitpy/common/host.py:
2649         (Host.buildbot):
2650         (Host.bugzilla): Renamed to 'buildbot'.
2651
2652 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2653
2654         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
2655         https://bugs.webkit.org/show_bug.cgi?id=194207
2656
2657         Reviewed by Tim Horton.
2658
2659         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
2660         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
2661         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
2662         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
2663         start and delete forwards to remove the original attachment.
2664
2665         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2666         (TestWebKitAPI::TEST):
2667
2668 2019-02-04  Youenn Fablet  <youenn@apple.com>
2669
2670         Capture state should be managed consistently when doing process swapping
2671         https://bugs.webkit.org/show_bug.cgi?id=194122
2672         <rdar://problem/47609293>
2673
2674         Reviewed by Eric Carlson.
2675
2676         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2677         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
2678         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
2679         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
2680         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2681         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2682         (WTR::TestRunner::isDoingMediaCapture const):
2683         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2684         * WebKitTestRunner/TestController.cpp:
2685         (WTR::TestController::isDoingMediaCapture const):
2686         * WebKitTestRunner/TestController.h:
2687         * WebKitTestRunner/TestInvocation.cpp:
2688         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2689         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2690         (WTR::TestController::isDoingMediaCapture const):
2691
2692 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
2693
2694         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
2695         https://bugs.webkit.org/show_bug.cgi?id=194142
2696
2697         Reviewed by Ross Kirsling.
2698
2699         There three 'separator' variables in TestController.cpp. Renamed
2700         it 'pathSeparator', and unified them.
2701
2702         * WebKitTestRunner/TestController.cpp:
2703         (WTR::TestController::generateContextConfiguration const):
2704         (WTR::createTestURL):
2705         (WTR::TestController::platformAdjustContext):
2706
2707 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
2708
2709         Make setNeedsLayout on the root more explicitly about triggering its side-effects
2710         https://bugs.webkit.org/show_bug.cgi?id=194198
2711
2712         Reviewed by Antti Koivisto.
2713
2714         No need to set the banner heights on navigation now, since Page stores them.
2715
2716         * MiniBrowser/mac/WK2BrowserWindowController.m:
2717         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
2718
2719 2019-02-03  John Wilander  <wilander@apple.com>
2720
2721         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
2722         https://bugs.webkit.org/show_bug.cgi?id=194104
2723         <rdar://problem/47649991>
2724
2725         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
2726
2727         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2728         (TestWebKitAPI::TEST):
2729             Changed numeric types from unsigned short to uint32_t.
2730
2731 2019-02-02  David Kilzer  <ddkilzer@apple.com>
2732
2733         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
2734         <https://webkit.org/b/194178>
2735         <rdar://problem/47753473>
2736
2737         Reviewed by Alexey Proskuryakov.
2738
2739         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2740         (WTR::uninstallFakeHelvetica): Pass nullptr into
2741         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
2742
2743 2019-02-02  Zalan Bujtas  <zalan@apple.com>
2744
2745         [LFC] Initialize ICB's style with fixed width/height.
2746         https://bugs.webkit.org/show_bug.cgi?id=194188
2747
2748         Reviewed by Antti Koivisto.
2749
2750         * LayoutReloaded/misc/LFC-passing-tests.txt:
2751
2752 2019-02-02  Zalan Bujtas  <zalan@apple.com>
2753
2754         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
2755         https://bugs.webkit.org/show_bug.cgi?id=194185
2756
2757         Reviewed by Antti Koivisto.
2758
2759         * LayoutReloaded/misc/LFC-passing-tests.txt:
2760
2761 2018-12-16  Darin Adler  <darin@apple.com>
2762
2763         Convert additional String::format clients to alternative approaches
2764         https://bugs.webkit.org/show_bug.cgi?id=192746
2765
2766         Reviewed by Alexey Proskuryakov.
2767
2768         * WebKitTestRunner/TestController.cpp:
2769         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
2770         as an intermediate in code that ultimately constructs a WTF::String.
2771         (WTR::userMediaOriginHash): Use makeString.
2772         (WTR::TestController::didNavigateWithNavigationData): More of the same.
2773         (WTR::TestController::didPerformClientRedirect): Ditto.
2774         (WTR::TestController::didPerformServerRedirect): Ditto.
2775         (WTR::TestController::didUpdateHistoryTitle): Ditto.
2776
2777 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
2778
2779         [ews-build] Add unit test to verify builder keys
2780         https://bugs.webkit.org/show_bug.cgi?id=194152
2781
2782         Reviewed by Lucas Forschler.
2783
2784         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2785         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
2786
2787 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2788
2789         [LFC] Expand tests coverage (12 new tests -> 787)
2790
2791         Unreviewed test gardening.
2792
2793         * LayoutReloaded/misc/LFC-passing-tests.txt:
2794
2795 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2796
2797         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
2798         https://bugs.webkit.org/show_bug.cgi?id=194163
2799
2800         Reviewed by Simon Fraser.
2801
2802         775
2803
2804         * LayoutReloaded/misc/LFC-passing-tests.txt:
2805
2806 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2807
2808         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
2809         https://bugs.webkit.org/show_bug.cgi?id=194140
2810         <rdar://problem/47728098>
2811
2812         Reviewed by Tim Horton.
2813
2814         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2815         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2816         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
2817
2818         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
2819         test to induce an IPC deadlock when presenting a modal alert during touch start.
2820
2821         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2822         * WebKitTestRunner/TestController.cpp:
2823         (WTR::runJavaScriptAlert):
2824
2825         Add a client callback function for running JavaScript alerts.
2826
2827         (WTR::TestController::createOtherPage):
2828         (WTR::TestController::generateContextConfiguration const):
2829
2830         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
2831         the fix in this patch.
2832
2833         (WTR::TestController::createWebViewWithOptions):
2834
2835         Plumb TestOptions to generateContextConfiguration.
2836
2837         (WTR::TestController::resetPreferencesToConsistentValues):
2838         (WTR::TestController::resetStateToConsistentValues):
2839         (WTR::updateTestOptionsFromTestHeader):
2840         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
2841         (WTR::TestController::handleJavaScriptAlert):
2842         * WebKitTestRunner/TestController.h:
2843         * WebKitTestRunner/TestInvocation.cpp:
2844         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2845         * WebKitTestRunner/TestOptions.h:
2846         (WTR::TestOptions::hasSameInitializationOptions const):
2847
2848 2019-02-01  Chris Dumez  <cdumez@apple.com>
2849
2850         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
2851         https://bugs.webkit.org/show_bug.cgi?id=193740
2852         <rdar://problem/47527267>
2853
2854         Reviewed by Alex Christensen.
2855
2856         Add API test coverage.
2857
2858         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2859
2860 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
2861
2862         [ews-app] Add display name field to BuilderMapping model
2863         https://bugs.webkit.org/show_bug.cgi?id=194153
2864
2865         Reviewed by Lucas Forschler.
2866
2867         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2868         (BuilderMapping):
2869
2870 2019-02-01  Youenn Fablet  <youenn@apple.com>
2871
2872         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
2873         https://bugs.webkit.org/show_bug.cgi?id=194155
2874
2875         Reviewed by Eric Carlson.
2876
2877         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
2878         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
2879         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
2880
2881 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2882
2883         [LFC] Adjust replaced element's intrinsic ratio
2884         https://bugs.webkit.org/show_bug.cgi?id=194154
2885
2886         Reviewed by Antti Koivisto.
2887
2888         761
2889
2890         * LayoutReloaded/misc/LFC-passing-tests.txt:
2891
2892 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2893
2894         [WPE] Show test results in minibrowser
2895         https://bugs.webkit.org/show_bug.cgi?id=194150
2896
2897         Reviewed by Žan Doberšek.
2898
2899         * Scripts/webkitpy/port/wpe.py:
2900         (WPEPort.show_results_html_file):
2901
2902 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2903
2904         [WPE] MiniBrowser: add ky bindings for back/forward navigation
2905         https://bugs.webkit.org/show_bug.cgi?id=194151
2906
2907         Reviewed by Žan Doberšek.
2908
2909         ALT + <- go back
2910         ALT + -> go forward
2911
2912         * MiniBrowser/wpe/main.cpp:
2913         (main):
2914
2915 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2916
2917         [LFC] Set intrinsic size on Layout::Replaced
2918         https://bugs.webkit.org/show_bug.cgi?id=194139
2919
2920         Reviewed by Antti Koivisto.
2921
2922         744
2923
2924         * LayoutReloaded/misc/LFC-passing-tests.txt:
2925
2926 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2927
2928         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
2929         https://bugs.webkit.org/show_bug.cgi?id=194146
2930
2931         Reviewed by Xabier Rodriguez-Calvar.
2932
2933         It allows to open relative paths.
2934
2935         * MiniBrowser/wpe/main.cpp:
2936         (main):
2937
2938 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
2939
2940         Update flakiness dashboard configuration after recent queue changes
2941         https://bugs.webkit.org/show_bug.cgi?id=194127
2942
2943         Rubber-stamped by Aakash Jain.
2944
2945         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
2946
2947         * TestResultServer/static-dashboards/builders.jsonp:
2948
2949 2019-01-31  Youenn Fablet  <youenn@apple.com>
2950
2951         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
2952         https://bugs.webkit.org/show_bug.cgi?id=194106
2953         <rdar://problem/47676333>
2954
2955         Reviewed by Ryosuke Niwa.
2956
2957         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2958         (TestWebKitAPI::didFinishNavigation):
2959         (TestWebKitAPI::TEST):
2960         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
2961
2962 2019-01-31  Chris Dumez  <cdumez@apple.com>
2963
2964         Page zoom level is lost after a process swap or a crash
2965         https://bugs.webkit.org/show_bug.cgi?id=194105
2966         <rdar://problem/47610781>
2967
2968         Reviewed by Alex Christensen.
2969
2970         Add API test coverage.
2971
2972         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2973         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
2974
2975 2019-01-31  Alex Christensen  <achristensen@webkit.org>
2976
2977         Revert r238819 which is unneeded and caused a performance regression.
2978         https://bugs.webkit.org/show_bug.cgi?id=192272
2979         <rdar://problem/46664625>
2980
2981         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
2982         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
2983         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
2984
2985 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
2986
2987         Formalize WebKitAdditions mechanism of LoadOptimizer
2988         https://bugs.webkit.org/show_bug.cgi?id=193886
2989         <rdar://problem/47696809>
2990
2991         Reviewed by Brent Fulgham.
2992
2993         * MiniBrowser/MiniBrowser.entitlements:
2994         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
2995
2996 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2997
2998         [LFC] Margin before/after/start/end initial value is 0 and not auto.
2999         https://bugs.webkit.org/show_bug.cgi?id=194090
3000
3001         Reviewed by Antti Koivisto.
3002
3003         * LayoutReloaded/misc/LFC-passing-tests.txt:
3004
3005 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3006
3007         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
3008         https://bugs.webkit.org/show_bug.cgi?id=194074
3009
3010         Reviewed by Antti Koivisto.
3011
3012         * LayoutReloaded/misc/LFC-passing-tests.txt:
3013
3014 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3015
3016         [LFC][BFC] Add support for block level replaced box.
3017         https://bugs.webkit.org/show_bug.cgi?id=194071
3018
3019         Reviewed by Antti Koivisto.
3020
3021         * LayoutReloaded/misc/LFC-passing-tests.txt:
3022
3023 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
3024
3025         Fix WebKitTestRunner's testPath with Windows full paths
3026         https://bugs.webkit.org/show_bug.cgi?id=194012
3027
3028         Reviewed by Alex Christensen.
3029
3030         updateTestOptionsFromTestHeader failed to open test files because
3031         testPath returned wrong file paths. It returned a path "/C:/..."
3032         if a URL "file:///C:/..." was given.
3033
3034         * WebKitTestRunner/TestController.cpp:
3035         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
3036
3037 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3038
3039         [WPE] Bump font related dependencies to match the GTK+ port
3040         https://bugs.webkit.org/show_bug.cgi?id=194017
3041
3042         Reviewed by Žan Doberšek.
3043
3044         * wpe/jhbuild.modules:
3045         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3046         * wpe/patches/icudata-stdlibs.patch: Added.
3047
3048 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
3049
3050         Enable swipe tests on iOS
3051         https://bugs.webkit.org/show_bug.cgi?id=194076
3052
3053         Reviewed by Geoffrey Garen.
3054
3055         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
3056         it causes a debug assertion failure in runUIScript.
3057
3058         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3059         (WTR::UIScriptController::beginBackSwipe):
3060         (WTR::UIScriptController::completeBackSwipe):
3061
3062 2019-01-30  Keith Rollin  <krollin@apple.com>
3063
3064         Use correct printf format specifier
3065         https://bugs.webkit.org/show_bug.cgi?id=194062
3066         <rdar://problem/47686167>
3067
3068         Reviewed by Alexey Proskuryakov.
3069
3070         LayoutTestSpellChecker.mm is trying to format a variable of type
3071         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
3072         actually an unsigned long long. Fix this by formatting with %llu.
3073
3074         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
3075         (-[LayoutTestTextCheckingResult description]):
3076
3077 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
3078
3079         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
3080         https://bugs.webkit.org/show_bug.cgi?id=193979
3081
3082         Reviewed by Wenson Hsieh.
3083
3084         Fix the test for iOS. Make the test work with iOS UA string.
3085
3086         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3087
3088 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
3089
3090         Replace High Sierra LLINT CLoop bot due to hardware failure
3091         https://bugs.webkit.org/show_bug.cgi?id=194066
3092
3093         Reviewed by Aakash Jain.
3094
3095         * BuildSlaveSupport/build.webkit.org-config/config.json:
3096
3097 2019-01-30  Keith Rollin  <krollin@apple.com>
3098
3099         [NSDragItem init] is unavailable
3100         https://bugs.webkit.org/show_bug.cgi?id=194059
3101         <rdar://problem/47685715>
3102
3103         Reviewed by Wenson Hsieh.
3104
3105         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
3106         DumpRenderTree and TestWebKitAPI, which both try to create an
3107         NSDragItem in a manner that invokes this method. Address this by using
3108         -initWithPasteboardWriter instead.
3109
3110         Note that the parameter passed to initWithPasteboardWriter is likely
3111         incorrect. In both cases, the object passed does not conform to
3112         NSPasteboardWriting. However, with this fix, we're no worse off than
3113         before, and can now perform builds with newer compilers and SDKs until
3114         a real fix can be crafted. That work is tracked in
3115         https://bugs.webkit.org/show_bug.cgi?id=194060
3116
3117         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3118         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
3119         * TestWebKitAPI/mac/TestDraggingInfo.mm:
3120         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
3121
3122 2019-01-30  Daniel Bates  <dabates@apple.com>
3123
3124         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
3125         https://bugs.webkit.org/show_bug.cgi?id=192824
3126         <rdar://problem/47100332>
3127
3128         Reviewed by Wenson Hsieh.
3129
3130         Fix a bug where the wrong usage code was used for F13 thru F24.
3131
3132         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3133         (keyCodeForDOMFunctionKey):
3134
3135 2019-01-30  Chris Dumez  <cdumez@apple.com>
3136
3137         Regression(PSON) Load hang can occur on history navigation
3138         https://bugs.webkit.org/show_bug.cgi?id=194030
3139         <rdar://problem/47656939>
3140
3141         Reviewed by Antti Koivisto.
3142
3143         Add API test coverage.
3144
3145         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3146
3147 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3148
3149         [LFC] Expand tests coverage.
3150
3151         Unreviewed test gardening.
3152
3153         * LayoutReloaded/misc/LFC-passing-tests.txt:
3154
3155 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
3156
3157         [Flatpak] Add openjpeg support
3158         https://bugs.webkit.org/show_bug.cgi?id=194019
3159
3160         Reviewed by Michael Catanzaro.
3161
3162         * flatpak/org.webkit.CommonModules.yaml:
3163
3164 2019-01-30  Commit Queue  <commit-queue@webkit.org>
3165
3166         Unreviewed, rolling out r240708.
3167         https://bugs.webkit.org/show_bug.cgi?id=194022
3168
3169         It broke WPE build (Requested by KaL on #webkit).
3170
3171         Reverted changeset:
3172
3173         "[WPE] Bump font related dependencies to match the GTK+ port"
3174         https://bugs.webkit.org/show_bug.cgi?id=194017
3175         https://trac.webkit.org/changeset/240708
3176
3177 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3178
3179         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
3180         https://bugs.webkit.org/show_bug.cgi?id=194001
3181
3182         Reviewed by Antti Koivisto.
3183
3184         * LayoutReloaded/misc/LFC-passing-tests.txt:
3185
3186 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3187
3188         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
3189         https://bugs.webkit.org/show_bug.cgi?id=194020
3190
3191         Reviewed by Antti Koivisto.
3192
3193         * LayoutReloaded/misc/LFC-passing-tests.txt:
3194
3195 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
3196
3197         AX: Support color well on iOS
3198         https://bugs.webkit.org/show_bug.cgi?id=194010
3199
3200         Reviewed by Joanmarie Diggs.
3201
3202         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3203         (WTR::AccessibilityUIElement::stringAttributeValue):
3204
3205 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
3206
3207         [WPE] Bump font related dependencies to match the GTK+ port
3208         https://bugs.webkit.org/show_bug.cgi?id=194017
3209
3210         Reviewed by Žan Doberšek.
3211
3212         * wpe/jhbuild.modules:
3213         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3214         * wpe/patches/icudata-stdlibs.patch: Added.
3215
3216 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
3217
3218         [Mac] Update window scale API usage
3219         https://bugs.webkit.org/show_bug.cgi?id=193991
3220         rdar://problem/47614795
3221
3222         Reviewed by Tim Horton.
3223
3224         * DumpRenderTree/mac/DumpRenderTree.mm:
3225         (changeWindowScaleIfNeeded):
3226         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3227         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3228         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
3229
3230 2019-01-29  Chris Dumez  <cdumez@apple.com>
3231
3232         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
3233         https://bugs.webkit.org/show_bug.cgi?id=193977
3234         <rdar://problem/47643716>
3235
3236         Reviewed by Geoff Garen.
3237
3238         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
3239         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
3240         to the previous provisional committing *before* we make the last load. 
3241
3242         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3243
3244 2019-01-29  Youenn Fablet  <youenn@apple.com>
3245
3246         Adopt new SPI to evaluate server certificate trust
3247         https://bugs.webkit.org/show_bug.cgi?id=193355
3248
3249         Reviewed by Alex Christensen.
3250
3251         Add infrastructure to handle HTTPS server trust evaluation testing.
3252
3253         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3254         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3255         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
3256         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
3257         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
3258         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3259         * WebKitTestRunner/TestController.cpp:
3260         (WTR::TestController::resetPreferencesToConsistentValues):
3261         (WTR::TestController::didReceiveAuthenticationChallenge):
3262         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
3263         * WebKitTestRunner/TestController.h:
3264         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
3265         * WebKitTestRunner/TestInvocation.cpp:
3266         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3267         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3268         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
3269
3270 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3271
3272         [ews-build] Add build step to print bot Configuration
3273         https://bugs.webkit.org/show_bug.cgi?id=193887
3274
3275         Reviewed by Lucas Forschler.
3276
3277         * BuildSlaveSupport/ews-build/steps.py:
3278         (PrintConfiguration): Build step to print configuration.
3279         * BuildSlaveSupport/ews-build/factories.py:
3280
3281 2019-01-29  Chris Dumez  <cdumez@apple.com>
3282
3283         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
3284         https://bugs.webkit.org/show_bug.cgi?id=193967
3285         <rdar://problem/47635348>
3286
3287         Reviewed by Alex Christensen.
3288
3289         Add API test coverage.
3290
3291         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3292         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
3293
3294 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3295
3296         [ews-app] Handle incoming results data
3297         https://bugs.webkit.org/show_bug.cgi?id=193973
3298
3299         Reviewed by Lucas Forschler.
3300
3301         * BuildSlaveSupport/ews-app/ews/views/results.py:
3302
3303 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3304
3305         [ews-app] Make the results url generic
3306         https://bugs.webkit.org/show_bug.cgi?id=193928
3307
3308         Reviewed by Lucas Forschler.
3309
3310         * BuildSlaveSupport/ews-app/ews/urls.py:
3311
3312 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3313
3314         [ews-build] Configure buildbot to send events to ews-app
3315         https://bugs.webkit.org/show_bug.cgi?id=193968
3316
3317         Reviewed by Lucas Forschler.
3318
3319         * BuildSlaveSupport/ews-build/events.py: Added.
3320         * BuildSlaveSupport/ews-build/master.cfg:
3321
3322 2019-01-29  Keith Rollin  <krollin@apple.com>
3323
3324         Add .xcfilelists to Run Script build phases
3325         https://bugs.webkit.org/show_bug.cgi?id=193792
3326         <rdar://problem/47201785>
3327
3328         Reviewed by Alex Christensen.
3329
3330         As part of supporting XCBuild, update the necessary Run Script build
3331         phases in their Xcode projects to refer to their associated
3332         .xcfilelist files.
3333
3334         Note that the addition of these files bumps the Xcode project version
3335         number to something that's Xcode 10 compatible. This change means that
3336         older versions of the Xcode IDE can't read these projects. Nor can it
3337         fully load workspaces that refer to these projects (the updated
3338         projects are shown as non-expandable placeholders). `xcodebuild` can
3339         still build these projects; it's just that the IDE can't open them.
3340
3341         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3342         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3343
3344 2019-01-29  John Wilander  <wilander@apple.com>
3345
3346         Add data abstraction and validation for Ad Click Attribution
3347         https://bugs.webkit.org/show_bug.cgi?id=193916
3348         <rdar://problem/47603481>
3349
3350         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
3351
3352         Ad click attribution has two steps. First, the storage of an ad
3353         campaign ID for a click that takes the user to a destination
3354         site. Second, a conversion on the destination site that can be
3355         attributed to the ad click.
3356
3357         This patch adds a class that represents a request for ad click
3358         attribution. Validation makes sure that the bits of entropy
3359         reported through this mechanism is limited.
3360
3361         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3362         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
3363         (TestWebKitAPI::TEST):
3364
3365 2019-01-29  Chris Dumez  <cdumez@apple.com>
3366
3367         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
3368         https://bugs.webkit.org/show_bug.cgi?id=193932
3369         <rdar://problem/47598947>
3370
3371         Reviewed by Brady Eidson.
3372
3373         Add API test coverage.
3374
3375         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3376
3377 2019-01-29  Zalan Bujtas  <zalan@apple.com>
3378
3379         Adding new passing LFC tests.
3380
3381         Unreviewed test gardening.
3382
3383         * LayoutReloaded/misc/LFC-passing-tests.txt:
3384
3385 2019-01-29  Zalan Bujtas  <zalan@apple.com>
3386
3387         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
3388         https://bugs.webkit.org/show_bug.cgi?id=193964
3389
3390         Reviewed by Antti Koivisto.
3391
3392         * LayoutReloaded/misc/LFC-passing-tests.txt:
3393
3394 2019-01-29  Zalan Bujtas  <zalan@apple.com>
3395
3396         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
3397         https://bugs.webkit.org/show_bug.cgi?id=193954
3398
3399         Reviewed by Antti Koivisto.
3400
3401         * LayoutReloaded/misc/LFC-passing-tests.txt:
3402
3403 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
3404
3405         WebDriver: add support for running subtests
3406         https://bugs.webkit.org/show_bug.cgi?id=193904
3407
3408         Reviewed by Michael Catanzaro.
3409
3410         pytest already supports it by passing test.py::subtest, so we can do the same.
3411
3412         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
3413         (get_item_name): Made this global.
3414         (CollectRecorder.__init__): Receive the parameter to ignore.
3415         (CollectRecorder.pytest_collectreport): Collect also the subtests.
3416         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
3417         (collect): Add parameter to ignore.
3418         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
3419         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
3420         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
3421         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
3422         (WebDriverTestRunnerSelenium.run): Ditto.
3423         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
3424         (WebDriverTestRunnerW3C.collect_tests): Ditto.
3425         (WebDriverTestRunnerW3C.run): Ditto.
3426
3427 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
3428
3429         User agent string override for navigator.userAgent should be site specific quirks
3430         https://bugs.webkit.org/show_bug.cgi?id=193950
3431
3432         Reviewed by Brent Fulgham.
3433
3434         Updated per the _WKWebsitePolicies rename.
3435
3436         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3437         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3438
3439 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
3440
3441         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
3442         https://bugs.webkit.org/show_bug.cgi?id=193941
3443
3444         Reviewed by Alex Christensen.
3445
3446         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
3447         * TestWebKitAPI/Tests/WTF/Condition.cpp:
3448         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3449         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
3450         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
3451         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
3452         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
3453         * TestWebKitAPI/Tests/WTF/Time.cpp:
3454         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
3455         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
3456         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3457         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
3458
3459 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
3460
3461         Unreviewed, reorder my emails to fix autocomplete in bugzilla
3462
3463         * Scripts/webkitpy/common/config/contributors.json:
3464
3465 2019-01-28  Andy Estes  <aestes@apple.com>
3466
3467         [watchOS] Enable Parental Controls content filtering
3468         https://bugs.webkit.org/show_bug.cgi?id=193939
3469         <rdar://problem/46641912>
3470
3471         Reviewed by Ryosuke Niwa.
3472
3473         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3474
3475 2019-01-28  David Kilzer  <ddkilzer@apple.com>
3476
3477         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
3478         <https://webkit.org/b/193884>
3479
3480         Reviewed by Jiewen Tan.
3481
3482         * Scripts/webkitpy/style/checkers/cpp.py:
3483         (check_language): Add LocalAuthentication to
3484         `frameworks_with_soft_links`.
3485
3486 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
3487
3488         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
3489         https://bugs.webkit.org/show_bug.cgi?id=193891
3490
3491         Reviewed by Ross Kirsling.
3492
3493         There were three problems in window sizes of WebView and the host window.
3494         1. The sizes of pixel image output were incorrect.
3495         2. The host window is going to appear after window.resize was invoked.
3496         3. window.resize resized only the host window, not WebView.
3497
3498         This change solves them with a following approach.
3499         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
3500         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
3501            as well as DumpRenderTree in order to match the client area and the window area.
3502         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
3503         d. PlatformWebView::setWindowFrame changes both window sizes.
3504         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
3505
3506         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3507         (WTR::PlatformWebView::PlatformWebView): Create the host window
3508         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
3509         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
3510         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
3511
3512 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3513
3514         [ews-app] Add method to save Step data to database
3515         https://bugs.webkit.org/show_bug.cgi?id=193890
3516
3517         Reviewed by Lucas Forschler.
3518
3519         * BuildSlaveSupport/ews-app/ews/models/step.py:
3520         (Step.save_step): Method to save step data.
3521         (Step.update_step): Method to update step data.
3522         (Step.get_existing_step): Method to fetch existing step from database.
3523         (Step.is_valid_result): Method to validate valid step result.
3524
3525 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3526
3527         [ews-app] Add method to save Build data to database
3528         https://bugs.webkit.org/show_bug.cgi?id=193735
3529
3530         Reviewed by Lucas Forschler.
3531
3532         * BuildSlaveSupport/ews-app/ews/models/build.py:
3533         (Build.save_build): Method to save build information to database.
3534         (Build.get_existing_build): Method to fetch existing build from database.
3535         (Build.is_valid_result): Method to validate build result.
3536         * BuildSlaveSupport/ews-app/ews/common/util.py:
3537         (is_valid_int_id): Method to validate valid id.
3538
3539 2019-01-28  Chris Dumez  <cdumez@apple.com>
3540
3541         Regression(PSON) Crash under WebPageProxy::didStartProgress()
3542         https://bugs.webkit.org/show_bug.cgi?id=193915
3543         <rdar://problem/47560907>
3544
3545         Reviewed by Alex Christensen.
3546
3547         Add API test coverage.
3548
3549         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3550
3551 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3552
3553         [ews-app] Rename id variables
3554         https://bugs.webkit.org/show_bug.cgi?id=193883
3555
3556         Reviewed by Lucas Forschler.
3557
3558         * BuildSlaveSupport/ews-app/ews/models/build.py:
3559         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3560         * BuildSlaveSupport/ews-app/ews/models/step.py:
3561         * BuildSlaveSupport/ews-app/ews/urls.py:
3562         * BuildSlaveSupport/ews-app/ews/views/patch.py:
3563         * BuildSlaveSupport/ews-app/ews/views/results.py:
3564         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3565
3566 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3567
3568         [ews-app] Allow certain fields to be empty
3569         https://bugs.webkit.org/show_bug.cgi?id=193892
3570
3571         Reviewed by Lucas Forschler.
3572
3573         * BuildSlaveSupport/ews-app/ews/models/build.py:
3574         * BuildSlaveSupport/ews-app/ews/models/step.py:
3575
3576 2019-01-28  Rob Buis  <rbuis@igalia.com>
3577
3578         Update MIME type parser
3579         https://bugs.webkit.org/show_bug.cgi?id=180526
3580
3581         Reviewed by Frédéric Wang.
3582
3583         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
3584         (TestWebKitAPI::TEST):
3585
3586 2019-01-28  Zalan Bujtas  <zalan@apple.com>
3587
3588         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
3589         https://bugs.webkit.org/show_bug.cgi?id=193896
3590
3591         Reviewed by Antti Koivisto.
3592
3593         * LayoutReloaded/misc/LFC-passing-tests.txt:
3594
3595 2018-12-15  Darin Adler  <darin@apple.com>
3596
3597         Replace many uses of String::format with more type-safe alternatives
3598         https://bugs.webkit.org/show_bug.cgi?id=192742
3599
3600         Reviewed by Mark Lam.
3601
3602         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3603         (WTR::cacheTestRunnerCallback): Use makeString.
3604         * WebKitTestRunner/TestController.cpp:
3605         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
3606         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
3607
3608 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
3609
3610         Use a load optimizer for some sites
3611         https://bugs.webkit.org/show_bug.cgi?id=193881
3612         <rdar://problem/46325455>
3613
3614         Reviewed by Brent Fulgham.
3615
3616         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3617         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
3618
3619 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
3620
3621         AX: Introduce a static accessibility tree
3622         https://bugs.webkit.org/show_bug.cgi?id=193348
3623         <rdar://problem/47203295>
3624
3625         Reviewed by Ryosuke Niwa.
3626
3627         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3628
3629 2019-01-26  Zalan Bujtas  <zalan@apple.com>
3630
3631         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
3632         https://bugs.webkit.org/show_bug.cgi?id=193867
3633
3634         Reviewed by Antti Koivisto.
3635
3636         * LayoutReloaded/misc/LFC-passing-tests.txt:
3637
3638 2019-01-26  Zalan Bujtas  <zalan@apple.com>
3639
3640         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
3641         https://bugs.webkit.org/show_bug.cgi?id=193865
3642
3643         Reviewed by Antti Koivisto.
3644
3645         * LayoutReloaded/misc/LFC-passing-tests.txt:
3646
3647 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
3648
3649         Need a mechanism to override navigator.userAgent
3650         https://bugs.webkit.org/show_bug.cgi?id=193762
3651         <rdar://problem/47504939>
3652
3653         Reviewed by Brent Fulgham.
3654
3655         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
3656
3657         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3658         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3659         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
3660
3661 2019-01-25  Dean Jackson  <dino@apple.com>
3662
3663         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
3664         https://bugs.webkit.org/show_bug.cgi?id=193831
3665         <rdar://problem/47399263>
3666
3667         Reviewed by Chris Dumez.
3668
3669         Two new tests that exercise cross-origin and same-origin System
3670         Previews.
3671
3672         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3673
3674 2019-01-25  Keith Rollin  <krollin@apple.com>
3675
3676         Update Xcode projects with "Check .xcfilelists" build phase
3677         https://bugs.webkit.org/show_bug.cgi?id=193790
3678         <rdar://problem/47201374>
3679
3680         Reviewed by Alex Christensen.
3681
3682         Support for XCBuild includes specifying inputs and outputs to various
3683         Run Script build phases. These inputs and outputs are specified as
3684         .xcfilelist files. Once created, these .xcfilelist files need to be
3685         kept up-to-date. In order to check that they are up-to-date or not,
3686         add an Xcode build step that invokes an external script that performs
3687         the checking. If the .xcfilelists are found to be out-of-date, update
3688         them, halt the build, and instruct the developer to restart the build
3689         with up-to-date files.
3690
3691         At this time, the checking and regenerating is performed only if the
3692         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
3693         who want to use this facility can set this variable and test out the
3694         checking/regenerating. Once it seems like there are no egregious
3695         issues that upset a developer's workflow, we'll unconditionally enable
3696         this facility.
3697
3698         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3699         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
3700         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
3701         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3702
3703 2019-01-25  Keith Rollin  <krollin@apple.com>
3704
3705         Update Xcode projects with "Apply Configuration to XCFileLists" build target
3706         https://bugs.webkit.org/show_bug.cgi?id=193781
3707         <rdar://problem/47201153>
3708
3709         Reviewed by Alex Christensen.
3710
3711         Part of generating the .xcfilelists used as part of adopting XCBuild
3712         includes running `make DerivedSources.make` from a standalone script.
3713         It’s important for this invocation to have the same environment as
3714         when the actual build invokes `make DerivedSources.make`. If the
3715         environments are different, then the two invocations will provide
3716         different results. In order to get the same environment in the
3717         standalone script, have the script launch xcodebuild targeting the
3718         "Apply Configuration to XCFileLists" build target, which will then
3719         re-invoke our standalone script. The script is now running again, this
3720         time in an environment with all workspace, project, target, xcconfig
3721         and other environment variables established.
3722
3723         The "Apply Configuration to XCFileLists" build target accomplishes
3724         this task via a small embedded shell script that consists only of:
3725
3726             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
3727
3728         The process that invokes "Apply Configuration to XCFileLists" first
3729         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
3730         evaluated and exports it into the shell environment. When xcodebuild
3731         is invoked, it inherits the value of this variable and can `eval` the
3732         contents of that variable. Our external standalone script can then set
3733         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
3734         of command-line parameters needed to restart itself in the appropriate
3735         state.
3736
3737         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3738         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3739
3740 2019-01-25  Alex Christensen  <achristensen@webkit.org>
3741
3742         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
3743         https://bugs.webkit.org/show_bug.cgi?id=193802
3744         <rdar://problem/46010580>
3745
3746         Reviewed by Andy Estes.
3747
3748         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3749         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
3750         (TEST):
3751
3752 2019-01-25  Daniel Bates  <dabates@apple.com>
3753
3754         [iOS] uiController.keyDown() does not translate Control modified key
3755         https://bugs.webkit.org/show_bug.cgi?id=192898
3756
3757         Reviewed by Wenson Hsieh.
3758
3759         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
3760         key translation, as applicable. Among other cases, key translation occurs when performing
3761         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
3762         also makes the behavior of uiController.keyDown() more closely match the behavior of a
3763         human pressing down and releasing key(s) using a hardware keyboard.
3764
3765         * WebKitTestRunner/ios/HIDEventGenerator.h:
3766         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3767         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
3768
3769         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
3770         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
3771         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3772         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3773         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
3774         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3775         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
3776         (-[HIDEventGenerator longPress:completionBlock:]):
3777         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
3778         Update code for above renaming.
3779
3780         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
3781         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
3782
3783         (-[HIDEventGenerator keyDown:]): Added.
3784         (-[HIDEventGenerator keyUp:]): Added.
3785         (-[HIDEventGenerator keyPress:completionBlock:]):
3786         (-[HIDEventGenerator eventDispatchThreadEntry:]):
3787         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
3788         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3789         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
3790         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
3791         (WTR::parseModifier): Deleted.
3792
3793 2019-01-25  Keith Rollin  <krollin@apple.com>
3794
3795         Complete the implementation of generate-xcfilelists
3796         https://bugs.webkit.org/show_bug.cgi?id=193782
3797
3798         Reviewed by Alex Christensen.
3799
3800         A preliminary version of generate-xcfilelists was added in r238008.
3801         This patch updates that script in order to:
3802
3803         - Support checking of .xcfilelists
3804         - Perform better execution of `make DerivedSources.make` by
3805           relaunching generate-xcfilelists under xcodebuild
3806         - Support incremental generation and checking of .xcfilelists
3807         - Support supplementary .xcfilelists files from WebKitAdditions
3808         - Support being wrapped by parallel version of generate-xcfilelists in
3809           Internal that adds support for (re)generating WebKit projects in
3810           that repo.
3811         - Support builds that have been performed in WebKitBuild as well as
3812           ~/Library/Developer/code/DerivedData
3813         - Increase robustness and debugging facilities.
3814
3815         * Scripts/generate-xcfilelists:
3816
3817 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
3818
3819         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3820         https://bugs.webkit.org/show_bug.cgi?id=193297
3821         <rdar://problem/47158841>
3822
3823         Unreviewed test case fix.
3824
3825         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
3826         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
3827
3828         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3829         (TEST):
3830
3831 2019-01-25  Keith Rollin  <krollin@apple.com>
3832
3833         Update existing .xcfilelists
3834         https://bugs.webkit.org/show_bug.cgi?id=193791
3835         <rdar://problem/47201706>
3836
3837         Reviewed by Alex Christensen.
3838
3839         Many .xcfilelist files were added in r238824 in order to support
3840         XCBuild. Update these with recent changes to the set of build files
3841         and with the current generate-xcfilelist script.
3842
3843         * DumpRenderTree/DerivedSources-input.xcfilelist:
3844         * DumpRenderTree/DerivedSources-output.xcfilelist:
3845         * WebKitTestRunner/DerivedSources-input.xcfilelist:
3846         * WebKitTestRunner/DerivedSources-output.xcfilelist:
3847
3848 2019-01-25  Keith Rollin  <krollin@apple.com>
3849
3850         Fix missing dependencies in extract-dependencies-from-makefile
3851         https://bugs.webkit.org/show_bug.cgi?id=193783
3852         <rdar://problem/47201571>
3853
3854         Reviewed by Alex Christensen.
3855
3856         The extract-dependencies-from-makefile script generates .xcfilelists
3857         for XCBuild by invoking a makefile in --debug mode, parsing the
3858         dependency information in the output, and extracting information
3859         regarding targets and dependents. However, the way `make` emits this
3860         dependency information is not rigorous, and so we need to determine
3861         what lines to look for and parse by trial and error. This approach
3862         didn't coriginally atch all the information we needed to collect, so
3863         update the script to look for the additional lines we now know to look
3864         for.
3865
3866         * Scripts/extract-dependencies-from-makefile:
3867         (Parser):
3868         (Parser.addTarget):
3869         (Parser.addPrereq):
3870         (Parser.doParse):
3871
3872 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
3873
3874         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3875         https://bugs.webkit.org/show_bug.cgi?id=193297
3876         <rdar://problem/47158841>
3877
3878         Reviewed by Alex Christensen.
3879
3880         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
3881             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
3882         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3883         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
3884         activating the message used to trigger the callback when it is set.
3885
3886 2019-01-25  Alex Christensen  <achristensen@webkit.org>
3887
3888         WKWebView.goBack should reload if there is a safe browsing warning
3889         https://bugs.webkit.org/show_bug.cgi?id=193805
3890         <rdar://problem/46908216>
3891
3892         Reviewed by Geoff Garen.
3893
3894         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3895         (+[Simple3LookupContext sharedLookupContext]):
3896         (-[Simple3LookupContext lookUpURL:completionHandler:]):
3897         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
3898         (TEST):
3899
3900 2019-01-25  Chris Dumez  <cdumez@apple.com>
3901
3902         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
3903         https://bugs.webkit.org/show_bug.cgi?id=193788
3904         <rdar://problem/47531231>
3905
3906         Reviewed by Alex Christensen.
3907
3908         Add API test coverage.
3909
3910         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3911         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
3912
3913 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
3914
3915         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
3916         https://bugs.webkit.org/show_bug.cgi?id=193771
3917
3918         Unreviewed infrastructure fix.
3919
3920         * Scripts/webkitpy/port/darwin.py:
3921         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
3922
3923 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
3924
3925         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
3926
3927 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
3928
3929         Add contributors.json entries for Ling Ho and for a new bot watchers group.
3930
3931         * Scripts/webkitpy/common/config/contributors.json:
3932
3933 2019-01-25  Chris Dumez  <cdumez@apple.com>
3934
3935         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
3936         https://bugs.webkit.org/show_bug.cgi?id=193779
3937         <rdar://problem/46170903>
3938
3939         Reviewed by Antti Koivisto.
3940
3941         Add API test that quickly navigates forward to a previous process without waiting for it to
3942         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
3943         the process' previous page when reconnecting the it for the forward navigation.
3944
3945         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3946
3947 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3948
3949         Need a way for JavaScript (or bundle) code to participate in undo
3950         https://bugs.webkit.org/show_bug.cgi?id=190009
3951         <rdar://problem/44807048>
3952
3953         Reviewed by Ryosuke Niwa.
3954
3955         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
3956         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
3957
3958         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3959         (WTR::UIScriptController::lastUndoLabel const):
3960         (WTR::UIScriptController::firstRedoLabel const):
3961         (WTR::UIScriptController::platformUndoManager const):
3962         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3963         (WTR::UIScriptController::lastUndoLabel const):
3964         (WTR::UIScriptController::firstRedoLabel const):
3965         (WTR::UIScriptController::platformUndoManager const):
3966         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3967         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3968         (WTR::UIScriptController::lastUndoLabel const):
3969         (WTR::UIScriptController::firstRedoLabel const):
3970         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3971         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3972         (WTR::UIScriptController::lastUndoLabel const):
3973         (WTR::UIScriptController::firstRedoLabel const):
3974         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3975         (WTR::UIScriptController::platformUndoManager const):
3976         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3977         (WTR::UIScriptController::platformUndoManager const):
3978
3979 2019-01-25  Zalan Bujtas  <zalan@apple.com>
3980
3981         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
3982         https://bugs.webkit.org/show_bug.cgi?id=193824
3983
3984         Reviewed by Antti Koivisto.
3985
3986         * LayoutReloaded/misc/LFC-passing-tests.txt:
3987
3988 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
3989
3990         Update macOS JSC bot configurations
3991         https://bugs.webkit.org/show_bug.cgi?id=193739
3992
3993         Reviewed by Alexey Proskuryakov.
3994
3995         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
3996         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3997         (BubbleQueueServer): Move JSC EWS to Mojave section.
3998         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3999         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
4000         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
4001
4002 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
4003
4004         [Win][WebKitTestRunner] Implement EventSenderProxy
4005         https://bugs.webkit.org/show_bug.cgi?id=193755
4006
4007         Reviewed by Don Olmstead.
4008
4009         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
4010         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
4011         (WTR::EventSenderProxy::dispatchMessage):
4012         (WTR::EventSenderProxy::EventSenderProxy):
4013         (WTR::EventSenderProxy::mouseDown):
4014         (WTR::EventSenderProxy::mouseUp):
4015         (WTR::EventSenderProxy::mouseMoveTo):
4016         (WTR::EventSenderProxy::mouseScrollBy):
4017         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
4018
4019 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
4020
4021         Unreviewed fix for API test failure after r240437.
4022
4023         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
4024
4025         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
4026
4027 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
4028
4029         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
4030         https://bugs.webkit.org/show_bug.cgi?id=193787
4031         <rdar://problem/47497634>
4032
4033         Reviewed by Alexey Proskuryakov.
4034
4035         * Scripts/webkitdirs.pm:
4036         (iosSimulatorApplicationsPath): Pick from available runtime directories.
4037
4038 2019-01-24  Truitt Savell  <tsavell@apple.com>
4039
4040         Unreviewed, rolling out r240446.
4041
4042         Casued 5 API failures
4043
4044         Reverted changeset:
4045
4046         "Activate the WebResourceLoadStatisticsStore in the
4047         NetworkProcess and deactivate it in the UIProcess."
4048         https://bugs.webkit.org/show_bug.cgi?id=193297
4049         https://trac.webkit.org/changeset/240446
4050
4051 2019-01-24  Zalan Bujtas  <zalan@apple.com>
4052
4053         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
4054         https://bugs.webkit.org/show_bug.cgi?id=193741
4055         <rdar://problem/47135030>
4056
4057         Reviewed by Antti Koivisto and Simon Fraser.
4058
4059         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4060         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
4061         (TestWebKitAPI::TEST):
4062
4063 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
4064
4065         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
4066         https://bugs.webkit.org/show_bug.cgi?id=193297
4067         <rdar://problem/47158841>
4068
4069         Reviewed by Alex Christensen.
4070
4071         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4072         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
4073         activating the message used to trigger the callback when it is set.
4074
4075 2019-01-24  John Wilander  <wilander@apple.com>
4076
4077         Add Ad Click Attribution as an internal/experimental feature
4078         https://bugs.webkit.org/show_bug.cgi?id=193685
4079         <rdar://problem/47450399>
4080
4081         Reviewed by Brent Fulgham.
4082
4083         Added test option adClickAttributionEnabled.
4084
4085         * DumpRenderTree/TestOptions.cpp:
4086         (TestOptions::TestOptions):
4087         * DumpRenderTree/TestOptions.h:
4088         * DumpRenderTree/mac/DumpRenderTree.mm:
4089         (setWebPreferencesForTestOptions):
4090
4091 2019-01-24  Antti Koivisto  <antti@apple.com>
4092
4093         [PSON] Flash on back navigation on Mac
4094         https://bugs.webkit.org/show_bug.cgi?id=193716
4095         <rdar://problem/47148458>
4096
4097         Reviewed by Chris Dumez.
4098
4099         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4100
4101         Closing of the previous page is delayed so waiting for didFinishNavigation is
4102         not sufficient to guarantee we have received all the messages. Wait for them.
4103
4104 2019-01-24  Chris Dumez  <cdumez@apple.com>
4105
4106         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
4107         https://bugs.webkit.org/show_bug.cgi?id=193761
4108         <rdar://problem/47456405>
4109
4110         Reviewed by Alex Christensen.
4111
4112         Add API test coverage.
4113
4114         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4115
4116 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
4117
4118         webkitpy: Missing PID in crashlog name should not be fatal
4119         https://bugs.webkit.org/show_bug.cgi?id=193771
4120
4121         If we can't determine the PID of a crashlog, just ignore the crashlog instead
4122         of raising an exception.
4123
4124         Reviewed by Lucas Forschler.
4125
4126         * Scripts/webkitpy/port/darwin.py:
4127         (DarwinPort._merge_crash_logs):
4128
4129 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
4130
4131         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
4132         https://bugs.webkit.org/show_bug.cgi?id=193746
4133
4134         Reviewed by Youenn Fablet.
4135
4136         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
4137         so we'd best just not call it.
4138
4139         * Scripts/webkitpy/w3c/test_exporter.py:
4140         (WebPlatformTestExporter.create_branch_with_patch):
4141
4142 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
4143
4144         Move FileSystem to WTF
4145         https://bugs.webkit.org/show_bug.cgi?id=193602
4146
4147         Reviewed by Yusuke Suzuki.
4148
4149         * DumpRenderTree/win/DumpRenderTree.cpp:
4150         * TestWebKitAPI/CMakeLists.txt:
4151         * TestWebKitAPI/PlatformGTK.cmake:
4152         * TestWebKitAPI/PlatformJSCOnly.cmake:
4153         * TestWebKitAPI/PlatformPlayStation.cmake:
4154         * TestWebKitAPI/PlatformWPE.cmake:
4155         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4156         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
4157         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
4158         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
4159         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
4160         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
4161         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
4162         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
4163         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
4164         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
4165
4166 2019-01-24  Philippe Normand  <pnormand@igalia.com>
4167
4168         [WPE] Remove hard dependency on subprocess32 for the API tests
4169
4170         Rubber-stamped by Carlos Garcia Campos.
4171
4172         * glib/api_test_runner.py:
4173         (TestRunner._run_test_qt): Lazily import subprocess32 and check
4174         its presence only when running WPEQt tests.
4175
4176 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
4177
4178         [GLIB] Expose JavaScriptCore options in GLib public API
4179         https://bugs.webkit.org/show_bug.cgi?id=188742
4180
4181         Reviewed by Michael Catanzaro.
4182
4183         Add a test for the new API.
4184
4185         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
4186         (testsJSCOptions):
4187         (main):
4188
4189 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
4190
4191         [GTK][WPE] Support JPEG 2000 images
4192         https://bugs.webkit.org/show_bug.cgi?id=186272
4193
4194         Reviewed by Žan Doberšek.
4195
4196         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
4197
4198         * gtk/jhbuild.modules:
4199         * wpe/jhbuild.modules:
4200
4201 2019-01-23  David Kilzer  <ddkilzer@apple.com>
4202
4203         check-webkit-style should warn when using soft-linking macros in a header
4204         <https://webkit.org/b/193750>
4205
4206         Reviewed by Darin Adler.
4207
4208         * Scripts/webkitpy/style/checkers/cpp.py:
4209         (check_language): Add softlink/header check by refactoring the
4210         softlink/framework check.
4211         (CppChecker): Enable softlink/header check by default.
4212         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4213         (CppStyleTest.test_softlink_framework): Rename from
4214         CppStyleTest.test_softlink() and change test framework name in
4215         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
4216         files. Set file_name for macros that only appear in headers.
4217         (CppStyleTest.test_softlink_header): Add tests for using
4218         soft-link macros in headers.
4219
4220 2019-01-23  Chris Dumez  <cdumez@apple.com>
4221
4222         Deprecate API to limit the maximum number of WebProcesses
4223         https://bugs.webkit.org/show_bug.cgi?id=193725
4224         <rdar://problem/47464879>
4225
4226         Reviewed by Geoff Garen.
4227
4228         Update existing API tests to stop using deprecated API.
4229
4230         * MiniBrowser/mac/AppDelegate.m:
4231         (defaultConfiguration):
4232         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
4233         (TestWebKitAPI::TEST):
4234         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
4235         (TestWebKitAPI::TEST):
4236         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
4237         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
4238         (TEST):
4239         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
4240         (TEST):
4241
4242 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
4243
4244         [ews-app] Rename ews model buildermappings to buildermapping
4245         https://bugs.webkit.org/show_bug.cgi?id=193729
4246
4247         Reviewed by Lucas Forschler.
4248
4249         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
4250         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
4251         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
4252
4253 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
4254
4255         [ews-app] Rename ews model steps to step
4256         https://bugs.webkit.org/show_bug.cgi?id=193697
4257
4258         Reviewed by Lucas Forschler.
4259
4260         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
4261         (Step): Renamed Steps to Step.
4262
4263 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
4264
4265         Clean up IndexedDB files between tests
4266         https://bugs.webkit.org/show_bug.cgi?id=192796
4267         <rdar://problem/46824999>
4268
4269         Reviewed by Geoffrey Garen.
4270
4271         * DumpRenderTree/mac/DumpRenderTree.mm:
4272         (runTest):
4273         * WebKitTestRunner/TestController.cpp:
4274         (WTR::TestController::resetStateToConsistentValues):
4275         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
4276         (WTR::RemoveAllIndexedDatabasesCallback):
4277         (WTR::TestController::ClearIndexedDatabases):
4278         * WebKitTestRunner/TestController.h:
4279         * WebKitTestRunner/TestInvocation.cpp:
4280         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
4281
4282 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
4283
4284         [ews-app] Rename ews model Builds to Build
4285         https://bugs.webkit.org/show_bug.cgi?id=193695
4286
4287         Reviewed by Lucas Forschler.
4288
4289         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
4290         (Build): Renamed Builds to Build.
4291
4292 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
4293
4294         webkitpy: Wait longer when launching WebKitTestRunner
4295         https://bugs.webkit.org/show_bug.cgi?id=193734
4296
4297         Reviewed by Aakash Jain.
4298
4299         * Scripts/webkitpy/port/simulator_process.py:
4300         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
4301
4302 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
4303
4304         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
4305         https://bugs.webkit.org/show_bug.cgi?id=193182
4306         <rdar://problem/47452154>
4307
4308         Reviewed by Tim Horton.
4309
4310         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
4311         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
4312         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
4313
4314         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
4315         preventing later tests from recognizing gestures.
4316
4317         * WebKitTestRunner/ios/TestControllerIOS.mm:
4318         (WTR::TestController::platformResetStateToConsistentValues):
4319
4320         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
4321
4322 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
4323
4324         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
4325         https://bugs.webkit.org/show_bug.cgi?id=193722
4326         <rdar://problem/47481475>
4327
4328         Reviewed by Lucas Forschler.
4329
4330         iPhone and iPad ports should both use the iOS config.
4331
4332         * Scripts/webkitpy/port/ios_simulator.py:
4333         (IPhoneSimulatorPort.__init__):
4334         (IPadSimulatorPort.__init__):
4335
4336 2019-01-23  Rob Buis  <rbuis@igalia.com>
4337
4338         Update MIME type parser
4339         https://bugs.webkit.org/show_bug.cgi?id=180526
4340
4341         Reviewed by Frédéric Wang.
4342
4343         Add unit tests for both parse modes of ParsedContentType.
4344
4345         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4346         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
4347         (TestWebKitAPI::TEST):
4348
4349 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
4350
4351         [ews-app] fetch loop should not stop on network issues
4352         https://bugs.webkit.org/show_bug.cgi?id=193666
4353
4354         Reviewed by Lucas Forschler.
4355
4356         * BuildSlaveSupport/ews-app/ews/fetcher.py:
4357         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
4358
4359 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
4360
4361         [iOS] Multiple WKWebViewAutofillTests are flaky failures
4362         https://bugs.webkit.org/show_bug.cgi?id=189165
4363         <rdar://problem/47433765>
4364
4365         Reviewed by Tim Horton.
4366
4367         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
4368         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
4369         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
4370         process in sufficient to ensure that any previous action that blurred the focused element in the web process
4371         would make its way to the UI process by the time the layer tree commit is finished.
4372
4373         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
4374         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
4375         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
4376         will fail because it asks for -_autofillContext too early.
4377
4378         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
4379         is handled in the UI process.
4380
4381         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
4382
4383         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
4384         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
4385         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new