Fix fat-fingered function name in git-add-reviewer.
[WebKit-https.git] / Tools / ChangeLog
1 2014-10-10  Dana Burkart  <dburkart@apple.com>
2
3         Fix fat-fingered function name in git-add-reviewer.
4
5         Unreviewed.
6
7         * Scripts/git-add-reviewer:
8         (getConfigValue):
9
10 2014-10-10  David Farler  <dfarler@apple.com>
11
12         [iOS] LayoutTestRelay should ensure its DRT/WKTR dies when receiving kill/term signals
13         https://bugs.webkit.org/show_bug.cgi?id=137528
14
15         Reviewed by Simon Fraser.
16
17         Catch SIGINT and SIGTERM signals in the LayoutTestRelay
18         and SIGKILL the paired simulator app before exiting cleanly.
19
20         webkitpy only uses SIGKILL to kill processes which you cannot
21         catch. Send SIGTERM to the process and give it chance to do
22         its thing before sending SIGKILL. Sending a SIGKILL to an already
23         dead PID is safe.
24
25         * LayoutTestRelay/LayoutTestRelay/LTRelayController.h:
26         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
27         (-[LTRelayController finish]):
28         * LayoutTestRelay/LayoutTestRelay/main.m:
29         (receivedSignal):
30         (main):
31
32 2014-10-10  David Farler  <dfarler@apple.com>
33
34         [iOS] LayoutTestRelay should detect EOF and properly signal underlying DRT/WKTR
35         https://bugs.webkit.org/show_bug.cgi?id=137527
36
37         Reviewed by Simon Fraser.
38
39         NSFileHandle doesn't notify of EOF in its readability handler.
40         Use a dispatch_source_t and an event handler that is called when reading is possible.
41         In the handler block, do a run-of-the-mill read(2) from standard input and
42         detect EOF in the usual way by checking that zero bytes were read.
43
44         Once an EOF is received, the FIFOs are disconnected, the simulator app
45         is killed, and the relay exits with status 0.
46
47         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
48         (-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]):
49         (-[LTRelayController didDisconnect]):
50         (-[LTRelayController didConnect]):
51         (-[LTRelayController launchApp]):
52         Rename "dispatchSource" to "simulatorAppExitDispatchSource" to prevent any
53         confusion with this new dispatch source, called "standardInputDispatchSource".
54         (-[LTRelayController finish]): Added.
55         (-[LTRelayController readFileHandle:]): Deleted.
56
57 2014-10-10  KwangHyuk Kim  <hyuki.kim@samsung.com>
58
59         [EFL] Crash on facebook.com
60         https://bugs.webkit.org/show_bug.cgi?id=137562
61
62         Reviewed by Chris Dumez.
63
64         Crash occurs on the facebook.com when the webview is resized
65         after the <select> item is clicked but no item is chosen.
66         This crash is just caused by the reference of invalidated variable.
67         From the EwkView::closePopupMenu(), ewk_menu is just invalidated.
68         Therefore ewk_menu variable is not available anymore when on_popup_menu_hide()
69         on MiniBrowser is called.
70         As a result, just set ewk_menu to NULL in order to prevent crash condition.
71
72         * MiniBrowser/efl/main.c:
73         (on_popup_menu_hide):
74
75 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
76
77         A small wording change for clarity.
78
79         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js:
80         (MetricsBubbleView.prototype._update):
81
82 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
83
84         Dashboard metrics page should have EWS statistics
85         https://bugs.webkit.org/show_bug.cgi?id=137626
86
87         Reviewed by Ryosuke Niwa.
88
89         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js:
90         (BubbleQueue): Put shortName in the object, so that it's actually useful.
91
92         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
93         (BubbleQueueServer): Re-ordered queues to match bubble order.
94         (BubbleQueueServer.prototype.jsonProcessingTimesURL): Added URL for the new handler.
95         (BubbleQueueServer.prototype.loadProcessingTimes): Load the data from webkit-queues.
96
97         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
98         Added analysis for bubble queues.
99
100         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js: Added.
101
102         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
103         (buildBubbleQueuesTable): Build the UI.
104
105         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/metrics.html:
106         Added JS sources to load.
107
108         * QueueStatusServer/app.yaml: To update app version.
109
110         * QueueStatusServer/handlers/processingtimesjson.py: Added.
111
112         * QueueStatusServer/main.py: Added a handler for processing-times-json.
113
114 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
115
116         REGRESSION: Commit queue doesn't process rollouts
117         https://bugs.webkit.org/show_bug.cgi?id=137623
118
119         Reviewed by Tim Horton.
120
121         * QueueStatusServer/app.yaml:
122         * QueueStatusServer/handlers/updateworkitems.py:
123         (UpdateWorkItems._work_items_from_request):
124
125 2014-10-10  Simon Fraser  <simon.fraser@apple.com>
126
127         Fix syntax error after r174601.
128
129         * Scripts/run-javascriptcore-tests:
130
131 2014-10-10  Michael Saboff  <msaboff@apple.com>
132
133         Add ability to select tarfile name in run-jsc-stress-tests
134         https://bugs.webkit.org/show_bug.cgi?id=137614
135
136         Reviewed by Mark Hahnenberg.
137
138         Added optional file name argument to the --tarball option.  
139
140         * Scripts/run-javascriptcore-tests: Added "--" to terminate options so the first
141         extra test given after the options wont be used for the optional tarball file name.
142         * Scripts/run-jsc-stress-tests:
143
144 2014-10-10  Chris Dumez  <cdumez@apple.com>
145
146         Unreviewed, update my information in contributors.json
147
148         Use my preferred first name and update my expertise areas.
149
150         * Scripts/webkitpy/common/config/contributors.json:
151
152 2014-10-10  Adrien Destugues  <pulkomandy@gmail.com>
153
154         Fix perl scripts to run with env on Linux
155         https://bugs.webkit.org/show_bug.cgi?id=137601
156
157         Reviewed by Csaba Osztrogonác.
158
159         Use of arguments in #! is nonstandard and does not behave the same on
160         different systems. Linux would look for an executable named "perl -w" 
161         "use warnings;" does the same things in a more portable way.
162
163         * Scripts/commit-log-editor:
164         * Scripts/num-cpus:
165         * Scripts/prepare-ChangeLog:
166         * Scripts/run-launcher:
167         * Scripts/svn-create-patch:
168
169 2014-10-10  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
170
171         [jhbuild] We should be able to disable wiping on configuration change
172         https://bugs.webkit.org/show_bug.cgi?id=137446
173
174         Reviewed by Csaba Osztrogonác.
175
176         The default behaviour isn't changed, wiping on configuration change feature can be disabled with
177         setting JHBUILD_WIPE_ON_CHANGE=0 environment variable
178         or passing --no-wipe-on-change command line option.
179
180         * Scripts/update-webkit-libs-jhbuild:
181
182 2014-10-09  Andy Estes  <aestes@apple.com>
183
184         Teach webkitpy about OS X Yosemite
185         https://bugs.webkit.org/show_bug.cgi?id=137585
186
187         Reviewed by Simon Fraser.
188
189         * Scripts/webkitpy/common/system/platforminfo.py:
190         (PlatformInfo._determine_mac_version):
191         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
192         (TestPlatformInfo.test_os_version):
193         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
194         (TestExpectationParser):
195         * Scripts/webkitpy/port/builders.py:
196         * Scripts/webkitpy/port/mac.py:
197         (MacPort):
198         * Scripts/webkitpy/port/mac_unittest.py:
199         (test_versions):
200         (test_baseline_search_path):
201         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
202         (TestRebaselineTest.test_baseline_directory):
203         (TestRebaselineExpectations.test_rebaseline_expectations):
204
205 2014-10-09  Dana Burkart  <dburkart@apple.com>
206
207         Add Mac OS Yosemite dashboard support.
208
209         Rubber-stamped by Lucas Forschler.
210
211         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite.png: Added.
212         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite@2x.png: Added.
213         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
214         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
215         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
216
217 2014-10-08  Ryosuke Niwa  <rniwa@webkit.org>
218
219         Add Babak to contributors.json and add historical email addresses for some contributors
220         https://bugs.webkit.org/show_bug.cgi?id=137546
221
222         Reviewed by Christophe Dumez.
223
224         contributors.json is used to analyze historical commit data and change logs.
225
226         Add back historical email addresses for some contributors and also add Babak (Shafiei).
227
228         * Scripts/webkitpy/common/config/contributors.json:
229
230 2014-10-09  Lucas Forschler  <lforschler@apple.com>
231
232         Add Mac OS Yosemite webkit build infrastructure.
233         
234         This patch adds 15 bots to our build.webkit.org configuration.
235         We are matching the current Mavericks machines 1:1.
236         
237         This patch includes some minor spacing changes to the buildslaves section to make everything similar.
238         
239         Reviewed by Matt Hanson.
240
241         * BuildSlaveSupport/build.webkit.org-config/config.json:
242
243 2014-10-09  Dana Burkart  <dburkart@apple.com>
244
245         Don't use backticks when running commands, as we run into sh-related
246         interpolation issues. Also, fix our usage of system() to properly
247         retrieve the status code.
248         https://bugs.webkit.org/show_bug.cgi?id=137541
249
250         Reviewed by Darin Adler.
251
252         * Scripts/git-add-reviewer:
253         (interactive):
254         (nonInteractive):
255         (requireCleanWorkTree):
256         (cherryPick):
257         (commit):
258         (addReviewerToFile):
259         (head):
260         (isAncestor):
261         (toCommit):
262         (changeLogsForCommit):
263         (resetToCommit):
264         (getConfigValue):
265         (runCommandWithOutput):
266
267 2014-10-09  Tim Horton  <timothy_horton@apple.com>
268
269         Add a WebKit1 preference for selection services
270         https://bugs.webkit.org/show_bug.cgi?id=137498
271         <rdar://problem/18572699>
272
273         Reviewed by Simon Fraser.
274
275         * MiniBrowser/mac/WK1BrowserWindowController.m:
276         (-[WK1BrowserWindowController awakeFromNib]):
277         Turn on image and selection services in the Legacy WebKit MiniBrowser.
278
279 2014-10-09  Adrien Destugues  <pulkomandy@gmail.com>
280
281         Get the patch scripts running on Haiku
282         https://bugs.webkit.org/show_bug.cgi?id=137559
283
284         Reviewed by Benjamin Poulain.
285
286         Use /usr/bin/env instead of hardcoding path to perl.
287         Declare haiku platform in platforminfo.py to avoid check-webkit-style
288         failure.
289
290         * Scripts/commit-log-editor:
291         * Scripts/num-cpus:
292         * Scripts/prepare-ChangeLog:
293         * Scripts/run-launcher:
294         * Scripts/svn-create-patch:
295         * Scripts/webkitpy/common/system/platforminfo.py:
296         (PlatformInfo._determine_os_name):
297
298 2014-10-08  Jake Nielsen  <jacob_nielsen@apple.com>
299
300         StyleQueue should throw a PatchIsNotValid exception to achieve
301         consistency with CommitQueue and EWS
302         https://bugs.webkit.org/show_bug.cgi?id=137500
303
304         Reviewed by Alexey Proskuryakov.
305
306         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
307         Adds a call to validate() in run().
308         (StyleQueueTask.run):
309         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
310         Adds a return False in the patch is not valid exception statement.
311         (AbstractEarlyWarningSystem.review_patch):
312         * Scripts/webkitpy/tool/commands/queues.py:
313         Adds a return False in the patch is not valid exception statement in
314         commit queue, and adds an except statement to catch PatchIsNotValid
315         exceptions in style queue.
316         (CommitQueue.process_work_item):
317         (StyleQueue.review_patch):
318
319 2014-10-08  Carlos Garcia Campos  <cgarcia@igalia.com>
320
321         Race condition with WebKitWebView:is-loading after starting page load
322         https://bugs.webkit.org/show_bug.cgi?id=136692
323
324         Reviewed by Gustavo Noronha Silva.
325
326         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
327         (loadChangedCallback): Only check is-loading is false when load
328         has finished if the load didn't fail due to a cancellation.
329         (loadFailedCallback): Only check is-loading is false if the load
330         didn't fail due to a cancellation.
331         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
332         (WebViewTest::loadURI): Check is-loading is true and active URI is
333         the requested one rigth after requesting the load.
334         (WebViewTest::loadHtml): Ditto.
335         (WebViewTest::loadPlainText): Ditto.
336         (WebViewTest::loadBytes): Ditto.
337         (WebViewTest::loadRequest): Ditto.
338         (WebViewTest::loadAlternateHTML): Ditto.
339         (WebViewTest::goBack): Ditto.
340         (WebViewTest::goForward): Ditto.
341         (WebViewTest::goToBackForwardListItem): Ditto.
342
343 2014-10-08  Brent Fulgham  <bfulgham@apple.com>
344
345         [Win] Resolve various static analyzer warnings in Tools.
346         https://bugs.webkit.org/show_bug.cgi?id=137534
347
348         Reviewed by Dean Jackson.
349
350         * DumpRenderTree/cg/ImageDiffCG.cpp:
351         (main): User proper printf specifiers.
352         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
353         (AccessibilityUIElement::childrenCount): Handle possibility that
354         gcc_accChildCount returns with an error.
355         (accessibilityState): Ditto for gcc_accState.
356         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
357         (DRTDesktopNotificationPresenter::showDesktopNotification): Use proper
358         check for return value from 'isHTML'. HRESULT is not a boolean and cannot
359         be treated as such.
360         * DumpRenderTree/win/DumpRenderTree.cpp:
361         (DumpRenderTreeWndProc): Avoid possible infinite loop on teardown caused
362         by comparing an unsigned value as being greater-than zero.
363         * DumpRenderTree/win/EditingDelegate.cpp:
364         (dump): Pass proper character pointer type to printf.
365         (EditingDelegate::shouldBeginEditingInDOMRange): Ditto.
366         (EditingDelegate::shouldEndEditingInDOMRange): Ditto.
367         (EditingDelegate::shouldInsertNode): Ditto.
368         (EditingDelegate::shouldInsertText): Ditto.
369         (EditingDelegate::shouldDeleteDOMRange): Ditto.
370         (EditingDelegate::shouldChangeSelectedDOMRange): Ditto.
371         (EditingDelegate::shouldApplyStyle): Ditto.
372         * DumpRenderTree/win/EventSender.cpp:
373         (beginDragWithFilesCallback): Handle possible error case for GlobalAlloc.
374         * DumpRenderTree/win/EventSender.h: Add proper declaration for HRESULT to match
375         system headers.
376         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Handle possible failure
377         from CreateDIBSection.
378         * DumpRenderTree/win/UIDelegate.cpp: Ensure proper type is passed to printf.
379         * TestWebKitAPI/Tests/WTF/MediaTime.cpp: Get rid of workaround for NaN under
380         older versions of MSVC we no longer support.
381         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Use proper types and API
382         for 64-bit builds.
383         * TestWebKitAPI/TestsController.cpp: Use NeverDestroyed like a good citizen.
384         * TestWebKitAPI/TestsController.h: Ditto.
385         * WinLauncher/Common.cpp: Handle possible failure from GetModuleFileName.
386         * WinLauncher/WinLauncher.cpp: Make order of operations explicit to avoid
387         performing bitwise | before the comparison is done.
388
389 2014-10-08  Ada Chan  <adachan@apple.com>
390
391         Add a test for WKPageIsPlayingAudio().
392         https://bugs.webkit.org/show_bug.cgi?id=137048
393
394         Reviewed by Darin Adler.
395
396         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
397         Add file-with-video.html, test.mp4, and WKPageIsPlayingAudio.cpp to the project.
398         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp: Added.
399         (TestWebKitAPI::nullJavaScriptCallback):
400         (TestWebKitAPI::didFinishLoadForFrame):
401         (TestWebKitAPI::isPlayingAudioDidChangeCallback):
402         (TestWebKitAPI::setUpClients):
403         (TestWebKitAPI::TEST):
404         This test loads a page with a video in it. When the page is loaded, we first check that
405         WKPageIsPlayingAudio() returns false for the page. Then we call a method to start the video.
406         When the WKPageUIClient::isPlayingAudioDidChange callback gets called, check that WKPageIsPlayingAudio()
407         now returns true for the page.
408         * TestWebKitAPI/Tests/WebKit2/file-with-video.html: Added.
409         * TestWebKitAPI/Tests/WebKit2/test.mp4: Added.
410         This is a video copied from LayoutTests/media/content.
411
412 2014-10-08  Csaba Osztrogonác  <ossy@webkit.org>
413
414         [webkitpy] Use python-irclib-0.4.8.tar.gz instead of zip in AutoInstaller
415         https://bugs.webkit.org/show_bug.cgi?id=137516
416
417         Reviewed by Alexey Proskuryakov.
418
419         * Scripts/webkitpy/thirdparty/__init__.py:
420         (AutoinstallImportHook._install_irc):
421
422 2014-10-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
423
424         [GTK] install-dependencies should install libjpeg-turbo on Debian and derivatives.
425         https://bugs.webkit.org/show_bug.cgi?id=137520
426
427         Reviewed by Philippe Normand.
428
429         Debian is switching is default JPEG library to libjpeg-turbo <https://wiki.debian.org/LJTTransition#Text>
430         For other distributions, we are already installing libjpeg-turbo.
431         So, do the same for Debian and derivatives.
432
433         * gtk/install-dependencies: Install libjpeg-dev that depends on the default implementation of libjpeg.
434
435 2014-10-08  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
436
437         [webkitpy] Add back the workaround to replace ZipFile.extractall()
438         https://bugs.webkit.org/show_bug.cgi?id=137519
439
440         Reviewed by Csaba Osztrogonác.
441
442         It was removed by <http://trac.webkit.org/changeset/174266>,
443         because the comment stated it is a workaround for buggy python
444         2.6.1 which shipped on Snow Leopard. But it turned out the bug
445         is still valid with python 2.7 shipped on the latest Ubuntu
446         (12.04 and 14.04) and OS X 10.9.
447
448         * Scripts/webkitpy/common/system/autoinstall.py:
449         (AutoInstaller):
450         (AutoInstaller._extract_all):
451         (AutoInstaller._unzip):
452
453 2014-10-08  Commit Queue  <commit-queue@webkit.org>
454
455         Unreviewed, rolling out r174335.
456         https://bugs.webkit.org/show_bug.cgi?id=137515
457
458         It broke EFL layout test totally (Requested by gyuyoung on
459         #webkit).
460
461         Reverted changeset:
462
463         "[EFL] Introduce EWebKit_Extension"
464         https://bugs.webkit.org/show_bug.cgi?id=134921
465         http://trac.webkit.org/changeset/174335
466
467 2014-10-08  Carlos Garcia Campos  <cgarcia@igalia.com>
468
469         [GTK] Make forwarding headers generation depend on source code
470         https://bugs.webkit.org/show_bug.cgi?id=137394
471
472         Reviewed by Philippe Normand.
473
474         * TestWebKitAPI/CMakeLists.txt: Add missing dependency rule.
475         * TestWebKitAPI/PlatformGTK.cmake: Only run
476         generate-forwarding-headers.pl when source code changes.
477         * WebKitTestRunner/PlatformGTK.cmake: Ditto.
478
479 2014-10-07  Tanay C  <tanay.c@samsung.com>
480
481         Remove build warnings in Hashmap API tests
482         https://bugs.webkit.org/show_bug.cgi?id=137484
483
484         Reviewed by Darin Adler.
485
486         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
487         (TestWebKitAPI::TEST): Changed EXPECT_EQ(false, addResult.isNewEntry) to EXPECT_FALSE(addResult.isNewEntry) 
488
489 2014-10-07  Jake Nielsen  <jacob_nielsen@apple.com>
490
491         Commit queue doesn't drop obsolete patches sometimes
492         https://bugs.webkit.org/show_bug.cgi?id=137460
493
494         Reviewed by Alexey Proskuryakov.
495
496         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
497         Adds another test patch for use in queues_unittest.py.
498         courtesy of Csaba Osztrogonác <ossy@webkit.org>
499         (MockBugzilla):
500         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
501         Raises a PatchIsNotValid exception in the case of validate() returning
502         false.
503         (CommitQueueTask.run):
504         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
505         Raises a PatchIsNotValid exception in the case of validate() returning
506         false.
507         (EarlyWarningSystemTask.run):
508         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
509         Defines PatchIsNotValid exception. 
510         (PatchIsNotValid):
511         (PatchIsNotValid.__init__):
512         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
513         Remove call to validate() and instead catches the PatchIsNotValid
514         exception.
515         (AbstractEarlyWarningSystem.review_patch):
516         * Scripts/webkitpy/tool/commands/queues.py:
517         Adds logic to catch the PatchIsNotValid exception.
518         (CommitQueue.process_work_item):
519         * Scripts/webkitpy/tool/commands/queues_unittest.py:
520         Adds the test_non_valid_patch test to ensure that invalid patches are
521         handled properly, and don't just result in indefinite spinning.
522         courtesy of Csaba Osztrogonác <ossy@webkit.org>
523         (test_non_valid_patch):
524
525 2014-10-07  Daniel Bates  <dabates@apple.com>
526
527         [iOS] Teach run-webkit-tests to honor TestExpectation file for iOS Simulator 64-bit builds
528         https://bugs.webkit.org/show_bug.cgi?id=137499
529
530         Reviewed by Simon Fraser.
531
532         Fixes an issue where the TestExpectation file for the iOS Simulator platform was only
533         honored when running run-webkit-tests with a 32-bit simulator build of iOS WebKit. We
534         should honor the TestExpectation file for the iOS Simulator platform for both 32- and 64-
535         bit simulator builds of iOS WebKit.
536
537         * Scripts/webkitpy/port/ios.py:
538         (IOSSimulatorPort._generate_all_test_configurations):
539
540 2014-10-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
541
542         [GTK] jhbuild modules should build xserver with the --without-dtrace option.
543         https://bugs.webkit.org/show_bug.cgi?id=137482
544
545         Reviewed by Martin Robinson.
546
547         * gtk/jhbuild.modules: Added --without-dtrace option to xserver jhbuild.modules config.
548
549 2014-10-07  Carlos Garcia Campos  <cgarcia@igalia.com>
550
551         [SOUP] TLS errors should take precedence over HTTP authentication
552         https://bugs.webkit.org/show_bug.cgi?id=137300
553
554         Reviewed by Sergio Villar Senin.
555
556         Add a test case to check that authenticate signal is not emitted
557         in case of TLS errors, and the load fails instead.
558
559         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
560         (webViewAuthenticationCallback):
561         (testTLSErrorsHTTPAuth):
562         (httpsServerCallback):
563         (beforeAll):
564
565 2014-10-06  Ryosuke Niwa  <rniwa@webkit.org>
566
567         Make webkit-patch find-users useful
568         https://bugs.webkit.org/show_bug.cgi?id=137475
569
570         Reviewed by Alexey Proskuryakov.
571
572         Make find-users use the CommitterList instead of accessing Bugzilla.
573
574         This essentially exposes the same functionality as webkitbot's whois command.
575
576         * Scripts/webkitpy/tool/commands/findusers.py:
577         (FindUsers.execute):
578
579 2014-10-06  Chris Fleizach  <cfleizach@apple.com>
580
581         AX: iOS8: Crash at -[WebAccessibilityObjectWrapper accessibilityElementAtIndex:]
582         https://bugs.webkit.org/show_bug.cgi?id=137289
583
584         Unreviewed build fix.
585
586         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
587         (AccessibilityUIElement::getChildrenWithRange):
588
589 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
590
591         build.webkit.org/dashboard: Add commit queue
592         https://bugs.webkit.org/show_bug.cgi?id=137462
593
594         Reviewed by Tim Horton.
595
596         Generalizes EWS into "bubble queue", which also includes commit queue and style queue.
597         Style queue is still invisible, as it doesn't have an associated platform, and also
598         we never have problems with it anyway, so it's not worth watching.
599
600         The UI now allows for adding more bots to the Other column (such as leaks bot).
601         To make that actually happen, we'll need to refactor QueueView, allowing for multiple
602         sources of data in a cell.
603
604         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js.
605         (BubbleQueue):
606         (BubbleQueue.prototype.get statusPageURL):
607         (BubbleQueue.prototype.update):
608         (BubbleQueue.prototype.loadDetailedStatus):
609         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js.
610         (BubbleQueueServer):
611         (BubbleQueueServer.prototype.jsonQueueLengthURL):
612         (BubbleQueueServer.prototype.jsonQueueStatusURL):
613         (BubbleQueueServer.prototype.queueStatusURL):
614         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js.
615         (BubbleQueueView):
616         (BubbleQueueView.prototype.update.appendQueue):
617         (BubbleQueueView.prototype.update):
618         (BubbleQueueView.prototype._addQueueHeadingToPopover):
619         (BubbleQueueView.prototype._popoverContentForBubbleQueue):
620         (BubbleQueueView.prototype._presentPopoverForBubbleQueue):
621         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js: Removed.
622         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js: Removed.
623         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js: Removed.
624         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
625         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
626         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
627         (.bubble-server-popover .popover-queue-heading .queue-charts-link):
628         (.bubble-server-popover .latest-status-no-link):
629         (.bubble-server-popover .bot-status-description):
630         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
631
632         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
633         (buildAggregateTable):
634         (buildQueuesTable):
635         Removed dysfunctional support for EWS for now. It will be different.
636
637 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
638
639         One more case of incorrect comparison in recordpatchevent.py
640         https://bugs.webkit.org/show_bug.cgi?id=137459
641
642         Reviewed by Tim Horton.
643
644         * QueueStatusServer/app.yaml:
645         * QueueStatusServer/loggers/recordpatchevent.py:
646         (RecordPatchEvent.started):
647
648 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
649
650         webkit-queues PatchLog is incorrect for patches that took less than a second
651         https://bugs.webkit.org/show_bug.cgi?id=137453
652
653         Reviewed by Tim Horton.
654
655         * QueueStatusServer/app.yaml: Updated app version.
656
657         * QueueStatusServer/loggers/recordpatchevent.py: (RecordPatchEvent.stopped):
658         Don't bail out for patches that took 0 seconds to process (as frequently happens
659         when a patch is obsolete).
660
661 2014-10-06  Csaba Osztrogonác  <ossy@webkit.org>
662
663         EWS bubble hover shows wrong timestamps
664         https://bugs.webkit.org/show_bug.cgi?id=137252
665
666         Reviewed by Alexey Proskuryakov.
667
668         Add "Z" suffix to timestamps to make sure if it is handled as UTC time.
669
670         * QueueStatusServer/handlers/queuestatusjson.py:
671         (QueueStatusJSON.get):
672         * QueueStatusServer/handlers/statusbubble.py:
673         (StatusBubble._iso_time):
674
675 2014-10-06  Mario Sanchez Prada  <mario@webkit.org>
676
677         Unreviewed, updated list of email addresses in contributors.json
678
679         * Scripts/webkitpy/common/config/contributors.json: Added my former
680         email address in Igalia, for the sake of completeness.
681
682 2014-10-06  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
683
684         Unreviewed, moved myself to the list of committers.
685
686         * Scripts/webkitpy/common/config/contributors.json:
687
688 2014-10-05  Ryuan Choi  <ryuan.choi@gmail.com>
689
690         [EFL] Introduce EWebKit_Extension
691         https://bugs.webkit.org/show_bug.cgi?id=134921
692
693         Reviewed by Gyuyoung Kim.
694
695         * MiniBrowser/efl/main.c: Added x option to test extension path.
696         (window_create):
697         (elm_main):
698         * Scripts/webkitpy/common/config/watchlist:
699         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFLWebKit2PublicAPI.
700         * Scripts/webkitpy/style/checker.py:
701         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFL exceptions.
702
703 2014-10-04  Csaba Osztrogonác  <ossy@webkit.org>
704
705         [jhbuild] Simplify platform detection in update-webkit-libs-jhbuild
706         https://bugs.webkit.org/show_bug.cgi?id=137390
707
708         Reviewed by Carlos Garcia Campos.
709
710         * Scripts/update-webkit-libs-jhbuild:
711
712 2014-10-04  Carlos Garcia Campos  <cgarcia@igalia.com>
713
714         [GTK] Do not generate webkit2gtk-tests-resources.gresource unconditionally
715         https://bugs.webkit.org/show_bug.cgi?id=137391
716
717         Reviewed by Martin Robinson.
718
719         Add a custom command to only re-generate
720         webkit2gtk-tests-resources.gresource when any of its dependencies changes.
721
722         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
723
724 2014-10-04  Carlos Garcia Campos  <cgarcia@igalia.com>
725
726         [GTK] generate-gtkdoc crashes when generating HTML due to encoding issues
727         https://bugs.webkit.org/show_bug.cgi?id=135502
728
729         Reviewed by Martin Robinson.
730
731         When writing to stdout/stderr fails due to a UnicodeDecodeError
732         exception, try again without encoding the output.
733
734         * gtk/gtkdoc.py:
735         (GTKDoc._run_command):
736
737 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
738
739         Bugzilla status bubble displays an exception showing attachment 175738
740         https://bugs.webkit.org/show_bug.cgi?id=137410
741
742         Reviewed by Tim Horton.
743
744         * QueueStatusServer/app.yaml: Update version.
745
746         * QueueStatusServer/handlers/statusbubble.py: (StatusBubble._build_bubble):
747         Don't fail even if expected status message is missing.
748
749         * QueueStatusServer/model/patchlog.py: (PatchLog): Quick unrelated fix - define
750         the field in the same way it's defined in QueueStatus table.
751
752 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
753
754         Record latest message in PatchLog for quick access
755         https://bugs.webkit.org/show_bug.cgi?id=137405
756
757         Fixing a typo.
758
759         * QueueStatusServer/app.yaml:
760         * QueueStatusServer/handlers/releasepatch.py:
761
762 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
763
764         Record latest message in PatchLog for quick access
765         https://bugs.webkit.org/show_bug.cgi?id=137405
766
767         Reviewed by Ryosuke Niwa.
768
769         It's no SQL...
770
771         * QueueStatusServer/handlers/releasepatch.py:
772         * QueueStatusServer/handlers/updatestatus.py:
773         * QueueStatusServer/loggers/recordpatchevent.py:
774         * QueueStatusServer/model/patchlog.py:
775
776 2014-10-02  David Farler  <dfarler@apple.com>
777
778         -asan-blacklist option also renamed to generic -fsanitize-blacklist
779         https://bugs.webkit.org/show_bug.cgi?id=137377
780
781         Reviewed by Daniel Bates.
782
783         * asan/asan.xcconfig:
784         -asan-blacklist -> -fsanitize-blacklist
785
786         http://llvm.org/viewvc/llvm-project?view=revision&revision=212505
787
788 2014-10-03  Roger Fong  <roger_fong@apple.com>
789
790         [Windows] Include batch size argument to layout tests on Windows.
791
792         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
793         (RunWebKitTests.start): 
794         This is a speculative fix for the the inconsistent crashes we are seeing on Windows.
795         These crashes seem to happen on random tests though generally in a spread out fashion.
796         It seems possible that the DRT instance is being clobbered somehow after running too many
797         tests in a row so we will try to mitigate this by just forcing DRT to restart periodically.
798
799 2014-10-03  Roger Fong  <roger_fong@apple.com>
800
801         [Windows] Settle for 2 chid processes running NRWT on Windows.
802
803         * Scripts/webkitpy/port/win.py:
804         (WinPort.default_child_processes): 3 child processes reintroduces the sporadic crashing, will settle for 2.
805
806 2014-10-03  Akos Kiss  <akiss@inf.u-szeged.hu>
807
808         [GTK] Bump up and patch dependencies to allow building for aarch64
809         https://bugs.webkit.org/show_bug.cgi?id=137147
810
811         Reviewed by Martin Robinson.
812
813         The currently used versions of pixman, libffi, librsvg, glib,
814         glib-networking, fontconfig, libxml2, gst-plugins-base fail to configure
815         and/or build for aarch64, so they are bumped up and patched where
816         necessary. Wherever possible, the same versions and patches were used as
817         for the EFL port bump-up
818         (https://bugs.webkit.org/show_bug.cgi?id=135885).
819
820         After the bump-up, a hitherto hidden bug in gst-plugins-good caused a
821         regression by crashing http/tests/media/video-redirect.html . A patch
822         already in upstream fixes that bug.
823
824         This change does not touch xserver, which also needs bumping up, but 
825         will be dealt with later.
826
827         * gtk/jhbuild.modules:
828         Specified versions and patches necessary to correctly build for aarch64.
829         * gtk/patches/gst-events-arent-gstobjects.patch:
830         Added. Patches gst-plugins-good to fix a bug in .mov file demuxing.
831         * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch:
832         Added. Patches gst-plugins-base to configure correctly for aarch64.
833         * gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch:
834         Added. Bumps up config.guess and config.sub in librsvg to recognize
835         aarch64.
836         * gtk/patches/libxml2-2.9.0-dtd.patch:
837         Removed. Not necessary for libxml2 v2.9.1 anymore.
838
839 2014-09-28  Sam Weinig  <sam@webkit.org>
840
841         Remove RefPtrHashMap
842         https://bugs.webkit.org/show_bug.cgi?id=137200
843
844         Reviewed by Darin Adler.
845
846         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
847         (TestWebKitAPI::TEST):
848         Add tests for using a HashMap with RefPtr keys, focusing on ensuring that
849         a minimum of refcount churn occurs.
850
851 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
852
853         Remove workarounds for versions of Python before 2.7
854         https://bugs.webkit.org/show_bug.cgi?id=137338
855
856         Reviewed by Csaba Osztrogonác.
857
858         * Scripts/webkitpy/common/system/autoinstall.py:
859         (AutoInstaller._extract_targz):
860         (AutoInstaller._unzip):
861         (AutoInstaller): Deleted.
862         (AutoInstaller._extract_all): Deleted.
863         * Scripts/webkitpy/common/webkitunittest.py:
864         (TestCase.setUp): Deleted.
865         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
866         (TestConfigurationConverter.collapse_macros):
867         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
868         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
869         (TestConfigurationConverter):
870         (TestConfigurationConverter.combinations): Deleted.
871         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
872         * Scripts/webkitpy/port/base.py:
873
874 2014-10-03  Commit Queue  <commit-queue@webkit.org>
875
876         Unreviewed, rolling out r174264.
877         https://bugs.webkit.org/show_bug.cgi?id=137392
878
879         It broke run-webkit-tests (Requested by ebalazsfalvi on
880         #webkit).
881
882         Reverted changeset:
883
884         "Remove workarounds for versions of Python before 2.7"
885         https://bugs.webkit.org/show_bug.cgi?id=137338
886         http://trac.webkit.org/changeset/174264
887
888 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
889
890         Remove workarounds for versions of Python before 2.7
891         https://bugs.webkit.org/show_bug.cgi?id=137338
892
893         Reviewed by Csaba Osztrogonác.
894
895         * Scripts/webkitpy/common/system/autoinstall.py:
896         (AutoInstaller._extract_targz):
897         (AutoInstaller._unzip):
898         (AutoInstaller): Deleted.
899         (AutoInstaller._extract_all): Deleted.
900         * Scripts/webkitpy/common/webkitunittest.py:
901         (TestCase.setUp): Deleted.
902         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
903         (TestConfigurationConverter.collapse_macros):
904         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
905         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
906         (TestConfigurationConverter):
907         (TestConfigurationConverter.combinations): Deleted.
908         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
909         * Scripts/webkitpy/port/base.py:
910         * Scripts/webkitpy/port/driver.py:
911         (ContentBlock.__init__):
912         * Scripts/webkitpy/port/server_process.py:
913         (ServerProcess._reset):
914
915 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
916
917         Remove autoinstaller workaround for python 2.6
918         https://bugs.webkit.org/show_bug.cgi?id=137343
919
920         Reviewed by Daniel Bates.
921
922         Reverting <http://trac.webkit.org/changeset/124928>, neither Python
923         2.6, nor Snow Leopard is supported anymore, so the workaround is not
924         needed anymore.
925
926         * Scripts/webkitpy/common/system/autoinstall.py:
927         (AutoInstaller.install):
928         * Scripts/webkitpy/test/main.py:
929         (Tester._run_tests):
930         * Scripts/webkitpy/thirdparty/__init__.py:
931         (AutoinstallImportHook._install_mechanize):
932         (AutoinstallImportHook._install_pep8):
933         (AutoinstallImportHook._install_pylint):
934         (AutoinstallImportHook._install_buildbot):
935         (AutoinstallImportHook._install_coverage):
936         (AutoinstallImportHook._install_eliza):
937         (AutoinstallImportHook._install_irc):
938         (AutoinstallImportHook._install):
939         (autoinstall_everything):
940
941 2014-10-02  Daniel Bates  <dabates@apple.com>
942
943         Use version number 101000 instead of 10100 for OS X Yosemite
944         https://bugs.webkit.org/show_bug.cgi?id=137372
945
946         Reviewed by Mark Rowe.
947
948         The version number for OS X Yosemite is 101000.
949
950         * DumpRenderTree/mac/TextInputController.m:
951
952 2014-10-02  Alexey Proskuryakov  <ap@apple.com>
953
954         update-work-items should never delete items
955         https://bugs.webkit.org/show_bug.cgi?id=137366
956
957         Reviewed by Ryosuke Niwa.
958
959         As we don't just replace the whole list any more, indicate which items are high
960         priority, and which are not. Hight priority ones will be prepended to the queue,
961         others will be appended.
962
963         This creates a bit of unfairness in that high priority item queue becomes a LIFO.
964         But hopefully we will never have many rollouts competing like that.
965
966         * QueueStatusServer/app.yaml: Update version.
967
968         * QueueStatusServer/handlers/updateworkitems.py: Never remove items. Pass high
969         priority and regular items separately. Removed some error handling that used to
970         end up in returning status 500 - an uncaught exception does that automatically.
971
972         * QueueStatusServer/main.py: Removed unnecessary regexps from URL matching code.
973
974         * QueueStatusServer/model/workitems.py: Added a way to add high priority items.
975
976         * QueueStatusServer/templates/updateworkitems.html: Added a field for high
977         priority items.
978
979         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
980         (BugzillaQueries._parse_attachment_ids_request_query): Removed an annoying log
981         line that complicated testing.
982
983         * Scripts/webkitpy/common/net/statusserver.py: Pass high priority items separately.
984
985         * Scripts/webkitpy/tool/bot/feeders.py: For commit queue, split high and regular
986         priority items into separate lists.
987
988         * Scripts/webkitpy/common/net/statusserver_mock.py:
989         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
990         * Scripts/webkitpy/tool/commands/queues_unittest.py:
991         Updated tests.
992
993 2014-10-02  Brendan Long  <b.long@cablelabs.com>
994
995         Annoying build warnings in WTFString API tests
996         https://bugs.webkit.org/show_bug.cgi?id=137360
997
998         Reviewed by Darin Adler.
999
1000         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1001         (TestWebKitAPI::TEST): Change EXPECT_EQ(false, ok) to EXPECT_FALSE(ok) and EXPECT_EQ(true, ok) to EXPECT_TRUE(ok).
1002
1003 2014-10-02  Roger Fong  <roger_fong@apple.com>
1004
1005         [Windows] The number of processes did not affect the crash inconsistency, increase number of child processes again.
1006
1007         * Scripts/webkitpy/port/win.py:
1008         (WinPort.default_child_processes): Ambitiously try 3 processes the testers are too slow now.
1009
1010 2014-10-02  David Farler  <dfarler@apple.com>
1011
1012         Move ASan arguments from LLVM (-mllvm) to the frontend
1013         https://bugs.webkit.org/show_bug.cgi?id=137365
1014
1015         Reviewed by David Kilzer.
1016
1017         * asan/asan.xcconfig:
1018         Remove the -mllvm prefix to the asan-blacklist argument, moving it
1019         to the clang frontend.
1020
1021         http://llvm.org/viewvc/llvm-project?view=revision&revision=212505
1022
1023 2014-10-02  Commit Queue  <commit-queue@webkit.org>
1024
1025         Unreviewed, rolling out r174120.
1026         https://bugs.webkit.org/show_bug.cgi?id=137350
1027
1028         While number of failures is reasonable with 2 processes, test
1029         results seem to be inconsistent between runs (Requested by
1030         rfong on #webkit).
1031
1032         Reverted changeset:
1033
1034         "[Windows] Back to 2 child processes for NRWT on Windows."
1035         http://trac.webkit.org/changeset/174120
1036
1037 2014-10-02  Jeff Miller  <jeffm@apple.com>
1038
1039         DumpRenderTree and WebKitTestRunner should use WebKitystemInterfaceYosemite when building on Yosemite
1040         https://bugs.webkit.org/show_bug.cgi?id=137347
1041
1042         Reviewed by Dan Bernstein.
1043
1044         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1045         Use WebKitSystemInterfaceYosemite on OS X 10.10.
1046
1047         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1048         Ditto.
1049
1050 2014-10-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1051
1052         [GTK] [JHBuild] Switch sourceware.org mirror to http.
1053
1054         Unreviewed.
1055
1056         The ftp access is recently failing to work as expected, and the
1057         bots fail to download the file.
1058         The same mirror is available via http and seems to work better.
1059
1060         * gtk/jhbuild.modules:
1061
1062 2014-10-01  Commit Queue  <commit-queue@webkit.org>
1063
1064         Unreviewed, rolling out r174185.
1065         https://bugs.webkit.org/show_bug.cgi?id=137334
1066
1067         Patch that adds logging causes webkitpy failures (Requested by
1068         rfong on #webkit).
1069
1070         Reverted changeset:
1071
1072         "commitqueuetasks_unittest references a non-existent member
1073         variable"
1074         https://bugs.webkit.org/show_bug.cgi?id=137303
1075         http://trac.webkit.org/changeset/174185
1076
1077 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
1078
1079         EWS and Commit Queue should know better than to spew 500 failed
1080         results in the case of extremely red patches.
1081         https://bugs.webkit.org/show_bug.cgi?id=137324
1082
1083         Reviewed by Alexey Proskuryakov.
1084
1085         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1086         Adds a check for did_exceed_test_failure_limit.
1087         (AbstractEarlyWarningSystem._failing_tests_message):
1088         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1089         Alters the task mock to respond properly to
1090         results_from_patch_test_run(patch)
1091         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
1092         * Scripts/webkitpy/tool/commands/queues.py:
1093         Adds a check for did_exceed_test_failure_limit.
1094         (CommitQueue._failing_tests_message):
1095
1096 2014-10-01  Daniel Bates  <dabates@apple.com>
1097
1098         Unreviewed, rolling out r174192.
1099
1100         Revert the unit test fix in r174192 since we reverted r174187
1101         in r174194 due to correctness issues. See
1102         <http://webkit.org/b/137329> for more details.
1103
1104         Reverted changeset:
1105
1106         "Test fix after r174187"
1107         http://trac.webkit.org/changeset/174192
1108
1109 2014-10-01  Mark Rowe  <mrowe@apple.com>
1110
1111         <https://webkit.org/b/137308> WebKit should build on OS X Yosemite for external users
1112
1113         Reviewed by Dan Bernstein.
1114
1115         * Scripts/copy-webkitlibraries-to-product-directory: Copy libWebKitSystemInterfaceYosemite.a
1116         into the build directory. Use LLVMIncludesYosemite.tar.bz2 and LLVMLibrariesYosemite.tar.bz2
1117         for the LLVM components when on Yosemite.
1118
1119 2014-10-01  Commit Queue  <commit-queue@webkit.org>
1120
1121         Unreviewed, rolling out r174187.
1122         https://bugs.webkit.org/show_bug.cgi?id=137329
1123
1124         webkitpy failures, and thorton says the patch is wrong
1125         (Requested by dethbakin on #webkit).
1126
1127         Reverted changeset:
1128
1129         "[Windows] Increase layout test timeout for Windows following
1130         r174162."
1131         http://trac.webkit.org/changeset/174187
1132
1133 2014-10-01  Brent Fulgham  <bfulgham@apple.com>
1134
1135         Test fix after r174187
1136
1137         * Scripts/webkitpy/port/win_unittest.py:
1138         (WinPortTest.test_default_timeout_ms): Expect the new 50000 ms timeout for Windows tests.
1139
1140 2014-10-01  Roger Fong  <roger_fong@apple.com>
1141
1142         [Windows] Increase layout test timeout for Windows following r174162.
1143
1144         * Scripts/webkitpy/port/win.py:
1145         (WinPort.default_timeout_ms):
1146
1147 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
1148
1149         commitqueuetasks_unittest references a non-existent member variable
1150         when mock-reporting flaky tests.
1151         https://bugs.webkit.org/show_bug.cgi?id=137303
1152
1153         Reviewed by Daniel Bates.
1154
1155         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1156         (MockCommitQueue.report_flaky_tests):
1157         Makes the appropriate name change.
1158         (test_simple_flaky_test_failure):
1159         Adds a unit test to make sure that the code is excercised.
1160
1161 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
1162
1163         EWS is inconclusively spinning forever on a patch that breaks 500+
1164         tests
1165         https://bugs.webkit.org/show_bug.cgi?id=137223
1166
1167         Reviewed by Tim Horton.
1168
1169         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1170         Checks to see whether the tests have exceeded the failure limit, and
1171         only spins off another test if they have not exceeded the limit.
1172         (PatchAnalysisTask._test_patch):
1173
1174 2014-10-01  Brian J. Burg  <burg@cs.washington.edu>
1175
1176         Unreviewed, add Katie Madonna as a contributor.
1177
1178         * Scripts/webkitpy/common/config/contributors.json:
1179
1180 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
1181
1182         commitqueuetasks_unittest does not construct FailingTestCommitQueue
1183         objects properly in its test cases.
1184         https://bugs.webkit.org/show_bug.cgi?id=137281
1185
1186         Reviewed by Daniel Bates.
1187
1188         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1189         (FailingTestCommitQueue.test_results):
1190         Adds an assert to make FailingTestCommitQueue harder to mis-use.
1191         (test_double_flaky_test_failure):
1192         Nests the intended test failure strings into one-length lists.
1193         (test_red_test_failure):
1194         Nests the intended test failure strings into one-length lists.
1195
1196 2014-10-01  Alexey Proskuryakov  <ap@apple.com>
1197
1198         REGRESSION (r172172): Multiple regression tests fail when primary system language is Russian
1199         https://bugs.webkit.org/show_bug.cgi?id=136987
1200
1201         Reviewed by Daniel Bates.
1202
1203         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues):
1204         Specify the default encoding for all WebKit developers to get consistent results.
1205
1206 2014-10-01  Alexey Proskuryakov  <ap@apple.com>
1207
1208         EWS is too eager to say that a patch does not apply to trunk of repository
1209         https://bugs.webkit.org/show_bug.cgi?id=137290
1210
1211         Reviewed by Ryosuke Niwa.
1212
1213         * QueueStatusServer/app.yaml: Updated app version.
1214
1215         * QueueStatusServer/handlers/statusbubble.py:
1216         (StatusBubble._build_bubble):
1217         (StatusBubble._build_bubbles_for_attachment):
1218         Rewrote to make more sense.
1219
1220 2014-09-30  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1221
1222         Remove thirdparty/unittest2 from webkitpy
1223         https://bugs.webkit.org/show_bug.cgi?id=137251
1224
1225         Reviewed by Brent Fulgham.
1226
1227         Additionally ordered imports in related webkitpy files and
1228         removed unnecessary shebangs from unittest files.
1229
1230         * BuildSlaveSupport/build.webkit.org-config/htdigestparser_unittest.py:
1231         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1232         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1233         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
1234         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
1235         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
1236         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1237         * Scripts/webkitpy/common/config/committers_unittest.py:
1238         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
1239         * Scripts/webkitpy/common/config/contributionareas_unittest.py:
1240         * Scripts/webkitpy/common/config/ports_unittest.py:
1241         * Scripts/webkitpy/common/config/urls_unittest.py:
1242         * Scripts/webkitpy/common/editdistance_unittest.py:
1243         * Scripts/webkitpy/common/find_files_unittest.py:
1244         * Scripts/webkitpy/common/lru_cache_unittest.py:
1245         * Scripts/webkitpy/common/memoized_unittest.py:
1246         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py:
1247         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1248         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1249         * Scripts/webkitpy/common/net/credentials_unittest.py:
1250         * Scripts/webkitpy/common/net/failuremap_unittest.py:
1251         * Scripts/webkitpy/common/net/irc/ircproxy_unittest.py:
1252         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1253         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
1254         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
1255         * Scripts/webkitpy/common/net/statusserver_unittest.py:
1256         * Scripts/webkitpy/common/net/unittestresults_unittest.py:
1257         * Scripts/webkitpy/common/newstringio_unittest.py:
1258         * Scripts/webkitpy/common/prettypatch_unittest.py:
1259         * Scripts/webkitpy/common/read_checksum_from_png_unittest.py:
1260         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
1261         * Scripts/webkitpy/common/system/environment_unittest.py:
1262         * Scripts/webkitpy/common/system/executive.py: Ordered imports.
1263         * Scripts/webkitpy/common/system/executive_mock.py: Ordered imports.
1264         * Scripts/webkitpy/common/system/executive_unittest.py:
1265         * Scripts/webkitpy/common/system/file_lock_integrationtest.py:
1266         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
1267         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1268         * Scripts/webkitpy/common/system/logtesting.py:
1269         * Scripts/webkitpy/common/system/logutils_unittest.py:
1270         * Scripts/webkitpy/common/system/outputcapture.py:
1271         * Scripts/webkitpy/common/system/outputcapture_unittest.py:
1272         * Scripts/webkitpy/common/system/outputtee_unittest.py:
1273         * Scripts/webkitpy/common/system/path_unittest.py:
1274         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
1275         * Scripts/webkitpy/common/system/profiler_unittest.py:
1276         * Scripts/webkitpy/common/system/stack_utils_unittest.py:
1277         * Scripts/webkitpy/common/system/user_unittest.py:
1278         * Scripts/webkitpy/common/system/workspace_unittest.py:
1279         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
1280         * Scripts/webkitpy/common/thread/messagepump_unittest.py:
1281         * Scripts/webkitpy/common/thread/threadedmessagequeue_unittest.py:
1282         * Scripts/webkitpy/common/watchlist/amountchangedpattern_unittest.py:
1283         * Scripts/webkitpy/common/watchlist/changedlinepattern_unittest.py:
1284         * Scripts/webkitpy/common/watchlist/filenamepattern_unittest.py:
1285         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py:
1286         * Scripts/webkitpy/common/watchlist/watchlistrule_unittest.py:
1287         * Scripts/webkitpy/common/webkitunittest.py:
1288         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
1289         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1290         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
1291         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1292         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
1293         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
1294         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1295         * Scripts/webkitpy/layout_tests/models/test_failures_unittest.py:
1296         * Scripts/webkitpy/layout_tests/models/test_results_unittest.py:
1297         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
1298         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1299         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
1300         * Scripts/webkitpy/layout_tests/servers/http_server_base_unittest.py:
1301         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
1302         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1303         * Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py:
1304         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
1305         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1306         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1307         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
1308         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1309         * Scripts/webkitpy/port/base_unittest.py:
1310         * Scripts/webkitpy/port/builders_unittest.py:
1311         * Scripts/webkitpy/port/config_unittest.py:
1312         * Scripts/webkitpy/port/driver_unittest.py:
1313         * Scripts/webkitpy/port/efl_unittest.py:
1314         * Scripts/webkitpy/port/factory_unittest.py:
1315         * Scripts/webkitpy/port/gtk_unittest.py:
1316         * Scripts/webkitpy/port/http_lock_unittest.py:
1317         * Scripts/webkitpy/port/image_diff_unittest.py:
1318         * Scripts/webkitpy/port/leakdetector_unittest.py:
1319         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py:
1320         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
1321         * Scripts/webkitpy/port/mock_drt_unittest.py:
1322         * Scripts/webkitpy/port/port_testcase.py:
1323         * Scripts/webkitpy/port/server_process_unittest.py:
1324         * Scripts/webkitpy/port/westondriver_unittest.py:
1325         * Scripts/webkitpy/port/win_unittest.py:
1326         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
1327         * Scripts/webkitpy/style/checker_unittest.py:
1328         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
1329         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
1330         * Scripts/webkitpy/style/checkers/common_unittest.py:
1331         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1332         * Scripts/webkitpy/style/checkers/exportfile_unittest.py:
1333         * Scripts/webkitpy/style/checkers/js_unittest.py:
1334         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py:
1335         * Scripts/webkitpy/style/checkers/messagesin_unittest.py:
1336         * Scripts/webkitpy/style/checkers/png_unittest.py:
1337         * Scripts/webkitpy/style/checkers/python_unittest.py:
1338         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1339         * Scripts/webkitpy/style/checkers/text_unittest.py:
1340         * Scripts/webkitpy/style/checkers/watchlist_unittest.py:
1341         * Scripts/webkitpy/style/checkers/xcodeproj_unittest.py:
1342         * Scripts/webkitpy/style/checkers/xml_unittest.py:
1343         * Scripts/webkitpy/style/error_handlers_unittest.py:
1344         * Scripts/webkitpy/style/filereader_unittest.py:
1345         * Scripts/webkitpy/style/filter_unittest.py:
1346         * Scripts/webkitpy/style/main_unittest.py:
1347         * Scripts/webkitpy/style/optparser_unittest.py:
1348         * Scripts/webkitpy/style/patchreader_unittest.py:
1349         * Scripts/webkitpy/test/finder_unittest.py:
1350         * Scripts/webkitpy/test/main.py: Ordered imports.
1351         * Scripts/webkitpy/test/main_unittest.py:
1352         * Scripts/webkitpy/test/printer.py: Ordered imports.
1353         (Printer.configure):
1354         * Scripts/webkitpy/test/runner_unittest.py:
1355         * Scripts/webkitpy/test/skip_unittest.py:
1356         * Scripts/webkitpy/thirdparty/__init__.py:
1357         (AutoinstallImportHook._install_irc):
1358         (AutoinstallImportHook._install_unittest2): Deleted.
1359         * Scripts/webkitpy/thirdparty/__init___unittest.py:
1360         * Scripts/webkitpy/thirdparty/ordered_dict.py: Removed.
1361         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py:
1362         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
1363         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1364         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
1365         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1366         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1367         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1368         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
1369         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
1370         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1371         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
1372         * Scripts/webkitpy/tool/commands/download_unittest.py:
1373         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
1374         * Scripts/webkitpy/tool/commands/perfalizer_unittest.py:
1375         * Scripts/webkitpy/tool/commands/queries_unittest.py:
1376         * Scripts/webkitpy/tool/commands/queuestest.py:
1377         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1378         * Scripts/webkitpy/tool/grammar_unittest.py:
1379         * Scripts/webkitpy/tool/mocktool_unittest.py:
1380         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
1381         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1382         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
1383         * Scripts/webkitpy/tool/servers/reflectionhandler_unittest.py:
1384         * Scripts/webkitpy/tool/steps/addsvnmimetypeforpng_unittest.py:
1385         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py:
1386         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
1387         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
1388         * Scripts/webkitpy/tool/steps/commit_unittest.py:
1389         * Scripts/webkitpy/tool/steps/discardlocalchanges_unittest.py:
1390         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
1391         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
1392         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
1393         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1394         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1395         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
1396         * Scripts/webkitpy/tool/steps/update_unittest.py:
1397         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
1398         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
1399         * Scripts/webkitpy/w3c/test_converter_unittest.py:
1400         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1401         * Scripts/webkitpy/w3c/test_parser_unittest.py:
1402
1403 2014-09-30  Jake Nielsen  <jacob_nielsen@apple.com>
1404
1405         LayoutTestResults and ExpectedFailures should know about the
1406         interrupted flag from the json results file
1407         https://bugs.webkit.org/show_bug.cgi?id=137229
1408
1409         Reviewed by Daniel Bates.
1410
1411         Changes LayoutTestResults to use the interrupted flag instead of
1412         counting failures.
1413
1414         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1415         (BuilderTest._install_fetch_build._mock_fetch_build):
1416         (BuilderTest.test_latest_layout_test_results):
1417         * Scripts/webkitpy/common/net/layouttestresults.py:
1418         Removes notion of failure_limit_count, and adds
1419         did_exceed_test_failure_limit.
1420
1421         (LayoutTestResults.results_from_string):
1422         (LayoutTestResults.__init__):
1423         (LayoutTestResults.did_exceed_test_failure_limit):
1424         (LayoutTestResults): Deleted.
1425         (LayoutTestResults.set_failure_limit_count): Deleted.
1426         (LayoutTestResults.failure_limit_count): Deleted.
1427         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1428         Removes unit test for failure_limit_count logic.
1429
1430         (LayoutTestResultsTest.test_set_failure_limit_count): Deleted.
1431         * Scripts/webkitpy/common/net/resultsjsonparser.py:
1432         Instead of providing a class method that returns a list of
1433         TestResults objects, resultsjsonparser now provides a class
1434         ParsedJSONResults that serves as an interface between the results.json
1435         file and the rest of webkitpy.
1436
1437         (ParsedJSONResults):
1438         (ParsedJSONResults.__init__):
1439         (ParsedJSONResults.did_exceed_test_failure_limit):
1440         (ParsedJSONResults.test_results):
1441         (ResultsJSONParser): Deleted.
1442         (ResultsJSONParser.parse_results_json): Deleted.
1443         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
1444         Updates the unit test so that it can test the new ResultsJSONParser
1445         class.
1446
1447         (ParsedJSONResultsTest):
1448         (test_basic):
1449         (ResultsJSONParserTest): Deleted.
1450         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1451         Updates the unit test to instantiate ResultsJSONParser objects rather
1452         than simple lists of TestResult objects.
1453
1454         (MockCommitQueue.test_results):
1455         (FailingTestCommitQueue.test_results):
1456         (test_flaky_test_failure):
1457         (test_failed_archive):
1458         * Scripts/webkitpy/tool/bot/expectedfailures.py:
1459         Updates ExpectedFailures to use the did_exceed_test_failure_limit
1460         method rather than counting the number of failed tests.
1461
1462         (ExpectedFailures._should_trust):
1463         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
1464         Updates MockResults to more closely resemble the updated
1465         LayoutTestResults class.
1466
1467         (MockResults.__init__):
1468         (MockResults.did_exceed_test_failure_limit):
1469         (ExpectedFailuresTest.test_can_trust_results):
1470         (ExpectedFailuresTest.test_unexpected_failures_observed):
1471         (ExpectedFailuresTest.test_unexpected_failures_observed_when_tree_is_hosed):
1472         (MockResults.failure_limit_count): Deleted.
1473         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
1474         Removes a FIXME regarding the use of the
1475         NON_INTERACTIVE_FAILURE_LIMIT_COUNT value.
1476
1477         (LayoutTestResultsReader.results):
1478         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
1479         Updates test to not check the now-nonexistant failure_count_limit
1480         method.
1481
1482         (test_missing_unit_test_results_path):
1483         (test_layout_test_results):
1484         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
1485         Accounts for name change: ResultsJSONParserTest ->
1486         ParsedJSONParserTest.
1487
1488         (RebaselineTestTest.test_gather_baselines):
1489
1490 2014-09-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1491
1492         [EFL] Rename TEST_THEME_DIR macro
1493         https://bugs.webkit.org/show_bug.cgi?id=137244
1494
1495         Reviewed by Csaba Osztrogonác.
1496
1497         TEST_THEME_DIR is to get a path for default theme though, it has used TEST_ prefix.
1498         DEFAULT_THEME_DIR is better than it.
1499
1500         * MiniBrowser/efl/main.c:
1501         (window_create):
1502         * TestWebKitAPI/efl/PlatformWebView.cpp:
1503         (TestWebKitAPI::PlatformWebView::PlatformWebView):
1504         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1505         (WTR::PlatformWebView::PlatformWebView):
1506
1507 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
1508
1509         Windows EWS went purple when it failed to build
1510         https://bugs.webkit.org/show_bug.cgi?id=137267
1511
1512         Reviewed by Ryosuke Niwa.
1513
1514         * QueueStatusServer/app.yaml: Update the version.
1515
1516         * QueueStatusServer/model/attachment.py: (Attachment._calculate_queue_positions):
1517         Make it work for style and win-ews queues.
1518
1519 2014-09-29  Filip Pizlo  <fpizlo@apple.com>
1520
1521         It should be fun and easy to run every possible JavaScript benchmark from the command line
1522         https://bugs.webkit.org/show_bug.cgi?id=137245
1523
1524         Reviewed by Oliver Hunt.
1525         
1526         We previously had Tools/Scripts/bencher.  Then we stopped adding things to it because we
1527         weren't sure about the licensing of things like Kraken and Octane.  Various people ended up
1528         having their own private scripts for doing benchmark runs, and didn't share them in the open
1529         source community, because of fears about the shady licensing of the benchmarks suites that
1530         they were running. The dominant version of this was "run-jsc-benchmarks", which has a lot of
1531         excellent power - it can run benchmarks through either jsc, DumpRenferTree, or
1532         WebKitTestRunner; it can run tests on any number of remote machines; and it has inside
1533         knowledge about how to run *a lot* of test suites. Many of those test suites are not public,
1534         but some of them are. The non-public tests are exclusively those that were not made by any
1535         WebKit contributor, but which JSC/WebKit devs found useful for testing.
1536
1537         This fixes this weirdness by releasing run-jsc-benchmarks. The paths to the test suites
1538         whose licenses are incompatible with WebKit's (to the extent that they cannot be safely
1539         checked into WebKit svn at all) can be run by passing the path to them via a configuration
1540         file. The default configuration file is ~/.run-jsc-benchmarks. The most important benchmark
1541         suites are Octane version 2 and Kraken version 1.1. We should probably check Octane 2 into
1542         WebKit eventually because it seems that the license is fine. Kraken, on the other hand, will
1543         probably never be checked in because there is no license text anywhere in that benchmark.
1544         A valid ~/.run-jsc-benchmarks file will just be something like:
1545         
1546             {
1547                 "OctanePath": "/path/to/Octane2",
1548                 "KrakenPath": "/path/to/Kraken-1.1/tests/kraken-1.1"
1549             }
1550         
1551         If your ~/.run-jsc-benchmarks file omits the directory for any particular test suite, then
1552         run-jsc-benchmarks will just gracefully avoid running that test suite.
1553         
1554         Finally, a word about policy: it is understood that different organizations that do
1555         development on JSC may find themselves having internal benchmarks that they cannot share
1556         because of weird licensing. It happens - usually because the organization doing JSC
1557         development found some test in the wild that is owned by someone else and therefore cannot
1558         be shared. So, we should consider it acceptable to write patches against run-jsc-benchmarks
1559         that add support for some new kind of benchmark suite even if the suite is not made public
1560         as part of the same patch - so long as the patch isn't too invasive. An example of
1561         non-invasiveness is the DSPJS suite, which is implemented using some new classes (like
1562         DSPJSAmmoJSRegularBenchmark) and some calls to otherwise reusable functions (like
1563         emitSelfContainedBenchRunCode). It is obviously super helpful if a benchmark suite can be
1564         completely open-sourced and committed to the WebKit repo - but the reality is that this
1565         can't always be done safely.
1566
1567         * Scripts/bencher: Removed.
1568         * Scripts/run-jsc-benchmarks: Added.
1569
1570 2014-09-30  Roger Fong  <roger_fong@apple.com>
1571
1572         [Windows] Add some logging to webkitpy to debug timeout issues with running NRWT using multiple child processes.
1573
1574         * Scripts/webkitpy/port/drdiver.py:
1575         (Driver.stop):
1576         * Scripts/webkitpy/port/server_process.py:
1577         (ServerProcess.stop):
1578
1579 2014-09-30  Roger Fong  <roger_fong@apple.com>
1580
1581         [Windows] Back to 2 child processes for NRWT on Windows.
1582
1583         * Scripts/webkitpy/port/win.py:
1584         (WinPort.default_child_processes):
1585         Changing the number of processes to 1 did not have an effect on the layout test results. 
1586         It does introduce an issue with one of the workers hanging indefinitely and causing the 
1587         layout tests to timeout as a whole occasionally, but we should just fix that.
1588
1589 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
1590
1591         Remove an accidentally committed line..
1592
1593         * QueueStatusServer/handlers/statusbubble.py:
1594         (StatusBubble._build_bubble):
1595
1596 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
1597
1598         build.webkit.org/dashboard: Switch EWS view to using actual retry count
1599         https://bugs.webkit.org/show_bug.cgi?id=137240
1600
1601         Reviewed by Ryosuke Niwa.
1602
1603         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
1604         (EWSQueue.prototype.loadDetailedStatus):
1605         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js:
1606         (EWSQueueView.prototype._popoverContentForEWSQueue):
1607         Use the new retry_count data member from JSON.
1608
1609         * QueueStatusServer/app.yaml: Updating the version.
1610
1611         * QueueStatusServer/handlers/queuestatusjson.py: (QueueStatusJSON._rows_for_work_items):
1612         Instead of message_count, produce retry_count.
1613
1614 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
1615
1616         EWS doesn't need to show all the bubbles when a patch fails to apply
1617         https://bugs.webkit.org/show_bug.cgi?id=137256
1618
1619         Reviewed by Ryosuke Niwa.
1620
1621         * QueueStatusServer/app.yaml: Updated app version.
1622
1623         * QueueStatusServer/handlers/statusbubble.py:
1624         (StatusBubble._build_bubble):
1625         (StatusBubble._build_bubbles_for_attachment):
1626         (StatusBubble.get):
1627         * QueueStatusServer/templates/statusbubble.html:
1628         When some queues fail to apply, and no queues had meaningful output (meaning that
1629         they will almost certainly fail to apply later), we can show a single bubble
1630         telling the user just that.
1631
1632 2014-09-30  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1633
1634         [EFL] Bump EFL version to 1.11.2
1635         https://bugs.webkit.org/show_bug.cgi?id=137118
1636
1637         Reviewed by Gyuyoung Kim.
1638
1639         Disable NEON for EFL build because the build system doesn't pass the necessary -mfpu=neon flag to the compiler.
1640         Tools/efl/patches/ecore.patch: Removed, because this fix is already in EFL.
1641
1642         * efl/jhbuild.modules:
1643         * efl/patches/ecore.patch: Removed.
1644
1645 2014-09-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1646
1647         REGRESSION(r173929): [GTK] TestInspector fails after r173929
1648         https://bugs.webkit.org/show_bug.cgi?id=137247
1649
1650         Reviewed by Philippe Normand.
1651
1652         Wait until can-attach property changes before trying to attach the
1653         inspector after resizing the view.
1654
1655         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp:
1656         (testInspectorDefault):
1657
1658 2014-09-30  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1659
1660         Require Python 2.7 version
1661         https://bugs.webkit.org/show_bug.cgi?id=137112
1662
1663         Reviewed by Csaba Osztrogonác.
1664
1665         * Scripts/ensure-valid-python:
1666         (checkPythonVersion):
1667         * Scripts/webkitpy/common/version_check.py:
1668
1669 2014-09-30  Martin Hock  <mhock@apple.com>
1670
1671         Skip a JSC test after r174036.
1672         https://bugs.webkit.org/show_bug.cgi?id=137236
1673
1674         Reviewed by Csaba Osztrogonác.
1675
1676         * Scripts/run-javascriptcore-tests:
1677
1678 2014-09-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1679
1680         [GTK] [EFL] Install TestNetscapePlugin apart from the other libs.
1681         https://bugs.webkit.org/show_bug.cgi?id=137212
1682
1683         This moves TestNetscapePlugin to a new folder (lib/plugins).
1684         We should not use the same directory for TestNetscapePlugin and
1685         the other libraries, because we end up scanning all the .so in the
1686         lib dir for every test.
1687
1688         Reviewed by Carlos Garcia Campos.
1689
1690         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Set LIBRARY_OUTPUT_DIRECTORY to lib/plugins.
1691         * Scripts/webkitpy/port/efl.py:
1692         (EflPort.setup_environ_for_server): Update plugin path.
1693         * Scripts/webkitpy/port/gtk.py:
1694         (GtkPort.setup_environ_for_server): Update plugin path.
1695         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Update plugin path.
1696
1697 2014-09-29  Alexey Proskuryakov  <ap@apple.com>
1698
1699         A small change to EWS bubble text. Explain why there are messages for ineligible patches.
1700
1701         Rubber-stamped by Tim Horton.
1702
1703         * QueueStatusServer/app.yaml:
1704         * QueueStatusServer/handlers/statusbubble.py:
1705         (StatusBubble._build_bubble):
1706
1707 2014-09-29  Alexey Proskuryakov  <ap@apple.com>
1708
1709         Typo fix, suggested by Tim Horton.
1710
1711         * QueueStatusServer/handlers/statusbubble.py:
1712         (StatusBubble._build_message_for_provisional_failure):
1713
1714 2014-09-29  Alexey Proskuryakov  <ap@apple.com>
1715
1716         Improve Bugzilla status bubbles
1717         https://bugs.webkit.org/show_bug.cgi?id=137232
1718
1719         Reviewed by Ryosuke Niwa.
1720
1721         * QueueStatusServer/app.yaml: Will update again with an actual version when landing.
1722
1723         * QueueStatusServer/handlers/statusbubble.py: Eliminated yellow color, added
1724         blue and orange. Significantly extended tooltips. Made bubbles show up even for queues
1725         that are stuck, as it was only confusing that they disappeared after 99.
1726
1727         * QueueStatusServer/model/attachment.py: Removed functionality that was only used
1728         by old bubbles. We need a lot more information to determine color, so the implementation
1729         can not be here.
1730
1731         * QueueStatusServer/templates/statusbubble.html: Updated colors in CSS, made bubbles
1732         always have a link for consistency. Added code to convert timestamps in tooltips
1733         to local time zone.
1734
1735 2014-09-29  Commit Queue  <commit-queue@webkit.org>
1736
1737         Unreviewed, rolling out r174045.
1738         https://bugs.webkit.org/show_bug.cgi?id=137231
1739
1740         Introduced a crash during page loading tests on Mac (Requested
1741         by rniwa on #webkit).
1742
1743         Reverted changeset:
1744
1745         "Replace OSObjectPtr with RetainPtr/adoptOS"
1746         https://bugs.webkit.org/show_bug.cgi?id=137158
1747         http://trac.webkit.org/changeset/174045
1748
1749 2014-09-29  Tim Horton  <timothy_horton@apple.com>
1750
1751         Add Jake as a contributor.
1752
1753         * Scripts/webkitpy/common/config/contributors.json:
1754
1755 2014-09-29  Roger Fong  <roger_fong@apple.com>
1756
1757         [Windows] Skip a javascriptcore test following r174036.
1758
1759         * Scripts/run-javascriptcore-tests:
1760
1761 2014-09-29  Roger Fong  <roger_fong@apple.com>
1762
1763         [Windows] Reduce number of processes used by NRWT on Windows to 1.
1764
1765         * Scripts/webkitpy/port/win.py:
1766         (WinPort.default_child_processes):
1767         Reduce number of processes to 1 so we can get a good baseline for what failures
1768         we should be expecting to see from the Windows bots.
1769
1770 2014-09-29  Darin Adler  <darin@apple.com>
1771
1772         Tweak and tighten SVG font converter
1773         https://bugs.webkit.org/show_bug.cgi?id=136956
1774
1775         Reviewed by Myles Maxfield.
1776
1777         I was investigating behavior of String::toInt, String::toDouble, and
1778         String::toFloat for various failure cases, and decided to start some
1779         unit tests for those functions here.
1780
1781         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1782         (TestWebKitAPI::TEST): Addded a first small bit of StringToInt and
1783         StringToDouble testing.
1784
1785 2014-09-29  Philippe Normand  <pnormand@igalia.com>
1786
1787         [GTK][CMake] TestWebCore target build sometimes fail
1788         https://bugs.webkit.org/show_bug.cgi?id=137207
1789
1790         Reviewed by Csaba Osztrogon.
1791
1792         * TestWebKitAPI/PlatformGTK.cmake: Make sure the forwarding
1793         headers are generated before the TestWebCore target is built.
1794
1795 2014-09-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1796
1797         [GTK] Remove IntPointGtk.cpp and IntRectGtk.cpp
1798         https://bugs.webkit.org/show_bug.cgi?id=137209
1799
1800         Reviewed by Philippe Normand.
1801
1802         * TestWebKitAPI/PlatformGTK.cmake: Remove unneeded IntRectGtk.cpp
1803         from the WebCore test sources.
1804
1805 2014-09-28  Myles C. Maxfield  <mmaxfield@apple.com>
1806
1807         Allow webkit-patch upload to respect the --directory argument with git checkouts
1808         https://bugs.webkit.org/show_bug.cgi?id=137166
1809
1810         Reviewed by Darin Adler.
1811
1812         We simply hadn't plumbed it through.
1813
1814         * Scripts/webkitpy/common/checkout/scm/detection.py:
1815         (SCMDetector.detect_scm_system):
1816         * Scripts/webkitpy/common/checkout/scm/git.py:
1817         (Git.__init__):
1818         (Git.changed_files):
1819
1820 2014-09-26  Sam Weinig  <sam@webkit.org>
1821
1822         Replace OSObjectPtr with RetainPtr/adoptOS
1823         https://bugs.webkit.org/show_bug.cgi?id=137158
1824
1825         Reviewed by Dan Bernstein.
1826
1827         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1828         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp: Removed.
1829         * TestWebKitAPI/Tests/WTF/darwin/RetainPtrOSObject.cpp: Copied from Tools/TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp.
1830         Rename and change test to use RetainPtr. Remove now unneeded part testing WTF::retainOSObject/WTF::releaseOSObject.
1831
1832 2014-09-26  Filip Pizlo  <fpizlo@apple.com>
1833
1834         Disable function.arguments
1835         https://bugs.webkit.org/show_bug.cgi?id=137167
1836
1837         Rubber stamped by Geoffrey Garen
1838         
1839         Enable the feature by default during tests.
1840
1841         * Scripts/run-jsc-stress-tests:
1842
1843 2014-09-26  Beth Dakin  <bdakin@apple.com>
1844
1845         Many platform/mac-wk2/tiled-drawing/ tests fail when run on a retina device
1846         https://bugs.webkit.org/show_bug.cgi?id=137089
1847
1848         Reviewed by Tim Horton.
1849
1850         This is a little sneaky since updateWindowScaleForTest() should ensure that these 
1851         tests run at 1x, but that code does not seem to execute at the right time for 
1852         these tests, so if we just ensure we start out at 1x, that appears to fix these 
1853         tests and does not break the HiDPI tests either.
1854         * WebKitTestRunner/TestController.cpp:
1855         (WTR::TestController::createWebViewWithOptions):
1856
1857 2014-09-26  Roger Fong  <roger_fong@apple.com>
1858
1859         [Windows] Decrease default number of child processes used by Windows.
1860
1861         * Scripts/webkitpy/port/win.py:
1862         (WinPort.default_child_processes):
1863         Having too many seems to cause many tests to crash or timeout. 
1864         We may even need to make it have only 1 child process if we’re still seeing problems after this.
1865
1866 2014-09-26  Alexey Proskuryakov  <ap@apple.com>
1867
1868         Mac EWS bots do not keep logs as promised
1869         https://bugs.webkit.org/show_bug.cgi?id=137151
1870
1871         Reviewed by Ryosuke Niwa.
1872
1873         * EWSTools/start-queue-mac.sh: Actually keep the logs for 14 days.
1874
1875 2014-09-26  Alexey Proskuryakov  <ap@apple.com>
1876
1877         Get rid of webkit-queues dashboard
1878         https://bugs.webkit.org/show_bug.cgi?id=137141
1879
1880         Reviewed by Ryosuke Niwa.
1881
1882         * QueueStatusServer/app.yaml: Updated version.
1883
1884         * QueueStatusServer/templates/dashboard.html: Removed.
1885         * QueueStatusServer/handlers/dashboard.py: Removed.
1886         * QueueStatusServer/main.py:
1887         Kill it!
1888
1889         * QueueStatusServer/stylesheets/common.css: Copied from Tools/QueueStatusServer/stylesheets/dashboard.css.
1890         (.status-cell): Deleted.
1891         (.status-cell:hover): Deleted.
1892         (.status-cell.pass): Deleted.
1893         (.status-cell.fail): Deleted.
1894         (.status-cell.pending): Deleted.
1895         (.status-cell.error): Deleted.
1896         * QueueStatusServer/stylesheets/dashboard.css: Removed.
1897         * QueueStatusServer/templates/activebots.html:
1898         * QueueStatusServer/templates/patch.html:
1899         * QueueStatusServer/templates/queuestatus.html:
1900         * QueueStatusServer/templates/recentstatus.html:
1901         Renamed dashboard.css to common.css, and removed dashboard-only rules.
1902
1903 2014-09-26  Alexey Proskuryakov  <ap@apple.com>
1904
1905         Get rid of Retry status in webkit-queues
1906         https://bugs.webkit.org/show_bug.cgi?id=137135
1907
1908         Reviewed by Ryosuke Niwa.
1909
1910         * QueueStatusServer/config/messages.py: Removed Retry.
1911
1912         * QueueStatusServer/handlers/releasepatch.py: This is now straightforward, as it
1913         no longer needs to check the latest status. It just always both unlocks the patch
1914         and removes it from WorkItems.
1915
1916         * QueueStatusServer/handlers/submittoews.py: (SubmitToEWS._should_add_to_ews_queue):
1917         I don't understand why we even needed to check for retries here, but now that there
1918         are no retries, that code can go to /dev/null.
1919
1920         * QueueStatusServer/loggers/recordpatchevent.py:
1921         (RecordPatchEvent.started):
1922         (RecordPatchEvent.retrying): Deleted.
1923         Fixed retry counting, it should work for all queues now.
1924
1925         * QueueStatusServer/model/queuestatus.py:
1926         (QueueStatus.is_retry_request): Deleted. These are no more.
1927
1928         * Scripts/webkitpy/common/net/statusserver_mock.py:
1929         (MockStatusServer.release_lock):
1930         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1931         Did whatever it took to keep passing the tests. The particular test doesn't seem
1932         quite right, but whatever.
1933
1934         * Scripts/webkitpy/tool/commands/queues.py:
1935         (CommitQueue.process_work_item): Instead of posting a retry status, just unlock
1936         and let others pick up. Also, added explicit returns for clarity.
1937         (AbstractPatchQueue._did_retry): Deleted.
1938
1939 2014-09-26  Csaba Osztrogonác  <ossy@webkit.org>
1940
1941         [EFL] Fix the gst-libav build on ARM Thumb2
1942         https://bugs.webkit.org/show_bug.cgi?id=137022
1943
1944         Reviewed by Zoltan Herczeg.
1945
1946         * efl/jhbuild.modules:
1947         * efl/patches/gst-libav.patch: Added.
1948
1949 2014-09-26  Akos Kiss  <akiss@inf.u-szeged.hu>
1950
1951         [EFL] Bump up dependencies not to conflict with the GTK port.
1952         https://bugs.webkit.org/show_bug.cgi?id=137143
1953
1954         Reviewed by Gyuyoung Kim.
1955
1956         Tools/efl/install-dependencies and Tools/gtk/install-dependencies keep
1957         installing and removing different versions of libgnutls-dev, thus
1958         hindering the development for both ports on the same machine. GTK is
1959         using the newer version of the package, now bumping up EFL to use the 
1960         same.
1961
1962         * efl/install-dependencies:
1963
1964 2014-09-25  Rohit Kumar  <kumar.rohit@samsung.com>
1965
1966         [EFL][WK2] Minibrowser : Fix the 'Escape' button issue to exit fullscreen
1967         https://bugs.webkit.org/show_bug.cgi?id=136854
1968
1969         Reviewed by Gyuyoung Kim.
1970
1971         'Escape' key should exit fullscreen first and then should be used to stop page load.
1972
1973         * MiniBrowser/efl/main.c:
1974         (on_key_down):
1975
1976 2014-09-25  Dean Jackson  <dino@apple.com>
1977
1978         Add Said to the contributors list so his name completes in bugzilla.
1979
1980         * Scripts/webkitpy/common/config/contributors.json:
1981
1982 2014-09-25  Alexey Proskuryakov  <ap@apple.com>
1983
1984         EWS only repeats its cycle every two hours
1985         https://bugs.webkit.org/show_bug.cgi?id=137129
1986
1987         Reviewed by Ryosuke Niwa.
1988
1989         * QueueStatusServer/app.yaml: Updated version.
1990
1991         * QueueStatusServer/config/queues.py: Moved timeout from activeworkitems.py to configuration.
1992
1993         * QueueStatusServer/handlers/releaselock.py: Added. Releases the lock without removing
1994         the patch from work items.
1995
1996         * QueueStatusServer/index.yaml: No real change, just let AppEngine have its way with entry order.
1997
1998         * QueueStatusServer/main.py: Added release-lock.
1999
2000         * QueueStatusServer/model/activeworkitems.py:
2001         (ActiveWorkItems.deactivate_expired): Use timeout from configuration.
2002
2003         * QueueStatusServer/model/workitems.py: Added move_to_end. When we unlock a patch,
2004         we don't want it to be immediately picked up again, it's better to give other patches
2005         a chance.
2006
2007         * QueueStatusServer/templates/releaselock.html: Added. Not sure why all commands have
2008         these interactive versions, but OK.
2009
2010         * Scripts/webkitpy/tool/commands/earlywarningsystem.py: (AbstractEarlyWarningSystem.review_patch):
2011         Unlock the patch when a non-final failure occurs (e.g. can't build even without the patch,
2012         or svn is down).
2013
2014         * Scripts/webkitpy/tool/commands/queues.py:
2015         (AbstractReviewQueue.process_work_item): Do not try/catch ScriptError around review_patch.
2016         Style queue never raises these, and EWS already calls _did_fail, before re-throwing,
2017         meaning that these handlers could never do the right thing. We'd either get a duplicate
2018         _did_fail, or try to unlock an already unlocked patch.
2019         (StyleQueue.review_patch): Unlock the patch on transient failure (such as svn failure),
2020         making it eligible for retry immediately.
2021
2022         * Scripts/webkitpy/common/net/statusserver.py:
2023         (StatusServer._post_release_lock):
2024         (StatusServer.release_lock):
2025         Added a call to release-lock.
2026
2027 2014-09-25  Roger Fong  <roger_fong@apple.com>
2028
2029         [Windows] Followup to r173972. Don’t set child process to none before reading from stdout.
2030
2031         * Scripts/webkitpy/common/system/path.py:
2032         (_CygPath.convert):
2033
2034 2014-09-25  Roger Fong  <roger_fong@apple.com>
2035
2036         [Windows] Close stdin to force a flush to stdout if no test path is read during layout tests.
2037
2038         * Scripts/webkitpy/common/system/path.py:
2039         (_CygPath.convert):
2040
2041 2014-09-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2042
2043         [Gtk] build.sh needs a -- before make options when the build command is cmake --build
2044         https://bugs.webkit.org/show_bug.cgi?id=136377
2045
2046         Reviewed by Philippe Normand.
2047
2048         * Scripts/webkitdirs.pm:
2049         (buildCMakeGeneratedProject): Only use the build.sh script if it exists.
2050
2051 2014-09-25  Akos Kiss  <akiss@inf.u-szeged.hu>
2052
2053         [EFL] Split the list of dependencies to make sure that at least the universally available packages get installed
2054         https://bugs.webkit.org/show_bug.cgi?id=137117
2055
2056         Tools/efl/install-dependencies relies on apt-get to install packages.
2057         Unfortunately, if a package does not exist (e.g., for a given
2058         architecture) then apt-get install is not able to ignore the missing
2059         package and install the rest but fails to run entirely (and there
2060         seems to be no intent to change this behaviour).
2061
2062         On ARM64, the luajit package is missing and currently it needs manual
2063         editing of install-dependencies to get the script install as much as it
2064         can.
2065
2066         This patch separates the installation of the universally available
2067         packages from those which might not be available for all architectures.
2068
2069         Reviewed by Gyuyoung Kim.
2070
2071         * efl/install-dependencies:
2072
2073 2014-09-25  Csaba Osztrogonác  <ossy@webkit.org>
2074
2075         Remove WinCE port from trunk
2076         https://bugs.webkit.org/show_bug.cgi?id=136951
2077
2078         Reviewed by Alex Christensen.
2079
2080         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2081         (_should_file_trigger_build):
2082         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
2083         (ShouldBuildTest):
2084         * CMakeLists.txt:
2085         * DumpRenderTree/win/DRTDataObject.cpp:
2086         (DRTDataObject::CopyMedium):
2087         * Scripts/build-webkit:
2088         * Scripts/webkit-build-directory:
2089         * Scripts/webkitdirs.pm:
2090         (argumentsForConfiguration):
2091         (builtDylibPathForName):
2092         (isAppleWinWebKit):
2093         (launcherPath):
2094         (launcherName):
2095         (shouldRemoveCMakeCache):
2096         (cmakeBasedPortArguments):
2097         (cmakeBasedPortName):
2098         (isCMakeBuild):
2099         (isWinCE): Deleted.
2100         (determineIsWinCE): Deleted.
2101         * Scripts/webkitperl/FeatureList.pm:
2102         * Scripts/webkitpy/port/port_testcase.py:
2103         (test_apache_config_file_name_for_platform):
2104         * TestWebKitAPI/config.h:
2105         * WinCELauncher/CMakeLists.txt: Removed.
2106         * WinCELauncher/main.cpp: Removed.
2107         * gtk/manifest.txt:
2108
2109 2014-09-23  David Farler  <dfarler@apple.com>
2110
2111         [iOS] run-webkit-tests should support minor versions under devices and create a testing device under the right runtime
2112         https://bugs.webkit.org/show_bug.cgi?id=136895
2113
2114         Reviewed by David Kilzer.
2115
2116         Create Device, DeviceType, and Runtime data classes.
2117         Create Simulator class represent simctl output.
2118
2119         Wherever possible, use structured data classes anywhere a raw
2120         identifier or UDID string was used for a cleaner implementation
2121         and to encapsulate the inherent fragility of scraping simctl output.
2122
2123         Create a suitably named testing device if one doesn't exist.
2124
2125         Finally, accurately handle having multiple simulator runtimes (SDKs)
2126         installed in the active Xcode.app bundle.
2127
2128         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2129         (_set_up_derived_options):
2130         * Scripts/webkitpy/port/driver.py:
2131         (IOSSimulatorDriver.cmd_line):
2132         Construct DeviceType and Runtime objects from identifiers passed at the
2133         command line, still providing sensible defaults for 32- and 64-bit testing.
2134         * Scripts/webkitpy/port/ios.py:
2135         (IOSSimulatorPort.__init__):
2136         (IOSSimulatorPort.setup_test_run):
2137         (IOSSimulatorPort):
2138         (IOSSimulatorPort.testing_device):
2139         Cache the testing device once it is created or found.
2140         (IOSSimulatorPort.reset_preferences):
2141         Get the device path from the Device object instead of consructing it
2142         in the port class.
2143         (IOSSimulatorPort.simulator_udid): Deleted.
2144         Get the UDID from the testing_device :: Device object itself.
2145         * Scripts/webkitpy/xcode/simulator.py:
2146         Created Device, DeviceType, Runtime, and Simulator classes.
2147         (get_runtimes): Deleted.
2148         (get_devices): Deleted.
2149         (get_device_types): Deleted.
2150         (get_latest_runtime): Deleted.
2151
2152 2014-09-24  Roger Fong  <roger_fong@apple.com>
2153
2154         [Windows] Tentative fix for Windows test bots.
2155
2156         * Scripts/webkitpy/common/system/path.py:
2157         (_CygPath.convert):
2158
2159 2014-09-24  Alexey Proskuryakov  <ap@apple.com>
2160
2161         Change more build.webkit.org links to https
2162         https://bugs.webkit.org/show_bug.cgi?id=137049
2163
2164         Reviewed by Csaba Osztrogonác.
2165
2166         Fix appspot, svn.webkit.org and Trac links.
2167
2168         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2169         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:
2170         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2171         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
2172         (ViewController.prototype._domForBuildName):
2173         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
2174         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2175         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2176         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2177         (.):
2178         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
2179         (EWS):
2180         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
2181         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitTestHistory.js:
2182         (TestHistory):
2183         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2184
2185 2014-09-24  Langó László  <llango.u-szeged@partner.samsung.com>
2186
2187         Update the list of u-szeged contributors.
2188
2189         Rubber-stamped by Csaba Osztrogonác <ossy@webkit.org>.
2190
2191         * Scripts/webkitpy/common/config/contributors.json:
2192
2193 2014-09-23  Roger Fong  <roger_fong@apple.com>
2194
2195         [Windows] More debugging for the Windows bots.
2196
2197         * Scripts/webkitpy/common/system/path.py:
2198         (_CygPath):
2199
2200 2014-09-23  Roger Fong  <roger_fong@apple.com>
2201
2202         Unreviewed. Fix for r173899, those tabs should be spaces.
2203
2204         * Scripts/webkitpy/port/driver.py:
2205         (Driver._command_from_driver_input):
2206         (Driver): Deleted.
2207
2208 2014-09-23  Roger Fong  <roger_fong@apple.com>
2209
2210         [Windows] Add some logging to debug a problem with the Windows bots that causes layout tests to exit early.
2211
2212         * Scripts/webkitpy/port/driver.py:
2213         (Driver):
2214
2215 2014-09-23  Jer Noble  <jer.noble@apple.com>
2216
2217         [Tools] git-commit uses wrong ChangeLog when run from a subdirectory
2218         https://bugs.webkit.org/show_bug.cgi?id=137031
2219
2220         Reviewed by Joseph Pecoraro.
2221
2222         commit-log-editor is run from the top of the Git checkout, even when git-commit is invoked
2223         from a subdirectory, making the parsed locations of ChangeLog files incorrect. Git provides
2224         a mapping prefix in the GIT_PREFIX environment variable, so apply this prefix to the parsed
2225         ChangeLog locations before passing them to createCommitMessage().
2226
2227         * Scripts/commit-log-editor:
2228
2229 2014-09-23  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2230
2231         W3C test importer should detect manual and reference tests according their filenames
2232         https://bugs.webkit.org/show_bug.cgi?id=133852
2233
2234         Reviewed by Bem Jones-Bey.
2235
2236         * Scripts/webkitpy/w3c/test_parser.py:
2237         (TestParser.analyze_test): Adding checks based on WPT filename rules.
2238         (TestParser.is_wpt_manualtest): Detecting whether the test is a manual test based on its filename.
2239         (TestParser):
2240         (TestParser.potential_ref_filename): Getting the potential reference filename of a test from its filename.
2241         (TestParser.is_wpt_reftest): Detecting whether the test is a ref test based on its filename.
2242         * Scripts/webkitpy/w3c/test_parser_unittest.py:
2243         (test_analyze_manual_wpt_test): Adding a test for a "-manual.html" file with testharness.js link in it. 
2244
2245 2014-09-23  Bem Jones-Bey  <bjonesbe@adobe.com>
2246
2247         Unreviewed, add Rebecca Hauck as a contributor.
2248
2249         * Scripts/webkitpy/common/config/contributors.json:
2250
2251 2014-09-23  David Kilzer  <ddkilzer@apple.com>
2252
2253         Switch build.webkit.org URLs to https
2254
2255         Reviewed by Lucas Forschler and Alexey Proskuryakov.
2256
2257         * TestResultServer/app.yaml: Update version to this commit
2258         revision.
2259
2260         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2261         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
2262         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2263         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBuildbot.js:
2264         (WebKitBuildbot):
2265         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
2266         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2267         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
2268         (.):
2269         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2270         (WebKitBuildbot):
2271         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2272         * Scripts/webkitpy/common/config/urls.py:
2273         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2274         (test_builder_with_name):
2275         * Scripts/webkitpy/tool/commands/queries.py:
2276         (TreeStatus):
2277         * TestResultServer/generate_builders_json.py:
2278         (main):
2279         * TestResultServer/generate_builders_json_unittest.py:
2280         (GenerateBuildersJsonTest.test_generate_json_data.dummy_fetch_json):
2281         (GenerateBuildersJsonTest):
2282         (GenerateBuildersJsonTest.test_generate_json_data):
2283         * TestResultServer/static-dashboards/builders.jsonp:
2284         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2285         (loadExpectationsLayoutTests):
2286         * TestResultServer/static-dashboards/timeline_explorer.js:
2287
2288 2014-09-23  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2289
2290         W3C test importer should copy .htaccess files
2291         https://bugs.webkit.org/show_bug.cgi?id=136850
2292
2293         Reviewed by Bem Jones-Bey.
2294
2295         * Scripts/webkitpy/w3c/test_importer.py:
2296         (TestImporter.should_skip_file): Helper function to check whether to skip file or not. Added ".htaccess" file specific check.
2297         (TestImporter):
2298         (TestImporter.find_importable_tests): Making use of new helper function.
2299
2300 2014-09-23  Alexey Proskuryakov  <ap@apple.com>
2301
2302         Trying to revive bot watcher's dashboard after HSTS.
2303
2304         Unreviewed.
2305
2306         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2307         (WebKitBuildbot): It looks like XMLHttpRequest may not like HSTS redirects, let's try to avoid these.
2308
2309 2014-09-23  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2310
2311         Make Tools/BuildSlaveSupport/wait-for-SVN-server.py handle server donwtime
2312         https://bugs.webkit.org/show_bug.cgi?id=137026
2313
2314         Reviewed by Csaba Osztrogonác.
2315
2316         * BuildSlaveSupport/wait-for-SVN-server.py:
2317         (getLatestSVNRevision):
2318         (waitForSVNRevision):
2319
2320 2014-09-23  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2321
2322         Remove unlinkZeroFiles from build-webkit
2323         https://bugs.webkit.org/show_bug.cgi?id=137018
2324
2325         Reviewed by Csaba Osztrogonác.
2326
2327         * Scripts/build-webkit:
2328         (unlinkZeroFiles): Deleted.
2329
2330 2014-09-23  Rohit Kumar  <kumar.rohit@samsung.com>
2331
2332         [GTK] Minibrowser : Add keyboard support for stop page load
2333         https://bugs.webkit.org/show_bug.cgi?id=136857
2334
2335         Reviewed by Philippe Normand.
2336
2337         Keyboard support to stop page load in GTK Minibrowser using F6 and Escape keys.
2338
2339         * MiniBrowser/gtk/BrowserWindow.c:
2340         (stopPageLoad): Callback to stop page load.
2341         (browser_window_init):
2342
2343 2014-09-22  Rohit Kumar  <kumar.rohit@samsung.com>
2344
2345         [EFL][WK2] Minibrowser : Add keyboard support for page reload while ignoring cache
2346         https://bugs.webkit.org/show_bug.cgi?id=136813
2347
2348         Reviewed by Gyuyoung Kim.
2349
2350         Ctrl+r is used for page reload along with F5. Ctrl+Shift+r and Ctrl+F5 is used for page reload while ignoring cache.
2351
2352         * MiniBrowser/efl/main.c:
2353         (on_key_down):
2354
2355 2014-09-22  Daniel Bates  <dabates@apple.com>
2356
2357         [Cocoa] Add UI delegate callback when window.close() is called
2358         https://bugs.webkit.org/show_bug.cgi?id=137008
2359         <rdar://problem/17801001>
2360
2361         Reviewed by Anders Carlsson.
2362
2363         Add a test to ensure that -[WKUIDelegatePrivate _webViewClose:] is called on window.close()
2364         for window opened via JavaScript (i.e. window.open()).
2365
2366         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2367         * TestWebKitAPI/Tests/WebKit2/open-and-close-window.html: Added.
2368         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm: Added.
2369
2370 2014-09-22  Youenn Fablet  <youennf@gmail.com>
2371
2372         W3C importer should import html files within resources folders
2373         https://bugs.webkit.org/show_bug.cgi?id=127548
2374
2375         Reviewed by Ryosuke Niwa.
2376         
2377         Import HTML files in any folder named "resources" even if file is not detected as a HTML test file 
2378
2379         * Scripts/webkitpy/w3c/test_importer.py:
2380         (TestImporter.find_importable_tests):
2381
2382 2014-09-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2383
2384         [GTK] Test /webkit2/WebKitWebView/can-show-mime-type fails if evince browser plugin is installed
2385         https://bugs.webkit.org/show_bug.cgi?id=136998
2386
2387         Reviewed by Philippe Normand.
2388
2389         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2390         (testWebViewCanShowMIMEType): Remove the check of PDF as
2391         unsupported MIME type.
2392
2393 2014-09-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2394
2395         Unreviewed. Fix WebKitGTKTranslations rule in watchlist.
2396
2397         In r145081 GTK+ translations were moved from Source/WebKit/gtk/po/
2398         to Source/WebCore/platform/gtk/po/ but the rule was not updated.
2399
2400         * Scripts/webkitpy/common/config/watchlist: Use
2401         Source/WebCore/platform/gtk/po/ as directory to watch for
2402         WebKitGTKTranslations rule and add berto and myself to the list of
2403         watchers.
2404
2405 2014-09-22  Ryuan Choi  <ryuan.choi@gmail.com>
2406
2407         Fix syntaxError in watchlist since r173594
2408         https://bugs.webkit.org/show_bug.cgi?id=136996
2409
2410         Reviewed by Philippe Normand.
2411
2412         * Scripts/webkitpy/common/config/watchlist: Removed unnecessary comma.
2413
2414 2014-09-20  Sam Weinig  <sam@webkit.org>
2415
2416         Make possible HashSet<std::unique_ptr<>>
2417         https://bugs.webkit.org/show_bug.cgi?id=136166
2418
2419         Reviewed by Darin Adler.
2420
2421         * TestWebKitAPI/Tests/WTF/CopyMoveCounter.h: Removed.
2422         * TestWebKitAPI/Counters.cpp: Added.
2423         * TestWebKitAPI/Counters.h: Copied from Tools/TestWebKitAPI/Tests/WTF/CopyMoveCounter.h.
2424         Move the CopyMoveCounter helper from CopyMoveCounter.h to Counters.h, and add a ConstructorDestructorCounter
2425         helper to the mix as well. Add Counters.cpp to allow for the global variables to be used in more than one
2426         translation unit.
2427     
2428         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2429         Add new files.
2430
2431         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2432         Add tests for using std::unique_ptr and OwnPtr as the key's of a HashMap.
2433
2434         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2435         Add tests for using std::unique_ptr and OwnPtr as the values of a HashSet.
2436
2437 2014-09-21  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2438
2439         run-webkit-tests should count tests submitted as absolute paths once
2440         https://bugs.webkit.org/show_bug.cgi?id=136848
2441
2442         Reviewed by Darin Adler.
2443
2444         * Scripts/webkitpy/port/base.py:
2445         (Port._expanded_paths): In case of absolute path, do not search for platform specific tests.
2446
2447 2014-09-19  Joseph Pecoraro  <pecoraro@apple.com>
2448
2449         JSStringRef leak on the leaks bot allocation under selectTextWithCriteriaCallback
2450         https://bugs.webkit.org/show_bug.cgi?id=136974
2451
2452         Reviewed by Chris Fleizach.
2453
2454         * DumpRenderTree/AccessibilityUIElement.cpp:
2455         (selectTextWithCriteriaCallback):
2456         Be sure to release the string if it was allocated.
2457
2458 2014-09-19  Alexey Proskuryakov  <ap@apple.com>
2459
2460         build.webkit.org/dashboard: Pending builds don't show up when there is a commit with no comments
2461         https://bugs.webkit.org/show_bug.cgi?id=136966
2462
2463         Reviewed by Daniel Bates.
2464
2465         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
2466         (Trac.prototype._convertCommitInfoElementToObject): Tolerate these horrible commits.
2467
2468 2014-09-19  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2469
2470         [CoordinatedGraphics][EFL] window.scrollTo(x, y) doesn't work when fixed layout is enabled
2471         https://bugs.webkit.org/show_bug.cgi?id=136917
2472
2473         Reviewed by Darin Adler.
2474
2475         Added WKViewScrollTo.cpp and scrollTo.html to test this issue.
2476
2477         * TestWebKitAPI/PlatformEfl.cmake:
2478         * TestWebKitAPI/Tests/WebKit2/efl/WKViewScrollTo.cpp: Added.
2479         (TestWebKitAPI::didFinishLoadForFrame):
2480         (TestWebKitAPI::TEST):
2481         * TestWebKitAPI/Tests/WebKit2/efl/scrollTo.html: Added.
2482
2483 2014-09-19  Daniel Bates  <dabates@apple.com>
2484
2485         Always assume internal SDK when building configuration Production
2486         https://bugs.webkit.org/show_bug.cgi?id=136925
2487         <rdar://problem/18362399>
2488
2489         Reviewed by Dan Bernstein.
2490
2491         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2492         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2493         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2494         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2495
2496 2014-09-19  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2497
2498         WTR and DRT didReceiveAuthenticationChallengeInFrame should print messages consistently
2499         https://bugs.webkit.org/show_bug.cgi?id=136847
2500
2501         Added protection space host and port logging to WTR didReceiveAuthenticationChallengeInFrame.
2502
2503         Reviewed by Alexey Proskuryakov.
2504
2505         * WebKitTestRunner/TestController.cpp:
2506         (WTR::TestController::didReceiveAuthenticationChallengeInFrame):
2507
2508 2014-09-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2509
2510         [GTK] Missing inspector files in the tarball
2511         https://bugs.webkit.org/show_bug.cgi?id=136952
2512
2513         Reviewed by Gustavo Noronha Silva.
2514
2515         * gtk/manifest.txt: Add
2516         Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
2517         to the tarball.
2518
2519 2014-09-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2520
2521         Webkitgtk 2.5.3: tarball contains APPLE LICENSE file - stating not distributable
2522         https://bugs.webkit.org/show_bug.cgi?id=136632
2523
2524         Reviewed by Gustavo Noronha Silva.
2525
2526         * gtk/generate-inspector-gresource-manifest.py: Use an alias for
2527         the gtk icons.
2528         * gtk/manifest.txt: Only include the free icons in the tarball.
2529
2530 2014-09-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2531
2532         [GTK] generate-inspector-gresource-manifest.py should receive the list of files from the makefile
2533         https://bugs.webkit.org/show_bug.cgi?id=136943
2534
2535         Reviewed by Philippe Normand.
2536
2537         Update the script to receive the list of files from the command
2538         line instead of scanning the given directories.
2539
2540         * gtk/generate-inspector-gresource-manifest.py:
2541         (get_filenames): Convert filenames to use relative paths.
2542         (find_all_files_in_directory): Deleted.
2543         (find_all_files_in_directory.select_file): Deleted.
2544
2545 2014-09-18  Tanay C  <tanay.c@samsung.com>
2546
2547         [EFL][WK2] Minibrowser : Support Zoom on Control key + scroll
2548         https://bugs.webkit.org/show_bug.cgi?id=136739
2549
2550         Reviewed by Gyuyoung Kim.
2551
2552         * MiniBrowser/efl/main.c: Add support for zoom on control key + mouse scroll
2553         (on_mouse_wheel): Modified.
2554
2555 2014-09-18  Carlos Garcia Campos  <cgarcia@igalia.com>
2556
2557         [GTK] Dot not allow to create delete-on-destroy GMainLoopSources
2558         https://bugs.webkit.org/show_bug.cgi?id=136923
2559
2560         Reviewed by Gustavo Noronha Silva.
2561
2562         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp:
2563         (TestWebKitAPI::TEST): Use the new API that doesn't allow to use
2564         the source.
2565
2566 2014-09-18  Csaba Osztrogonác  <ossy@webkit.org>
2567
2568         Fix countFailures of RunLLINTCLoopTests and Run32bitJSCTests (II)
2569         https://bugs.webkit.org/show_bug.cgi?id=136856
2570
2571         Reviewed by Darin Adler.
2572
2573         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2574         (RunLLINTCLoopTests.countFailures):
2575         (Run32bitJSCTests.countFailures):
2576         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2577         (RunLLINTCLoopTestsTest.test_failures):
2578         (RunLLINTCLoopTestsTest.test_failure):
2579         (RunLLINTCLoopTestsTest.test_no_failure):
2580         (Run32bitJSCTestsTest.test_failures):
2581         (Run32bitJSCTestsTest.test_failure):
2582         (Run32bitJSCTestsTest.test_no_failure):
2583
2584 2014-09-18  Zan Dobersek  <zdobersek@igalia.com>
2585
2586         GMainLoopSource is exposed to race conditions
2587         https://bugs.webkit.org/show_bug.cgi?id=135800
2588
2589         Reviewed by Carlos Garcia Campos.
2590
2591         Add unit tests for GMainLoopSource.
2592
2593         The tests check correct behavior of GMainLoopSource in various conditions --
2594         from the most simple rescheduling to rescheduling during dispatch, cancelling
2595         or destroying the GMainLoopSource during dispatch, proper destroy callback
2596         dispatching etc.
2597
2598         Scheduling both void (one-time) and bool (repeatable) callbacks is tested.
2599         State of the GMainLoopSource object (either ready, sheduled or active) is
2600         thoroughly tested throughout the lifetime of that object.
2601
2602         Still missing are tests for socket callbacks, which are a bit trickier because
2603         they rely on a GSocket object. The delete-on-destroy GMainLoopSource objects
2604         are also not tested thoroughly, simply because it is at the moment impossible
2605         to test that the objects are actually destroyed when the corresponding source
2606         is finally deleted.
2607
2608         * TestWebKitAPI/PlatformGTK.cmake:
2609         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp: Added.
2610         (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest):
2611         (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest):
2612         (TestWebKitAPI::GMainLoopSourceTest::runLoop):
2613         (TestWebKitAPI::GMainLoopSourceTest::delayedFinish):
2614         (TestWebKitAPI::GMainLoopSourceTest::finish):
2615         (TestWebKitAPI::GMainLoopSourceTest::source):
2616         (TestWebKitAPI::TEST):
2617
2618 2014-09-17  Ryuan Choi  <ryuan.choi@gmail.com>
2619
2620         Unreviewed, Update my email in contributors.json
2621
2622         * Scripts/webkitpy/common/config/contributors.json:
2623
2624 2014-09-17  Daniel Bates  <dabates@apple.com>
2625
2626         Unreviewed, rolling out r173695.
2627
2628         Broke building third-party Legacy WebKit apps; will
2629         investigate offline
2630
2631         Reverted changeset:
2632
2633         "[iOS] Make WebCore build with public iOS SDK"
2634         https://bugs.webkit.org/show_bug.cgi?id=136487
2635         http://trac.webkit.org/changeset/173695
2636
2637 2014-09-17  Daniel Bates  <dabates@apple.com>
2638
2639         [iOS] Make WebCore build with public iOS SDK
2640         https://bugs.webkit.org/show_bug.cgi?id=136487
2641
2642         Reviewed by David Kilzer.
2643
2644         Substitute <WebCore/MachVMSPI.h> for <mach/mach_vm.h>.
2645
2646         * DumpRenderTree/mac/CheckedMalloc.cpp:
2647
2648 2014-09-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2649
2650         [GTK] WebKitWebView::load-failed-with-tls-errors should receive the failing URI instead of a host
2651         https://bugs.webkit.org/show_bug.cgi?id=136889
2652
2653         Reviewed by Gustavo Noronha Silva.
2654
2655         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
2656         (testLoadFailedWithTLSErrors): Check that LoadFailedWithTLSErrors
2657         event was added to the events vector.
2658         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
2659         (loadFailedCallback): Do not assume the web view URI is the
2660         failing URI when the load fails before the committed state.
2661         (loadFailedWithTLSErrorsCallback): Handle the case of load failure
2662         because of TLS errors can call LoadTrackingTest::loadFailedWithTLSErrors.
2663         (LoadTrackingTest::LoadTrackingTest): Connect to WebKitWebView::load-failed-with-tls-errors.
2664         (LoadTrackingTest::loadFailedWithTLSErrors): Add
2665         LoadFailedWithTLSErrors event to the events vector.
2666         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
2667
2668 2014-09-17  Renato Nagy  <rnagy@inf.u-szeged.hu>
2669
2670         [EFL][GTK] Remove WebKit1 related codes
2671         https://bugs.webkit.org/show_bug.cgi?id=136853
2672
2673         Reviewed by Csaba Osztrogonác.
2674
2675         Gtk and EFL WebKit1 ports no longer exist. Webkit1 related codes were deleted
2676         from scripts.
2677
2678         * BuildSlaveSupport/build.webkit.org-config/config.json:
2679         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2680         (Compile32bitJSC):
2681         (BuildAndTestWebKit2Factory):
2682         (CompileWebKit1Only): Deleted.
2683         (CompileWebKit2Only): Deleted.
2684         (BuildAndTestWebKit1OnlyFactory): Deleted.
2685         (BuildAndTestWebKit2OnlyFactory): Deleted.
2686         * Scripts/build-webkit:
2687         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl:
2688         * Scripts/webkitpy/common/config/ports.py:
2689         (GtkWK2Port.build_webkit_command):
2690         (EflWK2Port.build_webkit_command):
2691         * Scripts/webkitpy/common/config/ports_unittest.py:
2692         (DeprecatedPortTest.test_gtk_wk2_port):
2693         * Scripts/webkitpy/port/efl.py:
2694         (EflPort.build_webkit_command):
2695         * Scripts/webkitpy/port/gtk.py:
2696         (GtkPort._built_libraries_path):
2697         (GtkPort._search_paths):
2698         (GtkPort.test_expectations_file_position):
2699         (GtkPort.build_webkit_command):
2700         (GtkPort.run_webkit_tests_command):
2701         (GtkPort.warn_if_bug_missing_in_test_expectations): Deleted.
2702
2703 2014-09-16  Daniel Bates  <dabates@apple.com>
2704
2705         [iOS] Add iOS SDK name and version suffix to WebKitSystemInterface debug/release product name
2706         https://bugs.webkit.org/show_bug.cgi?id=136862
2707
2708         Reviewed by David Kilzer.
2709
2710         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2711         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2712         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Remove hardcoded iOS 8.0
2713         IPHONEOS_DEPLOYMENT_TARGET to ensure we link against the latest version of WebKitSystemInterface.
2714
2715 2014-09-12  Ryosuke Niwa  <rniwa@webkit.org>
2716
2717         Mac queue slaves should reboot every so often
2718         https://bugs.webkit.org/show_bug.cgi?id=136791
2719
2720         Reviewed by Alexey Proskuryakov.
2721
2722         Reboot Mac queue slaves every night between 1 A.M. and 6 A.M.
2723
2724         * EWSTools/start-queue-mac.sh:
2725
2726 2014-09-16  Csaba Osztrogonác  <ossy@webkit.org>
2727
2728         Unreviewed gardening, skip one more tests on Windows.
2729
2730         * Scripts/run-javascriptcore-tests:
2731
2732 2014-09-16  Csaba Osztrogonác  <ossy@webkit.org>
2733
2734         JSC test gardening
2735         https://bugs.webkit.org/show_bug.cgi?id=136823
2736
2737         Reviewed by Geoffrey Garen.
2738
2739         * Scripts/run-javascriptcore-tests: Skip tests on only the affected platforms.
2740
2741 2014-09-16  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2742
2743         Remove shouldAbortEarly cruft from master.cfg
2744         https://bugs.webkit.org/show_bug.cgi?id=136779
2745
2746         Reviewed by Csaba Osztrogonác.
2747
2748         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2749         (ConfigureBuild.start):
2750         (RunWebKitTests.start):
2751         (RunWebKit2Tests.start): Deleted.
2752
2753 2014-09-15  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2754
2755         Remove ORWT related crufts from webkitdirs.pm
2756         https://bugs.webkit.org/show_bug.cgi?id=136821
2757
2758         Reviewed by Alexey Proskuryakov.
2759
2760         * Scripts/webkitdirs.pm:
2761         (isPerianInstalled): Deleted.
2762         (determineIPhoneSimulatorVersion): Deleted.
2763         (iPhoneSimulatorVersion): Deleted.
2764         (isSnowLeopard): Deleted.
2765         (isLion): Deleted.
2766         (quitIOSSimulator): Deleted.
2767
2768 2014-09-15  Roger Fong  <roger_fong@apple.com>
2769
2770         Unreviewed. Skip yet another ecma/Date test that fails only on Windows.
2771         https://bugs.webkit.org/show_bug.cgi?id=25160
2772
2773         * Scripts/run-javascriptcore-tests:
2774
2775 2014-09-15  Lucas Forschler  <lforschler@apple.com>
2776
2777         Add another Apple build slave to the Mountain Lion Debug WK1 queue
2778         
2779         Rubber stamped by Matt Hanson.
2780         
2781         * BuildSlaveSupport/build.webkit.org-config/config.json:
2782
2783 2014-09-15  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
2784
2785         [EFL] Ecore and Eina are initialized twice in TestWebKitAPI
2786         https://bugs.webkit.org/show_bug.cgi?id=136822
2787
2788         Reviewed by Gyuyoung Kim.
2789
2790         In TestWebKitAPI/efl/main.cpp, ecore and eina modules are unnecessarily
2791         initialized as we already does it in PlatformWebView::PlatformWebView
2792         calling ewk_init(). The reason for that was to ensure testing for example,
2793         WTF where creating the view is not mandatory.
2794
2795         Call ewk_init() and ewk_shutdown() in TestWebKitAPI/efl/main.cpp
2796         in order to properly initalize and release EWebKit.
2797
2798         * TestWebKitAPI/PlatformEfl.cmake:
2799         * TestWebKitAPI/efl/PlatformWebView.cpp:
2800         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2801         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
2802         * TestWebKitAPI/efl/main.cpp:
2803         (main):
2804
2805 2014-09-15  peavo@outlook.com  <peavo@outlook.com>
2806
2807         [WinCairo] Make it easier to enable/disable GStreamer.
2808         https://bugs.webkit.org/show_bug.cgi?id=135766
2809
2810         Reviewed by Brent Fulgham.
2811
2812         Make it possible to enable/disable GStreamer by editing the new user macro ENABLE_GSTREAMER_WINCAIRO.
2813
2814         * WinLauncher/WinMain.cpp: Compile fix when GStreamer is enabled.
2815
2816 2014-09-12  Brian J. Burg  <burg@cs.washington.edu>
2817
2818         Web Inspector: remind about rebaselining generator test results
2819         https://bugs.webkit.org/show_bug.cgi?id=136759
2820
2821         Reviewed by Joseph Pecoraro.
2822
2823         For now, we can implement this as a watchlist message. Add watchlist
2824         groups and messages for the inspector and web replay generators.
2825
2826         * Scripts/webkitpy/common/config/watchlist:
2827
2828 2014-09-12  Alexey Proskuryakov  <ap@apple.com>
2829
2830         build.webkit.org/dashboard: Overlapping text when status is long
2831         https://bugs.webkit.org/show_bug.cgi?id=136794
2832
2833         Reviewed by Timothy Hatcher.
2834
2835         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
2836         (.status-line): Replaces height with min-height.
2837
2838 2014-09-12  Timothy Hatcher  <timothy@apple.com>
2839
2840         Make Brian Burg a WebKit reviewer.
2841
2842         * Scripts/webkitpy/common/config/contributors.json: Move Brian Burg's entry.
2843
2844 2014-09-12  Alexey Proskuryakov  <ap@apple.com>
2845
2846         Multiple EWS or commit bots can pick up processing of the same patch
2847         https://bugs.webkit.org/show_bug.cgi?id=136793
2848
2849         Reviewed by Ryosuke Niwa.
2850
2851         Change timeout from one hour to two hours. This will let bots finish, and in the
2852         unlikely event of a bot being frozen, will only delay patch processing restart by
2853         one hour.
2854
2855         * QueueStatusServer/app.yaml:
2856         * QueueStatusServer/model/activeworkitems.py: (ActiveWorkItems.deactivate_expired):
2857
2858 2014-09-11  Andy Estes  <aestes@apple.com>
2859
2860         [WebKit2] WKImageCreateCGImage crashes when passed a null WKImage
2861         https://bugs.webkit.org/show_bug.cgi?id=136768
2862
2863         Reviewed by Tim Horton.
2864
2865         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2866         * TestWebKitAPI/Tests/WebKit2/WKImageCreateCGImageCrash.cpp: Added.
2867         (TestWebKitAPI::TEST):
2868
2869 2014-09-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2870
2871         REGRESSION(r173423): CertificateInfo is never sent to the UI process when using shared secondary process model
2872         https://bugs.webkit.org/show_bug.cgi?id=136669
2873
2874         Reviewed by Antti Koivisto.
2875
2876         * Scripts/run-gtk-tests:
2877         (TestRunner): Unskip SSL test.
2878
2879 2014-09-12  Eric Carlson  <eric.carlson@apple.com>
2880
2881         Strip extraneous AVFoundation and CoreMedia logging
2882         https://bugs.webkit.org/show_bug.cgi?id=136747
2883
2884         Reviewed by Jer Noble.
2885
2886         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2887         (SingleTestRunner._run_compare_test): Allow the port to specify patterns to strip from stderr.
2888
2889         * Scripts/webkitpy/port/base.py:
2890         (Port.stderr_patterns_to_strip): Base class, empty list
2891
2892         * Scripts/webkitpy/port/driver.py:
2893         (DriverOutput.strip_stderror_patterns): Strip the specified patterns from stderr.
2894
2895         * Scripts/webkitpy/port/ios.py:
2896         (IOSSimulatorPort.stderr_patterns_to_strip): iOS patterns - there are none.
2897
2898         * Scripts/webkitpy/port/mac.py:
2899         (MacPort.stderr_patterns_to_strip): CoreMedia and AVFoundation logging we can ignore.
2900
2901
2902 2014-09-11  Michael Saboff  <msaboff@apple.com>
2903
2904         lldb_webkit.py:btjs doesn't work with release builds
2905         https://bugs.webkit.org/show_bug.cgi?id=136760
2906
2907         Reviewed by Jer Noble.
2908
2909         If we can't get a result calling JSC::ExecState::describeFrame(), try calling the
2910         mangled name _ZN3JSC9ExecState13describeFrameEv.  Also cleaned up the handling if
2911         we can't get a valid result from trying either call.  In that case, we fallback to
2912         just showing the PC.  Also added check for both entry points.  If neither is found,
2913         we issue a warning and output the stack trace without JavaScript annotations.
2914
2915         * lldb/lldb_webkit.py:
2916         (btjs):
2917
2918 2014-09-11  Rebecca Hauck  <rhauck@adobe.com>
2919
2920         webkitpy test failures from import-w3c-tests
2921         https://bugs.webkit.org/show_bug.cgi?id=136752
2922
2923         Reviewed by Bem Jones-Bey.
2924
2925         This patch fixes a bug in import-w3c-tests where we were appending
2926         the wrong set of files to the copy_list. This also updates the tests
2927         to clear the failures introduced in the patch for bug 135929.
2928
2929         * Scripts/webkitpy/w3c/test_converter_unittest.py:
2930         (W3CTestConverterTest.test_read_prefixed_property_list):
2931         * Scripts/webkitpy/w3c/test_parser.py:
2932         (TestParser.analyze_test):
2933         (TestParser.support_files):
2934         * Scripts/webkitpy/w3c/test_parser_unittest.py:
2935
2936 2014-09-10  Brent Fulgham  <bfulgham@apple.com>
2937
2938         Blink merge: Speculative fix for windows run-webkit-tests hangs
2939         https://bugs.webkit.org/show_bug.cgi?id=136727
2940
2941         Reviewed by Csaba Osztrogonác.
2942
2943         Merged from Blink (patch by Dirk Pranke):
2944         <https://chromium.googlesource.com/chromium/blink/+/0cdd98d44a20c3951562ccf8b08b1fefba8dac67%5E%21/#F0>
2945
2946         * Scripts/webkitpy/common/system/executive.py:
2947         (Executive.kill_process):
2948
2949 2014-09-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2950
2951         Added myself as a committer.
2952
2953         Unreviewed.
2954
2955         * Scripts/webkitpy/common/config/contributors.json:
2956
2957 2014-09-11  László Langó  <llango.u-szeged@partner.samsung.com>
2958
2959         [JavaScriptCore] Fix FTL on platform EFL.
2960         https://bugs.webkit.org/show_bug.cgi?id=133571
2961
2962         Reviewed by Filip Pizlo.
2963
2964         * efl/install-dependencies: Revert r169181.
2965         * efl/jhbuild.modules: Clone and build a custom branch.
2966         This branch contains some fix for FTL of platform EFL.
2967         The branch is a fork of llvm r206311.
2968
2969 2014-09-10  Tanay C  <tanay.c@samsung.com>
2970
2971         [EFL][WK2] Minibrowser : Shift+Scroll navigate to back or forward url's
2972         https://bugs.webkit.org/show_bug.cgi?id=136698
2973
2974         Reviewed by Gyuyoung Kim.
2975
2976         * MiniBrowser/efl/main.c: Add functionality to support shift + mouse scroll navigation
2977         (on_mouse_wheel): Added.
2978         (window_free):
2979         (window_create):
2980
2981 2014-09-10  Rohit Kumar  <kumar.rohit@samsung.com>
2982
2983         [EFL][WK2] Minibrowser : Add tooltip for toolbar buttons in Minibrowser
2984         https://bugs.webkit.org/show_bug.cgi?id=136284
2985
2986         Reviewed by Gyuyoung Kim.
2987
2988         * MiniBrowser/efl/main.c:
2989         (window_create):
2990
2991 2014-09-10  Rebecca Hauck  <rhauck@adobe.com>
2992
2993         import-w3c-tests doesn't handle relative paths to support files in ref files correctly
2994         https://bugs.webkit.org/show_bug.cgi?id=135929
2995
2996         Reviewed by Bem Jones-Bey.
2997
2998         The recent refactor of the W3C test repo falsified a bunch of assmumptions that
2999         were made when this script was originally written with respect to relative paths
3000         in ref files. This patch updates import-w3c-tests to update paths in ref files if
3001         they move relative to the test file.
3002
3003
3004         * Scripts/webkitpy/w3c/test_converter.py:
3005         (convert_for_webkit):
3006         (_W3CTestConverter.__init__):
3007         (_W3CTestConverter.convert_reference_relpaths):
3008         (_W3CTestConverter.convert_style_data):
3009         (_W3CTestConverter.convert_attributes_if_needed):
3010         * Scripts/webkitpy/w3c/test_importer.py:
3011         (TestImporter.find_importable_tests):
3012         (TestImporter.import_tests):
3013         * Scripts/webkitpy/w3c/test_parser.py:
3014         (TestParser.load_file):
3015         (TestParser.analyze_test):
3016         (TestParser.support_files):
3017
3018 2014-09-10  Michael Catanzaro  <mcatanzaro@igalia.com>
3019
3020         [GTK] allow overwriting destination of download
3021         https://bugs.webkit.org/show_bug.cgi?id=136372
3022
3023         Reviewed by Carlos Garcia Campos.
3024
3025         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
3026         (downloadLocalFileSuccessfully): Split from testDownloadLocalFile
3027         (testDownloadLocalFile): Split off downloadLocalFileSuccessfully
3028         (createFileAtDestination): Added
3029         (testDownloadOverwriteDestinationAllowed): Added
3030         (testDownloadOverwriteDestinationDisallowed): Added
3031         (testDownloadLocalFileError): Use new DownloadErrorTest::ExpectedError
3032         (testDownloadRemoteFileError): Use new DownloadErrorTest::ExpectedError
3033         (beforeAll): New tests
3034
3035 2014-08-05  David Farler  <dfarler@apple.com>
3036
3037         iOS Simulator: run-webkit-tests chokes on unterminated UTF-8 when writing a test result
3038         https://bugs.webkit.org/show_bug.cgi?id=135551
3039
3040         Reviewed by Daniel Bates.
3041
3042         Prevent printing invalid Unicode strings going to stderr.
3043         Also, make filesystem.py more tolerant about receiving
3044         Unicode (encoded as UTF-8) when writing to files, in the
3045         rare case that an NSError description will make it to
3046         stderr, such as -[LTRelayController createUniqueApp].
3047
3048         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3049         (-[LTRelayController launchSimulator]): Removed.
3050         (-[LTRelayController createUniqueApp]):
3051         Don't explicitly try to uninstall the app. It is automatically handled
3052         when installing an app with the same bundle identifier.
3053         (-[LTRelayController start]):
3054         (-[LTRelayController bootDevice]): Removed.
3055         The device already boots as a part of starting the simulator. Attempting
3056         to boot a second time may cause spurious stderr output.
3057         * Scripts/webkitpy/port/driver.py:
3058         (IOSSimulatorDriver._setup_environ_for_driver):
3059         Explicitly set DEVELOPER_DIR once so xcode-select isn't called.
3060         Open the iOS Simulator once instead of the LayoutTestRelay trying
3061         to do it.
3062         * Scripts/webkitpy/port/ios.py:
3063         (IOSSimulatorPort._get_crash_log):
3064         Make sure stderr is at least an empty string.
3065         (IOSSimulatorPort):
3066         (IOSSimulatorPort.developer_dir):
3067         New property for setting up DEVELOPER_DIR in the driver environment.
3068
3069 2014-09-09  Dan Bernstein  <mitz@apple.com>
3070
3071         Clean up the MiniBrowser Xcode project
3072         https://bugs.webkit.org/show_bug.cgi?id=136684
3073
3074         Reviewed by Tim Horton.
3075
3076         * MiniBrowser/Configurations/Base.xcconfig: Enabled warnings recommended by Xcode 6.
3077         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Removed explicit linking against
3078         WebKit2.framework. Upgraded project file version.
3079
3080 2014-09-09  Daniel Bates  <dbates@webkit.org>
3081
3082         svn-{apply, unapply} fails to apply/unapply SVN 1.7 patch that adds new file with property change
3083         https://bugs.webkit.org/show_bug.cgi?id=136379
3084
3085         Reviewed by David Kilzer.
3086
3087         Fixes an issue where svn-{apply, unapply} fail to apply or unapply, respectively,
3088         a patch generated using Subversion 1.7.4 (r1295709) that both adds a new file F
3089         and sets a property on F (say, the executable bit).
3090
3091         * Scripts/svn-apply:
3092         (patch): Only add file if the diff has text chunks.
3093         * Scripts/svn-unapply:
3094         (patch): Only delete added file if the diff has text chunks.
3095
3096 2014-09-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3097
3098         [GTK] Unreviewed GTK gardening.
3099
3100         * Scripts/run-gtk-tests:
3101         (TestRunner): Skip TestSSL:webkit2/WebKitWebView/ssl (fails since r173423).
3102
3103 2014-09-09  Christophe Dumez  <cdumez@apple.com>
3104
3105         Update my email in contributors.json
3106         https://bugs.webkit.org/show_bug.cgi?id=136671
3107
3108         Reviewed by Andreas Kling.
3109
3110         * Scripts/webkitpy/common/config/contributors.json:
3111
3112 2014-09-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3113
3114         [EFL] Enable fixed layout by default
3115         https://bugs.webkit.org/show_bug.cgi?id=136607
3116
3117         Reviewed by Csaba Osztrogonác.
3118
3119         Fixed layout is being used by Tizen platform by default. However, the feature
3120         has still many defects now. So, we need to enable it by default, then should fix
3121         those bugs. 
3122
3123         * MiniBrowser/efl/main.c:
3124
3125 2014-09-08  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3126
3127         Remove FILTERS flag
3128         https://bugs.webkit.org/show_bug.cgi?id=136571
3129
3130         Reviewed by Darin Adler.
3131
3132         * Scripts/webkitperl/FeatureList.pm:
3133
3134 2014-09-08  Alexey Proskuryakov  <ap@apple.com>
3135
3136         Dashboard metrics should ignore commits that didn't trigger builds
3137         https://bugs.webkit.org/show_bug.cgi?id=136618
3138
3139         Reviewed by Darin Adler.
3140
3141         Commits that didn't trigger builds are ones like ChangeLog updates, patches for
3142         other platforms etc. It does not make sense to count wait time for these, as it
3143         can be arbitrarily long.
3144
3145         The new algorithm is much slower asymptotically, but it's OK, computers are fast.
3146
3147         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3148         (BuildbotIteration.prototype._parseData): Record changes that triggered the iteration.
3149
3150         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
3151         We used to walk the timeline to see which revisions are fully tested, but that's not
3152         correct. A revision that's only tested by a subset of queues finishes independently
3153         of another that's tested by another subset. Now, we just search for the answer for
3154         each revision individually.
3155
3156         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsView.js:
3157         (MetricsView.prototype._update.appendQueueResults): Added worst revision number, which
3158         the analyzer now reports. Removed best time, which is more confusing than meaningful.
3159
3160 2014-09-08  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
3161
3162         Remove EWebLauncher from webkitdirs.pm
3163         https://bugs.webkit.org/show_bug.cgi?id=136622
3164
3165         Reviewed by Gyuyoung Kim.
3166
3167         * Scripts/webkitdirs.pm:
3168         (launcherName):
3169
3170 2014-09-06  Sam Weinig  <sam@webkit.org>
3171
3172         XPCPtr should be converted into an all purpose smart pointer for os_objects
3173         https://bugs.webkit.org/show_bug.cgi?id=136602
3174
3175         Reviewed by Darin Adler.
3176
3177         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3178         * TestWebKitAPI/Tests/WTF/darwin: Added.
3179         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp: Added.
3180         Add basic unit tests for OSObjectPtr.
3181
3182 2014-09-06  Saam Barati  <saambarati1@gmail.com>
3183
3184         Unreviewed. Add myself as a committer.
3185
3186         * Scripts/webkitpy/common/config/contributors.json:
3187
3188 2014-09-06  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3189
3190         Unreviewed, EFL build fix when SHARED_CORE is on.
3191
3192         * TestWebKitAPI/PlatformEfl.cmake:
3193
3194 2014-09-05  Lucas Forschler  <lforschler@apple.com>
3195
3196         <https://webkit.org/b/136586> Add bots to Apple build/test queues
3197         
3198         Reviewed by Daniel Bates.
3199
3200         * BuildSlaveSupport/build.webkit.org-config/config.json:
3201
3202 2014-09-05  Alexey Proskuryakov  <ap@apple.com>
3203
3204         Buildbot metrics page gives wrong results after a new bot gets added
3205         https://bugs.webkit.org/show_bug.cgi?id=136516
3206
3207         Reviewed by Tim Horton.
3208
3209         Part 2: Fix elapsed times.
3210
3211         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
3212         (Analyzer.prototype._countTimes): Made lastTestedRevisionByQueue contain undefined values
3213         until the first build in a queue. This happens to work as needed with _fullyTestedRevisionNumber().
3214
3215 2014-09-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3216
3217         [SOUP] Implement ResourceResponse::platformSuggestedFilename() when USE(SOUP) is enabled.
3218         https://bugs.webkit.org/show_bug.cgi?id=136562
3219
3220         Reviewed by Martin Robinson.
3221
3222         * Scripts/run-gtk-tests:
3223         (TestRunner): Remove failure expectations for tests that now pass.
3224
3225 2014-09-04  Alexey Proskuryakov  <ap@apple.com>
3226
3227         Dashboard metrics page wastes a lot of time sorting iterations
3228         https://bugs.webkit.org/show_bug.cgi?id=136559
3229
3230         Reviewed by Tim Horton.
3231
3232         Also fixes comments here and there, and adds a missing "var".
3233
3234         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3235         (BuildbotIteration.prototype._parseData):
3236         (BuildbotIteration.prototype._updateWithData):
3237         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3238         (BuildbotQueue.prototype.loadAll):
3239         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
3240         (Analyzer.prototype._countTimes):
3241
3242 2014-09-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3243
3244         [GTK] Unreviewed GTK gardening.
3245
3246         * Scripts/run-gtk-tests:
3247         (TestRunner): Skip tests failing since r173272.
3248
3249 2014-09-04  Simon Fraser  <simon.fraser@apple.com>
3250
3251         Add some logging to help diagnose assertions in dumpWebViewAsPixelsAndCompareWithExpected() on bots
3252         https://bugs.webkit.org/show_bug.cgi?id=136561
3253
3254         Reviewed by Tim Horton.
3255         
3256         Log for calloc() and CGBitmapContextCreate() failures.
3257
3258         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3259         (createBitmapContext):
3260         (createBitmapContextFromWebView):
3261
3262 2014-09-04  Andy Estes  <aestes@apple.com>
3263
3264         Fix the Mac Production build after r173283.
3265
3266         * WebKitTestRunner/config.h: Reverted to defining WEBCORE_EXPORT for now.
3267
3268 2014-09-04  Brent Fulgham  <bfulgham@apple.com>
3269
3270         [Win] webkitpy test suite frequently fails to complete
3271         https://bugs.webkit.org/show_bug.cgi?id=136546
3272
3273         Reviewed by Daniel Bates.
3274
3275         Properly convert the ASCII crash log produced by ntsd into
3276         a unicode string as early as possible so that we handle it
3277         properly when generating our logs and other test support output.
3278
3279         We were mixing ASCII/unicode strings under Windows, which was
3280         causing test system failures when we processed some crash logs.
3281
3282         Also do a better job of handling garbage pid entries in the
3283         Cygwin lock files.
3284
3285         * Scripts/webkitpy/common/system/crashlogs.py:
3286         (CrashLogs._find_newest_log_win): The ntsd '.logopen' command
3287         creates an ASCII file. Decode it as ASCII, not 'utf-8', and
3288         handle the strings as unicode from that point on.
3289         * Scripts/webkitpy/port/http_lock.py:
3290         (HttpLock._current_lock_pid): Add logging and handle case of
3291         the current_pid failing to cleanly convert to 'int'.
3292         * Scripts/webkitpy/port/win.py:
3293         (WinPort): Add 64-bit architecture as a known target for the
3294         Windows build.
3295
3296 2014-09-04  Andy Estes  <aestes@apple.com>
3297
3298         Address additional review feedback after landing r173283.
3299
3300         Reviewed by Daniel Bates.
3301
3302         * DumpRenderTree/config.h: Removed redundant includes.
3303         * TestWebKitAPI/config.h: Ditto.
3304         * WebKitTestRunner/config.h: Ditto.
3305
3306 2014-09-03  Andy Estes  <aestes@apple.com>
3307
3308         [Cocoa] Some WebKitLegacy headers migrated from WebCore incorrectly contain WEBCORE_EXPORT
3309         https://bugs.webkit.org/show_bug.cgi?id=136521
3310
3311         Reviewed by Anders Carlsson.
3312
3313         * DumpRenderTree/config.h: Included <WebCore/PlatformExportMacros.h> instead of defining WEBCORE_EXPORT.
3314         * TestWebKitAPI/config.h: Ditto.
3315         * WebKitTestRunner/config.h: Ditto.
3316
3317 2014-09-04  Alexey Proskuryakov  <ap@apple.com>
3318
3319         REGRESSION: Dashboard metrics page aggregation counts performance bots
3320         https://bugs.webkit.org/show_bug.cgi?id=136539
3321
3322         Reviewed by Tim Horton.
3323
3324         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
3325
3326 2014-09-04  Brent Fulgham  <bfulgham@apple.com>
3327
3328         [Win] Perl test fix.
3329
3330         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl: Correct test to check for
3331         VersionStamp.exe tool, not just the driver script.
3332
3333 2014-09-04  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3334
3335         Remove CSS_FILTERS flag
3336         https://bugs.webkit.org/show_bug.cgi?id=136529
3337
3338         Reviewed by Dirk Schulze.
3339
3340         * Scripts/webkitperl/FeatureList.pm:
3341
3342 2014-09-04  Commit Queue  <commit-queue@webkit.org>
3343
3344         Unreviewed, rolling out r173201.
3345         https://bugs.webkit.org/show_bug.cgi?id=136538
3346
3347         Improves the situation but also introduces additional crashes.
3348         (Requested by zdobersek on #webkit).
3349
3350         Reverted changeset:
3351
3352         "GMainLoopSource is exposed to race conditions"
3353         https://bugs.webkit.org/show_bug.cgi?id=135800
3354         http://trac.webkit.org/changeset/173201
3355
3356 2014-09-03  Alexey Proskuryakov  <ap@apple.com>
3357
3358         Buildbot metrics page gives wrong results after a new bot gets added
3359         https://bugs.webkit.org/show_bug.cgi?id=136516
3360
3361         Part 1: Fix red/green counters. Dashboard is considered green at a given time
3362         if all the bots that ever had results before this time are green.
3363
3364         This doesn't (and cannot) address situations where the bot gets removed and then
3365         re-added. It also gives wrong results after a bot gets removed, because it doesn't
3366         know that it was ever displayed on the dashboard.
3367
3368         Reviewed by Darin Adler.
3369
3370         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
3371         (Analyzer.prototype._dashboardIsAllGreen):
3372         (Analyzer.prototype._updateStretchOfRedCounters):
3373         (Analyzer.prototype._countPercentageOfGreen):
3374         (Analyzer.prototype._allQueuesAreSuccessful): Deleted.
3375
3376 2014-09-03  Brent Fulgham  <bfulgham@apple.com>
3377
3378         [Win] Unreviewed test fix.
3379
3380         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl: Don't fail
3381         test if user doesn't have the VersionStamp.exe program.
3382
3383 2014-09-03  Dana Burkart  <dburkart@apple.com>
3384
3385         Unreviewed. Add myself as a committer.
3386
3387         * Scripts/webkitpy/common/config/contributors.json:
3388
3389 2014-09-03  Alexey Proskuryakov  <ap@apple.com>
3390
3391         build.webkit.org/dashboard performance popover is unstyled
3392         https://bugs.webkit.org/show_bug.cgi?id=136499
3393
3394         Reviewed by Tim Horton.
3395
3396         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
3397         (.performance-popover):
3398         (.performance-popover .dashboard-link):
3399
3400 2014-09-03  Saam Barati  <saambarati1@gmail.com>
3401
3402         Create tests for type profiling
3403         https://bugs.webkit.org/show_bug.cgi?id=136161
3404
3405         Reviewed by Geoffrey Garen.
3406
3407         Have run-javascriptcore-tests run the newly created
3408         tests for the type profiler.
3409
3410         * Scripts/run-javascriptcore-tests:
3411         * Scripts/run-jsc-stress-tests:
3412
3413 2014-09-03  Brent Fulgham  <bfulgham@apple.com>
3414
3415         [Win] Revise test environment for Windows build.
3416         https://bugs.webkit.org/show_bug.cgi?id=136486
3417
3418         Reviewed by David Kilzer.
3419
3420         The various calls to get the Safari path really only have
3421         meaning on the Mac. Other ports get access to the build
3422         and test environment separately, so remove the various
3423         checks in the Safari-specific code to simplify things.
3424
3425         Remove some 64-bit hacks used on Windows now that the
3426         various tools know how to find the 64-bit runtime environment.
3427
3428         * Scripts/run-javascriptcore-tests: 
3429         * Scripts/webkitdirs.pm:
3430         (safariPathFromSafariBundle): Revise to expect Mac.
3431         (installedSafariPath): Ditto.
3432         (safariPath): Ditto.
3433         (appleApplicationSupportPath): Get rid of 64-bit Windows hack.
3434         (setPathForRunningWebKitApp): Get rid of unused SafariPath
3435         argument for Windows runs.
3436
3437 2014-09-03  Dana Burkart  <dburkart@apple.com>
3438
3439         Dashboard should show performance bots.
3440         https://bugs.webkit.org/show_bug.cgi?id=136386
3441
3442         Reviewed by Alexey Proskuryakov.
3443
3444         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3445         (BuildbotIteration.prototype._parseData.collectPerfTestResults):
3446         (BuildbotIteration.prototype._parseData):
3447         Support possible performance failures.
3448
3449         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js:
3450         New QueueView to manage the way we present performance data.
3451
3452         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3453         (BuildbotQueue):
3454         Support new 'performance' and 'performanceTestName' keys.
3455
3456
3457         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3458         Add performance column to the main page.
3459
3460         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3461         (WebKitBuildbot):
3462         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3463         (body):
3464         Make sure everything fits on 13 inch screens.
3465
3466         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
3467
3468 2014-09-03  Zan Dobersek  <zdobersek@igalia.com>
3469
3470         GMainLoopSource is exposed to race conditions
3471         https://bugs.webkit.org/show_bug.cgi?id=135800
3472
3473         Reviewed by Carlos Garcia Campos.
3474
3475         Add a unit test for GMainLoopSource that tests different
3476         types of rescheduling tasks on already-active sources.
3477
3478         * TestWebKitAPI/PlatformGTK.cmake:
3479         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp: Added.
3480         (GMainLoopSourceTest::GMainLoopSourceTest):
3481         (GMainLoopSourceTest::~GMainLoopSourceTest):
3482         (GMainLoopSourceTest::runLoop):
3483         (GMainLoopSourceTest::finish):
3484         (GMainLoopSourceTest::source):
3485         (testGMainLoopSourceBasicRescheduling):
3486         (testGMainLoopSourceReentrantRescheduling):
3487         (testGMainLoopSourceDifferentThreadRescheduling):
3488         (beforeAll):
3489         (afterAll):
3490         (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest):
3491         (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest):
3492         (TestWebKitAPI::GMainLoopSourceTest::runLoop):
3493         (TestWebKitAPI::GMainLoopSourceTest::finish):
3494         (TestWebKitAPI::GMainLoopSourceTest::source):
3495         (TestWebKitAPI::TEST):
3496
3497 2014-09-02  Simon Fraser  <simon.fraser@apple.com>
3498
3499         Make sure WK1 prefs are initialized in MiniBrowser
3500         https://bugs.webkit.org/show_bug.cgi?id=136465
3501
3502         Reviewed by Tim Horton.
3503         
3504         Call -didChangeSettings from -awakeFromNib for WK1 windows just as we do
3505         for WK2 windows, to make sure that WebPreferences are updated (to get
3506         layer borders to work consistently).
3507
3508         * MiniBrowser/mac/WK1BrowserWindowController.m:
3509         (-[WK1BrowserWindowController awakeFromNib]):
3510
3511 2014-09-02  Renato Nagy  <rnagy@inf.u-szeged.hu>
3512
3513         check-webkit-style should complain about C++ comments in Platform.h
3514         https://bugs.webkit.org/show_bug.cgi?id=133802
3515
3516         Reviewed by Csaba Osztrogonác.
3517
3518         * Scripts/webkitpy/style/checkers/cpp.py:
3519         (check_platformh_comments):
3520         (_process_lines):
3521         (CppChecker):
3522         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3523         (CppStyleTest.test_platformh_comment):
3524
3525 2014-09-02  Brendan Long  <self@brendanlong.com>
3526
3527         [Gtk] Make install-dependencies work on Arch Linux
3528         https://bugs.webkit.org/show_bug.cgi?id=136374
3529
3530         Reviewed by Philippe Normand.
3531
3532         * gtk/install-dependencies: Add dependencies for pacman (Arch Linux).
3533
3534 2014-09-01  Brian J. Burg  <burg@cs.washington.edu>
3535
3536         Provide column numbers to DTrace willExecute/didExecute probes
3537         https://bugs.webkit.org/show_bug.cgi?id=136434
3538
3539         Reviewed by Antti Koivisto.
3540
3541         Create a directory for DTrace scripts. Add an example script that
3542         shows how to use static probes provided by JavaScriptCore's profiler.
3543
3544         * Scripts/dtrace/jsc-trace-profiler-events.d: Added.
3545
3546 2014-09-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3547
3548         [GTK] [JHBuild] Cyclic dependency between cairo and librsvg.
3549         https://bugs.webkit.org/show_bug.cgi?id=136431
3550
3551         Reviewed by Martin Robinson.
3552
3553         * gtk/jhbuild.modules: Disable cairo SVG testsuite.
3554         Add missing dependencies for librsvg (glib and cairo).
3555
3556 2014-09-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3557
3558         [GTK] install-dependencies don't installs dbus-launch that is needed for the API tests.
3559         https://bugs.webkit.org/show_bug.cgi?id=136425
3560
3561         Reviewed by Martin Robinson.
3562
3563         * gtk/install-dependencies: Add dbus-x11 to the list of packages needed for running the tests.
3564
3565 2014-09-01  Ryuan Choi  <ryuan.choi@samsung.com>
3566
3567         Update my list of email addresses in contributors.json
3568         https://bugs.webkit.org/show_bug.cgi?id=136424
3569
3570         Reviewed by Gyuyoung Kim.
3571
3572         * Scripts/webkitpy/common/config/contributors.json:
3573
3574 2014-08-30  Filip Pizlo  <fpizlo@apple.com>
3575
3576         [RJST] eager-no-cjit should really mean eager
3577         https://bugs.webkit.org/show_bug.cgi?id=136407
3578
3579         Reviewed by Mark Hahnenberg.
3580         
3581         At some point we made NO_CJIT_OPTIONS force threshold settings to something reasonable
3582         and well-known. But the way we appended options was such that NO_CJIT_OPTIONS came in
3583         after EAGER_OPTIONS. The whole point of "eager" was to use eager tier-up thresholds. This
3584         all meant that NO_CJIT_OPTIONS was overriding the eagerness of EAGER_OPTIONS, for the one
3585         threshold setting that NO_CJIT_OPTIONS was currently setting
3586         (thresholdForJITAfterWarmUp). The solution is to make sure that we always append
3587         NO_CJIT_OPTIONS before we append EAGER_OPTIONS.
3588         
3589         Luckily, no tests regressed during the time that we lost eager-no-cjit coverage.
3590
3591         * Scripts/run-jsc-stress-tests:
3592
3593 2014-08-29  Daniel Bates  <dabates@apple.com>
3594
3595         [iOS] Configure Xcode to build a command line tool for the iOS Simulator
3596         https://bugs.webkit.org/show_bug.cgi?id=136388
3597
3598         Reviewed by David Kilzer.
3599
3600         Add a script, called configure-xcode-for-ios-development, to configure Xcode to
3601         support building a command line tool for the iOS Simulator. You must run this
3602         script as root.
3603
3604         The script uses the xcspec files in the OS X SDK to create xcspec files in the
3605         iOS Simulator SDK with the product- and package- type definitions to build a
3606         command line tool, if applicable.
3607
3608         * Scripts/configure-xcode-for-ios-development: Added.
3609
3610 2014-08-29  Tim Horton  <timothy_horton@apple.com>
3611
3612         Remove Windows WebKit2 code from TestWebKitAPI
3613         https://bugs.webkit.org/show_bug.cgi?id=136385
3614
3615         Reviewed by Alexey Proskuryakov.
3616
3617         * TestWebKitAPI/PlatformUtilities.h:
3618         * TestWebKitAPI/PlatformWebView.h:
3619         (TestWebKitAPI::PlatformWebView::setParentWindowMessageObserver): Deleted.
3620         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
3621         (TestWebKitAPI::TEST): Deleted.
3622         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
3623         (TestWebKitAPI::TEST):
3624         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3625         (TestWebKitAPI::TEST):
3626         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp: Removed.
3627         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp: Removed.
3628         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp: Removed.
3629         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp: Removed.
3630         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp: Removed.
3631         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp: Removed.
3632         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp: Removed.
3633
3634 2014-08-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3635
3636         [JSC] Some JSC tests are dependent on the machine time zone.
3637         https://bugs.webkit.org/show_bug.cgi?id=136363
3638
3639         Reviewed by Filip Pizlo.
3640
3641         * Scripts/run-javascriptcore-tests: Export TZ environment variable to US/Pacific.
3642         Unskip the tests that were skipped on r99580.
3643
3644 2014-08-29  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3645