1 2015-03-20 Brent Fulgham <bfulgham@apple.com>
3 [Win] Temporarily turn of EWS Windows tests while I debug the test failure.
5 * Scripts/webkitpy/common/config/ews.json:
7 2015-03-20 Philippe Normand <pnormand@igalia.com>
9 [GTK][jhbuild] Fix flakey failures due to unstable googlecode repository
10 https://bugs.webkit.org/show_bug.cgi?id=142867
12 Rubber-stamped by Csaba Osztrogon.
14 * gtk/jhbuild.modules: Use Ossy's libusrsctp Github fork. Also use
15 a fixed revision for the openwebrtc-gst-plugins.
17 2015-03-19 Ryosuke Niwa <rniwa@webkit.org>
19 Unreviewed build fix. Don't try to report stats for all benchmarks.
20 Just report the geometric mean of preferred means.
22 * Scripts/run-jsc-benchmarks:
24 2015-03-19 Ryosuke Niwa <rniwa@webkit.org>
26 run-jsc-benchmarks should only report preferred mean
27 https://bugs.webkit.org/show_bug.cgi?id=142874
29 Reviewed by Geoffrey Garen.
31 Just collect statistics for the preferred mean.
33 * Scripts/run-jsc-benchmarks:
35 2015-03-19 Alex Christensen <achristensen@webkit.org>
37 [Content Extensions] Test regular expression parse failures.
38 https://bugs.webkit.org/show_bug.cgi?id=142872
40 Reviewed by Benjamin Poulain.
42 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
43 (TestWebKitAPI::testPatternStatus):
44 (TestWebKitAPI::TEST_F):
45 Added tests for each parsing status.
47 2015-03-19 Alex Christensen <achristensen@webkit.org>
49 Fix API tests after r181754.
51 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
52 (TestWebKitAPI::testRequest):
54 2015-03-19 Brady Eidson <beidson@apple.com>
56 Part of content extensions should apply css selectors
57 https://bugs.webkit.org/show_bug.cgi?id=142604
59 Reviewed by Alex Christensen.
61 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
62 (WebCore::ContentExtensions::operator<<):
64 2015-03-19 Brent Fulgham <bfulgham@apple.com>
66 [Win] Activate tests on EWS
67 https://bugs.webkit.org/show_bug.cgi?id=142850
69 Reviewed by Alexey Proskuryakov.
71 * Scripts/webkitpy/common/config/ews.json: Add me as
72 the EWS bot watcher, and activate tests.
74 2015-03-19 Csaba Osztrogonác <ossy@webkit.org>
76 [GTK] Fix inspector userinterface related incremental build issue
77 https://bugs.webkit.org/show_bug.cgi?id=142849
79 Reviewed by Carlos Garcia Campos.
81 * Scripts/webkitdirs.pm:
82 (shouldRemoveCMakeCache):
84 2015-03-18 Alex Christensen <achristensen@webkit.org>
86 [ContentExtensions] Prepare for compiling stylesheets of selectors to be used on every page.
87 https://bugs.webkit.org/show_bug.cgi?id=142799
89 Reviewed by Brady Eidson.
91 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
92 (TestWebKitAPI::testPattern):
93 (TestWebKitAPI::TEST_F):
94 Start testing regex failures.
96 2015-03-18 Dhi Aurrahman <diorahman@rockybars.com>
98 Fix StringView typos after r181525 and r181558
99 https://bugs.webkit.org/show_bug.cgi?id=142772
101 Reviewed by Darin Adler.
103 Add some tests in [1] to cover the StringView::startsWith,
104 StringView::startsWithIgnoringASCIICase, StringView::endsWith and
105 StringView::endsWithIgnoringASCIICase implementations.
107 * TestWebKitAPI/Tests/WTF/StringView.cpp:
108 (TestWebKitAPI::TEST):
110 2015-03-18 Dana Burkart <dburkart@apple.com>
112 Remove extraneous import to fix the build.
116 * Scripts/webkitpy/port/driver.py:
118 2015-03-18 Dana Burkart <dburkart@apple.com>
120 ASAN_OPTIONS=allocator_may_return_null=1 needs to be set
121 https://bugs.webkit.org/show_bug.cgi?id=142547
123 Reviewed by Alexey Proskuryakov.
125 * Scripts/webkitpy/port/driver.py:
126 (Driver._setup_environ_for_driver):
128 2015-03-18 Alexey Proskuryakov <ap@apple.com>
130 Tweak how AppleSystemFontOSSubversion default is added
131 https://bugs.webkit.org/show_bug.cgi?id=142835
133 Reviewed by Dan Bernstein.
135 * DumpRenderTree/mac/DumpRenderTree.mm:
136 (setDefaultsToConsistentValuesForTesting):
138 2015-03-18 Dan Bernstein <mitz@apple.com>
140 prepare-ChangeLog doesn't understand C string literals split across multiple lines with \
141 https://bugs.webkit.org/show_bug.cgi?id=142815
143 Reviewed by Darin Adler.
145 * Scripts/prepare-ChangeLog:
146 (get_function_line_ranges_for_cpp): If the line ends with a backslash instead of a matching
147 quotation mark, use new variable $quotation_mark to remember what we are looking for, and
148 keep consuming the quoted text until the matching quotation mark is reached. Emit the
149 warning only if a line ends without a backslash before the matching quotation mark was found.
151 2015-03-18 Joseph Pecoraro <pecoraro@apple.com>
153 Remove unused "preprocessor" parameter to sub-CodeGenerators
154 https://bugs.webkit.org/show_bug.cgi?id=142793
156 Reviewed by Darin Adler.
158 * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
161 2015-03-18 Csaba Osztrogonác <ossy@webkit.org>
163 [EFL] Bump gstreamer version to 1.4.4
164 https://bugs.webkit.org/show_bug.cgi?id=142782
166 Reviewed by Philippe Normand.
168 * efl/jhbuild.modules:
169 * efl/patches/gst-libav.patch:
170 * efl/patches/gst-plugins-bad-remove-gnustep-support.patch: Added.
171 * efl/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
173 2015-03-17 Tim Horton <timothy_horton@apple.com>
177 * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
178 (WTR::InjectedBundle::platformInitialize):
180 2015-03-17 Dean Jackson <dino@apple.com>
182 check-webkit-style should allow "bool a : 1"
183 https://bugs.webkit.org/show_bug.cgi?id=142794
185 Reviewed by Brent Fulgham.
187 We should allow member bitfields of the form:
191 It seems that Visual Studio 8 was the last compiler that
192 wasn't happy about not using unsigned here. We already have
193 about 500 cases (in WebCore) where people were ignoring this rule.
195 * Scripts/webkitpy/style/checkers/cpp.py:
196 (check_language): Allow "bool".
197 * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add tests.
198 (CppStyleTest.test_enum_bitfields):
199 (CppStyleTest.test_plain_integral_bitfields):
201 2015-03-17 Benjamin Poulain <bpoulain@apple.com>
203 Compile character ranges targeting the same state as range check in the bytecode
204 https://bugs.webkit.org/show_bug.cgi?id=142759
206 Reviewed by Alex Christensen.
208 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
209 (TestWebKitAPI::TEST_F):
211 2015-03-17 Youenn Fablet <youenn.fablet@crf.canon.fr>
213 W3C test parser and converter should use test importer host
214 https://bugs.webkit.org/show_bug.cgi?id=142729
216 Reviewed by Bem Jones-Bey.
218 When instantiated by TestImporter, TestParser and TestConverter are now using the same host.
219 This enables adding more TestImporter unit testing.
220 This patch also ensures that the git object instantiated by TestDownloader is using the
221 same Executive and FileSystem object as TestDownloader, again to enable TestImporter/TestDownloader unit testing.
223 * Scripts/webkitpy/common/system/filesystem_mock.py:
224 (MockFileSystem.copytree): Fixes implementation as it creates a runtime error.
225 * Scripts/webkitpy/w3c/test_downloader.py:
226 (TestDownloader.git): Set the executive of the git object to the one of TestDownloader. Refactoring in a new git function for future reuse.
227 (TestDownloader.checkout_test_repository): Making use of the new git function.
228 * Scripts/webkitpy/w3c/test_importer.py:
229 (TestImporter.find_importable_tests): Adding host as parameter to the parser.
230 (TestImporter.import_tests): Adding host as parameter to the converter.
231 * Scripts/webkitpy/w3c/test_importer_unittest.py:
232 (TestImporterTest.create_test_download_importer): Creating a test downloader mock, to be reused by other tests.
234 (TestImporterTest.test_harnesslinks_conversion): Adding test to check that test harness links are converted for CSS tests but not WPT tests.
235 * Scripts/webkitpy/w3c/test_parser.py:
236 (TestParser.__init__): Adding host as parameter constructor.
238 2015-03-17 Carlos Garcia Campos <cgarcia@igalia.com>
240 [GTK] WebKitDOM objects leaking
241 https://bugs.webkit.org/show_bug.cgi?id=118788
243 Reviewed by Darin Adler and Sergio Villar Senin.
245 Update DOMObjectCache unit test to check that DOM objects are also
246 released when new contents are loaded in the web view, and the old
247 document is detached from the frame.
249 * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
250 (testWebKitDOMObjectCache):
251 * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
254 2015-03-17 Youenn Fablet <youenn.fablet@crf.canon.fr>
256 W3C test importer default import folder should be LayoutTests/imported/w3c
257 https://bugs.webkit.org/show_bug.cgi?id=142728
259 Reviewed by Bem Jones-Bey.
261 * Scripts/webkitpy/w3c/test_importer.py:
262 (parse_args): Updating the default destination option value to 'imported/w3c'.
264 2015-03-17 Philippe Normand <pnormand@igalia.com>
266 [GTK] basic OpenWebRTC build support
267 https://bugs.webkit.org/show_bug.cgi?id=142393
269 Reviewed by Carlos Garcia Campos.
271 * gtk/jhbuild.modules: Add OpenWebRTC and its dependencies. This
272 is not the upstream OpenWebRTC repository. This temporary fork
273 contains a few patches needed by WebKit for audio/video rendering.
275 2015-03-17 Gyuyoung Kim <gyuyoung.kim@samsung.com>
277 [CMake][EFL] Build test tools only for developer mode
278 https://bugs.webkit.org/show_bug.cgi?id=142761
280 Reviewed by Csaba Osztrogonác.
282 Do not build EFL MiniBrowser, WebKitTestRunner, and ImageDiff on production mode.
286 2015-03-17 Joseph Pecoraro <pecoraro@apple.com>
288 Remove never used "useLayerOnTop" bindings generator argument
289 https://bugs.webkit.org/show_bug.cgi?id=142773
291 Reviewed by Darin Adler.
293 * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
296 2015-03-16 Ryosuke Niwa <rniwa@webkit.org>
298 Enable ES6 classes by default
299 https://bugs.webkit.org/show_bug.cgi?id=142774
301 Reviewed by Gavin Barraclough.
303 * Scripts/webkitperl/FeatureList.pm:
305 2015-03-16 Alexey Proskuryakov <ap@apple.com>
307 Fix webkitpy tests after r181585.
309 Looks like "me" cannot be anyone's email, it's a special case.
311 * Scripts/webkitpy/common/config/contributors.json:
313 2015-03-16 Alexey Proskuryakov <ap@apple.com>
315 Add tolerance to WebAudio tests
316 https://bugs.webkit.org/show_bug.cgi?id=142676
318 Reviewed by Tim Horton.
320 * Scripts/webkitpy/common/wavediff.py: Added. Based on Jer Noble's work.
322 * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
323 (TestResultWriter.create_audio_diff_and_write_result):
324 * Scripts/webkitpy/layout_tests/models/test_failures.py:
325 (FailureAudio.write_failure):
326 * Scripts/webkitpy/port/base.py:
327 (Port.do_audio_results_differ):
330 * Scripts/webkitpy/port/test.py: Added a test for the tolerance, fixed existing
331 tests to use real parseable WAV data, and got rid of base64, which there didn't
332 seem to have been any reason for.
334 2015-03-16 Alexey Proskuryakov <ap@apple.com>
336 [Mac] fast/forms/text-control-intrinsic-widths.html fails when MS Office is installed
337 https://bugs.webkit.org/show_bug.cgi?id=142720
339 Reviewed by Myles C. Maxfield.
341 Activate system copies of Microsoft fonts for the current process, thus overriding
342 any other ones that could be preferred by the system otherwise.
344 * DumpRenderTree/mac/DumpRenderTree.mm:
345 (activateSystemCoreWebFonts):
347 * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
348 (WTR::activateSystemCoreWebFonts):
349 (WTR::activateFonts):
351 2015-03-16 Xabier Rodriguez Calvar <calvaris@igalia.com>
353 Created Streams API watchlist
354 https://bugs.webkit.org/show_bug.cgi?id=142684
356 Reviewed by Benjamin Poulain.
358 * Scripts/webkitpy/common/config/watchlist: Created StreamsAPI
359 watchlist and added Benjamin, Youenn and me to it.
361 2015-03-15 Benjamin Poulain <benjamin@webkit.org>
363 CSS: fix the case-insensitive matching of the attribute selectors Begin, End and Hyphen
364 https://bugs.webkit.org/show_bug.cgi?id=142715
366 Reviewed by Brent Fulgham.
368 * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
369 (TestWebKitAPI::TEST):
371 2015-03-15 Benjamin Poulain <bpoulain@apple.com>
373 Change the exact attribute matching to be ASCII case-insensitive
374 https://bugs.webkit.org/show_bug.cgi?id=142609
376 Reviewed by Darin Adler.
378 * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
379 * TestWebKitAPI/Tests/WTF/StringView.cpp:
381 2015-03-13 Youenn Fablet <youenn.fablet@crf.canon.fr>
383 WebKit test infrastructure should automate the process of cloning W3C test suite and importing tests from it
384 https://bugs.webkit.org/show_bug.cgi?id=134764
386 Reviewed by Ryosuke Niwa.
388 TestDownloader is introduced to download W3C tests from the official
389 W3C tests repositories (https://github.com/w3c/web-platform-tests.git
390 and https://github.com/w3c/csswg-test.git).
391 TestDownloader clones the repositories and checkouts revisions of the tests
392 defined in LayoutTests/imported/w3c/resources/TestRepositories.
394 Similarly to https://codereview.chromium.org/148173016,
395 TestDownloader copies part of the files based on the rules
396 defined in LayoutTests/imported/w3c/resources/ImportExpectations.
398 TestDownloader is used by TestImporter when no source directory is provided.
400 * Scripts/webkitpy/w3c/test_downloader.py: Added.
402 (TestDownloader.default_options):
403 (TestDownloader.load_test_repositories):
404 (TestDownloader.__init__):
405 (TestDownloader.checkout_test_repository):
406 (TestDownloader._init_paths_from_expectations):
407 (TestDownloader._add_test_suite_paths):
408 (TestDownloader._empty_directory):
409 (TestDownloader.copy_tests):
410 (TestDownloader.download_tests):
411 * Scripts/webkitpy/w3c/test_importer.py:
414 (TestImporter.__init__):
415 (TestImporter.do_import):
416 (TestImporter.test_downloader):
417 (TestImporter.find_importable_tests.should_keep_subdir):
418 (TestImporter.should_convert_test_harness_links):
419 (TestImporter.import_tests):
420 (TestImporter.write_import_log):
422 2015-03-12 Alexey Proskuryakov <ap@apple.com>
424 [Mavericks] Test snapshots are 1600x1200 on Retina devices
425 https://bugs.webkit.org/show_bug.cgi?id=142630
427 Reviewed by Tim Horton.
429 * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::windowSnapshotImage):
430 Removed an ifdef that disabled the fix on Mavericks.
432 2015-03-12 Csaba Osztrogonác <ossy@webkit.org>
434 Remove isWK2 cruft from webkitdirs.pm after r170426
435 https://bugs.webkit.org/show_bug.cgi?id=142618
437 Reviewed by Daniel Bates.
439 * Scripts/webkitdirs.pm:
442 2015-03-12 Alexey Proskuryakov <ap@apple.com>
444 testRunner.setAlwaysAcceptCookies does not work with NetworkProcess
445 https://bugs.webkit.org/show_bug.cgi?id=138687
447 Reviewed by Carlos Garcia Campos.
449 Always change cookie policy from UI process, as changing it from WebProcess doesn't
450 affect other processes.
452 The implementation is imperfect, because the change happens asynchronously, but I
453 don't expect it to be a problem in practice.
455 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
456 (WTR::InjectedBundle::beginTesting):
457 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
458 (WTR::TestRunner::setAlwaysAcceptCookies):
459 * WebKitTestRunner/TestInvocation.cpp:
460 (WTR::TestInvocation::invoke):
461 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
463 2015-03-12 Csaba Osztrogonác <ossy@webkit.org>
465 [EFL] Enable building EFL 1.13 with NEON support
466 https://bugs.webkit.org/show_bug.cgi?id=142619
468 Reviewed by Gyuyoung Kim.
470 * efl/jhbuild.modules:
472 2015-03-11 Alex Christensen <achristensen@webkit.org>
474 [Content Extensions] Add resource type and load type triggers.
475 https://bugs.webkit.org/show_bug.cgi?id=142422
477 Reviewed by Benjamin Poulain.
479 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
480 (TestWebKitAPI::testRequest):
481 (TestWebKitAPI::mainDocumentRequest):
482 (TestWebKitAPI::TEST_F):
483 (TestWebKitAPI::testURL): Deleted.
485 2015-03-10 Sam Weinig <sam@webkit.org>
487 Allow adding a button in input elements for auto fill related functionality
488 <rdar://problem/19782066>
489 https://bugs.webkit.org/show_bug.cgi?id=142564
491 Reviewed by Anders Carlsson.
493 * WebKitTestRunner/TestController.cpp:
494 (WTR::TestController::createOtherPage):
495 (WTR::TestController::createWebViewWithOptions):
496 Update for new callback.
498 2015-03-11 Benjamin Poulain <bpoulain@apple.com>
500 Add basic support for BOL and EOL assertions to the URL Filter parser
501 https://bugs.webkit.org/show_bug.cgi?id=142568
503 Reviewed by Alex Christensen.
505 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
506 (TestWebKitAPI::TEST_F):
508 2015-03-11 Carlos Garcia Campos <cgarcia@igalia.com>
510 [GTK] Add support for handling TLS errors to MiniBrowser
511 https://bugs.webkit.org/show_bug.cgi?id=142576
513 Reviewed by Sergio Villar Senin.
515 It's useful for testing TLS errors handling itself, but also to
516 allow ignoring TLS errors when testing.
518 * MiniBrowser/gtk/BrowserWindow.c:
519 (webViewLoadFailedWithTLSerrors):
520 (browserWindowConstructed):
522 2015-03-11 Myles C. Maxfield <mmaxfield@apple.com>
524 Use out-of-band messaging for RenderBox::firstLineBaseline() and RenderBox::inlineBlockBaseline()
525 https://bugs.webkit.org/show_bug.cgi?id=142569
527 Reviewed by David Hyatt.
529 Test Optional::valueOrCompute().
531 * TestWebKitAPI/Tests/WTF/Optional.cpp:
532 (TestWebKitAPI::TEST):
534 2015-03-11 Carlos Garcia Campos <cgarcia@igalia.com>
536 [GTK] Add an option to enable MiniBrowser for non developer builds and always install it
537 https://bugs.webkit.org/show_bug.cgi?id=126688
539 Reviewed by Gustavo Noronha Silva.
541 * CMakeLists.txt: Build testing tools only for developer builds,
542 but MiniBrowser when ENABLE_MINIBROWSER option is ON.
543 * MiniBrowser/gtk/CMakeLists.txt: Only add
544 -DWEBKIT_INJECTED_BUNDLE_PATH to the build for developer builds,
545 and add a rule to install the MiniBrowser.
546 * MiniBrowser/gtk/main.c:
547 (main): Only set WEBKIT_INJECTED_BUNDLE_PATH env var for developer
550 2015-03-11 Brent Fulgham <bfulgham@apple.com>
552 Add some DateMath tests to TestWebKitAPI
553 https://bugs.webkit.org/show_bug.cgi?id=142565
555 Reviewed by Alexey Proskuryakov.
557 * TestWebKitAPI/CMakeLists.txt: Add new DateMath.cpp file.
558 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Ditto.
559 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Ditto.
560 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto."
561 * TestWebKitAPI/Tests/WTF/DateMath.cpp: Added.
563 2015-03-10 Brent Fulgham <bfulgham@apple.com>
565 Regression(r181257): WTF_WorkQueue.Simple is flaky
566 https://bugs.webkit.org/show_bug.cgi?id=142560
568 Unreviewed attempt to improve test stability.
570 * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Check the reference count for
571 the WorkQueue a little later to redue flakiness.
573 2015-03-10 Myles C. Maxfield <mmaxfield@apple.com>
575 Migrate from SystemUIFontSelect to AppleSystemFontOSSubversion
576 https://bugs.webkit.org/show_bug.cgi?id=142555
578 Reviewed by Simon Fraser.
580 * DumpRenderTree/mac/DumpRenderTree.mm:
581 (setDefaultsToConsistentValuesForTesting):
582 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
583 (WTR::InjectedBundle::platformInitialize):
585 2015-03-10 Alex Christensen <achristensen@webkit.org>
587 Use unsigned for HashSet size.
588 https://bugs.webkit.org/show_bug.cgi?id=142518
590 Reviewed by Benjamin Poulain.
592 * TestWebKitAPI/Tests/WTF/HashMap.cpp:
593 (TestWebKitAPI::TEST):
594 * TestWebKitAPI/Tests/WTF/HashSet.cpp:
595 (TestWebKitAPI::testInitialCapacity):
596 * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
597 (TestWebKitAPI::TEST):
599 2015-03-10 Daniel Bates <dabates@apple.com>
601 [iOS] Add WebKitSystemInterface for iOS 8.2
602 https://bugs.webkit.org/show_bug.cgi?id=142505
604 Rubber-stamped by Anders Carlsson.
606 Make copy-webkitlibraries-to-product-directory install libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a.
607 I inadvertently forgot to add libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a to script
608 copy-webkitlibraries-to-product-directory in r181286.
610 * Scripts/copy-webkitlibraries-to-product-directory:
612 2015-03-10 Benjamin Poulain <bpoulain@apple.com>
614 Extend URL filter's Term definition to support groups/subpatterns
615 https://bugs.webkit.org/show_bug.cgi?id=142519
617 Reviewed by Alex Christensen.
619 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
620 (TestWebKitAPI::testURL):
622 2015-03-06 Jer Noble <jer.noble@apple.com>
624 Add an option to run-webkit-tests to override the LayoutTests/ directory
625 https://bugs.webkit.org/show_bug.cgi?id=142418
627 Reviewed by David Kilzer.
629 Add an arugment to run-webkit-tests which, when set, overrides the port's default LayoutTests
630 directory. The base port will parse the options during initialization and store the override
631 location if present. layout_tests_dir() will return this overridden location if set.
633 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
635 * Scripts/webkitpy/port/base.py:
637 (Port.layout_tests_dir):
639 2015-03-09 Martin Robinson <mrobinson@igalia.com>
641 [CMake] Enable WorkQueue tests for CMake ports
642 https://bugs.webkit.org/show_bug.cgi?id=142473
644 Reviewed by Darin Adler.
646 * TestWebKitAPI/CMakeLists.txt: Add the WorkQueue tests source file to
647 the list of source files.
648 * Tools/TestWebKitAPI/PlatformEfl.cmake: Add the DispatchQueueEfl directory
649 to the list of include directories for EFL.
651 2015-03-09 David Kilzer <ddkilzer@apple.com>
653 Attempt to fix timeouts on iOS Simulator layout tests
655 * Scripts/webkitpy/port/ios.py:
656 (IOSSimulatorPort.setup_test_run): Most layout test runs on iOS
657 Simulator end after the first 50 tests time out. Some analysis
658 this past weekend shows that the 'Booted' status in the output
659 of `xcrun simctl list` is not sufficient (and watching the test
660 run shows that SpringBoard hasn't fully started to the point
661 where it's displaying icons on the home screen). The workaround
662 until we have a better fix is to add an arbitrary timeout to let
663 SpringBoard finish launching. In practice, 15 seconds is
664 probably enough, but 30 seconds should nearly always work.
666 2015-03-09 Per Arne Vollan <peavo@outlook.com>
668 Unreviewed. Add myself as a committer.
670 * Scripts/webkitpy/common/config/contributors.json:
672 2015-03-09 David Kilzer <ddkilzer@apple.com>
674 Attempt to fix WTF_WorkQueue.TwoQueues timeout test failure
676 * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
677 (TestWebKitAPI::TEST): Change delay from 50ns to 50ms, and add
678 an expectation that will fail if we hit the race condition.
679 This test is inherently racy and will deadlock if the first job
680 for queue2 takes the mutex lock before the second job for
683 2015-03-08 Brent Fulgham <bfulgham@apple.com>
685 [Win] WTF::WorkQueue does not balance ref/deref properly
686 https://bugs.webkit.org/show_bug.cgi?id=142471
688 Reviewed by Antti Koivisto.
690 * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
691 (TestWebKitAPI::TEST): Check that the refcount is correct.
693 2015-03-08 Gyuyoung Kim <gyuyoung.kim@samsung.com>
695 Do not show passing test result on output of EFL layout test
696 https://bugs.webkit.org/show_bug.cgi?id=142380
698 Reviewed by Darin Adler.
700 To show passing tests has caused inconvenience when we detect problem tests
701 in output of layout test. So this patch applies '--debug-rwt-logging' except for EFL port
702 in order not to show passing tests in the output of EFL layout test.
704 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
705 (RunWebKitTests.start):
707 2015-03-08 Brent Fulgham <bfulgham@apple.com>
709 Unreviewed build fix.
711 * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
712 (TestWebKitAPI::TEST): Remove two unused variables.
714 2015-03-08 Brent Fulgham <bfulgham@apple.com>
716 Add some WorkQueue tests to TestWebKitAPI
717 https://bugs.webkit.org/show_bug.cgi?id=142447
719 Reviewed by Sam Weinig.
721 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
722 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
723 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
724 * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Added.
725 (TestWebKitAPI::simpleTest):
726 (TestWebKitAPI::longTest):
727 (TestWebKitAPI::thirdTest):
728 (TestWebKitAPI::finishedTests):
729 (TestWebKitAPI::TEST):
730 (TestWebKitAPI::longTest2):
732 2015-03-08 Carlos Garcia Campos <cgarcia@igalia.com>
734 Remove willDestroyFrame in WKBundlePageLoaderClient
735 https://bugs.webkit.org/show_bug.cgi?id=142389
737 Reviewed by Anders Carlsson.
739 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
740 (WTR::InjectedBundlePage::InjectedBundlePage):
742 2015-03-07 Brent Fulgham <bfulgham@apple.com>
744 [Win] Increase TestWebKitAPI Test Coverage[Win] Increase TestWebKitAPI Test Coverage
745 https://bugs.webkit.org/show_bug.cgi?id=142433
747 Reviewed by Darin Adler.
749 Include more TestWebKitAPI tests when building for Windows. Also
750 fix a build error in MetaAllocator.cpp caused by one of the
751 Microsoft headers #defining 'small'.
753 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
754 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
755 * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
757 2015-03-06 Sam Weinig <sam@webkit.org>
759 [Content Extensions] Move compiling of content extensions to the UIProcess
760 https://bugs.webkit.org/show_bug.cgi?id=142402
762 Reviewed by Benjamin Poulain.
764 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
765 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: Copied from Tools/TestWebKitAPI/Tests/WebCore/ContentFilter.cpp.
766 (TestWebKitAPI::InMemoryCompiledContentExtension::create):
767 (TestWebKitAPI::InMemoryCompiledContentExtension::~InMemoryCompiledContentExtension):
768 (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
769 (TestWebKitAPI::TEST_F):
770 * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Removed.
771 Update test for new name (ContentFilter -> ContentExtensions) and API (CompiledContentExtension
774 2015-03-06 Brent Fulgham <bfulgham@apple.com>
776 [Win] Correct Windows build.
778 Rubberstamped by Michael Saboff
780 * win/AssembleBuildLogs/AssembleLogs.cmd: Correct cut/paste error
783 2015-03-06 Carlos Garcia Campos <cgarcia@igalia.com>
785 [GTK] Test /webkit2/WebKitWebView/sync-request-on-max-conns might fail after finished
786 https://bugs.webkit.org/show_bug.cgi?id=142385
788 Reviewed by Sergio Villar Senin.
790 Use stack allocated GMainLoopSources to make sure they are
791 cancelled automatically if the test finishes before they have
794 * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
795 (testWebViewSyncRequestOnMaxConns):
797 2015-03-06 Csaba Osztrogonác <ossy@webkit.org>
799 Remove Mountain Lion libraries since ML isn't supported
800 https://bugs.webkit.org/show_bug.cgi?id=142332
802 Reviewed by Darin Adler.
804 * Scripts/copy-webkitlibraries-to-product-directory:
806 2015-03-06 Carlos Alberto Lopez Perez <clopez@igalia.com> and Youenn Fablet <youenn.fablet@crf.canon.fr>
808 Layout tests imported/w3c/web-platform-tests certificates should not be tracked on WebKit VCS
809 https://bugs.webkit.org/show_bug.cgi?id=142083
811 Reviewed by Simon Fraser.
813 Modifying on the fly wpt config.json to set the directory where to generate/read certificates as a subfolder of the layout test results folder.
815 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
816 (WebPlatformTestServer._copy_webkit_test_files):
818 2015-03-06 Csaba Osztrogonác <ossy@webkit.org>
820 setup-git-clone fails due to the failure to download python-irclib-0.4.8
821 https://bugs.webkit.org/show_bug.cgi?id=141946
823 Reviewed by Ryosuke Niwa.
825 Check in ircbot.py and irclib.py to avoid network problems in the future.
827 * Scripts/webkitpy/common/net/irc/ircbot.py:
828 * Scripts/webkitpy/thirdparty/__init__.py:
829 (AutoinstallImportHook.find_module):
830 (AutoinstallImportHook._install_irc): Deleted.
831 * Scripts/webkitpy/thirdparty/__init___unittest.py:
832 (ThirdpartyTest.test_imports):
833 * Scripts/webkitpy/thirdparty/irc/__init__.py: Added.
834 * Scripts/webkitpy/thirdparty/irc/ircbot.py: Added.
835 * Scripts/webkitpy/thirdparty/irc/irclib.py: Added.
837 2015-03-06 David Kilzer <ddkilzer@apple.com>
839 Dashboard: Perf bot status is missing for Apple {Mavericks,Yosemite} Release builds
841 See also fix to config.json in r181097.
843 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
844 (WebKitBuildbot): Add missing "WK2" to the names of the perf
847 2015-03-06 Csaba Osztrogonác <ossy@webkit.org>
849 run-jsc-stress-tests should determine the architecture from ELF binaries
850 https://bugs.webkit.org/show_bug.cgi?id=142335
852 Reviewed by Darin Adler.
854 * Scripts/run-jsc-stress-tests:
856 2015-03-05 David Kilzer <ddkilzer@apple.com>
858 [iOS] TestExpectations for ios-simulator-wk2 should fall back to 'wk2' after 'ios-simulator'
859 <http://webkit.org/b/142226>
861 Reviewed by Darin Adler.
863 * Scripts/webkitpy/port/ios.py:
864 (IOSSimulatorPort.default_baseline_search_path): Switch the
865 TestExpectations order of ios-simulator-wk2 from this:
866 ios-simulator-wk2, wk2, ios-simulator
868 ios-simulator-wk2, ios-simualtor, wk2
870 2015-03-05 Brent Fulgham <bfulgham@apple.com>
872 [Win] Provide tiered logging from MSBuild -- Errors on top, Warnings after
873 https://bugs.webkit.org/show_bug.cgi?id=142370
875 Reviewed by Dean Jackson.
877 * Scripts/webkitdirs.pm:
878 (buildVisualStudioProject): Tell MSBuild to output log files to two separate
879 logs, one for warnings, the other for errors.
880 * win/AssembleBuildLogs/AssembleLogs.cmd: Combine the error and warning logs
881 into the standard BuildOutput.htm document.
883 2015-03-05 David Kilzer <ddkilzer@apple.com>
885 Dashboard has trouble parsing iOS test output
886 <http://webkit.org/b/142364>
888 Reviewed by Alex Christensen.
890 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
891 (BuildbotTestResults.prototype._parseResults.resultSummarizer):
892 Add fallback path to build a regex using 'matchString' so that
893 it matches anywhere in the line. In practice, 'matchString' is
894 a prefix for the label following the number.
896 2015-03-05 Alex Christensen <achristensen@webkit.org>
898 Fix linker warnings in TestWebKitAPI.
899 https://bugs.webkit.org/show_bug.cgi?id=141912
901 Reviewed by David Kilzer.
903 * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
904 Do not export TearDownTestCase or SetUpTestCase symbols.
906 2015-03-05 Brent Fulgham <bfulgham@apple.com>
908 [Win] Unreviewed EWS fix.
910 * Scripts/webkitdirs.pm:
911 (buildVisualStudioProject): Dial logging back to 'ErrorsOnly' to see if that makes
912 the EWS output more usable.
914 2015-03-05 Chris Dumez <cdumez@apple.com>
916 Regression(r173761): ASSERTION FAILED: !is8Bit() in StringImpl::characters16()
917 https://bugs.webkit.org/show_bug.cgi?id=142350
919 Reviewed by Michael Saboff and Benjamin Poulain.
921 Add API test for WTFString::hasInfixStartingAt() to make sure it doesn't
922 crash if the string is 8-bit but the pattern is 16-bit (and vice-versa).
924 * TestWebKitAPI/Tests/WTF/WTFString.cpp:
925 (TestWebKitAPI::TEST):
927 2015-03-05 Brent Fulgham <bfulgham@apple.com>
929 [Win] Ensure build target directory exists when launching MSBuild
930 https://bugs.webkit.org/show_bug.cgi?id=142360
932 Reviewed by Dean Jackson.
934 Create the build output directory (if it doesn't exist) before
935 launching MSBuild so that it can immediately begin writing logs.
937 * Scripts/webkitdirs.pm:
938 (buildVisualStudioProject):
940 2015-03-05 Chris Dumez <cdumez@apple.com>
942 run-webkit-tests and run-perf-tests should use WebKitTestRunner by default
943 https://bugs.webkit.org/show_bug.cgi?id=142325
945 Reviewed by Csaba Osztrogonác.
947 run-webkit-tests and run-perf-tests now use WebKitTestRunner by default.
948 As a result, "--webkit-test-runner / -2" parameters are replaced by
949 "--dump-render-tree / -1" so developers can run DumpRenderTree rather
950 than WebKitTestRunner.
952 * BuildSlaveSupport/build.webkit.org-config/config.json:
953 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
955 (RunWebKit1Tests.start):
956 (RunWebKit1LeakTests):
957 (RunWebKit1LeakTests.start):
958 (RunAndUploadPerfTestsWebKit1):
959 (RunAndUploadPerfTestsWebKit1.start):
961 (TestWebKit1LeaksFactory):
962 (TestWebKit1LeaksFactory.__init__):
963 (TestWebKit1Factory):
964 (TestWebKit1AllButJSCFactory):
965 (TestAllButJSCFactory):
966 (BuildAndPerfTestWebKit1Factory):
967 (BuildAndPerfTestWebKit1Factory.__init__):
968 (BuildAndPerfTestFactory):
969 (BuildAndPerfTestFactory.__init__):
970 (DownloadAndPerfTestWebKit1Factory):
971 (DownloadAndPerfTestWebKit1Factory.__init__):
972 (DownloadAndPerfTestFactory):
973 (DownloadAndPerfTestFactory.__init__):
974 (RunWebKitLeakTests): Deleted.
975 (RunWebKitLeakTests.start): Deleted.
976 (RunWebKit2Tests): Deleted.
977 (RunWebKit2Tests.start): Deleted.
978 (RunAndUploadPerfTestsWebKit2): Deleted.
979 (RunAndUploadPerfTestsWebKit2.start): Deleted.
980 (TestLeaksFactory): Deleted.
981 (TestLeaksFactory.__init__): Deleted.
982 (TestWebKit2Factory): Deleted.
983 (TestWebKit2AndJSCFactory): Deleted.
984 (BuildAndPerfTestWebKit2Factory): Deleted.
985 (BuildAndPerfTestWebKit2Factory.__init__): Deleted.
986 (DownloadAndPerfTestWebKit2Factory): Deleted.
987 (DownloadAndPerfTestWebKit2Factory.__init__): Deleted.
988 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
990 * Scripts/webkitpy/performance_tests/perftestsrunner.py:
991 (PerfTestsRunner._parse_args):
992 * Scripts/webkitpy/port/port_testcase.py:
993 (PortTestCase.test_build_driver):
995 2015-03-05 Brent Fulgham <bfulgham@apple.com>
997 [Win] Switch to MSBuild so we get more useful stdout logging in buildbot
998 https://bugs.webkit.org/show_bug.cgi?id=140845
1000 Reviewed by David Kilzer.
1002 Update 'webkitdirs.pm' to locate the MSBuild used with Visual Studio 2013
1003 and generate suitable build commands to drive a full build from our
1004 existing solution files.
1006 * Scripts/webkitdirs.pm:
1007 (msBuildInstallDir): Added.
1008 (determineConfigurationForVisualStudio): Revise to use MSBuild command
1009 line arguments to drive the build.
1010 (setupCygwinEnv): Warn user if MSBuild cannot be located.
1011 (buildVisualStudioProject): Revise to use MSBuild command line arguments
1012 to specify build architecture.
1013 * win/AssembleBuildLogs/AssembleLogs.cmd: MSBuild doesn't produce individual
1014 output logs, so don't attempt to consolidate them. Also: Drive-by fix: Don't
1015 bother looking for CoreUI or SafariTheme build logs.
1017 2015-03-05 Csaba Osztrogonác <ossy@webkit.org>
1019 [buildbot] mastercfg_unittest.py should be runnable easily
1020 https://bugs.webkit.org/show_bug.cgi?id=142219
1022 Reviewed by Chris Dumez.
1024 Buildbot 0.8.6p1 runs on build.webkit org with Twisted 12.1.0, which is
1025 the last Twisted version works together with this buildbot version.
1027 * Scripts/webkitpy/common/system/autoinstall.py:
1028 (AutoInstaller): Added prepend_to_search_path argument to be able
1029 to prefer autoinstalled package to system package.
1030 (AutoInstaller.__init__):
1031 (AutoInstaller._set_up_target_dir):
1032 (AutoInstaller._extract_tar): Renamed from _extract_targz, now it works with tar.bz2 too.
1033 (AutoInstaller._prepare_package):
1034 (AutoInstaller._extract_targz): Renamed to _extract_tar.
1035 * Scripts/webkitpy/thirdparty/__init__.py:
1036 (AutoinstallImportHook._install_buildbot): Autoinstall Twisted 12.1.0.
1038 2015-03-05 Lukasz Bialek <l.bialek@samsung.com>
1040 [EFL][WK2] Crash when "Download Linked File" from MiniBrowser context menu is clicked
1041 https://bugs.webkit.org/show_bug.cgi?id=131162
1043 Reviewed by Gyuyoung Kim.
1045 * MiniBrowser/efl/main.c:
1046 (on_download_request):
1047 (on_download_finished):
1048 (on_download_failed):
1050 Adapt download callbacks to new callback mechanism
1052 2015-03-05 Carlos Garcia Campos <cgarcia@igalia.com>
1054 Unreviewed. Fix /webkit2/WebKitWebResource/mime-type after r180927.
1056 In r180927 we updated the libsoup version used by the jhbuild. In
1057 this new version the sniffer uses image/x-icon instead of
1058 image/vnd.microsoft.icon for blank.ico resource.
1060 * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1061 (testWebResourceMimeType):
1063 2015-03-05 Carlos Garcia Campos <cgarcia@igalia.com>
1065 [SOUP] Check TLS errors as soon as they are set in the SoupMessage
1066 https://bugs.webkit.org/show_bug.cgi?id=142244
1068 Reviewed by Sergio Villar Senin.
1070 Check that the SSL server doesn't process any request in case of
1071 TLS errors when the policy is set to FAIL.
1073 * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1074 (testTLSErrorsPolicy):
1075 (testTLSErrorsRedirect):
1076 (testTLSErrorsHTTPAuth):
1077 (testLoadFailedWithTLSErrors):
1078 (testSubresourceLoadFailedWithTLSErrors):
1079 (httpsServerCallback):
1081 2015-03-05 Pawel Forysiuk <p.forysiuk@samsung.com>
1083 [EFL] REGRESSION (r178685): ASSERTION FAILED: !parameters.mediaKeyStorageDirectory.isEmpty()
1084 https://bugs.webkit.org/show_bug.cgi?id=141154
1086 Reviewed by Jer Noble.
1088 Unlike GTK, EFL port enables ENABLE_ENCRYPTED_MEDIA_V2 build option by default.
1090 For the sake of completeness WebKitTestRunner should specify temporary
1091 folder for MediaKeysStorageDirecory as well as IndexedDB, LocalStorage, etc.
1093 Default non legacy paths are set up in ProcessPoolConfiguration constructor.
1094 They use WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation
1095 to get data storage paths. Only Mac port has an actual implementation of it.
1096 However, WebKitTestRunner overrides them in favour of unique temporary dir
1097 which is taken from libraryPathForTesting().
1099 Since WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation
1100 is not implemented for EFL and GTK ports it returns an empty string.
1101 All default data folders besides MediaKeys are overridden in TestRunner
1102 code with unique temporary folders derived from DUMPRENDERTREE_TEMP
1105 GTK port does not enable encrypted keys by default so
1106 WebMediaKeyStorageManager::initialize() code path is never triggered.
1108 * WebKitTestRunner/TestController.cpp:
1109 (WTR::TestController::initialize): Set MediaKeysStorageDirectory for all
1112 2015-03-05 Csaba Osztrogonác <ossy@webkit.org>
1114 [buildbot] Add regression test to check which builder runs which tests
1115 https://bugs.webkit.org/show_bug.cgi?id=142166
1117 Reviewed by Alexey Proskuryakov.
1119 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1120 (BuildStepsConstructorTest.createTest):
1122 (BuildStepsTest.generateTests):
1123 (BuildStepsTest.createTest):
1124 (BuildStepsTest.createTest.doTest):
1125 (BuildStepsTest.test_unnecessary_expected_results):
1127 2015-03-04 Commit Queue <commit-queue@webkit.org>
1129 Unreviewed, rolling out r181054.
1130 https://bugs.webkit.org/show_bug.cgi?id=142320
1132 Broke the api tests (Requested by sundiamonde on #webkit).
1136 "Fix linker warnings in TestWebKitAPI."
1137 https://bugs.webkit.org/show_bug.cgi?id=141912
1138 http://trac.webkit.org/changeset/181054
1140 2015-03-04 Alex Christensen <achristensen@webkit.org>
1142 Fix linker warnings in TestWebKitAPI.
1143 https://bugs.webkit.org/show_bug.cgi?id=141912
1145 Reviewed by David Kilzer.
1147 * TestWebKitAPI/Configurations/Base.xcconfig:
1148 Use GCC_SYMBOLS_PRIVATE_EXTERN like we do in WebCore.
1150 2015-03-04 Alexey Proskuryakov <ap@apple.com>
1152 [Mac] Set SystemUIFontSelect in DRT and WKTR
1153 https://bugs.webkit.org/show_bug.cgi?id=142303
1155 Reviewed by Myles C. Maxfield.
1157 * DumpRenderTree/mac/DumpRenderTree.mm:
1158 (setDefaultsToConsistentValuesForTesting):
1159 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1160 (WTR::InjectedBundle::platformInitialize):
1162 2015-03-04 Chris Dumez <cdumez@apple.com>
1164 Mac Perf bots should use WebKitTestRunner instead of DumpRenderTree
1165 https://bugs.webkit.org/show_bug.cgi?id=142314
1166 <rdar://problem/20046835>
1168 Reviewed by Ryosuke Niwa.
1170 Mac Perf bots should use WebKitTestRunner instead of DumpRenderTree
1171 to get WK2 code coverage.
1173 * BuildSlaveSupport/build.webkit.org-config/config.json:
1175 2015-03-04 Alex Christensen <achristensen@webkit.org>
1177 Move content extensions test to properly named directory.
1178 https://bugs.webkit.org/show_bug.cgi?id=142299
1180 Reviewed by Tim Horton.
1182 * WebKitTestRunner/mac/TestControllerMac.mm:
1183 (WTR::TestController::platformConfigureViewForTest):
1185 2015-03-04 Youenn Fablet <youenn.fablet@crf.canon.fr>
1187 W3C test importer should use filesystem instead of os.walk
1188 https://bugs.webkit.org/show_bug.cgi?id=142085
1190 Reviewed by Bem Jones-Bey.
1192 Added FileSystem.dirs_under to remove the use of os.walk in test importer.
1193 Added MockFileSystem.dirs_under and MockFileSystem.getsize to enable unit testing of test importer.
1194 Added unit test for FileSystem.dirs_under and MockFileSystem.dirs_under.
1196 Made use of FileSystem.dirs_under within TestImporter.find_importable_tests.
1197 Added a unit test to check that test importer is now black-box testable using a Mock system.
1199 * Scripts/webkitpy/common/system/filesystem.py:
1200 (FileSystem.dirs_under): Returns a list of filtered sub-directories.
1201 (FileSystem.dirs_under.filter_all):
1202 * Scripts/webkitpy/common/system/filesystem_mock.py:
1203 (MockFileSystem.dirs_under):
1204 (MockFileSystem.dirs_under.filter_all):
1205 (MockFileSystem.getsize):
1206 * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
1207 (MockFileSystemTest.test_dirs_under):
1208 (MockFileSystemTest.test_dirs_under.filter_dir):
1209 * Scripts/webkitpy/common/system/filesystem_unittest.py:
1210 (RealFileSystemTest.test_sep):
1211 (RealFileSystemTest):
1212 (RealFileSystemTest.test_dirs_under):
1213 (RealFileSystemTest.test_dirs_under.filter_this_dir):
1214 * Scripts/webkitpy/w3c/test_importer.py:
1215 (TestImporter.do_import):
1216 (TestImporter.find_importable_tests.should_keep_subdir):
1217 (TestImporter.find_importable_tests):
1218 (TestImporter.should_keep_subdir): Deleted.
1219 (TestImporter.should_skip_file): Deleted.
1220 * Scripts/webkitpy/w3c/test_importer_unittest.py:
1221 (TestImporterTest.test_import_dir_with_empty_init_py): Added test to ensure empty __init__.py are no longer empty once imported.
1223 2015-03-04 Timothy Horton <timothy_horton@apple.com>
1225 [WebEditingTester] Add support for the find and replace bar
1226 https://bugs.webkit.org/show_bug.cgi?id=142247
1228 Reviewed by Enrica Casucci.
1230 While it's not hooked up yet in WKWebView, adding support for the
1231 find bar to WebEditingTester will help us implement that functionality.
1233 * WebEditingTester/AppDelegate.h:
1234 * WebEditingTester/AppDelegate.m:
1235 (-[WebEditingAppDelegate performTextFinderAction:]):
1236 * WebEditingTester/MainMenu.xib:
1237 Receive performTextFinderAction: and forward it to the frontmost WebDocumentController.
1239 * WebEditingTester/WK2WebDocumentController.m:
1240 (-[WK2WebDocumentController awakeFromNib]):
1241 (-[WK2WebDocumentController performTextFinderAction:]):
1242 (-[WK2WebDocumentController findBarView]):
1243 (-[WK2WebDocumentController setFindBarView:]):
1244 (-[WK2WebDocumentController isFindBarVisible]):
1245 (-[WK2WebDocumentController setFindBarVisible:]):
1246 (-[WK2WebDocumentController findBarViewDidChangeHeight]):
1247 (-[WK2WebDocumentController layout]):
1248 Implement performTextFinderAction: for WebKit2, and have a NSTextFinder
1249 pointing at the WKWebView (currently nothing will work, but the bar will
1250 show up). Install and uninstall the bar as needed.
1252 * WebEditingTester/WebDocument.xib:
1253 Don't use a full-size content view. There's no need, and it makes find
1256 * WebEditingTester/WebDocumentController.h:
1257 * WebEditingTester/WebDocumentController.m:
1258 (-[WebDocumentController performTextFinderAction:]):
1260 2015-03-03 Sam Weinig <sam@webkit.org>
1262 [Content Extensions] Split parsing and compiling of content extensions into their own files
1263 https://bugs.webkit.org/show_bug.cgi?id=142259
1265 Reviewed by Anders Carlsson.
1267 Add basic unit test for the content filter compiler.
1269 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1270 * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Added.
1271 (WebCore::ContentExtensions::operator<<):
1272 (TestWebKitAPI::ContentFilterTest::SetUp):
1273 (TestWebKitAPI::TEST_F):
1275 2015-03-04 Matthew Mirman <mmirman@apple.com>
1277 Cleaned up BuildAndTestFactory to not be a near duplicate of TestFactory
1278 https://bugs.webkit.org/show_bug.cgi?id=142230
1280 Reviewed by Csaba Osztrogonác.
1282 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1284 (TestFactory.getProduct): Added
1285 (TestFactory.__init__): moved downloader to getProduct
1286 (BuildAndTestFactory):
1287 (BuildAndTestFactory.getProduct): Added
1288 (BuildAndTestFactory.__init__): made to call TestFactory.__init__ and append steps to the end.
1289 (BuildAndTestWebKit2Factory): Deleted. Wasn't used anywhere.
1291 2015-03-04 Debarshi Ray <debarshir@gnome.org>
1293 [GTK] WebView should hold a reference on WebContext because non-default contexts are a reality
1294 https://bugs.webkit.org/show_bug.cgi?id=142225
1296 Reviewed by Carlos Garcia Campos.
1298 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1299 (testWebViewWebContextLifetime):
1302 2015-03-03 David Kilzer <ddkilzer@apple.com>
1304 [iOS] Crash logs can't be found on ios-simulator because WebKitTestRunner returns the wrong process name
1305 <http://webkit.org/b/142243>
1307 Reviewed by Alexey Proskuryakov.
1309 * WebKitTestRunner/TestController.cpp:
1310 (WTR::TestController::webProcessName):
1311 (WTR::TestController::networkProcessName):
1312 - Return the same process name on iOS and Mac because they both
1313 use the same process name for local engineering builds.
1315 2015-03-03 David Kilzer <ddkilzer@apple.com>
1317 check-webkit-style: Add exception for FrameworkSoftLink.h header order
1318 <http://webkit.org/b/141872>
1320 Reviewed by Alex Christensen.
1322 * Scripts/webkitpy/style/checkers/cpp.py: Remove unneeded
1323 semi-colons in various places and fix whitespace.
1324 (_IncludeState): Add _SOFT_LINK_HEADER and _SOFT_LINK_SECTION
1326 (_IncludeState.__init__): Add self._visited_soft_link_section
1327 boolean state variable.
1328 (_IncludeState.visited_soft_link_section): Getter for
1329 self._visited_soft_link_section.
1330 (_IncludeState.check_next_include_order): Update state machine
1331 for soft-link headers. Add check that soft-link headers always
1333 (_classify_include): Add check for soft-link header type.
1334 (check_include_line): Return early if there is a soft-link
1337 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1338 (OrderOfIncludesTest.test_public_primary_header): Add tests for
1339 including soft-link headers.
1340 (OrderOfIncludesTest.test_classify_include): Add test for
1341 _SOFT_LINK_HEADER type.
1343 2015-03-03 Alexey Proskuryakov <ap@apple.com>
1345 build.webkit.org/dashboard: Don't repeatedly handle each test type
1346 https://bugs.webkit.org/show_bug.cgi?id=142211
1348 Reviewed by Tim Horton and Matt Hanson.
1350 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1351 (Buildbot.prototype.javascriptTestResultsURLForIteration): Deleted.
1352 (Buildbot.prototype.apiTestResultsURLForIteration): Deleted.
1353 (Buildbot.prototype.platformAPITestResultsURLForIteration): Deleted.
1354 (Buildbot.prototype.webkitpyTestResultsURLForIteration): Deleted.
1355 (Buildbot.prototype.webkitperlTestResultsURLForIteration): Deleted.
1356 (Buildbot.prototype.bindingsTestResultsURLForIteration): Deleted.
1357 Removed functions that build a link to test step results. The buildbot provides
1358 these links in JSON.
1360 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1361 (BuildbotIteration): Put failing tests into an array, instead of named variables.
1362 (BuildbotIteration.ProductiveSteps): Removed step names that are not used on build.webkit.org.
1363 We can easily add them to the map as needed.
1364 (BuildbotIteration.TestSteps): Added a list of test steps to be displayed by test queues.
1365 (BuildbotIteration.prototype._parseData): Moved code for parsing step results away
1366 to BuildbotTestResults class. We used to parse here, build an intermediate data structure,
1367 and then build a BuildbotTestResults object, which was strange.
1368 (BuildbotIteration.prototype.loadLayoutTestResults): Ditto.
1370 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1371 Corrected an unrelated assertion that was buggy, and kept firing.
1373 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1374 (BuildbotTestResults):
1375 (BuildbotTestResults.prototype._parseResults.resultSummarizer):
1376 (BuildbotTestResults.prototype._parseResults):
1377 (BuildbotTestResults.prototype.addFullLayoutTestResults):
1378 Moved the code for parsing JSON results for a single step here.
1380 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1381 (BuildbotTesterQueueView.prototype._testStepFailureDescription):
1382 (BuildbotTesterQueueView.prototype._testStepFailureDescriptionWithCount):
1383 (BuildbotTesterQueueView.prototype._presentPopoverForGenericTestFailures):
1384 (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Deleted.
1385 (BuildbotTesterQueueView.prototype.update): Deleted.
1386 (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds): Deleted.
1387 Updated for the new data structures. One behavior change is that we now display individual
1388 counts when multiple test kinds fail, e.g. "1 javascript test failure, 83+ layout
1389 test failures, 3 platform api test failures".
1391 2015-03-03 Matthew Mirman <mmirman@apple.com>
1393 JSC tests should not be repeated twice for each branch builder, and should if possible have their own queue.
1394 https://bugs.webkit.org/show_bug.cgi?id=142094
1396 Reviewed by Csaba Osztrogonác.
1398 * BuildSlaveSupport/build.webkit.org-config/config.json: Added bots 155 and 157
1399 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1401 (TestFactory.__init__): Made running of JSC tests conditional.
1402 (TestAllButJSCFactory):
1403 (TestJSCFactory): Added.
1404 (TestJSCFactory.__init__):
1405 (TestWebKit2AndJSCFactory): Added factory to not run JSC tests on WebKit2.
1407 2015-03-03 David Kilzer <ddkilzer@apple.com>
1409 `build-webkit --help` is wrong about how to build for the iOS simulator
1410 <http://webkit.org/b/142223>
1412 Reviewed by Csaba Osztrogonác.
1414 * Scripts/build-webkit: Fix help.
1416 2015-03-03 Carlos Garcia Campos <cgarcia@igalia.com>
1418 Unreviewed. Bump libsoup version to 2.49.91.1 to fix 32 bit build.
1420 * gtk/jhbuild.modules:
1422 2015-03-03 Carlos Garcia Campos <cgarcia@igalia.com>
1424 [SOUP] Synchronous XMLHttpRequests can time out when we reach the max connections limit
1425 https://bugs.webkit.org/show_bug.cgi?id=141508
1427 Reviewed by Sergio Villar Senin.
1429 Add a unit test to check that synchronous XHRs load even if the
1430 maximum connection limits are reached.
1432 * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1433 (testWebViewSyncRequestOnMaxConns):
1436 * gtk/jhbuild.modules: Bump libsoup version to 2.49.91.
1438 2015-03-02 Alexey Proskuryakov <ap@apple.com>
1440 Update the name of ASan build step.
1442 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1444 2015-03-02 Jer Noble <jer.noble@apple.com>
1446 [WK1][WK2][Mac] Fullscreen animation is incorrect when page is scaled.
1447 https://bugs.webkit.org/show_bug.cgi?id=142121
1449 Reviewed by Simon Fraser.
1451 Add a test which changes the WebView's page scale, then enters fullscreen mode, and verifies
1452 that the initial and final screen rects for the web content are as expected.
1454 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1455 * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.html: Added.
1456 * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm: Added.
1457 (-[FullscreenStateDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
1458 (runJavaScriptAlert):
1459 (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
1460 (TestWebKitAPI::FullscreenZoomInitialFrame::teardownView):
1461 (TestWebKitAPI::FullscreenZoomInitialFrame::setPageScale):
1462 (TestWebKitAPI::FullscreenZoomInitialFrame::sendMouseDownEvent):
1463 (TestWebKitAPI::FullscreenZoomInitialFrame::runTest):
1464 (TestWebKitAPI::TEST_F):
1466 2015-03-01 David Kilzer <ddkilzer@apple.com>
1468 LayoutTestRealy: Prepend __XPC_ to the key, not the value!
1472 LayoutTestRelay: App environment variables not set for --guard-malloc or --leaks
1473 <http://webkit.org/b/142145>
1475 * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1476 (-[LTRelayController _environmentVariables]): Fix think-o.
1478 2015-03-01 David Kilzer <ddkilzer@apple.com>
1480 LayoutTestRelay: App environment variables not set for --guard-malloc or --leaks
1481 <http://webkit.org/b/142145>
1483 Reviewed by Simon Fraser.
1485 * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1486 (-[LTRelayController _environmentVariables]): Add.
1487 (-[LTRelayController launchApp]): Use -_environmentVariables.
1489 2015-02-28 David Kilzer <ddkilzer@apple.com>
1491 [iOS] Stop running webkit-build-directory on every layout test
1493 This was originally fixed by David Farler for Bug 135409 in
1496 * Scripts/webkitpy/port/ios.py:
1497 (IOSSimulatorPort.relay_path): Mark as @memoized so it doesn't
1498 run webkit-build-directory every time it's called.
1500 2015-02-28 Youenn Fablet <youenn.fablet@crf.canon.fr>
1502 W3C importer should use filesystem instead of shutil/host
1503 https://bugs.webkit.org/show_bug.cgi?id=142012
1505 Reviewed by Bem Jones-Bey.
1507 Removed direct use of python shutil and os, except for os.walk which will require its own fix.
1509 * Scripts/webkitpy/w3c/test_importer.py:
1511 (TestImporter.do_import):
1512 (TestImporter.find_importable_tests):
1513 (TestImporter.import_tests):
1514 (TestImporter.remove_deleted_files):
1515 (TestImporter.write_import_log):
1517 2015-02-28 Youenn Fablet <youenn.fablet@crf.canon.fr>
1519 W3C test importer should use filesystem to read and write files
1520 https://bugs.webkit.org/show_bug.cgi?id=142084
1522 Reviewed by Bem Jones-Bey.
1524 Use of FileSystem.write_binary_file, read_text_file and write_text_file in lieu of open().
1526 * Scripts/webkitpy/w3c/test_importer.py:
1527 (TestImporter.import_tests):
1528 (TestImporter.remove_deleted_files):
1529 (TestImporter.write_import_log):
1531 2015-02-27 Sam Weinig <sam@webkit.org>
1533 Add WebKit2 SPI to create a DOM File object
1534 https://bugs.webkit.org/show_bug.cgi?id=142109
1536 Reviewed by Tim Horton.
1538 Add a test for WKBundleFileHandleRef.
1540 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1541 * TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle.cpp: Added.
1542 (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1543 (TestWebKitAPI::didFinishLoadForFrame):
1544 (TestWebKitAPI::TEST):
1545 * TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle_Bundle.cpp: Added.
1546 (TestWebKitAPI::WKBundleFileHandleTest::WKBundleFileHandleTest):
1547 * TestWebKitAPI/Tests/WebKit2/bundle-file.html: Added.
1549 2015-02-27 Michael Saboff <msaboff@apple.com>
1551 Add ability for run-jsc-benchmarks to set library path from test binary when run on a build bot
1552 https://bugs.webkit.org/show_bug.cgi?id=142112
1554 Reviewed by Filip Pizlo.
1556 Added check for VMs in the form of <someDir>/{DumpRenderTree,webkitTestRunner,jsc} and use
1557 <someDir> as the library path.
1559 * Scripts/run-jsc-benchmarks:
1561 2015-02-27 Alex Christensen <achristensen@webkit.org>
1563 [WinCairo] Unreviewed build fix.
1565 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
1566 Use TestWebKitAPIPrefix.h like in TestWebKitAPICommon.props.
1568 2015-02-27 Anders Carlsson <andersca@apple.com>
1570 Add infrastructure for handling website data in the network process
1571 https://bugs.webkit.org/show_bug.cgi?id=142092
1573 Reviewed by Andreas Kling.
1575 Add a menu item that will fetch all website data, delete the returned data records, and
1576 fetch all website data again so we can confirm that it's all empty.
1578 * MiniBrowser/mac/WK2BrowserWindowController.m:
1579 (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
1581 2015-02-26 Brent Fulgham <bfulgham@apple.com>
1583 [Win] Remove remaining SafariTheme cruft
1584 https://bugs.webkit.org/show_bug.cgi?id=142075
1586 Reviewed by Anders Carlsson.
1588 Remove reference to SafariTheme-switching preference.
1590 * DumpRenderTree/win/DumpRenderTree.cpp:
1591 (resetWebPreferencesToConsistentValues):
1592 (prepareConsistentTestingEnvironment):
1594 2015-02-26 Doug Russell <d_russell@apple.com>
1596 AX: Expose caret browsing preference to accessibility API
1597 https://bugs.webkit.org/show_bug.cgi?id=141862
1599 Reviewed by Chris Fleizach.
1601 Exposing the caret browsing setting on WebCore::Frame via the accessibility API would allow assistive tech apps to enable it contextually (for example, when the assistive tech app is running).
1602 Enabling caret browsing when assistive tech apps are running greatly improves the reliability of keyboard navigation on the web. Most especially in cases where selection would be disrupted by focus events.
1604 * DumpRenderTree/AccessibilityUIElement.cpp:
1605 (setBoolAttributeValueCallback):
1606 (selectedTextMarkerRangeCallback):
1607 (resetSelectedTextMarkerRangeCallback):
1608 (AccessibilityUIElement::setBoolAttributeValue):
1609 (AccessibilityUIElement::selectedTextMarkerRange):
1610 (AccessibilityUIElement::resetSelectedTextMarkerRange):
1611 (AccessibilityUIElement::getJSClass):
1612 * DumpRenderTree/AccessibilityUIElement.h:
1613 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1614 (AccessibilityUIElement::setBoolAttributeValue):
1615 (AccessibilityUIElement::selectedTextMarkerRange):
1616 (AccessibilityUIElement::resetSelectedTextMarkerRange):
1617 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1618 (WTR::AccessibilityUIElement::selectedTextMarkerRange):
1619 (WTR::AccessibilityUIElement::resetSelectedTextMarkerRange):
1620 (WTR::AccessibilityUIElement::setBoolAttributeValue):
1621 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1622 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1623 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1624 (WTR::AccessibilityUIElement::setBoolAttributeValue):
1625 (WTR::AccessibilityUIElement::selectedTextMarkerRange):
1626 (WTR::AccessibilityUIElement::resetSelectedTextMarkerRange):
1628 2015-02-26 Brent Fulgham <bfulgham@apple.com>
1630 [Win] Remove WebKitExportGenerator project (and related)
1631 https://bugs.webkit.org/show_bug.cgi?id=142035
1633 Reviewed by Dean Jackson.
1635 * win/AssembleBuildLogs/AssembleLogs.cmd: Don't look for a
1636 build log from WebKitExportGenerator.
1638 2015-02-26 Csaba Osztrogonác <ossy@webkit.org>
1640 [EFL] Bump EFL version to 1.13.0
1641 https://bugs.webkit.org/show_bug.cgi?id=141708
1643 Reviewed by Gyuyoung Kim.
1645 * efl/jhbuild.modules:
1647 2015-02-26 Sam Weinig <sam@webkit.org>
1649 Check in missing WebEditingTester.xcconfig file.
1651 * WebEditingTester/Configurations/WebEditingTester.xcconfig: Added.
1653 2015-02-26 Csaba Osztrogonác <ossy@webkit.org>
1655 [webkitpy] Remove skipped file related crufts
1656 https://bugs.webkit.org/show_bug.cgi?id=142046
1658 Reviewed by Ryosuke Niwa.
1660 * Scripts/webkitpy/port/base.py:
1661 (Port.skipped_layout_tests):
1662 (Port._tests_from_skipped_file_contents): Deleted.
1664 (Port._expectations_from_skipped_files): Deleted.
1665 * Scripts/webkitpy/port/mac_unittest.py:
1666 (MacTest.test_default_timeout_ms):
1668 (test_tests_from_skipped_file_contents): Deleted.
1670 2015-02-26 Brent Fulgham <bfulgham@apple.com>
1672 [Win] Unreviewed WinCairo build fix after r180653.
1674 TestWebKitAPI should know about proper WEBCORE_EXPORT definitions.
1676 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1677 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
1678 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
1679 * TestWebKitAPI/win/TestWebKitAPIPrefix.cpp: Added.
1680 * TestWebKitAPI/win/TestWebKitAPIPrefix.h: Added.
1682 2015-02-25 Brent Fulgham <bfulgham@apple.com>
1684 [Win] Use WEBCORE_EXPORT instead of Definition file
1685 https://bugs.webkit.org/show_bug.cgi?id=141734
1687 Reviewed by Alex Christensen.
1689 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1690 Use a precompiled header so we can define our export macros properly.
1691 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj.filters:
1692 Visual studio automatic update stuff.
1693 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
1694 Set up Precompiled Header use for project..
1695 * DumpRenderTree/win/DumpRenderTreePrefix.cpp: Added.
1696 * DumpRenderTree/DumpRenderTreePrefix.h: Update with proper export
1697 declarations for building DumpRenderTree as a client of
1700 2015-02-25 Mark Lam <mark.lam@apple.com>
1702 ASan does not like JSC::MachineThreads::tryCopyOtherThreadStack.
1703 <https://webkit.org/b/141672>
1705 Reviewed by Alexey Proskuryakov.
1707 ASan does not like the fact that we memcpy the stack for GC scans. So,
1708 we're working around this by using our own memcpy (asanUnsafeMemcpy)
1709 implementation that we can tell ASan to ignore.
1711 Also removed the previous added directive to ignore *tryCopyOtherThreadStack*
1712 which isn't effective for working around this issue.
1714 * asan/webkit-asan-ignore.txt:
1716 2015-02-25 Benjamin Poulain <bpoulain@apple.com>
1718 CodeBlock crashes when dumping op_push_name_scope
1719 https://bugs.webkit.org/show_bug.cgi?id=141953
1721 Reviewed by Filip Pizlo.
1723 * Scripts/run-jsc-stress-tests:
1725 2015-02-25 Youenn Fablet <youenn.fablet@crf.canon.fr>
1727 W3C test importer should use argparse instead of optparse
1728 https://bugs.webkit.org/show_bug.cgi?id=142013
1730 Reviewed by Bem Jones-Bey.
1732 * Scripts/webkitpy/w3c/test_importer.py:
1733 (main): Updating according argparse.
1734 (parse_args): Moving from optparse to argparse.
1736 2015-02-25 Brady Eidson <beidson@apple.com>
1738 Get rid of TestInvocation::pathOrURL
1739 https://bugs.webkit.org/show_bug.cgi?id=142021
1741 Reviewed by Tim Horton.
1743 The pathOrURL string is a relative path used as an argument to WebKitTestRunner,
1744 but most code that uses it expected an absolute path.
1746 This gets rid of the member and replaces all uses with a more descriptive "urlContains" method.
1748 * WebKitTestRunner/TestController.cpp:
1749 (WTR::TestController::updateWebViewSizeForTest):
1750 (WTR::TestController::updateWindowScaleForTest):
1751 (WTR::shouldUseFixedLayout):
1752 (WTR::TestController::updateLayoutTypeForTest):
1754 * WebKitTestRunner/TestInvocation.cpp:
1755 (WTR::TestInvocation::TestInvocation):
1756 (WTR::TestInvocation::urlContains):
1757 (WTR::TestInvocation::shouldLogFrameLoadDelegates):
1758 (WTR::TestInvocation::shouldLogHistoryClientCallbacks):
1759 (WTR::TestInvocation::invoke):
1760 (WTR::shouldLogFrameLoadDelegates): Deleted.
1761 (WTR::shouldLogHistoryClientCallbacks): Deleted.
1762 * WebKitTestRunner/TestInvocation.h:
1763 (WTR::TestInvocation::pathOrURL): Deleted.
1765 * WebKitTestRunner/ios/TestControllerIOS.mm:
1766 (WTR::shouldMakeViewportFlexible):
1767 (WTR::TestController::platformConfigureViewForTest):
1769 * WebKitTestRunner/mac/TestControllerMac.mm:
1770 (WTR::shouldUseThreadedScrolling):
1771 (WTR::TestController::platformConfigureViewForTest):
1773 2015-02-25 Brady Eidson <beidson@apple.com>
1775 Layout test support for user content filters
1776 https://bugs.webkit.org/show_bug.cgi?id=142018
1778 Reviewed by Tim Horton.
1780 * WebKitTestRunner/TestController.cpp:
1781 (WTR::TestController::resetStateToConsistentValues): Clear all user content filters between tests.
1783 * WebKitTestRunner/mac/TestControllerMac.mm:
1784 (WTR::TestController::platformConfigureViewForTest): For all tests with usercontentfilter/ in their path try to load a matching .json
1785 file before loading the test itself.
1787 2015-02-24 Sam Weinig <sam@webkit.org>
1789 Convert WebEditingTester to use xcconfig files
1790 https://bugs.webkit.org/show_bug.cgi?id=141879
1792 Reviewed by Darin Adler.
1794 Add xcconfig files to WebEditingTester based on the ones used by MiniBrowser.
1796 * WebEditingTester/Configurations: Added.
1797 * WebEditingTester/Configurations/Base.xcconfig: Added.
1798 * WebEditingTester/Configurations/DebugRelease.xcconfig: Added.
1799 * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
1801 2015-02-24 Andy Estes <aestes@apple.com>
1803 Teach MiniBrowser how to disable per-window web processes
1804 https://bugs.webkit.org/show_bug.cgi?id=141988
1806 Reviewed by Darin Adler.
1808 * MiniBrowser/mac/AppDelegate.m:
1809 (defaultConfiguration): Created a _WKProcessPoolConfiguration with maximumProcessCount == 1 if per-window web processes are disabled.
1810 * MiniBrowser/mac/SettingsController.h:
1811 * MiniBrowser/mac/SettingsController.m:
1812 (-[SettingsController _populateMenu]): Added a new Settings menu item.
1813 (-[SettingsController validateMenuItem:]): Validated the new Settings menu item.
1814 (-[SettingsController togglePerWindowWebProcessesDisabled:]): Displayed an alert informing the user that MiniBrowser must be restarted for the setting to take effect.
1815 (-[SettingsController perWindowWebProcessesDisabled]): Returned the value from user defaults.
1817 2015-02-24 Alexey Proskuryakov <ap@apple.com>
1819 Bot watcher's dashboard sometimes hits an assertion: data.num_missing === this.layoutTestResults.testsWithMissingResults.length
1820 https://bugs.webkit.org/show_bug.cgi?id=141889
1822 Reviewed by Darin Adler.
1824 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1826 2015-02-24 Yusuke Suzuki <utatane.tea@gmail.com>
1828 REGRESSION(r179429): Can't type comments in Facebook
1829 https://bugs.webkit.org/show_bug.cgi?id=141859
1831 Reviewed by Brent Fulgham.
1833 Drop javaScriptExperimentsEnabled and specify JavaScriptRuntimeFlagsAllEnabled as KJavaScriptRuntimeFlags.
1835 * DumpRenderTree/mac/DumpRenderTree.mm:
1836 (resetWebPreferencesToConsistentValues):
1837 * DumpRenderTree/win/DumpRenderTree.cpp:
1838 (resetWebPreferencesToConsistentValues):
1839 * WebKitTestRunner/TestController.cpp:
1840 (WTR::TestController::resetPreferencesToConsistentValues):
1842 2015-02-24 Michael Catanzaro <mcatanzaro@igalia.com>
1844 Crash loading local file with WebPageProxy::loadAlternateHTMLString
1845 https://bugs.webkit.org/show_bug.cgi?id=141867
1847 Reviewed by Anders Carlsson.
1849 * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
1850 (TestWebKitAPI::loadAlternateHTMLString): Split most of this test into a function so it can
1851 be shared with the new test.
1852 (TestWebKitAPI::TEST): Add a cross-platform test for this crash.
1853 * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp: Add a GTK+ test for this crash.
1854 (testLoadAlternateHTMLForLocalPage):
1857 2015-02-24 David Kilzer <ddkilzer@apple.com>
1859 [iOS] Implement WTR::activateFonts() to fix missing fonts in WebKit2 test runs
1860 <http://webkit.org/b/141900>
1862 Reviewed by Myles C. Maxfield.
1864 * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
1865 (OTHER_LDFLAGS_BASE): Link to CoreText.framework.
1866 * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm: Rename from Tools/WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm.
1867 - Rename to share code with iOS.
1868 - Add USE(APPKIT) around AppKit-specific headers and code.
1869 - Fix a check-webkit-style warning.
1870 * WebKitTestRunner/InjectedBundle/ios/ActivateFontsIOS.mm: Remove.
1871 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1872 - Rename mac/ActivateFonts.mm to cocoa/ActivateFontsCocoa.mm.
1873 - Remove ios/ActivateFontsIOS.mm.
1874 - Fix InjectedBundle/cocoa group to represent the directory on
1875 disk. Includes a change to InjectedBundlePageCocoa.mm.
1877 2015-02-23 Commit Queue <commit-queue@webkit.org>
1879 Unreviewed, rolling out r180547 and r180550.
1880 https://bugs.webkit.org/show_bug.cgi?id=141957
1882 Broke 10 Windows tests. (Requested by bfulgham_ on #webkit).
1884 Reverted changesets:
1886 "REGRESSION(r179429): Can't type comments in Facebook"
1887 https://bugs.webkit.org/show_bug.cgi?id=141859
1888 http://trac.webkit.org/changeset/180547
1890 "Constructor returning null should construct an object instead
1892 https://bugs.webkit.org/show_bug.cgi?id=141640
1893 http://trac.webkit.org/changeset/180550
1895 2015-02-23 Yusuke Suzuki <utatane.tea@gmail.com>
1897 REGRESSION(r179429): Can't type comments in Facebook
1898 https://bugs.webkit.org/show_bug.cgi?id=141859
1900 Reviewed by Geoffrey Garen.
1902 Drop javaScriptExperimentsEnabled and specify JavaScriptRuntimeFlagsAllEnabled as KJavaScriptRuntimeFlags.
1904 * DumpRenderTree/mac/DumpRenderTree.mm:
1905 (resetWebPreferencesToConsistentValues):
1906 * WebKitTestRunner/TestController.cpp:
1907 (WTR::TestController::resetPreferencesToConsistentValues):
1909 2015-02-23 KwangHyuk Kim <hyuki.kim@samsung.com>
1912 https://bugs.webkit.org/show_bug.cgi?id=141909
1914 Reviewed by Gyuyoung Kim.
1916 Fix eo errors that occur whenever minibrowser is launched.
1917 - elm_obj_entry_text_style_user_push can only be applied for elm_entry
1918 - elm_obj_win_resize_object_add's first parameter should be elm_win
1920 * MiniBrowser/efl/main.c:
1923 2015-02-23 Ryosuke Niwa <rniwa@webkit.org>
1925 Unreviewed build fix after r180535. Removed the test case that wasn't compiling.
1927 * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1928 (TestWebKitAPI::TEST):
1930 2015-02-23 Brent Fulgham <bfulgham@apple.com>
1932 WTF::WeakPtr should rename 'forgot' to 'clear' and support nullptr assignment
1933 https://bugs.webkit.org/show_bug.cgi?id=141935
1935 Reviewed by Myles C. Maxfield.
1937 * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1938 (TestWebKitAPI::TEST): Updated for 'clear' method rename, and added a few
1939 tests for assigning from nullptr.
1941 2015-02-23 Brent Fulgham <bfulgham@apple.com>
1943 WTF::WeakPtr should have a 'forget' method.
1944 https://bugs.webkit.org/show_bug.cgi?id=141923
1946 Reviewed by Myles C. Maxfield.
1948 * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1949 (TestWebKitAPI::TEST): Added 'Forget' tests case.
1951 2015-02-23 Alexey Proskuryakov <ap@apple.com>
1953 build.webkit.org/dashboard CrashOnly queues should not show two green bubbles
1954 https://bugs.webkit.org/show_bug.cgi?id=141920
1956 Reviewed by Tim Horton.
1958 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1959 (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1960 Do the same thing as we do for regular green bubbles.
1962 2015-02-23 Alexey Proskuryakov <ap@apple.com>
1964 Bot watcher's dashboard doesn't show a popover for commit history when all commits were to another branch
1965 https://bugs.webkit.org/show_bug.cgi?id=141925
1967 Reviewed by Tim Horton.
1969 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1970 (BuildbotQueueView.prototype._presentPopoverForRevisionRange):
1972 2015-02-23 Anders Carlsson <andersca@apple.com>
1974 Add API for fetching website data records to _WKWebsiteDataStore
1975 https://bugs.webkit.org/show_bug.cgi?id=141926
1977 Reviewed by Beth Dakin.
1979 * MiniBrowser/mac/MainMenu.xib:
1980 * MiniBrowser/mac/WK2BrowserWindowController.m:
1981 (-[WK2BrowserWindowController fetchWebsiteData:]):
1982 Add menu item to fetch and dump website data.
1984 2015-02-23 David Kilzer <ddkilzer@apple.com>
1986 [iOS] run-webkit-tests --leaks is broken because IOSSimulatorPort has no is_snowleopard attribute
1987 <http://webkit.org/b/141884>
1989 Reviewed by Alexey Proskuryakov.
1991 * Scripts/webkitpy/port/leakdetector.py:
1992 (LeakDetector._callstacks_to_exclude_from_leaks): Remove
1993 snowleopard, lion and older leaks. Add known leak for
1994 mavericks, but check Port.operating_system before calling
1996 * Scripts/webkitpy/port/mac.py:
1997 (MacPort.is_snowleopard): Delete.
1998 (MacPort.is_lion): Delete.
1999 (MacPort.is_mavericks): Add.
2001 2015-02-23 Alexey Proskuryakov <ap@apple.com>
2003 build.webkit.org/dashboard should filter out commits to other branches
2004 https://bugs.webkit.org/show_bug.cgi?id=140362
2006 Reviewed by Tim Horton.
2008 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2010 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2011 (BuildbotQueueView.prototype._presentPopoverForPendingCommits):
2012 (BuildbotQueueView.prototype._presentPopoverForRevisionRange):
2013 (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration):
2014 (BuildbotQueueView.prototype.revisionContentForIteration):
2015 (BuildbotQueueView.prototype._appendPendingRevisionCount): Deleted.
2016 (BuildbotQueueView.prototype._popoverLinesForCommitRange): Deleted.
2017 (BuildbotQueueView.prototype._revisionPopoverContentForIteration): Deleted.
2018 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
2019 (Trac.prototype.get oldestRecordedRevisionNumber):
2020 (Trac.prototype.commitsOnBranch):
2021 (Trac.prototype._xmlTimelineURL):
2022 (Trac.prototype._convertCommitInfoElementToObject):
2023 (Trac.prototype._update):
2024 (Trac.prototype.startPeriodicUpdates):
2025 (Trac.prototype.loadMoreHistoricalData):
2026 (Trac.prototype.update): Deleted.
2028 2015-02-21 Youenn Fablet <youenn.fablet@crf.canon.fr>
2030 Tests don't work on some bots: Failed to stop wptwk
2031 https://bugs.webkit.org/show_bug.cgi?id=141235
2033 Reviewed by Ryosuke Niwa.
2035 Logging of server subprocesses in launcher script.
2036 Killing of server subprocesses when stopping/before starting.
2037 Removed empty __init.py__ file creation as importer now ensures these files cannot be empty anymore.
2039 * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
2040 (main): Removed empty __init.py__ file creation as importer now ensures these files cannot be empty anymore. Added logging in a file of server subprocesses to clean them in case of abnormal shutdown.
2041 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2042 (WebPlatformTestServer.__init__):
2043 (WebPlatformTestServer._stop_running_subservers): Kill server subprocesses based on file created by wpt launcher.
2044 (WebPlatformTestServer):
2045 (WebPlatformTestServer.stop): Overriden to ensure killing subprocesses in case of orphaned process.
2046 (WebPlatformTestServer._stop_running_server): Killing of wpt launcher process after regular shutdown.
2047 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
2048 (TestWebPlatformTestServer.test_server_closes_previously_spawned_instance): Reworked the test to call start/stop with an existing pid file.
2049 (TestWebPlatformTestServer.test_import_web_platform_test_modules): No change.
2050 (TestWebPlatformTestServer):
2051 (TestWebPlatformTestServer.test_corrupted_subserver_files): Checked that server subprocess cleaning does not throw in case of bad server pid file.
2053 2015-02-20 Timothy Horton <timothy_horton@apple.com>
2055 [WebEditingTester] Allow dropping HTML files on the app
2056 https://bugs.webkit.org/show_bug.cgi?id=141834
2058 Reviewed by Simon Fraser.
2060 * WebEditingTester/AppDelegate.m:
2061 (-[WebEditingAppDelegate openDocument:]):
2062 (-[WebEditingAppDelegate application:openFile:]):
2063 Implement application:openFile:, factoring file loading code out of openDocument.
2065 * WebEditingTester/Info.plist:
2066 Register as an editor for HTML files.
2068 * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
2069 Enrica is not an organization.
2071 2015-02-20 Timothy Horton <timothy_horton@apple.com>
2073 [WebEditingTester] Expand "WK" to "WebKit" in a few places
2074 https://bugs.webkit.org/show_bug.cgi?id=141833
2076 Reviewed by Anders Carlsson.
2078 * WebEditingTester/AppDelegate.h:
2079 * WebEditingTester/AppDelegate.m:
2080 (-[WebEditingAppDelegate newEditor:]):
2081 (-[WebEditingAppDelegate toggleUseWebKit2ByDefault:]):
2082 (-[WebEditingAppDelegate validateMenuItem:]):
2083 (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]):
2084 (-[WebEditingAppDelegate applicationDidFinishLaunching:]): Deleted.
2085 (-[WebEditingAppDelegate applicationWillTerminate:]): Deleted.
2086 (-[WebEditingAppDelegate showOperations:]): Deleted.
2087 * WebEditingTester/MainMenu.xib:
2088 The WK abbreviation is unnaturally grating in menu items for some reason.
2090 2015-02-20 Timothy Horton <timothy_horton@apple.com>
2092 [WebEditingTester] Add a custom protocol for loading canned content
2093 https://bugs.webkit.org/show_bug.cgi?id=141830
2095 Reviewed by Enrica Casucci.
2097 Add a canned:// protocol handler, which can be used to emulate behaviors
2098 in WebKit client apps (like Mail) that use custom protocol handlers,
2099 which can have important effects on editing (mostly, the URLs are only
2100 valid inside of the client application, but not when copied/dragged out).
2102 For now, we only support two canned files:
2104 canned://dice is a PNG of dice (stolen from LayoutTests/)
2105 canned://text is the string "canned text" served as text/html
2107 In the future we could support things like very large (generated) files,
2108 progressive loading, etc. to further simulate conditions in other apps.
2110 * WebEditingTester/AppDelegate.m:
2111 (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
2112 Register the protocol with CFNetwork, and the scheme with WebKit2.
2114 * WebEditingTester/Canned Content/dice.png: Added.
2115 * WebEditingTester/CannedContent.h: Added.
2116 * WebEditingTester/CannedContent.m: Added.
2117 (-[CannedContent initWithRequest:cachedResponse:client:]):
2118 (+[CannedContent canonicalRequestForRequest:]):
2119 (+[CannedContent canInitWithRequest:]):
2120 We only want to handle canned:// URLs.
2122 (-[CannedContent startLoading]):
2123 For now, immediately load the two files we know about.
2124 Otherwise, immediately fail the load.
2126 (-[CannedContent stopLoading]):
2127 * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
2129 2015-02-20 Timothy Horton <timothy_horton@apple.com>
2131 [WebEditingTester] Implement an open panel
2132 https://bugs.webkit.org/show_bug.cgi?id=141829
2134 Reviewed by Simon Fraser.
2136 * WebEditingTester/AppDelegate.m:
2137 (-[WebEditingAppDelegate _useWebKit1ForOpeningDocument:]):
2138 (-[WebEditingAppDelegate _useWebKit2ForOpeningDocument:]):
2139 (-[WebEditingAppDelegate openDocument:]):
2140 Add an open panel (with radio buttons to pick which WebKit to open with).
2141 Loads the file as an HTML string.
2143 2015-02-20 Simon Fraser <simon.fraser@apple.com>
2145 [WebEditingTester] @properties, dot syntax, and remember the window position
2146 https://bugs.webkit.org/show_bug.cgi?id=141843
2148 Reviewed by Tim Horton.
2150 Modernize a bit with more dot syntax, use @property for the web views,
2151 and give the main window an Autosave name so it remembers the widow position.
2153 * WebEditingTester/WK1WebDocumentController.m:
2154 (-[WK1WebDocumentController awakeFromNib]):
2155 (-[WK1WebDocumentController loadHTMLString:]):
2156 * WebEditingTester/WK2WebDocumentController.m:
2157 (-[WK2WebDocumentController awakeFromNib]):
2158 * WebEditingTester/WebDocument.xib:
2160 2015-02-20 Timothy Horton <timothy_horton@apple.com>
2162 [WebEditingTester] Hook up key equivalents for new window action
2163 https://bugs.webkit.org/show_bug.cgi?id=141828
2165 Reviewed by Enrica Casucci.
2167 * WebEditingTester/AppDelegate.h:
2168 * WebEditingTester/AppDelegate.m:
2169 (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
2170 (-[WebEditingAppDelegate newEditor:]):
2171 (-[WebEditingAppDelegate _defaultWebDocumentControllerClass]):
2172 (-[WebEditingAppDelegate toggleUseWK2ByDefault:]):
2173 (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]):
2174 (defaultConfiguration): Deleted.
2175 (-[WebEditingAppDelegate applicationWillTerminate:]): Deleted.
2176 Move WKWebViewConfiguration setup into WK2WebDocumentController.
2177 Remove unused application termination code.
2178 Update new-window menu item key equivalents when launching and when
2179 changing the use-WebKit2-by-default setting.
2180 Make WebDocumentController subclasses all initialized the same way,
2181 and use that to factor out alloc/init.
2182 Rename loadContent to loadHTMLString for future use.
2184 * WebEditingTester/MainMenu.xib:
2185 Add default key equivalents.
2186 Cmd-N will always make the default kind of window (controlled by the pref).
2187 Cmd-Opt-N will always make the other kind.
2188 The menu items are configured as alternates so they only show up if you
2189 press alt (just like in MiniBrowser).
2191 * WebEditingTester/WK1WebDocumentController.m:
2192 (-[WK1WebDocumentController loadHTMLString:]):
2193 (-[WK1WebDocumentController loadContent]): Deleted.
2194 * WebEditingTester/WK2WebDocumentController.h:
2195 * WebEditingTester/WK2WebDocumentController.m:
2196 (defaultConfiguration):
2197 (-[WK2WebDocumentController awakeFromNib]):
2198 (-[WK2WebDocumentController loadHTMLString:]):
2199 (-[WK2WebDocumentController initWithConfiguration:]): Deleted.
2200 (-[WK2WebDocumentController dealloc]): Deleted.
2201 * WebEditingTester/WebDocumentController.h:
2202 * WebEditingTester/WebDocumentController.m:
2203 (-[WebDocumentController init]):
2204 (-[WebDocumentController initWithWindow:]):
2205 (+[WebDocumentController defaultEditingSource]):
2206 (-[WebDocumentController loadHTMLString:]):
2207 (-[WebDocumentController windowDidLoad]): Deleted.
2208 (-[WebDocumentController defaultEditingSource]): Deleted.
2209 (-[WebDocumentController applicationTerminating]): Deleted.
2210 (-[WebDocumentController loadContent]): Deleted.
2212 2015-02-20 Timothy Horton <timothy_horton@apple.com>
2214 [WebEditingTester] ARC-ify WebEditingTester
2215 https://bugs.webkit.org/show_bug.cgi?id=141827
2217 Reviewed by Sam Weinig.
2219 * WebEditingTester/AppDelegate.m:
2220 (-[WebEditingAppDelegate showOperations:]):
2221 * WebEditingTester/EditingOperations.m:
2222 (editingOperations):
2223 * WebEditingTester/WK1WebDocumentController.m:
2224 (-[WK1WebDocumentController dealloc]): Deleted.
2225 * WebEditingTester/WK2WebDocumentController.m:
2226 (-[WK2WebDocumentController dealloc]): Deleted.
2227 * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
2228 Turn on ARC and remove a few retain/release/autorelease calls.
2229 We don't need to implement dealloc in either document controller
2230 because WebView and WKWebView's UIDelegate property does not hold a
2233 2015-02-20 Timothy Horton <timothy_horton@apple.com>
2235 [WebEditingTester] Factor out list of editing operations
2236 https://bugs.webkit.org/show_bug.cgi?id=141826
2238 Reviewed by Sam Weinig.
2240 * WebEditingTester/AppDelegate.m:
2241 (-[WebEditingAppDelegate showOperations:]):
2242 * WebEditingTester/EditingOperations.h: Added.
2243 * WebEditingTester/EditingOperations.m: Added.
2244 (editingOperations):
2245 * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
2246 Move EditingOperations array to its own file, and make it an NSArray
2247 instead of a C array. Adjust accordingly in showOperations:.
2249 2015-02-20 Michael Saboff <msaboff@apple.com>
2251 DFG JIT needs to check for stack overflow at the start of Program and Eval execution
2252 https://bugs.webkit.org/show_bug.cgi?id=141676
2254 Reviewed by Filip Pizlo.
2256 Set the newly added --maximumEvalCacheableSourceLength option for eager test runs. This is needed
2257 to allow the eval out of stack tests to tier up. Without this option, we don't cache the likely
2258 large string expression that we want to eval.
2260 * Scripts/run-jsc-stress-tests:
2262 2015-02-19 Daniel Bates <dabates@apple.com>
2264 REGRESSION (r180239): run-webkit-test fails to boot simulator device that was booted by previous test run
2265 https://bugs.webkit.org/show_bug.cgi?id=141815
2266 <rdar://problem/19893933>
2268 Reviewed by Simon Fraser.
2270 Fixes an issue where run-webkit-tests would fail to boot the WebKit Tester simulator device if it
2271 was booted by iOS Simulator in a previous run of run-webkit-test.
2273 * Scripts/webkitpy/port/ios.py:
2274 (IOSSimulatorPort.check_sys_deps): Added logic moved from IOSSimulatorPort.setup_test_run().
2275 (IOSSimulatorPort.setup_test_run): Moved logic to quit the iOS Simulator app and wait for the
2276 testing device to be in the shutdown state from here to IOSSimulatorPort.check_sys_deps().
2278 2015-02-19 David Kilzer <ddkilzer@apple.com>
2280 check-webkit-style: do not warn about missing primary header for *SoftLink.cpp files
2281 <http://webkit.org/b/141799>
2283 Reviewed by Alex Christensen.
2285 * Scripts/webkitpy/style/checkers/cpp.py:
2286 (_IncludeState.check_next_include_order): Don't emit a warning
2287 if the primary header exists and the source file name ends with
2288 "SoftLink.cpp". Add 'filename' argument to method.
2289 (check_include_line): Pass in 'filename'.
2291 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2292 (OrderOfIncludesTest.test_check_next_include_order__no_config):
2293 (OrderOfIncludesTest.test_check_next_include_order__no_self):
2294 (OrderOfIncludesTest.test_check_next_include_order__likely_then_config):
2295 (OrderOfIncludesTest.test_check_next_include_order__other_then_config):
2296 (OrderOfIncludesTest.test_check_next_include_order__config_then_other_then_likely):
2297 - Add test filename arguments for calls to
2298 check_next_include_order().
2299 (OrderOfIncludesTest.test_primary_header): Add test for a file
2300 name ending in "SoftLink.cpp".
2302 2015-02-18 Enrica Casucci <enrica@apple.com>
2304 Add new tool to test editable Webviews.
2305 https://bugs.webkit.org/show_bug.cgi?id=141772
2307 Reviewed by Tim Horton.
2309 Adding WebEditingTester, a Cocoa application to
2310 test WK1 and Wk2 views in editable mode.
2312 * WebEditingTester: Added.
2313 * WebEditingTester/AppDelegate.h: Added.
2314 * WebEditingTester/AppDelegate.m: Added.
2315 (-[WebEditingAppDelegate init]):
2316 (defaultConfiguration):
2317 (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
2318 (-[WebEditingAppDelegate applicationWillTerminate:]):
2319 (-[WebEditingAppDelegate newEditor:]):
2320 (-[WebEditingAppDelegate showOperations:]):
2321 (-[WebEditingAppDelegate useWebKit2ByDefault]):
2322 (-[WebEditingAppDelegate toggleUseWK2ByDefault:]):
2323 (-[WebEditingAppDelegate validateMenuItem:]):
2324 * WebEditingTester/Info.plist: Added.
2325 * WebEditingTester/MainMenu.xib: Added.
2326 * WebEditingTester/WK1WebDocumentController.h: Added.
2327 * WebEditingTester/WK1WebDocumentController.m: Added.
2328 (-[WK1WebDocumentController awakeFromNib]):
2329 (-[WK1WebDocumentController loadContent]):
2330 (-[WK1WebDocumentController dealloc]):
2331 (-[WK1WebDocumentController pasteAsMarkup:]):
2332 * WebEditingTester/WK2WebDocumentController.h: Added.
2333 * WebEditingTester/WK2WebDocumentController.m: Added.
2334 (-[WK2WebDocumentController initWithConfiguration:]):
2335 (-[WK2WebDocumentController pasteAsMarkup:]):
2336 (-[WK2WebDocumentController awakeFromNib]):
2337 (-[WK2WebDocumentController dealloc]):
2338 (-[WK2WebDocumentController loadContent]):
2339 * WebEditingTester/WebDocument.xib: Added.
2340 * WebEditingTester/WebDocumentController.h: Added.
2341 * WebEditingTester/WebDocumentController.m: Added.
2342 (-[WebDocumentController initWithWindow:]):
2343 (-[WebDocumentController windowDidLoad]):
2344 (-[WebDocumentController defaultEditingSource]):
2345 (-[WebDocumentController applicationTerminating]):
2346 (-[WebDocumentController loadContent]):
2347 * WebEditingTester/WebEditingTester.xcodeproj: Added.
2348 * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj: Added.
2349 * WebEditingTester/main.m: Added.
2352 2015-02-18 Csaba Osztrogonác <ossy@webkit.org>
2354 Run JSC tests on ARM EFL bots
2355 https://bugs.webkit.org/show_bug.cgi?id=141165
2357 Reviewed by Alexey Proskuryakov.
2359 * BuildSlaveSupport/build.webkit.org-config/config.json:
2360 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2361 (RunJavaScriptCoreTests.countFailures):
2362 (RunRemoteJavaScriptCoreTests):
2363 (RunRemoteJavaScriptCoreTests.start):
2364 (BuildAndRemoteJSCTestsFactory):
2365 (BuildAndRemoteJSCTestsFactory.__init__):
2367 2015-02-18 Alexey Proskuryakov <ap@apple.com>
2369 Streamline unexported function build fixes
2370 https://bugs.webkit.org/show_bug.cgi?id=141761
2372 Reviewed by Alex Christensen.
2374 * Scripts/check-for-weak-vtables-and-externals: (readXcode5SymbolsToIgnore): Deleted.
2375 We don't need to ignore symbols that are not exported due to the .unexp file.
2377 2015-02-18 Timothy Horton <timothy_horton@apple.com>
2379 Remove more references to WebCore.exp.in
2380 https://bugs.webkit.org/show_bug.cgi?id=141747
2382 Reviewed by Alexey Proskuryakov.
2384 * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
2387 2015-02-17 Myles C. Maxfield <mmaxfield@apple.com>
2389 Windows test results should not fall back to mac-mountainlion after r180176
2390 https://bugs.webkit.org/show_bug.cgi?id=141719
2392 Reviewed by Brent Fulgham.
2394 * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2395 (_should_file_trigger_build):
2396 * Scripts/webkitpy/port/win.py:
2397 (WinPort.default_baseline_search_path):
2398 * Scripts/webkitpy/port/win_unittest.py:
2399 (WinPortTest.test_baseline_search_path):
2401 2015-02-17 Daniel Bates <dabates@apple.com>
2403 [iOS] run-webkit-tests should check that simctl can boot and shutdown simulator device before running tests
2404 https://bugs.webkit.org/show_bug.cgi?id=141718
2406 Reviewed by Alex Christensen.
2408 We should only run layout tests if simctl can successfully boot and shutdown the testing device.
2410 * Scripts/webkitpy/port/ios.py:
2411 (IOSSimulatorPort.check_sys_deps): Modified to call Simulator.check_simulator_device_and_erase_if_needed().
2412 Log a error and return False if we are unable to boot the simulator device so that the caller can take
2413 appropriate action, say exit(3) before running any layout tests.
2414 * Scripts/webkitpy/xcode/simulator.py:
2415 (Simulator._boot_and_shutdown_simulator_device): Added. Boot and then shut down the simulator device
2416 with the specified UDID.
2417 (Simulator.check_simulator_device_and_erase_if_needed): Added. Checks that simulator device
2418 with the specified UDID can successfully boot and shut down. We make at most two attempts to
2419 boot and shut down the device, erasing the device between tries so as to restore the device
2420 to a known good state.
2422 2015-02-17 Daniel Bates <dabates@apple.com>
2424 run_webkit_tests.py should not know about iOS Simulator details
2425 https://bugs.webkit.org/show_bug.cgi?id=141711
2427 Reviewed by Alex Christensen.
2429 Run_webkit_tests.py should only parse the iOS-specific command
2430 line options --runtime and --device-type. Let the port-specific
2431 logic in ios.py validate the parsed options and instantiate
2432 internal data structures.
2434 Currently run_webkit_tests.py parses the iOS-specific command
2435 line options --runtime and --device-type, validates them, and
2436 instantiates internal data structures from the parsed strings.
2437 Instead the validation logic and instantiation of internal
2438 data structures should be handled by the iOS port object.
2440 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2441 (_set_up_derived_options): Remove logic to validate --runtime and --device-type
2442 and instantiate internal data structures for them.
2443 * Scripts/webkitpy/port/driver.py:
2444 (IOSSimulatorDriver.cmd_line): Modified to reference IOSSimulatorPort.simulator_runtime
2445 and IOSSimulatorPort.simulator_device_type for the iOS Simulator runtime and device type,
2447 * Scripts/webkitpy/port/ios.py: Sort the list of imports.
2448 (IOSSimulatorPort.simulator_runtime): Added. Instantiates a Runtime
2449 object from --runtime, if specified. Otherwise, instantiates a Runtime
2450 object for the latest installed iphonesimulator SDK version.
2451 (IOSSimulatorPort.simulator_device_type): Added. Instantiates a DeviceType
2452 object from --device-type, if specified. Otherwise, instantiates
2453 a DeviceType object for a iPhone 5 or iPhone 5s when on a 32-bit and 64-bit
2454 machine, respectively.
2455 (IOSSimulatorPort.check_sys_deps): Added. Validate if the chosen iOS simulator
2456 runtime is available to use.
2457 (IOSSimulatorPort.testing_device): Modified to make use of properties simulator_device_type
2458 and simulator_runtime for the iOS Simulator device type and runtime, respectively.
2459 * Scripts/webkitpy/xcode/simulator.py:
2460 (Runtime.from_version_string): Added. Turns around and calls Runtime.from_identifier()
2461 with a runtime identifier for the specified iOS version.
2463 2015-02-17 Dana Burkart <dburkart@apple.com>
2465 ASan does not like JSC::MachineThreads::tryCopyOtherThreadStack
2466 https://bugs.webkit.org/show_bug.cgi?id=141672
2468 Reviewed by David Kilzer.
2470 * asan/webkit-asan-ignore.txt:
2472 2015-02-17 Alex Christensen <achristensen@webkit.org>
2474 Remove WebCore.exp.in and clean up.
2475 https://bugs.webkit.org/show_bug.cgi?id=141491
2477 Reviewed by Andreas Kling.
2479 * Scripts/sort-export-file: Removed.
2480 * Scripts/webkitpy/style/checker.py:
2483 (CheckerDispatcher._file_type):
2484 (CheckerDispatcher._create_checker):
2485 Don't check if the export files are sorted.
2486 * Scripts/webkitpy/style/checkers/exportfile.py: Removed.
2487 * Scripts/webkitpy/style/checkers/exportfile_unittest.py: Removed.
2489 2015-02-17 Carlos Garcia Campos <cgarcia@igalia.com>
2491 Unreviewed. Fix GTK+ make distcheck.
2493 Do not exclude bmalloc directory from the tarball.
2495 * gtk/manifest.txt.in:
2497 2015-02-17 Carlos Garcia Campos <cgarcia@igalia.com>
2499 Unreviewed. Fix /webkit2/WebKitDOMNode/dom-cache after r180214.
2501 I forgot to add the return of a bool function.
2503 * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
2504 (WebKitDOMNodeTest::testDOMCache):
2506 2015-02-17 Carlos Garcia Campos <cgarcia@igalia.com>
2508 [GTK] GObject DOM bindings object are cached forever
2509 https://bugs.webkit.org/show_bug.cgi?id=141558
2511 Reviewed by Sergio Villar Senin.
2513 Add checks for all DOM objects to ensure they are not leaked. Also
2514 add a dedicated test for the DOM Object Cache.
2516 * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
2517 (WebKitDOMNodeFilterTest::testTreeWalker):
2518 (WebKitDOMNodeFilterTest::testNodeIterator):
2519 * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
2520 (WebKitDOMNodeTest::testHierarchyNavigation):
2521 (WebKitDOMNodeTest::testInsertion):
2522 (WebKitDOMNodeTest::testTagNames):
2523 (WebKitDOMNodeTest::testDOMCache):
2525 * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:
2526 (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
2527 (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
2528 (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
2529 * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
2530 (testWebKitDOMObjectCache):
2532 * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2533 (documentLoadedCallback):
2535 2015-02-16 Carlos Garcia Campos <cgarcia@igalia.com>
2537 [GTK] WebKitFrame objects are never released
2538 https://bugs.webkit.org/show_bug.cgi?id=141641
2540 Reviewed by Martin Robinson.
2542 Add a way to check GObjects leaks for WebProcess tests and check
2543 WebKitFrame objects are not leaked.
2545 * TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp:
2546 (WebKitFrameTest::testMainFrame):
2547 (WebKitFrameTest::testURI):
2548 (WebKitFrameTest::testJavaScriptContext):
2549 * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
2550 (WebProcessTest::assertObjectIsDeletedWhenTestFinishes):
2552 * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
2554 2015-02-16 Tim Horton <timothy_horton@apple.com>
2556 Fix the MiniBrowser build with newer clang
2558 * MiniBrowser/mac/SettingsController.m:
2559 (-[SettingsController _toggleBooleanDefault:]):
2560 * MiniBrowser/mac/WK1BrowserWindowController.m:
2561 (-[WK1BrowserWindowController windowWillClose:]):
2562 * MiniBrowser/mac/WK2BrowserWindowController.m:
2563 (-[WK2BrowserWindowController windowWillClose:]):
2564 NSApp is id and clang gets confused about which -delegate we're talking about.
2566 2015-02-16 Antti Koivisto <antti@apple.com>
2568 Develop/Disable Caches does not properly disable disk cache
2569 https://bugs.webkit.org/show_bug.cgi?id=141636
2571 Reviewed by Anders Carlsson.
2573 Make testRunner.setCacheModel() use the WKContext interface so the model gets passed to
2574 the network process too.
2576 This makes setCacheModel asynchronous but there don't seem to be any tests that expect otherwise.
2578 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2579 (WTR::InjectedBundle::beginTesting):
2580 (WTR::InjectedBundle::setCacheModel):
2581 * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2582 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2584 Forward to TestController.
2586 (WTR::TestRunner::setCacheModel):
2587 * WebKitTestRunner/TestInvocation.cpp:
2588 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2590 2015-02-16 Andrzej Badowski <a.badowski@samsung.com>
2592 Unreviewed. Add myself as a committer.
2594 * Scripts/webkitpy/common/config/contributors.json:
2596 2015-02-15 David Kilzer <ddkilzer@apple.com>
2598 REGRESSION (r180082): WebCore Debug builds fail on Mavericks due to weak export symbols
2599 <http://webkit.org/b/141607>
2601 * Scripts/check-for-weak-vtables-and-externals: Ignore weak
2602 externals in Source/WebCore/Configurations/WebCore.unexp when
2603 building with Xcode 5.x.
2604 (readXcode5SymbolsToIgnore): Add.
2606 2015-02-15 KwangHyuk Kim <hyuki.kim@samsung.com>
2608 [EFL] fix Evas GL engine error.
2609 https://bugs.webkit.org/show_bug.cgi?id=141621
2611 Reviewed by Gyuyoung Kim.
2613 As new elm engine api was added from efl 1.10, replace elm_config_preferred_engine_set with elm_config_accel_preference_set.
2615 * MiniBrowser/efl/main.c:
2618 2015-02-14 Csaba Osztrogonác <ossy@webkit.org>
2620 [buildbot] Enable run-api-tests on release Mac bots
2621 https://bugs.webkit.org/show_bug.cgi?id=141518
2623 Reviewed by Darin Adler.
2625 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2627 (BuildFactory.__init__):
2628 (TestFactory.__init__):
2629 (BuildAndTestFactory.__init__):
2630 (RunUnitTests.start): Deleted.
2631 (unitTestsSupported): Deleted.
2633 2015-02-13 Anders Carlsson <andersca@apple.com>
2635 Add a move constructor and move assignment operator to Deque
2636 https://bugs.webkit.org/show_bug.cgi?id=141571
2638 Reviewed by Andreas Kling.
2640 * TestWebKitAPI/Tests/WTF/Deque.cpp:
2641 (TestWebKitAPI::TEST):
2643 2015-02-13 Csaba Osztrogonác <ossy@webkit.org>
2645 run-jsc-stress-tests --remote should skip profiler tests
2646 https://bugs.webkit.org/show_bug.cgi?id=141470
2648 Reviewed by Filip Pizlo.
2650 * Scripts/run-jsc-stress-tests:
2652 2015-02-13 Anders Carlsson <andersca@apple.com>
2654 Add an initializer list constructor to Deque
2655 https://bugs.webkit.org/show_bug.cgi?id=141565
2657 Reviewed by Andreas Kling.
2659 * TestWebKitAPI/Tests/WTF/Deque.cpp:
2660 (TestWebKitAPI::TEST):
2662 2015-02-13 Csaba Osztrogonác <ossy@webkit.org>
2664 [buildbot] Remove buildJSCTool cruft from master.cfg
2665 https://bugs.webkit.org/show_bug.cgi?id=141513
2667 Reviewed by Alexey Proskuryakov.
2669 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2670 (RunJavaScriptCoreTests):
2671 (RunJavaScriptCoreTests.start):
2673 (RunWebKitTests.start):
2674 (TestFactory.__init__):
2675 (TestLeaksFactory.__init__):
2676 (RunJavaScriptCoreTests.__init__): Deleted.
2677 (RunWebKitTests.__init__): Deleted.
2679 2015-02-13 Csaba Osztrogonác <ossy@webkit.org>
2681 Unreviewed, remove empty directories.
2683 * DumpRenderTree/gtk: Removed.
2684 * DumpRenderTree/gtk/fonts: Removed.
2685 * DumpRenderTree/unix: Removed.
2686 * DumpRenderTree/unix/TestNetscapePlugin: Removed.
2687 * GtkLauncher: Removed.
2688 * TestWebKitAPI/Tests/WebKitGtk: Removed.
2689 * TestWebKitAPI/Tests/WebKitGtk/resources: Removed.
2690 * WebKitTestRunner/WebKitTestRunnerAppTests: Removed.
2691 * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj: Removed.
2693 2015-02-13 Csaba Osztrogonác <ossy@webkit.org>
2695 Remove Windows cruft from Tools/Scripts/build-webkittestrunner
2696 https://bugs.webkit.org/show_bug.cgi?id=141519
2698 Reviewed by Alexey Proskuryakov.
2700 * Scripts/build-webkittestrunner:
2702 2015-02-12 Alex Christensen <achristensen@webkit.org>
2704 Removed empty directory.
2706 * WinCELauncher: Removed.
2708 2015-02-12 Csaba Osztrogonác <ossy@webkit.org>
2710 run-jsc-stress-tests --remote should be able add the necessary libraries to the bundle on Linux
2711 https://bugs.webkit.org/show_bug.cgi?id=141202
2713 Reviewed by Darin Adler.
2715 * Scripts/run-jsc-stress-tests:
2717 2015-02-12 Brent Fulgham <bfulgham@apple.com>
2719 [Win] Test bot infrastructure should not try to find/use old Safari DLLs
2720 https://bugs.webkit.org/show_bug.cgi?id=141517
2722 Reviewed by Anders Carlsson.
2724 We do not need to locate or use the DLL's that came with Safari, so stop
2725 failing when we cannot find them. Also remove some old Qt cruft from this
2728 * BuildSlaveSupport/built-product-archive:
2729 (archiveBuiltProduct):
2730 (extractBuiltProduct):
2732 2015-02-11 Brent Fulgham <bfulgham@apple.com>
2734 [Win] [64-bit] Work around MSVC2013 Runtime Bug
2735 https://bugs.webkit.org/show_bug.cgi?id=141498
2736 <rdar://problem/19803642>
2738 Reviewed by Anders Carlsson.
2740 Disable FMA3 instruction use in the MSVC math library to
2741 work around a VS2013 runtime crash. We can remove this
2742 workaround when we switch to VS2015.
2744 * DumpRenderTree/cg/ImageDiffCG.cpp: Call _set_FMA3_enable(0) to
2745 disable FMA3 support.
2746 * DumpRenderTree/win/DumpRenderTree.cpp: Ditto.
2747 * DumpRenderTree/win/ImageDiffCairo.cpp: Ditto.
2748 * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
2749 * Scripts/webkitperl/httpd.pm: Ditto.
2750 * TestWebKitAPI/win/main.cpp: Ditto.
2751 * WinLauncher/Common.cpp: Ditto.
2752 * win/DLLLauncher/DLLLauncherMain.cpp: Ditto.
2754 2015-02-12 Csaba Osztrogonác <ossy@webkit.org>
2756 run-jsc-stress-tests should accept remote host config from JSON file
2757 https://bugs.webkit.org/show_bug.cgi?id=141509
2759 Reviewed by Michael Saboff.
2761 * Scripts/run-javascriptcore-tests:
2762 (runJSCStressTests):
2763 * Scripts/run-jsc-stress-tests:
2765 2015-02-12 Carlos Garcia Campos <cgarcia@igalia.com>
2767 [GTK] Add API to allow overriding the default color chooser implementation
2768 https://bugs.webkit.org/show_bug.cgi?id=98935
2770 Reviewed by Gustavo Noronha Silva.
2772 Add a color chooser implementation for MiniBrowser using
2773 GtkPopover when the GTK+ version is recent enough.
2774 And a test case to check the new color chooser API.
2776 * MiniBrowser/gtk/BrowserWindow.c:
2777 (colorChooserRGBAChanged):
2778 (popoverColorClosed):
2779 (colorChooserRequestFinished):
2780 (runColorChooserCallback):
2781 (browserWindowConstructed):
2782 * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
2783 (testWebViewColorChooserRequest):
2786 2015-02-11 Csaba Osztrogonác <ossy@webkit.org>
2788 Make run-jsc-stress-tests --remote work with make-based runner
2789 https://bugs.webkit.org/show_bug.cgi?id=141079
2791 Reviewed by Darin Adler.
2793 * Scripts/run-javascriptcore-tests:
2794 (runJSCStressTests): Pass through the --shell-runner and --make-runner arguments.
2795 * Scripts/run-jsc-stress-tests: Made the make-based runner the default runner,
2796 except for remote testing on Darwin. Unified runShellTestRunner and runMakeTestRunner
2797 to avoid code duplication.
2799 2015-02-11 Csaba Osztrogonác <ossy@webkit.org>
2801 run-jsc-stress tests should detect the number of processors on the remote machine too
2802 https://bugs.webkit.org/show_bug.cgi?id=141196
2804 Reviewed by Darin Adler.
2806 * Scripts/run-javascriptcore-tests:
2807 (runJSCStressTests): Pass through the --child-processes argument.
2808 * Scripts/run-jsc-stress-tests: Added determineNumberOfProcessors function
2809 to detect the number of local and remote processors with the same algorithm.
2810 Additionally introduced $numChildProcesses to emphasize it isn't necessarily
2811 same as $numProcessors.
2813 2015-02-11 Csaba Osztrogonác <ossy@webkit.org>
2815 run-jsc-stress-tests should pass JSC_timeout to remote hosts
2816 https://bugs.webkit.org/show_bug.cgi?id=141164
2818 Reviewed by Darin Adler.
2820 Additonally removed IMPORTANT_ENVS, since JSC_timeout was the only one.
2822 * Scripts/run-jsc-stress-tests:
2824 2015-02-11 Carlos Garcia Campos <cgarcia@igalia.com>
2826 [GTK] Add default color chooser implementation using GtkColorChooserDialog
2827 https://bugs.webkit.org/show_bug.cgi?id=141392
2829 Reviewed by Gustavo Noronha Silva.
2831 Enable INPUT_TYPE_COLOR by default for GTK+ port.
2833 * Scripts/webkitperl/FeatureList.pm:
2835 2015-02-09 Csaba Osztrogonác <ossy@webkit.org>
2837 run-jsc-stress-tests shell test runner should run tests in fixed order
2838 https://bugs.webkit.org/show_bug.cgi?id=141383
2840 Reviewed by Darin Adler.
2842 * Scripts/jsc-stress-test-helpers/shell-runner.sh:
2844 2015-02-08 Chris Fleizach <cfleizach@apple.com>
2846 AX: VoiceOver appears unresponsive when JavaScript alerts are triggered via focus or blur events
2847 https://bugs.webkit.org/show_bug.cgi?id=140485
2849 Reviewed by Anders Carlsson.
2851 Implement takeFocus() as a way to set focus through accessibility wrappers.
2853 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2854 (AccessibilityUIElement::takeFocus):
2855 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2856 (WTR::AccessibilityUIElement::takeFocus):
2858 2015-02-08 Darin Adler <darin@apple.com>
2860 Remove the SVG instance tree
2861 https://bugs.webkit.org/show_bug.cgi?id=140602
2863 Reviewed by Dean Jackson.
2865 * Scripts/check-for-global-initializers: Removed special case for
2866 SVGElementInstance.o.
2868 2015-02-07 David Kilzer <ddkilzer@apple.com>
2870 [iOS] run-webkit-tests fails due to simulator devices from previous SDK installs being marked as unavailable
2871 <http://webkit.org/b/141365>
2873 Reviewed by Daniel Bates.
2875 * Scripts/webkitpy/xcode/simulator.py:
2876 (Simulator): Add unavailable_version_re precompiled regex.
2877 (Simulator._parse_devices): Check for unavailable versions and
2878 ignore them if found when parsing the output of
2879 `xcrun simctl list`.
2880 * Scripts/webkitpy/xcode/simulator_unittest.py:
2881 (test_unavailable_devices): Add test with output from
2882 `xcrun simctl list` with unavailable runtimes that fails before
2885 2015-02-07 Chris Dumez <cdumez@apple.com>
2887 Add Vector::removeFirstMatching() / removeAllMatching() methods taking lambda functions
2888 https://bugs.webkit.org/show_bug.cgi?id=141321
2890 Reviewed by Darin Adler.
2892 Use new Vector::removeFirstMatching() / removeAllMatching() methods.
2894 2015-02-07 David Kilzer <ddkilzer@apple.com>
2896 [iOS] Make Simulator class testable
2897 <http://webkit.org/b/141358>
2899 Rubber-stamped by Darin Adler.
2901 * Scripts/webkitpy/common/system/platforminfo.py:
2902 (PlatformInfo.xcode_simctl_list): Move `xcrun simctl list`
2903 command to here from Simulator.refresh() in xcode/simulator.py
2904 so that the output of the command can be mocked.
2906 * Scripts/webkitpy/common/system/platforminfo_mock.py:
2907 (MockPlatformInfo.__init__): Set self.expected_xcode_simctl_list
2909 (MockPlatformInfo.xcode_simctl_list): Add method that returns
2910 self.expected_xcode_simctl_list expectation.
2912 * Scripts/webkitpy/xcode/simulator.py: Add missing copyright
2914 (Simulator.__init__): Add optional 'host' parameter to make it
2915 possible to pass in a mock object for testing. Set self._host
2916 to 'host' parameter or create Host() object.
2917 (Simulator.refresh): Call new PlatformInfo.xcode_simctl_list()
2920 * Scripts/webkitpy/xcode/simulator_unittest.py: Add unit test
2923 (SimulatorTest.setUp):
2924 (SimulatorTest._set_expected_xcrun_simctl_list):
2925 (SimulatorTest.test_simulator_device_types):
2926 (test_invalid_device_types_header):
2927 (test_invalid_runtimes_header):
2928 (test_invalid_devices_header):
2930 2015-02-07 Csaba Osztrogonác <ossy@webkit.org>
2932 run-jsc-stress-tests --remote should use the default ssh port
2933 https://bugs.webkit.org/show_bug.cgi?id=141287
2935 Reviewed by Darin Adler.
2937 * Scripts/run-jsc-stress-tests: Extended URI module to be able to handle ssh scheme with the default 22 port number.
2939 2015-02-06 Dana Burkart <dburkart@apple.com>
2941 dashboard: BuildbotTesterQueueView crashesOnly logic is wrong
2942 https://bugs.webkit.org/show_bug.cgi?id=141349
2944 Reviewed by Alexey Proskuryakov.
2946 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2947 (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2948 (BuildbotTesterQueueView.prototype.update):
2950 2015-02-06 Alexey Proskuryakov <ap@apple.com>
2952 Report network process crashes during layout tests
2953 https://bugs.webkit.org/show_bug.cgi?id=139646
2955 Reviewed by Anders Carlsson.
2957 * WebKitTestRunner/TestController.cpp:
2958 (WTR::TestController::initialize):
2959 (WTR::TestController::networkProcessName):
2960 (WTR::TestController::networkProcessDidCrash):
2961 * WebKitTestRunner/TestController.h:
2963 2015-02-06 Csaba Osztrogonác <ossy@webkit.org>
2965 run-jsc-stress-tests --remote should create remote directory before copying the bundle
2966 https://bugs.webkit.org/show_bug.cgi?id=141329
2968 Reviewed by Michael Saboff.
2970 * Scripts/run-jsc-stress-tests:
2972 2015-02-06 Carlos Garcia Campos <cgarcia@igalia.com>
2974 [GTK] Remove WebKitWebView::close-notification signal
2975 https://bugs.webkit.org/show_bug.cgi?id=141330
2977 Reviewed by Gustavo Noronha Silva.
2979 Update notifications unit tests according to the API changes, and
2980 add a test case to check that onclose event is fired when a
2981 notification is closed by the user.
2983 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2984 (testWebViewNotification):
2986 2015-02-05 Alexey Proskuryakov <ap@apple.com>
2988 Dashboard doesn't consider building ASan a productive step
2989 https://bugs.webkit.org/show_bug.cgi?id=141312
2991 Reviewed by Simon Fraser.
2993 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2995 2015-02-05 Daniel Bates <dabates@apple.com>
2997 [iOS] webkitpy.xcode.simulator.Runtime.from_identifier() returns wrong result for non-existent runtime
2998 https://bugs.webkit.org/show_bug.cgi?id=141306
3000 Reviewed by Alexey Proskuryakov.
3002 The function webkitpy.xcode.simulator.Runtime.from_identifier always returns a Runtime object
3003 corresponding to the last-most runtime parsed from the output of `simctl list` for any non-
3006 * Scripts/webkitpy/xcode/simulator.py:
3007 (Runtime.from_identifier):
3009 2015-02-05 Daniel Bates <dabates@apple.com>
3011 LayoutTestRelay does not install DumpRenderTree.app/WebKitTestRunnerApp.app
3012 https://bugs.webkit.org/show_bug.cgi?id=139746
3013 <rdar://problem/19283658>
3015 Reviewed by Alexey Proskuryakov.
3017 Fixes an issues where LayoutTestRelay may fail to install DumpRenderTree.app/WebKitTestRunnerApp.app
3018 if the simulator device is not in state Booted.
3020 Currently run-webkit-test --ios-sim executes LayoutTestRelay immediately after
3021 launching/relaunching the iOS Simulator app and a simulator app can only be installed
3022 on a device that is in the Booted state. LayoutTestRelay may run before the
3023 device is booted and hence fail to install DumpRenderTree.app/WebKitTestRunnerApp.app.
3024 We should defer executing LayoutTestRelay until the simulator device booted by
3025 iOS Simulator is in the Booted state.
3027 * Scripts/webkitpy/port/ios.py: Import webkitpy.xcode.simulator.Simulator to avoid prefixing
3028 Simulator methods with the module name, simulator.
3029 (IOSSimulatorPort.setup_test_run): Wait for the simulator device to be in the Booted state
3030 after launching iOS Simulator. Also, wait until the simulator device is in the Shutdown state
3031 before launching iOS Simulator to boot it.
3032 (IOSSimulatorPort.testing_device): Fix up caller since we now import webkitpy.xcode.simulator.Simulator.
3033 (IOSSimulatorPort.simulator_path): Deleted; moved this function to class Simulator and renamed to device_directory().
3034 * Scripts/webkitpy/xcode/simulator.py:
3035 (Device.__init__): Remove parameter state and an instance variable of the same name, which represented
3036 the state of the device when we created this object as part of parsing the output of `simctl list`. Callers
3037 interested in the state of the device are more likely interested in the current state of the device as
3038 opposed to the state of the device when the Device object was created.
3039 (Device.state): Added; turn around and call Simulator.device_state() for the current state of the device.
3040 (Device.path): Extracted implementation into Simulator.device_directory() so that it can be called
3041 from both this function and Simulator.device_state().
3042 (Device.create): Use Simulator.wait_until_device_is_in_state() to simplify the implementation of this function.
3043 (Simulator.DeviceState): Added; class of constants.
3044 (Simulator.wait_until_device_is_in_state): Added; this function does not return until the specified
3045 device is in the specified state.
3046 (Simulator.device_state): Added; parses the state of the device from the appropriate CoreSimulator device.plist file.
3047 (Simulator.device_directory): Added.
3048 (Simulator._parse_devices): Do not pass argument state to Device constructor as it no longer accepts it.
3050 2015-02-05 Alexey Proskuryakov <ap@apple.com>
3052 Disable retries on Mac debug testers
3053 https://bugs.webkit.org/show_bug.cgi?id=141296
3055 Reviewed by Simon Fraser.
3057 * BuildSlaveSupport/build.webkit.org-config/config.json:
3059 2015-02-05 Dan Bernstein <mitz@apple.com>
3061 Need a way to force $xcodeSDK in webkitdirs.pm
3062 https://bugs.webkit.org/show_bug.cgi?id=141291
3064 Reviewed by Anders Carlsson.
3066 * Scripts/webkitdirs.pm:
3067 (setXcodeSDK): Added.
3069 2015-02-05 Youenn Fablet <youenn.fablet@crf.canon.fr> and Xabier Rodriguez Calvar <calvaris@igalia.com>
3071 [Streams API] Implement a barebone ReadableStream interface
3072 https://bugs.webkit.org/show_bug.cgi?id=141045
3074 Reviewed by Benjamin Poulain.
3076 * Scripts/webkitperl/FeatureList.pm: Added streams-api compilation switch.
3078 2015-02-04 Joseph Pecoraro <pecoraro@apple.com>
3080 filter-build-webkit: reduce more unfiltered output
3081 https://bugs.webkit.org/show_bug.cgi?id=141282
3083 Reviewed by Daniel Bates.
3085 * Scripts/filter-build-webkit:
3086 Report CompileDTraceScript and Preprocess lines as successful.
3088 2015-02-04 Dana Burkart <dburkart@apple.com>
3090 Botwatcher's Dashboard is cramped
3091 https://bugs.webkit.org/show_bug.cgi?id=140273
3093 Reviewed by Alexey Proskuryakov.
3095 Add a heading key which will allow for arbitrary headings in builder queues.
3097 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
3098 (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
3099 (BuildbotBuilderQueueView.prototype.update):
3100 (BuildbotBuilderQueueView.prototype.update.appendBuildArchitecture): Deleted.
3101 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3102 (BuildbotIteration.prototype._parseData):
3103 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
3104 (BuildbotLeaksQueueView.prototype.update):
3105 (BuildbotLeaksQueueView.prototype.update.appendBuild): Deleted.
3106 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js:
3107 (BuildbotPerformanceQueueView.prototype.update):
3108 (BuildbotPerformanceQueueView.prototype.update.appendBuild): Deleted.
3109 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3111 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3112 (BuildbotQueueView.prototype._unauthorizedAccess):
3113 (BuildbotQueueView.prototype._appendBuild):
3114 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
3115 (BuildbotTestResults):
3116 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3117 (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
3118 (BuildbotTesterQueueView.prototype.update):
3119 (BuildbotTesterQueueView.prototype.update.appendBuild): Deleted.
3121 2015-02-04 Simon Fraser <simon.fraser@apple.com>
3123 WKTR should not use -mainScreen to pick a color profile
3124 https://bugs.webkit.org/show_bug.cgi?id=141265
3126 Reviewed by Tim Horton.
3128 -[NSScreen mainScreen] depends on the active window, so use the first screen
3129 (which is the one we put the window on anyway).
3131 Do some cleanup in DRT that makes the code look similar.
3133 * DumpRenderTree/mac/DumpRenderTree.mm:
3134 (createWebViewAndOffscreenWindow):
3135 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3136 (WTR::PlatformWebView::PlatformWebView):
3138 2015-02-04 Simon Fraser <simon.fraser@apple.com>
3140 LayoutTestHelper should set the color profile of all displays
3141 https://bugs.webkit.org/show_bug.cgi?id=141260
3143 Reviewed by Tim Horton.
3145 WebKitTestRunner can (erroneously) grab the colorspace of the "main" screen.
3146 which is the screen with the active window. Make things more robust by changing
3147 the colorspace of all displays, not just the main screen, when running layout tests.
3149 * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig: Enable ARC
3150 * DumpRenderTree/mac/LayoutTestHelper.m:
3151 (originalColorProfileURLs):
3152 (colorProfileURLForDisplay):
3153 (displayUUIDStrings):
3154 (saveDisplayColorProfiles):
3155 (setDisplayColorProfile):
3156 (restoreDisplayColorProfiles):
3157 (installLayoutTestColorProfile):
3158 (restoreUserColorProfile):
3160 Store display color profiles by map of UUID strings to URLs (NSUUID and CFUUID are not
3161 toll-free bridged, sadly). Use the map to restore all profiles on exit.
3162 Convert to use more Obj-C types.
3164 2015-02-04 Daniel Bates <dabates@apple.com>
3166 test-webkitpy fails on Mac without iphoneos SDK
3167 https://bugs.webkit.org/show_bug.cgi?id=141255
3168 <rdar://problem/19619691>
3170 I inadvertently committed the wrong exception message. Fix up the exception message
3171 to instruct a person to install the iOS SDK when it cannot be found.
3173 * Scripts/webkitpy/port/ios.py:
3174 (IOSPort.determine_full_port_name):
3176 2015-02-04 Youenn Fablet <youenn.fablet@crf.canon.fr>
3178 W3C test importer should sort the list of files when generating the w3c-import.log
3179 https://bugs.webkit.org/show_bug.cgi?id=141156
3181 Reviewed by Bem Jones-Bey.
3183 Sort explicitly the list of imported files written in the w3c-import.log.
3184 Removed logging of the import date.
3186 * Scripts/webkitpy/w3c/test_importer.py:
3187 (TestImporter.write_import_log):
3189 2015-02-04 Daniel Bates <dabates@apple.com>
3191 test-webkitpy fails on Mac without iphoneos SDK
3192 https://bugs.webkit.org/show_bug.cgi?id=141255
3193 <rdar://problem/19619691>
3195 Reviewed by David Kilzer and Alexey Proskuryakov.
3197 Fixes an issue where test-webkitpy fails on a Mac without the iOS SDK. We should
3198 should not require the iphoneos SDK to be installed to run the webkitpy tests.
3200 * Scripts/webkitpy/common/system/platforminfo.py:
3201 (PlatformInfo.xcode_sdk_version): Added; return the version of the specified SDK, if
3202 installed. We take advantage of the behavior that xcrun --show-sdk-version only writes
3203 to standard output if the SDK is installed to return the empty string if the SDK is
3205 * Scripts/webkitpy/common/system/platforminfo_mock.py:
3206 (MockPlatformInfo.xcode_sdk_version): Added.
3207 * Scripts/webkitpy/port/ios.py:
3208 (IOSPort.determine_full_port_name): Modified to call PlatformInfo.xcode_sdk_version()
3209 to get the version of the iphoneos SDK, if installed.
3211 2015-02-04 Alexey Proskuryakov <ap@apple.com>
3213 run-webkit-tests doesn't always capture ASan violation reports
3214 https://bugs.webkit.org/show_bug.cgi?id=141231
3216 Reviewed by Darin Adler.
3218 * Scripts/webkitpy/port/driver.py:
3219 (Driver.run_test): Don't look for CrashReporter crash logs if a log was provided
3220 by the driver already (as is the case with ASan violations, which are printed to
3222 (Driver._check_for_address_sanitizer_violation): Check if the line is a start of ASan
3224 (Driver._read_block): Give ASan enough time to symbolicate a crash, and put it into
3225 a separate variable for reporting.
3227 2015-02-03 Ryosuke Niwa <rniwa@webkit.org>
3229 [webkitpy] Add platform specific Skipped file mechanism for performance tests
3230 https://bugs.webkit.org/show_bug.cgi?id=141152
3232 Reviewed by Csaba Osztrogonác.
3234 Support a test-expectation-like syntax in performance tests' skipped files.
3235 e.g. [Mac] Parsed/BadTest.html will skip Parsed/BadTest.html on Mac ports.
3237 * Scripts/webkitpy/port/base.py:
3238 (Port.skipped_perf_tests): Implemented the syntax support by a regular expression.
3240 * Scripts/webkitpy/port/base_unittest.py:
3241 (PortTest.test_skipped_perf_tests): Test the new syntax.
3243 2015-02-04 Alexey Proskuryakov <ap@apple.com>
3245 When tests fail on leaks bot so much that there are no leaks detected, dashboard erroneously shows green
3246 https://bugs.webkit.org/show_bug.cgi?id=141236
3248 Reviewed by Sam Weinig.
3250 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
3251 (BuildbotLeaksQueueView.prototype.update.appendLeaksQueueStatus):
3253 2015-02-04 Chris Dumez <cdumez@apple.com>
3255 Add removeFirst(value) / removeAll(value) methods to WTF::Vector
3256 https://bugs.webkit.org/show_bug.cgi?id=141192
3258 Reviewed by Benjamin Poulain.
3260 Add API tests for Vector::removeFirst(value) and
3261 Vector::removeAll(value).
3263 * TestWebKitAPI/Tests/WTF/Vector.cpp:
3264 (TestWebKitAPI::TEST):
3266 2015-02-03 Tim Horton <timothy_horton@apple.com>
3268 Add WKPageNavigationClient as C SPI around API::NavigationClient, and adopt in WKTR
3269 https://bugs.webkit.org/show_bug.cgi?id=141217
3271 Reviewed by Sam Weinig.
3273 * WebKitTestRunner/TestController.cpp:
3274 (WTR::copyWebCryptoMasterKey):
3275 (WTR::TestController::createOtherPage):
3276 (WTR::TestController::createWebViewWithOptions):
3277 (WTR::TestController::ensureViewSupportsOptions):
3278 (WTR::TestController::didCommitNavigation):
3279 (WTR::TestController::didFinishNavigation):
3280 (WTR::TestController::canAuthenticateAgainstProtectionSpace):
3281 (WTR::TestController::didReceiveAuthenticationChallenge):
3282 (WTR::TestController::decidePolicyForPluginLoad):
3283 (WTR::TestController::decidePolicyForNavigationAction):
3284 (WTR::TestController::decidePolicyForNavigationResponse):
3285 (WTR::TestController::didCommitLoadForFrame): Deleted.
3286 (WTR::TestController::didFinishLoadForFrame): Deleted.
3287 * WebKitTestRunner/TestController.h:
3288 Adopt WKPageNavigationClient and adjust to its semantics (navigations are main-frame-only, etc.)
3290 2015-02-03 Dhi Aurrahman <diorahman@rockybars.com>
3292 Unreviewed. Add myself as a committer.
3294 * Scripts/webkitpy/common/config/contributors.json:
3296 2015-02-03 Brent Fulgham <bfulgham@apple.com>
3298 [Win] Unreviewed test fix.
3300 * DumpRenderTree/win/PolicyDelegate.cpp:
3301 (PolicyDelegate::unableToImplementPolicyWithError): The message was missing a linefeed,
3302 so was not matching expected output.
3304 2015-02-03 Youenn Fablet <youenn.fablet@crf.canon.fr>
3306 Unreviewed. Moving myself to the committer section at last.
3308 * Scripts/webkitpy/common/config/contributors.json:
3310 2015-02-03 Brent Fulgham <bfulgham@apple.com>
3312 [Win] Tests fail because DRT reports '(null)' instead of an empty string
3313 https://bugs.webkit.org/show_bug.cgi?id=141205
3315 Reviewed by Anders Carlsson.
3317 * DumpRenderTree/win/HistoryDelegate.cpp:
3318 (HistoryDelegate::didNavigateWithNavigationData): Deal with empty BSTR values
3319 properly so that we match expected DumpRenderTree output.
3321 2015-02-03 Michael Catanzaro <mcatanzaro@igalia.com>
3323 [GTK] TestWebKitAccessibility is not skipped
3324 https://bugs.webkit.org/show_bug.cgi?id=141179
3326 Reviewed by Carlos Garcia Campos.
3328 Don't attempt to skip TestWebKitAccessibility. This path is wrong so it was not being
3329 skipped, and it apparently works reliably on the bots.
3331 * Scripts/run-gtk-tests:
3334 2015-02-03 Carlos Alberto Lopez Perez <clopez@igalia.com>
3336 run-perf-tests: allow to specify a wrapper command.
3337 https://bugs.webkit.org/show_bug.cgi?id=141172
3339 Reviewed by Ryosuke Niwa.
3341 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3342 (parse_args): Update text to indicate is also valid for WTR.
3343 * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3344 (PerfTestsRunner._parse_args): Add wrapper command.
3346 2015-02-03 Brent Fulgham <bfulgham@apple.com>
3348 [Win] Correct version parsing warning in update-webkit
3349 https://bugs.webkit.org/show_bug.cgi?id=141200
3351 Reviewed by Anders Carlsson.
3353 * Scripts/webkitdirs.pm:
3354 (setupAppleWinEnv): Strip out any specific version build level
3355 from the Cygwin version information.
3358 2015-02-03 Brent Fulgham <bfulgham@apple.com>
3360 [Win] Attempt to improve the reliability of HTTP service
3361 https://bugs.webkit.org/show_bug.cgi?id=141191
3363 Reviewed by Darin Adler.
3365 * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
3366 (LayoutTestApacheHttpd.__init__): Use default XAMPP pidfile location.
3367 (LayoutTestApacheHttpd._stop_running_server): Delete the abandoned PID file
3368 when stopping the service doesn't do so on its own (for Windows runs).
3370 2015-02-03 Youenn Fablet <youenn.fablet@crf.canon.fr>
3372 Web platform test server should not need to create __init__.py files
3373 https://bugs.webkit.org/show_bug.cgi?id=141030
3375 Reviewed by Ryosuke Niwa.
3377 W3C TestImporter ensures that copied __init__.py files are not empty.
3378 If needed, a comment is inserted in __init__.py files.
3379 Added a unit test to check that web-platform-tests tools and scripts python modules can be imported.
3381 * Scripts/webkitpy/common/system/filesystem.py:
3382 (FileSystem.getsize):
3383 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
3384 (TestWebPlatformTestServer.test_start_cmd):
3385 (TestWebPlatformTestServer):
3386 (TestWebPlatformTestServer.test_import_web_platform_test_modules):
3387 * Scripts/webkitpy/w3c/test_importer.py:
3388 (TestImporter.import_tests):
3390 2015-01-26 Youenn Fablet <youenn.fablet@crf.canon.fr>
3392 Unreviewed. Moving myself to the committer section.
3394 * Scripts/webkitpy/common/config/contributors.json:
3396 2015-02-02 Saam Barati <saambarati1@gmail.com>
3398 Create tests for JSC's Control Flow Profiler
3399 https://bugs.webkit.org/show_bug.cgi?id=141123
3401 Reviewed by Filip Pizlo.
3403 * Scripts/run-javascriptcore-tests:
3404 (runJSCStressTests):
3405 * Scripts/run-jsc-stress-tests:
3407 2015-02-02 Csaba Osztrogonác <ossy@webkit.org>
3409 Remove copy/paste code from run-jsc-stress-tests to determine numberOfTests
3410 https://bugs.webkit.org/show_bug.cgi?id=141158
3412 Reviewed by Darin Adler.
3414 * Scripts/run-jsc-stress-tests:
3416 2015-02-02 Michael Catanzaro <mcatanzaro@igalia.com>
3418 [GTK] MiniBrowser should close itself on Ctrl+W or Ctrl+Q
3419 https://bugs.webkit.org/show_bug.cgi?id=141142
3421 Reviewed by Carlos Garcia Campos.
3423 * MiniBrowser/gtk/BrowserWindow.c:
3424 (browser_window_init): Quit on Ctrl+W or Ctrl+Q
3426 2015-02-01 Youenn Fablet <youenn.fablet@crf.canon.fr>
3428 Web platform test server is not always launching properly on Mac EWS bots
3429 https://bugs.webkit.org/show_bug.cgi?id=141141
3433 * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
3434 (create_wpt_empty_file_if_needed): Removed creation of empty __init.py__ files from AutoInstalled modules.
3436 2015-01-31 Sam Weinig <sam@webkit.org>
3438 Remove even more Mountain Lion support
3439 https://bugs.webkit.org/show_bug.cgi?id=141124
3441 Reviewed by Alexey Proskuryakov.
3443 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3444 (AccessibilityUIElement::attributedStringRangeIsMisspelled):
3445 * DumpRenderTree/mac/Configurations/Base.xcconfig:
3446 * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3447 * DumpRenderTree/mac/DumpRenderTree.mm:
3448 (activateTestingFonts):
3449 (prepareConsistentTestingEnvironment):
3450 * DumpRenderTree/mac/EventSendingController.mm:
3451 (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
3452 (-[EventSendingController contextClick]):
3453 * DumpRenderTree/mac/TextInputController.m:
3454 * LayoutTestRelay/Configurations/Base.xcconfig:
3455 * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
3456 * MiniBrowser/Configurations/Base.xcconfig:
3457 * MiniBrowser/Configurations/DebugRelease.xcconfig:
3458 * MiniBrowser/mac/WK2BrowserWindowController.m:
3459 (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3460 (-[WK2BrowserWindowController webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
3461 (-[WK2BrowserWindowController webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
3462 * TestWebKitAPI/Configurations/Base.xcconfig:
3463 * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3464 * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3465 (-[DownloadDelegate _downloadDidFinish:]):
3466 * TestWebKitAPI/Tests/mac/StringTruncator.mm:
3467 (TestWebKitAPI::TEST):
3468 * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
3469 (TestWebKitAPI::InjectedBundleController::platformInitialize):
3470 * WebKitLauncher/Configurations/Base.xcconfig:
3471 * WebKitTestRunner/Configurations/Base.xcconfig:
3472 * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3473 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3474 (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
3475 * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3476 (WTR::activateFonts):
3477 * WebKitTestRunner/TestController.cpp:
3478 (WTR::TestController::initialize):
3479 (WTR::TestController::webProcessName):
3480 * WebKitTestRunner/mac/EventSenderProxy.mm:
3481 * asan/asan.xcconfig:
3483 2015-01-31 Commit Queue <commit-queue@webkit.org>
3485 Unreviewed, rolling out r179408.
3486 https://bugs.webkit.org/show_bug.cgi?id=141117
3488 This didn't fully fix the issue (Requested by anttik on
3493 "OSObjectPtr does not work with dispatch_data_t on Maverics"
3494 https://bugs.webkit.org/show_bug.cgi?id=141081
3495 http://trac.webkit.org/changeset/179408
3497 2015-01-31 Youenn Fablet <youenn.fablet@crf.canon.fr>
3499 https://trac.webkit.org/changeset/179439 breaks a python test
3500 https://bugs.webkit.org/show_bug.cgi?id=141114
3504 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3505 (WebPlatformTestServer._install_modules): Checks whether WPTModules file exists before reading it as no such file exists in mock tests.
3507 2015-01-31 Youenn Fablet <youenn.fablet@crf.canon.fr>
3509 Import W3C web platform tests infrastructure
3510 https://bugs.webkit.org/show_bug.cgi?id=140934
3512 Reviewed by Ryosuke Niwa.
3514 Loading necessary web platform tests modules before launching server.
3515 Ensuring that some empty __init__.py files are present and create them if necessary.
3517 * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
3518 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3520 2015-01-30 Brent Fulgham <bfulgham@apple.com>
3522 [Win] Another unreviewed test fix.
3524 Correct copy/paste error in buildbot handling.
3526 * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
3527 (LayoutTestApacheHttpd.__init__):
3528 (LayoutTestApacheHttpd._get_apache_config_file_path):
3530 2015-01-30 Brent Fulgham <bfulgham@apple.com>
3532 [Win] Unreviewed test fix.
3534 Correct path handling based on failures on test bots to get things running again.
3536 * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
3537 (LayoutTestApacheHttpd.__init__):
3538 (LayoutTestApacheHttpd._get_apache_config_file_path):
3540 2015-01-30 Chris Dumez <cdumez@apple.com>
3542 Unreviewed. Fix Windows build after r179409.
3544 * DumpRenderTree/win/TestRunnerWin.cpp:
3545 (TestRunner::notifyDone):
3546 (TestRunner::queueLoad):
3548 2015-01-30 Chris Dumez <cdumez@apple.com>
3550 Rename shared() static member functions to singleton() for singleton classes.
3551 https://bugs.webkit.org/show_bug.cgi?id=141088
3553 Reviewed by Ryosuke Niwa and Benjamin Poulain.
3555 Rename shared() static member functions to singleton() for singleton
3556 classes as per the recent coding style change.
3558 2015-01-30 Antti Koivisto <antti@apple.com>
3560 OSObjectPtr does not work with dispatch_data_t on Maverics
3561 https://bugs.webkit.org/show_bug.cgi?id=141081
3563 Reviewed by Pratik Solanki.
3565 * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp:
3566 (TestWebKitAPI::TEST):
3568 2015-01-30 Brent Fulgham <bfulgham@apple.com>
3570 [Win] Switch to Apache on Windows
3571 https://bugs.webkit.org/show_bug.cgi?id=141060
3573 Reviewed by Alexey Proskuryakov.
3575 Update our scripts under Windows (and Cygwin) to locate and use
3576 the XAMPP installation of Apache for running tests.
3578 * Scripts/run-webkit-httpd:
3579 * Scripts/webkitperl/httpd.pm:
3581 (getDefaultConfigForTestDirectory):
3582 (getHTTPDConfigPathForTestDirectory):
3583 * Scripts/webkitpy/common/system/executive_unittest.py:
3584 (ExecutiveTest.serial_test_kill_process):
3585 * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
3586 (LayoutTestApacheHttpd.__init__):
3587 (LayoutTestApacheHttpd._get_apache_config_file_path):
3588 (LayoutTestApacheHttpd._stop_running_server):
3589 * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
3590 (HttpServerBase._is_server_running_on_all_ports):
3591 * Scripts/webkitpy/port/base.py:
3592 (Port._apache_config_file_name_for_platform):
3593 * Scripts/webkitpy/port/port_testcase.py:
3594 (test_apache_config_file_name_for_platform):
3595 * Scripts/webkitpy/port/win.py:
3596 (WinPort.show_results_html_file):
3597 (WinPort._uses_apache):
3599 (WinPort._path_to_apache):
3601 2015-01-29 Alexey Proskuryakov <ap@apple.com>
3603 Built result takes too long to be compressed on bots
3604 https://bugs.webkit.org/show_bug.cgi?id=141056
3606 Reviewed by Daniel Bates.
3608 Reduces compression time from ~3.5 min to ~1.5 min. Archive size gets 2% bigger.
3610 * BuildSlaveSupport/test-result-archive: (archiveTestResults):
3612 2015-01-29 Sam Weinig <sam@webkit.org>
3614 Remove support for screen font substitution
3615 https://bugs.webkit.org/show_bug.cgi?id=141038
3617 Reviewed by Tim Horton.
3619 * DumpRenderTree/win/DumpRenderTree.cpp:
3620 (resetWebPreferencesToConsistentValues):
3621 Remove call to now setScreenFontSubstitutionEnabled() which is a no-op.
3623 2015-01-29 Csaba Osztrogonác <ossy@webkit.org>
3625 Make run-jsc-stress-tests --remote work on Linux too
3626 https://bugs.webkit.org/show_bug.cgi?id=141000
3628 Reviewed by Darin Adler.
3630 * Scripts/jsc-stress-test-helpers/shell-runner.sh: Omit error message of sysctl,
3631 use bash/dash compatible signal names, use Linux/Mac compatible find options,
3632 use bash/dash compatible functions.
3633 * Scripts/run-jsc-stress-tests: Use Linux/Mac compatible find options.
3635 2015-01-29 Csaba Osztrogonác <ossy@webkit.org>
3637 [buildbot] Simplify jscore-test buildstep
3638 https://bugs.webkit.org/show_bug.cgi?id=140821
3640 Reviewed by Alexey Proskuryakov.
3642 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3643 (RunJavaScriptCoreTests): Inherited from TestWithFailureCount and removed useless actual.html logfile.
3644 (RunJavaScriptCoreTests.countFailures): Added.
3645 (RunJavaScriptCoreTests.commandComplete): Deleted.
3646 (RunJavaScriptCoreTests.evaluateCommand): Deleted.
3647 (RunJavaScriptCoreTests.getText): Deleted.
3648 (RunJavaScriptCoreTests.getText2): Deleted.
3649 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Updated.
3650 (RunJavaScriptCoreTestsTest.test_mozilla_failure_old_output):
3651 (RunJavaScriptCoreTestsTest.test_mozilla_failures_old_output):
3652 (RunJavaScriptCoreTestsTest.test_jsc_stress_failure_new_output):
3653 (RunJavaScriptCoreTestsTest.test_jsc_stress_failures_new_output):
3655 2015-01-29 Csaba Osztrogonác <ossy@webkit.org>
3657 Unreviewed, revert r179337, we don't need this dependency.
3659 * efl/install-dependencies:
3660 * gtk/install-dependencies:
3662 2015-01-28 Shivakumar JM <shiva.jm@samsung.com>