Tools/ChangeLog

   1 2017-02-20  Carlos Garcia Campos  <cgarcia@igalia.com>
   2
   3         Remove ENABLE_THREADED_COMPOSITOR build option
   4         https://bugs.webkit.org/show_bug.cgi?id=168606
   5
   6         Reviewed by Michael Catanzaro.
   7
   8         * Scripts/webkitperl/FeatureList.pm:
   9
  10 2017-02-20  Youenn Fablet  <youenn@apple.com>
  11
  12         [WebRTC][Mac] Activate libwebrtc
  13         https://bugs.webkit.org/show_bug.cgi?id=167293
  14         <rdar://problem/30401864>
  15
  16         Reviewed by Alex Christensen.
  17
  18         Fixing paths to allow loading libwebrtc.dylib successfully.
  19
  20         * Scripts/build-webkit:
  21         * Scripts/webkitdirs.pm:
  22         (setupMacWebKitEnvironment):
  23         (setupIOSWebKitEnvironment):
  24
  25 2017-02-20  Ryan Haddad  <ryanhaddad@apple.com>
  26
  27         Unreviewed, rolling out r212685.
  28
  29         This change broke the 32-bit Sierra build.
  30
  31         Reverted changeset:
  32
  33         "Resource Load Statistics: Add alternate classification
  34         method"
  35         https://bugs.webkit.org/show_bug.cgi?id=168347
  36         http://trac.webkit.org/changeset/212685
  37
  38 2017-02-20  John Wilander  <wilander@apple.com>
  39
  40         Resource Load Statistics: Add alternate classification method
  41         https://bugs.webkit.org/show_bug.cgi?id=168347
  42         <rdar://problem/30352793>
  43
  44         Reviewed by Alex Christensen.
  45
  46         Added three testRunner functions to facilitate layout tests:
  47         - setStatisticsSubframeUnderTopFrameOrigin()
  48         - setStatisticsSubresourceUnderTopFrameOrigin()
  49         - setStatisticsSubresourceUniqueRedirectTo()
  50
  51         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  52         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
  53         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
  54         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
  55         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
  56         * WebKitTestRunner/InjectedBundle/TestRunner.h:
  57         * WebKitTestRunner/TestController.cpp:
  58         (WTR::TestController::setStatisticsSubframeUnderTopFrameOrigin):
  59         (WTR::TestController::setStatisticsSubresourceUnderTopFrameOrigin):
  60         (WTR::TestController::setStatisticsSubresourceUniqueRedirectTo):
  61         * WebKitTestRunner/TestController.h:
  62         * WebKitTestRunner/TestInvocation.cpp:
  63         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
  64
  65 2017-02-20  Anders Carlsson  <andersca@apple.com>
  66
  67         Use the new drag code path when dragging links
  68         https://bugs.webkit.org/show_bug.cgi?id=168612
  69
  70         Reviewed by Tim Horton.
  71
  72         If a type is not dynamic, just use the static UTI.
  73
  74         * DumpRenderTree/mac/DumpRenderTreePasteboard.mm:
  75         (-[LocalPasteboard writeObjects:]):
  76
  77 2017-02-17  Anders Carlsson  <andersca@apple.com>
  78
  79         Add a new drag code path and use it for dragging plain text
  80         https://bugs.webkit.org/show_bug.cgi?id=168534
  81
  82         Reviewed by Geoffrey Garen.
  83
  84         Update the testing infrastructure to handle NSDraggingSession.
  85
  86         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  87         * DumpRenderTree/mac/DumpRenderTreePasteboard.mm: Renamed from Tools/DumpRenderTree/mac/DumpRenderTreePasteboard.m.
  88         (-[LocalPasteboard writeObjects:]):
  89         Implement this in terms of the legacy pasteboard API.
  90
  91         * DumpRenderTree/mac/EventSendingController.mm:
  92         (drt_WebHTMLView_beginDraggingSessionWithItemsEventSource):
  93         (+[EventSendingController initialize]):
  94         Swizzle the drag method instead of adding a delegate method (like the old code does).
  95
  96 2017-02-20  Florian Bruhin  <git@the-compiler.org>
  97
  98         Handle EINTR during webkitpy server process select()
  99         https://bugs.webkit.org/show_bug.cgi?id=168361
 100
 101         Reviewed by Michael Catanzaro.
 102
 103         Otherwise, on my machine, resizing the terminal run-webkit-tests is running in
 104         makes it die.
 105
 106         * Scripts/webkitpy/port/server_process.py:
 107         (ServerProcess._wait_for_data_and_update_buffers_using_select):
 108
 109 2017-02-20  Carlos Garcia Campos  <cgarcia@igalia.com>
 110
 111         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/default-menu.
 112
 113         It can happen that the window onload event is dispatched after the load finished is received in the UI
 114         process. Move the script to select the text to the body instead of using a window onload handler.
 115
 116         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
 117         (testContextMenuDefaultMenu):
 118
 119 2017-02-20  Manuel Rego Casasnovas  <rego@igalia.com>
 120
 121         [css-grid] Remove compilation flag ENABLE_CSS_GRID_LAYOUT
 122         https://bugs.webkit.org/show_bug.cgi?id=167693
 123
 124         Reviewed by Sergio Villar Senin.
 125
 126         * Scripts/webkitperl/FeatureList.pm:
 127         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
 128         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp:
 129         (TestWebKitAPI::computeNumberOfTracks):
 130         (TestWebKitAPI::TEST):
 131         * TestWebKitAPI/Tests/WebCore/GridPosition.cpp:
 132         (TestWebKitAPI::TEST):
 133
 134 2017-02-19  Commit Queue  <commit-queue@webkit.org>
 135
 136         Unreviewed, rolling out r212466.
 137         https://bugs.webkit.org/show_bug.cgi?id=168577
 138
 139         causes crashes on AArch64 on linux, maybe it's causing crashes
 140         on iOS too (Requested by pizlo on #webkit).
 141
 142         Reverted changeset:
 143
 144         "The collector thread should only start when the mutator
 145         doesn't have heap access"
 146         https://bugs.webkit.org/show_bug.cgi?id=167737
 147         http://trac.webkit.org/changeset/212466
 148
 149 2017-02-17  Aakash Jain  <aakash_jain@apple.com>
 150
 151         Fix failure from r212579.
 152
 153         Unreviewed build-fix.
 154
 155         * Scripts/webkitpy/tool/steps/checkpatchrelevance.py:
 156         (CheckPatchRelevance._changes_are_relevant): Return true for all groups others than jsc for now.
 157
 158 2017-02-17  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
 159
 160         EWS should run JavaScriptCore tests
 161         https://bugs.webkit.org/show_bug.cgi?id=162458
 162
 163         Reviewed by Alexey Proskuryakov.
 164
 165         * QueueStatusServer/config/queues.py: Add jsc-ews queue.
 166         * QueueStatusServer/model/queuestatus.py:
 167         (QueueStatus.did_skip): Returns whether patch was skipped, based on status.
 168         * QueueStatusServer/handlers/statusbubble.py:
 169         (StatusBubble._should_show_bubble_for): Add logic to hide jsc-ews bubble if the patch does not touch jsc.
 170         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
 171         (MockSCM.__init__): Add _mockChangedFiles variable.
 172         (MockSCM.changed_files): Change to use _mockChangedFiles variables.
 173         * Scripts/webkitpy/common/config/ews.json: Add config info for JSC EWS.
 174         * Scripts/webkitpy/common/config/ports.py: Add support for JSC EWS in Mac Port.
 175         (DeprecatedPort._append_build_style_flag): Helper function to append build_style to a command.
 176         (DeprecatedPort.build_jsc_command): Added - command to build JSC only (quicker than building all of WebKit).
 177         (DeprecatedPort.run_javascriptcore_tests_command): Allow JSC EWS to only run JSC tests.
 178         (MacPort.run_webkit_tests_command): Check for JSC.
 179         * Scripts/webkitpy/common/config/ports_mock.py:
 180         (MockPort.run_javascriptcore_tests_command): Add build_style argument.
 181         * Scripts/webkitpy/common/config/ports_unittest.py:
 182         (DeprecatedPortTest.test_mac_port): Add unit tests for build-jsc shell command.
 183         * Scripts/webkitpy/common/net/abstracttestresults.py: Added.
 184         (AbstractTestResults): Abstract superclass of JSCTestResults and JSCTestResults.
 185         (AbstractTestResults.test_results): Stub.
 186         (AbstractTestResults.failing_tests): Stub.
 187         (AbstractTestResults.did_exceed_test_failure_limit): Stub.
 188         * Scripts/webkitpy/common/net/jsctestresults.py: Added.
 189         (JSCTestResults): Added.
 190         (JSCTestResults.intersection): Return a JSCTestResults object with failures common to both input objects.
 191         (JSCTestResults.results_from_string): Use json library to parse results.
 192         (JSCTestResults.__init__): Initialize members.
 193         (JSCTestResults.equals): This enables unit testing.
 194         (JSCTestResults.is_subset): Checks if one set of failures is a subset of another.
 195         (JSCTestResults.all_passed): Getter.
 196         (JSCTestResults.failing_tests): Getter.
 197         (JSCTestResults.did_exceed_test_failure_limit): Getter.
 198         * Scripts/webkitpy/common/net/jsctestresults_unittest.py: Added.
 199         (JSCTestResultsTest): Class to test JSCTestResults.
 200         (JSCTestResultsTest.test_results_from_string): Tests parsing.
 201         (JSCTestResultsTest.test_intersection_api_tests): Unit test for intersection() class method.
 202         (JSCTestResultsTest.test_intersection_stress_tests): Unit test for intersection() class method.
 203         (JSCTestResultsTest.test_intersection_general_case): Unit test for intersection() class method.
 204         * Scripts/webkitpy/port/base.py:
 205         (Port.jsc_results_directory): Returns the directory for the JSC test results JSON file.
 206         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
 207         (EarlyWarningSystemTask.run): Add check_patch_relevance step.
 208         * Scripts/webkitpy/tool/bot/jscews_unittest.py: Added.
 209         (MockPatchAnalysisTask): Mocked-out version of PatchAnalysisTask that doesn't run commands.
 210         (MockPatchAnalysisTask.__init__): Sets attributes.
 211         (MockPatchAnalysisTask._test): Override to not run command.
 212         (MockPatchAnalysisTask._build_and_test_without_patch): Override to not run command.
 213         (MockPatchAnalysisTask.validate): Assume mocked patch is valid for purposes of testing retry logic.
 214         (MockPatchAnalysisTask.test_run_count): Specific to the mocked version, to test retry logic.
 215         (MockJSCEarlyWarningSystem): Mocked-out version of AbstarctEarlyWarningSystem so we can provide test results.
 216         (MockJSCEarlyWarningSystem.__init__): Sets attributes, also sets group to jsc.
 217         (MockJSCEarlyWarningSystem.test_results): Returns test results provided by us, instead of using a JSON reader.
 218         (JSCEarlyWarningSystemTest): Class to test retry logic in below situations.
 219         (JSCEarlyWarningSystemTest._create_task): Helper function to abstract out common code.
 220         (JSCEarlyWarningSystemTest._results_indicate_all_passed): False if input is None or has failures, else True.
 221         (JSCEarlyWarningSystemTest.test_success_case): Clean patch on clean tree.
 222         (JSCEarlyWarningSystemTest.test_test_failure): Failed patch on clean tree.
 223         (JSCEarlyWarningSystemTest.test_fix): Patch that fixes all tree redness.
 224         (JSCEarlyWarningSystemTest.test_ineffective_patch): Patch that has same failures as tree.
 225         (JSCEarlyWarningSystemTest.test_partially_effective_patch): Patch fixes some failures but adds no new failures.
 226         (JSCEarlyWarningSystemTest.test_different_test_failures_in_patch_and_tree): Patch has some failures not in tree.
 227         (JSCEarlyWarningSystemTest.test_first_results_could_not_be_read): Patch results not readable.
 228         (JSCEarlyWarningSystemTest.test_second_results_could_not_be_read): Patch results not readable on second run.
 229         (JSCEarlyWarningSystemTest.test_clean_results_could_not_be_read): Results from clean tree not readable.
 230         (JSCEarlyWarningSystemTest.test_flaky_results_on_clean_tree_pass): Patch has one flake and no failures.
 231         (JSCEarlyWarningSystemTest.test_flaky_results_on_clean_tree_pass_v2): Patch has one flake and no failures.
 232         (JSCEarlyWarningSystemTest.test_flaky_results_on_clean_tree_failure): Patch has flakes and failed tests.
 233         (JSCEarlyWarningSystemTest.test_flaky_results_on_red_tree_pass): Patch has same failures as tree, plus a flake.
 234         * Scripts/webkitpy/tool/bot/jsctestresultsreader.py: Added.
 235         (JSCTestResultsReader): Reads results file.
 236         (JSCTestResultsReader.__init__): Sets attributes.
 237         (JSCTestResultsReader._read_file_contents): Reads file.
 238         (JSCTestResultsReader.results): Reads the results file and returns a JSCTestResults object.
 239         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
 240         (PatchIsNotApplicable): Exception for when patch doesn't have relevant changes.
 241         (PatchAnalysisTask._check_patch_relevance): Added.
 242         (PatchAnalysisTask._build): Check for JSC.
 243         (PatchAnalysisTask._build_without_patch): Check for JSC.
 244         (PatchAnalysisTask._test): Check for JSC.
 245         (PatchAnalysisTask._build_and_test_without_patch): Check for JSC.
 246         (PatchAnalysisTask._retry_jsc_tests): Retry logic for JSC EWS.
 247         (PatchAnalysisTask._retry_layout_tests): Retry logic for layout tests EWS.
 248         (PatchAnalysisTask._test_patch): Add retry logic for JSC.
 249         * Scripts/webkitpy/tool/commands/download.py:
 250         (CheckPatchRelevance): Add check-patch-relevance command.
 251         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
 252         (AbstractEarlyWarningSystem._create_task): Abstract out to enable mocking.
 253         (AbstractEarlyWarningSystem.begin_work_queue): Use JSCTestResultsReader not LayoutTestResultsReader in JSC EWS.
 254         (AbstractEarlyWarningSystem.review_patch): Handle PatchIsApplicable.
 255         (AbstractEarlyWarningSystem.test_results): _layout_test_results_reader -> _test_results_reader.
 256         (AbstractEarlyWarningSystem.archive_last_test_results): _layout_test_results_reader -> _test_results_reader.
 257         (AbstractEarlyWarningSystem.group): This attribute determines the type of EWS (eg. JSC).
 258         (AbstractEarlyWarningSystem.load_ews_classes): Add _group, and make classes of type cls to enable mocking.
 259         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
 260         (TestEWS): Sample layout test EWS class used for unit testing.
 261         (TestJSCEWS): Sample JSC EWS class used for unit testing.
 262         (AbstractEarlyWarningSystemTest.test_failing_tests_message.TestEWS): Add _group.
 263         (AbstractEarlyWarningSystemTest.test_failing_jsc_tests_message.TestEWS): Added test for jsc failures message.
 264         (AbstractEarlyWarningSystemTest): Add _group variable.
 265         (EarlyWarningSystemTest._default_expected_logs): Add check-patch-relevance step, inconclusive logs, and group.
 266         (EarlyWarningSystemTest._test_ews): Add logs_are_conclusive option to pass through to default_expected_logs().
 267         (EarlyWarningSystemTest.test_inconclusive_test_results): Test not removing patch from queue if not conclusive.
 268         (MockAbstractEarlyWarningSystemForInconclusiveJSCResults): Added.
 269         (MockAbstractEarlyWarningSystemForInconclusiveJSCResults._test_patch): Simulates running tests but not getting a conclusive result.
 270         (MockEarlyWarningSystemTaskForInconclusiveJSCResults): Added.
 271         (MockEarlyWarningSystemTaskForInconclusiveJSCResults._create_task): Use MockEarlyWarningSystemTask (not EarlyWarningSystemTask).
 272         * Scripts/webkitpy/tool/steps/__init__.py: Add CheckPatchRelevance import.
 273         * Scripts/webkitpy/tool/steps/build.py:
 274         (Build.options): Check for JSC.
 275         (Build.build): Check for JSC.
 276         (Build.run): Check for JSC.
 277         * Scripts/webkitpy/tool/steps/checkpatchrelevance.py: Added.
 278         (CheckPatchRelevance): Added.
 279         (CheckPatchRelevance._does_contain_change_in_paths): Abstract function to perform regex matching.
 280         (CheckPatchRelevance.run): Check if changed files in patch belong in certain folders.
 281         * Scripts/webkitpy/tool/steps/options.py:
 282         (Options): Add --group command line option.
 283         * Scripts/webkitpy/tool/steps/runtests.py:
 284         (RunTests.options): Add group.
 285         (RunTests.run): Check for JSC.
 286         (RunTests._run_webkit_tests): Check for JSC.
 287         (RunTests): Add _group attribute.
 288         (RunTests._run_javascriptcore_tests): New.
 289         * Scripts/webkitpy/tool/steps/steps_unittest.py: Unit tests.
 290
 291 2017-02-17  Aakash Jain  <aakash_jain@apple.com>
 292
 293         Fix tools that were broken by Efl removal
 294         https://bugs.webkit.org/show_bug.cgi?id=168496
 295
 296         Reviewed by Alexey Proskuryakov.
 297
 298         * QueueStatusServer/config/queues.py:
 299         * Scripts/webkitpy/common/config/ews.json:
 300         * TestResultServer/static-dashboards/builders.jsonp:
 301         * TestResultServer/static-dashboards/flakiness_dashboard.js:
 302         * TestResultServer/static-dashboards/loader_unittests.js:
 303
 304 2017-02-16  Lucas Forschler  <lforschler@apple.com>
 305
 306         https://bugs.webkit.org/show_bug.cgi?id=168442
 307         Move the SVN checkout from http -> https.
 308         Update unit tests.
 309
 310         Reviewed by Alexey Proskuryakov.
 311
 312         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 313         (CheckOutSource.__init__):
 314         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
 315         (SVNMirrorTest.get_SVNMirrorFromConfig):
 316         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
 317
 318 2017-02-16  Commit Queue  <commit-queue@webkit.org>
 319
 320         Unreviewed, rolling out r212514.
 321         https://bugs.webkit.org/show_bug.cgi?id=168489
 322
 323         broke test runner (Requested by alexchristensen on #webkit).
 324
 325         Reverted changeset:
 326
 327         "Remove EFL-specific files in Tools."
 328         http://trac.webkit.org/changeset/212514
 329
 330 2017-02-16  Alex Christensen  <achristensen@webkit.org>
 331
 332         Remove EFL-specific files in Tools.
 333
 334         Rubber-stamped by Anders Carlsson.
 335
 336         * ImageDiff/efl: Removed.
 337         * ImageDiff/efl/ImageDiff.cpp: Removed.
 338         * MiniBrowser/efl: Removed.
 339         * MiniBrowser/efl/CMakeLists.txt: Removed.
 340         * MiniBrowser/efl/main.c: Removed.
 341         * Scripts/run-efl-tests: Removed.
 342         * Scripts/update-webkitefl-libs: Removed.
 343         * Scripts/webkitpy/port/efl.py: Removed.
 344         * Scripts/webkitpy/port/efl_unittest.py: Removed.
 345         * TestWebKitAPI/Tests/WebKit2/efl: Removed.
 346         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp: Removed.
 347         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp: Removed.
 348         * TestWebKitAPI/Tests/WebKit2/efl/WKViewScrollTo.cpp: Removed.
 349         * TestWebKitAPI/Tests/WebKit2/efl/scrollTo.html: Removed.
 350         * TestWebKitAPI/efl: Removed.
 351         * TestWebKitAPI/efl/InjectedBundleController.cpp: Removed.
 352         * TestWebKitAPI/efl/PlatformUtilities.cpp: Removed.
 353         * TestWebKitAPI/efl/PlatformWebView.cpp: Removed.
 354         * TestWebKitAPI/efl/main.cpp: Removed.
 355         * WebKitTestRunner/InjectedBundle/efl: Removed.
 356         * WebKitTestRunner/InjectedBundle/efl/ActivateFontsEfl.cpp: Removed.
 357         * WebKitTestRunner/InjectedBundle/efl/FontManagement.cpp: Removed.
 358         * WebKitTestRunner/InjectedBundle/efl/FontManagement.h: Removed.
 359         * WebKitTestRunner/InjectedBundle/efl/InjectedBundleEfl.cpp: Removed.
 360         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp: Removed.
 361         * WebKitTestRunner/efl: Removed.
 362         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp: Removed.
 363         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp: Removed.
 364         * WebKitTestRunner/efl/TestControllerEfl.cpp: Removed.
 365         * WebKitTestRunner/efl/main.cpp: Removed.
 366         * efl: Removed.
 367         * efl/install-dependencies: Removed.
 368         * efl/jhbuild-optional.modules: Removed.
 369         * efl/jhbuild.modules: Removed.
 370         * efl/jhbuildrc: Removed.
 371         * efl/patches: Removed.
 372         * efl/patches/evas-fix-build-with-giflib5.patch: Removed.
 373         * efl/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Removed.
 374         * efl/patches/gst-libav.patch: Removed.
 375         * efl/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Removed.
 376         * efl/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
 377         * efl/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
 378         * efl/patches/openwebrtc-gst-plugins-clang-warning-fix.patch: Removed.
 379
 380 2017-02-16  Myles C. Maxfield  <mmaxfield@apple.com>
 381
 382         font-weight in @font-face can cause a font to be downloaded even when it's not used
 383         https://bugs.webkit.org/show_bug.cgi?id=168114
 384         <rdar://problem/30301317>
 385
 386         Reviewed by Darin Adler.
 387
 388         LastResort needs to be usable in tests.
 389
 390         * DumpRenderTree/mac/DumpRenderTree.mm:
 391         (allowedFontFamilySet):
 392         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
 393         (WTR::allowedFontFamilySet):
 394         * WebKitTestRunner/mac/TestControllerMac.mm:
 395         (WTR::allowedFontFamilySet):
 396
 397 2017-02-16  Alex Christensen  <achristensen@webkit.org>
 398
 399         Remove old URL parser
 400         https://bugs.webkit.org/show_bug.cgi?id=168483
 401
 402         Reviewed by Tim Horton.
 403
 404         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
 405         (TestWebKitAPI::checkURL):
 406         (TestWebKitAPI::checkRelativeURL):
 407         (TestWebKitAPI::checkURLDifferences):
 408         (TestWebKitAPI::checkRelativeURLDifferences):
 409
 410 2017-02-16  Wenson Hsieh  <wenson_hsieh@apple.com>
 411
 412         [WK2] Add additional test infrastructure and unit tests for data interaction
 413         https://bugs.webkit.org/show_bug.cgi?id=168439
 414         <rdar://problem/30557942>
 415
 416         Reviewed by Tim Horton.
 417
 418         Adds test support for additional data interaction scenarios that we currently cannot test, and also adds 7 new
 419         test cases to DataInteractionTests. Most of the changes here refactor and augment DataInteractionSimulator to
 420         support data interaction from  See per-method descriptions below for more details.
 421
 422         * Configurations/TestWebKitAPI.xcconfig:
 423
 424         Add MobileCoreServices to the list of additional frameworks to link against on iOS.
 425
 426         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 427
 428         Add a new build phase that copies additional resources from WebKitAdditions/Resources/TestWebKitAPI and dumps
 429         them into TestWebKitAPI.resources/ in the build directory, if the WebKitAdditions folder exists.
 430
 431         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
 432         (-[TestWKWebView editorContainsImageElement]):
 433         (-[TestWKWebView editorValue]):
 434
 435         New helper methods for querying information from the "editor" element in a test page.
 436
 437         (TestWebKitAPI::TEST):
 438         (TestWebKitAPI::runTestsExpectingToObserveEvents): Deleted.
 439
 440         Moves logic for capturing events during a simulated data interaction run from the test file to
 441         DataInteractionSimulator. See -[DataInteractionSimulator observedEventNames].
 442
 443         * TestWebKitAPI/cocoa/TestWKWebView.h:
 444         * TestWebKitAPI/cocoa/TestWKWebView.mm:
 445         (-[TestMessageHandler removeMessage:]):
 446         (-[TestWKWebView clearMessageHandlers:]):
 447
 448         Add the ability to clear message handlers from the TestWKWebView.
 449
 450         * TestWebKitAPI/ios/DataInteractionSimulator.h:
 451         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
 452         (dataInteractionEventNames):
 453         (-[DataInteractionSimulator initWithWebView:]):
 454         (-[DataInteractionSimulator _resetSimulatedState]):
 455
 456         Moves logic to clear test harness state from any previous runs into a helper. Called at the beginning when
 457         simulating data interaction.
 458
 459         (-[DataInteractionSimulator observedEventNames]):
 460
 461         Returns a list of the names of events relevant to data interaction that were observed over the course of the
 462         most recent run.
 463
 464         (-[DataInteractionSimulator runFrom:to:]):
 465
 466         Changes -run to -runFrom:to:, which takes window-relative start and end locations. This allows the test harness
 467         to run the same data interaction for multiple simulated gestures.
 468
 469         (-[DataInteractionSimulator _advanceProgress]):
 470         (-[DataInteractionSimulator _finishDataInteraction]):
 471         (-[DataInteractionSimulator externalItemProvider]):
 472         (-[DataInteractionSimulator setExternalItemProvider:]):
 473
 474         Adds the -externalItemProvider property to DataInteractionSimulator. Setting this skips the gesture recognition
 475         phase of a test run.
 476
 477         (-[DataInteractionSimulator webViewDidPerformDataInteractionControllerOperation:]):
 478         (-[DataInteractionSimulator webView:beginDataInteractionWithSourceIndex:gestureRecognizer:]):
 479         (-[DataInteractionSimulator webViewDidSendDataInteractionStartRequest:]):
 480         (-[DataInteractionSimulator webView:didReceiveDataInteractionStartResponse:]):
 481
 482         While a request to start data interaction is in flight, put the remainder of the test on hold until the web
 483         process returns. Then continue the test by scheduling a progress advance call. This addresses a race condition
 484         wherein the the web process might take longer than usual to process the request to start data interaction, and
 485         in the meantime, DataInteractionSimulator would end up completing the rest of the test before a response from
 486         the web process is received, which then causes no simulated delegate methods to be fired.
 487
 488         (-[DataInteractionSimulator initWithWebView:startLocation:endLocation:]): Deleted.
 489         (-[DataInteractionSimulator run]): Deleted.
 490
 491 2017-02-16  Wenson Hsieh  <wenson_hsieh@apple.com>
 492
 493         Remove unused test pages in TestWebKitAPI
 494         https://bugs.webkit.org/show_bug.cgi?id=168462
 495
 496         Reviewed by Anders Carlsson.
 497
 498         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 499         * TestWebKitAPI/Tests/WebKit2Cocoa/autofocus-contenteditable.html: Removed.
 500         * TestWebKitAPI/Tests/WebKit2Cocoa/background-image-link-and-input.html: Removed.
 501         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-contenteditable.html: Removed.
 502         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html: Removed.
 503         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-input.html: Removed.
 504
 505 2017-02-16  Alex Christensen  <achristensen@webkit.org>
 506
 507         Special URLs without a host are invalid
 508         https://bugs.webkit.org/show_bug.cgi?id=168461
 509
 510         Reviewed by Tim Horton.
 511
 512         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
 513         (TestWebKitAPI::TEST_F):
 514
 515 2017-02-10  Filip Pizlo  <fpizlo@apple.com>
 516
 517         The collector thread should only start when the mutator doesn't have heap access
 518         https://bugs.webkit.org/show_bug.cgi?id=167737
 519
 520         Reviewed by Keith Miller.
 521
 522         Make more tests collect continuously.
 523
 524         * Scripts/run-jsc-stress-tests:
 525
 526 2017-02-16  Tim Horton  <timothy_horton@apple.com>
 527
 528         WKWebView inside a UICollectionView flashes when items are inserted above it
 529         https://bugs.webkit.org/show_bug.cgi?id=168376
 530         <rdar://problem/29322051>
 531
 532         Reviewed by Simon Fraser.
 533
 534         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
 535         (-[TestRunnerWKWebView _setStableStateOverride:]):
 536         Update the one external caller of this internal method...
 537
 538         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
 539         (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
 540         * DumpRenderTree/mac/UIScriptControllerMac.mm:
 541         (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
 542         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
 543         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
 544         (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
 545         * TestRunnerShared/UIScriptContext/UIScriptController.h:
 546         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
 547         (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
 548         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
 549         (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
 550         Expose doAfterVisibleContentRectUpdate to DRT and WKTR. It is called
 551         back after we dispatch a visible content rect update from the UI process
 552         to the Web Content process, so any messages sent from the block will arrive
 553         after the visible content rect update.
 554
 555 2017-02-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
 556
 557         [GTK] Add two new buildbots that build-only test on Debian stable and Ubuntu LTS.
 558         https://bugs.webkit.org/show_bug.cgi?id=168321
 559
 560         This bots should be added to the trunk build scheduler.
 561         Unreviewed fix after r212429.
 562
 563         * BuildSlaveSupport/build.webkit.org-config/config.json:
 564
 565 2017-02-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
 566
 567         [GTK] Add two new buildbots that build-only test on Debian stable and Ubuntu LTS
 568         https://bugs.webkit.org/show_bug.cgi?id=168321
 569
 570         Reviewed by Michael Catanzaro.
 571
 572         The additionalArgument --default-cmake-features is used both to
 573         skip the JHBuild (InstallGtkDependencies) build step and to build
 574         with the default features from the CMake config.
 575
 576         * BuildSlaveSupport/build.webkit.org-config/config.json:
 577         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 578         (Factory.__init__):
 579         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
 580
 581 2017-02-15  Lucas Forschler  <lforschler@apple.com>
 582
 583         https://bugs.webkit.org/show_bug.cgi?id=168386
 584         Remove EFL from build.webkit.org
 585
 586         Reviewed by Alex Christensen
 587
 588         * BuildSlaveSupport/build.webkit.org-config/config.json:
 589         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 590         (DeleteStaleBuildFiles.start):
 591         (appendCustomBuildFlags):
 592         (RunWebKitTests.start):
 593         (RunBuiltinsTests):
 594         (Factory.__init__):
 595         (TestFactory.__init__):
 596         (loadBuilderConfig):
 597         (InstallEflDependencies): Deleted.
 598         (RunEflAPITests): Deleted.
 599         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
 600         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
 601         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
 602         (BubbleQueueServer):
 603         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
 604         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
 605         (Analyzer.prototype._triggeringQueue):
 606         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
 607         (WebKitBuildbot):
 608         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
 609         (table.queue-grid tr.platform.linux-efl img.logo): Deleted.
 610         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
 611         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
 612         (_should_file_trigger_build):
 613
 614 2017-02-15  Alex Christensen  <achristensen@webkit.org>
 615
 616         Unreviewed, rolling out r212169.
 617
 618         Broke iOS WebInspector
 619
 620         Reverted changeset:
 621
 622         "WebInspector: refactor RemoteInspector to move cocoa specific
 623         code to their own files"
 624         https://bugs.webkit.org/show_bug.cgi?id=166681
 625         http://trac.webkit.org/changeset/212169
 626
 627 2017-02-15  Jonathan Bedard  <jbedard@apple.com>
 628
 629         webkitpy: Fix DarwinPort._get_crash_log()
 630         https://bugs.webkit.org/show_bug.cgi?id=168372
 631         <rdar://problem/30535156>
 632
 633         Reviewed by Daniel Bates.
 634
 635         Callers of _get_crash_log expect a pair to be returned and do not check it's return value.
 636         DarwinPort should return the expected return value for _get_crash_log.
 637
 638         * Scripts/webkitpy/port/darwin.py:
 639         (DarwinPort._get_crash_log): Call parent class's implementation of _get_crash_log.
 640
 641 2017-02-15  Chris Dumez  <cdumez@apple.com>
 642
 643         [iOS] Form Validation Bubble should be sensitive to Dynamic Type
 644         https://bugs.webkit.org/show_bug.cgi?id=168291
 645         <rdar://problem/30508593>
 646
 647         Reviewed by Tim Horton.
 648
 649         Drop overridePreference() implementation in iOS's UIScriptController
 650         as it was only used for the minimum font size setting and this setting
 651         is not exposed on iOS.
 652
 653         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
 654         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
 655         (WTR::UIScriptController::overridePreference):
 656         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
 657
 658 2017-02-15  Jonathan Bedard  <jbedard@apple.com>
 659
 660         webkitpy: Memoize app_identifier_from_bundle for efficiency, call parent class for _get_crash_log
 661         https://bugs.webkit.org/show_bug.cgi?id=168329
 662         <rdar://problem/30518832>
 663
 664         Reviewed by Daniel Bates.
 665
 666         When testing on device, app_identifier_from_bundle is repeatedly called but the return value will
 667         never change given the same input arguments.  Memoize function for efficiency.
 668
 669         * Scripts/webkitpy/port/darwin.py: Add memoized import.
 670         (DarwinPort):
 671         (DarwinPort.app_identifier_from_bundle): Memoize to avoid extra executions of PlistBuddy.
 672
 673
 674 2017-02-15  Jonathan Bedard  <jbedard@apple.com>
 675
 676         webkitpy: Remove unused import from darwin.py
 677         https://bugs.webkit.org/show_bug.cgi?id=168371
 678
 679         Reviewed by Alex Christensen.
 680
 681         * Scripts/webkitpy/port/darwin.py: Remove unused 'time' module.
 682
 683 2017-02-15  Carlos Garcia Campos  <cgarcia@igalia.com>
 684
 685         [SOUP] Credentials stored by libsoup are used even StoredCredentials policy is DoNotAllowStoredCredentials
 686         https://bugs.webkit.org/show_bug.cgi?id=168364
 687
 688         Reviewed by Michael Catanzaro.
 689
 690         This can happen if a previous load with allowed to use stored credentials authenticated successfully, saving the
 691         credentials in libsoup. It's actually a libsoup bug, but since it's causing layout test failures and we have
 692         patches for them, let's patch out jhbuild until we have a new libsoup version to depend on.
 693
 694         Fixes: http/tests/security/credentials-from-different-domains.html
 695                http/tests/xmlhttprequest/cross-origin-no-authorization.html
 696
 697         * gtk/jhbuild.modules:
 698         * gtk/patches/libsoup-auth-Fix-async-authentication-when-flag-SOUP_MESSAGE.patch: Added.
 699         * gtk/patches/libsoup-auth-do-not-use-cached-credentials-in-lookup-method-.patch: Added.
 700
 701 2017-02-14  Carlos Garcia Campos  <cgarcia@igalia.com>
 702
 703         [GTK] Update cookie manager API to properly work with ephemeral sessions
 704         https://bugs.webkit.org/show_bug.cgi?id=168230
 705
 706         Reviewed by Michael Catanzaro.
 707
 708         Update unit tests and add new cases for the new API.
 709
 710         * MiniBrowser/gtk/main.c:
 711         (gotWebsiteDataCallback):
 712         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
 713         (testCookieManagerEphemeral):
 714         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
 715         (testWebContextEphemeral):
 716         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
 717         (testWebViewEphemeral):
 718         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp:
 719         (serverCallback):
 720         (testWebsiteDataEphemeral):
 721         (testWebsiteDataCookies):
 722         (beforeAll):
 723
 724 2017-02-14  Wenson Hsieh  <wenson_hsieh@apple.com>
 725
 726         [WK2] Support data interaction on links
 727         https://bugs.webkit.org/show_bug.cgi?id=168331
 728         <rdar://problem/30200837>
 729
 730         Reviewed by Tim Horton.
 731
 732         Adds 2 unit tests checking that data interaction from a link (with or without a background image) into an
 733         editable area results in the link URL being inserted.
 734
 735         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 736         * TestWebKitAPI/Tests/WebKit2Cocoa/background-image-link-and-input.html: Added.
 737         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-input.html: Added.
 738         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
 739         (TestWebKitAPI::TEST):
 740
 741 2017-02-14  Jason Rinn  <jrinn@apple.com>
 742
 743         Add a test for new WebKit Cocoa API, _getContentsAsString.
 744         https://bugs.webkit.org/show_bug.cgi?id=168147
 745         <rdar://problem/30502539>
 746
 747         Reviewed by Tim Horton.
 748
 749         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 750         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewGetContents.mm: Added.
 751         (TEST):
 752
 753 2017-02-14  Matt Rajca  <mrajca@apple.com>
 754
 755         Website policies: iframes should respect the autoplay policy of the top-level document
 756         https://bugs.webkit.org/show_bug.cgi?id=168333
 757
 758         Reviewed by Alex Christensen.
 759
 760         * TestWebKitAPI/Tests/WebKit2/autoplay-check-frame.html: Added.
 761         * TestWebKitAPI/Tests/WebKit2/autoplay-check-in-iframe.html: Added.
 762         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
 763         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
 764         (TEST):
 765
 766 2017-02-14  Chris Dumez  <cdumez@apple.com>
 767
 768         HTML Form Validation bubble should take minimum font size setting into consideration
 769         https://bugs.webkit.org/show_bug.cgi?id=168271
 770         <rdar://problem/29869869>
 771
 772         Reviewed by Simon Fraser.
 773
 774         Extend UIScriptController's contentsOfUserInterfaceItem() to also return the
 775         font size of the validation bubble.
 776
 777         Add an overridePreference() method to UIScriptController. This is currently
 778         used to override the value of the minimumFontSize setting. testRunner's
 779         overridePreference() is not usable on WK2 because it does not update the
 780         value of the preference on the UIProcess side.
 781
 782         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
 783         (WTR::UIScriptController::overridePreference):
 784         * DumpRenderTree/mac/UIScriptControllerMac.mm:
 785         (WTR::UIScriptController::overridePreference):
 786         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
 787         * TestRunnerShared/UIScriptContext/UIScriptController.h:
 788         * WebKitTestRunner/TestController.cpp:
 789         (WTR::TestController::resetPreferencesToConsistentValues):
 790         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
 791         (WTR::UIScriptController::overridePreference):
 792         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
 793         (WTR::UIScriptController::contentsOfUserInterfaceItem):
 794         (WTR::UIScriptController::overridePreference):
 795
 796 2017-02-14  Florian Bruhin  <git@the-compiler.org>
 797
 798         Use a set instead of a list for tests when parsing expectations
 799         https://bugs.webkit.org/show_bug.cgi?id=168304
 800
 801         In _collect_matching_tests, a lot of membership tests are done on a giant list
 802         of strings. By making it a set instead, we can make those much faster, and
 803         there's no reason for it to be a list.
 804
 805         With ~45k tests and some 1000 expectations, this reduces the parse time from 34s
 806         to 3s on my machine.
 807
 808         Reviewed by Ryosuke Niwa.
 809
 810         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
 811         (TestExpectationParser.__init__):
 812         (TestExpectationParser._collect_matching_tests):
 813
 814 2017-02-14  Jonathan Bedard  <jbedard@apple.com>
 815
 816         Unreviewed build-fix after r212297.
 817
 818         * Scripts/webkitpy/port/simulator_process.py:
 819         (SimulatorProcess.stop): Should return value of the ServerProcess's stop.
 820
 821 2017-02-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
 822
 823         [CMake] build-webkit should allow building with the default cmake configuration
 824         https://bugs.webkit.org/show_bug.cgi?id=168323
 825
 826         Reviewed by Michael Catanzaro.
 827
 828         Add a --default-cmake-features switch that makes the script pass
 829         no value for any of the features defined by build-webkit, that
 830         way the default values from the port cmake config will be used.
 831
 832         * Scripts/build-webkit:
 833         (cMakeArgsFromFeatures):
 834
 835 2017-02-14  Jonathan Bedard  <jbedard@apple.com>
 836
 837         Unreviewed build-fix after r212297.
 838
 839         * Scripts/webkitpy/port/simulator_process.py:
 840         (SimulatorProcess.stop): Handle case where there is no process to kill.
 841
 842 2017-02-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
 843
 844         [CMake] build-webkit should print the cmake command executed
 845         https://bugs.webkit.org/show_bug.cgi?id=168318
 846
 847         Reviewed by Michael Catanzaro.
 848
 849         Run the cmake commands to configure or start the build through
 850         a wrapper that prints the command before executing it.
 851
 852         * Scripts/webkitdirs.pm:
 853         (systemVerbose):
 854         (generateBuildSystemFromCMakeProject):
 855         (buildCMakeGeneratedProject):
 856         (cleanCMakeGeneratedProject):
 857
 858 2017-02-14  Jonathan Bedard  <jbedard@apple.com>
 859
 860         run-webkit-tests for iOS Simulator always complains that stopping WebKitTestRunnerApp.app times out
 861         https://bugs.webkit.org/show_bug.cgi?id=168150
 862
 863         Reviewed by Alexey Proskuryakov.
 864
 865         * Scripts/webkitpy/port/simulator_process.py:
 866         (SimulatorProcess.stop): Close app before calling ServerProcess's stop.
 867         (SimulatorProcess._kill): Move closing of app into stop().
 868         * Scripts/webkitpy/xcode/simulator.py:
 869         (Device.launch_app):
 870         (Device.terminate_app): Deleted.
 871
 872 2017-02-14  Carlos Garcia Campos  <cgarcia@igalia.com>
 873
 874         REGRESSION(r212192): [GTK] Broke downloads API tests
 875         https://bugs.webkit.org/show_bug.cgi?id=168193
 876
 877         Unreviewed. Update test expectations after r212192.
 878
 879         The suggested filename now includes a file extensions if the MIME type is known.
 880
 881         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
 882         (testDownloadRemoteFile):
 883         (testDownloadMIMEType):
 884
 885 2017-02-14  Commit Queue  <commit-queue@webkit.org>
 886
 887         Unreviewed, rolling out r212237.
 888         https://bugs.webkit.org/show_bug.cgi?id=168298
 889
 890         This was a wrong fix (Requested by rniwa on #webkit).
 891
 892         Reverted changeset:
 893
 894         "Nwtr unexpectedly passes mismatch ref test if the hashes
 895         doesn't match but no diff"
 896         https://bugs.webkit.org/show_bug.cgi?id=168221
 897         http://trac.webkit.org/changeset/212237
 898
 899 2017-02-13  Alex Christensen  <achristensen@webkit.org>
 900
 901         URLs with an invalid IPv4 address should be invalid
 902         https://bugs.webkit.org/show_bug.cgi?id=168260
 903
 904         Reviewed by Tim Horton.
 905
 906         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
 907         (TestWebKitAPI::TEST_F):
 908         Update tests to reflect new correct behavior.
 909
 910 2017-02-13  Don Olmstead  <don.olmstead@am.sony.com>
 911
 912         [WinCairo] Add Build Slave
 913         https://bugs.webkit.org/show_bug.cgi?id=168263
 914
 915         Reviewed by Lucas Forschler.
 916
 917         * BuildSlaveSupport/build.webkit.org-config/config.json:
 918
 919 2017-02-13  Wenson Hsieh  <wenson_hsieh@apple.com>
 920
 921         Fix the build after r212254
 922
 923         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
 924         (-[DataInteractionSimulator _currentLocation]):
 925
 926 2017-02-13  Wenson Hsieh  <wenson_hsieh@apple.com>
 927
 928         [WK2] Add test infrastructure and unit tests for data interaction
 929         https://bugs.webkit.org/show_bug.cgi?id=168159
 930         <rdar://problem/30477634>
 931
 932         Reviewed by Tim Horton.
 933
 934         Uses the testing delegate introduced in WebKit2 to override the gesture recognizer used to initiate data
 935         interaction. Instead of being driven by UIKit, the DataInteractionSimulator drives this overridden gesture
 936         recognizer by making the WKContentView call its dataInteractionGestureRecognized method. To simulate an actual
 937         gesture being performed, we fire the gesture recognizer (or call the data interaction delegate methods, if the
 938         gesture has already been recognized) at regular intervals over the course of the test.
 939
 940         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 941         * TestWebKitAPI/Tests/WebKit2Cocoa/autofocus-contenteditable.html: Added.
 942         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-contenteditable.html: Added.
 943         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html: Added.
 944
 945         New test pages for data interaction.
 946
 947         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Added.
 948         (TestWebKitAPI::runTestsExpectingToObserveEvents):
 949         (TestWebKitAPI::TEST):
 950         * TestWebKitAPI/cocoa/TestWKWebView.mm:
 951         (-[TestWKWebView stringByEvaluatingJavaScript:]):
 952         * TestWebKitAPI/ios/DataInteractionSimulator.h: Added.
 953         * TestWebKitAPI/ios/DataInteractionSimulator.mm: Added.
 954         (-[MockLongPressGestureRecognizer initWithWindow:]):
 955         (-[MockLongPressGestureRecognizer locationInView:]):
 956         (-[MockLongPressGestureRecognizer state]):
 957         (-[MockLongPressGestureRecognizer numberOfTouches]):
 958         (-[DataInteractionSimulator initWithWebView:startLocation:endLocation:]):
 959         (-[DataInteractionSimulator dealloc]):
 960         (-[DataInteractionSimulator run]):
 961
 962         Performs a data interaction gesture from the start location to the end location with linear interpolation. For
 963         now, the timestep and progress per tick are 30ms and 3.33%, respectively, which means that tests should complete
 964         in a little under 1 second, though this can be easily changed to be configurable in the future if needed.
 965
 966         (-[DataInteractionSimulator _advanceProgress]):
 967
 968         Fired periodically to drive the data interaction gesture. Schedules a call of itself until the test is
 969         completed, and calls _finishDataInteraction when progress is at 1.
 970
 971         (-[DataInteractionSimulator _finishDataInteraction]):
 972         (-[DataInteractionSimulator _currentLocation]):
 973         (-[DataInteractionSimulator _scheduleAdvanceProgress]):
 974         (-[DataInteractionSimulator _recognizeGestureAtLocation:withState:]):
 975         (-[DataInteractionSimulator dataInteractionGestureRecognizer]):
 976         (-[DataInteractionSimulator webViewDidPerformDataInteractionControllerOperation:]):
 977         (-[DataInteractionSimulator webView:beginDataInteractionWithSourceIndex:gestureRecognizer:]):
 978
 979 2017-02-13  Alex Christensen  <achristensen@webkit.org>
 980
 981         Percent should be allowed in non-special URL hosts
 982         https://bugs.webkit.org/show_bug.cgi?id=168255
 983
 984         Reviewed by Tim Horton.
 985
 986         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
 987         (TestWebKitAPI::TEST_F):
 988
 989 2017-02-13  Fujii Hironori  <Hironori.Fujii@sony.com>
 990
 991         Nwtr unexpectedly passes mismatch ref test if the hashes doesn't match but no diff
 992         https://bugs.webkit.org/show_bug.cgi?id=168221
 993
 994         Reviewed by Ryosuke Niwa.
 995
 996         There is a logic error in comparing mismatch ref test images. In
 997         mismatch ref tests, it should be failed if two images has no diff.
 998         But, if the hashes are different, nwtr unexpectedly pass the
 999         mismatch ref test.
1000
1001         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1002         (SingleTestRunner._compare_output_with_reference): Fail the
1003         mismatch ref test if hashes of two images are equal. Invoke
1004         ImageDiff if the hashes don't match.
1005
1006 2017-02-13  Myles C. Maxfield  <mmaxfield@apple.com>
1007
1008         Update custom line breaking iterators to the latest version of Unicode
1009         https://bugs.webkit.org/show_bug.cgi?id=168182
1010
1011         Reviewed by Zalan Bujtas.
1012
1013         Treat the system's ICU as the source of truth to compare breaking positions against.
1014
1015         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1016         * TestWebKitAPI/Tests/WebCore/LineBreaking.mm: Added.
1017         (generateJavaScriptForTest):
1018         (breakingLocationsFromICU):
1019         (testAFewStrings):
1020         (TEST):
1021         * TestWebKitAPI/Tests/WebKit2Cocoa/AllAhem.svg: Renamed from LayoutTests/css3/line-break/resources/AllAhem.svg.
1022         * TestWebKitAPI/Tests/WebKit2Cocoa/LineBreaking.html: Added.
1023
1024 2017-02-12  Michael Catanzaro  <mcatanzaro@igalia.com>
1025
1026         [GTK] Several failing WebViewEditor API tests
1027         https://bugs.webkit.org/show_bug.cgi?id=161608
1028
1029         Reviewed by Carlos Garcia Campos.
1030
1031         Selection.collapse() requires arguments; passing no arguments means the JS that selects the
1032         text range here never gets evaluated. Perhaps there was a DOM API change? Changing it to use
1033         Selection.removeAllRanges(), which seems like a better function anyway, fixes all the tests
1034         except the first one, which is still broken due to unrelated bug #151654.
1035
1036         * Scripts/run-gtk-tests:
1037         (TestRunner):
1038         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
1039
1040 2017-02-12  Michael Catanzaro  <mcatanzaro@igalia.com>
1041
1042         Unreviewed, skip flaky WebKitPrintOperation/custom-widget test
1043
1044         * Scripts/run-gtk-tests:
1045         (TestRunner):
1046
1047 2017-02-12  Michael Catanzaro  <mcatanzaro@igalia.com>
1048
1049         Unreviewed, skip flaky form-controls-associated-signal test
1050
1051         * Scripts/run-gtk-tests:
1052         (TestRunner):
1053
1054 2017-02-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1055
1056         [GTK] Handle caps lock indicator in event modifiers
1057         https://bugs.webkit.org/show_bug.cgi?id=168186
1058
1059         Reviewed by Michael Catanzaro.
1060
1061         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1062         (WTR::webkitModifiersToGDKModifiers): Handle kWKEventModifiersCapsLockKey.
1063
1064 2017-02-11  Simon Fraser  <simon.fraser@apple.com>
1065
1066         MiniBrowser WK1 fails to update URL for within-page navigations
1067         https://bugs.webkit.org/show_bug.cgi?id=168173
1068
1069         Reviewed by Tim Horton.
1070
1071         Implement -webView:didChangeLocationWithinPageForFrame: so that clicking on named
1072         anchors updates the URL field.
1073
1074         * MiniBrowser/mac/WK1BrowserWindowController.m:
1075         (-[WK1BrowserWindowController webView:didChangeLocationWithinPageForFrame:]):
1076
1077 2017-02-10  John Wilander  <wilander@apple.com>
1078
1079         Updates to Resource Load Statistics: Get the right website data store and introduce timeout for user interaction
1080         https://bugs.webkit.org/show_bug.cgi?id=167474
1081         <rdar://problem/24681808>
1082         <rdar://problem/24703286>
1083         <rdar://problem/30290270>
1084
1085         This patch adds test infrastructure to allow testing
1086         of the various rules in place for data records removal.
1087
1088         Reviewed by Andy Estes.
1089
1090         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1091         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1092         (WTR::InjectedBundle::didReceiveMessageToPage):
1093             Callback mechanism to tell pages that a website data store
1094             scan has happened.
1095         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1096         (WTR::TestRunner::setStatisticsPrevalentResource):
1097         (WTR::TestRunner::isStatisticsPrevalentResource):
1098         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
1099         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
1100         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
1101         (WTR::TestRunner::installStatisticsDidModifyDataRecordsCallback):
1102         (WTR::TestRunner::statisticsDidModifyDataRecordsCallback):
1103         (WTR::TestRunner::statisticsFireDataModificationHandler):
1104         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
1105         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
1106         (WTR::TestRunner::setStatisticsMinimumTimeBetweeenDataRecordsRemoval):
1107         (WTR::TestRunner::statisticsResetToConsistentState):
1108         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1109         * WebKitTestRunner/TestController.cpp:
1110         (WTR::TestController::setStatisticsPrevalentResource):
1111         (WTR::TestController::isStatisticsPrevalentResource):
1112         (WTR::TestController::setStatisticsHasHadUserInteraction):
1113         (WTR::TestController::isStatisticsHasHadUserInteraction):
1114         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
1115         (WTR::TestController::statisticsFireDataModificationHandler):
1116         (WTR::TestController::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
1117         (WTR::TestController::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
1118         (WTR::TestController::setStatisticsMinimumTimeBetweeenDataRecordsRemoval):
1119         (WTR::TestController::statisticsResetToConsistentState):
1120         * WebKitTestRunner/TestController.h:
1121             These are all configuration and test functions.
1122         * WebKitTestRunner/TestInvocation.cpp:
1123         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1124
1125 2017-02-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1126
1127         REGRESSION(r182916) run-perf-tests never timeouts
1128         https://bugs.webkit.org/show_bug.cgi?id=167626
1129
1130         Reviewed by Ryosuke Niwa.
1131
1132         The --time-out-ms value (defaults to 600 seconds) of run-perf-tests
1133         was beeing ignored because the driver was created with no_timeout=True
1134         unconditionally.
1135         This adds a new parameter --no-timeout (disabled by default), that
1136         allows to use the driver with the expected timeout values.
1137         It also passes --no-timeout to DRT/WTR to ensure that timeouts
1138         are always controlled by the Python Driver.
1139
1140         * Scripts/webkitpy/performance_tests/perftest.py:
1141         (PerfTest._create_driver): Only disable timeout if --no-timeout is passed.
1142         (PerfTest.run): Disabling timeout should be done when the Driver is created.
1143         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1144         (PerfTestsRunner.__init__): Ensure --no-timeout is passed to DRT/WTR
1145         (PerfTestsRunner._parse_args): Add a --no-timeout parameter.
1146         (_run_tests_set): Pass the no-timeout parameter.
1147         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1148         (MainTest.test_drt_notimeout): Test --no-timeout is passed to DRT/WTR
1149         (MainTest.test_default_args): Test default values for additional_drt_flag and no_timeout.
1150         (MainTest.test_parse_args): Test that the argument no-timeout.
1151
1152 2017-02-10  Daniel Bates  <dabates@apple.com>
1153
1154         Detach frame from document when entering page cache
1155         https://bugs.webkit.org/show_bug.cgi?id=166774
1156         <rdar://problem/29904368>
1157
1158         Reviewed by Chris Dumez.
1159
1160         * DumpRenderTree/mac/DumpRenderTree.mm:
1161         (resetWebPreferencesToConsistentValues):
1162         * DumpRenderTree/win/DumpRenderTree.cpp:
1163         (resetWebPreferencesToConsistentValues):
1164         * WebKitTestRunner/TestController.cpp:
1165         (WTR::TestController::resetPreferencesToConsistentValues):
1166
1167 2017-02-10  Tim Horton  <timothy_horton@apple.com>
1168
1169         Infinite UI process hang under ensurePositionInformationIsUpToDate
1170         https://bugs.webkit.org/show_bug.cgi?id=168154
1171         <rdar://problem/30428673>
1172
1173         Reviewed by Simon Fraser.
1174
1175         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1176         * TestWebKitAPI/Tests/WebKit2Cocoa/InteractionDeadlockAfterCrash.mm: Added.
1177         (recursiveFindHighlightLongPressRecognizer):
1178         (TEST):
1179         Add a somewhat nasty test that does an async interaction information update, but
1180         kills the Web process before it arrives, and then does a sync interaction
1181         information update, which will wait for the oustanding async interaction
1182         information update if we still think it's coming. Before the patch, this
1183         test times out with the UI process stuck under ensurePositionInformationIsUpToDate.
1184
1185 2017-02-10  Simon Fraser  <simon.fraser@apple.com>
1186
1187         Make sure the "inwindow" flag propagates to TiledBackings for masks and reflections
1188         https://bugs.webkit.org/show_bug.cgi?id=168127
1189         rdar://problem/30467120
1190
1191         Reviewed by Tim Horton.
1192
1193         Reparent the web view before we try to fetch it via:
1194             [[[window contentView] subviews] objectAtIndex:0];
1195         which would throw an exception if the test unparented it.
1196
1197         * DumpRenderTree/mac/DumpRenderTree.mm:
1198         (resetWebViewToConsistentStateBeforeTesting):
1199         (runTest):
1200
1201 2017-02-10  Joseph Pecoraro  <pecoraro@apple.com>
1202
1203         [Resource Timing] Enable Resource Timing by default in Tests
1204         https://bugs.webkit.org/show_bug.cgi?id=168145
1205
1206         Reviewed by Ryosuke Niwa.
1207
1208         * DumpRenderTree/mac/DumpRenderTree.mm:
1209         (resetWebPreferencesToConsistentValues):
1210         * DumpRenderTree/win/DumpRenderTree.cpp:
1211         (resetWebPreferencesToConsistentValues):
1212         * WebKitTestRunner/TestController.cpp:
1213         (WTR::TestController::resetPreferencesToConsistentValues):
1214
1215 2017-02-10  Jonathan Bedard  <jbedard@apple.com>
1216
1217         Removing LayoutTestRelay
1218         https://bugs.webkit.org/show_bug.cgi?id=165927
1219
1220         Reviewed by Daniel Bates.
1221         Part 2
1222
1223         LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
1224         simulators through simctl (iOS 10 and later), use this functionality instead.
1225
1226         * BuildSlaveSupport/built-product-archive:
1227         (archiveBuiltProduct): Remove archiving of LayoutTestRelay as it is no longer being built.
1228         Added a FIXME that we will need to implement similar archiving machinery once we build
1229         ImageDiff for Mac when building WebKit for iOS. Currently ImageDiff is built with the iOS SDK.
1230         * BuildSlaveSupport/kill-old-processes:
1231         (main): Remove LayoutTestRelay from list of processes.
1232         * LayoutTestRelay: Removed LayoutTestRelay.
1233         * Makefile:
1234         * Scripts/build-layouttestrelay: Removed.
1235         * Scripts/build-webkit: Removed LayoutTestRelay references.
1236
1237 2017-02-10  Jiewen Tan  <jiewen_tan@apple.com>
1238
1239         [WebCrypto] Add WebCryptoAPI to watchlist
1240         https://bugs.webkit.org/show_bug.cgi?id=168138
1241
1242         Reviewed by Youenn Fablet.
1243
1244         * Scripts/webkitpy/common/config/watchlist:
1245
1246 2017-02-10  Brady Eidson  <beidson@apple.com>
1247
1248         Replace all WebKit Library Version checks in WK2 with SDK version checks.
1249         https://bugs.webkit.org/show_bug.cgi?id=168124
1250
1251         Reviewed by Geoffrey Garen.
1252
1253         For each of our tools that use WebKit2, opt them in to the new linkedOnOrAfter(Everything) setting.
1254
1255         * MiniBrowser/mac/main.m:
1256         (main):
1257         * MobileMiniBrowser/MobileMiniBrowser/main.m:
1258         (main):
1259         * TestWebKitAPI/ios/mainIOS.mm:
1260         (main):
1261         * TestWebKitAPI/mac/mainMac.mm:
1262         (main):
1263         * WebKitTestRunner/ios/mainIOS.mm:
1264         (main):
1265         * WebKitTestRunner/mac/main.mm:
1266         (setDefaultsToConsistentValuesForTesting):
1267
1268 2017-02-10  Alex Christensen  <achristensen@webkit.org>
1269
1270         Fix El Capitan build.
1271
1272         * Scripts/build-webkit:
1273         Don't build libwebrtc anywhere for now.
1274
1275 2017-02-10  Andy Estes  <aestes@apple.com>
1276
1277         Move two MiniBrowserBundle settings out of the .pbxproj
1278         https://bugs.webkit.org/show_bug.cgi?id=168106
1279
1280         Reviewed by Tim Horton.
1281
1282         INFOPLIST_FILE was specified in MiniBrowserBundle.xcconfig but overridden to "" in
1283         the project file. This removes the project file override.
1284
1285         WRAPPER_EXTENSION was moved from the project file to MiniBrowserBundle.xcconfig.
1286
1287         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig:
1288         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1289
1290 2017-02-10  Alex Christensen  <achristensen@webkit.org>
1291
1292         Fix 32-and-64-bit build on El Capitan.
1293
1294         * Scripts/build-webkit:
1295         Somebody's building with something like this:
1296         build-webkit ARCHS="i386 x86_64"
1297         We want this to also not build libwebrtc for now.
1298
1299 2017-02-10  Alex Christensen  <achristensen@webkit.org>
1300
1301         Fix 32-bit build on El Capitan.
1302
1303         * Scripts/build-webkit:
1304         The bot uses ARCHS=i386 instead of --32-bit.
1305         This is a hack, but it should fix the bot until I can do a better fix in the morning.
1306
1307 2017-02-10  Alex Christensen  <achristensen@webkit.org>
1308
1309         Fix 32-bit build on El Capitan.
1310
1311         * Scripts/build-webkit:
1312         Don't build i386 libwebrtc.
1313
1314 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1315
1316         Unreviewed, rolling out r212040.
1317
1318         Broke build.  I'm not surprised
1319
1320         Reverted changeset:
1321
1322         "[WebRTC][Mac] Activate libwebrtc"
1323         https://bugs.webkit.org/show_bug.cgi?id=167293
1324         http://trac.webkit.org/changeset/212040
1325
1326 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1327
1328         Build libwebrtc on bots without using it yet
1329         https://bugs.webkit.org/show_bug.cgi?id=168062
1330
1331         Reviewed by Brent Fulgham.
1332
1333         * Scripts/build-webkit:
1334
1335 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1336
1337         Don't build libwebrtc.
1338
1339         * Scripts/build-webkit:
1340         Not ready yet.  It broke El Capitan and iOS.
1341
1342 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1343
1344         Build libwebrtc on bots without using it yet
1345         https://bugs.webkit.org/show_bug.cgi?id=168062
1346
1347         Reviewed by Brent Fulgham.
1348
1349         * Scripts/build-webkit:
1350
1351 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1352
1353         Rename isAppleMacWebKit to isAppleCocoaWebKit
1354         https://bugs.webkit.org/show_bug.cgi?id=168075
1355
1356         Reviewed by Geoffrey Garen.
1357
1358         It returns true for Mac and iOS.  "isAppleMacWebKit" is confusing and wrong.
1359
1360         * Scripts/build-api-tests:
1361         * Scripts/build-dumprendertree:
1362         * Scripts/build-jsc:
1363         (buildMyProject):
1364         * Scripts/build-layouttestrelay:
1365         * Scripts/build-webkit:
1366         * Scripts/build-webkittestrunner:
1367         * Scripts/run-api-tests:
1368         (isSupportedPlatform):
1369         (runTest):
1370         (listAllTests):
1371         (prepareEnvironmentForRunningTestTool):
1372         * Scripts/run-content-extension-tester:
1373         * Scripts/run-javascriptcore-tests:
1374         * Scripts/run-minibrowser:
1375         * Scripts/show-pretty-diff:
1376         * Scripts/webkitdirs.pm:
1377         (determineBaseProductDir):
1378         (determineArchitecture):
1379         (determinePassedArchitecture):
1380         (safariPath):
1381         (builtDylibPathForName):
1382         (checkFrameworks):
1383         (isAppleWebKit):
1384         (isAppleCocoaWebKit):
1385         (determineNmPath):
1386         (launcherName):
1387         (wrapperPrefixIfNeeded):
1388         (isCMakeBuild):
1389         (mobileSafariBundle):
1390         (debugSafari):
1391         (runSafari):
1392         (runMiniBrowser):
1393         (debugMiniBrowser):
1394         (runWebKitTestRunner):
1395         (debugWebKitTestRunner):
1396         (isAppleMacWebKit): Deleted.
1397         * Scripts/webkitperl/FeatureList.pm:
1398
1399 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1400
1401         Revert r211991
1402         https://bugs.webkit.org/show_bug.cgi?id=168062
1403
1404         * Scripts/build-webkit:
1405         Not quite ready yet.
1406
1407 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1408
1409         Build libwebrtc on bots without using it yet
1410         https://bugs.webkit.org/show_bug.cgi?id=168062
1411
1412         Reviewed by Brent Fulgham.
1413
1414         * Scripts/build-webkit:
1415         Build libwebrtc on Mac when we build ANGLE.
1416
1417 2017-02-09  Youenn Fablet  <youenn@apple.com>
1418
1419         Improve W3C importer command line options
1420         https://bugs.webkit.org/show_bug.cgi?id=167448
1421
1422         Reviewed by Ryosuke Niwa.
1423
1424         Making the list of test paths to import the main arguments of the script.
1425         Allow passing the source directory to import as a -s option.
1426         Adding a warning when given test paths are skipped by default in ImportExpectations.
1427
1428         Making link conversion off by default when importing from a specific directory since this script is mostly used with web-platform-tests.
1429         Link conversion rules do not change when imported tests are downloaded by the script.
1430
1431         * Scripts/webkitpy/w3c/test_importer.py:
1432         (main):
1433         (parse_args):
1434         (TestImporter.__init__):
1435         (TestImporter.do_import):
1436         (TestImporter):
1437         (TestImporter.check_imported_expectations):
1438
1439 2017-02-08  Chris Dumez  <cdumez@apple.com>
1440
1441         Update web-platform-tests resources
1442         https://bugs.webkit.org/show_bug.cgi?id=168026
1443
1444         Reviewed by Youenn Fablet.
1445
1446         Stop copying testharness.js from resources/ to web-platform-tests/resources.
1447
1448         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1449         (WebPlatformTestServer._copy_webkit_test_files):
1450
1451 2017-02-08  Andy Estes  <aestes@apple.com>
1452
1453         Custom protocols should not continue loading after a network process crash
1454         https://bugs.webkit.org/show_bug.cgi?id=168028
1455         <rdar://problem/27607520>
1456
1457         Reviewed by Brady Eidson.
1458
1459         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1460         (processGroup):
1461         (-[CloseWhileStartingProtocol startLoading]):
1462         (-[CloseWhileStartingProtocol stopLoading]):
1463         (TestWebKitAPI::runTest):
1464         (TestWebKitAPI::TEST):
1465
1466 2017-02-08  Dan Bernstein  <mitz@apple.com>
1467
1468         [Cocoa] WKRemoteObjectCoder doesn’t handle CGSize
1469         https://bugs.webkit.org/show_bug.cgi?id=168031
1470
1471         Reviewed by Tim Horton.
1472
1473         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
1474         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
1475         (TEST):
1476         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
1477         (-[RemoteObjectRegistryPlugIn takeSize:completionHandler:]):
1478
1479 2017-02-08  Chris Dumez  <cdumez@apple.com>
1480
1481         Use smaller tiles in windows that are not active to facilitate App Napping
1482         https://bugs.webkit.org/show_bug.cgi?id=167997
1483         <rdar://problem/30358835>
1484
1485         Reviewed by Simon Fraser.
1486
1487         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1488         (WTR::PlatformWebView::setWindowIsKey):
1489         Actually update windowIsKey state of NSWindow so the WebView
1490         properly updates its activity state.
1491
1492 2017-02-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1493
1494         Add kUTTypeUTF8PlainText and kUTTypeJPEG to the list of compatible content types in DragData
1495         https://bugs.webkit.org/show_bug.cgi?id=167942
1496         <rdar://problem/30315079>
1497
1498         Reviewed by Tim Horton.
1499
1500         Adds a new test case that simulates dragging from a source that only vends JPEG images or UTF8 plaintext into a
1501         contenteditable area. An image element and the plain text content, respectively, should be inserted into the
1502         contenteditable in these cases.
1503
1504         The DragSource and DragInfo are used to mock dragging into the WebView. There is no reliance on using mouse
1505         events in this test, since we call the dragging delegate methods (draggingEntered:, draggingUpdated:, and
1506         performDragOperation:) directly.
1507
1508         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1509         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm: Added.
1510         (+[FrameLoadCompletionListener listenerWithCompletionBlock:]):
1511         (-[FrameLoadCompletionListener initWithCompletionBlock:]):
1512         (-[FrameLoadCompletionListener webView:didFinishLoadForFrame:]):
1513         (-[DragSource draggingSourceOperationMaskForLocal:]):
1514         (-[DragInfo initWithImage:offset:pasteboard:source:destinationWindow:]):
1515         (-[DragInfo lastMousePosition]):
1516         (-[DragInfo setLastMousePosition:]):
1517         (-[DragInfo draggingDestinationWindow]):
1518         (-[DragInfo draggingSourceOperationMask]):
1519         (-[DragInfo draggingLocation]):
1520         (-[DragInfo draggedImageLocation]):
1521         (-[DragInfo draggedImage]):
1522         (-[DragInfo draggingPasteboard]):
1523         (-[DragInfo draggingSource]):
1524         (-[DragInfo draggingSequenceNumber]):
1525         (-[DragInfo slideDraggedImageTo:]):
1526         (-[DragInfo namesOfPromisedFilesDroppedAtDestination:]):
1527         (-[DragInfo draggingFormation]):
1528         (-[DragInfo setDraggingFormation:]):
1529         (-[DragInfo animatesToDestination]):
1530         (-[DragInfo setAnimatesToDestination:]):
1531         (-[DragInfo numberOfValidItemsForDrop]):
1532         (-[DragInfo setNumberOfValidItemsForDrop:]):
1533         (-[DragInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1534         (-[DragInfo springLoadingHighlight]):
1535         (-[DragInfo resetSpringLoading]):
1536         (TestWebKitAPI::getTestImage):
1537         (TestWebKitAPI::webViewAfterPerformingDragOperation):
1538         (TestWebKitAPI::TEST):
1539         * TestWebKitAPI/Tests/mac/full-page-contenteditable.html: Added.
1540
1541 2017-02-08  Jer Noble  <jer.noble@apple.com>
1542
1543         Move FullscreenClient creation into WebViewImpl, for use in (deprecated) WKView.
1544         https://bugs.webkit.org/show_bug.cgi?id=168007
1545
1546         Reviewed by Alex Christensen.
1547
1548         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenDelegate.mm:
1549         (didFinishLoadForFrame):
1550         (TestWebKitAPI::TEST):
1551
1552 2017-02-08  Commit Queue  <commit-queue@webkit.org>
1553
1554         Unreviewed, rolling out r211873.
1555         https://bugs.webkit.org/show_bug.cgi?id=168001
1556
1557         It's in jhbuild for consistent layout tests (Requested by
1558         mcatanzaro on #webkit).
1559
1560         Reverted changeset:
1561
1562         "[GTK] Add icu packages to Tools/gtk/install-dependencies"
1563         https://bugs.webkit.org/show_bug.cgi?id=167993
1564         http://trac.webkit.org/changeset/211873
1565
1566 2017-02-08  Adrian Perez de Castro  <aperez@igalia.com>
1567
1568         [GTK] Add icu packages to Tools/gtk/install-dependencies
1569         https://bugs.webkit.org/show_bug.cgi?id=167993
1570
1571         Reviewed by Michael Catanzaro.
1572
1573         * gtk/install-dependencies: Add "icu" to the list of required packages (or "icu-dev", or "icu-devel"
1574         depending in the GNU/Linux distribution)
1575
1576 2017-02-07  Ryan Haddad  <ryanhaddad@apple.com>
1577
1578         Update flakiness dashboard configuration.
1579         https://bugs.webkit.org/show_bug.cgi?id=167957
1580
1581         Reviewed by Alexey Proskuryakov.
1582
1583         * TestResultServer/static-dashboards/builders.jsonp:
1584
1585 2017-02-07  Ryan Haddad  <ryanhaddad@apple.com>
1586
1587         Replace a bot that has an incorrect configuration.
1588         https://bugs.webkit.org/show_bug.cgi?id=167747
1589
1590         Rubber-stamped by Alexey Proskuryakov.
1591
1592         * BuildSlaveSupport/build.webkit.org-config/config.json:
1593
1594 2017-02-07  Myles C. Maxfield  <mmaxfield@apple.com>
1595
1596         [Win] [GTK] [EFL] Compile (but don't use, yet) the platform-independent piece of ComplexTextController
1597         https://bugs.webkit.org/show_bug.cgi?id=167927
1598
1599         Reviewed by Brent Fulgham.
1600
1601         Enable ComplexTextController API tests on the Win and GTK ports.
1602
1603         * TestWebKitAPI/PlatformGTK.cmake:
1604         * TestWebKitAPI/PlatformWin.cmake:
1605
1606 2017-02-07  Jonathan Bedard  <jbedard@apple.com>
1607
1608         File index appended to previous file in svn-create-patch with SVN 1.9
1609         https://bugs.webkit.org/show_bug.cgi?id=167903
1610         <rdar://problem/30387395>
1611
1612         Reviewed by Daniel Bates.
1613
1614         * Scripts/VCSUtils.pm:
1615         (fixSVNPatchForAdditionWithHistory): Append a trailing newline character.
1616         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Do not remove
1617         trailing newline character from the expected result before comparing it to the actual result.
1618
1619 2017-02-07  Olivier Blin  <olivier.blin@softathome.com>
1620
1621         [webkitdirs] remove unused host_processor variable in determineArchitecture()
1622         https://bugs.webkit.org/show_bug.cgi?id=167936
1623
1624         Reviewed by Michael Catanzaro.
1625
1626         * Scripts/webkitdirs.pm:
1627         (determineArchitecture):
1628         The host_processor variable in webkitdirs.pm's determineArchitecture() is not used anymore,
1629         since r195083.
1630
1631 2017-02-07  Youenn Fablet  <youenn@apple.com>
1632
1633         Use a JSON file to define which WPT files/folders to import
1634         https://bugs.webkit.org/show_bug.cgi?id=167923
1635
1636         Reviewed by Alex Christensen.
1637
1638         * Scripts/webkitpy/w3c/test_downloader.py:
1639         (TestDownloader.__init__):
1640         (TestDownloader._init_paths_from_expectations):
1641         * Scripts/webkitpy/w3c/test_importer.py:
1642         (parse_args):
1643         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1644
1645 2017-02-06  Fujii Hironori  <Hironori.Fujii@sony.com>
1646
1647         [GTK] jhbuild fails: mesa-11.0.6.tar.xz: 404 Not Found
1648         https://bugs.webkit.org/show_bug.cgi?id=167916
1649
1650         Reviewed by Carlos Garcia Campos.
1651
1652         URL of mesa-11.0.6.tar.xz has been moved.
1653
1654         * gtk/jhbuild.modules: Fix the module path.
1655
1656 2017-02-06  Joseph Pecoraro  <pecoraro@apple.com>
1657
1658         Static Analyzer: Address some leaks in MiniBrowser
1659         https://bugs.webkit.org/show_bug.cgi?id=167897
1660
1661         Reviewed by Alexey Proskuryakov.
1662
1663         * MiniBrowser/mac/BrowserWindowController.m:
1664         (-[BrowserWindowController sharingService:transitionImageForShareItem:contentRect:]):
1665         * MiniBrowser/mac/ExtensionManagerWindowController.m:
1666         (-[ExtensionManagerWindowController add:]):
1667         (-[ExtensionManagerWindowController remove:]):
1668         * MiniBrowser/mac/SettingsController.m:
1669         (-[SettingsController _populateMenu]):
1670         (-[SettingsController togglePerWindowWebProcessesDisabled:]):
1671         Address obvious leaks caught by the static analyzer.
1672
1673 2017-02-06  Myles C. Maxfield  <mmaxfield@apple.com>
1674
1675         Migrate ComplexTextController to use platform-independent types
1676         https://bugs.webkit.org/show_bug.cgi?id=167833
1677
1678         Reviewed by Brent Fulgham.
1679
1680         Migrate tests away from platform-dependent types.
1681
1682         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
1683         (TestWebKitAPI::TEST_F):
1684
1685 2017-02-06  Brent Fulgham  <bfulgham@apple.com>
1686
1687         Correct File Path Handling in SecurityOrigin and FileSystem
1688         https://bugs.webkit.org/show_bug.cgi?id=167894
1689         <rdar://problem/30380080>
1690
1691         Reviewed by Alexey Proskuryakov.
1692
1693         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp: Don't encode the temporary files,
1694         and perform same-volume checks using filesystem-compatible paths.
1695         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Create SecurityOrigins from
1696         filesystem paths, and perform validation of same-volume checks.
1697         (TestWebKitAPI::SecurityOriginTest::tempFilePath): Added.
1698         (TestWebKitAPI::SecurityOriginTest::spaceContainingFilePath): Added.
1699         (TestWebKitAPI::SecurityOriginTest::bangContainingFilePath): Added.
1700         (TestWebKitAPI::SecurityOriginTest::quoteContainingFilePath): Added.
1701
1702 2017-02-06  Jer Noble  <jer.noble@apple.com>
1703
1704         Playback stalls when a SourceBuffer append causes frame eviction
1705         https://bugs.webkit.org/show_bug.cgi?id=167834
1706
1707         Reviewed by Eric Carlson.
1708
1709         Add new correctness tests for the Webcore::SampleMap class. Add additional subtests
1710         for the WTF::MediaTime class.
1711
1712         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1713         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
1714         (TestWebKitAPI::TEST):
1715         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp: Added.
1716         (WTF::operator<<):
1717         (TestWebKitAPI::TestSample::create):
1718         (TestWebKitAPI::TestSample::TestSample):
1719         (TestWebKitAPI::TEST_F):
1720
1721 2017-02-06  Ryan Haddad  <ryanhaddad@apple.com>
1722
1723         Change capitalization in platform name after r211735.
1724
1725         Unreviewed dashboard fix.
1726
1727         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1728         (WebKitBuildbot):
1729
1730 2017-02-06  Alexey Proskuryakov  <ap@apple.com>
1731
1732         Move the Leaks bot to Sierra
1733         https://bugs.webkit.org/show_bug.cgi?id=167886
1734
1735         Reviewed by Daniel Bates.
1736
1737         * BuildSlaveSupport/build.webkit.org-config/config.json:
1738         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1739         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
1740         (LeaksViewer._displayURLPrompt):
1741         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1742         (WebKitBuildbot):
1743
1744 2017-02-06  Jonathan Bedard  <jbedard@apple.com>
1745
1746         Prevent app crash on launch during simctl install workaround
1747         https://bugs.webkit.org/show_bug.cgi?id=167685
1748
1749         Reviewed by Daniel Bates.
1750
1751         * Scripts/webkitpy/port/simulator_process.py:
1752         (SimulatorProcess.__init__): Pass environment to install.
1753         * Scripts/webkitpy/xcode/simulator.py:
1754         (Device.install_app): Accept environment, pass environment to launch.
1755
1756 2017-02-06  Alex Christensen  <achristensen@webkit.org>
1757
1758         Rebase API tests after r211638
1759         https://bugs.webkit.org/show_bug.cgi?id=167779
1760
1761         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1762         (TestWebKitAPI::TEST_F):
1763         URLs with non-special schemes and characters like % in the host now fail to parse,
1764         more like their special counterparts and according to spec.
1765
1766 2017-02-06  Csaba Osztrogonác  <ossy@webkit.org>
1767
1768         Unreviewed trivial fix after r211697.
1769         https://bugs.webkit.org/show_bug.cgi?id=167863
1770
1771         * Scripts/run-javascriptcore-tests:
1772         (runJSCStressTests): Renamed ES6SampleBench to ARES-6.
1773
1774 2017-02-04  Simon Fraser  <simon.fraser@apple.com>
1775
1776         Clean up how GraphicsLayer's "inWindow" state is set, and fix some issues with Page Overlays
1777         https://bugs.webkit.org/show_bug.cgi?id=167850
1778
1779         Reviewed by Tim Horton.
1780
1781         * DumpRenderTree/TestRunner.cpp:
1782         (TestRunner::uiScriptDidComplete): Fix an assertion that fires for non-16-bit strings.
1783
1784 2017-02-04  Andreas Kling  <akling@apple.com>
1785
1786         Plug some leaks in TestController and UIScriptContext.
1787         <https://webkit.org/b/167839>
1788
1789         Reviewed by Alexey Proskuryakov.
1790
1791         Fix a couple of the leaks seen on the leaks bot.
1792
1793         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
1794         (UIScriptContext::runUIScript):
1795         * WebKitTestRunner/TestController.cpp:
1796         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin):
1797         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
1798
1799 2017-02-03  Jeremy Jones  <jeremyj@apple.com>
1800
1801         WK1 mouse events are missing movementX and movementY for pointerlock.
1802         https://bugs.webkit.org/show_bug.cgi?id=167775
1803         rdar://problem/30343810
1804
1805         Reviewed by Alexey Proskuryakov.
1806
1807         Set kCGMouseEventDeltaX and kCGMouseEventDeltaY when synthesizing mouse move events.
1808
1809         * DumpRenderTree/mac/EventSendingController.mm:
1810         (-[EventSendingController mouseMoveToX:Y:]):
1811         * WebKitTestRunner/mac/EventSenderProxy.mm:
1812         (WTR::EventSenderProxy::mouseMoveTo):
1813
1814 2017-02-03  Simon Fraser  <simon.fraser@apple.com>
1815
1816         Correctly set the "inWindow" flag for TileControllers that aren't the page tiles, and clarify "usingTiledBacking" logic
1817         https://bugs.webkit.org/show_bug.cgi?id=167774
1818
1819         Reviewed by Tim Horton.
1820
1821         Implement UIScriptController removeViewFromWindow() and addViewToWindow(), and hook
1822         up for Mac WK1 and WK2, and iOS WK2. It takes a callback because view state updates to the
1823         web process are async, so the callback fires after the web process gets the new state.
1824
1825         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1826         (WTR::UIScriptController::removeViewFromWindow):
1827         (WTR::UIScriptController::addViewToWindow):
1828         * DumpRenderTree/mac/DumpRenderTree.mm:
1829         (createWebViewAndOffscreenWindow):
1830         (resetWebViewToConsistentStateBeforeTesting):
1831         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1832         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1833         (WTR::UIScriptController::removeViewFromWindow):
1834         (WTR::UIScriptController::addViewToWindow):
1835         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1836         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1837         (WTR::UIScriptController::removeViewFromWindow):
1838         (WTR::UIScriptController::addViewToWindow):
1839         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1840         * WebKitTestRunner/PlatformWebView.h:
1841         * WebKitTestRunner/TestController.cpp:
1842         (WTR::TestController::resetStateToConsistentValues):
1843         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1844         (WTR::PlatformWebView::removeFromWindow):
1845         (WTR::PlatformWebView::addToWindow):
1846         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1847         (WTR::UIScriptController::removeViewFromWindow):
1848         (WTR::UIScriptController::addViewToWindow):
1849         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1850         (WTR::PlatformWebView::removeFromWindow):
1851         (WTR::PlatformWebView::addToWindow):
1852         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1853         (WTR::UIScriptController::removeViewFromWindow):
1854         (WTR::UIScriptController::addViewToWindow):
1855
1856 2017-02-03  Alexey Proskuryakov  <ap@apple.com>
1857
1858         Remove check for SkipSafariExecutableEntitlementChecks
1859         https://bugs.webkit.org/show_bug.cgi?id=167762
1860
1861         Reviewed by Dan Bernstein.
1862
1863         Follow-up fix: don't break internal behavior.
1864
1865         * Scripts/webkitdirs.pm:
1866         (safariPath):
1867         (executableHasEntitlements): Deleted.
1868         (safariPathFromSafariBundle): Deleted.
1869         (installedSafariPath): Deleted.
1870
1871 2017-02-03  Daniel Bates  <dabates@apple.com>
1872
1873         [Mac][WK2] Add SPI to override the Content Security Policy of a page
1874         https://bugs.webkit.org/show_bug.cgi?id=167810
1875         <rdar://problem/30102568>
1876
1877         Reviewed by Anders Carlsson.
1878
1879         Add tests to ensure that we do not regress -[WKWebView _setOverrideContentSecurityPolicy:].
1880
1881         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1882         * TestWebKitAPI/Tests/WebKit2Cocoa/OverrideContentSecurityPolicy.mm: Added.
1883         (TEST):
1884         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp-iframe.html: Added.
1885         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp.html: Added.
1886         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp-iframe.html: Added.
1887         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp.html: Added.
1888
1889 2017-02-02  Alex Christensen  <achristensen@webkit.org>
1890
1891         URLParser: Fix parsing invalid IPv4 addresses with non-ASCII characters
1892         https://bugs.webkit.org/show_bug.cgi?id=167773
1893         <rdar://problem/30221102>
1894
1895         Reviewed by Ryosuke Niwa.
1896
1897         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1898         (TestWebKitAPI::TEST_F):
1899
1900 2017-02-02  Alexey Proskuryakov  <ap@apple.com>
1901
1902         Remove check for SkipSafariExecutableEntitlementChecks
1903         https://bugs.webkit.org/show_bug.cgi?id=167762
1904         rdar://problem/22480673
1905
1906         Reviewed by Dan Bernstein.
1907
1908         * Scripts/webkitdirs.pm:
1909         (safariPathFromSafariBundle):
1910         (skipSafariExecutableEntitlementChecks): Deleted.
1911
1912 2017-02-02  Jonathan Bedard  <jbedard@apple.com>
1913
1914         Undefined subroutine in svn-create-patch
1915         https://bugs.webkit.org/show_bug.cgi?id=167742
1916
1917         Unreviewed build-fix after r211543.
1918
1919         * Scripts/VCSUtils.pm: fixSVNPatchForAdditionWithHistory was not exported.
1920
1921 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1922
1923         Unreviewed. Fix jhbuild dependencies build.
1924
1925         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch:
1926         Patch updated.
1927
1928 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1929
1930         [EME][GStreamer] Fixed decryptor selection
1931         https://bugs.webkit.org/show_bug.cgi?id=167588
1932
1933         Reviewed by Žan Doberšek.
1934
1935         This patches are pending at https://bugzilla.gnome.org/show_bug.cgi?id=770107
1936
1937         * gtk/jhbuild.modules: Added patches to gstreamer and
1938         gst-plugins-good packages.
1939         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch: Added.
1940         * gtk/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
1941
1942 2017-02-01  Dewei Zhu  <dewei_zhu@apple.com>
1943
1944         Make run-benchmark script supports 'config' key in test plan.
1945         https://bugs.webkit.org/show_bug.cgi?id=167715
1946
1947         Reviewed by Ryosuke Niwa.
1948
1949         Add support for 'config' key in test paln.
1950         'config' key is a dictionary that specifies environment configurations while test is running.
1951         Specifies orientation to be portrait in MotionMark benchmark.
1952
1953         * Scripts/webkitpy/benchmark_runner/README.md:
1954         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1955         (BenchmarkRunner.__init__):
1956         (BenchmarkRunner._run_benchmark):
1957         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1958         (BrowserDriver.prepare_env):
1959         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
1960         (LinuxBrowserDriver.prepare_env):
1961         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1962         (OSXBrowserDriver.prepare_env):
1963         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1964         (OSXSafariDriver.prepare_env):
1965         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
1966
1967 2017-02-01  Daniel Bates  <dabates@apple.com>
1968
1969         REGRESSION (r210820): svn-create-patch does not emit property change only diff
1970         https://bugs.webkit.org/show_bug.cgi?id=167169
1971
1972         Reviewed by David Kilzer.
1973
1974         More directly handle the SVN 1.9 or newer syntax change for a diff of a copied or moved file
1975         - a SVN diff header and an empty body. In particular, remove a duplicate leading SVN diff
1976         header from the output of "svn diff" on a file that was copied or moved.
1977
1978         Following r210820 svn-create-patch emits to standard output a diff only if it has at least one
1979         chunk range line (e.g. @@ -0,0 +1,7 @@) as a means to workaround a syntax change in the diff
1980         output of a copied or moved file in SVN version 1.9 or newer. In SVN 1.9 or newer "svn diff"
1981         of a copied or moved file always emits to standard output a leading SVN diff header (an "Index:"
1982         line followed by a separator line) with an empty body; => no chunk range lines. However a diff
1983         of a file with only a property change also does not contain any chunk range lines. Therefore
1984         svn-create-patch no longer emitted to standard output such a diff. Instead of indirectly detecting
1985         a SVN diff header with an empty body by counting the number of chunk range lines in the diff
1986         we should directly test for the presence of a leading SVN diff header with an empty body and
1987         remove such lines from the diff.
1988
1989         * Scripts/VCSUtils.pm:
1990         (fixSVNPatchForAdditionWithHistory): Added.
1991         * Scripts/svn-create-patch:
1992         (generateDiff): Pass the output from "svn diff" to fixSVNPatchForAdditionWithHistory() when
1993         we have a non empty patch for an added file with history (i.e. a copied or moved file).
1994         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Added.
1995
1996 2017-02-01  Eric Carlson  <eric.carlson@apple.com>
1997
1998         [Mac] Update CARingBuffer class
1999         https://bugs.webkit.org/show_bug.cgi?id=167656
2000
2001         Reviewed by Jer Noble.
2002
2003         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2004         * TestWebKitAPI/Tests/WebCore/CARingBuffer.cpp: Added.
2005         (TestWebKitAPI::CARingBufferTest::SetUp):
2006         (TestWebKitAPI::CARingBufferTest::setup):
2007         (TestWebKitAPI::CARingBufferTest::setListDataBuffer):
2008         (TestWebKitAPI::CARingBufferTest::description):
2009         (TestWebKitAPI::CARingBufferTest::bufferList):
2010         (TestWebKitAPI::CARingBufferTest::ringBuffer):
2011         (TestWebKitAPI::CARingBufferTest::capacity):
2012         (TestWebKitAPI::CARingBufferTest::audioBufferListSizeForStream):
2013         (TestWebKitAPI::CARingBufferTest::configureBufferListForStream):
2014         (TestWebKitAPI::TEST_F):
2015         (TestWebKitAPI::MixingTest::run):
2016
2017 2017-02-01  Alexey Proskuryakov  <ap@apple.com>
2018
2019         [Mac] TestWebKitAPI includes system frameworks incorrectly
2020         https://bugs.webkit.org/show_bug.cgi?id=167703
2021         rdar://problem/30301498
2022
2023         Reviewed by Ryosuke Niwa.
2024
2025         FRAMEWORK_SEARCH_PATH results in frameworks being treated as user ones, not system.
2026         Make TestWebKitAPI use -iframework instead, like the rest of WebKit does.
2027
2028         Also, reduced the number of subframework search paths, looks like we only need one now.
2029
2030         * TestWebKitAPI/Configurations/Base.xcconfig:
2031
2032 2017-02-01  Brent Fulgham  <bfulgham@apple.com>
2033
2034         Correct "filesHaveSameVolume" predicate
2035         https://bugs.webkit.org/show_bug.cgi?id=167696
2036         <rdar://problem/30298722>
2037
2038         Reviewed by David Kilzer.
2039
2040         Add new tests that confirm that the 'filesHaveSamePath' predicate properly handles
2041         percent-escaped path inputs.
2042
2043         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
2044         (TestWebKitAPI::FileSystemTest::spaceContainingFilePath):
2045         (TestWebKitAPI::FileSystemTest::bangContainingFilePath):
2046         (TestWebKitAPI::FileSystemTest::quoteContainingFilePath):
2047         (TestWebKitAPI::TEST_F):
2048
2049 2017-02-01  Tomas Popela  <tpopela@redhat.com>
2050
2051         Unreviewed. Fix coding style in MiniBrowser
2052
2053         * MiniBrowser/gtk/BrowserWindow.c:
2054         (editingCommandCallback):
2055         (insertImageCommandCallback):
2056         (insertLinkCommandCallback):
2057
2058 2017-02-01  Tomas Popela  <tpopela@redhat.com>
2059
2060         [GTK] Add an API to add a custom tab into the print dialog
2061         https://bugs.webkit.org/show_bug.cgi?id=151998
2062
2063         Reviewed by Carlos Garcia Campos.
2064
2065         Add a new WebKitPrintOperation/custom-widget test in TestPrinting
2066         that is testing a newly added API.
2067
2068         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
2069         (testPrintCustomWidget):
2070         (beforeAll):
2071
2072 2017-02-01  Enrique Ocaña González  <eocanha@igalia.com>
2073
2074         [GStreamer][MSE] qtdemux: Update the tfdt patch to the version finally accepted upstream
2075         https://bugs.webkit.org/show_bug.cgi?id=166529
2076
2077         Reviewed by Xabier Rodriguez-Calvar.
2078
2079         * gtk/patches/gst-plugins-good-use-the-tfdt-decode-time.patch:
2080         New patch version accepted in GStreamer upstream.
2081
2082 2017-02-01  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2083
2084         [GTK] Install either libxfont1-dev or libxfont-dev as dependency
2085         https://bugs.webkit.org/show_bug.cgi?id=167498
2086
2087         Reviewed by Carlos Garcia Campos.
2088
2089         Depending on the distro version you can need either libxfont1-dev
2090         or libfont-dev to build with jhbuild.
2091
2092         * gtk/install-dependencies:
2093
2094 2017-01-31  Ryan Haddad  <ryanhaddad@apple.com>
2095
2096         Disable API test WebKit2.WKWebProcessPlugInRangeHandle
2097         https://bugs.webkit.org/show_bug.cgi?id=167594
2098
2099         Unreviewed test gardening.
2100
2101         Disabling this test while we investigate the cause of a timeout on ios-simulator.
2102
2103         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
2104         (TEST):
2105
2106 2017-01-31  Filip Pizlo  <fpizlo@apple.com>
2107
2108         Move slow-running microbenchmarks out of JSTests/microbenchmarks
2109         https://bugs.webkit.org/show_bug.cgi?id=167676
2110
2111         Reviewed by Saam Barati.
2112
2113         * Scripts/run-javascriptcore-tests:
2114         (runJSCStressTests): Add slowMicrobenchmarks.yaml.
2115
2116 2017-01-31  Megan Gardner  <megan_gardner@apple.com>
2117
2118         Make Dump Render Tree not crash
2119         https://bugs.webkit.org/show_bug.cgi?id=167667
2120
2121         DumpRenderTree is crashing when running WK2 tests that it's not supposed to be running.
2122         DumpRenderTree uses RunLoop::main.dispatch(), but that crashes because it's not set up on iOS.
2123         So we're making use of RunWebThread, which is the correct thing to do on iOS, and it doesn't crash.
2124         This does not fix any tests, it just fixes the crash.
2125
2126         Reviewed by Simon Fraser.
2127
2128         * DumpRenderTree/TestRunner.cpp:
2129         (TestRunner::callUIScriptCallback):
2130
2131 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
2132
2133         Workaround for simctl install failing to report install failure
2134         https://bugs.webkit.org/show_bug.cgi?id=167654
2135
2136         Reviewed by Daniel Bates.
2137
2138         simctl install will sometimes report success even though install has failed.
2139         To workaround this bug, we attempt an app launch after install to ensure
2140         install has succeeded.
2141
2142         * Scripts/webkitpy/xcode/simulator.py:
2143         (Device.install_app): Attempt app launch after install, retry install if launch fails.
2144         (Device.launch_app): Correct comment.
2145
2146 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
2147
2148         Unreviewed webkitpy fix after r211405.
2149
2150         * Scripts/webkitpy/xcode/simulator.py:
2151         (Device.launch_app): Remove @staticmethod on _log_debug_error.
2152
2153 2017-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2154
2155         Unreviewed. Do not include libwebrtc and qunit in GTK+ tarballs.
2156
2157         * gtk/manifest.txt.in:
2158
2159 2017-01-31  Chris Fleizach  <cfleizach@apple.com>
2160
2161         AX: enable search predication for iOS
2162         https://bugs.webkit.org/show_bug.cgi?id=167558
2163         <rdar://problem/30251367>
2164
2165         Reviewed by Joanmarie Diggs.
2166
2167         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2168         (AccessibilityUIElement::uiElementForSearchPredicate):
2169         * DumpRenderTree/mac/AccessibilityCommonMac.h:
2170         * DumpRenderTree/mac/AccessibilityCommonMac.mm:
2171         (searchPredicateParameterizedAttributeForSearchCriteria):
2172         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2173         (searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
2174         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2175         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
2176         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2177         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:
2178         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm:
2179         (WTR::searchPredicateParameterizedAttributeForSearchCriteria):
2180         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2181         (WTR::searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
2182         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2183
2184 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
2185
2186         Workaround for simctl launch bug
2187         https://bugs.webkit.org/show_bug.cgi?id=167613
2188
2189         Reviewed by Daniel Bates.
2190
2191         simctl launch will sometimes fail because of a race condition when many
2192         simulators are being run simultaneously. These failures will always have
2193         an exit code of 1. This change attempts to launch an app multiple times
2194         before reporting a failure to workaround this bug.
2195
2196         * Scripts/webkitpy/xcode/simulator.py:
2197         (Device.launch_app): Execute multiple launch attempts, better logging of failures.
2198
2199 2017-01-30  Alexey Proskuryakov  <ap@apple.com>
2200
2201         Commit queue fails to look at real name aliases for the reviewer
2202         https://bugs.webkit.org/show_bug.cgi?id=167422
2203
2204         Reviewed by Joseph Pecoraro.
2205
2206         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2207         (test_has_valid_reviewer): Added tests.
2208
2209         * Scripts/webkitpy/common/config/committers.py:
2210         (CommitterList._name_to_contributor_map):
2211         Made _name_to_contributor_map include alias names.
2212
2213         * Scripts/webkitpy/common/config/committers_unittest.py:
2214         (CommittersTest.test_contributors_by_fuzzy_match):
2215         Removed subtests that are now obsolete, as these matches are strict. It is not
2216         obvious if distance based fuzzy matching for names is useful at all, but we can
2217         look into that some other time.
2218
2219 2017-01-30  Aakash Jain  <aakash_jain@apple.com>
2220
2221         QueueStatusServer should have an explicit timeout for _fetch_url
2222         https://bugs.webkit.org/show_bug.cgi?id=167467
2223
2224         Reviewed by Alexey Proskuryakov.
2225
2226         * Scripts/webkitpy/common/net/statusserver.py:
2227         (StatusServer._fetch_url): Add an explicit timeout of 300s.
2228
2229 2017-01-30  Kocsen Chung  <kocsen_chung@apple.com>
2230
2231         Add support for Trac instances that host multiple projects.
2232         https://bugs.webkit.org/show_bug.cgi?id=167524
2233
2234         Reviewed by Alexey Proskuryakov.
2235
2236         When multiple projects are hosted on a single Trac instance, the current
2237         behavior will retrieve changesets from all tracked projects.
2238         This patch teaches Trac.js to get project-specific changesets from Trac.
2239         We do this by replacing the parameter `changeset=on` to `repo-projectname=on`
2240         when querying the Trac timeline.
2241
2242         To tell Trac to be aware of multi-project instances we leverage the
2243         `options` parameter when creating a new instance:
2244
2245             new Trac("https://mytrac.com/", { projectIdentifier: "tracProjectName" });
2246
2247         If this option is not provided, the original behaviour will prevail.
2248         Additionally, add corresponding tests.
2249
2250         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
2251         (Trac): Reason about new optional parameter 'projectIdentifier'.
2252         (Trac.prototype.revisionURL): Given a projectIdentifier, append it to the end of the URL.
2253         (Trac.prototype._xmlTimelineURL): Given a projectIdentifier,
2254         replace default parameter `changeset=on` with `repo-projectname=on`.
2255         (Trac.prototype._convertCommitInfoElementToObject): Fix missing ';'.
2256         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js:
2257         (MockTrac): Add support for instantiating Trac with a projectIdentifier.
2258         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
2259         (setup): Provide a multiple-project MockTrac instance to all test cases for testing.
2260         Add the following tests:
2261             test("revisionURL")
2262             test("revisionURL with Trac Identifier")
2263             test("_xmlTimelineURL")
2264             test("_xmlTimelineURL with Trac Identifier")
2265         (this.view._latestProductiveIteration): Fix missing ';'.
2266
2267 2017-01-30  Myles C. Maxfield  <mmaxfield@apple.com>
2268
2269         Correct spacing regression on inter-element complex path shaping on some fonts
2270         https://bugs.webkit.org/show_bug.cgi?id=166013
2271
2272         Reviewed by Simon Fraser.
2273
2274         Unskip existing tests and make some new tests:
2275         - Testing complex text with no origins
2276         - Testing initial expansions
2277         - Testing the sign of vertical advances
2278
2279         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
2280         (TestWebKitAPI::TEST_F):
2281
2282 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2283
2284         [GTK][EFL] Avoid using a thin directory to create the built product on the archive-built-product step.
2285         https://bugs.webkit.org/show_bug.cgi?id=167596
2286
2287         Reviewed by Daniel Bates.
2288
2289         We avoid needing a thin directory by invoking the zip program with
2290         the list of directories from the build directory to be zipped,
2291         and by using the zip feature to exclude files matching a pattern.
2292
2293         * BuildSlaveSupport/built-product-archive:
2294         (copyBuildFiles):
2295         (createZipFromList):
2296         (archiveBuiltProduct):
2297
2298 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
2299
2300         Use simctl instead of LayoutTestRelay
2301         https://bugs.webkit.org/show_bug.cgi?id=165927
2302
2303         Reviewed by Daniel Bates.
2304
2305         Part 1
2306
2307         LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
2308         simulators through simctl (iOS 10 and later), use this functionality instead.
2309
2310         * Scripts/webkitpy/port/base.py:
2311         (Port.__init__): Added _test_runner_process_constructor.
2312         * Scripts/webkitpy/port/darwin.py:
2313         (DarwinPort.app_identifier_from_bundle): Added function to extract bundle ID from plist.
2314         * Scripts/webkitpy/port/driver.py:
2315         (Driver._start): Pass worker_number to server_process so we can look up the correct simulator device to use.
2316         (IOSSimulatorDriver): Deleted.
2317         * Scripts/webkitpy/port/driver_unittest.py:
2318         (DriverTest.test_stop_cleans_up_properly): Set _test_runner_process_constructor for testing.
2319         (DriverTest.test_two_starts_cleans_up_properly): Ditto.
2320         (DriverTest.test_start_actually_starts): Ditto.
2321         * Scripts/webkitpy/port/ios.py:
2322         (IOSSimulatorPort): Remove relay_name.
2323         (IOSSimulatorPort.__init__): Set _test_runner_process_constructor to SimulatorProcess for IOSSimulatorPort.
2324         (IOSSimulatorPort._create_simulators): Formatting change.
2325         (IOSSimulatorPort.relay_path): Deleted.
2326         (IOSSimulatorPort._check_relay): Deleted.
2327         (IOSSimulatorPort._check_port_build): Deleted. Use base class implementation
2328         (IOSSimulatorPort._build_relay): Deleted.
2329         (IOSSimulatorPort._build_driver): Deleted. Use base class implementation
2330         (IOSSimulatorPort._driver_class): Deleted. Use base class implementation
2331         * Scripts/webkitpy/port/ios_unittest.py:
2332         (iosTest.test_32bit): Update test.
2333         (iosTest.test_64bit): Update test.
2334         * Scripts/webkitpy/port/server_process.py:
2335         (ServerProcess.__init__): Added argument worker_number. This class does not make use of it. We will make use of this argument in SimulatorProcess to lookup the associated simulator device.
2336         (ServerProcess._set_file_nonblocking): Added to share common code.
2337         * Scripts/webkitpy/port/server_process_mock.py:
2338         (MockServerProcess.__init__): Added argument worker_number.
2339         * Scripts/webkitpy/port/simulator_process.py: Added.
2340         (SimulatorProcess): Added.
2341         (SimulatorProcess.Popen): Added.
2342         (SimulatorProcess.Popen.__init__): Added. Initialize Popen structure with stdin, stdout, stderr and pid.
2343         (SimulatorProcess.Popen.poll): Added. Check if the process is running.
2344         (SimulatorProcess.Popen.wait): Added. Wait for process to close.
2345         (SimulatorProcess.__init__): Added. Install app to device specified through port and worker_number.
2346         (SimulatorProcess._reset): Added. Unlink fifos.
2347         (SimulatorProcess._start): Added. Launch app on simulator, link fifos.
2348         (SimulatorProcess._kill): Added. Shutdown app on simulator.
2349         * Scripts/webkitpy/xcode/simulator.py:
2350         (Device.__init__): Accept host to run install/launch/terminate.
2351         (Device.install_app): Install app to target Device.
2352         (Device.launch_app): Launch app on target Device.
2353         (Device.terminate_app): Shutdown app on target Device.
2354         (Simulator._parse_devices): Pass host to Device.
2355
2356 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2357
2358         [GTK] pixman fails to compile on Raspberry Pi (GCC crash)
2359         https://bugs.webkit.org/show_bug.cgi?id=167411
2360
2361         Reviewed by Michael Catanzaro.
2362
2363         Disable the ARM iwMMXt fast path for pixman, because it triggers
2364         a GCC bug on the RPi with Raspbian/PIXEL causing a build failure.
2365
2366         * gtk/jhbuild.modules:
2367
2368 2017-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2369
2370         [GTK] Add API to handle the accelerated compositing policy
2371         https://bugs.webkit.org/show_bug.cgi?id=167509
2372
2373         Reviewed by Michael Catanzaro.
2374
2375         Handle new setting in MiniBrowser. The settings dialog doesn't support enum settings so it needs to be handled
2376         as a special case. Also add test cases to the get/set API.
2377
2378         * MiniBrowser/gtk/BrowserSettingsDialog.c:
2379         (hardwareAccelerationPolicyToString):
2380         (stringToHardwareAccelerationPolicy):
2381         (cellRendererChanged):
2382         (browserSettingsDialogConstructed):
2383         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
2384         (testWebKitSettings):
2385
2386 2017-01-29  Andy Estes  <aestes@apple.com>
2387
2388         [QuickLook] Add a WebPreference to enable saving QuickLook documents in WebKitLegacy
2389         https://bugs.webkit.org/show_bug.cgi?id=167563
2390         <rdar://problem/30253207>
2391
2392         Reviewed by Andreas Kling.
2393
2394         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm:
2395         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
2396         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
2397         (runTest):
2398         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
2399         (TEST):
2400
2401 2017-01-29  Dan Bernstein  <mitz@apple.com>
2402
2403         [iOS] Expose WebCore::DataDetection::detectContentInRange WKWebProcessPlugInRangeHandle
2404         https://bugs.webkit.org/show_bug.cgi?id=167565
2405
2406         Reviewed by Sam Weinig.
2407
2408         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2409         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm: Added.
2410         (-[BundleRangeHandleRemoteObject textFromBodyRange:]):
2411         (-[BundleRangeHandleRemoteObject bodyInnerHTMLAfterDetectingData:]):
2412         (TEST):
2413         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandlePlugIn.mm: Added.
2414         (-[BundleRangeHandlePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2415         (-[BundleRangeHandlePlugIn webProcessPlugInBrowserContextController:didFinishDocumentLoadForFrame:]):
2416         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandleProtocol.h: Added.
2417
2418 2017-01-28  Yoav Weiss  <yoav@yoav.ws>
2419
2420         Add Link Preload as an off-by-default experimental feature menu item.
2421         https://bugs.webkit.org/show_bug.cgi?id=167201
2422
2423         Reviewed by Ryosuke Niwa.
2424
2425         * DumpRenderTree/mac/DumpRenderTree.mm:
2426         (resetWebPreferencesToConsistentValues):
2427         * DumpRenderTree/win/DumpRenderTree.cpp:
2428         (resetWebPreferencesToConsistentValues):
2429
2430 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
2431
2432         Add User Timing Experimental Feature
2433         https://bugs.webkit.org/show_bug.cgi?id=167542
2434         <rdar://problem/22746307>
2435
2436         Reviewed by Ryosuke Niwa.
2437
2438         * DumpRenderTree/mac/DumpRenderTree.mm:
2439         (enableExperimentalFeatures):
2440         (resetWebPreferencesToConsistentValues):
2441         * DumpRenderTree/win/DumpRenderTree.cpp:
2442         (enableExperimentalFeatures):
2443
2444 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
2445
2446         Patch Review: EWS Bubbles wrap to multiple lines but can fit on one line
2447         https://bugs.webkit.org/show_bug.cgi?id=167519
2448
2449         Reviewed by Ryosuke Niwa.
2450
2451         * QueueStatusServer/templates/statusbubble.html:
2452         To measure the bubbleContainer's width, it must not be wrapping based
2453         on its parent container. So when measuring the width temporarily set
2454         the parent to a very large width so as to not artificially wrap us.
2455         Restore the parent's width after measuring.
2456
2457 2017-01-27  Andy Estes  <aestes@apple.com>
2458
2459         [iOS] Add a test for _WKNSFileManagerExtras
2460         https://bugs.webkit.org/show_bug.cgi?id=167478
2461
2462         Reviewed by Andreas Kling.
2463
2464         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2465         * TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm: Added.
2466         (expectAttributes):
2467         (TEST):
2468
2469 2017-01-27  Keith Miller  <keith_miller@apple.com>
2470
2471         run-benchmarks should make sure it passes the test url to the right application
2472         https://bugs.webkit.org/show_bug.cgi?id=167533
2473
2474         Reviewed by Joseph Pecoraro.
2475
2476         This fixes an issue when trying to run-benchmark script with the
2477         system default browser set to STP. Previously, it would run
2478         the test in STP rather than the provided build. Now, it should run
2479         in the provided build.
2480
2481         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2482         (OSXSafariDriver.launch_url):
2483
2484 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
2485
2486         [Cocoa] Prepare ComplexTextController for unit testing
2487         https://bugs.webkit.org/show_bug.cgi?id=167493
2488
2489         Reviewed by Simon Fraser.
2490
2491         Addressing post-review comments from Simon Fraser.
2492
2493         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
2494         (TestWebKitAPI::TEST_F):
2495
2496 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
2497
2498         [Cocoa] Prepare ComplexTextController for unit testing
2499         https://bugs.webkit.org/show_bug.cgi?id=167493
2500
2501         Reviewed by Dean Jackson.
2502
2503         Create four unit tests.
2504
2505         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2506         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp: Added.
2507         (TestWebKitAPI::ComplexTextControllerTest::SetUp):
2508         (TestWebKitAPI::TEST_F):
2509
2510 2017-01-26  Chris Dumez  <cdumez@apple.com>
2511
2512         Crash when navigating back to a page in PacheCache when one of its frames has been removed
2513         https://bugs.webkit.org/show_bug.cgi?id=167421
2514         <rdar://problem/30188490>
2515
2516         Reviewed by Darin Adler.
2517
2518         Add a new setting allowing layout tests to enable PageCache in a window
2519         that has an opener, for convenience.
2520
2521         * DumpRenderTree/mac/DumpRenderTree.mm:
2522         (resetWebPreferencesToConsistentValues):
2523         * DumpRenderTree/win/DumpRenderTree.cpp:
2524         (resetWebPreferencesToConsistentValues):
2525         * WebKitTestRunner/TestController.cpp:
2526         (WTR::TestController::resetPreferencesToConsistentValues):
2527
2528 2017-01-26  Keith Miller  <keith_miller@apple.com>
2529
2530         classInfo should take a VM so it is not materialized from the object on each call
2531         https://bugs.webkit.org/show_bug.cgi?id=167424
2532
2533         Rubber Stamped by Michael Saboff.
2534
2535         Previously, classInfo() would get the VM from the target's
2536         MarkedBlock.  Most callers already have a VM on hand, so it is
2537         wasteful to compute the VM from the marked block every time. This
2538         patch refactors some of the most common callers of classInfo(),
2539         jsDynamicCast and inherits to take a VM as well.
2540
2541         * DumpRenderTree/TestRunner.cpp:
2542         (setAudioResultCallback):
2543
2544 2017-01-26  Jer Noble  <jer.noble@apple.com>
2545
2546         Autoplay muted videos stop playback of any streaming app in the background
2547         https://bugs.webkit.org/show_bug.cgi?id=163993
2548         <rdar://problem/29020431>
2549
2550         Reviewed by Eric Carlson.
2551
2552         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2553         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
2554         (TestWebKitAPI::TEST):
2555         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio-and-webaudio.html: Added.
2556
2557 2017-01-26  Ryan Haddad  <ryanhaddad@apple.com>
2558
2559         Disable API test WebKit2.WebsitePoliciesPlayAfterPreventedAutoplay.
2560         https://bugs.webkit.org/show_bug.cgi?id=167466
2561
2562         Unreviewed test gardening.
2563
2564         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2565         (TEST):
2566
2567 2017-01-26  Matt Rajca  <mrajca@apple.com>
2568
2569         Notify clients when the user plays media otherwise prevented from autoplaying
2570         https://bugs.webkit.org/show_bug.cgi?id=167390
2571
2572         Reviewed by Alex Christensen.
2573
2574         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2575         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
2576         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
2577         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2578         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
2579         (TEST):
2580         * TestWebKitAPI/cocoa/TestWKWebView.h:
2581         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2582         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
2583         (-[TestWKWebView waitForLoad]):
2584         (-[TestWKWebView mouseUpAtPoint:]):
2585         * WebKitTestRunner/TestController.cpp:
2586         (WTR::TestController::createOtherPage):
2587         (WTR::TestController::createWebViewWithOptions):
2588
2589 2017-01-26  Per Arne Vollan  <pvollan@apple.com>
2590
2591         Crash when setting custom scale factor.
2592         https://bugs.webkit.org/show_bug.cgi?id=167369
2593
2594         Reviewed by Sam Weinig.
2595
2596         Added API test.
2597
2598         * TestWebKitAPI/PlatformWin.cmake:
2599         * TestWebKitAPI/Tests/WebKit/win/ScaleWebView.cpp: Added.
2600         (TestWebKitAPI::WebKitCreateInstance):
2601         (TestWebKitAPI::ScaleWebView::SetUp):
2602         (TestWebKitAPI::ScaleWebView::TearDown):
2603         (TestWebKitAPI::TEST_F):
2604
2605 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
2606
2607         run-benchmark nests MotionMark results by the suite name twice
2608         https://bugs.webkit.org/show_bug.cgi?id=164948
2609
2610         Reviewed by Said Abou-Hallawa.
2611
2612         Use a single level MotionMark now that this is the name of the benchmark,
2613         and we no longer have tests that aren't part of the MotionMark suite.
2614
2615         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch:
2616
2617 2017-01-25  Ryan Haddad  <ryanhaddad@apple.com>
2618
2619         Unreviewed, rolling out r211193.
2620
2621         This change broke internal builds.
2622
2623         Reverted changeset:
2624
2625         "Notify clients when the user plays media otherwise prevented
2626         from autoplaying"
2627         https://bugs.webkit.org/show_bug.cgi?id=167390
2628         http://trac.webkit.org/changeset/211193
2629
2630 2017-01-25  Matt Rajca  <mrajca@apple.com>
2631
2632         Notify clients when the user plays media otherwise prevented from autoplaying
2633         https://bugs.webkit.org/show_bug.cgi?id=167390
2634
2635         Reviewed by Alex Christensen.
2636
2637         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2638         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
2639         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
2640         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2641         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
2642         (TEST):
2643         * TestWebKitAPI/cocoa/TestWKWebView.h:
2644         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2645         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
2646         (-[TestWKWebView waitForLoad]):
2647         (-[TestWKWebView mouseUpAtPoint:]):
2648         * WebKitTestRunner/TestController.cpp:
2649         (WTR::TestController::createOtherPage):
2650         (WTR::TestController::createWebViewWithOptions):
2651
2652 2017-01-25  Matt Rajca  <mrajca@apple.com>
2653
2654         [ios-simulator] API test WebKit2.WebsitePoliciesAutoplayEnabled timing out
2655         https://bugs.webkit.org/show_bug.cgi?id=167385
2656
2657         Reviewed by Alex Christensen.
2658
2659         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Avoid arbitrary timeouts in favor of promises.
2660         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html:
2661         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2662         (TEST): Allow inline (rather than full screen) media playback on iOS.
2663
2664 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2665
2666         [GTK] Icon Database should be in private browsing mode for ephemeral web views
2667         https://bugs.webkit.org/show_bug.cgi?id=167414
2668
2669         Reviewed by Michael Catanzaro.
2670
2671         Add a test case to check ephemeral web views don't write favicons to the database.
2672
2673         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
2674         (ephemeralViewLoadChanged):
2675         (testPrivateBrowsing):
2676         (testFaviconDatabase):
2677
2678 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2679
2680         [GTK] Add a private browsing mode to MiniBrowser
2681         https://bugs.webkit.org/show_bug.cgi?id=167413
2682
2683         Reviewed by Michael Catanzaro.
2684
2685         Add -p/--private command line option to create a private instance. Also add CTRL+SHIFT+P shortcut to create
2686         private windows, even on non-private instances.
2687
2688         * MiniBrowser/gtk/BrowserWindow.c:
2689         (webViewTitleChanged): Add [Private] to title window for private windows.
2690         (webViewCreate): Pass web context to browser_window_new.
2691         (openPrivateWindow): Create a new ephemeral web view and add it to a new window.
2692         (browserWindowFinalize): Disconnect web context signal handlers.
2693         (browser_window_init): Add shortcut for opening private window.
2694         (browser_window_new): It now receives the context and connect to download-started here.
2695         (browser_window_get_web_context): Return the context.
2696         * MiniBrowser/gtk/BrowserWindow.h:
2697         * MiniBrowser/gtk/main.c:
2698         (createBrowserTab): Create the web view for the window web context.
2699         (aboutDataScriptMessageReceivedCallback): Do not use the default web context, but the window one.
2700         (aboutDataHandleRequest): Ditto.
2701         (aboutURISchemeRequestCallback): Ditto.
2702         (main): Create ephemeral web context if private command line option is used.
2703
2704 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
2705
2706         collectMatchingElementsInFlatTree should not find elements inside an user agent shadow tree
2707         https://bugs.webkit.org/show_bug.cgi?id=167409
2708
2709         Reviewed by Antti Koivisto.
2710
2711         Added a test case for collectMatchingElementsInFlatTree not finding elements inside an user agent shadow tree
2712         as well as tests for the newly added matchingElementInFlatTree.
2713
2714         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp:
2715         (TestWebKitAPI::runJavaScriptAlert):
2716         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
2717         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
2718         * TestWebKitAPI/Tests/WebKit2/closed-shadow-tree-test.html:
2719
2720 2017-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2721
2722         [GTK] Add API to create ephemeral web views and deprecate the private browsing setting
2723         https://bugs.webkit.org/show_bug.cgi?id=167370
2724
2725         Reviewed by Michael Catanzaro.
2726
2727         Add several test cases of ephemeral web views.
2728
2729         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
2730         (testWebViewAuthenticationStorage):
2731         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
2732         (ephemeralViewloadChanged):
2733         (testCookieManagerEphemeral):
2734         (beforeAll):
2735         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
2736         (testWebKitSettings):
2737         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2738         (testWebContextEphemeral):
2739         (ephemeralViewloadChanged):
2740         (testWebContextProxySettings):
2741         (beforeAll):
2742         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2743         (ephemeralViewloadChanged):
2744         (testWebViewEphemeral):
2745         (beforeAll):
2746         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp:
2747         (ephemeralViewloadChanged):
2748         (testWebsiteDataEphemeral):
2749         (beforeAll):
2750
2751 2017-01-24  Alex Christensen  <achristensen@webkit.org>
2752
2753         REGRESSION (r208902): URLWithUserTypedString returns nil with file URLs
2754         https://bugs.webkit.org/show_bug.cgi?id=167402
2755
2756         Reviewed by Ryosuke Niwa.
2757
2758         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
2759         (TestWebKitAPI::TEST):
2760
2761 2017-01-24  Zalan Bujtas  <zalan@apple.com>
2762
2763         Add simple line layout toggle to MiniBrowser
2764         https://bugs.webkit.org/show_bug.cgi?id=167405
2765
2766         Reviewed by Andreas Kling.
2767
2768         * MiniBrowser/mac/SettingsController.h:
2769         * MiniBrowser/mac/SettingsController.m:
2770         (-[SettingsController _populateMenu]):
2771         (-[SettingsController validateMenuItem:]):
2772         (-[SettingsController toggleSimpleLineLayoutEnabled:]):
2773         (-[SettingsController simpleLineLayoutEnabled]):
2774         * MiniBrowser/mac/WK1BrowserWindowController.m:
2775         (-[WK1BrowserWindowController didChangeSettings]):
2776         * MiniBrowser/mac/WK2BrowserWindowController.m:
2777         (-[WK2BrowserWindowController didChangeSettings]):
2778
2779 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
2780
2781         WKR does not include my nick when commit-queue lands my patch
2782         https://bugs.webkit.org/show_bug.cgi?id=167388
2783
2784         Reviewed by Ryosuke Niwa.
2785
2786         * Scripts/webkitpy/tool/commands/newcommitbot.py:
2787         (NewCommitBot._summarize_commit_log):
2788         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
2789         Perform nickname insertion before grabbing "Patch by" details.
2790         This way we can include the nickname with the full name.
2791
2792 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
2793
2794         Fold USER_TIMING into WEB_TIMING and make it a RuntimeEnabledFeature
2795         https://bugs.webkit.org/show_bug.cgi?id=167394
2796
2797         Reviewed by Ryosuke Niwa.
2798
2799         * Scripts/webkitperl/FeatureList.pm:
2800         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2801
2802 2017-01-24  Youenn Fablet  <youenn@apple.com>
2803
2804         [WebRTC] Use HAVE_PTHREAD_COND_TIMEDWAIT_RELATIVE for libwebrtc
2805         https://bugs.webkit.org/show_bug.cgi?id=167353
2806
2807         Reviewed by Alex Christensen.
2808
2809         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
2810         (CMakeGenerator.initialize_targets):
2811
2812 2017-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2813
2814         WKR should not confuse Miguel Gomez with Andres Gomez
2815         https://bugs.webkit.org/show_bug.cgi?id=167389
2816
2817         Reviewed by Lucas Forschler.
2818
2819         Andres's email is a substring of Miguel's, causing WKR to credit Miguel's commits to
2820         "mAndres Gomez". Fix this.
2821
2822         * Scripts/webkitpy/tool/commands/newcommitbot.py:
2823         (NewCommitBot._summarize_commit_log): Be stricter about matching emails. SVN logs include a
2824         space on each side of the email address, so expect both spaces to be there before
2825         considering the email for replacement.
2826         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py: Add a test.
2827
2828 2017-01-24  Matt Rajca  <mrajca@apple.com>
2829
2830         Pass down website autoplay policies to media elements
2831         https://bugs.webkit.org/show_bug.cgi?id=167355
2832
2833         Reviewed by Alex Christensen.
2834
2835         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2836         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/autoplayCheck.html to match our naming conventions.
2837         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html: Added.
2838         * TestWebKitAPI/Tests/WebKit2/test-without-audio-track.mp4: Added.
2839         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2840         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
2841         (TEST):
2842
2843 2017-01-24  Nan Wang  <n_wang@apple.com>
2844
2845         AX: Speak Selection does not work in an iframe
2846         https://bugs.webkit.org/show_bug.cgi?id=166794
2847         <rdar://problem/29913013>
2848
2849         Reviewed by Chris Fleizach.
2850
2851         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2852         (WTR::UIScriptController::retrieveSpeakSelectionContent):
2853         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
2854         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2855         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2856         (WTR::UIScriptController::retrieveSpeakSelectionContent):
2857         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
2858         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2859         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2860         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2861         (-[TestRunnerWKWebView dealloc]):
2862         (-[TestRunnerWKWebView _accessibilityDidGetSpeakSelectionContent:]):
2863         (-[TestRunnerWKWebView accessibilityRetrieveSpeakSelectionContentWithCompletionHandler:]):
2864         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2865         (WTR::UIScriptController::retrieveSpeakSelectionContent):
2866         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
2867
2868 2017-01-24  Daniel Bates  <dabates@apple.com>
2869
2870         StringView.split() should use an iterator design pattern instead of allocating a Vector
2871         https://bugs.webkit.org/show_bug.cgi?id=163225
2872
2873         Reviewed by Darin Adler.
2874
2875         Add unit tests for StringView.split().
2876
2877         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2878         (TestWebKitAPI::stringViewFromLiteral): Moved to the top of the file so that it can be
2879         used in the StringView.split() unit tests.
2880         (TestWebKitAPI::stringViewFromUTF8): Ditto.
2881         (TestWebKitAPI::vectorFromSplitResult): Convenience function to convert a StringView::SplitResult
2882         object to a Vector of String objects.
2883         (TestWebKitAPI::TEST): Added the following tests:
2884             - WTF.StringViewSplitEmptyAndNullStrings
2885             - WTF.StringViewSplitBasic
2886             - WTF.StringViewSplitWithConsecutiveSeparators
2887
2888 2017-01-23  Anders Carlsson  <andersca@apple.com>
2889
2890         The Score Esports crashes on launch
2891         https://bugs.webkit.org/show_bug.cgi?id=167338
2892         rdar://problem/29948645
2893
2894         Reviewed by Dan Bernstein.
2895
2896         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
2897         (TestWebKitAPI::TEST):
2898         Add a test.
2899
2900 2017-01-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2901
2902         [GTK] Add API to WebKitWebsiteDataManager to handle website data
2903         https://bugs.webkit.org/show_bug.cgi?id=146589
2904
2905         Reviewed by Michael Catanzaro.
2906
2907         Add about:data handler to MiniBrowser to manually test the website data API. Also add unit tests to test all the
2908         new API, moving the WebKitWebsiteDataManager configuration API to the new file too.
2909
2910         * MiniBrowser/gtk/BrowserWindow.c:
2911         (webViewDecidePolicy):
2912         (newTabCallback):
2913         * MiniBrowser/gtk/main.c:
2914         (createBrowserTab):
2915         (aboutDataRequestFree):
2916         (aboutDataRequestNew):
2917         (aboutDataRequestForView):
2918         (websiteDataRemovedCallback):
2919         (websiteDataClearedCallback):
2920         (aboutDataScriptMessageReceivedCallback):
2921         (domainListFree):
2922         (aboutDataFillTable):
2923         (gotWebsiteDataCallback):
2924         (aboutDataHandleRequest):
2925         (aboutURISchemeRequestCallback):
2926         (main):
2927         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2928         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2929         (serverCallback):
2930         (beforeAll):
2931         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp: Added.
2932         (serverCallback):
2933         (WebsiteDataTest::WebsiteDataTest):
2934         (WebsiteDataTest::~WebsiteDataTest):
2935         (WebsiteDataTest::fetch):
2936         (WebsiteDataTest::remove):
2937         (WebsiteDataTest::clear):
2938         (testWebsiteDataConfiguration):
2939         (testWebsiteDataCache):
2940         (testWebsiteDataStorage):
2941         (testWebsiteDataDatabases):
2942         (testWebsiteDataAppcache):
2943         (beforeAll):
2944         (afterAll):
2945
2946 2017-01-23  Commit Queue  <commit-queue@webkit.org>
2947
2948         Unreviewed, rolling out r211062.
2949         https://bugs.webkit.org/show_bug.cgi?id=167354
2950
2951         broke API tests (Requested by alexchristensen on #webkit).
2952
2953         Reverted changeset:
2954
2955         "Pass down website autoplay policies to media elements"
2956         https://bugs.webkit.org/show_bug.cgi?id=167132
2957         http://trac.webkit.org/changeset/211062
2958
2959 2017-01-23  Alex Christensen  <achristensen@webkit.org>
2960
2961         URLParser should fail to parse percent-encoded invalid UTF-8 sequences
2962         https://bugs.webkit.org/show_bug.cgi?id=167330
2963
2964         Reviewed by Tim Horton.
2965
2966         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2967         (TestWebKitAPI::TEST_F):
2968
2969 2017-01-23  Alex Christensen  <achristensen@webkit.org>
2970
2971         Make URLs with non-special schemes and a query or fragment but no slash after the host more compatible
2972         https://bugs.webkit.org/show_bug.cgi?id=167317
2973
2974         Reviewed by Sam Weinig.
2975
2976         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2977         (TestWebKitAPI::TEST_F):
2978
2979 2017-01-23  Jonathan Bedard  <jbedard@apple.com>
2980
2981         svn-create-patch should emit properties when files are moved or copied
2982         https://bugs.webkit.org/show_bug.cgi?id=167264
2983
2984         Reviewed by Daniel Bates.
2985
2986         * Scripts/svn-create-patch:
2987         (manufacturePatchForAdditionWithHistory): Diff the source file against nothing to get properties.
2988
2989 2017-01-23  Youenn Fablet  <youenn@apple.com>
2990
2991         [WebRTC] Filter libwebrtc link flags
2992         https://bugs.webkit.org/show_bug.cgi?id=167287
2993
2994         Reviewed by Alex Christensen.
2995
2996         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
2997         (CMakeGenerator._compute_link_flags):
2998         (CMakeGenerator._compute_link_flags.keep_flag):
2999         (CMakeGenerator._generate_compile_target_options):
3000
3001 2017-01-23  Youenn Fablet  <youennf@gmail.com>
3002
3003         [WebRTC] Make VP8 optional in libwebrtc
3004         https://bugs.webkit.org/show_bug.cgi?id=167257
3005
3006         Reviewed by Darin Adler.
3007
3008         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
3009         (CMakeGenerator.remove_libvpx): Adding vp8_noop.cc to the build system.
3010
3011 2017-01-23  Jer Noble  <jer.noble@apple.com>
3012
3013         Video details does not apear and missing scrubber in Control Center
3014         https://bugs.webkit.org/show_bug.cgi?id=167233
3015
3016         Reviewed by Alex Christensen.
3017
3018         Refactor TestWKWebViewMac to work on PLATFORM(IOS). Add a new test to
3019         NowPlayingControlTests for iOS.
3020
3021         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3022         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
3023         (-[NowPlayingTestWebView setWindowVisible:]):
3024         (TestWebKitAPI::TEST):
3025         * TestWebKitAPI/Tests/WebKit2Cocoa/SnapshotStore.mm:
3026         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
3027         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
3028         * TestWebKitAPI/cocoa/TestWKWebView.h: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.h.
3029         * TestWebKitAPI/cocoa/TestWKWebView.mm: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.mm.
3030         (SOFT_LINK_CLASS):
3031         (-[TestMessageHandler addMessage:withHandler:]):
3032         (-[TestMessageHandler userContentController:didReceiveScriptMessage:]):
3033         (__simulated_forceClickAssociatedEventsMask):
3034         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:]):
3035         (-[TestWKWebViewHostWindow isKeyWindow]):
3036         (-[TestWKWebViewHostWindow makeKeyWindow]):
3037         (-[TestWKWebViewHostWindow resignKeyWindow]):
3038         (-[TestWKWebView initWithFrame:]):
3039         (-[TestWKWebView initWithFrame:configuration:]):
3040         (-[TestWKWebView _setUpTestWindow:]):
3041         (-[TestWKWebView performAfterReceivingMessage:action:]):
3042         (-[TestWKWebView loadTestPageNamed:]):
3043         (-[TestWKWebView synchronouslyLoadTestPageNamed:]):
3044         (-[TestWKWebView stringByEvaluatingJavaScript:]):
3045         (-[TestWKWebView waitForMessage:]):
3046         (-[TestWKWebView performAfterLoading:]):
3047         (-[TestWKWebView mouseDownAtPoint:simulatePressure:]):
3048         (-[TestWKWebView typeCharacter:]):
3049
3050 2017-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3051
3052         Unreviewed. Bring back gtk-doc error messages after r209981.
3053
3054         Since r209981, if gtk-doc shows warnings the build fails but those warnings are not printed to stdout so it's
3055         impossible to know what's wrong.
3056
3057         * gtk/gtkdoc.py:
3058         (GTKDoc._run_command): Make print_output True by default again and use debug instead of info to log "Running" messages.
3059
3060 2017-01-20  Youenn Fablet  <youennf@gmail.com>
3061
3062         [WebRTC] Update build system to make G711 optional in libwebrtc
3063         https://bugs.webkit.org/show_bug.cgi?id=167256
3064
3065         Reviewed by Alex Christensen.
3066
3067         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
3068         (CMakeGenerator.remove_webrtc_g711): Adding a missing file to the build system as this file includes generic pcm encoder functions.
3069
3070 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
3071
3072         Cleanup RuntimeEnabledFeatures
3073         https://bugs.webkit.org/show_bug.cgi?id=167228
3074
3075         Reviewed by Simon Fraser.
3076
3077         * DumpRenderTree/mac/DumpRenderTree.mm:
3078         (enableExperimentalFeatures):
3079         (resetWebPreferencesToConsistentValues):
3080         (setWebPreferencesForTestOptions):
3081         (resetWebViewToConsistentStateBeforeTesting):
3082         * DumpRenderTree/win/DumpRenderTree.cpp:
3083         (enableExperimentalFeatures):
3084         (resetWebPreferencesToConsistentValues):
3085         More closely match WebKitTestRunner initialization of preferences
3086         for experimental features.
3087
3088 2017-01-20  Alex Christensen  <achristensen@webkit.org>
3089
3090         Build Fix for Windows DumpRenderTree after r210976
3091         https://bugs.webkit.org/show_bug.cgi?id=167115
3092
3093         * DumpRenderTree/win/DumpRenderTree.cpp:
3094         (resetWebPreferencesToConsistentValues):
3095
3096 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
3097
3098         Remove outdated ENABLE(CSP_NEXT) build flag
3099         https://bugs.webkit.org/show_bug.cgi?id=167252
3100
3101         Reviewed by Brent Fulgham.
3102
3103         * Scripts/webkitperl/FeatureList.pm:
3104         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3105
3106 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
3107
3108         Build Fix for Windows DumpRenderTree after r210976
3109
3110         * DumpRenderTree/win/DumpRenderTree.cpp:
3111         (resetWebPreferencesToConsistentValues):
3112
3113 2017-01-20  Antoine Quint  <graouts@apple.com>
3114
3115         Web Animations should be off by default and enabled as an experimental feature
3116         https://bugs.webkit.org/show_bug.cgi?id=167115
3117         <rdar://problem/30048963>
3118
3119         Reviewed by Joseph Pecoraro.
3120
3121         Turn Web Animations on in DRT.
3122
3123         * DumpRenderTree/mac/DumpRenderTree.mm:
3124         (resetWebPreferencesToConsistentValues):
3125         * DumpRenderTree/win/DumpRenderTree.cpp:
3126         (resetWebPreferencesToConsistentValues):
3127
3128 2017-01-20  Youenn Fablet  <youenn@apple.com>
3129
3130         [WebRTC] Add libwebrtc build infrastructure
3131         https://bugs.webkit.org/show_bug.cgi?id=167207
3132
3133         Reviewed by Alex Christensen.
3134
3135         Adding a script doing the libwebrtc project json to CMake file conversion.
3136
3137         * Scripts/generate-libwebrtc-cmake: Added.
3138         * Scripts/webkitpy/libwebrtc/__init__.py: Added.
3139         * Scripts/webkitpy/libwebrtc/generate_cmake.py: Added.
3140
3141 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
3142
3143         Mini Browser: Show tooltip for Experimental Features
3144         https://bugs.webkit.org/show_bug.cgi?id=167225
3145
3146         Reviewed by Alex Christensen.
3147
3148         * MiniBrowser/mac/SettingsController.m:
3149         (-[SettingsController _populateMenu]):
3150         Include the full details string as a tooltip.
3151
3152 2017-01-20  Per Arne Vollan  <pvollan@apple.com>
3153
3154         [Win] Test output results should not be written twice.
3155         https://bugs.webkit.org/show_bug.cgi?id=167197
3156
3157         Reviewed by Brent Fulgham.
3158
3159         Prevent test output from being written twice by returning early from
3160         the dump() function, if it already has been called.
3161         This patch also adds a missing newline to a test output line.
3162
3163         * DumpRenderTree/win/DumpRenderTree.cpp:
3164         (dump):
3165
3166 2017-01-20  Antoine Quint  <graouts@apple.com>
3167
3168         [Modern Media Controls] Turn modern media controls on by default
3169         https://bugs.webkit.org/show_bug.cgi?id=165668
3170
3171         Reviewed by Dean Jackson.
3172
3173         Enabled modern media controls by default in test runners.
3174
3175         * DumpRenderTree/TestOptions.h:
3176         * WebKitTestRunner/TestOptions.h:
3177
3178 2017-01-19  Chris Dumez  <cdumez@apple.com>
3179
3180         iterable<> should be enabled on WK1
3181         https://bugs.webkit.org/show_bug.cgi?id=167221
3182         <rdar://problem/30108531>
3183
3184         Reviewed by Youenn Fablet.
3185
3186         * DumpRenderTree/mac/DumpRenderTree.mm:
3187         (resetWebPreferencesToConsistentValues):
3188         * DumpRenderTree/win/DumpRenderTree.cpp:
3189         (resetWebPreferencesToConsistentValues):
3190         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3191         (WTR::InjectedBundle::beginTesting):
3192         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3193         (WTR::TestRunner::setDOMIteratorEnabled): Deleted.
3194         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3195
3196 2017-01-19  Aakash Jain  <aakash_jain@apple.com>
3197
3198         Ensure status server logs go to log file
3199         https://bugs.webkit.org/show_bug.cgi?id=167210
3200
3201         Reviewed by Alexey Proskuryakov.
3202
3203         * Scripts/webkitpy/common/net/statusserver.py:
3204         (StatusServer.next_work_item): Change log level from debug to info in
3205         order to facilitate deubgging issues.
3206         (StatusServer.update_work_items): Same.
3207
3208 2017-01-19  Megan Gardner  <megan_gardner@apple.com>
3209
3210         Additional selection tests and interpolation fix
3211         https://bugs.webkit.org/show_bug.cgi?id=167171
3212
3213         Reviewed by Simon Fraser.
3214
3215         We weren't adding the final event when interpolating event streams.
3216
3217         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3218         (-[HIDEventGenerator interpolatedEvents:]):
3219
3220 2017-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
3221
3222         [Cocoa] Variation fonts are erroneously disabled on iOS
3223         https://bugs.webkit.org/show_bug.cgi?id=167172
3224
3225         Reviewed by Simon Fraser.
3226
3227         OpenSource builders don't seem to understand sdk=embedded*.
3228
3229         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3230
3231 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3232
3233         Unreviewed. Fix GTK+ unit tests failing since r210531.
3234
3235         Avoid using paths to files that don't actually exist.
3236
3237         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:
3238         (testWebKitConsoleMessageNetworkError):
3239         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
3240         (testContextMenuDefaultMenu):
3241         * TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg: Added.
3242         * TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json: Added.
3243         * TestWebKitAPI/Tests/WebKit2Gtk/resources/tracks.ogg: Added.
3244
3245 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3246
3247         [GTK] Provide API to set proxy settings
3248         https://bugs.webkit.org/show_bug.cgi?id=128674
3249
3250         Reviewed by Michael Catanzaro.
3251
3252         Add tests for new proxy settings API.
3253
3254         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
3255         (serverCallback):
3256         (ProxyTest::ProxyTest):
3257         (ProxyTest::~ProxyTest):
3258         (ProxyTest::loadURIAndGetMainResourceData):
3259         (ProxyTest::proxyServerPortAsString):
3260         (testWebContextProxySettings):
3261         (beforeAll):
3262
3263 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
3264
3265         Add back my old email address so old commits will still match it.
3266
3267         * Scripts/webkitpy/common/config/contributors.json:
3268
3269 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
3270
3271         Remove my old email address from contributors.json and watchlist.
3272
3273         * Scripts/validate-committer-lists:
3274         (CommitterListFromGit): Change the mapping to the correct email.
3275         * Scripts/webkitpy/common/config/contributors.json:
3276         * Scripts/webkitpy/common/config/watchlist:
3277
3278 2017-01-18  Ryan Haddad  <ryanhaddad@apple.com>
3279
3280         Unreviewed, rolling out r210848.
3281
3282         This change introduced media-related LayoutTest failures and
3283         crashes on macOS.
3284
3285         Reverted changeset:
3286
3287         "[Modern Media Controls] Turn modern media controls on by
3288         default"
3289         https://bugs.webkit.org/show_bug.cgi?id=165668
3290         http://trac.webkit.org/changeset/210848
3291
3292 2017-01-18  Andreas Kling  <akling@apple.com>
3293
3294         Document::securityOrigin() should return a reference.
3295         <https://webkit.org/b/167124>
3296
3297         Reviewed by Sam Weinig.
3298
3299         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
3300         (TestWebKitAPI::TEST_F):
3301
3302 2017-01-18  Per Arne Vollan  <pvollan@apple.com>
3303
3304         [Win] Clipboard tests are flaky.
3305         https://bugs.webkit.org/show_bug.cgi?id=167088
3306
3307         Reviewed by Brent Fulgham.
3308
3309         Tests involving the clipboard are flaky when running with multiple DRTs, since the clipboard is global.
3310         We can fix this by assigning each DRT a separate window station (each window station has its own clipboard).
3311
3312         * DumpRenderTree/win/DumpRenderTree.cpp:
3313         (main):
3314
3315 2017-01-18  Antoine Quint  <graouts@apple.com>
3316
3317         [Modern Media Controls] Turn modern media controls on by default
3318         https://bugs.webkit.org/show_bug.cgi?id=165668
3319
3320         Reviewed by Dean Jackson.
3321
3322         Enabled modern media controls by default in test runners.
3323
3324         * DumpRenderTree/TestOptions.h:
3325         * WebKitTestRunner/TestOptions.h:
3326
3327 2017-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
3328
3329         Unreviewed, rolling out r210834
3330         https://bugs.webkit.org/show_bug.cgi?id=165668
3331
3332         It introduced dozens of test timeouts.
3333
3334         Reverted changeset:
3335         "[Modern Media Controls] Turn modern media controls on by default"
3336         https://bugs.webkit.org/show_bug.cgi?id=165668
3337         http://trac.webkit.org/changeset/210834
3338
3339 2017-01-17  Antoine Quint  <graouts@apple.com>
3340
3341         [Modern Media Controls] Turn modern media controls on by default
3342         https://bugs.webkit.org/show_bug.cgi?id=165668
3343
3344         Reviewed by Dean Jackson.
3345
3346         Enabled modern media controls by default in test runners.
3347
3348         * DumpRenderTree/TestOptions.h:
3349         * WebKitTestRunner/TestOptions.h:
3350
3351 2017-01-17  Chris Dumez  <cdumez@apple.com>
3352
3353         Document title changed twice when setting document.title
3354         https://bugs.webkit.org/show_bug.cgi?id=167065
3355
3356         Reviewed by Darin Adler.
3357
3358         Add WebKit2GTK API test that was written by Michael Catanzaro.
3359
3360         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3361         (testWebViewTitleChange):
3362         (beforeAll):
3363
3364 2017-01-17  Joseph Pecoraro  <pecoraro@apple.com>
3365
3366         ENABLE(USER_TIMING) Not Defined for Apple Windows or OS X Ports
3367         https://bugs.webkit.org/show_bug.cgi?id=116551
3368         <rdar://problem/13949830>
3369
3370         Reviewed by Alex Christensen.
3371
3372         * Scripts/webkitperl/FeatureList.pm:
3373         Remove stale RESOURCE_TIMING references which are now a runtime enabled feature
3374         that is part of the existing WEB_TIMING feature.
3375
3376         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3377
3378 2017-01-17  Jonathan Bedard  <jbedard@apple.com>
3379
3380         'webkit-patch post' no longer works with moved/copied files
3381         https://bugs.webkit.org/show_bug.cgi?id=166914
3382         <rdar://problem/29979707>
3383
3384         Reviewed by Daniel Bates.
3385
3386         SVN 1.9 has a bug where when a file has been moved or copied, the svn diff of the new
3387         file outputs only the "Index:" line with an empty body.  This workaround
3388         ignores such output from svn diff.  A issue has been filed with SVN, a link to the
3389         public email list tracking this bug is below.
3390         http://mail-archives.apache.org/mod_mbox/subversion-users/201701.mbox/%3cCF9BDE0A-7454-4405-8259-1120C6B76A03@apple.com%3e
3391
3392
3393         * Scripts/svn-create-patch:
3394         (generateDiff): Ignore an "Index:" line with an empty body.
3395
3396 2017-01-16  Joseph Pecoraro  <pecoraro@apple.com>
3397
3398         Remove the REQUEST_ANIMATION_FRAME flag
3399         https://bugs.webkit.org/show_bug.cgi?id=156980
3400         <rdar://problem/25906849>
3401
3402         Reviewed by Simon Fraser.
3403
3404         * Scripts/webkitperl/FeatureList.pm:
3405         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3406
3407 2017-01-15  Sam Weinig  <sam@webkit.org>
3408
3409         Add the ability to use numbers in makeString()
3410         https://bugs.webkit.org/show_bug.cgi?id=167087
3411
3412         Reviewed by Darin Adler.
3413
3414         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3415         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Added.
3416         Add tests for StringConcatenate, focusing on new numeric additions.
3417
3418 2017-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
3419
3420         Unreviewed, remove stale comment.
3421
3422         This test was fixed by r163173.
3423
3424         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3425
3426 2017-01-14  Yusuke Suzuki  <utatane.tea@gmail.com>
3427
3428         Annotate large string tests with largeHeap
3429         https://bugs.webkit.org/show_bug.cgi?id=167054
3430
3431         Reviewed by Filip Pizlo.
3432
3433         * Scripts/run-javascriptcore-tests:
3434         * Scripts/run-jsc-stress-tests:
3435
3436 2017-01-14  Joseph Pecoraro  <pecoraro@apple.com>
3437
3438         Remove stale references to ENABLE_ES6_GENERATORS and ENABLE_PROMISES
3439         https://bugs.webkit.org/show_bug.cgi?id=167043
3440
3441         Reviewed by Darin Adler.
3442
3443         * Scripts/webkitperl/FeatureList.pm:
3444
3445 2017-01-13  Joseph Pecoraro  <pecoraro@apple.com>
3446
3447         Remove ENABLE(DETAILS_ELEMENT) guards
3448         https://bugs.webkit.org/show_bug.cgi?id=167042
3449
3450         Reviewed by Alex Christensen.
3451
3452         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3453
3454 2017-01-13  Said Abou-Hallawa  <sabouhallawa@apple.com>
3455
3456         26 MotionMark performance tests failing
3457         https://bugs.webkit.org/show_bug.cgi?id=166854
3458
3459         Reviewed by Ryosuke Niwa.
3460
3461         Unrelated change. This is the last place that we need to rename Animometer
3462         to MotionMark.
3463
3464         * Scripts/webkitpy/common/config/watchlist:
3465
3466 2017-01-13  Yusuke Suzuki  <utatane.tea@gmail.com>
3467
3468         run-jsc-benchmarks' echo should have -e option
3469         https://bugs.webkit.org/show_bug.cgi?id=167009
3470
3471         Reviewed by Sam Weinig.
3472
3473         echo requires `-e` option to use escape sequence.
3474         Without it, in some environment (in my Fedora 25), the escape sequence is not
3475         recognized and just dumped as `\c` etc.
3476
3477         * Scripts/run-jsc-benchmarks:
3478
3479 2017-01-12  Chris Dumez  <cdumez@apple.com>
3480
3481         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
3482         https://bugs.webkit.org/show_bug.cgi?id=166995
3483
3484         Reviewed by Jer Noble.
3485
3486         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
3487         as some people are having trouble building without it.
3488
3489         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3490
3491 2017-01-12  Sam Weinig  <sam@webkit.org>
3492
3493         Add the ability to filter the set of bindings tests you want to run
3494         https://bugs.webkit.org/show_bug.cgi?id=166977
3495
3496         Reviewed by Tim Horton.
3497
3498         Allows doing things like:
3499             run-bindings-tests TestObj* TestCEReactions*
3500
3501         to run only those tests that match the patterns.
3502
3503         * Scripts/run-bindings-tests:
3504         (main):
3505         Switch to using optparse and pass the remaining args as the filters.
3506
3507         * Scripts/webkitpy/bindings/main.py:
3508         (BindingsTests.__init__):
3509         Store the pattens.
3510
3511         (BindingsTests.test_matches_patterns):
3512         Add helper predicate to determine if a test should be run. When no
3513         patterns are present, all tests should run.
3514
3515         (BindingsTests.run_tests):
3516         Filter tests using the passed in patterns.
3517
3518 2017-01-12  Per Arne Vollan  <pvollan@apple.com>
3519
3520         Followup fix after r210503.
3521         https://bugs.webkit.org/show_bug.cgi?id=166887
3522
3523         Reviewed by Alex Christensen.
3524
3525         After <http://trac.webkit.org/changeset/210503>, test results are written to a
3526         duplicated file handle on Windows. This patch fixes the remaining call sites.
3527
3528         * DumpRenderTree/PixelDumpSupport.cpp:
3529         * DumpRenderTree/TestRunner.cpp:
3530         (TestRunner::waitToDumpWatchdogTimerFired):
3531         * DumpRenderTree/TestRunner.h:
3532         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3533         * DumpRenderTree/win/DumpRenderTree.cpp:
3534         * DumpRenderTree/win/DumpRenderTreeWin.h:
3535         * DumpRenderTree/win/TestRunnerWin.cpp:
3536         (TestRunner::setSpellCheckerLoggingEnabled):
3537
3538 2017-01-11  Megan Gardner  <megan_gardner@apple.com>
3539
3540         Add committer status for Megan
3541         https://bugs.webkit.org/show_bug.cgi?id=166954
3542
3543         Reviewed by Tim Horton.
3544
3545         Add committer status for Megan Gardner
3546
3547         * Scripts/webkitpy/common/config/contributors.json:
3548
3549 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
3550
3551         Unreviewed test fix after r210599.
3552
3553         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
3554         (TestWebKitAPI::TEST): Remove debugging code that was causing a timeout.
3555
3556 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
3557
3558         Unreviewed build fix after r210599.
3559
3560         Add missing files.
3561
3562         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
3563         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
3564
3565 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
3566
3567         File scheme should not allow access of a resource on a different volume.
3568         https://bugs.webkit.org/show_bug.cgi?id=158552
3569         <rdar://problem/15307582>
3570
3571         Reviewed by Alex Christensen.
3572
3573         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
3574         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
3575         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
3576
3577 2017-01-11  Ryan Haddad  <ryanhaddad@apple.com>
3578
3579         Unreviewed, rolling out r210571.
3580
3581         This change broke the 32-bit macOS build and caused LayoutTest
3582         failures.
3583
3584         Reverted changeset:
3585
3586         "File scheme should not allow access of a resource on a
3587         different volume."
3588         https://bugs.webkit.org/show_bug.cgi?id=158552
3589         http://trac.webkit.org/changeset/210571
3590
3591 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3592
3593         [GTK] install-dependencies script misses gdb
3594         https://bugs.webkit.org/show_bug.cgi?id=166917
3595
3596         Reviewed by Michael Catanzaro.
3597
3598         gdb is needed for generating the crash logs.
3599
3600         * gtk/install-dependencies:
3601
3602 2017-01-10  Michael Catanzaro  <mcatanzaro@igalia.com>
3603
3604         [GTK] No way for applications to set notification permissions without waiting for permission request
3605         https://bugs.webkit.org/show_bug.cgi?id=163366
3606
3607         Reviewed by Carlos Garcia Campos.
3608
3609         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3610         (testWebViewNotification):
3611         (setInitialNotificationPermissionsAllowedCallback):
3612         (setInitialNotificationPermissionsDisallowedCallback):
3613         (testWebViewNotificationInitialPermissionAllowed):
3614         (testWebViewNotificationInitialPermissionDisallowed):
3615         (beforeAll):
3616         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
3617         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
3618         (WebViewTest::WebViewTest):
3619         (WebViewTest::initializeWebView):
3620         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
3621
3622 2017-01-10  Tim Horton  <timothy_horton@apple.com>
3623
3624         MobileMiniBrowser tests don't work by default
3625         https://bugs.webkit.org/show_bug.cgi?id=166910
3626
3627         Reviewed by Alex Christensen.
3628
3629         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme: Added.
3630         Add a shared scheme; the Makefile depends on the MobileMiniBrowserUITests scheme existing, at the very least.
3631
3632 2017-01-10  Brent Fulgham  <bfulgham@apple.com>
3633
3634         File scheme should not allow access of a resource on a different volume.
3635         https://bugs.webkit.org/show_bug.cgi?id=158552
3636         <rdar://problem/15307582>
3637
3638         Reviewed by Alex Christensen.
3639
3640         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
3641         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
3642         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
3643
3644 2017-01-10  Mark Lam  <mark.lam@apple.com>
3645
3646         Reverting run-jsc-stress-tests' $buildType to use string values.