[Content Filtering] Determine navigation and content policy before continuing to...
[WebKit-https.git] / Tools / ChangeLog
1 2015-08-26  Andy Estes  <aestes@apple.com>
2
3         [Content Filtering] Determine navigation and content policy before continuing to filter a load
4         https://bugs.webkit.org/show_bug.cgi?id=148506
5
6         Reviewed by Brady Eidson.
7
8         Added download API tests covering every decision and decision point.
9         Removed _WKDownload.AsynchronousDownloadPolicy in favor of these new tests.
10
11         * TestWebKitAPI/Configurations/Base.xcconfig: Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to the header search path.
12         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Removed it from here.
13         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
14         (-[BundleParametersPlugIn observeValueForKeyPath:ofObject:change:context:]): Called -valueForKeyPath:, which
15         returns an id, instead of -valueForKey:, which always returns an NSString even if the object is of another type.
16         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Added a class that can send a MockContentFilter
17         decision and decision point as a bundle parameter.
18         (+[MockContentFilterEnabler supportsSecureCoding]):
19         (-[MockContentFilterEnabler copyWithZone:]):
20         (-[MockContentFilterEnabler initWithCoder:]):
21         (-[MockContentFilterEnabler initWithDecision:decisionPoint:]):
22         (-[MockContentFilterEnabler encodeWithCoder:]):
23         (configurationWithContentFilterSettings): Added a helper function to create a WKWebViewConfiguration with MockConentFilter settings.
24         (TEST): Renamed ContentFiltering.ServerRedirect to ContentFiltering.URLAfterServerRedirect.
25         (-[BecomeDownloadDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Decided _WKNavigationResponsePolicyBecomeDownload.
26         (-[BecomeDownloadDelegate webView:didFailProvisionalNavigation:withError:]): Set isDone to true.
27         (-[BecomeDownloadDelegate webView:didFinishNavigation:]): Ditto.
28         (-[ContentFilteringDownloadDelegate _downloadDidStart:]): Set downloadDidStart to true.
29         (downloadTest): Added a helper function to test downloads with a given decision and decision point.
30         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Added a corresponding bundle class that decodes
31         the MockContentFilter decision and decision point, and sets these values in the MockContentFilterSettings
32         singleton. This class is duplicated in the bundle to prevent TestWebKitAPI from having to link to WebCoreTestSupport.
33         (+[MockContentFilterEnabler supportsSecureCoding]):
34         (-[MockContentFilterEnabler copyWithZone:]):
35         (-[MockContentFilterEnabler initWithCoder:]):
36         (-[MockContentFilterEnabler dealloc]):
37         (-[MockContentFilterEnabler encodeWithCoder:]):
38         (-[ContentFilteringPlugIn webProcessPlugIn:initializeWithObject:]): Start observing changes to the MockContentFilterEnabler key path.
39         (-[ContentFilteringPlugIn dealloc]): Stop observing.
40         (-[ContentFilteringPlugIn observeValueForKeyPath:ofObject:change:context:]): Store a MockContentFilterEnabler in _contentFilterEnabler.
41         (+[ServerRedirectPlugIn initialize]): Deleted.
42         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
43         (-[AsynchronousDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
44         (-[AsynchronousDownloadDelegate _downloadDidStart:]): Deleted.
45         (TEST): Deleted.
46
47 2015-08-31  Filip Pizlo  <fpizlo@apple.com>
48
49         Skip slow lock tests on Windows/debug
50         https://bugs.webkit.org/show_bug.cgi?id=148643
51
52         Reviewed by Alexey Proskuryakov.
53
54         The lock tests simulate a critical section by doing some floating point math, and then either
55         make those critical sections very long or invoke them many times. This appears to be
56         particularly slow on Windows in debug mode, maybe because Visual Studio's debug build makes
57         that kind of computation slow.
58
59         These tests are almost as useful in release as they are in debug, so it's probably better to
60         just skip the in debug on platforms where this causes timeouts.
61
62         * TestWebKitAPI/Tests/WTF/Lock.cpp:
63         (TestWebKitAPI::runLockTest):
64         (TestWebKitAPI::skipSlow):
65         (TestWebKitAPI::TEST):
66
67 2015-08-29  Chris Fleizach  <cfleizach@apple.com>
68
69         AX: When navigating the elements of a scrollable element with VoiceOver, the scrollTop() position of the element does not permanently change
70         https://bugs.webkit.org/show_bug.cgi?id=125720
71
72         Reviewed by Daniel Bates.
73
74         Add support for scrollToMakeVisibleWithSubFocus and scrollToGlobalPoint.
75
76         * DumpRenderTree/AccessibilityUIElement.cpp:
77         (pressCallback):
78         (scrollToMakeVisibleWithSubFocusCallback):
79         (scrollToGlobalPointCallback):
80         (scrollToMakeVisibleCallback):
81         (AccessibilityUIElement::getJSClass):
82         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
83         (AccessibilityUIElement::scrollToMakeVisible):
84         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
85         (AccessibilityUIElement::scrollToGlobalPoint):
86         (AccessibilityUIElement::selectedTextRange):
87         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
88         (AccessibilityUIElement::AccessibilityUIElement):
89         (AccessibilityUIElement::mathPrescriptsDescription):
90         (AccessibilityUIElement::scrollToMakeVisible):
91         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
92         (AccessibilityUIElement::scrollToGlobalPoint):
93         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
94         (WTR::AccessibilityUIElement::isTextMarkerValid):
95         (WTR::AccessibilityUIElement::textMarkerForIndex):
96         (WTR::AccessibilityUIElement::scrollToMakeVisible):
97         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
98         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
99         (WTR::AccessibilityUIElement::supportedActions):
100         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
101         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
102         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
103         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
104         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
105         (WTR::AccessibilityUIElement::scrollToMakeVisible):
106         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
107         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
108         (WTR::AccessibilityUIElement::selectedTextRange):
109         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
110         (WTR::AccessibilityUIElement::scrollToMakeVisible):
111         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
112         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
113         (WTR::AccessibilityUIElement::selectedTextRange):
114
115 2015-08-28  Timothy Horton  <timothy_horton@apple.com>
116
117         Add a mysteriously nonproblematic missing comma.
118
119         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
120         (TestExpectationParser._collect_matching_tests):
121         (TestExpectationParser):
122
123 2015-08-28  Timothy Horton  <timothy_horton@apple.com>
124
125         Remove an old temporary script that has served its purpose
126
127         * Scripts/convert-test-expectations: Removed.
128
129 2015-08-28  Jer Noble  <jer.noble@apple.com>
130
131         [iOS] Add WebKit/WebKit2 settings to control automatic data loading
132         https://bugs.webkit.org/show_bug.cgi?id=148579
133
134         Reviewed by Anders Carlsson.
135
136         In DumpRenderTree, set the new mediaDataLoadsAutomatically preference to YES.
137
138         In WebKitTestRunner, do the same for the new _mediaDataLoadsAutomatically configuration property,
139         and also set the existing requiresUserActionForMediaPlayback configuration property to NO.
140
141         * DumpRenderTree/mac/DumpRenderTree.mm:
142         (resetWebPreferencesToConsistentValues):
143         (resetWebViewToConsistentStateBeforeTesting): 
144         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
145         (WTR::initializeWebViewConfiguration):
146
147 2015-08-28  Alexey Proskuryakov  <ap@apple.com>
148
149         Fix run-webkit-tests --additional-env-var="DYLD_INSERT_LIBRARIES=..."
150         https://bugs.webkit.org/show_bug.cgi?id=148592
151
152         Reviewed by Tim Horton.
153
154         * Scripts/webkitpy/port/base.py:
155         (Port.to.setup_environ_for_server):
156         (Port.to):
157         (Port.to._append_value_colon_separated):
158         (Port.to.show_results_html_file):
159         * Scripts/webkitpy/port/ios.py:
160         (IOSSimulatorPort.setup_environ_for_server):
161         * Scripts/webkitpy/port/mac.py:
162         (MacPort.setup_environ_for_server):
163
164 2015-08-28  Filip Pizlo  <fpizlo@apple.com>
165
166         LICM should be sound even if the CFG has changed
167         https://bugs.webkit.org/show_bug.cgi?id=148259
168
169         Reviewed by Benjamin Poulain.
170
171         Add a utility for creating tests that set some uncommon option.
172
173         * Scripts/run-jsc-stress-tests:
174
175 2015-08-28  Brent Fulgham  <bfulgham@apple.com>
176
177         [Win] Unreviewed EWS correction.
178
179         * EWSTools/start-queue-win.sh: Update settings to point to VS2015.
180
181 2015-08-28  Jer Noble  <jer.noble@apple.com>
182
183         [iOS] Make the AllowsInlineMediaPlayback preference work in WebKit / WebKit2.
184         https://bugs.webkit.org/show_bug.cgi?id=147512
185
186         Reviewed by Anders Carlsson.
187
188         Set the value of WebKitAllowsInlineMediaPlayback / WKPreferencesSetMediaPlaybackAllowsInline()
189         to a consistent (true) value.
190
191         * DumpRenderTree/mac/DumpRenderTree.mm:
192         (setDefaultsToConsistentValuesForTesting):
193         * WebKitTestRunner/TestController.cpp:
194         (WTR::TestController::resetPreferencesToConsistentValues):
195
196 2015-08-28  Tim Horton  <timothy_horton@apple.com>
197
198         Add navigation gesture callbacks to WKPageNavigationClient
199         https://bugs.webkit.org/show_bug.cgi?id=148568
200         <rdar://problem/22371346>
201
202         Reviewed by Anders Carlsson.
203
204         * WebKitTestRunner/TestController.cpp:
205         (WTR::TestController::createOtherPage):
206         (WTR::TestController::createWebViewWithOptions):
207         Add some zeroes.
208
209 2015-08-28  Alexey Proskuryakov  <ap@apple.com>
210
211         [Mac] kill-old-processes should kill more processes
212         https://bugs.webkit.org/show_bug.cgi?id=148577
213
214         Reviewed by Tim Horton.
215
216         * BuildSlaveSupport/kill-old-processes:
217
218 2015-08-28  Jason Marcell  <jmarcell@apple.com>
219
220         The status message for combined builder queues should say "all builds succeeded" if everything
221         built correctly.
222         https://bugs.webkit.org/show_bug.cgi?id=148535
223
224         Reviewed by David Kilzer and Alexey Proskuryakov.
225
226         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
227         (BuildbotCombinedQueueView.prototype.update): Make status message for combined builder queues
228         say "all builds succeeded" if everything built correctly.
229
230 2015-08-28  Carlos Garcia Campos  <cgarcia@igalia.com>
231
232         [GTK] Simplify the internal API to create a WebView
233         https://bugs.webkit.org/show_bug.cgi?id=148570
234
235         Reviewed by Žan Doberšek.
236
237         * TestWebKitAPI/PlatformWebView.h: Add initialize method for GTK+ too.
238         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
239         (TestWebKitAPI::PlatformWebView::PlatformWebView): Implement all
240         PlatformWebView constructors that end up calling initialize with a PageConfiguration.
241         (TestWebKitAPI::PlatformWebView::initialize): Create the WebView
242         passing the received PageConfiguration.
243         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
244         (WTR::PlatformWebView::PlatformWebView): Create the WebView
245         passing the received PageConfiguration.
246
247 2015-08-27  Aakash Jain  <aakash_jain@apple.com>
248
249         iOS Simulator API tests fails as Simulator is not running
250         https://bugs.webkit.org/show_bug.cgi?id=148501
251         rdar://problem/22447525
252
253         Reviewed by Daniel Bates.
254
255         This change is a workaround for <rdar://problem/22388812>.
256
257          * Scripts/run-api-tests: Launch the iOS Simulator before starting the API Tests
258          and quit it on program termination when running tests on the iOS port.
259          * Scripts/webkitdirs.pm: Store string "For WebKit Development" in constant
260          SIMULATOR_DEVICE_SUFFIX_FOR_WEBKIT_DEVELOPMENT to make it consistently reusable.
261
262 2015-08-27  Alex Christensen  <achristensen@webkit.org>
263
264         Make DLLLauncherMain executables dependent on dll
265         https://bugs.webkit.org/show_bug.cgi?id=148548
266
267         Reviewed by Brent Fulgham.
268
269         * DumpRenderTree/CMakeLists.txt:
270         * DumpRenderTree/PlatformWin.cmake:
271         * MiniBrowser/win/CMakeLists.txt:
272         * TestWebKitAPI/CMakeLists.txt:
273         * TestWebKitAPI/PlatformWin.cmake:
274
275 2015-08-27  Lucas Forschler  <lforschler@apple.com>
276
277         Remove Mac slaves 188/189 after being replaced with 400/401.
278         
279         Unreviewed.
280         
281         * BuildSlaveSupport/build.webkit.org-config/config.json:
282
283 2015-08-27  Lucas Forschler  <lforschler@apple.com>
284
285         Add two bots to the Mac Yosemite queue.
286         This is to eventually replace bots188/189, which will be removed after 400/401 are vetted.
287         
288         Unreviewed.
289         
290         * BuildSlaveSupport/build.webkit.org-config/config.json:
291
292 2015-08-27  Alex Christensen  <achristensen@webkit.org>
293
294         [Win CMake] Fix incremental build after r188673
295         https://bugs.webkit.org/show_bug.cgi?id=148539
296
297         Reviewed by Brent Fulgham.
298
299         * TestWebKitAPI/PlatformWin.cmake:
300         Copy forwarding headers from WebCore before building in case that was not yet done.
301         It used to be done when running CMake, but now it's a build step.
302
303 2015-08-27  Nan Wang  <n_wang@apple.com>
304
305         AX: Fix accessibility/select-element-at-index.html test
306         https://bugs.webkit.org/show_bug.cgi?id=148516
307
308         Reviewed by Chris Fleizach.
309
310         Implemented setSelectedChildAtIndex and removeSelectionAtIndex for mac.
311
312         * DumpRenderTree/AccessibilityUIElement.cpp:
313         (setSelectedChildCallback):
314         (setSelectedChildAtIndexCallback):
315         (removeSelectionAtIndexCallback):
316         (elementAtPointCallback):
317         (sentenceAtOffsetCallback):
318         (stringForSelectionCallback):
319         (AccessibilityUIElement::getJSClass):
320         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
321         (AccessibilityUIElement::setSelectedChild):
322         (AccessibilityUIElement::setSelectedChildAtIndex):
323         (AccessibilityUIElement::removeSelectionAtIndex):
324         (AccessibilityUIElement::accessibilityValue):
325         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
326         (WTR::AccessibilityUIElement::wordAtOffset):
327         (WTR::AccessibilityUIElement::lineAtOffset):
328         (WTR::AccessibilityUIElement::sentenceAtOffset):
329         (WTR::AccessibilityUIElement::isSelectable):
330         (WTR::AccessibilityUIElement::isMultiSelectable):
331         (WTR::AccessibilityUIElement::setSelectedChild):
332         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
333         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
334         (WTR::AccessibilityUIElement::selectedChildrenCount):
335         (WTR::AccessibilityUIElement::selectedChildAtIndex):
336         (WTR::AccessibilityUIElement::isExpanded):
337         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
338         (WTR::AccessibilityUIElement::setSelectedChild):
339         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
340         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
341         (WTR::AccessibilityUIElement::accessibilityValue):
342
343 2015-08-27  Alex Christensen  <achristensen@webkit.org>
344
345         Build fix after r188982
346
347         * MiniBrowser/win/CMakeLists.txt:
348         The directory structure changed in the move.
349
350 2015-08-27  Michael Catanzaro  <mcatanzaro@igalia.com>
351
352         [GTK] Unreviewed, install-dependencies should install geoclue2 on Fedora
353
354         geoclue-devel is for obsolete geoclue. Install geoclue2-devel instead.
355
356         * gtk/install-dependencies:
357
358 2015-08-27  Carlos Garcia Campos  <cgarcia@igalia.com>
359
360         Unreviewed. Mark WTF_WordLock.ContendedShortSection as slow too.
361
362         * Scripts/run-gtk-tests:
363         (TestRunner):
364
365 2015-08-27  Carlos Garcia Campos  <cgarcia@igalia.com>
366
367         Fix GTK+ WTR crashes in initializeMainRunLoop()
368
369         Rubber-stamped by Žan Doberšek.
370
371         Initialize threading and main thread before
372         RunLoop::initializeMainRunLoop(), since the GLib implementation of
373         the RunLoop uses isMainThread() to decide whether to create a new
374         GMainContext or use the default one. Also use RunLoop::run() and
375         ::stop() instead of gtk_main/quit.
376
377         * WebKitTestRunner/TestController.cpp:
378         (WTR::TestController::initialize):
379         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
380         (WTR::TestController::notifyDone):
381         (WTR::TestController::platformRunUntil):
382
383 2015-08-27  Filip Pizlo  <fpizlo@apple.com>
384
385         Unreviewed, further shorten a test that times out because it's very long
386         running.
387
388         I've locally run these tests on repeat for 24 hours and found no genuine
389         failures, like deadlocks. So, the timeouts are probably because the test
390         machine is slow and debug is slow. We should just run this test for fewer
391         iterations.
392
393         * TestWebKitAPI/Tests/WTF/Lock.cpp:
394         (TestWebKitAPI::TEST):
395
396 2015-08-26  Ryuan Choi  <ryuan.choi@navercorp.com>
397
398         Unreviewed build fix attempt on EFL
399
400         * WebKitTestRunner/PlatformEfl.cmake:
401
402 2015-08-26  Alex Christensen  <achristensen@webkit.org>
403
404         Build fix after r188982
405
406         * MiniBrowser/win/CMakeLists.txt:
407         Find .rc files in correct directory.
408
409 2015-08-26  Ryuan Choi  <ryuan.choi@navercorp.com>
410
411         [EFL] Bump cairo version to 1.14.2
412         https://bugs.webkit.org/show_bug.cgi?id=148474
413
414         Reviewed by Csaba Osztrogonác.
415
416         * efl/jhbuild.modules:
417
418 2015-08-26  Andy Estes  <aestes@apple.com>
419
420         Crash when following a Google search link to Twitter with Limit Adult Content enabled
421         https://bugs.webkit.org/show_bug.cgi?id=147651
422
423         Rubber-stamped by Brady Eidson.
424
425         Taught TestRunner how to decide the navigation policy after a delay.
426
427         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
428         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
429         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
430         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
431         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
432         * WebKitTestRunner/InjectedBundle/TestRunner.h:
433         (WTR::TestRunner::shouldDecideNavigationPolicyAfterDelay):
434         * WebKitTestRunner/TestController.cpp:
435         (WTR::TestController::initialize):
436         (WTR::TestController::resetStateToConsistentValues):
437         (WTR::TestController::decidePolicyForNavigationAction):
438         * WebKitTestRunner/TestController.h:
439         (WTR::TestController::setShouldDecideNavigationPolicyAfterDelay):
440         * WebKitTestRunner/TestInvocation.cpp:
441         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
442
443 2015-08-26  Brent Fulgham  <bfulgham@apple.com>
444
445         [Win] Rename 'WinLauncher' to 'MiniBrowser'
446         https://bugs.webkit.org/show_bug.cgi?id=148485
447
448         Reviewed by Alex Christensen
449
450         Move the WinLauncher project and source files to a subdirectory
451         of MiniBrowser. Globally change WinLauncher -> MiniBrowser in the
452         source code and project files.
453         
454         * MiniBrowser/MiniBrowser.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj.
455         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.ico: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.ico.
456         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.rc: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.rc.
457         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.
458         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj.filters: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters.
459         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCF.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props.
460         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCFLite.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props.
461         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCommon.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props.
462         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserDebug.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props.
463         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc.
464         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.
465         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj.filters: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters.
466         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibCommon.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props.
467         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibDebug.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props.
468         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPostBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd.
469         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPreBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd.
470         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibProduction.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props.
471         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibRelease.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props.
472         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h.
473         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPostBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherPostBuild.cmd.
474         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPreBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd.
475         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserProduction.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props.
476         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserRelease.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props.
477         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserResource.h: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h.
478         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.ico: Removed.
479         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.rc: Removed.
480         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.vcxproj: Removed.
481         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.vcxproj.filters: Removed.
482         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCF.props: Removed.
483         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCFLite.props: Removed.
484         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCommon.props: Removed.
485         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherDebug.props: Removed.
486         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.rc: Removed.
487         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.vcxproj: Removed.
488         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
489         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibCommon.props: Removed.
490         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibDebug.props: Removed.
491         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
492         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
493         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibProduction.props: Removed.
494         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibRelease.props: Removed.
495         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibResource.h: Removed.
496         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherPostBuild.cmd: Removed.
497         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherPreBuild.cmd: Removed.
498         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherProduction.props: Removed.
499         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherRelease.props: Removed.
500         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherResource.h: Removed.
501         * MiniBrowser/win: Copied from WinLauncher.
502         * MiniBrowser/win/Common.cpp:
503         * MiniBrowser/win/MiniBrowser.cpp: Copied from WinLauncher/WinLauncher.cpp.
504         * MiniBrowser/win/MiniBrowser.h: Copied from WinLauncher/WinLauncher.h.
505         * MiniBrowser/win/MiniBrowserReplace.h: Copied from WinLauncher/WinLauncherReplace.h.
506         * MiniBrowser/win/MiniBrowserWebHost.cpp: Copied from WinLauncher/WinLauncherWebHost.cpp.
507         * MiniBrowser/win/MiniBrowserWebHost.h: Copied from WinLauncher/WinLauncherWebHost.h.
508         * MiniBrowser/win/PageLoadTestClient.cpp:
509         * MiniBrowser/win/PageLoadTestClient.h:
510         * MiniBrowser/win/ResourceLoadDelegate.cpp:
511         * MiniBrowser/win/ResourceLoadDelegate.h:
512         * MiniBrowser/win/WinLauncher.cpp: Removed.
513         * MiniBrowser/win/WinLauncher.h: Removed.
514         * MiniBrowser/win/WinLauncher.vcxproj: Removed.
515         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.ico: Removed.
516         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.rc: Removed.
517         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.vcxproj: Removed.
518         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Removed.
519         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCF.props: Removed.
520         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCFLite.props: Removed.
521         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCommon.props: Removed.
522         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherDebug.props: Removed.
523         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.rc: Removed.
524         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Removed.
525         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
526         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibCommon.props: Removed.
527         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibDebug.props: Removed.
528         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
529         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
530         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibProduction.props: Removed.
531         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibRelease.props: Removed.
532         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibResource.h: Removed.
533         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherPostBuild.cmd: Removed.
534         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherPreBuild.cmd: Removed.
535         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherProduction.props: Removed.
536         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherRelease.props: Removed.
537         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherResource.h: Removed.
538         * MiniBrowser/win/WinLauncher.vcxproj/small.ico: Removed.
539         * MiniBrowser/win/WinLauncherReplace.h: Removed.
540         * MiniBrowser/win/WinLauncherWebHost.cpp: Removed.
541         * MiniBrowser/win/WinLauncherWebHost.h: Removed.
542         * MiniBrowser/win/WinMain.cpp:
543         * WinLauncher: Removed.
544         * WinLauncher/AccessibilityDelegate.cpp: Removed.
545         * WinLauncher/AccessibilityDelegate.h: Removed.
546         * WinLauncher/CMakeLists.txt: Removed.
547         * WinLauncher/Common.cpp: Removed.
548         * WinLauncher/DOMDefaultImpl.cpp: Removed.
549         * WinLauncher/DOMDefaultImpl.h: Removed.
550         * WinLauncher/PageLoadTestClient.cpp: Removed.
551         * WinLauncher/PageLoadTestClient.h: Removed.
552         * WinLauncher/PrintWebUIDelegate.cpp: Removed.
553         * WinLauncher/PrintWebUIDelegate.h: Removed.
554         * WinLauncher/ResourceLoadDelegate.cpp: Removed.
555         * WinLauncher/ResourceLoadDelegate.h: Removed.
556         * WinLauncher/WebDownloadDelegate.cpp: Removed.
557         * WinLauncher/WebDownloadDelegate.h: Removed.
558         * WinLauncher/WinLauncher.cpp: Removed.
559         * WinLauncher/WinLauncher.h: Removed.
560         * WinLauncher/WinLauncher.vcxproj: Removed.
561         * WinLauncher/WinLauncher.vcxproj/WinLauncher.ico: Removed.
562         * WinLauncher/WinLauncher.vcxproj/WinLauncher.rc: Removed.
563         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Removed.
564         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Removed.
565         * WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props: Removed.
566         * WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props: Removed.
567         * WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props: Removed.
568         * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props: Removed.
569         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Removed.
570         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Removed.
571         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
572         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Removed.
573         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props: Removed.
574         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
575         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
576         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props: Removed.
577         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props: Removed.
578         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Removed.
579         * WinLauncher/WinLauncher.vcxproj/WinLauncherPostBuild.cmd: Removed.
580         * WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd: Removed.
581         * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props: Removed.
582         * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props: Removed.
583         * WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h: Removed.
584         * WinLauncher/WinLauncher.vcxproj/small.ico: Removed.
585         * WinLauncher/WinLauncherReplace.h: Removed.
586         * WinLauncher/WinLauncherWebHost.cpp: Removed.
587         * WinLauncher/WinLauncherWebHost.h: Removed.
588         * WinLauncher/WinMain.cpp: Removed.
589         * WinLauncher/resource.h: Removed.
590         * WinLauncher/stdafx.cpp: Removed.
591         * WinLauncher/stdafx.h: Removed.
592         * win/AssembleBuildLogs/AssembleLogs.cmd:
593
594 2015-08-26  Brent Fulgham  <bfulgham@apple.com>
595
596         [Win] Simplify menu handling code in WinLauncher
597         https://bugs.webkit.org/show_bug.cgi?id=148461
598
599         Reviewed by Zalan Bujtas.
600
601         Revise 'ToggleMenuItem' to return a boolean value indicating if
602         it handled the message. Revise WndProc to use this to decide if it
603         should pass the message on to the default handler, rather than
604         duplicating the logic in both places.
605         
606         * WinLauncher/Common.cpp:
607         (ToggleMenuItem): Return true if the menu item message was handled.
608         (WndProc): If 'ToggleMenuItem' did not handle the message, pass
609         the message tothe default handler.
610
611 2015-08-26  Csaba Osztrogonác  <ossy@webkit.org>
612
613         Remove unused code after r188948
614         https://bugs.webkit.org/show_bug.cgi?id=148467
615
616         Reviewed by Gyuyoung Kim.
617
618         * WebKitTestRunner/TestController.cpp:
619         (WTR::TestController::platformPreferences): Deleted.
620
621 2015-08-26  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
622
623         [EFL][GTK] REGRESSION(r188828): All performance tests and almost all layout tests crash
624         https://bugs.webkit.org/show_bug.cgi?id=148377
625
626         Reviewed by Carlos Garcia Campos.
627
628         EFL and GTK don't support TestController::platformPreferences() yet which was introduced by r188828.
629         It caused all crashes of layout test and performance test on EFL and GTK. So this patch implements
630         TestController::platformPreferences() using WKPageGroupGetPreferences() which was previous thing for
631         EFL and GTK at the moment.
632
633         * WebKitTestRunner/TestController.cpp:
634         (WTR::TestController::platformWillRunTest):
635         * WebKitTestRunner/efl/TestControllerEfl.cpp:
636         (WTR::TestController::platformPreferences):
637         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
638         (WTR::TestController::platformPreferences):
639
640 2015-08-25  Nan Wang  <n_wang@apple.com>
641
642         AX: Enable accessibility/aria-controls.html test for mac
643         https://bugs.webkit.org/show_bug.cgi?id=148458
644
645         Reviewed by Chris Fleizach.
646
647         Implemented ariaControlsElementAtIndex(unsigned index).
648
649         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
650         (AccessibilityUIElement::ariaControlsElementAtIndex):
651         (AccessibilityUIElement::disclosedRowAtIndex):
652         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
653         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
654
655 2015-08-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
656
657         Remove python tests for PassRefPtr 
658         https://bugs.webkit.org/show_bug.cgi?id=148463
659
660         Reviewed by Andy Estes.
661
662         As we're removing uses of PassRefPtr, we need to remove all python tests for PassRefPtr as well.
663
664         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
665         (PassPtrTest): Deleted.
666         (PassPtrTest.assert_pass_ptr_check): Deleted.
667         (PassPtrTest.test_pass_ref_ptr_in_function): Deleted.
668         (PassPtrTest.test_pass_other_type_ptr_in_function): Deleted.
669         (PassPtrTest.test_pass_ref_ptr_return_value): Deleted.
670         (PassPtrTest.test_ref_ptr_parameter_value): Deleted.
671         (PassPtrTest.test_ref_ptr_member_variable): Deleted.
672         (PassPtrTest.test_ref_ptr_member_variable.Foo): Deleted.
673
674 2015-08-25  Andy Estes  <aestes@apple.com>
675
676         [iOS] run-webkit-tests fails if watchOS SDK is installed
677         https://bugs.webkit.org/show_bug.cgi?id=148453
678
679         Reviewed by David Kilzer.
680
681         * Scripts/webkitpy/xcode/simulator.py:
682         (Simulator): Taught Simulator how to parse watchOS runtimes and devices.
683         * Scripts/webkitpy/xcode/simulator_unittest.py: Added tests.
684
685 2015-08-25  Aakash Jain  <aakash_jain@apple.com>
686
687         iOS Simulator layout-tests fail to start while cleaning a directory structure if simulator is already running
688         https://bugs.webkit.org/show_bug.cgi?id=148197
689         rdar://problem/22334382
690
691         Reviewed by Daniel Bates.
692
693         * BuildSlaveSupport/kill-old-processes: Add Simulator to the list of processes to kill (for iOS builders).
694         * Scripts/webkitpy/port/ios.py:
695         (IOSSimulatorPort): Converted bundle id com.apple.iphonesimulator to a variable SIMULATOR_BUNDLE_ID.
696         (IOSSimulatorPort._quitIOSSimulator): Common function to quit iOS Simulator.
697         (IOSSimulatorPort.clean_up_test_run): Quit the simulator during the cleanup.
698         (IOSSimulatorPort.check_sys_deps): No need to quit the simulator here as its now being quit in reset_preferences().
699         (IOSSimulatorPort.reset_preferences): Quit the simulator before trying to delete associated data directory.
700
701 2015-08-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
702
703         Remove PassRefPtr style check rule
704         https://bugs.webkit.org/show_bug.cgi?id=148432
705
706         Reviewed by Andreas Kling.
707
708         PassRefPtr is being removed. Thus style rule needs to be removed as well.
709
710         * Scripts/webkitpy/style/checkers/cpp.py:
711         (_check_parameter_name_against_text): Deleted.
712         (check_function_definition_and_pass_ptr): Deleted.
713         (check_function_definition): Deleted.
714         (check_pass_ptr_usage): Deleted.
715         (process_line): Deleted.
716         (CppChecker): Deleted.
717
718 2015-08-25  Brent Fulgham  <bfulgham@apple.com>
719
720         [Win] Expose "Inverted Colors" option in WinLauncher
721         https://bugs.webkit.org/show_bug.cgi?id=148451
722
723         Reviewed by Tim Horton.
724
725         Add the ability to toggle the "Inverted Colors" preference
726         in WinLauncher.
727         
728         * WinLauncher/Common.cpp:
729         (ToggleMenuItem): Toggle the feature when the menu item
730         is selected.
731         (WndProc): Recognize the new menu option.
732         * WinLauncher/WinLauncher.cpp:
733         (WinLauncher::setToDefaultPreferences): Launch with "Invert
734         Colors" turned off.
735         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add menu
736         entry for "Invert Colors".
737         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:
738
739 2015-08-25  Nan Wang  <n_wang@apple.com>
740
741         [Mac] accessibility/document-attributes.html fails
742         https://bugs.webkit.org/show_bug.cgi?id=116636
743
744         Reviewed by Chris Fleizach.
745
746         Implemented documentURI() and documentEncoding().
747
748         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
749         (AccessibilityUIElement::documentEncoding):
750         (AccessibilityUIElement::documentURI):
751         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
752         (WTR::AccessibilityUIElement::documentEncoding):
753         (WTR::AccessibilityUIElement::documentURI):
754
755 2015-08-24  Brent Fulgham  <bfulgham@apple.com>
756
757         [Win] Unreviewed test gardening.
758
759         Fix another case where the logging string is constructed using the variable 'frame',
760         but the method argument is not given a name. This causes the global 'frame' value to
761         be used, producing incorrect output.
762
763         * DumpRenderTree/win/FrameLoadDelegate.cpp:
764         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): Use 'frame'
765         argument.
766
767 2015-08-24  Tim Horton  <timothy_horton@apple.com>
768
769         (Finally...) get rid of WKViewIOS
770         https://bugs.webkit.org/show_bug.cgi?id=148404
771
772         Reviewed by Anders Carlsson.
773
774         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
775         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
776         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
777         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
778         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
779         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
780         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
781         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
782         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
783         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.mm:
784         Mark tests that use WKBrowsingContextController as Mac-only.
785
786         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
787         (WTR::AccessibilityController::addNotificationListener):
788         * WebKitTestRunner/ios/mainIOS.mm:
789         (-[WebKitTestRunnerApp applicationDidEnterBackground:]):
790         Import UIKit instead of depending on WKView.h to do so.
791
792 2015-08-24  Jason Marcell  <jmarcell@apple.com>
793
794         Add support to dashboard for displaying Git SHA's as revisions.
795         https://bugs.webkit.org/show_bug.cgi?id=148387
796
797         Reviewed by Daniel Bates.
798
799         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
800         (parseRevisionProperty): Added support to dashboard for displaying Git SHA's as revisions.
801         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
802         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
803         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Added
804         "isSVN" property to Dashboard.Repository.(OpenSource|Internal).
805
806 2015-08-24  Andy Estes  <aestes@apple.com>
807
808         REGRESSION (r188851): WebKit2.BundleParameters fails on iOS
809
810         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Specify LD_RUNPATH_SEARCH_PATHS correctly for iOS.
811
812 2015-08-23  Andy Estes  <aestes@apple.com>
813
814         Addressed a missed piece of review feedback from r188851.
815
816         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
817
818 2015-08-23  Andy Estes  <aestes@apple.com>
819
820         [Content Filtering] REGRESSION (r182356): Provisional URL is incorrect in didReceiveServerRedirectForProvisionalLoadForFrame when Content Filtering is enabled
821         https://bugs.webkit.org/show_bug.cgi?id=147872
822         rdar://problem/22044000
823
824         Reviewed by Dan Bernstein.
825         
826         Added an API test.
827
828         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Linked libWebCoreTestSupport in order to use MockContentFilter.
829         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
830         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Added.
831         (-[ServerRedirectNavigationDelegate webView:didStartProvisionalNavigation:]): Expect the initial request URL.
832         (-[ServerRedirectNavigationDelegate webView:didReceiveServerRedirectForProvisionalNavigation:]): Expect the redirect URL.
833         (-[ServerRedirectNavigationDelegate webView:didCommitNavigation:]):
834         (TEST): Tested that -[WKWebView URL] is updated after a redirect when content filtering is enabled.
835         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Added.
836         (+[ServerRedirectPlugIn initialize]): Enable MockContentFilter.
837         * TestWebKitAPI/cocoa/TestProtocol.h: Renamed from Tools/TestWebKitAPI/mac/TestProtocol.h.
838         * TestWebKitAPI/cocoa/TestProtocol.mm: Renamed from Tools/TestWebKitAPI/mac/TestProtocol.mm.
839
840 2015-08-23  Andy Estes  <aestes@apple.com>
841
842         Fixed the 32-bit Mac build after r188844.
843
844         * TestWebKitAPI/WKWebViewConfigurationExtras.h:
845         * TestWebKitAPI/WKWebViewConfigurationExtras.mm:
846
847 2015-08-22  Andy Estes  <aestes@apple.com>
848
849         [Cocoa] API tests using the Modern WebKit API should be able to create web process plug-ins
850         https://bugs.webkit.org/show_bug.cgi?id=148317
851
852         Reviewed by Dan Bernstein.
853
854         Added the ability for Modern WebKit API tests to create WKWebProcessPlugIns. A test can create a plug-in by
855         creating a class that conforms to WKWebProcessPlugIn, adding it to the WebProcessPlugIn target, and using the
856         WKWebViewConfiguration returned by +[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]
857         when creating WKWebViews.
858
859         Since TestWebKitAPI relies on a bundle parameter to know which test class to instantiate in the plug-in, I also
860         added a new API test for bundle parameters.
861
862         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Added. Named the bundle TestWebKitAPI.wkbundle and
863         named its executable TestWebKitAPI.bundle.
864         * TestWebKitAPI/PlatformUtilities.h: Declared TestPlugInClassNameParameter.
865         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added the WebProcessPlugIn target.
866         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm: Added.
867         (TEST): Tested bundle parameters by verifying that parameter changes in the UI process are observed in the bundle.
868         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm: Added.
869         (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]): Started observing changes to a
870         bundle parameter and asked for an initial notification.
871         (-[BundleParametersPlugIn dealloc]): Stopped observing changes to a bundle parameter.
872         (-[BundleParametersPlugIn observeValueForKeyPath:ofObject:change:context:]): When a bundle parameter changes,
873         mirror its value in the main frame's JSContext.
874         * TestWebKitAPI/WKWebViewConfigurationExtras.h: Added.
875         * TestWebKitAPI/WKWebViewConfigurationExtras.mm: Added.
876         (+[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]): Created a configuration with
877         TestWebKitAPI's bundle URL and set a bundle parameter indicating the test plug-in's class name.
878         * TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm: Defined TestPlugInClassNameParameter.
879         * TestWebKitAPI/cocoa/WebProcessPlugIn/Info.plist: Added. Set the principal class to WebProcessPlugIn.
880         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm: Added.
881         (-[WebProcessPlugIn webProcessPlugIn:initializeWithObject:]): Forwarded to a newly-created test class instance.
882         (-[WebProcessPlugIn respondsToSelector:]): Returned YES if the test class instance response.
883         (-[WebProcessPlugIn forwardingTargetForSelector:]): Forwarded unimplemented methods to the test class instance.
884
885 2015-08-23  Csaba Osztrogonác  <ossy@webkit.org>
886
887         URTBF after r188828.
888
889         * WebKitTestRunner/PlatformWebView.h:
890
891 2015-08-23  Alexey Proskuryakov  <ap@apple.com>
892
893         build.webkit.org/dashboard: Combined queues don't turn orange on internal failure
894         https://bugs.webkit.org/show_bug.cgi?id=148356
895
896         Reviewed by Darin Adler.
897
898         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
899         (BuildbotCombinedQueueView.prototype.update):
900
901 2015-08-23  Alexey Proskuryakov  <ap@apple.com>
902
903         build.webkit.org/dashboard: Respect step's hidden flag
904         https://bugs.webkit.org/show_bug.cgi?id=148357
905
906         Reviewed by Darin Adler.
907
908         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
909         (BuildbotIteration.prototype._parseData):
910
911 2015-08-23  Nan Wang  <n_wang@apple.com>
912
913         AX: Fix accessibility/deleting-iframe-destroys-axcache.html test
914         https://bugs.webkit.org/show_bug.cgi?id=148328
915
916         Reviewed by Darin Adler.
917
918         We should only expose stringValue() when value attribute is set.
919
920         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
921         (AccessibilityUIElement::stringValue):
922         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
923         (WTR::AccessibilityUIElement::stringValue):
924
925 2015-08-23  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
926
927         Remove style checking rule regarding OwnPtr and PassOwnPtr
928         https://bugs.webkit.org/show_bug.cgi?id=148360
929
930         Reviewed by Darin Adler.
931
932         OwnPtr and PassOwnPtr were totally removed though, style rule is still alive.
933         Removed it.
934
935         * Scripts/do-webcore-rename:
936         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
937         (PassPtrTest.test_pass_own_ptr_in_function): Deleted.
938         (PassPtrTest.test_pass_ref_ptr_return_value): Deleted.
939         (PassPtrTest.test_own_ptr_parameter_value): Deleted.
940         (WebKitStyleTest.test_names): Deleted.
941
942 2015-08-22  Timothy Horton  <timothy_horton@apple.com>
943
944         WebKitTestRunner should use WKWebView on OS X and iOS
945         https://bugs.webkit.org/show_bug.cgi?id=143743
946         <rdar://problem/16947123>
947
948         Reviewed by Anders Carlsson.
949         Patch by Enrica Casucci and myself.
950
951         * WebKitTestRunner/PlatformWebView.h:
952         (WTR::PlatformWebView::windowSnapshotEnabled): Deleted.
953         Add a PlatformWebView constructor that takes a WKWebViewConfiguration
954         instead of WKContext and WKPageGroup.
955
956         Remove the unused, always-true windowSnapshotEnabled().
957         While technically some platforms don't have window snapshotting,
958         they just return null instead of implementing windowSnapshotEnabled().
959
960         * WebKitTestRunner/TestController.h:
961         * WebKitTestRunner/TestController.cpp:
962         (WTR::TestController::createOtherPage):
963         (WTR::TestController::initialize):
964         (WTR::TestController::createWebViewWithOptions):
965         Delegate to the various platforms for creating PlatformWebView instances,
966         for creating WKContexts, and for accessing WKPreferences,
967         so that they can do special things (like, use WKWebView instead!).
968
969         (WTR::TestController::resetPreferencesToConsistentValues):
970         Make explicit WebKitTestRunner's desired default for two preferences
971         which have differing defaults between the antique and modern API,
972         for consistency's sake.
973
974         (WTR::TestController::resetStateToConsistentValues):
975         Add platformResetStateToConsistentValues.
976
977         * WebKitTestRunner/TestInvocation.cpp:
978         (WTR::TestInvocation::dumpResults):
979         Adjust to the aforementioned removal of windowSnapshotEnabled().
980
981         * WebKitTestRunner/ios/TestControllerCocoa.mm:
982         (WTR::TestController::platformResetStateToConsistentValues):
983         (WTR::TestController::platformPreferences):
984         (WTR::TestController::platformCreateWebView):
985         (WTR::TestController::platformCreateOtherPage):
986         (WTR::TestController::platformInitializeConfiguration):
987         Implement the new platform functions for the Modern WebKit2 API,
988         in a new TestControllerCocoa file that is shared between iOS and Mac.
989         
990         For platformMaybeCreateContext, use the trick that we know we can cast
991         the WKProcessPool to a WKContextRef to retrieve a WKContextRef from
992         WKWebView's configuration.
993
994         Ditto for WKPreferencesRef and WKPreferences.
995
996         Remove user content filters on the WKWebView's userContentController.
997
998         * WebKitTestRunner/mac/TestControllerMac.mm:
999         * WebKitTestRunner/ios/TestControllerIOS.mm:
1000         Move code into TestControllerCocoa.
1001
1002         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1003         (WTR::InjectedBundle::beginTesting):
1004         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1005         (WTR::TestRunner::addUserScript):
1006         (WTR::TestRunner::addUserStyleSheet):
1007         Adopt WKBundlePage API for user scripts/sheets.
1008
1009         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1010         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1011         Make and keep a WKWebView instead of a WKView.
1012         
1013         * WebKitTestRunner/mac/EventSenderProxy.mm:
1014         (WTR::EventSenderProxy::mouseUp):
1015         (WTR::EventSenderProxy::mouseMoveTo):
1016         Reach inside the WKWebView to the WKView when dispatching events.
1017         This is fairly ugly and we should come up with a better solution.
1018         Also, fix some flipping and style errors.
1019
1020 2015-08-22  Michael Catanzaro  <mcatanzaro@igalia.com>
1021
1022         Unreviewed, attempt to fix GTK build after r188718
1023
1024         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1025         (WTR::PlatformWebView::PlatformWebView):
1026
1027 2015-08-21  Commit Queue  <commit-queue@webkit.org>
1028
1029         Unreviewed, rolling out r188807, r188813, and r188815.
1030         https://bugs.webkit.org/show_bug.cgi?id=148349
1031
1032         lots of 32-bit build problems, better to resolve separately
1033         and try again (Requested by thorton on #webkit).
1034
1035         Reverted changesets:
1036
1037         "WebKitTestRunner should use WKWebView on OS X and iOS"
1038         https://bugs.webkit.org/show_bug.cgi?id=143743
1039         http://trac.webkit.org/changeset/188807
1040
1041         "Stop building WebKitTestRunner for 32-bit platforms"
1042         https://bugs.webkit.org/show_bug.cgi?id=143743
1043         http://trac.webkit.org/changeset/188813
1044
1045         "Stop building WebKitTestRunner for 32-bit platforms"
1046         https://bugs.webkit.org/show_bug.cgi?id=143743
1047         http://trac.webkit.org/changeset/188815
1048
1049 2015-08-21  Tim Horton  <timothy_horton@apple.com>
1050
1051         Stop building WebKitTestRunner for 32-bit platforms
1052         https://bugs.webkit.org/show_bug.cgi?id=143743
1053         <rdar://problem/16947123>
1054
1055         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1056         This is a restriction on the valid set, not the desired set.
1057
1058 2015-08-21  Jason Marcell  <jmarcell@apple.com>
1059
1060         Make Dashboard.Branches be objects of the form (repository, "branch name") and update existing code
1061         to work with these new objects.
1062         https://bugs.webkit.org/show_bug.cgi?id=148188
1063
1064         Reviewed by Daniel Bates.
1065
1066         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1067         (Buildbot.prototype._normalizeQueueInfo): Renamed BuildbotQueue.branch to BuildbotQueue.branches.
1068         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
1069         (BuildbotCombinedQueueView): Changed to work with new branch objects which represent a
1070         (repository, "branch name")-pair.
1071         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Ditto.
1072         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1073         (BuildbotQueue): Renamed BuildbotQueue.branch to BuildbotQueue.branches.
1074         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1075         (BuildbotQueueView.prototype._appendPendingRevisionCount): Changed to work with new branch
1076         objects which represent a (repository, "branch name")-pair.
1077         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
1078         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
1079         (BuildbotQueueView.prototype._addDividerToPopover): Ditto.
1080         (BuildbotQueueView.prototype.revisionContentForIteration): Ditto.
1081         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Renamed
1082         BuildbotQueue.branch to BuildbotQueue.branches.
1083         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1084         (WebKitBuildbot.prototype.get defaultBranches): Changed to new (repository, "branch name") format.
1085
1086 2015-08-21  Tim Horton  <timothy_horton@apple.com>
1087
1088         Stop building WebKitTestRunner for 32-bit platforms
1089         https://bugs.webkit.org/show_bug.cgi?id=143743
1090         <rdar://problem/16947123>
1091
1092         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1093         WKWebView is not available on 32-bit OS X.
1094
1095 2015-08-21  Brent Fulgham  <bfulgham@apple.com>
1096
1097         [Win] Unreviewed test correction after r188709.
1098
1099         I removed a function argument that happened to be mirrored by a global
1100         value with the same name. This prevented a compile error, but testing
1101         showed that the wrong value was being used in the function.
1102
1103         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1104         (FrameLoadDelegate::willPerformClientRedirectToURL): Put function argument
1105         back
1106
1107 2015-08-21  Timothy Horton  <timothy_horton@apple.com>
1108
1109         WebKitTestRunner should use WKWebView on OS X and iOS
1110         https://bugs.webkit.org/show_bug.cgi?id=143743
1111         <rdar://problem/16947123>
1112
1113         Reviewed by Anders Carlsson.
1114         Patch by Enrica Casucci and myself.
1115
1116         * WebKitTestRunner/PlatformWebView.h:
1117         (WTR::PlatformWebView::windowSnapshotEnabled): Deleted.
1118         Add a PlatformWebView constructor that takes a WKWebViewConfiguration
1119         instead of WKContext and WKPageGroup.
1120
1121         Remove the unused, always-true windowSnapshotEnabled().
1122         While technically some platforms don't have window snapshotting,
1123         they just return null instead of implementing windowSnapshotEnabled().
1124
1125         * WebKitTestRunner/TestController.h:
1126         * WebKitTestRunner/TestController.cpp:
1127         (WTR::TestController::createOtherPage):
1128         (WTR::TestController::initialize):
1129         (WTR::TestController::createWebViewWithOptions):
1130         Delegate to the various platforms for creating PlatformWebView instances,
1131         for creating WKContexts, and for accessing WKPreferences,
1132         so that they can do special things (like, use WKWebView instead!).
1133
1134         (WTR::TestController::resetPreferencesToConsistentValues):
1135         Make explicit WebKitTestRunner's desired default for two preferences
1136         which have differing defaults between the antique and modern API,
1137         for consistency's sake.
1138
1139         (WTR::TestController::resetStateToConsistentValues):
1140         Add platformResetStateToConsistentValues.
1141
1142         * WebKitTestRunner/TestInvocation.cpp:
1143         (WTR::TestInvocation::dumpResults):
1144         Adjust to the aforementioned removal of windowSnapshotEnabled().
1145
1146         * WebKitTestRunner/ios/TestControllerCocoa.mm:
1147         (WTR::TestController::platformResetStateToConsistentValues):
1148         (WTR::TestController::platformPreferences):
1149         (WTR::TestController::platformCreateWebView):
1150         (WTR::TestController::platformCreateOtherPage):
1151         (WTR::TestController::platformInitializeConfiguration):
1152         Implement the new platform functions for the Modern WebKit2 API,
1153         in a new TestControllerCocoa file that is shared between iOS and Mac.
1154         
1155         For platformMaybeCreateContext, use the trick that we know we can cast
1156         the WKProcessPool to a WKContextRef to retrieve a WKContextRef from
1157         WKWebView's configuration.
1158
1159         Ditto for WKPreferencesRef and WKPreferences.
1160
1161         Remove user content filters on the WKWebView's userContentController.
1162
1163         * WebKitTestRunner/mac/TestControllerMac.mm:
1164         * WebKitTestRunner/ios/TestControllerIOS.mm:
1165         Move code into TestControllerCocoa.
1166
1167         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1168         (WTR::InjectedBundle::beginTesting):
1169         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1170         (WTR::TestRunner::addUserScript):
1171         (WTR::TestRunner::addUserStyleSheet):
1172         Adopt WKBundlePage API for user scripts/sheets.
1173
1174         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1175         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1176         Make and keep a WKWebView instead of a WKView.
1177         
1178         * WebKitTestRunner/mac/EventSenderProxy.mm:
1179         (WTR::EventSenderProxy::mouseUp):
1180         (WTR::EventSenderProxy::mouseMoveTo):
1181         Reach inside the WKWebView to the WKView when dispatching events.
1182         This is fairly ugly and we should come up with a better solution.
1183         Also, fix some flipping and style errors.
1184
1185 2015-08-21  Alexey Proskuryakov  <ap@apple.com>
1186
1187         Improve how UI events are dispatched by WebKitTestRunner
1188         https://bugs.webkit.org/show_bug.cgi?id=148326
1189
1190         Reviewed by Anders Carlsson.
1191
1192         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1193         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1194         Removed asyncScrolling from mouseScrollByWithWheelAndMomentumPhases, it's now always
1195         asynchronous (and really, it has always been for the most part).
1196
1197         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1198         (WTR::EventSendingController::mouseDown): Updated for WKBundlePagePostSynchronousMessage renaming.
1199         (WTR::EventSendingController::mouseUp): Ditto.
1200         (WTR::EventSendingController::mouseMoveTo): Ditto.
1201         (WTR::EventSendingController::mouseForceDown): Ditto.
1202         (WTR::EventSendingController::mouseForceUp): Ditto.
1203         (WTR::EventSendingController::mouseForceChanged): Ditto.
1204         (WTR::EventSendingController::leapForward): Ditto.
1205         (WTR::EventSendingController::scheduleAsynchronousClick): Ditto.
1206         (WTR::EventSendingController::keyDown): Ditto.
1207         (WTR::EventSendingController::scheduleAsynchronousKeyDown): Ditto.
1208         (WTR::EventSendingController::mouseScrollBy): Force a scrolling tree commit. It used
1209         to be done in custom WebKit2 code for test wheel event handling.
1210         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases): Got rid of sync version.
1211         (WTR::EventSendingController::continuousMouseScrollBy): Added a FIXME. This one is weird.
1212         (WTR::EventSendingController::contextClick): Updated for WKBundlePagePostSynchronousMessage renaming.
1213         (WTR::EventSendingController::addTouchPoint): Ditto.
1214         (WTR::EventSendingController::updateTouchPoint): Ditto.
1215         (WTR::EventSendingController::setTouchModifier): Ditto.
1216         (WTR::EventSendingController::setTouchPointRadius): Ditto.
1217         (WTR::EventSendingController::touchStart): Ditto.
1218         (WTR::EventSendingController::touchMove): Ditto.
1219         (WTR::EventSendingController::touchEnd): Ditto.
1220         (WTR::EventSendingController::touchCancel): Ditto.
1221         (WTR::EventSendingController::clearTouchPoints): Ditto.
1222         (WTR::EventSendingController::releaseTouchPoint): Ditto.
1223         (WTR::EventSendingController::cancelTouchPoint): Ditto.
1224
1225         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1226         (WTR::InjectedBundle::postSetWindowIsKey):
1227         (WTR::InjectedBundle::postSimulateWebNotificationClick):
1228         (WTR::InjectedBundle::isGeolocationProviderActive):
1229         (WTR::InjectedBundle::shouldProcessWorkQueue):
1230         Updated for WKBundlePagePostSynchronousMessage renaming.
1231
1232         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1233         (WTR::TestRunner::secureEventInputIsEnabled): Ditto.
1234
1235         * WebKitTestRunner/TestController.cpp:
1236         (WTR::TestController::initialize): Allow handling the new test style messages.
1237         (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle): Removed calls
1238         to WKPageSetShouldSendEventsSynchronously, which we no longer need.
1239         (WTR::TestController::didReceiveMessageFromInjectedBundle):
1240         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle): Moved
1241         "MouseScrollBy" to async section, and got rid of WKPageSetShouldSendEventsSynchronously.
1242
1243         * WebKitTestRunner/mac/EventSenderProxy.mm:
1244         (WTR::EventSenderProxy::mouseMoveTo): Got rid of WKPageSetShouldSendEventsSynchronously.
1245         (WTR::EventSenderProxy::keyDown): Ditto.
1246         (WTR::EventSenderProxy::mouseScrollBy): Ditto.
1247         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Ditto.
1248
1249 2015-08-21  Yusuke Suzuki  <utatane.tea@gmail.com>
1250
1251         Skip no-llint tests that fail due to running out of executable memory after r188969
1252         https://bugs.webkit.org/show_bug.cgi?id=148273
1253
1254         Reviewed by Michael Saboff.
1255
1256         * Scripts/run-jsc-stress-tests:
1257
1258 2015-08-21  Nan Wang  <n_wang@apple.com>
1259
1260         [Mac] accessibility/selection-states.html fails
1261         https://bugs.webkit.org/show_bug.cgi?id=116637
1262
1263         Reviewed by Chris Fleizach.
1264
1265         Implemented isSelectable() and isMultiSelectable().
1266
1267         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1268         (AccessibilityUIElement::isSelectable):
1269         (AccessibilityUIElement::isMultiSelectable):
1270         (AccessibilityUIElement::isSelectedOptionActive):
1271         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1272         (WTR::AccessibilityUIElement::isSelectable):
1273         (WTR::AccessibilityUIElement::isMultiSelectable):
1274         (WTR::AccessibilityUIElement::isVisible):
1275
1276 2015-08-21  Jason Marcell  <jmarcell@apple.com>
1277
1278         Fix iteration over repositories on bot watcher's dashboard.
1279
1280         Reviewed by Alexey Proskuryakov.
1281
1282         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1283         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Don't reuse the same index variable.
1284
1285 2015-08-20  Joonghun Park  <jh718.park@samsung.com>
1286
1287         [EFL] Revise PlatformWebView ctor according to r188718
1288         https://bugs.webkit.org/show_bug.cgi?id=148282
1289
1290         This patch change PlatformWebView ctor's argument to use WKPageConfigurationRef
1291         instead of WKContextRef and WKPageGroupRef respectively.
1292
1293         Reviewed by Gyuyoung Kim.
1294
1295         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1296         (WTR::PlatformWebView::PlatformWebView):
1297
1298 2015-08-20  Devin Rousso  <dcrousso+webkit@gmail.com>
1299
1300         Unreviewed, changed Devin Rousso's email.
1301
1302         * Scripts/webkitpy/common/config/contributors.json:
1303
1304 2015-08-20  Anders Carlsson  <andersca@apple.com>
1305
1306         Use WKPageConfigurationRef in WebKitTestRunner
1307         https://bugs.webkit.org/show_bug.cgi?id=147996
1308
1309         Reviewed by Tim Horton.
1310
1311         * WebKitTestRunner/TestController.cpp:
1312         (WTR::TestController::createOtherPage):
1313         (WTR::TestController::initialize):
1314         (WTR::TestController::createWebViewWithOptions):
1315         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1316         (-[TestRunnerWKView initWithFrame:configurationRef:useThreadedScrolling:]):
1317         (WTR::PlatformWebView::PlatformWebView):
1318         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useThreadedScrolling:]): Deleted.
1319
1320 2015-08-20  Brent Fulgham  <bfulgham@apple.com>
1321
1322         [Win] Update Windows tools for revised MIDL interfaces
1323         https://bugs.webkit.org/show_bug.cgi?id=148249
1324
1325         Reviewed by Dean Jackson.
1326
1327         This is a follow-up to Bug 148001.
1328
1329         Revise the testing software to use compatible signatures and
1330         implementations to match the requirements of the IDL generated
1331         with the SAL annotations.
1332
1333         * DumpRenderTree/win/DRTDataObject.cpp:
1334         * DumpRenderTree/win/DRTDataObject.h:
1335         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1336         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
1337         * DumpRenderTree/win/DRTDropSource.cpp:
1338         * DumpRenderTree/win/DRTDropSource.h:
1339         * DumpRenderTree/win/DumpRenderTree.cpp:
1340         * DumpRenderTree/win/EditingDelegate.cpp:
1341         * DumpRenderTree/win/EditingDelegate.h:
1342         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1343         * DumpRenderTree/win/FrameLoadDelegate.h:
1344         * DumpRenderTree/win/HistoryDelegate.cpp:
1345         * DumpRenderTree/win/HistoryDelegate.h:
1346         * DumpRenderTree/win/PolicyDelegate.cpp:
1347         * DumpRenderTree/win/PolicyDelegate.h:
1348         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1349         * DumpRenderTree/win/ResourceLoadDelegate.h:
1350         * DumpRenderTree/win/TestRunnerWin.cpp:
1351         * DumpRenderTree/win/UIDelegate.cpp:
1352         * DumpRenderTree/win/UIDelegate.h:
1353         * WinLauncher/AccessibilityDelegate.cpp:
1354         * WinLauncher/AccessibilityDelegate.h:
1355         * WinLauncher/Common.cpp:
1356         * WinLauncher/DOMDefaultImpl.cpp:
1357         * WinLauncher/DOMDefaultImpl.h:
1358         * WinLauncher/PageLoadTestClient.cpp:
1359         * WinLauncher/PageLoadTestClient.h:
1360         * WinLauncher/PrintWebUIDelegate.cpp:
1361         * WinLauncher/PrintWebUIDelegate.h:
1362         * WinLauncher/ResourceLoadDelegate.cpp:
1363         * WinLauncher/ResourceLoadDelegate.h:
1364         * WinLauncher/WebDownloadDelegate.cpp:
1365         * WinLauncher/WebDownloadDelegate.h:
1366         * WinLauncher/WinLauncherWebHost.cpp:
1367         * WinLauncher/WinLauncherWebHost.h:
1368         * WinLauncher/WinMain.cpp:
1369         * win/DLLLauncher/DLLLauncherMain.cpp:
1370
1371 2015-08-20  Filip Pizlo  <fpizlo@apple.com>
1372
1373         Unreviewed, shorten a test that runs too long and times out.
1374
1375         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1376         (TestWebKitAPI::TEST):
1377
1378 2015-08-20  Alex Christensen  <achristensen@webkit.org>
1379
1380         Clean up CMake build after r188673
1381         https://bugs.webkit.org/show_bug.cgi?id=148234
1382
1383         Reviewed by Tim Horton.
1384
1385         * DumpRenderTree/PlatformWin.cmake:
1386         * TestWebKitAPI/CMakeLists.txt:
1387         * TestWebKitAPI/PlatformWin.cmake:
1388         Define WIN_CAIRO so WinCairo executables can find the correct dlls in WebKitLibraries.
1389         gtest needs to be a static library on Windows to not crash.
1390
1391 2015-08-19  Alex Christensen  <achristensen@webkit.org>
1392
1393         CMake Windows build should not include files directly from other Source directories
1394         https://bugs.webkit.org/show_bug.cgi?id=148198
1395
1396         Reviewed by Brent Fulgham.
1397
1398         * DumpRenderTree/DumpRenderTreePrefix.h:
1399         Include cmakeconfig.h to properly define all enabled features.
1400         * DumpRenderTree/PlatformWin.cmake:
1401         * TestWebKitAPI/PlatformWin.cmake:
1402
1403 2015-08-19  Alex Christensen  <achristensen@webkit.org>
1404
1405         Build TestWTF on Mac with CMake.
1406         https://bugs.webkit.org/show_bug.cgi?id=147972
1407
1408         Reviewed by Tim Horton.
1409
1410         TestWTF only depends on gtest and WTF instead of TestWebKitAPi depending on all of WebKit.
1411         Now I can run the WTF API tests after a few seconds of building instead of waiting for all of WebKit to build.
1412
1413         * TestWebKitAPI/CMakeLists.txt:
1414         Added WTF as a dependency for platforms that do not have ForwardingHeadersForTestWebKitAPI_NAME.
1415         WTF was already a library that was linked, but having at least one item makes the syntax of add_dependencies work.
1416         * TestWebKitAPI/PlatformMac.cmake: Added.
1417         * TestWebKitAPI/config.h:
1418         Postpone some build fixes until WebKit builds completely on Mac with CMake.
1419
1420 2015-08-19  Brian Burg  <bburg@apple.com>
1421
1422         Unreviewed, add Aleksandr Skachkov to the list of contributors.
1423
1424         * Scripts/webkitpy/common/config/contributors.json:
1425
1426 2015-08-18  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1427
1428         REGRESSION(r188548): [GTK] Build broken.
1429         https://bugs.webkit.org/show_bug.cgi?id=148154
1430
1431         Reviewed by Martin Robinson.
1432
1433         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1434         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
1435         Even if we don't need to add/override any settings in ViewOptions,
1436         we need to define this as an empty function to make it build.
1437
1438 2015-08-18  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1439
1440         Fix conversion-null warning in conversion.cpp of TestWebKitAPI
1441         https://bugs.webkit.org/show_bug.cgi?id=148073
1442
1443         Reviewed by Alexey Proskuryakov.
1444
1445         * TestWebKitAPI/Tests/WTF/Condition.cpp: Use EXPECT_FALSE instead of EXPECT_EQ.
1446         (TestWebKitAPI::TEST):
1447
1448 2015-08-18  Anders Carlsson  <andersca@apple.com>
1449
1450         Fix test failure fallout from r188602 by using a V5 page ui client struct.
1451
1452         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
1453         (TestWebKitAPI::setUpClients):
1454
1455 2015-08-18  Brian Burg  <bburg@apple.com>
1456
1457         Web Inspector: load ProtocolTestStub from the WebInspectorUI bundle
1458         https://bugs.webkit.org/show_bug.cgi?id=147955
1459
1460         Reviewed by Timothy Hatcher.
1461
1462         To enable sharing of common test code between protocol and model tests,
1463         start loading the protocol TestStub.js through the WebInspectorUI bundle.
1464
1465         This patch adds the read-only getter TestRunner.inspectorTestStubURL, which
1466         protocol-test.js uses to load the inspector frontend stub into its iframe
1467         from an arbitrary local file URL.
1468
1469         * DumpRenderTree/TestRunner.cpp:
1470         (getInspectorTestStubURLCallback):
1471         (TestRunner::staticValues):
1472         * DumpRenderTree/TestRunner.h:
1473         * DumpRenderTree/mac/TestRunnerMac.mm:
1474         (SOFT_LINK_STAGED_FRAMEWORK):
1475         (TestRunner::inspectorTestStubURL):
1476         * DumpRenderTree/win/TestRunnerWin.cpp:
1477         (TestRunner::inspectorTestStubURL):
1478         * WebKitTestRunner/Configurations/Base.xcconfig:
1479         Since WebKitTestRunner now includes WebCore private headers, also search
1480         for the WebCore framework inside the WebKit umbrella framework.
1481
1482         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1483         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1484         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
1485         (WTR::TestRunner::inspectorTestStubURL):
1486         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1487         (WTR::TestRunner::inspectorTestStubURL):
1488         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1489         (WTR::TestRunner::inspectorTestStubURL):
1490
1491 2015-08-18  Filip Pizlo  <fpizlo@apple.com>
1492
1493         Unreviewed, fix GTK build.
1494
1495         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
1496         (TestWebKitAPI::TEST):
1497
1498 2015-08-17  Filip Pizlo  <fpizlo@apple.com>
1499
1500         Replace all remaining uses of WTF::Mutex with WTF::Lock
1501         https://bugs.webkit.org/show_bug.cgi?id=148089
1502
1503         Reviewed by Geoffrey Garen.
1504
1505         * DumpRenderTree/JavaScriptThreading.cpp:
1506         (javaScriptThreadsMutex):
1507         (runJavaScriptThread):
1508         (startJavaScriptThreads):
1509         (stopJavaScriptThreads):
1510         * TestWebKitAPI/Tests/WTF/Condition.cpp: Fixed a bug in the test that I found from turning the test into a benchmark.
1511         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
1512         (TestWebKitAPI::TEST):
1513         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
1514         (TestWebKitAPI::TEST):
1515
1516 2015-08-17  Commit Queue  <commit-queue@webkit.org>
1517
1518         Unreviewed, rolling out r188539, r188544, r188552, and
1519         r188564.
1520         https://bugs.webkit.org/show_bug.cgi?id=148122
1521
1522         Broke tests and some build styles (Requested by ap on
1523         #webkit).
1524
1525         Reverted changesets:
1526
1527         "Web Inspector: load ProtocolTestStub from the WebInspectorUI
1528         bundle"
1529         https://bugs.webkit.org/show_bug.cgi?id=147955
1530         http://trac.webkit.org/changeset/188539
1531
1532         "Web Inspector: split TestStub.js into multiple files and
1533         modernize it"
1534         https://bugs.webkit.org/show_bug.cgi?id=148077
1535         http://trac.webkit.org/changeset/188544
1536
1537         "Web Inspector: InspectorTest should be a subclass of
1538         TestHarness"
1539         https://bugs.webkit.org/show_bug.cgi?id=148079
1540         http://trac.webkit.org/changeset/188552
1541
1542         "Unreviewed internal build fix attempt after r188539."
1543         http://trac.webkit.org/changeset/188564
1544
1545 2015-08-17  Myles C. Maxfield  <mmaxfield@apple.com>
1546
1547         [OS X] Remove support for composite fonts
1548         https://bugs.webkit.org/show_bug.cgi?id=147920
1549
1550         Reviewed by Dan Bernstein.
1551
1552         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1553         * DumpRenderTree/fonts/SampleFont.sfont: Removed.
1554         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1555         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
1556         * DumpRenderTree/mac/DumpRenderTree.mm:
1557         (allowedFontFamilySet): Deleted.
1558         (activateTestingFonts): Deleted.
1559         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1560         (WTR::allowedFontFamilySet): Deleted.
1561         (WTR::activateFonts): Deleted.
1562         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1563         * WebKitTestRunner/fonts/SampleFont.sfont: Removed.
1564         * WebKitTestRunner/mac/TestControllerMac.mm:
1565         (WTR::allowedFontFamilySet): Deleted.
1566
1567 2015-08-17  Jon Honeycutt  <jhoneycutt@apple.com>
1568
1569         Unreviewed internal build fix attempt after r188539.
1570
1571         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1572
1573 2015-08-17  Myles C. Maxfield  <mmaxfield@apple.com>
1574
1575         Fix the build
1576
1577         Unreviewed.
1578
1579         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
1580
1581 2015-08-17  Alex Christensen  <achristensen@webkit.org>
1582
1583         Build Debug Suffix on Windows with CMake
1584         https://bugs.webkit.org/show_bug.cgi?id=148083
1585
1586         Reviewed by Brent Fulgham.
1587
1588         * TestWebKitAPI/CMakeLists.txt:
1589         * TestWebKitAPI/PlatformWin.cmake:
1590         Add DEBUG_SUFFIX
1591
1592 2015-08-17  Anders Carlsson  <andersca@apple.com>
1593
1594         Simplify how PlatformWebViews are created when view options change
1595         https://bugs.webkit.org/show_bug.cgi?id=148093
1596
1597         Reviewed by Sam Weinig.
1598
1599         Instead of letting each port dictate when the PlatformWebView should be recreated we now do the following:
1600
1601         TestController::ensureViewSupportsOptionsForTest gets the view options for a test by calling
1602         TestController::viewOptionsForTest, which returns a filled in ViewOptions struct for a given test. It also allows
1603         ports to add/override settings by calling TestController::updatePlatformSpecificViewOptionsForTest.
1604
1605         If the current PlatformWebView doesn't support the given view options, delete the web view and create a new one.
1606
1607         Also, get rid of the first call to TestController::createWebViewWithOptions in TestController::initialize and
1608         always rely on TestController::ensureViewSupportsOptionsForTest creating a PlatformWebView for us.
1609
1610         * WebKitTestRunner/TestController.cpp:
1611         (WTR::TestController::ensureViewSupportsOptionsForTest):
1612         (WTR::shouldUseFixedLayout):
1613         (WTR::TestController::viewOptionsForTest):
1614         (WTR::TestController::updateWebViewSizeForTest):
1615         (WTR::TestController::updateWindowScaleForTest):
1616         (WTR::TestController::configureViewForTest):
1617         (WTR::TestController::initialize): Deleted.
1618         (WTR::TestController::ensureViewSupportsOptions): Deleted.
1619         (WTR::TestController::updateLayoutTypeForTest): Deleted.
1620         (WTR::TestController::platformConfigureViewForTest): Deleted.
1621         (WTR::TestController::platformResetPreferencesToConsistentValues): Deleted.
1622         (WTR::TestController::run): Deleted.
1623         * WebKitTestRunner/TestController.h:
1624         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1625         (WTR::shouldUseFixedLayout):
1626         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
1627         (WTR::TestController::platformConfigureViewForTest):
1628         (WTR::TestController::platformResetPreferencesToConsistentValues):
1629         * WebKitTestRunner/ios/TestControllerIOS.mm:
1630         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
1631         * WebKitTestRunner/mac/TestControllerMac.mm:
1632         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
1633         (WTR::TestController::platformConfigureViewForTest):
1634
1635 2015-08-17  Sam Weinig  <sam@webkit.org>
1636
1637         API::PageConfiguration's sessionID needs to be set whenever the API::WebsiteDataStore is set
1638         https://bugs.webkit.org/show_bug.cgi?id=148097
1639
1640         Reviewed by Anders Carlsson.
1641
1642         * TestWebKitAPI/Tests/WebKit2/WKPageConfiguration.cpp:
1643         Add tests for WebsiteDataStores in the WKPageConfiguration.
1644
1645 2015-08-17  Brian Burg  <bburg@apple.com>
1646
1647         Web Inspector: load ProtocolTestStub from the WebInspectorUI bundle
1648         https://bugs.webkit.org/show_bug.cgi?id=147955
1649
1650         Reviewed by Timothy Hatcher.
1651
1652         To enable sharing of common test code between protocol and model tests,
1653         start loading the protocol TestStub.js through the WebInspectorUI bundle.
1654
1655         This patch adds the read-only getter TestRunner.inspectorTestStubURL, which
1656         protocol-test.js uses to load the inspector frontend stub into its iframe
1657         from an arbitrary local file URL.
1658
1659         * DumpRenderTree/TestRunner.cpp:
1660         (getInspectorTestStubURLCallback):
1661         (TestRunner::staticValues):
1662         * DumpRenderTree/TestRunner.h:
1663         * DumpRenderTree/mac/TestRunnerMac.mm:
1664         (SOFT_LINK_STAGED_FRAMEWORK):
1665         (TestRunner::inspectorTestStubURL):
1666         * DumpRenderTree/win/TestRunnerWin.cpp:
1667         (TestRunner::inspectorTestStubURL):
1668         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1669         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1670         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
1671         (WTR::TestRunner::inspectorTestStubURL):
1672         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1673         (WTR::TestRunner::inspectorTestStubURL):
1674         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1675         (WTR::TestRunner::inspectorTestStubURL):
1676
1677 2015-08-17  Saam barati  <sbarati@apple.com>
1678
1679         Change email address from saambarati1@gmail.com to sbarati@apple.com
1680
1681         * Scripts/webkitpy/common/config/contributors.json:
1682
1683 2015-08-17  Jason Marcell  <jmarcell@apple.com>
1684
1685         Refactor BuildbotQueueView._presentPopoverForPendingCommits to work more generically with
1686         repositories other than "openSource" and "internal".
1687         https://bugs.webkit.org/show_bug.cgi?id=147961
1688
1689         Reviewed by Daniel Bates.
1690
1691         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1692         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Refactored to work more
1693         generically with repositories other than "openSource" and "internal".
1694
1695 2015-08-17  Alexey Proskuryakov  <ap@apple.com>
1696
1697         build.webkit.org/dashboard shows yellow when crash-only queues have too many failures
1698         https://bugs.webkit.org/show_bug.cgi?id=148081
1699
1700         Reviewed by Tim Horton.
1701
1702         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1703         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1704
1705 2015-08-11  Andy Estes  <aestes@apple.com>
1706
1707         [Cocoa] Add redirect support to CustomProtocolManager
1708         https://bugs.webkit.org/show_bug.cgi?id=147871
1709
1710         Reviewed by Dan Bernstein.
1711
1712         Updated WebKit2CustomProtocolsTest.MainResource to generate a redirect response.
1713
1714         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
1715         (TestWebKitAPI::TEST): Unregesitered TestProtocol.
1716         * TestWebKitAPI/Tests/WebKit2/custom-protocol-sync-xhr.html: Changed scheme to http.
1717         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1718         (-[CustomProtocolsLoadDelegate browsingContextControllerDidStartProvisionalLoad:]): Expected a certain provisional URL.
1719         (-[CustomProtocolsLoadDelegate browsingContextControllerDidReceiveServerRedirectForProvisionalLoad:]): Ditto.
1720         (-[CustomProtocolsLoadDelegate browsingContextControllerDidCommitLoad:]): Expected a certain committed URL.
1721         (-[CustomProtocolsLoadDelegate browsingContextControllerDidFinishLoad:]): Expected isLoading to be false.
1722         (TestWebKitAPI::TEST): Used the new load delegate and unregistered TestProtocol.
1723         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
1724         (TestWebKitAPI::TEST): Unregistered TestProtocol.
1725         * TestWebKitAPI/mac/TestProtocol.mm: Changed scheme to http.
1726         (+[TestProtocol canInitWithRequest:]): Changed to use property syntax.
1727         (-[TestProtocol startLoading]): Taught to handle redirect responses.
1728
1729 2015-08-13  Andy Estes  <aestes@apple.com>
1730
1731         [Cocoa] Downloads do not start if policy decision is made asynchronously
1732         https://bugs.webkit.org/show_bug.cgi?id=147985
1733
1734         Reviewed by Brady Eidson.
1735
1736         Added a new API test.
1737
1738         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1739         (-[AsynchronousDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1740         (-[AsynchronousDownloadDelegate _downloadDidStart:]):
1741         (TEST):
1742
1743 2015-08-14  Commit Queue  <commit-queue@webkit.org>
1744
1745         Unreviewed, rolling out r187357.
1746         https://bugs.webkit.org/show_bug.cgi?id=148032
1747
1748         webkit-patch generates incorrect patches that cannot be
1749         applied (Requested by dydz on #webkit).
1750
1751         Reverted changeset:
1752
1753         "Call fixChangeLogPatch when generating patches from webkit-
1754         patch"
1755         https://bugs.webkit.org/show_bug.cgi?id=147248
1756         http://trac.webkit.org/changeset/187357
1757
1758 2015-08-14  Jason Marcell  <jmarcell@apple.com>
1759
1760         Refactor BuildbotQueueView._appendPendingRevisionCount to work more generically with repositories
1761         other than "openSource" and "internal".
1762         https://bugs.webkit.org/show_bug.cgi?id=147938
1763
1764         Reviewed by Daniel Bates.
1765
1766         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1767         (BuildbotQueueView.prototype._appendPendingRevisionCount): Refactored to work more generically with
1768         repositories other than "openSource" and "internal".
1769
1770 2015-08-14  Filip Pizlo  <fpizlo@apple.com>
1771
1772         Unreviewed, shorten another test that is timing out.
1773
1774         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1775         (TestWebKitAPI::TEST):
1776
1777 2015-08-13  Aakash Jain  <aakash_jain@apple.com>
1778
1779         AppScale: Assertion hit when hovering a webkit-queue bubble
1780         https://bugs.webkit.org/show_bug.cgi?id=147997
1781
1782         Reviewed by Alexey Proskuryakov.
1783
1784         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js:
1785         (BubbleQueue.prototype.loadDetailedStatus): Strip off http(s) before asserting.
1786
1787 2015-08-13  Lucas Forschler  <lforschler@apple.com>
1788
1789         Teach Scripts/copy-webkitlibraries-to-product-directory to copy the El Capitan Library.
1790         
1791         Unreviewed.
1792         
1793         * Scripts/copy-webkitlibraries-to-product-directory:
1794
1795 2015-08-13  Dewei Zhu  <dewei_zhu@apple.com>
1796
1797         Run benchmark customized Dromaeo should not assume there is an internet connection.
1798         https://bugs.webkit.org/show_bug.cgi?id=147995
1799
1800         Reviewed by Ryosuke Niwa.
1801
1802         Add several dependency js libs to local.
1803
1804         * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch:
1805
1806 2015-08-13  Filip Pizlo  <fpizlo@apple.com>
1807
1808         WTF should have a compact Condition object to use with Lock
1809         https://bugs.webkit.org/show_bug.cgi?id=147986
1810
1811         Reviewed by Geoffrey Garen.
1812
1813         Add a test for WTF::Condition.
1814
1815         * TestWebKitAPI/CMakeLists.txt:
1816         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1817         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1818         * TestWebKitAPI/Tests/WTF/Condition.cpp: Added.
1819         (TestWebKitAPI::TEST):
1820         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1821         (TestWebKitAPI::runLockTest): Change the name of the thread.
1822
1823 2015-08-13  Filip Pizlo  <fpizlo@apple.com>
1824
1825         Unreviewed, shorten another test. It's timing out in debug on some bot.
1826
1827         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1828         (TestWebKitAPI::TEST):
1829
1830 2015-08-12  Filip Pizlo  <fpizlo@apple.com>
1831
1832         WTF::Lock should not suffer from the thundering herd
1833         https://bugs.webkit.org/show_bug.cgi?id=147947
1834
1835         Reviewed by Geoffrey Garen.
1836
1837         Add testing that checks that locks return to a pristine state after contention is over.
1838
1839         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1840         (TestWebKitAPI::LockInspector::isFullyReset):
1841         (TestWebKitAPI::runLockTest):
1842         (TestWebKitAPI::TEST):
1843
1844 2015-08-12  Dewei Zhu  <dewei_zhu@apple.com>
1845
1846         Benchmarks supported by run_benchmark script should not assume we have internet access.
1847         https://bugs.webkit.org/show_bug.cgi?id=147959
1848
1849         Reviewed by Ryosuke Niwa.
1850
1851         For JSBench we should not request jquery.min.js from google through the internet.
1852
1853         * Scripts/webkitpy/benchmark_runner/data/patches/JSBench.patch:
1854
1855 2015-08-12  Jason Marcell  <jmarcell@apple.com>
1856
1857         Refactor BuildbotQueueView.revisionContentForIteration to work more generically with repositories
1858         other than "openSource" and "internal".
1859         https://bugs.webkit.org/show_bug.cgi?id=147796
1860
1861         Reviewed by Daniel Bates.
1862
1863         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1864         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): The "repository" parameter
1865         is now a repository object instead of the repository name, thus we don't have to pass the "trac"
1866         object in separately. Also added an assertion to see if the given repository is in iteration.revision,
1867         and another assertion that, if the previousIteration is non-null, the given repository is in
1868         previousIteration.revision.
1869         (BuildbotQueueView.prototype.revisionContentForIteration): Refactored to work more generically
1870         with repositories other than "openSource" and "internal". Also added an assertion that the returned
1871         fragment has at least one child node.
1872
1873 2015-08-12  Simon Fraser  <simon.fraser@apple.com>
1874
1875         Add a tool that dumps class and struct member layout, showing padding
1876         https://bugs.webkit.org/show_bug.cgi?id=147898
1877
1878         Reviewed by Zalan Bujtas.
1879         
1880         This 'dump-class-layout' script uses the lldb Python bindings to collect data
1881         about data member layout, and displays it.
1882         
1883         Sample output:
1884
1885               +0 { 72} WTF::ListHashSet<WebCore::URL, WebCore::URLHash>::Node
1886               +0 < 56>     WebCore::URL m_value;
1887               +0 <  8>         WTF::String m_string;
1888               +0 <  8>             WTF::RefPtr<WTF::StringImpl> m_impl;
1889               +0 <  8>                 WTF::StringImpl * m_ptr;
1890               +8 <  1>         bool:1 m_isValid;
1891               +8 <  1>         bool:1 m_protocolIsInHTTPFamily;
1892               +9 <  3>         <PADDING>
1893              +12 <  4>         int m_schemeEnd;
1894              +16 <  4>         int m_userStart;
1895              +20 <  4>         int m_userEnd;
1896              +24 <  4>         int m_passwordEnd;
1897              +28 <  4>         int m_hostEnd;
1898              +32 <  4>         int m_portEnd;
1899              +36 <  4>         int m_pathAfterLastSlash;
1900              +40 <  4>         int m_pathEnd;
1901              +44 <  4>         int m_queryEnd;
1902              +48 <  4>         int m_fragmentEnd;
1903              +52 <  4>         <PADDING>
1904              +52 <  4>     <PADDING>
1905              +56 <  8>     WTF::ListHashSetNode<WebCore::URL> * m_prev;
1906              +64 <  8>     WTF::ListHashSetNode<WebCore::URL> * m_next;
1907             Total byte size: 72
1908             Total pad bytes: 11
1909             Padding percentage: 15.28 %
1910
1911         * Scripts/dump-class-layout: Added.
1912         (webkit_build_dir):
1913         (developer_dir):
1914         (import_lldb):
1915         (find_build_directory):
1916         (verify_type):
1917         (verify_type_recursive):
1918         (dump_class):
1919         (main):
1920         (main.or):
1921
1922 2015-08-12  Alex Christensen  <achristensen@webkit.org>
1923
1924         Fix Debug CMake builds on Windows
1925         https://bugs.webkit.org/show_bug.cgi?id=147940
1926
1927         Reviewed by Chris Dumez.
1928
1929         * DumpRenderTree/PlatformWin.cmake:
1930         * TestWebKitAPI/PlatformWin.cmake:
1931         The BitmapImage test is not enabled on the AppleWin port.
1932         * WinLauncher/CMakeLists.txt:
1933         Debug builds need /NODEFAULTLIB:MSVCRTD, too.
1934
1935 2015-08-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1936
1937         Unreviewed. run-gtk-tests: Use a longer timeout for slow tests.
1938
1939         In r188125 I added a way to mark tests as slow to use a longer
1940         timeout. But it seems it was not enough for
1941         WTF_Lock.ContendedShortSection, so let's try again with a longer
1942         timeout now.
1943
1944         * Scripts/run-gtk-tests:
1945         (TestRunner._run_google_test):
1946
1947 2015-08-12  Yusuke Suzuki  <utatane.tea@gmail.com>
1948
1949         Allow --debug option in run-jsc
1950         https://bugs.webkit.org/show_bug.cgi?id=147923
1951
1952         Reviewed by Csaba Osztrogonác.
1953
1954         When `--debug` option is specified in run-jsc, it runs the JSC shell built in the debug mode.
1955
1956         * Scripts/run-jsc:
1957
1958 2015-08-11  Alex Christensen  <achristensen@webkit.org>
1959
1960         Fix test after build fix in r188286.
1961         https://bugs.webkit.org/show_bug.cgi?id=147907
1962
1963         Reviewed by Anders Carlsson.
1964
1965         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1966         sleep_for can now be used, but we need to include <thread>
1967
1968 2015-08-11  Filip Pizlo  <fpizlo@apple.com>
1969
1970         Always use a byte-sized lock implementation
1971         https://bugs.webkit.org/show_bug.cgi?id=147908
1972
1973         Reviewed by Geoffrey Garen.
1974
1975         All previous tests of Lock are now tests of WordLock. All previous tests of ByteLock are
1976         now tests of Lock.
1977
1978         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1979         (TestWebKitAPI::runLockTest):
1980         (TestWebKitAPI::TEST):
1981
1982 2015-08-11  Alexey Proskuryakov  <ap@apple.com>
1983
1984         Make ASan build not depend on asan.xcconfig
1985         https://bugs.webkit.org/show_bug.cgi?id=147840
1986         rdar://problem/21093702
1987
1988         Reviewed by Daniel Bates.
1989
1990         * asan/asan.xcconfig:
1991         * asan/webkit-asan-ignore.txt: Removed. It's no longer needed, as unsafe functions
1992         are now marked in source code.
1993
1994 2015-08-11  Filip Pizlo  <fpizlo@apple.com>
1995
1996         Unreviewed, shorten another test since it timed out.
1997
1998         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1999         (TestWebKitAPI::TEST):
2000
2001 2015-08-11  Mark Lam  <mark.lam@apple.com>
2002
2003         Fix names of Lock tests: should be "Contended", not "Contented".
2004         https://bugs.webkit.org/show_bug.cgi?id=147905
2005
2006         Reviewed by Saam Barati.
2007
2008         We're testing the behavior of lock contention (i.e. when threads contend), not
2009         whether the locks are happy (contented).
2010
2011         * Scripts/run-gtk-tests:
2012         (TestRunner):
2013         (TestRunner.__init__): Deleted.
2014         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2015         (TestWebKitAPI::runLockTest):
2016         (TestWebKitAPI::TEST):
2017
2018 2015-08-11  Alex Christensen  <achristensen@webkit.org>
2019
2020         Update WinCairoRequirements to VS2015.
2021
2022         * Scripts/update-webkit-wincairo-libs:
2023         Update WinCairoRequirements location.
2024
2025 2015-08-11  Jason Marcell  <jmarcell@apple.com>
2026
2027         Substituted Dashboard.Repository.OpenSource.trac for webkitTrac and Dashboard.Repository.Internal.trac
2028         for internalTrac.
2029         https://bugs.webkit.org/show_bug.cgi?id=147805
2030
2031         Reviewed by Daniel Bates.
2032
2033         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2034         (BuildbotQueueView): Substituted Dashboard.Repository.OpenSource.trac for webkitTrac and
2035         Dashboard.Repository.Internal.trac for internalTrac.
2036         (BuildbotQueueView.prototype._appendPendingRevisionCount): Added local variables webkitTrac
2037         and internalTrac for Dashboard.Repository.OpenSource.trac and Dashboard.Repository.Internal.trac,
2038         respectively.
2039         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
2040         (BuildbotQueueView.prototype.revisionContentForIteration): Substituted
2041         Dashboard.Repository.OpenSource.trac for webkitTrac and Dashboard.Repository.Internal.trac for
2042         internalTrac.
2043         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js: Ditto.
2044         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Ditto.
2045         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2046         (Analyzer): Ditto.
2047         (Analyzer.prototype.analyze): Ditto.
2048
2049 2015-08-11  Filip Pizlo  <fpizlo@apple.com>
2050
2051         Unreviewed, gardening these tests to run faster so that they don't timeout on slower OSes.
2052
2053         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2054         (TestWebKitAPI::TEST):
2055
2056 2015-08-11  Brent Fulgham  <bfulgham@apple.com>
2057
2058         [Win] Switch Windows build to Visual Studio 2015
2059         https://bugs.webkit.org/show_bug.cgi?id=147887
2060         <rdar://problem/22235098>
2061
2062         Reviewed by Alex Christensen.
2063
2064         Update Visual Studio project file settings to use the current Visual
2065         Studio and compiler. Continue targeting binaries to run on our minimum
2066         supported configuration of Windows 7.
2067
2068         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2069         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
2070         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
2071         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2072         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2073         * Scripts/webkitdirs.pm: Modify our Visual Studio search routines to
2074         prefer the newer MSBuild included in Visual Studio 2015.
2075         (visualStudioInstallDir):
2076         (msBuildInstallDir):
2077         (visualStudioVersion):
2078         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2079         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
2080         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
2081         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
2082         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
2083         * win/record-memory/record-memory.vcxproj:
2084
2085 2015-08-11  Alex Christensen  <achristensen@webkit.org>
2086
2087         Another speculative build fix after r188280.
2088
2089         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2090         std::this_thread is too modern c++ for VS2013 and supported GCC versions, 
2091         so let's go back to usleep and I made something close to usleep, but with much lower resolution.
2092
2093 2015-08-11  Alex Christensen  <achristensen@webkit.org>
2094
2095         Unreviewed build fix after r188280.
2096
2097         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2098         Include DataLog.h, and usleep is not available on Windows, so I used what I think is the c++11 equivalent.
2099
2100 2015-08-10  Filip Pizlo  <fpizlo@apple.com>
2101
2102         WTF should have a ParkingLot for parking sleeping threads, so that locks can fit in 1.6 bits
2103         https://bugs.webkit.org/show_bug.cgi?id=147665
2104
2105         Reviewed by Mark Lam.
2106
2107         * TestWebKitAPI/CMakeLists.txt:
2108         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2109         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2110         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2111         (TestWebKitAPI::TEST):
2112         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp: Added.
2113         (TestWebKitAPI::TEST):
2114
2115 2015-08-11  Brian Burg  <bburg@apple.com>
2116
2117         webkit-patch should not explode when $EDITOR is set incorrectly
2118         https://bugs.webkit.org/show_bug.cgi?id=147884
2119
2120         Reviewed by Darin Adler.
2121
2122         If $EDITOR doesn't exist, log a warning and continue.
2123
2124         * Scripts/webkitpy/common/system/user.py: 
2125         (User.edit):
2126         (User.edit_changelog):
2127
2128 2015-08-11  Dan Bernstein  <mitz@apple.com>
2129
2130         Reverted r188255, because it turned out that delegates do nonot need this information.
2131
2132         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2133         * TestWebKitAPI/Tests/WebKit2Cocoa/PrintFrame.mm: Removed.
2134
2135 2015-08-11  Dan Bernstein  <mitz@apple.com>
2136
2137         [Cocoa] The UI delegate can't tell if printing was user-initiated
2138         https://bugs.webkit.org/show_bug.cgi?id=147869
2139
2140         Reviewed by Sam Weinig.
2141
2142         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2143         * TestWebKitAPI/Tests/WebKit2Cocoa/PrintFrame.mm: Added.
2144         (-[PrintFrameController webView:didFinishNavigation:]):
2145         (-[PrintFrameController _webView:printFrame:userInitiated:]):
2146         (TEST):
2147
2148 2015-08-10  Alex Christensen  <achristensen@webkit.org>
2149
2150         Another build fix after r188239.
2151
2152         * TestWebKitAPI/PlatformWin.cmake:
2153         Link with more libraries.
2154         * WinLauncher/CMakeLists.txt:
2155         /NODEFAULTLIB:MSVCRT is not just needed for AppleWin.
2156
2157 2015-08-10  Ryosuke Niwa  <rniwa@webkit.org>
2158
2159         Build fix after r188237.
2160
2161         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
2162         (BenchmarkBuilder.__enter__):
2163
2164 2015-08-10  Dewei Zhu  <dewei_zhu@apple.com>
2165
2166         Update ReadMe and correct the way to use abstract abstract class.
2167         https://bugs.webkit.org/show_bug.cgi?id=147860
2168
2169         Reviewed by Ryosuke Niwa.
2170
2171         Update ReadMe according to recent changes. And set ABCMeta to be the __metaclass__ of BrowserDriver and HTTPServerDriver,
2172         so that all methods annotated by 'abstractmethod' will check whether they are implememnt by subclasses.
2173
2174         * Scripts/webkitpy/benchmark_runner/README.md:
2175         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2176         (BrowserDriver):
2177         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2178         (OSXBrowserDriver.restore_env):
2179         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
2180         (HTTPServerDriver):
2181         (HTTPServerDriver.set_device_id):
2182         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
2183         (SimpleHTTPServerDriver.get_return_code):
2184         (SimpleHTTPServerDriver):
2185         (SimpleHTTPServerDriver.set_device_id):
2186
2187 2015-08-10  Alex Christensen  <achristensen@webkit.org>
2188
2189         Build TestWebKitAPI with CMake on Windows
2190         https://bugs.webkit.org/show_bug.cgi?id=147851
2191
2192         Reviewed by Chris Dumez.
2193
2194         * CMakeLists.txt:
2195         * TestWebKitAPI/CMakeLists.txt:
2196         Removed TestJavaScriptCore because JavaScriptCore's API tests are elsewhere and this was just making an empty binary.
2197         Surrounded WebKit2-specific features with ENABLE_WEBKIT2 checks.
2198         Include directories after the Platform*.cmake is included because HostWindow.h needs to be found in Tools/TestWebKitAPI/win 
2199         before we look in Source/WebCore/platform, where another file named HostWindow.h exists.
2200         * TestWebKitAPI/PlatformEfl.cmake:
2201         * TestWebKitAPI/PlatformGTK.cmake:
2202         Windows needs all the binaries to be in the same directory to find gtest.dll and the other dlls.
2203         I did this without changing the directory structure of the existing EFL and GTK builds.
2204         * TestWebKitAPI/PlatformWin.cmake: Added.
2205         * TestWebKitAPI/win/main.cpp:
2206         (main):
2207         (dllLauncherEntryPoint):
2208         Added so we can launch TestWebKitAPI executables after finding the AAS directory.
2209         * WinLauncher/CMakeLists.txt:
2210         AppleWin port needs /NODEFAULTLIB:MSVCRT.
2211
2212 2015-08-10  Dewei Zhu  <dewei_zhu@apple.com>
2213
2214         Make cleanup more robust and minor code cleaning in run benchmark script.
2215         https://bugs.webkit.org/show_bug.cgi?id=147800
2216
2217         Reviewed by Ryosuke Niwa.
2218
2219         Use 'finnaly' block to make sure cleanup code is always executed.
2220
2221         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2222         (built_benchmark):
2223         (built_benchmark.__init__):
2224         (built_benchmark.__enter__):
2225         (built_benchmark.__exit__):
2226         (test_environment):
2227         (test_environment.__init__):
2228         (test_environment.__enter__):
2229         (test_environment.__exit__):
2230         (BenchmarkRunner.__init__):
2231         (BenchmarkRunner.execute):
2232         (BenchmarkRunner._dump):
2233         (BenchmarkRunner._wrap):
2234         (BenchmarkRunner): Deleted.
2235         (BenchmarkRunner._cleanup): Deleted.
2236         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2237         (BrowserDriver.close_browsers):
2238         (BrowserDriver):
2239         (BrowserDriver.restore_env):
2240         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
2241         (SimpleHTTPServerDriver.__init__): We do not actually need to know external ip address for now.
2242
2243 2015-08-10  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2244
2245         Compile warning (-Wsign-compare) on 32-bits at WebCore/platform/FileSystem.cpp
2246         https://bugs.webkit.org/show_bug.cgi?id=146414
2247
2248         Reviewed by Darin Adler.
2249
2250         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
2251         (TestWebKitAPI::TEST): Improving testing of WTF::isInBounds.
2252
2253 2015-08-10  Carlos Garcia Campos  <cgarcia@igalia.com>
2254
2255         [GTK] Test  /webkit2/WebKitWebView/submit-form is flaky
2256         https://bugs.webkit.org/show_bug.cgi?id=147727
2257
2258         Reviewed by Sergio Villar Senin.
2259
2260         I think it was not this test in particular, but
2261         /webkit2/WebKitWebView/custom-charset that is affecting the
2262         others. This is because changing the encoding reloads the page,
2263         but we don't wait for the page to be reloaded, so when the test
2264         finishes and other test starts the web process is still reloading
2265         the page.
2266
2267         * Scripts/run-gtk-tests:
2268         (TestRunner): Unskip /webkit2/WebKitWebView/submit-form.
2269         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2270         (testWebViewCustomCharset): Wait until page is reloaded after
2271         changing the charset.
2272
2273 2015-08-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2274
2275         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/install-missing-plugins-permission-request.
2276
2277         It's timing out in the bots. My guess is that there's no installer
2278         installed in the bots and gst_install_plugins_supported() returns
2279         false, so we don't even get a permission request because no
2280         installer will be launched.
2281
2282         * Scripts/run-gtk-tests:
2283         (TestRunner):
2284
2285 2015-08-07  Alex Christensen  <achristensen@webkit.org>
2286
2287         [GTK] Another build fix after r188157.
2288
2289         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2290         (WTR::PlatformWebView::viewSupportsOptions):
2291         Name all the things correctly!
2292
2293 2015-08-07  Alex Christensen  <achristensen@webkit.org>
2294
2295         [EFL, GTK] Build fix after r188176.
2296
2297         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2298         I moved forwarding headers out of a unix subdirectory because I am using them on Windows now.
2299
2300 2015-08-07  Alex Christensen  <achristensen@webkit.org>
2301
2302         [GTK] Speculative build fix after r188157.
2303
2304         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2305         (WTR::PlatformWebView::PlatformWebView):
2306         Update parameter list.
2307
2308 2015-08-07  Alex Christensen  <achristensen@webkit.org>
2309
2310         Build more testing binaries with CMake on Windows
2311         https://bugs.webkit.org/show_bug.cgi?id=147799
2312
2313         Reviewed by Brent Fulgham.
2314
2315         * DumpRenderTree/CMakeLists.txt:
2316         Build TestNetscapePlugin.
2317         * DumpRenderTree/PlatformWin.cmake:
2318         Build ImageDiff and add files necessary for TestNetscapePlugin on Windows.
2319         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders: Added.
2320         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit: Added.
2321         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Copied from DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h.
2322         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Copied from DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h.
2323         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Copied from DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h.
2324         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h: Removed.
2325         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h: Removed.
2326         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h: Removed.
2327
2328 2015-08-07  Jason Marcell  <jmarcell@apple.com>
2329
2330         Refactor BuildbotQueue.compareIterations and BuildbotQueue.compareIterationsByRevisions to be more generic
2331         https://bugs.webkit.org/show_bug.cgi?id=147667
2332
2333         Reviewed by Daniel Bates.
2334
2335         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2336         (BuildbotQueue.prototype.compareIterations): Refactored to work more generically with repositories
2337         other than "openSource" and "internal".
2338         (BuildbotQueue.prototype.compareIterationsByRevisions): Ditto.
2339         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2340         (Dashboard.get sortedPlatforms): Added. Returns a sorted array of platforms.
2341         (Dashboard.get sortedRepositories): Added. Returns a sorted array of repositories.
2342         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2343         (documentReady): Using Dashboard.sortedPlatforms instead of sortedPlatforms.
2344         (sortedPlatforms): Deleted.
2345         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
2346         (buildQueuesTable): Using Dashboard.sortedPlatforms instead of sortedPlatforms.
2347         (sortedPlatforms): Deleted.
2348         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
2349         (sortDictionariesByOrder): Added. Takes an array of dictionaries that have an "order" property
2350         and sorts them by this property returning the new sorted array.
2351
2352 2015-08-07  Filip Pizlo  <fpizlo@apple.com>
2353
2354         Lightweight locks should be adaptive
2355         https://bugs.webkit.org/show_bug.cgi?id=147545
2356
2357         Reviewed by Geoffrey Garen.
2358
2359         * TestWebKitAPI/CMakeLists.txt:
2360         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2361         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2362         * TestWebKitAPI/Tests/WTF/Lock.cpp: Added.
2363         (TestWebKitAPI::runLockTest):
2364         (TestWebKitAPI::TEST):
2365
2366 2015-08-07  Anders Carlsson  <andersca@apple.com>
2367
2368         Fix a tyop.
2369
2370         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2371         (WTR::PlatformWebView::viewSupportsOptions):
2372
2373 2015-08-07  Alexey Proskuryakov  <ap@apple.com>
2374
2375         Update AppEngine app version numbers to the latest commit.
2376
2377         * QueueStatusServer/app.yaml:
2378         * TestResultServer/app.yaml:
2379
2380 2015-08-07  Anders Carlsson  <andersca@apple.com>
2381
2382         Simplify WKTR's view options
2383         https://bugs.webkit.org/show_bug.cgi?id=147791
2384
2385         Reviewed by Sam Weinig.
2386
2387         Instead of using a WKDictionaryRef, just use a struct for the options.
2388
2389         * WebKitTestRunner/PlatformWebView.h:
2390         (WTR::PlatformWebView::options):
2391         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
2392         * WebKitTestRunner/TestController.cpp:
2393         (WTR::TestController::initialize):
2394         (WTR::TestController::createWebViewWithOptions):
2395         (WTR::TestController::ensureViewSupportsOptions):
2396         (WTR::TestController::updateLayoutTypeForTest):
2397         * WebKitTestRunner/TestController.h:
2398         * WebKitTestRunner/ViewOptions.h: Added.
2399         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2400         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2401         (WTR::PlatformWebView::PlatformWebView):
2402         (WTR::PlatformWebView::viewSupportsOptions):
2403         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2404         (WTR::PlatformWebView::viewSupportsOptions):
2405         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2406         (WTR::PlatformWebView::viewSupportsOptions):
2407         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2408         (WTR::PlatformWebView::PlatformWebView):
2409         (WTR::PlatformWebView::viewSupportsOptions):
2410         * WebKitTestRunner/mac/TestControllerMac.mm:
2411         (WTR::TestController::platformConfigureViewForTest):
2412
2413 2015-08-07  Joseph Pecoraro  <pecoraro@apple.com>
2414
2415         Running tests for a long time results in some tests running very slowly (throttling)
2416         https://bugs.webkit.org/show_bug.cgi?id=147718
2417
2418         Reviewed by Chris Dumez.
2419
2420         Follow-up, make DumpRenderTree consistent with WebKitTestRunner.
2421         Although COCOA ports default this setting to be disabled in WebKit1,
2422         we should make both test harnesses disable the setting for consistency.
2423
2424         * DumpRenderTree/mac/DumpRenderTree.mm:
2425         (resetWebPreferencesToConsistentValues):
2426
2427 2015-08-07  Ryosuke Niwa  <rniwa@webkit.org>
2428
2429         Use a specific version of Speedometer in run-benchmark
2430         https://bugs.webkit.org/show_bug.cgi?id=147769
2431
2432         Reviewed by Chris Dumez.
2433
2434         Use the current latest revision as we work towards the bug 147768 (Update frameworks in Speedometer).
2435
2436         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan:
2437
2438 2015-08-07  Ryosuke Niwa  <rniwa@webkit.org>
2439
2440         twisted_http_server.py should support --port
2441         https://bugs.webkit.org/show_bug.cgi?id=147771
2442
2443         Reviewed by Chris Dumez.
2444
2445         Added the option. This makes the script more useful on its own.
2446
2447         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
2448
2449 2015-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2450
2451         [GTK] WTF unit tests are timing out in the bots
2452         https://bugs.webkit.org/show_bug.cgi?id=147777
2453
2454         Reviewed by Filip Pizlo.
2455
2456         Add a way to mark google unit tests as slow and add
2457         WTF_Lock.ContentedShortSection to the list. In case of slow test
2458         we use the double of the given timeout for that particular test.
2459
2460         * Scripts/run-gtk-tests:
2461         (TestRunner):
2462         (TestRunner._run_google_test):
2463
2464 2015-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2465
2466         [GTK] run-gtk-tests should not stop when a google test case fails
2467         https://bugs.webkit.org/show_bug.cgi?id=147778
2468
2469         Reviewed by Philippe Normand.
2470
2471         For glib based tests we run the test runner with the -k option,
2472         but for google tests we are aborting as soon as we find a failure.
2473
2474         * Scripts/run-gtk-tests:
2475         (TestRunner._run_google_test_suite): Use a global return code that
2476         is set to 1 when any test has failed.
2477
2478 2015-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2479
2480         [GStreamer] Do not automatically show PackageKit codec installation notifications
2481         https://bugs.webkit.org/show_bug.cgi?id=135973
2482
2483         Reviewed by Philippe Normand.
2484
2485         Handle the missing media plugins installation permission request
2486         in MiniBrowser and add a test case for the new API.
2487
2488         * MiniBrowser/gtk/BrowserWindow.c:
2489         (webViewDecidePermissionRequest):
2490         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2491         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
2492         (permissionRequestCallback):
2493         (testInstallMissingPluginsPermissionRequest):
2494         (beforeAll):
2495         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2496         (methodCallCallback):
2497
2498 2015-08-06  Joseph Pecoraro  <pecoraro@apple.com>
2499
2500         Running tests for a long time results in some tests running very slowly (throttling)
2501         https://bugs.webkit.org/show_bug.cgi?id=147718
2502
2503         Reviewed by Alexey Proskuryakov.
2504
2505         * WebKitTestRunner/TestController.cpp:
2506         (WTR::TestController::resetPreferencesToConsistentValues):
2507         Ensure throttling settings are disabled for tests for all ports, as
2508         COCOA ports default to having these setting enabled. Note, there is
2509         still other timer throttling not covered by these setting.
2510
2511 2015-08-06  Ryosuke Niwa  <rniwa@webkit.org>
2512
2513         http_server_driver and benchmark_builder should not be in run-benchmark's plan files
2514         https://bugs.webkit.org/show_bug.cgi?id=147752
2515
2516         Reviewed by Chris Dumez.
2517
2518         Removed BenchmarkBuilderFactory since we have exactly one subclass of BenchmarkBuilder.
2519
2520         Also made HTTPServerDriverFactory instantiate the appropriate HTTP server based on the platform name instead of HTTP server name.
2521         This allows us to remove --http-server-driver option from run-benchmark, which was added to support the HTTP server for iOS.
2522
2523         * Scripts/webkitpy/benchmark_runner/benchmark_builder: Removed.
2524         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py: Moved from benchmark_runner/benchmark_builder/generic_benchmark_builder.py.
2525         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Removed.
2526         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builder_factory.py: Removed.
2527         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: Moved to benchmark_runner/benchmark_builder.py.
2528         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2529         (BenchmarkRunner.__init__): No longer takes http_server_driver_override as an argument since this is not handled by
2530         HTTPServerDriverFactory taking the platform name as an argument.
2531         (BenchmarkRunner.execute): Directly instantiate BenchmarkBuilder.
2532         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan: Removed http_server_driver and benchmark_builder.
2533         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan: Ditto.
2534         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan: Ditto.
2535         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Ditto.
2536         * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan: Ditto.
2537         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan: Ditto.
2538         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan: Ditto.
2539         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Ditto.
2540         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan: Ditto.
2541         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py:
2542         (http_server_driver_loader): Register http server drivers via supported platform names instead of http server names.
2543         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
2544         (HTTPServerDriver): Replaced name by platforms.
2545         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
2546         (SimpleHTTPServerDriver): Ditto.
2547         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
2548         (parse_args): Removed --http-server-driver option.
2549         (start): Ditto.
2550
2551 2015-08-06  Chris Dumez  <cdumez@apple.com>
2552
2553         Toggle GPS state based on page visibility to save battery
2554         https://bugs.webkit.org/show_bug.cgi?id=147685
2555
2556         Reviewed by Benjamin Poulain.
2557
2558         Add testRunner.isGeolocationProviderActive() test support function.
2559
2560         * DumpRenderTree/TestRunner.cpp:
2561         (isGeolocationProviderActiveCallback):
2562         (TestRunner::staticFunctions):
2563         * DumpRenderTree/TestRunner.h:
2564         * DumpRenderTree/mac/MockGeolocationProvider.h:
2565         * DumpRenderTree/mac/MockGeolocationProvider.mm:
2566         (-[MockGeolocationProvider isActive]):
2567         * DumpRenderTree/mac/TestRunnerMac.mm:
2568         (TestRunner::isGeolocationProviderActive):
2569         * DumpRenderTree/win/TestRunnerWin.cpp:
2570         (TestRunner::isGeolocationProviderActive):
2571         * WebKitTestRunner/GeolocationProviderMock.h:
2572         (WTR::GeolocationProviderMock::isActive):
2573         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2574         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2575         (WTR::InjectedBundle::isGeolocationProviderActive):
2576         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2577         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2578         (WTR::TestRunner::isGeolocationProviderActive):
2579         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2580         * WebKitTestRunner/TestController.cpp:
2581         (WTR::TestController::isGeolocationProviderActive):
2582         * WebKitTestRunner/TestController.h:
2583         * WebKitTestRunner/TestInvocation.cpp:
2584         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2585
2586 2015-08-06  Ryosuke Niwa  <rniwa@webkit.org>
2587
2588         Automate JSBench with run-benchmark
2589         https://bugs.webkit.org/show_bug.cgi?id=147716
2590
2591         Reviewed by Chris Dumez.
2592
2593         Added JSBench plan to run-benchmark.
2594
2595         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
2596         (GenericBenchmarkBuilder.prepare): Pass in the archive type to _fetch_remote_archive.
2597         (GenericBenchmarkBuilder._fetch_remote_archive): Added the support for extracting files from tar.gz in addition to zip.
2598         * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch: Fixed the coding style.
2599         * Scripts/webkitpy/benchmark_runner/data/patches/JSBench.patch: Added.
2600         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Fixed the coding style.
2601         * Scripts/webkitpy/benchmark_runner/data/patches/Kraken.patch: Ditto.
2602         * Scripts/webkitpy/benchmark_runner/data/patches/Octane.patch: Ditto.
2603         * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch: Ditto.
2604         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan: Specified the archive type.
2605         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan: Specified the archive type.
2606         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan: Ditto.
2607         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Fixed the coding style.
2608         * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan: Added.
2609         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan: Specified the archive type.
2610         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan: Ditto.
2611
2612 2015-08-06  Yusuke Suzuki  <utatane.tea@gmail.com>
2613
2614         Pass-through the undefined options in run-jsc
2615         https://bugs.webkit.org/show_bug.cgi?id=147717
2616
2617         Undefined options in run-jsc is just passed to the actual jsc shell.
2618         We can execute `Tools/Scripts/run-jsc -d`.
2619
2620         Reviewed by Csaba Osztrogonác.
2621
2622         * Scripts/run-jsc:
2623
2624 2015-08-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2625
2626         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/submit-form.
2627
2628         It's flaky.
2629
2630         * Scripts/run-gtk-tests:
2631         (TestRunner):
2632
2633 2015-08-06  Csaba Osztrogonác  <ossy@webkit.org>
2634
2635         [EFL] Bump EFL version to 1.15.0
2636         https://bugs.webkit.org/show_bug.cgi?id=147450
2637
2638         Reviewed by Gyuyoung Kim.
2639
2640         * efl/jhbuild.modules:
2641
2642 2015-08-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2643
2644         Unreviewed. Unksip TestContextMenu GTK+ API test.
2645
2646         This has been skipped for a long time, and it's very
2647         unconvenient. It has never failed for me locally, so let's try
2648         again to see if it works in the bots. I'll skip it again if it
2649         keeps failing.
2650
2651         * Scripts/run-gtk-tests:
2652         (TestRunner):
2653
2654 2015-08-05  Filip Pizlo  <fpizlo@apple.com>
2655
2656         Unreviewed, roll out http://trac.webkit.org/changeset/187972.
2657
2658         * DumpRenderTree/JavaScriptThreading.cpp:
2659         (javaScriptThreadsMutex):
2660         (runJavaScriptThread):
2661         (startJavaScriptThreads):
2662         (stopJavaScriptThreads):
2663         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2664         (TestWebKitAPI::TEST):
2665         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
2666         (TestWebKitAPI::TEST):
2667
2668 2015-08-05  Alex Christensen  <achristensen@webkit.org>
2669
2670         Build DumpRenderTree with CMake.
2671         https://bugs.webkit.org/show_bug.cgi?id=147519
2672
2673         Reviewed by Brent Fulgham.
2674
2675         * CMakeLists.txt:
2676         Build the DumpRenderTree directory now that it builds successfully.
2677         * DumpRenderTree/CMakeLists.txt:
2678         Added missing source file and don't link with WebCore.lib.
2679         * DumpRenderTree/PlatformWin.cmake:
2680         Added sources to DumpRenderTreeLib and made DumpRenderTree only build DLLLauncherMain.cpp. 
2681         * WinLauncher/CMakeLists.txt:
2682         We need libcmt now that we are not linking with WebCore.lib.
2683
2684 2015-08-05  Alexey Proskuryakov  <ap@apple.com>
2685
2686         AppScale: Use https URLs for subresources and links
2687         https://bugs.webkit.org/show_bug.cgi?id=147686
2688
2689         Reviewed by Ryosuke Niwa.
2690
2691         * QueueStatusServer/filters/webkit_extras.py:
2692         * TestResultServer/static-dashboards/dashboard_base.js:
2693         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2694         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2695         * TestResultServer/static-dashboards/treemap.js:
2696         * TestResultServer/static-dashboards/ui.js:
2697
2698 2015-08-04  Filip Pizlo  <fpizlo@apple.com>
2699
2700         Rename Mutex to DeprecatedMutex
2701         https://bugs.webkit.org/show_bug.cgi?id=147675
2702
2703         Reviewed by Geoffrey Garen.
2704
2705         * DumpRenderTree/JavaScriptThreading.cpp:
2706         (javaScriptThreadsMutex):
2707         (runJavaScriptThread):
2708         (startJavaScriptThreads):
2709         (stopJavaScriptThreads):
2710         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2711         (TestWebKitAPI::TEST):
2712         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
2713         (TestWebKitAPI::TEST):
2714
2715 2015-08-05  Timothy Hatcher  <timothy@apple.com>
2716
2717         Update the WebKit nightly icon
2718         https://bugs.webkit.org/show_bug.cgi?id=147684
2719
2720         Reviewed by Sam Weinig.
2721
2722         * WebKitLauncher/webkit.icns: Replaced.
2723
2724 2015-08-05  Daniel Bates  <dabates@apple.com>
2725
2726         REGRESSION (r185111): Clicking phone numbers doesn't prompt to call sometimes
2727         https://bugs.webkit.org/show_bug.cgi?id=147678
2728         <rdar://problem/21827815>
2729
2730         Reviewed by Brady Eidson.
2731
2732         Add a test to ensure that we restore the "should open external URLs" policy on
2733         page reload after the web content process crashes.
2734
2735         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2736         * TestWebKitAPI/Tests/WebKit2/should-open-external-schemes.html: Added.
2737         * TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
2738         (TEST):
2739
2740 2015-08-04  Hunseop Jeong  <hs85.jeong@samsung.com>
2741
2742         [EFL] Editing tests have been broken since r186694
2743         https://bugs.webkit.org/show_bug.cgi?id=146888
2744
2745         Reviewed by Brent Fulgham.
2746
2747         Restored some codes for the context click on GTK+ and EFL port.
2748
2749         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2750         (WTR::EventSendingController::contextClick): Seperated the codes using the PLATFORM guard.
2751
2752 2015-08-04  Dewei Zhu  <dewei_zhu@apple.com>
2753
2754         Install twisted package for http server when necessary.
2755         https://bugs.webkit.org/show_bug.cgi?id=147082
2756
2757         Reviewed by Ryosuke Niwa.
2758
2759         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
2760         * Scripts/webkitpy/thirdparty/__init__.py:
2761         (AutoinstallImportHook.find_module):
2762         (AutoinstallImportHook._install_twisted):
2763
2764 2015-08-04  Brent Fulgham  <bfulgham@apple.com>
2765
2766         [Win] Update Apple Windows build for VS2015
2767         https://bugs.webkit.org/show_bug.cgi?id=147653
2768
2769         Reviewed by Dean Jackson.
2770
2771         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/PluginTest.h: If building with
2772         something older than VS2015, define snprintf as _snprintf.
2773         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props:
2774         Remove unneeded macro definition for snprintf.
2775         * Scripts/webkitpy/common/system/platforminfo.py:
2776         (PlatformInfo._determine_win_version): Recognize Windows 10.
2777         * Scripts/webkitpy/port/win.py:
2778         (WinPort): Ditto.
2779         * Scripts/webkitpy/port/win_unittest.py:
2780         (WinPortTest.test_baseline_search_path): Include Windows 10 in tests.
2781         (WinPortTest._assert_version): Ditto.
2782
2783 2015-08-04  Brian Burg  <bburg@apple.com>
2784
2785         Unreviewed, update email addresses in contributors.json and watchlist.
2786
2787         * Scripts/webkitpy/common/config/contributors.json:
2788         * Scripts/webkitpy/common/config/watchlist:
2789
2790 2015-08-04  Alexey Proskuryakov  <ap@apple.com>
2791
2792         Implement NPAPI redirect handling
2793         https://bugs.webkit.org/show_bug.cgi?id=138675
2794         rdar://problem/15779101
2795
2796         Patch by Jeffrey Pfau, updated and tweaked by me.
2797
2798         Reviewed by Anders Carlsson.
2799
2800         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2801         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
2802         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2803         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2804         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2805         (PluginTest::NPP_URLNotify):
2806         (PluginTest::NPP_URLRedirectNotify):
2807         (PluginTest::NPP_GetValue):
2808         (PluginTest::NPN_GetURLNotify):
2809         (PluginTest::NPN_PostURLNotify):
2810         (PluginTest::NPN_GetValue):
2811         (PluginTest::NPN_ReleaseVariantValue):
2812         (PluginTest::NPN_URLRedirectResponse):
2813         (PluginTest::NPN_ConvertPoint):
2814         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2815         * DumpRenderTree/TestNetscapePlugIn/Tests/URLRedirect.cpp: Added.
2816         (URLRedirect::URLRedirect):
2817         (URLRedirect::ScriptableObject::hasMethod):
2818         (URLRedirect::ScriptableObject::get):
2819         (URLRedirect::ScriptableObject::serviceAsync):
2820         (URLRedirect::ScriptableObject::invoke):
2821         (URLRedirect::NPP_GetValue):
2822         (URLRedirect::NPP_URLNotify):
2823         (URLRedirect::NPP_URLRedirectNotify):
2824         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2825         (NP_GetEntryPoints):
2826         (NPP_URLNotify):
2827         (NPP_URLRedirectNotify):
2828         (NPP_GetValue):
2829
2830 2015-08-04  Tim Horton  <timothy_horton@apple.com>
2831
2832         Move Matt Daiter to committers.
2833
2834         * Scripts/webkitpy/common/config/contributors.json:
2835
2836 2015-08-04  Brent Fulgham  <bfulgham@apple.com>
2837
2838         [Win] build-webkit and MSBuild fight over BuildOutput.htm, causing build failures.
2839         https://bugs.webkit.org/show_bug.cgi?id=147636
2840
2841         Reviewed by Alex Christensen.
2842         
2843         We no longer need build-webkit to manually troll the log data and pipe it to stdout; MSBuild is already doing this properly.
2844         Stop the build-webkit script from interacting with BuildOutput.htm, thereby preventing a potential build failure (especially
2845         on EWS machines)
2846
2847         * Scripts/build-webkit:
2848
2849 2015-08-04  Jason Marcell  <jmarcell@apple.com>
2850
2851         Refactor to convert openSourceRevision and internalRevision properties on BuildbotIteration into a more generic collection of revisions.
2852         https://bugs.webkit.org/show_bug.cgi?id=147280
2853
2854         Reviewed by Daniel Bates.
2855
2856         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2857         (BuildbotIteration): Removed opensourceRevision, internalRevision. Added revision.
2858         Refactored _parseData to handle repositories more generically.
2859         (parseRevisionProperty): Moved a comment up to parseRevisionProperty where it seems more relevant.
2860         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2861         (BuildbotQueue.prototype.compareIterations): Using "revision" property instead of
2862         "opensourceRevision" and "internalRevision".
2863         (BuildbotQueue.prototype.compareIterationsByRevisions): Ditto.
2864         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2865         (BuildbotQueueView.prototype._appendPendingRevisionCount): Ditto.
2866         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
2867         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Changing "internal" boolean
2868         parameter to more generic "repository" string parameter. Added "trac" parameter in order to
2869         specify the trac instance to use. Using "revision" property instead of "opensourceRevision"
2870         and "internalRevision".
2871         (BuildbotQueueView.prototype.revisionContentForIteration): Passing the repository name and trac
2872         instance to _revisionContentWithPopoverForIteration(). Using "revision" property instead of
2873         "opensourceRevision" and "internalRevision".
2874         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Adding
2875         constants for internal and opensource repositories.
2876         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2877         (Analyzer.prototype._findIndexOfLargestIterationAtOrBeforeStart): Using "revision" property
2878         instead of "opensourceRevision" and "internalRevision".
2879         (Analyzer.prototype._countPercentageOfGreen): Ditto.
2880         (Analyzer.prototype.webkitTrac.recordedCommits.forEach): Ditto.
2881         (Analyzer.prototype._countTimes): Ditto.
2882         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2883         (WebKitBuildbot.prototype.layoutTestResultsDirectoryURLForIteration): Ditto.
2884
2885 2015-08-04  Mark Lam  <mark.lam@apple.com>
2886
2887         Removed a local debugging line I accidentally left in from a previous commit.
2888
2889         Not Reviewed.
2890
2891         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
2892
2893 2015-08-04  Mark Lam  <mark.lam@apple.com>
2894
2895         Unreviewed. Make Saam Barati a WebKit reviewer.
2896
2897         * Scripts/webkitpy/common/config/contributors.json:
2898
2899 2015-08-04  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2900
2901         Unreviewed, updated Streams API watchlist.
2902
2903         * Scripts/webkitpy/common/config/watchlist: Matched .*Readable.*Stream.* and .*QueuingStrategy.* in bindings/js.
2904
2905 2015-08-03  Csaba Osztrogonác  <ossy@webkit.org>
2906
2907         [CMake] Add an option to build AllInOne files
2908         https://bugs.webkit.org/show_bug.cgi?id=102647
2909
2910         Reviewed by Alex Christensen.
2911
2912         * Scripts/webkitperl/FeatureList.pm:
2913
2914 2015-08-03  Alexey Proskuryakov  <ap@apple.com>
2915
2916         AppScale: Add required indices
2917         https://bugs.webkit.org/show_bug.cgi?id=147593
2918
2919         Reviewed by Tim Horton.
2920
2921         * QueueStatusServer/index.yaml:
2922
2923 2015-08-03  Filip Pizlo  <fpizlo@apple.com>
2924
2925         Check in LLVM 3.6.2 binary drops for El Capitan
2926         https://bugs.webkit.org/show_bug.cgi?id=147582
2927
2928         Reviewed by Alexey Proskuryakov.
2929         
2930         Recognize 10.11 and use the right drops.
2931
2932         * Scripts/copy-webkitlibraries-to-product-directory:
2933
2934 2015-08-03  Alex Christensen  <achristensen@webkit.org>
2935
2936         [Win] Build fix after r187733.
2937
2938         * WinLauncher/PageLoadTestClient.cpp:
2939         (PageLoadTestClient::dumpRunStatistics):
2940         wtf/MathExtras.h is now included in HashTable.h, which #defines pow to wtf_pow.
2941
2942 2015-08-02  Benjamin Poulain  <bpoulain@apple.com>
2943
2944         Investigate HashTable::HashTable(const HashTable&) and HashTable::operator=(const HashTable&) performance for hash-based static analyses
2945         https://bugs.webkit.org/show_bug.cgi?id=118455
2946
2947         Reviewed by Filip Pizlo.
2948
2949         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2950         (TestWebKitAPI::TEST):
2951
2952 2015-07-31  Alex Christensen  <achristensen@webkit.org>
2953
2954         Prepare for VS2015
2955         https://bugs.webkit.org/show_bug.cgi?id=146579
2956
2957         Reviewed by Jon Honeycutt.
2958
2959         * WinLauncher/stdafx.h:
2960         Define __STDC_LIMIT_MACROS to have access to INTMAX_MAX.
2961
2962 2015-07-31  Csaba Osztrogonác  <ossy@webkit.org>
2963
2964         [EFL] Fix pixman build on ARM with GCC 4.9.3
2965         https://bugs.webkit.org/show_bug.cgi?id=147224
2966
2967         Reviewed by Gyuyoung Kim.
2968
2969         * efl/jhbuild.modules: Disable ARM IWMMXT fast paths as workarounding a GCC bug.
2970
2971 2015-07-30  Anders Carlsson  <andersca@apple.com>
2972
2973         Add support for window.open to WK1BrowserWindowController
2974         https://bugs.webkit.org/show_bug.cgi?id=147474
2975
2976         Reviewed by Dan Bernstein.
2977
2978         * MiniBrowser/mac/WK1BrowserWindowController.m:
2979         (-[WK1BrowserWindowController awakeFromNib]):
2980         Set javaScriptCanOpenWindowsAutomatically to YES. 
2981         If this becomes a nuisance, we can always add a menu item to toggle this.
2982
2983         (-[WK1BrowserWindowController webView:createWebViewWithRequest:]):
2984         Implement this UI delegate method.
2985
2986 2015-07-30  Anders Carlsson  <andersca@apple.com>
2987
2988         Undo stray commit.
2989
2990         * MiniBrowser/mac/WK1BrowserWindowController.m:
2991         (-[WK1BrowserWindowController awakeFromNib]):
2992         (-[WK1BrowserWindowController webView:createWebViewWithRequest:]):
2993
2994 2015-07-29  Dean Jackson  <dino@apple.com>
2995
2996         Don't use (Details) when exposing SPI
2997         https://bugs.webkit.org/show_bug.cgi?id=147426
2998         <rdar://problem/22062407>
2999
3000         Reviewed by Dan Bernstein.
3001
3002         If we are declaring the interface without any implementation,
3003         we should use class extensions.
3004
3005         * DumpRenderTree/mac/DumpRenderTree.mm:
3006         * DumpRenderTree/mac/EventSendingController.mm:
3007         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3008         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3009         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3010         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3011         * WebKitTestRunner/mac/TestControllerMac.mm:
3012
3013 2015-07-30  Aakash Jain  <aakash_jain@apple.com>
3014
3015         Replace Google App Engine with AppScale
3016         https://bugs.webkit.org/show_bug.cgi?id=147178
3017
3018         Reviewed by Daniel Bates.
3019
3020         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3021         (RunWebKitTests):
3022         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
3023         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
3024         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
3025         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3026         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3027         (.):
3028         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3029         (BubbleQueueServer):
3030         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitTestHistory.js:
3031         (TestHistory):
3032         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
3033         * QueueStatusServer/app.yaml: We must explicitly define threadsafe property when using the Python 2.7 runtime. We set threadsafe to be false because the status server code was written to be run in AppEngine's CGI environment and AppEngine's CGI programming model handles requests serially per section "Concurrent Requests and WSGI" of <https://cloud.google.com/appengine/docs/python/python25/migrate27>.
3034         * TestResultServer/app.yaml: Ditto
3035         * Scripts/webkitpy/common/config/urls.py:
3036         * TestResultServer/main.py:
3037         * TestResultServer/static-dashboards/dashboard_base.js:
3038         * TestResultServer/static-dashboards/loader.js:
3039
3040 2015-07-30  Joonghun Park  <jh718.park@samsung.com>
3041
3042         [EFL] Enable IndexedDB based on DatabaseProcess
3043         https://bugs.webkit.org/show_bug.cgi?id=147221
3044
3045         Reviewed by Csaba Osztrogonác.
3046
3047         * Scripts/webkitperl/FeatureList.pm:
3048
3049 2015-07-30  Alex Christensen  <achristensen@webkit.org>
3050
3051         Build AppleWin port with CMake
3052         https://bugs.webkit.org/show_bug.cgi?id=147385
3053
3054         Reviewed by Martin Robinson.
3055
3056         * WinLauncher/CMakeLists.txt:
3057         Link to CoreFoundation.lib and added /NODEFAULTLIB:LIBCMT to get it to link successfully.
3058
3059 2015-07-29  Andy VanWagoner  <thetalecrafter@gmail.com>
3060
3061         Implement basic types for ECMAScript Internationalization API
3062         https://bugs.webkit.org/show_bug.cgi?id=146926
3063
3064         Reviewed by Benjamin Poulain.
3065
3066         Enable flag now that the basic objects are in place.
3067
3068         * Scripts/webkitperl/FeatureList.pm: Enabled INTL
3069
3070 2015-07-28  Carlos Garcia Campos  <cgarcia@igalia.com>
3071
3072         [GTK] Add API to set the maximum number of web processes per WebKitWebContext
3073         https://bugs.webkit.org/show_bug.cgi?id=147108
3074
3075         Reviewed by Gustavo Noronha Silva.
3076
3077         Add test case to check the web process limit.
3078
3079         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
3080         (testWebProcessLimit):
3081         (beforeAll):
3082
3083 2015-07-28  Michael Catanzaro  <mcatanzaro@igalia.com>
3084
3085         [GTK] Missing casts in BrowserWindow.c
3086         https://bugs.webkit.org/show_bug.cgi?id=147395
3087
3088         Reviewed by Carlos Garcia Campos.
3089
3090         * MiniBrowser/gtk/BrowserWindow.c:
3091         (browserWindowSetupEditorToolbar):
3092
3093 2015-07-28  Yusuke Suzuki  <utatane.tea@gmail.com>
3094
3095         [ES6] Add ENABLE_ES6_MODULES compile time flag with the default value "false"
3096         https://bugs.webkit.org/show_bug.cgi?id=147350
3097
3098         Reviewed by Sam Weinig.
3099
3100         * Scripts/webkitperl/FeatureList.pm:
3101
3102 2015-07-28  Michael Catanzaro  <mcatanzaro@igalia.com>
3103
3104         [Freetype] Always allow font matching for strong aliases
3105         https://bugs.webkit.org/show_bug.cgi?id=147057
3106
3107         Reviewed by Martin Robinson.
3108
3109         Create family aliases needed for the new layout tests.
3110
3111         * WebKitTestRunner/gtk/fonts/fonts.conf:
3112
3113 2015-07-28  Alexey Proskuryakov  <ap@apple.com>
3114
3115         webkitbot and WKR unnecessarily rely on webkit-queues.appspot.com
3116         https://bugs.webkit.org/show_bug.cgi?id=147359
3117
3118         Reviewed by Ryosuke Niwa.
3119
3120         * Scripts/webkitpy/tool/commands/newcommitbot.py:
3121         (NewCommitBot.begin_work_queue):
3122         * Scripts/webkitpy/tool/commands/sheriffbot.py:
3123         (SheriffBot.begin_work_queue):
3124
3125 2015-07-27  Alex Christensen  <achristensen@webkit.org>
3126
3127         Use Ninja on Windows.
3128         https://bugs.webkit.org/show_bug.cgi?id=147228
3129
3130         Reviewed by Martin Robinson.
3131
3132         * WinLauncher/CMakeLists.txt:
3133         WinLauncherLib must make WinLauncher.dll, not WinLauncherLib.dll.
3134         * Scripts/build-webkit:
3135         Use Ninja to build WinCairo by default, but fall back to Visual Studio if Ninja is not on the system.
3136
3137 2015-07-24  Jon Honeycutt  <jhoneycutt@apple.com>
3138
3139         Test for bug #147164 "[iOS] Keyboard bold/italic/underline keys don't
3140         highlight after being tapped to style a selection"
3141         https://bugs.webkit.org/show_bug.cgi?id=147278
3142
3143         Reviewed by Ryosuke Niwa.
3144
3145         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3146
3147         * TestWebKitAPI/Tests/mac/WordBoundaryTypingAttributes.mm: Added.
3148         (-[WordBoundaryTypingAttributesController webView:didFinishLoadForFrame:]):
3149         (TestWebKitAPI::TEST):
3150         Load a page with the string "Hello, world!", then select "world" and
3151         underline it. Test that the typing attributes for the current selection
3152         include the underline attribute.
3153
3154 2015-07-24  Hyungwook Lee  <hyungwook.lee@navercorp.com>
3155
3156         Unreviewed, updated my nick name in contributors.json
3157
3158         * Scripts/webkitpy/common/config/contributors.json:
3159
3160 2015-07-24  Chris Fleizach  <cfleizach@apple.com>
3161
3162         AX: scrollable elements do not allow 3-finger swipe
3163         https://bugs.webkit.org/show_bug.cgi?id=141893
3164
3165         Reviewed by Mario Sanchez Prada.
3166
3167         Support global notification listeners for iOS code.
3168         Fix an issue in DRT where the dictionary of data was not being passed back to the layout test for the notication callback.
3169         Implement scrollUp/Down/Left/Right.
3170
3171         * DumpRenderTree/AccessibilityController.h:
3172         * DumpRenderTree/AccessibilityUIElement.cpp:
3173         (increaseTextSelectionCallback):
3174         (scrollPageUpCallback):
3175         (scrollPageDownCallback):
3176         (scrollPageLeftCallback):
3177         (scrollPageRightCallback):
3178         (decreaseTextSelectionCallback):
3179         (getElementTextLengthCallback):
3180         (AccessibilityUIElement::getJSClass):
3181         * DumpRenderTree/AccessibilityUIElement.h:
3182         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
3183         (AccessibilityController::~AccessibilityController):
3184         (AccessibilityController::elementAtPoint):
3185         (AccessibilityController::addNotificationListener):
3186         (AccessibilityController::platformResetToConsistentState):
3187         (AccessibilityController::removeNotificationListener):
3188         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3189         (AccessibilityUIElement::AccessibilityUIElement):
3190         (AccessibilityUIElement::subrole):
3191         (AccessibilityUIElement::scrollPageUp):
3192         (AccessibilityUIElement::scrollPageDown):
3193         (AccessibilityUIElement::scrollPageLeft):
3194         (AccessibilityUIElement::scrollPageRight):
3195         (AccessibilityUIElement::roleDescription):
3196         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
3197         (-[AccessibilityNotificationHandler _notificationReceived:]):
3198         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
3199         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3200         (WTR::AccessibilityUIElement::linkedElement):
3201         (WTR::AccessibilityUIElement::headerElementAtIndex):
3202         (WTR::AccessibilityUIElement::assistiveTechnologySimulatedFocus):
3203         (WTR::AccessibilityUIElement::scrollPageUp):
3204         (WTR::AccessibilityUIElement::scrollPageDown):
3205         (WTR::AccessibilityUIElement::scrollPageLeft):
3206         (WTR::AccessibilityUIElement::scrollPageRight):
3207         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3208         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3209         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
3210         (WTR::AccessibilityController::addNotificationListener):
3211         (WTR::AccessibilityController::removeNotificationListener):
3212         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3213         (WTR::AccessibilityUIElement::AccessibilityUIElement):
3214         (WTR::AccessibilityUIElement::assistiveTechnologySimulatedFocus):
3215         (WTR::AccessibilityUIElement::scrollPageUp):
3216         (WTR::AccessibilityUIElement::scrollPageDown):
3217         (WTR::AccessibilityUIElement::scrollPageLeft):
3218         (WTR::AccessibilityUIElement::scrollPageRight):
3219         (WTR::AccessibilityUIElement::increaseTextSelection):
3220
3221 2015-07-24  Brent Fulgham  <bfulgham@apple.com>
3222
3223         [Win] Activate CSP_NEXT and Connect UserScript and UserStyleSheet through WebView.
3224         https://bugs.webkit.org/show_bug.cgi?id=147279
3225         <rdar://problem/21990767>
3226
3227         Reviewed by Dean Jackson.
3228
3229         * DumpRenderTree/win/TestRunnerWin.cpp:
3230         (TestRunner::addUserScript):
3231         (TestRunner::addUserStyleSheet):
3232         (TestRunner::setDeveloperExtrasEnabled):
3233
3234 2015-07-24  Basile Clement  <basile_clement@apple.com>
3235
3236         Call fixChangeLogPatch when generating patches from webkit-patch
3237         https://bugs.webkit.org/show_bug.cgi?id=147248
3238
3239         Reviewed by Geoffrey Garen.
3240
3241         When two consecutive patches are from the same author, diff tools
3242         create wrong-looking diffs for ChangeLog files where the apparent added
3243         author is actually the previous patch's author line, making it awkward
3244         to read - and things only get worse when committing a patch and a
3245         followup fix for the same bug shortly after.
3246
3247         We have a perl function in VCSUtils.pm, fixChangeLogPatch, to corrects
3248         this, which we use in perl scripts (svn-create-patch et al). But it is
3249         not used by webkit-patch, which is a python script, and thus creates
3250         "bad" diffs.
3251
3252         In the long term, we should probably port fixChangeLogPatch to python -
3253         but in the short term, let's make webkit-patch call perl to run
3254         fixChangeLogPatch. We are already making various external calls there
3255         anyway.
3256
3257         * Scripts/webkitpy/common/checkout/scm/git.py:
3258         (Git.create_patch):
3259         * Scripts/webkitpy/common/checkout/scm/scm.py:
3260         (SCM.fix_changelog_patch):
3261         * Scripts/webkitpy/common/checkout/scm/svn.py:
3262         (SVN.create_patch):
3263
3264 2015-07-24  Dean Johnson  <dean_johnson@apple.com>
3265
3266         commit-queue flags in webkit-patch are confusing
3267         https://bugs.webkit.org/show_bug.cgi?id=88694
3268
3269         Reviewed by Csaba Osztrogonác.
3270
3271         * Scripts/webkitpy/tool/steps/options.py:
3272         (Options): Updated help string to be more descriptive.
3273
3274 2015-07-23  Brent Fulgham  <bfulgham@apple.com>
3275
3276         [Win] Implement proper High DPI support features
3277         https://bugs.webkit.org/show_bug.cgi?id=146335
3278         <rdar://problem/21558269>
3279
3280         Reviewed by Alex Christensen.
3281
3282         Update WinLauncher to take device scaling factor into account.
3283
3284         * WinLauncher/Common.cpp:
3285         (resizeSubViews): Make sure toolbars and URL bar are properly sized and using
3286         a valid font.
3287         (computeFullDesktopFrame): Handle high DPI desktops.
3288         (WndProc): Make comments more precise.
3289         * WinLauncher/WinLauncher.cpp:
3290         (WinLauncher::init): Determine device scale factor at launch.
3291         (WinLauncher::updateDeviceScaleFactor): Added.
3292         * WinLauncher/WinLauncher.h:
3293         * WinLauncher/WinLauncherWebHost.h: Use C++11 initialization.
3294         * WinLauncher/WinMain.cpp: Size interface based on scaling factor.
3295         (wWinMain): Ditto.
3296         * win/DLLLauncher/DLLLauncherMain.cpp:
3297         (wWinMain): Tell Windows we understand high DPI.
3298
3299 2015-07-23  Alex Christensen  <achristensen@webkit.org>
3300
3301         [Win] Unreviewed build fix after r187169.
3302
3303         * Scripts/build-webkit:
3304         Correctly find WebKit.sln.
3305
3306 2015-07-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3307
3308         [GTK] Add API to allow executing editing commands that require an argument
3309         https://bugs.webkit.org/show_bug.cgi?id=146781
3310
3311         Reviewed by Gustavo Noronha Silva.
3312
3313         Add buttons to insert image/link to the MiniBrowser edit toolbar,
3314         and test cases for insert image/link commands too.
3315
3316         * MiniBrowser/gtk/BrowserWindow.c:
3317         (insertImageCommandCallback):
3318         (insertLinkCommandCallback):
3319         (browserWindowSetupEditorToolbar):
3320         (browserWindowConstructed):
3321         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
3322         (testWebViewEditorInsertImage):
3323         (testWebViewEditorCreateLink):
3324         (beforeAll):
3325
3326 2015-07-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3327
3328         Unregistering and re-registering a user message handler does not work
3329         https://bugs.webkit.org/show_bug.cgi?id=138142
3330
3331         Reviewed by Martin Robinson.
3332
3333         This has probably been fixed in r184846, enable the test case
3334         blocked on it.
3335
3336         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
3337         (testUserContentManagerScriptMessageReceived):
3338
3339 2015-07-22  Sukolsak Sakshuwong  <sukolsak@gmail.com>
3340
3341         Add ENABLE_WEBASSEMBLY feature flag for WebAssembly
3342         https://bugs.webkit.org/show_bug.cgi?id=147212
3343
3344         Reviewed by Filip Pizlo.
3345
3346         * Scripts/webkitperl/FeatureList.pm:
3347
3348 2015-07-22  Jon Honeycutt  <jhoneycutt@apple.com>
3349
3350         Add --ios-simulator to run-api-tests --help.
3351
3352         Rubber-stamped by Dan Bates.
3353
3354         * Scripts/run-api-tests:
3355
3356 2015-07-22  Jason Marcell  <jmarcell@apple.com>
3357
3358         Remove hardcoded "internal" from Buildbot.prototype._normalizeQueueInfo.
3359         https://bugs.webkit.org/show_bug.cgi?id=147043
3360
3361         Reviewed by Daniel Bates and Alexey Proskuryakov.
3362
3363         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
3364         (Buildbot.prototype._normalizeQueueInfo):
3365         The _normalizeQueueInfo method now calls the defaultBranches getter instead of using hardcoded values
3366         in cases where the queue.branch property is not set and the queue is not a combined queue.
3367         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
3368         (BuildbotCombinedQueueView):
3369         Ensuring uniformity of repository branches within a combined queue.
3370         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3371         (WebKitBuildbot.prototype.get defaultBranches):
3372         Added; provides a WebKit-specific implementation that sets the queue.branches dictionary to have a
3373         single entry for "openSource" as the default set of branches. Note that we intentionally omitted a
3374         base class implementation of the defaultBranches getter so as to cause a JavaScript TypeError when a
3375         sub-queue of a combined queue does not specify property branch and the derived Buildbot class does not
3376         implement defaultBranches so that a person can either update the definition of the sub-queue or
3377         implement defaultBranches in the derived Buildbot class they are using.
3378
3379 2015-07-22  Alex Christensen  <achristensen@webkit.org>
3380
3381         Switch WinCairo build to use CMake.
3382         https://bugs.webkit.org/show_bug.cgi?id=147169
3383
3384         Reviewed by Brent Fulgham.
3385
3386         * Scripts/build-webkit:
3387         * Scripts/webkitdirs.pm:
3388         (determineConfiguration):
3389         (determineArchitecture):
3390         (determinePassedConfiguration):
3391         (passedConfiguration):
3392         (jhbuildWrapperPrefixIfNeeded):
3393         (generateBuildSystemFromCMakeProject):
3394         It's CMake time!  We now use the CMake files to generate a solution in WebKitBuild/Release/WebKit.sln and build that.
3395
3396 2015-07-22  Alex Christensen  <achristensen@webkit.org>
3397
3398         Fix quirks in CMake build on Mac and Windows
3399         https://bugs.webkit.org/show_bug.cgi?id=147174
3400
3401         Reviewed by Gyuyoung Kim.
3402
3403         * CMakeLists.txt:
3404         Don't build DumpRenderTree with CMake for now (until we get that working).
3405         * WinLauncher/CMakeLists.txt:
3406         Renamed WinLauncherLauncher to WinLauncher and WinLauncher to WinLauncherLib to match the Visual Studio build.
3407
3408 2015-07-22  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3409
3410         [check-webkit-style] .lut.h files shouldn't raise a sorting issue
3411         https://bugs.webkit.org/show_bug.cgi?id=147146
3412
3413         Reviewed by Darin Adler.
3414
3415         * Scripts/webkitpy/style/checkers/cpp.py:
3416         (check_include_line): Avoid checking previous lines if it it is a lut.h include.
3417         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3418         (OrderOfIncludesTest.test_check_alphabetical_include_order): Added test.
3419
3420 2015-07-21  Filip Pizlo  <fpizlo@apple.com>
3421
3422         Fixed VM pool allocation should have a reserve for allocations that cannot fail
3423         https://bugs.webkit.org/show_bug.cgi?id=147154
3424         rdar://problem/21847618
3425
3426         Reviewed by Geoffrey Garen.
3427         
3428         Add a new test mode where we artificially limit JIT memory to 50KB. If our JIT OOM
3429         mitigations work, these should all pass. Prior to this patch there were >20 failures.
3430
3431         * Scripts/run-jsc-stress-tests:
3432
3433 2015-07-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3434
3435         [GTK] Add API to be notified about editor state changes
3436         https://bugs.webkit.org/show_bug.cgi?id=145875
3437
3438         Reviewed by Gustavo Noronha Silva.
3439
3440         Update the typing attributes toggle buttons state according to the
3441         editor state in MiniBrowser, and add a test case to the
3442         WebViewEditor unit tests.
3443
3444         * MiniBrowser/gtk/BrowserWindow.c:
3445         (browserWindowEditingCommandToggleButtonSetActive):
3446         (typingAttributesChanged):
3447         (browserWindowSetupEditorToolbar):
3448         (browserWindowConstructed):
3449         (browser_window_init):
3450         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
3451         (testWebViewEditorEditorStateTypingAttributes):
3452         (beforeAll):
3453
3454 2015-07-20  Tomas Popela  <tpopela@redhat.com>
3455
3456         [GTK] Add selection-changed signal to the WebKit2 API
3457         https://bugs.webkit.org/show_bug.cgi?id=137116
3458
3459         Reviewed by Carlos Garcia Campos.
3460
3461         Add a new WebProcess test TestEditor that is testing the WebKitWebEditor
3462         (namely the selection-changed signal).
3463
3464         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3465         * TestWebKitAPI/Tests/WebKit2Gtk/EditorTest.cpp: Added.
3466         (WebKitWebEditorTest::create):
3467         (WebKitWebEditorTest::selectionChangedCallback):
3468         (WebKitWebEditorTest::testSelectionSelectAll):
3469         (WebKitWebEditorTest::testSelectionCollapse):
3470         (WebKitWebEditorTest::testSelectionModifyMove):
3471         (WebKitWebEditorTest::testSelectionModifyExtend):
3472         (WebKitWebEditorTest::testSelectionUnselect):
3473         (registerTests):
3474         * TestWebKitAPI/Tests/WebKit2Gtk/TestEditor.cpp: Added.
3475         (testWebKitWebEditorSelectionChanged):
3476         (beforeAll):
3477         (afterAll):
3478
3479 2015-07-20  Alex Christensen  <achristensen@webkit.org>
3480
3481         Resurrect CMake build on Windows.
3482         https://bugs.webkit.org/show_bug.cgi?id=147083
3483
3484         Reviewed by Gyuyoung Kim.
3485
3486         * DumpRenderTree/CMakeLists.txt:
3487         * DumpRenderTree/PlatformWin.cmake: Added.
3488         * WinLauncher/CMakeLists.txt:
3489
3490 2015-07-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3491
3492         [GTK] Enable seccomp filter API tests
3493         https://bugs.webkit.org/show_bug.cgi?id=140071
3494
3495         Reviewed by Žan Doberšek.
3496
3497         These tests will now be run by the run-gtk-tests script.
3498
3499         * TestWebKitAPI/PlatformGTK.cmake:
3500
3501 2015-07-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3502
3503         [GTK] Add seccomp filters support
3504         https://bugs.webkit.org/show_bug.cgi?id=110014
3505
3506         Reviewed by Žan Doberšek.
3507
3508         Add libseccomp to jhbuild modulesets.
3509
3510         * gtk/jhbuild.modules:
3511
3512 2015-07-18  Simon Fraser  <simon.fraser@apple.com>
3513
3514         MiniBrowser window title is just "Window" when page has no <title>
3515         https://bugs.webkit.org/show_bug.cgi?id=147076
3516
3517         Reviewed by Tim Horton.
3518         
3519         Make MiniBrowser windows show the filename from the URL if we never get a title changed
3520         notification.
3521
3522         * MiniBrowser/mac/WK1BrowserWindowController.m:
3523         (-[WK1BrowserWindowController updateTitle:]):
3524         (-[WK1BrowserWindowController webView:didCommitLoadForFrame:]):
3525         (-[WK1BrowserWindowController webView:didReceiveTitle:forFrame:]):
3526         * MiniBrowser/mac/WK2BrowserWindowController.m:
3527         (-[WK2BrowserWindowController updateTitle:]):
3528         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
3529         (-[WK2BrowserWindowController webView:didCommitNavigation:]):
3530
3531 2015-07-17  Andy Estes  <aestes@apple.com>
3532
3533         [iOS] Further tighten the sandbox around pages fetched with Content-Disposition: attachment
3534         https://bugs.webkit.org/show_bug.cgi?id=147044
3535         rdar://problem/21567820
3536
3537         Reviewed by Brady Eidson.
3538
3539         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3540         (WTR::InjectedBundlePage::decidePolicyForResponse): Only log the message about attachments if the custom policy delegate is enabled.
3541         This matches the behavior of DumpRenderTree.
3542
3543 2015-07-17  Benjamin Poulain  <bpoulain@apple.com>
3544
3545         [Content Extensions] Term::isUniversalTransition() incorrectly expects the end-of-line assertion in character sets
3546         https://bugs.webkit.org/show_bug.cgi?id=147032
3547
3548         Reviewed by Alex Christensen.
3549
3550         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3551         Test that the useless terms are eliminated by counting
3552         the number of NFA nodes generated.
3553
3554 2015-07-17  Dan Bernstein  <mitz@apple.com>
3555
3556         Tests for <rdar://problem/21803781> The external URL policy is not reported correctly in navigation actions that create new windows
3557         https://bugs.webkit.org/show_bug.cgi?id=147040
3558
3559         Reviewed by Dean Jackson.
3560
3561         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3562         * TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm: Added.
3563         (-[ShouldOpenExternalURLsInNewWindowActionsController webView:decidePolicyForNavigationAction:decisionHandler:]):
3564         (-[ShouldOpenExternalURLsInNewWindowActionsController webView:didFinishNavigation:]):
3565         (-[ShouldOpenExternalURLsInNewWindowActionsController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3566         (TEST):
3567
3568 2015-07-16  Dean Johnson  <dean_johnson@apple.com>
3569
3570         webkit-patch uses incorrect credentials from keychain to login until account lockout
3571         https://bugs.webkit.org/show_bug.cgi?id=146923
3572
3573         Reviewed by Daniel Bates.
3574
3575         When `webkit-patch upload` asks for login credentials for bugs.webkit.org, if you
3576         provide incorrect credentials then ask for them to be saved to the keychain
3577         webkit-patch will then use those incorrect credentials until 5 total attempts
3578         have been made to log in. This will lock the user out of Bugzilla for a
3579         half hour.
3580
3581         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3582         (Bugzilla.authenticate): Added argument to read_credentials() that
3583         passes in whether or not to use stored credentials.
3584         * Scripts/webkitpy/common/net/credentials.py:
3585         (Credentials.read_credentials): Added optional argument 'use_stored_credentials'
3586         that specifies whether or not to use credentials stored on the system. If it
3587         does, we do not auto-fill credentials since either the credentials caused
3588         the failure, or they weren't used in the first place so there is no reason