Add utility function to allow easy reverse range-based iteration of a container
[WebKit-https.git] / Tools / ChangeLog
1 2019-03-11  Sam Weinig  <sam@webkit.org>
2
3         Add utility function to allow easy reverse range-based iteration of a container
4         https://bugs.webkit.org/show_bug.cgi?id=195542
5
6         Reviewed by Antti Koivisto.
7
8         * TestWebKitAPI/CMakeLists.txt:
9         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
10         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
11         (TestWebKitAPI::TEST):
12         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
13
14 2019-03-10  Alex Christensen  <achristensen@webkit.org>
15
16         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
17         https://bugs.webkit.org/show_bug.cgi?id=195511
18         <rdar://problem/44873269>
19
20         Reviewed by Darin Adler.
21
22         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
23         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
24         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
25         (TEST_F):
26
27 2019-03-10  Tim Horton  <timothy_horton@apple.com>
28
29         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
30         https://bugs.webkit.org/show_bug.cgi?id=195499
31
32         Reviewed by Darin Adler.
33
34         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
35         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
36         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
37         (-[WKWebView synchronouslyFocusTextInputContext:]):
38         (applyStyle):
39         (applyIframe):
40         (TEST):
41         Add some tests for this SPI.
42
43 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
44
45         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
46         https://bugs.webkit.org/show_bug.cgi?id=181151
47
48         Reviewed by Don Olmstead.
49
50         * TestWebKitAPI/CMakeLists.txt:
51         * TestWebKitAPI/PlatformWin.cmake:
52         Enable TestWTF RunLoop tests in all platforms.
53
54         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
55         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
56         (TestWebKitAPI::DerivedOneShotTimer::fired):
57         (TestWebKitAPI::TEST):
58         Only a few platforms support nested RunLoop.
59
60         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
61         (TestWebKitAPI::DerivedRepeatingTimer::fired):
62
63 2019-03-10  David Quesada  <david_quesada@apple.com>
64
65         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
66         https://bugs.webkit.org/show_bug.cgi?id=152480
67
68         Reviewed by Chris Dumez.
69
70         Add a unit test based on Daniel Bates's test case that starts a download, ensures
71         there are no additional references to the process pool besides the one held by
72         the download, waits for the download to finish (in the sense that the
73         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
74         measure, also check that the process pool has been deallocated at the end of the
75         test. The test wouldn't be meaningful if the process pool were still alive.
76
77         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
78         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
79         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
80             The download will be canceled because the delegate does not implement the
81             method to decide the download's destination, so this is where we know the
82             DownloadProxyMap is done with the DownloadProxy.
83         (TEST):
84
85 2019-03-08  Chris Dumez  <cdumez@apple.com>
86
87         Add support for Device Orientation / Motion permission API
88         https://bugs.webkit.org/show_bug.cgi?id=195329
89         <rdar://problem/47645367>
90
91         Reviewed by Geoffrey Garen.
92
93         Add test infrastructure to help test the Device Orientation / Motion permission API.
94
95         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
96         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
97         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
98         * WebKitTestRunner/InjectedBundle/TestRunner.h:
99         * WebKitTestRunner/TestController.cpp:
100         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
101         (WTR::TestController::createWebViewWithOptions):
102         (WTR::TestController::resetStateToConsistentValues):
103         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
104         * WebKitTestRunner/TestController.h:
105         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
106         * WebKitTestRunner/TestInvocation.cpp:
107         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
108
109 2019-03-08  Saam barati  <sbarati@apple.com>
110
111         Add a compare-results script to compare benchmark results
112         https://bugs.webkit.org/show_bug.cgi?id=195486
113         <rdar://problem/48723397>
114
115         Reviewed by Geoffrey Garen.
116
117         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
118         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
119         to extend it to learn about our other benchmarks.
120
121         * Scripts/compare-results: Added.
122         (readJSONFile):
123         (detectJetStream2):
124         (JetStream2Results):
125         (detectSpeedometer2):
126         (Speedometer2Results):
127         (detectPLT5):
128         (PLT5Results):
129         (detectBenchmark):
130         (biggerIsBetter):
131         (ttest):
132         (getOptions):
133         (main):
134
135 2019-03-08  Stephanie Lewis  <slewis@apple.com>
136
137         Ensure old tab state is cleared between iterations of run-benchmark
138         https://bugs.webkit.org/show_bug.cgi?id=195393
139         <rdar://problem/46885583>
140
141         Reviewed by Dewei Zhu.
142
143         a) ensure the default to restore state is not set
144         b) terminate Safari correctly
145         c) Set the system default to ignore Persistent State in Safari
146
147         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
148         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
149         (OSXBrowserDriver.prepare_env): 
150         (OSXBrowserDriver.restore_env):
151         (OSXBrowserDriver.close_browsers):
152         (OSXBrowserDriver._terminate_processes):
153         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
154         (OSXChromeDriver):
155         (OSXChromeCanaryDriver):
156         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
157         (OSXFirefoxDriver):
158         (OSXFirefoxNightlyDriver):
159         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
160         (OSXSafariDriver):
161         (OSXSafariDriver.prepare_env):
162
163 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
164
165         [GTK] Several InputMethodFilter tests are failing
166         https://bugs.webkit.org/show_bug.cgi?id=195408
167
168         Reviewed by Carlos Garcia Campos.
169
170         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
171         Regressed in r241751.
172         Hexadecimal values of keycodes are expressed now in upper letters.
173         Composited characters should be cast to UTF8 strings.
174
175         (TestWebKitAPI::TEST):
176
177 2019-03-07  Tomas Popela  <tpopela@redhat.com>
178
179         [GTK] Make Tools/gtkdoc python3 compatible
180         https://bugs.webkit.org/show_bug.cgi?id=195359
181
182         Reviewed by Carlos Garcia Campos.
183
184         * gtkdoc/generate-gtkdoc:
185         ConfigParser was reworked in Python 3.2 so we have adapt the code to
186         work with Python 2 and 3.
187         (get_gtkdoc_module_paths):
188         The iteritems() was removed in Python 3, so let's use items() that's
189         available in Python 2 and 3.
190         (get_generator_for_config):
191         * gtkdoc/gtkdoc.py:
192         (GTKDoc._run_command):
193         The sys.stdout.write() is expecting str in Python 3 and not bytes
194         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
195         for passing the bytes there.
196
197 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
198
199         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
200         https://bugs.webkit.org/show_bug.cgi?id=195346
201         <rdar://problem/48667048>
202
203         Unreviewed build fix for clang-cl.
204
205         * DumpRenderTree/win/DumpRenderTree.cpp:
206         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
207
208 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
209
210         requestAnimationFrame should execute before the next frame
211         https://bugs.webkit.org/show_bug.cgi?id=177484
212
213         Reviewed by Simon Fraser.
214
215         Add trace points for the page RenderingUpdate.
216
217         * Tracing/SystemTracePoints.plist:
218
219 2019-03-07  Zalan Bujtas  <zalan@apple.com>
220
221         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
222         https://bugs.webkit.org/show_bug.cgi?id=195353
223         <rdar://problem/48626394>
224
225         Reviewed by Simon Fraser.
226
227         * WebKitTestRunner/ios/TestControllerIOS.mm:
228         (WTR::TestController::platformResetPreferencesToConsistentValues):
229
230 2019-03-07  John Wilander  <wilander@apple.com>
231
232         Resource Load Statistics: Make it possible to purge only script-accessible cookies
233         https://bugs.webkit.org/show_bug.cgi?id=195383
234         <rdar://problem/48570136>
235
236         Reviewed by Brent Fulgham.
237
238         This patch adds test infrastructure to purge only script-accessible cookies,
239         including a new testRunner function called statisticsDeleteCookiesForHost().git a
240
241         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
242         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
243         (WTR::TestRunner::statisticsDeleteCookiesForHost):
244         * WebKitTestRunner/InjectedBundle/TestRunner.h:
245         * WebKitTestRunner/TestController.cpp:
246         (WTR::TestController::statisticsDeleteCookiesForHost):
247         * WebKitTestRunner/TestController.h:
248         * WebKitTestRunner/TestInvocation.cpp:
249         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
250
251 2019-03-07  Commit Queue  <commit-queue@webkit.org>
252
253         Unreviewed, rolling out r242354.
254         https://bugs.webkit.org/show_bug.cgi?id=195402
255
256         breaks layout tests in all configurations (Requested by
257         zdobersek on #webkit).
258
259         Reverted changeset:
260
261         "[WPE] Enable web process sandbox"
262         https://bugs.webkit.org/show_bug.cgi?id=195169
263         https://trac.webkit.org/changeset/242354
264
265 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
266
267         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
268         https://bugs.webkit.org/show_bug.cgi?id=195346
269
270         Reviewed by Fujii Hironori.
271
272         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
273         (TestWebKitAPI::TEST):
274         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
275
276         * DumpRenderTree/win/DumpRenderTree.cpp:
277         (findFontFallback):
278         (addFontFallbackIfPresent):
279         (removeFontFallbackIfPresent):
280         (main):
281         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
282         (TestWebKitAPI::Util::moduleDirectory):
283         (TestWebKitAPI::Util::createInjectedBundlePath):
284         Use wchar helpers as needed.
285
286 2019-03-06  Rob Buis  <rbuis@igalia.com>
287
288         Consider supporting the `referrerpolicy` attribute.
289         https://bugs.webkit.org/show_bug.cgi?id=179053
290
291         Reviewed by Darin Adler.
292
293         Add a runtime flag for referrerpolicy attribute.
294
295         * DumpRenderTree/mac/DumpRenderTree.mm:
296         (enableExperimentalFeatures):
297
298 2019-03-05  Daniel Bates  <dabates@apple.com>
299
300         Update expected API test result following r242379
301         (https://bugs.webkit.org/show_bug.cgi?id=195125)
302
303         Update expected x-coordinate of selection rect now that the left padding of
304         a textarea is sized in ems (so dependent on the font size) just like the left
305         padding of a text field.
306
307         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
308         (TestWebKitAPI::TEST):
309
310 2019-03-05  David Quesada  <david_quesada@apple.com>
311
312         [WK2] It should be possible to follow links with 'download' attributes
313         https://bugs.webkit.org/show_bug.cgi?id=195145
314         rdar://problem/48462642
315
316         Reviewed by Alex Christensen.
317
318         Add a unit test to verify that activating links with 'download' attributes now
319         navigates to the linked resource, rather than starts downloading it. Add another
320         to verify that it is still possible to explicitly download the link via the
321         'Download' navigation action policy.
322
323         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
324         (-[DownloadAttributeTestDelegate init]):
325         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
326         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
327         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
328         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
329         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
330         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
331         (TEST):
332         * WebKitTestRunner/TestController.cpp:
333         (WTR::TestController::decidePolicyForNavigationAction):
334         * WebKitTestRunner/TestController.h:
335
336 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
337
338         [Curl] Implement Cookie Accept Policy.
339         https://bugs.webkit.org/show_bug.cgi?id=191645
340
341         Reviewed by Fujii Hironori.
342
343         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
344         (TestWebKitAPI::Curl::TEST_F):
345
346 2019-03-05  Youenn Fablet  <youenn@apple.com>
347
348         Rename requestCacheStorageSpace to requestStorageSpace
349         https://bugs.webkit.org/show_bug.cgi?id=195282
350
351         Reviewed by Chris Dumez.
352
353         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
354         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
355         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
356
357 2019-03-05  Brady Eidson  <beidson@apple.com>
358
359         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
360         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
361
362         Reviewed by Tim Horton.
363
364         Loading a file: URL into a WKWebView and then loading another file: url from a completely
365         different directory into that same WKWebView should work.
366
367         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
368         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
369
370 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
371
372         Add WeakHashSet
373         https://bugs.webkit.org/show_bug.cgi?id=195152
374
375         Reviewed by Antti Koivisto.
376
377         Added tests for WeakHashSet.
378
379         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
380         (TestWebKitAPI::Base::Base): Moved.
381         (TestWebKitAPI::Derived::foo): Moved.
382         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
383         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
384         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
385         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
386
387 2019-03-04  Chris Dumez  <cdumez@apple.com>
388
389         Do not share WebProcesses between private and regular sessions
390         https://bugs.webkit.org/show_bug.cgi?id=195189
391         <rdar://problem/48421064>
392
393         Reviewed by Alex Christensen.
394
395         Add API test coverage.
396
397         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
398         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
399
400 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
401
402         [WPE] Enable web process sandbox
403         https://bugs.webkit.org/show_bug.cgi?id=195169
404
405         Reviewed by Daniel Bates.
406
407         * wpe/install-dependencies:
408         * wpe/jhbuild.modules:
409
410 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
411
412         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
413         https://bugs.webkit.org/show_bug.cgi?id=195206
414
415         Reviewed by Žan Doberšek.
416
417         Add a new test case.
418
419         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
420         (testJSCClass):
421
422 2019-03-04  Charlie Turner  <cturner@igalia.com>
423
424         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
425         https://bugs.webkit.org/show_bug.cgi?id=194898
426
427         Reviewed by Žan Doberšek.
428
429         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
430         a GCC extension that permits arithmetic on void* pointer. Inline
431         the macro until this issue is fixed upstream.
432
433 2019-03-03  Tim Horton  <timothy_horton@apple.com>
434
435         Rid the world of WK_API_ENABLED
436         https://bugs.webkit.org/show_bug.cgi?id=195263
437
438         Reviewed by Dan Bernstein.
439
440         List of changed files elided because it's useless.
441
442 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
443
444         Unreviewed follow-up to r242292.
445
446         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
447
448         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
449         (TestWebKitAPI::testStrip): Renamed from strip.
450         (TestWebKitAPI::TEST):
451
452 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
453
454         Unreviewed, remove accidentally-committed URLHelpers.cpp test
455
456         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
457         and bug #194272 for details.
458
459         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
460
461 2019-03-03  Tim Horton  <timothy_horton@apple.com>
462
463         Remove some more unused 32-bit code
464         https://bugs.webkit.org/show_bug.cgi?id=195255
465
466         Reviewed by Darin Adler.
467
468         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
469         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
470         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
471         (NPP_New):
472         (NPP_HandleEvent):
473         (handleEventCarbon): Deleted.
474
475 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
476
477         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
478
479         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
480         (TestWebKitAPI::TEST):
481
482 2019-03-01  Darin Adler  <darin@apple.com>
483
484         Finish removing String::format
485         https://bugs.webkit.org/show_bug.cgi?id=194893
486
487         Reviewed by Daniel Bates.
488 '
489         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
490
491 2019-03-01  Alex Christensen  <achristensen@webkit.org>
492
493         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
494         https://bugs.webkit.org/show_bug.cgi?id=195229
495         <rdar://problem/48520362>
496
497         Reviewed by Chris Dumez.
498
499         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
500         (TEST):
501
502 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
503
504         Add a system trace scope for event region building
505         https://bugs.webkit.org/show_bug.cgi?id=195226
506
507         Reviewed by Jon Lee.
508
509         This trace scope measures the time spend converting element rects into Region objects,
510         which can be large on some pages.
511
512         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
513
514         * Tracing/SystemTracePoints.plist:
515
516 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
517
518         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
519         https://bugs.webkit.org/show_bug.cgi?id=194612
520
521         Reviewed by Alex Christensen.
522
523         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
524         Just test the new string-processing function and don't touch the actual environment.
525         (Test cases are all as before, but based on operator== instead of strcmp.)
526
527 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
528
529         [ews-app] Update primary keys for handling multiple Buildbot instances
530         https://bugs.webkit.org/show_bug.cgi?id=195120
531
532         Reviewed by Stephanie Lewis.
533
534         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
535         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
536         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
537
538         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
539         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
540         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
541         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
542         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
543         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
544
545 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
546
547         [WinCairo] Enable service worker
548         https://bugs.webkit.org/show_bug.cgi?id=188318
549
550         Reviewed by Youenn Fablet.
551
552         * DumpRenderTree/DumpRenderTreePrefix.h:
553         * TestWebKitAPI/PlatformWin.cmake:
554         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
555         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
556         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
557
558 2019-03-01  Justin Fan  <justin_fan@apple.com>
559
560         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
561         https://bugs.webkit.org/show_bug.cgi?id=195191
562
563         Rubber-stamped by Dean Jackson.
564
565         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
566
567         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
568
569 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
570
571         Unreviewed, fix lldb webkitpy tests
572         https://bugs.webkit.org/show_bug.cgi?id=194375
573
574         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
575
576         * lldb/lldb_webkit.py:
577         (WTFStringImplProvider.is_8bit):
578
579 2019-02-28  David Quesada  <david_quesada@apple.com>
580
581         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
582         https://bugs.webkit.org/show_bug.cgi?id=195121
583         rdar://problem/48450302
584
585         Reviewed by Alex Christensen.
586
587         Add API tests for -WKNavigationAction._shouldPerformDownload in various
588         configurations where the 'download' attribute is absent, blank, or populated
589         with a filename, and where the anchor element is same-origin or cross-origin
590         (meaning the 'download' attribute shouldn't be honored).
591
592         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
593         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
594         (-[NavigationActionTestDelegate init]):
595         (-[NavigationActionTestDelegate navigationAction]):
596         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
597         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
598         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
599         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
600         (TEST):
601
602 2019-02-28  Antoine Quint  <graouts@apple.com>
603
604         Enable the Pointer Events runtime flag by default
605         https://bugs.webkit.org/show_bug.cgi?id=195156
606
607         Reviewed by Dean Jackson.
608
609         * DumpRenderTree/mac/DumpRenderTree.mm:
610         (enableExperimentalFeatures):
611
612 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
613
614         Several PasteImage API tests are flaky
615         https://bugs.webkit.org/show_bug.cgi?id=195160
616
617         Reviewed by Tim Horton.
618
619         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
620         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
621         listening for a "load" event after image load is already complete.
622
623         To address this, make these tests first register a "load" event handler, then run script to insert an image
624         element into the document, and finally wait until the load event is observed before checking image size.
625
626         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
627
628 2019-02-28  Chris Dumez  <cdumez@apple.com>
629
630         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
631         https://bugs.webkit.org/show_bug.cgi?id=195107
632
633         Reviewed by Alex Christensen.
634
635         Give some time for the zoom level to get restored.
636
637         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
638
639 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
640
641         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
642         https://bugs.webkit.org/show_bug.cgi?id=194958
643
644         Reviewed by Geoffrey Garen.
645
646         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
647         (TEST):
648
649 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
650
651         [ews-app] Update method to save build to handle builder_display_name
652         https://bugs.webkit.org/show_bug.cgi?id=195047
653
654         Reviewed by Dewei Zhu.
655
656         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
657         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
658
659 2019-02-28  Justin Fan  <justin_fan@apple.com>
660
661         [Web GPU] Enable Web GPU only on 64-bit
662         https://bugs.webkit.org/show_bug.cgi?id=195139
663
664         Because Metal is only supported on 64 bit apps.
665
666         Unreviewed build fix.
667
668         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
669
670 2019-02-27  Youenn Fablet  <youenn@apple.com>
671
672         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
673         https://bugs.webkit.org/show_bug.cgi?id=194959
674
675         Reviewed by Chris Dumez.
676
677         Spin loop until getting the condition to remove flakiness.
678
679         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
680
681 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
682
683         [ews-build] Buildbot should include builder_display_name in the build events
684         https://bugs.webkit.org/show_bug.cgi?id=195045
685
686         Reviewed by Dewei Zhu.
687
688         * BuildSlaveSupport/ews-build/events.py:
689         (Events.buildStarted): Included builder_display_name in event data. Also renamed
690         buildername to builder_name to be consistent in naming style.
691         (Events.buildFinished): Ditto.
692
693 2019-02-27  Chris Dumez  <cdumez@apple.com>
694
695         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
696         https://bugs.webkit.org/show_bug.cgi?id=194480
697
698         Reviewed by Brady Eidson.
699
700         Update existing API test to make it more likely to reproduce the issue.
701
702         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
703
704 2019-02-27  Brady Eidson  <beidson@apple.com>
705
706         Universal links from Google search results pages don't open the app.
707         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
708
709         Reviewed by Geoffrey Garen.
710
711         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
712         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
713         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
714         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
715
716 2019-02-27  Chris Dumez  <cdumez@apple.com>
717
718         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
719         https://bugs.webkit.org/show_bug.cgi?id=195102
720
721         Reviewed by Geoffrey Garen.
722
723         If the number of processes is not yet what we expect, wait a bit and check again to give
724         processes some time to exit.
725
726         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
727
728 2019-02-27  Chris Dumez  <cdumez@apple.com>
729
730         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
731         https://bugs.webkit.org/show_bug.cgi?id=194545
732
733         Reviewed by Brady Eidson.
734
735         Make sure the test navigates forward and then back only once. Previously, navigating
736         back would trigger a navigation again in a timer.
737
738         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
739
740 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
741
742         High Sierra Debug JSC test queue should use faster hardware
743         https://bugs.webkit.org/show_bug.cgi?id=194603
744
745         Rubber-stamped by Alexey Proskuryakov.
746
747         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
748
749         * BuildSlaveSupport/build.webkit.org-config/config.json:
750         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
751         (BubbleQueueServer):
752         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
753         (WebKitBuildbot):
754         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
755         * QueueStatusServer/config/queues.py:
756         * Scripts/webkitpy/common/config/ews.json:
757         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
758         (test_ews_name):
759
760 2019-02-27  John Wilander  <wilander@apple.com>
761
762         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
763         https://bugs.webkit.org/show_bug.cgi?id=195071
764         <rdar://problem/48417690>
765
766         Reviewed by Alex Christensen and Brent Fulgham.
767
768         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
769         (TestWebKitAPI::createURL):
770             Convenience function.
771         (TestWebKitAPI::TEST):
772             WebCore::AdClickAttribution now takes a URL when creating Source and
773             Destination.
774         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
775         (TestWebKitAPI::TEST):
776             WebCore::AdClickAttribution now takes a URL when creating Source and
777             Destination.
778
779 2019-02-27  Antoine Quint  <graouts@apple.com>
780
781         Support Pointer Events on macOS
782         https://bugs.webkit.org/show_bug.cgi?id=195008
783         <rdar://problem/47454419>
784
785         Reviewed by Dean Jackson.
786
787         * DumpRenderTree/mac/DumpRenderTree.mm:
788         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
789         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
790
791 2019-02-26  Mark Lam  <mark.lam@apple.com>
792
793         Remove remaining poisoning code.
794         https://bugs.webkit.org/show_bug.cgi?id=194138
795
796         Reviewed by Saam Barati.
797
798         * TestWebKitAPI/CMakeLists.txt:
799         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
800         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
801         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
802         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
803         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
804         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
805         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
806
807 2019-02-26  Alex Christensen  <achristensen@webkit.org>
808
809         Move ephemeral local storage from WebProcess to UIProcess
810         https://bugs.webkit.org/show_bug.cgi?id=195074
811         <rdar://problem/47937975>
812
813         Reviewed by Geoff Garen.
814
815         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
816
817 2019-02-20  Jer Noble  <jer.noble@apple.com>
818
819         [Cocoa] Media elements will restart network buffering just before suspending
820         https://bugs.webkit.org/show_bug.cgi?id=193691
821
822         Reviewed by Eric Carlson.
823
824         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
825         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
826         (TEST):
827
828 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
829
830         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
831         https://bugs.webkit.org/show_bug.cgi?id=191652
832
833         Reviewed by Alex Christensen.
834
835         Fix WinCairo MiniBrowser behavior of authentication dialog.
836
837         * MiniBrowser/win/WebKitBrowserWindow.cpp:
838         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
839
840 2019-02-26  Youenn Fablet  <youenn@apple.com>
841
842         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
843         https://bugs.webkit.org/show_bug.cgi?id=195028
844         <rdar://problem/48243733>
845
846         Reviewed by Eric Carlson.
847
848         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
849
850 2019-02-26  Philippe Normand  <pnormand@igalia.com>
851
852         [WPE] Add API for webview background color configuration
853         https://bugs.webkit.org/show_bug.cgi?id=192305
854
855         Reviewed by Michael Catanzaro.
856
857         * MiniBrowser/wpe/main.cpp:
858         (main): Add a new option to configure the webview background
859         color. Example: --bg-color=transparent.
860         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
861         (testWebViewBackgroundColor): Enable background color API tests for WPE.
862         (beforeAll): Ditto.
863
864 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
865
866         scalableNativeWebpageParameters() is not preserved on new page navigation.
867         https://bugs.webkit.org/show_bug.cgi?id=194892
868         <rdar://problem/47538280>
869
870         Reviewed by Wenson Hsieh.
871         
872         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
873
874         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
875         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
876         * DumpRenderTree/mac/UIScriptControllerMac.mm:
877         (WTR::UIScriptController::allowsViewportShrinkToFit):
878         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
879         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
880         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
881         * TestRunnerShared/UIScriptContext/UIScriptController.h:
882         * WebKitTestRunner/UIScriptControllerCocoa.mm:
883         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
884
885 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
886
887         [ews-app] Add model for handling multiple Buildbot instances
888         https://bugs.webkit.org/show_bug.cgi?id=194863
889
890         Reviewed by Stephanie Lewis.
891
892         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
893
894 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
895
896         [ews-app] Remove BuilderMapping table
897         https://bugs.webkit.org/show_bug.cgi?id=194961
898
899         Reviewed by Stephanie Lewis.
900
901         Store builder name directly in build table, instead of having a separate
902         table for it.
903
904         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
905         * BuildSlaveSupport/ews-app/ews/models/build.py:
906         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
907         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
908
909 2019-02-25  John Wilander  <wilander@apple.com>
910
911         Introduce and adopt new class RegistrableDomain for eTLD+1
912         https://bugs.webkit.org/show_bug.cgi?id=194791
913         <rdar://problem/48179240>
914
915         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
916
917         This patch adds an API test and replaces two instances of
918         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
919
920         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
921         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
922         (TestWebKitAPI::TEST):
923             Changed two strings to make sure the registrable domains are still considered
924             invalid and pass the test.
925         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
926         (TestWebKitAPI::TEST):
927         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
928         (WTR::InjectedBundle::didReceiveMessageToPage):
929
930 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
931
932         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
933         https://bugs.webkit.org/show_bug.cgi?id=195001
934
935         Reviewed by Carlos Garcia Campos.
936
937         API version 1.0 always includes the functionality previously guarded with
938         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
939         unconditionally.
940
941         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
942         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
943         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
944         (WebViewTest::showInWindow): Ditto.
945         (WebViewTest::hideView): Ditto.
946         * wpe/backends/HeadlessViewBackend.cpp:
947         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
948         * wpe/backends/ViewBackend.cpp:
949         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
950         * wpe/backends/WindowViewBackend.cpp:
951         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
952         WPE_BACKEND_CHECK_VERSION().
953         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
954
955 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
956
957         [Flatpak] Add support for flatpak > 1.1.2
958         https://bugs.webkit.org/show_bug.cgi?id=194088
959
960         Flatpak 1.2 is now out so we need to support that
961         version now.
962
963         Reviewed by Michael Catanzaro.
964
965         * flatpak/flatpakutils.py:
966         (check_flatpak):
967         (FlatpakPackages.__init__):
968         (FlatpakPackages.__detect_packages):
969         (FlatpakPackages.__detect_packages.in):
970         (FlatpakRepos.update):
971
972 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
973
974         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
975         https://bugs.webkit.org/show_bug.cgi?id=194998
976
977         Reviewed by Carlos Garcia Campos.
978
979         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
980         to a Git checkout and using the latest commit containing various fixes
981         and improvements.
982
983 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
984
985         [WPE][GTK] Remove user agent quirk for washingtonpost.com
986         https://bugs.webkit.org/show_bug.cgi?id=194981
987
988         Reviewed by Žan Doberšek.
989
990         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
991         (TestWebKitAPI::TEST):
992
993 2019-02-23  Keith Miller  <keith_miller@apple.com>
994
995         Add new mac target numbers
996         https://bugs.webkit.org/show_bug.cgi?id=194955
997
998         Reviewed by Tim Horton.
999
1000         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1001         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1002         * MiniBrowser/Configurations/Base.xcconfig:
1003         * TestWebKitAPI/Configurations/Base.xcconfig:
1004         * WebKitTestRunner/Configurations/Base.xcconfig:
1005
1006 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
1007
1008         [WinCairo] Enable wk1/wk2 suffix for platform search path.
1009         https://bugs.webkit.org/show_bug.cgi?id=194846
1010
1011         Reviewed by Don Olmstead.
1012
1013         Added _search_paths() and _port_specific_expectations_files() for
1014         WinCairoPort.
1015
1016         * Scripts/webkitpy/port/win.py:
1017         (WinCairoPort.default_baseline_search_path):
1018         (WinCairoPort):
1019         (WinCairoPort._port_specific_expectations_files):
1020         (WinCairoPort._search_paths):
1021
1022 2019-02-22  Tim Horton  <timothy_horton@apple.com>
1023
1024         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
1025         https://bugs.webkit.org/show_bug.cgi?id=194963
1026
1027         Reviewed by Dean Jackson.
1028
1029         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1030         Do a `contains` check instead of `equals`, because in debug builds we
1031         put the GraphicsLayer pointer in a prefix.
1032
1033 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1034
1035         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
1036         https://bugs.webkit.org/show_bug.cgi?id=194873
1037         <rdar://problem/46701974>
1038
1039         Reviewed by Tim Horton.
1040
1041         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
1042
1043         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1044         (WTR::UIScriptController::menuRect const):
1045         (WTR::UIScriptController::isShowingMenu const):
1046         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1047         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1048         (WTR::UIScriptController::menuRect const):
1049
1050         Add a function to query the bounds of the callout menu in content coordinates.
1051
1052         (WTR::UIScriptController::isShowingMenu const):
1053
1054         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
1055
1056         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1057         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1058         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1059         (WTR::UIScriptController::rectForMenuAction const):
1060         (WTR::UIScriptController::menuRect const):
1061         (WTR::UIScriptController::isShowingMenu const):
1062         (WTR::findViewInHierarchyOfType): Deleted.
1063
1064 2019-02-22  Chris Dumez  <cdumez@apple.com>
1065
1066         Regression(PSON) Unable to preview password-protected documents on iCloud.com
1067         https://bugs.webkit.org/show_bug.cgi?id=194954
1068         <rdar://problem/48127957>
1069
1070         Reviewed by Alex Christensen.
1071
1072         Add API test coverage.
1073
1074         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1075         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1076         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1077         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1078
1079 2019-02-22  Chris Dumez  <cdumez@apple.com>
1080
1081         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
1082         https://bugs.webkit.org/show_bug.cgi?id=194924
1083         <rdar://problem/48216125>
1084
1085         Reviewed by Geoffrey Garen.
1086
1087         Add API test coverage.
1088
1089         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1090
1091 2019-02-22  Chris Dumez  <cdumez@apple.com>
1092
1093         Unreviewed, disable API test added in r241928 on iOS.
1094
1095         The cache is not enabled on devices with less than 3GB of RAM.
1096
1097         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1098
1099 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
1100
1101         Hardcode Visual Viewports on everywhere except iOS WK1
1102         https://bugs.webkit.org/show_bug.cgi?id=194928
1103
1104         Reviewed by Zalan Bujtas.
1105
1106         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
1107         change the default value of the Setting to 'true', and hardcode WebView on iOS to
1108         set it to false. The setting has shipped for several years and there's no need to turn
1109         it off now.
1110
1111         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
1112         Visual Viewports are not enabled.
1113         
1114         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
1115         that only runs in WK2
1116
1117         * MiniBrowser/mac/SettingsController.h:
1118         * MiniBrowser/mac/SettingsController.m:
1119         (-[SettingsController init]):
1120         (-[SettingsController _populateMenu]):
1121         (-[SettingsController validateMenuItem:]):
1122         (-[SettingsController visualViewportEnabled]): Deleted.
1123         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
1124         * MiniBrowser/mac/WK1BrowserWindowController.m:
1125         (-[WK1BrowserWindowController didChangeSettings]):
1126         * MiniBrowser/mac/WK2BrowserWindowController.m:
1127         (-[WK2BrowserWindowController didChangeSettings]):
1128
1129 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
1130
1131         Discard cached processes when clearing website data store
1132         https://bugs.webkit.org/show_bug.cgi?id=194894
1133
1134         Reviewed by Chris Dumez.
1135
1136         Added a test case.
1137
1138         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1139         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
1140
1141 2019-02-21  Alex Christensen  <achristensen@webkit.org>
1142
1143         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
1144         https://bugs.webkit.org/show_bug.cgi?id=194914
1145         <rdar://problem/47586889>
1146
1147         Reviewed by Geoffrey Garen.
1148
1149         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1150         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
1151         (TEST):
1152         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
1153
1154 2019-02-21  David Kilzer  <ddkilzer@apple.com>
1155
1156         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
1157         <https://webkit.org/b/194761>
1158
1159         Reviewed by Myles Maxfield.
1160
1161         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1162         (WTR::activateSystemCoreWebFonts): Log `error` to console if
1163         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
1164         to use ARC-compliant cast.
1165         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
1166         ARC-compliant cast.
1167         (WTR::installFakeHelvetica): Log `error` to console if
1168         CTFontManagerRegisterFontsForURL() fails, but only on supported
1169         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
1170         Call CFRelease() on `error` to fix the leak.  Update to use
1171         ARC-compliant cast.
1172         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
1173         cast.
1174
1175 2019-02-21  Chris Dumez  <cdumez@apple.com>
1176
1177         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
1178         https://bugs.webkit.org/show_bug.cgi?id=194481
1179
1180         Reviewed by Alex Christensen.
1181
1182         Give the processes a chance to shutdown and wait until we reached the expected number
1183         of processes.
1184
1185         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1186
1187 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1188
1189         Fix the macOS build
1190
1191         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1192
1193 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1194
1195         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
1196
1197         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1198         I am a backwards.
1199
1200 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1201
1202         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
1203
1204         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1205         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
1206         We could force on UI-side compositing, but I feel like the test might be more
1207         valuable exercising the normal path on each platform (though the original
1208         bug was also UI-side specific). Though we can't validate that the overlay
1209         layer was installed successfully, there are layout tests that do that.
1210
1211 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1212
1213         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
1214         https://bugs.webkit.org/show_bug.cgi?id=194845
1215         <rdar://problem/47944579>
1216
1217         Reviewed by Antti Koivisto.
1218
1219         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1220         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1221
1222 2019-02-21  Zalan Bujtas  <zalan@apple.com>
1223
1224         [LFC][Floats] Add support for placing formatting roots in-between floats.
1225         https://bugs.webkit.org/show_bug.cgi?id=194902
1226
1227         Reviewed by Antti Koivisto.
1228
1229         * LayoutReloaded/misc/LFC-passing-tests.txt:
1230
1231 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
1232
1233         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
1234         https://bugs.webkit.org/show_bug.cgi?id=194901
1235
1236         Unreviewed build fix.
1237
1238         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
1239         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
1240         WPEBackend-fdo-0.1 as library name.
1241
1242 2019-02-21  Rob Buis  <rbuis@igalia.com>
1243
1244         Update MIME type parser
1245         https://bugs.webkit.org/show_bug.cgi?id=180526
1246
1247         Reviewed by Darin Adler.
1248
1249         Add tests involving leading and trailing whitespace, non-token
1250         characters and quoted strings.
1251
1252         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1253         (TestWebKitAPI::TEST):
1254
1255 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
1256
1257         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
1258         https://bugs.webkit.org/show_bug.cgi?id=194884
1259
1260         Reviewed by Michael Catanzaro.
1261
1262         * PlatformWin.cmake:
1263
1264 2019-02-20  Chris Dumez  <cdumez@apple.com>
1265
1266         Add API test for <rdar://problem/47471222>
1267         https://bugs.webkit.org/show_bug.cgi?id=194847
1268
1269         Reviewed by Alex Christensen.
1270
1271         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1272
1273 2019-02-20  Chris Dumez  <cdumez@apple.com>
1274
1275         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
1276         https://bugs.webkit.org/show_bug.cgi?id=194872
1277         <rdar://problem/47924500>
1278
1279         Reviewed by Alex Christensen.
1280
1281         Add API test coverage.
1282
1283         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1284
1285 2019-02-20  Jer Noble  <jer.noble@apple.com>
1286
1287         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
1288         https://bugs.webkit.org/show_bug.cgi?id=191332
1289
1290         Reviewed by Dean Jackson.
1291
1292         * Scripts/git-is-in-range: Added.
1293
1294 2019-02-20  Andy Estes  <aestes@apple.com>
1295
1296         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
1297         https://bugs.webkit.org/show_bug.cgi?id=194869
1298
1299         Rubber-stamped by Jer Noble.
1300
1301         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1302         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
1303         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1304         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1305         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1306         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1307
1308 2019-02-20  Chris Dumez  <cdumez@apple.com>
1309
1310         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
1311         https://bugs.webkit.org/show_bug.cgi?id=194857
1312         <rdar://problem/47759323>
1313
1314         Reviewed by Alex Christensen.
1315
1316         Add API test coverage.
1317
1318         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1319
1320 2019-02-20  Chris Dumez  <cdumez@apple.com>
1321
1322         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
1323         https://bugs.webkit.org/show_bug.cgi?id=194829
1324         <rdar://problem/47889906>
1325
1326         Reviewed by Alexey Proskuryakov.
1327
1328         Every time the TestOptions were changing we were creating both a new Web view and
1329         a new WKContext, which would start a new Network process. In most cases, we only
1330         need to contruct a new Web view and we do can keep reusing the same WKContext.
1331         This patch implements this optimization and thus avoids spinning a lot of new
1332         Network processes while running the layout tests.
1333
1334         * WebKitTestRunner/TestController.cpp:
1335         (WTR::TestController::generateContextConfiguration const):
1336         (WTR::TestController::generatePageConfiguration):
1337         (WTR::TestController::createWebViewWithOptions):
1338         (WTR::TestController::resetPreferencesToConsistentValues):
1339         (WTR::updateTestOptionsFromTestHeader):
1340         * WebKitTestRunner/TestController.h:
1341         * WebKitTestRunner/TestOptions.h:
1342         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
1343         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
1344         (WTR::TestOptions::hasSameInitializationOptions const):
1345         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
1346         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1347         (WTR::TestController::platformAddTestOptions const):
1348
1349 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
1350
1351         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
1352         https://bugs.webkit.org/show_bug.cgi?id=167941
1353
1354         Reviewed by Carlos Garcia Campos.
1355
1356         * MiniBrowser/gtk/main.c:
1357         (filterSavedCallback): Added.
1358         (main): Support loading a JSON rule set file for content filtering.
1359         * MiniBrowser/wpe/main.cpp:
1360         (filterSavedCallback): Added.
1361         (main): Support loading a JSON rule set file for content filtering.
1362         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
1363         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
1364         (WTF::derefGPtr): Ditto.
1365         (testEmptyStore):
1366         (testSaveInvalidFilter):
1367         (testSaveLoadFilter):
1368         (testSavedFilterIdentifierMatch):
1369         (testRemoveFilter):
1370         (testSaveMultipleFilters):
1371         (testSaveFilterFromFile):
1372         (testFilterPersistence):
1373         (beforeAll):
1374         (afterAll):
1375         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
1376         (removeOldInjectedContentAndResetLists): Also reset content filters.
1377         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
1378         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
1379         the element affected by the style sheet.
1380         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
1381         and returns it to be used by tests.
1382         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
1383         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
1384         (serverCallback): Add support for serving a CSS style sheet for testing.
1385         (beforeAll): Add call to testUserContentManagerContentFilter().
1386         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
1387
1388 2019-02-19  Keith Rollin  <krollin@apple.com>
1389
1390         Add timing information to build output
1391         https://bugs.webkit.org/show_bug.cgi?id=194839
1392         <rdar://problem/48219609>
1393
1394         Reviewed by Alexey Proskuryakov.
1395
1396         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
1397         emit each project's build time to its output. E.g.,
1398
1399             ** BUILD SUCCEEDED ** [0.132 sec]
1400
1401         * Scripts/webkitdirs.pm:
1402         (XcodeOptions):
1403
1404 2019-02-19  Truitt Savell  <tsavell@apple.com>
1405
1406         Unreviewed, rolling out r241784.
1407
1408         Broke all OpenSource builds.
1409
1410         Reverted changeset:
1411
1412         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
1413         instances view"
1414         https://bugs.webkit.org/show_bug.cgi?id=172848
1415         https://trac.webkit.org/changeset/241784
1416
1417 2019-02-19  Zalan Bujtas  <zalan@apple.com>
1418
1419         [LFC][Floats] Remove redundant intersecting logic
1420         https://bugs.webkit.org/show_bug.cgi?id=194804
1421
1422         Reviewed by Antti Koivisto.
1423
1424         * LayoutReloaded/misc/LFC-passing-tests.txt:
1425
1426 2019-02-19  Dean Jackson  <dino@apple.com>
1427
1428         Clean-up output from generate-xcfilelists so it can be filtered
1429         https://bugs.webkit.org/show_bug.cgi?id=194795
1430
1431         Reviewed by Joseph Pecoraro (and Keith Rollin).
1432
1433         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
1434         make a slight tweak to filter-build-webkit so such lines are marked
1435         as plain.
1436
1437         * Scripts/filter-build-webkit:
1438         * Scripts/generate-xcfilelists:
1439
1440 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
1441
1442         pytest is not correctly auto-installed
1443         https://bugs.webkit.org/show_bug.cgi?id=194707
1444
1445         Reviewed by Carlos Garcia Campos.
1446
1447         * Scripts/webkitpy/thirdparty/__init__.py:
1448         (AutoinstallImportHook._install_pytest):
1449
1450 2019-02-18  Chris Dumez  <cdumez@apple.com>
1451
1452         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
1453         https://bugs.webkit.org/show_bug.cgi?id=194797
1454         <rdar://problem/48055151>
1455
1456         Reviewed by Geoffrey Garen.
1457
1458         Add API test coverage.
1459
1460         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1461
1462 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1463
1464         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
1465         https://bugs.webkit.org/show_bug.cgi?id=194670
1466         <rdar://problem/39066529>
1467
1468         Reviewed by Tim Horton.
1469
1470         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
1471         pasted in an editable area as attachment elements.
1472
1473         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
1474         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1475         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
1476         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1477         (TestWebKitAPI::TEST):
1478         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1479         (WTR::InjectedBundlePage::InjectedBundlePage):
1480
1481 2019-02-18  Alex Christensen  <achristensen@webkit.org>
1482
1483         Fix API test after r241728
1484        ​https://bugs.webkit.org/show_bug.cgi?id=194723
1485
1486         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1487         (TEST):
1488         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
1489
1490 2019-02-18  Daniel Bates  <dabates@apple.com>
1491
1492         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
1493         https://bugs.webkit.org/show_bug.cgi?id=192824
1494         <rdar://problem/47100332>
1495
1496         Reviewed by Wenson Hsieh.
1497
1498         Fix a bug where the wrong usage code was used for F13 thru F24.
1499
1500         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1501         (keyCodeForDOMFunctionKey):
1502
1503 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
1504
1505         Bytecode cache should a have a boot-specific validation
1506         https://bugs.webkit.org/show_bug.cgi?id=194769
1507         <rdar://problem/48149509>
1508
1509         Reviewed by Keith Miller.
1510
1511         Add test for WTF::bootSessionUUIDString()
1512
1513         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1514         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
1515         (TEST):
1516
1517 2019-02-18  Alex Christensen  <achristensen@webkit.org>
1518
1519         Disable safe browsing in WKWebView and remove its WKPreferences API
1520         https://bugs.webkit.org/show_bug.cgi?id=194723
1521         <rdar://problem/48122993>
1522
1523         Reviewed by Geoffrey Garen.
1524
1525         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1526         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1527         (TEST):
1528         (safeBrowsingView):
1529         Make tests use SPI instead of API.
1530
1531 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
1532
1533         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
1534         https://bugs.webkit.org/show_bug.cgi?id=194586
1535
1536         Reviewed by Ross Kirsling.
1537
1538         * DumpRenderTree/win/DumpRenderTree.cpp:
1539         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
1540         * Scripts/webkitpy/port/driver.py:
1541         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
1542
1543 2019-02-17  David Kilzer  <ddkilzer@apple.com>
1544
1545         Unreviewed, rolling out r241620.
1546
1547         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
1548         (Requested by ddkilzer on #webkit.)
1549
1550         Reverted changeset:
1551
1552         "[WTF] Add environment variable helpers"
1553         https://bugs.webkit.org/show_bug.cgi?id=192405
1554         https://trac.webkit.org/changeset/241620
1555
1556 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1557
1558         [LFC] RenderImage's default intrinsic size is 0.
1559         https://bugs.webkit.org/show_bug.cgi?id=194745
1560
1561         Reviewed by Antti Koivisto.
1562
1563         * LayoutReloaded/misc/LFC-passing-tests.txt:
1564
1565 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1566
1567         [LFC][BFC] Add support for block replaced intrinsic width.
1568         https://bugs.webkit.org/show_bug.cgi?id=194705
1569
1570         Reviewed by Simon Fraser.
1571
1572         * LayoutReloaded/misc/LFC-passing-tests.txt:
1573
1574 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1575
1576         [LFC] Apply min/max width constraints to preferred width computation
1577         https://bugs.webkit.org/show_bug.cgi?id=194739
1578
1579         Reviewed by Simon Fraser.
1580
1581         * LayoutReloaded/misc/LFC-passing-tests.txt:
1582
1583 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
1584
1585         [WTF] Add environment variable helpers
1586         https://bugs.webkit.org/show_bug.cgi?id=192405
1587
1588         Reviewed by Michael Catanzaro.
1589
1590         * DumpRenderTree/mac/DumpRenderTree.mm:
1591         (libraryPathForDumpRenderTree):
1592         * DumpRenderTree/win/DumpRenderTree.cpp:
1593         (libraryPathForDumpRenderTree):
1594         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
1595         (setUpIOSLayoutTestCommunication):
1596         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1597         (beforeAll):
1598         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1599         (main):
1600         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1601         (WebKitTestBus::run):
1602         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1603         (WTR::getOutputDir):
1604         (WTR::initializeFontConfigSetting):
1605         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
1606         (WTR::InjectedBundle::platformInitialize):
1607         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1608         (WTR::topLevelPath):
1609         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
1610         (WTR::topLevelPath):
1611         (WTR::getOutputDir):
1612         (WTR::activateFonts):
1613         * WebKitTestRunner/TestController.cpp:
1614         (WTR::TestController::libraryPathForTesting):
1615         (WTR::TestController::generateContextConfiguration const):
1616         (WTR::TestController::generatePageConfiguration):
1617         (WTR::TestController::decideDestinationWithSuggestedFilename):
1618         (WTR::TestController::platformAdjustContext):
1619         * WebKitTestRunner/TestController.h:
1620         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1621         (WTR::TestController::cocoaPlatformInitialize):
1622         (WTR::TestController::platformAdjustContext):
1623         * WebKitTestRunner/gtk/main.cpp:
1624         (main):
1625         * WebKitTestRunner/mac/TestControllerMac.mm:
1626         (WTR::TestController::configureContentExtensionForTest):
1627         * WebKitTestRunner/wpe/main.cpp:
1628         (main):
1629         Utilize WTF::Environment where possible.
1630
1631 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1632
1633         [iOS] WKWebView callout bar is missing Change Writing Direction item
1634         https://bugs.webkit.org/show_bug.cgi?id=190015
1635         <rdar://problem/44810366>
1636
1637         Reviewed by Tim Horton.
1638
1639         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
1640         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
1641
1642         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
1643         (TestWebKitAPI::TEST):
1644
1645 2019-02-15  Chris Dumez  <cdumez@apple.com>
1646
1647         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
1648         https://bugs.webkit.org/show_bug.cgi?id=194717
1649         <rdar://problem/47884404>
1650
1651         Reviewed by Brady Eidson.
1652
1653         Add API test coverage.
1654
1655         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1656
1657 2019-02-15  Youenn Fablet  <youenn@apple.com>
1658
1659         Make navigator.mediaDevices SecureContext
1660         https://bugs.webkit.org/show_bug.cgi?id=194666
1661
1662         Reviewed by Eric Carlson.
1663
1664         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
1665         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
1666         (TEST_F):
1667
1668 2019-02-15  Brian Burg  <bburg@apple.com>
1669
1670         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
1671         https://bugs.webkit.org/show_bug.cgi?id=194411
1672         <rdar://problem/47787614>
1673
1674         Reviewed by Joseph Pecoraro.
1675
1676         Remove unnecessary soft linking macro usage.
1677
1678         * DumpRenderTree/mac/TestRunnerMac.mm:
1679         (TestRunner::inspectorTestStubURL):
1680         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
1681         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1682         (WTR::TestRunner::inspectorTestStubURL):
1683
1684 2019-02-15  Commit Queue  <commit-queue@webkit.org>
1685
1686         Unreviewed, rolling out r241559 and r241566.
1687         https://bugs.webkit.org/show_bug.cgi?id=194710
1688
1689         Causes layout test crashes under GuardMalloc (Requested by
1690         ryanhaddad on #webkit).
1691
1692         Reverted changesets:
1693
1694         "[WTF] Add environment variable helpers"
1695         https://bugs.webkit.org/show_bug.cgi?id=192405
1696         https://trac.webkit.org/changeset/241559
1697
1698         "Unreviewed build fix for WinCairo Debug after r241559."
1699         https://trac.webkit.org/changeset/241566
1700
1701 2019-02-15  Zalan Bujtas  <zalan@apple.com>
1702
1703         [LFC] Out-of-flow box is never a float box
1704         https://bugs.webkit.org/show_bug.cgi?id=194704
1705
1706         Reviewed by Antti Koivisto.
1707
1708         * LayoutReloaded/misc/LFC-passing-tests.txt:
1709
1710 2019-02-10  Darin Adler  <darin@apple.com>
1711
1712         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
1713         https://bugs.webkit.org/show_bug.cgi?id=194487
1714
1715         Reviewed by Daniel Bates.
1716
1717         * DumpRenderTree/win/DumpRenderTree.cpp:
1718         (applicationId): Use makeString instead of String::format.
1719         (main): Ditto.
1720         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1721         (TestWebKitAPI::Util::createURLForResource): Ditto.
1722         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1723         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
1724
1725         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1726         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
1727         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
1728         (WTR::createStringWithAttributes): Use appendLiteral.
1729         (WTR::AccessibilityUIElement::helpText const): Ditto.
1730         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
1731         directly instead of using String::format.
1732         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
1733         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
1734
1735 2019-02-15  Truitt Savell  <tsavell@apple.com>
1736
1737         Unreviewed, rolling out r241564.
1738
1739         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
1740
1741         Reverted changeset:
1742
1743         "[Mac] WebInspectorUI.framework does not need to be soft-
1744         linked anymore"
1745         https://bugs.webkit.org/show_bug.cgi?id=194411
1746         https://trac.webkit.org/changeset/241564
1747
1748 2019-02-15  Saam barati  <sbarati@apple.com>
1749
1750         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
1751         https://bugs.webkit.org/show_bug.cgi?id=194036
1752
1753         Reviewed by Yusuke Suzuki.
1754
1755         * Scripts/run-jsc-stress-tests:
1756
1757 2019-02-14  Tim Horton  <timothy_horton@apple.com>
1758
1759         Fix the build.
1760
1761         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1762         (WTR::UIScriptController::drawSquareInEditableImage):
1763         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1764         (TestWebKitAPI::drawSquareInEditableImage):
1765
1766 2019-02-14  Tim Horton  <timothy_horton@apple.com>
1767
1768         Fix the build.
1769
1770         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1771         (WTR::UIScriptController::drawSquareInEditableImage):
1772         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1773         (TestWebKitAPI::drawSquareInEditableImage):
1774
1775 2019-02-14  Brian Burg  <bburg@apple.com>
1776
1777         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
1778         https://bugs.webkit.org/show_bug.cgi?id=194411
1779         <rdar://problem/47787614>
1780
1781         Reviewed by Joseph Pecoraro.
1782
1783         Remove unnecessary soft linking macro usage.
1784
1785         * DumpRenderTree/mac/TestRunnerMac.mm:
1786         (TestRunner::inspectorTestStubURL):
1787         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
1788         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1789         (WTR::TestRunner::inspectorTestStubURL):
1790
1791 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
1792
1793         [ews-app] status bubble should fetch builder name info from BuilderMapping table
1794         https://bugs.webkit.org/show_bug.cgi?id=194599
1795
1796         Reviewed by Lucas Forschler.
1797
1798         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1799         (StatusBubble._build_bubble):
1800
1801 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
1802
1803         [ews-app] Set Foreign Key in Django build model
1804         https://bugs.webkit.org/show_bug.cgi?id=194667
1805
1806         Reviewed by Lucas Forschler.
1807
1808         * BuildSlaveSupport/ews-app/ews/models/build.py:
1809         (Build):
1810
1811 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
1812
1813         [WTF] Add environment variable helpers
1814         https://bugs.webkit.org/show_bug.cgi?id=192405
1815
1816         Reviewed by Michael Catanzaro.
1817
1818         * DumpRenderTree/mac/DumpRenderTree.mm:
1819         (libraryPathForDumpRenderTree):
1820         * DumpRenderTree/win/DumpRenderTree.cpp:
1821         (libraryPathForDumpRenderTree):
1822         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
1823         (setUpIOSLayoutTestCommunication):
1824         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
1825         (TestWebKitAPI::strip):
1826         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1827         (beforeAll):
1828         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1829         (main):
1830         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1831         (WebKitTestBus::run):
1832         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1833         (WTR::getOutputDir):
1834         (WTR::initializeFontConfigSetting):
1835         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
1836         (WTR::InjectedBundle::platformInitialize):
1837         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1838         (WTR::topLevelPath):
1839         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
1840         (WTR::topLevelPath):
1841         (WTR::getOutputDir):
1842         (WTR::activateFonts):
1843         * WebKitTestRunner/TestController.cpp:
1844         (WTR::TestController::libraryPathForTesting):
1845         (WTR::TestController::generateContextConfiguration const):
1846         (WTR::TestController::generatePageConfiguration):
1847         (WTR::TestController::decideDestinationWithSuggestedFilename):
1848         (WTR::TestController::platformAdjustContext):
1849         * WebKitTestRunner/TestController.h:
1850         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1851         (WTR::TestController::cocoaPlatformInitialize):
1852         (WTR::TestController::platformAdjustContext):
1853         * WebKitTestRunner/gtk/main.cpp:
1854         (main):
1855         * WebKitTestRunner/mac/TestControllerMac.mm:
1856         (WTR::TestController::configureContentExtensionForTest):
1857         * WebKitTestRunner/wpe/main.cpp:
1858         (main):
1859         Utilize WTF::Environment where possible.
1860
1861 2019-02-14  Chris Dumez  <cdumez@apple.com>
1862
1863         [PSON] Introduce a WebContent Process cache
1864         https://bugs.webkit.org/show_bug.cgi?id=194594
1865         <rdar://problem/46793397>
1866
1867         Reviewed by Geoff Garen.
1868
1869         Update API tests to turn on the WebContent Process cache.
1870
1871         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1872
1873 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
1874
1875         Unreviewed, build fix after r241480
1876
1877         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1878         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
1879         (-[DragAndDropSimulator initWithWebView:]):
1880
1881 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
1882
1883         AX: ARIA Reflection was disabled in error
1884         https://bugs.webkit.org/show_bug.cgi?id=194647
1885         <rdar://problem/48068336>
1886
1887         Reviewed by Ryosuke Niwa.
1888
1889         Remove test override now that this feature should be enabled by default.
1890
1891         * WebKitTestRunner/TestController.cpp:
1892         (WTR::TestController::resetPreferencesToConsistentValues):
1893
1894 2019-02-14  Commit Queue  <commit-queue@webkit.org>
1895
1896         Unreviewed, rolling out r241486.
1897         https://bugs.webkit.org/show_bug.cgi?id=194655
1898
1899         causing API failures in builds (Requested by ShawnRoberts on
1900         #webkit).
1901
1902         Reverted changeset:
1903
1904         "[Cocoa] Media elements will restart network buffering just
1905         before suspending"
1906         https://bugs.webkit.org/show_bug.cgi?id=193691
1907         https://trac.webkit.org/changeset/241486
1908
1909 2019-02-14  Zalan Bujtas  <zalan@apple.com>
1910
1911         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
1912         https://bugs.webkit.org/show_bug.cgi?id=194622
1913
1914         Reviewed by Antti Koivisto.
1915
1916         * LayoutReloaded/misc/LFC-passing-tests.txt:
1917
1918 2019-02-14  Zalan Bujtas  <zalan@apple.com>
1919
1920         [LFC] Shrink-to-fit-width should be constrained by min/max width
1921         https://bugs.webkit.org/show_bug.cgi?id=194653
1922
1923         Reviewed by Antti Koivisto.
1924
1925         * LayoutReloaded/misc/LFC-passing-tests.txt:
1926
1927 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
1928
1929         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
1930         https://bugs.webkit.org/show_bug.cgi?id=194641
1931
1932         Reviewed by Geoffrey Garen.
1933
1934         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
1935         so that the test would fail without this fix.
1936
1937         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
1938         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
1939
1940 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1941
1942         [ews-app] Change log level for a log statement
1943
1944         Unreviewed minor fix.
1945
1946         * BuildSlaveSupport/ews-app/ews/models/patch.py:
1947         (Patch.save_patch):
1948
1949 2019-02-13  Jer Noble  <jer.noble@apple.com>
1950
1951         [Cocoa] Media elements will restart network buffering just before suspending
1952         https://bugs.webkit.org/show_bug.cgi?id=193691
1953
1954         Reviewed by Eric Carlson.
1955
1956         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1957         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
1958         (TEST):
1959
1960 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1961
1962         [ews-app] Fetch builder id to name mapping
1963         https://bugs.webkit.org/show_bug.cgi?id=194355
1964
1965         Reviewed by Lucas Forschler.
1966
1967         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
1968         (Buildbot.get_builder_id_to_name_mapping):
1969         (Buildbot._get_display_name_from_builder_name):
1970
1971 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
1972
1973         Further restricting webarchive loads
1974         https://bugs.webkit.org/show_bug.cgi?id=194567
1975         <rdar://problem/47610130>
1976
1977         Reviewed by Youenn Fablet.
1978
1979         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
1980         navigations on drop.
1981
1982         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1983         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
1984         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
1985         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
1986         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1987         (TestWebKitAPI::TEST):
1988         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
1989         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
1990         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
1991         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1992         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
1993         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
1994         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
1995
1996 2019-02-13  John Wilander  <wilander@apple.com>
1997
1998         Store Ad Click Attribution requests in the network process
1999         https://bugs.webkit.org/show_bug.cgi?id=194510
2000         <rdar://problem/47650118>
2001
2002         Reviewed by Alex Christensen and Daniel Bates.
2003
2004         This patch adds two TestRunner functions:
2005         - dumpAdClickAttribution()
2006         - clearAdClickAttribution()
2007
2008         They call into the network process to dump and clear Ad Click
2009         Attribution state, respectively.
2010
2011         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2012         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2013         (WTR::TestRunner::dumpAdClickAttribution):
2014         (WTR::TestRunner::clearAdClickAttribution):
2015         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2016         * WebKitTestRunner/TestController.cpp:
2017         (WTR::TestController::resetStateToConsistentValues):
2018         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
2019         (WTR::adClickAttributionStringResultCallback):
2020         (WTR::TestController::dumpAdClickAttribution):
2021         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
2022         (WTR::adClickAttributionVoidCallback):
2023         (WTR::TestController::clearAdClickAttribution):
2024         * WebKitTestRunner/TestController.h:
2025         * WebKitTestRunner/TestInvocation.cpp:
2026         (WTR::TestInvocation::dumpResults):
2027         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2028         (WTR::TestInvocation::dumpAdClickAttribution):
2029         * WebKitTestRunner/TestInvocation.h:
2030
2031 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
2032
2033         [ews-app] Generate status-bubble
2034         https://bugs.webkit.org/show_bug.cgi?id=194572
2035
2036         Reviewed by Lucas Forschler.
2037
2038         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2039         (StatusBubble._build_bubble):
2040         (StatusBubble._should_show_bubble_for):
2041         (StatusBubble._build_bubbles_for_patch):
2042
2043 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
2044
2045         [ews-app] Add status bubble html template
2046         https://bugs.webkit.org/show_bug.cgi?id=194571
2047
2048         Reviewed by Lucas Forschler.
2049
2050         * BuildSlaveSupport/ews-app/ews/templates: Added.
2051         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
2052
2053 2019-02-12  Chris Dumez  <cdumez@apple.com>
2054
2055         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
2056         https://bugs.webkit.org/show_bug.cgi?id=194568
2057         <rdar://problem/47944490>
2058
2059         Reviewed by Ryosuke Niwa.
2060
2061         Add API test coverage.
2062
2063         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2064         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
2065
2066 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
2067
2068         webkitpy: Remove bug_dummy from parsed test expectations
2069         https://bugs.webkit.org/show_bug.cgi?id=194562
2070         <rdar://problem/47853999>
2071
2072         Reviewed by Lucas Forschler.
2073
2074         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2075         (TestExpectationParser):
2076         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
2077         skipped tests.
2078         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2079
2080 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
2081
2082         [ews-app] Add method to fetch patch
2083         https://bugs.webkit.org/show_bug.cgi?id=194518
2084
2085         Reviewed by Lucas Forschler.
2086
2087         * BuildSlaveSupport/ews-app/ews/models/patch.py:
2088         (Patch.get_patch):
2089
2090 2019-02-12  Zalan Bujtas  <zalan@apple.com>
2091
2092         [LFC] Expand tests coverage (60 new tests -> 860)
2093
2094         Unreviewed test gardening (run-singly, --child-processes=1).
2095
2096         * LayoutReloaded/misc/LFC-passing-tests.txt:
2097
2098 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2099
2100         Allow pages to trigger programmatic paste from script on iOS
2101         https://bugs.webkit.org/show_bug.cgi?id=194271
2102         <rdar://problem/47808810>
2103
2104         Reviewed by Tim Horton.
2105
2106         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
2107
2108         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2109         (WTR::UIScriptController::platformSetDidShowMenuCallback):
2110         (WTR::UIScriptController::platformSetDidHideMenuCallback):
2111         (WTR::UIScriptController::rectForMenuAction const):
2112
2113         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
2114         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
2115         for when the menu is shown or hidden.
2116
2117         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2118         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
2119         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2120         (WTR::UIScriptController::setDidShowMenuCallback):
2121         (WTR::UIScriptController::didShowMenuCallback const):
2122         (WTR::UIScriptController::setDidHideMenuCallback):
2123         (WTR::UIScriptController::didHideMenuCallback const):
2124         (WTR::UIScriptController::platformSetDidShowMenuCallback):
2125         (WTR::UIScriptController::platformSetDidHideMenuCallback):
2126         (WTR::UIScriptController::rectForMenuAction const):
2127         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2128         * WebKitTestRunner/TestController.cpp:
2129         (WTR::TestController::resetPreferencesToConsistentValues):
2130         (WTR::updateTestOptionsFromTestHeader):
2131         * WebKitTestRunner/TestOptions.h:
2132
2133         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
2134         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
2135
2136         (WTR::TestOptions::hasSameInitializationOptions const):
2137         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2138         (WTR::UIScriptController::calendarType const):
2139         (WTR::UIScriptController::platformUndoManager const):
2140         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2141         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2142         (-[TestRunnerWKWebView initWithFrame:configuration:]):
2143         (-[TestRunnerWKWebView dealloc]):
2144         (-[TestRunnerWKWebView _didShowMenu]):
2145         (-[TestRunnerWKWebView _didHideMenu]):
2146
2147         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
2148
2149         * WebKitTestRunner/ios/TestControllerIOS.mm:
2150         (WTR::handleMenuWillHideNotification):
2151         (WTR::handleMenuDidHideNotification):
2152         (WTR::TestController::platformInitialize):
2153         (WTR::TestController::platformDestroy):
2154         (WTR::TestController::platformResetStateToConsistentValues):
2155
2156         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
2157         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
2158
2159         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2160         (WTR::forEachViewInHierarchy):
2161         (WTR::findViewInHierarchyOfType):
2162
2163         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
2164         functions that dig through a given view's hierarchy in search of a view of a given class.
2165
2166         (WTR::UIScriptController::selectionStartGrabberViewRect const):
2167         (WTR::UIScriptController::selectionEndGrabberViewRect const):
2168         (WTR::UIScriptController::selectionCaretViewRect const):
2169         (WTR::UIScriptController::selectionRangeViewRects const):
2170         (WTR::UIScriptController::platformSetDidShowMenuCallback):
2171         (WTR::UIScriptController::platformSetDidHideMenuCallback):
2172
2173         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
2174
2175         (WTR::UIScriptController::rectForMenuAction const):
2176
2177         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
2178         callout bar) whose label matches the given string.
2179
2180         (WTR::UIScriptController::platformContentView const):
2181
2182         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
2183         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
2184         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
2185
2186         (WTR::UIScriptController::platformUndoManager const): Deleted.
2187         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2188         (WTR::UIScriptController::platformContentView const):
2189         (WTR::UIScriptController::platformUndoManager const): Deleted.
2190
2191 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
2192
2193         webkitpy: No option to only show unexpected failures in results.html for iPad
2194         https://bugs.webkit.org/show_bug.cgi?id=194554
2195         <rdar://problem/47922442>
2196
2197         Rubber-stamped by Aakash Jain.
2198
2199         Just because a TestExpecations file does not exist for a specific platform does not mean that
2200         TestExpecations are not being used, given that platforms inherit test expectations.
2201
2202         * Scripts/webkitpy/port/base.py:
2203         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
2204         * Scripts/webkitpy/port/base_unittest.py:
2205         (PortTest.test_uses_test_expectations_file):
2206
2207 2019-02-12  Alex Christensen  <achristensen@webkit.org>
2208
2209         Remove setDefersLoading infrastructure from WebKit2
2210         https://bugs.webkit.org/show_bug.cgi?id=194506
2211
2212         Reviewed by Brady Eidson.
2213
2214         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2215         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2216         (WTR::TestRunner::setDefersLoading): Deleted.
2217         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2218
2219 2019-02-12  Alex Christensen  <achristensen@webkit.org>
2220
2221         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
2222         https://bugs.webkit.org/show_bug.cgi?id=194522
2223         <rdar://problem/47789393>
2224
2225         Reviewed by Chris Dumez.
2226
2227         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2228         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
2229         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2230         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2231
2232 2019-02-12  Andy Estes  <aestes@apple.com>
2233
2234         [iOSMac] Enable Parental Controls Content Filtering
2235         https://bugs.webkit.org/show_bug.cgi?id=194521
2236         <rdar://39732376>
2237
2238         Reviewed by Tim Horton.
2239
2240         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2241
2242 2019-02-12  Zalan Bujtas  <zalan@apple.com>
2243
2244         [LFC][IFC] Add intrinsic width support for float boxes.
2245         https://bugs.webkit.org/show_bug.cgi?id=194528
2246
2247         Reviewed by Antti Koivisto.
2248
2249         Expand tests coverage (2 new tests -> 800).
2250         (This is the correct test ordering --runs-singly --child-processes=1)
2251
2252         * LayoutReloaded/misc/LFC-passing-tests.txt:
2253
2254 2019-02-12  Rob Buis  <rbuis@igalia.com>
2255
2256         Implement serializing in MIME type parser
2257         https://bugs.webkit.org/show_bug.cgi?id=193909
2258
2259         Reviewed by Darin Adler.
2260
2261         Add various tests involving upper case, non-ASCII, control/null characters,
2262         various HTTP whitespace, single quotes and an unpaired surrogate.
2263
2264         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
2265         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
2266         (TestWebKitAPI::serializeIfValid):
2267         (TestWebKitAPI::TEST):
2268
2269 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
2270
2271         [Cocoa] Ask platform for generic font family mappings
2272         https://bugs.webkit.org/show_bug.cgi?id=187723
2273         <rdar://problem/41892438>
2274
2275         Reviewed by Brent Fulgham.
2276
2277         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
2278
2279         * DumpRenderTree/mac/DumpRenderTree.mm:
2280         (allowedFontFamilySet):
2281         * WebKitTestRunner/mac/TestControllerMac.mm:
2282         (WTR::allowedFontFamilySet):
2283
2284 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
2285
2286         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
2287         https://bugs.webkit.org/show_bug.cgi?id=193622
2288
2289         Reviewed by Michael Catanzaro.
2290
2291         This adds support for loading content extension rule sets from the JSON files which
2292         accompany the corresponding layout test, using the C API. The Cocoa specific parts
2293         of WKTR for this could be removed, but that is left for a follow-up patch with
2294         cleanups.
2295
2296         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
2297         * WebKitTestRunner/TestController.cpp:
2298         (WTR::testPath): Subtract one from the length when constructing the result std::string to
2299         avoid having the null-terminator copied into the result.
2300         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
2301         part of the preparations to run a test.
2302         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
2303         (WTR::contentExtensionStoreCallback): Added.
2304         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
2305         used for content extensions test.
2306         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
2307         extensions and compiling the JSON rule set for tests involving content extensions.
2308         (WTR::TestController::resetContentExtensions): Removes the content extension built for
2309         testing and disables content extensions.
2310         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
2311         resetContentExtensions().
2312         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
2313         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
2314         configureContentExtensionForTest(), and userContentController().
2315
2316 2019-02-11  Daniel Bates  <dabates@apple.com>
2317
2318         [iOS] Mouse/Touch/Pointer events are missing modifier keys
2319         https://bugs.webkit.org/show_bug.cgi?id=191446
2320         <rdar://problem/45929460>
2321
2322         Reviewed by Tim Horton.
2323
2324         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
2325
2326         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2327         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2328         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2329         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2330         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2331         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2332         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2333         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2334         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2335         (WTR::arrayLength):
2336         (WTR::parseModifierArray):
2337         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
2338         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2339         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
2340         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2341
2342 2019-02-11  Commit Queue  <commit-queue@webkit.org>
2343
2344         Unreviewed, rolling out r241272 and r241276.
2345         https://bugs.webkit.org/show_bug.cgi?id=194514
2346
2347         Broke the Apple Internal build and the fix requires human
2348         intervention :( (Requested by dydz on #webkit).
2349
2350         Reverted changesets:
2351
2352         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
2353         https://bugs.webkit.org/show_bug.cgi?id=191446
2354         https://trac.webkit.org/changeset/241272
2355
2356         "Fix internal iOS build after r241272"
2357         https://bugs.webkit.org/show_bug.cgi?id=191446
2358         https://trac.webkit.org/changeset/241276
2359
2360 2019-02-11  Truitt Savell  <tsavell@apple.com>
2361
2362         Unreviewed, rolling out r241269.
2363
2364         Caused 5 layout tests crashes on Mac WK1
2365
2366         Reverted changeset:
2367
2368         "DumpRenderTree should report unknown options"
2369         https://bugs.webkit.org/show_bug.cgi?id=191303
2370         https://trac.webkit.org/changeset/241269
2371
2372 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2373
2374         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
2375         https://bugs.webkit.org/show_bug.cgi?id=194313
2376
2377         Reviewed by Tim Horton.
2378
2379         Add a helper to determine whether the web view is presenting modal UI.
2380
2381         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2382         (WTR::UIScriptController::isPresentingModally const):
2383         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2384         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2385         (WTR::UIScriptController::isPresentingModally const):
2386         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2387         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2388         (WTR::UIScriptController::calendarType const): Deleted.
2389         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2390         (WTR::UIScriptController::isPresentingModally const):
2391         (WTR::UIScriptController::calendarType const):
2392         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2393         (WTR::UIScriptController::calendarType const):
2394
2395 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
2396
2397         GCHeapInspector: Show the retained sizes in more places
2398         https://bugs.webkit.org/show_bug.cgi?id=194464
2399
2400         Reviewed by Simon Fraser.
2401
2402         * GCHeapInspector/gc-heap-inspector.html:
2403         * GCHeapInspector/script/interface.js:
2404         (HeapInspectorUtils.humanReadableSize):
2405         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
2406         (HeapInspectorUtils.spanForNode.span.span):
2407         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
2408         (HeapSnapshotInspector.prototype.buildRoots):
2409
2410 2019-02-11  Daniel Bates  <dabates@apple.com>
2411
2412         [iOS] Mouse/Touch/Pointer events are missing modifier keys
2413         https://bugs.webkit.org/show_bug.cgi?id=191446
2414         <rdar://problem/45929460>
2415
2416         Reviewed by Tim Horton.
2417
2418         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
2419
2420         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2421         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2422         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2423         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2424         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2425         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2426         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2427         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2428         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2429         (WTR::arrayLength):
2430         (WTR::parseModifierArray):
2431         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
2432         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2433         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
2434         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2435
2436 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
2437
2438         DumpRenderTree should report unknown options
2439         https://bugs.webkit.org/show_bug.cgi?id=191303
2440
2441         Reviewed by Frédéric Wang.
2442
2443         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
2444         to report unknown options.
2445         Added and assigned test options which are currently used in tests.
2446
2447         * DumpRenderTree/TestOptions.cpp:
2448         (TestOptions::TestOptions):
2449
2450 2019-02-11  Truitt Savell  <tsavell@apple.com>
2451
2452         Unreviewed, rolling out r241229.
2453
2454         Revision broke internal builds for watchOS.
2455
2456         Reverted changeset:
2457
2458         "[Cocoa] Ask platform for generic font family mappings"
2459         https://bugs.webkit.org/show_bug.cgi?id=187723
2460         https://trac.webkit.org/changeset/241229
2461
2462 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
2463
2464         [WinCairo][MiniBrowser] Basic authentication always fails.
2465         https://bugs.webkit.org/show_bug.cgi?id=194496
2466
2467         Reviewed by Don Olmstead.
2468
2469         * MiniBrowser/win/DialogHelper.h:
2470         (Dialog::getText):
2471
2472 2019-02-11  Philippe Normand  <pnormand@igalia.com>
2473
2474         [GStreamer] GstMappedBuffer testsuite build fails
2475         https://bugs.webkit.org/show_bug.cgi?id=194495
2476
2477         Reviewed by Carlos Garcia Campos.
2478
2479         Fix the build by explicitely adding the gstreamer1.0-audio include
2480         directories to the include path.
2481
2482         * TestWebKitAPI/PlatformGTK.cmake:
2483         * TestWebKitAPI/PlatformWPE.cmake:
2484
2485 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2486
2487         [GTK][WPE] Add enable-javascript-markup setting
2488         https://bugs.webkit.org/show_bug.cgi?id=193439
2489
2490         Reviewed by Michael Catanzaro.
2491
2492         Add test cases to check the new setting.
2493
2494         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2495         (testWebKitSettings):
2496         (testWebKitSettingsJavaScriptMarkup):
2497         (beforeAll):
2498
2499 2019-02-10  Darin Adler  <darin@apple.com>
2500
2501         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
2502         https://bugs.webkit.org/show_bug.cgi?id=194485
2503
2504         Reviewed by Daniel Bates.
2505
2506         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
2507
2508 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
2509
2510         Add more tests for clampTo<>()
2511         https://bugs.webkit.org/show_bug.cgi?id=194462
2512
2513         Reviewed by Geoffrey Garen.
2514
2515         Darin suggested to test the very last floating point number
2516         at the boundaries when truncating to integer.
2517         I added test for max/min and max-1/min-1.
2518
2519         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2520         (TestWebKitAPI::TEST):
2521
2522 2019-02-09  Darin Adler  <darin@apple.com>
2523
2524         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
2525         https://bugs.webkit.org/show_bug.cgi?id=194021
2526
2527         Reviewed by Geoffrey Garen.
2528
2529         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
2530         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
2531         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
2532
2533 2019-02-09  Zalan Bujtas  <zalan@apple.com>
2534
2535         [LFC][IFC] Add intrinsic width support for basic inline containers
2536         https://bugs.webkit.org/show_bug.cgi?id=194473
2537
2538         Reviewed by Antti Koivisto.
2539
2540         Expand tests coverage (11 new tests -> 798)
2541
2542         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
2543
2544 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
2545
2546         Fix MiniBrowser's entitlements
2547         https://bugs.webkit.org/show_bug.cgi?id=192431
2548
2549         Reviewed by Joseph Pecoraro.
2550
2551         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
2552         files, making it impossible to load any extension.
2553
2554         * MiniBrowser/MiniBrowser.entitlements:
2555
2556 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
2557
2558         [Cocoa] Ask platform for generic font family mappings
2559         https://bugs.webkit.org/show_bug.cgi?id=187723
2560         <rdar://problem/41892438>
2561
2562         Reviewed by Brent Fulgham.
2563
2564         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
2565
2566         * DumpRenderTree/mac/DumpRenderTree.mm:
2567         (allowedFontFamilySet):
2568         * WebKitTestRunner/mac/TestControllerMac.mm:
2569         (WTR::allowedFontFamilySet):
2570
2571 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
2572
2573         [GTK] Implement back/forward touchpad gesture
2574         https://bugs.webkit.org/show_bug.cgi?id=193919
2575
2576         Reviewed by Michael Catanzaro.
2577
2578         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2579         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
2580
2581 2019-02-08  Alex Christensen  <achristensen@webkit.org>
2582
2583         Add SPI to use networking daemon instead of XPC service
2584         https://bugs.webkit.org/show_bug.cgi?id=194427
2585
2586         Reviewed by Geoffrey Garen
2587
2588         * MiniBrowser/MiniBrowser.entitlements:
2589
2590 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
2591
2592         [ews-build] Ensure that every builder in config.json has short name
2593         https://bugs.webkit.org/show_bug.cgi?id=194461
2594
2595         Reviewed by Lucas Forschler.
2596
2597         * BuildSlaveSupport/ews-build/loadConfig.py:
2598         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
2599
2600 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
2601
2602         [ews-build] Add short name to config.json
2603         https://bugs.webkit.org/show_bug.cgi?id=194456
2604
2605         Reviewed by Lucas Forschler.
2606
2607         * BuildSlaveSupport/ews-build/config.json: Added short name.
2608         * BuildSlaveSupport/ews-build/loadConfig.py:
2609         (loadBuilderConfig): Set the short name as the builder description.
2610
2611 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
2612
2613         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
2614         https://bugs.webkit.org/show_bug.cgi?id=194418
2615
2616         Reviewed by Lucas Forschler.
2617
2618         Do not include errors trying when finding crashlogs at the end of
2619         a run-webkit-tests run since we don't process those errors.
2620
2621         * Scripts/webkitpy/port/darwin.py:
2622         (DarwinPort._look_for_all_crash_logs_in_log_dir):
2623         * Scripts/webkitpy/port/ios_device.py:
2624         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
2625         * Scripts/webkitpy/port/watch_device.py:
2626         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
2627
2628 2019-02-08  Beth Dakin  <bdakin@apple.com>
2629
2630         Add afterScreenUpdates to WKSnapshotConfiguration
2631         https://bugs.webkit.org/show_bug.cgi?id=194362
2632         -and corresponding-
2633         <rdar://problem/40655528> Please add an "after screen updates" property to 
2634         WKSnapshotConfiguration (to solve blank snapshots)
2635
2636         Reviewed by Tim Horton.
2637
2638         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
2639         (TEST):
2640
2641 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
2642
2643         clampTo(): do not convert the input to double when dealing with integers
2644         https://bugs.webkit.org/show_bug.cgi?id=194263
2645         <rdar://problem/47692312>
2646
2647         Reviewed by Darin Adler.
2648
2649         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2650         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
2651         (TestWebKitAPI::testClampFloatingPointToInteger):
2652         (TestWebKitAPI::testClampSameSignIntegers):
2653         (TestWebKitAPI::testClampUnsignedToSigned):
2654         (TestWebKitAPI::testClampSignedToUnsigned):
2655
2656 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
2657
2658         webkitpy: Respect --dedicated-simulators flag
2659         https://bugs.webkit.org/show_bug.cgi?id=194416
2660         <rdar://problem/47894722>
2661
2662         Reviewed by Lucas Forschler.
2663
2664         * Scripts/webkitpy/port/device_port.py:
2665         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
2666         available devices can be safely ignored.
2667
2668 2019-02-07  Keith Rollin  <krollin@apple.com>
2669
2670         Remove extra copy of 100x100-red.tga
2671         https://bugs.webkit.org/show_bug.cgi?id=194371
2672         <rdar://problem/47873465>
2673
2674         Reviewed by Said Abou-Hallawa.
2675
2676         In order to help it pass its tests, Bug 194190 added a second copy of
2677         the file 100x100-red.tga. However, it turns out that this additional
2678         file wasn't actually needed, and that that sole previous copy was
2679         sufficient. At the same time, this second copy -- which was copied to
2680         the same location in the build output as the first copy -- now caused
2681         XCBuild to complain because there were two production rules for the
2682         same output file. Address this by removing the newly-added extra copy.
2683
2684         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2685         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
2686
2687 2019-02-07  Alex Christensen  <achristensen@webkit.org>
2688
2689         Deprecate WKBundlePageSetDefersLoading
2690         https://bugs.webkit.org/show_bug.cgi?id=191394
2691
2692         Reviewed by Dean Jackson.
2693
2694         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2695         (WTR::TestRunner::setDefersLoading):
2696
2697 2019-02-07  Zalan Bujtas  <zalan@apple.com>
2698
2699         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
2700         https://bugs.webkit.org/show_bug.cgi?id=194391
2701
2702         Reviewed by Antti Koivisto.
2703
2704         * LayoutReloaded/misc/LFC-passing-tests.txt:
2705
2706 2019-02-06  Keith Rollin  <krollin@apple.com>
2707
2708         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
2709         https://bugs.webkit.org/show_bug.cgi?id=193975
2710         <rdar://problem/47643306>
2711
2712         Reviewed by Tim Horton.
2713
2714         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
2715         the Info.plist file into the bundle. This step is not necessary as the
2716         implicit "bundle up all the build products into a framework" build
2717         phase does this already. Having the Copy Bundle Resources phase do
2718         this causes a conflict under XCBuild, which objects to two build
2719         phases producing the same file (Info.plist). Address this by removing
2720         Info.plist from the Copy Bundle Resources phase.
2721
2722         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
2723
2724 2019-02-06  Keith Rollin  <krollin@apple.com>
2725
2726         Really enable the automatic checking and regenerations of .xcfilelists during builds
2727         https://bugs.webkit.org/show_bug.cgi?id=194357
2728         <rdar://problem/47861231>
2729
2730         Reviewed by Chris Dumez.
2731
2732         Bug 194124 was supposed to enable the automatic checking and
2733         regenerating of .xcfilelist files during the build. While related
2734         changes were included in that patch, the change to actually enable the
2735         operation somehow was omitted. This patch actually enables the
2736         operation. The check-xcfilelist.sh scripts now check
2737         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
2738         from the checking.
2739
2740         * DumpRenderTree/Scripts/check-xcfilelists.sh:
2741         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
2742
2743 2019-02-06  David Kilzer  <ddkilzer@apple.com>
2744
2745         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
2746         <https://webkit.org/b/194286>
2747         <rdar://problem/47815558>
2748
2749         Reviewed by Alexey Proskuryakov.
2750
2751         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2752         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
2753         WKRetainPtr<> to avoid leaking the WKDataRef.
2754
2755 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
2756
2757         Unreviewed, fix a typo
2758
2759         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2760
2761 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
2762
2763         [GTK][WPE] force libpsl build to use ICU in jhbuild
2764         https://bugs.webkit.org/show_bug.cgi?id=194288
2765
2766         Reviewed by Carlos Garcia Campos.
2767
2768         * gtk/jhbuild.modules:
2769         Require ICU for libpsl build in jhbuild, like done in WPE.
2770
2771 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
2772
2773         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
2774         https://bugs.webkit.org/show_bug.cgi?id=194209
2775
2776         Reviewed by Carlos Garcia Campos.
2777
2778         Enhance TestCookieManager to ensure this doesn't happen again.
2779
2780         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2781         (testCookieManagerPersistentStorage):
2782         (beforeAll):
2783
2784 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2785
2786         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
2787         https://bugs.webkit.org/show_bug.cgi?id=194324
2788
2789         Reviewed by Andy Estes.
2790
2791         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
2792         part of the name is already implicit, since this is in testing code in TestOptions.
2793
2794         * WebKitTestRunner/TestController.cpp:
2795         (WTR::TestController::generateContextConfiguration const):
2796         (WTR::updateTestOptionsFromTestHeader):
2797         * WebKitTestRunner/TestOptions.h:
2798         (WTR::TestOptions::hasSameInitializationOptions const):
2799
2800 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2801
2802         [ews-build] Allow * as platform for builders and workers
2803         https://bugs.webkit.org/show_bug.cgi?id=188533
2804
2805         Reviewed by Lucas Forschler.
2806
2807         * BuildSlaveSupport/ews-build/loadConfig.py:
2808         (checkWorkersAndBuildersForConsistency):
2809
2810 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2811
2812         [ews-build] Add few bots to config.json
2813         https://bugs.webkit.org/show_bug.cgi?id=194304
2814
2815         Reviewed by Lucas Forschler.
2816
2817         * BuildSlaveSupport/ews-build/config.json:
2818
2819 2019-02-05  Keith Rollin  <krollin@apple.com>
2820
2821         Enable the automatic checking and regenerations of .xcfilelists during builds
2822         https://bugs.webkit.org/show_bug.cgi?id=194124
2823         <rdar://problem/47721277>
2824
2825         Reviewed by Tim Horton.
2826
2827         Bug 193790 add a facility for checking -- during build time -- that
2828         any needed .xcfilelist files are up-to-date and for updating them if
2829         they are not. This facility was initially opt-in by setting
2830         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
2831         the process seemed robust. Its now time to enable this facility and
2832         make it opt-out. If there is a need to disable this facility, set and
2833         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
2834         running `make` or `build-webkit`, or before running Xcode from the
2835         command line.
2836
2837         Additionally, remove the step that generates a list of source files
2838         going into the UnifiedSources build step. It's only necessarily to
2839         specify Sources.txt and SourcesCocoa.txt as inputs.
2840
2841         * Scripts/generate-xcfilelists:
2842
2843 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
2844
2845         [GTK][WPE] force libpsl build to use ICU in jhbuild
2846         https://bugs.webkit.org/show_bug.cgi?id=194288
2847
2848         Reviewed by Philippe Normand.
2849
2850         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
2851         This can cause build failures if libidn is detected but libunistring is not available.
2852
2853         Make sure that ICU is used for runtime and builtin PSL data.
2854
2855         * gtk/jhbuild.modules:
2856         * wpe/jhbuild.modules:
2857
2858 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2859
2860         [ews-app] Modified timestamp should be updated on updating data
2861         https://bugs.webkit.org/show_bug.cgi?id=194295
2862
2863         Reviewed by Lucas Forschler.
2864
2865         * BuildSlaveSupport/ews-app/ews/models/build.py:
2866         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2867         * BuildSlaveSupport/ews-app/ews/models/step.py:
2868
2869 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
2870
2871         Unreviewed, rolling out r240742.
2872
2873         Causes crashes on iOS simulator.
2874
2875         Reverted changeset:
2876
2877         "[iOS] Keyups for non-modifier keys identified as "Dead" when
2878         not focused in a content-editable element"
2879         https://bugs.webkit.org/show_bug.cgi?id=192824
2880         https://trac.webkit.org/changeset/240742
2881
2882 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
2883
2884         run-webkit-tests emits message "...running None" when running tests
2885         https://bugs.webkit.org/show_bug.cgi?id=194133
2886         <rdar://problem/47724738>
2887
2888         Reviewed by Lucas Forschler.
2889
2890         * Scripts/webkitpy/xcode/device_type.py:
2891         (DeviceType.__str__): Use both version mapping tables and use just the variant
2892         name if no version name is available.
2893         * Scripts/webkitpy/xcode/device_type_unittest.py:
2894         (DeviceTypeTest):
2895         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
2896         an associated named.
2897
2898 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
2899
2900         [WPE] require python3-setuptools for meson build in jhbuild
2901         https://bugs.webkit.org/show_bug.cgi?id=194287
2902
2903         Reviewed by Philippe Normand.
2904
2905         python3-setuptools is needed to build meson in jhbuild.
2906         It is already required by the GTK port.
2907
2908         * wpe/install-dependencies:
2909
2910 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2911
2912         [ews-app] Add method to save BuilderMapping to database
2913         https://bugs.webkit.org/show_bug.cgi?id=194264
2914
2915         Reviewed by Lucas Forschler.
2916
2917         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2918         (BuilderMapping.__str__):
2919         (BuilderMapping):
2920         (BuilderMapping.save_mapping):
2921         (BuilderMapping.update_mapping):
2922         (BuilderMapping.get_existing_mapping):
2923         (BuilderMapping.is_valid_mapping):
2924
2925 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2926
2927         [ews-app] Add timestamp fields for BuilderMappings
2928         https://bugs.webkit.org/show_bug.cgi?id=194266
2929
2930         Reviewed by Lucas Forschler.
2931
2932         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2933         (BuilderMapping):
2934
2935 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
2936
2937         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
2938         https://bugs.webkit.org/show_bug.cgi?id=174816
2939
2940         Reviewed by Michael Catanzaro.
2941
2942         Add tests for webkit_uri_for_display().
2943
2944         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
2945         (testURIForDisplayUnaffected):
2946         (testURIForDisplayAffected):
2947         (beforeAll):
2948         (afterAll):
2949         * TestWebKitAPI/glib/CMakeLists.txt:
2950
2951 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
2952
2953         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
2954         https://bugs.webkit.org/show_bug.cgi?id=194158
2955         <rdar://problem/47737268>
2956
2957         Rubber-stamped by Aakash Jain.
2958
2959         * Scripts/webkitpy/port/device_port.py:
2960         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
2961
2962 2019-02-04  Said Abou-Hallawa  <said@apple.com>
2963
2964         [CG] Enable setAdditionalSupportedImageTypes for WK1
2965         https://bugs.webkit.org/show_bug.cgi?id=194190
2966
2967         Reviewed by Tim Horton.
2968
2969         Add a test similar to the one under WebKit Cocoa but make it create a
2970         WebView instead of a WKWebView.
2971
2972         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2973         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
2974         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
2975         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
2976         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
2977         (TestWebKitAPI::runTest):
2978         (TestWebKitAPI::TEST):
2979
2980 2019-02-04  Zalan Bujtas  <zalan@apple.com>
2981
2982         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
2983         https://bugs.webkit.org/show_bug.cgi?id=194168
2984
2985         Reviewed by Simon Fraser.
2986
2987         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
2988
2989         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2990         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
2991         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
2992         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
2993         (TEST):
2994         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
2995         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
2996
2997 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
2998
2999         REGRESSION (r237269): webkit-patch what-broke is broken 
3000         https://bugs.webkit.org/show_bug.cgi?id=193025
3001
3002         Reviewed by Aakash Jain.
3003
3004         * Scripts/webkitpy/common/host.py:
3005         (Host.buildbot):
3006         (Host.bugzilla): Renamed to 'buildbot'.
3007
3008 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3009
3010         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
3011         https://bugs.webkit.org/show_bug.cgi?id=194207
3012
3013         Reviewed by Tim Horton.
3014
3015         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
3016         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
3017         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
3018         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
3019         start and delete forwards to remove the original attachment.
3020
3021         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3022         (TestWebKitAPI::TEST):
3023
3024 2019-02-04  Youenn Fablet  <youenn@apple.com>
3025
3026         Capture state should be managed consistently when doing process swapping
3027         https://bugs.webkit.org/show_bug.cgi?id=194122
3028         <rdar://problem/47609293>
3029
3030         Reviewed by Eric Carlson.
3031
3032         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3033         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
3034         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
3035         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
3036         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3037         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3038         (WTR::TestRunner::isDoingMediaCapture const):
3039         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3040         * WebKitTestRunner/TestController.cpp:
3041         (WTR::TestController::isDoingMediaCapture const):
3042         * WebKitTestRunner/TestController.h:
3043         * WebKitTestRunner/TestInvocation.cpp:
3044         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3045         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3046         (WTR::TestController::isDoingMediaCapture const):
3047
3048 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
3049
3050         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
3051         https://bugs.webkit.org/show_bug.cgi?id=194142
3052
3053         Reviewed by Ross Kirsling.
3054
3055         There three 'separator' variables in TestController.cpp. Renamed
3056         it 'pathSeparator', and unified them.
3057
3058         * WebKitTestRunner/TestController.cpp:
3059         (WTR::TestController::generateContextConfiguration const):
3060         (WTR::createTestURL):
3061         (WTR::TestController::platformAdjustContext):
3062
3063 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
3064
3065         Make setNeedsLayout on the root more explicitly about triggering its side-effects
3066         https://bugs.webkit.org/show_bug.cgi?id=194198
3067
3068         Reviewed by Antti Koivisto.
3069
3070         No need to set the banner heights on navigation now, since Page stores them.
3071
3072         * MiniBrowser/mac/WK2BrowserWindowController.m:
3073         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
3074
3075 2019-02-03  John Wilander  <wilander@apple.com>
3076
3077         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
3078         https://bugs.webkit.org/show_bug.cgi?id=194104
3079         <rdar://problem/47649991>
3080
3081         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
3082
3083         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3084         (TestWebKitAPI::TEST):
3085             Changed numeric types from unsigned short to uint32_t.
3086
3087 2019-02-02  David Kilzer  <ddkilzer@apple.com>
3088
3089         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
3090         <https://webkit.org/b/194178>
3091         <rdar://problem/47753473>
3092
3093         Reviewed by Alexey Proskuryakov.
3094
3095         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3096         (WTR::uninstallFakeHelvetica): Pass nullptr into
3097         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
3098
3099 2019-02-02  Zalan Bujtas  <zalan@apple.com>
3100
3101         [LFC] Initialize ICB's style with fixed width/height.
3102         https://bugs.webkit.org/show_bug.cgi?id=194188
3103
3104         Reviewed by Antti Koivisto.
3105
3106         * LayoutReloaded/misc/LFC-passing-tests.txt:
3107
3108 2019-02-02  Zalan Bujtas  <zalan@apple.com>
3109
3110         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
3111         https://bugs.webkit.org/show_bug.cgi?id=194185
3112
3113         Reviewed by Antti Koivisto.
3114
3115         * LayoutReloaded/misc/LFC-passing-tests.txt:
3116
3117 2018-12-16  Darin Adler  <darin@apple.com>
3118
3119         Convert additional String::format clients to alternative approaches
3120         https://bugs.webkit.org/show_bug.cgi?id=192746
3121
3122         Reviewed by Alexey Proskuryakov.
3123
3124         * WebKitTestRunner/TestController.cpp:
3125         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
3126         as an intermediate in code that ultimately constructs a WTF::String.
3127         (WTR::userMediaOriginHash): Use makeString.
3128         (WTR::TestController::didNavigateWithNavigationData): More of the same.
3129         (WTR::TestController::didPerformClientRedirect): Ditto.
3130         (WTR::TestController::didPerformServerRedirect): Ditto.
3131         (WTR::TestController::didUpdateHistoryTitle): Ditto.
3132
3133 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
3134
3135         [ews-build] Add unit test to verify builder keys
3136         https://bugs.webkit.org/show_bug.cgi?id=194152
3137
3138         Reviewed by Lucas Forschler.
3139
3140         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3141         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
3142
3143 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3144
3145         [LFC] Expand tests coverage (12 new tests -> 787)
3146
3147         Unreviewed test gardening.
3148
3149         * LayoutReloaded/misc/LFC-passing-tests.txt:
3150
3151 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3152
3153         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
3154         https://bugs.webkit.org/show_bug.cgi?id=194163
3155
3156         Reviewed by Simon Fraser.
3157
3158         775
3159
3160         * LayoutReloaded/misc/LFC-passing-tests.txt:
3161
3162 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
3163
3164         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
3165         https://bugs.webkit.org/show_bug.cgi?id=194140
3166         <rdar://problem/47728098>
3167
3168         Reviewed by Tim Horton.
3169
3170         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3171         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3172         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
3173
3174         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
3175         test to induce an IPC deadlock when presenting a modal alert during touch start.
3176
3177         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3178         * WebKitTestRunner/TestController.cpp:
3179         (WTR::runJavaScriptAlert):
3180
3181         Add a client callback function for running JavaScript alerts.
3182
3183         (WTR::TestController::createOtherPage):
3184         (WTR::TestController::generateContextConfiguration const):
3185
3186         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
3187         the fix in this patch.
3188
3189         (WTR::TestController::createWebViewWithOptions):
3190
3191         Plumb TestOptions to generateContextConfiguration.
3192
3193         (WTR::TestController::resetPreferencesToConsistentValues):
3194         (WTR::TestController::resetStateToConsistentValues):
3195         (WTR::updateTestOptionsFromTestHeader):
3196         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
3197         (WTR::TestController::handleJavaScriptAlert):
3198         * WebKitTestRunner/TestController.h:
3199         * WebKitTestRunner/TestInvocation.cpp:
3200         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3201         * WebKitTestRunner/TestOptions.h:
3202         (WTR::TestOptions::hasSameInitializationOptions const):
3203
3204 2019-02-01  Chris Dumez  <cdumez@apple.com>
3205
3206         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
3207         https://bugs.webkit.org/show_bug.cgi?id=193740
3208         <rdar://problem/47527267>
3209
3210         Reviewed by Alex Christensen.
3211
3212         Add API test coverage.
3213
3214         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3215
3216 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
3217
3218         [ews-app] Add display name field to BuilderMapping model
3219         https://bugs.webkit.org/show_bug.cgi?id=194153
3220
3221         Reviewed by Lucas Forschler.
3222
3223         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3224         (BuilderMapping):
3225
3226 2019-02-01  Youenn Fablet  <youenn@apple.com>
3227
3228         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
3229         https://bugs.webkit.org/show_bug.cgi?id=194155
3230
3231         Reviewed by Eric Carlson.
3232
3233         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
3234         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
3235         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
3236
3237 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3238
3239         [LFC] Adjust replaced element's intrinsic ratio
3240         https://bugs.webkit.org/show_bug.cgi?id=194154
3241
3242         Reviewed by Antti Koivisto.
3243
3244         761
3245
3246         * LayoutReloaded/misc/LFC-passing-tests.txt:
3247
3248 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3249
3250         [WPE] Show test results in minibrowser
3251         https://bugs.webkit.org/show_bug.cgi?id=194150
3252
3253         Reviewed by Žan Doberšek.
3254
3255         * Scripts/webkitpy/port/wpe.py:
3256         (WPEPort.show_results_html_file):
3257
3258 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3259
3260         [WPE] MiniBrowser: add ky bindings for back/forward navigation
3261         https://bugs.webkit.org/show_bug.cgi?id=194151
3262
3263         Reviewed by Žan Doberšek.
3264
3265         ALT + <- go back
3266         ALT + -> go forward
3267
3268         * MiniBrowser/wpe/main.cpp:
3269         (main):
3270
3271 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3272
3273         [LFC] Set intrinsic size on Layout::Replaced
3274         https://bugs.webkit.org/show_bug.cgi?id=194139
3275
3276         Reviewed by Antti Koivisto.
3277
3278         744
3279
3280         * LayoutReloaded/misc/LFC-passing-tests.txt:
3281
3282 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3283
3284         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
3285         https://bugs.webkit.org/show_bug.cgi?id=194146
3286
3287         Reviewed by Xabier Rodriguez-Calvar.
3288
3289         It allows to open relative paths.
3290
3291         * MiniBrowser/wpe/main.cpp:
3292         (main):
3293
3294 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
3295
3296         Update flakiness dashboard configuration after recent queue changes
3297         https://bugs.webkit.org/show_bug.cgi?id=194127
3298
3299         Rubber-stamped by Aakash Jain.
3300
3301         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
3302
3303         * TestResultServer/static-dashboards/builders.jsonp:
3304
3305 2019-01-31  Youenn Fablet  <youenn@apple.com>
3306
3307         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
3308         https://bugs.webkit.org/show_bug.cgi?id=194106
3309         <rdar://problem/47676333>
3310
3311         Reviewed by Ryosuke Niwa.
3312
3313         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3314         (TestWebKitAPI::didFinishNavigation):
3315         (TestWebKitAPI::TEST):
3316         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
3317
3318 2019-01-31  Chris Dumez  <cdumez@apple.com>
3319
3320         Page zoom level is lost after a process swap or a crash
3321         https://bugs.webkit.org/show_bug.cgi?id=194105
3322         <rdar://problem/47610781>
3323
3324         Reviewed by Alex Christensen.
3325
3326         Add API test coverage.
3327
3328         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3329         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
3330
3331 2019-01-31  Alex Christensen  <achristensen@webkit.org>
3332
3333         Revert r238819 which is unneeded and caused a performance regression.
3334         https://bugs.webkit.org/show_bug.cgi?id=192272
3335         <rdar://problem/46664625>
3336
3337         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
3338         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
3339         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
3340
3341 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
3342
3343         Formalize WebKitAdditions mechanism of LoadOptimizer
3344         https://bugs.webkit.org/show_bug.cgi?id=193886
3345         <rdar://problem/47696809>
3346
3347         Reviewed by Brent Fulgham.
3348
3349         * MiniBrowser/MiniBrowser.entitlements:
3350         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
3351
3352 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3353
3354         [LFC] Margin before/after/start/end initial value is 0 and not auto.
3355         https://bugs.webkit.org/show_bug.cgi?id=194090
3356
3357         Reviewed by Antti Koivisto.
3358
3359         * LayoutReloaded/misc/LFC-passing-tests.txt:
3360
3361 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3362
3363         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
3364         https://bugs.webkit.org/show_bug.cgi?id=194074
3365
3366         Reviewed by Antti Koivisto.
3367
3368         * LayoutReloaded/misc/LFC-passing-tests.txt:
3369
3370 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3371
3372         [LFC][BFC] Add support for block level replaced box.
3373         https://bugs.webkit.org/show_bug.cgi?id=194071
3374
3375         Reviewed by Antti Koivisto.
3376
3377         * LayoutReloaded/misc/LFC-passing-tests.txt:
3378
3379 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
3380
3381         Fix WebKitTestRunner's testPath with Windows full paths
3382         https://bugs.webkit.org/show_bug.cgi?id=194012
3383
3384         Reviewed by Alex Christensen.
3385
3386         updateTestOptionsFromTestHeader failed to open test files because
3387         testPath returned wrong file paths. It returned a path "/C:/..."
3388         if a URL "file:///C:/..." was given.
3389
3390         * WebKitTestRunner/TestController.cpp:
3391         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
3392
3393 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3394
3395         [WPE] Bump font related dependencies to match the GTK+ port
3396         https://bugs.webkit.org/show_bug.cgi?id=194017
3397
3398         Reviewed by Žan Doberšek.
3399
3400         * wpe/jhbuild.modules:
3401         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3402         * wpe/patches/icudata-stdlibs.patch: Added.
3403
3404 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
3405
3406         Enable swipe tests on iOS
3407         https://bugs.webkit.org/show_bug.cgi?id=194076
3408
3409         Reviewed by Geoffrey Garen.
3410
3411         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
3412         it causes a debug assertion failure in runUIScript.
3413
3414         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3415         (WTR::UIScriptController::beginBackSwipe):
3416         (WTR::UIScriptController::completeBackSwipe):
3417
3418 2019-01-30  Keith Rollin  <krollin@apple.com>
3419
3420         Use correct printf format specifier
3421         https://bugs.webkit.org/show_bug.cgi?id=194062
3422         <rdar://problem/47686167>
3423
3424         Reviewed by Alexey Proskuryakov.
3425
3426         LayoutTestSpellChecker.mm is trying to format a variable of type
3427         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
3428         actually an unsigned long long. Fix this by formatting with %llu.
3429
3430         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
3431         (-[LayoutTestTextCheckingResult description]):
3432
3433 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
3434
3435         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
3436         https://bugs.webkit.org/show_bug.cgi?id=193979
3437
3438         Reviewed by Wenson Hsieh.
3439
3440         Fix the test for iOS. Make the test work with iOS UA string.
3441
3442         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3443
3444 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
3445
3446         Replace High Sierra LLINT CLoop bot due to hardware failure
3447         https://bugs.webkit.org/show_bug.cgi?id=194066
3448
3449         Reviewed by Aakash Jain.
3450
3451         * BuildSlaveSupport/build.webkit.org-config/config.json:
3452
3453 2019-01-30  Keith Rollin  <krollin@apple.com>
3454
3455         [NSDragItem init] is unavailable
3456         https://bugs.webkit.org/show_bug.cgi?id=194059
3457         <rdar://problem/47685715>
3458
3459         Reviewed by Wenson Hsieh.
3460
3461         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
3462         DumpRenderTree and TestWebKitAPI, which both try to create an
3463         NSDragItem in a manner that invokes this method. Address this by using
3464         -initWithPasteboardWriter instead.
3465
3466         Note that the parameter passed to initWithPasteboardWriter is likely
3467         incorrect. In both cases, the object passed does not conform to
3468         NSPasteboardWriting. However, with this fix, we're no worse off than
3469         before, and can now perform builds with newer compilers and SDKs until
3470         a real fix can be crafted. That work is tracked in
3471         https://bugs.webkit.org/show_bug.cgi?id=194060
3472
3473         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3474         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
3475         * TestWebKitAPI/mac/TestDraggingInfo.mm:
3476         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
3477
3478 2019-01-30  Daniel Bates  <dabates@apple.com>
3479
3480         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
3481         https://bugs.webkit.org/show_bug.cgi?id=192824
3482         <rdar://problem/47100332>
3483
3484         Reviewed by Wenson Hsieh.
3485
3486         Fix a bug where the wrong usage code was used for F13 thru F24.
3487
3488         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3489         (keyCodeForDOMFunctionKey):
3490
3491 2019-01-30  Chris Dumez  <cdumez@apple.com>
3492
3493         Regression(PSON) Load hang can occur on history navigation
3494         https://bugs.webkit.org/show_bug.cgi?id=194030
3495         <rdar://problem/47656939>
3496
3497         Reviewed by Antti Koivisto.
3498
3499         Add API test coverage.
3500
3501         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3502
3503 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3504
3505         [LFC] Expand tests coverage.
3506
3507         Unreviewed test gardening.
3508
3509         * LayoutReloaded/misc/LFC-passing-tests.txt:
3510
3511 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
3512
3513         [Flatpak] Add openjpeg support
3514         https://bugs.webkit.org/show_bug.cgi?id=194019
3515
3516         Reviewed by Michael Catanzaro.
3517
3518         * flatpak/org.webkit.CommonModules.yaml:
3519
3520 2019-01-30  Commit Queue  <commit-queue@webkit.org>
3521
3522         Unreviewed, rolling out r240708.
3523         https://bugs.webkit.org/show_bug.cgi?id=194022
3524
3525         It broke WPE build (Requested by KaL on #webkit).
3526
3527         Reverted changeset:
3528
3529         "[WPE] Bump font related dependencies to match the GTK+ port"
3530         https://bugs.webkit.org/show_bug.cgi?id=194017
3531         https://trac.webkit.org/changeset/240708
3532
3533 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3534
3535         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
3536         https://bugs.webkit.org/show_bug.cgi?id=194001
3537
3538         Reviewed by Antti Koivisto.
3539
3540         * LayoutReloaded/misc/LFC-passing-tests.txt:
3541
3542 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3543
3544         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
3545         https://bugs.webkit.org/show_bug.cgi?id=194020
3546
3547         Reviewed by Antti Koivisto.
3548
3549         * LayoutReloaded/misc/LFC-passing-tests.txt:
3550
3551 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
3552
3553         AX: Support color well on iOS
3554         https://bugs.webkit.org/show_bug.cgi?id=194010
3555
3556         Reviewed by Joanmarie Diggs.
3557
3558         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3559         (WTR::AccessibilityUIElement::stringAttributeValue):
3560
3561 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
3562
3563         [WPE] Bump font related dependencies to match the GTK+ port
3564         https://bugs.webkit.org/show_bug.cgi?id=194017
3565
3566         Reviewed by Žan Doberšek.
3567
3568         * wpe/jhbuild.modules:
3569         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3570         * wpe/patches/icudata-stdlibs.patch: Added.
3571
3572 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
3573
3574         [Mac] Update window scale API usage
3575         https://bugs.webkit.org/show_bug.cgi?id=193991
3576         rdar://problem/47614795
3577
3578         Reviewed by Tim Horton.
3579
3580         * DumpRenderTree/mac/DumpRenderTree.mm:
3581         (changeWindowScaleIfNeeded):
3582         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3583         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3584         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
3585
3586 2019-01-29  Chris Dumez  <cdumez@apple.com>
3587
3588         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
3589         https://bugs.webkit.org/show_bug.cgi?id=193977
3590         <rdar://problem/47643716>
3591
3592         Reviewed by Geoff Garen.
3593
3594         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
3595         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
3596         to the previous provisional committing *before* we make the last load. 
3597
3598         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3599
3600 2019-01-29  Youenn Fablet  <youenn@apple.com>
3601
3602         Adopt new SPI to evaluate server certificate trust
3603         https://bugs.webkit.org/show_bug.cgi?id=193355
3604
3605         Reviewed by Alex Christensen.
3606
3607         Add infrastructure to handle HTTPS server trust evaluation testing.
3608
3609         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3610         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3611         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
3612         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
3613         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
3614         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3615         * WebKitTestRunner/TestController.cpp:
3616         (WTR::TestController::resetPreferencesToConsistentValues):
3617         (WTR::TestController::didReceiveAuthenticationChallenge):
3618         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
3619         * WebKitTestRunner/TestController.h:
3620         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
3621         * WebKitTestRunner/TestInvocation.cpp:
3622         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3623         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3624         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
3625
3626 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3627
3628         [ews-build] Add build step to print bot Configuration
3629         https://bugs.webkit.org/show_bug.cgi?id=193887
3630
3631         Reviewed by Lucas Forschler.
3632
3633         * BuildSlaveSupport/ews-build/steps.py:
3634         (PrintConfiguration): Build step to print configuration.
3635         * BuildSlaveSupport/ews-build/factories.py:
3636
3637 2019-01-29  Chris Dumez  <cdumez@apple.com>
3638
3639         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
3640         https://bugs.webkit.org/show_bug.cgi?id=193967
3641         <rdar://problem/47635348>
3642
3643         Reviewed by Alex Christensen.
3644
3645         Add API test coverage.
3646
3647         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3648         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
3649
3650 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3651
3652         [ews-app] Handle incoming results data
3653         https://bugs.webkit.org/show_bug.cgi?id=193973
3654
3655         Reviewed by Lucas Forschler.
3656
3657         * BuildSlaveSupport/ews-app/ews/views/results.py:
3658
3659 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3660
3661         [ews-app] Make the results url generic
3662         https://bugs.webkit.org/show_bug.cgi?id=193928
3663
3664         Reviewed by Lucas Forschler.
3665
3666         * BuildSlaveSupport/ews-app/ews/urls.py:
3667
3668 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3669
3670         [ews-build] Configure buildbot to send events to ews-app
3671         https://bugs.webkit.org/show_bug.cgi?id=193968
3672
3673         Reviewed by Lucas Forschler.
3674
3675         * BuildSlaveSupport/ews-build/events.py: Added.
3676         * BuildSlaveSupport/ews-build/master.cfg:
3677
3678 2019-01-29  Keith Rollin  <krollin@apple.com>
3679
3680         Add .xcfilelists to Run Script build phases
3681         https://bugs.webkit.org/show_bug.cgi?id=193792
3682         <rdar://problem/47201785>
3683
3684         Reviewed by Alex Christensen.
3685
3686         As part of supporting XCBuild, update the necessary Run Script build
3687         phases in their Xcode projects to refer to their associated
3688         .xcfilelist files.
3689
3690         Note that the addition of these files bumps the Xcode project version
3691         number to something that's Xcode 10 compatible. This change means that
3692         older versions of the Xcode IDE can't read these projects. Nor can it
3693         fully load workspaces that refer to these projects (the updated
3694         projects are shown as non-expandable placeholders). `xcodebuild` can
3695         still build these projects; it's just that the IDE can't open them.
3696
3697         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3698         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3699
3700 2019-01-29  John Wilander  <wilander@apple.com>
3701
3702         Add data abstraction and validation for Ad Click Attribution
3703         https://bugs.webkit.org/show_bug.cgi?id=193916
3704         <rdar://problem/47603481>
3705
3706         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
3707
3708         Ad click attribution has two steps. First, the storage of an ad
3709         campaign ID for a click that takes the user to a destination
3710         site. Second, a conversion on the destination site that can be
3711         attributed to the ad click.
3712