383a63121cb0fe34973477c905f7c0a8ee3b64d9
[WebKit-https.git] / Tools / ChangeLog
1 2019-03-22  Chris Dumez  <cdumez@apple.com>
2
3         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
4         https://bugs.webkit.org/show_bug.cgi?id=195348
5         <rdar://problem/48622090>
6
7         Reviewed by Alex Christensen.
8
9         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
10         to NO when test.options().shouldIgnoreMetaViewport is false.
11
12         * WebKitTestRunner/ios/TestControllerIOS.mm:
13         (WTR::TestController::platformConfigureViewForTest):
14
15 2019-03-22  Chris Dumez  <cdumez@apple.com>
16
17         Prewarmed processes should be usable with any website data store
18         https://bugs.webkit.org/show_bug.cgi?id=196104
19
20         Reviewed by Alex Christensen.
21
22         Add API test coverage.
23
24         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
25         (runInitialWarmedProcessUsedTest):
26         (TEST):
27
28 2019-03-22  David Kilzer  <ddkilzer@apple.com>
29
30         Back out local changes to Alex's Subversion working directory
31
32         They were accidentally committed.
33
34         * Scripts/webkitpy/common/system/abstractexecutive.py:
35         (AbstractExecutive.wait_newest):
36         * Scripts/webkitpy/common/system/executive.py:
37         (Executive.running_pids):
38         * Scripts/webkitpy/common/system/executive_mock.py:
39         (MockExecutive.running_pids):
40         * Scripts/webkitpy/common/system/executive_unittest.py:
41         (ExecutiveTest.serial_test_running_pids):
42         * Scripts/webkitpy/port/darwin.py:
43         (DarwinPort.check_for_leaks):
44         * Scripts/webkitpy/port/leakdetector.py:
45         (LeakDetector.check_for_leaks):
46         - This was the hack attached to Bug 193772.
47
48         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
49         (+[WebKitTestRunnerEvent mouseLocation]):
50         - This works around a crash on an internal build.
51
52 2019-03-22  Tim Horton  <timothy_horton@apple.com>
53
54         Fix the build after r243354
55         https://bugs.webkit.org/show_bug.cgi?id=196138
56         <rdar://problem/49145951>
57
58         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
59         (TEST):
60         * TestWebKitAPI/ios/UIKitSPI.h:
61
62 2019-03-21  Tim Horton  <timothy_horton@apple.com>
63
64         Adopt UIWKDocumentContext
65         https://bugs.webkit.org/show_bug.cgi?id=196040
66         <rdar://problem/48642440>
67
68         Reviewed by Ryosuke Niwa.
69
70         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
71         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
72         (makeRequest):
73         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
74         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
75         (applyStyle):
76         (TEST):
77         Add tests for UIWKDocumentContext.
78
79         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
80         (TEST):
81         (recursiveFindWKContentView): Deleted.
82         * TestWebKitAPI/cocoa/TestWKWebView.h:
83         * TestWebKitAPI/cocoa/TestWKWebView.mm:
84         (recursiveFindWKContentView):
85         (-[TestWKWebView wkContentView]):
86         * TestWebKitAPI/ios/UIKitSPI.h:
87         Share the WKContentView finding code between tests.
88
89 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
90
91         [iOS WK2] Turn on async overflow scrolling by default
92         https://bugs.webkit.org/show_bug.cgi?id=196011
93         rdar://problem/48453859
94
95         Reviewed by Antti Koivisto.
96         
97         Explicitly turn off the async overflow scrolling internal feature for tests by default,
98         since so many basic layout tests have different results when compositing is triggered for
99         overflow.
100         
101         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
102
103         * WebKitTestRunner/TestController.cpp:
104         (WTR::TestController::resetPreferencesToConsistentValues):
105
106 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
107
108         [ews-build] Retry API test in case of failures
109         https://bugs.webkit.org/show_bug.cgi?id=196004
110
111         Reviewed by Lucas Forschler.
112
113         * BuildSlaveSupport/ews-build/steps.py:
114         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
115         (CompileWebKitToT.doStepIf): Ditto.
116         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
117         (ReRunAPITests): Re-run API tests.
118         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
119         (RunAPITestsWithoutPatch): Run API tests without patch.
120         (RunAPITestsWithoutPatch.doStepIf):
121         (RunAPITestsWithoutPatch.hideStepIf):
122         (RunAPITestsWithoutPatch.evaluateCommand):
123         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
124         (AnalyzeAPITestsResults.start):
125         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
126         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
127         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
128         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
129
130 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
131
132         [ews-build] Update queues configurations
133         https://bugs.webkit.org/show_bug.cgi?id=196074
134
135         Reviewed by Dewei Zhu.
136
137         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
138         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
139
140 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
141
142         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
143         https://bugs.webkit.org/show_bug.cgi?id=195680
144         <rdar://problem/48903534>
145
146         Unreviewed infrastructure fix.
147
148         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
149         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
150
151 2019-03-21  Andy Estes  <aestes@apple.com>
152
153         [iOS] Apple Pay should be available in documents with no user agent scripts
154         https://bugs.webkit.org/show_bug.cgi?id=196061
155         <rdar://problem/48649391>
156
157         Reviewed by Brady Eidson.
158
159         Added API tests and related infrastructure.
160
161         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
162         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
163         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
164         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
165         (TestWebKitAPI::TEST):
166         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
167         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
168         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
169         * TestWebKitAPI/cocoa/TestProtocol.mm:
170         (-[TestProtocol startLoading]):
171         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
172         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
173         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
174         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
175
176 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
177
178         REGRESSSION (r243297): webkitpy tests broken
179         https://bugs.webkit.org/show_bug.cgi?id=196108
180
181         Reviewed by Aakash Jain.
182
183         r243297 updated contributors.json, which broke a few unit tests.
184
185         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
186         (IRCCommandTest.test_whois):
187         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
188
189 2019-03-21  Chris Dumez  <cdumez@apple.com>
190
191         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
192         https://bugs.webkit.org/show_bug.cgi?id=196041
193         <rdar://problem/49083230>
194
195         Reviewed by Alex Christensen.
196
197         Add API test coverage.
198
199         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
200         (TEST):
201
202 2019-03-21  Alex Christensen  <achristensen@webkit.org>
203
204         Add SPI to inform applications of WKContentRuleList actions
205         https://bugs.webkit.org/show_bug.cgi?id=195965
206         <rdar://problem/42664365>
207
208         Reviewed by Geoff Garen.
209
210         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
211         (TestWebKitAPI::allActionsForResourceLoad):
212         (TestWebKitAPI::testRequest):
213         (TestWebKitAPI::TEST_F):
214         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
215         (Notification::description):
216         (Notification::operator== const):
217         (toVector):
218         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
219         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
220         (makeContentRuleList):
221         (TEST):
222         (makeWarnContentRuleList): Deleted.
223
224 2019-03-21  Timothy Hatcher  <timothy@apple.com>
225
226         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
227         https://bugs.webkit.org/show_bug.cgi?id=196088
228
229         Reviewed by Brian Burg.
230
231         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
232         Support checks when only one platform is specified. Also deprecate macosx() and
233         force the use of macos() instead.
234
235         * Scripts/webkitpy/style/checkers/cpp.py:
236         (check_min_versions_of_wk_api_available):
237         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
238         (WebKitStyleTest.test_min_versions_of_wk_api_available):
239
240 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
241
242         Update status inactive committers' status to 'contributor'.
243
244         * Scripts/webkitpy/common/config/contributors.json:
245
246 2019-03-21  Xan Lopez  <xan@igalia.com>
247
248         [JSC][x86] Drop support for x87 floating point
249         https://bugs.webkit.org/show_bug.cgi?id=194853
250
251         Reviewed by Don Olmstead.
252
253         Force SSE2 on x86/32bit builds.
254
255         * Scripts/webkitdirs.pm:
256         (generateBuildSystemFromCMakeProject):
257
258 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
259
260         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
261         https://bugs.webkit.org/show_bug.cgi?id=196073
262
263         Reviewed by Michael Catanzaro.
264
265         Add test cases to check functions and constructors with no arguments but receiving user data.
266
267         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
268         (checkUserData):
269         (testJSCFunction):
270         (fooCreateWithUserData):
271         (testJSCClass):
272
273 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
274
275         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
276
277         Add g_assert_cmpfloat_with_epsilon macro if not defined.
278
279         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
280
281 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
282
283         [GTK][WPE] Add API to provide geolocation information
284         https://bugs.webkit.org/show_bug.cgi?id=195940
285
286         Reviewed by Michael Catanzaro.
287
288         Add a new test to check the new API.
289
290         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
291         (testGeolocationManagerCurrentPosition):
292         (testGeolocationManagerWatchPosition):
293         (beforeAll):
294         (afterAll):
295         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
296         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
297         (beforeAll): Ditto.
298         * TestWebKitAPI/glib/CMakeLists.txt:
299
300 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
301
302         [GLib] Returning G_TYPE_OBJECT from a method does not work
303         https://bugs.webkit.org/show_bug.cgi?id=195574
304
305         Reviewed by Michael Catanzaro.
306
307         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
308
309         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
310         (getGFile):
311         (getParent):
312         (createGString):
313         (getGString):
314         (getGStringCopyWillRaise):
315         (getGStringCopy):
316         (getGStringStr):
317         (getGStringLen):
318         (freeGString):
319         (testJSCClass):
320
321 2019-03-20  Saam Barati  <sbarati@apple.com>
322
323         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
324         https://bugs.webkit.org/show_bug.cgi?id=195721
325
326         Reviewed by Filip Pizlo.
327
328         * Scripts/run-javascriptcore-tests:
329
330 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
331
332         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
333         https://bugs.webkit.org/show_bug.cgi?id=196049
334
335         Reviewed by Tim Horton.
336
337         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
338         overflow scrolling in general, so rename it.
339
340         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
341
342 2019-03-20  Daniel Bates  <dabates@apple.com>
343
344         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
345         https://bugs.webkit.org/show_bug.cgi?id=196031
346         <rdar://problem/49078172>
347
348         Reviewed by Tim Horton.
349
350         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
351         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
352         same code path used when the Done button is pressed to dismiss the <select> picker.
353
354         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
355         (TestWebKitAPI::TEST):
356
357 2019-03-20  Chris Dumez  <cdumez@apple.com>
358
359         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
360         https://bugs.webkit.org/show_bug.cgi?id=196029
361         <rdar://problem/48954651>
362
363         Reviewed by Tim Horton.
364
365         Add API test coverage.
366
367         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
368
369 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
370
371         [ews-build] Improve failure summary string for ApplyPatch step
372         https://bugs.webkit.org/show_bug.cgi?id=195995
373
374         Reviewed by Alexey Proskuryakov.
375
376         * BuildSlaveSupport/ews-build/steps.py:
377         (ApplyPatch.getResultSummary): Override getResultSummary.
378
379 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
380
381         AX: Implement support for new meter ARIA role
382         https://bugs.webkit.org/show_bug.cgi?id=195966
383
384         Reviewed by Chris Fleizach.
385
386         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
387         to AXLevelIndicator.
388
389         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
390
391 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
392
393         [WebAuthN] Implement FIDO AppID extension
394         https://bugs.webkit.org/show_bug.cgi?id=143491
395         <rdar://problem/48298273>
396
397         Reviewed by Brent Fulgham.
398
399         Add a test that covers the new flag of convertToU2fSignCommand.
400
401         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
402         (TestWebKitAPI::TEST):
403         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
404         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
405         (TestWebKitAPI::TEST):
406
407 2019-03-19  Keith Rollin  <krollin@apple.com>
408
409         Add support for more platforms to generate-xcfilelists
410         https://bugs.webkit.org/show_bug.cgi?id=195977
411
412         Reviewed by Alexey Proskuryakov.
413
414         generate-xcfilelists incorrectly complains when involved with building
415         WebKit for iphonesimulator:
416
417             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
418             …
419             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
420
421         Address this by teaching generate-xcfilelists about more platforms.
422
423         * Scripts/generate-xcfilelists:
424
425 2019-03-19  John Wilander  <wilander@apple.com>
426
427         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
428         https://bugs.webkit.org/show_bug.cgi?id=195923
429         <rdar://problem/49001272>
430
431         Reviewed by Alex Christensen.
432
433         This patch does the following to the TestRunner:
434         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
435         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
436         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
437
438         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
439         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
440         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
441         * WebKitTestRunner/InjectedBundle/TestRunner.h:
442         * WebKitTestRunner/TestController.cpp:
443         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
444         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
445         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
446         * WebKitTestRunner/TestController.h:
447         * WebKitTestRunner/TestInvocation.cpp:
448         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
449
450 2019-03-19  Christopher Reid  <chris.reid@sony.com>
451
452         [CMake] Support more clang and gcc sanitizers
453         https://bugs.webkit.org/show_bug.cgi?id=195956
454
455         Reviewed by Michael Catanzaro.
456
457         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
458
459 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
460
461         [ews-build] Improve summary for PrintConfiguration step
462         https://bugs.webkit.org/show_bug.cgi?id=195945
463
464         Reviewed by Lucas Forschler.
465
466         * BuildSlaveSupport/ews-build/steps.py:
467         (PrintConfiguration.getResultSummary): Override getResultSummary.
468
469 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
470
471         [ews-build] Improve summary for CheckOutSource step
472         https://bugs.webkit.org/show_bug.cgi?id=195963
473
474         Reviewed by Lucas Forschler.
475
476         * BuildSlaveSupport/ews-build/steps.py:
477         (CheckOutSource.getResultSummary):
478
479 2019-03-19  Daniel Bates  <dabates@apple.com>
480
481         [iOS] Focus not preserved when switching between tabs
482         https://bugs.webkit.org/show_bug.cgi?id=195820
483         <rdar://problem/43614450>
484
485         Reviewed by Brent Fulgham.
486
487         Add tests to ensure that we restore focus when resigning and becoming first responder.
488
489         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
490         (TestWebKitAPI::TEST):
491
492 2019-03-19  Alex Christensen  <achristensen@webkit.org>
493
494         Make WTFLogChannelState and WTFLogLevel enum classes
495         https://bugs.webkit.org/show_bug.cgi?id=195904
496
497         Reviewed by Eric Carlson.
498
499         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
500         (TestWebKitAPI::TEST_F):
501
502 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
503
504         [GStreamer][EME] Backported mssdemux protection data crash fix
505         https://bugs.webkit.org/show_bug.cgi?id=195918
506
507         Reviewed by Philippe Normand.
508
509         * gstreamer/jhbuild.modules:
510         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
511
512 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
513
514         Unreviewed, rolling out r243132.
515
516         Broke GTK build
517
518         Reverted changeset:
519
520         "Make WTFLogChannelState and WTFLogLevel enum classes"
521         https://bugs.webkit.org/show_bug.cgi?id=195904
522         https://trac.webkit.org/changeset/243132
523
524 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
525
526         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
527
528         * Scripts/webkitdirs.pm:
529         (builtDylibPathForName): Adjust the shared library name that's changed
530         with the API version bump in r243073.
531
532 2019-03-18  Alex Christensen  <achristensen@webkit.org>
533
534         Make WTFLogChannelState and WTFLogLevel enum classes
535         https://bugs.webkit.org/show_bug.cgi?id=195904
536
537         Reviewed by Eric Carlson.
538
539         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
540         (TestWebKitAPI::TEST_F):
541
542 2019-03-18  Alex Christensen  <achristensen@webkit.org>
543
544         Disable flaky test added in r2431100
545         https://webkit.org/b/195785
546
547         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
548         (TestWebKitAPI::TEST):
549         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
550
551 2019-03-18  Timothy Hatcher  <timothy@apple.com>
552
553         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
554         https://bugs.webkit.org/show_bug.cgi?id=195916
555
556         Reviewed by Tim Horton.
557
558         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
559         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
560
561 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
562
563         Add a secondary e-mail address for Fujii Hironori to make tools happier.
564
565         * Scripts/webkitpy/common/config/contributors.json:
566
567 2019-03-18  Alex Christensen  <achristensen@webkit.org>
568
569         Implement DownloadMonitor to prevent long-running slow downloads from background apps
570         https://bugs.webkit.org/show_bug.cgi?id=195785
571
572         Reviewed by Geoffrey Garen.
573
574         * TestWebKitAPI/TCPServer.cpp: Added.
575         (TestWebKitAPI::TCPServer::TCPServer):
576         (TestWebKitAPI::TCPServer::~TCPServer):
577         (TestWebKitAPI::TCPServer::socketBindListen):
578         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
579         * TestWebKitAPI/TCPServer.h: Added.
580         (TestWebKitAPI::TCPServer::port const):
581         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
582         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
583         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
584         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
585         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
586         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
587         (TestWebKitAPI::respondSlowly):
588         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
589         (TestWebKitAPI::downloadAtRate):
590         (TestWebKitAPI::TEST):
591
592 2019-03-18  Saam Barati  <sbarati@apple.com>
593
594         Add a plan file for JetStream 2
595         https://bugs.webkit.org/show_bug.cgi?id=190734
596
597         Reviewed by Mark Lam.
598
599         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
600
601 2019-03-18  Chris Dumez  <cdumez@apple.com>
602
603         Delay WebProcess launch until a load is triggered in a Web view
604         https://bugs.webkit.org/show_bug.cgi?id=195758
605         <rdar://problem/48126013>
606
607         Reviewed by Geoff Garen.
608
609         Add API test coverage. Also update some existing API tests to not expect
610         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
611
612         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
613         (TestWebKitAPI::TEST):
614         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
615         (TestWebKitAPI::TEST):
616         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
617         (TEST):
618         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
619         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
620         (TEST):
621         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
622         (TEST):
623         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
624
625 2019-03-18  Xan Lopez  <xan@igalia.com>
626
627         [CMake] Prevent potential warning when determining $architecture
628         https://bugs.webkit.org/show_bug.cgi?id=195891
629
630         Reviewed by Michael Catanzaro.
631
632         It's possible for generateBuildSystemForCMakeProject to be called
633         before determineArchitecture() is ever called. This will make the
634         first eq check with $architecture to be bogus (and print a
635         warning). Change that to an eq check with architecture(), which
636         implicitly calls determineArchitecture() if needed, and change all
637         the other similar cases in the method in the same way to prevent
638         future bugs like this one.
639
640         * Scripts/webkitdirs.pm:
641         (generateBuildSystemFromCMakeProject):
642
643 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
644
645         [WPE] Tarballs generated with “make dist” cannot build documentation
646         https://bugs.webkit.org/show_bug.cgi?id=195885
647
648         Reviewed by Carlos Garcia Campos.
649
650         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
651
652 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
653
654         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
655         https://bugs.webkit.org/show_bug.cgi?id=195883
656
657         Reviewed by Carlos Garcia Campos.
658
659         * gtkdoc/gtkdoc.py:
660         (GTKDoc._run_command): When commands fail to run, include the full command line for
661         the program invocation and the output it has generated on the standard error stream.
662
663 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
664
665         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
666         https://bugs.webkit.org/show_bug.cgi?id=195786
667
668         Reviewed by Philippe Normand.
669
670         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
671         * wpe/jhbuild.modules: Ditto.
672
673 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
674
675         [ews-build] Don't run clean builds on EWS builders
676         https://bugs.webkit.org/show_bug.cgi?id=195851
677
678         Reviewed by Geoffrey Garen.
679
680         * BuildSlaveSupport/ews-build/factories.py:
681
682 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
683
684         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
685         https://bugs.webkit.org/show_bug.cgi?id=195849
686
687         Reviewed by Chris Dumez.
688
689         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
690
691         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
692         (runWebsiteDataStoreCustomPaths):
693
694 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
695
696         webkitpy: Upload test results
697         https://bugs.webkit.org/show_bug.cgi?id=195755
698         <rdar://problem/48896182>
699
700         Reviewed by Aakash Jain.
701
702         Establish a new format for uploading results that is not tied to layout tests, apply
703         that format to webkitpy tests.
704
705         * Scripts/webkitpy/common/checkout/scm/git.py:
706         (Git.native_branch): Return what branch the current checkout is on.
707         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
708         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
709         * Scripts/webkitpy/common/checkout/scm/svn.py:
710         (SVN.native_branch): Ditto.
711         * Scripts/webkitpy/common/system/platforminfo.py:
712         (PlatformInfo.build_version): Return a build version for Mac.
713         * Scripts/webkitpy/common/system/platforminfo_mock.py:
714         (MockPlatformInfo.__init__):
715         (MockPlatformInfo.build_version):
716         * Scripts/webkitpy/results: Added.
717         * Scripts/webkitpy/results/__init__.py: Added.
718         * Scripts/webkitpy/results/options.py: Added.
719         (upload_options): OptParse list for upload options.
720         * Scripts/webkitpy/results/upload.py: Added.
721         (Upload): Class which enforces the upload format expected by the results server.
722         (Upload.Expectations):
723         (Upload.create_configuration):
724         (Upload.create_commit):
725         (Upload.create_details):
726         (Upload.create_run_stats):
727         (Upload.create_test_result):
728         (Upload.__init__):
729         (Upload.Encoder): Encode Upload object as json.
730         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
731         * Scripts/webkitpy/results/upload_unittest.py: Added.
732         * Scripts/webkitpy/test/main.py:
733         (Tester._parse_args): Add upload arguments.
734         (Tester._run_tests): Allow results to be uploaded.
735         * Scripts/webkitpy/test/runner.py:
736         (Runner.__init__): Record which tests were run, rather than just counting them.
737         (Runner.handle):
738         * Scripts/webkitpy/test/runner_unittest.py:
739         (RunnerTest.test_run):
740         * Scripts/webkitpy/thirdparty/__init__.py:
741         (AutoinstallImportHook.find_module): Add requests auto-install.
742         (AutoinstallImportHook._install_requests):
743         * Scripts/webkitpy/tool/commands/queues_unittest.py:
744         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
745
746 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
747
748         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
749         https://bugs.webkit.org/show_bug.cgi?id=195810
750
751         Reviewed by Tim Horton.
752
753         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
754         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
755         ending certain layout tests.
756
757         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
758         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
759         (-[TestRunnerWKWebView dealloc]):
760         (-[TestRunnerWKWebView resetInteractionCallbacks]):
761
762         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
763         helper method when destroying the web view, and when resetting state between tests.
764
765         * WebKitTestRunner/ios/TestControllerIOS.mm:
766         (WTR::TestController::platformResetStateToConsistentValues):
767
768         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
769
770 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
771
772         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
773         https://bugs.webkit.org/show_bug.cgi?id=190350
774         <rdar://problem/45089503>
775
776         Reviewed by Geoffrey Garen.
777
778         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
779         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
780         (TEST):
781         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
782         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
783         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
784         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
785         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
786         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
787         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
788         (runTest):
789         (createDirectories):
790         (TEST):
791         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
792         (TEST):
793         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
794         (TEST):
795
796 2019-03-15  Timothy Hatcher  <timothy@apple.com>
797
798         Add support to WebPage for getting the contents as an attributed string.
799         https://bugs.webkit.org/show_bug.cgi?id=195636
800         rdar://problem/45055697
801
802         Reviewed by Tim Horton.
803
804         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
805         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
806
807 2019-03-15  Chris Dumez  <cdumez@apple.com>
808
809         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
810         https://bugs.webkit.org/show_bug.cgi?id=195747
811
812         Reviewed by Geoff Garen.
813
814         Add API test coverage.
815
816         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
817
818 2019-03-15  Shawn Roberts  <sroberts@apple.com>
819
820         Unreviewed, rolling out r242952.
821
822         Causing API failures on iOS Simulator
823
824         Reverted changeset:
825
826         "[PSON] Make sure the WebProcessCache is leverage when
827         relaunching a process after termination"
828         https://bugs.webkit.org/show_bug.cgi?id=195747
829         https://trac.webkit.org/changeset/242952
830
831 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
832
833         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
834         https://bugs.webkit.org/show_bug.cgi?id=195740
835
836         Reviewed by Ross Kirsling.
837
838         window.open doesn't work for WebKitBrowserWindow because it is not
839         implemented yet.
840
841         1. Implemented createNewPage callback of WKPageUIClient.
842         2. Changed MainWindow to take a BrowserWindow factory function
843           instead of BrowserWindowType to be flexible to create
844           BrowserWindow with extra settings.
845         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
846           because it is not relevant with MainWindow anymore.
847
848         * MiniBrowser/win/Common.cpp:
849         (parseCommandLine):
850         * MiniBrowser/win/Common.h:
851         (CommandLineOptions::CommandLineOptions):
852         * MiniBrowser/win/MainWindow.cpp:
853         (MainWindow::MainWindow):
854         (MainWindow::create):
855         (MainWindow::init):
856         (MainWindow::WndProc):
857         * MiniBrowser/win/MainWindow.h:
858         * MiniBrowser/win/PrintWebUIDelegate.cpp:
859         (PrintWebUIDelegate::createWebViewWithRequest):
860         * MiniBrowser/win/WebKitBrowserWindow.cpp:
861         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
862         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
863         (WebKitBrowserWindow::updateProxySettings):
864         (WebKitBrowserWindow::createNewPage):
865         * MiniBrowser/win/WebKitBrowserWindow.h:
866         * MiniBrowser/win/WinMain.cpp:
867         (wWinMain):
868
869 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
870
871         Make it possible to test scrolling tree layer manipulation more easily
872         https://bugs.webkit.org/show_bug.cgi?id=195780
873
874         Reviewed by Tim Horton.
875         
876         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
877         cuts off communication of scrolling tree scrolls back to the web process
878         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
879         allows tests to trigger scrolls which run the scrolling tree layer positioning
880         logic, but never get another commit from the web process that might mask
881         scrolling tree bugs.
882         
883         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
884         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
885         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
886
887         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
888         (WTR::UIScriptController::scrollUpdatesDisabled const):
889         (WTR::UIScriptController::setScrollUpdatesDisabled):
890         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
891         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
892         (WTR::UIScriptController::scrollUpdatesDisabled const):
893         (WTR::UIScriptController::setScrollUpdatesDisabled):
894         * TestRunnerShared/UIScriptContext/UIScriptController.h:
895         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
896         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
897         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
898         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
899         * WebKitTestRunner/ios/TestControllerIOS.mm:
900         (WTR::TestController::platformResetStateToConsistentValues):
901         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
902         (WTR::UIScriptController::scrollUpdatesDisabled const):
903         (WTR::UIScriptController::setScrollUpdatesDisabled):
904
905 2019-03-14  Youenn Fablet  <youenn@apple.com>
906
907         Move IDB storage in private browsing mode to NetworkProcess
908         https://bugs.webkit.org/show_bug.cgi?id=195602
909
910         Reviewed by Brady Eidson.
911
912         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
913         (TEST):
914
915 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
916
917         [ews-build] Make descriptionDone messages more readable
918         https://bugs.webkit.org/show_bug.cgi?id=195760
919
920         Reviewed by Lucas Forschler.
921
922         * BuildSlaveSupport/ews-build/steps.py:
923         * BuildSlaveSupport/ews-build/steps_unittest.py:
924
925 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
926
927         [ews-build] Generate status-bubble hover-over messages
928         https://bugs.webkit.org/show_bug.cgi?id=195680
929
930         Reviewed by Lucas Forschler.
931
932         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
933         (StatusBubble):
934         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
935         on hover-over.
936         (StatusBubble._iso_time):
937         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
938         hover-over message.
939         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
940
941 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
942
943         [ews-app] Gracefully handle the case when state_string is None
944         https://bugs.webkit.org/show_bug.cgi?id=195753
945
946         Reviewed by Lucas Forschler.
947
948         * BuildSlaveSupport/ews-app/ews/models/build.py:
949         * BuildSlaveSupport/ews-app/ews/models/step.py:
950
951 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
952
953         [ews-app] Status bubble display pending for currently running build step
954         https://bugs.webkit.org/show_bug.cgi?id=195744
955
956         Reviewed by Lucas Forschler.
957
958         * BuildSlaveSupport/ews-build/events.py:
959         (Events.stepStarted): If state_string is pending, replace it with step name.
960
961 2019-03-14  Chris Dumez  <cdumez@apple.com>
962
963         Add WebsitePolicy for the client to specify the device orientation & motion access policy
964         https://bugs.webkit.org/show_bug.cgi?id=195750
965
966         Reviewed by Geoffrey Garen.
967
968         Add API test coverage.
969
970         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
971         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
972         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
973         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
974
975 2019-03-14  Chris Dumez  <cdumez@apple.com>
976
977         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
978         https://bugs.webkit.org/show_bug.cgi?id=195747
979
980         Reviewed by Geoff Garen.
981
982         Add API test coverage.
983
984         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
985
986 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
987
988         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
989         https://bugs.webkit.org/show_bug.cgi?id=195725
990         <rdar://problem/48545062>
991
992         Reviewed by Tim Horton.
993
994         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
995         handler is nil.
996
997         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
998         (TestWebKitAPI::TEST):
999
1000 2019-03-13  Sam Weinig  <sam@webkit.org>
1001
1002         Add utility function to allow easy reverse range-based iteration of a container
1003         https://bugs.webkit.org/show_bug.cgi?id=195542
1004
1005         Reviewed by Antti Koivisto.
1006
1007         * TestWebKitAPI/CMakeLists.txt:
1008         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1009         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
1010         (TestWebKitAPI::TEST):
1011         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
1012
1013 2019-03-13  Chris Dumez  <cdumez@apple.com>
1014
1015         Use a ServiceWorker process per registrable domain
1016         https://bugs.webkit.org/show_bug.cgi?id=195649
1017
1018         Reviewed by Youenn Fablet.
1019
1020         Update API test coverage.
1021
1022         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1023
1024 2019-03-13  Chris Dumez  <cdumez@apple.com>
1025
1026         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
1027         https://bugs.webkit.org/show_bug.cgi?id=195684
1028         <rdar://problem/48294714>
1029
1030         Reviewed by Antti Koivisto.
1031
1032         Add API test coverage.
1033
1034         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1035
1036 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
1037
1038         [ews-app] Remove unused patch view
1039         https://bugs.webkit.org/show_bug.cgi?id=195669
1040
1041         Reviewed by Lucas Forschler.
1042
1043         * BuildSlaveSupport/ews-app/ews/urls.py:
1044         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
1045
1046 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
1047
1048         [ews-app] Use Buildbot result code variables
1049         https://bugs.webkit.org/show_bug.cgi?id=195668
1050
1051         Reviewed by Alexey Proskuryakov.
1052
1053         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
1054         (Buildbot): Added Buildbot result code variables.
1055         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1056         (StatusBubble._build_bubble): Used Buildbot result code variables.
1057
1058 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
1059
1060         [Flatpak] Expand submodule recursively
1061         https://bugs.webkit.org/show_bug.cgi?id=195672
1062
1063         Building WPE with flatpak was impossible without that as it was raising an exception.
1064         Also update wpebackend-fdo to match what is built in jhbuild
1065
1066         Reviewed by Philippe Normand.
1067
1068         * flatpak/flatpakutils.py:
1069         (expand_submodules_recurse):
1070         (expand_manifest):
1071         * flatpak/org.webkit.WPEModules.yaml:
1072
1073 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
1074
1075         [ews-app] status bubble should be hidden for certain builds
1076         https://bugs.webkit.org/show_bug.cgi?id=194597
1077
1078         Reviewed by Dewei Zhu.
1079
1080         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1081         (StatusBubble._build_bubble):
1082         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
1083         because the patch didn't have relevant changes.
1084         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
1085         in production yet.
1086
1087 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
1088
1089         [Win] Fix a slew of simple clang-cl warnings.
1090         https://bugs.webkit.org/show_bug.cgi?id=195652
1091
1092         Reviewed by Don Olmstead.
1093
1094         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1095         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
1096
1097 2019-03-12  Justin Fan  <justin_fan@apple.com>
1098
1099         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
1100         https://bugs.webkit.org/show_bug.cgi?id=195518
1101         <rdar://problem/46322356>
1102
1103         Reviewed by Myles C. Maxfield.
1104
1105         * DumpRenderTree/DerivedSources-input.xcfilelist:
1106         * DumpRenderTree/DerivedSources-output.xcfilelist:
1107
1108 2019-03-12  Commit Queue  <commit-queue@webkit.org>
1109
1110         Unreviewed, rolling out r242825.
1111         https://bugs.webkit.org/show_bug.cgi?id=195648
1112
1113         "Broke webkitpy tests with my change to
1114         lldb_dump_class_layout.py" (Requested by rmorisset on
1115         #webkit).
1116
1117         Reverted changeset:
1118
1119         "Alter Tools/Scripts/dump-class-layout to be able to dump all
1120         classes with suspicious padding"
1121         https://bugs.webkit.org/show_bug.cgi?id=195573
1122         https://trac.webkit.org/changeset/242825
1123
1124 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
1125
1126         [ews-build] Show status bubbles while the patch is waiting in queue
1127         https://bugs.webkit.org/show_bug.cgi?id=195618
1128
1129         Reviewed by Lucas Forschler.
1130
1131         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1132         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
1133         enabled in initial deployment.
1134         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
1135         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
1136         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
1137         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
1138         (StatusBubble._build_bubbles_for_patch):
1139
1140 2019-03-12  Robin Morisset  <rmorisset@apple.com>
1141
1142         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
1143         https://bugs.webkit.org/show_bug.cgi?id=195573
1144
1145         Reviewed by Simon Fraser.
1146
1147         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
1148
1149         * Scripts/dump-class-layout:
1150         (main):
1151         * lldb/lldb_dump_class_layout.py:
1152         (ClassLayout.__init__):
1153         (ClassLayout._compute_padding_recursive):
1154         (LLDBDebuggerInstance.dump_layout_for_classname):
1155         (LLDBDebuggerInstance):
1156         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
1157         (LLDBDebuggerInstance.layout_for_classname): Deleted.
1158
1159 2019-03-12  Chris Dumez  <cdumez@apple.com>
1160
1161         Device Orientation access permission should be denied unless explicitly granted by the client
1162         https://bugs.webkit.org/show_bug.cgi?id=195625
1163
1164         Reviewed by Youenn Fablet.
1165
1166         add API test coverage.
1167
1168         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1169         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
1170         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
1171         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
1172         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
1173         (runDeviceOrientationTest):
1174         (TEST):
1175         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1176         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
1177
1178 2019-03-12  Jer Noble  <jer.noble@apple.com>
1179
1180         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
1181         https://bugs.webkit.org/show_bug.cgi?id=195137
1182         <rdar://problem/48810307>
1183
1184         Reviewed by Eric Carlson.
1185
1186         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
1187         (TestWebKitAPI::TEST):
1188
1189 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
1190
1191         [ews-build] Change urls from uat to production
1192         https://bugs.webkit.org/show_bug.cgi?id=195566
1193
1194         Reviewed by Lucas Forschler.
1195
1196         * BuildSlaveSupport/ews-app/ews/config.py:
1197         * BuildSlaveSupport/ews-build/events.py:
1198         * BuildSlaveSupport/ews-build/steps.py:
1199
1200 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
1201
1202         [ews-build] change max_builds for local-worker to 1
1203         https://bugs.webkit.org/show_bug.cgi?id=195568
1204
1205         Reviewed by Lucas Forschler.
1206
1207         * BuildSlaveSupport/ews-build/loadConfig.py:
1208
1209 2019-03-12  Tim Horton  <timothy_horton@apple.com>
1210
1211         Fix the build
1212
1213         * TestRunnerShared/spi/PencilKitTestSPI.h:
1214         * TestWebKitAPI/ios/PencilKitTestSPI.h:
1215
1216 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
1217
1218         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
1219         https://bugs.webkit.org/show_bug.cgi?id=194131
1220
1221         Reviewed by Michael Catanzaro.
1222
1223         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1224         (uriChanged):
1225         (testUnfinishedSubresourceLoad):
1226         (serverCallback):
1227         (beforeAll):
1228
1229 2019-03-11  Alex Christensen  <achristensen@webkit.org>
1230
1231         WTF::Expected should use std::addressof instead of operator&
1232         https://bugs.webkit.org/show_bug.cgi?id=195604
1233
1234         Reviewed by Myles Maxfield.
1235
1236         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1237         (TestWebKitAPI::Unique::Unique):
1238         (TestWebKitAPI::Unique::operator&):
1239         (TestWebKitAPI::TEST):
1240
1241 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
1242
1243         Add Optional to Forward.h.
1244         https://bugs.webkit.org/show_bug.cgi?id=195586
1245
1246         Reviewed by Darin Adler.
1247
1248         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
1249         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
1250         Remove unnecessary includes from headers.
1251
1252 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
1253
1254         Add testing API to hit-test and scroll overflow scrollers
1255         https://bugs.webkit.org/show_bug.cgi?id=195278
1256
1257         Reviewed by Antti Koivisto.
1258         
1259         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
1260         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
1261         
1262         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
1263
1264         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1265         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
1266         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1267         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1268         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
1269         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1270         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1271         (WTR::enclosingScrollViewIncludingSelf):
1272         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
1273
1274 2019-03-11  Tim Horton  <timothy_horton@apple.com>
1275
1276         API test WebKit.RequestTextInputContext fails on iOS
1277         https://bugs.webkit.org/show_bug.cgi?id=195585
1278
1279         Reviewed by Wenson Hsieh and Simon Fraser.
1280
1281         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
1282         (applyStyle):
1283         (TEST):
1284         Add a viewport, so that the coordinates match up on iOS.
1285         Scroll by moving the UIScrollView's contentOffset.
1286
1287 2019-03-11  Chris Dumez  <cdumez@apple.com>
1288
1289         Assert in WebPageProxy::suspendCurrentPageIfPossible()
1290         https://bugs.webkit.org/show_bug.cgi?id=195506
1291         <rdar://problem/48733477>
1292
1293         Reviewed by Alex Christensen.
1294
1295         Add API test coverage.
1296
1297         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1298
1299 2019-03-11  Shawn Roberts  <sroberts@apple.com>
1300
1301         Adding myself to contributors.json
1302
1303         Unreviewed, addming myself to contributors.json .
1304
1305         * Scripts/webkitpy/common/config/contributors.json:
1306
1307 2019-03-11  Alex Christensen  <achristensen@webkit.org>
1308
1309         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
1310         https://bugs.webkit.org/show_bug.cgi?id=195511
1311         <rdar://problem/44873269>
1312
1313         Reviewed by Darin Adler.
1314
1315         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
1316         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
1317         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
1318         (TEST_F):
1319
1320 2019-03-11  Chris Dumez  <cdumez@apple.com>
1321
1322         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
1323         https://bugs.webkit.org/show_bug.cgi?id=195561
1324
1325         Reviewed by Youenn Fablet.
1326
1327         Make sure the JS in the test requests for permission to receive device orientation events.
1328
1329         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1330
1331 2019-03-11  Youenn Fablet  <youenn@apple.com>
1332
1333         Allow storage quota increase by default in WTR
1334         https://bugs.webkit.org/show_bug.cgi?id=195541
1335
1336         Reviewed by Geoffrey Garen.
1337
1338         Allow storage quota increase by default in WTR.
1339         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
1340         Use this for tests that explicitly need cache increase.
1341
1342         Instead of increasing quota by 2, make sure the next request is
1343         granted by adding all given parameters.
1344
1345         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1346         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1347         (WTR::TestRunner::setAllowStorageQuotaIncrease):
1348         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
1349         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1350         * WebKitTestRunner/TestController.cpp:
1351         (WTR::TestController::setAllowStorageQuotaIncrease):
1352         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
1353         * WebKitTestRunner/TestController.h:
1354         * WebKitTestRunner/TestInvocation.cpp:
1355         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1356         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1357         (WTR::TestController::cocoaResetStateToConsistentValues):
1358         (WTR::TestController::setAllowStorageQuotaIncrease):
1359         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
1360         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
1361         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
1362
1363 2019-03-11  Xan Lopez  <xan@igalia.com>
1364
1365         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
1366         https://bugs.webkit.org/show_bug.cgi?id=194147
1367
1368         Reviewed by Michael Saboff.
1369
1370         To make --32-bit work correctly on Linux/64bit we need to:
1371
1372         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
1373         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
1374         unfortunately CMake only allows us to do this during
1375         crosscompilation, which is overkill here.
1376         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
1377         pkg-config detection module uses the x86 .pc files instead of the
1378         x86_64 ones.
1379         - Set the -m32 flags for the compiler.
1380
1381         * Scripts/webkitdirs.pm:
1382         (generateBuildSystemFromCMakeProject):
1383
1384 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
1385
1386         Add MotionMark-1.1 plan file for run-benchmark script.
1387         https://bugs.webkit.org/show_bug.cgi?id=195481
1388
1389         Rubber-stamped by Darin Adler.
1390
1391         Run-benchmark script should support MontionMark-1.1.
1392
1393         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
1394
1395 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
1396
1397         [ews-app] Add support for submit-to-ews url
1398         https://bugs.webkit.org/show_bug.cgi?id=195477
1399
1400         Reviewed by Lucas Forschler.
1401
1402         * BuildSlaveSupport/ews-app/ews/fetcher.py:
1403         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1404         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
1405         * BuildSlaveSupport/ews-app/ews/urls.py:
1406         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
1407
1408 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
1409
1410         Unreviewed, rolling out r242688, r242643, r242624.
1411
1412         Caused multiple layout test failures and crashes on iOS and macOS.
1413
1414         Reverted changeset:
1415
1416         "requestAnimationFrame should execute before the next frame"
1417         https://bugs.webkit.org/show_bug.cgi?id=177484
1418         https://trac.webkit.org/changeset/242624/webkit
1419
1420         * Tracing/SystemTracePoints.plist:
1421
1422 2019-03-11  John Wilander  <wilander@apple.com>
1423
1424         Resource Load Statistics: Make it possible exclude localhost from classification
1425         https://bugs.webkit.org/show_bug.cgi?id=195474
1426         <rdar://problem/47520577>
1427
1428         Reviewed by Brent Fulgham.
1429
1430         This patch allows for localhost to be excluded from classification and
1431         treatment as a prevalent resource.
1432
1433         The WebKit Tools change adds a new function called
1434         testRunner.setStatisticsIsRunningTest() which can be used to control this
1435         behavior.
1436
1437         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1438         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1439         (WTR::TestRunner::setStatisticsIsRunningTest):
1440         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1441         * WebKitTestRunner/TestController.cpp:
1442         (WTR::TestController::setStatisticsIsRunningTest):
1443         * WebKitTestRunner/TestController.h:
1444         * WebKitTestRunner/TestInvocation.cpp:
1445         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1446
1447 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
1448
1449         [ews-build] Disable waterfall and console view for ews-build.webkit.org
1450         https://bugs.webkit.org/show_bug.cgi?id=195560
1451
1452         Reviewed by Lucas Forschler.
1453
1454         * BuildSlaveSupport/ews-build/master.cfg:
1455
1456 2019-03-11  Alex Christensen  <achristensen@webkit.org>
1457
1458         Unreviewed, rolling out r242698.
1459
1460         API test crashes on bots.
1461
1462         Reverted changeset:
1463
1464         "Add a WKContentRuleList variant that uses copied memory
1465         instead of mmap'd shared memory for class A containerized
1466         apps"
1467         https://bugs.webkit.org/show_bug.cgi?id=195511
1468         https://trac.webkit.org/changeset/242698
1469
1470 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
1471
1472         [WPE] Enable web process sandbox
1473         https://bugs.webkit.org/show_bug.cgi?id=195169
1474
1475         Reviewed by Daniel Bates.
1476
1477         * wpe/install-dependencies:
1478         * wpe/jhbuild.modules:
1479
1480 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
1481
1482         [ews-app] Use port 17000 for worker communication
1483         https://bugs.webkit.org/show_bug.cgi?id=195558
1484
1485         Reviewed by Lucas Forschler.
1486
1487         * BuildSlaveSupport/ews-build/master.cfg:
1488
1489 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
1490
1491         [ews-build] unit-tests fail when passwords.json is missing
1492         https://bugs.webkit.org/show_bug.cgi?id=195557
1493
1494         Reviewed by Lucas Forschler.
1495
1496         * BuildSlaveSupport/ews-build/loadConfig.py:
1497         (loadBuilderConfig):
1498         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
1499         (ConfigDotJSONTest.test_configuration):
1500         * BuildSlaveSupport/ews-build/master.cfg:
1501
1502 2019-03-11  Truitt Savell  <tsavell@apple.com>
1503
1504         Unreviewed, rolling out r242702.
1505
1506         Broke High Sierra builders.
1507
1508         Reverted changeset:
1509
1510         "Add utility function to allow easy reverse range-based
1511         iteration of a container"
1512         https://bugs.webkit.org/show_bug.cgi?id=195542
1513         https://trac.webkit.org/changeset/242702
1514
1515 2019-03-11  Sam Weinig  <sam@webkit.org>
1516
1517         Add utility function to allow easy reverse range-based iteration of a container
1518         https://bugs.webkit.org/show_bug.cgi?id=195542
1519
1520         Reviewed by Antti Koivisto.
1521
1522         * TestWebKitAPI/CMakeLists.txt:
1523         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1524         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
1525         (TestWebKitAPI::TEST):
1526         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
1527
1528 2019-03-10  Alex Christensen  <achristensen@webkit.org>
1529
1530         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
1531         https://bugs.webkit.org/show_bug.cgi?id=195511
1532         <rdar://problem/44873269>
1533
1534         Reviewed by Darin Adler.
1535
1536         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
1537         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
1538         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
1539         (TEST_F):
1540
1541 2019-03-10  Tim Horton  <timothy_horton@apple.com>
1542
1543         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
1544         https://bugs.webkit.org/show_bug.cgi?id=195499
1545
1546         Reviewed by Darin Adler.
1547
1548         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1549         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
1550         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
1551         (-[WKWebView synchronouslyFocusTextInputContext:]):
1552         (applyStyle):
1553         (applyIframe):
1554         (TEST):
1555         Add some tests for this SPI.
1556
1557 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
1558
1559         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
1560         https://bugs.webkit.org/show_bug.cgi?id=181151
1561
1562         Reviewed by Don Olmstead.
1563
1564         * TestWebKitAPI/CMakeLists.txt:
1565         * TestWebKitAPI/PlatformWin.cmake:
1566         Enable TestWTF RunLoop tests in all platforms.
1567
1568         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
1569         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
1570         (TestWebKitAPI::DerivedOneShotTimer::fired):
1571         (TestWebKitAPI::TEST):
1572         Only a few platforms support nested RunLoop.
1573
1574         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
1575         (TestWebKitAPI::DerivedRepeatingTimer::fired):
1576
1577 2019-03-10  David Quesada  <david_quesada@apple.com>
1578
1579         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
1580         https://bugs.webkit.org/show_bug.cgi?id=152480
1581
1582         Reviewed by Chris Dumez.
1583
1584         Add a unit test based on Daniel Bates's test case that starts a download, ensures
1585         there are no additional references to the process pool besides the one held by
1586         the download, waits for the download to finish (in the sense that the
1587         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
1588         measure, also check that the process pool has been deallocated at the end of the
1589         test. The test wouldn't be meaningful if the process pool were still alive.
1590
1591         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1592         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
1593         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
1594             The download will be canceled because the delegate does not implement the
1595             method to decide the download's destination, so this is where we know the
1596             DownloadProxyMap is done with the DownloadProxy.
1597         (TEST):
1598
1599 2019-03-08  Chris Dumez  <cdumez@apple.com>
1600
1601         Add support for Device Orientation / Motion permission API
1602         https://bugs.webkit.org/show_bug.cgi?id=195329
1603         <rdar://problem/47645367>
1604
1605         Reviewed by Geoffrey Garen.
1606
1607         Add test infrastructure to help test the Device Orientation / Motion permission API.
1608
1609         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1610         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1611         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
1612         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1613         * WebKitTestRunner/TestController.cpp:
1614         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
1615         (WTR::TestController::createWebViewWithOptions):
1616         (WTR::TestController::resetStateToConsistentValues):
1617         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
1618         * WebKitTestRunner/TestController.h:
1619         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
1620         * WebKitTestRunner/TestInvocation.cpp:
1621         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1622
1623 2019-03-08  Saam barati  <sbarati@apple.com>
1624
1625         Add a compare-results script to compare benchmark results
1626         https://bugs.webkit.org/show_bug.cgi?id=195486
1627         <rdar://problem/48723397>
1628
1629         Reviewed by Geoffrey Garen.
1630
1631         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
1632         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
1633         to extend it to learn about our other benchmarks.
1634
1635         * Scripts/compare-results: Added.
1636         (readJSONFile):
1637         (detectJetStream2):
1638         (JetStream2Results):
1639         (detectSpeedometer2):
1640         (Speedometer2Results):
1641         (detectPLT5):
1642         (PLT5Results):
1643         (detectBenchmark):
1644         (biggerIsBetter):
1645         (ttest):
1646         (getOptions):
1647         (main):
1648
1649 2019-03-08  Stephanie Lewis  <slewis@apple.com>
1650
1651         Ensure old tab state is cleared between iterations of run-benchmark
1652         https://bugs.webkit.org/show_bug.cgi?id=195393
1653         <rdar://problem/46885583>
1654
1655         Reviewed by Dewei Zhu.
1656
1657         a) ensure the default to restore state is not set
1658         b) terminate Safari correctly
1659         c) Set the system default to ignore Persistent State in Safari
1660
1661         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1662         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
1663         (OSXBrowserDriver.prepare_env): 
1664         (OSXBrowserDriver.restore_env):
1665         (OSXBrowserDriver.close_browsers):
1666         (OSXBrowserDriver._terminate_processes):
1667         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
1668         (OSXChromeDriver):
1669         (OSXChromeCanaryDriver):
1670         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
1671         (OSXFirefoxDriver):
1672         (OSXFirefoxNightlyDriver):
1673         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
1674         (OSXSafariDriver):
1675         (OSXSafariDriver.prepare_env):
1676
1677 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
1678
1679         [GTK] Several InputMethodFilter tests are failing
1680         https://bugs.webkit.org/show_bug.cgi?id=195408
1681
1682         Reviewed by Carlos Garcia Campos.
1683
1684         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
1685         Regressed in r241751.
1686         Hexadecimal values of keycodes are expressed now in upper letters.
1687         Composited characters should be cast to UTF8 strings.
1688
1689         (TestWebKitAPI::TEST):
1690
1691 2019-03-07  Tomas Popela  <tpopela@redhat.com>
1692
1693         [GTK] Make Tools/gtkdoc python3 compatible
1694         https://bugs.webkit.org/show_bug.cgi?id=195359
1695
1696         Reviewed by Carlos Garcia Campos.
1697
1698         * gtkdoc/generate-gtkdoc:
1699         ConfigParser was reworked in Python 3.2 so we have adapt the code to
1700         work with Python 2 and 3.
1701         (get_gtkdoc_module_paths):
1702         The iteritems() was removed in Python 3, so let's use items() that's
1703         available in Python 2 and 3.
1704         (get_generator_for_config):
1705         * gtkdoc/gtkdoc.py:
1706         (GTKDoc._run_command):
1707         The sys.stdout.write() is expecting str in Python 3 and not bytes
1708         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
1709         for passing the bytes there.
1710
1711 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
1712
1713         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
1714         https://bugs.webkit.org/show_bug.cgi?id=195346
1715         <rdar://problem/48667048>
1716
1717         Unreviewed build fix for clang-cl.
1718
1719         * DumpRenderTree/win/DumpRenderTree.cpp:
1720         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
1721
1722 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
1723
1724         requestAnimationFrame should execute before the next frame
1725         https://bugs.webkit.org/show_bug.cgi?id=177484
1726
1727         Reviewed by Simon Fraser.
1728
1729         Add trace points for the page RenderingUpdate.
1730
1731         * Tracing/SystemTracePoints.plist:
1732
1733 2019-03-07  Zalan Bujtas  <zalan@apple.com>
1734
1735         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
1736         https://bugs.webkit.org/show_bug.cgi?id=195353
1737         <rdar://problem/48626394>
1738
1739         Reviewed by Simon Fraser.
1740
1741         * WebKitTestRunner/ios/TestControllerIOS.mm:
1742         (WTR::TestController::platformResetPreferencesToConsistentValues):
1743
1744 2019-03-07  John Wilander  <wilander@apple.com>
1745
1746         Resource Load Statistics: Make it possible to purge only script-accessible cookies
1747         https://bugs.webkit.org/show_bug.cgi?id=195383
1748         <rdar://problem/48570136>
1749
1750         Reviewed by Brent Fulgham.
1751
1752         This patch adds test infrastructure to purge only script-accessible cookies,
1753         including a new testRunner function called statisticsDeleteCookiesForHost().git a
1754
1755         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1756         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1757         (WTR::TestRunner::statisticsDeleteCookiesForHost):
1758         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1759         * WebKitTestRunner/TestController.cpp:
1760         (WTR::TestController::statisticsDeleteCookiesForHost):
1761         * WebKitTestRunner/TestController.h:
1762         * WebKitTestRunner/TestInvocation.cpp:
1763         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1764
1765 2019-03-07  Commit Queue  <commit-queue@webkit.org>
1766
1767         Unreviewed, rolling out r242354.
1768         https://bugs.webkit.org/show_bug.cgi?id=195402
1769
1770         breaks layout tests in all configurations (Requested by
1771         zdobersek on #webkit).
1772
1773         Reverted changeset:
1774
1775         "[WPE] Enable web process sandbox"
1776         https://bugs.webkit.org/show_bug.cgi?id=195169
1777         https://trac.webkit.org/changeset/242354
1778
1779 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
1780
1781         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
1782         https://bugs.webkit.org/show_bug.cgi?id=195346
1783
1784         Reviewed by Fujii Hironori.
1785
1786         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
1787         (TestWebKitAPI::TEST):
1788         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
1789
1790         * DumpRenderTree/win/DumpRenderTree.cpp:
1791         (findFontFallback):
1792         (addFontFallbackIfPresent):
1793         (removeFontFallbackIfPresent):
1794         (main):
1795         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1796         (TestWebKitAPI::Util::moduleDirectory):
1797         (TestWebKitAPI::Util::createInjectedBundlePath):
1798         Use wchar helpers as needed.
1799
1800 2019-03-06  Rob Buis  <rbuis@igalia.com>
1801
1802         Consider supporting the `referrerpolicy` attribute.
1803         https://bugs.webkit.org/show_bug.cgi?id=179053
1804
1805         Reviewed by Darin Adler.
1806
1807         Add a runtime flag for referrerpolicy attribute.
1808
1809         * DumpRenderTree/mac/DumpRenderTree.mm:
1810         (enableExperimentalFeatures):
1811
1812 2019-03-05  Daniel Bates  <dabates@apple.com>
1813
1814         Update expected API test result following r242379
1815         (https://bugs.webkit.org/show_bug.cgi?id=195125)
1816
1817         Update expected x-coordinate of selection rect now that the left padding of
1818         a textarea is sized in ems (so dependent on the font size) just like the left
1819         padding of a text field.
1820
1821         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1822         (TestWebKitAPI::TEST):
1823
1824 2019-03-05  David Quesada  <david_quesada@apple.com>
1825
1826         [WK2] It should be possible to follow links with 'download' attributes
1827         https://bugs.webkit.org/show_bug.cgi?id=195145
1828         rdar://problem/48462642
1829
1830         Reviewed by Alex Christensen.
1831
1832         Add a unit test to verify that activating links with 'download' attributes now
1833         navigates to the linked resource, rather than starts downloading it. Add another
1834         to verify that it is still possible to explicitly download the link via the
1835         'Download' navigation action policy.
1836
1837         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1838         (-[DownloadAttributeTestDelegate init]):
1839         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
1840         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
1841         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
1842         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
1843         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1844         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
1845         (TEST):
1846         * WebKitTestRunner/TestController.cpp:
1847         (WTR::TestController::decidePolicyForNavigationAction):
1848         * WebKitTestRunner/TestController.h:
1849
1850 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
1851
1852         [Curl] Implement Cookie Accept Policy.
1853         https://bugs.webkit.org/show_bug.cgi?id=191645
1854
1855         Reviewed by Fujii Hironori.
1856
1857         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
1858         (TestWebKitAPI::Curl::TEST_F):
1859
1860 2019-03-05  Youenn Fablet  <youenn@apple.com>
1861
1862         Rename requestCacheStorageSpace to requestStorageSpace
1863         https://bugs.webkit.org/show_bug.cgi?id=195282
1864
1865         Reviewed by Chris Dumez.
1866
1867         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
1868         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
1869         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
1870
1871 2019-03-05  Brady Eidson  <beidson@apple.com>
1872
1873         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
1874         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
1875
1876         Reviewed by Tim Horton.
1877
1878         Loading a file: URL into a WKWebView and then loading another file: url from a completely
1879         different directory into that same WKWebView should work.
1880
1881         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1882         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
1883
1884 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
1885
1886         Add WeakHashSet
1887         https://bugs.webkit.org/show_bug.cgi?id=195152
1888
1889         Reviewed by Antti Koivisto.
1890
1891         Added tests for WeakHashSet.
1892
1893         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1894         (TestWebKitAPI::Base::Base): Moved.
1895         (TestWebKitAPI::Derived::foo): Moved.
1896         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
1897         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
1898         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
1899         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
1900
1901 2019-03-04  Chris Dumez  <cdumez@apple.com>
1902
1903         Do not share WebProcesses between private and regular sessions
1904         https://bugs.webkit.org/show_bug.cgi?id=195189
1905         <rdar://problem/48421064>
1906
1907         Reviewed by Alex Christensen.
1908
1909         Add API test coverage.
1910
1911         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1912         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1913
1914 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
1915
1916         [WPE] Enable web process sandbox
1917         https://bugs.webkit.org/show_bug.cgi?id=195169
1918
1919         Reviewed by Daniel Bates.
1920
1921         * wpe/install-dependencies:
1922         * wpe/jhbuild.modules:
1923
1924 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
1925
1926         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
1927         https://bugs.webkit.org/show_bug.cgi?id=195206
1928
1929         Reviewed by Žan Doberšek.
1930
1931         Add a new test case.
1932
1933         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1934         (testJSCClass):
1935
1936 2019-03-04  Charlie Turner  <cturner@igalia.com>
1937
1938         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
1939         https://bugs.webkit.org/show_bug.cgi?id=194898
1940
1941         Reviewed by Žan Doberšek.
1942
1943         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
1944         a GCC extension that permits arithmetic on void* pointer. Inline
1945         the macro until this issue is fixed upstream.
1946
1947 2019-03-03  Tim Horton  <timothy_horton@apple.com>
1948
1949         Rid the world of WK_API_ENABLED
1950         https://bugs.webkit.org/show_bug.cgi?id=195263
1951
1952         Reviewed by Dan Bernstein.
1953
1954         List of changed files elided because it's useless.
1955
1956 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
1957
1958         Unreviewed follow-up to r242292.
1959
1960         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
1961
1962         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
1963         (TestWebKitAPI::testStrip): Renamed from strip.
1964         (TestWebKitAPI::TEST):
1965
1966 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1967
1968         Unreviewed, remove accidentally-committed URLHelpers.cpp test
1969
1970         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
1971         and bug #194272 for details.
1972
1973         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
1974
1975 2019-03-03  Tim Horton  <timothy_horton@apple.com>
1976
1977         Remove some more unused 32-bit code
1978         https://bugs.webkit.org/show_bug.cgi?id=195255
1979
1980         Reviewed by Darin Adler.
1981
1982         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1983         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
1984         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1985         (NPP_New):
1986         (NPP_HandleEvent):
1987         (handleEventCarbon): Deleted.
1988
1989 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
1990
1991         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
1992
1993         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
1994         (TestWebKitAPI::TEST):
1995
1996 2019-03-01  Darin Adler  <darin@apple.com>
1997
1998         Finish removing String::format
1999         https://bugs.webkit.org/show_bug.cgi?id=194893
2000
2001         Reviewed by Daniel Bates.
2002 '
2003         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
2004
2005 2019-03-01  Alex Christensen  <achristensen@webkit.org>
2006
2007         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
2008         https://bugs.webkit.org/show_bug.cgi?id=195229
2009         <rdar://problem/48520362>
2010
2011         Reviewed by Chris Dumez.
2012
2013         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2014         (TEST):
2015
2016 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
2017
2018         Add a system trace scope for event region building
2019         https://bugs.webkit.org/show_bug.cgi?id=195226
2020
2021         Reviewed by Jon Lee.
2022
2023         This trace scope measures the time spend converting element rects into Region objects,
2024         which can be large on some pages.
2025
2026         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
2027
2028         * Tracing/SystemTracePoints.plist:
2029
2030 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
2031
2032         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
2033         https://bugs.webkit.org/show_bug.cgi?id=194612
2034
2035         Reviewed by Alex Christensen.
2036
2037         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
2038         Just test the new string-processing function and don't touch the actual environment.
2039         (Test cases are all as before, but based on operator== instead of strcmp.)
2040
2041 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
2042
2043         [ews-app] Update primary keys for handling multiple Buildbot instances
2044         https://bugs.webkit.org/show_bug.cgi?id=195120
2045
2046         Reviewed by Stephanie Lewis.
2047
2048         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
2049         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
2050         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
2051
2052         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
2053         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
2054         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
2055         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
2056         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
2057         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
2058
2059 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
2060
2061         [WinCairo] Enable service worker
2062         https://bugs.webkit.org/show_bug.cgi?id=188318
2063
2064         Reviewed by Youenn Fablet.
2065
2066         * DumpRenderTree/DumpRenderTreePrefix.h:
2067         * TestWebKitAPI/PlatformWin.cmake:
2068         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
2069         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
2070         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
2071
2072 2019-03-01  Justin Fan  <justin_fan@apple.com>
2073
2074         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
2075         https://bugs.webkit.org/show_bug.cgi?id=195191
2076
2077         Rubber-stamped by Dean Jackson.
2078
2079         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
2080
2081         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2082
2083 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
2084
2085         Unreviewed, fix lldb webkitpy tests
2086         https://bugs.webkit.org/show_bug.cgi?id=194375
2087
2088         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
2089
2090         * lldb/lldb_webkit.py:
2091         (WTFStringImplProvider.is_8bit):
2092
2093 2019-02-28  David Quesada  <david_quesada@apple.com>
2094
2095         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
2096         https://bugs.webkit.org/show_bug.cgi?id=195121
2097         rdar://problem/48450302
2098
2099         Reviewed by Alex Christensen.
2100
2101         Add API tests for -WKNavigationAction._shouldPerformDownload in various
2102         configurations where the 'download' attribute is absent, blank, or populated
2103         with a filename, and where the anchor element is same-origin or cross-origin
2104         (meaning the 'download' attribute shouldn't be honored).
2105
2106         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2107         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
2108         (-[NavigationActionTestDelegate init]):
2109         (-[NavigationActionTestDelegate navigationAction]):
2110         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
2111         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
2112         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2113         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
2114         (TEST):
2115
2116 2019-02-28  Antoine Quint  <graouts@apple.com>
2117
2118         Enable the Pointer Events runtime flag by default
2119         https://bugs.webkit.org/show_bug.cgi?id=195156
2120
2121         Reviewed by Dean Jackson.
2122
2123         * DumpRenderTree/mac/DumpRenderTree.mm:
2124         (enableExperimentalFeatures):
2125
2126 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
2127
2128         Several PasteImage API tests are flaky
2129         https://bugs.webkit.org/show_bug.cgi?id=195160
2130
2131         Reviewed by Tim Horton.
2132
2133         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
2134         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
2135         listening for a "load" event after image load is already complete.
2136
2137         To address this, make these tests first register a "load" event handler, then run script to insert an image
2138         element into the document, and finally wait until the load event is observed before checking image size.
2139
2140         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
2141
2142 2019-02-28  Chris Dumez  <cdumez@apple.com>
2143
2144         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
2145         https://bugs.webkit.org/show_bug.cgi?id=195107
2146
2147         Reviewed by Alex Christensen.
2148
2149         Give some time for the zoom level to get restored.
2150
2151         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2152
2153 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
2154
2155         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
2156         https://bugs.webkit.org/show_bug.cgi?id=194958
2157
2158         Reviewed by Geoffrey Garen.
2159
2160         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
2161         (TEST):
2162
2163 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
2164
2165         [ews-app] Update method to save build to handle builder_display_name
2166         https://bugs.webkit.org/show_bug.cgi?id=195047
2167
2168         Reviewed by Dewei Zhu.
2169
2170         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
2171         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
2172
2173 2019-02-28  Justin Fan  <justin_fan@apple.com>
2174
2175         [Web GPU] Enable Web GPU only on 64-bit
2176         https://bugs.webkit.org/show_bug.cgi?id=195139
2177
2178         Because Metal is only supported on 64 bit apps.
2179
2180         Unreviewed build fix.
2181
2182         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2183
2184 2019-02-27  Youenn Fablet  <youenn@apple.com>
2185
2186         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
2187         https://bugs.webkit.org/show_bug.cgi?id=194959
2188
2189         Reviewed by Chris Dumez.
2190
2191         Spin loop until getting the condition to remove flakiness.
2192
2193         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2194
2195 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
2196
2197         [ews-build] Buildbot should include builder_display_name in the build events
2198         https://bugs.webkit.org/show_bug.cgi?id=195045
2199
2200         Reviewed by Dewei Zhu.
2201
2202         * BuildSlaveSupport/ews-build/events.py:
2203         (Events.buildStarted): Included builder_display_name in event data. Also renamed
2204         buildername to builder_name to be consistent in naming style.
2205         (Events.buildFinished): Ditto.
2206
2207 2019-02-27  Chris Dumez  <cdumez@apple.com>
2208
2209         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
2210         https://bugs.webkit.org/show_bug.cgi?id=194480
2211
2212         Reviewed by Brady Eidson.
2213
2214         Update existing API test to make it more likely to reproduce the issue.
2215
2216         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2217
2218 2019-02-27  Brady Eidson  <beidson@apple.com>
2219
2220         Universal links from Google search results pages don't open the app.
2221         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
2222
2223         Reviewed by Geoffrey Garen.
2224
2225         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
2226         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
2227         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
2228         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2229
2230 2019-02-27  Chris Dumez  <cdumez@apple.com>
2231
2232         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
2233         https://bugs.webkit.org/show_bug.cgi?id=195102
2234
2235         Reviewed by Geoffrey Garen.
2236
2237         If the number of processes is not yet what we expect, wait a bit and check again to give
2238         processes some time to exit.
2239
2240         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2241
2242 2019-02-27  Chris Dumez  <cdumez@apple.com>
2243
2244         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
2245         https://bugs.webkit.org/show_bug.cgi?id=194545
2246
2247         Reviewed by Brady Eidson.
2248
2249         Make sure the test navigates forward and then back only once. Previously, navigating
2250         back would trigger a navigation again in a timer.
2251
2252         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2253
2254 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
2255
2256         High Sierra Debug JSC test queue should use faster hardware
2257         https://bugs.webkit.org/show_bug.cgi?id=194603
2258
2259         Rubber-stamped by Alexey Proskuryakov.
2260
2261         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
2262
2263         * BuildSlaveSupport/build.webkit.org-config/config.json:
2264         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2265         (BubbleQueueServer):
2266         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2267         (WebKitBuildbot):
2268         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2269         * QueueStatusServer/config/queues.py:
2270         * Scripts/webkitpy/common/config/ews.json:
2271         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2272         (test_ews_name):
2273
2274 2019-02-27  John Wilander  <wilander@apple.com>
2275
2276         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
2277         https://bugs.webkit.org/show_bug.cgi?id=195071
2278         <rdar://problem/48417690>
2279
2280         Reviewed by Alex Christensen and Brent Fulgham.
2281
2282         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2283         (TestWebKitAPI::createURL):
2284             Convenience function.
2285         (TestWebKitAPI::TEST):
2286             WebCore::AdClickAttribution now takes a URL when creating Source and
2287             Destination.
2288         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
2289         (TestWebKitAPI::TEST):
2290             WebCore::AdClickAttribution now takes a URL when creating Source and
2291             Destination.
2292
2293 2019-02-27  Antoine Quint  <graouts@apple.com>
2294
2295         Support Pointer Events on macOS
2296         https://bugs.webkit.org/show_bug.cgi?id=195008
2297         <rdar://problem/47454419>
2298
2299         Reviewed by Dean Jackson.
2300
2301         * DumpRenderTree/mac/DumpRenderTree.mm:
2302         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
2303         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2304
2305 2019-02-26  Mark Lam  <mark.lam@apple.com>
2306
2307         Remove remaining poisoning code.
2308         https://bugs.webkit.org/show_bug.cgi?id=194138
2309
2310         Reviewed by Saam Barati.
2311
2312         * TestWebKitAPI/CMakeLists.txt:
2313         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2314         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
2315         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
2316         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
2317         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
2318         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
2319         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
2320
2321 2019-02-26  Alex Christensen  <achristensen@webkit.org>
2322
2323         Move ephemeral local storage from WebProcess to UIProcess
2324         https://bugs.webkit.org/show_bug.cgi?id=195074
2325         <rdar://problem/47937975>
2326
2327         Reviewed by Geoff Garen.
2328
2329         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2330
2331 2019-02-20  Jer Noble  <jer.noble@apple.com>
2332
2333         [Cocoa] Media elements will restart network buffering just before suspending
2334         https://bugs.webkit.org/show_bug.cgi?id=193691
2335
2336         Reviewed by Eric Carlson.
2337
2338         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2339         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
2340         (TEST):
2341
2342 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
2343
2344         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
2345         https://bugs.webkit.org/show_bug.cgi?id=191652
2346
2347         Reviewed by Alex Christensen.
2348
2349         Fix WinCairo MiniBrowser behavior of authentication dialog.
2350
2351         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2352         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
2353
2354 2019-02-26  Youenn Fablet  <youenn@apple.com>
2355
2356         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
2357         https://bugs.webkit.org/show_bug.cgi?id=195028
2358         <rdar://problem/48243733>
2359
2360         Reviewed by Eric Carlson.
2361
2362         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2363
2364 2019-02-26  Philippe Normand  <pnormand@igalia.com>
2365
2366         [WPE] Add API for webview background color configuration
2367         https://bugs.webkit.org/show_bug.cgi?id=192305
2368
2369         Reviewed by Michael Catanzaro.
2370
2371         * MiniBrowser/wpe/main.cpp:
2372         (main): Add a new option to configure the webview background
2373         color. Example: --bg-color=transparent.
2374         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
2375         (testWebViewBackgroundColor): Enable background color API tests for WPE.
2376         (beforeAll): Ditto.
2377
2378 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
2379
2380         scalableNativeWebpageParameters() is not preserved on new page navigation.
2381         https://bugs.webkit.org/show_bug.cgi?id=194892
2382         <rdar://problem/47538280>
2383
2384         Reviewed by Wenson Hsieh.
2385         
2386         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
2387
2388         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2389         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
2390         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2391         (WTR::UIScriptController::allowsViewportShrinkToFit):
2392         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2393         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2394         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
2395         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2396         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2397         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
2398
2399 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
2400
2401         [ews-app] Add model for handling multiple Buildbot instances
2402         https://bugs.webkit.org/show_bug.cgi?id=194863
2403
2404         Reviewed by Stephanie Lewis.
2405
2406         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
2407
2408 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
2409
2410         [ews-app] Remove BuilderMapping table
2411         https://bugs.webkit.org/show_bug.cgi?id=194961
2412
2413         Reviewed by Stephanie Lewis.
2414
2415         Store builder name directly in build table, instead of having a separate
2416         table for it.
2417
2418         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
2419         * BuildSlaveSupport/ews-app/ews/models/build.py:
2420         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
2421         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2422
2423 2019-02-25  John Wilander  <wilander@apple.com>
2424
2425         Introduce and adopt new class RegistrableDomain for eTLD+1
2426         https://bugs.webkit.org/show_bug.cgi?id=194791
2427         <rdar://problem/48179240>
2428
2429         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
2430
2431         This patch adds an API test and replaces two instances of
2432         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
2433
2434         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2435         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2436         (TestWebKitAPI::TEST):
2437             Changed two strings to make sure the registrable domains are still considered
2438             invalid and pass the test.
2439         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
2440         (TestWebKitAPI::TEST):
2441         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2442         (WTR::InjectedBundle::didReceiveMessageToPage):
2443
2444 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
2445
2446         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
2447         https://bugs.webkit.org/show_bug.cgi?id=195001
2448
2449         Reviewed by Carlos Garcia Campos.
2450
2451         API version 1.0 always includes the functionality previously guarded with
2452         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
2453         unconditionally.
2454
2455         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2456         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
2457         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
2458         (WebViewTest::showInWindow): Ditto.
2459         (WebViewTest::hideView): Ditto.
2460         * wpe/backends/HeadlessViewBackend.cpp:
2461         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
2462         * wpe/backends/ViewBackend.cpp:
2463         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
2464         * wpe/backends/WindowViewBackend.cpp:
2465         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
2466         WPE_BACKEND_CHECK_VERSION().
2467         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
2468
2469 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
2470
2471         [Flatpak] Add support for flatpak > 1.1.2
2472         https://bugs.webkit.org/show_bug.cgi?id=194088
2473
2474         Flatpak 1.2 is now out so we need to support that
2475         version now.
2476
2477         Reviewed by Michael Catanzaro.
2478
2479         * flatpak/flatpakutils.py:
2480         (check_flatpak):
2481         (FlatpakPackages.__init__):
2482         (FlatpakPackages.__detect_packages):
2483         (FlatpakPackages.__detect_packages.in):
2484         (FlatpakRepos.update):
2485
2486 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
2487
2488         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
2489         https://bugs.webkit.org/show_bug.cgi?id=194998
2490
2491         Reviewed by Carlos Garcia Campos.
2492
2493         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
2494         to a Git checkout and using the latest commit containing various fixes
2495         and improvements.
2496
2497 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2498
2499         [WPE][GTK] Remove user agent quirk for washingtonpost.com
2500         https://bugs.webkit.org/show_bug.cgi?id=194981
2501
2502         Reviewed by Žan Doberšek.
2503
2504         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2505         (TestWebKitAPI::TEST):
2506
2507 2019-02-23  Keith Miller  <keith_miller@apple.com>
2508
2509         Add new mac target numbers
2510         https://bugs.webkit.org/show_bug.cgi?id=194955
2511
2512         Reviewed by Tim Horton.
2513
2514         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2515         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2516         * MiniBrowser/Configurations/Base.xcconfig:
2517         * TestWebKitAPI/Configurations/Base.xcconfig:
2518         * WebKitTestRunner/Configurations/Base.xcconfig:
2519
2520 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
2521
2522         [WinCairo] Enable wk1/wk2 suffix for platform search path.
2523         https://bugs.webkit.org/show_bug.cgi?id=194846
2524
2525         Reviewed by Don Olmstead.
2526
2527         Added _search_paths() and _port_specific_expectations_files() for
2528         WinCairoPort.
2529
2530         * Scripts/webkitpy/port/win.py:
2531         (WinCairoPort.default_baseline_search_path):
2532         (WinCairoPort):
2533         (WinCairoPort._port_specific_expectations_files):
2534         (WinCairoPort._search_paths):
2535
2536 2019-02-22  Tim Horton  <timothy_horton@apple.com>
2537
2538         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
2539         https://bugs.webkit.org/show_bug.cgi?id=194963
2540
2541         Reviewed by Dean Jackson.
2542
2543         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2544         Do a `contains` check instead of `equals`, because in debug builds we
2545         put the GraphicsLayer pointer in a prefix.
2546
2547 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2548
2549         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
2550         https://bugs.webkit.org/show_bug.cgi?id=194873
2551         <rdar://problem/46701974>
2552
2553         Reviewed by Tim Horton.
2554
2555         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
2556
2557         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2558         (WTR::UIScriptController::menuRect const):
2559         (WTR::UIScriptController::isShowingMenu const):
2560         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2561         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2562         (WTR::UIScriptController::menuRect const):
2563
2564         Add a function to query the bounds of the callout menu in content coordinates.
2565
2566         (WTR::UIScriptController::isShowingMenu const):
2567
2568         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
2569
2570         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2571         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2572         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2573         (WTR::UIScriptController::rectForMenuAction const):
2574         (WTR::UIScriptController::menuRect const):
2575         (WTR::UIScriptController::isShowingMenu const):
2576         (WTR::findViewInHierarchyOfType): Deleted.
2577
2578 2019-02-22  Chris Dumez  <cdumez@apple.com>
2579
2580         Regression(PSON) Unable to preview password-protected documents on iCloud.com
2581         https://bugs.webkit.org/show_bug.cgi?id=194954
2582         <rdar://problem/48127957>
2583
2584         Reviewed by Alex Christensen.
2585
2586         Add API test coverage.
2587
2588         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2589         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
2590         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
2591         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
2592
2593 2019-02-22  Chris Dumez  <cdumez@apple.com>
2594
2595         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
2596         https://bugs.webkit.org/show_bug.cgi?id=194924
2597         <rdar://problem/48216125>
2598
2599         Reviewed by Geoffrey Garen.
2600
2601         Add API test coverage.
2602
2603         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2604
2605 2019-02-22  Chris Dumez  <cdumez@apple.com>
2606
2607         Unreviewed, disable API test added in r241928 on iOS.
2608
2609         The cache is not enabled on devices with less than 3GB of RAM.
2610
2611         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2612
2613 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
2614
2615         Hardcode Visual Viewports on everywhere except iOS WK1
2616         https://bugs.webkit.org/show_bug.cgi?id=194928
2617
2618         Reviewed by Zalan Bujtas.
2619
2620         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
2621         change the default value of the Setting to 'true', and hardcode WebView on iOS to
2622         set it to false. The setting has shipped for several years and there's no need to turn
2623         it off now.
2624
2625         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
2626         Visual Viewports are not enabled.
2627         
2628         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
2629         that only runs in WK2
2630
2631         * MiniBrowser/mac/SettingsController.h:
2632         * MiniBrowser/mac/SettingsController.m:
2633         (-[SettingsController init]):
2634         (-[SettingsController _populateMenu]):
2635         (-[SettingsController validateMenuItem:]):
2636         (-[SettingsController visualViewportEnabled]): Deleted.
2637         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
2638         * MiniBrowser/mac/WK1BrowserWindowController.m:
2639         (-[WK1BrowserWindowController didChangeSettings]):
2640         * MiniBrowser/mac/WK2BrowserWindowController.m:
2641         (-[WK2BrowserWindowController didChangeSettings]):
2642
2643 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
2644
2645         Discard cached processes when clearing website data store
2646         https://bugs.webkit.org/show_bug.cgi?id=194894
2647
2648         Reviewed by Chris Dumez.
2649
2650         Added a test case.
2651
2652         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2653         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
2654
2655 2019-02-21  Alex Christensen  <achristensen@webkit.org>
2656
2657         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
2658         https://bugs.webkit.org/show_bug.cgi?id=194914
2659         <rdar://problem/47586889>
2660
2661         Reviewed by Geoffrey Garen.
2662
2663         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2664         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
2665         (TEST):
2666         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
2667
2668 2019-02-21  David Kilzer  <ddkilzer@apple.com>
2669
2670         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
2671         <https://webkit.org/b/194761>
2672
2673         Reviewed by Myles Maxfield.
2674
2675         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2676         (WTR::activateSystemCoreWebFonts): Log `error` to console if
2677         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
2678         to use ARC-compliant cast.
2679         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
2680         ARC-compliant cast.
2681         (WTR::installFakeHelvetica): Log `error` to console if
2682         CTFontManagerRegisterFontsForURL() fails, but only on supported
2683         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
2684         Call CFRelease() on `error` to fix the leak.  Update to use
2685         ARC-compliant cast.
2686         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
2687         cast.
2688
2689 2019-02-21  Chris Dumez  <cdumez@apple.com>
2690
2691         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
2692         https://bugs.webkit.org/show_bug.cgi?id=194481
2693
2694         Reviewed by Alex Christensen.
2695
2696         Give the processes a chance to shutdown and wait until we reached the expected number
2697         of processes.
2698
2699         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2700
2701 2019-02-21  Tim Horton  <timothy_horton@apple.com>
2702
2703         Fix the macOS build
2704
2705         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2706
2707 2019-02-21  Tim Horton  <timothy_horton@apple.com>
2708
2709         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
2710
2711         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2712         I am a backwards.
2713
2714 2019-02-21  Tim Horton  <timothy_horton@apple.com>
2715
2716         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
2717
2718         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2719         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
2720         We could force on UI-side compositing, but I feel like the test might be more
2721         valuable exercising the normal path on each platform (though the original
2722         bug was also UI-side specific). Though we can't validate that the overlay
2723         layer was installed successfully, there are layout tests that do that.
2724
2725 2019-02-21  Tim Horton  <timothy_horton@apple.com>
2726
2727         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
2728         https://bugs.webkit.org/show_bug.cgi?id=194845
2729         <rdar://problem/47944579>
2730
2731         Reviewed by Antti Koivisto.
2732
2733         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2734         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2735
2736 2019-02-21  Zalan Bujtas  <zalan@apple.com>
2737
2738         [LFC][Floats] Add support for placing formatting roots in-between floats.
2739         https://bugs.webkit.org/show_bug.cgi?id=194902
2740
2741         Reviewed by Antti Koivisto.
2742
2743         * LayoutReloaded/misc/LFC-passing-tests.txt:
2744
2745 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
2746
2747         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
2748         https://bugs.webkit.org/show_bug.cgi?id=194901
2749
2750         Unreviewed build fix.
2751
2752         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
2753         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
2754         WPEBackend-fdo-0.1 as library name.
2755
2756 2019-02-21  Rob Buis  <rbuis@igalia.com>
2757
2758         Update MIME type parser
2759         https://bugs.webkit.org/show_bug.cgi?id=180526
2760
2761         Reviewed by Darin Adler.
2762
2763         Add tests involving leading and trailing whitespace, non-token
2764         characters and quoted strings.
2765
2766         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
2767         (TestWebKitAPI::TEST):
2768
2769 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
2770
2771         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
2772         https://bugs.webkit.org/show_bug.cgi?id=194884
2773
2774         Reviewed by Michael Catanzaro.
2775
2776         * PlatformWin.cmake:
2777
2778 2019-02-20  Chris Dumez  <cdumez@apple.com>
2779
2780         Add API test for <rdar://problem/47471222>
2781         https://bugs.webkit.org/show_bug.cgi?id=194847
2782
2783         Reviewed by Alex Christensen.
2784
2785         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2786
2787 2019-02-20  Chris Dumez  <cdumez@apple.com>
2788
2789         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
2790         https://bugs.webkit.org/show_bug.cgi?id=194872
2791         <rdar://problem/47924500>
2792
2793         Reviewed by Alex Christensen.
2794
2795         Add API test coverage.
2796
2797         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2798
2799 2019-02-20  Jer Noble  <jer.noble@apple.com>
2800
2801         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
2802         https://bugs.webkit.org/show_bug.cgi?id=191332
2803
2804         Reviewed by Dean Jackson.
2805
2806         * Scripts/git-is-in-range: Added.
2807
2808 2019-02-20  Andy Estes  <aestes@apple.com>
2809
2810         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
2811         https://bugs.webkit.org/show_bug.cgi?id=194869
2812
2813         Rubber-stamped by Jer Noble.
2814
2815         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2816         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
2817         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2818         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
2819         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2820         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2821
2822 2019-02-20  Chris Dumez  <cdumez@apple.com>
2823
2824         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
2825         https://bugs.webkit.org/show_bug.cgi?id=194857
2826         <rdar://problem/47759323>
2827
2828         Reviewed by Alex Christensen.
2829
2830         Add API test coverage.
2831
2832         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2833
2834 2019-02-20  Chris Dumez  <cdumez@apple.com>
2835
2836         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
2837         https://bugs.webkit.org/show_bug.cgi?id=194829
2838         <rdar://problem/47889906>
2839
2840         Reviewed by Alexey Proskuryakov.
2841
2842         Every time the TestOptions were changing we were creating both a new Web view and
2843         a new WKContext, which would start a new Network process. In most cases, we only
2844         need to contruct a new Web view and we do can keep reusing the same WKContext.
2845         This patch implements this optimization and thus avoids spinning a lot of new
2846         Network processes while running the layout tests.
2847
2848         * WebKitTestRunner/TestController.cpp:
2849         (WTR::TestController::generateContextConfiguration const):
2850         (WTR::TestController::generatePageConfiguration):
2851         (WTR::TestController::createWebViewWithOptions):
2852         (WTR::TestController::resetPreferencesToConsistentValues):
2853         (WTR::updateTestOptionsFromTestHeader):
2854         * WebKitTestRunner/TestController.h:
2855         * WebKitTestRunner/TestOptions.h:
2856         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
2857         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
2858         (WTR::TestOptions::hasSameInitializationOptions const):
2859         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
2860         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2861         (WTR::TestController::platformAddTestOptions const):
2862
2863 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
2864
2865         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
2866         https://bugs.webkit.org/show_bug.cgi?id=167941
2867
2868         Reviewed by Carlos Garcia Campos.
2869
2870         * MiniBrowser/gtk/main.c:
2871         (filterSavedCallback): Added.
2872         (main): Support loading a JSON rule set file for content filtering.
2873         * MiniBrowser/wpe/main.cpp:
2874         (filterSavedCallback): Added.
2875         (main): Support loading a JSON rule set file for content filtering.
2876         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
2877         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
2878         (WTF::derefGPtr): Ditto.
2879         (testEmptyStore):
2880         (testSaveInvalidFilter):
2881         (testSaveLoadFilter):
2882         (testSavedFilterIdentifierMatch):
2883         (testRemoveFilter):
2884         (testSaveMultipleFilters):
2885         (testSaveFilterFromFile):
2886         (testFilterPersistence):
2887         (beforeAll):
2888         (afterAll):
2889         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
2890         (removeOldInjectedContentAndResetLists): Also reset content filters.
2891         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
2892         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
2893         the element affected by the style sheet.
2894         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
2895         and returns it to be used by tests.
2896         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
2897         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
2898         (serverCallback): Add support for serving a CSS style sheet for testing.
2899         (beforeAll): Add call to testUserContentManagerContentFilter().
2900         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
2901
2902 2019-02-19  Keith Rollin  <krollin@apple.com>
2903
2904         Add timing information to build output
2905         https://bugs.webkit.org/show_bug.cgi?id=194839
2906         <rdar://problem/48219609>
2907
2908         Reviewed by Alexey Proskuryakov.
2909
2910         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
2911         emit each project's build time to its output. E.g.,
2912
2913             ** BUILD SUCCEEDED ** [0.132 sec]
2914
2915         * Scripts/webkitdirs.pm:
2916         (XcodeOptions):
2917
2918 2019-02-19  Truitt Savell  <tsavell@apple.com>
2919
2920         Unreviewed, rolling out r241784.
2921
2922         Broke all OpenSource builds.
2923
2924         Reverted changeset:
2925
2926         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
2927         instances view"
2928         https://bugs.webkit.org/show_bug.cgi?id=172848
2929         https://trac.webkit.org/changeset/241784
2930
2931 2019-02-19  Zalan Bujtas  <zalan@apple.com>
2932
2933         [LFC][Floats] Remove redundant intersecting logic
2934         https://bugs.webkit.org/show_bug.cgi?id=194804
2935
2936         Reviewed by Antti Koivisto.
2937
2938         * LayoutReloaded/misc/LFC-passing-tests.txt:
2939
2940 2019-02-19  Dean Jackson  <dino@apple.com>
2941
2942         Clean-up output from generate-xcfilelists so it can be filtered
2943         https://bugs.webkit.org/show_bug.cgi?id=194795
2944
2945         Reviewed by Joseph Pecoraro (and Keith Rollin).
2946
2947         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
2948         make a slight tweak to filter-build-webkit so such lines are marked
2949         as plain.
2950
2951         * Scripts/filter-build-webkit:
2952         * Scripts/generate-xcfilelists:
2953
2954 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
2955
2956         pytest is not correctly auto-installed
2957         https://bugs.webkit.org/show_bug.cgi?id=194707
2958
2959         Reviewed by Carlos Garcia Campos.
2960
2961         * Scripts/webkitpy/thirdparty/__init__.py:
2962         (AutoinstallImportHook._install_pytest):
2963
2964 2019-02-18  Chris Dumez  <cdumez@apple.com>
2965
2966         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
2967         https://bugs.webkit.org/show_bug.cgi?id=194797
2968         <rdar://problem/48055151>
2969
2970         Reviewed by Geoffrey Garen.
2971
2972         Add API test coverage.
2973
2974         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2975
2976 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2977
2978         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
2979         https://bugs.webkit.org/show_bug.cgi?id=194670
2980         <rdar://problem/39066529>
2981
2982         Reviewed by Tim Horton.
2983
2984         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
2985         pasted in an editable area as attachment elements.
2986
2987         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
2988         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2989         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
2990         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2991         (TestWebKitAPI::TEST):
2992         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2993         (WTR::InjectedBundlePage::InjectedBundlePage):
2994
2995 2019-02-18  Alex Christensen  <achristensen@webkit.org>
2996
2997         Fix API test after r241728
2998        ​https://bugs.webkit.org/show_bug.cgi?id=194723
2999
3000         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3001         (TEST):
3002         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
3003
3004 2019-02-18  Daniel Bates  <dabates@apple.com>
3005
3006         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
3007         https://bugs.webkit.org/show_bug.cgi?id=192824
3008         <rdar://problem/47100332>
3009
3010         Reviewed by Wenson Hsieh.
3011
3012         Fix a bug where the wrong usage code was used for F13 thru F24.
3013
3014         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3015         (keyCodeForDOMFunctionKey):
3016
3017 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
3018
3019         Bytecode cache should a have a boot-specific validation
3020         https://bugs.webkit.org/show_bug.cgi?id=194769
3021         <rdar://problem/48149509>
3022
3023         Reviewed by Keith Miller.
3024
3025         Add test for WTF::bootSessionUUIDString()
3026
3027         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3028         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
3029         (TEST):
3030
3031 2019-02-18  Alex Christensen  <achristensen@webkit.org>
3032
3033         Disable safe browsing in WKWebView and remove its WKPreferences API
3034         https://bugs.webkit.org/show_bug.cgi?id=194723
3035         <rdar://problem/48122993>
3036
3037         Reviewed by Geoffrey Garen.
3038
3039         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3040         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3041         (TEST):
3042         (safeBrowsingView):
3043         Make tests use SPI instead of API.
3044
3045 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
3046
3047         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
3048         https://bugs.webkit.org/show_bug.cgi?id=194586
3049
3050         Reviewed by Ross Kirsling.
3051
3052         * DumpRenderTree/win/DumpRenderTree.cpp:
3053         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
3054         * Scripts/webkitpy/port/driver.py:
3055         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
3056
3057 2019-02-17  David Kilzer  <ddkilzer@apple.com>
3058
3059         Unreviewed, rolling out r241620.
3060
3061         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
3062         (Requested by ddkilzer on #webkit.)
3063
3064         Reverted changeset:
3065
3066         "[WTF] Add environment variable helpers"
3067         https://bugs.webkit.org/show_bug.cgi?id=192405
3068         https://trac.webkit.org/changeset/241620
3069
3070 2019-02-16  Zalan Bujtas  <zalan@apple.com>
3071
3072         [LFC] RenderImage's default intrinsic size is 0.
3073         https://bugs.webkit.org/show_bug.cgi?id=194745
3074
3075         Reviewed by Antti Koivisto.
3076
3077         * LayoutReloaded/misc/LFC-passing-tests.txt:
3078
3079 2019-02-16  Zalan Bujtas  <zalan@apple.com>
3080
3081         [LFC][BFC] Add support for block replaced intrinsic width.
3082         https://bugs.webkit.org/show_bug.cgi?id=194705
3083
3084         Reviewed by Simon Fraser.
3085
3086         * LayoutReloaded/misc/LFC-passing-tests.txt:
3087
3088 2019-02-16  Zalan Bujtas  <zalan@apple.com>
3089
3090         [LFC] Apply min/max width constraints to preferred width computation
3091         https://bugs.webkit.org/show_bug.cgi?id=194739
3092
3093         Reviewed by Simon Fraser.
3094
3095         * LayoutReloaded/misc/LFC-passing-tests.txt:
3096
3097 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
3098
3099         [WTF] Add environment variable helpers
3100         https://bugs.webkit.org/show_bug.cgi?id=192405
3101
3102         Reviewed by Michael Catanzaro.
3103
3104         * DumpRenderTree/mac/DumpRenderTree.mm:
3105         (libraryPathForDumpRenderTree):
3106         * DumpRenderTree/win/DumpRenderTree.cpp:
3107         (libraryPathForDumpRenderTree):
3108         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
3109         (setUpIOSLayoutTestCommunication):
3110         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
3111         (beforeAll):
3112         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
3113         (main):
3114         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
3115         (WebKitTestBus::run):
3116         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3117         (WTR::getOutputDir):
3118         (WTR::initializeFontConfigSetting):
3119         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
3120         (WTR::InjectedBundle::platformInitialize):
3121         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
3122         (WTR::topLevelPath):
3123         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
3124         (WTR::topLevelPath):
3125         (WTR::getOutputDir):
3126         (WTR::activateFonts):
3127         * WebKitTestRunner/TestController.cpp:
3128         (WTR::TestController::libraryPathForTesting):
3129         (WTR::TestController::generateContextConfiguration const):
3130         (WTR::TestController::generatePageConfiguration):
3131         (WTR::TestController::decideDestinationWithSuggestedFilename):
3132         (WTR::TestController::platformAdjustContext):
3133         * WebKitTestRunner/TestController.h:
3134         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3135         (WTR::TestController::cocoaPlatformInitialize):
3136         (WTR::TestController::platformAdjustContext):
3137         * WebKitTestRunner/gtk/main.cpp:
3138         (main):
3139         * WebKitTestRunner/mac/TestControllerMac.mm:
3140         (WTR::TestController::configureContentExtensionForTest):
3141         * WebKitTestRunner/wpe/main.cpp:
3142         (main):
3143         Utilize WTF::Environment where possible.
3144
3145 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3146
3147         [iOS] WKWebView callout bar is missing Change Writing Direction item
3148         https://bugs.webkit.org/show_bug.cgi?id=190015
3149         <rdar://problem/44810366>
3150
3151         Reviewed by Tim Horton.
3152
3153         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
3154         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
3155
3156         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
3157         (TestWebKitAPI::TEST):
3158
3159 2019-02-15  Chris Dumez  <cdumez@apple.com>
3160
3161         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
3162         https://bugs.webkit.org/show_bug.cgi?id=194717
3163         <rdar://problem/47884404>
3164
3165         Reviewed by Brady Eidson.
3166
3167         Add API test coverage.
3168
3169         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3170
3171 2019-02-15  Youenn Fablet  <youenn@apple.com>
3172
3173         Make navigator.mediaDevices SecureContext
3174         https://bugs.webkit.org/show_bug.cgi?id=194666
3175
3176         Reviewed by Eric Carlson.
3177
3178         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
3179         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
3180         (TEST_F):
3181
3182 2019-02-15  Brian Burg  <bburg@apple.com>
3183
3184         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
3185         https://bugs.webkit.org/show_bug.cgi?id=194411
3186         <rdar://problem/47787614>
3187
3188         Reviewed by Joseph Pecoraro.
3189
3190         Remove unnecessary soft linking macro usage.
3191
3192         * DumpRenderTree/mac/TestRunnerMac.mm:
3193         (TestRunner::inspectorTestStubURL):
3194         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
3195         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
3196         (WTR::TestRunner::inspectorTestStubURL):
3197
3198 2019-02-15  Commit Queue  <commit-queue@webkit.org>
3199
3200         Unreviewed, rolling out r241559 and r241566.
3201         https://bugs.webkit.org/show_bug.cgi?id=194710
3202
3203         Causes layout test crashes under GuardMalloc (Requested by
3204         ryanhaddad on #webkit).
3205
3206         Reverted changesets:
3207
3208         "[WTF] Add environment variable helpers"
3209         https://bugs.webkit.org/show_bug.cgi?id=192405
3210         https://trac.webkit.org/changeset/241559
3211
3212         "Unreviewed build fix for WinCairo Debug after r241559."
3213         https://trac.webkit.org/changeset/241566
3214
3215 2019-02-15  Zalan Bujtas  <zalan@apple.com>
3216
3217         [LFC] Out-of-flow box is never a float box
3218         https://bugs.webkit.org/show_bug.cgi?id=194704
3219
3220         Reviewed by Antti Koivisto.
3221
3222         * LayoutReloaded/misc/LFC-passing-tests.txt:
3223
3224 2019-02-10  Darin Adler  <darin@apple.com>
3225
3226         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
3227         https://bugs.webkit.org/show_bug.cgi?id=194487
3228
3229         Reviewed by Daniel Bates.
3230
3231         * DumpRenderTree/win/DumpRenderTree.cpp:
3232         (applicationId): Use makeString instead of String::format.
3233         (main): Ditto.
3234         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3235         (TestWebKitAPI::Util::createURLForResource): Ditto.
3236         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
3237         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
3238
3239         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3240         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
3241         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
3242         (WTR::createStringWithAttributes): Use appendLiteral.
3243         (WTR::AccessibilityUIElement::helpText const): Ditto.
3244         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
3245         directly instead of using String::format.
3246         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
3247         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
3248
3249 2019-02-15  Truitt Savell  <tsavell@apple.com>
3250
3251         Unreviewed, rolling out r241564.
3252
3253         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
3254
3255         Reverted changeset:
3256
3257         "[Mac] WebInspectorUI.framework does not need to be soft-
3258         linked anymore"
3259         https://bugs.webkit.org/show_bug.cgi?id=194411
3260         https://trac.webkit.org/changeset/241564
3261
3262 2019-02-15  Saam barati  <sbarati@apple.com>
3263
3264         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
3265         https://bugs.webkit.org/show_bug.cgi?id=194036
3266
3267         Reviewed by Yusuke Suzuki.
3268
3269         * Scripts/run-jsc-stress-tests:
3270
3271 2019-02-14  Tim Horton  <timothy_horton@apple.com>
3272
3273         Fix the build.
3274
3275         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3276         (WTR::UIScriptController::drawSquareInEditableImage):
3277         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3278         (TestWebKitAPI::drawSquareInEditableImage):
3279
3280 2019-02-14  Tim Horton  <timothy_horton@apple.com>
3281
3282         Fix the build.
3283
3284         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3285         (WTR::UIScriptController::drawSquareInEditableImage):
3286         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3287         (TestWebKitAPI::drawSquareInEditableImage):
3288
3289 2019-02-14  Brian Burg  <bburg@apple.com>
3290
3291         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
3292         https://bugs.webkit.org/show_bug.cgi?id=194411
3293         <rdar://problem/47787614>
3294
3295         Reviewed by Joseph Pecoraro.
3296
3297         Remove unnecessary soft linking macro usage.
3298
3299         * DumpRenderTree/mac/TestRunnerMac.mm:
3300         (TestRunner::inspectorTestStubURL):
3301         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
3302         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
3303         (WTR::TestRunner::inspectorTestStubURL):
3304
3305 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
3306
3307         [ews-app] status bubble should fetch builder name info from BuilderMapping table
3308         https://bugs.webkit.org/show_bug.cgi?id=194599
3309
3310         Reviewed by Lucas Forschler.
3311
3312         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3313         (StatusBubble._build_bubble):
3314
3315 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
3316
3317         [ews-app] Set Foreign Key in Django build model
3318         https://bugs.webkit.org/show_bug.cgi?id=194667
3319
3320         Reviewed by Lucas Forschler.
3321
3322         * BuildSlaveSupport/ews-app/ews/models/build.py:
3323         (Build):
3324
3325 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
3326
3327         [WTF] Add environment variable helpers
3328         https://bugs.webkit.org/show_bug.cgi?id=192405
3329
3330         Reviewed by Michael Catanzaro.
3331
3332         * DumpRenderTree/mac/DumpRenderTree.mm:
3333         (libraryPathForDumpRenderTree):
3334         * DumpRenderTree/win/DumpRenderTree.cpp:
3335         (libraryPathForDumpRenderTree):
3336         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
3337         (setUpIOSLayoutTestCommunication):
3338         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3339         (TestWebKitAPI::strip):
3340         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
3341         (beforeAll):
3342         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
3343         (main):
3344         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
3345         (WebKitTestBus::run):
3346         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3347         (WTR::getOutputDir):
3348         (WTR::initializeFontConfigSetting):
3349         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
3350         (WTR::InjectedBundle::platformInitialize):
3351         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
3352         (WTR::topLevelPath):
3353         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
3354         (WTR::topLevelPath):
3355         (WTR::getOutputDir):
3356         (WTR::activateFonts):
3357         * WebKitTestRunner/TestController.cpp:
3358         (WTR::TestController::libraryPathForTesting):
3359         (WTR::TestController::generateContextConfiguration const):
3360         (WTR::TestController::generatePageConfiguration):
3361         (WTR::TestController::decideDestinationWithSuggestedFilename):
3362         (WTR::TestController::platformAdjustContext):
3363         * WebKitTestRunner/TestController.h:
3364         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3365         (WTR::TestController::cocoaPlatformInitialize):
3366         (WTR::TestController::platformAdjustContext):
3367         * WebKitTestRunner/gtk/main.cpp:
3368         (main):
3369         * WebKitTestRunner/mac/TestControllerMac.mm:
3370         (WTR::TestController::configureContentExtensionForTest):
3371         * WebKitTestRunner/wpe/main.cpp:
3372         (main):
3373         Utilize WTF::Environment where possible.
3374
3375 2019-02-14  Chris Dumez  <cdumez@apple.com>
3376
3377         [PSON] Introduce a WebContent Process cache
3378         https://bugs.webkit.org/show_bug.cgi?id=194594
3379         <rdar://problem/46793397>
3380
3381         Reviewed by Geoff Garen.
3382
3383         Update API tests to turn on the WebContent Process cache.
3384
3385         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3386
3387 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
3388
3389         Unreviewed, build fix after r241480
3390
3391         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3392         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
3393         (-[DragAndDropSimulator initWithWebView:]):
3394
3395 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
3396
3397         AX: ARIA Reflection was disabled in error
3398         https://bugs.webkit.org/show_bug.cgi?id=194647
3399         <rdar://problem/48068336>
3400
3401         Reviewed by Ryosuke Niwa.
3402
3403         Remove test override now that this feature should be enabled by default.
3404
3405         * WebKitTestRunner/TestController.cpp:
3406         (WTR::TestController::resetPreferencesToConsistentValues):
3407
3408 2019-02-14  Commit Queue  <commit-queue@webkit.org>
3409
3410         Unreviewed, rolling out r241486.
3411         https://bugs.webkit.org/show_bug.cgi?id=194655
3412
3413         causing API failures in builds (Requested by ShawnRoberts on
3414         #webkit).
3415
3416         Reverted changeset:
3417
3418         "[Cocoa] Media elements will restart network buffering just
3419         before suspending"
3420         https://bugs.webkit.org/show_bug.cgi?id=193691
3421         https://trac.webkit.org/changeset/241486
3422
3423 2019-02-14  Zalan Bujtas  <zalan@apple.com>
3424
3425         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
3426         https://bugs.webkit.org/show_bug.cgi?id=194622
3427
3428         Reviewed by Antti Koivisto.
3429
3430         * LayoutReloaded/misc/LFC-passing-tests.txt:
3431
3432 2019-02-14  Zalan Bujtas  <zalan@apple.com>
3433
3434         [LFC] Shrink-to-fit-width should be constrained by min/max width
3435         https://bugs.webkit.org/show_bug.cgi?id=194653
3436
3437         Reviewed by Antti Koivisto.
3438
3439         * LayoutReloaded/misc/LFC-passing-tests.txt:
3440
3441 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
3442
3443         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
3444         https://bugs.webkit.org/show_bug.cgi?id=194641
3445
3446         Reviewed by Geoffrey Garen.
3447
3448         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
3449         so that the test would fail without this fix.
3450
3451         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
3452         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
3453
3454 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
3455
3456         [ews-app] Change log level for a log statement
3457
3458         Unreviewed minor fix.
3459
3460         * BuildSlaveSupport/ews-app/ews/models/patch.py:
3461         (Patch.save_patch):
3462
3463 2019-02-13  Jer Noble  <jer.noble@apple.com>
3464
3465         [Cocoa] Media elements will restart network buffering just before suspending
3466         https://bugs.webkit.org/show_bug.cgi?id=193691
3467
3468         Reviewed by Eric Carlson.
3469
3470         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3471         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
3472         (TEST):
3473
3474 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
3475
3476         [ews-app] Fetch builder id to name mapping
3477         https://bugs.webkit.org/show_bug.cgi?id=194355
3478
3479         Reviewed by Lucas Forschler.
3480
3481         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
3482         (Buildbot.get_builder_id_to_name_mapping):
3483         (Buildbot._get_display_name_from_builder_name):
3484
3485 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
3486
3487         Further restricting webarchive loads
3488         https://bugs.webkit.org/show_bug.cgi?id=194567
3489         <rdar://problem/47610130>
3490
3491         Reviewed by Youenn Fablet.
3492
3493         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
3494         navigations on drop.
3495
3496         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3497         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
3498         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
3499         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
3500         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3501         (TestWebKitAPI::TEST):
3502         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
3503         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
3504         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
3505         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
3506         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
3507         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
3508         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
3509
3510 2019-02-13  John Wilander  <wilander@apple.com>
3511
3512         Store Ad Click Attribution requests in the network process
3513         https://bugs.webkit.org/show_bug.cgi?id=194510
3514         <rdar://problem/47650118>
3515
3516         Reviewed by Alex Christensen and Daniel Bates.
3517
3518         This patch adds two TestRunner functions:
3519         - dumpAdClickAttribution()
3520         - clearAdClickAttribution()
3521
3522         They call into the network process to dump and clear Ad Click
3523         Attribution state, respectively.
3524
3525         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3526         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3527         (WTR::TestRunner::dumpAdClickAttribution):
3528         (WTR::TestRunner::clearAdClickAttribution):
3529         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3530         * WebKitTestRunner/TestController.cpp:
3531         (WTR::TestController::resetStateToConsistentValues):
3532         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
3533         (WTR::adClickAttributionStringResultCallback):
3534         (WTR::TestController::dumpAdClickAttribution):
3535         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
3536         (WTR::adClickAttributionVoidCallback):
3537         (WTR::TestController::clearAdClickAttribution):
3538         * WebKitTestRunner/TestController.h:
3539         * WebKitTestRunner/TestInvocation.cpp:
3540         (WTR::TestInvocation::dumpResults):
3541         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3542         (WTR::TestInvocation::dumpAdClickAttribution):
3543         * WebKitTestRunner/TestInvocation.h:
3544
3545 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
3546
3547         [ews-app] Generate status-bubble
3548         https://bugs.webkit.org/show_bug.cgi?id=194572
3549
3550         Reviewed by Lucas Forschler.
3551
3552         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3553         (StatusBubble._build_bubble):
3554         (StatusBubble._should_show_bubble_for):
3555         (StatusBubble._build_bubbles_for_patch):
3556
3557 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
3558
3559         [ews-app] Add status bubble html template
3560         https://bugs.webkit.org/show_bug.cgi?id=194571
3561
3562         Reviewed by Lucas Forschler.
3563
3564         * BuildSlaveSupport/ews-app/ews/templates: Added.
3565         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
3566
3567 2019-02-12  Chris Dumez  <cdumez@apple.com>
3568
3569         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
3570         https://bugs.webkit.org/show_bug.cgi?id=194568
3571         <rdar://problem/47944490>
3572
3573         Reviewed by Ryosuke Niwa.
3574
3575         Add API test coverage.
3576
3577         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3578         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
3579
3580 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
3581
3582         webkitpy: Remove bug_dummy from parsed test expectations
3583         https://bugs.webkit.org/show_bug.cgi?id=194562
3584         <rdar://problem/47853999>
3585
3586         Reviewed by Lucas Forschler.
3587
3588         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3589         (TestExpectationParser):
3590         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
3591         skipped tests.
3592         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3593
3594 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
3595
3596         [ews-app] Add method to fetch patch
3597         https://bugs.webkit.org/show_bug.cgi?id=194518
3598
3599         Reviewed by Lucas Forschler.
3600
3601         * BuildSlaveSupport/ews-app/ews/models/patch.py:
3602         (Patch.get_patch):
3603
3604 2019-02-12  Zalan Bujtas  <zalan@apple.com>
3605
3606         [LFC] Expand tests coverage (60 new tests -> 860)
3607
3608         Unreviewed test gardening (run-singly, --child-processes=1).
3609
3610         * LayoutReloaded/misc/LFC-passing-tests.txt:
3611
3612 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
3613
3614         Allow pages to trigger programmatic paste from script on iOS
3615         https://bugs.webkit.org/show_bug.cgi?id=194271
3616         <rdar://problem/47808810>
3617
3618         Reviewed by Tim Horton.
3619
3620         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
3621
3622         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3623         (WTR::UIScriptController::platformSetDidShowMenuCallback):
3624         (WTR::UIScriptController::platformSetDidHideMenuCallback):
3625         (WTR::UIScriptController::rectForMenuAction const):
3626
3627         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
3628         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
3629         for when the menu is shown or hidden.
3630
3631         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3632         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
3633         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3634         (WTR::UIScriptController::setDidShowMenuCallback):
3635         (WTR::UIScriptController::didShowMenuCallback const):
3636         (WTR::UIScriptController::setDidHideMenuCallback):
3637         (WTR::UIScriptController::didHideMenuCallback const):
3638         (WTR::UIScriptController::platformSetDidShowMenuCallback):
3639         (WTR::UIScriptController::platformSetDidHideMenuCallback):
3640         (WTR::UIScriptController::rectForMenuAction const):
3641         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3642         * WebKitTestRunner/TestController.cpp:
3643         (WTR::TestController::resetPreferencesToConsistentValues):
3644         (WTR::updateTestOptionsFromTestHeader):
3645         * WebKitTestRunner/TestOptions.h:
3646
3647         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
3648         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
3649
3650         (WTR::TestOptions::hasSameInitializationOptions const):
3651         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3652         (WTR::UIScriptController::calendarType const):
3653         (WTR::UIScriptController::platformUndoManager const):
3654         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3655         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3656         (-[TestRunnerWKWebView initWithFrame:configuration:]):
3657         (-[TestRunnerWKWebView dealloc]):
3658         (-[TestRunnerWKWebView _didShowMenu]):
3659         (-[TestRunnerWKWebView _didHideMenu]):
3660
3661         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
3662
3663         * WebKitTestRunner/ios/TestControllerIOS.mm:
3664         (WTR::handleMenuWillHideNotification):
3665         (WTR::handleMenuDidHideNotification):
3666         (WTR::TestController::platformInitialize):
3667         (WTR::TestController::platformDestroy):
3668         (WTR::TestController::platformResetStateToConsistentValues):
3669
3670         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
3671         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
3672
3673         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3674         (WTR::forEachViewInHierarchy):
3675         (WTR::findViewInHierarchyOfType):
3676
3677         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
3678         functions that dig through a given view's hierarchy in search of a view of a given class.
3679
3680         (WTR::UIScriptController::selectionStartGrabberViewRect const):
3681         (WTR::UIScriptController::selectionEndGrabberViewRect const):
3682         (WTR::UIScriptController::selectionCaretViewRect const):
3683         (WTR::UIScriptController::selectionRangeViewRects const):
3684         (WTR::UIScriptController::platformSetDidShowMenuCallback):
3685         (WTR::UIScriptController::platformSetDidHideMenuCallback):
3686
3687         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
3688
3689         (WTR::UIScriptController::rectForMenuAction const):
3690
3691         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
3692         callout bar) whose label matches the given string.
3693
3694         (WTR::UIScriptController::platformContentView const):
3695
3696         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
3697         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
3698         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
3699
3700         (WTR::UIScriptController::platformUndoManager const): Deleted.
3701         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3702         (WTR::UIScriptController::platformContentView const):
3703         (WTR::UIScriptController::platformUndoManager const): Deleted.
3704
3705 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
3706
3707         webkitpy: No option to only show unexpected failures in results.html for iPad
3708         https://bugs.webkit.org/show_bug.cgi?id=194554
3709         <rdar://problem/47922442>
3710
3711         Rubber-stamped by Aakash Jain.
3712
3713         Just because a TestExpecations file does not exist for a specific platform does not mean that
3714         TestExpecations are not being used, given that platforms inherit test expectations.
3715
3716         * Scripts/webkitpy/port/base.py:
3717         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
3718         * Scripts/webkitpy/port/base_unittest.py:
3719         (PortTest.test_uses_test_expectations_file):
3720
3721 2019-02-12  Alex Christensen  <achristensen@webkit.org>
3722
3723         Remove setDefersLoading infrastructure from WebKit2
3724         https://bugs.webkit.org/show_bug.cgi?id=194506
3725
3726         Reviewed by Brady Eidson.
3727
3728         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3729         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3730         (WTR::TestRunner::setDefersLoading): Deleted.
3731         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3732
3733 2019-02-12  Alex Christensen  <achristensen@webkit.org>
3734
3735         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
3736         https://bugs.webkit.org/show_bug.cgi?id=194522
3737         <rdar://problem/47789393>
3738
3739         Reviewed by Chris Dumez.
3740
3741         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3742         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
3743         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3744         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3745
3746 2019-02-12  Andy Estes  <aestes@apple.com>
3747
3748         [iOSMac] Enable Parental Controls Content Filtering
3749         https://bugs.webkit.org/show_bug.cgi?id=194521
3750         <rdar://39732376>
3751
3752         Reviewed by Tim Horton.
3753
3754         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3755
3756 2019-02-12  Zalan Bujtas  <zalan@apple.com>
3757
3758         [LFC][IFC] Add intrinsic width support for float boxes.
3759         https://bugs.webkit.org/show_bug.cgi?id=194528
3760
3761         Reviewed by Antti Koivisto.
3762
3763         Expand tests coverage (2 new tests -> 800).
3764         (This is the correct test ordering --runs-singly --child-processes=1)
3765
3766         * LayoutReloaded/misc/LFC-passing-tests.txt:
3767
3768 2019-02-12  Rob Buis  <rbuis@igalia.com>
3769
3770         Implement serializing in MIME type parser
3771         https://bugs.webkit.org/show_bug.cgi?id=193909
3772
3773         Reviewed by Darin Adler.
3774
3775         Add various tests involving upper case, non-ASCII, control/null characters,
3776         various HTTP whitespace, single quotes and an unpaired surrogate.
3777
3778         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
3779         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
3780         (TestWebKitAPI::serializeIfValid):
3781         (TestWebKitAPI::TEST):
3782
3783 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
3784
3785         [Cocoa] Ask platform for generic font family mappings
3786         https://bugs.webkit.org/show_bug.cgi?id=187723
3787         <rdar://problem/41892438>
3788
3789         Reviewed by Brent Fulgham.
3790
3791         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
3792
3793         * DumpRenderTree/mac/DumpRenderTree.mm:
3794         (allowedFontFamilySet):
3795         * WebKitTestRunner/mac/TestControllerMac.mm:
3796         (WTR::allowedFontFamilySet):
3797
3798 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
3799
3800         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
3801         https://bugs.webkit.org/show_bug.cgi?id=193622
3802
3803         Reviewed by Michael Catanzaro.
3804
3805         This adds support for loading content extension rule sets from the JSON files which
3806         accompany the corresponding layout test, using the C API. The Cocoa specific parts
3807         of WKTR for this could be removed, but that is left for a follow-up patch with
3808         cleanups.
3809
3810         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
3811         * WebKitTestRunner/TestController.cpp:
3812         (WTR::testPath): Subtract one from the length when constructing the result std::string to
3813         avoid having the null-terminator copied into the result.
3814         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
3815         part of the preparations to run a test.
3816         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
3817         (WTR::contentExtensionStoreCallback): Added.
3818         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
3819         used for content extensions test.
3820         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
3821         extensions and compiling the JSON rule set for tests involving content extensions.
3822         (WTR::TestController::resetContentExtensions): Removes the content extension built for
3823         testing and disables content extensions.
3824         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
3825         resetContentExtensions().
3826         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
3827         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
3828         configureContentExtensionForTest(), and userContentController().
3829
3830 2019-02-11  Daniel Bates  <dabates@apple.com>
3831
3832         [iOS] Mouse/Touch/Pointer events are missing modifier keys
3833         https://bugs.webkit.org/show_bug.cgi?id=191446
3834         <rdar://problem/45929460>
3835
3836         Reviewed by Tim Horton.
3837
3838         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
3839
3840         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3841         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
3842         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
3843         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3844         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3845         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
3846         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
3847         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3848         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3849         (WTR::arrayLength):
3850         (WTR::parseModifierArray):
3851         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
3852         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
3853         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
3854         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
3855
3856 2019-02-11  Commit Queue  <commit-queue@webkit.org>
3857
3858         Unreviewed, rolling out r241272 and r241276.
3859         https://bugs.webkit.org/show_bug.cgi?id=194514
3860
3861         Broke the Apple Internal build and the fix requires human
3862         intervention :( (Requested by dydz on #webkit).
3863
3864         Reverted changesets:
3865
3866         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
3867         https://bugs.webkit.org/show_bug.cgi?id=191446
3868         https://trac.webkit.org/changeset/241272
3869
3870         "Fix internal iOS build after r241272"
3871         https://bugs.webkit.org/show_bug.cgi?id=191446
3872         https://trac.webkit.org/changeset/241276
3873
3874 2019-02-11  Truitt Savell  <tsavell@apple.com>
3875
3876         Unreviewed, rolling out r241269.
3877
3878         Caused 5 layout tests crashes on Mac WK1
3879
3880         Reverted changeset:
3881
3882         "DumpRenderTree should report unknown options"
3883         https://bugs.webkit.org/show_bug.cgi?id=191303
3884         https://trac.webkit.org/changeset/241269
3885
3886 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3887
3888         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
3889         https://bugs.webkit.org/show_bug.cgi?id=194313
3890
3891         Reviewed by Tim Horton.
3892
3893         Add a helper to determine whether the web view is presenting modal UI.
3894
3895         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3896         (WTR::UIScriptController::isPresentingModally const):
3897         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3898         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3899         (WTR::UIScriptController::isPresentingModally const):
3900         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3901         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3902         (WTR::UIScriptController::calendarType const): Deleted.
3903         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3904         (WTR::UIScriptController::isPresentingModally const):
3905         (WTR::UIScriptController::calendarType const):
3906         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3907         (WTR::UIScriptController::calendarType const):
3908
3909 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
3910
3911         GCHeapInspector: Show the retained sizes in more places
3912         https://bugs.webkit.org/show_bug.cgi?id=194464
3913
3914         Reviewed by Simon Fraser.
3915
3916         * GCHeapInspector/gc-heap-inspector.html:
3917         * GCHeapInspector/script/interface.js:
3918         (HeapInspectorUtils.humanReadableSize):
3919         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
3920         (HeapInspectorUtils.spanForNode.span.span):
3921         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
3922         (HeapSnapshotInspector.prototype.buildRoots):
3923
3924 2019-02-11  Daniel Bates  <dabates@apple.com>
3925
3926         [iOS] Mouse/Touch/Pointer events are missing modifier keys
3927         https://bugs.webkit.org/show_bug.cgi?id=191446
3928         <rdar://problem/45929460>
3929
3930         Reviewed by Tim Horton.
3931
3932         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
3933
3934         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3935         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
3936         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
3937         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3938         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3939         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
3940         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
3941         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3942         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3943         (WTR::arrayLength):
3944         (WTR::parseModifierArray):
3945         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
3946         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
3947         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
3948         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
3949
3950 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
3951
3952         DumpRenderTree should report unknown options
3953         https://bugs.webkit.org/show_bug.cgi?id=191303
3954
3955         Reviewed by Frédéric Wang.
3956
3957         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
3958         to report unknown options.
3959         Added and assigned test options which are currently used in tests.
3960
3961         * DumpRenderTree/TestOptions.cpp:
3962         (TestOptions::TestOptions):
3963
3964 2019-02-11  Truitt Savell  <tsavell@apple.com>
3965
3966         Unreviewed, rolling out r241229.
3967
3968         Revision broke internal builds for watchOS.
3969
3970         Reverted changeset:
3971
3972         "[Cocoa] Ask platform for generic font family mappings"
3973         https://bugs.webkit.org/show_bug.cgi?id=187723
3974         https://trac.webkit.org/changeset/241229
3975
3976 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
3977
3978         [WinCairo][MiniBrowser] Basic authentication always fails.
3979         https://bugs.webkit.org/show_bug.cgi?id=194496
3980
3981         Reviewed by Don Olmstead.
3982
3983         * MiniBrowser/win/DialogHelper.h:
3984         (Dialog::getText):
3985
3986 2019-02-11  Philippe Normand  <pnormand@igalia.com>
3987
3988         [GStreamer] GstMappedBuffer testsuite build fails
3989         https://bugs.webkit.org/show_bug.cgi?id=194495
3990
3991         Reviewed by Carlos Garcia Campos.
3992
3993         Fix the build by explicitely adding the gstreamer1.0-audio include
3994         directories to the include path.
3995
3996         * TestWebKitAPI/PlatformGTK.cmake:
3997         * TestWebKitAPI/PlatformWPE.cmake:
3998
3999 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
4000
4001         [GTK][WPE] Add enable-javascript-markup setting
4002         https://bugs.webkit.org/show_bug.cgi?id=193439
4003
4004         Reviewed by Michael Catanzaro.
4005
4006         Add test cases to check the new setting.
4007
4008         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
4009         (testWebKitSettings):
4010         (testWebKitSettingsJavaScriptMarkup):
4011         (beforeAll):
4012
4013 2019-02-10  Darin Adler  <darin@apple.com>
4014
4015         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
4016         https://bugs.webkit.org/show_bug.cgi?id=194485
4017
4018         Reviewed by Daniel Bates.
4019
4020         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
4021
4022 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
4023
4024         Add more tests for clampTo<>()
4025         https://bugs.webkit.org/show_bug.cgi?id=194462
4026
4027         Reviewed by Geoffrey Garen.
4028
4029         Darin suggested to test the very last floating point number
4030         at the boundaries when truncating to integer.
4031         I added test for max/min and max-1/min-1.
4032
4033         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
4034         (TestWebKitAPI::TEST):
4035
4036 2019-02-09  Darin Adler  <darin@apple.com>
4037
4038         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
4039         https://bugs.webkit.org/show_bug.cgi?id=194021
4040
4041         Reviewed by Geoffrey Garen.
4042
4043         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
4044         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
4045         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
4046
4047 2019-02-09  Zalan Bujtas  <zalan@apple.com>
4048
4049         [LFC][IFC] Add intrinsic width support for basic inline containers
4050         https://bugs.webkit.org/show_bug.cgi?id=194473
4051
4052         Reviewed by Antti Koivisto.
4053
4054         Expand tests coverage (11 new tests -> 798)
4055
4056         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
4057
4058 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
4059
4060         Fix MiniBrowser's entitlements
4061         https://bugs.webkit.org/show_bug.cgi?id=192431
4062
4063         Reviewed by Joseph Pecoraro.
4064
4065         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
4066         files, making it impossible to load any extension.
4067
4068         * MiniBrowser/MiniBrowser.entitlements:
4069
4070 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
4071
4072         [Cocoa] Ask platform for generic font family mappings
4073         https://bugs.webkit.org/show_bug.cgi?id=187723
4074         <rdar://problem/41892438>
4075
4076         Reviewed by Brent Fulgham.
4077
4078         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
4079
4080         * DumpRenderTree/mac/DumpRenderTree.mm:
4081         (allowedFontFamilySet):
4082         * WebKitTestRunner/mac/TestControllerMac.mm:
4083         (WTR::allowedFontFamilySet):
4084
4085 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
4086
4087         [GTK] Implement back/forward touchpad gesture
4088         https://bugs.webkit.org/show_bug.cgi?id=193919
4089
4090         Reviewed by Michael Catanzaro.
4091
4092         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
4093         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
4094
4095 2019-02-08  Alex Christensen  <achristensen@webkit.org>
4096
4097         Add SPI to use networking daemon instead of XPC service
4098         https://bugs.webkit.org/show_bug.cgi?id=194427
4099
4100         Reviewed by Geoffrey Garen
4101
4102         * MiniBrowser/MiniBrowser.entitlements:
4103
4104 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
4105
4106         [ews-build] Ensure that every builder in config.json has short name
4107         https://bugs.webkit.org/show_bug.cgi?id=194461
4108
4109         Reviewed by Lucas Forschler.
4110
4111         * BuildSlaveSupport/ews-build/loadConfig.py:
4112         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
4113
4114 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
4115
4116         [ews-build] Add short name to config.json
4117         https://bugs.webkit.org/show_bug.cgi?id=194456
4118
4119         Reviewed by Lucas Forschler.
4120
4121         * BuildSlaveSupport/ews-build/config.json: Added short name.
4122         * BuildSlaveSupport/ews-build/loadConfig.py:
4123         (loadBuilderConfig): Set the short name as the builder description.
4124
4125 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
4126
4127         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
4128         https://bugs.webkit.org/show_bug.cgi?id=194418
4129
4130         Reviewed by Lucas Forschler.
4131
4132         Do not include errors trying when finding crashlogs at the end of
4133         a run-webkit-tests run since we don't process those errors.
4134
4135         * Scripts/webkitpy/port/darwin.py:
4136         (DarwinPort._look_for_all_crash_logs_in_log_dir):
4137         * Scripts/webkitpy/port/ios_device.py:
4138         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
4139         * Scripts/webkitpy/port/watch_device.py:
4140         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
4141
4142 2019-02-08  Beth Dakin  <bdakin@apple.com>
4143
4144         Add afterScreenUpdates to WKSnapshotConfiguration
4145         https://bugs.webkit.org/show_bug.cgi?id=194362
4146         -and corresponding-
4147         <rdar://problem/40655528> Please add an "after screen updates" property to 
4148         WKSnapshotConfiguration (to solve blank snapshots)
4149
4150         Reviewed by Tim Horton.
4151
4152         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
4153         (TEST):
4154
4155 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
4156
4157         clampTo(): do not convert the input to double when dealing with integers
4158         https://bugs.webkit.org/show_bug.cgi?id=194263
4159         <rdar://problem/47692312>
4160
4161         Reviewed by Darin Adler.
4162
4163         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
4164         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
4165         (TestWebKitAPI::testClampFloatingPointToInteger):
4166         (TestWebKitAPI::testClampSameSignIntegers):
4167         (TestWebKitAPI::testClampUnsignedToSigned):
4168         (TestWebKitAPI::testClampSignedToUnsigned):
4169
4170 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
4171
4172         webkitpy: Respect --dedicated-simulators flag
4173         https://bugs.webkit.org/show_bug.cgi?id=194416
4174         <rdar://problem/47894722>
4175
4176         Reviewed by Lucas Forschler.
4177
4178         * Scripts/webkitpy/port/device_port.py:
4179         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
4180         available devices can be safely ignored.
4181
4182 2019-02-07  Keith Rollin  <krollin@apple.com>
4183
4184         Remove extra copy of 100x100-red.tga
4185         https://bugs.webkit.org/show_bug.cgi?id=194371
4186         <rdar://problem/47873465>
4187
4188         Reviewed by Said Abou-Hallawa.
4189
4190         In order to help it pass its tests, Bug 194190 added a second copy of
4191         the file 100x100-red.tga. However, it turns out that this additional
4192         file wasn't actually needed, and that that sole previous copy was
4193         sufficient. At the same time, this second copy -- which was copied to
4194         the same location in the build output as the first copy -- now caused
4195         XCBuild to complain because there were two production rules for the
4196         same output file. Address this by removing the newly-added extra copy.
4197
4198         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4199         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
4200
4201 2019-02-07  Alex Christensen  <achristensen@webkit.org>
4202
4203         Deprecate WKBundlePageSetDefersLoading
4204         https://bugs.webkit.org/show_bug.cgi?id=191394
4205
4206         Reviewed by Dean Jackson.
4207
4208         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4209         (WTR::TestRunner::setDefersLoading):
4210
4211 2019-02-07  Zalan Bujtas  <zalan@apple.com>
4212
4213         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
4214         https://bugs.webkit.org/show_bug.cgi?id=194391
4215
4216         Reviewed by Antti Koivisto.
4217
4218         * LayoutReloaded/misc/LFC-passing-tests.txt:
4219
4220 2019-02-06  Keith Rollin  <krollin@apple.com>
4221
4222         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
4223         https://bugs.webkit.org/show_bug.cgi?id=193975
4224         <rdar://problem/47643306>
4225
4226         Reviewed by Tim Horton.
4227
4228         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
4229         the Info.plist file into the bundle. This step is not necessary as the
4230         implicit "bundle up all the build products into a framework" build
4231         phase does this already. Having the Copy Bundle Resources phase do
4232         this causes a conflict under XCBuild, which objects to two build
4233         phases producing the same file (Info.plist). Address this by removing
4234         Info.plist from the Copy Bundle Resources phase.
4235
4236         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
4237
4238 2019-02-06  Keith Rollin  <krollin@apple.com>
4239
4240         Really enable the automatic checking and regenerations of .xcfilelists during builds
4241         https://bugs.webkit.org/show_bug.cgi?id=194357
4242         <rdar://problem/47861231>
4243
4244         Reviewed by Chris Dumez.
4245
4246         Bug 194124 was supposed to enable the automatic checking and
4247         regenerating of .xcfilelist files during the build. While related
4248         changes were included in that patch, the change to actually enable the
4249         operation somehow was omitted. This patch actually enables the
4250         operation. The check-xcfilelist.sh scripts now check
4251         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
4252         from the checking.
4253
4254         * DumpRenderTree/Scripts/check-xcfilelists.sh:
4255         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
4256
4257 2019-02-06  David Kilzer  <ddkilzer@apple.com>
4258
4259         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
4260         <https://webkit.org/b/194286>
4261         <rdar://problem/47815558>
4262
4263         Reviewed by Alexey Proskuryakov.
4264
4265         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4266         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
4267         WKRetainPtr<> to avoid leaking the WKDataRef.
4268
4269 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
4270
4271         Unreviewed, fix a typo
4272
4273         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
4274
4275 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
4276
4277         [GTK][WPE] force libpsl build to use ICU in jhbuild
4278         https://bugs.webkit.org/show_bug.cgi?id=194288
4279
4280         Reviewed by Carlos Garcia Campos.
4281
4282         * gtk/jhbuild.modules:
4283         Require ICU for libpsl build in jhbuild, like done in WPE.
4284
4285 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
4286
4287         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
4288         https://bugs.webkit.org/show_bug.cgi?id=194209
4289
4290         Reviewed by Carlos Garcia Campos.
4291
4292         Enhance TestCookieManager to ensure this doesn't happen again.
4293
4294         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
4295         (testCookieManagerPersistentStorage):
4296         (beforeAll):
4297
4298 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
4299
4300         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
4301         https://bugs.webkit.org/show_bug.cgi?id=194324
4302
4303         Reviewed by Andy Estes.
4304
4305         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
4306         part of the name is already implicit, since this is in testing code in TestOptions.
4307
4308         * WebKitTestRunner/TestController.cpp:
4309         (WTR::TestController::generateContextConfiguration const):
4310         (WTR::updateTestOptionsFromTestHeader):
4311         * WebKitTestRunner/TestOptions.h:
4312         (WTR::TestOptions::hasSameInitializationOptions const):
4313
4314 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
4315
4316         [ews-build] Allow * as platform for builders and workers
4317         https://bugs.webkit.org/show_bug.cgi?id=188533
4318
4319         Reviewed by Lucas Forschler.
4320
4321         * BuildSlaveSupport/ews-build/loadConfig.py:
4322         (checkWorkersAndBuildersForConsistency):
4323
4324 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
4325
4326         [ews-build] Add few bots to config.json
4327         https://bugs.webkit.org/show_bug.cgi?id=194304
4328
4329         Reviewed by Lucas Forschler.
4330
4331         * BuildSlaveSupport/ews-build/config.json:
4332
4333 2019-02-05  Keith Rollin  <krollin@apple.com>
4334
4335         Enable the automatic checking and regenerations of .xcfilelists during builds
4336         https://bugs.webkit.org/show_bug.cgi?id=194124
4337         <rdar://problem/47721277>
4338
4339         Reviewed by Tim Horton.
4340
4341         Bug 193790 add a facility for checking -- during build time -- that
4342         any needed .xcfilelist files are up-to-date and for updating them if
4343         they are not. This facility was initially opt-in by setting
4344         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
4345         the process seemed robust. Its now time to enable this facility and
4346         make it opt-out. If there is a need to disable this facility, set and
4347         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
4348         running `make` or `build-webkit`, or before running Xcode from the
4349         command line.
4350
4351         Additionally, remove the step that generates a list of source files
4352         going into the UnifiedSources build step. It's only necessarily to
4353         specify Sources.txt and SourcesCocoa.txt as inputs.
4354
4355         * Scripts/generate-xcfilelists:
4356
4357 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
4358
4359         [GTK][WPE] force libpsl build to use ICU in jhbuild
4360         https://bugs.webkit.org/show_bug.cgi?id=194288
4361
4362         Reviewed by Philippe Normand.
4363
4364         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
4365         This can cause build failures if libidn is detected but libunistring is not available.
4366
4367         Make sure that ICU is used for runtime and builtin PSL data.
4368
4369         * gtk/jhbuild.modules:
4370         * wpe/jhbuild.modules:
4371
4372 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
4373
4374         [ews-app] Modified timestamp should be updated on updating data
4375         https://bugs.webkit.org/show_bug.cgi?id=194295
4376
4377         Reviewed by Lucas Forschler.
4378
4379         * BuildSlaveSupport/ews-app/ews/models/build.py:
4380         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
4381         * BuildSlaveSupport/ews-app/ews/models/step.py:
4382
4383 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
4384
4385         Unreviewed, rolling out r240742.
4386
4387         Causes crashes on iOS simulator.
4388
4389         Reverted changeset:
4390
4391         "[iOS] Keyups for non-modifier keys identified as "Dead" when
4392         not