Remove ENABLE definitions from WebKit config files
[WebKit-https.git] / Tools / ChangeLog
1 2019-05-29  Don Olmstead  <don.olmstead@sony.com>
2
3         Remove ENABLE definitions from WebKit config files
4         https://bugs.webkit.org/show_bug.cgi?id=197858
5
6         Reviewed by Simon Fraser.
7
8         Sync FeatureDefines.xcconfig.
9
10         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
11
12 2019-05-29  Said Abou-Hallawa  <sabouhallawa@apple.com>
13
14         [iOS] WebPage::positionInformation() may set InteractionInformationAtPosition.isImage to true but leave image unset
15         https://bugs.webkit.org/show_bug.cgi?id=198202
16
17         Reviewed by Tim Horton.
18
19         The new test ensures InteractionInformationAtPosition::isImage will not
20         be to true for a broken image.
21
22         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
23         (TestWebKitAPI::TEST):
24
25 2019-05-29  David Kilzer  <ddkilzer@apple.com>
26
27         check-webkit-style reports false-positive build/include_order warning in WTF C++ source files
28         <https://webkit.org/b/198349>
29
30         Reviewed by Alex Christensen.
31
32         * Scripts/webkitpy/style/checkers/cpp.py:
33         (_classify_include): Don't return early for <wtf/Header.h>
34         includes.
35         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
36         (OrderOfIncludesTest.test_primary_header): Add tests for
37         <wtf/Header.h> includes.
38
39 2019-05-29  Geoffrey Garen  <ggaren@apple.com>
40
41         WeakPtr breaks vtables when upcasting to base classes
42         https://bugs.webkit.org/show_bug.cgi?id=188799
43
44         Reviewed by Youenn Fablet.
45
46         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp: Adopt the new macro API instead
47         of template specialization for observing weak references.
48
49         (TestWebKitAPI::Int::Int):
50         (TestWebKitAPI::Int::operator int const):
51         (TestWebKitAPI::Int::operator== const): Use a class for integer tests
52         because WeakPtr doesn't naturally support pointing to non-class objects
53         now.
54
55         (TestWebKitAPI::Base::foo):
56         (TestWebKitAPI::Derived::foo): Inherit from CanMakeWeakPtr to enable
57         deduction of the weak pointer type.
58
59         (TestWebKitAPI::TEST): Updated to use Int.
60
61         (TestWebKitAPI::Base::weakPtrFactory const): Deleted.
62         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference): Deleted.
63         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference): Deleted.
64
65 2019-05-29  Ryan Haddad  <ryanhaddad@apple.com>
66
67         Unreviewed, rolling out r245857.
68
69         Breaks internal builds.
70
71         Reverted changeset:
72
73         "WeakPtr breaks vtables when upcasting to base classes"
74         https://bugs.webkit.org/show_bug.cgi?id=188799
75         https://trac.webkit.org/changeset/245857
76
77 2019-05-28  Geoffrey Garen  <ggaren@apple.com>
78
79         WeakPtr breaks vtables when upcasting to base classes
80         https://bugs.webkit.org/show_bug.cgi?id=188799
81
82         Reviewed by Youenn Fablet.
83
84         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp: Adopt the new macro API instead
85         of template specialization for observing weak references.
86
87         (TestWebKitAPI::Int::Int):
88         (TestWebKitAPI::Int::operator int const):
89         (TestWebKitAPI::Int::operator== const): Use a class for integer tests
90         because WeakPtr doesn't naturally support pointing to non-class objects
91         now.
92
93         (TestWebKitAPI::Base::foo):
94         (TestWebKitAPI::Derived::foo): Inherit from CanMakeWeakPtr to enable
95         deduction of the weak pointer type.
96
97         (TestWebKitAPI::TEST): Updated to use Int.
98
99         (TestWebKitAPI::Base::weakPtrFactory const): Deleted.
100         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference): Deleted.
101         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference): Deleted.
102
103 2019-05-29  Aakash Jain  <aakash_jain@apple.com>
104
105         Disable Flaky API Test TestWebKitAPI._WKDownload.DownloadMonitorCancel
106         https://bugs.webkit.org/show_bug.cgi?id=198328
107
108         Reviewed by Alexey Proskuryakov.
109
110         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
111
112 2019-05-28  Justin Michaud  <justin_michaud@apple.com>
113
114         Attempt to fix JSC test timeouts after adding collectContinuously to WASM tests.
115         https://bugs.webkit.org/show_bug.cgi?id=198322
116
117         Reviewed by Saam Barati.
118
119         Increases the collection period from 1 to slightly higher to try to speed up the tests. Any higher and
120         the test runner does not detect the bug that required the memset in Wasm::Instance::Instance().
121
122         * Scripts/run-jsc-stress-tests:
123
124 2019-05-28  Wenson Hsieh  <wenson_hsieh@apple.com>
125
126         [iOS] Respect NSItemProvider's registered types when dropping files that are loaded in-place
127         https://bugs.webkit.org/show_bug.cgi?id=198315
128         <rdar://problem/51183762>
129
130         Reviewed by Tim Horton.
131
132         Adds a new API test to verify that when dropping a file that is loaded in-place with a file extension that is
133         not a .png (but was registered to the item provider as "public.png"), the resulting attachment is contained in
134         an image element, and the resulting attachment info indicates that the dropped attachment is a png file.
135
136         Additionally, rebaseline some existing tests.
137
138         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
139         (runTestWithTemporaryImageFile):
140         (TestWebKitAPI::TEST):
141
142 2019-05-28  Yusuke Suzuki  <ysuzuki@apple.com>
143
144         GCHeapInspector should accept weird filename
145         https://bugs.webkit.org/show_bug.cgi?id=198314
146
147         Reviewed by Simon Fraser.
148
149         GCHeapInspector filenameForPath should have a fallback path if regexp does not match against the given path.
150
151         * GCHeapInspector/script/interface.js:
152         (filenameForPath):
153
154 2019-05-28  Eric Carlson  <eric.carlson@apple.com>
155
156         [MacOS] Filter GVA warning logged to stdout
157         https://bugs.webkit.org/show_bug.cgi?id=198303
158         <rdar://problem/50098041>
159
160         Reviewed by Jer Noble.
161
162         * Scripts/webkitpy/port/mac.py:
163         (MacPort.logging_patterns_to_strip): Filter GVA warnings.
164
165 2019-05-28  Nikita Vasilyev  <nvasilyev@apple.com>
166
167         Web Inspector: Provide UIString descriptions to improve localizations
168         https://bugs.webkit.org/show_bug.cgi?id=195132
169         <rdar://problem/48457817>
170
171         Reviewed by Devin Rousso.
172
173         Allow WI.UIString to take:
174         - WI.UIString(string, key, comment)
175         - WI.UIString(string, comment)
176         - WI.UIString(string)
177
178         * Scripts/extract-localizable-js-strings:
179
180 2019-05-25  Dewei Zhu  <dewei_zhu@apple.com>
181
182         Limit run-benchmark http server to specific interface.
183         https://bugs.webkit.org/show_bug.cgi?id=198247
184
185         Reviewed by Ryosuke Niwa.
186
187         Add '--interface' option to 'twisted_http_server.py'.
188         'SimpleHTTPServerDriver' should specify interface for http server.
189         Update regex that determines http server port from 'lsof' output to support ipv6 address.
190
191         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
192         Added '--interface' argument.
193         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
194         Limited http server to a specific interfce.
195         Added '-P' option to 'lsof' invocation to inhibits the conversion of port numbers to port name so script won't
196         fail if it's listening on a 'well-known' port.
197         Abstracted '_check_http_server_is_running' to allow potential child class to have its own implementation.
198         (SimpleHTTPServerDriver.serve): Updated regex that determines http server port from 'lsof' output to support ipv6 address.
199         (SimpleHTTPServerDriver.kill_server): Added null check for 'self._server_process'.
200
201 2019-05-28  David Xiong  <w_xiong@apple.com>
202
203         webkitpy: Switch run-webkit-tests to tailspin
204         https://bugs.webkit.org/show_bug.cgi?id=198144
205         <rdar://problem/32463212>
206
207         Reviewed by Jonathan Bedard.
208
209         Changes run-webkit-tests to run tailspin on test time out
210         rather than spindump, and edited tests to look for tailspin logs
211         instead.
212
213         * Scripts/webkitpy/port/darwin.py:
214         (DarwinPort.sample_process): Replaced spindump with tailspin (+ symbolication)
215         (DarwinPort):
216         (DarwinPort.tailspin_file_path):
217         (DarwinTest.spindump_file_path): Deleted.
218         * Scripts/webkitpy/port/darwin_testcase.py:
219         (DarwinTest.test_tailspin): Changed spindump test (below) to test for tailspin instead
220         (DarwinTest.test_spindump): Deleted.
221         (DarwinTest.test_spindump.logging_run_command): Deleted.
222         * Scripts/webkitpy/port/ios_device_unittest.py:
223         (IOSDeviceTest.test_tailspin): Changed spindump tests (inc. below) to test for tailspin instead
224         (IOSDeviceTest.test_sample_process.logging_run_command):
225         (IOSDeviceTest.test_sample_process_exception.throwing_run_command):
226         (IOSDeviceTest.test_spindump): Deleted.
227         (IOSDeviceTest.test_spindump.logging_run_command): Deleted.
228
229 2019-05-28  David Xiong  <w_xiong@apple.com>
230
231         webkitpy: Using sudo on iOS device during timeout spindumps 
232         https://bugs.webkit.org/show_bug.cgi?id=198142
233
234         Reviewed by Jonathan Bedard.
235
236         * Scripts/webkitpy/port/darwin.py:
237         (DarwinPort.sample_process): Check target host instead of source host for sudo command.
238
239 2019-05-28  Aakash Jain  <aakash_jain@apple.com>
240
241         [ews-build] Remove unused buildbot tabs
242         https://bugs.webkit.org/show_bug.cgi?id=198108
243
244         Reviewed by Jonathan Bedard.
245
246         * BuildSlaveSupport/ews-build/templates/build.jade: Removed unused 'Changes' and 'Responsible Users' tabs.
247
248 2019-05-27  Carlos Garcia Campos  <cgarcia@igalia.com>
249
250         [GTK] Use WPEBackend-fdo for accelerating compositing in Wayland instead of the nested compositor
251         https://bugs.webkit.org/show_bug.cgi?id=197944
252
253         Reviewed by Michael Catanzaro.
254
255         Add WPEBackend-fdo to jhbuild moduleset.
256
257         * gtk/jhbuild.modules:
258
259 2019-05-27  Wenson Hsieh  <wenson_hsieh@apple.com>
260
261         [iOS] Dropping in an editable element should result in a ranged selection
262         https://bugs.webkit.org/show_bug.cgi?id=198267
263         <rdar://problem/51145977>
264
265         Reviewed by Tim Horton.
266
267         Adjust some existing API tests that currently check for selection rects after a drop. Instead of checking for
268         visible selection rects, simply check for the start caret rect, as determined by WKContentView's
269         -selectionRange.
270
271         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
272         (TestWebKitAPI::TEST):
273         (makeCGRectValue): Deleted.
274         (checkSelectionRectsWithLogging): Deleted.
275         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
276
277         Replace finalSelectionRects with finalSelectionStartRect.
278
279         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
280         (-[DragAndDropSimulator _resetSimulatedState]):
281         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
282         (-[DragAndDropSimulator finalSelectionRects]): Deleted.
283
284 2019-05-27  Oriol Brufau  <obrufau@igalia.com>
285
286         [css-grid] Preserve repeat() notation when serializing declared values
287         https://bugs.webkit.org/show_bug.cgi?id=197840
288
289         Reviewed by Manuel Rego Casasnovas.
290
291         Adapt CSSPropertyParserTest to CSSGridIntegerRepeatValue.
292
293         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp:
294         (TestWebKitAPI::computeNumberOfTracks):
295
296 2019-05-26  Wenson Hsieh  <wenson_hsieh@apple.com>
297
298         [iOS] Dropped text, attachments, and images should animate into place
299         https://bugs.webkit.org/show_bug.cgi?id=198243
300         <rdar://problem/35205373>
301
302         Reviewed by Tim Horton.
303
304         Adjusts the iOS dragging simulator, and adds a new API test. See below for more detail.
305
306         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
307         (TestWebKitAPI::isCompletelyWhite):
308         (TestWebKitAPI::TEST):
309
310         Add a test that drags and drops an image into a contenteditable element, and then observes the resulting
311         UITargetedDragPreviews upon drop.
312
313         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
314         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
315         (-[DragAndDropSimulator _resetSimulatedState]):
316         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
317         (-[DragAndDropSimulator _concludeDropAndPerformOperationIfNecessary]):
318
319         Teach the iOS version of DragAndDropSimulator to invoke -dropInteraction:concludeDrop: on the drop interaction
320         delegate when the drop finishes. This additionally uses _doAfterReceivingEditDragSnapshotForTesting: to defer
321         the end of the simulated drag and drop until after drag previews have been received during an edit drag.
322
323         (-[DragAndDropSimulator dropPreviews]):
324         (-[DragAndDropSimulator delayedDropPreviews]):
325
326         Have the drag and drop simulator remember which previews were returned by the delegate on drop, as well as which
327         previews were provided asynchronously.
328
329         (-[DragAndDropSimulator _webView:dataInteractionOperationWasHandled:forSession:itemProviders:]):
330         * TestWebKitAPI/ios/UIKitSPI.h:
331
332         Stage the new private drop interacton delegate method.
333
334 2019-05-25  Simon Fraser  <simon.fraser@apple.com>
335
336         MobileMiniBrowser: Add iPad support, and allow insecure loads
337         https://bugs.webkit.org/show_bug.cgi?id=198249
338
339         Reviewed by Tim Horton.
340
341         Add iPad support to MobileMiniBrowser, and allow insecure loads.
342
343         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
344         * MobileMiniBrowser/MobileMiniBrowser/Info.plist:
345
346 2019-05-25  Wenson Hsieh  <wenson_hsieh@apple.com>
347
348         [iOS] Respect -[NSItemProvider preferredPresentationSize] when dropping images
349         https://bugs.webkit.org/show_bug.cgi?id=198242
350
351         Reviewed by Beth Dakin.
352
353         Add a new test that simulates dropping an image with a preferred presentation size into an editable element
354         with attachment elements enabled.
355
356         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
357         (TestWebKitAPI::TEST):
358
359 2019-05-24  Yusuke Suzuki  <ysuzuki@apple.com>
360
361         Make display-profiler-output work with newer HighLine
362         https://bugs.webkit.org/show_bug.cgi?id=198205
363
364         Reviewed by Saam Barati.
365
366         Newer HighLine does not have SystemExtensions. Access @terminal member in default instance of HighLine.
367
368         * Scripts/display-profiler-output:
369
370 2019-05-23  Fujii Hironori  <Hironori.Fujii@sony.com>
371
372         run-webkit-tests: Remove feature detection support
373         https://bugs.webkit.org/show_bug.cgi?id=198105
374
375         Reviewed by Jonathan Bedard.
376
377         Feature detection support was added to DRT for Windows and old
378         run-webkit-tests in Bug 35610. It was added for NRWT in Bug 41842.
379         But, it doesn't work for DRT for Windows because of feature name
380         mismatches. Since USE(ACCELERATED_COMPOSITING) flag has been
381         removed in Bug 127833, it is not needed anymore.
382
383         * DumpRenderTree/win/DumpRenderTree.cpp:
384         (main):
385         * Scripts/webkitpy/port/base.py:
386         (Port._tests_for_other_platforms):
387         (Port._skipped_tests_for_unsupported_features):
388         (Port._runtime_feature_list): Deleted.
389         (Port.nm_command): Deleted.
390         (Port._modules_to_search_for_symbols): Deleted.
391         (Port._symbols_string): Deleted.
392         (Port._missing_feature_to_skipped_tests): Deleted.
393         (Port._has_test_in_directories): Deleted.
394         * Scripts/webkitpy/port/darwin.py:
395         (DarwinPort.make_command):
396         (DarwinPort.nm_command): Deleted.
397         * Scripts/webkitpy/port/ios_simulator.py:
398         (IOSSimulatorPort.reset_preferences):
399         (IOSSimulatorPort.nm_command): Deleted.
400         * Scripts/webkitpy/port/port_testcase.py:
401         (TestWebKitPort.__init__):
402         (TestWebKitPort.all_test_configurations):
403         (PortTestCase.test_path_to_test_expectations_file):
404         (TestWebKitPort._symbols_string): Deleted.
405         (PortTestCase.test_skipped_directories_for_features): Deleted.
406         (PortTestCase.test_skipped_directories_for_features_no_matching_tests_in_test_list): Deleted.
407         (PortTestCase.test_skipped_tests_for_unsupported_features_empty_test_list): Deleted.
408         * Scripts/webkitpy/port/watch_simulator.py:
409         (WatchSimulatorPort.reset_preferences):
410         (WatchSimulatorPort.nm_command): Deleted.
411         * Scripts/webkitpy/port/win.py:
412         (WinPort.show_results_html_file):
413         (WinPort._runtime_feature_list): Deleted.
414         * Scripts/webkitpy/port/win_unittest.py:
415         (WinPortTest.test_operating_system):
416         (WinPortTest.test_runtime_feature_list): Deleted.
417         * WebKitTestRunner/Options.cpp:
418         (WTR::OptionsHandler::OptionsHandler):
419         (WTR::handleOptionPrintSupportedFeatures): Deleted.
420         * WebKitTestRunner/Options.h:
421         * WebKitTestRunner/TestController.cpp:
422         (WTR::TestController::initialize):
423
424 2019-05-23  Commit Queue  <commit-queue@webkit.org>
425
426         Unreviewed, rolling out r245665.
427         https://bugs.webkit.org/show_bug.cgi?id=198203
428
429         Inspector appears blank, again. (Requested by NVI on #webkit).
430
431         Reverted changeset:
432
433         "Web Inspector: Provide UIString descriptions to improve
434         localizations"
435         https://bugs.webkit.org/show_bug.cgi?id=195132
436         https://trac.webkit.org/changeset/245665
437
438 2019-05-23  Stephan Szabo  <stephan.szabo@sony.com>
439
440         [Win][CMake] Pass architecture to cmake via -A for both x64 and Win32
441         https://bugs.webkit.org/show_bug.cgi?id=198098
442
443         Reviewed by Don Olmstead.
444
445         With current CMake and Visual Studio 2019, the default
446         architecture will match the host, so we should make sure
447         to explicitly mention the architecture we want for 32-bit
448         builds as well for cases where we are on x64 and not in an
449         x64_x32 cross-build vcvars environment.
450
451         * Scripts/webkitdirs.pm:
452         (getVisualStudioToolset): Get toolset name for cmake/msbuild
453         (getMSBuildPlatformArgument): Update to use getVisualStudioToolset
454         (getCMakeWindowsToolsetArgument): Get -A argument for cmake
455         based on toolset
456         (generateBuildSystemFromCMakeProject): Remove explicit -A x64
457         in 64-bit mode in favor of new getCMakeWindowsToolsetArgument.
458
459 2019-05-23  Youenn Fablet  <youenn@apple.com>
460
461         Set default WebsiteDataStore storage quota based on StorageQuotaManager
462         https://bugs.webkit.org/show_bug.cgi?id=198133
463         <rdar://problem/51031436>
464
465         Reviewed by Geoffrey Garen.
466
467         * TestWebKitAPI/Tests/WebKitCocoa/StorageQuota.mm:
468         (doTest):
469
470 2019-05-23  Keith Rollin  <krollin@apple.com>
471
472         generate-xcfilelists should not store temporary build files in /tmp
473         https://bugs.webkit.org/show_bug.cgi?id=198136
474
475         Reviewed by Jonathan Bedard.
476
477         Provide the build infrastructure control of the location of
478         generate-xcfilelists' temporary files by creating them in the build
479         directory when possible.
480
481         * Scripts/webkitpy/generate_xcfilelists_lib/application.py:
482         (get_xcode_project_temp_dir):
483         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
484         (BaseGenerator._generate_derived):
485         (BaseGenerator._generate_unified):
486         (BaseGenerator):
487         (BaseGenerator._get_temp_dir):
488
489 2019-05-23  Philippe Normand  <philn@igalia.com>
490
491         [JHBuild][GStreamer] Enable libsrtp
492         https://bugs.webkit.org/show_bug.cgi?id=198041
493
494         Reviewed by Xabier Rodriguez-Calvar.
495
496         * gstreamer/jhbuild.modules: Enable libsrtp. The system version
497         can't be used from Stretch because it's too old.
498
499 2019-05-22  Ryan Haddad  <ryanhaddad@apple.com>
500
501         Move win-ews queue bubble to Win10 section of dashboard
502         https://bugs.webkit.org/show_bug.cgi?id=198159
503
504         Reviewed by Alexey Proskuryakov.
505
506         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
507         (BubbleQueueServer): Change platform to Windows10 to match the OS version of the bots.
508
509 2019-05-22  Myles C. Maxfield  <mmaxfield@apple.com>
510
511         [Mac] Add API test to make sure the system font is drawn just like in native code
512         https://bugs.webkit.org/show_bug.cgi?id=198010
513
514         Reviewed by Daniel Bates.
515
516         We can compare the width of using font-family:system-ui to a CTLine.
517
518         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
519         * TestWebKitAPI/Tests/WebKitCocoa/TextWidth.html: Added.
520         * TestWebKitAPI/Tests/WebKitCocoa/TextWidth.mm: Added.
521         (TEST):
522
523 2019-05-22  Nikita Vasilyev  <nvasilyev@apple.com>
524
525         Web Inspector: Provide UIString descriptions to improve localizations
526         https://bugs.webkit.org/show_bug.cgi?id=195132
527         <rdar://problem/48457817>
528
529         Reviewed by Devin Rousso.
530
531         Allow WI.UIString to take:
532         - WI.UIString(string, key, comment)
533         - WI.UIString(string, comment)
534         - WI.UIString(string)
535
536         * Scripts/extract-localizable-js-strings:
537
538 2019-05-22  Wenson Hsieh  <wenson_hsieh@apple.com>
539
540         [iOS] The shouldIgnoreMetaViewport test option incorrectly persists across layout tests
541         https://bugs.webkit.org/show_bug.cgi?id=198135
542         <rdar://problem/51001306>
543
544         Reviewed by Alexey Proskuryakov.
545
546         When shouldIgnoreMetaViewport=true is specified on a test, if the following test does not use a flexible
547         viewport, we will continue ignoring the meta viewport, since we'll bail before we attempt to reset
548         WKPreferences' _shouldIgnoreMetaViewport property to NO.
549
550         We fix this by simply allowing shouldIgnoreMetaViewport to take precedence over useFlexibleViewport, such that
551         -[WKPreferences _shouldIgnoreMetaViewport] will always be updated to its intended value between tests.
552
553         * WebKitTestRunner/ios/TestControllerIOS.mm:
554         (WTR::TestController::platformConfigureViewForTest):
555
556 2019-05-22  Sihui Liu  <sihui_liu@apple.com>
557
558         API Test landed in r245540 [Mac WK2] TestWebKitAPI.WKWebView.LocalStorageProcessCrashes is a flaky failure
559         https://bugs.webkit.org/show_bug.cgi?id=198090
560         <rdar://problem/51003644>
561
562         Reviewed by Youenn Fablet.
563
564         WebView was wrongly loaded multiple times.
565
566         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:
567         (TEST):
568
569 2019-05-22  Jiewen Tan  <jiewen_tan@apple.com>
570
571         [WebAuthN] Support Attestation Conveyance Preference
572         https://bugs.webkit.org/show_bug.cgi?id=192722
573         <rdar://problem/49939647>
574
575         Reviewed by Brent Fulgham.
576
577         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
578         (TestWebKitAPI::TEST):
579         Updates the test with AttestationConveyancePreference.
580
581 2019-05-22  Zalan Bujtas  <zalan@apple.com>
582
583         [Paste] Add support for preferred presentation size when pasting an image
584         https://bugs.webkit.org/show_bug.cgi?id=198132
585         <rdar://problem/50886917>
586
587         Reviewed by Wenson Hsieh.
588
589         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
590         (TestWebKitAPI::TEST):
591
592 2019-05-22  Keith Rollin  <krollin@apple.com>
593
594         Use a different variable when testing for Xcode context in generate-xcfilelists
595         https://bugs.webkit.org/show_bug.cgi?id=198130
596         <rdar://problem/51032752>
597
598         Reviewed by Jonathan Bedard.
599
600         The generate-xcfilelists script can run stand-alone or in the context
601         of Xcode. There are a couple of places where it helps to know which
602         context is current. To determine the context, genreate-xfilelists
603         checks an environment variable that should be defined only when Xcode
604         is running. The variable chosen was XCODE_INSTALL_PATH. It turns out
605         that this variable is not always defined. Therefore, switch to
606         checking XCODE_PRODUCT_BUILD_VERSION.
607
608         * Scripts/webkitpy/generate_xcfilelists_lib/util.py:
609         (subprocess_run):
610         (is_running_under_xcode):
611
612 2019-05-22  Carlos Garcia Campos  <cgarcia@igalia.com>
613
614         Unreviewed. Fix WPE unit tests after r245565
615
616         Backend creation is failing when the a11y bus is not running because atk produces warning messages. We should
617         not make warnings fatal during backend creation.
618
619         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
620         (testAutomationSessionRequestSession):
621         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
622         (testWebViewGeolocationPermissionRequests):
623         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
624         (Test::createWebViewBackend):
625         (Test::addLogFatalFlag):
626         (Test::removeLogFatalFlag):
627
628 2019-05-21  Aakash Jain  <aakash_jain@apple.com>
629
630         [ews-build] Use custom templates for Buildbot (follow-up fix)
631         https://bugs.webkit.org/show_bug.cgi?id=198076
632
633         Unreviewed minor follow-up fix.
634
635         * BuildSlaveSupport/ews-build/templates/build.jade:
636
637 2019-05-21  Alex Christensen  <achristensen@webkit.org>
638
639         Fix branch build.
640         <rdar://problem/50625279>
641
642         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
643         We need to explicitly include WebKit.h on the branch.
644
645 2019-05-21  Aakash Jain  <aakash_jain@apple.com>
646
647         [ews-build] Use custom templates for Buildbot
648         https://bugs.webkit.org/show_bug.cgi?id=198076
649
650         Rubber-stamped by Jonathan Bedard.
651
652         * BuildSlaveSupport/ews-build/master.cfg:
653         * BuildSlaveSupport/ews-build/templates: Added.
654         * BuildSlaveSupport/ews-build/templates/build.jade: Copied from https://github.com/buildbot/buildbot/blob/v1.7.0/www/base/src/app/builders/builds/build.tpl.jade
655
656 2019-05-21  Chris Dumez  <cdumez@apple.com>
657
658         [PSON] Assertion hit when navigating back after a process swap forced by the client
659         https://bugs.webkit.org/show_bug.cgi?id=198006
660
661         Reviewed by Alex Christensen.
662
663         Add API test coverage.
664
665         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
666
667 2019-05-21  Carlos Garcia Campos  <cgarcia@igalia.com>
668
669         Unreviewed. Fix the build with HAVE(ACCESSIBILITY) disabled
670
671         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
672         (WTR::AccessibilityController::elementAtPoint):
673         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
674         (WTR::AccessibilityController::rootElement):
675         (WTR::AccessibilityController::focusedElement):
676
677 2019-05-21  Carlos Garcia Campos  <cgarcia@igalia.com>
678
679         [WPE] Add initial accessibility support using ATK
680         https://bugs.webkit.org/show_bug.cgi?id=197413
681
682         Reviewed by Michael Catanzaro.
683
684         Add accessibility support in MiniBrowser and backends used by MiniBrowser and tests.
685
686         * MiniBrowser/wpe/CMakeLists.txt:
687         * MiniBrowser/wpe/main.cpp:
688         (main):
689         * TestWebKitAPI/PlatformWPE.cmake:
690         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
691         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
692         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
693         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
694         (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
695         (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
696         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityControllerWPE.cpp: Removed.
697         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp: Removed.
698         * WebKitTestRunner/PlatformWPE.cmake:
699         * wpe/backends/CMakeLists.txt:
700         * wpe/backends/HeadlessViewBackend.cpp:
701         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend):
702         * wpe/backends/ViewBackend.cpp:
703         (WPEToolingBackends::addKeyEventListener):
704         (WPEToolingBackends::removeKeyEventListener):
705         (WPEToolingBackends::notifyAccessibilityKeyEventListeners):
706         (WPEToolingBackends::ViewBackend::initialize):
707         (WPEToolingBackends::ViewBackend::initializeAccessibility):
708         (WPEToolingBackends::ViewBackend::updateAccessibilityState):
709         (WPEToolingBackends::ViewBackend::setAccessibleChild):
710         (WPEToolingBackends::ViewBackend::addActivityState):
711         (WPEToolingBackends::ViewBackend::removeActivityState):
712         (WPEToolingBackends::ViewBackend::dispatchInputKeyboardEvent):
713         * wpe/backends/ViewBackend.h:
714         * wpe/backends/WebKitAccessibleApplication.cpp: Added.
715         (webkitAccessibleApplicationWindowInterfaceInit):
716         (webkitAccessibleApplicationFinalize):
717         (webkitAccessibleApplicationInitialize):
718         (webkitAccessibleApplicationGetNChildren):
719         (webkitAccessibleApplicationRefChild):
720         (webkitAccessibleApplicationGetName):
721         (webkit_accessible_application_class_init):
722         (webkit_accessible_application_init):
723         (webkitAccessibleApplicationNew):
724         (webkitAccessibleApplicationSetChild):
725         * wpe/backends/WebKitAccessibleApplication.h: Added.
726         * wpe/backends/WindowViewBackend.cpp:
727         (WPEToolingBackends::WindowViewBackend::WindowViewBackend):
728         * wpe/jhbuild.modules:
729
730 2019-05-20  Fujii Hironori  <Hironori.Fujii@sony.com>
731
732         run-webkit-tests not gathering crash logs on Cygwin Python and Windows Python
733         https://bugs.webkit.org/show_bug.cgi?id=179828
734
735         Reviewed by Jonathan Bedard.
736
737         ServerProcess should store its Windows PID for Cygwin before
738         process crashing because the Windows PID is required to get a
739         correct CrashLog.
740
741         CrashLog format has been changed. CrashLogs.GLOBAL_PID_REGEX
742         should accept the new format.
743
744         * Scripts/webkitpy/common/system/crashlogs.py:
745         (CrashLogs.GLOBAL_PID_REGEX): Accept any words between 'Global' and 'PID:'.
746
747         * Scripts/webkitpy/port/driver.py:
748         (Driver.has_crashed):
749         (Driver._check_for_driver_crash_or_unresponsiveness):
750         (Driver._read_block):
751         Store server_process.system_pid() to self._crashed_pid instead of server_process.pid().
752
753         * Scripts/webkitpy/port/server_process.py:
754         (ServerProcess.__init__):
755         (ServerProcess.system_pid): Added.
756         (ServerProcess._find_system_pid): Added.
757         (ServerProcess._start): Set self._system_pid.
758         * Scripts/webkitpy/port/win.py:
759         (WinPort._get_crash_log): Removed broken old code converting Cygwin pid to Windows pid.
760
761 2019-05-20  Aakash Jain  <aakash_jain@apple.com>
762
763         Windows 10 test results missing on flakiness dashboard
764         https://bugs.webkit.org/show_bug.cgi?id=198058
765
766         Rubber-stamped by Alexey Proskuryakov.
767
768         * TestResultServer/static-dashboards/flakiness_dashboard.js:
769
770 2019-05-20  Sihui Liu  <sihui_liu@apple.com>
771
772         Move Web Storage to Network Process
773         https://bugs.webkit.org/show_bug.cgi?id=197636
774  
775         Reviewed by Youenn Fablet.
776  
777         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
778         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageDatabaseTracker.mm: Remove the wait for database file update.
779         (TEST):
780         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm: Add a test for network process crash recovery.
781         (TEST):
782         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm: Fix a typo and add a test case to cover it.
783         * TestWebKitAPI/Tests/WebKitCocoa/local-storage-process-crashes.html: Added.
784
785 2019-05-20  Keith Rollin  <krollin@apple.com>
786
787         generate-xcfilelists is stranding temporary files
788         https://bugs.webkit.org/show_bug.cgi?id=198008
789         <rdar://problem/50893659>
790
791         Reviewed by Jonathan Bedard.
792
793         generate-xcfilelists makes use of temporary files on disk. These files
794         are opened with the OS's "temporary" bit set, causing them to get
795         deleted when closed or the process exists. However, these temporary
796         files actually end up persisting after the script exists. This is
797         because `sed` is used to process the files, and is done so in a way
798         that causes the "temporary" bit to get cleared.
799
800         Address this issue by no longer using `sed` and instead performing the
801         equivalent processing the file content in-memory.
802
803         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
804         (BaseGenerator._generate_derived):
805         (BaseGenerator._generate_unified):
806         (BaseGenerator._replace):
807         (BaseGenerator._unexpand):
808         (BaseGenerator._find_added_lines.get_lines):
809         (BaseGenerator._find_added_lines):
810
811 2019-05-20  Ludovico de Nittis  <ludovico.denittis@collabora.com>
812
813         [WPE][Qt] Use C++17 instead of C++14
814         https://bugs.webkit.org/show_bug.cgi?id=197415
815
816         Reviewed by Philippe Normand.
817
818         There was a regression introduced with the commit https://bugs.webkit.org/show_bug.cgi?id=197131
819         The WPE Qt port was not updated to C++17 and this leaded to a compilation error.
820
821         * TestWebKitAPI/glib/CMakeLists.txt:
822
823 2019-05-20  Ludovico de Nittis  <ludovico.denittis@collabora.com>
824
825         [Flatpak][Qt] Meson: Unknown type feature for gstreamer
826         https://bugs.webkit.org/show_bug.cgi?id=197408
827
828         Reviewed by Philippe Normand.
829
830         This is a regression that has been introduced when
831         GStreamer was updated to version 1.16.0
832         https://bugs.webkit.org/show_bug.cgi?id=197157
833
834         Now GStreamer requires meson >= 0.47.0
835         Updating the Kde runtime to version 5.12 we fulfill
836         this requirement.
837
838         * flatpak/org.webkit.WPEQT.yaml:
839
840 2019-05-20  Carlos Garcia Campos  <cgarcia@igalia.com>
841
842         [GLIB] Crash when instantiating a js object registered with jsc_context_register_class on window object cleared
843         https://bugs.webkit.org/show_bug.cgi?id=198037
844
845         Reviewed by Michael Catanzaro.
846
847         Add a test case to check the crash is fixed.
848
849         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
850         (testWebExtensionWindowObjectCleared):
851         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
852         (windowObjectCleared):
853
854 2019-05-20  Carlos Garcia Campos  <cgarcia@igalia.com>
855
856         [GLIB] Repeating timer is not stopped when stop is called from the callback
857         https://bugs.webkit.org/show_bug.cgi?id=197986
858
859         Reviewed by Michael Catanzaro.
860
861         Check the timer is no longer active after it has been stopped.
862
863         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
864         (TestWebKitAPI::TEST):
865
866 2019-05-19  Darin Adler  <darin@apple.com>
867
868         Change String::number to use "shortest" instead of "fixed precision 6 digits"
869         https://bugs.webkit.org/show_bug.cgi?id=178319
870
871         Reviewed by Sam Weinig.
872
873         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
874         (TestWebKitAPI::testStringNumberFixedPrecision): Use String::numberToStringFixedPrecision.
875
876         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
877         (attributesOfElement): Use appendFixedPrecisionNumber.
878
879 2019-05-18  Jiewen Tan  <jiewen_tan@apple.com>
880
881         [WebAuthN] Allow authenticators that support both CTAP and U2F to try U2F if CTAP fails in authenticatorGetAssertion
882         https://bugs.webkit.org/show_bug.cgi?id=197974
883         <rdar://problem/50879746>
884
885         Reviewed by Brent Fulgham.
886
887         Add a canDowngrade option for mock hid devices to simulate the situation.
888
889         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
890         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
891
892 2019-05-18  Tadeu Zagallo  <tzagallo@apple.com>
893
894         Add extra information to dumpJITMemory
895         https://bugs.webkit.org/show_bug.cgi?id=197998
896
897         Reviewed by Saam Barati.
898
899         Add description for the new dumpJITMemory trace point code.
900
901         * Tracing/SystemTracePoints.plist:
902
903 2019-05-17  Justin Michaud  <justin_michaud@apple.com>
904
905         [WASM-References] Add support for Anyref in parameters and return types, Ref.null and Ref.is_null for Anyref values.
906         https://bugs.webkit.org/show_bug.cgi?id=197969
907
908         Run wasm tests additionally with wasmBBQUsesAir=0.
909
910         Reviewed by Keith Miller.
911
912         * Scripts/run-jsc-stress-tests:
913
914 2019-05-17  Don Olmstead  <don.olmstead@sony.com>
915
916         [CMake] Use builtin FindICU
917         https://bugs.webkit.org/show_bug.cgi?id=197934
918
919         Reviewed by Michael Catanzaro.
920
921         Remove uses of ICU_INCLUDE_DIRS and ICU_LIBRARIES.
922
923         * TestWebKitAPI/PlatformMac.cmake:
924         * TestWebKitAPI/PlatformPlayStation.cmake:
925         * TestWebKitAPI/PlatformWin.cmake:
926         * WebKitTestRunner/CMakeLists.txt:
927
928 2019-05-17  Alex Christensen  <achristensen@webkit.org>
929
930         Enable legacy EME for iOS WKWebView
931         https://bugs.webkit.org/show_bug.cgi?id=197964
932         <rdar://problem/50625666>
933
934         Reviewed by Wenson Hsieh.
935
936         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
937         (TEST):
938
939 2019-05-17  Aakash Jain  <aakash_jain@apple.com>
940
941         [ews-build] Add clickable url in UI for uploaded S3 archive
942         https://bugs.webkit.org/show_bug.cgi?id=197996
943
944         Reviewed by Jonathan Bedard.
945
946         * BuildSlaveSupport/ews-build/steps.py:
947
948 2019-05-17  Aakash Jain  <aakash_jain@apple.com>
949
950         [ews-app] Status bubble should not turn orange when any build step has warnings
951         https://bugs.webkit.org/show_bug.cgi?id=198000
952
953         Reviewed by Jonathan Bedard.
954
955         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
956         (StatusBubble._does_build_contains_any_failed_step):
957
958 2019-05-17  Alex Christensen  <achristensen@webkit.org>
959
960         Add SPI to set a list of hosts to which to send custom header fields cross-origin
961         https://bugs.webkit.org/show_bug.cgi?id=197397
962
963         Reviewed by Geoff Garen.
964
965         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
966         (TEST):
967         (expectLegacyHeaders):
968         (expectHeaders):
969         (-[CustomHeaderFieldsDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
970         (-[CustomHeaderFieldsDelegate webView:startURLSchemeTask:]):
971         (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
972
973 2019-05-17  Keith Rollin  <krollin@apple.com>
974
975         Unreviewed build fix.
976
977         Teach generate-xcfilelists about iphonesimulator.
978
979         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
980         (JavaScriptCoreGenerator):
981         (WebCoreGenerator):
982         (WebKitGenerator):
983
984 2019-05-17  Keith Rollin  <krollin@apple.com>
985
986         Re-enable generate-xcfilelists
987         https://bugs.webkit.org/show_bug.cgi?id=197933
988         <rdar://problem/50831677>
989
990         Reviewed by Jonathan Bedard.
991
992         The following two tasks have been completed, and we can re-enable
993         generate-xcfilelists:
994
995         Bug 197619 <rdar://problem/50507392> Temporarily disable generate-xcfilelists (197619)
996         Bug 197622 <rdar://problem/50508222> Rewrite generate-xcfilelists in Python (197622)
997
998         * DumpRenderTree/Scripts/check-xcfilelists.sh:
999         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
1000
1001 2019-05-17  Commit Queue  <commit-queue@webkit.org>
1002
1003         Unreviewed, rolling out r245401.
1004         https://bugs.webkit.org/show_bug.cgi?id=197990
1005
1006         Causing internal build failures (Requested by ShawnRoberts on
1007         #webkit).
1008
1009         Reverted changeset:
1010
1011         "Add SPI to set a list of hosts to which to send custom header
1012         fields cross-origin"
1013         https://bugs.webkit.org/show_bug.cgi?id=197397
1014         https://trac.webkit.org/changeset/245401
1015
1016 2019-05-17  Commit Queue  <commit-queue@webkit.org>
1017
1018         Unreviewed, rolling out r245418.
1019         https://bugs.webkit.org/show_bug.cgi?id=197989
1020
1021         New API test causing crashes on Mojave testers (Requested by
1022         ShawnRoberts on #webkit).
1023
1024         Reverted changeset:
1025
1026         "Add a unit test for client certificate authentication"
1027         https://bugs.webkit.org/show_bug.cgi?id=197800
1028         https://trac.webkit.org/changeset/245418
1029
1030 2019-05-17  Aakash Jain  <aakash_jain@apple.com>
1031
1032         [ews-build] Add build step to Transfer archive to S3
1033         https://bugs.webkit.org/show_bug.cgi?id=197922
1034
1035         Reviewed by Jonathan Bedard.
1036
1037         * BuildSlaveSupport/ews-build/steps.py:
1038         (TransferToS3):
1039         (TransferToS3.finished): Invoke triggers after transfer is successful.
1040         (TransferToS3.getResultSummary): Create more readable failure string.
1041         (UploadBuiltProduct.finished): Deleted. Moved the trigger invocation after TransferToS3.
1042         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1043
1044 2019-05-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1045
1046         [GTK] Need WebKitContextMenuItemType to open emoji picker
1047         https://bugs.webkit.org/show_bug.cgi?id=176760
1048
1049         Reviewed by Michael Catanzaro.
1050
1051         Update context menu test to check insert emoji action is included in default context menu for editable content.
1052
1053         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
1054
1055 2019-05-16  Aakash Jain  <aakash_jain@apple.com>
1056
1057         [ews-build] Download archives from S3
1058         https://bugs.webkit.org/show_bug.cgi?id=197949
1059
1060         Reviewed by Jonathan Bedard.
1061
1062         * BuildSlaveSupport/ews-build/steps.py:
1063         (DownloadBuiltProduct): Updated to use S3 URL.
1064         (DownloadBuiltProduct.getResultSummary): Method to display custom failure string.
1065         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
1066
1067 2019-05-16  David Kilzer  <ddkilzer@apple.com>
1068
1069         REGRESSION (r15133): Fix leak of JSStringRef in minidom
1070         <https://webkit.org/b/197968>
1071         <rdar://problem/50872430>
1072
1073         Reviewed by Joseph Pecoraro.
1074
1075         * TestWebKitAPI/Tests/WebKitObjC/UserContentTest.mm:
1076         (expectScriptValueIsString): Drive-by fix to use adopt() instead
1077         of JSRetainPtr<JSStringRef> string(Adopt, JSValueToStringCopy(...)).
1078
1079 2019-05-16  David Kilzer  <ddkilzer@apple.com>
1080
1081         REGRESSION (r84160): Leak of OpaqueJSString under WTR::JSTestRunner::pathToLocalResource (32 bytes) in com.apple.WebKit.WebContent running layout tests
1082         <https://webkit.org/b/197965>
1083
1084         Reviewed by Joseph Pecoraro.
1085
1086         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1087         (WTR::TestRunner::pathToLocalResource): Don't call
1088         JSStringRetain() here because the JSRetainPtr<JSStringRef>
1089         return type will increment the retain count for us.
1090
1091 2019-05-16  Alex Christensen  <achristensen@webkit.org>
1092
1093         Add a unit test for client certificate authentication
1094         https://bugs.webkit.org/show_bug.cgi?id=197800
1095
1096         Reviewed by Youenn Fablet.
1097
1098         Make better abstractions for reading and writing from/to TCPServer.
1099         Add a unit test that causes a client certificate authentication challenge to happen.
1100
1101         * TestWebKitAPI/TCPServer.cpp:
1102         (TestWebKitAPI::TCPServer::TCPServer):
1103         (TestWebKitAPI::TCPServer::read):
1104         (TestWebKitAPI::TCPServer::write):
1105         (TestWebKitAPI::TCPServer::respondWithChallengeThenOK):
1106         (TestWebKitAPI::TCPServer::respondWithOK):
1107         * TestWebKitAPI/TCPServer.h:
1108         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1109         (credentialWithIdentity):
1110         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1111         (TEST):
1112         (-[ClientCertificateDelegate webView:didFinishNavigation:]):
1113         (-[ClientCertificateDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1114         (-[ClientCertificateDelegate challengeCount]):
1115         (TestWebKitAPI::TEST):
1116         (respondWithChallengeThenOK): Deleted.
1117         (credentialWithIdentityAndKeychainPath): Deleted.
1118         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
1119         (TEST):
1120         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
1121         (TestWebKitAPI::TEST):
1122         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1123         (TEST):
1124         (readRequest): Deleted.
1125         (writeResponse): Deleted.
1126         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1127         (TestWebKitAPI::TEST):
1128         (TestWebKitAPI::respondWithChallengeThenOK): Deleted.
1129
1130 2019-05-16  Alex Christensen  <achristensen@webkit.org>
1131
1132         Add SPI to set a list of hosts to which to send custom header fields cross-origin
1133         https://bugs.webkit.org/show_bug.cgi?id=197397
1134
1135         Reviewed by Geoff Garen.
1136
1137         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1138         (TEST):
1139         (expectLegacyHeaders):
1140         (expectHeaders):
1141         (-[CustomHeaderFieldsDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
1142         (-[CustomHeaderFieldsDelegate webView:startURLSchemeTask:]):
1143         (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
1144
1145 2019-05-15  Aakash Jain  <aakash_jain@apple.com>
1146
1147         Replace double-quotes with single quotes in steps.py
1148         https://bugs.webkit.org/show_bug.cgi?id=197921
1149
1150         Reviewed by Jonathan Bedard.
1151
1152         * BuildSlaveSupport/ews-build/steps.py:
1153
1154 2019-05-15  Keith Rollin  <krollin@apple.com>
1155
1156         Rewrite generate-xcfilelists in Python
1157         https://bugs.webkit.org/show_bug.cgi?id=197622
1158         <rdar://problem/50508222>
1159
1160         Reviewed by Jonathan Bedard, Alex Christensen.
1161
1162         For a number of reasons, rewrite generate-xcfilelists in Python:
1163
1164         - The previous bash script was large and unmaintainable.
1165         - We have more internal expertise with Python than with bash.
1166         - The bash script used temporary files in /tmp that got stranded and
1167           were owned by root, making them awkward to clear out.
1168           <rdar://problem/49490262>
1169         - We needed to complete support for engineers that built with Xcode
1170           rather than the command line.
1171         - There are some bugs leading to mildly corrupted .xcfilelist files.
1172           It's not apparent the source of the bugs, but one general reason
1173           might be due to approaches born of using bash. Rewriting in Python
1174           may clear these up.
1175
1176         * Scripts/generate-xcfilelists:
1177         * Scripts/webkitpy/common/attribute_saver.py: Added.
1178         (AttributeSaver):
1179         (AttributeSaver.__init__):
1180         (AttributeSaver.__enter__):
1181         (AttributeSaver.__exit__):
1182         * Scripts/webkitpy/common/attribute_saver_unittest.py: Added.
1183         (AttributeSaverTest):
1184         (AttributeSaverTest.SimpleTestClass):
1185         (AttributeSaverTest.SimpleTestClass.__init__):
1186         (AttributeSaverTest.test_class):
1187         (AttributeSaverTest.test_normal_default):
1188         (AttributeSaverTest.test_normal_value):
1189         (AttributeSaverTest.test_normal_value_on_exception):
1190         (AttributeSaverTest.test_normal_value_on_normal_exit):
1191         (AttributeSaverTest.test_normal_value_with_finally_on_exception):
1192         (AttributeSaverTest.test_normal_value_with_finally_on_normal_exit):
1193         (AttributeSaverTest.test_normal_value_with_else_on_exception):
1194         (AttributeSaverTest.test_normal_value_with_else_on_normal_exit):
1195         * Scripts/webkitpy/generate_xcfilelists_lib/__init__.py: Added.
1196         * Scripts/webkitpy/generate_xcfilelists_lib/application.py: Added.
1197         (Application):
1198         (Application.__init__):
1199         (Application.run):
1200         (Application._initialize):
1201         (Application._initialize.collect_attributes):
1202         (Application._create_parser):
1203         (_validate_args):
1204         (_cmd_generate):
1205         (_cmd_check):
1206         (_cmd_subgenerate):
1207         (_cmd_help):
1208         (_do_generate):
1209         (_do_merge):
1210         (_report_results):
1211         (_report_merge_results):
1212         (_report_remediation_steps):
1213         (_report_remediation_steps.add_to_message):
1214         (_any_have_errors):
1215         (_any_have_actions):
1216         (_log_progress):
1217         (_log_results):
1218         (get_generate_xcfilelists_script_path):
1219         (_get_root_dir):
1220         (get_opensource_dir):
1221         (get_build_scripts_dir):
1222         (get_extract_dependencies_from_makefile_script):
1223         (get_xcode_built_products_dir):
1224         (_getenv):
1225         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py: Added.
1226         (BaseGenerator):
1227         (BaseGenerator.__init__):
1228         (BaseGenerator.__str__):
1229         (BaseGenerator.generate):
1230         (BaseGenerator._sublaunch_under_xcode):
1231         (BaseGenerator.subgenerate):
1232         (BaseGenerator.merge):
1233         (BaseGenerator.pickle_to_file):
1234         (BaseGenerator.has_action):
1235         (BaseGenerator.has_error):
1236         (BaseGenerator.is_valid):
1237         (BaseGenerator.report_error):
1238         (BaseGenerator._generate_derived):
1239         (BaseGenerator._merge_derived):
1240         (BaseGenerator._generate_unified):
1241         (BaseGenerator._merge_unified):
1242         (BaseGenerator._replace):
1243         (BaseGenerator._unexpand):
1244         (BaseGenerator._find_added_lines):
1245         (BaseGenerator._merge_added_lines):
1246         (BaseGenerator._get_file_lines):
1247         (BaseGenerator._getenv):
1248         (BaseGenerator._get_project_file_path):
1249         (BaseGenerator._get_project_dir):
1250         (BaseGenerator._get_project_file_name):
1251         (BaseGenerator._get_project_name):
1252         (BaseGenerator._get_sym_root):
1253         (BaseGenerator._get_obj_root):
1254         (BaseGenerator._get_shared_precomps_dir):
1255         (BaseGenerator._get_build_dirs):
1256         (BaseGenerator._get_build_dirs.define_xcode_build_dirs):
1257         (BaseGenerator._get_build_dirs.define_xcode_build_dirs.read_xcode_user_default):
1258         (BaseGenerator._get_build_dirs.define_command_line_build_dirs):
1259         (BaseGenerator._get_derived_sources_dir):
1260         (BaseGenerator._get_xcfilelist_dir):
1261         (BaseGenerator._get_input_derived_xcfilelist_project_path):
1262         (BaseGenerator._get_output_derived_xcfilelist_project_path):
1263         (BaseGenerator._get_input_unified_xcfilelist_project_path):
1264         (BaseGenerator._get_output_unified_xcfilelist_project_path):
1265         (BaseGenerator._get_generate_derived_sources_script):
1266         (BaseGenerator._get_generate_unified_sources_script):
1267         (JavaScriptCoreGenerator):
1268         (JavaScriptCoreGenerator._get_project_file_path):
1269         (JavaScriptCoreGenerator._get_generate_derived_sources_script):
1270         (JavaScriptCoreGenerator._get_generate_unified_sources_script):
1271         (WebCoreGenerator):
1272         (WebCoreGenerator._get_project_file_path):
1273         (WebCoreGenerator._get_generate_derived_sources_script):
1274         (WebCoreGenerator._get_generate_unified_sources_script):
1275         (WebKitGenerator):
1276         (WebKitGenerator._get_project_file_path):
1277         (WebKitGenerator._get_derived_sources_dir):
1278         (WebKitGenerator._get_generate_derived_sources_script):
1279         (WebKitGenerator._get_generate_unified_sources_script):
1280         (DumpRenderTreeGenerator):
1281         (DumpRenderTreeGenerator._get_project_file_path):
1282         (DumpRenderTreeGenerator._get_generate_derived_sources_script):
1283         (WebKitTestRunnerGenerator):
1284         (WebKitTestRunnerGenerator._get_project_file_path):
1285         (WebKitTestRunnerGenerator._get_generate_derived_sources_script):
1286         * Scripts/webkitpy/generate_xcfilelists_lib/util.py: Added.
1287         (debug_log):
1288         (LogEntryHelper):
1289         (LogEntryHelper.__init__):
1290         (LogEntryHelper.log_entry):
1291         (LogEntryHelper.log_result):
1292         (LogEntryHelper.log_exception):
1293         (LogEntryHelper._print):
1294         (LogEntryExit):
1295         (LogEntryExit._show_debug_logging):
1296         (LogEntryExitClass):
1297         (LogEntryExitClass._show_debug_logging):
1298         (LogEntryExitGlobal):
1299         (LogEntryExitGlobal._show_debug_logging):
1300         (subprocess_run):
1301         (is_running_under_xcode):
1302         (CheckValidItemAction):
1303         (CheckValidItemAction.__init__):
1304         (CheckValidItemAction.__call__):
1305         (CheckValidItemAction.validate_item):
1306         (CheckCommandAction):
1307         (CheckCommandAction.__call__):
1308         (InvalidCommandError):
1309         (InvalidArgumentError):
1310         (InvalidConfigurationError):
1311         (CalledProcessError):
1312         (CalledProcessError.__str__):
1313         * Scripts/webkitpy/xcode/__init__.py:
1314         (xcode_hash_for_path):
1315         (xcode_hash_for_path.convert_to_string):
1316         * Scripts/webkitpy/xcode/sdk.py: Added.
1317         (SDK):
1318         (SDK.__init__):
1319         (SDK.__repr__):
1320         (SDK.as_xcode_specification):
1321         (SDK.get_preferred_sdk_for_platform):
1322         (SDK._parse_sdk):
1323         * Scripts/webkitpy/xcode/sdk_unittest.py: Added.
1324         (SDKTest):
1325
1326 2019-05-15  Aakash Jain  <aakash_jain@apple.com>
1327
1328         [ews-build] Enabling uploading EWS archives to S3
1329         https://bugs.webkit.org/show_bug.cgi?id=197914
1330
1331         Reviewed by Jonathan Bedard.
1332
1333         * BuildSlaveSupport/Shared: Added.
1334         * BuildSlaveSupport/Shared/transfer-archive-to-s3: Moved from Tools/BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3.
1335         (archiveExists): Replace tab with space.
1336         (main): Added main method.
1337         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1338         (TransferToS3): Updated path to the script.
1339         * BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3: Moved to Shared folder.
1340
1341 2019-05-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1342
1343         inputmode="numeric" should show a number pad with digits 0-9, instead of the numeric keyplane
1344         https://bugs.webkit.org/show_bug.cgi?id=197916
1345         <rdar://problem/50815427>
1346
1347         Reviewed by Timothy Hatcher.
1348
1349         Re-enable this previously flaky test, and rebaseline the result to to expect UIKeyboardTypeNumberPad for
1350         inputmode="numeric".
1351
1352         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1353         (TestWebKitAPI::TEST):
1354
1355 2019-05-15  Youenn Fablet  <youenn@apple.com>
1356
1357         Reuse existing WebPageProxy quota handler for NetworkProcessProxy quota requests
1358         https://bugs.webkit.org/show_bug.cgi?id=197463
1359         <rdar://problem/47403621>
1360
1361         Reviewed by Alex Christensen.
1362
1363         * TestWebKitAPI/Tests/WebKitCocoa/StorageQuota.mm: Added.
1364         (-[QuotaDelegate init]):
1365         (-[QuotaDelegate _webView:decideDatabaseQuotaForSecurityOrigin:currentQuota:currentOriginUsage:currentDatabaseUsage:expectedUsage:decisionHandler:]):
1366         (-[QuotaDelegate quotaDelegateCalled]):
1367         (-[QuotaDelegate grantQuota]):
1368         (-[StorageSchemes webView:startURLSchemeTask:]):
1369         (-[StorageSchemes webView:stopURLSchemeTask:]):
1370         (-[QuotaMessageHandler userContentController:didReceiveScriptMessage:]):
1371         (doTest):
1372
1373 2019-05-15  Youenn Fablet  <youenn@apple.com>
1374
1375         Constant crashes under WebPage::isThrottleable() after r245299
1376         https://bugs.webkit.org/show_bug.cgi?id=197902
1377         <rdar://problem/50793796>
1378
1379         Reviewed by Alex Christensen.
1380
1381         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1382
1383 2019-05-15  Philippe Normand  <pnormand@igalia.com>
1384
1385         [GTK][jhbuild] misc cleanups and bumps
1386         https://bugs.webkit.org/show_bug.cgi?id=197913
1387
1388         Reviewed by Xabier Rodriguez-Calvar.
1389
1390         * gstreamer/jhbuild.modules: Bump to libva 2.4.1 and switch to Meson.
1391         * gtk/jhbuild.modules: Bump to Brotli 1.0.5 and Wayland 1.16.
1392
1393 2019-05-15  Chris Dumez  <cdumez@apple.com>
1394
1395         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
1396         https://bugs.webkit.org/show_bug.cgi?id=195102
1397         <rdar://problem/48456786>
1398
1399         Reviewed by Alex Christensen.
1400
1401         Try to wait longer for the number of processes to reach the expected number
1402         and before failing.
1403
1404         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1405
1406 2019-05-15  Alex Christensen  <achristensen@webkit.org>
1407
1408         Allow NSFileCoordinator to be called from WebContent process
1409         https://bugs.webkit.org/show_bug.cgi?id=197895
1410         <rdar://problem/50107679>
1411
1412         Reviewed by Brent Fulgham.
1413
1414         Add a unit test that verifies calling the block succeeds.
1415
1416         * TestWebKitAPI/Tests/WebKitCocoa/AdditionalReadAccessAllowedURLsPlugin.mm:
1417         (-[AdditionalReadAccessAllowedURLsPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1418
1419 2019-05-14  Andy Estes  <aestes@apple.com>
1420
1421         [Apple Pay] Payment APIs should be completely disabled in web views into which clients have injected user scripts
1422         https://bugs.webkit.org/show_bug.cgi?id=197751
1423         <rdar://problem/50631563>
1424
1425         Reviewed by Alex Christensen.
1426
1427         Added new API tests.
1428
1429         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm:
1430         (-[TestApplePayScriptMessageHandler initWithAPIsAvailableExpectation:canMakePaymentsExpectation:]):
1431         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1432         (TestWebKitAPI::TEST):
1433         (-[TestApplePayScriptMessageHandler initWithExpectation:]): Deleted.
1434         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html:
1435
1436 2019-05-14  Youenn Fablet  <youenn@apple.com>
1437
1438         A service worker process should app nap when all its clients app nap
1439         https://bugs.webkit.org/show_bug.cgi?id=185626
1440         <rdar://problem/46785908>
1441
1442         Reviewed by Alex Christensen.
1443
1444         Allow to enable app nap through test header.
1445
1446         * WebKitTestRunner/TestController.cpp:
1447         (WTR::TestController::resetPreferencesToConsistentValues):
1448         (WTR::updateTestOptionsFromTestHeader):
1449         * WebKitTestRunner/TestOptions.h:
1450         (WTR::TestOptions::hasSameInitializationOptions const):
1451
1452 2019-05-14  Commit Queue  <commit-queue@webkit.org>
1453
1454         Unreviewed, rolling out r245281.
1455         https://bugs.webkit.org/show_bug.cgi?id=197887
1456
1457         Broke API Test TestWebKitAPI.Challenge.ClientCertificate
1458         (Requested by aakashjain on #webkit).
1459
1460         Reverted changeset:
1461
1462         "Add a unit test for client certificate authentication"
1463         https://bugs.webkit.org/show_bug.cgi?id=197800
1464         https://trac.webkit.org/changeset/245281
1465
1466 2019-05-14  Youenn Fablet  <youenn@apple.com>
1467
1468         Add support for webkit-test-runner options to WPT importer
1469         https://bugs.webkit.org/show_bug.cgi?id=197826
1470
1471         Reviewed by Alex Christensen.
1472
1473         In case of overwriting an existing test, check if the existing test
1474         contains a <!-- webkit-test-runner --> comment and insert it back if
1475         needed in the new test.
1476
1477         For exporter, forbid creating a WPT PR if there are changes containing
1478         the webkit-test-runner string.
1479
1480         * Scripts/webkitpy/w3c/test_converter.py:
1481         (convert_for_webkit):
1482         (_W3CTestConverter.__init__):
1483         (_W3CTestConverter.add_webkit_test_runner_options_if_needed):
1484         (_W3CTestConverter.handle_starttag):
1485         (_W3CTestConverter.handle_comment):
1486         (_W3CTestConverter.handle_decl):
1487         (_W3CTestConverter.handle_pi):
1488         * Scripts/webkitpy/w3c/test_exporter.py:
1489         (WebPlatformTestExporter.write_git_patch_file):
1490         (WebPlatformTestExporter.make_pull_request):
1491         * Scripts/webkitpy/w3c/test_importer.py:
1492         (TestImporter.webkit_test_runner_options):
1493         (TestImporter):
1494         (TestImporter.add_webkit_test_runner_options_to_content):
1495         (TestImporter.copy_html_file):
1496         (TestImporter.write_html_template):
1497         (TestImporter.write_html_files_for_templated_js_tests):
1498         (TestImporter.import_tests):
1499         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1500         (test_manual_slow_test):
1501         (test_webkit_test_runner_options):
1502
1503 2019-05-14  Aakash Jain  <aakash_jain@apple.com>
1504
1505         [ews-app] Status bubble should turn orange when any build step fails
1506         https://bugs.webkit.org/show_bug.cgi?id=197812
1507
1508         Reviewed by Jonathan Bedard.
1509
1510         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1511         (StatusBubble._build_bubble): Turn status-bubble orange if there is any failed step in the on-going build.
1512         (StatusBubble._does_build_contains_any_failed_step): Method to check if build contains any failed step.
1513
1514 2019-05-14  Alex Christensen  <achristensen@webkit.org>
1515
1516         Add a unit test for client certificate authentication
1517         https://bugs.webkit.org/show_bug.cgi?id=197800
1518
1519         Reviewed by Youenn Fablet.
1520
1521         Make better abstractions for reading and writing from/to TCPServer.
1522         Add a unit test that causes a client certificate authentication challenge to happen.
1523
1524         * TestWebKitAPI/TCPServer.cpp:
1525         (TestWebKitAPI::TCPServer::TCPServer):
1526         (TestWebKitAPI::TCPServer::read):
1527         (TestWebKitAPI::TCPServer::write):
1528         (TestWebKitAPI::TCPServer::respondWithChallengeThenOK):
1529         (TestWebKitAPI::TCPServer::respondWithOK):
1530         * TestWebKitAPI/TCPServer.h:
1531         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1532         (credentialWithIdentity):
1533         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1534         (TEST):
1535         (-[ClientCertificateDelegate webView:didFinishNavigation:]):
1536         (-[ClientCertificateDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1537         (-[ClientCertificateDelegate challengeCount]):
1538         (TestWebKitAPI::TEST):
1539         (respondWithChallengeThenOK): Deleted.
1540         (credentialWithIdentityAndKeychainPath): Deleted.
1541         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
1542         (TEST):
1543         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
1544         (TestWebKitAPI::TEST):
1545         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1546         (TEST):
1547         (readRequest): Deleted.
1548         (writeResponse): Deleted.
1549         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1550         (TestWebKitAPI::TEST):
1551         (TestWebKitAPI::respondWithChallengeThenOK): Deleted.
1552
1553 2019-05-14  Said Abou-Hallawa  <sabouhallawa@apple.com>
1554
1555         [CG] Adding support for HEIF-sequence ('public.heics') images
1556         https://bugs.webkit.org/show_bug.cgi?id=197384
1557
1558         Reviewed by Simon Fraser.
1559
1560         * DumpRenderTree/TestOptions.cpp:
1561         (TestOptions::TestOptions):
1562         * DumpRenderTree/TestOptions.h:
1563         * DumpRenderTree/mac/DumpRenderTree.mm:
1564         (resetWebViewToConsistentStateBeforeTesting):
1565         Parse the new webkit-test-runner paramter: additionalSupportedImageTypes.
1566         Make DRT call setAdditionalSupportedImageTypesForTesting() before starting
1567         the test.
1568
1569         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1570         (WTR::InjectedBundle::stringForKey):
1571         (WTR::InjectedBundle::beginTesting):
1572         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1573         * WebKitTestRunner/TestController.cpp:
1574         (WTR::TestController::resetStateToConsistentValues):
1575         (WTR::updateTestOptionsFromTestHeader):
1576         * WebKitTestRunner/TestInvocation.cpp:
1577         (WTR::TestInvocation::createTestSettingsDictionary):
1578         * WebKitTestRunner/TestOptions.h:
1579         (WTR::TestOptions::hasSameInitializationOptions const):
1580         Parse the new webkit-test-runner paramter: additionalSupportedImageTypes.
1581         Make WTR call setAdditionalSupportedImageTypesForTesting() before starting
1582         the test.
1583
1584 2019-05-12  Yusuke Suzuki  <ysuzuki@apple.com>
1585
1586         [JSC] Compress Watchpoint size by using enum type and Packed<> data structure
1587         https://bugs.webkit.org/show_bug.cgi?id=197730
1588
1589         Reviewed by Filip Pizlo.
1590
1591         * TestWebKitAPI/CMakeLists.txt:
1592         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1593         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1594         (TestWebKitAPI::TEST):
1595         * TestWebKitAPI/Tests/WTF/Packed.cpp: Added.
1596         (TestWebKitAPI::TEST):
1597
1598 2019-05-10  Chris Dumez  <cdumez@apple.com>
1599
1600         Unreviewed, fix ProcessSwap.OpenerLinkAfterAPIControlledProcessSwappingOfOpener API test
1601
1602         It became flaky after r245198.
1603
1604         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1605
1606 2019-05-10  Youenn Fablet  <youenn@apple.com>
1607
1608         A service worker instance should be terminated when its SWServer is destroyed
1609         https://bugs.webkit.org/show_bug.cgi?id=197801
1610         <rdar://problem/50587270>
1611
1612         Reviewed by Chris Dumez.
1613
1614         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1615
1616 2019-05-10  Chris Dumez  <cdumez@apple.com>
1617
1618         Do not wait until requestPermission() is called to fire deviceorientation events if permission was already granted
1619         https://bugs.webkit.org/show_bug.cgi?id=197750
1620
1621         Reviewed by Geoffrey Garen.
1622
1623         Add API test coverage.
1624
1625         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
1626         (TEST):
1627
1628 2019-05-10  Keith Miller  <keith_miller@apple.com>
1629
1630         Remove legacy test262 import script
1631         https://bugs.webkit.org/show_bug.cgi?id=197788
1632
1633         Reviewed by Yusuke Suzuki.
1634
1635         import-test262-tests doesn't work anymore. We should be using test262-import instead.
1636
1637         * Scripts/import-test262-tests: Removed.
1638
1639 2019-05-10  Charlie Turner  <cturner@igalia.com>
1640
1641         [WPE] Forward libepoxy cflags
1642         https://bugs.webkit.org/show_bug.cgi?id=197784
1643
1644         Reviewed by Žan Doberšek.
1645
1646         Patch by Zan Dobersek.
1647
1648         * wpe/backends/CMakeLists.txt: This is required to keep
1649         -DMESA_EGL_NO_X11_HEADERS in the build, if we don't do this, EGL ends
1650         up trying to include X11 headers even when they're not present in the
1651         environment.
1652
1653 2019-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
1654
1655         Fix a bunch of compiler warnings
1656         https://bugs.webkit.org/show_bug.cgi?id=197785
1657
1658         Reviewed by Don Olmstead.
1659
1660         Add preprocessor guards to avoid -Wunused-function warnings.
1661
1662         * TestWebKitAPI/Tests/WebCore/FloatRect.cpp:
1663         * TestWebKitAPI/Tests/WebCore/IntRect.cpp:
1664         * TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp:
1665
1666 2019-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
1667
1668         [WPE][GTK] Add webkit_frame_get_id() API
1669         https://bugs.webkit.org/show_bug.cgi?id=197270
1670
1671         Reviewed by Carlos Garcia Campos.
1672
1673         This was hard, but I added a test to verify that two different WebKitFrames of the same
1674         WebKitWebPage return two different frame IDs.
1675
1676         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
1677         (WebKitFrameTest::willSubmitFormCallback):
1678         (WebKitFrameTest::testSubframe):
1679         (registerTests):
1680         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
1681         (testWebKitFrameSubframe):
1682         (beforeAll):
1683         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1684         (willSubmitFormCallback):
1685         * TestWebKitAPI/Tests/WebKitGLib/resources/form-in-frame.html: Added.
1686         * TestWebKitAPI/Tests/WebKitGLib/resources/webkitglib-tests.gresource.xml:
1687
1688 2019-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
1689
1690         [WPE][GTK] Add WebKitWebPage::did-associate-form-controls-for-frame and deprecate original did-associate-form-controls
1691         https://bugs.webkit.org/show_bug.cgi?id=197271
1692
1693         Reviewed by Youenn Fablet.
1694
1695         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1696         (formControlsAssociatedForFrameCallback):
1697         (pageCreatedCallback):
1698         (formControlsAssociatedCallback): Deleted.
1699
1700 2019-05-10  Adrian Perez de Castro  <aperez@igalia.com>
1701
1702         [Flatpak] Use the safe PyYAML loader if available
1703         https://bugs.webkit.org/show_bug.cgi?id=197771
1704
1705         Reviewed by Philippe Normand.
1706
1707         * flatpak/flatpakutils.py:
1708         (load_manifest): Use yaml.safe_load() if available, with yaml.load()
1709         still used as fallback when the former is not provided by the module.
1710
1711 2019-05-09  Fujii Hironori  <Hironori.Fujii@sony.com>
1712
1713         WinCairo WebKitTestRunner should take platform/wk2/TestExpectations into account
1714         https://bugs.webkit.org/show_bug.cgi?id=197734
1715
1716         Reviewed by Don Olmstead.
1717
1718         * Scripts/webkitpy/port/win.py:
1719         (WinCairoPort._search_paths): Add 'wk2' and
1720         additional_platform_directory to paths as well as other ports do.
1721
1722 2019-05-09  Daniel Bates  <dabates@apple.com>
1723
1724         [iOS] Numpad comma key has incorrect keyIdentifier property
1725         https://bugs.webkit.org/show_bug.cgi?id=197753
1726         <rdar://problem/50636274>
1727
1728         Reviewed by Brent Fulgham.
1729
1730         Recognize "numpadComma" and return the appropriate HID usage code.
1731
1732         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1733         (hidUsageCodeForCharacter):
1734
1735 2019-05-09  Eric Carlson  <eric.carlson@apple.com>
1736
1737         Refine AudioSession route sharing policy
1738         https://bugs.webkit.org/show_bug.cgi?id=197742
1739         <rdar://problem/50590818>
1740
1741         Reviewed by Darin Adler.
1742
1743         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
1744         (TestWebKitAPI::TEST):
1745
1746 2019-05-09  Alex Christensen  <achristensen@webkit.org>
1747
1748         Remove unnecessary test SPI after r244883
1749         https://bugs.webkit.org/show_bug.cgi?id=197575
1750
1751         Reviewed by Tim Horton.
1752
1753         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1754         (TEST):
1755         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1756         (TestWebKitAPI::TEST):
1757
1758 2019-05-09  Aakash Jain  <aakash_jain@apple.com>
1759
1760         [ews-app] Add migrations file to repository
1761         https://bugs.webkit.org/show_bug.cgi?id=197729
1762
1763         Reviewed by Jonathan Bedard.
1764
1765         * BuildSlaveSupport/ews-app/ews/migrations/0001_initial.py: Added. Auto-generated by Django based on models' information.
1766
1767 2019-05-09  Aakash Jain  <aakash_jain@apple.com>
1768
1769         [ews-build] Fix formatting issues and typos
1770         https://bugs.webkit.org/show_bug.cgi?id=197737
1771
1772         Reviewed by Jonathan Bedard.
1773
1774         * BuildSlaveSupport/ews-build/steps.py:
1775         (CompileWebKit.evaluateCommand): Removed extra empty line.
1776         * BuildSlaveSupport/ews-build/steps_unittest.py:
1777         (TestRunWebKitPerlTests): Fixed typo.
1778         * BuildSlaveSupport/ews-app/ews/models/step.py:
1779         (Step.save_step): Changed log level to info so that it is logged in production.
1780
1781 2019-05-09  Aakash Jain  <aakash_jain@apple.com>
1782
1783         [ews-app] Production and Development env should configure DEBUG appropriately
1784         https://bugs.webkit.org/show_bug.cgi?id=197700
1785
1786         Reviewed by Jonathan Bedard.
1787
1788         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1789
1790 2019-05-09  Xan López  <xan@igalia.com>
1791
1792         [CMake] Detect SSE2 at compile time
1793         https://bugs.webkit.org/show_bug.cgi?id=196488
1794
1795         Reviewed by Carlos Garcia Campos.
1796
1797         * Scripts/webkitdirs.pm:
1798         (generateBuildSystemFromCMakeProject): Do not add SSE2 flags here
1799         for x86 builds. This is now handled in WebKitCompilerFlags.cmake.
1800
1801 2019-05-08  Adrian Perez de Castro  <aperez@igalia.com>
1802
1803         [WPE] Update dependencies to use libwpe + WPEBackend-fdo 1.3.0
1804         https://bugs.webkit.org/show_bug.cgi?id=197697
1805
1806         Reviewed by Žan Doberšek.
1807
1808         * flatpak/org.webkit.WPEModules.yaml: Bump version and update checksums.
1809         * wpe/jhbuild.modules: Ditto.
1810
1811 2019-05-08  Don Olmstead  <don.olmstead@sony.com>
1812
1813         Update ANGLE
1814         https://bugs.webkit.org/show_bug.cgi?id=197676
1815
1816         Reviewed by Alex Christensen.
1817
1818         * TestWebKitAPI/PlatformWin.cmake:
1819         Remove unnecessary library linkage.
1820
1821 2019-05-08  Stephan Szabo  <stephan.szabo@sony.com> and Fujii Hironori  <Hironori.Fujii@sony.com>
1822
1823         [Win] build-webkit should be ready for Visual Studio 2019
1824         https://bugs.webkit.org/show_bug.cgi?id=196622
1825
1826         Reviewed by Ross Kirsling.
1827
1828         1. Accommodated to the new msbuild.exe location of VS 2019.
1829         2. Removed the hard coded "Visual Studio 15" generator.
1830
1831         build-webkit is going to choose a Visual Studio generator version
1832         matching with the latest installed VS. If you invoke vcvars.bat
1833         before build-webkit, it chooses the corresponding Visual Studio
1834         generator version by cheking 'VisualStudioVersion' env var which
1835         is set by vcvars.bat.
1836
1837         * Scripts/webkitdirs.pm: Renamed $vcBuildPath to $msBuildPath. Removed $msBuildInstallDir.
1838         (msBuildPath): When looking for MSBuild, look in
1839         "MSBuild\Current\bin" (the new expected location) and fallback
1840         to "MSBuild\15.0\bin" if we can't find an MSBuild.exe in the
1841         first location.
1842         (msBuildInstallDir): Renamed to msBuildPath.
1843         (generateBuildSystemFromCMakeProject): Use -A switch to specify x64.
1844         Add -G "Visual Studio " switch if a env var 'VisualStudioVersion'
1845
1846 2019-05-08  Don Olmstead  <don.olmstead@sony.com>
1847
1848         [PlayStation] Update port options
1849         https://bugs.webkit.org/show_bug.cgi?id=197723
1850
1851         Reviewed by Ross Kirsling.
1852
1853         ICU headers were missing from TestWTF.
1854
1855         * TestWebKitAPI/PlatformPlayStation.cmake:
1856
1857 2019-05-08  Alex Christensen  <achristensen@webkit.org>
1858
1859         Don't crash when DOMNode.addEventListener:listener:useCapture: is called with a nil listener
1860         https://bugs.webkit.org/show_bug.cgi?id=197712
1861         <rdar://problem/50429770>
1862
1863         Reviewed by Tim Horton.
1864
1865         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm:
1866         (TestWebKitAPI::TEST):
1867
1868 2019-05-08  Jonathan Bedard  <jbedard@apple.com>
1869
1870         Change my status to be a WebKit reviewer.
1871
1872         * Scripts/webkitpy/common/config/contributors.json:
1873
1874 2019-05-08  Ryan Haddad  <ryanhaddad@apple.com>
1875
1876         Unreviewed, rolling out r244952.
1877
1878         Caused inspector to appear blank.
1879
1880         Reverted changeset:
1881
1882         "Web Inspector: Provide UIString descriptions to improve
1883         localizations"
1884         https://bugs.webkit.org/show_bug.cgi?id=195132
1885         https://trac.webkit.org/changeset/244952
1886
1887 2019-05-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1888
1889         TestRunnerWKWebView's menu callbacks should be cleared upon UI script completion
1890         https://bugs.webkit.org/show_bug.cgi?id=197685
1891
1892         Reviewed by Alex Christensen.
1893
1894         Fixes a bug in the test runner wherein didShowMenuCallback and didHideMenuCallback are not reset upon UI script
1895         completion. See LayoutTests/ChangeLog for more details.
1896
1897         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1898         (WTR::UIScriptController::platformClearAllCallbacks):
1899
1900 2019-05-07  Oriol Brufau  <obrufau@igalia.com>
1901
1902         Unreviewed. Add myself as a committer.
1903
1904         * Scripts/webkitpy/common/config/contributors.json:
1905
1906 2019-05-07  Ryan Haddad  <ryanhaddad@apple.com>
1907
1908         Unreviewed, rolling out r245038.
1909
1910         Breaks internal builds.
1911
1912         Reverted changeset:
1913
1914         "Add SPI to set a list of hosts to which to send custom header
1915         fields cross-origin"
1916         https://bugs.webkit.org/show_bug.cgi?id=197397
1917         https://trac.webkit.org/changeset/245038
1918
1919 2019-05-07  Joonghun Park  <pjh0718@gmail.com>
1920
1921         Unreviewed. Add myself as a committer.
1922
1923         * Scripts/webkitpy/common/config/contributors.json:
1924
1925 2019-05-07  Eric Carlson  <eric.carlson@apple.com>
1926
1927         Define media buffering policy
1928         https://bugs.webkit.org/show_bug.cgi?id=196979
1929         <rdar://problem/28383861>
1930
1931         Reviewed by Jer Noble.
1932
1933         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1934         * TestWebKitAPI/Tests/WebKitCocoa/MediaBufferingPolicy.mm: Added.
1935         (waitUntilBufferingPolicyIsEqualTo):
1936         (TEST):
1937
1938 2019-05-07  Alex Christensen  <achristensen@webkit.org>
1939
1940         Add SPI to set a list of hosts to which to send custom header fields cross-origin
1941         https://bugs.webkit.org/show_bug.cgi?id=197397
1942
1943         Reviewed by Geoff Garen.
1944
1945         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1946         (TEST):
1947         (expectLegacyHeaders):
1948         (expectHeaders):
1949         (-[CustomHeaderFieldsDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
1950         (-[CustomHeaderFieldsDelegate webView:startURLSchemeTask:]):
1951         (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
1952
1953 2019-05-07  Keith Rollin  <krollin@apple.com>
1954
1955         Add option to build-webkit to control whether or not XCBuild is used
1956         https://bugs.webkit.org/show_bug.cgi?id=197668
1957         <rdar://problem/50549728>
1958
1959         Reviewed by Tim Horton.
1960
1961         Add --[no-]xcbuild to build-webkit to force the use of XCBuild or not.
1962         Also update build-webkit and the makefiles with the foundation for
1963         automatically using XCBuild when the conditions allow it. This latter
1964         facility is currently turned off until Xcode fully supports building
1965         WebKit with XCBuild.
1966
1967         * Scripts/build-webkit:
1968         * Scripts/webkitdirs.pm:
1969         (XcodeOptions):
1970         (canUseXCBuild):
1971
1972 2019-05-07  Andy Estes  <aestes@apple.com>
1973
1974         run-bindings-tests should test global scope constructor generation
1975         https://bugs.webkit.org/show_bug.cgi?id=197669
1976
1977         Reviewed by Alex Christensen.
1978
1979         * Scripts/webkitpy/bindings/main.py:
1980         Updated to specify --testGlobalContextName and --testGlobalScopeConstructorsFile when
1981         invoking preprocess-idls.pl.
1982
1983 2019-05-07  Youenn Fablet  <youenn@apple.com>
1984
1985         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageDefaultDirectories
1986         https://bugs.webkit.org/show_bug.cgi?id=195997
1987         <rdar://problem/50509884>
1988
1989         Reviewed by Chris Dumez.
1990
1991         Spin test until successful.
1992
1993         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1994
1995 2019-05-07  Adrian Perez de Castro  <aperez@igalia.com>
1996
1997         [Flatpak] webkit-build fails due to missing GTK2 in build environment
1998         https://bugs.webkit.org/show_bug.cgi?id=197352
1999
2000         Reviewed by Philippe Normand.
2001
2002         The Flatpak runtimes do not include GTK 2.x anymore, which means that we need
2003         to build it ourselves on top in order to be able to build the GTK 2.x plugin
2004         process.
2005
2006         * flatpak/org.webkit.GTK.yaml: Add gtk2 package.
2007
2008 2019-05-07  Wenson Hsieh  <wenson_hsieh@apple.com>
2009
2010         [macOS] Avoid crashing the UI process when writing empty data to the pasteboard
2011         https://bugs.webkit.org/show_bug.cgi?id=197644
2012         <rdar://problem/50526364>
2013
2014         Reviewed by Tim Horton.
2015
2016         Add a new API test to exercise a possible scenario where we may crash while writing data to the pasteboard.
2017
2018         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegate.mm:
2019         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
2020         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2021         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:pasteboardDataForRange:]):
2022
2023 2019-05-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2024
2025         [GTK][WPE] MiniBrowser: load about:blank for new web views in automation mode
2026         https://bugs.webkit.org/show_bug.cgi?id=197651
2027
2028         Reviewed by Žan Doberšek.
2029
2030         This is required since the process creation was delayed until something is loaded in the view.
2031
2032         * MiniBrowser/gtk/BrowserWindow.c:
2033         (browser_window_get_or_create_web_view_for_automation):
2034         * MiniBrowser/wpe/main.cpp:
2035         (main):
2036
2037 2019-05-06  Tim Horton  <timothy_horton@apple.com>
2038
2039         _overrideViewportWithArguments does not work when called before loading
2040         https://bugs.webkit.org/show_bug.cgi?id=197638
2041         <rdar://problem/50505111>
2042
2043         Reviewed by Wenson Hsieh.
2044
2045         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
2046         (TEST):
2047
2048 2019-05-04  Per Arne Vollan  <pvollan@apple.com>
2049
2050         -[WKWebsiteDataStore removeDataOfTypes:forDataRecords:completionHandler:] doesn't delete _WKWebsiteDataTypeCredentials
2051         https://bugs.webkit.org/show_bug.cgi?id=197510
2052
2053         Reviewed by Alex Christensen.
2054
2055         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
2056         (TestWebKitAPI::TEST):
2057
2058 2019-05-06  Keith Rollin  <krollin@apple.com>
2059
2060         Temporarily disable generate-xcfilelists
2061         https://bugs.webkit.org/show_bug.cgi?id=197619
2062         <rdar://problem/50507392>
2063
2064         Reviewed by Alex Christensen.
2065
2066         We need to perform a significant update to the generate-xcfilelist
2067         scripts. This work involves coordinated work with another facility. If
2068         the work does not occur in tandem, the build will be broken. To avoid
2069         this, disable the invoking of the scripts during the transition. The
2070         checking will be restored once the new scripts are in place.
2071
2072         * DumpRenderTree/Scripts/check-xcfilelists.sh:
2073         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
2074
2075 2019-05-04  Alex Christensen  <achristensen@webkit.org>
2076
2077         Revert r244953 and r244954 because they broke internal builds.
2078         https://bugs.webkit.org/show_bug.cgi?id=197534
2079
2080         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
2081         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
2082         * DumpRenderTree/mac/DumpRenderTree.mm:
2083         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2084         * DumpRenderTree/mac/TestRunnerMac.mm:
2085         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2086         * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
2087         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2088         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
2089         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
2090         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
2091         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindString.mm:
2092         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2093         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2094         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2095         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2096         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
2097         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2098         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2099         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
2100         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2101         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2102         * TestWebKitAPI/ios/UIKitSPI.h: Added.
2103         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2104         * WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:
2105         * WebKitTestRunner/ios/HIDEventGenerator.h:
2106         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2107         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2108         * WebKitTestRunner/ios/TestControllerIOS.mm:
2109         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2110         * WebKitTestRunner/ios/mainIOS.mm:
2111
2112 2019-05-04  Alex Christensen  <achristensen@webkit.org>
2113
2114         Merge the three UIKitSPI.h files into a single one in PAL
2115         https://bugs.webkit.org/show_bug.cgi?id=197534
2116
2117         Reviewed by Darin Adler.
2118
2119         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
2120         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
2121         * DumpRenderTree/mac/DumpRenderTree.mm:
2122         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2123         * DumpRenderTree/mac/TestRunnerMac.mm:
2124         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2125         * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
2126         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2127         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
2128         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
2129         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
2130         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindString.mm:
2131         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2132         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2133         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2134         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2135         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
2136         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2137         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2138         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
2139         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2140         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2141         * TestWebKitAPI/ios/UIKitSPI.h: Removed.
2142         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2143         * WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:
2144         * WebKitTestRunner/ios/HIDEventGenerator.h:
2145         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2146         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2147         * WebKitTestRunner/ios/TestControllerIOS.mm:
2148         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2149         * WebKitTestRunner/ios/mainIOS.mm:
2150
2151 2019-05-04  Nikita Vasilyev  <nvasilyev@apple.com>
2152
2153         Web Inspector: Provide UIString descriptions to improve localizations
2154         https://bugs.webkit.org/show_bug.cgi?id=195132
2155         <rdar://problem/48457817>
2156
2157         Reviewed by Devin Rousso.
2158
2159         Allow WI.UIString to take:
2160         - WI.UIString(string, key, comment)
2161         - WI.UIString(string, comment)
2162         - WI.UIString(string)
2163
2164         * Scripts/extract-localizable-js-strings:
2165
2166 2019-05-03  Wenson Hsieh  <wenson_hsieh@apple.com>
2167
2168         REGRESSION (r244897): Caret may appear wider than normal after zooming to focus an editable element
2169         https://bugs.webkit.org/show_bug.cgi?id=197579
2170
2171         Reviewed by Tim Horton.
2172
2173         Fixes a couple of flaky layout tests (ModifyInputAssistantItemBarButtonGroups and
2174         OverrideInputAssistantItemBarButtonGroups) by programmatically blurring focused elements and waiting for the
2175         input session to change, rather than relying on -resignFirstResponder and -waitForNextPresentationUpdate to
2176         ensure that the the focused element has been blurred.
2177
2178         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2179
2180 2019-05-02  Alexey Proskuryakov  <ap@apple.com>
2181
2182         Add a tool to block spammer accounts
2183         https://bugs.webkit.org/show_bug.cgi?id=197537
2184
2185         Reviewed by Darin Adler.
2186
2187         Usage: block-spammers email1 email2 ...
2188
2189         The tool finds and hides all bugs and comments from this account. Before any work
2190         is done, these bugs and comments are displayed for confirmation.
2191
2192         * Scripts/block-spammers: Added.
2193         (get_bugzilla_token):
2194         (invalidate_bugzilla_token):
2195         (get_user_info):
2196         (get_user_info_self):
2197         (can_use_this_tool):
2198         (disable_user):
2199         (get_bugs_created_by_user):
2200         (get_bugs_commented_on_by_user):
2201         (get_comments):
2202         (hide_bug):
2203         (hide_comments):
2204         (ask_yes_no):
2205         (sanitized_string):
2206         (main):
2207
2208 2019-05-03  Jonathan Bedard  <jbedard@apple.com>
2209
2210         run-apit-tests: Add --iterations and --repeat-each
2211         https://bugs.webkit.org/show_bug.cgi?id=197563
2212
2213         Reviewed by Aakash Jain.
2214
2215         * Scripts/webkitpy/api_tests/manager.py:
2216         (Manager.run): Add --iterations and --repeat-each/
2217         * Scripts/webkitpy/api_tests/run_api_tests.py:
2218         (parse_args): Duplicate the test list based on --iterations and --repeat-each.
2219
2220 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
2221
2222         New EWS: Clicking on white bubble navigates to page with only bubbles
2223         https://bugs.webkit.org/show_bug.cgi?id=197520
2224
2225         Reviewed by Lucas Forschler.
2226
2227         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Disable clicking if bubble doesn't have any url.
2228
2229 2019-05-03  Daniel Bates  <dabates@apple.com>
2230
2231         [lldb-webkit] Support adding pretty-printing for qualified types
2232         https://bugs.webkit.org/show_bug.cgi?id=197518
2233
2234         Reviewed by Darin Adler.
2235
2236         Remove all "::"s from the name of the specified type when computing the name for the Python classes
2237         that will provide summary and synthetic details as LLDB is not happy about registering such classes
2238         when they contain :: in their name.
2239
2240         * lldb/lldb_webkit.py:
2241         (addSummaryAndSyntheticFormattersForRawBitmaskType):
2242
2243 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
2244
2245         New EWS: patches on recently added queues listed as #1 for older bugs
2246         https://bugs.webkit.org/show_bug.cgi?id=197496
2247
2248         Reviewed by Lucas Forschler.
2249
2250         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2251         (StatusBubble._build_bubble):
2252         (StatusBubble._queue_position):
2253
2254 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
2255
2256         webkit-patch --no-review upload does not submit patch to New EWS
2257         https://bugs.webkit.org/show_bug.cgi?id=197519
2258         <rdar://problem/50424887>
2259
2260         Reviewed by Lucas Forschler.
2261
2262         * Scripts/webkitpy/tool/steps/submittoews.py:
2263         (SubmitToEWS.run): Submit to both old and new EWS.
2264         * Scripts/webkitpy/common/config/urls.py: Added url for new EWS server.
2265         * Scripts/webkitpy/common/net/ewsserver.py: Added.
2266         (EWSServer._server_url): Method to return server url.
2267         (EWSServer._post_patch_to_ews): Method to post patch to ews.
2268         (EWSServer.submit_to_ews): Method to submit the patch to ews using NetworkTransaction.
2269         * Scripts/webkitpy/common/net/ewsserver_mock.py: Added Mock EWS Server.
2270         * Scripts/webkitpy/common/net/ewsserver_unittest.py: Added unit-test for EWS Server.
2271         * Scripts/webkitpy/common/net/statusserver_mock.py:
2272         (MockStatusServer.submit_to_ews): Updated the log text.
2273         * Scripts/webkitpy/tool/commands/queues_unittest.py: Updated unit-tests.
2274         * Scripts/webkitpy/tool/commands/upload_unittest.py: Ditto.
2275         * Scripts/webkitpy/tool/main.py:
2276         (WebKitPatch.__init__): Initialize ews_server. 
2277         * Scripts/webkitpy/tool/mocktool.py:
2278         (MockTool.__init__): Ditto.
2279
2280 2019-05-03  Chris Dumez  <cdumez@apple.com>
2281
2282         ASSERTION FAILED: [weakThis->m_view window] == weakThis->m_targetWindowForMovePreparation
2283         https://bugs.webkit.org/show_bug.cgi?id=197574
2284         <rdar://problem/50453181>
2285
2286         Reviewed by Tim Horton.
2287
2288         Add API test coverage.
2289
2290         * TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
2291         (TEST):
2292
2293 2019-05-03  Yusuke Suzuki  <ysuzuki@apple.com>
2294
2295         [JSC] Generator CodeBlock generation should be idempotent
2296         https://bugs.webkit.org/show_bug.cgi?id=197552
2297
2298         Reviewed by Keith Miller.
2299
2300         * Scripts/run-javascriptcore-tests:
2301         (runJSCStressTests):
2302         * Scripts/run-jsc-stress-tests:
2303
2304 2019-05-03  Commit Queue  <commit-queue@webkit.org>
2305
2306         Unreviewed, rolling out r244881.
2307         https://bugs.webkit.org/show_bug.cgi?id=197559
2308
2309         Breaks compilation of jsconly on linux, breaking compilation
2310         for jsc-i386-ews, jsc-mips-ews and jsc-armv7-ews (Requested by
2311         guijemont on #webkit).
2312
2313         Reverted changeset:
2314
2315         "[CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into
2316         WEBKIT_COPY_FILES"
2317         https://bugs.webkit.org/show_bug.cgi?id=197174
2318         https://trac.webkit.org/changeset/244881
2319
2320 2019-05-03  Zan Dobersek  <zdobersek@igalia.com>
2321
2322         Unreviewed WPE build fix after r244898.
2323
2324         * WebKitTestRunner/wpe/TestControllerWPE.cpp:
2325         (WTR::TestController::abortModal): Add the missing (no-op) definition.
2326
2327 2019-05-02  Alex Christensen  <achristensen@webkit.org>
2328
2329         Mark U+01C0 as a homograph of U+006C
2330         https://bugs.webkit.org/show_bug.cgi?id=197526
2331         <rdar://problem/50301904>
2332
2333         Reviewed by Tim Horton.
2334
2335         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
2336         (TestWebKitAPI::TEST):
2337
2338 2019-05-02  Chris Dumez  <cdumez@apple.com>
2339
2340         Add test coverage for <rdar://problem/49731231>
2341         https://bugs.webkit.org/show_bug.cgi?id=196730
2342         <rdar://problem/49731231>
2343
2344         Reviewed by Ryosuke Niwa.
2345
2346         Add support for testRunner.abortModal() in macOS's WebKitTestRunner in order
2347         to match DumpRenderTree.
2348
2349         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2350         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2351         (WTR::TestRunner::abortModal):
2352         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2353         * WebKitTestRunner/TestController.cpp:
2354         (WTR::TestController::runModal):
2355         * WebKitTestRunner/TestController.h:
2356         * WebKitTestRunner/TestInvocation.cpp:
2357         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2358         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2359         (WTR::TestController::abortModal):
2360         * WebKitTestRunner/ios/TestControllerIOS.mm:
2361         (WTR::TestController::abortModal):
2362         * WebKitTestRunner/mac/TestControllerMac.mm:
2363         (WTR::TestController::abortModal):
2364         * WebKitTestRunner/win/TestControllerWin.cpp:
2365         (WTR::TestController::abortModal):
2366
2367 2019-05-02  Christopher Reid  <chris.reid@sony.com>
2368
2369         [CMake] Add support for LTO builds
2370         https://bugs.webkit.org/show_bug.cgi?id=188986
2371
2372         Reviewed by Don Olmstead.
2373
2374         Add support to configure --lto-mode with cmake builds.
2375
2376         * Scripts/build-webkit:
2377         * Scripts/webkitdirs.pm:
2378         (generateBuildSystemFromCMakeProject):
2379
2380 2019-05-02  John Wilander  <wilander@apple.com>
2381
2382         Make both filterForRegistrableDomains() in WebKit::NetworkProcess use WebCore::RegistrableDomain::uncheckedCreateFromHost()
2383         https://bugs.webkit.org/show_bug.cgi?id=197521
2384         <rdar://problem/49651503>
2385
2386         Reviewed by Brent Fulgham.
2387
2388         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
2389         (TestWebKitAPI::TEST):
2390            Added a test for host strings with leading dots since they are
2391            often used for the domain attribute in cookies.
2392
2393 2019-05-02  Per Arne Vollan  <pvollan@apple.com>
2394
2395         -[WKWebsiteDataStore removeDataOfTypes:forDataRecords:completionHandler:] doesn't delete _WKWebsiteDataTypeCredentials
2396         https://bugs.webkit.org/show_bug.cgi?id=197510
2397
2398         Reviewed by Alex Christensen.
2399
2400         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
2401         (TestWebKitAPI::TEST):
2402
2403 2019-05-02  Don Olmstead  <don.olmstead@sony.com>
2404
2405         [CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into WEBKIT_COPY_FILES
2406         https://bugs.webkit.org/show_bug.cgi?id=197174
2407
2408         Reviewed by Alex Christensen.
2409
2410         Make TestJSC dependent on JavaScriptCorePrivateFrameworkHeaders.
2411
2412         * TestWebKitAPI/PlatformGTK.cmake:
2413         * TestWebKitAPI/PlatformWPE.cmake:
2414
2415 2019-05-02  Alex Christensen  <achristensen@webkit.org>
2416
2417         Build fix for internal branch.
2418
2419         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
2420         RetainPtr.h was not explicitly included.
2421
2422 2019-05-02  Jonathan Bedard  <jbedard@apple.com>
2423
2424         webkitpy: Ignore errors when shutting down an already shutdown simulator
2425         <https://bugs.webkit.org/show_bug.cgi?id=197514>
2426         <rdar://problem/50390247>
2427
2428         Reviewed by Lucas Forschler.
2429
2430         * Scripts/webkitpy/xcode/simulated_device.py:
2431         (SimulatedDevice._shut_down):
2432
2433 2019-05-02  Frederic Wang  <fwang@igalia.com>
2434
2435         [GTK][WPE] Disable "thin", "thick", "medium" values of mfrac@linethickness at runtime
2436         https://bugs.webkit.org/show_bug.cgi?id=196142
2437
2438         This patch introduces some experimental runtime flag to let users
2439         disable MathML features that are removed from MathML Core [1]. For now,
2440         these features are only disabled on GTK and WPE ports.
2441
2442         [1] https://mathml-refresh.github.io/mathml-core/
2443
2444         Reviewed by Rob Buis.
2445
2446         * DumpRenderTree/TestOptions.cpp:
2447         (TestOptions::TestOptions):
2448         * DumpRenderTree/TestOptions.h:
2449         * DumpRenderTree/mac/DumpRenderTree.mm:
2450         (setWebPreferencesForTestOptions):
2451
2452 2019-05-01  Don Olmstead  <don.olmstead@sony.com>
2453
2454         TestWebKitAPI config.h should be aware of what suite is being built
2455         https://bugs.webkit.org/show_bug.cgi?id=196583
2456
2457         Reviewed by Konstantin Tokarev.
2458
2459         Migrate to WEBKIT_EXECUTABLE to define the Test* executables. As an added
2460         benefit the macro defines BUILDING_* for the executable which allows the includes
2461         of the config.h to be tailored to the test suite being built. Because of that the
2462         dependencies of the Test* executable are specific to the test suite which may
2463         speed up the build.
2464
2465         Some source files were including "PlatformUtilities.h" which includes WebKit headers
2466         when "Utilities.h" is what was needed.
2467
2468         * TestWebKitAPI/CMakeLists.txt:
2469         * TestWebKitAPI/PlatformGTK.cmake:
2470         * TestWebKitAPI/PlatformJSCOnly.cmake:
2471         * TestWebKitAPI/PlatformMac.cmake:
2472         * TestWebKitAPI/PlatformPlayStation.cmake:
2473         * TestWebKitAPI/PlatformUtilities.h:
2474         * TestWebKitAPI/PlatformWPE.cmake:
2475         * TestWebKitAPI/PlatformWin.cmake:
2476         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
2477         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2478         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
2479         * TestWebKitAPI/Tests/WebCore/LineBreaking.mm:
2480         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm:
2481         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
2482         * TestWebKitAPI/config.h:
2483
2484 2019-05-01  Jiewen Tan  <jiewen_tan@apple.com>
2485
2486         Move Document::domainIsRegisterable to SecurityOrigin::isMatchingRegistrableDomainSuffix
2487         https://bugs.webkit.org/show_bug.cgi?id=181950
2488         <rdar://problem/43357371>
2489
2490         Reviewed by Brent Fulgham.
2491
2492         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
2493         (TestWebKitAPI::TEST_F):
2494
2495 2019-05-01  Aakash Jain  <aakash_jain@apple.com>
2496
2497         Remove webkitpy and bindings EWS queues from dashboard
2498         https://bugs.webkit.org/show_bug.cgi?id=197475
2499
2500         Reviewed by Alexey Proskuryakov.
2501
2502         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2503
2504 2019-05-01  Aakash Jain  <aakash_jain@apple.com>
2505
2506         Remove webkitpy and bindings test queues from old EWS
2507         https://bugs.webkit.org/show_bug.cgi?id=197468
2508
2509         Reviewed by Alexey Proskuryakov.
2510
2511         * QueueStatusServer/config/queues.py:
2512
2513 2019-04-30  Tim Horton  <timothy_horton@apple.com>
2514
2515         Fix the WebKitTestRunner build
2516         https://bugs.webkit.org/show_bug.cgi?id=197449
2517         <rdar://problem/50334169>
2518
2519         Reviewed by Alexey Proskuryakov.
2520
2521         * WebKitTestRunner/mac/EventSenderProxy.mm:
2522         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
2523         (WTR::EventSenderProxy::mouseForceChanged):
2524         Use some SPI instead of IPI.
2525
2526 2019-04-30  Chris Dumez  <cdumez@apple.com>
2527
2528         Regression(PSON) URL scheme handlers can no longer respond asynchronously
2529         https://bugs.webkit.org/show_bug.cgi?id=197426
2530         <rdar://problem/50256169>
2531
2532         Reviewed by Brady Eidson.
2533
2534         Add API test coverage.
2535
2536         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2537         (-[PSONScheme setShouldRespondAsynchronously:]):
2538         (-[PSONScheme webView:startURLSchemeTask:]):
2539         (-[PSONScheme webView:stopURLSchemeTask:]):
2540
2541 2019-04-30  Chris Dumez  <cdumez@apple.com>
2542
2543         Unreviewed, rolling out r244802.
2544
2545         Caused an API test failure
2546
2547         Reverted changeset:
2548
2549         "Regression(PSON) URL scheme handlers can no longer respond
2550         asynchronously"
2551         https://bugs.webkit.org/show_bug.cgi?id=197426
2552         https://trac.webkit.org/changeset/244802
2553
2554 2019-04-30  Chris Dumez  <cdumez@apple.com>
2555
2556         Regression(PSON) URL scheme handlers can no longer respond asynchronously
2557         https://bugs.webkit.org/show_bug.cgi?id=197426
2558         <rdar://problem/50256169>
2559
2560         Reviewed by Brady Eidson.
2561
2562         Add API test coverage.
2563
2564         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2565         (-[PSONScheme setShouldRespondAsynchronously:]):
2566         (-[PSONScheme webView:startURLSchemeTask:]):
2567         (-[PSONScheme webView:stopURLSchemeTask:]):
2568
2569 2019-04-30  Chris Dumez  <cdumez@apple.com>
2570
2571         Only use a related page's process if that page has not been closed yet
2572         https://bugs.webkit.org/show_bug.cgi?id=197393
2573         <rdar://problem/50302423>
2574
2575         Reviewed by Tim Horton.
2576
2577         Add API test coverage.
2578
2579         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2580
2581 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
2582
2583         [ews-build] Enable Bindings tests queue on new EWS
2584         https://bugs.webkit.org/show_bug.cgi?id=197424
2585
2586         Reviewed by Lucas Forschler.
2587
2588         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2589         (StatusBubble):
2590         * BuildSlaveSupport/ews-build/config.json:
2591
2592 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
2593
2594         [ews-build] Configure ews151 for running various tests
2595         https://bugs.webkit.org/show_bug.cgi?id=197419
2596
2597         Reviewed by Lucas Forschler.
2598
2599         * BuildSlaveSupport/ews-build/config.json:
2600
2601 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
2602
2603         [ews-build] Parse and display bindings test failures
2604         https://bugs.webkit.org/show_bug.cgi?id=197423
2605
2606         Reviewed by Lucas Forschler.
2607
2608         * BuildSlaveSupport/ews-build/steps.py:
2609         (RunBindingsTests.__init__): Set timeout of 5 minutes.
2610         (RunBindingsTests.start): Initialize log_observer for json output.
2611         (RunBindingsTests.getResultSummary): Update step and build summary based on bindings test results.
2612         (RunBindingsTests._addToLog): Method to add message to log.
2613         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
2614
2615 2019-04-30  Pablo Saavedra  <psaavedra@igalia.com>
2616
2617         Unreviewed. Add myself as a committer.
2618
2619         * Scripts/webkitpy/common/config/contributors.json:
2620
2621 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
2622
2623         [ews-build] Enable webkitpy queue on new EWS
2624         https://bugs.webkit.org/show_bug.cgi?id=197396
2625
2626         Reviewed by Lucas Forschler.
2627
2628         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2629         (StatusBubble):
2630         * BuildSlaveSupport/ews-build/config.json:
2631
2632 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
2633
2634         [ews-build] Parse and display webkitpy failures
2635         https://bugs.webkit.org/show_bug.cgi?id=197395
2636
2637         Reviewed by Lucas Forschler.
2638
2639         * BuildSlaveSupport/ews-build/steps.py:
2640         (RunWebKitPyTests.start): Initialize log_observer for json output.
2641         (RunWebKitPyTests.getResultSummary): Update step and build summary based on webkitpy results.
2642         (RunWebKitPyTests._addToLog): Method to add message to log.
2643         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
2644
2645 2019-04-29  Alex Christensen  <achristensen@webkit.org>
2646
2647         <rdar://problem/50299396> Fix internal High Sierra build
2648         https://bugs.webkit.org/show_bug.cgi?id=197388
2649
2650         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2651         * MiniBrowser/Configurations/Base.xcconfig:
2652         * MobileMiniBrowser/Configurations/Base.xcconfig:
2653         * TestWebKitAPI/Configurations/Base.xcconfig:
2654         * WebKitTestRunner/Configurations/Base.xcconfig:
2655
2656 2019-04-29  Youenn Fablet  <youenn@apple.com>
2657
2658         Remove spurious GVA printf logging
2659         https://bugs.webkit.org/show_bug.cgi?id=197368
2660         <rdar://problem/35975256>
2661
2662         Reviewed by Alexey Proskuryakov.
2663
2664         * Scripts/webkitpy/port/mac.py:
2665         (MacPort.logging_patterns_to_strip):
2666
2667 2019-04-29  Youenn Fablet  <youenn@apple.com>
2668
2669         getDisplayMedia should be called on user gesture
2670         https://bugs.webkit.org/show_bug.cgi?id=197356
2671         <rdar://problem/50296074>
2672
2673         Reviewed by Eric Carlson.
2674
2675         Update test configuration to inject internals
2676         so that we can use it to simulate a user click to call getDisplayMedia.
2677
2678         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
2679         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
2680         (TestWebKitAPI::GetDisplayMediaTest::SetUp):
2681
2682 2019-04-26  Stephanie Lewis  <slewis@apple.com>
2683
2684         run-benchmarks should have an intial prep and restore env call for tasks that are too expensive to do for every iteration
2685         https://bugs.webkit.org/show_bug.cgi?id=197339
2686
2687         Reviewed by Dewei Zhu.
2688
2689         Add two new functions prepare_inital_env and restore_env_after_all_testing around the entire
2690         test run for setup steps that are too expensive to do every iteration.
2691
2692         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2693         (BenchmarkRunner._run_benchmark):
2694         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2695         (BrowserDriver):
2696         (BrowserDriver.prepare_initial_env):
2697         (BrowserDriver.restore_env_after_all_testing):
2698         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
2699         (LinuxBrowserDriver.prepare_initial_env):
2700         (LinuxBrowserDriver.restore_env_after_all_testing):
2701         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2702         (OSXBrowserDriver.prepare_initial_env):
2703         (OSXBrowserDriver.restore_env_after_all_testing):
2704
2705 2019-04-28  Andy Estes  <aestes@apple.com>
2706
2707         Fix the watchOS engineering build.
2708
2709         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
2710         (TestWebKitAPI::TEST): AVVideoPerformanceMetrics does not exist on watchOS.
2711
2712 2019-04-27  Chris Dumez  <cdumez@apple.com>
2713
2714         [WKTR] Move test timeout handling to the UIProcess
2715         https://bugs.webkit.org/show_bug.cgi?id=197333
2716
2717         Reviewed by Darin Adler.
2718
2719         Move test timeout handling in WebKitTestRunner to the UIProcess to play nicely with PSON. Previously,
2720         we'd start the timeout timer in the InjectedBundle, which would fail to account of the time spent in
2721         every WebContent process in the case of swapping.
2722
2723         Also, because of process caching, the timeout timer would sometime fire in a cached process and it
2724         would lead to crashes when firing the timer.
2725
2726         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2727         (WTR::InjectedBundle::didReceiveMessageToPage):
2728         (WTR::InjectedBundle::done):
2729         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2730         (WTR::InjectedBundle::shouldDumpPixels const):
2731         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2732         (WTR::TestRunner::TestRunner):
2733         (WTR::TestRunner::waitUntilDone):
2734         (WTR::TestRunner::setWaitUntilDone):
2735         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2736         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
2737         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2738         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
2739         * WebKitTestRunner/InjectedBundle/wpe/TestRunnerWPE.cpp:
2740         * WebKitTestRunner/TestInvocation.cpp:
2741         (WTR::TestInvocation::TestInvocation):
2742         (WTR::TestInvocation::createTestSettingsDictionary):
2743         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2744         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2745         (WTR::TestInvocation::initializeWaitToDumpWatchdogTimerIfNeeded):
2746         (WTR::TestInvocation::invalidateWaitToDumpWatchdogTimer):
2747         (WTR::TestInvocation::waitToDumpWatchdogTimerFired):
2748         (WTR::TestInvocation::setWaitUntilDone):
2749         (WTR::TestInvocation::done):
2750         * WebKitTestRunner/TestInvocation.h:
2751
2752 2019-04-25  Yusuke Suzuki  <ysuzuki@apple.com>
2753
2754         [JSC] linkPolymorphicCall now does GC
2755         https://bugs.webkit.org/show_bug.cgi?id=197306
2756
2757         Reviewed by Saam Barati.
2758
2759         The test is sensitive to allocations and even adding $vm makes it non-reproducible.
2760         To add this test, we add `runWithoutBaseOption`.
2761
2762         * Scripts/run-jsc-stress-tests:
2763
2764 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
2765
2766         Update inactive reviewers' status to 'contributor'.
2767
2768         Accidentally skipped one at first.
2769
2770         * Scripts/webkitpy/common/config/contributors.json:
2771
2772 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
2773
2774         Update inactive reviewers' status to 'contributor'.
2775
2776         * Scripts/webkitpy/common/config/contributors.json: The change.
2777
2778         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2779         * Scripts/webkitpy/common/checkout/checkout_mock.py:
2780         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2781         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
2782         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2783         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
2784         * Scripts/webkitpy/tool/commands/queries_unittest.py:
2785         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2786         Sadly, regression tests operate on a crazy mix of mock and live data for
2787         contributors.json. It would be a substantial project to mock all code paths,
2788         so changing the tests instead.
2789
2790 2019-04-26  Eric Carlson  <eric.carlson@apple.com>
2791
2792         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
2793         https://bugs.webkit.org/show_bug.cgi?id=197171
2794         <rdar://problem/47454979>
2795
2796         Reviewed by Youenn Fablet.
2797
2798         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2799         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
2800         (TestWebKitAPI::TEST):
2801
2802 2019-04-26  David Kilzer  <ddkilzer@apple.com>
2803
2804         WebKitTestRunner leaks an NSDictionary and multiple JSStringRef objects
2805         <https://webkit.org/b/197314>
2806         <rdar://problem/50245252>
2807
2808         Reviewed by Simon Fraser.
2809
2810         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2811         (WTR::UIScriptController::lastUndoLabel const):
2812         (WTR::UIScriptController::firstRedoLabel const):
2813         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
2814
2815         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2816         (-[HIDEventGenerator sendEventStream:completionBlock:]):
2817         - Call -autorelease to fix leak of NSDictionary.
2818
2819         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2820         (WTR::UIScriptController::accessibilitySpeakSelectionContent const):
2821         (WTR::UIScriptController::selectFormPopoverTitle const):
2822         (WTR::UIScriptController::textContentType const):
2823         (WTR::UIScriptController::formInputLabel const):
2824         (WTR::UIScriptController::scrollingTreeAsText const):
2825         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
2826
2827 2019-04-26  Jonathan Bedard  <jbedard@apple.com>
2828
2829         webkitpy: Running a single test will always use the default device
2830         https://bugs.webkit.org/show_bug.cgi?id=195472
2831         <rdar://problem/48724825>
2832
2833         Reviewed by Lucas Forschler.
2834
2835         It makes more sense to have the Manager class handle the case where a user specifically requests a test which is
2836         skipped on the current configuration. This changes the behavior when running part of a test shard, now tests explicitly
2837         requested will be run regardless of what shard they are in.
2838
2839         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
2840         (LayoutTestFinder.skip_tests): Caller should manage running skipped tests which were explicitly requested.
2841         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2842         (Manager.run): If a test is marked as skipped for the configuration, but was specifically requested, run it anyways
2843         on the default device type.
2844         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2845         (RunTest.test_run_chunk): Explicitly requesting a test will override sharing behavior.
2846         (RunTest.test_run_part): Ditto.
2847
2848 2019-04-26  Alex Christensen  <achristensen@webkit.org>
2849
2850         Add ENABLE(CONTENT_EXTENSIONS) and namespace ContentExtensions to ResourceLoadInfo.h
2851         https://bugs.webkit.org/show_bug.cgi?id=197165
2852
2853         Reviewed by Youenn Fablet.
2854
2855         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2856
2857 2019-04-26  Ryan Haddad  <ryanhaddad@apple.com>
2858
2859         Replace iOS build queue hardware
2860         https://bugs.webkit.org/show_bug.cgi?id=197312
2861
2862         Reviewed by Aakash Jain.
2863
2864         * BuildSlaveSupport/build.webkit.org-config/config.json:
2865         Use newer hardware that supports macOS Mojave.
2866
2867 2019-04-26  Yoshiaki Jitsukawa  <yoshiaki.jitsukawa@sony.com>
2868
2869         check-webkit-style complains the first block in while loop.
2870         https://bugs.webkit.org/show_bug.cgi?id=197307
2871
2872         The style checker shouldn't complain about an open brace on
2873         its own line if the last non-whitespace character on the previous
2874         non-blank line is another open brace, because it's likely to
2875         indicate the begining of a nested code block.
2876
2877         Reviewed by Alex Christensen.
2878
2879         * Scripts/webkitpy/style/checkers/cpp.py:
2880         (check_braces):
2881         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2882         (WebKitStyleTest.test_braces):
2883
2884 2019-04-26  Sihui Liu  <sihui_liu@apple.com>
2885
2886         Stop IDB transactions to release locked database files when network process is ready to suspend
2887         https://bugs.webkit.org/show_bug.cgi?id=196372
2888         <rdar://problem/48930116>
2889
2890         Reviewed by Brady Eidson.
2891
2892         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2893         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.html: Added.
2894         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm: Added.
2895         (-[IndexedDBSuspendImminentlyMessageHandler userContentController:didReceiveScriptMessage:]):
2896         (runTestAndCheckResult):
2897         (keepNetworkProcessActive):
2898         (TEST):
2899
2900 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
2901
2902         REGRESSION (r234330): 3 legacy-animation-engine/compositing tests are flaky failures
2903         https://bugs.webkit.org/show_bug.cgi?id=188357
2904         <rdar://problem/42986633>
2905
2906         Reviewed by Dean Jackson.
2907
2908         DumpRenderTree had no code that set page.setCompositingPolicyOverride() to Normal, so some
2909         tests would fall into low memory mode and have different behavior.
2910         
2911         Fix by moving the code that calls setCompositingPolicyOverride(Normal) from the WK2 layer
2912         to Internals, so it's shared by DRT and WTR.
2913         
2914         We no longer need the WK2 C SPI glue.
2915
2916         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2917         (WTR::InjectedBundlePage::prepare):
2918
2919 2019-04-25  Jonathan Bedard  <jbedard@apple.com>
2920
2921         webkitpy: Including skipped tests in the final count
2922         https://bugs.webkit.org/show_bug.cgi?id=197298
2923         <rdar://problem/49705424>
2924
2925         Reviewed by Lucas Forschler.
2926
2927         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
2928         (BuildBotPrinter.print_run_results): The total number of tests run should exclude delibrately skipped tests.
2929
2930 2019-04-25  Timothy Hatcher  <timothy@apple.com>
2931
2932         Disable date and time inputs on iOSMac.
2933         https://bugs.webkit.org/show_bug.cgi?id=197287
2934         rdar://problem/46794376
2935
2936         Reviewed by Wenson Hsieh.
2937
2938         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2939
2940 2019-04-25  Alex Christensen  <achristensen@webkit.org>
2941
2942         Fix test-webkitpy after r244653
2943         https://bugs.webkit.org/show_bug.cgi?id=197131
2944
2945         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
2946         Also use C++17.
2947
2948 2019-04-25  Per Arne Vollan  <pvollan@apple.com>
2949
2950         -[WKWebsiteDataStore fetchDataRecordsOfTypes:completionHandler:] never returns _WKWebsiteDataTypeCredentials
2951         https://bugs.webkit.org/show_bug.cgi?id=196991
2952         <rdar://problem/45507423>
2953
2954         Reviewed by Alex Christensen.
2955
2956         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
2957         (-[NavigationTestDelegate init]):
2958         (-[NavigationTestDelegate waitForDidFinishNavigation]):
2959         (-[NavigationTestDelegate webView:didFinishNavigation:]):
2960         (-[NavigationTestDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2961         (TestWebKitAPI::TEST):
2962         (TEST): Deleted.
2963
2964 2019-04-25  Alex Christensen  <achristensen@webkit.org>
2965
2966         Revert some code accidentally committed with r244653
2967         https://bugs.webkit.org/show_bug.cgi?id=197131
2968
2969         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
2970         (TestWebKitAPI::TEST):
2971
2972 2019-04-25  Alex Christensen  <achristensen@webkit.org>
2973
2974         Start using C++17
2975         https://bugs.webkit.org/show_bug.cgi?id=197131
2976
2977         Reviewed by Darin Adler.
2978
2979         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2980         * MiniBrowser/Configurations/Base.xcconfig:
2981         * MobileMiniBrowser/Configurations/Base.xcconfig:
2982         * TestWebKitAPI/Configurations/Base.xcconfig:
2983         * WebKitTestRunner/Configurations/Base.xcconfig:
2984
2985 2019-04-25  Commit Queue  <commit-queue@webkit.org>
2986
2987         Unreviewed, rolling out r244627.
2988         https://bugs.webkit.org/show_bug.cgi?id=197282
2989
2990         Causing internal build failures (Requested by ShawnRoberts on
2991         #webkit).
2992
2993         Reverted changeset:
2994
2995         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
2996         https://bugs.webkit.org/show_bug.cgi?id=197171
2997         https://trac.webkit.org/changeset/244627
2998
2999 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3000
3001         [GTK] Hardcoded text color in input fields
3002         https://bugs.webkit.org/show_bug.cgi?id=126907
3003
3004         Reviewed by Michael Catanzaro.
3005
3006         Add dark-mode command line option to MiniBrowser.
3007
3008         * MiniBrowser/gtk/main.c:
3009         (main):
3010
3011 2019-04-24  Zalan Bujtas  <zalan@apple.com>
3012
3013         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
3014         https://bugs.webkit.org/show_bug.cgi?id=196948
3015         <rdar://problem/49927131>
3016
3017         Reviewed by Tim Horton.
3018
3019         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
3020         (TEST):
3021         The expected order of incoming events is
3022         1. didInvalidateIntrinsicContentSize
3023         2. didFirstLayout
3024         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
3025         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
3026         (and remember, all we care about is ordering).
3027
3028 2019-04-24  Eric Carlson  <eric.carlson@apple.com>
3029
3030         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
3031         https://bugs.webkit.org/show_bug.cgi?id=197171
3032         <rdar://problem/47454979>
3033
3034         Reviewed by Youenn Fablet.
3035
3036         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3037         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
3038         (TestWebKitAPI::TEST):
3039
3040 2019-04-24  Brady Eidson  <beidson@apple.com>
3041
3042         XMLHTTPRequest POSTs to a custom WKURLSchemeHandler protocol are missing the HTTP body.
3043         https://bugs.webkit.org/show_bug.cgi?id=191362
3044
3045         Reviewed by Alex Christensen.
3046
3047         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm: Add a test that POSTs all sorts of things
3048           from an XHR to a custom protocol.
3049
3050 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
3051
3052         DumpRenderTree doesn't call Internals::resetToConsistentState() before the first test
3053         https://bugs.webkit.org/show_bug.cgi?id=197273
3054
3055         Reviewed by Dean Jackson.
3056
3057         Reorder code so that we create gTestRunner before calling resetWebViewToConsistentStateBeforeTesting(),
3058         so that WebCoreTestSupport::resetInternalsObject() is always run.
3059
3060         * DumpRenderTree/mac/DumpRenderTree.mm:
3061         (resetWebViewToConsistentStateBeforeTesting):
3062         (runTest):
3063
3064 2019-04-24  John Wilander  <wilander@apple.com>
3065
3066         Age out unconverted Ad Click Attributions after one week.
3067         https://bugs.webkit.org/show_bug.cgi?id=197238
3068         <rdar://problem/50177349>
3069
3070         Reviewed by Chris Dumez.
3071
3072         This patch adds infrastructure to allow tests to expire all unconverted
3073         attributions early.
3074
3075         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3076         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3077         (WTR::TestRunner::markAdClickAttributionsAsExpiredForTesting):
3078         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3079         * WebKitTestRunner/TestController.cpp:
3080         (WTR::TestController::markAdClickAttributionsAsExpiredForTesting):
3081         * WebKitTestRunner/TestController.h:
3082         * WebKitTestRunner/TestInvocation.cpp:
3083         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3084
3085 2019-04-24  Chris Dumez  <cdumez@apple.com>
3086
3087         Fix flaky crashes in a couple of PSON API tests
3088         https://bugs.webkit.org/show_bug.cgi?id=197239
3089
3090         Reviewed by Tim Horton.
3091
3092         Do not adopt the NSURLRequest returned by [NSURLRequest requestWithURL:].
3093
3094         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3095
3096 2019-04-24  Simon Fraser  <simon.fraser@apple.com>
3097
3098         Make it possible to control the renderTreeAsText output by setting options on testRunner
3099         https://bugs.webkit.org/show_bug.cgi?id=197133
3100
3101         Reviewed by Sam Weinig.
3102
3103         Add testRunner.setRenderTreeDumpOptions() and expose the subset of RenderAsTextFlag flags
3104         that make sense in testing (those that don't dump unstable data like addresses), and plumb
3105         these flags through the various framework layers.
3106
3107         Convert RenderAsTextBehavior to an OptionSet<RenderAsTextFlag>.
3108
3109         Fix code generation in WebKitTestRunner to generate bindings for IDL const values,
3110         and hand-code DumpRenderTree bindings.
3111
3112         Some cleanup of the TestRunners, using member initializers.
3113
3114         * DumpRenderTree/TestRunner.cpp:
3115         (TestRunner::TestRunner):
3116         (setRenderTreeDumpOptionsCallback):
3117         (TestRunner::staticFunctions):
3118         (TestRunner::setRenderTreeDumpOptions):
3119         * DumpRenderTree/TestRunner.h:
3120         (TestRunner::renderTreeDumpOptions const):
3121         * DumpRenderTree/mac/DumpRenderTree.mm:
3122         (dump):
3123         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3124         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3125         (WTR::InjectedBundlePage::dump):
3126         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3127         (WTR::TestRunner::TestRunner):
3128         (WTR::TestRunner::setRenderTreeDumpOptions):
3129         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3130         (WTR::TestRunner::renderTreeDumpOptions const):
3131
3132 2019-04-24  Alex Christensen  <achristensen@webkit.org>
3133
3134         WKContentRuleLists should have a maximum FileProtection of CompleteUnlessOpen
3135         https://bugs.webkit.org/show_bug.cgi?id=197078
3136         <rdar://problem/49564348>
3137
3138         Reviewed by Geoff Garen.
3139
3140         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3141         (TEST_F):
3142         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]): Deleted.
3143         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]): Deleted.
3144         Unfortunately, setting the NSFileProtectionKey attribute is only supported on iOS devices.
3145
3146 2019-04-24  Alex Christensen  <achristensen@webkit.org>
3147
3148         Add unit test for r239322
3149         https://bugs.webkit.org/show_bug.cgi?id=197236
3150
3151         Reviewed by Chris Dumez.
3152
3153         I initially developed this as a unit test for rdar://problem/48797895 but it seems that isn't quite ready.
3154         May as well add the test infrastructure which was needed before and will be needed in the future.
3155
3156         * TestWebKitAPI/TCPServer.cpp:
3157         (TestWebKitAPI::TCPServer::TCPServer):
3158         * TestWebKitAPI/TCPServer.h:
3159         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3160         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
3161         (TestWebKitAPI::TEST):
3162         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3163         (TestWebKitAPI::downloadAtRate):
3164         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
3165         (TEST):
3166         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm: Added.
3167         (-[ProxyDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3168         (-[ProxyDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
3169         (TestWebKitAPI::TEST):
3170         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
3171         (TEST):
3172
3173 2019-04-24  Chris Dumez  <cdumez@apple.com>
3174
3175         URL set by document.open() is communicated with the WebPageProxy but not the WebFrameProxy
3176         https://bugs.webkit.org/show_bug.cgi?id=197214
3177         <rdar://problem/49237544>
3178
3179         Reviewed by Alex Christensen.
3180
3181         Extend API test coverage.
3182
3183         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
3184         (TEST):
3185
3186 2019-04-24  Philippe Normand  <pnormand@igalia.com>
3187
3188         [Build][GStreamer] Update to 1.16.0
3189         https://bugs.webkit.org/show_bug.cgi?id=197157
3190
3191         Reviewed by Xabier Rodriguez-Calvar.
3192
3193         The upstreamed patches were removed and a new one was added for a
3194         regression detected in the scaletempo GStreamer element. The GNOME
3195         Flatpak was migrated to 3.32 and I switched a few modules to Meson
3196         on the way, as it is the preferred build system now in GStreamer
3197         1.16.
3198
3199         * flatpak/files/httpd-autogen.sh:
3200         * flatpak/flatpakutils.py:
3201         (FlatpakPackage.install):
3202         (WebkitFlatpak.run_in_sandbox):
3203         * flatpak/org.webkit.CommonModules.yaml:
3204         * flatpak/org.webkit.WebKit.yaml:
3205         * gstreamer/jhbuild.modules:
3206         * gstreamer/patches/gst-plugins-bad-0001-aomenc-Add-support-for-10-12bit-decoding.patch: Removed.
3207         * gstreamer/patches/gst-plugins-bad-0002-aomenc-Handle-8-bit_depth-images-with-AOM_IMG_FMT_HI.patch: Removed.
3208         * gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch: Removed.
3209         * gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch: Removed.
3210         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Removed.
3211         * gstreamer/patches/gst-plugins-base-0001-parsebin-Post-STREAM_COLLECTION-on-EVENT_STREAM_COLL.patch: Removed.
3212         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Detect-and-expose-CEA-608-708-Closed-Caption.patch: Removed.
3213         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Do-not-run-the-preferred-decryptor-context-q.patch: Removed.
3214         * gstreamer/patches/gst-plugins-good-0002-qtdemux-Do-not-unref-a-NULL-stream_tags.patch: Removed.
3215         * gstreamer/patches/gst-plugins-good-0002-qtdemux-add-context-for-a-preferred-protection.patch: Removed.
3216         * gstreamer/patches/gst-plugins-good-0003-qtdemux-Clarify-field-name-about-stream-encryption-s.patch: Removed.
3217         * gstreamer/patches/gst-plugins-good-0003-qtdemux-also-push-buffers-without-encryption-info-in.patch: Removed.
3218         * gstreamer/patches/gst-plugins-good-0004-qtdemux-Add-initial-support-for-AV1-demuxing.patch: Removed.
3219         * gstreamer/patches/gst-plugins-good-0005-qtdemux-Extract-AV1-codec_data-and-put-it-in-the-cap.patch: Removed.
3220         * gstreamer/patches/gst-plugins-good-0006-qtdemux-Recognize-more-AV1-atoms.patch: Removed.
3221         * gstreamer/patches/gst-plugins-good-0011-matroska-Add-the-WebM-encrypted-content-support-in-m.patch: Removed.
3222         * gstreamer/patches/gst-plugins-good-0012-matroskdemux-do-not-use-MapInfo.data-after-unmapping.patch: Removed.
3223         * gstreamer/patches/gst-plugins-good-0013-Avoid-warning-when-reporting-about-decryptors.patch: Removed.
3224         * gstreamer/patches/gst-plugins-good-0014-pulse-Mark-default-devices-as-default.patch: Removed.
3225         * gstreamer/patches/gst-plugins-good-scaletempo-Advertise-interleaved-layout-in-caps-temp.patch: Added.
3226         * gstreamer/patches/gstreamer-0001-protection-Add-a-new-definition-for-unspecified-syst.patch: Removed.
3227         * gstreamer/patches/gstreamer-0002-protection-Fix-the-string-to-define-unspecified-syst.patch: Removed.
3228
3229 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3230
3231         [GTK] MiniBrowser: also set the passed bg-color when receiving arguments
3232         https://bugs.webkit.org/show_bug.cgi?id=197156
3233
3234         Reviewed by Michael Catanzaro.
3235
3236         The background color is only set when MiniBrowser is launched without arguments. This regressed when tabs
3237         support was added.
3238
3239         * MiniBrowser/gtk/BrowserTab.c:
3240         (browser_tab_set_background_color): Set the passed in color as web view background color.
3241         * MiniBrowser/gtk/BrowserTab.h:
3242         * MiniBrowser/gtk/BrowserWindow.c:
3243         (browser_window_init): Initialize backgroundColor.
3244         (browser_window_append_view): Call browser_tab_set_background_color().
3245         (browser_window_set_background_color): Save the passed in color. This function should now be called before tabs
3246         are added.
3247         * MiniBrowser/gtk/main.c:
3248         (main): Call browser_window_set_background_color() before creating the tabs.
3249
3250 2019-04-23  John Wilander  <wilander@apple.com>
3251
3252         Move Ad Click Attribution from internal feature to experimental feature
3253         https://bugs.webkit.org/show_bug.cgi?id=197218
3254         <rdar://problem/47651691>
3255
3256         Reviewed by Brent Fulgham.
3257
3258         * DumpRenderTree/TestOptions.cpp:
3259         (TestOptions::TestOptions):
3260
3261 2019-04-23  Andy Estes  <aestes@apple.com>
3262
3263         [iOS] QuickLook documents loaded from file: URLs should be allowed to perform same-document navigations
3264         https://bugs.webkit.org/show_bug.cgi?id=196749
3265         <rdar://problem/35773454>
3266
3267         Reviewed by Daniel Bates.
3268
3269         Added a new QuickLook API test and added new expectations to existing QuickLook tests.
3270
3271         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
3272         (-[QuickLookDelegate webView:didStartProvisionalNavigation:]):
3273         (-[QuickLookDelegate webView:didFinishNavigation:]):
3274         (-[QuickLookDelegate _webView:didFailNavigation:withError:userInfo:]):
3275         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
3276         (runTest):
3277         (runTestDecideBeforeLoading):
3278         (runTestDecideAfterLoading):
3279         (TEST):
3280
3281 2019-04-23  John Wilander  <wilander@apple.com>
3282
3283         Remove Ad Click Attribution data when removing website data
3284         https://bugs.webkit.org/show_bug.cgi?id=197215
3285         <rdar://problem/47668988>
3286
3287         Reviewed by Chris Dumez.
3288
3289         This patch adds test infrastructure to delete Ad Click Attribution data
3290         through WebsiteDataStore::removeData().
3291
3292         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3293         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3294         (WTR::TestRunner::clearAdClickAttribution):
3295         (WTR::TestRunner::clearAdClickAttributionsThroughWebsiteDataRemoval):
3296         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3297         * WebKitTestRunner/TestController.cpp:
3298         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
3299         * WebKitTestRunner/TestController.h:
3300         * WebKitTestRunner/TestInvocation.cpp:
3301         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3302
3303 2019-04-23  Jonathan Bedard  <jbedard@apple.com>
3304
3305         webkitpy: Kill unresponsive worker processes
3306         https://bugs.webkit.org/show_bug.cgi?id=197205
3307         <rdar://problem/50104388>
3308
3309         Reviewed by Lucas Forschler.
3310
3311         * Scripts/webkitpy/common/message_pool.py:
3312         (_MessagePool.__init__): Add close timeout.
3313         (_MessagePool._close): Send termination before joining workers, kill unresponsive workers.
3314
3315 2019-04-23  Alex Christensen  <achristensen@webkit.org>
3316
3317         Add unit tests for WKWebView.serverTrust
3318         https://bugs.webkit.org/show_bug.cgi?id=197202
3319
3320         Reviewed by Youenn Fablet
3321
3322         * TestWebKitAPI/TCPServer.cpp:
3323         (TestWebKitAPI::deleter<BIO>::operator()):
3324         (TestWebKitAPI::deleter<SSL>::operator()):
3325         (TestWebKitAPI::deleter<X509>::operator()):
3326         (TestWebKitAPI::deleter<SSL_CTX>::operator()):
3327         (TestWebKitAPI::deleter<EVP_PKEY>::operator()):
3328         (TestWebKitAPI::TCPServer::TCPServer):
3329         (TestWebKitAPI::TCPServer::listenForConnections):
3330         * TestWebKitAPI/TCPServer.h:
3331         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3332         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
3333         (TestWebKitAPI::TEST):
3334         (verifyCertificateAndPublicKey):
3335         (-[ServerTrustDelegate webView:didFinishNavigation:]):
3336         (-[ServerTrustDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
3337         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3338         (TestWebKitAPI::downloadAtRate):
3339         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
3340         (TEST):
3341         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
3342         (TEST):
3343
3344 2019-04-23  Commit Queue  <commit-queue@webkit.org>
3345
3346         Unreviewed, rolling out r244556.
3347         https://bugs.webkit.org/show_bug.cgi?id=197212
3348
3349         Causing build failures on multiple builders (Requested by
3350         ShawnRoberts on #webkit).
3351
3352         Reverted changeset:
3353
3354         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
3355         https://bugs.webkit.org/show_bug.cgi?id=197171
3356         https://trac.webkit.org/changeset/244556
3357
3358 2019-04-23  Alex Christensen  <achristensen@webkit.org>
3359
3360         Fix iOS build.
3361         https://bugs.webkit.org/show_bug.cgi?id=195537
3362
3363         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3364         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
3365         AdoptWK constructor is private now.  Use adoptWK instead.
3366
3367 2019-04-23  Andres Gonzalez  <andresg_22@apple.com>
3368
3369         Accessibility text search and selection API enhancements.
3370         https://bugs.webkit.org/show_bug.cgi?id=197095
3371         <rdar://problem/48181791>
3372
3373         Reviewed by Chris Fleizach.
3374
3375         Added new API JS binding code for searchTextWithCriteria to both WTR and DRT.
3376
3377         * DumpRenderTree/AccessibilityTextMarker.h:
3378         * DumpRenderTree/AccessibilityUIElement.cpp:
3379         (searchTextWithCriteriaCallback):
3380         (AccessibilityUIElement::getJSClass):
3381         * DumpRenderTree/AccessibilityUIElement.h:
3382         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3383         (convertVectorToObjectArray):
3384         (convertNSArrayToVector):
3385         (searchTextParameterizedAttributeForCriteria):
3386         (AccessibilityUIElement::getLinkedUIElements):
3387         (AccessibilityUIElement::getDocumentLinks):
3388         (AccessibilityUIElement::getChildren):
3389         (AccessibilityUIElement::getChildrenWithRange):
3390         (AccessibilityUIElement::rowHeaders const):
3391         (AccessibilityUIElement::columnHeaders const):
3392         (AccessibilityUIElement::uiElementArrayAttributeValue const):
3393         (AccessibilityUIElement::searchTextWithCriteria):
3394         (AccessibilityUIElement::attributesOfColumnHeaders):
3395         (AccessibilityUIElement::attributesOfRowHeaders):
3396         (AccessibilityUIElement::attributesOfColumns):
3397         (AccessibilityUIElement::attributesOfRows):
3398         (AccessibilityUIElement::attributesOfVisibleCells):
3399         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3400         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3401         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3402         (WTR::convertVectorToObjectArray):
3403         (WTR::convertNSArrayToVector):
3404         (WTR::searchTextParameterizedAttributeForCriteria):
3405         (WTR::AccessibilityUIElement::getLinkedUIElements):
3406         (WTR::AccessibilityUIElement::getDocumentLinks):
3407         (WTR::AccessibilityUIElement::getUIElementsWithAttribute const):
3408         (WTR::AccessibilityUIElement::getChildren):
3409         (WTR::AccessibilityUIElement::getChildrenWithRange):
3410         (WTR::AccessibilityUIElement::rowHeaders const):
3411         (WTR::AccessibilityUIElement::columnHeaders const):
3412         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue const):
3413         (WTR::AccessibilityUIElement::searchTextWithCriteria):
3414         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
3415         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
3416         (WTR::AccessibilityUIElement::attributesOfColumns):
3417         (WTR::AccessibilityUIElement::attributesOfRows):
3418         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
3419         (WTR::convertElementsToObjectArray): Deleted.
3420
3421 2019-04-23  Guy Lewin  <guy@lewin.co.il>
3422
3423         Multiple File Input Icon Set Regardless of File List
3424         https://bugs.webkit.org/show_bug.cgi?id=195537
3425
3426         Reviewed by Alexey Proskuryakov.
3427
3428         Add setOpenPanelFilesMediaIcon to TestRunner in order to test icon and
3429         display string in iOS file inputs
3430
3431         * DumpRenderTree/TestRunner.cpp:
3432         (SetOpenPanelFilesMediaIconCallback):
3433         (TestRunner::staticFunctions):
3434         (TestRunner::setOpenPanelFilesMediaIcon):
3435         * DumpRenderTree/TestRunner.h:
3436         (TestRunner::openPanelFilesMediaIcon const):
3437         * DumpRenderTree/mac/UIDelegate.mm:
3438         (-[UIDelegate webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
3439         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3440         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3441         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
3442         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3443         * WebKitTestRunner/TestController.cpp:
3444         (WTR::runOpenPanel):
3445         (WTR::TestController::resetStateToConsistentValues):
3446         * WebKitTestRunner/TestController.h:
3447         (WTR::TestController::openPanelFileURLsMediaIcon const):
3448         (WTR::TestController::setOpenPanelFileURLsMediaIcon):
3449         * WebKitTestRunner/TestInvocation.cpp:
3450         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3451
3452 2019-04-23  Eric Carlson  <eric.carlson@apple.com>
3453
3454         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
3455         https://bugs.webkit.org/show_bug.cgi?id=197171
3456         <rdar://problem/47454979>
3457
3458         Reviewed by Youenn Fablet.
3459
3460         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3461         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
3462         (TestWebKitAPI::TEST):
3463
3464 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
3465
3466         [ews-build] Add unit tests for UnApplyPatchIfRequired
3467         https://bugs.webkit.org/show_bug.cgi?id=197197
3468
3469         Reviewed by Lucas Forschler.
3470
3471         * BuildSlaveSupport/ews-build/steps_unittest.py:
3472         (TestUnApplyPatchIfRequired):
3473         (TestUnApplyPatchIfRequired.test_success):
3474         (TestUnApplyPatchIfRequired.test_failure):
3475         (TestUnApplyPatchIfRequired.test_skip):
3476
3477 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
3478
3479         [ews-build] Add unit tests for CleanWorkingDirectory
3480         https://bugs.webkit.org/show_bug.cgi?id=197195
3481
3482         Reviewed by Lucas Forschler.
3483
3484         * BuildSlaveSupport/ews-build/steps_unittest.py:
3485         (TestCleanWorkingDirectory):
3486         (TestCleanWorkingDirectory.test_success):
3487         (TestCleanWorkingDirectory.test_failure):
3488
3489 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
3490
3491         [ews-build] Use explicit imports instead of wildcard imports
3492         https://bugs.webkit.org/show_bug.cgi?id=197194
3493
3494         Reviewed by Lucas Forschler.
3495
3496         * BuildSlaveSupport/ews-build/factories.py:
3497         * BuildSlaveSupport/ews-build/loadConfig.py:
3498         * BuildSlaveSupport/ews-build/steps_unittest.py:
3499
3500 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
3501
3502         [ews-build] Add unit tests for DownloadBuiltProduct
3503         https://bugs.webkit.org/show_bug.cgi?id=197193
3504
3505         Reviewed by Lucas Forschler.
3506
3507         * BuildSlaveSupport/ews-build/steps_unittest.py:
3508         (TestDownloadBuiltProduct):
3509         (TestDownloadBuiltProduct.setUp):
3510         (TestDownloadBuiltProduct.tearDown):
3511         (TestDownloadBuiltProduct.test_success):
3512         (TestDownloadBuiltProduct.test_failure):
3513
3514 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
3515
3516         [ews-app] Exception while loading status-bubble when no build step has started
3517         https://bugs.webkit.org/show_bug.cgi?id=196676
3518
3519         Reviewed by Lucas Forschler.
3520
3521         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3522         (StatusBubble.get_build_timestamp): Check if build step is present before accessing its timestamp.
3523
3524 2019-04-23  Stephan Szabo  <stephan.szabo@sony.com>
3525
3526         [PlayStation] Support running of JSC tests on remote playstation devices
3527         https://bugs.webkit.org/show_bug.cgi?id=197170
3528
3529         Reviewed by Ross Kirsling.
3530
3531         Script changes
3532
3533         * Scripts/run-javascriptcore-tests:
3534         (runJSCStressTests): Pass arguments for playstation to
3535         run-jsc-stress-tests
3536         * Scripts/run-jsc-stress-tests:
3537         Handle $hostOS=="playstation" for determineArchitecture, turning
3538         off $isFTLPlatform and runProfiler and defaulting test writer.
3539         * Scripts/webkitdirs.pm:
3540         (jscPath): PlayStation WebKit executables have .elf extension
3541         (executableProductDir): PlayStation builds on Windows hosts but
3542         uses bin directory rather than bin64/bin32 for executable output
3543         location.
3544         * Scripts/webkitruby/jsc-stress-test-writer-playstation.rb: Added.
3545
3546 2019-04-23  Don Olmstead  <don.olmstead@sony.com>
3547
3548         [CMake][Win] Use target oriented design for WebKit
3549         https://bugs.webkit.org/show_bug.cgi?id=197173
3550
3551         Reviewed by Alex Christensen.
3552
3553         * TestWebKitAPI/PlatformWin.cmake: Add WebKitFrameworkHeaders as a dependency.
3554         * TestWebKitAPI/Tests/WebKit/curl/Certificates.cpp: Remove unused header.
3555
3556 2019-04-23  Chris Dumez  <cdumez@apple.com>
3557
3558         [Process-Swap-On-Navigation] WebKit hangs when going back to a form submission's page due to Process-Swap-On-Navigation on iOS 12.2 and higher
3559         https://bugs.webkit.org/show_bug.cgi?id=197097
3560         <rdar://problem/50048318>
3561
3562         Reviewed by Alex Christensen.
3563
3564         Add API test coverage.
3565
3566         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3567         (-[PSONScheme webView:startURLSchemeTask:]):
3568
3569 2019-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3570
3571         [ATK] Implement AtkComponentIface scroll_to methods
3572         https://bugs.webkit.org/show_bug.cgi?id=196856
3573
3574         Reviewed by Michael Catanzaro.
3575
3576         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3577         (WTR::AccessibilityUIElement::scrollToMakeVisible): Call atk_component_scroll_to().
3578         (WTR::AccessibilityUIElement::scrollToGlobalPoint): Call atk_component_scroll_to_point().
3579         * gtk/jhbuild.modules: Bump atk, at-spi2-core and at-spi2-atk to their latest stable version.
3580
3581 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
3582
3583         [ews-build] Improve summary for UploadBuiltProduct step
3584         https://bugs.webkit.org/show_bug.cgi?id=197182
3585
3586         Reviewed by Lucas Forschler.
3587
3588         * BuildSlaveSupport/ews-build/steps.py:
3589         (UploadBuiltProduct): Added descriptionDone.
3590         (UploadBuiltProduct.getResultSummary): Overrided getResultSummary.
3591         * BuildSlaveSupport/ews-build/steps_unittest.py:
3592         (TestUploadBuiltProduct.test_success): Updated unit-test.
3593         (TestUploadBuiltProduct.test_failure): Added unit-test for failure case.
3594
3595 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
3596
3597         [ews-build] Trigger queues only after uploading the archive
3598         https://bugs.webkit.org/show_bug.cgi?id=197180
3599
3600         Reviewed by Lucas Forschler.
3601
3602         * BuildSlaveSupport/ews-build/factories.py:
3603         (Factory.__init__):
3604         (BuildFactory.__init__): Remove trigger step from factories.
3605         (BuildFactory.propertiesToPassToTriggers): Deleted.
3606         * BuildSlaveSupport/ews-build/steps.py:
3607         (ConfigureBuild.__init__): Confiure triggers property.
3608         (Trigger): Step to trigger other queues.
3609         (Trigger.propertiesToPassToTriggers): Method to construct properties to pass to triggerred builds.
3610         (UploadBuiltProduct.finished): Trigger builds after upload is successful.
3611
3612 2019-04-22  Alex Christensen  <achristensen@webkit.org>
3613
3614         Deprecate WKContextCreateWithInjectedBundlePath
3615         https://bugs.webkit.org/show_bug.cgi?id=197169
3616
3617         Reviewed by Youenn Fablet.
3618
3619         * TestWebKitAPI/PlatformUtilities.cpp:
3620         (TestWebKitAPI::Util::createContextWithInjectedBundle):
3621         Use WKContextCreateWithConfiguration instead of WKContextCreateWithInjectedBundlePath after having set its injected bundle path.
3622
3623 2019-04-22  Alex Christensen  <achristensen@webkit.org>
3624
3625         REGRESSION(r230681) Do not use stored credentials if WKBundlePageResourceLoadClient.shouldUseCredentialStorage returns false
3626         https://bugs.webkit.org/show_bug.cgi?id=197093
3627         <rdar://problem/49708268>
3628
3629         Reviewed by Chris Dumez.
3630
3631         Add a test that does two loads.  The first load shouldUseCredentialStorage returns true and we provide a persistent credential.
3632         The second load shouldUseCredentialStorage returns false and we verify that a challenge is received with no suggested credential.
3633         We also need to make the TCPServer able to handle more than one connection because we need these two loads to come from the same protection space,
3634         and our current Cocoa implementation of NetworkSession uses two NSURLSessions that don't share a connection cache, one for loads with credentials
3635         and one for loads without credentials, so there are two TCP connections to the same server in this test.
3636
3637         * TestWebKitAPI/TCPServer.cpp:
3638         (TestWebKitAPI::TCPServer::TCPServer):
3639         (TestWebKitAPI::TCPServer::~TCPServer):
3640         (TestWebKitAPI::TCPServer::socketBindListen):
3641         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests): Deleted.
3642         * TestWebKitAPI/TCPServer.h:
3643         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3644         * TestWebKitAPI/Tests/WebKitCocoa/BasicProposedCredentialPlugIn.mm: Added.
3645         (-[BasicProposedCredentialPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3646         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
3647         (respondWithChallengeThenOK):
3648         (TestWebKitAPI::TEST):
3649         (-[ProposedCredentialDelegate webView:didFinishNavigation:]):
3650         (-[ProposedCredentialDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
3651         (TEST):
3652
3653 2019-04-22  Chris Dumez  <cdumez@apple.com>
3654
3655         Delayed WebProcessLaunch may break the _relatedWebView SPI
3656         https://bugs.webkit.org/show_bug.cgi?id=197160
3657
3658         Reviewed by Alex Christensen.
3659
3660         Add API test coverage.
3661
3662         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3663
3664 2019-04-22  Dean Johnson  <dean_johnson@apple.com>
3665
3666         Use curl to download packages for webkitpy autoinstaller
3667         https://bugs.webkit.org/show_bug.cgi?id=197164
3668
3669         Reviewed by Darin Adler.
3670
3671         * Scripts/webkitpy/common/system/autoinstall.py:
3672         (AutoInstaller._download): Use curl(1) to download packages necessary for
3673         webkitpy/thirdparty/autoinstalled since Python2's urllib2 module can result in unnecessary
3674         errors which are not present when using curl(1).
3675
3676 2019-04-22  Chris Dumez  <cdumez@apple.com>
3677
3678         Unreviewed, rolling out r244502.
3679
3680         Caused crashes on the bots
3681
3682         Reverted changeset:
3683
3684         "Delayed WebProcessLaunch may break the _relatedWebView