3793bb846a1a779329c33dc4dec2a47f3387a2d5
[WebKit-https.git] / Tools / ChangeLog
1 2014-06-12  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2
3         [GTK] Performance tests should be always ran with WKTR.
4         https://bugs.webkit.org/show_bug.cgi?id=133780
5
6         Reviewed by Ryosuke Niwa.
7
8         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
9         (PerfTestsRunner.__init__): Enable webkit_test_runner when port
10         is GTK.
11
12 2014-06-12  Sergio Villar Senin  <svillar@igalia.com>
13
14         [GTK] REGRESSION: application name is not correctly appended to the UA
15         https://bugs.webkit.org/show_bug.cgi?id=133793
16
17         Reviewed by Carlos Garcia Campos.
18
19         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
20         (testWebKitSettingsUserAgent):
21
22 2014-06-12  Sergio Villar Senin  <svillar@igalia.com>
23
24         [GTK] Unsupported browser in www.icloud.com
25         https://bugs.webkit.org/show_bug.cgi?id=133403
26
27         Reviewed by Martin Robinson.
28
29         * TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp:
30         (TestWebKitAPI::TEST): removed a test for the NeedsSafariVersion6
31         quirk that was removed.
32
33 2014-06-11  Simon Fraser  <simon.fraser@apple.com>
34
35         [iOS WK2] Give WebKitTestRunner a viewport configuration with initial scale=1 for testing
36         https://bugs.webkit.org/show_bug.cgi?id=133779
37
38         Reviewed by Benjamin Poulain.
39         
40         Tell the WebPage to use the testing viewport configuration from the injected bundle.
41
42         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
43         (WTR::InjectedBundle::didReceiveMessage): Code cleanup.
44         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
45         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Call WKBundlePageSetUseTestingViewportConfiguration()
46         on iOS.
47
48 2014-06-11  Simon Fraser  <simon.fraser@apple.com>
49
50         WTR cleanup: push per-test viewport configuration into TestController, where platforms can customize it
51         https://bugs.webkit.org/show_bug.cgi?id=133770
52
53         Reviewed by Anders Carlsson.
54         
55         Push the per-test view configuration up to TestController, so that platforms
56         can modify the behavior. This also allows platform-specific changes (e.g.
57         for threaded scrolling) to made without #ifefs.
58
59         * WebKitTestRunner/TestController.cpp:
60         (WTR::TestController::updateWebViewSizeForTest):
61         (WTR::TestController::updateWindowScaleForTest):
62         (WTR::shouldUseFixedLayout):
63         (WTR::TestController::updateLayoutTypeForTest):
64         (WTR::TestController::platformConfigureViewForTest):
65         (WTR::TestController::configureViewForTest):
66         * WebKitTestRunner/TestController.h:
67         * WebKitTestRunner/TestInvocation.cpp:
68         (WTR::TestInvocation::invoke):
69         (WTR::sizeWebViewForCurrentTest): Deleted.
70         (WTR::changeWindowScaleIfNeeded): Deleted.
71         (WTR::shouldUseThreadedScrolling): Deleted.
72         (WTR::updateThreadedScrollingForCurrentTest): Deleted.
73         (WTR::shouldUseFixedLayout): Deleted.
74         (WTR::updateLayoutType): Deleted.
75         * WebKitTestRunner/TestInvocation.h:
76         (WTR::TestInvocation::pathOrURL):
77         * WebKitTestRunner/ios/TestControllerIOS.mm:
78         (WTR::shouldMakeViewportFlexible):
79         (WTR::TestController::platformConfigureViewForTest):
80         * WebKitTestRunner/mac/TestControllerMac.mm:
81         (WTR::shouldUseThreadedScrolling):
82         (WTR::TestController::platformConfigureViewForTest):
83
84 2014-06-11  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
85
86         [EFL] Add dependencies packages to efl install-dependencies file
87         https://bugs.webkit.org/show_bug.cgi?id=133720
88
89         Reviewed by Csaba Osztrogonác.
90
91         After r169785, EFL port starts to use efl 1.9 ver. EFL port needs to
92         install doxygen and libssl-dev because efl 1.9 depends on those libraries.
93
94         * efl/install-dependencies:
95
96 2014-06-11  Zoltan Horvath  <zoltan@webkit.org>
97
98         Unreviewed. Moving myself to the list of reviewers.
99
100         * Scripts/webkitpy/common/config/contributors.json:
101
102 2014-06-11  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
103
104         [EFL] Drop to maintain EFL 32bit release bot
105         https://bugs.webkit.org/show_bug.cgi?id=133710
106
107         Reviewed by Csaba Osztrogonác.
108
109         * BuildSlaveSupport/build.webkit.org-config/config.json: Removed EFL 32bit bot.
110
111 2014-06-11  Carlos Garcia Campos  <cgarcia@igalia.com>
112
113         [GTK] Use a different user agent string depending on the site
114         https://bugs.webkit.org/show_bug.cgi?id=132681
115
116         Reviewed by Anders Carlsson.
117
118         Add a unit test to check user agent quirks.
119
120         * TestWebKitAPI/PlatformGTK.cmake:
121         * TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp: Added.
122         (TestWebKitAPI::TEST):
123         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
124         (testWebKitSettings): Site specific quirks setting is now enabled
125         by default.
126
127 2014-06-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
128
129         Unreviewed, update my list of email addresses in contributors.json.
130
131         * Scripts/webkitpy/common/config/contributors.json:
132
133 2014-06-10  Simon Fraser  <simon.fraser@apple.com>
134
135         Always switch to an sRGB screen color profile when running tests
136         https://bugs.webkit.org/show_bug.cgi?id=133712
137
138         Reviewed by Tim Horton.
139         
140         Switch the screen color profile to sRGB when running tests, because even ref
141         tests need the screen to use the correct color profile.
142
143         * DumpRenderTree/mac/LayoutTestHelper.m:
144         (installLayoutTestColorProfile):
145         * Scripts/webkitpy/port/mac.py:
146         (MacPort.start_helper):
147
148 2014-06-10  Martin Hodovan  <mhodovan@partner.samsung.com>
149
150         [EFL] Bump EFL libraries to 1.9
151         https://bugs.webkit.org/show_bug.cgi?id=125479
152
153         Reviewed by Gyuyoung Kim.
154
155         Based on the work of Ryuan Choi <ryuan.choi@samsung.com>
156         and László Langó <llango.u-szeged@partner.samsung.com>.
157
158         * ImageDiff/CMakeLists.txt:
159         * MiniBrowser/efl/CMakeLists.txt:
160         * efl/install-dependencies:
161         * efl/jhbuild.modules:
162         * efl/jhbuildrc:
163
164 2014-06-10  David Farler  <dfarler@apple.com>
165
166         old-run-webkit-tests: Create CoreSimulator device on demand and find it by name
167         https://bugs.webkit.org/show_bug.cgi?id=133663
168
169         Reviewed by David Kilzer.
170
171         * Scripts/old-run-webkit-tests:
172         (installAndLaunchDumpToolAppUsingNotification):
173         - Remove obsolete notification keys
174         - Key off of mandatory device UDID (a UUID)
175         - Create a device on demand via CoreSimulator if necessary
176         -- Grab the UDID from the created device plist.
177         * Scripts/webkitdirs.pm:
178         (iOSSimulatorDevicesPath): Added
179         (iOSSimulatorDevices): Added
180         (createiOSSimulatorDevice): Added
181         (deleteiOSSimulatorDevice): Added
182
183 2014-06-10  Víctor Manuel Jáquez Leal  <vjaquez@igalia.com>
184
185         [GTK][gtkdoc] remove -Wcast-align
186         https://bugs.webkit.org/show_bug.cgi?id=133640
187
188         Apparently gcc warns that GParamSpec is not castable to
189         GParamSpecInt64/GParamSpecUInt64/GParamSpecDouble due they are 64bit, even
190         though ARM hackers claim that those only need 4byte alignment. As long as gcc
191         behaves that way, this warning is not very useful, also they break the Debian
192         packaging.
193
194         This patch appends the compiler flag -Wno-align-cast for the gtkdoc
195         scanner compilation, thus the compiler ignores the previous
196         -Waling-cast flag.
197
198         Reviewed by Martin Robinson.
199
200         * gtk/generate-gtkdoc:
201         (get_generator_for_config):
202
203 2014-06-09  Alexey Proskuryakov  <ap@apple.com>
204
205         Disable button animations in regression tests
206         https://bugs.webkit.org/show_bug.cgi?id=133647
207         <rdar://problem/16677530>
208
209         Reviewed by Tim Horton.
210
211         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
212         (WTR::InjectedBundle::platformInitialize):
213
214 2014-06-09  Simon Fraser  <simon.fraser@apple.com>
215
216         Move scrolling-related tests to tiled-drawing/scrolling subdirectory, and minor cleanup
217         https://bugs.webkit.org/show_bug.cgi?id=133650
218
219         Reviewed by Tim Horton.
220         
221         No point checking for a Windows-style path in Cocoa code.
222
223         * WebKitTestRunner/TestInvocation.cpp:
224         (WTR::shouldUseThreadedScrolling):
225
226 2014-06-09  Simon Fraser  <simon.fraser@apple.com>
227
228         Fix more latched scrolling test flakiness and slowness
229         https://bugs.webkit.org/show_bug.cgi?id=133601
230
231         Reviewed by Brent Fulgham.
232         
233         Latched scrolling tests were flakey for two reasons. First, the EventSender
234         wheel events were async from the web to the UI process, and the resulting
235         synthetic events also async from the UI to the web process. Make them sync
236         for testing.
237         
238         Secondly, the timer-based scrolling tree commit could result in the scrolling
239         tree (specifically the frame node's notion of the scrollable area and content
240         size) not being updated before the scrolling thread starts getting wheel events.
241         Fix by having WebPage::wheelEventSyncForTesting() commit if necessary.
242         
243         Finally remove all the now-unnecessary timeouts from the tests.
244
245         * WebKitTestRunner/mac/EventSenderProxy.mm:
246         (WTR::EventSenderProxy::mouseMoveTo):
247         (WTR::EventSenderProxy::mouseScrollBy):
248         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
249
250 2014-06-09  Andrzej Badowski  <a.badowski@samsung.com>
251
252         [EFL] Add parameter to MiniBrowser to disable web security
253         https://bugs.webkit.org/show_bug.cgi?id=121095
254
255         Reviewed by Gyuyoung Kim.
256
257         -w (--web-security) commandline allows to disable/enable web security (enabled by default).
258         The reason for this is to test and debug (using, for example, MiniBrowser) scripts accessing
259         resources from other domains (cross-domain requests) such as access map location on another server.
260         Another possibility is to launch in a webkit browser local file tests that will refer to the links
261         in the http website loaded in an iframe. It will not be possible without deactivation of web security.
262
263         * MiniBrowser/efl/main.c:
264         (window_create):
265         (elm_main):
266
267 2014-06-06  Simon Fraser  <simon.fraser@apple.com>
268
269         32-bit build fix.
270
271         * WebKitTestRunner/mac/EventSenderProxy.mm:
272         (WTR::EventSenderProxy::mouseMoveTo):
273         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
274
275 2014-06-06  Simon Fraser  <simon.fraser@apple.com>
276
277         Fix builds on 10.8; -firstObject isn't declared on NSArray there.
278
279         * DumpRenderTree/mac/DumpRenderTree.mm:
280         (createWebViewAndOffscreenWindow):
281         * DumpRenderTree/mac/EventSendingController.mm:
282         (-[EventSendingController mouseScrollByX:andY:continuously:]):
283         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
284         * WebKitTestRunner/mac/EventSenderProxy.mm:
285         (WTR::EventSenderProxy::mouseScrollBy):
286         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
287
288 2014-06-06  Simon Fraser  <simon.fraser@apple.com>
289
290         Latched scrolling tests are flakey on Mavericks
291         https://bugs.webkit.org/show_bug.cgi?id=133578
292         <rdar://problem/17180591>
293
294         Reviewed by Brent Fulgham.
295         
296         The latched scrolling tests rely on synthetic mousewheel events whose coordinates can
297         be wrong on machines with more than one screen. This is because we use
298         [NSScreen mainScreen] when computing the global coordinates of the events, but
299         [NSScreen mainScreen] returns the screen with the key window, not the first screen.
300         
301         So replace calls to [NSScreen mainScreen] with [[NSScreen screens] firstObject]. Also
302         add comments clarifying why the coordinate math works (which is not obvious given
303         the events have no target window).
304         
305         Some scrolling tests also dispatched events outside the 800x600 test window, so
306         fix those tests, and add logging that will appear in test output when this happens.
307
308         * DumpRenderTree/mac/DumpRenderTree.mm:
309         (createWebViewAndOffscreenWindow):
310         * DumpRenderTree/mac/EventSendingController.mm:
311         (-[EventSendingController mouseScrollByX:andY:continuously:]):
312         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
313         * WebKitTestRunner/mac/EventSenderProxy.mm:
314         (WTR::EventSenderProxy::mouseMoveTo):
315         (WTR::EventSenderProxy::mouseScrollBy):
316         (WTR::EventSenderProxy::continuousMouseScrollBy):
317         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
318
319 2014-06-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
320
321         [GTK] run-perf-tests should run the tests inside the jhbuild shell.
322         https://bugs.webkit.org/show_bug.cgi?id=133533
323
324         Reviewed by Carlos Garcia Campos.
325
326         * Scripts/webkitpy/common/multiprocessing_bootstrap.py:
327         (run): Remove the jhbuild-wrapper wrapper from here. It should be
328         on Scripts/webkitpy/port/gtk.py.
329         * Scripts/webkitpy/port/base.py:
330         (Port.set_option): Add a set_option(name, value) function to set
331         the optparse parameter "name" to the value "value", even if the
332         parameter "name" is already initialized.
333         * Scripts/webkitpy/port/gtk.py:
334         (GtkPort.__init__): Set the default wrapper to jhbuild-wrapper.
335         If another wrapper is specified via the option "-l --wrapper=x",
336         then prepend the jhbuild-wrapper to the one specified.
337
338 2014-06-04  David Farler  <dfarler@apple.com>
339
340         Build ASan WebKit for iOS Simulator
341         https://bugs.webkit.org/show_bug.cgi?id=133489
342
343         Reviewed by Darin Adler.
344
345         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
346         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
347         - Add missing ASan LDFLAGS.
348         * asan/asan.xcconfig:
349         - Split compiler-rt linker flags for OS X and iOS Simulator
350
351 2014-06-03  Yoav Weiss  <yoav@yoav.ws>
352
353         Add myself (yoav@yoav.ws) to contributors.json
354         https://bugs.webkit.org/show_bug.cgi?id=133492
355
356         * Scripts/webkitpy/common/config/contributors.json:
357
358 2014-06-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
359
360         REGRESSION(r169092 and r169102): Skip failing JSC tests poperly on non-x86 Darwin platforms
361         https://bugs.webkit.org/show_bug.cgi?id=133149
362
363         Reviewed by Csaba Osztrogonác.
364
365         * Scripts/run-jsc-stress-tests: Added determineOS to determine the host operating system the script run on.
366
367 2014-06-02  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
368
369         Add a verbose flag to binding tests
370         https://bugs.webkit.org/show_bug.cgi?id=122303
371
372         Reviewed by Csaba Osztrogonác.
373
374         This patch will:
375         - Add a verbose keyword argument to the BindingsTests constructor,
376         - Add --no-verbose option to the run-bindigs-test.
377         Verbose mode, which is on by default, prints positive results to stdout as before.
378         When the --no-verbose option added to run-bindings-tests, positive results are not printed at all.
379
380         Original patch from Matthew Hanson <matthew_hanson@apple.com>
381
382         * Scripts/run-bindings-tests:
383         (main):
384         * Scripts/webkitpy/bindings/main.py:
385         (BindingsTests.__init__):
386         (BindingsTests.detect_changes):
387
388 2014-06-01  Ryosuke Niwa  <rniwa@webkit.org>
389
390         Rename DoYouEvenBench 0.17 to Speedometer 1.0 and add a new look.
391         https://bugs.webkit.org/show_bug.cgi?id=133455
392
393         Reviewed by Timothy Hatcher.
394
395         Since the perf. dashboard doesn't support following renamed benchmarks,
396         keep reporting Speedometer results as DoYouEvenBench results.
397
398         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
399         (_generate_results_dict):
400
401 2014-05-31  Darin Adler  <darin@apple.com>
402
403         Viewport percentage tests that resize the viewport are flaky
404         https://bugs.webkit.org/show_bug.cgi?id=133351
405
406         Reviewed by Anders Carlsson.
407
408         * DumpRenderTree/mac/DumpRenderTree.mm:
409         (sizeWebViewForCurrentTest): Added a call to reset the window origin, which
410         happens to be stored in the UI delegate object. This is part of resetting the
411         window position.
412
413         * DumpRenderTree/mac/UIDelegate.h: Store the window origin rather than storing
414         a frame rectangle. The size is stored in the size of the web view itself.
415         * DumpRenderTree/mac/UIDelegate.mm:
416         (-[UIDelegate resetWindowOrigin]): Added.
417         (-[UIDelegate webView:setFrame:]): Changed to set the size of the web view. The
418         old version would store the frame, but not resize the web view!
419         (-[UIDelegate webViewFrame:]): Get the size from the web view.
420
421         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
422         (WTR::PlatformWebView::setWindowFrame): Added code to resize the web view.
423
424         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
425         (WTR::PlatformWebView::resizeTo): Added a comment about missing code to resize
426         the window.
427
428         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
429         (WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame so the
430         window gets resized too, not just the web view.
431         (WTR::PlatformWebView::setWindowFrame): Added code to set the size of the web view.
432
433         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
434         (WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame so the
435         window gets resized too, not just the web view.
436         (WTR::PlatformWebView::setWindowFrame): Added code to set the size of the web view.
437
438 2014-05-30  Michael Saboff  <msaboff@apple.com>
439
440         Change run-jsc-stress-tests to not resolve jsc path locally when creating a bundle
441         https://bugs.webkit.org/show_bug.cgi?id=133409
442
443         Reviewed by Filip Pizlo.
444
445         Handle creating a tarball the same way as running remote when processing
446         paths in prepareBundle.
447
448         * Scripts/run-jsc-stress-tests:
449
450 2014-05-30  Mario Sanchez Prada  <mario.prada@samsung.com>
451
452         [ATK] Deprecate usage of logAccessibilityEvents() in layout tests
453         https://bugs.webkit.org/show_bug.cgi?id=132280
454
455         Reviewed by Chris Fleizach.
456
457         Remove implementation of logAccessibilityEvents() for ATK based
458         ports, as this has proved to be a flaky method of checking that
459         ATK events are being properly emitted. Instead, it's better to use
460         the addNotificationListener() functions and provide a JS callback
461         to check that the right events are being emmitted from the tests.
462
463         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
464         (WTR::AccessibilityController::logAccessibilityEvents): Replaced
465         with dummy implementation.
466         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
467         (WTR::AccessibilityNotificationHandler::logAccessibilityEvents): Removed
468
469 2014-05-30  Mario Sanchez Prada  <mario.prada@samsung.com>
470
471         [ATK] Deprecate usage of logAccessibilityEvents() in layout tests
472         https://bugs.webkit.org/show_bug.cgi?id=132280
473
474         Rubber stamped by Carlos Garcia Campos.
475
476         Fix two small issues with previous patch (r169483), that caused some tests to break.
477
478         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
479         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Removed
480         duplicated entry.
481         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
482         (WTR::AccessibilityUIElement::setSelectedTextRange): Fix boolean condition.
483
484 2014-05-30  Jarek Czekalski  <jarekczek@poczta.onet.pl>
485
486         [ATK] Added new accessibility signal: text-caret-moved.
487         Make AccessibilityUIElement.setSelectedTextRange work
488         as atk_text_set_caret_offset when given offset == 0.
489         https://bugs.webkit.org/show_bug.cgi?id=132527
490
491         Reviewed by Mario Sanchez Prada.
492
493         text-caret-moved signal in accessibilityController is needed to
494         implement tests from Tools/TestWebKitAPI/Tests/WebKitGtk/testatk.c
495         as LayoutTests. Add the signal to the controller.
496
497         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
498         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
499         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
500         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
501         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
502         (setSelectedTextRange): Change return type to bool.
503         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
504         (setSelectedTextRange): Call atk_text_set_caret_offset and return bool.
505         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
506         (axObjectEventListener): Add notification name AXTextCaretMoved, allow
507         for extra arguments passed to handler and use it for text-caret-moved offset.
508         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
509         Connect callback to new listener for ATK:AtkText:text-caret-moved.
510         Refactor so that failures be reported.
511         Initialize atk interfaces before trying to connect to them, see
512         https://bugzilla.gnome.org/show_bug.cgi?id=729922
513         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
514         Simplify code by using a vector in place of dozen variables.
515         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
516         Comment about not synchronizing with accessibilityController.
517
518 2014-05-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
519
520         [GTK] Add a WebKit2 Performance bot.
521         https://bugs.webkit.org/show_bug.cgi?id=132862
522
523         Reviewed by Csaba Osztrogonác.
524
525         This adds a GTK WebKit2 perf bot.
526
527         * BuildSlaveSupport/build.webkit.org-config/config.json:
528
529 2014-05-29  Dan Bernstein  <mitz@apple.com>
530
531         Fixed the WebKitTestRunner build after r169452.
532
533         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
534         (WTR::InjectedBundle::initialize):
535
536 2014-05-28  Gwang Yoon Hwang  <yoon@igalia.com>
537
538         Unreviewed. Update my email addresses in contributors.json.
539
540         * Scripts/webkitpy/common/config/contributors.json:
541
542 2014-05-27  Jon Honeycutt  <jhoneycutt@apple.com>
543
544         Need an API test for bug #133193 (r169315)
545         <https://bugs.webkit.org/show_bug.cgi?id=133324>
546
547         This adds an API test that ensures that calling "stop loading" during a
548         "did fail provisional load" callback doesn't crash.
549
550         Reviewed by Andy Estes.
551
552         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
553         Add new files to project.
554
555         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp: Added.
556         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
557         If the message is the "test done" message, record that.
558         (TestWebKitAPI::setInjectedBundleClient):
559         Register a function for the "did receive message from injected bundle"
560         callback.
561         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
562         Assert that we received the message from the injected bundle, and set
563         'done' to finish the test.
564         (TestWebKitAPI::TEST):
565         Create a WebView, register a page loader client for the "did fail
566         provisional load" callback, and load a non-existent resource.
567
568         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp: Added.
569         (TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::StopLoadingDuringDidFailProvisionalLoadTest):
570         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrameCallback):
571         Tell the StopLoadingDuringDidFailProvisionalLoadTest object that the
572         provisional load failed.
573         (TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::didCreatePage):
574         Register a page loader client for the "did fail provisional load"
575         callback.
576         (TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::didFailProvisionalLoad):
577         Call WKBundlePageStopLoading() during the callback. This not crashing
578         is what we're ensuring with this test.
579
580 2014-05-28  Carlos Garcia Campos  <cgarcia@igalia.com>
581
582         [GTK] Make it possible to build with FTL enabled
583         https://bugs.webkit.org/show_bug.cgi?id=133219
584
585         Reviewed by Philippe Normand.
586
587         * gtk/jhbuild-optional.modules: Add llvm from svn and build the
588         same revision than mac.
589
590 2014-05-27  Michael Saboff  <msaboff@apple.com>
591
592         REGRESSION(r169265): sh: line 0: cd: ../.vm
593         https://bugs.webkit.org/show_bug.cgi?id=133242
594
595         Rubber stamped by Oliver Hunt.
596
597         Changed runAndMonitorTestRunnerCommand() to pass mysys as a string instead of an
598         array since the command may contain character escapes that don't work with the
599         array form of system().
600
601         * Scripts/run-jsc-stress-tests:
602
603 2014-05-27  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
604
605         [EFL] Change download url of freetype6
606         https://bugs.webkit.org/show_bug.cgi?id=133303
607
608         Reviewed by Csaba Osztrogonác.
609
610         freetype6 tarball isn't downloaded in Korea. So, we need to
611         change the url for now.
612
613         * efl/jhbuild.modules:
614
615 2014-05-27  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
616
617         Remove BLOB guards
618         https://bugs.webkit.org/show_bug.cgi?id=132863
619
620         Reviewed by Csaba Osztrogonác.
621
622         * Scripts/webkitperl/FeatureList.pm:
623
624 2014-05-27  Alberto Garcia  <berto@igalia.com>
625
626         Remove leftover comment from r165182.
627
628         Rubber stamped by Carlos Garcia Campos.
629
630         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
631
632 2014-05-26  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
633
634         [EFL] Add LLVM as optional jhbuild module for FTL developers
635         https://bugs.webkit.org/show_bug.cgi?id=133216
636
637         Reviewed by Gyuyoung Kim.
638
639         * efl/jhbuild.modules:
640
641 2014-05-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
642
643         Fix test failures on python test
644         https://bugs.webkit.org/show_bug.cgi?id=133297
645
646         Reviewed by Dirk Schulze.
647
648         2 tests are failing because of unbounded local variable reference in test_importer.py.
649
650         * Scripts/webkitpy/w3c/test_importer.py: Move local variable declaration to top.
651         (TestImporter.import_tests):
652
653 2014-05-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
654
655         [GTK] GObject DOM bindings API break test fails in the tests bots
656         https://bugs.webkit.org/show_bug.cgi?id=133211
657
658         Reviewed by Martin Robinson.
659
660         When generating the built product archive on platform GTK, we need
661         to copy also the file gtkdoc-webkitdom.cfg and the directory
662         DerivedSources/webkitdom.
663
664         * BuildSlaveSupport/built-product-archive:
665         (archiveBuiltProduct):
666
667 2014-05-26  Commit Queue  <commit-queue@webkit.org>
668
669         Unreviewed, rolling out r169122.
670         https://bugs.webkit.org/show_bug.cgi?id=133288
671
672         Broke CJK font fallback (Requested by ap on #webkit).
673
674         Reverted changeset:
675
676         "[Mac] WebProcess doesn't follow localization of UI process
677         when run as a service"
678         https://bugs.webkit.org/show_bug.cgi?id=133126
679         http://trac.webkit.org/changeset/169122
680
681 2014-05-26  Carlos Garcia Campos  <cgarcia@igalia.com>
682
683         [GTK] WebProcess leaked when closing pages with network process enabled
684         https://bugs.webkit.org/show_bug.cgi?id=129684
685
686         Reviewed by Anders Carlsson.
687
688         Enable the test to check that web processes finish when the web
689         view is destroyed.
690
691         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
692
693 2014-05-26  Carlos Garcia Campos  <cgarcia@igalia.com>
694
695         REGRESSION(r164632): [GTK] Crash in generate-gtkdoc when rebasing docs
696         https://bugs.webkit.org/show_bug.cgi?id=133279
697
698         Reviewed by Philippe Normand.
699
700         generator.saw_warnings is only set by GTKDoc::generate(), so it
701         should only be used after generate.
702
703         * gtk/generate-gtkdoc:
704         (generate_documentation_for_config): Do not check
705         generator.saw_warnings again, simply return the value returned by
706         generate_doc() which is generator.saw_warnings. When rebasing,
707         returns always False since there aren't warnings.
708
709 2014-05-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
710
711         W3C test importer should catch exceptions coming from HTML/CSS conversion
712         https://bugs.webkit.org/show_bug.cgi?id=133176
713
714         Reviewed by Darin Adler.
715
716         Exceptions raised when converting HTML/CSS are caught.
717         Files for which conversion failed are still copied to the target directory.
718         Each individual conversion failure is logged.
719         Total conversion failure number is logged at the end of the import process.
720
721         * Scripts/webkitpy/w3c/test_importer.py:
722         (TestImporter.import_tests):
723
724 2014-05-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
725
726         [GTK] Allow to run the tests on the native X display.
727         https://bugs.webkit.org/show_bug.cgi?id=133157
728
729         Reviewed by Benjamin Poulain.
730
731         This adds a new driver (xorgdriver) that runs the tests on the
732         X display referenced by the environment variable DISPLAY.
733
734         This new driver will be activated only if the environment variable
735         USE_NATIVE_XDISPLAY is defined. This can be used both for layout
736         tests and performance tests.
737
738         This patch also makes the script run-perf-tests to check the
739         system dependencies before starting the tests. Previously this
740         was not checked, and if the system dependencies were not met,
741         the script tried to execute the tests anyway, causing massive
742         failures. For example, if you had Xvfb not installed and you
743         wanted to use the Xvfb driver (the default on GTK and EFL),
744         run-perf-tests would not abort.
745
746         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
747         (PerfTestsRunner._parse_args): Check the system dependencies of
748         the driver before starting the tests.
749         * Scripts/webkitpy/port/driver.py:
750         (Driver): Implement generic check_driver method.
751         (Driver.check_driver):
752         (Driver.check_driver.implementation):
753         * Scripts/webkitpy/port/gtk.py:
754         (GtkPort._driver_class): Check for environment variable
755         USE_NATIVE_XDISPLAY to decide if the Xorg driver should be used.
756         * Scripts/webkitpy/port/xorgdriver.py: Added.
757         (XorgDriver): Implement Xorg driver.
758         (XorgDriver.check_driver):
759         (XorgDriver._start):
760
761 2014-05-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
762
763         REGRESSION(r166798): [GTK] [EFL] kill-old-processes should not kill dbus-daemon
764         https://bugs.webkit.org/show_bug.cgi?id=133215
765
766         Reviewed by Csaba Osztrogonác.
767
768         This reverts r166798.
769
770         * BuildSlaveSupport/kill-old-processes:
771         (main):
772
773 2014-05-26  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
774
775         [EFL] Turn on ENABLE_CSS_FILTERS in build script
776         https://bugs.webkit.org/show_bug.cgi?id=133278
777
778         Reviewed by Gyuyoung Kim.
779
780         * Scripts/webkitperl/FeatureList.pm: Add a build script condition missing in r169172.
781
782 2014-05-26  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
783
784         run-javascriptcore-tests warning fix on non Mac platforms
785         https://bugs.webkit.org/show_bug.cgi?id=133260
786
787         Reviewed by Darin Adler.
788
789         * Scripts/webkitdirs.pm:
790         (argumentsForConfiguration):
791
792 2014-05-23  Michael Saboff  <msaboff@apple.com>
793
794         REGRESSION(r169265): sh: line 0: cd: ../.vm
795         https://bugs.webkit.org/show_bug.cgi?id=133242
796
797         Rubber stamped by Geoffrey Garen.
798
799         Added missing shell escapes '\' required as part of previous fix.
800
801         * Scripts/run-jsc-stress-tests:
802
803 2014-05-23  Ryosuke Niwa  <rniwa@webkit.org>
804
805         Revert the erroneous change committed in r169286.
806
807         * Scripts/webkitpy/performance_tests/perftest.py:
808         (PerfTest._run_with_driver):
809
810 2014-05-23  Geoffrey Garen  <ggaren@apple.com>
811
812         run-perf-tests should ignore whitespace lines when snarfing test output
813         https://bugs.webkit.org/show_bug.cgi?id=133238
814
815         Reviewed by Ryosuke Niwa.
816
817         Required for PerformanceTests/Canvas/terrain.html.
818
819         * Scripts/webkitpy/performance_tests/perftest.py:
820         (PerfTest._run_with_driver):
821         (PerfTest):
822
823 2014-05-23  Michael Saboff  <msaboff@apple.com>
824
825         REGRESSION (r169241) Crash running run-jsc-stress-tests on EFL ARM
826         https://bugs.webkit.org/show_bug.cgi?id=133223
827
828         Reviewed by Geoffrey Garen.
829
830         Change runAndMonitorTestRunnerCommand() to convert the *cmd argument to a
831         string before calling IO.popen() to work with older versions of ruby.
832         Changed the remote path in runShellTestRunner to quote the command
833         string we want to run via ssh so that it will work correctly with array
834         to string conversion needed for popen.
835
836         * Scripts/run-jsc-stress-tests:
837
838 2014-05-23  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
839
840         Remove 'css-shaders' option from the build-webkit
841         https://bugs.webkit.org/show_bug.cgi?id=133212
842
843         Reviewed by Daniel Bates.
844
845         Original CSS shaders removed in r162644.
846
847         * Scripts/webkitperl/FeatureList.pm:
848
849 2014-05-23  Carlos Garcia Campos  <cgarcia@igalia.com>
850
851         [GTK] GObject DOM bindings API break test should fail in the bots when the command fails to run
852         https://bugs.webkit.org/show_bug.cgi?id=133209
853
854         Reviewed by Sergio Villar Senin.
855
856         Return FAILURE when the command failed to run.
857
858         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
859         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.evaluateCommand):
860
861 2014-05-23  Alberto Garcia  <berto@igalia.com>
862
863         [GTK] Install libharfbuzz-dev in Tools/gtk/install-dependencies
864         https://bugs.webkit.org/show_bug.cgi?id=133210
865
866         Reviewed by Carlos Garcia Campos.
867
868         * gtk/install-dependencies:
869
870 2014-05-22  Benjamin Poulain  <bpoulain@apple.com>
871
872         Add Yusuke Suzuki to the list of contributors (for real)
873
874         Wrong section...
875
876         * Scripts/webkitpy/common/config/contributors.json:
877
878 2014-05-22  Benjamin Poulain  <bpoulain@apple.com>
879
880         Add Yusuke Suzuki to the list of contributors
881
882         * Scripts/webkitpy/common/config/contributors.json:
883
884 2014-05-22  Michael Saboff  <msaboff@apple.com>
885
886         Eliminate n/total progress update from run-jsc-stress-tests output to file
887         https://bugs.webkit.org/show_bug.cgi?id=133191
888
889         Reviewed by Geoffrey Garen.
890
891         Changed progressMeter setting to be based on stdout being a tty instead of
892         stdin.  Unified the processing of output from the shell runner to match the
893         same processing as is used by the makefile runner.  As part of this, the 
894         shell runner script was simplified.  It now forwards the output of each
895         test_script just like the Makefile and doesn't provide its own progress.
896
897         * Scripts/jsc-stress-test-helpers/shell-runner.sh:
898         * Scripts/run-jsc-stress-tests:
899
900 2014-05-22  Michael Saboff  <msaboff@apple.com>
901
902         Add option to run-jsc-stress-tests to use installed jsc
903         https://bugs.webkit.org/show_bug.cgi?id=133102
904
905         Reviewed by Geoffrey Garen.
906
907         Added --no-copy option to not copy a JavaScriptCore framework, but use the one
908         provied with the --jsc option.
909
910         * Scripts/run-jsc-stress-tests:
911
912 2014-05-21  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
913
914         [EFL] Add include path of compact_unwind_encoding.h if FTL JIT is enabled
915         https://bugs.webkit.org/show_bug.cgi?id=132907
916
917         Reviewed by Gyuyoung Kim.
918
919         We need the mach-o/compact_unwind_encoding.h header from libc++abi-dev package
920         in JavaScriptCore/ftl/FTLUnwindInfo.cpp when FTL JIT is enabled.
921
922         * efl/install-dependencies:
923
924 2014-05-21  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
925
926         REGRESSION(r169092): It broke run-jsc-stress tests on non Mac platforms
927         https://bugs.webkit.org/show_bug.cgi?id=133145
928
929         Reviewed by Csaba Osztrogonác.
930
931         * Scripts/run-jsc-stress-tests:
932
933 2014-05-20  Alexey Proskuryakov  <ap@apple.com>
934
935         [Mac] WebProcess doesn't follow localization of UI process when run as a service
936         https://bugs.webkit.org/show_bug.cgi?id=133126
937         <rdar://problem/13396515>
938         <rdar://problem/16561084>
939
940         Reviewed by Sam Weinig and Tim Horton.
941
942         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
943         (WTR::InjectedBundle::platformInitialize): It was too late to override language
944         here, and it's not necessary any more. Keeping the code for older OS versions in
945         case it did have effect in some code paths.
946
947 2014-05-19  David Farler  <dfarler@apple.com>
948
949         Move WebKitTestRunner to std::unique_ptr
950         https://bugs.webkit.org/show_bug.cgi?id=133081
951
952         Reviewed by Daniel Bates.
953
954         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
955         (WTR::InjectedBundle::didCreatePage):
956         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
957         * WebKitTestRunner/TestController.cpp:
958         (WTR::TestController::initialize):
959         (WTR::TestController::createWebViewWithOptions):
960         (WTR::TestController::resetStateToConsistentValues):
961         (WTR::TestController::runTest):
962         * WebKitTestRunner/TestController.h:
963         * WebKitTestRunner/TestInvocation.cpp:
964         * WebKitTestRunner/TestInvocation.h:
965         * WebKitTestRunner/WorkQueueManager.cpp:
966         (WTR::WorkQueueManager::processWorkQueue):
967         (WTR::WorkQueueManager::enqueue):
968         * WebKitTestRunner/WorkQueueManager.h:
969
970 2014-05-20  Carlos Garcia Campos  <cgarcia@igalia.com>
971
972         [GTK] WebKitWebPage::send-request always pass a valid pointer for redirected response
973         https://bugs.webkit.org/show_bug.cgi?id=133119
974
975         Reviewed by Sergio Villar Senin.
976
977         Check that redirect response parameter of
978         WebKitWebPage::send-request signal is NULL when not redirecting
979         and a valid WebKitURIResponse object when redirecting.
980
981         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
982         (testWebResourceSendRequest):
983         (serverCallback):
984         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
985         (sendRequestCallback):
986
987 2014-05-20  Carlos Garcia Campos  <cgarcia@igalia.com>
988
989         REGRESSION(CMAKE): [GTK] Several WebKit2GTK+ unit tests are no longer built
990         https://bugs.webkit.org/show_bug.cgi?id=133117
991
992         Reviewed by Philippe Normand.
993
994         Bring back missing tests to the build.
995
996         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
997
998 2014-05-19  Filip Pizlo  <fpizlo@apple.com>
999
1000         Take care of some ARM64 test failures
1001         https://bugs.webkit.org/show_bug.cgi?id=133090
1002
1003         Reviewed by Geoffrey Garen.
1004
1005         * Scripts/run-jsc-stress-tests: Make it easier to conditionally skip things.
1006
1007 2014-05-19  David Kilzer  <ddkilzer@apple.com>
1008
1009         [iOS] REGRESSION (r168910): webkitdirs.pm: Be more forgiving when parsing --sdk, --device and --sim
1010         <http://webkit.org/b/133089>
1011
1012         Reviewed by Darin Adler.
1013
1014         * Scripts/webkitdirs.pm:
1015         (determineXcodeSDK): If both '--sdk SDKROOT' and '--sim' are
1016         specified on the command line, we would remove the '--sdk'
1017         arguments, but leave '--sim', potentially passing it along to
1018         xcodebuild causing a build failure.  This happens when
1019         'old-run-webkit-tests --release --sim' invokes
1020         build-dumprendertree when DumpRenderTree hasn't been built yet.
1021
1022 2014-05-19  David Farler  <dfarler@apple.com>
1023
1024         Dashboard: OpenSource revision key changed from WebKitOpenSource to WebKit
1025         https://bugs.webkit.org/show_bug.cgi?id=133086
1026
1027         Reviewed by Daniel Bates.
1028
1029         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1030
1031 2014-05-19  David Kilzer  <ddkilzer@apple.com>
1032
1033         REGRESSION (r169042): Fix run-api-tests on Mountain Lion
1034         <http://webkit.org/b/132954>
1035
1036         * Scripts/webkitdirs.pm:
1037         (sharedCommandLineOptionsUsage): Remove the prototype for the
1038         subroutine.  Older perls don't like the "+@" syntax.
1039
1040 2014-05-19  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1041
1042         run-javascriptcore-tests should sort the list of failing stress tests
1043         https://bugs.webkit.org/show_bug.cgi?id=132989
1044
1045         Reviewed by Csaba Osztrogonác.
1046
1047         * Scripts/run-javascriptcore-tests:
1048
1049 2014-05-19  David Kilzer  <ddkilzer@apple.com>
1050
1051         webkitdirs.pm: Add setupMacWebKitEnvironment() to set __XPC_DYLD_FRAMEWORK_PATH consistently
1052         <http://webkit.org/b/132954>
1053
1054         Reviewed by Darin Adler.
1055
1056         Extract code into setupMacWebKitEnvironment() for setting up
1057         common environment variables so it may be shared.  Sets
1058         __XPC_DYLD_FRAMEWORK_PATH consistently and adds support for
1059         using guardmalloc to some scripts.
1060
1061         Also adds support for parsing shared (common) command-line
1062         switches, initially just -g|--guard-malloc.
1063
1064         * Scripts/bisect-builds: Add -g|--guard-malloc support by using
1065         sharedCommandLineOptions() and sharedCommandLineOptionsUsage().
1066         (mountAndRunNightly): Call setupMacWebKitEnvironment().  Use a
1067         local copy of %ENV when launching Safari so we don't have to
1068         restore variables.
1069
1070         * Scripts/run-api-tests: Add -g|--guard-malloc support by using
1071         sharedCommandLineOptions() and sharedCommandLineOptionsUsage().
1072         Check result of GetOptions() to catch invalid command-line
1073         switches.
1074         (runTest): Use a local copy of %ENV when running tests so we
1075         don't have to restore variables.
1076         (prepareEnvironmentForRunningTestTool): Call
1077         setupMacWebKitEnvironment().
1078
1079         * Scripts/run-pageloadtest: Add -g|--guard-malloc support by
1080         using sharedCommandLineOptions() and
1081         sharedCommandLineOptionsUsage().  Call
1082         setupMacWebKitEnvironment().
1083
1084         * Scripts/webkitdirs.pm:
1085         (sharedCommandLineOptions): Return array of common switches to
1086         pass to Getopt::Long::GetOptions().
1087         (sharedCommandLineOptionsUsage): Return formatted string of
1088         common switches for printing usage help text.
1089         (setUpGuardMallocIfNeeded): Support using '-g' for enabling
1090         guardmalloc.
1091         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Ditto.
1092         (setupMacWebKitEnvironment): Extracted from runMacWebKitApp()
1093         and changed not to clobber DYLD_FRAMEWORK_PATH if already set.
1094         (runMacWebKitApp): Call setupMacWebKitEnvironment().  Use a
1095         local copy of %ENV when launching Safari so we don't have to
1096         restore variables.
1097         (execMacWebKitAppForDebugging): Call
1098         setupMacWebKitEnvironment().
1099
1100 2014-05-18  Rik Cabanier  <cabanier@adobe.com>
1101
1102         support for navigator.hardwareConcurrency
1103         https://bugs.webkit.org/show_bug.cgi?id=132588
1104
1105         Reviewed by Filip Pizlo.
1106
1107         * Scripts/webkitperl/FeatureList.pm:
1108
1109 2014-05-18  Anders Carlsson  <andersca@apple.com>
1110
1111         Implement Navigations for all methods declared returning one
1112         https://bugs.webkit.org/show_bug.cgi?id=133048
1113         <rdar://problem/16830064>
1114
1115         Reviewed by Sam Weinig.
1116
1117         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
1118         Import WebKit.h.
1119         
1120         * MiniBrowser/mac/WK2BrowserWindowController.m:
1121         (-[WK2BrowserWindowController webView:didStartProvisionalNavigation:]):
1122         (-[WK2BrowserWindowController webView:didReceiveServerRedirectForProvisionalNavigation:]):
1123         (-[WK2BrowserWindowController webView:didFailProvisionalNavigation:withError:]):
1124         (-[WK2BrowserWindowController webView:didCommitNavigation:]):
1125         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
1126         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
1127         Print out the navigations.
1128
1129 2014-05-17  Zalan Bujtas  <zalan@apple.com>
1130
1131         Subpixel rendering: Add subpixelCSSOMElementMetricsEnabled to WK1 WebPreferences.
1132         https://bugs.webkit.org/show_bug.cgi?id=133029
1133
1134         Reviewed by Simon Fraser.
1135
1136         Added a menu item to toggle subpixelCSSOMElementMetricsEnabled's value. However
1137         toggling it on a WK2 window needs restart.
1138         Adding dynamic toggle to WK2 requires a WebPreferences SPI. It's not worth cluttering
1139         the WebPreferences just to support this temporary toggle.
1140
1141         * MiniBrowser/mac/BrowserWindowController.h:
1142         * MiniBrowser/mac/MainMenu.xib:
1143         * MiniBrowser/mac/WK1BrowserWindowController.m:
1144         (-[WK1BrowserWindowController validateMenuItem:]):
1145         (-[WK1BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]):
1146         (-[WK1BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]):
1147         * MiniBrowser/mac/WK2BrowserWindowController.m:
1148         (-[WK2BrowserWindowController validateMenuItem:]):
1149         (-[WK2BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]):
1150         (-[WK2BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]):
1151
1152 2014-05-17  Anders Carlsson  <andersca@apple.com>
1153
1154         Replace WKContextSetDatabaseDirectory with two WKContextConfiguration parameters
1155         https://bugs.webkit.org/show_bug.cgi?id=133033
1156         <rdar://problem/16830143>
1157
1158         Reviewed by Sam Weinig.
1159
1160         Set up the WebSQL and IndexedDB directories.
1161
1162         * WebKitTestRunner/TestController.cpp:
1163         (WTR::TestController::initialize):
1164
1165 2014-05-16  Martin Hock  <mhock@apple.com>
1166
1167         MemoryCache::addImageToCache should return the result of add().
1168         https://bugs.webkit.org/show_bug.cgi?id=132928
1169         <rdar://problem/16651547>
1170
1171         Reviewed by Alexey Proskuryakov.
1172
1173         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1174         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1175         * TestWebKitAPI/Tests/ios/MemoryCacheAddImageToCacheIOS.mm: Added.
1176         (TestWebKitAPI::TEST):
1177
1178 2014-05-15  David Farler  <dfarler@apple.com>
1179
1180         old-run-webkit-tests: allow specifying a simulator app path
1181         https://bugs.webkit.org/show_bug.cgi?id=132975
1182
1183         Reviewed by Anders Carlsson.
1184
1185         * Scripts/old-run-webkit-tests:
1186         (openIPhoneSimulator):
1187         Add new --simulator-app command line parameter for specifying the
1188         absolute path to the simulator app to launch before starting a
1189         session.
1190
1191 2014-05-16  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1192
1193         [webkitpy] In case of multiple bug rollout, all bugs should be reopened, not only the oldest one
1194         https://bugs.webkit.org/show_bug.cgi?id=131363
1195
1196         Reviewed by Csaba Osztrogonác.
1197
1198         * Scripts/webkitpy/common/checkout/checkout_mock.py:
1199         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
1200         (MockBugzilla):
1201         * Scripts/webkitpy/tool/commands/download_unittest.py:
1202         (test_create_rollout_multiple_revision_with_one_resolved):
1203         (test_create_rollout_multiple_resolved):
1204         (test_rollout_two_revisions):
1205         (test_rollout_multiple_revisions):
1206         (test_rollout_multiple_revisions_with_a_missing_bug_id):
1207         * Scripts/webkitpy/tool/steps/createbug.py:
1208         (CreateBug.run):
1209         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
1210         (ReopenBugAfterRollout.run):
1211
1212 2014-05-16  Martin Hodovan  <mhodovan.u-szeged@partner.samsung.com>
1213
1214         [WK2] Change the remaining framework includes from WebKit2 to WebKit
1215         https://bugs.webkit.org/show_bug.cgi?id=132956
1216
1217         Reviewed by Sam Weinig.
1218
1219         * MiniBrowser/MiniBrowserWebProcessPlugIn.h:
1220         * MiniBrowser/mac/AppDelegate.m:
1221         * MiniBrowser/mac/WK2BrowserWindowController.m:
1222         * TestWebKitAPI/InjectedBundleController.h:
1223         * TestWebKitAPI/InjectedBundleMain.cpp:
1224         * TestWebKitAPI/JavaScriptTest.cpp:
1225         * TestWebKitAPI/PlatformUtilities.h:
1226         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
1227         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
1228         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
1229         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
1230         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
1231         (TestWebKitAPI::TEST):
1232         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive_Bundle.cpp:
1233         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp:
1234         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
1235         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
1236         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
1237         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
1238         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
1239         * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp:
1240         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
1241         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
1242         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
1243         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
1244         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
1245         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
1246         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
1247         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
1248         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
1249         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
1250         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
1251         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1252         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp:
1253         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback_Bundle.cpp:
1254         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
1255         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
1256         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
1257         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
1258         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp:
1259         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
1260         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp:
1261         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins_Bundle.cpp:
1262         * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp:
1263         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
1264         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
1265         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
1266         * TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:
1267         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
1268         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
1269         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp:
1270         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
1271         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp:
1272         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
1273         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp:
1274         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp:
1275         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1276         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1277         * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp:
1278         * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp:
1279         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm:
1280         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp:
1281         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
1282         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp:
1283         * TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp:
1284         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
1285         * TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp:
1286         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
1287         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp:
1288         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:
1289         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp:
1290         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1291         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
1292         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
1293         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
1294         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp:
1295         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
1296         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp:
1297         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
1298         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp:
1299         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
1300         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
1301         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor_Bundle.mm:
1302         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
1303         * TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm:
1304         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
1305         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
1306         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
1307         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
1308         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
1309         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
1310         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1311         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
1312         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
1313         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1314         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
1315         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp:
1316         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
1317         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
1318         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
1319         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
1320         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
1321         * TestWebKitAPI/config.h:
1322         * TestWebKitAPI/efl/PlatformWebView.cpp:
1323         * TestWebKitAPI/mac/JavaScriptTestMac.mm:
1324         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1325         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1326         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
1327         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
1328         * WebKitTestRunner/EventSenderProxy.h:
1329         * WebKitTestRunner/GeolocationProviderMock.cpp:
1330         * WebKitTestRunner/GeolocationProviderMock.h:
1331         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1332         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1333         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1334         * WebKitTestRunner/InjectedBundle/GCController.cpp:
1335         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1336         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1337         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
1338         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1339         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1340         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1341         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1342         * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
1343         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
1344         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1345         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1346         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1347         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
1348         * WebKitTestRunner/InjectedBundle/ios/EventSenderProxyIOS.mm:
1349         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
1350         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
1351         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1352         * WebKitTestRunner/PlatformWebView.h:
1353         * WebKitTestRunner/StringFunctions.h:
1354         * WebKitTestRunner/TestController.cpp:
1355         * WebKitTestRunner/TestController.h:
1356         * WebKitTestRunner/TestInvocation.cpp:
1357         * WebKitTestRunner/TestInvocation.h:
1358         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1359         * WebKitTestRunner/WebNotificationProvider.cpp:
1360         * WebKitTestRunner/WebNotificationProvider.h:
1361         * WebKitTestRunner/WorkQueueManager.cpp:
1362         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
1363         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1364         * WebKitTestRunner/cocoa/CrashReporterInfo.mm:
1365         * WebKitTestRunner/config.h:
1366         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1367         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1368         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1369         * WebKitTestRunner/ios/TestControllerIOS.mm:
1370         * WebKitTestRunner/mac/EventSenderProxy.mm:
1371         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1372         * WebKitTestRunner/mac/TestControllerMac.mm:
1373
1374 2014-05-15  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1375
1376         [EFL][WK2] Skip failing unit tests
1377         https://bugs.webkit.org/show_bug.cgi?id=132979
1378
1379         Reviewed by Daniel Bates.
1380
1381         * TestWebKitAPI/PlatformEfl.cmake: Skip failing unit tests for now.
1382
1383 2014-05-15  David Kilzer  <ddkilzer@apple.com>
1384
1385         [iOS] Support TestWebKitAPI in the iOS Simulator
1386         <http://webkit.org/b/129535>
1387         <rdar://problem/16203529>
1388
1389         Reviewed by Daniel Bates.
1390
1391         * Scripts/run-api-tests:
1392         (runTest):
1393         (listAllTests):
1394         - Extract common arguments into local variable.
1395         - Use xcrun to find the sim tool in order to invoke
1396         TestWebKitAPI properly in the iOS Simulator. 
1397
1398         * Scripts/webkitdirs.pm:
1399         (argumentsForConfiguration): Set --device or --sim as
1400         appropriate to fix buildTestTool() in run-api-tests.
1401
1402 2014-05-15  Tim Horton  <timothy_horton@apple.com>
1403
1404         Fix a logging typo in copy-webkitlibraries-to-product-directory
1405
1406         Reviewed by Dean Jackson.
1407
1408         * Scripts/copy-webkitlibraries-to-product-directory:
1409
1410 2014-05-15  David Kilzer  <ddkilzer@apple.com>
1411
1412         TestWebKitAPI: URLExtras.mm should be a shared test for iOS and Mac
1413         <http://webkit.org/b/132959>
1414
1415         Reviewed by Dan Bernstein.
1416
1417         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add
1418         Cocoa directory to project and move URLExtras.mm into it.
1419         * TestWebKitAPI/Tests/Cocoa/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/mac/URLExtras.mm.
1420
1421 2014-05-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1422
1423         [GTK] Compile all installed resources as GResources
1424         https://bugs.webkit.org/show_bug.cgi?id=131099
1425
1426         Reviewed by Philippe Normand.
1427
1428         * Scripts/webkitpy/port/gtk.py:
1429         (GtkPort.setup_environ_for_server): Removed now unneeded
1430         AUDIO_RESOURCES_PATH env var.
1431
1432 2014-05-14  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1433
1434         Remove CSS_STICKY_POSITION guards
1435         https://bugs.webkit.org/show_bug.cgi?id=132676
1436
1437         Reviewed by Simon Fraser.
1438
1439         * Scripts/webkitperl/FeatureList.pm:
1440
1441 2014-05-14  Carlos Garcia Campos  <cgarcia@igalia.com>
1442
1443         REGRESSION(CMAKE): [GTK] InputMethodFilter unit test is not built
1444         https://bugs.webkit.org/show_bug.cgi?id=132686
1445
1446         Reviewed by Philippe Normand.
1447
1448         Bring back InputMethodFilter test to the build and compile it into
1449         a single binary TestWebCore with the other WebCore tests. Also
1450         move it from TestWebKitAPI/gtk/ to TestWebKitAPI/Tests/WebCore/gtk/.
1451
1452         * Scripts/run-gtk-tests:
1453         (TestRunner): Remove WebCoreGtk from the list of test directories.
1454         * TestWebKitAPI/PlatformGTK.cmake:
1455         * TestWebKitAPI/Tests/WebCore/gtk/InputMethodFilter.cpp: Renamed from Tools/TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp.
1456
1457 2014-05-14  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
1458
1459         [EFL] Make XVFBDriver optional
1460         https://bugs.webkit.org/show_bug.cgi?id=131036
1461
1462         Reviewed by Gyuyoung Kim.
1463
1464         * Scripts/webkitpy/port/efl.py:
1465         (EflPort._driver_class):
1466
1467 2014-05-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1468
1469         Flakiness dashboard contains outdated list of bots on builders.jsonp
1470         https://bugs.webkit.org/show_bug.cgi?id=132874
1471
1472         Reviewed by Darin Adler.
1473
1474         * TestResultServer/static-dashboards/builders.jsonp: Regenerate this
1475         file by changing to the directory Tools/TestResultServer and executing
1476         the script generate_builders_json.py
1477
1478 2014-05-11  Anders Carlsson  <andersca@apple.com>
1479
1480         Replace WKContextSetLocalStorageDirectory with a context configuration getter/setter
1481         https://bugs.webkit.org/show_bug.cgi?id=132809
1482
1483         Reviewed by Dan Bernstein.
1484
1485         * WebKitTestRunner/TestController.cpp:
1486         (WTR::TestController::initialize):
1487         Set the local storage directory using WKContextConfigurationSetLocalStorageDirectory.
1488
1489 2014-05-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1490
1491         REGRESSION(CMAKE): [GTK] JavaScriptCore API tests are not built anymore
1492         https://bugs.webkit.org/show_bug.cgi?id=132739
1493
1494         Reviewed Anders Carlsson.
1495
1496         * TestWebKitAPI/CMakeLists.txt: Add missing includes required by
1497         the JSC unit tests.
1498         * TestWebKitAPI/PlatformGTK.cmake: Bring back JavaScriptCore unit tests.
1499
1500 2014-05-11  Anders Carlsson  <andersca@apple.com>
1501
1502         Add a WKContextConfigurationRef object and make the injected bundle path part of the configuration
1503         https://bugs.webkit.org/show_bug.cgi?id=132806
1504
1505         Reviewed by Beth Dakin.
1506
1507         Migrate to WKContextConfiguration.
1508
1509         * WebKitTestRunner/TestController.cpp:
1510         (WTR::TestController::initialize):
1511
1512 2014-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
1513
1514         REGRESSION(CMAKE): [GTK] WebKit2 C API tests are not longer built in the same binary
1515         https://bugs.webkit.org/show_bug.cgi?id=132685
1516
1517         Reviewed by Martin Robinson.
1518
1519         Use a single TestWebKit2 binary for all WebKit2 C API tests.
1520
1521         * TestWebKitAPI/PlatformGTK.cmake:
1522
1523 2014-05-09  Benjamin Poulain  <benjamin@webkit.org>
1524
1525         [iOS] Switch geolocation to an explicit authorization query model
1526         https://bugs.webkit.org/show_bug.cgi?id=132717
1527
1528         Reviewed by Sam Weinig.
1529
1530         * DumpRenderTree/mac/MockGeolocationProvider.mm:
1531         (-[MockGeolocationProvider initializeGeolocationForWebView:listener:]):
1532         (-[MockGeolocationProvider cancelWarmUpForWebView:]): Deleted.
1533
1534 2014-05-09  David Farler  <dfarler@apple.com>
1535
1536         com.apple.iphonesimulator.startSession needs to pass "RuntimeIdentifier"
1537         https://bugs.webkit.org/show_bug.cgi?id=132718
1538
1539         Reviewed by David Kilzer.
1540
1541         The simulator may not be able to look up runtimes by SDK paths
1542         and instead will map SDK versions to runtimes instead. In
1543         com.apple.iphonesimulator.startSession notifications,
1544         'runtimeIdentifier' (SDK version string) is preferred over
1545         'sdkRoot' (SDK path) anyway. Include the 'runtimeIdentifier' key
1546         when creating a new DRT or WKTR simulator session.
1547
1548         IPhoneSimulatorNotification.pm filters out keys for this
1549         notification's userInfo with a hard-coded list. There's no harm
1550         in including extra key-value pairs in an NSNotification userInfo
1551         dictionary anyway and the simulator may again change its
1552         userInfo schema for this notification.
1553
1554         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm:
1555         (postStartSessionNotification):
1556         * Scripts/old-run-webkit-tests:
1557         (installAndLaunchDumpToolAppUsingNotification):
1558
1559 2014-05-09  Anders Carlsson  <andersca@apple.com>
1560
1561         Another build fix.
1562
1563         * Scripts/build-webkit:
1564         WebKit2 should always be built for OS X and iOS.
1565
1566 2014-05-09  Anders Carlsson  <andersca@apple.com>
1567
1568         Follow-up build fix.
1569
1570         * Scripts/build-webkit:
1571         WebKit2 should no longer be built before WebKit.
1572
1573 2014-05-09  Anders Carlsson  <andersca@apple.com>
1574
1575         Rename WebKit2.framework to WebKit.framework
1576         https://bugs.webkit.org/show_bug.cgi?id=132743
1577         <rdar://problem/15920046>
1578
1579         Reviewed by Dan Bernstein.
1580
1581         * Scripts/check-for-inappropriate-files-in-framework:
1582         Use PRODUCT_NAME instead of PROJECT_NAME when matching frameworks.
1583         Change WebKit2 to WebKit.
1584
1585         * Scripts/check-for-webkit-framework-include-consistency:
1586         Change WebKit to WebKitLegacy.
1587
1588 2014-05-09  Manuel Rego Casasnovas  <rego@igalia.com>
1589
1590         Remove GTK+ WK1 EWS from build.webkit.org/dashboard
1591         https://bugs.webkit.org/show_bug.cgi?id=132732
1592
1593         Reviewed by Alexey Proskuryakov.
1594
1595         GTK+ WK1 EWS was removed in r166427, so it shouldn't appear in the dashboard.
1596
1597         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
1598         (EWS): Remove GTK+ WK1 EWS.
1599
1600 2014-05-09  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1601
1602         Add new u-szeged contributors.
1603
1604         Reviewed by Csaba Osztrogonác.
1605
1606         * Scripts/webkitpy/common/config/contributors.json:
1607
1608 2014-05-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1609
1610         REGRESSION(CMAKE): [GTK] run-gtk-tests doesn't set the right injected bundle path
1611         https://bugs.webkit.org/show_bug.cgi?id=132736
1612
1613         Reviewed by Philippe Normand.
1614
1615         There are two problems, the path returned by common.library_build_path() is wrong when
1616         common.binary_build_path() has previously been called, and the test is still looking for
1617         the .la instead of .so
1618
1619         * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:
1620         (TestWebKitAPI::Util::createInjectedBundlePath): Use .so instead
1621         of .la as extension of the injected bundle library.
1622         * gtk/common.py:
1623         (binary_build_path): Remove unused global variable and add a new
1624         one for binary_build_dir instead of sharing the same global
1625         variable for library_build_path and binary_build_path.
1626
1627 2014-05-08  Praveen R Jadhav  <praveen.j@samsung.com>
1628
1629         [EFL] Enable MEDIA_STREAM for EFL port
1630         https://bugs.webkit.org/show_bug.cgi?id=132648
1631
1632         Reviewed by Gyuyoung Kim.
1633
1634         Script modified to enable MEDIA_STREAM for EFL build.
1635
1636         * Scripts/webkitperl/FeatureList.pm: 
1637
1638 2014-05-08  David Farler  <dfarler@apple.com>
1639
1640         old-run-webkit-tests: update strings for simulator devices and app name
1641         https://bugs.webkit.org/show_bug.cgi?id=132687
1642
1643         Reviewed by Darin Adler.
1644
1645         iPhone Retina (4-inch) -> iPhone 5
1646         iPhone Retina (4-inch 64-bit) -> iPhone 5s
1647
1648         * Scripts/old-run-webkit-tests:
1649         (installAndLaunchDumpToolAppUsingNotification):
1650         (openIPhoneSimulator):
1651         (quitIPhoneSimulator):
1652         quit iOS Simulator, not iPhone Simulator.
1653
1654 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1655
1656         REGRESSION(r168471): Update the builder names on the scheduler list.
1657         https://bugs.webkit.org/show_bug.cgi?id=132699
1658
1659         Reviewed by Martin Robinson.
1660
1661         On r168471 I missed to update the builder names for the GTK build
1662         bots on the AnyBranchScheduler type scheduler list of bots.
1663
1664         * BuildSlaveSupport/build.webkit.org-config/config.json:
1665
1666 2014-05-08  Brady Eidson  <beidson@apple.com>
1667
1668         "shouldKeepCurrentBackForwardListItemInList" API should pass clientInfo to the callback
1669         <rdar://problem/16855357> and https://bugs.webkit.org/show_bug.cgi?id=132692
1670
1671         Reviewed by Tim Horton.
1672
1673         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp:
1674         (TestWebKitAPI::shouldKeepCurrentBackForwardListItemInList):
1675
1676 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1677
1678         REGRESSION(r168471): Duplicate builddirs broke the build master.
1679         https://bugs.webkit.org/show_bug.cgi?id=132688
1680
1681         Reviewed by Carlos Garcia Campos.
1682
1683         Rename the builddirs of the new GTK bots introduced on r168471 to
1684         be unique. Otherwise the master will break.
1685
1686         * BuildSlaveSupport/build.webkit.org-config/config.json:
1687
1688 2014-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1689
1690         [GTK] webkitdom script assumes mkdir only fails because the directory already exists
1691         https://bugs.webkit.org/show_bug.cgi?id=132674
1692
1693         Reviewed by Philippe Normand.
1694
1695         Only ignore mkdir failure when exception is raised because the
1696         file already exists and it's a directory.
1697
1698         * gtk/webkitdom.py:
1699         (write_doc_files):
1700
1701 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1702
1703         [WK2][GTK] Split the 64-bit GTK buildbots in Build and Test.
1704         https://bugs.webkit.org/show_bug.cgi?id=131358
1705
1706         Reviewed by Carlos Garcia Campos.
1707
1708         Current 64-bit GTK build bots (Release and Debug) not only test
1709         the build, but run all tests. Split each one of the bots in
1710         BuildOnly and TestWebKit2.
1711
1712         This will allow us to have a better overview of the status of
1713         the GTK port.
1714
1715         Original patch from Sergio Villar Senin <svillar@igalia.com>
1716
1717         * BuildSlaveSupport/build.webkit.org-config/config.json:
1718         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1719         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1720         (WebKitBuildbot):
1721         * Scripts/webkitpy/port/builders.py:
1722         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1723         (TestRebaselineTest.test_baseline_directory):
1724         * TestResultServer/static-dashboards/builders.jsonp:
1725         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1726         (resetGlobals):
1727         * TestResultServer/static-dashboards/loader_unittests.js:
1728
1729 2014-05-07  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1730
1731         [CoordinatedGraphics][WK2] Scale factor and scroll position is not being restored properly in a back/forward load
1732         https://bugs.webkit.org/show_bug.cgi?id=126022
1733
1734         Reviewed by Benjamin Poulain.
1735
1736         Original author : Thiago de Barros Lacerda, and finished by Gyuyoung Kim.
1737
1738         Added an unit test case to check if scroll position and scale are restored properly.
1739
1740         * TestWebKitAPI/PlatformEfl.cmake:
1741         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp: Added.
1742         (TestWebKitAPI::didFinishLoadForFrame):
1743         (TestWebKitAPI::didChangeContentsPosition):
1744         (TestWebKitAPI::TEST):
1745         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward1.html: Added.
1746         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward2.html: Added.
1747
1748 2014-05-07  Simon Fraser  <simon.fraser@apple.com>
1749
1750         WebKit1 is flashy when compositing layers come and go
1751         https://bugs.webkit.org/show_bug.cgi?id=132655
1752         <rdar://problem/16830981&16788846>
1753
1754         Reviewed by Sam Weinig.
1755         
1756         Revert the change from r166117.
1757
1758         * DumpRenderTree/mac/DumpRenderTree.mm:
1759         (updateDisplay):
1760
1761 2014-05-07  Chris Fleizach  <cfleizach@apple.com>
1762
1763         AX: AXSelectTextWithCriteria should support capitalize/lowercase/uppercase
1764         https://bugs.webkit.org/show_bug.cgi?id=132622
1765
1766         Reviewed by Mario Sanchez Prada.
1767
1768         * DumpRenderTree/AccessibilityUIElement.cpp:
1769         (selectTextWithCriteriaCallback):
1770         (isEqualCallback):
1771         * DumpRenderTree/AccessibilityUIElement.h:
1772         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1773         (AccessibilityUIElement::selectTextWithCriteria):
1774         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1775         (AccessibilityUIElement::selectTextWithCriteria):
1776         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1777         (selectTextParameterizedAttributeForCriteria):
1778         (AccessibilityUIElement::selectTextWithCriteria):
1779         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1780         (AccessibilityUIElement::selectTextWithCriteria):
1781         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1782         (WTR::AccessibilityUIElement::selectTextWithCriteria):
1783         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1784         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1785         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1786         (WTR::AccessibilityUIElement::selectTextWithCriteria):
1787         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1788         (WTR::AccessibilityUIElement::selectTextWithCriteria):
1789         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1790         (WTR::selectTextParameterizedAttributeForCriteria):
1791         (WTR::AccessibilityUIElement::selectTextWithCriteria):
1792
1793 2014-05-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1794
1795         [SOUP] TLSErrors do not cause page load to fail when not ignored
1796         https://bugs.webkit.org/show_bug.cgi?id=121548
1797
1798         Reviewed by Sergio Villar Senin.
1799
1800         Add unit tests to check that the load fails with TLS errors in
1801         case of a redirection.
1802
1803         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1804         (testTLSErrorsRedirect):
1805         (httpsServerCallback):
1806         (beforeAll):
1807
1808 2014-05-07  Manuel Rego Casasnovas  <rego@igalia.com>
1809
1810         [CSS Grid Layout] Remove runtime feature
1811         https://bugs.webkit.org/show_bug.cgi?id=132382
1812
1813         Reviewed by Benjamin Poulain.
1814
1815         Remove cssGridLayoutEnabled setting usage.
1816
1817         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1818         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1819         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1820         (TestRunner::overridePreference):
1821         * DumpRenderTree/mac/DumpRenderTree.mm:
1822         (resetWebPreferencesToConsistentValues):
1823
1824 2014-05-06  David Kilzer  <ddkilzer@apple.com>
1825
1826         Add Makefile targets for copying static libraries (LLVM and WKSI)
1827         <http://webkit.org/b/132619>
1828
1829         Reviewed by Mark Rowe.
1830
1831         * Scripts/copy-webkitlibraries-to-product-directory: Set a
1832         sensible default for product directory if not specified on
1833         either the command-line or in the environment (by Xcode) by
1834         calling productDir() in webkitdirs.pm.
1835
1836 2014-05-06  Brady Eidson  <beidson@apple.com>
1837
1838         Add WK2 SPI to prevent the previous back/forward item from remaining in the list
1839         <rdar://problem/16248710> and https://bugs.webkit.org/show_bug.cgi?id=132636
1840
1841         Reviewed by Sam Weinig.
1842
1843         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1844
1845         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp: Added.
1846         (TestWebKitAPI::itemURLLastComponentIsString):
1847         (TestWebKitAPI::didFinishLoadForFrame):
1848         (TestWebKitAPI::willGoToBackForwardListItem):
1849         (TestWebKitAPI::shouldKeepCurrentBackForwardListItemInList):
1850         (TestWebKitAPI::setPageLoaderClient):
1851         (TestWebKitAPI::TEST):
1852         * TestWebKitAPI/Tests/WebKit2/simple2.html: Added.
1853         * TestWebKitAPI/Tests/WebKit2/simple3.html: Added.
1854
1855         * WebKitTestRunner/TestController.cpp:
1856         (WTR::TestController::createWebViewWithOptions): Update for new client layout.
1857
1858 2014-05-06  Darin Adler  <darin@apple.com>
1859
1860         Try to fix iOS build.
1861
1862         * DumpRenderTree/mac/TestRunnerMac.mm:
1863         (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]):
1864         Updated since I changed testRunner into a pointer instead of a reference.
1865         Updated argument names to avoid conflict with field names.
1866         (-[APITestDelegateIPhone run]): Ditto.
1867         (-[APITestDelegateIPhone _cleanUp]): Ditto.
1868
1869 2014-05-06  Commit Queue  <commit-queue@webkit.org>
1870
1871         Unreviewed, rolling out r168304.
1872         https://bugs.webkit.org/show_bug.cgi?id=132607
1873
1874         Broke the build (Requested by KaL on #webkit).
1875
1876         Reverted changeset:
1877
1878         "[GTK][CMake] Unable to do make install"
1879         https://bugs.webkit.org/show_bug.cgi?id=130188
1880         http://trac.webkit.org/changeset/168304
1881
1882 2014-05-04  Darin Adler  <darin@apple.com>
1883
1884         RetainPtr: Use adoptCF function instead of AdoptCF constructor argument
1885         https://bugs.webkit.org/show_bug.cgi?id=80222
1886
1887         Reviewed by Alexey Proskuryakov.
1888
1889         * DumpRenderTree/mac/TestRunnerMac.mm:
1890         (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]): Updated to
1891         do more work here so we don't use RetainPtr local variables.
1892         (-[APITestDelegateIPhone dealloc]): Added.
1893         (-[APITestDelegateIPhone run]): Added an early exit if the web view is already
1894         created. Updated for changes to member names and types.
1895         (-[APITestDelegateIPhone _cleanUp]): Added code to set webView to nil and
1896         updated for changes to member names and types. Changed to two word spelling.
1897         (-[APITestDelegateIPhone webView:didFailLoadWithError:forFrame:]): Updated
1898         name of _cleanUp method.
1899         (-[APITestDelegateIPhone webView:didFailProvisionalLoadWithError:forFrame:]):
1900         Ditto.
1901         (-[APITestDelegateIPhone webView:didFinishLoadForFrame:]): Ditto.
1902
1903 2014-05-05  Benjamin Poulain  <benjamin@webkit.org>
1904
1905         Clean up Image Document and tweak the layout and viewport
1906         https://bugs.webkit.org/show_bug.cgi?id=132552
1907
1908         Reviewed by Anders Carlsson.
1909
1910         * DumpRenderTree/mac/DumpRenderTree.mm:
1911         (resetWebPreferencesToConsistentValues):
1912         Update the default settings to have something consistent with WebKit2.
1913
1914 2014-05-05  Martin Robinson  <mrobinson@igalia.com>
1915
1916         [GTK][CMake] Unable to do make install
1917         https://bugs.webkit.org/show_bug.cgi?id=130188
1918
1919         Reviewed by Carlos Garcia Campos.
1920
1921         * Scripts/webkitdirs.pm:
1922         (buildCMakeGeneratedProject): Always build gtkdoc-no-html for WebKitGTK+. This
1923         will give an early signal that a change has broken the documentation.
1924
1925 2014-05-05  Pratik Solanki  <psolanki@apple.com>
1926
1927         Update framework locations in package-root
1928         https://bugs.webkit.org/show_bug.cgi?id=132571
1929
1930         Reviewed by Simon Fraser.
1931
1932         * Scripts/package-root:
1933
1934 2014-05-05  Ryuan Choi  <ryuan.choi@samsung.com>
1935
1936         [EFL][WK2] Refactor favicon database APIs
1937         https://bugs.webkit.org/show_bug.cgi?id=132519
1938
1939         Reviewed by Gyuyoung Kim.
1940
1941         * MiniBrowser/efl/main.c: Use ewk_favicon_database_icon_get instead of ewk_view_favicon_get.
1942         (update_view_favicon):
1943         (on_icon_changed_cb):
1944         (window_free):
1945         (on_url_changed):
1946         (window_create):
1947         (on_view_favicon_changed): Deleted.
1948
1949 2014-05-02  Mark Rowe  <mrowe@apple.com>
1950
1951         <https://webkit.org/b/132505> Make it possible to tell copy-webkitlibraries-to-product-directory which OS X version to copy for
1952
1953         Reviewed by Dan Bernstein.
1954
1955         * Scripts/copy-webkitlibraries-to-product-directory: Add an --osx-version argument and use the passed value
1956         when determining which LLVM archive to extract.
1957
1958 2014-05-02  Jeremy Jones  <jeremyj@apple.com>
1959
1960         Add Jeremy as a committer.
1961         https://bugs.webkit.org/show_bug.cgi?id=132492
1962
1963         Reviewed by Jer Noble.
1964
1965         Add myself as a committer.
1966
1967         * Scripts/webkitpy/common/config/contributors.json:
1968
1969 2014-05-02  Jeremy Jones  <jeremyj@apple.com>
1970
1971         Add Jeremy as a committer.
1972         https://bugs.webkit.org/show_bug.cgi?id=132492
1973
1974         Reviewed by Jer Noble.
1975
1976         Add Jeremy Jones to the committers file.
1977
1978         * Scripts/webkitpy/common/config/contributors.json:
1979
1980 2014-05-02  Brian J. Burg  <burg@cs.washington.edu>
1981
1982         Hard to figure out how to run a single test with run-api-tests
1983         https://bugs.webkit.org/show_bug.cgi?id=116332
1984
1985         Reviewed by Alexey Proskuryakov.
1986
1987         * Scripts/run-api-tests: add two examples to the help message.
1988
1989 2014-05-02  Simon Fraser  <simon.fraser@apple.com>
1990
1991         Fix several memory leaks found by code inspection
1992         https://bugs.webkit.org/show_bug.cgi?id=132472
1993
1994         Reviewed by Geoffrey Garen.
1995         
1996         Fix memory leaks.
1997
1998         * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:
1999         (TestWebKitAPI::TEST):
2000         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2001         (WTR::InjectedBundlePage::willSendRequestForFrame):
2002         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2003         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
2004
2005 2014-05-02  Filip Pizlo  <fpizlo@apple.com>
2006
2007         DFGAbstractInterpreter should not claim Int52 arithmetic creates Int52s
2008         https://bugs.webkit.org/show_bug.cgi?id=132446
2009
2010         Reviewed by Mark Hahnenberg.
2011         
2012         Test the FTL by default now that it's enabled by default.
2013
2014         * Scripts/run-javascriptcore-tests:
2015
2016 2014-05-01  Ryuan Choi  <ryuan.choi@samsung.com>
2017
2018         [EFL][WK1] Drop ewk_view_setting_tiled_backingstore APIs
2019         https://bugs.webkit.org/show_bug.cgi?id=132240
2020
2021         Reviewed by Anders Carlsson.
2022
2023         Removed ewk_view_setting_tiled_backingstore related code.
2024
2025         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2026         (DumpRenderTreeChrome::createView):
2027         (shouldUseTiledBackingStore): Deleted.
2028         * EWebLauncher/main.c:
2029         (windowCreate):
2030         (parseUserArguments):
2031
2032 2014-05-01  Anders Carlsson  <andersca@apple.com>
2033
2034         window.testRunner.keepWebHistory() should update the UI process state
2035         https://bugs.webkit.org/show_bug.cgi?id=132440
2036
2037         Reviewed by Dan Bernstein.
2038
2039         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2040         (WTR::InjectedBundle::postSetAddsVisitedLinks):
2041         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2042         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2043         (WTR::TestRunner::keepWebHistory):
2044         * WebKitTestRunner/TestInvocation.cpp:
2045         (WTR::TestInvocation::invoke):
2046         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2047
2048 2014-05-01  David Kilzer  <ddkilzer@apple.com>
2049
2050         Really remove ENABLE_PLUGIN_PROXY_FOR_VIDEO
2051         <http://webkit.org/b/132432>
2052
2053         Reviewed by Tim Horton.
2054
2055         * Scripts/webkitperl/FeatureList.pm: Remove support for
2056         --plugin-proxy-for-video switch.
2057
2058 2014-04-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2059
2060         Kernel sysctl interface hw.activecpu don't exists on Linux.
2061         https://bugs.webkit.org/show_bug.cgi?id=132286
2062
2063         Reviewed by Filip Pizlo.
2064
2065         * Scripts/run-jsc-stress-tests: Redirect stderr to null when
2066         calling sysctl over hw.activecpu
2067
2068 2014-04-30  Anders Carlsson  <andersca@apple.com>
2069
2070         Move the legacy WebKit API into WebKitLegacy.framework and move it inside WebKit.framework
2071         https://bugs.webkit.org/show_bug.cgi?id=132399
2072         <rdar://problem/15920046>
2073
2074         Reviewed by Dan Bernstein.
2075
2076         * Scripts/check-for-webkit-framework-include-consistency:
2077         Allos WAK headers in WebKitLegacy as well as WebKit.
2078
2079         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2080         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2081         Update header imports.
2082
2083 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
2084
2085         [iOS WK2] Add test URL to crash reports for the UI process, clean up project
2086         https://bugs.webkit.org/show_bug.cgi?id=131954
2087
2088         Reviewed by Darin Adler.
2089         
2090         WebKitTestRunner was adding application-specific information to crash reports
2091         to log the test path, but only in the web process. Fix it to also do this
2092         for the UI process, for both iOS and OS X.
2093         
2094         Moved InjectedBundlePageMac.mm to InjectedBundlePageCocoa.mm and compile it for
2095         both iOS and OS X.
2096         
2097         Factored crash reprorter-related code into CrashReporterInfo, and call it from
2098         a new TestController::platformWillRunTest() function on Mac and iOS.
2099         
2100         Also remove Xcode-added unit test junk from the project.
2101
2102         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
2103         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
2104         * WebKitTestRunner/TestController.cpp:
2105         (WTR::TestController::runTest):
2106         * WebKitTestRunner/TestController.h:
2107         * WebKitTestRunner/TestInvocation.cpp:
2108         (WTR::TestInvocation::url):
2109         * WebKitTestRunner/TestInvocation.h:
2110         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2111         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests-Info.plist: Removed.
2112         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests.m: Removed.
2113         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj/InfoPlist.strings: Removed.
2114         * WebKitTestRunner/cocoa/CrashReporterInfo.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
2115         * WebKitTestRunner/cocoa/CrashReporterInfo.mm: Renamed from Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm.
2116         (WTR::testPathFromURL):
2117         (WTR::setCrashReportApplicationSpecificInformationToURL):
2118         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2119         (WTR::TestController::platformWillRunTest):
2120         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2121         (WTR::TestController::platformWillRunTest):
2122         * WebKitTestRunner/ios/TestControllerIOS.mm:
2123         (WTR::TestController::platformWillRunTest):
2124         (WTR::TestController::setHidden):
2125         * WebKitTestRunner/mac/TestControllerMac.mm:
2126         (WTR::TestController::platformWillRunTest):
2127
2128 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
2129
2130         Fix DRT assertion about mock scrollbars, which doesn't apply to iOS.
2131
2132         Reviewed by Tim Horton.
2133
2134         * DumpRenderTree/mac/DumpRenderTree.mm:
2135         (resetWebPreferencesToConsistentValues):
2136         (prepareConsistentTestingEnvironment):
2137
2138 2014-04-30  Anders Carlsson  <andersca@apple.com>
2139
2140         check-for-inappropriate-macros-in-external-headers should get the product name, not the project name
2141         https://bugs.webkit.org/show_bug.cgi?id=132397
2142
2143         Reviewed by Dan Bernstein.
2144
2145         * Scripts/check-for-inappropriate-macros-in-external-headers:
2146
2147 2014-04-29  Martin Robinson  <mrobinson@igalia.com>
2148
2149         [GTK] Make it easier to run CMake for downstreams
2150         https://bugs.webkit.org/show_bug.cgi?id=132370
2151
2152         Reviewed by Carlos Garcia Campos.
2153
2154         * Scripts/webkitdirs.pm:
2155         (generateBuildSystemFromCMakeProject): Pass -DDEVELOPER_MODE when building
2156         the GTK+ port.
2157
2158 2014-04-29  Stephanie Lewis  <slewis@apple.com>
2159
2160         <rdar://problem/16765765> Use JSON::PP in perl scripts instead of JSON.
2161         
2162         Rubber stamped by Jessie Berlin.
2163
2164         JSON.pm was removed from our tools setup.
2165
2166         * Scripts/generate-coverage-data:
2167
2168 2014-04-29  Filip Pizlo  <fpizlo@apple.com>
2169
2170         Use LLVM as a backend for the fourth-tier DFG JIT (a.k.a. the FTL JIT)
2171         https://bugs.webkit.org/show_bug.cgi?id=112840
2172
2173         Rubber stamped by Geoffrey Garen.
2174
2175         * Scripts/build-jsc: Enable it on Mac.
2176         * Scripts/build-webkit: Enable it on Mac.
2177         * Scripts/export-llvm-build: Make it slightly easier to export the build if you've done a "make install".
2178
2179 2014-04-28  Sam Weinig  <sam@webkit.org>
2180
2181         REGRESSION (r167751): svn-create-patch is very slow
2182         https://bugs.webkit.org/show_bug.cgi?id=132300
2183
2184         Reviewed by Alexey Proskuryakov.
2185
2186         * Scripts/svn-create-patch:
2187         Change default behavior of svn-create-patch to no longer run the style checker. It can still be run
2188         by calling `svn-create-patch --style`.
2189
2190 2014-04-29  Enrique Ocaña González  <eocanha@igalia.com>
2191
2192         Generate Eclipse project + ninja build for GTK+ if Eclipse in available in the PATH
2193         https://bugs.webkit.org/show_bug.cgi?id=132190
2194
2195         Reviewed by Gustavo Noronha Silva.
2196
2197         * Scripts/webkitdirs.pm:
2198         (canUseEclipse): Test if Eclipse is in the path. This is the same method used to test
2199             if ninja is in the path.
2200         (generateBuildSystemFromCMakeProject): Use the eclipse generator if possible, fallback
2201             to the previous ninja generator if not.
2202
2203 2014-04-29  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
2204
2205         check-webkit-style should understand --git-index
2206         https://bugs.webkit.org/show_bug.cgi?id=125364
2207
2208         Reviewed by Csaba Osztrogonác.
2209
2210         * Scripts/webkitpy/common/checkout/scm/git.py:
2211         (Git.create_patch): The command now supports the --cached option.
2212         * Scripts/webkitpy/style/main.py:
2213         (CheckWebKitStyle.main): Passing the --git-index option.
2214         * Scripts/webkitpy/style/optparser.py:
2215         (CommandOptionValues.__init__): The git-index option is switched off by default.
2216         (CommandOptionValues.__eq__): Equality check for the new option.
2217         (ArgumentParser._create_option_parser):Adding the --git-index option
2218         (ArgumentParser.parse):
2219         * Scripts/webkitpy/style/optparser_unittest.py: New tests for the --git-index option
2220         (CommandOptionValuesTest.test_init): 
2221         (CommandOptionValuesTest.test_eq):
2222
2223 2014-04-28  Michael Saboff  <msaboff@apple.com>
2224
2225         Crash in platform/mac/accessibility/table-visible-rows.html
2226         https://bugs.webkit.org/show_bug.cgi?id=132146
2227
2228         Reviewed by Filip Pizlo.
2229
2230         Instead of creating a local JSValueRef array on the stack and passing that to
2231         JSObjectMakeArray(), changed to create an empty JSArray and then populate the
2232         values using the JSObjectSetPropertyAtIndex() API.
2233
2234         * DumpRenderTree/AccessibilityUIElement.cpp:
2235         (elementsForRangeCallback):
2236         (convertElementsToObjectArray):
2237         * DumpRenderTree/mac/TestRunnerMac.mm:
2238         (originsArrayToJS):
2239         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2240         (WTR::EventSendingController::contextClick):
2241         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2242         (WTR::stringArrayToJS):
2243         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2244         (WTR::convertElementsToObjectArray):
2245
2246 2014-04-28  Filip Pizlo  <fpizlo@apple.com>
2247
2248         Make sure that the coverage of our tests doesn't change much if we change the thresholds now and in the future, but making
2249         "no-cjit" runs force the old-school threshold.
2250
2251         Rubber stamped by Mark Hahnenberg.
2252
2253         * Scripts/run-jsc-stress-tests:
2254
2255 2014-04-28  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2256
2257         [GTK] install-dependencies should also install ruby-json and ruby-highline
2258         https://bugs.webkit.org/show_bug.cgi?id=132292
2259
2260         Reviewed by Philippe Normand.
2261
2262         * gtk/install-dependencies: Install ruby json and highline packages.
2263
2264 2014-04-27  Joonghun Park  <jh718.park@samsung.com>
2265
2266         [EFL] Remove indexedDB's dependency on leveldb and disable indexedDB
2267         https://bugs.webkit.org/show_bug.cgi?id=132176
2268
2269         Reviewed by Gyuyoung Kim.
2270
2271         EFL port will use sqlite to support indexedDB. So, this patch removes levelDB dependency
2272         and turn off indexedDB feature until the sqlite implementation is introduced.
2273
2274         * Scripts/webkitperl/FeatureList.pm:
2275
2276 2014-04-25  James Craig  <jcraig@apple.com>
2277
2278         Set prepare-Changelog flag so that it no longer runs check-webkit-style by default
2279         https://bugs.webkit.org/show_bug.cgi?id=132209
2280
2281         Reviewed by Daniel Bates.
2282
2283         Set default to --no-style to avoid additional spew from false positives in check-webkit-style.
2284         Run check-webkit-style before generating changelogs to avoid additional spurious errors.
2285
2286         * Scripts/prepare-ChangeLog:
2287         (main): 
2288
2289 2014-04-25  Michael Saboff  <msaboff@apple.com>
2290
2291         Crash in platform/mac/accessibility/table-visible-rows.html
2292         https://bugs.webkit.org/show_bug.cgi?id=132146
2293
2294         Reviewed by Mark Lam.
2295
2296         Changed to use a local JSValueRef array temporary instead of a
2297         std::make_unique<JSValueRef[]> when making an array of JSValues so that the temporary
2298         JSValues are visited during garbage collection when the stack is scanned.  Otherwise,
2299         the temporary values could be collected.
2300
2301         * DumpRenderTree/AccessibilityUIElement.cpp:
2302         (convertElementsToObjectArray):
2303         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2304         (WTR::EventSendingController::contextClick):
2305         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2306         (WTR::convertElementsToObjectArray):
2307
2308 2014-04-24  Eduardo Lima Mitev  <elima@igalia.com>
2309
2310         Unreviewed GTK gardening
2311
2312         * Scripts/run-gtk-tests: Skips one flaky accesibility test in WK2API suite
2313         (TestRunner):
2314
2315 2014-04-24  László Langó  <llango.u-szeged@partner.samsung.com>
2316
2317         prepare-ChangeLog reports as deleted methods that has not been removed.
2318         https://bugs.webkit.org/show_bug.cgi?id=131733
2319
2320         Reviewed by Ryosuke Niwa.
2321
2322         * Scripts/prepare-ChangeLog:
2323         (originalFile): Set merge base to origin/master by default.
2324
2325 2014-04-23  James Craig  <jcraig@apple.com>
2326
2327         prepare-Changelog and svn-create-patch should optionally run check-webkit-style.
2328         https://bugs.webkit.org/show_bug.cgi?id=131115
2329
2330         Reviewed by Daniel Bates.
2331
2332         Added [--[no-]style] param to run check-webkit-style as part of prepare-Changelog and svn-create-patch.
2333
2334         * Scripts/commit-log-editor: Added --no-style.
2335         * Scripts/prepare-ChangeLog: Primary patch.
2336         (main): Primary patch.
2337         (createPatchCommand): Added --no-style.
2338         * Scripts/svn-create-patch: Primary patch.
2339         * Scripts/webkit-tools-completion.sh: Added --style and --no-style.
2340         * Scripts/webkitpy/common/checkout/scm/svn.py: Added --no-style.
2341         (SVN.create_patch): Added --no-style.
2342
2343 2014-04-23  Anders Carlsson  <andersca@apple.com>
2344
2345         Try to fix iOS build.
2346
2347         * DumpRenderTree/mac/DumpRenderTree.mm:
2348
2349 2014-04-23  Alexey Proskuryakov  <ap@apple.com>
2350
2351         Eliminate internals.setMockScrollbarsEnabled()
2352         https://bugs.webkit.org/show_bug.cgi?id=132085
2353
2354         Reviewed by Tim Horton.
2355
2356         * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues):
2357         No need to reset the preference, there is no way it can change.
2358
2359 2014-04-23  James Craig  <jcraig@apple.com>
2360
2361         Unreviewed. Moving myself from Contributors to Committers list.
2362
2363         * Scripts/webkitpy/common/config/contributors.json:
2364
2365 2014-04-23  Tim Horton  <timothy_horton@apple.com>
2366
2367         Mock scrollbars don't always work in DumpRenderTree
2368         https://bugs.webkit.org/show_bug.cgi?id=132082
2369
2370         Reviewed by Alexey Proskuryakov.
2371
2372         * DumpRenderTree/mac/DumpRenderTree.mm:
2373         (prepareConsistentTestingEnvironment):
2374         Set the mock scrollbar setting before creating the WebView, as this setting
2375         cannot be dynamically changed, so any scrollbars that are created during
2376         WebView initialization and are not replaced before snapshotting will end
2377         up being platform scrollbars instead of mock ones.
2378         WebKitTestRunner already sets this preference before creating WKViews,
2379         so we're just matching its behavior.
2380
2381 2014-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2382
2383         [GTK] ShadowRoot API was removed in r164131
2384         https://bugs.webkit.org/show_bug.cgi?id=132059
2385
2386         Reviewed by Gustavo Noronha Silva.
2387
2388         Add WebKitDOMShadowRoot to the list of deleted classes to generate
2389         the API docs.
2390
2391         * gtk/webkitdom.py:
2392         (WebKitDOMDocGenerator):
2393
2394 2014-04-23  Lorenzo Tilve  <ltilve@igalia.com>
2395
2396         [GTK] run-webkit-tests script is failing to invoke run-launcher
2397         https://bugs.webkit.org/show_bug.cgi?id=132051
2398
2399         Reviewed by Philippe Normand.
2400
2401         After the WK1 support was dropped, if run-webkit-tests is executed
2402         without --no-show-results parameter, the launcher is being called
2403         using a -2 parameter that is it causing the run-launcher to break.
2404
2405         * Scripts/webkitpy/port/gtk.py:
2406         (GtkPort.show_results_html_file):
2407
2408 2014-04-22  Tim Horton  <timothy_horton@apple.com>
2409
2410         DumpRenderTree generates black snapshots on some platforms
2411         https://bugs.webkit.org/show_bug.cgi?id=132029
2412         <rdar://problem/16679363>
2413
2414         Reviewed by Simon Fraser.
2415
2416         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2417         (createBitmapContextFromWebView):
2418         DRT checks with the WebView to determine whether it can use the window's
2419         backing store directly or (because of compositing) needs to take a WindowServer
2420         snapshot. However, on some platforms and in some situations, the window can
2421         be layer backed without the WebView necessarily currently being composited.
2422         We should check with the window in addition to the WebView before going
2423         ahead and using its backing store.
2424
2425 2014-04-22  Tim Horton  <timothy_horton@apple.com>
2426
2427         DumpRenderTree generates white snapshots on some platforms
2428         https://bugs.webkit.org/show_bug.cgi?id=132026
2429         <rdar://problem/16679363>
2430
2431         Reviewed by Simon Fraser.
2432
2433         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2434         Link DRT against QuartzCore.
2435
2436         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2437         (createBitmapContextFromWebView):
2438         Force CoreAnimation to synchronously update layers in a more explicit
2439         way that doesn't depend on AppKit behavior. This is very similar to what
2440         WebKitTestRunner does (indirectly) during its force repaint.
2441
2442 2014-04-22  Brent Fulgham  <bfulgham@apple.com>
2443
2444         [Win] Support Python 2.7 in Cygwin
2445         https://bugs.webkit.org/show_bug.cgi?id=132023
2446
2447         Reviewed by Michael Saboff.
2448
2449         * Scripts/webkitdirs.pm:
2450         (checkInstalledTools): Remove check for Python 2.7, since
2451         it now works properly.
2452
2453 2014-04-22  Filip Pizlo  <fpizlo@apple.com>
2454
2455         Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
2456         https://bugs.webkit.org/show_bug.cgi?id=130867
2457         <rdar://problem/16432456> 
2458
2459         Reviewed by Mark Hahnenberg.
2460
2461         * Scripts/build-webkit:
2462         * Scripts/copy-webkitlibraries-to-product-directory:
2463
2464 2014-04-22  Gustavo Noronha Silva  <gns@gnome.org>
2465
2466         [GTK] Fails to build documentation when output is redirected
2467         https://bugs.webkit.org/show_bug.cgi?id=131178
2468
2469         Reviewed by Martin Robinson.
2470
2471         * gtk/generate-gtkdoc: set the output for stdout and stderr to UTF-8
2472         explicitly to avoid encoding issues when they are redirected.
2473
2474 2014-04-22  ChangSeok Oh  <changseok.oh@collabora.com>
2475
2476         [GTK] YCM choose a newer compile_commands.json in between Release or Debug
2477         https://bugs.webkit.org/show_bug.cgi?id=131911
2478
2479         Reviewed by Martin Robinson.
2480
2481         common.get_build_path returns release path even though Debug configuration
2482         is newer than Release. So YouCompleteMe is used to refer old build setup inadvertently.
2483
2484         * gtk/ycm_extra_conf.py:
2485         (get_build_path): Compare modified time of Release and Debug. And return a recent modified path.
2486         (FlagsForFile):
2487
2488 2014-04-21  Brent Fulgham  <bfulgham@apple.com>
2489
2490         Unreviewed build fix.
2491
2492         * DumpRenderTree/mac/EventSendingController.mm:
2493         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
2494         Correct a typo that prevented tests from working properly.
2495
2496 2014-04-21  Martin Robinson  <mrobinson@igalia.com>
2497
2498         [GTK] Should have the ability to output composited contents during layout testing
2499         https://bugs.webkit.org/show_bug.cgi?id=131864
2500
2501         Reviewed by Philippe Normand.
2502
2503         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2504         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Add a path that paints the widget contents
2505         to an image surface. We run the main loop a bit to match the implementation from WebKit1 and EFL.
2506         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2507         (WTR::PlatformWebView::windowSnapshotImage): Use the new UI-process path on GTK+.
2508
2509 2014-04-21  Sam Weinig  <sam@webkit.org>
2510
2511         Attempt to fix the tests.
2512
2513         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2514         (-[DidFailProvisionalNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2515         Add policy handler to override the new default of denying loads that NSURLConnection cannot handle.
2516
2517 2014-04-21  Filip Pizlo  <fpizlo@apple.com>
2518
2519         Unreviewed test gardening, make no-eager runs run everything except eager (as opposed to
2520         being the same as a "quick run", which is meant for genuinely slow tests).
2521
2522         * Scripts/run-jsc-stress-tests:
2523
2524 2014-04-21  Darin Adler  <darin@apple.com>
2525
2526         Add HashSet::takeAny
2527         https://bugs.webkit.org/show_bug.cgi?id=131928
2528
2529         Reviewed by Benjamin Poulain.
2530
2531         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Added a test for takeAny.
2532
2533 2014-04-20  Dan Bernstein  <mitz@apple.com>
2534
2535         Fixed a test timing out after r167572.
2536
2537         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2538         (-[NavigationDelegate webView:didFinishNavigation:]): Renamed from
2539         -webView:didFinishLoadingNavigation:.
2540
2541 2014-04-20  Commit Queue  <commit-queue@webkit.org>
2542
2543         Unreviewed, rolling out r167510.
2544         https://bugs.webkit.org/show_bug.cgi?id=131915
2545
2546         broke GTK Debug bot (Requested by philn on #webkit).
2547
2548         Reverted changeset:
2549
2550         "[GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force
2551         it when running layout tests"
2552         https://bugs.webkit.org/show_bug.cgi?id=131472
2553         http://trac.webkit.org/changeset/167510
2554
2555 2014-04-18  Martin Robinson  <mrobinson@igalia.com>
2556
2557         [GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force it when running layout tests
2558         https://bugs.webkit.org/show_bug.cgi?id=131472
2559
2560         Reviewed by Philippe Normand.
2561
2562         * Scripts/webkitpy/port/gtk.py:
2563         (GtkPort.setup_environ_for_server): Use the LLVMPIPE_LIBGL_PATH to set the LD_LIBRARY_PATH
2564         when running WebKitTestRunner with run-webkit-tests.
2565         * gtk/jhbuild.modules: Add Mesa to the modulelist so that the llvmpipe libGL is build, but not
2566         installed.
2567         * gtk/jhbuildrc: Set the LLVMPIPE_LIBGL_PATH environment variable so that the test driver knows
2568         how to properly set the LD_LIBRARY_PATH variable. We do this because it is much easier to
2569         calculate the path in the jhbuildrc than in the test driver code. This simplifies things a great
2570         deal.
2571
2572 2014-04-18  Alexey Proskuryakov  <ap@apple.com>
2573
2574         DownloadDecideDestinationCrash API test uses an incorrect value for path
2575         https://bugs.webkit.org/show_bug.cgi?id=131845
2576         <rdar://problem/15925560>
2577
2578         Reviewed by Enrica Casucci.
2579
2580         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
2581         (TestWebKitAPI::decideDestinationWithSuggestedFilename):
2582
2583 2014-04-17  Alexey Proskuryakov  <ap@apple.com>
2584
2585         [Mac] AttributedStringTest API tests fail with async text input
2586         https://bugs.webkit.org/show_bug.cgi?id=131833
2587
2588         Reviewed by Enrica Casucci.
2589
2590         Don't run sync NSTextInputClient tests where we don't implement these calls.
2591
2592         * TestWebKitAPI/Tests/mac/AttributedString.mm:
2593         (TestWebKitAPI::AttributedStringTest_CustomFont::didLoadURL):
2594         (TestWebKitAPI::AttributedStringTest_CustomFont::runSyncTest):
2595         (TestWebKitAPI::AttributedStringTest_Strikethrough::didLoadURL):
2596         (TestWebKitAPI::AttributedStringTest_Strikethrough::runSyncTest):
2597         (TestWebKitAPI::AttributedStringTest_CustomFont::runTest): Deleted.
2598         (TestWebKitAPI::AttributedStringTest_Strikethrough::runTest): Deleted.
2599
2600 2014-04-18  Philippe Normand  <pnormand@igalia.com>
2601
2602         Remove NETWORK_INFO support
2603         https://bugs.webkit.org/show_bug.cgi?id=131841
2604
2605         Reviewed by Gyuyoung Kim.
2606
2607         * Scripts/webkitperl/FeatureList.pm:
2608
2609 2014-04-17  ChangSeok Oh  <changseok.oh@collabora.com>
2610
2611         [GTK] YouCompleteMe doesn't work for cmake build system.
2612         https://bugs.webkit.org/show_bug.cgi?id=131591
2613
2614         Reviewed by Martin Robinson.
2615
2616         Add cmake build system support for YouCompleteMe. It should work regardless of
2617         using make or ninja. In addition, autotools related code is removed since it's
2618         not used anymore in WebKit.
2619
2620         * Scripts/webkitdirs.pm:
2621         (generateBuildSystemFromCMakeProject):
2622         * gtk/ycm_extra_conf.py:
2623         (transform_relative_paths_to_absolute_paths):
2624         (FlagsForFile):
2625
2626 2014-04-17  Anders Carlsson  <andersca@apple.com>
2627
2628         Fix build.
2629
2630         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2631         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2632         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2633
2634 2014-04-17  Anders Carlsson  <andersca@apple.com>
2635
2636         Remove unused API enums
2637         https://bugs.webkit.org/show_bug.cgi?id=131836
2638
2639         Reviewed by Tim Horton.
2640
2641         * MiniBrowser/mac/WK2BrowserWindowController.m:
2642         (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
2643
2644 2014-04-16  Brent Fulgham  <bfulgham@apple.com>
2645
2646         [Win] A few final cleanups to the DataObject classes.
2647         https://bugs.webkit.org/show_bug.cgi?id=131784
2648
2649         Reviewed by Anders Carlsson.
2650
2651         * DumpRenderTree/win/DRTDataObject.cpp:
2652         (DRTDataObject::clearData): Use 'last()' method.
2653         * DumpRenderTree/win/UIDelegate.cpp:
2654         (DRTUndoStack::pop): Use 'takeLast()' method.
2655
2656 2014-04-17  Andres Gomez  <agomez@igalia.com>
2657
2658         [Win] cygwin to keep installing curl 7.33.0-1 and subversion 1.7.14-1
2659         https://bugs.webkit.org/show_bug.cgi?id=131365
2660
2661         Reviewed by Brent Fulgham.
2662
2663         The cygwin installer is now downloading the wanted versions for
2664         the local installation given to the setup wizard.
2665
2666         * CygwinDownloader/cygwin-downloader.py:
2667         * CygwinDownloader/cygwin-downloader.zip:
2668
2669 2014-04-17  Adrian Perez de Castro  <aperez@igalia.com>
2670
2671         [GTK] Make run-webkit-tests always use WKTR
2672         https://bugs.webkit.org/show_bug.cgi?id=131737
2673
2674         Reviewed by Darin Adler.
2675
2676         Now that the GTK+ port only has support for WebKit2, instruct
2677         run-webkit-tests to always use WKTR. This avoids needing to pass
2678         flag "-2" every time.
2679
2680         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 
2681         (_set_up_derived_options): Always set webkit_test_runner when
2682         the platform is GTK+.
2683
2684 2014-04-17  Brendan Long  <b.long@cablelabs.com>
2685
2686         [Gtk] Install ninja-build in Tools/gtk/install-dependencies
2687         https://bugs.webkit.org/show_bug.cgi?id=131760
2688
2689         Reviewed by Philippe Normand.
2690
2691         * gtk/install-dependencies: Install ninja-build when it's available.
2692
2693 2014-04-16  peavo@outlook.com  <peavo@outlook.com>
2694
2695         [Win] run-javascriptcore-tests fails to run.
2696         https://bugs.webkit.org/show_bug.cgi?id=131761
2697
2698         Reviewed by Brent Fulgham.
2699
2700         * Scripts/build-jsc: For now, don't try to build bmalloc on Windows.
2701
2702 2014-04-16  Andres Gomez  <agomez@igalia.com>
2703
2704         [Win] Pass default parameters to cygwin setup wizard
2705         https://bugs.webkit.org/show_bug.cgi?id=131361
2706
2707         Reviewed by Brent Fulgham.
2708
2709         Added some parameters to the cygwin setup wizard so the user
2710         doesn't really have to do any interaction.
2711
2712         * CygwinDownloader/cygwin-downloader.py:
2713         * CygwinDownloader/cygwin-downloader.zip:
2714
2715 2014-04-15  Brent Fulgham  <bfulgham@apple.com>
2716
2717         [Win] Eliminate use of deleteAllValues in Windows Files
2718         https://bugs.webkit.org/show_bug.cgi?id=131631
2719
2720         Reviewed by Darin Adler.
2721
2722         Switch to std::unique_ptr for memory lifetime. Get rid of
2723         deleteAllValues now that it is no longer needed. Use ranged
2724         for loops where possible.
2725
2726         * DumpRenderTree/win/DRTDataObject.cpp:
2727         (WCEnumFormatEtc::WCEnumFormatEtc):
2728         (DRTDataObject::~DRTDataObject):
2729         (DRTDataObject::GetData):
2730         (DRTDataObject::QueryGetData):
2731         (DRTDataObject::SetData):
2732         (DRTDataObject::clearData):
2733         * DumpRenderTree/win/DRTDataObject.h:
2734         * DumpRenderTree/win/UIDelegate.cpp:
2735         (DRTUndoObject::DRTUndoObject):
2736         (DRTUndoObject::~DRTUndoObject):
2737         (DRTUndoStack::~DRTUndoStack):
2738         (DRTUndoStack::clear):
2739         (DRTUndoStack::pop):
2740         (DRTUndoManager::DRTUndoManager):
2741         (DRTUndoManager::redo):
2742         (DRTUndoManager::undo):
2743         (UIDelegate::UIDelegate):
2744         (UIDelegate::resetUndoManager):
2745         * DumpRenderTree/win/UIDelegate.h:
2746
2747 2014-04-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2748
2749         [GTK] Unreviewed GTK gardening.
2750
2751         Update list of skipped unit tests:
2752
2753           Skip test: WebKit2Gtk/TestWebKitWebView:/webkit2/WebKitWebView/page-visibility
2754
2755           Unskip tests: WebKit2/TestWebKit2:WebKit2.ResizeReversePaginatedWebView
2756           and WebKit2/TestWebKit2:WebKit2.ScrollPinningBehaviors
2757
2758         * Scripts/run-gtk-tests:
2759         (TestRunner):
2760
2761 2014-04-16  Tim Horton  <timothy_horton@apple.com>
2762
2763         check-webkit-style doesn't check code style in .mm or .m files
2764         https://bugs.webkit.org/show_bug.cgi?id=131708
2765
2766         Reviewed by Darin Adler.
2767
2768         * Scripts/webkitpy/style/checker.py:
2769         * Scripts/webkitpy/style/checker_unittest.py:
2770         (CheckerDispatcherDispatchTest.test_cpp_paths):
2771         (CheckerDispatcherDispatchTest.test_text_paths):
2772         Check .mm and .m files as C++.
2773
2774         * Scripts/webkitpy/style/checkers/cpp.py:
2775         (check_spacing):
2776         Add an override for our ordinary "missing spaces around =" for @synthesize,
2777         which should look like "@synthesize propertyName=_varName;"
2778
2779         Add an override for "missing space before {" for blocks' "^{".
2780
2781         Don't follow the "extra space before [" rule for Objective-C, because
2782         it breaks this rule in a multitude of ways because of method calls.
2783
2784         (check_braces):
2785         Don't complain about { not being on the end of the previous line if
2786         the previous line starts with "- (" or "+ (", which would indicate a
2787         Objective-C method definition.
2788
2789 2014-04-16  Darin Adler  <darin@apple.com>
2790
2791         Make Vector::takeLast work with move-only types (and optimize for types where move is faster)
2792         https://bugs.webkit.org/show_bug.cgi?id=131735
2793
2794         Reviewed by Alexey Proskuryakov.
2795
2796         * TestWebKitAPI/Tests/WTF/Vector.cpp: Added a test for Vector::takeLast with move only types.
2797         Fixed invocations of EXPECT macros so the expected value is on the left, and the test result
2798         is on the right. This can be confusing since our JavaScript test framework does it the opposite
2799         way, but gtest works better this way.
2800
2801 2014-04-15  Hyowon Kim  <hw1008.kim@samsung.com>
2802
2803         [EFL] Fix problems with the pixel dump.
2804         https://bugs.webkit.org/show_bug.cgi?id=131265
2805
2806         Reviewed by Gyuyoung Kim.
2807
2808         Painting and compositing paths of WebKit-EFL were totally modified from r166768.
2809         However pixel dump codes still call deprecated functions like ewk_view_paint(),
2810         which causes that nothing is drawn.
2811
2812         This patch adds new member functions to AcceleratedCompositingContext to support pixel dump.
2813         One of new functions is AcceleratedCompositingContext::extractImageData(),
2814         which replaces deprecated function calls. Besides the extractImageData() is invoked by
2815         ewk_view_screenshot_contents_get() in order to take the visible content displayed on the EFL webview.
2816
2817         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
2818         (createBitmapContextFromWebView): Add to call DumpRenderTreeSupportEfl::forcePaint().
2819
2820 2014-04-15  Filip Pizlo  <fpizlo@apple.com>
2821
2822         Update LLVM export scrpt to handle the build directory being different from the
2823         source directory.
2824
2825         Rubber stamped by Geoffrey Garen.
2826
2827         * Scripts/export-llvm-build:
2828
2829 2014-04-15  Ryosuke Niwa  <rniwa@webkit.org>
2830
2831         Update the hyperlink to waterfall views of perf bots on build.webkit.org
2832         https://bugs.webkit.org/show_bug.cgi?id=131695
2833
2834         Reviewed by Antti Koivisto.
2835
2836         Updated.
2837
2838         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2839
2840 2014-04-15  Carlos Garcia Campos  <cgarcia@igalia.com>
2841
2842         [GTK] Reduce the binary size by compressing the text based web inspector resources
2843         https://bugs.webkit.org/show_bug.cgi?id=121545
2844
2845         Reviewed by Gustavo Noronha Silva.
2846
2847         Compress text based files when compiling inspector resources. It
2848         reduces the binary size in 3MB.
2849
2850         * gtk/generate-inspector-gresource-manifest.py:
2851         (find_all_files_in_directory):
2852         (is_compressible):
2853
2854 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
2855
2856         Remove Gtk WebKit1 tester.
2857
2858         Gtk WebKit1 port no longer exists, and dashboard was trying to load its tester
2859         results over and over as fast as it could.
2860
2861         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2862         (WebKitBuildbot):
2863
2864 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
2865
2866         Wrong link for webkitpy tests results in dashboard popover
2867         https://bugs.webkit.org/show_bug.cgi?id=131664
2868
2869         Reviewed by Timothy Hatcher.
2870
2871         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2872         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds):
2873         Use a correct link.
2874
2875 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
2876
2877         Update webkitpy regression test result that started to fail after http://trac.webkit.org/r167243
2878
2879         I'm not sure whether the changes are desirable, but am not suspicious enough to roll out.
2880
2881         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2882         (CommitMessageForThisCommitTest):
2883
2884 2014-04-14  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
2885
2886         Fix commit-log-editor bug revealed by r165447
2887         https://bugs.webkit.org/show_bug.cgi?id=130676
2888
2889         Reviewed by Csaba Osztrogonác.
2890
2891         * Scripts/commit-log-editor:
2892         (createCommitMessage): Omitting empty Source/JavaScriptCore:... blocks.
2893         Add \n before the first block too, because the longest common prefix now ends with only one newline.
2894         (removeLongestCommonPrefixEndingInNewline): The longest common prefix ends with only one newline,
2895         now the last block of the common prefix isn't duplicated below. Changing the function name accordingly.
2896
2897 2014-04-13  Darin Adler  <darin@apple.com>
2898
2899         userVisibleString should not try to "encode" host names
2900         https://bugs.webkit.org/show_bug.cgi?id=131587
2901         rdar://problem/14686849
2902
2903         Reviewed by Alexey Proskuryakov.
2904
2905         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added URLExtras.mm.
2906
2907         * TestWebKitAPI/Tests/mac/URLExtras.mm: Added. A few tests for WebCoreNSURLExtras.
2908         Coverage is tiny at this point; we could add a lot more cases!
2909
2910 2014-04-13  Jaehun Lim  <ljaehun.lim@samsung.com>
2911
2912         Use #include instead of #import
2913         https://bugs.webkit.org/show_bug.cgi?id=131604
2914
2915         Reviewed by Darin Adler.
2916
2917         Fix "warning: #import is a deprecated GCC extension [-Wdeprecated]".
2918
2919         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2920
2921 2014-04-12  Filip Pizlo  <fpizlo@apple.com>
2922
2923         Make slow-stress tests run faster by running fewer VM variants.
2924
2925         Rubber stamped by Geoffrey Garen.
2926
2927         * Scripts/run-javascriptcore-tests:
2928         * Scripts/run-jsc-stress-tests:
2929
2930 2014-04-10  Zan Dobersek  <zdobersek@igalia.com>
2931
2932         [CMake] Add missing WTF unit tests
2933         https://bugs.webkit.org/show_bug.cgi?id=131459
2934
2935         Reviewed by Martin Robinson.
2936
2937         * TestWebKitAPI/CMakeLists.txt: Add a few missing source files
2938         that should be compiled into the TestWTF binary.
2939
2940 2014-04-10  Brendan Long  <b.long@cablelabs.com>
2941
2942         [Gtk] run-launcher doesn't work by default
2943         https://bugs.webkit.org/show_bug.cgi?id=131494
2944
2945         Reviewed by Philippe Normand.
2946
2947         * Scripts/run-launcher: Always use MiniBrowser for WebKitGTK.
2948         * Scripts/webkitdirs.pm:
2949         (launcherName): Same.
2950         * Scripts/webkitpy/style/checker.py: Remove reference to GtkLauncher.
2951         * gtk/common.py:
2952         (get_build_path.is_valid_build_directory): Same.
2953         * gtk/manifest.txt: Same.
2954
2955 2014-04-09  Commit Queue  <commit-queue@webkit.org>
2956
2957         Unreviewed, rolling out r167046.
2958         https://bugs.webkit.org/show_bug.cgi?id=131479
2959
2960         Caused 300+ failures on Mavericks WK1 tester (Requested by ap
2961         on #webkit).
2962
2963         Reverted changeset:
2964
2965         "Remove "System Font" from whitelisted DRT fonts and char
2966         width calculations"
2967         https://bugs.webkit.org/show_bug.cgi?id=131411
2968         http://trac.webkit.org/changeset/167046
2969
2970 2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
2971
2972         Remove "System Font" from whitelisted DRT fonts and char width calculations
2973         https://bugs.webkit.org/show_bug.cgi?id=131411
2974
2975         Reviewed by Tim Horton.
2976
2977         Covered by existing tests.
2978
2979         * DumpRenderTree/mac/DumpRenderTree.mm:
2980         (allowedFontFamilySet):
2981
2982 2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
2983
2984         systemHiddenFontFamilySet in DRT is unnecessary
2985         https://bugs.webkit.org/show_bug.cgi?id=131414
2986
2987         Reviewed by Tim Horton.
2988
2989         It doesn't seem to affect test results on my machine.
2990
2991         * DumpRenderTree/mac/DumpRenderTree.mm:
2992         (drt_NSFontManager_availableFonts):
2993         (systemHiddenFontFamilySet): Deleted.
2994
2995 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
2996
2997         [Win] Unreviewed test fix: Don't double-release BSTR.
2998
2999         * DumpRenderTree/win/DumpRenderTree.cpp:
3000         (dump): Remove unneeded call to SysFreeString now that we are
3001         using _bstr_t for this variable.
3002
3003 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
3004
3005         [Win] Various DumpRenderTree Fixes.
3006         https://bugs.webkit.org/show_bug.cgi?id=131446.
3007
3008         Reviewed by Tim Horton.
3009
3010         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3011         (AccessibilityUIElement::title): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3012         (AccessibilityUIElement::description): Ditto.
3013         (AccessibilityUIElement::helpText): Ditto.
3014         (AccessibilityUIElement::intValue): Ditto.
3015         (AccessibilityUIElement::isPressActionSupported): Ditto.
3016         (AccessibilityUIElement::accessibilityValue): Ditto.
3017         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
3018         (DRTDesktopNotificationPresenter::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
3019         (DRTDesktopNotificationPresenter::AddRef): Ditto.
3020         (DRTDesktopNotificationPresenter::Release): Ditto.
3021         (DRTDesktopNotificationPresenter::showDesktopNotification): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3022         (DRTDesktopNotificationPresenter::cancelDesktopNotification): Ditto.
3023         (DRTDesktopNotificationPresenter::notificationDestroyed): Ditto.
3024         (DRTDesktopNotificationPresenter::checkNotificationPermission): Ditto.
3025         (DRTDesktopNotificationPresenter::requestNotificationPermission): Ditto.
3026         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
3027         * DumpRenderTree/win/DumpRenderTree.cpp:
3028         (dumpFrameScrollPosition): Ditto.
3029         (dumpFramesAsText): Ditto.
3030         (compareHistoryItems): Ditto.
3031         (dumpHistoryItem): Ditto.
3032         (dump): Ditto.
3033         (resetDefaultsToConsistentValues): Ditto.
3034         (resetWebViewToConsistentStateBeforeTesting): Ditto.
3035         (runTest): Ditto.
3036         (createWebViewAndOffscreenWindow): Ditto.
3037         * DumpRenderTree/win/EditingDelegate.cpp:
3038         (EditingDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
3039         (EditingDelegate::AddRef): Ditto.
3040         (EditingDelegate::Release): Ditto.
3041         (dumpPath): Switch to _bstr_t. Use JSStringCreateWithBSTR
3042         (EditingDelegate::shouldBeginEditingInDOMRange): Get rid of uneeded STDMETHODCALLTYPE declaration.
3043         (EditingDelegate::shouldEndEditingInDOMRange): Ditto.
3044         (EditingDelegate::shouldInsertNode): Ditto.
3045         (EditingDelegate::shouldInsertText): Ditto.
3046         (EditingDelegate::shouldDeleteDOMRange): Ditto.
3047         (EditingDelegate::shouldChangeSelectedDOMRange): Ditto.
3048         (EditingDelegate::shouldApplyStyle): Ditto.
3049         (EditingDelegate::shouldChangeTypingStyle): Ditto.
3050         (EditingDelegate::doPlatformCommand): Ditto.
3051         (EditingDelegate::webViewDidBeginEditing): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3052         (EditingDelegate::webViewDidChange): Ditto.
3053         (EditingDelegate::webViewDidEndEditing): Ditto.
3054         (EditingDelegate::webViewDidChangeTypingStyle): Ditto.
3055         (EditingDelegate::webViewDidChangeSelection): Ditto.
3056         (EditingDelegate::checkSpellingOfString): Ditto.
3057         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3058         (descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3059         (FrameLoadDelegate::FrameLoadDelegate): Ditto.
3060         (FrameLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
3061         (FrameLoadDelegate::AddRef): Ditto.
3062         (FrameLoadDelegate::Release): Ditto.
3063         (FrameLoadDelegate::didStartProvisionalLoadForFrame): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3064         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): Ditto.
3065         (FrameLoadDelegate::didFailProvisionalLoadWithError): Ditto.
3066         (FrameLoadDelegate::didCommitLoadForFrame): Ditto.
3067         (FrameLoadDelegate::didReceiveTitle): Ditto.
3068         (FrameLoadDelegate::didChangeIcons): Ditto.
3069         (delegatesWithDelayedWork): Ditto.
3070         (FrameLoadDelegate::didFinishLoadForFrame): Ditto.
3071         (FrameLoadDelegate::didFailLoadWithError): Ditto.
3072         (FrameLoadDelegate::willPerformClientRedirectToURL): Ditto.
3073         (FrameLoadDelegate::didCancelClientRedirectForFrame): Ditto.
3074         (FrameLoadDelegate::willCloseFrame): Ditto.
3075         (FrameLoadDelegate::didFinishDocumentLoadForFrame): Ditto.
3076         (FrameLoadDelegate::didHandleOnloadEventsForFrame): Ditto.
3077         (FrameLoadDelegate::didFirstVisuallyNonEmptyLayoutInFrame): Ditto.
3078         (FrameLoadDelegate::didDisplayInsecureContent): Ditto.
3079         (FrameLoadDelegate::didRunInsecureContent): Ditto.
3080         * DumpRenderTree/win/FrameLoadDelegate.h:
3081         * DumpRenderTree/win/HistoryDelegate.cpp:
3082         (HistoryDelegate::didNavigateWithNavigationData): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3083         (HistoryDelegate::updateHistoryTitle): Ditto.
3084         (HistoryDelegate::populateVisitedLinksForWebView): Ditto.
3085         * DumpRenderTree/win/PolicyDelegate.cpp:
3086         (dumpPath):
3087         (PolicyDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
3088         (PolicyDelegate::AddRef): Ditto.
3089         (PolicyDelegate::Release): Ditto.
3090         (PolicyDelegate::decidePolicyForNavigationAction): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3091         (PolicyDelegate::unableToImplementPolicyWithError): Ditto.
3092         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3093         (ResourceLoadDelegate::descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3094         (ResourceLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
3095         (ResourceLoadDelegate::AddRef): Ditto.
3096         (ResourceLoadDelegate::Release): Ditto.
3097         (ResourceLoadDelegate::identifierForInitialRequest): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3098         (ResourceLoadDelegate::removeIdentifierForRequest): Ditto.
3099         (ResourceLoadDelegate::willSendRequest): Ditto.
3100         (ResourceLoadDelegate::didReceiveAuthenticationChallenge): Ditto.
3101         (ResourceLoadDelegate::didReceiveResponse): Ditto.
3102         (ResourceLoadDelegate::didFinishLoadingFromDataSource): Ditto.
3103         (ResourceLoadDelegate::didFailLoadingWithError): Ditto.
3104         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
3105         (TestRunner::queueLoad): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3106         (TestRunner::setUserStyleSheetLocation): Ditto.
3107         (TestRunner::execCommand): Ditto.
3108         (TestRunner::overridePreference): Ditto.
3109         (TestRunner::evaluateScriptInIsolatedWorld): Ditto.
3110         * DumpRenderTree/win/TextInputControllerWin.cpp: Ditto.
3111         (TextInputController::setMarkedText): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3112         (TextInputController::insertText): Ditto.
3113         * DumpRenderTree/win/UIDelegate.cpp:
3114         (UIDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
3115         (UIDelegate::AddRef): Ditto.
3116         (UIDelegate::Release): Ditto.
3117         (UIDelegate::hasCustomMenuImplementation): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3118         (UIDelegate::trackCustomPopupMenu): Ditto.
3119         (UIDelegate::registerUndoWithTarget): Ditto.
3120         (UIDelegate::removeAllActionsWithTarget): Ditto.
3121         (UIDelegate::setActionTitle): Ditto.
3122         (UIDelegate::undo): Ditto.
3123         (UIDelegate::redo): Ditto.
3124         (UIDelegate::canUndo): Ditto.
3125         (UIDelegate::canRedo): Ditto.
3126         (UIDelegate::printFrame): Ditto.
3127         (UIDelegate::ftpDirectoryTemplatePath): Ditto.
3128         (UIDelegate::webViewHeaderHeight): Ditto.
3129         (UIDelegate::webViewFooterHeight): Ditto.
3130         (UIDelegate::drawHeaderInRect): Ditto.
3131         (UIDelegate::drawFooterInRect): Ditto.
3132         (UIDelegate::webViewPrintingMarginRect): Ditto.
3133         (UIDelegate::canRunModal): Ditto.
3134         (UIDelegate::createModalDialog): Ditto.
3135         (UIDelegate::runModal): Ditto.
3136         (UIDelegate::isMenuBarVisible): Ditto.
3137         (UIDelegate::setMenuBarVisible): Ditto.
3138         (UIDelegate::runDatabaseSizeLimitPrompt): Ditto.
3139         (UIDelegate::paintCustomScrollbar): Ditto.
3140         (UIDelegate::paintCustomScrollCorner): Ditto.
3141         (UIDelegate::setFrame): Ditto.
3142         (UIDelegate::webViewFrame): Ditto.
3143         (UIDelegate::runJavaScriptAlertPanelWithMessage): Ditto.
3144         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Ditto.
3145         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Ditto.
3146         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
3147         (UIDelegate::webViewAddMessageToConsole): Ditto.
3148         (UIDelegate::doDragDrop): Ditto.
3149         (UIDelegate::webViewGetDlgCode): Ditto.
3150         (UIDelegate::createWebViewWithRequest): Ditto.
3151         (UIDelegate::webViewClose): Ditto.
3152         (UIDelegate::webViewFocus): Ditto.
3153         (UIDelegate::webViewUnfocus): Ditto.
3154         (UIDelegate::webViewPainted): Ditto.
3155         (UIDelegate::exceededDatabaseQuota): Ditto.
3156         (UIDelegate::embeddedViewWithArguments): Ditto.
3157         (UIDelegate::webViewClosing): Ditto.
3158         (UIDelegate::webViewSetCursor): Ditto.
3159         (UIDelegate::webViewDidInvalidate): Ditto.
3160         (UIDelegate::setStatusText): Ditto.
3161         (UIDelegate::desktopNotificationsDelegate): Ditto.
3162         (UIDelegate::drawBackground): Ditto.
3163         (UIDelegate::decidePolicyForGeolocationRequest): Ditto.
3164         (UIDelegate::didPressMissingPluginButton): Ditto.
3165         * DumpRenderTree/win/WorkQueueItemWin.cpp: Ditto.
3166         (LoadItem::invoke):  Switch to _bstr_t. Use JSStringCreateWithBSTR.
3167         (LoadHTMLStringItem::invoke): Ditto.
3168         (ScriptItem::invoke): Ditto.
3169
3170 2014-04-09  Gergo Balogh  <gbalogh.u-szeged@partner.samsung.com>
3171
3172         Stylechecker: False positive on inline asm code.
3173         https://bugs.webkit.org/show_bug.cgi?id=130570
3174
3175         Reviewed by Csaba Osztrogonác.
3176
3177         Disable stylechecking in asm blocks.
3178
3179         * Scripts/webkitpy/style/checkers/cpp.py:
3180         (process_line):
3181         (_InlineASMState):
3182         (_InlineASMState.__init__):
3183         (_InlineASMState.process_line):
3184         (_InlineASMState.isInside):
3185         (_process_lines):
3186         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3187         (WebKitStyleTest.test_member_initialization_list):
3188
3189 2014-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
3190
3191         [GTK] Move WebKit1 unit tests resources used by WebKit2 unit tests to WebKit2 resources dir
3192         https://bugs.webkit.org/show_bug.cgi?id=131029
3193
3194         Reviewed by Philippe Normand.
3195
3196         Add blank.ico and test.pdf to resources dir of WebKit2Gtk unit
3197         tests and remove the getWebKit1TestResoucesDir() method.
3198
3199         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
3200         (testDownloadLocalFile): Use Test::getResourcesDir().
3201         (testDownloadLocalFileError): Ditto.
3202         (serverCallback): Ditto.
3203         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
3204         (serverCallback): Ditto.
3205         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
3206         (httpServerCallback): Ditto.
3207         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
3208         (serverCallback): Ditto.
3209         * TestWebKitAPI/Tests/WebKit2Gtk/resources/blank.ico: Added.
3210         * TestWebKitAPI/Tests/WebKit2Gtk/resources/test.pdf: Added.
3211         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
3212         (Test::getWebKit1TestResoucesDir): Deleted.
3213
3214 2014-04-09  Alexey Proskuryakov  <ap@apple.com>
3215
3216         [WK2] HTTP authentication regression tests fail
3217         https://bugs.webkit.org/show_bug.cgi?id=81627
3218         <rdar://problem/11079296>
3219
3220         Reviewed by Anders Carlsson.
3221
3222         * WebKitTestRunner/TestController.h:
3223         * WebKitTestRunner/TestController.cpp:
3224         (WTR::TestController::createWebViewWithOptions): Added canAuthenticateAgainstProtectionSpaceInFrame
3225         to pageLoaderClient structure.
3226         (WTR::TestController::canAuthenticateAgainstProtectionSpaceInFrame): Return true
3227         for password based authentication (we do get server trust challenges on some tests,
3228         which WKTR can't handle).
3229         When this client call is not implemented or returns false, didReceiveAuthenticationChallengeInFrame
3230         calls won't be made, at least on CFNetwork based platforms.
3231         (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Changed the output
3232         to omit <unknown>. The resource is always unknown with WK2, and it doesn't really
3233         make sense to associate auth requests with individual resources - there can be
3234         multiple resources loading at once from the same protection space, so WebKit1 API
3235         that had a resource identifier was inherently racy.
3236
3237 2014-04-09  Ryuan Choi  <ryuan.choi@samsung.com>
3238
3239         [EFL] Change font path for DumpRenderTree and WebKitTestRunner
3240         https://bugs.webkit.org/show_bug.cgi?id=131427
3241
3242         Reviewed by Gyuyoung Kim.
3243
3244         Since r166973, font path was changed.
3245
3246         * DumpRenderTree/PlatformEfl.cmake:
3247         * WebKitTestRunner/PlatformEfl.cmake:
3248
3249 2014-04-08  Geoffrey Garen  <ggaren@apple.com>
3250
3251         Fix the build-jsc build
3252         https://bugs.webkit.org/show_bug.cgi?id=131410
3253
3254         Reviewed by Michael Saboff.
3255
3256         * Scripts/build-jsc: Make sure to build bmalloc before WTF, since
3257         WTF depends on it.
3258
3259 2014-04-08  Martin Robinson  <mrobinson@igalia.com>
3260
3261         [GTK] Remove WebKit1 unit tests
3262         https://bugs.webkit.org/show_bug.cgi?id=131359
3263
3264         Reviewed by Anders Carlsson.
3265
3266         Remove all WebKit1 GTK+ unit tests, in preparation for removing the WebKit1 port
3267         entirely. We also remove the list of skipped WebKi1 tests from run-gtk-tests, as
3268         they were inadvertently left in http://trac.webkit.org/changeset/166504.
3269
3270         * CMakeLists.txt: No longer load the WebKit1 unit test CMakeLists.txt file.
3271         * Scripts/run-gtk-tests: Remove skipped WebKit1 unit tests.
3272         * TestWebKitAPI/Tests/WebKitGtk/CMakeLists.txt: Removed.
3273         * TestWebKitAPI/Tests/WebKitGtk/resources/blank.ico: Removed.
3274         * TestWebKitAPI/Tests/WebKitGtk/resources/test.html: Removed.
3275         * TestWebKitAPI/Tests/WebKitGtk/resources/test.ogg: Removed.
3276         * TestWebKitAPI/Tests/WebKitGtk/resources/test.pdf: Removed.
3277         * TestWebKitAPI/Tests/WebKitGtk/resources/test.txt: Removed.
3278         * TestWebKitAPI/Tests/WebKitGtk/test_utils.c: Removed.
3279         * TestWebKitAPI/Tests/WebKitGtk/test_utils.h: Removed.
3280         * TestWebKitAPI/Tests/WebKitGtk/testapplicationcache.c: Removed.
3281         * TestWebKitAPI/Tests/WebKitGtk/testatk.c: Removed.
3282         * TestWebKitAPI/Tests/WebKitGtk/testatkroles.c: Removed.
3283         * TestWebKitAPI/Tests/WebKitGtk/testcontextmenu.c: Removed.
3284         * TestWebKitAPI/Tests/WebKitGtk/testcopyandpaste.c: Removed.
3285         * TestWebKitAPI/Tests/WebKitGtk/testdomdocument.c: Removed.
3286         * TestWebKitAPI/Tests/WebKitGtk/testdomdomwindow.c: Removed.
3287         * TestWebKitAPI/Tests/WebKitGtk/testdomnode.c: Removed.
3288         * TestWebKitAPI/Tests/WebKitGtk/testdownload.c: Removed.
3289         * TestWebKitAPI/Tests/WebKitGtk/testfavicondatabase.c: Removed.
3290         * TestWebKitAPI/Tests/WebKitGtk/testglobals.c: Removed.
3291         * TestWebKitAPI/Tests/WebKitGtk/testhittestresult.c: Removed.
3292         * TestWebKitAPI/Tests/WebKitGtk/testhttpbackend.c: Removed.
3293         * TestWebKitAPI/Tests/WebKitGtk/testkeyevents.c: Removed.
3294         * TestWebKitAPI/Tests/WebKitGtk/testloading.c: Removed.
3295         * TestWebKitAPI/Tests/WebKitGtk/testmimehandling.c: Removed.
3296         * TestWebKitAPI/Tests/WebKitGtk/testnetworkrequest.c: Removed.
3297         * TestWebKitAPI/Tests/WebKitGtk/testnetworkresponse.c: Removed.
3298         * TestWebKitAPI/Tests/WebKitGtk/testwebbackforwardlist.c: Removed.
3299         * TestWebKitAPI/Tests/WebKitGtk/testwebdatasource.c: Removed.
3300         * TestWebKitAPI/Tests/WebKitGtk/testwebframe.c: Removed.
3301         * TestWebKitAPI/Tests/WebKitGtk/testwebhistoryitem.c: Removed.
3302         * TestWebKitAPI/Tests/WebKitGtk/testwebinspector.c: Removed.
3303         * TestWebKitAPI/Tests/WebKitGtk/testwebplugindatabase.c: Removed.
3304         * TestWebKitAPI/Tests/WebKitGtk/testwebresource.c: Removed.
3305         * TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c: Removed.
3306         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Removed.
3307         * TestWebKitAPI/Tests/WebKitGtk/testwindow.c: Removed.
3308
3309 2014-04-08  Brent Fulgham  <bfulgham@apple.com>
3310
3311         Unreviewed gardening (Take 2): Prevent users from attempting
3312         to build with known invalid cURL. 
3313
3314         * Scripts/webkitdirs.pm:
3315         (checkInstalledTools): Check for 7.34.0 (the broken version), not
3316         7.33.0 (the known good version).
3317
3318 2014-04-08  Martin Robinson  <mrobinson@igalia.com>
3319
3320         [GTK] Remove DumpRenderTree and GtkLauncher
3321         https://bugs.webkit.org/show_bug.cgi?id=131373
3322
3323         Reviewed by Andreas Kling.
3324
3325         Remove the GTK+ port of DumpRenderTree and GtkLauncher. These tools are
3326         no longer necessary now that WebKit1 GTK+ will be removed.
3327
3328         * CMakeLists.txt:
3329         * DumpRenderTree/PlatformGTK.cmake: Removed.
3330         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: Removed.
3331         * DumpRenderTree/gtk/DumpRenderTree.cpp: Removed.
3332         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Removed.
3333         * DumpRenderTree/gtk/EditingCallbacks.cpp: Removed.
3334         * DumpRenderTree/gtk/EditingCallbacks.h: Removed.
3335         * DumpRenderTree/gtk/EventSender.cpp: Removed.
3336         * DumpRenderTree/gtk/EventSender.h: Removed.
3337         * DumpRenderTree/gtk/GCControllerGtk.cpp: Removed.
3338         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Removed.
3339         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp: Removed.
3340         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h: Removed.
3341         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Removed.
3342         * DumpRenderTree/gtk/TextInputController.cpp: Removed.
3343         * DumpRenderTree/gtk/TextInputController.h: Removed.
3344         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Removed.
3345         * GtkLauncher/CMakeLists.txt: Removed.
3346         * GtkLauncher/LauncherInspectorWindow.c: Removed.
3347         * GtkLauncher/LauncherInspectorWindow.h: Removed.
3348         * GtkLauncher/main.c: Removed.
3349         * GtkLauncher/simple.svg: Removed.
3350         * GtkLauncher/text.html: Removed.
3351         * WebKitTestRunner/PlatformGTK.cmake:
3352         * WebKitTestRunner/gtk/fonts/AHEM____.TTF: Renamed from Tools/DumpRenderTree/gtk/fonts/AHEM____.TTF.
3353         * WebKitTestRunner/gtk/fonts/FontWithNoValidEncoding.fon: Renamed from Tools/DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon.
3354         * WebKitTestRunner/gtk/fonts/fonts.conf: Renamed from Tools/DumpRenderTree/gtk/fonts/fonts.conf.
3355
3356 2014-04-08  Mark Rowe  <mrowe@apple.com>
3357
3358         XPC services launched by Safari have wrong DYLD_FRAMEWORK_PATH set when launched via run-safari / debug-safari
3359         <https://webkit.org/b/131388> / <rdar://problem/16291687>
3360
3361         Reviewed by Alexey Proskuryakov.
3362
3363         * Scripts/webkitdirs.pm:
3364         (runMacWebKitApp): Set __XPC_DYLD_FRAMEWORK_PATH to the absolute path to the built products directory.
3365         (execMacWebKitAppForDebugging): Ditto.
3366
3367 2014-04-08  Geoffrey Garen  <ggaren@apple.com>
3368
3369         Build bmalloc on iOS too
3370         https://bugs.webkit.org/show_bug.cgi?id=131381
3371
3372         Reviewed by Andreas Kling.
3373
3374         * Scripts/build-webkit:
3375
3376 2014-04-08  Brent Fulgham  <bfulgham@apple.com>
3377
3378         Unreviewed gardening: Prevent users from attempting
3379         to build with known invalid cURL.
3380
3381         * Scripts/webkitdirs.pm:
3382         (checkInstalledTools): Block build attempts with bad
3383         Cygwin tool set.
3384
3385 2014-04-07  Geoffrey Garen  <ggaren@apple.com>
3386
3387         Build bmalloc on Mac
3388         https://bugs.webkit.org/show_bug.cgi?id=131333
3389
3390         Reviewed by Mark Rowe.
3391
3392         * Scripts/build-webkit: Add the bmalloc target if we're on Mac.
3393         (Note: Just testing Mac is not good enough because in this
3394         script 'Mac' means 'Mac or iOS'.)
3395
3396 2014-03-30  Filip Pizlo  <fpizlo@apple.com>
3397
3398         Move slow JSRegress tests out of the way so that they don't show up in run-jsc-benchmarks runs and also skip tests that are extremely long-running
3399         https://bugs.webkit.org/show_bug.cgi?id=130951
3400
3401         Reviewed by Geoffrey Garen.
3402
3403         * Scripts/run-javascriptcore-tests:
3404
3405 2014-04-06  Darin Adler  <darin@apple.com>
3406
3407         Rework CSS calc logic, fixing some reference count mistakes in Length
3408         https://bugs.webkit.org/show_bug.cgi?id=131280
3409
3410         Reviewed by Andreas Kling.
3411
3412         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added CalculationValue.cpp.
3413         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp: Added.
3414
3415 2014-04-04  Brian J. Burg  <burg@cs.washington.edu>
3416
3417         Enable WEB_REPLAY for PLATFORM(MAC)
3418         https://bugs.webkit.org/show_bug.cgi?id=130700
3419
3420         Reviewed by Timothy Hatcher.
3421
3422         * Scripts/webkitperl/FeatureList.pm: Set the default for WEB_REPLAY for OS X engineering builds.
3423
3424 2014-04-05  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3425
3426         [CMake] Include X11's include dirs in TestNetscapePlugin
3427         https://bugs.webkit.org/show_bug.cgi?id=131270
3428
3429         Reviewed by Martin Robinson.
3430
3431         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Include X11_INCLUDE_DIR since
3432         TestNetscapePlugin includes WebCore code that includes X headers.
3433
3434 2014-04-05  David Kilzer  <ddkilzer@apple.com>
3435
3436         REGRESSION (r166529): Fix build after renaming TileCache to LegacyTileCache
3437         <http://webkit.org/b/130986>
3438
3439         * Scripts/check-for-inappropriate-objc-class-names: Add 'Legacy'
3440         prefix to TileCache class names in exception list.
3441
3442 2014-04-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3443
3444         [GTK] kill-old-processes should kill dbus-daemon processes
3445         https://bugs.webkit.org/show_bug.cgi?id=127352
3446
3447         Reviewed by Martin Robinson.
3448
3449         * BuildSlaveSupport/kill-old-processes:
3450         (main):
3451
3452 2014-04-04  Andres Gomez  <agomez@igalia.com>
3453
3454         [Win] Update obsolete packages in cygwin
3455         https://bugs.webkit.org/show_bug.cgi?id=126264
3456
3457         Reviewed by Brent Fulgham.
3458
3459         Removed "apache" and "minires" as the first has been replaced by
3460         "lighttpd" and the second is now integrated into
3461         "cygwin". Replaced the transitional and now obsolete "gcc" package
3462         with "gcc-g++" and ensure that "python" stays at version "2.6.8"
3463         since the newer version available is "2.7.3" which breaks the
3464         build due to some funniness with environment variable handling.
3465
3466         * CygwinDownloader/cygwin-downloader.py:
3467         * CygwinDownloader/cygwin-downloader.zip:
3468
3469 2014-04-03  Joseph Pecoraro  <pecoraro@apple.com>
3470
3471         check-webkit-style: Improve warnings on Objective-C @property syntax
3472         https://bugs.webkit.org/show_bug.cgi?id=131200
3473
3474         Reviewed by Dan Bernstein.
3475
3476         * Scripts/webkitpy/style/checkers/cpp.py:
3477         (check_spacing):
3478         (CppChecker):
3479         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3480         (CppStyleTest.test_spacing_in_objective_c_properties):
3481
3482 2014-04-03  Santosh Mahto  <santoshbit2007@gmail.com>
3483
3484         Unreviewed. Moving my name to commiter section
3485
3486         * Scripts/webkitpy/common/config/contributors.json:
3487
3488 2014-04-03  Santosh Mahto  <santoshbit2007@gmail.com>
3489
3490         Unreviewed. Add myself as a committer.
3491
3492         * Scripts/webkitpy/common/config/contributors.json:
3493
3494 2014-04-03  Andrzej Badowski  <a.badowski@samsung.com>
3495
3496         [EFL][WK2] Replacing zoom functionality of MiniBrowser from scale_set to page_zoom_set.
3497         https://bugs.webkit.org/show_bug.cgi?id=130391
3498
3499         Reviewed by Gyuyoung Kim.
3500
3501         Change the implementation of the zoom functionality from ewk_view_scale_set
3502         to ewk_view_page_zoom_set.
3503
3504         * MiniBrowser/efl/main.c:
3505
3506 2014-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
3507
3508         [webkitpy] perf profiler does not understand --call-graph argument
3509         https://bugs.webkit.org/show_bug.cgi?id=131132
3510
3511         Reviewed by Ryosuke Niwa.
3512
3513         New versions of perf profiler have changed the argument from --call-graph to -g.
3514
3515         * Scripts/webkitpy/common/system/profiler.py:
3516         (Perf.wrapper_arguments): Use -g instead of --call-graph.
3517         * Scripts/webkitpy/port/driver_unittest.py:
3518         (DriverTest.test_profiler_as_wrapper): Update test accordingly.
3519
3520 2014-04-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
3521
3522         Add EFL WK2 performance bot to build.webkit.org
3523         https://bugs.webkit.org/show_bug.cgi?id=131034
3524
3525         Fix after r166707, use "Perf" instead of "perf" for consistency.
3526
3527         Reviewed by Csaba Osztrogonác.
3528
3529         * BuildSlaveSupport/build.webkit.org-config/config.json:
3530
3531 2014-04-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
3532
3533         Add EFL WK2 performance bot to build.webkit.org
3534         https://bugs.webkit.org/show_bug.cgi?id=131034
3535
3536         Reviewed by Csaba Osztrogonác.
3537
3538         * BuildSlaveSupport/build.webkit.org-config/config.json:
3539
3540 2014-04-02  Ryuan Choi  <ryuan.choi@samsung.com>
3541
3542         [EFL][WK1] Use Evas_Touch_Point_State instead of Ewk_Touch_Point_Type
3543         https://bugs.webkit.org/show_bug.cgi?id=131151
3544
3545         Reviewed by Gyuyoung Kim.
3546
3547         * DumpRenderTree/efl/EventSender.cpp: Replace Ewk_Touch_Point_Type to Evas_Touch_Point_State.
3548         (TouchEventInfo::TouchEventInfo):
3549         (sendTouchEvent):
3550         (addTouchPointCallback):
3551         (updateTouchPointCallback):
3552         (cancelTouchPointCallback):
3553         (releaseTouchPointCallback):
3554
3555 2014-04-02  David Kilzer  <ddkilzer@apple.com>
3556
3557         filter-build-webkit: Ignore xcodebuild warnings when compiling with newer builds of clang
3558         <http://webkit.org/b/131045>
3559
3560         Reviewed by Daniel Bates.
3561
3562         * Scripts/filter-build-webkit:
3563         (shouldIgnoreLine): Ignore DVTAssertions related to new builds
3564         of clang, plus debug data for all DVTAssertions.
3565
3566 2014-04-01  Dean Jackson  <dino@apple.com>
3567
3568         Load Media Controls js/css from bundle
3569         https://bugs.webkit.org/show_bug.cgi?id=131086
3570
3571         Reviewed by Eric Carlson.
3572
3573         We're now putting CSS files into the bundle, so remove the test for them.
3574
3575         * Scripts/check-for-inappropriate-files-in-framework:
3576
3577 2014-04-02  Martin Hock  <mhock@apple.com>
3578
3579         Unify private browsing with sessions.
3580         https://bugs.webkit.org/show_bug.cgi?id=130099
3581
3582         Reviewed by Alexey Proskuryakov.
3583
3584         Add an API test for ephemeral sessions similar to PrivateBrowsingPushStateNoHistoryCallback.
3585         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3586         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
3587         (TestWebKitAPI::didNavigateWithNavigationData):
3588         (TestWebKitAPI::didSameDocumentNavigationForFrame):
3589         (TestWebKitAPI::TEST):
3590
3591         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp: Also test to make sure private browsing can be disabled.
3592         (TestWebKitAPI::didNavigateWithoutNavigationData):
3593         (TestWebKitAPI::didNavigateWithNavigationData):
3594         (TestWebKitAPI::didSameDocumentNavigationForFrame):
3595         (TestWebKitAPI::TEST):
3596
3597 2014-04-02  Martin Robinson  <mrobinson@igalia.com>
3598
3599         REGRESSION(r165704): [GTK] Inspector resources not correctly generated
3600         https://bugs.webkit.org/show_bug.cgi?id=130343
3601
3602         Reviewed by Gustavo Noronha Silva.
3603
3604         * gtk/generate-inspector-gresource-manifest.py: Instead of hard-coding the file list, accept a list
3605         of directories on the command line and look for all appropriate files in those directories for the
3606         GResource archive. Also make archive paths relative to those directories.
3607         (find_all_files_in_directory): This helper looks for all the appropriate files in a given directory.
3608         (find_all_files_in_directory.select_file): Whether or not to add the file to the archive.
3609
3610 2014-04-02  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3611
3612         [webkitpy] Avoid multiple "Preparing rollout for bug" log messages
3613         https://bugs.webkit.org/show_bug.cgi?id=131106
3614
3615         Reviewed by Csaba Osztrogonác.
3616
3617         * Scripts/webkitpy/tool/commands/download.py:
3618         (AbstractRolloutPrepCommand._prepare_state):
3619         * Scripts/webkitpy/tool/commands/download_unittest.py:
3620         (test_prepare_rollout):
3621         (test_create_rollout):
3622         (test_create_rollout_resolved):
3623         (test_rollout):
3624
3625 2014-04-02  Krzysztof Wolanski  <k.wolanski@samsung.com>
3626
3627         [EFL] Add option to use separate web process for new window in MiniBrowser
3628         https://bugs.webkit.org/show_bug.cgi?id=130190
3629
3630         Reviewed by Gyuyoung Kim.
3631
3632         New created window (CTRL + n) will be open in separated web process.
3633         This option is enabled by adding a flag (S/separate-process) with launching
3634         MiniBrowser.
3635
3636         * MiniBrowser/efl/main.c:
3637         (elm_main):
3638
3639 2014-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
3640
3641         [GTK] Move NEWS file to a new location
3642         https://bugs.webkit.org/show_bug.cgi?id=130901
3643
3644         Reviewed by Brent Fulgham.
3645
3646         * gtk/manifest.txt: Update the NEWS file path.
3647
3648 2014-04-01  Anders Carlsson  <andersca@apple.com>
3649
3650         Fix build.
3651
3652         * MiniBrowser/mac/WK2BrowserWindowController.m:
3653         (-[WK2BrowserWindowController awakeFromNib]):
3654         (-[WK2BrowserWindowController dealloc]):
3655         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
3656
3657 2014-04-01  Brent Fulgham  <bfulgham@apple.com>
3658
3659         Unreviewed test gardening.
3660
3661         * Scripts/webkitpy/port/base_unittest.py:
3662         (PortTest.test_build_path): Handle the Debug case so we don't get webkitpy-test failures on our test bots.
3663
3664 2014-04-01  Zoltan Horvath  <zoltan@webkit.org>
3665
3666         [CSS Exclusions] Remove exclusions parsing support
3667         https://bugs.webkit.org/show_bug.cgi?id=131046
3668
3669         Reviewed by David Hyatt.
3670
3671         * Scripts/webkitperl/FeatureList.pm:
3672
3673 2014-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
3674
3675         [GTK] Remove last reference to GTK+ WK1 EWS
3676         https://bugs.webkit.org/show_bug.cgi?id=131058
3677
3678         Reviewed by Martin Robinson.
3679
3680         In r166427 WK1 GTK+ bots and EWS where removed, but this file was missing.
3681
3682         * QueueStatusServer/config/queues.py: Remove reference to GTK+ WK1 EWS.
3683
3684 2014-04-01  Lucas Forschler  <lforschler@apple.com>
3685
3686         Add a 32bit JSC builder/tester.
3687         https://bugs.webkit.org/show_bug.cgi?id=131054
3688         
3689         Reviewed by Michael Saboff.
3690
3691         * BuildSlaveSupport/build.webkit.org-config/config.json:
3692         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3693         (Compile32bitJSC):
3694         (Run32bitJSCTests):
3695         (Run32bitJSCTests.countFailures):
3696         (BuildAndTest32bitJSCFactory):
3697         (BuildAndTest32bitJSCFactory.__init__):
3698
3699 2014-04-01  Martin Robinson  <mrobinson@igalia.com>
3700
3701         [GTK] No longer build WebKit1 gtkdoc
3702         https://bugs.webkit.org/show_bug.cgi?id=130970
3703
3704         Reviewed by Anders Carlsson.
3705
3706         * gtk/common.py:
3707         (gtk_version_of_pkg_config_file): Deleted.
3708         * gtk/generate-gtkdoc:
3709         (get_gtkdoc_module_paths): We no longer need to worry about GTK+ 2, since it
3710         was only applicable for WebKit1.
3711         (get_generator_for_config): No longer look for the WebKit1 configuration file.
3712
3713 2014-04-01  Mario Sanchez Prada  <mario.prada@samsung.com>
3714
3715         [GTK] Running minibrowser with url crashes in debug build
3716         https://bugs.webkit.org/show_bug.cgi?id=130492
3717
3718         Reviewed by Martin Robinson.
3719
3720         Update "uri-scheme" test not to use invalid URIs in it, so we
3721         don't get a mistmatch when comparing the original URI stored in
3722         the test class with the one returned by the WebKitWebView.
3723
3724         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
3725         (testWebContextURIScheme): Update the test.
3726
3727 2014-04-01  Mihai Tica  <mitica@adobe.com>
3728
3729         Unreviewed: Add myself as a commiter to the contributors list.
3730
3731         * Scripts/webkitpy/common/config/contributors.json:
3732
3733 2014-03-31  Ryuan Choi  <ryuan.choi@samsung.com>
3734
3735         [EFL][WK2] Extract the control of page background out of color_set
3736         https://bugs.webkit.org/show_bug.cgi?id=127539
3737
3738         Reviewed by Gyuyoung Kim.
3739
3740         Added an option(C) to change background color.
3741
3742         * MiniBrowser/efl/main.c:
3743         (window_create):
3744         (elm_main):
3745
3746 2014-03-31  Ryuan Choi  <ryuan.choi@samsung.com>
3747
3748         Unreviewed build fix on the EFL port with latest EFL libraries since r166149
3749
3750         * ImageDiff/PlatformEfl.cmake: Added ECORE_IMF_INCLUDE_DIRS to include dirs
3751
3752 2014-03-31  Brent Fulgham  <bfulgham@apple.com>
3753
3754         Unreviewed test correction after r166530.
3755
3756         * DumpRenderTree/mac/DumpRenderTree.mm:
3757         (setDefaultsToConsistentValuesForTesting): No need to change preference for all tests. We set the proper
3758         fine-grained setting for swipe tests. This prevents existing tests from breaking.
3759
3760 2014-03-31  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3761
3762         Remove the trigger for webkit1 tests on the gtk-linux-64-release bot
3763         https://bugs.webkit.org/show_bug.cgi?id=130987
3764
3765         r166427 removed the WebKit1 GTK+ bots, so we don't longer need to
3766         trigger the webkit1 bot tests on the gtk-linux-64-release bot.
3767
3768         Reviewed by Martin Robinson.
3769
3770         * BuildSlaveSupport/build.webkit.org-config/config.json:
3771
3772 2014-03-31  Dean Jackson  <dino@apple.com>
3773
3774         Remove WEB_ANIMATIONS
3775         https://bugs.webkit.org/show_bug.cgi?id=130989
3776
3777         Reviewed by Simon Fraser.
3778
3779         Remove this feature flag until we plan to implement.
3780
3781         * Scripts/webkitperl/FeatureList.pm:
3782
3783 2014-03-31  Brent Fulgham  <bfulgham@apple.com>
3784
3785         Reduced Latched Scroll Test Flakiness
3786         https://bugs.webkit.org/show_bug.cgi?id=130983
3787
3788         Reviewed by Darin Adler.
3789
3790         * DumpRenderTree/mac/DumpRenderTree.mm:
3791         (setDefaultsToConsistentValuesForTesting): Test user should have 'high resolution' scrolling.
3792         * DumpRenderTree/mac/EventSendingController.mm:
3793         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]): Generate mouse wheel events
3794         with high resolution flags turned on.
3795         * WebKitTestRunner/mac/EventSenderProxy.mm:
3796         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Ditto.
3797
3798 2014-03-31  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
3799
3800         run-webkit-tests should have a --no-timeout option
3801         https://bugs.webkit.org/show_bug.cgi?id=128286
3802
3803         Reviewed by Joseph Pecoraro.
3804
3805         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3806         (Worker._run_test): Renaming _run_test_with_timeout()
3807         (Worker._run_test_with_or_without_timeout): Renaming _run_test_with_timeout(), because tests can now run without timeout.
3808         (Worker._run_test_in_another_thread): Passing the --no-timeout option to the driver
3809         (Worker._run_test_in_this_thread):
3810         (Worker._run_test_with_timeout): Deleted.
3811         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3812         (parse_args): Added the --no-timeout option
3813
3814 2014-03-31  Samuel White  <samuel_white@apple.com>
3815
3816         AX: Need ability to get line range for text marker.
3817         https://bugs.webkit.org/show_bug.cgi?id=130906
3818
3819         Reviewed by Chris Fleizach.
3820
3821         Added a new function in DRT and TestRunner to test that AXLineTextMarkerRangeForTextMarker works as expected.
3822
3823         * DumpRenderTree/AccessibilityUIElement.cpp:
3824         (lineTextMarkerRangeForTextMarkerCallback):
3825         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
3826         (AccessibilityUIElement::getJSClass):
3827         * DumpRenderTree/AccessibilityUIElement.h:
3828         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3829         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
3830         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3831         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
3832         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3833         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3834         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3835         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
3836         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3837         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
3838         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3839         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
3840
3841 2014-03-31  Filip Pizlo  <fpizlo@apple.com>
3842
3843         More validation for FTL inline caches
3844         https://bugs.webkit.org/show_bug.cgi?id=130948
3845
3846         Reviewed by Geoffrey Garen.
3847
3848         * Scripts/run-jsc-stress-tests:
3849
3850 2014-03-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3851
3852         [GTK] Do not run WebKit1 unit tests by default
3853         https://bugs.webkit.org/show_bug.cgi?id=130968
3854
3855         Reviewed by Martin Robinson.
3856
3857         * Scripts/run-gtk-tests:
3858         (TestRunner):
3859
3860 2014-03-31  Martin Robinson  <mrobinson@igalia.com>
3861
3862         [GTK] Remove scripts code only applicable to autotools
3863         https://bugs.webkit.org/show_bug.cgi?id=130841
3864
3865         Reviewed by Anders Carlsson.
3866
3867         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
3868         (_should_file_trigger_build): Update file list to reflect GTK+ CMake port.
3869         * Scripts/webkitpy/common/config/watchlist: Remove the GTK+ build watchlist.
3870         * Scripts/webkitpy/style/checker.py: The GNUmakefile doesn't exist any longer.
3871         * gtk/find-make-dist-errors: Removed.
3872         * gtk/generate-feature-defines-files: Removed.
3873         * gtk/manifest.txt: No longer need to consider autotools files.
3874
3875 2014-03-30  Andy Estes  <aestes@apple.com>
3876
3877         Fix two failing layout tests on Mountain Lion after r166466.
3878
3879         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3880         (-[DownloadDelegate _downloadDidStart:]):
3881
3882 2014-03-30  Andy Estes  <aestes@apple.com>
3883
3884         [Cocoa] Add an originatingWebView property to _WKDownload
3885         https://bugs.webkit.org/show_bug.cgi?id=130945
3886
3887         Reviewed by Anders Carlsson.
3888
3889         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3890         (-[DownloadDelegate _downloadDidStart:]):
3891         (-[OriginatingWebViewDownloadDelegate initWithWebView:]):
3892         (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
3893         (TEST):
3894
3895 2014-03-28  Filip Pizlo  <fpizlo@apple.com>
3896
3897         Land the stackmap register liveness glue with the uses of the liveness disabled
3898         https://bugs.webkit.org/show_bug.cgi?id=130924
3899
3900         Reviewed by Oliver Hunt.
3901
3902         * Scripts/run-jsc-stress-tests:
3903
3904 2014-03-29  Alexey Proskuryakov  <ap@apple.com>
3905
3906         Update WebKit1.StringTruncator for Mountain Lion.
3907
3908         * TestWebKitAPI/Tests/mac/StringTruncator.mm: Looks like one subtest was failing
3909         due to different font metrics on 10.8.
3910
3911 2014-03-28  Darin Adler  <darin@apple.com>
3912
3913         Fix recently-introduced off-by-one error in centerTruncateToBuffer
3914         https://bugs.webkit.org/show_bug.cgi?id=130889
3915
3916         Reviewed by Alexey Proskuryakov.
3917
3918         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added StringTruncator.mm.
3919         * TestWebKitAPI/Tests/mac/StringTruncator.mm: Added. One test for each of the
3920         WebStringTruncator methods; should be good for a start. These are dependent on the
3921         metrics of Helvetica 12, but I am hoping that will be consistent across OS X machines.
3922
3923 2014-03-28  Martin Hock  <mhock@apple.com>
3924
3925         Unreviewed. Add myself as a committer.
3926
3927         * Scripts/webkitpy/common/config/contributors.json:
3928
3929 2014-03-28  Martin Robinson  <mrobinson@igalia.com>
3930
3931         Remove WebKit1 GTK+ bots
3932         https://bugs.webkit.org/show_bug.cgi?id=130904
3933
3934         Reviewed by Anders Carlsson.
3935
3936         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove references to GTK+ WebKit1 test bot and ensure
3937         all bots are testing WebKit2 only.
3938         * Scripts/webkitpy/common/config/ews.json: Remove references to GTK+ WK1 EWS.
3939         * Scripts/webkitpy/common/config/ports.py: Remove references to GTK+ WK1 bots.
3940         * Scripts/webkitpy/common/config/ports_unittest.py: Ditto.
3941         * Scripts/webkitpy/port/builders.py: Ditto.
3942         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Ditto.
3943         * TestResultServer/static-dashboards/builders.jsonp: Ditto.
3944
3945 2014-03-28  Timothy Hatcher  <timothy@apple.com>
3946
3947         Remove Brian Burg's apple.com email address.
3948
3949         * Scripts/webkitpy/common/config/contributors.json:
3950
3951 2014-03-28  David Kilzer  <ddkilzer@apple.com>
3952
3953         bisect-builds should print Trac 'changeset' URL if only one build is detected
3954         <http://webkit.org/b/130903>
3955
3956         Reviewed by Dan Bernstein.
3957
3958         * Scripts/bisect-builds:
3959         (printTracLink): Print a direct link to the Trac 'changeset'
3960         URL if there is only one revision in the range.
3961
3962 2014-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3963
3964         [EFL] Bump glib version from 2.36 to 2.38 
3965         https://bugs.webkit.org/show_bug.cgi?id=130886
3966
3967         Reviewed by Csaba Osztrogonác.
3968
3969         There is a build break on EFL port when using glib 2.36 ver. To fix it,
3970         we need to bump glib version up to 2.38 as gtk port.
3971
3972         * efl/jhbuild.modules:
3973
3974 2014-03-27  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3975
3976         <https://webkit.org/b/42704> WebKitTestRunner needs to print history delegate information
3977
3978         Provide an implementation of WKContextHistoryClient that logs when called for tests in
3979         the globalhistory directory.
3980
3981         Reviewed by Sam Weinig.
3982
3983         * WebKitTestRunner/TestController.cpp:
3984         (WTR::TestController::TestController):
3985         (WTR::TestController::initialize): Set the history client.
3986         (WTR::TestController::resetStateToConsistentValues): Disable logging of history client callbacks.
3987         (WTR::TestController::didNavigateWithNavigationData): Log information about the navigation. Some portions
3988         of the output are hard-coded to match WebKit1's results for now since they're fixed in our existing tests
3989         and we don't yet have API to access the data in question.
3990         (WTR::TestController::didPerformClientRedirect):
3991         (WTR::TestController::didPerformServerRedirect):
3992         (WTR::TestController::didUpdateHistoryTitle):
3993         * WebKitTestRunner/TestController.h:
3994         (WTR::TestController::setShouldLogHistoryClientCallbacks):
3995         * WebKitTestRunner/TestInvocation.cpp:
3996         (WTR::shouldLogHistoryClientCallbacks): Log history client callbacks for tests in a globalhistory directory.
3997         (WTR::TestInvocation::invoke):
3998
3999 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
4000
4001         Revert http://trac.webkit.org/changeset/166386 because it broke builds.
4002
4003         * Scripts/build-webkit:
4004         * Scripts/copy-webkitlibraries-to-product-directory:
4005
4006 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
4007
4008         Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
4009         https://bugs.webkit.org/show_bug.cgi?id=130867
4010         <rdar://problem/16432456> 
4011
4012         Reviewed by Mark Hahnenberg.
4013
4014         * Scripts/build-webkit:
4015         * Scripts/copy-webkitlibraries-to-product-directory:
4016
4017 2014-03-26  Andy Estes  <aestes@apple.com>
4018
4019         [Cocoa] Expose DownloadClient::didFail() and DownloadClient::didCancel()
4020         https://bugs.webkit.org/show_bug.cgi?id=130805
4021
4022         Reviewed by Dan Bernstein.
4023
4024         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
4025         (-[DownloadDelegate _download:didReceiveResponse:]):
4026         (-[DownloadDelegate _downloadDidFinish:]):
4027         (runTest):
4028         (TEST):
4029         (-[FailingDownloadDelegate _downloadDidFinish:]):
4030         (-[FailingDownloadDelegate _download:didFailWithError:]):
4031         (-[FailingDownloadDelegate _downloadDidCancel:]):
4032         (-[CancelledDownloadDelegate _downloadDidStart:]):
4033         (-[CancelledDownloadDelegate _downloadDidFinish:]):
4034         (-[CancelledDownloadDelegate _download:didFailWithError:]):
4035         (-[CancelledDownloadDelegate _downloadDidCancel:]):
4036         (-[DownloadDelegate initWithSourceURL:]): Deleted.
4037         (-[DownloadDelegate sourceURL]): Deleted.
4038         (runTestWithNavigationDelegate): Deleted.
4039
4040 2014-03-26  Anders Carlsson  <andersca@apple.com>
4041
4042         Change MiniBrowser to hold on to window controllers instead of windows
4043         https://bugs.webkit.org/show_bug.cgi?id=130797
4044
4045         Reviewed by Oliver Hunt.
4046
4047         * MiniBrowser/mac/AppDelegate.h:
4048         * MiniBrowser/mac/AppDelegate.m:
4049         (-[BrowserAppDelegate init]):
4050         (-[BrowserAppDelegate newWindow:]):
4051         (-[BrowserAppDelegate browserWindowWillClose:]):
4052         (-[BrowserAppDelegate applicationWillTerminate:]):
4053         (-[BrowserAppDelegate frontmostBrowserWindowController]):
4054
4055 2014-03-26  Commit Queue  <commit-queue@webkit.org>
4056
4057         Unreviewed, rolling out r166264.
4058         https://bugs.webkit.org/show_bug.cgi?id=130785
4059
4060         Broke some window.opener tests for WK2 Mavericks (Requested by
4061         brrian__ on #webkit).
4062
4063         Reverted changeset:
4064
4065         "Web Replay: resource unique identifiers should be unique-per-
4066         frame, not globally"
4067         https://bugs.webkit.org/show_bug.cgi?id=130632
4068         http://trac.webkit.org/changeset/166264
4069
4070 2014-03-26  Zoltan Horvath  <zoltan@webkit.org>
4071
4072         [CSS Shapes] Remove shape-inside support
4073         https://bugs.webkit.org/show_bug.cgi?id=130698
4074
4075         Reviewed by David Hyatt.
4076
4077         * Scripts/webkitperl/FeatureList.pm:
4078
4079 2014-02-27  Gurpreet Kaur  <k.gurpreet@samsung.com>
4080
4081         Unreviewed. Add myself as a committer.
4082
4083         * Scripts/webkitpy/common/config/contributors.json:
4084
4085 2014-03-26  Tomas Popela  <tpopela@redhat.com>
4086
4087         run-launcher is Perl script so use elsif and not elif
4088         https://bugs.webkit.org/show_bug.cgi?id=130771
4089
4090         Reviewed by Carlos Garcia Campos.
4091
4092         * Scripts/run-launcher:
4093
4094 2014-03-26  Krzysztof Czech  <k.czech@samsung.com>
4095
4096         [ATK] Utilize new AtkValue interface coming in ATK 2.11.92
4097         https://bugs.webkit.org/show_bug.cgi?id=130575
4098
4099         Reviewed by Mario Sanchez Prada.
4100
4101         Change ATK version to 2.11.92. Adjust current implementation.
4102
4103         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
4104         (AccessibilityUIElement::intValue):
4105         (AccessibilityUIElement::minValue):
4106         (AccessibilityUIElement::maxValue):
4107         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4108         (WTR::AccessibilityUIElement::intValue):
4109         (WTR::AccessibilityUIElement::minValue):
4110         (WTR::AccessibilityUIElement::maxValue):
4111         * efl/jhbuild.modules:
4112         * gtk/jhbuild.modules:
4113
4114 2014-03-12  Philippe Normand  <pnormand@igalia.com>
4115
4116         [GTK] The gnumake package is no longer needed in jhbuild
4117         https://bugs.webkit.org/show_bug.cgi?id=130121
4118
4119         Reviewed by Martin Robinson.
4120
4121         For GTK build-webkit now relies on cmake and ninja/gnumake. Even
4122         for a debug build cmake/system-gnumake worked just fine for me.
4123
4124         * gtk/jhbuild.modules: Removed gnumake.
4125         * gtk/patches/make-3.82-arg-list-length.patch: Removed.
4126         * gtk/patches/make-3.82-parallel-build.patch: Removed.
4127
4128 2014-03-25  Andy Estes  <aestes@apple.com>
4129
4130         Fix a failing API test on Mountain Lion and remove temporary debug logging.
4131
4132         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
4133         (-[DownloadDelegate _download:didReceiveData:]):
4134         (-[DownloadDelegate _downloadDidFinish:]):
4135
4136 2014-03-25  Brian Burg  <bburg@apple.com>
4137
4138         Web Replay: resource unique identifiers should be unique-per-frame, not globally
4139         https://bugs.webkit.org/show_bug.cgi?id=130623
4140
4141         Reviewed by Timothy Hatcher.
4142
4143         The resource loader callback dumping routines assumed that resource identifiers
4144         were globally unique. Its map of resource identifiers to URLs must also track the
4145         frame associated with the resource.
4146
4147         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4148         (WTR::dumpResourceURL): Additionally take a WKBundleFrameRef argument, and use the
4149         opaque pointer as part of the key for assignedUrlsCache. The frame pointer is
4150         stable as long as the frame is valid.
4151         (WTR::InjectedBundlePage::didInitiateLoadForResource):
4152         (WTR::InjectedBundlePage::willSendRequestForFrame):
4153         (WTR::InjectedBundlePage::didReceiveResponseForResource):
4154         (WTR::InjectedBundlePage::didFinishLoadForResource):
4155         (WTR::InjectedBundlePage::didFailLoadForResource):
4156
4157 2014-03-25  Andy Estes  <aestes@apple.com>
4158
4159         Fix one API test expectation failure on Mountain Lion, and add additional logging to help diagnose another.
4160
4161         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
4162         (-[DownloadDelegate _download:didReceiveResponse:]):
4163         (-[DownloadDelegate _download:didReceiveData:]):
4164
4165 2014-03-25  Andy Estes  <aestes@apple.com>
4166
4167         Add some debug logging to an API test that's failing on Mountain Lion.
4168
4169         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
4170         (-[DownloadDelegate _download:didReceiveResponse:]):
4171         (-[DownloadDelegate _downloadDidFinish:]):
4172
4173 2014-03-25  Anders Carlsson  <andersca@apple.com>
4174
4175         Add goBack: and goForward: IBActions and move stopLoading: to a new WKIBActions category on WKWebView
4176         https://bugs.webkit.org/show_bug.cgi?id=130732
4177
4178         Reviewed by Tim Horton.
4179
4180         * MiniBrowser/mac/WK2BrowserWindowController.m:
4181         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
4182
4183 2014-03-25  Martin Robinson  <mrobinson@igalia.com>
4184
4185         [GTK] Remove the autotools build
4186         https://bugs.webkit.org/show_bug.cgi?id=130717
4187
4188         Reviewed by Anders Carlsson.
4189
4190         * DumpRenderTree/config.h: Remove references to the autotools configure file.
4191         * GNUmakefile.am: Removed.
4192         * GtkLauncher/GNUmakefile.am: Removed.
4193         * GtkLauncher/main.c: Remove references to the autotools configure file.
4194         * MiniBrowser/gtk/BrowserDownloadsBar.c: Ditto.
4195         * MiniBrowser/gtk/BrowserSearchBar.c: Ditto.
4196         * MiniBrowser/gtk/BrowserWindow.c: Ditto.
4197         * MiniBrowser/gtk/GNUmakefile.am: Removed.
4198         * MiniBrowser/gtk/main.c: Remove references to the autotools configure file.
4199         * Scripts/build-webkit: No longer handle autotools.
4200         * Scripts/run-gtk-tests: Ditto.
4201         (TestRunner._setup_testing_environment):
4202         * Scripts/run-launcher: Ditto.
4203         * Scripts/webkitdirs.pm: Ditto.
4204         * Scripts/webkitpy/common/config/contributionareas.py: Remove autotools as a contribution area.
4205         * Scripts/webkitpy/common/config/contributors.json: Ditto.
4206         * Scripts/webkitpy/port/gtk.py: No longer handle autotools.
4207         * Scripts/webkitpy/style/checker.py:
4208         * TestWebKitAPI/GNUmakefile.am: Removed.
4209         * TestWebKitAPI/config.h: Remove references to the autotools configure file.
4210         * WebKitTestRunner/GNUmakefile.am: Removed.
4211         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Ditto.
4212         * gtk/GNUmakefile.am: Removed.
4213         * gtk/common.py: Remove checks for the autotools build.
4214         * gtk/symbols.filter: Renamed from Source/autotools/symbols.filter.
4215
4216 2014-03-25  László Langó  <llango.u-szeged@partner.samsung.com>
4217
4218         prepare-ChangeLog throws false positive warnings for modified files.
4219         https://bugs.webkit.org/show_bug.cgi?id=130687
4220
4221         Reviewed by Darin Adler.
4222
4223         * Scripts/prepare-ChangeLog:
4224         (originalFile): Ignore git commit paremeter.
4225         We don't need this to get the unmodified file.
4226         (extractLineRangeBeforeChange):
4227         Simplify the if statement. Follow-up after r166189.
4228
4229 2014-03-25  Gabor Rapcsanyi  <rgabor@webkit.org>
4230
4231         [EFL] Add ARM64 build support
4232         https://bugs.webkit.org/show_bug.cgi?id=130506
4233
4234         Rubber stamped by Gyuyoung Kim.
4235
4236         * Scripts/webkitdirs.pm:
4237         (isARM): Detect aarch64 as ARM.
4238
4239 2014-03-25  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
4240
4241         [webkitpy] Improve _parse_bug_description to recognize more descriptions
4242         https://bugs.webkit.org/show_bug.cgi?id=130137
4243
4244         Reviewed by Csaba Osztrogonác.
4245
4246         * Scripts/webkitpy/common/checkout/changelog.py:
4247         (ChangeLogEntry._parse_bug_description):
4248         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
4249         (test_parse_log_entries_from_changelog):
4250         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
4251         (CheckoutTest.test_commit_info_for_revision):
4252
4253 2014-03-24  Andy Estes  <aestes@apple.com>
4254
4255         Fix the iOS build of TestWebKitAPI.
4256
4257         * TestWebKitAPI/Configurations/Base.xcconfig:
4258         * TestWebKitAPI/PlatformUtilities.h:
4259
4260 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
4261
4262         Fix prepare-ChangeLog after r166156.
4263         https://bugs.webkit.org/show_bug.cgi?id=130674
4264
4265         Reviewed by Darin Adler.
4266
4267         * Scripts/prepare-ChangeLog:
4268         (generateFunctionLists):
4269         (extractLineRangeBeforeChange):
4270
4271 2014-03-24  Andy Estes  <aestes@apple.com>
4272
4273         [iOS] Download support by CFURLDownloadRef under USE(CFNETWORK).
4274         https://bugs.webkit.org/show_bug.cgi?id=129322
4275
4276         Reviewed by Anders Carlsson.
4277
4278         Add an API test suite for _WKDownload.
4279
4280         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4281         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm: Added.
4282         (-[DownloadDelegate initWithSourceURL:]):
4283         (-[DownloadDelegate sourceURL]):
4284         (-[DownloadDelegate _downloadDidStart:]):
4285         (-[DownloadDelegate _download:didReceiveResponse:]):
4286         (-[DownloadDelegate _download:didReceiveData:]):
4287         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
4288         (-[DownloadDelegate _downloadDidFinish:]):
4289         (TEST):
4290         (runTestWithNavigationDelegate):
4291         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4292         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
4293
4294 2014-03-24  Joseph Pecoraro  <pecoraro@apple.com>
4295
4296         filter-build-webkit: reduce unfiltered output
4297         https://bugs.webkit.org/show_bug.cgi?id=130485
4298
4299         Reviewed by Brent Fulgham.
4300
4301         * Scripts/filter-build-webkit:
4302         (shouldIgnoreLine):
4303
4304 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
4305
4306         prepare-ChangeLog should list functions that have been removed too.
4307         https://bugs.webkit.org/show_bug.cgi?id=130508
4308
4309         Reviewed by Darin Adler.
4310
4311         The prepare-ChangeLog does not list the deleted functions in the Changelog.
4312         We have to read the functions and the line ranges of them from the source
4313         before the change, then search for overlaps between them and the changed
4314         line ranges from diff.
4315
4316         * Scripts/prepare-ChangeLog:
4317         (originalFile): Get original source command.
4318         (generateFunctionLists): Collect deleted functions too.
4319         (generateFunctionListsByRanges): Duplicated code is moved to a separate subroutine.
4320         (extractLineRangeBeforeChange): Extract line ranges from the original source to get
4321         deleted functions ranges too.
4322         (extractLineRange): Renamed to extractLineRangeAfterChange.
4323
4324 2014-03-23  Hyowon Kim  <hw1008.kim@samsung.com>
4325
4326         Move all EFL typedefs into EflTypedefs.h.
4327         https://bugs.webkit.org/show_bug.cgi?id=130511
4328
4329         Reviewed by Gyuyoung Kim.
4330
4331         * TestWebKitAPI/PlatformWebView.h: Remove EFL typedefs.
4332         * WebKitTestRunner/InjectedBundle/TestRunner.h: