WKWebView has no equivalent of -[WebView setAlwaysShowVerticalScroller:]
[WebKit-https.git] / Tools / ChangeLog
1 2017-12-16  Dan Bernstein  <mitz@apple.com>
2
3         WKWebView has no equivalent of -[WebView setAlwaysShowVerticalScroller:]
4         https://bugs.webkit.org/show_bug.cgi?id=180613
5         <rdar://problem/35946124>
6
7         Reviewed by Geoff Garen.
8
9         * MiniBrowser/mac/MainMenu.xib: Added Always Show {Horizontal,Vertical} Scroller menu items
10           to the View menu.
11
12         * MiniBrowser/mac/WK1BrowserWindowController.m:
13         (-[WK1BrowserWindowController validateMenuItem:]): Set the state of the new menu items based
14           on -alwaysShow{Horizontal,Vertical}Scroller.
15         (-[WK1BrowserWindowController toggleAlwaysShowsHorizontalScroller:]): Toggle the value.
16         (-[WK1BrowserWindowController toggleAlwaysShowsVerticalScroller:]): Ditto.
17
18         * MiniBrowser/mac/WK2BrowserWindowController.m:
19         (-[WK2BrowserWindowController validateMenuItem:]): Set the state of the new menu items based
20           on the new property.
21         (-[WK2BrowserWindowController toggleAlwaysShowsHorizontalScroller:]): Toggle the property.
22         (-[WK2BrowserWindowController toggleAlwaysShowsVerticalScroller:]): Ditto.
23
24         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
25         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewAlwaysShowsScroller.mm: Added.
26         (TEST):
27
28 2017-12-16  Basuke Suzuki  <Basuke.Suzuki@sony.com>
29
30         [WinCairo] Move the destination of WinCairoRequirements.zip into WebKitLibraries and register it and related files as git ignore files.
31         https://bugs.webkit.org/show_bug.cgi?id=180875
32
33         Reviewed by Alex Christensen.
34
35         Bug fix. Specify the download destination correctly.
36
37         * Scripts/update-webkit-wincairo-libs.py:
38
39 2017-12-16  Brent Fulgham  <bfulgham@apple.com>
40
41         Plugin processes are repeatedly spun up to do nothing
42         https://bugs.webkit.org/show_bug.cgi?id=180885
43         <rdar://problem/36082564>
44
45         Reviewed by Geoffrey Garen.
46
47         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
48         (runTestWithWebsiteDataStore): Check that deleting website data did not
49         trigger any plugin processes to start up.
50
51 2017-12-16  Yusuke Suzuki  <utatane.tea@gmail.com>
52
53         Remove unnecessary boolean result of start() functions
54         https://bugs.webkit.org/show_bug.cgi?id=180856
55
56         Reviewed by Darin Adler.
57
58         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
59
60 2017-12-15  David Quesada  <david_quesada@apple.com>
61
62         Unreviewed, adding myself to contributors.json
63
64         * Scripts/webkitpy/common/config/contributors.json:
65
66 2017-12-15  Ryan Haddad  <ryanhaddad@apple.com>
67
68         Unreviewed, rolling out r225941.
69
70         This change introduced LayoutTest crashes and assertion
71         failures.
72
73         Reverted changeset:
74
75         "Web Inspector: replace HTMLCanvasElement with
76         CanvasRenderingContext for instrumentation logic"
77         https://bugs.webkit.org/show_bug.cgi?id=180770
78         https://trac.webkit.org/changeset/225941
79
80 2017-12-15  Alex Christensen  <achristensen@webkit.org>
81
82         Introduce SPI _WKWebsitePolicies.websiteDataStore
83         https://bugs.webkit.org/show_bug.cgi?id=180880
84         <rdar://problem/35535328>
85
86         Reviewed by Andy Estes.
87
88         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
89         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
90         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:startURLSchemeTask:]):
91         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:stopURLSchemeTask:]):
92         (TEST):
93
94 2017-12-15  Nael Ouedraogo  <nael.ouedraogo@crf.canon.fr>
95
96         [GTK] Add proxy option to Minibrowser
97         https://bugs.webkit.org/show_bug.cgi?id=180750
98
99         Reviewed by Michael Catanzaro.
100
101         Add command line option to set proxy settings in GTK minibrowser.
102
103         * MiniBrowser/gtk/main.c:
104         (main):
105
106 2017-12-14  Basuke Suzuki  <Basuke.Suzuki@sony.com>
107
108         [webkitpy, Windows] Remove unnecessary debug message
109         https://bugs.webkit.org/show_bug.cgi?id=180844
110
111         Reviewed by Ryosuke Niwa.
112
113         * Scripts/webkitpy/common/system/crashlogs.py:
114         (CrashLogs._find_newest_log_win): Delete debug print
115
116 2017-12-14  David Kilzer  <ddkilzer@apple.com>
117
118         check-webkit-style: Stop warning about underscores in webrtc source
119         <https://webkit.org/b/180848>
120
121         Reviewed by Joseph Pecoraro.
122
123         * Scripts/webkitpy/style/checker.py:
124         (_PATH_RULES_SPECIFIER): Suppress readability/naming/underscores
125         warnings under Source/ThirdParty/libwebrtc/Source/webrtc.
126
127 2017-12-14  Jonathan Bedard  <jbedard@apple.com>
128
129         webkitpy: Replace Version.contained_in with Version.__contains__
130         https://bugs.webkit.org/show_bug.cgi?id=180772
131         <rdar://problem/36033555>
132
133         Reviewed by David Kilzer.
134
135         Using __contains__ instead of contained_in allows for the more
136         Pythonic 'in' operator to be used.
137
138         * Scripts/webkitpy/common/version.py:
139         (Version):
140         (Version.__contains__): Replace contained_in. Note that self is now
141         the container.
142         (Version.contained_in): Deleted.
143         * Scripts/webkitpy/common/version_name_map.py:
144         (VersionNameMap.to_name):
145         * Scripts/webkitpy/common/version_unittest.py:
146         (VersionTestCase.test_contained_in):
147
148 2017-12-14  Ryan Haddad  <ryanhaddad@apple.com>
149
150         Unreviewed, rolling out r225931.
151
152         Breaks internal builds.
153
154         Reverted changeset:
155
156         "Fix Mac CMake build"
157         https://bugs.webkit.org/show_bug.cgi?id=180835
158         https://trac.webkit.org/changeset/225931
159
160 2017-12-14  Devin Rousso  <webkit@devinrousso.com>
161
162         Web Inspector: replace HTMLCanvasElement with CanvasRenderingContext for instrumentation logic
163         https://bugs.webkit.org/show_bug.cgi?id=180770
164
165         Reviewed by Joseph Pecoraro.
166
167         * Scripts/webkitpy/common/config/watchlist:
168
169 2017-12-14  Alexey Proskuryakov  <ap@apple.com>
170
171         Improve leaks detector output
172         https://bugs.webkit.org/show_bug.cgi?id=180828
173
174         Reviewed by Joseph Pecoraro.
175
176         Fixing two issues:
177         1. run-leaks omits many lines from leaks tool output, making it incompatible with
178         other tools. Notably, symbolication cannot be performed.
179         2. run-leaks output goes to "run-webkit-tests --debug-rwt-logging" output. This
180         makes it much longer than needed, sometimes even overloading buildbot. We don't
181         need full output in test log, as separate files are created for each of these.
182
183         * Scripts/run-leaks: Represent each line in leaks output when parsing, and print
184         everything except for explicitly excluded leaks. From my testing and reading
185         the code, it looks like none of our tools should be broken by this change.
186
187         * Scripts/webkitpy/port/leakdetector.py: I couldn't find a way to run a helper tool
188         without dumping all of its output to debug log, so switched to using a file for leaks.
189
190         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:
191         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl:
192         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl:
193         * Scripts/webkitpy/port/leakdetector_unittest.py:
194         Updated tests for new behavior.
195
196 2017-12-14  Brady Eidson  <beidson@apple.com>
197
198         REGRESSION (r225789): API tests WKProcessPool.InitialWarmedProcessUsed and WebKit.WebsiteDataStoreCustomPaths are failing.
199         https://bugs.webkit.org/show_bug.cgi?id=180722
200
201         Reviewed by Chris Dumez.
202
203         * TestWebKitAPI/Tests/WebKitCocoa/InitialWarmedProcessUsed.mm:
204         (TEST):
205
206 2017-12-14  Alex Christensen  <achristensen@webkit.org>
207
208         Fix Mac CMake build
209         https://bugs.webkit.org/show_bug.cgi?id=180835
210
211         Reviewed by Andy Estes.
212
213         * DumpRenderTree/mac/DumpRenderTree.mm:
214         * MiniBrowser/mac/WK1BrowserWindowController.m:
215
216 2017-12-14  Jonathan Bedard  <jbedard@apple.com>
217
218         webkitpy: Better name-version mapping (Follow-up fix)
219         https://bugs.webkit.org/show_bug.cgi?id=179621
220         <rdar://problem/35589585>
221
222         Unreviewed infrastructure fix.
223
224         r225856 caused some undesired logging on Linux and Windows.
225
226         * Scripts/webkitpy/port/mac.py:
227         (MacPort.__init__): Use most recent OS release if not on a Mac.
228         (MacPort.default_baseline_search_path): Make platform explicit.
229         (MacPort.configuration_specifier_macros): Ditto.
230
231 2017-12-14  Carlos Garcia Campos  <cgarcia@igalia.com>
232
233         WebDriver: add a common way to run tests with pytest
234         https://bugs.webkit.org/show_bug.cgi?id=180800
235
236         Reviewed by Carlos Alberto Lopez Perez.
237
238         We currently use pytestrunner from wpt for w3c tests and our own code for selenium tests. Using the same code
239         for both would simplify everything, but also allows us to have a custom results recorder to support other test
240         expectations like TIMEOUT. The code to run selenium tests with pytest has been moved to a new file
241         pytest_runner.py and made generic to be used also for w3c tests.
242
243         * Scripts/webkitpy/webdriver_tests/pytest_runner.py: Added.
244         (TemporaryDirectory):
245         (TemporaryDirectory.__enter__):
246         (TemporaryDirectory.__exit__):
247         (CollectRecorder):
248         (CollectRecorder.__init__):
249         (CollectRecorder.pytest_collectreport):
250         (HarnessResultRecorder):
251         (HarnessResultRecorder.__init__):
252         (HarnessResultRecorder.pytest_collectreport):
253         (SubtestResultRecorder):
254         (SubtestResultRecorder.__init__):
255         (SubtestResultRecorder.pytest_runtest_logreport):
256         (SubtestResultRecorder._was_timeout):
257         (SubtestResultRecorder.record_pass):
258         (SubtestResultRecorder.record_fail):
259         (SubtestResultRecorder.record_error):
260         (SubtestResultRecorder.record_skip):
261         (SubtestResultRecorder.record):
262         (collect):
263         (run):
264         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
265         (do_delayed_imports): Import pytest_runner here to avoid cycles.
266         (WebDriverSeleniumExecutor.__init__): Save the driver parameter as args member and call do_delayed_imports() if
267         needed.
268         (WebDriverSeleniumExecutor.collect): Use pytest_runner.
269         (WebDriverSeleniumExecutor.run): Ditto.
270         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
271         (WebDriverTestRunner.print_results): Handle all possible tests results.
272         (WebDriverTestRunner.print_results.report): Helper to dump test results.
273         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
274         (WebDriverTestRunnerSelenium.run):
275         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
276         (WebDriverTestRunnerW3C.__init__): Do not set PYTEST_TIMEOUT env var.
277         (WebDriverTestRunnerW3C._is_test): Fix check for support files.
278         (WebDriverTestRunnerW3C.run): Pass the timeout as parameter to WebDriverW3CExecutor.run().
279         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
280         (do_delayed_imports): Import pytest_runner here to avoid cycles.
281         (WebDriverW3CExecutor.__init__): Call do_delayed_imports() if needed.
282         (WebDriverW3CExecutor.run): Use pytest_runner.
283
284 2017-12-13  Matt Lewis  <jlewis3@apple.com>
285
286         Unreviewed, rolling out r225864.
287
288         This caused the Layout test step to crash out on Debug testers
289
290         Reverted changeset:
291
292         "REGRESSION (r225789): API tests
293         WKProcessPool.InitialWarmedProcessUsed and
294         WebKit.WebsiteDataStoreCustomPaths are failing."
295         https://bugs.webkit.org/show_bug.cgi?id=180722
296         https://trac.webkit.org/changeset/225864
297
298 2017-12-13  Youenn Fablet  <youenn@apple.com>
299
300         Update ContentFiltering.LazilyLoadPlatformFrameworks test to account for libwebrtc using VideoProcessing framework
301         https://bugs.webkit.org/show_bug.cgi?id=180713
302         <rdar://problem/36003031>
303
304         Reviewed by Andy Estes.
305
306         Reenable the check for non High Sierra builds.
307
308         * TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.mm:
309         (-[LazilyLoadPlatformFrameworksController expectParentalControlsLoaded:networkExtensionLoaded:]):
310
311 2017-12-13  Brady Eidson  <beidson@apple.com>
312
313         REGRESSION (r225789): API tests WKProcessPool.InitialWarmedProcessUsed and WebKit.WebsiteDataStoreCustomPaths are failing.
314         https://bugs.webkit.org/show_bug.cgi?id=180722
315
316         Reviewed by Chris Dumez.
317
318         * TestWebKitAPI/Tests/WebKitCocoa/InitialWarmedProcessUsed.mm:
319         (TEST): Call a new SPI to get the count of WebProcesses hosting WebPages.
320
321 2017-12-13  Mark Lam  <mark.lam@apple.com>
322
323         Fill out some Poisoned APIs, fix some bugs, and add some tests.
324         https://bugs.webkit.org/show_bug.cgi?id=180724
325         <rdar://problem/36006884>
326
327         Reviewed by JF Bastien.
328
329         * TestWebKitAPI/CMakeLists.txt:
330         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
331         * TestWebKitAPI/Tests/WTF/ConstExprPoisoned.cpp: Added.
332         (TestWebKitAPI::TEST):
333         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Added.
334         (TestWebKitAPI::initializeTestPoison):
335         (TestWebKitAPI::TEST):
336
337 2017-12-13  Jonathan Bedard  <jbedard@apple.com>
338
339         webkitpy: Better name-version mapping (Part 2)
340         https://bugs.webkit.org/show_bug.cgi?id=179621
341         <rdar://problem/35589585>
342
343         Reviewed by David Kilzer.
344
345         Now that we have a central mapping of version numbers to version names, this
346         mapping should be used to compute version names. This patch treats passes versions
347         as objects, only mapping them to names when strings are needed.
348
349         * Scripts/webkitpy/common/system/platforminfo.py:
350         (PlatformInfo.__init__): Store os_version as a version object instead of a string.
351         (PlatformInfo.os_version_name): Convert os_version to a string through the VersionNameMap.
352         * Scripts/webkitpy/common/system/platforminfo_mock.py:
353         (MockPlatformInfo.__init__): Store os_version as a version object.
354         (MockPlatformInfo.os_version_name): Mirror PlatformInfo.
355         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
356         (TestPlatformInfo.test_real_code): Only Mac and Windows have defined version objects.
357         (TestPlatformInfo.test_os_version): Deleted, this behavior is now managed by VersionNameMap.
358         * Scripts/webkitpy/common/version.py:
359         (Version.__cmp__): Allow a version object to be compared with 'None'.
360         * Scripts/webkitpy/common/version_name_map.py:
361         (VersionNameMap.map): Check for the apple_additions VersionNameMap.
362         (VersionNameMap.__init__): Add a wincairo mapping, the same as the win mapping.
363         * Scripts/webkitpy/common/version_unittest.py:
364         (VersionTestCase.test_compare_versions): Test comparing a version object to 'None'.
365         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
366         (TestConfiguration.__init__): Strip formatting from version name. Note that this object still
367         accepts a string because the version string implicitly contains the platform as well.
368         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Win7 should be 7SP0 as
369         it is in the VersionNameMap.
370         * Scripts/webkitpy/port/apple.py:
371         (ApplePort): Replace VERSION_FALLBACK_ORDER with a minimum and maximum version. This is required
372         because it may be the case that scripts are aware of more versions than the port actually supports.
373         (ApplePort.determine_full_port_name): Use the host operating system to compute the full port name.
374         (ApplePort._allowed_versions): Return a list of valid port versions by iterating through the
375         VersionNameMap.
376         (ApplePort._generate_all_test_configurations): Compute a list of configurations by iterating through
377         _allowed_versions and converting each version to a string.
378         (ApplePort._apple_baseline_path): Return a layout test expectation directory inside apple_additions.
379         (ApplePort._skipped_file_search_paths): Deleted.
380         (ApplePort._allowed_port_names): Deleted.
381         (ApplePort._future_port_name): Deleted.
382         * Scripts/webkitpy/port/base.py:
383         (Port.__init__): Replace _version string with _os_version object.
384         (Port.version_name): Convert version object to string.
385         (Port.test_configuration): Pass version string to TestConfiguration.
386         (Port.version): Deleted.
387         * Scripts/webkitpy/port/darwin_testcase.py:
388         (DarwinTest.assert_name): Convert an os_version_string to a version object and construct a port.
389         * Scripts/webkitpy/port/factory_unittest.py:
390         (FactoryTest.test_mac): Replace version strings with version objects.
391         (FactoryTest.test_win): Ditto.
392         * Scripts/webkitpy/port/gtk.py:
393         (GtkPort._generate_all_test_configurations): Replace _version with version_name().
394         * Scripts/webkitpy/port/ios.py:
395         (IOSPort.version_name): Both Simulator and device share the same version-name convention.
396         (IOSPort._generate_all_test_configurations): Replace _version with version_name().
397         (IOSPort.default_baseline_search_path): Use the internal mapping of version names to construct
398         apple_additions expectations.
399         (IOSPort._apple_additions_path): Deleted.
400         * Scripts/webkitpy/port/ios_device.py:
401         (IOSDevicePort.ios_version): Return None if no version is defined.
402         * Scripts/webkitpy/port/ios_device_unittest.py:
403         (IOSDeviceTest):
404         (IOSDeviceTest.test_layout_test_searchpath_with_apple_additions): Conform with the new mock
405         apple_additions.
406         (IOSDeviceTest.make_port): Deleted.
407         * Scripts/webkitpy/port/ios_simulator.py:
408         (IOSSimulatorPort._create_devices): Use Version object over list of version strings.
409         * Scripts/webkitpy/port/ios_simulator_unittest.py:
410         (IOSSimulatorTest):
411         (IOSSimulatorTest.make_port): Use iOS 11 as the default version for testing.
412         (IOSSimulatorTest.test_layout_test_searchpath_with_apple_additions): Conform with the new
413         mock apple_additions.
414         * Scripts/webkitpy/port/ios_testcase.py:
415         (IOSTest.make_port): Use iOS 11 as the default version for testing.
416         * Scripts/webkitpy/port/mac.py:
417         (MacPort):
418         (MacPort.__init__): Use Version object for _os_version.
419         (MacPort.default_baseline_search_path): Use the internal mapping of version names to construct
420         apple_additions expectations.
421         (MacPort.configuration_specifier_macros): Automatically construct macros based on VersionNameMap.
422         (MacPort._apple_additions_path): Deleted.
423         * Scripts/webkitpy/port/mac_unittest.py:
424         (MacTest): Use Version object instead of version string.
425         (MacTest.test_version):
426         * Scripts/webkitpy/port/port_testcase.py:
427         (bind_mock_apple_additions): Add a mock VersionNameMap to mock apple_additions.
428         (bind_mock_apple_additions.MockAppleAdditions):
429         (bind_mock_apple_additions.MockAppleAdditions.version_name_mapping):
430         * Scripts/webkitpy/port/test.py:
431         (TestPort):
432         (TestPort.__init__): Use VersionNameMap to compute the correct Version from a port name.
433         (TestPort.version_name): Mirror Port object.
434         (TestPort.baseline_search_path): Replace win7 with 7sp0.
435         (TestPort._all_systems): Ditto.
436         (TestPort.configuration_specifier_macros): Ditto.
437         * Scripts/webkitpy/port/win.py:
438         (WinPort):
439         (WinPort.__init__): Construct Version object from port name.
440         (WinPort.default_baseline_search_path): Use the internal mapping of version names to construct
441         apple_additions expectations.
442         (WinCairoPort):
443         (WinCairoPort.default_baseline_search_path): Use MIN/MAX instead of the VERSION_FALLBACK_ORDER.
444         (WinCairoPort._future_port_name): Deleted.
445         * Scripts/webkitpy/port/win_unittest.py:
446         (WinPortTest.test_baseline_search_path): Add new Windows versions not previously included.
447         (WinPortTest._assert_version): Handle expected_version as a Version object.
448         (WinPortTest.test_versions): Pass Version objects instead of version strings.
449         * Scripts/webkitpy/port/wpe.py:
450         (WPEPort._generate_all_test_configurations): Replace _version with version_name().
451         * Scripts/webkitpy/tool/commands/queries_unittest.py:
452         (PrintExpectationsTest.test_multiple): Replace win7 with 7sp0.
453         (PrintBaselinesTest.test_multiple): Ditto.
454         * Scripts/webkitpy/tool/commands/queues.py:
455         (PatchProcessingQueue._new_port_name_from_old): Use os_version_name() instead of Version object.
456
457 2017-12-12  Daniel Bates  <dabates@apple.com>
458
459         [WK] Add modern WebKit SPI to set auto fill button type and query if the auto fill button is enabled
460         https://bugs.webkit.org/show_bug.cgi?id=180686
461
462         Reviewed by Alex Christensen.
463
464         * TestWebKitAPI/Tests/WebKitCocoa/ClickAutoFillButton.mm:
465         (-[ClickAutoFillButton webProcessPlugIn:didCreateBrowserContextController:]):
466
467 2017-12-12  Alex Christensen  <achristensen@webkit.org>
468
469         Fix possible out-of-bounds read in protocolIsInHTTPFamily
470         https://bugs.webkit.org/show_bug.cgi?id=180688
471
472         Reviewed by Daniel Bates.
473
474         * TestWebKitAPI/Tests/WebCore/URL.cpp:
475         (TestWebKitAPI::TEST_F):
476
477 2017-12-12  JF Bastien  <jfbastien@apple.com>
478
479         makeString: support more integral types
480         https://bugs.webkit.org/show_bug.cgi?id=180720
481
482         Reviewed by Sam Weinig.
483
484         Test a few more types can be made string'd.
485
486         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
487         (TestWebKitAPI::TEST):
488
489 2017-12-12  Alicia Boya García  <aboya@igalia.com>
490
491         Flakiness dashboard: Make GTK and WPE builds inherit expectations from WK2
492         https://bugs.webkit.org/show_bug.cgi?id=178782
493
494         Reviewed by Michael Catanzaro.
495
496         * TestResultServer/static-dashboards/flakiness_dashboard.js:
497
498 2017-12-12  Jonathan Bedard  <jbedard@apple.com>
499
500         MobileMiniBrowser using the wrong toolchain
501         https://bugs.webkit.org/show_bug.cgi?id=180716
502         <rdar://problem/36002951>
503
504         Reviewed by Tim Horton.
505
506         Move Debug/Release configurations from xcodeproj into Base.xcconfig.
507
508         * MobileMiniBrowser/Configurations/Base.xcconfig:
509         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
510
511 2017-12-12  Youenn Fablet  <youenn@apple.com>
512
513         Update ContentFiltering.LazilyLoadPlatformFrameworks test to account for libwebrtc using VideoProcessing framework
514         https://bugs.webkit.org/show_bug.cgi?id=180713
515
516         Reviewed by Andy Estes.
517
518         Temporarily disabling a subcheck until we make the test more robust and/or libwebrtc weak linking VideoProcessing framework.
519
520         * TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.mm:
521         (-[LazilyLoadPlatformFrameworksController expectParentalControlsLoaded:networkExtensionLoaded:]):
522
523 2017-12-12  Caio Lima  <ticaiolima@gmail.com>
524
525         [ESNext][BigInt] Implement BigInt literals and JSBigInt
526         https://bugs.webkit.org/show_bug.cgi?id=179000
527
528         Reviewed by Darin Adler and Yusuke Suzuki.
529
530         * Scripts/run-jsc-stress-tests:
531
532 2017-12-12  Carlos Alberto Lopez Perez  <clopez@igalia.com>
533
534         [GTK][WPE] Bump GStreamer version to 1.12 in jhbuild
535         https://bugs.webkit.org/show_bug.cgi?id=171677
536
537         Reviewed by Carlos Garcia Campos.
538
539         Bump gstreamer related modules and rebase patches still needed and not merged
540
541         * gstreamer/jhbuild.modules:
542         * gstreamer/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Removed. This was needed for OpenWebRTC. Not longer supported.
543         * gstreamer/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Rebased.
544         * gstreamer/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Rebased.
545         * gstreamer/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Rebased.
546         * gstreamer/patches/gst-plugins-good-0009-qtdemux-fix-assert-when-moof-contains-one-sample.patch: Added a note about merge commit not still in 1.12.4.
547
548 2017-12-12  Yusuke Suzuki  <utatane.tea@gmail.com>
549
550         [WTF] Thread::create should have Thread::tryCreate
551         https://bugs.webkit.org/show_bug.cgi?id=180333
552
553         Reviewed by Darin Adler.
554
555         * TestWebKitAPI/Tests/WTF/Condition.cpp:
556         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
557         * TestWebKitAPI/Tests/WTF/Signals.cpp:
558         (TEST):
559         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
560         (TestWebKitAPI::testThreadGroup):
561         (TestWebKitAPI::TEST):
562
563 2017-12-11  Basuke Suzuki  <Basuke.Suzuki@sony.com>
564
565         [WinCairo] Enable running sharded tests
566         https://bugs.webkit.org/show_bug.cgi?id=180660
567
568         Reviewed by Alex Christensen.
569
570         The sharder splits the test inputs into groups of test based on the directory, 
571         but separation of base name and directory name was wrong because of this bug.
572         Once sharded correctly, the execution of layout test on native Windows environment
573         is in parallel and much less time to run.
574
575         * Scripts/webkitpy/port/win.py:
576         (WinCairoPort):
577
578 2017-12-11  Fujii Hironori  <Hironori.Fujii@sony.com>
579
580         [WinCairo] DLLLauncherMain should use SetDllDirectory
581         https://bugs.webkit.org/show_bug.cgi?id=180642
582
583         Reviewed by Alex Christensen.
584
585         Windows have icuuc.dll in the system directory. WebKit should find
586         one in WebKitLibraries directory, not one in the system directory.
587
588         * win/DLLLauncher/DLLLauncherMain.cpp:
589         (modifyPath): Use SetDllDirectory for WebKitLibraries directory instead of modifying path.
590         Do not add a path for GStreamer because nobody is using now.
591
592 2017-12-11  David Quesada  <david_quesada@apple.com>
593
594         Turn on ENABLE_APPLICATION_MANIFEST
595         https://bugs.webkit.org/show_bug.cgi?id=180562
596         rdar://problem/35924737
597
598         Reviewed by Geoffrey Garen.
599
600         * Configurations/FeatureDefines.xcconfig:
601
602 2017-12-11  Zan Dobersek  <zdobersek@igalia.com>
603
604         Unreviewed, rolling out r225737.
605
606         Breaks Git clones of the repository, including EWSs and webkitbot.
607
608         Reverted changeset:
609
610         "Add a script to automate W3c web-platform-tests pull request
611         creations from WebKit commits"
612         https://bugs.webkit.org/show_bug.cgi?id=169462
613         https://trac.webkit.org/changeset/225737
614
615 2017-12-11  Carlos Garcia Campos  <cgarcia@igalia.com>
616
617         [GTK] WebDriver: run-webdriver-tests is leaking a DumpRenderTree directory in tmp
618         https://bugs.webkit.org/show_bug.cgi?id=180426
619
620         Reviewed by Michael Catanzaro.
621
622         This happens when running the tests with Xvfb driver, because _setup_environ_for_test() is called twice and the
623         DTR temp directory is created there every time. Only the last directory created is cleaned up by the driver
624         destructor. The DRT temp directory is only needed for layout tests, so we could even avoid its creation by
625         moving it to the start() method like other drivers do (included the base driver implementation). Since API and
626         WebDriver tests don't call start(), the directory is not even created, and the required env vars are not set
627         either in that case. Weston driver was behaving differently for some reason, it's now consistent with all other
628         drivers.
629
630         * Scripts/webkitpy/port/headlessdriver.py:
631         (HeadlessDriver._setup_environ_for_test): Do not set DUMPRENDERTREE_TEMP and XDG_CACHE_HOME if _driver_tempdir is None.
632         (HeadlessDriver._start): Use Port._driver_tempdir() to create the driver temp directory.
633         * Scripts/webkitpy/port/waylanddriver.py:
634         (WaylandDriver._setup_environ_for_test): Do not set DUMPRENDERTREE_TEMP and XDG_CACHE_HOME if _driver_tempdir is None.
635         (WaylandDriver._start): Use Port._driver_tempdir() to create the driver temp directory.
636         * Scripts/webkitpy/port/westondriver.py:
637         (WestonDriver._setup_environ_for_test): Do not set DUMPRENDERTREE_TEMP and XDG_CACHE_HOME if _driver_tempdir is None.
638         (WestonDriver._start): Use Port._driver_tempdir() to create the driver temp directory.
639         (WestonDriver.stop): Do not delete the temp directory, it's done by the parent class.
640         (WestonDriver._ensure_driver_tmpdir_subdirectory): Deleted.
641         * Scripts/webkitpy/port/westondriver_unittest.py:
642         (WestonDriverTest.make_driver):
643         (WestonDriverTest.test_stop):
644         * Scripts/webkitpy/port/xorgdriver.py:
645         (XorgDriver._setup_environ_for_test): Do not set DUMPRENDERTREE_TEMP and XDG_CACHE_HOME if _driver_tempdir is None.
646         (XorgDriver._start): Use Port._driver_tempdir() to create the driver temp directory.
647         * Scripts/webkitpy/port/xvfbdriver.py:
648         (XvfbDriver._setup_environ_for_test): Do not set DUMPRENDERTREE_TEMP and XDG_CACHE_HOME if _driver_tempdir is None.
649         (XvfbDriver._start): Use Port._driver_tempdir() to create the driver temp directory.
650
651 2017-12-10  Zan Dobersek  <zdobersek@igalia.com>
652
653         Unreviewed webkitpy fix on Linux platforms after r225721.
654
655         Add an empty 'linux' entry to the PUBLIC_TABLE mapping in the
656         VersionNameMap class. This avoids asserting in this class's
657         mapping_for_platform() method when the code is evaluated on a Linux
658         system, which happens when the static VERSION_FALLBACK_ORDER member in
659         the WinCairoPort class is constructed. This can occur during a
660         test-webkitpy run or when trying to construct a WPEPort instance in
661         PortFactory, which isn't possible because again the WinCairoPort
662         instance is constructed first, leading to the same assert in both cases.
663
664         * Scripts/webkitpy/common/version_name_map.py:
665         (VersionNameMap.__init__):
666
667 2017-12-10  Youenn Fablet  <youenn@apple.com>
668
669         Add a script to automate W3c web-platform-tests pull request creations from WebKit commits
670         https://bugs.webkit.org/show_bug.cgi?id=169462
671
672         Reviewed by Darin Adler.
673
674         Adding some git helper routines used by WPT exporter.
675         Copying WPT github utility files from Chromium.
676         Updating web.py/web_mock.py to cope with these new files.
677
678         Implementing test exporter in test_exporter.py.
679         This script takes a WebKit commit as input and will create a WPT commit in a local WPT clone.
680         It will then push the commit to a public GitHub repository identified by a username parameter.
681         This parameter is passed through the command line or searched through git config/environment variables.
682
683         The script can optionally create a pull request to the official WPT GitHub repository.
684         User must provide a GitHub token to allow the script to make the PR on behalf of the user.
685         In that case, a comment is added to the corresponding bugzilla if a bug ID is given or can be found from the change log,
686         to easily link the pull request with the bugzilla bug.
687
688         * Scripts/export-w3c-test-changes: Added.
689         * Scripts/webkitpy/common/checkout/scm/git.py:
690         (Git.reset_hard):
691         (Git):
692         (Git.am):
693         (Git.commit):
694         (Git.format_patch):
695         (Git.request_pull):
696         (Git.remote):
697         (Git.push):
698         (Git.checkout_new_branch):
699         * Scripts/webkitpy/common/net/web.py:
700         (Web.request): Copied from Chromium.
701         * Scripts/webkitpy/common/net/web_mock.py: Copied needed code from Chromium.
702         * Scripts/webkitpy/w3c/test_exporter.py: Added.
703         (TestExporter):
704         (TestExporter.__init__):
705         (TestExporter._init_repository):
706         (TestExporter.download_and_commit_patch):
707         (TestExporter.clean):
708         (TestExporter.create_branch_with_patch):
709         (TestExporter.push_to_public_repository):
710         (TestExporter.make_pull_request):
711         (TestExporter.delete_local_branch):
712         (TestExporter.create_git_patch):
713         (TestExporter.create_upload_remote_if_needed):
714         (TestExporter.do_export):
715         (parse_args):
716         (configure_logging):
717         (configure_logging.LogHandler):
718         (configure_logging.LogHandler.format):
719         (main):
720         * Scripts/webkitpy/w3c/test_exporter_unittest.py: Added.
721         (TestExporterTest):
722         (TestExporterTest.MockBugzilla):
723         (TestExporterTest.MockBugzilla.__init__):
724         (TestExporterTest.MockBugzilla.fetch_bug_dictionary):
725         (TestExporterTest.MockBugzilla.post_comment_to_bug):
726         (TestExporterTest.MockGit):
727         (TestExporterTest.MockGit.clone):
728         (TestExporterTest.MockGit.__init__):
729         (TestExporterTest.MockGit.fetch):
730         (TestExporterTest.MockGit.checkout):
731         (TestExporterTest.MockGit.reset_hard):
732         (TestExporterTest.MockGit.push):
733         (TestExporterTest.MockGit.format_patch):
734         (TestExporterTest.MockGit.delete_branch):
735         (TestExporterTest.MockGit.checkout_new_branch):
736         (TestExporterTest.MockGit.am):
737         (TestExporterTest.MockGit.commit):
738         (TestExporterTest.MockGit.remote):
739         (TestExporterTest.test_export):
740         * Scripts/webkitpy/w3c/common.py: Copied from chromium.
741         * Scripts/webkitpy/w3c/wpt_github.py: Copied from chromium.
742         * Scripts/webkitpy/w3c/wpt_github_mock.py: Copied from chromium.
743         * Scripts/webkitpy/w3c/wpt_github_unittest.py: Copied from chromium.
744
745 2017-12-10  Konstantin Tokarev  <annulen@yandex.ru>
746
747         [python] Modernize "except" usage for python3 compatibility
748         https://bugs.webkit.org/show_bug.cgi?id=180612
749
750         Reviewed by Michael Catanzaro.
751
752         * BuildSlaveSupport/build.webkit.org-config/committer_auth.py:
753         (CommitterAuth.auth_json):
754         (CommitterAuth.authenticate):
755         (CommitterAuth.is_webkit_committer):
756         (CommitterAuth.is_webkit_trac_user):
757         * BuildSlaveSupport/wait-for-SVN-server.py:
758         (getLatestSVNRevision):
759         * QueueStatusServer/handlers/updatebase.py:
760         (UpdateBase._int_from_request):
761         * Scripts/webkitpy/bindings/main.py:
762         (BindingsTests.generate_from_idl):
763         (BindingsTests.generate_supplemental_dependency):
764         (BindingsTests.detect_changes):
765         * Scripts/webkitpy/codegen/main.py:
766         (BuiltinsGeneratorTests.generate_from_js_builtins):
767         (BuiltinsGeneratorTests.detect_changes):
768         * Scripts/webkitpy/common/checkout/changelog.py:
769         (ChangeLog.parse_latest_entry_from_file):
770         * Scripts/webkitpy/common/checkout/checkout.py:
771         (Checkout.bug_id_for_this_commit):
772         * Scripts/webkitpy/common/checkout/scm/git.py:
773         (Git.in_working_directory):
774         (Git.clone):
775         (Git._string_to_int_or_none):
776         (Git._commit_on_branch):
777         * Scripts/webkitpy/common/checkout/scm/svn.py:
778         (SVN.revisions_changing_file):
779         * Scripts/webkitpy/common/config/committers.py:
780         (CommitterList.load_json):
781         * Scripts/webkitpy/common/message_pool.py:
782         (_Worker.run):
783         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
784         (Builder.force_build.predicate):
785         (Builder._fetch_revision_to_build_map):
786         (BuildBot._fetch_build_dictionary):
787         * Scripts/webkitpy/common/net/credentials.py:
788         (Credentials._credentials_from_git):
789         * Scripts/webkitpy/common/net/networktransaction.py:
790         (NetworkTransaction.run):
791         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
792         (NetworkTransactionTest.test_exception):
793         (NetworkTransactionTest.test_timeout):
794         * Scripts/webkitpy/common/net/statusserver.py:
795         (StatusServer._fetch_url):
796         * Scripts/webkitpy/common/net/unittestresults.py:
797         (UnitTestResults.results_from_string):
798         * Scripts/webkitpy/common/prettypatch.py:
799         (PrettyPatch.check_pretty_patch):
800         (PrettyPatch.pretty_patch_text):
801         * Scripts/webkitpy/common/prettypatch_unittest.py:
802         (PrettyPatchTest.check_ruby):
803         * Scripts/webkitpy/common/system/autoinstall.py:
804         (AutoInstaller._extract_tar):
805         (AutoInstaller._unzip):
806         (AutoInstaller._replace_domain_with_next_mirror):
807         (AutoInstaller._download_to_stream):
808         (AutoInstaller.install):
809         * Scripts/webkitpy/common/system/crashlogs.py:
810         (CrashLogs._find_newest_log_darwin):
811         (CrashLogs._find_newest_log_win):
812         (CrashLogs._find_all_logs_darwin):
813         * Scripts/webkitpy/common/system/executive.py:
814         (Executive.kill_process):
815         (Executive.running_pids):
816         * Scripts/webkitpy/common/system/filesystem.py:
817         (FileSystem.maybe_make_directory):
818         (FileSystem.remove):
819         * Scripts/webkitpy/common/system/user.py:
820         (User._wait_on_list_response):
821         (User.edit):
822         (User.page):
823         (User.can_open_url):
824         * Scripts/webkitpy/common/system/workspace.py:
825         (Workspace.create_zip):
826         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
827         (WatchListParser._parse_definition_section):
828         * Scripts/webkitpy/common/webkitunittest.py:
829         (TestCase._assertRaisesRegexp):
830         * Scripts/webkitpy/inspector/main.py:
831         (InspectorGeneratorTests.generate_from_json):
832         (InspectorGeneratorTests.detect_changes):
833         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
834         (LayoutTestFinder._read_test_names_from_file):
835         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
836         (LayoutTestRunner.run_tests):
837         * Scripts/webkitpy/layout_tests/controllers/manager.py:
838         (Manager.upload_results):
839         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
840         (JSONResultsGenerator.upload_json_files):
841         (JSONResultsGenerator._get_archived_json_results):
842         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
843         (MiscTests.test_parse_warning):
844         (SemanticTests.test_bad_bugid):
845         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
846         (summarize_results):
847         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
848         (main):
849         * Scripts/webkitpy/layout_tests/servers/http_server.py:
850         (Lighttpd._remove_stale_logs):
851         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
852         (HttpServerBase._is_running_on_port):
853         (HttpServerBase._check_that_all_ports_are_available):
854         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
855         (BaseTest.assert_servers_are_down):
856         (BaseTest.assert_servers_are_up):
857         (BaseTest.integration_test_server__fails):
858         (BaseTest.maybe_make_dir):
859         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
860         (run_server):
861         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
862         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
863         (PyWebSocket.is_running):
864         (PyWebSocket._remove_stale_logs):
865         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
866         (_merge_slave_config_json):
867         (_merge_outputs_if_needed):
868         (_upload_json):
869         * Scripts/webkitpy/port/base.py:
870         (Port._build_driver):
871         (Port._build_image_diff):
872         (Port._symbols_string):
873         * Scripts/webkitpy/port/leakdetector.py:
874         (LeakDetector.count_total_bytes_and_unique_leaks):
875         (LeakDetector.check_for_leaks):
876         * Scripts/webkitpy/port/leakdetector_valgrind.py:
877         (LeakDetectorValgrind._parse_leaks_output):
878         * Scripts/webkitpy/port/mac.py:
879         (MacPort.reset_preferences):
880         (MacPort.stop_helper):
881         * Scripts/webkitpy/port/port_testcase.py:
882         (PortTestCase.assert_servers_are_down):
883         (PortTestCase.assert_servers_are_up):
884         (PortTestCase.integration_test_http_server__fails):
885         (PortTestCase.integration_test_websocket_server__fails):
886         * Scripts/webkitpy/port/server_process.py:
887         (ServerProcess.write):
888         (ServerProcess._wait_for_data_and_update_buffers_using_select):
889         (ServerProcess._non_blocking_read_win32):
890         * Scripts/webkitpy/port/win.py:
891         (WinPort._runtime_feature_list):
892         * Scripts/webkitpy/port/xvfbdriver.py:
893         (XvfbDriver._xvfb_read_display_id):
894         * Scripts/webkitpy/style/checkers/jsonchecker.py:
895         (JSONChecker.check):
896         * Scripts/webkitpy/style/checkers/xml.py:
897         (XMLChecker.check):
898         * Scripts/webkitpy/style/filereader.py:
899         (TextFileReader.process_file):
900         * Scripts/webkitpy/style/filereader_unittest.py:
901         (TextFileReaderTest.test_process_file__does_not_exist):
902         * Scripts/webkitpy/style/optparser.py:
903         (ArgumentParser.parse):
904         * Scripts/webkitpy/tool/bot/irc_command.py:
905         (CreateBug.execute):
906         (Rollout.execute):
907         * Scripts/webkitpy/tool/bot/ircbot.py:
908         (IRCBot.process_message):
909         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
910         (LayoutTestResultsReader._read_file_contents):
911         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
912         (PatchAnalysisTask._run_command):
913         * Scripts/webkitpy/tool/bot/queueengine.py:
914         (QueueEngine.run):
915         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
916         (AbstractSequencedCommand.execute):
917         * Scripts/webkitpy/tool/commands/download.py:
918         (AbstractPatchSequencingCommand._prepare_to_process):
919         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
920         (AbstractEarlyWarningSystem.review_patch):
921         * Scripts/webkitpy/tool/commands/queries.py:
922         (FailureReason._blame_line_for_revision):
923         * Scripts/webkitpy/tool/commands/queues.py:
924         (AbstractQueue._cc_watchers):
925         (AbstractQueue.run_webkit_patch):
926         (CommitQueue.process_work_item):
927         (StyleQueue.review_patch):
928         * Scripts/webkitpy/tool/commands/rebaseline.py:
929         (AbstractParallelRebaselineCommand._run_webkit_patch):
930         * Scripts/webkitpy/tool/commands/stepsequence.py:
931         (StepSequence.run_and_handle_errors):
932         * Scripts/webkitpy/tool/commands/suggestnominations.py:
933         (SuggestNominations._count_recent_patches):
934         * Scripts/webkitpy/tool/multicommandtool.py:
935         (MultiCommandTool.main):
936         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
937         (_rebaseline_test):
938         (_move_test_baselines):
939         * Scripts/webkitpy/tool/steps/addsvnmimetypeforpng_unittest.py:
940         (AddSvnMimetypeForPngTest.test_run):
941         * Scripts/webkitpy/tool/steps/checkstyle.py:
942         (CheckStyle.run):
943         * Scripts/webkitpy/tool/steps/commit.py:
944         (Commit._check_test_expectations):
945         (Commit.run):
946         * Scripts/webkitpy/tool/steps/confirmdiff.py:
947         (ConfirmDiff._show_pretty_diff):
948         * Scripts/webkitpy/tool/steps/haslanded.py:
949         (HasLanded.diff_diff):
950         * Scripts/webkitpy/tool/steps/preparechangelog.py:
951         (PrepareChangeLog.run):
952         * Scripts/webkitpy/tool/steps/promptforbugortitle.py:
953         (PromptForBugOrTitle.run):
954         * Scripts/webkitpy/tool/steps/sortxcodeprojectfiles.py:
955         (SortXcodeProjectFiles.run):
956         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
957         (WebDriverW3CWebServer._wait_for_server.check_port):
958         * TestResultServer/model/datastorefile.py:
959         (DataStoreFile.save_data):
960         * jhbuild/jhbuildutils.py:
961         (enter_jhbuild_environment_if_available):
962
963 2017-12-09  Yusuke Suzuki  <utatane.tea@gmail.com>
964
965         Fix WTF::Hasher tuple expansion with variadic args
966         https://bugs.webkit.org/show_bug.cgi?id=180623
967
968         Reviewed by JF Bastien.
969
970         * TestWebKitAPI/Tests/WTF/Hasher.cpp:
971         (TestWebKitAPI::TEST):
972
973 2017-12-09  Konstantin Tokarev  <annulen@yandex.ru>
974
975         [python] Replace print >> operator with print() function for python3 compatibility
976         https://bugs.webkit.org/show_bug.cgi?id=180611
977
978         Reviewed by Michael Catanzaro.
979
980         * CygwinDownloader/cygwin-downloader.py:
981         (download_url_to_file):
982         * Scripts/webkitpy/common/system/profiler.py:
983         (Perf.profile_after_exit):
984         * Scripts/webkitpy/common/version_check.py:
985         * Scripts/webkitpy/layout_tests/lint_test_expectations.py:
986         (main):
987         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
988         (main):
989         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
990         (run_server):
991         * Scripts/webkitpy/tool/commands/analyzechangelog.py:
992         (ChangeLogAnalyzer._print_status):
993         * Scripts/webkitpy/tool/commands/queries.py:
994         (BugsToCommit.execute):
995         (PatchesInCommitQueue.execute):
996         (PatchesToCommitQueue.execute):
997         (PatchesToReview._print_report):
998         (WhatBroke._print_builder_line):
999         (WhatBroke._print_blame_information_for_builder):
1000         (WhatBroke.execute):
1001         (ResultsFor._print_layout_test_results):
1002         (ResultsFor.execute):
1003         (FailureReason._print_blame_information_for_transition):
1004         (FailureReason._explain_failures_for_builder):
1005         (FailureReason._builder_to_explain):
1006         (FailureReason.execute):
1007         (FindFlakyTests._find_failures):
1008         (FindFlakyTests._print_statistics):
1009         (FindFlakyTests._walk_backwards_from):
1010         (execute):
1011         (PrintExpectations.execute):
1012         (PrintBaselines.execute):
1013         (PrintBaselines._print_baselines):
1014         (FindResolvedBugs.execute):
1015         * Scripts/webkitpy/tool/commands/rebaseline.py:
1016         (AbstractParallelRebaselineCommand._run_webkit_patch):
1017         (AbstractParallelRebaselineCommand._rebaseline):
1018         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1019         (GardeningHTTPRequestHandler.rebaselineall):
1020         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1021         (GardeningServerTest.disabled_test_rebaselineall.run_command):
1022         (GardeningServerTest):
1023
1024 2017-12-08  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1025
1026         [Win] The way to detect Windows 10 is wrong
1027         https://bugs.webkit.org/show_bug.cgi?id=179344
1028         <rdar://problem/35562264>
1029
1030         Reviewed by Alex Christensen.
1031
1032         Python2.7 doesn't return correct information on Windows 10.
1033         Use platform.win32_ver() instead of sys.getwindowsversion().
1034
1035         * Scripts/webkitpy/common/system/platforminfo.py:
1036         (PlatformInfo._win_version):
1037         (PlatformInfo._win_version_str):
1038         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
1039         (fake_sys):
1040         (fake_sys.FakeSysModule):
1041         (fake_platform):
1042         (fake_platform.FakePlatformModule.win32_ver):
1043         (TestPlatformInfo.test_os_name_and_wrappers):
1044         (TestPlatformInfo.test_os_version):
1045         (TestPlatformInfo.test_display_name):
1046         (TestPlatformInfo.test_total_bytes_memory):
1047
1048 2017-12-08  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1049
1050         [WinCairo] Fix runtime error after r225229
1051         https://bugs.webkit.org/show_bug.cgi?id=180614
1052
1053         Reviewed by Alex Christensen.
1054
1055         The list of fallback versions doesn't match with version name mapping introduced recently.
1056         It should be safe by creating the list automatically from the name map for consistency.
1057  
1058         * Scripts/webkitpy/common/version_name_map.py:
1059         (VersionNameMap.__init__):
1060         (VersionNameMap.to_name):
1061         (VersionNameMap.from_name):
1062         (VersionNameMap):
1063         (VersionNameMap.names):
1064         (VersionNameMap.mapping_for_platform):
1065         * Scripts/webkitpy/port/win.py:
1066         (WinCairoPort):
1067         (WinCairoPort.default_baseline_search_path):
1068
1069 2017-12-08  David Quesada  <david_quesada@apple.com>
1070
1071         ApplicationManifestParser should strip whitespace from the raw input
1072         https://bugs.webkit.org/show_bug.cgi?id=180539
1073         rdar://problem/35915075
1074
1075         Reviewed by Joseph Pecoraro.
1076
1077         Added an API test for parsing manifests with surrounding whitespace.
1078
1079         Also drive-by fix ApplicationManifestParserTest.Display. Earlier versions of the
1080         manifest spec explicitly stated that the "display" value should be treated as if
1081         it were run through String.prototype.trim(), which allowed for the really weird
1082         edge case of an array containing one string. This behavior was lost when I changed
1083         ApplicationManifestParser's JSON parsing from using JavaScriptCore to WTF's JSON
1084         parsing. Update the unit test accordingly.
1085
1086         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
1087         (TEST_F):
1088
1089 2017-12-08  Konstantin Tokarev  <annulen@yandex.ru>
1090
1091         [python] Replace print operator with print() function for python3 compatibility
1092         https://bugs.webkit.org/show_bug.cgi?id=180592
1093
1094         Reviewed by Michael Catanzaro.
1095
1096         * BuildSlaveSupport/wait-for-SVN-server.py:
1097         (getLatestSVNRevision):
1098         (waitForSVNRevision):
1099         * Scripts/download-latest-github-release.py:
1100         (find_latest_release):
1101         (main):
1102         * Scripts/update-wasm-gcc-torture.py:
1103         (update_lkgr):
1104         (untar_torture):
1105         (list_js_files):
1106         (waterfall_known_failures):
1107         * Scripts/update-webkit-wincairo-libs.py:
1108         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1109         (BenchmarkRunner.show_results):
1110         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
1111         (SimpleHTTPServerDriver.fetch_result):
1112         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
1113         (list_benchmark_plans):
1114         * Scripts/webkitpy/bindings/main.py:
1115         (BindingsTests.generate_from_idl):
1116         (BindingsTests.generate_supplemental_dependency):
1117         (BindingsTests.detect_changes):
1118         (BindingsTests.run_tests):
1119         (BindingsTests.main):
1120         * Scripts/webkitpy/codegen/main.py:
1121         (BuiltinsGeneratorTests.generate_from_js_builtins):
1122         (BuiltinsGeneratorTests.detect_changes):
1123         (BuiltinsGeneratorTests.single_builtin_test):
1124         (BuiltinsGeneratorTests.run_test):
1125         (BuiltinsGeneratorTests.run_tests):
1126         (BuiltinsGeneratorTests.main):
1127         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
1128         (MockBugzilla.fetch_attachment):
1129         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1130         (Builder._fetch_revision_to_build_map):
1131         * Scripts/webkitpy/common/system/crashlogs.py:
1132         (CrashLogs._find_newest_log_win):
1133         * Scripts/webkitpy/common/system/outputcapture_unittest.py:
1134         (OutputCaptureTest.test_output_capture_scope):
1135         * Scripts/webkitpy/common/system/profiler.py:
1136         (GooglePProf.profile_after_exit):
1137         (Perf.profile_after_exit):
1138         * Scripts/webkitpy/common/system/user.py:
1139         (User.prompt_with_multiple_lists):
1140         (User.prompt_with_list):
1141         (User._warn_if_application_is_xcode):
1142         (User.edit_changelog):
1143         * Scripts/webkitpy/inspector/main.py:
1144         (InspectorGeneratorTests.generate_from_json):
1145         (InspectorGeneratorTests.detect_changes):
1146         (InspectorGeneratorTests.run_tests):
1147         (InspectorGeneratorTests.main):
1148         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1149         (Manager._print_expectation_line_for_test):
1150         (Manager._print_expectations_for_subset):
1151         (Manager._print_expectations_for_subset.if):
1152         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
1153         (run_server):
1154         * Scripts/webkitpy/port/config_standalone.py:
1155         (main):
1156         * Scripts/webkitpy/port/darwin_testcase.py:
1157         (DarwinTest.test_spindump.logging_run_command):
1158         (DarwinTest.test_sample_process.logging_run_command):
1159         * Scripts/webkitpy/port/ios.py:
1160         (IOSPort.clean_up_test_run):
1161         * Scripts/webkitpy/port/ios_device_unittest.py:
1162         (IOSDeviceTest.test_spindump.logging_run_command):
1163         (IOSDeviceTest.test_sample_process.logging_run_command):
1164         * Scripts/webkitpy/port/ios_simulator_unittest.py:
1165         (IOSSimulatorTest.test_xcrun.throwing_run_command):
1166         * Scripts/webkitpy/port/leakdetector_unittest.py:
1167         (test_count_total_bytes_and_unique_leaks.mock_run_script):
1168         * Scripts/webkitpy/port/mac_unittest.py:
1169         (MacTest.test_xcrun.throwing_run_command):
1170         * Scripts/webkitpy/style/checkers/contributors.py:
1171         (ContributorsChecker.check):
1172         * Scripts/webkitpy/tool/commands/abstractlocalservercommand.py:
1173         (AbstractLocalServerCommand.execute):
1174         * Scripts/webkitpy/tool/commands/adduserstogroups.py:
1175         (AddUsersToGroups.execute):
1176         * Scripts/webkitpy/tool/commands/analyzechangelog.py:
1177         (AnalyzeChangeLog._generate_jsons):
1178         (AnalyzeChangeLog.execute):
1179         (ChangeLogAnalyzer._set_filename):
1180         (ChangeLogAnalyzer.analyze):
1181         * Scripts/webkitpy/tool/commands/bugfortest.py:
1182         (BugForTest.execute):
1183         * Scripts/webkitpy/tool/commands/bugsearch.py:
1184         (execute):
1185         * Scripts/webkitpy/tool/commands/findusers.py:
1186         (FindUsers.execute):
1187         * Scripts/webkitpy/tool/commands/gardenomatic.py:
1188         (GardenOMatic.execute):
1189         * Scripts/webkitpy/tool/commands/rebaseline.py:
1190         (RebaselineTest.execute):
1191         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1192         (RebaselineServer._prepare_config):
1193         * Scripts/webkitpy/tool/commands/setupgitclone.py:
1194         (SetupGitClone.execute):
1195         (SetupGitClone._get_username_and_email):
1196         * Scripts/webkitpy/tool/commands/suggestnominations.py:
1197         (SuggestNominations._print_nominations):
1198         (SuggestNominations._print_counts):
1199         * Scripts/webkitpy/tool/commands/upload.py:
1200         (CommitMessageForCurrentDiff.execute):
1201         (CreateBug.prompt_for_bug_title_and_comment):
1202         * Scripts/webkitpy/tool/multicommandtool.py:
1203         (HelpCommand.execute):
1204         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1205         (TestGardeningHTTPRequestHandler._serve_text):
1206         (TestGardeningHTTPRequestHandler._serve_json):
1207         * Scripts/webkitpy/tool/steps/addsvnmimetypeforpng.py:
1208         (AddSvnMimetypeForPng.run):
1209         * Scripts/webkitpy/tool/steps/suggestreviewers.py:
1210         (SuggestReviewers.run):
1211         * Scripts/webkitpy/w3c/test_importer.py:
1212         (TestImporter.update_tests_options):
1213         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
1214         (WebDriverTestRunnerSelenium.run):
1215         * TestResultServer/model/jsonresults_unittest.py:
1216         * gtk/ycm_extra_conf.py:
1217         (FlagsForFile):
1218         * lldb/lldb_webkit.py:
1219         (btjs):
1220
1221 2017-12-08  Eric Carlson  <eric.carlson@apple.com>
1222
1223         Move Logger from PAL to WTF so it can be used outside of WebCore
1224         https://bugs.webkit.org/show_bug.cgi?id=180561
1225
1226         Reviewed by Alex Christensen.
1227
1228         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1229         (TestWebKitAPI::TEST_F):
1230
1231 2017-12-08  Chris Dumez  <cdumez@apple.com>
1232
1233         Different WebKitTestRunner instances should use different service worker registrations databases
1234         https://bugs.webkit.org/show_bug.cgi?id=180589
1235
1236         Reviewed by Brady Eidson.
1237
1238         * WebKitTestRunner/TestController.cpp:
1239         (WTR::TestController::generateContextConfiguration const):
1240
1241 2017-12-08  Fujii Hironori  <Hironori.Fujii@sony.com>
1242
1243         Tools/ImageDiff/cg/PlatformImageCG.cpp doesn't need to include <wtf/MathExtras.h>
1244         https://bugs.webkit.org/show_bug.cgi?id=180578
1245
1246         Reviewed by Konstantin Tokarev.
1247
1248         * ImageDiff/cg/PlatformImageCG.cpp: Removed unnecessary #include <wtf/MathExtras.h>.
1249
1250 2017-12-08  Zan Dobersek  <zdobersek@igalia.com>
1251
1252         Unreviewed WPE build fix after r225671.
1253
1254         * WebKitTestRunner/InjectedBundle/wpe/TestRunnerWPE.cpp:
1255         Include the ActivateFonts.h header to have a usable
1256         WTR::installFakeHelvetica() function declaration.
1257
1258 2017-12-07  Zan Dobersek  <zdobersek@igalia.com>
1259
1260         Unreviewed GTK+ and WPE build fix.
1261
1262         Add TestRunner::installFakeHelvetica(), WTR::installFakeHelvetica()
1263         and WTF::uninstallFakeHelvetica() definitions, filling out the
1264         declarations added in r225641. This fills up missing symbols in the
1265         WKTR's InjectedBundle library, unbreaking layout tests for both
1266         configurations.
1267
1268         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1269         (WTR::installFakeHelvetica):
1270         (WTR::uninstallFakeHelvetica):
1271         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1272         (WTR::TestRunner::inspectorTestStubURL):
1273         (WTR::TestRunner::installFakeHelvetica):
1274         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
1275         (WTR::installFakeHelvetica):
1276         (WTR::uninstallFakeHelvetica):
1277         * WebKitTestRunner/InjectedBundle/wpe/TestRunnerWPE.cpp:
1278         (WTR::TestRunner::installFakeHelvetica):
1279
1280 2017-12-07  Yusuke Suzuki  <utatane.tea@gmail.com>
1281
1282         Use StaticLock instead of NeverDestroyed<Lock>
1283         https://bugs.webkit.org/show_bug.cgi?id=180507
1284
1285         Reviewed by Saam Barati.
1286
1287         * DumpRenderTree/JavaScriptThreading.cpp:
1288         (javaScriptThreads):
1289         (runJavaScriptThread):
1290         (startJavaScriptThreads):
1291         (stopJavaScriptThreads):
1292         (javaScriptThreadsMutex): Deleted.
1293
1294 2017-12-07  Alex Christensen  <achristensen@webkit.org>
1295
1296         Always synchronously continue with fragment navigations
1297         https://bugs.webkit.org/show_bug.cgi?id=180544
1298         <rdar://problem/34815986> and <rdar://problem/35126690>
1299
1300         Reviewed by Geoffrey Garen.
1301
1302         * TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:
1303         (-[DecidePolicyForNavigationActionFragmentDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1304         (TEST):
1305         Add a test that verifies that decidePolicyForNavigationAction is called for fragment navigations.
1306
1307 2017-12-07  Myles C. Maxfield  <mmaxfield@apple.com>
1308
1309         [Cocoa] Add SPI to disallow user-installed fonts
1310         https://bugs.webkit.org/show_bug.cgi?id=180062
1311         <rdar://problem/35042408>
1312
1313         Reviewed by Simon Fraser.
1314
1315         * WebKitTestRunner/InjectedBundle/ActivateFonts.h:
1316         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1317         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1318         (WTR::InjectedBundlePage::resetAfterTest):
1319         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1320         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1321         (WTR::resourcesDirectoryURL):
1322         (WTR::activateFonts):
1323         (WTR::installFakeHelvetica):
1324         (WTR::uninstallFakeHelvetica):
1325         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1326         (WTR::TestRunner::installFakeHelvetica):
1327         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1328         * WebKitTestRunner/fonts/FakeHelvetica-Helvetica-400.ttf: Added.
1329         * WebKitTestRunner/fonts/FakeHelvetica-Helvetica-500.ttf: Added.
1330         * WebKitTestRunner/fonts/FakeHelvetica-Helvetica2-400.ttf: Added.
1331         * WebKitTestRunner/fonts/FakeHelvetica-Helvetica2-500.ttf: Added.
1332
1333 2017-12-07  David Quesada  <david_quesada@apple.com>
1334
1335         [Web App Manifest] Support display-mode media feature
1336         https://bugs.webkit.org/show_bug.cgi?id=180376
1337         rdar://problem/35837993
1338
1339         Reviewed by Geoffrey Garen.
1340
1341         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1342         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
1343         (WebCore::operator<<):
1344         (ApplicationManifestParserTest::testDisplay):
1345         (TEST_F):
1346             Add unit tests for the parsing of the 'display' manifest property.
1347
1348         * TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm:
1349         (TestWebKitAPI::TEST):
1350         * TestWebKitAPI/Tests/WebKitCocoa/display-mode.html: Added.
1351             Update API tests to include _WKApplicationManifest.displayMode.
1352
1353         * WebKitTestRunner/TestController.cpp:
1354         (WTR::parseStringTestHeaderValueAsRelativePath):
1355         (WTR::updateTestOptionsFromTestHeader):
1356         * WebKitTestRunner/TestOptions.h:
1357         (WTR::TestOptions::hasSameInitializationOptions const):
1358         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1359         (WTR::TestController::platformCreateWebView):
1360             Teach WKTR to look for and apply an app manifest. A new <!--webkit-test-runner-->
1361             directive 'applicationManifest' can specify a path (relative to the test file itself)
1362             to a JSON app manifest to be applied to the web view before running the test.
1363
1364 2017-12-07  Eric Carlson  <eric.carlson@apple.com>
1365
1366         Add WebRTC watchlist rule, update MediaStream rule
1367         https://bugs.webkit.org/show_bug.cgi?id=180536
1368         <rdar://problem/35914066>
1369
1370         Reviewed by Youenn Fablet.
1371
1372         * Scripts/webkitpy/common/config/watchlist:
1373
1374 2017-12-06  Chris Dumez  <cdumez@apple.com>
1375
1376         We should be able to recover after a Service Worker process crash
1377         https://bugs.webkit.org/show_bug.cgi?id=180477
1378
1379         Reviewed by Brady Eidson and Youenn Fablet.
1380
1381         Add testRunner API to terminate the Service Worker process.
1382
1383         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1384         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1385         (WTR::TestRunner::terminateServiceWorkerProcess):
1386         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1387         * WebKitTestRunner/TestController.cpp:
1388         (WTR::TestController::terminateServiceWorkerProcess):
1389         * WebKitTestRunner/TestController.h:
1390         * WebKitTestRunner/TestInvocation.cpp:
1391         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1392
1393 2017-12-02  Darin Adler  <darin@apple.com>
1394
1395         Modernize some aspects of text codecs, eliminate WebKit use of strcasecmp
1396         https://bugs.webkit.org/show_bug.cgi?id=180009
1397
1398         Reviewed by Alex Christensen.
1399
1400         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Removed include of StringExtras.h.
1401
1402         * TestWebKitAPI/CMakeLists.txt: Added LineEnding.cpp.
1403         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
1404         * TestWebKitAPI/Tests/WTF/LineEnding.cpp: Added. Has tests for the LineEnding
1405         functions rewritten in this patch.
1406
1407         * TestWebKitAPI/Tests/WebCore/TextCodec.cpp: Updated test now that the decode
1408         function doesn't have defaults for as many arguments any more. Also changed so
1409         that the tests log the fact that the decode function returns an error and updated
1410         expected results to expect all the errors.
1411
1412         * WebKitTestRunner/cg/TestInvocationCG.cpp: Ditto.
1413
1414 2017-12-06  Alexey Proskuryakov  <ap@apple.com>
1415
1416         Exclude another leak callstack.
1417
1418         * Scripts/webkitpy/port/leakdetector.py: (LeakDetector._callstacks_to_exclude_from_leaks):
1419
1420 2017-12-06  Jeff Miller  <jeffm@apple.com>
1421
1422         -[WKWebViewConfiguration copyWithZone] doesn't copy _groupIdentifier
1423         https://bugs.webkit.org/show_bug.cgi?id=180504
1424
1425         Reviewed by Geoffrey Garen.
1426
1427         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
1428         Add a test to verify that the _groupIdentifier is copied.
1429
1430 2017-12-06  David Quesada  <david_quesada@apple.com>
1431
1432         [Web App Manifest] Add SPI for fetching the manifest
1433         https://bugs.webkit.org/show_bug.cgi?id=180294
1434         rdar://problem/34747968
1435
1436         Reviewed by Geoffrey Garen.
1437
1438         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1439         * TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm: Added.
1440             Added two API tests for _WKApplicationManifest:
1441             - Testing _WKApplicationManifest's conformance to NSCoding.
1442             - Testing -[WKWebView _getApplicationManifestWithCompletionHandler:], verifying the
1443               values of the resulting _WKApplicationManifest.
1444         (TestWebKitAPI::TEST):
1445
1446         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1447             Added a new testRunner method getApplicationManifestThen(), used by the LayoutTests
1448             to request the document load its associated manifest. The layout tests formerly called
1449             an unimplemented function getManifestThen(), but I added 'Application' to somewhat
1450             differentiate this from the app cache manifest.
1451
1452         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1453         (WTR::InjectedBundle::didReceiveMessageToPage):
1454         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1455         (WTR::TestRunner::getApplicationManifestThen):
1456         (WTR::TestRunner::didGetApplicationManifest):
1457         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1458         * WebKitTestRunner/TestInvocation.cpp:
1459         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1460
1461 2017-12-05  Stephan Szabo  <stephan.szabo@sony.com>
1462
1463         Switch windows build to Visual Studio 2017
1464         https://bugs.webkit.org/show_bug.cgi?id=172412
1465
1466         Reviewed by Per Arne Vollan.
1467
1468         * Scripts/build-webkit:
1469         * Scripts/webkitdirs.pm:
1470         (visualStudioInstallDir):
1471         (visualStudioInstallDirFallback):
1472         (msBuildInstallDir):
1473         (setupAppleWinEnv):
1474         (setupCygwinEnv):
1475         (generateBuildSystemFromCMakeProject):
1476         (pickLegacyVisualStudioInstallation): Deleted.
1477         (visualStudioInstallDirLegacy): Deleted.
1478         (visualStudioVersion): Deleted.
1479         (visualStudioVersionFromInstallDir): Deleted.
1480
1481 2017-12-05  Alex Christensen  <achristensen@webkit.org>
1482
1483         Fix crash when loading a file URL that does not have a fileSystemPath representation
1484         https://bugs.webkit.org/show_bug.cgi?id=180448
1485         <rdar://problem/22805921>
1486
1487         Reviewed by Chris Dumez.
1488
1489         * TestWebKitAPI/Tests/WebKitCocoa/LoadAlternateHTMLString.mm:
1490         (TEST):
1491         Test opening a URL that used to crash WebKit.
1492
1493 2017-12-05  Michael Saboff  <msaboff@apple.com>
1494
1495         Make WebKit build for ARM64_32
1496         https://bugs.webkit.org/show_bug.cgi?id=180447
1497
1498         Reviewed by Mark Lam.
1499
1500         Add an instance of the _TestWTFAlwaysMissing for arm64_32 architecture.
1501
1502         * TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-iOS-v2.tbd:
1503
1504 2017-12-05  Aakash Jain  <aakash_jain@apple.com>
1505
1506         [build.webkit.org] Rename mastercfg_unittest to steps_unittest
1507         https://bugs.webkit.org/show_bug.cgi?id=180432
1508
1509         Rubber-stamped by Alexey Proskuryakov.
1510
1511         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Removed.
1512         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Copied from BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py.
1513
1514 2017-12-05  Aakash Jain  <aakash_jain@apple.com>
1515
1516         [build.webkit.org] Fix style issues in mastercfg_unittest.py
1517         https://bugs.webkit.org/show_bug.cgi?id=180439
1518
1519         Reviewed by Alexey Proskuryakov.
1520
1521         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Added imports directly instead of relying
1522         on imports from other files. We will try to import minimum required modules. Currently we are importing
1523         everything from master.cfg, loadConfig.py, factories.py and steps.py
1524
1525 2017-12-05  Aakash Jain  <aakash_jain@apple.com>
1526
1527         [build.webkit.org] Rename MasterCfgTest to RunWebKitTestsTest
1528         https://bugs.webkit.org/show_bug.cgi?id=180391
1529
1530         Rubber-stamped by Alexey Proskuryakov.
1531
1532         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1533         (RunWebKitTestsTest): Renamed from MasterCfgTest.
1534
1535 2017-12-01  Filip Pizlo  <fpizlo@apple.com>
1536
1537         GC constraint solving should be parallel
1538         https://bugs.webkit.org/show_bug.cgi?id=179934
1539
1540         Reviewed by JF Bastien.
1541
1542         * Scripts/run-jsc-benchmarks: Add splay-latency test, since this change needed to be carefully validated with that benchmark.
1543         * TestWebKitAPI/CMakeLists.txt:
1544         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1545         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp: Added. This has unit tests of the new concurrent data structure. The tests focus on correctness under serial execution, which appears to be enough for now (it's so easy to catch a concurrency bug by just running the GC).
1546         (TestWebKitAPI::TEST):
1547
1548 2017-12-04  Nan Wang  <n_wang@apple.com>
1549
1550         AX: AOM: Implement relation type properties
1551         https://bugs.webkit.org/show_bug.cgi?id=179500
1552
1553         Reviewed by Ryosuke Niwa.
1554
1555         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1556         (WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
1557         (WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):
1558         (WTR::AccessibilityUIElement::ariaDescribedByReferencingElementAtIndex):
1559         (WTR::AccessibilityUIElement::ariaDetailsReferencingElementAtIndex):
1560         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1561         (WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
1562         (WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):
1563
1564 2017-12-04  Simon Fraser  <simon.fraser@apple.com>
1565
1566         Minor DisplayRefreshMonitor-related cleanup
1567         https://bugs.webkit.org/show_bug.cgi?id=179802
1568
1569         Reviewed by Sam Weinig.
1570
1571         New trace point for when the CVDisplayLink fires on its own thread.
1572
1573         * Tracing/SystemTracePoints.plist:
1574
1575 2017-12-04  David Quesada  <david_quesada@apple.com>
1576
1577         Add a class for parsing application manifests
1578         https://bugs.webkit.org/show_bug.cgi?id=177973
1579         rdar://problem/34747949
1580
1581         Reviewed by Geoffrey Garen.
1582
1583         Add basic unit tests for ApplicationManifestParser. For each of the implemented top-level properties,
1584         attempt to parse manifests with varying types of valid and invalid data to ensure the resulting
1585         ApplicationManifest is configured with the appropriate values per the spec.
1586
1587         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Add ENABLE_APPLICATION_MANIFEST feature flag.
1588         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1589         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp: Added.
1590         (ApplicationManifestParserTest::SetUp):
1591         (ApplicationManifestParserTest::parseString):
1592         (ApplicationManifestParserTest::parseTopLevelProperty):
1593         (ApplicationManifestParserTest::testStartURL):
1594         (ApplicationManifestParserTest::testName):
1595         (ApplicationManifestParserTest::testDescription):
1596         (ApplicationManifestParserTest::testShortName):
1597         (ApplicationManifestParserTest::testScope):
1598         (assertManifestHasDefaultValues):
1599         (TEST_F):
1600
1601 2017-12-04  Aakash Jain  <aakash_jain@apple.com>
1602
1603         Add docstring in EarlyWarningSystemTask to explain return values
1604         https://bugs.webkit.org/show_bug.cgi?id=180303
1605
1606         Reviewed by Daniel Bates.
1607
1608         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
1609         (EarlyWarningSystemTask.run): Added docstring to explain return values.
1610         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1611         (AbstractEarlyWarningSystem.review_patch): Added comment to explain the result of unlocking a patch.
1612
1613 2017-12-04  JF Bastien  <jfbastien@apple.com>
1614
1615         Update std::expected to match libc++ coding style
1616         https://bugs.webkit.org/show_bug.cgi?id=180264
1617
1618         Reviewed by Alex Christensen.
1619
1620         Update tests according to name changes as well as removal of
1621         now-gone APIs.
1622
1623         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1624         (std::experimental::fundamentals_v3::operator<<):
1625         (TestWebKitAPI::TEST):
1626         (WTF::operator<<): Deleted.
1627         * TestWebKitAPI/Tests/WebCore/HTMLParserIdioms.cpp:
1628         (TestWebKitAPI::testParseHTMLInteger):
1629         (TestWebKitAPI::testParseHTMLNonNegativeInteger):
1630
1631 2017-12-04  Ross Kirsling  <ross.kirsling@sony.com>
1632
1633         download-latest-github-release.py should use existing release ANY time latest is not found
1634         https://bugs.webkit.org/show_bug.cgi?id=180293
1635
1636         Reviewed by Per Arne Vollan.
1637
1638         * Scripts/download-latest-github-release.py:
1639         (find_latest_release):
1640         Handle all URLErrors, not just HTTPErrors. Stop special-casing 404s.
1641
1642         (main):
1643         Rearrange logic so any failure to detect a latest release falls back to an existing release. Improve logging.
1644
1645         (Status):
1646         (download_release):
1647         (load_version_info): Renamed from existing_version info.
1648         (has_latest_release): Deleted.
1649         Cleanup.
1650
1651 2017-12-04  Joseph Pecoraro  <pecoraro@apple.com>
1652
1653         Exclude some more leak callstacks
1654         https://bugs.webkit.org/show_bug.cgi?id=180379
1655
1656         Reviewed by Alexey Proskuryakov.
1657
1658         * Scripts/webkitpy/port/leakdetector.py:
1659         (LeakDetector._types_to_exclude_from_leaks):
1660         (LeakDetector._callstacks_to_exclude_from_leaks):
1661         (LeakDetector._leaks_args):
1662         (LeakDetector._types_to_exlude_from_leaks): Deleted.
1663         * Scripts/webkitpy/port/leakdetector_unittest.py:
1664         (LeakDetectorTest.test_leaks_args):
1665
1666 2017-12-03  Yusuke Suzuki  <utatane.tea@gmail.com>
1667
1668         WTF shouldn't have both Thread and ThreadIdentifier
1669         https://bugs.webkit.org/show_bug.cgi?id=180308
1670
1671         Reviewed by Darin Adler.
1672
1673         * DumpRenderTree/mac/DumpRenderTree.mm:
1674         (dumpRenderTree):
1675         (runThread): Deleted.
1676         (runPthread): Deleted.
1677         (testThreadIdentifierMap): Deleted.
1678         * TestWebKitAPI/CMakeLists.txt:
1679         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1680         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1681         * TestWebKitAPI/Tests/WTF/Threading.cpp: Added.
1682         (TestWebKitAPI::TEST):
1683
1684 2017-12-03  Aakash Jain  <aakash_jain@apple.com>
1685
1686         webkitpy EWS keeps retrying a failing patch
1687         https://bugs.webkit.org/show_bug.cgi?id=180302
1688
1689         Reviewed by Alexey Proskuryakov.
1690
1691         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1692         (PatchAnalysisTask._test_patch): Instead of returning false, call report_failure() 
1693         which raises an exception, this exception is catched by earlywarningsystem.py and
1694         it posts a comment on bugzilla. Returning false simply unlocks the patch and returns
1695         it to the queue.
1696
1697 2017-12-03  Darin Adler  <darin@apple.com>
1698
1699         Add WTF::Hasher, an easier to use replacement for WTF::IntegerHasher
1700         https://bugs.webkit.org/show_bug.cgi?id=180318
1701
1702         Reviewed by JF Bastien.
1703
1704         * TestWebKitAPI/CMakeLists.txt: Added Hasher.cpp.
1705         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
1706
1707         * TestWebKitAPI/Tests/WTF/Hasher.cpp: Added. Contains tests of the new
1708         WTF::Hasher class.
1709
1710         * TestWebKitAPI/Tests/WTF/StringHasher.cpp: Include StringHasher.h instead of
1711         Hasher.h.
1712
1713 2017-12-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1714
1715         WebDriver: auto-install pytest instead of importing it from wpt tools directory
1716         https://bugs.webkit.org/show_bug.cgi?id=180243
1717
1718         Reviewed by Brian Burg.
1719
1720         We don't really need the (old) version included in wpt tools dir, so we can simply remove it and use autoinstall
1721         instead.
1722
1723         * Scripts/webkitpy/thirdparty/__init__.py:
1724         (AutoinstallImportHook.find_module): Check pytest.
1725         (AutoinstallImportHook._install_pytest): Install pytest.
1726         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py: Import autoinstalled pytest.
1727         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
1728         (WebDriverTestRunnerW3C.run): Update the subtest path since the new pytest uses a different strategy for
1729         rootdir.
1730         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py: Import autoinstalled pytest.
1731
1732 2017-12-01  Dewei Zhu  <dewei_zhu@apple.com>
1733
1734         Hardcoded python path is not compatible with virtual environment.
1735         https://bugs.webkit.org/show_bug.cgi?id=180300
1736
1737         Reviewed by Stephanie Lewis.
1738
1739         Hardcoding '/usr/bin/python' does not work with python virtual environment.
1740         Use 'python' instead.
1741
1742         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
1743         (SimpleHTTPServerDriver.serve):
1744
1745 2017-12-01  Aakash Jain  <aakash_jain@apple.com>
1746
1747         [build.webkit.org] Move python code to load config from master.cfg in separate file
1748         https://bugs.webkit.org/show_bug.cgi?id=180278
1749
1750         Reviewed by Daniel Bates.
1751
1752         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Moved appropriate code to loadConfig.py
1753         * BuildSlaveSupport/build.webkit.org-config/loadConfig.py: Ditto.
1754         * BuildSlaveSupport/build.webkit.org-config/steps.py: Removed extra import.
1755
1756 2017-12-01  Brian Burg  <bburg@apple.com>
1757
1758         Web Inspector: move Inspector::Protocol::Array<T> to JSON namespace
1759         https://bugs.webkit.org/show_bug.cgi?id=173662
1760
1761         Reviewed by Joseph Pecoraro.
1762
1763         Add duplicate test cases for JSON::ArrayOf<T> based on JSON::Array.
1764
1765         * TestWebKitAPI/Tests/WTF/JSONValue.cpp:
1766         (TestWebKitAPI::TEST):
1767
1768 2017-12-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1769
1770         [Attachment Support] Implement SPI for clients to update a given attachment's data
1771         https://bugs.webkit.org/show_bug.cgi?id=180184
1772         <rdar://problem/35355731>
1773
1774         Reviewed by Tim Horton.
1775
1776         Adds two new API tests to exercise the attachment data update flow.
1777
1778         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1779         (TestWebKitAPI::ObserveAttachmentUpdatesForScope::ObserveAttachmentUpdatesForScope):
1780         (-[_WKAttachment synchronouslySetDisplayOptions:error:]):
1781         (-[_WKAttachment synchronouslyRequestData:]):
1782         (-[_WKAttachment synchronouslySetData:newContentType:newFilename:error:]):
1783         (TestWebKitAPI::TEST):
1784
1785 2017-12-01  Alicia Boya García  <aboya@igalia.com>
1786
1787         [GTK] Add SampleMap.cpp API tests to CMake
1788         https://bugs.webkit.org/show_bug.cgi?id=180252
1789
1790         Reviewed by Žan Doberšek.
1791
1792         * TestWebKitAPI/PlatformGTK.cmake:
1793
1794 2017-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1795
1796         WebDriver: add support for importing and running selenium tests
1797         https://bugs.webkit.org/show_bug.cgi?id=180145
1798
1799         Reviewed by Brian Burg.
1800
1801         We currently import and run W3C tests, which are the best ones to ensure our implementation is spec
1802         compliant. However, the selenium API is what user will actually use in the end, so it's important to ensure that
1803         we don't break the selenium support. This patch adds webdriver_test_runner_selenium.py and
1804         webdriver_selenium_executor.py to run selenium tests. The script import-w3c-webdriver-tests has been renamed as
1805         import-webdriver-tests and it can now import selenium tests too.
1806
1807         * Scripts/import-w3c-webdriver-tests: Removed.
1808         * Scripts/import-webdriver-tests: Added.
1809         (Importer):
1810         (Importer.__init__):
1811         (Importer.download_tests):
1812         (Importer.import_tests):
1813         (Importer.import_tests.should_skip_file):
1814         * Scripts/webkitpy/webdriver_tests/webdriver_driver.py:
1815         (WebDriver.browser_path):
1816         (WebDriver):
1817         (WebDriver.browser_args):
1818         (WebDriver.selenium_name):
1819         * Scripts/webkitpy/webdriver_tests/webdriver_driver_gtk.py:
1820         (WebDriverGtk.browser_path):
1821         (WebDriverGtk):
1822         (WebDriverGtk.browser_args):
1823         (WebDriverGtk.capabilities):
1824         (WebDriverGtk.selenium_name):
1825         * Scripts/webkitpy/webdriver_tests/webdriver_driver_wpe.py:
1826         (WebDriverWPE.browser_args):
1827         (WebDriverWPE.capabilities):
1828         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py: Added.
1829         (_ensure_directory_in_path):
1830         (CollectRecorder):
1831         (CollectRecorder.__init__):
1832         (CollectRecorder.pytest_collectreport):
1833         (WebDriverSeleniumExecutor):
1834         (WebDriverSeleniumExecutor.__init__):
1835         (WebDriverSeleniumExecutor.collect):
1836         (WebDriverSeleniumExecutor.run):
1837         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
1838         (WebDriverTestRunner):
1839         (WebDriverTestRunner.__init__):
1840         (WebDriverTestRunner.run):
1841         (WebDriverTestRunner.print_results):
1842         (WebDriverTestRunner.dump_results_to_json_file):
1843         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py: Added.
1844         (WebDriverTestRunnerSelenium):
1845         (WebDriverTestRunnerSelenium.__init__):
1846         (WebDriverTestRunnerSelenium._tests_dir):
1847         (WebDriverTestRunnerSelenium.collect_tests):
1848         (WebDriverTestRunnerSelenium.run):
1849         (WebDriverTestRunnerSelenium.results):
1850         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
1851         (WebDriverTestRunnerW3C.__init__):
1852         (WebDriverTestRunnerW3C.run):
1853         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
1854
1855 2017-11-30  Alex Christensen  <achristensen@webkit.org>
1856
1857         REGRESSION (r224791): cookies are shared between ephemeral sessions in the same process pool
1858         https://bugs.webkit.org/show_bug.cgi?id=180235
1859
1860         Reviewed by Joseph Pecoraro.
1861
1862         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1863         * TestWebKitAPI/Tests/WebKitCocoa/CookiePrivateBrowsing.mm: Added.
1864         (-[CookiePrivateBrowsingDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1865         (TEST):
1866
1867 2017-11-30  Stephan Szabo  <stephan.szabo@sony.com>
1868
1869         Make LegacyCustomProtocolManager optional for network process
1870         https://bugs.webkit.org/show_bug.cgi?id=176230
1871
1872         Reviewed by Alex Christensen.
1873
1874         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1875
1876 2017-11-30  Dewei Zhu  <dewei_zhu@apple.com>
1877
1878         HTTP server driver is responsible for ensuring the dependencies of HTTP server.
1879         https://bugs.webkit.org/show_bug.cgi?id=180231
1880
1881         Reviewed by Stephanie Lewis.
1882
1883         Added the logic to ensure system environment meet the requirments of launching the http server.
1884
1885         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
1886         (SimpleHTTPServerDriver.serve):
1887         (SimpleHTTPServerDriver.set_device_id):
1888         (SimpleHTTPServerDriver):
1889         (SimpleHTTPServerDriver._ensure_http_server_dependencies):
1890
1891 2017-11-30  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1892
1893         [WinCairo] Cannot build without Internet connection
1894         https://bugs.webkit.org/show_bug.cgi?id=180068
1895
1896         Reviewed by Alex Christensen
1897
1898         With no Internet connection, if libraries has been downloaded
1899         before, trust that version and keep building.
1900
1901         * Scripts/download-latest-github-release.py:
1902         (Status):
1903         (current_release):
1904         (has_latest_release):
1905         (main):
1906
1907 2017-11-30  Alex Christensen  <achristensen@webkit.org>
1908
1909         WKURLSchemeHandler.request should include HTTPBody
1910         https://bugs.webkit.org/show_bug.cgi?id=180220
1911
1912         Reviewed by Brady Eidson.
1913
1914         * TestWebKitAPI/Tests/WebKitCocoa/_WKInputDelegate.mm:
1915         (-[FormSubmissionDelegate webView:startURLSchemeTask:]):
1916
1917 2017-11-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1918
1919         Add a script for automatically running the buildbot configurations on a test environment.
1920         https://bugs.webkit.org/show_bug.cgi?id=169084
1921
1922         Reviewed by Michael Catanzaro.
1923
1924         This new script does the following:
1925         - Creates a temporal workingdir.
1926         - Installs buildbot and its dependencies there (very same version used by the webkit.org buildbot master https://build.webkit.org/about ).
1927           This is important as there are problems that that may not be detected if you don't test with the same version that will be used on production.
1928         - Copies the buildmaster config files to the temporal workingdir.
1929         - Performs the required steps to start a buildmaster.
1930         - Creates the required config for each slave and starts all of them.
1931
1932         The test buildmaster should be accessible at http://localhost:8710/ allowing to trigger manual builds.
1933         This allows to test any configuration changes on this test environment that is pretty much identical to the production one.
1934
1935         * BuildSlaveSupport/build.webkit.org-config/run-buildbot-test.py: Added.
1936         (check_tcp_port_open):
1937         (upgrade_db_needed):
1938         (create_tempdir):
1939         (print_if_error_stdout_stderr):
1940         (setup_master_workdir):
1941         (wait_for_master_ready):
1942         (start_master):
1943         (get_list_workers):
1944         (start_worker):
1945         (clean):
1946         (cmd_exists):
1947         (check_buildbot_installed):
1948         (setup_virtualenv):
1949         (configdir_is_valid):
1950         (main):
1951
1952 2017-11-30  Aakash Jain  <aakash_jain@apple.com>
1953
1954         [build.webkit.org] Move python code from master.cfg in separate files
1955         https://bugs.webkit.org/show_bug.cgi?id=180180
1956
1957         Reviewed by Alexey Proskuryakov.
1958
1959         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Moved code to steps.py and master.cfg appropriately.
1960         * BuildSlaveSupport/build.webkit.org-config/factories.py: Moved all factory related code from master.cfg.
1961         * BuildSlaveSupport/build.webkit.org-config/steps.py: Moved all steps related code from master.cfg
1962
1963 2017-11-30  Wenson Hsieh  <wenson_hsieh@apple.com>
1964
1965         WKAttachmentTests.InPlaceImageAttachmentToggleDisplayMode times out on macOS bots
1966         https://bugs.webkit.org/show_bug.cgi?id=180200
1967
1968         Reviewed by Alexey Proskuryakov.
1969
1970         Rewrites an API test to avoid checking against the hard-coded platform-dependent size of an attachment element.
1971         Instead, first insert the attachment element as an icon and compute its size, and then check that the size of
1972         the element is restored to this original value after toggling the display mode to in-place mode and back.
1973
1974         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1975         (-[TestWKWebView attachmentElementSize]):
1976         (-[TestWKWebView waitForAttachmentElementSizeToBecome:]):
1977         (TestWebKitAPI::TEST):
1978         (platformAttachmentIconElementSize): Deleted.
1979
1980 2017-11-30  Michael Catanzaro  <mcatanzaro@igalia.com>
1981
1982         [WPE] Stop building Wayland in JHBuild moduleset
1983         https://bugs.webkit.org/show_bug.cgi?id=179951
1984
1985         Reviewed by Žan Doberšek.
1986
1987         Since Wayland is not used for running tests, and since it does not seem to depend on
1988         anything in the JHBuild moduleset, I think we can remove it safely without having to worry
1989         that the system version of Wayland might use libraries in the JHBuild environment (which
1990         would be unsafe).
1991
1992         * wpe/install-dependencies: Install Wayland.
1993         * wpe/jhbuild.modules: Stop building Wayland.
1994
1995 2017-11-30  Alexey Proskuryakov  <ap@apple.com>
1996
1997         Silence the BitVector leak for
1998         https://bugs.webkit.org/show_bug.cgi?id=121662
1999
2000         The out of line data pointer isn't stored directly, so the leaks tool cannot see it.
2001
2002         * Scripts/webkitpy/port/leakdetector.py:
2003         (LeakDetector._callstacks_to_exclude_from_leaks):
2004
2005 2017-11-29  Aakash Jain  <aakash_jain@apple.com>
2006
2007         Fix build.webkit.org broken unit-test after r225080
2008         https://bugs.webkit.org/show_bug.cgi?id=180176
2009
2010         Reviewed by Carlos Garcia Campos.
2011
2012         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Updated expected_build_steps.
2013
2014 2017-11-29  Wenson Hsieh  <wenson_hsieh@apple.com>
2015
2016         [Attachment Support] Implement SPI for clients to make an attachment element display in-place
2017         https://bugs.webkit.org/show_bug.cgi?id=180153
2018         <rdar://problem/35735252>
2019
2020         Reviewed by Tim Horton.
2021
2022         Adds new API tests to cover inserting in-place attachments and updating the display mode of existing attachments,
2023         as well as performing a few editing operations (paragraph insertion, cut/paste, list insertion) on attachment
2024         elements.
2025
2026         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2027         (platformAttachmentIconElementSize):
2028         (testVideoData):
2029         (testPDFData):
2030         (displayOptionsWithMode):
2031         (-[TestWKWebView waitForAttachmentElementSizeToBecome:]):
2032         (-[_WKAttachment synchronouslySetDisplayOptions:error:]):
2033         (TestWebKitAPI::TEST):
2034
2035 2017-11-29  Simon Fraser  <simon.fraser@apple.com>
2036
2037         API test fix after r225288.
2038
2039         Make the test work on iOS.
2040
2041         * TestWebKitAPI/Tests/WebKit/NoHistoryItemScrollToFragment.mm:
2042         (-[DidScrollToFragmentScrollViewDelegate scrollViewDidScroll:]):
2043         (TestWebKitAPI::TEST):
2044
2045 2017-11-29  Simon Fraser  <simon.fraser@apple.com>
2046
2047         REGRESSION (r213590): Scrolling to anchors broken in web views when content loaded via HTML string
2048         https://bugs.webkit.org/show_bug.cgi?id=180155
2049         rdar://problem/34220827
2050
2051         Reviewed by Zalan Bujtas.
2052
2053         API test that loads a page with a relative anchor, and simulates a click to scroll to it.
2054
2055         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2056         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
2057         (TestWebKitAPI::TEST):
2058         * TestWebKitAPI/Tests/WebKit/NoHistoryItemScrollToFragment.mm: Added.
2059         (-[DidScrollToFragmentDelegate _webViewDidScroll:]):
2060         (TestWebKitAPI::TEST):
2061         * TestWebKitAPI/Tests/WebKit/scroll-to-anchor.html: Added.
2062
2063 2017-11-29  Ryan Haddad  <ryanhaddad@apple.com>
2064
2065         webkitpy EWS should be present on the dashboard.
2066         https://bugs.webkit.org/show_bug.cgi?id=179801
2067
2068         Reviewed by Aakash Jain.
2069
2070         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2071         (BubbleQueueServer): Add Webkitpy EWS.
2072
2073 2017-11-29  Simon Fraser  <simon.fraser@apple.com>
2074
2075         Viewport unit values affected by Comand-+ zoom
2076         https://bugs.webkit.org/show_bug.cgi?id=145614
2077
2078         Reviewed by Zalan Bujtas.
2079         
2080         Fix Command+ and Command- in MiniBrowser to do zooming, rather than being tied
2081         to editing commands.
2082
2083         * MiniBrowser/mac/MainMenu.xib:
2084
2085 2017-11-29  Alex Christensen  <achristensen@webkit.org>
2086
2087         Add test for _WKVisitedLinkStore.addVisitedLinkWithString
2088         https://bugs.webkit.org/show_bug.cgi?id=180152
2089
2090         Reviewed by Chris Dumez.
2091
2092         * TestWebKitAPI/Tests/WebKitCocoa/VisitedLinkStore.mm:
2093         (TestWebKitAPI::TEST):
2094
2095 2017-11-29  Jonathan Bedard  <jbedard@apple.com>
2096
2097         webkitpy: Trying to use iOS versions from machines without iOS SDKs doesn't make sense
2098         https://bugs.webkit.org/show_bug.cgi?id=179534
2099         <rdar://problem/35469509>
2100
2101         Reviewed by Brent Fulgham.
2102
2103         Provide more specific information in builders.py so that machines do not try and calculate
2104         an iOS SDK version while running tests.
2105
2106         * Scripts/webkitpy/port/builders.py: Explicitly specify a version for iOS Simulator.
2107         * Scripts/webkitpy/port/ios_simulator.py:
2108         (IOSSimulatorPort._version_from_name): Attempt to extract the iOS version from the name
2109         of the port.
2110         (IOSSimulatorPort.ios_version): Use specified iOS version if a version is detected in
2111         in the provided name string (just like Mac).
2112
2113 2017-11-29  Robin Morisset  <rmorisset@apple.com>
2114
2115         The recursive tail call optimisation is wrong on closures
2116         https://bugs.webkit.org/show_bug.cgi?id=179835
2117
2118         Reviewed by Saam Barati.
2119
2120         This just includes merge-sort-cps.js to the list of benchmarks ran by run-jsc-benchmarks --tail-bench
2121
2122         * Scripts/run-jsc-benchmarks:
2123
2124 2017-11-28  Carlos Garcia Campos  <cgarcia@igalia.com>
2125
2126         WebDriver: add an option to dump test results to a json file
2127         https://bugs.webkit.org/show_bug.cgi?id=180082
2128
2129         Reviewed by Brian Burg.
2130
2131         Add --json-output command line option to run-webdriver-tests to dump test results to a json file in a format
2132         compatible with the W3C report. WebDriverTestResult now represents a test file and contains a list of
2133         subtests, instead of having one WebDriverTestResult per subtest. This way we can store also the harness result
2134         and dump the results to different formats.
2135
2136         * Scripts/run-webdriver-tests:
2137         * Scripts/webkitpy/webdriver_tests/webdriver_test_result.py:
2138         (WebDriverTestResult.__init__):
2139         (WebDriverTestResult):
2140         (WebDriverTestResult.add_subtest_results):
2141         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
2142         (WebDriverTestRunner.print_results):
2143         (WebDriverTestRunner):
2144         (WebDriverTestRunner.dump_results_to_json_file):
2145         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
2146         (WebDriverTestRunnerW3C.run):
2147
2148 2017-11-28  Alexey Proskuryakov  <ap@apple.com>
2149
2150         Stop silencing leaks in TextCodecICU::registerCodecs, as the problem was fixed a while ago.
2151         https://bugs.webkit.org/show_bug.cgi?id=118505
2152
2153         Reviewed by Joseph Pecoraro.
2154
2155         * Scripts/valgrind/suppressions.txt:
2156         * Scripts/webkitpy/port/leakdetector.py:
2157         (LeakDetector._callstacks_to_exclude_from_leaks):
2158
2159 2017-11-28  Ms2ger  <Ms2ger@igalia.com>
2160
2161         Stop modifying self.expectations in TestExpectationLine.expected_behavior.
2162         https://bugs.webkit.org/show_bug.cgi?id=180074
2163
2164         Reviewed by Simon Fraser.
2165
2166         In particular, getting the property multiple times on a skipped test
2167         expectation line (which happens when using
2168         `Tools/Scripts/run-webkit-tests --print-expectations` if a directory
2169         containing multiple tests is skipped) would yield [pass, skip], then
2170         [pass, skip, skip], then [pass, skip, skip, skip], and so on.
2171
2172         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2173         (TestExpectationLine.expected_behavior): copy self.expectations before modifying it.
2174
2175 2017-11-14  Carlos Garcia Campos  <cgarcia@igalia.com>
2176
2177         Move JSONValues to WTF and convert uses of InspectorValues.h to JSONValues.h
2178         https://bugs.webkit.org/show_bug.cgi?id=173793
2179
2180         Reviewed by Joseph Pecoraro.
2181
2182         * TestWebKitAPI/CMakeLists.txt:
2183         * TestWebKitAPI/PlatformGTK.cmake:
2184         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2185         * TestWebKitAPI/Tests/WTF/JSONValue.cpp: Renamed from Tools/TestWebKitAPI/Tests/JavaScriptCore/InspectorValue.cpp.
2186         (TestWebKitAPI::TEST):
2187
2188 2017-11-28  Ryan Haddad  <ryanhaddad@apple.com>
2189
2190         Bugs filed from the flakiness dashboard should include a link to the dashboard
2191         https://bugs.webkit.org/show_bug.cgi?id=180090
2192
2193         Reviewed by Aakash Jain.
2194
2195         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2196         (createBugHTML):
2197         Open the bug compose page in a new tab and include a link
2198         to the flakiness dashboard results for the selected test.
2199
2200 2017-11-28  Jonathan Bedard  <jbedard@apple.com>
2201
2202         webkitpy: Standardize Version representation
2203         https://bugs.webkit.org/show_bug.cgi?id=179677
2204         <rdar://problem/35711277>
2205
2206         Reviewed by Alex Christensen.
2207
2208         Standardize a single method of representing versions in the Version object
2209         constructor. Provide static methods for converting string and lists/tuples
2210         to Version objects.
2211
2212         * Scripts/webkitpy/common/system/platforminfo.py:
2213         (PlatformInfo.__init__): Parse Version object from string instead of using
2214         the constructor.
2215         (PlatformInfo.xcode_sdk_version): Ditto.
2216         (PlatformInfo.xcode_version): Ditto.
2217         (PlatformInfo._win_version): Construct Version object from list.
2218         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2219         (MockPlatformInfo.xcode_sdk_version):
2220         (MockPlatformInfo.xcode_version):
2221         * Scripts/webkitpy/common/version.py:
2222         (Version):
2223         (Version.from_string): Parse string of the form 'x.x.x'.
2224         (Version.from_iterable): Construct a version object from a list, tuple or
2225         other indexable object.
2226         (Version.__init__): Construct a Version object from integers.
2227         * Scripts/webkitpy/common/version_name_map.py:
2228         (VersionNameMap.__init__): Use integer Version constructor.
2229         (VersionNameMap._automap_to_major_version): Ditto.
2230         (VersionNameMap.to_name):
2231         (VersionNameMap.strip_name_formatting): Construct Version from string.
2232         * Scripts/webkitpy/common/version_name_map_unittest.py:
2233         (VersionMapTestCase.test_mac_version_by_name): Use integer Version constructor.
2234         (VersionMapTestCase.test_mac_name_by_version): Ditto.
2235         (VersionMapTestCase.test_ios_name_by_version): Ditto.
2236         * Scripts/webkitpy/common/version_unittest.py:
2237         (VersionTestCase.test_string_constructor):
2238         (VersionTestCase.test_from_list):
2239         (VersionTestCase.test_from_tuple):
2240         (VersionTestCase.test_int_constructor):
2241         (VersionTestCase.test_len):
2242         (VersionTestCase.test_set_by_int):
2243         (VersionTestCase.test_set_by_string):
2244         (VersionTestCase.test_get_by_int):
2245         (VersionTestCase.test_get_by_string):
2246         (VersionTestCase.test_string):
2247         (VersionTestCase.test_contained_in):
2248         (VersionTestCase.test_compare_versions):
2249         (VersionTestCase.test_list_constructor): Deleted.
2250         (VersionTestCase.test_tuple_constructor): Deleted.
2251         (VersionTestCase.test_copy_constructor): Deleted.
2252         (VersionTestCase.test_none_constructor): Deleted.
2253         * Scripts/webkitpy/port/ios.py:
2254         (IOSPort.default_baseline_search_path): Handle case where ios_version is None.
2255         * Scripts/webkitpy/port/ios_device.py:
2256         (IOSDevicePort.ios_version): Return None rather than an empty version.
2257         * Scripts/webkitpy/port/ios_simulator.py:
2258         (IOSSimulatorPort.simulator_runtime): Parse Version object from string instead
2259         of using the constructor.
2260         (IOSSimulatorPort.ios_version): Return None rather than an empty version.
2261         * Scripts/webkitpy/xcode/simulator.py:
2262         (Simulator._parse_runtimes): Parse Version object from string instead of using
2263         the constructor.
2264         (Simulator._parse_devices): Ditto.
2265         * Scripts/webkitpy/xcode/simulator_unittest.py:
2266
2267 2017-11-28  Daniel Bates  <dabates@apple.com>
2268
2269         [Cocoa] First pass at implementing alternative presentation button element
2270         https://bugs.webkit.org/show_bug.cgi?id=179785
2271         Part of <rdar://problem/34917108>
2272
2273         Reviewed by Brent Fulgham.
2274
2275         Add a test that substitutes the alternative presentation button for an element in
2276         the page and clicks it.
2277
2278         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add test.
2279         * TestWebKitAPI/Tests/WebKitCocoa/ClickAlternativePresentationButton.mm: Added.
2280         (didClickAlternativePresentationButton):
2281         (-[ClickAlternativePresentationButton webProcessPlugIn:didCreateBrowserContextController:]):
2282         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2283         (TEST):
2284         (-[AlternativePresentationButtonDelegate _webView:didClickAlternativePresentationButtonWithUserInfo:]):
2285         (-[AlternativePresentationButtonDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2286
2287 2017-11-28  Carlos Garcia Campos  <cgarcia@igalia.com>
2288
2289         REGRESSION(r225166): [GTK] Skipped unit tests are considered failures after glib upgrade
2290         https://bugs.webkit.org/show_bug.cgi?id=180072
2291
2292         Reviewed by Michael Catanzaro.
2293
2294         This is a bug in GLib that has already been fixed. Backport the patch to fix it until there's a new GLib release
2295         we can depend on.
2296
2297         * gtk/jhbuild.modules:
2298         * gtk/patches/glib-gtester-do-not-consider-skipped-tests-as-failures.patch: Added.
2299
2300 2017-11-28  Fujii Hironori  <Hironori.Fujii@sony.com>
2301
2302         webkitpy: PlatformInfo raises AssertionError "assert self.os_version is not None" in Cygwin since Bug 179621
2303         https://bugs.webkit.org/show_bug.cgi?id=180069
2304
2305         Reviewed by Daniel Bates.
2306
2307         "Version 10.0.16299" was interpreted as 0.0.16299. Fix the wrong
2308         regexp for 'ver' command.
2309
2310         * Scripts/webkitpy/common/system/platforminfo.py:
2311         (PlatformInfo._win_version_from_cmd): Replace \d with \d+.
2312
2313 2017-11-28  Carlos Garcia Campos  <cgarcia@igalia.com>
2314
2315         [GTK] WebDriver: disable XSS auditor when running WebDriver tests
2316         https://bugs.webkit.org/show_bug.cgi?id=180075
2317
2318         Reviewed by Carlos Alberto Lopez Perez.
2319
2320         Some tests are now doing inline('<script>window.alert()</script>') which is rejected by the XSS auditor because
2321         the script source is part of the request URL.
2322
2323         * Scripts/webkitpy/webdriver_tests/webdriver_driver_gtk.py:
2324         (WebDriverGtk.capabilities): Disable XSS auditor.
2325
2326 2017-11-28  Carlos Garcia Campos  <cgarcia@igalia.com>
2327
2328         WebDriver: add timeout option to run-webdriver-tests script
2329         https://bugs.webkit.org/show_bug.cgi?id=179940
2330
2331         Reviewed by Carlos Alberto Lopez Perez.
2332
2333         We need to handle timeouts to be able to run the tests in the bots. pytest doesn't support timeouts, but there's
2334         a plugin pytest_timeout that can be used for that.
2335
2336         * Scripts/run-webdriver-tests: Add --timeout command line option.
2337         * Scripts/webkitpy/thirdparty/__init__.py:
2338         (AutoinstallImportHook.find_module): Check if pytest_timeout is imported to install it.
2339         (AutoinstallImportHook._install_pytest_timeout): Install pytest_timeout from pypi.
2340         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
2341         (WebDriverTestRunnerW3C.__init__): Set PYTEST_TIMEOUT env var with the timeout given.
2342         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
2343         (WebDriverW3CExecutor.run): Clarify that the timeout received by do_wdspec() is ignored, and pass 0 instead of 25.
2344
2345 2017-11-27  Aakash Jain  <aakash_jain@apple.com>
2346
2347         Do not run webkitpy tests on multiple EWSes
2348         https://bugs.webkit.org/show_bug.cgi?id=179834
2349
2350         Reviewed by Alexey Proskuryakov.
2351
2352         Do not run webkitpy tests in every EWS. We now have
2353         a dedicated webkitpy test EWS.
2354
2355         * Scripts/webkitpy/tool/steps/runtests.py:
2356         (RunTests.run): Do not run webkitpy tests in EWSes. These tests will still run
2357         when --non-interactive option is not passed. 
2358
2359 2017-11-27  Jonathan Bedard  <jbedard@apple.com>
2360
2361         webkitpy: Better name-version mapping (Part 1)
2362         https://bugs.webkit.org/show_bug.cgi?id=179621
2363         <rdar://problem/35589585>
2364
2365         Reviewed by David Kilzer.
2366
2367         Mapping version numbers to version names should occur in a central location.
2368         This has a few advantages. First, it makes iterating through versions easier.
2369         Second, it allows for apple_additions to define an additional set of name
2370         mappings. Lastly, it will allow, in a future patch, for us to track version
2371         instead of version name, only mapping version to version name when required.
2372
2373         * Scripts/webkitpy/common/system/platforminfo.py:
2374         (PlatformInfo.__init__):
2375         (PlatformInfo._determine_os_name): Use VersionNameMap instead of custom functions
2376         mapping version to name.
2377         (PlatformInfo._determine_linux_version): Deleted.
2378         (PlatformInfo._determine_mac_version): Deleted.
2379         (PlatformInfo._determine_win_version): Deleted.
2380         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
2381         (TestPlatformInfo.test_os_name_and_wrappers):
2382         (TestPlatformInfo.test_os_version):
2383         (TestPlatformInfo.test_display_name):
2384         (TestPlatformInfo.test_total_bytes_memory):
2385         * Scripts/webkitpy/common/version.py:
2386         (Version.contained_in): Add partial version mapping.
2387         * Scripts/webkitpy/common/version_name_map.py: Added.
2388         (VersionNameMap): Holds a mapping of version name to version object.
2389         (VersionNameMap.map): Don't re-create VersionNameMap every time.
2390         (VersionNameMap.__init__): Initialize mapping, use platform to
2391         define the default system platform.
2392         (VersionNameMap._automap_to_major_version): Some operating systems, such
2393         as iOS, have a naming scheme based on their major version and os name.
2394         Automatically generate such mappings.
2395         (VersionNameMap.to_name): Given a version object, platform name and
2396         table, find the closest matching version name.
2397         (VersionNameMap.strip_name_formatting): Remove spaces and extract the major version,
2398         if a version string is included in the name.
2399         (VersionNameMap.from_name): Return an os name and version given a version name.
2400         * Scripts/webkitpy/common/version_name_map_unittest.py: Added.
2401         (VersionMapTestCase):
2402         (VersionMapTestCase.test_default_system_platform):
2403         (VersionMapTestCase.test_mac_version_by_name):
2404         (VersionMapTestCase.test_ios_version_by_name):
2405         (VersionMapTestCase.test_mac_name_by_version):
2406         (VersionMapTestCase.test_ios_name_by_version):
2407         * Scripts/webkitpy/common/version_unittest.py:
2408         (VersionTestCase.test_contained_in):
2409         * Scripts/webkitpy/port/ios_device.py:
2410         (IOSDevicePort.ios_version): Map os_version name to version number.
2411
2412 2017-11-27  Don Olmstead  <don.olmstead@sony.com>
2413
2414         [CMake][Win] Conditionally select DLL CRT or static CRT
2415         https://bugs.webkit.org/show_bug.cgi?id=170594
2416
2417         Reviewed by Alex Christensen.
2418
2419         * DumpRenderTree/PlatformWin.cmake:
2420         * MiniBrowser/win/CMakeLists.txt:
2421
2422 2017-11-27  Yacine Bandou  <yacine.bandou_ext@softathome.com>
2423
2424         [GTK][WPE] Add "enable-encrypted-media" property to WebKitWebSettings
2425         https://bugs.webkit.org/show_bug.cgi?id=18005
2426
2427         Reviewed by Michael Catanzaro.
2428
2429         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2430         (testWebKitSettings):
2431
2432 2017-11-27  Tim Horton  <timothy_horton@apple.com>
2433
2434         One too many zeroes in macOS version number in FeatureDefines
2435         https://bugs.webkit.org/show_bug.cgi?id=180011
2436
2437         Reviewed by Dan Bernstein.
2438
2439         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2440
2441 2017-11-27  Per Arne Vollan  <pvollan@apple.com>
2442
2443         [Win] The number of webkit-patch iterations on EWS should be configurable.
2444         https://bugs.webkit.org/show_bug.cgi?id=178517
2445
2446         Reviewed by Darin Adler.
2447
2448         Add a new RESET_AFTER_ITERATION argument to the EWS shell script.
2449
2450         * EWSTools/start-queue-win.sh:
2451
2452 2017-11-27  Per Arne Vollan  <pvollan@apple.com>
2453
2454         [Win] Switch to VS2017 on EWS bots.
2455         https://bugs.webkit.org/show_bug.cgi?id=178516
2456
2457         Reviewed by Darin Adler.
2458
2459         * EWSTools/start-queue-win.sh:
2460
2461 2017-11-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2462
2463         [SOUP] Layout test media/track/track-text-track-cue-list.html crash with g_source_set_ready_time: assertion 'source->ref_count > 0' failed
2464         https://bugs.webkit.org/show_bug.cgi?id=176806
2465
2466         Reviewed by Carlos Alberto Lopez Perez.
2467
2468         This was caused by a GLib bug that has already been fixed. Upgrade glib to 2.54.2.
2469
2470         * gtk/jhbuild.modules:
2471         * gtk/patches/gdate-suppress-string-format-literal-warning.patch: Removed.
2472
2473 2017-11-24  Darin Adler  <darin@apple.com>
2474
2475         * TestWebKitAPI/Tests/WTF/OptionSet.cpp:
2476         (TestWebKitAPI::TEST): Added a test for OptionSet operator|.
2477
2478 2017-11-24  Mark Lam  <mark.lam@apple.com>
2479
2480         Move unsafe jsc shell test functions to the $vm object.
2481         https://bugs.webkit.org/show_bug.cgi?id=179980
2482
2483         Reviewed by Yusuke Suzuki.
2484
2485         Always set --useDollarVM=true for jsc runs of benchmarks.  This is needed because
2486         some microbenchmarks relies on createBuiltin().
2487
2488         Also set --useDollarVM=true for runExceptionFuzz and runExecutableAllocationFuzz.
2489
2490         * Scripts/run-jsc-benchmarks:
2491         * Scripts/run-jsc-stress-tests:
2492
2493 2017-11-23  Darin Adler  <darin@apple.com>
2494
2495         Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
2496         https://bugs.webkit.org/show_bug.cgi?id=179907
2497
2498         Reviewed by Sam Weinig.
2499
2500         * DumpRenderTree/mac/DumpRenderTree.mm:
2501         (changeWindowScaleIfNeeded): Use containsIgnoringASCIICase.
2502         * WebKitTestRunner/TestInvocation.cpp:
2503         (WTR::TestInvocation::urlContains const): Ditto.
2504
2505 2017-11-22  Ali Juma  <ajuma@chromium.org>
2506
2507         Implement VisualViewport API attributes
2508         https://bugs.webkit.org/show_bug.cgi?id=179385
2509
2510         Reviewed by Frédéric Wang.
2511
2512         Enable the VisualViewportAPI in layout tests.
2513
2514         * DumpRenderTree/mac/DumpRenderTree.mm:
2515         (enableExperimentalFeatures):
2516         * DumpRenderTree/win/DumpRenderTree.cpp:
2517         (enableExperimentalFeatures):
2518
2519 2017-11-22  Tim Horton <timothy_horton@apple.com> and Michael Catanzaro <mcatanzaro@igalia.com>
2520
2521         Remove build-webkit's notion of feature flags having a default value
2522         https://bugs.webkit.org/show_bug.cgi?id=177338
2523
2524         Reviewed by Carlos Alberto Lopez Perez.
2525
2526         Delegate feature flag default values to the build system.
2527         (FeatureDefines.xcconfig for Xcode, WebKitFeatures.cmake and Options*.cmake for CMake, and FeatureDefines.h for everyone)
2528
2529         * BuildSlaveSupport/build.webkit.org-config/config.json:
2530         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2531         (Factory.__init__):
2532         Update GTK and WPE buildbot configuration to use --no-experimental-features on old stable
2533         bots instead of --default-cmake-features.
2534  
2535         * Scripts/build-webkit:
2536         (cMakeArgsFromFeatures): Deleted.
2537         Default feature values to 'undef'.
2538         Remove the --default-cmake-features argument; it is now the default.
2539         Add --no-experimental-features to replace it.
2540         Stop printing the default feature flag value in the help.
2541         Avoid propagating undefined values to the build system;
2542         only mention flags that are overridden on the command line.
2543
2544         This has the nice side effect of using the default CMake features
2545         for CMake builds, but still allowing toggling of them using the
2546         prettier --FEATURE and --no-FEATURE arguments.
2547
2548         * Scripts/webkitdirs.pm:
2549         (generateBuildSystemFromCMakeProject):
2550         No longer need to suppress CMake warnings about unused arguments.
2551
2552         * Scripts/webkitperl/FeatureList.pm:
2553         Remove the default values from the feature list.
2554
2555 2017-11-22  Mark Lam  <mark.lam@apple.com>
2556
2557         [Re-landing] Pass --useDollarVM=true to all JSC tests.
2558         https://bugs.webkit.org/show_bug.cgi?id=179647
2559
2560         Reviewed by Saam Barati.
2561
2562         * Scripts/run-jsc-stress-tests:
2563
2564 2017-11-22  Commit Queue  <commit-queue@webkit.org>
2565
2566         Unreviewed, rolling out r225093.
2567         https://bugs.webkit.org/show_bug.cgi?id=179938
2568
2569         Compilation failed on WinCairo 64-bit Release (Requested by
2570         fredw on #webkit).
2571
2572         Reverted changeset:
2573
2574         "Implement VisualViewport API attributes"
2575         https://bugs.webkit.org/show_bug.cgi?id=179385
2576         https://trac.webkit.org/changeset/225093
2577
2578 2017-11-21  Ali Juma  <ajuma@chromium.org>
2579
2580         Implement VisualViewport API attributes
2581         https://bugs.webkit.org/show_bug.cgi?id=179385
2582
2583         Reviewed by Frédéric Wang.
2584
2585         Enable the VisualViewportAPI in layout tests.
2586
2587         * DumpRenderTree/mac/DumpRenderTree.mm:
2588         (enableExperimentalFeatures):
2589         * DumpRenderTree/win/DumpRenderTree.cpp:
2590         (enableExperimentalFeatures):
2591
2592 2017-11-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2593
2594         [WPE] Run unit tests in the bots
2595         https://bugs.webkit.org/show_bug.cgi?id=179910
2596
2597         Reviewed by Michael Catanzaro.
2598
2599         Add a step to run unit tests in WPE test bots.
2600
2601         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2602         (RunGLibAPITests):
2603         (RunGtkAPITests):
2604         (RunWPEAPITests):
2605         (TestFactory.__init__):
2606         (RunGtkAPITests.start): Deleted.
2607         (RunGtkAPITests.commandComplete): Deleted.
2608         (RunGtkAPITests.evaluateCommand): Deleted.
2609         (RunGtkAPITests.getText): Deleted.
2610         (RunGtkAPITests.getText2): Deleted.
2611         * wpe/jhbuild.modules: Upgrade WPEBackend-mesa to fix crashes when running unit tests.
2612
2613 2017-11-21  Tomas Popela  <tpopela@redhat.com>
2614
2615         Fix WebKitGTK+ compilation
2616
2617         Reviewed by Carlos Garcia Campos.
2618
2619         File "/builddir/build/BUILD/webkitgtk-2.19.2/Tools/gtk/generate-gtkdoc", line 31, in <module>
2620         import common
2621         ImportError: No module named common
2622
2623         * gtk/manifest.txt.in:
2624         Add Tools/glib/common.py to the tarball.
2625
2626 2017-11-21  Ms2ger  <Ms2ger@igalia.com>
2627
2628         [GTK] Avoid warning in jhbuildrc.
2629         https://bugs.webkit.org/show_bug.cgi?id=179913
2630
2631         Reviewed by Carlos Garcia Campos.
2632
2633         Apparently this is not quite a real python file; this declaration causes
2634         warnings like
2635           I: unknown keys defined in configuration file: top_level_directory
2636         which break run-webkit-tests.
2637
2638         * gtk/jhbuildrc:
2639
2640 2017-11-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2641
2642         Unreviewed. Fix WPE make distcheck.
2643
2644         * wpe/manifest.txt.in: Add generate-inspector-gresource-manifest.py to the tarball.
2645
2646 2017-11-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2647
2648         Unreviewed. Fix GTK+ make distcheck.
2649
2650         * gtk/manifest.txt.in: Add generate-inspector-gresource-manifest.py to the tarball.
2651
2652 2017-11-20  Michael Catanzaro  <mcatanzaro@igalia.com>
2653
2654         [WPE] Disable ACCELERATED_2D_CANVAS in FeatureList.pm
2655         https://bugs.webkit.org/show_bug.cgi?id=179889
2656
2657         Reviewed by Darin Adler.
2658
2659         * Scripts/webkitperl/FeatureList.pm:
2660
2661 2017-11-20  Michael Catanzaro  <mcatanzaro@igalia.com>
2662
2663         Unreviewed, speculative attempt to fix run-gtk-tests after r225047
2664         https://bugs.webkit.org/show_bug.cgi?id=173772
2665
2666         * jhbuild/jhbuildutils.py:
2667         (enter_jhbuild_environment_if_available):
2668
2669 2017-11-20  Mario Sanchez Prada  <mario@endlessm.com>
2670
2671         [GTK] New API to add, retrieve and delete cookies via WebKitCookieManager
2672         https://bugs.webkit.org/show_bug.cgi?id=177932
2673
2674         Reviewed by Carlos Garcia Campos.
2675
2676         Added new test cases to cover the newly added API for WebKitCookieManager:
2677         webkit_cookie_manager_add_cookie, webkit_cookie_manager_get_cookies and
2678         webkit_cookie_manager_delete_cookie.
2679
2680         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2681         (testCookieManagerAddCookie): Added.
2682         (testCookieManagerGetCookies): Added.
2683         (testCookieManagerDeleteCookie): Added.
2684         (serverCallback): Small update to avoid hardcoding strings we reuse.
2685         (beforeAll): Added the new test cases to the test suite.
2686
2687 2017-11-20  Stephan Szabo  <stephan.szabo@sony.com>
2688
2689         [Win] Update ruby JSC test writer for gigacage changes
2690         https://bugs.webkit.org/show_bug.cgi?id=178757
2691
2692         Reviewed by Keith Miller.
2693
2694         * Scripts/webkitruby/jsc-stress-test-writer-ruby.rb:
2695         Add additionalEnv to ruby test writer Plan
2696
2697 2017-11-20  Michael Catanzaro  <mcatanzaro@igalia.com>
2698
2699         Remove ENABLE_ALLINONE_BUILD option
2700         https://bugs.webkit.org/show_bug.cgi?id=179823
2701
2702         Reviewed by Darin Adler.
2703
2704         * Scripts/webkitperl/FeatureList.pm:
2705
2706 2017-11-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2707
2708         Unreviewed. Fix WPE build after r225047.
2709
2710         Remove changes from an old patch committed by mistake in r225047.
2711
2712         * WebKitTestRunner/PlatformWebView.h:
2713         * WebKitTestRunner/wpe/PlatformWebViewWPE.cpp:
2714         (WTR::PlatformWebView::windowSnapshotImage):
2715
2716 2017-11-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2717
2718         [WPE] Add run-wpe-tests script to run WPE glib API tests
2719         https://bugs.webkit.org/show_bug.cgi?id=173772
2720
2721         Reviewed by Michael Catanzaro.
2722
2723         Move common code from run-gtk-tests to api_test_runner.py, to be shared by both run-gtk-tests and un-wpe-tests.
2724
2725         * Scripts/run-gtk-tests:
2726         (GtkTestRunner):
2727         (GtkTestRunner.__init__):
2728         (GtkTestRunner._start_accessibility_daemons):
2729         (GtkTestRunner._setup_testing_environment):
2730         (GtkTestRunner._tear_down_testing_environment):
2731         (GtkTestRunner.is_glib_test):
2732         (GtkTestRunner.is_google_test):
2733         * Scripts/run-wpe-tests: Added.
2734         (WPETestRunner):
2735         (WPETestRunner.__init__):
2736         (WPETestRunner.is_glib_test):
2737         (WPETestRunner.is_google_test):
2738         * Scripts/webkitpy/port/headlessdriver.py: Added.
2739         (HeadlessDriver):
2740         (HeadlessDriver._setup_environ_for_test):
2741         (HeadlessDriver._start):
2742         * Scripts/webkitpy/port/headlessdriver_unittest.py: Added.
2743         (HeadlessDriverTest):
2744         (HeadlessDriverTest.make_driver):
2745         (HeadlessDriverTest.make_environment):
2746         (HeadlessDriverTest.test_environment_needed_variables):
2747         (HeadlessDriverTest.test_environment_forbidden_variables):
2748         * Scripts/webkitpy/port/wpe.py:
2749         (WPEPort._driver_class):
2750         * WebKitTestRunner/PlatformWebView.h:
2751         * WebKitTestRunner/wpe/PlatformWebViewWPE.cpp:
2752         (WTR::PlatformWebView::windowSnapshotImage):
2753         * glib/api_test_runner.py: Copied from Tools/Scripts/run-gtk-tests.
2754         (SkippedTest):
2755         (SkippedTest.__init__):
2756         (SkippedTest.__str__):
2757         (SkippedTest.skip_entire_suite):
2758         (SkippedTest.skip_for_build_type):
2759         (TestTimeout):
2760         (TestRunner):
2761         (TestRunner.__init__):
2762         (TestRunner._test_programs_base_dir):
2763         (TestRunner._get_tests_from_dir):
2764         (TestRunner._get_tests):
2765         (TestRunner._create_driver):
2766         (TestRunner._setup_testing_environment):
2767         (TestRunner._tear_down_testing_environment):
2768         (TestRunner._test_cases_to_skip):
2769         (TestRunner._should_run_test_program):
2770         (TestRunner._kill_process):
2771         (TestRunner._start_timeout):
2772         (TestRunner._start_timeout._alarm_handler):
2773         (TestRunner._stop_timeout):
2774         (TestRunner._waitpid):
2775         (TestRunner._run_test_glib):
2776         (TestRunner._run_test_glib.parse_line):
2777         (TestRunner._run_test_glib.parse_line.set_test_result):
2778         (TestRunner._get_tests_from_google_test_suite):
2779         (TestRunner._run_google_test):
2780         (TestRunner._run_google_test_suite):
2781         (TestRunner.is_glib_test):
2782         (TestRunner.is_google_test):
2783         (TestRunner._run_test):
2784         (TestRunner.run_tests):
2785         (add_options):
2786         * glib/common.py: Renamed from Tools/gtk/common.py.
2787         (get_build_path.is_valid_build_directory):
2788         * gtk/generate-gtkdoc:
2789         * gtk/jhbuildrc:
2790         * gtk/ycm_extra_conf.py:
2791
2792 2017-11-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2793
2794         [WPE] Build C API tests
2795         https://bugs.webkit.org/show_bug.cgi?id=179817
2796
2797         Reviewed by Michael Catanzaro.
2798
2799         * TestWebKitAPI/CMakeLists.txt:
2800         * TestWebKitAPI/PlatformGTK.cmake:
2801         * TestWebKitAPI/PlatformWPE.cmake:
2802         * TestWebKitAPI/PlatformWebView.h:
2803         * TestWebKitAPI/wpe/PlatformUtilitiesWPE.cpp:
2804         (TestWebKitAPI::Util::URLForNonExistentResource):
2805         (TestWebKitAPI::Util::isKeyDown):
2806         * TestWebKitAPI/wpe/PlatformWebViewWPE.cpp: Added.
2807         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2808         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
2809         (TestWebKitAPI::PlatformWebView::initialize):
2810         (TestWebKitAPI::PlatformWebView::page const):
2811         (TestWebKitAPI::PlatformWebView::resizeTo):
2812         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
2813         (TestWebKitAPI::PlatformWebView::simulateAltKeyPress):
2814         (TestWebKitAPI::PlatformWebView::simulateRightClick):
2815         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
2816
2817 2017-11-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2818
2819         [WPE] Add env var WPE_USE_HEADLESS_VIEW_BACKEND
2820         https://bugs.webkit.org/show_bug.cgi?id=173770
2821
2822         Reviewed by Michael Catanzaro.
2823
2824         Move HeadlessViewBackend implementation to a common place and build it as a private static library to be used by
2825         WTR, GLib API tests and eventually C API tests too. WTR uses the HeadlessViewBackend unconditionally, but GLib
2826         API tests use it only when WPE_USE_HEADLESS_VIEW_BACKEND environment variable is present and not "0".
2827
2828         * CMakeLists.txt: Include wpe/HeadlessViewBackend directory for developer builds.
2829         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
2830         (testAutomationSessionRequestSession):
2831         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2832         (testCookieManagerEphemeral):
2833         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
2834         (testPrivateBrowsing):
2835         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
2836         (testWebContextProxySettings):
2837         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
2838         (testWebViewWebContext):
2839         (testWebViewEphemeral):
2840         * TestWebKitAPI/glib/PlatformWPE.cmake:
2841         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2842         (Test::createWebViewBackend):
2843         (Test::createWebView):
2844         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
2845         (WebViewTest::initializeWebView):
2846         * WebKitTestRunner/PlatformWPE.cmake:
2847         * wpe/HeadlessViewBackend/CMakeLists.txt: Added.
2848         * wpe/HeadlessViewBackend/HeadlessViewBackend.cpp: Renamed from Tools/WebKitTestRunner/wpe/HeadlessViewBackend.cpp.
2849         (HeadlessViewBackend::HeadlessViewBackend):
2850         * wpe/HeadlessViewBackend/HeadlessViewBackend.h: Renamed from Tools/WebKitTestRunner/wpe/HeadlessViewBackend.h.
2851
2852 2017-11-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2853
2854         [WPE] webkit_web_view_new() should enable specifying wpe_view_backend object
2855         https://bugs.webkit.org/show_bug.cgi?id=178655
2856
2857         Reviewed by Michael Catanzaro.
2858
2859         Update unit tests to create web views using helper methods that have a different implementation for GTK and
2860         WPE. Also add a new test case to check the new API to create a WebKitWebView with a WPE backend. Use
2861         WKViewCreate in WTR and fix a memory leak in HeadlessViewBackend.
2862
2863         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
2864         (testAutomationSessionRequestSession):
2865         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
2866         (testWebKitWebViewSessionState):
2867         (testWebKitWebViewSessionStateWithFormData):
2868         (testWebKitWebViewNavigationAfterSessionRestore):
2869         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
2870         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
2871         (testWebResourceGetDataError):
2872         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2873         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
2874         (testWebViewNewWithUserContentManager):
2875         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
2876         (testWebContextEphemeral):
2877         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
2878         (testWebViewWebContext):
2879         (testWebViewWebContextLifetime):
2880         (testWebViewWebBackend):
2881         (testWebViewSettings):
2882         (beforeAll):
2883         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
2884         (testWebsiteDataEphemeral):
2885         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2886         (Test::createWebView):
2887         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
2888         (HeadlessViewBackend::~HeadlessViewBackend):
2889         * WebKitTestRunner/wpe/PlatformWebViewWPE.cpp:
2890         (WTR::PlatformWebView::PlatformWebView):
2891
2892 2017-11-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2893
2894         [GTK][WPE] webkit_cookie_manager_delete_all_cookies doesn't delete the cookies if called before a web process is running
2895         https://bugs.webkit.org/show_bug.cgi?id=175265
2896
2897         Reviewed by Michael Catanzaro.
2898
2899         Add test case.
2900
2901         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2902         (testCookieManagerPersistentStorageDeleteAll):
2903         (serverCallback):
2904         (beforeAll):
2905
2906 2017-11-19  Tim Horton  <timothy_horton@apple.com>
2907
2908         Remove unused TOUCH_ICON_LOADING feature flag
2909         https://bugs.webkit.org/show_bug.cgi?id=179873
2910
2911         Reviewed by Simon Fraser.
2912
2913         * Scripts/webkitperl/FeatureList.pm:
2914         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2915
2916 2017-11-19  Tim Horton  <timothy_horton@apple.com>
2917
2918         Remove unused LEGACY_VENDOR_PREFIXES feature flag
2919         https://bugs.webkit.org/show_bug.cgi?id=179872
2920
2921         Reviewed by Darin Adler.
2922
2923         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2924
2925 2017-11-19  Yusuke Suzuki  <utatane.tea@gmail.com>
2926
2927         Unreviewed, rolling out r225016.
2928
2929         Break webkit-patch on Ubuntu and Debian Linux
2930
2931         Reverted changeset:
2932
2933         "webkitpy: Better name-version mapping (Part 1)"
2934         https://bugs.webkit.org/show_bug.cgi?id=179621
2935         https://trac.webkit.org/changeset/225016
2936
2937 2017-11-18  Jonathan Bedard  <jbedard@apple.com>
2938
2939         webkitpy: Better name-version mapping (Part 1)
2940         https://bugs.webkit.org/show_bug.cgi?id=179621
2941         <rdar://problem/35589585>
2942
2943         Reviewed by David Kilzer.
2944
2945         Mapping version numbers to version names should occur in a central location.
2946         This has a few advantages. First, it makes iterating through versions easier.
2947         Second, it allows for apple_additions to define an additional set of name
2948         mappings. Lastly, it will allow, in a future patch, for us to track version
2949         instead of version name, only mapping version to version name when required.
2950
2951         * Scripts/webkitpy/common/system/platforminfo.py:
2952         (PlatformInfo.__init__):
2953         (PlatformInfo._determine_os_name): Use VersionNameMap instead of custom functions
2954         mapping version to name.
2955         (PlatformInfo._determine_linux_version): Deleted.
2956         (PlatformInfo._determine_mac_version): Deleted.
2957         (PlatformInfo._determine_win_version): Deleted.
2958         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
2959         (TestPlatformInfo.test_os_name_and_wrappers):
2960         (TestPlatformInfo.test_os_version):
2961         (TestPlatformInfo.test_display_name):
2962         (TestPlatformInfo.test_total_bytes_memory):
2963         * Scripts/webkitpy/common/version.py:
2964         (Version.contained_in): Add partial version mapping.
2965         * Scripts/webkitpy/common/version_name_map.py: Added.
2966         (VersionNameMap): Holds a mapping of version name to version object.
2967         (VersionNameMap.map): Don't re-create VersionNameMap every time.
2968         (VersionNameMap.__init__): Initialize mapping, use platform to
2969         define the default system platform.
2970         (VersionNameMap._automap_to_major_version): Some operating systems, such
2971         as iOS, have a naming scheme based on their major version and os name.
2972         Automatically generate such mappings.
2973         (VersionNameMap.to_name): Given a version object, platform name and
2974         table, find the closest matching version name.
2975         (VersionNameMap.strip_name_formatting): Remove spaces and extract the major version,
2976         if a version string is included in the name.
2977         (VersionNameMap.from_name): Return an os name and version given a version name.
2978         * Scripts/webkitpy/common/version_name_map_unittest.py: Added.
2979         (VersionMapTestCase):
2980         (VersionMapTestCase.test_default_system_platform):
2981         (VersionMapTestCase.test_mac_version_by_name):
2982         (VersionMapTestCase.test_ios_version_by_name):
2983         (VersionMapTestCase.test_mac_name_by_version):
2984         (VersionMapTestCase.test_ios_name_by_version):
2985         * Scripts/webkitpy/common/version_unittest.py:
2986         (VersionTestCase.test_contained_in):
2987
2988 2017-11-17  John Wilander  <wilander@apple.com>
2989
2990         Storage Access API: UI process should update network process about granted access
2991         https://bugs.webkit.org/show_bug.cgi?id=176943
2992         <rdar://problem/34440612>
2993
2994         Reviewed by Alex Christensen.
2995
2996         This adds the TestRunner function setStatisticsHasHadNonRecentUserInteraction()
2997         which enables testing of prevalent resources with user interaction outside the
2998         24 hour window.
2999
3000         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3001         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3002         (WTR::TestRunner::setStorageAccessAPIEnabled):
3003         (WTR::TestRunner::setStatisticsHasHadNonRecentUserInteraction):
3004         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3005         * WebKitTestRunner/TestController.cpp:
3006         (WTR::TestController::setStatisticsHasHadNonRecentUserInteraction):
3007         * WebKitTestRunner/TestController.h:
3008         * WebKitTestRunner/TestInvocation.cpp:
3009         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3010         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3011         (WTR::initializeWebViewConfiguration):
3012         (WTR::TestController::setStatisticsHasHadNonRecentUserInteraction):
3013
3014 2017-11-17  Ryan Haddad  <ryanhaddad@apple.com>
3015
3016         Disable failing API tests for rdar://problem/35344202.
3017
3018         Unreviewed test gardening.
3019
3020         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
3021
3022 2017-11-17  Joanmarie Diggs  <jdiggs@igalia.com>
3023
3024         AX: [ATK] Fix WKTR's methods for testing row header and column header presence and count
3025         https://bugs.webkit.org/show_bug.cgi?id=179837
3026
3027         Reviewed by Chris Fleizach.
3028
3029         Add support to rowHeaders() for tables. Return an empty array in rowHeaders()
3030         and columnHeaders() upon failure. Rename getRowHeaders() and getColumnHeaders()
3031         to getTableRowHeaders() and getTableColumnHeaders() respectively.
3032
3033         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3034         (WTR::AccessibilityUIElement::rowHeaders const):
3035         (WTR::AccessibilityUIElement::columnHeaders const):
3036         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
3037         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
3038
3039 2017-11-16  Don Olmstead  <don.olmstead@sony.com>
3040
3041         [WinCairo] Update WinCairoRequirements
3042         https://bugs.webkit.org/show_bug.cgi?id=179790
3043
3044         Reviewed by Alex Christensen.
3045
3046         * TestWebKitAPI/PlatformWin.cmake:
3047
3048 2017-11-16  Daniel Bates  <dabates@apple.com>
3049
3050         Add feature define for alternative presentation button element
3051         https://bugs.webkit.org/show_bug.cgi?id=179692
3052         Part of <rdar://problem/34917108>
3053
3054         Reviewed by Andy Estes.
3055
3056         Only enabled on Cocoa platforms by default.
3057
3058         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3059
3060 2017-11-16  Per Arne Vollan  <pvollan@apple.com>
3061
3062         Win EWS bots should reboot after N webkit-patch iterations.
3063         https://bugs.webkit.org/show_bug.cgi?id=177970
3064
3065         Reviewed by Brent Fulgham.
3066
3067         * EWSTools/start-queue-win.sh:
3068
3069 2017-11-15  Carlos Garcia Campos  <cgarcia@igalia.com>
3070
3071         [WPE] Add initial support for WebDriver
3072         https://bugs.webkit.org/show_bug.cgi?id=179727
3073
3074         Reviewed by Michael Catanzaro.
3075
3076         Make it possible to run WebDriver tests with WPE.
3077
3078         * Scripts/run-webdriver-tests: Add --wpe alias for --platform=wpe.
3079         * Scripts/webkitpy/port/wpe.py:
3080         (WPEPort.__init__): Initialize _display_server from options.
3081         (WPEPort._driver_class): Use WaylandDriver when wayland is passed as display server option.
3082         * Scripts/webkitpy/webdriver_tests/webdriver_driver.py:
3083         (WebDriver.browser_env): Add virtual method to get the environment that should be used.
3084         * Scripts/webkitpy/webdriver_tests/webdriver_driver_wpe.py: Copied from Tools/Scripts/webkitpy/webdriver_tests/webdriver_driver.py.
3085         (WebDriverWPE):
3086         (WebDriverWPE.__init__):
3087         (WebDriverWPE.binary_path):
3088         (WebDriverWPE.browser_name):
3089         (WebDriverWPE.capabilities):
3090         (WebDriverWPE.browser_env):
3091         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
3092         (WebDriverW3CExecutor.__init__): Update the environment with the one provided by the driver.
3093         * wpe/jhbuild.modules: Upgrade dyz to newer version that supports automation.
3094
3095 2017-11-15  Alex Christensen  <achristensen@webkit.org>
3096
3097         WebViews scheduled in custom run loop modes should be able to do more than 50ms of work at a time
3098         https://bugs.webkit.org/show_bug.cgi?id=179742
3099         <rdar://problem/35519421>
3100
3101         Reviewed by Jer Noble.
3102
3103         * TestWebKitAPI/Tests/mac/WebViewScheduleInRunLoop.mm:
3104         (-[ScheduleInRunLoopDelegate webView:didFinishLoadForFrame:]):
3105         (TestWebKitAPI::TEST):
3106         Load more than one scheduled WebView to test work that typically takes more than 50 ms.
3107
3108 2017-11-15  Ryan Haddad  <ryanhaddad@apple.com>
3109
3110         Unreviewed, rolling out r223781.
3111
3112         The test is now returning false, so the FIXME is not needed
3113         anymore.
3114
3115         Reverted changeset:
3116
3117         "WebsiteDataStoreCustomPaths.mm is failing after r223718"
3118         https://bugs.webkit.org/show_bug.cgi?id=178596
3119         https://trac.webkit.org/changeset/223781
3120
3121 2017-11-15  Ryan Haddad  <ryanhaddad@apple.com>
3122
3123         Unreviewed, rolling out r224863.
3124
3125         Introduced LayoutTest crashes on iOS Simulator.
3126
3127         Reverted changeset:
3128
3129         "Move JSONValues to WTF and convert uses of InspectorValues.h
3130         to JSONValues.h"
3131         https://bugs.webkit.org/show_bug.cgi?id=173793
3132         https://trac.webkit.org/changeset/224863
3133
3134 2017-11-15  Michael Catanzaro  <mcatanzaro@igalia.com>
3135
3136         Remove GTK web inspector images
3137         https://bugs.webkit.org/show_bug.cgi?id=179716
3138
3139         Reviewed by Carlos Garcia Campos.
3140
3141         * Scripts/webkitdirs.pm:
3142         (shouldRemoveCMakeCache):
3143         * glib/generate-inspector-gresource-manifest.py:
3144         (get_filenames.should_ignore_resource):
3145         * gtk/manifest.txt.in:
3146         * wpe/manifest.txt.in:
3147
3148 2017-11-15  Jonathan Bedard  <jbedard@apple.com>
3149
3150         REGRESSION(r221877): 'future' handled incorrectly for mac
3151         https://bugs.webkit.org/show_bug.cgi?id=179711
3152         <rdar://problem/35546604>
3153
3154         Reviewed by Alex Christensen.
3155
3156         * Scripts/webkitpy/port/mac.py:
3157         (MacPort.default_baseline_search_path): Use platform/mac-<version> instead of
3158         platform/<version> as the baseline search path.
3159
3160 2017-11-14  Nan Wang  <n_wang@apple.com>
3161
3162         AX: AOM: Implement AccessibleNode class and support label and role attributes
3163         https://bugs.webkit.org/show_bug.cgi?id=179494
3164
3165         Reviewed by Ryosuke Niwa.
3166
3167         * DumpRenderTree/mac/DumpRenderTree.mm:
3168         (enableExperimentalFeatures):
3169         * WebKitTestRunner/TestController.cpp:
3170         (WTR::TestController::resetPreferencesToConsistentValues):
3171
3172 2017-11-14  Basuke Suzuki  <Basuke.Suzuki@sony.com>
3173
3174         [Windows] Fix error while launching subprocess on Windows Python
3175         https://bugs.webkit.org/show_bug.cgi?id=179637
3176
3177         Reviewed by Alex Christensen.
3178
3179         To pass environment variables to subprocess.popen on Windows Python 2,
3180         the dict values must be str not unicode.
3181         Also is_native_win() method is added to port.
3182
3183         * Scripts/webkitpy/common/system/platforminfo.py:
3184         (PlatformInfo.is_native_win):
3185         * Scripts/webkitpy/common/system/platforminfo_mock.py:
3186         (MockPlatformInfo.is_native_win):
3187         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
3188         (TestPlatformInfo.test_os_name_and_wrappers):
3189         * Scripts/webkitpy/port/server_process.py:
3190         (ServerProcess.__init__):
3191
3192 2017-11-14  Carlos Garcia Campos  <cgarcia@igalia.com>
3193
3194         Move JSONValues to WTF and convert uses of InspectorValues.h to JSONValues.h
3195         https://bugs.webkit.org/show_bug.cgi?id=173793
3196
3197         Reviewed by Brian Burg.
3198
3199         * TestWebKitAPI/CMakeLists.txt:
3200         * TestWebKitAPI/PlatformGTK.cmake:
3201         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3202         * TestWebKitAPI/Tests/WTF/JSONValue.cpp: Renamed from Tools/TestWebKitAPI/Tests/JavaScriptCore/InspectorValue.cpp.
3203         (TestWebKitAPI::TEST):
3204
3205 2017-11-14  Jonathan Bedard  <jbedard@apple.com>
3206
3207         webkitpy: Use more verbose version info from simctl
3208         https://bugs.webkit.org/show_bug.cgi?id=179687
3209         <rdar://problem/35539392>
3210
3211         Reviewed by Tim Horton.
3212
3213         * Scripts/webkitpy/xcode/simulator.py:
3214         (Simulator): Address FIXME, use more verbose version.
3215         (Simulator._parse_runtimes): 'Internal' no longer stands along, check os for this
3216         string instead.
3217         * Scripts/webkitpy/xcode/simulator_unittest.py: Mock simctl output specifies iOS
3218         8.4.1, not iOS 8.4.
3219
3220 2017-11-14  Daniel Bates  <dabates@apple.com>
3221
3222         Update comment in FeatureDefines.xcconfig to reflect location of Visual Studio property files
3223         for feature defines
3224
3225         Following r195498 and r201917 the Visual Studio property files for feature defines have
3226         moved from directory WebKitLibraries/win/tools/vsprops to directory Source/cmake/tools/vsprops.
3227         Update the comment in FeatureDefines.xcconfig to reflect the new location and names of these
3228         files.
3229
3230         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3231
3232 2017-11-14  Jer Noble  <jer.noble@apple.com>
3233
3234         Enable Modern EME tests in DumpRenderTree
3235         https://bugs.webkit.org/show_bug.cgi?id=179544
3236
3237         Reviewed by Alex Christensen.
3238
3239         * DumpRenderTree/mac/DumpRenderTree.mm:
3240         (enableExperimentalFeatures):
3241
3242 2017-11-14  Commit Queue  <commit-queue@webkit.org>
3243
3244         Unreviewed, rolling out r224800.
3245         https://bugs.webkit.org/show_bug.cgi?id=179684
3246
3247         "Broke CLoop test mozilla/js1_6/Array/regress-304828.js"
3248         (Requested by mlam on #webkit).
3249
3250         Reverted changeset:
3251
3252         "Pass --useDollarVM=true to all JSC tests."
3253         https://bugs.webkit.org/show_bug.cgi?id=179647
3254         https://trac.webkit.org/changeset/224800
3255
3256 2017-11-14  Antti Koivisto  <antti@apple.com>
3257
3258         Enable display:contents by default
3259         https://bugs.webkit.org/show_bug.cgi?id=179655
3260
3261         Reviewed by Sam Weinig.
3262
3263         No need to enable this specifically for tests anymore.
3264
3265         * DumpRenderTree/mac/DumpRenderTree.mm:
3266         (enableExperimentalFeatures):
3267         * WebKitTestRunner/TestController.cpp:
3268         (WTR::TestController::resetPreferencesToConsistentValues):
3269
3270 2017-11-14  Tim Horton  <timothy_horton@apple.com>
3271
3272         Long pressing a phone number with spaces in it results in a link sheet instead of a data detectors sheet
3273         https://bugs.webkit.org/show_bug.cgi?id=179646
3274         <rdar://problem/35337288>
3275
3276         Reviewed by Simon Fraser.
3277
3278         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
3279         (-[ActionSheetObserver _dataDetectionContextForWebView:]):
3280         (TestWebKitAPI::TEST):
3281         Add a test that ensures that a phone number with spaces in it
3282         invokes a data detectors sheet, not a normal link sheet.
3283
3284 2017-11-14  Emilio Cobos Álvarez  <emilio@crisal.io>
3285
3286         Add committer status for Emilio Cobos Álvarez.
3287         https://bugs.webkit.org/show_bug.cgi?id=179667
3288
3289         Unreviewed.
3290
3291         * Scripts/webkitpy/common/config/contributors.json:
3292
3293 2017-11-13  Mark Lam  <mark.lam@apple.com>
3294
3295         Pass --useDollarVM=true to all JSC tests.
3296         https://bugs.webkit.org/show_bug.cgi?id=179647
3297
3298         Reviewed by Saam Barati.
3299
3300         * Scripts/run-jsc-stress-tests:
3301
3302 2017-11-13  Simon Fraser  <simon.fraser@apple.com>
3303
3304         When navigating back to a page, compositing layers may not use accelerated drawing
3305         https://bugs.webkit.org/show_bug.cgi?id=178749
3306         rdar://problem/35158946
3307
3308         Reviewed by Dean Jackson.
3309
3310         Fix WTR and DRT to parse "useAcceleratedDrawing" out of "webkit-test-runner" options
3311         and use it to set the state of the web view.
3312
3313         * DumpRenderTree/TestOptions.h:
3314         * DumpRenderTree/TestOptions.mm:
3315         (TestOptions::TestOptions):
3316         * DumpRenderTree/mac/DumpRenderTree.mm:
3317         (setWebPreferencesForTestOptions):
3318         * WebKitTestRunner/TestController.cpp:
3319         (WTR::TestController::resetPreferencesToConsistentValues):
3320         (WTR::updateTestOptionsFromTestHeader):
3321         * WebKitTestRunner/TestOptions.h:
3322         (WTR::TestOptions::hasSameInitializationOptions const):
3323
3324 2017-11-13  Basuke Suzuki  <Basuke.Suzuki@sony.com>
3325
3326         [Windows] Fix Python error for subprocess.popen with close_fds
3327         https://bugs.webkit.org/show_bug.cgi?id=179553
3328
3329         Reviewed by Per Arne Vollan.
3330
3331         * Scripts/webkitpy/port/server_process.py:
3332         (ServerProcess._start):
3333         (ServerProcess._should_close_fds):
3334
3335 2017-11-13  Michael Catanzaro  <mcatanzaro@igalia.com>
3336
3337         [GTK] Require woff2 1.0.2 and drop direct brotli dependency
3338         https://bugs.webkit.org/show_bug.cgi?id=179630
3339
3340         Reviewed by Frédéric Wang.
3341
3342         * gtk/jhbuild.modules:
3343
3344 2017-11-08  Keith Miller  <keith_miller@apple.com>
3345
3346         Async iteration should only fetch the next method once and add feature flag
3347         https://bugs.webkit.org/show_bug.cgi?id=179451
3348
3349         Reviewed by Geoffrey Garen.
3350
3351         Add feature flag for Async iteration.
3352
3353         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3354
3355 2017-11-13  Gabriel Ivascu  <givascu@igalia.com>
3356
3357         [GTK] Automatically adjust font size when gtk-xft-dpi changes
3358         https://bugs.webkit.org/show_bug.cgi?id=142673
3359
3360         Reviewed by Michael Catanzaro.
3361
3362         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3363         (testWebKitSettings):
3364
3365 2017-11-13  Jonathan Bedard  <jbedard@apple.com>
3366
3367         check-webkit-style cannot construct valid iOS version without an iOS SDK
3368         https://bugs.webkit.org/show_bug.cgi?id=179616
3369         <rdar://problem/35507018>
3370
3371         Reviewed by David Kilzer.
3372
3373         Instead of throwing an exception when we ask for an unavailable SDK on Mac,
3374         we should return None.
3375
3376         * Scripts/webkitpy/common/system/platforminfo.py:
3377         (PlatformInfo.xcode_sdk_version): Return 'None' version if the machine does not
3378         have the requested SDK.
3379
3380 2017-11-13  Keith Miller  <keith_miller@apple.com>
3381
3382         Uninitialized variable in sort-Xcode-project-file
3383         https://bugs.webkit.org/show_bug.cgi?id=179581
3384
3385         Reviewed by Simon Fraser.
3386
3387         Previously all the unified source files were named
3388         UnifiedSource<some-number>.mm. This was changed to
3389         UnifiedSource<some-number>-mm.mm to stop Xcode from creating
3390         hashes for mm and cpp unified source files with the same
3391         number. This broke the expectations in sort-Xcode-project-file.
3392
3393         * Scripts/sort-Xcode-project-file:
3394         (sortChildrenByFileName):
3395         (sortFilesByFileName):
3396
3397 2017-11-13  JF Bastien  <jfbastien@apple.com>
3398
3399         std::expected: fix and test move
3400         https://bugs.webkit.org/show_bug.cgi?id=179617
3401
3402         Reviewed by Alex Christensen.
3403
3404         Test that unique_ptr can be moved around properly, both has a
3405         value and an error (and in a <void, unique> specialization).
3406
3407         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3408         (TestWebKitAPI::snowflake::reset):
3409         (TestWebKitAPI::snowflake::snowflake):
3410         (TestWebKitAPI::snowflake::~snowflake):
3411         (TestWebKitAPI::TEST):
3412
3413 2017-11-13  Basuke Suzuki  <Basuke.Suzuki@sony.com>
3414
3415         [Windows] Make the port's normalize_test_name() method platform independent.
3416         https://bugs.webkit.org/show_bug.cgi?id=179572
3417
3418         Reviewed by Alexey Proskuryakov.
3419
3420         * Scripts/webkitpy/port/base.py:
3421         (Port.normalize_test_name):
3422
3423 2017-11-13  Wenson Hsieh  <wenson_hsieh@apple.com>
3424
3425         [Attachment Support] Implement SPI for clients to request data for a given attachment
3426         https://bugs.webkit.org/show_bug.cgi?id=179586
3427         <rdar://problem/35355720>
3428
3429         Reviewed by Darin Adler.
3430
3431         Augments existing API tests in WKAttachmentTests to additionally check that -requestData: yields the correct
3432         result when performing various editing operations. Also adds a new API test that cuts and pastes an attachment
3433         inserted using WKWebView attachment SPI, and expects that the data of the attachment can still be fetched using
3434         the _WKAttachment SPI, as well as another test that inserts an empty NSData and expects that requestData: also
3435         yields an empty NSData result.
3436
3437         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3438         (-[NSData shortDescription]):
3439         (-[_WKAttachment synchronouslyRequestData:]):
3440         (-[_WKAttachment expectRequestedDataToBe:]):
3441         (TestWebKitAPI::TEST):
3442
3443 2017-11-12  Gabriel Ivascu  <givascu@igalia.com>
3444
3445         [GTK] Add functionality to handle font sizes in points
3446         https://bugs.webkit.org/show_bug.cgi?id=179285
3447
3448         Reviewed by Carlos Garcia Campos and Michael Catanzaro.
3449
3450         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3451         (testWebKitSettings):
3452
3453 2017-11-10  Fujii Hironori  <Hironori.Fujii@sony.com>
3454
3455         check-webkit-style: AttributeError: 'NoneType' object has no attribute 'major'
3456         https://bugs.webkit.org/show_bug.cgi?id=179522
3457
3458         Reviewed by Aakash Jain.
3459
3460         IOSSimulatorPort.ios_version should return a Version object.
3461
3462         * Scripts/webkitpy/port/ios_simulator.py:
3463         (IOSSimulatorPort.ios_version): Return a Version object.
3464
3465 2017-11-10  Basuke Suzuki  <Basuke.Suzuki@sony.com>
3466
3467         [Win] The way to detect Windows 10 is wrong
3468         https://bugs.webkit.org/show_bug.cgi?id=179344
3469
3470         Reviewed by Alex Christensen.
3471
3472         * Scripts/webkitpy/common/system/platforminfo.py:
3473         (PlatformInfo._determine_win_version):
3474
3475 2017-11-10  Basuke Suzuki  <Basuke.Suzuki@sony.com>
3476
3477         [WinCairo] LayoutTests doesn't read TextExpectations files correctly
3478         https://bugs.webkit.org/show_bug.cgi?id=179219
3479
3480         Reviewed by Alex Christensen.
3481
3482         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3483         (TestExpectationParser._parse_line):
3484         * Scripts/webkitpy/port/apple.py:
3485         (ApplePort.__init__):
3486         (ApplePort._allowed_port_names):
3487         (ApplePort):
3488         (ApplePort._future_port_name):
3489         (ApplePort._generate_all_test_configurations):
3490         * Scripts/webkitpy/port/win.py:
3491         (WinCairoPort.default_baseline_search_path):
3492         (WinCairoPort):
3493         (WinCairoPort._future_port_name):
3494
3495 2017-11-10  Basuke Suzuki  <Basuke.Suzuki@sony.com>
3496
3497         [WinCairo] Treat 'future' version correctly
3498         https://bugs.webkit.org/show_bug.cgi?id=179345
3499
3500         Reviewed by Alex Christensen.
3501
3502         * Scripts/webkitpy/port/win.py:
3503         (WinCairoPort.default_baseline_search_path):
3504
3505 2017-11-10  Wenson Hsieh  <wenson_hsieh@apple.com>
3506
3507         Finish rolling out r224544
3508
3509         Rubber-stamped by Tim Horton.
3510
3511         Now that https://bugs.webkit.org/show_bug.cgi?id=179431 has been fixed, we can once again allow one of the API
3512         tests added in r224512 (WKAttachmentTests.AttachmentUpdatesWhenChangingFontStyles) to test toggling underline
3513         style with a selected attachment element.
3514
3515         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3516         (TestWebKitAPI::TEST):
3517
3518 2017-11-10  Alex Christensen  <achristensen@webkit.org>
3519
3520         _WKThumbnailView initialization with WKWebView needs to call correct initWithFrame
3521         https://bugs.webkit.org/show_bug.cgi?id=179537
3522         <rdar://problem/35275219>
3523
3524         Reviewed by Darin Adler.
3525
3526         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
3527         (-[WKThumbnailViewDelegate webView:didFinishNavigation:]):
3528         (TestWebKitAPI::TEST):
3529
3530 2017-11-10  Jonathan Bedard  <jbedard@apple.com>
3531
3532         webkitpy: Remove find_system_pid from port classes
3533         https://bugs.webkit.org/show_bug.cgi?id=179514
3534         <rdar://problem/35456900>
3535
3536         Reviewed by David Kilzer.
3537
3538         Removing dead code.
3539
3540         * Scripts/webkitpy/port/base.py:
3541         (Port.find_system_pid): Deleted.
3542         * Scripts/webkitpy/port/server_process.py:
3543         (ServerProcess._start):
3544         * Scripts/webkitpy/port/win.py:
3545         (WinPort.find_system_pid): Deleted.
3546
3547 2017-11-10  Aakash Jain  <aakash_jain@apple.com>
3548
3549         fix style failures in webkitpy: multiple statements on one line (semicolon)
3550         https://bugs.webkit.org/show_bug.cgi?id=179530
3551
3552         Reviewed by Alex Christensen.
3553
3554         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Removed semicolon.
3555         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: Ditto.
3556         * Scripts/webkitpy/tool/steps/runtests.py: Ditto.
3557
3558 2017-11-10  Aakash Jain  <aakash_jain@apple.com>
3559
3560         fix style failures in webkitpy: expected 2 blank lines found 1
3561         https://bugs.webkit.org/show_bug.cgi?id=179529
3562
3563         Reviewed by Alex Christensen.
3564
3565         * Scripts/webkitpy/benchmark_runner/run_benchmark.py: Added a blank line to follow style guidelines.
3566         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: Ditto.
3567         * Scripts/webkitpy/common/system/platforminfo_mock.py: Ditto.
3568         * Scripts/webkitpy/common/version.py: Ditto.
3569         * Scripts/webkitpy/layout_tests/models/test_failures.py: Ditto.
3570         * Scripts/webkitpy/port/mac_unittest.py: Ditto.
3571         * Scripts/webkitpy/port/simulator_process.py: Ditto.
3572
3573 2017-11-10  Alex Christensen  <achristensen@webkit.org>
3574
3575         REGRESSION(r224267): WebViews scheduled with custom run loop modes don't load
3576         https://bugs.webkit.org/show_bug.cgi?id=179515
3577
3578         Reviewed by Andy Estes.
3579
3580         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3581         * TestWebKitAPI/Tests/mac/WebViewScheduleInRunLoop.mm: Added.
3582         (-[ScheduleInRunLoopDelegate webView:didFinishLoadForFrame:]):
3583         (TestWebKitAPI::TEST):
3584
3585 2017-11-10  Fujii Hironori  <Hironori.Fujii@sony.com>
3586
3587         [webkitpy] Fix PlatformInfo._win_version since r224657
3588         https://bugs.webkit.org/show_bug.cgi?id=179520
3589
3590         Reviewed by Aakash Jain.
3591
3592         There are two problems.
3593
3594         The return value of sys.getwindowsversion() doesn't match with
3595         Version.__init__ expects. Truncate the 4th and 5th of it.
3596
3597         _win_version_tuple_from_cmd was deleted in r224657. But, it is
3598         still needed for Cygwin Python.
3599
3600         * Scripts/webkitpy/common/system/platforminfo.py:
3601         (PlatformInfo._win_version): Return [0:3] of getwindowsversion().
3602         Call _win_version_from_cmd for Cygwin Python.
3603         (PlatformInfo._win_version_from_cmd): Restored.
3604
3605 2017-11-10  Guillaume Emont  <guijemont@igalia.com>
3606
3607         build-jsc: build testmasm for all platforms using cmake
3608         https://bugs.webkit.org/show_bug.cgi?id=179512
3609
3610         Reviewed by Michael Catanzaro.
3611
3612         * Scripts/build-jsc:
3613
3614 2017-11-09  Jonathan Bedard  <jbedard@apple.com>
3615
3616         webkitpy: Unify version parsing code
3617         https://bugs.webkit.org/show_bug.cgi?id=179426
3618         <rdar://problem/35415191>
3619
3620         Unreviewed fix to r224657.
3621
3622         * Scripts/webkitpy/common/version.py:
3623         (Version.__init__): Check if an object is iterable.
3624
3625 2017-11-09  Jonathan Bedard  <jbedard@apple.com>
3626
3627         webkitpy: Unify version parsing code
3628         https://bugs.webkit.org/show_bug.cgi?id=179426
3629         <rdar://problem/35415191>
3630