API tests using permanent credentials should clear credentials left by previous tests
[WebKit-https.git] / Tools / ChangeLog
1 2019-08-02  Sihui Liu  <sihui_liu@apple.com>
2
3         API tests using permanent credentials should clear credentials left by previous tests
4         https://bugs.webkit.org/show_bug.cgi?id=199729
5
6         Reviewed by Alex Christensen.
7
8         We used to clear the permanent credentials created by API tests at the end of the API tests, to ensure those 
9         credentials will not affect tests running after. There is a case where permanent credentials were left on the 
10         system, so those API tests were timing out themselves before reaching to the cleanup, which caused cascading 
11         failure. To prevent this from happening again, add cleanup at the begining of the tests.
12
13         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
14         (TEST):
15         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
16         (TestWebKitAPI::TEST):
17
18 2019-08-02  Andres Gonzalez  <andresg_22@apple.com>
19
20         Add accessibility object method to determine whether an element is inside a table cell. Needed for iOS accessibility client.
21         https://bugs.webkit.org/show_bug.cgi?id=200394
22         <rdar://problem/52914964>
23
24         Reviewed by Chris Fleizach.
25
26         Glue code to exercise new method [WebAccessibilityObjectWrapper _accessibilityIsInTableCell].
27
28         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
29         (WTR::AccessibilityUIElement::isInTableCell const):
30         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
31         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
32         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
33         (WTR::AccessibilityUIElement::isInTableCell const):
34
35 2019-08-02  Zhifei Fang  <zhifei_fang@apple.com>
36
37         [results.webkit.org Timeline] Using transform matrix to calculate the tag rotation position
38         https://bugs.webkit.org/show_bug.cgi?id=200397
39
40         Reviewed by Jonathan Bedard.
41
42         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
43
44 2019-08-02  Wenson Hsieh  <wenson_hsieh@apple.com>
45
46         [macOS 10.15] Image dragged from Safari does not appear in Notes
47         https://bugs.webkit.org/show_bug.cgi?id=188490
48         <rdar://problem/39462717>
49
50         Reviewed by Andy Estes.
51
52         Add a test to verify that promised image data can be delivered to multiple pasteboards when performing a drop.
53
54         * TestWebKitAPI/Tests/mac/DragAndDropTestsMac.mm:
55
56 2019-08-02  Alex Christensen  <achristensen@webkit.org>
57
58         Fix API test after r248139
59         https://bugs.webkit.org/show_bug.cgi?id=200102
60
61         * TestWebKitAPI/Tests/WebKitCocoa/AdditionalReadAccessAllowedURLsPlugin.mm:
62         (-[AdditionalReadAccessAllowedURLsPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
63         This was supposed to be removed as part of reverting r245322.
64
65 2019-08-01  Zhifei Fang  <zhifei_fang@apple.com>
66
67         results.webkit.org: Force update cache when timeline updated
68         https://bugs.webkit.org/show_bug.cgi?id=200363
69
70         Reviewed by Jonathan Bedard.
71
72         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
73         (offscreenCachedRenderFactory): Add ability to force the redraw.
74         (Timeline.CanvasSeriesComponent): Force redraw when scales or dots are updated.
75         (Timeline.CanvasXAxisComponent): Force redraw when scales are updated. Add missing exporter for export scales update API
76
77 2019-08-01  Alex Christensen  <achristensen@webkit.org>
78
79         Do not send NetworkProcessProxy::LogTestingEvent message if we are not testing
80         https://bugs.webkit.org/show_bug.cgi?id=200360
81
82         Reviewed by Tim Horton.
83
84         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
85         (cleanupITPDatabase):
86         (TEST):
87
88 2019-08-01  Alex Christensen  <achristensen@webkit.org>
89
90         Move FormData zip file generation to NetworkProcess and enable it for all WebKit clients for uploading directories
91         https://bugs.webkit.org/show_bug.cgi?id=200102
92         <rdar://problem/53275114>
93
94         Reviewed by Darin Adler.
95
96         Add an API test that is Mac-only right now because runOpenPanelWithParameters is only supported on Mac for some reason
97         and because clicking on a TestWKWebView only works on Mac.
98
99         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
100         * TestWebKitAPI/Tests/WebKitCocoa/UploadDirectory.mm: Added.
101         (-[UploadDelegate initWithDirectory:]):
102         (-[UploadDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
103         (-[UploadDelegate sentDirectory]):
104         (TEST):
105         * TestWebKitAPI/cocoa/TestWKWebView.h:
106         * TestWebKitAPI/cocoa/TestWKWebView.mm:
107         (-[TestWKWebView sendClickAtPoint:]):
108
109 2019-08-01  Zhifei Fang  <zhifei_fang@apple.com>
110
111         [results.webkit.org] Timeline.CanvasXAxisComponent height should be defined by option
112         https://bugs.webkit.org/show_bug.cgi?id=200321
113
114         Reviewed by Jonathan Bedard.
115
116         *resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
117         Let the axis' height be defined in the option. Timeine component will use this value as 
118         padding-top for headers which allows headers start in the right position, even with multiple 
119         top axises.
120         (Timeline.CanvasSeriesComponent):
121         (prototype.Timeline.CanvasContainer):
122
123 2019-08-01  Zhifei Fang  <zhifei_fang@apple.com>
124
125         results.webkit.org: Collision detection for dots is off by 2 * dotMargin
126         https://bugs.webkit.org/show_bug.cgi?id=200347
127
128         Reviewed by Jonathan Bedard.
129
130         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
131         (Timeline.CanvasSeriesComponent): Need to change it to dotMargin + radius other than use a fixed 3 * radius, which is for the old wide timeline
132
133 2019-08-01  Jiewen Tan  <jiewen_tan@apple.com>
134
135         Improve flakiness of SOAuthorizationRedirect tests
136         https://bugs.webkit.org/show_bug.cgi?id=200320
137         <rdar://problem/53767057>
138
139         Reviewed by Alex Christensen.
140
141         This patch replaces Util::sleep(0.5) in tests that expect a SOAuthorization session to wait when the corresponding WKWebView
142         is out of the window with a more precise boolean indicator: navigationPolicyDecided. The new boolean indicator is working and
143         better because the authorizationPerformed should be set in the same runloop when NavigationState::decidePolicyForNavigationAction
144         is executed.
145
146         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
147         (-[TestSOAuthorizationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
148         (resetState):
149         (TestWebKitAPI::TEST):
150
151 2019-08-01  Keith Rollin  <krollin@apple.com>
152
153         Update TestWebKitAPI for XCBuild
154         https://bugs.webkit.org/show_bug.cgi?id=200311
155         <rdar://problem/53773804>
156
157         Reviewed by Alex Christensen.
158
159         Bug 199728 (svn 247402) updated TestWebKitAPI to use the unified-build
160         technique. Now update WebKitLegacy to build under XCBuild after those
161         changes. This work involves adding an "Apply Configuration to
162         XCFileLists" build target, adding a check-xcfilelists.sh script,
163         adding a "Check xcfilelists" build phase that calls that script,
164         adding knowledge of the project to the generate-xcfilelists script,
165         creating new .xcfilelist files, and adding those to the project.
166
167         * Scripts/webkitpy/generate_xcfilelists_lib/application.py:
168         (Application.__init__):
169         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
170         (WebKitTestRunnerGenerator._get_generate_derived_sources_script):
171         (TestWebKitAPIGenerator):
172         (TestWebKitAPIGenerator._get_project_file_path):
173         (TestWebKitAPIGenerator._get_generate_unified_sources_script):
174         * TestWebKitAPI/Scripts/check-xcfilelists.sh: Added.
175         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
176         * TestWebKitAPI/UnifiedSources-output.xcfilelist: Added.
177
178 2019-08-01  Youenn Fablet  <youenn@apple.com>
179
180         UserMediaPermissionRequestManagerProxy should not use audio+video denied requests to deny audio-only or video-only requests
181         https://bugs.webkit.org/show_bug.cgi?id=200317
182
183         Reviewed by Eric Carlson.
184
185         * TestWebKitAPI/Tests/WebKit/getUserMediaAudioVideoCapture.html: Added
186         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
187         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
188         (-[GetUserMediaOnlyAudioUIDelegate _webView:requestMediaCaptureAuthorization:decisionHandler:]):
189         (-[GetUserMediaOnlyAudioUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
190         (TestWebKitAPI::TEST):
191
192 2019-08-01  Aakash Jain  <aakash_jain@apple.com>
193
194         New EWS: Cannot see build status page when patch is waiting for tester
195         https://bugs.webkit.org/show_bug.cgi?id=200333
196
197         Reviewed by Jonathan Bedard.
198
199         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
200         (StatusBubble): While patch hasn't started processing on tester queue, display build information from builder queue.
201
202 2019-08-01  Carlos Garcia Campos  <cgarcia@igalia.com>
203
204         [SOUP] Switch to use libsoup WebSockets API
205         https://bugs.webkit.org/show_bug.cgi?id=200162
206
207         Reviewed by Michael Catanzaro.
208
209         Update libsoup version to 2.67.90.
210
211         * gtk/jhbuild.modules:
212         * wpe/jhbuild.modules:
213
214 2019-07-31  Andy Estes  <aestes@apple.com>
215
216         REGRESSION (r240942): first visually non-empty layout milestone is not reached in media documents until after the video finishes loading
217         https://bugs.webkit.org/show_bug.cgi?id=200293
218         <rdar://problem/52937749>
219
220         Reviewed by Alex Christensen.
221
222         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
223         * TestWebKitAPI/Tests/WebKitCocoa/FirstVisuallyNonEmptyMilestone.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm.
224         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
225         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
226         (-[RenderingProgressNavigationDelegate webView:didFinishNavigation:]):
227         (TEST):
228
229 2019-07-31  Aakash Jain  <aakash_jain@apple.com>
230
231         [ews-build] Enable all macOS queues on new EWS
232         https://bugs.webkit.org/show_bug.cgi?id=199944
233
234         Reviewed by Jonathan Bedard.
235
236         * BuildSlaveSupport/ews-build/config.json: Enabled the triggers for macOS queues.
237         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
238         (StatusBubble): Enabled status-bubbles for mac queues, separated builders and testers bubbles in separate lines. Also
239         removed mac-32bit and mac-32bit-wk2 bubbles, these queues were removed from Buildbot configuration previously.
240         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: Removed mac queues from bot-watcher's dashboard.
241         * QueueStatusServer/config/queues.py: Removed mac queues from old EWS.
242
243 2019-07-31  Ryan Haddad  <ryanhaddad@apple.com>
244
245         Unreviewed test gardening, disable failing test for rdar://51752593.
246
247         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
248
249 2019-07-31  Jonathan Bedard  <jbedard@apple.com>
250
251         results.webkit.og: Timeline in canvas painting with wrong colors, cannot customize scale
252         https://bugs.webkit.org/show_bug.cgi?id=200318
253
254         Reviewed by Aakash Jain.
255
256         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
257         (Timeline.CanvasSeriesComponent): Reset draw context between dots.
258         (Timeline.CanvasXAxisComponent): Use getLabel function.
259
260 2019-07-31  Loïc Yhuel  <loic.yhuel@softathome.com>
261
262         [GTK][WPE] Fix gtkdoc build with "build-webkit --32-bit" on 64-bit hosts
263         https://bugs.webkit.org/show_bug.cgi?id=200306
264
265         Reviewed by Michael Catanzaro.
266
267         gtkdoc-scangobj calls scangobj.py, which only uses LDFLAGS on link (when producing
268         jsc-glib-4.0-scan for example).
269
270         * Scripts/webkitdirs.pm:
271         (generateBuildSystemFromCMakeProject):
272
273 2019-07-31  Ryan Haddad  <ryanhaddad@apple.com>
274
275         Unreviewed test gardening, disable failing test for rdar://52355829.
276
277         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
278         (TEST):
279
280 2019-07-31  Keith Rollin  <krollin@apple.com>
281
282         Update WebKitLegacy for XCBuild
283         https://bugs.webkit.org/show_bug.cgi?id=200310
284         <rdar://problem/53773708>
285
286         Reviewed by Alex Christensen.
287
288         Bug 199771 (svn r247570) updated WebKitLegacy to use the unified-build
289         technique. Now update WebKitLegacy to build under XCBuild after those
290         changes. This work involves adding an "Apply Configuration to
291         XCFileLists" build target, adding a check-xcfilelists.sh script,
292         adding a "Check xcfilelists" build phase that calls that script,
293         adding knowledge of the project to the generate-xcfilelists script,
294         creating new .xcfilelist files, and adding those to the project.
295
296         * Scripts/webkitpy/generate_xcfilelists_lib/application.py:
297         (Application.__init__):
298         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
299         (JavaScriptCoreGenerator):
300         (WebCoreGenerator):
301         (WebKitGenerator):
302         (WebKitGenerator._get_generate_unified_sources_script):
303         (WebKitLegacyGenerator):
304         (WebKitLegacyGenerator._get_project_file_path):
305         (WebKitLegacyGenerator._get_generate_unified_sources_script):
306
307 2019-07-31  Chris Dumez  <cdumez@apple.com>
308
309         REGRESSION (r247486?): Flaky API Test TestWebKitAPI.WKWebView.LocalStorageProcessSuspends
310         https://bugs.webkit.org/show_bug.cgi?id=200086
311         <rdar://problem/53501721>
312
313         Reviewed by Alex Christensen.
314
315         re-enable the API test.
316
317         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:
318         (TEST):
319
320 2019-07-31  Wenson Hsieh  <wenson_hsieh@apple.com>
321
322         [iOS 13] Safari crashes when closing a tab with a focused element if the unified field has focus
323         https://bugs.webkit.org/show_bug.cgi?id=200291
324         <rdar://problem/53717946>
325
326         Reviewed by Megan Gardner.
327
328         Add an API test to exercise the scenario of synchronously requesting the autocorrection context immediately
329         after closing the web view, while the web view's content view isn't the first responder.
330
331         * TestWebKitAPI/Tests/ios/AutocorrectionTestsIOS.mm:
332         * TestWebKitAPI/ios/UIKitSPI.h:
333
334 2019-07-31  Carlos Garcia Campos  <cgarcia@igalia.com>
335
336         [GTK] Datalist element support for TextFieldInputType
337         https://bugs.webkit.org/show_bug.cgi?id=98934
338
339         Reviewed by Michael Catanzaro.
340
341         Implement UIScriptControllerGtk::isShowingDataListSuggestions.
342
343         * WebKitTestRunner/gtk/UIScriptControllerGtk.cpp:
344         (WTR::UIScriptControllerGtk::isShowingDataListSuggestions const):
345         * WebKitTestRunner/gtk/UIScriptControllerGtk.h:
346
347 2019-07-30  Tim Horton  <timothy_horton@apple.com>
348
349         Remove some needless comments that snuck into the tree
350
351         * TestRunnerShared/UIScriptContext/UIScriptController.h:
352         (WTR::UIScriptController::setHardwareKeyboardAttached):
353         (WTR::UIScriptController::playBackEventStream):
354
355 2019-07-30  Fujii Hironori  <Hironori.Fujii@sony.com>
356
357         [WebKit] Add PageLoadState::Observer C API
358         https://bugs.webkit.org/show_bug.cgi?id=199848
359
360         Reviewed by Alex Christensen.
361
362         * MiniBrowser/win/WebKitBrowserWindow.cpp:
363         (WebKitBrowserWindow::WebKitBrowserWindow):
364         (WebKitBrowserWindow::didChangeTitle):
365         (WebKitBrowserWindow::didFinishNavigation): Deleted.
366         * MiniBrowser/win/WebKitBrowserWindow.h:
367         * TestWebKitAPI/CMakeLists.txt:
368         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
369         * TestWebKitAPI/Tests/WebKit/PageLoadState.cpp: Added.
370         (TestWebKitAPI::PageLoadTestState::PageLoadTestState):
371         (TestWebKitAPI::didChangeActiveURL):
372         (TestWebKitAPI::didChangeCanGoBack):
373         (TestWebKitAPI::didChangeCanGoForward):
374         (TestWebKitAPI::didChangeCertificateInfo):
375         (TestWebKitAPI::didChangeEstimatedProgress):
376         (TestWebKitAPI::didChangeHasOnlySecureContent):
377         (TestWebKitAPI::didChangeIsLoading):
378         (TestWebKitAPI::didChangeNetworkRequestsInProgress):
379         (TestWebKitAPI::didChangeTitle):
380         (TestWebKitAPI::didChangeWebProcessIsResponsive):
381         (TestWebKitAPI::didSwapWebProcesses):
382         (TestWebKitAPI::willChangeActiveURL):
383         (TestWebKitAPI::willChangeCanGoBack):
384         (TestWebKitAPI::willChangeCanGoForward):
385         (TestWebKitAPI::willChangeCertificateInfo):
386         (TestWebKitAPI::willChangeEstimatedProgress):
387         (TestWebKitAPI::willChangeHasOnlySecureContent):
388         (TestWebKitAPI::willChangeIsLoading):
389         (TestWebKitAPI::willChangeNetworkRequestsInProgress):
390         (TestWebKitAPI::willChangeTitle):
391         (TestWebKitAPI::willChangeWebProcessIsResponsive):
392         (TestWebKitAPI::didFinishNavigation):
393         (TestWebKitAPI::TEST):
394
395 2019-07-30  Jonathan Bedard  <jbedard@apple.com>
396
397         DumpRenderTree.app: Add CFBundleShortVersionString
398         https://bugs.webkit.org/show_bug.cgi?id=200269
399         <rdar://problem/53412596>
400
401         Rubber-stamped by Aakash Jain.
402
403         * DumpRenderTree/ios/Info.plist:
404
405 2019-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
406
407         Add layout test coverage for <https://webkit.org/b/200215>
408         https://bugs.webkit.org/show_bug.cgi?id=200245
409         <rdar://problem/52976965>
410
411         Reviewed by Tim Horton.
412
413         Add new testing infrastructure. See below for more details.
414
415         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
416         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
417         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
418         (WTR::UIScriptController::setWillCreateNewPageCallback):
419         (WTR::UIScriptController::willCreateNewPageCallback const):
420
421         Add platform-agnostic UIScriptController callback hooks to notify a test when a new page is being created. The
422         new test in this patch uses this opportunity to remove and reinsert the web view into the window's hierarchy.
423
424         * TestRunnerShared/UIScriptContext/UIScriptController.h:
425         (WTR::UIScriptController::becomeFirstResponder):
426
427         Add and implement a Cocoa platform hook to make the web view first responder.
428
429         * WebKitTestRunner/TestController.cpp:
430         (WTR::TestController::createOtherPage):
431         * WebKitTestRunner/TestInvocation.cpp:
432         (WTR::TestInvocation::willCreateNewPage):
433         * WebKitTestRunner/TestInvocation.h:
434         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.h:
435         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm:
436         (WTR::UIScriptControllerCocoa::becomeFirstResponder):
437
438 2019-07-29  Fujii Hironori  <Hironori.Fujii@sony.com>
439
440         [Win][MiniBrowser] Add 'reload' menu item and 'reload' toolbar button
441         https://bugs.webkit.org/show_bug.cgi?id=200217
442
443         Reviewed by Alex Christensen.
444
445         * MiniBrowser/win/BrowserWindow.h:
446         * MiniBrowser/win/MainWindow.cpp:
447         (MainWindow::init):
448         (MainWindow::resizeSubViews):
449         (MainWindow::WndProc):
450         * MiniBrowser/win/MainWindow.h: Added m_hReloadButtonWnd.
451         * MiniBrowser/win/MiniBrowserLib.rc:
452         * MiniBrowser/win/MiniBrowserLibResource.h: Added IDM_RELOAD.
453         * MiniBrowser/win/WebKitBrowserWindow.cpp:
454         (WebKitBrowserWindow::reload):
455         * MiniBrowser/win/WebKitBrowserWindow.h: Added reload() interface.
456         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
457         (WebKitLegacyBrowserWindow::reload):
458         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
459
460 2019-07-29  Fujii Hironori  <Hironori.Fujii@sony.com>
461
462         [Win][MiniBrowser][WK2] Automatically supplement "file://" or "http://" for an input URL as well as WK1 browser window
463         https://bugs.webkit.org/show_bug.cgi?id=200218
464
465         Reviewed by Alex Christensen.
466
467         Moved the scheme supplementing logic from
468         WebKitLegacyBrowserWindow::loadURL to MainWindow::loadURL.
469
470         * MiniBrowser/win/MainWindow.cpp:
471         (MainWindow::loadURL):
472         (MainWindow::onURLBarEnter):
473         * MiniBrowser/win/MainWindow.h:
474         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
475         (WebKitLegacyBrowserWindow::loadURL):
476
477 2019-07-29  Aakash Jain  <aakash_jain@apple.com>
478
479         Disable Flaky API Test TestWebKitAPI.WKWebView.LocalStorageProcessSuspends
480         https://bugs.webkit.org/show_bug.cgi?id=200254
481
482         Unreviewed infrastructure fix.
483
484         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm: Disabled the test.
485
486 2019-07-29  Zhifei Fang  <zhifei_fang@apple.com>
487
488         [Canvas Timeline] Compact canvas timeline
489         https://bugs.webkit.org/show_bug.cgi?id=200177
490
491         Reviewed by Jonathan Bedard.
492
493         * resultsdbpy/resultsdbpy/view/static/library/js/components/BaseComponents.js:
494         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
495         (Timeline.CanvasSeriesComponent):
496
497 2019-07-29  Carlos Garcia Campos  <cgarcia@igalia.com>
498
499         Multiple context menu actions broken for YouTube videos
500         https://bugs.webkit.org/show_bug.cgi?id=199999
501
502         Reviewed by Eric Carlson.
503
504         Add a test case to check copy link address, open in new window and download options are not included in the
505         context menu for non-downloadable media.
506
507         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
508         (writeNextChunk):
509         (serverCallback):
510         (testContextMenuLiveStream):
511         (beforeAll):
512         (afterAll):
513
514 2019-07-28  Tim Horton  <timothy_horton@apple.com>
515
516         Reorganize UIScriptController into platform-specific subclasses
517         https://bugs.webkit.org/show_bug.cgi?id=200027
518
519         Reviewed by Simon Fraser.
520
521         Instead of a mishmash of #ifdefs and extraneous empty functions,
522         reorganize UIScriptController so that we have a base class
523         with functions that assert if called (to make it harder to
524         accidentally write a test that depends on unimplemented
525         functionality), and override them in platform specific subclasses
526         as functionality is added.
527
528         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
529         * DumpRenderTree/ios/UIScriptControllerIOS.h: Added.
530         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
531         * DumpRenderTree/mac/UIScriptControllerMac.h: Added.
532         * DumpRenderTree/mac/UIScriptControllerMac.mm:
533         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
534         * TestRunnerShared/UIScriptContext/UIScriptController.h:
535         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
536         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.h: Added.
537         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm: Added.
538         * WebKitTestRunner/gtk/UIScriptControllerGtk.cpp:
539         * WebKitTestRunner/gtk/UIScriptControllerGtk.h: Added.
540         * WebKitTestRunner/ios/UIScriptControllerIOS.h: Added.
541         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
542         * WebKitTestRunner/mac/UIScriptControllerMac.h: Added.
543         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
544
545 2019-07-28  Fujii Hironori  <Hironori.Fujii@sony.com>
546
547         [Win][MiniBrowser] Remove PageLoadTestClient
548         https://bugs.webkit.org/show_bug.cgi?id=200155
549
550         Reviewed by Brent Fulgham.
551
552         It is not used nowadays.
553
554         * MiniBrowser/win/CMakeLists.txt:
555         * MiniBrowser/win/Common.cpp:
556         (parseCommandLine):
557         * MiniBrowser/win/Common.h:
558         * MiniBrowser/win/MainWindow.cpp:
559         (MainWindow::init):
560         * MiniBrowser/win/MainWindow.h:
561         * MiniBrowser/win/MiniBrowserWebHost.cpp:
562         (MiniBrowserWebHost::updateAddressBar):
563         (MiniBrowserWebHost::didFinishLoadForFrame):
564         (MiniBrowserWebHost::didStartProvisionalLoadForFrame):
565         (MiniBrowserWebHost::didFailLoadWithError):
566         (MiniBrowserWebHost::didHandleOnloadEventsForFrame):
567         (MiniBrowserWebHost::didFirstLayoutInFrame):
568         * MiniBrowser/win/PageLoadTestClient.cpp: Removed.
569         * MiniBrowser/win/PageLoadTestClient.h: Removed.
570         * MiniBrowser/win/ResourceLoadDelegate.cpp:
571         (ResourceLoadDelegate::identifierForInitialRequest):
572         (ResourceLoadDelegate::willSendRequest):
573         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
574         (ResourceLoadDelegate::didFailLoadingWithError):
575         * MiniBrowser/win/WebKitBrowserWindow.cpp:
576         (WebKitBrowserWindow::create):
577         (WebKitBrowserWindow::createNewPage):
578         * MiniBrowser/win/WebKitBrowserWindow.h:
579         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
580         (WebKitLegacyBrowserWindow::create):
581         (WebKitLegacyBrowserWindow::WebKitLegacyBrowserWindow):
582         (WebKitLegacyBrowserWindow::exitProgram): Deleted.
583         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
584         (WebKitLegacyBrowserWindow::pageLoadTestClient): Deleted.
585         * MiniBrowser/win/WinMain.cpp:
586         (wWinMain):
587
588 2019-07-26  Jiewen Tan  <jiewen_tan@apple.com>
589
590         NavigationSOAuthorizationSession should check the active URL of the responding page after waking up from waiting
591         https://bugs.webkit.org/show_bug.cgi?id=200150
592         <rdar://problem/53280170>
593
594         Reviewed by Brent Fulgham.
595
596         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
597         (TestWebKitAPI::TEST):
598
599 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
600
601         Follow-up fix: results.webkit.org: Suite results shouldn't be the landing page
602         https://bugs.webkit.org/show_bug.cgi?id=200090
603
604         Unreviewed follow-up fix.
605
606         * resultsdbpy/resultsdbpy/view/view_routes.py:
607         (ViewRoutes.__init__): Keep /search endpoint for existing links
608
609 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
610
611         results.webkit.org: Add switch to filter results by expectation
612         https://bugs.webkit.org/show_bug.cgi?id=200134
613
614         Rubber-stamped by Aakash Jain.
615
616         Users of the results database should be able to easily differentiate tests which are expected
617         to fail verse tests which are unexpectedly failing.
618
619         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
620         (Timeline.render): Respect the willFilterExpected variable.
621         (LegendLabel): Generates html for label in the legend.
622         (Legend): Add switch for filter results.
623         * resultsdbpy/resultsdbpy/view/templates/search.html: GIve Legend callback to re-render timelines.
624         * resultsdbpy/resultsdbpy/view/templates/suite_results.html:
625
626 2019-07-26  Aakash Jain  <aakash_jain@apple.com>
627
628         [ews-build] Use update-webkit script in Style EWS
629         https://bugs.webkit.org/show_bug.cgi?id=193196
630
631         Reviewed by Jonathan Bedard.
632
633         * BuildSlaveSupport/ews-build/factories.py:
634         (StyleFactory): Updated to use CheckOutSource step as well.
635         * BuildSlaveSupport/ews-build/steps.py: Added build-step to UpdateWorkingDirectory.
636         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
637
638 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
639
640         results.webkit.org: Support buildbot 0.8 CI links
641         https://bugs.webkit.org/show_bug.cgi?id=200146
642
643         Reviewed by Aakash Jain.
644
645         * resultsdbpy/resultsdbpy/model/ci_context.py:
646         (BuildbotEightURLFactory): Buildbot 0.8 link factory.
647         (BuildbotEightURLFactory.__init__):
648         (BuildbotEightURLFactory.url):
649         * resultsdbpy/resultsdbpy/model/ci_context_unittest.py:
650         (URLFactoryTest.test_old_builder_url):
651         (URLFactoryTest):
652         (URLFactoryTest.test_old_worker_url):
653
654 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
655
656         results.webkit.org: Suite results shouldn't be the landing page
657         https://bugs.webkit.org/show_bug.cgi?id=200090
658
659         Reviewed by Aakash Jain.
660
661         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Remove search bar.
662         * resultsdbpy/resultsdbpy/view/view_routes.py:
663         (ViewRoutes.__init__): Make search the landing page instead of suite results.
664         * resultsdbpy/resultsdbpy/view/view_routes_unittest.py:
665         (WebSiteUnittest.test_main):
666
667 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
668
669         Follow-up fix: results.webkit.org: Color should be the worst result, count should include all results
670         https://bugs.webkit.org/show_bug.cgi?id=200127
671
672         Unreviewed follow-up fix.
673
674         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
675         (Dot.toString): Use self instead of this in render callback.
676
677 2019-07-24  Jiewen Tan  <jiewen_tan@apple.com>
678
679         WebPageProxy::receivedPolicyDecision should check navigation ID before clear pendingAPIRequest
680         https://bugs.webkit.org/show_bug.cgi?id=200108
681         <rdar://problem/53521238>
682
683         Reviewed by Chris Dumez.
684
685         Added an API test.
686
687         * TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:
688         (-[DecidePolicyForNavigationActionController webView:decidePolicyForNavigationAction:decisionHandler:]):
689         (TEST):
690
691 2019-07-25  Jonathan Bedard  <jbedard@apple.com>
692
693         results.webkit.org: Color should be the worst result, count should include all results
694         https://bugs.webkit.org/show_bug.cgi?id=200127
695
696         Rubber-stamped by Aakash Jain.
697
698         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
699         (Dot.prototype.toString): Do not differentiate the count based on the prevailing failure type.
700
701 2019-07-25  Zhifei Fang  <zhifei_fang@apple.com>
702
703         [Timeline]: Make timeline header width automatic, instead of fixed width
704         https://bugs.webkit.org/show_bug.cgi?id=200059
705
706         Reviewed by Jonathan Bedard.
707
708         * resultsdbpy/resultsdbpy/view/static/css/timeline.css:
709         (.dot.crash):
710         (.timeline>.header): Deleted.
711         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
712         (.timeline>.content):
713         (.timeline>.header):
714
715 2019-07-25  Ross Kirsling  <ross.kirsling@sony.com>
716
717         [ESNext] Implement nullish coalescing
718         https://bugs.webkit.org/show_bug.cgi?id=200072
719
720         Reviewed by Darin Adler.
721
722         * Scripts/run-jsc-stress-tests:
723
724 2019-07-24  Fujii Hironori  <Hironori.Fujii@sony.com>
725
726         Add Takashi Komori and Tomoki Imai as contributors
727
728         Unreviewed.
729
730         * Scripts/webkitpy/common/config/contributors.json:
731
732 2019-07-24  Yusuke Suzuki  <ysuzuki@apple.com>
733
734         [bmalloc] Add IsoHeap test to ensure that IsoHeap pages are not allocating too large VA
735         https://bugs.webkit.org/show_bug.cgi?id=200103
736
737         Reviewed by Mark Lam.
738
739         This patch adds tests to TestWTF IsoHeap tests to ensure that IsoHeap's component is not leaking pages or not allocating too large VAs for memory allocation.
740         We use VMTag to get the system view of the allocated VAs and check whether it is not incredibly large.
741
742         While the tests are white-box tests (it means that this is a bit flaky to the implementation changes of IsoHeap), I adjusted some threshold to make this less-flaky
743         to the future implementation changes while it catches the severe issues we had.
744
745         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
746         (assertEmptyPointerSet):
747         (assertHasOnlyObjects):
748         (assertClean):
749         (TEST):
750         (allocateAndDeallocate):
751
752 2019-07-24  Fujii Hironori  <fujii.hironori@gmail.com>
753
754         [CMake] CMAKE_SHARED_LINKER_FLAGS drops "-Wl,--no-undefined"
755         https://bugs.webkit.org/show_bug.cgi?id=200074
756
757         Reviewed by Michael Catanzaro.
758
759         There was a latent issue. PluginTest::indicateTestFailure was
760         using WTF::sleep without linking WTF.
761
762         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
763         Added WebKit::WTF to WebKitTestNetscapePlugIn_LIBRARIES.
764
765 2019-07-24  Fujii Hironori  <fujii.hironori@gmail.com>
766
767         [GTK][WPE][CMake] failing to build TestWebKitAPIInjectedBundle due to missing forwarding headers
768         https://bugs.webkit.org/show_bug.cgi?id=200073
769
770         Reviewed by Michael Catanzaro.
771
772         * TestWebKitAPI/PlatformGTK.cmake:
773         * TestWebKitAPI/PlatformWPE.cmake:
774         Added add_dependencies(TestWebKitAPIInjectedBundle TestWebKitAPI-forwarding-headers).
775
776 2019-07-24  Fujii Hironori  <Hironori.Fujii@sony.com>
777
778         [webkitperl] runCommand doesn't work in Windows Perl
779         https://bugs.webkit.org/show_bug.cgi?id=199900
780
781         Reviewed by Don Olmstead.
782
783         runCommand was always failing implicit fork by using 'open' with
784         '-|' in Windows Perl. Explicitly specify the command to 'open' not
785         to do the implicit fork.
786
787         There is one more difference between Windows and Unix. 'open'
788         successes on Windows even for non existent command while it fails
789         on Unix. So, return the same error code on Unix as well as
790         Windows.
791
792         * Scripts/VCSUtils.pm: Specified the command to 'open'.
793         * Scripts/webkitperl/VCSUtils_unittest/runCommand.pl: 'echo'
794         command is not available on Windows. Use Perl ($^X) instead.
795
796 2019-07-24  Priyanka Agarwal  <pagarwal999@apple.com>
797
798         Allow Clients to Add Fields to the AutoFillContext Dictionary.
799         https://bugs.webkit.org/show_bug.cgi?id=199326
800         rdar://problem/42816957
801
802         Reviewed by Wenson Hsieh.
803
804         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
805         (TestWebKitAPI::TEST): Created a test to check that the auto fill context
806         is being properly populated with additional context dictionary.
807
808         * TestWebKitAPI/Tests/ios/TestInputDelegate.h:
809         * TestWebKitAPI/Tests/ios/TestInputDelegate.mm:
810         (-[TestInputDelegate setWebViewAdditionalContextForStrongPasswordAssistanceHandler:]): Setting the handler for the function
811         which will populate the additional autofill context dictionary.
812
813         (-[TestInputDelegate webViewAdditionalContextForStrongPasswordAssistanceHandler]): Returns the handler for the function which
814         populates the additional autofill context dictionary.
815
816         (-[TestInputDelegate _webViewAdditionalContextForStrongPasswordAssistance:]): Function which populates the additional autofill
817         context dictionary.
818
819         (-[TestInputDelegate setFocusRequiresStrongPasswordAssistanceHandler:]): Setting the handler for the function which checks if the 
820         input field requires strong password work.
821
822         (-[TestInputDelegate focusRequiresStrongPasswordAssistanceHandler]): Returns the handler for the function which checks if the
823         input field requires strong password work.
824
825         (-[TestInputDelegate _webView:focusRequiresStrongPasswordAssistance:]): Function which checks if the input field requires strong
826         password work.
827
828 2019-07-24  Zhifei Fang  <zhifei_fang@apple.com>
829
830         run-javascriptcore-tests won't report test results for testmasm, testair, testb3, testdfg and test api
831         https://bugs.webkit.org/show_bug.cgi?id=199489
832
833         Reviewed by Aakash Jain.
834
835         * BuildSlaveSupport/build.webkit.org-config/steps.py:
836         (RunJavaScriptCoreTests.start): Skip run jsc test binaries for mips, armv7, aarch64.
837         (RunJavaScriptCoreTests.countFailures): Pick up the test binaires failure to total failures count
838         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
839         * Scripts/run-javascriptcore-tests: The script now failed wether the run-jsc-stress-tests failed or test binaries failed.
840         (runTest): Record test binary failure
841         (reportTestFailures): Report test binary failure
842         (runJSCStressTests): 
843         * Scripts/webkitpy/common/config/ports.py: Skip run jsc test binaries for those need to run remotely
844         (JscOnlyPort.build_jsc_command):
845         (JscOnlyPort):
846         (JscOnlyPort.run_javascriptcore_tests_command):
847         * Scripts/webkitpy/common/config/ports_unittest.py:
848         (DeprecatedPortTest.test_jsconly_port):
849
850 2019-07-24  Zalan Bujtas  <zalan@apple.com>
851
852         ASSERTION FAILED: settings().textAutosizingEnabled() && settings().textAutosizingUsesIdempotentMode() in WebCore::Page::recomputeTextAutoSizingInAllFrames()
853         https://bugs.webkit.org/show_bug.cgi?id=200079
854         <rdar://problem/53474325>
855
856         Reviewed by Wenson Hsieh.
857
858         Reset textAutosizingUsesIdempotentMode when transitioning to a new test.
859
860         * WebKitTestRunner/ios/TestControllerIOS.mm:
861         (WTR::TestController::platformResetPreferencesToConsistentValues):
862
863 2019-07-23  Fujii Hironori  <Hironori.Fujii@sony.com>
864
865         [webkitperl] prepare-ChangeLog_unittest/parser_unittests.pl is failing on Windows Perl
866         https://bugs.webkit.org/show_bug.cgi?id=199927
867
868         Reviewed by Alex Christensen.
869
870         convertAbsolutepathToWebKitPath was failing to convert paths on
871         Windows Perl due to path separators mismatch.
872
873         Renamed convertAbsolutepathToWebKitPath to
874         convertAbsolutePathToRelativeUnixPath, and changed it to replace
875         paths to relative Unix paths.
876
877         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
878         (convertAbsolutePathToRelativeUnixPath): Added.
879         (convertAbsolutepathToWebKitPath): Deleted.
880
881 2019-07-23  Alex Christensen  <achristensen@webkit.org>
882
883         Fix iOS API test after r247759
884         https://bugs.webkit.org/show_bug.cgi?id=200045
885
886         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
887         (TEST):
888         In the iOS simulator, the WebProcess was being started before we were setting the value on the WKProcessPool.
889         To fix this, set the value on the WKProcessPool before making the WKWebView.  This makes the test always pass on Mac and iOS.
890
891 2019-07-23  Keith Rollin  <krollin@apple.com>
892
893         Remove rest of NavigatorContentUtils support
894         https://bugs.webkit.org/show_bug.cgi?id=200052
895         <rdar://problem/53467357>
896
897         Reviewed by Alex Christensen.
898
899         Bug 196070 removes most of the support for the never-used
900         NavigatorContentUtils facility. However, there were still a couple of
901         left-over references after that change. This patch sweeps those up.
902
903         * Scripts/webkitperl/FeatureList.pm:
904
905 2019-07-23  Alex Christensen  <achristensen@webkit.org>
906
907         Move javaScriptConfigurationDirectory SPI from _WKProcessPoolConfiguration to WKProcessPoolPrivate to make it runtime switchable
908         https://bugs.webkit.org/show_bug.cgi?id=200045
909
910         Reviewed by Mark Lam.
911
912         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
913         (TEST):
914
915 2019-07-23  Russell Epstein  <repstein@apple.com>
916
917         Unreviewed, rolling out r247745.
918
919         This broke API test
920         TestWebKitAPI.WKProcessPool.JavaScriptConfiguration as
921         indicated by EWS
922
923         Reverted changeset:
924
925         "Move javaScriptConfigurationDirectory SPI from
926         _WKProcessPoolConfiguration to WKProcessPoolPrivate to make it
927         runtime switchable"
928         https://bugs.webkit.org/show_bug.cgi?id=200045
929         https://trac.webkit.org/changeset/247745
930
931 2019-07-23  Alex Christensen  <achristensen@webkit.org>
932
933         Move javaScriptConfigurationDirectory SPI from _WKProcessPoolConfiguration to WKProcessPoolPrivate to make it runtime switchable
934         https://bugs.webkit.org/show_bug.cgi?id=200045
935
936         Reviewed by Mark Lam.
937
938         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
939         (TEST):
940
941 2019-07-23  Alex Christensen  <achristensen@webkit.org>
942
943         Add SPI for setting media cache and key location on _WKWebsiteDataStoreConfiguration
944         https://bugs.webkit.org/show_bug.cgi?id=199972
945
946         Reviewed by Jer Noble.
947
948         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
949         (TEST):
950
951 2019-07-23  Alicia Boya García  <aboya@igalia.com>
952
953         [WTF] Add DataMutex and MainThreadData wrappers
954         https://bugs.webkit.org/show_bug.cgi?id=199831
955
956         Reviewed by Alex Christensen.
957
958         Added a very simple test that checks that DataMutex<T> indeed takes
959         the lock and indeed holds data.
960
961         * TestWebKitAPI/CMakeLists.txt:
962         * TestWebKitAPI/Tests/WTF/DataMutex.cpp: Added.
963         (TestWebKitAPI::TEST):
964
965 2019-07-23  Wenson Hsieh  <wenson_hsieh@apple.com>
966
967         [macOS 10.15] Web process crashes when attempting to show the font panel via Font > Show Fonts
968         https://bugs.webkit.org/show_bug.cgi?id=200021
969         <rdar://problem/53301325>
970
971         Reviewed by Ryosuke Niwa.
972
973         Add support for grabbing the child menu items of a context menu item.
974
975         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
976         (WTR::getMenuItemChildrenCallback):
977
978 2019-07-23  Ryosuke Niwa  <rniwa@webkit.org>
979
980         WebKit should strip away system font names from the pasted content
981         https://bugs.webkit.org/show_bug.cgi?id=199975
982         <rdar://problem/53336353>
983
984         Reviewed by Darin Adler.
985
986         Added a test to strip away system font names such as ".AppleSystemUIFont", ".SFUI-Regular", and ".SF UI Mono".
987
988         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
989         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
990         * TestWebKitAPI/Tests/WebKitCocoa/cocoa-writer-markup-with-system-fonts.html: Added.
991
992 2019-07-22  Aakash Jain  <aakash_jain@apple.com>
993
994         [ews-build] EWS fails to parse multi-line full_results.json
995         https://bugs.webkit.org/show_bug.cgi?id=199992
996
997         Reviewed by Alexey Proskuryakov.
998
999         * BuildSlaveSupport/ews-build/layout_test_failures.py:
1000         (LayoutTestFailures.results_from_string): Concatenate content into single line.
1001         * BuildSlaveSupport/ews-build/steps_unittest.py:
1002         (test_parse_results_json_with_newlines): Unit-test to cover this scenario.
1003
1004 2019-07-22  Jonathan Bedard  <jbedard@apple.com>
1005
1006         resultsdbpy: Handle case where the previous commit doesn't have the changelog
1007         https://bugs.webkit.org/show_bug.cgi?id=200015
1008
1009         Reviewed by Aakash Jain.
1010
1011         * resultsdbpy/resultsdbpy/model/repository.py:
1012         (WebKitRepository.commit_for_id.diff_changelogs): Allow the previous_response to be None.
1013
1014 2019-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1015
1016         [iOS] [WK1] UIWebView always jumps to the top left corner when scrolling to reveal the selection
1017         https://bugs.webkit.org/show_bug.cgi?id=200013
1018         <rdar://problem/52526901>
1019
1020         Reviewed by Simon Fraser.
1021
1022         Add a new API test to verify that inserting text in UIWebView causes the document to scroll.
1023
1024         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1025         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollToRevealSelection.mm: Added.
1026         (-[LegacyLoadingDelegate webViewDidFinishLoad:]):
1027         (-[LegacyLoadingDelegate waitForDidFinishLoad]):
1028         * TestWebKitAPI/ios/UIKitSPI.h:
1029
1030 2019-07-22  Jer Noble  <jer.noble@apple.com>
1031
1032         REGRESSION(rUnknown): YouTube playback pauses when switching to a new tab
1033         https://bugs.webkit.org/show_bug.cgi?id=199971
1034         <rdar://problem/51951218>
1035
1036         Reviewed by Alex Christensen.
1037
1038         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1039         * TestWebKitAPI/Tests/WebKitCocoa/NoPauseWhenSwitchingTabs.mm: Added.
1040         (TestWebKitAPI::TEST):
1041
1042 2019-07-22  Aakash Jain  <aakash_jain@apple.com>
1043
1044         [ews-build] Add an EWS to run services tests
1045         https://bugs.webkit.org/show_bug.cgi?id=199994
1046
1047         Reviewed by Jonathan Bedard.
1048
1049         * BuildSlaveSupport/ews-build/config.json: Added Services-EWS configuration.
1050         * BuildSlaveSupport/ews-build/factories.py: Added ServicesFactory.
1051         * BuildSlaveSupport/ews-build/steps.py:
1052         (CheckPatchRelevance): Run this EWS only for patches with changes in relevant files.
1053         (RunEWSUnitTests): Build step to run EWS unit-tests.
1054         (RunEWSBuildbotCheckConfig): Build step to run buildbot checkconfig command.
1055         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1056         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Added services status-bubble.
1057
1058 2019-07-22  Youenn Fablet  <youenn@apple.com>
1059
1060         Disable MediaRecorder for legacy WebKit
1061         https://bugs.webkit.org/show_bug.cgi?id=200001
1062         <rdar://problem/53400030>
1063
1064         Reviewed by Eric Carlson.
1065
1066         Enable MediaRecorder for testing purposes.
1067
1068         * DumpRenderTree/mac/DumpRenderTree.mm:
1069         (createWebViewAndOffscreenWindow):
1070
1071 2019-07-22  Jonathan Bedard  <jbedard@apple.com>
1072
1073         results.webkit.org: Timeline header is too small
1074         https://bugs.webkit.org/show_bug.cgi?id=199955
1075
1076         Reviewed by Aakash Jain.
1077
1078         * resultsdbpy/resultsdbpy/view/static/css/timeline.css:
1079         (.timeline>.header): Make timeline header larder to fit configuration names.
1080
1081 2019-07-22  Alex Christensen  <achristensen@webkit.org>
1082
1083         Add SPI to _WKWebsiteDataStoreConfiguration for configuring application cache storage location
1084         https://bugs.webkit.org/show_bug.cgi?id=199954
1085
1086         Reviewed by Geoff Garen.
1087
1088         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1089         (TEST):
1090
1091 2019-07-22  Alex Christensen  <achristensen@webkit.org>
1092
1093         Add SPI _WKProcessPoolConfiguration.javaScriptConfigurationDirectory
1094         https://bugs.webkit.org/show_bug.cgi?id=199917
1095
1096         Reviewed by Sam Weinig.
1097
1098         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1099         (TEST):
1100
1101 2019-07-22  Aakash Jain  <aakash_jain@apple.com>
1102
1103         [ews-build] ReRunWebKitTests should use similar logic for evaluateCommand as RunWebKitTests
1104         https://bugs.webkit.org/show_bug.cgi?id=199980
1105
1106         Reviewed by Jonathan Bedard.
1107
1108         * BuildSlaveSupport/ews-build/steps.py:
1109         (ReRunWebKitTests.evaluateCommand): Updatd to use similar logic as RunWebKitTests.
1110         * BuildSlaveSupport/ews-build/steps_unittest.py:
1111         (TestRunWebKitTests): Modified to make it generic so as to re-use tests.
1112         (TestReRunWebKitTests): Run all TestRunWebKitTests unit-tests for ReRunWebKitTests as well.
1113
1114 2019-07-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1115
1116         [webkitpy] Add an unit test for setting up the driver environment without starting it.
1117         https://bugs.webkit.org/show_bug.cgi?id=199945
1118
1119         Reviewed by Michael Catanzaro.
1120
1121         This adds an unit test for the change implemented in r247663.
1122
1123         * Scripts/webkitpy/port/driver_unittest.py:
1124         (DriverTest.test_setup_environ_base_vars):
1125         (DriverTest):
1126         (DriverTest.test_setup_environ_without_starting_driver):
1127
1128 2019-07-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1129
1130         [iOS] [WebKit2] Add limited support for -isPosition:atBoundary:inDirection: in WKContentView
1131         https://bugs.webkit.org/show_bug.cgi?id=199993
1132         <rdar://problem/49523528>
1133
1134         Reviewed by Beth Dakin.
1135
1136         Add a new API test to verify the behavior of -isPosition:atBoundary:inDirection:.
1137
1138         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
1139         (TestWebKitAPI::TEST):
1140         * TestWebKitAPI/cocoa/TestWKWebView.h:
1141
1142 2019-07-21  Andres Gonzalez  <andresg_22@apple.com>
1143
1144         Add accessibilityInsertText for text insertion in edit fields.
1145         https://bugs.webkit.org/show_bug.cgi?id=199973
1146
1147         Reviewed by Chris Fleizach.
1148
1149         Renamed accessibilityInsertText to _accessibilityInsertText.
1150
1151         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1152         (AccessibilityUIElement::insertText):
1153         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1154         (AccessibilityUIElement::insertText):
1155         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1156         (WTR::AccessibilityUIElement::insertText):
1157         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1158         (WTR::AccessibilityUIElement::insertText):
1159
1160 2019-07-20  Chris Dumez  <cdumez@apple.com>
1161
1162         Speed up HashTable decoding by reserving capacity and avoiding rehashing
1163         https://bugs.webkit.org/show_bug.cgi?id=199982
1164
1165         Reviewed by Saam Barati.
1166
1167         Add API test coverage.
1168
1169         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1170         (TestWebKitAPI::TEST):
1171
1172 2019-07-20  Andres Gonzalez  <andresg_22@apple.com>
1173
1174         Add accessibilityInsertText for text insertion in edit fields.
1175         https://bugs.webkit.org/show_bug.cgi?id=199973
1176
1177         Reviewed by Chris Fleizach.
1178
1179         Glue code to run new LayoutTests.
1180         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1181         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1182         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1183         (WTR::AccessibilityUIElement::insertText):
1184         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1185         (WTR::AccessibilityUIElement::insertText):
1186         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1187         (WTR::AccessibilityUIElement::insertText):
1188         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
1189         (WTR::AccessibilityUIElement::insertText):
1190
1191 2019-07-19  Zhifei Fang  <zhifei_fang@apple.com>
1192
1193         Move webkit.css to opensource to support resultsdbpy's frontend
1194         https://bugs.webkit.org/show_bug.cgi?id=199957
1195
1196         Reviewed by Jonathan Bedard.
1197
1198         * resultsdbpy/resultsdbpy/view/static/library/css/docs.yaml: Added.
1199         * resultsdbpy/resultsdbpy/view/static/library/css/generate-webkit-css-docs: Added.
1200         * resultsdbpy/resultsdbpy/view/static/library/css/index.html: Added.
1201         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css: Added.
1202
1203 2019-07-19  Zhifei Fang  <zhifei_fang@apple.com>
1204
1205         Move Ref.js to WebKit to support resultsdbpy's frontend
1206         https://bugs.webkit.org/show_bug.cgi?id=199956
1207
1208         Reviewed by Jonathan Bedard.
1209
1210         * resultsdbpy/resultsdbpy/view/static/js/drawer.js:
1211         * resultsdbpy/resultsdbpy/view/static/js/search.js:
1212         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
1213         * resultsdbpy/resultsdbpy/view/static/library/js/Ref.js: Added.
1214         * resultsdbpy/resultsdbpy/view/static/library/js/Utils.js: Added.
1215         * resultsdbpy/resultsdbpy/view/static/library/js/components/BaseComponents.js: Added.
1216         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js: Added.
1217         * resultsdbpy/resultsdbpy/view/templates/base.html:
1218         * resultsdbpy/resultsdbpy/view/templates/commits.html:
1219         * resultsdbpy/resultsdbpy/view/templates/documentation.html:
1220         * resultsdbpy/resultsdbpy/view/templates/search.html:
1221         * resultsdbpy/resultsdbpy/view/templates/suite_results.html:
1222         * resultsdbpy/resultsdbpy/view/view_routes.py:
1223
1224 2019-07-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1225
1226         [webkitpy] Allow the testrunner driver to setup the environment completely without needing to start the server process.
1227         https://bugs.webkit.org/show_bug.cgi?id=199945
1228
1229         Reviewed by Michael Catanzaro.
1230
1231         Refactor the code to create the Driver temporal directories inside Driver._setup_environ_for_driver().
1232         This allows external callers to setup the environment for running tests by calling that method without needing to start the server process.
1233         When this callers finish testing, it is enough with calling either Driver.stop() or Driver._delete_temporal_directories().
1234
1235         * Scripts/webkitpy/port/driver.py:
1236         (Driver._setup_environ_for_driver):
1237         (Driver._create_temporal_directories):
1238         (Driver):
1239         (Driver._start):
1240         (Driver._delete_temporal_directories):
1241         (Driver.stop):
1242         * Scripts/webkitpy/w3c/wpt_runner.py: Not needed anymore to start the driver since this doesnt need the server process running.
1243         (main):
1244         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py: Ditto.
1245         (WebDriverTestRunner.__init__):
1246         * glib/api_test_runner.py:
1247         (TestRunner._setup_testing_environment): Ditto.
1248
1249 2019-07-19  Aakash Jain  <aakash_jain@apple.com>
1250
1251         [ews-build] Display pre-existing Layout test failure names in the build summary
1252         https://bugs.webkit.org/show_bug.cgi?id=199941
1253
1254         Reviewed by Jonathan Bedard.
1255
1256         * BuildSlaveSupport/ews-build/steps.py:
1257         (AnalyzeLayoutTestsResults.report_pre_existing_failures):
1258
1259 2019-07-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1260
1261         [GTK][WPE] run-webkit-tests should run with a temporal homedir
1262         https://bugs.webkit.org/show_bug.cgi?id=199738
1263
1264         Reviewed by Michael Catanzaro.
1265
1266         Run the tests with an empty homedir that is created inside the driver tmpdir.
1267         The driver tmpdir is a random directory created for each test runner that is purged after the run.
1268
1269         This is done to ensure that the test results are not affected by the user settings of any library.
1270
1271         * Scripts/webkitpy/port/driver.py:
1272         (Driver._setup_environ_for_driver):
1273         * Scripts/webkitpy/port/driver_unittest.py:
1274         (DriverTest.test_setup_environ_base_vars):
1275         (DriverTest):
1276         (DriverTest.test_create_temporal_home_dir):
1277
1278 2019-07-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1279
1280         Remove pywebsockets from thirdparty
1281         https://bugs.webkit.org/show_bug.cgi?id=199710
1282
1283         Reviewed by Jonathan Bedard.
1284
1285         We have a very old version of pywebsocket in webkitpy thirdparty, but we are also importing pywebsocket as part
1286         of wpt tools. We can simply use the wpt one for all websocket tests and remove the old copy from sources.
1287
1288         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
1289         (PyWebSocket._prepare_config): Use pywebsocket from imported w3c tools directory.
1290         * Scripts/webkitpy/thirdparty/mod_pywebsocket/COPYING: Removed.
1291         * Scripts/webkitpy/thirdparty/mod_pywebsocket/__init__.py: Removed.
1292         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_base.py: Removed.
1293         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hixie75.py: Removed.
1294         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hybi.py: Removed.
1295         * Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py: Removed.
1296         * Scripts/webkitpy/thirdparty/mod_pywebsocket/dispatch.py: Removed.
1297         * Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py: Removed.
1298         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/__init__.py: Removed.
1299         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/_base.py: Removed.
1300         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi.py: Removed.
1301         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi00.py: Removed.
1302         * Scripts/webkitpy/thirdparty/mod_pywebsocket/headerparserhandler.py: Removed.
1303         * Scripts/webkitpy/thirdparty/mod_pywebsocket/http_header_util.py: Removed.
1304         * Scripts/webkitpy/thirdparty/mod_pywebsocket/memorizingfile.py: Removed.
1305         * Scripts/webkitpy/thirdparty/mod_pywebsocket/msgutil.py: Removed.
1306         * Scripts/webkitpy/thirdparty/mod_pywebsocket/mux.py: Removed.
1307         * Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py: Removed.
1308         * Scripts/webkitpy/thirdparty/mod_pywebsocket/stream.py: Removed.
1309         * Scripts/webkitpy/thirdparty/mod_pywebsocket/util.py: Removed.
1310
1311 2019-07-18  Jonathan Bedard  <jbedard@apple.com>
1312
1313         results.webkit.org: Move resultsdbpy to WebKit
1314         https://bugs.webkit.org/show_bug.cgi?id=199837
1315         <rdar://problem/53172130>
1316
1317         Rubber-stamped by Aakash Jain.
1318
1319         Moving the entirety of the resultsdbpy library, which provides utilities to build
1320         a database designed to store, visualize and organize test results, into WebKit.
1321
1322         * Scripts/webkitpy/style/checker.py:
1323         (CheckerDispatcher._create_checker): resulltsdbpy is a Python 3 library.
1324         * resultsdbpy: Added.
1325         * resultsdbpy/MANIFEST.in: Added.
1326         * resultsdbpy/README.md: Added.
1327         * resultsdbpy/resultsdbpy: Added.
1328         * resultsdbpy/resultsdbpy/__init__.py: Added.
1329         * resultsdbpy/resultsdbpy/controller: Added.
1330         * resultsdbpy/resultsdbpy/controller/__init__.py: Added.
1331         * resultsdbpy/resultsdbpy/controller/api_routes.py: Added.
1332         * resultsdbpy/resultsdbpy/controller/ci_controller.py: Added.
1333         * resultsdbpy/resultsdbpy/controller/ci_controller_unittest.py: Added.
1334         * resultsdbpy/resultsdbpy/controller/commit.py: Added.
1335         * resultsdbpy/resultsdbpy/controller/commit_controller.py: Added.
1336         * resultsdbpy/resultsdbpy/controller/commit_controller_unittest.py: Added.
1337         * resultsdbpy/resultsdbpy/controller/commit_unittest.py: Added.
1338         * resultsdbpy/resultsdbpy/controller/configuration.py: Added.
1339         * resultsdbpy/resultsdbpy/controller/configuration_controller.py: Added.
1340         * resultsdbpy/resultsdbpy/controller/configuration_controller_unittest.py: Added.
1341         * resultsdbpy/resultsdbpy/controller/configuration_unittest.py: Added.
1342         * resultsdbpy/resultsdbpy/controller/suite_controller.py: Added.
1343         * resultsdbpy/resultsdbpy/controller/suite_controller_unittest.py: Added.
1344         * resultsdbpy/resultsdbpy/controller/test_controller.py: Added.
1345         * resultsdbpy/resultsdbpy/controller/test_controller_unittest.py: Added.
1346         * resultsdbpy/resultsdbpy/controller/upload_controller.py: Added.
1347         * resultsdbpy/resultsdbpy/controller/upload_controller_unittest.py: Added.
1348         * resultsdbpy/resultsdbpy/flask_support: Added.
1349         * resultsdbpy/resultsdbpy/flask_support/__init__.py: Added.
1350         * resultsdbpy/resultsdbpy/flask_support/authed_blueprint.py: Added.
1351         * resultsdbpy/resultsdbpy/flask_support/flask_test_context.py: Added.
1352         * resultsdbpy/resultsdbpy/flask_support/flask_testcase.py: Added.
1353         * resultsdbpy/resultsdbpy/flask_support/util.py: Added.
1354         * resultsdbpy/resultsdbpy/flask_support/util_unittest.py: Added.
1355         * resultsdbpy/resultsdbpy/model: Added.
1356         * resultsdbpy/resultsdbpy/model/__init__.py: Added.
1357         * resultsdbpy/resultsdbpy/model/cassandra_context.py: Added.
1358         * resultsdbpy/resultsdbpy/model/cassandra_context_unittest.py: Added.
1359         * resultsdbpy/resultsdbpy/model/casserole.py: Added.
1360         * resultsdbpy/resultsdbpy/model/casserole_unittest.py: Added.
1361         * resultsdbpy/resultsdbpy/model/ci_context.py: Added.
1362         * resultsdbpy/resultsdbpy/model/ci_context_unittest.py: Added.
1363         * resultsdbpy/resultsdbpy/model/commit_context.py: Added.
1364         * resultsdbpy/resultsdbpy/model/commit_context_unittest.py: Added.
1365         * resultsdbpy/resultsdbpy/model/configuration_context.py: Added.
1366         * resultsdbpy/resultsdbpy/model/configuration_context_unittest.py: Added.
1367         * resultsdbpy/resultsdbpy/model/docker-compose.yml: Added.
1368         * resultsdbpy/resultsdbpy/model/docker.py: Added.
1369         * resultsdbpy/resultsdbpy/model/docker_unittest.py: Added.
1370         * resultsdbpy/resultsdbpy/model/mock_cassandra_context.py: Added.
1371         * resultsdbpy/resultsdbpy/model/mock_model_factory.py: Added.
1372         * resultsdbpy/resultsdbpy/model/mock_repository.py: Added.
1373         * resultsdbpy/resultsdbpy/model/model.py: Added.
1374         * resultsdbpy/resultsdbpy/model/partitioned_redis.py: Added.
1375         * resultsdbpy/resultsdbpy/model/partitioned_redis_unittest.py: Added.
1376         * resultsdbpy/resultsdbpy/model/redis_unittest.py: Added.
1377         * resultsdbpy/resultsdbpy/model/repository.py: Added.
1378         * resultsdbpy/resultsdbpy/model/repository_unittest.py: Added.
1379         * resultsdbpy/resultsdbpy/model/suite_context.py: Added.
1380         * resultsdbpy/resultsdbpy/model/suite_context_unittest.py: Added.
1381         * resultsdbpy/resultsdbpy/model/test_context.py: Added.
1382         * resultsdbpy/resultsdbpy/model/test_context_unittest.py: Added.
1383         * resultsdbpy/resultsdbpy/model/upload_context.py: Added.
1384         * resultsdbpy/resultsdbpy/model/upload_context_unittest.py: Added.
1385         * resultsdbpy/resultsdbpy/model/wait_for_docker_test_case.py: Added.
1386         * resultsdbpy/resultsdbpy/run-tests: Added.
1387         * resultsdbpy/resultsdbpy/view: Added.
1388         * resultsdbpy/resultsdbpy/view/__init__.py: Added.
1389         * resultsdbpy/resultsdbpy/view/ci_view.py: Added.
1390         * resultsdbpy/resultsdbpy/view/commit_view.py: Added.
1391         * resultsdbpy/resultsdbpy/view/commit_view_unittest.py: Added.
1392         * resultsdbpy/resultsdbpy/view/site_menu.py: Added.
1393         * resultsdbpy/resultsdbpy/view/static: Added.
1394         * resultsdbpy/resultsdbpy/view/static/css: Added.
1395         * resultsdbpy/resultsdbpy/view/static/css/commit.css: Added.
1396         * resultsdbpy/resultsdbpy/view/static/css/drawer.css: Added.
1397         * resultsdbpy/resultsdbpy/view/static/css/search.css: Added.
1398         * resultsdbpy/resultsdbpy/view/static/css/timeline.css: Added.
1399         * resultsdbpy/resultsdbpy/view/static/js: Added.
1400         * resultsdbpy/resultsdbpy/view/static/js/commit.js: Added.
1401         * resultsdbpy/resultsdbpy/view/static/js/common.js: Added.
1402         * resultsdbpy/resultsdbpy/view/static/js/configuration.js: Added.
1403         * resultsdbpy/resultsdbpy/view/static/js/drawer.js: Added.
1404         * resultsdbpy/resultsdbpy/view/static/js/search.js: Added.
1405         * resultsdbpy/resultsdbpy/view/static/js/timeline.js: Added.
1406         * resultsdbpy/resultsdbpy/view/suite_view.py: Added.
1407         * resultsdbpy/resultsdbpy/view/templates: Added.
1408         * resultsdbpy/resultsdbpy/view/templates/base.html: Added.
1409         * resultsdbpy/resultsdbpy/view/templates/commit.html: Added.
1410         * resultsdbpy/resultsdbpy/view/templates/commits.html: Added.
1411         * resultsdbpy/resultsdbpy/view/templates/documentation.html: Added.
1412         * resultsdbpy/resultsdbpy/view/templates/error.html: Added.
1413         * resultsdbpy/resultsdbpy/view/templates/search.html: Added.
1414         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Added.
1415         * resultsdbpy/resultsdbpy/view/view_routes.py: Added.
1416         * resultsdbpy/resultsdbpy/view/view_routes_unittest.py: Added.
1417         * resultsdbpy/setup.py: Added.
1418
1419 2019-07-18  Alex Christensen  <achristensen@webkit.org>
1420
1421         Add and test _WKWebsiteDataStoreConfiguration.deviceIdHashSaltsStorageDirectory SPI
1422         https://bugs.webkit.org/show_bug.cgi?id=199923
1423
1424         Reviewed by Youenn Fablet.
1425
1426         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
1427         (TestWebKitAPI::TEST):
1428
1429 2019-07-18  Aakash Jain  <aakash_jain@apple.com>
1430
1431         [ews-build] Enable iOS WK2 tester queue on new EWS
1432         https://bugs.webkit.org/show_bug.cgi?id=199867
1433
1434         Reviewed by Jonathan Bedard.
1435
1436         * BuildSlaveSupport/ews-build/config.json: Enabled the triggers for ios-wk2 queue.
1437         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Enabled ios-sim (builder) and ios-wk2 (tester) bubbles.
1438         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: Removed ios-sim queue from bot-watcher's dashboard.
1439         * QueueStatusServer/config/queues.py: Removed ios-sim queue from old EWS.
1440
1441 2019-07-18  Aakash Jain  <aakash_jain@apple.com>
1442
1443         [ews-build] Add build step to AnalyzeLayoutTestsResults
1444         https://bugs.webkit.org/show_bug.cgi?id=199877
1445
1446         Reviewed by Jonathan Bedard.
1447
1448         Logic is ported from webkitpy/tool/bot/patchanalysistask.py::_retry_layout_tests()
1449
1450         * BuildSlaveSupport/ews-build/steps.py:
1451         (RunWebKitTestsWithoutPatch.evaluateCommand): invoke AnalyzeLayoutTestsResults step.
1452         (AnalyzeLayoutTestsResults): Build step to analyze layout-test results.
1453         (AnalyzeLayoutTestsResults.report_failure):
1454         (AnalyzeLayoutTestsResults.report_pre_existing_failures):
1455         (AnalyzeLayoutTestsResults.retry_build):
1456         (AnalyzeLayoutTestsResults._results_failed_different_tests):
1457         (AnalyzeLayoutTestsResults._report_flaky_tests):
1458         (AnalyzeLayoutTestsResults.start):
1459         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1460
1461 2019-07-18  Alex Christensen  <achristensen@webkit.org>
1462
1463         Move NetworkCache ownership from NetworkProcess to NetworkSession
1464         https://bugs.webkit.org/show_bug.cgi?id=199817
1465
1466         Reviewed by Geoff Garen.
1467
1468         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1469         (TEST):
1470         * TestWebKitAPI/cocoa/TestWKWebView.h:
1471         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1472         (-[WKWebView synchronouslyLoadRequest:]):
1473
1474 2019-07-18  Youenn Fablet  <youenn@apple.com>
1475
1476         Make sure to set kCTFontFallbackOptionAttribute to kCTFontFallbackOptionSystem for system fonts
1477         https://bugs.webkit.org/show_bug.cgi?id=199769
1478         <rdar://problem/49390297>
1479
1480         Reviewed by Myles C. Maxfield.
1481
1482         Add a font containing one extended character not found in system fonts.
1483
1484         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1485         * WebKitTestRunner/fonts/FakeHelvetica-SingleExtendedCharacter.ttf: Added.
1486
1487 2019-07-18  Konstantin Tokarev  <annulen@yandex.ru>
1488
1489         Unreviewed, Add Olivier Blin as contributor
1490
1491         * Scripts/webkitpy/common/config/contributors.json:
1492
1493 2019-07-17  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1494
1495         [GTK][WPE][webkitpy] Refactor drivers to use the base driver for setting up the environment and start the drivers.
1496         https://bugs.webkit.org/show_bug.cgi?id=199855
1497
1498         Reviewed by Michael Catanzaro.
1499
1500         The webkitpy drivers for GTK and WPE use their own versions for setting
1501         up the environment and starting/stopping the drivers.
1502         This refactors those drivers to use the base class driver functions.
1503         As a benefit we get some fixes like support for setting the profiler
1504         environment variables, and a simpler code.
1505
1506         * Scripts/webkitpy/port/driver.py:
1507         (Driver._setup_environ_for_driver): This already correctly setups LOCAL_RESOURCE_ROOT and DUMPRENDERTREE_TEMP.
1508         Add the remaining environment variable XDG_CACHE_HOME that is needed for Linux.
1509         * Scripts/webkitpy/port/headlessdriver.py:
1510         (HeadlessDriver._setup_environ_for_test):
1511         * Scripts/webkitpy/port/waylanddriver.py:
1512         (WaylandDriver._setup_environ_for_test):
1513         * Scripts/webkitpy/port/westondriver.py:
1514         (WestonDriver._setup_environ_for_test):
1515         (WestonDriver.stop):
1516         * Scripts/webkitpy/port/westondriver_unittest.py: now mock _test_runner_process_constructor as base driver does.
1517         (WestonDriverTest.make_driver):
1518         * Scripts/webkitpy/port/xorgdriver.py:
1519         (XorgDriver._setup_environ_for_test):
1520         * Scripts/webkitpy/port/xvfbdriver.py: the xvfb binary is started with the port server env
1521         (XvfbDriver._setup_environ_for_test):
1522         * Scripts/webkitpy/port/xvfbdriver_unittest.py: rename the variable to make clearer that it uses the port server env.
1523         (XvfbDriverTest.make_driver):
1524         (XvfbDriverTest.test_start):
1525         (XvfbDriverTest.test_start_arbitrary_worker_number):
1526         * Scripts/webkitpy/w3c/wpt_runner.py:
1527         (main): Start the driver before trying to get its environment to define all the environment variables.
1528         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
1529         (WebDriverTestRunner.__init__): Ditto.
1530         * glib/api_test_runner.py:
1531         (TestRunner._setup_testing_environment): Ditto.
1532
1533 2019-07-17  Antoine Quint  <graouts@apple.com>
1534
1535         Disable Pointer Events prior to watchOS 6
1536         https://bugs.webkit.org/show_bug.cgi?id=199890
1537         <rdar://problem/53206113>
1538
1539         Reviewed by Dean Jackson.
1540
1541         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1542
1543 2019-07-17  Christopher Reid  <chris.reid@sony.com>
1544
1545         Bytecode cache should use FileSystem
1546         https://bugs.webkit.org/show_bug.cgi?id=199759
1547
1548         Reviewed by Yusuke Suzuki.
1549
1550         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
1551
1552 2019-07-17  Jonathan Bedard  <jbedard@apple.com>
1553
1554         check-webkit-style: Add limited Python3 support
1555         https://bugs.webkit.org/show_bug.cgi?id=199870
1556
1557         Rubber-stamped by Aakash Jain.
1558
1559         Since new services will be added in the near future which are Python 3, we
1560         need to support Python 3 style checks. For now, assume all Python files are
1561         Python 2 unless otherwise specified.
1562
1563         * Scripts/webkitpy/style/checker.py:
1564         (_all_categories): Add pycodestyle to valid categories for testing.
1565         (CheckerDispatcher._create_checker): Check that the provided Python file is in
1566         one of the declared Python 3 directories.
1567         * Scripts/webkitpy/style/checkers/python.py:
1568         (Python3Checker): Add Python 3 checker, which doesn't lint and uses pycodestyle
1569         instead of pep8.
1570         (Python3Checker.__init__):
1571         (Python3Checker.check):
1572         * Scripts/webkitpy/thirdparty/__init__.py:
1573         (AutoinstallImportHook.find_module): Support auto-installing pycodestyle.
1574         (AutoinstallImportHook._install_pycodestyle):
1575
1576 2019-07-17  Sam Weinig  <weinig@apple.com>
1577
1578         Add StringBuilder member function which allows makeString() style variadic argument construction
1579         https://bugs.webkit.org/show_bug.cgi?id=198997
1580
1581         Reviewed by Darin Adler.
1582
1583         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1584         Add basic test showing that StringBuilder::flexibleAppend can be used to 
1585         append one or more string adaptable types. 
1586
1587         * TestWebKitAPI/CMakeLists.txt:
1588         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1589         Add WTFStringUtilities.cpp
1590
1591         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1592         Add basic test showing that StringBuilder::flexibleAppend can be used to 
1593         append one or more string adaptable types. 
1594
1595         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
1596         * TestWebKitAPI/WTFStringUtilities.cpp: Added.
1597         * TestWebKitAPI/WTFStringUtilities.h:
1598         Move WTF_STRINGTYPEADAPTER_COPIED_WTF_STRING() and wtfStringCopyCount to WTFStringUtilities.h/cpp
1599         to allow for a single definition of StringTypeAdapter<String, void> which is required for ODR.
1600
1601 2019-07-17  Ryosuke Niwa  <rniwa@webkit.org>
1602
1603         Remove the file superfluously added in r247535.
1604
1605         * TestWebKitAPI/Tests/ios/SelectionModifyByParagraphBoundary.h: Removed.
1606         * TestWebKitAPI/Tests/ios/SelectionModifyByParagraphBoundary.mm:
1607
1608 2019-07-17  Alex Christensen  <achristensen@webkit.org>
1609
1610         Add a runtime-disabled dialog element skeleton
1611         https://bugs.webkit.org/show_bug.cgi?id=199839
1612
1613         Reviewed by Ryosuke Niwa.
1614
1615         * DumpRenderTree/mac/DumpRenderTree.mm:
1616         (resetWebPreferencesToConsistentValues):
1617         * WebKitTestRunner/TestController.cpp:
1618         (WTR::TestController::resetPreferencesToConsistentValues):
1619         Enable the dialog element for layout tests.
1620
1621 2019-07-17  Ryosuke Niwa  <rniwa@webkit.org>
1622
1623         [iOS] Option + Up or Down Arrow key doesn’t move cursor past paragraph boundaries in WebKit2
1624         https://bugs.webkit.org/show_bug.cgi?id=199851
1625
1626         Reviewed by Wenson Hsieh.
1627
1628         Added a regression test for iOS. Unfortunately, event sender, etc... doesn't work because
1629         this code is getting directly triggered from UIKeyboard's code.
1630
1631         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1632         * TestWebKitAPI/Tests/ios/SelectionModifyByParagraphBoundary.h: Added.
1633         * TestWebKitAPI/Tests/ios/SelectionModifyByParagraphBoundary.mm: Added.
1634         * TestWebKitAPI/ios/UIKitSPI.h:
1635
1636 2019-07-17  Commit Queue  <commit-queue@webkit.org>
1637
1638         Unreviewed, rolling out r247505.
1639         https://bugs.webkit.org/show_bug.cgi?id=199871
1640
1641         "Caused failed ASSERT in stress test" (Requested by creid on
1642         #webkit).
1643
1644         Reverted changeset:
1645
1646         "Bytecode cache should use FileSystem"
1647         https://bugs.webkit.org/show_bug.cgi?id=199759
1648         https://trac.webkit.org/changeset/247505
1649
1650 2019-07-17  Russell Epstein  <russell_e@apple.com>
1651
1652         Adding self to contributors.json
1653
1654         Unreviewed.
1655
1656         * Scripts/webkitpy/common/config/contributors.json:
1657
1658 2019-07-17  Aakash Jain  <aakash_jain@apple.com>
1659
1660         [ews-build] Parse full_results.json for layout-tests
1661         https://bugs.webkit.org/show_bug.cgi?id=199804
1662
1663         Reviewed by Jonathan Bedard.
1664
1665         * BuildSlaveSupport/ews-build/steps.py:
1666         (RunWebKitTests.start): Monitor json output.
1667         (RunWebKitTests.commandComplete): Read json output, parse the results and set Buildbot properties accordingly. These
1668         properties would be used in subsequent AnalyzeLayoutTests build step to determine whether the failures are introduced
1669         by the patch or are pre-existing.
1670         (ReRunWebKitTests.commandComplete): Ditto.
1671         (RunWebKitTestsWithoutPatch.commandComplete): Ditto.
1672         * BuildSlaveSupport/ews-build/steps_unittest.py:
1673         (BuildStepMixinAdditions.getProperty): Added.
1674         (TestRunWebKitTests.test_parse_results_json): Added unit-tests.
1675         * BuildSlaveSupport/ews-build/layout_test_failures.py: Parse full_results.json and generate list of failing tests.
1676
1677 2019-07-17  Michael Catanzaro  <mcatanzaro@igalia.com>
1678
1679         Unreviewed, rolling out r247512.
1680
1681         Broke API test runners
1682
1683         Reverted changeset:
1684
1685         "[GTK][WPE][webkitpy] Refactor drivers to use the base driver
1686         for setting up the environment and start the drivers."
1687         https://bugs.webkit.org/show_bug.cgi?id=199855
1688         https://trac.webkit.org/changeset/247512
1689
1690 2019-07-17  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1691
1692         [GTK][WPE][webkitpy] Refactor drivers to use the base driver for setting up the environment and start the drivers.
1693         https://bugs.webkit.org/show_bug.cgi?id=199855
1694
1695         Reviewed by Carlos Garcia Campos.
1696
1697         The webkitpy drivers for GTK and WPE use their own versions for setting
1698         up the environment and starting/stopping the drivers.
1699         This refactors those drivers to use the base class driver functions.
1700         As a benefit we get some fixes like support for setting the profiler
1701         environment variables, and a simpler code.
1702
1703         * Scripts/webkitpy/port/driver.py:
1704         (Driver._setup_environ_for_driver): This already correctly setups LOCAL_RESOURCE_ROOT and DUMPRENDERTREE_TEMP.
1705         Add the remaining environment variable XDG_CACHE_HOME that is needed for Linux.
1706         * Scripts/webkitpy/port/headlessdriver.py:
1707         (HeadlessDriver._setup_environ_for_test):
1708         * Scripts/webkitpy/port/waylanddriver.py:
1709         (WaylandDriver._setup_environ_for_test):
1710         * Scripts/webkitpy/port/westondriver.py:
1711         (WestonDriver._setup_environ_for_test):
1712         (WestonDriver.stop):
1713         * Scripts/webkitpy/port/westondriver_unittest.py: now mock _test_runner_process_constructor as base driver does.
1714         (WestonDriverTest.make_driver):
1715         * Scripts/webkitpy/port/xorgdriver.py:
1716         (XorgDriver._setup_environ_for_test):
1717         * Scripts/webkitpy/port/xvfbdriver.py: the xvfb binary is started with the port server env
1718         (XvfbDriver._setup_environ_for_test):
1719         * Scripts/webkitpy/port/xvfbdriver_unittest.py: rename the variable to make clearer that it uses the port server env.
1720         (XvfbDriverTest.make_driver):
1721         (XvfbDriverTest.test_start):
1722         (XvfbDriverTest.test_start_arbitrary_worker_number):
1723
1724 2019-07-16  Christopher Reid  <chris.reid@sony.com>
1725
1726         Bytecode cache should use FileSystem
1727         https://bugs.webkit.org/show_bug.cgi?id=199759
1728
1729         Reviewed by Yusuke Suzuki.
1730
1731         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
1732
1733 2019-07-16  Jonathan Bedard  <jbedard@apple.com>
1734
1735         svn-create-patch duplicates diffs when adding directories
1736         https://bugs.webkit.org/show_bug.cgi?id=199842
1737
1738         Reviewed by Dewei Zhu.
1739
1740         * Scripts/svn-create-patch:
1741         (findKind): Add function which returns what 'kind' of file the provided path is.
1742         (generateFileList): If the path is a directory and being added, don't add it.
1743         Instead, rely on the fact that its children will be added.
1744
1745 2019-07-16  Tim Horton  <timothy_horton@apple.com>
1746
1747         NSTextFinder holes don't scroll with the page
1748         https://bugs.webkit.org/show_bug.cgi?id=199815
1749         <rdar://problem/52280514>
1750
1751         Reviewed by Simon Fraser.
1752
1753         * MiniBrowser/mac/WK2BrowserWindowController.m:
1754         (-[MiniBrowserNSTextFinder performAction:]):
1755         (-[WK2BrowserWindowController awakeFromNib]):
1756         Adopt the WebKit UI in MiniBrowser. Also, override NSTextFinder's
1757         -performAction: so that we can intercept the close action and
1758         hide our own find UI, since there is no delegate for that action yet.
1759
1760         * TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:
1761         (TEST):
1762
1763 2019-07-15  Keith Miller  <keith_miller@apple.com>
1764
1765         JSGlobalObject type macros should support feature flags and WeakRef should have one
1766         https://bugs.webkit.org/show_bug.cgi?id=199601
1767
1768         Reviewed by Mark Lam.
1769
1770         JSC options need to be set before the window is created for the test.
1771
1772         * DumpRenderTree/mac/DumpRenderTree.mm:
1773         (resetWebViewToConsistentStateBeforeTesting):
1774         * DumpRenderTree/win/DumpRenderTree.cpp:
1775         (setJSCOptions):
1776         (resetWebViewToConsistentStateBeforeTesting):
1777
1778 2019-07-15  Said Abou-Hallawa  <sabouhallawa@apple.com>
1779
1780         [ Mojave WK1 ] Some Image tests are flakey failures and are failing in tandem with zoomed in or blank image results
1781         https://bugs.webkit.org/show_bug.cgi?id=193108
1782
1783         Reviewed by Simon Fraser.
1784
1785         Add a workaround for <rdar://problem/17084993> in createBitmapContextFromWebView().
1786         Re-request the snapshot at kCGWindowImageNominalResolution if it was captured
1787         at the wrong scale.
1788
1789         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1790         (takeWindowSnapshot):
1791         (createBitmapContextFromWebView):
1792
1793 2019-07-15  Brady Eidson  <beidson@apple.com>
1794
1795         Make WKURLSchemeTask thread safe.
1796         <rdar://problem/50471863> and https://bugs.webkit.org/show_bug.cgi?id=199764
1797
1798         Reviewed by Alex Christensen.
1799
1800         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
1801
1802 2019-07-15  Jiewen Tan  <jiewen_tan@apple.com>
1803
1804         Unreviewed, a build fix after r247437
1805
1806         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
1807         Added platform guard towards -[WKUIDelegate _presentingViewControllerForWebView:].
1808
1809 2019-07-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1810
1811         [macOS 10.15] Cannot unbold selected text when the system font is used
1812         https://bugs.webkit.org/show_bug.cgi?id=199788
1813         <rdar://problem/52142570>
1814
1815         Reviewed by Tim Horton.
1816
1817         Add a new API test to verify that bolding and unbolding updates the
1818         shared font manager's selected font.
1819
1820         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
1821         (TestWebKitAPI::TEST):
1822
1823 2019-07-15  Jiewen Tan  <jiewen_tan@apple.com>
1824
1825         [iOS] SOAuthorizationSession should tell AppSSO whether the UIClient is capable of showing the extension UI
1826         https://bugs.webkit.org/show_bug.cgi?id=199790
1827         <rdar://problem/52790112>
1828
1829         Reviewed by Brent Fulgham.
1830
1831         Add tests to check SOAuthorization.enableEmbeddedAuthorizationViewController accordingly.
1832
1833         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
1834         (-[TestSOAuthorizationDelegate _presentingViewControllerForWebView:]):
1835         (configureSOAuthorizationWebView):
1836         (TestWebKitAPI::TEST):
1837         (-[TestSOAuthorizationNavigationDelegate init]): Deleted.
1838         (-[TestSOAuthorizationNavigationDelegate webView:didFinishNavigation:]): Deleted.
1839         (-[TestSOAuthorizationNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
1840         (-[TestSOAuthorizationNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]): Deleted.
1841         (-[TestSOAuthorizationNavigationDelegate _webView:decidePolicyForSOAuthorizationLoadWithCurrentPolicy:forExtension:completionHandler:]): Deleted.
1842
1843 2019-07-15  Sihui Liu  <sihui_liu@apple.com>
1844
1845         window.openDatabase is not writable
1846         https://bugs.webkit.org/show_bug.cgi?id=199737
1847         <rdar://problem/52551332>
1848
1849         Reviewed by Chris Dumez.
1850
1851         * TestWebKitAPI/Tests/WebKitCocoa/WebSQLBasics.mm:
1852         (TEST):
1853         * TestWebKitAPI/Tests/WebKitCocoa/opendatabase-always-exists.html:
1854
1855 2019-07-15  Aakash Jain  <aakash_jain@apple.com>
1856
1857         [ews-build] Parse and display layout test failures
1858         https://bugs.webkit.org/show_bug.cgi?id=199709
1859
1860         Rubber-stamped by Jonathan Bedard.
1861
1862         * BuildSlaveSupport/ews-build/steps.py:
1863         (RunWebKitTests.start): Initialize log_observer.
1864         (RunWebKitTests._strip_python_logging_prefix): Copied from similar code in build.webkit.org buildbot config.
1865         (RunWebKitTests._parseRunWebKitTestsOutput): Ditto.
1866         (RunWebKitTests.commandComplete): Gather and parse the stdout and stderr logs.
1867         (RunWebKitTests.evaluateResult): Analyze the results and decide build status.
1868         (RunWebKitTests.getResultSummary): Update build and step summary.
1869         * BuildSlaveSupport/ews-build/steps_unittest.py: Added and updated unit-tests.
1870
1871 2019-07-15  Commit Queue  <commit-queue@webkit.org>
1872
1873         Unreviewed, rolling out r247393.
1874         https://bugs.webkit.org/show_bug.cgi?id=199797
1875
1876         broke mips and arm EWS (Requested by guijemont on #webkit).
1877
1878         Reverted changeset:
1879
1880         "run-javascriptcore-tests won't report test results for
1881         testmasm, testair, testb3, testdfg and test api"
1882         https://bugs.webkit.org/show_bug.cgi?id=199489
1883         https://trac.webkit.org/changeset/247393
1884
1885 2019-07-12  Andy Estes  <aestes@apple.com>
1886
1887         [Cocoa] -loadFileURL:allowingReadAccessToURL: should fully resolve file URLs
1888         https://bugs.webkit.org/show_bug.cgi?id=199768
1889         <rdar://problem/52002206>
1890
1891         Reviewed by Geoffrey Garen.
1892
1893         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm:
1894         (TEST):
1895
1896 2019-07-12  Aakash Jain  <aakash_jain@apple.com>
1897
1898         [ews-build] Remove wincairo queue from old EWS and dashboard
1899         https://bugs.webkit.org/show_bug.cgi?id=199776
1900
1901         Reviewed by Don Olmstead.
1902
1903         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1904         * QueueStatusServer/config/queues.py:
1905
1906 2019-07-12  Aakash Jain  <aakash_jain@apple.com>
1907
1908         [ews-build] Enable wincairo queue on new EWS
1909         https://bugs.webkit.org/show_bug.cgi?id=199593
1910
1911         Reviewed by Don Olmstead.
1912
1913         * BuildSlaveSupport/ews-build/config.json: Enabled the triggers for wincairo builder.
1914         * BuildSlaveSupport/ews-build/factories.py: Added required build steps for wincairo factory.
1915         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1916         (StatusBubble): Enable wincairo status-bubble.
1917
1918 2019-07-12  Aakash Jain  <aakash_jain@apple.com>
1919
1920         [ews-app] Enable logging for clicking SubmitToEWS button
1921         https://bugs.webkit.org/show_bug.cgi?id=199757
1922
1923         Unreviewed minor infrastructure fix.
1924
1925         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
1926         (SubmitToEWS.post): Change logging level from debug to info.
1927
1928 2019-07-12  Alex Christensen  <achristensen@webkit.org>
1929
1930         Enable client certificate authentication unit test
1931         https://bugs.webkit.org/show_bug.cgi?id=199735
1932
1933         Reviewed by Chris Dumez.
1934
1935         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1936         (TEST):
1937         I originally wrote this in https://bugs.webkit.org/show_bug.cgi?id=197800 but it was disabled because it crashed.
1938         I found what was crashing.  I was reading out of bounds on my vector of 2 strings :(
1939
1940 2019-07-12  Alex Christensen  <achristensen@webkit.org>
1941
1942         Begin unifying TestWebKitAPI build
1943         https://bugs.webkit.org/show_bug.cgi?id=199728
1944
1945         Reviewed by Keith Miller.
1946
1947         * TestWebKitAPI/Configurations/Base.xcconfig:
1948         * TestWebKitAPI/Scripts/generate-unified-sources.sh: Added.
1949         * TestWebKitAPI/Sources.txt: Added.
1950         * TestWebKitAPI/SourcesCocoa.txt: Added.
1951         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1952
1953 2019-07-12  Zhifei Fang  <zhifei_fang@apple.com>
1954
1955         run-javascriptcore-tests won't report test results for testmasm, testair, testb3, testdfg and test api
1956         https://bugs.webkit.org/show_bug.cgi?id=199489
1957         <rdar://problem/47891081>
1958
1959         Reviewed by Aakash Jain.
1960
1961         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1962         (RunJavaScriptCoreTests.countFailures):
1963         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1964         * Scripts/run-javascriptcore-tests:
1965         (runTest):
1966         (reportTestFailures):
1967         (runJSCStressTests):
1968
1969 2019-07-12  Aakash Jain  <aakash_jain@apple.com>
1970
1971         [ews-build] Make layout-tests' full_results.json accessible in Buildbot
1972         https://bugs.webkit.org/show_bug.cgi?id=199743
1973
1974         Reviewed by Jonathan Bedard.
1975
1976         * BuildSlaveSupport/ews-build/steps.py:
1977         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
1978
1979 2019-07-11  Aakash Jain  <aakash_jain@apple.com>
1980
1981         Unreviewed follow-up fix to r247364.
1982         [ews-build] Add build step to clean up .git/index.lock file
1983         https://bugs.webkit.org/show_bug.cgi?id=199722
1984
1985         * BuildSlaveSupport/ews-build/steps.py:
1986         (CheckOutSource): CheckOutSource should not haltOnFailure since CleanUpGitIndexLock step needs
1987         to be run after this step.
1988
1989 2019-07-11  Yusuke Suzuki  <ysuzuki@apple.com>
1990
1991         Flaky API Test TestWTF.bmalloc.ScavengedMemoryShouldBeReused
1992         https://bugs.webkit.org/show_bug.cgi?id=199524
1993         <rdar://problem/52783816>
1994
1995         Reviewed by Saam Barati.
1996
1997         This test is white-box one and it has strong assumption how IsoHeap allocates pages.
1998         But this test has several problems.
1999
2000         1. IsoPage::numObjects is not the exact number of how many we allocate objects. This
2001            number is calculated by pageSize / sizeof(T), and this does not account the header
2002            size of IsoPage. So, # of objects per IsoPage is less than numObjects. Since sizeof(double)
2003            is very small, we can have many objects in one IsoPage. As a result, we need a large
2004            bitmap in IsoPage. This reduces # of objects in IsoPage largely. So, `ptrs.size()` becomes
2005            less than numObjects.
2006
2007         2. We now have lower tier of allocation in IsoHeap. It means that we allocate 8 objects in
2008            shared page (page is shared, but memory is pinned for a specific type) before using IsoHeap's
2009            page. This also makes the intention of this test wrong.
2010
2011         Due to (1), we access OoB of ptrs vector, passing a garbage to IsoHeap::deallocate, and crashing.
2012
2013         We make this test robust while we still keep this test white-box one to test the critical feature
2014         of IsoHeap. We first exhaust lower tier of IsoHeap, and after that, start testing the memory. We
2015         allocate many pointers, deallocate them, allocate one pointer while keeping pointers in the lower
2016         tier live, and check whether the deallocated memory is reused.
2017
2018         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
2019         (TEST):
2020
2021 2019-07-11  Pablo Saavedra  <psaavedra@igalia.com>
2022
2023         [WPE][GTK] Build failure with ENABLE_ACCESSIBILITY=OFF
2024         https://bugs.webkit.org/show_bug.cgi?id=199625
2025
2026         Added ENABLE(ACCESSIBILITY) and replaced HAVE(ACCESSIBILITY)
2027         with ENABLE(ACCESSIBILITY) in the code.
2028
2029         Additionally, the TestRunner code generator now honors the
2030         Conditional IDL format.
2031
2032         Reviewed by Konstantin Tokarev.
2033
2034         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2035         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp:
2036         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp:
2037         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2038         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
2039         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarker.idl:
2040         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarkerRange.idl:
2041         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2042         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2043         (_generateImplementationFile):
2044
2045 2019-07-11  Aakash Jain  <aakash_jain@apple.com>
2046
2047         [ews-build] Add build step to clean up .git/index.lock file
2048         https://bugs.webkit.org/show_bug.cgi?id=199722
2049
2050         Reviewed by Jonathan Bedard.
2051
2052         * BuildSlaveSupport/ews-build/steps.py:
2053         (CheckOutSource.getResultSummary): Run CleanUpGitIndexLock step when CheckOutSource fails.
2054         (CleanUpGitIndexLock.__init__): Configure timeout and logEnviron.
2055         (CleanUpGitIndexLock.evaluateCommand): Always RETRY the build after this step is run.
2056         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2057
2058 2019-07-11  Jonathan Bedard  <jbedard@apple.com>
2059
2060         [iOS 13] Enable WebKit build
2061         https://bugs.webkit.org/show_bug.cgi?id=199481
2062         <rdar://problem/52619048>
2063
2064         Reviewed by Tim Horton.
2065
2066         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: Add iOS framework stubs.
2067
2068 2019-07-11  Ryan Haddad  <ryanhaddad@apple.com>
2069
2070         Add test expectations and baselines for iOS 13
2071         https://bugs.webkit.org/show_bug.cgi?id=199329
2072
2073         Reviewed by Jonathan Bedard.
2074
2075         * Scripts/webkitpy/port/ios.py:
2076         (IOSPort): Increment current version to 13.
2077         * Scripts/webkitpy/port/ios_device_unittest.py: Update unit tests.
2078         (IOSDeviceTest.test_layout_test_searchpath_with_apple_additions):
2079         (IOSDeviceTest.test_layout_test_searchpath_without_apple_additions):
2080         (IOSDeviceTest.test_layout_searchpath_wih_device_type):
2081         * Scripts/webkitpy/port/ios_simulator_unittest.py: Ditto.
2082         (IOSSimulatorTest.make_port):
2083         (IOSSimulatorTest.test_layout_test_searchpath_with_apple_additions):
2084         (IOSSimulatorTest.test_layout_test_searchpath_without_apple_additions):
2085         (IOSSimulatorTest.test_layout_searchpath_wih_device_type):
2086         * Scripts/webkitpy/port/ios_testcase.py: Ditto.
2087         (IOSTest.make_port):
2088
2089 2019-07-11  Joanmarie Diggs  <jdiggs@igalia.com>
2090
2091         AX: Implement support for ARIA roles insertion, deletion, subscript, superscript, and time
2092         https://bugs.webkit.org/show_bug.cgi?id=199692
2093
2094         Reviewed by Chris Fleizach.
2095
2096         Add support for output of AXDeletion and AXInsertion roles for tests.
2097         Update GTK and WPE jhbuild modules to use version of ATK and AT-SPI2
2098         which include ROLE_CONTENT_DELETION and ROLE_CONTENT_INSERTION.
2099
2100         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2101         * gtk/jhbuild.modules:
2102         * wpe/jhbuild.modules:
2103
2104 2019-07-11  Adrian Perez de Castro  <aperez@igalia.com>
2105
2106         [ews-build] Remove workers {ltilve,tanty}-gtk-wk2-ews from configuration
2107         https://bugs.webkit.org/show_bug.cgi?id=199707
2108
2109         Reviewed by Aakash Jain.
2110
2111         * BuildSlaveSupport/ews-build/config.json: Remove old unused workers.
2112
2113 2019-07-10  Simon Fraser  <simon.fraser@apple.com>
2114
2115         [iOS WK2] With modal overlay and body overflow:hidden, can't access all the content
2116         https://bugs.webkit.org/show_bug.cgi?id=199693
2117         rdar://problem/51930364
2118
2119         Reviewed by Tim Horton.
2120         
2121         New API tests that test scrollability with various combinations of content, insets,
2122         input accessory bars etc.
2123
2124         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2125         * TestWebKitAPI/Tests/ios/ScrollViewScrollabilityTests.mm: Added.
2126         (TestWebKitAPI::webViewWithAutofocusedInput):
2127         (TestWebKitAPI::TEST):
2128
2129 2019-07-10  Tim Horton  <timothy_horton@apple.com>
2130
2131         Long pressing on attachments will crash the WebContent process
2132         https://bugs.webkit.org/show_bug.cgi?id=199696
2133         <rdar://problem/52920241>
2134
2135         Reviewed by Dean Jackson.
2136
2137         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
2138         (TestWebKitAPI::TEST):
2139         Add a test that previously crashed.
2140
2141 2019-07-10  Dean Jackson  <dino@apple.com>
2142
2143         Support MacCatalyst in run-webkit-app
2144         https://bugs.webkit.org/show_bug.cgi?id=199690
2145
2146         Reviewed by Tim Horton.
2147
2148         Add a --maccatalyst option to run-webkit-app that
2149         can launch MacCatalyst applications with a built WebKit.
2150
2151         * Scripts/webkitdirs.pm:
2152         (argumentsForConfiguration):
2153         (determineXcodeSDK):
2154         (xcodeSDKPlatformName):
2155         (determineConfigurationProductDir):
2156         (determinePortName):
2157         (isCatalystWebKit):
2158         (isAppleCocoaWebKit):
2159         (willUseCatalystSDK):
2160
2161 2019-07-10  Ryan Haddad  <ryanhaddad@apple.com>
2162
2163         [MacOS] Filter VPA info logged to stdout
2164         https://bugs.webkit.org/show_bug.cgi?id=199673
2165
2166         Reviewed by Eric Carlson.
2167
2168         * Scripts/webkitpy/port/mac.py:
2169         (MacPort.logging_patterns_to_strip):
2170
2171 2019-07-10  Ryan Haddad  <ryanhaddad@apple.com>
2172
2173         Unreviewed, rolling out r247286.
2174
2175         Caused TestWTF.WTF.StringOperators to fail on debug bots
2176
2177         Reverted changeset:
2178
2179         "Add StringBuilder member function which allows makeString()
2180         style variadic argument construction"
2181         https://bugs.webkit.org/show_bug.cgi?id=198997
2182         https://trac.webkit.org/changeset/247286
2183
2184 2019-07-10  Aakash Jain  <aakash_jain@apple.com>
2185
2186         [ews-build] Explicitly use perl or python while invoking scripts
2187         https://bugs.webkit.org/show_bug.cgi?id=199669
2188
2189         Reviewed by Jonathan Bedard.
2190
2191         * BuildSlaveSupport/ews-build/steps.py: Explicitly added perl or python while invoking scripts.
2192         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests accordingly.
2193
2194 2019-07-10  Guillaume Emont  <guijemont@igalia.com>
2195
2196         Run tests on mips EWS
2197         https://bugs.webkit.org/show_bug.cgi?id=196854
2198
2199         Reviewed by Carlos Garcia Campos.
2200
2201         * Scripts/webkitpy/common/config/ews.json:
2202
2203 2019-07-09  Michael Catanzaro  <mcatanzaro@igalia.com>
2204
2205         [WPE][GTK] GUniqueOutPtr::release should return a raw pointer
2206         https://bugs.webkit.org/show_bug.cgi?id=199579
2207
2208         Reviewed by Carlos Garcia Campos.
2209
2210         * TestWebKitAPI/Tests/WTF/glib/GUniquePtr.cpp:
2211         (TestWebKitAPI::TEST):
2212
2213 2019-07-09  Chris Dumez  <cdumez@apple.com>
2214
2215         Fix integer type encoding / decoding in WKRemoteObjectCoder
2216         https://bugs.webkit.org/show_bug.cgi?id=199643
2217         <rdar://problem/52732342>
2218
2219         Reviewed by Anders Carlsson.
2220
2221         Update API test coverage.
2222
2223         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.h:
2224         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.mm:
2225         (TEST):
2226         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistryPlugIn.mm:
2227         (-[RemoteObjectRegistryPlugIn takeUnsignedLongLong:completionHandler:]):
2228         (-[RemoteObjectRegistryPlugIn takeLongLong:completionHandler:]):
2229         (-[RemoteObjectRegistryPlugIn takeUnsignedLong:completionHandler:]):
2230         (-[RemoteObjectRegistryPlugIn takeLong:completionHandler:]):
2231
2232 2019-07-09  Sam Weinig  <weinig@apple.com>
2233
2234         Add StringBuilder member function which allows makeString() style variadic argument construction
2235         https://bugs.webkit.org/show_bug.cgi?id=198997
2236
2237         Reviewed by Darin Adler.
2238
2239         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2240         Add basic test showing that StringBuilder::flexibleAppend can be used to 
2241         append one or more string adaptable types. 
2242
2243 2019-07-09  Sihui Liu  <sihui_liu@apple.com>
2244
2245         Only allow fetching and removing session credentials from WebsiteDataStore
2246         https://bugs.webkit.org/show_bug.cgi?id=199385
2247         <rdar://problem/52622080>
2248
2249         Reviewed by Alex Christensen.
2250
2251         removeDataOfTypes will no longer remove persistent credentials. We should clear persistent credentials using
2252         the new SPI after each test that creates persistent credentials, otherwise the later tests may use credentials
2253         left by previous tests and didReceiveAuthenticationChallenge will not be invoked.
2254
2255         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
2256         (TEST):
2257         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
2258         (TestWebKitAPI::TEST):
2259
2260 2019-07-09  Alex Christensen  <achristensen@webkit.org>
2261
2262         When parsing an IPv4 address, wait until after deciding it is indeed an IPv4 address before reporting syntax violations
2263         https://bugs.webkit.org/show_bug.cgi?id=199628
2264
2265         Reviewed by Brady Eidson.
2266
2267         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
2268         (TestWebKitAPI::TEST_F):
2269
2270 2019-07-09  Alex Christensen  <achristensen@webkit.org>
2271
2272         Remove invalid assertion in URLParser::domainToASCII
2273         https://bugs.webkit.org/show_bug.cgi?id=199624
2274
2275         Reviewed by Brady Eidson.
2276
2277         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
2278         (TestWebKitAPI::TEST_F):
2279
2280 2019-07-09  Alex Christensen  <achristensen@webkit.org>
2281
2282         URLParser should reserialize IPv6 addresses that end with a colon
2283         https://bugs.webkit.org/show_bug.cgi?id=199627
2284
2285         Reviewed by Brady Eidson.
2286
2287         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
2288         (TestWebKitAPI::TEST_F):
2289
2290 2019-07-08  Aakash Jain  <aakash_jain@apple.com>
2291
2292         [ews-build] Do not run unix commands for windows in PrintConfiguration
2293         https://bugs.webkit.org/show_bug.cgi?id=199605
2294
2295         Reviewed by Jonathan Bedard.
2296
2297         * BuildSlaveSupport/ews-build/steps.py:
2298
2299 2019-07-08  Fujii Hironori  <Hironori.Fujii@sony.com>
2300
2301         JSTestGlobalObject.cpp of bindings-generation-tests is failing for Windows Python
2302         https://bugs.webkit.org/show_bug.cgi?id=199487
2303
2304         Reviewed by Ross Kirsling.
2305
2306         In Windows Python, preprocessor.pm is using cl.exe. cl.exe was
2307         failing to open testglobalscope_constructors_file which was
2308         created by using tempfile.mkstemp() because it keeps the file
2309         open. Use tempfile.mkdtemp() to create temporary files in the
2310         temporary directory instead of tempfile.mkstemp().
2311
2312         * Scripts/webkitpy/bindings/main.py:
2313         (BindingsTests.run_tests):
2314         (BindingsTests.main):
2315         (BindingsTests.close_and_remove): Deleted.
2316
2317 2019-07-08  Aakash Jain  <aakash_jain@apple.com>
2318
2319         [ews-build] Add KillOldProcesses step before running API or Layout tests
2320         https://bugs.webkit.org/show_bug.cgi?id=199592
2321
2322         Reviewed by Jonathan Bedard.
2323
2324         * BuildSlaveSupport/ews-build/factories.py:
2325
2326 2019-07-08  Jonathan Bedard  <jbedard@apple.com>
2327
2328         test-webkitpy: Explicitly use Python 2.7 lldb library
2329         https://bugs.webkit.org/show_bug.cgi?id=199578
2330         <rdar://problem/51853557>
2331
2332         Reviewed by Aakash Jain.
2333
2334         * Scripts/webkitpy/common/system/systemhost.py:
2335         (SystemHost.path_to_lldb_python_directory): Explicitly use Python 2.7 lldb libary.
2336         * Scripts/webkitpy/test/main.py:
2337         (_supports_building_and_running_lldb_tests): Run lldb tests on Catalina again.
2338
2339 2019-07-08  Ryan Haddad  <ryanhaddad@apple.com>
2340
2341         Add test expectations and baselines for Catalina
2342         https://bugs.webkit.org/show_bug.cgi?id=199328
2343
2344         Reviewed by Jonathan Bedard.
2345
2346         * Scripts/webkitpy/port/mac.py:
2347         (MacPort): Increment current version to 10.15 so that baseline search paths are correctly constructed for High Sierra.
2348
2349 2019-07-08  Christopher Reid  <chris.reid@sony.com>
2350
2351         Implement MappedFileData for Windows
2352         https://bugs.webkit.org/show_bug.cgi?id=198269
2353
2354         Reviewed by Darin Adler.
2355
2356         * TestWebKitAPI/PlatformWin.cmake:
2357
2358 2019-07-08  Charlie Turner  <cturner@igalia.com>
2359
2360         REGRESSION(r243197): [GStreamer] Web process hangs when scrolling twitter timeline which contains HLS videos
2361         https://bugs.webkit.org/show_bug.cgi?id=197558
2362
2363         Reviewed by Xabier Rodriguez-Calvar.
2364
2365         On shutdown we can easily deadlock the web process if we don't
2366         ensure all network operations are completed before comitting state
2367         changes. In HLS, make sure the network operations are cancelled,
2368         and also prevent hlsdemux's retry logic from scuppering our
2369         efforts.
2370
2371         * gstreamer/jhbuild.modules: Include the patch.
2372         * gstreamer/patches/gst-plugins-bad-do-not-retry-downloads-during-shutdown.patch: Added.
2373
2374 2019-07-08  Antoine Quint  <graouts@apple.com>
2375
2376         [Pointer Events] Enable only on the most recent version of the supported iOS family
2377         https://bugs.webkit.org/show_bug.cgi?id=199562
2378         <rdar://problem/52766511>
2379
2380         Reviewed by Dean Jackson.
2381
2382         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2383
2384 2019-07-06  Simon Fraser  <simon.fraser@apple.com>
2385
2386         Long hang when loading a cnn.com page on iOS
2387         https://bugs.webkit.org/show_bug.cgi?id=199556
2388
2389         Reviewed by Zalan Bujtas.
2390
2391         Add code to load a page by default in MobileMiniBrowser so it's easy to hack it
2392         to load a test page of your choice.
2393
2394         * MobileMiniBrowser/MobileMiniBrowserFramework/WebViewController.m:
2395         (-[WebViewController viewDidLoad]):
2396
2397 2019-07-05  Ryosuke Niwa  <rniwa@webkit.org>
2398
2399         [iOS] Crash in WebKit::WebPage::positionInformation via Range::startPosition
2400         https://bugs.webkit.org/show_bug.cgi?id=199503
2401
2402         Reviewed by Wenson Hsieh.
2403
2404         Added UIScriptController.ensurePositionInformationIsUpToDateAt using the existing WKWebView SPI:
2405         _requestActivatedElementAtPosition
2406
2407         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2408         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
2409         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2410         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
2411         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2412         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2413         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
2414         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2415         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2416         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
2417         * WebKitTestRunner/ios/UIScriptControllerMac.mm:
2418         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
2419
2420 2019-07-05  Ryan Haddad  <ryanhaddad@apple.com>
2421
2422         Unreviewed, rolling out r247115.
2423
2424         Breaks lldbWebKitTester (and by extension, test-webkitpy)
2425
2426         Reverted changeset:
2427
2428         "[WHLSL] Standard library is too big to directly include in
2429         WebCore"
2430         https://bugs.webkit.org/show_bug.cgi?id=198186
2431         https://trac.webkit.org/changeset/247115
2432
2433 2019-07-05  Ryan Haddad  <ryanhaddad@apple.com>
2434
2435         Unreviewed, rolling out r247123.
2436
2437         Caused TestWebKitAPI.Challenge.BasicProposedCredential to
2438         fail.
2439
2440         Reverted changeset:
2441
2442         "Only allow fetching and removing session credentials from
2443         WebsiteDataStore"
2444         https://bugs.webkit.org/show_bug.cgi?id=199385
2445         https://trac.webkit.org/changeset/247123
2446
2447 2019-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2448
2449         Touching media controls sometimes shows software keyboard
2450         https://bugs.webkit.org/show_bug.cgi?id=199490
2451         <rdar://problem/52076270>
2452
2453         Reviewed by Eric Carlson.
2454
2455         Adds plumbing for a new testing hook to check whether or not there is an active input session. See other
2456         ChangeLog entries for more detail.
2457
2458         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2459         (WTR::UIScriptController::hasInputSession const):
2460         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2461         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2462         (WTR::UIScriptController::hasInputSession const):
2463         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2464         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2465         (WTR::UIScriptController::hasInputSession const):
2466
2467 2019-07-04  Aakash Jain  <aakash_jain@apple.com>
2468
2469         [ews-build] Remove GTK and WPE queue from old EWS and dashboard
2470         https://bugs.webkit.org/show_bug.cgi?id=199458
2471
2472         Reviewed by Michael Catanzaro.
2473
2474         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2475         * QueueStatusServer/config/queues.py:
2476
2477 2019-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2478
2479         [GTK] Fix browserperfdash script after r239522
2480         https://bugs.webkit.org/show_bug.cgi?id=199496
2481
2482         Reviewed by Michael Catanzaro.
2483
2484         * Scripts/webkitpy/browserperfdash/browserperfdash_runner.py:
2485         (BrowserPerfDashRunner.run): Pass None for the new required BenchmarkRunner constructor.
2486
2487 2019-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2488
2489         [webkitpy] test-webkitpy is broken on Linux since r246662
2490         https://bugs.webkit.org/show_bug.cgi?id=199493
2491
2492         Reviewed by Michael Catanzaro.
2493
2494         * Scripts/webkitpy/test/main.py:
2495         (_supports_building_and_running_lldb_tests): Add a check for None before calling startswith().
2496
2497 2019-07-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2498
2499         [GTK][WPE] Not longer needed to build woff2 on the JHBuild
2500         https://bugs.webkit.org/show_bug.cgi?id=199406
2501
2502         Reviewed by Michael Catanzaro.
2503
2504         Install the Woff2 libraries and headers from the system package
2505         and stop building them on the JHBuild.
2506
2507         * gtk/install-dependencies:
2508         * gtk/jhbuild.modules:
2509         * wpe/install-dependencies:
2510         * wpe/jhbuild.modules:
2511
2512 2019-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2513
2514         [GTK][WPE][CMake] The CMake cache should be clean when the JHBuild is rebuilt
2515         https://bugs.webkit.org/show_bug.cgi?id=199449
2516
2517         Reviewed by Michael Catanzaro.
2518
2519         * Scripts/webkitdirs.pm:
2520         (shouldRemoveCMakeCache): Clean the CMake cache if we detect that the JHBuild has been rebuilt.
2521
2522 2019-07-01  Philippe Normand  <pnormand@igalia.com>
2523
2524         Unreviewed, GTK a11y tests fix after r247071
2525
2526         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2527         (WTR::AccessibilityUIElement::popupValue const):
2528
2529 2019-07-03  Aakash Jain  <aakash_jain@apple.com>
2530
2531         [ews-build] Enable WPE and GTK queues on new EWS
2532         https://bugs.webkit.org/show_bug.cgi?id=199234
2533
2534         Reviewed by Jonathan Bedard.
2535
2536         * BuildSlaveSupport/ews-build/config.json: Enabled the triggers for GTK and WPE builders.
2537         * BuildSlaveSupport/ews-build/factories.py: Added required build steps for GTKFactory and WPEFactory.
2538         * BuildSlaveSupport/ews-build/steps.py:
2539         (CompileWebKit.evaluateCommand): Added InstallGtkDependencies/InstallWpeDependencies step before Compiling WebKit without patch.
2540         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2541         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2542         (StatusBubble): Enable gtk and wpe status-bubbles.
2543
2544 2019-07-03  Sihui Liu  <sihui_liu@apple.com>
2545
2546         Only allow fetching and removing session credentials from WebsiteDataStore
2547         https://bugs.webkit.org/show_bug.cgi?id=199385
2548
2549         Reviewed by Alex Christensen.
2550
2551         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
2552         (TestWebKitAPI::TEST):
2553
2554 2019-07-03  Tim Horton  <timothy_horton@apple.com>
2555
2556         UI process exception when dragging an <attachment> with no content type
2557         https://bugs.webkit.org/show_bug.cgi?id=199480
2558         <rdar://problem/44351353>
2559
2560         Reviewed by Wenson Hsieh.
2561
2562         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2563         (TestWebKitAPI::TEST):
2564         Add a test; before the change, it crashes.
2565
2566 2019-07-03  Jonathan Bedard  <jbedard@apple.com>
2567
2568         [Catalina] Enable WebKit build
2569         https://bugs.webkit.org/show_bug.cgi?id=199209
2570
2571         Reviewed by Darin Adler.
2572
2573         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: Add Mac framework stubs.
2574
2575 2019-07-03  Sam Weinig  <weinig@apple.com>
2576
2577         Adopt simple structured bindings in more places
2578         https://bugs.webkit.org/show_bug.cgi?id=199247
2579
2580         Reviewed by Alex Christensen.
2581
2582         Replaces simple uses of std::tie() with structured bindings. Does not touch
2583         uses of std::tie() that are not initial declarations, use std::ignore or in
2584         case where the binding is captured by a lambda, as structured bindings don't
2585         work for those cases yet.
2586
2587         * TestWebKitAPI/ios/PreferredContentMode.mm:
2588         (TestWebKitAPI::TEST):
2589
2590 2019-07-03  Aakash Jain  <aakash_jain@apple.com>
2591
2592         Unreviewed follow-up fix to r247049, default the platform to '*' when platform property is not set.
2593
2594         * BuildSlaveSupport/ews-build/steps.py:
2595         (PrintConfiguration.run):
2596
2597 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
2598
2599         [ews-build] Add build steps to Install Wpe and Gtk dependencies
2600         https://bugs.webkit.org/show_bug.cgi?id=199408
2601
2602         Reviewed by Michael Catanzaro.
2603
2604         * BuildSlaveSupport/ews-build/steps.py:
2605         (InstallGtkDependencies): Build step to install dependencies for GTK. Set haltOnFailure=False so that in case of failure, build isn't
2606         marked as failed (which would indicated patch failed EWS), instead subsequent steps would be run and the build would be marked as RETRY.
2607         (InstallWpeDependencies): Ditto for WPE.
2608         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2609
2610 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
2611
2612         [ews-build] Allow skipping uploading built product for few builders
2613         https://bugs.webkit.org/show_bug.cgi?id=199422
2614
2615         Reviewed by Michael Catanzaro.
2616
2617         * BuildSlaveSupport/ews-build/steps.py:
2618         (CompileWebKit.__init__): Added optional skipUpload parameter.
2619         (CompileWebKit.evaluateCommand): Allow to skip upload if there are no triggers and skipUpload is True.
2620
2621 2019-07-02  Tim Horton  <timothy_horton@apple.com>
2622
2623         REGRESSION (r243240): Unable to swipe back in Safari
2624         https://bugs.webkit.org/show_bug.cgi?id=199394
2625         <rdar://problem/51137447>
2626
2627         Reviewed by Wenson Hsieh.
2628
2629         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2630         Make sure that we actually end up with swipe gesture recognizers installed
2631         after process swap and crash.
2632
2633 2019-07-02  Andres Gonzalez  <andresg_22@apple.com>
2634
2635         Enhance support of aria-haspopup per ARIA 1.1 specification.
2636         https://bugs.webkit.org/show_bug.cgi?id=199216
2637         <rdar://problem/46221342>
2638
2639         Reviewed by Chris Fleizach.
2640
2641         * DumpRenderTree/AccessibilityUIElement.cpp:
2642         (getPopupValueCallback):
2643         (AccessibilityUIElement::getJSClass):
2644         * DumpRenderTree/AccessibilityUIElement.h:
2645         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2646         (AccessibilityUIElement::popupValue const):
2647         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2648         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2649         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2650         (WTR::AccessibilityUIElement::popupValue const):
2651         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2652         (WTR::AccessibilityUIElement::popupValue const):
2653
2654 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
2655
2656         [ews-build] Do not print worker environment variables in each build step [part 2]
2657         https://bugs.webkit.org/show_bug.cgi?id=199405
2658
2659         Reviewed by Jonathan Bedard.
2660
2661         * BuildSlaveSupport/ews-build/steps.py:
2662         (CheckOutSpecificRevision.__init__): Disabled logging of environment variables.
2663         (CleanWorkingDirectory.__init__): Ditto.
2664         (RunBindingsTests.__init__): Ditto.
2665         (RunWebKitPerlTests.__init__): Ditto.
2666         (RunWebKitPyTests.__init__): Ditto.
2667         (CompileWebKit.__init__): Ditto.
2668         (ArchiveTestResults.__init__): Ditto.
2669         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
2670
2671 2019-07-02  Jer Noble  <jer.noble@apple.com>
2672
2673         Pipe suport for 'cenc' init data type into CDMFairPlayStreaming
2674         https://bugs.webkit.org/show_bug.cgi?id=199381
2675         <rdar://problem/52483103>
2676
2677         Reviewed by Eric Carlson.
2678
2679         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
2680
2681 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
2682
2683         [ews-build] Update bot configuration for WPE and GTK
2684         https://bugs.webkit.org/show_bug.cgi?id=199238
2685
2686         Reviewed by Michael Catanzaro.
2687
2688         * BuildSlaveSupport/ews-build/config.json:
2689
2690 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
2691
2692         [ews-build] Make PrintConfiguration platform aware
2693         https://bugs.webkit.org/show_bug.cgi?id=196657
2694
2695         Reviewed by Lucas Forschler.
2696
2697         * BuildSlaveSupport/ews-build/steps.py:
2698         (PrintConfiguration): Specified platform-specific command lists.
2699         (PrintConfiguration.run): Override run method and specify platform specific commands.
2700         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2701
2702 2019-07-01  Justin Michaud  <justin_michaud@apple.com>
2703
2704         [Wasm-References] Disable references by default
2705         https://bugs.webkit.org/show_bug.cgi?id=199390
2706
2707         Reviewed by Saam Barati.
2708
2709         * Scripts/run-jsc-stress-tests:
2710
2711 2019-07-01  Joonghun Park  <pjh0718@gmail.com>
2712
2713         Unreviewed. Revert r246965 to fix build break
2714         since r247019 reverted its related changes.
2715
2716         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2717         (WTR::AccessibilityUIElement::popupValue const): Deleted.
2718
2719 2019-07-01  Alex Christensen  <achristensen@webkit.org>
2720
2721         Add new decidePolicyForNavigationAction SPI with preferences and userInfo
2722         https://bugs.webkit.org/show_bug.cgi?id=199371
2723         <rdar://problem/52352905>
2724
2725         Reviewed by Tim Horton.
2726
2727         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
2728         (-[NavigationActionSPIDelegate webView:didFinishNavigation:]):
2729         (-[NavigationActionSPIDelegate _webView:decidePolicyForNavigationAction:preferences:userInfo:decisionHandler:]):
2730         (-[NavigationActionSPIDelegate spiCalled]):
2731         (TEST):
2732
2733 2019-07-01  Alex Christensen  <achristensen@webkit.org>
2734
2735         Deprecate _webView:showCustomSheetForElement: after transition to UIContextMenuInteraction
2736         https://bugs.webkit.org/show_bug.cgi?id=199296
2737         <rdar://problem/51041960>
2738
2739         Reviewed by Darin Adler.
2740
2741         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2742         (-[DragAndDropSimulator _webView:showCustomSheetForElement:]):
2743
2744 2019-07-01  Truitt Savell  <tsavell@apple.com>
2745
2746         Unreviewed, rolling out r246958.
2747
2748         Broke inspector/dom/getAccessibilityPropertiesForNode.html
2749
2750         Reverted changeset:
2751
2752         "Enhance support of aria-haspopup per ARIA 1.1 specification."
2753         https://bugs.webkit.org/show_bug.cgi?id=199216
2754         https://trac.webkit.org/changeset/246958
2755
2756 2019-07-01  Philippe Normand  <pnormand@igalia.com>
2757
2758         Unreviewed, GTK a11y tests fix after r246958
2759
2760         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2761         (WTR::AccessibilityUIElement::popupValue const):
2762
2763 2019-06-30  Andres Gonzalez  <andresg_22@apple.com>
2764
2765         Enhance support of aria-haspopup per ARIA 1.1 specification.
2766         https://bugs.webkit.org/show_bug.cgi?id=199216
2767         <rdar://problem/46221342>
2768
2769         Reviewed by Chris Fleizach.
2770
2771         * DumpRenderTree/AccessibilityUIElement.cpp:
2772         (getPopupValueCallback):
2773         (AccessibilityUIElement::getJSClass):
2774         * DumpRenderTree/AccessibilityUIElement.h:
2775         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2776         (AccessibilityUIElement::popupValue const):
2777         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2778         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2779         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2780         (WTR::AccessibilityUIElement::popupValue const):
2781         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2782         (WTR::AccessibilityUIElement::popupValue const):
2783
2784 2019-06-28  Robin Morisset  <rmorisset@apple.com>
2785
2786         Adding myself as a reviewer to contributors.json.
2787
2788         Unreviewed.
2789
2790         * Scripts/webkitpy/common/config/contributors.json:
2791
2792 2019-06-28  Jer Noble  <jer.noble@apple.com>
2793
2794         Add new -[WKWebView _closeAllMediaPresentations] SPI
2795         https://bugs.webkit.org/show_bug.cgi?id=199294
2796         <rdar://problem/51965958>
2797
2798         Reviewed by Alex Christensen.
2799
2800         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2801         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm: Added.
2802         (TEST):
2803
2804 2019-06-28  Sihui Liu  <sihui_liu@apple.com>
2805
2806         Add a regression test for change r246901
2807         https://bugs.webkit.org/show_bug.cgi?id=199290
2808
2809         Reviewed by Geoffrey Garen.
2810
2811         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2812         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:
2813         (-[LocalStorageNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2814         (TEST):
2815         * TestWebKitAPI/Tests/WebKitCocoa/localstorage-open-window-private.html: Added.
2816
2817 2019-06-28  Konstantin Tokarev  <annulen@yandex.ru>
2818
2819         Remove traces of ENABLE_ICONDATABASE remaining after its removal in 219733
2820         https://bugs.webkit.org/show_bug.cgi?id=199317
2821
2822         Reviewed by Michael Catanzaro.
2823
2824         While IconDatabase and all code using it was removed,
2825         ENABLE_ICONDATABASE still exists as build option and C++ macro.
2826
2827         * Scripts/webkitperl/FeatureList.pm:
2828         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2829         * gtk/manifest.txt.in: Remove reference to unused urlIcon.png file.
2830         * wpe/manifest.txt.in: Remove reference to unused urlIcon.png file.
2831
2832 2019-06-28  Wenson Hsieh  <wenson_hsieh@apple.com>
2833
2834         -[WKContentView _selectionClipRects] returns a bogus value in -reloadInputViews when focusing an element
2835         https://bugs.webkit.org/show_bug.cgi?id=199310
2836         <rdar://problem/52292137>
2837
2838         Reviewed by Megan Gardner.
2839
2840         Add a new API test to verify that _selectionClipRects returns the correct value when invoked under the scope of
2841         _elementDidFocus.
2842
2843         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2844         (TestWebKitAPI::TEST):
2845         * TestWebKitAPI/Tests/ios/TestInputDelegate.h:
2846         * TestWebKitAPI/Tests/ios/TestInputDelegate.mm:
2847         (-[TestInputDelegate setDidStartInputSessionHandler:]):
2848         (-[TestInputDelegate didStartInputSessionHandler]):
2849
2850         Add plumbing for a handler block in TestInputDelegate.
2851
2852         (-[TestInputDelegate setWillStartInputSessionHandler:]):
2853
2854         Drive-by style fixes to add a space between id and < for Objective-C protocols.
2855
2856         (-[TestInputDelegate willStartInputSessionHandler]):
2857         (-[TestInputDelegate _webView:willStartInputSession:]):
2858         (-[TestInputDelegate _webView:didStartInputSession:]):
2859         * TestWebKitAPI/cocoa/TestWKWebView.h:
2860         * TestWebKitAPI/ios/UIKitSPI.h:
2861
2862         Add a declaration for _selectionClipRects.
2863
2864 2019-06-27  Zalan Bujtas  <zalan@apple.com>
2865
2866         REGRESSION(r244633): e-mail with "height: 100%" causes unstable layout.
2867         https://bugs.webkit.org/show_bug.cgi?id=199303
2868         <rdar://problem/51340927>
2869
2870         Reviewed by Tim Horton.
2871
2872         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
2873         (TEST):
2874
2875 2019-06-27  Beth Dakin  <bdakin@apple.com>
2876
2877         Upstream use of MACCATALYST
2878         https://bugs.webkit.org/show_bug.cgi?id=199245
2879         rdar://problem/51687723
2880
2881         Reviewed by Tim Horton.
2882
2883         * ContentExtensionTester/Configurations/SDKVariant.xcconfig:
2884         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig:
2885         * ImageDiff/cg/Configurations/SDKVariant.xcconfig:
2886         * MiniBrowser/Configurations/SDKVariant.xcconfig:
2887         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig:
2888         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
2889         (JavaScriptCoreGenerator):
2890         (WebCoreGenerator):
2891         (WebKitGenerator):
2892         * TestWebKitAPI/Configurations/Base.xcconfig:
2893         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2894         * TestWebKitAPI/Configurations/SDKVariant.xcconfig:
2895         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2896         * WebEditingTester/Configurations/SDKVariant.xcconfig:
2897         * WebKitLauncher/Configurations/SDKVariant.xcconfig:
2898         * WebKitTestRunner/Configurations/SDKVariant.xcconfig:
2899         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig:
2900
2901 2019-06-27  Saam Barati  <sbarati@apple.com>
2902
2903         Make WEBGPU enabled only on Mojave and later.
2904
2905         Rubber-stamped by Myles C. Maxfield.
2906
2907         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2908
2909 2019-06-27  Aakash Jain  <aakash_jain@apple.com>
2910
2911         [ews-build] Do not print worker environment variables in each build step
2912         https://bugs.webkit.org/show_bug.cgi?id=197319
2913
2914         Reviewed by Lucas Forschler.
2915
2916         * BuildSlaveSupport/ews-build/steps.py:
2917         (CheckOutSource.__init__): Disabled logging of environment variables.
2918         (ApplyPatch.__init__): Ditto.
2919         (KillOldProcesses.__init__): Ditto.
2920         (ArchiveBuiltProduct.__init__): Ditto.
2921         (DownloadBuiltProduct.__init__): Ditto.
2922         (ExtractBuiltProduct.__init__): Ditto.
2923         (RunAPITests.__init__): Ditto.
2924         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests accordingly.
2925
2926 2019-06-26  Jiewen Tan  <jiewen_tan@apple.com>
2927
2928         SubFrameSOAuthorizationSession should preserve the referrer header when fall back to web path
2929         https://bugs.webkit.org/show_bug.cgi?id=199232
2930         <rdar://problem/51718328>
2931
2932         Reviewed by Youenn Fablet.
2933
2934         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
2935         (TestWebKitAPI::TEST):
2936         Add a test that utilizes TCPServer as local files always omit referrer.
2937
2938 2019-06-26  Aakash Jain  <aakash_jain@apple.com>
2939
2940         [ews-build] Add configuration and architecture for WPE and GTK builders
2941         https://bugs.webkit.org/show_bug.cgi?id=199249
2942
2943         Reviewed by Jonathan Bedard.
2944
2945         * BuildSlaveSupport/ews-build/config.json:
2946
2947 2019-06-26  Aakash Jain  <aakash_jain@apple.com>
2948
2949         [ews-build] Add check for duplicate workers in config.json
2950         https://bugs.webkit.org/show_bug.cgi?id=199240
2951
2952         Reviewed by Jonathan Bedard.
2953
2954         * BuildSlaveSupport/ews-build/loadConfig.py:
2955         (checkWorkersAndBuildersForConsistency._find_worker_with_name): Check for duplicate worker entry.
2956         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2957         (TestcheckWorkersAndBuildersForConsistency.test_duplicate_worker): Added unit-test.
2958
2959 2019-06-26  Ross Kirsling  <ross.kirsling@sony.com>
2960
2961         [Win] MiniBrowser should make better font choices
2962         https://bugs.webkit.org/show_bug.cgi?id=199244
2963
2964         Reviewed by Brent Fulgham.
2965
2966         * MiniBrowser/win/MainWindow.cpp:
2967         (MainWindow::updateDeviceScaleFactor):
2968         * MiniBrowser/win/MiniBrowserLib.rc:
2969
2970 2019-06-26  Alex Christensen  <achristensen@webkit.org>
2971
2972         testRunner.setAlwaysAcceptCookies should wait for cookie accept policy to be set
2973         https://bugs.webkit.org/show_bug.cgi?id=199230
2974         <rdar://51757107>
2975
2976         Reviewed by Andy Estes.
2977
2978         * TestWebKitAPI/Tests/WebKit/CookieManager.cpp:
2979         (TestWebKitAPI::didGetTestHTTPCookieAcceptPolicy):
2980         (TestWebKitAPI::didGetUserHTTPCookieAcceptPolicy):
2981         * WebKitTestRunner/TestController.cpp:
2982         (WTR::TestController::generatePageConfiguration):
2983         (WTR::TestController::createWebViewWithOptions):
2984         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundleWithListener):
2985         (WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundleWithListener):
2986         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2987         (WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundle): Deleted.
2988         * WebKitTestRunner/TestController.h:
2989         * WebKitTestRunner/TestInvocation.cpp:
2990         (WTR::TestInvocation::invoke):
2991         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2992
2993 2019-06-26  Ross Kirsling  <ross.kirsling@sony.com>
2994
2995         [Win][MiniBrowser] Remove obsolete code after r246814.
2996         https://bugs.webkit.org/show_bug.cgi?id=199233
2997
2998         Reviewed by Fujii Hironori.
2999
3000         * MiniBrowser/win/MiniBrowserWebHost.cpp:
3001         (MiniBrowserWebHost::didFinishLoadForFrame):
3002         (SimpleEventListener::SimpleEventListener): Deleted.
3003         (SimpleEventListener::handleEvent): Deleted.
3004
3005 2019-06-25  Jiewen Tan  <jiewen_tan@apple.com>
3006
3007         Implement a new SPI to inform clients about AppSSO
3008         https://bugs.webkit.org/show_bug.cgi?id=199085
3009         <rdar://problem/50028246>
3010
3011         Reviewed by Geoffrey Garen.
3012
3013         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
3014         (-[TestSOAuthorizationBasicDelegate webView:didFinishNavigation:]):
3015         (-[TestSOAuthorizationNavigationDelegate init]):
3016         (-[TestSOAuthorizationNavigationDelegate _webView:decidePolicyForSOAuthorizationLoadWithCurrentPolicy:forExtension:completionHandler:]):
3017         (TestWebKitAPI::TEST):
3018
3019 2019-06-25  Aakash Jain  <aakash_jain@apple.com>
3020
3021         [ews-build] Retry Layout test in case of failures
3022         https://bugs.webkit.org/show_bug.cgi?id=199194
3023
3024         Reviewed by Jonathan Bedard.
3025
3026         * BuildSlaveSupport/ews-build/steps.py:
3027         (RunWebKitTests.evaluateCommand): Check if tests failed and retry them if required.
3028         (ReRunWebKitTests): Build step to re-run layout tests.
3029         (ReRunWebKitTests.evaluateCommand): Check if tests failed and retry on clean build if required.
3030         (RunWebKitTestsWithoutPatch): Build step to run tests without patch.
3031         (RunWebKitTestsWithoutPatch.evaluateCommand):
3032
3033 2019-06-25  Aakash Jain  <aakash_jain@apple.com>
3034
3035         [ews-build] Combine various patchFailed*Tests properties
3036         https://bugs.webkit.org/show_bug.cgi?id=199193
3037
3038         Reviewed by Jonathan Bedard.
3039
3040         * BuildSlaveSupport/ews-build/steps.py: Renamed patchFailedJSCTests and patchFailedAPITests to patchFailedTests. This property 
3041         can also be used for layout-tests later on.
3042         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
3043
3044 2019-06-25  Ross Kirsling  <ross.kirsling@sony.com>
3045
3046         [Win] MiniBrowser should default to webkit.org
3047         https://bugs.webkit.org/show_bug.cgi?id=199201
3048
3049         Reviewed by Don Olmstead.
3050
3051         * MiniBrowser/win/BrowserWindow.h:
3052         * MiniBrowser/win/MiniBrowserReplace.h:
3053         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3054         (WebKitBrowserWindow::loadHTMLString): Deleted.
3055         * MiniBrowser/win/WebKitBrowserWindow.h:
3056         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
3057         (WebKitLegacyBrowserWindow::loadHTMLString): Deleted.
3058         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
3059         * MiniBrowser/win/WinMain.cpp:
3060         (wWinMain):
3061
3062 2019-06-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3063
3064         [iOS] Occasional crash under -[UIPreviewTarget initWithContainer:center:transform:] when generating a drag preview
3065         https://bugs.webkit.org/show_bug.cgi?id=199192
3066         <rdar://problem/51554509>
3067
3068         Reviewed by Tim Horton.
3069
3070         Tweak the drag and drop simulator to ask for drag cancellation previews, and use this to write a couple tests to
3071         verify that we gracefully handle web process termination and web view unparenting mid-drag.
3072
3073         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3074         (TestWebKitAPI::TEST):
3075         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
3076         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3077         (-[DragAndDropSimulator _resetSimulatedState]):
3078         (-[DragAndDropSimulator _concludeDropAndPerformOperationIfNecessary]):
3079         (-[DragAndDropSimulator _advanceProgress]):
3080         (-[DragAndDropSimulator liftPreviews]):
3081         (-[DragAndDropSimulator cancellationPreviews]):
3082         (-[DragAndDropSimulator setSessionWillBeginBlock:]):
3083         (-[DragAndDropSimulator sessionWillBeginBlock]):
3084         (-[DragAndDropSimulator _webView:dataInteraction:sessionWillBegin:]):
3085
3086 2019-06-25  Aakash Jain  <aakash_jain@apple.com>
3087
3088         [ews-build] UploadTestResults and ExtractTestResults clobber results in case of multiple layout test runs in a build
3089         https://bugs.webkit.org/show_bug.cgi?id=199178
3090
3091         Reviewed by Jonathan Bedard.
3092
3093         * BuildSlaveSupport/ews-build/steps.py:
3094         (UploadTestResults.__init__): Add an optional identifier and append the identifier to the file name.
3095         (ExtractTestResults.__init__): Ditto.
3096         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit tests.
3097
3098 2019-06-25  Michael Catanzaro  <mcatanzaro@igalia.com>
3099
3100         Add user agent quirk for bankofamerica.com
3101         https://bugs.webkit.org/show_bug.cgi?id=199154
3102
3103         Reviewed by Carlos Garcia Campos.
3104
3105         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3106         (TestWebKitAPI::TEST):
3107
3108 2019-06-25  Michael Catanzaro  <mcatanzaro@igalia.com>
3109
3110         Fully rename WebKitGTK+ -> WebKitGTK everywhere
3111         https://bugs.webkit.org/show_bug.cgi?id=199159
3112
3113         Reviewed by Carlos Garcia Campos.
3114
3115         * BuildSlaveSupport/gtk/README:
3116         * MiniBrowser/gtk/BrowserWindow.c:
3117         * MiniBrowser/gtk/main.c:
3118         (aboutURISchemeRequestCallback):
3119         * Scripts/webkitpy/common/config/contributionareas.py:
3120         * Scripts/webkitpy/common/config/contributors.json:
3121         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py:
3122         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
3123         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
3124         (testWebViewResources):
3125         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3126         (testWebViewMouseTarget):
3127         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
3128         (testWebExtensionGetTitle):
3129         (testDocumentLoadedSignal):
3130         (testWebExtensionFormControlsAssociated):
3131         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3132         (testWebKitSettingsUserAgent):
3133         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3134         (testWebViewRunJavaScript):
3135         * TestWebKitAPI/Tests/WebKitGtk/InspectorTestServer.cpp:
3136         (main):
3137         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
3138         (prepareContextMenuTestView):
3139         (testContextMenuPopulateMenu):
3140         (testContextMenuCustomMenu):
3141         (testContextMenuDisableMenu):
3142         (testContextMenuSubMenu):
3143         (testContextMenuDismissed):
3144         (testContextMenuWebExtensionMenu):
3145         (testContextMenuWebExtensionNode):
3146         * TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp:
3147         (testInspectorDefault):
3148         (testInspectorManualAttachDetach):
3149         (testInspectorCustomContainerDestroyed):
3150         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
3151         (testWebViewPrint):
3152         (testPrintOperationPrint):
3153         (testPrintOperationErrors):
3154         * gtk/install-dependencies:
3155         * gtk/jhbuild.modules:
3156         * gtkdoc/generate-gtkdoc:
3157         * wpe/install-dependencies:
3158
3159 2019-06-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3160
3161         contributors.json not canonicalized since r243297
3162         https://bugs.webkit.org/show_bug.cgi?id=199161
3163
3164         Reviewed by Alexey Proskuryakov.
3165
3166         Canonicalize it using 'validate-committer-lists --canonicalize'
3167
3168         * Scripts/webkitpy/common/config/contributors.json:
3169
3170 2019-06-24  Jonathan Bedard  <jbedard@apple.com>
3171
3172         webkitpy: Build style should be lower-case
3173         https://bugs.webkit.org/show_bug.cgi?id=199158
3174
3175         Reviewed by Aakash Jain.
3176
3177         * Scripts/webkitpy/test/main.py:
3178         (Tester._run_tests): Make all styles lower-case.
3179
3180 2019-06-24  Aakash Jain  <aakash_jain@apple.com>
3181
3182         [ews-build] Remove iOS queue from old EWS and dashboard
3183         https://bugs.webkit.org/show_bug.cgi?id=199150
3184
3185         Reviewed by Jonathan Bedard.
3186
3187         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3188         * QueueStatusServer/config/queues.py:
3189
3190 2019-06-21  Ryan Haddad  <ryanhaddad@apple.com>
3191
3192         API Test [Mojave+ WK2 Debug ] TestWebKitAPI.WKAttachmentTestsMac.InsertDroppedFilePromisesAsAttachments is a flaky crash
3193         https://bugs.webkit.org/show_bug.cgi?id=198795
3194
3195         Unreviewed test gardening.
3196
3197         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3198         (TestWebKitAPI::TEST): Disable flaky test.
3199
3200 2019-06-24  Aakash Jain  <aakash_jain@apple.com>
3201
3202         [ews-build] Enable iOS-12-Build queue on new EWS
3203         https://bugs.webkit.org/show_bug.cgi?id=199149
3204
3205         Reviewed by Jonathan Bedard.
3206
3207         * BuildSlaveSupport/ews-build/config.json: Enable iOS-12-Build-EWS trigger. Also temporarily share ews152 and ews154 with
3208         this queue.
3209         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3210         (StatusBubble): Enable ios status-bubble. Also display the ios bubble first (left). Going forward
3211         will keep the builders to the left and testers to the right.
3212
3213 2019-06-24  Aakash Jain  <aakash_jain@apple.com>
3214
3215         [ews-build] Upload test results after running layout-tests
3216         https://bugs.webkit.org/show_bug.cgi?id=199120
3217
3218         Reviewed by Jonathan Bedard.
3219
3220         * BuildSlaveSupport/ews-build/steps.py:
3221         (RunWebKitTests.evaluateCommand):
3222         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3223
3224 2019-06-24  Aakash Jain  <aakash_jain@apple.com>
3225
3226         [ews-build] EWS should provide option to download layout test results zip file
3227         https://bugs.webkit.org/show_bug.cgi?id=199121
3228
3229         Reviewed by Jonathan Bedard.
3230
3231         * BuildSlaveSupport/ews-build/steps.py:
3232         (ExtractTestResults.resultsDownloadURL): Method to return layout test result zip file url. 
3233         (ExtractTestResults.addCustomURLs): Add url to download layout test results zip file.
3234
3235 2019-06-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3236
3237         Add user agent quirk for Google Drive
3238         https://bugs.webkit.org/show_bug.cgi?id=199153
3239
3240         Reviewed by Carlos Garcia Campos.
3241
3242         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3243         (TestWebKitAPI::TEST):
3244
3245 2019-06-22  Zalan Bujtas  <zalan@apple.com>
3246
3247         [LFC] Expand tests coverage (328 new tests -> 2652).
3248
3249         * LayoutReloaded/misc/LFC-passing-tests.txt:
3250
3251 2019-06-22  Andres Gonzalez  <andresg_22@apple.com>
3252
3253         Accessibility objects contained in links should honor the aria-haspopup attribute in the ancestor link.
3254         https://bugs.webkit.org/show_bug.cgi?id=199107
3255         <rdar://problem/43663611>
3256
3257         Reviewed by Chris Fleizach.
3258
3259         iOS implementation for AccessibilityUIElement::hasPopup.
3260         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3261         (WTR::AccessibilityUIElement::hasPopup const):
3262
3263 2019-06-22  Konstantin Tokarev  <annulen@yandex.ru>
3264
3265         Unreviewed, add myself to CMake watchlist
3266
3267         * Scripts/webkitpy/common/config/watchlist:
3268
3269 2019-06-21  Sihui Liu  <sihui_liu@apple.com>
3270
3271         openDatabase should return an empty object when WebSQL is disabled
3272         https://bugs.webkit.org/show_bug.cgi?id=198805
3273
3274         Reviewed by Geoffrey Garen.
3275
3276         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3277         * TestWebKitAPI/Tests/WebKitCocoa/WebSQLBasics.mm: Added.
3278         (-[WebSQLBasicsMessageHandler userContentController:didReceiveScriptMessage:]):
3279         (TEST):
3280         * TestWebKitAPI/Tests/WebKitCocoa/opendatabase-always-exists.html: Added.
3281
3282 2019-06-21  Jiewen Tan  <jiewen_tan@apple.com>
3283
3284         WebPageProxy::loadData should accept ShouldOpenExternalURLsPolicy
3285         https://bugs.webkit.org/show_bug.cgi?id=199114
3286         <rdar://problem/51671674>
3287
3288         Reviewed by Youenn Fablet.
3289
3290         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
3291         (-[TestSOAuthorizationNavigationDelegate init]):
3292         (-[TestSOAuthorizationNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3293         (configureSOAuthorizationWebView):
3294         (TestWebKitAPI::TEST):
3295
3296 2019-06-21  Youenn Fablet  <youenn@apple.com>
3297
3298         WebPageProxy should use the right path for sandbox extension
3299         https://bugs.webkit.org/show_bug.cgi?id=198902
3300         <rdar://problem/50772810>
3301
3302         Reviewed by Geoffrey Garen.
3303
3304         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm:
3305         (TEST):
3306         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3307
3308 2019-06-21  Michael Catanzaro  <mcatanzaro@igalia.com>
3309
3310         [WPE][GTK] Bump minimum versions of GLib, GTK, libsoup, ATK, GStreamer, and Cairo
3311         https://bugs.webkit.org/show_bug.cgi?id=199094
3312
3313         Reviewed by Carlos Garcia Campos.
3314
3315         * MiniBrowser/gtk/BrowserTab.c:
3316         (runColorChooserCallback):
3317         (browserTabConstructed):
3318         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
3319         (testWebViewSyncRequestOnMaxConns):
3320         (beforeAll):
3321         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
3322         (testWebSocketTLSErrors):
3323         (beforeAll):
3324         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
3325         (WebKitTestServer::~WebKitTestServer):
3326         (WebKitTestServer::getWebSocketURIForPath const):
3327         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3328         (WTR::AccessibilityUIElement::rowHeaders const):
3329         (WTR::AccessibilityUIElement::columnHeaders const):
3330         (WTR::AccessibilityUIElement::isAttributeSettable):
3331         (WTR::AccessibilityUIElement::x):
3332         (WTR::AccessibilityUIElement::y):
3333         (WTR::AccessibilityUIElement::width):
3334         (WTR::AccessibilityUIElement::height):
3335         (WTR::AccessibilityUIElement::clickPointX):
3336         (WTR::AccessibilityUIElement::clickPointY):
3337         (WTR::AccessibilityUIElement::intValue const):
3338         (WTR::AccessibilityUIElement::minValue):
3339         (WTR::AccessibilityUIElement::maxValue):
3340         (WTR::stringAtOffset):
3341
3342 2019-06-20  Dean Johnson  <dean_johnson@apple.com>
3343
3344         test-webkitpy is broken on macOS Catalina
3345         https://bugs.webkit.org/show_bug.cgi?id=199078
3346
3347         Reviewed by Jonathan Bedard.
3348
3349         * Scripts/webkitpy/test/main.py: Check if lldb tests are supported before adding them
3350         to the runner.
3351         (main): 
3352         (_supports_building_and_running_lldb_tests): Check if you are running macOS Catalina.
3353
3354 2019-06-20  Dean Johnson  <dean_johnson@apple.com>
3355
3356         Change status to "committer" in contributors.json
3357
3358         Unreviewed.
3359
3360         * Scripts/webkitpy/common/config/contributors.json:
3361
3362 2019-06-20  Alex Christensen  <achristensen@webkit.org>
3363
3364         Add unit test for UIContextMenuConfiguration API
3365         https://bugs.webkit.org/show_bug.cgi?id=199043
3366
3367         Reviewed by Wenson Hsieh.
3368
3369         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3370         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm: Added.
3371         (-[TestContextMenuUIDelegate webView:contextMenuConfigurationForElement:completionHandler:]):
3372         (-[TestContextMenuUIDelegate webView:contextMenuWillPresentForElement:]):
3373         (-[TestContextMenuUIDelegate webView:contextMenuForElement:willCommitWithAnimator:]):
3374         (-[TestContextMenuUIDelegate webView:contextMenuDidEndForElement:]):
3375         (TEST):
3376         * TestWebKitAPI/cocoa/TestContextMenuDriver.h: Added.
3377         * TestWebKitAPI/cocoa/TestContextMenuDriver.mm: Added.
3378         (-[TestContextMenuDriver delegate]):
3379         (-[TestContextMenuDriver setDelegate:]):
3380         (-[TestContextMenuDriver view]):
3381         (-[TestContextMenuDriver setView:]):
3382         (-[TestContextMenuDriver allowableMovement]):
3383         (-[TestContextMenuDriver setAllowableMovement:]):
3384         (-[TestContextMenuDriver primaryGestureRecognizer]):
3385         (-[TestContextMenuDriver setPrimaryGestureRecognizer:]):
3386         (-[TestContextMenuDriver touchDuration]):
3387         (-[TestContextMenuDriver setTouchDuration:]):
3388         (-[TestContextMenuDriver locationInCoordinateSpace:]):
3389         (-[TestContextMenuDriver cancelInteraction]):
3390         (-[TestContextMenuDriver begin:]):
3391         (-[TestContextMenuDriver clickDown]):
3392         (-[TestContextMenuDriver clickUp]):
3393         (-[TestContextMenuDriver end]):
3394         * TestWebKitAPI/ios/UIKitSPI.h:
3395
3396 2019-06-20  Aakash Jain  <aakash_jain@apple.com>
3397
3398         [ews-app] Status bubble should not turn orange when any build step is skipped
3399         https://bugs.webkit.org/show_bug.cgi?id=199079
3400
3401         Reviewed by Jonathan Bedard.
3402
3403         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3404
3405 2019-06-20  Alex Christensen  <achristensen@webkit.org>
3406
3407         Fix an internal engineering build after r246605
3408        ​https://bugs.webkit.org/show_bug.cgi?id=197800
3409
3410         * TestWebKitAPI/TCPServer.cpp:
3411
3412 2019-06-20  Aakash Jain  <aakash_jain@apple.com>
3413
3414         [ews-build] Triggered builds should use same revision as parent build
3415         https://bugs.webkit.org/show_bug.cgi?id=198289
3416
3417         Reviewed by Jonathan Bedard.
3418
3419         * BuildSlaveSupport/ews-build/steps.py:
3420         (CheckOutSpecificRevision): Build step to checkout specific revision.
3421         (CheckOutSpecificRevision.doStepIf): Run this step only if ews_revision property is set.
3422         (CheckOutSpecificRevision.hideStepIf): Hide this step when it is skipped.
3423         (CheckOutSpecificRevision.start): Run appropriate git command.
3424         (Trigger.propertiesToPassToTriggers): Pass ews_revision property to triggered builds, so that triggered
3425         builds use same revision as parent build.
3426         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3427         * BuildSlaveSupport/ews-build/factories.py:
3428         (Factory.__init__): Added CheckOutSpecificRevision step.
3429
3430 2019-06-20  Aakash Jain  <aakash_jain@apple.com>
3431
3432         [ews-build] Add unit tests for AnalyzeCompileWebKitResults
3433         https://bugs.webkit.org/show_bug.cgi?id=199073
3434
3435         Reviewed by Jonathan Bedard.
3436
3437         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests for AnalyzeCompileWebKitResults.
3438
3439 2019-06-20  Alexander Mikhaylenko  <exalm7659@gmail.com>
3440
3441         [GTK] Enable navigation swipe layout tests
3442         https://bugs.webkit.org/show_bug.cgi?id=198995
3443
3444         Reviewed by Michael Catanzaro.
3445
3446         Add a way for tests to enable and then control swipe gesture on GTK.
3447
3448         * TestRunnerShared/UIScriptContext/UIScriptController.cpp: Hide
3449         empty implementations of beginBackSwipe() and completeBackSwipe() for GTK.
3450         * WebKitTestRunner/PlatformGTK.cmake:
3451         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3452         (WTR::PlatformWebView::setNavigationGesturesEnabled): Implemented.
3453         * WebKitTestRunner/gtk/UIScriptControllerGtk.cpp: Added.
3454         (WTR::UIScriptController::beginBackSwipe):
3455         (WTR::UIScriptController::completeBackSwipe):
3456
3457 2019-06-20  Alexander Mikhaylenko  <exalm7659@gmail.com>
3458
3459         [GTK] HTTP layout tests don't run in flatpak
3460         https://bugs.webkit.org/show_bug.cgi?id=199067
3461
3462         Reviewed by Michael Catanzaro.
3463
3464         Stop bind mounting /app/lib/perl to /etc/perl because Perl doesn't actually
3465         check that path. Instead, add /app/lib/perl to Apache config directly.
3466
3467         /usr/manifest.json file is not guaranteed to exist in sandbox, check for
3468         /.flatpak-info instead.
3469
3470         * Scripts/webkitpy/port/base.py:
3471         (Port._is_flatpak):
3472         (Port._in_flatpak_sandbox):
3473         * flatpak/flatpakutils.py:
3474         (WebkitFlatpak.run_in_sandbox):
3475         (is_sandboxed):
3476
3477 2019-06-18  Darin Adler  <darin@apple.com>
3478
3479         Tidy up the remaining bits of the AtomicString to AtomString rename
3480         https://bugs.webkit.org/show_bug.cgi?id=198990
3481
3482         Reviewed by Michael Catanzaro.
3483
3484         * Scripts/do-webcore-rename: Removed already-done renames.
3485         * TestWebKitAPI/Tests/WTF/StringImpl.cpp: Rename one use of "atomic".
3486
3487 2019-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3488
3489         [GTK] Remove support for GTK2 plugins
3490         https://bugs.webkit.org/show_bug.cgi?id=199065
3491
3492         Reviewed by Sergio Villar Senin.
3493
3494         * EWSTools/ubuntu-ews-packages:
3495         * TestWebKitAPI/PlatformGTK.cmake:
3496         * WebKitTestRunner/PlatformGTK.cmake:
3497         * flatpak/org.webkit.GTK.yaml:
3498         * gtk/install-dependencies:
3499
3500 2019-06-19  Yusuke Suzuki  <ysuzuki@apple.com>
3501
3502         [bmalloc] IsoHeap's initialization is racy with IsoHeap::isInitialized
3503         https://bugs.webkit.org/show_bug.cgi?id=199053
3504
3505         Reviewed by Saam Barati.
3506
3507         Added a test stressing IsoHeap with multiple threads.
3508
3509         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
3510         (assertHasObjects):
3511         (assertHasOnlyObjects):
3512         (assertClean):
3513         (TEST):
3514
3515 2019-06-19  Zalan Bujtas  <zalan@apple.com>
3516
3517         [LFC] Expand tests coverage (1126 new tests -> 2324).
3518
3519         * LayoutReloaded/misc/LFC-passing-tests.txt:
3520
3521 2019-06-19  Fujii Hironori  <Hironori.Fujii@sony.com>
3522
3523         Add WTF::crossThreadCopy(T&&) to utilize String::isolatedCopy() &&
3524         https://bugs.webkit.org/show_bug.cgi?id=198957
3525
3526         Reviewed by Alex Christensen.
3527
3528         * TestWebKitAPI/CMakeLists.txt:
3529         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3530         * TestWebKitAPI/Tests/WTF/CrossThreadCopier.cpp: Added.
3531
3532 2019-06-19  Keith Rollin  <krollin@apple.com>
3533
3534         Relocate some test tools in non-mac builds
3535         https://bugs.webkit.org/show_bug.cgi?id=198984
3536         <rdar://problem/51873261>
3537
3538         Reviewed by Andy Estes.
3539
3540         The tools DumpRenderTree, WebKitTestRunner, LayoutTestHelper, and
3541         TestNetscapePlugin get created in
3542         WebKit.framework/Versions/A/Resources on non-mac builds. This is
3543         incorrect, as those bundles are shallow bundles that don't use the
3544         Versions hierarchy. Instead, store these files directly in
3545         WebKit.framework.
3546
3547         Note that getting rid of just the "Versions/A" path components and
3548         putting the files in WebKit.framework/Resources doesn't work as
3549         `codesign` treats the result as an invalid layout.
3550
3551         The work in this patch involves changing the definition of the custom
3552         build variable WEBKIT_FRAMEWORK_RESOURCES_PATH. The standard build
3553         variable INSTALL_PATH is defined in terms of this variable. In order
3554         to increase visiblity into this relationship, move both of these
3555         variables into .xcconfig files if they weren't already. This
3556         refactoring was done in a way to be the least disruptive and most
3557         compatible with the previous definitions, even at the cost of being
3558         repetitive.
3559
3560         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3561         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3562         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
3563         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig:
3564         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
3565         * WebKitTestRunner/Configurations/BaseTarget.xcconfig:
3566
3567 2019-06-19  Aakash Jain  <aakash_jain@apple.com>
3568
3569         [ews-build] Patch link should open the pretty patch
3570         https://bugs.webkit.org/show_bug.cgi?id=199031
3571
3572         Reviewed by Jonathan Bedard.
3573
3574         * BuildSlaveSupport/ews-build/steps.py:
3575         (ConfigureBuild.getPatchURL): Use the prettypatch url for patch.
3576
3577 2019-06-19  Aakash Jain  <aakash_jain@apple.com>
3578
3579         [ews-build] Add step to analyze Compile WebKit failures
3580         https://bugs.webkit.org/show_bug.cgi?id=199025
3581
3582         Reviewed by Jonathan Bedard.
3583
3584         * BuildSlaveSupport/ews-build/steps.py:
3585         (CompileWebKit.evaluateCommand): Add AnalyzeCompileWebKitResults step.
3586         (CompileWebKitToT): set haltOnFailure to False since we need to run AnalyzeCompileWebKitResults step.
3587         (AnalyzeCompileWebKitResults): Class to analyze compile webkit steps results.
3588         (AnalyzeCompileWebKitResults.start): If ToT fails to build, retry the build, else marked the build as failed. Note that
3589         this step is run only when compile-webkit failed.
3590
3591 2019-06-19  Aakash Jain  <aakash_jain@apple.com>
3592
3593         [ews-build] Send email notifications for failures
3594         https://bugs.webkit.org/show_bug.cgi?id=198919
3595
3596         Reviewed by Jonathan Bedard.
3597
3598         * BuildSlaveSupport/ews-build/master.cfg:
3599
3600 2019-06-19  Alex Christensen  <achristensen@webkit.org>
3601
3602         Add a unit test for client certificate authentication
3603         https://bugs.webkit.org/show_bug.cgi?id=197800
3604
3605         Reviewed by Youenn Fablet.
3606
3607         Make better abstractions for reading and writing from/to TCPServer.
3608         Add a unit test that causes a client certificate authentication challenge to happen.
3609
3610         * TestWebKitAPI/TCPServer.cpp:
3611         (TestWebKitAPI::TCPServer::TCPServer):
3612         (TestWebKitAPI::TCPServer::read):
3613         (TestWebKitAPI::TCPServer::write):
3614         (TestWebKitAPI::TCPServer::respondWithChallengeThenOK):
3615         (TestWebKitAPI::TCPServer::respondWithOK):
3616         * TestWebKitAPI/TCPServer.h:
3617         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
3618         (credentialWithIdentity):
3619         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
3620         (TEST):
3621         (-[ClientCertificateDelegate webView:didFinishNavigation:]):
3622         (-[ClientCertificateDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
3623         (-[ClientCertificateDelegate challengeCount]):
3624         (TestWebKitAPI::TEST):
3625         (respondWithChallengeThenOK): Deleted.
3626         (credentialWithIdentityAndKeychainPath): Deleted.
3627         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
3628         (TEST):
3629         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
3630         (TestWebKitAPI::TEST):
3631         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
3632         (TEST):
3633         (readRequest): Deleted.
3634         (writeResponse): Deleted.
3635         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
3636         (TestWebKitAPI::TEST):
3637         (TestWebKitAPI::respondWithChallengeThenOK): Deleted.
3638
3639 2019-06-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3640
3641         Unreviewed, fix build warnings in TestWebKitAPIInjectedBundle
3642
3643         System headers are being included without SYSTEM again here.
3644
3645         * TestWebKitAPI/PlatformGTK.cmake:
3646
3647 2019-06-18  Yusuke Suzuki  <ysuzuki@apple.com>
3648
3649         [JSC] JSLock should be WebThread aware
3650         https://bugs.webkit.org/show_bug.cgi?id=198911
3651
3652         Reviewed by Geoffrey Garen.
3653
3654         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3655         * TestWebKitAPI/Tests/WebKitLegacy/ios/JSLockTakesWebThreadLock.mm: Added.
3656         (TestWebKitAPI::TEST):
3657
3658 2019-06-18  Keith Miller  <keith_miller@apple.com>