36c58fb36ef74abb79bc73ef1925c9688656b7ff
[WebKit-https.git] / Tools / ChangeLog
1 2014-03-27  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2
3         <https://webkit.org/b/42704> WebKitTestRunner needs to print history delegate information
4
5         Provide an implementation of WKContextHistoryClient that logs when called for tests in
6         the globalhistory directory.
7
8         Reviewed by Sam Weinig.
9
10         * WebKitTestRunner/TestController.cpp:
11         (WTR::TestController::TestController):
12         (WTR::TestController::initialize): Set the history client.
13         (WTR::TestController::resetStateToConsistentValues): Disable logging of history client callbacks.
14         (WTR::TestController::didNavigateWithNavigationData): Log information about the navigation. Some portions
15         of the output are hard-coded to match WebKit1's results for now since they're fixed in our existing tests
16         and we don't yet have API to access the data in question.
17         (WTR::TestController::didPerformClientRedirect):
18         (WTR::TestController::didPerformServerRedirect):
19         (WTR::TestController::didUpdateHistoryTitle):
20         * WebKitTestRunner/TestController.h:
21         (WTR::TestController::setShouldLogHistoryClientCallbacks):
22         * WebKitTestRunner/TestInvocation.cpp:
23         (WTR::shouldLogHistoryClientCallbacks): Log history client callbacks for tests in a globalhistory directory.
24         (WTR::TestInvocation::invoke):
25
26 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
27
28         Revert http://trac.webkit.org/changeset/166386 because it broke builds.
29
30         * Scripts/build-webkit:
31         * Scripts/copy-webkitlibraries-to-product-directory:
32
33 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
34
35         Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
36         https://bugs.webkit.org/show_bug.cgi?id=130867
37         <rdar://problem/16432456> 
38
39         Reviewed by Mark Hahnenberg.
40
41         * Scripts/build-webkit:
42         * Scripts/copy-webkitlibraries-to-product-directory:
43
44 2014-03-26  Andy Estes  <aestes@apple.com>
45
46         [Cocoa] Expose DownloadClient::didFail() and DownloadClient::didCancel()
47         https://bugs.webkit.org/show_bug.cgi?id=130805
48
49         Reviewed by Dan Bernstein.
50
51         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
52         (-[DownloadDelegate _download:didReceiveResponse:]):
53         (-[DownloadDelegate _downloadDidFinish:]):
54         (runTest):
55         (TEST):
56         (-[FailingDownloadDelegate _downloadDidFinish:]):
57         (-[FailingDownloadDelegate _download:didFailWithError:]):
58         (-[FailingDownloadDelegate _downloadDidCancel:]):
59         (-[CancelledDownloadDelegate _downloadDidStart:]):
60         (-[CancelledDownloadDelegate _downloadDidFinish:]):
61         (-[CancelledDownloadDelegate _download:didFailWithError:]):
62         (-[CancelledDownloadDelegate _downloadDidCancel:]):
63         (-[DownloadDelegate initWithSourceURL:]): Deleted.
64         (-[DownloadDelegate sourceURL]): Deleted.
65         (runTestWithNavigationDelegate): Deleted.
66
67 2014-03-26  Anders Carlsson  <andersca@apple.com>
68
69         Change MiniBrowser to hold on to window controllers instead of windows
70         https://bugs.webkit.org/show_bug.cgi?id=130797
71
72         Reviewed by Oliver Hunt.
73
74         * MiniBrowser/mac/AppDelegate.h:
75         * MiniBrowser/mac/AppDelegate.m:
76         (-[BrowserAppDelegate init]):
77         (-[BrowserAppDelegate newWindow:]):
78         (-[BrowserAppDelegate browserWindowWillClose:]):
79         (-[BrowserAppDelegate applicationWillTerminate:]):
80         (-[BrowserAppDelegate frontmostBrowserWindowController]):
81
82 2014-03-26  Commit Queue  <commit-queue@webkit.org>
83
84         Unreviewed, rolling out r166264.
85         https://bugs.webkit.org/show_bug.cgi?id=130785
86
87         Broke some window.opener tests for WK2 Mavericks (Requested by
88         brrian__ on #webkit).
89
90         Reverted changeset:
91
92         "Web Replay: resource unique identifiers should be unique-per-
93         frame, not globally"
94         https://bugs.webkit.org/show_bug.cgi?id=130632
95         http://trac.webkit.org/changeset/166264
96
97 2014-03-26  Zoltan Horvath  <zoltan@webkit.org>
98
99         [CSS Shapes] Remove shape-inside support
100         https://bugs.webkit.org/show_bug.cgi?id=130698
101
102         Reviewed by David Hyatt.
103
104         * Scripts/webkitperl/FeatureList.pm:
105
106 2014-02-27  Gurpreet Kaur  <k.gurpreet@samsung.com>
107
108         Unreviewed. Add myself as a committer.
109
110         * Scripts/webkitpy/common/config/contributors.json:
111
112 2014-03-26  Tomas Popela  <tpopela@redhat.com>
113
114         run-launcher is Perl script so use elsif and not elif
115         https://bugs.webkit.org/show_bug.cgi?id=130771
116
117         Reviewed by Carlos Garcia Campos.
118
119         * Scripts/run-launcher:
120
121 2014-03-26  Krzysztof Czech  <k.czech@samsung.com>
122
123         [ATK] Utilize new AtkValue interface coming in ATK 2.11.92
124         https://bugs.webkit.org/show_bug.cgi?id=130575
125
126         Reviewed by Mario Sanchez Prada.
127
128         Change ATK version to 2.11.92. Adjust current implementation.
129
130         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
131         (AccessibilityUIElement::intValue):
132         (AccessibilityUIElement::minValue):
133         (AccessibilityUIElement::maxValue):
134         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
135         (WTR::AccessibilityUIElement::intValue):
136         (WTR::AccessibilityUIElement::minValue):
137         (WTR::AccessibilityUIElement::maxValue):
138         * efl/jhbuild.modules:
139         * gtk/jhbuild.modules:
140
141 2014-03-12  Philippe Normand  <pnormand@igalia.com>
142
143         [GTK] The gnumake package is no longer needed in jhbuild
144         https://bugs.webkit.org/show_bug.cgi?id=130121
145
146         Reviewed by Martin Robinson.
147
148         For GTK build-webkit now relies on cmake and ninja/gnumake. Even
149         for a debug build cmake/system-gnumake worked just fine for me.
150
151         * gtk/jhbuild.modules: Removed gnumake.
152         * gtk/patches/make-3.82-arg-list-length.patch: Removed.
153         * gtk/patches/make-3.82-parallel-build.patch: Removed.
154
155 2014-03-25  Andy Estes  <aestes@apple.com>
156
157         Fix a failing API test on Mountain Lion and remove temporary debug logging.
158
159         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
160         (-[DownloadDelegate _download:didReceiveData:]):
161         (-[DownloadDelegate _downloadDidFinish:]):
162
163 2014-03-25  Brian Burg  <bburg@apple.com>
164
165         Web Replay: resource unique identifiers should be unique-per-frame, not globally
166         https://bugs.webkit.org/show_bug.cgi?id=130623
167
168         Reviewed by Timothy Hatcher.
169
170         The resource loader callback dumping routines assumed that resource identifiers
171         were globally unique. Its map of resource identifiers to URLs must also track the
172         frame associated with the resource.
173
174         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
175         (WTR::dumpResourceURL): Additionally take a WKBundleFrameRef argument, and use the
176         opaque pointer as part of the key for assignedUrlsCache. The frame pointer is
177         stable as long as the frame is valid.
178         (WTR::InjectedBundlePage::didInitiateLoadForResource):
179         (WTR::InjectedBundlePage::willSendRequestForFrame):
180         (WTR::InjectedBundlePage::didReceiveResponseForResource):
181         (WTR::InjectedBundlePage::didFinishLoadForResource):
182         (WTR::InjectedBundlePage::didFailLoadForResource):
183
184 2014-03-25  Andy Estes  <aestes@apple.com>
185
186         Fix one API test expectation failure on Mountain Lion, and add additional logging to help diagnose another.
187
188         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
189         (-[DownloadDelegate _download:didReceiveResponse:]):
190         (-[DownloadDelegate _download:didReceiveData:]):
191
192 2014-03-25  Andy Estes  <aestes@apple.com>
193
194         Add some debug logging to an API test that's failing on Mountain Lion.
195
196         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
197         (-[DownloadDelegate _download:didReceiveResponse:]):
198         (-[DownloadDelegate _downloadDidFinish:]):
199
200 2014-03-25  Anders Carlsson  <andersca@apple.com>
201
202         Add goBack: and goForward: IBActions and move stopLoading: to a new WKIBActions category on WKWebView
203         https://bugs.webkit.org/show_bug.cgi?id=130732
204
205         Reviewed by Tim Horton.
206
207         * MiniBrowser/mac/WK2BrowserWindowController.m:
208         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
209
210 2014-03-25  Martin Robinson  <mrobinson@igalia.com>
211
212         [GTK] Remove the autotools build
213         https://bugs.webkit.org/show_bug.cgi?id=130717
214
215         Reviewed by Anders Carlsson.
216
217         * DumpRenderTree/config.h: Remove references to the autotools configure file.
218         * GNUmakefile.am: Removed.
219         * GtkLauncher/GNUmakefile.am: Removed.
220         * GtkLauncher/main.c: Remove references to the autotools configure file.
221         * MiniBrowser/gtk/BrowserDownloadsBar.c: Ditto.
222         * MiniBrowser/gtk/BrowserSearchBar.c: Ditto.
223         * MiniBrowser/gtk/BrowserWindow.c: Ditto.
224         * MiniBrowser/gtk/GNUmakefile.am: Removed.
225         * MiniBrowser/gtk/main.c: Remove references to the autotools configure file.
226         * Scripts/build-webkit: No longer handle autotools.
227         * Scripts/run-gtk-tests: Ditto.
228         (TestRunner._setup_testing_environment):
229         * Scripts/run-launcher: Ditto.
230         * Scripts/webkitdirs.pm: Ditto.
231         * Scripts/webkitpy/common/config/contributionareas.py: Remove autotools as a contribution area.
232         * Scripts/webkitpy/common/config/contributors.json: Ditto.
233         * Scripts/webkitpy/port/gtk.py: No longer handle autotools.
234         * Scripts/webkitpy/style/checker.py:
235         * TestWebKitAPI/GNUmakefile.am: Removed.
236         * TestWebKitAPI/config.h: Remove references to the autotools configure file.
237         * WebKitTestRunner/GNUmakefile.am: Removed.
238         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Ditto.
239         * gtk/GNUmakefile.am: Removed.
240         * gtk/common.py: Remove checks for the autotools build.
241         * gtk/symbols.filter: Renamed from Source/autotools/symbols.filter.
242
243 2014-03-25  László Langó  <llango.u-szeged@partner.samsung.com>
244
245         prepare-ChangeLog throws false positive warnings for modified files.
246         https://bugs.webkit.org/show_bug.cgi?id=130687
247
248         Reviewed by Darin Adler.
249
250         * Scripts/prepare-ChangeLog:
251         (originalFile): Ignore git commit paremeter.
252         We don't need this to get the unmodified file.
253         (extractLineRangeBeforeChange):
254         Simplify the if statement. Follow-up after r166189.
255
256 2014-03-25  Gabor Rapcsanyi  <rgabor@webkit.org>
257
258         [EFL] Add ARM64 build support
259         https://bugs.webkit.org/show_bug.cgi?id=130506
260
261         Rubber stamped by Gyuyoung Kim.
262
263         * Scripts/webkitdirs.pm:
264         (isARM): Detect aarch64 as ARM.
265
266 2014-03-25  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
267
268         [webkitpy] Improve _parse_bug_description to recognize more descriptions
269         https://bugs.webkit.org/show_bug.cgi?id=130137
270
271         Reviewed by Csaba Osztrogonác.
272
273         * Scripts/webkitpy/common/checkout/changelog.py:
274         (ChangeLogEntry._parse_bug_description):
275         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
276         (test_parse_log_entries_from_changelog):
277         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
278         (CheckoutTest.test_commit_info_for_revision):
279
280 2014-03-24  Andy Estes  <aestes@apple.com>
281
282         Fix the iOS build of TestWebKitAPI.
283
284         * TestWebKitAPI/Configurations/Base.xcconfig:
285         * TestWebKitAPI/PlatformUtilities.h:
286
287 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
288
289         Fix prepare-ChangeLog after r166156.
290         https://bugs.webkit.org/show_bug.cgi?id=130674
291
292         Reviewed by Darin Adler.
293
294         * Scripts/prepare-ChangeLog:
295         (generateFunctionLists):
296         (extractLineRangeBeforeChange):
297
298 2014-03-24  Andy Estes  <aestes@apple.com>
299
300         [iOS] Download support by CFURLDownloadRef under USE(CFNETWORK).
301         https://bugs.webkit.org/show_bug.cgi?id=129322
302
303         Reviewed by Anders Carlsson.
304
305         Add an API test suite for _WKDownload.
306
307         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
308         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm: Added.
309         (-[DownloadDelegate initWithSourceURL:]):
310         (-[DownloadDelegate sourceURL]):
311         (-[DownloadDelegate _downloadDidStart:]):
312         (-[DownloadDelegate _download:didReceiveResponse:]):
313         (-[DownloadDelegate _download:didReceiveData:]):
314         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
315         (-[DownloadDelegate _downloadDidFinish:]):
316         (TEST):
317         (runTestWithNavigationDelegate):
318         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
319         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
320
321 2014-03-24  Joseph Pecoraro  <pecoraro@apple.com>
322
323         filter-build-webkit: reduce unfiltered output
324         https://bugs.webkit.org/show_bug.cgi?id=130485
325
326         Reviewed by Brent Fulgham.
327
328         * Scripts/filter-build-webkit:
329         (shouldIgnoreLine):
330
331 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
332
333         prepare-ChangeLog should list functions that have been removed too.
334         https://bugs.webkit.org/show_bug.cgi?id=130508
335
336         Reviewed by Darin Adler.
337
338         The prepare-ChangeLog does not list the deleted functions in the Changelog.
339         We have to read the functions and the line ranges of them from the source
340         before the change, then search for overlaps between them and the changed
341         line ranges from diff.
342
343         * Scripts/prepare-ChangeLog:
344         (originalFile): Get original source command.
345         (generateFunctionLists): Collect deleted functions too.
346         (generateFunctionListsByRanges): Duplicated code is moved to a separate subroutine.
347         (extractLineRangeBeforeChange): Extract line ranges from the original source to get
348         deleted functions ranges too.
349         (extractLineRange): Renamed to extractLineRangeAfterChange.
350
351 2014-03-23  Hyowon Kim  <hw1008.kim@samsung.com>
352
353         Move all EFL typedefs into EflTypedefs.h.
354         https://bugs.webkit.org/show_bug.cgi?id=130511
355
356         Reviewed by Gyuyoung Kim.
357
358         * TestWebKitAPI/PlatformWebView.h: Remove EFL typedefs.
359         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
360         * WebKitTestRunner/PlatformWebView.h: Ditto.
361
362 2014-03-21  Simon Fraser  <simon.fraser@apple.com>
363
364         Don't flush compositing layers within FrameView::willPaintContents()
365         https://bugs.webkit.org/show_bug.cgi?id=130627
366         <rdar://problem/16368869>
367
368         Reviewed by Sam Weinig.
369         
370         Fix DRT to correctly render tests with layers now that FrameView::paintContents
371         does not flush.
372         
373         Move the -[WebView displayIfNeeded] from -[FrameLoadDelegate webView:didFinishLoadForFrame:]
374         into an explicit function called before dumping. 
375         
376         Then explicitly call _flushCompositingChanges to ensure that GraphicsLayer changes
377         are flushed to CA. They will be pushed to the window by snapshotting.
378
379         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
380         Fix weird path to IOKit.framework.
381         * DumpRenderTree/mac/DumpRenderTree.mm:
382         (updateDisplay):
383         (dump):
384         * DumpRenderTree/mac/FrameLoadDelegate.mm:
385         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]): Fix parameter name.
386         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): Remove display call.
387
388 2014-03-21  David Kilzer  <ddkilzer@apple.com>
389
390         fix-blink-patch: tool to fix up renamed directory paths in Blink
391         <http://webkit.org/b/130609>
392
393         Reviewed by Ryosuke Niwa.
394
395         Usage: cat blink.patch | fix-blink-patch | svn-apply
396
397         * Scripts/fix-blink-patch: Added.
398
399 2014-03-21  Darin Adler  <darin@apple.com>
400
401         Remove use of deprecatedCharacters in WebKit API tests
402         https://bugs.webkit.org/show_bug.cgi?id=130602
403
404         Reviewed by Antti Koivisto.
405
406         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
407         (TestWebKitAPI::expectBuilderContent): Use characters8/16 instead of deprecatedCharacters.
408         (TestWebKitAPI::expectEmpty): Use characters8.
409         (TestWebKitAPI::TEST): Use characters8 instead of deprecatedCharacters in most cases.
410
411         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
412         Removed the test that is entirely about 16-bit conversion since that's basically a test of
413         the deprecatedCharacters function itself, which we are about to delete.
414
415 2014-03-21  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
416
417         [webkitpy] Fix has_valid_reviewer()
418         https://bugs.webkit.org/show_bug.cgi?id=130589
419
420         Reviewed by Csaba Osztrogonác.
421
422         * Scripts/webkitpy/common/checkout/changelog.py:
423         (ChangeLogEntry.has_valid_reviewer):
424         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
425         (test_has_valid_reviewer):
426         * Scripts/webkitpy/common/config/committers.py:
427         (CommitterList._reviewer_only):
428         (CommitterList.committer_by_name):
429         (CommitterList.reviewer_by_email):
430         (CommitterList):
431         (CommitterList.reviewer_by_name):
432
433 2014-03-21  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
434
435         Add cache support for jhbuild
436         https://bugs.webkit.org/show_bug.cgi?id=130588
437
438         Reviewed by Csaba Osztrogonác.
439
440         * jhbuild/jhbuildrc_common.py:
441         (init): Jhbuild can now save the dependencies locally, if the JHBUILD_MIRROR environment variable is set.
442
443 2014-03-21  Xabier Rodriguez Calvar  <calvaris@igalia.com>
444
445         [CMake] Add support for MAX_CPU_LOAD translated to -l in ninja and make
446         https://bugs.webkit.org/show_bug.cgi?id=130504
447
448         Reviewed by Martin Robinson.
449
450         * Scripts/build-webkit: Add the maxCPULoad() to the makeArgs in
451         CMake if not specified.
452         * Scripts/webkitdirs.pm:
453         (determineMaxCPULoad): Read MAX_CPU_LOAD as maxCPULoad.
454         (maxCPULoad): determineMaxCPULoad and return maxCPULoad.
455
456 2014-03-21  Andreas Kling  <akling@apple.com>
457
458         RetainPtr API test should use CFArray instead of CFString for testing.
459         <rdar://problem/16384899>
460
461         Unreviewed bot fix.
462
463         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
464         (TestWebKitAPI::TEST):
465         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
466         (TestWebKitAPI::TEST):
467
468 2014-03-20  Hyowon Kim  <hw1008.kim@samsung.com>
469
470         Move to using std::unique_ptr for EFL objects.
471         https://bugs.webkit.org/show_bug.cgi?id=129853
472
473         Reviewed by Gyuyoung Kim.
474
475         EflUniquePtr is a template alias of std::unique_ptr
476         with a custom deleter for each Efl Objects, which is motivated by GUniquePtr.
477         This patch replaces uses of OwnPtr and PassOwnPtr for Efl objects with EflUniquePtr.
478
479         * DumpRenderTree/efl/DumpRenderTree.cpp:
480         (main):
481         * ImageDiff/efl/ImageDiff.cpp:
482         (initEfl):
483         (main):
484
485 2014-03-20  Ryuan Choi  <ryuan.choi@samsung.com>
486
487         Unreviewed buildfix after r165983 for non Cocoa platforms
488
489         Renamed WKPreferencesPrivate.h to WKPreferencesRefPrivate.h
490
491         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
492         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
493         * WebKitTestRunner/TestController.cpp:
494
495 2014-03-20  Zan Dobersek  <zdobersek@igalia.com>
496
497         [GTK][CMake] Add support for building with Clang
498         https://bugs.webkit.org/show_bug.cgi?id=130260
499
500         Reviewed by Martin Robinson.
501
502         * TestWebKitAPI/CMakeLists.txt: When building with Clang TestWebKitAPI should be
503         built with GTEST_HAS_TR1_TUPLE defined to 0 to avoid build failures occuring in the
504         included GTest framework headers.
505         * gtk/generate-gtkdoc:
506         (prepare_environment_for_gtkdoc_generation): Don't modify the CFLAGS env anymore
507         in case of using Clang since that is now set by the CMake rule.
508
509 2014-03-19  Simon Fraser  <simon.fraser@apple.com>
510
511         Expose text and page zoom in WK2 SPI, and hook them up in MiniBrowser
512         https://bugs.webkit.org/show_bug.cgi?id=130476
513
514         Reviewed by Anders Carlsson.
515         
516         Hook up page/text zoom in MiniBrowser, make reload work, remove some logging.
517
518         * MiniBrowser/mac/WK1BrowserWindowController.m:
519         (-[WK1BrowserWindowController webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
520         Remove log.
521         * MiniBrowser/mac/WK2BrowserWindowController.m:
522         (-[WK2BrowserWindowController awakeFromNib]):
523         (-[WK2BrowserWindowController validateMenuItem:]):
524         (-[WK2BrowserWindowController reload:]):
525         Hook up reload.
526         (-[WK2BrowserWindowController toggleZoomMode:]):
527         (-[WK2BrowserWindowController resetZoom:]):
528         (-[WK2BrowserWindowController canResetZoom]):
529         (-[WK2BrowserWindowController currentZoomFactor]):
530         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
531         (-[WK2BrowserWindowController canZoomIn]):
532         (-[WK2BrowserWindowController canZoomOut]):
533
534 2014-03-19  Alexey Proskuryakov  <ap@apple.com>
535
536         REGRESSION (OS X 10.9.2): PageVisibilityStateWithWindowChanges.WebKit2 API test fails
537         https://bugs.webkit.org/show_bug.cgi?id=130463
538
539         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm: Disable the test.
540
541 2014-03-18  Samuel White  <samuel_white@apple.com>
542
543         AX: Not able to use arrow keys to read text with VoiceOver before selection is set someplace (anyplace).
544         https://bugs.webkit.org/show_bug.cgi?id=130250
545
546         Reviewed by Chris Fleizach.
547
548         Added ability to toggle enhanced accessibility on and off to support tests that require it.
549
550         * DumpRenderTree/AccessibilityController.cpp:
551         (enableEnhancedAccessibilityCallback):
552         (getEnhancedAccessibilityEnabledCallback):
553         (AccessibilityController::getJSClass):
554         * DumpRenderTree/AccessibilityController.h:
555         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
556         (AccessibilityController::enableEnhancedAccessibility):
557         (AccessibilityController::enhancedAccessibilityEnabled):
558         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
559         (AccessibilityController::enableEnhancedAccessibility):
560         (AccessibilityController::enhancedAccessibilityEnabled):
561         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
562         (AccessibilityController::enableEnhancedAccessibility):
563         (AccessibilityController::enhancedAccessibilityEnabled):
564         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
565         (AccessibilityController::enableEnhancedAccessibility):
566         (AccessibilityController::enhancedAccessibilityEnabled):
567         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
568         (WTR::AccessibilityController::enableEnhancedAccessibility):
569         (WTR::AccessibilityController::enhancedAccessibilityEnabled):
570         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
571         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
572
573 2014-03-18  Filip Pizlo  <fpizlo@apple.com>
574
575         Unreviewed, add some contributors, and fix Nadav's entry (he's not really a reviewer
576         yet).
577
578         * Scripts/webkitpy/common/config/contributors.json:
579
580 2014-03-18  Joseph Pecoraro  <pecoraro@apple.com>
581
582         Web Inspector: Remove stale ReportMemoryUsagePlugin
583         https://bugs.webkit.org/show_bug.cgi?id=130405
584
585         Reviewed by Andreas Kling.
586
587         This clang plugin looks like it was used for the old Inspector memory
588         instrumentation that was removed. So the tool can be removed.
589
590         * clang/ReportMemoryUsagePlugin/CMakeLists.txt: Removed.
591         * clang/ReportMemoryUsagePlugin/Makefile: Removed.
592         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp: Removed.
593         * clang/ReportMemoryUsagePlugin/tests/Source/WebCore/Test.cpp: Removed.
594
595 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
596
597         webkit-patch land shouldn't add a reviewer for unreviewed build fixes
598         https://bugs.webkit.org/show_bug.cgi?id=130220
599
600         Reviewed by Csaba Osztrogonác.
601
602         * Scripts/webkitpy/common/checkout/changelog.py:
603         (ChangeLog.set_reviewer):
604         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
605         (test_set_reviewer):
606
607 2014-03-17  Filip Pizlo  <fpizlo@apple.com>
608
609         More FTL enabling.
610
611         Rubber stamped by Dan Bernstein.
612
613         * Tools/Scripts/build-webkit:
614
615 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
616
617         Renable pagination mode in WK2 MiniBrowser
618         https://bugs.webkit.org/show_bug.cgi?id=130374
619
620         Reviewed by Anders Carlsson.
621         
622         Put the implementation of togglePaginationMode: back, and correctly
623         enable the menu item.
624
625         * MiniBrowser/mac/WK2BrowserWindowController.m:
626         (-[WK2BrowserWindowController validateMenuItem:]):
627         (-[WK2BrowserWindowController isPaginated]):
628         (-[WK2BrowserWindowController togglePaginationMode:]):
629
630 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
631
632         Add --reset option to Tools/Scripts/set-webkit-configuration script
633         https://bugs.webkit.org/show_bug.cgi?id=130401
634
635         Reviewed by Csaba Osztrogonác.
636
637         * Scripts/set-webkit-configuration:
638
639 2014-03-18  Alberto Garcia  <berto@igalia.com>
640
641         [GTK] [CMake] build-webkit-options.txt is not generated during a fresh build
642         https://bugs.webkit.org/show_bug.cgi?id=130388
643
644         Reviewed by Sergio Villar Senin.
645
646         * Scripts/webkitdirs.pm:
647         (shouldRemoveCMakeCache): make sure that the build directory
648         exists before attempting to create a file in it.
649
650 2014-03-18  Robert Plociennik  <r.plociennik@samsung.com>
651
652         [EFL] fontconfig-2.8.0 is not compliant with C++11 leading to a build break
653         https://bugs.webkit.org/show_bug.cgi?id=130336
654
655         Reviewed by Gyuyoung Kim.
656
657         Compilation with gcc 4.8.x results in 'invalid suffix on literal; C++11
658         requires a space between literal and string macro [-Wliteral-suffix]'
659         warning treated as error.
660
661         This patch applies a solution from r162448 to the EFL port.
662
663         * efl/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
664         * efl/jhbuild.modules: Added appropriate patch section.
665
666 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
667
668         webkitpy test rebaseline.
669
670         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
671         (MainTest.test_default_args):
672
673 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
674
675         --profile should imply --test-runner-count=1 in run-perf-tests
676         https://bugs.webkit.org/show_bug.cgi?id=130375
677
678         Reviewed by Benjamin Poulain.
679
680         Use the test runner count of 1 when --profile is specified but not --test-runner-count.
681
682         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
683         (PerfTestsRunner._parse_args): Use -1 as the default value.
684         (PerfTestsRunner._collect_tests): If --test-runner-count is set (i.e. it's a positive value),
685         then use that value. Otherwise, if it's never set and --profile is present, test-runner-count
686         should be 1.
687
688 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
689
690         Address some style nits.
691
692         * MiniBrowser/mac/WK2BrowserWindowController.m:
693
694 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
695
696         Add transparent window support back into MiniBrowser
697         https://bugs.webkit.org/show_bug.cgi?id=130363
698
699         Reviewed by Anders Carlsson.
700         
701         Re-enable transparent window support for WK2.
702
703         * MiniBrowser/mac/WK2BrowserWindowController.m:
704         (-[WK2BrowserWindowController validateMenuItem:]):
705         (-[WK2BrowserWindowController toggleTransparentWindow:]):
706
707 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
708
709         Fix the 32-bit build; make the open panel make a WK1 window.
710
711         * MiniBrowser/mac/AppDelegate.m:
712         (-[BrowserAppDelegate openDocument:]):
713
714 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
715
716         Convert MiniBrowser to use WKWebView API
717         https://bugs.webkit.org/show_bug.cgi?id=130061
718
719         Reviewed by Anders Carlsson.
720         
721         Convert the MiniBrowser WK2 window to use WebKit2 API as much
722         as possible.
723         
724         Some functionality was removed temporarily:
725             - text zoom, page zoom
726             - reload
727             - pagination mode
728             - transparent window
729             - dumping source
730             - window.open support
731             - beforeUnload panel
732             - find in page
733
734         * MiniBrowser/mac/AppDelegate.h:
735         * MiniBrowser/mac/AppDelegate.m:
736         (-[BrowserAppDelegate init]):
737         (-[BrowserAppDelegate newWindow:]):
738         (-[BrowserAppDelegate applicationWillTerminate:]):
739         (-[BrowserAppDelegate openDocument:]):
740         * MiniBrowser/mac/WK2BrowserWindowController.h:
741         * MiniBrowser/mac/WK2BrowserWindowController.m:
742         (-[WK2BrowserWindowController awakeFromNib]):
743         (-[WK2BrowserWindowController dealloc]):
744         (-[WK2BrowserWindowController fetch:]):
745         (-[WK2BrowserWindowController validateMenuItem:]):
746         (-[WK2BrowserWindowController reload:]):
747         (-[WK2BrowserWindowController goBack:]):
748         (-[WK2BrowserWindowController goForward:]):
749         (-[WK2BrowserWindowController toggleZoomMode:]):
750         (-[WK2BrowserWindowController resetZoom:]):
751         (-[WK2BrowserWindowController canResetZoom]):
752         (-[WK2BrowserWindowController dumpSourceToConsole:]):
753         (-[WK2BrowserWindowController togglePaginationMode:]):
754         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
755         (-[WK2BrowserWindowController windowShouldClose:]):
756         (-[WK2BrowserWindowController applicationTerminating]):
757         (-[WK2BrowserWindowController currentZoomFactor]):
758         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
759         (-[WK2BrowserWindowController toggleTransparentWindow:]):
760         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
761         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
762         (-[WK2BrowserWindowController webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
763         (-[WK2BrowserWindowController webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
764         (-[WK2BrowserWindowController find:]):
765         (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
766         (-[WK2BrowserWindowController webView:didStartProvisionalNavigation:]):
767         (-[WK2BrowserWindowController webView:didReceiveServerRedirectForProvisionalNavigation:]):
768         (-[WK2BrowserWindowController webView:didFailProvisionalNavigation:withError:]):
769         (-[WK2BrowserWindowController webView:didCommitNavigation:]):
770         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
771         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
772         * WebKitTestRunner/PlatformWebView.h:
773         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
774         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
775
776 2014-03-17  Zan Dobersek  <zdobersek@igalia.com>
777
778         Use RunLoop objects through references instead of pointers
779         https://bugs.webkit.org/show_bug.cgi?id=130313
780
781         Reviewed by Andreas Kling.
782
783         Adjust the code accordingly now that RunLoop::current() and RunLoop::main()
784         return RunLoop reference instead of a pointer.
785
786         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp:
787         (loadedCallback):
788         (clickedCallback):
789
790 2014-03-17  Tim Horton  <timothy_horton@apple.com>
791
792         sort-export-file --help doesn't work (missing 'use')
793         https://bugs.webkit.org/show_bug.cgi?id=130338
794
795         Reviewed by Anders Carlsson.
796
797         * Scripts/sort-export-file:
798         Add a missing 'use', and fix a typo in an error message.
799
800 2014-03-17  Martin Robinson  <mrobinson@igalia.com>
801
802         [GTK][CMake] Ensure that HAVE_GTK_UNIX_PRINTING is defined when appropriate
803         https://bugs.webkit.org/show_bug.cgi?id=130155
804
805         Reviewed by Philippe Normand.
806
807         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Add GTK_UNIX_PRINT flags to the build.
808
809 2014-03-17  Carlos Garcia Campos  <cgarcia@igalia.com>
810
811         [GTK] MiniBrowser fails to load injected bundle lib
812         https://bugs.webkit.org/show_bug.cgi?id=130332
813
814         Reviewed by Anders Carlsson.
815
816         This is because WEBKIT_INJECTED_BUNDLE_PATH env var is set too late.
817
818         * MiniBrowser/gtk/main.c:
819         (main): Make sure WEBKIT_INJECTED_BUNDLE_PATH is set before a web
820         process is spawn.
821
822 2014-03-16  Kim Byung Jun  <bj1987.kim@samsung.com>
823
824         [EFL] Enable TOUCH_SLIDER macro
825         https://bugs.webkit.org/show_bug.cgi?id=130185
826
827         Reviewed by Gyuyoung Kim.
828
829         * Scripts/webkitperl/FeatureList.pm:
830
831 2014-03-16  Zan Dobersek  <zdobersek@igalia.com>
832
833         [GTK][CMake] Build with -fno-rtti
834         https://bugs.webkit.org/show_bug.cgi?id=130261
835
836         Reviewed by Martin Robinson.
837
838         * TestWebKitAPI/CMakeLists.txt: Build TestWebKitAPI with GTEST_HAS_RTTI macro
839         defined to 0 to prevent typeid use in included GTest headers.
840
841 2014-03-16  Brian Burg  <bburg@apple.com>
842
843         Web Inspector: vended backend commands file should be generated as part of the build
844         https://bugs.webkit.org/show_bug.cgi?id=130110
845
846         Reviewed by Timothy Hatcher.
847
848         * Scripts/build-webkit: build WebInspectorUI after WebCore but before WebKit.
849
850 2014-03-16  Diego Pino García  <dpino@igalia.com>
851
852         [GTK] Minibrowser: Add shortcuts for reloading page and reloading page ignoring cache
853         https://bugs.webkit.org/show_bug.cgi?id=128999
854
855         Reviewed by Philippe Normand.
856
857         * MiniBrowser/gtk/BrowserWindow.c:
858         (reloadPage):
859         (reloadPageIgnoringCache):
860         (browser_window_init):
861
862 2014-03-15  Martin Robinson  <mrobinson@igalia.com>
863
864         [GTK] Improve ninja detection in webkitdirs.pm
865         https://bugs.webkit.org/show_bug.cgi?id=129902
866
867         Reviewed by Daniel Bates.
868
869         * Scripts/webkitdirs.pm:
870         (canUseNinja): Use which instead of trying to invoke ninja directly. This also allows
871         us to look for ninja-build as well.
872
873 2014-03-14  Maciej Stachowiak  <mjs@apple.com>
874
875         Replace "Apple Computer, Inc." with "Apple Inc." in copyright headers
876         https://bugs.webkit.org/show_bug.cgi?id=130276
877         <rdar://problem/16266927>
878         
879         Reviewed by Simon Fraser.
880
881         * BuildSlaveSupport/build-launcher-app:
882         * BuildSlaveSupport/build-launcher-dmg:
883         * DumpRenderTree/DumpRenderTree.h:
884         * DumpRenderTree/DumpRenderTreePrefix.h:
885         * DumpRenderTree/GCController.cpp:
886         * DumpRenderTree/GCController.h:
887         * DumpRenderTree/JavaScriptThreading.cpp:
888         * DumpRenderTree/JavaScriptThreading.h:
889         * DumpRenderTree/PixelDumpSupport.cpp:
890         * DumpRenderTree/PixelDumpSupport.h:
891         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
892         * DumpRenderTree/TestRunner.cpp:
893         * DumpRenderTree/TestRunner.h:
894         * DumpRenderTree/WorkQueue.cpp:
895         * DumpRenderTree/WorkQueue.h:
896         * DumpRenderTree/WorkQueueItem.h:
897         * DumpRenderTree/atk/AccessibilityCallbacks.h:
898         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
899         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
900         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
901         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
902         * DumpRenderTree/cg/PixelDumpSupportCG.h:
903         * DumpRenderTree/efl/EditingCallbacks.cpp:
904         * DumpRenderTree/efl/EditingCallbacks.h:
905         * DumpRenderTree/efl/EventSender.cpp:
906         * DumpRenderTree/efl/EventSender.h:
907         * DumpRenderTree/efl/GCControllerEfl.cpp:
908         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
909         * DumpRenderTree/efl/TestRunnerEfl.cpp:
910         * DumpRenderTree/gtk/DumpRenderTree.cpp:
911         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
912         * DumpRenderTree/gtk/EditingCallbacks.cpp:
913         * DumpRenderTree/gtk/EditingCallbacks.h:
914         * DumpRenderTree/gtk/EventSender.cpp:
915         * DumpRenderTree/gtk/EventSender.h:
916         * DumpRenderTree/gtk/GCControllerGtk.cpp:
917         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
918         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp:
919         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h:
920         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
921         * DumpRenderTree/gtk/TextInputController.cpp:
922         * DumpRenderTree/gtk/TextInputController.h:
923         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL:
924         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm:
925         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
926         * DumpRenderTree/mac/AppleScriptController.h:
927         * DumpRenderTree/mac/AppleScriptController.m:
928         * DumpRenderTree/mac/CheckedMalloc.cpp:
929         * DumpRenderTree/mac/CheckedMalloc.h:
930         * DumpRenderTree/mac/DumpRenderTree.mm:
931         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
932         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
933         * DumpRenderTree/mac/DumpRenderTreeMac.h:
934         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
935         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
936         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
937         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
938         * DumpRenderTree/mac/EditingDelegate.h:
939         * DumpRenderTree/mac/EditingDelegate.mm:
940         * DumpRenderTree/mac/EventSendingController.h:
941         * DumpRenderTree/mac/EventSendingController.mm:
942         * DumpRenderTree/mac/FrameLoadDelegate.h:
943         * DumpRenderTree/mac/FrameLoadDelegate.mm:
944         * DumpRenderTree/mac/GCControllerMac.mm:
945         * DumpRenderTree/mac/MockWebNotificationProvider.h:
946         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
947         * DumpRenderTree/mac/NavigationController.h:
948         * DumpRenderTree/mac/NavigationController.m:
949         * DumpRenderTree/mac/ObjCController.h:
950         * DumpRenderTree/mac/ObjCController.m:
951         * DumpRenderTree/mac/ObjCPlugin.h:
952         * DumpRenderTree/mac/ObjCPlugin.m:
953         * DumpRenderTree/mac/ObjCPluginFunction.h:
954         * DumpRenderTree/mac/ObjCPluginFunction.m:
955         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
956         * DumpRenderTree/mac/PolicyDelegate.h:
957         * DumpRenderTree/mac/PolicyDelegate.mm:
958         * DumpRenderTree/mac/ResourceLoadDelegate.h:
959         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
960         * DumpRenderTree/mac/TestRunnerMac.mm:
961         * DumpRenderTree/mac/TextInputController.h:
962         * DumpRenderTree/mac/TextInputController.m:
963         * DumpRenderTree/mac/UIDelegate.h:
964         * DumpRenderTree/mac/UIDelegate.mm:
965         * DumpRenderTree/mac/WorkQueueItemMac.mm:
966         * DumpRenderTree/win/DRTDataObject.cpp:
967         * DumpRenderTree/win/DRTDataObject.h:
968         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
969         * DumpRenderTree/win/DRTDropSource.cpp:
970         * DumpRenderTree/win/DRTDropSource.h:
971         * DumpRenderTree/win/DraggingInfo.h:
972         * DumpRenderTree/win/DumpRenderTree.cpp:
973         * DumpRenderTree/win/DumpRenderTreeWin.h:
974         * DumpRenderTree/win/EditingDelegate.cpp:
975         * DumpRenderTree/win/EditingDelegate.h:
976         * DumpRenderTree/win/EventSender.cpp:
977         * DumpRenderTree/win/EventSender.h:
978         * DumpRenderTree/win/FrameLoadDelegate.cpp:
979         * DumpRenderTree/win/FrameLoadDelegate.h:
980         * DumpRenderTree/win/GCControllerWin.cpp:
981         * DumpRenderTree/win/HistoryDelegate.cpp:
982         * DumpRenderTree/win/HistoryDelegate.h:
983         * DumpRenderTree/win/MD5.cpp:
984         * DumpRenderTree/win/MD5.h:
985         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
986         * DumpRenderTree/win/PolicyDelegate.cpp:
987         * DumpRenderTree/win/PolicyDelegate.h:
988         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
989         * DumpRenderTree/win/ResourceLoadDelegate.h:
990         * DumpRenderTree/win/TestRunnerWin.cpp:
991         * DumpRenderTree/win/TextInputController.cpp:
992         * DumpRenderTree/win/TextInputController.h:
993         * DumpRenderTree/win/TextInputControllerWin.cpp:
994         * DumpRenderTree/win/UIDelegate.cpp:
995         * DumpRenderTree/win/UIDelegate.h:
996         * DumpRenderTree/win/WorkQueueItemWin.cpp:
997         * EWebLauncher/main.c:
998         * GtkLauncher/main.c:
999         * ImageDiff/efl/ImageDiff.cpp:
1000         * ImageDiff/gtk/ImageDiff.cpp:
1001         * MiniBrowser/gtk/main.c:
1002         * Scripts/SpacingHeuristics.pm:
1003         * Scripts/VCSUtils.pm:
1004         * Scripts/bisect-builds:
1005         * Scripts/build-dumprendertree:
1006         * Scripts/build-jsc:
1007         * Scripts/build-webkit:
1008         * Scripts/check-dom-results:
1009         * Scripts/check-for-exit-time-destructors:
1010         * Scripts/check-for-global-initializers:
1011         * Scripts/commit-log-editor:
1012         * Scripts/compare-timing-files:
1013         * Scripts/debug-minibrowser:
1014         * Scripts/debug-safari:
1015         * Scripts/do-file-rename:
1016         * Scripts/find-extra-includes:
1017         * Scripts/generate-coverage-data:
1018         * Scripts/make-script-test-wrappers:
1019         * Scripts/malloc-tree:
1020         * Scripts/old-run-webkit-tests:
1021         * Scripts/parse-malloc-history:
1022         * Scripts/report-include-statistics:
1023         * Scripts/resolve-ChangeLogs:
1024         * Scripts/run-bindings-tests:
1025         * Scripts/run-iexploder-tests:
1026         * Scripts/run-javascriptcore-tests:
1027         * Scripts/run-jsc:
1028         * Scripts/run-launcher:
1029         * Scripts/run-leaks:
1030         * Scripts/run-mangleme-tests:
1031         * Scripts/run-minibrowser:
1032         * Scripts/run-pageloadtest:
1033         * Scripts/run-regexp-tests:
1034         * Scripts/run-safari:
1035         * Scripts/run-sunspider:
1036         * Scripts/run-webkit-app:
1037         * Scripts/sampstat:
1038         * Scripts/set-webkit-configuration:
1039         * Scripts/sort-Xcode-project-file:
1040         * Scripts/sort-export-file:
1041         * Scripts/split-file-by-class:
1042         * Scripts/sunspider-compare-results:
1043         * Scripts/svn-apply:
1044         * Scripts/svn-create-patch:
1045         * Scripts/svn-unapply:
1046         * Scripts/test-webkit-scripts:
1047         * Scripts/update-javascriptcore-test-results:
1048         * Scripts/update-webkit:
1049         * Scripts/update-webkit-auxiliary-libs:
1050         * Scripts/update-webkit-dependency:
1051         * Scripts/update-webkit-localizable-strings:
1052         * Scripts/update-webkit-support-libs:
1053         * Scripts/update-webkit-wincairo-libs:
1054         * Scripts/webkit-build-directory:
1055         * Scripts/webkitdirs.pm:
1056         (installedSafariPath):
1057         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
1058         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
1059         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
1060         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
1061         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
1062         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
1063         * Scripts/webkitperl/features.pm:
1064         * Scripts/webkitperl/httpd.pm:
1065         * Scripts/webkitpy/bindings/main.py:
1066         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
1067         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
1068         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1069         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
1070         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
1071         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
1072         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
1073         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1074         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1075         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.h:
1076         * WebKitTestRunner/PixelDumpSupport.cpp:
1077         * WebKitTestRunner/PixelDumpSupport.h:
1078         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1079         * WinLauncher/WinLauncher.cpp:
1080         * WinLauncher/WinLauncher.h:
1081         * WinLauncher/stdafx.cpp:
1082         * WinLauncher/stdafx.h:
1083
1084 2014-03-14  Filip Pizlo  <fpizlo@apple.com>
1085
1086         Sometimes we need to be explicit about the SDK when running ranlib on Darwin
1087         https://bugs.webkit.org/show_bug.cgi?id=130265
1088
1089         Reviewed by Michael Saboff.
1090
1091         * Scripts/build-webkit:
1092         * Scripts/copy-webkitlibraries-to-product-directory:
1093
1094 2014-03-14  Landry Breuil  <landry@openbsd.org>
1095
1096         Recognize openbsd/netbsd and am64 archs in Tools/Scripts.
1097         Also allow to set MAKE in the environment.
1098         https://bugs.webkit.org/show_bug.cgi?id=129991
1099
1100         Reviewed by Andreas Kling.
1101
1102         * Scripts/webkitdirs.pm:
1103         (determineArchitecture):
1104         (determineNumberOfCPUs):
1105         (isBSD):
1106         (buildAutotoolsProject):
1107         * Scripts/webkitpy/common/system/platforminfo.py:
1108         (PlatformInfo.__init__):
1109         (PlatformInfo.is_openbsd):
1110         (PlatformInfo):
1111         (PlatformInfo.is_netbsd):
1112         (PlatformInfo._determine_os_name):
1113
1114 2014-03-14  Dean Jackson  <dino@apple.com>
1115
1116         Remove libWebKitSystemInterfaceLion.a
1117         https://bugs.webkit.org/show_bug.cgi?id=130254
1118
1119         Reviewed by Geoffrey Garen and Andreas Kling.
1120
1121         No need to copy the Lion libraries into the build.
1122
1123         * Scripts/copy-webkitlibraries-to-product-directory:
1124
1125 2014-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
1126
1127         [EFL][MiniBrowser] Revise help messages of command line parameters
1128         https://bugs.webkit.org/show_bug.cgi?id=130222
1129
1130         Reviewed by Csaba Osztrogonác.
1131
1132         Correct the default value description and make help messages to be consistent.
1133
1134         * MiniBrowser/efl/main.c:
1135
1136 2014-03-12  Sergio Villar Senin  <svillar@igalia.com>
1137
1138         Rename DEFINE_STATIC_LOCAL to DEPRECATED_DEFINE_STATIC_LOCAL
1139         https://bugs.webkit.org/show_bug.cgi?id=129612
1140
1141         Reviewed by Darin Adler.
1142
1143         For new code use static NeverDestroyed<T> instead.
1144
1145         * DumpRenderTree/JavaScriptThreading.cpp:
1146         (javaScriptThreadsMutex):
1147         (javaScriptThreads):
1148         * DumpRenderTree/efl/EventSender.cpp:
1149         (touchPointList):
1150         (delayedEventQueue):
1151         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1152         (delegatesWithDelayedWork):
1153         * Scripts/check-for-exit-time-destructors:
1154         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp:
1155         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
1156         (testsMap):
1157
1158 2014-03-13  Sanghyup Lee  <sh53.lee@samsung.com>
1159
1160         [EFL][WK2] Fix compilation warning in Minibrowser
1161         https://bugs.webkit.org/show_bug.cgi?id=130132
1162
1163         Reviewed by Csaba Osztrogonác.
1164
1165         Replace mktemp() with mkstemp() to fix compilation warning in MiniBrowser.
1166
1167         * MiniBrowser/efl/main.c:
1168         (on_download_request):
1169
1170 2014-03-13  Filip Pizlo  <fpizlo@apple.com>
1171
1172         FTL should support IsBlah
1173         https://bugs.webkit.org/show_bug.cgi?id=130202
1174
1175         Reviewed by Geoffrey Garen.
1176         
1177         Running existing JSRegress tests with noInline gives us coverage for these
1178         changes. Chances are, this will also give coverage for other interesting things
1179         as well.
1180
1181         * Scripts/run-jsc-stress-tests:
1182
1183 2014-03-12  Brian Burg  <bburg@apple.com>
1184
1185         Web Inspector: Remove unused callId parameter from evaluateInWebInspector
1186         https://bugs.webkit.org/show_bug.cgi?id=129744
1187
1188         Reviewed by Timothy Hatcher.
1189
1190         * DumpRenderTree/TestRunner.cpp:
1191         (evaluateInWebInspectorCallback):
1192         * DumpRenderTree/TestRunner.h:
1193         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1194         (TestRunner::evaluateInWebInspector):
1195         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1196         (TestRunner::evaluateInWebInspector):
1197         * DumpRenderTree/mac/TestRunnerMac.mm:
1198         (TestRunner::evaluateInWebInspector):
1199         * DumpRenderTree/win/TestRunnerWin.cpp:
1200         (TestRunner::evaluateInWebInspector):
1201         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1202         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1203         (WTR::TestRunner::evaluateInWebInspector):
1204         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1205
1206 2014-03-13  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
1207
1208         [GTK] build-webkit shouldn't show error message when ninja isn't installed
1209         https://bugs.webkit.org/show_bug.cgi?id=130129
1210
1211         Reviewed by Csaba Osztrogonác.
1212
1213         * Scripts/webkitdirs.pm:
1214         (canUseNinja): Redirecting stderr to /dev/null
1215
1216 2014-03-13  Andres Gomez  <agomez@igalia.com>
1217
1218         [GTK] "Tools/jhbuild/jhbuild-wrapper --gtk" build fails even after running Tools/gtk/install-dependencies due to missing proper libxml2 python bindings
1219         https://bugs.webkit.org/show_bug.cgi?id=130092
1220
1221         Reviewed by Csaba Osztrogonác.
1222
1223         Added "python-dev" as dependency for deb based distros. It is
1224         already present for rpm based distros. This dependency will allow
1225         libxml2 to generate its python bindings, needed by gtk-doc.
1226
1227         * gtk/install-dependencies:
1228
1229 2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1230
1231         Unreviewed. Fix GTK+ cmake build after r165488.
1232
1233         * MiniBrowser/gtk/CMakeLists.txt: Add CMAKE_BINARY_DIR to include dirs.
1234
1235 2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1236
1237         [GTK][CMAKE] Remove compile warnings about GTK+ deprecated API
1238         https://bugs.webkit.org/show_bug.cgi?id=130014
1239
1240         Reviewed by Martin Robinson.
1241
1242         Include cmake or autotools config header.
1243
1244         * MiniBrowser/gtk/BrowserDownloadsBar.c:
1245         * MiniBrowser/gtk/BrowserSearchBar.c:
1246         * MiniBrowser/gtk/BrowserWindow.c:
1247         * MiniBrowser/gtk/main.c:
1248
1249 2014-03-12  Commit Queue  <commit-queue@webkit.org>
1250
1251         Unreviewed, rolling out r165471.
1252         https://bugs.webkit.org/show_bug.cgi?id=130139
1253
1254         Didn't really fix the issue and broke another bot (Requested
1255         by mrobinson on #webkit).
1256
1257         Reverted changeset:
1258
1259         "[CMake] Newer versions of CMake cannot find older versions of
1260         Freetype"
1261         https://bugs.webkit.org/show_bug.cgi?id=130107
1262         http://trac.webkit.org/changeset/165471
1263
1264 2014-03-11  Filip Pizlo  <fpizlo@apple.com>
1265
1266         It should be possible to build WebKit with FTL on iOS
1267         https://bugs.webkit.org/show_bug.cgi?id=130116
1268
1269         Reviewed by Dan Bernstein.
1270
1271         * Scripts/build-webkit:
1272         * Scripts/copy-webkitlibraries-to-product-directory:
1273
1274 2014-03-12  Brent Fulgham  <bfulgham@apple.com>
1275
1276         [Win] Remove use of QTSDK
1277         https://bugs.webkit.org/show_bug.cgi?id=130049
1278
1279         Reviewed by Darin Adler.
1280
1281         * DumpRenderTree/win/DumpRenderTree.cpp:
1282         (initialize): Remove QuickTime code.
1283         * win/AssembleBuildLogs/AssembleLogs.cmd: Don't grab logs from
1284         building QTMovieWin.
1285
1286 2014-03-12  Martin Robinson  <mrobinson@igalia.com>
1287
1288         [GTK][CMAKE] Too verbose build output
1289         https://bugs.webkit.org/show_bug.cgi?id=130076
1290
1291         Reviewed by Carlos Garcia Campos.
1292
1293         Instead of building with cmake --build which isn't smart about pretty printing and
1294         colors, we build with a script which calls the proper build command.
1295
1296         * Scripts/webkitdirs.pm:
1297         (buildCMakeGeneratedProject): For GTK+ call the script that we generate during
1298         the CMake configuration pass.
1299
1300 2014-03-11  Martin Robinson  <mrobinson@igalia.com>
1301
1302         [CMake] Newer versions of CMake cannot find older versions of Freetype
1303         https://bugs.webkit.org/show_bug.cgi?id=130107
1304
1305         Reviewed by Gustavo Noronha Silva.
1306
1307         * gtk/jhbuildrc: Work around a bug in newer CMakes by giving the FREETYPE_DIR hint
1308         to CMake during jhbuild initialization.
1309
1310 2014-03-12  Zalan Bujtas  <zalan@apple.com>
1311
1312         Add hiDPI support for compositing content in DumpRenderTree/WebKitTestRunner
1313         https://bugs.webkit.org/show_bug.cgi?id=129961
1314
1315         Reviewed by Simon Fraser.
1316
1317         Now scaled content can go through the window capturing mechanism too for compositing content.
1318         AppleMagnifiedMode is redundant.
1319
1320         * DumpRenderTree/mac/DumpRenderTree.mm:
1321         (setDefaultsToConsistentValuesForTesting):
1322         (runTest):
1323         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1324         (createBitmapContextFromWebView):
1325         * WebKitTestRunner/PlatformWebView.h:
1326         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1327         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1328         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1329         (WTR::PlatformWebView::didInitializeClients):
1330         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1331         (WTR::PlatformWebView::forceWindowFramesChanged):
1332         * WebKitTestRunner/mac/main.mm:
1333         (setDefaultsToConsistentValuesForTesting):
1334
1335 2014-03-12  Anton Obzhirov  <a.obzhirov@samsung.com>
1336
1337         Unreviewed. Add myself as a committer.
1338
1339         * Scripts/webkitpy/common/config/contributors.json:
1340
1341 2014-03-12  Ryuan Choi  <ryuan.choi@samsung.com>
1342
1343         Unreviewed build fix on the EFL port when used lower version of ATK
1344
1345         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1346         (WTR::AccessibilityUIElement::y): Fixed typo.
1347
1348 2014-03-11  Myles C. Maxfield  <mmaxfield@apple.com>
1349
1350         Some images are blank in the rebaseline server UI
1351         https://bugs.webkit.org/show_bug.cgi?id=130104
1352
1353         Reviewed by Tim Horton.
1354
1355         Let the server check for images in the 'retries' directory
1356         if it can't find an image otherwise.
1357
1358         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
1359         (RebaselineHTTPRequestHandler.test_result):
1360
1361 2014-03-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1362
1363         [GTK][CMake] --update-gtk has no effect
1364         https://bugs.webkit.org/show_bug.cgi?id=130088
1365
1366         Reviewed by Philippe Normand.
1367
1368         * Scripts/webkitdirs.pm:
1369         (buildCMakeProjectOrExit): call update-webkitgtk-libs if --update-gtk has been passed
1370         as an argument.
1371
1372 2014-03-10  Myles C. Maxfield  <mmaxfield@apple.com>
1373
1374         Add "System Font" to the list of whitelisted DRT fonts
1375         https://bugs.webkit.org/show_bug.cgi?id=130046
1376
1377         Reviewed by Darin Adler.
1378
1379         * DumpRenderTree/mac/DumpRenderTree.mm:
1380         (allowedFontFamilySet):
1381         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
1382
1383 2014-03-11  Martin Robinson  <mrobinson@igalia.com>
1384
1385         [GTK] The jhbuild environment should set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_PATH
1386         https://bugs.webkit.org/show_bug.cgi?id=130064
1387
1388         Reviewed by Philippe Normand.
1389
1390         * efl/jhbuildrc: Remove duplicated code.
1391         * gtk/jhbuildrc: Remove duplicated code.
1392         * jhbuild/jhbuildrc_common.py:
1393         (init): Move duplicated code from jhbuildrc's and extend setting CMake environment variables to
1394         GTK+. We always set the CMAKE_LIBRARY_PATH, which should be harmless for EFL 32-bit systems.
1395         and is apparently necessary for GTK+.
1396
1397 2014-03-11  László Langó  <llango.u-szeged@partner.samsung.com>
1398
1399         check-webkit-style failed to complain about missing braces
1400         https://bugs.webkit.org/show_bug.cgi?id=34189
1401
1402         Reviewed by Ryosuke Niwa.
1403
1404         * Scripts/webkitpy/style/checkers/cpp.py:
1405         (check_braces):
1406         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1407         (WebKitStyleTest.test_braces):
1408
1409 2014-03-11  László Langó  <llango.u-szeged@partner.samsung.com>
1410
1411         Remove Qt cruft from style checker.
1412         https://bugs.webkit.org/show_bug.cgi?id=130085
1413
1414         Reviewed by Csaba Osztrogonác.
1415
1416         There is no 'foreach' keyword in c++. That was a Qt feature
1417         added in: http://trac.webkit.org/changeset/46113
1418         Qt was removed from WebKit, so we should remove the checks
1419         of this keyword from check-webkit-style scripts.
1420
1421         * Scripts/webkitpy/style/checkers/cpp.py:
1422         (check_spacing_for_function_call):
1423         (check_spacing):
1424         (check_braces):
1425         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1426         (CppStyleTest.test_mismatching_spaces_in_parens):
1427         (CppStyleTest.test_spacing_for_fncall):
1428         (WebKitStyleTest.test_braces):
1429
1430 2014-03-11  Martin Hodovan  <mhodovan@inf.u-szeged.hu>
1431
1432         [GTK] update-webkitgtk-libs needs itstool
1433         https://bugs.webkit.org/show_bug.cgi?id=130082
1434
1435         After http://trac.webkit.org/changeset/165110 WebKitGTK+ uses gtk-doc 1.20.
1436         itstool is a dependency of building gtk-doc from version 1.19, so it should
1437         be added to Tools/gtk/install-dependencies script, too.
1438
1439         Reviewed by Philippe Normand.
1440
1441         * gtk/install-dependencies:
1442
1443 2014-03-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1444
1445         webkitbot rollout ChangeLogs should be nicer
1446         https://bugs.webkit.org/show_bug.cgi?id=122654
1447
1448         Reviewed by Csaba Osztrogonác.
1449
1450         Added bug urls and descriptions of rolled out patches to the rollout changelog
1451         if they are present in the original changelog. Additionally removed the list of
1452         changed files and functions.
1453
1454         * Scripts/webkitpy/common/checkout/changelog.py:
1455         (ChangeLog.update_with_unreviewed_message): Cut off the list of modified files.
1456         * Scripts/webkitpy/common/checkout/checkout.py:
1457         (Checkout._changelog_data_for_revision): Store bug description.
1458         * Scripts/webkitpy/common/checkout/checkout_mock.py:
1459         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1460         (CheckoutTest.test_commit_info_for_revision):
1461         * Scripts/webkitpy/common/checkout/commitinfo.py:
1462         (CommitInfo.bug_description): Added.
1463         (CommitInfo.to_json):
1464         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
1465         (CommitInfoTest.test_commit_info_creation):
1466         * Scripts/webkitpy/tool/commands/download.py:
1467         (AbstractRolloutPrepCommand._prepare_state): Store bug ids and descriptions of rolled
1468         out patches for creating rollout changelog.
1469         (CreateRollout._prepare_state): Remove obsolete comments and code, the bug id that
1470         caused the regression is stored in state["bug_blocked"] now.
1471         * Scripts/webkitpy/tool/commands/download_unittest.py:
1472         (test_prepare_rollout):
1473         (test_create_rollout_multiple_revision):
1474         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1475         (PrepareChangeLogForRevert._message_for_revert): Add bug urls and descriptions of
1476         rolled out patches to the changelog.
1477         (PrepareChangeLogForRevert.run):
1478         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
1479         (UpdateChangeLogsForRevertTest):
1480         (test_message_for_revert):
1481         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
1482         (ReopenBugAfterRollout.run):
1483
1484 2014-03-11  Krzysztof Czech  <k.czech@samsung.com>
1485
1486         [ATK] Adjust WKTR/DRT to use new API from ATK 2.11.90
1487         https://bugs.webkit.org/show_bug.cgi?id=130021
1488
1489         Reviewed by Mario Sanchez Prada.
1490
1491         Replace deprecated functions to use new API from ATK 2.11.90.
1492
1493         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1494         (AccessibilityUIElement::x):
1495         (AccessibilityUIElement::y):
1496         (AccessibilityUIElement::width):
1497         (AccessibilityUIElement::height):
1498         (AccessibilityUIElement::clickPointX):
1499         (AccessibilityUIElement::clickPointY):
1500         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1501         (WTR::AccessibilityUIElement::x):
1502         (WTR::AccessibilityUIElement::y):
1503         (WTR::AccessibilityUIElement::width):
1504         (WTR::AccessibilityUIElement::height):
1505         (WTR::AccessibilityUIElement::clickPointX):
1506         (WTR::AccessibilityUIElement::clickPointY):
1507
1508 2014-03-11  Krzysztof Czech  <k.czech@samsung.com>
1509
1510         [ATK] Expose aria-posinset and aria-setsize through object attributes
1511         https://bugs.webkit.org/show_bug.cgi?id=130011
1512
1513         Reviewed by Chris Fleizach.
1514
1515         Added missing implementation of numberAttributeValue both to WKTR and DRT.
1516
1517         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1518         (AccessibilityUIElement::numberAttributeValue):
1519         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1520         (WTR::AccessibilityUIElement::numberAttributeValue):
1521
1522 2014-03-10  Brent Fulgham  <bfulgham@apple.com>
1523
1524         [Win] Unreviewed build fix.
1525
1526         Some bad Windows code was committed at some point that prevents the Apple Windows port
1527         from finding its runtime dependencies reliably.
1528
1529         * win/DLLLauncher/DLLLauncherMain.cpp:
1530         (appleApplicationSupportDirectory): Restored this function.
1531         (modifyPath): Update to use appleApplicationSupportDirectory function.
1532
1533 2014-03-10  Zoltan Horvath  <zoltan@webkit.org>
1534
1535         Let the user define the full address of the performance-site-server for uploading results
1536         https://bugs.webkit.org/show_bug.cgi?id=129819
1537
1538         Reviewed by Ryosuke Niwa.
1539
1540         Currently perftestsrunner.py assumes that the server uses https protocol all the time, which
1541         can be confusing. It's more straightforward, if you need to define explicitly the server's full
1542         address along with the protocol, when you're using this parameter. I added HTTPS as the default
1543         protocol for now, in order to avoid breaking the perf bots.
1544
1545         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1546         (_upload_json):
1547         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1548         (MainTest.test_upload_json):
1549
1550 2014-03-10  Brent Fulgham  <bfulgham@apple.com>
1551
1552         [Win] Pass environment to Pre-Build, Pre-Link, and Post-Build Stages.
1553         https://bugs.webkit.org/show_bug.cgi?id=130023
1554
1555         Reviewed by Dean Jackson.
1556
1557         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add missing
1558         /SAFESEH flag to DLL launcher process.
1559
1560 2014-03-09  Martin Robinson  <mrobinson@igalia.com>
1561
1562         RunGtkWebKitGObjectDOMBindingsAPIBreakTests should be added to the BuildAndTestFactory not the TestFactory
1563         https://bugs.webkit.org/show_bug.cgi?id=129980
1564
1565         Reviewed by Carlos Garcia Campos.
1566
1567         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add RunGtkWebKitGObjectDOMBindingsAPIBreakTests to the correct factory.
1568
1569 2014-03-09  Martin Robinson  <mrobinson@igalia.com>
1570
1571         [GTK] Remove the WebView source-mode WebKit1 test
1572         https://bugs.webkit.org/show_bug.cgi?id=129976
1573
1574         Reviewed by Carlos Garcia Campos.
1575
1576         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Remove the source-mode test.
1577
1578 2014-03-08  Martin Robinson  <mrobinson@igalia.com>
1579
1580         Unreviewed build fix for GTKbuild after the switch to CMake
1581
1582         * gtk/common.py:
1583         (is_cmake_build): Like r165284, we need to assume CMake by default, since the
1584         test-only bot doesn't have any build files.
1585
1586 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
1587
1588         [GTK] built-product-archive does not handle GTK+ CMake build
1589         https://bugs.webkit.org/show_bug.cgi?id=129941
1590
1591         * BuildSlaveSupport/built-product-archive:
1592         (archiveBuiltProduct): Fix the build by adding support to built-product-archive for
1593         the CMake build.
1594
1595 2014-03-07  Lorenzo Tilve  <ltilve@igalia.com>
1596
1597         [GTK] Include CMake into install-dependencies script
1598         https://bugs.webkit.org/show_bug.cgi?id=129909
1599
1600         Reviewed by Martin Robinson.
1601
1602         As since r165267 buid-webkit uses CMake by default, the dependency
1603         with 'cmake' package should be introduced.
1604
1605         * gtk/install-dependencies: Ditto.
1606
1607 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
1608
1609         REGRESSION(165267): Broke a webkitpy unit tests
1610         https://bugs.webkit.org/show_bug.cgi?id=129904
1611
1612         Reviewed by Jon Honeycutt.
1613
1614         * Scripts/webkitpy/port/gtk.py: Flip the default test to assume CMake by default.
1615         (GtkPort._is_cmake_build):
1616
1617 2014-03-07  Andres Gomez  <agomez@igalia.com>
1618
1619         [GTK] webkit-patch setup-git-clone fails even after running Tools/gtk/install-dependencies
1620         https://bugs.webkit.org/show_bug.cgi?id=129893
1621
1622         Reviewed by Martin Robinson.
1623
1624         Added "git-svn" as dependency for deb based distros and,
1625         additionally, "subversion" for rpm based distros.
1626
1627         * gtk/install-dependencies:
1628
1629 2014-03-07  Roger Fong  <roger_fong@apple.com>
1630
1631         Remove dummy setSystemWebGLLoadPolicy client method.
1632         https://bugs.webkit.org/show_bug.cgi?id=129873.
1633
1634         Reviewed by Dean Jackson.
1635
1636         * WebKitTestRunner/TestController.cpp:
1637         (WTR::TestController::createWebViewWithOptions):
1638
1639 2014-03-07  Mark Hahnenberg  <mhahnenberg@apple.com>
1640
1641         run-jsc-stress-tests doesn't eagerly report test failures when using the shell runner
1642         https://bugs.webkit.org/show_bug.cgi?id=129886
1643
1644         Reviewed by Mark Lam.
1645
1646         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Added a "verbose" mode to the shell runner.
1647         If we're in verbose mode, then we don't redirect any output when running each test. If we're not
1648         in verbose mode then we redirect stdout to /dev/null and allow any stderr output through.
1649         * Scripts/run-jsc-stress-tests: Redirect any sort of error output to stderr so that it will 
1650         make it through when in non-verbose mode.
1651
1652 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
1653
1654         [GTK] buid-webkit should use CMake by default
1655         https://bugs.webkit.org/show_bug.cgi?id=129855
1656
1657         Reviewed by Carlos Garcia Campos.
1658
1659         Make the CMake build the default GTK+ build when using build-webkit. This will
1660         ensure that all bots are using CMake. We do this by swapping --gtk and --gtkcmake,
1661         so that we have --gtk and --gtkautotools.
1662
1663         * Scripts/webkitdirs.pm: Swap --gtkcmake/--gtk for --gtk/--gtkautotools.
1664         * Scripts/webkitpy/port/gtk.py: Ditto.
1665
1666 2014-03-06  Martin Robinson  <mrobinson@igalia.com>
1667
1668         [CMake] [GTK] Build with ninja when it is available
1669         https://bugs.webkit.org/show_bug.cgi?id=129805
1670
1671         Reviewed by Philippe Normand.
1672
1673         * Scripts/webkitdirs.pm:
1674         (canUseNinja): Added this helper which tries to execute Ninja, in an effort to determine
1675         if it's available on the system.
1676         (cmakeGeneratedBuildfile): Return the path to the generated build file. Only Unix support ATM.
1677         (generateBuildSystemFromCMakeProject): For GTK+ compile with Ninja when possible.
1678
1679 2014-03-06  Filip Pizlo  <fpizlo@apple.com>
1680
1681         If the FTL is build-time enabled then it should be run-time enabled.
1682
1683         Rubber stamped by Geoffrey Garen.
1684
1685         * Scripts/run-jsc-stress-tests:
1686
1687 2014-03-06  Mark Hahnenberg  <mhahnenberg@apple.com>
1688
1689         detectFailures in run-jsc-stress-tests can report everything was ok if too many tests fail
1690         https://bugs.webkit.org/show_bug.cgi?id=129837
1691
1692         Reviewed by Michael Saboff.
1693
1694         ls test_fail_* can fail if there are too many files that match. We then swallow that error, which makes everything seem ok.
1695         The fix is to use find instead of ls like we do in shell-runner.sh.
1696
1697         * Scripts/run-jsc-stress-tests:
1698
1699 2014-03-06  Joseph Pecoraro  <pecoraro@apple.com>
1700
1701         filter-build-webkit should not strip .o
1702         https://bugs.webkit.org/show_bug.cgi?id=129614
1703
1704         Reviewed by Dean Jackson.
1705
1706         This makes it much easier to jump from the failing output at
1707         the end back up to the compile errors earlier in the output.
1708
1709         * Scripts/filter-build-webkit:
1710
1711 2014-03-06  Anders Carlsson  <andersca@apple.com>
1712
1713         Build WebKit2 before building WebKit
1714         https://bugs.webkit.org/show_bug.cgi?id=129831
1715         <rdar://problem/15920020>
1716
1717         Reviewed by Dan Bernstein.
1718
1719         * Scripts/build-webkit:
1720         Always build WebKit2 and make sure to build it before WebKit when building on Mac.
1721
1722 2014-03-06  ChangSeok Oh  <changseok.oh@collabora.com>
1723
1724         make-3.82 fails to build on ARM/Linux
1725         https://bugs.webkit.org/show_bug.cgi?id=107926
1726
1727         Reviewed by Martin Robinson.
1728
1729         Some ARM/Linux systems don't support PAGE_SIZE macro so that it causes a build failure.
1730         The related bug reporting is here. https://lists.debian.org/debian-kernel/2014/02/msg00274.html
1731         To avoid this, I propose to use sysconf(_SC_PAGESIZE) instead of PAGE_SIZE
1732         where it is not defined. See more details, http://linux.die.net/man/2/getpagesize
1733
1734         * gtk/patches/make-3.82-arg-list-length.patch:
1735
1736 2014-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1737
1738         [GTK] Close the page when the view is disposed instead of when finalized
1739         https://bugs.webkit.org/show_bug.cgi?id=129783
1740
1741         Reviewed by Sergio Villar Senin.
1742
1743         Add test case but disabled for now because it's affetected by bug #129684.
1744
1745         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
1746         (testProcessPerWebView):
1747
1748 2014-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1749
1750         [GTK] MiniBrowser crashes when opening several urls passed as command line options
1751         https://bugs.webkit.org/show_bug.cgi?id=129738
1752
1753         Reviewed by Sergio Villar Senin.
1754
1755         The problem is that we are calling g_object_unref() for the
1756         WebKitWebSettings everytime we set it to a WebKitWebView, but the
1757         view only increases the reference counter when the settings is not
1758         the same it currently has. We should release our reference once.
1759
1760         * MiniBrowser/gtk/main.c:
1761         (createBrowserWindow):
1762         (main):
1763
1764 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
1765
1766         [GTK][CMake] Tarball is created with wrong tarball paths
1767         https://bugs.webkit.org/show_bug.cgi?id=129496
1768
1769         Reviewed by Daniel Bates.
1770
1771         * gtk/make-dist.py:
1772         (Manifest.__init__): I inadvertently inverted the logic of these checks when
1773         landing the original patch with some suggestions from the reviewer. With the
1774         checks corrected, the tarball path is constructed properly.
1775
1776 2014-03-05  Jae Hyun Park  <jaepark@webkit.org>
1777
1778         Unreviewed. Update my email in contributors.json
1779
1780         * Scripts/webkitpy/common/config/contributors.json:
1781
1782 2014-03-05  Dean Jackson  <dino@apple.com>
1783
1784         [WebGL] Use WKSI to see what the system policy for WebGL is
1785         https://bugs.webkit.org/show_bug.cgi?id=129722
1786         <rdar://problem/15790542>
1787
1788         Reviewed by Tim Horton.
1789
1790         Dummy entry for setSystemWebGLLoadPolicy.
1791
1792         * WebKitTestRunner/TestController.cpp:
1793         (WTR::TestController::createWebViewWithOptions):
1794
1795 2014-03-03  Martin Robinson  <mrobinson@igalia.com>
1796
1797         [GTK][CMake] Generate documentation for the DOM bindings
1798         https://bugs.webkit.org/show_bug.cgi?id=126211
1799
1800         Reviewed by Carlos Garcia Campos.
1801
1802         * gtk/GNUmakefile.am: No longer generation sections and SGML files in the makefile.
1803         * gtk/generate-gtkdoc: Call the code from webkitdom.py to generate sections and SGML files.
1804         * gtk/generate-webkitdom-doc-files: Removed.
1805         * gtk/webkitdom.py: Moved WebKit GObject DOM bindings doc generation code here, so
1806         that it can be called by generate-gtkdoc.
1807
1808 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
1809
1810         [GTK][CMake] build-webkit should rerun cmake if the Makefile is missing
1811         https://bugs.webkit.org/show_bug.cgi?id=129380
1812
1813         Reviewed by Philippe Normand.
1814
1815         * Scripts/webkitdirs.pm:
1816         (generateBuildSystemFromCMakeProject): Check for the existence of the Makefile before
1817         skipping CMake execution.
1818
1819 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
1820
1821         [GTK] The jhbuild environment should have the latest stable release of gtk-doc
1822         https://bugs.webkit.org/show_bug.cgi?id=129651
1823
1824         Reviewed by Philippe Normand.
1825
1826         * gtk/jhbuild.modules: Add gtk-doc to the list of modules.
1827
1828 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
1829
1830         [GTK] Give the WebKit GObject DOM bindings API break detection it's own buildbot bubble
1831         https://bugs.webkit.org/show_bug.cgi?id=129637
1832
1833         Reviewed by Carlos Garcia Campos.
1834
1835         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1836         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests): Added this test runner.
1837         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.commandComplete): Run the breakage test command and scan the output.
1838         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.evaluateCommand): Return failure if there is missing API (an API break).
1839         New API typically just requires a rebaseline and isn't necessarily a faiulre.
1840         (TestFactory.__init__): Add the test for GTK+.
1841         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Add a unit test for the new bubble.
1842
1843 2014-03-05  Krzysztof Czech  <k.czech@samsung.com>
1844
1845         [ATK] Expose missing functionalities of AtkTableCell to AT
1846         https://bugs.webkit.org/show_bug.cgi?id=129492
1847
1848         Reviewed by Mario Sanchez Prada.
1849
1850         Reducing some code by using new API of AtkTableCell.
1851
1852         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1853         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1854
1855 2014-03-04  Alex Christensen  <achristensen@webkit.org>
1856
1857         Preparing to run layout tests on Wincairo.
1858         https://bugs.webkit.org/show_bug.cgi?id=129709
1859
1860         Reviewed by Brent Fulgham.
1861
1862         * Scripts/webkitdirs.pm:
1863         (setPathForRunningWebKitApp):
1864         Add GStreamer directory for WinCairo running layout tests.
1865         * win/DLLLauncher/DLLLauncherMain.cpp:
1866         (modifyPath):
1867         Added the WinCairo bin32 or bin64 directory for running WinLauncher.
1868
1869 2014-03-04  Martin Robinson  <mrobinson@igalia.com>
1870
1871         [GTK] Simplify the GObject DOM bindings API break check into one step
1872         https://bugs.webkit.org/show_bug.cgi?id=129571
1873
1874         Reviewed by Carlos Garcia Campos.
1875
1876         * GNUmakefile.am: Add the API break check to 'make check.'
1877         * gtk/check-for-webkitdom-api-breaks: Added. A combination of the two removed scripts.
1878         * gtk/check-gdom-symbols: Removed.
1879         * gtk/webkitdom.py: Added.
1880         (header_name_list_from_gtkdoc_config_file): Gets the names of all headers from the gtkdoc config file.
1881         (get_all_webkitdom_symbol_files): Find the symbol files from the names.
1882
1883 2014-03-03  Simon Fraser  <simon.fraser@apple.com>
1884
1885         Add Jeremy Jones to the contributors list as a contributor.
1886
1887         * Scripts/webkitpy/common/config/contributors.json:
1888
1889 2014-03-03  Adenilson Cavalcanti  <cavalcantii@gmail.com>
1890
1891         Unreviewed. Update contact email.
1892         https://bugs.webkit.org/show_bug.cgi?id=129610
1893
1894         * Scripts/webkitpy/common/config/contributors.json:
1895
1896 2014-03-02  Brian Burg  <bburg@apple.com>
1897
1898         Web Inspector model tests load wrong inspector page under WebKitTestRunner
1899         https://bugs.webkit.org/show_bug.cgi?id=129460
1900
1901         Reviewed by Dan Bernstein.
1902
1903         Don't unconditionally open the inspector before running an inspector test.
1904         Instead, the test should request that the inspector open when it's ready.
1905
1906         This change was lost during a rebase, but is the same change made to
1907         DumpRenderTree.
1908
1909         * WebKitTestRunner/TestInvocation.cpp:
1910         (WTR::TestInvocation::invoke): 
1911
1912 2014-03-02  Darin Adler  <darin@apple.com>
1913
1914         Split TextIteratorBehavior into a separate header
1915         https://bugs.webkit.org/show_bug.cgi?id=129578
1916
1917         Reviewed by Sam Weinig.
1918
1919         * Scripts/sort-export-file: Added special cases to the script so you can just paste link errors
1920         from WebKit in and the script will add them in as unconditional exports. This makes the "add"
1921         task easy, but the remove is still a bit of a pain.
1922
1923 2014-03-02  Darin Adler  <darin@apple.com>
1924
1925         Sort Mac platform export files so they merge better
1926         https://bugs.webkit.org/show_bug.cgi?id=129581
1927
1928         Reviewed by Sam Weinig.
1929
1930         * Scripts/sort-export-file: Added. Quickly whipped together script that sorts
1931         Mac export files in a "canonical" order for this project.
1932
1933 2014-02-28  Zalan Bujtas  <zalan@apple.com>
1934
1935         Add hiDPI support to DumpRenderTree/WebKitTestRunner without the need of reloading the test case.
1936         https://bugs.webkit.org/show_bug.cgi?id=129438
1937
1938         Reviewed by Simon Fraser.
1939
1940         'hidpi-' prefixed test cases now trigger 2x scale factor on the testing
1941         offscreen window. It makes testing subpixel rendering and positioning possible.
1942
1943         Both the offscreen window's and WebKit's scaling are set accordingly.
1944
1945         * DumpRenderTree/mac/DumpRenderTree.mm:
1946         (createWebViewAndOffscreenWindow): cleanup
1947         (destroyWebViewAndOffscreenWindow): cleanup
1948         (dumpRenderTree):
1949         (changeWindowScaleIfNeeded):
1950         (runTest):
1951         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1952         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1953         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]): cleanup
1954         * WebKitTestRunner/PlatformWebView.h:
1955         * WebKitTestRunner/TestInvocation.cpp:
1956         (WTR::changeWindowScaleIfNeeded):
1957         (WTR::TestInvocation::invoke):
1958         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1959         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1960         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1961         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1962         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1963         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1964         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1965         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1966
1967 2014-02-28  Anders Carlsson  <andersca@apple.com>
1968
1969         Remove logging.
1970
1971         Reviewed by Dan Bernstein.
1972
1973         * MiniBrowser/mac/WK2BrowserWindowController.m:
1974         (-[WK2BrowserWindowController browsingContextController:decidePolicyForNavigationAction:decisionHandler:]):
1975
1976 2014-02-28  Daniel Bates  <dabates@apple.com>
1977
1978         [iOS] DumpRenderTree Perl Support may build against wrong SDK and toolchain
1979         https://bugs.webkit.org/show_bug.cgi?id=129163
1980
1981         Reviewed by David Kilzer.
1982
1983         Fixes an issue where DumpRenderTree Perl Support may build with the specified
1984         iOS Simulator SDK and toolchain instead of using the OS X SDK and toolchain.
1985         This issue manifests itself in a build failure when building the IPhoneSimulatorNotification
1986         bundle.
1987
1988         Currently we build DumpRenderTree Perl Support with respect to the variable SDKROOT,
1989         which is specified either explicitly when building with MAKE(1) or implicitly by
1990         build-{dumprendertree, webkit}. Instead we should always build Perl Support using
1991         the OS X SDK and toolchain since the built products are only applicable to OS X.
1992
1993         * DumpRenderTree/ios/PerlSupport/Makefile:
1994
1995 2014-02-28  Commit Queue  <commit-queue@webkit.org>
1996
1997         Unreviewed, rolling out r164859.
1998         http://trac.webkit.org/changeset/164859
1999         https://bugs.webkit.org/show_bug.cgi?id=129483
2000
2001         caused WK1 crashes (DumpRenderTree) (Requested by zalan on
2002         #webkit).
2003
2004         * DumpRenderTree/mac/DumpRenderTree.mm:
2005         (createWebViewAndOffscreenWindow):
2006         (dumpRenderTree):
2007         (runTest):
2008         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2009         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2010         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
2011         * WebKitTestRunner/PlatformWebView.h:
2012         * WebKitTestRunner/TestInvocation.cpp:
2013         (WTR::TestInvocation::invoke):
2014         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2015         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2016         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2017         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2018         (-[WebKitTestRunnerWindow frameRespectingFakeOrigin]):
2019
2020 2014-02-28  Zalan Bujtas  <zalan@apple.com>
2021
2022         Add hiDPI support to DumpRenderTree/WebKitTestRunner without the need of reloading the test case.
2023         https://bugs.webkit.org/show_bug.cgi?id=129438
2024
2025         Reviewed by Simon Fraser.
2026
2027         'hidpi-' prefixed test cases now trigger 2x scale factor on the testing
2028         offscreen window. It makes testing subpixel rendering and positioning possible.
2029
2030         Both the offscreen window's and WebKit's scaling are set accordingly.
2031
2032         * DumpRenderTree/mac/DumpRenderTree.mm:
2033         (createWebViewAndOffscreenWindow): unrelated cleanup.
2034         (destroyWebViewAndOffscreenWindow): unrelated cleanup.
2035         (dumpRenderTree):
2036         (changeOffscreenWindowScaleIfNeeded):
2037         (runTest):
2038         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2039         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2040         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]): cleanup.
2041         * WebKitTestRunner/PlatformWebView.h:
2042         * WebKitTestRunner/TestInvocation.cpp:
2043         (WTR::changeOffscreenWindowScaleIfNeeded):
2044         (WTR::TestInvocation::invoke):
2045         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2046         (WTR::PlatformWebView::changeOffscreenWindowScaleIfNeeded):
2047
2048 2014-02-27  Brian Burg  <bburg@apple.com>
2049
2050         Web Inspector: model tests should use a special Test.html inspector page
2051         https://bugs.webkit.org/show_bug.cgi?id=129190
2052
2053         Reviewed by Timothy Hatcher.
2054
2055         Remove code that immediately opens the Web Inspector based on the file path of the test.
2056         Instead, the test page should request that the inspector open inside its `test()` method.
2057
2058         This change is necessary because otherwise, the inspector would be opened too early for
2059         InspectorController::isUnderTest to get set in time, so the normal Web Inspector page
2060         will get loaded instead of the minimal test page.
2061
2062         * DumpRenderTree/efl/DumpRenderTree.cpp:
2063         (createTestRunner):
2064         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2065         (runTest):
2066         * DumpRenderTree/mac/DumpRenderTree.mm:
2067         (runTest):
2068         * DumpRenderTree/win/DumpRenderTree.cpp:
2069         (runTest):
2070
2071 2014-02-27  Laszlo Vidacs  <lvidacs.u-szeged@partner.samsung.com>
2072
2073         check-webkit-style indentation false alarm in WebKit/win/WebNodeHighlight.cpp
2074         https://bugs.webkit.org/show_bug.cgi?id=127076
2075
2076         Reviewed by Anders Carlsson.
2077
2078         Avoid match for :: as start of a member initialization list. Modify expression to match
2079         after a colon either non-colon character or end of line.
2080
2081         * Scripts/webkitpy/style/checkers/cpp.py:
2082         (check_member_initialization_list):
2083         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2084         (WebKitStyleTest.test_member_initialization_list):
2085
2086 2014-02-27  Renata Hodovan  <rhodovan.u-szeged@partner.samsung.com>
2087
2088         Unreviewed. Update my email addresses in contributors.json.
2089
2090         * Scripts/webkitpy/common/config/contributors.json:
2091
2092 2014-02-27  Alberto Garcia  <berto@igalia.com>
2093
2094         [gtk-doc] UnicodeEncodeError: 'ascii' codec can't encode character
2095         https://bugs.webkit.org/show_bug.cgi?id=128927
2096
2097         Reviewed by Philippe Normand.
2098
2099         Encode manually the data for sys.{stdout,stderr}.write.
2100
2101         * gtk/gtkdoc.py:
2102         (GTKDoc._run_command):
2103
2104 2014-02-27  Andres Gomez  <agomez@igalia.com>
2105
2106         Unreviewed. Add myself to watchlists
2107
2108         * Scripts/webkitpy/common/config/watchlist: Add myself to
2109         watchlists.
2110
2111 2014-02-27  Andres Gomez  <agomez@igalia.com>
2112
2113         Unreviewed, rolling out r164790.
2114         http://trac.webkit.org/changeset/164790
2115
2116         Revert r164790 because of erroneous commit log
2117
2118         * Scripts/webkitpy/common/config/watchlist:
2119
2120 2014-02-27  Krzysztof Czech  <k.czech@samsung.com>
2121
2122         [ATK] Utilize AtkTableCell to expose directly AccessibilityTableCell to AT
2123         https://bugs.webkit.org/show_bug.cgi?id=129250
2124
2125         Reviewed by Mario Sanchez Prada.
2126
2127         Changing version of ATK to 2.11.90, because it introduces AtkTableCell interface.
2128         Implementing methods so that we could test column/row headers represented as an array of cells.
2129
2130         * DumpRenderTree/AccessibilityUIElement.cpp:
2131         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2132         (AccessibilityUIElement::columnHeaders):
2133         (AccessibilityUIElement::rowHeaders):
2134         * DumpRenderTree/win/AccessibilityUIElementWin.cpp: Adding empty stubs, to not break compilation.
2135         (AccessibilityUIElement::columnHeaders):
2136         (AccessibilityUIElement::rowHeaders):
2137         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2138         (WTR::AccessibilityUIElement::rowHeaders):
2139         (WTR::AccessibilityUIElement::columnHeaders):
2140         * efl/jhbuild.modules:
2141         * gtk/jhbuild.modules:
2142
2143 2014-02-27  Andres Gomez  <agomez@igalia.com>
2144
2145         Unreviewed. Add myself to watchlists
2146
2147         * Scripts/webkitpy/common/config/watchlist: Add myself to
2148         watchlists.
2149
2150 2014-02-27  Andres Gomez  <agomez@igalia.com>
2151
2152         Unreviewed. Add myself as a committer.
2153
2154         * Scripts/webkitpy/common/config/contributors.json:
2155
2156 2014-02-27  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2157
2158         Unreviewed. Add Víctor Jáquez and myself to watchlists
2159
2160         * Scripts/webkitpy/common/config/watchlist: Add Víctor Jáquez and
2161         myself to watchlists.
2162
2163 2014-02-26  Julien Brianceau  <jbriance@cisco.com>
2164
2165         Unreviewed. Add myself as a committer.
2166
2167         * Scripts/webkitpy/common/config/contributors.json:
2168
2169 2014-02-26  Laszlo Vidacs  <lvidacs.u-szeged@partner.samsung.com>
2170
2171         Unreviewed. Moved myself to the list of committers.
2172
2173         * Scripts/webkitpy/common/config/contributors.json:
2174
2175 2014-02-24  Martin Robinson  <mrobinson@igalia.com>
2176
2177         [GTK] Reduplicate common.top_level_path in scripts
2178         https://bugs.webkit.org/show_bug.cgi?id=129291
2179
2180         Reviewed by Philippe Normand.
2181
2182         Duplicate common.top_level_path and avoid polluting many scripts with awkward system
2183         path manipulation and weird dependencies on the jhbuild infrastructure.
2184
2185         * Scripts/run-gtk-tests: Use common again.
2186         (TestRunner._setup_testing_environment): Ditto.
2187         * gtk/check-gdom-symbols: Ditto.
2188         * gtk/common.py:
2189         (top_level_path): Re-add top_level_path..
2190         (get_build_path): Use the builtin top_level_path again.
2191         * gtk/find-make-dist-errors: Use common again.
2192         (get_missing_headers): Ditto.
2193         * gtk/generate-inspector-gresource-manifest.py: Ditto.
2194
2195 2014-02-26  Mark Hahnenberg  <mhahnenberg@apple.com>
2196
2197         runscript: line 42: /bin/ls: Argument list too long
2198         https://bugs.webkit.org/show_bug.cgi?id=129376
2199
2200         Reviewed by Michael Saboff.
2201
2202         The "test_script_*" can expand to more things than can be passed as arguments on the command line. 
2203         We should use find instead, which generates the list of files rather than expanding them all on 
2204         the command line and spitting them back out.
2205
2206         * Scripts/jsc-stress-test-helpers/shell-runner.sh: 
2207
2208 2014-02-26  Martin Robinson  <mrobinson@igalia.com>
2209
2210         ENABLE_PROMISES is improperly specified as ENABLE_PROMISE in Features.pm
2211         https://bugs.webkit.org/show_bug.cgi?id=129377
2212
2213         Reviewed by Csaba Osztrogonác.
2214
2215         * Scripts/webkitperl/FeatureList.pm: Properly specify the promises feature as ENABLE_PROMISES.
2216
2217 2014-02-26  Manuel Rego Casasnovas  <rego@igalia.com>
2218
2219         [GTK] Re-enable gtk-doc in EWS
2220         https://bugs.webkit.org/show_bug.cgi?id=128369
2221
2222         Reviewed by Carlos Garcia Campos.
2223
2224         Enable again gtk-doc generation in EWS once bug #128417 has been fixed.
2225
2226         * Scripts/webkitpy/common/config/ports.py:
2227         (GtkPort.build_webkit_command): Add --disable-gtk-doc arg.
2228         (GtkWK2Port.build_webkit_command): Ditto.
2229         * Scripts/webkitpy/common/config/ports_unittest.py:
2230         (DeprecatedPortTest.test_gtk_port): Ditto.
2231         (DeprecatedPortTest.test_gtk_wk2_port): Ditto.
2232
2233 2014-02-26  Martin Robinson  <mrobinson@igalia.com>
2234
2235         [GTK] generate-gtkdoc can fail with WebKit1 or WebKit2 only builds
2236         https://bugs.webkit.org/show_bug.cgi?id=129319
2237
2238         Reviewed by Carlos Garcia Campos.
2239
2240         * gtk/generate-gtkdoc:
2241         (get_generator_for_config): Properly handle the situation where the pkgconfig file is missing.
2242
2243 2014-02-25  Mihai Maerean  <mmaerean@adobe.com>
2244
2245         Unreviewed. Add myself as a committer.
2246
2247         * Scripts/webkitpy/common/config/contributors.json:
2248
2249 2014-02-25  Sergio Villar Senin  <svillar@igalia.com>
2250
2251         [CSS Grid Layout] Add ENABLE flag
2252         https://bugs.webkit.org/show_bug.cgi?id=129153
2253
2254         Reviewed by Simon Fraser.
2255
2256         Added ENABLE_CSS_GRID_LAYOUT feature flag. It's on by default for
2257         all ports for developer builds.
2258
2259         * Scripts/webkitperl/FeatureList.pm:
2260
2261 2014-02-25  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
2262
2263         Added myself as a committer.
2264
2265         Unreviewed.
2266
2267         * Scripts/webkitpy/common/config/contributors.json:
2268
2269 2014-02-25  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
2270
2271         Unreviewed. Moved myself to the list of committers.
2272
2273         * Scripts/webkitpy/common/config/contributors.json:
2274
2275 2014-02-25  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
2276
2277         Move myself to the committers list.
2278
2279         Unreviewed.
2280
2281         * Scripts/webkitpy/common/config/contributors.json:
2282
2283 2014-02-25  László Langó  <llango.u-szeged@partner.samsung.com>
2284
2285         Unreviewed. Add myself as a committer.
2286
2287         * Scripts/webkitpy/common/config/contributors.json:
2288
2289 2014-02-25  Commit Queue  <commit-queue@webkit.org>
2290
2291         Unreviewed, rolling out r164639.
2292         http://trac.webkit.org/changeset/164639
2293         https://bugs.webkit.org/show_bug.cgi?id=129302
2294
2295         gtk-doc still have problems in EWS (Requested by rego on
2296         #webkit).
2297
2298         * Scripts/webkitpy/common/config/ports.py:
2299         (GtkPort.build_webkit_command):
2300         (GtkWK2Port.build_webkit_command):
2301         * Scripts/webkitpy/common/config/ports_unittest.py:
2302         (DeprecatedPortTest.test_gtk_port):
2303         (DeprecatedPortTest.test_gtk_wk2_port):
2304
2305 2014-02-25  Manuel Rego Casasnovas  <rego@igalia.com>
2306
2307         [GTK] Re-enable gtk-doc in EWS
2308         https://bugs.webkit.org/show_bug.cgi?id=128369
2309
2310         Reviewed by Carlos Garcia Campos.
2311
2312         Enable again gtk-doc generation in EWS once bug #128417 has been fixed.
2313
2314         * Scripts/webkitpy/common/config/ports.py:
2315         (GtkPort.build_webkit_command): Add --disable-gtk-doc arg.
2316         (GtkWK2Port.build_webkit_command): Ditto.
2317         * Scripts/webkitpy/common/config/ports_unittest.py:
2318         (DeprecatedPortTest.test_gtk_port): Ditto.
2319         (DeprecatedPortTest.test_gtk_wk2_port): Ditto.
2320
2321 2014-02-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2322
2323         [GTK] Mark view source mode methods as deprecated
2324         https://bugs.webkit.org/show_bug.cgi?id=128920
2325
2326         Reviewed by Martin Robinson.
2327
2328         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2329         (beforeAll): Remove view mode test.
2330
2331 2014-02-24  Martin Robinson  <mrobinson@igalia.com>
2332
2333         [GTK] generate-gtkdoc should not generate documentation for source files for unbuilt source files
2334         https://bugs.webkit.org/show_bug.cgi?id=128417
2335
2336         Reviewed by Carlos Garcia Campos.
2337
2338         * gtk/GNUmakefile.am: Make the documentation process depend on the configuration files.
2339         * gtk/generate-gtkdoc: Switch from using hard-coded configurations to reading them from
2340         a makefile. This allows accepting a header list from the build system, which can be used
2341         to dynamically build a list of ignored files. We can ignore any source file that doesn't
2342         have a corresponding header file on the header list. 
2343         * gtk/gtkdoc.py: Now accept a headers parameter, which can be used instead of passing just
2344         source directories to gtkdoc-scan.
2345
2346 2014-02-24  Anders Carlsson  <andersca@apple.com>
2347
2348         Add a DefaultVisitedLinkProvider and route visited link actions through it
2349         https://bugs.webkit.org/show_bug.cgi?id=129285
2350
2351         Reviewed by Dan Bernstein.
2352
2353         * MiniBrowser/mac/AppDelegate.m:
2354         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
2355         Set a shared history so we'll get visited link tracking.
2356
2357         * MiniBrowser/mac/WK1BrowserWindowController.m:
2358         (-[WK1BrowserWindowController awakeFromNib]):
2359         Set a group name.
2360
2361 2014-02-24  Dan Bernstein  <mitz@apple.com>
2362
2363         iOS build fix after r164577.
2364
2365         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2366         (AccessibilityUIElement::selectedChildrenCount):
2367         (AccessibilityUIElement::selectedChildAtIndex):
2368
2369 2014-02-24  David Kilzer  <ddkilzer@apple.com>
2370
2371         [ASan] Remove methods from ignore list that no longer cause crashes
2372         <http://webkit.org/b/129257>
2373
2374         Reviewed by Anders Carlsson.
2375
2376         * asan/webkit-asan-ignore.txt: Remove old methods.
2377
2378 2014-02-24  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2379
2380         Extract common parts from jhbuildrc files.
2381         https://bugs.webkit.org/show_bug.cgi?id=125986
2382
2383         Reviewed by Csaba Osztrogonác.
2384
2385         Co-authored with Peter Szanka <h868064@stud.u-szeged.hu>.
2386
2387         * Scripts/run-gtk-tests:
2388         (TestRunner._setup_testing_environment):
2389         * efl/common.py: Removed.
2390         * efl/jhbuildrc:
2391         * gtk/check-gdom-symbols:
2392         * gtk/common.py:
2393         (binary_build_path):
2394         (get_build_path):
2395         * gtk/find-make-dist-errors:
2396         (get_missing_headers):
2397         * gtk/generate-gtkdoc:
2398         (get_webkit2_options):
2399         (get_webkit1_options.src_path):
2400         (get_webkit1_options):
2401         (get_webkitdom_options.src_path):
2402         (get_webkitdom_options):
2403         * gtk/generate-inspector-gresource-manifest.py:
2404         * gtk/jhbuildrc:
2405         * jhbuild/jhbuildrc_common.py: Added.
2406         (script_path):
2407         (top_level_path):
2408         (init):
2409
2410 2014-02-24  Diego Pino Garcia  <dpino@igalia.com>
2411
2412         Unreviewed. Fix code indentation and spacing.
2413
2414         * Scripts/webkitpy/style/checkers/js.py:
2415         (SingleQuoteChecker.check):
2416
2417 2014-02-24  Krzysztof Czech  <k.czech@samsung.com>
2418
2419         [ATK] Wrong selected element at a given index in a list box.
2420         https://bugs.webkit.org/show_bug.cgi?id=129039
2421
2422         Reviewed by Chris Fleizach.
2423
2424         Added missing implementation and proposed some new function for testing selection
2425         in a list boxes.
2426
2427         * DumpRenderTree/AccessibilityUIElement.cpp:
2428         (setSelectedChildAtIndexCallback):
2429         (removeSelectionAtIndexCallback):
2430         (AccessibilityUIElement::getJSClass):
2431         * DumpRenderTree/AccessibilityUIElement.h:
2432         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2433         (AccessibilityUIElement::selectedChildrenCount):
2434         (AccessibilityUIElement::selectedChildAtIndex):
2435         (AccessibilityUIElement::setSelectedChildAtIndex):
2436         (AccessibilityUIElement::removeSelectionAtIndex):
2437         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2438         (AccessibilityUIElement::selectedChildrenCount):
2439         (AccessibilityUIElement::selectedChildAtIndex):
2440         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2441         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
2442         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
2443         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2444         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2445         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2446         (WTR::AccessibilityUIElement::selectedChildAtIndex):
2447         (WTR::AccessibilityUIElement::selectedChildrenCount):
2448         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
2449         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
2450
2451 2014-02-23  Diego Pino García  <dpino@igalia.com>
2452
2453         [GTK] Fix build after Web Inspector code reorganization (r164543)
2454         https://bugs.webkit.org/show_bug.cgi?id=129231
2455
2456         Reviewed by Dean Jackson.
2457
2458         * gtk/generate-inspector-gresource-manifest.py:
2459         Modify paths to Web Inspector code.
2460
2461 2014-02-23  Martin Robinson  <mrobinson@igalia.com>
2462
2463         [GTK] generate-gtkdoc should use argparse
2464         https://bugs.webkit.org/show_bug.cgi?id=128418
2465
2466         Reviewed by Carlos Garcia Campos.
2467
2468         * gtk/generate-gtkdoc: Get all arguments from argparse, pass then as parameters
2469         to all functions, and guard the main routine with a __name__ == __main__ check.
2470
2471 2014-02-23  Martin Robinson  <mrobinson@igalia.com>
2472
2473         [GTK][CMake] Many plugin tests fail when running WebKit1 layout tests
2474         https://bugs.webkit.org/show_bug.cgi?id=129191
2475
2476         Reviewed by Anders Carlsson.
2477
2478         * DumpRenderTree/PlatformGTK.cmake: Properly specify the library build directory
2479         for the GTK+ DumpRenderTree build. We could manually construct this path, but the
2480         name of the directory is "lib" and not "libs". Instead we should use the CMake
2481         variable specifically assigned to this task.
2482
2483 2014-02-23  David Kilzer  <ddkilzer@apple.com>
2484
2485         [ASan] Add JSC::DFG::prepareOSREntry() to ignore list
2486         <http://webkit.org/b/129209>
2487
2488         Reviewed by Geoffrey Garen.
2489
2490         * asan/webkit-asan-ignore.txt: Add DFG::prepareOSREntry() to the
2491         ignore list to make ASan builds usable again.  Follow-up
2492         investigation is tracked by <rdar://problem/16055903>.
2493
2494 2014-02-20  David Farler  <dfarler@apple.com>
2495
2496         Make old-run-webkit-tests work with iOS Simulator WebKitTestRunner
2497         https://bugs.webkit.org/show_bug.cgi?id=128622
2498
2499         Reviewed by Simon Fraser.
2500
2501         With this change, we now have layout tests running in both DumpRenderTree
2502         and WebKitTestRunner, with WebKit and WebKit2 used respectively in the iOS
2503         simulator.
2504
2505         * Scripts/old-run-webkit-tests:
2506         In general, make any specific reference to DumpRenderTree
2507         able to refer to WebKitTestRunner wherever possible:
2508         - Rename functions to remove DRT-specific naming.
2509         - Name FIFOs after the tool that is being used.
2510         -- Clean up FIFO creation code
2511         Other necessary changes:
2512         - Allow use of an ios-sim-wk2 platform.
2513         - Clean up platform hierarchy creation where the simulator platform behavior differed.
2514         * WebKitTestRunner/TestController.cpp:
2515         Open FIFOs to get dumps out of the simulator as we do in DumpRenderTree.
2516         (WTR::TestController::TestController):
2517         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2518         Copy the injected bundle into the app bundle.
2519
2520 2014-02-21  Joseph Pecoraro  <pecoraro@apple.com>
2521
2522         run-webkit-httpd fails to find httpd configuation file.
2523
2524         Reviewed by Ryosuke Niwa.
2525
2526         * Scripts/webkitperl/httpd.pm:
2527         (getHTTPDConfigPathForTestDirectory):
2528
2529 2014-02-21  Eric Carlson  <eric.carlson@apple.com>
2530
2531         Fix TimeRanges layering violations
2532         https://bugs.webkit.org/show_bug.cgi?id=128717
2533
2534         Reviewed by Jer Noble.
2535
2536         * TestWebKitAPI/Tests/WebCore/TimeRanges.cpp: TimeRanges* -> TimeRanges&.
2537         (TestWebKitAPI::TEST):
2538
2539 2014-02-21  Diego Pino García  <dpino@igalia.com>
2540
2541         Web Inspector: update check-webkit-style to flag single quotes in WebInspectorUI projects
2542         https://bugs.webkit.org/show_bug.cgi?id=128422
2543
2544         Reviewed by Joseph Pecoraro.
2545
2546         * Scripts/webkitpy/style/checkers/js.py:
2547         (JSChecker.__init__):
2548         (JSChecker.check):
2549         (SingleQuoteChecker):
2550         (SingleQuoteChecker.__init__):
2551         (SingleQuoteChecker.check):
2552         * Scripts/webkitpy/style/checkers/js_unittest.py:
2553         (JSTestCase.assertError.error_for_test):
2554         (JSTestCase.assertError):
2555         (JSTestCase.test_no_error):
2556         (JSTestCase.test_error):
2557
2558 == Rolled over to ChangeLog-2014-02-20 ==