2011-01-04 Jochen Eisinger <jochen@chromium.org>
[WebKit-https.git] / Tools / ChangeLog
1 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
2
3         Reviewed by David Levin.
4
5         Store the tempdir object in a variable so it doesn't get deleted too early.
6         https://bugs.webkit.org/show_bug.cgi?id=51875
7
8         * Scripts/update-webkit-auxiliary-libs:
9         * Scripts/update-webkit-support-libs:
10
11 2011-01-14  Eric Seidel  <eric@webkit.org>
12
13         Unreviewed.  Make it work in python 2.5.
14
15         webkit-patch suggest-reviewers dies when ChangeLogs are missing
16         https://bugs.webkit.org/show_bug.cgi?id=49158
17
18         * Scripts/webkitpy/common/checkout/api_unittest.py:
19
20 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
21
22         Unreviewed, rolling out r75774.
23         http://trac.webkit.org/changeset/75774
24         https://bugs.webkit.org/show_bug.cgi?id=52431
25
26         gtk builds were broken (Requested by loislo2 on #webkit).
27
28         * Scripts/webkitpy/common/checkout/scm.py:
29
30 2011-01-14  David Levin  <levin@chromium.org>
31
32         Reviewed by Shinichiro Hamaji.
33
34         check-webkit-style: _FunctionState should detect pure functions.
35         https://bugs.webkit.org/show_bug.cgi?id=52428
36
37         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
38         is a pure virtual function.
39         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
40         virtual functions are correctly detected.
41
42 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
43
44         Reviewed by Yury Semikhatsky.
45
46         Just small fix for problem with check-webkit-style.
47         It just didn't work for this patch.
48         Old code can't concatenate a list of strings with None.
49
50         * Scripts/webkitpy/common/checkout/scm.py:
51
52 2011-01-13  David Levin  <levin@chromium.org>
53
54         Reviewed by Shinichiro Hamaji.
55
56         check-webkit-style: _FunctionState should use Position to know where items are.
57         https://bugs.webkit.org/show_bug.cgi?id=52424
58
59         * Scripts/webkitpy/style/checkers/cpp.py:
60         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
61         (detect_functions): Changed to pass Position's to _FunctionState.begin and
62         did some minor clean-up.
63         (*): Other changes are simply about converting to use the Position's in_FunctionState
64         instead of line numbers.
65         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
66         to verify the positions stored in _FunctionState.
67
68 2011-01-13  Eric Seidel  <eric@webkit.org>
69
70         Reviewed by David Levin.
71
72         webkit-patch suggest-reviewers dies when ChangeLogs are missing
73         https://bugs.webkit.org/show_bug.cgi?id=49158
74
75         This is not the most elegant, but it is a very safe fix to this bug.
76         One advantage of catching ScriptError like this instead of adding a
77         new added_or_modified_files or fixing all changed_files callers
78         to use a more specific change_files variant, is that we catch
79         all kinds of ScriptErrors which might cause our (non-essential)
80         suggest-reviewers code to fail out.  This should make passing
81         --suggest-reviewers to webkit-patch upload much more robust
82         and may even make it possible for us to make it default.
83
84         The root of the problem here is that SCM.changed_files includes
85         deleted ChangeLog paths (from moves, etc) which then when we ask
86         SVN/Git for the contents of the file at that revision, the command
87         errors out and Executive.run_command raises a ScriptError.
88
89         In the future we might fix this differently by making all current
90         callers of chagned_files use a more specific method for requesting
91         what types of changes they're interested in (adds, modifies, deletes, etc.)
92
93         * Scripts/webkitpy/common/checkout/api.py:
94         * Scripts/webkitpy/common/checkout/api_unittest.py:
95
96 2011-01-13  Dan Bernstein  <mitz@apple.com>
97
98         Reviewed by Alexey Proskuryakov.
99
100         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
101         https://bugs.webkit.org/show_bug.cgi?id=52419
102
103         Allow to further control the behavior of the willSendRequest delegate callback by making it
104         set a different URL in the new request.
105
106         * DumpRenderTree/LayoutTestController.cpp:
107         (addURLToRedirectCallback): Added.
108         (LayoutTestController::staticFunctions): Added addURLToRedirect.
109         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
110         (LayoutTestController::redirectionDestinationForURL): Added this getter.
111         * DumpRenderTree/LayoutTestController.h:
112         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
113         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
114         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
115         change the URL in the new request to the redirect destination.
116
117 2011-01-13  Eric Seidel  <eric@webkit.org>
118
119         Reviewed by Mihai Parparita.
120
121         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
122         https://bugs.webkit.org/show_bug.cgi?id=52416
123
124         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
125         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
126
127         I also added FIXMEs about the changed_files returning deleted files problem
128         which is causing the other most common exception for suggest-reviewers
129         (and is probably breaking sheriff-bots blame detection).
130
131         * Scripts/webkitpy/common/checkout/api.py:
132         * Scripts/webkitpy/common/checkout/api_unittest.py:
133         * Scripts/webkitpy/common/checkout/scm.py:
134
135 2011-01-13  Eric Seidel  <eric@webkit.org>
136
137         Reviewed by Adam Barth.
138
139         results archives from commit-queue are too large to upload
140         https://bugs.webkit.org/show_bug.cgi?id=52405
141
142         * Scripts/webkitpy/common/system/filesystem.py:
143         * Scripts/webkitpy/common/system/filesystem_mock.py:
144         * Scripts/webkitpy/tool/commands/queues.py:
145
146 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
147
148         Reviewed by Martin Robinson.
149
150         [gtk] Zero-sized font does not yet work
151         https://bugs.webkit.org/show_bug.cgi?id=49793
152
153         Set minimum-font-size to 0 for the DRT.
154
155         * DumpRenderTree/gtk/DumpRenderTree.cpp:
156         (resetDefaultsToConsistentValues):
157
158 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
159
160         Reviewed by Darin Adler.
161
162         Make old-run-webkit-tests more robust on buildbots
163         https://bugs.webkit.org/show_bug.cgi?id=52364
164
165         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
166
167 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
168
169         Reviewed by Darin Adler.
170
171         Make old-run-webkit-tests more robust on buildbots
172         https://bugs.webkit.org/show_bug.cgi?id=52364
173
174         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
175
176 2011-01-13  Tony Chang  <tony@chromium.org>
177
178         Reviewed by Kent Tamura.
179
180         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
181         https://bugs.webkit.org/show_bug.cgi?id=52332
182
183         Forked Info.plist is not longer needed.
184
185         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
186
187 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
188
189         Reviewed by Timothy Hatcher.
190
191         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
192         to be passed directly to WebInspector.UIString
193
194         https://bugs.webkit.org/show_bug.cgi?id=52365
195
196         * Scripts/check-inspector-strings:
197
198 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
199
200         Unreviewed, rolling out r74881.
201         http://trac.webkit.org/changeset/74881
202         https://bugs.webkit.org/show_bug.cgi?id=52357
203
204         The EFL builder has been red for days (Requested by abarth on
205         #webkit).
206
207         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
208         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
209
210 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
211
212         Reviewed by David Levin.
213
214         Add beforeunload support to WebKitTestRunner
215         https://bugs.webkit.org/show_bug.cgi?id=52353
216         
217         This makes a number of currently failing tests pass.
218
219         * WebKitTestRunner/TestController.cpp:
220         (WTR::runBeforeUnloadConfirmPanel):
221         (WTR::createOtherPage):
222         (WTR::TestController::initialize):
223
224 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
225
226         Reviewed by Sam Weinig.
227
228         Detect, identify and recover from WebProcess crashes in run-webkit-tests
229         https://bugs.webkit.org/show_bug.cgi?id=52330
230
231         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
232         a web process crash.
233         * WebKitTestRunner/TestController.cpp:
234         (WTR::TestController::initialize): Set up a processDidCrash
235         callback.
236         (WTR::TestController::processDidCrash): Report that the Web process
237         crashed.
238         * WebKitTestRunner/TestController.h:
239
240 2011-01-12  David Levin  <levin@chromium.org>
241
242         Reviewed by Shinichiro Hamaji.
243
244         check-webkit-style -- close_expression function doesn't work correctly.
245         https://bugs.webkit.org/show_bug.cgi?id=52272
246
247         * Scripts/webkitpy/style/checkers/cpp.py:
248         (Position.__str__): Added a way to convert it to a string which is useful in tests.
249         (Position.__cmp__): Added a way to compare Position which is useful in tests and
250         generally useful (for upcoming code changes).
251         (close_expression): Changed to use Position for input and output.
252         Also, fixed many bugs such as only working correctly for parenthesis,
253         not working correctly if given an offset in a line and not finding
254         the real closing element if there were multiple closing elements in
255         the same line.
256         (detect_functions): Adjusted due to the change in arguments for
257         close_expression.
258         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
259         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
260         two positions are the same.
261         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
262         (CppStyleTest.test_close_expression): Added tests to catch the issues
263         that were fixed.
264
265 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
266
267         Unreviewed, rolling out r75576.
268         http://trac.webkit.org/changeset/75576
269         https://bugs.webkit.org/show_bug.cgi?id=52304
270
271         broke rebaseline-chromium-webkit-test (Requested by thakis on
272         #webkit).
273
274         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
275         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
276         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
277         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
278         * Scripts/webkitpy/layout_tests/port/base.py:
279         * Scripts/webkitpy/layout_tests/port/chromium.py:
280         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
281         * Scripts/webkitpy/layout_tests/port/test.py:
282         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
283         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
284         * Scripts/webkitpy/style/checkers/test_expectations.py:
285         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
286
287 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
288
289         Reviewed by Darin Adler.
290
291         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
292         https://bugs.webkit.org/show_bug.cgi?id=52307
293
294         * Scripts/old-run-webkit-tests:
295
296 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
297
298         Reviewed by Martin Robinson.
299
300         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
301         https://bugs.webkit.org/show_bug.cgi?id=50867
302
303         Fixed library extention for Mac in webkitdirs.pm and type conflict in
304         TestNetscapePlugin.cpp 
305
306         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
307         * Scripts/webkitdirs.pm:
308
309 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
310
311         Reviewed by Pavel Feldman.
312
313         Add check-inspector-strings script.
314
315         https://bugs.webkit.org/show_bug.cgi?id=52295
316
317         * Scripts/check-inspector-strings: Added.
318
319 2011-01-12  Adam Roben  <aroben@apple.com>
320
321         Advertise the .testnetscape file extension on Windows
322
323         Fixes <http://webkit.org/b/52298>
324         plugins/no-mime-with-valid-extension.html fails on Windows
325
326         Reviewed by Dan Bernstein.
327
328         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
329         FileExtents field to map the .testnetscape file extension to the
330         application/x-webkit-test-netscape MIME type, just as we do on Mac.
331
332 2011-01-12  Adam Barth  <abarth@webkit.org>
333
334         Reviewed by Eric Seidel.
335
336         Make webkit-patch support subdirectories for SVN checkouts
337         https://bugs.webkit.org/show_bug.cgi?id=52261
338
339         os.relpath does not exist on Python 2.5, so we need to call our version
340         of the API.
341
342         * Scripts/webkitpy/common/checkout/scm.py:
343
344 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
345
346         Reviewed by Eric Seidel.
347
348         Close additional pages opened during a test once the test completes.
349         https://bugs.webkit.org/show_bug.cgi?id=52276
350
351         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
352         (WTR::InjectedBundle::done):
353
354 2011-01-11  David Levin  <levin@chromium.org>
355
356         Reviewed by Eric Seidel.
357
358         Errors should be separated from the command line in bot messages.
359         https://bugs.webkit.org/show_bug.cgi?id=52275
360
361         * Scripts/webkitpy/common/system/executive.py:
362         (ScriptError.message_with_output): Added a newline to separate the command
363         line from the errors.
364         * Scripts/webkitpy/common/system/executive_unittest.py:
365         (ScriptErrorTest.test_message_with_output): Added tests for the various code
366         paths in message_with_output.
367
368 2011-01-11  Eric Seidel  <eric@webkit.org>
369
370         Unreviewed.
371
372         commit-queue should know how to upload archived results (for test flakes or general failures)
373         https://bugs.webkit.org/show_bug.cgi?id=52048
374
375         The zips are mostly empty due to forgetting -r.
376         Expected diffs were not being pulled from the archive due
377         to the archive having longer paths than I realized.
378
379         * Scripts/webkitpy/common/system/workspace.py:
380         * Scripts/webkitpy/common/system/workspace_unittest.py:
381         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
382         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
383
384 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
385
386         Reviewed by Ojan Vafai.
387
388         The current modifier parsing code in test_expectations is
389         fragile and hard-coded, so it's not easy to understand the logic
390         or easily add new types of modifiers (like GPU vs. CPU testing
391         for graphics tests, or 32-bit vs. 64-bit differences).
392
393         This is the first of two patches that will add in more generic
394         support and then eliminate the GPU-specific test expectations
395         files for Chromium.
396
397         This patch adds two standalone objects for handling modifiers. The
398         rules for interpreting modifiers, precedence, and conflicts are
399         given in the docstring to the ModifierMatcher class, which
400         returns ModifierMatchResult objects.
401         
402         This patch also adds routines to the Port interface and a
403         default set of values in the base object, in order to obtain the
404         values needed on a given test run. These values are then passed
405         to the expectation parser. This also allows us to clean up the
406         logic used to lint all of the different configurations in a
407         single test_expectations.txt file.
408
409         The next patch will merge in the separate GPU expectations file.
410
411         https://bugs.webkit.org/show_bug.cgi?id=51222
412
413         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
414         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
415         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
416         * Scripts/webkitpy/layout_tests/port/base.py:
417         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
418         * Scripts/webkitpy/layout_tests/port/chromium.py:
419         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
420         * Scripts/webkitpy/layout_tests/port/test.py:
421         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
422         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
423
424 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
425
426         Reviewed by Adam Barth.
427
428         Make webkit-patch support subdirectories for SVN checkouts
429         https://bugs.webkit.org/show_bug.cgi?id=52261
430
431         * Scripts/webkitpy/common/checkout/scm.py:
432         * Scripts/webkitpy/style_references.py:
433         * Scripts/webkitpy/tool/main.py:
434         * Scripts/webkitpy/tool/steps/preparechangelog.py:
435
436 2011-01-11  Eric Seidel  <eric@webkit.org>
437
438         Unreviewed.
439
440         commit-queue should know how to upload archived results (for test flakes or general failures)
441         https://bugs.webkit.org/show_bug.cgi?id=52048
442
443         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
444         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
445
446         * Scripts/webkitpy/common/system/workspace.py:
447         * Scripts/webkitpy/common/system/workspace_unittest.py:
448         * Scripts/webkitpy/tool/commands/queues.py:
449
450 2011-01-11  Sam Weinig  <sam@webkit.org>
451
452         Roll r75474 back in.
453
454 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
455
456         Reviewed by Kenneth Rohde Christiansen.
457
458         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
459         https://bugs.webkit.org/show_bug.cgi?id=51204
460
461         * QtTestBrowser/webpage.h:
462         (QtNAMThread::QtNAMThread):
463         (QtNAMThread::networkAccessManager):
464         (QtNAMThread::run):
465
466 2011-01-11  Peter Varga  <pvarga@webkit.org>
467
468         Unreviewed.
469
470         Add myself to committers' list.
471
472         * Scripts/webkitpy/common/config/committers.py:
473
474 2011-01-11  Eric Seidel  <eric@webkit.org>
475
476         Reviewed by Adam Barth.
477
478         commit-queue should know how to upload archived results (for test flakes or general failures)
479         https://bugs.webkit.org/show_bug.cgi?id=52048
480
481         Now the queue will always upload results.  Either the entire zip, or just
482         the diffs.txt in the case of text failures.
483
484         This should make understanding flakes much easier, and paves the way
485         for having the EWS run layout tests (and upload failures).
486
487         In order to upload .zip files I had to teach bugzilla.py to autodetect
488         mime types from the filename.  Since mimetypes.py doesn't include a mapping
489         for .patch files, I have it add one before calling guess_type.
490
491         We may find that always uploading the whole zip instead of just the -diffs.txt
492         file is preferable, but for now I'm keeping the old behavior because it makes
493         quickly understanding text failures easy.
494
495         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
496         * Scripts/webkitpy/common/system/workspace.py: Added.
497         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
498         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
499         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
500         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
501         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
502         * Scripts/webkitpy/tool/commands/queues.py:
503         * Scripts/webkitpy/tool/commands/queues_unittest.py:
504
505 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
506
507         Unreviewed, rolling out r75464.
508         http://trac.webkit.org/changeset/75464
509         https://bugs.webkit.org/show_bug.cgi?id=52193
510
511         Followup rollout for 75474 (Requested by Ossy on #webkit).
512
513         * MiniBrowser/mac/BrowserWindowController.m:
514         (-[BrowserWindowController awakeFromNib]):
515         * MiniBrowser/win/BrowserView.cpp:
516         (BrowserView::create):
517         * WebKitTestRunner/TestController.cpp:
518         (WTR::createOtherPage):
519         (WTR::TestController::initialize):
520
521 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
522
523         Reviewed by Csaba Osztrogonác.
524
525         [Qt] Baseline qt_minimal configuration
526         https://bugs.webkit.org/show_bug.cgi?id=51313
527
528         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
529         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
530         QT_NO_UNDOSTACK guard.
531
532         * QtTestBrowser/launcherwindow.cpp:
533         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
534         guards.
535         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
536         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
537         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
538         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
539
540         * QtTestBrowser/launcherwindow.h:
541         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
542         * QtTestBrowser/locationedit.h: Ditto.
543
544         * QtTestBrowser/mainwindow.cpp:
545         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
546         QT_NO_UNDOSTACK guards.
547         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
548         (MainWindow::changeLocation): Ditto.
549         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
550         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
551
552         * QtTestBrowser/webpage.cpp:
553         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
554         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
555
556         * QtTestBrowser/webview.cpp:
557         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
558         (WebViewGraphicsBased::animatedYFlip): Ditto.
559
560 2011-01-10  Sam Weinig  <sam@webkit.org>
561
562         Fix build.
563
564         * MiniBrowser/mac/BrowserWindowController.m:
565         (-[BrowserWindowController awakeFromNib]):
566         * MiniBrowser/win/BrowserView.cpp:
567         (BrowserView::create):
568         * WebKitTestRunner/TestController.cpp:
569         (WTR::createOtherPage):
570         (WTR::TestController::initialize):
571
572 2011-01-10  Eric Seidel  <eric@webkit.org>
573
574         Reviewed by Ojan Vafai.
575
576         style-queue messages are way too long for big patches
577         https://bugs.webkit.org/show_bug.cgi?id=52161
578
579         We definitely could build much fancier list-to-string-with-limit functions
580         but this should be sufficient for our needs at the moment.
581
582         * Scripts/webkitpy/common/system/executive.py:
583         * Scripts/webkitpy/common/system/executive_unittest.py:
584
585 2011-01-10  Tony Chang  <tony@chromium.org>
586
587         Unreviewed, rolling out r75398.
588         http://trac.webkit.org/changeset/75398
589         https://bugs.webkit.org/show_bug.cgi?id=52008
590
591         Some layout tests are crashing on Chromium Win.
592
593         * DumpRenderTree/chromium/WebViewHost.cpp:
594         (WebViewHost::updatePaintRect):
595         * DumpRenderTree/chromium/WebViewHost.h:
596
597 2011-01-10  Adam Roben  <aroben@apple.com>
598
599         Roll out r75392
600
601         It isn't needed now that r75289 has been rolled out.
602
603         * Scripts/run-javascriptcore-tests:
604
605 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
606
607         Reviewed by Anders Carlsson.
608
609         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
610         https://bugs.webkit.org/show_bug.cgi?id=52160
611
612         * WebKitTestRunner/mac/TestControllerMac.mm:
613         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
614         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
615         anyway.
616
617 2011-01-10  Tony Chang  <tony@chromium.org>
618
619         Reviewed by Mihai Parparita.
620
621         [chromium] fix for animated gif layout tests
622         https://bugs.webkit.org/show_bug.cgi?id=52008
623
624         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
625             to trigger gif animations.
626         (WebViewHostPaintTask::WebViewHostPaintTask):
627         (WebViewHostPaintTask::runIfValid):
628         (WebViewHost::updatePaintRect):
629         * DumpRenderTree/chromium/WebViewHost.h:
630         (WebViewHost::taskList):
631
632 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
633
634         Reviewed by Xan Lopez.
635
636         [GTK] Fix gtk2 compilation for master
637         https://bugs.webkit.org/show_bug.cgi?id=51885
638
639         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
640         (createBitmapContextFromWebView): Replaced the old
641         gdk_drawable_get_size with gdk_pixmap_get_size.
642
643 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
644
645         Reviewed by Laszlo Gombos.
646
647         [WINCE] Reenable NPAPI after r75203
648         https://bugs.webkit.org/show_bug.cgi?id=52109
649
650         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
651         it with !isEfl(), because EFL port does not support NPAPI (yet).
652
653         * Scripts/build-webkit:
654
655 2011-01-10  Adam Roben  <aroben@apple.com>
656
657         Skip some asserting JS tests
658
659         See <http://webkit.org/b/52156>.
660
661         * Scripts/run-javascriptcore-tests:
662
663 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
664
665         Reviewed by Xan Lopez.
666
667         [GTK] build-webkit disable Blob support via arguments passed to automake
668         https://bugs.webkit.org/show_bug.cgi?id=52097
669
670         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
671         build-webkit.
672
673 2011-01-10  Adam Roben  <aroben@apple.com>
674
675         Use the same name and description for TestNetscapePlugin on Windows and
676         Mac
677
678         Fixes <http://webkit.org/b/52151>
679         fast/frames/iframe-reparenting-plugins.html fails on Windows
680
681         Reviewed by Steve Falkenburg.
682
683         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
684         the name and description from Mac's Info.plist.
685
686 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
687
688         Reviewed by Laszlo Gombos.
689
690         [Qt][WK2] Guard gcc-specific syntax
691
692         Non-gcc based compliers choke on the "-include"
693         syntax for preinclude, place guard around it.
694
695         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
696         * WebKitTestRunner/qt/WebKitTestRunner.pro:
697
698 2011-01-10  Andreas Kling  <kling@webkit.org>
699
700         Reviewed by Simon Hausmann.
701
702         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
703         https://bugs.webkit.org/show_bug.cgi?id=52111
704
705         When getting a createNewPage() callback from QWKPage, create the
706         new page with the same QWKContext as the page that is passed to
707         the callback.
708
709         * MiniBrowser/qt/BrowserView.h:
710         * MiniBrowser/qt/BrowserWindow.cpp:
711         (newPageFunction):
712         (BrowserWindow::BrowserWindow):
713         * MiniBrowser/qt/BrowserWindow.h:
714
715 2011-01-10  Andreas Kling  <kling@webkit.org>
716
717         Reviewed by Kenneth Rohde Christiansen.
718
719         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
720
721         BrowserView set its own useless createNewPage() callback on QWKPage.
722         This was immediately overridden by BrowserWindow anyway, so remove
723         the BrowserView one.
724
725         * MiniBrowser/qt/BrowserView.cpp:
726         (BrowserView::BrowserView):
727
728 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
729
730         Reviewed by Jeremy Orlow.
731
732         [Chromium] Remove non-client-based Geolocation code
733         https://bugs.webkit.org/show_bug.cgi?id=50921
734
735         * DumpRenderTree/chromium/LayoutTestController.cpp:
736         (LayoutTestController::setGeolocationPermission):
737         (LayoutTestController::setMockGeolocationPosition):
738         (LayoutTestController::setMockGeolocationError):
739         * DumpRenderTree/chromium/WebViewHost.cpp:
740         (WebViewHost::geolocationClientMock):
741         (WebViewHost::reset):
742         * DumpRenderTree/chromium/WebViewHost.h:
743
744 2011-01-10  Eric Seidel  <eric@webkit.org>
745
746         Reviewed by Adam Barth.
747
748         Commit bot tried to land r? cq+ patch
749         https://bugs.webkit.org/show_bug.cgi?id=36638
750
751         It should now be possible to post a patch with r? and cq+ and the
752         commit-queue will correctly wait for the r+ before attempting to land the patch.
753         (This was a feature requested by several users.)
754
755         One caveat: We don't actually reject r-, cq+ patches from the queue
756         (we just ignore them), but I think that's OK for now.
757
758         I also noticed that setting r- once a commit-queue node had grabbed
759         a patch would not properly cancel the landing.  That's fixed and
760         tested in this patch.
761
762         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
763         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
764         * Scripts/webkitpy/tool/bot/feeders.py:
765         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
766
767 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
768
769         Reviewed by Kenneth Rohde Christiansen.
770
771         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
772         https://bugs.webkit.org/show_bug.cgi?id=51934
773
774         When accessing the network from the destructor of QWebPage, the network access manager
775         was already deleted because the object WebPage was already destructed.
776
777         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
778         The object is now destructed in the destructor of QObject.
779
780         * QtTestBrowser/webpage.cpp:
781         (WebPage::WebPage):
782         (WebPage::setQnamThreaded):
783         * QtTestBrowser/webpage.h:
784         (QtNAMThread::QtNAMThread):
785
786 2011-01-08  Eric Seidel  <eric@webkit.org>
787
788         Reviewed by Ojan Vafai.
789
790         test_failures.py should not mention TestShell (long live DumpRenderTree!)
791         https://bugs.webkit.org/show_bug.cgi?id=52067
792
793         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
794         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
795
796         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
797
798 2011-01-08  Eric Seidel  <eric@webkit.org>
799
800         Reviewed by Mihai Parparita.
801
802         commit-queue hangs when the ChangeLog diff is bad
803         https://bugs.webkit.org/show_bug.cgi?id=52072
804
805         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
806         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
807
808 2011-01-08  Adam Barth  <abarth@webkit.org>
809
810         Teach svn-apply how to re-write WebCore to Source/WebCore.
811
812         * Scripts/VCSUtils.pm:
813
814 2011-01-07  Adam Barth  <abarth@webkit.org>
815
816         Rubber-stamped by Eric Seidel.
817
818         Move WebCore to Source
819         https://bugs.webkit.org/show_bug.cgi?id=52050
820
821         Update the tools to understand WebCore's new location.
822
823         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
824         * DumpRenderTree/wscript:
825         * GNUmakefile.am:
826         * Scripts/build-webkit:
827         * Scripts/do-file-rename:
828         * Scripts/do-webcore-rename:
829         * Scripts/generate-qt-inspector-resource:
830         * Scripts/prepare-ChangeLog:
831         * Scripts/run-bindings-tests:
832         * Scripts/update-iexploder-cssproperties:
833         * Scripts/update-sources-list.py:
834         * Scripts/update-webkit-localizable-strings:
835         * Scripts/webkitdirs.pm:
836         * Scripts/webkitpy/common/config/build.py:
837         * Scripts/webkitpy/common/config/build_unittest.py:
838         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
839         * Scripts/webkitpy/style/checker.py:
840         * Scripts/webkitpy/style/checker_unittest.py:
841         * WebKitTestRunner/DerivedSources.pro:
842         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
843         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
844         * wx/browser/wscript:
845         * wx/build/settings.py:
846
847 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
848
849         Reviewed by Sam Weinig.
850
851         Make WebKitTestRunner rest between loads more robust to avoid test crashes
852         https://bugs.webkit.org/show_bug.cgi?id=52086
853
854         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
855         (WTR::InjectedBundle::didReceiveMessage):
856         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
857         (WTR::LayoutTestController::notifyDone):
858         * WebKitTestRunner/TestController.cpp:
859         (WTR::TestController::resetStateToConsistentValues):
860         (WTR::TestController::run):
861
862 2011-01-07  James Robinson  <jamesr@chromium.org>
863
864         Revert "Implement mozilla's animationTime property"
865         https://bugs.webkit.org/show_bug.cgi?id=51952
866
867         This approach isn't quite right.
868
869         * DumpRenderTree/chromium/WebViewHost.cpp:
870         (WebViewHost::paintInvalidatedRegion):
871
872 2011-01-07  Adam Roben  <aroben@apple.com>
873
874         Build master fix
875
876         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
877         (RunWebKitTests.start): Don't try to concatenate a list and a string.
878
879 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
880
881         Reviewed by Csaba Osztrogonác.
882
883         run-qtwebkit-tests should be able to kill a testsuite.
884
885         Add new option in the script that can setup a timeout for a test.
886         If the test execution takes more then specified time then the test
887         would be terminated.
888
889         [Qt] run-qtwebkit-tests needs timeout
890         https://bugs.webkit.org/show_bug.cgi?id=51894
891
892         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
893         * Scripts/run-qtwebkit-tests:
894
895 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
896
897         Unreviewed fix after r75233.
898
899         Based on idea from Eric Seidel.
900
901         Add remote zip file handling to webkitpy.
902         https://bugs.webkit.org/show_bug.cgi?id=50901
903
904         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
905
906 2011-01-07  Shane Stephens  <shanestephens@google.com>
907
908         Reviewed by Eric Seidel.
909
910         svn-apply: should support git binary delta diffs
911         https://bugs.webkit.org/show_bug.cgi?id=38864
912
913         * Scripts/VCSUtils.pm:
914         * Scripts/svn-apply:
915
916 2011-01-06  Julie Parent  <jparent@chromium.org>
917
918         Reviewed by Eric Seidel.
919
920         Test Result Server not removing old results.
921         https://bugs.webkit.org/show_bug.cgi?id=52012
922
923         * TestResultServer/model/jsonresults.py:
924         Fix off-by-one: Truncate if >= num_runs, not just >.
925         * TestResultServer/model/jsonresults_unittest.py:
926         Add unit test to test that merging in a new result with the same value
927         as the last result causes previous result to fall off.
928
929 2011-01-06  James Kozianski  <koz@chromium.org>
930
931         Reviewed by Mihai Parparita.
932
933         Add classes to provide a consistent interface to a set of files.
934         https://bugs.webkit.org/show_bug.cgi?id=50901
935
936         These classes allow us to write code that is agnostic to whether a
937         particular set of files resides in a local directory or in a zip file
938         on a remote machine.
939
940         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
941         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
942         * Scripts/webkitpy/common/system/fileset.py: Added.
943         * Scripts/webkitpy/common/system/filesystem.py:
944         * Scripts/webkitpy/common/system/filesystem_mock.py:
945         * Scripts/webkitpy/common/system/zipfileset.py: Added.
946         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
947
948 2011-01-06  Eric Seidel  <eric@webkit.org>
949
950         Reviewed by Adam Barth.
951
952         NetworkTransaction should log the url it is retrying
953         https://bugs.webkit.org/show_bug.cgi?id=52043
954
955         * Scripts/webkitpy/common/net/networktransaction.py:
956         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
957
958 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
959
960         Windows build fix.
961         Import os before using it.
962
963         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
964
965 2011-01-06  Eric Seidel  <eric@webkit.org>
966
967         Reviewed by Adam Barth.
968
969         StyleQueue fails to report errors when patches have many files
970         https://bugs.webkit.org/show_bug.cgi?id=52042
971
972         This is one of at least two errors preventing style error reporting at the moment.
973         When we moved to passing the list of files to check explicitly,
974         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
975         We could change the type of the QueueStatus.message type, or we could
976         just teach statusserver.py how to clamp values (and warn when it does).
977         I chose the latter path.
978
979         * Scripts/webkitpy/common/net/statusserver.py:
980
981 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
982
983         Reviewed by Stephanie Lewis.
984         
985         Fix syntax error in script.
986
987         Windows bots need to archive/unarchive builds to/from configuration-specific directories
988         https://bugs.webkit.org/show_bug.cgi?id=51996
989
990         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
991
992 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
993
994         Unreviewed, fixing WinCE build after r75196.
995
996         WinCE port does not (yet) support NPAPI.
997
998         * Scripts/build-webkit:
999
1000 2011-01-06  Xan Lopez  <xlopez@igalia.com>
1001
1002         Reviewed by Darin Adler.
1003
1004         File::Spec->rel2abs in sunspider-compare-results mangles parameters
1005         https://bugs.webkit.org/show_bug.cgi?id=52015
1006
1007         * Scripts/sunspider-compare-results: call rel2abs on our arguments
1008         after the platform has been detected, otherwise the script will
1009         mangle things like '--gtk' into '/a/path/--gtk', breaking the
1010         detection.
1011
1012 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1013
1014         Reviewed by Eric Seidel.
1015
1016         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
1017         https://bugs.webkit.org/show_bug.cgi?id=51346
1018
1019         * Scripts/build-webkit:
1020
1021 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1022
1023         Reviewed by Adam Roben.
1024
1025         Windows bots need to archive/unarchive builds to/from configuration-specific directories
1026         https://bugs.webkit.org/show_bug.cgi?id=51996
1027         
1028         After the configuration directory change, we were archiving the incorrect directory for
1029         build product, so we were running tests on the wrong binaries.
1030         
1031         This change archives the correct directory, and also unarchives it into a configuration-
1032         specific directory.
1033
1034         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
1035         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
1036
1037 2011-01-06  Eric Seidel  <eric@webkit.org>
1038
1039         Reviewed by Mihai Parparita.
1040
1041         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
1042         https://bugs.webkit.org/show_bug.cgi?id=52002
1043
1044         See an example of this here:
1045         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
1046
1047         It's due to the fact that we pass around TestFailure() instance
1048         objects and yet expect them to all compare to be the same.
1049
1050         This is bad.  We should either have shared instances of these values
1051         or we should just pass around the class names.  There are already hacks
1052         in place to make TestFailure objects pass equality tests, I just added
1053         a __hash__ implementation so they can be used in sets as expected.
1054
1055         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1056         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1057
1058 2011-01-06  Evan Martin  <evan@chromium.org>
1059
1060         Reviewed by Tony Chang.
1061
1062         [gdb] handle inaccessible memory and UChar*
1063         https://bugs.webkit.org/show_bug.cgi?id=52003
1064
1065         To pretty-print a UChar*, we just grope around in the memory
1066         looking for a terminating NUL.  We need to handle the exception
1067         that can occur when we poke into an invalid location.
1068
1069         Additionally, the logic for choosing which pretty-printer would
1070         early return before hitting the point where we'd use the UChar*
1071         printer.  (Did this ever work?  How did it regress?)
1072
1073         * gdb/webkit.py:
1074
1075 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
1076
1077         Reviewed by Ada Chan.
1078
1079         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
1080         https://bugs.webkit.org/show_bug.cgi?id=51969
1081         
1082         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
1083
1084         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1085         (WTR::InjectedBundlePage::InjectedBundlePage):
1086         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
1087         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1088
1089 2011-01-06  James Robinson  <jamesr@chromium.org>
1090
1091         Reviewed by Simon Fraser.
1092
1093         Implement mozilla's animationTime property
1094         https://bugs.webkit.org/show_bug.cgi?id=51952
1095
1096         Chromium DRT support for webkitAnimationTime.
1097
1098         * DumpRenderTree/chromium/WebViewHost.cpp:
1099         (WebViewHost::paintInvalidatedRegion):
1100
1101 2011-01-06  Julie Parent  <jparent@chromium.org>
1102
1103         Reviewed by Tony Chang.
1104
1105         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
1106         https://bugs.webkit.org/show_bug.cgi?id=51217
1107
1108         * TestResultServer/model/jsonresults.py:
1109         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
1110         Adds missing documentation.
1111         * TestResultServer/model/jsonresults_unittest.py:
1112         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
1113         Update test_merge to take a number of builds to truncate at.
1114
1115 2011-01-06  Adam Barth  <abarth@webkit.org>
1116
1117         Reviewed by Eric Seidel.
1118
1119         The EWS should log outside of the working directory
1120         https://bugs.webkit.org/show_bug.cgi?id=51986
1121
1122         This patch prepare us for using git clean -x -d -f in the EWS wrapper
1123         script, which will actually clean the working copy back to a pristine
1124         state instead of leaving untracked directories and ignored files.
1125
1126         * Scripts/webkitpy/tool/commands/queues.py:
1127         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1128
1129 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1130
1131         Windows build fix.
1132         Back out attempted change to built-product-archive.
1133
1134         * BuildSlaveSupport/built-product-archive:
1135
1136 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1137
1138         Windows build fix.
1139         Include configuration name when unpacking a build archive.
1140
1141         Needed, since we split Windows build results into configuration-specific directories
1142         under WebKitOutputDir.
1143
1144         * BuildSlaveSupport/built-product-archive:
1145
1146 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1147
1148         Reviewed by Darin Adler.
1149
1150         Debug and Release builds on Windows clobber each other
1151         https://bugs.webkit.org/show_bug.cgi?id=49185
1152
1153         Changes the structure of WebKitBuild build products directory so we
1154         completely separate each build configuration into independent directories.
1155         
1156         Although we previously had per-configuration directories for obj, this change adds
1157         per-configuration directories for bin, lib, obj, and include. Each configuration's
1158         build products are stored within a directory inside of WebKitBuild.
1159         
1160         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
1161         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
1162
1163         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
1164         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
1165         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
1166         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
1167         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
1168         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
1169         * DumpRenderTree/win/ImageDiffCommon.vsprops:
1170         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
1171         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
1172         * FindSafari/FindSafari.vcproj:
1173         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
1174         * MiniBrowser/MiniBrowserPostBuild.cmd:
1175         * MiniBrowser/MiniBrowserPreBuild.cmd:
1176         * Scripts/webkitdirs.pm:
1177         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
1178         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
1179         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
1180         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
1181         * TestWebKitAPI/win/copy-resources.cmd:
1182         * WebKitAPITest/WebKitAPITestCommon.vsprops:
1183         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
1184         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
1185         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
1186         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
1187         * WebKitTestRunner/win/InjectedBundle.vcproj:
1188         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
1189         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
1190         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
1191         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
1192         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
1193         * WinLauncher/WinLauncherCommon.vsprops:
1194         * WinLauncher/WinLauncherPostBuild.cmd:
1195         * WinLauncher/WinLauncherPreBuild.cmd:
1196
1197 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
1198
1199         Reviewed by Ariya Hidayat.
1200
1201         [Qt] TestNetscapePlugin doesn't link on OS X
1202         https://bugs.webkit.org/show_bug.cgi?id=51948
1203
1204         Only add a dependency on libX11 on X11 systems
1205
1206         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1207
1208 2011-01-05  Jeff Miller  <jeffm@apple.com>
1209
1210         Reviewed by Adam Roben.
1211
1212         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
1213         https://bugs.webkit.org/show_bug.cgi?id=51970
1214
1215         * Scripts/webkitpy/style/checker.py:
1216         Add -readability/naming for WebKit2 C API directories.
1217
1218 2011-01-05  Eric Seidel  <eric@webkit.org>
1219
1220         Unreviewed, just fixing one more log error from my previous python patch.
1221
1222         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1223         https://bugs.webkit.org/show_bug.cgi?id=51802
1224
1225         webkit-patch failure-reason was logging about parsing errors
1226         due to my misunderstanding of how BeautifulSoup.findAll worked.
1227
1228         Fixed, and added a unit test.
1229
1230         * Scripts/webkitpy/common/net/layouttestresults.py:
1231         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1232
1233 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
1234
1235         Reviewed by Kenneth Rohde Christiansen.
1236
1237         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
1238         https://bugs.webkit.org/show_bug.cgi?id=51951
1239
1240         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
1241         to create new window from WebKit.
1242
1243         * MiniBrowser/qt/BrowserWindow.cpp:
1244         (newPageFunction):
1245         (BrowserWindow::BrowserWindow):
1246         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
1247         (BrowserWindow::newWindow):
1248         (BrowserWindow::updateUserAgentList):
1249         (BrowserWindow::showUserAgentDialog):
1250         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
1251         define the type of the backing store used for new windows.
1252         * MiniBrowser/qt/main.cpp:
1253         (main):
1254
1255 2011-01-05  Eric Seidel  <eric@webkit.org>
1256
1257         Reviewed by Ojan Vafai.
1258
1259         commit-queue should report failure type when reporting flaky tests
1260         https://bugs.webkit.org/show_bug.cgi?id=51900
1261
1262         This patch was a ridiculous amount of plumbing.  In the end I like
1263         the NRWT-style TestResult class even less.  But now we're passing
1264         a list of TestResult objects from the queue to the FlakyTestReporter.
1265         Thus the FlakyTestReporter can more easily report what type of failure
1266         occurred.
1267
1268         In the process, I found that I was not alone in finding TestResult
1269         cumbersome to use.  A bunch of code was trying to create a TestResult
1270         object with default values.  However since the constructor didn't make
1271         this easy, some places were getting it wrong (including the TestResult unit test)!
1272         I've fixed the TestResult constructor to have default values for non-essential
1273         arguments.
1274
1275         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1276         * Scripts/webkitpy/common/net/layouttestresults.py:
1277         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1278         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1279         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1280         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1281         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
1282         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
1283         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1284         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1285         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1286         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1287         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1288         * Scripts/webkitpy/tool/commands/queues.py:
1289         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1290
1291 2011-01-05  Eric Seidel  <eric@webkit.org>
1292
1293         Unreviewed.
1294
1295         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1296         https://bugs.webkit.org/show_bug.cgi?id=51802
1297
1298         Add another unit test to cover a previously missing import.
1299
1300         * Scripts/webkitpy/common/net/layouttestresults.py:
1301         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1302
1303 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
1304
1305         Reviewed by David Levin.
1306
1307         Add mihaip@chromium.org as a reviewer
1308         https://bugs.webkit.org/show_bug.cgi?id=51966
1309         
1310         Add myself as a reviewer.
1311
1312         * Scripts/webkitpy/common/config/committers.py:
1313
1314 2011-01-05  James Simonsen  <simonjam@chromium.org>
1315
1316         Unreviewed. Adding myself to the list of committers.
1317
1318         * Scripts/webkitpy/common/config/committers.py:
1319
1320 2011-01-05  Eric Seidel  <eric@webkit.org>
1321
1322         Unreviewed.
1323
1324         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1325         https://bugs.webkit.org/show_bug.cgi?id=51802
1326
1327         Fix two exceptions seen on the bots after my original commit.
1328
1329         * Scripts/webkitpy/common/net/layouttestresults.py:
1330         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1331
1332 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
1333
1334         Reviewed by Andreas Kling.
1335
1336         [Qt]Add local storage settings to QtTestBrowser command line arguments 
1337         https://bugs.webkit.org/show_bug.cgi?id=51750
1338
1339         * QtTestBrowser/main.cpp:
1340         (LauncherApplication::handleUserOptions):
1341          Local storage settings can be enable form command line arguments for
1342          QtTestBrowser.
1343
1344 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
1345
1346         Reviewed by Martin Robinson.
1347
1348         GTK: AX: DRT needs to use correct root object method.
1349         https://bugs.webkit.org/show_bug.cgi?id=51911
1350
1351         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1352         (AccessibilityController::rootElement):
1353
1354 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1355
1356         Rubber-stamped by Csaba Osztrogonác.
1357
1358         Based on idea from Péter Gál.
1359
1360         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
1361
1362 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1363
1364         Reviewed by Adam Barth.
1365
1366         sheriff-bot should be able to do multi-revision rollouts
1367         https://bugs.webkit.org/show_bug.cgi?id=51176
1368
1369         * Scripts/webkitpy/tool/bot/irc_command.py:
1370         * Scripts/webkitpy/tool/bot/sheriff.py:
1371         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1372
1373 2011-01-05  Eric Seidel  <eric@webkit.org>
1374
1375         Reviewed by Adam Barth.
1376
1377         queues.webkit.org should have per-bot status pages
1378         https://bugs.webkit.org/show_bug.cgi?id=51906
1379
1380         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
1381         statuses from a single queue.  Now that we have many bots servicing
1382         some queues (commit-queue, win-ews, etc.) its easy to have the messages
1383         you care about scroll off the end of the 15-message limit on the main page.
1384
1385         Eventually we should probably rename /queue-status to /queue or /queues,
1386         but that's fodder for another patch.
1387
1388         * QueueStatusServer/handlers/queuestatus.py:
1389         * QueueStatusServer/index.yaml:
1390         * QueueStatusServer/main.py:
1391         * QueueStatusServer/templates/includes/singlequeuestatus.html:
1392          - This probably should use a custom filter instead of hard-coding
1393            the URL scheme here, but I couldn't figure out how to easily
1394            create such a filter.  Most filters work with "strings" so we can't
1395            pass the status object.  We could add a method to the status
1396            object and call that, but that seemed a bit strange too.
1397         * QueueStatusServer/templates/queuestatus.html:
1398
1399 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1400
1401         Unreviewed. Adding myself to the list of committers.
1402
1403         * Scripts/webkitpy/common/config/committers.py:
1404
1405 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
1406
1407         Reviewed by David Levin.
1408
1409         check-webkit-style treated some macros with parentheses after #elif as function calls
1410         https://bugs.webkit.org/show_bug.cgi?id=51695
1411
1412         Ingore function call space checking in any preprocessor directives
1413         (things starting with #). Change search() to match() because 
1414         preprocessor directives are supposed to be in the beginning of lines.
1415
1416         * Scripts/webkitpy/style/checkers/cpp.py:
1417         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
1418
1419 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
1420
1421         Reviewed by Tony Chang.
1422
1423         Change the --multi-load test option to --stress-opt
1424         https://bugs.webkit.org/show_bug.cgi?id=50751
1425
1426         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1427         (runTest):
1428         (main):
1429         * DumpRenderTree/chromium/TestShell.cpp:
1430         (TestShell::TestShell):
1431         * DumpRenderTree/chromium/TestShell.h:
1432         (TestShell::stressOpt):
1433         (TestShell::setStressOpt):
1434         (TestShell::stressDeopt):
1435         (TestShell::setStressDeopt):
1436         (TestShell::javaScriptFlags):
1437         (TestShell::setJavaScriptFlags):
1438         * Scripts/webkitpy/layout_tests/port/chromium.py:
1439         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1440
1441 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
1442
1443         Reviewed by Sam Weinig.
1444
1445         WK2: Support Accessibility
1446         https://bugs.webkit.org/show_bug.cgi?id=51859
1447
1448         Use rootObject() method to get top of accessibility tree.
1449
1450         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1451         (AccessibilityController::focusedElement):
1452         (AccessibilityController::rootElement):
1453
1454 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
1455
1456         Reviewed by Darin Adler.
1457
1458         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
1459         https://bugs.webkit.org/show_bug.cgi?id=51846
1460
1461         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
1462         back to GRefPtr.
1463
1464 2011-01-04  Zhe Su  <suzhe@chromium.org>
1465
1466         Reviewed by Kenneth Russell.
1467
1468         Fix insertText, setMarkedText and unmarkText methods of
1469         TextInputController to call corresponding methods of WebKit::WebView
1470         rather than WebKit::WebFrame. This change matches the behavior of
1471         chromium browser.
1472         insertText corresponds to WebView::confirmComposition(text)
1473         setMarkedText corresponds to WebView::setComposition(...)
1474         unmarkText corresponds to WebView::confirmComposition()
1475         https://bugs.webkit.org/show_bug.cgi?id=51693
1476
1477         * DumpRenderTree/chromium/TextInputController.cpp:
1478         (TextInputController::insertText):
1479         (TextInputController::setMarkedText):
1480         (TextInputController::unmarkText):
1481
1482 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
1483
1484         Reviewed by Laszlo Gombos.
1485
1486         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
1487
1488         On Symbian productDir points to the source directory. Removing all the
1489         empty files from the productDir directory corrupts the svn repository.
1490
1491         * Scripts/build-webkit:
1492
1493 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
1494
1495         Reviewed by Adam Barth.
1496
1497         [Qt] Add SelectAll option to the context menu for the editor
1498         https://bugs.webkit.org/show_bug.cgi?id=50049
1499
1500         Set shortcut for the SelectAll action.
1501
1502         * QtTestBrowser/mainwindow.cpp:
1503         (MainWindow::buildUI):
1504
1505 2011-01-03  David Levin  <levin@chromium.org>
1506
1507         Reviewed by Eric Seidel.
1508
1509         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
1510         https://bugs.webkit.org/show_bug.cgi?id=51842
1511
1512         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
1513         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
1514
1515 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
1516
1517         Reviewed by David Kilzer.
1518
1519         [WINCE] Adds a build slave.
1520         https://bugs.webkit.org/show_bug.cgi?id=50523
1521
1522         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
1523         entry for a release build of the WinCE port.
1524         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
1525         flag to build the WinCE port.
1526
1527 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
1528
1529         Reviewed by David Kilzer.
1530
1531         Add WinCE support to build-webkit
1532         https://bugs.webkit.org/show_bug.cgi?id=51642
1533
1534         * Scripts/build-webkit:
1535         * Scripts/webkitdirs.pm:
1536
1537 2011-01-03  Eric Seidel  <eric@webkit.org>
1538
1539         Reviewed by Adam Barth.
1540
1541         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1542         https://bugs.webkit.org/show_bug.cgi?id=51802
1543
1544         I'm not the biggest fan of the test_failures or test_results classes,
1545         but it's better to have one shared set of classes, than separate ones
1546         for new vs. old run-webkit-test result handling.
1547
1548         This moves the ORWT results class "LayoutTestResults" over to using
1549         TestResult and TestFailure classes, making it easy for us to
1550         make all our sheriff-bot and other webkitpy code NRWT ready.
1551
1552         This also makes it a trivial patch to generate results.json information
1553         from ORWT results.html files (for flaky test analysis, etc.) as well
1554         as making it a one-liner to report test failure types when the
1555         commit-queue sees flaky tests.
1556
1557         This patch tried not to add new functionality, but only to replace
1558         the guts of LayoutTestResults, while adding unit tests and hoping
1559         not to break anything.
1560
1561         I also moved callers which assumed User.prompt* were static/class methods
1562         to using them as instance methods (since we'll eventually want to make them such).
1563
1564         In the process of re-writing things, I broke the rebaseline command, so I wrote
1565         a unit test to catch my breakage were I do do so again in the future.
1566
1567         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1568         * Scripts/webkitpy/common/net/layouttestresults.py:
1569         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1570         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1571         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
1572         * Scripts/webkitpy/tool/commands/queries.py:
1573         * Scripts/webkitpy/tool/commands/rebaseline.py:
1574         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1575         * Scripts/webkitpy/tool/mocktool.py:
1576
1577 2011-01-03  Adam Barth  <abarth@webkit.org>
1578
1579         Reviewed by Simon Fraser.
1580
1581         webkit-patch shouldn't waste time cleaning a working directory that's already clean
1582         https://bugs.webkit.org/show_bug.cgi?id=51840
1583
1584         * Scripts/webkitpy/common/checkout/scm.py:
1585
1586 2011-01-03  Adam Barth  <abarth@webkit.org>
1587
1588         Reviewed by Simon Fraser.
1589
1590         webkit-patch should only hide update output if --quiet
1591         https://bugs.webkit.org/show_bug.cgi?id=51838
1592
1593         As requested by smfr.
1594
1595         * Scripts/webkitpy/tool/steps/update.py:
1596
1597 2011-01-03  Adam Barth  <abarth@webkit.org>
1598
1599         Reviewed by David Levin.
1600
1601         commit-queue shouldn't reject patches twice if two bots process the same patch
1602         https://bugs.webkit.org/show_bug.cgi?id=51805
1603
1604         Before raising an error, we first check whether the patch is still in
1605         the commit-queue.  This check is still racy, of course, but the time
1606         window is much smaller.
1607
1608         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1609
1610 2011-01-03  Sam Weinig  <sam@webkit.org>
1611
1612         Reviewed by Anders Carlsson.
1613
1614         Make run-api-tests less chatty.
1615         https://bugs.webkit.org/show_bug.cgi?id=51831
1616
1617         - Make script quiet by default and add --verbose option (replacing --quiet).
1618         - When not verbose, pipe stdout and stderr to devnull.
1619
1620         * Scripts/run-api-tests:
1621
1622 2011-01-03  Pratik Solanki  <psolanki@apple.com>
1623
1624         Unreviewed. Adding myself to committers.py.
1625
1626         * Scripts/webkitpy/common/config/committers.py:
1627
1628 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
1629
1630         Reviewed by Xan Lopez.
1631
1632         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
1633         https://bugs.webkit.org/show_bug.cgi?id=51806
1634
1635         Originally, the $libraryName is 'JavaScriptCore'. When building release 
1636         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
1637         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
1638         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 
1639         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
1640         so make it 'WebKitBuild/Release/.libs'
1641
1642         * Scripts/webkitdirs.pm: 
1643
1644 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
1645
1646         Reviewed by Adam Barth.
1647
1648         Make EFL a core builder
1649         https://bugs.webkit.org/show_bug.cgi?id=51804
1650
1651         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1652         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1653
1654 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
1655
1656         [Qt] Unreviewed fix after r74855 and r74875.
1657
1658         * BuildSlaveSupport/built-product-archive:
1659          - Create directories explicitly.
1660          - Pass shell=True to subprocess.call().
1661
1662 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
1663
1664         [Qt] Unreviewed fix after r74855.
1665
1666         Move JavaScriptCore to Source
1667         https://bugs.webkit.org/show_bug.cgi?id=51604
1668
1669         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
1670
1671 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
1672
1673         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
1674
1675         Move JavaScriptCore to Source
1676         https://bugs.webkit.org/show_bug.cgi?id=51604
1677
1678         * Scripts/webkitdirs.pm:
1679
1680 2011-01-02  Robert Hogan  <robert@webkit.org>
1681
1682         Unreviewed, build fix.
1683
1684         [Qt] Fix DRT build after 74855
1685
1686         * DumpRenderTree/qt/DumpRenderTree.pro:
1687
1688 2011-01-01  Adam Barth  <abarth@webkit.org>
1689
1690         Remove the assumption from the Qt and Gtk builds that every project is
1691         in the root directory.
1692
1693         * Scripts/build-webkit:
1694
1695 2011-01-01  Adam Barth  <abarth@webkit.org>
1696
1697         Reviewed by Eric Seidel.
1698
1699         Teach svn-apply how to apply patches even though JavaScriptCore has moved
1700         https://bugs.webkit.org/show_bug.cgi?id=51796
1701
1702         After this change, svn-apply will magically apply patches to
1703         JavaScriptCore/foo to Source/JavaScriptCore/foo.
1704
1705         * Scripts/VCSUtils.pm:
1706
1707 2011-01-01  Adam Barth  <abarth@webkit.org>
1708
1709         Reviewed by Eric Seidel.
1710
1711         Move JavaScriptCore to Source
1712         https://bugs.webkit.org/show_bug.cgi?id=51604
1713
1714         Update references to JavaScriptCore to point to the new location.
1715
1716         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1717         * DumpRenderTree/qt/DumpRenderTree.pro:
1718         * DumpRenderTree/qt/ImageDiff.pro:
1719         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1720         * DumpRenderTree/wscript:
1721         * Scripts/build-jsc:
1722         * Scripts/build-webkit:
1723         * Scripts/do-file-rename:
1724         * Scripts/do-webcore-rename:
1725         * Scripts/run-javascriptcore-tests:
1726         * Scripts/update-javascriptcore-test-results:
1727         * Scripts/webkitdirs.pm:
1728         * Scripts/webkitpy/common/config/build_unittest.py:
1729         * Scripts/webkitpy/style/checker.py:
1730         * Scripts/webkitpy/style/checker_unittest.py:
1731         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1732         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1733         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1734         * wx/build/settings.py:
1735
1736 2011-01-01  Adam Barth  <abarth@webkit.org>
1737
1738         Reviewed by Eric Seidel.
1739
1740         Move Sources to Source
1741         https://bugs.webkit.org/show_bug.cgi?id=51794
1742
1743         Update scripts to point to the new location.
1744
1745         * Scripts/build-webkit:
1746         * Scripts/do-file-rename:
1747         * Scripts/do-webcore-rename:
1748         * Scripts/webkitpy/common/config/build.py:
1749         * Scripts/webkitpy/common/config/build_unittest.py:
1750
1751 2010-12-31  Kent Tamura  <tkent@chromium.org>
1752
1753         Reviewed by Eric Seidel.
1754
1755         [DRT/Chromium] Enable mock spell checker on non-OSX
1756         https://bugs.webkit.org/show_bug.cgi?id=51401
1757
1758         * DumpRenderTree/chromium/WebViewHost.cpp:
1759         (WebViewHost::spellCheck):
1760
1761 2010-12-31  Adam Barth  <abarth@webkit.org>
1762
1763         Reviewed by Ariya Hidayat.
1764
1765         Remove Tools/Scripts/wkstyle
1766         https://bugs.webkit.org/show_bug.cgi?id=51774
1767
1768         This script appears to not have been touched in a while and seems to
1769         have been replaced by check-webkit-style.
1770
1771         * Scripts/wkstyle: Removed.
1772
1773 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
1774
1775         Unreviewed. Coding style fix.
1776
1777         * DumpRenderTree/chromium/TestShell.h:
1778
1779 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
1780
1781         Reviewed by Pavel Feldman.
1782
1783         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
1784
1785         It was a problem with Chromium DRT. DevToolsAgent object instance was
1786         attached not only to the inspected page but to the DevTools window too.
1787         As result all the inspector files were interpreted as a content of inspected page
1788         and were transfered to the DevTools scripts panel for debugging etc.
1789
1790         https://bugs.webkit.org/show_bug.cgi?id=51735
1791
1792         * DumpRenderTree/chromium/TestShell.cpp:
1793         (TestShell::TestShell):
1794         (TestShell::bindJSObjectsToWindow):
1795         (TestShell::createNewWindow):
1796         * DumpRenderTree/chromium/TestShell.h:
1797
1798 2010-12-31  Adam Barth  <abarth@webkit.org>
1799
1800         Rubber-stamped by Eric Seidel.
1801
1802         Move PageLoadTests to PerformanceTests/PageLoad
1803         https://bugs.webkit.org/show_bug.cgi?id=51771
1804
1805         Update references to PageLoadTests to point to the new location.
1806
1807         * Scripts/run-pageloadtest:
1808         * Scripts/webkitpy/common/config/build.py:
1809
1810 2010-12-31  Adam Barth  <abarth@webkit.org>
1811
1812         Rubber-stamped by Eric Seidel.
1813
1814         Move SunSpider into PerformanceTests
1815         https://bugs.webkit.org/show_bug.cgi?id=51769
1816
1817         Update these scripts to point to the new location.
1818
1819         * Scripts/run-sunspider:
1820         * Scripts/sunspider-compare-results:
1821
1822 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
1823
1824         Reviewed by Kent Tamura.
1825
1826         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
1827         https://bugs.webkit.org/show_bug.cgi?id=51728
1828         
1829         Add implementation of the Mac WebThemeEngine that uses an NSScroller
1830         to render top-level scrollbars. This makes them match the Mac port's
1831         use of an NSScrollView, which means that we'll be able to share more
1832         pixel baselines.
1833         
1834         The new rendering code will not be activated until the 
1835         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
1836         ScrollbarThemeChromiumMac.
1837
1838         * DumpRenderTree/DumpRenderTree.gypi:
1839         * DumpRenderTree/chromium/TestShellMac.mm:
1840         (platformInit):
1841         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
1842         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
1843         (+[FakeActiveWindow alwaysActiveWindow]):
1844         (+[FakeActiveWindow alwaysInactiveWindow]):
1845         (-[FakeActiveWindow initWithActiveControls:]):
1846         (-[FakeActiveWindow _hasActiveControls]):
1847         (WebThemeEngineDRTMac::paintScrollbarThumb):
1848         (stateToHIEnableState):
1849         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
1850         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
1851
1852 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
1853
1854         Reviewed by David Kilzer.
1855
1856         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
1857         used
1858         https://bugs.webkit.org/show_bug.cgi?id=51672
1859
1860         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
1861         with USE_SYSTEM_MALLOC=1
1862         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
1863         with USE_SYSTEM_MALLOC=1
1864
1865 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1866
1867         Reviewed by David Kilzer.
1868
1869         [Qt] [Symbian] Fix build-webkit script for Symbian
1870         https://bugs.webkit.org/show_bug.cgi?id=51509
1871
1872         Set the OUTPUT_DIR for Symbian to be the same as the source
1873         directory.
1874
1875         * Scripts/webkitdirs.pm:
1876
1877 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
1878
1879         Reviewed by Darin Adler.
1880
1881         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
1882         https://bugs.webkit.org/show_bug.cgi?id=51758
1883
1884         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
1885
1886         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
1887         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
1888
1889 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
1890
1891         Unreviewed WinCE buildfix.
1892
1893         * WinCELauncher/main.cpp: Add missing include.
1894
1895 2010-12-29  Daniel Bates  <dbates@rim.com>
1896
1897         Reviewed by Darin Adler.
1898
1899         svn-apply updates date of wrong change log entry for a change log diff that
1900         contains two consecutive entries with the same author and date
1901         https://bugs.webkit.org/show_bug.cgi?id=46061
1902
1903         Fixes an issue where the date of the wrong change log entry may be modified.
1904         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
1905         in a ChangeLog file to the top of the file.
1906
1907         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
1908         diff when it detects that the diff inserts a change log entry earlier in a
1909         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
1910         change. With the advent of the commit-queue this functionality of bailing out
1911         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
1912         Instead, we should always move the change log entry to the top of the ChangeLog file.
1913
1914         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
1915         the date line of the correct change log entry in a ChangeLog diff.
1916
1917         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
1918
1919         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
1920           Updated the following unit tests now that we move entries inserted earlier to the top:
1921           - "fixChangeLogPatch: New entry inserted in middle."
1922             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
1923
1924           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
1925             (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
1926
1927         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
1928
1929 2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>
1930
1931         Reviewed by Eric Seidel.
1932
1933         [Qt] Fixed compatibility with gold linker on X11 platforms
1934         https://bugs.webkit.org/show_bug.cgi?id=51700
1935
1936         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1937         Linked TestNetscapePlugin with libX11 on Unix platforms
1938
1939 2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
1940
1941         Reviewed by Darin Adler.
1942
1943         Circular dependency in webkitpy.common.checkout.changelog module
1944         https://bugs.webkit.org/show_bug.cgi?id=50475
1945
1946         Remove automatic import of api.Checkout module when any checkout/
1947         submodule is imported (e.g.: when checkout.scm.Git is imported).
1948
1949         * Scripts/webkitpy/common/checkout/__init__.py:
1950
1951 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
1952
1953         Reviewed by Ojan Vafai.
1954
1955         prepare-ChangeLog should support the -g option for specifying the git-commit
1956         https://bugs.webkit.org/show_bug.cgi?id=51708
1957
1958         Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
1959         webkit-patch, though the exact meaning of the two options remain different.
1960
1961         * Scripts/prepare-ChangeLog: Add -g.
1962
1963 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
1964
1965         Reviewed by Simon Hausmann.
1966
1967         [Qt] Fix compilation with Qt in namespace
1968         https://bugs.webkit.org/show_bug.cgi?id=51701
1969
1970         * QtTestBrowser/webview.h:
1971
1972 2010-12-28  Daniel Bates  <dbates@rim.com>
1973
1974         Reviewed by Sam Weinig.
1975
1976         Substitute // MARK: for compiler-specific #pragma mark
1977         https://bugs.webkit.org/show_bug.cgi?id=51657
1978
1979         Fix future compilation warnings about "#pragma mark" on GTK+ bots by
1980         substituting  "// MARK:" for "#pragma mark", which provides
1981         analogous code-bookmarking functionality under Xcode.
1982
1983         Also, for consistency, we should substitute "// MARK:" for compiler-
1984         specific "#pragma mark" in the source files for the Mac port.
1985
1986         * DumpRenderTree/AccessibilityTextMarker.cpp:
1987         * DumpRenderTree/cf/WebArchiveDumpSupport.h:
1988         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
1989         * DumpRenderTree/mac/ObjCController.m:
1990         * MiniBrowser/mac/AppDelegate.m:
1991         * MiniBrowser/mac/BrowserWindowController.m:
1992
1993 2010-12-28  Xan Lopez  <xlopez@igalia.com>
1994
1995         Reviewed by Eric Seidel.
1996
1997         Add --no-build option to run-sunspider
1998         https://bugs.webkit.org/show_bug.cgi?id=51658
1999
2000         * Scripts/run-sunspider: add --no-build flag to skip building
2001         phase.
2002
2003 2010-12-27  Daniel Bates  <dbates@rim.com>
2004
2005         Rubber-stamped by Martin Robinson.
2006
2007         Append the directory Tools/DumpRenderTree to the list of directories that
2008         do-webcore-rename should search so that it can rename DRT files and
2009         source code.
2010
2011         * Scripts/do-webcore-rename:
2012
2013 2010-12-27  Eric Seidel  <eric@webkit.org>
2014
2015         Reviewed by Adam Barth.
2016
2017         build-webkit should detect missing Java SDK and explain how to install it
2018         https://bugs.webkit.org/show_bug.cgi?id=51651
2019
2020         * Scripts/build-webkit:
2021
2022 2010-12-26  Martin Robinson  <mrobinson@igalia.com>
2023
2024         Reviewed by Daniel Bates.
2025
2026         [GTK] Add support for build-jsc
2027         https://bugs.webkit.org/show_bug.cgi?id=51625
2028
2029         Add GTK+ support to build-jsc now that building the jsc executable as
2030         a standalone target is easy.
2031
2032         * Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
2033         * Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
2034         * Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject
2035         and pass it along to buildAutotoolsProject.
2036
2037 2010-12-27  David Levin  <levin@chromium.org>
2038
2039         Reviewed by Eric Seidel.
2040
2041         check-webkit-style check for meaningless variable names in function declarations.
2042         https://bugs.webkit.org/show_bug.cgi?id=51523
2043
2044         * Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp
2045         from the new check and whitespace/parens because the syntax is unusual and
2046         produced a fair number of positives for these checks.
2047         * Scripts/webkitpy/style/checkers/cpp.py:
2048         (_convert_to_lower_with_underscores): Used as a canonical form for type names
2049         and parameter names when determining if the parameter name is useless.
2050         (_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
2051         (Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
2052         format.
2053         (_check_parameter_name_against_text):  Checks to see if the parameter name is in the
2054         text or an acronym of it.
2055         (check_function_definition): Checks function definitions for meaningless variable names.
2056         (process_line): Added call to check_function_definition.
2057         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2058         (CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
2059         (CppFunctionsTest.test_create_acronym): Test for _create_acronym.
2060         (CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
2061         (CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
2062         because when only checking a snippet, there are a lot of bogus functions.
2063         (CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
2064         that I put there previously and just noticed.
2065         (WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
2066         check_function_definition and process_line.
2067
2068 2010-12-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2069
2070         Reviewed by Martin Robinson.
2071
2072         [GTK] Disable flash plugin in GtkLauncher when using gtk3
2073         https://bugs.webkit.org/show_bug.cgi?id=51591
2074
2075         Flash plugin uses gtk2 that is incompatible with gtk3 making
2076         webkit crash when it's built with gtk3.
2077
2078         * GtkLauncher/main.c:
2079         (main):
2080
2081 2010-12-25  Adam Barth  <abarth@webkit.org>
2082
2083         Reviewed by Eric Seidel.
2084
2085         Move ANGLE to Sources/ThirdParty
2086         https://bugs.webkit.org/show_bug.cgi?id=51605
2087
2088         * Scripts/build-webkit:
2089           - Point to the new ANGLE location.
2090
2091 2010-12-26  David Levin  <levin@chromium.org>
2092
2093         Reviewed by Eric Seidel.
2094
2095         check-webkit-style should be able to parse function declaration parameters.
2096         https://bugs.webkit.org/show_bug.cgi?id=51451
2097
2098         * Scripts/webkitpy/style/checkers/cpp.py:
2099         (Position.__init__): Holds simple position information (row, column).
2100         (Parameter.__init__): Holds information about a parameter.
2101         (SingleLineView.__init): Converts multiple lines into a single line for simpler searches.
2102         (SingleLineView.convert_column_to_row): Returns the original row given a column.
2103         (create_skeleton_parameters): Simplifies a parameter list for easier searching.
2104         (find_parameter_name_index): Finds where the parameter name is.
2105         (parameter_list): Generates the list of parameters for a function.
2106         (_FunctionState.begin): Added information to allow determining the parameters
2107         on demand.
2108         (_FunctionState.get_parameter_list): Returns a tuple of function parameters.
2109         (detect_functions): Improve function detection for operator functions and
2110         determine where the parameters end and pass that to _FunctionState.begin.
2111         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2112         (CppFunctionsTest.test_parameter): Verifies Parameter functionality.
2113         (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality.
2114         (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters.
2115         (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index.
2116         (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list.
2117         Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list.
2118         (FunctionDetectionTest.perform_function_detection): Added support for verifying
2119         the parameters found.
2120         (FunctionDetectionTest.test_function_declaration_detection): Added more function
2121         detection test to verify that we catch the operator functions.
2122         (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros.
2123         (FunctionDetectionTest.test_parameter_list): Added tests to verify the parameter parsing.
2124         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Removed
2125         because the error. The test is about the bad function name. Fixing the name makes the test exactly like
2126         test_function_length_check_definition_severity1_for_test.
2127
2128 2010-12-25  Patrick Gansterer  <paroga@webkit.org>
2129
2130         Unreviewed WinCE buildfix after r74334.
2131
2132         * CMakeListsWinCE.txt:
2133
2134 2010-12-24  Sheriff Bot  <webkit.review.bot@gmail.com>
2135
2136         Unreviewed, rolling out r74632.
2137         http://trac.webkit.org/changeset/74632
2138         https://bugs.webkit.org/show_bug.cgi?id=51600
2139
2140         makes test-webkitpy hang forever on GTK (Requested by philn-tp
2141         on #webkit).
2142
2143         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2144         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2145
2146 2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>
2147
2148         Reviewed by Kenneth Rohde Christiansen.
2149
2150         [EFL] Screen doesn't be rendered when changing size of EWebLauncher
2151         https://bugs.webkit.org/show_bug.cgi?id=43528
2152
2153         Remove on_resize because ewk_view_fixed_layout_size_set should not be
2154         called on callback of EVAS_CALLBACK_RESIZE. As it change size of
2155         FrameView, rendering was ignored when _ewk_view_smart_calculate was
2156         called.
2157
2158         * EWebLauncher/main.c:
2159         (browserCreate):
2160
2161 2010-12-24  Eric Seidel  <eric@webkit.org>
2162
2163         Reviewed by Adam Barth.
2164
2165         webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
2166         https://bugs.webkit.org/show_bug.cgi?id=28291
2167
2168         This is a start.  At least now webkit-patch will prompt when your ChangeLog looks questionable.
2169         We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
2170         to strings with find in the diff.
2171         Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.
2172
2173         * Scripts/webkitpy/common/checkout/api.py:
2174         * Scripts/webkitpy/common/checkout/diff_parser.py:
2175         * Scripts/webkitpy/tool/steps/abstractstep.py:
2176         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
2177         * Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
2178         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
2179         * Scripts/webkitpy/tool/steps/validatereviewer.py:
2180
2181 2010-12-24  Dirk Pranke  <dpranke@chromium.org>
2182
2183         Reviewed by Kenneth Russell.
2184
2185         Modify new-run-webkit-tests to shut up and exit when all the threads
2186         are wedged so that test runs complete faster and we don't end up
2187         w/ enormous log files.
2188
2189         https://bugs.webkit.org/show_bug.cgi?id=51572
2190
2191         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2192         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2193
2194 2010-12-24  Eric Seidel  <eric@webkit.org>
2195
2196         Reviewed by David Levin.
2197
2198         commit-queue should better explain how it will re-open bugs and follow duplicate chains
2199         https://bugs.webkit.org/show_bug.cgi?id=51549
2200
2201         I've had multiple people ask me about the commit-queue's behavior
2202         regarding reporting flaky tests.  I figured it would be best to just
2203         have the queue explain itself in the bugs it files.
2204
2205         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2206         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2207
2208 2010-12-24  Shinichiro Hamaji  <hamaji@chromium.org>
2209
2210         Reviewed by Eric Seidel.
2211
2212         check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt
2213         https://bugs.webkit.org/show_bug.cgi?id=51467
2214
2215         * Scripts/webkitpy/style/checker.py:
2216         * Scripts/webkitpy/style/checker_unittest.py:
2217
2218 2010-12-23  Adam Barth  <abarth@webkit.org>
2219
2220         Rubber-stamped by Eric Seidel.
2221
2222         Move JavaScriptGlue into Sources
2223         https://bugs.webkit.org/show_bug.cgi?id=51583
2224
2225         These tools refer to JavaScriptGlue and need to be updated to its new
2226         location.
2227
2228         * Scripts/build-webkit:
2229         * Scripts/do-file-rename:
2230         * Scripts/do-webcore-rename:
2231         * Scripts/webkitpy/common/config/build.py:
2232         * Scripts/webkitpy/common/config/build_unittest.py:
2233
2234 2010-12-23  Lucas Forschler  <lforschler@apple.com>
2235
2236         Reviewed by Eric Seidel.
2237
2238         Bug 51539 - update iexploder scripts to point to new location
2239
2240         * Scripts/run-iexploder-tests:
2241         * Scripts/update-iexploder-cssproperties:
2242
2243 2010-12-23  Evan Martin  <evan@chromium.org>
2244
2245         Reviewed by Ryosuke Niwa.
2246
2247         [chromium] LayoutTestController warning in float->int conversion
2248         https://bugs.webkit.org/show_bug.cgi?id=51553
2249
2250         Rather than reading an int, converting to a float, then getting a compiler
2251         warning on passing the float to something that expects an int, instead
2252         just pass around ints.
2253
2254         No tests, fixes a compiler warning.
2255
2256         * DumpRenderTree/chromium/LayoutTestController.cpp:
2257         (parsePageSizeParameters):
2258         (LayoutTestController::pageNumberForElementById):
2259         (LayoutTestController::numberOfPages):
2260
2261 2010-12-23  Lucas Forschler  <lforschler@apple.com>
2262
2263         Reviewed by Darin Adler.
2264
2265         Bug 51537 - iexploder needs cleanup
2266         
2267         * iExploder/htdocs: Removed.
2268         * iExploder/htdocs/config.rb: Removed.
2269         * iExploder/htdocs/cssproperties.in: Removed.
2270         * iExploder/htdocs/cssvalues.in: Removed.
2271         * iExploder/htdocs/htmlattrs.in: Removed.
2272         * iExploder/htdocs/htmltags.in: Removed.
2273         * iExploder/htdocs/htmlvalues.in: Removed.
2274         * iExploder/htdocs/iexploder.cgi: Removed.
2275         * iExploder/htdocs/iexploder.rb: Removed.
2276         * iExploder/htdocs/index.html: Removed.
2277         * iExploder/htdocs/webserver.rb: Removed.
2278         * iExploder/iexploder-1.7.2/output: Removed.
2279         * iExploder/tools: Removed.
2280         * iExploder/tools/lasthit.rb: Removed.
2281         * iExploder/tools/osx_last_crash.rb: Removed.
2282         * iExploder/tools/showtest.rb: Removed.
2283
2284 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2285
2286         Reviewed by Kenneth Rohde Christiansen.
2287
2288         [EFL] Make 'single' the default backing store in EWebLauncher
2289         https://bugs.webkit.org/show_bug.cgi?id=51534
2290
2291         'single' is the simplest backing store and the one intended to be the
2292         default in the test browser. By mistake the tiled backing store was
2293         left as default in r72617.
2294
2295         * EWebLauncher/main.c:
2296         (browserCreate): ditto.
2297
2298 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2299
2300         Reviewed by Kenneth Rohde Christiansen.
2301
2302         [EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround
2303         https://bugs.webkit.org/show_bug.cgi?id=51533
2304
2305         There's no point in concatenating env("HOME") with "blah", so remove
2306         option from EWebLauncher.
2307
2308         * EWebLauncher/main.c:
2309         (main): ditto.
2310
2311 2010-12-23  Ilya Tikhonovsky  <loislo@chromium.org>
2312
2313         Reviewed by Eric Seidel.
2314
2315         Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).
2316
2317         Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
2318         I just discovered that we have two additional GC runs per each WebViewHost.
2319         Test_shell had no such calls.
2320         These gc runs eat 15% of cpu time.
2321
2322         https://bugs.webkit.org/show_bug.cgi?id=51479
2323
2324         * DumpRenderTree/chromium/WebViewHost.cpp:
2325         (WebViewHost::~WebViewHost):
2326
2327 2010-12-22  Dirk Pranke  <dpranke@chromium.org>
2328
2329         Reviewed by Ojan Vafai.
2330
2331         This change splits out the TestRunner class into its own file.
2332         When we fork the code for message passing, we will create a new
2333         TestRunner, and this change will allow that to be more modular.
2334
2335         While we're at it, split out TestInput and ResultSummary into
2336         their own files, to reduce the size of run_webkit_tests to
2337         something more managable.
2338
2339         https://bugs.webkit.org/show_bug.cgi?id=51092
2340
2341         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2342         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
2343         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2344         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
2345         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
2346         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2347         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2348
2349  2010-12-22  Dirk Pranke  <dpranke@chromium.org>
2350
2351         Reviewed by Ojan Vafai.
2352
2353         nrwt multiprocessing - start over, prepare to fork the code
2354  
2355         This code cleans up the signatures and implementation of the
2356         TestRunner class so we can easily fork it to run either the
2357         stable implementation or the new, unstable message-passing
2358         implementation. The two variants will have different
2359         implementations of the run_tests() method. We will switch
2360         between the two based on the setting for the '--worker-model'
2361         switch. We rename the two currently valid values to 'old-inline'
2362         and 'old-threads'.
2363
2364         https://bugs.webkit.org/show_bug.cgi?id=51081
2365
2366         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2367         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2368
2369 2010-12-22  Victor Wang  <victorw@chromium.org>
2370
2371         Reviewed by Darin Fisher.
2372
2373         [Chromium] Update chromium archive test result url in rebaseline script.
2374
2375         https://bugs.webkit.org/show_bug.cgi?id=51503
2376
2377         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2378
2379 2010-12-22  Lucas Forschler  <lforschler@apple.com>
2380
2381         Reviewed by Alice Liu.
2382
2383         <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
2384         Verified on Chrome, Safari, and IE.
2385         With this change, we will record memory from a parent browser window and all child processes.
2386
2387         * record-memory-win/main.cpp:
2388         (ProcessArgs):
2389         (PrintUsage):
2390         (getMemoryInfo):
2391         (printProcessInfo):
2392         (evalProcesses):
2393         (UseImage):
2394         (QueryContinuously):
2395         (ElapsedTime):
2396
2397 2010-12-22  Lucas Forschler  <lforschler@apple.com>
2398
2399         Unreviewed rollout r74489, because it was missing changelog.
2400
2401         * record-memory-win/main.cpp:
2402         
2403 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
2404
2405         Adding myself as a reviewer.
2406
2407         * Scripts/webkitpy/common/config/committers.py:
2408
2409 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
2410
2411         Unreviewed.  Adding myself to committers.py.
2412
2413         * Scripts/webkitpy/common/config/committers.py:
2414
2415 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
2416
2417         Reviewed by Kenneth Rohde Christiansen.
2418
2419         TestNetscapePlugIn should use #if defined
2420         https://bugs.webkit.org/show_bug.cgi?id=51471
2421
2422         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2423         (NP_Initialize):
2424         (NPP_New):
2425
2426 2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
2427
2428         Reviewed by Yury Semikhatsky.
2429
2430         Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
2431
2432         DevTools window should be closed explicitly because it has custom deinitialization code.
2433
2434         https://bugs.webkit.org/show_bug.cgi?id=50722
2435
2436         * DumpRenderTree/chromium/TestShell.cpp:
2437         (TestShell::closeRemainingWindows):
2438
2439 2010-12-22  David Levin  <levin@chromium.org>
2440
2441         Reviewed by Shinichiro Hamaji.
2442
2443         check-webkit-style shouldn't complaint about underscores in variables in objective C files.
2444         https://bugs.webkit.org/show_bug.cgi?id=51452
2445
2446         * Scripts/webkitpy/style/checkers/cpp.py:
2447         (_FileState.__init__): Added the information to determine if a file is C or Objective C.
2448         Using the file extension if possible but falling back to the file contents if we have a header file.
2449         (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
2450         (_FileState.is_c_or_objective_c):
2451         (check_using_std): Changed to using _FileState to determine the file type.
2452         (check_max_min_macros): Ditto.
2453         (check_for_null): Ditto.
2454         (check_style): Changed the parameters to various calls since they now need _FileState
2455         to determine the file type.
2456         (check_language): Added the file_state parameter so it could be passed
2457         to check_identifier_name_in_declaration.
2458         (check_identifier_name_in_declaration): Don't warn about underscores in variables if
2459         this is an Objective C file.
2460         (_process_lines): Added information for the _FileState constructor (and moved the
2461         call to a place that had the information).
2462         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2463         (CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
2464         its functionality.
2465         (WebKitStyleTest.test_names): Add tests for underscores in Objective C files.
2466
2467 2010-12-21  Andy Estes  <aestes@apple.com>
2468
2469         Reviewed by Mark Rowe.
2470
2471         Do not build non-Intel architectures for WebKit2-related projects.
2472         https://bugs.webkit.org/show_bug.cgi?id=51440
2473
2474         * MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64.
2475         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
2476         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
2477
2478 2010-12-21  Mihai Parparita  <mihaip@chromium.org>
2479
2480         Reviewed by Darin Fisher.
2481
2482         [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
2483         https://bugs.webkit.org/show_bug.cgi?id=51406 
2484         
2485         Rename WebThemeControlDRT to WebThemeControlDRTWin and WebThemeEngineDRT
2486         to WebThemeEngineDRTWin and update references everywhere.
2487
2488         * DumpRenderTree/DumpRenderTree.gypi:
2489         * DumpRenderTree/chromium/TestShellWin.cpp:
2490         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.cpp.
2491         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.h.
2492         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp.
2493         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.h.
2494
2495 2010-12-21  Anders Carlsson  <andersca@apple.com>
2496
2497         Reviewed by John Sullivan.
2498
2499         Clicking missing plug-in text does not show a sheet
2500         https://bugs.webkit.org/show_bug.cgi?id=51403
2501
2502         Update for changes to the WebPageUIClient.
2503
2504         * MiniBrowser/mac/BrowserWindowController.m:
2505         (-[BrowserWindowController awakeFromNib]):
2506         * WebKitTestRunner/TestController.cpp:
2507         (WTR::createOtherPage):
2508         (WTR::TestController::initialize):
2509
2510 2010-12-21  Eric Seidel  <eric@webkit.org>
2511
2512         Reviewed by Adam Barth.
2513
2514         commit-queue will report constant failures as flaky if other tests flake
2515         https://bugs.webkit.org/show_bug.cgi?id=51272
2516
2517         This patch just removes functionality and adds testing.
2518         Previously we attempted to report flaky tests when we had
2519         two different tests fail in a row.  However, since we stop
2520         running the tests at the first failure, our code was wrong in
2521         trying to determine flakiness from the incomplete runs.
2522
2523         Originally I posted an alternate patch:
2524         https://bug-51272-attachments.webkit.org/attachment.cgi?id=77078
2525         which fixed our flaky logic in this case, however it was decided
2526         that that patch would be too difficult to maintain, so now
2527         I'm just removing the broken logic.
2528
2529         This will dramatically cut-down on our flaky-test false positives
2530         at the (small) cost of the queues being unable to report
2531         any flakiness if the tree is very flaky.  (With at least one test
2532         flaking on every run, we'll never report failures anymore.)  I think
2533         this is a tradeoff worth making.
2534
2535         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2536         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2537
2538 2010-12-20  Eric Seidel  <eric@webkit.org>
2539
2540         Reviewed by Adam Barth.
2541
2542         commit-queue wrongly rejects patches when it can't update itself
2543         https://bugs.webkit.org/show_bug.cgi?id=46636
2544
2545         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2546         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2547         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2548
2549 2010-12-20  Adam Barth  <abarth@webkit.org>
2550
2551         Move web sites to Websites directory
2552         https://bugs.webkit.org/show_bug.cgi?id=51323
2553
2554         Update references to BugsSite to point to the new location.
2555
2556         This patch was never officially reviewed (because it was too large to
2557         upload to bugs.webkit.org), but it was discussed on webkit-dev and Mark
2558         Rowe gave me the green light.
2559
2560         * Scripts/old-run-webkit-tests:
2561         * Scripts/webkitpy/common/config/build.py:
2562         * Scripts/webkitpy/common/config/build_unittest.py:
2563         * Scripts/webkitpy/common/prettypatch.py:
2564         * Scripts/webkitpy/layout_tests/port/base.py:
2565         * Scripts/webkitpy/style/main.py:
2566
2567 2010-12-20  Adrienne Walker  <enne@google.com>
2568
2569         Unreviewed. Adding myself to the list of committers.
2570
2571         * webkitpy/common/config/committers.py:
2572
2573 2010-12-20  Mark Rowe  <mrowe@apple.com>
2574
2575         Reviewed by Dan Bernstein.
2576
2577         <rdar://problem/8757601> Don't install header files in to the Resources directory.
2578
2579         * Scripts/check-for-inappropriate-files-in-framework: Don't allow .h files in the
2580         Resources directory.
2581
2582 2010-12-20  Eric Seidel  <eric@webkit.org>
2583
2584         Reviewed by Adam Barth.
2585
2586         commit-queue should include bot id when attaching failure diffs
2587         https://bugs.webkit.org/show_bug.cgi?id=51280
2588
2589         This is a tiny change to include the bot id in the name of the attachment.
2590         Most of this diff is just changing the unit test expectations
2591         now that I hid the comment printing when the comment is None.
2592
2593         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2594         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2595         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2596         * Scripts/webkitpy/tool/mocktool.py:
2597
2598 2010-12-20  Jeff Miller  <jeffm@apple.com>
2599
2600         Reviewed by Dan Bernstein.
2601
2602         Tools/vcbin/midl.exe needs to be rebuilt
2603         https://bugs.webkit.org/show_bug.cgi?id=51347
2604
2605         * vcbin/midl.exe: Rebuilt.
2606
2607 2010-12-20  David Levin  <levin@chromium.org>
2608
2609         Reviewed by Ariya Hidayat.
2610
2611         .gitignore and webkit-tools-completion.sh have references to WebKitTools that should be Tools.
2612         https://bugs.webkit.org/show_bug.cgi?id=51343
2613
2614         Follow up from the WebKitTools -> Tools rename.
2615
2616         * Scripts/webkit-tools-completion.sh:
2617
2618 2010-12-20  Cosmin Truta  <ctruta@chromium.org>
2619
2620         Reviewed by James Robinson.
2621
2622         new-run-webkit-tests ignores trailing EOL differences in text tests
2623         https://bugs.webkit.org/show_bug.cgi?id=36983
2624
2625         Changed the handling of new-line characters within new-run-webkit-tests
2626         to match old-run-webkit-tests.  Differences in leading and trailing empty
2627         lines in text expectation files are no longer ignored.
2628
2629         * Scripts/webkitpy/layout_tests/port/base.py:
2630         * Scripts/webkitpy/layout_tests/port/test.py:
2631         Added unit tests.  Removed old duplicate unit test entries.
2632         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2633
2634 2010-12-20  David Levin  <levin@chromium.org>
2635
2636         Reviewed by Shinichiro Hamaji.
2637
2638         check-webkit-style should detect function declarations (and trivial functions).
2639         https://bugs.webkit.org/show_bug.cgi?id=51303
2640
2641         * Scripts/webkitpy/style/checkers/cpp.py:
2642         (_FunctionState.begin): Add is_declaration and changed the line count
2643         start to begin at -1 (which will keep the results consistent, since
2644         the starting line number passed in is one less in this change).
2645         (detect_functions): changed function detection to now catch trivial
2646         functions and declarations.
2647         (check_pass_ptr_usage): Don't check for Pass*Ptr on the first line
2648         of the function as this may look at return values (when processing
2649         a declaration).
2650         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2651         (FunctionDetectionTest.perform_function_detection): Basic mechanics
2652         of testing the function detection.
2653         (FunctionDetectionTest.test_basic_function_detection): Test a simple
2654         function.
2655         (FunctionDetectionTest.test_function_declaration_detection): Test a
2656         declaration.
2657         (FunctionDetectionTest.test_non_functions): A test case for a case
2658         that caused the code to fail due to the { being in quotes.
2659         (PassPtrTest.test_pass_ref_ptr_return_value): Added some more test
2660         cases to help catch false alarms for return values.
2661         (PassPtrTest.test_pass_ref_ptr_member_variable): Ensure that
2662         we don't get false alarms for member variables either.
2663
2664 2010-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
2665
2666         Reviewed by Antonio Gomes.
2667
2668         [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR
2669         https://bugs.webkit.org/show_bug.cgi?id=51319
2670
2671         * CMakeListsEfl.txt:
2672
2673 2010-12-18  Adam Barth  <abarth@webkit.org>
2674
2675         Reviewed by Sam Weinig.
2676
2677         Move WebKitExamplePlugins to Examples
2678         https://bugs.webkit.org/show_bug.cgi?id=51291
2679
2680         * Scripts/webkitpy/common/config/build.py:
2681
2682 2010-12-17  Csaba Osztrogonác  <ossy@webkit.org>
2683
2684         Unreviewed Qt buildfix after r74301.
2685
2686         Rename WebKitTools to Tools
2687         https://bugs.webkit.org/show_bug.cgi?id=49861
2688
2689         * MiniBrowser/DerivedSources.pro:
2690         * MiniBrowser/qt/MiniBrowser.pro:
2691
2692 2010-12-17  Dan Bernstein  <mitz@apple.com>
2693
2694         Reviewed by Simon Fraser.
2695
2696         Rename WebKitTools to Tools
2697         https://bugs.webkit.org/show_bug.cgi?id=49861
2698
2699         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2700         * CodeCoverage/README:
2701         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2702         (WebCore::DumpRenderTree::initializeFonts):
2703         * EWSTools/start-commit-queue.sh:
2704         * EWSTools/start-queue.sh:
2705         * GNUmakefile.am:
2706         * MIDLWrapper/MIDLWrapper.cpp:
2707         (wmain):
2708         * MiniBrowser/qt/MiniBrowser.pro:
2709         * Scripts/build-api-tests:
2710         * Scripts/build-dumprendertree:
2711         * Scripts/build-webkit:
2712         * Scripts/build-webkittestrunner:
2713         * Scripts/generate-coverage-data:
2714         * Scripts/old-run-webkit-tests:
2715         * Scripts/run-api-tests:
2716         * Scripts/run-iexploder-tests:
2717         * Scripts/run-javascriptcore-tests:
2718         * Scripts/run-mangleme-tests:
2719         * Scripts/run-sunspider:
2720         * Scripts/run-webkit-websocketserver:
2721         * Scripts/sunspider-compare-results:
2722         * Scripts/test-webkitperl:
2723         * Scripts/test-webkitpy:
2724         * Scripts/update-iexploder-cssproperties:
2725         * Scripts/update-webkit:
2726         * Scripts/update-webkit-localizable-strings:
2727         * Scripts/webkitdirs.pm:
2728         * Scripts/webkitpy/common/checkout/scm.py:
2729         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2730         * Scripts/webkitpy/common/config/committervalidator.py:
2731         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
2732         * Scripts/webkitpy/common/config/ports.py:
2733         * Scripts/webkitpy/common/config/ports_unittest.py:
2734         * Scripts/webkitpy/common/system/logutils_unittest.py:
2735         * Scripts/webkitpy/common/system/ospath_unittest.py:
2736         * Scripts/webkitpy/layout_tests/port/chromium.py:
2737         * Scripts/webkitpy/layout_tests/port/config.py:
2738         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2739         * Scripts/webkitpy/layout_tests/port/http_server.py:
2740         * Scripts/webkitpy/layout_tests/port/test.py:
2741         * Scripts/webkitpy/style/checker.py:
2742         * Scripts/webkitpy/style/checker_unittest.py:
2743         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
2744         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2745         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2746         * WebKitTestRunner/DerivedSources.pro:
2747         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2748         (WTR::activateFonts):
2749         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2750         * wx/build/build_utils.py:
2751
2752 2010-12-16  Antonio Gomes  <agomes@rim.com>
2753
2754         Reviewed by Martin Robinson.
2755
2756         Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
2757         https://bugs.webkit.org/show_bug.cgi?id=51163
2758
2759         Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
2760         GTK+'s DRT should also reset to UNIX after each test execution.
2761
2762         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2763         (resetDefaultsToConsistentValues):
2764
2765 2010-12-17  David Levin  <levin@chromium.org>
2766
2767         Reviewed by Eric Seidel.
2768
2769         check-webkit-style should understand WTF #include guards
2770         https://bugs.webkit.org/show_bug.cgi?id=44911
2771
2772         * Scripts/webkitpy/style/checkers/cpp.py:
2773         (get_header_guard_cpp_variable): modify to suggest the WTF style
2774         of header guard when appropriate.
2775         (check_for_header_guard): handle multiple return values from
2776         get_header_guard_cpp_variable
2777         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2778         (CppStyleTest.test_build_header_guard): Added tests for the WTF
2779         header style.
2780
2781 2010-12-16  David Levin  <levin@chromium.org>
2782
2783         Reviewed by Eric Seidel.
2784
2785         test-webkitpy: unittest for the xml.py checker displays a decprecation warning.
2786         https://bugs.webkit.org/show_bug.cgi?id=51210
2787
2788         The error only shows up when using python 2.6 or later.
2789
2790         * Scripts/webkitpy/style/checkers/xml.py: Replace the usage of
2791         the decprecated field error,message with something equivalent.
2792
2793 2010-12-16  Mihai Parparita  <mihaip@chromium.org>
2794
2795         Reviewed by Eric Seidel.
2796
2797         Add --exit-after-n-failures/crashes to NRWT
2798         https://bugs.webkit.org/show_bug.cgi?id=51160
2799         
2800         Abort test run (in a similar way to how control-C is handled) when
2801         --exit-after-n-failures/crashes-or-timeouts are passed and we've reached
2802         that number of unexpected failures/crashes/timeouts.
2803
2804         * Scripts/webkitpy/layout_tests/port/test.py:
2805         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2806         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2807
2808 2010-12-16  David Levin  <levin@chromium.org>
2809
2810         Reviewed by Shinichiro Hamaji.
2811
2812         check-webkit-style unit tests has some duplicate boilerplate code.
2813         https://bugs.webkit.org/show_bug.cgi?id=49519
2814
2815         * Scripts/webkitpy/style/checkers/cpp.py:
2816         (update_include_state): Replaced the "io" parameter with the global
2817         configuration _unit_test_config. This allowed not calling into
2818         functions at a low level and also not plumbing through the injection
2819         information through many levels of code.
2820         (check_for_include_what_you_use): Ditto.
2821         (process_file_data): Added the ability to set up the unit test config
2822         to allow for injection.
2823         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2824         (ErrorCollector.__init__): Added support for having a filter for errors.
2825         (ErrorCollector.__call__): Ditto.
2826         (CppStyleTestBase.process_file_data): Added the ability to set unit_test_config.
2827         (CppStyleTestBase.perform_lint): Consolidated logic for the perform functions.
2828         (CppStyleTestBase.perform_single_line_lint): Replace specific calls to
2829         functions in the cpp.py with generic processing and a filter that
2830         indicates what errors should be kept.
2831         (CppStyleTestBase.perform_multi_line_lint): Ditto.
2832         (CppStyleTestBase.perform_language_rules_check): Ditto.
2833         (CppStyleTestBase.perform_function_lengths_check): Ditto.
2834         (CppStyleTestBase.perform_pass_ptr_check): Ditto.
2835         (CppStyleTestBase.perform_include_what_you_use): Ditto.
2836         (CppStyleTest.test_multi_line_comments): Added another
2837         error message which applies to the test case.
2838         (CppStyleTest.test_spacing_for_binary_ops): Fixed test
2839         to not have config.h, since it is processed as a header file.
2840         (CppStyleTest.test_static_or_global_stlstrings): Fixed variable name
2841         style and indentation in checked code.
2842         (OrderOfIncludesTest.test_check_preprocessor_in_include_section):
2843         Fixed line number.
2844         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
2845         Ditto.
2846
2847 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
2848
2849         Unreviewed, rolling out r74136.
2850         http://trac.webkit.org/changeset/74136
2851         https://bugs.webkit.org/show_bug.cgi?id=51135
2852
2853         r74136 breaks chromium canary bots because some tests are not
2854         rebaselined correctly to resolve EOL differences (Requested by
2855         jianli on #webkit).
2856
2857         * Scripts/webkitpy/layout_tests/port/base.py:
2858         * Scripts/webkitpy/layout_tests/port/test.py:
2859         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2860
2861 2010-12-15  Adam Roben  <aroben@apple.com>
2862
2863         Teach check-webkit-style to check .vcproj and .vsprops files for XML
2864         syntax errors
2865
2866         Fixes <http://webkit.org/b/51103> check-webkit-style should check for
2867         XML syntax errors in .vcproj/.vsprops files
2868
2869         Reviewed by Dave Levin.
2870
2871         * Scripts/webkitpy/style/checker.py: Added lists of file extensions
2872         that should be treated as XML and that should be allowed to contain
2873         carriage returns. (These lists happen to be identical currently.)
2874         (FileType): Added a new XML type.
2875         (CheckerDispatcher.should_check_and_strip_carriage_returns): Added.
2876         Just does a simple file extension check.
2877         (CheckerDispatcher._file_type): Added a case for XML files.
2878         (CheckerDispatcher._create_checker): Ditto. We use XMLChecker for XML
2879         files (surprise!).
2880         (StyleProcessor.process): Ask the dispatcher whether we should pass the
2881         lines through the carriage checker.
2882
2883         * Scripts/webkitpy/style/checker_unittest.py:
2884         (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
2885         Added. Checks a few file names to see if carriage returns are allowed
2886         or not.
2887         (CheckerDispatcherDispatchTest.assert_checker_xml): Added. Similar to
2888         other assert_checker_* functions.
2889         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
2890         test_*_paths functions.
2891         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
2892         test_*_paths functions.
2893         (CheckerDispatcherDispatchTest.test_none_paths): Removed the vcproj
2894         file from this test case, as vcproj files now have a type.
2895         (StyleProcessor_CodeCoverageTest.MockDispatcher.should_check_and_strip_carriage_returns):
2896         Added. Similar to the other should_* functions.
2897         (StyleProcessor_CodeCoverageTest.test_process__carriage_returns_not_stripped):
2898         Added. Checks that carriage returns aren't checked for or stripped for
2899         allowed files.
2900
2901         * Scripts/webkitpy/style/checkers/xml.py: Added.
2902         (XMLChecker.__init__): Simple init method.
2903         (XMLChecker.check): Pass each line through the expat parser, and record
2904         a style error for any errors thrown by the parser.
2905
2906         * Scripts/webkitpy/style/checkers/xml_unittest.py: Added.
2907         (XMLCheckerTest.assert_no_error): Checks that the given XML does not
2908         produce a style error.
2909         (XMLCheckerTest.assert_error): Checks that the given XML produces an
2910         error of the given category on the given line.
2911         (XMLCheckerTest.mock_handle_style_error): Does nothing. Used for
2912         checking that the XMLChecker constructor works properly.
2913         (XMLCheckerTest.test_conflict_marker): Tests that conflict markers
2914         cause a style error (see, e.g., r73887).
2915         (XMLCheckerTest.test_extra_closing_tag): Tests that extra closing tags
2916         cause a style error (see, e.g., r73773).
2917         (XMLCheckerTest.test_init): Tests that the XMLChecker constructor works
2918         properly.
2919         (XMLCheckerTest.test_missing_closing_tag): Tests that missing closing
2920         tags cause a style error (see, e.g., r72795).
2921         (XMLCheckerTest.test_no_error): Tests that valid XML does not cause a
2922         style error.
2923
2924 2010-12-15  Lucas Forschler  <lforschler@apple.com>
2925
2926         Reviewed by Stephanie Lewis.
2927
2928         https://bugs.webkit.org/show_bug.cgi?id=51117
2929         Add a new leopard test bot
2930         really really commit to trunk this time.
2931
2932         * BuildSlaveSupport/build.webkit.org-config/config.json:
2933
2934 2010-12-15  Sam Weinig  <sam@webkit.org>
2935
2936         Reviewed by Anders Carlsson.
2937
2938         WebKit2: Can't add files to an <input type=file>
2939         https://bugs.webkit.org/show_bug.cgi?id=51087
2940
2941         * MiniBrowser/mac/BrowserWindowController.m:
2942         (runOpenPanel):
2943         (-[BrowserWindowController awakeFromNib]):
2944         Add simple implementation of runOpenPanel callback.
2945
2946         * MiniBrowser/win/BrowserView.cpp:
2947         (BrowserView::create):
2948         * WebKitTestRunner/TestController.cpp:
2949         (WTR::createOtherPage):
2950         (WTR::TestController::initialize):
2951         Stub out runOpenPanel callback. 
2952
2953 2010-12-14  Eric Seidel  <eric@webkit.org>
2954
2955         Reviewed by Adam Barth.
2956
2957         commit-queue should upload failure diffs when tests flake
2958         https://bugs.webkit.org/show_bug.cgi?id=51051
2959
2960         To make this testable I needed to pipe FileSystem down onto tool.
2961         We've wanted it there for a long time anyway.
2962
2963         This patch is kinda a big hack.  But we don't have a nice
2964         way to read results.html files.  I think this will need further
2965         revision before this code actually feels clean.
2966
2967         As part of testing this change, I had to make MockBugzilla.create_bug
2968         actually return an id (like it should) which required updating
2969         a few other unit test results (for the better).
2970
2971         The results_matching_keys change in layouttestresults/rebasline
2972         was an alternate path which I decided not to use in the end, but
2973         I left the change as it seemed an improvement.
2974
2975         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2976         * Scripts/webkitpy/common/net/layouttestresults.py:
2977         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2978         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2979         * Scripts/webkitpy/tool/commands/queues.py:
2980         * Scripts/webkitpy/tool/commands/rebaseline.py:
2981         * Scripts/webkitpy/tool/main.py:
2982         * Scripts/webkitpy/tool/mocktool.py:
2983
2984 2010-12-15  Cosmin Truta  <ctruta@chromium.org>
2985
2986         Reviewed by James Robinson.
2987
2988         new-run-webkit-tests ignores trailing EOL differences in text tests
2989         https://bugs.webkit.org/show_bug.cgi?id=36983
2990
2991         Changed the handling of new-line characters within new-run-webkit-tests
2992         to match old-run-webkit-tests.  Differences in leading and trailing empty
2993         lines in text expectation files are no longer ignored.
2994
2995         * Scripts/webkitpy/layout_tests/port/base.py:
2996         * Scripts/webkitpy/layout_tests/port/test.py:
2997         Added unit tests.  Removed old duplicate unit test entries.
2998         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2999
3000 2010-12-15  Ojan Vafai  <ojan@chromium.org>
3001
3002         Reviewed by Adam Barth.
3003
3004         make status-bubble white-space:nowrap so we can measure it's width without wrapping
3005         https://bugs.webkit.org/show_bug.cgi?id=51149
3006
3007         * QueueStatusServer/templates/statusbubble.html:
3008
3009 2010-12-15  Ojan Vafai  <ojan@chromium.org>
3010
3011         Reviewed by Adam Barth.
3012
3013         have the statusbubble postMessage it's metrics so that embedders can properly size the iframe
3014         https://bugs.webkit.org/show_bug.cgi?id=51125
3015
3016         * QueueStatusServer/templates/statusbubble.html:
3017
3018 2010-12-15  Darin Adler  <darin@apple.com>
3019
3020         * Scripts/webkitpy/common/net/buildbot: Added property svn:ignore.
3021
3022 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
3023
3024         Unreviewed, rolling out r74117.
3025         http://trac.webkit.org/changeset/74117
3026         https://bugs.webkit.org/show_bug.cgi?id=51113
3027
3028         This broke the GTK1 build. (Requested by mrobinson on
3029         #webkit).
3030
3031         * Scripts/webkitdirs.pm:
3032
3033 2010-12-15  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>
3034
3035         Reviewed by Martin Robinson.
3036
3037         Change generate-forwarding-headers.pl for GTK port usage 
3038         (https://bugs.webkit.org/show_bug.cgi?id=37369)
3039
3040         * Scripts/webkitdirs.pm: Added changes to build webkit2 for GTK port using build-webkit script.
3041
3042 2010-12-14  Kent Tamura  <tkent@chromium.org>
3043
3044         Reviewed by Jian Li.
3045
3046         [DRT/Chromium] Remove another unnecessary error message
3047         https://bugs.webkit.org/show_bug.cgi?id=51083
3048
3049         * DumpRenderTree/chromium/WebViewHost.cpp:
3050         (WebViewHost::didInvalidateRect):
3051
3052 2010-12-14  Lucas Forschler  <lforschler@apple.com>
3053
3054         Reviewed by Stephanie Lewis.
3055
3056         Add a new Leopard Debug Test WK2 Bot
3057
3058         * BuildSlaveSupport/build.webkit.org-config/config.json:
3059
3060 2010-12-14  Ojan Vafai  <ojan@chromium.org>
3061
3062         Fix python unittests after http://trac.webkit.org/changeset/74070.
3063
3064         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3065
3066 2010-12-14  Kent Tamura  <tkent@chromium.org>
3067
3068         Reviewed by Jian Li.
3069
3070         [DRT/Chromium] Remove a unnecessary error message
3071         https://bugs.webkit.org/show_bug.cgi?id=51069
3072
3073         * DumpRenderTree/chromium/WebViewHost.cpp:
3074         (WebViewHost::paintInvalidatedRegion):
3075
3076 2010-12-14  Benjamin Kalman  <kalman@chromium.org>
3077
3078         Reviewed by Ojan Vafai.
3079
3080         Using BUG/BUGWK in test_expectations is error prone, should use BUGCR/BUGWK
3081         https://bugs.webkit.org/show_bug.cgi?id=48926
3082
3083         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3084         Add presubmit check that BUG isn't used, either BUGCR/BUGWK/BUGV8_.
3085
3086 2010-12-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3087
3088         Reviewed by Eric Seidel.
3089
3090         [Qt] [Symbian] Do not use pkg-config on Symbian as it is not supported
3091         https://bugs.webkit.org/show_bug.cgi?id=50231
3092
3093         Guard CONFIG+=link_pkgconfig with !symbian.
3094
3095         * DumpRenderTree/qt/DumpRenderTree.pro:
3096         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3097         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3098
3099 2010-12-14  Philippe Normand  <pnormand@igalia.com>
3100
3101         Reviewed by Ojan Vafai.
3102
3103         [new-run-webkit-tests] expectations parsing is slow
3104         https://bugs.webkit.org/show_bug.cgi?id=50635
3105
3106         Avoid expensive iteration of all the tests when checking if a test
3107         file is to be skipped or not.
3108
3109         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3110         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3111         * Scripts/webkitpy/layout_tests/port/test.py:
3112
3113 2010-12-14  Mario Sanchez Prada  <msanchez@igalia.com>
3114
3115         Reviewed by Xan Lopez.
3116
3117         [Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding events for text objects
3118         https://bugs.webkit.org/show_bug.cgi?id=27048
3119
3120         Add support in DRT for checking whether an accessibility UI
3121         element is focusable and/or focused. Implemented for GTK.
3122
3123         * DumpRenderTree/AccessibilityUIElement.cpp:
3124         (getIsFocusedCallback): New.
3125         (getIsFocusableCallback): New.
3126         (AccessibilityUIElement::getJSClass): Add the new available
3127         callbacks for isFocused and isFocusable.
3128         * DumpRenderTree/AccessibilityUIElement.h:
3129         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3130         (AccessibilityUIElement::isFocused): New, implemented by checking
3131         whether the related AtkState value is in the object's state set.
3132         (AccessibilityUIElement::isFocusable): Ditto.
3133         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3134         (AccessibilityUIElement::isFocused): New, dummy implementation.
3135         (AccessibilityUIElement::isFocusable): Ditto.
3136         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3137         (AccessibilityUIElement::isFocused): Ditto.
3138         (AccessibilityUIElement::isFocusable): Ditto.
3139
3140 2010-12-14  Eric Seidel  <eric@webkit.org>
3141
3142         Reviewed by Ojan Vafai.
3143
3144         webkit-patch should warn users when they're using a 32-bit git on a 64-bit system
3145         https://bugs.webkit.org/show_bug.cgi?id=50715
3146
3147         This patch makes webkit-patch print the following:
3148
3149         Warning: This machine is 64-bit, but the git binary (/usr/local/git/bin/git) does not support 64-bit.
3150         Install a 64-bit git for better performance, see:
3151         https://lists.webkit.org/pipermail/webkit-dev/2010-December/015249.html
3152
3153         I wrote this mostly because I have approximately 8 machines that I use
3154         and making sure each one is using a good Git install seemed folly.
3155         webkit-patch makes a lot of git calls, so using a fast git can shave
3156         several seconds in every invocation.  See the webkit-dev thread for more info.
3157
3158         This message will print twice during 'webkit-patch upload',
3159         once from webkit-patch and once from check-webkit-style.
3160
3161         Unfortunately there is no good way to test this due to how machine-dependent
3162         the code is.  I considered writing a test for the log message, but it seemed not worth it.
3163
3164         * Scripts/webkitpy/common/checkout/scm.py:
3165
3166 2010-12-13  Eric Seidel  <eric@webkit.org>
3167
3168         Reviewed by Adam Barth.
3169
3170         FlakyTestReporter doesn't understand bots running from multiple email addresses
3171         https://bugs.webkit.org/show_bug.cgi?id=50960
3172
3173         This explains at least one of the dupes of:
3174         https://bugs.webkit.org/show_bug.cgi?id=50863
3175         that we saw filed by the commit-queue this morning.
3176         I think the other one was explained by my previous fix to result counting code.
3177
3178         Since this is really hard to test with a unit test, instead I
3179         create a new (possibly useful in the future) command
3180         which given a layout test path will return you
3181         the one bug which our tools would assume it the flaky test bug.
3182         If some other script wants to use bug-for-test we'll
3183         need to extend it with some options like --create-if-missing or similar.
3184
3185         * Scripts/webkitpy/common/net/bugzilla/bug.py:
3186         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3187         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3188         * Scripts/webkitpy/tool/commands/__init__.py:
3189         * Scripts/webkitpy/tool/commands/bugfortest.py: Added.
3190
3191 2010-12-13  Mihai Parparita  <mihaip@chromium.org>
3192
3193         Reviewed by James Robinson.
3194
3195         Add option to build-webkit to not build WebKit2
3196         https://bugs.webkit.org/show_bug.cgi?id=50988
3197         
3198         Add support for a --no-webkit2 option to build-webkit. It seems to save
3199         ~1 minute from clean builds and ~10 seconds from no-op builds.
3200
3201         * Scripts/build-webkit:
3202
3203 2010-12-13  Lucas Forschler  <lforschler@apple.com>
3204
3205         Reviewed by Dave Kilzer.
3206
3207         Update iexploder from 1.3.2 to 1.7.2
3208         Move 1.3.2 into its own subdir
3209         Add 1.7.2 into its own subdir
3210         update scripts to point to new 1.3.2 location (avoid breaking existing scripts)
3211
3212         * Scripts/run-iexploder-tests:
3213         * Scripts/update-iexploder-cssproperties:
3214         * iExploder/CHANGELOG.txt: Removed.
3215         * iExploder/LICENSE.txt: Removed.
3216         * iExploder/README.txt: Removed.
3217         * iExploder/htdocs: Removed.
3218         * iExploder/iexploder-1.3.2: Added.
3219         * iExploder/iexploder-1.3.2/CHANGELOG.txt: Copied from iExploder/CHANGELOG.txt.
3220         * iExploder/iexploder-1.3.2/LICENSE.txt: Copied from iExploder/LICENSE.txt.
3221         * iExploder/iexploder-1.3.2/README.txt: Copied from iExploder/README.txt.
3222         * iExploder/iexploder-1.3.2/htdocs: Added.
3223         * iExploder/iexploder-1.3.2/htdocs/config.rb: Copied from iExploder/htdocs/config.rb.
3224         * iExploder/iexploder-1.3.2/htdocs/cssproperties.in: Copied from iExploder/htdocs/cssproperties.in.
3225         * iExploder/iexploder-1.3.2/htdocs/cssvalues.in: Copied from iExploder/htdocs/cssvalues.in.
3226         * iExploder/iexploder-1.3.2/htdocs/htmlattrs.in: Copied from iExploder/htdocs/htmlattrs.in.
3227         * iExploder/iexploder-1.3.2/htdocs/htmltags.in: Copied from iExploder/htdocs/htmltags.in.
3228         * iExploder/iexploder-1.3.2/htdocs/htmlvalues.in: Copied from iExploder/htdocs/htmlvalues.in.
3229         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi: Copied from iExploder/htdocs/iexploder.cgi.
3230         * iExploder/iexploder-1.3.2/htdocs/iexploder.rb: Copied from iExploder/htdocs/iexploder.rb.
3231         * iExploder/iexploder-1.3.2/htdocs/index.html: Copied from iExploder/htdocs/index.html.
3232         * iExploder/iexploder-1.3.2/htdocs/webserver.rb: Copied from iExploder/htdocs/webserver.rb.
3233         * iExploder/iexploder-1.3.2/tools: Added.
3234         * iExploder/iexploder-1.3.2/tools/lasthit.rb: Copied from iExploder/tools/lasthit.rb.
3235         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb: Copied from iExploder/tools/osx_last_crash.rb.
3236         * iExploder/iexploder-1.3.2/tools/showtest.rb: Copied from iExploder/tools/showtest.rb.
3237         * iExploder/iexploder-1.7.2: Added.
3238         * iExploder/iexploder-1.7.2/ChangeLog.txt: Added.
3239         * iExploder/iexploder-1.7.2/LICENSE.txt: Added.
3240         * iExploder/iexploder-1.7.2/README.txt: Added.
3241         * iExploder/iexploder-1.7.2/output: Added.
3242         * iExploder/iexploder-1.7.2/src: Added.
3243         * iExploder/iexploder-1.7.2/src/browser_harness.rb: Added.
3244         * iExploder/iexploder-1.7.2/src/config.yaml: Added.
3245         * iExploder/iexploder-1.7.2/src/css-atrules: Added.
3246         * iExploder/iexploder-1.7.2/src/css-atrules/mozilla: Added.
3247         * iExploder/iexploder-1.7.2/src/css-atrules/webkit: Added.
3248         * iExploder/iexploder-1.7.2/src/css-properties: Added.
3249         * iExploder/iexploder-1.7.2/src/css-properties/dillo: Added.
3250         * iExploder/iexploder-1.7.2/src/css-properties/gtkhtml: Added.
3251         * iExploder/iexploder-1.7.2/src/css-properties/internet_explorer6: Added.
3252         * iExploder/iexploder-1.7.2/src/css-properties/mozilla: Added.
3253         * iExploder/iexploder-1.7.2/src/css-properties/webkit: Added.
3254         * iExploder/iexploder-1.7.2/src/css-pseudo: Added.
3255         * iExploder/iexploder-1.7.2/src/css-pseudo/mozilla: Added.
3256         * iExploder/iexploder-1.7.2/src/css-pseudo/webkit: Added.
3257         * iExploder/iexploder-1.7.2/src/css-values: Added.
3258         * iExploder/iexploder-1.7.2/src/css-values/dillo: Added.
3259         * iExploder/iexploder-1.7.2/src/css-values/gtkhtml: Added.
3260         * iExploder/iexploder-1.7.2/src/css-values/mozilla: Added.
3261         * iExploder/iexploder-1.7.2/src/css-values/other: Added.
3262         * iExploder/iexploder-1.7.2/src/css-values/webkit: Added.
3263         * iExploder/iexploder-1.7.2/src/headers: Added.
3264         * iExploder/iexploder-1.7.2/src/headers/dillo: Added.
3265         * iExploder/iexploder-1.7.2/src/headers/gtkhtml: Added.
3266         * iExploder/iexploder-1.7.2/src/headers/mozilla: Added.
3267         * iExploder/iexploder-1.7.2/src/headers/webkit: Added.
3268         * iExploder/iexploder-1.7.2/src/html-attrs: Added.
3269         * iExploder/iexploder-1.7.2/src/html-attrs/dillo: Added.
3270         * iExploder/iexploder-1.7.2/src/html-attrs/gtkhtml: Added.
3271         * iExploder/iexploder-1.7.2/src/html-attrs/internet_explorer6: Added.
3272         * iExploder/iexploder-1.7.2/src/html-attrs/mozilla: Added.
3273         * iExploder/iexploder-1.7.2/src/html-attrs/other: Added.
3274         * iExploder/iexploder-1.7.2/src/html-attrs/webkit: Added.
3275         * iExploder/iexploder-1.7.2/src/html-tags: Added.
3276         * iExploder/iexploder-1.7.2/src/html-tags/dillo: Added.
3277         * iExploder/iexploder-1.7.2/src/html-tags/gtkhtml: Added.
3278         * iExploder/iexploder-1.7.2/src/html-tags/mozilla: Added.
3279         * iExploder/iexploder-1.7.2/src/html-tags/other: Added.
3280         * iExploder/iexploder-1.7.2/src/html-tags/webkit: Added.
3281         * iExploder/iexploder-1.7.2/src/html-values: Added.
3282         * iExploder/iexploder-1.7.2/src/html-values/dillo: Added.
3283         * iExploder/iexploder-1.7.2/src/html-values/gtkhtml: Added.
3284         * iExploder/iexploder-1.7.2/src/html-values/mozilla: Added.
3285         * iExploder/iexploder-1.7.2/src/html-values/other: Added.
3286         * iExploder/iexploder-1.7.2/src/html-values/webkit: Added.
3287         * iExploder/iexploder-1.7.2/src/iexploder.cgi: Added.
3288         * iExploder/iexploder-1.7.2/src/iexploder.rb: Added.
3289         * iExploder/iexploder-1.7.2/src/index.html: Added.
3290         * iExploder/iexploder-1.7.2/src/media: Added.
3291         * iExploder/iexploder-1.7.2/src/media/blank.ogg: Added.
3292         * iExploder/iexploder-1.7.2/src/media/blank.snd: Added.
3293         * iExploder/iexploder-1.7.2/src/media/blank.wav: Added.
3294         * iExploder/iexploder-1.7.2/src/media/bug.bmp: Added.
3295         * iExploder/iexploder-1.7.2/src/media/bug.gif: Added.
3296         * iExploder/iexploder-1.7.2/src/media/bug.ico: Added.
3297         * iExploder/iexploder-1.7.2/src/media/bug.jng: Added.
3298         * iExploder/iexploder-1.7.2/src/media/bug.jpg: Added.
3299         * iExploder/iexploder-1.7.2/src/media/bug.png: Added.
3300         * iExploder/iexploder-1.7.2/src/media/bug.svg: Added.
3301         * iExploder/iexploder-1.7.2/src/media/bug.tiff: Added.
3302         * iExploder/iexploder-1.7.2/src/media/bug.xbm: Added.
3303         * iExploder/iexploder-1.7.2/src/media/bug.xpm: Added.
3304         * iExploder/iexploder-1.7.2/src/mime-types: Added.
3305         * iExploder/iexploder-1.7.2/src/mime-types/dillo: Added.
3306         * iExploder/iexploder-1.7.2/src/mime-types/mozilla: Added.
3307         * iExploder/iexploder-1.7.2/src/mime-types/webkit: Added.
3308         * iExploder/iexploder-1.7.2/src/protocols: Added.
3309         * iExploder/iexploder-1.7.2/src/protocols/dillo: Added.
3310         * iExploder/iexploder-1.7.2/src/protocols/gtkhtml: Added.
3311         * iExploder/iexploder-1.7.2/src/protocols/mozilla: Added.
3312         * iExploder/iexploder-1.7.2/src/protocols/webkit: Added.
3313         * iExploder/iexploder-1.7.2/src/scanner.rb: Added.
3314         * iExploder/iexploder-1.7.2/src/version.rb: Added.
3315         * iExploder/iexploder-1.7.2/src/webserver.rb: Added.
3316         * iExploder/iexploder-1.7.2/testcases: Added.
3317         * iExploder/iexploder-1.7.2/testcases/testcase-Linux_x86_64_rv2.0b6pre_Gecko-20100904_Firefox-4.0b6pre-TEST-8375-1_59.html: Added.
3318         * iExploder/iexploder-1.7.2/testcases/testcase-Opera-9.80_Linux_x86_64_en_Presto-2.6.30_Version-10.61-16704-3_108,3.html: Added.
3319         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_Chrome-7.0.529.0-TEST-611-3_36,9.html: Added.
3320         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_hrome-7.0.529.0-TEST-55313622206-3_6,0.html: Added.
3321         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-120813-8_72,56,24,8,0.html: Added.
3322         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-121240-3_81,3.html: Added.
3323         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-4800-5_80,65,15.html: Added.
3324         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-TEST-23583190347-3_15,12.html: Added.
3325         * iExploder/iexploder-1.7.2/tools: Added.
3326         * iExploder/iexploder-1.7.2/tools/lasthit.rb: Added.
3327         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb: Added.
3328         * iExploder/iexploder-1.7.2/tools/release_src.sh: Added.
3329         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added.
3330         * iExploder/tools: Removed.
3331
3332 2010-12-13  Sam Weinig  <sam@webkit.org>
3333
3334         Reviewed by Anders Carlsson.
3335
3336         Remove associated page concept from WKView constructor
3337         https://bugs.webkit.org/show_bug.cgi?id=50983
3338
3339         Step 1: Remove associate page constructors from WKView and make
3340         all views use the shared namespace for the context.
3341
3342         * TestWebKitAPI/PlatformWebView.h:
3343         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3344         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3345         * WebKitTestRunner/PlatformWebView.h:
3346         * WebKitTestRunner/TestController.cpp:
3347         (WTR::createOtherPage):
3348         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3349         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3350         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3351
3352 2010-12-13  Sam Weinig  <sam@webkit.org>
3353
3354         Reviewed by Anders Carlsson.
3355
3356         Change the WebKit2 public API so there is no explicit WKPageNamespace object
3357         https://bugs.webkit.org/show_bug.cgi?id=50898
3358
3359         * MiniBrowser/mac/AppDelegate.h:
3360         * MiniBrowser/mac/AppDelegate.m:
3361         * MiniBrowser/mac/BrowserWindowController.h:
3362         * MiniBrowser/mac/BrowserWindowController.m:
3363         * MiniBrowser/win/BrowserView.cpp:
3364         Convert MiniBrowser to not use PageNamespaces.
3365
3366         * TestWebKitAPI/PlatformWebView.h:
3367         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
3368         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
3369         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
3370         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
3371         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
3372         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
3373         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
3374         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3375         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3376         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
3377         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
3378         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
3379         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
3380         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3381         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3382         Convert TestWebKitAPI to not use PageNamespaces.
3383
3384         * WebKitTestRunner/PlatformWebView.h:
3385         * WebKitTestRunner/TestController.cpp:
3386         * WebKitTestRunner/TestController.h:
3387         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3388         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3389         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3390         Convert WebKitTestRunner to not use PageNamespaces.
3391
3392 2010-12-13  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3393
3394         Reviewed by Eric Seidel.
3395
3396         webkit-patch rollout should be able to do multi-revision rollouts
3397         https://bugs.webkit.org/show_bug.cgi?id=33336
3398
3399         Make it possible to pass more than one revision to webkit-patch.
3400
3401         * Scripts/webkitpy/common/checkout/api.py:
3402         * Scripts/webkitpy/common/checkout/changelog.py:
3403         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3404         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
3405         * Scripts/webkitpy/tool/commands/download.py:
3406         * Scripts/webkitpy/tool/commands/download_unittest.py:
3407         * Scripts/webkitpy/tool/mocktool.py:
3408         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
3409         * Scripts/webkitpy/tool/steps/revertrevision.py:
3410
3411 2010-12-13  Eric Seidel  <eric@webkit.org>
3412
3413         Unreviewed.
3414
3415         Teach webkit-patch how to search bugzilla
3416         https://bugs.webkit.org/show_bug.cgi?id=50500
3417
3418         webkit-patch bug-search fails when there is only one result.
3419         Turns out we needed a bit more logic in our result count parsing code.
3420
3421         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3422         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3423
3424 2010-12-13  Antti Koivisto  <antti@apple.com>
3425
3426         Reviewed by Alexey Proskuryakov.
3427
3428         Add setSerializeHTTPLoads function to allow testing resource load order on OS X.
3429         https://bugs.webkit.org/show_bug.cgi?id=50758
3430
3431         * DumpRenderTree/LayoutTestController.cpp:
3432         (setSerializeHTTPLoadsCallback):
3433         (LayoutTestController::staticFunctions):
3434         * DumpRenderTree/LayoutTestController.h:
3435         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3436         (LayoutTestController::setSerializeHTTPLoads):
3437         * DumpRenderTree/mac/DumpRenderTree.mm:
3438         (resetDefaultsToConsistentValues):
3439         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3440         (LayoutTestController::setSerializeHTTPLoads):
3441         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3442         (LayoutTestController::setSerializeHTTPLoads):
3443
3444 2010-12-13  Dimitri Glazkov  <dglazkov@chromium.org>
3445
3446         Reviewed by Ojan Vafai.
3447
3448         Remove "use-drt" option from test step command line, since the option was removed in r73748.
3449         https://bugs.webkit.org/show_bug.cgi?id=50936
3450
3451         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed the option.
3452
3453 2010-12-13  Patrick Gansterer  <paroga@webkit.org>
3454
3455         Reviewed by Csaba Osztrogonác.
3456
3457         Add revlink to BuildBot status
3458         https://bugs.webkit.org/show_bug.cgi?id=50914
3459
3460         This adds a hyperlink to trac changeset on the revision numbers. 
3461
3462         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3463
3464 2010-12-13  Andras Becsi  <abecsi@webkit.org>
3465
3466         Reviewed by Csaba Osztrogonác.
3467
3468         [Qt][WK2] Fix build if WebKitTools are not available
3469         https://bugs.webkit.org/show_bug.cgi?id=50242
3470
3471         * MiniBrowser/qt/MiniBrowser.pro: Correct the comment.
3472         * Scripts/webkitdirs.pm: Added WebKitTools/MiniBrowser to $subdirs.
3473         * MiniBrowser/DerivedSources.pro: Added.
3474
3475 2010-12-13  Eric Seidel  <eric@webkit.org>
3476
3477         Reviewed by Adam Barth.
3478
3479         EWS Queues should remove orpahned pyc files before starting
3480         https://bugs.webkit.org/show_bug.cgi?id=50904
3481
3482         A previous check added a platform.py which caused
3483         EWS bots on some platforms to hit an import exception.
3484         The platform.py file was removed in a subsequent commit, but
3485         the EWS bots in question stayed stuck.  This change will
3486         fix those bots once restarted (and prevent this in the future).
3487
3488         I also went ahead and unified start-queue and start-commit-queue
3489         since they were nearly identical.  I also added bot_id support
3490         to both force all EWSes to have bot ids as well as get rid of the one
3491         remaining reason why I had my own copies of these scripts.
3492         Hopefully this will be enough to get all the other bot admins
3493         (ahem, Adam, ahem) to move to using these checked in copies as well.
3494
3495         * EWSTools/start-commit-queue.sh: Removed.
3496         * EWSTools/start-queue.sh:
3497
3498 2010-10-28  MORITA Hajime  <morrita@google.com>
3499
3500         Reviewed by Ojan Vafai.
3501
3502         spellcheck does not check pasted text
3503         https://bugs.webkit.org/show_bug.cgi?id=40092
3504
3505         Added LayoutTestController::setAsynchronousSpellCheckingEnabled()
3506         to control the setting.
3507
3508         * DumpRenderTree/LayoutTestController.cpp:
3509         (setAsynchronousSpellCheckingEnabledCallback):
3510         (LayoutTestController::staticFunctions):
3511         * DumpRenderTree/LayoutTestController.h:
3512         * DumpRenderTree/chromium/LayoutTestController.h:
3513         * DumpRenderTree/chromium/LayoutTestController.cpp:
3514         (LayoutTestController::LayoutTestController):
3515         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
3516         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3517         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
3518         * DumpRenderTree/mac/DumpRenderTree.mm:
3519         (resetDefaultsToConsistentValues):
3520         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3521         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
3522         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3523         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3524         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
3525         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3526         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
3527         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3528         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
3529
3530 2010-12-12  Sam Weinig  <sam@webkit.org>
3531
3532         Reviewed by Anders Carlsson.
3533
3534         Fix failing API test. It turns out that a pop-state event
3535         is sent before every fragment navigation, so we have to test
3536         for it in addition in PageLoadDidChangeLocationWithinPageForFrame.
3537
3538         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3539         (TestWebKitAPI::didSameDocumentNavigationForFrame):
3540
3541 2010-12-12  Alejandro G. Castro  <alex@igalia.com>
3542
3543         Reviewed by Eric Seidel.
3544
3545         [GTK] Add new-run-webkit-tests support to gtk
3546         https://bugs.webkit.org/show_bug.cgi?id=50681
3547
3548         Adding the basic support to run the new-run-webkit-tests.
3549
3550         * Scripts/webkitpy/layout_tests/port/gtk.py:
3551
3552 2010-10-11  Diego Gonzalez  <diegohcg@webkit.org>
3553
3554         Reviewed by Kenneth Rohde Christiansen.
3555
3556         [Qt] Mock DeviceOrientation client for DRT
3557         https://bugs.webkit.org/show_bug.cgi?id=47490
3558
3559         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3560         (WebCore::DumpRenderTree::DumpRenderTree):
3561         (WebCore::DumpRenderTree::~DumpRenderTree):
3562         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3563         (LayoutTestController::setMockDeviceOrientation):
3564
3565 2010-12-11  Philippe Normand  <pnormand@igalia.com>
3566
3567         Reviewed by Gustavo Noronha Silva.
3568
3569         [GTK] launcher: disable the Mozilla-style fullscreen API
3570         https://bugs.webkit.org/show_bug.cgi?id=50874
3571
3572         Disabling the fullscreen API until its implementation for GTK is
3573         mature enough. The webview setting for it is already FALSE by
3574         default.
3575
3576         * GtkLauncher/main.c:
3577         (createWindow):
3578
3579 2010-12-10  Eric Seidel  <eric@webkit.org>
3580
3581         Reviewed by Adam Barth.
3582
3583         commit-queue flaky test messages show cryptic version information for mac os x
3584         https://bugs.webkit.org/show_bug.cgi?id=50864
3585
3586         Turns out platform.platform() returns kernel version information
3587         which isn't helpful, and just plain confusing on Mac
3588         (OS X 10.6.5 uses Darwin Kernel 10.5.0).
3589
3590         So I've updated PlatformInfo.display_name() to special case
3591         mac.  I also found a bad use of sys.platform in the process
3592         and fixed that.  (sys.platform always returns 'darwin' on mac).
3593
3594         * Scripts/webkitpy/common/system/platforminfo.py:
3595         * Scripts/webkitpy/common/system/user.py:
3596         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3597         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3598         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3599
3600 2010-12-10  Eric Seidel  <eric@webkit.org>
3601
3602         Unreviewed.
3603
3604         Exception seen while reporting flaky test with commit-queue.
3605         Just a missing include.
3606
3607         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3608         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3609
3610 2010-12-10  Kinuko Yasuda  <kinuko@chromium.org>
3611
3612         Reviewed by Eric Seidel.
3613
3614         [Chromium] Remove old JSONResultsGenerator script that existed for backward-compatibility
3615         https://bugs.webkit.org/show_bug.cgi?id=50796
3616
3617         Also updating the test code to use JSONResultsGeneratorBase and
3618         to improve test coverage for incremental cases.
3619
3620         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3621         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3622
3623 2010-12-10  Joseph Pecoraro  <joepeck@webkit.org>
3624
3625         Reviewed by Darin Adler.
3626
3627         prepare-ChangeLog --help doesn't mention --bug shorthand -b
3628         https://bugs.webkit.org/show_bug.cgi?id=50835
3629
3630         * Scripts/prepare-ChangeLog: be more explicit about -b and match file style.
3631
3632 2010-12-10  Eric Seidel  <eric@webkit.org>
3633
3634         Reviewed by Adam Barth.
3635
3636         Bugs created by the commit-queue should all block on a master bug
3637         https://bugs.webkit.org/show_bug.cgi?id=50857
3638
3639         This makes all bugs created by the commit-queue block on:
3640         https://bugs.webkit.org/show_bug.cgi?id=50856
3641
3642         In the process of testing this, I found that the existing
3643         create_bug code was wrong.  I also found that existing
3644         unit tests for create-rollout used invalid values
3645         for options.blocks.  I fixed both issues and tested.
3646