35900162621cd2b95ced166686c90a322efb7081
[WebKit-https.git] / Tools / ChangeLog
1 2011-01-13  David Levin  <levin@chromium.org>
2
3         Reviewed by Shinichiro Hamaji.
4
5         check-webkit-style: _FunctionState should use Position to know where items are.
6         https://bugs.webkit.org/show_bug.cgi?id=52424
7
8         * Scripts/webkitpy/style/checkers/cpp.py:
9         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
10         (detect_functions): Changed to pass Position's to _FunctionState.begin and
11         did some minor clean-up.
12         (*): Other changes are simply about converting to use the Position's in_FunctionState
13         instead of line numbers.
14         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
15         to verify the positions stored in _FunctionState.
16
17 2011-01-13  Eric Seidel  <eric@webkit.org>
18
19         Reviewed by David Levin.
20
21         webkit-patch suggest-reviewers dies when ChangeLogs are missing
22         https://bugs.webkit.org/show_bug.cgi?id=49158
23
24         This is not the most elegant, but it is a very safe fix to this bug.
25         One advantage of catching ScriptError like this instead of adding a
26         new added_or_modified_files or fixing all changed_files callers
27         to use a more specific change_files variant, is that we catch
28         all kinds of ScriptErrors which might cause our (non-essential)
29         suggest-reviewers code to fail out.  This should make passing
30         --suggest-reviewers to webkit-patch upload much more robust
31         and may even make it possible for us to make it default.
32
33         The root of the problem here is that SCM.changed_files includes
34         deleted ChangeLog paths (from moves, etc) which then when we ask
35         SVN/Git for the contents of the file at that revision, the command
36         errors out and Executive.run_command raises a ScriptError.
37
38         In the future we might fix this differently by making all current
39         callers of chagned_files use a more specific method for requesting
40         what types of changes they're interested in (adds, modifies, deletes, etc.)
41
42         * Scripts/webkitpy/common/checkout/api.py:
43         * Scripts/webkitpy/common/checkout/api_unittest.py:
44
45 2011-01-13  Dan Bernstein  <mitz@apple.com>
46
47         Reviewed by Alexey Proskuryakov.
48
49         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
50         https://bugs.webkit.org/show_bug.cgi?id=52419
51
52         Allow to further control the behavior of the willSendRequest delegate callback by making it
53         set a different URL in the new request.
54
55         * DumpRenderTree/LayoutTestController.cpp:
56         (addURLToRedirectCallback): Added.
57         (LayoutTestController::staticFunctions): Added addURLToRedirect.
58         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
59         (LayoutTestController::redirectionDestinationForURL): Added this getter.
60         * DumpRenderTree/LayoutTestController.h:
61         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
62         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
63         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
64         change the URL in the new request to the redirect destination.
65
66 2011-01-13  Eric Seidel  <eric@webkit.org>
67
68         Reviewed by Mihai Parparita.
69
70         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
71         https://bugs.webkit.org/show_bug.cgi?id=52416
72
73         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
74         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
75
76         I also added FIXMEs about the changed_files returning deleted files problem
77         which is causing the other most common exception for suggest-reviewers
78         (and is probably breaking sheriff-bots blame detection).
79
80         * Scripts/webkitpy/common/checkout/api.py:
81         * Scripts/webkitpy/common/checkout/api_unittest.py:
82         * Scripts/webkitpy/common/checkout/scm.py:
83
84 2011-01-13  Eric Seidel  <eric@webkit.org>
85
86         Reviewed by Adam Barth.
87
88         results archives from commit-queue are too large to upload
89         https://bugs.webkit.org/show_bug.cgi?id=52405
90
91         * Scripts/webkitpy/common/system/filesystem.py:
92         * Scripts/webkitpy/common/system/filesystem_mock.py:
93         * Scripts/webkitpy/tool/commands/queues.py:
94
95 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
96
97         Reviewed by Martin Robinson.
98
99         [gtk] Zero-sized font does not yet work
100         https://bugs.webkit.org/show_bug.cgi?id=49793
101
102         Set minimum-font-size to 0 for the DRT.
103
104         * DumpRenderTree/gtk/DumpRenderTree.cpp:
105         (resetDefaultsToConsistentValues):
106
107 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
108
109         Reviewed by Darin Adler.
110
111         Make old-run-webkit-tests more robust on buildbots
112         https://bugs.webkit.org/show_bug.cgi?id=52364
113
114         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
115
116 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
117
118         Reviewed by Darin Adler.
119
120         Make old-run-webkit-tests more robust on buildbots
121         https://bugs.webkit.org/show_bug.cgi?id=52364
122
123         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
124
125 2011-01-13  Tony Chang  <tony@chromium.org>
126
127         Reviewed by Kent Tamura.
128
129         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
130         https://bugs.webkit.org/show_bug.cgi?id=52332
131
132         Forked Info.plist is not longer needed.
133
134         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
135
136 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
137
138         Reviewed by Timothy Hatcher.
139
140         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
141         to be passed directly to WebInspector.UIString
142
143         https://bugs.webkit.org/show_bug.cgi?id=52365
144
145         * Scripts/check-inspector-strings:
146
147 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
148
149         Unreviewed, rolling out r74881.
150         http://trac.webkit.org/changeset/74881
151         https://bugs.webkit.org/show_bug.cgi?id=52357
152
153         The EFL builder has been red for days (Requested by abarth on
154         #webkit).
155
156         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
157         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
158
159 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
160
161         Reviewed by David Levin.
162
163         Add beforeunload support to WebKitTestRunner
164         https://bugs.webkit.org/show_bug.cgi?id=52353
165         
166         This makes a number of currently failing tests pass.
167
168         * WebKitTestRunner/TestController.cpp:
169         (WTR::runBeforeUnloadConfirmPanel):
170         (WTR::createOtherPage):
171         (WTR::TestController::initialize):
172
173 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
174
175         Reviewed by Sam Weinig.
176
177         Detect, identify and recover from WebProcess crashes in run-webkit-tests
178         https://bugs.webkit.org/show_bug.cgi?id=52330
179
180         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
181         a web process crash.
182         * WebKitTestRunner/TestController.cpp:
183         (WTR::TestController::initialize): Set up a processDidCrash
184         callback.
185         (WTR::TestController::processDidCrash): Report that the Web process
186         crashed.
187         * WebKitTestRunner/TestController.h:
188
189 2011-01-12  David Levin  <levin@chromium.org>
190
191         Reviewed by Shinichiro Hamaji.
192
193         check-webkit-style -- close_expression function doesn't work correctly.
194         https://bugs.webkit.org/show_bug.cgi?id=52272
195
196         * Scripts/webkitpy/style/checkers/cpp.py:
197         (Position.__str__): Added a way to convert it to a string which is useful in tests.
198         (Position.__cmp__): Added a way to compare Position which is useful in tests and
199         generally useful (for upcoming code changes).
200         (close_expression): Changed to use Position for input and output.
201         Also, fixed many bugs such as only working correctly for parenthesis,
202         not working correctly if given an offset in a line and not finding
203         the real closing element if there were multiple closing elements in
204         the same line.
205         (detect_functions): Adjusted due to the change in arguments for
206         close_expression.
207         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
208         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
209         two positions are the same.
210         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
211         (CppStyleTest.test_close_expression): Added tests to catch the issues
212         that were fixed.
213
214 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
215
216         Unreviewed, rolling out r75576.
217         http://trac.webkit.org/changeset/75576
218         https://bugs.webkit.org/show_bug.cgi?id=52304
219
220         broke rebaseline-chromium-webkit-test (Requested by thakis on
221         #webkit).
222
223         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
224         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
225         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
226         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
227         * Scripts/webkitpy/layout_tests/port/base.py:
228         * Scripts/webkitpy/layout_tests/port/chromium.py:
229         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
230         * Scripts/webkitpy/layout_tests/port/test.py:
231         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
232         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
233         * Scripts/webkitpy/style/checkers/test_expectations.py:
234         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
235
236 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
237
238         Reviewed by Darin Adler.
239
240         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
241         https://bugs.webkit.org/show_bug.cgi?id=52307
242
243         * Scripts/old-run-webkit-tests:
244
245 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
246
247         Reviewed by Martin Robinson.
248
249         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
250         https://bugs.webkit.org/show_bug.cgi?id=50867
251
252         Fixed library extention for Mac in webkitdirs.pm and type conflict in
253         TestNetscapePlugin.cpp 
254
255         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
256         * Scripts/webkitdirs.pm:
257
258 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
259
260         Reviewed by Pavel Feldman.
261
262         Add check-inspector-strings script.
263
264         https://bugs.webkit.org/show_bug.cgi?id=52295
265
266         * Scripts/check-inspector-strings: Added.
267
268 2011-01-12  Adam Roben  <aroben@apple.com>
269
270         Advertise the .testnetscape file extension on Windows
271
272         Fixes <http://webkit.org/b/52298>
273         plugins/no-mime-with-valid-extension.html fails on Windows
274
275         Reviewed by Dan Bernstein.
276
277         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
278         FileExtents field to map the .testnetscape file extension to the
279         application/x-webkit-test-netscape MIME type, just as we do on Mac.
280
281 2011-01-12  Adam Barth  <abarth@webkit.org>
282
283         Reviewed by Eric Seidel.
284
285         Make webkit-patch support subdirectories for SVN checkouts
286         https://bugs.webkit.org/show_bug.cgi?id=52261
287
288         os.relpath does not exist on Python 2.5, so we need to call our version
289         of the API.
290
291         * Scripts/webkitpy/common/checkout/scm.py:
292
293 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
294
295         Reviewed by Eric Seidel.
296
297         Close additional pages opened during a test once the test completes.
298         https://bugs.webkit.org/show_bug.cgi?id=52276
299
300         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
301         (WTR::InjectedBundle::done):
302
303 2011-01-11  David Levin  <levin@chromium.org>
304
305         Reviewed by Eric Seidel.
306
307         Errors should be separated from the command line in bot messages.
308         https://bugs.webkit.org/show_bug.cgi?id=52275
309
310         * Scripts/webkitpy/common/system/executive.py:
311         (ScriptError.message_with_output): Added a newline to separate the command
312         line from the errors.
313         * Scripts/webkitpy/common/system/executive_unittest.py:
314         (ScriptErrorTest.test_message_with_output): Added tests for the various code
315         paths in message_with_output.
316
317 2011-01-11  Eric Seidel  <eric@webkit.org>
318
319         Unreviewed.
320
321         commit-queue should know how to upload archived results (for test flakes or general failures)
322         https://bugs.webkit.org/show_bug.cgi?id=52048
323
324         The zips are mostly empty due to forgetting -r.
325         Expected diffs were not being pulled from the archive due
326         to the archive having longer paths than I realized.
327
328         * Scripts/webkitpy/common/system/workspace.py:
329         * Scripts/webkitpy/common/system/workspace_unittest.py:
330         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
331         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
332
333 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
334
335         Reviewed by Ojan Vafai.
336
337         The current modifier parsing code in test_expectations is
338         fragile and hard-coded, so it's not easy to understand the logic
339         or easily add new types of modifiers (like GPU vs. CPU testing
340         for graphics tests, or 32-bit vs. 64-bit differences).
341
342         This is the first of two patches that will add in more generic
343         support and then eliminate the GPU-specific test expectations
344         files for Chromium.
345
346         This patch adds two standalone objects for handling modifiers. The
347         rules for interpreting modifiers, precedence, and conflicts are
348         given in the docstring to the ModifierMatcher class, which
349         returns ModifierMatchResult objects.
350         
351         This patch also adds routines to the Port interface and a
352         default set of values in the base object, in order to obtain the
353         values needed on a given test run. These values are then passed
354         to the expectation parser. This also allows us to clean up the
355         logic used to lint all of the different configurations in a
356         single test_expectations.txt file.
357
358         The next patch will merge in the separate GPU expectations file.
359
360         https://bugs.webkit.org/show_bug.cgi?id=51222
361
362         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
363         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
364         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
365         * Scripts/webkitpy/layout_tests/port/base.py:
366         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
367         * Scripts/webkitpy/layout_tests/port/chromium.py:
368         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
369         * Scripts/webkitpy/layout_tests/port/test.py:
370         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
371         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
372
373 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
374
375         Reviewed by Adam Barth.
376
377         Make webkit-patch support subdirectories for SVN checkouts
378         https://bugs.webkit.org/show_bug.cgi?id=52261
379
380         * Scripts/webkitpy/common/checkout/scm.py:
381         * Scripts/webkitpy/style_references.py:
382         * Scripts/webkitpy/tool/main.py:
383         * Scripts/webkitpy/tool/steps/preparechangelog.py:
384
385 2011-01-11  Eric Seidel  <eric@webkit.org>
386
387         Unreviewed.
388
389         commit-queue should know how to upload archived results (for test flakes or general failures)
390         https://bugs.webkit.org/show_bug.cgi?id=52048
391
392         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
393         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
394
395         * Scripts/webkitpy/common/system/workspace.py:
396         * Scripts/webkitpy/common/system/workspace_unittest.py:
397         * Scripts/webkitpy/tool/commands/queues.py:
398
399 2011-01-11  Sam Weinig  <sam@webkit.org>
400
401         Roll r75474 back in.
402
403 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
404
405         Reviewed by Kenneth Rohde Christiansen.
406
407         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
408         https://bugs.webkit.org/show_bug.cgi?id=51204
409
410         * QtTestBrowser/webpage.h:
411         (QtNAMThread::QtNAMThread):
412         (QtNAMThread::networkAccessManager):
413         (QtNAMThread::run):
414
415 2011-01-11  Peter Varga  <pvarga@webkit.org>
416
417         Unreviewed.
418
419         Add myself to committers' list.
420
421         * Scripts/webkitpy/common/config/committers.py:
422
423 2011-01-11  Eric Seidel  <eric@webkit.org>
424
425         Reviewed by Adam Barth.
426
427         commit-queue should know how to upload archived results (for test flakes or general failures)
428         https://bugs.webkit.org/show_bug.cgi?id=52048
429
430         Now the queue will always upload results.  Either the entire zip, or just
431         the diffs.txt in the case of text failures.
432
433         This should make understanding flakes much easier, and paves the way
434         for having the EWS run layout tests (and upload failures).
435
436         In order to upload .zip files I had to teach bugzilla.py to autodetect
437         mime types from the filename.  Since mimetypes.py doesn't include a mapping
438         for .patch files, I have it add one before calling guess_type.
439
440         We may find that always uploading the whole zip instead of just the -diffs.txt
441         file is preferable, but for now I'm keeping the old behavior because it makes
442         quickly understanding text failures easy.
443
444         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
445         * Scripts/webkitpy/common/system/workspace.py: Added.
446         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
447         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
448         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
449         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
450         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
451         * Scripts/webkitpy/tool/commands/queues.py:
452         * Scripts/webkitpy/tool/commands/queues_unittest.py:
453
454 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
455
456         Unreviewed, rolling out r75464.
457         http://trac.webkit.org/changeset/75464
458         https://bugs.webkit.org/show_bug.cgi?id=52193
459
460         Followup rollout for 75474 (Requested by Ossy on #webkit).
461
462         * MiniBrowser/mac/BrowserWindowController.m:
463         (-[BrowserWindowController awakeFromNib]):
464         * MiniBrowser/win/BrowserView.cpp:
465         (BrowserView::create):
466         * WebKitTestRunner/TestController.cpp:
467         (WTR::createOtherPage):
468         (WTR::TestController::initialize):
469
470 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
471
472         Reviewed by Csaba Osztrogonác.
473
474         [Qt] Baseline qt_minimal configuration
475         https://bugs.webkit.org/show_bug.cgi?id=51313
476
477         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
478         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
479         QT_NO_UNDOSTACK guard.
480
481         * QtTestBrowser/launcherwindow.cpp:
482         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
483         guards.
484         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
485         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
486         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
487         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
488
489         * QtTestBrowser/launcherwindow.h:
490         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
491         * QtTestBrowser/locationedit.h: Ditto.
492
493         * QtTestBrowser/mainwindow.cpp:
494         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
495         QT_NO_UNDOSTACK guards.
496         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
497         (MainWindow::changeLocation): Ditto.
498         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
499         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
500
501         * QtTestBrowser/webpage.cpp:
502         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
503         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
504
505         * QtTestBrowser/webview.cpp:
506         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
507         (WebViewGraphicsBased::animatedYFlip): Ditto.
508
509 2011-01-10  Sam Weinig  <sam@webkit.org>
510
511         Fix build.
512
513         * MiniBrowser/mac/BrowserWindowController.m:
514         (-[BrowserWindowController awakeFromNib]):
515         * MiniBrowser/win/BrowserView.cpp:
516         (BrowserView::create):
517         * WebKitTestRunner/TestController.cpp:
518         (WTR::createOtherPage):
519         (WTR::TestController::initialize):
520
521 2011-01-10  Eric Seidel  <eric@webkit.org>
522
523         Reviewed by Ojan Vafai.
524
525         style-queue messages are way too long for big patches
526         https://bugs.webkit.org/show_bug.cgi?id=52161
527
528         We definitely could build much fancier list-to-string-with-limit functions
529         but this should be sufficient for our needs at the moment.
530
531         * Scripts/webkitpy/common/system/executive.py:
532         * Scripts/webkitpy/common/system/executive_unittest.py:
533
534 2011-01-10  Tony Chang  <tony@chromium.org>
535
536         Unreviewed, rolling out r75398.
537         http://trac.webkit.org/changeset/75398
538         https://bugs.webkit.org/show_bug.cgi?id=52008
539
540         Some layout tests are crashing on Chromium Win.
541
542         * DumpRenderTree/chromium/WebViewHost.cpp:
543         (WebViewHost::updatePaintRect):
544         * DumpRenderTree/chromium/WebViewHost.h:
545
546 2011-01-10  Adam Roben  <aroben@apple.com>
547
548         Roll out r75392
549
550         It isn't needed now that r75289 has been rolled out.
551
552         * Scripts/run-javascriptcore-tests:
553
554 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
555
556         Reviewed by Anders Carlsson.
557
558         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
559         https://bugs.webkit.org/show_bug.cgi?id=52160
560
561         * WebKitTestRunner/mac/TestControllerMac.mm:
562         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
563         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
564         anyway.
565
566 2011-01-10  Tony Chang  <tony@chromium.org>
567
568         Reviewed by Mihai Parparita.
569
570         [chromium] fix for animated gif layout tests
571         https://bugs.webkit.org/show_bug.cgi?id=52008
572
573         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
574             to trigger gif animations.
575         (WebViewHostPaintTask::WebViewHostPaintTask):
576         (WebViewHostPaintTask::runIfValid):
577         (WebViewHost::updatePaintRect):
578         * DumpRenderTree/chromium/WebViewHost.h:
579         (WebViewHost::taskList):
580
581 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
582
583         Reviewed by Xan Lopez.
584
585         [GTK] Fix gtk2 compilation for master
586         https://bugs.webkit.org/show_bug.cgi?id=51885
587
588         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
589         (createBitmapContextFromWebView): Replaced the old
590         gdk_drawable_get_size with gdk_pixmap_get_size.
591
592 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
593
594         Reviewed by Laszlo Gombos.
595
596         [WINCE] Reenable NPAPI after r75203
597         https://bugs.webkit.org/show_bug.cgi?id=52109
598
599         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
600         it with !isEfl(), because EFL port does not support NPAPI (yet).
601
602         * Scripts/build-webkit:
603
604 2011-01-10  Adam Roben  <aroben@apple.com>
605
606         Skip some asserting JS tests
607
608         See <http://webkit.org/b/52156>.
609
610         * Scripts/run-javascriptcore-tests:
611
612 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
613
614         Reviewed by Xan Lopez.
615
616         [GTK] build-webkit disable Blob support via arguments passed to automake
617         https://bugs.webkit.org/show_bug.cgi?id=52097
618
619         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
620         build-webkit.
621
622 2011-01-10  Adam Roben  <aroben@apple.com>
623
624         Use the same name and description for TestNetscapePlugin on Windows and
625         Mac
626
627         Fixes <http://webkit.org/b/52151>
628         fast/frames/iframe-reparenting-plugins.html fails on Windows
629
630         Reviewed by Steve Falkenburg.
631
632         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
633         the name and description from Mac's Info.plist.
634
635 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
636
637         Reviewed by Laszlo Gombos.
638
639         [Qt][WK2] Guard gcc-specific syntax
640
641         Non-gcc based compliers choke on the "-include"
642         syntax for preinclude, place guard around it.
643
644         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
645         * WebKitTestRunner/qt/WebKitTestRunner.pro:
646
647 2011-01-10  Andreas Kling  <kling@webkit.org>
648
649         Reviewed by Simon Hausmann.
650
651         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
652         https://bugs.webkit.org/show_bug.cgi?id=52111
653
654         When getting a createNewPage() callback from QWKPage, create the
655         new page with the same QWKContext as the page that is passed to
656         the callback.
657
658         * MiniBrowser/qt/BrowserView.h:
659         * MiniBrowser/qt/BrowserWindow.cpp:
660         (newPageFunction):
661         (BrowserWindow::BrowserWindow):
662         * MiniBrowser/qt/BrowserWindow.h:
663
664 2011-01-10  Andreas Kling  <kling@webkit.org>
665
666         Reviewed by Kenneth Rohde Christiansen.
667
668         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
669
670         BrowserView set its own useless createNewPage() callback on QWKPage.
671         This was immediately overridden by BrowserWindow anyway, so remove
672         the BrowserView one.
673
674         * MiniBrowser/qt/BrowserView.cpp:
675         (BrowserView::BrowserView):
676
677 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
678
679         Reviewed by Jeremy Orlow.
680
681         [Chromium] Remove non-client-based Geolocation code
682         https://bugs.webkit.org/show_bug.cgi?id=50921
683
684         * DumpRenderTree/chromium/LayoutTestController.cpp:
685         (LayoutTestController::setGeolocationPermission):
686         (LayoutTestController::setMockGeolocationPosition):
687         (LayoutTestController::setMockGeolocationError):
688         * DumpRenderTree/chromium/WebViewHost.cpp:
689         (WebViewHost::geolocationClientMock):
690         (WebViewHost::reset):
691         * DumpRenderTree/chromium/WebViewHost.h:
692
693 2011-01-10  Eric Seidel  <eric@webkit.org>
694
695         Reviewed by Adam Barth.
696
697         Commit bot tried to land r? cq+ patch
698         https://bugs.webkit.org/show_bug.cgi?id=36638
699
700         It should now be possible to post a patch with r? and cq+ and the
701         commit-queue will correctly wait for the r+ before attempting to land the patch.
702         (This was a feature requested by several users.)
703
704         One caveat: We don't actually reject r-, cq+ patches from the queue
705         (we just ignore them), but I think that's OK for now.
706
707         I also noticed that setting r- once a commit-queue node had grabbed
708         a patch would not properly cancel the landing.  That's fixed and
709         tested in this patch.
710
711         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
712         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
713         * Scripts/webkitpy/tool/bot/feeders.py:
714         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
715
716 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
717
718         Reviewed by Kenneth Rohde Christiansen.
719
720         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
721         https://bugs.webkit.org/show_bug.cgi?id=51934
722
723         When accessing the network from the destructor of QWebPage, the network access manager
724         was already deleted because the object WebPage was already destructed.
725
726         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
727         The object is now destructed in the destructor of QObject.
728
729         * QtTestBrowser/webpage.cpp:
730         (WebPage::WebPage):
731         (WebPage::setQnamThreaded):
732         * QtTestBrowser/webpage.h:
733         (QtNAMThread::QtNAMThread):
734
735 2011-01-08  Eric Seidel  <eric@webkit.org>
736
737         Reviewed by Ojan Vafai.
738
739         test_failures.py should not mention TestShell (long live DumpRenderTree!)
740         https://bugs.webkit.org/show_bug.cgi?id=52067
741
742         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
743         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
744
745         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
746
747 2011-01-08  Eric Seidel  <eric@webkit.org>
748
749         Reviewed by Mihai Parparita.
750
751         commit-queue hangs when the ChangeLog diff is bad
752         https://bugs.webkit.org/show_bug.cgi?id=52072
753
754         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
755         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
756
757 2011-01-08  Adam Barth  <abarth@webkit.org>
758
759         Teach svn-apply how to re-write WebCore to Source/WebCore.
760
761         * Scripts/VCSUtils.pm:
762
763 2011-01-07  Adam Barth  <abarth@webkit.org>
764
765         Rubber-stamped by Eric Seidel.
766
767         Move WebCore to Source
768         https://bugs.webkit.org/show_bug.cgi?id=52050
769
770         Update the tools to understand WebCore's new location.
771
772         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
773         * DumpRenderTree/wscript:
774         * GNUmakefile.am:
775         * Scripts/build-webkit:
776         * Scripts/do-file-rename:
777         * Scripts/do-webcore-rename:
778         * Scripts/generate-qt-inspector-resource:
779         * Scripts/prepare-ChangeLog:
780         * Scripts/run-bindings-tests:
781         * Scripts/update-iexploder-cssproperties:
782         * Scripts/update-sources-list.py:
783         * Scripts/update-webkit-localizable-strings:
784         * Scripts/webkitdirs.pm:
785         * Scripts/webkitpy/common/config/build.py:
786         * Scripts/webkitpy/common/config/build_unittest.py:
787         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
788         * Scripts/webkitpy/style/checker.py:
789         * Scripts/webkitpy/style/checker_unittest.py:
790         * WebKitTestRunner/DerivedSources.pro:
791         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
792         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
793         * wx/browser/wscript:
794         * wx/build/settings.py:
795
796 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
797
798         Reviewed by Sam Weinig.
799
800         Make WebKitTestRunner rest between loads more robust to avoid test crashes
801         https://bugs.webkit.org/show_bug.cgi?id=52086
802
803         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
804         (WTR::InjectedBundle::didReceiveMessage):
805         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
806         (WTR::LayoutTestController::notifyDone):
807         * WebKitTestRunner/TestController.cpp:
808         (WTR::TestController::resetStateToConsistentValues):
809         (WTR::TestController::run):
810
811 2011-01-07  James Robinson  <jamesr@chromium.org>
812
813         Revert "Implement mozilla's animationTime property"
814         https://bugs.webkit.org/show_bug.cgi?id=51952
815
816         This approach isn't quite right.
817
818         * DumpRenderTree/chromium/WebViewHost.cpp:
819         (WebViewHost::paintInvalidatedRegion):
820
821 2011-01-07  Adam Roben  <aroben@apple.com>
822
823         Build master fix
824
825         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
826         (RunWebKitTests.start): Don't try to concatenate a list and a string.
827
828 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
829
830         Reviewed by Csaba Osztrogonác.
831
832         run-qtwebkit-tests should be able to kill a testsuite.
833
834         Add new option in the script that can setup a timeout for a test.
835         If the test execution takes more then specified time then the test
836         would be terminated.
837
838         [Qt] run-qtwebkit-tests needs timeout
839         https://bugs.webkit.org/show_bug.cgi?id=51894
840
841         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
842         * Scripts/run-qtwebkit-tests:
843
844 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
845
846         Unreviewed fix after r75233.
847
848         Based on idea from Eric Seidel.
849
850         Add remote zip file handling to webkitpy.
851         https://bugs.webkit.org/show_bug.cgi?id=50901
852
853         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
854
855 2011-01-07  Shane Stephens  <shanestephens@google.com>
856
857         Reviewed by Eric Seidel.
858
859         svn-apply: should support git binary delta diffs
860         https://bugs.webkit.org/show_bug.cgi?id=38864
861
862         * Scripts/VCSUtils.pm:
863         * Scripts/svn-apply:
864
865 2011-01-06  Julie Parent  <jparent@chromium.org>
866
867         Reviewed by Eric Seidel.
868
869         Test Result Server not removing old results.
870         https://bugs.webkit.org/show_bug.cgi?id=52012
871
872         * TestResultServer/model/jsonresults.py:
873         Fix off-by-one: Truncate if >= num_runs, not just >.
874         * TestResultServer/model/jsonresults_unittest.py:
875         Add unit test to test that merging in a new result with the same value
876         as the last result causes previous result to fall off.
877
878 2011-01-06  James Kozianski  <koz@chromium.org>
879
880         Reviewed by Mihai Parparita.
881
882         Add classes to provide a consistent interface to a set of files.
883         https://bugs.webkit.org/show_bug.cgi?id=50901
884
885         These classes allow us to write code that is agnostic to whether a
886         particular set of files resides in a local directory or in a zip file
887         on a remote machine.
888
889         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
890         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
891         * Scripts/webkitpy/common/system/fileset.py: Added.
892         * Scripts/webkitpy/common/system/filesystem.py:
893         * Scripts/webkitpy/common/system/filesystem_mock.py:
894         * Scripts/webkitpy/common/system/zipfileset.py: Added.
895         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
896
897 2011-01-06  Eric Seidel  <eric@webkit.org>
898
899         Reviewed by Adam Barth.
900
901         NetworkTransaction should log the url it is retrying
902         https://bugs.webkit.org/show_bug.cgi?id=52043
903
904         * Scripts/webkitpy/common/net/networktransaction.py:
905         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
906
907 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
908
909         Windows build fix.
910         Import os before using it.
911
912         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
913
914 2011-01-06  Eric Seidel  <eric@webkit.org>
915
916         Reviewed by Adam Barth.
917
918         StyleQueue fails to report errors when patches have many files
919         https://bugs.webkit.org/show_bug.cgi?id=52042
920
921         This is one of at least two errors preventing style error reporting at the moment.
922         When we moved to passing the list of files to check explicitly,
923         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
924         We could change the type of the QueueStatus.message type, or we could
925         just teach statusserver.py how to clamp values (and warn when it does).
926         I chose the latter path.
927
928         * Scripts/webkitpy/common/net/statusserver.py:
929
930 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
931
932         Reviewed by Stephanie Lewis.
933         
934         Fix syntax error in script.
935
936         Windows bots need to archive/unarchive builds to/from configuration-specific directories
937         https://bugs.webkit.org/show_bug.cgi?id=51996
938
939         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
940
941 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
942
943         Unreviewed, fixing WinCE build after r75196.
944
945         WinCE port does not (yet) support NPAPI.
946
947         * Scripts/build-webkit:
948
949 2011-01-06  Xan Lopez  <xlopez@igalia.com>
950
951         Reviewed by Darin Adler.
952
953         File::Spec->rel2abs in sunspider-compare-results mangles parameters
954         https://bugs.webkit.org/show_bug.cgi?id=52015
955
956         * Scripts/sunspider-compare-results: call rel2abs on our arguments
957         after the platform has been detected, otherwise the script will
958         mangle things like '--gtk' into '/a/path/--gtk', breaking the
959         detection.
960
961 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
962
963         Reviewed by Eric Seidel.
964
965         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
966         https://bugs.webkit.org/show_bug.cgi?id=51346
967
968         * Scripts/build-webkit:
969
970 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
971
972         Reviewed by Adam Roben.
973
974         Windows bots need to archive/unarchive builds to/from configuration-specific directories
975         https://bugs.webkit.org/show_bug.cgi?id=51996
976         
977         After the configuration directory change, we were archiving the incorrect directory for
978         build product, so we were running tests on the wrong binaries.
979         
980         This change archives the correct directory, and also unarchives it into a configuration-
981         specific directory.
982
983         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
984         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
985
986 2011-01-06  Eric Seidel  <eric@webkit.org>
987
988         Reviewed by Mihai Parparita.
989
990         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
991         https://bugs.webkit.org/show_bug.cgi?id=52002
992
993         See an example of this here:
994         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
995
996         It's due to the fact that we pass around TestFailure() instance
997         objects and yet expect them to all compare to be the same.
998
999         This is bad.  We should either have shared instances of these values
1000         or we should just pass around the class names.  There are already hacks
1001         in place to make TestFailure objects pass equality tests, I just added
1002         a __hash__ implementation so they can be used in sets as expected.
1003
1004         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1005         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1006
1007 2011-01-06  Evan Martin  <evan@chromium.org>
1008
1009         Reviewed by Tony Chang.
1010
1011         [gdb] handle inaccessible memory and UChar*
1012         https://bugs.webkit.org/show_bug.cgi?id=52003
1013
1014         To pretty-print a UChar*, we just grope around in the memory
1015         looking for a terminating NUL.  We need to handle the exception
1016         that can occur when we poke into an invalid location.
1017
1018         Additionally, the logic for choosing which pretty-printer would
1019         early return before hitting the point where we'd use the UChar*
1020         printer.  (Did this ever work?  How did it regress?)
1021
1022         * gdb/webkit.py:
1023
1024 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
1025
1026         Reviewed by Ada Chan.
1027
1028         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
1029         https://bugs.webkit.org/show_bug.cgi?id=51969
1030         
1031         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
1032
1033         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1034         (WTR::InjectedBundlePage::InjectedBundlePage):
1035         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
1036         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1037
1038 2011-01-06  James Robinson  <jamesr@chromium.org>
1039
1040         Reviewed by Simon Fraser.
1041
1042         Implement mozilla's animationTime property
1043         https://bugs.webkit.org/show_bug.cgi?id=51952
1044
1045         Chromium DRT support for webkitAnimationTime.
1046
1047         * DumpRenderTree/chromium/WebViewHost.cpp:
1048         (WebViewHost::paintInvalidatedRegion):
1049
1050 2011-01-06  Julie Parent  <jparent@chromium.org>
1051
1052         Reviewed by Tony Chang.
1053
1054         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
1055         https://bugs.webkit.org/show_bug.cgi?id=51217
1056
1057         * TestResultServer/model/jsonresults.py:
1058         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
1059         Adds missing documentation.
1060         * TestResultServer/model/jsonresults_unittest.py:
1061         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
1062         Update test_merge to take a number of builds to truncate at.
1063
1064 2011-01-06  Adam Barth  <abarth@webkit.org>
1065
1066         Reviewed by Eric Seidel.
1067
1068         The EWS should log outside of the working directory
1069         https://bugs.webkit.org/show_bug.cgi?id=51986
1070
1071         This patch prepare us for using git clean -x -d -f in the EWS wrapper
1072         script, which will actually clean the working copy back to a pristine
1073         state instead of leaving untracked directories and ignored files.
1074
1075         * Scripts/webkitpy/tool/commands/queues.py:
1076         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1077
1078 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1079
1080         Windows build fix.
1081         Back out attempted change to built-product-archive.
1082
1083         * BuildSlaveSupport/built-product-archive:
1084
1085 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1086
1087         Windows build fix.
1088         Include configuration name when unpacking a build archive.
1089
1090         Needed, since we split Windows build results into configuration-specific directories
1091         under WebKitOutputDir.
1092
1093         * BuildSlaveSupport/built-product-archive:
1094
1095 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1096
1097         Reviewed by Darin Adler.
1098
1099         Debug and Release builds on Windows clobber each other
1100         https://bugs.webkit.org/show_bug.cgi?id=49185
1101
1102         Changes the structure of WebKitBuild build products directory so we
1103         completely separate each build configuration into independent directories.
1104         
1105         Although we previously had per-configuration directories for obj, this change adds
1106         per-configuration directories for bin, lib, obj, and include. Each configuration's
1107         build products are stored within a directory inside of WebKitBuild.
1108         
1109         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
1110         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
1111
1112         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
1113         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
1114         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
1115         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
1116         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
1117         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
1118         * DumpRenderTree/win/ImageDiffCommon.vsprops:
1119         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
1120         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
1121         * FindSafari/FindSafari.vcproj:
1122         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
1123         * MiniBrowser/MiniBrowserPostBuild.cmd:
1124         * MiniBrowser/MiniBrowserPreBuild.cmd:
1125         * Scripts/webkitdirs.pm:
1126         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
1127         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
1128         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
1129         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
1130         * TestWebKitAPI/win/copy-resources.cmd:
1131         * WebKitAPITest/WebKitAPITestCommon.vsprops:
1132         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
1133         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
1134         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
1135         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
1136         * WebKitTestRunner/win/InjectedBundle.vcproj:
1137         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
1138         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
1139         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
1140         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
1141         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
1142         * WinLauncher/WinLauncherCommon.vsprops:
1143         * WinLauncher/WinLauncherPostBuild.cmd:
1144         * WinLauncher/WinLauncherPreBuild.cmd:
1145
1146 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
1147
1148         Reviewed by Ariya Hidayat.
1149
1150         [Qt] TestNetscapePlugin doesn't link on OS X
1151         https://bugs.webkit.org/show_bug.cgi?id=51948
1152
1153         Only add a dependency on libX11 on X11 systems
1154
1155         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1156
1157 2011-01-05  Jeff Miller  <jeffm@apple.com>
1158
1159         Reviewed by Adam Roben.
1160
1161         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
1162         https://bugs.webkit.org/show_bug.cgi?id=51970
1163
1164         * Scripts/webkitpy/style/checker.py:
1165         Add -readability/naming for WebKit2 C API directories.
1166
1167 2011-01-05  Eric Seidel  <eric@webkit.org>
1168
1169         Unreviewed, just fixing one more log error from my previous python patch.
1170
1171         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1172         https://bugs.webkit.org/show_bug.cgi?id=51802
1173
1174         webkit-patch failure-reason was logging about parsing errors
1175         due to my misunderstanding of how BeautifulSoup.findAll worked.
1176
1177         Fixed, and added a unit test.
1178
1179         * Scripts/webkitpy/common/net/layouttestresults.py:
1180         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1181
1182 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
1183
1184         Reviewed by Kenneth Rohde Christiansen.
1185
1186         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
1187         https://bugs.webkit.org/show_bug.cgi?id=51951
1188
1189         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
1190         to create new window from WebKit.
1191
1192         * MiniBrowser/qt/BrowserWindow.cpp:
1193         (newPageFunction):
1194         (BrowserWindow::BrowserWindow):
1195         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
1196         (BrowserWindow::newWindow):
1197         (BrowserWindow::updateUserAgentList):
1198         (BrowserWindow::showUserAgentDialog):
1199         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
1200         define the type of the backing store used for new windows.
1201         * MiniBrowser/qt/main.cpp:
1202         (main):
1203
1204 2011-01-05  Eric Seidel  <eric@webkit.org>
1205
1206         Reviewed by Ojan Vafai.
1207
1208         commit-queue should report failure type when reporting flaky tests
1209         https://bugs.webkit.org/show_bug.cgi?id=51900
1210
1211         This patch was a ridiculous amount of plumbing.  In the end I like
1212         the NRWT-style TestResult class even less.  But now we're passing
1213         a list of TestResult objects from the queue to the FlakyTestReporter.
1214         Thus the FlakyTestReporter can more easily report what type of failure
1215         occurred.
1216
1217         In the process, I found that I was not alone in finding TestResult
1218         cumbersome to use.  A bunch of code was trying to create a TestResult
1219         object with default values.  However since the constructor didn't make
1220         this easy, some places were getting it wrong (including the TestResult unit test)!
1221         I've fixed the TestResult constructor to have default values for non-essential
1222         arguments.
1223
1224         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1225         * Scripts/webkitpy/common/net/layouttestresults.py:
1226         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1227         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1228         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1229         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1230         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
1231         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
1232         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1233         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1234         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1235         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1236         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1237         * Scripts/webkitpy/tool/commands/queues.py:
1238         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1239
1240 2011-01-05  Eric Seidel  <eric@webkit.org>
1241
1242         Unreviewed.
1243
1244         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1245         https://bugs.webkit.org/show_bug.cgi?id=51802
1246
1247         Add another unit test to cover a previously missing import.
1248
1249         * Scripts/webkitpy/common/net/layouttestresults.py:
1250         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1251
1252 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
1253
1254         Reviewed by David Levin.
1255
1256         Add mihaip@chromium.org as a reviewer
1257         https://bugs.webkit.org/show_bug.cgi?id=51966
1258         
1259         Add myself as a reviewer.
1260
1261         * Scripts/webkitpy/common/config/committers.py:
1262
1263 2011-01-05  James Simonsen  <simonjam@chromium.org>
1264
1265         Unreviewed. Adding myself to the list of committers.
1266
1267         * Scripts/webkitpy/common/config/committers.py:
1268
1269 2011-01-05  Eric Seidel  <eric@webkit.org>
1270
1271         Unreviewed.
1272
1273         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1274         https://bugs.webkit.org/show_bug.cgi?id=51802
1275
1276         Fix two exceptions seen on the bots after my original commit.
1277
1278         * Scripts/webkitpy/common/net/layouttestresults.py:
1279         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1280
1281 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
1282
1283         Reviewed by Andreas Kling.
1284
1285         [Qt]Add local storage settings to QtTestBrowser command line arguments 
1286         https://bugs.webkit.org/show_bug.cgi?id=51750
1287
1288         * QtTestBrowser/main.cpp:
1289         (LauncherApplication::handleUserOptions):
1290          Local storage settings can be enable form command line arguments for
1291          QtTestBrowser.
1292
1293 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
1294
1295         Reviewed by Martin Robinson.
1296
1297         GTK: AX: DRT needs to use correct root object method.
1298         https://bugs.webkit.org/show_bug.cgi?id=51911
1299
1300         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1301         (AccessibilityController::rootElement):
1302
1303 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1304
1305         Rubber-stamped by Csaba Osztrogonác.
1306
1307         Based on idea from Péter Gál.
1308
1309         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
1310
1311 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1312
1313         Reviewed by Adam Barth.
1314
1315         sheriff-bot should be able to do multi-revision rollouts
1316         https://bugs.webkit.org/show_bug.cgi?id=51176
1317
1318         * Scripts/webkitpy/tool/bot/irc_command.py:
1319         * Scripts/webkitpy/tool/bot/sheriff.py:
1320         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1321
1322 2011-01-05  Eric Seidel  <eric@webkit.org>
1323
1324         Reviewed by Adam Barth.
1325
1326         queues.webkit.org should have per-bot status pages
1327         https://bugs.webkit.org/show_bug.cgi?id=51906
1328
1329         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
1330         statuses from a single queue.  Now that we have many bots servicing
1331         some queues (commit-queue, win-ews, etc.) its easy to have the messages
1332         you care about scroll off the end of the 15-message limit on the main page.
1333
1334         Eventually we should probably rename /queue-status to /queue or /queues,
1335         but that's fodder for another patch.
1336
1337         * QueueStatusServer/handlers/queuestatus.py:
1338         * QueueStatusServer/index.yaml:
1339         * QueueStatusServer/main.py:
1340         * QueueStatusServer/templates/includes/singlequeuestatus.html:
1341          - This probably should use a custom filter instead of hard-coding
1342            the URL scheme here, but I couldn't figure out how to easily
1343            create such a filter.  Most filters work with "strings" so we can't
1344            pass the status object.  We could add a method to the status
1345            object and call that, but that seemed a bit strange too.
1346         * QueueStatusServer/templates/queuestatus.html:
1347
1348 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1349
1350         Unreviewed. Adding myself to the list of committers.
1351
1352         * Scripts/webkitpy/common/config/committers.py:
1353
1354 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
1355
1356         Reviewed by David Levin.
1357
1358         check-webkit-style treated some macros with parentheses after #elif as function calls
1359         https://bugs.webkit.org/show_bug.cgi?id=51695
1360
1361         Ingore function call space checking in any preprocessor directives
1362         (things starting with #). Change search() to match() because 
1363         preprocessor directives are supposed to be in the beginning of lines.
1364
1365         * Scripts/webkitpy/style/checkers/cpp.py:
1366         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
1367
1368 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
1369
1370         Reviewed by Tony Chang.
1371
1372         Change the --multi-load test option to --stress-opt
1373         https://bugs.webkit.org/show_bug.cgi?id=50751
1374
1375         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1376         (runTest):
1377         (main):
1378         * DumpRenderTree/chromium/TestShell.cpp:
1379         (TestShell::TestShell):
1380         * DumpRenderTree/chromium/TestShell.h:
1381         (TestShell::stressOpt):
1382         (TestShell::setStressOpt):
1383         (TestShell::stressDeopt):
1384         (TestShell::setStressDeopt):
1385         (TestShell::javaScriptFlags):
1386         (TestShell::setJavaScriptFlags):
1387         * Scripts/webkitpy/layout_tests/port/chromium.py:
1388         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1389
1390 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
1391
1392         Reviewed by Sam Weinig.
1393
1394         WK2: Support Accessibility
1395         https://bugs.webkit.org/show_bug.cgi?id=51859
1396
1397         Use rootObject() method to get top of accessibility tree.
1398
1399         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1400         (AccessibilityController::focusedElement):
1401         (AccessibilityController::rootElement):
1402
1403 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
1404
1405         Reviewed by Darin Adler.
1406
1407         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
1408         https://bugs.webkit.org/show_bug.cgi?id=51846
1409
1410         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
1411         back to GRefPtr.
1412
1413 2011-01-04  Zhe Su  <suzhe@chromium.org>
1414
1415         Reviewed by Kenneth Russell.
1416
1417         Fix insertText, setMarkedText and unmarkText methods of
1418         TextInputController to call corresponding methods of WebKit::WebView
1419         rather than WebKit::WebFrame. This change matches the behavior of
1420         chromium browser.
1421         insertText corresponds to WebView::confirmComposition(text)
1422         setMarkedText corresponds to WebView::setComposition(...)
1423         unmarkText corresponds to WebView::confirmComposition()
1424         https://bugs.webkit.org/show_bug.cgi?id=51693
1425
1426         * DumpRenderTree/chromium/TextInputController.cpp:
1427         (TextInputController::insertText):
1428         (TextInputController::setMarkedText):
1429         (TextInputController::unmarkText):
1430
1431 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
1432
1433         Reviewed by Laszlo Gombos.
1434
1435         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
1436
1437         On Symbian productDir points to the source directory. Removing all the
1438         empty files from the productDir directory corrupts the svn repository.
1439
1440         * Scripts/build-webkit:
1441
1442 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
1443
1444         Reviewed by Adam Barth.
1445
1446         [Qt] Add SelectAll option to the context menu for the editor
1447         https://bugs.webkit.org/show_bug.cgi?id=50049
1448
1449         Set shortcut for the SelectAll action.
1450
1451         * QtTestBrowser/mainwindow.cpp:
1452         (MainWindow::buildUI):
1453
1454 2011-01-03  David Levin  <levin@chromium.org>
1455
1456         Reviewed by Eric Seidel.
1457
1458         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
1459         https://bugs.webkit.org/show_bug.cgi?id=51842
1460
1461         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
1462         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
1463
1464 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
1465
1466         Reviewed by David Kilzer.
1467
1468         [WINCE] Adds a build slave.
1469         https://bugs.webkit.org/show_bug.cgi?id=50523
1470
1471         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
1472         entry for a release build of the WinCE port.
1473         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
1474         flag to build the WinCE port.
1475
1476 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
1477
1478         Reviewed by David Kilzer.
1479
1480         Add WinCE support to build-webkit
1481         https://bugs.webkit.org/show_bug.cgi?id=51642
1482
1483         * Scripts/build-webkit:
1484         * Scripts/webkitdirs.pm:
1485
1486 2011-01-03  Eric Seidel  <eric@webkit.org>
1487
1488         Reviewed by Adam Barth.
1489
1490         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1491         https://bugs.webkit.org/show_bug.cgi?id=51802
1492
1493         I'm not the biggest fan of the test_failures or test_results classes,
1494         but it's better to have one shared set of classes, than separate ones
1495         for new vs. old run-webkit-test result handling.
1496
1497         This moves the ORWT results class "LayoutTestResults" over to using
1498         TestResult and TestFailure classes, making it easy for us to
1499         make all our sheriff-bot and other webkitpy code NRWT ready.
1500
1501         This also makes it a trivial patch to generate results.json information
1502         from ORWT results.html files (for flaky test analysis, etc.) as well
1503         as making it a one-liner to report test failure types when the
1504         commit-queue sees flaky tests.
1505
1506         This patch tried not to add new functionality, but only to replace
1507         the guts of LayoutTestResults, while adding unit tests and hoping
1508         not to break anything.
1509
1510         I also moved callers which assumed User.prompt* were static/class methods
1511         to using them as instance methods (since we'll eventually want to make them such).
1512
1513         In the process of re-writing things, I broke the rebaseline command, so I wrote
1514         a unit test to catch my breakage were I do do so again in the future.
1515
1516         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1517         * Scripts/webkitpy/common/net/layouttestresults.py:
1518         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1519         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1520         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
1521         * Scripts/webkitpy/tool/commands/queries.py:
1522         * Scripts/webkitpy/tool/commands/rebaseline.py:
1523         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1524         * Scripts/webkitpy/tool/mocktool.py:
1525
1526 2011-01-03  Adam Barth  <abarth@webkit.org>
1527
1528         Reviewed by Simon Fraser.
1529
1530         webkit-patch shouldn't waste time cleaning a working directory that's already clean
1531         https://bugs.webkit.org/show_bug.cgi?id=51840
1532
1533         * Scripts/webkitpy/common/checkout/scm.py:
1534
1535 2011-01-03  Adam Barth  <abarth@webkit.org>
1536
1537         Reviewed by Simon Fraser.
1538
1539         webkit-patch should only hide update output if --quiet
1540         https://bugs.webkit.org/show_bug.cgi?id=51838
1541
1542         As requested by smfr.
1543
1544         * Scripts/webkitpy/tool/steps/update.py:
1545
1546 2011-01-03  Adam Barth  <abarth@webkit.org>
1547
1548         Reviewed by David Levin.
1549
1550         commit-queue shouldn't reject patches twice if two bots process the same patch
1551         https://bugs.webkit.org/show_bug.cgi?id=51805
1552
1553         Before raising an error, we first check whether the patch is still in
1554         the commit-queue.  This check is still racy, of course, but the time
1555         window is much smaller.
1556
1557         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1558
1559 2011-01-03  Sam Weinig  <sam@webkit.org>
1560
1561         Reviewed by Anders Carlsson.
1562
1563         Make run-api-tests less chatty.
1564         https://bugs.webkit.org/show_bug.cgi?id=51831
1565
1566         - Make script quiet by default and add --verbose option (replacing --quiet).
1567         - When not verbose, pipe stdout and stderr to devnull.
1568
1569         * Scripts/run-api-tests:
1570
1571 2011-01-03  Pratik Solanki  <psolanki@apple.com>
1572
1573         Unreviewed. Adding myself to committers.py.
1574
1575         * Scripts/webkitpy/common/config/committers.py:
1576
1577 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
1578
1579         Reviewed by Xan Lopez.
1580
1581         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
1582         https://bugs.webkit.org/show_bug.cgi?id=51806
1583
1584         Originally, the $libraryName is 'JavaScriptCore'. When building release 
1585         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
1586         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
1587         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 
1588         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
1589         so make it 'WebKitBuild/Release/.libs'
1590
1591         * Scripts/webkitdirs.pm: 
1592
1593 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
1594
1595         Reviewed by Adam Barth.
1596
1597         Make EFL a core builder
1598         https://bugs.webkit.org/show_bug.cgi?id=51804
1599
1600         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1601         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1602
1603 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
1604
1605         [Qt] Unreviewed fix after r74855 and r74875.
1606
1607         * BuildSlaveSupport/built-product-archive:
1608          - Create directories explicitly.
1609          - Pass shell=True to subprocess.call().
1610
1611 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
1612
1613         [Qt] Unreviewed fix after r74855.
1614
1615         Move JavaScriptCore to Source
1616         https://bugs.webkit.org/show_bug.cgi?id=51604
1617
1618         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
1619
1620 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
1621
1622         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
1623
1624         Move JavaScriptCore to Source
1625         https://bugs.webkit.org/show_bug.cgi?id=51604
1626
1627         * Scripts/webkitdirs.pm:
1628
1629 2011-01-02  Robert Hogan  <robert@webkit.org>
1630
1631         Unreviewed, build fix.
1632
1633         [Qt] Fix DRT build after 74855
1634
1635         * DumpRenderTree/qt/DumpRenderTree.pro:
1636
1637 2011-01-01  Adam Barth  <abarth@webkit.org>
1638
1639         Remove the assumption from the Qt and Gtk builds that every project is
1640         in the root directory.
1641
1642         * Scripts/build-webkit:
1643
1644 2011-01-01  Adam Barth  <abarth@webkit.org>
1645
1646         Reviewed by Eric Seidel.
1647
1648         Teach svn-apply how to apply patches even though JavaScriptCore has moved
1649         https://bugs.webkit.org/show_bug.cgi?id=51796
1650
1651         After this change, svn-apply will magically apply patches to
1652         JavaScriptCore/foo to Source/JavaScriptCore/foo.
1653
1654         * Scripts/VCSUtils.pm:
1655
1656 2011-01-01  Adam Barth  <abarth@webkit.org>
1657
1658         Reviewed by Eric Seidel.
1659
1660         Move JavaScriptCore to Source
1661         https://bugs.webkit.org/show_bug.cgi?id=51604
1662
1663         Update references to JavaScriptCore to point to the new location.
1664
1665         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1666         * DumpRenderTree/qt/DumpRenderTree.pro:
1667         * DumpRenderTree/qt/ImageDiff.pro:
1668         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1669         * DumpRenderTree/wscript:
1670         * Scripts/build-jsc:
1671         * Scripts/build-webkit:
1672         * Scripts/do-file-rename:
1673         * Scripts/do-webcore-rename:
1674         * Scripts/run-javascriptcore-tests:
1675         * Scripts/update-javascriptcore-test-results:
1676         * Scripts/webkitdirs.pm:
1677         * Scripts/webkitpy/common/config/build_unittest.py:
1678         * Scripts/webkitpy/style/checker.py:
1679         * Scripts/webkitpy/style/checker_unittest.py:
1680         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1681         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1682         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1683         * wx/build/settings.py:
1684
1685 2011-01-01  Adam Barth  <abarth@webkit.org>
1686
1687         Reviewed by Eric Seidel.
1688
1689         Move Sources to Source
1690         https://bugs.webkit.org/show_bug.cgi?id=51794
1691
1692         Update scripts to point to the new location.
1693
1694         * Scripts/build-webkit:
1695         * Scripts/do-file-rename:
1696         * Scripts/do-webcore-rename:
1697         * Scripts/webkitpy/common/config/build.py:
1698         * Scripts/webkitpy/common/config/build_unittest.py:
1699
1700 2010-12-31  Kent Tamura  <tkent@chromium.org>
1701
1702         Reviewed by Eric Seidel.
1703
1704         [DRT/Chromium] Enable mock spell checker on non-OSX
1705         https://bugs.webkit.org/show_bug.cgi?id=51401
1706
1707         * DumpRenderTree/chromium/WebViewHost.cpp:
1708         (WebViewHost::spellCheck):
1709
1710 2010-12-31  Adam Barth  <abarth@webkit.org>
1711
1712         Reviewed by Ariya Hidayat.
1713
1714         Remove Tools/Scripts/wkstyle
1715         https://bugs.webkit.org/show_bug.cgi?id=51774
1716
1717         This script appears to not have been touched in a while and seems to
1718         have been replaced by check-webkit-style.
1719
1720         * Scripts/wkstyle: Removed.
1721
1722 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
1723
1724         Unreviewed. Coding style fix.
1725
1726         * DumpRenderTree/chromium/TestShell.h:
1727
1728 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
1729
1730         Reviewed by Pavel Feldman.
1731
1732         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
1733
1734         It was a problem with Chromium DRT. DevToolsAgent object instance was
1735         attached not only to the inspected page but to the DevTools window too.
1736         As result all the inspector files were interpreted as a content of inspected page
1737         and were transfered to the DevTools scripts panel for debugging etc.
1738
1739         https://bugs.webkit.org/show_bug.cgi?id=51735
1740
1741         * DumpRenderTree/chromium/TestShell.cpp:
1742         (TestShell::TestShell):
1743         (TestShell::bindJSObjectsToWindow):
1744         (TestShell::createNewWindow):
1745         * DumpRenderTree/chromium/TestShell.h:
1746
1747 2010-12-31  Adam Barth  <abarth@webkit.org>
1748
1749         Rubber-stamped by Eric Seidel.
1750
1751         Move PageLoadTests to PerformanceTests/PageLoad
1752         https://bugs.webkit.org/show_bug.cgi?id=51771
1753
1754         Update references to PageLoadTests to point to the new location.
1755
1756         * Scripts/run-pageloadtest:
1757         * Scripts/webkitpy/common/config/build.py:
1758
1759 2010-12-31  Adam Barth  <abarth@webkit.org>
1760
1761         Rubber-stamped by Eric Seidel.
1762
1763         Move SunSpider into PerformanceTests
1764         https://bugs.webkit.org/show_bug.cgi?id=51769
1765
1766         Update these scripts to point to the new location.
1767
1768         * Scripts/run-sunspider:
1769         * Scripts/sunspider-compare-results:
1770
1771 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
1772
1773         Reviewed by Kent Tamura.
1774
1775         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
1776         https://bugs.webkit.org/show_bug.cgi?id=51728
1777         
1778         Add implementation of the Mac WebThemeEngine that uses an NSScroller
1779         to render top-level scrollbars. This makes them match the Mac port's
1780         use of an NSScrollView, which means that we'll be able to share more
1781         pixel baselines.
1782         
1783         The new rendering code will not be activated until the 
1784         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
1785         ScrollbarThemeChromiumMac.
1786
1787         * DumpRenderTree/DumpRenderTree.gypi:
1788         * DumpRenderTree/chromium/TestShellMac.mm:
1789         (platformInit):
1790         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
1791         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
1792         (+[FakeActiveWindow alwaysActiveWindow]):
1793         (+[FakeActiveWindow alwaysInactiveWindow]):
1794         (-[FakeActiveWindow initWithActiveControls:]):
1795         (-[FakeActiveWindow _hasActiveControls]):
1796         (WebThemeEngineDRTMac::paintScrollbarThumb):
1797         (stateToHIEnableState):
1798         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
1799         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
1800
1801 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
1802
1803         Reviewed by David Kilzer.
1804
1805         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
1806         used
1807         https://bugs.webkit.org/show_bug.cgi?id=51672
1808
1809         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
1810         with USE_SYSTEM_MALLOC=1
1811         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
1812         with USE_SYSTEM_MALLOC=1
1813
1814 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1815
1816         Reviewed by David Kilzer.
1817
1818         [Qt] [Symbian] Fix build-webkit script for Symbian
1819         https://bugs.webkit.org/show_bug.cgi?id=51509
1820
1821         Set the OUTPUT_DIR for Symbian to be the same as the source
1822         directory.
1823
1824         * Scripts/webkitdirs.pm:
1825
1826 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
1827
1828         Reviewed by Darin Adler.
1829
1830         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
1831         https://bugs.webkit.org/show_bug.cgi?id=51758
1832
1833         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
1834
1835         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
1836         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
1837
1838 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
1839
1840         Unreviewed WinCE buildfix.
1841
1842         * WinCELauncher/main.cpp: Add missing include.
1843
1844 2010-12-29  Daniel Bates  <dbates@rim.com>
1845
1846         Reviewed by Darin Adler.
1847
1848         svn-apply updates date of wrong change log entry for a change log diff that
1849         contains two consecutive entries with the same author and date
1850         https://bugs.webkit.org/show_bug.cgi?id=46061
1851
1852         Fixes an issue where the date of the wrong change log entry may be modified.
1853         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
1854         in a ChangeLog file to the top of the file.
1855
1856         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
1857         diff when it detects that the diff inserts a change log entry earlier in a
1858         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
1859         change. With the advent of the commit-queue this functionality of bailing out
1860         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
1861         Instead, we should always move the change log entry to the top of the ChangeLog file.
1862
1863         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
1864         the date line of the correct change log entry in a ChangeLog diff.
1865
1866         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
1867
1868         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
1869           Updated the following unit tests now that we move entries inserted earlier to the top:
1870           - "fixChangeLogPatch: New entry inserted in middle."
1871             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
1872
1873           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
1874             (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
1875
1876         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
1877
1878 2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>
1879
1880         Reviewed by Eric Seidel.
1881
1882         [Qt] Fixed compatibility with gold linker on X11 platforms
1883         https://bugs.webkit.org/show_bug.cgi?id=51700
1884
1885         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1886         Linked TestNetscapePlugin with libX11 on Unix platforms
1887
1888 2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
1889
1890         Reviewed by Darin Adler.
1891
1892         Circular dependency in webkitpy.common.checkout.changelog module
1893         https://bugs.webkit.org/show_bug.cgi?id=50475
1894
1895         Remove automatic import of api.Checkout module when any checkout/
1896         submodule is imported (e.g.: when checkout.scm.Git is imported).
1897
1898         * Scripts/webkitpy/common/checkout/__init__.py:
1899
1900 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
1901
1902         Reviewed by Ojan Vafai.
1903
1904         prepare-ChangeLog should support the -g option for specifying the git-commit
1905         https://bugs.webkit.org/show_bug.cgi?id=51708
1906
1907         Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
1908         webkit-patch, though the exact meaning of the two options remain different.
1909
1910         * Scripts/prepare-ChangeLog: Add -g.
1911
1912 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
1913
1914         Reviewed by Simon Hausmann.
1915
1916         [Qt] Fix compilation with Qt in namespace
1917         https://bugs.webkit.org/show_bug.cgi?id=51701
1918
1919         * QtTestBrowser/webview.h:
1920
1921 2010-12-28  Daniel Bates  <dbates@rim.com>
1922
1923         Reviewed by Sam Weinig.
1924
1925         Substitute // MARK: for compiler-specific #pragma mark
1926         https://bugs.webkit.org/show_bug.cgi?id=51657
1927
1928         Fix future compilation warnings about "#pragma mark" on GTK+ bots by
1929         substituting  "// MARK:" for "#pragma mark", which provides
1930         analogous code-bookmarking functionality under Xcode.
1931
1932         Also, for consistency, we should substitute "// MARK:" for compiler-
1933         specific "#pragma mark" in the source files for the Mac port.
1934
1935         * DumpRenderTree/AccessibilityTextMarker.cpp:
1936         * DumpRenderTree/cf/WebArchiveDumpSupport.h:
1937         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
1938         * DumpRenderTree/mac/ObjCController.m:
1939         * MiniBrowser/mac/AppDelegate.m:
1940         * MiniBrowser/mac/BrowserWindowController.m:
1941
1942 2010-12-28  Xan Lopez  <xlopez@igalia.com>
1943
1944         Reviewed by Eric Seidel.
1945
1946         Add --no-build option to run-sunspider
1947         https://bugs.webkit.org/show_bug.cgi?id=51658
1948
1949         * Scripts/run-sunspider: add --no-build flag to skip building
1950         phase.
1951
1952 2010-12-27  Daniel Bates  <dbates@rim.com>
1953
1954         Rubber-stamped by Martin Robinson.
1955
1956         Append the directory Tools/DumpRenderTree to the list of directories that
1957         do-webcore-rename should search so that it can rename DRT files and
1958         source code.
1959
1960         * Scripts/do-webcore-rename:
1961
1962 2010-12-27  Eric Seidel  <eric@webkit.org>
1963
1964         Reviewed by Adam Barth.
1965
1966         build-webkit should detect missing Java SDK and explain how to install it
1967         https://bugs.webkit.org/show_bug.cgi?id=51651
1968
1969         * Scripts/build-webkit:
1970
1971 2010-12-26  Martin Robinson  <mrobinson@igalia.com>
1972
1973         Reviewed by Daniel Bates.
1974
1975         [GTK] Add support for build-jsc
1976         https://bugs.webkit.org/show_bug.cgi?id=51625
1977
1978         Add GTK+ support to build-jsc now that building the jsc executable as
1979         a standalone target is easy.
1980
1981         * Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
1982         * Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
1983         * Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject
1984         and pass it along to buildAutotoolsProject.
1985
1986 2010-12-27  David Levin  <levin@chromium.org>
1987
1988         Reviewed by Eric Seidel.
1989
1990         check-webkit-style check for meaningless variable names in function declarations.
1991         https://bugs.webkit.org/show_bug.cgi?id=51523
1992
1993         * Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp
1994         from the new check and whitespace/parens because the syntax is unusual and
1995         produced a fair number of positives for these checks.
1996         * Scripts/webkitpy/style/checkers/cpp.py:
1997         (_convert_to_lower_with_underscores): Used as a canonical form for type names
1998         and parameter names when determining if the parameter name is useless.
1999         (_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
2000         (Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
2001         format.
2002         (_check_parameter_name_against_text):  Checks to see if the parameter name is in the
2003         text or an acronym of it.
2004         (check_function_definition): Checks function definitions for meaningless variable names.
2005         (process_line): Added call to check_function_definition.
2006         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2007         (CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
2008         (CppFunctionsTest.test_create_acronym): Test for _create_acronym.
2009         (CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
2010         (CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
2011         because when only checking a snippet, there are a lot of bogus functions.
2012         (CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
2013         that I put there previously and just noticed.
2014         (WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
2015         check_function_definition and process_line.
2016
2017 2010-12-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2018
2019         Reviewed by Martin Robinson.
2020
2021         [GTK] Disable flash plugin in GtkLauncher when using gtk3
2022         https://bugs.webkit.org/show_bug.cgi?id=51591
2023
2024         Flash plugin uses gtk2 that is incompatible with gtk3 making
2025         webkit crash when it's built with gtk3.
2026
2027         * GtkLauncher/main.c:
2028         (main):
2029
2030 2010-12-25  Adam Barth  <abarth@webkit.org>
2031
2032         Reviewed by Eric Seidel.
2033
2034         Move ANGLE to Sources/ThirdParty
2035         https://bugs.webkit.org/show_bug.cgi?id=51605
2036
2037         * Scripts/build-webkit:
2038           - Point to the new ANGLE location.
2039
2040 2010-12-26  David Levin  <levin@chromium.org>
2041
2042         Reviewed by Eric Seidel.
2043
2044         check-webkit-style should be able to parse function declaration parameters.
2045         https://bugs.webkit.org/show_bug.cgi?id=51451
2046
2047         * Scripts/webkitpy/style/checkers/cpp.py:
2048         (Position.__init__): Holds simple position information (row, column).
2049         (Parameter.__init__): Holds information about a parameter.
2050         (SingleLineView.__init): Converts multiple lines into a single line for simpler searches.
2051         (SingleLineView.convert_column_to_row): Returns the original row given a column.
2052         (create_skeleton_parameters): Simplifies a parameter list for easier searching.
2053         (find_parameter_name_index): Finds where the parameter name is.
2054         (parameter_list): Generates the list of parameters for a function.
2055         (_FunctionState.begin): Added information to allow determining the parameters
2056         on demand.
2057         (_FunctionState.get_parameter_list): Returns a tuple of function parameters.
2058         (detect_functions): Improve function detection for operator functions and
2059         determine where the parameters end and pass that to _FunctionState.begin.
2060         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2061         (CppFunctionsTest.test_parameter): Verifies Parameter functionality.
2062         (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality.
2063         (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters.
2064         (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index.
2065         (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list.
2066         Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list.
2067         (FunctionDetectionTest.perform_function_detection): Added support for verifying
2068         the parameters found.
2069         (FunctionDetectionTest.test_function_declaration_detection): Added more function
2070         detection test to verify that we catch the operator functions.
2071         (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros.
2072         (FunctionDetectionTest.test_parameter_list): Added tests to verify the parameter parsing.
2073         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Removed
2074         because the error. The test is about the bad function name. Fixing the name makes the test exactly like
2075         test_function_length_check_definition_severity1_for_test.
2076
2077 2010-12-25  Patrick Gansterer  <paroga@webkit.org>
2078
2079         Unreviewed WinCE buildfix after r74334.
2080
2081         * CMakeListsWinCE.txt:
2082
2083 2010-12-24  Sheriff Bot  <webkit.review.bot@gmail.com>
2084
2085         Unreviewed, rolling out r74632.
2086         http://trac.webkit.org/changeset/74632
2087         https://bugs.webkit.org/show_bug.cgi?id=51600
2088
2089         makes test-webkitpy hang forever on GTK (Requested by philn-tp
2090         on #webkit).
2091
2092         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2093         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2094
2095 2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>
2096
2097         Reviewed by Kenneth Rohde Christiansen.
2098
2099         [EFL] Screen doesn't be rendered when changing size of EWebLauncher
2100         https://bugs.webkit.org/show_bug.cgi?id=43528
2101
2102         Remove on_resize because ewk_view_fixed_layout_size_set should not be
2103         called on callback of EVAS_CALLBACK_RESIZE. As it change size of
2104         FrameView, rendering was ignored when _ewk_view_smart_calculate was
2105         called.
2106
2107         * EWebLauncher/main.c:
2108         (browserCreate):
2109
2110 2010-12-24  Eric Seidel  <eric@webkit.org>
2111
2112         Reviewed by Adam Barth.
2113
2114         webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
2115         https://bugs.webkit.org/show_bug.cgi?id=28291
2116
2117         This is a start.  At least now webkit-patch will prompt when your ChangeLog looks questionable.
2118         We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
2119         to strings with find in the diff.
2120         Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.
2121
2122         * Scripts/webkitpy/common/checkout/api.py:
2123         * Scripts/webkitpy/common/checkout/diff_parser.py:
2124         * Scripts/webkitpy/tool/steps/abstractstep.py:
2125         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
2126         * Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
2127         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
2128         * Scripts/webkitpy/tool/steps/validatereviewer.py:
2129
2130 2010-12-24  Dirk Pranke  <dpranke@chromium.org>
2131
2132         Reviewed by Kenneth Russell.
2133
2134         Modify new-run-webkit-tests to shut up and exit when all the threads
2135         are wedged so that test runs complete faster and we don't end up
2136         w/ enormous log files.
2137
2138         https://bugs.webkit.org/show_bug.cgi?id=51572
2139
2140         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2141         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2142
2143 2010-12-24  Eric Seidel  <eric@webkit.org>
2144
2145         Reviewed by David Levin.
2146
2147         commit-queue should better explain how it will re-open bugs and follow duplicate chains
2148         https://bugs.webkit.org/show_bug.cgi?id=51549
2149
2150         I've had multiple people ask me about the commit-queue's behavior
2151         regarding reporting flaky tests.  I figured it would be best to just
2152         have the queue explain itself in the bugs it files.
2153
2154         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2155         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2156
2157 2010-12-24  Shinichiro Hamaji  <hamaji@chromium.org>
2158
2159         Reviewed by Eric Seidel.
2160
2161         check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt
2162         https://bugs.webkit.org/show_bug.cgi?id=51467
2163
2164         * Scripts/webkitpy/style/checker.py:
2165         * Scripts/webkitpy/style/checker_unittest.py:
2166
2167 2010-12-23  Adam Barth  <abarth@webkit.org>
2168
2169         Rubber-stamped by Eric Seidel.
2170
2171         Move JavaScriptGlue into Sources
2172         https://bugs.webkit.org/show_bug.cgi?id=51583
2173
2174         These tools refer to JavaScriptGlue and need to be updated to its new
2175         location.
2176
2177         * Scripts/build-webkit:
2178         * Scripts/do-file-rename:
2179         * Scripts/do-webcore-rename:
2180         * Scripts/webkitpy/common/config/build.py:
2181         * Scripts/webkitpy/common/config/build_unittest.py:
2182
2183 2010-12-23  Lucas Forschler  <lforschler@apple.com>
2184
2185         Reviewed by Eric Seidel.
2186
2187         Bug 51539 - update iexploder scripts to point to new location
2188
2189         * Scripts/run-iexploder-tests:
2190         * Scripts/update-iexploder-cssproperties:
2191
2192 2010-12-23  Evan Martin  <evan@chromium.org>
2193
2194         Reviewed by Ryosuke Niwa.
2195
2196         [chromium] LayoutTestController warning in float->int conversion
2197         https://bugs.webkit.org/show_bug.cgi?id=51553
2198
2199         Rather than reading an int, converting to a float, then getting a compiler
2200         warning on passing the float to something that expects an int, instead
2201         just pass around ints.
2202
2203         No tests, fixes a compiler warning.
2204
2205         * DumpRenderTree/chromium/LayoutTestController.cpp:
2206         (parsePageSizeParameters):
2207         (LayoutTestController::pageNumberForElementById):
2208         (LayoutTestController::numberOfPages):
2209
2210 2010-12-23  Lucas Forschler  <lforschler@apple.com>
2211
2212         Reviewed by Darin Adler.
2213
2214         Bug 51537 - iexploder needs cleanup
2215         
2216         * iExploder/htdocs: Removed.
2217         * iExploder/htdocs/config.rb: Removed.
2218         * iExploder/htdocs/cssproperties.in: Removed.
2219         * iExploder/htdocs/cssvalues.in: Removed.
2220         * iExploder/htdocs/htmlattrs.in: Removed.
2221         * iExploder/htdocs/htmltags.in: Removed.
2222         * iExploder/htdocs/htmlvalues.in: Removed.
2223         * iExploder/htdocs/iexploder.cgi: Removed.
2224         * iExploder/htdocs/iexploder.rb: Removed.
2225         * iExploder/htdocs/index.html: Removed.
2226         * iExploder/htdocs/webserver.rb: Removed.
2227         * iExploder/iexploder-1.7.2/output: Removed.
2228         * iExploder/tools: Removed.
2229         * iExploder/tools/lasthit.rb: Removed.
2230         * iExploder/tools/osx_last_crash.rb: Removed.
2231         * iExploder/tools/showtest.rb: Removed.
2232
2233 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2234
2235         Reviewed by Kenneth Rohde Christiansen.
2236
2237         [EFL] Make 'single' the default backing store in EWebLauncher
2238         https://bugs.webkit.org/show_bug.cgi?id=51534
2239
2240         'single' is the simplest backing store and the one intended to be the
2241         default in the test browser. By mistake the tiled backing store was
2242         left as default in r72617.
2243
2244         * EWebLauncher/main.c:
2245         (browserCreate): ditto.
2246
2247 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2248
2249         Reviewed by Kenneth Rohde Christiansen.
2250
2251         [EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround
2252         https://bugs.webkit.org/show_bug.cgi?id=51533
2253
2254         There's no point in concatenating env("HOME") with "blah", so remove
2255         option from EWebLauncher.
2256
2257         * EWebLauncher/main.c:
2258         (main): ditto.
2259
2260 2010-12-23  Ilya Tikhonovsky  <loislo@chromium.org>
2261
2262         Reviewed by Eric Seidel.
2263
2264         Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).
2265
2266         Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
2267         I just discovered that we have two additional GC runs per each WebViewHost.
2268         Test_shell had no such calls.
2269         These gc runs eat 15% of cpu time.
2270
2271         https://bugs.webkit.org/show_bug.cgi?id=51479
2272
2273         * DumpRenderTree/chromium/WebViewHost.cpp:
2274         (WebViewHost::~WebViewHost):
2275
2276 2010-12-22  Dirk Pranke  <dpranke@chromium.org>
2277
2278         Reviewed by Ojan Vafai.
2279
2280         This change splits out the TestRunner class into its own file.
2281         When we fork the code for message passing, we will create a new
2282         TestRunner, and this change will allow that to be more modular.
2283
2284         While we're at it, split out TestInput and ResultSummary into
2285         their own files, to reduce the size of run_webkit_tests to
2286         something more managable.
2287
2288         https://bugs.webkit.org/show_bug.cgi?id=51092
2289
2290         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2291         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
2292         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2293         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
2294         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
2295         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2296         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2297
2298  2010-12-22  Dirk Pranke  <dpranke@chromium.org>
2299
2300         Reviewed by Ojan Vafai.
2301
2302         nrwt multiprocessing - start over, prepare to fork the code
2303  
2304         This code cleans up the signatures and implementation of the
2305         TestRunner class so we can easily fork it to run either the
2306         stable implementation or the new, unstable message-passing
2307         implementation. The two variants will have different
2308         implementations of the run_tests() method. We will switch
2309         between the two based on the setting for the '--worker-model'
2310         switch. We rename the two currently valid values to 'old-inline'
2311         and 'old-threads'.
2312
2313         https://bugs.webkit.org/show_bug.cgi?id=51081
2314
2315         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2316         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2317
2318 2010-12-22  Victor Wang  <victorw@chromium.org>
2319
2320         Reviewed by Darin Fisher.
2321
2322         [Chromium] Update chromium archive test result url in rebaseline script.
2323
2324         https://bugs.webkit.org/show_bug.cgi?id=51503
2325
2326         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2327
2328 2010-12-22  Lucas Forschler  <lforschler@apple.com>
2329
2330         Reviewed by Alice Liu.
2331
2332         <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
2333         Verified on Chrome, Safari, and IE.
2334         With this change, we will record memory from a parent browser window and all child processes.
2335
2336         * record-memory-win/main.cpp:
2337         (ProcessArgs):
2338         (PrintUsage):
2339         (getMemoryInfo):
2340         (printProcessInfo):
2341         (evalProcesses):
2342         (UseImage):
2343         (QueryContinuously):
2344         (ElapsedTime):
2345
2346 2010-12-22  Lucas Forschler  <lforschler@apple.com>
2347
2348         Unreviewed rollout r74489, because it was missing changelog.
2349
2350         * record-memory-win/main.cpp:
2351         
2352 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
2353
2354         Adding myself as a reviewer.
2355
2356         * Scripts/webkitpy/common/config/committers.py:
2357
2358 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
2359
2360         Unreviewed.  Adding myself to committers.py.
2361
2362         * Scripts/webkitpy/common/config/committers.py:
2363
2364 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
2365
2366         Reviewed by Kenneth Rohde Christiansen.
2367
2368         TestNetscapePlugIn should use #if defined
2369         https://bugs.webkit.org/show_bug.cgi?id=51471
2370
2371         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2372         (NP_Initialize):
2373         (NPP_New):
2374
2375 2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
2376
2377         Reviewed by Yury Semikhatsky.
2378
2379         Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
2380
2381         DevTools window should be closed explicitly because it has custom deinitialization code.
2382
2383         https://bugs.webkit.org/show_bug.cgi?id=50722
2384
2385         * DumpRenderTree/chromium/TestShell.cpp:
2386         (TestShell::closeRemainingWindows):
2387
2388 2010-12-22  David Levin  <levin@chromium.org>
2389
2390         Reviewed by Shinichiro Hamaji.
2391
2392         check-webkit-style shouldn't complaint about underscores in variables in objective C files.
2393         https://bugs.webkit.org/show_bug.cgi?id=51452
2394
2395         * Scripts/webkitpy/style/checkers/cpp.py:
2396         (_FileState.__init__): Added the information to determine if a file is C or Objective C.
2397         Using the file extension if possible but falling back to the file contents if we have a header file.
2398         (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
2399         (_FileState.is_c_or_objective_c):
2400         (check_using_std): Changed to using _FileState to determine the file type.
2401         (check_max_min_macros): Ditto.
2402         (check_for_null): Ditto.
2403         (check_style): Changed the parameters to various calls since they now need _FileState
2404         to determine the file type.
2405         (check_language): Added the file_state parameter so it could be passed
2406         to check_identifier_name_in_declaration.
2407         (check_identifier_name_in_declaration): Don't warn about underscores in variables if
2408         this is an Objective C file.
2409         (_process_lines): Added information for the _FileState constructor (and moved the
2410         call to a place that had the information).
2411         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2412         (CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
2413         its functionality.
2414         (WebKitStyleTest.test_names): Add tests for underscores in Objective C files.
2415
2416 2010-12-21  Andy Estes  <aestes@apple.com>
2417
2418         Reviewed by Mark Rowe.
2419
2420         Do not build non-Intel architectures for WebKit2-related projects.
2421         https://bugs.webkit.org/show_bug.cgi?id=51440
2422
2423         * MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64.
2424         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
2425         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
2426
2427 2010-12-21  Mihai Parparita  <mihaip@chromium.org>
2428
2429         Reviewed by Darin Fisher.
2430
2431         [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
2432         https://bugs.webkit.org/show_bug.cgi?id=51406 
2433         
2434         Rename WebThemeControlDRT to WebThemeControlDRTWin and WebThemeEngineDRT
2435         to WebThemeEngineDRTWin and update references everywhere.
2436
2437         * DumpRenderTree/DumpRenderTree.gypi:
2438         * DumpRenderTree/chromium/TestShellWin.cpp:
2439         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.cpp.
2440         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.h.
2441         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp.
2442         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.h.
2443
2444 2010-12-21  Anders Carlsson  <andersca@apple.com>
2445
2446         Reviewed by John Sullivan.
2447
2448         Clicking missing plug-in text does not show a sheet
2449         https://bugs.webkit.org/show_bug.cgi?id=51403
2450
2451         Update for changes to the WebPageUIClient.
2452
2453         * MiniBrowser/mac/BrowserWindowController.m:
2454         (-[BrowserWindowController awakeFromNib]):
2455         * WebKitTestRunner/TestController.cpp:
2456         (WTR::createOtherPage):
2457         (WTR::TestController::initialize):
2458
2459 2010-12-21  Eric Seidel  <eric@webkit.org>
2460
2461         Reviewed by Adam Barth.
2462
2463         commit-queue will report constant failures as flaky if other tests flake
2464         https://bugs.webkit.org/show_bug.cgi?id=51272
2465
2466         This patch just removes functionality and adds testing.
2467         Previously we attempted to report flaky tests when we had
2468         two different tests fail in a row.  However, since we stop
2469         running the tests at the first failure, our code was wrong in
2470         trying to determine flakiness from the incomplete runs.
2471
2472         Originally I posted an alternate patch:
2473         https://bug-51272-attachments.webkit.org/attachment.cgi?id=77078
2474         which fixed our flaky logic in this case, however it was decided
2475         that that patch would be too difficult to maintain, so now
2476         I'm just removing the broken logic.
2477
2478         This will dramatically cut-down on our flaky-test false positives
2479         at the (small) cost of the queues being unable to report
2480         any flakiness if the tree is very flaky.  (With at least one test
2481         flaking on every run, we'll never report failures anymore.)  I think
2482         this is a tradeoff worth making.
2483
2484         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2485         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2486
2487 2010-12-20  Eric Seidel  <eric@webkit.org>
2488
2489         Reviewed by Adam Barth.
2490
2491         commit-queue wrongly rejects patches when it can't update itself
2492         https://bugs.webkit.org/show_bug.cgi?id=46636
2493
2494         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2495         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2496         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2497
2498 2010-12-20  Adam Barth  <abarth@webkit.org>
2499
2500         Move web sites to Websites directory
2501         https://bugs.webkit.org/show_bug.cgi?id=51323
2502
2503         Update references to BugsSite to point to the new location.
2504
2505         This patch was never officially reviewed (because it was too large to
2506         upload to bugs.webkit.org), but it was discussed on webkit-dev and Mark
2507         Rowe gave me the green light.
2508
2509         * Scripts/old-run-webkit-tests:
2510         * Scripts/webkitpy/common/config/build.py:
2511         * Scripts/webkitpy/common/config/build_unittest.py:
2512         * Scripts/webkitpy/common/prettypatch.py:
2513         * Scripts/webkitpy/layout_tests/port/base.py:
2514         * Scripts/webkitpy/style/main.py:
2515
2516 2010-12-20  Adrienne Walker  <enne@google.com>
2517
2518         Unreviewed. Adding myself to the list of committers.
2519
2520         * webkitpy/common/config/committers.py:
2521
2522 2010-12-20  Mark Rowe  <mrowe@apple.com>
2523
2524         Reviewed by Dan Bernstein.
2525
2526         <rdar://problem/8757601> Don't install header files in to the Resources directory.
2527
2528         * Scripts/check-for-inappropriate-files-in-framework: Don't allow .h files in the
2529         Resources directory.
2530
2531 2010-12-20  Eric Seidel  <eric@webkit.org>
2532
2533         Reviewed by Adam Barth.
2534
2535         commit-queue should include bot id when attaching failure diffs
2536         https://bugs.webkit.org/show_bug.cgi?id=51280
2537
2538         This is a tiny change to include the bot id in the name of the attachment.
2539         Most of this diff is just changing the unit test expectations
2540         now that I hid the comment printing when the comment is None.
2541
2542         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2543         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2544         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2545         * Scripts/webkitpy/tool/mocktool.py:
2546
2547 2010-12-20  Jeff Miller  <jeffm@apple.com>
2548
2549         Reviewed by Dan Bernstein.
2550
2551         Tools/vcbin/midl.exe needs to be rebuilt
2552         https://bugs.webkit.org/show_bug.cgi?id=51347
2553
2554         * vcbin/midl.exe: Rebuilt.
2555
2556 2010-12-20  David Levin  <levin@chromium.org>
2557
2558         Reviewed by Ariya Hidayat.
2559
2560         .gitignore and webkit-tools-completion.sh have references to WebKitTools that should be Tools.
2561         https://bugs.webkit.org/show_bug.cgi?id=51343
2562
2563         Follow up from the WebKitTools -> Tools rename.
2564
2565         * Scripts/webkit-tools-completion.sh:
2566
2567 2010-12-20  Cosmin Truta  <ctruta@chromium.org>
2568
2569         Reviewed by James Robinson.
2570
2571         new-run-webkit-tests ignores trailing EOL differences in text tests
2572         https://bugs.webkit.org/show_bug.cgi?id=36983
2573
2574         Changed the handling of new-line characters within new-run-webkit-tests
2575         to match old-run-webkit-tests.  Differences in leading and trailing empty
2576         lines in text expectation files are no longer ignored.
2577
2578         * Scripts/webkitpy/layout_tests/port/base.py:
2579         * Scripts/webkitpy/layout_tests/port/test.py:
2580         Added unit tests.  Removed old duplicate unit test entries.
2581         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2582
2583 2010-12-20  David Levin  <levin@chromium.org>
2584
2585         Reviewed by Shinichiro Hamaji.
2586
2587         check-webkit-style should detect function declarations (and trivial functions).
2588         https://bugs.webkit.org/show_bug.cgi?id=51303
2589
2590         * Scripts/webkitpy/style/checkers/cpp.py:
2591         (_FunctionState.begin): Add is_declaration and changed the line count
2592         start to begin at -1 (which will keep the results consistent, since
2593         the starting line number passed in is one less in this change).
2594         (detect_functions): changed function detection to now catch trivial
2595         functions and declarations.
2596         (check_pass_ptr_usage): Don't check for Pass*Ptr on the first line
2597         of the function as this may look at return values (when processing
2598         a declaration).
2599         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2600         (FunctionDetectionTest.perform_function_detection): Basic mechanics
2601         of testing the function detection.
2602         (FunctionDetectionTest.test_basic_function_detection): Test a simple
2603         function.
2604         (FunctionDetectionTest.test_function_declaration_detection): Test a
2605         declaration.
2606         (FunctionDetectionTest.test_non_functions): A test case for a case
2607         that caused the code to fail due to the { being in quotes.
2608         (PassPtrTest.test_pass_ref_ptr_return_value): Added some more test
2609         cases to help catch false alarms for return values.
2610         (PassPtrTest.test_pass_ref_ptr_member_variable): Ensure that
2611         we don't get false alarms for member variables either.
2612
2613 2010-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
2614
2615         Reviewed by Antonio Gomes.
2616
2617         [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR
2618         https://bugs.webkit.org/show_bug.cgi?id=51319
2619
2620         * CMakeListsEfl.txt:
2621
2622 2010-12-18  Adam Barth  <abarth@webkit.org>
2623
2624         Reviewed by Sam Weinig.
2625
2626         Move WebKitExamplePlugins to Examples
2627         https://bugs.webkit.org/show_bug.cgi?id=51291
2628
2629         * Scripts/webkitpy/common/config/build.py:
2630
2631 2010-12-17  Csaba Osztrogonác  <ossy@webkit.org>
2632
2633         Unreviewed Qt buildfix after r74301.
2634
2635         Rename WebKitTools to Tools
2636         https://bugs.webkit.org/show_bug.cgi?id=49861
2637
2638         * MiniBrowser/DerivedSources.pro:
2639         * MiniBrowser/qt/MiniBrowser.pro:
2640
2641 2010-12-17  Dan Bernstein  <mitz@apple.com>
2642
2643         Reviewed by Simon Fraser.
2644
2645         Rename WebKitTools to Tools
2646         https://bugs.webkit.org/show_bug.cgi?id=49861
2647
2648         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2649         * CodeCoverage/README:
2650         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2651         (WebCore::DumpRenderTree::initializeFonts):
2652         * EWSTools/start-commit-queue.sh:
2653         * EWSTools/start-queue.sh:
2654         * GNUmakefile.am:
2655         * MIDLWrapper/MIDLWrapper.cpp:
2656         (wmain):
2657         * MiniBrowser/qt/MiniBrowser.pro:
2658         * Scripts/build-api-tests:
2659         * Scripts/build-dumprendertree:
2660         * Scripts/build-webkit:
2661         * Scripts/build-webkittestrunner:
2662         * Scripts/generate-coverage-data:
2663         * Scripts/old-run-webkit-tests:
2664         * Scripts/run-api-tests:
2665         * Scripts/run-iexploder-tests:
2666         * Scripts/run-javascriptcore-tests:
2667         * Scripts/run-mangleme-tests:
2668         * Scripts/run-sunspider:
2669         * Scripts/run-webkit-websocketserver:
2670         * Scripts/sunspider-compare-results:
2671         * Scripts/test-webkitperl:
2672         * Scripts/test-webkitpy:
2673         * Scripts/update-iexploder-cssproperties:
2674         * Scripts/update-webkit:
2675         * Scripts/update-webkit-localizable-strings:
2676         * Scripts/webkitdirs.pm:
2677         * Scripts/webkitpy/common/checkout/scm.py:
2678         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2679         * Scripts/webkitpy/common/config/committervalidator.py:
2680         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
2681         * Scripts/webkitpy/common/config/ports.py:
2682         * Scripts/webkitpy/common/config/ports_unittest.py:
2683         * Scripts/webkitpy/common/system/logutils_unittest.py:
2684         * Scripts/webkitpy/common/system/ospath_unittest.py:
2685         * Scripts/webkitpy/layout_tests/port/chromium.py:
2686         * Scripts/webkitpy/layout_tests/port/config.py:
2687         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2688         * Scripts/webkitpy/layout_tests/port/http_server.py:
2689         * Scripts/webkitpy/layout_tests/port/test.py:
2690         * Scripts/webkitpy/style/checker.py:
2691         * Scripts/webkitpy/style/checker_unittest.py:
2692         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
2693         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2694         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2695         * WebKitTestRunner/DerivedSources.pro:
2696         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2697         (WTR::activateFonts):
2698         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2699         * wx/build/build_utils.py:
2700
2701 2010-12-16  Antonio Gomes  <agomes@rim.com>
2702
2703         Reviewed by Martin Robinson.
2704
2705         Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
2706         https://bugs.webkit.org/show_bug.cgi?id=51163
2707
2708         Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
2709         GTK+'s DRT should also reset to UNIX after each test execution.
2710
2711         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2712         (resetDefaultsToConsistentValues):
2713
2714 2010-12-17  David Levin  <levin@chromium.org>
2715
2716         Reviewed by Eric Seidel.
2717
2718         check-webkit-style should understand WTF #include guards
2719         https://bugs.webkit.org/show_bug.cgi?id=44911
2720
2721         * Scripts/webkitpy/style/checkers/cpp.py:
2722         (get_header_guard_cpp_variable): modify to suggest the WTF style
2723         of header guard when appropriate.
2724         (check_for_header_guard): handle multiple return values from
2725         get_header_guard_cpp_variable
2726         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2727         (CppStyleTest.test_build_header_guard): Added tests for the WTF
2728         header style.
2729
2730 2010-12-16  David Levin  <levin@chromium.org>
2731
2732         Reviewed by Eric Seidel.
2733
2734         test-webkitpy: unittest for the xml.py checker displays a decprecation warning.
2735         https://bugs.webkit.org/show_bug.cgi?id=51210
2736
2737         The error only shows up when using python 2.6 or later.
2738
2739         * Scripts/webkitpy/style/checkers/xml.py: Replace the usage of
2740         the decprecated field error,message with something equivalent.
2741
2742 2010-12-16  Mihai Parparita  <mihaip@chromium.org>
2743
2744         Reviewed by Eric Seidel.
2745
2746         Add --exit-after-n-failures/crashes to NRWT
2747         https://bugs.webkit.org/show_bug.cgi?id=51160
2748         
2749         Abort test run (in a similar way to how control-C is handled) when
2750         --exit-after-n-failures/crashes-or-timeouts are passed and we've reached
2751         that number of unexpected failures/crashes/timeouts.
2752
2753         * Scripts/webkitpy/layout_tests/port/test.py:
2754         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2755         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2756
2757 2010-12-16  David Levin  <levin@chromium.org>
2758
2759         Reviewed by Shinichiro Hamaji.
2760
2761         check-webkit-style unit tests has some duplicate boilerplate code.
2762         https://bugs.webkit.org/show_bug.cgi?id=49519
2763
2764         * Scripts/webkitpy/style/checkers/cpp.py:
2765         (update_include_state): Replaced the "io" parameter with the global
2766         configuration _unit_test_config. This allowed not calling into
2767         functions at a low level and also not plumbing through the injection
2768         information through many levels of code.
2769         (check_for_include_what_you_use): Ditto.
2770         (process_file_data): Added the ability to set up the unit test config
2771         to allow for injection.
2772         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2773         (ErrorCollector.__init__): Added support for having a filter for errors.
2774         (ErrorCollector.__call__): Ditto.
2775         (CppStyleTestBase.process_file_data): Added the ability to set unit_test_config.
2776         (CppStyleTestBase.perform_lint): Consolidated logic for the perform functions.
2777         (CppStyleTestBase.perform_single_line_lint): Replace specific calls to
2778         functions in the cpp.py with generic processing and a filter that
2779         indicates what errors should be kept.
2780         (CppStyleTestBase.perform_multi_line_lint): Ditto.
2781         (CppStyleTestBase.perform_language_rules_check): Ditto.
2782         (CppStyleTestBase.perform_function_lengths_check): Ditto.
2783         (CppStyleTestBase.perform_pass_ptr_check): Ditto.
2784         (CppStyleTestBase.perform_include_what_you_use): Ditto.
2785         (CppStyleTest.test_multi_line_comments): Added another
2786         error message which applies to the test case.
2787         (CppStyleTest.test_spacing_for_binary_ops): Fixed test
2788         to not have config.h, since it is processed as a header file.
2789         (CppStyleTest.test_static_or_global_stlstrings): Fixed variable name
2790         style and indentation in checked code.
2791         (OrderOfIncludesTest.test_check_preprocessor_in_include_section):
2792         Fixed line number.
2793         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
2794         Ditto.
2795
2796 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
2797
2798         Unreviewed, rolling out r74136.
2799         http://trac.webkit.org/changeset/74136
2800         https://bugs.webkit.org/show_bug.cgi?id=51135
2801
2802         r74136 breaks chromium canary bots because some tests are not
2803         rebaselined correctly to resolve EOL differences (Requested by
2804         jianli on #webkit).
2805
2806         * Scripts/webkitpy/layout_tests/port/base.py:
2807         * Scripts/webkitpy/layout_tests/port/test.py:
2808         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2809
2810 2010-12-15  Adam Roben  <aroben@apple.com>
2811
2812         Teach check-webkit-style to check .vcproj and .vsprops files for XML
2813         syntax errors
2814
2815         Fixes <http://webkit.org/b/51103> check-webkit-style should check for
2816         XML syntax errors in .vcproj/.vsprops files
2817
2818         Reviewed by Dave Levin.
2819
2820         * Scripts/webkitpy/style/checker.py: Added lists of file extensions
2821         that should be treated as XML and that should be allowed to contain
2822         carriage returns. (These lists happen to be identical currently.)
2823         (FileType): Added a new XML type.
2824         (CheckerDispatcher.should_check_and_strip_carriage_returns): Added.
2825         Just does a simple file extension check.
2826         (CheckerDispatcher._file_type): Added a case for XML files.
2827         (CheckerDispatcher._create_checker): Ditto. We use XMLChecker for XML
2828         files (surprise!).
2829         (StyleProcessor.process): Ask the dispatcher whether we should pass the
2830         lines through the carriage checker.
2831
2832         * Scripts/webkitpy/style/checker_unittest.py:
2833         (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
2834         Added. Checks a few file names to see if carriage returns are allowed
2835         or not.
2836         (CheckerDispatcherDispatchTest.assert_checker_xml): Added. Similar to
2837         other assert_checker_* functions.
2838         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
2839         test_*_paths functions.
2840         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
2841         test_*_paths functions.
2842         (CheckerDispatcherDispatchTest.test_none_paths): Removed the vcproj
2843         file from this test case, as vcproj files now have a type.
2844         (StyleProcessor_CodeCoverageTest.MockDispatcher.should_check_and_strip_carriage_returns):
2845         Added. Similar to the other should_* functions.
2846         (StyleProcessor_CodeCoverageTest.test_process__carriage_returns_not_stripped):
2847         Added. Checks that carriage returns aren't checked for or stripped for
2848         allowed files.
2849
2850         * Scripts/webkitpy/style/checkers/xml.py: Added.
2851         (XMLChecker.__init__): Simple init method.
2852         (XMLChecker.check): Pass each line through the expat parser, and record
2853         a style error for any errors thrown by the parser.
2854
2855         * Scripts/webkitpy/style/checkers/xml_unittest.py: Added.
2856         (XMLCheckerTest.assert_no_error): Checks that the given XML does not
2857         produce a style error.
2858         (XMLCheckerTest.assert_error): Checks that the given XML produces an
2859         error of the given category on the given line.
2860         (XMLCheckerTest.mock_handle_style_error): Does nothing. Used for
2861         checking that the XMLChecker constructor works properly.
2862         (XMLCheckerTest.test_conflict_marker): Tests that conflict markers
2863         cause a style error (see, e.g., r73887).
2864         (XMLCheckerTest.test_extra_closing_tag): Tests that extra closing tags
2865         cause a style error (see, e.g., r73773).
2866         (XMLCheckerTest.test_init): Tests that the XMLChecker constructor works
2867         properly.
2868         (XMLCheckerTest.test_missing_closing_tag): Tests that missing closing
2869         tags cause a style error (see, e.g., r72795).
2870         (XMLCheckerTest.test_no_error): Tests that valid XML does not cause a
2871         style error.
2872
2873 2010-12-15  Lucas Forschler  <lforschler@apple.com>
2874
2875         Reviewed by Stephanie Lewis.
2876
2877         https://bugs.webkit.org/show_bug.cgi?id=51117
2878         Add a new leopard test bot
2879         really really commit to trunk this time.
2880
2881         * BuildSlaveSupport/build.webkit.org-config/config.json:
2882
2883 2010-12-15  Sam Weinig  <sam@webkit.org>
2884
2885         Reviewed by Anders Carlsson.
2886
2887         WebKit2: Can't add files to an <input type=file>
2888         https://bugs.webkit.org/show_bug.cgi?id=51087
2889
2890         * MiniBrowser/mac/BrowserWindowController.m:
2891         (runOpenPanel):
2892         (-[BrowserWindowController awakeFromNib]):
2893         Add simple implementation of runOpenPanel callback.
2894
2895         * MiniBrowser/win/BrowserView.cpp:
2896         (BrowserView::create):
2897         * WebKitTestRunner/TestController.cpp:
2898         (WTR::createOtherPage):
2899         (WTR::TestController::initialize):
2900         Stub out runOpenPanel callback. 
2901
2902 2010-12-14  Eric Seidel  <eric@webkit.org>
2903
2904         Reviewed by Adam Barth.
2905
2906         commit-queue should upload failure diffs when tests flake
2907         https://bugs.webkit.org/show_bug.cgi?id=51051
2908
2909         To make this testable I needed to pipe FileSystem down onto tool.
2910         We've wanted it there for a long time anyway.
2911
2912         This patch is kinda a big hack.  But we don't have a nice
2913         way to read results.html files.  I think this will need further
2914         revision before this code actually feels clean.
2915
2916         As part of testing this change, I had to make MockBugzilla.create_bug
2917         actually return an id (like it should) which required updating
2918         a few other unit test results (for the better).
2919
2920         The results_matching_keys change in layouttestresults/rebasline
2921         was an alternate path which I decided not to use in the end, but
2922         I left the change as it seemed an improvement.
2923
2924         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2925         * Scripts/webkitpy/common/net/layouttestresults.py:
2926         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2927         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2928         * Scripts/webkitpy/tool/commands/queues.py:
2929         * Scripts/webkitpy/tool/commands/rebaseline.py:
2930         * Scripts/webkitpy/tool/main.py:
2931         * Scripts/webkitpy/tool/mocktool.py:
2932
2933 2010-12-15  Cosmin Truta  <ctruta@chromium.org>
2934
2935         Reviewed by James Robinson.
2936
2937         new-run-webkit-tests ignores trailing EOL differences in text tests
2938         https://bugs.webkit.org/show_bug.cgi?id=36983
2939
2940         Changed the handling of new-line characters within new-run-webkit-tests
2941         to match old-run-webkit-tests.  Differences in leading and trailing empty
2942         lines in text expectation files are no longer ignored.
2943
2944         * Scripts/webkitpy/layout_tests/port/base.py:
2945         * Scripts/webkitpy/layout_tests/port/test.py:
2946         Added unit tests.  Removed old duplicate unit test entries.
2947         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2948
2949 2010-12-15  Ojan Vafai  <ojan@chromium.org>
2950
2951         Reviewed by Adam Barth.
2952
2953         make status-bubble white-space:nowrap so we can measure it's width without wrapping
2954         https://bugs.webkit.org/show_bug.cgi?id=51149
2955
2956         * QueueStatusServer/templates/statusbubble.html:
2957
2958 2010-12-15  Ojan Vafai  <ojan@chromium.org>
2959
2960         Reviewed by Adam Barth.
2961
2962         have the statusbubble postMessage it's metrics so that embedders can properly size the iframe
2963         https://bugs.webkit.org/show_bug.cgi?id=51125
2964
2965         * QueueStatusServer/templates/statusbubble.html:
2966
2967 2010-12-15  Darin Adler  <darin@apple.com>
2968
2969         * Scripts/webkitpy/common/net/buildbot: Added property svn:ignore.
2970
2971 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
2972
2973         Unreviewed, rolling out r74117.
2974         http://trac.webkit.org/changeset/74117
2975         https://bugs.webkit.org/show_bug.cgi?id=51113
2976
2977         This broke the GTK1 build. (Requested by mrobinson on
2978         #webkit).
2979
2980         * Scripts/webkitdirs.pm:
2981
2982 2010-12-15  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>
2983
2984         Reviewed by Martin Robinson.
2985
2986         Change generate-forwarding-headers.pl for GTK port usage 
2987         (https://bugs.webkit.org/show_bug.cgi?id=37369)
2988
2989         * Scripts/webkitdirs.pm: Added changes to build webkit2 for GTK port using build-webkit script.
2990
2991 2010-12-14  Kent Tamura  <tkent@chromium.org>
2992
2993         Reviewed by Jian Li.
2994
2995         [DRT/Chromium] Remove another unnecessary error message
2996         https://bugs.webkit.org/show_bug.cgi?id=51083
2997
2998         * DumpRenderTree/chromium/WebViewHost.cpp:
2999         (WebViewHost::didInvalidateRect):
3000
3001 2010-12-14  Lucas Forschler  <lforschler@apple.com>
3002
3003         Reviewed by Stephanie Lewis.
3004
3005         Add a new Leopard Debug Test WK2 Bot
3006
3007         * BuildSlaveSupport/build.webkit.org-config/config.json:
3008
3009 2010-12-14  Ojan Vafai  <ojan@chromium.org>
3010
3011         Fix python unittests after http://trac.webkit.org/changeset/74070.
3012
3013         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3014
3015 2010-12-14  Kent Tamura  <tkent@chromium.org>
3016
3017         Reviewed by Jian Li.
3018
3019         [DRT/Chromium] Remove a unnecessary error message
3020         https://bugs.webkit.org/show_bug.cgi?id=51069
3021
3022         * DumpRenderTree/chromium/WebViewHost.cpp:
3023         (WebViewHost::paintInvalidatedRegion):
3024
3025 2010-12-14  Benjamin Kalman  <kalman@chromium.org>
3026
3027         Reviewed by Ojan Vafai.
3028
3029         Using BUG/BUGWK in test_expectations is error prone, should use BUGCR/BUGWK
3030         https://bugs.webkit.org/show_bug.cgi?id=48926
3031
3032         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3033         Add presubmit check that BUG isn't used, either BUGCR/BUGWK/BUGV8_.
3034
3035 2010-12-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3036
3037         Reviewed by Eric Seidel.
3038
3039         [Qt] [Symbian] Do not use pkg-config on Symbian as it is not supported
3040         https://bugs.webkit.org/show_bug.cgi?id=50231
3041
3042         Guard CONFIG+=link_pkgconfig with !symbian.
3043
3044         * DumpRenderTree/qt/DumpRenderTree.pro:
3045         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3046         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3047
3048 2010-12-14  Philippe Normand  <pnormand@igalia.com>
3049
3050         Reviewed by Ojan Vafai.
3051
3052         [new-run-webkit-tests] expectations parsing is slow
3053         https://bugs.webkit.org/show_bug.cgi?id=50635
3054
3055         Avoid expensive iteration of all the tests when checking if a test
3056         file is to be skipped or not.
3057
3058         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3059         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3060         * Scripts/webkitpy/layout_tests/port/test.py:
3061
3062 2010-12-14  Mario Sanchez Prada  <msanchez@igalia.com>
3063
3064         Reviewed by Xan Lopez.
3065
3066         [Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding events for text objects
3067         https://bugs.webkit.org/show_bug.cgi?id=27048
3068
3069         Add support in DRT for checking whether an accessibility UI
3070         element is focusable and/or focused. Implemented for GTK.
3071
3072         * DumpRenderTree/AccessibilityUIElement.cpp:
3073         (getIsFocusedCallback): New.
3074         (getIsFocusableCallback): New.
3075         (AccessibilityUIElement::getJSClass): Add the new available
3076         callbacks for isFocused and isFocusable.
3077         * DumpRenderTree/AccessibilityUIElement.h:
3078         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3079         (AccessibilityUIElement::isFocused): New, implemented by checking
3080         whether the related AtkState value is in the object's state set.
3081         (AccessibilityUIElement::isFocusable): Ditto.
3082         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3083         (AccessibilityUIElement::isFocused): New, dummy implementation.
3084         (AccessibilityUIElement::isFocusable): Ditto.
3085         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3086         (AccessibilityUIElement::isFocused): Ditto.
3087         (AccessibilityUIElement::isFocusable): Ditto.
3088
3089 2010-12-14  Eric Seidel  <eric@webkit.org>
3090
3091         Reviewed by Ojan Vafai.
3092
3093         webkit-patch should warn users when they're using a 32-bit git on a 64-bit system
3094         https://bugs.webkit.org/show_bug.cgi?id=50715
3095
3096         This patch makes webkit-patch print the following:
3097
3098         Warning: This machine is 64-bit, but the git binary (/usr/local/git/bin/git) does not support 64-bit.
3099         Install a 64-bit git for better performance, see:
3100         https://lists.webkit.org/pipermail/webkit-dev/2010-December/015249.html
3101
3102         I wrote this mostly because I have approximately 8 machines that I use
3103         and making sure each one is using a good Git install seemed folly.
3104         webkit-patch makes a lot of git calls, so using a fast git can shave
3105         several seconds in every invocation.  See the webkit-dev thread for more info.
3106
3107         This message will print twice during 'webkit-patch upload',
3108         once from webkit-patch and once from check-webkit-style.
3109
3110         Unfortunately there is no good way to test this due to how machine-dependent
3111         the code is.  I considered writing a test for the log message, but it seemed not worth it.
3112
3113         * Scripts/webkitpy/common/checkout/scm.py:
3114
3115 2010-12-13  Eric Seidel  <eric@webkit.org>
3116
3117         Reviewed by Adam Barth.
3118
3119         FlakyTestReporter doesn't understand bots running from multiple email addresses
3120         https://bugs.webkit.org/show_bug.cgi?id=50960
3121
3122         This explains at least one of the dupes of:
3123         https://bugs.webkit.org/show_bug.cgi?id=50863
3124         that we saw filed by the commit-queue this morning.
3125         I think the other one was explained by my previous fix to result counting code.
3126
3127         Since this is really hard to test with a unit test, instead I
3128         create a new (possibly useful in the future) command
3129         which given a layout test path will return you
3130         the one bug which our tools would assume it the flaky test bug.
3131         If some other script wants to use bug-for-test we'll
3132         need to extend it with some options like --create-if-missing or similar.
3133
3134         * Scripts/webkitpy/common/net/bugzilla/bug.py:
3135         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3136         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3137         * Scripts/webkitpy/tool/commands/__init__.py:
3138         * Scripts/webkitpy/tool/commands/bugfortest.py: Added.
3139
3140 2010-12-13  Mihai Parparita  <mihaip@chromium.org>
3141
3142         Reviewed by James Robinson.
3143
3144         Add option to build-webkit to not build WebKit2
3145         https://bugs.webkit.org/show_bug.cgi?id=50988
3146         
3147         Add support for a --no-webkit2 option to build-webkit. It seems to save
3148         ~1 minute from clean builds and ~10 seconds from no-op builds.
3149
3150         * Scripts/build-webkit:
3151
3152 2010-12-13  Lucas Forschler  <lforschler@apple.com>
3153
3154         Reviewed by Dave Kilzer.
3155
3156         Update iexploder from 1.3.2 to 1.7.2
3157         Move 1.3.2 into its own subdir
3158         Add 1.7.2 into its own subdir
3159         update scripts to point to new 1.3.2 location (avoid breaking existing scripts)
3160
3161         * Scripts/run-iexploder-tests:
3162         * Scripts/update-iexploder-cssproperties:
3163         * iExploder/CHANGELOG.txt: Removed.
3164         * iExploder/LICENSE.txt: Removed.
3165         * iExploder/README.txt: Removed.
3166         * iExploder/htdocs: Removed.
3167         * iExploder/iexploder-1.3.2: Added.
3168         * iExploder/iexploder-1.3.2/CHANGELOG.txt: Copied from iExploder/CHANGELOG.txt.
3169         * iExploder/iexploder-1.3.2/LICENSE.txt: Copied from iExploder/LICENSE.txt.
3170         * iExploder/iexploder-1.3.2/README.txt: Copied from iExploder/README.txt.
3171         * iExploder/iexploder-1.3.2/htdocs: Added.
3172         * iExploder/iexploder-1.3.2/htdocs/config.rb: Copied from iExploder/htdocs/config.rb.
3173         * iExploder/iexploder-1.3.2/htdocs/cssproperties.in: Copied from iExploder/htdocs/cssproperties.in.
3174         * iExploder/iexploder-1.3.2/htdocs/cssvalues.in: Copied from iExploder/htdocs/cssvalues.in.
3175         * iExploder/iexploder-1.3.2/htdocs/htmlattrs.in: Copied from iExploder/htdocs/htmlattrs.in.
3176         * iExploder/iexploder-1.3.2/htdocs/htmltags.in: Copied from iExploder/htdocs/htmltags.in.
3177         * iExploder/iexploder-1.3.2/htdocs/htmlvalues.in: Copied from iExploder/htdocs/htmlvalues.in.
3178         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi: Copied from iExploder/htdocs/iexploder.cgi.
3179         * iExploder/iexploder-1.3.2/htdocs/iexploder.rb: Copied from iExploder/htdocs/iexploder.rb.
3180         * iExploder/iexploder-1.3.2/htdocs/index.html: Copied from iExploder/htdocs/index.html.
3181         * iExploder/iexploder-1.3.2/htdocs/webserver.rb: Copied from iExploder/htdocs/webserver.rb.
3182         * iExploder/iexploder-1.3.2/tools: Added.
3183         * iExploder/iexploder-1.3.2/tools/lasthit.rb: Copied from iExploder/tools/lasthit.rb.
3184         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb: Copied from iExploder/tools/osx_last_crash.rb.
3185         * iExploder/iexploder-1.3.2/tools/showtest.rb: Copied from iExploder/tools/showtest.rb.
3186         * iExploder/iexploder-1.7.2: Added.
3187         * iExploder/iexploder-1.7.2/ChangeLog.txt: Added.
3188         * iExploder/iexploder-1.7.2/LICENSE.txt: Added.
3189         * iExploder/iexploder-1.7.2/README.txt: Added.
3190         * iExploder/iexploder-1.7.2/output: Added.
3191         * iExploder/iexploder-1.7.2/src: Added.
3192         * iExploder/iexploder-1.7.2/src/browser_harness.rb: Added.
3193         * iExploder/iexploder-1.7.2/src/config.yaml: Added.
3194         * iExploder/iexploder-1.7.2/src/css-atrules: Added.
3195         * iExploder/iexploder-1.7.2/src/css-atrules/mozilla: Added.
3196         * iExploder/iexploder-1.7.2/src/css-atrules/webkit: Added.
3197         * iExploder/iexploder-1.7.2/src/css-properties: Added.
3198         * iExploder/iexploder-1.7.2/src/css-properties/dillo: Added.
3199         * iExploder/iexploder-1.7.2/src/css-properties/gtkhtml: Added.
3200         * iExploder/iexploder-1.7.2/src/css-properties/internet_explorer6: Added.
3201         * iExploder/iexploder-1.7.2/src/css-properties/mozilla: Added.
3202         * iExploder/iexploder-1.7.2/src/css-properties/webkit: Added.
3203         * iExploder/iexploder-1.7.2/src/css-pseudo: Added.
3204         * iExploder/iexploder-1.7.2/src/css-pseudo/mozilla: Added.
3205         * iExploder/iexploder-1.7.2/src/css-pseudo/webkit: Added.
3206         * iExploder/iexploder-1.7.2/src/css-values: Added.
3207         * iExploder/iexploder-1.7.2/src/css-values/dillo: Added.
3208         * iExploder/iexploder-1.7.2/src/css-values/gtkhtml: Added.
3209         * iExploder/iexploder-1.7.2/src/css-values/mozilla: Added.
3210         * iExploder/iexploder-1.7.2/src/css-values/other: Added.
3211         * iExploder/iexploder-1.7.2/src/css-values/webkit: Added.
3212         * iExploder/iexploder-1.7.2/src/headers: Added.
3213         * iExploder/iexploder-1.7.2/src/headers/dillo: Added.
3214         * iExploder/iexploder-1.7.2/src/headers/gtkhtml: Added.
3215         * iExploder/iexploder-1.7.2/src/headers/mozilla: Added.
3216         * iExploder/iexploder-1.7.2/src/headers/webkit: Added.
3217         * iExploder/iexploder-1.7.2/src/html-attrs: Added.
3218         * iExploder/iexploder-1.7.2/src/html-attrs/dillo: Added.
3219         * iExploder/iexploder-1.7.2/src/html-attrs/gtkhtml: Added.
3220         * iExploder/iexploder-1.7.2/src/html-attrs/internet_explorer6: Added.
3221         * iExploder/iexploder-1.7.2/src/html-attrs/mozilla: Added.
3222         * iExploder/iexploder-1.7.2/src/html-attrs/other: Added.
3223         * iExploder/iexploder-1.7.2/src/html-attrs/webkit: Added.
3224         * iExploder/iexploder-1.7.2/src/html-tags: Added.
3225         * iExploder/iexploder-1.7.2/src/html-tags/dillo: Added.
3226         * iExploder/iexploder-1.7.2/src/html-tags/gtkhtml: Added.
3227         * iExploder/iexploder-1.7.2/src/html-tags/mozilla: Added.
3228         * iExploder/iexploder-1.7.2/src/html-tags/other: Added.
3229         * iExploder/iexploder-1.7.2/src/html-tags/webkit: Added.
3230         * iExploder/iexploder-1.7.2/src/html-values: Added.
3231         * iExploder/iexploder-1.7.2/src/html-values/dillo: Added.
3232         * iExploder/iexploder-1.7.2/src/html-values/gtkhtml: Added.
3233         * iExploder/iexploder-1.7.2/src/html-values/mozilla: Added.
3234         * iExploder/iexploder-1.7.2/src/html-values/other: Added.
3235         * iExploder/iexploder-1.7.2/src/html-values/webkit: Added.
3236         * iExploder/iexploder-1.7.2/src/iexploder.cgi: Added.
3237         * iExploder/iexploder-1.7.2/src/iexploder.rb: Added.
3238         * iExploder/iexploder-1.7.2/src/index.html: Added.
3239         * iExploder/iexploder-1.7.2/src/media: Added.
3240         * iExploder/iexploder-1.7.2/src/media/blank.ogg: Added.
3241         * iExploder/iexploder-1.7.2/src/media/blank.snd: Added.
3242         * iExploder/iexploder-1.7.2/src/media/blank.wav: Added.
3243         * iExploder/iexploder-1.7.2/src/media/bug.bmp: Added.
3244         * iExploder/iexploder-1.7.2/src/media/bug.gif: Added.
3245         * iExploder/iexploder-1.7.2/src/media/bug.ico: Added.
3246         * iExploder/iexploder-1.7.2/src/media/bug.jng: Added.
3247         * iExploder/iexploder-1.7.2/src/media/bug.jpg: Added.
3248         * iExploder/iexploder-1.7.2/src/media/bug.png: Added.
3249         * iExploder/iexploder-1.7.2/src/media/bug.svg: Added.
3250         * iExploder/iexploder-1.7.2/src/media/bug.tiff: Added.
3251         * iExploder/iexploder-1.7.2/src/media/bug.xbm: Added.
3252         * iExploder/iexploder-1.7.2/src/media/bug.xpm: Added.
3253         * iExploder/iexploder-1.7.2/src/mime-types: Added.
3254         * iExploder/iexploder-1.7.2/src/mime-types/dillo: Added.
3255         * iExploder/iexploder-1.7.2/src/mime-types/mozilla: Added.
3256         * iExploder/iexploder-1.7.2/src/mime-types/webkit: Added.
3257         * iExploder/iexploder-1.7.2/src/protocols: Added.
3258         * iExploder/iexploder-1.7.2/src/protocols/dillo: Added.
3259         * iExploder/iexploder-1.7.2/src/protocols/gtkhtml: Added.
3260         * iExploder/iexploder-1.7.2/src/protocols/mozilla: Added.
3261         * iExploder/iexploder-1.7.2/src/protocols/webkit: Added.
3262         * iExploder/iexploder-1.7.2/src/scanner.rb: Added.
3263         * iExploder/iexploder-1.7.2/src/version.rb: Added.
3264         * iExploder/iexploder-1.7.2/src/webserver.rb: Added.
3265         * iExploder/iexploder-1.7.2/testcases: Added.
3266         * iExploder/iexploder-1.7.2/testcases/testcase-Linux_x86_64_rv2.0b6pre_Gecko-20100904_Firefox-4.0b6pre-TEST-8375-1_59.html: Added.
3267         * iExploder/iexploder-1.7.2/testcases/testcase-Opera-9.80_Linux_x86_64_en_Presto-2.6.30_Version-10.61-16704-3_108,3.html: Added.
3268         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_Chrome-7.0.529.0-TEST-611-3_36,9.html: Added.
3269         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_hrome-7.0.529.0-TEST-55313622206-3_6,0.html: Added.
3270         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-120813-8_72,56,24,8,0.html: Added.
3271         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-121240-3_81,3.html: Added.
3272         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-4800-5_80,65,15.html: Added.
3273         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-TEST-23583190347-3_15,12.html: Added.
3274         * iExploder/iexploder-1.7.2/tools: Added.
3275         * iExploder/iexploder-1.7.2/tools/lasthit.rb: Added.
3276         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb: Added.
3277         * iExploder/iexploder-1.7.2/tools/release_src.sh: Added.
3278         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added.
3279         * iExploder/tools: Removed.
3280
3281 2010-12-13  Sam Weinig  <sam@webkit.org>
3282
3283         Reviewed by Anders Carlsson.
3284
3285         Remove associated page concept from WKView constructor
3286         https://bugs.webkit.org/show_bug.cgi?id=50983
3287
3288         Step 1: Remove associate page constructors from WKView and make
3289         all views use the shared namespace for the context.
3290
3291         * TestWebKitAPI/PlatformWebView.h:
3292         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3293         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3294         * WebKitTestRunner/PlatformWebView.h:
3295         * WebKitTestRunner/TestController.cpp:
3296         (WTR::createOtherPage):
3297         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3298         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3299         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3300
3301 2010-12-13  Sam Weinig  <sam@webkit.org>
3302
3303         Reviewed by Anders Carlsson.
3304
3305         Change the WebKit2 public API so there is no explicit WKPageNamespace object
3306         https://bugs.webkit.org/show_bug.cgi?id=50898
3307
3308         * MiniBrowser/mac/AppDelegate.h:
3309         * MiniBrowser/mac/AppDelegate.m:
3310         * MiniBrowser/mac/BrowserWindowController.h:
3311         * MiniBrowser/mac/BrowserWindowController.m:
3312         * MiniBrowser/win/BrowserView.cpp:
3313         Convert MiniBrowser to not use PageNamespaces.
3314
3315         * TestWebKitAPI/PlatformWebView.h:
3316         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
3317         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
3318         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
3319         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
3320         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
3321         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
3322         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
3323         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3324         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3325         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
3326         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
3327         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
3328         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
3329         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3330         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3331         Convert TestWebKitAPI to not use PageNamespaces.
3332
3333         * WebKitTestRunner/PlatformWebView.h:
3334         * WebKitTestRunner/TestController.cpp:
3335         * WebKitTestRunner/TestController.h:
3336         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3337         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3338         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3339         Convert WebKitTestRunner to not use PageNamespaces.
3340
3341 2010-12-13  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3342
3343         Reviewed by Eric Seidel.
3344
3345         webkit-patch rollout should be able to do multi-revision rollouts
3346         https://bugs.webkit.org/show_bug.cgi?id=33336
3347
3348         Make it possible to pass more than one revision to webkit-patch.
3349
3350         * Scripts/webkitpy/common/checkout/api.py:
3351         * Scripts/webkitpy/common/checkout/changelog.py:
3352         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3353         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
3354         * Scripts/webkitpy/tool/commands/download.py:
3355         * Scripts/webkitpy/tool/commands/download_unittest.py:
3356         * Scripts/webkitpy/tool/mocktool.py:
3357         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
3358         * Scripts/webkitpy/tool/steps/revertrevision.py:
3359
3360 2010-12-13  Eric Seidel  <eric@webkit.org>
3361
3362         Unreviewed.
3363
3364         Teach webkit-patch how to search bugzilla
3365         https://bugs.webkit.org/show_bug.cgi?id=50500
3366
3367         webkit-patch bug-search fails when there is only one result.
3368         Turns out we needed a bit more logic in our result count parsing code.
3369
3370         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3371         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3372
3373 2010-12-13  Antti Koivisto  <antti@apple.com>
3374
3375         Reviewed by Alexey Proskuryakov.
3376
3377         Add setSerializeHTTPLoads function to allow testing resource load order on OS X.
3378         https://bugs.webkit.org/show_bug.cgi?id=50758
3379
3380         * DumpRenderTree/LayoutTestController.cpp:
3381         (setSerializeHTTPLoadsCallback):
3382         (LayoutTestController::staticFunctions):
3383         * DumpRenderTree/LayoutTestController.h:
3384         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3385         (LayoutTestController::setSerializeHTTPLoads):
3386         * DumpRenderTree/mac/DumpRenderTree.mm:
3387         (resetDefaultsToConsistentValues):
3388         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3389         (LayoutTestController::setSerializeHTTPLoads):
3390         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3391         (LayoutTestController::setSerializeHTTPLoads):
3392
3393 2010-12-13  Dimitri Glazkov  <dglazkov@chromium.org>
3394
3395         Reviewed by Ojan Vafai.
3396
3397         Remove "use-drt" option from test step command line, since the option was removed in r73748.
3398         https://bugs.webkit.org/show_bug.cgi?id=50936
3399
3400         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed the option.
3401
3402 2010-12-13  Patrick Gansterer  <paroga@webkit.org>
3403
3404         Reviewed by Csaba Osztrogonác.
3405
3406         Add revlink to BuildBot status
3407         https://bugs.webkit.org/show_bug.cgi?id=50914
3408
3409         This adds a hyperlink to trac changeset on the revision numbers. 
3410
3411         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3412
3413 2010-12-13  Andras Becsi  <abecsi@webkit.org>
3414
3415         Reviewed by Csaba Osztrogonác.
3416
3417         [Qt][WK2] Fix build if WebKitTools are not available
3418         https://bugs.webkit.org/show_bug.cgi?id=50242
3419
3420         * MiniBrowser/qt/MiniBrowser.pro: Correct the comment.
3421         * Scripts/webkitdirs.pm: Added WebKitTools/MiniBrowser to $subdirs.
3422         * MiniBrowser/DerivedSources.pro: Added.
3423
3424 2010-12-13  Eric Seidel  <eric@webkit.org>
3425
3426         Reviewed by Adam Barth.
3427
3428         EWS Queues should remove orpahned pyc files before starting
3429         https://bugs.webkit.org/show_bug.cgi?id=50904
3430
3431         A previous check added a platform.py which caused
3432         EWS bots on some platforms to hit an import exception.
3433         The platform.py file was removed in a subsequent commit, but
3434         the EWS bots in question stayed stuck.  This change will
3435         fix those bots once restarted (and prevent this in the future).
3436
3437         I also went ahead and unified start-queue and start-commit-queue
3438         since they were nearly identical.  I also added bot_id support
3439         to both force all EWSes to have bot ids as well as get rid of the one
3440         remaining reason why I had my own copies of these scripts.
3441         Hopefully this will be enough to get all the other bot admins
3442         (ahem, Adam, ahem) to move to using these checked in copies as well.
3443
3444         * EWSTools/start-commit-queue.sh: Removed.
3445         * EWSTools/start-queue.sh:
3446
3447 2010-10-28  MORITA Hajime  <morrita@google.com>
3448
3449         Reviewed by Ojan Vafai.
3450
3451         spellcheck does not check pasted text
3452         https://bugs.webkit.org/show_bug.cgi?id=40092
3453
3454         Added LayoutTestController::setAsynchronousSpellCheckingEnabled()
3455         to control the setting.
3456
3457         * DumpRenderTree/LayoutTestController.cpp:
3458         (setAsynchronousSpellCheckingEnabledCallback):
3459         (LayoutTestController::staticFunctions):
3460         * DumpRenderTree/LayoutTestController.h:
3461         * DumpRenderTree/chromium/LayoutTestController.h:
3462         * DumpRenderTree/chromium/LayoutTestController.cpp:
3463         (LayoutTestController::LayoutTestController):
3464         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
3465         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3466         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
3467         * DumpRenderTree/mac/DumpRenderTree.mm:
3468         (resetDefaultsToConsistentValues):
3469         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3470         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
3471         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3472         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3473         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
3474         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3475         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
3476         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3477         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
3478
3479 2010-12-12  Sam Weinig  <sam@webkit.org>
3480
3481         Reviewed by Anders Carlsson.
3482
3483         Fix failing API test. It turns out that a pop-state event
3484         is sent before every fragment navigation, so we have to test
3485         for it in addition in PageLoadDidChangeLocationWithinPageForFrame.
3486
3487         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3488         (TestWebKitAPI::didSameDocumentNavigationForFrame):
3489
3490 2010-12-12  Alejandro G. Castro  <alex@igalia.com>
3491
3492         Reviewed by Eric Seidel.
3493
3494         [GTK] Add new-run-webkit-tests support to gtk
3495         https://bugs.webkit.org/show_bug.cgi?id=50681
3496
3497         Adding the basic support to run the new-run-webkit-tests.
3498
3499         * Scripts/webkitpy/layout_tests/port/gtk.py:
3500
3501 2010-10-11  Diego Gonzalez  <diegohcg@webkit.org>
3502
3503         Reviewed by Kenneth Rohde Christiansen.
3504
3505         [Qt] Mock DeviceOrientation client for DRT
3506         https://bugs.webkit.org/show_bug.cgi?id=47490
3507
3508         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3509         (WebCore::DumpRenderTree::DumpRenderTree):
3510         (WebCore::DumpRenderTree::~DumpRenderTree):
3511         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3512         (LayoutTestController::setMockDeviceOrientation):
3513
3514 2010-12-11  Philippe Normand  <pnormand@igalia.com>
3515
3516         Reviewed by Gustavo Noronha Silva.
3517
3518         [GTK] launcher: disable the Mozilla-style fullscreen API
3519         https://bugs.webkit.org/show_bug.cgi?id=50874
3520
3521         Disabling the fullscreen API until its implementation for GTK is
3522         mature enough. The webview setting for it is already FALSE by
3523         default.
3524
3525         * GtkLauncher/main.c:
3526         (createWindow):
3527
3528 2010-12-10  Eric Seidel  <eric@webkit.org>
3529
3530         Reviewed by Adam Barth.
3531
3532         commit-queue flaky test messages show cryptic version information for mac os x
3533         https://bugs.webkit.org/show_bug.cgi?id=50864
3534
3535         Turns out platform.platform() returns kernel version information
3536         which isn't helpful, and just plain confusing on Mac
3537         (OS X 10.6.5 uses Darwin Kernel 10.5.0).
3538
3539         So I've updated PlatformInfo.display_name() to special case
3540         mac.  I also found a bad use of sys.platform in the process
3541         and fixed that.  (sys.platform always returns 'darwin' on mac).
3542
3543         * Scripts/webkitpy/common/system/platforminfo.py:
3544         * Scripts/webkitpy/common/system/user.py:
3545         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3546         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3547         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3548
3549 2010-12-10  Eric Seidel  <eric@webkit.org>
3550
3551         Unreviewed.
3552
3553         Exception seen while reporting flaky test with commit-queue.
3554         Just a missing include.
3555
3556         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3557         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3558
3559 2010-12-10  Kinuko Yasuda  <kinuko@chromium.org>
3560
3561         Reviewed by Eric Seidel.
3562
3563         [Chromium] Remove old JSONResultsGenerator script that existed for backward-compatibility
3564         https://bugs.webkit.org/show_bug.cgi?id=50796
3565
3566         Also updating the test code to use JSONResultsGeneratorBase and
3567         to improve test coverage for incremental cases.
3568
3569         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3570         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3571
3572 2010-12-10  Joseph Pecoraro  <joepeck@webkit.org>
3573
3574         Reviewed by Darin Adler.
3575
3576         prepare-ChangeLog --help doesn't mention --bug shorthand -b
3577         https://bugs.webkit.org/show_bug.cgi?id=50835
3578
3579         * Scripts/prepare-ChangeLog: be more explicit about -b and match file style.
3580
3581 2010-12-10  Eric Seidel  <eric@webkit.org>
3582
3583         Reviewed by Adam Barth.
3584
3585         Bugs created by the commit-queue should all block on a master bug
3586         https://bugs.webkit.org/show_bug.cgi?id=50857
3587
3588         This makes all bugs created by the commit-queue block on:
3589         https://bugs.webkit.org/show_bug.cgi?id=50856
3590
3591         In the process of testing this, I found that the existing
3592         create_bug code was wrong.  I also found that existing
3593         unit tests for create-rollout used invalid values
3594         for options.blocks.  I fixed both issues and tested.
3595
3596         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3597         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3598         * Scripts/webkitpy/tool/commands/commandtest.py:
3599         * Scripts/webkitpy/tool/commands/download_unittest.py:
3600         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3601         * Scripts/webkitpy/tool/mocktool.py:
3602         * Scripts/webkitpy/tool/steps/options.py:
3603
3604 2010-12-10  Eric Seidel  <eric@webkit.org>
3605
3606         Reviewed by Adam Barth.
3607
3608         Teach webkitpy how to follow duplicate chains when posting comments on flake bugs
3609         https://bugs.webkit.org/show_bug.cgi?id=50853
3610
3611         I also discovered when doing this that the code was posting
3612         the comment on the wrong bug, but that's fixed here too.
3613
3614         * Scripts/webkitpy/common/net/bugzilla/bug.py:
3615         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3616         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3617         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3618         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3619         * Scripts/webkitpy/tool/mocktool.py:
3620
3621 2010-12-10  Anders Carlsson  <andersca@apple.com>
3622
3623         Reviewed by John Sullivan.
3624
3625         Make WKContextGetStatistics gather global statistics
3626         https://bugs.webkit.org/show_bug.cgi?id=50850
3627
3628         Remove the code that gets the statistics and fills in the per context
3629         statistics information for now.
3630
3631         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
3632         (-[BrowserStatisticsWindowController refreshStatistics:]):
3633
3634 2010-12-10  Eric Seidel  <eric@webkit.org>
3635
3636         Unreviewed.
3637
3638         commit-queue should report port/platform information when commenting on flaky test bugs
3639         https://bugs.webkit.org/show_bug.cgi?id=50839
3640
3641         Renamed platform.py to platforminfo.py.  This broke import platform in executive.py
3642         which was only used by new run webkit tests (and clearly not unit tested).
3643
3644         * Scripts/webkitpy/common/system/platforminfo.py: Renamed from WebKitTools/Scripts/webkitpy/common/system/platform.py.
3645         * Scripts/webkitpy/tool/main.py:
3646         * Scripts/webkitpy/tool/mocktool.py:
3647
3648 2010-12-10  Eric Seidel  <eric@webkit.org>
3649
3650         Reviewed by Tony Chang.
3651
3652         commit-queue should report port/platform information when commenting on flaky test bugs
3653         https://bugs.webkit.org/show_bug.cgi?id=50839
3654
3655         This was a suggestion from Tony Chang this morning.
3656         I added a platform.py class so I could easily mock the platform call,
3657         but that may not be the final solution for this mocking.
3658         We'll try it and see.
3659
3660         * Scripts/webkitpy/common/system/platform.py: Added.
3661         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3662         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3663         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3664         * Scripts/webkitpy/tool/main.py:
3665         * Scripts/webkitpy/tool/mocktool.py:
3666
3667 2010-12-10  Krithigassree Sambamurthy  <krithigassree.sambamurthy@nokia.com>
3668
3669         Reviewed by Joseph Pecoraro.
3670
3671         Bug 43455 - [Qt]: Implement Application Cache Quotas
3672         https://bugs.webkit.org/show_bug.cgi?id=43455
3673
3674         Introduce functions to allow new appcache layout test origin-quota.html
3675         to work correctly under Qt.
3676
3677         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3678         (WebCore::DumpRenderTree::DumpRenderTree):
3679         (WebCore::DumpRenderTree::dumpApplicationCacheQuota):
3680         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3681
3682         Introduce functions to allow new appcache layout test origin-quota.html
3683         to be successful under qt. Changes required because LayoutTestControllerQt
3684         does not inherit from LayoutController.
3685
3686         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3687         (LayoutTestController::reset):
3688         (LayoutTestController::clearAllApplicationCaches):
3689         (LayoutTestController::setApplicationCacheOriginQuota):
3690         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3691         (LayoutTestController::shouldDumpApplicationCacheDelegateCallbacks):
3692         (LayoutTestController::dumpApplicationCacheDelegateCallbacks):
3693
3694 2010-12-10  Eric Seidel  <eric@webkit.org>
3695
3696         Reviewed by Adam Barth.
3697
3698         Move buildbot.py into its own module so we can split it out into one-file-per-class
3699         https://bugs.webkit.org/show_bug.cgi?id=50806
3700
3701         We're adding more buildbot logic these days, so it makes sense
3702         to give buildbot its own module.
3703
3704         * Scripts/webkitpy/common/net/buildbot/__init__.py: Added.
3705         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot.py.
3706         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot_unittest.py.
3707         * Scripts/webkitpy/common/net/failuremap.py:
3708         * Scripts/webkitpy/common/net/regressionwindow.py:
3709         * Scripts/webkitpy/tool/commands/rebaseline.py:
3710
3711 2010-12-10  Tony Chang  <tony@chromium.org>
3712
3713         Reviewed by Eric Seidel.
3714
3715         Use FileSystem::remove when cleaning up http lock files
3716         https://bugs.webkit.org/show_bug.cgi?id=50830
3717
3718         * Scripts/webkitpy/layout_tests/port/http_lock.py:
3719
3720 2010-12-10  Joone Hur  <joone@kldp.org>
3721
3722         Reviewed by Martin Robinson.
3723
3724         [GTK] DRT needs layoutTestController.setCacheModel
3725         https://bugs.webkit.org/show_bug.cgi?id=50705
3726         
3727         webkit_set_cache_mode() is called to set the cache model.
3728         
3729         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3730         (LayoutTestController::setCacheModel): Set the cache model. 
3731
3732 2010-12-10  Tony Chang  <tony@chromium.org>
3733
3734         Reviewed by Ojan Vafai.
3735
3736         [chromium] remove --use-drt and add --use-test-shell
3737         https://bugs.webkit.org/show_bug.cgi?id=50701
3738
3739         * Scripts/webkitpy/common/config/ports.py:
3740         * Scripts/webkitpy/common/config/ports_unittest.py:
3741         * Scripts/webkitpy/layout_tests/port/chromium.py:
3742         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3743         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3744         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3745         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3746         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3747         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3748         * Scripts/webkitpy/layout_tests/port/webkit.py:
3749         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3750         * Scripts/webkitpy/style/checkers/test_expectations.py:
3751         * Scripts/webkitpy/tool/commands/queries.py:
3752
3753 2010-12-10  John Knottenbelt  <jknotten@chromium.org>
3754
3755         Reviewed by Steve Block.
3756
3757         [Chromium] Implement mocks for client-based geolocation
3758         https://bugs.webkit.org/show_bug.cgi?id=46895
3759
3760         * DumpRenderTree/chromium/LayoutTestController.cpp:
3761         (LayoutTestController::setGeolocationPermission):
3762         (LayoutTestController::setMockGeolocationPosition):
3763         (LayoutTestController::setMockGeolocationError):
3764         * DumpRenderTree/chromium/LayoutTestController.h:
3765         * DumpRenderTree/chromium/WebViewHost.cpp:
3766         (WebViewHost::geolocationClient):
3767         (WebViewHost::geolocationClientMock):
3768         (WebViewHost::reset):
3769         * DumpRenderTree/chromium/WebViewHost.h:
3770
3771 2010-12-10  Alejandro G. Castro  <alex@igalia.com>
3772
3773         Reviewed by Martin Robinson.
3774
3775         [GTK] Add hasSpellingMarker support to the DRT
3776         https://bugs.webkit.org/show_bug.cgi?id=50739
3777
3778         Implemented the hasSpellingMarker to support spelling tests.
3779
3780         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3781         (LayoutTestController::hasSpellingMarker):
3782
3783 2010-12-10  Eric Seidel  <eric@webkit.org>
3784
3785         Reviewed by Ojan Vafai.
3786
3787         webkit-patch: not possible to use build-and-test with local commits
3788         https://bugs.webkit.org/show_bug.cgi?id=33378
3789
3790         Make --no-clean not even check if we have local commits.
3791         It's unclear to me why the code was originally written this way.
3792         I was unable to dig up a reason from svn history.
3793
3794         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
3795         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
3796
3797 2010-12-10  Mario Sanchez Prada  <msanchez@igalia.com>
3798
3799         Reviewed by Martin Robinson.
3800
3801         [GTK] AX: implement isEnabled in DRT
3802         https://bugs.webkit.org/show_bug.cgi?id=50814
3803
3804         Implement AccessibilityUIElement::isEnabled() for GTK.
3805
3806         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3807         (checkElementState): New function to refactor common code.
3808         (AccessibilityUIElement::isEnabled): Implement this by checking
3809         the current state of the AtkObject.
3810         (AccessibilityUIElement::isSelected): Use the new
3811         checkElementState function.
3812
3813 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3814
3815         Reviewed by Kenneth Rohde Christiansen.
3816
3817         [Qt][WK2] Add the QWKContext API class to wrap the WebContext.
3818         https://bugs.webkit.org/show_bug.cgi?id=50750
3819
3820         * MiniBrowser/qt/BrowserView.cpp:
3821         (BrowserView::BrowserView):
3822         * MiniBrowser/qt/BrowserView.h:
3823         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3824         (WTR::WebView::WebView):
3825
3826 2010-12-10  Joone Hur  <joone@kldp.org>
3827
3828         Reviewed by Xan Lopez.
3829
3830         [GTK] Unskipping some test cases in userscripts dependent on addUserStyleSheet
3831         https://bugs.webkit.org/show_bug.cgi?id=50808
3832
3833         Unskipping the following test cases:
3834         userscripts/mixed-case-stylesheet.html
3835         userscripts/simple-stylesheet.html
3836         userscripts/user-style-all-frames.html
3837
3838         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3839         (LayoutTestController::addUserStyleSheet):
3840
3841 2010-12-10  Joone Hur  <joone@kldp.org>
3842
3843         Reviewed by Eric Seidel.
3844
3845         [GTK] Add DRT support for pageProperty, isPageBoxVisible, pageSizeAndMarginsInPixels, and addUserStyleSheet
3846         https://bugs.webkit.org/show_bug.cgi?id=50783
3847
3848         This patch allows to unskip the following test cases:
3849         printing/page-rule-selection.html
3850         printing/page-format-data.html
3851
3852         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3853         (LayoutTestController::pageProperty): Added.
3854         (LayoutTestController::isPageBoxVisible): Ditto.
3855         (LayoutTestController::pageSizeAndMarginsInPixels): Ditto.
3856         (LayoutTestController::addUserStyleSheet): Ditto.
3857
3858 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3859
3860         Reviewed by Kenneth Rohde Christiansen.
3861
3862         [Qt] Make QtTestBrowser spawn QNAM in a secondary thread.
3863
3864         A menu allows to switch QNAM back to the same thread.
3865
3866         * QtTestBrowser/launcherwindow.cpp:
3867         (LauncherWindow::initializeView):
3868         (LauncherWindow::createChrome):
3869         (LauncherWindow::toggleThreadedQnam):
3870         * QtTestBrowser/launcherwindow.h:
3871         (WindowOptions::WindowOptions):
3872         * QtTestBrowser/webpage.cpp:
3873         (WebPage::WebPage):
3874         (WebPage::setQnamThreaded):
3875         * QtTestBrowser/webpage.h:
3876         (QnamThread::QnamThread):
3877         (QnamThread::~QnamThread):
3878         (QnamThread::networkAccessManager):
3879         (QnamThread::run):
3880
3881 2010-12-10  Martin Robinson  <mrobinson@igalia.com>
3882
3883         Reviewed by Xan Lopez.
3884
3885         [Gtk] style="font-family: courier" makes text disappear
3886         https://bugs.webkit.org/show_bug.cgi?id=47452
3887
3888         Add a test that verifies that fonts without valid charmaps are
3889         never selected.
3890
3891         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3892         (initializeFonts): Initialize DRT with our font (derived from Ahem)
3893         that has no valid charmap.
3894         * DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon: Added.
3895         * DumpRenderTree/gtk/fonts/fonts.conf: Updated settings to override users'
3896         settings which may disable selection of bitmap fonts.
3897
3898 2010-12-10  Eric Seidel  <eric@webkit.org>
3899
3900         Unreviewed.
3901
3902         The commit-queue should file bugs about flaky tests it encounters
3903         https://bugs.webkit.org/show_bug.cgi?id=50803
3904
3905         create_bug_for_flaky_test was insufficiently tested, thus buggy.
3906         Now it's tested.
3907
3908         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3909         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3910
3911 2010-12-10  Eric Seidel  <eric@webkit.org>
3912
3913         Unreviewed.  Somehow this last-minute edit didn't quite get committed.
3914
3915         The commit-queue should file bugs about flaky tests it encounters
3916         https://bugs.webkit.org/show_bug.cgi?id=50803
3917
3918         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3919
3920 2010-12-09  Eric Seidel  <eric@webkit.org>
3921
3922         Reviewed by Adam Barth.
3923
3924         The commit-queue should file bugs about flaky tests it encounters
3925         https://bugs.webkit.org/show_bug.cgi?id=50803
3926
3927         This change got a bit big.  I also added a new config.urls file
3928         because I needed to share the view_source_url code with committervalidator.py.
3929
3930         This adds a new class FlakyTestReporter which holds all the logic about
3931         reporting flaky tests to bugzilla.
3932
3933         Right now this code knows how to look up bugs for flaky tests.
3934         If it can't find a bug filed from the commit-queue, it will open a new
3935         one, ccing the relevant people and adding information about the failure.
3936
3937         It is not yet smart enough to chase down duplicate chains, or to include
3938         the actual failure diff.  But those can be added in later iterations.
3939
3940         * Scripts/webkitpy/common/checkout/api.py:
3941         * Scripts/webkitpy/common/checkout/changelog.py:
3942         * Scripts/webkitpy/common/checkout/commitinfo.py:
3943         * Scripts/webkitpy/common/config/committervalidator.py:
3944         * Scripts/webkitpy/common/config/urls.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
3945         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3946         * Scripts/webkitpy/tool/bot/flakytestreporter.py: Added.
3947         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
3948         * Scripts/webkitpy/tool/bot/irc_command.py:
3949         * Scripts/webkitpy/tool/bot/sheriff.py:
3950         * Scripts/webkitpy/tool/commands/download.py:
3951         * Scripts/webkitpy/tool/commands/queues.py:
3952         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3953         * Scripts/webkitpy/tool/comments.py:
3954         * Scripts/webkitpy/tool/mocktool.py:
3955         * Scripts/webkitpy/tool/steps/commit.py:
3956
3957 2010-12-09  Eric Seidel  <eric@webkit.org>
3958
3959         Reviewed by Adam Barth.
3960
3961         Teach webkit-patch how to search bugzilla
3962         https://bugs.webkit.org/show_bug.cgi?id=50500
3963
3964         This is a step towards teaching webkitpy how to file
3965         new bugs for flaky tests and update them when new flakes occur.
3966
3967         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3968         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3969         * Scripts/webkitpy/tool/commands/__init__.py:
3970         * Scripts/webkitpy/tool/commands/bugsearch.py: Added.
3971
3972 2010-12-09  Adam Barth  <abarth@webkit.org>
3973
3974         Reviewed by Ojan Vafai.
3975
3976         commit-queue errors out due to local commits
3977         https://bugs.webkit.org/show_bug.cgi?id=50766
3978
3979         We seem to be tripping over having local commits in the working copy a
3980         lot recently.  I don't quite fully understand what the issue is, but
3981         this patch attempts to solve the problem by adding an explicit clean
3982         step before processing a patch.  Previously, we did the cleaning as
3983         part of the apply-attachment step, so this might not actually fix the
3984         problem.
3985
3986         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3987         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3988         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3989
3990 2010-12-09  Dirk Pranke  <dpranke@chromium.org>
3991
3992         Reviewed by Ojan Vafai.
3993
3994         Make new-run-webkit-tests --lint-test-files log slightly better
3995         messages and return -1 if lint fails. Remove the
3996         'suppress_errors' keyword param to the TestExpectationsFile
3997         class, and clean up logging and exception raising for error
3998         handling. Also add more unit tests and clean up the unit test code a bit.
3999
4000         https://bugs.webkit.org/show_bug.cgi?id=50205
4001
4002         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4003         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
4004         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py
4005         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py
4006         * Scripts/webkitpy/layout_tests/port/chromium.py:
4007         * Scripts/webkitpy/style/checkers/test_expectations.py:
4008         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
4009
4010 2010-12-09  Tony Chang  <tony@chromium.org>
4011
4012         Unreviewed, fix for windows code.  We were catching the wrong
4013         exception in Windows.
4014
4015         * Scripts/webkitpy/common/system/filesystem.py:
4016
4017 2010-12-09  Antonio Gomes  <agomes@rim.com>
4018
4019         Reviewed by Martin Robinson.
4020
4021         [Gtk] Populate DumpRenderTreeSupportGtk (part IV)
4022         https://bugs.webkit.org/show_bug.cgi?id=48429
4023
4024         Adjust call sites of webkit_thread_count to use the DumpRenderTreeSupportGtk version now.
4025
4026         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4027         (LayoutTestController::workerThreadCount):
4028
4029 2010-12-06  Philippe Normand  <pnormand@igalia.com>
4030
4031         Reviewed by Martin Robinson.
4032
4033         [GTK] Support the Mozilla-style Fullscreen Javascript API
4034         https://bugs.webkit.org/show_bug.cgi?id=50572
4035
4036         Enable the Javascript Fullscreen support in the GtkLauncher. Also
4037         make DRT update the Chrome when the WebView settings have been
4038         reset to consistent values.
4039
4040         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4041         (resetDefaultsToConsistentValues):
4042         * GtkLauncher/main.c:
4043         (create_window):
4044         * Scripts/build-webkit:
4045
4046 2010-12-09  Koan-Sin Tan  <koansin.tan@gmail.com>
4047
4048         Reviewed by Tor Arne Vestbø
4049
4050         [Qt] run-launcher doesn't start the browser on Mac OS X 10.6
4051         https://bugs.webkit.org/show_bug.cgi?id=50742
4052
4053         check not only QtWebKit.framework/QtWebKit but also libQtWebKit.dylib
4054
4055         * Scripts/webkitdirs.pm:
4056
4057 2010-12-09  Joone Hur  <joone@kldp.org>
4058
4059          Reviewed by Martin Robinson.
4060
4061          [GTK] Support for viewport meta tag
4062          https://bugs.webkit.org/show_bug.cgi?id=45443
4063
4064          Add support for testing the viewport properties for WebKitGtk.
4065
4066          * DumpRenderTree/LayoutTestController.cpp:
4067          (dumpConfigurationForViewportCallback): Added this JS callback to set the size of the visible viewport.
4068          (LayoutTestController::staticFunctions):
4069          * DumpRenderTree/LayoutTestController.h:
4070          * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4071          (LayoutTestController::dumpConfigurationForViewport): Added this function to test the viewport properties.
4072          * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4073          (LayoutTestController::dumpConfigurationForViewport): Ditto.
4074          * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4075          (LayoutTestController::dumpConfigurationForViewport): Ditto.
4076          * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4077          (LayoutTestController::dumpConfigurationForViewport): Ditto.
4078          * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
4079          (LayoutTestController::dumpConfigurationForViewport): Ditto.
4080
4081 2010-12-08  William Siegrist <wsiegrist@apple.com>
4082
4083         Reviewed by Eric Seidel.
4084
4085         Migrate buildbot.py from xmlrpc to json.
4086         https://bugs.webkit.org/show_bug.cgi?id=50647
4087
4088         * Scripts/webkitpy/common/net/buildbot.py:
4089
4090 2010-12-08  Tony Chang  <tony@chromium.org>
4091
4092         Reviewed by Eric Seidel.
4093
4094         make starting the websocket server more reliable on windows
4095         https://bugs.webkit.org/show_bug.cgi?id=50712
4096
4097         * Scripts/webkitpy/common/system/filesystem.py:
4098         (remove): Substitute method for os.remove to retry on error on Windows
4099         * Scripts/webkitpy/common/system/filesystem_unittest.py:
4100         * Scripts/webkitpy/layout_tests/port/http_server_base.py: Use FileSystem.remove
4101
4102 2010-12-08  Jessie Berlin  <jberlin@apple.com>
4103
4104         Reviewed by Adam Roben.
4105
4106         WebKit2: Implement WebChromeClient::exceededDatabaseQuota
4107         https://bugs.webkit.org/show_bug.cgi?id=50656
4108
4109         * MiniBrowser/mac/BrowserWindowController.m:
4110         (-[BrowserWindowController awakeFromNib]):
4111         Indicate that exceededDatabaseQuota is not implemented.
4112         * MiniBrowser/win/BrowserView.cpp:
4113         (BrowserView::create):
4114         Ditto.
4115         * WebKitTestRunner/TestController.cpp:
4116         (WTR::createOtherPage):
4117         Ditto.
4118         (WTR::TestController::initialize):
4119         Ditto.
4120
4121 2010-12-08  Antonio Gomes  <agomes@rim.com>
4122
4123         Reviewed by Martin Robinson.
4124
4125         [Gtk] Populate DumpRenderTreeSupportGtk (part III)
4126         https://bugs.webkit.org/show_bug.cgi?id=48429
4127
4128         Moved the following methods from webkitprivate.h to DumpRenderTreeSupportGtk.cpp|h:
4129         * webkit_gc_collect_javascript_objects;
4130         * webkit_gc_collect_javascript_objects_on_alternate_thread;
4131         * webkit_gc_count_javascript_objects;
4132         * webkit_web_frame_layout.
4133
4134         These were all only used by GTK+ DRT.
4135
4136         * DumpRenderTree/gtk/EventSender.cpp:
4137         (dispatchEvent):
4138         * DumpRenderTree/gtk/GCControllerGtk.cpp:
4139         (GCController::collect):
4140         (GCController::collectOnAlternateThread):
4141         (GCController::getJSObjectCount):
4142
4143 2010-12-07  Tony Chang  <tony@chromium.org>
4144
4145         Reviewed by Ojan Vafai.
4146
4147         [chromium] force NRWT to use DRT
4148         https://bugs.webkit.org/show_bug.cgi?id=50359
4149
4150         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4151
4152 2010-12-06  Sam Weinig  <sam@webkit.org>
4153
4154         Reviewed by Anders Carlsson.
4155
4156         Generalize didChangeLocationWithinPageForFrame for all same document navigations
4157         https://bugs.webkit.org/show_bug.cgi?id=50584
4158
4159         * MiniBrowser/mac/BrowserWindowController.m:
4160         (didSameDocumentNavigationForFrame):
4161         (-[BrowserWindowController awakeFromNib]):
4162         (-[BrowserWindowController didSameDocumentNavigationForFrame:]):
4163         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
4164         (TestWebKitAPI::didSameDocumentNavigationForFrame):
4165         (TestWebKitAPI::TEST):
4166         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4167         (WTR::InjectedBundlePage::InjectedBundlePage):
4168         (WTR::InjectedBundlePage::didSameDocumentNavigationForFrame):
4169         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
4170         * WebKitTestRunner/TestController.cpp:
4171         (WTR::TestController::initialize):
4172
4173 2010-12-06  Kinuko Yasuda  <kinuko@chromium.org>
4174
4175         Reviewed by Ojan Vafai.
4176
4177         Make TestResultsServer return 404 for non-existing results files.
4178         https://bugs.webkit.org/show_bug.cgi?id=50581
4179
4180         * TestResultServer/handlers/testfilehandler.py:
4181
4182 2010-12-06  Tony Chang  <tony@chromium.org>
4183
4184         Reviewed by Ojan Vafai.
4185
4186         [chromium] fix an assert hit in DRT
4187         https://bugs.webkit.org/show_bug.cgi?id=50575
4188
4189         This class uses WTF's RefPtr, but expects chrome's base::RefPtr
4190         semantics.
4191
4192         Otherwise, we hit ASSERTION FAILED: !m_adoptionIsRequired
4193         (third_party/WebKit/JavaScriptCore/wtf/RefCounted.h:37 void
4194         WTF::RefCountedBase::ref()).
4195
4196         * DumpRenderTree/chromium/TestWebWorker.h:
4197         (TestWebWorker::TestWebWorker):
4198
4199 2010-12-02  Ojan Vafai  <ojan@chromium.org>
4200
4201         Reviewed by Eric Seidel.
4202
4203         make webkit-patch command work when the git branch is not synced to the remote svn branch
4204         https://bugs.webkit.org/show_bug.cgi?id=50424
4205
4206         * Scripts/webkitpy/common/checkout/scm.py:
4207         * Scripts/webkitpy/common/checkout/scm_unittest.py:
4208
4209 2010-12-06  Patrick Gansterer  <paroga@webkit.org>
4210
4211         Reviewed by Andreas Kling.
4212
4213         [WINCE] Add build system
4214         https://bugs.webkit.org/show_bug.cgi?id=50522
4215
4216         * CMakeListsWinCE.txt: Added.
4217
4218 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
4219
4220         Reviewed by Tony Chang.
4221
4222         Allow the Chromium port to have Leopard-specific baselines
4223         https://bugs.webkit.org/show_bug.cgi?id=50506
4224
4225         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
4226
4227 2010-12-03  Tony Chang  <tony@chromium.org>
4228
4229         Reviewed by Kent Tamura.
4230
4231         [chromium] fix 2 bugs with inspector tests in DRT
4232         https://bugs.webkit.org/show_bug.cgi?id=50492
4233
4234         Tasks can outlive the tasklist (even when canceled) so this was
4235         causing a crash when ~WebTask() ran.  Avoid this by unregistering
4236         when a task is canceled.
4237
4238         Also fix an assert when closing devtool windows by copying some
4239         logic from test_shell.
4240
4241         * DumpRenderTree/chromium/Task.cpp:
4242         (WebTask::~WebTask):
4243         (TaskList::revokeAll):
4244         * DumpRenderTree/chromium/Task.h: Canceling a task now removes it from
4245             the tasklist (since the task can outlive the tasklist).
4246         * DumpRenderTree/chromium/TestShell.h:
4247         (TestShell::devToolsWebView):
4248         * DumpRenderTree/chromium/WebViewHost.cpp:
4249         (WebViewHost::~WebViewHost): Don't load about:blank when closing
4250             a window if the window has devtools loaded.  This avoids an
4251             ASSERT and matches test_shell.
4252
4253 2010-12-06  Alejandro G. Castro  <alex@igalia.com>
4254
4255         Reviewed by Martin Robinson.
4256
4257         [GTK] Fix GtkLauncher.c style, use webkit style
4258         https://bugs.webkit.org/show_bug.cgi?id=50542
4259
4260         * GtkLauncher/main.c:
4261         (activateUriEntryCb):
4262         (updateTitle):
4263         (linkHoverCb):
4264         (notifyTitleCb):
4265         (notifyLoadStatusCb):
4266         (notifyProgressCb):
4267         (destroyCb):
4268         (goBackCb):
4269         (goForwardCb):
4270         (create_webViewCb):
4271         (webViewReadyCb):
4272         (closeWebViewCb):
4273         (createBrowser):
4274         (createStatusbar):
4275         (createToolbar):
4276         (createWindow):
4277         (main):
4278
4279 2010-12-04  Antonio Gomes  <agomes@rim.com>
4280
4281         Reviewed by Martin Robinson.
4282
4283         [Gtk] Populate DumpRenderTreeSupportGtk (Part II)
4284         https://bugs.webkit.org/show_bug.cgi?id=48429
4285
4286         Moved more private method declared with WEBKIT_API to
4287         DumpRenderTreeSupportGtk, since they were only being used by DRT.
4288
4289         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4290         (resetDefaultsToConsistentValues):
4291         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4292         (LayoutTestController::addOriginAccessWhitelistEntry):
4293         (LayoutTestController::execCommand):
4294         (LayoutTestController::isCommandEnabled):
4295
4296 2010-12-04  Antonio Gomes  <agomes@rim.com>
4297
4298         Reviewed by Andreas Kling.
4299
4300         Removed extern webkit_web_view_set_group_name from gtk/DumpRenderTree.cpp
4301
4302         Method was removed by http://trac.webkit.org/changeset/71604
4303
4304         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4305
4306 2010-12-05  Alejandro G. Castro  <alex@igalia.com>
4307
4308         Reviewed by Xan Lopez.
4309
4310         [GTK] Fix compilation warnings reported by clang
4311         https://bugs.webkit.org/show_bug.cgi?id=50252
4312
4313         * GtkLauncher/main.c:
4314         (create_window): The create_statusbar function does not have
4315         parameters.
4316
4317 2010-12-05  Robert Hogan  <robert@webkit.org>
4318
4319         Reviewed by Andreas Kling.
4320
4321         [Qt] Zero-sized font does not yet work
4322
4323         Fix fast/text/font-size-zero.html