357ccfcde2c26b3843fe5fdb07adcb2e5c45df64
[WebKit-https.git] / Tools / ChangeLog
1 2011-03-17  Adam Roben  <aroben@apple.com>
2
3         Make old-run-webkit-tests pick up mac-wk2 results when running in WebKit2 mode on Windows
4
5         Fixes <http://webkit.org/b/56563> Running WebKit2 tests on Windows should use results from
6         mac-wk2
7
8         Reviewed by Anders Carlsson.
9
10         * Scripts/old-run-webkit-tests:
11         (expectedDirectoryForTest): Clean up the code to search in extra Mac platform result
12         directories on Windows. Add mac-wk2 to the set of extra platforms we look in on Windows when
13         we're running in WebKit2 mode.
14
15 2011-03-17  Mikhail Naganov  <mnaganov@chromium.org>
16
17         Reviewed by Yury Semikhatsky.
18
19         Web Inspector: Clean up Inspector strings.
20         https://bugs.webkit.org/show_bug.cgi?id=56557
21
22         Modify the script to deal correctly with "\xNN" escapes, and to
23         check strings in Chromium's DevTools.js.
24
25         * Scripts/check-inspector-strings:
26
27 2011-03-17  Keith Kyzivat  <keith.kyzivat@nokia.com>
28
29         Reviewed by Benjamin Poulain.
30
31         Update autoinstall to install mechanize 0.2.4
32         https://bugs.webkit.org/show_bug.cgi?id=56499
33
34         Newer versions of mechanize support HTTPS proxies, which is necessary
35         for people using webkit-patch behind firewalls.
36
37         * Scripts/webkitpy/common/system/autoinstall.py:
38         * Scripts/webkitpy/thirdparty/__init__.py:
39
40 2011-03-16  Sam Weinig  <sam@webkit.org>
41
42         Reviewed by Adam Roben.
43
44         REGRESSION (r81084): media/invalid-media-url-crash.html and editing/execCommand/indent-paragraphs.html failing on WebKit2
45         https://bugs.webkit.org/show_bug.cgi?id=56541
46
47         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
48         (WTR::InjectedBundlePage::willSendRequestForFrame):
49         Check for an empty host in addition to a null host.  This bug was introduced
50         when porting off of the KURL code and onto the WKURLRef version.
51
52 2011-03-16  Sam Weinig  <sam@webkit.org>
53
54         Reviewed by Adam Roben.
55
56         Add Lucas Forschler to the list of WebKit committers.
57
58         * Scripts/webkitpy/common/config/committers.py:
59
60 2011-03-16  Sam Weinig  <sam@webkit.org>
61
62         Reviewed upon and dictated through Adam Roben.
63
64         Escape crashing function names in results.html. This fixes an issue
65         when a crash involves a type with templates.
66
67         * Scripts/old-run-webkit-tests:
68
69 2011-03-16  Daniel Sievers  <sievers@google.com>
70
71         Reviewed by James Robinson.
72
73         Add setting to always force compositing mode
74         https://bugs.webkit.org/show_bug.cgi?id=56156
75
76         * DumpRenderTree/chromium/DumpRenderTree.cpp:
77         (main):
78         * DumpRenderTree/chromium/TestShell.cpp:
79         (TestShell::TestShell):
80         (TestShell::resetWebSettings):
81         * DumpRenderTree/chromium/TestShell.h:
82         (TestShell::setForceCompositingMode):
83         * DumpRenderTree/chromium/WebPreferences.cpp:
84         (WebPreferences::reset):
85         (WebPreferences::applyTo):
86         * DumpRenderTree/chromium/WebPreferences.h:
87
88 2011-03-15  Hayato Ito  <hayato@chromium.org>
89
90         Reviewed by Ojan Vafai.
91
92         Ignore files that will be used by reftests in old-run-webkit-tests.
93
94         https://bugs.webkit.org/show_bug.cgi?id=55936
95
96         * Scripts/old-run-webkit-tests:
97
98 2011-03-15  Felipe Oliveira da Silva Netto  <f.dachshund@gmail.com>
99
100         Reviewed by Adam Roben.
101
102         Function relativeScriptsDir doesn't return the correct relative
103         Scripts directory.
104
105         * Scripts/webkitdirs.pm:
106         (relativeScriptsDir): Ensure we use the directory that contains
107         webkitdirs.pm, not the one that contains the original script that
108         was invoked.
109
110 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
111
112         [wx] Build fixes for long linker commands on Win and method return error, plus a Mac
113         fix to link against the Security framework after recent WebKitSystemInterface changes.
114
115         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
116         (LayoutTestController::originsWithLocalStorage):
117         * wx/build/settings.py:
118         * wx/build/waf_extensions.py:
119
120 2011-03-15  Sam Weinig  <sam@webkit.org>
121
122         Reviewed by Darin Adler.
123
124         Add script to convert a patch to a prettypatch and show in the default browser
125         https://bugs.webkit.org/show_bug.cgi?id=56416
126
127         This can be used either like
128             $ svn-create-patch | show-pretty-diff
129         or
130             $ show-pretty-diff patch.diff
131
132         * Scripts/show-pretty-diff: Added.
133
134 2011-03-15  Brian Weinstein  <bweinstein@apple.com>
135
136         Rubber-stamped by Adam Roben.
137
138         Adding myself as a reviewer.
139
140         * Scripts/webkitpy/common/config/committers.py:
141
142 2011-03-15  Anders Carlsson  <andersca@apple.com>
143
144         Try to fix the Windows build.
145
146         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp:
147         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
148
149 2011-03-15  Anders Carlsson  <andersca@apple.com>
150
151         Reviewed by Sam Weinig.
152
153         Make sure that NP_Shutdown is always the last NPP function called
154         https://bugs.webkit.org/show_bug.cgi?id=56391
155
156         Add a test that times out if an NP_Deallocate object is called after NP_Shutdown.
157
158         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
159         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
160         (PluginTest::PluginTest):
161         (PluginTest::NP_Shutdown):
162         (PluginTest::registerNPShutdownFunction):
163         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
164         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp: Added.
165         (NPDeallocateCalledBeforeNPShutdown::NPDeallocateCalledBeforeNPShutdown):
166         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
167         (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::hasProperty):
168         (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::getProperty):
169         (NPDeallocateCalledBeforeNPShutdown::NPP_New):
170         (NPDeallocateCalledBeforeNPShutdown::NPP_GetValue):
171         (NPDeallocateCalledBeforeNPShutdown::shutdown):
172         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
173         (NP_Shutdown):
174         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
175         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
176         * GNUmakefile.am:
177
178 2011-03-15  Ilya Sherman  <isherman@chromium.org>
179
180         Reviewed by Tony Chang.
181
182         Autofilled form elements are assigned fixed background color but not text color
183         https://bugs.webkit.org/show_bug.cgi?id=48382
184
185         * DumpRenderTree/LayoutTestController.cpp:
186         (setAutofilledCallback): Added.
187         (LayoutTestController::staticFunctions):
188         * DumpRenderTree/LayoutTestController.h:
189         * DumpRenderTree/chromium/LayoutTestController.cpp:
190         (LayoutTestController::LayoutTestController):
191         (LayoutTestController::setAutofilled): Added.
192         * DumpRenderTree/chromium/LayoutTestController.h:
193         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
194         (LayoutTestController::setAutofilled): Added.
195         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
196         (LayoutTestController::setAutofilled): Added.
197         (LayoutTestController::setValueForUser): Style tweak.
198         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
199         (LayoutTestController::setAutofilled): Added (stub).
200         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
201         (LayoutTestController::setAutofilled): Added (stub).
202
203 2011-03-15  Dan Bernstein  <mitz@apple.com>
204
205         Build fix after r81135.
206
207         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
208
209 2011-03-15  Dan Bernstein  <mitz@apple.com>
210
211         Build fix after r81135.
212
213         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
214         * WebKitTestRunner/mac/TestControllerMac.mm:
215         * WebKitTestRunner/mac/TestInvocationMac.mm:
216         * WebKitTestRunner/mac/main.mm:
217
218 2011-03-15  Balazs Kelemen  <kbalazs@webkit.org>
219
220         Reviewed by Adam Barth.
221
222         REGRESSION(80977): breaks Qt ARMv7 Linux Release bot
223         https://bugs.webkit.org/show_bug.cgi?id=56349
224
225         * QtTestBrowser/QtTestBrowser.pro: Link against fontconfig
226         on platforms where we use it. Copied from DumpRenderTree.pro.
227
228 2011-03-15  Dan Bernstein  <mitz@apple.com>
229
230         Build fix after r81135.
231
232         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
233         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
234
235 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
236
237         Reviewed by Darin Adler.
238
239         Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export
240         info into the headers rather than in export symbol definition files, but disable it on 
241         all platforms initially so we can deal with port build issues one port at a time.
242         
243         https://bugs.webkit.org/show_bug.cgi?id=27551
244
245         * DumpRenderTree/cg/ImageDiffCG.cpp:
246         * DumpRenderTree/chromium/config.h:
247         * DumpRenderTree/config.h:
248         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
249         * TestWebKitAPI/TestWebKitAPIPrefix.h:
250         * WebKitAPITest/HostWindow.cpp:
251         * WebKitAPITest/TestsController.cpp:
252         * WebKitAPITest/config.h: Added.
253         * WebKitAPITest/main.cpp:
254         * WebKitAPITest/tests/WebViewDestruction.cpp:
255         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp:
256         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
257         * WebKitTestRunner/InjectedBundle/GCController.cpp:
258         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
259         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
260         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
261         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
262         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
263         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
264         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
265         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp:
266         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp:
267         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
268         * WebKitTestRunner/TestController.cpp:
269         * WebKitTestRunner/TestInvocation.cpp:
270         * WebKitTestRunner/config.h: Added.
271         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
272         * WebKitTestRunner/qt/TestControllerQt.cpp:
273         * WebKitTestRunner/qt/TestInvocationQt.cpp:
274         * WebKitTestRunner/qt/main.cpp:
275         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
276         * WebKitTestRunner/win/TestControllerWin.cpp:
277         * WebKitTestRunner/win/TestInvocationWin.cpp:
278         * WebKitTestRunner/win/main.cpp:
279         * wx/build/settings.py:
280
281 2011-03-15  Hayato Ito  <hayato@chromium.org>
282
283         Reviewed by Shinichiro Hamaji.
284
285         [NRWT] Add support for reftests to new-run-webkit-tests.
286
287         https://bugs.webkit.org/show_bug.cgi?id=55457
288
289         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
290         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
291         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
292         * Scripts/webkitpy/layout_tests/port/base.py:
293         * Scripts/webkitpy/layout_tests/port/dryrun.py:
294         * Scripts/webkitpy/layout_tests/port/test.py:
295         * Scripts/webkitpy/layout_tests/port/test_files.py:
296         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
297
298 2011-03-15  Alejandro G. Castro  <alex@igalia.com>
299
300         Reviewed by Martin Robinson.
301
302         [GTK] Fix compilation warning after r80892
303         https://bugs.webkit.org/show_bug.cgi?id=56302
304
305         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
306         (LayoutTestController::originsWithLocalStorage):
307
308 2011-03-15  Robert Hogan  <robert@webkit.org>
309
310         Reviewed by Adam Barth.
311
312         Document the qmakearg argument, and hint how to build webkit2 on Qt
313         https://bugs.webkit.org/show_bug.cgi?id=56326
314
315         * Scripts/build-webkit: add --qmakearg to build-webkit --help
316
317 2011-03-15  Adam Roben  <aroben@apple.com>
318
319         Make Windows 7 Release (Tests) a core builder
320
321         We can probably make Windows XP Debug (Tests) a core builder, too, but we should probably
322         give it a few more days of greenness first.
323
324         Fixes <http://webkit.org/b/55665> Windows 7 Release (Tests) should be a core builder
325
326         Reviewed by Sam Weinig.
327
328         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
329         (BuildBot): Added a regexp to match Windows 7 Release (Tests).
330
331         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
332         (BuildBotTest): Updated the list of builders to match the current list on build.webkit.org.
333         Updated the core regexps to match the buildbot module. Updated the expected results to match
334         the current set of core builders.
335
336 2011-03-14  Adam Roben  <aroben@apple.com>
337
338         Add forgotten file from r81116
339
340         * TestWebKitAPI/Configurations/TestWebKitAPICFNetwork.vsprops: Added.
341
342 2011-03-14  Sam Weinig  <sam@webkit.org>
343
344         Reviewed by Adam Roben.
345
346         about:blank fake responses don't get serialized when sent the UIProcess
347         <rdar://problem/9108119>
348         https://bugs.webkit.org/show_bug.cgi?id=56357
349
350         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp: Added.
351         (TestWebKitAPI::decidePolicyForResponse):
352         (TestWebKitAPI::TEST):
353         Add test that loads of about:blank have a response with a MIMEType of text/html.
354
355         * TestWebKitAPI/PlatformUtilities.h:
356         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
357         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
358         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
359         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
360         Add helper to get the MIMEType from a WKURLResponse.
361
362         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
363         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
364         Add new files.
365
366 2011-03-14  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>
367
368         Reviewed by Kenneth Rohde Christiansen.
369
370         [Qt] Command-line options for QGLWidget and WebGL to QtTestBrowser
371         https://bugs.webkit.org/show_bug.cgi?id=56006
372
373         * QtTestBrowser/launcherwindow.cpp:
374         (LauncherWindow::initializeView):
375         * QtTestBrowser/main.cpp:
376         (LauncherApplication::handleUserOptions):
377
378 2011-03-14  James Kozianski  <koz@chromium.org>
379
380         Reviewed by Ojan Vafai.
381
382         Add method to make BuildBot return test outputs
383         https://bugs.webkit.org/show_bug.cgi?id=54374
384
385         The Builder.latest_cached_build will be used by the new rebaseline
386         script to determine the build to use baselines from.
387
388         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
389         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
390
391 2011-03-14  Adam Roben  <aroben@apple.com>
392
393         Test that WKBundlePageCanHandleRequest returns true for empty document URLs
394
395         Reviewed by Sam Weinig.
396
397         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp: Added.
398         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Store the result of the test.
399         (TestWebKitAPI::setInjectedBundleClient): Hook up our callback.
400         (TestWebKitAPI::TEST): Register "emptyscheme" as an empty document scheme, load a page to
401         ensure the web process is initialized, then ask the bundle to run the test and assert that
402         it succeeded.
403
404         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp: Added.
405         (TestWebKitAPI::CanHandleRequestTest::CanHandleRequestTest): Just call up to the base class.
406         (TestWebKitAPI::canHandleURL): Helper function to test whether WebKit2 claims to be able to
407         handle a given URL.
408         (TestWebKitAPI::runTest): Check that empty document URLs can be handled (and that an unknown
409         URL type cannot be handled).
410         (TestWebKitAPI::CanHandleRequestTest::didReceiveMessage): Run the test and return the
411         result.
412
413         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
414         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
415         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
416         Added new files to the project.
417
418 2011-03-14  Sheriff Bot  <webkit.review.bot@gmail.com>
419
420         Unreviewed, rolling out r81094.
421         http://trac.webkit.org/changeset/81094
422         https://bugs.webkit.org/show_bug.cgi?id=56355
423
424         Broke the chromium DRT related build. (Requested by dave_levin
425         on #webkit).
426
427         * DumpRenderTree/chromium/DumpRenderTree.cpp:
428         (main):
429         * DumpRenderTree/chromium/LayoutTestController.cpp:
430         (LayoutTestController::LayoutTestController):
431         (LayoutTestController::layerTreeAsText):
432         * DumpRenderTree/chromium/LayoutTestController.h:
433         * DumpRenderTree/chromium/TestShell.cpp:
434         (TestShell::runFileTest):
435         (TestShell::dump):
436         * DumpRenderTree/chromium/TestShell.h:
437         (TestParams::TestParams):
438
439 2011-03-14  Daniel Sievers  <sievers@google.com>
440
441         Reviewed by Simon Fraser.
442
443         [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
444         https://bugs.webkit.org/show_bug.cgi?id=56139
445
446         * DumpRenderTree/chromium/DumpRenderTree.cpp:
447         (main):
448         * DumpRenderTree/chromium/LayoutTestController.cpp:
449         (LayoutTestController::LayoutTestController):
450         (LayoutTestController::layerTreeAsText):
451         * DumpRenderTree/chromium/LayoutTestController.h:
452         (LayoutTestController::setShowDebugLayerTree):
453         * DumpRenderTree/chromium/TestShell.cpp:
454         (TestShell::runFileTest):
455         (TestShell::dump):
456         * DumpRenderTree/chromium/TestShell.h:
457         (TestParams::TestParams):
458
459 2011-03-14  Balazs Kelemen  <kbalazs@webkit.org>
460
461         Reviewed by Adam Roben.
462
463         [Qt][WK2]Unbreak InjectedBundle on Qt
464         https://bugs.webkit.org/show_bug.cgi?id=54109
465
466         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
467         (WTR::InjectedBundlePage::willSendRequestForFrame): Use new WebKit2
468         API's instead of KURL to analyze the URL.
469         * WebKitTestRunner/StringFunctions.h:
470         (WTR::adoptWK): Moved from InjectedBundlePage.cpp to make it available globally
471         in the WebKitTestRunner project.
472         (WTR::toWK): Use adoptWK.
473         (WTR::operator<<): Added helper for printing a WKURL.
474         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Do not link
475         against WebCore.
476
477 2011-03-14  Balazs Kelemen  <kbalazs@webkit.org>
478
479         Reviewed by Kenneth Rohde Christiansen.
480
481         check-webkit-style falsely should not complain about WebKit2 API headers in the Shared directory
482         https://bugs.webkit.org/show_bug.cgi?id=56321
483
484         * Scripts/webkitpy/style/checker.py: Add the patch "Source/WebKit2/Shared/API/c"
485         to the list of exceptions for WebKit2 C API headers.
486
487 2011-03-14  Adam Roben  <aroben@apple.com>
488
489         Show the list of recent leaky builds in reverse chronological order
490
491         Previously they were being shown in a deterministic but surprising order based on
492         lexicographically sorting the build offsets (-1, -10, -2, -3...).
493
494         Fixes <http://webkit.org/b/56342> Leaks Viewer shows recent builds in a strange order
495
496         Reviewed by Darin Adler.
497
498         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
499         (RecentBuildsLoader.prototype.start): Sort the builds by revision before passing them to our
500         callback.
501
502 2011-03-14  Adam Roben  <aroben@apple.com>
503
504         Show a list of up to 10 recent leaky builds when Leaks Viewer loads
505
506         Fixes <http://webkit.org/b/56043> Leaks Viewer should present a list of recent builds to
507         analyze
508
509         Reviewed by David Kilzer and Joe Pecoraro.
510
511         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
512         (#url-prompt): Made this a bit taller to make room for the list of builds.
513
514         (#recent-builds-loading-indicator):
515         (#recent-builds-list):
516         Added styles for the build list and loading indicator.
517
518         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
519         (LeaksViewer.loaded): Pass the URL from the query through decodeURIComponent before loading
520         it. This will unescape it.
521         (LeaksViewer.urlPromptButtonClicked): Moved code from here to _urlChosenFromPrompt.
522         (LeaksViewer._didLoadRecentBuilds): Added. Stores the builds and updates the prompt.
523         (LeaksViewer._displayURLPrompt): Start loading the recent leaky builds.
524         (LeaksViewer._updateURLPrompt): Create a list of the recent leaky builds and add them to the
525         prompt UI.
526         (LeaksViewer._urlChosenFromPrompt): Added. Code came from urlPromptButtonClicked. This is
527         now also used when a recent build is clicked.
528
529         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js: Added.
530         (RecentBuildsLoader): Store the callback.
531         (RecentBuildsLoader.prototype.start): Load the N most recent builds from the specified
532         builder. Find the revision number, leak count, and results URL for each one. Pass the
533         resulting info to our callback.
534
535         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:
536         (range): Added this helper function to return an array containing the integers [0, n).
537
538         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added
539         RecentBuildsLoader.js and added text to the prompt UI to show the recent builds.
540
541 2011-03-14  Mark Rowe  <mrowe@apple.com>
542
543         Reviewed by Adam Roben.
544
545         Fix two memory leaks within LayoutTestController's storage support.
546
547         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
548         (LayoutTestController::originsWithLocalStorage): Don't leak the JSStringRef that is returned
549         by JSStringCreateWithCFString.
550         (LayoutTestController::deleteLocalStorageForOrigin): Don't leak the WebSecurityOrigin that we
551         allocate.
552
553 2011-03-14  Mark Rowe  <mrowe@apple.com>
554
555         Reviewed by Oliver Hunt.
556
557         <http://webkit.org/b/56304> REGRESSION(r80892): 100,000+ leaks seen on the build bot
558
559         * DumpRenderTree/LayoutTestController.cpp:
560         (LayoutTestController::staticFunctions): Remove duplicate entries.
561
562 2011-03-14  Alice Liu  <alice.liu@apple.com>
563
564         Reviewed by Dan Bernstein.
565
566         DumpRenderTree Perl Support fails to build with ARCHS="i386 x86_64"
567
568         * DumpRenderTree/mac/PerlSupport/Makefile:
569         Add whitespace when joining "-arch" with the architectures passed in as arguments.
570
571 2011-03-14  Daniel Bates  <dbates@rim.com>
572
573         https://bugs.webkit.org/show_bug.cgi?id=55438
574         Add double quotes around value of -DCMAKE_WINCE_SDK that I inadvertently did not add
575         when landing changeset 81041 <http://trac.webkit.org/changeset/81041>.
576
577         * Scripts/build-webkit:
578
579 2011-03-14  Daniel Bates  <dbates@rim.com>
580
581         Reviewed by David Kilzer.
582
583         Cleanup: Separate port-specific implementation details from webkitdirs::buildCMakeProject()
584         https://bugs.webkit.org/show_bug.cgi?id=55438
585
586         Separate out the EFL- and WinCE-specific logic from the port-independent logic in
587         webkitdirs::buildCMakeProject(). Also, remove redundant code for generating the
588         CMake arguments for feature defines.
589
590         * Scripts/build-webkit:
591           - Added cMakeArgsFromFeatures() to convert the @features array to CMake arguments.
592           - Modified EFL and WinCE-specific building logic to call buildCMakeProjectOrExit().
593           - Sorted forward declarations.
594           - Initialize $makeArgs with the empty string so as to simplify its use in string operations;
595             Modified call sites as needed.
596         * Scripts/webkitdirs.pm:
597           - Added cleanCMakeGeneratedProject() to clean a CMake build.
598           - Added buildCMakeGeneratedProject() to build using generated build system.
599           - Added buildCMakeProjectOrExit() which is a facade for building a CMake project.
600           - Added generateBuildSystemFromCMakeProject() to generate the build system from
601             a CMake project.
602           - Removed buildCMakeProject(). This functionality is in buildCMakeProjectOrExit().
603
604 2011-03-14  John Knottenbelt  <jknotten@chromium.org>
605
606         Reviewed by Steve Block.
607
608         Detach Geolocation from Frame when Page destroyed.
609         https://bugs.webkit.org/show_bug.cgi?id=52877
610
611         Extend the layout test controller to expose the number of pending
612         geolocation requests, so that we can test that the requests have
613         been cancelled on page close.
614
615         * DumpRenderTree/LayoutTestController.cpp:
616         (numberOfPendingGeolocationPermissionRequestsCallback):
617         (LayoutTestController::staticFunctions):
618         * DumpRenderTree/LayoutTestController.h:
619         * DumpRenderTree/chromium/LayoutTestController.cpp:
620         (LayoutTestController::LayoutTestController):
621         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
622         * DumpRenderTree/chromium/LayoutTestController.h:
623         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
624         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
625         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
626         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
627         * DumpRenderTree/mac/UIDelegate.h:
628         * DumpRenderTree/mac/UIDelegate.mm:
629         (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
630         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
631         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
632         * DumpRenderTree/qt/LayoutTestControllerQt.h:
633         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
634         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
635         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
636         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
637
638
639 2011-03-14  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
640
641         Unreviewed. Modify my email address in committers.py.
642
643         * Scripts/webkitpy/common/config/committers.py:
644
645 2011-03-13  Joe Wild  <joseph.wild@nokia.com>
646
647         Reviewed by Kenneth Rohde Christiansen.
648
649         [Qt] QtLauncher does not load the same set of fonts as the DRT
650         https://bugs.webkit.org/show_bug.cgi?id=34959
651
652         This patch adds the option "-use-test-fonts" to the QtTestBrowser.
653         When this option is used the webkit fonts are loaded the same
654         as they are in DumpRenderTree.  This option can be used on
655         QtTestBrowser and run-launcher.  It can only be used
656         on Linux systems with FcInit and is configured as such.
657
658         * QtTestBrowser/launcherwindow.h:
659         (WindowOptions::WindowOptions):
660         * QtTestBrowser/main.cpp:
661         (initWebKitTestFonts):
662         (launcherMain):
663         (LauncherApplication::handleUserOptions):
664
665 2011-03-12  Dan Bernstein  <mitz@apple.com>
666
667         Reviewed by Mark Rowe.
668
669         <rdar://problem/8995822> Build DumpRenderTree perl support only for the architectures
670         DumpRenderTree is being built for.
671
672         * DumpRenderTree/mac/PerlSupport/Makefile:
673
674 2011-03-12  Dan Bernstein  <mitz@apple.com>
675
676         Suggested by Mark Rowe.
677
678         * DumpRenderTree/mac/Configurations/Base.xcconfig: Leave C++ exceptions enabled
679         as they were before r80915.
680
681 2011-03-12  Anders Carlsson  <andersca@apple.com>
682
683         Reviewed by Sam Weinig.
684
685         Should be able to download a PDF to the Downloads folder
686         https://bugs.webkit.org/show_bug.cgi?id=56256
687
688         * MiniBrowser/mac/BrowserWindowController.m:
689         (-[BrowserWindowController awakeFromNib]):
690         * WebKitTestRunner/TestController.cpp:
691         (WTR::TestController::createOtherPage):
692         (WTR::TestController::initialize):
693         Update for API changes.
694
695 2011-03-11  Anton D'Auria  <adauria@apple.com>
696
697         Reviewed and landed by Brady Eidson.
698
699         https://bugs.webkit.org/show_bug.cgi?id=51878
700         Add WebKit1 API to view and delete local storage
701
702         Added tests that write to LocalStorage, delete one origin, get list of origins with local storage, delete all origins.
703
704         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
705         * DumpRenderTree/LayoutTestController.cpp:
706         (syncLocalStorageCallback):
707         (observeStorageTrackerNotificationsCallback):
708         (deleteAllLocalStorageCallback):
709         (deleteLocalStorageForOriginCallback):
710         (originsWithLocalStorageCallback):
711         (LayoutTestController::staticFunctions):
712         * DumpRenderTree/LayoutTestController.h:
713         * DumpRenderTree/StorageTrackerDelegate.h: Added.
714         * DumpRenderTree/StorageTrackerDelegate.mm: Added.
715         (-[StorageTrackerDelegate init]):
716         (-[StorageTrackerDelegate logNotifications:controller:]):
717         (-[StorageTrackerDelegate originModified:]):
718         (-[StorageTrackerDelegate dealloc]):
719         (-[StorageTrackerDelegate setControllerToNotifyDone:]):
720         * DumpRenderTree/chromium/LayoutTestController.cpp:
721         (LayoutTestController::LayoutTestController):
722         (LayoutTestController::deleteAllLocalStorage):
723         (LayoutTestController::originsWithLocalStorage):
724         (LayoutTestController::deleteLocalStorageForOrigin):
725         (observeStorageTrackerNotifications):
726         (syncLocalStorage):
727         * DumpRenderTree/chromium/LayoutTestController.h:
728         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
729         (LayoutTestController::originsWithLocalStorage):
730         (LayoutTestController::deleteAllLocalStorage):
731         (LayoutTestController::deleteLocalStorageForOrigin):
732         (LayoutTestController::observeStorageTrackerNotifications):
733         (LayoutTestController::syncLocalStorage):
734         * DumpRenderTree/mac/DumpRenderTree.mm:
735         (resetDefaultsToConsistentValues):
736         (allocateGlobalControllers):
737         (releaseGlobalControllers):
738         * DumpRenderTree/mac/DumpRenderTreeMac.h:
739         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
740         (LayoutTestController::syncLocalStorage):
741         (LayoutTestController::observeStorageTrackerNotifications):
742         (LayoutTestController::deleteAllLocalStorage):
743         (LayoutTestController::originsWithLocalStorage):
744         (LayoutTestController::deleteLocalStorageForOrigin):
745         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
746         (LayoutTestController::originsWithLocalStorage):
747         (LayoutTestController::deleteAllLocalStorage):
748         (LayoutTestController::deleteLocalStorageForOrigin):
749         (LayoutTestController::observeStorageTrackerNotifications):
750         (LayoutTestController::syncLocalStorage):
751         * DumpRenderTree/qt/LayoutTestControllerQt.h:
752         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
753         (LayoutTestController::clearAllApplicationCaches):
754         (LayoutTestController::syncLocalStorage):
755         (LayoutTestController::observeStorageTrackerNotifications):
756         (LayoutTestController::clearAllDatabases):
757         (LayoutTestController::deleteAllLocalStorage):
758         (LayoutTestController::originsWithLocalStorage):
759         (LayoutTestController::deleteLocalStorageForOrigin):
760         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
761         (LayoutTestController::syncLocalStorage):
762         (LayoutTestController::observeStorageTrackerNotifications):
763         (LayoutTestController::clearAllDatabases):
764         (LayoutTestController::deleteAllLocalStorage):
765         (LayoutTestController::originsWithLocalStorage):
766         (LayoutTestController::deleteLocalStorageForOrigin):
767
768 2011-03-11  Jessie Berlin  <jberlin@apple.com>
769
770         Reviewed by Adam Roben.
771
772         Crash calling WebContext::clearResourceCaches(InMemoryResourceCachesOnly) before the Web
773         Process has finished launching.
774         https://bugs.webkit.org/show_bug.cgi?id=56208
775
776         * TestWebKitAPI/Tests/WebKit2/SendingMessagesToTheWebProcessBeforeItIsValid.cpp: Added.
777         (TestWebKitAPI::TEST):
778         Test that calling WKContextClearResourceCaches works with both options when called before
779         the Web Process is valid.
780
781         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
782         Add the new test.
783         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
784         Ditto.
785
786 2011-03-11  Adam Roben  <aroben@apple.com>
787
788         Make it possible to view all leaks from a build at once in Leaks Viewer
789
790         You can now give Leaks Viewer the URL of a build results page (e.g.,
791         <http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r80847%20(15493)/>), and it
792         will load all the leaks files from that build.
793
794         Fixes <http://webkit.org/b/56030> Leaks Viewer: Would like to be able to look at all leaks
795         files from a particular build at once, rather than one at a time
796
797         Reviewed by David Kilzer.
798
799         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksLoader.js: Added.
800         (LeaksLoader): Initialize our properties.
801         (LeaksLoader.prototype.start): If the URL ends in .txt, assume it's a single leaks file and
802         load it. Otherwise assume it's a build results page URL and start fetching the leaks files
803         from that page.
804         (LeaksLoader.prototype._loadLeaksFiles): Tell our client how many leaks files we're loading
805         so it can provide feedback. Then load each one and pass it to the client.
806         (LeaksLoader.prototype._loadLeaksFromResultsPage): Load the HTML of the results page, parse
807         it into a DOM, pull out all the links to leaks files, and load each one.
808
809         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParser.js: Added.
810         (LeaksParser): Initialize our worker.
811         (LeaksParser.prototype.addLeaksFile): Tell the worker about the leaks file's contents.
812
813         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js: Added.
814         This code mostly came from Worker.js.
815         (LeaksParserWorker): Initialize our profile.
816         (LeaksParserWorker.prototype.addLeaksFile): Parse the leaks file and incorporate it into our
817         profile.
818         (LeaksParserWorker.prototype._parseLeaks):
819         (LeaksParserWorker.prototype._createNode):
820         (LeaksParserWorker.prototype._incorporateLeaks):
821         Moved these functions here from LeaksViewer. _incorporateLeaks is essentially just a renamed
822         version of createProfile which adds to this.profile instead of making a new profile each
823         time.
824         (onmessage): Parse the file and send back the new profile.
825
826         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
827         (#loading-indicator):
828         (#spinner):
829         (#loading-indicator-label):
830         Tweaked styles to accomodate a longer label.
831
832         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
833         (LeaksViewer.loaded): Set up a loader and parser.
834
835         (LeaksViewer.get filesLeftToParse):
836         (LeaksViewer.set filesLeftToParse):
837         Added these simple accessors.
838
839         (LeaksViewer._didCountLeaksFiles): Callback from LeaksLoader. Stores the count.
840         (LeaksViewer._didLoadLeaksFile): Callback from LeaksLoader. Passes the file contents off to
841         the parser.
842         (LeaksViewer._didParseLeaksFile): Callback from LeaksParser. If all files have been parsed,
843         tell the ProfilerAgent and mark that we're done loading. (Code came from the old
844         _loadLeaksFromURL function).
845         (LeaksViewer._loadLeaksFromURL): Now just calls through to the loader.
846         (LeaksViewer._loadingIndicatorText): Added. Returns the text that should show up in the
847         loading indicator, including the number of files being loaded.
848         (LeaksViewer._loadingStatusChanged): Update the loading indicator's label, too.
849         (LeaksViewer._updateLoadingIndicatorLabel): Added. Just updates the label!
850         (LeaksViewer._updateTitle): Moved code to compute the "Loading" text to
851         _loadingIndicatorText.
852
853         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js: Added.
854         (getResource): Moved here from LeaksViewer.js.
855
856         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Worker.js: Subsumed by
857         LeaksParserWorker.js.
858
859         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added new JS
860         files, added a #loading-indicator-label element, and tweaked the prompt wording.
861
862 2011-03-11  Adam Roben  <aroben@apple.com>
863
864         Don't trigger a build when build.webkit.org's HTML files are modified
865
866         Fixes <http://webkit.org/b/56190> Windows bots shouldn't have built r80848/r80851, but did
867
868         Reviewed by Dan Bernstein.
869
870         * Scripts/webkitpy/common/config/build.py:
871         (_should_file_trigger_build): Added build.webkit.org's public_html directory to the list of
872         directories that shouldn't trigger builds. Re-sorted the list.
873
874         * Scripts/webkitpy/common/config/build_unittest.py:
875         (ShouldBuildTest): Added a test to cover the above change.
876
877 2011-03-11  Adam Roben  <aroben@apple.com>
878
879         Roll out r80848
880
881         It was accidentally committed.
882
883         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
884         (LeaksViewer._loadLeaksFromURL):
885
886 2011-03-11  Tony Chang  <tony@chromium.org>
887
888         Reviewed by Ojan Vafai.
889
890         kill hung lighttpd processes on the chromium win bot
891         https://bugs.webkit.org/show_bug.cgi?id=56152
892
893         Sometimes this process doesn't exit and it holds on to
894         a log file that we can't delete or copy, causing the tests
895         to go red.
896
897         * BuildSlaveSupport/win/kill-old-processes:
898
899 2011-03-11  Ilya Sherman  <isherman@chromium.org>
900
901         Reviewed by Kent Tamura.
902
903         [Chromium] missing HTMLInputElement::setValueForUser() to tests
904         https://bugs.webkit.org/show_bug.cgi?id=55854
905
906         * DumpRenderTree/chromium/LayoutTestController.cpp:
907         (LayoutTestController::LayoutTestController):
908         (LayoutTestController::setValueForUser): Added.
909         * DumpRenderTree/chromium/LayoutTestController.h:
910
911 2011-03-10  Peter Kasting  <pkasting@google.com>
912
913         Reviewed by Dimitri Glazkov.
914
915         Clean up some gross code in TestShellWin.cpp.  No functional change.
916         https://bugs.webkit.org/show_bug.cgi?id=56048
917
918         * DumpRenderTree/chromium/TestShellWin.cpp:
919         (checkLayoutTestSystemDependencies):
920
921 2011-03-10  Keith Kyzivat  <keith.kyzivat@nokia.com>
922
923         Reviewed by Laszlo Gombos.
924
925         [Qt] Buildfix for platforms where X11 is not available (e.g. Symbian)
926
927         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
928         (WTR::activateFonts): Guard X11-specific code with Q_WS_X11.
929
930 2011-03-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
931
932         Reviewed by Kenneth Rohde Christiansen.
933
934         [EFL] Make single backing store the default for EWebLauncher
935         https://bugs.webkit.org/show_bug.cgi?id=55753
936
937         Set single backing store the default for EWebLauncher.
938
939         * EWebLauncher/main.c:
940         (main):
941
942 2011-03-10  Adam Roben  <aroben@apple.com>
943
944         Ignore errors from files being held open when creating a test result archive
945
946         Fixes <http://webkit.org/b/55581> Test results don't get uploaded if test-result-archive
947         fails to delete the results directory
948
949         Reviewed by Mark Rowe.
950
951         * BuildSlaveSupport/test-result-archive:
952         (archiveTestResults): Ignore errno 2 when deleting the results directory, since it can be
953         thrown when a process is holding a file open.
954
955 2011-03-10  Sheriff Bot  <webkit.review.bot@gmail.com>
956
957         Unreviewed, rolling out r80701.
958         http://trac.webkit.org/changeset/80701
959         https://bugs.webkit.org/show_bug.cgi?id=56126
960
961         fast/dom/Geolocation/window-close-crash.html fails on Snow
962         Leopard release builds (Requested by mihaip on #webkit).
963
964         * DumpRenderTree/LayoutTestController.cpp:
965         (LayoutTestController::staticFunctions):
966         * DumpRenderTree/LayoutTestController.h:
967         * DumpRenderTree/chromium/LayoutTestController.cpp:
968         (LayoutTestController::LayoutTestController):
969         * DumpRenderTree/chromium/LayoutTestController.h:
970         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
971         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
972         * DumpRenderTree/mac/UIDelegate.h:
973         * DumpRenderTree/mac/UIDelegate.mm:
974         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
975         * DumpRenderTree/qt/LayoutTestControllerQt.h:
976         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
977         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
978
979 2011-03-10  Philippe Normand  <pnormand@igalia.com>
980
981         Reviewed by Gustavo Noronha Silva.
982
983         [GTK] run-gtk-tests doesn't fail if a test crashes
984         https://bugs.webkit.org/show_bug.cgi?id=56089
985
986         * Scripts/run-gtk-tests: gtester -k exits with a 0 exit status
987         even if a test crashes. So run the tests individually and if a
988         test fails remember its exit code so run-gtk-test fails too, if
989         required.
990
991 2011-01-26  John Knottenbelt  <jknotten@chromium.org>
992
993         Reviewed by Dmitry Titov.
994
995         Detach Geolocation from Frame when Page destroyed.
996         https://bugs.webkit.org/show_bug.cgi?id=52877
997
998         Extend the layout test controller to expose the number of pending
999         geolocation requests, so that we can test that the requests have
1000         been cancelled on page close.
1001
1002         * DumpRenderTree/LayoutTestController.cpp:
1003         (numberOfPendingGeolocationPermissionRequestsCallback):
1004         (LayoutTestController::staticFunctions):
1005         * DumpRenderTree/LayoutTestController.h:
1006         * DumpRenderTree/chromium/LayoutTestController.cpp:
1007         (LayoutTestController::LayoutTestController):
1008         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1009         * DumpRenderTree/chromium/LayoutTestController.h:
1010         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1011         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1012         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1013         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1014         * DumpRenderTree/mac/UIDelegate.h:
1015         * DumpRenderTree/mac/UIDelegate.mm:
1016         (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
1017         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1018         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1019         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1020         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1021         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1022         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1023         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1024
1025
1026 2011-03-09  Adam Roben  <aroben@apple.com>
1027
1028         Hide Leaks Viewer's URL prompt by default
1029
1030         We will show it as needed. I think I left it visible by default by accident after doing some
1031         testing.
1032
1033         Fixes <http://webkit.org/b/56031> Leaks Viewer: URL prompt overlay shouldn't appear when a
1034         URL is passed as a query parameter, but does
1035
1036         Reviewed by Simon Fraser.
1037
1038         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:
1039
1040 2011-03-09  Adam Roben  <aroben@apple.com>
1041
1042         Don't use Element.classList or box-shadow in Leaks Viewer
1043
1044         They aren't supported by Safari 5. Luckily we have substitutes for them!
1045
1046         Fixes <http://webkit.org/b/56035> Leaks viewer doesn't work in Safari 5
1047
1048         Reviewed by Simon Fraser.
1049
1050         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
1051         (#url-prompt): Use -webkit-box-shadow instead of box-shadow.
1052
1053         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
1054         (LeaksViewer.urlPromptButtonClicked):
1055         (LeaksViewer._displayURLPrompt):
1056         (LeaksViewer._setLoadingIndicatorHidden):
1057         Use add/removeStyleClass (from utilities.js) instead of Element.classList.
1058
1059 2011-03-09  Adam Roben  <aroben@apple.com>
1060
1061         Add a link to the Leaks Viewer tool on the build.webkit.org homepage
1062
1063         Rubber-stamped by David Kilzer.
1064
1065         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1066
1067 2011-03-09  Adam Roben  <aroben@apple.com>
1068
1069         Add a Leaks Viewer tool to build.webkit.org
1070
1071         This tool parses leaks from the files generated by the leaks bot and displays them in a
1072         view similar to the Web Inspector's Profiles pane (in fact, it uses the Web Inspector's
1073         code).
1074
1075         The URL of the leaks file can be entered in a prompt when the tools is first shown, or can
1076         be passed to the tool via the "url" query parameter.
1077
1078         Only one leaks file can be viewed at a time for now. Only the number of leaks, as opposed to
1079         the number of leaked bytes, is shown. And this tool has made apparent some bugs in the Web
1080         Inspector's Heavy profile view. But it's still pretty useful as-is.
1081
1082         Fixes <http://webkit.org/b/56028> Would like a Shark-like tool for viewing leaks from leak bots
1083
1084         Reviewed by Darin Adler.
1085
1086         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css: Added.
1087         (#url-prompt-container): This is the dark overlay that is shown behind the URL prompt.
1088         (#url-prompt): This is the prompt itself.
1089
1090         (#loading-indicator):
1091         (#loading-indicator > img):
1092         These show a spinner in the bottom-right when we're loading a leaks file.
1093
1094         (.percent-time-status-bar-item): Hide the Percent button since we never want to show leaks
1095         as percentages.
1096
1097         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js: Added.
1098         (LeaksViewer.loaded): Initialize ourselves and start loading the leaks file (or prompt for a
1099         URL if one wasn't given to us as a query parameter).
1100
1101         (LeaksViewer.get loading):
1102         (LeaksViewer.set loading):
1103         (LeaksViewer.get url):
1104         (LeaksViewer.set url):
1105         Pretty simple accessors.
1106
1107         (LeaksViewer.urlPromptButtonClicked): Start loading the URL from the prompt and hide the
1108         prompt.
1109         (LeaksViewer._displayURLPrompt): Show the prompt and focus the URL input.
1110         (LeaksViewer._loadLeaksFromURL): Start fetching the leaks file. When we've retrieved the
1111         file, hand it off to a Web Worker that will parse it into a fake "profile", then hand off
1112         the profile to the Web Inspector code once it's been created.
1113         (LeaksViewer._loadingStatusChanged): Update our loading indicator and title.
1114         (LeaksViewer._setLoadingIndicatorHidden): Simply hide or show the indicator.
1115         (LeaksViewer._updateTitle): Set our title based on our URL and loading status.
1116         (getResource): Helper function to fetch a resource via XHR and pass it to a callback.
1117
1118         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js: Added.
1119         (WebInspector.UIString): Just a simple implementation since this tool isn't localized.
1120         (ProfilerAgent.getProfile): Store the callback.
1121         (ProfilerAgent.profileReady): Call the callback.
1122         (monkeyPatchInspectorObjects): Fix up WebInspector.ProfileDataGridNode to show the self leak
1123         count and total leak counts as real values, not percentages or milliseconds.
1124
1125         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Worker.js: Added.
1126         (onmessage): Create a profile based on the leaks file and pass it back to our caller.
1127         (parseLeaks): Extract call stacks out of a leaks file.
1128         (createNode): Helper function to create a new empty profile node.
1129         (createProfile): Take the leak stacks and turn them into a fake "profile" for consumption by
1130         WebInspector.ProfileView.
1131
1132         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added.
1133
1134 2011-03-09  Dan Bernstein  <mitz@apple.com>
1135
1136         Reviewed by Adam Roben.
1137
1138         Combine multiple --ignore-tests values
1139         https://bugs.webkit.org/show_bug.cgi?id=56016
1140
1141         * Scripts/old-run-webkit-tests:
1142
1143 2011-03-08  Kenji Imasaki  <imasaki@chromium.org>
1144
1145         Reviewed by David Levin.
1146
1147         Adding myself to the committer file.
1148
1149         * Scripts/webkitpy/common/config/committers.py:
1150
1151 2011-03-08  Jessie Berlin  <jberlin@apple.com>
1152
1153         Rubber-stamped by Adam Roben.
1154
1155         Fix two leaks I introduced into the API tests.
1156
1157         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
1158         (TestWebKitAPI::TEST):
1159
1160 2011-03-08  Jessie Berlin  <jberlin@apple.com>
1161
1162         Reviewed by Anders Carlsson.
1163
1164         Crash in CFNetwork visiting google.com
1165         https://bugs.webkit.org/show_bug.cgi?id=55958
1166
1167         Add a test for not trying to copy a null CFURLResponse.
1168
1169         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp: Added.
1170         (TestWebKitAPI::TEST):
1171         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1172
1173 2011-03-08  Hayato Ito  <hayato@chromium.org>
1174
1175         Reviewed by Ojan Vafai.
1176
1177         [NRWT] Renamed a FailureWithType class to a ComparisonTestFailure class.
1178
1179         FailureWithType is a confusing naming because we have removed test_type/* classes in r79840.
1180
1181         https://bugs.webkit.org/show_bug.cgi?id=55450
1182
1183         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1184
1185 2011-03-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1186
1187         Reviewed by Martin Robinson.
1188
1189         [GTK] Add layoutTestController.setValueForUser() after r80412
1190         https://bugs.webkit.org/show_bug.cgi?id=55862
1191
1192         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1193         (LayoutTestController::setValueForUser): Implement setValueForUser()
1194
1195 2011-03-08  Patrick Gansterer  <paroga@webkit.org>
1196
1197         Reviewed by Adam Barth.
1198
1199         Add script_shell_command to WebKitPort
1200         https://bugs.webkit.org/show_bug.cgi?id=55925
1201
1202         Add a central place where we generate the shell command from the script name.
1203         This function will be used later to detect the correct script interpreter on Win32.
1204
1205         * Scripts/webkitpy/common/config/ports.py:
1206         * Scripts/webkitpy/layout_tests/port/base.py:
1207         * Scripts/webkitpy/tool/steps/abstractstep.py:
1208         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1209
1210 2011-03-07  Ojan Vafai  <ojan@chromium.org>
1211
1212         Reviewed by Adam Barth.
1213
1214         add webkit-patch attach-to-bug for posting to bugzilla from the commandline
1215         https://bugs.webkit.org/show_bug.cgi?id=55749
1216
1217         * Scripts/webkitpy/tool/commands/upload.py:
1218         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1219         * Scripts/webkitpy/tool/steps/__init__.py:
1220         * Scripts/webkitpy/tool/steps/attachtobug.py: Added.
1221         * Scripts/webkitpy/tool/steps/options.py:
1222
1223 2011-03-07  Daniel Cheng  <dcheng@chromium.org>
1224
1225         Reviewed by David Levin.
1226
1227         Add support for DataTransferItems
1228         https://bugs.webkit.org/show_bug.cgi?id=55115
1229
1230         Enable data transfer items in DRT.
1231
1232         * DumpRenderTree/chromium/TestShell.cpp:
1233         (TestShell::TestShell):
1234
1235 2011-03-06  Ojan Vafai  <ojan@chromium.org>
1236
1237         Reviewed by Tony Chang.
1238
1239         [test dashboard] pull treemap files
1240         https://bugs.webkit.org/show_bug.cgi?id=55852
1241
1242         * TestResultServer/handlers/dashboardhandler.py:
1243
1244 2011-03-03  Hayato Ito  <hayato@chromium.org>
1245
1246         Reviewed by Mihai Parparita.
1247
1248         [NRWT] Clear output image file used by DumpRenderTree to make sure the
1249         previous image should not be used in the ChromiumDriver.
1250
1251         Also make sure that output image from the ChromiumDriver should be ''
1252         (empty string) if a test crashes for consistency with the WebKitDriver
1253         implementation.
1254
1255         https://bugs.webkit.org/show_bug.cgi?id=55746
1256
1257         * Scripts/webkitpy/layout_tests/port/chromium.py:
1258
1259 2011-03-07  Zan Dobersek  <zandobersek@gmail.com>
1260
1261         Reviewed by Martin Robinson.
1262
1263         [Gtk] fast/js/navigator-language.html fails locally
1264         https://bugs.webkit.org/show_bug.cgi?id=55880
1265
1266         Add LANG variable to the clean environment when running
1267         old-run-webkit-tests script.
1268
1269         * Scripts/old-run-webkit-tests:
1270
1271 2011-03-07  Tony Chang  <tony@chromium.org>
1272
1273         Reviewed by Mihai Parparita.
1274
1275         [Chromium] Find .checksum files without .pngs and vice-versa
1276         https://bugs.webkit.org/show_bug.cgi?id=55236
1277
1278         * Scripts/find-mismatched-layout-test-results: Added. A script for finding
1279             mismatched results.
1280
1281 2011-03-07  Chris Fleizach  <cfleizach@apple.com>
1282
1283         Reviewed by Beth Dakin.
1284
1285         AX: WK1 needs to use the ScrollView attachment for AXScrollArea, WK2 should not use this element.
1286         https://bugs.webkit.org/show_bug.cgi?id=55706
1287
1288         The rootElement in DRT should point to the scroll view. In WK1, that will be the parent of the rootObject.
1289
1290         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1291         (AccessibilityController::focusedElement):
1292            Remove FIXME comment about caching the focusedElement. In fact, we shouldn't cache this 
1293            because it could change at any time.
1294         (AccessibilityController::rootElement):
1295
1296 2011-03-07  Sam Weinig  <sam@webkit.org>
1297
1298         Reviewed by Anders Carlsson.
1299
1300         Add unableToImplementPolicy callback for WebKit2 policy client
1301         <rdar://problem/9071902>
1302         https://bugs.webkit.org/show_bug.cgi?id=55884
1303
1304         * MiniBrowser/mac/BrowserWindowController.m:
1305         (-[BrowserWindowController awakeFromNib]):
1306         Update policy client initialization struct for new member.
1307
1308 2011-03-07  Sam Weinig  <sam@webkit.org>
1309
1310         Reviewed by Anders Carlsson.
1311
1312         Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
1313         https://bugs.webkit.org/show_bug.cgi?id=55827
1314
1315         * MiniBrowser/mac/BrowserWindowController.m:
1316         (decidePolicyForResponse):
1317         (-[BrowserWindowController awakeFromNib]):
1318         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1319         (TestWebKitAPI::decidePolicyForResponse):
1320         (TestWebKitAPI::TEST):
1321         Update tools for new name.
1322
1323 2011-03-06  Daniel Bates  <dbates@rim.com>
1324
1325         Reviewed by Eric Seidel and David Kilzer.
1326
1327         Fix misspelled word in build-webkit's checkForJavaSDK() and sort forward declarations
1328         https://bugs.webkit.org/show_bug.cgi?id=55503
1329
1330         Fix misspelled word "Dowloads" [sic] in the message printed to standard output
1331         in checkForJavaSDK().
1332
1333         Also, remove extraneous space in function prototype for unlinkZeroFiles.
1334
1335         * Scripts/build-webkit:
1336
1337 2011-03-05  Brian Weinstein  <bweinstein@apple.com>
1338
1339         Reviewed by Sam Weinig.
1340
1341         Fix Web Process crashes caused by https://bugs.webkit.org/show_bug.cgi?id=53919.
1342
1343         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1344         (WTR::InjectedBundlePage::willSendRequestForFrame): Retain the WKURLRequestRef returned
1345             by willSendRequestForFrame. The API expects a retained reference to the URL request.
1346
1347 2011-03-05  Ilya Sherman  <isherman@chromium.org>
1348
1349         Reviewed by Darin Adler.
1350
1351         HTMLInputElement::setValue() should schedule change event when the element is focused
1352         In service of https://code.google.com/p/chromium/issues/detail?id=42716
1353         https://bugs.webkit.org/show_bug.cgi?id=53160
1354
1355         * DumpRenderTree/LayoutTestController.cpp:
1356         (setValueForUserCallback):
1357         (LayoutTestController::staticFunctions):
1358         * DumpRenderTree/LayoutTestController.h:
1359         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1360         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
1361         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1362         (LayoutTestController::setValueForUser): Expose HTMLInputElement::setValueForUser() to tests
1363         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1364         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
1365         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1366         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
1367         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1368         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
1369
1370 2011-03-04  Mark Rowe  <mrowe@apple.com>
1371
1372         Reviewed by Alexey Proskuryakov.
1373
1374         <rdar://problem/9055252> DumpRenderTree is crashing with GuardMalloc
1375
1376         GuardMalloc does not expect the memory containing its malloc_zone_t to ever be read-only.
1377         
1378         * DumpRenderTree/mac/CheckedMalloc.cpp:
1379         (protectionOfRegion): Retrieve the protection flags for the VM region containing the given address.
1380         (makeLargeMallocFailSilently): Save the initial protection flags, temporarily make the region writeable,
1381         and then restore the initial protection flags when we're done.
1382
1383 2011-03-04  Evan Martin  <evan@chromium.org>
1384
1385         Reviewed by Tony Chang.
1386
1387         [gdb] pretty-print KURL in gdb
1388         https://bugs.webkit.org/show_bug.cgi?id=55788
1389
1390         * gdb/webkit.py: extend the pretty-printers to print WTF::CString
1391         and KURLGooglePrivate.  As always, "p/r" can be used to sidestep
1392         pretty-printing.
1393
1394 2011-03-03  Timothy Hatcher  <timothy@apple.com>
1395
1396         Update the tests that use WKPageRunJavaScriptInMainFrame use the WKSerializedScriptValueRef.
1397
1398         Reviewed by Darin Adler.
1399
1400         * TestWebKitAPI/JavaScriptTest.cpp:
1401         (TestWebKitAPI::javaScriptCallback):
1402         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
1403         (TestWebKitAPI::didRunJavaScript):
1404         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1405         (TestWebKitAPI::nullJavaScriptCallback):
1406         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
1407         (TestWebKitAPI::didRunJavaScript):
1408
1409 2011-03-03  Timothy Hatcher  <timothy@apple.com>
1410
1411         Make run-api-tests show failed if a test fails.
1412
1413         https://webkit.org/b/55725
1414
1415         Reviewed by Sam Weinig.
1416
1417         * Scripts/run-api-tests:
1418         (runTest): Remove "my" from the nested $result assignment so the
1419         check outside the condition sees the real result.
1420
1421 2011-03-02  MORITA Hajime  <morrita@google.com>
1422
1423         Reviewed by Kent Tamura.
1424
1425         [Chromium][DRT] WebTask should use webkit_support::TaskAdaptor
1426         https://bugs.webkit.org/show_bug.cgi?id=55434
1427
1428         Changed WebTask to be a subclass of webkit_support::TaskAdaptor
1429         and passed the object webkit_support::PostDelayedTask directly.
1430
1431         Note that the change keeps postTask() as is because it has a
1432         semantics taht webkit_support::PostDelayedTask() has; It jumps to
1433         the main thread.
1434
1435         * DumpRenderTree/chromium/Task.cpp:
1436         (postDelayedTask):
1437         * DumpRenderTree/chromium/Task.h:
1438         (WebTask::Run):
1439
1440 2011-03-03  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
1441
1442         Reviewed by Kenneth Rohde Christiansen.
1443
1444         [QT] Implement mock client-based geolocation for layout testing
1445         https://bugs.webkit.org/show_bug.cgi?id=54334
1446
1447         Implement testing for Client-Based geolocation for QtWebkit.
1448
1449         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1450         (WebCore::DumpRenderTree::DumpRenderTree):
1451         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1452         (LayoutTestController::reset):
1453         (LayoutTestController::setGeolocationPermission):
1454         (LayoutTestController::setMockGeolocationError):
1455         (LayoutTestController::setMockGeolocationPosition):
1456
1457 2011-03-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1458
1459         Unreviewed, rolling out r80237.
1460         http://trac.webkit.org/changeset/80237
1461         https://bugs.webkit.org/show_bug.cgi?id=55714
1462
1463         Windows bots aren't ready to be core (Requested by aroben on
1464         #webkit).
1465
1466         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1467         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1468
1469 2011-03-03  Mihai Parparita  <mihaip@chromium.org>
1470
1471         Reviewed by Tony Chang.
1472
1473         NRWT: AttributeError: TestRunner2 instance has no attribute '_cancel_workers'
1474         https://bugs.webkit.org/show_bug.cgi?id=55694
1475         
1476         Fixes for interruptions in NRWT:
1477         - Make TestRunInterruptedException be pickleable correctly (the base
1478           Exception class defines a __reduce__ that does not include the reason)
1479         - Fix ordering of returned arguments from TestRunner2._run_tests
1480           (interrupted and keyboard_interrupted were reversed)
1481         - Fix cancel_workers callsites (was using old name).
1482         - In handle_exception re-raise actual exception instance that was thrown
1483
1484         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1485         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
1486         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
1487         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1488
1489 2011-03-03  Qi Zhang  <qi.2.zhang@nokia.com>
1490
1491         Unreviewed.
1492
1493         Adding myself as a committer.
1494
1495         * Scripts/webkitpy/common/config/committers.py:
1496
1497 2011-03-03  Tony Gentilcore  <tonyg@chromium.org>
1498
1499         Reviewed by Mihai Parparita.
1500
1501         Teach sheriffbot to answer whois commands
1502         https://bugs.webkit.org/show_bug.cgi?id=55687
1503
1504         * Scripts/webkitpy/tool/bot/irc_command.py:
1505         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1506         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1507
1508 2011-03-03  Victoria Kirst  <vrk@google.com>
1509
1510         Reviewed by Eric Carlson.
1511
1512         Enable media tests in chromium-gpu/test_expectations
1513         https://bugs.webkit.org/show_bug.cgi?id=53608
1514
1515         Add media folder to the list of GPU test paths.
1516
1517         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1518
1519 2011-03-03  Adam Roben  <aroben@apple.com>
1520
1521         Work around a bug in KURL's parsing of Windows-style absolute file: URLs
1522
1523         Fixes <http://webkit.org/b/55674> Many tests fail in WebKit2 mode on Windows due to
1524         incorrect parsing of absolute Windows-style file: URLs
1525
1526         Reviewed by Tim Hatcher.
1527
1528         * WebKitTestRunner/TestInvocation.cpp:
1529         (WTR::createWKURL): Add a "localhost" host to file: URLs we create to work around
1530         <http://webkit.org/b/55683>.
1531
1532 2011-03-03  Tony Chang  <tony@chromium.org>
1533
1534         Reviewed by Dimitri Glazkov.
1535
1536         [chromium] Run kill-old-processes on the chromium-win bot too
1537         https://bugs.webkit.org/show_bug.cgi?id=55630
1538
1539         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1540         * BuildSlaveSupport/win/kill-old-processes: Add wdiff.exe to the kill list.
1541
1542 2011-03-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1543
1544         Reviewed by Martin Robinson.
1545
1546         [GTK] DRT needs implementation of EventSender.scheduleAsynchronousClick
1547         https://bugs.webkit.org/show_bug.cgi?id=53960
1548
1549         * DumpRenderTree/gtk/EventSender.cpp:
1550         (sendClick):
1551         (scheduleAsynchronousClickCallback):
1552
1553 2011-03-03  Adam Roben  <aroben@apple.com>
1554
1555         Look for Windows-style paths when checking whether a test is an Inspector test
1556
1557         WTR part of <http://webkit.org/b/55672> <rdar://problem/9080867> All inspector tests time
1558         out or crash on Windows 7 Release (WebKit2 Tests)
1559
1560         Reviewed by Darin Adler.
1561
1562         * WebKitTestRunner/TestInvocation.cpp:
1563         (WTR::shouldOpenWebInspector): Also look for backslashes, since that's what we'll get on
1564         Windows.
1565
1566 2011-03-03  Adam Roben  <aroben@apple.com>
1567
1568         Make Windows 7 Release (Tests) a core builder
1569
1570         We can probably make Windows XP Debug (Tests) a core builder, too, but we should probably
1571         give it a few more days of greenness first.
1572
1573         Fixes <http://webkit.org/b/55665> Windows 7 Release (Tests) should be a core builder
1574
1575         Reviewed by Andreas Kling.
1576
1577         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1578         (BuildBot): Added a regexp to match Windows 7 Release (Tests).
1579
1580         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1581         (BuildBotTest): Updated the list of builders to match the current list on build.webkit.org.
1582         Updated the core regexps to match the buildbot module. Updated the expected results to match
1583         the current set of core builders.
1584
1585 2011-03-03  Benjamin Poulain  <benjamin.poulain@nokia.com>
1586
1587         Reviewed by Andreas Kling.
1588
1589         Adding myself as a reviewer.
1590
1591         * Scripts/webkitpy/common/config/committers.py:
1592
1593 2011-03-03  Lukasz Slachciak  <l.slachciak@samsung.com>
1594
1595         Reviewed by Xan Lopez.
1596
1597         [GTK] Extended application cache database API and added unit tests file.
1598         https://bugs.webkit.org/show_bug.cgi?id=55335
1599
1600         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: removed external declaration
1601         of webkit_application_cache_set_maximum_size due to API exposal.
1602
1603 2011-03-02  Ojan Vafai  <ojan@chromium.org>
1604
1605         Reviewed by Adam Barth.
1606
1607         make webkit-patch upload work for security bugs
1608         https://bugs.webkit.org/show_bug.cgi?id=55655
1609
1610         The problem is that we shell out to prepare-ChangeLog,
1611         which does not authenticate with bugzilla. All it needs from
1612         bugzilla is the bug title though. We just pass it through from
1613         webkit-patch instead.
1614
1615         * Scripts/prepare-ChangeLog:
1616         * Scripts/webkitpy/common/net/bugzilla/bug.py:
1617         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1618
1619 2011-03-01  Ojan Vafai  <ojan@chromium.org>
1620
1621         Reviewed by Tony Chang.
1622
1623         [test-dashboard] make gtest JSON match layout-tests JSON
1624         https://bugs.webkit.org/show_bug.cgi?id=55556
1625
1626         http://trac.webkit.org/changeset/80090 stopped converting time_ms to t.
1627         Make this code match.
1628
1629         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1630
1631 2011-03-02  Dirk Pranke  <dpranke@chromium.org>
1632
1633         Reviewed by Tony Chang.
1634
1635         NRWT - implement Linux Hardy 64-bit port support. This involves
1636         adding support for non-'x86' architectures and updating the
1637         "deduplicate_tests" script to correctly understand that
1638         port.name() is not always equal to basename(port.baseline_path()).
1639
1640         This change introduces two new port names: 'chromium-linux-x86'
1641         and 'chromium-linux-x86_64'. Using the prior 'chromium-linux'
1642         flag will cause the code to determine which one to use at
1643         runtime, just like we currently do with 'chromium-win'.
1644
1645         https://bugs.webkit.org/show_bug.cgi?id=55535
1646
1647         * Scripts/webkitpy/common/system/executive_mock.py:
1648           Handle 'return_stderr' keyword arg to run_command()
1649         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
1650         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1651         * Scripts/webkitpy/layout_tests/port/base.py:
1652         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1653         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
1654         * Scripts/webkitpy/layout_tests/port/factory.py:
1655         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1656
1657 2011-03-02  Kevin Ollivier  <kevino@theolliviers.com>
1658
1659         [wx] Build fix, make sure we put the wxWebKit dylib in the right directory and
1660         update symlinks accordingly.
1661
1662         * wx/packaging/build-mac-installer.py:
1663
1664 2011-03-02  Sheriff Bot  <webkit.review.bot@gmail.com>
1665
1666         Unreviewed, rolling out r80139.
1667         http://trac.webkit.org/changeset/80139
1668         https://bugs.webkit.org/show_bug.cgi?id=55620
1669
1670         failing and crashing tests on Snow Leopard bot (Requested by
1671         mihaip1 on #webkit).
1672
1673         * DumpRenderTree/LayoutTestController.cpp:
1674         (LayoutTestController::staticFunctions):
1675         * DumpRenderTree/LayoutTestController.h:
1676         * DumpRenderTree/chromium/LayoutTestController.cpp:
1677         (LayoutTestController::LayoutTestController):
1678         * DumpRenderTree/chromium/LayoutTestController.h:
1679         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1680         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1681         * DumpRenderTree/mac/UIDelegate.h:
1682         * DumpRenderTree/mac/UIDelegate.mm:
1683         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1684         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1685         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1686         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1687
1688 2011-03-02  Adam Roben  <aroben@apple.com>
1689
1690         Wait for force a paint in WebKitTestRunner until we're actually ready to dump the output
1691
1692         This matches DumpRenderTree on Windows.
1693
1694         Fixes <http://webkit.org/b/55469> <rdar://problem/9068539> REGRESSION (r79863): Lots of
1695         dom/html/level2/html/HTMLFrameElement*.html tests crashing in FrameView::paintOverhangAreas
1696         in WebKit2
1697
1698         Reviewed by Beth Dakin.
1699
1700         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1701         (WTR::InjectedBundlePage::dump): Moved code to force a paint here...
1702         (WTR::InjectedBundlePage::didFinishLoadForFrame): ...from here.
1703
1704 2011-03-02  Daniel Cheng  <dcheng@chromium.org>
1705
1706         Reviewed by David Levin.
1707
1708         Add feature define for data transfer items
1709         https://bugs.webkit.org/show_bug.cgi?id=55510
1710
1711         * Scripts/build-webkit:
1712
1713 2011-03-02  Adam Roben  <aroben@apple.com>
1714
1715         Look in the new-to-SnowLeopard location for crash logs on SnowLeopard and newer
1716
1717         ReportCrash saves logs to ~/Library/Logs/CrashReporter on Leopard, but to
1718         ~/Library/Logs/DiagnosticReports on SnowLeopard. old-run-webkit-tests was only looking in
1719         the former location, but was getting lucky on some SnowLeopard machines because symlinks
1720         were being created there pointing into DiagnosticReports. For machines without these
1721         symlinks, crash logs were not getting captured.
1722
1723         Fixes <http://webkit.org/b/55607> old-run-webkit-tests doesn't capture crash logs on some
1724         SnowLeopard machines
1725
1726         Reviewed by Eric Seidel.
1727
1728         * Scripts/old-run-webkit-tests:
1729         (captureSavedCrashLog): Look in ~/Library/Logs/DiagnosticReports on SnowLeopard and newer.
1730
1731 2011-03-02  Adam Roben  <aroben@apple.com>
1732
1733         Don't try to capture crash logs on platforms that haven't implemented that feature
1734
1735         Fixes <http://webkit.org/b/55504> Use of uninitialized value in numeric lt (<) at
1736         Tools/Scripts/old-run-webkit-tests line 1778 seen on Qt bots after a crash
1737
1738         Reviewed by Joseph Pecoraro.
1739
1740         * Scripts/old-run-webkit-tests:
1741         (captureSavedCrashLog): Bail if we don't have a crash log glob.
1742         (findNewestFileMatchingGlob): Fix a buggy test for when no paths match the glob. This isn't
1743         strictly required to fix bug 55504, but seems worthwhile.
1744
1745 2011-01-26  John Knottenbelt  <jknotten@chromium.org>
1746
1747         Reviewed by Dmitry Titov.
1748
1749         Detach Geolocation from Frame when Page destroyed.
1750         https://bugs.webkit.org/show_bug.cgi?id=52877
1751
1752         Extend the layout test controller to expose the number of pending
1753         geolocation requests, so that we can test that the requests have
1754         been cancelled on page close.
1755
1756         * DumpRenderTree/LayoutTestController.cpp:
1757         (numberOfPendingGeolocationPermissionRequestsCallback):
1758         (LayoutTestController::staticFunctions):
1759         * DumpRenderTree/LayoutTestController.h:
1760         * DumpRenderTree/chromium/LayoutTestController.cpp:
1761         (LayoutTestController::LayoutTestController):
1762         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1763         * DumpRenderTree/chromium/LayoutTestController.h:
1764         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1765         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1766         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1767         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1768         * DumpRenderTree/mac/UIDelegate.h:
1769         * DumpRenderTree/mac/UIDelegate.mm:
1770         (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
1771         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1772         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1773         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1774         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1775         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1776         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1777         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1778
1779
1780 2011-03-01  Kent Tamura  <tkent@chromium.org>
1781
1782         Reviewed by Dimitri Glazkov.
1783
1784         Assertion fails when a form validation bubble appears
1785         https://bugs.webkit.org/show_bug.cgi?id=55550
1786
1787         Test: fast/forms/interactive-validation-attach-assertion.html
1788
1789         * DumpRenderTree/chromium/WebPreferences.cpp:
1790         (WebPreferences::applyTo): Enable the interactive validation feature by
1791           default. This matches to Chromium browser.
1792
1793 2011-03-01  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1794
1795         Reviewed by Kent Tamura.
1796
1797         Remove efl port style exception of Webcore/JavaScriptCore
1798         https://bugs.webkit.org/show_bug.cgi?id=55549
1799
1800         WebCore and JavaScriptCore need to adhere WebKit coding style.
1801
1802         * Scripts/webkitpy/style/checker.py:
1803
1804 2011-03-01  Tony Chang  <tony@chromium.org>
1805
1806         Reviewed by Ojan Vafai.
1807
1808         [chromium] clean up temp files on chromium-mac builder too
1809         https://bugs.webkit.org/show_bug.cgi?id=55525
1810
1811         * BuildSlaveSupport/chromium/remove-crash-logs:
1812
1813 2011-02-28  Ojan Vafai  <ojan@chromium.org>
1814
1815         Reviewed by Tony Chang.
1816
1817         wrap json in a function call to afford cross-domain loading
1818         https://bugs.webkit.org/show_bug.cgi?id=55353
1819
1820         Also delete the code that compacts the JSON. It turns out this
1821         breaks the rebaseline tool and is probably a premature optimization anyways.
1822
1823         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1824         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1825         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1826         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1827
1828 2011-03-01  Sheriff Bot  <webkit.review.bot@gmail.com>
1829
1830         Unreviewed, rolling out r80079.
1831         http://trac.webkit.org/changeset/80079
1832         https://bugs.webkit.org/show_bug.cgi?id=55547
1833
1834         "Broke the Win debug build?" (Requested by dcheng on #webkit).
1835
1836         * Scripts/build-webkit:
1837
1838 2011-03-01  Mark Rowe  <mrowe@apple.com>
1839
1840         Reviewed by Sam Weinig.
1841
1842         Update verification scripts to handle WebKit2.
1843
1844         * Scripts/check-for-global-initializers: Skip object files that use RefCountedLeakChecker.
1845         * Scripts/check-for-inappropriate-files-in-framework: Add some inappropriate file types for
1846         WebKit2.
1847
1848 2011-03-01  Daniel Cheng  <dcheng@chromium.org>
1849
1850         Reviewed by David Levin.
1851
1852         Add feature define for data transfer items
1853         https://bugs.webkit.org/show_bug.cgi?id=55510
1854
1855         * Scripts/build-webkit:
1856
1857 2011-02-23  Joseph Pecoraro  <joepeck@webkit.org>
1858
1859         Reviewed by Timothy Hatcher.
1860
1861         All Console Messages should be passed to ChromeClients.
1862         https://bugs.webkit.org/show_bug.cgi?id=54926
1863
1864         Update DumpRenderTree's UIDelegate to use the new console message delegate.
1865
1866         * DumpRenderTree/mac/UIDelegate.mm:
1867         (-[UIDelegate webView:addMessageToConsole:withSource:]):
1868
1869 2011-03-01  Dirk Pranke  <dpranke@chromium.org>
1870
1871         Reviewed by Adam Barth.
1872
1873         Tragically, we stopped running the python unit tests
1874         on Chromium Win just as I was getting them to be green.
1875         This patch turns them back on.
1876
1877         https://bugs.webkit.org/show_bug.cgi?id=55521
1878
1879         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1880
1881 2011-03-01  Dirk Pranke  <dpranke@chromium.org>
1882
1883         Reviewed by Adam Roben.
1884
1885         Disable
1886         webkitpy.common.system.executive_unittest.ExecutiveTest.\
1887            test_kill_all fails on win until it can be properly triaged.
1888
1889         https://bugs.webkit.org/show_bug.cgi?id=54790
1890
1891         * Scripts/webkitpy/common/system/executive_unittest.py:
1892
1893     2011-03-01  Helder Correia  <helder@sencha.com>
1894
1895             Unreviewed. Add myself to committers.py.
1896
1897             * Scripts/webkitpy/common/config/committers.py:
1898
1899 2011-03-01  Adam Roben  <aroben@apple.com>
1900
1901         Give up if a crash log for the web process is taking too long to be saved on Windows
1902
1903         This should keep the bots from getting stuck while waiting for a crash log, if writing a
1904         crash log ever hangs or the UI process for some reason doesn't notice it's finished.
1905
1906         Fixes <http://webkit.org/b/55499> WebKitTestRunner can hang forever waiting for a crash log
1907         to be saved for the web process
1908
1909         Reviewed by Steve Falkenburg.
1910
1911         * WebKitTestRunner/win/TestControllerWin.cpp:
1912         (WTR::runRunLoopUntil): Moved code to run the run loop here here from platformRunUntil.
1913         Generalized the code slightly to handle the optional object to wait on.
1914         (WTR::TestController::platformRunUntil): Use the new runRunLoopUntil function, and also use
1915         it (with a timeout) when waiting for a crash log for the web process to be saved. This will
1916         prevent us from waiting forever.
1917
1918 2011-03-01  Adam Roben  <aroben@apple.com>
1919
1920         Give WebKitLauncherWin's PDB file a name different from WebKit's
1921
1922         WebKitLauncherWin (which builds WebKit.exe) and WebKit (which builds WebKit.dll) were
1923         fighting over the same PDB file, meaning that one of them was going to lose and not have
1924         symbols. WebKitLauncherWin's PDB file is now named WebKitLauncherWin.pdb.
1925
1926         Fixes <http://webkit.org/b/55495> Crashes in WebKit.dll have bad backtraces for some test
1927         runs (due to missing symbols)
1928
1929         Reviewed by David Kilzer.
1930
1931         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Use the project name,
1932         "WebKitLauncherWin", instead of the target name, "WebKit", when naming the PDB file.
1933
1934 2011-03-01  Adam Roben  <aroben@apple.com>
1935
1936         Count web process crashes toward the --exit-after-n-crashes-or-timeouts limit
1937
1938         Fixes <http://webkit.org/b/55492> Web process crashes aren't counted toward the
1939         --exit-after-n-crashes-or-timeouts limit
1940
1941         Reviewed by David Kilzer.
1942
1943         * Scripts/old-run-webkit-tests:
1944         (stopRunningTestsEarlyIfNeeded): Include web process crashes in the computation, and print
1945         the number of tests that caused the web process to crash when exiting early.
1946
1947 2011-03-01  Adam Roben  <aroben@apple.com>
1948
1949         Save a crash log when the web process crashes
1950
1951         On Windows, WebKitTestRunner now detects when the web process is crashing and waits to exit
1952         until it has finished crashing, which guarantees that the crash log will have had time to be
1953         saved, too. On Mac, we always wait until ReportCrash has exited before capturing the crash
1954         log, so all we have to do is choose the right crash log out of the CrashReporter directory.
1955
1956         Fixes <http://webkit.org/b/44121> <rdar://problem/8320759> When the web process crashes and
1957         a crash log is being saved, WebKitTestRunner thinks the web process has become unresponsive
1958
1959         Reviewed by Sam Weinig.
1960
1961         * Scripts/old-run-webkit-tests:
1962         (testCrashedOrTimedOut): Don't kill WebKitTestRunner when the web process crashes. It will
1963         kill itself. On Windows, this will cause us to wait until the crash log has been saved. On
1964         Mac, it should have no effect. Capture saved crash logs for web process crashes, too.
1965         (captureSavedCrashLog): Added $webProcessCrashed argument. On Mac, look for
1966         WebProces_*.crash files when the web process crashes.
1967
1968         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1969         (WTR::InjectedBundle::initialize): Added an initializationUserData argument. Updated for
1970         initializePlatformDefaults -> platformInitialize rename. Pass the initializationUserData
1971         along to platformInitialize.
1972
1973         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: See above.
1974
1975         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
1976         (WKBundleInitialize): Pass along the initializationUserData to the InjectedBundle.
1977
1978         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1979         (WTR::InjectedBundle::platformInitialize):
1980         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
1981         (WTR::InjectedBundle::platformInitialize):
1982         Updated function signature.
1983
1984         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp:
1985         (WTR::exceptionFilter): Added. Tells the UI process we're crashing by signaling the
1986         webProcessCrashingEvent, then lets the crash continue as normal.
1987
1988         (WTR::InjectedBundle::platformInitialize): Hook up exceptionFilter. Retrieve the name of the
1989         event we should use to tell the UI process we're crashing from the initializationUserData,
1990         and get a handle to that event.
1991
1992         * WebKitTestRunner/TestController.cpp:
1993         (WTR::TestController::TestController): Initialize new members.
1994         (WTR::TestController::processDidCrash): Removed unnecessary WKPageRef argument. Changed to
1995         only print the "#CRASHED - WebProcess" message once, since this can be called more than once
1996         when a crash log is being saved on Windows. Exit right away if specified. (This is the
1997         default.)
1998
1999         * WebKitTestRunner/TestController.h: Added new members.
2000
2001         * WebKitTestRunner/win/TestControllerWin.cpp:
2002         (WTR::TestController::platformInitialize): Set up the event the web process will use to tell
2003         us it's crashing.
2004         (WTR::TestController::platformRunUntil): Pass MWMO_INPUTAVAILABLE to
2005         ::MsgWaitForMultipleObjectsEx so we'll process messages that have already been seen by
2006         ::PeekMessage. (This is unrelated to the bug fix.) Notice when the webProcessCrashingEvent
2007         has been signaled. When this happens, print the "#CRASHED - WebProcess" message right away
2008         so the test harness will know the web process has crashed and not try to kill us, then wait
2009         for the web process to finish crashing so a crash log will have time to be saved.
2010         (WTR::toWK): Simple hepler function.
2011         (WTR::TestController::platformInitializeContext): Pass along the name of the event the web
2012         process should use to tell us it is crashing in the context's initialization user data.
2013
2014 2011-03-01  Dimitri Glazkov  <dglazkov@chromium.org>
2015
2016         Reviewed by Tony Gentilcore.
2017
2018         Move the checks to exclude Python/Perl tests for Chromium Win build to the right place.
2019         https://bugs.webkit.org/show_bug.cgi?id=55476
2020
2021         Chromium Win uses BuildAndTestFactory, not TestFactory.
2022
2023         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Moved to the right place.
2024
2025 2011-03-01  Adam Roben  <aroben@apple.com>
2026
2027         Test that the WebKit2 responsiveness timer doesn't fire too early
2028
2029         Test for <http://webkit.org/b/55417> <rdar://problem/9065287> RunLoop::Timer fires 1000x too
2030         early on Windows
2031
2032         Reviewed by Anders Carlsson.
2033
2034         * TestWebKitAPI/PlatformUtilities.h: Added sleep().
2035
2036         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp: Added.
2037         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2038         (TestWebKitAPI::didFinishLoadForFrame):
2039         (TestWebKitAPI::processDidBecomeUnresponsive):
2040         (TestWebKitAPI::setInjectedBundleClient):
2041         (TestWebKitAPI::setPageLoaderClient):
2042         Simple helper functions.
2043
2044         (TestWebKitAPI::TEST): Load an HTML file to make sure the web process is initialized. Then
2045         tell the web process to pause and press the spacebar key. The spacebar keypress should cause
2046         the responsiveness timer to start, but the web process should unpause before it has a chance
2047         to fire. Run until the web process has unpaused, and assert that the timer didn't fire.
2048
2049         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp: Added.
2050         (TestWebKitAPI::ResponsivenessTimerDoesntFireEarlyTest::ResponsivenessTimerDoesntFireEarlyTest):
2051         Call up to the base class.
2052         (TestWebKitAPI::ResponsivenessTimerDoesntFireEarlyTest::didReceiveMessage): When asked to
2053         pause, sleep for 0.5 seconds, then send back a message saying we paused.
2054
2055         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2056         (TestWebKitAPI::Util::sleep): Added. Calls through to usleep.
2057         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2058         (TestWebKitAPI::Util::sleep): Added. Calls through to ::Sleep.
2059
2060         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2061         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2062         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
2063         Added new files.
2064
2065 2011-03-01  Andras Becsi  <abecsi@webkit.org>
2066
2067         Reviewed by Csaba Osztrogonác.
2068
2069         [Qt] Clean up the project files and move common options to WebKit.pri.
2070
2071         * WebKitTestRunner/qt/WebKitTestRunner.pro: Deduplicate.
2072
2073
2074 2011-03-01  Adam Roben  <aroben@apple.com>
2075
2076         Skip another multiprocessing test on Windows
2077
2078         It is sometimes failing (and may be leaving child Python processes around).
2079         <http://webkit.org/b/55087> tracks the failure.
2080
2081         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
2082         (FuncitonTests.test_get__processes): Skip this test on Windows.
2083
2084 2011-03-01  Ilya Tikhonovsky  <loislo@chromium.org>
2085
2086         Reviewed by Pavel Feldman.
2087
2088         Web Inspector: reduce inspector tests flakiness.
2089         https://bugs.webkit.org/show_bug.cgi?id=55401
2090
2091         * DumpRenderTree/chromium/TestShell.cpp:
2092         (TestShell::runFileTest):
2093         * DumpRenderTree/chromium/WebPreferences.cpp:
2094         (WebPreferences::reset):
2095
2096 2011-02-28  Mihai Parparita  <mihaip@chromium.org>
2097
2098         Reviewed by James Robinson.
2099
2100         NRWT should still upload results when it exits early due to too many failures
2101         https://bugs.webkit.org/show_bug.cgi?id=55432
2102         
2103         Only keyboard interrupts should prevent results from being uploaded.
2104
2105         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2106         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2107
2108 2011-02-28  Alice Liu  <alice.liu@apple.com>
2109
2110         Reviewed by Adam Roben and Gavin Barraclough.
2111
2112         Test for https://bugs.webkit.org/show_bug.cgi?id=54898
2113         InjectedBundleNodeHandle dies too early in WKBundleHitTestResultGetNodeHandle.
2114
2115         * TestWebKitAPI/InjectedBundleController.h:
2116         (TestWebKitAPI::InjectedBundleController::bundle):
2117         * TestWebKitAPI/PlatformWebView.h:
2118         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp: Added.
2119         (TestWebKitAPI::didFinishLoadForFrame):
2120         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2121         (TestWebKitAPI::setPageLoaderClient):
2122         (TestWebKitAPI::TEST):
2123         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp: Added.
2124         (TestWebKitAPI::HitTestResultNodeHandleTest::HitTestResultNodeHandleTest):
2125         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
2126         (TestWebKitAPI::HitTestResultNodeHandleTest::didCreatePage):
2127         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2128         (TestWebKitAPI::PlatformWebView::simulateRightClick):
2129         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
2130         (TestWebKitAPI::PlatformWebView::simulateRightClick):
2131         
2132         Added files to:
2133         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2134         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2135         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
2136
2137 2011-02-28  Adam Roben  <aroben@apple.com>
2138
2139         Start running InjectedBundle API tests on Windows
2140
2141         A new project, TestWebKitAPIInjectedBundle, builds the injected bundle DLL.
2142
2143         Fixes <http://webkit.org/b/55420> run-api-tests doesn't run injected bundle tests on Windows
2144
2145         Reviewed by Darin Adler.
2146
2147         * TestWebKitAPI/Configurations/TestWebKitAPIDebug.vsprops: Added.
2148         * TestWebKitAPI/Configurations/TestWebKitAPIDebugAll.vsprops: Added.
2149         * TestWebKitAPI/Configurations/TestWebKitAPIDebugCairoCFLite.vsprops: Added.
2150         * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops: Added.
2151         * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops: Added.
2152         These are just extracted from TestWebKitAPI.vcproj.
2153
2154         * TestWebKitAPI/Configurations/TestWebKitAPIInjectedBundleCommon.vsprops: Added. Just sets
2155         up the DLL's filename.
2156
2157         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp: Fixed DLL name.
2158         (TestWebKitAPI::Util::createInjectedBundlePath): Changed to use kCFAllocatorNull instead of
2159         0 (== kCFAllocatorDefault) so that CF won't try to deallocate our C string.
2160
2161         * TestWebKitAPI/win/TestWebKitAPI.sln: Added TestWebKitAPIInjectedBundle. Removed the bogus
2162         "all" configuration.
2163
2164         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Changed to use the new .vsprops files. Added
2165         injected bundle tests. Let VS resort things.
2166
2167         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: Copied from Tools/TestWebKitAPI/win/TestWebKitAPI.vcproj.
2168
2169 2011-02-28  Adam Roben  <aroben@apple.com>
2170
2171         Add a test for the paint rect passed via WM_PAINT to windowless plugins
2172
2173         Test for <http://webkit.org/b/55365> <rdar://problem/9031089> REGRESSION (r79040): WebKit2:
2174         Large portions of pages with plugins paint black
2175
2176         Reviewed by Anders Carlsson.
2177
2178         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2179         (PluginTest::NPP_HandleEvent):
2180         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2181         Added NPP_HandleEvent. Just returns 0 at this level.
2182
2183         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowlessPaintRectCoordinates.cpp: Added.
2184         (WindowlessPaintRectCoordinates::WindowlessPaintRectCoordinates): Call up to the base class.
2185         (WindowlessPaintRectCoordinates::NPP_New): Mark ourselves as windowless.
2186         (WindowlessPaintRectCoordinates::NPP_HandleEvent): Check that the paint rect passed via
2187         WM_PAINT has the expected coordinates.
2188
2189         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2190         (NPP_HandleEvent): Give the PluginTest a chance to handle the event before doing anything
2191         else.
2192
2193         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added new file, let VS
2194         resort things.
2195
2196         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2197         (WTR::InjectedBundlePage::didFinishLoadForFrame): Added a call to WKBundlePageForceRepaint.
2198         This is roughly equivalent to the call to -[WebView displayIfNeeded] in -[FrameLoadDelegate
2199         webView:didFinishLoadForFrame:] in DumpRenderTree.
2200
2201         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2202         (WTR::PlatformWebView::PlatformWebView): Tell the WKView it's in a window so that plugins
2203         can start running.
2204
2205 2011-02-28  Adam Roben  <aroben@apple.com>
2206
2207         Tell MiniBrowser's WKViews that they're in a window
2208
2209         Fixes <http://webkit.org/b/55364> Plugins don't work in MiniBrowser on Windows
2210
2211         Reviewed by Anders Carlsson.
2212
2213         * MiniBrowser/win/BrowserView.cpp:
2214         (BrowserView::create): Call WKViewSetIsInWindow after creating the view.
2215
2216 2011-02-28  Alexis Menard  <alexis.menard@openbossa.org>
2217
2218         Reviewed by Csaba Osztrogonác.
2219
2220         The new QML tests require QML_IMPORT_PATH variable to be set in order to
2221         load the proper plugin.
2222
2223         * Scripts/run-qtwebkit-tests:
2224
2225 2011-02-28  Joone Hur  <joone.hur@collabora.co.uk>
2226
2227         Unreviewed, fix spelling mistake.
2228
2229         hardware-accelated => hardware-accelerated.
2230
2231         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2232
2233 2011-02-28  Kristian Amlie  <kristian.amlie@nokia.com>
2234
2235         Reviewed by Andreas Kling.
2236
2237         Made sure that the build-webkit --qmake argument is always respected.
2238
2239         Previously, it would be respected during the build, but not during
2240         the early feature detection. The build would also fail if qmake was
2241         not in your path, even if you specified --qmake with a valid qmake
2242         binary.
2243
2244         [Qt] WebKit patches required to work with a modularized version of Qt
2245         https://bugs.webkit.org/show_bug.cgi?id=53916
2246
2247         * Scripts/build-webkit:
2248         * Scripts/webkitdirs.pm:
2249
2250 2011-02-27  Ojan Vafai  <ojan@chromium.org>
2251
2252         Fix failing tests from http://trac.webkit.org/changeset/79837.
2253
2254         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2255         This was just a mistake that would break if someone tried printing with this configuration.
2256         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2257         Method signature changed. Didn't notice that this method was being calling in a unittest.
2258
2259 2011-02-24  Hayato Ito  <hayato@chromium.org>
2260
2261         Reviewed by Eric Seidel.
2262
2263         [NRWT] Remove test_types/* classes.
2264
2265         This is the last patch in the series of efforts which tried to remove test_types classes.
2266         A single_test_runner module will take over responsibilities of test_type classes.
2267
2268         From this patch, we won't display statistics per test_type even if a '--verbose' option is given.
2269
2270         https://bugs.webkit.org/show_bug.cgi?id=55123
2271
2272         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
2273         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
2274         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
2275         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2276         * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
2277         * Scripts/webkitpy/layout_tests/test_types/__init__.py: Removed.
2278         * Scripts/webkitpy/layout_tests/test_types/image_diff.py: Removed.
2279         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: Removed.
2280         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py: Removed.
2281         * Scripts/webkitpy/layout_tests/test_types/text_diff.py: Removed.
2282
2283 2011-02-25  Ojan Vafai  <ojan@chromium.org>
2284
2285         Reviewed by Tony Chang.
2286
2287         Change results.json format to the one used by unexpected_results.json
2288         https://bugs.webkit.org/show_bug.cgi?id=52267
2289
2290         Also add runtimes in milliseconds to the JSON and make the output format more compact.
2291         Named the file full_results.json to avoid conflicting with the results.json
2292         file the test-results server currently serves up.
2293
2294         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2295         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2296         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2297         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2298         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
2299         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2300
2301 2011-02-27  Adam Roben  <aroben@apple.com>
2302
2303         Followup fix to r79827
2304
2305         * DumpRenderTree/win/UIDelegate.cpp:
2306         (UIDelegate::webViewAddMessageToConsole): Replaced call to urlSuitableForTestResult with
2307         lastPathComponent. This matches what we did here before r79827, and matches Mac.
2308
2309 2011-02-27  Dan Bernstein  <mitz@apple.com>
2310
2311         Reviewed by Adam Roben.
2312
2313         Make bisect-builds print a trac link for the regression range
2314         https://bugs.webkit.org/show_bug.cgi?id=55331
2315
2316         * Scripts/bisect-builds:
2317
2318 2011-02-27  Adam Roben  <aroben@apple.com>
2319
2320         Use iswalpha instead of isalpha when dealing with wchar_ts in EditingDelegate
2321
2322         Fixes <http://webkit.org/b/55062> <rdar://problem/9059907> Crash beneath
2323         EditingDelegate::checkSpellingOfString when running fast/forms/input-text-maxlength.html or
2324         fast/forms/input-text-paste-maxlength.html on Windows with full page heap enabled
2325
2326         Reviewed by Anders Carlsson.
2327
2328         * DumpRenderTree/win/EditingDelegate.cpp:
2329         (indexOfFirstWordCharacter):
2330         (wordLength):
2331         Use iswalpha instead of isalpha, since TCHAR is really just wchar_t.
2332
2333 2011-02-27  Adam Roben  <aroben@apple.com>
2334
2335         Make ResourceLoadDelegate print URLs relative to the main resource on Windows
2336
2337         This matches Mac. (In fact, the code was ported from Mac!)
2338
2339         Fixes <http://webkit.org/b/55328> URLs printed by ResourceLoadDelegate on Windows don't
2340         match Mac
2341
2342         Reviewed by Anders Carlsson.
2343
2344         * DumpRenderTree/win/DumpRenderTree.cpp:
2345         (substringFromIndex): Added. Emulates -[NSString substringFromIndex:].
2346         (urlSuitableForTestResult): Ported code from -[NSURL(DRTExtras)
2347         _drt_descriptionSuitableForTestResult].
2348         (cfStringRefToWString): Moved here from LayoutTestControllerWin.cpp.
2349
2350         * DumpRenderTree/win/DumpRenderTreeWin.h: Added declaration of cfStringRefToWString.
2351
2352         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Moved cfStringRefToWString to
2353         DumpRenderTree.cpp.
2354
2355 2011-02-27  Adam Roben  <aroben@apple.com>
2356
2357         Change the order of Chang Shu's email addresses so the first one is their Bugzilla username
2358
2359         This makes Bugzilla autocompletion work correctly.
2360
2361         * Scripts/webkitpy/common/config/committers.py:
2362
2363 2011-02-27  Patrick Gansterer  <paroga@webkit.org>
2364
2365         Reviewed by Andreas Kling.
2366
2367         [Qt] fast/loader/user-stylesheet-fast-path.html fails
2368         https://bugs.webkit.org/show_bug.cgi?id=50911
2369
2370         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2371         (LayoutTestController::setUserStyleSheetLocation):
2372         Use QUrl::fromEncoded since the passed string is already encoded.
2373
2374 2011-02-27  Adam Roben  <aroben@apple.com>
2375
2376         Ensure $testResultsDirectory is an absolute path before setting up Windows crash log saving
2377
2378         Windows 7 (and maybe Vista?) launches the post-mortem debugger with a working directory that
2379         is different from old-run-webkit-test's. Because of this, the path to the crash log file
2380         (which is relative to $testResultsDirectory) must be an absolute path. See the bug for more
2381         details.
2382
2383         Fixes <http://webkit.org/b/55318> Crash logs aren't saved on Windows 7 when a relative
2384         --results-directory path is used (like on the test slaves)
2385
2386         Reviewed by Dan Bernstein.
2387
2388         * Scripts/old-run-webkit-tests: Moved the call to setUpWindowsCrashLogSaving after we've
2389         made $testResultsDirectory an absolute path.
2390
2391 2011-02-26  Dominic Mazzoni  <dmazzoni@google.com>
2392
2393         Reviewed by Adam Barth.
2394
2395         m_dumpAccessibilityNotifications should be initialized.
2396         https://bugs.webkit.org/show_bug.cgi?id=54874
2397
2398         * DumpRenderTree/chromium/AccessibilityController.cpp:
2399         (AccessibilityController::AccessibilityController):
2400
2401 2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>
2402
2403         Reviewed by Pavel Feldman.
2404
2405         DumpRenderTree should reset frame opener between tests.
2406         https://bugs.webkit.org/show_bug.cgi?id=54874
2407
2408         Added clearOpener() calls between tests.
2409         Some tests are using window.open() to change current window location.
2410         This changes window.opener property whose nullity is checked before
2411         showing xml viewer.
2412
2413         * DumpRenderTree/chromium/TestShell.cpp:
2414         (TestShell::resetTestController):
2415         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2416         (resetDefaultsToConsistentValues):
2417         * DumpRenderTree/mac/DumpRenderTree.mm:
2418         (resetWebViewToConsistentStateBeforeTesting):
2419         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2420         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2421         * DumpRenderTree/win/DumpRenderTree.cpp:
2422         (resetWebViewToConsistentStateBeforeTesting):
2423         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2424         (WTR::InjectedBundlePage::reset):
2425
2426 2011-02-26  Yael Aharon  <yael.aharon@nokia.com>
2427
2428         Reviewed by Andreas Kling.
2429
2430         [Qt] Fix the focus in MiniBrowser.
2431         https://bugs.webkit.org/show_bug.cgi?id=55288
2432
2433         Give focus to the web view when a load starts.
2434
2435         * MiniBrowser/qt/BrowserWindow.cpp:
2436         (BrowserWindow::urlChanged):
2437
2438 2011-02-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2439
2440         Reviewed by Adam Barth.
2441
2442         [EFL] Add coding style exceptions for EFL port
2443         https://bugs.webkit.org/show_bug.cgi?id=54733
2444
2445         The EFL APIs use EFL naming style, which includes both lower-cased and camel-cased,
2446         underscore-sparated values. But, style checking rule have found parameter_name errors
2447         in efl directories so far.
2448
2449         * Scripts/webkitpy/style/checker.py: Add prameter_name rule's exception and efl directories.
2450
2451 2011-02-26  David Levin  <levin@chromium.org>
2452
2453         Reviewed by Darin Adler.
2454
2455         check-webkit-style should check for spaces after periods in comments
2456         https://bugs.webkit.org/show_bug.cgi?id=55253
2457
2458         * Scripts/webkitpy/style/checkers/cpp.py: Added the check.
2459         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests
2460           and fixed the name of one related test.
2461
2462 2011-02-26  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2463
2464         Reviewed by Andreas Kling.
2465
2466         Make it possible to test the targetdensity-dpi support
2467         https://bugs.webkit.org/show_bug.cgi?id=55142
2468
2469         Test the viewport meta tag feature targetdensity-dpi by
2470         adding extra arguments to dumpConfigurationForViewport
2471
2472         Add the new arguments to the shared header and all
2473         implementation.
2474
2475         * DumpRenderTree/LayoutTestController.cpp:
2476         (dumpConfigurationForViewportCallback):
2477         * DumpRenderTree/LayoutTestController.h:
2478         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2479         (LayoutTestController::dumpConfigurationForViewport):
2480         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2481         (LayoutTestController::dumpConfigurationForViewport):
2482         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2483         (LayoutTestController::dumpConfigurationForViewport):
2484         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2485         (LayoutTestController::dumpConfigurationForViewport):
2486         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2487         (LayoutTestController::dumpConfigurationForViewport):
2488         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2489
2490 2011-02-26  Sheriff Bot  <webkit.review.bot@gmail.com>
2491
2492         Unreviewed, rolling out r79764.
2493         http://trac.webkit.org/changeset/79764
2494         https://bugs.webkit.org/show_bug.cgi?id=55295
2495
2496         "broke Chromium builds" (Requested by rniwa on #webkit).
2497
2498         * DumpRenderTree/chromium/TestShell.cpp:
2499         (TestShell::resetTestController):
2500         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2501         (resetDefaultsToConsistentValues):
2502         * DumpRenderTree/mac/DumpRenderTree.mm:
2503         (resetWebViewToConsistentStateBeforeTesting):
2504         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2505         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2506         * DumpRenderTree/win/DumpRenderTree.cpp:
2507         (resetWebViewToConsistentStateBeforeTesting):
2508         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2509         (WTR::InjectedBundlePage::reset):
2510
2511 2011-02-26  Yongjun Zhang  <yongjun_zhang@apple.com>
2512
2513         Reviewed by David Kilzer.
2514
2515         https://bugs.webkit.org/show_bug.cgi?id=48781
2516
2517         Add a resource load delegate method to query if WebCore should paint the default broken image for failed images.
2518
2519         Add a new resource load client method (shouldPaintBrokenImage).  WebKit client can decide if WebCore
2520         should paint the default broken image when an image fails to load or decode.
2521
2522         * DumpRenderTree/LayoutTestController.cpp:
2523         (LayoutTestController::LayoutTestController):
2524         (setShouldPaintBrokenImageCallback):
2525         (LayoutTestController::staticFunctions):
2526         (LayoutTestController::setShouldPaintBrokenImage):
2527         * DumpRenderTree/LayoutTestController.h:
2528         (LayoutTestController::shouldPaintBrokenImage):
2529         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2530         (-[ResourceLoadDelegate webView:shouldPaintBrokenImageForURL:]):
2531
2532 2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>
2533
2534         Reviewed by Pavel Feldman.
2535
2536         DumpRenderTree should reset frame opener between tests.
2537         https://bugs.webkit.org/show_bug.cgi?id=54874
2538
2539         Added clearOpener() calls between tests.
2540         Some tests are using window.open() to change current window location.
2541         This changes window.opener property whose nullity is checked before
2542         showing xml viewer.
2543
2544         * DumpRenderTree/chromium/TestShell.cpp:
2545         (TestShell::resetTestController):
2546         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2547         (resetDefaultsToConsistentValues):
2548         * DumpRenderTree/mac/DumpRenderTree.mm:
2549         (resetWebViewToConsistentStateBeforeTesting):
2550         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2551         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2552         * DumpRenderTree/win/DumpRenderTree.cpp:
2553         (resetWebViewToConsistentStateBeforeTesting):
2554         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2555         (WTR::InjectedBundlePage::reset):
2556
2557 2011-02-25  Lukasz Slachciak  <l.slachciak@samsung.com>
2558
2559         Reviewed by Kenneth Rohde Christiansen.
2560
2561         [EFL] Added EWebLauncher command line option to turn on/off frame flattening
2562         https://bugs.webkit.org/show_bug.cgi?id=54809
2563
2564         * EWebLauncher/main.c: Handling -f option added.
2565         (on_key_down):
2566         (browserCreate):
2567         (main):
2568
2569 2011-02-25  Sheriff Bot  <webkit.review.bot@gmail.com>
2570
2571         Unreviewed, rolling out r79324.
2572         http://trac.webkit.org/changeset/79324
2573         https://bugs.webkit.org/show_bug.cgi?id=55260
2574
2575         Leopard Debug is once again running out of address space while
2576         linking (Requested by aroben on #webkit).
2577
2578         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2579         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2580
2581 2011-02-25  Tony Chang  <tony@chromium.org>
2582
2583         Reviewed by James Robinson.
2584
2585         Clean up temp files left by crashing DRTs on chromium-win
2586         https://bugs.webkit.org/show_bug.cgi?id=55182
2587
2588         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2589         * BuildSlaveSupport/chromium/remove-crash-logs: Added.
2590
2591 2011-02-25  Adam Roben  <aroben@apple.com>
2592
2593         Double-check that modifying the registry worked
2594
2595         On Windows Vista/7 with UAC enabled, regtool will fail to modify the registry, but it will
2596         still return a successful exit code. So we double-check here that the value we tried to
2597         write to the registry was really written.
2598
2599         Fixes <http://webkit.org/b/55227> old-run-webkit-tests falsely claims to be saving crash
2600         logs on Windows Vista/7
2601
2602         Reviewed by Darin Adler.
2603
2604         * Scripts/old-run-webkit-tests:
2605         (writeRegistryString): After trying to write the string value, check that it was really
2606         written.
2607
2608 2011-02-25  Adam Roben  <aroben@apple.com>
2609
2610         Set the 32-bit post-mortem debugger on 64-bit OSes
2611
2612         The post-mortem debugger is controlled by some registry values in
2613         HKLM\SOFTWARE\Microsoft\Windows NT\CurrentVersion\AeDebug. On 64-bit OSes, you can either
2614         set the values in that key, which will be used for 64-bit apps, or in the equivalent key
2615         under Wow6432Node, which will be used for 32-bit apps. Since DumpRenderTree and
2616         WebKitTestRunner are 32-bit, we want to use the latter location.
2617
2618         Fixes <http://webkit.org/b/55225> old-run-webkit-tests sets the post-mortem debugger for
2619         64-bit apps, but should set it for 32-bit apps instead
2620
2621         Reviewed by Darin Adler.
2622
2623         * Scripts/old-run-webkit-tests:
2624         (readRegistryString):
2625         (writeRegistryString):
2626         Pass --wow32 to regtool so it will get/set values beneath Wow6432Node, which is where
2627         Windows looks for the post-mortem debugger values when a 32-bit app crashes on a 64-bit OS.
2628         Passing --wow32 on a 32-bit OS will not have any effect.
2629
2630 2011-02-25  Adam Roben  <aroben@apple.com>
2631
2632         Clean up code to set up crash log saving on Windows
2633
2634         Fixes <http://webkit.org/b/55224> old-run-webkit-test's Windows registry code is ugly
2635
2636         Reviewed by David Kilzer.
2637
2638         * Scripts/old-run-webkit-tests:
2639         (readRegistryString):
2640         (writeRegistryString):
2641         Moved code to read strings from and write strings to the registry here...
2642
2643         (setUpWindowsCrashLogSaving): ...from here.
2644
2645 2011-02-25  Adam Roben  <aroben@apple.com>
2646
2647         Work around Cygwin's crash-suppression behavior
2648
2649         Cygwin calls ::SetErrorMode(SEM_FAILCRITICALERRORS), which any processes it launches will
2650         inherit. This is bad for testing/debugging, as it causes the post-mortem debugger not to be
2651         invoked. (Cygwin does this because it makes crashes more UNIX-y.) We reset the error mode
2652         when our test apps launch to work around Cygwin's behavior.
2653
2654         Fixes <http://webkit.org/b/55222> Test apps crash silently (without invoking post-mortem
2655         debugger) when launched from Cygwin 1.7
2656
2657         Reviewed by Darin Adler.
2658
2659         * DumpRenderTree/win/DumpRenderTree.cpp:
2660         (main):
2661         * TestWebKitAPI/win/main.cpp:
2662         (main):
2663         * WebKitAPITest/main.cpp:
2664         (main):
2665         * WebKitTestRunner/win/TestControllerWin.cpp:
2666         (WTR::TestController::platformInitialize):
2667         Call ::SetErrorMode(0) to undo Cygwin's folly.
2668
2669 2011-02-24  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2670
2671         Reviewed by Andreas Kling.
2672
2673         [Qt] Revert the support for QNAM affined to a different thread.
2674         https://bugs.webkit.org/show_bug.cgi?id=55149
2675
2676         Qt 4.8 will have QNAM use its own thread internally by default,
2677         no need to keep this complexity in WebKit.
2678
2679         This mainly reverts:
2680         http://trac.webkit.org/changeset/73710
2681         http://trac.webkit.org/changeset/73712
2682
2683         * QtTestBrowser/launcherwindow.cpp:
2684         (LauncherWindow::~LauncherWindow):
2685         (LauncherWindow::initializeView):
2686         (LauncherWindow::createChrome):
2687         * QtTestBrowser/launcherwindow.h:
2688         (WindowOptions::WindowOptions):
2689         * QtTestBrowser/webpage.cpp:
2690         (WebPage::WebPage):
2691         * QtTestBrowser/webpage.h:
2692
2693 2011-02-24  Adam Barth  <abarth@webkit.org>
2694
2695         Reviewed by Eric Seidel.
2696
2697         Add a script for creating gypi files
2698         https://bugs.webkit.org/show_bug.cgi?id=55113
2699
2700         This is a trivial script to create gypi files from the source code in
2701         the current directory.
2702
2703         * Scripts/make-gypi: Added.
2704
2705 2011-02-24  Sheriff Bot  <webkit.review.bot@gmail.com>
2706
2707         Unreviewed, rolling out r79628.
2708         http://trac.webkit.org/changeset/79628
2709         https://bugs.webkit.org/show_bug.cgi?id=55195
2710
2711         "broke chromium win tests" (Requested by dpranke on #webkit).
2712
2713         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2714         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2715
2716 2011-02-24  Dirk Pranke  <dpranke@chromium.org>
2717
2718         Reviewed by Mihai Parparita.
2719
2720         rebaseline-chromium-webkit-tests can't handle GPU variants
2721         https://bugs.webkit.org/show_bug.cgi?id=55002
2722
2723         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2724         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2725
2726 2011-02-24  Dirk Pranke  <dpranke@chromium.org>
2727
2728         Reviewed by Mihai Parparita.
2729
2730         nrwt: log command used to start web server to --verbose
2731
2732         https://bugs.webkit.org/show_bug.cgi?id=55188
2733
2734         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
2735         * Scripts/webkitpy/layout_tests/port/http_server.py:
2736
2737 2011-02-24  Victoria Kirst  <vrk@google.com>
2738
2739         Reviewed by Mihai Parparita.
2740
2741         [chromium] Move media-file.js and video-test.js back to media/ for UILayoutTests
2742         https://bugs.webkit.org/show_bug.cgi?id=55089
2743
2744         This adds an alias into the media/ directory so that http/tests/media
2745         tests can access the media resources when running in an httpd process.
2746
2747         * Scripts/webkitperl/httpd.pm:
2748         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
2749         * Scripts/webkitpy/layout_tests/port/http_server.py:
2750
2751 2011-02-24  Dirk Pranke  <dpranke@chromium.org>
2752
2753         Reviewed by Mihai Parparita.
2754
2755         nrwt: enable multiple processes by default on Chromium Win.
2756
2757         https://bugs.webkit.org/show_bug.cgi?id=55163
2758
2759         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2760         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2761
2762 2011-02-24  Sam Weinig  <sam@webkit.org>
2763
2764         Attempt to fix Qt.
2765
2766         * WebKitTestRunner/TestInvocation.cpp:
2767
2768 2011-02-24  James Robinson  <jamesr@chromium.org>
2769
2770         Unreviewed, rolling out r79598.
2771         http://trac.webkit.org/changeset/79598
2772         https://bugs.webkit.org/show_bug.cgi?id=55089
2773
2774         Appears to be causing trouble with httpd on windows
2775
2776         * Scripts/webkitperl/httpd.pm:
2777         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
2778         * Scripts/webkitpy/layout_tests/port/http_server.py:
2779
2780 2011-02-24  Sam Weinig  <sam@webkit.org>
2781
2782         Reviewed by Darin Adler.
2783
2784         Add basic pixel testing support to WebKitTestRunner
2785         https://bugs.webkit.org/show_bug.cgi?id=55161
2786
2787         * Scripts/old-run-webkit-tests:
2788         Don't print color space information when using WebKitTestRunner since
2789         we don't need to change the screen.
2790
2791         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2792         (WTR::InjectedBundle::initialize):
2793         Add call to initializePlatformDefaults.
2794         
2795         (WTR::InjectedBundle::done):
2796         Return a dictionary on completion with both the text output and pixel dump override.
2797
2798         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2799         Add declaration for initializePlatformDefaults.
2800
2801         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2802         (WTR::LayoutTestController::LayoutTestController):
2803         (WTR::LayoutTestController::dumpAsText):
2804         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2805         (WTR::LayoutTestController::shouldDumpPixels):
2806         Make setting dumpAsText override the dump pixels preference.
2807
2808         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: Added.
2809         (WTR::InjectedBundle::initializePlatformDefaults):
2810         Set platform defaults matching DumpRenderTree.
2811
2812         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp: Added.
2813         (WTR::InjectedBundle::initializePlatformDefaults):
2814         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp: Added.
2815         (WTR::InjectedBundle::initializePlatformDefaults):
2816         Add stubs for initializePlatformDefaults.
2817
2818         * WebKitTestRunner/TestController.cpp:
2819         (WTR::TestController::runTest):
2820         (WTR::TestController::runTestingServerLoop):
2821         (WTR::TestController::run):
2822         Parse expected pixel results out of stdin and setup the invocation with it.
2823
2824         * WebKitTestRunner/TestInvocation.cpp:
2825         (WTR::TestInvocation::TestInvocation):
2826         Initialize new members.
2827
2828         (WTR::TestInvocation::~TestInvocation):
2829         (WTR::TestInvocation::setIsPixelTest):
2830         (WTR::sizeWebViewForCurrentTest):
2831         (WTR::TestInvocation::invoke):
2832         (WTR::TestInvocation::dump):
2833         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2834         * WebKitTestRunner/TestInvocation.h:
2835         Dump pixels in addition to text by calling dumpPixelsAndCompareWithExpected.
2836
2837         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2838         (WTR::PlatformWebView::PlatformWebView):
2839         Use -[NSColorSpace genericRGBColorSpace] instead of the main screen color space.
2840
2841         * WebKitTestRunner/mac/TestInvocationMac.mm: Added.
2842         (WTR::createCGContextFromPlatformView):
2843         (WTR::computeMD5HashStringForContext):
2844         (WTR::dumpBitmap):
2845         (WTR::forceRepaintFunction):
2846         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2847         Add mac specific pixel dumping support. Right now, we always pull pixels
2848         from the window server.
2849
2850         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2851         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2852         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2853         * WebKitTestRunner/win/InjectedBundle.vcproj:
2854         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2855         Add new files.
2856
2857 2011-02-24  Chang Shu  <cshu@webkit.org>
2858
2859         Reviewed by Kenneth Rohde Christiansen.
2860
2861         [Qt] Launch MiniBrowser if the test run is WebKit2. 
2862         https://bugs.webkit.org/show_bug.cgi?id=55145
2863
2864         * Scripts/old-run-webkit-tests:
2865         * Scripts/run-launcher:
2866         * Scripts/webkitdirs.pm:
2867
2868 2011-02-24  Victoria Kirst  <vrk@google.com>
2869
2870         Reviewed by Mihai Parparita.
2871
2872         [chromium] Move media-file.js and video-test.js back to media/ for UILayoutTests
2873         https://bugs.webkit.org/show_bug.cgi?id=55089
2874
2875         This adds an alias into the media/ directory so that http/tests/media
2876         tests can access the media resources when running in an httpd process.
2877
2878         * Scripts/webkitperl/httpd.pm:
2879         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
2880         * Scripts/webkitpy/layout_tests/port/http_server.py:
2881
2882 2011-02-24  Andrew Wilson  <atwilson@chromium.org>
2883
2884         Unreviewed, rolling out r79570.
2885         http://trac.webkit.org/changeset/79570
2886         https://bugs.webkit.org/show_bug.cgi?id=54874
2887
2888         Breaks chromium build because glue/mocks/mock_web_frame.h/cc
2889         was not updated
2890
2891         * DumpRenderTree/chromium/TestShell.cpp:
2892         (TestShell::resetTestController):
2893         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2894         (resetDefaultsToConsistentValues):
2895         * DumpRenderTree/mac/DumpRenderTree.mm:
2896         (resetWebViewToConsistentStateBeforeTesting):
2897         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2898         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2899         * DumpRenderTree/win/DumpRenderTree.cpp:
2900         (resetWebViewToConsistentStateBeforeTesting):
2901         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2902         (WTR::InjectedBundlePage::reset):
2903
2904 2011-02-24  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
2905
2906         Reviewed by Laszlo Gombos.
2907
2908         [Qt] add android 2.2 user agent to QtTestBrowser
2909         https://bugs.webkit.org/show_bug.cgi?id=55085
2910
2911         Credit to Forrest Hodgkins to find right user-agent which works for youtube.
2912         * QtTestBrowser/useragentlist.txt:
2913
2914 2011-02-24  Adam Roben  <aroben@apple.com>
2915
2916         Change FrameLoadDelegate to support any number of delegates with delayed work to process
2917
2918         This makes our behavior match Mac more closely, and allows us to remove an incorrect
2919         assertion that was firing during some tests. (The assertion was claiming that there was
2920         never more than one delegate with delayed work to process, but that was not the case.)
2921
2922         Fixes <http://webkit.org/b/55146> Assertion failure in FrameLoadDelegate::locationChangeDone
2923         when running http/tests/navigation/back-twice-without-commit.html
2924
2925         Reviewed by Eric Carlson.
2926
2927         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2928         (delegatesWithDelayedWork): Added. Returns all FrameLoadDelegates that have delayed work to
2929         process. A single delegate may appear in this Vector more than once (just as, on Mac, a
2930         single delegate may have multiple performSelector requests).
2931         (processWorkTimer): Pass the HWND to ::KillTimer, for pedantic brownie points. Added an
2932         assertion that the timer firing is the shared process work timer. Instead of using the
2933         single, global "delegate waiting for timer" delegate, give all delegates that have delayed
2934         work to process a chance to process their work.
2935         (FrameLoadDelegate::locationChangeDone): If we don't already have an active timer for
2936         processing delayed work, create one. Then add ourselves to the delegatesWithDelayedWork
2937         Vector so our processWork function will be called when the timer fires.
2938
2939 2011-02-24  Vsevolod Vlasov  <vsevik@chromium.org>
2940
2941         Reviewed by Alexey Proskuryakov.
2942
2943         DumpRenderTree should reset frame opener between tests.
2944         https://bugs.webkit.org/show_bug.cgi?id=54874
2945
2946         Added clearOpener() calls between tests.
2947         Some tests are using window.open() to change current window location.
2948         This changes window.opener property whose nullity is checked before
2949         showing xml viewer.
2950
2951         * DumpRenderTree/chromium/TestShell.cpp:
2952         (TestShell::resetTestController):
2953         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2954         (resetDefaultsToConsistentValues):
2955         * DumpRenderTree/mac/DumpRenderTree.mm:
2956         (resetWebViewToConsistentStateBeforeTesting):
2957         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2958         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2959         * DumpRenderTree/win/DumpRenderTree.cpp:
2960         (resetWebViewToConsistentStateBeforeTesting):
2961         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2962         (WTR::InjectedBundlePage::reset):
2963
2964 2011-02-24  Adam Roben  <aroben@apple.com>
2965
2966         Don't trigger Windows builds for changes to WebCore.exp.in or the top-level GNUmakefile.am
2967
2968         Fixes <http://webkit.org/b/55144> Windows builders should not have built r79343 or r79440,
2969         but did
2970
2971         Reviewed by Anders Carlsson.
2972
2973         * Scripts/webkitpy/common/config/build.py:
2974         (_should_file_trigger_build): Loosened the pattern for GNUmakefile.am to include the
2975         top-level GNUmakefile.am, and loosened the pattern for .exp files to include WebCore.exp.in.
2976
2977         * Scripts/webkitpy/common/config/build_unittest.py:
2978         (ShouldBuildTest): Added some more tests.
2979
2980 2011-02-24  Andras Becsi  <abecsi@webkit.org>
2981
2982         Reviewed by Laszlo Gombos.
2983
2984         [Qt] MinGW build fails to link
2985         https://bugs.webkit.org/show_bug.cgi?id=55050
2986
2987         Prepend the libraries of subcomponents instead of appending them
2988         to fix the library order according to the dependency of the libraries
2989
2990         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2991         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2992
2993 2011-02-24  Gabor Loki  <loki@webkit.org>
2994
2995         Reviewed by Csaba Osztrogonác.
2996
2997         [Qt] Remove ARMv5 Release buildbot.
2998
2999         Remove ARMv5 Release buildbot, because there is very little difference
3000         between ARMv5 and ARMv7 Release bots, and there is also very little
3001         interest in ARMv5 build slave (compared to ARMv7).
3002
3003         * BuildSlaveSupport/build.webkit.org-config/config.json:
3004         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3005
3006 2011-02-22  Ojan Vafai  <ojan@chromium.org>
3007
3008         Reviewed by Tony Chang.
3009
3010         fix revision number finding when creating git patches
3011         https://bugs.webkit.org/show_bug.cgi?id=55024
3012
3013         HEAD~n does not walk merge commits correctly. git log however does.
3014
3015         * Scripts/webkitpy/common/checkout/scm.py:
3016         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3017
3018 2011-02-23  Kenneth Russell  <kbr@google.com>
3019
3020         Unreviewed, rolling out r79387.
3021         https://bugs.webkit.org/show_bug.cgi?id=54885
3022
3023         Reapply the code changes from r79038 since they weren't the root
3024         cause of the test timeouts.
3025
3026         * DumpRenderTree/chromium/WebViewHost.cpp:
3027         (WebViewHost::reset):
3028
3029 2011-02-23  Siddharth Mathur  <siddharth.mathur@nokia.com>
3030
3031         Reviewed by Laszlo Gombos.
3032
3033         [Qt] Make sure Symbian binary UIDs are unique
3034
3035         * MiniBrowser/qt/MiniBrowser.pro: Resolve the UID collision with
3036         QtTestBrowser.pro by changing the UID.
3037
3038 2011-02-23  Patrick Gansterer  <paroga@webkit.org>
3039
3040         Reviewed by Darin Adler.
3041
3042         Rename PLATFORM(CF) to USE(CF)
3043         https://bugs.webkit.org/show_bug.cgi?id=53540
3044
3045         * DumpRenderTree/config.h:
3046
3047 2011-02-23  Dirk Pranke  <dpranke@chromium.org>
3048
3049         Reviewed by Ojan Vafai.
3050
3051         nrwt: turn on multiprocessing on chromium_linux, clean up unit tests for worker model defaults
3052         https://bugs.webkit.org/show_bug.cgi?id=55016
3053
3054         * Scripts/webkitpy/layout_tests/port/base.py:
3055         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3056         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py: Added.
3057         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3058         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3059         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3060         * Scripts/webkitpy/layout_tests/port/mac.py:
3061         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3062         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3063         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3064
3065 2011-02-23  Tony Chang  <tony@chromium.org>
3066
3067         Reviewed by Kent Tamura.
3068
3069         [chromium] DumpRenderTree --check-layout-test-sys-deps leaks 4 temp dirs
3070         https://bugs.webkit.org/show_bug.cgi?id=55004
3071
3072         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3073         (WebKitSupportTestEnvironment::WebKitSupportTestEnvironment):
3074         (WebKitSupportTestEnvironment::~WebKitSupportTestEnvironment):
3075         (main): Use a C++ object to ensure that TearDownTestEnvironment
3076             gets called when --check-layout-test-sys-deps is called
3077
3078 2011-02-23  Gopal Raghavan  <gopal.1.raghavan@nokia.com>
3079
3080         Reviewed by Anders Carlsson.
3081
3082         [Qt] [Qt] check webkit style fails in qt/tests
3083         https://bugs.webkit.org/show_bug.cgi?id=54998
3084
3085         check-webkit-style was complaining about missing config.h in WebKit/qt/test/qdeclarativewebview. This patch was originally part of 50222. Reviewer suggested to split and create a separate patch for checker.
3086
3087         * Scripts/webkitpy/style/checker.py:
3088
3089 2011-02-22  Vsevolod Vlasov  <vsevik@chromium.org>
3090
3091         Reviewed by Pavel Feldman.
3092
3093         DumpRenderTree should dump as text if test path contains "dumpAsText/"
3094         https://bugs.webkit.org/show_bug.cgi?id=54873
3095
3096         * DumpRenderTree/chromium/LayoutTestController.h:
3097         (LayoutTestController::setShouldDumpAsText):
3098         (LayoutTestController::setShouldGeneratePixelResults):
3099         * DumpRenderTree/chromium/TestShell.cpp:
3100         (TestShell::runFileTest):
3101         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3102         (shouldDumpAsText):
3103         (dump):
3104         (runTest):
3105         * DumpRenderTree/mac/DumpRenderTree.mm:
3106         (shouldDumpAsText):
3107         (runTest):
3108         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3109         (WebCore::isDumpAsTextTest):
3110         (WebCore::DumpRenderTree::open):
3111         * DumpRenderTree/win/DumpRenderTree.cpp:
3112         (shouldDumpAsText):
3113         (runTest):
3114         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3115         (WTR::InjectedBundlePage::dump):
3116
3117 2011-02-22  Kenneth Russell  <kbr@google.com>
3118
3119         Reviewed by James Robinson.
3120
3121         Many tests started timing out on the chrome mac canaries around r79035
3122         https://bugs.webkit.org/show_bug.cgi?id=54885
3123
3124         Revert the code changes, but not the Chromium DEPS roll, from
3125         r79038 to see whether this clears up the timing-out tests. Was not
3126         able to reproduce the timeouts locally with a Release mode build
3127         of DRT (on Snow Leopard).
3128
3129         * DumpRenderTree/chromium/WebViewHost.cpp:
3130         (WebViewHost::reset):
3131
3132 2011-02-22  Dirk Pranke  <dpranke@chromium.org>
3133
3134         Reviewed by James Robinson.
3135
3136         nrwt: --platform chromium-gpu doesn't work with --worker-model=processes
3137         https://bugs.webkit.org/show_bug.cgi?id=55009
3138
3139         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3140
3141 2011-02-18  Mihai Parparita  <mihaip@chromium.org>
3142
3143         Reviewed by Ojan Vafai.
3144
3145         Default to 500 for --exit-after-n-failures
3146         https://bugs.webkit.org/show_bug.cgi?id=54773
3147
3148         Make 500 the default value for --exit-after-n-failures (ORWT bots
3149         already default to this as of r75726). Similarly, change the default for
3150         --exit-after-n-crashes-or-timeouts to 20.
3151
3152         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3153
3154 2011-02-02  Martin Robinson  <mrobinson@igalia.com>
3155
3156         Reviewed by Xan Lopez.
3157
3158         [GTK] DRT needs an implementation of LayoutTestController.setSelectTrailingWhitespace
3159         https://bugs.webkit.org/show_bug.cgi?id=53603
3160
3161         Add support for LayoutTestController.setSelectTrailingWhitespace by calling through
3162         to DumpRenderTreeSupportGtk for this functionality.
3163
3164         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3165         (resetDefaultsToConsistentValues): Always call LayoutTestController.setSelectTrailingWhitespace to
3166         false when reseting values between tests.
3167         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3168         (LayoutTestController::setSelectTrailingWhitespaceEnabled): Call LayoutTestController.setSelectTrailingWhitespace
3169         with the appropriate value.
3170
3171 2011-02-22  Adam Roben  <aroben@apple.com>
3172
3173         Don't trigger a Windows build when the top-level ChangeLog changes
3174
3175         r79320 is an example of a change that shouldn't have built on Windows, but did, because of
3176         this bug.
3177
3178         Fixes <http://webkit.org/b/54957> Windows bots build when top-level ChangeLog changes, but
3179         shouldn't
3180
3181         Reviewed by Anders Carlsson.
3182
3183         * Scripts/webkitpy/common/config/build.py:
3184         (_should_file_trigger_build): Modified the ChangeLog pattern to match the top-level
3185         ChangeLog, and re-sorted it in the list.
3186
3187         * Scripts/webkitpy/common/config/build_unittest.py:
3188         (ShouldBuildTest): Added a test that ChangeLogs don't trigger builds.
3189
3190 2011-02-22  Sheriff Bot  <webkit.review.bot@gmail.com>
3191
3192         Unreviewed, rolling out r78691.
3193         http://trac.webkit.org/changeset/78691
3194         https://bugs.webkit.org/show_bug.cgi?id=54956
3195
3196         Leopard Debug is successfully building again (Requested by
3197         aroben on #webkit).
3198
3199         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3200         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3201
3202 2011-02-22  Ilya Tikhonovsky  <loislo@chromium.org>
3203
3204         Reviewed by Pavel Feldman.
3205
3206         Web Inspector: flakyness of inspector tests.
3207         https://bugs.webkit.org/show_bug.cgi?id=54729
3208
3209         As far as we have the protocol with sequence numbers we can simplify test harness support
3210         and drop out chomium specific methods.
3211
3212         * DumpRenderTree/DumpRenderTree.gypi:
3213         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
3214         (DRTDevToolsAgent::sendMessageToInspectorFrontend):
3215         (DRTDevToolsAgent::runtimePropertyChanged):
3216         (DRTDevToolsAgent::asyncCall):
3217         (DRTDevToolsAgent::call):
3218         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
3219         * DumpRenderTree/chromium/DRTDevToolsCallArgs.cpp: Removed.
3220         * DumpRenderTree/chromium/DRTDevToolsCallArgs.h: Removed.
3221         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
3222         (DRTDevToolsClient::sendMessageToBackend):
3223         (DRTDevToolsClient::asyncCall):
3224         (DRTDevToolsClient::call):
3225         * DumpRenderTree/chromium/DRTDevToolsClient.h:
3226
3227 2011-02-22  Andras Becsi  <abecsi@webkit.org>
3228
3229         Reviewed by Laszlo Gombos.
3230
3231         [Qt] Redesign the build system
3232         https://bugs.webkit.org/show_bug.cgi?id=51339
3233
3234         Part 2.
3235
3236         Build WebCore as a static library, compile the WebKit API and WebKit2 API
3237         in a final step and link to WebKit2, WebCore and JSC libraries to fix
3238         linking issues resulting from stripped away symbols.
3239
3240         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Remove superfluous includepaths.
3241
3242 2011-02-21  Lukasz Slachciak  <l.slachciak@samsung.com>
3243
3244         Reviewed by Antonio Gomes.
3245
3246         [EFL] Restored spatial navigation option in EWebLauncher since #18662 bug is closed
3247         https://bugs.webkit.org/show_bug.cgi?id=54806
3248
3249         * EWebLauncher/main.c:
3250         (on_key_down): calling ewk_view_setting_spatial_navigation_set when "F12" pressed added.
3251
3252 2011-02-21  Dirk Pranke  <dpranke@chromium.org>
3253
3254         Reviewed by Kent Tamura.
3255
3256         nrwt: revert behavior on 10.5 to "old-threads". It's possible
3257         that r79062 has introduced a bunch of flakiness, although I
3258         can't explain why right now. This change should restore the
3259         old behavior, and then we can look at the build logs to see
3260         if the tests stop timing out or being flaky.
3261
3262         https://bugs.webkit.org/show_bug.cgi?id=54925
3263
3264         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3265         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3266         * Scripts/webkitpy/layout_tests/port/mac.py:
3267         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3268
3269 2011-02-21  Dirk Pranke  <dpranke@chromium.org>
3270
3271         Reviewed by Dimitri Glazkov.
3272
3273         nrwt: fix typo causing us to try and repeatedly shut down the servers
3274         https://bugs.webkit.org/show_bug.cgi?id=54904
3275
3276         * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
3277
3278 2011-02-21  Alejandro G. Castro  <alex@igalia.com>
3279
3280         Reviewed by Csaba Osztrogonác.
3281
3282         REGRESSION(r79157):
3283         plugins/get-url-with-javascript-destroying-plugin.html make the
3284         next test crash
3285         https://bugs.webkit.org/show_bug.cgi?id=54863
3286
3287         * GNUmakefile.am:
3288
3289 2011-02-20  Dirk Pranke  <dpranke@chromium.org>
3290
3291         Reviewed by Ojan Vafai.
3292
3293         test-webkitpy: stop skipping a bunch of tests on win32
3294         https://bugs.webkit.org/show_bug.cgi?id=54788
3295
3296         * Scripts/webkitpy/common/net/testoutputset_unittest.py:
3297         * Scripts/webkitpy/test/main.py:
3298
3299 2011-02-20  Dirk Pranke  <dpranke@chromium.org>
3300
3301         Reviewed by Ojan Vafai.
3302
3303         Fix various bugs related to handling of dir separators and real
3304         vs. fake filesystems that were causing test-webkitpy to fail
3305         tests on win32. These bugs have a variety of causes but are
3306         lumped together because they should be easy to review.
3307
3308         https://bugs.webkit.org/show_bug.cgi?id=54700
3309
3310         * Scripts/webkitpy/common/net/testoutput.py:
3311           Here we were using os.path.sep but not escaping it prior to
3312           using in a regexp, which  caused bad things on win32.
3313         * Scripts/webkitpy/common/net/testoutput_unittest.py:
3314           Same here.
3315         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3316           Here we were using the native filesystem instead of the mock
3317           filesystem, making some tests unnecessarily platform dependent.
3318           Also we weren't setting the default configuration for the
3319           TestChromiumWinPort.
3320         * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py:
3321           Here we *shouldn't* use os.path.join(), just so the code becomes
3322           less platform dependent.
3323         * Scripts/webkitpy/style/checker.py:
3324           Here we should be using os.path.sep instead of "/"; the tests
3325           require the native filesystem.
3326         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3327           Here the underlying code is using os.path.sep, so we probably
3328           should as well.
3329         * Scripts/webkitpy/style/test_expectations_unittest.py:
3330           Here we should be using the filesystem hanging of the port
3331           object (which is the mocked filesystem) rather than the native
3332           one.
3333
3334 2011-02-20  Anders Carlsson  <andersca@apple.com>
3335
3336         Reviewed by Maciej Stachowiak.
3337
3338         Crash when a plug-in requests a javascript: url that destroys the plug-in
3339         https://bugs.webkit.org/show_bug.cgi?id=54837
3340         <rdar://problem/9005475>
3341
3342         Add new plug-in test.
3343
3344         * DumpRenderTree/DumpRenderTree.gypi:
3345         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3346         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3347         (PluginTest::NPN_GetURL):
3348         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3349         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURLDestroyingPlugin.cpp: Added.
3350         (GetURLWithJavaScriptURLDestroyingPlugin::GetURLWithJavaScriptURLDestroyingPlugin):
3351         (GetURLWithJavaScriptURLDestroyingPlugin::NPP_New):
3352         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3353         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3354
3355 2011-02-19  Patrick Gansterer  <paroga@webkit.org>
3356
3357         Reviewed by Andreas Kling.
3358
3359         Make WinCE a core builder
3360         https://bugs.webkit.org/show_bug.cgi?id=54801
3361
3362         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3363         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3364
3365 2011-02-19  Lukasz Slachciak  <l.slachciak@samsung.com>
3366
3367         Reviewed by Andreas Kling.
3368
3369         Fixed problem with launching EWebLauncher with "run-launcher --efl". Incorrect path referring to non-existing .libs directory ws set.
3370         https://webkit.org/b/54778
3371
3372         * Scripts/webkitdirs.pm:
3373
3374 2011-02-18  David Levin  <levin@chromium.org>
3375
3376         Reviewed by Eric Seidel.
3377
3378         check-webkit-style: Misses brace style error when the line with the { has a } in it.
3379         https://bugs.webkit.org/show_bug.cgi?id=54769
3380
3381         * Scripts/webkitpy/style/checkers/cpp.py: Fixed the check for the close brace
3382           to only look after the last open brace, so that the open brace in this line
3383           "} else {" will still be able to trigger the error.
3384         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added related unit tests.
3385
3386 2011-02-18  Zan Dobersek  <zandobersek@gmail.com>
3387
3388         Reviewed by Martin Robinson.
3389
3390         [Gtk] Re-enable meter tag support
3391         https://bugs.webkit.org/show_bug.cgi?id=54762
3392
3393         Meter tag is supported on the Gtk port, enable it by default.
3394
3395         * Scripts/build-webkit:
3396
3397 2011-02-18  David Levin  <levin@chromium.org>
3398
3399         Reviewed by Eric Seidel.
3400
3401         check-webkit-style falsely complains about WebKitGTK+ public headers
3402         https://bugs.webkit.org/show_bug.cgi?id=54650
3403
3404         * Scripts/webkitpy/style/checker.py: Add some exceptions for the gtk files.
3405         * Scripts/webkitpy/style/checkers/cpp.py: Restrict the checks for WEBKIT_API
3406           to the chromium directory (and improved the checks slightly).
3407         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added corresponding tests.
3408
3409 2011-02-18  Dirk Pranke  <dpranke@chromium.org>
3410
3411         Reviewed by James Robinson.
3412
3413         new-run-webkit-tests: enable multiple processes by default on
3414         mac. This change removes the artificial restrictions we placed
3415         on the # of child processes we used with the old threading
3416         model, and switches to the new message-based model and multiple
3417         processes, where available. If multiple processes are not
3418         available (Leopard / Python 2.5), then we use the 'inline' model
3419         instead of the 'old-threads' model on the 'mac' port or one
3420         process on the 'chromium-mac' port. We need additional testing
3421         to see if the new 'threads' model works reliably and is worth
3422         supporting, or if we should just live with things being slightly
3423         slow.
3424
3425         https://bugs.webkit.org/show_bug.cgi?id=54596
3426
3427         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3428         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3429         * Scripts/webkitpy/layout_tests/port/mac.py:
3430         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3431         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3432
3433 2011-02-18  Andrew Wilson  <atwilson@chromium.org>
3434
3435         Unreviewed, rolling out r79047.
3436         http://trac.webkit.org/changeset/79047
3437         https://bugs.webkit.org/show_bug.cgi?id=54596
3438
3439         Broke canary bots - please watch the canaries the next time
3440         you land this
3441
3442         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3443         * Scripts/webkitpy/layout_tests/port/mac.py:
3444
3445 2011-02-18  Emil A Eklund  <eae@chromium.org>
3446
3447         Reviewed by Darin Adler.
3448
3449         Crash in EventHandler::sendContextMenuEventForKey
3450         https://bugs.webkit.org/show_bug.cgi?id=54495
3451
3452         Add support for the context menu key (VK_APPS) to EventSender for
3453         platforms that support the key.
3454
3455         * DumpRenderTree/chromium/EventSender.cpp:
3456         (EventSender::keyDown):
3457         * DumpRenderTree/gtk/EventSender.cpp:
3458         (keyDownCallback):
3459         * DumpRenderTree/qt/EventSenderQt.cpp:
3460         (EventSender::keyDown):
3461         * DumpRenderTree/win/EventSender.cpp:
3462         (keyDownCallback):
3463
3464 2011-02-18  Dirk Pranke  <dpranke@chromium.org>
3465
3466         Reviewed by Ojan Vafai.
3467
3468         new-run-webkit-tests: enable multiple processes by default on mac
3469         https://bugs.webkit.org/show_bug.cgi?id=54596
3470
3471         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3472         * Scripts/webkitpy/layout_tests/port/mac.py:
3473
3474 2011-02-18  Dirk Pranke  <dpranke@chromium.org>
3475
3476         Reviewed by Adam Roben.
3477
3478         Skip pretty patch unit tests if ruby isn't installed.
3479
3480         https://bugs.webkit.org/show_bug.cgi?id=54699
3481
3482         * Scripts/webkitpy/common/prettypatch_unittest.py:
3483
3484 2011-02-18  Dirk Pranke  <dpranke@chromium.org>
3485
3486         Reviewed by Adam Roben.
3487
3488         Skip mac.test_skipped_file_paths() when running on win32; the
3489         test has hardcoded '/' directory separators and since it's a
3490         port-specific test and we have coverage on other ports it's not
3491         worth it to make the test more generic.
3492
3493         https://bugs.webkit.org/show_bug.cgi?id=54698
3494
3495         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3496
3497 2011-02-18  Dirk Pranke  <dpranke@chromium.org>
3498
3499         Reviewed by Adam Roben.
3500
3501         Fix webkitpy.layout_tests.port.config_unittest to work on Win32.
3502
3503         https://bugs.webkit.org/show_bug.cgi?id=54703
3504
3505         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3506
3507 2011-02-18  Dirk Pranke  <dpranke@chromium.org>
3508
3509         Reviewed by Adam Roben.
3510
3511         Change the default port we're mocking out on win32 when we
3512         run mock_drt_unittest. Normally we'd default to the
3513         port-specific default, but that would be "win", which doesn't
3514         currently work.
3515
3516         https://bugs.webkit.org/show_bug.cgi?id=54708
3517
3518         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3519
3520 2011-02-18  Kenneth Russell  <kbr@google.com>
3521
3522         Reviewed by James Robinson.
3523
3524         [chromium] Clean up initialization of minimum timer interval
3525         https://bugs.webkit.org/show_bug.cgi?id=54772
3526
3527         Use new GetForegroundTabTimerInterval function in webkit_support
3528         to reset the minimum timer interval before each test.
3529
3530         * DumpRenderTree/chromium/WebViewHost.cpp:
3531         (WebViewHost::reset):
3532
3533 2011-02-18  Dirk Pranke  <dpranke@chromium.org>
3534
3535         Reviewed by Adam Roben.
3536
3537         r78494 fixed the chromium_win unittest failing under win32,
3538         but not cygwin. This fixes cygwin as well.
3539
3540         https://bugs.webkit.org/show_bug.cgi?id=54652
3541
3542         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3543
3544 2011-02-18  Dirk Pranke  <dpranke@chromium.org>
3545
3546         Reviewed by Ojan Vafai, Mihai Parparita.
3547
3548         new-run-webkit-tests: r78522 made it impossible to create a
3549         'chromium-win' or 'chromium-mac' port; they would always get the
3550         version tacked on to the end. It turns out that we actually need
3551         to be able to create these ports in order for
3552         rebaseline-chromium-webkit-tests to work correctly given the
3553         broken coverage of our layout bots. As soon as we get SL and
3554         Win 7 bots running reliably on the canaries, we can get rid of
3555         this change. Note that we only need to change the chromium_mac
3556         and win ports because linux doesn't yet use versions and that
3557         script doesn't work with non-chromium ports.
3558
3559         Also, this change fixes a bug where we were using
3560         "platform/chromium-win-win7" and
3561         "platform/chromium-mac-snowleopard" as the baseline dirs for
3562         Win 7 and SL; we should've been using the generic directories
3563         instead since they are the newest versions of the os's.
3564
3565         https://bugs.webkit.org/show_bug.cgi?id=54691
3566
3567         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3568         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3569         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3570         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3571         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3572
3573 2011-02-16  MORITA Hajime  <morrita@google.com>
3574
3575         Reviewed by Kent Tamura.
3576
3577         [Chromium][DRT] some PostDelayedTask() accesses possibly dangling this pointer.
3578         http://webkit.org/b/53899
3579
3580         Replaced static invocation wrappers with MethodTask objects,
3581         which are removed on WebViewHost destructor.
3582         
3583         * DumpRenderTree/chromium/WebViewHost.cpp:
3584         (WebViewHost::requestCheckingOfText):
3585         (WebViewHost::scheduleAnimation):
3586         (WebViewHost::closeWidgetSoon):
3587         * DumpRenderTree/chromium/WebViewHost.h:
3588         (WebViewHost::HostMethodTask::HostMethodTask):
3589         (WebViewHost::HostMethodTask::runIfValid):
3590         (WebViewHost::taskList):
3591
3592 2011-02-07  Hayato Ito  <hayato@chromium.org>
3593
3594         Reviewed by Ojan Vafai.
3595
3596         Get rid of code which writes test results from test_type's
3597         compare_output() method.
3598         Writing test results now happens in single_test_runner, using
3599         newly introduced test_result_writer module.
3600
3601         Subsequent patches will eliminate test_type/* classes.
3602
3603         https://bugs.webkit.org/show_bug.cgi?id=53908
3604
3605         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
3606         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py: Added.
3607         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
3608         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
3609         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3610
3611 2011-02-17  Dirk Pranke  <dpranke@chromium.org>
3612
3613         Reviewed by Adam Roben.
3614
3615         Add blacklist of remaining webkitpy/* modules that fail on
3616         Win32, so that test-webkitpy will at least run cleanly.
3617
3618         https://bugs.webkit.org/show_bug.cgi?id=54709
3619
3620         * Scripts/webkitpy/layout_tests/test/main.py:
3621
3622 2011-02-17  Simon Fraser  <simon.fraser@apple.com>
3623
3624         Reviewed by Sam Weinig.
3625
3626         Set a preference to ensure that scrollbars are in a predictable
3627         state for DRT.
3628
3629         * DumpRenderTree/mac/DumpRenderTree.mm:
3630         (resetDefaultsToConsistentValues):
3631
3632 2011-02-17  Dirk Pranke  <dpranke@chromium.org>
3633
3634         Reviewed by Adam Roben.
3635
3636         test-webkitpy doesn't work with the multiprocessing module on win32
3637         or cygwin, so we skip it for now.
3638
3639         https://bugs.webkit.org/show_bug.cgi?id=54520
3640
3641         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
3642         * Scripts/webkitpy/layout_tests/layout_package/run_webkit_tests_unittest.py:
3643
3644 2011-02-17  Dirk Pranke  <dpranke@chromium.org>
3645
3646         Reviewed by Adam Roben.
3647
3648         Fix version, baseline_search_path for chromium-win-win7. Also
3649         fix chromium_win_unittests, and fix port_testcase.make_port()
3650         to correctly use the options passed into it and only set
3651         results_directory() if necessary.
3652
3653         https://bugs.webkit.org/show_bug.cgi?id=54652
3654
3655         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3656         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3657         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3658
3659 2011-02-17  Dirk Pranke  <dpranke@chromium.org>
3660
3661         Reviewed by Ojan Vafai.
3662
3663         Fix a hang in new-run-webkit-tests when run with
3664         --dry-run --worker-model=processes
3665
3666         https://bugs.webkit.org/show_bug.cgi?id=54595
3667
3668         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
3669         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3670
3671 2011-02-17  Kevin Ollivier  <kevino@theolliviers.com>
3672
3673         [wx] Build fixes after recent changes.
3674
3675         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3676         (LayoutTestController::setMinimumTimerInterval):
3677         * wx/build/settings.py:
3678
3679 2011-02-17  Csaba Osztrogonác  <ossy@webkit.org>
3680
3681         Reviewed by Andreas Kling.
3682
3683         [Qt] ImageDiff sometimes hangs
3684         https://bugs.webkit.org/show_bug.cgi?id=54641
3685
3686         * DumpRenderTree/qt/ImageDiff.cpp: Clear actualImage and baselineImage after all comparison.
3687         (main):
3688
3689 2011-02-17  Peter Varga  <pvarga@webkit.org>
3690
3691         Reviewed by Csaba Osztrogonác.
3692
3693         The run-sunspider --v8-suite doesn't work
3694         https://bugs.webkit.org/show_bug.cgi?id=54660
3695
3696         * Scripts/run-sunspider:
3697
3698 2011-02-17  Gabor Rapcsanyi  <rgabor@webkit.org>
3699
3700         Reviewed by Csaba Osztrogonác.
3701
3702         [NRWT] Fix environment setup on Qt port.
3703         https://bugs.webkit.org/show_bug.cgi?id=54549
3704
3705         * Scripts/webkitpy/layout_tests/port/qt.py:
3706
3707 2011-02-16  Yael Aharon  <yael.aharon@nokia.com>
3708
3709         Reviewed by Andreas Kling.
3710
3711         [Qt] Enable tiled backing store by default in MiniBrowser.
3712         https://bugs.webkit.org/show_bug.cgi?id=54581
3713
3714         Instead of a flag to turn it on, a new flag is defined to turn
3715         tiled backing store off.
3716
3717         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3718         (MiniBrowserApplication::handleUserOptions):
3719         * MiniBrowser/qt/MiniBrowserApplication.h:
3720         (WindowOptions::WindowOptions):
3721
3722 2011-02-16  Eric Seidel  <eric@webkit.org>
3723
3724         Reviewed by Mihai Parparita.
3725
3726         flaky test archive uploads are always 22 bytes long
3727         https://bugs.webkit.org/show_bug.cgi?id=54593
3728
3729         Speculative fix for the 22-bytes bug.
3730
3731         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3732
3733 2011-02-16  Anna Cavender  <annacc@chromium.org>
3734
3735         Reviewed by Mihai Parparita.
3736
3737         http/tests/media should be served over HTTP (not from local file)
3738         https://bugs.webkit.org/show_bug.cgi?id=54028
3739
3740         Removed special file:// treatment of http/tests/media
3741
3742         * Scripts/old-run-webkit-tests:
3743         * Scripts/webkitpy/layout_tests/port/base.py:
3744
3745 2011-02-16  Mihai Parparita  <mihaip@chromium.org>
3746
3747         Reviewed by Ojan Vafai.
3748
3749         ChangeLog.parse_latest_entry_from_file does not handle rolled over ChangeLogs
3750         https://bugs.webkit.org/show_bug.cgi?id=54609
3751         
3752         r78737 rolled over ChangeLogs, and webkit-patch complains when landing
3753         patches such as this one that are the first to add an entry to the
3754         ChangeLog (since they don't see a second date line to know where the
3755         entry ends).
3756
3757         * Scripts/webkitpy/common/checkout/changelog.py:
3758         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3759
3760 == Rolled over to ChangeLog-2011-02-16 ==