Build bmalloc on Mac
[WebKit-https.git] / Tools / ChangeLog
1 2014-04-07  Geoffrey Garen  <ggaren@apple.com>
2
3         Build bmalloc on Mac
4         https://bugs.webkit.org/show_bug.cgi?id=131333
5
6         Reviewed by Mark Rowe.
7
8         * Scripts/build-webkit: Add the bmalloc target if we're on Mac.
9         (Note: Just testing Mac is not good enough because in this
10         script 'Mac' means 'Mac or iOS'.)
11
12 2014-03-30  Filip Pizlo  <fpizlo@apple.com>
13
14         Move slow JSRegress tests out of the way so that they don't show up in run-jsc-benchmarks runs and also skip tests that are extremely long-running
15         https://bugs.webkit.org/show_bug.cgi?id=130951
16
17         Reviewed by Geoffrey Garen.
18
19         * Scripts/run-javascriptcore-tests:
20
21 2014-04-06  Darin Adler  <darin@apple.com>
22
23         Rework CSS calc logic, fixing some reference count mistakes in Length
24         https://bugs.webkit.org/show_bug.cgi?id=131280
25
26         Reviewed by Andreas Kling.
27
28         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added CalculationValue.cpp.
29         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp: Added.
30
31 2014-04-04  Brian J. Burg  <burg@cs.washington.edu>
32
33         Enable WEB_REPLAY for PLATFORM(MAC)
34         https://bugs.webkit.org/show_bug.cgi?id=130700
35
36         Reviewed by Timothy Hatcher.
37
38         * Scripts/webkitperl/FeatureList.pm: Set the default for WEB_REPLAY for OS X engineering builds.
39
40 2014-04-05  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
41
42         [CMake] Include X11's include dirs in TestNetscapePlugin
43         https://bugs.webkit.org/show_bug.cgi?id=131270
44
45         Reviewed by Martin Robinson.
46
47         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Include X11_INCLUDE_DIR since
48         TestNetscapePlugin includes WebCore code that includes X headers.
49
50 2014-04-05  David Kilzer  <ddkilzer@apple.com>
51
52         REGRESSION (r166529): Fix build after renaming TileCache to LegacyTileCache
53         <http://webkit.org/b/130986>
54
55         * Scripts/check-for-inappropriate-objc-class-names: Add 'Legacy'
56         prefix to TileCache class names in exception list.
57
58 2014-04-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
59
60         [GTK] kill-old-processes should kill dbus-daemon processes
61         https://bugs.webkit.org/show_bug.cgi?id=127352
62
63         Reviewed by Martin Robinson.
64
65         * BuildSlaveSupport/kill-old-processes:
66         (main):
67
68 2014-04-04  Andres Gomez  <agomez@igalia.com>
69
70         [Win] Update obsolete packages in cygwin
71         https://bugs.webkit.org/show_bug.cgi?id=126264
72
73         Reviewed by Brent Fulgham.
74
75         Removed "apache" and "minires" as the first has been replaced by
76         "lighttpd" and the second is now integrated into
77         "cygwin". Replaced the transitional and now obsolete "gcc" package
78         with "gcc-g++" and ensure that "python" stays at version "2.6.8"
79         since the newer version available is "2.7.3" which breaks the
80         build due to some funniness with environment variable handling.
81
82         * CygwinDownloader/cygwin-downloader.py:
83         * CygwinDownloader/cygwin-downloader.zip:
84
85 2014-04-03  Joseph Pecoraro  <pecoraro@apple.com>
86
87         check-webkit-style: Improve warnings on Objective-C @property syntax
88         https://bugs.webkit.org/show_bug.cgi?id=131200
89
90         Reviewed by Dan Bernstein.
91
92         * Scripts/webkitpy/style/checkers/cpp.py:
93         (check_spacing):
94         (CppChecker):
95         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
96         (CppStyleTest.test_spacing_in_objective_c_properties):
97
98 2014-04-03  Santosh Mahto  <santoshbit2007@gmail.com>
99
100         Unreviewed. Moving my name to commiter section
101
102         * Scripts/webkitpy/common/config/contributors.json:
103
104 2014-04-03  Santosh Mahto  <santoshbit2007@gmail.com>
105
106         Unreviewed. Add myself as a committer.
107
108         * Scripts/webkitpy/common/config/contributors.json:
109
110 2014-04-03  Andrzej Badowski  <a.badowski@samsung.com>
111
112         [EFL][WK2] Replacing zoom functionality of MiniBrowser from scale_set to page_zoom_set.
113         https://bugs.webkit.org/show_bug.cgi?id=130391
114
115         Reviewed by Gyuyoung Kim.
116
117         Change the implementation of the zoom functionality from ewk_view_scale_set
118         to ewk_view_page_zoom_set.
119
120         * MiniBrowser/efl/main.c:
121
122 2014-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
123
124         [webkitpy] perf profiler does not understand --call-graph argument
125         https://bugs.webkit.org/show_bug.cgi?id=131132
126
127         Reviewed by Ryosuke Niwa.
128
129         New versions of perf profiler have changed the argument from --call-graph to -g.
130
131         * Scripts/webkitpy/common/system/profiler.py:
132         (Perf.wrapper_arguments): Use -g instead of --call-graph.
133         * Scripts/webkitpy/port/driver_unittest.py:
134         (DriverTest.test_profiler_as_wrapper): Update test accordingly.
135
136 2014-04-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
137
138         Add EFL WK2 performance bot to build.webkit.org
139         https://bugs.webkit.org/show_bug.cgi?id=131034
140
141         Fix after r166707, use "Perf" instead of "perf" for consistency.
142
143         Reviewed by Csaba Osztrogonác.
144
145         * BuildSlaveSupport/build.webkit.org-config/config.json:
146
147 2014-04-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
148
149         Add EFL WK2 performance bot to build.webkit.org
150         https://bugs.webkit.org/show_bug.cgi?id=131034
151
152         Reviewed by Csaba Osztrogonác.
153
154         * BuildSlaveSupport/build.webkit.org-config/config.json:
155
156 2014-04-02  Ryuan Choi  <ryuan.choi@samsung.com>
157
158         [EFL][WK1] Use Evas_Touch_Point_State instead of Ewk_Touch_Point_Type
159         https://bugs.webkit.org/show_bug.cgi?id=131151
160
161         Reviewed by Gyuyoung Kim.
162
163         * DumpRenderTree/efl/EventSender.cpp: Replace Ewk_Touch_Point_Type to Evas_Touch_Point_State.
164         (TouchEventInfo::TouchEventInfo):
165         (sendTouchEvent):
166         (addTouchPointCallback):
167         (updateTouchPointCallback):
168         (cancelTouchPointCallback):
169         (releaseTouchPointCallback):
170
171 2014-04-02  David Kilzer  <ddkilzer@apple.com>
172
173         filter-build-webkit: Ignore xcodebuild warnings when compiling with newer builds of clang
174         <http://webkit.org/b/131045>
175
176         Reviewed by Daniel Bates.
177
178         * Scripts/filter-build-webkit:
179         (shouldIgnoreLine): Ignore DVTAssertions related to new builds
180         of clang, plus debug data for all DVTAssertions.
181
182 2014-04-01  Dean Jackson  <dino@apple.com>
183
184         Load Media Controls js/css from bundle
185         https://bugs.webkit.org/show_bug.cgi?id=131086
186
187         Reviewed by Eric Carlson.
188
189         We're now putting CSS files into the bundle, so remove the test for them.
190
191         * Scripts/check-for-inappropriate-files-in-framework:
192
193 2014-04-02  Martin Hock  <mhock@apple.com>
194
195         Unify private browsing with sessions.
196         https://bugs.webkit.org/show_bug.cgi?id=130099
197
198         Reviewed by Alexey Proskuryakov.
199
200         Add an API test for ephemeral sessions similar to PrivateBrowsingPushStateNoHistoryCallback.
201         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
202         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
203         (TestWebKitAPI::didNavigateWithNavigationData):
204         (TestWebKitAPI::didSameDocumentNavigationForFrame):
205         (TestWebKitAPI::TEST):
206
207         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp: Also test to make sure private browsing can be disabled.
208         (TestWebKitAPI::didNavigateWithoutNavigationData):
209         (TestWebKitAPI::didNavigateWithNavigationData):
210         (TestWebKitAPI::didSameDocumentNavigationForFrame):
211         (TestWebKitAPI::TEST):
212
213 2014-04-02  Martin Robinson  <mrobinson@igalia.com>
214
215         REGRESSION(r165704): [GTK] Inspector resources not correctly generated
216         https://bugs.webkit.org/show_bug.cgi?id=130343
217
218         Reviewed by Gustavo Noronha Silva.
219
220         * gtk/generate-inspector-gresource-manifest.py: Instead of hard-coding the file list, accept a list
221         of directories on the command line and look for all appropriate files in those directories for the
222         GResource archive. Also make archive paths relative to those directories.
223         (find_all_files_in_directory): This helper looks for all the appropriate files in a given directory.
224         (find_all_files_in_directory.select_file): Whether or not to add the file to the archive.
225
226 2014-04-02  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
227
228         [webkitpy] Avoid multiple "Preparing rollout for bug" log messages
229         https://bugs.webkit.org/show_bug.cgi?id=131106
230
231         Reviewed by Csaba Osztrogonác.
232
233         * Scripts/webkitpy/tool/commands/download.py:
234         (AbstractRolloutPrepCommand._prepare_state):
235         * Scripts/webkitpy/tool/commands/download_unittest.py:
236         (test_prepare_rollout):
237         (test_create_rollout):
238         (test_create_rollout_resolved):
239         (test_rollout):
240
241 2014-04-02  Krzysztof Wolanski  <k.wolanski@samsung.com>
242
243         [EFL] Add option to use separate web process for new window in MiniBrowser
244         https://bugs.webkit.org/show_bug.cgi?id=130190
245
246         Reviewed by Gyuyoung Kim.
247
248         New created window (CTRL + n) will be open in separated web process.
249         This option is enabled by adding a flag (S/separate-process) with launching
250         MiniBrowser.
251
252         * MiniBrowser/efl/main.c:
253         (elm_main):
254
255 2014-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
256
257         [GTK] Move NEWS file to a new location
258         https://bugs.webkit.org/show_bug.cgi?id=130901
259
260         Reviewed by Brent Fulgham.
261
262         * gtk/manifest.txt: Update the NEWS file path.
263
264 2014-04-01  Anders Carlsson  <andersca@apple.com>
265
266         Fix build.
267
268         * MiniBrowser/mac/WK2BrowserWindowController.m:
269         (-[WK2BrowserWindowController awakeFromNib]):
270         (-[WK2BrowserWindowController dealloc]):
271         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
272
273 2014-04-01  Brent Fulgham  <bfulgham@apple.com>
274
275         Unreviewed test gardening.
276
277         * Scripts/webkitpy/port/base_unittest.py:
278         (PortTest.test_build_path): Handle the Debug case so we don't get webkitpy-test failures on our test bots.
279
280 2014-04-01  Zoltan Horvath  <zoltan@webkit.org>
281
282         [CSS Exclusions] Remove exclusions parsing support
283         https://bugs.webkit.org/show_bug.cgi?id=131046
284
285         Reviewed by David Hyatt.
286
287         * Scripts/webkitperl/FeatureList.pm:
288
289 2014-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
290
291         [GTK] Remove last reference to GTK+ WK1 EWS
292         https://bugs.webkit.org/show_bug.cgi?id=131058
293
294         Reviewed by Martin Robinson.
295
296         In r166427 WK1 GTK+ bots and EWS where removed, but this file was missing.
297
298         * QueueStatusServer/config/queues.py: Remove reference to GTK+ WK1 EWS.
299
300 2014-04-01  Lucas Forschler  <lforschler@apple.com>
301
302         Add a 32bit JSC builder/tester.
303         https://bugs.webkit.org/show_bug.cgi?id=131054
304         
305         Reviewed by Michael Saboff.
306
307         * BuildSlaveSupport/build.webkit.org-config/config.json:
308         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
309         (Compile32bitJSC):
310         (Run32bitJSCTests):
311         (Run32bitJSCTests.countFailures):
312         (BuildAndTest32bitJSCFactory):
313         (BuildAndTest32bitJSCFactory.__init__):
314
315 2014-04-01  Martin Robinson  <mrobinson@igalia.com>
316
317         [GTK] No longer build WebKit1 gtkdoc
318         https://bugs.webkit.org/show_bug.cgi?id=130970
319
320         Reviewed by Anders Carlsson.
321
322         * gtk/common.py:
323         (gtk_version_of_pkg_config_file): Deleted.
324         * gtk/generate-gtkdoc:
325         (get_gtkdoc_module_paths): We no longer need to worry about GTK+ 2, since it
326         was only applicable for WebKit1.
327         (get_generator_for_config): No longer look for the WebKit1 configuration file.
328
329 2014-04-01  Mario Sanchez Prada  <mario.prada@samsung.com>
330
331         [GTK] Running minibrowser with url crashes in debug build
332         https://bugs.webkit.org/show_bug.cgi?id=130492
333
334         Reviewed by Martin Robinson.
335
336         Update "uri-scheme" test not to use invalid URIs in it, so we
337         don't get a mistmatch when comparing the original URI stored in
338         the test class with the one returned by the WebKitWebView.
339
340         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
341         (testWebContextURIScheme): Update the test.
342
343 2014-04-01  Mihai Tica  <mitica@adobe.com>
344
345         Unreviewed: Add myself as a commiter to the contributors list.
346
347         * Scripts/webkitpy/common/config/contributors.json:
348
349 2014-03-31  Ryuan Choi  <ryuan.choi@samsung.com>
350
351         [EFL][WK2] Extract the control of page background out of color_set
352         https://bugs.webkit.org/show_bug.cgi?id=127539
353
354         Reviewed by Gyuyoung Kim.
355
356         Added an option(C) to change background color.
357
358         * MiniBrowser/efl/main.c:
359         (window_create):
360         (elm_main):
361
362 2014-03-31  Ryuan Choi  <ryuan.choi@samsung.com>
363
364         Unreviewed build fix on the EFL port with latest EFL libraries since r166149
365
366         * ImageDiff/PlatformEfl.cmake: Added ECORE_IMF_INCLUDE_DIRS to include dirs
367
368 2014-03-31  Brent Fulgham  <bfulgham@apple.com>
369
370         Unreviewed test correction after r166530.
371
372         * DumpRenderTree/mac/DumpRenderTree.mm:
373         (setDefaultsToConsistentValuesForTesting): No need to change preference for all tests. We set the proper
374         fine-grained setting for swipe tests. This prevents existing tests from breaking.
375
376 2014-03-31  Carlos Alberto Lopez Perez  <clopez@igalia.com>
377
378         Remove the trigger for webkit1 tests on the gtk-linux-64-release bot
379         https://bugs.webkit.org/show_bug.cgi?id=130987
380
381         r166427 removed the WebKit1 GTK+ bots, so we don't longer need to
382         trigger the webkit1 bot tests on the gtk-linux-64-release bot.
383
384         Reviewed by Martin Robinson.
385
386         * BuildSlaveSupport/build.webkit.org-config/config.json:
387
388 2014-03-31  Dean Jackson  <dino@apple.com>
389
390         Remove WEB_ANIMATIONS
391         https://bugs.webkit.org/show_bug.cgi?id=130989
392
393         Reviewed by Simon Fraser.
394
395         Remove this feature flag until we plan to implement.
396
397         * Scripts/webkitperl/FeatureList.pm:
398
399 2014-03-31  Brent Fulgham  <bfulgham@apple.com>
400
401         Reduced Latched Scroll Test Flakiness
402         https://bugs.webkit.org/show_bug.cgi?id=130983
403
404         Reviewed by Darin Adler.
405
406         * DumpRenderTree/mac/DumpRenderTree.mm:
407         (setDefaultsToConsistentValuesForTesting): Test user should have 'high resolution' scrolling.
408         * DumpRenderTree/mac/EventSendingController.mm:
409         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]): Generate mouse wheel events
410         with high resolution flags turned on.
411         * WebKitTestRunner/mac/EventSenderProxy.mm:
412         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Ditto.
413
414 2014-03-31  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
415
416         run-webkit-tests should have a --no-timeout option
417         https://bugs.webkit.org/show_bug.cgi?id=128286
418
419         Reviewed by Joseph Pecoraro.
420
421         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
422         (Worker._run_test): Renaming _run_test_with_timeout()
423         (Worker._run_test_with_or_without_timeout): Renaming _run_test_with_timeout(), because tests can now run without timeout.
424         (Worker._run_test_in_another_thread): Passing the --no-timeout option to the driver
425         (Worker._run_test_in_this_thread):
426         (Worker._run_test_with_timeout): Deleted.
427         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
428         (parse_args): Added the --no-timeout option
429
430 2014-03-31  Samuel White  <samuel_white@apple.com>
431
432         AX: Need ability to get line range for text marker.
433         https://bugs.webkit.org/show_bug.cgi?id=130906
434
435         Reviewed by Chris Fleizach.
436
437         Added a new function in DRT and TestRunner to test that AXLineTextMarkerRangeForTextMarker works as expected.
438
439         * DumpRenderTree/AccessibilityUIElement.cpp:
440         (lineTextMarkerRangeForTextMarkerCallback):
441         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
442         (AccessibilityUIElement::getJSClass):
443         * DumpRenderTree/AccessibilityUIElement.h:
444         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
445         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
446         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
447         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
448         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
449         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
450         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
451         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
452         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
453         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
454         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
455         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
456
457 2014-03-31  Filip Pizlo  <fpizlo@apple.com>
458
459         More validation for FTL inline caches
460         https://bugs.webkit.org/show_bug.cgi?id=130948
461
462         Reviewed by Geoffrey Garen.
463
464         * Scripts/run-jsc-stress-tests:
465
466 2014-03-31  Carlos Garcia Campos  <cgarcia@igalia.com>
467
468         [GTK] Do not run WebKit1 unit tests by default
469         https://bugs.webkit.org/show_bug.cgi?id=130968
470
471         Reviewed by Martin Robinson.
472
473         * Scripts/run-gtk-tests:
474         (TestRunner):
475
476 2014-03-31  Martin Robinson  <mrobinson@igalia.com>
477
478         [GTK] Remove scripts code only applicable to autotools
479         https://bugs.webkit.org/show_bug.cgi?id=130841
480
481         Reviewed by Anders Carlsson.
482
483         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
484         (_should_file_trigger_build): Update file list to reflect GTK+ CMake port.
485         * Scripts/webkitpy/common/config/watchlist: Remove the GTK+ build watchlist.
486         * Scripts/webkitpy/style/checker.py: The GNUmakefile doesn't exist any longer.
487         * gtk/find-make-dist-errors: Removed.
488         * gtk/generate-feature-defines-files: Removed.
489         * gtk/manifest.txt: No longer need to consider autotools files.
490
491 2014-03-30  Andy Estes  <aestes@apple.com>
492
493         Fix two failing layout tests on Mountain Lion after r166466.
494
495         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
496         (-[DownloadDelegate _downloadDidStart:]):
497
498 2014-03-30  Andy Estes  <aestes@apple.com>
499
500         [Cocoa] Add an originatingWebView property to _WKDownload
501         https://bugs.webkit.org/show_bug.cgi?id=130945
502
503         Reviewed by Anders Carlsson.
504
505         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
506         (-[DownloadDelegate _downloadDidStart:]):
507         (-[OriginatingWebViewDownloadDelegate initWithWebView:]):
508         (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
509         (TEST):
510
511 2014-03-28  Filip Pizlo  <fpizlo@apple.com>
512
513         Land the stackmap register liveness glue with the uses of the liveness disabled
514         https://bugs.webkit.org/show_bug.cgi?id=130924
515
516         Reviewed by Oliver Hunt.
517
518         * Scripts/run-jsc-stress-tests:
519
520 2014-03-29  Alexey Proskuryakov  <ap@apple.com>
521
522         Update WebKit1.StringTruncator for Mountain Lion.
523
524         * TestWebKitAPI/Tests/mac/StringTruncator.mm: Looks like one subtest was failing
525         due to different font metrics on 10.8.
526
527 2014-03-28  Darin Adler  <darin@apple.com>
528
529         Fix recently-introduced off-by-one error in centerTruncateToBuffer
530         https://bugs.webkit.org/show_bug.cgi?id=130889
531
532         Reviewed by Alexey Proskuryakov.
533
534         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added StringTruncator.mm.
535         * TestWebKitAPI/Tests/mac/StringTruncator.mm: Added. One test for each of the
536         WebStringTruncator methods; should be good for a start. These are dependent on the
537         metrics of Helvetica 12, but I am hoping that will be consistent across OS X machines.
538
539 2014-03-28  Martin Hock  <mhock@apple.com>
540
541         Unreviewed. Add myself as a committer.
542
543         * Scripts/webkitpy/common/config/contributors.json:
544
545 2014-03-28  Martin Robinson  <mrobinson@igalia.com>
546
547         Remove WebKit1 GTK+ bots
548         https://bugs.webkit.org/show_bug.cgi?id=130904
549
550         Reviewed by Anders Carlsson.
551
552         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove references to GTK+ WebKit1 test bot and ensure
553         all bots are testing WebKit2 only.
554         * Scripts/webkitpy/common/config/ews.json: Remove references to GTK+ WK1 EWS.
555         * Scripts/webkitpy/common/config/ports.py: Remove references to GTK+ WK1 bots.
556         * Scripts/webkitpy/common/config/ports_unittest.py: Ditto.
557         * Scripts/webkitpy/port/builders.py: Ditto.
558         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Ditto.
559         * TestResultServer/static-dashboards/builders.jsonp: Ditto.
560
561 2014-03-28  Timothy Hatcher  <timothy@apple.com>
562
563         Remove Brian Burg's apple.com email address.
564
565         * Scripts/webkitpy/common/config/contributors.json:
566
567 2014-03-28  David Kilzer  <ddkilzer@apple.com>
568
569         bisect-builds should print Trac 'changeset' URL if only one build is detected
570         <http://webkit.org/b/130903>
571
572         Reviewed by Dan Bernstein.
573
574         * Scripts/bisect-builds:
575         (printTracLink): Print a direct link to the Trac 'changeset'
576         URL if there is only one revision in the range.
577
578 2014-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
579
580         [EFL] Bump glib version from 2.36 to 2.38 
581         https://bugs.webkit.org/show_bug.cgi?id=130886
582
583         Reviewed by Csaba Osztrogonác.
584
585         There is a build break on EFL port when using glib 2.36 ver. To fix it,
586         we need to bump glib version up to 2.38 as gtk port.
587
588         * efl/jhbuild.modules:
589
590 2014-03-27  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
591
592         <https://webkit.org/b/42704> WebKitTestRunner needs to print history delegate information
593
594         Provide an implementation of WKContextHistoryClient that logs when called for tests in
595         the globalhistory directory.
596
597         Reviewed by Sam Weinig.
598
599         * WebKitTestRunner/TestController.cpp:
600         (WTR::TestController::TestController):
601         (WTR::TestController::initialize): Set the history client.
602         (WTR::TestController::resetStateToConsistentValues): Disable logging of history client callbacks.
603         (WTR::TestController::didNavigateWithNavigationData): Log information about the navigation. Some portions
604         of the output are hard-coded to match WebKit1's results for now since they're fixed in our existing tests
605         and we don't yet have API to access the data in question.
606         (WTR::TestController::didPerformClientRedirect):
607         (WTR::TestController::didPerformServerRedirect):
608         (WTR::TestController::didUpdateHistoryTitle):
609         * WebKitTestRunner/TestController.h:
610         (WTR::TestController::setShouldLogHistoryClientCallbacks):
611         * WebKitTestRunner/TestInvocation.cpp:
612         (WTR::shouldLogHistoryClientCallbacks): Log history client callbacks for tests in a globalhistory directory.
613         (WTR::TestInvocation::invoke):
614
615 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
616
617         Revert http://trac.webkit.org/changeset/166386 because it broke builds.
618
619         * Scripts/build-webkit:
620         * Scripts/copy-webkitlibraries-to-product-directory:
621
622 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
623
624         Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
625         https://bugs.webkit.org/show_bug.cgi?id=130867
626         <rdar://problem/16432456> 
627
628         Reviewed by Mark Hahnenberg.
629
630         * Scripts/build-webkit:
631         * Scripts/copy-webkitlibraries-to-product-directory:
632
633 2014-03-26  Andy Estes  <aestes@apple.com>
634
635         [Cocoa] Expose DownloadClient::didFail() and DownloadClient::didCancel()
636         https://bugs.webkit.org/show_bug.cgi?id=130805
637
638         Reviewed by Dan Bernstein.
639
640         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
641         (-[DownloadDelegate _download:didReceiveResponse:]):
642         (-[DownloadDelegate _downloadDidFinish:]):
643         (runTest):
644         (TEST):
645         (-[FailingDownloadDelegate _downloadDidFinish:]):
646         (-[FailingDownloadDelegate _download:didFailWithError:]):
647         (-[FailingDownloadDelegate _downloadDidCancel:]):
648         (-[CancelledDownloadDelegate _downloadDidStart:]):
649         (-[CancelledDownloadDelegate _downloadDidFinish:]):
650         (-[CancelledDownloadDelegate _download:didFailWithError:]):
651         (-[CancelledDownloadDelegate _downloadDidCancel:]):
652         (-[DownloadDelegate initWithSourceURL:]): Deleted.
653         (-[DownloadDelegate sourceURL]): Deleted.
654         (runTestWithNavigationDelegate): Deleted.
655
656 2014-03-26  Anders Carlsson  <andersca@apple.com>
657
658         Change MiniBrowser to hold on to window controllers instead of windows
659         https://bugs.webkit.org/show_bug.cgi?id=130797
660
661         Reviewed by Oliver Hunt.
662
663         * MiniBrowser/mac/AppDelegate.h:
664         * MiniBrowser/mac/AppDelegate.m:
665         (-[BrowserAppDelegate init]):
666         (-[BrowserAppDelegate newWindow:]):
667         (-[BrowserAppDelegate browserWindowWillClose:]):
668         (-[BrowserAppDelegate applicationWillTerminate:]):
669         (-[BrowserAppDelegate frontmostBrowserWindowController]):
670
671 2014-03-26  Commit Queue  <commit-queue@webkit.org>
672
673         Unreviewed, rolling out r166264.
674         https://bugs.webkit.org/show_bug.cgi?id=130785
675
676         Broke some window.opener tests for WK2 Mavericks (Requested by
677         brrian__ on #webkit).
678
679         Reverted changeset:
680
681         "Web Replay: resource unique identifiers should be unique-per-
682         frame, not globally"
683         https://bugs.webkit.org/show_bug.cgi?id=130632
684         http://trac.webkit.org/changeset/166264
685
686 2014-03-26  Zoltan Horvath  <zoltan@webkit.org>
687
688         [CSS Shapes] Remove shape-inside support
689         https://bugs.webkit.org/show_bug.cgi?id=130698
690
691         Reviewed by David Hyatt.
692
693         * Scripts/webkitperl/FeatureList.pm:
694
695 2014-02-27  Gurpreet Kaur  <k.gurpreet@samsung.com>
696
697         Unreviewed. Add myself as a committer.
698
699         * Scripts/webkitpy/common/config/contributors.json:
700
701 2014-03-26  Tomas Popela  <tpopela@redhat.com>
702
703         run-launcher is Perl script so use elsif and not elif
704         https://bugs.webkit.org/show_bug.cgi?id=130771
705
706         Reviewed by Carlos Garcia Campos.
707
708         * Scripts/run-launcher:
709
710 2014-03-26  Krzysztof Czech  <k.czech@samsung.com>
711
712         [ATK] Utilize new AtkValue interface coming in ATK 2.11.92
713         https://bugs.webkit.org/show_bug.cgi?id=130575
714
715         Reviewed by Mario Sanchez Prada.
716
717         Change ATK version to 2.11.92. Adjust current implementation.
718
719         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
720         (AccessibilityUIElement::intValue):
721         (AccessibilityUIElement::minValue):
722         (AccessibilityUIElement::maxValue):
723         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
724         (WTR::AccessibilityUIElement::intValue):
725         (WTR::AccessibilityUIElement::minValue):
726         (WTR::AccessibilityUIElement::maxValue):
727         * efl/jhbuild.modules:
728         * gtk/jhbuild.modules:
729
730 2014-03-12  Philippe Normand  <pnormand@igalia.com>
731
732         [GTK] The gnumake package is no longer needed in jhbuild
733         https://bugs.webkit.org/show_bug.cgi?id=130121
734
735         Reviewed by Martin Robinson.
736
737         For GTK build-webkit now relies on cmake and ninja/gnumake. Even
738         for a debug build cmake/system-gnumake worked just fine for me.
739
740         * gtk/jhbuild.modules: Removed gnumake.
741         * gtk/patches/make-3.82-arg-list-length.patch: Removed.
742         * gtk/patches/make-3.82-parallel-build.patch: Removed.
743
744 2014-03-25  Andy Estes  <aestes@apple.com>
745
746         Fix a failing API test on Mountain Lion and remove temporary debug logging.
747
748         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
749         (-[DownloadDelegate _download:didReceiveData:]):
750         (-[DownloadDelegate _downloadDidFinish:]):
751
752 2014-03-25  Brian Burg  <bburg@apple.com>
753
754         Web Replay: resource unique identifiers should be unique-per-frame, not globally
755         https://bugs.webkit.org/show_bug.cgi?id=130623
756
757         Reviewed by Timothy Hatcher.
758
759         The resource loader callback dumping routines assumed that resource identifiers
760         were globally unique. Its map of resource identifiers to URLs must also track the
761         frame associated with the resource.
762
763         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
764         (WTR::dumpResourceURL): Additionally take a WKBundleFrameRef argument, and use the
765         opaque pointer as part of the key for assignedUrlsCache. The frame pointer is
766         stable as long as the frame is valid.
767         (WTR::InjectedBundlePage::didInitiateLoadForResource):
768         (WTR::InjectedBundlePage::willSendRequestForFrame):
769         (WTR::InjectedBundlePage::didReceiveResponseForResource):
770         (WTR::InjectedBundlePage::didFinishLoadForResource):
771         (WTR::InjectedBundlePage::didFailLoadForResource):
772
773 2014-03-25  Andy Estes  <aestes@apple.com>
774
775         Fix one API test expectation failure on Mountain Lion, and add additional logging to help diagnose another.
776
777         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
778         (-[DownloadDelegate _download:didReceiveResponse:]):
779         (-[DownloadDelegate _download:didReceiveData:]):
780
781 2014-03-25  Andy Estes  <aestes@apple.com>
782
783         Add some debug logging to an API test that's failing on Mountain Lion.
784
785         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
786         (-[DownloadDelegate _download:didReceiveResponse:]):
787         (-[DownloadDelegate _downloadDidFinish:]):
788
789 2014-03-25  Anders Carlsson  <andersca@apple.com>
790
791         Add goBack: and goForward: IBActions and move stopLoading: to a new WKIBActions category on WKWebView
792         https://bugs.webkit.org/show_bug.cgi?id=130732
793
794         Reviewed by Tim Horton.
795
796         * MiniBrowser/mac/WK2BrowserWindowController.m:
797         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
798
799 2014-03-25  Martin Robinson  <mrobinson@igalia.com>
800
801         [GTK] Remove the autotools build
802         https://bugs.webkit.org/show_bug.cgi?id=130717
803
804         Reviewed by Anders Carlsson.
805
806         * DumpRenderTree/config.h: Remove references to the autotools configure file.
807         * GNUmakefile.am: Removed.
808         * GtkLauncher/GNUmakefile.am: Removed.
809         * GtkLauncher/main.c: Remove references to the autotools configure file.
810         * MiniBrowser/gtk/BrowserDownloadsBar.c: Ditto.
811         * MiniBrowser/gtk/BrowserSearchBar.c: Ditto.
812         * MiniBrowser/gtk/BrowserWindow.c: Ditto.
813         * MiniBrowser/gtk/GNUmakefile.am: Removed.
814         * MiniBrowser/gtk/main.c: Remove references to the autotools configure file.
815         * Scripts/build-webkit: No longer handle autotools.
816         * Scripts/run-gtk-tests: Ditto.
817         (TestRunner._setup_testing_environment):
818         * Scripts/run-launcher: Ditto.
819         * Scripts/webkitdirs.pm: Ditto.
820         * Scripts/webkitpy/common/config/contributionareas.py: Remove autotools as a contribution area.
821         * Scripts/webkitpy/common/config/contributors.json: Ditto.
822         * Scripts/webkitpy/port/gtk.py: No longer handle autotools.
823         * Scripts/webkitpy/style/checker.py:
824         * TestWebKitAPI/GNUmakefile.am: Removed.
825         * TestWebKitAPI/config.h: Remove references to the autotools configure file.
826         * WebKitTestRunner/GNUmakefile.am: Removed.
827         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Ditto.
828         * gtk/GNUmakefile.am: Removed.
829         * gtk/common.py: Remove checks for the autotools build.
830         * gtk/symbols.filter: Renamed from Source/autotools/symbols.filter.
831
832 2014-03-25  László Langó  <llango.u-szeged@partner.samsung.com>
833
834         prepare-ChangeLog throws false positive warnings for modified files.
835         https://bugs.webkit.org/show_bug.cgi?id=130687
836
837         Reviewed by Darin Adler.
838
839         * Scripts/prepare-ChangeLog:
840         (originalFile): Ignore git commit paremeter.
841         We don't need this to get the unmodified file.
842         (extractLineRangeBeforeChange):
843         Simplify the if statement. Follow-up after r166189.
844
845 2014-03-25  Gabor Rapcsanyi  <rgabor@webkit.org>
846
847         [EFL] Add ARM64 build support
848         https://bugs.webkit.org/show_bug.cgi?id=130506
849
850         Rubber stamped by Gyuyoung Kim.
851
852         * Scripts/webkitdirs.pm:
853         (isARM): Detect aarch64 as ARM.
854
855 2014-03-25  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
856
857         [webkitpy] Improve _parse_bug_description to recognize more descriptions
858         https://bugs.webkit.org/show_bug.cgi?id=130137
859
860         Reviewed by Csaba Osztrogonác.
861
862         * Scripts/webkitpy/common/checkout/changelog.py:
863         (ChangeLogEntry._parse_bug_description):
864         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
865         (test_parse_log_entries_from_changelog):
866         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
867         (CheckoutTest.test_commit_info_for_revision):
868
869 2014-03-24  Andy Estes  <aestes@apple.com>
870
871         Fix the iOS build of TestWebKitAPI.
872
873         * TestWebKitAPI/Configurations/Base.xcconfig:
874         * TestWebKitAPI/PlatformUtilities.h:
875
876 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
877
878         Fix prepare-ChangeLog after r166156.
879         https://bugs.webkit.org/show_bug.cgi?id=130674
880
881         Reviewed by Darin Adler.
882
883         * Scripts/prepare-ChangeLog:
884         (generateFunctionLists):
885         (extractLineRangeBeforeChange):
886
887 2014-03-24  Andy Estes  <aestes@apple.com>
888
889         [iOS] Download support by CFURLDownloadRef under USE(CFNETWORK).
890         https://bugs.webkit.org/show_bug.cgi?id=129322
891
892         Reviewed by Anders Carlsson.
893
894         Add an API test suite for _WKDownload.
895
896         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
897         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm: Added.
898         (-[DownloadDelegate initWithSourceURL:]):
899         (-[DownloadDelegate sourceURL]):
900         (-[DownloadDelegate _downloadDidStart:]):
901         (-[DownloadDelegate _download:didReceiveResponse:]):
902         (-[DownloadDelegate _download:didReceiveData:]):
903         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
904         (-[DownloadDelegate _downloadDidFinish:]):
905         (TEST):
906         (runTestWithNavigationDelegate):
907         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
908         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
909
910 2014-03-24  Joseph Pecoraro  <pecoraro@apple.com>
911
912         filter-build-webkit: reduce unfiltered output
913         https://bugs.webkit.org/show_bug.cgi?id=130485
914
915         Reviewed by Brent Fulgham.
916
917         * Scripts/filter-build-webkit:
918         (shouldIgnoreLine):
919
920 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
921
922         prepare-ChangeLog should list functions that have been removed too.
923         https://bugs.webkit.org/show_bug.cgi?id=130508
924
925         Reviewed by Darin Adler.
926
927         The prepare-ChangeLog does not list the deleted functions in the Changelog.
928         We have to read the functions and the line ranges of them from the source
929         before the change, then search for overlaps between them and the changed
930         line ranges from diff.
931
932         * Scripts/prepare-ChangeLog:
933         (originalFile): Get original source command.
934         (generateFunctionLists): Collect deleted functions too.
935         (generateFunctionListsByRanges): Duplicated code is moved to a separate subroutine.
936         (extractLineRangeBeforeChange): Extract line ranges from the original source to get
937         deleted functions ranges too.
938         (extractLineRange): Renamed to extractLineRangeAfterChange.
939
940 2014-03-23  Hyowon Kim  <hw1008.kim@samsung.com>
941
942         Move all EFL typedefs into EflTypedefs.h.
943         https://bugs.webkit.org/show_bug.cgi?id=130511
944
945         Reviewed by Gyuyoung Kim.
946
947         * TestWebKitAPI/PlatformWebView.h: Remove EFL typedefs.
948         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
949         * WebKitTestRunner/PlatformWebView.h: Ditto.
950
951 2014-03-21  Simon Fraser  <simon.fraser@apple.com>
952
953         Don't flush compositing layers within FrameView::willPaintContents()
954         https://bugs.webkit.org/show_bug.cgi?id=130627
955         <rdar://problem/16368869>
956
957         Reviewed by Sam Weinig.
958         
959         Fix DRT to correctly render tests with layers now that FrameView::paintContents
960         does not flush.
961         
962         Move the -[WebView displayIfNeeded] from -[FrameLoadDelegate webView:didFinishLoadForFrame:]
963         into an explicit function called before dumping. 
964         
965         Then explicitly call _flushCompositingChanges to ensure that GraphicsLayer changes
966         are flushed to CA. They will be pushed to the window by snapshotting.
967
968         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
969         Fix weird path to IOKit.framework.
970         * DumpRenderTree/mac/DumpRenderTree.mm:
971         (updateDisplay):
972         (dump):
973         * DumpRenderTree/mac/FrameLoadDelegate.mm:
974         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]): Fix parameter name.
975         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): Remove display call.
976
977 2014-03-21  David Kilzer  <ddkilzer@apple.com>
978
979         fix-blink-patch: tool to fix up renamed directory paths in Blink
980         <http://webkit.org/b/130609>
981
982         Reviewed by Ryosuke Niwa.
983
984         Usage: cat blink.patch | fix-blink-patch | svn-apply
985
986         * Scripts/fix-blink-patch: Added.
987
988 2014-03-21  Darin Adler  <darin@apple.com>
989
990         Remove use of deprecatedCharacters in WebKit API tests
991         https://bugs.webkit.org/show_bug.cgi?id=130602
992
993         Reviewed by Antti Koivisto.
994
995         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
996         (TestWebKitAPI::expectBuilderContent): Use characters8/16 instead of deprecatedCharacters.
997         (TestWebKitAPI::expectEmpty): Use characters8.
998         (TestWebKitAPI::TEST): Use characters8 instead of deprecatedCharacters in most cases.
999
1000         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1001         Removed the test that is entirely about 16-bit conversion since that's basically a test of
1002         the deprecatedCharacters function itself, which we are about to delete.
1003
1004 2014-03-21  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1005
1006         [webkitpy] Fix has_valid_reviewer()
1007         https://bugs.webkit.org/show_bug.cgi?id=130589
1008
1009         Reviewed by Csaba Osztrogonác.
1010
1011         * Scripts/webkitpy/common/checkout/changelog.py:
1012         (ChangeLogEntry.has_valid_reviewer):
1013         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1014         (test_has_valid_reviewer):
1015         * Scripts/webkitpy/common/config/committers.py:
1016         (CommitterList._reviewer_only):
1017         (CommitterList.committer_by_name):
1018         (CommitterList.reviewer_by_email):
1019         (CommitterList):
1020         (CommitterList.reviewer_by_name):
1021
1022 2014-03-21  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
1023
1024         Add cache support for jhbuild
1025         https://bugs.webkit.org/show_bug.cgi?id=130588
1026
1027         Reviewed by Csaba Osztrogonác.
1028
1029         * jhbuild/jhbuildrc_common.py:
1030         (init): Jhbuild can now save the dependencies locally, if the JHBUILD_MIRROR environment variable is set.
1031
1032 2014-03-21  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1033
1034         [CMake] Add support for MAX_CPU_LOAD translated to -l in ninja and make
1035         https://bugs.webkit.org/show_bug.cgi?id=130504
1036
1037         Reviewed by Martin Robinson.
1038
1039         * Scripts/build-webkit: Add the maxCPULoad() to the makeArgs in
1040         CMake if not specified.
1041         * Scripts/webkitdirs.pm:
1042         (determineMaxCPULoad): Read MAX_CPU_LOAD as maxCPULoad.
1043         (maxCPULoad): determineMaxCPULoad and return maxCPULoad.
1044
1045 2014-03-21  Andreas Kling  <akling@apple.com>
1046
1047         RetainPtr API test should use CFArray instead of CFString for testing.
1048         <rdar://problem/16384899>
1049
1050         Unreviewed bot fix.
1051
1052         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
1053         (TestWebKitAPI::TEST):
1054         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
1055         (TestWebKitAPI::TEST):
1056
1057 2014-03-20  Hyowon Kim  <hw1008.kim@samsung.com>
1058
1059         Move to using std::unique_ptr for EFL objects.
1060         https://bugs.webkit.org/show_bug.cgi?id=129853
1061
1062         Reviewed by Gyuyoung Kim.
1063
1064         EflUniquePtr is a template alias of std::unique_ptr
1065         with a custom deleter for each Efl Objects, which is motivated by GUniquePtr.
1066         This patch replaces uses of OwnPtr and PassOwnPtr for Efl objects with EflUniquePtr.
1067
1068         * DumpRenderTree/efl/DumpRenderTree.cpp:
1069         (main):
1070         * ImageDiff/efl/ImageDiff.cpp:
1071         (initEfl):
1072         (main):
1073
1074 2014-03-20  Ryuan Choi  <ryuan.choi@samsung.com>
1075
1076         Unreviewed buildfix after r165983 for non Cocoa platforms
1077
1078         Renamed WKPreferencesPrivate.h to WKPreferencesRefPrivate.h
1079
1080         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
1081         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
1082         * WebKitTestRunner/TestController.cpp:
1083
1084 2014-03-20  Zan Dobersek  <zdobersek@igalia.com>
1085
1086         [GTK][CMake] Add support for building with Clang
1087         https://bugs.webkit.org/show_bug.cgi?id=130260
1088
1089         Reviewed by Martin Robinson.
1090
1091         * TestWebKitAPI/CMakeLists.txt: When building with Clang TestWebKitAPI should be
1092         built with GTEST_HAS_TR1_TUPLE defined to 0 to avoid build failures occuring in the
1093         included GTest framework headers.
1094         * gtk/generate-gtkdoc:
1095         (prepare_environment_for_gtkdoc_generation): Don't modify the CFLAGS env anymore
1096         in case of using Clang since that is now set by the CMake rule.
1097
1098 2014-03-19  Simon Fraser  <simon.fraser@apple.com>
1099
1100         Expose text and page zoom in WK2 SPI, and hook them up in MiniBrowser
1101         https://bugs.webkit.org/show_bug.cgi?id=130476
1102
1103         Reviewed by Anders Carlsson.
1104         
1105         Hook up page/text zoom in MiniBrowser, make reload work, remove some logging.
1106
1107         * MiniBrowser/mac/WK1BrowserWindowController.m:
1108         (-[WK1BrowserWindowController webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
1109         Remove log.
1110         * MiniBrowser/mac/WK2BrowserWindowController.m:
1111         (-[WK2BrowserWindowController awakeFromNib]):
1112         (-[WK2BrowserWindowController validateMenuItem:]):
1113         (-[WK2BrowserWindowController reload:]):
1114         Hook up reload.
1115         (-[WK2BrowserWindowController toggleZoomMode:]):
1116         (-[WK2BrowserWindowController resetZoom:]):
1117         (-[WK2BrowserWindowController canResetZoom]):
1118         (-[WK2BrowserWindowController currentZoomFactor]):
1119         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
1120         (-[WK2BrowserWindowController canZoomIn]):
1121         (-[WK2BrowserWindowController canZoomOut]):
1122
1123 2014-03-19  Alexey Proskuryakov  <ap@apple.com>
1124
1125         REGRESSION (OS X 10.9.2): PageVisibilityStateWithWindowChanges.WebKit2 API test fails
1126         https://bugs.webkit.org/show_bug.cgi?id=130463
1127
1128         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm: Disable the test.
1129
1130 2014-03-18  Samuel White  <samuel_white@apple.com>
1131
1132         AX: Not able to use arrow keys to read text with VoiceOver before selection is set someplace (anyplace).
1133         https://bugs.webkit.org/show_bug.cgi?id=130250
1134
1135         Reviewed by Chris Fleizach.
1136
1137         Added ability to toggle enhanced accessibility on and off to support tests that require it.
1138
1139         * DumpRenderTree/AccessibilityController.cpp:
1140         (enableEnhancedAccessibilityCallback):
1141         (getEnhancedAccessibilityEnabledCallback):
1142         (AccessibilityController::getJSClass):
1143         * DumpRenderTree/AccessibilityController.h:
1144         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
1145         (AccessibilityController::enableEnhancedAccessibility):
1146         (AccessibilityController::enhancedAccessibilityEnabled):
1147         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
1148         (AccessibilityController::enableEnhancedAccessibility):
1149         (AccessibilityController::enhancedAccessibilityEnabled):
1150         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1151         (AccessibilityController::enableEnhancedAccessibility):
1152         (AccessibilityController::enhancedAccessibilityEnabled):
1153         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1154         (AccessibilityController::enableEnhancedAccessibility):
1155         (AccessibilityController::enhancedAccessibilityEnabled):
1156         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1157         (WTR::AccessibilityController::enableEnhancedAccessibility):
1158         (WTR::AccessibilityController::enhancedAccessibilityEnabled):
1159         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
1160         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
1161
1162 2014-03-18  Filip Pizlo  <fpizlo@apple.com>
1163
1164         Unreviewed, add some contributors, and fix Nadav's entry (he's not really a reviewer
1165         yet).
1166
1167         * Scripts/webkitpy/common/config/contributors.json:
1168
1169 2014-03-18  Joseph Pecoraro  <pecoraro@apple.com>
1170
1171         Web Inspector: Remove stale ReportMemoryUsagePlugin
1172         https://bugs.webkit.org/show_bug.cgi?id=130405
1173
1174         Reviewed by Andreas Kling.
1175
1176         This clang plugin looks like it was used for the old Inspector memory
1177         instrumentation that was removed. So the tool can be removed.
1178
1179         * clang/ReportMemoryUsagePlugin/CMakeLists.txt: Removed.
1180         * clang/ReportMemoryUsagePlugin/Makefile: Removed.
1181         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp: Removed.
1182         * clang/ReportMemoryUsagePlugin/tests/Source/WebCore/Test.cpp: Removed.
1183
1184 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1185
1186         webkit-patch land shouldn't add a reviewer for unreviewed build fixes
1187         https://bugs.webkit.org/show_bug.cgi?id=130220
1188
1189         Reviewed by Csaba Osztrogonác.
1190
1191         * Scripts/webkitpy/common/checkout/changelog.py:
1192         (ChangeLog.set_reviewer):
1193         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1194         (test_set_reviewer):
1195
1196 2014-03-17  Filip Pizlo  <fpizlo@apple.com>
1197
1198         More FTL enabling.
1199
1200         Rubber stamped by Dan Bernstein.
1201
1202         * Tools/Scripts/build-webkit:
1203
1204 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
1205
1206         Renable pagination mode in WK2 MiniBrowser
1207         https://bugs.webkit.org/show_bug.cgi?id=130374
1208
1209         Reviewed by Anders Carlsson.
1210         
1211         Put the implementation of togglePaginationMode: back, and correctly
1212         enable the menu item.
1213
1214         * MiniBrowser/mac/WK2BrowserWindowController.m:
1215         (-[WK2BrowserWindowController validateMenuItem:]):
1216         (-[WK2BrowserWindowController isPaginated]):
1217         (-[WK2BrowserWindowController togglePaginationMode:]):
1218
1219 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1220
1221         Add --reset option to Tools/Scripts/set-webkit-configuration script
1222         https://bugs.webkit.org/show_bug.cgi?id=130401
1223
1224         Reviewed by Csaba Osztrogonác.
1225
1226         * Scripts/set-webkit-configuration:
1227
1228 2014-03-18  Alberto Garcia  <berto@igalia.com>
1229
1230         [GTK] [CMake] build-webkit-options.txt is not generated during a fresh build
1231         https://bugs.webkit.org/show_bug.cgi?id=130388
1232
1233         Reviewed by Sergio Villar Senin.
1234
1235         * Scripts/webkitdirs.pm:
1236         (shouldRemoveCMakeCache): make sure that the build directory
1237         exists before attempting to create a file in it.
1238
1239 2014-03-18  Robert Plociennik  <r.plociennik@samsung.com>
1240
1241         [EFL] fontconfig-2.8.0 is not compliant with C++11 leading to a build break
1242         https://bugs.webkit.org/show_bug.cgi?id=130336
1243
1244         Reviewed by Gyuyoung Kim.
1245
1246         Compilation with gcc 4.8.x results in 'invalid suffix on literal; C++11
1247         requires a space between literal and string macro [-Wliteral-suffix]'
1248         warning treated as error.
1249
1250         This patch applies a solution from r162448 to the EFL port.
1251
1252         * efl/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
1253         * efl/jhbuild.modules: Added appropriate patch section.
1254
1255 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
1256
1257         webkitpy test rebaseline.
1258
1259         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1260         (MainTest.test_default_args):
1261
1262 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
1263
1264         --profile should imply --test-runner-count=1 in run-perf-tests
1265         https://bugs.webkit.org/show_bug.cgi?id=130375
1266
1267         Reviewed by Benjamin Poulain.
1268
1269         Use the test runner count of 1 when --profile is specified but not --test-runner-count.
1270
1271         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1272         (PerfTestsRunner._parse_args): Use -1 as the default value.
1273         (PerfTestsRunner._collect_tests): If --test-runner-count is set (i.e. it's a positive value),
1274         then use that value. Otherwise, if it's never set and --profile is present, test-runner-count
1275         should be 1.
1276
1277 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
1278
1279         Address some style nits.
1280
1281         * MiniBrowser/mac/WK2BrowserWindowController.m:
1282
1283 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
1284
1285         Add transparent window support back into MiniBrowser
1286         https://bugs.webkit.org/show_bug.cgi?id=130363
1287
1288         Reviewed by Anders Carlsson.
1289         
1290         Re-enable transparent window support for WK2.
1291
1292         * MiniBrowser/mac/WK2BrowserWindowController.m:
1293         (-[WK2BrowserWindowController validateMenuItem:]):
1294         (-[WK2BrowserWindowController toggleTransparentWindow:]):
1295
1296 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
1297
1298         Fix the 32-bit build; make the open panel make a WK1 window.
1299
1300         * MiniBrowser/mac/AppDelegate.m:
1301         (-[BrowserAppDelegate openDocument:]):
1302
1303 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
1304
1305         Convert MiniBrowser to use WKWebView API
1306         https://bugs.webkit.org/show_bug.cgi?id=130061
1307
1308         Reviewed by Anders Carlsson.
1309         
1310         Convert the MiniBrowser WK2 window to use WebKit2 API as much
1311         as possible.
1312         
1313         Some functionality was removed temporarily:
1314             - text zoom, page zoom
1315             - reload
1316             - pagination mode
1317             - transparent window
1318             - dumping source
1319             - window.open support
1320             - beforeUnload panel
1321             - find in page
1322
1323         * MiniBrowser/mac/AppDelegate.h:
1324         * MiniBrowser/mac/AppDelegate.m:
1325         (-[BrowserAppDelegate init]):
1326         (-[BrowserAppDelegate newWindow:]):
1327         (-[BrowserAppDelegate applicationWillTerminate:]):
1328         (-[BrowserAppDelegate openDocument:]):
1329         * MiniBrowser/mac/WK2BrowserWindowController.h:
1330         * MiniBrowser/mac/WK2BrowserWindowController.m:
1331         (-[WK2BrowserWindowController awakeFromNib]):
1332         (-[WK2BrowserWindowController dealloc]):
1333         (-[WK2BrowserWindowController fetch:]):
1334         (-[WK2BrowserWindowController validateMenuItem:]):
1335         (-[WK2BrowserWindowController reload:]):
1336         (-[WK2BrowserWindowController goBack:]):
1337         (-[WK2BrowserWindowController goForward:]):
1338         (-[WK2BrowserWindowController toggleZoomMode:]):
1339         (-[WK2BrowserWindowController resetZoom:]):
1340         (-[WK2BrowserWindowController canResetZoom]):
1341         (-[WK2BrowserWindowController dumpSourceToConsole:]):
1342         (-[WK2BrowserWindowController togglePaginationMode:]):
1343         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
1344         (-[WK2BrowserWindowController windowShouldClose:]):
1345         (-[WK2BrowserWindowController applicationTerminating]):
1346         (-[WK2BrowserWindowController currentZoomFactor]):
1347         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
1348         (-[WK2BrowserWindowController toggleTransparentWindow:]):
1349         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
1350         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1351         (-[WK2BrowserWindowController webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
1352         (-[WK2BrowserWindowController webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
1353         (-[WK2BrowserWindowController find:]):
1354         (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
1355         (-[WK2BrowserWindowController webView:didStartProvisionalNavigation:]):
1356         (-[WK2BrowserWindowController webView:didReceiveServerRedirectForProvisionalNavigation:]):
1357         (-[WK2BrowserWindowController webView:didFailProvisionalNavigation:withError:]):
1358         (-[WK2BrowserWindowController webView:didCommitNavigation:]):
1359         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
1360         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
1361         * WebKitTestRunner/PlatformWebView.h:
1362         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1363         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1364
1365 2014-03-17  Zan Dobersek  <zdobersek@igalia.com>
1366
1367         Use RunLoop objects through references instead of pointers
1368         https://bugs.webkit.org/show_bug.cgi?id=130313
1369
1370         Reviewed by Andreas Kling.
1371
1372         Adjust the code accordingly now that RunLoop::current() and RunLoop::main()
1373         return RunLoop reference instead of a pointer.
1374
1375         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp:
1376         (loadedCallback):
1377         (clickedCallback):
1378
1379 2014-03-17  Tim Horton  <timothy_horton@apple.com>
1380
1381         sort-export-file --help doesn't work (missing 'use')
1382         https://bugs.webkit.org/show_bug.cgi?id=130338
1383
1384         Reviewed by Anders Carlsson.
1385
1386         * Scripts/sort-export-file:
1387         Add a missing 'use', and fix a typo in an error message.
1388
1389 2014-03-17  Martin Robinson  <mrobinson@igalia.com>
1390
1391         [GTK][CMake] Ensure that HAVE_GTK_UNIX_PRINTING is defined when appropriate
1392         https://bugs.webkit.org/show_bug.cgi?id=130155
1393
1394         Reviewed by Philippe Normand.
1395
1396         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Add GTK_UNIX_PRINT flags to the build.
1397
1398 2014-03-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1399
1400         [GTK] MiniBrowser fails to load injected bundle lib
1401         https://bugs.webkit.org/show_bug.cgi?id=130332
1402
1403         Reviewed by Anders Carlsson.
1404
1405         This is because WEBKIT_INJECTED_BUNDLE_PATH env var is set too late.
1406
1407         * MiniBrowser/gtk/main.c:
1408         (main): Make sure WEBKIT_INJECTED_BUNDLE_PATH is set before a web
1409         process is spawn.
1410
1411 2014-03-16  Kim Byung Jun  <bj1987.kim@samsung.com>
1412
1413         [EFL] Enable TOUCH_SLIDER macro
1414         https://bugs.webkit.org/show_bug.cgi?id=130185
1415
1416         Reviewed by Gyuyoung Kim.
1417
1418         * Scripts/webkitperl/FeatureList.pm:
1419
1420 2014-03-16  Zan Dobersek  <zdobersek@igalia.com>
1421
1422         [GTK][CMake] Build with -fno-rtti
1423         https://bugs.webkit.org/show_bug.cgi?id=130261
1424
1425         Reviewed by Martin Robinson.
1426
1427         * TestWebKitAPI/CMakeLists.txt: Build TestWebKitAPI with GTEST_HAS_RTTI macro
1428         defined to 0 to prevent typeid use in included GTest headers.
1429
1430 2014-03-16  Brian Burg  <bburg@apple.com>
1431
1432         Web Inspector: vended backend commands file should be generated as part of the build
1433         https://bugs.webkit.org/show_bug.cgi?id=130110
1434
1435         Reviewed by Timothy Hatcher.
1436
1437         * Scripts/build-webkit: build WebInspectorUI after WebCore but before WebKit.
1438
1439 2014-03-16  Diego Pino García  <dpino@igalia.com>
1440
1441         [GTK] Minibrowser: Add shortcuts for reloading page and reloading page ignoring cache
1442         https://bugs.webkit.org/show_bug.cgi?id=128999
1443
1444         Reviewed by Philippe Normand.
1445
1446         * MiniBrowser/gtk/BrowserWindow.c:
1447         (reloadPage):
1448         (reloadPageIgnoringCache):
1449         (browser_window_init):
1450
1451 2014-03-15  Martin Robinson  <mrobinson@igalia.com>
1452
1453         [GTK] Improve ninja detection in webkitdirs.pm
1454         https://bugs.webkit.org/show_bug.cgi?id=129902
1455
1456         Reviewed by Daniel Bates.
1457
1458         * Scripts/webkitdirs.pm:
1459         (canUseNinja): Use which instead of trying to invoke ninja directly. This also allows
1460         us to look for ninja-build as well.
1461
1462 2014-03-14  Maciej Stachowiak  <mjs@apple.com>
1463
1464         Replace "Apple Computer, Inc." with "Apple Inc." in copyright headers
1465         https://bugs.webkit.org/show_bug.cgi?id=130276
1466         <rdar://problem/16266927>
1467         
1468         Reviewed by Simon Fraser.
1469
1470         * BuildSlaveSupport/build-launcher-app:
1471         * BuildSlaveSupport/build-launcher-dmg:
1472         * DumpRenderTree/DumpRenderTree.h:
1473         * DumpRenderTree/DumpRenderTreePrefix.h:
1474         * DumpRenderTree/GCController.cpp:
1475         * DumpRenderTree/GCController.h:
1476         * DumpRenderTree/JavaScriptThreading.cpp:
1477         * DumpRenderTree/JavaScriptThreading.h:
1478         * DumpRenderTree/PixelDumpSupport.cpp:
1479         * DumpRenderTree/PixelDumpSupport.h:
1480         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
1481         * DumpRenderTree/TestRunner.cpp:
1482         * DumpRenderTree/TestRunner.h:
1483         * DumpRenderTree/WorkQueue.cpp:
1484         * DumpRenderTree/WorkQueue.h:
1485         * DumpRenderTree/WorkQueueItem.h:
1486         * DumpRenderTree/atk/AccessibilityCallbacks.h:
1487         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
1488         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
1489         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
1490         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1491         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1492         * DumpRenderTree/efl/EditingCallbacks.cpp:
1493         * DumpRenderTree/efl/EditingCallbacks.h:
1494         * DumpRenderTree/efl/EventSender.cpp:
1495         * DumpRenderTree/efl/EventSender.h:
1496         * DumpRenderTree/efl/GCControllerEfl.cpp:
1497         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
1498         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1499         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1500         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
1501         * DumpRenderTree/gtk/EditingCallbacks.cpp:
1502         * DumpRenderTree/gtk/EditingCallbacks.h:
1503         * DumpRenderTree/gtk/EventSender.cpp:
1504         * DumpRenderTree/gtk/EventSender.h:
1505         * DumpRenderTree/gtk/GCControllerGtk.cpp:
1506         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1507         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp:
1508         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h:
1509         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1510         * DumpRenderTree/gtk/TextInputController.cpp:
1511         * DumpRenderTree/gtk/TextInputController.h:
1512         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL:
1513         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm:
1514         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
1515         * DumpRenderTree/mac/AppleScriptController.h:
1516         * DumpRenderTree/mac/AppleScriptController.m:
1517         * DumpRenderTree/mac/CheckedMalloc.cpp:
1518         * DumpRenderTree/mac/CheckedMalloc.h:
1519         * DumpRenderTree/mac/DumpRenderTree.mm:
1520         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
1521         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1522         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1523         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
1524         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
1525         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1526         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1527         * DumpRenderTree/mac/EditingDelegate.h:
1528         * DumpRenderTree/mac/EditingDelegate.mm:
1529         * DumpRenderTree/mac/EventSendingController.h:
1530         * DumpRenderTree/mac/EventSendingController.mm:
1531         * DumpRenderTree/mac/FrameLoadDelegate.h:
1532         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1533         * DumpRenderTree/mac/GCControllerMac.mm:
1534         * DumpRenderTree/mac/MockWebNotificationProvider.h:
1535         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
1536         * DumpRenderTree/mac/NavigationController.h:
1537         * DumpRenderTree/mac/NavigationController.m:
1538         * DumpRenderTree/mac/ObjCController.h:
1539         * DumpRenderTree/mac/ObjCController.m:
1540         * DumpRenderTree/mac/ObjCPlugin.h:
1541         * DumpRenderTree/mac/ObjCPlugin.m:
1542         * DumpRenderTree/mac/ObjCPluginFunction.h:
1543         * DumpRenderTree/mac/ObjCPluginFunction.m:
1544         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1545         * DumpRenderTree/mac/PolicyDelegate.h:
1546         * DumpRenderTree/mac/PolicyDelegate.mm:
1547         * DumpRenderTree/mac/ResourceLoadDelegate.h:
1548         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1549         * DumpRenderTree/mac/TestRunnerMac.mm:
1550         * DumpRenderTree/mac/TextInputController.h:
1551         * DumpRenderTree/mac/TextInputController.m:
1552         * DumpRenderTree/mac/UIDelegate.h:
1553         * DumpRenderTree/mac/UIDelegate.mm:
1554         * DumpRenderTree/mac/WorkQueueItemMac.mm:
1555         * DumpRenderTree/win/DRTDataObject.cpp:
1556         * DumpRenderTree/win/DRTDataObject.h:
1557         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
1558         * DumpRenderTree/win/DRTDropSource.cpp:
1559         * DumpRenderTree/win/DRTDropSource.h:
1560         * DumpRenderTree/win/DraggingInfo.h:
1561         * DumpRenderTree/win/DumpRenderTree.cpp:
1562         * DumpRenderTree/win/DumpRenderTreeWin.h:
1563         * DumpRenderTree/win/EditingDelegate.cpp:
1564         * DumpRenderTree/win/EditingDelegate.h:
1565         * DumpRenderTree/win/EventSender.cpp:
1566         * DumpRenderTree/win/EventSender.h:
1567         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1568         * DumpRenderTree/win/FrameLoadDelegate.h:
1569         * DumpRenderTree/win/GCControllerWin.cpp:
1570         * DumpRenderTree/win/HistoryDelegate.cpp:
1571         * DumpRenderTree/win/HistoryDelegate.h:
1572         * DumpRenderTree/win/MD5.cpp:
1573         * DumpRenderTree/win/MD5.h:
1574         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
1575         * DumpRenderTree/win/PolicyDelegate.cpp:
1576         * DumpRenderTree/win/PolicyDelegate.h:
1577         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1578         * DumpRenderTree/win/ResourceLoadDelegate.h:
1579         * DumpRenderTree/win/TestRunnerWin.cpp:
1580         * DumpRenderTree/win/TextInputController.cpp:
1581         * DumpRenderTree/win/TextInputController.h:
1582         * DumpRenderTree/win/TextInputControllerWin.cpp:
1583         * DumpRenderTree/win/UIDelegate.cpp:
1584         * DumpRenderTree/win/UIDelegate.h:
1585         * DumpRenderTree/win/WorkQueueItemWin.cpp:
1586         * EWebLauncher/main.c:
1587         * GtkLauncher/main.c:
1588         * ImageDiff/efl/ImageDiff.cpp:
1589         * ImageDiff/gtk/ImageDiff.cpp:
1590         * MiniBrowser/gtk/main.c:
1591         * Scripts/SpacingHeuristics.pm:
1592         * Scripts/VCSUtils.pm:
1593         * Scripts/bisect-builds:
1594         * Scripts/build-dumprendertree:
1595         * Scripts/build-jsc:
1596         * Scripts/build-webkit:
1597         * Scripts/check-dom-results:
1598         * Scripts/check-for-exit-time-destructors:
1599         * Scripts/check-for-global-initializers:
1600         * Scripts/commit-log-editor:
1601         * Scripts/compare-timing-files:
1602         * Scripts/debug-minibrowser:
1603         * Scripts/debug-safari:
1604         * Scripts/do-file-rename:
1605         * Scripts/find-extra-includes:
1606         * Scripts/generate-coverage-data:
1607         * Scripts/make-script-test-wrappers:
1608         * Scripts/malloc-tree:
1609         * Scripts/old-run-webkit-tests:
1610         * Scripts/parse-malloc-history:
1611         * Scripts/report-include-statistics:
1612         * Scripts/resolve-ChangeLogs:
1613         * Scripts/run-bindings-tests:
1614         * Scripts/run-iexploder-tests:
1615         * Scripts/run-javascriptcore-tests:
1616         * Scripts/run-jsc:
1617         * Scripts/run-launcher:
1618         * Scripts/run-leaks:
1619         * Scripts/run-mangleme-tests:
1620         * Scripts/run-minibrowser:
1621         * Scripts/run-pageloadtest:
1622         * Scripts/run-regexp-tests:
1623         * Scripts/run-safari:
1624         * Scripts/run-sunspider:
1625         * Scripts/run-webkit-app:
1626         * Scripts/sampstat:
1627         * Scripts/set-webkit-configuration:
1628         * Scripts/sort-Xcode-project-file:
1629         * Scripts/sort-export-file:
1630         * Scripts/split-file-by-class:
1631         * Scripts/sunspider-compare-results:
1632         * Scripts/svn-apply:
1633         * Scripts/svn-create-patch:
1634         * Scripts/svn-unapply:
1635         * Scripts/test-webkit-scripts:
1636         * Scripts/update-javascriptcore-test-results:
1637         * Scripts/update-webkit:
1638         * Scripts/update-webkit-auxiliary-libs:
1639         * Scripts/update-webkit-dependency:
1640         * Scripts/update-webkit-localizable-strings:
1641         * Scripts/update-webkit-support-libs:
1642         * Scripts/update-webkit-wincairo-libs:
1643         * Scripts/webkit-build-directory:
1644         * Scripts/webkitdirs.pm:
1645         (installedSafariPath):
1646         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
1647         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
1648         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
1649         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
1650         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
1651         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
1652         * Scripts/webkitperl/features.pm:
1653         * Scripts/webkitperl/httpd.pm:
1654         * Scripts/webkitpy/bindings/main.py:
1655         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
1656         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
1657         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1658         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
1659         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
1660         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
1661         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
1662         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1663         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1664         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.h:
1665         * WebKitTestRunner/PixelDumpSupport.cpp:
1666         * WebKitTestRunner/PixelDumpSupport.h:
1667         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1668         * WinLauncher/WinLauncher.cpp:
1669         * WinLauncher/WinLauncher.h:
1670         * WinLauncher/stdafx.cpp:
1671         * WinLauncher/stdafx.h:
1672
1673 2014-03-14  Filip Pizlo  <fpizlo@apple.com>
1674
1675         Sometimes we need to be explicit about the SDK when running ranlib on Darwin
1676         https://bugs.webkit.org/show_bug.cgi?id=130265
1677
1678         Reviewed by Michael Saboff.
1679
1680         * Scripts/build-webkit:
1681         * Scripts/copy-webkitlibraries-to-product-directory:
1682
1683 2014-03-14  Landry Breuil  <landry@openbsd.org>
1684
1685         Recognize openbsd/netbsd and am64 archs in Tools/Scripts.
1686         Also allow to set MAKE in the environment.
1687         https://bugs.webkit.org/show_bug.cgi?id=129991
1688
1689         Reviewed by Andreas Kling.
1690
1691         * Scripts/webkitdirs.pm:
1692         (determineArchitecture):
1693         (determineNumberOfCPUs):
1694         (isBSD):
1695         (buildAutotoolsProject):
1696         * Scripts/webkitpy/common/system/platforminfo.py:
1697         (PlatformInfo.__init__):
1698         (PlatformInfo.is_openbsd):
1699         (PlatformInfo):
1700         (PlatformInfo.is_netbsd):
1701         (PlatformInfo._determine_os_name):
1702
1703 2014-03-14  Dean Jackson  <dino@apple.com>
1704
1705         Remove libWebKitSystemInterfaceLion.a
1706         https://bugs.webkit.org/show_bug.cgi?id=130254
1707
1708         Reviewed by Geoffrey Garen and Andreas Kling.
1709
1710         No need to copy the Lion libraries into the build.
1711
1712         * Scripts/copy-webkitlibraries-to-product-directory:
1713
1714 2014-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
1715
1716         [EFL][MiniBrowser] Revise help messages of command line parameters
1717         https://bugs.webkit.org/show_bug.cgi?id=130222
1718
1719         Reviewed by Csaba Osztrogonác.
1720
1721         Correct the default value description and make help messages to be consistent.
1722
1723         * MiniBrowser/efl/main.c:
1724
1725 2014-03-12  Sergio Villar Senin  <svillar@igalia.com>
1726
1727         Rename DEFINE_STATIC_LOCAL to DEPRECATED_DEFINE_STATIC_LOCAL
1728         https://bugs.webkit.org/show_bug.cgi?id=129612
1729
1730         Reviewed by Darin Adler.
1731
1732         For new code use static NeverDestroyed<T> instead.
1733
1734         * DumpRenderTree/JavaScriptThreading.cpp:
1735         (javaScriptThreadsMutex):
1736         (javaScriptThreads):
1737         * DumpRenderTree/efl/EventSender.cpp:
1738         (touchPointList):
1739         (delayedEventQueue):
1740         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1741         (delegatesWithDelayedWork):
1742         * Scripts/check-for-exit-time-destructors:
1743         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp:
1744         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
1745         (testsMap):
1746
1747 2014-03-13  Sanghyup Lee  <sh53.lee@samsung.com>
1748
1749         [EFL][WK2] Fix compilation warning in Minibrowser
1750         https://bugs.webkit.org/show_bug.cgi?id=130132
1751
1752         Reviewed by Csaba Osztrogonác.
1753
1754         Replace mktemp() with mkstemp() to fix compilation warning in MiniBrowser.
1755
1756         * MiniBrowser/efl/main.c:
1757         (on_download_request):
1758
1759 2014-03-13  Filip Pizlo  <fpizlo@apple.com>
1760
1761         FTL should support IsBlah
1762         https://bugs.webkit.org/show_bug.cgi?id=130202
1763
1764         Reviewed by Geoffrey Garen.
1765         
1766         Running existing JSRegress tests with noInline gives us coverage for these
1767         changes. Chances are, this will also give coverage for other interesting things
1768         as well.
1769
1770         * Scripts/run-jsc-stress-tests:
1771
1772 2014-03-12  Brian Burg  <bburg@apple.com>
1773
1774         Web Inspector: Remove unused callId parameter from evaluateInWebInspector
1775         https://bugs.webkit.org/show_bug.cgi?id=129744
1776
1777         Reviewed by Timothy Hatcher.
1778
1779         * DumpRenderTree/TestRunner.cpp:
1780         (evaluateInWebInspectorCallback):
1781         * DumpRenderTree/TestRunner.h:
1782         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1783         (TestRunner::evaluateInWebInspector):
1784         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1785         (TestRunner::evaluateInWebInspector):
1786         * DumpRenderTree/mac/TestRunnerMac.mm:
1787         (TestRunner::evaluateInWebInspector):
1788         * DumpRenderTree/win/TestRunnerWin.cpp:
1789         (TestRunner::evaluateInWebInspector):
1790         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1791         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1792         (WTR::TestRunner::evaluateInWebInspector):
1793         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1794
1795 2014-03-13  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
1796
1797         [GTK] build-webkit shouldn't show error message when ninja isn't installed
1798         https://bugs.webkit.org/show_bug.cgi?id=130129
1799
1800         Reviewed by Csaba Osztrogonác.
1801
1802         * Scripts/webkitdirs.pm:
1803         (canUseNinja): Redirecting stderr to /dev/null
1804
1805 2014-03-13  Andres Gomez  <agomez@igalia.com>
1806
1807         [GTK] "Tools/jhbuild/jhbuild-wrapper --gtk" build fails even after running Tools/gtk/install-dependencies due to missing proper libxml2 python bindings
1808         https://bugs.webkit.org/show_bug.cgi?id=130092
1809
1810         Reviewed by Csaba Osztrogonác.
1811
1812         Added "python-dev" as dependency for deb based distros. It is
1813         already present for rpm based distros. This dependency will allow
1814         libxml2 to generate its python bindings, needed by gtk-doc.
1815
1816         * gtk/install-dependencies:
1817
1818 2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1819
1820         Unreviewed. Fix GTK+ cmake build after r165488.
1821
1822         * MiniBrowser/gtk/CMakeLists.txt: Add CMAKE_BINARY_DIR to include dirs.
1823
1824 2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1825
1826         [GTK][CMAKE] Remove compile warnings about GTK+ deprecated API
1827         https://bugs.webkit.org/show_bug.cgi?id=130014
1828
1829         Reviewed by Martin Robinson.
1830
1831         Include cmake or autotools config header.
1832
1833         * MiniBrowser/gtk/BrowserDownloadsBar.c:
1834         * MiniBrowser/gtk/BrowserSearchBar.c:
1835         * MiniBrowser/gtk/BrowserWindow.c:
1836         * MiniBrowser/gtk/main.c:
1837
1838 2014-03-12  Commit Queue  <commit-queue@webkit.org>
1839
1840         Unreviewed, rolling out r165471.
1841         https://bugs.webkit.org/show_bug.cgi?id=130139
1842
1843         Didn't really fix the issue and broke another bot (Requested
1844         by mrobinson on #webkit).
1845
1846         Reverted changeset:
1847
1848         "[CMake] Newer versions of CMake cannot find older versions of
1849         Freetype"
1850         https://bugs.webkit.org/show_bug.cgi?id=130107
1851         http://trac.webkit.org/changeset/165471
1852
1853 2014-03-11  Filip Pizlo  <fpizlo@apple.com>
1854
1855         It should be possible to build WebKit with FTL on iOS
1856         https://bugs.webkit.org/show_bug.cgi?id=130116
1857
1858         Reviewed by Dan Bernstein.
1859
1860         * Scripts/build-webkit:
1861         * Scripts/copy-webkitlibraries-to-product-directory:
1862
1863 2014-03-12  Brent Fulgham  <bfulgham@apple.com>
1864
1865         [Win] Remove use of QTSDK
1866         https://bugs.webkit.org/show_bug.cgi?id=130049
1867
1868         Reviewed by Darin Adler.
1869
1870         * DumpRenderTree/win/DumpRenderTree.cpp:
1871         (initialize): Remove QuickTime code.
1872         * win/AssembleBuildLogs/AssembleLogs.cmd: Don't grab logs from
1873         building QTMovieWin.
1874
1875 2014-03-12  Martin Robinson  <mrobinson@igalia.com>
1876
1877         [GTK][CMAKE] Too verbose build output
1878         https://bugs.webkit.org/show_bug.cgi?id=130076
1879
1880         Reviewed by Carlos Garcia Campos.
1881
1882         Instead of building with cmake --build which isn't smart about pretty printing and
1883         colors, we build with a script which calls the proper build command.
1884
1885         * Scripts/webkitdirs.pm:
1886         (buildCMakeGeneratedProject): For GTK+ call the script that we generate during
1887         the CMake configuration pass.
1888
1889 2014-03-11  Martin Robinson  <mrobinson@igalia.com>
1890
1891         [CMake] Newer versions of CMake cannot find older versions of Freetype
1892         https://bugs.webkit.org/show_bug.cgi?id=130107
1893
1894         Reviewed by Gustavo Noronha Silva.
1895
1896         * gtk/jhbuildrc: Work around a bug in newer CMakes by giving the FREETYPE_DIR hint
1897         to CMake during jhbuild initialization.
1898
1899 2014-03-12  Zalan Bujtas  <zalan@apple.com>
1900
1901         Add hiDPI support for compositing content in DumpRenderTree/WebKitTestRunner
1902         https://bugs.webkit.org/show_bug.cgi?id=129961
1903
1904         Reviewed by Simon Fraser.
1905
1906         Now scaled content can go through the window capturing mechanism too for compositing content.
1907         AppleMagnifiedMode is redundant.
1908
1909         * DumpRenderTree/mac/DumpRenderTree.mm:
1910         (setDefaultsToConsistentValuesForTesting):
1911         (runTest):
1912         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1913         (createBitmapContextFromWebView):
1914         * WebKitTestRunner/PlatformWebView.h:
1915         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1916         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1917         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1918         (WTR::PlatformWebView::didInitializeClients):
1919         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1920         (WTR::PlatformWebView::forceWindowFramesChanged):
1921         * WebKitTestRunner/mac/main.mm:
1922         (setDefaultsToConsistentValuesForTesting):
1923
1924 2014-03-12  Anton Obzhirov  <a.obzhirov@samsung.com>
1925
1926         Unreviewed. Add myself as a committer.
1927
1928         * Scripts/webkitpy/common/config/contributors.json:
1929
1930 2014-03-12  Ryuan Choi  <ryuan.choi@samsung.com>
1931
1932         Unreviewed build fix on the EFL port when used lower version of ATK
1933
1934         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1935         (WTR::AccessibilityUIElement::y): Fixed typo.
1936
1937 2014-03-11  Myles C. Maxfield  <mmaxfield@apple.com>
1938
1939         Some images are blank in the rebaseline server UI
1940         https://bugs.webkit.org/show_bug.cgi?id=130104
1941
1942         Reviewed by Tim Horton.
1943
1944         Let the server check for images in the 'retries' directory
1945         if it can't find an image otherwise.
1946
1947         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
1948         (RebaselineHTTPRequestHandler.test_result):
1949
1950 2014-03-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1951
1952         [GTK][CMake] --update-gtk has no effect
1953         https://bugs.webkit.org/show_bug.cgi?id=130088
1954
1955         Reviewed by Philippe Normand.
1956
1957         * Scripts/webkitdirs.pm:
1958         (buildCMakeProjectOrExit): call update-webkitgtk-libs if --update-gtk has been passed
1959         as an argument.
1960
1961 2014-03-10  Myles C. Maxfield  <mmaxfield@apple.com>
1962
1963         Add "System Font" to the list of whitelisted DRT fonts
1964         https://bugs.webkit.org/show_bug.cgi?id=130046
1965
1966         Reviewed by Darin Adler.
1967
1968         * DumpRenderTree/mac/DumpRenderTree.mm:
1969         (allowedFontFamilySet):
1970         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
1971
1972 2014-03-11  Martin Robinson  <mrobinson@igalia.com>
1973
1974         [GTK] The jhbuild environment should set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_PATH
1975         https://bugs.webkit.org/show_bug.cgi?id=130064
1976
1977         Reviewed by Philippe Normand.
1978
1979         * efl/jhbuildrc: Remove duplicated code.
1980         * gtk/jhbuildrc: Remove duplicated code.
1981         * jhbuild/jhbuildrc_common.py:
1982         (init): Move duplicated code from jhbuildrc's and extend setting CMake environment variables to
1983         GTK+. We always set the CMAKE_LIBRARY_PATH, which should be harmless for EFL 32-bit systems.
1984         and is apparently necessary for GTK+.
1985
1986 2014-03-11  László Langó  <llango.u-szeged@partner.samsung.com>
1987
1988         check-webkit-style failed to complain about missing braces
1989         https://bugs.webkit.org/show_bug.cgi?id=34189
1990
1991         Reviewed by Ryosuke Niwa.
1992
1993         * Scripts/webkitpy/style/checkers/cpp.py:
1994         (check_braces):
1995         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1996         (WebKitStyleTest.test_braces):
1997
1998 2014-03-11  László Langó  <llango.u-szeged@partner.samsung.com>
1999
2000         Remove Qt cruft from style checker.
2001         https://bugs.webkit.org/show_bug.cgi?id=130085
2002
2003         Reviewed by Csaba Osztrogonác.
2004
2005         There is no 'foreach' keyword in c++. That was a Qt feature
2006         added in: http://trac.webkit.org/changeset/46113
2007         Qt was removed from WebKit, so we should remove the checks
2008         of this keyword from check-webkit-style scripts.
2009
2010         * Scripts/webkitpy/style/checkers/cpp.py:
2011         (check_spacing_for_function_call):
2012         (check_spacing):
2013         (check_braces):
2014         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2015         (CppStyleTest.test_mismatching_spaces_in_parens):
2016         (CppStyleTest.test_spacing_for_fncall):
2017         (WebKitStyleTest.test_braces):
2018
2019 2014-03-11  Martin Hodovan  <mhodovan@inf.u-szeged.hu>
2020
2021         [GTK] update-webkitgtk-libs needs itstool
2022         https://bugs.webkit.org/show_bug.cgi?id=130082
2023
2024         After http://trac.webkit.org/changeset/165110 WebKitGTK+ uses gtk-doc 1.20.
2025         itstool is a dependency of building gtk-doc from version 1.19, so it should
2026         be added to Tools/gtk/install-dependencies script, too.
2027
2028         Reviewed by Philippe Normand.
2029
2030         * gtk/install-dependencies:
2031
2032 2014-03-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2033
2034         webkitbot rollout ChangeLogs should be nicer
2035         https://bugs.webkit.org/show_bug.cgi?id=122654
2036
2037         Reviewed by Csaba Osztrogonác.
2038
2039         Added bug urls and descriptions of rolled out patches to the rollout changelog
2040         if they are present in the original changelog. Additionally removed the list of
2041         changed files and functions.
2042
2043         * Scripts/webkitpy/common/checkout/changelog.py:
2044         (ChangeLog.update_with_unreviewed_message): Cut off the list of modified files.
2045         * Scripts/webkitpy/common/checkout/checkout.py:
2046         (Checkout._changelog_data_for_revision): Store bug description.
2047         * Scripts/webkitpy/common/checkout/checkout_mock.py:
2048         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2049         (CheckoutTest.test_commit_info_for_revision):
2050         * Scripts/webkitpy/common/checkout/commitinfo.py:
2051         (CommitInfo.bug_description): Added.
2052         (CommitInfo.to_json):
2053         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
2054         (CommitInfoTest.test_commit_info_creation):
2055         * Scripts/webkitpy/tool/commands/download.py:
2056         (AbstractRolloutPrepCommand._prepare_state): Store bug ids and descriptions of rolled
2057         out patches for creating rollout changelog.
2058         (CreateRollout._prepare_state): Remove obsolete comments and code, the bug id that
2059         caused the regression is stored in state["bug_blocked"] now.
2060         * Scripts/webkitpy/tool/commands/download_unittest.py:
2061         (test_prepare_rollout):
2062         (test_create_rollout_multiple_revision):
2063         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
2064         (PrepareChangeLogForRevert._message_for_revert): Add bug urls and descriptions of
2065         rolled out patches to the changelog.
2066         (PrepareChangeLogForRevert.run):
2067         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
2068         (UpdateChangeLogsForRevertTest):
2069         (test_message_for_revert):
2070         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
2071         (ReopenBugAfterRollout.run):
2072
2073 2014-03-11  Krzysztof Czech  <k.czech@samsung.com>
2074
2075         [ATK] Adjust WKTR/DRT to use new API from ATK 2.11.90
2076         https://bugs.webkit.org/show_bug.cgi?id=130021
2077
2078         Reviewed by Mario Sanchez Prada.
2079
2080         Replace deprecated functions to use new API from ATK 2.11.90.
2081
2082         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2083         (AccessibilityUIElement::x):
2084         (AccessibilityUIElement::y):
2085         (AccessibilityUIElement::width):
2086         (AccessibilityUIElement::height):
2087         (AccessibilityUIElement::clickPointX):
2088         (AccessibilityUIElement::clickPointY):
2089         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2090         (WTR::AccessibilityUIElement::x):
2091         (WTR::AccessibilityUIElement::y):
2092         (WTR::AccessibilityUIElement::width):
2093         (WTR::AccessibilityUIElement::height):
2094         (WTR::AccessibilityUIElement::clickPointX):
2095         (WTR::AccessibilityUIElement::clickPointY):
2096
2097 2014-03-11  Krzysztof Czech  <k.czech@samsung.com>
2098
2099         [ATK] Expose aria-posinset and aria-setsize through object attributes
2100         https://bugs.webkit.org/show_bug.cgi?id=130011
2101
2102         Reviewed by Chris Fleizach.
2103
2104         Added missing implementation of numberAttributeValue both to WKTR and DRT.
2105
2106         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2107         (AccessibilityUIElement::numberAttributeValue):
2108         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2109         (WTR::AccessibilityUIElement::numberAttributeValue):
2110
2111 2014-03-10  Brent Fulgham  <bfulgham@apple.com>
2112
2113         [Win] Unreviewed build fix.
2114
2115         Some bad Windows code was committed at some point that prevents the Apple Windows port
2116         from finding its runtime dependencies reliably.
2117
2118         * win/DLLLauncher/DLLLauncherMain.cpp:
2119         (appleApplicationSupportDirectory): Restored this function.
2120         (modifyPath): Update to use appleApplicationSupportDirectory function.
2121
2122 2014-03-10  Zoltan Horvath  <zoltan@webkit.org>
2123
2124         Let the user define the full address of the performance-site-server for uploading results
2125         https://bugs.webkit.org/show_bug.cgi?id=129819
2126
2127         Reviewed by Ryosuke Niwa.
2128
2129         Currently perftestsrunner.py assumes that the server uses https protocol all the time, which
2130         can be confusing. It's more straightforward, if you need to define explicitly the server's full
2131         address along with the protocol, when you're using this parameter. I added HTTPS as the default
2132         protocol for now, in order to avoid breaking the perf bots.
2133
2134         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2135         (_upload_json):
2136         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2137         (MainTest.test_upload_json):
2138
2139 2014-03-10  Brent Fulgham  <bfulgham@apple.com>
2140
2141         [Win] Pass environment to Pre-Build, Pre-Link, and Post-Build Stages.
2142         https://bugs.webkit.org/show_bug.cgi?id=130023
2143
2144         Reviewed by Dean Jackson.
2145
2146         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add missing
2147         /SAFESEH flag to DLL launcher process.
2148
2149 2014-03-09  Martin Robinson  <mrobinson@igalia.com>
2150
2151         RunGtkWebKitGObjectDOMBindingsAPIBreakTests should be added to the BuildAndTestFactory not the TestFactory
2152         https://bugs.webkit.org/show_bug.cgi?id=129980
2153
2154         Reviewed by Carlos Garcia Campos.
2155
2156         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add RunGtkWebKitGObjectDOMBindingsAPIBreakTests to the correct factory.
2157
2158 2014-03-09  Martin Robinson  <mrobinson@igalia.com>
2159
2160         [GTK] Remove the WebView source-mode WebKit1 test
2161         https://bugs.webkit.org/show_bug.cgi?id=129976
2162
2163         Reviewed by Carlos Garcia Campos.
2164
2165         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Remove the source-mode test.
2166
2167 2014-03-08  Martin Robinson  <mrobinson@igalia.com>
2168
2169         Unreviewed build fix for GTKbuild after the switch to CMake
2170
2171         * gtk/common.py:
2172         (is_cmake_build): Like r165284, we need to assume CMake by default, since the
2173         test-only bot doesn't have any build files.
2174
2175 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
2176
2177         [GTK] built-product-archive does not handle GTK+ CMake build
2178         https://bugs.webkit.org/show_bug.cgi?id=129941
2179
2180         * BuildSlaveSupport/built-product-archive:
2181         (archiveBuiltProduct): Fix the build by adding support to built-product-archive for
2182         the CMake build.
2183
2184 2014-03-07  Lorenzo Tilve  <ltilve@igalia.com>
2185
2186         [GTK] Include CMake into install-dependencies script
2187         https://bugs.webkit.org/show_bug.cgi?id=129909
2188
2189         Reviewed by Martin Robinson.
2190
2191         As since r165267 buid-webkit uses CMake by default, the dependency
2192         with 'cmake' package should be introduced.
2193
2194         * gtk/install-dependencies: Ditto.
2195
2196 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
2197
2198         REGRESSION(165267): Broke a webkitpy unit tests
2199         https://bugs.webkit.org/show_bug.cgi?id=129904
2200
2201         Reviewed by Jon Honeycutt.
2202
2203         * Scripts/webkitpy/port/gtk.py: Flip the default test to assume CMake by default.
2204         (GtkPort._is_cmake_build):
2205
2206 2014-03-07  Andres Gomez  <agomez@igalia.com>
2207
2208         [GTK] webkit-patch setup-git-clone fails even after running Tools/gtk/install-dependencies
2209         https://bugs.webkit.org/show_bug.cgi?id=129893
2210
2211         Reviewed by Martin Robinson.
2212
2213         Added "git-svn" as dependency for deb based distros and,
2214         additionally, "subversion" for rpm based distros.
2215
2216         * gtk/install-dependencies:
2217
2218 2014-03-07  Roger Fong  <roger_fong@apple.com>
2219
2220         Remove dummy setSystemWebGLLoadPolicy client method.
2221         https://bugs.webkit.org/show_bug.cgi?id=129873.
2222
2223         Reviewed by Dean Jackson.
2224
2225         * WebKitTestRunner/TestController.cpp:
2226         (WTR::TestController::createWebViewWithOptions):
2227
2228 2014-03-07  Mark Hahnenberg  <mhahnenberg@apple.com>
2229
2230         run-jsc-stress-tests doesn't eagerly report test failures when using the shell runner
2231         https://bugs.webkit.org/show_bug.cgi?id=129886
2232
2233         Reviewed by Mark Lam.
2234
2235         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Added a "verbose" mode to the shell runner.
2236         If we're in verbose mode, then we don't redirect any output when running each test. If we're not
2237         in verbose mode then we redirect stdout to /dev/null and allow any stderr output through.
2238         * Scripts/run-jsc-stress-tests: Redirect any sort of error output to stderr so that it will 
2239         make it through when in non-verbose mode.
2240
2241 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
2242
2243         [GTK] buid-webkit should use CMake by default
2244         https://bugs.webkit.org/show_bug.cgi?id=129855
2245
2246         Reviewed by Carlos Garcia Campos.
2247
2248         Make the CMake build the default GTK+ build when using build-webkit. This will
2249         ensure that all bots are using CMake. We do this by swapping --gtk and --gtkcmake,
2250         so that we have --gtk and --gtkautotools.
2251
2252         * Scripts/webkitdirs.pm: Swap --gtkcmake/--gtk for --gtk/--gtkautotools.
2253         * Scripts/webkitpy/port/gtk.py: Ditto.
2254
2255 2014-03-06  Martin Robinson  <mrobinson@igalia.com>
2256
2257         [CMake] [GTK] Build with ninja when it is available
2258         https://bugs.webkit.org/show_bug.cgi?id=129805
2259
2260         Reviewed by Philippe Normand.
2261
2262         * Scripts/webkitdirs.pm:
2263         (canUseNinja): Added this helper which tries to execute Ninja, in an effort to determine
2264         if it's available on the system.
2265         (cmakeGeneratedBuildfile): Return the path to the generated build file. Only Unix support ATM.
2266         (generateBuildSystemFromCMakeProject): For GTK+ compile with Ninja when possible.
2267
2268 2014-03-06  Filip Pizlo  <fpizlo@apple.com>
2269
2270         If the FTL is build-time enabled then it should be run-time enabled.
2271
2272         Rubber stamped by Geoffrey Garen.
2273
2274         * Scripts/run-jsc-stress-tests:
2275
2276 2014-03-06  Mark Hahnenberg  <mhahnenberg@apple.com>
2277
2278         detectFailures in run-jsc-stress-tests can report everything was ok if too many tests fail
2279         https://bugs.webkit.org/show_bug.cgi?id=129837
2280
2281         Reviewed by Michael Saboff.
2282
2283         ls test_fail_* can fail if there are too many files that match. We then swallow that error, which makes everything seem ok.
2284         The fix is to use find instead of ls like we do in shell-runner.sh.
2285
2286         * Scripts/run-jsc-stress-tests:
2287
2288 2014-03-06  Joseph Pecoraro  <pecoraro@apple.com>
2289
2290         filter-build-webkit should not strip .o
2291         https://bugs.webkit.org/show_bug.cgi?id=129614
2292
2293         Reviewed by Dean Jackson.
2294
2295         This makes it much easier to jump from the failing output at
2296         the end back up to the compile errors earlier in the output.
2297
2298         * Scripts/filter-build-webkit:
2299
2300 2014-03-06  Anders Carlsson  <andersca@apple.com>
2301
2302         Build WebKit2 before building WebKit
2303         https://bugs.webkit.org/show_bug.cgi?id=129831
2304         <rdar://problem/15920020>
2305
2306         Reviewed by Dan Bernstein.
2307
2308         * Scripts/build-webkit:
2309         Always build WebKit2 and make sure to build it before WebKit when building on Mac.
2310
2311 2014-03-06  ChangSeok Oh  <changseok.oh@collabora.com>
2312
2313         make-3.82 fails to build on ARM/Linux
2314         https://bugs.webkit.org/show_bug.cgi?id=107926
2315
2316         Reviewed by Martin Robinson.
2317
2318         Some ARM/Linux systems don't support PAGE_SIZE macro so that it causes a build failure.
2319         The related bug reporting is here. https://lists.debian.org/debian-kernel/2014/02/msg00274.html
2320         To avoid this, I propose to use sysconf(_SC_PAGESIZE) instead of PAGE_SIZE
2321         where it is not defined. See more details, http://linux.die.net/man/2/getpagesize
2322
2323         * gtk/patches/make-3.82-arg-list-length.patch:
2324
2325 2014-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2326
2327         [GTK] Close the page when the view is disposed instead of when finalized
2328         https://bugs.webkit.org/show_bug.cgi?id=129783
2329
2330         Reviewed by Sergio Villar Senin.
2331
2332         Add test case but disabled for now because it's affetected by bug #129684.
2333
2334         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
2335         (testProcessPerWebView):
2336
2337 2014-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2338
2339         [GTK] MiniBrowser crashes when opening several urls passed as command line options
2340         https://bugs.webkit.org/show_bug.cgi?id=129738
2341
2342         Reviewed by Sergio Villar Senin.
2343
2344         The problem is that we are calling g_object_unref() for the
2345         WebKitWebSettings everytime we set it to a WebKitWebView, but the
2346         view only increases the reference counter when the settings is not
2347         the same it currently has. We should release our reference once.
2348
2349         * MiniBrowser/gtk/main.c:
2350         (createBrowserWindow):
2351         (main):
2352
2353 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
2354
2355         [GTK][CMake] Tarball is created with wrong tarball paths
2356         https://bugs.webkit.org/show_bug.cgi?id=129496
2357
2358         Reviewed by Daniel Bates.
2359
2360         * gtk/make-dist.py:
2361         (Manifest.__init__): I inadvertently inverted the logic of these checks when
2362         landing the original patch with some suggestions from the reviewer. With the
2363         checks corrected, the tarball path is constructed properly.
2364
2365 2014-03-05  Jae Hyun Park  <jaepark@webkit.org>
2366
2367         Unreviewed. Update my email in contributors.json
2368
2369         * Scripts/webkitpy/common/config/contributors.json:
2370
2371 2014-03-05  Dean Jackson  <dino@apple.com>
2372
2373         [WebGL] Use WKSI to see what the system policy for WebGL is
2374         https://bugs.webkit.org/show_bug.cgi?id=129722
2375         <rdar://problem/15790542>
2376
2377         Reviewed by Tim Horton.
2378
2379         Dummy entry for setSystemWebGLLoadPolicy.
2380
2381         * WebKitTestRunner/TestController.cpp:
2382         (WTR::TestController::createWebViewWithOptions):
2383
2384 2014-03-03  Martin Robinson  <mrobinson@igalia.com>
2385
2386         [GTK][CMake] Generate documentation for the DOM bindings
2387         https://bugs.webkit.org/show_bug.cgi?id=126211
2388
2389         Reviewed by Carlos Garcia Campos.
2390
2391         * gtk/GNUmakefile.am: No longer generation sections and SGML files in the makefile.
2392         * gtk/generate-gtkdoc: Call the code from webkitdom.py to generate sections and SGML files.
2393         * gtk/generate-webkitdom-doc-files: Removed.
2394         * gtk/webkitdom.py: Moved WebKit GObject DOM bindings doc generation code here, so
2395         that it can be called by generate-gtkdoc.
2396
2397 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
2398
2399         [GTK][CMake] build-webkit should rerun cmake if the Makefile is missing
2400         https://bugs.webkit.org/show_bug.cgi?id=129380
2401
2402         Reviewed by Philippe Normand.
2403
2404         * Scripts/webkitdirs.pm:
2405         (generateBuildSystemFromCMakeProject): Check for the existence of the Makefile before
2406         skipping CMake execution.
2407
2408 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
2409
2410         [GTK] The jhbuild environment should have the latest stable release of gtk-doc
2411         https://bugs.webkit.org/show_bug.cgi?id=129651
2412
2413         Reviewed by Philippe Normand.
2414
2415         * gtk/jhbuild.modules: Add gtk-doc to the list of modules.
2416
2417 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
2418
2419         [GTK] Give the WebKit GObject DOM bindings API break detection it's own buildbot bubble
2420         https://bugs.webkit.org/show_bug.cgi?id=129637
2421
2422         Reviewed by Carlos Garcia Campos.
2423
2424         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2425         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests): Added this test runner.
2426         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.commandComplete): Run the breakage test command and scan the output.
2427         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.evaluateCommand): Return failure if there is missing API (an API break).
2428         New API typically just requires a rebaseline and isn't necessarily a faiulre.
2429         (TestFactory.__init__): Add the test for GTK+.
2430         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Add a unit test for the new bubble.
2431
2432 2014-03-05  Krzysztof Czech  <k.czech@samsung.com>
2433
2434         [ATK] Expose missing functionalities of AtkTableCell to AT
2435         https://bugs.webkit.org/show_bug.cgi?id=129492
2436
2437         Reviewed by Mario Sanchez Prada.
2438
2439         Reducing some code by using new API of AtkTableCell.
2440
2441         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2442         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2443
2444 2014-03-04  Alex Christensen  <achristensen@webkit.org>
2445
2446         Preparing to run layout tests on Wincairo.
2447         https://bugs.webkit.org/show_bug.cgi?id=129709
2448
2449         Reviewed by Brent Fulgham.
2450
2451         * Scripts/webkitdirs.pm:
2452         (setPathForRunningWebKitApp):
2453         Add GStreamer directory for WinCairo running layout tests.
2454         * win/DLLLauncher/DLLLauncherMain.cpp:
2455         (modifyPath):
2456         Added the WinCairo bin32 or bin64 directory for running WinLauncher.
2457
2458 2014-03-04  Martin Robinson  <mrobinson@igalia.com>
2459
2460         [GTK] Simplify the GObject DOM bindings API break check into one step
2461         https://bugs.webkit.org/show_bug.cgi?id=129571
2462
2463         Reviewed by Carlos Garcia Campos.
2464
2465         * GNUmakefile.am: Add the API break check to 'make check.'
2466         * gtk/check-for-webkitdom-api-breaks: Added. A combination of the two removed scripts.
2467         * gtk/check-gdom-symbols: Removed.
2468         * gtk/webkitdom.py: Added.
2469         (header_name_list_from_gtkdoc_config_file): Gets the names of all headers from the gtkdoc config file.
2470         (get_all_webkitdom_symbol_files): Find the symbol files from the names.
2471
2472 2014-03-03  Simon Fraser  <simon.fraser@apple.com>
2473
2474         Add Jeremy Jones to the contributors list as a contributor.
2475
2476         * Scripts/webkitpy/common/config/contributors.json:
2477
2478 2014-03-03  Adenilson Cavalcanti  <cavalcantii@gmail.com>
2479
2480         Unreviewed. Update contact email.
2481         https://bugs.webkit.org/show_bug.cgi?id=129610
2482
2483         * Scripts/webkitpy/common/config/contributors.json:
2484
2485 2014-03-02  Brian Burg  <bburg@apple.com>
2486
2487         Web Inspector model tests load wrong inspector page under WebKitTestRunner
2488         https://bugs.webkit.org/show_bug.cgi?id=129460
2489
2490         Reviewed by Dan Bernstein.
2491
2492         Don't unconditionally open the inspector before running an inspector test.
2493         Instead, the test should request that the inspector open when it's ready.
2494
2495         This change was lost during a rebase, but is the same change made to
2496         DumpRenderTree.
2497
2498         * WebKitTestRunner/TestInvocation.cpp:
2499         (WTR::TestInvocation::invoke): 
2500
2501 2014-03-02  Darin Adler  <darin@apple.com>
2502
2503         Split TextIteratorBehavior into a separate header
2504         https://bugs.webkit.org/show_bug.cgi?id=129578
2505
2506         Reviewed by Sam Weinig.
2507
2508         * Scripts/sort-export-file: Added special cases to the script so you can just paste link errors
2509         from WebKit in and the script will add them in as unconditional exports. This makes the "add"
2510         task easy, but the remove is still a bit of a pain.
2511
2512 2014-03-02  Darin Adler  <darin@apple.com>
2513
2514         Sort Mac platform export files so they merge better
2515         https://bugs.webkit.org/show_bug.cgi?id=129581
2516
2517         Reviewed by Sam Weinig.
2518
2519         * Scripts/sort-export-file: Added. Quickly whipped together script that sorts
2520         Mac export files in a "canonical" order for this project.
2521
2522 2014-02-28  Zalan Bujtas  <zalan@apple.com>
2523
2524         Add hiDPI support to DumpRenderTree/WebKitTestRunner without the need of reloading the test case.
2525         https://bugs.webkit.org/show_bug.cgi?id=129438
2526
2527         Reviewed by Simon Fraser.
2528
2529         'hidpi-' prefixed test cases now trigger 2x scale factor on the testing
2530         offscreen window. It makes testing subpixel rendering and positioning possible.
2531
2532         Both the offscreen window's and WebKit's scaling are set accordingly.
2533
2534         * DumpRenderTree/mac/DumpRenderTree.mm:
2535         (createWebViewAndOffscreenWindow): cleanup
2536         (destroyWebViewAndOffscreenWindow): cleanup
2537         (dumpRenderTree):
2538         (changeWindowScaleIfNeeded):
2539         (runTest):
2540         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2541         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2542         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]): cleanup
2543         * WebKitTestRunner/PlatformWebView.h:
2544         * WebKitTestRunner/TestInvocation.cpp:
2545         (WTR::changeWindowScaleIfNeeded):
2546         (WTR::TestInvocation::invoke):
2547         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2548         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
2549         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2550         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
2551         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2552         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
2553         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2554         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
2555
2556 2014-02-28  Anders Carlsson  <andersca@apple.com>
2557
2558         Remove logging.
2559
2560         Reviewed by Dan Bernstein.
2561
2562         * MiniBrowser/mac/WK2BrowserWindowController.m:
2563         (-[WK2BrowserWindowController browsingContextController:decidePolicyForNavigationAction:decisionHandler:]):
2564
2565 2014-02-28  Daniel Bates  <dabates@apple.com>
2566
2567         [iOS] DumpRenderTree Perl Support may build against wrong SDK and toolchain
2568         https://bugs.webkit.org/show_bug.cgi?id=129163
2569
2570         Reviewed by David Kilzer.
2571
2572         Fixes an issue where DumpRenderTree Perl Support may build with the specified
2573         iOS Simulator SDK and toolchain instead of using the OS X SDK and toolchain.
2574         This issue manifests itself in a build failure when building the IPhoneSimulatorNotification
2575         bundle.
2576
2577         Currently we build DumpRenderTree Perl Support with respect to the variable SDKROOT,
2578         which is specified either explicitly when building with MAKE(1) or implicitly by
2579         build-{dumprendertree, webkit}. Instead we should always build Perl Support using
2580         the OS X SDK and toolchain since the built products are only applicable to OS X.
2581
2582         * DumpRenderTree/ios/PerlSupport/Makefile:
2583
2584 2014-02-28  Commit Queue  <commit-queue@webkit.org>
2585
2586         Unreviewed, rolling out r164859.
2587         http://trac.webkit.org/changeset/164859
2588         https://bugs.webkit.org/show_bug.cgi?id=129483
2589
2590         caused WK1 crashes (DumpRenderTree) (Requested by zalan on
2591         #webkit).
2592
2593         * DumpRenderTree/mac/DumpRenderTree.mm:
2594         (createWebViewAndOffscreenWindow):
2595         (dumpRenderTree):
2596         (runTest):
2597         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2598         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2599         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
2600         * WebKitTestRunner/PlatformWebView.h:
2601         * WebKitTestRunner/TestInvocation.cpp:
2602         (WTR::TestInvocation::invoke):
2603         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2604         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2605         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2606         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2607         (-[WebKitTestRunnerWindow frameRespectingFakeOrigin]):
2608
2609 2014-02-28  Zalan Bujtas  <zalan@apple.com>
2610
2611         Add hiDPI support to DumpRenderTree/WebKitTestRunner without the need of reloading the test case.
2612         https://bugs.webkit.org/show_bug.cgi?id=129438
2613
2614         Reviewed by Simon Fraser.
2615
2616         'hidpi-' prefixed test cases now trigger 2x scale factor on the testing
2617         offscreen window. It makes testing subpixel rendering and positioning possible.
2618
2619         Both the offscreen window's and WebKit's scaling are set accordingly.
2620
2621         * DumpRenderTree/mac/DumpRenderTree.mm:
2622         (createWebViewAndOffscreenWindow): unrelated cleanup.
2623         (destroyWebViewAndOffscreenWindow): unrelated cleanup.
2624         (dumpRenderTree):
2625         (changeOffscreenWindowScaleIfNeeded):
2626         (runTest):
2627         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2628         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2629         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]): cleanup.
2630         * WebKitTestRunner/PlatformWebView.h:
2631         * WebKitTestRunner/TestInvocation.cpp:
2632         (WTR::changeOffscreenWindowScaleIfNeeded):
2633         (WTR::TestInvocation::invoke):
2634         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2635         (WTR::PlatformWebView::changeOffscreenWindowScaleIfNeeded):
2636
2637 2014-02-27  Brian Burg  <bburg@apple.com>
2638
2639         Web Inspector: model tests should use a special Test.html inspector page
2640         https://bugs.webkit.org/show_bug.cgi?id=129190
2641
2642         Reviewed by Timothy Hatcher.
2643
2644         Remove code that immediately opens the Web Inspector based on the file path of the test.
2645         Instead, the test page should request that the inspector open inside its `test()` method.
2646
2647         This change is necessary because otherwise, the inspector would be opened too early for
2648         InspectorController::isUnderTest to get set in time, so the normal Web Inspector page
2649         will get loaded instead of the minimal test page.
2650
2651         * DumpRenderTree/efl/DumpRenderTree.cpp:
2652         (createTestRunner):
2653         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2654         (runTest):
2655         * DumpRenderTree/mac/DumpRenderTree.mm:
2656         (runTest):
2657         * DumpRenderTree/win/DumpRenderTree.cpp:
2658         (runTest):
2659
2660 2014-02-27  Laszlo Vidacs  <lvidacs.u-szeged@partner.samsung.com>
2661
2662         check-webkit-style indentation false alarm in WebKit/win/WebNodeHighlight.cpp
2663         https://bugs.webkit.org/show_bug.cgi?id=127076
2664
2665         Reviewed by Anders Carlsson.
2666
2667         Avoid match for :: as start of a member initialization list. Modify expression to match
2668         after a colon either non-colon character or end of line.
2669
2670         * Scripts/webkitpy/style/checkers/cpp.py:
2671         (check_member_initialization_list):
2672         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2673         (WebKitStyleTest.test_member_initialization_list):
2674
2675 2014-02-27  Renata Hodovan  <rhodovan.u-szeged@partner.samsung.com>
2676
2677         Unreviewed. Update my email addresses in contributors.json.
2678
2679         * Scripts/webkitpy/common/config/contributors.json:
2680
2681 2014-02-27  Alberto Garcia  <berto@igalia.com>
2682
2683         [gtk-doc] UnicodeEncodeError: 'ascii' codec can't encode character
2684         https://bugs.webkit.org/show_bug.cgi?id=128927
2685
2686         Reviewed by Philippe Normand.
2687
2688         Encode manually the data for sys.{stdout,stderr}.write.
2689
2690         * gtk/gtkdoc.py:
2691         (GTKDoc._run_command):
2692
2693 2014-02-27  Andres Gomez  <agomez@igalia.com>
2694
2695         Unreviewed. Add myself to watchlists
2696
2697         * Scripts/webkitpy/common/config/watchlist: Add myself to
2698         watchlists.
2699
2700 2014-02-27  Andres Gomez  <agomez@igalia.com>
2701
2702         Unreviewed, rolling out r164790.
2703         http://trac.webkit.org/changeset/164790
2704
2705         Revert r164790 because of erroneous commit log
2706
2707         * Scripts/webkitpy/common/config/watchlist:
2708
2709 2014-02-27  Krzysztof Czech  <k.czech@samsung.com>
2710
2711         [ATK] Utilize AtkTableCell to expose directly AccessibilityTableCell to AT
2712         https://bugs.webkit.org/show_bug.cgi?id=129250
2713
2714         Reviewed by Mario Sanchez Prada.
2715
2716         Changing version of ATK to 2.11.90, because it introduces AtkTableCell interface.
2717         Implementing methods so that we could test column/row headers represented as an array of cells.
2718
2719         * DumpRenderTree/AccessibilityUIElement.cpp:
2720         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2721         (AccessibilityUIElement::columnHeaders):
2722         (AccessibilityUIElement::rowHeaders):
2723         * DumpRenderTree/win/AccessibilityUIElementWin.cpp: Adding empty stubs, to not break compilation.
2724         (AccessibilityUIElement::columnHeaders):
2725         (AccessibilityUIElement::rowHeaders):
2726         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2727         (WTR::AccessibilityUIElement::rowHeaders):
2728         (WTR::AccessibilityUIElement::columnHeaders):
2729         * efl/jhbuild.modules:
2730         * gtk/jhbuild.modules:
2731
2732 2014-02-27  Andres Gomez  <agomez@igalia.com>
2733
2734         Unreviewed. Add myself to watchlists
2735
2736         * Scripts/webkitpy/common/config/watchlist: Add myself to
2737         watchlists.
2738
2739 2014-02-27  Andres Gomez  <agomez@igalia.com>
2740
2741         Unreviewed. Add myself as a committer.
2742
2743         * Scripts/webkitpy/common/config/contributors.json:
2744
2745 2014-02-27  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2746
2747         Unreviewed. Add Víctor Jáquez and myself to watchlists
2748
2749         * Scripts/webkitpy/common/config/watchlist: Add Víctor Jáquez and
2750         myself to watchlists.
2751
2752 2014-02-26  Julien Brianceau  <jbriance@cisco.com>
2753
2754         Unreviewed. Add myself as a committer.
2755
2756         * Scripts/webkitpy/common/config/contributors.json:
2757
2758 2014-02-26  Laszlo Vidacs  <lvidacs.u-szeged@partner.samsung.com>
2759
2760         Unreviewed. Moved myself to the list of committers.
2761
2762         * Scripts/webkitpy/common/config/contributors.json:
2763
2764 2014-02-24  Martin Robinson  <mrobinson@igalia.com>
2765
2766         [GTK] Reduplicate common.top_level_path in scripts
2767         https://bugs.webkit.org/show_bug.cgi?id=129291
2768
2769         Reviewed by Philippe Normand.
2770
2771         Duplicate common.top_level_path and avoid polluting many scripts with awkward system
2772         path manipulation and weird dependencies on the jhbuild infrastructure.
2773
2774         * Scripts/run-gtk-tests: Use common again.
2775         (TestRunner._setup_testing_environment): Ditto.
2776         * gtk/check-gdom-symbols: Ditto.
2777         * gtk/common.py:
2778         (top_level_path): Re-add top_level_path..
2779         (get_build_path): Use the builtin top_level_path again.
2780         * gtk/find-make-dist-errors: Use common again.
2781         (get_missing_headers): Ditto.
2782         * gtk/generate-inspector-gresource-manifest.py: Ditto.
2783
2784 2014-02-26  Mark Hahnenberg  <mhahnenberg@apple.com>
2785
2786         runscript: line 42: /bin/ls: Argument list too long
2787         https://bugs.webkit.org/show_bug.cgi?id=129376
2788
2789         Reviewed by Michael Saboff.
2790
2791         The "test_script_*" can expand to more things than can be passed as arguments on the command line. 
2792         We should use find instead, which generates the list of files rather than expanding them all on 
2793         the command line and spitting them back out.
2794
2795         * Scripts/jsc-stress-test-helpers/shell-runner.sh: 
2796
2797 2014-02-26  Martin Robinson  <mrobinson@igalia.com>
2798
2799         ENABLE_PROMISES is improperly specified as ENABLE_PROMISE in Features.pm
2800         https://bugs.webkit.org/show_bug.cgi?id=129377
2801
2802         Reviewed by Csaba Osztrogonác.
2803
2804         * Scripts/webkitperl/FeatureList.pm: Properly specify the promises feature as ENABLE_PROMISES.
2805
2806 2014-02-26  Manuel Rego Casasnovas  <rego@igalia.com>
2807
2808         [GTK] Re-enable gtk-doc in EWS
2809         https://bugs.webkit.org/show_bug.cgi?id=128369
2810
2811         Reviewed by Carlos Garcia Campos.
2812
2813         Enable again gtk-doc generation in EWS once bug #128417 has been fixed.
2814
2815         * Scripts/webkitpy/common/config/ports.py:
2816         (GtkPort.build_webkit_command): Add --disable-gtk-doc arg.
2817         (GtkWK2Port.build_webkit_command): Ditto.
2818         * Scripts/webkitpy/common/config/ports_unittest.py:
2819         (DeprecatedPortTest.test_gtk_port): Ditto.
2820         (DeprecatedPortTest.test_gtk_wk2_port): Ditto.
2821
2822 2014-02-26  Martin Robinson  <mrobinson@igalia.com>
2823
2824         [GTK] generate-gtkdoc can fail with WebKit1 or WebKit2 only builds
2825         https://bugs.webkit.org/show_bug.cgi?id=129319
2826
2827         Reviewed by Carlos Garcia Campos.
2828
2829         * gtk/generate-gtkdoc:
2830         (get_generator_for_config): Properly handle the situation where the pkgconfig file is missing.
2831
2832 2014-02-25  Mihai Maerean  <mmaerean@adobe.com>
2833
2834         Unreviewed. Add myself as a committer.
2835
2836         * Scripts/webkitpy/common/config/contributors.json:
2837
2838 2014-02-25  Sergio Villar Senin  <svillar@igalia.com>
2839
2840         [CSS Grid Layout] Add ENABLE flag
2841         https://bugs.webkit.org/show_bug.cgi?id=129153
2842
2843         Reviewed by Simon Fraser.
2844
2845         Added ENABLE_CSS_GRID_LAYOUT feature flag. It's on by default for
2846         all ports for developer builds.
2847
2848         * Scripts/webkitperl/FeatureList.pm:
2849
2850 2014-02-25  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
2851
2852         Added myself as a committer.
2853
2854         Unreviewed.
2855
2856         * Scripts/webkitpy/common/config/contributors.json:
2857
2858 2014-02-25  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
2859
2860         Unreviewed. Moved myself to the list of committers.
2861
2862         * Scripts/webkitpy/common/config/contributors.json:
2863
2864 2014-02-25  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
2865
2866         Move myself to the committers list.
2867
2868         Unreviewed.
2869
2870         * Scripts/webkitpy/common/config/contributors.json:
2871
2872 2014-02-25  László Langó  <llango.u-szeged@partner.samsung.com>
2873
2874         Unreviewed. Add myself as a committer.
2875
2876         * Scripts/webkitpy/common/config/contributors.json:
2877
2878 2014-02-25  Commit Queue  <commit-queue@webkit.org>
2879
2880         Unreviewed, rolling out r164639.
2881         http://trac.webkit.org/changeset/164639
2882         https://bugs.webkit.org/show_bug.cgi?id=129302
2883
2884         gtk-doc still have problems in EWS (Requested by rego on
2885         #webkit).
2886
2887         * Scripts/webkitpy/common/config/ports.py:
2888         (GtkPort.build_webkit_command):
2889         (GtkWK2Port.build_webkit_command):
2890         * Scripts/webkitpy/common/config/ports_unittest.py:
2891         (DeprecatedPortTest.test_gtk_port):
2892         (DeprecatedPortTest.test_gtk_wk2_port):
2893
2894 2014-02-25  Manuel Rego Casasnovas  <rego@igalia.com>
2895
2896         [GTK] Re-enable gtk-doc in EWS
2897         https://bugs.webkit.org/show_bug.cgi?id=128369
2898
2899         Reviewed by Carlos Garcia Campos.
2900
2901         Enable again gtk-doc generation in EWS once bug #128417 has been fixed.
2902
2903         * Scripts/webkitpy/common/config/ports.py:
2904         (GtkPort.build_webkit_command): Add --disable-gtk-doc arg.
2905         (GtkWK2Port.build_webkit_command): Ditto.
2906         * Scripts/webkitpy/common/config/ports_unittest.py:
2907         (DeprecatedPortTest.test_gtk_port): Ditto.
2908         (DeprecatedPortTest.test_gtk_wk2_port): Ditto.
2909
2910 2014-02-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2911
2912         [GTK] Mark view source mode methods as deprecated
2913         https://bugs.webkit.org/show_bug.cgi?id=128920
2914
2915         Reviewed by Martin Robinson.
2916
2917         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2918         (beforeAll): Remove view mode test.
2919
2920 2014-02-24  Martin Robinson  <mrobinson@igalia.com>
2921
2922         [GTK] generate-gtkdoc should not generate documentation for source files for unbuilt source files
2923         https://bugs.webkit.org/show_bug.cgi?id=128417
2924
2925         Reviewed by Carlos Garcia Campos.
2926
2927         * gtk/GNUmakefile.am: Make the documentation process depend on the configuration files.
2928         * gtk/generate-gtkdoc: Switch from using hard-coded configurations to reading them from
2929         a makefile. This allows accepting a header list from the build system, which can be used
2930         to dynamically build a list of ignored files. We can ignore any source file that doesn't
2931         have a corresponding header file on the header list. 
2932         * gtk/gtkdoc.py: Now accept a headers parameter, which can be used instead of passing just
2933         source directories to gtkdoc-scan.
2934
2935 2014-02-24  Anders Carlsson  <andersca@apple.com>
2936
2937         Add a DefaultVisitedLinkProvider and route visited link actions through it
2938         https://bugs.webkit.org/show_bug.cgi?id=129285
2939
2940         Reviewed by Dan Bernstein.
2941
2942         * MiniBrowser/mac/AppDelegate.m:
2943         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
2944         Set a shared history so we'll get visited link tracking.
2945
2946         * MiniBrowser/mac/WK1BrowserWindowController.m:
2947         (-[WK1BrowserWindowController awakeFromNib]):
2948         Set a group name.
2949
2950 2014-02-24  Dan Bernstein  <mitz@apple.com>
2951
2952         iOS build fix after r164577.
2953
2954         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2955         (AccessibilityUIElement::selectedChildrenCount):
2956         (AccessibilityUIElement::selectedChildAtIndex):
2957
2958 2014-02-24  David Kilzer  <ddkilzer@apple.com>
2959
2960         [ASan] Remove methods from ignore list that no longer cause crashes
2961         <http://webkit.org/b/129257>
2962
2963         Reviewed by Anders Carlsson.
2964
2965         * asan/webkit-asan-ignore.txt: Remove old methods.
2966
2967 2014-02-24  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2968
2969         Extract common parts from jhbuildrc files.
2970         https://bugs.webkit.org/show_bug.cgi?id=125986
2971
2972         Reviewed by Csaba Osztrogonác.
2973
2974         Co-authored with Peter Szanka <h868064@stud.u-szeged.hu>.
2975
2976         * Scripts/run-gtk-tests:
2977         (TestRunner._setup_testing_environment):
2978         * efl/common.py: Removed.
2979         * efl/jhbuildrc:
2980         * gtk/check-gdom-symbols:
2981         * gtk/common.py:
2982         (binary_build_path):
2983         (get_build_path):
2984         * gtk/find-make-dist-errors:
2985         (get_missing_headers):
2986         * gtk/generate-gtkdoc:
2987         (get_webkit2_options):
2988         (get_webkit1_options.src_path):
2989         (get_webkit1_options):
2990         (get_webkitdom_options.src_path):
2991         (get_webkitdom_options):
2992         * gtk/generate-inspector-gresource-manifest.py:
2993         * gtk/jhbuildrc:
2994         * jhbuild/jhbuildrc_common.py: Added.
2995         (script_path):
2996         (top_level_path):
2997         (init):
2998
2999 2014-02-24  Diego Pino Garcia  <dpino@igalia.com>
3000
3001         Unreviewed. Fix code indentation and spacing.
3002
3003         * Scripts/webkitpy/style/checkers/js.py:
3004         (SingleQuoteChecker.check):
3005
3006 2014-02-24  Krzysztof Czech  <k.czech@samsung.com>
3007
3008         [ATK] Wrong selected element at a given index in a list box.
3009         https://bugs.webkit.org/show_bug.cgi?id=129039
3010
3011         Reviewed by Chris Fleizach.
3012
3013         Added missing implementation and proposed some new function for testing selection
3014         in a list boxes.
3015
3016         * DumpRenderTree/AccessibilityUIElement.cpp:
3017         (setSelectedChildAtIndexCallback):
3018         (removeSelectionAtIndexCallback):
3019         (AccessibilityUIElement::getJSClass):
3020         * DumpRenderTree/AccessibilityUIElement.h:
3021         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3022         (AccessibilityUIElement::selectedChildrenCount):
3023         (AccessibilityUIElement::selectedChildAtIndex):
3024         (AccessibilityUIElement::setSelectedChildAtIndex):
3025         (AccessibilityUIElement::removeSelectionAtIndex):
3026         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3027         (AccessibilityUIElement::selectedChildrenCount):
3028         (AccessibilityUIElement::selectedChildAtIndex):
3029         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3030         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
3031         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
3032         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3033         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3034         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3035         (WTR::AccessibilityUIElement::selectedChildAtIndex):
3036         (WTR::AccessibilityUIElement::selectedChildrenCount):
3037         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
3038         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
3039
3040 2014-02-23  Diego Pino García  <dpino@igalia.com>
3041
3042         [GTK] Fix build after Web Inspector code reorganization (r164543)
3043         https://bugs.webkit.org/show_bug.cgi?id=129231
3044
3045         Reviewed by Dean Jackson.
3046
3047         * gtk/generate-inspector-gresource-manifest.py:
3048         Modify paths to Web Inspector code.
3049
3050 2014-02-23  Martin Robinson  <mrobinson@igalia.com>
3051
3052         [GTK] generate-gtkdoc should use argparse
3053         https://bugs.webkit.org/show_bug.cgi?id=128418
3054
3055         Reviewed by Carlos Garcia Campos.
3056
3057         * gtk/generate-gtkdoc: Get all arguments from argparse, pass then as parameters
3058         to all functions, and guard the main routine with a __name__ == __main__ check.
3059
3060 2014-02-23  Martin Robinson  <mrobinson@igalia.com>
3061
3062         [GTK][CMake] Many plugin tests fail when running WebKit1 layout tests
3063         https://bugs.webkit.org/show_bug.cgi?id=129191
3064
3065         Reviewed by Anders Carlsson.
3066
3067         * DumpRenderTree/PlatformGTK.cmake: Properly specify the library build directory
3068         for the GTK+ DumpRenderTree build. We could manually construct this path, but the
3069         name of the directory is "lib" and not "libs". Instead we should use the CMake
3070         variable specifically assigned to this task.
3071
3072 2014-02-23  David Kilzer  <ddkilzer@apple.com>
3073
3074         [ASan] Add JSC::DFG::prepareOSREntry() to ignore list
3075         <http://webkit.org/b/129209>
3076
3077         Reviewed by Geoffrey Garen.
3078
3079         * asan/webkit-asan-ignore.txt: Add DFG::prepareOSREntry() to the
3080         ignore list to make ASan builds usable again.  Follow-up
3081         investigation is tracked by <rdar://problem/16055903>.
3082
3083 2014-02-20  David Farler  <dfarler@apple.com>
3084
3085         Make old-run-webkit-tests work with iOS Simulator WebKitTestRunner
3086         https://bugs.webkit.org/show_bug.cgi?id=128622
3087
3088         Reviewed by Simon Fraser.
3089
3090         With this change, we now have layout tests running in both DumpRenderTree
3091         and WebKitTestRunner, with WebKit and WebKit2 used respectively in the iOS
3092         simulator.
3093
3094         * Scripts/old-run-webkit-tests:
3095         In general, make any specific reference to DumpRenderTree
3096         able to refer to WebKitTestRunner wherever possible:
3097         - Rename functions to remove DRT-specific naming.
3098         - Name FIFOs after the tool that is being used.
3099         -- Clean up FIFO creation code
3100         Other necessary changes:
3101         - Allow use of an ios-sim-wk2 platform.
3102         - Clean up platform hierarchy creation where the simulator platform behavior differed.
3103         * WebKitTestRunner/TestController.cpp:
3104         Open FIFOs to get dumps out of the simulator as we do in DumpRenderTree.
3105         (WTR::TestController::TestController):
3106         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3107         Copy the injected bundle into the app bundle.
3108
3109 2014-02-21  Joseph Pecoraro  <pecoraro@apple.com>
3110
3111         run-webkit-httpd fails to find httpd configuation file.
3112
3113         Reviewed by Ryosuke Niwa.
3114
3115         * Scripts/webkitperl/httpd.pm:
3116         (getHTTPDConfigPathForTestDirectory):
3117
3118 2014-02-21  Eric Carlson  <eric.carlson@apple.com>
3119
3120         Fix TimeRanges layering violations
3121         https://bugs.webkit.org/show_bug.cgi?id=128717
3122
3123         Reviewed by Jer Noble.
3124
3125         * TestWebKitAPI/Tests/WebCore/TimeRanges.cpp: TimeRanges* -> TimeRanges&.
3126         (TestWebKitAPI::TEST):
3127
3128 2014-02-21  Diego Pino García  <dpino@igalia.com>
3129
3130         Web Inspector: update check-webkit-style to flag single quotes in WebInspectorUI projects
3131         https://bugs.webkit.org/show_bug.cgi?id=128422
3132
3133         Reviewed by Joseph Pecoraro.
3134
3135         * Scripts/webkitpy/style/checkers/js.py:
3136         (JSChecker.__init__):
3137         (JSChecker.check):
3138         (SingleQuoteChecker):
3139         (SingleQuoteChecker.__init__):
3140         (SingleQuoteChecker.check):
3141         * Scripts/webkitpy/style/checkers/js_unittest.py:
3142         (JSTestCase.assertError.error_for_test):
3143         (JSTestCase.assertError):
3144         (JSTestCase.test_no_error):
3145         (JSTestCase.test_error):
3146
3147 == Rolled over to ChangeLog-2014-02-20 ==