[LFC] Unreviewed test gardening.
[WebKit-https.git] / Tools / ChangeLog
1 2019-06-16  Zalan Bujtas  <zalan@apple.com>
2
3         [LFC] Unreviewed test gardening.
4
5         Unsupported alignments.
6
7         fast/inline/absolute-positioned-inline-in-centred-block.html -align: center
8         fast/borders/empty-outline-border-assert.html -vertical-align: super
9         css2.1/20110323/vertical-align-boxes-001.htm - vertical-align: middle
10
11         * LayoutReloaded/misc/LFC-passing-tests.txt:
12
13 2019-06-15  Youenn Fablet  <youenn@apple.com>
14
15         WPT test importer WTR option reader should not throw if the file is not proper UTF-8
16         https://bugs.webkit.org/show_bug.cgi?id=198780
17
18         Reviewed by Jonathan Bedard.
19
20         * Scripts/webkitpy/w3c/test_importer.py:
21         (TestImporter._webkit_test_runner_options):
22         In case the test file cannot be read as text, consider that there is no WTR option.
23
24 2019-06-14  Youenn Fablet  <youenn@apple.com>
25
26         WebResourceLoadStatisticsStore should not use its network session if invalidated
27         https://bugs.webkit.org/show_bug.cgi?id=198814
28
29         Reviewed by Geoffrey Garen.
30
31         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
32         (TEST):
33
34 2019-06-14  Youenn Fablet  <youenn@apple.com>
35
36         import-w3c-tests should respect WEBKIT_OUTPUTDIR
37         https://bugs.webkit.org/show_bug.cgi?id=198682
38         <rdar://problem/51536931>
39
40         Reviewed by Jonathan Bedard.
41
42         Check for WEBKIT_OUTPUTDIR environment variable to compute the w3c-tests folder.
43         Made some refactoring to also teach WPTPaths users about WEBKIT_OUTPUTDIR.
44
45         * Scripts/webkitpy/common/webkit_finder.py:
46         (WebKitFinder.path_from_webkit_outputdir):
47         * Scripts/webkitpy/w3c/common.py:
48         (WPTPaths):
49         (WPTPaths.checkout_directory):
50         (WPTPaths.wpt_checkout_path):
51         * Scripts/webkitpy/w3c/test_importer.py:
52         (TestImporter.__init__):
53         * Scripts/webkitpy/w3c/test_importer_unittest.py:
54         (test_checkout_directory):
55
56 2019-06-13  Antoine Quint  <graouts@apple.com>
57
58         REGRESSION (r246103) [ Mojave+ WK1 ] Layout Test scrollbars/scrollbar-iframe-click-does-not-blur-content.html is timing out
59         https://bugs.webkit.org/show_bug.cgi?id=198800
60         <rdar://problem/51679634>
61
62         Reviewed by Tim Horton.
63
64         We didn't detect an NSScroller in a sub-frame due to WebHTMLView's implementation of -[NSView hitTest:]. We now use a private method
65         which lets us use the default implementation and correctly returns an NSScroller in a sub-frame.
66
67         * DumpRenderTree/mac/EventSendingController.mm:
68         (eventPressedMouseButtonsSwizzlerForViewAndEvent):
69         (-[EventSendingController mouseDown:withModifiers:]):
70         (-[EventSendingController mouseUp:withModifiers:]):
71         (-[EventSendingController mouseMoveToX:Y:]):
72
73 2019-06-13  Fujii Hironori  <Hironori.Fujii@sony.com>
74
75         [WinCairo][WebKitTestRunner] pixel image dump outputs blank images
76         https://bugs.webkit.org/show_bug.cgi?id=198820
77
78         Reviewed by Ross Kirsling.
79
80         WebView window paints nothing because it is moved out of the
81         screen. Send WM_PRINT with memory DC instead of WM_PAINT as well
82         as DumpRenderTree does.
83
84         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
85         (WTR::PlatformWebView::windowSnapshotImage): Send WM_PRINT instead of BitBlt.
86
87 2019-06-13  Tim Horton  <timothy_horton@apple.com>
88
89         Make it possible for validate-committer-lists to dump a mailmap file
90         https://bugs.webkit.org/show_bug.cgi?id=198517
91
92         Reviewed by Simon Fraser.
93
94         Mailmaps wildly improve the output of various Git tools, including
95         `git shortlog -sne`, mapping committers to our canonical name/email pair.
96
97         * Scripts/validate-committer-lists:
98         (CommitterListFromGit):
99         (CommitterListBugzillaChecker.print_committers_with_invalid_bugzilla_emails):
100         Add some missing legacy username mappings.
101
102         (dump_mailmap):
103         (dump_mailmap.format_email):
104         (dump_mailmap.format_email_with_gitsvn_uuid):
105         (dump_mailmap.map_emails_to_legacy_username):
106         (main):
107         Add `validate-committer-lists --dump-mailmap`, which generates
108         one given committers.json and the existing mapping of legacy username
109         to email addresses that exists in validate-committer-lists.
110
111 2019-06-12  Aakash Jain  <aakash_jain@apple.com>
112
113         Replace double-quotes with single quotes in loadConfig.py
114         https://bugs.webkit.org/show_bug.cgi?id=198792
115
116         Reviewed by Jonathan Bedard.
117
118         * BuildSlaveSupport/ews-build/loadConfig.py:
119         * BuildSlaveSupport/ews-build/steps_unittest.py:
120
121 22019-06-11  Brent Fulgham  <bfulgham@apple.com>
122
123         Add mechanism and test case to check if ITP is active
124         https://bugs.webkit.org/show_bug.cgi?id=198694
125         <rdar://problem/51557704>
126
127         Reviewed by Youenn Fablet.
128
129         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
130         (TEST):
131
132 2019-06-12  Michael Catanzaro  <mcatanzaro@igalia.com>
133
134         [WPE][GTK] Deprecate WebSQL APIs
135         https://bugs.webkit.org/show_bug.cgi?id=195011
136
137         Reviewed by Carlos Garcia Campos.
138
139         * MiniBrowser/gtk/main.c:
140         (gotWebsiteDataCallback):
141         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
142         (testWebsiteDataConfiguration):
143         (testWebsiteDataEphemeral):
144         (testWebsiteDataDatabases):
145
146 2019-06-12  Michael Catanzaro  <mcatanzaro@igalia.com>
147
148         [WPE][GTK] Enable hyperlink auditing
149         https://bugs.webkit.org/show_bug.cgi?id=197845
150
151         Reviewed by Carlos Garcia Campos.
152
153         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
154         (testWebKitSettings):
155
156 2019-06-11  Keith Rollin  <krollin@apple.com>
157
158         Open up xcfilelist processing to more platforms
159         https://bugs.webkit.org/show_bug.cgi?id=198675
160         <rdar://problem/51533238>
161
162         Reviewed by Jonathan Bedard.
163
164         Now that it's been tested, add AppleTV{OS,Simulator} to the set of
165         platforms on which to perform xcfilelist generation/updating.
166
167         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
168         (JavaScriptCoreGenerator):
169         (WebCoreGenerator):
170         (WebKitGenerator):
171
172 2019-06-11  Jonathan Bedard  <jbedard@apple.com>
173
174         webkitpy: Fix device ASan reporting, add testing for report configurations
175         https://bugs.webkit.org/show_bug.cgi?id=198756
176
177         Reviewed by Aakash Jain.
178
179         ASan results were reporting an incorrect style. This indicates we need to be testing this upload
180         configuration thoroughly in webkitpy.
181
182         * Scripts/webkitpy/port/config.py:
183         (clear_cached_configuration): Clearing configurations should clear the ASan cache as well.
184         * Scripts/webkitpy/port/device_port.py:
185         (DevicePort.configuration_for_upload): Add ASan as style.
186         * Scripts/webkitpy/port/ios_device_unittest.py:
187         (IOSDeviceTest):
188         (IOSDeviceTest.test_default_upload_configuration):
189         * Scripts/webkitpy/port/ios_simulator_unittest.py:
190         (IOSSimulatorTest.test_default_upload_configuration):
191         * Scripts/webkitpy/port/mock_drt_unittest.py:
192         (MockDRTPortTest.test_asan_upload_configuration):
193         * Scripts/webkitpy/port/port_testcase.py:
194         (test_default_upload_configuration):
195         (test_debug_upload_configuration):
196         (test_asan_upload_configuration):
197         (test_guard_malloc_configuration):
198         * Scripts/webkitpy/port/watch_simulator_unittest.py:
199         (WatchSimulatorTest):
200         (WatchSimulatorTest.test_default_upload_configuration):
201
202 2019-06-11  Michael Catanzaro  <mcatanzaro@igalia.com>
203
204         tu-berlin university email web interface (Outlook Web App) goes directly to the light version instead of the normal web app
205         https://bugs.webkit.org/show_bug.cgi?id=198749
206
207         Reviewed by Carlos Garcia Campos.
208
209         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
210         (TestWebKitAPI::TEST):
211
212 2019-06-11  Wenson Hsieh  <wenson_hsieh@apple.com>
213
214         Quotes are always inserted as smart quotes on stackblitz.com, causing compilation errors
215         https://bugs.webkit.org/show_bug.cgi?id=198735
216         <rdar://problem/51557159>
217
218         Reviewed by Megan Gardner.
219
220         Add a test to verify that spellcheck="false" disables smart quotes and dashes, but any other value defers to the
221         user's preferences by using UITextSmartQuotesTypeDefault and UITextSmartDashesTypeDefault.
222
223         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
224         (TestWebKitAPI::TEST):
225
226 2019-06-11  Tadeu Zagallo  <tzagallo@apple.com>
227
228         Unreviewed, add myself to the JavaScriptCore watchlist.
229
230         * Scripts/webkitpy/common/config/watchlist:
231
232 2019-06-11  Tadeu Zagallo  <tzagallo@apple.com>
233
234         Unreviewed, change my status to be a WebKit reviewer
235
236         * Scripts/webkitpy/common/config/contributors.json:
237
238 2019-06-11  Carlos Garcia Campos  <cgarcia@igalia.com>
239
240         [WPE] Use new exported image API from fdo backend
241         https://bugs.webkit.org/show_bug.cgi?id=198558
242
243         Reviewed by Philippe Normand.
244
245         * WebKitTestRunner/PlatformWPE.cmake: Do not find fdo backend and libxkb again here, since WKTR depends on
246         WPEToolingBackends that already depends on fdo backend and libxkb
247         * wpe/backends/CMakeLists.txt: Bump fdo requirements to 1.3.0 version.
248         * wpe/backends/HeadlessViewBackend.cpp:
249         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend):
250         (WPEToolingBackends::HeadlessViewBackend::createSnapshot):
251         (WPEToolingBackends::HeadlessViewBackend::performUpdate):
252         (WPEToolingBackends::HeadlessViewBackend::displayBuffer):
253         * wpe/backends/HeadlessViewBackend.h:
254         * wpe/backends/ViewBackend.cpp:
255         (WPEToolingBackends::ViewBackend::initialize):
256         * wpe/backends/ViewBackend.h:
257         * wpe/backends/WindowViewBackend.cpp:
258         (WPEToolingBackends::WindowViewBackend::displayBuffer):
259         * wpe/backends/WindowViewBackend.h:
260
261 2019-06-10  Dewei Zhu  <dewei_zhu@apple.com>
262
263         Extend run-benchmark to allow diagnosing before closing browser on test failure.
264         https://bugs.webkit.org/show_bug.cgi?id=198729
265
266         Reviewed by Ryosuke Niwa.
267
268         Add '--diagnose-directory' option to store diagnose information when test failed.
269
270         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
271         (BenchmarkRunner.__init__):
272         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
273         (BrowserDriver.diagnose_test_failure): Add default no-op function to base class.
274         * Scripts/webkitpy/benchmark_runner/run_benchmark.py: Added '--diagnose-directory' option.
275         (parse_args):
276         (run_benchmark_plan):
277         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py:
278         (WebDriverBenchmarkRunner._run_one_test): Added 'diagnose_test_failure' invocation on test failure.
279         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
280         (WebServerBenchmarkRunner.__init__):
281         (WebServerBenchmarkRunner._run_one_test): Added 'diagnose_test_failure' invocation on test failure.
282
283 2019-06-10  Sam Weinig  <weinig@apple.com>
284
285         Remove Dashboard support
286         https://bugs.webkit.org/show_bug.cgi?id=198615
287
288         Reviewed by Ryosuke Niwa.
289
290         * DumpRenderTree/TestRunner.cpp:
291         (TestRunner::staticFunctions):
292         (setUseDashboardCompatibilityModeCallback): Deleted.
293         * DumpRenderTree/TestRunner.h:
294         * DumpRenderTree/mac/Configurations/Base.xcconfig:
295         * DumpRenderTree/mac/DumpRenderTree.mm:
296         (resetWebViewToConsistentStateBeforeTesting):
297         * DumpRenderTree/mac/TestRunnerMac.mm:
298         (TestRunner::setUseDashboardCompatibilityMode): Deleted.
299         * ImageDiff/cg/Configurations/Base.xcconfig:
300         * Scripts/webkitperl/FeatureList.pm:
301         * TestWebKitAPI/Configurations/Base.xcconfig:
302         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
303         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
304         * TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm: Removed.
305         * WebKitTestRunner/Configurations/Base.xcconfig:
306         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
307         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
308         (WTR::InjectedBundle::beginTesting):
309         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
310         (WTR::TestRunner::setUseDashboardCompatibilityMode): Deleted.
311         * WebKitTestRunner/InjectedBundle/TestRunner.h:
312
313 2019-06-10  Alexey Proskuryakov  <ap@apple.com>
314
315         Tool binaries like WebKitTestRunner have too aggressive stripping, resulting in non-symbolicated crash logs
316         https://bugs.webkit.org/show_bug.cgi?id=198616
317         rdar://problem/36386573
318
319         Reviewed by David Kilzer.
320
321         Adding an explicit STRIP_STYLE to appropriate xcconfigs.
322
323         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
324         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
325         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig:
326         * ImageDiff/cg/Configurations/ImageDiff.xcconfig:
327         * MiniBrowser/Configurations/MiniBrowser.xcconfig:
328         * MobileMiniBrowser/Configurations/MobileMiniBrowser.xcconfig:
329         * TestWebKitAPI/Configurations/TestWTF.xcconfig:
330         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
331         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
332         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
333
334 2019-06-10  Wenson Hsieh  <wenson_hsieh@apple.com>
335
336         [iOS] fast/xsl tests are flaky when run after certain viewport shrink-to-fit tests
337         https://bugs.webkit.org/show_bug.cgi?id=198699
338         <rdar://problem/50501718>
339
340         Reviewed by Simon Fraser.
341
342         Add logic to platformResetPreferencesToConsistentValues, to reset the "ShouldIgnoreMetaViewport" preference.
343         While this is already being adjusted in platformConfigureViewForTest using the correct, TestOptions, this might
344         happen too late, allowing the shrink-to-fit-content heuristic to unexpectedly kick in on tests where testing
345         viewport parameters are used.
346
347         * WebKitTestRunner/ios/TestControllerIOS.mm:
348         (WTR::TestController::platformResetPreferencesToConsistentValues):
349         (WTR::TestController::platformConfigureViewForTest):
350
351 2019-06-10  Yusuke Suzuki  <ysuzuki@apple.com>
352
353         [JSC] UnlinkedCodeBlock should be eventually jettisoned in VM mini mode
354         https://bugs.webkit.org/show_bug.cgi?id=198023
355
356         Reviewed by Saam Barati.
357
358         * Scripts/run-jsc-stress-tests:
359
360 2019-06-10  Timothy Hatcher  <timothy@apple.com>
361
362         Integrate dark mode support for iOS.
363         https://bugs.webkit.org/show_bug.cgi?id=198687
364         rdar://problem/51545643
365
366         Reviewed by Tim Horton.
367
368         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
369
370 2019-06-10  Jonathan Bedard  <jbedard@apple.com>
371
372         webkitpy: xcrun simctl spawn *** launchctl print system output is not utf-8
373         https://bugs.webkit.org/show_bug.cgi?id=198723
374
375         Reviewed by Aakash Jain.
376
377         * Scripts/webkitpy/xcode/simulated_device.py:
378         (SimulatedDevice.is_usable): Do not decode 'print system' output, it's already ASCII.
379
380 2019-06-10  Sihui Liu  <sihui_liu@apple.com>
381
382         [WKHTTPCookieStore getAllCookies:] may return duplicate cookies
383         https://bugs.webkit.org/show_bug.cgi?id=198635
384         <rdar://problem/46010232>
385
386         Reviewed by Ryosuke Niwa.
387
388         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
389         (areCookiesEqual):
390         (TEST):
391
392 2019-06-10  Adrian Perez de Castro  <aperez@igalia.com>
393
394         [JHBuild] Bump shared-mime-info to version ≥ 1.6
395         https://bugs.webkit.org/show_bug.cgi?id=198714
396
397         Reviewed by Carlos Garcia Campos.
398
399         * gtk/jhbuild.modules: Bump shared-mime-info version to 1.10.
400         * gtk/patches/shared-mime-info-xht-glob.patch: Removed.
401         * gtk/patches/shared-mime-info-xhtml-magic.patch: Removed.
402
403 2019-06-10  Philippe Normand  <pnormand@igalia.com>
404
405         [WPE][Qt] Port to new wpe_fdo_egl_exported_image API
406         https://bugs.webkit.org/show_bug.cgi?id=198713
407
408         Reviewed by Carlos Garcia Campos.
409
410         * flatpak/org.webkit.WPEModules.yaml: Include wpebackend-fdo
411         patches currently used in JHBuild.
412
413 2019-06-10  Adrian Perez de Castro  <aperez@igalia.com>
414
415         [GTK][Flatpak] webkit-build fails due to missing libwpe in Flatpak environment
416         https://bugs.webkit.org/show_bug.cgi?id=198711
417
418         Reviewed by Philippe Normand.
419
420         * flatpak/org.webkit.GTK.yaml: Also include modules from
421         org.webkit.WPEModules.yaml, which brings in libwpe and WPEBackend-fdo
422
423 2019-06-10  Zan Dobersek  <zdobersek@igalia.com>
424
425         Unreviewed follow-up to r246148. Add another WPEBackend-fdo patch that
426         avoids double-free condition that's causing bots to exit early.
427
428         * gtk/jhbuild.modules:
429         * gtk/wpebackend-fdo-view-backend-exportable-private-don-t-double-free-ca.patch: Added.
430         * wpe/jhbuild.modules:
431         * wpe/wpebackend-fdo-view-backend-exportable-private-don-t-double-free-ca.patch: Added.
432
433 2019-06-09  Fujii Hironori  <Hironori.Fujii@sony.com>
434
435         [WinCairo][MiniBrowser] Disable MediaCapabilities until it's ready
436         https://bugs.webkit.org/show_bug.cgi?id=198655
437
438         Reviewed by Ross Kirsling.
439
440         MediaCapabilities is enabled by default for WK2, but WinCairo
441         doesn't implemented yet. Disable it in MiniBrowser.
442
443         * MiniBrowser/win/WebKitBrowserWindow.cpp:
444         (WebKitBrowserWindow::create):
445
446 2019-06-08  Wenson Hsieh  <wenson_hsieh@apple.com>
447
448         [iOS] The default application name for user agent when requesting desktop content is still "Mobile/15E148"
449         https://bugs.webkit.org/show_bug.cgi?id=198693
450         <rdar://problem/51555371>
451
452         Reviewed by Tim Horton.
453
454         Augment an existing API test to exercise three additional scenarios:
455             -   The web view configuration's application name is never set; the default should not include
456                 "Mobile/15E148" in desktop mode.
457             -   The application name is explicitly set to nil; the default application name should still not include
458                 "Mobile/15E148".
459             -   The application name is explicitly set to the default value, "Mobile/15E148". WKWebView should honor
460                 this when generating the user agent, even in desktop mode.
461
462         * TestWebKitAPI/ios/PreferredContentMode.mm:
463         (TestWebKitAPI::setUpWebViewForPreferredContentModeTestingWithoutNavigationDelegate):
464         (TestWebKitAPI::setUpWebViewForPreferredContentModeTesting):
465         (TestWebKitAPI::TEST):
466
467 2019-06-08  Zalan Bujtas  <zalan@apple.com>
468
469         [LFC] Unreviewed test gardening.
470
471         Remove rtl tests. They were mistakenly marked as pass.
472
473         * LayoutReloaded/misc/LFC-passing-tests.txt:
474
475 2019-06-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
476
477         REGRESSION (r244182) [WK1]: Page updates should always scheduleCompositingLayerFlush() immediately
478         https://bugs.webkit.org/show_bug.cgi?id=198664
479
480         Reviewed by Simon Fraser.
481
482         Delete repeated entries which were submitted by mistake.
483
484         * Tracing/SystemTracePoints.plist:
485
486 2019-06-07  Wenson Hsieh  <wenson_hsieh@apple.com>
487
488         Allow clients to vend custom -inputView and -inputAccessoryView by overriding WKWebView methods
489         https://bugs.webkit.org/show_bug.cgi?id=198631
490         <rdar://problem/51505431>
491
492         Reviewed by Tim Horton.
493
494         Add an API test that overrides -[WKWebView inputView] and -[WKWebView inputAccessoryView].
495
496         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
497         (-[CustomInputWebView initWithFrame:configuration:inputView:inputAccessoryView:]):
498         (-[CustomInputWebView inputView]):
499         (-[CustomInputWebView inputAccessoryView]):
500         (TestWebKitAPI::TEST):
501
502 2019-06-07  Daniel Bates  <dabates@apple.com>
503
504         [lldb-webkit] Pretty-print all kinds of Documents
505         https://bugs.webkit.org/show_bug.cgi?id=198620
506
507         Reviewed by Simon Fraser.
508
509         Register formatters for all classes derived from WebCore::Document so we get nice summaries
510         without having to drill down in Xcode- or casting- to the base class, Document.
511
512         Older LLDB versions use to do this automatically, but this functionality was removed in newer
513         versions:
514             [[
515                 Warning: previous versions of LLDB defined cascading to mean not only going through typedef
516                 chains, but also through inheritance chains. This feature has been removed since it
517                 significantly degrades performance. You need to set up your formatters for every type in
518                 inheritance chains to which you want the formatter to apply.
519             ]]
520             <https://lldb.llvm.org/use/variable.html> (as of 06/06/2019)
521
522         * lldb/lldb_webkit.py:
523         (__lldb_init_module):
524
525 2019-06-07  Jonathan Bedard  <jbedard@apple.com>
526
527         webkitpy: Support reporting results for uncommon test configurations
528         https://bugs.webkit.org/show_bug.cgi?id=198662
529         <rdar://problem/51524128>
530
531         Reviewed by Aakash Jain.
532
533         * Scripts/webkitpy/layout_tests/controllers/manager.py:
534         (Manager.run): Override wk1 and wk2 flavors with specified flavor.
535         * Scripts/webkitpy/port/base.py:
536         (Port.configuration_for_upload): Set flavor based on options.
537         * Scripts/webkitpy/results/options.py:
538         (upload_options): Add result-report-flavor option.
539         * Scripts/webkitpy/test/main.py:
540         (Tester._run_tests): Set flavor based on options.
541
542 2019-06-07  Wenson Hsieh  <wenson_hsieh@apple.com>
543
544         [iOS] At least 6 API tests are failing due to an exception when writing NSAttributedString to the pasteboard
545         https://bugs.webkit.org/show_bug.cgi?id=198641
546         <rdar://problem/51266310>
547
548         Reviewed by Tim Horton.
549
550         Work around a bug in a lower-level framework, which currently prevents NSAttributedStrings from being written to
551         UIPasteboard by way of -[NSItemProvider registerObject:visibility:]. This is because, when saving a
552         representation of "public.rtfd" to disk, the default suggested filename (determined using CoreServices APIs
553         _UTTypeCreateSuggestedFilename and UTTypeCopyDescription) ends up being nil; UIKit then subsequently tries to
554         append nil as a path component using -URLByAppendingPathComponent:, which throws an exception. This only
555         reproduces on iOS simulator.
556
557         To work around this for the time being, simply avoid writing a representation of "public.rtfd" to disk. This
558         representation is actually ignored by most clients anyways (including WebKit), in favor of using
559         "com.apple.flat-rtfd".
560
561         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
562         (TestWebKitAPI::TEST):
563         * TestWebKitAPI/cocoa/TestWKWebView.mm:
564         (applyWorkaroundToAllowWritingAttributedStringsToItemProviders):
565         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
566
567 2019-06-06  Carlos Garcia Campos  <cgarcia@igalia.com>
568
569         REGRESSION(r244857): [GTK][WPE] Many tests are no longer run in the bots after r244857
570         https://bugs.webkit.org/show_bug.cgi?id=198607
571
572         Reviewed by Michael Catanzaro.
573
574         Since r244857 several test executables are compiled in the base tests directory instead of using their own sub
575         directory. Our scripts to run the tests rely on the tests location to decide whether to run them or not, or
576         determine the type of the tests.
577
578         * Scripts/run-gtk-tests:
579         (GtkTestRunner): Rename TEST_DIRS as TEST_TARGETS and use the executable names for tests not in a subdirectory.
580         (GtkTestRunner._setup_testing_environment): Fix TestWebKitAccessibility directory name.
581         (GtkTestRunner.is_glib_test): Use the test name for the ones not using a subdirectory.
582         (GtkTestRunner.is_google_test): Ditto.
583         * Scripts/run-wpe-tests:
584         (WPETestRunner): Rename TEST_DIRS as TEST_TARGETS and use the executable names for tests not in a subdirectory.
585         (WPETestRunner.is_glib_test): Use the test name for the ones not using a subdirectory.
586         (WPETestRunner.is_google_test): Ditto.
587         * glib/api_test_runner.py:
588         (TestRunner): Rename TEST_DIRS as TEST_TARGETS.
589         (TestRunner._get_tests): Handle test targets which can now contain directories and executables.
590
591 2019-06-06  Keith Rollin  <krollin@apple.com>
592
593         Remove SSL-based tests from TestWebKitAPI on some configurations
594         https://bugs.webkit.org/show_bug.cgi?id=198551
595         <rdar://problem/51424996>
596
597         Reviewed by Jonathan Bedard.
598
599         Not all platforms have SSL handy, so don't include SSL-based tests on
600         those platforms.
601
602         * TestWebKitAPI/TCPServer.cpp:
603         * TestWebKitAPI/TCPServer.h:
604         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
605         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
606         * TestWebKitAPI/config.h:
607
608 2019-06-06  Daniel Bates  <dabates@apple.com>
609
610         [lldb-webkit] TypeError: cannot concatenate 'str' and 'int' objects when prettify SecurityOrigin with
611         non-default port number
612         https://bugs.webkit.org/show_bug.cgi?id=198618
613
614         Reviewed by Brent Fulgham.
615
616         WebCoreSecurityOriginProvider.port() returns an int data type. We need to explicitly convert this to
617         a string before we concatenate it with another string when building the string representation
618         for the WebCore::SecurityOrigin object. Otherwise, Python complains that we are concatenating a str
619         with an int and we don't get a pretty-printed representation for WebCore::SecurityOrigin.
620
621         * lldb/lldb_webkit.py:
622         (WebCoreSecurityOriginProvider.to_string): Call str() on the port before concatenting it.
623
624 2019-06-06  Jonathan Bedard  <jbedard@apple.com>
625
626         Remove obsolete TOOLCHAINS overrides from as asan.xcconfig
627         https://bugs.webkit.org/show_bug.cgi?id=198613
628
629         Reviewed by Alexey Proskuryakov.
630
631         * asan/asan.xcconfig: XCBuild doesn't support overriding toolchains.
632
633 2019-06-06  Jonathan Bedard  <jbedard@apple.com>
634
635         webkitpluginhost: Support ASan as a style
636         https://bugs.webkit.org/show_bug.cgi?id=198586
637         <rdar://problem/51459088>
638
639         Reviewed by Alexey Proskuryakov.
640
641         * Scripts/webkitpy/port/base.py:
642         (Port.configuration_for_upload): Add ASan as a style.
643         * Scripts/webkitpy/port/config.py:
644         (Config._read_configuration):
645         (Config):
646         (Config.asan): Add property to check if the ASan configuration is active.
647         * Scripts/webkitpy/port/config_unittest.py:
648         (ConfigTest.test_default_configuration__scripterror):
649         (ConfigTest):
650         (ConfigTest.test_asan):
651         * Scripts/webkitpy/test/main.py:
652         (Tester._run_tests): Add Asan as a style.
653
654 2019-06-06  Alexey Proskuryakov  <ap@apple.com>
655
656         block-spammers tool doesn't block e-mail
657         https://bugs.webkit.org/show_bug.cgi?id=198570
658
659         Reviewed by Jonathan Bedard.
660
661         * Scripts/block-spammers: (disable_user): Corrected the parameters, Bugzilla doesn't
662         recognize "false" here. Also, request body is unnecessary.
663
664 2019-06-06  Carlos Garcia Campos  <cgarcia@igalia.com>
665
666         [GTK][WPE] Enable PSON
667         https://bugs.webkit.org/show_bug.cgi?id=194979
668
669         Reviewed by Žan Doberšek.
670
671         Add WPEBackend-fdo patch required for PSON to work. It can be removed once we have a new version to depend on.
672
673         * gtk/jhbuild.modules:
674         * gtk/patches/wpebackend-fdo-Handle-the-case-of-new-target-created-for-the-same-v.patch: Added.
675         * wpe/jhbuild.modules:
676         * wpe/patches/wpebackend-fdo-Handle-the-case-of-new-target-created-for-the-same-v.patch: Added.
677
678 2019-06-05  Andy Estes  <aestes@apple.com>
679
680         [macOS] Stop calling -[NSDraggingItem setItem:]
681         https://bugs.webkit.org/show_bug.cgi?id=198588
682         <rdar://problem/48297453>
683
684         On macOS Catalina, use -[NSDraggingItem _initWithItem:] instead.
685
686         Reviewed by Wenson Hsieh.
687
688         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Fixed up file paths in the
689         TestRunnerShared group.
690
691         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
692         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
693         Changed to call -[NSDraggingItem _initWithItem:] when available.
694
695         * TestRunnerShared/spi/AppKitTestSPI.h: Renamed from
696         Tools/DumpRenderTree/mac/AppKitTestSPI.h and moved NSDraggingItem internal interface
697         declarations here from DumpRenderTree.
698
699         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
700         Added TestRunnerShared/spi/AppKitTestSPI.h.
701
702         * TestWebKitAPI/mac/TestDraggingInfo.mm:
703         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
704         Changed to call -[NSDraggingItem _initWithItem:] when available.
705
706 2019-06-05  Jer Noble  <jer.noble@apple.com>
707
708         -[WKWebView _suspendAllMediaPlayback] does not persist across navigation.
709         https://bugs.webkit.org/show_bug.cgi?id=198585
710
711         Reviewed by Chris Dumez.
712
713         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
714         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
715         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSuspendAllMediaPlayback.mm: Added.
716         (TEST):
717         * TestWebKitAPI/Tests/WebKitLegacy/ios/video-with-audio.html:
718
719 2019-06-05  Alex Christensen  <achristensen@webkit.org>
720
721         Re-enable safe browsing in WKWebView
722         https://bugs.webkit.org/show_bug.cgi?id=196161
723         <rdar://problem/49171413>
724
725         Reviewed by Ryosuke Niwa.
726
727         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
728         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
729         (TEST):
730         (safeBrowsingView):
731
732 == Rolled over to ChangeLog-2019-06-05 ==