[GTK] MiniBrowser fails to load injected bundle lib
[WebKit-https.git] / Tools / ChangeLog
1 2014-03-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2
3         [GTK] MiniBrowser fails to load injected bundle lib
4         https://bugs.webkit.org/show_bug.cgi?id=130332
5
6         Reviewed by Anders Carlsson.
7
8         This is because WEBKIT_INJECTED_BUNDLE_PATH env var is set too late.
9
10         * MiniBrowser/gtk/main.c:
11         (main): Make sure WEBKIT_INJECTED_BUNDLE_PATH is set before a web
12         process is spawn.
13
14 2014-03-16  Kim Byung Jun  <bj1987.kim@samsung.com>
15
16         [EFL] Enable TOUCH_SLIDER macro
17         https://bugs.webkit.org/show_bug.cgi?id=130185
18
19         Reviewed by Gyuyoung Kim.
20
21         * Scripts/webkitperl/FeatureList.pm:
22
23 2014-03-16  Zan Dobersek  <zdobersek@igalia.com>
24
25         [GTK][CMake] Build with -fno-rtti
26         https://bugs.webkit.org/show_bug.cgi?id=130261
27
28         Reviewed by Martin Robinson.
29
30         * TestWebKitAPI/CMakeLists.txt: Build TestWebKitAPI with GTEST_HAS_RTTI macro
31         defined to 0 to prevent typeid use in included GTest headers.
32
33 2014-03-16  Brian Burg  <bburg@apple.com>
34
35         Web Inspector: vended backend commands file should be generated as part of the build
36         https://bugs.webkit.org/show_bug.cgi?id=130110
37
38         Reviewed by Timothy Hatcher.
39
40         * Scripts/build-webkit: build WebInspectorUI after WebCore but before WebKit.
41
42 2014-03-16  Diego Pino García  <dpino@igalia.com>
43
44         [GTK] Minibrowser: Add shortcuts for reloading page and reloading page ignoring cache
45         https://bugs.webkit.org/show_bug.cgi?id=128999
46
47         Reviewed by Philippe Normand.
48
49         * MiniBrowser/gtk/BrowserWindow.c:
50         (reloadPage):
51         (reloadPageIgnoringCache):
52         (browser_window_init):
53
54 2014-03-15  Martin Robinson  <mrobinson@igalia.com>
55
56         [GTK] Improve ninja detection in webkitdirs.pm
57         https://bugs.webkit.org/show_bug.cgi?id=129902
58
59         Reviewed by Daniel Bates.
60
61         * Scripts/webkitdirs.pm:
62         (canUseNinja): Use which instead of trying to invoke ninja directly. This also allows
63         us to look for ninja-build as well.
64
65 2014-03-14  Maciej Stachowiak  <mjs@apple.com>
66
67         Replace "Apple Computer, Inc." with "Apple Inc." in copyright headers
68         https://bugs.webkit.org/show_bug.cgi?id=130276
69         <rdar://problem/16266927>
70         
71         Reviewed by Simon Fraser.
72
73         * BuildSlaveSupport/build-launcher-app:
74         * BuildSlaveSupport/build-launcher-dmg:
75         * DumpRenderTree/DumpRenderTree.h:
76         * DumpRenderTree/DumpRenderTreePrefix.h:
77         * DumpRenderTree/GCController.cpp:
78         * DumpRenderTree/GCController.h:
79         * DumpRenderTree/JavaScriptThreading.cpp:
80         * DumpRenderTree/JavaScriptThreading.h:
81         * DumpRenderTree/PixelDumpSupport.cpp:
82         * DumpRenderTree/PixelDumpSupport.h:
83         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
84         * DumpRenderTree/TestRunner.cpp:
85         * DumpRenderTree/TestRunner.h:
86         * DumpRenderTree/WorkQueue.cpp:
87         * DumpRenderTree/WorkQueue.h:
88         * DumpRenderTree/WorkQueueItem.h:
89         * DumpRenderTree/atk/AccessibilityCallbacks.h:
90         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
91         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
92         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
93         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
94         * DumpRenderTree/cg/PixelDumpSupportCG.h:
95         * DumpRenderTree/efl/EditingCallbacks.cpp:
96         * DumpRenderTree/efl/EditingCallbacks.h:
97         * DumpRenderTree/efl/EventSender.cpp:
98         * DumpRenderTree/efl/EventSender.h:
99         * DumpRenderTree/efl/GCControllerEfl.cpp:
100         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
101         * DumpRenderTree/efl/TestRunnerEfl.cpp:
102         * DumpRenderTree/gtk/DumpRenderTree.cpp:
103         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
104         * DumpRenderTree/gtk/EditingCallbacks.cpp:
105         * DumpRenderTree/gtk/EditingCallbacks.h:
106         * DumpRenderTree/gtk/EventSender.cpp:
107         * DumpRenderTree/gtk/EventSender.h:
108         * DumpRenderTree/gtk/GCControllerGtk.cpp:
109         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
110         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp:
111         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h:
112         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
113         * DumpRenderTree/gtk/TextInputController.cpp:
114         * DumpRenderTree/gtk/TextInputController.h:
115         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL:
116         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm:
117         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
118         * DumpRenderTree/mac/AppleScriptController.h:
119         * DumpRenderTree/mac/AppleScriptController.m:
120         * DumpRenderTree/mac/CheckedMalloc.cpp:
121         * DumpRenderTree/mac/CheckedMalloc.h:
122         * DumpRenderTree/mac/DumpRenderTree.mm:
123         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
124         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
125         * DumpRenderTree/mac/DumpRenderTreeMac.h:
126         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
127         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
128         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
129         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
130         * DumpRenderTree/mac/EditingDelegate.h:
131         * DumpRenderTree/mac/EditingDelegate.mm:
132         * DumpRenderTree/mac/EventSendingController.h:
133         * DumpRenderTree/mac/EventSendingController.mm:
134         * DumpRenderTree/mac/FrameLoadDelegate.h:
135         * DumpRenderTree/mac/FrameLoadDelegate.mm:
136         * DumpRenderTree/mac/GCControllerMac.mm:
137         * DumpRenderTree/mac/MockWebNotificationProvider.h:
138         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
139         * DumpRenderTree/mac/NavigationController.h:
140         * DumpRenderTree/mac/NavigationController.m:
141         * DumpRenderTree/mac/ObjCController.h:
142         * DumpRenderTree/mac/ObjCController.m:
143         * DumpRenderTree/mac/ObjCPlugin.h:
144         * DumpRenderTree/mac/ObjCPlugin.m:
145         * DumpRenderTree/mac/ObjCPluginFunction.h:
146         * DumpRenderTree/mac/ObjCPluginFunction.m:
147         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
148         * DumpRenderTree/mac/PolicyDelegate.h:
149         * DumpRenderTree/mac/PolicyDelegate.mm:
150         * DumpRenderTree/mac/ResourceLoadDelegate.h:
151         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
152         * DumpRenderTree/mac/TestRunnerMac.mm:
153         * DumpRenderTree/mac/TextInputController.h:
154         * DumpRenderTree/mac/TextInputController.m:
155         * DumpRenderTree/mac/UIDelegate.h:
156         * DumpRenderTree/mac/UIDelegate.mm:
157         * DumpRenderTree/mac/WorkQueueItemMac.mm:
158         * DumpRenderTree/win/DRTDataObject.cpp:
159         * DumpRenderTree/win/DRTDataObject.h:
160         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
161         * DumpRenderTree/win/DRTDropSource.cpp:
162         * DumpRenderTree/win/DRTDropSource.h:
163         * DumpRenderTree/win/DraggingInfo.h:
164         * DumpRenderTree/win/DumpRenderTree.cpp:
165         * DumpRenderTree/win/DumpRenderTreeWin.h:
166         * DumpRenderTree/win/EditingDelegate.cpp:
167         * DumpRenderTree/win/EditingDelegate.h:
168         * DumpRenderTree/win/EventSender.cpp:
169         * DumpRenderTree/win/EventSender.h:
170         * DumpRenderTree/win/FrameLoadDelegate.cpp:
171         * DumpRenderTree/win/FrameLoadDelegate.h:
172         * DumpRenderTree/win/GCControllerWin.cpp:
173         * DumpRenderTree/win/HistoryDelegate.cpp:
174         * DumpRenderTree/win/HistoryDelegate.h:
175         * DumpRenderTree/win/MD5.cpp:
176         * DumpRenderTree/win/MD5.h:
177         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
178         * DumpRenderTree/win/PolicyDelegate.cpp:
179         * DumpRenderTree/win/PolicyDelegate.h:
180         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
181         * DumpRenderTree/win/ResourceLoadDelegate.h:
182         * DumpRenderTree/win/TestRunnerWin.cpp:
183         * DumpRenderTree/win/TextInputController.cpp:
184         * DumpRenderTree/win/TextInputController.h:
185         * DumpRenderTree/win/TextInputControllerWin.cpp:
186         * DumpRenderTree/win/UIDelegate.cpp:
187         * DumpRenderTree/win/UIDelegate.h:
188         * DumpRenderTree/win/WorkQueueItemWin.cpp:
189         * EWebLauncher/main.c:
190         * GtkLauncher/main.c:
191         * ImageDiff/efl/ImageDiff.cpp:
192         * ImageDiff/gtk/ImageDiff.cpp:
193         * MiniBrowser/gtk/main.c:
194         * Scripts/SpacingHeuristics.pm:
195         * Scripts/VCSUtils.pm:
196         * Scripts/bisect-builds:
197         * Scripts/build-dumprendertree:
198         * Scripts/build-jsc:
199         * Scripts/build-webkit:
200         * Scripts/check-dom-results:
201         * Scripts/check-for-exit-time-destructors:
202         * Scripts/check-for-global-initializers:
203         * Scripts/commit-log-editor:
204         * Scripts/compare-timing-files:
205         * Scripts/debug-minibrowser:
206         * Scripts/debug-safari:
207         * Scripts/do-file-rename:
208         * Scripts/find-extra-includes:
209         * Scripts/generate-coverage-data:
210         * Scripts/make-script-test-wrappers:
211         * Scripts/malloc-tree:
212         * Scripts/old-run-webkit-tests:
213         * Scripts/parse-malloc-history:
214         * Scripts/report-include-statistics:
215         * Scripts/resolve-ChangeLogs:
216         * Scripts/run-bindings-tests:
217         * Scripts/run-iexploder-tests:
218         * Scripts/run-javascriptcore-tests:
219         * Scripts/run-jsc:
220         * Scripts/run-launcher:
221         * Scripts/run-leaks:
222         * Scripts/run-mangleme-tests:
223         * Scripts/run-minibrowser:
224         * Scripts/run-pageloadtest:
225         * Scripts/run-regexp-tests:
226         * Scripts/run-safari:
227         * Scripts/run-sunspider:
228         * Scripts/run-webkit-app:
229         * Scripts/sampstat:
230         * Scripts/set-webkit-configuration:
231         * Scripts/sort-Xcode-project-file:
232         * Scripts/sort-export-file:
233         * Scripts/split-file-by-class:
234         * Scripts/sunspider-compare-results:
235         * Scripts/svn-apply:
236         * Scripts/svn-create-patch:
237         * Scripts/svn-unapply:
238         * Scripts/test-webkit-scripts:
239         * Scripts/update-javascriptcore-test-results:
240         * Scripts/update-webkit:
241         * Scripts/update-webkit-auxiliary-libs:
242         * Scripts/update-webkit-dependency:
243         * Scripts/update-webkit-localizable-strings:
244         * Scripts/update-webkit-support-libs:
245         * Scripts/update-webkit-wincairo-libs:
246         * Scripts/webkit-build-directory:
247         * Scripts/webkitdirs.pm:
248         (installedSafariPath):
249         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
250         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
251         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
252         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
253         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
254         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
255         * Scripts/webkitperl/features.pm:
256         * Scripts/webkitperl/httpd.pm:
257         * Scripts/webkitpy/bindings/main.py:
258         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
259         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
260         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
261         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
262         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
263         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
264         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
265         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
266         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
267         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.h:
268         * WebKitTestRunner/PixelDumpSupport.cpp:
269         * WebKitTestRunner/PixelDumpSupport.h:
270         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
271         * WinLauncher/WinLauncher.cpp:
272         * WinLauncher/WinLauncher.h:
273         * WinLauncher/stdafx.cpp:
274         * WinLauncher/stdafx.h:
275
276 2014-03-14  Filip Pizlo  <fpizlo@apple.com>
277
278         Sometimes we need to be explicit about the SDK when running ranlib on Darwin
279         https://bugs.webkit.org/show_bug.cgi?id=130265
280
281         Reviewed by Michael Saboff.
282
283         * Scripts/build-webkit:
284         * Scripts/copy-webkitlibraries-to-product-directory:
285
286 2014-03-14  Landry Breuil  <landry@openbsd.org>
287
288         Recognize openbsd/netbsd and am64 archs in Tools/Scripts.
289         Also allow to set MAKE in the environment.
290         https://bugs.webkit.org/show_bug.cgi?id=129991
291
292         Reviewed by Andreas Kling.
293
294         * Scripts/webkitdirs.pm:
295         (determineArchitecture):
296         (determineNumberOfCPUs):
297         (isBSD):
298         (buildAutotoolsProject):
299         * Scripts/webkitpy/common/system/platforminfo.py:
300         (PlatformInfo.__init__):
301         (PlatformInfo.is_openbsd):
302         (PlatformInfo):
303         (PlatformInfo.is_netbsd):
304         (PlatformInfo._determine_os_name):
305
306 2014-03-14  Dean Jackson  <dino@apple.com>
307
308         Remove libWebKitSystemInterfaceLion.a
309         https://bugs.webkit.org/show_bug.cgi?id=130254
310
311         Reviewed by Geoffrey Garen and Andreas Kling.
312
313         No need to copy the Lion libraries into the build.
314
315         * Scripts/copy-webkitlibraries-to-product-directory:
316
317 2014-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
318
319         [EFL][MiniBrowser] Revise help messages of command line parameters
320         https://bugs.webkit.org/show_bug.cgi?id=130222
321
322         Reviewed by Csaba Osztrogonác.
323
324         Correct the default value description and make help messages to be consistent.
325
326         * MiniBrowser/efl/main.c:
327
328 2014-03-12  Sergio Villar Senin  <svillar@igalia.com>
329
330         Rename DEFINE_STATIC_LOCAL to DEPRECATED_DEFINE_STATIC_LOCAL
331         https://bugs.webkit.org/show_bug.cgi?id=129612
332
333         Reviewed by Darin Adler.
334
335         For new code use static NeverDestroyed<T> instead.
336
337         * DumpRenderTree/JavaScriptThreading.cpp:
338         (javaScriptThreadsMutex):
339         (javaScriptThreads):
340         * DumpRenderTree/efl/EventSender.cpp:
341         (touchPointList):
342         (delayedEventQueue):
343         * DumpRenderTree/win/FrameLoadDelegate.cpp:
344         (delegatesWithDelayedWork):
345         * Scripts/check-for-exit-time-destructors:
346         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp:
347         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
348         (testsMap):
349
350 2014-03-13  Sanghyup Lee  <sh53.lee@samsung.com>
351
352         [EFL][WK2] Fix compilation warning in Minibrowser
353         https://bugs.webkit.org/show_bug.cgi?id=130132
354
355         Reviewed by Csaba Osztrogonác.
356
357         Replace mktemp() with mkstemp() to fix compilation warning in MiniBrowser.
358
359         * MiniBrowser/efl/main.c:
360         (on_download_request):
361
362 2014-03-13  Filip Pizlo  <fpizlo@apple.com>
363
364         FTL should support IsBlah
365         https://bugs.webkit.org/show_bug.cgi?id=130202
366
367         Reviewed by Geoffrey Garen.
368         
369         Running existing JSRegress tests with noInline gives us coverage for these
370         changes. Chances are, this will also give coverage for other interesting things
371         as well.
372
373         * Scripts/run-jsc-stress-tests:
374
375 2014-03-12  Brian Burg  <bburg@apple.com>
376
377         Web Inspector: Remove unused callId parameter from evaluateInWebInspector
378         https://bugs.webkit.org/show_bug.cgi?id=129744
379
380         Reviewed by Timothy Hatcher.
381
382         * DumpRenderTree/TestRunner.cpp:
383         (evaluateInWebInspectorCallback):
384         * DumpRenderTree/TestRunner.h:
385         * DumpRenderTree/efl/TestRunnerEfl.cpp:
386         (TestRunner::evaluateInWebInspector):
387         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
388         (TestRunner::evaluateInWebInspector):
389         * DumpRenderTree/mac/TestRunnerMac.mm:
390         (TestRunner::evaluateInWebInspector):
391         * DumpRenderTree/win/TestRunnerWin.cpp:
392         (TestRunner::evaluateInWebInspector):
393         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
394         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
395         (WTR::TestRunner::evaluateInWebInspector):
396         * WebKitTestRunner/InjectedBundle/TestRunner.h:
397
398 2014-03-13  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
399
400         [GTK] build-webkit shouldn't show error message when ninja isn't installed
401         https://bugs.webkit.org/show_bug.cgi?id=130129
402
403         Reviewed by Csaba Osztrogonác.
404
405         * Scripts/webkitdirs.pm:
406         (canUseNinja): Redirecting stderr to /dev/null
407
408 2014-03-13  Andres Gomez  <agomez@igalia.com>
409
410         [GTK] "Tools/jhbuild/jhbuild-wrapper --gtk" build fails even after running Tools/gtk/install-dependencies due to missing proper libxml2 python bindings
411         https://bugs.webkit.org/show_bug.cgi?id=130092
412
413         Reviewed by Csaba Osztrogonác.
414
415         Added "python-dev" as dependency for deb based distros. It is
416         already present for rpm based distros. This dependency will allow
417         libxml2 to generate its python bindings, needed by gtk-doc.
418
419         * gtk/install-dependencies:
420
421 2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
422
423         Unreviewed. Fix GTK+ cmake build after r165488.
424
425         * MiniBrowser/gtk/CMakeLists.txt: Add CMAKE_BINARY_DIR to include dirs.
426
427 2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
428
429         [GTK][CMAKE] Remove compile warnings about GTK+ deprecated API
430         https://bugs.webkit.org/show_bug.cgi?id=130014
431
432         Reviewed by Martin Robinson.
433
434         Include cmake or autotools config header.
435
436         * MiniBrowser/gtk/BrowserDownloadsBar.c:
437         * MiniBrowser/gtk/BrowserSearchBar.c:
438         * MiniBrowser/gtk/BrowserWindow.c:
439         * MiniBrowser/gtk/main.c:
440
441 2014-03-12  Commit Queue  <commit-queue@webkit.org>
442
443         Unreviewed, rolling out r165471.
444         https://bugs.webkit.org/show_bug.cgi?id=130139
445
446         Didn't really fix the issue and broke another bot (Requested
447         by mrobinson on #webkit).
448
449         Reverted changeset:
450
451         "[CMake] Newer versions of CMake cannot find older versions of
452         Freetype"
453         https://bugs.webkit.org/show_bug.cgi?id=130107
454         http://trac.webkit.org/changeset/165471
455
456 2014-03-11  Filip Pizlo  <fpizlo@apple.com>
457
458         It should be possible to build WebKit with FTL on iOS
459         https://bugs.webkit.org/show_bug.cgi?id=130116
460
461         Reviewed by Dan Bernstein.
462
463         * Scripts/build-webkit:
464         * Scripts/copy-webkitlibraries-to-product-directory:
465
466 2014-03-12  Brent Fulgham  <bfulgham@apple.com>
467
468         [Win] Remove use of QTSDK
469         https://bugs.webkit.org/show_bug.cgi?id=130049
470
471         Reviewed by Darin Adler.
472
473         * DumpRenderTree/win/DumpRenderTree.cpp:
474         (initialize): Remove QuickTime code.
475         * win/AssembleBuildLogs/AssembleLogs.cmd: Don't grab logs from
476         building QTMovieWin.
477
478 2014-03-12  Martin Robinson  <mrobinson@igalia.com>
479
480         [GTK][CMAKE] Too verbose build output
481         https://bugs.webkit.org/show_bug.cgi?id=130076
482
483         Reviewed by Carlos Garcia Campos.
484
485         Instead of building with cmake --build which isn't smart about pretty printing and
486         colors, we build with a script which calls the proper build command.
487
488         * Scripts/webkitdirs.pm:
489         (buildCMakeGeneratedProject): For GTK+ call the script that we generate during
490         the CMake configuration pass.
491
492 2014-03-11  Martin Robinson  <mrobinson@igalia.com>
493
494         [CMake] Newer versions of CMake cannot find older versions of Freetype
495         https://bugs.webkit.org/show_bug.cgi?id=130107
496
497         Reviewed by Gustavo Noronha Silva.
498
499         * gtk/jhbuildrc: Work around a bug in newer CMakes by giving the FREETYPE_DIR hint
500         to CMake during jhbuild initialization.
501
502 2014-03-12  Zalan Bujtas  <zalan@apple.com>
503
504         Add hiDPI support for compositing content in DumpRenderTree/WebKitTestRunner
505         https://bugs.webkit.org/show_bug.cgi?id=129961
506
507         Reviewed by Simon Fraser.
508
509         Now scaled content can go through the window capturing mechanism too for compositing content.
510         AppleMagnifiedMode is redundant.
511
512         * DumpRenderTree/mac/DumpRenderTree.mm:
513         (setDefaultsToConsistentValuesForTesting):
514         (runTest):
515         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
516         (createBitmapContextFromWebView):
517         * WebKitTestRunner/PlatformWebView.h:
518         * WebKitTestRunner/cg/TestInvocationCG.cpp:
519         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
520         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
521         (WTR::PlatformWebView::didInitializeClients):
522         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
523         (WTR::PlatformWebView::forceWindowFramesChanged):
524         * WebKitTestRunner/mac/main.mm:
525         (setDefaultsToConsistentValuesForTesting):
526
527 2014-03-12  Anton Obzhirov  <a.obzhirov@samsung.com>
528
529         Unreviewed. Add myself as a committer.
530
531         * Scripts/webkitpy/common/config/contributors.json:
532
533 2014-03-12  Ryuan Choi  <ryuan.choi@samsung.com>
534
535         Unreviewed build fix on the EFL port when used lower version of ATK
536
537         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
538         (WTR::AccessibilityUIElement::y): Fixed typo.
539
540 2014-03-11  Myles C. Maxfield  <mmaxfield@apple.com>
541
542         Some images are blank in the rebaseline server UI
543         https://bugs.webkit.org/show_bug.cgi?id=130104
544
545         Reviewed by Tim Horton.
546
547         Let the server check for images in the 'retries' directory
548         if it can't find an image otherwise.
549
550         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
551         (RebaselineHTTPRequestHandler.test_result):
552
553 2014-03-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
554
555         [GTK][CMake] --update-gtk has no effect
556         https://bugs.webkit.org/show_bug.cgi?id=130088
557
558         Reviewed by Philippe Normand.
559
560         * Scripts/webkitdirs.pm:
561         (buildCMakeProjectOrExit): call update-webkitgtk-libs if --update-gtk has been passed
562         as an argument.
563
564 2014-03-10  Myles C. Maxfield  <mmaxfield@apple.com>
565
566         Add "System Font" to the list of whitelisted DRT fonts
567         https://bugs.webkit.org/show_bug.cgi?id=130046
568
569         Reviewed by Darin Adler.
570
571         * DumpRenderTree/mac/DumpRenderTree.mm:
572         (allowedFontFamilySet):
573         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
574
575 2014-03-11  Martin Robinson  <mrobinson@igalia.com>
576
577         [GTK] The jhbuild environment should set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_PATH
578         https://bugs.webkit.org/show_bug.cgi?id=130064
579
580         Reviewed by Philippe Normand.
581
582         * efl/jhbuildrc: Remove duplicated code.
583         * gtk/jhbuildrc: Remove duplicated code.
584         * jhbuild/jhbuildrc_common.py:
585         (init): Move duplicated code from jhbuildrc's and extend setting CMake environment variables to
586         GTK+. We always set the CMAKE_LIBRARY_PATH, which should be harmless for EFL 32-bit systems.
587         and is apparently necessary for GTK+.
588
589 2014-03-11  László Langó  <llango.u-szeged@partner.samsung.com>
590
591         check-webkit-style failed to complain about missing braces
592         https://bugs.webkit.org/show_bug.cgi?id=34189
593
594         Reviewed by Ryosuke Niwa.
595
596         * Scripts/webkitpy/style/checkers/cpp.py:
597         (check_braces):
598         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
599         (WebKitStyleTest.test_braces):
600
601 2014-03-11  László Langó  <llango.u-szeged@partner.samsung.com>
602
603         Remove Qt cruft from style checker.
604         https://bugs.webkit.org/show_bug.cgi?id=130085
605
606         Reviewed by Csaba Osztrogonác.
607
608         There is no 'foreach' keyword in c++. That was a Qt feature
609         added in: http://trac.webkit.org/changeset/46113
610         Qt was removed from WebKit, so we should remove the checks
611         of this keyword from check-webkit-style scripts.
612
613         * Scripts/webkitpy/style/checkers/cpp.py:
614         (check_spacing_for_function_call):
615         (check_spacing):
616         (check_braces):
617         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
618         (CppStyleTest.test_mismatching_spaces_in_parens):
619         (CppStyleTest.test_spacing_for_fncall):
620         (WebKitStyleTest.test_braces):
621
622 2014-03-11  Martin Hodovan  <mhodovan@inf.u-szeged.hu>
623
624         [GTK] update-webkitgtk-libs needs itstool
625         https://bugs.webkit.org/show_bug.cgi?id=130082
626
627         After http://trac.webkit.org/changeset/165110 WebKitGTK+ uses gtk-doc 1.20.
628         itstool is a dependency of building gtk-doc from version 1.19, so it should
629         be added to Tools/gtk/install-dependencies script, too.
630
631         Reviewed by Philippe Normand.
632
633         * gtk/install-dependencies:
634
635 2014-03-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
636
637         webkitbot rollout ChangeLogs should be nicer
638         https://bugs.webkit.org/show_bug.cgi?id=122654
639
640         Reviewed by Csaba Osztrogonác.
641
642         Added bug urls and descriptions of rolled out patches to the rollout changelog
643         if they are present in the original changelog. Additionally removed the list of
644         changed files and functions.
645
646         * Scripts/webkitpy/common/checkout/changelog.py:
647         (ChangeLog.update_with_unreviewed_message): Cut off the list of modified files.
648         * Scripts/webkitpy/common/checkout/checkout.py:
649         (Checkout._changelog_data_for_revision): Store bug description.
650         * Scripts/webkitpy/common/checkout/checkout_mock.py:
651         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
652         (CheckoutTest.test_commit_info_for_revision):
653         * Scripts/webkitpy/common/checkout/commitinfo.py:
654         (CommitInfo.bug_description): Added.
655         (CommitInfo.to_json):
656         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
657         (CommitInfoTest.test_commit_info_creation):
658         * Scripts/webkitpy/tool/commands/download.py:
659         (AbstractRolloutPrepCommand._prepare_state): Store bug ids and descriptions of rolled
660         out patches for creating rollout changelog.
661         (CreateRollout._prepare_state): Remove obsolete comments and code, the bug id that
662         caused the regression is stored in state["bug_blocked"] now.
663         * Scripts/webkitpy/tool/commands/download_unittest.py:
664         (test_prepare_rollout):
665         (test_create_rollout_multiple_revision):
666         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
667         (PrepareChangeLogForRevert._message_for_revert): Add bug urls and descriptions of
668         rolled out patches to the changelog.
669         (PrepareChangeLogForRevert.run):
670         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
671         (UpdateChangeLogsForRevertTest):
672         (test_message_for_revert):
673         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
674         (ReopenBugAfterRollout.run):
675
676 2014-03-11  Krzysztof Czech  <k.czech@samsung.com>
677
678         [ATK] Adjust WKTR/DRT to use new API from ATK 2.11.90
679         https://bugs.webkit.org/show_bug.cgi?id=130021
680
681         Reviewed by Mario Sanchez Prada.
682
683         Replace deprecated functions to use new API from ATK 2.11.90.
684
685         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
686         (AccessibilityUIElement::x):
687         (AccessibilityUIElement::y):
688         (AccessibilityUIElement::width):
689         (AccessibilityUIElement::height):
690         (AccessibilityUIElement::clickPointX):
691         (AccessibilityUIElement::clickPointY):
692         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
693         (WTR::AccessibilityUIElement::x):
694         (WTR::AccessibilityUIElement::y):
695         (WTR::AccessibilityUIElement::width):
696         (WTR::AccessibilityUIElement::height):
697         (WTR::AccessibilityUIElement::clickPointX):
698         (WTR::AccessibilityUIElement::clickPointY):
699
700 2014-03-11  Krzysztof Czech  <k.czech@samsung.com>
701
702         [ATK] Expose aria-posinset and aria-setsize through object attributes
703         https://bugs.webkit.org/show_bug.cgi?id=130011
704
705         Reviewed by Chris Fleizach.
706
707         Added missing implementation of numberAttributeValue both to WKTR and DRT.
708
709         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
710         (AccessibilityUIElement::numberAttributeValue):
711         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
712         (WTR::AccessibilityUIElement::numberAttributeValue):
713
714 2014-03-10  Brent Fulgham  <bfulgham@apple.com>
715
716         [Win] Unreviewed build fix.
717
718         Some bad Windows code was committed at some point that prevents the Apple Windows port
719         from finding its runtime dependencies reliably.
720
721         * win/DLLLauncher/DLLLauncherMain.cpp:
722         (appleApplicationSupportDirectory): Restored this function.
723         (modifyPath): Update to use appleApplicationSupportDirectory function.
724
725 2014-03-10  Zoltan Horvath  <zoltan@webkit.org>
726
727         Let the user define the full address of the performance-site-server for uploading results
728         https://bugs.webkit.org/show_bug.cgi?id=129819
729
730         Reviewed by Ryosuke Niwa.
731
732         Currently perftestsrunner.py assumes that the server uses https protocol all the time, which
733         can be confusing. It's more straightforward, if you need to define explicitly the server's full
734         address along with the protocol, when you're using this parameter. I added HTTPS as the default
735         protocol for now, in order to avoid breaking the perf bots.
736
737         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
738         (_upload_json):
739         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
740         (MainTest.test_upload_json):
741
742 2014-03-10  Brent Fulgham  <bfulgham@apple.com>
743
744         [Win] Pass environment to Pre-Build, Pre-Link, and Post-Build Stages.
745         https://bugs.webkit.org/show_bug.cgi?id=130023
746
747         Reviewed by Dean Jackson.
748
749         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add missing
750         /SAFESEH flag to DLL launcher process.
751
752 2014-03-09  Martin Robinson  <mrobinson@igalia.com>
753
754         RunGtkWebKitGObjectDOMBindingsAPIBreakTests should be added to the BuildAndTestFactory not the TestFactory
755         https://bugs.webkit.org/show_bug.cgi?id=129980
756
757         Reviewed by Carlos Garcia Campos.
758
759         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add RunGtkWebKitGObjectDOMBindingsAPIBreakTests to the correct factory.
760
761 2014-03-09  Martin Robinson  <mrobinson@igalia.com>
762
763         [GTK] Remove the WebView source-mode WebKit1 test
764         https://bugs.webkit.org/show_bug.cgi?id=129976
765
766         Reviewed by Carlos Garcia Campos.
767
768         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Remove the source-mode test.
769
770 2014-03-08  Martin Robinson  <mrobinson@igalia.com>
771
772         Unreviewed build fix for GTKbuild after the switch to CMake
773
774         * gtk/common.py:
775         (is_cmake_build): Like r165284, we need to assume CMake by default, since the
776         test-only bot doesn't have any build files.
777
778 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
779
780         [GTK] built-product-archive does not handle GTK+ CMake build
781         https://bugs.webkit.org/show_bug.cgi?id=129941
782
783         * BuildSlaveSupport/built-product-archive:
784         (archiveBuiltProduct): Fix the build by adding support to built-product-archive for
785         the CMake build.
786
787 2014-03-07  Lorenzo Tilve  <ltilve@igalia.com>
788
789         [GTK] Include CMake into install-dependencies script
790         https://bugs.webkit.org/show_bug.cgi?id=129909
791
792         Reviewed by Martin Robinson.
793
794         As since r165267 buid-webkit uses CMake by default, the dependency
795         with 'cmake' package should be introduced.
796
797         * gtk/install-dependencies: Ditto.
798
799 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
800
801         REGRESSION(165267): Broke a webkitpy unit tests
802         https://bugs.webkit.org/show_bug.cgi?id=129904
803
804         Reviewed by Jon Honeycutt.
805
806         * Scripts/webkitpy/port/gtk.py: Flip the default test to assume CMake by default.
807         (GtkPort._is_cmake_build):
808
809 2014-03-07  Andres Gomez  <agomez@igalia.com>
810
811         [GTK] webkit-patch setup-git-clone fails even after running Tools/gtk/install-dependencies
812         https://bugs.webkit.org/show_bug.cgi?id=129893
813
814         Reviewed by Martin Robinson.
815
816         Added "git-svn" as dependency for deb based distros and,
817         additionally, "subversion" for rpm based distros.
818
819         * gtk/install-dependencies:
820
821 2014-03-07  Roger Fong  <roger_fong@apple.com>
822
823         Remove dummy setSystemWebGLLoadPolicy client method.
824         https://bugs.webkit.org/show_bug.cgi?id=129873.
825
826         Reviewed by Dean Jackson.
827
828         * WebKitTestRunner/TestController.cpp:
829         (WTR::TestController::createWebViewWithOptions):
830
831 2014-03-07  Mark Hahnenberg  <mhahnenberg@apple.com>
832
833         run-jsc-stress-tests doesn't eagerly report test failures when using the shell runner
834         https://bugs.webkit.org/show_bug.cgi?id=129886
835
836         Reviewed by Mark Lam.
837
838         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Added a "verbose" mode to the shell runner.
839         If we're in verbose mode, then we don't redirect any output when running each test. If we're not
840         in verbose mode then we redirect stdout to /dev/null and allow any stderr output through.
841         * Scripts/run-jsc-stress-tests: Redirect any sort of error output to stderr so that it will 
842         make it through when in non-verbose mode.
843
844 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
845
846         [GTK] buid-webkit should use CMake by default
847         https://bugs.webkit.org/show_bug.cgi?id=129855
848
849         Reviewed by Carlos Garcia Campos.
850
851         Make the CMake build the default GTK+ build when using build-webkit. This will
852         ensure that all bots are using CMake. We do this by swapping --gtk and --gtkcmake,
853         so that we have --gtk and --gtkautotools.
854
855         * Scripts/webkitdirs.pm: Swap --gtkcmake/--gtk for --gtk/--gtkautotools.
856         * Scripts/webkitpy/port/gtk.py: Ditto.
857
858 2014-03-06  Martin Robinson  <mrobinson@igalia.com>
859
860         [CMake] [GTK] Build with ninja when it is available
861         https://bugs.webkit.org/show_bug.cgi?id=129805
862
863         Reviewed by Philippe Normand.
864
865         * Scripts/webkitdirs.pm:
866         (canUseNinja): Added this helper which tries to execute Ninja, in an effort to determine
867         if it's available on the system.
868         (cmakeGeneratedBuildfile): Return the path to the generated build file. Only Unix support ATM.
869         (generateBuildSystemFromCMakeProject): For GTK+ compile with Ninja when possible.
870
871 2014-03-06  Filip Pizlo  <fpizlo@apple.com>
872
873         If the FTL is build-time enabled then it should be run-time enabled.
874
875         Rubber stamped by Geoffrey Garen.
876
877         * Scripts/run-jsc-stress-tests:
878
879 2014-03-06  Mark Hahnenberg  <mhahnenberg@apple.com>
880
881         detectFailures in run-jsc-stress-tests can report everything was ok if too many tests fail
882         https://bugs.webkit.org/show_bug.cgi?id=129837
883
884         Reviewed by Michael Saboff.
885
886         ls test_fail_* can fail if there are too many files that match. We then swallow that error, which makes everything seem ok.
887         The fix is to use find instead of ls like we do in shell-runner.sh.
888
889         * Scripts/run-jsc-stress-tests:
890
891 2014-03-06  Joseph Pecoraro  <pecoraro@apple.com>
892
893         filter-build-webkit should not strip .o
894         https://bugs.webkit.org/show_bug.cgi?id=129614
895
896         Reviewed by Dean Jackson.
897
898         This makes it much easier to jump from the failing output at
899         the end back up to the compile errors earlier in the output.
900
901         * Scripts/filter-build-webkit:
902
903 2014-03-06  Anders Carlsson  <andersca@apple.com>
904
905         Build WebKit2 before building WebKit
906         https://bugs.webkit.org/show_bug.cgi?id=129831
907         <rdar://problem/15920020>
908
909         Reviewed by Dan Bernstein.
910
911         * Scripts/build-webkit:
912         Always build WebKit2 and make sure to build it before WebKit when building on Mac.
913
914 2014-03-06  ChangSeok Oh  <changseok.oh@collabora.com>
915
916         make-3.82 fails to build on ARM/Linux
917         https://bugs.webkit.org/show_bug.cgi?id=107926
918
919         Reviewed by Martin Robinson.
920
921         Some ARM/Linux systems don't support PAGE_SIZE macro so that it causes a build failure.
922         The related bug reporting is here. https://lists.debian.org/debian-kernel/2014/02/msg00274.html
923         To avoid this, I propose to use sysconf(_SC_PAGESIZE) instead of PAGE_SIZE
924         where it is not defined. See more details, http://linux.die.net/man/2/getpagesize
925
926         * gtk/patches/make-3.82-arg-list-length.patch:
927
928 2014-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
929
930         [GTK] Close the page when the view is disposed instead of when finalized
931         https://bugs.webkit.org/show_bug.cgi?id=129783
932
933         Reviewed by Sergio Villar Senin.
934
935         Add test case but disabled for now because it's affetected by bug #129684.
936
937         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
938         (testProcessPerWebView):
939
940 2014-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
941
942         [GTK] MiniBrowser crashes when opening several urls passed as command line options
943         https://bugs.webkit.org/show_bug.cgi?id=129738
944
945         Reviewed by Sergio Villar Senin.
946
947         The problem is that we are calling g_object_unref() for the
948         WebKitWebSettings everytime we set it to a WebKitWebView, but the
949         view only increases the reference counter when the settings is not
950         the same it currently has. We should release our reference once.
951
952         * MiniBrowser/gtk/main.c:
953         (createBrowserWindow):
954         (main):
955
956 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
957
958         [GTK][CMake] Tarball is created with wrong tarball paths
959         https://bugs.webkit.org/show_bug.cgi?id=129496
960
961         Reviewed by Daniel Bates.
962
963         * gtk/make-dist.py:
964         (Manifest.__init__): I inadvertently inverted the logic of these checks when
965         landing the original patch with some suggestions from the reviewer. With the
966         checks corrected, the tarball path is constructed properly.
967
968 2014-03-05  Jae Hyun Park  <jaepark@webkit.org>
969
970         Unreviewed. Update my email in contributors.json
971
972         * Scripts/webkitpy/common/config/contributors.json:
973
974 2014-03-05  Dean Jackson  <dino@apple.com>
975
976         [WebGL] Use WKSI to see what the system policy for WebGL is
977         https://bugs.webkit.org/show_bug.cgi?id=129722
978         <rdar://problem/15790542>
979
980         Reviewed by Tim Horton.
981
982         Dummy entry for setSystemWebGLLoadPolicy.
983
984         * WebKitTestRunner/TestController.cpp:
985         (WTR::TestController::createWebViewWithOptions):
986
987 2014-03-03  Martin Robinson  <mrobinson@igalia.com>
988
989         [GTK][CMake] Generate documentation for the DOM bindings
990         https://bugs.webkit.org/show_bug.cgi?id=126211
991
992         Reviewed by Carlos Garcia Campos.
993
994         * gtk/GNUmakefile.am: No longer generation sections and SGML files in the makefile.
995         * gtk/generate-gtkdoc: Call the code from webkitdom.py to generate sections and SGML files.
996         * gtk/generate-webkitdom-doc-files: Removed.
997         * gtk/webkitdom.py: Moved WebKit GObject DOM bindings doc generation code here, so
998         that it can be called by generate-gtkdoc.
999
1000 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
1001
1002         [GTK][CMake] build-webkit should rerun cmake if the Makefile is missing
1003         https://bugs.webkit.org/show_bug.cgi?id=129380
1004
1005         Reviewed by Philippe Normand.
1006
1007         * Scripts/webkitdirs.pm:
1008         (generateBuildSystemFromCMakeProject): Check for the existence of the Makefile before
1009         skipping CMake execution.
1010
1011 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
1012
1013         [GTK] The jhbuild environment should have the latest stable release of gtk-doc
1014         https://bugs.webkit.org/show_bug.cgi?id=129651
1015
1016         Reviewed by Philippe Normand.
1017
1018         * gtk/jhbuild.modules: Add gtk-doc to the list of modules.
1019
1020 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
1021
1022         [GTK] Give the WebKit GObject DOM bindings API break detection it's own buildbot bubble
1023         https://bugs.webkit.org/show_bug.cgi?id=129637
1024
1025         Reviewed by Carlos Garcia Campos.
1026
1027         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1028         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests): Added this test runner.
1029         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.commandComplete): Run the breakage test command and scan the output.
1030         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.evaluateCommand): Return failure if there is missing API (an API break).
1031         New API typically just requires a rebaseline and isn't necessarily a faiulre.
1032         (TestFactory.__init__): Add the test for GTK+.
1033         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Add a unit test for the new bubble.
1034
1035 2014-03-05  Krzysztof Czech  <k.czech@samsung.com>
1036
1037         [ATK] Expose missing functionalities of AtkTableCell to AT
1038         https://bugs.webkit.org/show_bug.cgi?id=129492
1039
1040         Reviewed by Mario Sanchez Prada.
1041
1042         Reducing some code by using new API of AtkTableCell.
1043
1044         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1045         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1046
1047 2014-03-04  Alex Christensen  <achristensen@webkit.org>
1048
1049         Preparing to run layout tests on Wincairo.
1050         https://bugs.webkit.org/show_bug.cgi?id=129709
1051
1052         Reviewed by Brent Fulgham.
1053
1054         * Scripts/webkitdirs.pm:
1055         (setPathForRunningWebKitApp):
1056         Add GStreamer directory for WinCairo running layout tests.
1057         * win/DLLLauncher/DLLLauncherMain.cpp:
1058         (modifyPath):
1059         Added the WinCairo bin32 or bin64 directory for running WinLauncher.
1060
1061 2014-03-04  Martin Robinson  <mrobinson@igalia.com>
1062
1063         [GTK] Simplify the GObject DOM bindings API break check into one step
1064         https://bugs.webkit.org/show_bug.cgi?id=129571
1065
1066         Reviewed by Carlos Garcia Campos.
1067
1068         * GNUmakefile.am: Add the API break check to 'make check.'
1069         * gtk/check-for-webkitdom-api-breaks: Added. A combination of the two removed scripts.
1070         * gtk/check-gdom-symbols: Removed.
1071         * gtk/webkitdom.py: Added.
1072         (header_name_list_from_gtkdoc_config_file): Gets the names of all headers from the gtkdoc config file.
1073         (get_all_webkitdom_symbol_files): Find the symbol files from the names.
1074
1075 2014-03-03  Simon Fraser  <simon.fraser@apple.com>
1076
1077         Add Jeremy Jones to the contributors list as a contributor.
1078
1079         * Scripts/webkitpy/common/config/contributors.json:
1080
1081 2014-03-03  Adenilson Cavalcanti  <cavalcantii@gmail.com>
1082
1083         Unreviewed. Update contact email.
1084         https://bugs.webkit.org/show_bug.cgi?id=129610
1085
1086         * Scripts/webkitpy/common/config/contributors.json:
1087
1088 2014-03-02  Brian Burg  <bburg@apple.com>
1089
1090         Web Inspector model tests load wrong inspector page under WebKitTestRunner
1091         https://bugs.webkit.org/show_bug.cgi?id=129460
1092
1093         Reviewed by Dan Bernstein.
1094
1095         Don't unconditionally open the inspector before running an inspector test.
1096         Instead, the test should request that the inspector open when it's ready.
1097
1098         This change was lost during a rebase, but is the same change made to
1099         DumpRenderTree.
1100
1101         * WebKitTestRunner/TestInvocation.cpp:
1102         (WTR::TestInvocation::invoke): 
1103
1104 2014-03-02  Darin Adler  <darin@apple.com>
1105
1106         Split TextIteratorBehavior into a separate header
1107         https://bugs.webkit.org/show_bug.cgi?id=129578
1108
1109         Reviewed by Sam Weinig.
1110
1111         * Scripts/sort-export-file: Added special cases to the script so you can just paste link errors
1112         from WebKit in and the script will add them in as unconditional exports. This makes the "add"
1113         task easy, but the remove is still a bit of a pain.
1114
1115 2014-03-02  Darin Adler  <darin@apple.com>
1116
1117         Sort Mac platform export files so they merge better
1118         https://bugs.webkit.org/show_bug.cgi?id=129581
1119
1120         Reviewed by Sam Weinig.
1121
1122         * Scripts/sort-export-file: Added. Quickly whipped together script that sorts
1123         Mac export files in a "canonical" order for this project.
1124
1125 2014-02-28  Zalan Bujtas  <zalan@apple.com>
1126
1127         Add hiDPI support to DumpRenderTree/WebKitTestRunner without the need of reloading the test case.
1128         https://bugs.webkit.org/show_bug.cgi?id=129438
1129
1130         Reviewed by Simon Fraser.
1131
1132         'hidpi-' prefixed test cases now trigger 2x scale factor on the testing
1133         offscreen window. It makes testing subpixel rendering and positioning possible.
1134
1135         Both the offscreen window's and WebKit's scaling are set accordingly.
1136
1137         * DumpRenderTree/mac/DumpRenderTree.mm:
1138         (createWebViewAndOffscreenWindow): cleanup
1139         (destroyWebViewAndOffscreenWindow): cleanup
1140         (dumpRenderTree):
1141         (changeWindowScaleIfNeeded):
1142         (runTest):
1143         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1144         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1145         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]): cleanup
1146         * WebKitTestRunner/PlatformWebView.h:
1147         * WebKitTestRunner/TestInvocation.cpp:
1148         (WTR::changeWindowScaleIfNeeded):
1149         (WTR::TestInvocation::invoke):
1150         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1151         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1152         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1153         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1154         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1155         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1156         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1157         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1158
1159 2014-02-28  Anders Carlsson  <andersca@apple.com>
1160
1161         Remove logging.
1162
1163         Reviewed by Dan Bernstein.
1164
1165         * MiniBrowser/mac/WK2BrowserWindowController.m:
1166         (-[WK2BrowserWindowController browsingContextController:decidePolicyForNavigationAction:decisionHandler:]):
1167
1168 2014-02-28  Daniel Bates  <dabates@apple.com>
1169
1170         [iOS] DumpRenderTree Perl Support may build against wrong SDK and toolchain
1171         https://bugs.webkit.org/show_bug.cgi?id=129163
1172
1173         Reviewed by David Kilzer.
1174
1175         Fixes an issue where DumpRenderTree Perl Support may build with the specified
1176         iOS Simulator SDK and toolchain instead of using the OS X SDK and toolchain.
1177         This issue manifests itself in a build failure when building the IPhoneSimulatorNotification
1178         bundle.
1179
1180         Currently we build DumpRenderTree Perl Support with respect to the variable SDKROOT,
1181         which is specified either explicitly when building with MAKE(1) or implicitly by
1182         build-{dumprendertree, webkit}. Instead we should always build Perl Support using
1183         the OS X SDK and toolchain since the built products are only applicable to OS X.
1184
1185         * DumpRenderTree/ios/PerlSupport/Makefile:
1186
1187 2014-02-28  Commit Queue  <commit-queue@webkit.org>
1188
1189         Unreviewed, rolling out r164859.
1190         http://trac.webkit.org/changeset/164859
1191         https://bugs.webkit.org/show_bug.cgi?id=129483
1192
1193         caused WK1 crashes (DumpRenderTree) (Requested by zalan on
1194         #webkit).
1195
1196         * DumpRenderTree/mac/DumpRenderTree.mm:
1197         (createWebViewAndOffscreenWindow):
1198         (dumpRenderTree):
1199         (runTest):
1200         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1201         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1202         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
1203         * WebKitTestRunner/PlatformWebView.h:
1204         * WebKitTestRunner/TestInvocation.cpp:
1205         (WTR::TestInvocation::invoke):
1206         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1207         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1208         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1209         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1210         (-[WebKitTestRunnerWindow frameRespectingFakeOrigin]):
1211
1212 2014-02-28  Zalan Bujtas  <zalan@apple.com>
1213
1214         Add hiDPI support to DumpRenderTree/WebKitTestRunner without the need of reloading the test case.
1215         https://bugs.webkit.org/show_bug.cgi?id=129438
1216
1217         Reviewed by Simon Fraser.
1218
1219         'hidpi-' prefixed test cases now trigger 2x scale factor on the testing
1220         offscreen window. It makes testing subpixel rendering and positioning possible.
1221
1222         Both the offscreen window's and WebKit's scaling are set accordingly.
1223
1224         * DumpRenderTree/mac/DumpRenderTree.mm:
1225         (createWebViewAndOffscreenWindow): unrelated cleanup.
1226         (destroyWebViewAndOffscreenWindow): unrelated cleanup.
1227         (dumpRenderTree):
1228         (changeOffscreenWindowScaleIfNeeded):
1229         (runTest):
1230         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1231         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1232         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]): cleanup.
1233         * WebKitTestRunner/PlatformWebView.h:
1234         * WebKitTestRunner/TestInvocation.cpp:
1235         (WTR::changeOffscreenWindowScaleIfNeeded):
1236         (WTR::TestInvocation::invoke):
1237         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1238         (WTR::PlatformWebView::changeOffscreenWindowScaleIfNeeded):
1239
1240 2014-02-27  Brian Burg  <bburg@apple.com>
1241
1242         Web Inspector: model tests should use a special Test.html inspector page
1243         https://bugs.webkit.org/show_bug.cgi?id=129190
1244
1245         Reviewed by Timothy Hatcher.
1246
1247         Remove code that immediately opens the Web Inspector based on the file path of the test.
1248         Instead, the test page should request that the inspector open inside its `test()` method.
1249
1250         This change is necessary because otherwise, the inspector would be opened too early for
1251         InspectorController::isUnderTest to get set in time, so the normal Web Inspector page
1252         will get loaded instead of the minimal test page.
1253
1254         * DumpRenderTree/efl/DumpRenderTree.cpp:
1255         (createTestRunner):
1256         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1257         (runTest):
1258         * DumpRenderTree/mac/DumpRenderTree.mm:
1259         (runTest):
1260         * DumpRenderTree/win/DumpRenderTree.cpp:
1261         (runTest):
1262
1263 2014-02-27  Laszlo Vidacs  <lvidacs.u-szeged@partner.samsung.com>
1264
1265         check-webkit-style indentation false alarm in WebKit/win/WebNodeHighlight.cpp
1266         https://bugs.webkit.org/show_bug.cgi?id=127076
1267
1268         Reviewed by Anders Carlsson.
1269
1270         Avoid match for :: as start of a member initialization list. Modify expression to match
1271         after a colon either non-colon character or end of line.
1272
1273         * Scripts/webkitpy/style/checkers/cpp.py:
1274         (check_member_initialization_list):
1275         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1276         (WebKitStyleTest.test_member_initialization_list):
1277
1278 2014-02-27  Renata Hodovan  <rhodovan.u-szeged@partner.samsung.com>
1279
1280         Unreviewed. Update my email addresses in contributors.json.
1281
1282         * Scripts/webkitpy/common/config/contributors.json:
1283
1284 2014-02-27  Alberto Garcia  <berto@igalia.com>
1285
1286         [gtk-doc] UnicodeEncodeError: 'ascii' codec can't encode character
1287         https://bugs.webkit.org/show_bug.cgi?id=128927
1288
1289         Reviewed by Philippe Normand.
1290
1291         Encode manually the data for sys.{stdout,stderr}.write.
1292
1293         * gtk/gtkdoc.py:
1294         (GTKDoc._run_command):
1295
1296 2014-02-27  Andres Gomez  <agomez@igalia.com>
1297
1298         Unreviewed. Add myself to watchlists
1299
1300         * Scripts/webkitpy/common/config/watchlist: Add myself to
1301         watchlists.
1302
1303 2014-02-27  Andres Gomez  <agomez@igalia.com>
1304
1305         Unreviewed, rolling out r164790.
1306         http://trac.webkit.org/changeset/164790
1307
1308         Revert r164790 because of erroneous commit log
1309
1310         * Scripts/webkitpy/common/config/watchlist:
1311
1312 2014-02-27  Krzysztof Czech  <k.czech@samsung.com>
1313
1314         [ATK] Utilize AtkTableCell to expose directly AccessibilityTableCell to AT
1315         https://bugs.webkit.org/show_bug.cgi?id=129250
1316
1317         Reviewed by Mario Sanchez Prada.
1318
1319         Changing version of ATK to 2.11.90, because it introduces AtkTableCell interface.
1320         Implementing methods so that we could test column/row headers represented as an array of cells.
1321
1322         * DumpRenderTree/AccessibilityUIElement.cpp:
1323         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1324         (AccessibilityUIElement::columnHeaders):
1325         (AccessibilityUIElement::rowHeaders):
1326         * DumpRenderTree/win/AccessibilityUIElementWin.cpp: Adding empty stubs, to not break compilation.
1327         (AccessibilityUIElement::columnHeaders):
1328         (AccessibilityUIElement::rowHeaders):
1329         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1330         (WTR::AccessibilityUIElement::rowHeaders):
1331         (WTR::AccessibilityUIElement::columnHeaders):
1332         * efl/jhbuild.modules:
1333         * gtk/jhbuild.modules:
1334
1335 2014-02-27  Andres Gomez  <agomez@igalia.com>
1336
1337         Unreviewed. Add myself to watchlists
1338
1339         * Scripts/webkitpy/common/config/watchlist: Add myself to
1340         watchlists.
1341
1342 2014-02-27  Andres Gomez  <agomez@igalia.com>
1343
1344         Unreviewed. Add myself as a committer.
1345
1346         * Scripts/webkitpy/common/config/contributors.json:
1347
1348 2014-02-27  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1349
1350         Unreviewed. Add Víctor Jáquez and myself to watchlists
1351
1352         * Scripts/webkitpy/common/config/watchlist: Add Víctor Jáquez and
1353         myself to watchlists.
1354
1355 2014-02-26  Julien Brianceau  <jbriance@cisco.com>
1356
1357         Unreviewed. Add myself as a committer.
1358
1359         * Scripts/webkitpy/common/config/contributors.json:
1360
1361 2014-02-26  Laszlo Vidacs  <lvidacs.u-szeged@partner.samsung.com>
1362
1363         Unreviewed. Moved myself to the list of committers.
1364
1365         * Scripts/webkitpy/common/config/contributors.json:
1366
1367 2014-02-24  Martin Robinson  <mrobinson@igalia.com>
1368
1369         [GTK] Reduplicate common.top_level_path in scripts
1370         https://bugs.webkit.org/show_bug.cgi?id=129291
1371
1372         Reviewed by Philippe Normand.
1373
1374         Duplicate common.top_level_path and avoid polluting many scripts with awkward system
1375         path manipulation and weird dependencies on the jhbuild infrastructure.
1376
1377         * Scripts/run-gtk-tests: Use common again.
1378         (TestRunner._setup_testing_environment): Ditto.
1379         * gtk/check-gdom-symbols: Ditto.
1380         * gtk/common.py:
1381         (top_level_path): Re-add top_level_path..
1382         (get_build_path): Use the builtin top_level_path again.
1383         * gtk/find-make-dist-errors: Use common again.
1384         (get_missing_headers): Ditto.
1385         * gtk/generate-inspector-gresource-manifest.py: Ditto.
1386
1387 2014-02-26  Mark Hahnenberg  <mhahnenberg@apple.com>
1388
1389         runscript: line 42: /bin/ls: Argument list too long
1390         https://bugs.webkit.org/show_bug.cgi?id=129376
1391
1392         Reviewed by Michael Saboff.
1393
1394         The "test_script_*" can expand to more things than can be passed as arguments on the command line. 
1395         We should use find instead, which generates the list of files rather than expanding them all on 
1396         the command line and spitting them back out.
1397
1398         * Scripts/jsc-stress-test-helpers/shell-runner.sh: 
1399
1400 2014-02-26  Martin Robinson  <mrobinson@igalia.com>
1401
1402         ENABLE_PROMISES is improperly specified as ENABLE_PROMISE in Features.pm
1403         https://bugs.webkit.org/show_bug.cgi?id=129377
1404
1405         Reviewed by Csaba Osztrogonác.
1406
1407         * Scripts/webkitperl/FeatureList.pm: Properly specify the promises feature as ENABLE_PROMISES.
1408
1409 2014-02-26  Manuel Rego Casasnovas  <rego@igalia.com>
1410
1411         [GTK] Re-enable gtk-doc in EWS
1412         https://bugs.webkit.org/show_bug.cgi?id=128369
1413
1414         Reviewed by Carlos Garcia Campos.
1415
1416         Enable again gtk-doc generation in EWS once bug #128417 has been fixed.
1417
1418         * Scripts/webkitpy/common/config/ports.py:
1419         (GtkPort.build_webkit_command): Add --disable-gtk-doc arg.
1420         (GtkWK2Port.build_webkit_command): Ditto.
1421         * Scripts/webkitpy/common/config/ports_unittest.py:
1422         (DeprecatedPortTest.test_gtk_port): Ditto.
1423         (DeprecatedPortTest.test_gtk_wk2_port): Ditto.
1424
1425 2014-02-26  Martin Robinson  <mrobinson@igalia.com>
1426
1427         [GTK] generate-gtkdoc can fail with WebKit1 or WebKit2 only builds
1428         https://bugs.webkit.org/show_bug.cgi?id=129319
1429
1430         Reviewed by Carlos Garcia Campos.
1431
1432         * gtk/generate-gtkdoc:
1433         (get_generator_for_config): Properly handle the situation where the pkgconfig file is missing.
1434
1435 2014-02-25  Mihai Maerean  <mmaerean@adobe.com>
1436
1437         Unreviewed. Add myself as a committer.
1438
1439         * Scripts/webkitpy/common/config/contributors.json:
1440
1441 2014-02-25  Sergio Villar Senin  <svillar@igalia.com>
1442
1443         [CSS Grid Layout] Add ENABLE flag
1444         https://bugs.webkit.org/show_bug.cgi?id=129153
1445
1446         Reviewed by Simon Fraser.
1447
1448         Added ENABLE_CSS_GRID_LAYOUT feature flag. It's on by default for
1449         all ports for developer builds.
1450
1451         * Scripts/webkitperl/FeatureList.pm:
1452
1453 2014-02-25  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
1454
1455         Added myself as a committer.
1456
1457         Unreviewed.
1458
1459         * Scripts/webkitpy/common/config/contributors.json:
1460
1461 2014-02-25  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
1462
1463         Unreviewed. Moved myself to the list of committers.
1464
1465         * Scripts/webkitpy/common/config/contributors.json:
1466
1467 2014-02-25  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
1468
1469         Move myself to the committers list.
1470
1471         Unreviewed.
1472
1473         * Scripts/webkitpy/common/config/contributors.json:
1474
1475 2014-02-25  László Langó  <llango.u-szeged@partner.samsung.com>
1476
1477         Unreviewed. Add myself as a committer.
1478
1479         * Scripts/webkitpy/common/config/contributors.json:
1480
1481 2014-02-25  Commit Queue  <commit-queue@webkit.org>
1482
1483         Unreviewed, rolling out r164639.
1484         http://trac.webkit.org/changeset/164639
1485         https://bugs.webkit.org/show_bug.cgi?id=129302
1486
1487         gtk-doc still have problems in EWS (Requested by rego on
1488         #webkit).
1489
1490         * Scripts/webkitpy/common/config/ports.py:
1491         (GtkPort.build_webkit_command):
1492         (GtkWK2Port.build_webkit_command):
1493         * Scripts/webkitpy/common/config/ports_unittest.py:
1494         (DeprecatedPortTest.test_gtk_port):
1495         (DeprecatedPortTest.test_gtk_wk2_port):
1496
1497 2014-02-25  Manuel Rego Casasnovas  <rego@igalia.com>
1498
1499         [GTK] Re-enable gtk-doc in EWS
1500         https://bugs.webkit.org/show_bug.cgi?id=128369
1501
1502         Reviewed by Carlos Garcia Campos.
1503
1504         Enable again gtk-doc generation in EWS once bug #128417 has been fixed.
1505
1506         * Scripts/webkitpy/common/config/ports.py:
1507         (GtkPort.build_webkit_command): Add --disable-gtk-doc arg.
1508         (GtkWK2Port.build_webkit_command): Ditto.
1509         * Scripts/webkitpy/common/config/ports_unittest.py:
1510         (DeprecatedPortTest.test_gtk_port): Ditto.
1511         (DeprecatedPortTest.test_gtk_wk2_port): Ditto.
1512
1513 2014-02-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1514
1515         [GTK] Mark view source mode methods as deprecated
1516         https://bugs.webkit.org/show_bug.cgi?id=128920
1517
1518         Reviewed by Martin Robinson.
1519
1520         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1521         (beforeAll): Remove view mode test.
1522
1523 2014-02-24  Martin Robinson  <mrobinson@igalia.com>
1524
1525         [GTK] generate-gtkdoc should not generate documentation for source files for unbuilt source files
1526         https://bugs.webkit.org/show_bug.cgi?id=128417
1527
1528         Reviewed by Carlos Garcia Campos.
1529
1530         * gtk/GNUmakefile.am: Make the documentation process depend on the configuration files.
1531         * gtk/generate-gtkdoc: Switch from using hard-coded configurations to reading them from
1532         a makefile. This allows accepting a header list from the build system, which can be used
1533         to dynamically build a list of ignored files. We can ignore any source file that doesn't
1534         have a corresponding header file on the header list. 
1535         * gtk/gtkdoc.py: Now accept a headers parameter, which can be used instead of passing just
1536         source directories to gtkdoc-scan.
1537
1538 2014-02-24  Anders Carlsson  <andersca@apple.com>
1539
1540         Add a DefaultVisitedLinkProvider and route visited link actions through it
1541         https://bugs.webkit.org/show_bug.cgi?id=129285
1542
1543         Reviewed by Dan Bernstein.
1544
1545         * MiniBrowser/mac/AppDelegate.m:
1546         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
1547         Set a shared history so we'll get visited link tracking.
1548
1549         * MiniBrowser/mac/WK1BrowserWindowController.m:
1550         (-[WK1BrowserWindowController awakeFromNib]):
1551         Set a group name.
1552
1553 2014-02-24  Dan Bernstein  <mitz@apple.com>
1554
1555         iOS build fix after r164577.
1556
1557         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1558         (AccessibilityUIElement::selectedChildrenCount):
1559         (AccessibilityUIElement::selectedChildAtIndex):
1560
1561 2014-02-24  David Kilzer  <ddkilzer@apple.com>
1562
1563         [ASan] Remove methods from ignore list that no longer cause crashes
1564         <http://webkit.org/b/129257>
1565
1566         Reviewed by Anders Carlsson.
1567
1568         * asan/webkit-asan-ignore.txt: Remove old methods.
1569
1570 2014-02-24  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1571
1572         Extract common parts from jhbuildrc files.
1573         https://bugs.webkit.org/show_bug.cgi?id=125986
1574
1575         Reviewed by Csaba Osztrogonác.
1576
1577         Co-authored with Peter Szanka <h868064@stud.u-szeged.hu>.
1578
1579         * Scripts/run-gtk-tests:
1580         (TestRunner._setup_testing_environment):
1581         * efl/common.py: Removed.
1582         * efl/jhbuildrc:
1583         * gtk/check-gdom-symbols:
1584         * gtk/common.py:
1585         (binary_build_path):
1586         (get_build_path):
1587         * gtk/find-make-dist-errors:
1588         (get_missing_headers):
1589         * gtk/generate-gtkdoc:
1590         (get_webkit2_options):
1591         (get_webkit1_options.src_path):
1592         (get_webkit1_options):
1593         (get_webkitdom_options.src_path):
1594         (get_webkitdom_options):
1595         * gtk/generate-inspector-gresource-manifest.py:
1596         * gtk/jhbuildrc:
1597         * jhbuild/jhbuildrc_common.py: Added.
1598         (script_path):
1599         (top_level_path):
1600         (init):
1601
1602 2014-02-24  Diego Pino Garcia  <dpino@igalia.com>
1603
1604         Unreviewed. Fix code indentation and spacing.
1605
1606         * Scripts/webkitpy/style/checkers/js.py:
1607         (SingleQuoteChecker.check):
1608
1609 2014-02-24  Krzysztof Czech  <k.czech@samsung.com>
1610
1611         [ATK] Wrong selected element at a given index in a list box.
1612         https://bugs.webkit.org/show_bug.cgi?id=129039
1613
1614         Reviewed by Chris Fleizach.
1615
1616         Added missing implementation and proposed some new function for testing selection
1617         in a list boxes.
1618
1619         * DumpRenderTree/AccessibilityUIElement.cpp:
1620         (setSelectedChildAtIndexCallback):
1621         (removeSelectionAtIndexCallback):
1622         (AccessibilityUIElement::getJSClass):
1623         * DumpRenderTree/AccessibilityUIElement.h:
1624         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1625         (AccessibilityUIElement::selectedChildrenCount):
1626         (AccessibilityUIElement::selectedChildAtIndex):
1627         (AccessibilityUIElement::setSelectedChildAtIndex):
1628         (AccessibilityUIElement::removeSelectionAtIndex):
1629         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1630         (AccessibilityUIElement::selectedChildrenCount):
1631         (AccessibilityUIElement::selectedChildAtIndex):
1632         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1633         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
1634         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
1635         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1636         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1637         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1638         (WTR::AccessibilityUIElement::selectedChildAtIndex):
1639         (WTR::AccessibilityUIElement::selectedChildrenCount):
1640         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
1641         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
1642
1643 2014-02-23  Diego Pino García  <dpino@igalia.com>
1644
1645         [GTK] Fix build after Web Inspector code reorganization (r164543)
1646         https://bugs.webkit.org/show_bug.cgi?id=129231
1647
1648         Reviewed by Dean Jackson.
1649
1650         * gtk/generate-inspector-gresource-manifest.py:
1651         Modify paths to Web Inspector code.
1652
1653 2014-02-23  Martin Robinson  <mrobinson@igalia.com>
1654
1655         [GTK] generate-gtkdoc should use argparse
1656         https://bugs.webkit.org/show_bug.cgi?id=128418
1657
1658         Reviewed by Carlos Garcia Campos.
1659
1660         * gtk/generate-gtkdoc: Get all arguments from argparse, pass then as parameters
1661         to all functions, and guard the main routine with a __name__ == __main__ check.
1662
1663 2014-02-23  Martin Robinson  <mrobinson@igalia.com>
1664
1665         [GTK][CMake] Many plugin tests fail when running WebKit1 layout tests
1666         https://bugs.webkit.org/show_bug.cgi?id=129191
1667
1668         Reviewed by Anders Carlsson.
1669
1670         * DumpRenderTree/PlatformGTK.cmake: Properly specify the library build directory
1671         for the GTK+ DumpRenderTree build. We could manually construct this path, but the
1672         name of the directory is "lib" and not "libs". Instead we should use the CMake
1673         variable specifically assigned to this task.
1674
1675 2014-02-23  David Kilzer  <ddkilzer@apple.com>
1676
1677         [ASan] Add JSC::DFG::prepareOSREntry() to ignore list
1678         <http://webkit.org/b/129209>
1679
1680         Reviewed by Geoffrey Garen.
1681
1682         * asan/webkit-asan-ignore.txt: Add DFG::prepareOSREntry() to the
1683         ignore list to make ASan builds usable again.  Follow-up
1684         investigation is tracked by <rdar://problem/16055903>.
1685
1686 2014-02-20  David Farler  <dfarler@apple.com>
1687
1688         Make old-run-webkit-tests work with iOS Simulator WebKitTestRunner
1689         https://bugs.webkit.org/show_bug.cgi?id=128622
1690
1691         Reviewed by Simon Fraser.
1692
1693         With this change, we now have layout tests running in both DumpRenderTree
1694         and WebKitTestRunner, with WebKit and WebKit2 used respectively in the iOS
1695         simulator.
1696
1697         * Scripts/old-run-webkit-tests:
1698         In general, make any specific reference to DumpRenderTree
1699         able to refer to WebKitTestRunner wherever possible:
1700         - Rename functions to remove DRT-specific naming.
1701         - Name FIFOs after the tool that is being used.
1702         -- Clean up FIFO creation code
1703         Other necessary changes:
1704         - Allow use of an ios-sim-wk2 platform.
1705         - Clean up platform hierarchy creation where the simulator platform behavior differed.
1706         * WebKitTestRunner/TestController.cpp:
1707         Open FIFOs to get dumps out of the simulator as we do in DumpRenderTree.
1708         (WTR::TestController::TestController):
1709         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1710         Copy the injected bundle into the app bundle.
1711
1712 2014-02-21  Joseph Pecoraro  <pecoraro@apple.com>
1713
1714         run-webkit-httpd fails to find httpd configuation file.
1715
1716         Reviewed by Ryosuke Niwa.
1717
1718         * Scripts/webkitperl/httpd.pm:
1719         (getHTTPDConfigPathForTestDirectory):
1720
1721 2014-02-21  Eric Carlson  <eric.carlson@apple.com>
1722
1723         Fix TimeRanges layering violations
1724         https://bugs.webkit.org/show_bug.cgi?id=128717
1725
1726         Reviewed by Jer Noble.
1727
1728         * TestWebKitAPI/Tests/WebCore/TimeRanges.cpp: TimeRanges* -> TimeRanges&.
1729         (TestWebKitAPI::TEST):
1730
1731 2014-02-21  Diego Pino García  <dpino@igalia.com>
1732
1733         Web Inspector: update check-webkit-style to flag single quotes in WebInspectorUI projects
1734         https://bugs.webkit.org/show_bug.cgi?id=128422
1735
1736         Reviewed by Joseph Pecoraro.
1737
1738         * Scripts/webkitpy/style/checkers/js.py:
1739         (JSChecker.__init__):
1740         (JSChecker.check):
1741         (SingleQuoteChecker):
1742         (SingleQuoteChecker.__init__):
1743         (SingleQuoteChecker.check):
1744         * Scripts/webkitpy/style/checkers/js_unittest.py:
1745         (JSTestCase.assertError.error_for_test):
1746         (JSTestCase.assertError):
1747         (JSTestCase.test_no_error):
1748         (JSTestCase.test_error):
1749
1750 == Rolled over to ChangeLog-2014-02-20 ==