[ews-build] Do not print worker environment variables in each build step [part 2]
[WebKit-https.git] / Tools / ChangeLog
1 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
2
3         [ews-build] Do not print worker environment variables in each build step [part 2]
4         https://bugs.webkit.org/show_bug.cgi?id=199405
5
6         Reviewed by Jonathan Bedard.
7
8         * BuildSlaveSupport/ews-build/steps.py:
9         (CheckOutSpecificRevision.__init__): Disabled logging of environment variables.
10         (CleanWorkingDirectory.__init__): Ditto.
11         (RunBindingsTests.__init__): Ditto.
12         (RunWebKitPerlTests.__init__): Ditto.
13         (RunWebKitPyTests.__init__): Ditto.
14         (CompileWebKit.__init__): Ditto.
15         (ArchiveTestResults.__init__): Ditto.
16         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
17
18 2019-07-02  Jer Noble  <jer.noble@apple.com>
19
20         Pipe suport for 'cenc' init data type into CDMFairPlayStreaming
21         https://bugs.webkit.org/show_bug.cgi?id=199381
22         <rdar://problem/52483103>
23
24         Reviewed by Eric Carlson.
25
26         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
27
28 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
29
30         [ews-build] Update bot configuration for WPE and GTK
31         https://bugs.webkit.org/show_bug.cgi?id=199238
32
33         Reviewed by Michael Catanzaro.
34
35         * BuildSlaveSupport/ews-build/config.json:
36
37 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
38
39         [ews-build] Make PrintConfiguration platform aware
40         https://bugs.webkit.org/show_bug.cgi?id=196657
41
42         Reviewed by Lucas Forschler.
43
44         * BuildSlaveSupport/ews-build/steps.py:
45         (PrintConfiguration): Specified platform-specific command lists.
46         (PrintConfiguration.run): Override run method and specify platform specific commands.
47         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
48
49 2019-07-01  Justin Michaud  <justin_michaud@apple.com>
50
51         [Wasm-References] Disable references by default
52         https://bugs.webkit.org/show_bug.cgi?id=199390
53
54         Reviewed by Saam Barati.
55
56         * Scripts/run-jsc-stress-tests:
57
58 2019-07-01  Joonghun Park  <pjh0718@gmail.com>
59
60         Unreviewed. Revert r246965 to fix build break
61         since r247019 reverted its related changes.
62
63         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
64         (WTR::AccessibilityUIElement::popupValue const): Deleted.
65
66 2019-07-01  Alex Christensen  <achristensen@webkit.org>
67
68         Add new decidePolicyForNavigationAction SPI with preferences and userInfo
69         https://bugs.webkit.org/show_bug.cgi?id=199371
70         <rdar://problem/52352905>
71
72         Reviewed by Tim Horton.
73
74         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
75         (-[NavigationActionSPIDelegate webView:didFinishNavigation:]):
76         (-[NavigationActionSPIDelegate _webView:decidePolicyForNavigationAction:preferences:userInfo:decisionHandler:]):
77         (-[NavigationActionSPIDelegate spiCalled]):
78         (TEST):
79
80 2019-07-01  Alex Christensen  <achristensen@webkit.org>
81
82         Deprecate _webView:showCustomSheetForElement: after transition to UIContextMenuInteraction
83         https://bugs.webkit.org/show_bug.cgi?id=199296
84         <rdar://problem/51041960>
85
86         Reviewed by Darin Adler.
87
88         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
89         (-[DragAndDropSimulator _webView:showCustomSheetForElement:]):
90
91 2019-07-01  Truitt Savell  <tsavell@apple.com>
92
93         Unreviewed, rolling out r246958.
94
95         Broke inspector/dom/getAccessibilityPropertiesForNode.html
96
97         Reverted changeset:
98
99         "Enhance support of aria-haspopup per ARIA 1.1 specification."
100         https://bugs.webkit.org/show_bug.cgi?id=199216
101         https://trac.webkit.org/changeset/246958
102
103 2019-07-01  Philippe Normand  <pnormand@igalia.com>
104
105         Unreviewed, GTK a11y tests fix after r246958
106
107         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
108         (WTR::AccessibilityUIElement::popupValue const):
109
110 2019-06-30  Andres Gonzalez  <andresg_22@apple.com>
111
112         Enhance support of aria-haspopup per ARIA 1.1 specification.
113         https://bugs.webkit.org/show_bug.cgi?id=199216
114         <rdar://problem/46221342>
115
116         Reviewed by Chris Fleizach.
117
118         * DumpRenderTree/AccessibilityUIElement.cpp:
119         (getPopupValueCallback):
120         (AccessibilityUIElement::getJSClass):
121         * DumpRenderTree/AccessibilityUIElement.h:
122         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
123         (AccessibilityUIElement::popupValue const):
124         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
125         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
126         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
127         (WTR::AccessibilityUIElement::popupValue const):
128         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
129         (WTR::AccessibilityUIElement::popupValue const):
130
131 2019-06-28  Robin Morisset  <rmorisset@apple.com>
132
133         Adding myself as a reviewer to contributors.json.
134
135         Unreviewed.
136
137         * Scripts/webkitpy/common/config/contributors.json:
138
139 2019-06-28  Jer Noble  <jer.noble@apple.com>
140
141         Add new -[WKWebView _closeAllMediaPresentations] SPI
142         https://bugs.webkit.org/show_bug.cgi?id=199294
143         <rdar://problem/51965958>
144
145         Reviewed by Alex Christensen.
146
147         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
148         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm: Added.
149         (TEST):
150
151 2019-06-28  Sihui Liu  <sihui_liu@apple.com>
152
153         Add a regression test for change r246901
154         https://bugs.webkit.org/show_bug.cgi?id=199290
155
156         Reviewed by Geoffrey Garen.
157
158         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
159         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:
160         (-[LocalStorageNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
161         (TEST):
162         * TestWebKitAPI/Tests/WebKitCocoa/localstorage-open-window-private.html: Added.
163
164 2019-06-28  Konstantin Tokarev  <annulen@yandex.ru>
165
166         Remove traces of ENABLE_ICONDATABASE remaining after its removal in 219733
167         https://bugs.webkit.org/show_bug.cgi?id=199317
168
169         Reviewed by Michael Catanzaro.
170
171         While IconDatabase and all code using it was removed,
172         ENABLE_ICONDATABASE still exists as build option and C++ macro.
173
174         * Scripts/webkitperl/FeatureList.pm:
175         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
176         * gtk/manifest.txt.in: Remove reference to unused urlIcon.png file.
177         * wpe/manifest.txt.in: Remove reference to unused urlIcon.png file.
178
179 2019-06-28  Wenson Hsieh  <wenson_hsieh@apple.com>
180
181         -[WKContentView _selectionClipRects] returns a bogus value in -reloadInputViews when focusing an element
182         https://bugs.webkit.org/show_bug.cgi?id=199310
183         <rdar://problem/52292137>
184
185         Reviewed by Megan Gardner.
186
187         Add a new API test to verify that _selectionClipRects returns the correct value when invoked under the scope of
188         _elementDidFocus.
189
190         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
191         (TestWebKitAPI::TEST):
192         * TestWebKitAPI/Tests/ios/TestInputDelegate.h:
193         * TestWebKitAPI/Tests/ios/TestInputDelegate.mm:
194         (-[TestInputDelegate setDidStartInputSessionHandler:]):
195         (-[TestInputDelegate didStartInputSessionHandler]):
196
197         Add plumbing for a handler block in TestInputDelegate.
198
199         (-[TestInputDelegate setWillStartInputSessionHandler:]):
200
201         Drive-by style fixes to add a space between id and < for Objective-C protocols.
202
203         (-[TestInputDelegate willStartInputSessionHandler]):
204         (-[TestInputDelegate _webView:willStartInputSession:]):
205         (-[TestInputDelegate _webView:didStartInputSession:]):
206         * TestWebKitAPI/cocoa/TestWKWebView.h:
207         * TestWebKitAPI/ios/UIKitSPI.h:
208
209         Add a declaration for _selectionClipRects.
210
211 2019-06-27  Zalan Bujtas  <zalan@apple.com>
212
213         REGRESSION(r244633): e-mail with "height: 100%" causes unstable layout.
214         https://bugs.webkit.org/show_bug.cgi?id=199303
215         <rdar://problem/51340927>
216
217         Reviewed by Tim Horton.
218
219         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
220         (TEST):
221
222 2019-06-27  Beth Dakin  <bdakin@apple.com>
223
224         Upstream use of MACCATALYST
225         https://bugs.webkit.org/show_bug.cgi?id=199245
226         rdar://problem/51687723
227
228         Reviewed by Tim Horton.
229
230         * ContentExtensionTester/Configurations/SDKVariant.xcconfig:
231         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig:
232         * ImageDiff/cg/Configurations/SDKVariant.xcconfig:
233         * MiniBrowser/Configurations/SDKVariant.xcconfig:
234         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig:
235         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
236         (JavaScriptCoreGenerator):
237         (WebCoreGenerator):
238         (WebKitGenerator):
239         * TestWebKitAPI/Configurations/Base.xcconfig:
240         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
241         * TestWebKitAPI/Configurations/SDKVariant.xcconfig:
242         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
243         * WebEditingTester/Configurations/SDKVariant.xcconfig:
244         * WebKitLauncher/Configurations/SDKVariant.xcconfig:
245         * WebKitTestRunner/Configurations/SDKVariant.xcconfig:
246         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig:
247
248 2019-06-27  Saam Barati  <sbarati@apple.com>
249
250         Make WEBGPU enabled only on Mojave and later.
251
252         Rubber-stamped by Myles C. Maxfield.
253
254         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
255
256 2019-06-27  Aakash Jain  <aakash_jain@apple.com>
257
258         [ews-build] Do not print worker environment variables in each build step
259         https://bugs.webkit.org/show_bug.cgi?id=197319
260
261         Reviewed by Lucas Forschler.
262
263         * BuildSlaveSupport/ews-build/steps.py:
264         (CheckOutSource.__init__): Disabled logging of environment variables.
265         (ApplyPatch.__init__): Ditto.
266         (KillOldProcesses.__init__): Ditto.
267         (ArchiveBuiltProduct.__init__): Ditto.
268         (DownloadBuiltProduct.__init__): Ditto.
269         (ExtractBuiltProduct.__init__): Ditto.
270         (RunAPITests.__init__): Ditto.
271         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests accordingly.
272
273 2019-06-26  Jiewen Tan  <jiewen_tan@apple.com>
274
275         SubFrameSOAuthorizationSession should preserve the referrer header when fall back to web path
276         https://bugs.webkit.org/show_bug.cgi?id=199232
277         <rdar://problem/51718328>
278
279         Reviewed by Youenn Fablet.
280
281         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
282         (TestWebKitAPI::TEST):
283         Add a test that utilizes TCPServer as local files always omit referrer.
284
285 2019-06-26  Aakash Jain  <aakash_jain@apple.com>
286
287         [ews-build] Add configuration and architecture for WPE and GTK builders
288         https://bugs.webkit.org/show_bug.cgi?id=199249
289
290         Reviewed by Jonathan Bedard.
291
292         * BuildSlaveSupport/ews-build/config.json:
293
294 2019-06-26  Aakash Jain  <aakash_jain@apple.com>
295
296         [ews-build] Add check for duplicate workers in config.json
297         https://bugs.webkit.org/show_bug.cgi?id=199240
298
299         Reviewed by Jonathan Bedard.
300
301         * BuildSlaveSupport/ews-build/loadConfig.py:
302         (checkWorkersAndBuildersForConsistency._find_worker_with_name): Check for duplicate worker entry.
303         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
304         (TestcheckWorkersAndBuildersForConsistency.test_duplicate_worker): Added unit-test.
305
306 2019-06-26  Ross Kirsling  <ross.kirsling@sony.com>
307
308         [Win] MiniBrowser should make better font choices
309         https://bugs.webkit.org/show_bug.cgi?id=199244
310
311         Reviewed by Brent Fulgham.
312
313         * MiniBrowser/win/MainWindow.cpp:
314         (MainWindow::updateDeviceScaleFactor):
315         * MiniBrowser/win/MiniBrowserLib.rc:
316
317 2019-06-26  Alex Christensen  <achristensen@webkit.org>
318
319         testRunner.setAlwaysAcceptCookies should wait for cookie accept policy to be set
320         https://bugs.webkit.org/show_bug.cgi?id=199230
321         <rdar://51757107>
322
323         Reviewed by Andy Estes.
324
325         * TestWebKitAPI/Tests/WebKit/CookieManager.cpp:
326         (TestWebKitAPI::didGetTestHTTPCookieAcceptPolicy):
327         (TestWebKitAPI::didGetUserHTTPCookieAcceptPolicy):
328         * WebKitTestRunner/TestController.cpp:
329         (WTR::TestController::generatePageConfiguration):
330         (WTR::TestController::createWebViewWithOptions):
331         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundleWithListener):
332         (WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundleWithListener):
333         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
334         (WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundle): Deleted.
335         * WebKitTestRunner/TestController.h:
336         * WebKitTestRunner/TestInvocation.cpp:
337         (WTR::TestInvocation::invoke):
338         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
339
340 2019-06-26  Ross Kirsling  <ross.kirsling@sony.com>
341
342         [Win][MiniBrowser] Remove obsolete code after r246814.
343         https://bugs.webkit.org/show_bug.cgi?id=199233
344
345         Reviewed by Fujii Hironori.
346
347         * MiniBrowser/win/MiniBrowserWebHost.cpp:
348         (MiniBrowserWebHost::didFinishLoadForFrame):
349         (SimpleEventListener::SimpleEventListener): Deleted.
350         (SimpleEventListener::handleEvent): Deleted.
351
352 2019-06-25  Jiewen Tan  <jiewen_tan@apple.com>
353
354         Implement a new SPI to inform clients about AppSSO
355         https://bugs.webkit.org/show_bug.cgi?id=199085
356         <rdar://problem/50028246>
357
358         Reviewed by Geoffrey Garen.
359
360         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
361         (-[TestSOAuthorizationBasicDelegate webView:didFinishNavigation:]):
362         (-[TestSOAuthorizationNavigationDelegate init]):
363         (-[TestSOAuthorizationNavigationDelegate _webView:decidePolicyForSOAuthorizationLoadWithCurrentPolicy:forExtension:completionHandler:]):
364         (TestWebKitAPI::TEST):
365
366 2019-06-25  Aakash Jain  <aakash_jain@apple.com>
367
368         [ews-build] Retry Layout test in case of failures
369         https://bugs.webkit.org/show_bug.cgi?id=199194
370
371         Reviewed by Jonathan Bedard.
372
373         * BuildSlaveSupport/ews-build/steps.py:
374         (RunWebKitTests.evaluateCommand): Check if tests failed and retry them if required.
375         (ReRunWebKitTests): Build step to re-run layout tests.
376         (ReRunWebKitTests.evaluateCommand): Check if tests failed and retry on clean build if required.
377         (RunWebKitTestsWithoutPatch): Build step to run tests without patch.
378         (RunWebKitTestsWithoutPatch.evaluateCommand):
379
380 2019-06-25  Aakash Jain  <aakash_jain@apple.com>
381
382         [ews-build] Combine various patchFailed*Tests properties
383         https://bugs.webkit.org/show_bug.cgi?id=199193
384
385         Reviewed by Jonathan Bedard.
386
387         * BuildSlaveSupport/ews-build/steps.py: Renamed patchFailedJSCTests and patchFailedAPITests to patchFailedTests. This property 
388         can also be used for layout-tests later on.
389         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
390
391 2019-06-25  Ross Kirsling  <ross.kirsling@sony.com>
392
393         [Win] MiniBrowser should default to webkit.org
394         https://bugs.webkit.org/show_bug.cgi?id=199201
395
396         Reviewed by Don Olmstead.
397
398         * MiniBrowser/win/BrowserWindow.h:
399         * MiniBrowser/win/MiniBrowserReplace.h:
400         * MiniBrowser/win/WebKitBrowserWindow.cpp:
401         (WebKitBrowserWindow::loadHTMLString): Deleted.
402         * MiniBrowser/win/WebKitBrowserWindow.h:
403         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
404         (WebKitLegacyBrowserWindow::loadHTMLString): Deleted.
405         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
406         * MiniBrowser/win/WinMain.cpp:
407         (wWinMain):
408
409 2019-06-25  Wenson Hsieh  <wenson_hsieh@apple.com>
410
411         [iOS] Occasional crash under -[UIPreviewTarget initWithContainer:center:transform:] when generating a drag preview
412         https://bugs.webkit.org/show_bug.cgi?id=199192
413         <rdar://problem/51554509>
414
415         Reviewed by Tim Horton.
416
417         Tweak the drag and drop simulator to ask for drag cancellation previews, and use this to write a couple tests to
418         verify that we gracefully handle web process termination and web view unparenting mid-drag.
419
420         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
421         (TestWebKitAPI::TEST):
422         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
423         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
424         (-[DragAndDropSimulator _resetSimulatedState]):
425         (-[DragAndDropSimulator _concludeDropAndPerformOperationIfNecessary]):
426         (-[DragAndDropSimulator _advanceProgress]):
427         (-[DragAndDropSimulator liftPreviews]):
428         (-[DragAndDropSimulator cancellationPreviews]):
429         (-[DragAndDropSimulator setSessionWillBeginBlock:]):
430         (-[DragAndDropSimulator sessionWillBeginBlock]):
431         (-[DragAndDropSimulator _webView:dataInteraction:sessionWillBegin:]):
432
433 2019-06-25  Aakash Jain  <aakash_jain@apple.com>
434
435         [ews-build] UploadTestResults and ExtractTestResults clobber results in case of multiple layout test runs in a build
436         https://bugs.webkit.org/show_bug.cgi?id=199178
437
438         Reviewed by Jonathan Bedard.
439
440         * BuildSlaveSupport/ews-build/steps.py:
441         (UploadTestResults.__init__): Add an optional identifier and append the identifier to the file name.
442         (ExtractTestResults.__init__): Ditto.
443         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit tests.
444
445 2019-06-25  Michael Catanzaro  <mcatanzaro@igalia.com>
446
447         Add user agent quirk for bankofamerica.com
448         https://bugs.webkit.org/show_bug.cgi?id=199154
449
450         Reviewed by Carlos Garcia Campos.
451
452         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
453         (TestWebKitAPI::TEST):
454
455 2019-06-25  Michael Catanzaro  <mcatanzaro@igalia.com>
456
457         Fully rename WebKitGTK+ -> WebKitGTK everywhere
458         https://bugs.webkit.org/show_bug.cgi?id=199159
459
460         Reviewed by Carlos Garcia Campos.
461
462         * BuildSlaveSupport/gtk/README:
463         * MiniBrowser/gtk/BrowserWindow.c:
464         * MiniBrowser/gtk/main.c:
465         (aboutURISchemeRequestCallback):
466         * Scripts/webkitpy/common/config/contributionareas.py:
467         * Scripts/webkitpy/common/config/contributors.json:
468         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py:
469         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
470         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
471         (testWebViewResources):
472         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
473         (testWebViewMouseTarget):
474         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
475         (testWebExtensionGetTitle):
476         (testDocumentLoadedSignal):
477         (testWebExtensionFormControlsAssociated):
478         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
479         (testWebKitSettingsUserAgent):
480         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
481         (testWebViewRunJavaScript):
482         * TestWebKitAPI/Tests/WebKitGtk/InspectorTestServer.cpp:
483         (main):
484         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
485         (prepareContextMenuTestView):
486         (testContextMenuPopulateMenu):
487         (testContextMenuCustomMenu):
488         (testContextMenuDisableMenu):
489         (testContextMenuSubMenu):
490         (testContextMenuDismissed):
491         (testContextMenuWebExtensionMenu):
492         (testContextMenuWebExtensionNode):
493         * TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp:
494         (testInspectorDefault):
495         (testInspectorManualAttachDetach):
496         (testInspectorCustomContainerDestroyed):
497         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
498         (testWebViewPrint):
499         (testPrintOperationPrint):
500         (testPrintOperationErrors):
501         * gtk/install-dependencies:
502         * gtk/jhbuild.modules:
503         * gtkdoc/generate-gtkdoc:
504         * wpe/install-dependencies:
505
506 2019-06-24  Michael Catanzaro  <mcatanzaro@igalia.com>
507
508         contributors.json not canonicalized since r243297
509         https://bugs.webkit.org/show_bug.cgi?id=199161
510
511         Reviewed by Alexey Proskuryakov.
512
513         Canonicalize it using 'validate-committer-lists --canonicalize'
514
515         * Scripts/webkitpy/common/config/contributors.json:
516
517 2019-06-24  Jonathan Bedard  <jbedard@apple.com>
518
519         webkitpy: Build style should be lower-case
520         https://bugs.webkit.org/show_bug.cgi?id=199158
521
522         Reviewed by Aakash Jain.
523
524         * Scripts/webkitpy/test/main.py:
525         (Tester._run_tests): Make all styles lower-case.
526
527 2019-06-24  Aakash Jain  <aakash_jain@apple.com>
528
529         [ews-build] Remove iOS queue from old EWS and dashboard
530         https://bugs.webkit.org/show_bug.cgi?id=199150
531
532         Reviewed by Jonathan Bedard.
533
534         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
535         * QueueStatusServer/config/queues.py:
536
537 2019-06-21  Ryan Haddad  <ryanhaddad@apple.com>
538
539         API Test [Mojave+ WK2 Debug ] TestWebKitAPI.WKAttachmentTestsMac.InsertDroppedFilePromisesAsAttachments is a flaky crash
540         https://bugs.webkit.org/show_bug.cgi?id=198795
541
542         Unreviewed test gardening.
543
544         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
545         (TestWebKitAPI::TEST): Disable flaky test.
546
547 2019-06-24  Aakash Jain  <aakash_jain@apple.com>
548
549         [ews-build] Enable iOS-12-Build queue on new EWS
550         https://bugs.webkit.org/show_bug.cgi?id=199149
551
552         Reviewed by Jonathan Bedard.
553
554         * BuildSlaveSupport/ews-build/config.json: Enable iOS-12-Build-EWS trigger. Also temporarily share ews152 and ews154 with
555         this queue.
556         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
557         (StatusBubble): Enable ios status-bubble. Also display the ios bubble first (left). Going forward
558         will keep the builders to the left and testers to the right.
559
560 2019-06-24  Aakash Jain  <aakash_jain@apple.com>
561
562         [ews-build] Upload test results after running layout-tests
563         https://bugs.webkit.org/show_bug.cgi?id=199120
564
565         Reviewed by Jonathan Bedard.
566
567         * BuildSlaveSupport/ews-build/steps.py:
568         (RunWebKitTests.evaluateCommand):
569         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
570
571 2019-06-24  Aakash Jain  <aakash_jain@apple.com>
572
573         [ews-build] EWS should provide option to download layout test results zip file
574         https://bugs.webkit.org/show_bug.cgi?id=199121
575
576         Reviewed by Jonathan Bedard.
577
578         * BuildSlaveSupport/ews-build/steps.py:
579         (ExtractTestResults.resultsDownloadURL): Method to return layout test result zip file url. 
580         (ExtractTestResults.addCustomURLs): Add url to download layout test results zip file.
581
582 2019-06-24  Michael Catanzaro  <mcatanzaro@igalia.com>
583
584         Add user agent quirk for Google Drive
585         https://bugs.webkit.org/show_bug.cgi?id=199153
586
587         Reviewed by Carlos Garcia Campos.
588
589         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
590         (TestWebKitAPI::TEST):
591
592 2019-06-22  Zalan Bujtas  <zalan@apple.com>
593
594         [LFC] Expand tests coverage (328 new tests -> 2652).
595
596         * LayoutReloaded/misc/LFC-passing-tests.txt:
597
598 2019-06-22  Andres Gonzalez  <andresg_22@apple.com>
599
600         Accessibility objects contained in links should honor the aria-haspopup attribute in the ancestor link.
601         https://bugs.webkit.org/show_bug.cgi?id=199107
602         <rdar://problem/43663611>
603
604         Reviewed by Chris Fleizach.
605
606         iOS implementation for AccessibilityUIElement::hasPopup.
607         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
608         (WTR::AccessibilityUIElement::hasPopup const):
609
610 2019-06-22  Konstantin Tokarev  <annulen@yandex.ru>
611
612         Unreviewed, add myself to CMake watchlist
613
614         * Scripts/webkitpy/common/config/watchlist:
615
616 2019-06-21  Sihui Liu  <sihui_liu@apple.com>
617
618         openDatabase should return an empty object when WebSQL is disabled
619         https://bugs.webkit.org/show_bug.cgi?id=198805
620
621         Reviewed by Geoffrey Garen.
622
623         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
624         * TestWebKitAPI/Tests/WebKitCocoa/WebSQLBasics.mm: Added.
625         (-[WebSQLBasicsMessageHandler userContentController:didReceiveScriptMessage:]):
626         (TEST):
627         * TestWebKitAPI/Tests/WebKitCocoa/opendatabase-always-exists.html: Added.
628
629 2019-06-21  Jiewen Tan  <jiewen_tan@apple.com>
630
631         WebPageProxy::loadData should accept ShouldOpenExternalURLsPolicy
632         https://bugs.webkit.org/show_bug.cgi?id=199114
633         <rdar://problem/51671674>
634
635         Reviewed by Youenn Fablet.
636
637         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
638         (-[TestSOAuthorizationNavigationDelegate init]):
639         (-[TestSOAuthorizationNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
640         (configureSOAuthorizationWebView):
641         (TestWebKitAPI::TEST):
642
643 2019-06-21  Youenn Fablet  <youenn@apple.com>
644
645         WebPageProxy should use the right path for sandbox extension
646         https://bugs.webkit.org/show_bug.cgi?id=198902
647         <rdar://problem/50772810>
648
649         Reviewed by Geoffrey Garen.
650
651         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm:
652         (TEST):
653         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
654
655 2019-06-21  Michael Catanzaro  <mcatanzaro@igalia.com>
656
657         [WPE][GTK] Bump minimum versions of GLib, GTK, libsoup, ATK, GStreamer, and Cairo
658         https://bugs.webkit.org/show_bug.cgi?id=199094
659
660         Reviewed by Carlos Garcia Campos.
661
662         * MiniBrowser/gtk/BrowserTab.c:
663         (runColorChooserCallback):
664         (browserTabConstructed):
665         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
666         (testWebViewSyncRequestOnMaxConns):
667         (beforeAll):
668         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
669         (testWebSocketTLSErrors):
670         (beforeAll):
671         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
672         (WebKitTestServer::~WebKitTestServer):
673         (WebKitTestServer::getWebSocketURIForPath const):
674         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
675         (WTR::AccessibilityUIElement::rowHeaders const):
676         (WTR::AccessibilityUIElement::columnHeaders const):
677         (WTR::AccessibilityUIElement::isAttributeSettable):
678         (WTR::AccessibilityUIElement::x):
679         (WTR::AccessibilityUIElement::y):
680         (WTR::AccessibilityUIElement::width):
681         (WTR::AccessibilityUIElement::height):
682         (WTR::AccessibilityUIElement::clickPointX):
683         (WTR::AccessibilityUIElement::clickPointY):
684         (WTR::AccessibilityUIElement::intValue const):
685         (WTR::AccessibilityUIElement::minValue):
686         (WTR::AccessibilityUIElement::maxValue):
687         (WTR::stringAtOffset):
688
689 2019-06-20  Dean Johnson  <dean_johnson@apple.com>
690
691         test-webkitpy is broken on macOS Catalina
692         https://bugs.webkit.org/show_bug.cgi?id=199078
693
694         Reviewed by Jonathan Bedard.
695
696         * Scripts/webkitpy/test/main.py: Check if lldb tests are supported before adding them
697         to the runner.
698         (main): 
699         (_supports_building_and_running_lldb_tests): Check if you are running macOS Catalina.
700
701 2019-06-20  Dean Johnson  <dean_johnson@apple.com>
702
703         Change status to "committer" in contributors.json
704
705         Unreviewed.
706
707         * Scripts/webkitpy/common/config/contributors.json:
708
709 2019-06-20  Alex Christensen  <achristensen@webkit.org>
710
711         Add unit test for UIContextMenuConfiguration API
712         https://bugs.webkit.org/show_bug.cgi?id=199043
713
714         Reviewed by Wenson Hsieh.
715
716         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
717         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm: Added.
718         (-[TestContextMenuUIDelegate webView:contextMenuConfigurationForElement:completionHandler:]):
719         (-[TestContextMenuUIDelegate webView:contextMenuWillPresentForElement:]):
720         (-[TestContextMenuUIDelegate webView:contextMenuForElement:willCommitWithAnimator:]):
721         (-[TestContextMenuUIDelegate webView:contextMenuDidEndForElement:]):
722         (TEST):
723         * TestWebKitAPI/cocoa/TestContextMenuDriver.h: Added.
724         * TestWebKitAPI/cocoa/TestContextMenuDriver.mm: Added.
725         (-[TestContextMenuDriver delegate]):
726         (-[TestContextMenuDriver setDelegate:]):
727         (-[TestContextMenuDriver view]):
728         (-[TestContextMenuDriver setView:]):
729         (-[TestContextMenuDriver allowableMovement]):
730         (-[TestContextMenuDriver setAllowableMovement:]):
731         (-[TestContextMenuDriver primaryGestureRecognizer]):
732         (-[TestContextMenuDriver setPrimaryGestureRecognizer:]):
733         (-[TestContextMenuDriver touchDuration]):
734         (-[TestContextMenuDriver setTouchDuration:]):
735         (-[TestContextMenuDriver locationInCoordinateSpace:]):
736         (-[TestContextMenuDriver cancelInteraction]):
737         (-[TestContextMenuDriver begin:]):
738         (-[TestContextMenuDriver clickDown]):
739         (-[TestContextMenuDriver clickUp]):
740         (-[TestContextMenuDriver end]):
741         * TestWebKitAPI/ios/UIKitSPI.h:
742
743 2019-06-20  Aakash Jain  <aakash_jain@apple.com>
744
745         [ews-app] Status bubble should not turn orange when any build step is skipped
746         https://bugs.webkit.org/show_bug.cgi?id=199079
747
748         Reviewed by Jonathan Bedard.
749
750         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
751
752 2019-06-20  Alex Christensen  <achristensen@webkit.org>
753
754         Fix an internal engineering build after r246605
755        ​https://bugs.webkit.org/show_bug.cgi?id=197800
756
757         * TestWebKitAPI/TCPServer.cpp:
758
759 2019-06-20  Aakash Jain  <aakash_jain@apple.com>
760
761         [ews-build] Triggered builds should use same revision as parent build
762         https://bugs.webkit.org/show_bug.cgi?id=198289
763
764         Reviewed by Jonathan Bedard.
765
766         * BuildSlaveSupport/ews-build/steps.py:
767         (CheckOutSpecificRevision): Build step to checkout specific revision.
768         (CheckOutSpecificRevision.doStepIf): Run this step only if ews_revision property is set.
769         (CheckOutSpecificRevision.hideStepIf): Hide this step when it is skipped.
770         (CheckOutSpecificRevision.start): Run appropriate git command.
771         (Trigger.propertiesToPassToTriggers): Pass ews_revision property to triggered builds, so that triggered
772         builds use same revision as parent build.
773         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
774         * BuildSlaveSupport/ews-build/factories.py:
775         (Factory.__init__): Added CheckOutSpecificRevision step.
776
777 2019-06-20  Aakash Jain  <aakash_jain@apple.com>
778
779         [ews-build] Add unit tests for AnalyzeCompileWebKitResults
780         https://bugs.webkit.org/show_bug.cgi?id=199073
781
782         Reviewed by Jonathan Bedard.
783
784         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests for AnalyzeCompileWebKitResults.
785
786 2019-06-20  Alexander Mikhaylenko  <exalm7659@gmail.com>
787
788         [GTK] Enable navigation swipe layout tests
789         https://bugs.webkit.org/show_bug.cgi?id=198995
790
791         Reviewed by Michael Catanzaro.
792
793         Add a way for tests to enable and then control swipe gesture on GTK.
794
795         * TestRunnerShared/UIScriptContext/UIScriptController.cpp: Hide
796         empty implementations of beginBackSwipe() and completeBackSwipe() for GTK.
797         * WebKitTestRunner/PlatformGTK.cmake:
798         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
799         (WTR::PlatformWebView::setNavigationGesturesEnabled): Implemented.
800         * WebKitTestRunner/gtk/UIScriptControllerGtk.cpp: Added.
801         (WTR::UIScriptController::beginBackSwipe):
802         (WTR::UIScriptController::completeBackSwipe):
803
804 2019-06-20  Alexander Mikhaylenko  <exalm7659@gmail.com>
805
806         [GTK] HTTP layout tests don't run in flatpak
807         https://bugs.webkit.org/show_bug.cgi?id=199067
808
809         Reviewed by Michael Catanzaro.
810
811         Stop bind mounting /app/lib/perl to /etc/perl because Perl doesn't actually
812         check that path. Instead, add /app/lib/perl to Apache config directly.
813
814         /usr/manifest.json file is not guaranteed to exist in sandbox, check for
815         /.flatpak-info instead.
816
817         * Scripts/webkitpy/port/base.py:
818         (Port._is_flatpak):
819         (Port._in_flatpak_sandbox):
820         * flatpak/flatpakutils.py:
821         (WebkitFlatpak.run_in_sandbox):
822         (is_sandboxed):
823
824 2019-06-18  Darin Adler  <darin@apple.com>
825
826         Tidy up the remaining bits of the AtomicString to AtomString rename
827         https://bugs.webkit.org/show_bug.cgi?id=198990
828
829         Reviewed by Michael Catanzaro.
830
831         * Scripts/do-webcore-rename: Removed already-done renames.
832         * TestWebKitAPI/Tests/WTF/StringImpl.cpp: Rename one use of "atomic".
833
834 2019-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
835
836         [GTK] Remove support for GTK2 plugins
837         https://bugs.webkit.org/show_bug.cgi?id=199065
838
839         Reviewed by Sergio Villar Senin.
840
841         * EWSTools/ubuntu-ews-packages:
842         * TestWebKitAPI/PlatformGTK.cmake:
843         * WebKitTestRunner/PlatformGTK.cmake:
844         * flatpak/org.webkit.GTK.yaml:
845         * gtk/install-dependencies:
846
847 2019-06-19  Yusuke Suzuki  <ysuzuki@apple.com>
848
849         [bmalloc] IsoHeap's initialization is racy with IsoHeap::isInitialized
850         https://bugs.webkit.org/show_bug.cgi?id=199053
851
852         Reviewed by Saam Barati.
853
854         Added a test stressing IsoHeap with multiple threads.
855
856         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
857         (assertHasObjects):
858         (assertHasOnlyObjects):
859         (assertClean):
860         (TEST):
861
862 2019-06-19  Zalan Bujtas  <zalan@apple.com>
863
864         [LFC] Expand tests coverage (1126 new tests -> 2324).
865
866         * LayoutReloaded/misc/LFC-passing-tests.txt:
867
868 2019-06-19  Fujii Hironori  <Hironori.Fujii@sony.com>
869
870         Add WTF::crossThreadCopy(T&&) to utilize String::isolatedCopy() &&
871         https://bugs.webkit.org/show_bug.cgi?id=198957
872
873         Reviewed by Alex Christensen.
874
875         * TestWebKitAPI/CMakeLists.txt:
876         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
877         * TestWebKitAPI/Tests/WTF/CrossThreadCopier.cpp: Added.
878
879 2019-06-19  Keith Rollin  <krollin@apple.com>
880
881         Relocate some test tools in non-mac builds
882         https://bugs.webkit.org/show_bug.cgi?id=198984
883         <rdar://problem/51873261>
884
885         Reviewed by Andy Estes.
886
887         The tools DumpRenderTree, WebKitTestRunner, LayoutTestHelper, and
888         TestNetscapePlugin get created in
889         WebKit.framework/Versions/A/Resources on non-mac builds. This is
890         incorrect, as those bundles are shallow bundles that don't use the
891         Versions hierarchy. Instead, store these files directly in
892         WebKit.framework.
893
894         Note that getting rid of just the "Versions/A" path components and
895         putting the files in WebKit.framework/Resources doesn't work as
896         `codesign` treats the result as an invalid layout.
897
898         The work in this patch involves changing the definition of the custom
899         build variable WEBKIT_FRAMEWORK_RESOURCES_PATH. The standard build
900         variable INSTALL_PATH is defined in terms of this variable. In order
901         to increase visiblity into this relationship, move both of these
902         variables into .xcconfig files if they weren't already. This
903         refactoring was done in a way to be the least disruptive and most
904         compatible with the previous definitions, even at the cost of being
905         repetitive.
906
907         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
908         * DumpRenderTree/mac/Configurations/Base.xcconfig:
909         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
910         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig:
911         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
912         * WebKitTestRunner/Configurations/BaseTarget.xcconfig:
913
914 2019-06-19  Aakash Jain  <aakash_jain@apple.com>
915
916         [ews-build] Patch link should open the pretty patch
917         https://bugs.webkit.org/show_bug.cgi?id=199031
918
919         Reviewed by Jonathan Bedard.
920
921         * BuildSlaveSupport/ews-build/steps.py:
922         (ConfigureBuild.getPatchURL): Use the prettypatch url for patch.
923
924 2019-06-19  Aakash Jain  <aakash_jain@apple.com>
925
926         [ews-build] Add step to analyze Compile WebKit failures
927         https://bugs.webkit.org/show_bug.cgi?id=199025
928
929         Reviewed by Jonathan Bedard.
930
931         * BuildSlaveSupport/ews-build/steps.py:
932         (CompileWebKit.evaluateCommand): Add AnalyzeCompileWebKitResults step.
933         (CompileWebKitToT): set haltOnFailure to False since we need to run AnalyzeCompileWebKitResults step.
934         (AnalyzeCompileWebKitResults): Class to analyze compile webkit steps results.
935         (AnalyzeCompileWebKitResults.start): If ToT fails to build, retry the build, else marked the build as failed. Note that
936         this step is run only when compile-webkit failed.
937
938 2019-06-19  Aakash Jain  <aakash_jain@apple.com>
939
940         [ews-build] Send email notifications for failures
941         https://bugs.webkit.org/show_bug.cgi?id=198919
942
943         Reviewed by Jonathan Bedard.
944
945         * BuildSlaveSupport/ews-build/master.cfg:
946
947 2019-06-19  Alex Christensen  <achristensen@webkit.org>
948
949         Add a unit test for client certificate authentication
950         https://bugs.webkit.org/show_bug.cgi?id=197800
951
952         Reviewed by Youenn Fablet.
953
954         Make better abstractions for reading and writing from/to TCPServer.
955         Add a unit test that causes a client certificate authentication challenge to happen.
956
957         * TestWebKitAPI/TCPServer.cpp:
958         (TestWebKitAPI::TCPServer::TCPServer):
959         (TestWebKitAPI::TCPServer::read):
960         (TestWebKitAPI::TCPServer::write):
961         (TestWebKitAPI::TCPServer::respondWithChallengeThenOK):
962         (TestWebKitAPI::TCPServer::respondWithOK):
963         * TestWebKitAPI/TCPServer.h:
964         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
965         (credentialWithIdentity):
966         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
967         (TEST):
968         (-[ClientCertificateDelegate webView:didFinishNavigation:]):
969         (-[ClientCertificateDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
970         (-[ClientCertificateDelegate challengeCount]):
971         (TestWebKitAPI::TEST):
972         (respondWithChallengeThenOK): Deleted.
973         (credentialWithIdentityAndKeychainPath): Deleted.
974         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
975         (TEST):
976         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
977         (TestWebKitAPI::TEST):
978         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
979         (TEST):
980         (readRequest): Deleted.
981         (writeResponse): Deleted.
982         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
983         (TestWebKitAPI::TEST):
984         (TestWebKitAPI::respondWithChallengeThenOK): Deleted.
985
986 2019-06-19  Michael Catanzaro  <mcatanzaro@igalia.com>
987
988         Unreviewed, fix build warnings in TestWebKitAPIInjectedBundle
989
990         System headers are being included without SYSTEM again here.
991
992         * TestWebKitAPI/PlatformGTK.cmake:
993
994 2019-06-18  Yusuke Suzuki  <ysuzuki@apple.com>
995
996         [JSC] JSLock should be WebThread aware
997         https://bugs.webkit.org/show_bug.cgi?id=198911
998
999         Reviewed by Geoffrey Garen.
1000
1001         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1002         * TestWebKitAPI/Tests/WebKitLegacy/ios/JSLockTakesWebThreadLock.mm: Added.
1003         (TestWebKitAPI::TEST):
1004
1005 2019-06-18  Keith Miller  <keith_miller@apple.com>
1006
1007         webkit-patch should allow for a bugzilla url not just bugzilla id
1008         https://bugs.webkit.org/show_bug.cgi?id=198972
1009
1010         Reviewed by Dewei Zhu.
1011
1012         When prompting for a bugzilla id or a new title we should also
1013         allow for a bugzilla url.
1014
1015         * Scripts/webkitpy/tool/steps/promptforbugortitle.py:
1016         (PromptForBugOrTitle.run):
1017
1018 2019-06-18  David Quesada  <david_quesada@apple.com>
1019
1020         REGRESSION: _WKDownload.OriginatingWebView and _WKDownload.CrashAfterDownloadDidFinishWhenDownloadProxyHoldsTheLastRefOnWebProcessPool failing
1021         https://bugs.webkit.org/show_bug.cgi?id=198954
1022         rdar://problem/51711556
1023
1024         Reviewed by Alex Christensen.
1025
1026         For these tests, kill the web process after the download starts. This makes the deallocation
1027         of the download-originating web views, which these tests depend on, more reliable.
1028
1029         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1030         (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
1031         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
1032
1033 2019-06-18  Dan Bernstein  <mitz@apple.com>
1034
1035         Revert workaround for bug 198904 from run-webkit-archive
1036         https://bugs.webkit.org/show_bug.cgi?id=198931
1037
1038         Reviewed by Alexey Proskuryakov.
1039
1040         Reverted r245965, now that the load commands in the XPC service binaries make them correctly
1041         pick up the built frameworks.
1042
1043         * WebKitArchiveSupport/run-webkit-archive:
1044         (set_dyld_framework_path):
1045
1046 2019-06-17  Sihui Liu  <sihui_liu@apple.com>
1047
1048         -[WKWebsiteDataStore removeDataOfTypes:modifiedSince:completionHandler:] doesn't delete _WKWebsiteDataTypeCredentials
1049         https://bugs.webkit.org/show_bug.cgi?id=198854
1050         <rdar://problem/51386058>
1051
1052         Reviewed by Geoffrey Garen.
1053
1054         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1055         (TestWebKitAPI::TEST):
1056
1057 2019-06-17  Adrian Perez de Castro  <aperez@igalia.com>
1058
1059         [Flatpak][JHBuild] Update build environments to use WPEBackend-fdo 1.3.1
1060         https://bugs.webkit.org/show_bug.cgi?id=198831
1061
1062         Reviewed by Žan Doberšek.
1063
1064         * flatpak/org.webkit.WPEModules.yaml: Bump versions of libwpe and WPEBackend-fdo to 1.3.1
1065         * wpe/jhbuild.modules: Ditto.
1066         * wpe/patches/wpebackend-fdo-Handle-the-case-of-new-target-created-for-the-same-v.patch: Removed.
1067         * wpe/wpebackend-fdo-view-backend-exportable-private-don-t-double-free-ca.patch: Removed.
1068
1069 2019-06-17  Jiewen Tan  <jiewen_tan@apple.com>
1070
1071         Move SOAuthorization from WebKitAdditions to WebKit
1072         https://bugs.webkit.org/show_bug.cgi?id=198874
1073         <rdar://problem/47573431>
1074
1075         Reviewed by Brent Fulgham.
1076
1077         This patch moves all SOAuthorization tests from WebKitAdditions to WebKit.
1078
1079         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1080         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1081         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm: Added.
1082         (-[TestSOAuthorizationNavigationDelegate init]):
1083         (-[TestSOAuthorizationNavigationDelegate webView:didFinishNavigation:]):
1084         (-[TestSOAuthorizationNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1085         (-[TestSOAuthorizationNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1086         (-[TestSOAuthorizationViewController viewDidAppear]):
1087         (-[TestSOAuthorizationViewController viewDidDisappear]):
1088         (overrideCanPerformAuthorizationWithURL):
1089         (overrideSetDelegate):
1090         (overrideBeginAuthorizationWithURL):
1091         (overrideCancelAuthorization):
1092         (overrideAddObserverForName):
1093         (overrideIsURLFromAppleOwnedDomain):
1094         (resetState):
1095         (configureSOAuthorizationWebView):
1096         (generateHtml):
1097         (checkAuthorizationOptions):
1098         (TestWebKitAPI::TEST):
1099
1100 2019-06-17  Brent Fulgham  <bfulgham@apple.com>
1101
1102         Ensure ITP state is relayed to Network Process on restart
1103         https://bugs.webkit.org/show_bug.cgi?id=198797
1104         <rdar://problem/51646944>
1105
1106         Reviewed by Youenn Fablet.
1107
1108         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1109         (cleanupITPDatabase): Added.
1110         (TEST:EnableDisableITP): Update to use cleanup method.
1111         (TEST:NetworkProcessRestart): Added.
1112
1113 2019-06-17  Aakash Jain  <aakash_jain@apple.com>
1114
1115         New EWS can't process patches larger than 640kb
1116         https://bugs.webkit.org/show_bug.cgi?id=198851
1117
1118         Reviewed by Jonathan Bedard.
1119
1120         * BuildSlaveSupport/ews-build/master.cfg: Increase the patch size limit to 100 MB.
1121
1122 2019-06-17  Jonathan Bedard  <jbedard@apple.com>
1123
1124         webkitpy: Add macOS Catalina, iOS 13
1125         https://bugs.webkit.org/show_bug.cgi?id=198492
1126
1127         Reviewed by Alexey Proskuryakov.
1128
1129         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Catalina.png: Added.
1130         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Catalina@2x.png: Added.
1131         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS13.png: Added.
1132         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS13@2x.png: Added.
1133         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS13Simulator.png: Added.
1134         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS13Simulator@2x.png: Added.
1135         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1136         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1137         * BuildSlaveSupport/ews-build/steps.py:
1138         * Scripts/webkitpy/common/version_name_map.py:
1139         * Scripts/webkitpy/common/version_name_map_unittest.py:
1140         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1141         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1142
1143 2019-06-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1144
1145         Unreviewed. [GTK] Bump WPEBackend-fdo requirement to 1.3.1
1146
1147         * gtk/jhbuild.modules:
1148         * gtk/patches/wpebackend-fdo-Handle-the-case-of-new-target-created-for-the-same-v.patch: Removed.
1149         * gtk/wpebackend-fdo-view-backend-exportable-private-don-t-double-free-ca.patch: Removed.
1150
1151 2019-06-16  Zalan Bujtas  <zalan@apple.com>
1152
1153         [LFC] Expand tests coverage (325 new tests -> 1198).
1154
1155         * LayoutReloaded/misc/LFC-passing-tests.txt:
1156
1157 2019-06-16  Darin Adler  <darin@apple.com>
1158
1159         Rename AtomicString to AtomString
1160         https://bugs.webkit.org/show_bug.cgi?id=195276
1161
1162         Reviewed by Michael Catanzaro.
1163
1164         * many files: Let do-webcore-rename do the renaming.
1165
1166         * Scripts/do-webcore-rename: Updated with a list of all the identifiers
1167         that mention "atomic string" and changed them to instead say "atom string".
1168
1169 2019-06-16  Zalan Bujtas  <zalan@apple.com>
1170
1171         [LFC] Unreviewed test gardening.
1172
1173         Unsupported alignments.
1174
1175         fast/inline/absolute-positioned-inline-in-centred-block.html -align: center
1176         fast/borders/empty-outline-border-assert.html -vertical-align: super
1177         css2.1/20110323/vertical-align-boxes-001.htm - vertical-align: middle
1178
1179         * LayoutReloaded/misc/LFC-passing-tests.txt:
1180
1181 2019-06-15  Youenn Fablet  <youenn@apple.com>
1182
1183         WPT test importer WTR option reader should not throw if the file is not proper UTF-8
1184         https://bugs.webkit.org/show_bug.cgi?id=198780
1185
1186         Reviewed by Jonathan Bedard.
1187
1188         * Scripts/webkitpy/w3c/test_importer.py:
1189         (TestImporter._webkit_test_runner_options):
1190         In case the test file cannot be read as text, consider that there is no WTR option.
1191
1192 2019-06-14  Youenn Fablet  <youenn@apple.com>
1193
1194         WebResourceLoadStatisticsStore should not use its network session if invalidated
1195         https://bugs.webkit.org/show_bug.cgi?id=198814
1196
1197         Reviewed by Geoffrey Garen.
1198
1199         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1200         (TEST):
1201
1202 2019-06-14  Youenn Fablet  <youenn@apple.com>
1203
1204         import-w3c-tests should respect WEBKIT_OUTPUTDIR
1205         https://bugs.webkit.org/show_bug.cgi?id=198682
1206         <rdar://problem/51536931>
1207
1208         Reviewed by Jonathan Bedard.
1209
1210         Check for WEBKIT_OUTPUTDIR environment variable to compute the w3c-tests folder.
1211         Made some refactoring to also teach WPTPaths users about WEBKIT_OUTPUTDIR.
1212
1213         * Scripts/webkitpy/common/webkit_finder.py:
1214         (WebKitFinder.path_from_webkit_outputdir):
1215         * Scripts/webkitpy/w3c/common.py:
1216         (WPTPaths):
1217         (WPTPaths.checkout_directory):
1218         (WPTPaths.wpt_checkout_path):
1219         * Scripts/webkitpy/w3c/test_importer.py:
1220         (TestImporter.__init__):
1221         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1222         (test_checkout_directory):
1223
1224 2019-06-13  Antoine Quint  <graouts@apple.com>
1225
1226         REGRESSION (r246103) [ Mojave+ WK1 ] Layout Test scrollbars/scrollbar-iframe-click-does-not-blur-content.html is timing out
1227         https://bugs.webkit.org/show_bug.cgi?id=198800
1228         <rdar://problem/51679634>
1229
1230         Reviewed by Tim Horton.
1231
1232         We didn't detect an NSScroller in a sub-frame due to WebHTMLView's implementation of -[NSView hitTest:]. We now use a private method
1233         which lets us use the default implementation and correctly returns an NSScroller in a sub-frame.
1234
1235         * DumpRenderTree/mac/EventSendingController.mm:
1236         (eventPressedMouseButtonsSwizzlerForViewAndEvent):
1237         (-[EventSendingController mouseDown:withModifiers:]):
1238         (-[EventSendingController mouseUp:withModifiers:]):
1239         (-[EventSendingController mouseMoveToX:Y:]):
1240
1241 2019-06-13  Fujii Hironori  <Hironori.Fujii@sony.com>
1242
1243         [WinCairo][WebKitTestRunner] pixel image dump outputs blank images
1244         https://bugs.webkit.org/show_bug.cgi?id=198820
1245
1246         Reviewed by Ross Kirsling.
1247
1248         WebView window paints nothing because it is moved out of the
1249         screen. Send WM_PRINT with memory DC instead of WM_PAINT as well
1250         as DumpRenderTree does.
1251
1252         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1253         (WTR::PlatformWebView::windowSnapshotImage): Send WM_PRINT instead of BitBlt.
1254
1255 2019-06-13  Tim Horton  <timothy_horton@apple.com>
1256
1257         Make it possible for validate-committer-lists to dump a mailmap file
1258         https://bugs.webkit.org/show_bug.cgi?id=198517
1259
1260         Reviewed by Simon Fraser.
1261
1262         Mailmaps wildly improve the output of various Git tools, including
1263         `git shortlog -sne`, mapping committers to our canonical name/email pair.
1264
1265         * Scripts/validate-committer-lists:
1266         (CommitterListFromGit):
1267         (CommitterListBugzillaChecker.print_committers_with_invalid_bugzilla_emails):
1268         Add some missing legacy username mappings.
1269
1270         (dump_mailmap):
1271         (dump_mailmap.format_email):
1272         (dump_mailmap.format_email_with_gitsvn_uuid):
1273         (dump_mailmap.map_emails_to_legacy_username):
1274         (main):
1275         Add `validate-committer-lists --dump-mailmap`, which generates
1276         one given committers.json and the existing mapping of legacy username
1277         to email addresses that exists in validate-committer-lists.
1278
1279 2019-06-12  Aakash Jain  <aakash_jain@apple.com>
1280
1281         Replace double-quotes with single quotes in loadConfig.py
1282         https://bugs.webkit.org/show_bug.cgi?id=198792
1283
1284         Reviewed by Jonathan Bedard.
1285
1286         * BuildSlaveSupport/ews-build/loadConfig.py:
1287         * BuildSlaveSupport/ews-build/steps_unittest.py:
1288
1289 22019-06-11  Brent Fulgham  <bfulgham@apple.com>
1290
1291         Add mechanism and test case to check if ITP is active
1292         https://bugs.webkit.org/show_bug.cgi?id=198694
1293         <rdar://problem/51557704>
1294
1295         Reviewed by Youenn Fablet.
1296
1297         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1298         (TEST):
1299
1300 2019-06-12  Michael Catanzaro  <mcatanzaro@igalia.com>
1301
1302         [WPE][GTK] Deprecate WebSQL APIs
1303         https://bugs.webkit.org/show_bug.cgi?id=195011
1304
1305         Reviewed by Carlos Garcia Campos.
1306
1307         * MiniBrowser/gtk/main.c:
1308         (gotWebsiteDataCallback):
1309         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
1310         (testWebsiteDataConfiguration):
1311         (testWebsiteDataEphemeral):
1312         (testWebsiteDataDatabases):
1313
1314 2019-06-12  Michael Catanzaro  <mcatanzaro@igalia.com>
1315
1316         [WPE][GTK] Enable hyperlink auditing
1317         https://bugs.webkit.org/show_bug.cgi?id=197845
1318
1319         Reviewed by Carlos Garcia Campos.
1320
1321         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1322         (testWebKitSettings):
1323
1324 2019-06-11  Keith Rollin  <krollin@apple.com>
1325
1326         Open up xcfilelist processing to more platforms
1327         https://bugs.webkit.org/show_bug.cgi?id=198675
1328         <rdar://problem/51533238>
1329
1330         Reviewed by Jonathan Bedard.
1331
1332         Now that it's been tested, add AppleTV{OS,Simulator} to the set of
1333         platforms on which to perform xcfilelist generation/updating.
1334
1335         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
1336         (JavaScriptCoreGenerator):
1337         (WebCoreGenerator):
1338         (WebKitGenerator):
1339
1340 2019-06-11  Jonathan Bedard  <jbedard@apple.com>
1341
1342         webkitpy: Fix device ASan reporting, add testing for report configurations
1343         https://bugs.webkit.org/show_bug.cgi?id=198756
1344
1345         Reviewed by Aakash Jain.
1346
1347         ASan results were reporting an incorrect style. This indicates we need to be testing this upload
1348         configuration thoroughly in webkitpy.
1349
1350         * Scripts/webkitpy/port/config.py:
1351         (clear_cached_configuration): Clearing configurations should clear the ASan cache as well.
1352         * Scripts/webkitpy/port/device_port.py:
1353         (DevicePort.configuration_for_upload): Add ASan as style.
1354         * Scripts/webkitpy/port/ios_device_unittest.py:
1355         (IOSDeviceTest):
1356         (IOSDeviceTest.test_default_upload_configuration):
1357         * Scripts/webkitpy/port/ios_simulator_unittest.py:
1358         (IOSSimulatorTest.test_default_upload_configuration):
1359         * Scripts/webkitpy/port/mock_drt_unittest.py:
1360         (MockDRTPortTest.test_asan_upload_configuration):
1361         * Scripts/webkitpy/port/port_testcase.py:
1362         (test_default_upload_configuration):
1363         (test_debug_upload_configuration):
1364         (test_asan_upload_configuration):
1365         (test_guard_malloc_configuration):
1366         * Scripts/webkitpy/port/watch_simulator_unittest.py:
1367         (WatchSimulatorTest):
1368         (WatchSimulatorTest.test_default_upload_configuration):
1369
1370 2019-06-11  Michael Catanzaro  <mcatanzaro@igalia.com>
1371
1372         tu-berlin university email web interface (Outlook Web App) goes directly to the light version instead of the normal web app
1373         https://bugs.webkit.org/show_bug.cgi?id=198749
1374
1375         Reviewed by Carlos Garcia Campos.
1376
1377         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1378         (TestWebKitAPI::TEST):
1379
1380 2019-06-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1381
1382         Quotes are always inserted as smart quotes on stackblitz.com, causing compilation errors
1383         https://bugs.webkit.org/show_bug.cgi?id=198735
1384         <rdar://problem/51557159>
1385
1386         Reviewed by Megan Gardner.
1387
1388         Add a test to verify that spellcheck="false" disables smart quotes and dashes, but any other value defers to the
1389         user's preferences by using UITextSmartQuotesTypeDefault and UITextSmartDashesTypeDefault.
1390
1391         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1392         (TestWebKitAPI::TEST):
1393
1394 2019-06-11  Tadeu Zagallo  <tzagallo@apple.com>
1395
1396         Unreviewed, add myself to the JavaScriptCore watchlist.
1397
1398         * Scripts/webkitpy/common/config/watchlist:
1399
1400 2019-06-11  Tadeu Zagallo  <tzagallo@apple.com>
1401
1402         Unreviewed, change my status to be a WebKit reviewer
1403
1404         * Scripts/webkitpy/common/config/contributors.json:
1405
1406 2019-06-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1407
1408         [WPE] Use new exported image API from fdo backend
1409         https://bugs.webkit.org/show_bug.cgi?id=198558
1410
1411         Reviewed by Philippe Normand.
1412
1413         * WebKitTestRunner/PlatformWPE.cmake: Do not find fdo backend and libxkb again here, since WKTR depends on
1414         WPEToolingBackends that already depends on fdo backend and libxkb
1415         * wpe/backends/CMakeLists.txt: Bump fdo requirements to 1.3.0 version.
1416         * wpe/backends/HeadlessViewBackend.cpp:
1417         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend):
1418         (WPEToolingBackends::HeadlessViewBackend::createSnapshot):
1419         (WPEToolingBackends::HeadlessViewBackend::performUpdate):
1420         (WPEToolingBackends::HeadlessViewBackend::displayBuffer):
1421         * wpe/backends/HeadlessViewBackend.h:
1422         * wpe/backends/ViewBackend.cpp:
1423         (WPEToolingBackends::ViewBackend::initialize):
1424         * wpe/backends/ViewBackend.h:
1425         * wpe/backends/WindowViewBackend.cpp:
1426         (WPEToolingBackends::WindowViewBackend::displayBuffer):
1427         * wpe/backends/WindowViewBackend.h:
1428
1429 2019-06-10  Dewei Zhu  <dewei_zhu@apple.com>
1430
1431         Extend run-benchmark to allow diagnosing before closing browser on test failure.
1432         https://bugs.webkit.org/show_bug.cgi?id=198729
1433
1434         Reviewed by Ryosuke Niwa.
1435
1436         Add '--diagnose-directory' option to store diagnose information when test failed.
1437
1438         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1439         (BenchmarkRunner.__init__):
1440         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1441         (BrowserDriver.diagnose_test_failure): Add default no-op function to base class.
1442         * Scripts/webkitpy/benchmark_runner/run_benchmark.py: Added '--diagnose-directory' option.
1443         (parse_args):
1444         (run_benchmark_plan):
1445         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py:
1446         (WebDriverBenchmarkRunner._run_one_test): Added 'diagnose_test_failure' invocation on test failure.
1447         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
1448         (WebServerBenchmarkRunner.__init__):
1449         (WebServerBenchmarkRunner._run_one_test): Added 'diagnose_test_failure' invocation on test failure.
1450
1451 2019-06-10  Sam Weinig  <weinig@apple.com>
1452
1453         Remove Dashboard support
1454         https://bugs.webkit.org/show_bug.cgi?id=198615
1455
1456         Reviewed by Ryosuke Niwa.
1457
1458         * DumpRenderTree/TestRunner.cpp:
1459         (TestRunner::staticFunctions):
1460         (setUseDashboardCompatibilityModeCallback): Deleted.
1461         * DumpRenderTree/TestRunner.h:
1462         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1463         * DumpRenderTree/mac/DumpRenderTree.mm:
1464         (resetWebViewToConsistentStateBeforeTesting):
1465         * DumpRenderTree/mac/TestRunnerMac.mm:
1466         (TestRunner::setUseDashboardCompatibilityMode): Deleted.
1467         * ImageDiff/cg/Configurations/Base.xcconfig:
1468         * Scripts/webkitperl/FeatureList.pm:
1469         * TestWebKitAPI/Configurations/Base.xcconfig:
1470         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1471         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1472         * TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm: Removed.
1473         * WebKitTestRunner/Configurations/Base.xcconfig:
1474         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1475         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1476         (WTR::InjectedBundle::beginTesting):
1477         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1478         (WTR::TestRunner::setUseDashboardCompatibilityMode): Deleted.
1479         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1480
1481 2019-06-10  Alexey Proskuryakov  <ap@apple.com>
1482
1483         Tool binaries like WebKitTestRunner have too aggressive stripping, resulting in non-symbolicated crash logs
1484         https://bugs.webkit.org/show_bug.cgi?id=198616
1485         rdar://problem/36386573
1486
1487         Reviewed by David Kilzer.
1488
1489         Adding an explicit STRIP_STYLE to appropriate xcconfigs.
1490
1491         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1492         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
1493         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig:
1494         * ImageDiff/cg/Configurations/ImageDiff.xcconfig:
1495         * MiniBrowser/Configurations/MiniBrowser.xcconfig:
1496         * MobileMiniBrowser/Configurations/MobileMiniBrowser.xcconfig:
1497         * TestWebKitAPI/Configurations/TestWTF.xcconfig:
1498         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1499         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
1500         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
1501
1502 2019-06-10  Wenson Hsieh  <wenson_hsieh@apple.com>
1503
1504         [iOS] fast/xsl tests are flaky when run after certain viewport shrink-to-fit tests
1505         https://bugs.webkit.org/show_bug.cgi?id=198699
1506         <rdar://problem/50501718>
1507
1508         Reviewed by Simon Fraser.
1509
1510         Add logic to platformResetPreferencesToConsistentValues, to reset the "ShouldIgnoreMetaViewport" preference.
1511         While this is already being adjusted in platformConfigureViewForTest using the correct, TestOptions, this might
1512         happen too late, allowing the shrink-to-fit-content heuristic to unexpectedly kick in on tests where testing
1513         viewport parameters are used.
1514
1515         * WebKitTestRunner/ios/TestControllerIOS.mm:
1516         (WTR::TestController::platformResetPreferencesToConsistentValues):
1517         (WTR::TestController::platformConfigureViewForTest):
1518
1519 2019-06-10  Yusuke Suzuki  <ysuzuki@apple.com>
1520
1521         [JSC] UnlinkedCodeBlock should be eventually jettisoned in VM mini mode
1522         https://bugs.webkit.org/show_bug.cgi?id=198023
1523
1524         Reviewed by Saam Barati.
1525
1526         * Scripts/run-jsc-stress-tests:
1527
1528 2019-06-10  Timothy Hatcher  <timothy@apple.com>
1529
1530         Integrate dark mode support for iOS.
1531         https://bugs.webkit.org/show_bug.cgi?id=198687
1532         rdar://problem/51545643
1533
1534         Reviewed by Tim Horton.
1535
1536         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1537
1538 2019-06-10  Jonathan Bedard  <jbedard@apple.com>
1539
1540         webkitpy: xcrun simctl spawn *** launchctl print system output is not utf-8
1541         https://bugs.webkit.org/show_bug.cgi?id=198723
1542
1543         Reviewed by Aakash Jain.
1544
1545         * Scripts/webkitpy/xcode/simulated_device.py:
1546         (SimulatedDevice.is_usable): Do not decode 'print system' output, it's already ASCII.
1547
1548 2019-06-10  Sihui Liu  <sihui_liu@apple.com>
1549
1550         [WKHTTPCookieStore getAllCookies:] may return duplicate cookies
1551         https://bugs.webkit.org/show_bug.cgi?id=198635
1552         <rdar://problem/46010232>
1553
1554         Reviewed by Ryosuke Niwa.
1555
1556         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
1557         (areCookiesEqual):
1558         (TEST):
1559
1560 2019-06-10  Adrian Perez de Castro  <aperez@igalia.com>
1561
1562         [JHBuild] Bump shared-mime-info to version ≥ 1.6
1563         https://bugs.webkit.org/show_bug.cgi?id=198714
1564
1565         Reviewed by Carlos Garcia Campos.
1566
1567         * gtk/jhbuild.modules: Bump shared-mime-info version to 1.10.
1568         * gtk/patches/shared-mime-info-xht-glob.patch: Removed.
1569         * gtk/patches/shared-mime-info-xhtml-magic.patch: Removed.
1570
1571 2019-06-10  Philippe Normand  <pnormand@igalia.com>
1572
1573         [WPE][Qt] Port to new wpe_fdo_egl_exported_image API
1574         https://bugs.webkit.org/show_bug.cgi?id=198713
1575
1576         Reviewed by Carlos Garcia Campos.
1577
1578         * flatpak/org.webkit.WPEModules.yaml: Include wpebackend-fdo
1579         patches currently used in JHBuild.
1580
1581 2019-06-10  Adrian Perez de Castro  <aperez@igalia.com>
1582
1583         [GTK][Flatpak] webkit-build fails due to missing libwpe in Flatpak environment
1584         https://bugs.webkit.org/show_bug.cgi?id=198711
1585
1586         Reviewed by Philippe Normand.
1587
1588         * flatpak/org.webkit.GTK.yaml: Also include modules from
1589         org.webkit.WPEModules.yaml, which brings in libwpe and WPEBackend-fdo
1590
1591 2019-06-10  Zan Dobersek  <zdobersek@igalia.com>
1592
1593         Unreviewed follow-up to r246148. Add another WPEBackend-fdo patch that
1594         avoids double-free condition that's causing bots to exit early.
1595
1596         * gtk/jhbuild.modules:
1597         * gtk/wpebackend-fdo-view-backend-exportable-private-don-t-double-free-ca.patch: Added.
1598         * wpe/jhbuild.modules:
1599         * wpe/wpebackend-fdo-view-backend-exportable-private-don-t-double-free-ca.patch: Added.
1600
1601 2019-06-09  Fujii Hironori  <Hironori.Fujii@sony.com>
1602
1603         [WinCairo][MiniBrowser] Disable MediaCapabilities until it's ready
1604         https://bugs.webkit.org/show_bug.cgi?id=198655
1605
1606         Reviewed by Ross Kirsling.
1607
1608         MediaCapabilities is enabled by default for WK2, but WinCairo
1609         doesn't implemented yet. Disable it in MiniBrowser.
1610
1611         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1612         (WebKitBrowserWindow::create):
1613
1614 2019-06-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1615
1616         [iOS] The default application name for user agent when requesting desktop content is still "Mobile/15E148"
1617         https://bugs.webkit.org/show_bug.cgi?id=198693
1618         <rdar://problem/51555371>
1619
1620         Reviewed by Tim Horton.
1621
1622         Augment an existing API test to exercise three additional scenarios:
1623             -   The web view configuration's application name is never set; the default should not include
1624                 "Mobile/15E148" in desktop mode.
1625             -   The application name is explicitly set to nil; the default application name should still not include
1626                 "Mobile/15E148".
1627             -   The application name is explicitly set to the default value, "Mobile/15E148". WKWebView should honor
1628                 this when generating the user agent, even in desktop mode.
1629
1630         * TestWebKitAPI/ios/PreferredContentMode.mm:
1631         (TestWebKitAPI::setUpWebViewForPreferredContentModeTestingWithoutNavigationDelegate):
1632         (TestWebKitAPI::setUpWebViewForPreferredContentModeTesting):
1633         (TestWebKitAPI::TEST):
1634
1635 2019-06-08  Zalan Bujtas  <zalan@apple.com>
1636
1637         [LFC] Unreviewed test gardening.
1638
1639         Remove rtl tests. They were mistakenly marked as pass.
1640
1641         * LayoutReloaded/misc/LFC-passing-tests.txt:
1642
1643 2019-06-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
1644
1645         REGRESSION (r244182) [WK1]: Page updates should always scheduleCompositingLayerFlush() immediately
1646         https://bugs.webkit.org/show_bug.cgi?id=198664
1647
1648         Reviewed by Simon Fraser.
1649
1650         Delete repeated entries which were submitted by mistake.
1651
1652         * Tracing/SystemTracePoints.plist:
1653
1654 2019-06-07  Wenson Hsieh  <wenson_hsieh@apple.com>
1655
1656         Allow clients to vend custom -inputView and -inputAccessoryView by overriding WKWebView methods
1657         https://bugs.webkit.org/show_bug.cgi?id=198631
1658         <rdar://problem/51505431>
1659
1660         Reviewed by Tim Horton.
1661
1662         Add an API test that overrides -[WKWebView inputView] and -[WKWebView inputAccessoryView].
1663
1664         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1665         (-[CustomInputWebView initWithFrame:configuration:inputView:inputAccessoryView:]):
1666         (-[CustomInputWebView inputView]):
1667         (-[CustomInputWebView inputAccessoryView]):
1668         (TestWebKitAPI::TEST):
1669
1670 2019-06-07  Daniel Bates  <dabates@apple.com>
1671
1672         [lldb-webkit] Pretty-print all kinds of Documents
1673         https://bugs.webkit.org/show_bug.cgi?id=198620
1674
1675         Reviewed by Simon Fraser.
1676
1677         Register formatters for all classes derived from WebCore::Document so we get nice summaries
1678         without having to drill down in Xcode- or casting- to the base class, Document.
1679
1680         Older LLDB versions use to do this automatically, but this functionality was removed in newer
1681         versions:
1682             [[
1683                 Warning: previous versions of LLDB defined cascading to mean not only going through typedef
1684                 chains, but also through inheritance chains. This feature has been removed since it
1685                 significantly degrades performance. You need to set up your formatters for every type in
1686                 inheritance chains to which you want the formatter to apply.
1687             ]]
1688             <https://lldb.llvm.org/use/variable.html> (as of 06/06/2019)
1689
1690         * lldb/lldb_webkit.py:
1691         (__lldb_init_module):
1692
1693 2019-06-07  Jonathan Bedard  <jbedard@apple.com>
1694
1695         webkitpy: Support reporting results for uncommon test configurations
1696         https://bugs.webkit.org/show_bug.cgi?id=198662
1697         <rdar://problem/51524128>
1698
1699         Reviewed by Aakash Jain.
1700
1701         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1702         (Manager.run): Override wk1 and wk2 flavors with specified flavor.
1703         * Scripts/webkitpy/port/base.py:
1704         (Port.configuration_for_upload): Set flavor based on options.
1705         * Scripts/webkitpy/results/options.py:
1706         (upload_options): Add result-report-flavor option.
1707         * Scripts/webkitpy/test/main.py:
1708         (Tester._run_tests): Set flavor based on options.
1709
1710 2019-06-07  Wenson Hsieh  <wenson_hsieh@apple.com>
1711
1712         [iOS] At least 6 API tests are failing due to an exception when writing NSAttributedString to the pasteboard
1713         https://bugs.webkit.org/show_bug.cgi?id=198641
1714         <rdar://problem/51266310>
1715
1716         Reviewed by Tim Horton.
1717
1718         Work around a bug in a lower-level framework, which currently prevents NSAttributedStrings from being written to
1719         UIPasteboard by way of -[NSItemProvider registerObject:visibility:]. This is because, when saving a
1720         representation of "public.rtfd" to disk, the default suggested filename (determined using CoreServices APIs
1721         _UTTypeCreateSuggestedFilename and UTTypeCopyDescription) ends up being nil; UIKit then subsequently tries to
1722         append nil as a path component using -URLByAppendingPathComponent:, which throws an exception. This only
1723         reproduces on iOS simulator.
1724
1725         To work around this for the time being, simply avoid writing a representation of "public.rtfd" to disk. This
1726         representation is actually ignored by most clients anyways (including WebKit), in favor of using
1727         "com.apple.flat-rtfd".
1728
1729         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1730         (TestWebKitAPI::TEST):
1731         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1732         (applyWorkaroundToAllowWritingAttributedStringsToItemProviders):
1733         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
1734
1735 2019-06-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1736
1737         REGRESSION(r244857): [GTK][WPE] Many tests are no longer run in the bots after r244857
1738         https://bugs.webkit.org/show_bug.cgi?id=198607
1739
1740         Reviewed by Michael Catanzaro.
1741
1742         Since r244857 several test executables are compiled in the base tests directory instead of using their own sub
1743         directory. Our scripts to run the tests rely on the tests location to decide whether to run them or not, or
1744         determine the type of the tests.
1745
1746         * Scripts/run-gtk-tests:
1747         (GtkTestRunner): Rename TEST_DIRS as TEST_TARGETS and use the executable names for tests not in a subdirectory.
1748         (GtkTestRunner._setup_testing_environment): Fix TestWebKitAccessibility directory name.
1749         (GtkTestRunner.is_glib_test): Use the test name for the ones not using a subdirectory.
1750         (GtkTestRunner.is_google_test): Ditto.
1751         * Scripts/run-wpe-tests:
1752         (WPETestRunner): Rename TEST_DIRS as TEST_TARGETS and use the executable names for tests not in a subdirectory.
1753         (WPETestRunner.is_glib_test): Use the test name for the ones not using a subdirectory.
1754         (WPETestRunner.is_google_test): Ditto.
1755         * glib/api_test_runner.py:
1756         (TestRunner): Rename TEST_DIRS as TEST_TARGETS.
1757         (TestRunner._get_tests): Handle test targets which can now contain directories and executables.
1758
1759 2019-06-06  Keith Rollin  <krollin@apple.com>
1760
1761         Remove SSL-based tests from TestWebKitAPI on some configurations
1762         https://bugs.webkit.org/show_bug.cgi?id=198551
1763         <rdar://problem/51424996>
1764
1765         Reviewed by Jonathan Bedard.
1766
1767         Not all platforms have SSL handy, so don't include SSL-based tests on
1768         those platforms.
1769
1770         * TestWebKitAPI/TCPServer.cpp:
1771         * TestWebKitAPI/TCPServer.h:
1772         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1773         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
1774         * TestWebKitAPI/config.h:
1775
1776 2019-06-06  Daniel Bates  <dabates@apple.com>
1777
1778         [lldb-webkit] TypeError: cannot concatenate 'str' and 'int' objects when prettify SecurityOrigin with
1779         non-default port number
1780         https://bugs.webkit.org/show_bug.cgi?id=198618
1781
1782         Reviewed by Brent Fulgham.
1783
1784         WebCoreSecurityOriginProvider.port() returns an int data type. We need to explicitly convert this to
1785         a string before we concatenate it with another string when building the string representation
1786         for the WebCore::SecurityOrigin object. Otherwise, Python complains that we are concatenating a str
1787         with an int and we don't get a pretty-printed representation for WebCore::SecurityOrigin.
1788
1789         * lldb/lldb_webkit.py:
1790         (WebCoreSecurityOriginProvider.to_string): Call str() on the port before concatenting it.
1791
1792 2019-06-06  Jonathan Bedard  <jbedard@apple.com>
1793
1794         Remove obsolete TOOLCHAINS overrides from as asan.xcconfig
1795         https://bugs.webkit.org/show_bug.cgi?id=198613
1796
1797         Reviewed by Alexey Proskuryakov.
1798
1799         * asan/asan.xcconfig: XCBuild doesn't support overriding toolchains.
1800
1801 2019-06-06  Jonathan Bedard  <jbedard@apple.com>
1802
1803         webkitpluginhost: Support ASan as a style
1804         https://bugs.webkit.org/show_bug.cgi?id=198586
1805         <rdar://problem/51459088>
1806
1807         Reviewed by Alexey Proskuryakov.
1808
1809         * Scripts/webkitpy/port/base.py:
1810         (Port.configuration_for_upload): Add ASan as a style.
1811         * Scripts/webkitpy/port/config.py:
1812         (Config._read_configuration):
1813         (Config):
1814         (Config.asan): Add property to check if the ASan configuration is active.
1815         * Scripts/webkitpy/port/config_unittest.py:
1816         (ConfigTest.test_default_configuration__scripterror):
1817         (ConfigTest):
1818         (ConfigTest.test_asan):
1819         * Scripts/webkitpy/test/main.py:
1820         (Tester._run_tests): Add Asan as a style.
1821
1822 2019-06-06  Alexey Proskuryakov  <ap@apple.com>
1823
1824         block-spammers tool doesn't block e-mail
1825         https://bugs.webkit.org/show_bug.cgi?id=198570
1826
1827         Reviewed by Jonathan Bedard.
1828
1829         * Scripts/block-spammers: (disable_user): Corrected the parameters, Bugzilla doesn't
1830         recognize "false" here. Also, request body is unnecessary.
1831
1832 2019-06-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1833
1834         [GTK][WPE] Enable PSON
1835         https://bugs.webkit.org/show_bug.cgi?id=194979
1836
1837         Reviewed by Žan Doberšek.
1838
1839         Add WPEBackend-fdo patch required for PSON to work. It can be removed once we have a new version to depend on.
1840
1841         * gtk/jhbuild.modules:
1842         * gtk/patches/wpebackend-fdo-Handle-the-case-of-new-target-created-for-the-same-v.patch: Added.
1843         * wpe/jhbuild.modules:
1844         * wpe/patches/wpebackend-fdo-Handle-the-case-of-new-target-created-for-the-same-v.patch: Added.
1845
1846 2019-06-05  Andy Estes  <aestes@apple.com>
1847
1848         [macOS] Stop calling -[NSDraggingItem setItem:]
1849         https://bugs.webkit.org/show_bug.cgi?id=198588
1850         <rdar://problem/48297453>
1851
1852         On macOS Catalina, use -[NSDraggingItem _initWithItem:] instead.
1853
1854         Reviewed by Wenson Hsieh.
1855
1856         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Fixed up file paths in the
1857         TestRunnerShared group.
1858
1859         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1860         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1861         Changed to call -[NSDraggingItem _initWithItem:] when available.
1862
1863         * TestRunnerShared/spi/AppKitTestSPI.h: Renamed from
1864         Tools/DumpRenderTree/mac/AppKitTestSPI.h and moved NSDraggingItem internal interface
1865         declarations here from DumpRenderTree.
1866
1867         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1868         Added TestRunnerShared/spi/AppKitTestSPI.h.
1869
1870         * TestWebKitAPI/mac/TestDraggingInfo.mm:
1871         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1872         Changed to call -[NSDraggingItem _initWithItem:] when available.
1873
1874 2019-06-05  Jer Noble  <jer.noble@apple.com>
1875
1876         -[WKWebView _suspendAllMediaPlayback] does not persist across navigation.
1877         https://bugs.webkit.org/show_bug.cgi?id=198585
1878
1879         Reviewed by Chris Dumez.
1880
1881         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1882         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1883         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSuspendAllMediaPlayback.mm: Added.
1884         (TEST):
1885         * TestWebKitAPI/Tests/WebKitLegacy/ios/video-with-audio.html:
1886
1887 2019-06-05  Alex Christensen  <achristensen@webkit.org>
1888
1889         Re-enable safe browsing in WKWebView
1890         https://bugs.webkit.org/show_bug.cgi?id=196161
1891         <rdar://problem/49171413>
1892
1893         Reviewed by Ryosuke Niwa.
1894
1895         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1896         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1897         (TEST):
1898         (safeBrowsingView):
1899
1900 == Rolled over to ChangeLog-2019-06-05 ==