There should be a way to disable optimizer in webkit-patch rebaseline-expectations
[WebKit-https.git] / Tools / ChangeLog
1 2012-03-05  Dirk Pranke  <dpranke@chromium.org>
2
3         There should be a way to disable optimizer in webkit-patch rebaseline-expectations
4         https://bugs.webkit.org/show_bug.cgi?id=69590
5
6         Reviewed by Ryosuke Niwa.
7
8         Adds a --no-optimize flag to webkit-patch rebaseline-expectations
9         to skip the 'optimize-expectations' step.
10
11         * Scripts/webkitpy/tool/commands/rebaseline.py:
12         (RebaselineExpectations.__init__):
13         (RebaselineExpectations.execute):
14         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
15
16 2012-03-05  Kent Tamura  <tkent@chromium.org>
17
18         [Chromium] Add new popup type: PagePopup
19         https://bugs.webkit.org/show_bug.cgi?id=80106
20
21         Reviewed by Darin Fisher.
22
23         * DumpRenderTree/chromium/WebViewHost.cpp:
24         (WebViewHost::createPopupMenu):
25
26 2012-03-05  Jessie Berlin  <jberlin@apple.com>
27
28         Add myself as a reviewer.
29
30         * Scripts/webkitpy/common/config/committers.py:
31         Also, add my IRC nick so it is easier to find and yell at me.
32
33 2012-03-05  Robert Kroeger  <rjkroege@chromium.org>
34
35         Correctly compute the positions of GestureScroll* events on
36         Chromium.
37         https://bugs.webkit.org/show_bug.cgi?id=80075
38
39         Reviewed by Adam Barth.
40
41         * DumpRenderTree/chromium/EventSender.cpp:
42         (EventSender::reset):
43         (EventSender::gestureEvent):
44         * DumpRenderTree/chromium/EventSender.h:
45         (EventSender):
46
47 2012-03-05  Dirk Pranke  <dpranke@chromium.org>
48
49         flakiness dashboard doesn't display baselines for virtual tests correctly
50         https://bugs.webkit.org/show_bug.cgi?id=80341
51
52         Reviewed by Ojan Vafai.
53
54         If the test is part of a virtual test suite, we need to look for
55         baselines in the underlying fallback path for the actual test
56         being run, as well as baselines for the virtual version.
57
58         This patch adds code to handle both branches and also pulls the
59         mapping of the test suites up into a constant.
60
61         * TestResultServer/static-dashboards/flakiness_dashboard.html:
62         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
63         (testLookupVirtualTestSuite):
64         (testBaseTest):
65
66 2012-03-05  Sheriff Bot  <webkit.review.bot@gmail.com>
67
68         Unreviewed, rolling out r109760.
69         http://trac.webkit.org/changeset/109760
70         https://bugs.webkit.org/show_bug.cgi?id=80320
71
72         Caused many GTK+ tests to crash (Requested by mrobinson on
73         #webkit).
74
75         * gtk/jhbuild.modules:
76
77 2012-03-05  Charlie Reis  <creis@chromium.org>
78
79         [chromium] Pass WebNavigationPolicy to WebViewClient::createView
80         https://bugs.webkit.org/show_bug.cgi?id=80057
81
82         Reviewed by Darin Fisher.
83
84         * DumpRenderTree/chromium/WebViewHost.cpp:
85         (WebViewHost::createView):
86         * DumpRenderTree/chromium/WebViewHost.h:
87         (WebViewHost):
88
89 2012-03-05  Martin Robinson  <mrobinson@igalia.com>
90
91         [soup] Crash while loading http://www.jusco.cn
92         https://bugs.webkit.org/show_bug.cgi?id=68238
93
94         Reviewed by Philippe Normand.
95
96         * gtk/jhbuild.modules: Bumped the libsoup and glib dependencies
97         in the jhbuild file.
98
99 2012-03-05  Sheriff Bot  <webkit.review.bot@gmail.com>
100
101         Unreviewed, rolling out r109748.
102         http://trac.webkit.org/changeset/109748
103         https://bugs.webkit.org/show_bug.cgi?id=80296
104
105         Made some tests crash, will fix and recommit (Requested by
106         noamr on #webkit).
107
108         * MiniBrowser/qt/main.cpp:
109         (main):
110
111 2012-03-05  Zan Dobersek  <zandobersek@gmail.com>
112
113         [GTK] plugins/netscape-plugin-page-cache-works.html fails
114         https://bugs.webkit.org/show_bug.cgi?id=74409
115
116         Reviewed by Martin Robinson.
117
118         Add support for overriding the page-cache-for-plugins preference
119         through DumpRenderTreeSupport.
120
121         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
122         (booleanFromValue): A helper function to convert a string to boolean.
123         (LayoutTestController::overridePreference):
124
125 2012-03-05  Rob Buis  <rbuis@rim.com>
126
127         [BlackBerry] Update Tools/DumpRenderTree
128         https://bugs.webkit.org/show_bug.cgi?id=80287
129
130         Reviewed by Antonio Gomes.
131
132         Update so we are sure we can build our implementation of DRT.
133
134         * DumpRenderTree/DumpRenderTree.h: include DumpRenderTreeBlackBerry.h.
135         * DumpRenderTree/PixelDumpSupport.cpp: include PixelDumpSupportBlackBerry.h.
136         * DumpRenderTree/blackberry/AccessibilityControllerBlackBerry.cpp:
137         (AccessibilityController::addNotificationListener): add missing hook.
138         (AccessibilityController::removeNotificationListener): add missing hook.
139         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
140         (AccessibilityUIElement::isSelectedOptionActive): add missing hook.
141         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
142         (LayoutTestController::setMockSpeechInputDumpRect): add missing hook.
143         (LayoutTestController::simulateDesktopNotificationClick): add missing hook.
144
145 2012-03-05  No'am Rosenthal  <noam.rosenthal@nokia.com>
146
147         [Qt] [WK2] Support threaded renderer in WK2
148         https://bugs.webkit.org/show_bug.cgi?id=76661
149
150         Remove the QML_NO_THREADED_RENDERER environment variable from MiniBrowser.
151
152         Reviewed by Kenneth Rohde Christiansen.
153
154         * MiniBrowser/qt/main.cpp:
155         (main):
156
157 2012-03-05  Alexander Færøy  <alexander.faeroy@nokia.com>
158
159         Unreviewed. Add myself to committer list.
160
161         * Scripts/webkitpy/common/config/committers.py:
162
163 2012-03-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
164
165         [Qt] Use config test to determine if the compiler supports -MD
166
167         We used to assume that unix systems building against Qt5 would have
168         a compiler that supported -MD. Although this was usually the case,
169         we failed to take into account broken tools for distributed builds
170         (e.g. teambuilder or icecream) which would end up producing .d files
171         in the root of the build dir instead of along-side the object file.
172
173         Now that we use a config-test to determine the support, we'll capture
174         those cases, unless distributed builds are enabled after the initial
175         build-webkit run.
176
177         Reviewed by Csaba Osztrogonác.
178
179         * Tools.pro:
180         * qmake/config.tests/gccdepends/empty.cpp: Added.
181         * qmake/config.tests/gccdepends/gccdepends.pro: Added.
182         * qmake/mkspecs/features/default_pre.prf:
183         * qmake/mkspecs/features/features.prf:
184         * qmake/mkspecs/features/unix/default_pre.prf:
185         * qmake/sync.profile:
186
187 2012-03-05  Csaba Osztrogonác  <ossy@webkit.org>
188
189         Qt API test buildstep throws exception after buildmaster update
190         https://bugs.webkit.org/show_bug.cgi?id=80249
191
192         Reviewed by Zoltan Herczeg.
193
194         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Disable API tests on the Qt bot temporarily.
195         (BuildAndTestFactory.__init__):
196
197 2012-03-04  Martin Robinson  <mrobinson@igalia.com>
198
199         [GTK] Unit tests are noisy when run under jhbuild
200         https://bugs.webkit.org/show_bug.cgi?id=80241
201
202         Reviewed by Philippe Normand.
203
204         Force the 'memory' backend in GSettings so that each unit
205         test doesn't produce a warning when it's forced to fall back
206         to the 'memory' backend.
207
208         * Scripts/run-gtk-tests:
209         (TestRunner.run): Force the 'memory' backend.
210
211 2012-03-04  Martin Robinson  <mrobinson@igalia.com>
212
213         [GTK] "Console: undefined @0: ReferenceError: Can't find variable: WebInspector" during testwebinspector
214         https://bugs.webkit.org/show_bug.cgi?id=80235
215
216         Reviewed by Philippe Normand.
217
218         * Scripts/run-gtk-tests:
219         (TestRunner.run): Use the WEBKIT_INSPECTOR_PATH environment variable so that
220         inspector resources path determination is shared by all tests.
221
222 2012-03-04  Martin Robinson  <mrobinson@igalia.com>
223
224         [GTK] REGRESSION: r108278 broke some tests that expect focus
225         https://bugs.webkit.org/show_bug.cgi?id=79084
226
227         Reviewed by Philippe Normand.
228
229         Grab focus when dumping test results and also when sending
230         events. During the course of testing, the WebView may lose
231         focus and this seems to snap it back when tests demand it.
232
233         * DumpRenderTree/gtk/DumpRenderTree.cpp:
234         (dump): Grab focus.
235         * DumpRenderTree/gtk/EventSender.cpp:
236         (dispatchEvent): Ditto.
237
238 2012-03-04  Charles Wei  <charles.wei@torchmobile.com.cn>
239
240         Unreviewed, Add myself to committer list.
241         https://bugs.webkit.org/show_bug.cgi?id=80232
242
243         * Scripts/webkitpy/common/config/committers.py:
244
245 2012-03-04  Anders Carlsson  <andersca@apple.com>
246
247         Newer versions of clang fail to compile WebKit.
248
249         Fix build.
250
251         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
252         (descriptionOfValue):
253         (AccessibilityUIElement::rowIndexRange):
254         (AccessibilityUIElement::columnIndexRange):
255         (AccessibilityUIElement::selectedTextRange):
256         * DumpRenderTree/mac/EditingDelegate.mm:
257         (-[DOMRange dump]):
258         * DumpRenderTree/mac/PolicyDelegate.mm:
259         (-[PolicyDelegate webView:unableToImplementPolicyWithError:frame:]):
260         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
261         (-[NSError _drt_descriptionSuitableForTestResult]):
262         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
263         (WTR::descriptionOfValue):
264         (WTR::AccessibilityUIElement::rowIndexRange):
265         (WTR::AccessibilityUIElement::columnIndexRange):
266         (WTR::AccessibilityUIElement::selectedTextRange):
267
268 2012-03-03  Simon Hausmann  <simon.hausmann@nokia.com>
269
270         [Qt] Fix static_libs_as_shared build
271         https://bugs.webkit.org/show_bug.cgi?id=80214
272
273         Reviewed by Tor Arne Vestbø.
274
275         * WebKitTestRunner/qt/main.cpp:
276         (main): Set the correct environment variable for choosing the theme in the
277         web process.
278
279 2012-03-03  Hans Wennborg  <hans@chromium.org>
280
281         Implement Speech JavaScript API
282         https://bugs.webkit.org/show_bug.cgi?id=80019
283
284         Reviewed by Adam Barth.
285
286         Add ENABLE_SCRIPTED_SPEECH.
287
288         * Scripts/build-webkit:
289         * qmake/mkspecs/features/features.prf:
290
291 2012-03-02  Alexey Proskuryakov  <ap@apple.com>
292
293         Fix commit queue, remove duplicate entry.
294
295         * Scripts/webkitpy/common/config/committers.py:
296
297 2012-03-02  Stephen Chenney  <schenney@chromium.org>
298
299         Unreviewed, add myself as a committer
300
301         * Scripts/webkitpy/common/config/committers.py:
302
303 2012-03-02  Ojan Vafai  <ojan@chromium.org>
304
305         Add the Chromium Lion canary bot to the flakiness dashboard.
306         * TestResultServer/static-dashboards/builders.js:
307
308 2012-03-02  Dirk Pranke  <dpranke@chromium.org>
309
310         links for virtual tests are broken in the flakiness dashboard
311         https://bugs.webkit.org/show_bug.cgi?id=80180
312
313         Reviewed by Ojan Vafai.
314
315         * TestResultServer/static-dashboards/flakiness_dashboard.html:
316         (linkHTMLToOpenWindow):
317         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
318         (testLinkHTMLToOpenWindow): added.
319
320 2012-03-02  Philippe Normand  <pnormand@igalia.com>
321
322         [GTK] security/block-test.html baselines differ from mac
323         https://bugs.webkit.org/show_bug.cgi?id=78343
324
325         Reviewed by Martin Robinson.
326
327         Improved the FrameLoader error heuristics to match mac behavior a
328         bit more.
329
330         * DumpRenderTree/gtk/DumpRenderTree.cpp:
331         (pathFromSoupURI): Handle ftp urls the same as http urls.
332         (descriptionSuitableForTestResult): Map WebKitPolicyError to WebKitErrorDomain.
333
334 2012-03-02  Andras Becsi  <andras.becsi@nokia.com>
335
336         [Qt][WK2] Fix typo in patch committed in r109575
337
338         Unreviewed typo fix.
339
340         * MiniBrowser/qt/MiniBrowserApplication.cpp:
341         (MiniBrowserApplication::notify): Cache the position
342         in floating point coordinates.
343
344 2012-03-02  Andras Becsi  <andras.becsi@nokia.com>
345
346         [Qt][WK2] Infinite loop on history navigation, when panning
347         https://bugs.webkit.org/show_bug.cgi?id=79119
348
349         Reviewed by Simon Hausmann.
350
351         Make the touch mocking more robust by creating touch events
352         directly and sending them synchronously to the browser window.
353         If the sent touch event was not accepted we propagate the
354         original mouse event to its target.
355         This way we make sure we only send either a touch or a mouse
356         event and do not end up in an infinite loop between our mocking
357         code and the Qt5 automatic mouse event synthesizing.
358
359         * MiniBrowser/qt/BrowserWindow.cpp:
360         (BrowserWindow::updateVisualMockTouchPoints):
361         * MiniBrowser/qt/BrowserWindow.h:
362         (BrowserWindow):
363         * MiniBrowser/qt/MiniBrowserApplication.cpp:
364         (touchRectForPosition):
365         (MiniBrowserApplication::notify):
366         (MiniBrowserApplication::sendTouchEvent):
367         * MiniBrowser/qt/MiniBrowserApplication.h:
368         (MiniBrowserApplication):
369
370 2012-03-02  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
371
372         [Qt] Use 'all' as default target when debug_and_release is in effect
373
374         When debug_and_release is enabled, in combination with build_all,
375         qmake will generate an aggregate makefile that calls make on both
376         the debug and the release makefiles, but with the 'all' target.
377
378         In this case we can't use 'first' as the default target, as the
379         extra targets would then not be run, so we append extra targets
380         to 'all' instead.
381
382         Reviewed by Simon Hausmann.
383
384         * qmake/mkspecs/features/default_post.prf:
385
386 2012-03-02  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
387
388         [Qt] Make sure activeBuildConfig() returns the right config
389
390         Using isActiveConfig fails, as that only checks if the given
391         argument is in CONFIG, not the order.
392
393         Reviewed by Simon Hausmann.
394
395         * qmake/mkspecs/features/functions.prf:
396
397 2012-03-02  Simon Hausmann  <simon.hausmann@nokia.com>
398
399         [Qt] Fix tests run with WTR not using QStyle theme
400         https://bugs.webkit.org/show_bug.cgi?id=80147
401
402         Reviewed by Csaba Osztrogonác.
403
404         * WebKitTestRunner/qt/main.cpp:
405         (main): Set environment variable for web process to use QStyle theme.
406
407 2012-03-02  Philippe Normand  <pnormand@igalia.com>
408
409         Unreviewed, remove debug print call.
410
411         * DumpRenderTree/gtk/DumpRenderTree.cpp:
412         (descriptionSuitableForTestResult):
413
414 2012-03-02  Robert Kroeger  <rjkroege@chromium.org>
415
416         Updated EventSender to send complete gesture events.
417         https://bugs.webkit.org/show_bug.cgi?id=80075
418
419         Reviewed by Adam Barth.
420
421         * DumpRenderTree/chromium/EventSender.cpp:
422         (EventSender::gestureEvent): set additional parameters in sent events.
423
424 2012-03-01  Kalev Lember  <kalevlember@gmail.com>
425
426         WebKitTestRunner: Explicitly include unistd.h for gcc 4.7
427         https://bugs.webkit.org/show_bug.cgi?id=80033
428
429         Reviewed by Gustavo Noronha Silva.
430
431         GCC 4.7 no longer includes unistd.h from most of the standard C++
432         header files, so we need to explicitly include it for getcwd().
433
434         * WebKitTestRunner/TestInvocation.cpp: Make sure unistd.h gets included
435         not only on Mac, but on all Unix platforms.
436
437 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
438
439         Actually look at the args in driver_input :(.
440
441         Unreviewed, build fix.
442
443         * Scripts/webkitpy/layout_tests/port/chromium.py:
444         (ChromiumDriver.run_test):
445
446 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
447
448         Fix typo in flag used to run gpu virtual suites.
449
450         Unreviewed, build fix.
451
452         * Scripts/webkitpy/layout_tests/port/chromium.py:
453         (ChromiumPort.virtual_test_suites):
454
455 2012-03-01  Adam Barth  <abarth@webkit.org>
456
457         Unreviewed, rolling out r109317.
458         http://trac.webkit.org/changeset/109317
459
460         Let's try watchlists again now that we're using a pure git
461         working copy
462
463         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
464         (StyleQueueTask.run):
465         * Scripts/webkitpy/tool/commands/queues_unittest.py:
466
467 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
468
469         webkitpy: test_run_test_pause_before_testing is failing after r109482
470         https://bugs.webkit.org/show_bug.cgi?id=80084
471
472         Unreviewed, build fix.
473
474         Fixes the test string compare to ignore the time spent running
475         the tests.
476
477         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
478         (test_run_test_pause_before_testing):
479
480 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
481
482         nrwt: virtual tests aren't being run
483         https://bugs.webkit.org/show_bug.cgi?id=80083
484
485         Reviewed by Eric Seidel.
486
487         If we tried to run all of the tests by default (and
488         didn't specify any paths), the virtual tests weren't
489         picked up.
490
491         * Scripts/webkitpy/layout_tests/port/base.py:
492         (Port._virtual_tests):
493         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
494         (PortTest.test_tests):
495         * Scripts/webkitpy/layout_tests/port/test.py:
496         (TestPort.virtual_test_suites):
497
498 2012-03-01  Ryosuke Niwa  <rniwa@webkit.org>
499
500         run-perf-tests should report the test runtime
501         https://bugs.webkit.org/show_bug.cgi?id=80078
502
503         Reviewed by Hajime Morita.
504
505         Record and output the aggreated test run time.
506
507         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
508         (PerfTestsRunner._run_single_test):
509
510 2012-03-01  Michael Nordman  <michaeln@google.com>
511
512         [chromium] Use webkit_support to create session storage namespaces in DRT.
513         https://bugs.webkit.org/show_bug.cgi?id=79933
514
515         Reviewed by Tony Chang.
516
517         * DumpRenderTree/chromium/WebViewHost.cpp:
518         (WebViewHost::createSessionStorageNamespace):
519
520 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
521
522         nrwt: test_isfile, test_isdir, and test_exists don't work for virtual tests
523         https://bugs.webkit.org/show_bug.cgi?id=80048
524
525         Reviewed by Adam Barth.
526
527         * Scripts/webkitpy/layout_tests/port/base.py:
528         (Port.test_isfile):
529         (Port.test_isdir):
530         (Port):
531         (Port.test_exists):
532         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
533         (PortTest.test_test_exists):
534         (PortTest):
535         (PortTest.test_test_isfile):
536         (PortTest.test_test_isdir):
537         * Scripts/webkitpy/layout_tests/port/test.py:
538         (TestPort.virtual_test_suites):
539         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
540         (MainTest.test_virtual):
541
542 2012-03-01  Kalev Lember  <kalevlember@gmail.com>
543
544         [GTK] Avoid building any parts of WebKitTestRunner when WK2 is disabled
545         https://bugs.webkit.org/show_bug.cgi?id=80031
546
547         Reviewed by Gustavo Noronha Silva.
548
549         Only build the libTestRunnerInjectedBundle.la convenience library when
550         ENABLE_WEBKIT2 is defined.
551
552         * WebKitTestRunner/GNUmakefile.am:
553
554 2012-03-01  Philippe Normand  <pnormand@igalia.com>
555
556         Unreviewed, second attempt to fix GTK NRWT after r109242.
557
558         * Scripts/webkitpy/layout_tests/port/gtk.py:
559         (GtkDriver._start):
560
561 2012-03-01  Philippe Normand  <pnormand@igalia.com>
562
563         Unreviewed, GTK NRWT build fix attempt after r109242.
564
565         * Scripts/webkitpy/layout_tests/port/gtk.py:
566         (GtkDriver._start):
567
568 2012-03-01  Kentaro Hara  <haraken@chromium.org>
569
570         REGRESSION(r109036): run-bindings-tests fails because resolve-supplemental.pl was renamed
571         https://bugs.webkit.org/show_bug.cgi?id=80008
572
573         Reviewed by Adam Barth.
574
575         In r109036, I forgot to rename "resolve-supplemental.pl" in run-bindings-tests
576         to "preprocess-idls.pl". This patch renames it.
577
578         Test: Confirm that run-bindings-tests runs.
579
580         * Scripts/webkitpy/bindings/main.py:
581         (BindingsTests.generate_supplemental_dependency):
582
583 2012-02-29  Simon Hausmann  <simon.hausmann@nokia.com>
584
585         [Qt][WK2] QQuickWebView::event should lookup faster which events QQuickWebPage can handle
586         https://bugs.webkit.org/show_bug.cgi?id=78047
587
588         Reviewed by Kenneth Rohde Christiansen.
589
590         Send events for the webview through the QQuickCanvas instead of directly to the item. Direct
591         sending to the item requires the QObject::event re-implementation to dispatch to the correct
592         event handling function. However QQuickItem::event doesn't do that. Instead QQuickCanvas calls
593         the event handlers directly, and with the removal of our own dispatching we need to go through
594         that code path.
595
596         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
597         (WTR::PlatformWebView::sendEvent):
598         (WTR::PlatformWebView::postEvent):
599
600 2012-02-29  Adam Barth  <abarth@webkit.org>
601
602         Disable watchlist.  It's been spamming CCs.
603
604         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
605         (StyleQueueTask.run):
606         * Scripts/webkitpy/tool/commands/queues_unittest.py:
607
608 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
609
610         need to clone the gpu baselines and expectations into the new "virtual" dir
611         https://bugs.webkit.org/show_bug.cgi?id=79956
612
613         Reviewed by Adam Barth.
614
615         * Scripts/webkitpy/layout_tests/port/chromium.py:
616         (ChromiumPort.virtual_test_suites):
617
618 2012-02-29  Mark Rowe  <mrowe@apple.com>
619
620         Switch to using json rather than simplejson now that the master is using Python 2.7.
621
622         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
623         (loadBuilderConfig):
624
625 2012-02-29  David Levin  <levin@chromium.org>
626
627         [chromium] Add the ability to turn off autoresize.
628         https://bugs.webkit.org/show_bug.cgi?id=77452
629
630         Reviewed by Darin Fisher.
631
632         * DumpRenderTree/chromium/LayoutTestController.cpp:
633         (LayoutTestController::LayoutTestController): Expose a way to turn off auto-resize.
634         (LayoutTestController::enableAutoResizeMode): Ditto and adjust to new WebKit api.
635         (LayoutTestController::disableAutoResizeMode):  Ditto.
636         * DumpRenderTree/chromium/LayoutTestController.h: Ditto.
637
638 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
639
640         nrwt: make --print trace work with virtual tests
641         https://bugs.webkit.org/show_bug.cgi?id=79952
642
643         Reviewed by Adam Barth.
644
645         * Scripts/webkitpy/layout_tests/views/printing.py:
646         (Printer._print_test_trace):
647         (Printer._print_baseline):
648
649 2012-02-28  Brian Weinstein  <bweinstein@apple.com>
650
651         WebKit2: didNewFirstVisuallyNonEmptyLayout should be sent to injected bundle
652         https://bugs.webkit.org/show_bug.cgi?id=79849
653
654         Reviewed by Beth Dakin.
655
656         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
657         (WTR::InjectedBundlePage::InjectedBundlePage): Add an entry to the struct.
658
659 2012-02-29  Lucas Forschler  <lforschler@apple.com>
660
661         Removed unused Apple buildslaves from the master configuration
662         https://bugs.webkit.org/show_bug.cgi?id=79925
663
664         Reviewed by Stephanie Lewis.
665
666         * BuildSlaveSupport/build.webkit.org-config/config.json:
667
668 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
669
670         nrwt: implement simple 'virtual test suite' support
671         https://bugs.webkit.org/show_bug.cgi?id=79737
672
673         Reviewed by Adam Barth.
674
675         Add very basic support for 'virtual test suites' to NRWT:
676         a virtual suite is a directory that may contain new baselines,
677         contains a pointer to a "base" directory of tests, and an
678         optional list of command line arguments to pass to DRT;
679         it gives us a way to run all of the tests in a given directory
680         multiple times with multiple (potentially differing) sets of
681         results and baselines.
682
683         This patch implements the support needed for this feature, and
684         some basic tests, but no actual port will use the feature yet.
685
686         This is probably the simplest implementation possible - the
687         list of virtual suites will be hard-coded into the port's
688         implementation. One can imagine a more data-driven approach
689         where the suite instructions are stored in a manifest file
690         either in LayoutTests (all suites in one file), or per-port,
691         or per-directory. If this feature ends up being useful we
692         should probably add something like that so people don't have
693         to hunt around in the code to add suites.
694
695         * Scripts/webkitpy/layout_tests/port/base.py:
696         (Port.__init__):
697         (Port.expected_filename):
698         (Port.tests):
699         (Port):
700         (Port._real_tests):
701         (Port._driver_class):
702         (Port.virtual_test_suites):
703         (Port.virtual_suite):
704         (Port.virtual_suite.VirtualTestSuite):
705         (Port.virtual_suite.VirtualTestSuite.__init__):
706         (Port.virtual_suite.VirtualTestSuite.__repr__):
707         (Port.populated_virtual_test_suites):
708         (Port._virtual_tests):
709         (Port.lookup_virtual_test_base):
710         (Port.lookup_virtual_test_args):
711         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
712         (PortTest.test_find_with_skipped_directories):
713         * Scripts/webkitpy/layout_tests/port/driver.py:
714         (DriverInput.__init__):
715         (DriverProxy.run_test):
716         * Scripts/webkitpy/layout_tests/port/test.py:
717         (TestPort.virtual_test_suites):
718         (TestDriver.run_test):
719         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
720         (MainTest.test_all):
721         (MainTest.test_virtual):
722
723 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
724
725         nrwt: support more than two drivers in DriverProxy
726         https://bugs.webkit.org/show_bug.cgi?id=79736
727
728         Reviewed by Adam Barth.
729
730         Now that we can support per-test command lines for
731         Drivers, modify DriverProxy to keep a map of running
732         drivers for each needed command-line; this will allow
733         us to transparently maintain a pool of appropriately
734         configured DRTs without having to constantly start and stop
735         them.
736
737         Note that this potentially raises a garbage collection
738         problem - the number of running DRTs will grow with the
739         number of different sets of command line args. For now
740         this is no worse than the current code - if you're running
741         with pixel tests, you will only need one DRT per worker,
742         and if you aren't, you'll need two (one for text-only tests,
743         and one for reftests).
744
745         An alternative would be to only ever have one running driver,
746         and restart the driver as the command line changes, but this
747         might (?) slow down execution in the text-only case - we
748         should benchmark this because it would be simpler and possibly
749         allow us to eliminate DriverProxy altogether.
750
751         * Scripts/webkitpy/layout_tests/port/driver.py:
752         (DriverProxy.__init__):
753         (DriverProxy):
754         (DriverProxy._make_driver):
755         (DriverProxy.run_test):
756         (DriverProxy.has_crashed):
757         (DriverProxy.stop):
758         (DriverProxy.cmd_line):
759         (DriverProxy._cmd_line_as_key):
760
761 2012-02-29  Adrienne Walker  <enne@google.com>
762
763         Unreviewed, add myself as a reviewer
764
765         * Scripts/webkitpy/common/config/committers.py:
766
767 2012-02-29  Greg Billock  <gbillock@google.com>
768
769         Add more tests for web intents
770         https://bugs.webkit.org/show_bug.cgi?id=79527
771
772         Reviewed by Adam Barth.
773
774         * DumpRenderTree/chromium/LayoutTestController.cpp:
775         (LayoutTestController::LayoutTestController):
776         (LayoutTestController::sendWebIntentResponse):
777         * DumpRenderTree/chromium/LayoutTestController.h:
778         (LayoutTestController):
779         * DumpRenderTree/chromium/WebViewHost.h:
780         (WebViewHost):
781         (WebViewHost::currentIntentRequest):
782
783 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
784
785         nrwt: port/Driver needs to support per-test command line args
786         https://bugs.webkit.org/show_bug.cgi?id=79733
787
788         Reviewed by Adam Barth.
789
790         As part of removing the 'gpu' configurations and adding support
791         for 'virtual test suites', the Driver classes need to support
792         per-test command lines (since different tests will need to be
793         run with different command line options).
794
795         The per-test args are not yet used, so this change should have
796         no visible effects and need no additional testing.
797
798         * Scripts/webkitpy/layout_tests/port/base.py:
799         (Port.driver_cmd_line):
800         * Scripts/webkitpy/layout_tests/port/chromium.py:
801         (ChromiumDriver.cmd_line):
802         (ChromiumDriver._start):
803         (ChromiumDriver.start):
804         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
805         (ChromiumDriverTest.test_two_drivers.MockDriver.cmd_line):
806         (ChromiumDriverTest):
807         (ChromiumDriverTest.test_two_drivers):
808         * Scripts/webkitpy/layout_tests/port/driver.py:
809         (Driver.cmd_line):
810         (DriverProxy.__init__):
811         (DriverProxy.start):
812         (DriverProxy.cmd_line):
813         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
814         (DriverTest.test_virtual_driver_methods):
815         * Scripts/webkitpy/layout_tests/port/gtk.py:
816         (GtkDriver.cmd_line):
817         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
818         * Scripts/webkitpy/layout_tests/port/test.py:
819         (TestPort._path_to_driver):
820         (TestDriver.cmd_line):
821         (TestDriver.start):
822         * Scripts/webkitpy/layout_tests/port/webkit.py:
823         (WebKitDriver.cmd_line):
824         (WebKitDriver._start):
825         (WebKitDriver.run_test):
826         (WebKitDriver.start):
827         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
828         (WebKitDriverTest.test_no_timeout):
829         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
830         (PerfTestsRunner._run_tests_set):
831         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
832         (test_run_test_pause_before_testing):
833
834 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
835
836         perftestsrunner can call printer.write() after printer.cleanup()
837         https://bugs.webkit.org/show_bug.cgi?id=79872
838
839         Reviewed by Ryosuke Niwa.
840
841         This patch fixes a unittest that was incorrectly calling
842         PerfTestsRunner.run() twice (which led to a weird state in the
843         printer object).
844
845         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
846         (MainTest.test_run_with_upload_json):
847
848 2012-02-29  Balazs Kelemen  <kbalazs@webkit.org>
849
850         [Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
851         https://bugs.webkit.org/show_bug.cgi?id=76546
852
853         Reviewed by Simon Hausmann.
854
855         Revert the workaround introduced in r107868 and reintroduce
856         the qml binding so we can test the code path that we are more
857         interested in. The reason that it did not work before is that
858         we don't have an active platform window which we now workaround
859         by propagating the resize through QWindowSystemInterface.
860
861         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
862         (WTR::WrapperWindow::handleStatusChanged):
863         (WTR::PlatformWebView::resizeTo):
864
865 2012-02-29  Gabor Rapcsanyi  <rgabor@webkit.org>
866
867         [GTK] Small fix for cross compilation to not generate gtkdoc.
868
869         Rubber-stamped by Csaba Osztrogonác.
870
871         * Scripts/webkitdirs.pm:
872         (isCrossCompilation):
873
874 2012-02-28  Lucas Forschler  <lforschler@apple.com>
875
876         Fix a typo in config.json
877         linx -> linux
878         
879         * BuildSlaveSupport/build.webkit.org-config/config.json:
880
881 2012-02-28  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
882
883         [Qt] Allow read/write to the WebView.url property
884         https://bugs.webkit.org/show_bug.cgi?id=77554
885
886         Reviewed by Tor Arne Vestbø.
887
888         Fix MiniBrowser to use WebView.url property and remove WebView.load usage.
889
890         * MiniBrowser/qt/qml/BrowserWindow.qml:
891
892 2012-02-28  Dan Winship  <danw@gnome.org>
893
894         [GTK] make tests explicitly request GSettingsBackendMemory
895         https://bugs.webkit.org/show_bug.cgi?id=79788
896
897         Reviewed by Martin Robinson.
898
899         Explicitly request the fallback memory-based GSettings backend; if
900         other backends are available then we don't want to use them,
901         because they would make tests depend on the user's preferences.
902         And if other backends aren't available, we don't need glib to
903         print a warning about that fact.
904
905         * Scripts/webkitpy/layout_tests/port/gtk.py:
906         (GtkPort.setup_environ_for_server):
907
908 2012-02-28  Sheriff Bot  <webkit.review.bot@gmail.com>
909
910         Unreviewed, rolling out r109110.
911         http://trac.webkit.org/changeset/109110
912         https://bugs.webkit.org/show_bug.cgi?id=79806
913
914         webkitpy makes it too easy to add wkb.ug URLs to ChangeLogs
915         (Requested by aroben on #webkit).
916
917         * Scripts/webkitpy/common/checkout/changelog.py:
918         (parse_bug_id):
919         (parse_bug_id_from_changelog):
920         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
921         * Scripts/webkitpy/common/config/urls.py:
922
923 2012-02-28  Adam Roben  <aroben@webkit.org>
924
925         Add my new email address
926
927         Fixes <http://wkb.ug/79797> Adam Roben's email address in webkitpy is soon to be incorrect
928
929         Reviewed by Anders Carlsson.
930
931         * Scripts/webkitpy/common/config/committers.py:
932
933 2012-02-28  Adam Roben  <aroben@apple.com>
934
935         Teach webkitpy about wkb.ug URLs
936
937         Fixes <http://wkb.ug/79799> webkit-patch can't find bug numbers from ChangeLog entries that
938         use wkb.ug URLs
939
940         Reviewed by Anders Carlsson.
941
942         * Scripts/webkitpy/common/checkout/changelog.py:
943         (parse_bug_id):
944         (parse_bug_id_from_changelog):
945         Fall back to the tiny URL format if neither the short nor long URL formats work.
946
947         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
948         (ChangeLogTest.test_parse_bug_id_from_changelog): Added tests for the above changes.
949
950         * Scripts/webkitpy/common/config/urls.py: Added bug_url_tiny, which can be used to match
951         wkb.ug URLs.
952
953 2012-02-28  János Badics  <dicska@gmail.com>
954
955         [Qt] build-webkit does not detect the number of CPUs
956         https://bugs.webkit.org/show_bug.cgi?id=76445
957
958         Based on Seo Sanghyeon's work (modification:
959         Automatically determine the number of CPUs for make
960         only if -j make argument haven't already been specified.)
961
962         Reviewed by Csaba Osztrogonác.
963
964         * Scripts/webkitdirs.pm:
965         (buildQMakeProjects):
966
967 2012-02-28  Kent Tamura  <tkent@chromium.org>
968
969         Update a pattern for forms files of watchlist
970         https://bugs.webkit.org/show_bug.cgi?id=79767
971
972         Reviewed by Kentaro Hara.
973
974         * Scripts/webkitpy/common/config/watchlist:
975         Catches the following files with the "Forms" pattern.
976         - HTMLDatListElement.*
977         - HTMLKeygenElement.*
978         - HTMLLegendElement.*
979         - HTMLOutputElement.*
980         - FormAssociatedElement.*
981         - SliderThumbElement.*
982         - TextControlInnerElements.*
983         - RenderFileUploadControl.*
984
985 2012-02-27  Sheriff Bot  <webkit.review.bot@gmail.com>
986
987         Unreviewed, rolling out r109041.
988         http://trac.webkit.org/changeset/109041
989         https://bugs.webkit.org/show_bug.cgi?id=79741
990
991         Broke Chromium Win build (Requested by bashi on #webkit).
992
993         * DumpRenderTree/chromium/LayoutTestController.cpp:
994         (LayoutTestController::LayoutTestController):
995         * DumpRenderTree/chromium/LayoutTestController.h:
996         (LayoutTestController):
997         * DumpRenderTree/chromium/WebViewHost.h:
998
999 2012-02-27  James Robinson  <jamesr@chromium.org>
1000
1001         [chromium] Remove media tests from ChromiumGpu configurations
1002         https://bugs.webkit.org/show_bug.cgi?id=79720
1003
1004         Reviewed by Adam Barth.
1005
1006         We no longer need to run the media/ tests in both GPU and non-GPU configurations since we can exercise the GPU
1007         composited playback path via tests in the compositing/ directory.
1008
1009         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1010         (_default_tests_paths):
1011         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1012         (ChromiumGpuTest.test_default_tests_paths):
1013         (ChromiumGpuTest.test_test_files):
1014
1015 2012-02-27  Dirk Pranke  <dpranke@chromium.org>
1016
1017         nrwt: log multiline stderr/crash output properly
1018         https://bugs.webkit.org/show_bug.cgi?id=79722
1019
1020         Reviewed by Adam Barth.
1021
1022         This cleans up some nits in the log output to make things
1023         slightly easier to read (every line gets timestamped, etc.).
1024
1025         Also tweaks the log message for pixel hash mismatches.
1026
1027         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1028         (SingleTestRunner._handle_error):
1029         (SingleTestRunner._compare_image):
1030
1031 2012-02-27  Ryosuke Niwa  <rniwa@webkit.org>
1032
1033         Touch the master.cfg to force a reconfig.
1034
1035         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1036         (BuildAndTestLeaksFactory):
1037         (NewBuildAndTestFactory):
1038
1039 2012-02-27  Jacky Jiang  <zhajiang@rim.com>
1040
1041         [BlackBerry] Upstream BlackBerry API web page related files
1042         https://bugs.webkit.org/show_bug.cgi?id=74380
1043
1044         Reviewed by Antonio Gomes.
1045
1046         Adapt to the removing of WebPage::mainFrame(), use
1047         DumpRenderTreeSupport::corePage() and its mainFrame() instead.
1048
1049         No new tests as this patch doesn't change behavior.
1050
1051         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1052         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
1053         (BlackBerry::WebKit::DumpRenderTree::runTests):
1054
1055 2012-02-27  Ryosuke Niwa  <rniwa@webkit.org>
1056
1057         Add Windows and Linux Chromium perf bots
1058         https://bugs.webkit.org/show_bug.cgi?id=79418
1059
1060         Reviewed by Tony Chang.
1061
1062         Add Chromium Win and Linux perf bots. Also replace Chromium Mac by
1063         the dedicated perf bot slave (uses the same hardware).
1064
1065         * BuildSlaveSupport/build.webkit.org-config/config.json:
1066
1067 2012-02-27  Xianzhu Wang  <wangxianzhu@chromium.org>
1068
1069         Undefined variable 'current' when running chromium_android.py
1070         https://bugs.webkit.org/show_bug.cgi?id=79696
1071
1072         Reviewed by Adam Barth.
1073
1074         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1075         (ChromiumAndroidDriver._read_prompt):
1076
1077 2012-02-27  Greg Billock  <gbillock@google.com>
1078
1079         Add more tests for web intents
1080         https://bugs.webkit.org/show_bug.cgi?id=79527
1081
1082         Reviewed by Adam Barth.
1083
1084         * DumpRenderTree/chromium/LayoutTestController.cpp:
1085         (LayoutTestController::LayoutTestController):
1086         (LayoutTestController::sendWebIntentResponse):
1087         * DumpRenderTree/chromium/LayoutTestController.h:
1088         (LayoutTestController):
1089         * DumpRenderTree/chromium/WebViewHost.h:
1090         (WebViewHost):
1091         (WebViewHost::currentIntentRequest):
1092
1093 2012-02-27  Xianzhu Wang  <wangxianzhu@chromium.org>
1094
1095         Chromium-Android layout test script: the adb shell prompt is not always '# '
1096         https://bugs.webkit.org/show_bug.cgi?id=79506
1097
1098         Reviewed by Adam Barth.
1099
1100         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1101         (ChromiumAndroidDriver._start):
1102         (ChromiumAndroidDriver._read_prompt):
1103
1104 2012-02-27  Dan Bernstein  <mitz@apple.com>
1105
1106         Added a test for <rdar://problem/9557598> REGRESSION (WebKit2): Non-activating links sometimes don’t work
1107         https://bugs.webkit.org/show_bug.cgi?id=79607
1108
1109         Reviewed by Adele Peterson.
1110
1111         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
1112         * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm: Added.
1113         (TestWebKitAPI::AcceptsFirstMouse::url):
1114         (TestWebKitAPI::AcceptsFirstMouse::didLoadURL):
1115         (TestWebKitAPI::AcceptsFirstMouse::runTest):
1116         (TestWebKitAPI::TEST_F):
1117         * TestWebKitAPI/Tests/mac/acceptsFirstMouse.html: Added.
1118
1119 2012-02-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1120
1121         Unreviewed. Fix make distcheck.
1122
1123         * GNUmakefile.am: Fix typo.
1124
1125 2012-02-27  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1126
1127         [Qt] Use USE() macro instead of ENABLE() for using the Qt image decoder
1128
1129         Reviewed by Kenneth Rohde Christiansen..
1130
1131         * qmake/mkspecs/features/features.prf:
1132
1133 2012-02-27  Hao Zheng  <zhenghao@chromium.org>
1134
1135         Add a ChromiumGpuAndroid port.
1136         https://bugs.webkit.org/show_bug.cgi?id=79628
1137
1138         Reviewed by Adam Barth.
1139
1140         Android does have a gpu port, so revert r107697.
1141
1142         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1143         (ChromiumAndroidPort.__init__):
1144         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1145         (ChromiumGpuAndroidPort):
1146         (ChromiumGpuAndroidPort.__init__):
1147         (ChromiumGpuAndroidPort.baseline_search_path):
1148         (ChromiumGpuAndroidPort.default_child_processes):
1149         (ChromiumGpuAndroidPort.tests):
1150         * Scripts/webkitpy/layout_tests/port/factory.py:
1151         (PortFactory):
1152
1153 2012-02-25  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1154
1155         Change Build bot with BuildAndTest bot for EFL port.
1156         https://bugs.webkit.org/show_bug.cgi?id=77518
1157
1158         Reviewed by Ryosuke Niwa.
1159
1160         EFL build bot starts to support layout test.
1161
1162         * BuildSlaveSupport/build.webkit.org-config/config.json:
1163         * BuildSlaveSupport/built-product-archive:
1164         (archiveBuiltProduct):
1165         (extractBuiltProduct):
1166         * BuildSlaveSupport/test-result-archive:
1167         (archiveTestResults):
1168         * Scripts/webkitdirs.pm: Enable SHARED_CORE option when ENABLE_DRT is enable in EFL port.
1169         (generateBuildSystemFromCMakeProject):
1170
1171 2012-02-24  Darin Fisher  <darin@chromium.org>
1172
1173         Add watchlist for ChromiumPlatformApi matching Source/Platform/chromium/public/
1174
1175         Reviewed by James Robinson.
1176
1177         * Scripts/webkitpy/common/config/watchlist:
1178
1179 2012-02-24  Dirk Pranke  <dpranke@chromium.org>
1180
1181         webkitpy: changelog_unittest test_fuzzy_reviewer_match is slow
1182         https://bugs.webkit.org/show_bug.cgi?id=79258
1183
1184         Reviewed by Ryosuke Niwa.
1185
1186         Split the fuzzy matching into separate functions so that they
1187         can be sharded and run in parallel.
1188
1189         Also, fix a bug in the svn_blame_regexp that was causing us
1190         to require ChangeLog lines to have at least one space after the
1191         author, making the code require trailing whitespace in the
1192         changelog in some places (this was making my life harder because
1193         I have my text editor set to strip trailing whitespace in python
1194         files, and that was causing test_parse_log_entries_from_changelog() to fail
1195         when the whitespace on line 275 was removed).
1196
1197         * Scripts/webkitpy/common/checkout/changelog.py:
1198         (ChangeLog):
1199         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1200         (test_fuzzy_reviewer_match__none):
1201         (test_fuzzy_reviewer_match_adam_barth):
1202         (test_fuzzy_reviewer_match_darin_adler_et_al):
1203         (test_fuzzy_reviewer_match_dimitri_glazkov):
1204         (test_fuzzy_reviewer_match_george_staikos):
1205         (test_fuzzy_reviewer_match_mark_rowe):
1206
1207 2012-02-24  Dirk Pranke  <dpranke@chromium.org>
1208
1209         webkitpy: committers_unittest fuzzy matching is really slow
1210         https://bugs.webkit.org/show_bug.cgi?id=79179
1211
1212         Reviewed by Ryosuke Niwa.
1213
1214         Break the fuzzy matching tests into individual routines for
1215         each contributor so that the intent is a little clearer, so
1216         that it's easier to test individual names (and identify
1217         duplicate tests), and so that we can eventually run
1218         them in parallel.
1219
1220         Also, mark most of them as 'integration' tests so that they
1221         can be skipped if we want to go fast (we leave a few as
1222         regular tests for functional coverage).
1223
1224         * Scripts/webkitpy/common/config/committers_unittest.py:
1225         (CommittersTest):
1226         (CommittersTest.test_contributors_by_fuzzy_match):
1227         (CommittersTest.integration_test_contributors__none):
1228         (CommittersTest.integration_test_contributors__none_2):
1229         (CommittersTest.integration_test_contributors__none_3):
1230         (CommittersTest.integration_test_contributors_ada_chan):
1231         (CommittersTest.integration_test_contributors_adele_peterson):
1232         (CommittersTest.integration_test_contributors_alexey_proskuryakov):
1233         (CommittersTest.integration_test_contributors_alice_liu):
1234         (CommittersTest.integration_test_contributors_alp_toker):
1235         (CommittersTest.integration_test_contributors_anders_carlsson):
1236         (CommittersTest.integration_test_contributors_antti_koivisto):
1237         (CommittersTest.integration_test_contributors_beth_dakin):
1238         (CommittersTest.integration_test_contributors_brady_eidson):
1239         (CommittersTest.integration_test_contributors_cameron_zwarich):
1240         (CommittersTest.integration_test_contributors_chris_blumenberg):
1241         (CommittersTest.integration_test_contributors_dan_bernstein):
1242         (CommittersTest.integration_test_contributors_dan_bernstein_2):
1243         (CommittersTest.integration_test_contributors_darin_adler):
1244         (CommittersTest.integration_test_contributors_david_harrison):
1245         (CommittersTest.integration_test_contributors_david_harrison_2):
1246         (CommittersTest.integration_test_contributors_david_hyatt):
1247         (CommittersTest.integration_test_contributors_david_kilzer):
1248         (CommittersTest.integration_test_contributors_don_melton):
1249         (CommittersTest.integration_test_contributors_eric_seidel):
1250         (CommittersTest.integration_test_contributors_geoffrey_garen):
1251         (CommittersTest.integration_test_contributors_greg_bolsinga):
1252         (CommittersTest.integration_test_contributors_holger_freyther):
1253         (CommittersTest.integration_test_contributors_jon_sullivan):
1254         (CommittersTest.integration_test_contributors_jon_honeycutt):
1255         (CommittersTest.integration_test_contributors_joseph_pecoraro):
1256         (CommittersTest.integration_test_contributors_ken_kocienda):
1257         (CommittersTest.integration_test_contributors_kenneth_russell):
1258         (CommittersTest.integration_test_contributors_kevin_decker):
1259         (CommittersTest.integration_test_contributors_kevin_mccullough):
1260         (CommittersTest.integration_test_contributors_lars_knoll):
1261         (CommittersTest.integration_test_contributors_lars_weintraub):
1262         (CommittersTest.integration_test_contributors_maciej_stachowiak):
1263         (CommittersTest.integration_test_contributors_mark_rowe):
1264         (CommittersTest.integration_test_contributors_nikolas_zimmermann):
1265         (CommittersTest.integration_test_contributors_oliver_hunt):
1266         (CommittersTest.integration_test_contributors_rniwa):
1267         (CommittersTest.disabled_integration_test_contributors_simon_fraser):
1268         (CommittersTest.integration_test_contributors_steve_falkenburg):
1269         (CommittersTest.integration_test_contributors_sam_weinig):
1270         (CommittersTest.integration_test_contributors_tim_omernick):
1271         (CommittersTest.integration_test_contributors_timothy_hatcher):
1272         (CommittersTest.integration_test_contributors_tor_arne_vestbo):
1273         (CommittersTest.integration_test_contributors_vicki_murley):
1274         (CommittersTest.integration_test_contributors_zack_rusin):
1275
1276 2012-02-24  Dirk Pranke  <dpranke@chromium.org>
1277
1278         webkitpy: should autoinstall coverage
1279         https://bugs.webkit.org/show_bug.cgi?id=79535
1280
1281         Reviewed by Eric Seidel.
1282
1283         We should automatically print the coverage report after the run, too.
1284
1285         * Scripts/webkitpy/test/main.py:
1286         (Tester._run_tests):
1287         * Scripts/webkitpy/thirdparty/__init__.py:
1288         (AutoinstallImportHook.find_module):
1289         (AutoinstallImportHook._install_coverage):
1290
1291 2012-02-24  Pablo Flouret  <pablof@motorola.com>
1292
1293         Fix copypasta in build-webkit's --vibration option description
1294         https://bugs.webkit.org/show_bug.cgi?id=79528
1295
1296         Reviewed by Andreas Kling.
1297
1298         * Scripts/build-webkit:
1299
1300 2012-02-24  Antonio Gomes  <agomes@rim.com>
1301
1302         Adding myself to ScrollingCoordinator watchlist
1303         https://bugs.webkit.org/show_bug.cgi?id=79525
1304
1305         Reviewed by Rob Buis.
1306
1307         * Scripts/webkitpy/common/config/watchlist:
1308
1309 2012-02-24  Darin Fisher  <darin@chromium.org>
1310
1311         Update watchlist for ChromiumPublicApi to include Platform/chromium/public/
1312
1313         Reviewed by Adam Barth.
1314
1315         * Scripts/webkitpy/common/config/watchlist:
1316
1317 2012-02-24  Dirk Pranke  <dpranke@chromium.org>
1318
1319         webkitpy: config_unittest is sensitive to other tests that might've already run
1320         https://bugs.webkit.org/show_bug.cgi?id=79382
1321
1322         Reviewed by Adam Barth.
1323
1324         If another test runs prior to config_unittest and pokes the
1325         cached configuration, the first test in config_unittest might
1326         fail; the tearDown() will then allow subsequent tests to pass.
1327         Clearing the configuration prior to each test makes things
1328         slightly slower but safer.
1329
1330         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
1331         (ConfigTest.setUp):
1332
1333 2012-02-24  David Kilzer  <ddkilzer@apple.com>
1334
1335         Use xcrun to find compiler paths for Generate Derived Sources build phase script
1336         <http://webkit.org/b/79512>
1337
1338         Reviewed by Dan Bernstein.
1339
1340         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1341         (Generate Derived Sources): Use xcrun to find the path to the
1342         compiler since that works on both iOS and OS X.
1343
1344 2012-02-24  James Robinson  <jamesr@chromium.org>
1345
1346         Create a watchlist for ScrollingCoordinator changes
1347         https://bugs.webkit.org/show_bug.cgi?id=79511
1348
1349         Reviewed by Anders Carlsson.
1350
1351         * Scripts/webkitpy/common/config/watchlist:
1352
1353 2012-02-24  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
1354
1355         [EFL][DRT] Implement setValueForUser and setAutofilled.
1356         https://bugs.webkit.org/show_bug.cgi?id=79237
1357
1358         Reviewed by Andreas Kling.
1359
1360         Adds missing implementation setValueForUser and setAutofilled to EFL's LayoutTestController.
1361         Those implementations are related with input fields and allow to pass following tests:
1362         fast/forms/onchange-setvalueforuser.html
1363         fast/forms/input-autofilled.html
1364         fast/forms/reset-autofilled.html
1365
1366         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1367         (LayoutTestController::setValueForUser):
1368         (LayoutTestController::setAutofilled):
1369
1370 2012-02-24  Zoltan Horvath  <zoltan@webkit.org>
1371
1372         [Qt] Allow to use WebCore imagedecoders
1373         https://bugs.webkit.org/show_bug.cgi?id=32410
1374
1375         Add ENABLE_QT_IMAGE_DECODER macro, it's enabled by default.
1376
1377         Reviewed by Simon Hausmann.
1378
1379         * qmake/mkspecs/features/features.prf:
1380
1381 2012-02-24  Balazs Kelemen  <kbalazs@webkit.org>
1382
1383         [Qt] Add Qt5 way to force 96 DPI for tests
1384         https://bugs.webkit.org/show_bug.cgi?id=79364
1385
1386         Reviewed by Simon Hausmann.
1387
1388         * DumpRenderTree/qt/main.cpp:
1389         (main):
1390         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1391         (WTR::activateFonts):
1392
1393 2012-02-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1394
1395         [GTK] MiniBrowser should reload the view then the reload button is clicked
1396         https://bugs.webkit.org/show_bug.cgi?id=79472
1397
1398         Reviewed by Philippe Normand.
1399
1400         * MiniBrowser/gtk/BrowserWindow.c:
1401         (reloadCallback): Call webkit_web_view_reload().
1402         (browser_window_init): Connect reload item clicked even to
1403         reloadCallback instead of activateUriEntryCallback.
1404
1405 2012-02-24  Kentaro Hara  <haraken@chromium.org>
1406
1407         Add performance tests for DOM attribute getters and setters
1408         https://bugs.webkit.org/show_bug.cgi?id=79208
1409
1410         Reviewed by Ryosuke Niwa.
1411
1412         We want to allow perf tests to output info messages
1413         that do not affect the test results. To accomplish this,
1414         this patch modifies perftestsrunner.py so that it ignores
1415         a line that starts from "Info:".
1416
1417         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1418         (PerfTestsRunner):
1419
1420 2012-02-24  Andrew Lo  <anlo@rim.com>
1421
1422         [BlackBerry] Enable requestAnimationFrame
1423         https://bugs.webkit.org/show_bug.cgi?id=79408
1424
1425         Enable requestAnimationFrame for BlackBerry.
1426
1427         Reviewed by Rob Buis.
1428
1429         * Scripts/build-webkit:
1430
1431 2012-02-24  Adam Barth  <abarth@webkit.org>
1432
1433         style-queue tries to apply the patch twice
1434         https://bugs.webkit.org/show_bug.cgi?id=79459
1435
1436         Reviewed by Eric Seidel.
1437
1438         Previously, we applied the patch using both apply-patch and
1439         check-style.  This patch introduces a check-style-local to mirror the
1440         apply-watchlist-local, which operates on the current working diff.
1441
1442         This patch also cleans up some other bugs I found by running the queue
1443         locally for a while.  The queue still prints out a slightly
1444         less-than-ideal message on the bugs when it find an error, but it's ok
1445         for now.  We'll need to iterate a bit.
1446
1447         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
1448         (StyleQueueTask.validate):
1449         (StyleQueueTask._check_style):
1450         * Scripts/webkitpy/tool/commands/download.py:
1451         (CheckStyleLocal):
1452         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1453         (EarlyWarningSytemTest._default_expected_stderr):
1454         (EarlyWarningSytemTest._test_testing_ews):
1455         * Scripts/webkitpy/tool/commands/queues.py:
1456         (AbstractReviewQueue.handle_script_error):
1457         (StyleQueue.review_patch):
1458         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1459         * Scripts/webkitpy/tool/commands/queuestest.py:
1460         (QueuesTest.assert_queue_outputs):
1461
1462 2012-02-23  Adam Barth  <abarth@webkit.org>
1463
1464         should_proceed_with_work_item is unused and can be removed
1465         https://bugs.webkit.org/show_bug.cgi?id=79416
1466
1467         Reviewed by Eric Seidel.
1468
1469         We used to use this function to check whether the tree is red.  Now, we
1470         don't use external measures of whether to proceed with work items.
1471         Instead, we analyze them with the idea in mind that the tree might be
1472         red.
1473
1474         * Scripts/webkitpy/tool/bot/queueengine.py:
1475         (QueueEngineDelegate.next_work_item):
1476         (QueueEngine.run):
1477         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1478         (LoggingDelegate):
1479         (LoggingDelegate.next_work_item):
1480         (RaisingDelegate.process_work_item):
1481         (QueueEngineTest.test_terminating_error):
1482         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1483         (AbstractEarlyWarningSystem.__init__):
1484         * Scripts/webkitpy/tool/commands/queues.py:
1485         (AbstractQueue.next_work_item):
1486         (FeederQueue.next_work_item):
1487         (CommitQueue.next_work_item):
1488         (AbstractReviewQueue.next_work_item):
1489         (StyleQueue.__init__):
1490         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1491         (FeederQueueTest.test_feeder_queue):
1492         (CommitQueueTest.test_commit_queue):
1493         (test_commit_queue_failure):
1494         (test_commit_queue_failure_with_failing_tests):
1495         (test_rollout):
1496         (test_rollout_lands):
1497         (StyleQueueTest.test_style_queue_with_style_exception):
1498         (test_style_queue_with_watch_list_exception):
1499         * Scripts/webkitpy/tool/commands/queuestest.py:
1500         (QueuesTest.assert_queue_outputs):
1501         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1502         (SheriffBot.next_work_item):
1503
1504 2012-02-23  Adrienne Walker  <enne@google.com>
1505
1506         Unreviewed, add Stephen Chenney to committers.py as a contributor.
1507
1508         * Scripts/webkitpy/common/config/committers.py:
1509
1510 2012-02-23  Adam Barth  <abarth@webkit.org>
1511
1512         style-queue logs bogus messages to the QueueStatusServer
1513         https://bugs.webkit.org/show_bug.cgi?id=79424
1514
1515         Reviewed by Eric Seidel.
1516
1517         Copy/paste error.
1518
1519         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
1520         (StyleQueueTask._check_style):
1521         (StyleQueueTask._apply_watch_list):
1522         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1523
1524 2012-02-23  Eric Seidel  <eric@webkit.org>
1525
1526         Use self._filesystem in more places in the SCM classes
1527         https://bugs.webkit.org/show_bug.cgi?id=79415
1528
1529         Reviewed by Adam Barth.
1530
1531         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
1532         (SCMDetectorTest.test_detect_scm_system):
1533         * Scripts/webkitpy/common/checkout/scm/git.py:
1534         (Git.find_checkout_root):
1535         (Git.to_object_name):
1536         * Scripts/webkitpy/common/checkout/scm/scm.py:
1537         (SCM.__init__):
1538         (SCM.in_working_directory):
1539         * Scripts/webkitpy/common/checkout/scm/svn.py:
1540         (SVN.find_uuid):
1541         (SVN.find_checkout_root):
1542
1543 2012-02-23  Sheriff Bot  <webkit.review.bot@gmail.com>
1544
1545         Unreviewed, rolling out r108685.
1546         http://trac.webkit.org/changeset/108685
1547         https://bugs.webkit.org/show_bug.cgi?id=79414
1548
1549         Broke Chromium builds (Requested by enne on #webkit).
1550
1551         * qmake/mkspecs/features/features.prf:
1552
1553 2012-02-23  Adam Barth  <abarth@webkit.org>
1554
1555         style-queue shouldn't spam bugs if it fails to update its working copy
1556         https://bugs.webkit.org/show_bug.cgi?id=79412
1557
1558         Reviewed by Eric Seidel.
1559
1560         This patch moves style-queue over to the new PatchAnalysisTask
1561         infrastructure, which is smarter about retrying patches when update
1562         fails.
1563
1564         * Scripts/webkitpy/common/system/executive_mock.py:
1565         (MockExecutive.run_and_throw_if_fail):
1566         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
1567         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1568         (UnableToApplyPatch):
1569         (UnableToApplyPatch.__init__):
1570         (PatchAnalysisTask.__init__):
1571         * Scripts/webkitpy/tool/bot/stylequeuetask.py: Added.
1572         (StyleQueueTaskDelegate):
1573         (StyleQueueTaskDelegate.parent_command):
1574         (StyleQueueTask):
1575         (StyleQueueTask.validate):
1576         (StyleQueueTask._check_style):
1577         (StyleQueueTask._apply_watch_list):
1578         (StyleQueueTask.run):
1579         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1580         * Scripts/webkitpy/tool/commands/queues.py:
1581         (StyleQueue):
1582         (StyleQueue.should_proceed_with_work_item):
1583         (StyleQueue.review_patch):
1584         (StyleQueue.run_command):
1585         (StyleQueue.command_passed):
1586         (StyleQueue.command_failed):
1587         (StyleQueue.expected_failures):
1588         (StyleQueue.refetch_patch):
1589         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1590         (StyleQueueTest.test_style_queue_with_style_exception):
1591         (test_style_queue_with_watch_list_exception):
1592
1593 2012-02-23  Zoltan Horvath  <zoltan@webkit.org>
1594
1595         [Qt] Allow to use WebCore imagedecoders
1596         https://bugs.webkit.org/show_bug.cgi?id=32410
1597
1598         Add ENABLE_QT_IMAGE_DECODER macro, it's enabled by default.
1599
1600         Reviewed by Simon Hausmann.
1601
1602         * qmake/mkspecs/features/features.prf:
1603
1604 2012-02-23  Eric Seidel  <eric@webkit.org>
1605
1606         Remove old broken find_checkout_root tests now that find_checkout_root is gone
1607         https://bugs.webkit.org/show_bug.cgi?id=79405
1608
1609         Reviewed by Adam Barth.
1610
1611         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py: Added.
1612         (SCMDetectorTest):
1613         (SCMDetectorTest.test_find_checkout_root):
1614         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1615         (SVNTestRepository.tear_down):
1616
1617 2012-02-23  Michael Brüning  <michael.bruning@nokia.com>
1618
1619         [Qt][WK2] Implement proxy authentication dialog.
1620         https://bugs.webkit.org/show_bug.cgi?id=79350
1621
1622         Reviewed by Simon Hausmann.
1623
1624         * MiniBrowser/qt/MiniBrowser.qrc:
1625         * MiniBrowser/qt/qml/BrowserWindow.qml:
1626         * MiniBrowser/qt/qml/ProxyAuthenticationDialog.qml: Added.
1627
1628 2012-02-23  Kevin Ollivier  <kevino@theolliviers.com>
1629
1630         [wx] Build fix, add recently added source dirs.
1631
1632         * waf/build/settings.py:
1633
1634 2012-02-23  Simon Hausmann  <simon.hausmann@nokia.com>
1635
1636         [Qt] Add support for touch cancellation
1637         https://bugs.webkit.org/show_bug.cgi?id=79348
1638
1639         Reviewed by Kenneth Rohde Christiansen.
1640
1641         Added straight-forward touch cancellation event sending to Qt WK1 DRT
1642         and WK2 WTR.
1643
1644         * DumpRenderTree/qt/EventSenderQt.cpp:
1645         (EventSender::touchCancel):
1646         (EventSender::cancelTouchPoint):
1647         * DumpRenderTree/qt/EventSenderQt.h:
1648         (EventSender):
1649         * WebKitTestRunner/EventSenderProxy.h:
1650         (EventSenderProxy):
1651         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1652         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1653         (WTR::EventSendingController::touchCancel):
1654         (WTR):
1655         (WTR::EventSendingController::cancelTouchPoint):
1656         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1657         (EventSendingController):
1658         * WebKitTestRunner/TestController.cpp:
1659         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1660         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
1661         (WTR::EventSenderProxy::touchCancel):
1662         (WTR):
1663         (WTR::EventSenderProxy::cancelTouchPoint):
1664
1665 2012-02-23  Sheriff Bot  <webkit.review.bot@gmail.com>
1666
1667         Unreviewed, rolling out r108626.
1668         http://trac.webkit.org/changeset/108626
1669         https://bugs.webkit.org/show_bug.cgi?id=79370
1670
1671         broke qt-wk2 bot, somehow the workaround does not work on the
1672         bot (Requested by Ossy on #webkit).
1673
1674         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1675         (WTR::WrapperWindow::handleStatusChanged):
1676         (WTR::PlatformWebView::resizeTo):
1677
1678 2012-02-23  ChangSeok Oh  <shivamidow@gmail.com>
1679
1680         [GTK] DRT doesn't support scheduleAsynchronousKeyDown.
1681         https://bugs.webkit.org/show_bug.cgi?id=78481
1682
1683         Reviewed by Gustavo Noronha Silva.
1684
1685         Extracted shareable code from keyDownCallback and then added createKeyPressEvent
1686         to create gdk press key event.
1687         Added sendKeyDown and sendAsynchronousKeyDown to evaluate keyDown event directly
1688         and asynchronously. Eventually, sendAsynchronousKeyDown calls sendKeyDown.
1689
1690         * DumpRenderTree/gtk/EventSender.cpp:
1691         (scheduleAsynchronousClickCallback):
1692         (createKeyPressEvent):
1693         (sendKeyDown):
1694         (keyDownCallback):
1695         (sendAsynchronousKeyDown):
1696         (scheduleAsynchronousKeyDownCallback):
1697
1698 2012-02-23  Balazs Kelemen  <kbalazs@webkit.org>
1699
1700         [Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
1701         https://bugs.webkit.org/show_bug.cgi?id=76546
1702
1703         Reviewed by Simon Hausmann.
1704
1705         Co-authored with Simon Hausmann.
1706
1707         Revert the workaround introduced in r107868 and reintroduce
1708         the qml binding so we can test the code path that we are more
1709         interested in. The reason that it did not work before is that
1710         we don't have an active platform window which we now workaround
1711         by propagating the resize through QWindowSystemInterface.
1712
1713         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1714         (WTR::WrapperWindow::handleStatusChanged):
1715         (WTR::PlatformWebView::resizeTo):
1716
1717 2012-02-23  Sheriff Bot  <webkit.review.bot@gmail.com>
1718
1719         Unreviewed, rolling out r108577.
1720         http://trac.webkit.org/changeset/108577
1721         https://bugs.webkit.org/show_bug.cgi?id=79359
1722
1723         It doesn't work as expected (Requested by Ossy on #webkit).
1724
1725         * DumpRenderTree/qt/EventSenderQt.cpp:
1726         (EventSender::postEvent):
1727         * DumpRenderTree/qt/EventSenderQt.h:
1728         (EventSender):
1729
1730 2012-02-23  Philippe Normand  <pnormand@igalia.com>
1731
1732         [GTK] FullScreen signals
1733         https://bugs.webkit.org/show_bug.cgi?id=76181
1734
1735         Reviewed by Martin Robinson.
1736
1737         Use the two new entering/leaving fullscreen signals to hide/show
1738         the tool bar, the status bar and ask the user's permission before
1739         entering fullscreen.
1740
1741         * GtkLauncher/main.c:
1742         (webViewFullscreenMessageWindowClose):
1743         (webViewWindowStateEvent):
1744         (hide_widget):
1745         (show_widget):
1746         (webViewEnteringFullScreen):
1747         (webViewLeavingFullScreen):
1748         (createBrowser):
1749         (createWindow):
1750
1751 2012-02-22  Dongwoo Im  <dw.im@samsung.com>
1752
1753         [EFL] Fix to launch the EWebLauncher using the script, run-launcher.
1754         https://bugs.webkit.org/show_bug.cgi?id=79076
1755
1756         Reviewed by Andreas Kling.
1757
1758         * Scripts/webkitdirs.pm: Fix the path of libewebkit.so.
1759         (builtDylibPathForName):
1760
1761 2012-02-22  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
1762
1763         [Qt] Add eventSender.gestureTap
1764         https://bugs.webkit.org/show_bug.cgi?id=66173
1765
1766         Reviewed by Kenneth Rohde Christiansen.
1767
1768         * DumpRenderTree/qt/EventSenderQt.cpp:
1769         (EventSender::gestureTap):
1770         * DumpRenderTree/qt/EventSenderQt.h:
1771
1772 2012-02-22  Brady Eidson  <beidson@apple.com>
1773
1774         <rdar://problem/10406044> and https://bugs.webkit.org/show_bug.cgi?id=79279
1775         Synchronous ShouldGoToBackForwardListItem causes lots of WebProcess hangs
1776
1777         Reviewed by Anders Carlsson.
1778
1779         Update our tools to the new form of the PageLoadClient.
1780
1781         * MiniBrowser/mac/BrowserWindowController.m:
1782         (-[BrowserWindowController awakeFromNib]): 
1783
1784         * WebKitTestRunner/TestController.cpp:
1785         (WTR::TestController::initialize):
1786
1787 2012-02-22  Daniel Bates  <dbates@webkit.org>
1788
1789         new-run-webkit-tests shouldn't restore Safari state on Lion when showing results
1790         https://bugs.webkit.org/show_bug.cgi?id=79277
1791
1792         Reviewed by Adam Barth.
1793
1794         Pass command line argument no-saved-state to run-safari to disable Safari
1795         state restoration for the session on OS 10.7.
1796
1797         * Scripts/webkitpy/layout_tests/port/mac.py:
1798         (MacPort.show_results_html_file):
1799         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1800         (test_show_results_html_file):
1801
1802 2012-02-22  Kalev Lember  <kalevlember@gmail.com>
1803
1804         Explicitly include unistd.h in TestNetscapePlugIn for GCC 4.7
1805         https://bugs.webkit.org/show_bug.cgi?id=77759
1806
1807         Reviewed by Tony Chang.
1808
1809         Fixes build with gcc 4.7.
1810
1811         r100432 added the include only for ANDROID; this changes the ifdef to
1812         also cover other unix platforms. On Fedora 17 the gcc 4.7 compiler no
1813         longer implicitly includes unistd.h from standard headers and other
1814         unix platforms are likely to get gcc 4.7 as well in the future.
1815
1816         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1817
1818 2012-02-22  Philippe Normand  <pnormand@igalia.com>
1819
1820         Unreviewed, rolling out r108522.
1821         http://trac.webkit.org/changeset/108522
1822         https://bugs.webkit.org/show_bug.cgi?id=76181
1823
1824         Broke 4 fullscreen tests on GTK.
1825
1826         * GtkLauncher/main.c:
1827         (createBrowser):
1828         (createWindow):
1829
1830 2012-02-20  Philippe Normand  <pnormand@igalia.com>
1831
1832         [GTK] FullScreen signals
1833         https://bugs.webkit.org/show_bug.cgi?id=76181
1834
1835         Reviewed by Martin Robinson.
1836
1837         Use the two new entering/leaving fullscreen signals to hide/show
1838         the tool bar, the status bar and ask the user's permission before
1839         entering fullscreen.
1840
1841         * GtkLauncher/main.c:
1842         (webViewFullscreenMessageWindowClose):
1843         (webViewWindowStateEvent):
1844         (hide_widget):
1845         (show_widget):
1846         (webViewEnteringFullScreen):
1847         (webViewLeavingFullScreen):
1848         (createBrowser):
1849         (createWindow):
1850
1851 2012-02-22  Rob Flack  <flackr@chromium.org>
1852
1853         Update Linux ChromiumOS builders in flakiness dashboard.
1854         https://bugs.webkit.org/show_bug.cgi?id=79238
1855
1856         Reviewed by Ojan Vafai.
1857
1858         * TestResultServer/static-dashboards/builders.js:
1859
1860 2012-02-22  Dirk Pranke  <dpranke@chromium.org>
1861
1862         webkitpy: test_function_length_check_definition_huge_lines is slow
1863         https://bugs.webkit.org/show_bug.cgi?id=79185
1864
1865         Reviewed by Adam Barth.
1866
1867         This test takes ~3 seconds to run, apparently because we're
1868         running a test on a 10,000 line function :). Dropping the
1869         function length to 640 still exercises the code path and
1870         provides a 10x speedup.
1871
1872         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1873         (CppStyleTest):
1874         (CheckForFunctionLengthsTest.test_function_length_check_definition_huge_lines):
1875
1876 2012-02-22  Dirk Pranke  <dpranke@chromium.org>
1877
1878         webkitpy: speed up FileLockTest.test_lock_lifecycle
1879         https://bugs.webkit.org/show_bug.cgi?id=79189
1880
1881         Reviewed by Adam Barth.
1882
1883         The unit test had a second lock trying to acquire a
1884         lock already held, and a hard-coded timeout of one second.
1885         I have changed the timeouts to a tenth of a second (which
1886         is probably still fine) and changed the hard-spin on
1887         the lock to a slow-spin every hundredth of a second.
1888
1889         * Scripts/webkitpy/common/system/file_lock.py:
1890         (FileLock.acquire_lock):
1891         * Scripts/webkitpy/common/system/file_lock_integrationtest.py:
1892         (FileLockTest.setUp):
1893         (FileLockTest.test_stuck_lock):
1894
1895 2012-02-22  Gabor Rapcsanyi  <rgabor@webkit.org>
1896
1897         build-webkit should use environment variable at number of CPU
1898         detection on all platform
1899         https://bugs.webkit.org/show_bug.cgi?id=79227
1900
1901         Reviewed by Martin Robinson.
1902
1903         * Scripts/webkitdirs.pm:
1904         (determineNumberOfCPUs):
1905
1906 2012-02-22  Mihnea Ovidenie  <mihnea@adobe.com>
1907
1908         [Qt] REGRESSION(r108108): It made 3 fast/repaint tests fail
1909         https://bugs.webkit.org/show_bug.cgi?id=78960
1910
1911         Reviewed by Csaba Osztrogonác.
1912
1913         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1914         (LayoutTestController::overridePreference):
1915
1916 2012-02-22  Hao Zheng  <zhenghao@chromium.org>
1917
1918         [chromium] Build WebKit with MEDIA_STREAM disabled.
1919         https://bugs.webkit.org/show_bug.cgi?id=79214
1920
1921         Reviewed by Kent Tamura.
1922
1923         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
1924         * DumpRenderTree/chromium/WebUserMediaClientMock.h:
1925         * DumpRenderTree/chromium/WebViewHost.cpp:
1926         (WebViewHost::createMediaPlayer):
1927         * DumpRenderTree/chromium/WebViewHost.h:
1928         (WebViewHost):
1929
1930 2012-02-22  Zeno Albisser  <zeno@webkit.org>
1931
1932         [Qt][WK2][Mac] WebKitTestRunner does not build with clang.
1933         https://bugs.webkit.org/show_bug.cgi?id=79124
1934
1935         WebKitTestRunnerPrefix.h should also be included
1936         when building with clang.
1937
1938         Reviewed by Kenneth Rohde Christiansen.
1939
1940         * WebKitTestRunner/Target.pri:
1941
1942 2012-02-20  Roland Steiner  <rolandsteiner@chromium.org>
1943
1944         <style scoped>: Add runtime-flag
1945         https://bugs.webkit.org/show_bug.cgi?id=79074
1946
1947         Enable the runtime-flag for DRT. 
1948
1949         Reviewed by Dimitri Glazkov.
1950
1951         * DumpRenderTree/chromium/TestShell.cpp:
1952         (TestShell::TestShell):
1953
1954 2012-02-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1955
1956         Unreviewed, rolling out r107351.
1957         http://trac.webkit.org/changeset/107351
1958         https://bugs.webkit.org/show_bug.cgi?id=53600
1959
1960         Several issues introduced in WebKitGTK+ API
1961
1962         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1963         (createWebView):
1964         * GtkLauncher/main.c:
1965         (createWebViewCb):
1966         (createBrowser):
1967         (createWindow):
1968         (main):
1969
1970 2012-02-21  Filip Pizlo  <fpizlo@apple.com>
1971
1972         JSC should be a triple-tier VM
1973         https://bugs.webkit.org/show_bug.cgi?id=75812
1974         <rdar://problem/10079694>
1975
1976         Reviewed by Gavin Barraclough.
1977
1978         Changed EFL's build system to include a new directory in JavaScriptCore.
1979
1980         * DumpRenderTree/efl/CMakeLists.txt:
1981
1982 2012-02-21  Daniel Cheng  <dcheng@chromium.org>
1983
1984         [chromium] Fix image drag out on Chromium
1985         https://bugs.webkit.org/show_bug.cgi?id=79158
1986
1987         Reviewed by Tony Chang.
1988
1989         * DumpRenderTree/chromium/EventSender.cpp:
1990         (EventSender::dumpFilenameBeingDragged):
1991         (EventSender::beginDragWithFiles):
1992         * DumpRenderTree/chromium/WebViewHost.cpp:
1993         (addDRTFakeFileToDataObject):
1994
1995 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
1996
1997         webkitpy: speed up hot filesystem_mock functions
1998         https://bugs.webkit.org/show_bug.cgi?id=79159
1999
2000         Reviewed by Adam Barth.
2001
2002         Profiling run_webkit_tests_integrationtest.py revealed that
2003         isdir(), normpath(), and join() are called a lot and were very
2004         slow.This patch speeds them up substantially, shaving 20 seconds
2005         off of the execution time.
2006
2007         * Scripts/webkitpy/common/system/filesystem_mock.py:
2008         (MockFileSystem.isdir):
2009         (MockFileSystem._slow_but_correct_join):
2010         (MockFileSystem.join):
2011         (MockFileSystem.listdir):
2012         (MockFileSystem._slow_but_correct_normpath):
2013         (MockFileSystem.normpath):
2014         (MockFileSystem.write_binary_file):
2015         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
2016         (MockFileSystemTest.quick_check):
2017         (MockFileSystemTest):
2018         (MockFileSystemTest.test_join):
2019         (MockFileSystemTest.test_normpath):
2020         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
2021         (get_test_config): Call write_binary_file() instead of updating
2022           filesystem.files directly, so that we create directories as
2023           needed.
2024
2025 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
2026
2027         nrwt: make the delay between starting workers configurable per-port
2028         https://bugs.webkit.org/show_bug.cgi?id=79148
2029
2030         Reviewed by Eric Seidel.
2031
2032         Because of bug 79147, we have to sleep a bit in between starting
2033         DRTs; however, doing so across the board slows down the Test
2034         port. Making this configurable shaves 10 seconds off of
2035         run_webkit_tests_integrationtest.py
2036         
2037         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2038         (Manager._run_tests):
2039         * Scripts/webkitpy/layout_tests/port/base.py:
2040         (Port.worker_startup_delay_secs):
2041         * Scripts/webkitpy/layout_tests/port/test.py:
2042         (TestPort.worker_startup_delay_secs):
2043
2044 2012-02-21  Jon Lee  <jonlee@apple.com>
2045
2046         Bring notifications support to WK1 mac
2047         https://bugs.webkit.org/show_bug.cgi?id=78783
2048         <rdar://problem/10610578>
2049
2050         Reviewed by Anders Carlsson.
2051
2052         * DumpRenderTree/mac/UIDelegate.mm: Refactor WebGeolocationPolicyListener to WebAllowDenyPolicyListener.
2053         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
2054         (-[UIDelegate timerFired]):
2055
2056 2012-02-21  Kentaro Hara  <haraken@chromium.org>
2057
2058         Enable the IDL attribute checker in run-bindings-tests
2059         https://bugs.webkit.org/show_bug.cgi?id=79091
2060
2061         Reviewed by Adam Barth.
2062
2063         We have enabled the IDL attribute checker in Chromium in r108322.
2064         This patch enables the IDL attribute checker in run-bindings-tests.
2065
2066         No tests. I manually checked that [Custommm], [CallWith=],
2067         [CallWith=ScriptExecutionContext|Foo] in TestObj.idl cause
2068         run-bindings-tests failures.
2069
2070         * Scripts/webkitpy/bindings/main.py:
2071         (BindingsTests.generate_supplemental_dependency):
2072
2073 2012-02-21  Rafael Weinstein  <rafaelw@chromium.org>
2074
2075         Add rafaelw as a committer.
2076
2077         Unreviewed.
2078
2079         * Scripts/webkitpy/common/config/committers.py:
2080
2081 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
2082
2083         webkitpy: update names after deleting message_broker
2084         https://bugs.webkit.org/show_bug.cgi?id=79000
2085
2086         Reviewed by Eric Seidel.
2087
2088         Part 3 of 3 in deleting message_broker.py; this change just
2089         adjusts the names for the newly merged symbols so that they are
2090         private as appropriate.
2091
2092         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
2093         (get):
2094         (_Broker):
2095         (_BrokerConnection):
2096         (_BrokerConnection.__init__):
2097         (AbstractWorker.__init__):
2098         (_ManagerConnection):
2099         (_ManagerConnection.__init__):
2100         (_WorkerConnection):
2101         (_WorkerConnection.__init__):
2102
2103 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
2104
2105         webkitpy: merge message_broker.py into manager_worker_broker.py
2106         https://bugs.webkit.org/show_bug.cgi?id=78999
2107
2108         Reviewed by Tony Chang.
2109
2110         This is pretty much a straight cut-and-paste of one file into
2111         another (broken up so that docstrings and imports are in the
2112         right place).
2113
2114         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
2115         (BrokerClient):
2116         (BrokerClient.is_done):
2117         (BrokerClient.name):
2118         (Broker):
2119         (Broker.__init__):
2120         (Broker.add_topic):
2121         (Broker._get_queue_for_topic):
2122         (Broker.post_message):
2123         (Broker.run_message_loop):
2124         (Broker.run_all_pending):
2125         (Broker._run_loop):
2126         (Broker._dispatch_message):
2127         (_Message):
2128         (_Message.loads):
2129         (_Message.__init__):
2130         (_Message.dumps):
2131         (_Message.__repr__):
2132         (BrokerConnection):
2133         (BrokerConnection.__init__):
2134         (BrokerConnection.run_message_loop):
2135         (BrokerConnection.post_message):
2136         (BrokerConnection.raise_exception):
2137         * Scripts/webkitpy/layout_tests/controllers/message_broker.py: Removed.
2138
2139 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
2140
2141         webkitpy: prepare to delete message_broker.py
2142         https://bugs.webkit.org/show_bug.cgi?id=78997
2143
2144         Reviewed by Eric Seidel.
2145
2146         This is part 1 of 3 changes to fix bug 78187. This change
2147         prepares the code for merging message_broker.py into
2148         manager_worker_broker.py; the tests in message_broker_unittest
2149         are merged into manager_worker_broker_unittest, the symbols
2150         needed by the tests are exported from manager_worker_broker.py,
2151         and manager_worker_broker itself is updated to refer to the
2152         symbols directly (without the module prefix).
2153
2154         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
2155         (get):
2156         (AbstractWorker):
2157         (AbstractWorker.__init__):
2158         (_ManagerConnection):
2159         (_ManagerConnection.__init__):
2160         (_WorkerConnection):
2161         (_WorkerConnection.__init__):
2162         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
2163         (InterfaceTest.test_brokerclient_is_abstract):
2164         (InterfaceTest.test_brokerclient_is_abstract.methods):
2165         (MessageTest):
2166         (MessageTest.test__no_body):
2167         (MessageTest.test__body):
2168         * Scripts/webkitpy/layout_tests/controllers/message_broker_unittest.py: Removed.
2169
2170 2012-02-21  Sam Weinig  <sam@webkit.org>
2171
2172         Attempt to fix the Snow Leopard build.
2173
2174         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2175         * MiniBrowser/Configurations/Base.xcconfig:
2176         * TestWebKitAPI/Configurations/Base.xcconfig:
2177         * WebKitTestRunner/Configurations/Base.xcconfig:
2178
2179 2012-02-21  Sam Weinig  <sam@webkit.org>
2180
2181         Use libc++ when building with Clang on Mac
2182         https://bugs.webkit.org/show_bug.cgi?id=78981
2183
2184         Reviewed by Dan Bernstein.
2185
2186         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2187         * MiniBrowser/Configurations/Base.xcconfig:
2188         * TestWebKitAPI/Configurations/Base.xcconfig:
2189         * WebKitTestRunner/Configurations/Base.xcconfig:
2190
2191 2012-02-21  Adam Roben  <aroben@apple.com>
2192
2193         Roll out r108309, r108323, and r108326
2194
2195         They broke the 32-bit Lion build.
2196
2197         Original bugs is <http://webkit.org/b/75812> <rdar://problem/10079694>.
2198
2199         * DumpRenderTree/efl/CMakeLists.txt:
2200
2201 2012-02-21  Andras Becsi  <andras.becsi@nokia.com>
2202
2203         [Qt][WK2] Get rid of the dependency to QtWidgets
2204         https://bugs.webkit.org/show_bug.cgi?id=76276
2205
2206         Reviewed by Simon Hausmann.
2207
2208         * MiniBrowser/qt/MiniBrowser.pro:
2209         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2210         (MiniBrowserApplication::MiniBrowserApplication):
2211         (MiniBrowserApplication::notify):
2212         (MiniBrowserApplication::sendTouchEvent):
2213         * MiniBrowser/qt/MiniBrowserApplication.h:
2214         (MiniBrowserApplication):
2215         * QtTestBrowser/locationedit.h:
2216         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2217         (WTR::activateFonts):
2218         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2219
2220 2012-02-20  Adam Barth  <abarth@webkit.org>
2221
2222         mastercfg_unittest.py fails without simplejson
2223         https://bugs.webkit.org/show_bug.cgi?id=79070
2224
2225         Reviewed by Csaba Osztrogonác.
2226
2227         Now that we require Python 2.6 (and higher) we can import json rather
2228         than simplejson.  We still need to use the simplejson name because
2229         that's what the master.cfg script expects.
2230
2231         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2232         (BuildBotConfigLoader._add_dependant_modules_to_sys_modules):
2233
2234 2012-02-20  Filip Pizlo  <fpizlo@apple.com>
2235
2236         JSC should be a triple-tier VM
2237         https://bugs.webkit.org/show_bug.cgi?id=75812
2238         <rdar://problem/10079694>
2239
2240         Reviewed by Gavin Barraclough.
2241
2242         Changed EFL's build system to include a new directory in JavaScriptCore.
2243
2244         * DumpRenderTree/efl/CMakeLists.txt:
2245
2246 2012-02-20  Kenichi Ishibashi  <bashi@chromium.org>
2247
2248         Update pywebsocket to 0.7.2
2249         https://bugs.webkit.org/show_bug.cgi?id=79066
2250
2251         This version includes vendor-prefixed deflate-frame extension support.
2252
2253         Reviewed by Kent Tamura.
2254
2255         * Scripts/webkitpy/thirdparty/__init__.py:
2256         (AutoinstallImportHook._install_pywebsocket):
2257
2258 2012-02-20  Martin Robinson  <mrobinson@igalia.com>
2259
2260         [UNIX] Plugin information fields are not interpreted as UTF-8
2261         https://bugs.webkit.org/show_bug.cgi?id=78635
2262
2263         Reviewed by Gustavo Noronha Silva.
2264
2265         Interpret plugin metadata as UTF8 aways. This matches the behavior
2266         of Chromium and the Totem plugin.
2267
2268         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2269         (NPP_GetValue): Include a UTF-8 character in the description string for testing purposes.
2270
2271 2012-02-20  Martin Robinson  <mrobinson@igalia.com>
2272
2273         [GTK] [Qt] Move the unix forwarding headers for TestNetscapePlugin to the TestNetscapePlugin directory
2274         https://bugs.webkit.org/show_bug.cgi?id=78935
2275
2276         Reviewed by Gustavo Noronha Silva.
2277
2278         Move the TestNetscapePlugin headers to a more appropriate directory and update
2279         the build files to match.
2280
2281         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h.
2282         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h.
2283         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h.
2284         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update build.
2285         * GNUmakefile.am: Ditto.
2286
2287 2012-02-20  Kihong Kwon  <kihong.kwon@samsung.com>
2288
2289         Add a new API for the Vibration API(W3C).
2290         https://bugs.webkit.org/show_bug.cgi?id=72010
2291
2292         Reviewed by Hajime Morita.
2293
2294         * Scripts/build-webkit: Enable ENABLE_VIBRATION feature.
2295
2296 2012-02-20  János Badics  <dicska@gmail.com>
2297
2298         [Qt] run-qtwebkit-tests doesn't consider timeouts as failures
2299         https://bugs.webkit.org/show_bug.cgi?id=71816
2300
2301         RunQtAPITests will notify if a timeout occurs during testing.
2302         Added unittest to the master.cfg
2303
2304         Reviewed by Csaba Osztrogonác.
2305
2306         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2307         (RunQtAPITests.evaluateCommand):
2308         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2309         (RunQtAPITestsTest):
2310         (RunQtAPITestsTest.assertResults):
2311         (RunQtAPITestsTest.test_timeout):
2312         (test_success):
2313         (test_failure):
2314         (test_timeout_and_failure):
2315
2316 2012-02-20  Andy Wingo  <wingo@igalia.com>
2317
2318         Add wingo as a committer.
2319
2320         Unreviewed.
2321
2322         * Scripts/webkitpy/common/config/committers.py: Add myself to the
2323         committers list.
2324
2325 2012-02-20  Jochen Eisinger  <jochen@chromium.org>
2326
2327         [chromium] check that we're not running multiple modal dialogs at the same time
2328         https://bugs.webkit.org/show_bug.cgi?id=78486
2329
2330         Reviewed by Kent Tamura.
2331
2332         * DumpRenderTree/chromium/TestShell.cpp:
2333         (TestShell::TestShell):
2334         * DumpRenderTree/chromium/TestShell.h:
2335         (TestShell::setIsDisplayingModalDialog):
2336         (TestShell::isDisplayingModalDialog):
2337         (TestShell):
2338         * DumpRenderTree/chromium/WebViewHost.cpp:
2339         (WebViewHost::runModal):
2340
2341 2012-02-20  Martin Robinson  <mrobinson@igalia.com>
2342
2343         Fix WebKit2GTK+ for 'make distcheck'.
2344
2345         Instead of conditionally including WebKit2 GNUmakefiles, always
2346         include them and conditionally activate the final targets.
2347
2348         * MiniBrowser/gtk/GNUmakefile.am:
2349         * WebKitTestRunner/GNUmakefile.am:
2350
2351 2012-02-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2352
2353         Enable video option for EFL port in build-webkit.
2354         https://bugs.webkit.org/show_bug.cgi?id=79006
2355
2356         Reviewed by Daniel Bates.
2357
2358         * Scripts/build-webkit:
2359
2360 2012-02-19  JungJik Lee  <jungjik.lee@samsung.com>
2361
2362         [EFL] Use modifier keys to execute pre-rendering.
2363         https://bugs.webkit.org/show_bug.cgi?id=77933
2364
2365         Reviewed by Chang Shu.
2366
2367         Use modifier key to execute pre-rendering instead of using reserved function keys.
2368
2369         * EWebLauncher/main.c:
2370         (on_key_down):
2371
2372 2012-02-18  Dirk Pranke  <dpranke@chromium.org>
2373
2374         Fix one more dangling reference to worker_connection.name, delete unused code.
2375
2376         Unreviewed, build fix.
2377
2378         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2379         (Manager.update):
2380         (_WorkerState.__init__):
2381
2382 2012-02-18  Dirk Pranke  <dpranke@chromium.org>
2383
2384         Add a change that should've been in r108005.
2385
2386         Unreviewed, build fix.
2387
2388         In the refactoring/cleanup in r108005 I should've changed the
2389         implementation of WorkerConnection to make it match BrokerClient
2390         (and everything else) so that objects had a name() method
2391         instead of a name property.
2392
2393         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2394         (Manager._run_tests):
2395         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
2396         (_WorkerConnection.__init__):
2397         (_WorkerConnection.name):
2398         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
2399         (_TestWorker.__init__):
2400         (_TestsMixin.name):
2401         (_TestsMixin.test_name):
2402         (_TestsMixin.test_cancel):
2403         (_TestsMixin.test_unknown_message):
2404
2405 2012-02-18  Dirk Pranke  <dpranke@chromium.org>
2406
2407         webkitpy: remove webkitpy.common.array_stream
2408         https://bugs.webkit.org/show_bug.cgi?id=78952
2409
2410         Reviewed by Eric Seidel.
2411
2412         Turns out array_stream didn't really do anything that StringIO
2413         didn't do (at least as of Python 2.6). This change removes it
2414         and updates all of the callers. Where possible, I changed the
2415         test assertions in order to capture the intent more clearly,
2416         e.g., instead of calling self.assertTrue('foo' in stream.get()),
2417         we have self.assertContainsLine(stream, 'foo'), and instead of
2418         self.assertTrue(stream.empty()), we have self.assertEmpty(stream) -
2419         the latter isn't that much more readable, but StringIO doesn't
2420         export an empty() method.
2421
2422         * Scripts/webkitpy/common/array_stream.py: Removed.
2423         * Scripts/webkitpy/common/array_stream_unittest.py: Removed.
2424         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2425         (passing_run):
2426         (run_and_capture):
2427         (StreamTestingMixin):
2428         (StreamTestingMixin.assertContains):
2429         (StreamTestingMixin.assertContainsLine):
2430         (StreamTestingMixin.assertEmpty):
2431         (StreamTestingMixin.assertNotEmpty):
2432         (LintTest):
2433         (LintTest.test_lint_test_files):
2434         (LintTest.test_lint_test_files__errors):
2435         (MainTest):
2436         (MainTest.test_child_process_1):
2437         (MainTest.test_child_processes_2):
2438         (MainTest.test_child_processes_min):
2439         (MainTest.test_help_printing):
2440         (MainTest.test_hung_thread):
2441         (MainTest.test_no_tests_found):
2442         (MainTest.test_no_tests_found_2):
2443         (MainTest.test_repeat_each_iterations_num_tests):
2444         (MainTest.test_test_list):
2445         (MainTest.test_unexpected_failures):
2446         (MainTest.test_worker_model__inline_with_child_processes):
2447         (MainTest.test_additional_platform_directory):
2448         (RebaselineTest):
2449         (RebaselineTest.assertBaselines):
2450         (RebaselineTest.test_reset_results):
2451         (RebaselineTest.test_missing_results):
2452         (RebaselineTest.test_new_baseline):
2453         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
2454         (MeteredStream.update):
2455         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
2456         (TestMeteredStream.test_regular):
2457         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
2458         (TestUtilityFunctions.assertEmpty):
2459         (TestUtilityFunctions):
2460         (TestUtilityFunctions.assertNotEmpty):
2461         (TestUtilityFunctions.assertWritten):
2462         (TestUtilityFunctions.test_configure_logging):
2463         (Testprinter.assertEmpty):
2464         (Testprinter):
2465         (Testprinter.assertNotEmpty):
2466         (Testprinter.assertWritten):
2467         (Testprinter.reset):
2468         (Testprinter.get_printer):
2469         (Testprinter.test_help_printer):
2470         (Testprinter.do_switch_tests.do_helper):
2471         (Testprinter.test_print_one_line_summary):
2472         (Testprinter.test_print_test_result):
2473         (Testprinter.test_print_progress):
2474         (Testprinter.test_write_nothing):
2475         (Testprinter.test_write_misc):
2476         (Testprinter.test_write_everything):
2477         (Testprinter.test_write_verbose):
2478         (Testprinter.test_print_unexpected_results):
2479         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2480         (MainTest.assertWritten):
2481         (create_runner):
2482         (test_run_test_set):
2483         (test_run_test_set_kills_drt_per_run):
2484         (test_run_test_set_for_parser_tests):
2485         (test_run_test_set_with_json_output):
2486         (test_run_test_set_with_json_source):
2487         (test_run_test_set_with_multiple_repositories):
2488         (test_upload_json):
2489
2490 2012-02-18  Kevin Ollivier  <kevino@theolliviers.com>
2491
2492         [wx] Add the WebCore/page/scrolling directory to the build dirs.
2493
2494         * waf/build/settings.py:
2495
2496 2012-02-18  Kevin Ollivier  <kevino@theolliviers.com>
2497
2498         [wx] Unreviewed build fix. Don't error out or hang if we have
2499         downloaded dependencies but server update check fails.
2500
2501         * waf/build/build_utils.py:
2502         (download_if_newer):
2503
2504 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
2505
2506         The new run-webkit-tests needs to dump out pixel hash failures even if the pixel test passes.
2507         https://bugs.webkit.org/show_bug.cgi?id=69444
2508
2509         Reviewed by Tony Chang.
2510
2511         Currently if a test's image checksum doesn't match the checksum
2512         in the baseline, but the images themselves match according to
2513         ImageDiff, new-run-webkit-tests ignores the problem. This is
2514         probably bad, but it's not yet clear what the right thing to do
2515         is. This patch will log a warning to stderr, at least (but the
2516         test will still pass).
2517
2518         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2519         (SingleTestRunner._compare_image):
2520         (SingleTestRunner._run_reftest):
2521         * Scripts/webkitpy/layout_tests/port/test.py:
2522         (unit_test_list):
2523         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2524
2525 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
2526
2527         NRWT does not report failure for a skipped test
2528         https://bugs.webkit.org/show_bug.cgi?id=78750
2529
2530         Reviewed by Eric Seidel.
2531
2532         If a test is listed in a Skipped file and you run it anyway
2533         with --force, and the test fails, currently NRWT will print
2534         "test ran as expected"; this is confusing, because you probably
2535         expect the test to fail and yet this might lead you to think the
2536         test passed. This patch changes the expected behavior to "PASS",
2537         so tests that fail will be reported.
2538
2539         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2540         (result_was_expected):
2541         (TestExpectationParser):
2542         (TestExpectationParser.expectation_for_skipped_test):
2543         (TestExpectations):
2544         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2545         (test_add_skipped_tests):
2546         * Scripts/webkitpy/layout_tests/port/test.py:
2547         (unit_test_list): Add some tests that are expected to be in a Skipped file.
2548         (TestPort.skipped_tests): This adds actual integration test coverage of Skipped files.
2549
2550 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
2551
2552         webkitpy: fix test code after bug 78181
2553         https://bugs.webkit.org/show_bug.cgi?id=78870
2554
2555         Reviewed by Adam Barth.
2556
2557         I forgot to update the test code as per Tony's suggestion in
2558         bug 78181 (r108005). This change does that, and in doing so
2559         it revealed a subtle bug in _InlineWorkerConnection.run() that
2560         I am fixing as part of this (_alive would not be cleared if an
2561         exception was thrown).
2562
2563         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
2564         (_InlineWorkerConnection.run):
2565         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
2566         (_TestWorker.__init__):
2567         (_TestWorker.handle_stop):
2568         (_TestWorker.handle_test):
2569         (_TestWorker.run):
2570         (_TestsMixin.handle_exception):
2571         (_TestsMixin.test_unknown_message):
2572
2573 2012-02-17  Adam Roben  <aroben@apple.com>
2574
2575         Mac build fix after r108119
2576
2577         * DumpRenderTree/mac/DumpRenderTree.mm:
2578         (runThread):
2579         (runPthread):
2580         (testThreadIdentifierMap):
2581         Updated to match current WTF threading APIs.
2582
2583 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
2584
2585         revert r107147 - breaks webkit-patch on Mac SL
2586         https://bugs.webkit.org/show_bug.cgi?id=78866
2587
2588         Reviewed by Adam Barth.
2589
2590         It appears that zipfile.ExtractAll is broken on Python 2.6.1,
2591         which is the version that ships on Mac SL. Reverting this
2592         change until we no longer have to worry about that version.
2593
2594         * Scripts/webkitpy/common/system/autoinstall.py:
2595         (AutoInstaller):
2596         (AutoInstaller._extract_all): Added a comment about SL.
2597         (AutoInstaller._unzip):
2598
2599 2012-02-17  Mihnea Ovidenie  <mihnea@adobe.com>
2600
2601         CSS regions enabled by default
2602         https://bugs.webkit.org/show_bug.cgi?id=78525
2603
2604         Reviewed by David Hyatt.
2605
2606         Add a runtime preference to enable/disable regions functionality at runtime(WebKitCSSRegionsEnabled).
2607         CSSRegions are still enabled by default.
2608         In DRT, use layoutTestController.overridePreference("WebKitCSSRegionsEnabled", "0") to disable the css regions functionality.
2609
2610         * DumpRenderTree/chromium/LayoutTestController.cpp:
2611         (LayoutTestController::overridePreference):
2612         * DumpRenderTree/chromium/WebPreferences.cpp:
2613         (WebPreferences::reset):
2614         (WebPreferences::applyTo):
2615         * DumpRenderTree/chromium/WebPreferences.h:
2616         (WebPreferences):
2617         * DumpRenderTree/mac/DumpRenderTree.mm:
2618         (resetDefaultsToConsistentValues):
2619
2620 2012-02-17  Maciej Stachowiak  <mjs@apple.com>
2621
2622         Some API tests erroneously use = instead of == (causing build failures)
2623         https://bugs.webkit.org/show_bug.cgi?id=78915
2624
2625         Reviewed by Sam Weinig.
2626
2627         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2628         (TestWebKitAPI::decidePolicyForNavigationAction): Replace an = with an ==
2629         (TestWebKitAPI::decidePolicyForNewWindowAction): ditto
2630
2631 2012-02-17  Peter Beverloo  <peter@chromium.org>
2632
2633         [Chromium] Include TestShellLinux.cpp in the build for Android
2634         https://bugs.webkit.org/show_bug.cgi?id=78865
2635
2636         Reviewed by Eric Seidel.
2637
2638         Android will be re-using the TestShellLinux.cpp file. I already
2639         added this r104033, but it seems to have gotten lost in the
2640         recent refactorings.
2641
2642         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2643
2644 2012-02-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2645
2646         Unreviewed, disable video build on EFL until it can be
2647         supported by EFL build bot.
2648
2649         * Scripts/build-webkit:
2650
2651 2012-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2652
2653         [GTK] Implement zoom in/out in MiniBrowser
2654         https://bugs.webkit.org/show_bug.cgi?id=75253
2655
2656         Reviewed by Gustavo Noronha Silva.
2657
2658         * MiniBrowser/gtk/BrowserWindow.c:
2659         (browserWindowCanZoomIn):
2660         (browserWindowCanZoomOut):
2661         (browserWindowUpdateZoomActions):
2662         (webViewZoomLevelChanged):
2663         (zoomInCallback):
2664         (zoomOutCallback):
2665         (browser_window_init):
2666         (browserWindowConstructed):
2667
2668 2012-02-17  Nikolas Zimmermann  <nzimmermann@rim.com>
2669
2670         layoutTestController.display() is flaky for SVG tests
2671         https://bugs.webkit.org/show_bug.cgi?id=78021
2672
2673         Reviewed by Adam Roben.
2674
2675         Apply the same fix to DRT/Win, as previously applied to DRT/Mac.
2676         Size the web view before running the test, not when dumping.
2677         All platforms handle this correctly now.
2678
2679         * DumpRenderTree/win/DumpRenderTree.cpp:
2680         (dump):
2681         (sizeWebViewForCurrentTest):
2682         (runTest):
2683
2684 2012-02-16  Carlos Garcia Campos  <cgarcia@igalia.com>
2685
2686         [GTK] Make install is broken when building without --enable-gtk-doc
2687         https://bugs.webkit.org/show_bug.cgi?id=78828
2688
2689         Reviewed by Martin Robinson.
2690
2691         * gtk/generate-gtkdoc:
2692         (rebase_installed_docs): Check documentation has been generated
2693         before trying to rebase it.
2694
2695 2012-02-16  Dirk Pranke  <dpranke@chromium.org>
2696
2697         nrwt: simplify worker interface
2698         https://bugs.webkit.org/show_bug.cgi?id=78181
2699
2700         Reviewed by Tony Chang.
2701
2702         This change moves code in name(), is_done(), run(), and cancel()
2703         from Worker to AbstractWorker, since the logic is pretty much
2704         boilerplate code that any implementation would want to use.
2705
2706         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
2707         (get.should):
2708         (AbstractWorker.__init__):
2709         (AbstractWorker):
2710         (AbstractWorker.name):
2711         (AbstractWorker.stop_handling_messages):
2712         (AbstractWorker.run):
2713         (AbstractWorker.is_done):
2714         (AbstractWorker.cancel):
2715         * Scripts/webkitpy/layout_tests/controllers/worker.py:
2716         (Worker.__init__):
2717         (Worker.run):
2718         (Worker.handle_stop):
2719
2720 2012-02-16  Michael Saboff  <msaboff@apple.com>
2721
2722         ENH: Add ability to run subset of JavaScript layout tests with JSC
2723         https://bugs.webkit.org/show_bug.cgi?id=78764
2724
2725         Reviewed by Gavin Barraclough.
2726
2727         New simple test drive shell script that runs a defined
2728         list of javascript tests using jsc and the standalone-{pre,post}.js
2729         wrappers.
2730
2731         * Scripts/run-fast-jsc: Added.
2732
2733 2012-02-16  Csaba Osztrogonác  <ossy@webkit.org>
2734
2735         Add new Qt performance tester bot to build.webkit.org
2736         https://bugs.webkit.org/show_bug.cgi?id=78795
2737
2738         Reviewed by Adam Roben.
2739
2740         * BuildSlaveSupport/build.webkit.org-config/config.json:
2741
2742 2012-02-16  Patrick Gansterer  <paroga@webkit.org>
2743
2744         Disable inspector on WinCE.
2745
2746         Avoid compiling InspectorBackendDispatcher.cpp, which causes an internal compiler error.
2747
2748         * Scripts/build-webkit:
2749
2750 2012-02-16  Patrick Gansterer  <paroga@webkit.org>
2751
2752         WinCE build fix after r107656.
2753
2754         Disable FTPDIR on WinCE, since it does not compile there.
2755
2756         * Scripts/build-webkit:
2757
2758 2012-02-15  Leo Yang  <leo.yang@torchmobile.com.cn>
2759
2760         Build fix after r107863.
2761
2762         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
2763
2764 2012-02-15  Tony Chang  <tony@chromium.org>
2765
2766         [chromium] add linux dbg back to garden-o-matic
2767         https://bugs.webkit.org/show_bug.cgi?id=78752
2768
2769         Reviewed by Adam Barth.
2770
2771         This reflects the current linux debug bot name (there's only one bot).
2772         I'm also remove the mac clang builder since it doesn't exist (mac
2773         always uses clang now).
2774
2775         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2776         * Scripts/webkitpy/layout_tests/port/builders.py:
2777
2778 2012-02-15  Sam Weinig  <sam@webkit.org>
2779
2780         Add style check for ctype functions that are generally frowned upon in WebKit
2781         https://bugs.webkit.org/show_bug.cgi?id=78748
2782
2783         Reviewed by Anders Carlsson.
2784
2785         Not every platform has DisallowCType.h to check for uses of the ctype.h
2786         functions, so add a style check for them as well.
2787
2788         * Scripts/webkitpy/style/checkers/cpp.py:
2789         (check_ctype_functions):
2790         (check_style):
2791         (CppChecker):
2792         Add check.
2793
2794         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2795         (WebKitStyleTest.test_ctype_fucntion):
2796         Add checker.
2797
2798 2012-02-15  Szilard Ledan  <Ledan-Muntean.Szilard@stud.u-szeged.hu>
2799
2800         [Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
2801         https://bugs.webkit.org/show_bug.cgi?id=76546
2802
2803         Reviewed by Simon Hausmann.
2804
2805         Resize the web view programatically because the declarative property binding
2806         does not work. Seems like our qml environment is not initialized fully but it
2807         needs more investigation.
2808
2809         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2810         (WTR::WrapperWindow::handleStatusChanged):
2811         (WTR::PlatformWebView::resizeTo):
2812
2813 2012-02-15  Dirk Pranke  <dpranke@chromium.org>
2814
2815         webkitpy: add a worker_args concept to start_worker()
2816         https://bugs.webkit.org/show_bug.cgi?id=78572
2817
2818         Reviewed by Tony Chang.
2819
2820         This change replaces the three NRWT-specific arguments passed
2821         through the broker to the worker with a generic WorkerArguments
2822         wrapper class and a separate set_inline_arguments() call that can
2823         be used to pass additional data to the worker when it is running
2824         in the same process as the manager (this is needed for testing).
2825         With the addition of set_inline_arguments() we also no longer
2826         need to pass an optional argument to the worker.run() call.
2827
2828         Note that this method is *only* implemented on inline workers,
2829         so calling this on a regular (child process) worker will result
2830         in a runtime error.
2831
2832         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2833         (Manager._run_tests):
2834         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
2835         (AbstractWorker.__init__):
2836         (AbstractWorker.run):
2837         (_ManagerConnection.start_worker):
2838         (_InlineManager.start_worker):
2839         (_InlineManager.set_inline_arguments):
2840         (_InlineManager.run_message_loop):
2841         (_MultiProcessManager.start_worker): Reworked signature.
2842         (_WorkerConnection.__init__):
2843         (_InlineWorkerConnection.__init__):
2844         (_InlineWorkerConnection.set_inline_arguments): New method.
2845         (_InlineWorkerConnection):
2846         (_InlineWorkerConnection.run):
2847         (_Process.run):
2848         (_MultiProcessWorkerConnection.__init__):
2849         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
2850         (_TestWorker.__init__):
2851         (_TestWorker.set_inline_arguments):
2852         (_TestWorker.handle_test):
2853         (_TestWorker.run):
2854         (_TestsMixin.test_cancel):
2855         (_TestsMixin.test_done):
2856         (_TestsMixin.test_unknown_message):
2857         (InlineBrokerTests): New class for more testing.
2858         (InlineBrokerTests.setUp):
2859         (InlineBrokerTests.test_inline_arguments): New test.
2860         (InterfaceTest.test_managerconnection_is_abstract):
2861         (InterfaceTest.test_workerconnection_is_abstract):
2862         * Scripts/webkitpy/layout_tests/controllers/worker.py:
2863         (WorkerArguments):
2864         (WorkerArguments.__init__):
2865         (Worker.__init__):
2866         (Worker.set_inline_arguments):
2867         (Worker):
2868         (Worker.run):
2869         * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py:
2870         (WorkerTest.test_default_platform_in_worker):
2871
2872 2012-02-15  Adam Klein  <adamk@chromium.org>
2873
2874         Unreviewed, rolling out r107704.
2875         http://trac.webkit.org/changeset/107704
2876         https://bugs.webkit.org/show_bug.cgi?id=78486
2877
2878         Caused layout test crashes in debug builds.
2879
2880         Specific crashing tests:
2881
2882         fast/events/show-modal-dialog-onblur-onfocus.html
2883         fast/harness/show-modal-dialog.html
2884         inspector/console/console-long-eval-crash.html
2885
2886         * DumpRenderTree/chromium/TestShell.cpp:
2887         (TestShell::TestShell):
2888         * DumpRenderTree/chromium/TestShell.h:
2889         (TestShell):
2890         * DumpRenderTree/chromium/WebViewHost.cpp:
2891         (WebViewHost::runModal):
2892
2893 2012-02-15  Michael Brüning  <michael.bruning@nokia.com>
2894
2895         [Qt] Add UI for HTTP authentication in the Qt MiniBrowser
2896         https://bugs.webkit.org/show_bug.cgi?id=76347
2897
2898         Reviewed by Kenneth Rohde Christiansen.
2899
2900         * MiniBrowser/qt/MiniBrowser.qrc:
2901         * MiniBrowser/qt/qml/AuthenticationDialog.qml: Added. 
2902         * MiniBrowser/qt/qml/BrowserWindow.qml:
2903         * MiniBrowser/qt/qml/DialogLineInput.qml:
2904
2905 2012-02-15  Simon Hausmann  <simon.hausmann@nokia.com>
2906
2907         [Qt] Fix WebGL in QtTestBrowser
2908
2909         Reviewed by Tor Arne Vestbø.
2910
2911         * QtTestBrowser/QtTestBrowser.pro: Set the OpenGL define so that when passing
2912         the options for enabling GL we also pass them on properly.
2913
2914 2012-02-14  Sam Weinig  <sam@webkit.org>
2915
2916         Add #include of unistd.h on the mac for getcwd. 
2917
2918         Reviewed by Anders Carlsson.
2919
2920         This is necessary when building with libc++.
2921
2922         * WebKitTestRunner/TestInvocation.cpp:
2923
2924 2012-02-14  Sam Weinig  <sam@webkit.org>
2925
2926         In DRT, don't #define min or max on non-Windows platforms, it just isn't needed
2927         https://bugs.webkit.org/show_bug.cgi?id=78663
2928
2929         Reviewed by Anders Carlsson.
2930
2931         * DumpRenderTree/DumpRenderTreePrefix.h:
2932         * DumpRenderTree/cg/ImageDiffCG.cpp:
2933
2934 2012-02-14  Adam Barth  <abarth@webkit.org>
2935
2936         Implement an adb-based driver for the ChromiumAndroidPort
2937         https://bugs.webkit.org/show_bug.cgi?id=78627
2938
2939         Reviewed by Eric Seidel.
2940
2941         This driver mostly just wires up the ChromiumDriver through adb.  In
2942         some cases, it translates protocol elements, such as URIs, so that the
2943         rest of webkitpy is insulated from the "remoteness" of the target device.
2944
2945         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2946         (ChromiumAndroidPort.start_helper):
2947         (ChromiumAndroidPort._driver_class):
2948         (ChromiumAndroidPort._update_version):
2949         (ChromiumAndroidPort._get_stderr):
2950         (ChromiumAndroidPort):
2951         (ChromiumAndroidPort._get_last_stacktrace):
2952         (ChromiumAndroidPort._teardown_performance):
2953         (ChromiumAndroidDriver):
2954         (ChromiumAndroidDriver.__init__):
2955         (ChromiumAndroidDriver._start):
2956         (ChromiumAndroidDriver.run_test):
2957         (ChromiumAndroidDriver.stop):
2958         (ChromiumAndroidDriver._test_shell_command):
2959         (ChromiumAndroidDriver._write_command_and_read_line):
2960         (ChromiumAndroidDriver._output_image):
2961         (ChromiumAndroidDriver._has_crash_hint):
2962
2963 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
2964
2965         webkitpy: the real_name() method in the Port class is no longer needed
2966         https://bugs.webkit.org/show_bug.cgi?id=78651
2967
2968         Reviewed by Eric Seidel.
2969
2970         The change in bug 78565 / r107718 made it no longer necessary
2971         (we can use options.platform instead).
2972
2973         * Scripts/webkitpy/layout_tests/port/base.py:
2974         (Port.name):
2975         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2976         (MockDRTPort.__init__):
2977
2978 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
2979
2980         webkitpy: clean up options, port handling in manager_worker_broker
2981         https://bugs.webkit.org/show_bug.cgi?id=78568
2982
2983         Reviewed by Tony Chang.
2984
2985         manager_worker_broker no longer needs options or port objects
2986         directly, so we make them only be passed in start_worker().
2987
2988         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2989         (Manager._run_tests):
2990         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
2991         (get):
2992         (_ManagerConnection.__init__):
2993         (_ManagerConnection.start_worker):
2994         (_InlineManager.__init__):
2995         (_InlineManager.start_worker):
2996         (_InlineManager.run_message_loop):
2997         (_MultiProcessManager.__init__):
2998         (_MultiProcessManager):
2999         (_MultiProcessManager.start_worker):
3000         (_InlineWorkerConnection.__init__):
3001         (_InlineWorkerConnection.run):
3002         (_Process.__init__):
3003         (_MultiProcessWorkerConnection.__init__):
3004         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
3005         (make_broker):
3006         (_TestWorker.run):
3007         (_TestsMixin.test_cancel):
3008         (_TestsMixin.test_done):
3009         (_TestsMixin.test_unknown_message):
3010         (MultiProcessBrokerTests.setUp):
3011         (InterfaceTest.test_managerconnection_is_abstract):
3012         * Scripts/webkitpy/layout_tests/controllers/message_broker.py:
3013         (Broker.__init__):
3014
3015 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
3016
3017         nrwt: add a unit test for regression introduced in bug 78565
3018         https://bugs.webkit.org/show_bug.cgi?id=78646
3019
3020         Reviewed by Tony Chang.
3021
3022         * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py: Added.
3023         (FakeConnection):
3024         (FakeConnection.run_message_loop):
3025         (FakeConnection.post_message):
3026         (WorkerTest):
3027         (WorkerTest.test_default_platform_in_worker):
3028
3029 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
3030
3031         NRWT is broken for the default port
3032         https://bugs.webkit.org/show_bug.cgi?id=78640
3033     
3034         Reviewed by Tony Chang.
3035
3036         The change in r107718 (bug 78565) broke NRWT if you didn't
3037         specify any sort of --platform flag or equivalent. I didn't
3038         catch this because it's a full integration test (which we don't
3039         have an automated test for) and I missed this command line
3040         variant when testing interactively.
3041
3042         * Scripts/webkitpy/layout_tests/controllers/worker.py:
3043         (Worker.run):
3044
3045 2012-02-14  Ramya Chandrasekaran  <cramya@google.com>
3046
3047         Last character display for passwords in Android.
3048         https://bugs.webkit.org/show_bug.cgi?id=78532
3049
3050         Reviewed by Adam Barth.
3051
3052         * DumpRenderTree/chromium/WebPreferences.cpp:
3053         (WebPreferences::applyTo):
3054
3055 2012-02-14  Adam Barth  <abarth@webkit.org>
3056
3057         Finish implementing start_helper for ChromiumAndroidPort
3058         https://bugs.webkit.org/show_bug.cgi?id=78582
3059
3060         Reviewed by Eric Seidel.
3061
3062         This patch contains the remaining odds and ends for the start_helper function.
3063
3064         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3065         (ChromiumAndroidPort.start_helper):
3066         (ChromiumAndroidPort._synchronize_datetime):
3067         (ChromiumAndroidPort):
3068         (ChromiumAndroidPort._check_version):
3069         (ChromiumAndroidPort._run_adb_command):
3070         (ChromiumAndroidPort._copy_device_file):
3071
3072 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
3073
3074         webkitpy: create ports in Workers, not in manager_worker_broker
3075         https://bugs.webkit.org/show_bug.cgi?id=78565
3076
3077         Reviewed by Tony Chang.
3078
3079         We will now create the Port object (if necessary) in the Worker
3080         directly, so that the manager_worker_broker module doesn't need
3081         all of this layout_test-specific logic. Part of the fixes for
3082         bug 78171.
3083
3084         These changes are all well-tested by the existing tests in
3085         run_webkit_tests_integrationtest.py.
3086
3087         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3088         (_Process.run):
3089         * Scripts/webkitpy/layout_tests/controllers/worker.py:
3090         (Worker.__init__):
3091         (Worker.safe_init):
3092         (Worker.run):
3093         (Worker.cleanup):
3094         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3095         (parse_args):
3096         (main): Fix a minor bug where running the 'mock-test' port didn't work right.
3097
3098 2012-02-14  Jochen Eisinger  <jochen@chromium.org>
3099
3100         [chromium] check that we're not running multiple modal dialogs at the same time
3101         https://bugs.webkit.org/show_bug.cgi?id=78486
3102
3103         Reviewed by Kent Tamura.
3104
3105         * DumpRenderTree/chromium/TestShell.cpp:
3106         (TestShell::TestShell):
3107         * DumpRenderTree/chromium/TestShell.h:
3108         (TestShell::setIsDisplayingModalDialog):
3109         (TestShell::isDisplayingModalDialog):
3110         (TestShell):
3111         * DumpRenderTree/chromium/WebViewHost.cpp:
3112         (WebViewHost::runModal):
3113
3114 2012-02-14  Adam Barth  <abarth@webkit.org>
3115
3116         Enable the GPU codepath in the chromium-android port
3117         https://bugs.webkit.org/show_bug.cgi?id=78580
3118
3119         Reviewed by James Robinson.
3120
3121         Suprise!  There is no ChromiumGpuAndroidPort!  Instead, Chromium
3122         Android always uses the GPU codepath, so we set the GPU flags on the
3123         main chromium-android port instead.
3124
3125         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3126         (ChromiumAndroidPort.__init__):
3127
3128 2012-02-14  Adam Barth  <abarth@webkit.org>
3129
3130         NRWT should expose --adb-args flag for Android
3131         https://bugs.webkit.org/show_bug.cgi?id=78579
3132
3133         Reviewed by Eric Seidel.
3134
3135         This flag is already wired up to the ChromiumAndroidPort.
3136
3137         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3138         (parse_args):
3139
3140 2012-02-14  Alexey Proskuryakov  <ap@apple.com>
3141
3142         [Mac][Win][WK2] Switch to RFC 6455 protocol for WebSockets
3143         https://bugs.webkit.org/show_bug.cgi?id=78541
3144         <rdar://problem/10036695>
3145
3146         Reviewed by Kent Tamura.
3147
3148         * DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
3149         * DumpRenderTree/win/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
3150         After each test, reset to using new protocol.
3151
3152 2012-02-11  Nikolas Zimmermann  <nzimmermann@rim.com>
3153
3154         Convert svg/animations to use SMIL methods for driving the timeline
3155         https://bugs.webkit.org/show_bug.cgi?id=78422
3156
3157         Reviewed by Dirk Schulze.
3158
3159         Remove no longer needed SVG specific animation sampling functionality from DRT.
3160         Instead we switched the svg/animations tests to use SVGSVGElement.setCurrentTime.
3161
3162         * DumpRenderTree/LayoutTestController.cpp:
3163         (LayoutTestController::staticFunctions):
3164         * DumpRenderTree/LayoutTestController.h:
3165         (LayoutTestController):
3166         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
3167         * DumpRenderTree/chromium/LayoutTestController.cpp:
3168         (LayoutTestController::LayoutTestController):
3169         * DumpRenderTree/chromium/LayoutTestController.h:
3170         (LayoutTestController):
3171         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3172         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3173         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3174         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3175         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3176         (LayoutTestController):
3177         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3178         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3179
3180 2012-02-13  Rob Flack  <flackr@chromium.org>
3181
3182         Add Linux ChromiumOS test results to flakiness dashboard.
3183         https://bugs.webkit.org/show_bug.cgi?id=78495
3184
3185         Reviewed by Ojan Vafai.
3186
3187         * TestResultServer/static-dashboards/builders.js:
3188         * TestResultServer/static-dashboards/dashboard_base.js:
3189
3190 2012-02-13  ChangSeok Oh  <shivamidow@gmail.com>
3191
3192         [GTK] Mutation Observers build is broken
3193         https://bugs.webkit.org/show_bug.cgi?id=78433
3194
3195         Reviewed by Martin Robinson.
3196
3197         Enabled mutation observers as a default feature for GTK port, too.
3198
3199         * Scripts/build-webkit:
3200
3201 2012-02-13  Loïc Yhuel  <loic.yhuel_ext@softathome.com>
3202
3203         Allow to configure ENABLE_FTPDIR in build-webkit
3204         https://bugs.webkit.org/show_bug.cgi?id=65098
3205
3206         Reviewed by Eric Seidel.
3207
3208         Allow to disable ENABLE_FTPDIR by command line.
3209         Remove ENABLE_FTPDIR from --minimal build
3210
3211         * Scripts/build-webkit: Add entries for ENABLE_FTPDIR (enabled by default)
3212         * qmake/mkspecs/features/features.prf: ENABLE_FTPDIR must be set to match Platform.h,
3213         as, for Qt platform, build-webkit does not add on command line what it thinks to be default values
3214
3215 2012-02-13  Shinya Kawanaka  <shinyak@chromium.org>
3216
3217         Add shinyak as committer.
3218
3219         Unreviewed.
3220
3221         * Scripts/webkitpy/common/config/committers.py:
3222
3223 2012-02-13  Adam Barth  <abarth@webkit.org>
3224
3225         Implement start/stop_helper for ChromiumAndroidPort
3226         https://bugs.webkit.org/show_bug.cgi?id=78558
3227
3228         Reviewed by Dirk Pranke.
3229
3230         These functions (and their dependencies) set up the Android device for
3231         testing.
3232
3233         This patch also includes a few tweaks on the previous patch recommended
3234         by dpranke.
3235
3236         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3237         (ChromiumAndroidPort.__init__):
3238         (ChromiumAndroidPort.start_helper):
3239         (ChromiumAndroidPort.stop_helper):
3240         (ChromiumAndroidPort._shut_down_http_server):
3241         (ChromiumAndroidPort):
3242         (ChromiumAndroidPort._push_executable):
3243         (ChromiumAndroidPort._push_fonts):
3244         (ChromiumAndroidPort._restore_system_font):
3245         (ChromiumAndroidPort._push_test_resources):
3246         (ChromiumAndroidPort._push_to_device):
3247         (ChromiumAndroidPort._pull_from_device):
3248         (ChromiumAndroidPort._kill_device_process):
3249         (ChromiumAndroidPort._setup_performance):
3250         (ChromiumAndroidPort._teardown_performance):
3251         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
3252         (ChromiumAndroidPortTest):
3253         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3254         (PortTestCase):
3255         (PortTestCase.make_port):
3256         (PortTestCase.test_default_worker_model):
3257
3258 2012-02-13  Adam Barth  <abarth@webkit.org>
3259
3260         Implement enough of ChromiumAndroidPort to make ChromiumAndroidPortTest pass
3261         https://bugs.webkit.org/show_bug.cgi?id=78550
3262
3263         Reviewed by Eric Seidel.
3264
3265         Much of this code just forwards to the "host" port, which seems like a
3266         reasonable thing to do.
3267
3268         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3269         (ChromiumAndroidPort.__init__):
3270         (ChromiumAndroidPort.stop_helper):
3271         (ChromiumAndroidPort):
3272         (ChromiumAndroidPort._build_path):
3273         (ChromiumAndroidPort._path_to_apache):
3274         (ChromiumAndroidPort._path_to_apache_config_file):
3275         (ChromiumAndroidPort._path_to_driver):
3276         (ChromiumAndroidPort._path_to_helper):
3277         (ChromiumAndroidPort._path_to_image_diff):
3278         (ChromiumAndroidPort._path_to_lighttpd):
3279         (ChromiumAndroidPort._path_to_lighttpd_modules):
3280         (ChromiumAndroidPort._path_to_lighttpd_php):
3281         (ChromiumAndroidPort._path_to_wdiff):
3282         (ChromiumAndroidPort._shut_down_http_server):
3283         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
3284         (ChromiumAndroidPortTest):
3285         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3286         (PortTestCase):
3287         (PortTestCase.make_port):
3288         (PortTestCase.test_default_worker_model):
3289
3290 2012-02-13  Adam Barth  <abarth@webkit.org>
3291
3292         chromium_android.py should implement "virtual" methods from ChromiumPort
3293         https://bugs.webkit.org/show_bug.cgi?id=78545
3294
3295         Reviewed by Dirk Pranke.
3296
3297         This patch adds basic implementations that specialize a bunch of
3298         functions from ChromiumPort.
3299
3300         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3301         (ChromiumAndroidPort):
3302         (ChromiumAndroidPort.__init__):
3303         (ChromiumAndroidPort.default_child_processes):
3304         (ChromiumAndroidPort.baseline_search_path):
3305         (ChromiumAndroidPort.check_build):
3306         (ChromiumAndroidPort.check_sys_deps):
3307         (ChromiumAndroidPort.default_worker_model):
3308         (ChromiumAndroidPort.test_expectations):
3309         (ChromiumAndroidPort.start_http_server):
3310         (ChromiumAndroidPort.stop_http_server):
3311         (ChromiumAndroidPort.start_helper):
3312         (ChromiumAndroidPort.stop_helper):
3313
3314 2012-02-13  Adam Barth  <abarth@webkit.org>
3315
3316         Add a skeleton ChromiumAndroid port to webkitpy
3317         https://bugs.webkit.org/show_bug.cgi?id=78543
3318
3319         Reviewed by Eric Seidel.
3320
3321         This patch just adds an empty ChromiumAndroid port object to webkitpy
3322         and wires it up to the factory objects.  An actual implementation will
3323         follow.
3324
3325         * Scripts/webkitpy/layout_tests/port/chromium.py:
3326         (ChromiumPort):
3327         * Scripts/webkitpy/layout_tests/port/chromium_android.py: Added.
3328         (ChromiumAndroidPort):
3329         (ChromiumAndroidPort.__init__):
3330         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3331         (ChromiumPortTest.test_all_test_configurations):
3332         * Scripts/webkitpy/layout_tests/port/factory.py:
3333         (PortFactory):
3334
3335 2012-02-13  Adam Barth  <abarth@webkit.org>
3336
3337         NRWT's HTTP servers should support additional directories for resources
3338         https://bugs.webkit.org/show_bug.cgi?id=78528
3339
3340         Reviewed by Eric Seidel.
3341
3342         This functionality will be used by the Chromium-Android port.
3343
3344         * Scripts/webkitpy/layout_tests/port/base.py:
3345         (Port.to.start_http_server):
3346         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
3347         (LayoutTestApacheHttpd.__init__):
3348         * Scripts/webkitpy/layout_tests/servers/http_server.py:
3349         (Lighttpd.__init__):
3350         (Lighttpd._prepare_config):
3351
3352 2012-02-13  Ami Fischman  <fischman@chromium.org>
3353
3354         Add fischman as committer.
3355
3356         Unreviewed
3357
3358         * Scripts/webkitpy/common/config/committers.py:
3359
3360 2012-02-06  Raphael Kubo da Costa  <kubo@profusion.mobi>
3361
3362         [EFL] Drop support for the Curl network backend.
3363         https://bugs.webkit.org/show_bug.cgi?id=77874
3364
3365         Reviewed by Eric Seidel.
3366
3367         Nobody seems to be maintaining the Curl backend in WebCore, the
3368         EFL port developers all seem to be using the Soup backend and the
3369         port itself has many features which are only implemented for the
3370         latter.
3371
3372         * DumpRenderTree/efl/CMakeLists.txt: Always link to glib/libsoup
3373         and always add the required include directories.
3374         * EWebLauncher/CMakeLists.txt: Add the required glib/libsoup
3375         include directories and link to them.
3376
3377 2012-02-13  Kenichi Ishibashi  <bashi@chromium.org>
3378
3379         [WebSocket] Update pywebsocket to 0.7.1
3380         https://bugs.webkit.org/show_bug.cgi?id=78484
3381
3382         pywebsocket-0.7.1 follow the current draft of WebSocket deflate-frame extension.
3383
3384         Reviewed by Kent Tamura.
3385
3386         * Scripts/webkitpy/thirdparty/__init__.py:
3387         (AutoinstallImportHook._install_pywebsocket):
3388
3389 2012-02-12  Kangil Han  <kangil.han@samsung.com>
3390
3391         [EFL][DRT] Implement zoomPage{In,Out} and textZoom{In,Out} events.
3392         https://bugs.webkit.org/show_bug.cgi?id=78091
3393
3394         Reviewed by Hajime Morita.
3395
3396         Implemented zoomPageIn, zoomPageOut, textZoomIn and textZoomOut events on EFL DRT.
3397         This patch will activate around 1,900 test cases from skipped list in EFL port.
3398
3399         * DumpRenderTree/efl/EventSender.cpp:
3400         (textZoom):
3401         (pageZoom):
3402         (textZoomInCallback):
3403         (textZoomOutCallback):
3404         (zoomPageInCallback):
3405         (zoomPageOutCallback):
3406
3407 2012-02-12  Ashod Nakashian  <ashodnakashian@yahoo.com>
3408
3409         KeywordLookupGenerator.py script fails in some cases
3410         https://bugs.webkit.org/show_bug.cgi?id=77886
3411
3412         Reviewed by Benjamin Poulain.
3413
3414         * Scripts/webkitpy/style/checker.py: New rule for Keywords.table to not have CR.
3415         * Scripts/webkitpy/style/checker_unittest.py: New UT for Keywords.table rule.
3416         (GlobalVariablesTest.test_path_rules_specifier):
3417
3418 2012-02-12  Joe Thomas  <joethomas@motorola.com>
3419
3420         Add toText and isTextNode helpers in Text class.
3421         https://bugs.webkit.org/show_bug.cgi?id=78140
3422
3423         Unit test case for the new style checker introduced.
3424
3425         Reviewed by Adam Barth.
3426
3427         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3428         (CppStyleTest):
3429         (CppStyleTest.test_static_cast_readability): Added a unit test case.
3430
3431 2012-02-12  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3432
3433         Enable features supported by EFL port in build-webkit.
3434         https://bugs.webkit.org/show_bug.cgi?id=78348
3435
3436         Reviewed by Ryosuke Niwa.
3437
3438         Sync build-webkit with OptionEfl.cmake, as some features enabled in
3439         OptionEfl.cmake are not enabled in build-webkit.
3440
3441         * Scripts/build-webkit:
3442
3443 2012-02-12  Joe Thomas  <joethomas@motorola.com>
3444
3445         Add toText and isTextNode helpers in Text class.
3446         https://bugs.webkit.org/show_bug.cgi?id=78140
3447
3448         Added a style checker to use toText rather than static_cast<Text*>.
3449
3450         Reviewed by Adam Barth.
3451
3452         * Scripts/webkitpy/style/checkers/cpp.py:
3453         (check_language): Style checker for static_cast<Text*>.
3454
3455 2012-02-12  Philippe Normand  <pnormand@igalia.com>
3456
3457         Unreviewed, disable Mutation observers build on GTK until it can
3458         actually build.
3459
3460         * Scripts/build-webkit:
3461
3462 2012-02-11  Benjamin Poulain  <benjamin@webkit.org>
3463
3464         Add back WTFURL to WebKit
3465         https://bugs.webkit.org/show_bug.cgi?id=77291
3466
3467         Reviewed by Adam Barth.
3468
3469         Add a flag to build-webkit to easily build WebKit with WTFURL.
3470
3471         * Scripts/build-webkit:
3472
3473 2012-02-10  Adam Klein  <adamk@chromium.org>
3474
3475         Enable MUTATION_OBSERVERS by default on all platforms
3476         https://bugs.webkit.org/show_bug.cgi?id=78196
3477
3478         Reviewed by Ojan Vafai.
3479
3480         * Scripts/build-webkit:
3481
3482 2012-02-10  Adam Barth  <abarth@webkit.org>
3483
3484         Move garden-o-matic's All Failures out of experimental
3485         https://bugs.webkit.org/show_bug.cgi?id=78395
3486
3487         Reviewed by Dimitri Glazkov.
3488
3489         Several folks have tried this feature and found it useful.
3490
3491         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
3492
3493 2012-02-10  Tim Horton  <timothy_horton@apple.com>
3494
3495         NRWT should categorize options in --help
3496         https://bugs.webkit.org/show_bug.cgi?id=76221
3497
3498         Reviewed by Eric Seidel.
3499         
3500         Use optparse's OptionGroup mechanism to logically group NRWT's options,
3501         providing a better experience when scanning all the options.
3502
3503         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3504         (parse_args):
3505
3506 2012-02-10  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
3507
3508         [Qt][WK2] Refactor on Qt5 Layout tests' structure
3509         https://bugs.webkit.org/show_bug.cgi?id=77450
3510
3511         Reviewed by Csaba Osztrogonác.
3512
3513         Fix the scripts and related unittest due to the rename of qt-wk2 and qt-wk1
3514         to qt-5.0-wk2 and qt-5.0-wk1.
3515
3516         * Scripts/old-run-webkit-tests:
3517         (buildPlatformResultHierarchy):
3518         (readSkippedFiles):
3519         * Scripts/webkitpy/layout_tests/port/qt.py:
3520         (QtPort._wk2_port_name):
3521         (QtPort._skipped_file_search_paths):
3522         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3523         (QtPortTest.test_baseline_search_path):
3524         * Scripts/webkitpy/layout_tests/port/webkit.py:
3525         (WebKitPort._wk2_port_name):
3526
3527 2012-02-09  Philippe Normand  <pnormand@igalia.com>
3528
3529         [GTK] EWS command-line option to run the tests
3530         https://bugs.webkit.org/show_bug.cgi?id=78211
3531
3532         Reviewed by Adam Barth.
3533
3534         New --run-tests option (defaults to False) for the EWS commands.
3535
3536         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3537         (AbstractEarlyWarningSystem):
3538         (AbstractEarlyWarningSystem.__init__):
3539         (AbstractEarlyWarningSystem.review_patch):
3540         (ChromiumLinuxEWS):
3541         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3542         (EarlyWarningSytemTest._test_builder_ews):
3543
3544 2012-02-09  Eric Seidel  <eric@webkit.org>
3545
3546         Rename compare_text and compare_audio to make it clear that they're !=
3547         https://bugs.webkit.org/show_bug.cgi?id=78301
3548
3549         Reviewed by Adam Barth.
3550
3551         I also removed the maybe_create_directory function which was redundant.
3552
3553         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3554         (Manager.set_up_run):
3555         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3556         (TestResultWriter._make_output_directory):
3557         * Scripts/webkitpy/layout_tests/port/base.py:
3558         (Port.do_text_results_differ):
3559         (Port.do_audio_results_differ):
3560         (Port.diff_text):
3561         (Port.driver_name):
3562         (Port.skips_perf_test):
3563         * Scripts/webkitpy/layout_tests/port/win.py:
3564         (WinPort.do_text_results_differ):
3565         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3566         (WinPortTest.test_do_text_results_differ):
3567         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
3568         (LayoutTestApacheHttpd.__init__):
3569         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
3570         (HttpServerBase.__init__):
3571         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
3572         (Rebaseliner._diff_baselines):
3573
3574 2012-02-09  Zan Dobersek  <zandobersek@gmail.com>
3575
3576         [GTK] Add DRT support for modal dialogs
3577         https://bugs.webkit.org/show_bug.cgi?id=53600
3578
3579         Reviewed by Martin Robinson.
3580
3581         Implement the modal dialogs handling in DumpRenderTree and GtkLauncher.
3582         Most significantly, when creating a new web view in GtkLauncher, the window
3583         of the web view opener is passed around. In DumpRenderTree, the window of
3584         the main web view is always considered as the opener. This is required so
3585         the modal dialog's toplevel can be made transient for the opener's toplevel.
3586
3587         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3588         (webViewRunModalDialog):
3589         (createWebView):
3590         * GtkLauncher/main.c:
3591         (createWebViewCb):
3592         (runModalDialogCb):
3593         (createBrowser):
3594         (createWindow):
3595         (main):
3596
3597 2012-02-09  Zan Dobersek  <zandobersek@gmail.com>
3598
3599         [Gtk] security/set-form-autocomplete-attribute.html fails
3600         https://bugs.webkit.org/show_bug.cgi?id=78261
3601
3602         Reviewed by Martin Robinson.
3603
3604         Use the new helper in DumpRenderTreeSupportGtk to properly
3605         test whether an element performs autocompletion.
3606
3607         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3608         (LayoutTestController::elementDoesAutoCompleteForElementWithId):
3609
3610 2012-02-09  James Robinson  <jamesr@chromium.org>
3611
3612         [chromium] Enable mock scrollbars for compositing layout tests
3613         https://bugs.webkit.org/show_bug.cgi?id=78299
3614
3615         Reviewed by Dirk Pranke.
3616
3617         This enables mock scrollbars by default for compositing tests. These pixel tests are intended to test the
3618         compositor behavior, not native theming, and having real scrollbars causes us to have to maintain significantly
3619         more pngs than we should and expose weird alpha bugs in our theming that doesn't impact real users.
3620
3621         * DumpRenderTree/chromium/TestShell.cpp:
3622         (TestShell::runFileTest):
3623         * DumpRenderTree/chromium/WebPreferences.cpp:
3624         (WebPreferences::reset):
3625         (WebPreferences::applyTo):
3626         * DumpRenderTree/chromium/WebPreferences.h:
3627         (WebPreferences):
3628
3629 2012-02-09  Eric Seidel  <eric@webkit.org>
3630
3631         Remove more uses of "os" from our webkitpy code
3632         https://bugs.webkit.org/show_bug.cgi?id=78292
3633
3634         Reviewed by Adam Barth.
3635
3636         * Scripts/webkitpy/common/checkout/checkout_mock.py:
3637         (MockCheckout.__init__):
3638         (MockCheckout.is_path_to_changelog):
3639         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3640         * Scripts/webkitpy/common/system/filesystem_mock.py:
3641         (MockFileSystem._split):
3642         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
3643         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3644         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3645         * Scripts/webkitpy/layout_tests/port/webkit.py:
3646         * Scripts/webkitpy/tool/bot/queueengine.py:
3647         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
3648         * Scripts/webkitpy/tool/commands/download.py:
3649         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3650         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3651         * Scripts/webkitpy/tool/commands/sheriffbot.py:
3652         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
3653         * Scripts/webkitpy/tool/commands/upload.py:
3654         (CreateBug.prompt_for_bug_title_and_comment):
3655         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
3656         * Scripts/webkitpy/tool/steps/attachtobug.py:
3657         (AttachToBug.run):
3658         * Scripts/webkitpy/tool/steps/checkstyle.py:
3659         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
3660         * Scripts/webkitpy/tool/steps/commit_unittest.py:
3661         * Scripts/webkitpy/tool/steps/editchangelog.py:
3662         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3663         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
3664         (PrepareChangeLogTest.test_ensure_bug_url):
3665         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
3666         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
3667         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
3668         * Scripts/webkitpy/tool/steps/validatereviewer.py:
3669
3670 2012-02-09  Eric Seidel  <eric@webkit.org>
3671
3672         Remove the cr-mac-ews (it's long been dead)
3673         https://bugs.webkit.org/show_bug.cgi?id=78267
3674
3675         Reviewed by Adam Barth.
3676
3677         * QueueStatusServer/model/queues.py:
3678         (Queue):
3679         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3680         (ChromiumWindowsEWS):
3681         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3682         (EarlyWarningSytemTest._test_builder_ews):
3683         (EarlyWarningSytemTest._test_testing_ews):
3684
3685 2012-02-09  Dirk Pranke  <dpranke@chromium.org>
3686
3687         some tests in webkitpy are being run three times
3688         https://bugs.webkit.org/show_bug.cgi?id=78283
3689
3690         Reviewed by Ryosuke Niwa.
3691
3692         It turns out that if you import a class derived from
3693         unittest.TestCase as a base name (e.g., from ... import ChangeLogTest),
3694         the unittest framework treats it as if the class was defined in
3695         the file (as well in the original file). This led us to running
3696         the tests in ChangeLogTest three times.
3697
3698         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
3699         (PrepareChangeLogTest):
3700         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
3701         (_assert_message_for_revert_output):
3702
3703 2012-02-09  Adam Barth  <abarth@webkit.org>
3704
3705         Remove extraneous line in previous patch.  I forgot to remove this
3706         before landing.
3707
3708         * Scripts/webkitpy/layout_tests/port/driver.py:
3709         (DriverProxy.start):
3710
3711 2012-02-09  Adam Barth  <abarth@webkit.org>
3712
3713         run-perf-tests should have an option to pause before running tests so we can attach Instruments
3714         https://bugs.webkit.org/show_bug.cgi?id=78271
3715
3716         Reviewed by Ryosuke Niwa.
3717
3718         This lets me attach instruments to profile the performance of the test.
3719
3720         * Scripts/webkitpy/layout_tests/port/chromium.py:
3721         (ChromiumDriver.start):
3722         * Scripts/webkitpy/layout_tests/port/driver.py:
3723         (Driver.start):
3724         (DriverProxy.start):
3725         * Scripts/webkitpy/layout_tests/port/server_process.py:
3726         (ServerProcess.start):
3727         * Scripts/webkitpy/layout_tests/port/test.py:
3728         (TestDriver.start):
3729         * Scripts/webkitpy/layout_tests/port/webkit.py:
3730         (WebKitDriver.start):
3731         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3732