Fix scrollperf logging
[WebKit-https.git] / Tools / ChangeLog
1 2013-01-22  Joseph Pecoraro  <pecoraro@apple.com>
2
3         [Mac] Enable Page Visibility (PAGE_VISIBILITY_API)
4         https://bugs.webkit.org/show_bug.cgi?id=107230
5
6         Reviewed by David Kilzer.
7
8         * DumpRenderTree/mac/TestRunnerMac.mm:
9         (TestRunner::resetPageVisibility):
10         Fix a typo in the original implementation. resetPageVisibility should
11         pass initialState YES so an event is not dispatched, which causes
12         issues in multiple tests. This now matches other ports.
13
14 2013-01-22  Zan Dobersek  <zandobersek@gmail.com>
15
16         [GTK] Enable CSS Image Orientation feature
17         https://bugs.webkit.org/show_bug.cgi?id=99040
18
19         Reviewed by Martin Robinson.
20
21         Enable the CSS Image Orientation feature in the development
22         builds of the GTK port. The feature is still disabled in the release
23         builds.
24
25         * Scripts/webkitperl/FeatureList.pm:
26
27 2013-01-22  Zan Dobersek  <zandobersek@gmail.com>
28
29         [GTK] Enable the <template> element support in development builds
30         https://bugs.webkit.org/show_bug.cgi?id=106575
31
32         Reviewed by Martin Robinson.
33
34         Enable the <template> element support in the development builds of the GTK port.
35
36         * Scripts/webkitperl/FeatureList.pm:
37
38 2013-01-22  Zan Dobersek  <zandobersek@gmail.com>
39
40         Prettify the output of the override-feature-defines script
41         https://bugs.webkit.org/show_bug.cgi?id=106542
42
43         Reviewed by Martin Robinson.
44
45         The output now clearly lists the feature defines being overridden
46         along with the default and overriding values for each feature define.
47
48         * gtk/override-feature-defines:
49         (adjust_feature_defines_makefile):
50         (adjust_feature_defines_makefile.override_feature_define):
51
52 2013-01-22  Zan Dobersek  <zdobersek@igalia.com>
53
54         Remove uses of deprecated unittest.TestCase aliases
55         https://bugs.webkit.org/show_bug.cgi?id=102252
56
57         Reviewed by Adam Barth.
58
59         Replace the deprecated assertEquals method of the TestCase interface
60         used in some webkitpy unittests with the assertEqual method.
61
62         * Scripts/webkitpy/common/system/profiler_unittest.py:
63         (ProfilerFactoryTest._assert_default_profiler_name):
64         (ProfilerFactoryTest.test_default_profiler_output):
65         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
66         (GtkPortTest.test_expectations_files):
67         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
68         (TestHttpServer.test_win32_start_and_stop):
69
70 2013-01-22  Jer Noble  <jer.noble@apple.com>
71
72         REGRESSION(r140344): Repeated crashes in WKTR PlatformWebView::viewSupportsOptions().
73         https://bugs.webkit.org/show_bug.cgi?id=107562
74
75         Rubber-stamped by Alexy Proskuryakov.
76
77         The input to WKBooleanGetValue() is not NULL-safe, so NULL check its inputs before calling.
78
79         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
80         (WTR::PlatformWebView::PlatformWebView):
81         (WTR::PlatformWebView::viewSupportsOptions):
82
83 2013-01-22  Alexey Proskuryakov  <ap@apple.com>
84
85         One is not allowed to use commit-queue to make oneself a committer.
86
87         * Scripts/webkitpy/common/config/committers.py: Removing eustas@chromium.org.
88
89 2013-01-22  Eugene Klyuchnikov  <eustas@chromium.org>
90
91         Add myself to commiters.py
92         https://bugs.webkit.org/show_bug.cgi?id=107546
93
94         Reviewed by Kentaro Hara.
95
96         * Scripts/webkitpy/common/config/committers.py:
97
98 2013-01-22  Manuel Rego Casasnovas  <rego@igalia.com>
99
100         [GTK] Implement TestRunner::setTextDirection
101         https://bugs.webkit.org/show_bug.cgi?id=107131
102
103         Reviewed by Philippe Normand.
104
105         * DumpRenderTree/gtk/DumpRenderTree.cpp:
106         (resetDefaultsToConsistentValues): Reset direction to default value.
107         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
108         (TestRunner::setTextDirection): Implement method using
109         gtk_widget_set_direction.
110
111 2013-01-22  Jochen Eisinger  <jochen@chromium.org>
112
113         [chromium] move spell checking mocks to TestRunner library
114         https://bugs.webkit.org/show_bug.cgi?id=107455
115
116         Reviewed by Kent Tamura.
117
118         The content module doesn't provide its own WebSpellCheckClient.
119
120         * DumpRenderTree/DumpRenderTree.gypi:
121         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
122         (WebTestRunner::WebTestDelegate::fillSpellingSuggestionList):
123         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
124         (WebKit):
125         (WebTestRunner):
126         (WebTestProxyBase):
127         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
128         (WebTestRunner):
129         (WebTestRunner::makeMenuItemStringsFor):
130         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp: Renamed from Tools/DumpRenderTree/chromium/MockGrammarCheck.cpp.
131         (MockGrammarCheck::checkGrammarOfString):
132         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h: Renamed from Tools/DumpRenderTree/chromium/MockGrammarCheck.h.
133         (WebKit):
134         (MockGrammarCheck):
135         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp: Renamed from Tools/DumpRenderTree/chromium/MockSpellCheck.cpp.
136         (MockSpellCheck::MockSpellCheck):
137         (MockSpellCheck::~MockSpellCheck):
138         (isNotASCIIAlpha):
139         (MockSpellCheck::spellCheckWord):
140         (MockSpellCheck::fillSuggestionList):
141         (MockSpellCheck::initializeIfNeeded):
142         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h: Renamed from Tools/DumpRenderTree/chromium/MockSpellCheck.h.
143         (MockSpellCheck):
144         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp: Added.
145         (WebTestRunner::SpellCheckClient::SpellCheckClient):
146         (WebTestRunner):
147         (WebTestRunner::SpellCheckClient::~SpellCheckClient):
148         (WebTestRunner::SpellCheckClient::setDelegate):
149         (WebTestRunner::SpellCheckClient::spellCheck):
150         (WebTestRunner::SpellCheckClient::checkTextOfParagraph):
151         (WebTestRunner::SpellCheckClient::requestCheckingOfText):
152         (WebTestRunner::SpellCheckClient::finishLastTextCheck):
153         (WebTestRunner::SpellCheckClient::autoCorrectWord):
154         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestDelegate.h.
155         (WebTestRunner):
156         (SpellCheckClient):
157         (WebTestRunner::SpellCheckClient::taskList):
158         (WebTestRunner::SpellCheckClient::mockSpellCheck):
159         * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
160         (TestDelegate):
161         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
162         (WebTestInterfaces::Internal):
163         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
164         (WebTestRunner::WebTestProxyBase::WebTestProxyBase):
165         (WebTestRunner::WebTestProxyBase::~WebTestProxyBase):
166         (WebTestRunner::WebTestProxyBase::setDelegate):
167         (WebTestRunner::WebTestProxyBase::spellCheckClient):
168         (WebTestRunner):
169         * DumpRenderTree/chromium/WebViewHost.cpp:
170         (WebViewHost::WebViewHost):
171         (WebViewHost::setWebWidget):
172         * DumpRenderTree/chromium/WebViewHost.h:
173         (WebViewHost):
174
175 2013-01-22  Krzysztof Czech  <k.czech@samsung.com>
176
177         [EFL] Adds Accessibility support to wk1
178         https://bugs.webkit.org/show_bug.cgi?id=107440
179
180         Reviewed by Gyuyoung Kim.
181
182         * DumpRenderTree/efl/CMakeLists.txt: Adds ATK headers and libraries.
183
184 2013-01-21  Joseph Pecoraro  <pecoraro@apple.com>
185
186         [Mac] WK1 MiniBrowser should clear delegates before releasing webview
187         https://bugs.webkit.org/show_bug.cgi?id=107506
188
189         Reviewed by Dan Bernstein.
190
191         * MiniBrowser/mac/WK1BrowserWindowController.m:
192         (-[WK1BrowserWindowController dealloc]):
193
194 2013-01-21  Dirk Schulze  <dschulze@adobe.com>
195
196         Add build flag for Canvas's Path object (disabled by default)
197         https://bugs.webkit.org/show_bug.cgi?id=107473
198
199         Reviewed by Dean Jackson.
200
201         Add CANVAS_PATH build flag to build systems.
202
203         * Scripts/webkitperl/FeatureList.pm:
204
205 2013-01-21  Jinwoo Song  <jinwoo7.song@samsung.com>
206
207         [EFL][WK2] Add APIs to set/get view source mode
208         https://bugs.webkit.org/show_bug.cgi?id=106633
209
210         Reviewed by Gyuyoung Kim.
211
212         Added a shotcut 'F8' in Minibrowser to display a source code
213         of the web page in a new window.
214
215        * MiniBrowser/efl/main.c:
216         (on_key_down):
217         (on_window_create):
218         (window_create):
219         (elm_main):
220
221 2013-01-21  Nico Weber  <thakis@chromium.org>
222
223         [chromium] Don't archive generated source files.
224         https://bugs.webkit.org/show_bug.cgi?id=106736
225
226         Reviewed by Eric Seidel.
227
228         They shouldn't be needed to run tests. They don't need a lot of space,
229         but add many lines to the "extracting" stdout. This attempts to reduce
230         that noise a bit.
231
232         * BuildSlaveSupport/built-product-archive:
233         (archiveBuiltProduct):
234
235 2013-01-21  Benjamin Poulain  <benjamin@webkit.org>
236
237         Mac DumpRenderTree's installSignalHandlers() is unreachable code
238         https://bugs.webkit.org/show_bug.cgi?id=107383
239
240         Reviewed by Sam Weinig.
241
242         The CrashHandler of DumpRenderTree were originally used for restoring
243         the color profile of the main display even if DRT crashes.
244
245         That feature was later limited to pixel tests only in r29999.
246
247         In r104351, the DRT was changed to use device color space. Making the crash
248         handlers useless, but they were left in the code since the error reporting
249         code was still reachable.
250
251         Later, r124581 refactored the code and dumpPixelsForCurrentTest
252         is being used before being assigned its value.
253         This did cause any regression because the code had become useless with the previous change.
254
255         * DumpRenderTree/mac/DumpRenderTree.mm:
256         Remove crashHandler() and installSignalHandlers() as they have become useless and
257         have been unreachable code for 6 months.
258         (dumpRenderTree):
259         Remove the code that was unreachable due to dumpPixelsForCurrentTest being always false
260         at those points.
261
262 2013-01-21  Nico Weber  <thakis@chromium.org>
263
264         Make ninja the default build system for build-webkit --chromium on mac
265         https://bugs.webkit.org/show_bug.cgi?id=106737
266
267         Reviewed by Eric Seidel.
268
269         * Scripts/update-webkit-chromium:
270
271 2013-01-21  Christophe Dumez  <christophe.dumez@intel.com>
272
273         Regression(r140262): Causes a lot of flakiness
274         https://bugs.webkit.org/show_bug.cgi?id=107454
275
276         Reviewed by Alexey Proskuryakov.
277
278         r140262 introduced a lot of flakiness due to fixed layout mode
279         not getting disabled on the view after being enabled for
280         specific test cases. This patch makes sure fixed layout mode
281         properly gets reset in WebKitTestRunner to avoid flakiness.
282
283         * WebKitTestRunner/TestInvocation.cpp:
284         (WTR::updateLayoutType):
285
286 2013-01-21  Gustavo Noronha Silva  <gns@gnome.org>
287
288         REGRESSION (r140285): GTK uses WKPageResourceLoadClient which was removed
289         https://bugs.webkit.org/show_bug.cgi?id=107421
290
291         Unreviewed build fix.
292
293         * Scripts/run-gtk-tests:
294         (TestRunner): skip Resource tests.
295
296 2013-01-21  Christophe Dumez  <christophe.dumez@intel.com>
297
298         [EFL][WKTR] platformRunUntil() should keep the main loop running
299         https://bugs.webkit.org/show_bug.cgi?id=107442
300
301         Reviewed by Noam Rosenthal.
302
303         EFL's implementation of platformRunUntil() should keep the main loop
304         running and avoid calling sleep() between calls to
305         ecore_main_loop_iterate(). This call to sleep seems to be a source
306         of deadlocks (see Bug 106884).
307
308         * WebKitTestRunner/efl/TestControllerEfl.cpp:
309         (WTR::TestController::platformRunUntil):
310
311 2013-01-21  Vivek Galatage  <vivek.vg@samsung.com>
312
313         QtTestBrowser should provide way to clear selected elements
314         https://bugs.webkit.org/show_bug.cgi?id=107437
315
316         Reviewed by Simon Hausmann.
317
318         Provide a way to "Clear selection" in the "Develop" menu to clear the previous search highlight.
319         Invoke the clearSelection prior to highlighting new elements.
320
321         * QtTestBrowser/launcherwindow.cpp:
322         (ElementHighlight):
323         (LauncherWindow::createChrome):
324         (LauncherWindow::selectElements):
325         (LauncherWindow::clearSelection):
326         * QtTestBrowser/launcherwindow.h:
327         (LauncherWindow):
328
329 2013-01-21  Jochen Eisinger  <jochen@chromium.org>
330
331         [chromium] move methods interacting with willSendRequest to TestRunner
332         https://bugs.webkit.org/show_bug.cgi?id=107270
333
334         Reviewed by Kent Tamura.
335
336         * DumpRenderTree/chromium/DRTTestRunner.cpp:
337         (DRTTestRunner::DRTTestRunner):
338         (DRTTestRunner::waitForPolicyDelegate):
339         * DumpRenderTree/chromium/DRTTestRunner.h:
340         (DRTTestRunner):
341         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
342         (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
343         (WebTestRunner::WebTestRunner::httpHeadersToClear):
344         (WebTestRunner::WebTestRunner::shouldBlockRedirects):
345         (WebTestRunner::WebTestRunner::willSendRequestShouldReturnNull):
346         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
347         (WebTestRunner::TestRunner::TestRunner):
348         (WebTestRunner::TestRunner::reset):
349         (WebTestRunner::TestRunner::httpHeadersToClear):
350         (WebTestRunner):
351         (WebTestRunner::TestRunner::shouldBlockRedirects):
352         (WebTestRunner::TestRunner::willSendRequestShouldReturnNull):
353         (WebTestRunner::TestRunner::setWillSendRequestClearHeader):
354         (WebTestRunner::TestRunner::setWillSendRequestReturnsNullOnRedirect):
355         (WebTestRunner::TestRunner::setWillSendRequestReturnsNull):
356         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
357         (TestRunner):
358         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
359         (WebTestRunner::WebTestProxyBase::willSendRequest):
360         * DumpRenderTree/chromium/WebViewHost.cpp:
361         (WebViewHost::willSendRequest):
362         (WebViewHost::reset):
363         * DumpRenderTree/chromium/WebViewHost.h:
364         (WebViewHost):
365
366 2013-01-21  Zan Dobersek  <zdobersek@igalia.com>
367
368         [GTK] Stop building WebKit2 on GTK EWSs
369         https://bugs.webkit.org/show_bug.cgi?id=107435
370
371         Reviewed by Philippe Normand.
372
373         The WebKit2 build of the GTK is at the moment not efficiently maintainable,
374         so stop building it on GTK EWSs.
375
376         * Scripts/webkitpy/common/config/ports.py:
377         (GtkPort.build_webkit_command):
378         * Scripts/webkitpy/common/config/ports_unittest.py:
379         (DeprecatedPortTest.test_gtk_port):
380
381 2013-01-21  Tommy Widenflycht  <tommyw@google.com>
382
383         MediaStream API: Update the RTCPeerConnection states to match the latest specification
384         https://bugs.webkit.org/show_bug.cgi?id=107120
385
386         Reviewed by Adam Barth.
387
388         Updating mock to use the new states.
389
390         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
391         (RTCPeerConnectionStateTask::RTCPeerConnectionStateTask):
392         (MockWebRTCPeerConnectionHandler::initialize):
393         (MockWebRTCPeerConnectionHandler::updateICE):
394
395 2013-01-20  Tim 'mithro' Ansell  <mithro@mithis.com>
396
397         Extend diff_parser to support the --full-index output.
398         https://bugs.webkit.org/show_bug.cgi?id=107408
399
400         Reviewed by Maciej Stachowiak.
401
402         * Scripts/webkitpy/common/checkout/diff_parser.py:
403         (git_diff_to_svn_diff):
404         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
405         (DiffParserTest):
406         (DiffParserTest.test_git_diff_to_svn_diff):
407         (git_diff_to_svn_diff):
408
409 2013-01-20  Yoshifumi Inoue  <yosin@chromium.org>
410
411         Dragging over an element with scrollbars should scroll the element when dragging near edges
412         https://bugs.webkit.org/show_bug.cgi?id=39725
413
414         Reviewed by Hajime Morita.
415
416         This patch introduces canceling drag-and-drop by escape key for testing
417         behavior after cancellation drag-and-drop.
418
419         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
420         (WebTestRunner):
421         (WebTestRunner::EventSender::doMouseUp):
422         (WebTestRunner::EventSender::finishDragAndDrop):
423         (WebTestRunner::EventSender::keyDown):
424         * DumpRenderTree/chromium/TestRunner/src/EventSender.h:
425         (EventSender):
426         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Added VKEY_ESCAPE.
427
428 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
429
430         [chromium] move frame generation related methods to TestRunner
431         https://bugs.webkit.org/show_bug.cgi?id=107268
432
433         Reviewed by Adam Barth.
434
435         * DumpRenderTree/chromium/DRTTestRunner.cpp:
436         (DRTTestRunner::DRTTestRunner):
437         (DRTTestRunner::setWillSendRequestReturnsNull):
438         * DumpRenderTree/chromium/DRTTestRunner.h:
439         (DRTTestRunner):
440         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
441         (WebTestRunner::WebTestDelegate::display):
442         (WebTestRunner::WebTestDelegate::displayInvalidatedRegion):
443         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
444         (WebTestRunner::TestRunner::TestRunner):
445         (WebTestRunner::TestRunner::display):
446         (WebTestRunner):
447         (WebTestRunner::TestRunner::displayInvalidatedRegion):
448         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
449         (TestRunner):
450         * DumpRenderTree/chromium/WebViewHost.cpp:
451         (WebViewHost::display):
452         (WebViewHost::displayInvalidatedRegion):
453         * DumpRenderTree/chromium/WebViewHost.h:
454
455 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
456
457         [chromium] move speech related methods to TestRunner library
458         https://bugs.webkit.org/show_bug.cgi?id=107266
459
460         Reviewed by Adam Barth.
461
462         * DumpRenderTree/chromium/DRTTestRunner.cpp:
463         (DRTTestRunner::DRTTestRunner):
464         (DRTTestRunner::displayInvalidatedRegion):
465         * DumpRenderTree/chromium/DRTTestRunner.h:
466         (DRTTestRunner):
467         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
468         (WebTestDelegate):
469         (WebTestRunner::WebTestDelegate::addMockSpeechInputResult):
470         (WebTestRunner::WebTestDelegate::setMockSpeechInputDumpRect):
471         (WebTestRunner::WebTestDelegate::addMockSpeechRecognitionResult):
472         (WebTestRunner::WebTestDelegate::setMockSpeechRecognitionError):
473         (WebTestRunner::WebTestDelegate::wasMockSpeechRecognitionAborted):
474         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
475         (WebTestRunner::TestRunner::TestRunner):
476         (WebTestRunner):
477         (WebTestRunner::TestRunner::addMockSpeechInputResult):
478         (WebTestRunner::TestRunner::setMockSpeechInputDumpRect):
479         (WebTestRunner::TestRunner::addMockSpeechRecognitionResult):
480         (WebTestRunner::TestRunner::setMockSpeechRecognitionError):
481         (WebTestRunner::TestRunner::wasMockSpeechRecognitionAborted):
482         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
483         (TestRunner):
484         * DumpRenderTree/chromium/WebViewHost.cpp:
485         (WebViewHost::addMockSpeechInputResult):
486         (WebViewHost::setMockSpeechInputDumpRect):
487         (WebViewHost::addMockSpeechRecognitionResult):
488         (WebViewHost::setMockSpeechRecognitionError):
489         (WebViewHost::wasMockSpeechRecognitionAborted):
490         * DumpRenderTree/chromium/WebViewHost.h:
491
492 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
493
494         [chromium] move notification related methods to TestRunner
495         https://bugs.webkit.org/show_bug.cgi?id=107269
496
497         Reviewed by Adam Barth.
498
499         * DumpRenderTree/chromium/DRTTestRunner.cpp:
500         (DRTTestRunner::DRTTestRunner):
501         * DumpRenderTree/chromium/DRTTestRunner.h:
502         (DRTTestRunner):
503         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
504         (WebTestDelegate):
505         (WebTestRunner::WebTestDelegate::grantWebNotificationPermission):
506         (WebTestRunner::WebTestDelegate::simulateLegacyWebNotificationClick):
507         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
508         (WebTestRunner::TestRunner::TestRunner):
509         (WebTestRunner):
510         (WebTestRunner::TestRunner::grantWebNotificationPermission):
511         (WebTestRunner::TestRunner::simulateLegacyWebNotificationClick):
512         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
513         (TestRunner):
514         * DumpRenderTree/chromium/WebViewHost.cpp:
515         (WebViewHost::grantWebNotificationPermission):
516         (WebViewHost::simulateLegacyWebNotificationClick):
517         * DumpRenderTree/chromium/WebViewHost.h:
518
519 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
520
521         [chromium] move geolocation related methods to TestRunner
522         https://bugs.webkit.org/show_bug.cgi?id=107267
523
524         Reviewed by Adam Barth.
525
526         * DumpRenderTree/chromium/DRTTestRunner.cpp:
527         (DRTTestRunner::DRTTestRunner):
528         * DumpRenderTree/chromium/DRTTestRunner.h:
529         (DRTTestRunner):
530         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
531         (WebTestRunner::WebTestDelegate::numberOfPendingGeolocationPermissionRequests):
532         (WebTestRunner::WebTestDelegate::setGeolocationPermission):
533         (WebTestRunner::WebTestDelegate::setMockGeolocationPosition):
534         (WebTestRunner::WebTestDelegate::setMockGeolocationPositionUnavailableError):
535         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
536         (WebTestRunner::TestRunner::TestRunner):
537         (WebTestRunner::TestRunner::numberOfPendingGeolocationPermissionRequests):
538         (WebTestRunner):
539         (WebTestRunner::TestRunner::setGeolocationPermission):
540         (WebTestRunner::TestRunner::setMockGeolocationPosition):
541         (WebTestRunner::TestRunner::setMockGeolocationPositionUnavailableError):
542         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
543         (TestRunner):
544         * DumpRenderTree/chromium/WebViewHost.cpp:
545         (WebViewHost::numberOfPendingGeolocationPermissionRequests):
546         (WebViewHost::setGeolocationPermission):
547         (WebViewHost::setMockGeolocationPosition):
548         (WebViewHost::setMockGeolocationPositionUnavailableError):
549         * DumpRenderTree/chromium/WebViewHost.h:
550
551 2013-01-19  Zan Dobersek  <zdobersek@igalia.com>
552
553         Unreviewed build fix for Qt WK2 after r140258.
554         Use the size_t type instead of unsigned for the variable
555         which holds the position of the first null character in the
556         console message.
557
558         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
559         (WTR::InjectedBundlePage::willAddMessageToConsole):
560
561 2013-01-19  Sheriff Bot  <webkit.review.bot@gmail.com>
562
563         Unreviewed, rolling out r140260.
564         http://trac.webkit.org/changeset/140260
565         https://bugs.webkit.org/show_bug.cgi?id=107387
566
567         breaks fast/text/hyphens.html, fast/text/hyphenate-* (but
568         nothing else) (Requested by thakis__ on #webkit).
569
570         * Scripts/update-webkit-chromium:
571
572 2013-01-19  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
573
574         Delegated scrolling: Assertion on attempt to show a CSS sticky element
575         https://bugs.webkit.org/show_bug.cgi?id=106890
576
577         Reviewed by Kenneth Rohde Christiansen.
578
579         Enabled fixed layout mode in WTR for 'fast/css/sticky' tests.
580
581         * WebKitTestRunner/TestInvocation.cpp:
582         (WTR::shouldUseFixedLayout):
583         (WTR):
584         (WTR::updateLayoutType):
585
586 2013-01-19  Nico Weber  <thakis@chromium.org>
587
588         Make ninja the default build system for build-webkit --chromium on mac
589         https://bugs.webkit.org/show_bug.cgi?id=106737
590
591         Reviewed by Eric Seidel.
592
593         * Scripts/update-webkit-chromium:
594
595 2013-01-19  Zan Dobersek  <zdobersek@igalia.com>
596
597         [WK2] svg/dom/fuzz-path-parser.html is failing
598         https://bugs.webkit.org/show_bug.cgi?id=107133
599
600         Reviewed by Alexey Proskuryakov.
601
602         Console messages can contain null characters before the end of string.
603         Appending such message to the StringBuilder as a WTFString appends the
604         complete string, including the null character. This later cuts off everything
605         after the null character when the string is being printed out to the test
606         output.
607
608         To avoid this, truncate the string up to the first null character. This
609         preserves the newline character appended immediately after this and
610         stops giving incorrect output.
611
612         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
613         (WTR::InjectedBundlePage::willAddMessageToConsole):
614
615 2013-01-19  Eric Seidel  <eric@webkit.org>
616
617         Update error regexps so that Parser/html-parser-srcdoc.html can "pass"
618         https://bugs.webkit.org/show_bug.cgi?id=107367
619
620         Reviewed by Ryosuke Niwa.
621
622         Using srcdoc instead of document.write changes the error output
623         ever so slightly.  Clearly we were already trying to ignore these
624         messages, just not succeeding.  This change makes this new test "pass" correctly.
625
626         * Scripts/webkitpy/performance_tests/perftest.py:
627         (PerfTest):
628
629 2013-01-18  Dan Winship  <danw@gnome.org>
630
631         REGRESSION (r139071): run-webkit-httpd complains at launch
632         https://bugs.webkit.org/show_bug.cgi?id=107310
633
634         Reviewed by Alexey Proskuryakov.
635
636         * Scripts/webkitperl/httpd.pm:
637         (getApacheVersion): use preferred perl syntax
638
639 2013-01-18  Julie Parent  <jparent@chromium.org>
640
641         Add back 'group' as a default cross dashboard parameter, but with null as its value.
642         https://bugs.webkit.org/show_bug.cgi?id=107336
643
644         We need to have 'group' listed as a parameter, else we never parse it,
645         as we only parse parameters with defaults.
646         
647         Reviewed by Ojan Vafai.
648
649         * TestResultServer/static-dashboards/dashboard_base.js:
650
651 2013-01-18  Emil A Eklund  <eae@chromium.org>
652
653         Update LayoutUnit rounding unit test
654         https://bugs.webkit.org/show_bug.cgi?id=107322
655
656         Reviewed by Levi Weintraub.
657         
658         Update the LayoutUnitRounding test to use fromFloatRound for
659         values that cannot accurately be represented as a LayoutUnit
660         (the default behavior is to floor the value to the nearest
661         LayoutUnit).
662
663         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
664         (TestWebKitAPI::TEST):
665
666 2013-01-18  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
667
668         VCSUtils.pm: Stop calling git repo-config.
669         https://bugs.webkit.org/show_bug.cgi?id=107294
670
671         Reviewed by Dirk Pranke.
672
673         The `repo-config' git command has been deprecated since early
674         2008, and recent versions have started warning it is deprecated.
675
676         Basically revert r27870 and use the `config' command all the time.
677
678         * Scripts/VCSUtils.pm:
679         (gitConfig):
680
681 2013-01-18  Levi Weintraub  <leviw@chromium.org>
682
683         LayoutUnit should round half consistently, not away from zero
684         https://bugs.webkit.org/show_bug.cgi?id=107208
685
686         Reviewed by Eric Seidel.
687
688         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp: Updating to reflect and
689         cover this change in rounding behavior.
690
691 2013-01-18  Tim Horton  <timothy_horton@apple.com>
692
693         [mac] DumpRenderTree/WebKitTestRunner should not participate in Exposé/Mission Control
694         https://bugs.webkit.org/show_bug.cgi?id=107234
695
696         Reviewed by Simon Fraser.
697
698         * DumpRenderTree/mac/DumpRenderTree.mm:
699         (createWebViewAndOffscreenWindow): Disable participation in Exposé via NSWindowCollectionBehaviorStationary.
700         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
701         (WTR::PlatformWebView::PlatformWebView): Ditto.
702
703 2013-01-18  Tim Horton  <timothy_horton@apple.com>
704
705         [mac] DumpRenderTree/WebKitTestRunner should disable NSBeep
706         https://bugs.webkit.org/show_bug.cgi?id=107251
707
708         Reviewed by Simon Fraser.
709
710         Disable NSBeep in DumpRenderTree and WebKitTestRunner using NSSound SPI.
711
712         * DumpRenderTree/mac/DumpRenderTree.mm:
713         (dumpRenderTree):
714         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
715         (WTR::InjectedBundle::platformInitialize):
716
717 2013-01-18  Martin Robinson  <mrobinson@igalia.com>
718
719         [GTK] Enable indexed database for development builds
720         https://bugs.webkit.org/show_bug.cgi?id=107299
721
722         Reviewed by Gustavo Noronha Silva.
723
724         * Scripts/webkitperl/FeatureList.pm: Enable indexed database by default
725         for GTK+ development builds.
726
727 2013-01-18  Dominic Mazzoni  <dmazzoni@google.com>
728
729         AX: Improve table-guessing heuristics
730         https://bugs.webkit.org/show_bug.cgi?id=107042
731
732         Reviewed by Chris Fleizach.
733
734         Implement parentElementCallback on Chromium to make testing easier.
735
736         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
737         (WebTestRunner::AccessibilityUIElement::parentElementCallback):
738
739 2013-01-18  Martin Robinson  <mrobinson@igalia.com>
740
741         [GTK] Add property for IndexedDB database path to WebKitGTK+
742         https://bugs.webkit.org/show_bug.cgi?id=106136
743
744         Reviewed by Gustavo Noronha Silva.
745
746         During testing, set the web database directory to DUMPRENDERTREE_TEMP
747         before falling back to the old default. This is necessary because
748         indexed database tests require that each DRT shard is using a different
749         IDB database location.
750
751         * DumpRenderTree/gtk/DumpRenderTree.cpp:
752         (temporaryDatabaseDirectory): Added this helper for getting the
753         database directory.
754         (setDefaultsToConsistentStateValuesForTesting): Use the new helper.
755
756 2013-01-18  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
757
758         [EFL][WK2] Enable API test InjectedBundleFrameHitTest on EFL
759         https://bugs.webkit.org/show_bug.cgi?id=107264
760
761         Reviewed by Laszlo Gombos.
762
763         Enable API test InjectedBundleFrameHitTest for hit-testing,
764         since it is now passing on both Debug and Release builds.
765
766         * TestWebKitAPI/CMakeLists.txt:
767         * TestWebKitAPI/PlatformEfl.cmake:
768
769 2013-01-18  Manuel Rego Casasnovas  <rego@igalia.com>
770
771         [GTK] Implement TestRunner::addUserScript
772         https://bugs.webkit.org/show_bug.cgi?id=107275
773
774         Reviewed by Philippe Normand.
775
776         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
777         (TestRunner::addUserScript): Implement method using
778         DumpRenderTreeSupportGtk::addUserScript.
779
780 2013-01-18  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
781
782         Unreviewed, add my secondary email address to the list.
783
784         * Scripts/webkitpy/common/config/committers.py:
785
786 2013-01-18  Dan Carney  <dcarney@google.com>
787
788         [chromium] move pointerlock functions to TestRunner library
789         https://bugs.webkit.org/show_bug.cgi?id=107241
790
791         Reviewed by Jochen Eisinger.
792
793         * DumpRenderTree/chromium/DRTTestRunner.cpp:
794         (DRTTestRunner::DRTTestRunner):
795         * DumpRenderTree/chromium/DRTTestRunner.h:
796         (DRTTestRunner):
797         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
798         (WebTestRunner::WebTestDelegate::didAcquirePointerLock):
799         (WebTestRunner::WebTestDelegate::didNotAcquirePointerLock):
800         (WebTestRunner::WebTestDelegate::didLosePointerLock):
801         (WebTestRunner::WebTestDelegate::setPointerLockWillRespondAsynchronously):
802         (WebTestRunner::WebTestDelegate::setPointerLockWillFailSynchronously):
803         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
804         (WebTestRunner::TestRunner::TestRunner):
805         (WebTestRunner):
806         (WebTestRunner::TestRunner::didAcquirePointerLock):
807         (WebTestRunner::TestRunner::didNotAcquirePointerLock):
808         (WebTestRunner::TestRunner::didLosePointerLock):
809         (WebTestRunner::TestRunner::setPointerLockWillRespondAsynchronously):
810         (WebTestRunner::TestRunner::setPointerLockWillFailSynchronously):
811         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
812         (TestRunner):
813         * DumpRenderTree/chromium/WebViewHost.h:
814         (WebViewHost):
815
816 2013-01-14  Dominik Röttsches  <dominik.rottsches@intel.com>
817
818         [EFL] Update freetype in jhbuild to 2.4.11 and activate subpixel layout
819         https://bugs.webkit.org/show_bug.cgi?id=106774
820
821         Reviewed by Martin Robinson.
822
823         In order to fix a long standing linespacing/font ascent & descent issue
824         we found that FreeType commit b0962ac34e660 solves that problem.
825         Let's update FreeType accordingly, but bump it to 2.4.11 due to the
826         maintainer recommending several security updates after that said commit.
827
828         Also, in order to avoid extra rebaselining, let's activate subpixel
829         layout at the same time.
830
831         * efl/jhbuild.modules: New freetype 2.4.11
832
833 2013-01-17  Xiaobo Wang  <xbwang@torchmobile.com.cn>
834
835         [BlackBerry] DRT - Accept http/file URL when running drt-launcher from command line
836         https://bugs.webkit.org/show_bug.cgi?id=107107
837         PR 282192
838
839         Reviewed by Rob Buis.
840
841         The DRT application will convert relative/absolute file path to
842         file://<real-file-path> format, so we only check for http/file prefix.
843
844         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
845         (BlackBerry::WebKit::isFullUrl):
846         (WebKit):
847         (BlackBerry::WebKit::DumpRenderTree::runCurrentTest):
848
849 2013-01-17  Frank Farzan  <frankf@chromium.org>
850
851         Flakiness dashboard: Add ChromiumFYI master
852         https://bugs.webkit.org/show_bug.cgi?id=107180
853
854         Reviewed by Ojan Vafai.
855
856         This is needed to enable Chrome Android bots
857         to upload results for instrumentation tests.
858
859         * TestResultServer/generate_builders_json.py:
860         (main):
861         * TestResultServer/static-dashboards/builders.jsonp:
862
863 2013-01-17  Frank Farzan  <frankf@chromium.org>
864
865         Add Chrome on Android instrumentation test types to flakiness dashboard
866         https://bugs.webkit.org/show_bug.cgi?id=106964
867
868         Reviewed by Ojan Vafai.
869
870         Specifically, add these test types:
871         
872          androidwebview_instrumentation_tests
873          chromiumtestshell_instrumentation_tests
874          contentshell_instrumentation_tests
875         
876         Also, add ChromiumFYI to the list of masters.
877
878         * TestResultServer/static-dashboards/builders.js:
879         (loadBuildersList):
880         * TestResultServer/static-dashboards/dashboard_base.js:
881         (currentBuilderGroupCategory):
882
883 2013-01-17  Tim 'mithro' Ansell  <mithro@mithis.com>
884
885         Fixing webkitpy's SCM unit tests.
886         https://bugs.webkit.org/show_bug.cgi?id=106429
887
888         Reviewed by Eric Seidel.
889
890         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
891         (SCMDetectorTest.test_detect_scm_system):
892         * Scripts/webkitpy/common/checkout/scm/git.py:
893         (Git.in_working_directory):
894         (Git.read_git_config):
895         (Git._assert_can_squash):
896         (Git.remote_branch_ref):
897         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
898         (GitSVNTest.test_commit_with_message_multiple_local_commits_always_squash):
899         (GitTestWithMock):
900         (GitTestWithMock.make_scm):
901         (GitTestWithMock.test_create_patch):
902         * Scripts/webkitpy/common/system/outputcapture.py:
903         (OutputCapture.assert_outputs):
904         (OutputCaptureTestCaseBase):
905         * Scripts/webkitpy/test/printer.py:
906         (Printer.configure):
907
908 2013-01-17  Julie Parent  <jparent@chromium.org>
909
910         Flakiness dashboard assumes there must be ToT tests
911         https://bugs.webkit.org/show_bug.cgi?id=107155
912
913         Remove group as a default parameter, since we can't actually know
914         the name of a group initially.  Instead, introduces 
915         currentBuilderGroupName which returns the current builder group
916         if it has been explicitly set, or picks the first one available
917         as a default. Allows us to remove some extra code tracking this
918         stuff as well.
919         
920         Reviewed by Ojan Vafai.
921
922         * TestResultServer/static-dashboards/dashboard_base.js:
923         (parseCrossDashboardParameters):
924         (currentBuilderGroupName):
925         (currentBuilderGroup):
926         * TestResultServer/static-dashboards/flakiness_dashboard.js:
927         (platformAndBuildType):
928         * TestResultServer/static-dashboards/loader.js:
929         (.):
930
931 2013-01-16  Ryosuke Niwa  <rniwa@webkit.org>
932
933         Remove NodeListsNodeData when it's no longer needed
934         https://bugs.webkit.org/show_bug.cgi?id=107074
935
936         Reviewed by Darin Adler.
937
938         Generalize the warning a little so that it's also ignored on PerformanceTests/DOM/TraverseChildNodes.html
939
940         * Scripts/webkitpy/performance_tests/perftest.py:
941         (PerfTest):
942
943 2013-01-17  Simon Fraser  <simon.fraser@apple.com>
944
945         Ref test images are upside-down in WebKit2
946         https://bugs.webkit.org/show_bug.cgi?id=105457
947
948         Reviewed by Sam "Speedy" Weinig.
949         
950         The bitmap context created in TestInvocation::dumpPixelsAndCompareWithExpected()
951         from the window snapshot contained a flipped copy of the image, causing all ref
952         and pixel images to be upside-down.
953
954         * WebKitTestRunner/cg/TestInvocationCG.cpp:
955         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
956
957 2013-01-17  Timothy Loh  <timloh@google.com>
958
959         Replaced specifiers variable with is_debug in builders.py
960         https://bugs.webkit.org/show_bug.cgi?id=107057
961
962         Reviewed by Dirk Pranke.
963
964         Replaced specifiers variable with is_debug in builders.py to simplify
965         Bug 106259. The other specifiers are not used elsewhere in the code.
966         Fixed builder_name_for_port_name to return a debug builder if we don't
967         have a release builder.
968
969         * Scripts/webkitpy/layout_tests/port/builders.py:
970         (all_port_names):
971         (builder_name_for_port_name):
972         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
973         (TestRebaselineExpectations.test_rebaseline_expectations):
974
975 2013-01-17  Martin Robinson  <mrobinson@igalia.com>
976
977         [GTK] Build with LevelDB when IndexedDB is enabled
978         https://bugs.webkit.org/show_bug.cgi?id=103220
979
980         Reviewed by Gustavo Noronha Silva.
981
982         * Scripts/webkitpy/style/checker.py: Do not style check the leveldb source code
983         as it does not conform to WebKit style.
984
985 2013-01-17  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
986
987         [EFL][WK2] Fix misuse of ASSERT on ecore_evas_init()
988         https://bugs.webkit.org/show_bug.cgi?id=107119
989
990         Reviewed by Laszlo Gombos.
991
992         Do not use ASSERT on ecore_evas_init(), since the expression inside
993         the macro compiles out of release builds.
994
995         * TestWebKitAPI/PlatformEfl.cmake: Enable API test UserMessage.
996         * TestWebKitAPI/efl/PlatformWebView.cpp:
997         (TestWebKitAPI::initEcoreEvas): Remove ASSERT on ecore_evas_init().
998
999 2013-01-17  Eugene Klyuchnikov  <eustas@chromium.org>
1000
1001         Web Inspector: Profiler: split "getProfile" to "getCPUProfile" and "loadHeapSnapshot"
1002         https://bugs.webkit.org/show_bug.cgi?id=104545
1003
1004         Reviewed by Yury Semikhatsky.
1005
1006         Adopt signature changes.
1007
1008         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
1009         (ProfilerAgent.getCPUProfile): Renamed.
1010         (ProfilerAgent.getHeapSnapshot): Added.
1011
1012 2013-01-17  Zan Dobersek  <zdobersek@igalia.com>
1013
1014         [GTK][EFL] NWRT should check that Xvfb is installed
1015         https://bugs.webkit.org/show_bug.cgi?id=71767
1016
1017         Reviewed by Dirk Pranke.
1018
1019         EFL and GTK ports now check that Xvfb is installed before running
1020         layout tests. The command line used to check whether Xvfb is present
1021         is a simple `which Xvfb` that should return 0 as the exit code upon
1022         success.
1023
1024         * Scripts/webkitpy/layout_tests/port/efl.py:
1025         (EflPort.show_results_html_file):
1026         (EflPort):
1027         (EflPort.check_sys_deps):
1028         * Scripts/webkitpy/layout_tests/port/gtk.py:
1029         (GtkPort.check_sys_deps):
1030         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
1031         (XvfbDriver):
1032         (XvfbDriver.check_xvfb):
1033
1034 2013-01-16  Alan Cutter  <alancutter@chromium.org>
1035
1036         sheriffbot can't tell me who "kov" is
1037         https://bugs.webkit.org/show_bug.cgi?id=106184
1038
1039         Reviewed by Eric Seidel.
1040
1041         Added glob style searching to the CommitterList contributors_by_search_string function so exact matches are favoured.
1042
1043         * Scripts/webkitpy/common/config/committers.py:
1044         (Account.matches_glob):
1045         (CommitterList.contributors_by_search_string):
1046         * Scripts/webkitpy/common/config/committers_unittest.py:
1047         (CommittersTest.test_committer_lookup):
1048         * Scripts/webkitpy/tool/bot/irc_command.py:
1049         (Whois):
1050
1051 2013-01-16  David Kilzer  <ddkilzer@apple.com>
1052
1053         Use xcrun to find path to make for Mac port
1054         <http://webkit.org/b/107091>
1055
1056         Reviewed by Dan Bernstein.
1057
1058         * Scripts/webkitpy/layout_tests/port/mac.py:
1059         (MacPort._build_java_test_support): Call self.make_command().
1060         (MacPort.make_command): Add.  Call xcrun_find().
1061         (MacPort.nm_command): Use self.xcrun_find().
1062         (MacPort.xcrun_find): Add.  Extract from nm_command().
1063
1064 2013-01-16  Sam Weinig  <sam@webkit.org>
1065
1066         Make debug-safari --target-web-process work again
1067         https://bugs.webkit.org/show_bug.cgi?id=107088
1068
1069         Reviewed by Anders Carlsson.
1070
1071         * Scripts/webkitdirs.pm:
1072         (execMacWebKitAppForDebugging):
1073         The shim is now called SecItemShim.
1074
1075 2013-01-16  Alan Cutter  <alancutter@chromium.org>
1076
1077         GCE build scripts don't take working directory into account when calling findzone.sh
1078         https://bugs.webkit.org/show_bug.cgi?id=106962
1079
1080         Reviewed by Adam Barth.
1081
1082         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
1083         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
1084         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
1085
1086 2013-01-16  Alan Cutter  <alancutter@chromium.org>
1087
1088         start-queue.sh does not pass remaining parameters correctly
1089         https://bugs.webkit.org/show_bug.cgi?id=107054
1090
1091         Reviewed by Adam Barth.
1092
1093         start-queue.sh now passes all remaining params to the webkit-patch command.
1094         Previously only one additional queue parameter could be sent.
1095
1096         * EWSTools/start-queue.sh:
1097
1098 2013-01-16  Xueqing Huang  <huangxueqing@baidu.com>
1099
1100         check-webkit-style script cannot running in Chinese windows.
1101         https://bugs.webkit.org/show_bug.cgi?id=87548
1102
1103         Reviewed by Darin Adler.
1104
1105         * Scripts/webkitpy/common/system/platforminfo.py:
1106         (PlatformInfo._win_version_tuple_from_cmd):
1107
1108 2013-01-16  Dirk Pranke  <dpranke@chromium.org>
1109
1110         Delete an extraneous print statement.
1111         https://bugs.webkit.org/show_bug.cgi?id=106562
1112
1113         Delete the extraneous print statement introduced in r139841.
1114
1115         * Scripts/webkitpy/layout_tests/views/printing.py:
1116         (Printer.print_found):
1117
1118 2013-01-16  Zan Dobersek  <zdobersek@igalia.com>
1119
1120         Please reinstate --pixel
1121         https://bugs.webkit.org/show_bug.cgi?id=101995
1122
1123         Reviewed by Dirk Pranke.
1124
1125         Add the '--pixel' and '--no-pixel' options for NRWT as aliases for
1126         the '--pixel-tests' (or '-p') and '--no-pixel-tests' options respectively.
1127         Some developers are still used to these options that were available in the ORWT.
1128
1129         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1130         (parse_args):
1131
1132 2013-01-16  Eric Seidel  <eric@webkit.org>
1133
1134         Remove --shark* support from sunspider/run-sunspider now that Shark is dead
1135         https://bugs.webkit.org/show_bug.cgi?id=99512
1136
1137         Reviewed by Darin Adler.
1138
1139         * Scripts/run-sunspider:
1140
1141 2013-01-16  Eric Seidel  <eric@webkit.org>
1142
1143         Remove webkitpy Visual Studio files, as core developers are not interested in maintaining them
1144         https://bugs.webkit.org/show_bug.cgi?id=106036
1145
1146         Reviewed by Darin Adler.
1147
1148         * Scripts/webkitpy/webkitpy.pyproj: Removed.
1149         * Scripts/webkitpy/webkitpy.sln: Removed.
1150
1151 2013-01-16  Chris Hopman  <cjhopman@chromium.org>
1152
1153         [Chromium] Remove hardcoded chromium_*.jar in gyp files
1154         https://bugs.webkit.org/show_bug.cgi?id=104049
1155
1156         Reviewed by Eric Seidel.
1157
1158         Targets with dependencies (direct/indirect) on a java target receive
1159         the chromium_*.jar paths in the variable input_jars_paths. Targets
1160         should use that rather than hardcoding where they think the jar will
1161         be. These can be passed directly to ant as INPUT_JARS_PATHS rather
1162         than as --jars to generate_native_test.py.
1163
1164         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1165         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
1166
1167 2013-01-16  Dan Carney  <dcarney@google.com>
1168
1169         [chromium] move setMockDeviceOrientation to TestRunner library
1170         https://bugs.webkit.org/show_bug.cgi?id=106895
1171
1172         Reviewed by Jochen Eisinger.
1173
1174         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1175         (DRTTestRunner::DRTTestRunner):
1176         * DumpRenderTree/chromium/DRTTestRunner.h:
1177         (DRTTestRunner):
1178         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1179         (WebKit):
1180         (WebTestRunner::WebTestDelegate::setDeviceOrientation):
1181         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1182         (WebTestRunner::TestRunner::TestRunner):
1183         (WebTestRunner::TestRunner::setMockDeviceOrientation):
1184         (WebTestRunner):
1185         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1186         (TestRunner):
1187         * DumpRenderTree/chromium/WebViewHost.cpp:
1188         (WebViewHost::setDeviceOrientation):
1189         * DumpRenderTree/chromium/WebViewHost.h:
1190         (WebViewHost):
1191
1192 2013-01-16  Jochen Eisinger  <jochen@chromium.org>
1193
1194         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
1195         https://bugs.webkit.org/show_bug.cgi?id=106904
1196
1197         Reviewed by Adam Barth.
1198
1199         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1200         (DRTTestRunner::DRTTestRunner):
1201         (DRTTestRunner::notifyDone):
1202         (DRTTestRunner::reset):
1203         * DumpRenderTree/chromium/DRTTestRunner.h:
1204         (DRTTestRunner):
1205         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1206         (WebTestRunner::WebTestDelegate::setDeviceScaleFactor):
1207         (WebTestRunner::WebTestDelegate::setFocus):
1208         (WebTestRunner::WebTestDelegate::setAcceptAllCookies):
1209         (WebTestRunner::WebTestDelegate::pathToLocalResource):
1210         (WebTestRunner::WebTestDelegate::setLocale):
1211         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1212         (WebTestRunner::TestRunner::TestRunner):
1213         (WebTestRunner::TestRunner::reset):
1214         (WebTestRunner::TestRunner::setAlwaysAcceptCookies):
1215         (WebTestRunner):
1216         (WebTestRunner::TestRunner::setWindowIsKey):
1217         (WebTestRunner::TestRunner::pathToLocalResource):
1218         (WebTestRunner::TestRunner::setBackingScaleFactor):
1219         (WebTestRunner::TestRunner::setPOSIXLocale):
1220         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1221         (WebTestRunner::TestRunner::taskList):
1222         (TestRunner):
1223         * DumpRenderTree/chromium/WebViewHost.cpp:
1224         (WebViewHost::setDeviceScaleFactor):
1225         (WebViewHost::setFocus):
1226         (WebViewHost::setAcceptAllCookies):
1227         (WebViewHost::pathToLocalResource):
1228         (WebViewHost::setLocale):
1229         * DumpRenderTree/chromium/WebViewHost.h:
1230         (WebViewHost):
1231
1232 2013-01-16  Sergio Villar Senin  <svillar@igalia.com>
1233
1234         [GTK] build-webkit fails if the jhbuild wrapper is not used
1235         https://bugs.webkit.org/show_bug.cgi?id=106769
1236
1237         Reviewed by Martin Robinson.
1238
1239         Return an empty array instead of "" in
1240         jhbuildWrapperPrefixIfNeeded() because otherwise that empty string
1241         will not be recognized as a valid command when the returned array
1242         is directly passed to perl's system() call.
1243
1244         * Scripts/webkitdirs.pm:
1245         (jhbuildWrapperPrefixIfNeeded):
1246
1247 2013-01-16  Jochen Eisinger  <jochen@chromium.org>
1248
1249         [chromium] add title text direction attribute to TestRunner
1250         https://bugs.webkit.org/show_bug.cgi?id=106907
1251
1252         Reviewed by Adam Barth.
1253
1254         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1255         (DRTTestRunner::DRTTestRunner):
1256         (DRTTestRunner::reset):
1257         * DumpRenderTree/chromium/DRTTestRunner.h:
1258         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1259         (WebTestRunner::WebTestRunner::setTitleTextDirection):
1260         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1261         (WebTestRunner::TestRunner::TestRunner):
1262         (WebTestRunner::TestRunner::reset):
1263         (WebTestRunner::TestRunner::setTitleTextDirection):
1264         (WebTestRunner):
1265         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1266         (TestRunner):
1267         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1268         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
1269         * DumpRenderTree/chromium/WebViewHost.cpp:
1270         (WebViewHost::didReceiveTitle):
1271
1272 2013-01-16  Jussi Kukkonen  <jussi.kukkonen@intel.com>
1273
1274         NRWT still confused about test count with --repeat-each and --iterations
1275         https://bugs.webkit.org/show_bug.cgi?id=106562
1276
1277         Reviewed by Dirk Pranke.
1278
1279         Fix the printed unique test count and skipped count. This
1280         seems to have broken in r127688 ("NRWT lies about the number
1281         of tests that it's skipping when used with --repeat-each").
1282
1283         Also add a test for print_found()
1284
1285         * Scripts/webkitpy/layout_tests/views/printing.py:
1286         (Printer.print_found):
1287         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1288         (Testprinter.test_details):
1289         (Testprinter):
1290         (Testprinter.test_found):
1291
1292 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
1293
1294         Unreviewed follow-up to r139769.
1295
1296         Note that omitting the WebKit1 code from the build now
1297         works for GTK as well.
1298
1299         * Scripts/build-webkit:
1300
1301 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
1302
1303         test-webkitpy: truncate output to the terminal width when necessary
1304         https://bugs.webkit.org/show_bug.cgi?id=106973
1305
1306         Reviewed by Ojan Vafai.
1307
1308         this implements the same logic for test-webkitpy that we have
1309         for run-webkit-tests (and ninja).
1310
1311         No tests written as this is exercised by running test-webkitpy itself.
1312
1313         * Scripts/webkitpy/test/printer.py:
1314         (Printer.configure):
1315         (Printer._test_line):
1316
1317 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
1318
1319         remove extraneous output in test-webkitpy
1320         https://bugs.webkit.org/show_bug.cgi?id=106971
1321
1322         Reviewed by Ojan Vafai.
1323
1324         We weren't ignoring or capturing the echoed output from
1325         these two tests, and getting noise in the logs as a result.
1326
1327         * Scripts/webkitpy/common/system/executive_unittest.py:
1328         (ExecutiveTest.test_auto_stringify_args):
1329         (ExecutiveTest.test_popen_args):
1330
1331 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
1332
1333         webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer.test_win32_start_and_stop is flaky
1334         https://bugs.webkit.org/show_bug.cgi?id=106974
1335
1336         Reviewed by Ryosuke Niwa.
1337
1338         I forgot to stub out the call to check to ensure that the ports were
1339         available, so this test could fail if something was listening on 8000 or
1340         8443 on the machine.
1341
1342         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1343         (TestHttpServer.test_win32_start_and_stop):
1344
1345 2013-01-15  Levi Weintraub  <leviw@chromium.org>
1346
1347         Unreviewed, rolling out r139792.
1348         http://trac.webkit.org/changeset/139792
1349         https://bugs.webkit.org/show_bug.cgi?id=106970
1350
1351         Broke the windows build.
1352
1353         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1354         (DRTTestRunner::DRTTestRunner):
1355         (DRTTestRunner::notifyDone):
1356         (DRTTestRunner::reset):
1357         (DRTTestRunner::setAlwaysAcceptCookies):
1358         (DRTTestRunner::setWindowIsKey):
1359         (DRTTestRunner::pathToLocalResource):
1360         (DRTTestRunner::setPOSIXLocale):
1361         (InvokeCallbackTask):
1362         (InvokeCallbackTask::InvokeCallbackTask):
1363         (InvokeCallbackTask::runIfValid):
1364         (DRTTestRunner::setBackingScaleFactor):
1365         * DumpRenderTree/chromium/DRTTestRunner.h:
1366         (DRTTestRunner):
1367         (DRTTestRunner::taskList):
1368         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1369         (WebTestRunner::WebTestDelegate::setDatabaseQuota):
1370         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1371         (WebTestRunner::TestRunner::TestRunner):
1372         (WebTestRunner::TestRunner::reset):
1373         (WebTestRunner::TestRunner::setDatabaseQuota):
1374         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1375         (TestRunner):
1376         * DumpRenderTree/chromium/WebViewHost.cpp:
1377         (WebViewHost::setPendingExtraData):
1378         (WebViewHost::setDeviceScaleFactor):
1379         * DumpRenderTree/chromium/WebViewHost.h:
1380         (WebViewHost):
1381
1382 2013-01-15  Ryosuke Niwa  <rniwa@webkit.org>
1383
1384         Build fix after r139357. The port name of MacWK2EWS should be 'mac-wk2'.
1385
1386         * Scripts/webkitpy/common/config/ports.py:
1387         (MacWK2Port):
1388
1389 2013-01-15  Alan Cutter  <alancutter@chromium.org>
1390
1391         Extend sheriffbot's "help" command to be able to get help on individual commands
1392         https://bugs.webkit.org/show_bug.cgi?id=106629
1393
1394         Reviewed by Eric Seidel.
1395
1396         Added a help command to sheriffbot.
1397         Fixed some style issues and ordered the commands alphabetically.
1398
1399         * Scripts/webkitpy/tool/bot/irc_command.py:
1400         (IRCCommand):
1401         (IRCCommand.execute):
1402         (IRCCommand.usage):
1403         (IRCCommand.help):
1404         (CreateBug):
1405         (CreateBug.execute):
1406         (Help):
1407         (Help.execute):
1408         (Help._post_command_help):
1409         (Hi):
1410         (Hi.execute):
1411         (Restart):
1412         (RollChromiumDEPS):
1413         (RollChromiumDEPS._parse_args):
1414         (RollChromiumDEPS._expand_irc_nickname):
1415         (RollChromiumDEPS.execute):
1416         (Rollout):
1417         (Rollout._extract_revisions):
1418         (Rollout.execute):
1419         (Sheriffs):
1420         (Sheriffs.execute):
1421         (Whois):
1422         (Whois.execute):
1423         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
1424         (IRCBotTest.test_help):
1425
1426 2013-01-15  Enrica Casucci  <enrica@apple.com>
1427
1428         Add a new set of WebKit2 APIs for text search and
1429         search results management.
1430         https://bugs.webkit.org/show_bug.cgi?id=106834.
1431         <rdar://problem/12597159>
1432
1433         Added new test for the new WebKit2 API for
1434         text search.
1435         
1436         Reviewed by Simon Fraser.
1437
1438         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1439         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm: Added.
1440
1441 2013-01-15  Levi Weintraub  <leviw@chromium.org>
1442
1443         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
1444         https://bugs.webkit.org/show_bug.cgi?id=106904
1445
1446         Reverting 139794. It broke the build. It appears that a header file,
1447         WebTextDirection.h, was left out.
1448
1449         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1450         (DRTTestRunner::DRTTestRunner):
1451         (DRTTestRunner::reset):
1452         * DumpRenderTree/chromium/DRTTestRunner.h:
1453         (DRTTestRunner::setTitleTextDirection):
1454         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1455         (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
1456         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1457         (WebTestRunner::TestRunner::TestRunner):
1458         (WebTestRunner::TestRunner::reset):
1459         (WebTestRunner::TestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
1460         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1461         (TestRunner):
1462         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1463         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
1464         * DumpRenderTree/chromium/WebViewHost.cpp:
1465         (WebViewHost::didReceiveTitle):
1466
1467 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
1468
1469         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
1470         https://bugs.webkit.org/show_bug.cgi?id=106904
1471
1472         Reviewed by Adam Barth.
1473
1474         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1475         (DRTTestRunner::DRTTestRunner):
1476         (DRTTestRunner::notifyDone):
1477         (DRTTestRunner::reset):
1478         * DumpRenderTree/chromium/DRTTestRunner.h:
1479         (DRTTestRunner):
1480         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1481         (WebTestRunner::WebTestDelegate::setDeviceScaleFactor):
1482         (WebTestRunner::WebTestDelegate::setFocus):
1483         (WebTestRunner::WebTestDelegate::setAcceptAllCookies):
1484         (WebTestRunner::WebTestDelegate::pathToLocalResource):
1485         (WebTestRunner::WebTestDelegate::setLocale):
1486         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1487         (WebTestRunner::TestRunner::TestRunner):
1488         (WebTestRunner::TestRunner::reset):
1489         (WebTestRunner::TestRunner::setAlwaysAcceptCookies):
1490         (WebTestRunner):
1491         (WebTestRunner::TestRunner::setWindowIsKey):
1492         (WebTestRunner::TestRunner::pathToLocalResource):
1493         (WebTestRunner::TestRunner::setBackingScaleFactor):
1494         (WebTestRunner::TestRunner::setPOSIXLocale):
1495         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1496         (WebTestRunner::TestRunner::taskList):
1497         (TestRunner):
1498         * DumpRenderTree/chromium/WebViewHost.cpp:
1499         (WebViewHost::setDeviceScaleFactor):
1500         (WebViewHost::setFocus):
1501         (WebViewHost::setAcceptAllCookies):
1502         (WebViewHost::pathToLocalResource):
1503         (WebViewHost::setLocale):
1504         * DumpRenderTree/chromium/WebViewHost.h:
1505         (WebViewHost):
1506
1507 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
1508
1509         Tests with WontFix expectation are (indirectly) skipped
1510         https://bugs.webkit.org/show_bug.cgi?id=105860
1511
1512         Reviewed by Dirk Pranke.
1513
1514         Only skip the WontFix expectation if there are no other layout test
1515         expectations (like Failure, ImageOnlyFailure) listed for the test.
1516         This makes it possible to run an expected failure for which there
1517         is no reason or interest to fix. There are some ports that would like
1518         to exercise this behavior as well as specific test cases that should use
1519         such expectations.
1520
1521         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1522         (TestExpectationParser._tokenize_line): Only add the SKIP modifier for a
1523         WONTFIX test if there are no expectations listed. The warning is adjusted
1524         to reflect the new behavior.
1525         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Add
1526         and adjust test cases for these changes.
1527         (ExpectationSyntaxTests.test_wontfix):
1528         (SemanticTests.test_skip_and_wontfix):
1529
1530 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
1531
1532         [chromium] add title text direction attribute to TestRunner
1533         https://bugs.webkit.org/show_bug.cgi?id=106907
1534
1535         Reviewed by Adam Barth.
1536
1537         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1538         (DRTTestRunner::DRTTestRunner):
1539         (DRTTestRunner::reset):
1540         * DumpRenderTree/chromium/DRTTestRunner.h:
1541         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1542         (WebTestRunner::WebTestRunner::setTitleTextDirection):
1543         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1544         (WebTestRunner::TestRunner::TestRunner):
1545         (WebTestRunner::TestRunner::reset):
1546         (WebTestRunner::TestRunner::setTitleTextDirection):
1547         (WebTestRunner):
1548         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1549         (TestRunner):
1550         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1551         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
1552         * DumpRenderTree/chromium/WebViewHost.cpp:
1553         (WebViewHost::didReceiveTitle):
1554
1555 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
1556
1557         nrwt: change the default # of locked shards on chromium_win to 1
1558         https://bugs.webkit.org/show_bug.cgi?id=106938
1559
1560         Reviewed by Eric Seidel.
1561
1562         It looks like LigHTTPd might be buggy or unstable if we are
1563         running multiple http tests in parallel; see
1564         http://code.google.com/p/chromium/issues/detail?id=169530 for more
1565         context as well. This change will stop running http tests in parallel
1566         and we can see if this fixes things.
1567
1568         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1569         (ChromiumWinPort.default_max_locked_shards):
1570         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1571         (ChromiumWinTest.test_path_to_image_diff):
1572         (ChromiumWinTest):
1573         (ChromiumWinTest.test_default_max_locked_shards):
1574
1575 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
1576
1577         [chromium] move WebDatabase related methods to TestRunner library
1578         https://bugs.webkit.org/show_bug.cgi?id=106905
1579
1580         Reviewed by Adam Barth.
1581
1582         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1583         (DRTTestRunner::DRTTestRunner):
1584         (DRTTestRunner::reset):
1585         * DumpRenderTree/chromium/DRTTestRunner.h:
1586         (DRTTestRunner):
1587         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1588         (WebTestRunner::WebTestDelegate::clearAllDatabases):
1589         (WebTestRunner::WebTestDelegate::setDatabaseQuota):
1590         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1591         (WebTestRunner::TestRunner::TestRunner):
1592         (WebTestRunner::TestRunner::reset):
1593         (WebTestRunner::TestRunner::clearAllDatabases):
1594         (WebTestRunner):
1595         (WebTestRunner::TestRunner::setDatabaseQuota):
1596         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1597         (TestRunner):
1598         * DumpRenderTree/chromium/WebViewHost.cpp:
1599         (WebViewHost::clearAllDatabases):
1600         (WebViewHost::setDatabaseQuota):
1601         * DumpRenderTree/chromium/WebViewHost.h:
1602         (WebViewHost):
1603
1604 2013-01-15  Tim 'mithro' Ansell  <mithro@mithis.com>
1605
1606         Renaming CleanWorkingDirectory step to DiscardLocalChanges to make
1607         functionality match the name.
1608         https://bugs.webkit.org/show_bug.cgi?id=106870
1609
1610         Reviewed by Adam Barth.
1611
1612         * Scripts/webkitpy/tool/commands/download.py:
1613         (Clean):
1614         (Update):
1615         (Build):
1616         (BuildAndTest):
1617         (CheckStyle):
1618         (BuildAttachment):
1619         (BuildAndTestAttachment):
1620         (AbstractPatchApplyingCommand):
1621         (ApplyWatchList):
1622         (AbstractPatchLandingCommand):
1623         (CreateRollout):
1624         * Scripts/webkitpy/tool/steps/__init__.py:
1625         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
1626         (CleanWorkingDirectory.options):
1627         (CleanWorkingDirectory.run):
1628         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
1629         * Scripts/webkitpy/tool/steps/discardlocalchanges.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
1630         * Scripts/webkitpy/tool/steps/discardlocalchanges_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py.
1631
1632 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
1633
1634         [Autotools] Add support for WebKit2-only builds
1635         https://bugs.webkit.org/show_bug.cgi?id=106889
1636
1637         Reviewed by Gustavo Noronha Silva.
1638
1639         * GNUmakefile.am: Only build the GtkLauncher and DumpRenderTree if building WebKit1.
1640         * Scripts/build-webkit: Pass along the information on whether to build WebKit1 when
1641         building the GTK port through build-webkit.
1642         * Scripts/webkitdirs.pm:
1643         (buildAutotoolsProject): Add the --disable-webkit1 configuration flag to the build
1644         arguments when not building WebKit1.
1645         (buildGtkProject): Pass along the information on whether to build WebKit1 when building
1646         through the Autotools build system.
1647
1648 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
1649
1650         [GTK] Enable Performance Timeline, Resource Timing, Navigation Timing features
1651         https://bugs.webkit.org/show_bug.cgi?id=106197
1652
1653         Reviewed by Martin Robinson.
1654
1655         * Scripts/webkitperl/FeatureList.pm: Add the configuration options for all three
1656         features. Enable them on GTK, meaning they will be enabled in development builds
1657         (i.e. when building with build-webkit).
1658
1659 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
1660
1661         [GTK] Enable CSS Image Resolution feature
1662         https://bugs.webkit.org/show_bug.cgi?id=99038
1663
1664         Reviewed by Gustavo Noronha Silva.
1665
1666         Enable the CSS Image Resolution feature for the development
1667         builds of the GTK port.
1668
1669         * Scripts/webkitperl/FeatureList.pm:
1670
1671 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
1672
1673         [GTK] Stop passing the unstable features flag to configure script when using build-webkit
1674         https://bugs.webkit.org/show_bug.cgi?id=106579
1675
1676         Reviewed by Gustavo Noronha Silva.
1677
1678         The --enable-unstable-features flag is not required to be passed anymore
1679         to the configure script as it was removed in r138252.
1680
1681         * Scripts/webkitdirs.pm:
1682         (buildAutotoolsProject):
1683
1684 2013-01-15  Tony Chang  <tony@chromium.org>
1685
1686         [chromium] Unreviewed, fix a bug where we don't properly shutdown lighttpd.
1687
1688         * Scripts/webkitpy/layout_tests/servers/http_server.py:
1689         (Lighttpd._check_and_kill): Pass /pid so taskkill.exe doesn't error out on us.
1690         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1691         (TestHttpServer.test_win32_start_and_stop):
1692
1693 2013-01-15  Joshua Bell  <jsbell@chromium.org>
1694
1695         Unreviewed. Adding Michael Pruett as contributor.
1696
1697         * Scripts/webkitpy/common/config/committers.py:
1698
1699 2013-01-15  Victor Carbune  <victor@rosedu.org>
1700
1701         Unreviewed. Update my email addresses.
1702
1703         * Scripts/webkitpy/common/config/committers.py:
1704
1705 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
1706
1707         [GTK] Waiting on the gdb process will lead to deadlock
1708         https://bugs.webkit.org/show_bug.cgi?id=106906
1709
1710         Reviewed by Philippe Normand.
1711
1712         Use communicate() rather than wait() on the Popen object that's running the gdb
1713         command. This avoids the deadlock that occurs on the GTK builders.
1714
1715         * Scripts/webkitpy/layout_tests/port/gtk.py:
1716         (GtkPort._get_gdb_output):
1717
1718 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
1719
1720         [GTK] Limit the number of frames printed out when backtracing with gdb
1721         https://bugs.webkit.org/show_bug.cgi?id=106901
1722
1723         Reviewed by Philippe Normand.
1724
1725         Printing an unlimited number of frames when dumping the gdb backtracing
1726         output can cause timeouts in the builders. This patch limits the number
1727         of frames that are printed out to 1024.
1728
1729         * Scripts/webkitpy/layout_tests/port/gtk.py:
1730         (GtkPort._get_gdb_output):
1731
1732 2013-01-15  Andras Becsi  <andras.becsi@digia.com>
1733
1734         [Qt] Fix ImageDiff's image format conversion
1735         https://bugs.webkit.org/show_bug.cgi?id=106880
1736
1737         Reviewed by Csaba Osztrogonác.
1738
1739         Besides actually doing the conversion this also silences the suspicious warning:
1740         "ignoring return value of function declared with warn_unused_result attribute".
1741
1742         * ImageDiff/qt/ImageDiff.cpp:
1743         (main): QImage::convertToFormat, contrary to the assumed behaviour, returns a
1744         copy of the image in the given format and does not alter the image itself.
1745
1746 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
1747
1748         [chromium] move remaining methods that just set a boolean flag to TestRunner library
1749         https://bugs.webkit.org/show_bug.cgi?id=106823
1750
1751         Reviewed by Darin Fisher.
1752
1753         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1754         (DRTTestRunner::DRTTestRunner):
1755         (DRTTestRunner::reset):
1756         * DumpRenderTree/chromium/DRTTestRunner.h:
1757         (DRTTestRunner):
1758         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1759         (WebTestRunner::WebTestRunner::shouldDumpBackForwardList):
1760         (WebTestRunner::WebTestRunner::deferMainResourceDataLoad):
1761         (WebTestRunner::WebTestRunner::shouldDumpSelectionRect):
1762         (WebTestRunner::WebTestRunner::testRepaint):
1763         (WebTestRunner::WebTestRunner::sweepHorizontally):
1764         (WebTestRunner::WebTestRunner::isPrinting):
1765         (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
1766         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1767         (WebTestRunner::TestRunner::TestRunner):
1768         (WebTestRunner::TestRunner::reset):
1769         (WebTestRunner::TestRunner::shouldDumpBackForwardList):
1770         (WebTestRunner):
1771         (WebTestRunner::TestRunner::deferMainResourceDataLoad):
1772         (WebTestRunner::TestRunner::shouldDumpSelectionRect):
1773         (WebTestRunner::TestRunner::testRepaint):
1774         (WebTestRunner::TestRunner::sweepHorizontally):
1775         (WebTestRunner::TestRunner::isPrinting):
1776         (WebTestRunner::TestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
1777         (WebTestRunner::TestRunner::dumpBackForwardList):
1778         (WebTestRunner::TestRunner::setDeferMainResourceDataLoad):
1779         (WebTestRunner::TestRunner::dumpSelectionRect):
1780         (WebTestRunner::TestRunner::repaintSweepHorizontally):
1781         (WebTestRunner::TestRunner::setPrinting):
1782         (WebTestRunner::TestRunner::setShouldStayOnPageAfterHandlingBeforeUnload):
1783         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1784         (TestRunner):
1785
1786 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
1787
1788         nrwt: stub out show_results_html for mock ports
1789         https://bugs.webkit.org/show_bug.cgi?id=106848
1790
1791         Reviewed by Ojan Vafai.
1792
1793         We were accidentally using the underlying ports'
1794         show_results_html_file() implementation, which would, unsurprisingly,
1795         fail in many cases (e.g., running mock-efl on the mac).
1796
1797         No test added since we don't generally add tests for the mock
1798         implementation.
1799
1800         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1801         (MockDRTPort.show_results_html_file):
1802
1803 2013-01-14  Tim 'mithro' Ansell  <mithro@mithis.com>
1804
1805         Changing clean_working_directory/clean_local_commits and related
1806         functions to have consistent naming.
1807
1808         https://bugs.webkit.org/show_bug.cgi?id=104198
1809
1810         Reviewed by Adam Barth.
1811
1812         * Scripts/webkitpy/common/checkout/scm/git.py:
1813         * Scripts/webkitpy/common/checkout/scm/scm.py:
1814         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
1815         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1816         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
1817         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
1818
1819 2013-01-14  Alan Cutter  <alancutter@chromium.org>
1820
1821         Fix EWS GCE build scripts to detect which zone is available
1822         https://bugs.webkit.org/show_bug.cgi?id=106524
1823
1824         Reviewed by Adam Barth.
1825
1826         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
1827         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
1828         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
1829         * EWSTools/GoogleComputeEngine/findzone.sh: Added.
1830
1831 2013-01-14  Tim 'mithro' Ansell  <mithro@mithis.com>
1832
1833         Adding an error string to AmbiguousCommitError.
1834         https://bugs.webkit.org/show_bug.cgi?id=106846
1835
1836         Reviewed by Adam Barth.
1837
1838         * Scripts/webkitpy/common/checkout/scm/git.py:
1839         (AmbiguousCommitError.__init__):
1840
1841 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
1842
1843         kill whole lighttpd process tree for chromium win
1844         https://bugs.webkit.org/show_bug.cgi?id=106838
1845
1846         Reviewed by Tony Chang.
1847
1848         Land a speculative fix for lighttpd.exe hanging on some chromium bots;
1849         I think a test is causing a httpd server child process to wedge and
1850         killing the parent httpd server process isn't sufficient to ensure
1851         that the children are also killed.
1852
1853         * Scripts/webkitpy/layout_tests/servers/http_server.py:
1854         (Lighttpd._check_and_kill):
1855         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1856         (TestHttpServer.test_start_cmd):
1857         (TestHttpServer):
1858         (TestHttpServer.test_win32_start_and_stop):
1859         (TestHttpServer.test_win32_start_and_stop.wait_for_action):
1860         (TestHttpServer.test_win32_start_and_stop.mock_returns):
1861         (TestHttpServer.test_win32_start_and_stop.mock_returns.return_value_thunk):
1862
1863 2013-01-14  Nico Weber  <thakis@chromium.org>
1864
1865         [chromium] Enable `update-webkit --chromium --ninja` on windows
1866         https://bugs.webkit.org/show_bug.cgi?id=106836
1867
1868         Reviewed by Eric Seidel.
1869
1870         After running this, build-webkit --chromium will use ninja to build.
1871         Apparently there are some minor issues with that still, so it's
1872         not quite ready for use yet.
1873
1874         * Scripts/webkitdirs.pm:
1875         (determineIsChromiumNinja):
1876         (buildChromium):
1877
1878 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
1879
1880         nrwt: use the same search path for baselines and TestExpectations on apple mac
1881         https://bugs.webkit.org/show_bug.cgi?id=105599
1882
1883         Reviewed by Ryosuke Niwa.
1884
1885         Bug 105583 revealed some confusion due to the fact that the Apple
1886         Mac port used a different list of directories to search for baselines
1887         and TestExpectations files (actually, pretty much every port does).
1888
1889         It seems like a good idea to use the same list for both by default, but
1890         making this happen will affect every port in slightly different ways, so
1891         we'll try this on the Apple Mac port first.
1892
1893         Note that the effective changes for this are that:
1894         1) The apple mac port will look in platform/wk2 for baselines where
1895         it didn't before (it will look after looking in mac-wk2 but before
1896         the non-wk2 dirs)
1897         2) The apple mac-snowleopard port will use the expectations in
1898         mac-lion as well as the expectations in mac-snowleopard, although
1899         I'm not even sure if mac-snowleopard is still supported ...
1900
1901         * Scripts/webkitpy/layout_tests/port/mac.py:
1902         (MacPort.default_baseline_search_path):
1903         (MacPort.expectations_files):
1904         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1905         (test_baseline_search_path):
1906
1907 2013-01-14  Dominic Mazzoni  <dmazzoni@google.com>
1908
1909         AX: Need to implement ColorWellRole
1910         https://bugs.webkit.org/show_bug.cgi?id=106756
1911
1912         Reviewed by Chris Fleizach.
1913
1914         Returns a string representation of the value of a color
1915         when the role is Color Well, to make it easy to write layout
1916         tests for color controls.
1917
1918         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
1919
1920 2013-01-14  Dominic Mazzoni  <dmazzoni@google.com>
1921
1922         Chromium: Error in AccessibilityUIElement::intValueGetterCallback
1923         https://bugs.webkit.org/show_bug.cgi?id=106682
1924
1925         Reviewed by Chris Fleizach.
1926
1927         Modify Chromium's DRT implementation of intValue to return a
1928         different value depending on the role.
1929
1930         There are actually platform-specific differences in what should
1931         be returned in the "value" of an object, so Chromium normally keeps
1932         these separate (i.e. valueForRange, headingLevel, hierarchicalLevel, etc.)
1933         but this is a fine simplification to make cross-platform tests easier.
1934
1935         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
1936         (WebTestRunner::AccessibilityUIElement::intValueGetterCallback):
1937
1938 2013-01-14  Jochen Eisinger  <jochen@chromium.org>
1939
1940         [chromium] move remaining methods to dump WebViewClient callbacks to TestRunner library
1941         https://bugs.webkit.org/show_bug.cgi?id=106785
1942
1943         Reviewed by Adam Barth.
1944
1945         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1946         (DRTTestRunner::DRTTestRunner):
1947         (DRTTestRunner::reset):
1948         * DumpRenderTree/chromium/DRTTestRunner.h:
1949         (DRTTestRunner):
1950         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
1951         (WebTestProxyBase):
1952         (WebTestRunner::WebTestProxy::setStatusText):
1953         (WebTestRunner::WebTestProxy::didStopLoading):
1954         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1955         (WebTestRunner::WebTestRunner::shouldDumpStatusCallbacks):
1956         (WebTestRunner::WebTestRunner::shouldDumpProgressFinishedCallback):
1957         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1958         (WebTestRunner::TestRunner::TestRunner):
1959         (WebTestRunner::TestRunner::reset):
1960         (WebTestRunner::TestRunner::shouldDumpStatusCallbacks):
1961         (WebTestRunner):
1962         (WebTestRunner::TestRunner::shouldDumpProgressFinishedCallback):
1963         (WebTestRunner::TestRunner::dumpWindowStatusChanges):
1964         (WebTestRunner::TestRunner::dumpProgressFinishedCallback):
1965         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1966         (TestRunner):
1967         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1968         (WebTestRunner::WebTestProxyBase::setStatusText):
1969         (WebTestRunner):
1970         (WebTestRunner::WebTestProxyBase::didStopLoading):
1971         * DumpRenderTree/chromium/WebViewHost.cpp:
1972         (WebViewHost::didStopLoading):
1973         * DumpRenderTree/chromium/WebViewHost.h:
1974         (WebViewHost):
1975
1976 2013-01-14  Andrey Lushnikov  <lushnikov@chromium.org>
1977
1978         Web Inspector: devtools front-end doesn't have focus in TestShell
1979         https://bugs.webkit.org/show_bug.cgi?id=106778
1980
1981         Reviewed by Pavel Feldman.
1982
1983         Focus devTools window after loadURL method.
1984
1985         * DumpRenderTree/chromium/TestShell.cpp:
1986         (TestShell::runFileTest):
1987
1988 2013-01-14  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1989
1990         [EFL][jhbuild] Build the GStreamer-related dependencies with the "configure" script
1991         https://bugs.webkit.org/show_bug.cgi?id=106573
1992
1993         Reviewed by Philippe Normand.
1994
1995         Similarly to what's been described in bug 106569, we're building
1996         from release tarballs, so there's no reason to regenerate the
1997         autoconf-related stuff with autogen.sh, especially since we might
1998         run into trouble with automake 1.13 and deprecated macros.
1999
2000         * efl/jhbuild.modules:
2001
2002 2013-01-14  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
2003
2004         [Qt] The Qt's configuration isn't honoured regarding the use of the system libpng and libjpeg
2005         https://bugs.webkit.org/show_bug.cgi?id=104909
2006
2007         Reviewed by Simon Hausmann.
2008
2009         To be able to build redistribuable binary packages, Qt's configure switches
2010         -qt-libpng and -qt-libjpeg are used to avoid having the binaries trying to
2011         dynamically link to optional system libraries.
2012         QtWebKit is doing its own configure checks for those libraries, thus adding a
2013         runtime dependency that might not be fulfilled if the packager's machine had
2014         those libraries while the user's machine won't.
2015
2016         Since in most cases where WebKit will want to use those system libraries, Qt will
2017         also be using them, remove these configure tests from WebKit.
2018
2019         * qmake/config.tests/libjpeg/libjpeg.cpp: Removed.
2020         * qmake/config.tests/libjpeg/libjpeg.pro: Removed.
2021         * qmake/config.tests/libpng/libpng.cpp: Removed.
2022         * qmake/config.tests/libpng/libpng.pro: Removed.
2023         * qmake/mkspecs/features/features.prf:
2024
2025 2013-01-09  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2026
2027         [EFL][jhbuild] Bump the EFL dependencies in jhbuild to 1.7.5.
2028         https://bugs.webkit.org/show_bug.cgi?id=106574
2029
2030         Reviewed by Laszlo Gombos.
2031
2032         Rely on a more recent stable release, which includes support for
2033         Lua 5.2 in Edje and other assorted minor fixes.
2034
2035         While here, also use the "configure" script to build the libraries
2036         instead of relying on autogen.sh, which is not really needed with
2037         a release tarball and may have problems with automake 1.13.
2038
2039         * efl/jhbuild.modules:
2040
2041 2013-01-14  Andrey Lushnikov  <lushnikov@chromium.org>
2042
2043         Web Inspector: fix DRT to deliver simulated events to devtools front-end
2044         https://bugs.webkit.org/show_bug.cgi?id=106650
2045
2046         Reviewed by Pavel Feldman.
2047
2048         Add separated m_devToolsTestInterfaces object to testShell which is
2049         bind to devTools webview.
2050
2051         * DumpRenderTree/chromium/TestShell.cpp:
2052         (TestShell::initialize):
2053         (TestShell::createMainWindow):
2054         (TestShell::~TestShell):
2055         (TestShell::showDevTools):
2056         (TestShell::resetTestController):
2057         (TestShell::bindJSObjectsToWindow):
2058         (TestShell::createNewWindow):
2059         * DumpRenderTree/chromium/TestShell.h:
2060         (TestShell):
2061
2062 2013-01-14  Alan Cutter  <alancutter@chromium.org>
2063
2064         Sheriffbot command aliases need test cases
2065         https://bugs.webkit.org/show_bug.cgi?id=106754
2066
2067         Reviewed by Eric Seidel.
2068
2069         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
2070         (SheriffBotTest.test_command_aliases):
2071
2072 2013-01-13  Alan Cutter  <alancutter@chromium.org>
2073
2074         Allow users to misspell the "sheriffs" command in sheriffbot
2075         https://bugs.webkit.org/show_bug.cgi?id=106628
2076
2077         Reviewed by Steve Block.
2078
2079         * Scripts/webkitpy/tool/bot/irc_command.py:
2080
2081 2013-01-13  Alan Cutter  <alancutter@chromium.org>
2082
2083         Make "gardeners" an alias for "sheriffs" in sherrifbot
2084         https://bugs.webkit.org/show_bug.cgi?id=106627
2085
2086         Reviewed by Eric Seidel.
2087
2088         * Scripts/webkitpy/tool/bot/irc_command.py:
2089
2090 2013-01-13  Dirk Pranke  <dpranke@chromium.org>
2091
2092         [chromium] webkitpy-test: executive.py stringify_args error on the release test bot
2093         https://bugs.webkit.org/show_bug.cgi?id=105380
2094
2095         Reviewed by Eric Seidel.
2096
2097         Fix a regression introduced in r137692 where we were double-encoding
2098         the arguments to popen(); this was only an issue on windows, where
2099         we would try to encode something to mbcs, then try to encode it
2100         to unicode as if the input as ascii.
2101
2102         * Scripts/webkitpy/common/system/executive.py:
2103         (Executive.run_command):
2104
2105 2013-01-13  Alan Cutter  <alancutter@chromium.org>
2106
2107         State who told sheriffbot to roll the Chromium deps and to what revision
2108         https://bugs.webkit.org/show_bug.cgi?id=106626
2109
2110         Reviewed by Eric Seidel.
2111
2112         Added optional argument to post-chromium-deps-roll so Sheriffbot can specify ChangeLog message.
2113
2114         * Scripts/webkitpy/tool/bot/irc_command.py:
2115         (RollChromiumDEPS._expand_irc_nickname):
2116         (RollChromiumDEPS.execute):
2117         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2118         (IRCCommandTest.test_roll_chromium_deps):
2119         * Scripts/webkitpy/tool/bot/sheriff.py:
2120         (Sheriff.post_chromium_deps_roll):
2121         * Scripts/webkitpy/tool/commands/roll.py:
2122         (RollChromiumDEPS._prepare_state):
2123         (PostChromiumDEPSRoll):
2124         (PostChromiumDEPSRoll._prepare_state):
2125         * Scripts/webkitpy/tool/commands/roll_unittest.py:
2126         (PostRollCommandsTest.test_prepare_state):
2127         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
2128         (PrepareChangeLogForDEPSRoll.run):
2129
2130 2013-01-13  Alan Cutter  <alancutter@chromium.org>
2131
2132         Add Alan Cutter as contributor
2133         https://bugs.webkit.org/show_bug.cgi?id=106747
2134
2135         Reviewed by Eric Seidel.
2136
2137         * Scripts/webkitpy/common/config/committers.py:
2138
2139 2013-01-13  Jonathan Liu  <net147@gmail.com>
2140
2141         Fix CONFIG missing link_pkgconfig on Windows
2142         https://bugs.webkit.org/show_bug.cgi?id=106647
2143
2144         Some libraries (e.g. libxslt, libxml2 and sqlite3) fail to link
2145         properly on Windows because they are added to PKGCONFIG but
2146         CONFIG does not contain link_pkgconfig.
2147
2148         This is because link_pkgconfig is added in unix/default_pre.prf
2149         which is only used for UNIX platforms. To fix this, move it to
2150         the general default_pre.prf.
2151
2152         Reviewed by Simon Hausmann.
2153
2154         * qmake/mkspecs/features/default_pre.prf:
2155         * qmake/mkspecs/features/unix/default_pre.prf:
2156
2157 2013-01-12  Nico Weber  <thakis@chromium.org>
2158
2159         nrwt/chromium: Don't prefer chromium over webkit build directories
2160         https://bugs.webkit.org/show_bug.cgi?id=105597
2161
2162         Reviewed by Dirk Pranke.
2163
2164         Rely on the new timestamp logic instead. Requested by dpranke in
2165         https://bugs.webkit.org/show_bug.cgi?id=105498
2166
2167         * Scripts/webkitpy/layout_tests/port/chromium.py:
2168         (ChromiumPort._static_build_path):
2169         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2170         (ChromiumLinuxPortTest.test_build_path):
2171         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2172         (ChromiumMacPortTest.test_build_path):
2173         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2174         (ChromiumWinTest.test_build_path):
2175
2176 2013-01-12  Nico Weber  <thakis@chromium.org>
2177
2178         Use ninja by default on Linux for build-webkit --chromium, bot edition
2179         https://bugs.webkit.org/show_bug.cgi?id=104434
2180
2181         Reviewed by Eric Seidel.
2182
2183         r139557 changed update-webkit to pick ninja by default on linux, but
2184         the bots run update-webkit-chromium directly so they didn't see this.
2185         Move the default for ninja into update-webkit-chromium so that it's
2186         picked up by the bots, and let update-webkit forward non-default
2187         options to there.
2188
2189         This way, the default is in one place only and both developers (who
2190         usually use update-webkit which then shells out to
2191         updat-webkit-chromium) and bots (which use update-webkit-chromium
2192         directly) see the same behavior.
2193
2194         * Scripts/update-webkit:
2195         * Scripts/update-webkit-chromium:
2196
2197 2013-01-12  Nico Weber  <thakis@chromium.org>
2198
2199         Make ninja the default build system on Linux for build-webkit --chromium
2200         https://bugs.webkit.org/show_bug.cgi?id=104434
2201
2202         Reviewed by Eric Seidel.
2203
2204         * Scripts/update-webkit:
2205
2206 2013-01-12  Alan Cutter  <alancutter@chromium.org>
2207
2208         Migrate the remaining bots in EC2 to Google Compute Engine
2209         https://bugs.webkit.org/show_bug.cgi?id=106005
2210
2211         Reviewed by Eric Seidel.
2212
2213         Updated bot scripts for launching feeder-queue, style-queue and sheriffbot on GCE.
2214
2215         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh: Copied from Tools/EWSTools/build-repo.sh.
2216         * EWSTools/boot.sh:
2217         * EWSTools/build-repo.sh:
2218         * EWSTools/start-queue.sh:
2219
2220 2013-01-12  Jochen Eisinger  <jochen@chromium.org>
2221
2222         [chromium] move inspector related methods to TestRunner library
2223         https://bugs.webkit.org/show_bug.cgi?id=106654
2224
2225         Reviewed by Adam Barth.
2226
2227         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2228         (DRTTestRunner::DRTTestRunner):
2229         * DumpRenderTree/chromium/DRTTestRunner.h:
2230         (DRTTestRunner):
2231         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2232         (WebTestRunner::WebTestDelegate::showDevTools):
2233         (WebTestRunner::WebTestDelegate::closeDevTools):
2234         (WebTestRunner::WebTestDelegate::evaluateInWebInspector):
2235         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2236         (WebTestRunner::TestRunner::TestRunner):
2237         (WebTestRunner::TestRunner::showWebInspector):
2238         (WebTestRunner):
2239         (WebTestRunner::TestRunner::closeWebInspector):
2240         (WebTestRunner::TestRunner::evaluateInWebInspector):
2241         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2242         (TestRunner):
2243         * DumpRenderTree/chromium/WebViewHost.cpp:
2244         (WebViewHost::showDevTools):
2245         (WebViewHost::closeDevTools):
2246         (WebViewHost::evaluateInWebInspector):
2247         * DumpRenderTree/chromium/WebViewHost.h:
2248         (WebViewHost):
2249
2250 2013-01-11  Julie Parent  <jparent@chromium.org>
2251
2252         Builder should not be a valid parameter for stats dashboard
2253         https://bugs.webkit.org/show_bug.cgi?id=106698
2254
2255         Reviewed by Dirk Pranke.
2256         
2257         Since builder is a dashboard specific parameter, dashboard_base
2258         should not be handling it in handleValidHashParameterWrapper, rather,
2259         each specific dashboard should in its handleValidHashParameter function.
2260     
2261         Note that the FIXME in dashboard_base about this was actually wrong -
2262         we don't want to move it to g_crossDashboardState, because it isn't
2263         actually cross dashboard state.
2264         
2265         In fact, flakiness and treemap have the code in 
2266         handleValidHashParameter, but it is currently dead code because 
2267         dashboard_base gets to it first.
2268         
2269         Added the proper handling to timeline_explorer, since builder is
2270         valid there.
2271
2272         * TestResultServer/static-dashboards/dashboard_base.js:
2273         * TestResultServer/static-dashboards/timeline_explorer.html:
2274
2275 2013-01-11  Ryosuke Niwa  <rniwa@webkit.org>
2276
2277         REGRESSION: buildbot mangles error messages with timestamps run-webkit-tests outputs
2278         https://bugs.webkit.org/show_bug.cgi?id=106688
2279
2280         Reviewed by Eric Seidel.
2281
2282         Update the regular expression used to strip the garbage at the beginning.
2283
2284         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2285         (RunWebKitTests.nrwt_log_message_regexp):
2286
2287 2013-01-11  Pratik Solanki  <psolanki@apple.com>
2288
2289         TestRunner leaks when running tests
2290         https://bugs.webkit.org/show_bug.cgi?id=106683
2291
2292         Reviewed by Simon Fraser.
2293
2294         Remove extra ref() that we missed out on deleting when refactoring window.layoutTestController
2295         to window.testRunner in r124705. This caused the TestRunner object to be leaked when running
2296         tests.
2297
2298         * DumpRenderTree/TestRunner.cpp:
2299         (TestRunner::makeWindowObject):
2300
2301 2013-01-11  Julie Parent  <jparent@chromium.org>
2302
2303         Dashboard Cleanup: Add isLoadingComplete to the loader.Loader object.
2304         https://bugs.webkit.org/show_bug.cgi?id=106247
2305
2306         Old code nulled out the loader instance when it completed loading and
2307         then later used the fact that it was null to determine if it had loaded
2308         or not.  This is not only unintuitive, but it also prevents using the
2309         loader object later on.
2310         
2311         Added new method, used it, added unit test for it.
2312         
2313         Reviewed by Dirk Pranke.
2314
2315         * TestResultServer/static-dashboards/dashboard_base.js:
2316         (resourceLoadingComplete):
2317         (handleLocationChange):
2318         * TestResultServer/static-dashboards/loader.js:
2319         (.):
2320         * TestResultServer/static-dashboards/loader_unittests.js:
2321
2322 2013-01-11  Ryosuke Niwa  <rniwa@webkit.org>
2323
2324         Try CRLF to LF change in r139407 again.
2325
2326         * BuildSlaveSupport/delete-stale-build-files:
2327         (main):
2328         (webkitBuildDirectory):
2329         * BuildSlaveSupport/kill-old-processes:
2330         (main):
2331
2332 2013-01-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2333
2334         [GTK] Disable the unit tests timeout when running from make check
2335         https://bugs.webkit.org/show_bug.cgi?id=106670
2336
2337         Reviewed by Philippe Normand.
2338
2339         * GNUmakefile.am: Pass --timeout=-1 to run-gtk-test.
2340
2341 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2342
2343         Yet another unreviewed fix after r139431.
2344
2345         * Scripts/run-launcher: Pass the arguments to `jhbuild-wrapper' in
2346         the correct order.
2347
2348 2013-01-11  Dan Carney  <dcarney@google.com>
2349
2350         [chromium] move some whitespace and resize related methods to TestRunner library
2351         https://bugs.webkit.org/show_bug.cgi?id=106655
2352
2353         Reviewed by Jochen Eisinger.
2354
2355         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2356         (DRTTestRunner::DRTTestRunner):
2357         * DumpRenderTree/chromium/DRTTestRunner.h:
2358         (DRTTestRunner):
2359         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2360         (WebKit):
2361         (WebTestRunner::WebTestDelegate::setClientWindowRect):
2362         (WebTestRunner::WebTestDelegate::setSelectTrailingWhitespaceEnabled):
2363         (WebTestRunner::WebTestDelegate::setSmartInsertDeleteEnabled):
2364         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2365         (WebTestRunner::TestRunner::TestRunner):
2366         (WebTestRunner::TestRunner::setSmartInsertDeleteEnabled):
2367         (WebTestRunner):
2368         (WebTestRunner::TestRunner::setSelectTrailingWhitespaceEnabled):
2369         (WebTestRunner::TestRunner::enableAutoResizeMode):
2370         (WebTestRunner::TestRunner::disableAutoResizeMode):
2371         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2372         (TestRunner):
2373         * DumpRenderTree/chromium/WebViewHost.cpp:
2374         (WebViewHost::setClientWindowRect):
2375         * DumpRenderTree/chromium/WebViewHost.h:
2376         (WebViewHost):
2377
2378 2013-01-11  Mario Sanchez Prada  <mario.prada@samsung.com>
2379
2380         Unreviewed. Update my e-mail addresses.
2381
2382         * Scripts/webkitpy/common/config/committers.py:
2383
2384 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2385
2386         Another unreviewed fix after r139431.
2387
2388         In a way, this is also a generic bug fix, since previously isEfl()
2389         would fail when called from run-efl-tests and we thus did not use
2390         jhbuild to run our tests. This now resulted in us calling
2391         "jhbuild-wrapper run" without specifying a platform.
2392
2393         * Scripts/run-efl-tests: Pass "--efl" to ARGV manually for isEfl()
2394         to work.
2395
2396 2013-01-11  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2397
2398         [Qt][WK1] Web Audio support
2399         https://bugs.webkit.org/show_bug.cgi?id=106651
2400
2401         Reviewed by Jocelyn Turcotte.
2402
2403         Implements support for dumping audio data in DumpRenderTree.
2404
2405         Adds WebAudio to toggleable features in QtTestBrowser.
2406
2407         Enables LEGACY_WEB_AUDIO. This feature is required for 2/3 of the web audio regression tests. It is enabled by default
2408         because it has no effect when WEB_AUDIO is not enabled. This combination matches the settings in FeatureList.pm.
2409
2410         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2411         (WebCore::DumpRenderTree::dump):
2412         * DumpRenderTree/qt/TestRunnerQt.cpp:
2413         (TestRunner::reset):
2414         (TestRunner::overridePreference):
2415         (TestRunner::setAudioData):
2416         * DumpRenderTree/qt/TestRunnerQt.h:
2417         (TestRunner::shouldDumpAsAudio):
2418         (TestRunner::audioData):
2419         (TestRunner):
2420         * QtTestBrowser/launcherwindow.cpp:
2421         (LauncherWindow::applyPrefs):
2422         (LauncherWindow::createChrome):
2423         (LauncherWindow::toggleWebAudio):
2424         * QtTestBrowser/launcherwindow.h:
2425         (WindowOptions::WindowOptions):
2426         (WindowOptions):
2427         (LauncherWindow):
2428         * qmake/mkspecs/features/features.prf:
2429         * qmake/mkspecs/features/features.pri:
2430
2431 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2432
2433         Unreviewed jhbuild-related fix after r139431.
2434
2435         * Scripts/webkitpy/layout_tests/port/efl.py:
2436         (EflPort.__init__): Pass a string to set_option_default(), since
2437         shlex.split() will be called on it later.
2438
2439 2013-01-11  Csaba Osztrogonác  <ossy@webkit.org>
2440
2441         Unreviewed typo fixes after r139431.
2442
2443         * Scripts/run-javascriptcore-tests:
2444
2445 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2446
2447         [jhbuild] Remove the "run-with-jhbuild" scripts.
2448         https://bugs.webkit.org/show_bug.cgi?id=106572
2449
2450         Reviewed by Martin Robinson.
2451
2452         Both ports which use jhbuild were mostly duplicating the
2453         `run-with-jhbuild' script in their own directories for no clear reason.
2454
2455         The script itself was just a thin wrapper around the `jhbuild-wrapper',
2456         so just start using that directly and get rid of a useless middle man.
2457
2458         Adjust scripts which called run-with-jhbuild to call jhbuild-wrapper
2459         instead.
2460
2461         * Scripts/run-javascriptcore-tests:
2462         * Scripts/run-launcher:
2463         * Scripts/webkitdirs.pm:
2464         (runAutogenForAutotoolsProjectIfNecessary):
2465         (buildAutotoolsProject):
2466         (jhbuildWrapperPrefixIfNeeded):
2467         (generateBuildSystemFromCMakeProject):
2468         (buildCMakeGeneratedProject):
2469         * Scripts/webkitpy/common/multiprocessing_bootstrap.py:
2470         (run):
2471         * Scripts/webkitpy/layout_tests/port/efl.py:
2472         (EflPort.__init__):
2473         (EflPort._image_diff_command):
2474         * efl/run-with-jhbuild: Removed.
2475         * gtk/run-with-jhbuild: Removed.
2476
2477 2013-01-11  Alan Cutter  <alancutter@chromium.org>
2478
2479         Allow arbitrary queue launch parameters in EWSTools/start-queue.sh
2480         https://bugs.webkit.org/show_bug.cgi?id=106636
2481
2482         Reviewed by Adam Barth.
2483
2484         This parameter will allow the bot boot script to use start-queue.sh and provide an IRC password for sheriffbot.
2485
2486         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
2487         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
2488         * EWSTools/screen-config:
2489         * EWSTools/start-queue.sh:
2490
2491 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
2492
2493         kill-old-processes and delete-stale-build-files use CRLF linebreaks
2494         https://bugs.webkit.org/show_bug.cgi?id=106622
2495
2496         Reviewed by Simon Fraser.
2497
2498         Use LF instead of CRLF in kill-old-processes and delete-stale-build-files.
2499         Also escape clang\+\+ correctly in kill-old-processes.
2500
2501         * BuildSlaveSupport/delete-stale-build-files:
2502         * BuildSlaveSupport/kill-old-processes:
2503
2504 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
2505
2506         Build fix after r139357. It was missing a comma.
2507
2508         * QueueStatusServer/model/queues.py:
2509         (Queue):
2510
2511 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
2512
2513         Fixing AuthenticationError when running test-webkitpy as a non-committer.
2514         https://bugs.webkit.org/show_bug.cgi?id=106420
2515
2516         Reviewed by Eric Seidel.
2517
2518         * Scripts/webkitpy/common/checkout/scm/git.py:
2519         (Git.push_local_commits_to_server):
2520         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2521         * Scripts/webkitpy/common/checkout/scm/svn.py:
2522         (SVNRepository):
2523         (SVNRepository.has_authorization_for_realm):
2524
2525 2013-01-10  Christophe Dumez  <christophe.dumez@intel.com>
2526
2527         [EFL][jhbuild] Use tarballs for gstreamer instead of git
2528         https://bugs.webkit.org/show_bug.cgi?id=106552
2529
2530         Reviewed by Laszlo Gombos.
2531
2532         Use tarballs for gstreamer instead of git in EFL's jhbuild
2533         to work around intermittent network issues on our build
2534         bots. Tarballs are fully cached and require no network
2535         operation if their checksum matches.
2536
2537         * efl/jhbuild.modules:
2538
2539 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
2540
2541         Add Mac WK2 EWS bots
2542         https://bugs.webkit.org/show_bug.cgi?id=106590
2543
2544         Reviewed by Adam Barth.
2545
2546         Added MacWK2EWS, and made myself a watcher for MacEWS and MacWK2EWS.
2547         Also add a deprecated MacWK2Port class.
2548
2549         * QueueStatusServer/model/queues.py:
2550         (Queue):
2551         * Scripts/webkitpy/common/config/ports.py:
2552         (DeprecatedPort.port):
2553         (MacWK2Port):
2554         (MacWK2Port.run_webkit_tests_command):
2555         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2556         (MacEWS):
2557         (MacWK2EWS):
2558         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2559         (_test_ewses):
2560
2561 2013-01-10  Dan Carney  <dcarney@google.com>
2562
2563         [chromium] move webpermissionclient related methods to TestRunner library
2564         https://bugs.webkit.org/show_bug.cgi?id=106548
2565
2566         Reviewed by Jochen Eisinger.
2567
2568         * DumpRenderTree/DumpRenderTree.gypi:
2569         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2570         (DRTTestRunner::DRTTestRunner):
2571         (DRTTestRunner::reset):
2572         * DumpRenderTree/chromium/DRTTestRunner.h:
2573         (DRTTestRunner):
2574         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2575         (WebTestRunner::WebTestDelegate::normalizeLayoutTestURL):
2576         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2577         (WebKit):
2578         (WebTestRunner::WebTestRunner::webPermissions):
2579         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2580         (WebTestRunner::TestRunner::TestRunner):
2581         (WebTestRunner::TestRunner::setDelegate):
2582         (WebTestRunner):
2583         (WebTestRunner::TestRunner::reset):
2584         (WebTestRunner::TestRunner::webPermissions):
2585         (WebTestRunner::TestRunner::dumpPermissionClientCallbacks):
2586         (WebTestRunner::TestRunner::setImagesAllowed):
2587         (WebTestRunner::TestRunner::setScriptsAllowed):
2588         (WebTestRunner::TestRunner::setStorageAllowed):
2589         (WebTestRunner::TestRunner::setPluginsAllowed):
2590         (WebTestRunner::TestRunner::setAllowDisplayOfInsecureContent):
2591         (WebTestRunner::TestRunner::setAllowRunningOfInsecureContent):
2592         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2593         (WebTestRunner):
2594         (TestRunner):
2595         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Renamed from Tools/DumpRenderTree/chromium/WebPermissions.cpp.
2596         (WebTestRunner):
2597         (WebTestRunner::WebPermissions::WebPermissions):
2598         (WebTestRunner::WebPermissions::~WebPermissions):
2599         (WebTestRunner::WebPermissions::allowImage):
2600         (WebTestRunner::WebPermissions::allowScriptFromSource):
2601         (WebTestRunner::WebPermissions::allowStorage):
2602         (WebTestRunner::WebPermissions::allowPlugins):
2603         (WebTestRunner::WebPermissions::allowDisplayingInsecureContent):
2604         (WebTestRunner::WebPermissions::allowRunningInsecureContent):
2605         (WebTestRunner::WebPermissions::setImagesAllowed):
2606         (WebTestRunner::WebPermissions::setScriptsAllowed):
2607         (WebTestRunner::WebPermissions::setStorageAllowed):
2608         (WebTestRunner::WebPermissions::setPluginsAllowed):
2609         (WebTestRunner::WebPermissions::setDisplayingInsecureContentAllowed):
2610         (WebTestRunner::WebPermissions::setRunningInsecureContentAllowed):
2611         (WebTestRunner::WebPermissions::setDelegate):
2612         (WebTestRunner::WebPermissions::setDumpCallbacks):
2613         (WebTestRunner::WebPermissions::reset):
2614         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Renamed from Tools/DumpRenderTree/chromium/WebPermissions.h.
2615         (WebTestRunner):
2616         (WebPermissions):
2617         * DumpRenderTree/chromium/TestShell.cpp:
2618         (TestShell::initialize):
2619         (TestShell::resetTestController):
2620         (TestShell::createNewWindow):
2621         * DumpRenderTree/chromium/TestShell.h:
2622         (TestShell):
2623         * DumpRenderTree/chromium/WebViewHost.cpp:
2624         (WebViewHost::normalizeLayoutTestURL):
2625         * DumpRenderTree/chromium/WebViewHost.h:
2626         (WebViewHost):
2627
2628 2013-01-10  Alan Cutter  <alancutter@chromium.org>
2629
2630         Split EWS tool cold-boot.sh into modular components
2631         https://bugs.webkit.org/show_bug.cgi?id=106527
2632
2633         Reviewed by Adam Barth.
2634
2635         Split cold-boot.sh script up into build-vm.sh, build-repo.sh and build-boot-cmd.sh.
2636         Updated GCE bot build scripts to match.
2637         Unable to test scripts directly as they depend on being in the repository to work!
2638
2639         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
2640         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
2641         * EWSTools/build-boot-cmd.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-chromium-ews.sh.
2642         * EWSTools/build-repo.sh: Copied from Tools/EWSTools/cold-boot.sh.
2643         * EWSTools/build-vm.sh: Renamed from Tools/EWSTools/cold-boot.sh.
2644
2645 2013-01-10  Julie Parent  <jparent@chromium.org>
2646
2647         Dashboard Cleanup: Do not generate the page if we are about to reload.
2648         https://bugs.webkit.org/show_bug.cgi?id=106584
2649
2650         Reviewed by Dirk Pranke.
2651
2652         Move the logic to determine if we should generate the page into
2653         parseParameters() since that is where we have the knowledge to
2654         determine it, and return that value to handleLocationChange, 
2655         rather than passing the changed parameters back to handleLocationChange
2656         and having it make the decision.
2657         
2658         This is logically equivalent, save one case: when we are about to do
2659         a reload, we know that there is no reason to generate the page.  Old
2660         code was causing an extra page generation in this case.
2661         
2662         * TestResultServer/static-dashboards/dashboard_base.js:
2663         (parseParameters):
2664         (handleLocationChange):
2665
2666 2013-01-10  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2667
2668         [jhbuild] Use the "configure" script to build glib
2669         https://bugs.webkit.org/show_bug.cgi?id=106569
2670
2671         Reviewed by Martin Robinson.
2672
2673         So far both EFL and GTK have been using autogen.sh to build glib.
2674         While that does work most of the time, it's not really needed since
2675         we are downloading and building stable releases from tarballs.
2676         Additionally, autogen.sh fails to work with automake 1.13 due to the
2677         usage of some macros that have been removed (this has already been
2678         fixed in glib master).
2679
2680         * efl/jhbuild.modules:
2681         * gtk/jhbuild.modules:
2682
2683 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
2684
2685         Changing tests to be consistent and use self.scm rather then recreating the scm object.
2686         (Missed a couple)
2687         https://bugs.webkit.org/show_bug.cgi?id=106536
2688
2689         Reviewed by Eric Seidel.
2690
2691         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2692
2693 2013-01-10  Tony Chang  <tony@chromium.org>
2694
2695         Speed up supplemental dependency computation
2696         https://bugs.webkit.org/show_bug.cgi?id=106503
2697
2698         Reviewed by Adam Barth.
2699
2700         Pass the IDL attributes file for generating the bindings in WebKitTestRunner.
2701
2702         * WebKitTestRunner/CMakeLists.txt:
2703
2704 2013-01-10  Zan Dobersek  <zandobersek@gmail.com>
2705
2706         Remove the ENABLE_ANIMATION_API feature define occurences
2707         https://bugs.webkit.org/show_bug.cgi?id=106544
2708
2709         Reviewed by Simon Fraser.
2710
2711         The Animation API code was removed in r137243. The ENABLE_ANIMATION_API
2712         feature define handling still lingers in various build systems and configurations
2713         but is of no use, so it should be removed.
2714
2715         * Scripts/webkitperl/FeatureList.pm:
2716         * qmake/mkspecs/features/features.pri:
2717
2718 2013-01-10  Carlos Garcia Campos  <cgarcia@igalia.com>
2719
2720         [GTK] Add support for loading web process extensions
2721         https://bugs.webkit.org/show_bug.cgi?id=105631
2722
2723         Reviewed by Gustavo Noronha Silva.
2724
2725         * MiniBrowser/gtk/GNUmakefile.am:
2726         * MiniBrowser/gtk/main.c:
2727         (main): Set WEBKIT_INJECTED_BUNDLE env var to use the injected
2728         bundle lib from build dir.
2729         * Scripts/webkitpy/style/checker.py: Add exceptions for GTK+ API
2730         located in WebProcess/InjectedBundle/API/gtk.
2731         * gtk/generate-gtkdoc:
2732         (get_webkit2_options): Scan also files in
2733         WebProcess/InjectedBundle/API/gtk to generate API docs.
2734         (get_webkit2_options.injected_bundle_src_path): Helper function to
2735         build paths in WebProcess/InjectedBundle/API/gtk.
2736
2737 2013-01-10  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2738
2739         [EFL][WK2] Writing immediately to created windows (open) fails
2740         https://bugs.webkit.org/show_bug.cgi?id=105276
2741
2742         Reviewed by Kenneth Rohde Christiansen.
2743
2744         Do not reset 'about:blank' url for the new pages in mini browser.
2745
2746         * MiniBrowser/efl/main.c:
2747         (window_create):
2748
2749 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
2750
2751         Changing tests to be consistent and use self.scm rather then recreating the scm object.
2752         https://bugs.webkit.org/show_bug.cgi?id=106536
2753
2754         Reviewed by Eric Seidel.
2755
2756         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2757
2758 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
2759
2760         Converting to unittest2 so we can use assertItemsEqual, making tests
2761         not dependent on order of items.
2762         https://bugs.webkit.org/show_bug.cgi?id=106532
2763
2764         Before:
2765         Ran 1733 tests in 38.385s
2766         FAILED (failures=1, errors=22)
2767
2768         After:
2769         Ran 1733 tests in 32.298s
2770         FAILED (failures=0, errors=22)
2771
2772         Reviewed by Eric Seidel.
2773
2774         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2775         * Scripts/webkitpy/thirdparty/__init__.py:
2776         (AutoinstallImportHook._install_unittest2):
2777
2778 2013-01-10  Christophe Dumez  <christophe.dumez@intel.com>
2779
2780         [EFL] Add gstreamer 1.0.5 to jhbuild
2781         https://bugs.webkit.org/show_bug.cgi?id=106178
2782
2783         Reviewed by Laszlo Gombos.
2784
2785         Add gstreamer 1.0.5 to EFL's jhbuild configuration.
2786
2787         * efl/jhbuild.modules:
2788
2789 2013-01-09  Alan Cutter  <alancutter@chromium.org>
2790
2791         Updated parameters in GCE build scripts so they now work.
2792         https://bugs.webkit.org/show_bug.cgi?id=106523
2793
2794         Reviewed by Adam Barth.
2795
2796         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
2797         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
2798         * EWSTools/cold-boot.sh:
2799
2800 2013-01-09  Mark Pilgrim  <pilgrim@chromium.org>
2801
2802         [Chromium] Remove some stray references to WebKitPlatformSupport.h in DumpRenderTree
2803         https://bugs.webkit.org/show_bug.cgi?id=106520
2804
2805         Reviewed by James Robinson.
2806
2807         Part of a larger refactoring series. See tracking bug 82948.
2808
2809         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
2810         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
2811
2812 2013-01-09  Julie Parent  <jparent@chromium.org>
2813
2814         Dashboard cleanup: Remove code for currentState and window.location.hash getting out of state
2815         https://bugs.webkit.org/show_bug.cgi?id=106514
2816
2817         This is old code, as these can no longer get out of sync.
2818         permmaLinkURLHash is generated from currentState, which is set only
2819         from the location.  The commment about how these can get out of sync
2820         refers to a function that no longer exists.
2821         
2822         Reviewed by Dirk Pranke.
2823
2824         * TestResultServer/static-dashboards/dashboard_base.js:
2825         (handleLocationChange):
2826
2827 2013-01-09  Julie Parent  <jparent@chromium.org>
2828
2829         Dashboard Cleanup: Reload the page as soon as we know we need to.
2830         https://bugs.webkit.org/show_bug.cgi?id=106515
2831
2832         No need to continue parsing all of the data once we know that
2833         we need to do a reload.
2834         
2835         Reviewed by Dirk Pranke.
2836
2837         * TestResultServer/static-dashboards/dashboard_base.js:
2838         (parseParameters):
2839
2840 2013-01-09  Eric Seidel  <eric@webkit.org>
2841
2842         run-perf-tests --chromium-android --profile should show symbols for the kernel
2843         https://bugs.webkit.org/show_bug.cgi?id=106498
2844
2845         Reviewed by Adam Barth.
2846
2847         Turns out this was easy, once I finally read the output from "perf report".
2848         It appears there may be a bug in "perf record" on android, as it complains
2849         about not being able to read from /proc/kallsyms even when
2850         /proc/sys/kernel/kptr_restrict is 0.  For now I've not bothered
2851         to keep /proc/sys/kernel/kptr_restrict as 0 during the actual record
2852         but rather just flip it to 0 long enough to grab the /proc/kallsyms
2853         and then flip it back to whatever the device had.
2854
2855         /proc/sys/kernel/kptr_restrict controls what /proc/kallsyms returns
2856         on Linux.  /proc/kallsyms contains a mapping of kernel addresses
2857         to symbol names.  Its world-readable, but will return all 0s if you
2858         don't have permission to see the kernel symbols.  kptr_restrict
2859         supports values 0, 1, 2.  Where 0 means "everyone can see the real symbols"
2860         1 is only a specific group, and 2 is "no one, not even root".
2861         By default kptr_restrict is 2 on Android it seems.
2862         More kptr_restrict docs: http://lwn.net/Articles/420403/
2863
2864         I also took this opportunity to clean up how the perf record command
2865         was built for use/display in AndroidPerf.profile_after_exit and
2866         change to always using long-form names for the arguments (to hopefully help readability).
2867
2868         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2869         (AndroidPerf.__init__):
2870         (profile_after_exit):
2871         (ChromiumAndroidDriver.__init__):
2872         (ChromiumAndroidDriver._update_kallsyms_cache):
2873         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
2874
2875 2013-01-09  Julie Parent  <jparent@chromium.org>
2876
2877         Dashboard cleanup: remove dead code.
2878         https://bugs.webkit.org/show_bug.cgi?id=106509
2879
2880         Reviewed by Dirk Pranke.
2881
2882         * TestResultServer/static-dashboards/dashboard_base.js:
2883         (parseParameters):
2884
2885 2013-01-09  Joanmarie Diggs  <jdiggs@igalia.com>
2886
2887         [GTK] accessibility/aria-labelledby-overrides-label.html requires a proper baseline
2888         https://bugs.webkit.org/show_bug.cgi?id=105638
2889
2890         Reviewed by Martin Robinson.
2891
2892         The test was failing for two reasons:
2893         - AccessibilityRenderObject::correspondingLabelForControlElement() was
2894           not ignoring the ARIA labelled-by property
2895         - AccessibilityController::accessibleElementById() was not implemented
2896
2897         Because getting an element by ID cannot be done in the UIProcess, the
2898         decision was made to expose the element's ID as an accessible attribute
2899         of the object.
2900
2901         In addition, fixing the bug in AccessibilityRenderObject made it possible
2902         to eliminate the Gtk platform-specific expectations for another test.
2903
2904         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2905         (childElementById): Added. Walks the tree looking for the AtkObject
2906         Attribute which exposes the HTML element's ID.
2907         (AccessibilityController::accessibleElementById): Implemented.
2908         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2909         (AccessibilityUIElement::title): Modified to print out "AXTitle: " even
2910         when there is no title, as is done with the Mac port.
2911         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2912         (WTR):
2913         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
2914         (WTR::childElementById): Added. Walks the tree looking for the AtkObject
2915         Attribute which exposes the HTML element's ID.
2916         (WTR):
2917         (WTR::AccessibilityController::accessibleElementById): Implemented.
2918         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2919         (WTR::AccessibilityUIElement::title): Modified to print out "AXTitle: "
2920         even when there is no title, as is done with the Mac port.
2921
2922 2013-01-09  Gregg Tavares  <gman@google.com>
2923
2924         Add Gregg Tavares as a committer
2925         https://bugs.webkit.org/show_bug.cgi?id=106492
2926
2927         Unreviewed.
2928
2929         * Scripts/webkitpy/common/config/committers.py:
2930
2931 2013-01-09  Roger Fong  <roger_fong@apple.com>
2932
2933         Enable seamless iFrames for Windows DRT.
2934         https://bugs.webkit.org/show_bug.cgi?id=106468.
2935
2936         Rubberstamped by Timothy Horton.
2937
2938         * DumpRenderTree/win/DumpRenderTree.cpp:
2939         (resetDefaultsToConsistentValues):
2940
2941 2013-01-09  Christophe Dumez  <christophe.dumez@intel.com>
2942
2943         [WK2] Implement eventSender.scheduleAsynchronousKeyDown
2944         https://bugs.webkit.org/show_bug.cgi?id=93979
2945
2946         Reviewed by Benjamin Poulain.
2947
2948         Implement eventSender.scheduleAsynchronousKeyDown() in
2949         WebKitTestRunner.
2950
2951         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2952         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2953         (WTR::createKeyDownMessageBody):
2954         (WTR::EventSendingController::keyDown):
2955         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
2956         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2957         (EventSendingController):
2958         * WebKitTestRunner/TestController.cpp:
2959         (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle):
2960         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2961         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2962         * WebKitTestRunner/TestController.h:
2963         (TestController):
2964
2965 2013-01-09  Jochen Eisinger  <jochen@chromium.org>
2966
2967         [chromium] move resource load callback dumping to TestRunner library
2968         https://bugs.webkit.org/show_bug.cgi?id=106449
2969
2970         Reviewed by Adam Barth.
2971
2972         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2973         (DRTTestRunner::DRTTestRunner):
2974         (DRTTestRunner::reset):
2975         * DumpRenderTree/chromium/DRTTestRunner.h:
2976         (DRTTestRunner):
2977         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2978         (WebKit):
2979         (WebTestRunner::WebTestDelegate::makeURLErrorDescription):
2980         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2981         (WebKit):
2982         (WebTestProxyBase):
2983         (WebTestRunner::WebTestProxy::assignIdentifierToRequest):
2984         (WebTestRunner::WebTestProxy::willRequestResource):
2985         (WebTestRunner::WebTestProxy::willSendRequest):
2986         (WebTestRunner::WebTestProxy::didReceiveResponse):
2987         (WebTestRunner::WebTestProxy::didFinishResourceLoad):
2988         (WebTestRunner::WebTestProxy::didFailResourceLoad):
2989         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2990         (WebTestRunner::WebTestRunner::shouldDumpResourceLoadCallbacks):
2991         (WebTestRunner::WebTestRunner::shouldDumpResourceRequestCallbacks):
2992         (WebTestRunner::WebTestRunner::shouldDumpResourceResponseMIMETypes):
2993         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2994         (WebTestRunner::TestRunner::TestRunner):
2995         (WebTestRunner::TestRunner::reset):
2996         (WebTestRunner::TestRunner::shouldDumpResourceLoadCallbacks):
2997         (WebTestRunner::TestRunner::shouldDumpResourceRequestCallbacks):
2998         (WebTestRunner::TestRunner::shouldDumpResourceResponseMIMETypes):
2999         (WebTestRunner):
3000         (WebTestRunner::TestRunner::dumpResourceLoadCallbacks):
3001         (WebTestRunner::TestRunner::dumpResourceRequestCallbacks):
3002         (WebTestRunner::TestRunner::dumpResourceResponseMIMETypes):
3003         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3004         (TestRunner):
3005         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3006         (WebTestRunner::WebTestProxyBase::reset):
3007         (WebTestRunner):
3008         (WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):
3009         (WebTestRunner::WebTestProxyBase::willRequestResource):
3010         (WebTestRunner::WebTestProxyBase::willSendRequest):
3011         (WebTestRunner::WebTestProxyBase::didReceiveResponse):
3012         (WebTestRunner::WebTestProxyBase::didFinishResourceLoad):
3013         (WebTestRunner::WebTestProxyBase::didFailResourceLoad):
3014         * DumpRenderTree/chromium/WebViewHost.cpp:
3015         (WebViewHost::willSendRequest):
3016         (WebViewHost::makeURLErrorDescription):
3017         (WebViewHost::reset):
3018         * DumpRenderTree/chromium/WebViewHost.h:
3019         (WebViewHost):
3020
3021 2013-01-09  Dan Carney  <dcarney@google.com>
3022
3023         [chromium] move dumpcreateview methods to testrunner library
3024         https://bugs.webkit.org/show_bug.cgi?id=106434
3025
3026         Reviewed by Adam Barth.
3027
3028         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3029         (DRTTestRunner::DRTTestRunner):
3030         (DRTTestRunner::reset):
3031         * DumpRenderTree/chromium/DRTTestRunner.h:
3032         (DRTTestRunner):
3033         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
3034         (WebTestRunner::WebTestRunner::shouldDumpCreateView):
3035         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3036         (WebTestRunner::TestRunner::TestRunner):
3037         (WebTestRunner::TestRunner::reset):
3038         (WebTestRunner::TestRunner::shouldDumpCreateView):
3039         (WebTestRunner):
3040         (WebTestRunner::TestRunner::dumpCreateView):
3041         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3042         (TestRunner):
3043
3044 2013-01-09  Csaba Osztrogonác  <ossy@webkit.org>
3045
3046         webkitpy cleanup: Merge additional_comment_text into comment_text
3047         https://bugs.webkit.org/show_bug.cgi?id=106421
3048
3049         Reviewed by Adam Barth.
3050
3051         * Scripts/webkitpy/common/config/committervalidator.py:
3052         (CommitterValidator.reject_patch_from_commit_queue):
3053         (CommitterValidator.reject_patch_from_review_queue):
3054         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3055         (Bugzilla.set_flag_on_attachment):
3056         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
3057         (MockBugzilla.set_flag_on_attachment):
3058         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3059         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3060         (AbstractEarlyWarningSystem._post_reject_message_on_bug):
3061         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3062
3063 2013-01-09  Mario Sanchez Prada  <mario.prada@samsung.com>
3064
3065         [GTK] Raise version of gdk-pixbuf in jhbuild up to 2.26.5
3066         https://bugs.webkit.org/show_bug.cgi?id=106464
3067
3068         Reviewed by Martin Robinson.
3069
3070         Current version in jhbuild.modules (2.26.0) is giving trouble to
3071         when trying to build WebKitGTK from scratch, due to a segmentation
3072         fault error in gdk-pixbuf-query-loader during the 'make'
3073         phase. Raising the version to 2.26.5 fixes this issue.
3074
3075         * gtk/jhbuild.modules: Version raised, checksums updated.
3076
3077 2013-01-09  János Badics  <jbadics@inf.u-szeged.hu>
3078
3079         [Qt][NRWT] Pass --timeout to DRT/WTR if a test is marked as SLOW.
3080         https://bugs.webkit.org/show_bug.cgi?id=90968.
3081
3082         Reviewed by Csaba Osztrogonác.
3083
3084         Added functionality in DRT and WTR to use any timeout value while running
3085         slow tests (eventually, any test). Now NRWT --time-out-ms determines the
3086         timeout value for the test. Added a flag in NRWT (supports_per_test_timeout)
3087         to indicate whether the current port supports setting timeout value
3088         per test (it's False by default; I enabled it only on Qt).
3089         Also corrected a typo in driver.py
3090
3091         * DumpRenderTree/DumpRenderTree.h:
3092         (TestCommand::TestCommand):
3093         (TestCommand):
3094         * DumpRenderTree/DumpRenderTreeCommon.cpp:
3095         (parseInputLine):
3096         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3097         (WebCore::DumpRenderTree::processLine):
3098         * Scripts/webkitpy/layout_tests/port/base.py:
3099         (Port.supports_per_test_timeout):
3100         * Scripts/webkitpy/layout_tests/port/driver.py:
3101         (Driver.run_test):
3102         (Driver._command_from_driver_input):
3103         * Scripts/webkitpy/layout_tests/port/qt.py:
3104         (QtPort.supports_per_test_timeout):
3105         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3106         (WTR::InjectedBundle::InjectedBundle):
3107         (WTR::InjectedBundle::didReceiveMessage):
3108         (WTR::InjectedBundle::beginTesting):
3109         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3110         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3111         (WTR::TestRunner::setCustomTimeout):
3112         (WTR):
3113         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3114         (TestRunner):
3115         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
3116         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
3117         * WebKitTestRunner/TestController.cpp:
3118         (WTR::TestController::TestController):
3119         (WTR::TestController::getCustomTimeout):
3120         (WTR):
3121         (WTR::TestCommand::TestCommand):
3122         (TestCommand):
3123         (WTR::parseInputLine):
3124         (WTR::TestController::runTest):
3125         (WTR::TestController::runUntil):
3126         * WebKitTestRunner/TestController.h:
3127         (TestController):
3128         * WebKitTestRunner/TestInvocation.cpp:
3129         (WTR::TestInvocation::TestInvocation):
3130         (WTR::TestInvocation::setCustomTimeout):
3131         (WTR):
3132         (WTR::TestInvocation::invoke):
3133         * WebKitTestRunner/TestInvocation.h:
3134         (TestInvocation):
3135
3136 2013-01-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3137
3138         Regression(r138681): Add HAVE(ACCESSIBILITY) guard to atk files
3139         https://bugs.webkit.org/show_bug.cgi?id=106290
3140
3141         Reviewed by Martin Robinson.
3142
3143         Some atk files don't use HAVE(ACCESSIBILITY). It might make build errors when
3144         the macro isn't enabled.
3145
3146         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3147
3148 2013-01-08  Martin Robinson  <mrobinson@igalia.com>
3149
3150         WebKitTestRunner needs support for setHandlesAuthenticationChallenges
3151         https://bugs.webkit.org/show_bug.cgi?id=103653
3152
3153         Reviewed by Anders Carlsson.
3154
3155         Implement setHandlesAuthenticationChallenges in the UIProcess by sending credentials
3156         and the enabled boolean to the UIProcess and then implementing the didReceiveAuthenticationChallengeInFrame
3157         client callback.
3158
3159         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Exposed the new TestRunner
3160         methods to the JavaScript API.
3161         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3162         (WTR::TestRunner::setHandlesAuthenticationChallenges): Added this callback for the JavaScript API.
3163         (WTR::TestRunner::setAuthenticationUsername): Ditto.
3164         (WTR::TestRunner::setAuthenticationPassword): Ditto.
3165         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3166         (TestRunner): Added new declarations for the above.
3167         * WebKitTestRunner/TestController.cpp:
3168         (WTR::TestController::createWebViewWithOptions): Hook up the new didReceiveSynchronousMessageFromInjectedBundle
3169         callback.
3170         (WTR::TestController::resetStateToConsistentValues): Reset the credentials and enabled boolean between tests.
3171         (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Handle the callback by using
3172         the authentication information passed from the InjectedBundle.
3173         * WebKitTestRunner/TestController.h:
3174         (WTR::TestController::setHandlesAuthenticationChallenges): Added setter to allow TestInvocation
3175         to communicate with the TestController.
3176         (WTR::TestController::setAuthenticationUsername): Ditto.
3177         (WTR::TestController::setAuthenticationPassword): Ditto.
3178         (TestController):
3179         * WebKitTestRunner/TestInvocation.cpp:
3180         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Handle the messages sending authentication
3181         information from the InjectedBundle.
3182         (WTR::TestInvocation::outputText): Added this method so that the TestController can output
3183         text to the TestInvocation text output.
3184         * WebKitTestRunner/TestInvocation.h:
3185         (TestInvocation): Added declaration for new method.
3186
3187 2013-01-08  Benjamin Poulain  <benjamin@webkit.org>
3188
3189         Add myself as a watcher for Web Geolocation
3190
3191         Unreviewed.
3192
3193         * Scripts/webkitpy/common/config/watchlist:
3194
3195 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
3196
3197         [webkitpy] Call setup_test_run method of the parent Port interface when method is called on subclasses
3198         https://bugs.webkit.org/show_bug.cgi?id=106364
3199
3200         Reviewed by Eric Seidel.
3201
3202         When the setup_test_run method is called on the subclasses of the base Port
3203         interface, the parent method should also be called via super(), despite the
3204         parent method not doing anything at the moment.
3205
3206         The according calls to super() are required in the ChromiumPort, EflPort
3207         and GtkPort implementations.
3208
3209         * Scripts/webkitpy/layout_tests/port/chromium.py:
3210         (ChromiumPort.setup_test_run):
3211         * Scripts/webkitpy/layout_tests/port/efl.py:
3212         (EflPort.setup_test_run):
3213         * Scripts/webkitpy/layout_tests/port/gtk.py:
3214         (GtkPort.setup_test_run):
3215
3216 2013-01-08  Julie Parent  <jparent@chromium.org>
3217
3218         Dashboard cleanup: Remove globals g_buildersThatFailedToLoad and g_staleBuilders
3219         https://bugs.webkit.org/show_bug.cgi?id=106356
3220
3221         g_buildersThatFailedToLoad and g_staleBuilders were globals defined in
3222         dashboard_base, assigned by Loader, and used only by dashboard_base to
3223         create error messages.  Moved the variables to be privates on the Loader
3224         object, moved error message creation to _getLoadingErrorMessages on the
3225         Loader object, and now pass the errors back to dashboard base via the
3226         resourceLoadingComplete callback.
3227         
3228         Also removed the now unused clearError function, it was only being used
3229         by unit tests to clean up global state.
3230         
3231         Reviewed by Dirk Pranke.
3232
3233         * TestResultServer/static-dashboards/dashboard_base.js:
3234         (resourceLoadingComplete):
3235         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3236         * TestResultServer/static-dashboards/loader.js:
3237         (.):
3238         * TestResultServer/static-dashboards/loader_unittests.js:
3239
3240 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
3241
3242         [EFL][GTK] Make the PulseAudioSanitizer an object on the EflPort, GtkPort
3243         https://bugs.webkit.org/show_bug.cgi?id=106354
3244
3245         Reviewed by Eric Seidel.
3246
3247         Put the PulseAudioSanitizer object on the EflPort and GtkPort interfaces
3248         instead of those two inheriting from it. Also add a mock object of the
3249         sanitizer that's used in unit tests.
3250
3251         * Scripts/webkitpy/layout_tests/port/efl.py:
3252         (EflPort):
3253         (EflPort.__init__):
3254         (EflPort.setup_test_run):
3255         (EflPort.clean_up_test_run):
3256         * Scripts/webkitpy/layout_tests/port/efl_unittest.py: Also correct the
3257         importing order.
3258         (EflPortTest.make_port): Put a mock PulseAudioSanitizer on the instance.
3259         * Scripts/webkitpy/layout_tests/port/gtk.py:
3260         (GtkPort):
3261         (GtkPort.__init__):
3262         (GtkPort.setup_test_run):
3263         (GtkPort.clean_up_test_run):
3264         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py: Also correct the
3265         importing order.
3266         (GtkPortTest.make_port): Put a mock PulseAudioSanitizer on the instance.
3267         * Scripts/webkitpy/layout_tests/port/pulseaudio_sanitizer.py:
3268         (PulseAudioSanitizer.unload_pulseaudio_module): Stylize the method as public.
3269         (PulseAudioSanitizer.restore_pulseaudio_module): Ditto.
3270         * Scripts/webkitpy/layout_tests/port/pulseaudio_sanitizer_mock.py: Added.
3271         (PulseAudioSanitizerMock): A simple mock interface for PulseAudioSanitizer.
3272         (PulseAudioSanitizerMock.unload_pulseaudio_module):
3273         (PulseAudioSanitizerMock.restore_pulseaudio_module):
3274
3275 2013-01-08  Jochen Eisinger  <jochen@chromium.org>
3276
3277         [chromium] move dumpFrameLoadCallbacks and friends to the TestRunner library
3278         https://bugs.webkit.org/show_bug.cgi?id=106324
3279
3280         Reviewed by Adam Barth.
3281
3282         Since the frame load callbacks are part of the WebFrameClient, the
3283         WebTestProxy is now intercepting both WebViewClient and WebFrameClient
3284         methods.
3285
3286         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3287         (DRTTestRunner::DRTTestRunner):
3288         (DRTTestRunner::reset):
3289         * DumpRenderTree/chromium/DRTTestRunner.h:
3290         (DRTTestRunner):
3291         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3292         (WebTestInterfaces):
3293         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3294         (WebKit):
3295         (WebTestProxyBase):
3296         (WebTestRunner):
3297         (WebTestRunner::WebTestProxy::WebTestProxy):
3298         (WebTestProxy):
3299         (WebTestRunner::WebTestProxy::didInvalidateRect):
3300         (WebTestRunner::WebTestProxy::didScrollRect):
3301         (WebTestRunner::WebTestProxy::scheduleComposite):
3302         (WebTestRunner::WebTestProxy::scheduleAnimation):
3303         (WebTestRunner::WebTestProxy::setWindowRect):
3304         (WebTestRunner::WebTestProxy::show):
3305         (WebTestRunner::WebTestProxy::didAutoResize):
3306         (WebTestRunner::WebTestProxy::postAccessibilityNotification):
3307         (WebTestRunner::WebTestProxy::startDragging):
3308         (WebTestRunner::WebTestProxy::shouldBeginEditing):
3309         (WebTestRunner::WebTestProxy::shouldEndEditing):
3310         (WebTestRunner::WebTestProxy::shouldInsertNode):
3311         (WebTestRunner::WebTestProxy::shouldInsertText):
3312         (WebTestRunner::WebTestProxy::shouldChangeSelectedRange):
3313         (WebTestRunner::WebTestProxy::shouldDeleteRange):
3314         (WebTestRunner::WebTestProxy::shouldApplyStyle):
3315         (WebTestRunner::WebTestProxy::didBeginEditing):
3316         (WebTestRunner::WebTestProxy::didChangeSelection):
3317         (WebTestRunner::WebTestProxy::didChangeContents):
3318         (WebTestRunner::WebTestProxy::didEndEditing):
3319         (WebTestRunner::WebTestProxy::registerIntentService):
3320         (WebTestRunner::WebTestProxy::dispatchIntent):
3321         (WebTestRunner::WebTestProxy::willPerformClientRedirect):
3322         (WebTestRunner::WebTestProxy::didCancelClientRedirect):
3323         (WebTestRunner::WebTestProxy::didStartProvisionalLoad):
3324         (WebTestRunner::WebTestProxy::didReceiveServerRedirectForProvisionalLoad):
3325         (WebTestRunner::WebTestProxy::didFailProvisionalLoad):
3326         (WebTestRunner::WebTestProxy::didCommitProvisionalLoad):
3327         (WebTestRunner::WebTestProxy::didReceiveTitle):
3328         (WebTestRunner::WebTestProxy::didFinishDocumentLoad):
3329         (WebTestRunner::WebTestProxy::didHandleOnloadEvents):
3330         (WebTestRunner::WebTestProxy::didFailLoad):
3331         (WebTestRunner::WebTestProxy::didFinishLoad):
3332         (WebTestRunner::WebTestProxy::didChangeLocationWithinPage):
3333         (WebTestRunner::WebTestProxy::didDisplayInsecureContent):
3334         (WebTestRunner::WebTestProxy::didRunInsecureContent):
3335         (WebTestRunner::WebTestProxy::didDetectXSS):
3336         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
3337         (WebTestRunner::WebTestRunner::setTestIsRunning):
3338         (WebTestRunner::WebTestRunner::shouldDumpFrameLoadCallbacks):
3339         (WebTestRunner::WebTestRunner::setShouldDumpFrameLoadCallbacks):
3340         (WebTestRunner::WebTestRunner::shouldDumpUserGestureInFrameLoadCallbacks):
3341         (WebTestRunner::WebTestRunner::stopProvisionalFrameLoads):
3342         (WebTestRunner::WebTestRunner::shouldDumpTitleChanges):
3343         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3344         (WebTestRunner::TestRunner::TestRunner):
3345         (WebTestRunner::TestRunner::reset):
3346         (WebTestRunner::TestRunner::setTestIsRunning):
3347         (WebTestRunner):
3348         (WebTestRunner::TestRunner::shouldDumpFrameLoadCallbacks):
3349         (WebTestRunner::TestRunner::setShouldDumpFrameLoadCallbacks):
3350         (WebTestRunner::TestRunner::shouldDumpUserGestureInFrameLoadCallbacks):
3351         (WebTestRunner::TestRunner::stopProvisionalFrameLoads):
3352         (WebTestRunner::TestRunner::shouldDumpTitleChanges):
3353         (WebTestRunner::TestRunner::dumpFrameLoadCallbacks):
3354         (WebTestRunner::TestRunner::dumpUserGestureInFrameLoadCallbacks):
3355         (WebTestRunner::TestRunner::setStopProvisionalFrameLoads):
3356         (WebTestRunner::TestRunner::dumpTitleChanges):
3357         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3358         (TestRunner):
3359         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3360         (WebTestInterfaces::Internal):
3361         (WebTestRunner::WebTestInterfaces::Internal::webView):
3362         (WebTestRunner::WebTestInterfaces::Internal::Internal):
3363         (WebTestRunner::WebTestInterfaces::Internal::setWebView):
3364         (WebTestRunner):
3365         (WebTestRunner::WebTestInterfaces::Internal::setTestIsRunning):
3366         (WebTestRunner::WebTestInterfaces::setWebView):
3367         (WebTestRunner::WebTestInterfaces::setTestIsRunning):
3368         (WebTestRunner::WebTestInterfaces::webView):
3369         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3370         (WebTestRunner::WebTestProxyBase::willPerformClientRedirect):
3371         (WebTestRunner):
3372         (WebTestRunner::WebTestProxyBase::didCancelClientRedirect):
3373         (WebTestRunner::WebTestProxyBase::didStartProvisionalLoad):
3374         (WebTestRunner::WebTestProxyBase::didReceiveServerRedirectForProvisionalLoad):
3375         (WebTestRunner::WebTestProxyBase::didFailProvisionalLoad):
3376         (WebTestRunner::WebTestProxyBase::didCommitProvisionalLoad):
3377         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
3378         (WebTestRunner::WebTestProxyBase::didFinishDocumentLoad):
3379         (WebTestRunner::WebTestProxyBase::didHandleOnloadEvents):
3380         (WebTestRunner::WebTestProxyBase::didFailLoad):
3381         (WebTestRunner::WebTestProxyBase::didFinishLoad):
3382         (WebTestRunner::WebTestProxyBase::didChangeLocationWithinPage):
3383         (WebTestRunner::WebTestProxyBase::didDisplayInsecureContent):
3384         (WebTestRunner::WebTestProxyBase::didRunInsecureContent):
3385         (WebTestRunner::WebTestProxyBase::didDetectXSS):
3386         * DumpRenderTree/chromium/TestShell.cpp:
3387         (TestShell::runFileTest):
3388         (TestShell::testFinished):
3389         * DumpRenderTree/chromium/TestShell.h:
3390         (TestShell):
3391         * DumpRenderTree/chromium/WebViewHost.cpp:
3392         (WebViewHost::didStartProvisionalLoad):
3393         (WebViewHost::didReceiveServerRedirectForProvisionalLoad):
3394         (WebViewHost::didFailProvisionalLoad):
3395         (WebViewHost::didCommitProvisionalLoad):
3396         (WebViewHost::didReceiveTitle):
3397         (WebViewHost::didFailLoad):
3398         (WebViewHost::didFinishLoad):
3399         * DumpRenderTree/chromium/WebViewHost.h:
3400         (WebViewHost):
3401
3402 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
3403
3404         [GTK] Lower the default timeout value for WebKitTestRunner
3405         https://bugs.webkit.org/show_bug.cgi?id=106353
3406
3407         Reviewed by Dirk Pranke.
3408
3409         The default timeout value for WebKitTestRunner should be lowered.
3410         The current value (80 seconds) is irrational and just leads to producing
3411         text failures for layout tests that genuinely time out. This just leads
3412         to more deviation from the GTK WK1 port in terms of test expectations.
3413
3414         The value used is the same as when running the DumpRenderTree, that's
3415         6 seconds in release builds and 12 seconds in debug builds.
3416
3417         * Scripts/webkitpy/layout_tests/port/gtk.py:
3418         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3419         (GtkPortTest.test_default_timeout_ms):
3420
3421 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
3422
3423         test-webkitpy shows failure output on my linux box
3424         https://bugs.webkit.org/show_bug.cgi?id=101261
3425
3426         Reviewed by Eric Seidel.
3427
3428         Mock out the PulseAudioSanitizer methods when creating testing instances
3429         of EflPort and GtkPort interfaces in unit tests. This stops throwing up
3430         PulseAudio output when the sanitizer was trying to unload modules which
3431         were already unloaded by another unit test that was being run in parallel.
3432
3433         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
3434         (EflPortTest):
3435         (EflPortTest.make_port):
3436         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3437         (GtkPortTest):
3438         (GtkPortTest.make_port):
3439
3440 2013-01-08  Julie Parent  <jparent@chromium.org>
3441
3442         Dashboard Cleanup: Remove g_hasDoneInitialPageGeneration
3443         https://bugs.webkit.org/show_bug.cgi?id=106254
3444
3445         Remove the global variable g_hasDoneInitialPageGeneration.  It was used
3446         only to figure out if we should call addBuilderLoadErrors during
3447         handleLocationChange, which was called when the loader completed and on
3448         any hash change, but we only ever wanted to call addBuilderLoadErrors
3449         on the initial loader load.  Moved the call of addBuilderLoadErrors to
3450         resourceLoadingComplete rather than handleLocationChange, so now we
3451         only call it when we want to, and the check can go away completely.
3452
3453         Reviewed by Dirk Pranke.
3454
3455         * TestResultServer/static-dashboards/dashboard_base.js:
3456         (addBuilderLoadErrors):
3457         (resourceLoadingComplete):
3458         (handleLocationChange):
3459         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3460
3461 2013-01-08  Dominic Mazzoni  <dmazzoni@google.com>
3462
3463         Add aboxhall@chromium.org to accessibility watchlist.
3464
3465         Unreviewed.
3466
3467         * Scripts/webkitpy/common/config/watchlist:
3468
3469 2013-01-08  Dan Winship  <danw@gnome.org>
3470
3471         Add Apache 2.4 support for Fedora 18
3472         https://bugs.webkit.org/show_bug.cgi?id=104478
3473
3474         Reviewed by Martin Robinson.
3475
3476         Apache 2.4's httpd.conf is slightly incompatible with 2.2's, so we
3477         need a separate config.
3478
3479         * Scripts/webkitpy/layout_tests/port/base.py:
3480         (Port._apache_version):
3481         (Port._apache_config_file_name_for_platform):
3482         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3483         * Scripts/run-webkit-httpd:
3484         * Scripts/webkitperl/httpd.pm:
3485         (getApacheVersion):
3486         (getDefaultConfigForTestDirectory):
3487         (getHTTPDConfigPathForTestDirectory):
3488
3489 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
3490
3491         Make the override-feature-defines script compatible with Python v3
3492         https://bugs.webkit.org/show_bug.cgi?id=105742
3493
3494         Reviewed by Martin Robinson.
3495
3496         Instead of printing output through a statement, use the print function and format
3497         the output using the str.format method. This makes the script runnable with Python v3.
3498
3499         * gtk/override-feature-defines:
3500         (adjust_feature_defines_makefile):
3501
3502 2013-01-08  Heikki Paajanen  <heikki.paajanen@palm.com>
3503
3504         [Qt] Fix libxml2 config test
3505         https://bugs.webkit.org/show_bug.cgi?id=106317
3506
3507         Reviewed by Simon Hausmann.
3508
3509         Don't assume standard include/libxml2, libxml-2.0.pc should know
3510         where it's headers are.
3511
3512         * qmake/config.tests/libxml2/libxml2.cpp: Fix include
3513
3514 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
3515
3516         [GTK] Make Tools/gtk/generate-gtkdoc compatible with Python 3
3517         https://bugs.webkit.org/show_bug.cgi?id=106195
3518
3519         Reviewed by Philippe Normand.
3520
3521         Perform changes in the generate-gtkdoc script and common and gtkdoc modules
3522         to make the Python code compatible with Python 3. This includes modifying
3523         print statements, exception handling, dictionary iteration and
3524         byte-sequence-to-string conversion.
3525
3526         * gtk/common.py:
3527         (get_build_path):
3528         (pkg_config_file_variable):
3529         (gtk_version_of_pkg_config_file):
3530         * gtk/generate-gtkdoc:
3531         (print_missing_api):
3532         * gtk/gtkdoc.py:
3533         (GTKDoc.__init__):
3534         (GTKDoc._run_command):
3535
3536 2013-01-02  Steve Block  <steveblock@chromium.org>
3537
3538         Add chromium.org email address for Steve Block.
3539
3540         Unreviewed.
3541
3542         * Scripts/webkitpy/common/config/committers.py:
3543
3544 2013-01-07  Filip Pizlo  <fpizlo@apple.com>
3545
3546         Rationalize closure call heuristics and profiling
3547         https://bugs.webkit.org/show_bug.cgi?id=106270
3548
3549         Reviewed by Oliver Hunt.
3550         
3551         Add ability to use display-profiler-output via a pipe, and add the ability to dump
3552         all generated code ('display *' or 'd *').
3553
3554         * Scripts/display-profiler-output:
3555
3556 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
3557
3558         Sorted more xcodeproj files.
3559
3560         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
3561         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3562         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
3563
3564 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
3565
3566         Sorted xcodeproj files.
3567
3568         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3569         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3570
3571 2013-01-07  Dan Bernstein  <mitz@apple.com>
3572
3573         [mac] WebKit1 clients can’t tell when a frame has been removed from the hierarchy
3574         https://bugs.webkit.org/show_bug.cgi?id=106261
3575
3576         Reviewed by Simon Fraser.
3577
3578         Added a test for -[WebFrameLoadDelegate webView:didRemoveFrameFromHierarchy:].
3579
3580         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3581         * TestWebKitAPI/Tests/mac/WebViewDidRemoveFrameFromHierarchy.mm: Added.
3582         (-[DidRemoveFrameFromHierarchyFrameLoadDelegate webView:didFinishLoadForFrame:]):
3583         (-[DidRemoveFrameFromHierarchyFrameLoadDelegate webView:didRemoveFrameFromHierarchy:]):
3584         (TestWebKitAPI):
3585         (TestWebKitAPI::TEST):
3586
3587 2013-01-07  Ojan Vafai  <ojan@chromium.org>
3588
3589         Add the Apple MountainLion bots to garden-o-matic.
3590         Eventually, we really should move away from hardcoding
3591         the list of bots.
3592
3593         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3594
3595 2013-01-07  Jochen Eisinger  <jochen@chromium.org>
3596
3597         [chromium] move web audio related methods to testrunner library
3598         https://bugs.webkit.org/show_bug.cgi?id=106211
3599
3600         Reviewed by Adam Barth.
3601
3602         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3603         (DRTTestRunner::DRTTestRunner):
3604         (DRTTestRunner::reset):
3605         * DumpRenderTree/chromium/DRTTestRunner.h:
3606         (DRTTestRunner):
3607         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
3608         (WebKit):
3609         (WebTestRunner::WebTestRunner::shouldDumpAsAudio):
3610         (WebTestRunner::WebTestRunner::audioData):
3611         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3612         (WebTestRunner::TestRunner::TestRunner):
3613         (WebTestRunner::TestRunner::reset):
3614         (WebTestRunner::TestRunner::shouldDumpAsAudio):
3615         (WebTestRunner):
3616         (WebTestRunner::TestRunner::audioData):
3617         (WebTestRunner::TestRunner::setAudioData):
3618         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3619         (TestRunner):
3620         * DumpRenderTree/chromium/TestShell.cpp:
3621         (TestShell::dump):
3622
3623 2013-01-07  Mike West  <mkwst@chromium.org>
3624
3625         Make the IFRAME_SEAMLESS flag runtime-enabled.
3626         https://bugs.webkit.org/show_bug.cgi?id=106213
3627
3628         Reviewed by Ojan Vafai.
3629
3630         * DumpRenderTree/chromium/TestShell.cpp:
3631         (TestShell::TestShell):
3632         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3633         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3634         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3635         (resetDefaultsToConsistentValues):
3636         * DumpRenderTree/mac/DumpRenderTree.mm:
3637         (resetDefaultsToConsistentValues):
3638         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3639         (WebCore::WebPage::resetSettings):
3640         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3641         (WTR::InjectedBundle::beginTesting):
3642             Ensure that seamless IFrames are enabled for layout tests in each of
3643             the ports that support seamless IFrames.
3644
3645 2013-01-07  Jochen Eisinger  <jochen@chromium.org>
3646
3647         [chromium] move dumpAsText and friends to the TestRunner library
3648         https://bugs.webkit.org/show_bug.cgi?id=106222
3649
3650         Reviewed by Adam Barth.
3651
3652         This moves dumpAsText, dumpChildFramesAsText, and dumpChildFrameScrollPositions to the TestRunner library.
3653
3654         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3655         (DRTTestRunner::DRTTestRunner):
3656         (DRTTestRunner::reset):
3657         * DumpRenderTree/chromium/DRTTestRunner.h:
3658         (DRTTestRunner):
3659         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
3660         (WebTestRunner::WebTestRunner::shouldDumpAsText):
3661         (WebTestRunner::WebTestRunner::setShouldDumpAsText):
3662         (WebTestRunner::WebTestRunner::shouldGeneratePixelResults):