1 2015-04-08 Alex Christensen <achristensen@webkit.org>
3 Block popups from content extensions.
4 https://bugs.webkit.org/show_bug.cgi?id=143497
6 Reviewed by Brady Eidson.
8 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
9 (TestWebKitAPI::TEST_F):
12 2015-04-08 Alex Christensen <achristensen@webkit.org> and Patrick Gansterer <paroga@webkit.org>
14 Add CMake build system for WinCairo port.
15 https://bugs.webkit.org/show_bug.cgi?id=115944
17 Reviewed by Chris Dumez.
20 * WinLauncher/CMakeLists.txt: Added.
22 2015-04-08 Carlos Garcia Campos <cgarcia@igalia.com>
24 [GTK] Crash in DOMObjectCache when a wrapped object owned by the cache is unreffed by the user
25 https://bugs.webkit.org/show_bug.cgi?id=143521
27 Reviewed by Martin Robinson.
29 Add a way to detect unexpected web process crashes to WebViewTest,
30 and a test case to testDOMCache to trigger the crash.
32 * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
33 (WebKitDOMNodeTest::testDOMCache):
34 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
35 (testWebKitWebViewProcessCrashed):
36 * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
37 (WebViewTest::WebViewTest):
38 (WebViewTest::webProcessCrashed):
39 * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
41 2015-04-07 Alexey Proskuryakov <ap@apple.com>
43 PageVisibilityStateWithWindowChanges should only be enabled on Yosemite
44 rdar://problem/20461342
46 * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
48 2015-04-07 Commit Queue <commit-queue@webkit.org>
50 Unreviewed, rolling out r182511.
51 https://bugs.webkit.org/show_bug.cgi?id=143507
53 caused debug test failures (Requested by alexchristensen on
58 "Block popups from content extensions."
59 https://bugs.webkit.org/show_bug.cgi?id=143497
60 http://trac.webkit.org/changeset/182511
62 2015-04-07 Alex Christensen <achristensen@webkit.org>
64 Block popups from content extensions.
65 https://bugs.webkit.org/show_bug.cgi?id=143497
67 Reviewed by Brady Eidson.
69 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
70 (TestWebKitAPI::TEST_F):
73 2015-04-07 Benjamin Poulain <benjamin@webkit.org>
75 Get the features.json files ready for open contributions
76 https://bugs.webkit.org/show_bug.cgi?id=143436
78 Reviewed by Darin Adler.
80 * Scripts/webkitpy/style/checkers/jsonchecker.py:
81 (JSONFeaturesChecker.check):
82 Extend the syntax checking a bit, but leave everything non-mandatory
83 very loose until we figure what fields are important.
85 2015-04-07 Tim Horton <timothy_horton@apple.com>
87 Expose and test fixedLayoutSize via modern WebKit SPI
88 https://bugs.webkit.org/show_bug.cgi?id=143500
90 Reviewed by Simon Fraser.
92 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
93 * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: Added.
94 (-[FixedLayoutSizeNavigationDelegate webView:didFinishNavigation:]):
96 Add a test that verifies that fixedLayoutSize works at all, that
97 it persists through a navigation, and that turning it back off reverts to
98 laying out at the size of the view.
100 2015-04-07 Michael Catanzaro <mcatanzaro@igalia.com>
102 Unreviewed. Add myself as a committer.
104 * Scripts/webkitpy/common/config/contributors.json:
106 2015-04-07 Brent Fulgham <bfulgham@apple.com>
108 [Win] Bots complain about missing /etc/catalog
109 https://bugs.webkit.org/show_bug.cgi?id=143484
111 Reviewed by Chris Dumez.
113 The libxml2 build on Mac, iOS, and Windows does not provide the set
114 of default catalog files. We do not actually need these for our
115 purposes, but we get warnings and some bot flakiness because they
118 We can avoid both problems the same way the Mac and iOS ports do,
119 by setting the XML_CATALOG_FILES environment variable to 'empty string',
120 which avoid the warnings and bot problems.
122 * Scripts/webkitpy/port/win.py:
123 (WinPort.setup_environ_for_server): Added.
125 2015-04-06 Sam Weinig <sam@webkit.org>
127 Use content extensions in MiniBrowser.
128 https://bugs.webkit.org/show_bug.cgi?id=143446
130 Reviewed by Alex Christensen.
132 * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
133 * MiniBrowser/mac/AppDelegate.h:
134 * MiniBrowser/mac/AppDelegate.m:
135 (-[BrowserAppDelegate init]):
136 (-[BrowserAppDelegate showExtensionsManager:]):
137 (-[BrowserAppDelegate userContentContoller]):
138 * MiniBrowser/mac/ExtensionManagerWindowController.h: Added.
139 * MiniBrowser/mac/ExtensionManagerWindowController.m: Added.
140 (-[ExtensionManagerWindowController init]):
141 (-[ExtensionManagerWindowController windowDidLoad]):
142 (-[ExtensionManagerWindowController add:]):
143 (-[ExtensionManagerWindowController remove:]):
144 * MiniBrowser/mac/ExtensionManagerWindowController.xib: Added.
145 * MiniBrowser/mac/MainMenu.xib:
147 2015-04-07 Youenn Fablet <youenn.fablet@crf.canon.fr>
149 web-platform-tests server should retrieve the modules file relatively to its docroot path
150 https://bugs.webkit.org/show_bug.cgi?id=142742
152 Reviewed by Darin Adler.
154 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
155 (WebPlatformTestServer._install_modules): Compute the modules description file path according wpt server doc root path.
157 2015-04-06 Commit Queue <commit-queue@webkit.org>
159 Unreviewed, rolling out r182445.
160 https://bugs.webkit.org/show_bug.cgi?id=143459
162 broke 32 bit build (Requested by alexchristensen on #webkit).
166 "Use content extensions in MiniBrowser."
167 https://bugs.webkit.org/show_bug.cgi?id=143446
168 http://trac.webkit.org/changeset/182445
170 2015-04-06 Sam Weinig <sam@webkit.org>
172 Use content extensions in MiniBrowser.
173 https://bugs.webkit.org/show_bug.cgi?id=143446
175 Reviewed by Alex Christensen.
177 * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
178 * MiniBrowser/mac/AppDelegate.h:
179 * MiniBrowser/mac/AppDelegate.m:
180 (-[BrowserAppDelegate init]):
181 (-[BrowserAppDelegate showExtensionsManager:]):
182 (-[BrowserAppDelegate userContentContoller]):
183 * MiniBrowser/mac/ExtensionManagerWindowController.h: Added.
184 * MiniBrowser/mac/ExtensionManagerWindowController.m: Added.
185 (-[ExtensionManagerWindowController init]):
186 (-[ExtensionManagerWindowController windowDidLoad]):
187 (-[ExtensionManagerWindowController add:]):
188 (-[ExtensionManagerWindowController remove:]):
189 * MiniBrowser/mac/ExtensionManagerWindowController.xib: Added.
190 * MiniBrowser/mac/MainMenu.xib:
192 2015-04-06 Michael Catanzaro <mcatanzaro@gnome.org>
194 [GTK] install-dependencies should prefer dnf to yum
195 https://bugs.webkit.org/show_bug.cgi?id=143441
197 Reviewed by Martin Robinson.
199 Test for the existance of dnf before yum, and only try to use yum if dnf does not exist.
201 * gtk/install-dependencies:
203 2015-04-06 Andy Estes <aestes@apple.com>
205 [iOS] 'make clean' fails in Tools/WebKitTestRunner
206 https://bugs.webkit.org/show_bug.cgi?id=143455
208 Reviewed by Dan Bernstein.
210 This Makefile adds '-target WebKitTestRunnerApp' to OTHER_OPTIONS during iOS builds, but the top-level
211 Makefile.shared adds '-alltargets' for clean builds, and xcodebuild does not allow both -target and -alltargets.
213 * WebKitTestRunner/Makefile: Don't add '-target WebKitTestRunerApp' to OTHER_OPTIONS on clean builds.
215 2015-04-06 Alexey Proskuryakov <ap@apple.com>
217 WebKit1.SetAndUpdateCacheModelPreferencesChangeMix fails on some machines
218 https://bugs.webkit.org/show_bug.cgi?id=143450
220 Reviewed by Anders Carlsson.
222 * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm: (TestWebKitAPI::TEST):
223 Make sure that the view is actually closed, regardless of anything else that happens beneath.
224 Also, removed unnecessary get() calls.
226 2015-04-03 Alexey Proskuryakov <ap@apple.com>
228 Reduce the dependency on Flash in regression tests
229 https://bugs.webkit.org/show_bug.cgi?id=143391
231 Reviewed by Anders Carlsson.
233 * WebKitTestRunner/TestController.cpp: (WTR::TestController::decidePolicyForPluginLoad):
234 Only allow QuickTime and the test plug-in.
236 2015-04-06 Youenn Fablet <youenn.fablet@crf.canon.fr>
238 W3C test importer should generate the modules installed dynamically to run wpt tests
239 https://bugs.webkit.org/show_bug.cgi?id=142738
241 Reviewed by Ryosuke Niwa.
243 The test importer can now generate the submodules description file based on information extracted from the corresponding git repository.
244 The implementation is done within TestDownloader and it is activated for the WPT repository.
245 LayoutTests/imported/w3c/resources/WPTModules is renamed as LayoutTests/imported/w3c/resources/web-platform-tests-modules.json for that reason.
247 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
248 (WebPlatformTestServer._install_modules): Updated to cope with path as array.
249 * Scripts/webkitpy/w3c/test_downloader.py:
250 (TestDownloader._git_submodules_status): Added so that it can be overriden for unit tests.
252 (TestDownloader._git_submodules_description): Computes submodule description.
253 (TestDownloader.generate_git_submodules_description): Write submodule description in a file.
254 * Scripts/webkitpy/w3c/test_importer.py:
255 (TestImporter.do_import): Added the possibility to post process the tests.
257 (TestImporter.generate_git_submodules_description_for_all_repositories): Enable generating module description file.
258 (TestImporter.should_convert_test_harness_links): Updated according new options format.
259 * Scripts/webkitpy/w3c/test_importer_unittest.py:
260 (TestImporterTest.import_downloaded_tests): Making use of TestDownloaderMock.
261 (TestImporterTest.import_downloaded_tests.TestDownloaderMock): Added to override submodule status gathering.
262 (TestImporterTest.import_downloaded_tests.TestDownloaderMock.__init__):
263 (TestImporterTest.import_downloaded_tests.TestDownloaderMock._git_submodules_status):
264 (TestImporterTest.test_submodules_generation): Added to check that modules description files works.
266 2015-04-05 Antti Koivisto <antti@apple.com>
268 Bloom filter should support longer hashes
269 https://bugs.webkit.org/show_bug.cgi?id=143419
271 Reviewed by Dan Bernstein.
273 * TestWebKitAPI/Tests/WTF/BloomFilter.cpp:
274 (TestWebKitAPI::generateRandomDigests):
275 (TestWebKitAPI::TEST):
277 2015-04-03 Csaba Osztrogonác <ossy@webkit.org>
279 run-jsc-stress-tests --remote should add libllvmForJSC.so to the bundle on Linux
280 https://bugs.webkit.org/show_bug.cgi?id=143372
282 Reviewed by Darin Adler.
284 * Scripts/run-jsc-stress-tests:
286 2015-04-03 Antti Koivisto <antti@apple.com>
288 Add non-counting bloom filter class
289 https://bugs.webkit.org/show_bug.cgi?id=143366
291 Reviewed by Sam Weinig.
293 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
294 * TestWebKitAPI/Tests/WTF/BloomFilter.cpp: Added.
295 (TestWebKitAPI::generateRandomHashes):
296 (TestWebKitAPI::TEST):
298 2015-04-03 Csaba Osztrogonác <ossy@webkit.org>
300 FTL JIT tests should fail if LLVM library isn't available
301 https://bugs.webkit.org/show_bug.cgi?id=143374
303 Reviewed by Mark Lam.
305 * Scripts/run-jsc-stress-tests:
307 2015-04-03 Csaba Osztrogonác <ossy@webkit.org>
309 [EFL] Speedup jhbuild with disable running autogen.sh
310 https://bugs.webkit.org/show_bug.cgi?id=143369
312 Reviewed by Gyuyoung Kim.
314 * efl/jhbuild.modules:
316 2015-04-01 Alexey Proskuryakov <ap@apple.com>
318 filter-webkit-build should filter out "created by an unsupported XCDependencyGraph build" lines
319 https://bugs.webkit.org/show_bug.cgi?id=143282
321 Reviewed by Daniel Bates.
323 * Scripts/filter-build-webkit: (shouldIgnoreLine): Do it.
325 2015-04-01 Alexey Proskuryakov <ap@apple.com>
327 When LayoutTestHelper fails to start, we continue to run the tests, ending up with mysterious failures
328 https://bugs.webkit.org/show_bug.cgi?id=143240
329 rdar://problem/19990425
331 Reviewed by Tim Horton.
333 * DumpRenderTree/mac/LayoutTestHelper.m:
334 (colorProfileURLForDisplay):
335 (saveDisplayColorProfiles):
336 Gracefully handle it when the current profile cannot be retrieved, fixing at
337 least one case when LayoutTestHelper couldn't start.
339 * Scripts/webkitpy/layout_tests/controllers/manager.py:
340 (Manager._set_up_run):
341 (Manager._force_pixel_tests_if_needed):
342 * Scripts/webkitpy/port/base.py: (Port.to.start_helper):
343 * Scripts/webkitpy/port/mac.py: (MacPort.start_helper):
344 Return and check an error from start_helper().
346 2015-04-01 Brent Fulgham <bfulgham@apple.com>
348 [Win] Run test-webkitpy as part of EWS (just like we do on other platforms)
349 https://bugs.webkit.org/show_bug.cgi?id=143321
351 Reviewed by Alexey Proskuryakov.
353 * EWSTools/start-queue-win.sh: Add commands to run 'test-webkitpy' during processing loop.
355 2015-04-01 Enrica Casucci <enrica@apple.com>
357 Injected bundle messages should be at the page level.
358 https://bugs.webkit.org/show_bug.cgi?id=143283
360 Reviewed by Alexey Proskuryakov.
362 Updating WebKitTestRunner to use the new page level messaging.
363 The author of this patch is Tim Horton, I just finished it.
365 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
366 (WTR::EventSendingController::mouseDown):
367 (WTR::EventSendingController::mouseUp):
368 (WTR::EventSendingController::mouseMoveTo):
369 (WTR::EventSendingController::leapForward):
370 (WTR::EventSendingController::scheduleAsynchronousClick):
371 (WTR::EventSendingController::keyDown):
372 (WTR::EventSendingController::scheduleAsynchronousKeyDown):
373 (WTR::EventSendingController::mouseScrollBy):
374 (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
375 (WTR::EventSendingController::continuousMouseScrollBy):
376 (WTR::EventSendingController::addTouchPoint):
377 (WTR::EventSendingController::updateTouchPoint):
378 (WTR::EventSendingController::setTouchModifier):
379 (WTR::EventSendingController::setTouchPointRadius):
380 (WTR::EventSendingController::touchStart):
381 (WTR::EventSendingController::touchMove):
382 (WTR::EventSendingController::touchEnd):
383 (WTR::EventSendingController::touchCancel):
384 (WTR::EventSendingController::clearTouchPoints):
385 (WTR::EventSendingController::releaseTouchPoint):
386 (WTR::EventSendingController::cancelTouchPoint):
387 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
388 (WTR::InjectedBundle::didReceiveMessage):
389 (WTR::InjectedBundle::didReceiveMessageToPage):
390 (WTR::InjectedBundle::done):
391 (WTR::InjectedBundle::outputText):
392 (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
393 (WTR::InjectedBundle::postAddChromeInputField):
394 (WTR::InjectedBundle::postRemoveChromeInputField):
395 (WTR::InjectedBundle::postFocusWebView):
396 (WTR::InjectedBundle::postSetBackingScaleFactor):
397 (WTR::InjectedBundle::postSetWindowIsKey):
398 (WTR::InjectedBundle::postSimulateWebNotificationClick):
399 (WTR::InjectedBundle::postSetAddsVisitedLinks):
400 (WTR::InjectedBundle::setGeolocationPermission):
401 (WTR::InjectedBundle::setMockGeolocationPosition):
402 (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
403 (WTR::InjectedBundle::setUserMediaPermission):
404 (WTR::InjectedBundle::setCustomPolicyDelegate):
405 (WTR::InjectedBundle::setHidden):
406 (WTR::InjectedBundle::setCacheModel):
407 (WTR::InjectedBundle::shouldProcessWorkQueue):
408 (WTR::InjectedBundle::processWorkQueue):
409 (WTR::InjectedBundle::queueBackNavigation):
410 (WTR::InjectedBundle::queueForwardNavigation):
411 (WTR::InjectedBundle::queueLoad):
412 (WTR::InjectedBundle::queueLoadHTMLString):
413 (WTR::InjectedBundle::queueReload):
414 (WTR::InjectedBundle::queueLoadingScript):
415 (WTR::InjectedBundle::queueNonLoadingScript):
416 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
417 (WTR::TestRunner::setHandlesAuthenticationChallenges):
418 (WTR::TestRunner::setAuthenticationUsername):
419 (WTR::TestRunner::setAuthenticationPassword):
420 (WTR::TestRunner::secureEventInputIsEnabled):
421 (WTR::TestRunner::setBlockAllPlugins):
422 * WebKitTestRunner/TestController.cpp:
423 (WTR::TestController::createWebViewWithOptions):
424 (WTR::TestController::resetStateToConsistentValues):
425 (WTR::TestController::didReceivePageMessageFromInjectedBundle):
426 (WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundle):
427 * WebKitTestRunner/TestController.h:
428 * WebKitTestRunner/TestInvocation.cpp:
429 (WTR::TestInvocation::invoke):
430 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
432 2015-04-01 Commit Queue <commit-queue@webkit.org>
434 Unreviewed, rolling out r182174 and r182177.
435 https://bugs.webkit.org/show_bug.cgi?id=143314
437 Try to correct EWS failures (Requested by bfulgham on
442 "Python SCM should be able to retrieve untracked files"
443 https://bugs.webkit.org/show_bug.cgi?id=143135
444 http://trac.webkit.org/changeset/182174
446 "[buildbot] clean-build script should remove untracked files
447 and revert local changes too"
448 https://bugs.webkit.org/show_bug.cgi?id=142400
449 http://trac.webkit.org/changeset/182177
451 2015-04-01 Alex Christensen <achristensen@webkit.org>
453 [Content Extensions] Properly handle regexes that match everything.
454 https://bugs.webkit.org/show_bug.cgi?id=143281
456 Reviewed by Benjamin Poulain.
458 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
459 (TestWebKitAPI::testRequest):
460 (TestWebKitAPI::makeBackend):
461 (TestWebKitAPI::TEST_F):
462 Removed duplicate code and added test.
464 2015-03-31 Benjamin Poulain <bpoulain@apple.com>
466 Content Extensions: split the state machines to minimize prefix states
467 https://bugs.webkit.org/show_bug.cgi?id=143253
469 Reviewed by Alex Christensen.
471 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
472 (TestWebKitAPI::TEST_F):
473 (TestWebKitAPI::testPatternStatus):
475 2015-03-31 Yusuke Suzuki <utatane.tea@gmail.com>
477 Clean up Identifier factories to clarify the meaning of StringImpl*
478 https://bugs.webkit.org/show_bug.cgi?id=143146
480 Reviewed by Filip Pizlo.
482 Simple API tests for StringImpl are added.
484 * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
485 (TestWebKitAPI::TEST):
487 2015-03-31 Csaba Osztrogonác <ossy@webkit.org>
489 [EFL] Add AArch64 builder and tester bot to build.webkit.org
490 https://bugs.webkit.org/show_bug.cgi?id=143092
492 Reviewed by Gyuyoung Kim.
494 * BuildSlaveSupport/build.webkit.org-config/config.json:
495 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
497 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
499 2015-03-31 Youenn Fablet <youenn.fablet@crf.canon.fr>
501 [buildbot] clean-build script should remove untracked files and revert local changes too
502 https://bugs.webkit.org/show_bug.cgi?id=142400
504 Reviewed by Ryosuke Niwa.
506 This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
507 A helper routine SCM.discard_untracked_files is added for that purpose.
509 * BuildSlaveSupport/clean-build:
510 (main): Making call to Scripts/clean-webkit
511 * Scripts/clean-webkit: Added.
512 (main): Revert changes and delete untracked files.
513 * Scripts/webkitpy/common/checkout/scm/scm.py:
514 (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.
515 * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
516 (SCMTest._shared_test_discard_untracked_files):
517 (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.
519 2015-03-31 Youenn Fablet <youenn.fablet@crf.canon.fr>
521 Python SCM should be able to retrieve untracked files
522 https://bugs.webkit.org/show_bug.cgi?id=143135
524 Reviewed by Ryosuke Niwa.
526 This patch introduces SCM.untracked_files to retrieve a list of untracked files.
527 Ignored files may be included or not in this list according boolean passed to the function.
529 * Scripts/webkitpy/common/checkout/scm/git.py:
530 (Git.untracked_files):
531 * Scripts/webkitpy/common/checkout/scm/scm.py:
532 (SCM.untracked_files):
533 * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
534 (SCMTest._shared_test_untracked_files):
535 (test_untracked_files):
536 (GitSVNTest.test_untracked_files):
537 * Scripts/webkitpy/common/checkout/scm/svn.py:
538 (SVN.untracked_files):
540 2015-03-30 Alex Christensen <achristensen@webkit.org>
542 [Content Extensions] Correctly handle regular expressions matching everything
543 https://bugs.webkit.org/show_bug.cgi?id=143235
545 Reviewed by Benjamin Poulain.
547 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
548 (TestWebKitAPI::checkCompilerError):
549 (TestWebKitAPI::TEST_F):
550 Test ContentExtensionErrors.
552 2015-03-30 Alexey Proskuryakov <ap@apple.com>
554 DumpRenderTree should set NSWindowDisplayWithRunLoopObserver
555 https://bugs.webkit.org/show_bug.cgi?id=143241
556 rdar://problem/20351297
558 Reviewed by Mark Lam.
560 * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
562 2015-03-30 Gyuyoung Kim <gyuyoung.kim@samsung.com>
564 [CMake][EFL] Remove redundant library link and include path
565 https://bugs.webkit.org/show_bug.cgi?id=143221
567 Reviewed by Csaba Osztrogonác.
569 * ImageDiff/PlatformEfl.cmake: Remove unnecessary library link and include path.
571 2015-03-30 Sam Weinig <sam@webkit.org>
573 [Content Extensions] Flesh out the UserContentExtensionStore
574 https://bugs.webkit.org/show_bug.cgi?id=143123
576 Reviewed by Benjamin Poulain.
578 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
579 * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm: Added.
580 Add tests for _WKUserContentExtensionStore.
582 2015-03-30 Marcos ChavarrÃa Teijeiro <chavarria1991@gmail.com>
584 Update install-dependencies Fedora packages after r181624
585 https://bugs.webkit.org/show_bug.cgi?id=143215
587 Add json-glib, libv4l, openssl and pulseaudio development packages to
588 the Fedora list providing we need them to build WebKit dependencies
589 for this distribution.
591 Reviewed by Philippe Normand.
593 * gtk/install-dependencies:
595 2015-03-30 Commit Queue <commit-queue@webkit.org>
597 Unreviewed, rolling out r182119.
598 https://bugs.webkit.org/show_bug.cgi?id=143196
600 problem with syntax (Requested by youenn on #webkit).
604 "[buildbot] clean-build script should remove untracked files
605 and revert local changes too"
606 https://bugs.webkit.org/show_bug.cgi?id=142400
607 http://trac.webkit.org/changeset/182119
609 2015-03-30 Benjamin Poulain <benjamin@webkit.org>
611 Start the features.json files
612 https://bugs.webkit.org/show_bug.cgi?id=143207
614 Reviewed by Darin Adler.
616 I kept the style checking light. We'll have to figure
617 what is the best format for each field.
619 * Scripts/webkitpy/style/checker.py:
620 (CheckerDispatcher._create_checker):
621 * Scripts/webkitpy/style/checkers/jsonchecker.py:
622 (JSONContributorsChecker.check):
623 (JSONFeaturesChecker):
624 (JSONFeaturesChecker.check):
626 2015-03-29 Youenn Fablet <youenn.fablet@crf.canon.fr>
628 [buildbot] clean-build script should remove untracked files and revert local changes too
629 https://bugs.webkit.org/show_bug.cgi?id=142400
631 Reviewed by Ryosuke Niwa.
633 This patch cleans the WebKit folder by deleting SCM untracked files and reverting changes for tracked files.
635 * BuildSlaveSupport/clean-build:
636 (main): Adding call to Tools/Scripts/clean-webkit.
637 * Scripts/clean-webkit: Added.
638 (main): Removes untracked and changed files.
639 * Scripts/webkitpy/common/checkout/scm/git.py:
640 (Git.untracked_files): Retrieves GIT untracked files.
641 * Scripts/webkitpy/common/checkout/scm/scm.py:
642 (SCM.untracked_files): Retrieves SVN untracked files.
644 (SCM.discard_untracked_files): Deletes untracked files/folders.
645 * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
646 (SCMTest._shared_test_untracked_files): Unit testing for untracked files.
647 (test_untracked_files):
648 (GitSVNTest.test_untracked_files):
649 * Scripts/webkitpy/common/checkout/scm/svn.py:
650 (SVN.untracked_files):
652 2015-03-27 Gyuyoung Kim <gyuyoung.kim@samsung.com>
654 [CMake] Remove unnecessary INCLUDE_IF_EXISTS macro
655 https://bugs.webkit.org/show_bug.cgi?id=143138
657 Reviewed by Csaba Osztrogonác.
659 INCLUDE_IF_EXISTS isn't used except for 2 places. However those uses can
660 be replaced with WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS.
662 * ImageDiff/CMakeLists.txt:
663 Use WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS() instead of INCLUDE_IF_EXISTS.
664 * WebKitTestRunner/CMakeLists.txt: ditto.
666 2015-03-27 Myles C. Maxfield <mmaxfield@apple.com>
668 Support building WTF on Windows without Cygwin
669 https://bugs.webkit.org/show_bug.cgi?id=143084
671 Reviewed by Brent Fulgham.
673 Windows without Cygwin doesn't have curl, unzip, or grep. Luckily, Perl does all of these things.
674 This patch also migrates to using File::Spec->catfile() for directory separators.
676 * Scripts/update-webkit-dependency:
678 * Scripts/update-webkit-support-libs:
680 (downloadExpectedVersionNumber):
682 (toUnixPath): Deleted.
683 * Scripts/webkitdirs.pm:
684 (determineSourceDir):
685 (windowsSourceSourceDir):
686 (windowsLibrariesDir):
688 (checkInstalledTools):
689 (buildVisualStudioProject):
691 2015-03-27 Alex Christensen <achristensen@webkit.org>
694 https://bugs.webkit.org/show_bug.cgi?id=143086
696 Reviewed by Brent Fulgham.
698 * Scripts/webkitdirs.pm:
699 (buildVisualStudioProject):
700 (runSvnUpdateAndResolveChangeLogs):
701 Use ActivePerl-friendly perl.
703 2015-03-27 Csaba Osztrogonác <ossy@webkit.org>
705 URTBF after r182059 to fix the EFL build.
707 * TestWebKitAPI/CMakeLists.txt:
709 2015-03-26 Alexey Proskuryakov <ap@apple.com>
711 Layout test results URL loads in WK1 but not WK2 minibrowser
712 https://bugs.webkit.org/show_bug.cgi?id=143117
714 Reviewed by Tim Horton.
716 * MiniBrowser/mac/WK2BrowserWindowController.m:
717 (-[WK2BrowserWindowController fetch:]): Fix this, international domain names, and
719 (-[WK2BrowserWindowController updateTextFieldFromURL:]): Ditto.
721 2015-03-26 Jer Noble <jer.noble@apple.com>
723 Add --allowed-host support to run-webkit-tests
724 https://bugs.webkit.org/show_bug.cgi?id=142938
726 Reviewed by Brent Fulgham.
728 Accept --allowed-host arguments from run-webkit-tests and pass them through to
729 DumpRenderTree and WebKitTestRunner.
731 Drive-by fix: Depending on the value of the --layout-test-dir parameter, layout test results
732 are placed in the wrong location. The argument is compared with each tests's path, and if a
733 relative path or a path with '..' was used, results are placed alongside the test. Take the
734 absolute path of the --layout-test-dir argument, collapsing path components like '..'.
736 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
738 * Scripts/webkitpy/port/base.py:
740 (Port.allowed_hosts):
741 * Scripts/webkitpy/port/driver.py:
744 2015-03-26 Jer Noble <jer.noble@apple.com>
746 [Mac] Add an --allowed-host argument to DRT and WKTR to allow tests to connect to non-localhost servers
747 https://bugs.webkit.org/show_bug.cgi?id=142931
749 Reviewed by Brent Fulgham.
751 Currently, both DRT and WKTR will refuse to allow network connections to non-localhost servers
752 over HTTP/HTTPS. For certain testing scenarios, however, it would be useful if both DRT and
753 WKTR could be allowed to make HTTP/HTTPS connections to certain, specific servers defined at
756 To allow this, add an optional argument to DRT and WKTR, --allowed-host, which will add the specified
757 hostname to a whitelist; requests to these hosts will allowed to proceed normally.
759 Drive-by fix: in InjectedBundlePage::willSendRequestForFrame, we get the top loading frame from the
760 injected bundle. But after the main resource load completes, the bundle nulls out it's pointer to the
761 top loading frame, which causes a subsequent crash when further resources are requested. Instead, get
762 the top loading frame from the page, as we do elsewhere in this class.
764 * DumpRenderTree/TestRunner.h:
765 (TestRunner::allowedHosts):
766 (TestRunner::setAllowedHosts):
767 * DumpRenderTree/mac/DumpRenderTree.mm:
768 (initializeGlobalsFromCommandLineOptions):
770 * DumpRenderTree/mac/ResourceLoadDelegate.mm:
772 (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
773 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
774 (WTR::InjectedBundle::didReceiveMessage):
775 (WTR::InjectedBundle::isAllowedHost):
776 * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
777 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
778 (WTR::isAllowedHost):
779 (WTR::InjectedBundlePage::willSendRequestForFrame):
780 * WebKitTestRunner/InjectedBundle/TestRunner.h:
781 * WebKitTestRunner/Options.cpp:
782 (WTR::handleOptionAllowedHost):
783 (WTR::OptionsHandler::OptionsHandler):
784 * WebKitTestRunner/Options.h:
785 * WebKitTestRunner/TestController.cpp:
786 (WTR::TestController::initialize):
787 (WTR::TestController::resetStateToConsistentValues):
788 * WebKitTestRunner/TestController.h:
790 2015-03-26 Brady Eidson <beidson@apple.com>
792 Apply ContentExtension actions after redirects.
793 <rdar://problem/20062613> and https://bugs.webkit.org/show_bug.cgi?id=143055
795 Reviewed by Alex Christensen.
797 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
798 (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Dump the fact that the load error is kWKErrorCodeCannotShowURL
799 which is specifically interesting to a new test.
801 2015-03-26 Csaba Osztrogonác <ossy@webkit.org>
803 [EFL] Disable building libseccomp on AArch64
804 https://bugs.webkit.org/show_bug.cgi?id=143094
806 Reviewed by Gyuyoung Kim.
810 2015-03-26 Csaba Osztrogonác <ossy@webkit.org>
812 [jhbuild] git should use only 1 thread for cloning jhbuild
813 https://bugs.webkit.org/show_bug.cgi?id=143095
815 Reviewed by Gyuyoung Kim.
817 * jhbuild/jhbuild-wrapper:
820 2015-03-25 Joseph Pecoraro <pecoraro@apple.com>
822 Update prepare-ChangeLog to work with ES6 Class syntax
823 https://bugs.webkit.org/show_bug.cgi?id=143069
825 Reviewed by Timothy Hatcher.
827 * Scripts/prepare-ChangeLog:
828 (get_function_line_ranges_for_javascript):
829 Better handle ES6 Class syntax.
831 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt:
832 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js:
835 (DerivedClass.staticMethod):
836 (DerivedClass.prototype.method.nestedFunctionInsideMethod):
837 (DerivedClass.prototype.method):
838 (DerivedClass.prototype.get getter):
840 (namespace.MyClass.staticMethod):
841 (namespace.MyClass.prototype.method.nestedFunctionInsideMethod):
842 (namespace.MyClass.prototype.method):
843 (namespace.MyClass.prototype.get getter):
846 2015-03-25 Filip Pizlo <fpizlo@apple.com>
848 Use JITCompilationCanFail in more places, and make the fail path of JITCompilationMustSucceed a crash instead of attempting GC
849 https://bugs.webkit.org/show_bug.cgi?id=142993
851 Reviewed by Mark Lam.
853 Bunch of support for testing executable allocation failure.
855 * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz: Added.
857 * Scripts/run-javascriptcore-tests:
859 * Scripts/run-jsc-stress-tests:
861 2015-03-25 Myles C. Maxfield <mmaxfield@apple.com>
863 Fix Windows build from r181977.
867 * Scripts/update-webkit-dependency:
869 2015-03-25 Sam Weinig <sam@webkit.org>
871 Address additional review feedback from https://bugs.webkit.org/show_bug.cgi?id=143059.
873 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
874 (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
876 2015-03-25 Myles C. Maxfield <mmaxfield@apple.com>
878 Migrate update-webkit for Windows to not require Cygwin
879 https://bugs.webkit.org/show_bug.cgi?id=143040
881 Reviewed by Brent Fulgham.
883 * Scripts/update-webkit-dependency:
885 (toUnixPath): Deleted.
886 * Scripts/webkitdirs.pm:
888 (checkInstalledTools):
891 2015-03-25 Sam Weinig <sam@webkit.org>
893 [Content Extensions] Convert content extension compiling to return error codes and write its output using a client
894 https://bugs.webkit.org/show_bug.cgi?id=143059
896 Reviewed by Alex Christensen.
898 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
899 (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
900 Update for new interface of compileRuleList().
902 2015-03-25 Alex Christensen <achristensen@webkit.org>
904 [Content Extensions] Add multi-DFA compiling and interpreting.
905 https://bugs.webkit.org/show_bug.cgi?id=143010
907 Reviewed by Benjamin Poulain.
909 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
910 (TestWebKitAPI::testRequest):
911 (TestWebKitAPI::TEST_F):
912 Add some tests for ignore-previous-rules and large rulesets.
914 2015-03-25 Alexey Proskuryakov <ap@apple.com>
916 Mavericks WK1 still runs JSC tests
917 https://bugs.webkit.org/show_bug.cgi?id=143035
919 Reviewed by Csaba Osztrogonác.
921 * BuildSlaveSupport/build.webkit.org-config/config.json: Bring Mavericks WK1 in line
924 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Updated the tests
927 2015-03-25 Commit Queue <commit-queue@webkit.org>
929 Unreviewed, rolling out r181932.
930 https://bugs.webkit.org/show_bug.cgi?id=143041
932 The test fails most of the time on bots (Requested by ap on
937 "[Content Extensions] Add multi-DFA compiling and
939 https://bugs.webkit.org/show_bug.cgi?id=143010
940 http://trac.webkit.org/changeset/181932
942 2015-03-24 Alex Christensen <achristensen@webkit.org>
944 [Content Extensions] Add multi-DFA compiling and interpreting.
945 https://bugs.webkit.org/show_bug.cgi?id=143010
947 Reviewed by Benjamin Poulain.
949 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
950 (TestWebKitAPI::testRequest):
951 (TestWebKitAPI::TEST_F):
952 Add some tests for ignore-previous-rules and large rulesets.
954 2015-03-24 Benjamin Poulain <bpoulain@apple.com>
956 Make URL filter patterns matching consistent and add a simple canonicalization step
957 https://bugs.webkit.org/show_bug.cgi?id=142998
959 Reviewed by Alex Christensen.
961 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
963 2015-03-24 Csaba Osztrogonác <ossy@webkit.org>
965 [EFL] Add OpenWebRTC in jhbuild
966 https://bugs.webkit.org/show_bug.cgi?id=142778
968 Reviewed by Gyuyoung Kim.
970 Original patch by Philippe Normand <pnormand@igalia.com>
972 * efl/install-dependencies: Dependencies for OpenWebRTC.
973 * efl/jhbuild.modules: build OpenWebRTC, libusrsctp, libnice and
974 the openwebrtc gst plugins.
976 2015-03-23 Brent Fulgham <bfulgham@apple.com>
978 Regression(r181257): WTF_WorkQueue.Simple is flaky
979 https://bugs.webkit.org/show_bug.cgi?id=142560
981 Remove the check that the refCount has returned to one after the
982 individual tasks have completed. It's too nondeterministic when
983 the reference count will be reduced.
985 Reviewed by Alexey Proskuryakov
987 * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
988 (TestWebKitAPI::TEST): Remove test that refCount is back to 1.
990 2015-03-23 Gyuyoung Kim <gyuyoung.kim@samsung.com>
992 [CMake][EFL] Put failure API test excutables into failure directory
993 https://bugs.webkit.org/show_bug.cgi?id=142965
995 Reviewed by Csaba Osztrogonác.
997 Move failing WK2 API test executables to *bin/TestWebKitAPI/WebKit2/failure* directory.
999 * TestWebKitAPI/CMakeLists.txt: Fix a typo. Change *testBaseName* with *testName*.
1000 * TestWebKitAPI/PlatformEfl.cmake: Additionally remove unnecessary SHARED_CORE and comment for SeccompFilters test.
1002 2015-03-22 Benjamin Poulain <benjamin@webkit.org>
1004 CSS Selectors: fix attribute case-insensitive matching of Contain and List
1005 https://bugs.webkit.org/show_bug.cgi?id=142932
1007 Reviewed by Darin Adler.
1009 Add tests for the new features and fix some existing tests using the
1010 stringFromUTF8() utility recently added by Dhi.
1012 * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1013 (TestWebKitAPI::stringFromUTF8):
1014 * TestWebKitAPI/Tests/WTF/StringView.cpp:
1016 2015-03-22 Michael Catanzaro <mcatanzaro@igalia.com>
1018 [GTK] install-dependencies should install orc
1019 https://bugs.webkit.org/show_bug.cgi?id=142955
1021 Reviewed by Martin Robinson.
1023 Install orc, needed by openwebrtc
1025 * gtk/install-dependencies:
1027 2015-03-22 Benjamin Poulain <bpoulain@apple.com>
1029 Detect when url filter pattern with groups match the empty string
1030 https://bugs.webkit.org/show_bug.cgi?id=142930
1032 Reviewed by Sam Weinig.
1034 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1036 2015-03-22 Anders Carlsson <andersca@apple.com>
1038 _WKWebsiteDataStore should clear WebSQL databases
1039 https://bugs.webkit.org/show_bug.cgi?id=142947
1041 Reviewed by Sam Weinig.
1043 Add a variable that keeps track of the types of data we want to operate on, for easier debugging.
1045 * MiniBrowser/mac/WK2BrowserWindowController.m:
1046 (-[WK2BrowserWindowController fetchWebsiteData:]):
1047 (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
1048 (-[WK2BrowserWindowController clearWebsiteData:]):
1050 2015-03-20 Mark Hahnenberg <mhahnenb@gmail.com>
1052 GCTimer should know keep track of nested GC phases
1053 https://bugs.webkit.org/show_bug.cgi?id=142675
1055 Reviewed by Darin Adler.
1057 Adds a tool to aid in parsing the GC phase timing output into a
1058 tree-like structure based on the parent-child relationships
1059 of nested GC phases.
1061 * Scripts/parse-gc-phase-timings: Added.
1064 (Timing.__unicode__):
1068 (print_timing_node):
1069 (print_timing_tree):
1073 2015-03-20 Brent Fulgham <bfulgham@apple.com>
1075 [Win] Temporarily turn of EWS Windows tests while I debug the test failure.
1077 * Scripts/webkitpy/common/config/ews.json:
1079 2015-03-20 Philippe Normand <pnormand@igalia.com>
1081 [GTK][jhbuild] Fix flakey failures due to unstable googlecode repository
1082 https://bugs.webkit.org/show_bug.cgi?id=142867
1084 Rubber-stamped by Csaba Osztrogon.
1086 * gtk/jhbuild.modules: Use Ossy's libusrsctp Github fork. Also use
1087 a fixed revision for the openwebrtc-gst-plugins.
1089 2015-03-19 Ryosuke Niwa <rniwa@webkit.org>
1091 Unreviewed build fix. Don't try to report stats for all benchmarks.
1092 Just report the geometric mean of preferred means.
1094 * Scripts/run-jsc-benchmarks:
1096 2015-03-19 Ryosuke Niwa <rniwa@webkit.org>
1098 run-jsc-benchmarks should only report preferred mean
1099 https://bugs.webkit.org/show_bug.cgi?id=142874
1101 Reviewed by Geoffrey Garen.
1103 Just collect statistics for the preferred mean.
1105 * Scripts/run-jsc-benchmarks:
1107 2015-03-19 Alex Christensen <achristensen@webkit.org>
1109 [Content Extensions] Test regular expression parse failures.
1110 https://bugs.webkit.org/show_bug.cgi?id=142872
1112 Reviewed by Benjamin Poulain.
1114 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1115 (TestWebKitAPI::testPatternStatus):
1116 (TestWebKitAPI::TEST_F):
1117 Added tests for each parsing status.
1119 2015-03-19 Alex Christensen <achristensen@webkit.org>
1121 Fix API tests after r181754.
1123 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1124 (TestWebKitAPI::testRequest):
1126 2015-03-19 Brady Eidson <beidson@apple.com>
1128 Part of content extensions should apply css selectors
1129 https://bugs.webkit.org/show_bug.cgi?id=142604
1131 Reviewed by Alex Christensen.
1133 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1134 (WebCore::ContentExtensions::operator<<):
1136 2015-03-19 Brent Fulgham <bfulgham@apple.com>
1138 [Win] Activate tests on EWS
1139 https://bugs.webkit.org/show_bug.cgi?id=142850
1141 Reviewed by Alexey Proskuryakov.
1143 * Scripts/webkitpy/common/config/ews.json: Add me as
1144 the EWS bot watcher, and activate tests.
1146 2015-03-19 Csaba Osztrogonác <ossy@webkit.org>
1148 [GTK] Fix inspector userinterface related incremental build issue
1149 https://bugs.webkit.org/show_bug.cgi?id=142849
1151 Reviewed by Carlos Garcia Campos.
1153 * Scripts/webkitdirs.pm:
1154 (shouldRemoveCMakeCache):
1156 2015-03-18 Alex Christensen <achristensen@webkit.org>
1158 [ContentExtensions] Prepare for compiling stylesheets of selectors to be used on every page.
1159 https://bugs.webkit.org/show_bug.cgi?id=142799
1161 Reviewed by Brady Eidson.
1163 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1164 (TestWebKitAPI::testPattern):
1165 (TestWebKitAPI::TEST_F):
1166 Start testing regex failures.
1168 2015-03-18 Dhi Aurrahman <diorahman@rockybars.com>
1170 Fix StringView typos after r181525 and r181558
1171 https://bugs.webkit.org/show_bug.cgi?id=142772
1173 Reviewed by Darin Adler.
1175 Add some tests in [1] to cover the StringView::startsWith,
1176 StringView::startsWithIgnoringASCIICase, StringView::endsWith and
1177 StringView::endsWithIgnoringASCIICase implementations.
1179 * TestWebKitAPI/Tests/WTF/StringView.cpp:
1180 (TestWebKitAPI::TEST):
1182 2015-03-18 Dana Burkart <dburkart@apple.com>
1184 Remove extraneous import to fix the build.
1188 * Scripts/webkitpy/port/driver.py:
1190 2015-03-18 Dana Burkart <dburkart@apple.com>
1192 ASAN_OPTIONS=allocator_may_return_null=1 needs to be set
1193 https://bugs.webkit.org/show_bug.cgi?id=142547
1195 Reviewed by Alexey Proskuryakov.
1197 * Scripts/webkitpy/port/driver.py:
1198 (Driver._setup_environ_for_driver):
1200 2015-03-18 Alexey Proskuryakov <ap@apple.com>
1202 Tweak how AppleSystemFontOSSubversion default is added
1203 https://bugs.webkit.org/show_bug.cgi?id=142835
1205 Reviewed by Dan Bernstein.
1207 * DumpRenderTree/mac/DumpRenderTree.mm:
1208 (setDefaultsToConsistentValuesForTesting):
1210 2015-03-18 Dan Bernstein <mitz@apple.com>
1212 prepare-ChangeLog doesn't understand C string literals split across multiple lines with \
1213 https://bugs.webkit.org/show_bug.cgi?id=142815
1215 Reviewed by Darin Adler.
1217 * Scripts/prepare-ChangeLog:
1218 (get_function_line_ranges_for_cpp): If the line ends with a backslash instead of a matching
1219 quotation mark, use new variable $quotation_mark to remember what we are looking for, and
1220 keep consuming the quoted text until the matching quotation mark is reached. Emit the
1221 warning only if a line ends without a backslash before the matching quotation mark was found.
1223 2015-03-18 Joseph Pecoraro <pecoraro@apple.com>
1225 Remove unused "preprocessor" parameter to sub-CodeGenerators
1226 https://bugs.webkit.org/show_bug.cgi?id=142793
1228 Reviewed by Darin Adler.
1230 * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1233 2015-03-18 Csaba Osztrogonác <ossy@webkit.org>
1235 [EFL] Bump gstreamer version to 1.4.4
1236 https://bugs.webkit.org/show_bug.cgi?id=142782
1238 Reviewed by Philippe Normand.
1240 * efl/jhbuild.modules:
1241 * efl/patches/gst-libav.patch:
1242 * efl/patches/gst-plugins-bad-remove-gnustep-support.patch: Added.
1243 * efl/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
1245 2015-03-17 Tim Horton <timothy_horton@apple.com>
1249 * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
1250 (WTR::InjectedBundle::platformInitialize):
1252 2015-03-17 Dean Jackson <dino@apple.com>
1254 check-webkit-style should allow "bool a : 1"
1255 https://bugs.webkit.org/show_bug.cgi?id=142794
1257 Reviewed by Brent Fulgham.
1259 We should allow member bitfields of the form:
1263 It seems that Visual Studio 8 was the last compiler that
1264 wasn't happy about not using unsigned here. We already have
1265 about 500 cases (in WebCore) where people were ignoring this rule.
1267 * Scripts/webkitpy/style/checkers/cpp.py:
1268 (check_language): Allow "bool".
1269 * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add tests.
1270 (CppStyleTest.test_enum_bitfields):
1271 (CppStyleTest.test_plain_integral_bitfields):
1273 2015-03-17 Benjamin Poulain <bpoulain@apple.com>
1275 Compile character ranges targeting the same state as range check in the bytecode
1276 https://bugs.webkit.org/show_bug.cgi?id=142759
1278 Reviewed by Alex Christensen.
1280 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1281 (TestWebKitAPI::TEST_F):
1283 2015-03-17 Youenn Fablet <youenn.fablet@crf.canon.fr>
1285 W3C test parser and converter should use test importer host
1286 https://bugs.webkit.org/show_bug.cgi?id=142729
1288 Reviewed by Bem Jones-Bey.
1290 When instantiated by TestImporter, TestParser and TestConverter are now using the same host.
1291 This enables adding more TestImporter unit testing.
1292 This patch also ensures that the git object instantiated by TestDownloader is using the
1293 same Executive and FileSystem object as TestDownloader, again to enable TestImporter/TestDownloader unit testing.
1295 * Scripts/webkitpy/common/system/filesystem_mock.py:
1296 (MockFileSystem.copytree): Fixes implementation as it creates a runtime error.
1297 * Scripts/webkitpy/w3c/test_downloader.py:
1298 (TestDownloader.git): Set the executive of the git object to the one of TestDownloader. Refactoring in a new git function for future reuse.
1299 (TestDownloader.checkout_test_repository): Making use of the new git function.
1300 * Scripts/webkitpy/w3c/test_importer.py:
1301 (TestImporter.find_importable_tests): Adding host as parameter to the parser.
1302 (TestImporter.import_tests): Adding host as parameter to the converter.
1303 * Scripts/webkitpy/w3c/test_importer_unittest.py:
1304 (TestImporterTest.create_test_download_importer): Creating a test downloader mock, to be reused by other tests.
1306 (TestImporterTest.test_harnesslinks_conversion): Adding test to check that test harness links are converted for CSS tests but not WPT tests.
1307 * Scripts/webkitpy/w3c/test_parser.py:
1308 (TestParser.__init__): Adding host as parameter constructor.
1310 2015-03-17 Carlos Garcia Campos <cgarcia@igalia.com>
1312 [GTK] WebKitDOM objects leaking
1313 https://bugs.webkit.org/show_bug.cgi?id=118788
1315 Reviewed by Darin Adler and Sergio Villar Senin.
1317 Update DOMObjectCache unit test to check that DOM objects are also
1318 released when new contents are loaded in the web view, and the old
1319 document is detached from the frame.
1321 * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
1322 (testWebKitDOMObjectCache):
1323 * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
1326 2015-03-17 Youenn Fablet <youenn.fablet@crf.canon.fr>
1328 W3C test importer default import folder should be LayoutTests/imported/w3c
1329 https://bugs.webkit.org/show_bug.cgi?id=142728
1331 Reviewed by Bem Jones-Bey.
1333 * Scripts/webkitpy/w3c/test_importer.py:
1334 (parse_args): Updating the default destination option value to 'imported/w3c'.
1336 2015-03-17 Philippe Normand <pnormand@igalia.com>
1338 [GTK] basic OpenWebRTC build support
1339 https://bugs.webkit.org/show_bug.cgi?id=142393
1341 Reviewed by Carlos Garcia Campos.
1343 * gtk/jhbuild.modules: Add OpenWebRTC and its dependencies. This
1344 is not the upstream OpenWebRTC repository. This temporary fork
1345 contains a few patches needed by WebKit for audio/video rendering.
1347 2015-03-17 Gyuyoung Kim <gyuyoung.kim@samsung.com>
1349 [CMake][EFL] Build test tools only for developer mode
1350 https://bugs.webkit.org/show_bug.cgi?id=142761
1352 Reviewed by Csaba Osztrogonác.
1354 Do not build EFL MiniBrowser, WebKitTestRunner, and ImageDiff on production mode.
1358 2015-03-17 Joseph Pecoraro <pecoraro@apple.com>
1360 Remove never used "useLayerOnTop" bindings generator argument
1361 https://bugs.webkit.org/show_bug.cgi?id=142773
1363 Reviewed by Darin Adler.
1365 * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1368 2015-03-16 Ryosuke Niwa <rniwa@webkit.org>
1370 Enable ES6 classes by default
1371 https://bugs.webkit.org/show_bug.cgi?id=142774
1373 Reviewed by Gavin Barraclough.
1375 * Scripts/webkitperl/FeatureList.pm:
1377 2015-03-16 Alexey Proskuryakov <ap@apple.com>
1379 Fix webkitpy tests after r181585.
1381 Looks like "me" cannot be anyone's email, it's a special case.
1383 * Scripts/webkitpy/common/config/contributors.json:
1385 2015-03-16 Alexey Proskuryakov <ap@apple.com>
1387 Add tolerance to WebAudio tests
1388 https://bugs.webkit.org/show_bug.cgi?id=142676
1390 Reviewed by Tim Horton.
1392 * Scripts/webkitpy/common/wavediff.py: Added. Based on Jer Noble's work.
1394 * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1395 (TestResultWriter.create_audio_diff_and_write_result):
1396 * Scripts/webkitpy/layout_tests/models/test_failures.py:
1397 (FailureAudio.write_failure):
1398 * Scripts/webkitpy/port/base.py:
1399 (Port.do_audio_results_differ):
1400 Diff audio failures.
1402 * Scripts/webkitpy/port/test.py: Added a test for the tolerance, fixed existing
1403 tests to use real parseable WAV data, and got rid of base64, which there didn't
1404 seem to have been any reason for.
1406 2015-03-16 Alexey Proskuryakov <ap@apple.com>
1408 [Mac] fast/forms/text-control-intrinsic-widths.html fails when MS Office is installed
1409 https://bugs.webkit.org/show_bug.cgi?id=142720
1411 Reviewed by Myles C. Maxfield.
1413 Activate system copies of Microsoft fonts for the current process, thus overriding
1414 any other ones that could be preferred by the system otherwise.
1416 * DumpRenderTree/mac/DumpRenderTree.mm:
1417 (activateSystemCoreWebFonts):
1419 * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1420 (WTR::activateSystemCoreWebFonts):
1421 (WTR::activateFonts):
1423 2015-03-16 Xabier Rodriguez Calvar <calvaris@igalia.com>
1425 Created Streams API watchlist
1426 https://bugs.webkit.org/show_bug.cgi?id=142684
1428 Reviewed by Benjamin Poulain.
1430 * Scripts/webkitpy/common/config/watchlist: Created StreamsAPI
1431 watchlist and added Benjamin, Youenn and me to it.
1433 2015-03-15 Benjamin Poulain <benjamin@webkit.org>
1435 CSS: fix the case-insensitive matching of the attribute selectors Begin, End and Hyphen
1436 https://bugs.webkit.org/show_bug.cgi?id=142715
1438 Reviewed by Brent Fulgham.
1440 * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1441 (TestWebKitAPI::TEST):
1443 2015-03-15 Benjamin Poulain <bpoulain@apple.com>
1445 Change the exact attribute matching to be ASCII case-insensitive
1446 https://bugs.webkit.org/show_bug.cgi?id=142609
1448 Reviewed by Darin Adler.
1450 * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1451 * TestWebKitAPI/Tests/WTF/StringView.cpp:
1453 2015-03-13 Youenn Fablet <youenn.fablet@crf.canon.fr>
1455 WebKit test infrastructure should automate the process of cloning W3C test suite and importing tests from it
1456 https://bugs.webkit.org/show_bug.cgi?id=134764
1458 Reviewed by Ryosuke Niwa.
1460 TestDownloader is introduced to download W3C tests from the official
1461 W3C tests repositories (https://github.com/w3c/web-platform-tests.git
1462 and https://github.com/w3c/csswg-test.git).
1463 TestDownloader clones the repositories and checkouts revisions of the tests
1464 defined in LayoutTests/imported/w3c/resources/TestRepositories.
1466 Similarly to https://codereview.chromium.org/148173016,
1467 TestDownloader copies part of the files based on the rules
1468 defined in LayoutTests/imported/w3c/resources/ImportExpectations.
1470 TestDownloader is used by TestImporter when no source directory is provided.
1472 * Scripts/webkitpy/w3c/test_downloader.py: Added.
1474 (TestDownloader.default_options):
1475 (TestDownloader.load_test_repositories):
1476 (TestDownloader.__init__):
1477 (TestDownloader.checkout_test_repository):
1478 (TestDownloader._init_paths_from_expectations):
1479 (TestDownloader._add_test_suite_paths):
1480 (TestDownloader._empty_directory):
1481 (TestDownloader.copy_tests):
1482 (TestDownloader.download_tests):
1483 * Scripts/webkitpy/w3c/test_importer.py:
1486 (TestImporter.__init__):
1487 (TestImporter.do_import):
1488 (TestImporter.test_downloader):
1489 (TestImporter.find_importable_tests.should_keep_subdir):
1490 (TestImporter.should_convert_test_harness_links):
1491 (TestImporter.import_tests):
1492 (TestImporter.write_import_log):
1494 2015-03-12 Alexey Proskuryakov <ap@apple.com>
1496 [Mavericks] Test snapshots are 1600x1200 on Retina devices
1497 https://bugs.webkit.org/show_bug.cgi?id=142630
1499 Reviewed by Tim Horton.
1501 * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::windowSnapshotImage):
1502 Removed an ifdef that disabled the fix on Mavericks.
1504 2015-03-12 Csaba Osztrogonác <ossy@webkit.org>
1506 Remove isWK2 cruft from webkitdirs.pm after r170426
1507 https://bugs.webkit.org/show_bug.cgi?id=142618
1509 Reviewed by Daniel Bates.
1511 * Scripts/webkitdirs.pm:
1514 2015-03-12 Alexey Proskuryakov <ap@apple.com>
1516 testRunner.setAlwaysAcceptCookies does not work with NetworkProcess
1517 https://bugs.webkit.org/show_bug.cgi?id=138687
1519 Reviewed by Carlos Garcia Campos.
1521 Always change cookie policy from UI process, as changing it from WebProcess doesn't
1522 affect other processes.
1524 The implementation is imperfect, because the change happens asynchronously, but I
1525 don't expect it to be a problem in practice.
1527 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1528 (WTR::InjectedBundle::beginTesting):
1529 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1530 (WTR::TestRunner::setAlwaysAcceptCookies):
1531 * WebKitTestRunner/TestInvocation.cpp:
1532 (WTR::TestInvocation::invoke):
1533 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1535 2015-03-12 Csaba Osztrogonác <ossy@webkit.org>
1537 [EFL] Enable building EFL 1.13 with NEON support
1538 https://bugs.webkit.org/show_bug.cgi?id=142619
1540 Reviewed by Gyuyoung Kim.
1542 * efl/jhbuild.modules:
1544 2015-03-11 Alex Christensen <achristensen@webkit.org>
1546 [Content Extensions] Add resource type and load type triggers.
1547 https://bugs.webkit.org/show_bug.cgi?id=142422
1549 Reviewed by Benjamin Poulain.
1551 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1552 (TestWebKitAPI::testRequest):
1553 (TestWebKitAPI::mainDocumentRequest):
1554 (TestWebKitAPI::TEST_F):
1555 (TestWebKitAPI::testURL): Deleted.
1557 2015-03-10 Sam Weinig <sam@webkit.org>
1559 Allow adding a button in input elements for auto fill related functionality
1560 <rdar://problem/19782066>
1561 https://bugs.webkit.org/show_bug.cgi?id=142564
1563 Reviewed by Anders Carlsson.
1565 * WebKitTestRunner/TestController.cpp:
1566 (WTR::TestController::createOtherPage):
1567 (WTR::TestController::createWebViewWithOptions):
1568 Update for new callback.
1570 2015-03-11 Benjamin Poulain <bpoulain@apple.com>
1572 Add basic support for BOL and EOL assertions to the URL Filter parser
1573 https://bugs.webkit.org/show_bug.cgi?id=142568
1575 Reviewed by Alex Christensen.
1577 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1578 (TestWebKitAPI::TEST_F):
1580 2015-03-11 Carlos Garcia Campos <cgarcia@igalia.com>
1582 [GTK] Add support for handling TLS errors to MiniBrowser
1583 https://bugs.webkit.org/show_bug.cgi?id=142576
1585 Reviewed by Sergio Villar Senin.
1587 It's useful for testing TLS errors handling itself, but also to
1588 allow ignoring TLS errors when testing.
1590 * MiniBrowser/gtk/BrowserWindow.c:
1591 (webViewLoadFailedWithTLSerrors):
1592 (browserWindowConstructed):
1594 2015-03-11 Myles C. Maxfield <mmaxfield@apple.com>
1596 Use out-of-band messaging for RenderBox::firstLineBaseline() and RenderBox::inlineBlockBaseline()
1597 https://bugs.webkit.org/show_bug.cgi?id=142569
1599 Reviewed by David Hyatt.
1601 Test Optional::valueOrCompute().
1603 * TestWebKitAPI/Tests/WTF/Optional.cpp:
1604 (TestWebKitAPI::TEST):
1606 2015-03-11 Carlos Garcia Campos <cgarcia@igalia.com>
1608 [GTK] Add an option to enable MiniBrowser for non developer builds and always install it
1609 https://bugs.webkit.org/show_bug.cgi?id=126688
1611 Reviewed by Gustavo Noronha Silva.
1613 * CMakeLists.txt: Build testing tools only for developer builds,
1614 but MiniBrowser when ENABLE_MINIBROWSER option is ON.
1615 * MiniBrowser/gtk/CMakeLists.txt: Only add
1616 -DWEBKIT_INJECTED_BUNDLE_PATH to the build for developer builds,
1617 and add a rule to install the MiniBrowser.
1618 * MiniBrowser/gtk/main.c:
1619 (main): Only set WEBKIT_INJECTED_BUNDLE_PATH env var for developer
1622 2015-03-11 Brent Fulgham <bfulgham@apple.com>
1624 Add some DateMath tests to TestWebKitAPI
1625 https://bugs.webkit.org/show_bug.cgi?id=142565
1627 Reviewed by Alexey Proskuryakov.
1629 * TestWebKitAPI/CMakeLists.txt: Add new DateMath.cpp file.
1630 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Ditto.
1631 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Ditto.
1632 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto."
1633 * TestWebKitAPI/Tests/WTF/DateMath.cpp: Added.
1635 2015-03-10 Brent Fulgham <bfulgham@apple.com>
1637 Regression(r181257): WTF_WorkQueue.Simple is flaky
1638 https://bugs.webkit.org/show_bug.cgi?id=142560
1640 Unreviewed attempt to improve test stability.
1642 * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Check the reference count for
1643 the WorkQueue a little later to redue flakiness.
1645 2015-03-10 Myles C. Maxfield <mmaxfield@apple.com>
1647 Migrate from SystemUIFontSelect to AppleSystemFontOSSubversion
1648 https://bugs.webkit.org/show_bug.cgi?id=142555
1650 Reviewed by Simon Fraser.
1652 * DumpRenderTree/mac/DumpRenderTree.mm:
1653 (setDefaultsToConsistentValuesForTesting):
1654 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1655 (WTR::InjectedBundle::platformInitialize):
1657 2015-03-10 Alex Christensen <achristensen@webkit.org>
1659 Use unsigned for HashSet size.
1660 https://bugs.webkit.org/show_bug.cgi?id=142518
1662 Reviewed by Benjamin Poulain.
1664 * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1665 (TestWebKitAPI::TEST):
1666 * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1667 (TestWebKitAPI::testInitialCapacity):
1668 * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
1669 (TestWebKitAPI::TEST):
1671 2015-03-10 Daniel Bates <dabates@apple.com>
1673 [iOS] Add WebKitSystemInterface for iOS 8.2
1674 https://bugs.webkit.org/show_bug.cgi?id=142505
1676 Rubber-stamped by Anders Carlsson.
1678 Make copy-webkitlibraries-to-product-directory install libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a.
1679 I inadvertently forgot to add libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a to script
1680 copy-webkitlibraries-to-product-directory in r181286.
1682 * Scripts/copy-webkitlibraries-to-product-directory:
1684 2015-03-10 Benjamin Poulain <bpoulain@apple.com>
1686 Extend URL filter's Term definition to support groups/subpatterns
1687 https://bugs.webkit.org/show_bug.cgi?id=142519
1689 Reviewed by Alex Christensen.
1691 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1692 (TestWebKitAPI::testURL):
1694 2015-03-06 Jer Noble <jer.noble@apple.com>
1696 Add an option to run-webkit-tests to override the LayoutTests/ directory
1697 https://bugs.webkit.org/show_bug.cgi?id=142418
1699 Reviewed by David Kilzer.
1701 Add an arugment to run-webkit-tests which, when set, overrides the port's default LayoutTests
1702 directory. The base port will parse the options during initialization and store the override
1703 location if present. layout_tests_dir() will return this overridden location if set.
1705 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1707 * Scripts/webkitpy/port/base.py:
1709 (Port.layout_tests_dir):
1711 2015-03-09 Martin Robinson <mrobinson@igalia.com>
1713 [CMake] Enable WorkQueue tests for CMake ports
1714 https://bugs.webkit.org/show_bug.cgi?id=142473
1716 Reviewed by Darin Adler.
1718 * TestWebKitAPI/CMakeLists.txt: Add the WorkQueue tests source file to
1719 the list of source files.
1720 * Tools/TestWebKitAPI/PlatformEfl.cmake: Add the DispatchQueueEfl directory
1721 to the list of include directories for EFL.
1723 2015-03-09 David Kilzer <ddkilzer@apple.com>
1725 Attempt to fix timeouts on iOS Simulator layout tests
1727 * Scripts/webkitpy/port/ios.py:
1728 (IOSSimulatorPort.setup_test_run): Most layout test runs on iOS
1729 Simulator end after the first 50 tests time out. Some analysis
1730 this past weekend shows that the 'Booted' status in the output
1731 of `xcrun simctl list` is not sufficient (and watching the test
1732 run shows that SpringBoard hasn't fully started to the point
1733 where it's displaying icons on the home screen). The workaround
1734 until we have a better fix is to add an arbitrary timeout to let
1735 SpringBoard finish launching. In practice, 15 seconds is
1736 probably enough, but 30 seconds should nearly always work.
1738 2015-03-09 Per Arne Vollan <peavo@outlook.com>
1740 Unreviewed. Add myself as a committer.
1742 * Scripts/webkitpy/common/config/contributors.json:
1744 2015-03-09 David Kilzer <ddkilzer@apple.com>
1746 Attempt to fix WTF_WorkQueue.TwoQueues timeout test failure
1748 * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
1749 (TestWebKitAPI::TEST): Change delay from 50ns to 50ms, and add
1750 an expectation that will fail if we hit the race condition.
1751 This test is inherently racy and will deadlock if the first job
1752 for queue2 takes the mutex lock before the second job for
1755 2015-03-08 Brent Fulgham <bfulgham@apple.com>
1757 [Win] WTF::WorkQueue does not balance ref/deref properly
1758 https://bugs.webkit.org/show_bug.cgi?id=142471
1760 Reviewed by Antti Koivisto.
1762 * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
1763 (TestWebKitAPI::TEST): Check that the refcount is correct.
1765 2015-03-08 Gyuyoung Kim <gyuyoung.kim@samsung.com>
1767 Do not show passing test result on output of EFL layout test
1768 https://bugs.webkit.org/show_bug.cgi?id=142380
1770 Reviewed by Darin Adler.
1772 To show passing tests has caused inconvenience when we detect problem tests
1773 in output of layout test. So this patch applies '--debug-rwt-logging' except for EFL port
1774 in order not to show passing tests in the output of EFL layout test.
1776 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1777 (RunWebKitTests.start):
1779 2015-03-08 Brent Fulgham <bfulgham@apple.com>
1781 Unreviewed build fix.
1783 * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
1784 (TestWebKitAPI::TEST): Remove two unused variables.
1786 2015-03-08 Brent Fulgham <bfulgham@apple.com>
1788 Add some WorkQueue tests to TestWebKitAPI
1789 https://bugs.webkit.org/show_bug.cgi?id=142447
1791 Reviewed by Sam Weinig.
1793 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1794 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
1795 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1796 * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Added.
1797 (TestWebKitAPI::simpleTest):
1798 (TestWebKitAPI::longTest):
1799 (TestWebKitAPI::thirdTest):
1800 (TestWebKitAPI::finishedTests):
1801 (TestWebKitAPI::TEST):
1802 (TestWebKitAPI::longTest2):
1804 2015-03-08 Carlos Garcia Campos <cgarcia@igalia.com>
1806 Remove willDestroyFrame in WKBundlePageLoaderClient
1807 https://bugs.webkit.org/show_bug.cgi?id=142389
1809 Reviewed by Anders Carlsson.
1811 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1812 (WTR::InjectedBundlePage::InjectedBundlePage):
1814 2015-03-07 Brent Fulgham <bfulgham@apple.com>
1816 [Win] Increase TestWebKitAPI Test Coverage[Win] Increase TestWebKitAPI Test Coverage
1817 https://bugs.webkit.org/show_bug.cgi?id=142433
1819 Reviewed by Darin Adler.
1821 Include more TestWebKitAPI tests when building for Windows. Also
1822 fix a build error in MetaAllocator.cpp caused by one of the
1823 Microsoft headers #defining 'small'.
1825 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1826 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
1827 * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1829 2015-03-06 Sam Weinig <sam@webkit.org>
1831 [Content Extensions] Move compiling of content extensions to the UIProcess
1832 https://bugs.webkit.org/show_bug.cgi?id=142402
1834 Reviewed by Benjamin Poulain.
1836 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1837 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: Copied from Tools/TestWebKitAPI/Tests/WebCore/ContentFilter.cpp.
1838 (TestWebKitAPI::InMemoryCompiledContentExtension::create):
1839 (TestWebKitAPI::InMemoryCompiledContentExtension::~InMemoryCompiledContentExtension):
1840 (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
1841 (TestWebKitAPI::TEST_F):
1842 * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Removed.
1843 Update test for new name (ContentFilter -> ContentExtensions) and API (CompiledContentExtension
1846 2015-03-06 Brent Fulgham <bfulgham@apple.com>
1848 [Win] Correct Windows build.
1850 Rubberstamped by Michael Saboff
1852 * win/AssembleBuildLogs/AssembleLogs.cmd: Correct cut/paste error
1855 2015-03-06 Carlos Garcia Campos <cgarcia@igalia.com>
1857 [GTK] Test /webkit2/WebKitWebView/sync-request-on-max-conns might fail after finished
1858 https://bugs.webkit.org/show_bug.cgi?id=142385
1860 Reviewed by Sergio Villar Senin.
1862 Use stack allocated GMainLoopSources to make sure they are
1863 cancelled automatically if the test finishes before they have
1866 * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1867 (testWebViewSyncRequestOnMaxConns):
1869 2015-03-06 Csaba Osztrogonác <ossy@webkit.org>
1871 Remove Mountain Lion libraries since ML isn't supported
1872 https://bugs.webkit.org/show_bug.cgi?id=142332
1874 Reviewed by Darin Adler.
1876 * Scripts/copy-webkitlibraries-to-product-directory:
1878 2015-03-06 Carlos Alberto Lopez Perez <clopez@igalia.com> and Youenn Fablet <youenn.fablet@crf.canon.fr>
1880 Layout tests imported/w3c/web-platform-tests certificates should not be tracked on WebKit VCS
1881 https://bugs.webkit.org/show_bug.cgi?id=142083
1883 Reviewed by Simon Fraser.
1885 Modifying on the fly wpt config.json to set the directory where to generate/read certificates as a subfolder of the layout test results folder.
1887 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1888 (WebPlatformTestServer._copy_webkit_test_files):
1890 2015-03-06 Csaba Osztrogonác <ossy@webkit.org>
1892 setup-git-clone fails due to the failure to download python-irclib-0.4.8
1893 https://bugs.webkit.org/show_bug.cgi?id=141946
1895 Reviewed by Ryosuke Niwa.
1897 Check in ircbot.py and irclib.py to avoid network problems in the future.
1899 * Scripts/webkitpy/common/net/irc/ircbot.py:
1900 * Scripts/webkitpy/thirdparty/__init__.py:
1901 (AutoinstallImportHook.find_module):
1902 (AutoinstallImportHook._install_irc): Deleted.
1903 * Scripts/webkitpy/thirdparty/__init___unittest.py:
1904 (ThirdpartyTest.test_imports):
1905 * Scripts/webkitpy/thirdparty/irc/__init__.py: Added.
1906 * Scripts/webkitpy/thirdparty/irc/ircbot.py: Added.
1907 * Scripts/webkitpy/thirdparty/irc/irclib.py: Added.
1909 2015-03-06 David Kilzer <ddkilzer@apple.com>
1911 Dashboard: Perf bot status is missing for Apple {Mavericks,Yosemite} Release builds
1913 See also fix to config.json in r181097.
1915 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1916 (WebKitBuildbot): Add missing "WK2" to the names of the perf
1919 2015-03-06 Csaba Osztrogonác <ossy@webkit.org>
1921 run-jsc-stress-tests should determine the architecture from ELF binaries
1922 https://bugs.webkit.org/show_bug.cgi?id=142335
1924 Reviewed by Darin Adler.
1926 * Scripts/run-jsc-stress-tests:
1928 2015-03-05 David Kilzer <ddkilzer@apple.com>
1930 [iOS] TestExpectations for ios-simulator-wk2 should fall back to 'wk2' after 'ios-simulator'
1931 <http://webkit.org/b/142226>
1933 Reviewed by Darin Adler.
1935 * Scripts/webkitpy/port/ios.py:
1936 (IOSSimulatorPort.default_baseline_search_path): Switch the
1937 TestExpectations order of ios-simulator-wk2 from this:
1938 ios-simulator-wk2, wk2, ios-simulator
1940 ios-simulator-wk2, ios-simualtor, wk2
1942 2015-03-05 Brent Fulgham <bfulgham@apple.com>
1944 [Win] Provide tiered logging from MSBuild -- Errors on top, Warnings after
1945 https://bugs.webkit.org/show_bug.cgi?id=142370
1947 Reviewed by Dean Jackson.
1949 * Scripts/webkitdirs.pm:
1950 (buildVisualStudioProject): Tell MSBuild to output log files to two separate
1951 logs, one for warnings, the other for errors.
1952 * win/AssembleBuildLogs/AssembleLogs.cmd: Combine the error and warning logs
1953 into the standard BuildOutput.htm document.
1955 2015-03-05 David Kilzer <ddkilzer@apple.com>
1957 Dashboard has trouble parsing iOS test output
1958 <http://webkit.org/b/142364>
1960 Reviewed by Alex Christensen.
1962 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1963 (BuildbotTestResults.prototype._parseResults.resultSummarizer):
1964 Add fallback path to build a regex using 'matchString' so that
1965 it matches anywhere in the line. In practice, 'matchString' is
1966 a prefix for the label following the number.
1968 2015-03-05 Alex Christensen <achristensen@webkit.org>
1970 Fix linker warnings in TestWebKitAPI.
1971 https://bugs.webkit.org/show_bug.cgi?id=141912
1973 Reviewed by David Kilzer.
1975 * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1976 Do not export TearDownTestCase or SetUpTestCase symbols.
1978 2015-03-05 Brent Fulgham <bfulgham@apple.com>
1980 [Win] Unreviewed EWS fix.
1982 * Scripts/webkitdirs.pm:
1983 (buildVisualStudioProject): Dial logging back to 'ErrorsOnly' to see if that makes
1984 the EWS output more usable.
1986 2015-03-05 Chris Dumez <cdumez@apple.com>
1988 Regression(r173761): ASSERTION FAILED: !is8Bit() in StringImpl::characters16()
1989 https://bugs.webkit.org/show_bug.cgi?id=142350
1991 Reviewed by Michael Saboff and Benjamin Poulain.
1993 Add API test for WTFString::hasInfixStartingAt() to make sure it doesn't
1994 crash if the string is 8-bit but the pattern is 16-bit (and vice-versa).
1996 * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1997 (TestWebKitAPI::TEST):
1999 2015-03-05 Brent Fulgham <bfulgham@apple.com>
2001 [Win] Ensure build target directory exists when launching MSBuild
2002 https://bugs.webkit.org/show_bug.cgi?id=142360
2004 Reviewed by Dean Jackson.
2006 Create the build output directory (if it doesn't exist) before
2007 launching MSBuild so that it can immediately begin writing logs.
2009 * Scripts/webkitdirs.pm:
2010 (buildVisualStudioProject):
2012 2015-03-05 Chris Dumez <cdumez@apple.com>
2014 run-webkit-tests and run-perf-tests should use WebKitTestRunner by default
2015 https://bugs.webkit.org/show_bug.cgi?id=142325
2017 Reviewed by Csaba Osztrogonác.
2019 run-webkit-tests and run-perf-tests now use WebKitTestRunner by default.
2020 As a result, "--webkit-test-runner / -2" parameters are replaced by
2021 "--dump-render-tree / -1" so developers can run DumpRenderTree rather
2022 than WebKitTestRunner.
2024 * BuildSlaveSupport/build.webkit.org-config/config.json:
2025 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2027 (RunWebKit1Tests.start):
2028 (RunWebKit1LeakTests):
2029 (RunWebKit1LeakTests.start):
2030 (RunAndUploadPerfTestsWebKit1):
2031 (RunAndUploadPerfTestsWebKit1.start):
2033 (TestWebKit1LeaksFactory):
2034 (TestWebKit1LeaksFactory.__init__):
2035 (TestWebKit1Factory):
2036 (TestWebKit1AllButJSCFactory):
2037 (TestAllButJSCFactory):
2038 (BuildAndPerfTestWebKit1Factory):
2039 (BuildAndPerfTestWebKit1Factory.__init__):
2040 (BuildAndPerfTestFactory):
2041 (BuildAndPerfTestFactory.__init__):
2042 (DownloadAndPerfTestWebKit1Factory):
2043 (DownloadAndPerfTestWebKit1Factory.__init__):
2044 (DownloadAndPerfTestFactory):
2045 (DownloadAndPerfTestFactory.__init__):
2046 (RunWebKitLeakTests): Deleted.
2047 (RunWebKitLeakTests.start): Deleted.
2048 (RunWebKit2Tests): Deleted.
2049 (RunWebKit2Tests.start): Deleted.
2050 (RunAndUploadPerfTestsWebKit2): Deleted.
2051 (RunAndUploadPerfTestsWebKit2.start): Deleted.
2052 (TestLeaksFactory): Deleted.
2053 (TestLeaksFactory.__init__): Deleted.
2054 (TestWebKit2Factory): Deleted.
2055 (TestWebKit2AndJSCFactory): Deleted.
2056 (BuildAndPerfTestWebKit2Factory): Deleted.
2057 (BuildAndPerfTestWebKit2Factory.__init__): Deleted.
2058 (DownloadAndPerfTestWebKit2Factory): Deleted.
2059 (DownloadAndPerfTestWebKit2Factory.__init__): Deleted.
2060 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2062 * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2063 (PerfTestsRunner._parse_args):
2064 * Scripts/webkitpy/port/port_testcase.py:
2065 (PortTestCase.test_build_driver):
2067 2015-03-05 Brent Fulgham <bfulgham@apple.com>
2069 [Win] Switch to MSBuild so we get more useful stdout logging in buildbot
2070 https://bugs.webkit.org/show_bug.cgi?id=140845
2072 Reviewed by David Kilzer.
2074 Update 'webkitdirs.pm' to locate the MSBuild used with Visual Studio 2013
2075 and generate suitable build commands to drive a full build from our
2076 existing solution files.
2078 * Scripts/webkitdirs.pm:
2079 (msBuildInstallDir): Added.
2080 (determineConfigurationForVisualStudio): Revise to use MSBuild command
2081 line arguments to drive the build.
2082 (setupCygwinEnv): Warn user if MSBuild cannot be located.
2083 (buildVisualStudioProject): Revise to use MSBuild command line arguments
2084 to specify build architecture.
2085 * win/AssembleBuildLogs/AssembleLogs.cmd: MSBuild doesn't produce individual
2086 output logs, so don't attempt to consolidate them. Also: Drive-by fix: Don't
2087 bother looking for CoreUI or SafariTheme build logs.
2089 2015-03-05 Csaba Osztrogonác <ossy@webkit.org>
2091 [buildbot] mastercfg_unittest.py should be runnable easily
2092 https://bugs.webkit.org/show_bug.cgi?id=142219
2094 Reviewed by Chris Dumez.
2096 Buildbot 0.8.6p1 runs on build.webkit org with Twisted 12.1.0, which is
2097 the last Twisted version works together with this buildbot version.
2099 * Scripts/webkitpy/common/system/autoinstall.py:
2100 (AutoInstaller): Added prepend_to_search_path argument to be able
2101 to prefer autoinstalled package to system package.
2102 (AutoInstaller.__init__):
2103 (AutoInstaller._set_up_target_dir):
2104 (AutoInstaller._extract_tar): Renamed from _extract_targz, now it works with tar.bz2 too.
2105 (AutoInstaller._prepare_package):
2106 (AutoInstaller._extract_targz): Renamed to _extract_tar.
2107 * Scripts/webkitpy/thirdparty/__init__.py:
2108 (AutoinstallImportHook._install_buildbot): Autoinstall Twisted 12.1.0.
2110 2015-03-05 Lukasz Bialek <l.bialek@samsung.com>
2112 [EFL][WK2] Crash when "Download Linked File" from MiniBrowser context menu is clicked
2113 https://bugs.webkit.org/show_bug.cgi?id=131162
2115 Reviewed by Gyuyoung Kim.
2117 * MiniBrowser/efl/main.c:
2118 (on_download_request):
2119 (on_download_finished):
2120 (on_download_failed):
2122 Adapt download callbacks to new callback mechanism
2124 2015-03-05 Carlos Garcia Campos <cgarcia@igalia.com>
2126 Unreviewed. Fix /webkit2/WebKitWebResource/mime-type after r180927.
2128 In r180927 we updated the libsoup version used by the jhbuild. In
2129 this new version the sniffer uses image/x-icon instead of
2130 image/vnd.microsoft.icon for blank.ico resource.
2132 * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2133 (testWebResourceMimeType):
2135 2015-03-05 Carlos Garcia Campos <cgarcia@igalia.com>
2137 [SOUP] Check TLS errors as soon as they are set in the SoupMessage
2138 https://bugs.webkit.org/show_bug.cgi?id=142244
2140 Reviewed by Sergio Villar Senin.
2142 Check that the SSL server doesn't process any request in case of
2143 TLS errors when the policy is set to FAIL.
2145 * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
2146 (testTLSErrorsPolicy):
2147 (testTLSErrorsRedirect):
2148 (testTLSErrorsHTTPAuth):
2149 (testLoadFailedWithTLSErrors):
2150 (testSubresourceLoadFailedWithTLSErrors):
2151 (httpsServerCallback):
2153 2015-03-05 Pawel Forysiuk <p.forysiuk@samsung.com>
2155 [EFL] REGRESSION (r178685): ASSERTION FAILED: !parameters.mediaKeyStorageDirectory.isEmpty()
2156 https://bugs.webkit.org/show_bug.cgi?id=141154
2158 Reviewed by Jer Noble.
2160 Unlike GTK, EFL port enables ENABLE_ENCRYPTED_MEDIA_V2 build option by default.
2162 For the sake of completeness WebKitTestRunner should specify temporary
2163 folder for MediaKeysStorageDirecory as well as IndexedDB, LocalStorage, etc.
2165 Default non legacy paths are set up in ProcessPoolConfiguration constructor.
2166 They use WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation
2167 to get data storage paths. Only Mac port has an actual implementation of it.
2168 However, WebKitTestRunner overrides them in favour of unique temporary dir
2169 which is taken from libraryPathForTesting().
2171 Since WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation
2172 is not implemented for EFL and GTK ports it returns an empty string.
2173 All default data folders besides MediaKeys are overridden in TestRunner
2174 code with unique temporary folders derived from DUMPRENDERTREE_TEMP
2177 GTK port does not enable encrypted keys by default so
2178 WebMediaKeyStorageManager::initialize() code path is never triggered.
2180 * WebKitTestRunner/TestController.cpp:
2181 (WTR::TestController::initialize): Set MediaKeysStorageDirectory for all
2184 2015-03-05 Csaba Osztrogonác <ossy@webkit.org>
2186 [buildbot] Add regression test to check which builder runs which tests
2187 https://bugs.webkit.org/show_bug.cgi?id=142166
2189 Reviewed by Alexey Proskuryakov.
2191 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2192 (BuildStepsConstructorTest.createTest):
2194 (BuildStepsTest.generateTests):
2195 (BuildStepsTest.createTest):
2196 (BuildStepsTest.createTest.doTest):
2197 (BuildStepsTest.test_unnecessary_expected_results):
2199 2015-03-04 Commit Queue <commit-queue@webkit.org>
2201 Unreviewed, rolling out r181054.
2202 https://bugs.webkit.org/show_bug.cgi?id=142320
2204 Broke the api tests (Requested by sundiamonde on #webkit).
2208 "Fix linker warnings in TestWebKitAPI."
2209 https://bugs.webkit.org/show_bug.cgi?id=141912
2210 http://trac.webkit.org/changeset/181054
2212 2015-03-04 Alex Christensen <achristensen@webkit.org>
2214 Fix linker warnings in TestWebKitAPI.
2215 https://bugs.webkit.org/show_bug.cgi?id=141912
2217 Reviewed by David Kilzer.
2219 * TestWebKitAPI/Configurations/Base.xcconfig:
2220 Use GCC_SYMBOLS_PRIVATE_EXTERN like we do in WebCore.
2222 2015-03-04 Alexey Proskuryakov <ap@apple.com>
2224 [Mac] Set SystemUIFontSelect in DRT and WKTR
2225 https://bugs.webkit.org/show_bug.cgi?id=142303
2227 Reviewed by Myles C. Maxfield.
2229 * DumpRenderTree/mac/DumpRenderTree.mm:
2230 (setDefaultsToConsistentValuesForTesting):
2231 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2232 (WTR::InjectedBundle::platformInitialize):
2234 2015-03-04 Chris Dumez <cdumez@apple.com>
2236 Mac Perf bots should use WebKitTestRunner instead of DumpRenderTree
2237 https://bugs.webkit.org/show_bug.cgi?id=142314
2238 <rdar://problem/20046835>
2240 Reviewed by Ryosuke Niwa.
2242 Mac Perf bots should use WebKitTestRunner instead of DumpRenderTree
2243 to get WK2 code coverage.
2245 * BuildSlaveSupport/build.webkit.org-config/config.json:
2247 2015-03-04 Alex Christensen <achristensen@webkit.org>
2249 Move content extensions test to properly named directory.
2250 https://bugs.webkit.org/show_bug.cgi?id=142299
2252 Reviewed by Tim Horton.
2254 * WebKitTestRunner/mac/TestControllerMac.mm:
2255 (WTR::TestController::platformConfigureViewForTest):
2257 2015-03-04 Youenn Fablet <youenn.fablet@crf.canon.fr>
2259 W3C test importer should use filesystem instead of os.walk
2260 https://bugs.webkit.org/show_bug.cgi?id=142085
2262 Reviewed by Bem Jones-Bey.
2264 Added FileSystem.dirs_under to remove the use of os.walk in test importer.
2265 Added MockFileSystem.dirs_under and MockFileSystem.getsize to enable unit testing of test importer.
2266 Added unit test for FileSystem.dirs_under and MockFileSystem.dirs_under.
2268 Made use of FileSystem.dirs_under within TestImporter.find_importable_tests.
2269 Added a unit test to check that test importer is now black-box testable using a Mock system.
2271 * Scripts/webkitpy/common/system/filesystem.py:
2272 (FileSystem.dirs_under): Returns a list of filtered sub-directories.
2273 (FileSystem.dirs_under.filter_all):
2274 * Scripts/webkitpy/common/system/filesystem_mock.py:
2275 (MockFileSystem.dirs_under):
2276 (MockFileSystem.dirs_under.filter_all):
2277 (MockFileSystem.getsize):
2278 * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
2279 (MockFileSystemTest.test_dirs_under):
2280 (MockFileSystemTest.test_dirs_under.filter_dir):
2281 * Scripts/webkitpy/common/system/filesystem_unittest.py:
2282 (RealFileSystemTest.test_sep):
2283 (RealFileSystemTest):
2284 (RealFileSystemTest.test_dirs_under):
2285 (RealFileSystemTest.test_dirs_under.filter_this_dir):
2286 * Scripts/webkitpy/w3c/test_importer.py:
2287 (TestImporter.do_import):
2288 (TestImporter.find_importable_tests.should_keep_subdir):
2289 (TestImporter.find_importable_tests):
2290 (TestImporter.should_keep_subdir): Deleted.
2291 (TestImporter.should_skip_file): Deleted.
2292 * Scripts/webkitpy/w3c/test_importer_unittest.py:
2293 (TestImporterTest.test_import_dir_with_empty_init_py): Added test to ensure empty __init__.py are no longer empty once imported.
2295 2015-03-04 Timothy Horton <timothy_horton@apple.com>
2297 [WebEditingTester] Add support for the find and replace bar
2298 https://bugs.webkit.org/show_bug.cgi?id=142247
2300 Reviewed by Enrica Casucci.
2302 While it's not hooked up yet in WKWebView, adding support for the
2303 find bar to WebEditingTester will help us implement that functionality.
2305 * WebEditingTester/AppDelegate.h:
2306 * WebEditingTester/AppDelegate.m:
2307 (-[WebEditingAppDelegate performTextFinderAction:]):
2308 * WebEditingTester/MainMenu.xib:
2309 Receive performTextFinderAction: and forward it to the frontmost WebDocumentController.
2311 * WebEditingTester/WK2WebDocumentController.m:
2312 (-[WK2WebDocumentController awakeFromNib]):
2313 (-[WK2WebDocumentController performTextFinderAction:]):
2314 (-[WK2WebDocumentController findBarView]):
2315 (-[WK2WebDocumentController setFindBarView:]):
2316 (-[WK2WebDocumentController isFindBarVisible]):
2317 (-[WK2WebDocumentController setFindBarVisible:]):
2318 (-[WK2WebDocumentController findBarViewDidChangeHeight]):
2319 (-[WK2WebDocumentController layout]):
2320 Implement performTextFinderAction: for WebKit2, and have a NSTextFinder
2321 pointing at the WKWebView (currently nothing will work, but the bar will
2322 show up). Install and uninstall the bar as needed.
2324 * WebEditingTester/WebDocument.xib:
2325 Don't use a full-size content view. There's no need, and it makes find
2328 * WebEditingTester/WebDocumentController.h:
2329 * WebEditingTester/WebDocumentController.m:
2330 (-[WebDocumentController performTextFinderAction:]):
2332 2015-03-03 Sam Weinig <sam@webkit.org>
2334 [Content Extensions] Split parsing and compiling of content extensions into their own files
2335 https://bugs.webkit.org/show_bug.cgi?id=142259
2337 Reviewed by Anders Carlsson.
2339 Add basic unit test for the content filter compiler.
2341 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2342 * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Added.
2343 (WebCore::ContentExtensions::operator<<):
2344 (TestWebKitAPI::ContentFilterTest::SetUp):
2345 (TestWebKitAPI::TEST_F):
2347 2015-03-04 Matthew Mirman <mmirman@apple.com>
2349 Cleaned up BuildAndTestFactory to not be a near duplicate of TestFactory
2350 https://bugs.webkit.org/show_bug.cgi?id=142230
2352 Reviewed by Csaba Osztrogonác.
2354 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2356 (TestFactory.getProduct): Added
2357 (TestFactory.__init__): moved downloader to getProduct
2358 (BuildAndTestFactory):
2359 (BuildAndTestFactory.getProduct): Added
2360 (BuildAndTestFactory.__init__): made to call TestFactory.__init__ and append steps to the end.
2361 (BuildAndTestWebKit2Factory): Deleted. Wasn't used anywhere.
2363 2015-03-04 Debarshi Ray <debarshir@gnome.org>
2365 [GTK] WebView should hold a reference on WebContext because non-default contexts are a reality
2366 https://bugs.webkit.org/show_bug.cgi?id=142225
2368 Reviewed by Carlos Garcia Campos.
2370 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2371 (testWebViewWebContextLifetime):
2374 2015-03-03 David Kilzer <ddkilzer@apple.com>
2376 [iOS] Crash logs can't be found on ios-simulator because WebKitTestRunner returns the wrong process name
2377 <http://webkit.org/b/142243>
2379 Reviewed by Alexey Proskuryakov.
2381 * WebKitTestRunner/TestController.cpp:
2382 (WTR::TestController::webProcessName):
2383 (WTR::TestController::networkProcessName):
2384 - Return the same process name on iOS and Mac because they both
2385 use the same process name for local engineering builds.
2387 2015-03-03 David Kilzer <ddkilzer@apple.com>
2389 check-webkit-style: Add exception for FrameworkSoftLink.h header order
2390 <http://webkit.org/b/141872>
2392 Reviewed by Alex Christensen.
2394 * Scripts/webkitpy/style/checkers/cpp.py: Remove unneeded
2395 semi-colons in various places and fix whitespace.
2396 (_IncludeState): Add _SOFT_LINK_HEADER and _SOFT_LINK_SECTION
2398 (_IncludeState.__init__): Add self._visited_soft_link_section
2399 boolean state variable.
2400 (_IncludeState.visited_soft_link_section): Getter for
2401 self._visited_soft_link_section.
2402 (_IncludeState.check_next_include_order): Update state machine
2403 for soft-link headers. Add check that soft-link headers always
2405 (_classify_include): Add check for soft-link header type.
2406 (check_include_line): Return early if there is a soft-link
2409 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2410 (OrderOfIncludesTest.test_public_primary_header): Add tests for
2411 including soft-link headers.
2412 (OrderOfIncludesTest.test_classify_include): Add test for
2413 _SOFT_LINK_HEADER type.
2415 2015-03-03 Alexey Proskuryakov <ap@apple.com>
2417 build.webkit.org/dashboard: Don't repeatedly handle each test type
2418 https://bugs.webkit.org/show_bug.cgi?id=142211
2420 Reviewed by Tim Horton and Matt Hanson.
2422 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2423 (Buildbot.prototype.javascriptTestResultsURLForIteration): Deleted.
2424 (Buildbot.prototype.apiTestResultsURLForIteration): Deleted.
2425 (Buildbot.prototype.platformAPITestResultsURLForIteration): Deleted.
2426 (Buildbot.prototype.webkitpyTestResultsURLForIteration): Deleted.
2427 (Buildbot.prototype.webkitperlTestResultsURLForIteration): Deleted.
2428 (Buildbot.prototype.bindingsTestResultsURLForIteration): Deleted.
2429 Removed functions that build a link to test step results. The buildbot provides
2430 these links in JSON.
2432 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2433 (BuildbotIteration): Put failing tests into an array, instead of named variables.
2434 (BuildbotIteration.ProductiveSteps): Removed step names that are not used on build.webkit.org.
2435 We can easily add them to the map as needed.
2436 (BuildbotIteration.TestSteps): Added a list of test steps to be displayed by test queues.
2437 (BuildbotIteration.prototype._parseData): Moved code for parsing step results away
2438 to BuildbotTestResults class. We used to parse here, build an intermediate data structure,
2439 and then build a BuildbotTestResults object, which was strange.
2440 (BuildbotIteration.prototype.loadLayoutTestResults): Ditto.
2442 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2443 Corrected an unrelated assertion that was buggy, and kept firing.
2445 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
2446 (BuildbotTestResults):
2447 (BuildbotTestResults.prototype._parseResults.resultSummarizer):
2448 (BuildbotTestResults.prototype._parseResults):
2449 (BuildbotTestResults.prototype.addFullLayoutTestResults):
2450 Moved the code for parsing JSON results for a single step here.
2452 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2453 (BuildbotTesterQueueView.prototype._testStepFailureDescription):
2454 (BuildbotTesterQueueView.prototype._testStepFailureDescriptionWithCount):
2455 (BuildbotTesterQueueView.prototype._presentPopoverForGenericTestFailures):
2456 (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Deleted.
2457 (BuildbotTesterQueueView.prototype.update): Deleted.
2458 (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds): Deleted.
2459 Updated for the new data structures. One behavior change is that we now display individual
2460 counts when multiple test kinds fail, e.g. "1Â javascript test failure, 83+Â layout
2461 test failures, 3Â platform api test failures".
2463 2015-03-03 Matthew Mirman <mmirman@apple.com>
2465 JSC tests should not be repeated twice for each branch builder, and should if possible have their own queue.
2466 https://bugs.webkit.org/show_bug.cgi?id=142094
2468 Reviewed by Csaba Osztrogonác.
2470 * BuildSlaveSupport/build.webkit.org-config/config.json: Added bots 155 and 157
2471 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2473 (TestFactory.__init__): Made running of JSC tests conditional.
2474 (TestAllButJSCFactory):
2475 (TestJSCFactory): Added.
2476 (TestJSCFactory.__init__):
2477 (TestWebKit2AndJSCFactory): Added factory to not run JSC tests on WebKit2.
2479 2015-03-03 David Kilzer <ddkilzer@apple.com>
2481 `build-webkit --help` is wrong about how to build for the iOS simulator
2482 <http://webkit.org/b/142223>
2484 Reviewed by Csaba Osztrogonác.
2486 * Scripts/build-webkit: Fix help.
2488 2015-03-03 Carlos Garcia Campos <cgarcia@igalia.com>
2490 Unreviewed. Bump libsoup version to 2.49.91.1 to fix 32 bit build.
2492 * gtk/jhbuild.modules:
2494 2015-03-03 Carlos Garcia Campos <cgarcia@igalia.com>
2496 [SOUP] Synchronous XMLHttpRequests can time out when we reach the max connections limit
2497 https://bugs.webkit.org/show_bug.cgi?id=141508
2499 Reviewed by Sergio Villar Senin.
2501 Add a unit test to check that synchronous XHRs load even if the
2502 maximum connection limits are reached.
2504 * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2505 (testWebViewSyncRequestOnMaxConns):
2508 * gtk/jhbuild.modules: Bump libsoup version to 2.49.91.
2510 2015-03-02 Alexey Proskuryakov <ap@apple.com>
2512 Update the name of ASan build step.
2514 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2516 2015-03-02 Jer Noble <jer.noble@apple.com>
2518 [WK1][WK2][Mac] Fullscreen animation is incorrect when page is scaled.
2519 https://bugs.webkit.org/show_bug.cgi?id=142121
2521 Reviewed by Simon Fraser.
2523 Add a test which changes the WebView's page scale, then enters fullscreen mode, and verifies
2524 that the initial and final screen rects for the web content are as expected.
2526 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2527 * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.html: Added.
2528 * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm: Added.
2529 (-[FullscreenStateDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
2530 (runJavaScriptAlert):
2531 (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
2532 (TestWebKitAPI::FullscreenZoomInitialFrame::teardownView):
2533 (TestWebKitAPI::FullscreenZoomInitialFrame::setPageScale):
2534 (TestWebKitAPI::FullscreenZoomInitialFrame::sendMouseDownEvent):
2535 (TestWebKitAPI::FullscreenZoomInitialFrame::runTest):
2536 (TestWebKitAPI::TEST_F):
2538 2015-03-01 David Kilzer <ddkilzer@apple.com>
2540 LayoutTestRealy: Prepend __XPC_ to the key, not the value!
2544 LayoutTestRelay: App environment variables not set for --guard-malloc or --leaks
2545 <http://webkit.org/b/142145>
2547 * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2548 (-[LTRelayController _environmentVariables]): Fix think-o.
2550 2015-03-01 David Kilzer <ddkilzer@apple.com>
2552 LayoutTestRelay: App environment variables not set for --guard-malloc or --leaks
2553 <http://webkit.org/b/142145>
2555 Reviewed by Simon Fraser.
2557 * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2558 (-[LTRelayController _environmentVariables]): Add.
2559 (-[LTRelayController launchApp]): Use -_environmentVariables.
2561 2015-02-28 David Kilzer <ddkilzer@apple.com>
2563 [iOS] Stop running webkit-build-directory on every layout test
2565 This was originally fixed by David Farler for Bug 135409 in
2568 * Scripts/webkitpy/port/ios.py:
2569 (IOSSimulatorPort.relay_path): Mark as @memoized so it doesn't
2570 run webkit-build-directory every time it's called.
2572 2015-02-28 Youenn Fablet <youenn.fablet@crf.canon.fr>
2574 W3C importer should use filesystem instead of shutil/host
2575 https://bugs.webkit.org/show_bug.cgi?id=142012
2577 Reviewed by Bem Jones-Bey.
2579 Removed direct use of python shutil and os, except for os.walk which will require its own fix.
2581 * Scripts/webkitpy/w3c/test_importer.py:
2583 (TestImporter.do_import):
2584 (TestImporter.find_importable_tests):
2585 (TestImporter.import_tests):
2586 (TestImporter.remove_deleted_files):
2587 (TestImporter.write_import_log):
2589 2015-02-28 Youenn Fablet <youenn.fablet@crf.canon.fr>
2591 W3C test importer should use filesystem to read and write files
2592 https://bugs.webkit.org/show_bug.cgi?id=142084
2594 Reviewed by Bem Jones-Bey.
2596 Use of FileSystem.write_binary_file, read_text_file and write_text_file in lieu of open().
2598 * Scripts/webkitpy/w3c/test_importer.py:
2599 (TestImporter.import_tests):
2600 (TestImporter.remove_deleted_files):
2601 (TestImporter.write_import_log):
2603 2015-02-27 Sam Weinig <sam@webkit.org>
2605 Add WebKit2 SPI to create a DOM File object
2606 https://bugs.webkit.org/show_bug.cgi?id=142109
2608 Reviewed by Tim Horton.
2610 Add a test for WKBundleFileHandleRef.
2612 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2613 * TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle.cpp: Added.
2614 (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2615 (TestWebKitAPI::didFinishLoadForFrame):
2616 (TestWebKitAPI::TEST):
2617 * TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle_Bundle.cpp: Added.
2618 (TestWebKitAPI::WKBundleFileHandleTest::WKBundleFileHandleTest):
2619 * TestWebKitAPI/Tests/WebKit2/bundle-file.html: Added.
2621 2015-02-27 Michael Saboff <msaboff@apple.com>
2623 Add ability for run-jsc-benchmarks to set library path from test binary when run on a build bot
2624 https://bugs.webkit.org/show_bug.cgi?id=142112
2626 Reviewed by Filip Pizlo.
2628 Added check for VMs in the form of <someDir>/{DumpRenderTree,webkitTestRunner,jsc} and use
2629 <someDir> as the library path.
2631 * Scripts/run-jsc-benchmarks:
2633 2015-02-27 Alex Christensen <achristensen@webkit.org>
2635 [WinCairo] Unreviewed build fix.
2637 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
2638 Use TestWebKitAPIPrefix.h like in TestWebKitAPICommon.props.
2640 2015-02-27 Anders Carlsson <andersca@apple.com>
2642 Add infrastructure for handling website data in the network process
2643 https://bugs.webkit.org/show_bug.cgi?id=142092
2645 Reviewed by Andreas Kling.
2647 Add a menu item that will fetch all website data, delete the returned data records, and
2648 fetch all website data again so we can confirm that it's all empty.
2650 * MiniBrowser/mac/WK2BrowserWindowController.m:
2651 (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
2653 2015-02-26 Brent Fulgham <bfulgham@apple.com>
2655 [Win] Remove remaining SafariTheme cruft
2656 https://bugs.webkit.org/show_bug.cgi?id=142075
2658 Reviewed by Anders Carlsson.
2660 Remove reference to SafariTheme-switching preference.
2662 * DumpRenderTree/win/DumpRenderTree.cpp:
2663 (resetWebPreferencesToConsistentValues):
2664 (prepareConsistentTestingEnvironment):
2666 2015-02-26 Doug Russell <d_russell@apple.com>
2668 AX: Expose caret browsing preference to accessibility API
2669 https://bugs.webkit.org/show_bug.cgi?id=141862
2671 Reviewed by Chris Fleizach.
2673 Exposing the caret browsing setting on WebCore::Frame via the accessibility API would allow assistive tech apps to enable it contextually (for example, when the assistive tech app is running).
2674 Enabling caret browsing when assistive tech apps are running greatly improves the reliability of keyboard navigation on the web. Most especially in cases where selection would be disrupted by focus events.
2676 * DumpRenderTree/AccessibilityUIElement.cpp:
2677 (setBoolAttributeValueCallback):
2678 (selectedTextMarkerRangeCallback):
2679 (resetSelectedTextMarkerRangeCallback):
2680 (AccessibilityUIElement::setBoolAttributeValue):
2681 (AccessibilityUIElement::selectedTextMarkerRange):
2682 (AccessibilityUIElement::resetSelectedTextMarkerRange):
2683 (AccessibilityUIElement::getJSClass):
2684 * DumpRenderTree/AccessibilityUIElement.h:
2685 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2686 (AccessibilityUIElement::setBoolAttributeValue):
2687 (AccessibilityUIElement::selectedTextMarkerRange):
2688 (AccessibilityUIElement::resetSelectedTextMarkerRange):
2689 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2690 (WTR::AccessibilityUIElement::selectedTextMarkerRange):
2691 (WTR::AccessibilityUIElement::resetSelectedTextMarkerRange):
2692 (WTR::AccessibilityUIElement::setBoolAttributeValue):
2693 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2694 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2695 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2696 (WTR::AccessibilityUIElement::setBoolAttributeValue):
2697 (WTR::AccessibilityUIElement::selectedTextMarkerRange):
2698 (WTR::AccessibilityUIElement::resetSelectedTextMarkerRange):
2700 2015-02-26 Brent Fulgham <bfulgham@apple.com>
2702 [Win] Remove WebKitExportGenerator project (and related)
2703 https://bugs.webkit.org/show_bug.cgi?id=142035
2705 Reviewed by Dean Jackson.
2707 * win/AssembleBuildLogs/AssembleLogs.cmd: Don't look for a
2708 build log from WebKitExportGenerator.
2710 2015-02-26 Csaba Osztrogonác <ossy@webkit.org>
2712 [EFL] Bump EFL version to 1.13.0
2713 https://bugs.webkit.org/show_bug.cgi?id=141708
2715 Reviewed by Gyuyoung Kim.
2717 * efl/jhbuild.modules:
2719 2015-02-26 Sam Weinig <sam@webkit.org>
2721 Check in missing WebEditingTester.xcconfig file.
2723 * WebEditingTester/Configurations/WebEditingTester.xcconfig: Added.
2725 2015-02-26 Csaba Osztrogonác <ossy@webkit.org>
2727 [webkitpy] Remove skipped file related crufts
2728 https://bugs.webkit.org/show_bug.cgi?id=142046
2730 Reviewed by Ryosuke Niwa.
2732 * Scripts/webkitpy/port/base.py:
2733 (Port.skipped_layout_tests):
2734 (Port._tests_from_skipped_file_contents): Deleted.
2736 (Port._expectations_from_skipped_files): Deleted.
2737 * Scripts/webkitpy/port/mac_unittest.py:
2738 (MacTest.test_default_timeout_ms):
2740 (test_tests_from_skipped_file_contents): Deleted.
2742 2015-02-26 Brent Fulgham <bfulgham@apple.com>
2744 [Win] Unreviewed WinCairo build fix after r180653.
2746 TestWebKitAPI should know about proper WEBCORE_EXPORT definitions.
2748 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2749 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
2750 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
2751 * TestWebKitAPI/win/TestWebKitAPIPrefix.cpp: Added.
2752 * TestWebKitAPI/win/TestWebKitAPIPrefix.h: Added.
2754 2015-02-25 Brent Fulgham <bfulgham@apple.com>
2756 [Win] Use WEBCORE_EXPORT instead of Definition file
2757 https://bugs.webkit.org/show_bug.cgi?id=141734
2759 Reviewed by Alex Christensen.
2761 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2762 Use a precompiled header so we can define our export macros properly.
2763 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj.filters:
2764 Visual studio automatic update stuff.
2765 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
2766 Set up Precompiled Header use for project..
2767 * DumpRenderTree/win/DumpRenderTreePrefix.cpp: Added.
2768 * DumpRenderTree/DumpRenderTreePrefix.h: Update with proper export
2769 declarations for building DumpRenderTree as a client of
2772 2015-02-25 Mark Lam <mark.lam@apple.com>
2774 ASan does not like JSC::MachineThreads::tryCopyOtherThreadStack.
2775 <https://webkit.org/b/141672>
2777 Reviewed by Alexey Proskuryakov.
2779 ASan does not like the fact that we memcpy the stack for GC scans. So,
2780 we're working around this by using our own memcpy (asanUnsafeMemcpy)
2781 implementation that we can tell ASan to ignore.
2783 Also removed the previous added directive to ignore *tryCopyOtherThreadStack*
2784 which isn't effective for working around this issue.
2786 * asan/webkit-asan-ignore.txt:
2788 2015-02-25 Benjamin Poulain <bpoulain@apple.com>
2790 CodeBlock crashes when dumping op_push_name_scope
2791 https://bugs.webkit.org/show_bug.cgi?id=141953
2793 Reviewed by Filip Pizlo.
2795 * Scripts/run-jsc-stress-tests:
2797 2015-02-25 Youenn Fablet <youenn.fablet@crf.canon.fr>
2799 W3C test importer should use argparse instead of optparse
2800 https://bugs.webkit.org/show_bug.cgi?id=142013
2802 Reviewed by Bem Jones-Bey.
2804 * Scripts/webkitpy/w3c/test_importer.py:
2805 (main): Updating according argparse.
2806 (parse_args): Moving from optparse to argparse.
2808 2015-02-25 Brady Eidson <beidson@apple.com>
2810 Get rid of TestInvocation::pathOrURL
2811 https://bugs.webkit.org/show_bug.cgi?id=142021
2813 Reviewed by Tim Horton.
2815 The pathOrURL string is a relative path used as an argument to WebKitTestRunner,
2816 but most code that uses it expected an absolute path.
2818 This gets rid of the member and replaces all uses with a more descriptive "urlContains" method.
2820 * WebKitTestRunner/TestController.cpp:
2821 (WTR::TestController::updateWebViewSizeForTest):
2822 (WTR::TestController::updateWindowScaleForTest):
2823 (WTR::shouldUseFixedLayout):
2824 (WTR::TestController::updateLayoutTypeForTest):
2826 * WebKitTestRunner/TestInvocation.cpp:
2827 (WTR::TestInvocation::TestInvocation):
2828 (WTR::TestInvocation::urlContains):
2829 (WTR::TestInvocation::shouldLogFrameLoadDelegates):
2830 (WTR::TestInvocation::shouldLogHistoryClientCallbacks):
2831 (WTR::TestInvocation::invoke):
2832 (WTR::shouldLogFrameLoadDelegates): Deleted.
2833 (WTR::shouldLogHistoryClientCallbacks): Deleted.
2834 * WebKitTestRunner/TestInvocation.h:
2835 (WTR::TestInvocation::pathOrURL): Deleted.
2837 * WebKitTestRunner/ios/TestControllerIOS.mm:
2838 (WTR::shouldMakeViewportFlexible):
2839 (WTR::TestController::platformConfigureViewForTest):
2841 * WebKitTestRunner/mac/TestControllerMac.mm:
2842 (WTR::shouldUseThreadedScrolling):
2843 (WTR::TestController::platformConfigureViewForTest):
2845 2015-02-25 Brady Eidson <beidson@apple.com>
2847 Layout test support for user content filters
2848 https://bugs.webkit.org/show_bug.cgi?id=142018
2850 Reviewed by Tim Horton.
2852 * WebKitTestRunner/TestController.cpp:
2853 (WTR::TestController::resetStateToConsistentValues): Clear all user content filters between tests.
2855 * WebKitTestRunner/mac/TestControllerMac.mm:
2856 (WTR::TestController::platformConfigureViewForTest): For all tests with usercontentfilter/ in their path try to load a matching .json
2857 file before loading the test itself.
2859 2015-02-24 Sam Weinig <sam@webkit.org>
2861 Convert WebEditingTester to use xcconfig files
2862 https://bugs.webkit.org/show_bug.cgi?id=141879
2864 Reviewed by Darin Adler.
2866 Add xcconfig files to WebEditingTester based on the ones used by MiniBrowser.
2868 * WebEditingTester/Configurations: Added.
2869 * WebEditingTester/Configurations/Base.xcconfig: Added.
2870 * WebEditingTester/Configurations/DebugRelease.xcconfig: Added.
2871 * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
2873 2015-02-24 Andy Estes <aestes@apple.com>
2875 Teach MiniBrowser how to disable per-window web processes
2876 https://bugs.webkit.org/show_bug.cgi?id=141988
2878 Reviewed by Darin Adler.
2880 * MiniBrowser/mac/AppDelegate.m:
2881 (defaultConfiguration): Created a _WKProcessPoolConfiguration with maximumProcessCount == 1 if per-window web processes are disabled.
2882 * MiniBrowser/mac/SettingsController.h:
2883 * MiniBrowser/mac/SettingsController.m:
2884 (-[SettingsController _populateMenu]): Added a new Settings menu item.
2885 (-[SettingsController validateMenuItem:]): Validated the new Settings menu item.
2886 (-[SettingsController togglePerWindowWebProcessesDisabled:]): Displayed an alert informing the user that MiniBrowser must be restarted for the setting to take effect.
2887 (-[SettingsController perWindowWebProcessesDisabled]): Returned the value from user defaults.
2889 2015-02-24 Alexey Proskuryakov <ap@apple.com>
2891 Bot watcher's dashboard sometimes hits an assertion: data.num_missing === this.layoutTestResults.testsWithMissingResults.length
2892 https://bugs.webkit.org/show_bug.cgi?id=141889
2894 Reviewed by Darin Adler.
2896 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2898 2015-02-24 Yusuke Suzuki <utatane.tea@gmail.com>
2900 REGRESSION(r179429): Can't type comments in Facebook
2901 https://bugs.webkit.org/show_bug.cgi?id=141859
2903 Reviewed by Brent Fulgham.
2905 Drop javaScriptExperimentsEnabled and specify JavaScriptRuntimeFlagsAllEnabled as KJavaScriptRuntimeFlags.
2907 * DumpRenderTree/mac/DumpRenderTree.mm:
2908 (resetWebPreferencesToConsistentValues):
2909 * DumpRenderTree/win/DumpRenderTree.cpp:
2910 (resetWebPreferencesToConsistentValues):
2911 * WebKitTestRunner/TestController.cpp:
2912 (WTR::TestController::resetPreferencesToConsistentValues):
2914 2015-02-24 Michael Catanzaro <mcatanzaro@igalia.com>
2916 Crash loading local file with WebPageProxy::loadAlternateHTMLString
2917 https://bugs.webkit.org/show_bug.cgi?id=141867
2919 Reviewed by Anders Carlsson.
2921 * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
2922 (TestWebKitAPI::loadAlternateHTMLString): Split most of this test into a function so it can
2923 be shared with the new test.
2924 (TestWebKitAPI::TEST): Add a cross-platform test for this crash.
2925 * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp: Add a GTK+ test for this crash.
2926 (testLoadAlternateHTMLForLocalPage):
2929 2015-02-24 David Kilzer <ddkilzer@apple.com>
2931 [iOS] Implement WTR::activateFonts() to fix missing fonts in WebKit2 test runs
2932 <http://webkit.org/b/141900>
2934 Reviewed by Myles C. Maxfield.
2936 * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
2937 (OTHER_LDFLAGS_BASE): Link to CoreText.framework.
2938 * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm: Rename from Tools/WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm.
2939 - Rename to share code with iOS.
2940 - Add USE(APPKIT) around AppKit-specific headers and code.
2941 - Fix a check-webkit-style warning.
2942 * WebKitTestRunner/InjectedBundle/ios/ActivateFontsIOS.mm: Remove.
2943 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2944 - Rename mac/ActivateFonts.mm to cocoa/ActivateFontsCocoa.mm.
2945 - Remove ios/ActivateFontsIOS.mm.
2946 - Fix InjectedBundle/cocoa group to represent the directory on
2947 disk. Includes a change to InjectedBundlePageCocoa.mm.
2949 2015-02-23 Commit Queue <commit-queue@webkit.org>
2951 Unreviewed, rolling out r180547 and r180550.
2952 https://bugs.webkit.org/show_bug.cgi?id=141957
2954 Broke 10 Windows tests. (Requested by bfulgham_ on #webkit).
2956 Reverted changesets:
2958 "REGRESSION(r179429): Can't type comments in Facebook"
2959 https://bugs.webkit.org/show_bug.cgi?id=141859
2960 http://trac.webkit.org/changeset/180547
2962 "Constructor returning null should construct an object instead
2964 https://bugs.webkit.org/show_bug.cgi?id=141640
2965 http://trac.webkit.org/changeset/180550
2967 2015-02-23 Yusuke Suzuki <utatane.tea@gmail.com>
2969 REGRESSION(r179429): Can't type comments in Facebook
2970 https://bugs.webkit.org/show_bug.cgi?id=141859
2972 Reviewed by Geoffrey Garen.
2974 Drop javaScriptExperimentsEnabled and specify JavaScriptRuntimeFlagsAllEnabled as KJavaScriptRuntimeFlags.
2976 * DumpRenderTree/mac/DumpRenderTree.mm:
2977 (resetWebPreferencesToConsistentValues):
2978 * WebKitTestRunner/TestController.cpp:
2979 (WTR::TestController::resetPreferencesToConsistentValues):
2981 2015-02-23 KwangHyuk Kim <hyuki.kim@samsung.com>
2984 https://bugs.webkit.org/show_bug.cgi?id=141909
2986 Reviewed by Gyuyoung Kim.
2988 Fix eo errors that occur whenever minibrowser is launched.
2989 - elm_obj_entry_text_style_user_push can only be applied for elm_entry
2990 - elm_obj_win_resize_object_add's first parameter should be elm_win
2992 * MiniBrowser/efl/main.c:
2995 2015-02-23 Ryosuke Niwa <rniwa@webkit.org>
2997 Unreviewed build fix after r180535. Removed the test case that wasn't compiling.
2999 * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3000 (TestWebKitAPI::TEST):
3002 2015-02-23 Brent Fulgham <bfulgham@apple.com>
3004 WTF::WeakPtr should rename 'forgot' to 'clear' and support nullptr assignment
3005 https://bugs.webkit.org/show_bug.cgi?id=141935
3007 Reviewed by Myles C. Maxfield.
3009 * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3010 (TestWebKitAPI::TEST): Updated for 'clear' method rename, and added a few
3011 tests for assigning from nullptr.
3013 2015-02-23 Brent Fulgham <bfulgham@apple.com>
3015 WTF::WeakPtr should have a 'forget' method.
3016 https://bugs.webkit.org/show_bug.cgi?id=141923
3018 Reviewed by Myles C. Maxfield.
3020 * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3021 (TestWebKitAPI::TEST): Added 'Forget' tests case.
3023 2015-02-23 Alexey Proskuryakov <ap@apple.com>
3025 build.webkit.org/dashboard CrashOnly queues should not show two green bubbles
3026 https://bugs.webkit.org/show_bug.cgi?id=141920
3028 Reviewed by Tim Horton.
3030 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3031 (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
3032 Do the same thing as we do for regular green bubbles.
3034 2015-02-23 Alexey Proskuryakov <ap@apple.com>
3036 Bot watcher's dashboard doesn't show a popover for commit history when all commits were to another branch
3037 https://bugs.webkit.org/show_bug.cgi?id=141925
3039 Reviewed by Tim Horton.
3041 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3042 (BuildbotQueueView.prototype._presentPopoverForRevisionRange):
3044 2015-02-23 Anders Carlsson <andersca@apple.com>
3046 Add API for fetching website data records to _WKWebsiteDataStore
3047 https://bugs.webkit.org/show_bug.cgi?id=141926
3049 Reviewed by Beth Dakin.
3051 * MiniBrowser/mac/MainMenu.xib:
3052 * MiniBrowser/mac/WK2BrowserWindowController.m:
3053 (-[WK2BrowserWindowController fetchWebsiteData:]):
3054 Add menu item to fetch and dump website data.
3056 2015-02-23 David Kilzer <ddkilzer@apple.com>
3058 [iOS] run-webkit-tests --leaks is broken because IOSSimulatorPort has no is_snowleopard attribute
3059 <http://webkit.org/b/141884>
3061 Reviewed by Alexey Proskuryakov.
3063 * Scripts/webkitpy/port/leakdetector.py:
3064 (LeakDetector._callstacks_to_exclude_from_leaks): Remove
3065 snowleopard, lion and older leaks. Add known leak for
3066 mavericks, but check Port.operating_system before calling
3068 * Scripts/webkitpy/port/mac.py:
3069 (MacPort.is_snowleopard): Delete.
3070 (MacPort.is_lion): Delete.
3071 (MacPort.is_mavericks): Add.
3073 2015-02-23 Alexey Proskuryakov <ap@apple.com>
3075 build.webkit.org/dashboard should filter out commits to other branches
3076 https://bugs.webkit.org/show_bug.cgi?id=140362
3078 Reviewed by Tim Horton.
3080 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3082 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3083 (BuildbotQueueView.prototype._presentPopoverForPendingCommits):
3084 (BuildbotQueueView.prototype._presentPopoverForRevisionRange):
3085 (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration):
3086 (BuildbotQueueView.prototype.revisionContentForIteration):
3087 (BuildbotQueueView.prototype._appendPendingRevisionCount): Deleted.
3088 (BuildbotQueueView.prototype._popoverLinesForCommitRange): Deleted.
3089 (BuildbotQueueView.prototype._revisionPopoverContentForIteration): Deleted.
3090 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3091 (Trac.prototype.get oldestRecordedRevisionNumber):
3092 (Trac.prototype.commitsOnBranch):
3093 (Trac.prototype._xmlTimelineURL):
3094 (Trac.prototype._convertCommitInfoElementToObject):
3095 (Trac.prototype._update):
3096 (Trac.prototype.startPeriodicUpdates):
3097 (Trac.prototype.loadMoreHistoricalData):
3098 (Trac.prototype.update): Deleted.
3100 2015-02-21 Youenn Fablet <youenn.fablet@crf.canon.fr>
3102 Tests don't work on some bots: Failed to stop wptwk
3103 https://bugs.webkit.org/show_bug.cgi?id=141235
3105 Reviewed by Ryosuke Niwa.
3107 Logging of server subprocesses in launcher script.
3108 Killing of server subprocesses when stopping/before starting.
3109 Removed empty __init.py__ file creation as importer now ensures these files cannot be empty anymore.
3111 * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
3112 (main): Removed empty __init.py__ file creation as importer now ensures these files cannot be empty anymore. Added logging in a file of server subprocesses to clean them in case of abnormal shutdown.
3113 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3114 (WebPlatformTestServer.__init__):
3115 (WebPlatformTestServer._stop_running_subservers): Kill server subprocesses based on file created by wpt launcher.
3116 (WebPlatformTestServer):
3117 (WebPlatformTestServer.stop): Overriden to ensure killing subprocesses in case of orphaned process.
3118 (WebPlatformTestServer._stop_running_server): Killing of wpt launcher process after regular shutdown.
3119 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
3120 (TestWebPlatformTestServer.test_server_closes_previously_spawned_instance): Reworked the test to call start/stop with an existing pid file.
3121 (TestWebPlatformTestServer.test_import_web_platform_test_modules): No change.
3122 (TestWebPlatformTestServer):
3123 (TestWebPlatformTestServer.test_corrupted_subserver_files): Checked that server subprocess cleaning does not throw in case of bad server pid file.
3125 2015-02-20 Timothy Horton <timothy_horton@apple.com>
3127 [WebEditingTester] Allow dropping HTML files on the app
3128 https://bugs.webkit.org/show_bug.cgi?id=141834
3130 Reviewed by Simon Fraser.
3132 * WebEditingTester/AppDelegate.m:
3133 (-[WebEditingAppDelegate openDocument:]):
3134 (-[WebEditingAppDelegate application:openFile:]):
3135 Implement application:openFile:, factoring file loading code out of openDocument.
3137 * WebEditingTester/Info.plist:
3138 Register as an editor for HTML files.
3140 * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
3141 Enrica is not an organization.
3143 2015-02-20 Timothy Horton <timothy_horton@apple.com>
3145 [WebEditingTester] Expand "WK" to "WebKit" in a few places
3146 https://bugs.webkit.org/show_bug.cgi?id=141833
3148 Reviewed by Anders Carlsson.
3150 * WebEditingTester/AppDelegate.h:
3151 * WebEditingTester/AppDelegate.m:
3152 (-[WebEditingAppDelegate newEditor:]):
3153 (-[WebEditingAppDelegate toggleUseWebKit2ByDefault:]):
3154 (-[WebEditingAppDelegate validateMenuItem:]):
3155 (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]):
3156 (-[WebEditingAppDelegate applicationDidFinishLaunching:]): Deleted.
3157 (-[WebEditingAppDelegate applicationWillTerminate:]): Deleted.
3158 (-[WebEditingAppDelegate showOperations:]): Deleted.
3159 * WebEditingTester/MainMenu.xib:
3160 The WK abbreviation is unnaturally grating in menu items for some reason.
3162 2015-02-20 Timothy Horton <timothy_horton@apple.com>
3164 [WebEditingTester] Add a custom protocol for loading canned content
3165 https://bugs.webkit.org/show_bug.cgi?id=141830
3167 Reviewed by Enrica Casucci.
3169 Add a canned:// protocol handler, which can be used to emulate behaviors
3170 in WebKit client apps (like Mail) that use custom protocol handlers,
3171 which can have important effects on editing (mostly, the URLs are only
3172 valid inside of the client application, but not when copied/dragged out).
3174 For now, we only support two canned files:
3176 canned://dice is a PNG of dice (stolen from LayoutTests/)
3177 canned://text is the string "canned text" served as text/html
3179 In the future we could support things like very large (generated) files,
3180 progressive loading, etc. to further simulate conditions in other apps.
3182 * WebEditingTester/AppDelegate.m:
3183 (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
3184 Register the protocol with CFNetwork, and the scheme with WebKit2.
3186 * WebEditingTester/Canned Content/dice.png: Added.
3187 * WebEditingTester/CannedContent.h: Added.
3188 * WebEditingTester/CannedContent.m: Added.
3189 (-[CannedContent initWithRequest:cachedResponse:client:]):
3190 (+[CannedContent canonicalRequestForRequest:]):
3191 (+[CannedContent canInitWithRequest:]):
3192 We only want to handle canned:// URLs.
3194 (-[CannedContent startLoading]):
3195 For now, immediately load the two files we know about.
3196 Otherwise, immediately fail the load.
3198 (-[CannedContent stopLoading]):
3199 * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
3201 2015-02-20 Timothy Horton <timothy_horton@apple.com>
3203 [WebEditingTester] Implement an open panel
3204 https://bugs.webkit.org/show_bug.cgi?id=141829
3206 Reviewed by Simon Fraser.
3208 * WebEditingTester/AppDelegate.m:
3209 (-[WebEditingAppDelegate _useWebKit1ForOpeningDocument:]):
3210 (-[WebEditingAppDelegate _useWebKit2ForOpeningDocument:]):
3211 (-[WebEditingAppDelegate openDocument:]):
3212 Add an open panel (with radio buttons to pick which WebKit to open with).
3213 Loads the file as an HTML string.
3215 2015-02-20 Simon Fraser <simon.fraser@apple.com>
3217 [WebEditingTester] @properties, dot syntax, and remember the window position
3218 https://bugs.webkit.org/show_bug.cgi?id=141843
3220 Reviewed by Tim Horton.
3222 Modernize a bit with more dot syntax, use @property for the web views,
3223 and give the main window an Autosave name so it remembers the widow position.
3225 * WebEditingTester/WK1WebDocumentController.m:
3226 (-[WK1WebDocumentController awakeFromNib]):
3227 (-[WK1WebDocumentController loadHTMLString:]):
3228 * WebEditingTester/WK2WebDocumentController.m:
3229 (-[WK2WebDocumentController awakeFromNib]):
3230 * WebEditingTester/WebDocument.xib:
3232 2015-02-20 Timothy Horton <timothy_horton@apple.com>
3234 [WebEditingTester] Hook up key equivalents for new window action
3235 https://bugs.webkit.org/show_bug.cgi?id=141828
3237 Reviewed by Enrica Casucci.
3239 * WebEditingTester/AppDelegate.h:
3240 * WebEditingTester/AppDelegate.m:
3241 (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
3242 (-[WebEditingAppDelegate newEditor:]):
3243 (-[WebEditingAppDelegate _defaultWebDocumentControllerClass]):
3244 (-[WebEditingAppDelegate toggleUseWK2ByDefault:]):
3245 (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]):
3246 (defaultConfiguration): Deleted.
3247 (-[WebEditingAppDelegate applicationWillTerminate:]): Deleted.
3248 Move WKWebViewConfiguration setup into WK2WebDocumentController.
3249 Remove unused application termination code.
3250 Update new-window menu item key equivalents when launching and when
3251 changing the use-WebKit2-by-default setting.
3252 Make WebDocumentController subclasses all initialized the same way,
3253 and use that to factor out alloc/init.
3254 Rename loadContent to loadHTMLString for future use.
3256 * WebEditingTester/MainMenu.xib:
3257 Add default key equivalents.
3258 Cmd-N will always make the default kind of window (controlled by the pref).
3259 Cmd-Opt-N will always make the other kind.
3260 The menu items are configured as alternates so they only show up if you
3261 press alt (just like in MiniBrowser).
3263 * WebEditingTester/WK1WebDocumentController.m:
3264 (-[WK1WebDocumentController loadHTMLString:]):
3265 (-[WK1WebDocumentController loadContent]): Deleted.
3266 * WebEditingTester/WK2WebDocumentController.h:
3267 * WebEditingTester/WK2WebDocumentController.m:
3268 (defaultConfiguration):
3269 (-[WK2WebDocumentController awakeFromNib]):
3270 (-[WK2WebDocumentController loadHTMLString:]):
3271 (-[WK2WebDocumentController initWithConfiguration:]): Deleted.
3272 (-[WK2WebDocumentController dealloc]): Deleted.
3273 * WebEditingTester/WebDocumentController.h:
3274 * WebEditingTester/WebDocumentController.m:
3275 (-[WebDocumentController init]):
3276 (-[WebDocumentController initWithWindow:]):
3277 (+[WebDocumentController defaultEditingSource]):
3278 (-[WebDocumentController loadHTMLString:]):
3279 (-[WebDocumentController windowDidLoad]): Deleted.
3280 (-[WebDocumentController defaultEditingSource]): Deleted.
3281 (-[WebDocumentController applicationTerminating]): Deleted.
3282 (-[WebDocumentController loadContent]): Deleted.
3284 2015-02-20 Timothy Horton <timothy_horton@apple.com>
3286 [WebEditingTester] ARC-ify WebEditingTester
3287 https://bugs.webkit.org/show_bug.cgi?id=141827
3289 Reviewed by Sam Weinig.
3291 * WebEditingTester/AppDelegate.m:
3292 (-[WebEditingAppDelegate showOperations:]):
3293 * WebEditingTester/EditingOperations.m:
3294 (editingOperations):
3295 * WebEditingTester/WK1WebDocumentController.m:
3296 (-[WK1WebDocumentController dealloc]): Deleted.
3297 * WebEditingTester/WK2WebDocumentController.m:
3298 (-[WK2WebDocumentController dealloc]): Deleted.
3299 * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
3300 Turn on ARC and remove a few retain/release/autorelease calls.
3301 We don't need to implement dealloc in either document controller
3302 because WebView and WKWebView's UIDelegate property does not hold a
3305 2015-02-20 Timothy Horton <timothy_horton@apple.com>
3307 [WebEditingTester] Factor out list of editing operations
3308 https://bugs.webkit.org/show_bug.cgi?id=141826
3310 Reviewed by Sam Weinig.
3312 * WebEditingTester/AppDelegate.m:
3313 (-[WebEditingAppDelegate showOperations:]):
3314 * WebEditingTester/EditingOperations.h: Added.
3315 * WebEditingTester/EditingOperations.m: Added.
3316 (editingOperations):
3317 * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
3318 Move EditingOperations array to its own file, and make it an NSArray
3319 instead of a C array. Adjust accordingly in showOperations:.
3321 2015-02-20 Michael Saboff <msaboff@apple.com>
3323 DFG JIT needs to check for stack overflow at the start of Program and Eval execution
3324 https://bugs.webkit.org/show_bug.cgi?id=141676
3326 Reviewed by Filip Pizlo.
3328 Set the newly added --maximumEvalCacheableSourceLength option for eager test runs. This is needed
3329 to allow the eval out of stack tests to tier up. Without this option, we don't cache the likely
3330 large string expression that we want to eval.
3332 * Scripts/run-jsc-stress-tests:
3334 2015-02-19 Daniel Bates <dabates@apple.com>
3336 REGRESSION (r180239): run-webkit-test fails to boot simulator device that was booted by previous test run
3337 https://bugs.webkit.org/show_bug.cgi?id=141815
3338 <rdar://problem/19893933>
3340 Reviewed by Simon Fraser.
3342 Fixes an issue where run-webkit-tests would fail to boot the WebKit Tester simulator device if it
3343 was booted by iOS Simulator in a previous run of run-webkit-test.
3345 * Scripts/webkitpy/port/ios.py:
3346 (IOSSimulatorPort.check_sys_deps): Added logic moved from IOSSimulatorPort.setup_test_run().
3347 (IOSSimulatorPort.setup_test_run): Moved logic to quit the iOS Simulator app and wait for the
3348 testing device to be in the shutdown state from here to IOSSimulatorPort.check_sys_deps().
3350 2015-02-19 David Kilzer <ddkilzer@apple.com>
3352 check-webkit-style: do not warn about missing primary header for *SoftLink.cpp files
3353 <http://webkit.org/b/141799>
3355 Reviewed by Alex Christensen.
3357 * Scripts/webkitpy/style/checkers/cpp.py:
3358 (_IncludeState.check_next_include_order): Don't emit a warning
3359 if the primary header exists and the source file name ends with
3360 "SoftLink.cpp". Add 'filename' argument to method.
3361 (check_include_line): Pass in 'filename'.
3363 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3364 (OrderOfIncludesTest.test_check_next_include_order__no_config):
3365 (OrderOfIncludesTest.test_check_next_include_order__no_self):
3366 (OrderOfIncludesTest.test_check_next_include_order__likely_then_config):
3367 (OrderOfIncludesTest.test_check_next_include_order__other_then_config):
3368 (OrderOfIncludesTest.test_check_next_include_order__config_then_other_then_likely):
3369 - Add test filename arguments for calls to
3370 check_next_include_order().
3371 (OrderOfIncludesTest.test_primary_header): Add test for a file
3372 name ending in "SoftLink.cpp".
3374 2015-02-18 Enrica Casucci <enrica@apple.com>
3376 Add new tool to test editable Webviews.
3377 https://bugs.webkit.org/show_bug.cgi?id=141772
3379 Reviewed by Tim Horton.
3381 Adding WebEditingTester, a Cocoa application to
3382 test WK1 and Wk2 views in editable mode.
3384 * WebEditingTester: Added.
3385 * WebEditingTester/AppDelegate.h: Added.
3386 * WebEditingTester/AppDelegate.m: Added.
3387 (-[WebEditingAppDelegate init]):
3388 (defaultConfiguration):
3389 (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
3390 (-[WebEditingAppDelegate applicationWillTerminate:]):
3391 (-[WebEditingAppDelegate newEditor:]):
3392 (-[WebEditingAppDelegate showOperations:]):
3393 (-[WebEditingAppDelegate useWebKit2ByDefault]):
3394 (-[WebEditingAppDelegate toggleUseWK2ByDefault:]):
3395 (-[WebEditingAppDelegate validateMenuItem:]):
3396 * WebEditingTester/Info.plist: Added.
3397 * WebEditingTester/MainMenu.xib: Added.
3398 * WebEditingTester/WK1WebDocumentController.h: Added.
3399 * WebEditingTester/WK1WebDocumentController.m: Added.
3400 (-[WK1WebDocumentController awakeFromNib]):
3401 (-[WK1WebDocumentController loadContent]):
3402 (-[WK1WebDocumentController dealloc]):
3403 (-[WK1WebDocumentController pasteAsMarkup:]):
3404 * WebEditingTester/WK2WebDocumentController.h: Added.
3405 * WebEditingTester/WK2WebDocumentController.m: Added.
3406 (-[WK2WebDocumentController initWithConfiguration:]):
3407 (-[WK2WebDocumentController pasteAsMarkup:]):
3408 (-[WK2WebDocumentController awakeFromNib]):
3409 (-[WK2WebDocumentController dealloc]):
3410 (-[WK2WebDocumentController loadContent]):
3411 * WebEditingTester/WebDocument.xib: Added.
3412 * WebEditingTester/WebDocumentController.h: Added.
3413 * WebEditingTester/WebDocumentController.m: Added.
3414 (-[WebDocumentController initWithWindow:]):
3415 (-[WebDocumentController windowDidLoad]):
3416 (-[WebDocumentController defaultEditingSource]):
3417 (-[WebDocumentController applicationTerminating]):
3418 (-[WebDocumentController loadContent]):
3419 * WebEditingTester/WebEditingTester.xcodeproj: Added.
3420 * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj: Added.
3421 * WebEditingTester/main.m: Added.
3424 2015-02-18 Csaba Osztrogonác <ossy@webkit.org>
3426 Run JSC tests on ARM EFL bots
3427 https://bugs.webkit.org/show_bug.cgi?id=141165
3429 Reviewed by Alexey Proskuryakov.
3431 * BuildSlaveSupport/build.webkit.org-config/config.json:
3432 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3433 (RunJavaScriptCoreTests.countFailures):
3434 (RunRemoteJavaScriptCoreTests):
3435 (RunRemoteJavaScriptCoreTests.start):
3436 (BuildAndRemoteJSCTestsFactory):
3437 (BuildAndRemoteJSCTestsFactory.__init__):
3439 2015-02-18 Alexey Proskuryakov <ap@apple.com>
3441 Streamline unexported function build fixes
3442 https://bugs.webkit.org/show_bug.cgi?id=141761
3444 Reviewed by Alex Christensen.
3446 * Scripts/check-for-weak-vtables-and-externals: (readXcode5SymbolsToIgnore): Deleted.
3447 We don't need to ignore symbols that are not exported due to the .unexp file.
3449 2015-02-18 Timothy Horton <timothy_horton@apple.com>
3451 Remove more references to WebCore.exp.in
3452 https://bugs.webkit.org/show_bug.cgi?id=141747
3454 Reviewed by Alexey Proskuryakov.
3456 * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
3459 2015-02-17 Myles C. Maxfield <mmaxfield@apple.com>
3461 Windows test results should not fall back to mac-mountainlion after r180176
3462 https://bugs.webkit.org/show_bug.cgi?id=141719
3464 Reviewed by Brent Fulgham.
3466 * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
3467 (_should_file_trigger_build):
3468 * Scripts/webkitpy/port/win.py:
3469 (WinPort.default_baseline_search_path):
3470 * Scripts/webkitpy/port/win_unittest.py:
3471 (WinPortTest.test_baseline_search_path):
3473 2015-02-17 Daniel Bates <dabates@apple.com>
3475 [iOS] run-webkit-tests should check that simctl can boot and shutdown simulator device before running tests
3476 https://bugs.webkit.org/show_bug.cgi?id=141718
3478 Reviewed by Alex Christensen.
3480 We should only run layout tests if simctl can successfully boot and shutdown the testing device.
3482 * Scripts/webkitpy/port/ios.py:
3483 (IOSSimulatorPort.check_sys_deps): Modified to call Simulator.check_simulator_device_and_erase_if_needed().
3484 Log a error and return False if we are unable to boot the simulator device so that the caller can take
3485 appropriate action, say exit(3) before running any layout tests.
3486 * Scripts/webkitpy/xcode/simulator.py:
3487 (Simulator._boot_and_shutdown_simulator_device): Added. Boot and then shut down the simulator device
3488 with the specified UDID.
3489 (Simulator.check_simulator_device_and_erase_if_needed): Added. Checks that simulator device
3490 with the specified UDID can successfully boot and shut down. We make at most two attempts to
3491 boot and shut down the device, erasing the device between tries so as to restore the device
3492 to a known good state.
3494 2015-02-17 Daniel Bates <dabates@apple.com>
3496 run_webkit_tests.py should not know about iOS Simulator details
3497 https://bugs.webkit.org/show_bug.cgi?id=141711
3499 Reviewed by Alex Christensen.
3501 Run_webkit_tests.py should only parse the iOS-specific command
3502 line options --runtime and --device-type. Let the port-specific
3503 logic in ios.py validate the parsed options and instantiate
3504 internal data structures.
3506 Currently run_webkit_tests.py parses the iOS-specific command
3507 line options --runtime and --device-type, validates them, and
3508 instantiates internal data structures from the parsed strings.
3509 Instead the validation logic and instantiation of internal
3510 data structures should be handled by the iOS port object.
3512 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3513 (_set_up_derived_options): Remove logic to validate --runtime and --device-type
3514 and instantiate internal data structures for them.
3515 * Scripts/webkitpy/port/driver.py:
3516 (IOSSimulatorDriver.cmd_line): Modified to reference IOSSimulatorPort.simulator_runtime
3517 and IOSSimulatorPort.simulator_device_type for the iOS Simulator runtime and device type,
3519 * Scripts/webkitpy/port/ios.py: Sort the list of imports.
3520 (IOSSimulatorPort.simulator_runtime): Added. Instantiates a Runtime
3521 object from --runtime, if specified. Otherwise, instantiates a Runtime
3522 object for the latest installed iphonesimulator SDK version.
3523 (IOSSimulatorPort.simulator_device_type): Added. Instantiates a DeviceType
3524 object from --device-type, if specified. Otherwise, instantiates
3525 a DeviceType object for a iPhone 5 or iPhone 5s when on a 32-bit and 64-bit
3526 machine, respectively.
3527 (IOSSimulatorPort.check_sys_deps): Added. Validate if the chosen iOS simulator
3528 runtime is available to use.
3529 (IOSSimulatorPort.testing_device): Modified to make use of properties simulator_device_type
3530 and simulator_runtime for the iOS Simulator device type and runtime, respectively.
3531 * Scripts/webkitpy/xcode/simulator.py:
3532 (Runtime.from_version_string): Added. Turns around and calls Runtime.from_identifier()
3533 with a runtime identifier for the specified iOS version.
3535 2015-02-17 Dana Burkart <dburkart@apple.com>
3537 ASan does not like JSC::MachineThreads::tryCopyOtherThreadStack
3538 https://bugs.webkit.org/show_bug.cgi?id=141672
3540 Reviewed by David Kilzer.
3542 * asan/webkit-asan-ignore.txt:
3544 2015-02-17 Alex Christensen <achristensen@webkit.org>
3546 Remove WebCore.exp.in and clean up.
3547 https://bugs.webkit.org/show_bug.cgi?id=141491
3549 Reviewed by Andreas Kling.
3551 * Scripts/sort-export-file: Removed.
3552 * Scripts/webkitpy/style/checker.py:
3555 (CheckerDispatcher._file_type):
3556 (CheckerDispatcher._create_checker):
3557 Don't check if the export files are sorted.
3558 * Scripts/webkitpy/style/checkers/exportfile.py: Removed.
3559 * Scripts/webkitpy/style/checkers/exportfile_unittest.py: Removed.
3561 2015-02-17 Carlos Garcia Campos <cgarcia@igalia.com>
3563 Unreviewed. Fix GTK+ make distcheck.
3565 Do not exclude bmalloc directory from the tarball.
3567 * gtk/manifest.txt.in:
3569 2015-02-17 Carlos Garcia Campos <cgarcia@igalia.com>
3571 Unreviewed. Fix /webkit2/WebKitDOMNode/dom-cache after r180214.
3573 I forgot to add the return of a bool function.
3575 * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
3576 (WebKitDOMNodeTest::testDOMCache):
3578 2015-02-17 Carlos Garcia Campos <cgarcia@igalia.com>
3580 [GTK] GObject DOM bindings object are cached forever
3581 https://bugs.webkit.org/show_bug.cgi?id=141558
3583 Reviewed by Sergio Villar Senin.
3585 Add checks for all DOM objects to ensure they are not leaked. Also
3586 add a dedicated test for the DOM Object Cache.
3588 * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
3589 (WebKitDOMNodeFilterTest::testTreeWalker):
3590 (WebKitDOMNodeFilterTest::testNodeIterator):
3591 * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
3592 (WebKitDOMNodeTest::testHierarchyNavigation):
3593 (WebKitDOMNodeTest::testInsertion):
3594 (WebKitDOMNodeTest::testTagNames):
3595 (WebKitDOMNodeTest::testDOMCache):
3597 * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:
3598 (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
3599 (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
3600 (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
3601 * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
3602 (testWebKitDOMObjectCache):
3604 * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
3605 (documentLoadedCallback):
3607 2015-02-16 Carlos Garcia Campos <cgarcia@igalia.com>
3609 [GTK] WebKitFrame objects are never released
3610 https://bugs.webkit.org/show_bug.cgi?id=141641
3612 Reviewed by Martin Robinson.
3614 Add a way to check GObjects leaks for WebProcess tests and check
3615 WebKitFrame objects are not leaked.
3617 * TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp:
3618 (WebKitFrameTest::testMainFrame):
3619 (WebKitFrameTest::testURI):
3620 (WebKitFrameTest::testJavaScriptContext):
3621 * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
3622 (WebProcessTest::assertObjectIsDeletedWhenTestFinishes):
3624 * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
3626 2015-02-16 Tim Horton <timothy_horton@apple.com>
3628 Fix the MiniBrowser build with newer clang
3630 * MiniBrowser/mac/SettingsController.m:
3631 (-[SettingsController _toggleBooleanDefault:]):
3632 * MiniBrowser/mac/WK1BrowserWindowController.m:
3633 (-[WK1BrowserWindowController windowWillClose:]):
3634 * MiniBrowser/mac/WK2BrowserWindowController.m:
3635 (-[WK2BrowserWindowController windowWillClose:]):
3636 NSApp is id and clang gets confused about which -delegate we're talking about.
3638 2015-02-16 Antti Koivisto <antti@apple.com>
3640 Develop/Disable Caches does not properly disable disk cache
3641 https://bugs.webkit.org/show_bug.cgi?id=141636
3643 Reviewed by Anders Carlsson.
3645 Make testRunner.setCacheModel() use the WKContext interface so the model gets passed to
3646 the network process too.
3648 This makes setCacheModel asynchronous but there don't seem to be any tests that expect otherwise.
3650 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3651 (WTR::InjectedBundle::beginTesting):
3652 (WTR::InjectedBundle::setCacheModel):
3653 * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3654 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3656 Forward to TestController.
3658 (WTR::TestRunner::setCacheModel):
3659 * WebKitTestRunner/TestInvocation.cpp:
3660 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3662 2015-02-16 Andrzej Badowski <a.badowski@samsung.com>
3664 Unreviewed. Add myself as a committer.
3666 * Scripts/webkitpy/common/config/contributors.json:
3668 2015-02-15 David Kilzer <ddkilzer@apple.com>
3670 REGRESSION (r180082): WebCore Debug buil