Tools/ChangeLog

   1 2016-08-12  Alex Christensen  <achristensen@webkit.org>
   2
   3         Make URLParser work with URLs missing URL parts
   4         https://bugs.webkit.org/show_bug.cgi?id=160824
   5
   6         Reviewed by Brady Eidson.
   7
   8         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
   9         (TestWebKitAPI::s):
  10         (TestWebKitAPI::checkURL):
  11         (TestWebKitAPI::TEST_F):
  12         (TestWebKitAPI::eq): Deleted.
  13
  14 2016-08-12  John Wilander  <wilander@apple.com>
  15
  16         Add HashCountedSet API tests to TestWTFLibrary target
  17         https://bugs.webkit.org/show_bug.cgi?id=160815
  18
  19         Reviewed by Alex Christensen.
  20
  21         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  22             Added HashCountedSet.cpp and sorted the file reference section
  23             according to UNIX sort.
  24
  25 2016-08-12  Ryosuke Niwa  <rniwa@webkit.org>
  26
  27         run-benchmark should run JetStream 1.1 instead of 1.0.1
  28         https://bugs.webkit.org/show_bug.cgi?id=160816
  29
  30         Reviewed by Filip Pizlo.
  31
  32         Use the latest JetStream 1.1 in run-benchmark.
  33
  34         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
  35         (BenchmarkBuilder.__exit__):
  36         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Updated to apply against 1.1 directory.
  37         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Updated to use r190897, which is the last
  38         change to JetStream directory.
  39
  40 2016-08-12  Alex Christensen  <achristensen@webkit.org>
  41
  42         Initial URLParser implementation
  43         https://bugs.webkit.org/show_bug.cgi?id=160811
  44
  45         Reviewed by Brady Eidson.
  46
  47         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
  48         (TestWebKitAPI::eq):
  49         (TestWebKitAPI::checkURL):
  50         (TestWebKitAPI::TEST_F):
  51
  52 2016-08-12  Brady Eidson  <beidson@apple.com>
  53
  54         Fix the 32-bit Mac build after:
  55         Add WK2 ExperimentalFeature support to MiniBrowser
  56         https://bugs.webkit.org/show_bug.cgi?id=160788
  57
  58         Unreviewed.
  59
  60         Sprinkle "#if WK_API_ENABLED"s liberally.
  61
  62         * MiniBrowser/mac/AppDelegate.m:
  63         (defaultConfiguration):
  64         * MiniBrowser/mac/SettingsController.m:
  65         (-[SettingsController _populateMenu]):
  66         (-[SettingsController validateMenuItem:]):
  67
  68 2016-08-12  Philippe Normand  <pnormand@igalia.com>
  69
  70         [GStreamer][OWR] Video rendering fixes
  71         https://bugs.webkit.org/show_bug.cgi?id=160764
  72
  73         Reviewed by Xabier Rodriguez-Calvar.
  74
  75         * gtk/jhbuild.modules: Bump to current OpenWebRTC master.
  76
  77 2016-08-12  Per Arne Vollan  <pvollan@apple.com>
  78
  79         Add missing return statement in convertFast function added in r204376.
  80
  81         Unreviewed.
  82
  83         * Scripts/webkitpy/common/system/path.py:
  84         (_CygPath.convertFast):
  85
  86 2016-08-11  Brady Eidson  <beidson@apple.com>
  87
  88         Add WK2 ExperimentalFeature support to MiniBrowser.
  89         https://bugs.webkit.org/show_bug.cgi?id=160788
  90
  91         Reviewed by Alex Christensen.
  92
  93         * MiniBrowser/mac/AppDelegate.h:
  94         * MiniBrowser/mac/AppDelegate.m:
  95         (defaultConfiguration):
  96         (defaultPreferences):
  97
  98         * MiniBrowser/mac/SettingsController.m:
  99         (-[SettingsController _populateMenu]):
 100         (-[SettingsController validateMenuItem:]):
 101         (-[SettingsController toggleExperimentalFeature:]):
 102
 103 2016-08-11  Aakash Jain  <aakash_jain@apple.com>
 104
 105         Keep EWS logs for longer
 106         https://bugs.webkit.org/show_bug.cgi?id=160776
 107
 108         Reviewed by Daniel Bates.
 109
 110         * EWSTools/start-queue-mac.sh: Keep logs for 30 days instead of 14 days.
 111
 112 2016-08-11  Simon Fraser  <simon.fraser@apple.com>
 113
 114         iOS DRT/WTR project cleanup
 115         https://bugs.webkit.org/show_bug.cgi?id=160778
 116
 117         Reviewed by Tim Horton.
 118
 119         Move TARGETED_DEVICE_FAMILY from the project to an xcconfig file.
 120
 121         Remove AppDelegate.* which were unused.
 122
 123         Exclude ios/Launch.storyboard on more platforms.
 124
 125         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 126         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
 127         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
 128         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
 129         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Removed.
 130         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Removed.
 131         (-[AppDelegate application:didFinishLaunchingWithOptions:]): Deleted.
 132
 133 2016-08-11  Alex Christensen  <achristensen@webkit.org>
 134
 135         Fix Yosemite bots' cookie accept policies after r204365.
 136         https://bugs.webkit.org/show_bug.cgi?id=160758
 137
 138         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
 139         (TEST):
 140         This makes the test fully clean up after itself.
 141
 142 2016-08-11  Alex Christensen  <achristensen@webkit.org>
 143
 144         Fix Yosemite bots' cookie accept policies after r204365.
 145         https://bugs.webkit.org/show_bug.cgi?id=160758
 146
 147         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
 148         (TEST):
 149         I didn't restore the cookieAcceptPolicy of the sharedHTTPCookieStorage after changing it with this API test.
 150         On Yosemite, this is changing the cookieAcceptPolicy that DumpRenderTree uses.
 151         On more recent Cocoa platforms, it is only changing the cookieAcceptPolicy that TestWebKitAPI uses, which isn't
 152         causing any problems because there are no other API tests that do anything with cookies.
 153         My solution will be to restore the original cookieAcceptPolicy after running this API test to clean up,
 154         but first I am committing this patch setting the cookieAcceptPolicy to NSHTTPCookieAcceptPolicyOnlyFromMainDocumentDomain
 155         to reset any bots that have run tests since r204365.  I will commit a followup that sets it to originalCookieAcceptPolicy.
 156
 157 2016-08-11  Aakash Jain  <aakash_jain@apple.com>
 158
 159         EWS should check if the patch is still valid before executing every major step
 160         https://bugs.webkit.org/show_bug.cgi?id=160739
 161         rdar://problem/27768813
 162
 163         Reviewed by Alexey Proskuryakov.
 164
 165         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
 166         (CommitQueueTask.run): validate method is now executed in base class.
 167         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
 168         (EarlyWarningSystemTask.run): validate method is now executed in base class.
 169         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
 170         (StyleQueueTask.validate): Raise an PatchIsNotValid exception instead of returning False.
 171         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
 172         (PatchAnalysisTask._run_command): validate the patch before executing any command. This is to ensure
 173         that we do not waste time on any patch which has become invalid (e.g.: obsolete, r-).
 174         * Scripts/webkitpy/tool/commands/perfalizer.py:
 175         (PerfalizerTask.validate): Added.
 176         * Scripts/webkitpy/tool/commands/queues_unittest.py:
 177         (test_manual_reject_during_processing): Updated test case.
 178
 179 2016-08-11  Alex Christensen  <achristensen@webkit.org>
 180
 181         Add URLParser stub
 182         https://bugs.webkit.org/show_bug.cgi?id=160770
 183
 184         Reviewed by Sam Weinig.
 185
 186         * TestWebKitAPI/PlatformGTK.cmake:
 187         * TestWebKitAPI/PlatformWin.cmake:
 188         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 189         * TestWebKitAPI/Tests/WebCore/URLParser.cpp: Added.
 190         (TestWebKitAPI::TEST_F):
 191
 192 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
 193
 194         [iOS DRT] Allow DRT to be iPad-sized in the iPad simulator
 195         https://bugs.webkit.org/show_bug.cgi?id=160761
 196
 197         Reviewed by Tim Horton.
 198
 199         Give iOS DRT a Launch storyboard.
 200
 201         Have it use a UIViewController so future forms testing works correctly.
 202
 203         Add TARGETED_DEVICE_FAMILY = "1,2" to the build settings for the .app, so that it
 204         can run in iPad mode.
 205
 206         Remove empty InfoPlist.strings files.
 207
 208         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 209         * DumpRenderTree/ios/Info.plist:
 210         * DumpRenderTree/ios/Launch.storyboard: Added.
 211         * DumpRenderTree/mac/DumpRenderTree.mm:
 212         (createWebViewAndOffscreenWindow):
 213         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
 214         * WebKitTestRunner/WebKitTestRunnerApp/en.lproj/InfoPlist.strings: Removed.
 215         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
 216         (WTR::PlatformWebView::PlatformWebView): Drive-by leak fix.
 217
 218 2016-08-11  Per Arne Vollan  <pvollan@apple.com>
 219
 220         [Win] Unable to reliably run tests in parallel
 221         https://bugs.webkit.org/show_bug.cgi?id=140914
 222
 223         Reviewed by Brent Fulgham.
 224
 225         The cygpath utility function can fail badly when running with multiple DumpRenderTree
 226         processes. We can use string replacement to convert the Cygwin path to a Windows path
 227         instead.
 228
 229         * Scripts/webkitpy/common/system/path.py:
 230         (cygpathFast):
 231         * Scripts/webkitpy/port/driver.py:
 232         (Driver._command_from_driver_input):
 233
 234 2016-08-10  Alex Christensen  <achristensen@webkit.org>
 235
 236         Fix crash when changing cookie accept policy after r204327
 237         https://bugs.webkit.org/show_bug.cgi?id=160758
 238
 239         Reviewed by Simon Fraser.
 240
 241         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 242         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm: Added.
 243         (-[CookieAcceptPolicyMessageHandler userContentController:didReceiveScriptMessage:]):
 244         (TEST):
 245         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieMessage.html: Added.
 246
 247 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
 248
 249         [iOS WK2] Have WebKitTestRunnerApp.app use a UIViewController, and fix to avoid the status bar
 250         https://bugs.webkit.org/show_bug.cgi?id=160757
 251
 252         Reviewed by Tim Horton.
 253
 254         When programmatically creating the test UIWindow, make a root UIViewController and parent
 255         the WKWebView in its view. This makes the app more like a normal UIKit application.
 256
 257         Move the WKWebView down 20px to avoid the status bar.
 258
 259         Give the UIWindow a gray background so it's obvious where the window and view positioned.
 260
 261         Sorted the project file. Removed the link to UIKit which showed red, and wasn't necessary.
 262
 263         Remove duplicate references to Launch.storyboard.
 264
 265         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
 266         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Add license.
 267         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Add license.
 268         (-[AppDelegate applicationWillResignActive:]): Deleted.
 269         (-[AppDelegate applicationDidEnterBackground:]): Deleted.
 270         (-[AppDelegate applicationWillEnterForeground:]): Deleted.
 271         (-[AppDelegate applicationDidBecomeActive:]): Deleted.
 272         (-[AppDelegate applicationWillTerminate:]): Deleted.
 273         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
 274         (WTR::viewRectForWindowRect):
 275         (WTR::PlatformWebView::PlatformWebView):
 276         (WTR::PlatformWebView::setWindowFrame):
 277
 278 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
 279
 280         [iOS WK2] Use the simulated device's screen size, rather than a harcoded size
 281         https://bugs.webkit.org/show_bug.cgi?id=160748
 282
 283         Reviewed by Tim Horton.
 284
 285         Use the main UIScreen's bounds for the window size if we're using a flexible viewport. This
 286         opens the door for tests using other device sizes.
 287
 288         * WebKitTestRunner/ios/TestControllerIOS.mm:
 289         (WTR::TestController::platformConfigureViewForTest):
 290
 291 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
 292
 293         Sort the feature flags in the FEATURE_DEFINES lines
 294         https://bugs.webkit.org/show_bug.cgi?id=160742
 295
 296         Reviewed by Anders Carlsson.
 297
 298         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
 299
 300 2016-08-09  Simon Fraser  <simon.fraser@apple.com>
 301
 302         Logging and other minor improvements to iOS webkitpy
 303         https://bugs.webkit.org/show_bug.cgi?id=160722
 304
 305         Reviewed by Dan Bates.
 306
 307         Fix --debug-rwt-logging to log all the calls to simctl as well as device state information,
 308         to make it easier to debug launching issues.
 309
 310         Have reset_preferences() reset the device, rather than just nuking the data
 311         directory (which broke some versions of the simulator).
 312
 313         Make the Simulator.app launch in the background with open -g.
 314
 315         Wait for the simulator device to be in a known state in some more places.
 316
 317         * Scripts/webkitpy/port/ios.py:
 318         (IOSSimulatorPort.setup_test_run):
 319         (IOSSimulatorPort._quit_ios_simulator):
 320         (IOSSimulatorPort.clean_up_test_run):
 321         (IOSSimulatorPort.setup_environ_for_server):
 322         (IOSSimulatorPort.reset_preferences):
 323         * Scripts/webkitpy/xcode/simulator.py:
 324         (Device.create):
 325         (Device.delete):
 326         (Device):
 327         (Device.reset):
 328         (Simulator.wait_until_device_is_booted):
 329         (Simulator.wait_until_device_is_in_state):
 330         (Simulator):
 331         (Simulator.delete_device):
 332         (Simulator.reset_device):
 333         (Simulator.lookup_or_create_device):
 334
 335 2016-08-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
 336
 337         [GTK][EFL] ALSA_CARD environment variable is not passed for layout tests.
 338         https://bugs.webkit.org/show_bug.cgi?id=160697
 339
 340         Reviewed by Antonio Gomes.
 341
 342         * Scripts/webkitpy/port/base.py:
 343         (Port.to.setup_environ_for_server): Add ALSA_CARD and sort the Linux
 344         list of environment variables to copy.
 345
 346 2016-08-09  George Ruan  <gruan@apple.com>
 347
 348         Implement functionality of media capture on iOS
 349         https://bugs.webkit.org/show_bug.cgi?id=158945
 350         <rdar://problem/26893343>
 351
 352         Reviewed by Tim Horton.
 353
 354         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Enable Media
 355         Capture feature on iOS.
 356
 357 2016-08-09  Saam Barati  <sbarati@apple.com>
 358
 359         Parser<LexerType>::parseFunctionInfo() has the wrong info about captured vars when a function is not cached.
 360         https://bugs.webkit.org/show_bug.cgi?id=160671
 361         <rdar://problem/27756112>
 362
 363         Reviewed by Mark Lam.
 364
 365         * Scripts/run-jsc-stress-tests:
 366
 367 2016-08-09  Alexey Proskuryakov  <ap@apple.com>
 368
 369         Make directory reading code in iOSSimulatorDevices() more strict
 370         https://bugs.webkit.org/show_bug.cgi?id=160702
 371
 372         Reviewed by Tim Horton.
 373
 374         * Scripts/webkitdirs.pm:
 375         (iOSSimulatorDevices):
 376
 377 2016-08-06  Sam Weinig  <sam@webkit.org>
 378
 379         Replace NodeOrString with std::variant<RefPtr<Node>, String>
 380         https://bugs.webkit.org/show_bug.cgi?id=160638
 381
 382         Reviewed by Anders Carlsson.
 383
 384         * TestWebKitAPI/CMakeLists.txt:
 385         * TestWebKitAPI/Tests/WTF/Variant.cpp:
 386         Add additional tests for the initial state of std::variant and using
 387         makeVisitor for visiting.
 388
 389 2016-08-09  Aakash Jain  <aakash_jain@apple.com>
 390
 391         EWS logging should ensure the logging to file is stopped on queue termination
 392         https://bugs.webkit.org/show_bug.cgi?id=160698
 393         rdar://problem/24464570
 394
 395         Reviewed by Daniel Bates.
 396
 397         * Scripts/webkitpy/tool/bot/queueengine.py:
 398         (QueueEngine._stopping): Stop logging to file on queue termination.
 399         (QueueEngine._begin_logging): Configure the Python logger to log to file.
 400         * Scripts/webkitpy/common/system/logutils.py:
 401         (configure_logger_to_log_to_file): Return the handler so as to enable caller to remove it later.
 402         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
 403         (QueueEngineTest._run_engine): Removed extra newline character to improve log readability.
 404         * Scripts/webkitpy/tool/commands/queues.py:
 405         (AbstractQueue._log_directory): Reverting to os.path.join as we don't have host object.
 406         (AbstractQueue.queue_log_path): Same.
 407         (AbstractQueue.begin_work_queue): Removed logging initialization, it is now being done in QueueEngine.
 408         (AbstractQueue.__init__): Removed host parameter, not required anymore, it was required by logging initialization
 409         which moved to QueueEngine now.
 410         (PatchProcessingQueue.__init__): Same.
 411         (CommitQueue.__init__): Same.
 412         (AbstractReviewQueue.__init__): Same.
 413         (StyleQueue.__init__): Same.
 414         * Scripts/webkitpy/tool/commands/queues_unittest.py:
 415         (TestCommitQueue): Removed host parameter.
 416         (TestCommitQueue.__init__): Same.
 417         (AbstractPatchQueueTest.test_next_patch): Same.
 418         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
 419         (test_commit_queue_failure): Same.
 420         (mock_run_webkit_patch):
 421         (MockCommitQueueTask.results_from_patch_test_run): Same.
 422         (test_rollout_lands): Same.
 423         (test_non_valid_patch): Same.
 424         (test_auto_retry): Same.
 425         (test_style_queue_with_watch_list_exception): Same.
 426         (TestQueue.__init__): Deleted.
 427         (TestReviewQueue.__init__): Deleted.
 428         (TestFeederQueue.__init__): Deleted.
 429
 430 2016-08-09  Konstantin Tokarev  <annulen@yandex.ru>
 431
 432         webkit-gtk tarball fails to build due to missing files
 433         https://bugs.webkit.org/show_bug.cgi?id=160684
 434
 435         Reviewed by Alex Christensen.
 436
 437         * gtk/manifest.txt.in: Added back spi directories.
 438
 439 2016-08-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
 440
 441         [GTK] Build the jhbuild with -O2 optimization level by default
 442         https://bugs.webkit.org/show_bug.cgi?id=160544
 443
 444         Reviewed by Michael Catanzaro.
 445
 446         * gtk/jhbuildrc: Pass -O2 when building the JHBuild, as also -g1
 447         which don't increases the required disk space significatively and
 448         provides better debug information than no passing it.
 449
 450 2016-08-09  Csaba Osztrogonác  <ossy@webkit.org>
 451
 452         Allow more --cmakeargs option in build-jsc and build-webkit
 453         https://bugs.webkit.org/show_bug.cgi?id=160340
 454
 455         Reviewed by Michael Catanzaro.
 456
 457         * Scripts/build-jsc:
 458         * Scripts/build-webkit:
 459
 460 2016-08-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
 461
 462         Do not check if WebKitLibraries folder exists on EFL and GTK
 463         https://bugs.webkit.org/show_bug.cgi?id=160659
 464
 465         Reviewed by Csaba Osztrogonác.
 466
 467         Though WebKitLibraries is only needed by mac and win ports,
 468         EFL and GTK ports have checked whether it exists.
 469
 470         * Scripts/build-webkit:
 471
 472 2016-08-08  Aakash Jain  <aakash_jain@apple.com>
 473
 474         Some EWS console logs doesn't go to log file
 475         https://bugs.webkit.org/show_bug.cgi?id=160585
 476         rdar://problem/24464570
 477
 478         Reviewed by Daniel Bates.
 479
 480         * Scripts/webkitpy/common/system/logutils.py:
 481         (FileSystemHandler._open): Ensure that we open logfile in append mode in order to avoid
 482         any possible overwriting.
 483         * Scripts/webkitpy/common/system/filesystem.py:
 484         (FileSystem.open_text_file_for_writing): Add should_append parameter to append to file.
 485         * Scripts/webkitpy/common/system/filesystem_mock.py:
 486         (MockFileSystem.open_text_file_for_writing): Same.
 487         * Scripts/webkitpy/common/system/filesystem_unittest.py:
 488         (RealFileSystemTest.test_read_and_write_text_file): Removed unused variable 'hex_equivalent'.
 489         (RealFileSystemTest.test_append_to_text_file): Added new unit test for testing append functionality.
 490         * Scripts/webkitpy/tool/commands/queues.py:
 491         (AbstractQueue.begin_work_queue): Configure the logger for overall webkitpy to log to file.
 492         This will ensure that all the sub-modules inside webkitpy will log to file.
 493
 494 2016-08-08  Simon Fraser  <simon.fraser@apple.com>
 495
 496         Have the iOS platform interit from the Apple platform in webkitpy
 497         https://bugs.webkit.org/show_bug.cgi?id=160672
 498
 499         Reviewed by Dan Bates.
 500
 501         The IOSSimulatorPort used to inherit from Port, rather than ApplePort.
 502         Fix this, and move duplicated code from IOSSimulatorPort and MacPort into
 503         ApplePort.
 504
 505         Since WinPort also inherits from ApplePort, it needs to stub out some things
 506         that are unavailable on Windows (leaks, sampling).
 507
 508         Some SnowLeopard-related code and the associated test were removed.
 509
 510         * Scripts/webkitpy/port/apple.py:
 511         (ApplePort.__init__):
 512         (ApplePort):
 513         (ApplePort._make_leak_detector):
 514         (ApplePort.default_timeout_ms):
 515         (ApplePort.supports_per_test_timeout):
 516         (ApplePort.should_retry_crashes):
 517         (ApplePort._generate_all_test_configurations):
 518         (ApplePort.check_for_leaks):
 519         (ApplePort.print_leaks_summary):
 520         (ApplePort._path_to_webcore_library):
 521         (ApplePort.show_results_html_file):
 522         (ApplePort._merge_crash_logs):
 523         (ApplePort._look_for_all_crash_logs_in_log_dir):
 524         (ApplePort._get_crash_log):
 525         (ApplePort.look_for_new_crash_logs):
 526         (ApplePort.sample_process):
 527         (ApplePort.sample_file_path):
 528         (ApplePort.look_for_new_samples):
 529         (ApplePort._path_to_helper):
 530         (ApplePort.determine_full_port_name): Deleted.
 531         * Scripts/webkitpy/port/ios.py:
 532         (IOSSimulatorPort):
 533         (IOSSimulatorPort.__init__):
 534         (IOSSimulatorPort.default_timeout_ms): Deleted.
 535         (IOSSimulatorPort.supports_per_test_timeout): Deleted.
 536         (IOSSimulatorPort.should_retry_crashes): Deleted.
 537         (IOSSimulatorPort.check_for_leaks): Deleted.
 538         (IOSSimulatorPort.print_leaks_summary): Deleted.
 539         (IOSSimulatorPort._path_to_webcore_library): Deleted.
 540         (IOSSimulatorPort.show_results_html_file): Deleted.
 541         (IOSSimulatorPort.sample_file_path): Deleted.
 542         (IOSSimulatorPort._merge_crash_logs): Deleted.
 543         (IOSSimulatorPort._look_for_all_crash_logs_in_log_dir): Deleted.
 544         (IOSSimulatorPort.look_for_new_crash_logs): Deleted.
 545         (IOSSimulatorPort.look_for_new_samples): Deleted.
 546         (IOSSimulatorPort.sample_process): Deleted.
 547         (IOSSimulatorPort._path_to_helper): Deleted.
 548         (IOSSimulatorPort.make_command): Deleted.
 549         * Scripts/webkitpy/port/mac.py:
 550         (MacPort.__init__):
 551         (MacPort.make_command):
 552         (MacPort._build_java_test_support):
 553         (MacPort): Deleted.
 554         (MacPort.default_timeout_ms): Deleted.
 555         (MacPort.supports_per_test_timeout): Deleted.
 556         (MacPort.should_retry_crashes): Deleted.
 557         (MacPort.default_child_processes): Deleted.
 558         (MacPort.check_for_leaks): Deleted.
 559         (MacPort.print_leaks_summary): Deleted.
 560         (MacPort._path_to_webcore_library): Deleted.
 561         (MacPort.show_results_html_file): Deleted.
 562         (MacPort.sample_file_path): Deleted.
 563         (MacPort._merge_crash_logs): Deleted.
 564         (MacPort._look_for_all_crash_logs_in_log_dir): Deleted.
 565         (MacPort.look_for_new_crash_logs): Deleted.
 566         (MacPort.look_for_new_samples): Deleted.
 567         (MacPort.sample_process): Deleted.
 568         (MacPort._path_to_helper): Deleted.
 569         * Scripts/webkitpy/port/mac_unittest.py:
 570         (MacTest.test_default_child_processes): Deleted.
 571         * Scripts/webkitpy/port/win.py:
 572         (WinPort.look_for_new_samples):
 573         (WinPort):
 574         (WinPort.sample_process):
 575         (WinPort._make_leak_detector):
 576         (WinPort.check_for_leaks):
 577         (WinPort.print_leaks_summary):
 578         (WinPort._path_to_webcore_library):
 579
 580 2016-08-08  Matt Baker  <mattbaker@apple.com>
 581
 582         Unreviewed: moved myself to the reviewers list.
 583
 584         * Scripts/webkitpy/common/config/contributors.json:
 585
 586 2016-08-08  Chris Dumez  <cdumez@apple.com>
 587
 588         Update API tests in mac/SetDocumentURI.mm after r204247
 589         https://bugs.webkit.org/show_bug.cgi?id=160660
 590
 591         Reviewed by Alex Christensen.
 592
 593         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
 594         (TestWebKitAPI::TEST):
 595
 596 2016-08-08  Jonathan Bedard  <jbedard@apple.com>
 597
 598         run-webkit-tests should trigger a spindump when WebContent process is unresponsive
 599         https://bugs.webkit.org/show_bug.cgi?id=159827
 600
 601         Reviewed by Daniel Bates.
 602
 603         This change was spurred by a process hang which occurred between tests and did
 604         not produce a meaningful crashlog.
 605
 606         * Scripts/webkitpy/port/driver.py:
 607         (Driver._check_for_driver_crash_or_unresponsiveness): Notify test controller when finished through stdin.
 608
 609          * Scripts/webkitpy/port/ios.py:
 610         (IOSSimulatorPort):
 611         (IOSSimulatorPort.sample_process): Attempt spindump, but use sample if spindump fails.
 612         * Scripts/webkitpy/port/mac.py:
 613         (MacPort):
 614         (MacPort.sample_process): Attempt spindump, but use sample if spindump fails.
 615
 616         * Scripts/webkitpy/port/mac_unittest.py: Changed expected values to match spindump calls, added specific spindump test.
 617         * Scripts/webkitpy/port/driver_unittest.py: Added dummy write function.
 618
 619         * WebKitTestRunner/TestController.h:
 620         (WTR::TestController::usingServerMode): Added accessor for m_usingServerMode.
 621         * WebKitTestRunner/TestInvocation.cpp:
 622         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Wait for stdin before continuing when in server mode.
 623
 624 2016-08-07  Dan Bernstein  <mitz@apple.com>
 625
 626         [Cocoa] Reply block leaks if the remote object doesn’t call it
 627         https://bugs.webkit.org/show_bug.cgi?id=160642
 628
 629         Reviewed by Sam Weinig.
 630
 631         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h: Declared a new method.
 632         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
 633         (TEST): Added a test case that checks that the reply block is released even when it’s not
 634           called.
 635         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
 636         (-[RemoteObjectRegistryPlugIn doNotCallCompletionHandler:]): Implement new method by not
 637           calling the completion handler.
 638
 639 2016-08-07  Chris Dumez  <cdumez@apple.com>
 640
 641         Write API test to cover crash fix in r204135
 642         https://bugs.webkit.org/show_bug.cgi?id=160587
 643
 644         Reviewed by Darin Adler.
 645
 646         Add API test to cover crash fix in r204135. This reproduces the crash
 647         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
 648         callback.
 649
 650         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
 651         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
 652         (TEST):
 653
 654 2016-08-06  Chris Dumez  <cdumez@apple.com>
 655
 656         Unreviewed, rolling out r204226.
 657
 658         Broke some API tests
 659
 660         Reverted changeset:
 661
 662         "Write API test to cover crash fix in r204135"
 663         https://bugs.webkit.org/show_bug.cgi?id=160587
 664         http://trac.webkit.org/changeset/204226
 665
 666 2016-08-06  Aakash Jain  <aakash_jain@apple.com>
 667
 668         EWS Style Queue fails to process patches which fails validation
 669         https://bugs.webkit.org/show_bug.cgi?id=160632
 670
 671         Reviewed by Alexey Proskuryakov.
 672
 673         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
 674         (StyleQueueTask.validate): Add more information about validation failure.
 675         (StyleQueueTask.run): Pass the error details in the PatchIsNotValid exception.
 676         * Scripts/webkitpy/tool/commands/queues_unittest.py:
 677         (test_non_valid_patch): Add a unit test to test the above code path.
 678
 679 2016-08-06  Sam Weinig  <sam@webkit.org>
 680
 681         WTF needs a variant implementation
 682         https://bugs.webkit.org/show_bug.cgi?id=160618
 683
 684         Reviewed by Darin Adler.
 685
 686         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 687         * TestWebKitAPI/Tests/WTF/Variant.cpp: Added.
 688         Add tests for the variant implementation.
 689
 690 2016-08-06  Chris Dumez  <cdumez@apple.com>
 691
 692         Write API test to cover crash fix in r204135
 693         https://bugs.webkit.org/show_bug.cgi?id=160587
 694
 695         Reviewed by Darin Adler.
 696
 697         Add API test to cover crash fix in r204135. This reproduces the crash
 698         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
 699         callback.
 700
 701         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
 702         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
 703         (TEST):
 704
 705 2016-08-05  Tim Horton  <timothy_horton@apple.com>
 706
 707         run-api-tests should use a headed simulator
 708         https://bugs.webkit.org/show_bug.cgi?id=160611
 709
 710         Reviewed by Sam Weinig.
 711
 712         CADisplayLink doesn't work in a headless simulator, but is
 713         vital for the proper functioning of WebKit2 painting on iOS.
 714         So, we should not use a headless simulator.
 715
 716         * Scripts/run-api-tests:
 717         Launch a simulator app, don't just boot the simulator.
 718
 719         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
 720         Re-enable a test that works now.
 721
 722 2016-08-05  Dan Bernstein  <mitz@apple.com>
 723
 724         [Cocoa] WKRemoteObjectCoder doesn’t handle NSRange
 725         https://bugs.webkit.org/show_bug.cgi?id=160589
 726
 727         Reviewed by Tim Horton.
 728
 729         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
 730         (remoteObjectInterface): Fixed a mistake in the set of allowed classes in one of the reply
 731           blocks, which wasn’t caught because the test wasn’t run correctly.
 732         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
 733         (TEST): Fixed the -selectionAndClickInformationForClickAtPoint:completionHandler: test, and
 734           added a test that sends over an NSRange.
 735         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
 736         (-[RemoteObjectRegistryPlugIn takeRange:completionHandler:]): Added. Calls the completion
 737           handler with the range‘s location and length.
 738
 739 2016-08-05  Enrica Casucci  <enrica@apple.com>
 740
 741         Fixing tests failing after r204175.
 742
 743         Unreviewed.
 744
 745         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig:
 746
 747 2016-08-05  Enrica Casucci  <enrica@apple.com>
 748
 749         Build fix after 204053.
 750
 751         Unreviewed.
 752
 753         * TestWebKitAPI/Configurations/Base.xcconfig:
 754         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
 755         (-[MockContentFilterEnabler initWithCoder:]):
 756         (-[MockContentFilterEnabler dealloc]):
 757
 758 2016-08-05  Konstantin Tokarev  <annulen@yandex.ru>
 759
 760         Print test name in "Last character read from DRT..." error message.
 761         https://bugs.webkit.org/show_bug.cgi?id=160559
 762
 763         Reviewed by Michael Catanzaro.
 764
 765         * Scripts/webkitpy/port/driver.py:
 766         (Driver.run_test):
 767         (Driver._read_first_block):
 768         (Driver._read_optional_image_block):
 769         (Driver._read_block):
 770         * Scripts/webkitpy/port/driver_unittest.py:
 771         (DriverTest.test_read_block):
 772         (DriverTest.test_read_binary_block):
 773         (DriverTest.test_read_base64_block):
 774
 775 2016-08-05  Commit Queue  <commit-queue@webkit.org>
 776
 777         Unreviewed, rolling out r204123.
 778         https://bugs.webkit.org/show_bug.cgi?id=160597
 779
 780         Caused layout test timeouts on Windows. (Requested by perarne
 781         on #webkit).
 782
 783         Reverted changeset:
 784
 785         "[Win] Unable to reliably run tests in parallel"
 786         https://bugs.webkit.org/show_bug.cgi?id=140914
 787         http://trac.webkit.org/changeset/204123
 788
 789 2016-08-04  Saam Barati  <sbarati@apple.com>
 790
 791         Restore CodeBlock jettison code to jettison when a CodeBlock has been alive for a long time
 792         https://bugs.webkit.org/show_bug.cgi?id=151241
 793
 794         Reviewed by Benjamin Poulain.
 795
 796         * Scripts/run-jsc-stress-tests:
 797
 798 2016-08-04  Dean Johnson  <dean_johnson@apple.com>
 799
 800         UI improvements to Flakiness Dashboard.
 801         https://bugs.webkit.org/show_bug.cgi?id=153295
 802
 803         Reviewed by Alexey Proskuryakov.
 804
 805         * TestResultServer/static-dashboards/flakiness_dashboard.css:
 806         (td.options-container): Center text in most fields.
 807         * TestResultServer/static-dashboards/flakiness_dashboard.js:
 808         (createBugHTML): Text/Grammar updates.
 809         (tableHeaders): Ditto.
 810         (htmlForSingleTestRow): Ditto.
 811         (headerForTestTableHtml): Ditto.
 812         * TestResultServer/static-dashboards/ui.js: Removed the "Group: " and "Test type: " headings.
 813         (ui.html.testTypeSwitcher): Deleted. Removes the "Group:" heading.
 814
 815 2016-08-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
 816
 817         [GTK] install-dependencies script misses libxslt as build-dependency and some python libs for the run-benchmark script
 818         https://bugs.webkit.org/show_bug.cgi?id=160518
 819
 820         Reviewed by Michael Catanzaro.
 821
 822         * Scripts/webkitpy/thirdparty/__init__.py:
 823         (AutoinstallImportHook._install_twisted): Twisted requires zope.interface.
 824         * gtk/install-dependencies:
 825
 826 2016-08-04  Alexey Proskuryakov  <ap@apple.com>
 827
 828         Optimize bot watcher's dashboard a little
 829         https://bugs.webkit.org/show_bug.cgi?id=160515
 830         rdar://problem/26096900
 831
 832         Reviewed by Lucas Forschler.
 833
 834         Made re-sorting after loading an iteration more efficient.
 835
 836         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
 837         (BuildbotIteration.prototype._updateWithData):
 838         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
 839         (BuildbotQueue.prototype.updateIterationPosition):
 840
 841 2016-08-04  Per Arne Vollan  <pvollan@apple.com>
 842
 843         [Win] Unable to reliably run tests in parallel
 844         https://bugs.webkit.org/show_bug.cgi?id=140914
 845
 846         Reviewed by Brent Fulgham.
 847
 848         The cygpath utility function can fail badly when running with multiple DumpRenderTree
 849         processes. We can use string replacement to convert the Cygwin path to a Windows path
 850         instead.
 851
 852         * Scripts/webkitpy/common/system/path.py:
 853         (cygpathFast):
 854         * Scripts/webkitpy/port/driver.py:
 855         (Driver._command_from_driver_input):
 856
 857 2016-08-03  Aakash Jain  <aakash_jain@apple.com>
 858
 859         Document instructions for increasing process and file limits
 860         https://bugs.webkit.org/show_bug.cgi?id=160528
 861         rdar://problem/24777576
 862
 863         Reviewed by Alexey Proskuryakov.
 864
 865         * Scripts/webkitpy/port/ios.py:
 866         (IOSSimulatorPort.default_child_processes):
 867
 868 2016-08-03  Anders Carlsson  <andersca@apple.com>
 869
 870         Remove the Objective-C bindings generator
 871         https://bugs.webkit.org/show_bug.cgi?id=160526
 872
 873         Reviewed by Sam Weinig.
 874
 875         * Scripts/run-bindings-tests:
 876         Update test.
 877
 878 2016-08-03  Tim Horton  <timothy_horton@apple.com>
 879
 880         Revise a TestWebKitAPI comment to mention the actual underlying problem
 881
 882         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
 883         Note that this is because of https://bugs.webkit.org/show_bug.cgi?id=160516
 884
 885 2016-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
 886
 887         Benchmark test content-animation timeouts always
 888         https://bugs.webkit.org/show_bug.cgi?id=160057
 889
 890         Reviewed by Simon Fraser.
 891
 892         * Scripts/webkitpy/benchmark_runner/data/plans/Skipped: Added.
 893         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
 894         (start):
 895
 896 2016-08-02  Nan Wang  <n_wang@apple.com>
 897
 898         AX: Simulated touch events are not working on iOS
 899         https://bugs.webkit.org/show_bug.cgi?id=160395
 900         <rdar://problem/27633597>
 901
 902         Reviewed by Chris Fleizach.
 903
 904         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
 905         (WTR::AccessibilityUIElement::press):
 906         (WTR::AccessibilityUIElement::setSelectedChild):
 907
 908 2016-08-02  Filip Pizlo  <fpizlo@apple.com>
 909
 910         run-javascriptcore-tests should accept multiple --extra-tests
 911         https://bugs.webkit.org/show_bug.cgi?id=160486
 912
 913         Reviewed by Saam Barati.
 914
 915         We want to be able to pass --extra-tests multiple times, to supply an arbitrary number of extra
 916         test suites. This does it by using GetOpt::Long's array support.
 917
 918         * Scripts/run-javascriptcore-tests:
 919         (runJSCStressTests):
 920
 921 2016-08-02  Enrica Casucci  <enrica@apple.com>
 922
 923         Allow building with content filtering disabled.
 924         https://bugs.webkit.org/show_bug.cgi?id=160454
 925
 926         Reviewed by Simon Fraser.
 927
 928         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
 929
 930 2016-08-02  Brady Eidson  <beidson@apple.com>
 931
 932         Removing IndexedDB WebsiteData can fail for some users.
 933         https://bugs.webkit.org/show_bug.cgi?id=160463
 934
 935         Reviewed by Alex Christensen.
 936
 937         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
 938
 939 2016-08-01  Alex Christensen  <achristensen@webkit.org>
 940
 941         _WKDownloadDelegate.didReceiveResponse should be called before decideDestinationWithSuggestedFilename
 942         https://bugs.webkit.org/show_bug.cgi?id=160437
 943         <rdar://problem/27578272>
 944
 945         Reviewed by Brady Eidson.
 946
 947         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
 948         (-[DownloadDelegate _download:didReceiveResponse:]):
 949         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
 950         (runTest):
 951         Add a boolean to make sure that didReceiveResponse is called before decideDestinationWithSuggestedFilename.
 952
 953 2016-08-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
 954
 955         [Tools] The GDB backtrace report tool don't checks the gdb return code.
 956         https://bugs.webkit.org/show_bug.cgi?id=160414
 957
 958         Reviewed by Michael Catanzaro.
 959
 960         * Scripts/webkitpy/port/linux_get_crash_log.py:
 961         (GDBCrashLogGenerator._wait_for_corefile):
 962
 963 2016-08-01  Youenn Fablet  <youenn@apple.com>
 964
 965         Make wpt server generate its certificates in layout test results folder
 966         https://bugs.webkit.org/show_bug.cgi?id=160422
 967
 968         Reviewed by Chris Dumez.
 969
 970         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
 971         (WebPlatformTestServer._copy_webkit_test_files): Setting certificate folder to layout tests results directory.
 972
 973 2016-08-01  Jonathan Bedard  <jbedard@apple.com>
 974
 975         Function Call on NULL Object
 976         https://bugs.webkit.org/show_bug.cgi?id=160325
 977
 978         Reviewed by Darin Adler.
 979
 980         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
 981         (WTR::InjectedBundle::didReceiveMessageToPage): Changed removeAllWebNotificationPermissions() call to static function call.
 982         * WebKitTestRunner/InjectedBundle/TestRunner.h: Made all web-notification functions static.
 983
 984 2016-08-01  Keith Miller  <keith_miller@apple.com>
 985
 986         We should not keep the JavaScript tests inside the Source/JavaScriptCore/ directory.
 987         https://bugs.webkit.org/show_bug.cgi?id=160372
 988
 989         Rubber stamped by Geoffrey Garen.
 990
 991         This patch moves all the JavaScript tests from Source/JavaScriptCore/tests to
 992         a new top level directory, JSTests. Having the tests in the Source directory
 993         was both confusing an inconvenient for people that just want to checkout the
 994         source code of WebKit. Since there is no other obvious place to put all the
 995         JavaScript tests a new top level directory seemed the most sensible.
 996
 997         * Scripts/import-test262-tests:
 998         * Scripts/run-javascriptcore-tests:
 999         * Scripts/update-javascriptcore-test-res:
1000
1001 2016-07-31  Nan Wang  <n_wang@apple.com>
1002
1003         AX: Add a check for touch event listener on iOS accessibility object
1004         https://bugs.webkit.org/show_bug.cgi?id=160388
1005
1006         Reviewed by Chris Fleizach.
1007
1008         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1009         (AccessibilityUIElement::boolAttributeValue):
1010         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1011         (WTR::AccessibilityUIElement::boolAttributeValue):
1012
1013 2016-07-30  Manuel Rego Casasnovas  <rego@igalia.com>
1014
1015         Unreviewed: add myself to the reviewers list.
1016
1017         * Scripts/webkitpy/common/config/contributors.json:
1018
1019 2016-07-29  Alexey Proskuryakov  <ap@apple.com>
1020
1021         Undo r203939, and copy over a rule that clips the logos.
1022
1023         Sierra wasn't the only logo without transparency.
1024
1025         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
1026         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
1027         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1028
1029 2016-07-29  Alan Sien Wei Hshieh  <hshieh@apple.com>
1030
1031         The Sierra asset at build.webkit.org/dashboard/images/Sierra*.png has a white background
1032         https://bugs.webkit.org/show_bug.cgi?id=160377
1033
1034         Reviewed by Brian Weinstein.
1035
1036         Update assets to remove the white background and use a transparent background instead.
1037
1038         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
1039         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
1040
1041 2016-07-29  David Kilzer  <ddkilzer@apple.com>
1042
1043         Ignore most check-webkit-style checks for ANGLE project
1044         <https://webkit.org/b/160333>
1045
1046         Reviewed by Daniel Bates.
1047
1048         * Scripts/webkitpy/style/checker.py: Ignore all checkers except:
1049         - No tabs.
1050         - No spaces at the end of lines.
1051         - No carriage returns (DOS line endings).
1052
1053 2016-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
1054
1055         Media controls are not displayed for some autoplaying videos at certain browser dimensions
1056         https://bugs.webkit.org/show_bug.cgi?id=160360
1057         <rdar://problem/27179484>
1058
1059         Reviewed by Myles C. Maxfield.
1060
1061         Adds two tests verifying that videos may be considered main content as long as they
1062         are large enough and cover a majority of the mainframe's viewport.
1063
1064         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1065         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1066         (TestWebKitAPI::TEST):
1067         * TestWebKitAPI/Tests/WebKit2Cocoa/full-size-autoplaying-video-with-audio.html: Added.
1068         * TestWebKitAPI/Tests/WebKit2Cocoa/skinny-autoplaying-video-with-audio.html: Added.
1069
1070 2016-07-29  Mark Lam  <mark.lam@apple.com>
1071
1072         Gardening: removed unused variable.
1073
1074         Not reviewed.
1075
1076         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1077         (TestWebKitAPI::TEST):
1078
1079 2016-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
1080
1081         Add TestWebKitAPI support for interacting with media controls
1082         https://bugs.webkit.org/show_bug.cgi?id=160342
1083         <rdar://problem/27610246>
1084
1085         Reviewed by Beth Dakin.
1086
1087         Adds support for testing interaction with some media controls, as well as a basic test
1088         verifying that media control teardown after interaction does not result in a crash.
1089
1090         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1091         (-[WKWebView mouseDownAtPoint:]):
1092         (-[WKWebView performAfterLoading:]):
1093         (TestWebKitAPI::TEST):
1094
1095 2016-07-29  Jonathan Bedard  <jbedard@apple.com>
1096
1097         Crash Log Clobbering on Unbound Crashes
1098         https://bugs.webkit.org/show_bug.cgi?id=160198
1099         <rdar://problem/27472618>
1100
1101         Reviewed by Alexey Proskuryakov.
1102
1103         * Scripts/webkitpy/common/system/crashlogs.py:
1104         (CrashLogs): Fix header order.
1105         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1106         (TestResultWriter.output_filename): Only remove file extension if it is clearly a file extension.
1107
1108 2016-07-29  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1109
1110         Update for contributors.json
1111         https://bugs.webkit.org/show_bug.cgi?id=160294
1112
1113         * Scripts/webkitpy/common/config/contributors.json:
1114
1115 2016-07-28  Myles C. Maxfield  <mmaxfield@apple.com>
1116
1117         Remove deprecated SPI for video inline / fullscreen controls
1118         https://bugs.webkit.org/show_bug.cgi?id=160318
1119
1120         Reviewed by Tim Horton.
1121
1122         * DumpRenderTree/mac/DumpRenderTree.mm:
1123         (setDefaultsToConsistentValuesForTesting): Deleted.
1124         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1125         (RequiresUserActionForPlaybackTest::SetUp): Deleted.
1126         * WebKitTestRunner/TestController.cpp:
1127         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
1128         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1129         (WTR::initializeWebViewConfiguration): Deleted.
1130
1131 2016-07-28  Daniel Bates  <dabates@apple.com>
1132
1133         [iOS] TestWebKitAPI bundle targets are not code signed
1134         https://bugs.webkit.org/show_bug.cgi?id=160328
1135         <rdar://problem/27409246>
1136
1137         Reviewed by Andy Estes.
1138
1139         Workaround <rdar://problem/27459890> by explicitly defining Xcode build settings
1140         CODE_SIGNING_ALLOWED and AD_HOC_CODE_SIGNING_ALLOWED to be YES so as to allow the
1141         the TestWebKitAPI bundle targets to be code signed when building for the iOS simulator.
1142
1143         * TestWebKitAPI/Configurations/Base.xcconfig:
1144
1145 2016-07-28  Tim Horton  <timothy_horton@apple.com>
1146
1147         Disable WebKit2.ResizeWithHiddenContentDoesNotHang for now
1148
1149         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1150         (animatedResizeWebView):
1151         (TEST):
1152         This test times out only when run in the WebKit Testing simulator environment,
1153         but not in a fresh simulator. Disabling to keep the bots green while under investigation.
1154
1155 2016-07-28  Tim Horton  <timothy_horton@apple.com>
1156
1157         Frequent animation lags when interacting with Safari (sidebar, tab switching, etc.)
1158         https://bugs.webkit.org/show_bug.cgi?id=160289
1159         <rdar://problem/27553464>
1160
1161         Reviewed by Simon Fraser.
1162
1163         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1164         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1165         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm: Added.
1166         (-[AnimatedResizeNavigationDelegate _webView:renderingProgressDidChange:]):
1167         (-[AnimatedResizeWebView _endAnimatedResize]):
1168         (animatedResizeWebView):
1169         (TEST):
1170         * TestWebKitAPI/Tests/WebKit2Cocoa/blinking-div.html: Added.
1171         Add two tests that ensure that hidden-content and animated resizes
1172         don't cause unnecessary synchronous waits. Only the hidden-content
1173         one fails before my patch, but it seemed reasonable to add both anyway.
1174
1175 2016-07-28  David Kilzer  <ddkilzer@apple.com>
1176
1177         webkit-patch upload --suggest-reviewers shouldn't break in the presence of deleted or moved files
1178         <https://webkit.org/b/83342>
1179
1180         Reviewed by Ryosuke Niwa.
1181
1182         * Scripts/webkitpy/common/checkout/scm/git.py:
1183         (Git.revisions_changing_file): Remove code to raise an exception
1184         when the file doesn't exist.  If a file was moved or renamed,
1185         then this caused the script to terminate, which was very
1186         frustrating when you wanted a list of reviewers.
1187         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1188         (SCMTest._shared_test_revisions_changing_file): Update test
1189         expectation to return an empty list of revisions.
1190         (test_create_patch_is_full_patch): Drive-by fix when running all
1191         webkitpy tests (including scm tests).
1192         * Scripts/webkitpy/common/checkout/scm/svn.py:
1193         (SVN.revisions_changing_file): Catch ScriptError exceptions and
1194         return an empty array of revisions if this occurs.
1195
1196 2016-07-28  Aakash Jain  <aakash_jain@apple.com>
1197
1198         EWS error message "Error: * did not process patch" should include explanation
1199         https://bugs.webkit.org/show_bug.cgi?id=159903
1200         <rdar://problem/27410788>
1201
1202         Reviewed by Alexey Proskuryakov.
1203
1204         * QueueStatusServer/handlers/statusbubble.py:
1205         (StatusBubble._build_bubble): Display more detailed error message on bubbles when patch
1206         is not processed.
1207         * QueueStatusServer/handlers/processingtimesjson.py:
1208         (ProcessingTimesJSON._resultFromFinalStatus): Updated error message to match with rest
1209         of the code.
1210         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1211         (CommitQueueTask.validate): Add more information about validation failure.
1212         (CommitQueueTask.run): Pass the error details in the PatchIsNotValid exception.
1213         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
1214         (EarlyWarningSystemTask.validate): Add more information about validation failure.
1215         (EarlyWarningSystemTask.run): Pass the error details in the PatchIsNotValid exception.
1216         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1217         (PatchIsNotValid.__init__): Add the failure_message argument.
1218         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1219         (AbstractEarlyWarningSystem.review_patch): Re-word the error message and include
1220         failure details.
1221         * Scripts/webkitpy/tool/commands/queues.py:
1222         (CommitQueue.process_work_item): Same.
1223         (StyleQueue.review_patch): Same.
1224         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1225         (test_non_valid_patch): Updated test-cases messages to match the above changes.
1226
1227 2016-07-27  Alexey Proskuryakov  <ap@apple.com>
1228
1229         LayoutTestRelay should wait for WebKitTestRunnerApp installation to complete
1230         https://bugs.webkit.org/show_bug.cgi?id=160262
1231
1232         Reviewed by Daniel Bates.
1233
1234         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1235         (-[LTRelayController installApp]):
1236
1237 2016-07-27  Ryan Haddad  <ryanhaddad@apple.com>
1238
1239         Disable WebCoreNSURLSessionTest API tests on ios-simulator
1240         https://bugs.webkit.org/show_bug.cgi?id=160225
1241
1242         Reviewed by Alexey Proskuryakov.
1243
1244         * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
1245
1246 2016-07-27  Miguel Gomez  <magomez@igalia.com>
1247
1248         [GTK] Fix some video/canvas tests that should be passing
1249         https://bugs.webkit.org/show_bug.cgi?id=160023
1250
1251         Reviewed by Carlos Garcia Campos.
1252
1253         Add a platform identifier to the TestRunner's page user agent when the tests are run on the
1254         EFL or GTK platforms.
1255
1256         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1257         (WTR::TestController::platformConfigureViewForTest):
1258         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1259         (WTR::TestController::platformConfigureViewForTest):
1260
1261 2016-07-27  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1262
1263         [Tools] The built product doesn't contains the dwo files when DEBUG_FISSION is enabled.
1264         https://bugs.webkit.org/show_bug.cgi?id=160247
1265
1266         Reviewed by Michael Catanzaro.
1267
1268         * BuildSlaveSupport/built-product-archive:
1269         (createZip):
1270         (dirContainsdwo):
1271         (archiveBuiltProduct):
1272
1273 2016-07-26  Alex Christensen  <achristensen@webkit.org>
1274
1275         Fix tests after r203743.
1276         https://bugs.webkit.org/show_bug.cgi?id=156947
1277
1278         * WebKitTestRunner/TestController.cpp:
1279         (WTR::TestController::resetStateToConsistentValues):
1280         Reset the new boolean m_rejectsProtectionSpaceAndContinueForAuthenticationChallenges.
1281
1282 2016-07-26  Myles C. Maxfield  <mmaxfield@apple.com>
1283
1284         [iPhone] Playing a video on tudou.com plays only sound, no video
1285         https://bugs.webkit.org/show_bug.cgi?id=160178
1286         <rdar://problem/27535468>
1287
1288         Reviewed by Dan Bernstein.
1289
1290         * DumpRenderTree/mac/DumpRenderTree.mm:
1291         (setDefaultsToConsistentValuesForTesting):
1292         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1293         (RequiresUserActionForPlaybackTest::SetUp):
1294         * WebKitTestRunner/TestController.cpp:
1295         (WTR::TestController::resetPreferencesToConsistentValues):
1296         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1297         (WTR::initializeWebViewConfiguration):
1298
1299 2016-07-26  Simon Fraser  <simon.fraser@apple.com>
1300
1301         Allow LOG macros to be used outside the namespace, and other logging cleanup
1302         https://bugs.webkit.org/show_bug.cgi?id=160216
1303
1304         Reviewed by Anders Carlsson.
1305
1306         initializeLoggingChannelsIfNecessary -> initializeLogChannelsIfNecessary
1307
1308         * DumpRenderTree/TestRunner.cpp:
1309         * DumpRenderTree/mac/DumpRenderTree.mm:
1310         (resetWebViewToConsistentStateBeforeTesting):
1311
1312 2016-07-26  David Kilzer <ddkilzer@apple.com>
1313
1314         Networking process crash due to missing -[WebCoreAuthenticationClientAsChallengeSender performDefaultHandlingForAuthenticationChallenge:] implementation
1315         https://bugs.webkit.org/show_bug.cgi?id=156947
1316         <rdar://problem/23325160>
1317
1318         Reviewed by Alex Christensen.
1319
1320         * DumpRenderTree/TestRunner.cpp:
1321         (TestRunner::TestRunner):
1322         (setRejectsProtectionSpaceAndContinueForAuthenticationChallengesCallback):
1323         * DumpRenderTree/TestRunner.h:
1324         (TestRunner::rejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1325         (TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1326         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1327         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
1328         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1329         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1330         (WTR::TestRunner::queueNonLoadingScript):
1331         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1332         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1333         * WebKitTestRunner/TestController.cpp:
1334         (WTR::TestController::didReceiveAuthenticationChallenge):
1335         * WebKitTestRunner/TestController.h:
1336         (WTR::TestController::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1337         * WebKitTestRunner/TestInvocation.cpp:
1338         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1339         Add TestRunner.setRejectsProtectionSpaceAndContinueForAuthenticationChallenges to use for testing.
1340
1341 2016-07-26  David Kilzer  <ddkilzer@apple.com>
1342
1343         check-for-exit-time-destructors should be usable outside Xcode
1344         <https://webkit.org/b/160195>
1345
1346         Reviewed by Darin Adler.
1347
1348         * Scripts/check-for-exit-time-destructors: Update to parse
1349         -h|--help switch, or to take one argument to a binary to check
1350         for exit time destructors on the command-line.  The clang
1351         compiler will find these at compile-time with the
1352         -Wexit-time-destructors switch, but this script will check for
1353         them after-the-fact.
1354
1355 2016-07-26  Lucas Forschler  <lforschler@apple.com>
1356
1357         Test svn.webkit.org functionality after maintenance.
1358
1359 2016-07-25  Brady Eidson  <beidson@apple.com>
1360
1361         Modern IDB: Make sure IndexedDB works from file:// url documents by default
1362         https://bugs.webkit.org/show_bug.cgi?id=153783
1363
1364         Reviewed by Alex Christensen.
1365
1366         Previously, to grant IndexedDB access to file:// urls for testing purposes,
1367         we had to call the SPI [WKWebViewConfiguration _setAllowUniversalAccessFromFileURLs:].
1368
1369         As of https://trac.webkit.org/changeset/203695 this is no longer required.
1370
1371         Change the relevant API tests to make sure this continues to be no longer required.
1372
1373         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
1374         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
1375         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
1376         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
1377         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
1378         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
1379
1380 2016-07-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1381
1382         Media controls should not be displayed for a video until it starts playing
1383         https://bugs.webkit.org/show_bug.cgi?id=160092
1384         <rdar://problem/26986673>
1385
1386         Reviewed by Beth Dakin.
1387
1388         Verify that multiple videos do or don't show the media controller depending on whether videos
1389         are playing. Also tweaks an existing API test (VideoControlsManagerSingleLargeVideo) that was
1390         passing because we were always showing media controls for large videos with audio, even if they
1391         had not played back yet. This change ensures that large videos with audio show media controls
1392         only after they begin to play back, and not by virtue of being large enough for main content.
1393
1394         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1395         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1396         (TestWebKitAPI::TEST):
1397         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html:
1398         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio-autoplay.html: Added.
1399         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio.html: Added.
1400
1401 2016-07-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1402
1403         Media controls on apple.com don't disappear when movie finishes playing
1404         https://bugs.webkit.org/show_bug.cgi?id=160068
1405         <rdar://problem/26668526>
1406
1407         Reviewed by Darin Adler.
1408
1409         Adds new API tests. Please see WebCore ChangeLog for more details.
1410
1411         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1412         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1413         (-[MediaPlaybackMessageHandler initWithWKWebView:finalMessageString:]):
1414         (-[MediaPlaybackMessageHandler userContentController:didReceiveScriptMessage:]):
1415         (TestWebKitAPI::TEST):
1416         (-[DidPlayMessageHandler initWithWKWebView:]): Deleted.
1417         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]): Deleted.
1418         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-hides-controls-after-seek-to-end.html: Added.
1419         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-after-ending.html: Added.
1420         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-to-beginning-and-play-after-ending.html: Added.
1421
1422 2016-07-25  Philippe Normand  <pnormand@igalia.com>
1423
1424         Unreviewed, fix test-webkitpy after r203674.
1425
1426         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
1427         (GDBCrashLogGeneratorTest.test_generate_crash_log):
1428
1429 2016-07-24  Philippe Normand  <pnormand@igalia.com>
1430
1431         Unreviewed, forgot to commit this file in r203674.
1432
1433         * Scripts/process-linux-coredump: Added.
1434         (main):
1435
1436 2016-07-25  Philippe Normand  <pnormand@igalia.com>
1437
1438         Improve GDB backtrace generation for GTK/EFL
1439         https://bugs.webkit.org/show_bug.cgi?id=128928
1440
1441         Reviewed by Carlos Garcia Campos.
1442
1443         The PID of the crashed process is now correctly supplied to the
1444         crash log reporter. The kernel core_pattern needs to be updated
1445         after this change to something like:
1446
1447         echo "|/home/phil/WebKit/Tools/Scripts/process-linux-coredump /tmp/core-pid_%p.dump" > /proc/sys/kernel/core_pattern
1448
1449         * Scripts/process-linux-coredump: Added.
1450         (main): Minimal python script reading coredump data on stdin and writing it to a file in /tmp/.
1451         * Scripts/webkitpy/port/efl.py:
1452         (EflPort._get_crash_log): Supply path of the process-linux-coredump script.
1453         * Scripts/webkitpy/port/gtk.py:
1454         (GtkPort._get_crash_log): Ditto.
1455         * Scripts/webkitpy/port/linux_get_crash_log.py:
1456         (GDBCrashLogGenerator.__init__): New argument for supplying the path of a coredump processor script.
1457         (GDBCrashLogGenerator.generate_crash_log): Update error message, the core_pattern should now be set to pipe coredumps to a script.
1458         (GDBCrashLogGenerator): Deleted.
1459         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
1460         (GDBCrashLogGeneratorTest.test_generate_crash_log): Update test expectations.
1461         * WebKitTestRunner/TestController.cpp:
1462         (WTR::TestController::networkProcessDidCrash): Supply PID of crash process.
1463         (WTR::TestController::databaseProcessDidCrash): Ditto.
1464         (WTR::TestController::processDidCrash): Ditto.
1465
1466 2016-07-23  Youenn Fablet  <youenn@apple.com>
1467
1468         WPT stash server should be kept running when launching wpt server
1469         https://bugs.webkit.org/show_bug.cgi?id=160052
1470
1471         Reviewed by Sam Weinig.
1472
1473         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
1474         (main): waiting to read stdin while stash server is started.
1475
1476 2016-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1477
1478         Media controls should be displayed for media in media documents
1479         https://bugs.webkit.org/show_bug.cgi?id=160104
1480         <rdar://problem/27438936>
1481
1482         Reviewed by Myles C. Maxfield.
1483
1484         Verifies that even a small video with audio in a media document gets media controls.
1485
1486         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1487         (TestWebKitAPI::TEST):
1488
1489 2016-07-22  Michael Saboff  <msaboff@apple.com>
1490
1491         REGRESSION(203616): no FTL testing was inadvertently removed
1492         https://bugs.webkit.org/show_bug.cgi?id=160100
1493
1494         Rubber-stamped by Filip Pizlo.
1495
1496         Added runNoFTL back into the set of tests we run on FTL enabled platforms.
1497         Renamed runLayoutTestNoFTL to runLayoutTestDefault.  Restructured the test
1498         logic for the runLayout and runNoisy variants to match the run test logic,
1499         that is we always invoke runXXXDefault and invoke runXXXNoFTL for FTL
1500         enabled platforms.
1501
1502         * Scripts/run-jsc-stress-tests:
1503
1504 2016-07-22  Brady Eidson  <beidson@apple.com>
1505
1506         Removing IndexedDatabases that have stored blobs doesn't remove the blob files.
1507         https://bugs.webkit.org/show_bug.cgi?id=160089
1508
1509         Reviewed by Darin Adler.
1510
1511         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1512         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm: Added.
1513         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobToBeDeleted.html: Added.
1514
1515 2016-07-22  Konstantin Tokarev  <annulen@yandex.ru>
1516
1517         [GTK] Improved exclusion patterns in make-dist.py manifest.
1518         https://bugs.webkit.org/show_bug.cgi?id=160094
1519
1520         Reviewed by Michael Catanzaro.
1521
1522         * gtk/manifest.txt.in:
1523         Exclude Platform*.cmake files for more ports.
1524         Removed obsolete .gyp and .pro.user patterns.
1525         Exclude 'Configurations' and 'spi' directories.
1526         Exclude CMakeLists.txt.user (Qt Creator IDE).
1527
1528 2016-07-22  Michael Saboff  <msaboff@apple.com>
1529
1530         Don't run FTL related JSC stress tests on non-FTL platforms
1531         https://bugs.webkit.org/show_bug.cgi?id=160033
1532
1533         Reviewed by Mark Lam.
1534
1535         Added check for running tests on platforms that don't enable FTL to not run FTL tests.
1536         Refactored several of the runXXX test methods to always runXXXDefault and made those
1537         runXXXDefault to pass FTL_OPTIONS.  For platforms that don't enable the FTL, FTL_OPTIONS
1538         doesn't cause a problem.
1539
1540         * Scripts/run-jsc-stress-tests:
1541
1542 2016-07-22  Per Arne Vollan  <pvollan@apple.com>
1543
1544         IWebView::mainFrame crashes if called after IWebView::close
1545         https://bugs.webkit.org/show_bug.cgi?id=32868
1546
1547         Reviewed by Brent Fulgham.
1548
1549         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
1550         (TestWebKitAPI::TEST_F): Added test.
1551
1552 2016-07-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1553
1554         [GTK] Enable threaded compositor by default
1555         https://bugs.webkit.org/show_bug.cgi?id=160079
1556
1557         Reviewed by Žan Doberšek.
1558
1559         * Scripts/webkitperl/FeatureList.pm:
1560
1561 2016-07-22  Youenn Fablet  <youenn@apple.com>
1562
1563         run-builtins-generator-tests should be able to test WebCore builtins wrapper with more than one file
1564         https://bugs.webkit.org/show_bug.cgi?id=159921
1565
1566         Reviewed by Brian Burg.
1567
1568         Updated builtin generator test runner to generate WebCore wrapper files based on all WebCore valid separate files.
1569
1570         * Scripts/webkitpy/codegen/main.py:
1571         (BuiltinsGeneratorTests.generate_from_js_builtins): Passing a list of builtin files to the script.
1572         (BuiltinsGeneratorTests):
1573         (BuiltinsGeneratorTests.single_builtin_test): Added to handle the case of single builtin generation.
1574         (BuiltinsGeneratorTests.wrappers_builtin_test): Added to handle the case of WebCore wrappers builtin generation.
1575         (BuiltinsGeneratorTests.run_test): Helper routine to run a test in reset mode or normal check mode.
1576         (BuiltinsGeneratorTests.run_tests): Updated to add WebCore wrappers builtin generation test.
1577
1578 2016-07-21  Dan Bernstein  <mitz@apple.com>
1579
1580         [Mac] webkitdirs.pm contains unused code to support outdated OS X and Xcode versions
1581         https://bugs.webkit.org/show_bug.cgi?id=160072
1582
1583         Reviewed by Andy Estes.
1584
1585         * Scripts/webkitdirs.pm:
1586         (readXcodeUserDefault): Changed to take a defaults key rather than a suffix. Removed support
1587           for old Xcode versions.
1588         (determineBaseProductDir): Removed support for old Xcode versions. Updated for the change
1589           to readXcodeUserDefault.
1590         (debugger): Deleted. This was only used for Darwin, where LLDB is now the only supported
1591           debugger.
1592         (determineDebugger): Ditto.
1593         (checkRequiredSystemConfig): Updated to require at least OS X Yosemite v10.10.5 and Xcode
1594           7.0.
1595         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Removed --use-gdb and --use-lldb
1596           switches.
1597         (execMacWebKitAppForDebugging): Removed support for GDB.
1598
1599 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
1600
1601         Remove support for deprecated SPI inlineMediaPlaybackRequiresPlaysInlineAttribute
1602         https://bugs.webkit.org/show_bug.cgi?id=160066
1603
1604         Reviewed by Dean Jackson.
1605
1606         * DumpRenderTree/mac/DumpRenderTree.mm:
1607         (setDefaultsToConsistentValuesForTesting): Deleted.
1608         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1609         (RequiresUserActionForPlaybackTest::SetUp): Deleted.
1610         * WebKitTestRunner/TestController.cpp:
1611         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
1612         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1613         (WTR::initializeWebViewConfiguration): Deleted.
1614
1615 2016-07-21  Chelsea Pugh  <cpugh@apple.com>
1616
1617         [iOS] Apps using WKWebView will crash if they set the scroll view's delegate and don't nil it out later
1618         https://bugs.webkit.org/show_bug.cgi?id=159980
1619         rdar://problem/27450825
1620
1621         Reviewed by Dan Bernstein.
1622
1623         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1624         * TestWebKitAPI/Tests/ios/WKScrollViewDelegateCrash.mm: Added.
1625         (-[TestDelegateForScrollView dealloc]): Update delegateIsDeallocated to true so that we can tell
1626         when our delegate has hit -dealloc.
1627         (TestWebKitAPI::TEST): Ensure that after an object has been set as the scroll view's delegate,
1628         and has then been deallocated, that the scroll view's delegate is nil and the deallocated delegate
1629         will not be messaged.
1630
1631 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
1632
1633         Follow-up patch to r203520
1634         https://bugs.webkit.org/show_bug.cgi?id=159967
1635         <rdar://problem/26964090>
1636
1637         Unreviewed.
1638
1639         * DumpRenderTree/mac/DumpRenderTree.mm:
1640         (setDefaultsToConsistentValuesForTesting):
1641         * WebKitTestRunner/TestController.cpp:
1642         (WTR::TestController::resetPreferencesToConsistentValues):
1643
1644 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
1645
1646         [iPhone] Playing a video on tudou.com plays only sound, no video
1647         https://bugs.webkit.org/show_bug.cgi?id=159967
1648         <rdar://problem/26964090>
1649
1650         Reviewed by Jon Lee, Jeremy Jones, and Anders Carlsson.
1651
1652         Migrate tests to use new SPI.
1653
1654         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1655         (RequiresUserActionForPlaybackTest::SetUp):
1656         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1657         (WTR::initializeWebViewConfiguration):
1658
1659 2016-07-21  Csaba Osztrogonác  <ossy@webkit.org>
1660
1661         Clarify testing mode names in run-jsc-stress-tests
1662         https://bugs.webkit.org/show_bug.cgi?id=160021
1663
1664         Reviewed by Mark Lam.
1665
1666         Default should mean really default, not default with disabled FTL, renamed
1667         - runMozillaTestDefault to runMozillaTestNoFTL
1668         - runMozillaTestDefaultFTL to runMozillaTestDefault
1669         - runDefault to runNoFTL
1670         - runDefaultFTL to runDefault
1671         - runLayoutTestDefault to runLayoutTestNoFTL
1672         - runLayoutTestDefaultFTL to runLayoutTestDefault
1673         - runNoisyTestDefault to runNoisyTestNoFTL
1674         - runNoisyTestDefaultFTL to runNoisyTestDefault
1675
1676         * Scripts/run-jsc-stress-tests:
1677
1678 2016-07-21  Yongjun Zhang  <yongjun_zhang@apple.com>
1679
1680         WebBackForwardList's currentIndex could get out of bounds when filtering items.
1681         https://bugs.webkit.org/show_bug.cgi?id=159986
1682
1683         Add a test to verify filtering out 2 items from a 3-item list will set the currentIndex
1684         to 0.
1685
1686         Reviewed by Dan Bernstein.
1687
1688         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1689         * TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm: Added.
1690         (-[WKBackForwardListTestNavigationDelegate webView:didFinishNavigation:]):
1691         (TEST):
1692
1693 2016-07-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1694
1695         [GTK] Web view background colors don't work in accelerated compositing mode
1696         https://bugs.webkit.org/show_bug.cgi?id=159455
1697
1698         Reviewed by Michael Catanzaro.
1699
1700         Set always RGBA visual to the view widget when setting a background color.
1701
1702         * MiniBrowser/gtk/BrowserWindow.c:
1703         (browser_window_set_background_color):
1704
1705 2016-07-20  Youenn Fablet  <youenn@apple.com>
1706
1707         Bots should run built-ins generator tests
1708         https://bugs.webkit.org/show_bug.cgi?id=159971
1709
1710         Reviewed by Alexey Proskuryakov.
1711
1712         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1713         (RunBuiltinsTests): New step to run built-in generator tests.
1714         (TestFactory.__init__): Adding an additional step for bultin generator tests.
1715         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Rebasing expectations.
1716         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Adding additional step for proper display.
1717
1718 2016-07-20  Aakash Jain  <aakash_jain@apple.com>
1719
1720         Revert temporary fix r203417
1721         https://bugs.webkit.org/show_bug.cgi?id=160001
1722
1723         Reviewed by Alexey Proskuryakov.
1724
1725         * EWSTools/start-queue-mac.sh: Revert the temporary fix.
1726
1727 2016-07-20  Aakash Jain  <aakash_jain@apple.com>
1728
1729         REGRESSION(r148588): ews classes might get garbage collected
1730         https://bugs.webkit.org/show_bug.cgi?id=159990
1731
1732         Reviewed by Ryosuke Niwa.
1733
1734         * Scripts/webkitpy/tool/commands/__init__.py: Store the loaded ews classes
1735         in a variable so that they do not get garbage collected.
1736
1737 2016-07-20  Jeremy Jones  <jeremyj@apple.com>
1738
1739         Add API test for layout constraints after exit fullscreen
1740         https://bugs.webkit.org/show_bug.cgi?id=159900
1741
1742         Reviewed by Jon Lee.
1743
1744         Added Fullscreen.LaytoutConstraints API test.
1745         Tests fix from https://bugs.webkit.org/show_bug.cgi?id=159731
1746
1747         This test compares layout constraints on the web view before and after fullscreen to make sure
1748         they are preserved.
1749
1750         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.html: Added.
1751         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.mm: Added.
1752         (-[FullscreenStateChangeMessageHandler userContentController:didReceiveScriptMessage:]):
1753         (TestWebKitAPI::TEST):
1754
1755 2016-07-20  Ryan Haddad  <ryanhaddad@apple.com>
1756
1757         Disable two failing API tests.
1758
1759         Unreviewed test gardening.
1760
1761         * TestWebKitAPI/Tests/mac/CandidateTests.mm:
1762         (TestWebKitAPI::TEST):
1763
1764 2016-07-20  Wenson Hsieh  <wenson_hsieh@apple.com>
1765
1766         Unreviewed iOS build fix.
1767
1768         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: Only import Carbon.h on Mac.
1769
1770 2016-07-20  Wenson Hsieh  <wenson_hsieh@apple.com>
1771
1772         Media controls don't appear when pausing a small autoplaying video
1773         https://bugs.webkit.org/show_bug.cgi?id=159972
1774         <rdar://problem/27180657>
1775
1776         Reviewed by Beth Dakin.
1777
1778         Adds a new test that verifies media controls show up when pausing a small autoplayed video. Also adds mechanisms
1779         for simulating basic user interaction in VideoControlsManager.
1780
1781         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1782         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1783         (-[WKWebView mouseDownAtPoint:]):
1784         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]):
1785         (-[OnLoadMessageHandler initWithWKWebView:handler:]):
1786         (-[OnLoadMessageHandler userContentController:didReceiveScriptMessage:]):
1787         (TestWebKitAPI::TEST):
1788         * TestWebKitAPI/Tests/WebKit2Cocoa/autoplaying-video-with-audio.html: Added.
1789
1790 2016-07-20  Per Arne Vollan  <pvollan@apple.com>
1791
1792         [Win] MathML fonts are not found.
1793         https://bugs.webkit.org/show_bug.cgi?id=159920
1794
1795         Reviewed by Alex Christensen.
1796
1797         When looking up a font in the registry, use the /v option of the Windows 'reg query' command to query
1798         for a specific registry key value.
1799
1800         * Scripts/webkitdirs.pm:
1801         (fontExists):
1802
1803 2016-07-20  Joseph Pecoraro  <pecoraro@apple.com>
1804
1805         Improve prepare-ChangeLog for @media blocks
1806         https://bugs.webkit.org/show_bug.cgi?id=159907
1807
1808         Reviewed by Timothy Hatcher.
1809
1810         * Scripts/prepare-ChangeLog:
1811         (get_selector_line_ranges_for_css):
1812         Get a range for @media blocks just like a selector.
1813             Start Line = line with '{'
1814             End line = line with '}'
1815             Name = "@media ..."
1816
1817         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning-expected.txt:
1818         Improved error messages for unbalanced portions.
1819
1820         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt:
1821         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css:
1822         (.media-query::before):
1823         (@media only screen and (max-width: 980px)):
1824         (.media-query a):
1825         (@media (-webkit-min-device-pixel-ratio: 2)):
1826         (.both a):
1827         (.both b):
1828         (.media-query b):
1829         (.media-query::after):
1830
1831 2016-07-20  Csaba Osztrogonác  <ossy@webkit.org>
1832
1833         Fix expectedFailErrorHandler in run-jsc-stress-tests
1834         https://bugs.webkit.org/show_bug.cgi?id=159811
1835
1836         Reviewed by Yusuke Suzuki.
1837
1838         * Scripts/run-jsc-stress-tests:
1839
1840 2016-07-20  Csaba Osztrogonác  <ossy@webkit.org>
1841
1842         Unreviewed Mac cmake buildfix after r203426. Just for fun.
1843
1844         * TestWebKitAPI/PlatformMac.cmake:
1845
1846 2016-07-19  Filip Pizlo  <fpizlo@apple.com>
1847
1848         The default testing mode should not involve disabling the FTL JIT
1849         https://bugs.webkit.org/show_bug.cgi?id=159929
1850
1851         Rubber stamped by Mark Lam and Saam Barati.
1852
1853         It used to be the case that most actively maintained ports did not have the FTL JIT enabled.
1854         Heck, for most of the FTL's initial development, it wasn't enabled anywhere. So, testing the
1855         FTL was not the default. You had to enable it with an option.
1856
1857         For some reason we have kept this arrangement even though the FTL JIT is now the default on
1858         all of the major ports. This has become a serious pain. For example, it's useful to be able
1859         to say that a test should only run in the default config that is representative of what a
1860         normal user would see if they ran JSC. Clearly, this would be a config that does not
1861         explicitly disable the FTL JIT on the command line. However, if you try to specify this then
1862         your test won't run at all if the --ftl-jit option is not passed. That's dangerous!
1863
1864         So, this change gets rid of all of this logic. I think it's better to get rid of it then to
1865         try to fix it, because:
1866
1867         - I don't know what the fix would look like. Presumably it would ensure that ports that don't
1868           have the FTL enabled never run any tests that explicitly disable the FTL, since that
1869           doesn't do anything. The code is not really structured to allow this.
1870
1871         - It benefits a minority of clients. Three build bots run tests in a config that has the FTL
1872           disabled in testing. On the other hand there are already build bots that do FTL tests
1873           despite having the FTL disabled by virtue of being a 32-bit platform. So, maybe rather than
1874           preserving this broken feature, we should create something that (a) acknowledges the fact
1875           that the FTL is the default on those platforms that support it and (b) avoids running
1876           no-ftl tests on precisely those platforms that don't have FTL.
1877
1878         - To the extent that some bots benefited from disabling FTL tests, they were doing it by
1879           relying on a feature that was never meant to stick around. The FTL JIT is meant to be the
1880           default configuration. Disabling the FTL JIT is the non-default. So, we shouldn't be
1881           pretending that the FTL JIT is not the default just because some bots used that as an
1882           optimization.
1883
1884         This change allows me to speed up some debug tests and paint some bots green.
1885
1886         * Scripts/run-javascriptcore-tests:
1887         (runJSCStressTests):
1888         * Scripts/run-jsc-stress-tests:
1889
1890 2016-07-19  Alex Christensen  <achristensen@webkit.org>
1891
1892         Fix API test after r203426.
1893         https://bugs.webkit.org/show_bug.cgi?id=159949
1894
1895         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
1896         (TEST):
1897         If there is website data already on disk, the initial count after putting the AppCache data in place will not be exactly 1.
1898         This is no problem.  We want to verify that it is a nonzero number and that it decrements by one when we remove the 1 AppCache data.
1899
1900 2016-07-19  Andy Estes  <aestes@apple.com>
1901
1902         Move WebKitErrorFrameLoadBlockedByContentFilter from WebKitErrors.h to WebKitErrorsPrivate.h
1903         https://bugs.webkit.org/show_bug.cgi?id=159956
1904
1905         Reviewed by Dan Bernstein.
1906
1907         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Included WKErrorRef.h.
1908         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
1909         Used kWKErrorCodeFrameLoadBlockedByContentFilter instead of WebKitErrorFrameLoadBlockedByContentFilter.
1910         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Included WebKitErrorsPrivate.h instead of WebKitErrors.h.
1911
1912 2016-07-19  Alex Christensen  <achristensen@webkit.org>
1913
1914         Add regression test for r203392
1915         https://bugs.webkit.org/show_bug.cgi?id=159949
1916
1917         Reviewed by Brady Eidson.
1918
1919         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
1920         (fileSize):
1921         (swizzledBundleIdentifierWebBookmarksD):
1922         (defaultApplicationCacheDirectory):
1923         (TEST):
1924         (swizzledBundleIdentifierMobileSafari): Deleted.
1925         This actually tests that webbookmarksd uses the path quirk in WebsiteDataStore::defaultApplicationCacheDirectory.
1926         I wanted to verify that it uses the same path as MobileSafari, but swizzling out the bundleIdentifier twice caused
1927         problems with the static bools that are set once in RuntimeApplicationChecks.mm.
1928
1929 2016-07-19  Alex Christensen  <achristensen@webkit.org>
1930
1931         Add regression test for r203392
1932         https://bugs.webkit.org/show_bug.cgi?id=159949
1933
1934         Reviewed by Brady Eidson.
1935
1936         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1937         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db: Added.
1938         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-shm: Added.
1939         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-wal: Added.
1940         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
1941         (TEST):
1942         (fileSize):
1943         (swizzledBundleIdentifierMobileSafari):
1944         (swizzledBundleIdentifierWebBookmarksD):
1945         (defaultApplicationCacheDirectory):
1946         * TestWebKitAPI/cocoa/InstanceMethodSwizzler.h: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.h.
1947         * TestWebKitAPI/cocoa/InstanceMethodSwizzler.mm: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.mm.
1948         * TestWebKitAPI/mac/InstanceMethodSwizzler.h: Removed.
1949         * TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Removed.
1950
1951 2016-07-19  Keith Miller  <keith_miller@apple.com>
1952
1953         Test262 should have a file with the revision and url
1954         https://bugs.webkit.org/show_bug.cgi?id=159937
1955
1956         Reviewed by Mark Lam.
1957
1958         The import script should update the information from
1959         the path to the test262 repository it gets.
1960
1961         * Scripts/import-test262-tests:
1962
1963 2016-07-19  Alexey Proskuryakov  <ap@apple.com>
1964
1965         Temporary workaround for iOS EWS failing after the fix for bug 159539.
1966         To be deleted once the root cause is found and addressed.
1967
1968         * EWSTools/start-queue-mac.sh:
1969
1970 2016-07-19  Frederic Wang  <fwang@igalia.com>
1971
1972         [win] Fixup the register name for STIX Math and Latin Modern Math
1973
1974         Unreviewed follow-up of r203406
1975
1976         * Scripts/webkitdirs.pm:
1977         (checkInstalledTools):
1978
1979 2016-07-19  Frederic Wang  <fwang@igalia.com>
1980
1981         [win] Update the list of MathML fonts
1982         https://bugs.webkit.org/show_bug.cgi?id=156838
1983
1984         The set of recommended math fonts is now described at
1985         https://trac.webkit.org/wiki/MathML/Fonts
1986         We update the Perl script to use the latest list of fonts.
1987
1988         Reviewed by Brent Fulgham.
1989
1990         * Scripts/webkitdirs.pm:
1991         (checkInstalledTools):
1992
1993 2016-07-19  Per Arne Vollan  <pvollan@apple.com>
1994
1995         [Win] The test fast/scrolling/overflow-scroll-past-max.html is timing out.
1996         https://bugs.webkit.org/show_bug.cgi?id=159342
1997
1998         Reviewed by Darin Adler.
1999
2000         Implement required functions in event sender.
2001
2002         * DumpRenderTree/PlatformWin.cmake:
2003         * DumpRenderTree/win/EventSender.cpp:
2004         (monitorWheelEvents): Added.
2005         (callAfterScrollingCompletes): Added.
2006
2007 2016-07-19  Youenn Fablet  <youenn@apple.com>
2008
2009         Add new aliases to http test server
2010         https://bugs.webkit.org/show_bug.cgi?id=159878
2011
2012         Reviewed by Darin Adler.
2013
2014         Adding testharness.css, testharness.js and testharnessreport.js new aliases to http test servers.
2015         Adding explicitly these links to perl script.
2016         Extracting default alias in an aliases.json file.
2017         Reading that file from python scripts to initialize aliases from that file.
2018
2019         Python script changes covered by unit tests and changed layout test.
2020
2021         * Scripts/webkitperl/httpd.pm:
2022         (getDefaultConfigForTestDirectory): Adding 3 new aliases
2023         * Scripts/webkitpy/layout_tests/servers/aliases.json: Added.
2024         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2025         (LayoutTestApacheHttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
2026         Adding -c directives for each alias.
2027         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
2028         (TestLayoutTestApacheHttpd.test_start_cmd): Adding aliases.json mock-up file.
2029         * Scripts/webkitpy/layout_tests/servers/http_server.py:
2030         (Lighttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
2031         Adding alias directive for each alias.
2032         (Lighttpd._prepare_config):
2033         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
2034         (HttpServerBase.__init__): Adding tests_dir member with a default value being layout tests directory.
2035         (HttpServerBase.aliases): Computing of alias from the json file, paths to the real files being relative to
2036         layout tests directory.
2037         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
2038         (TestHttpServer.test_start_cmd): Adding aliases.json mock-up file and updating test expectation.
2039         (TestHttpServer.test_win32_start_and_stop): Adding aliases.json mock-up file.
2040
2041 2016-07-18  Aakash Jain  <aakash_jain@apple.com>
2042
2043         EWS console logs doesn't go to log file
2044         https://bugs.webkit.org/show_bug.cgi?id=159539
2045         <rdar://problem/24464570>
2046
2047         Reviewed by David Kilzer.
2048
2049         * Scripts/webkitpy/common/system/logutils.py:
2050         (configure_logger_to_log_to_file): Added method to configure the logger to log to file.
2051         (FileSystemHandler): Added class which uses logging.FileHandler as base class and supports writing
2052         to filesystem. It also supports passing MockFilesystem.
2053         (FileSystemHandler.__init__): Initialize the class and calls base class __init__.
2054         (FileSystemHandler._open): Overrides the base class _open method to use filesystem object.
2055         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2056         (AbstractEarlyWarningSystemTest.test_failing_tests_message): Added MockHost() parameter.
2057         (_test_ews): Same.
2058         * Scripts/webkitpy/tool/commands/queues.py:
2059         (AbstractQueue.begin_work_queue): Configure the logger to log to file.
2060         (AbstractQueue._log_directory): Using filesystem object instead of os.
2061         (AbstractQueue.queue_log_path): Same.
2062         (AbstractQueue.__init__): Passed host parameter.
2063         (PatchProcessingQueue.__init__): Same.
2064         (CommitQueue.__init__): Same.
2065         (AbstractReviewQueue.__init__): Same.
2066         (StyleQueue.__init__): Same.
2067         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2068         (TestCommitQueue): Passed MockHost() as host.
2069         (TestCommitQueue.__init__): Same.
2070         (TestQueue.__init__): Same.
2071         (TestReviewQueue.__init__): Same.
2072         (TestFeederQueue.__init__): Same.
2073         (AbstractPatchQueueTest.test_next_patch): Same.
2074         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
2075         (test_commit_queue_failure): Same.
2076         (MockCommitQueueTask.results_from_patch_test_run): Same.
2077         (test_rollout_lands): Same.
2078         (test_non_valid_patch): Same.
2079         (test_auto_retry): Same.
2080         (test_style_queue_with_watch_list_exception): Same.
2081
2082 2016-07-02  Filip Pizlo  <fpizlo@apple.com>
2083
2084         WTF::Lock should be fair eventually
2085         https://bugs.webkit.org/show_bug.cgi?id=159384
2086
2087         Reviewed by Geoffrey Garen.
2088
2089         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2090
2091 2016-07-17  Sam Weinig  <sam@webkit.org>
2092
2093         [WebKit API] Add SPI to track multiple navigations caused by a single user gesture
2094         <rdar://problem/26554137>
2095         https://bugs.webkit.org/show_bug.cgi?id=159856
2096
2097         Reviewed by Dan Bernstein.
2098
2099         * MiniBrowser/mac/WK2BrowserWindowController.m:
2100         (-[WK2BrowserWindowController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2101         Add basic window.open implementation.
2102
2103         (-[WK2BrowserWindowController webView:decidePolicyForNavigationAction:decisionHandler:]):
2104         Add basic navigation policy implementation which implements a rule where a user gesture is only allowed
2105         to open a single non-web URL, all others are dropped.
2106
2107         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2108         * TestWebKitAPI/Tests/WebKit2Cocoa/UserInitiatedActionInNavigationAction.mm: Added.
2109         * TestWebKitAPI/Tests/WebKit2Cocoa/open-multiple-external-url.html: Added.
2110         Add API for the new SPI.
2111
2112 2016-07-17  Yusuke Suzuki  <utatane.tea@gmail.com>
2113
2114         [JSC] Enable test262 module tests
2115         https://bugs.webkit.org/show_bug.cgi?id=159854
2116
2117         Reviewed by Saam Barati.
2118
2119         Use --module-file instead.
2120
2121         * Scripts/run-jsc-stress-tests:
2122
2123 2016-07-16  Chris Dumez  <cdumez@apple.com>
2124
2125         Unreviewed, rolling out r203318.
2126
2127         Regressed most JS Benchmarks on MacBook Air by ~2% (7% on
2128         SunSpider)
2129
2130         Reverted changeset:
2131
2132         "[JSC] Change some parameters based on a random search"
2133         https://bugs.webkit.org/show_bug.cgi?id=158514
2134         http://trac.webkit.org/changeset/203318
2135
2136 2016-07-16  Chris Dumez  <cdumez@apple.com>
2137
2138         Add move constructor / assignment operator to ListHashSet
2139         https://bugs.webkit.org/show_bug.cgi?id=159837
2140
2141         Reviewed by Darin Adler.
2142
2143         Add API tests.
2144
2145         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
2146         (TestWebKitAPI::TEST):
2147
2148 2016-07-15  Benjamin Poulain  <bpoulain@apple.com>
2149
2150         [JSC] Change some parameters based on a random search
2151         https://bugs.webkit.org/show_bug.cgi?id=158514
2152
2153         Reviewed by Saam Barati.
2154
2155         * Scripts/run-jsc-stress-tests:
2156
2157 2016-07-15  Jon Davis  <jond@apple.com>
2158
2159         Changed the start page URL for WebKit Nightly builds.
2160         https://bugs.webkit.org/show_bug.cgi?id=159816
2161
2162         Reviewed by Timothy Hatcher.
2163
2164         * WebKitLauncher/start.html:
2165
2166 2016-07-15  Per Arne Vollan  <pvollan@apple.com>
2167
2168         Uninitialized variable in DIBPixelData can cause a dangerous memory write
2169         https://bugs.webkit.org/show_bug.cgi?id=159414
2170
2171         Reviewed by Brent Fulgham.
2172
2173         Add test to check that DIBPixelData::setRGBABitmapAlpha does not cause a crash
2174         when the HDC parameter is invalid.
2175
2176         * TestWebKitAPI/PlatformWin.cmake:
2177         * TestWebKitAPI/Tests/WebCore/win/DIBPixelData.cpp: Added.
2178         (TestWebKitAPI::TEST):
2179
2180 2016-07-15  Carlos Garcia Campos  <cgarcia@igalia.com>
2181
2182         [GTK] Add basic tabs support to MiniBrowser
2183         https://bugs.webkit.org/show_bug.cgi?id=159803
2184
2185         Reviewed by Sergio Villar Senin.
2186
2187         It's quite common to have issues with web views loaded in secondary tabs, and we need to use an external browser
2188         like epiphany to debug those issues. It would be a lot easier to work on those bugs if we could use the MiniBrowser.
2189
2190         * MiniBrowser/gtk/BrowserTab.c: Added.
2191         (titleChanged):
2192         (isLoadingChanged):
2193         (decidePolicy):
2194         (removeChildIfInfoBar):
2195         (loadChanged):
2196         (createInfoBarQuestionMessage):
2197         (tlsErrorsDialogResponse):
2198         (loadFailedWithTLSerrors):
2199         (permissionRequestDialogResponse):
2200         (decidePermissionRequest):
2201         (colorChooserRGBAChanged):
2202         (popoverColorClosed):
2203         (colorChooserRequestFinished):
2204         (runColorChooserCallback):
2205         (inspectorOpenedInWindow):
2206         (inspectorClosed):
2207         (browserTabSetProperty):
2208         (browserTabFinalize):
2209         (browser_tab_init):
2210         (browserTabConstructed):
2211         (browser_tab_class_init):
2212         (getInternalURI):
2213         (browser_tab_new):
2214         (browser_tab_get_web_view):
2215         (browser_tab_load_uri):
2216         (browser_tab_get_title_widget):
2217         (browser_tab_set_status_text):
2218         (browser_tab_toggle_inspector):
2219         (browser_tab_start_search):
2220         (browser_tab_stop_search):
2221         (browser_tab_add_accelerators):
2222         (fullScreenMessageTimeoutCallback):
2223         (browser_tab_enter_fullscreen):
2224         (browser_tab_leave_fullscreen):
2225         * MiniBrowser/gtk/BrowserTab.h: Added.
2226         * MiniBrowser/gtk/BrowserWindow.c:
2227         (getExternalURI):
2228         (browserWindowSetStatusText):
2229         (reloadOrStopCallback):
2230         (goBackCallback):
2231         (goForwardCallback):
2232         (settingsCallback):
2233         (webViewURIChanged):
2234         (browserWindowHistoryItemActivated):
2235         (browserWindowUpdateNavigationActions):
2236         (webViewCreate):
2237         (webViewEnterFullScreen):
2238         (webViewLeaveFullScreen):
2239         (webViewDecidePolicy):
2240         (browserWindowCanZoomIn):
2241         (browserWindowCanZoomOut):
2242         (browserWindowZoomIn):
2243         (browserWindowZoomOut):
2244         (scrollEventCallback):
2245         (faviconChanged):
2246         (webViewIsLoadingChanged):
2247         (defaultZoomCallback):
2248         (searchCallback):
2249         (newTabCallback):
2250         (toggleWebInspector):
2251         (reloadPage):
2252         (reloadPageIgnoringCache):
2253         (stopPageLoad):
2254         (loadHomePage):
2255         (editingCommandCallback):
2256         (insertImageCommandCallback):
2257         (insertLinkCommandCallback):
2258         (browserWindowSetupEditorToolbar):
2259         (browserWindowSwitchTab):
2260         (browserWindowTabAddedOrRemoved):
2261         (browser_window_init):
2262         (browserWindowConstructed):
2263         (browserWindowSaveSession):
2264         (browserWindowDeleteEvent):
2265         (browser_window_new):
2266         (browser_window_append_view):
2267         (browser_window_load_uri):
2268         (browser_window_load_session):
2269         (browser_window_set_background_color):
2270         (resetStatusText): Deleted.
2271         (activateUriEntryCallback): Deleted.
2272         (webViewTitleChanged): Deleted.
2273         (resetEntryProgress): Deleted.
2274         (browserWindowCreateBackForwardMenu): Deleted.
2275         (webViewReadyToShow): Deleted.
2276         (webViewLoadFailed): Deleted.
2277         (webViewMouseTargetChanged): Deleted.
2278         (browserWindowUpdateZoomActions): Deleted.
2279         (webViewZoomLevelChanged): Deleted.
2280         (updateUriEntryIcon): Deleted.
2281         (zoomInCallback): Deleted.
2282         (zoomOutCallback): Deleted.
2283         (toggleFullScreen): Deleted.
2284         (browserWindowEditingCommandToggleButtonSetActive): Deleted.
2285         (browserWindowFinalize): Deleted.
2286         (browser_window_class_init): Deleted.
2287         * MiniBrowser/gtk/BrowserWindow.h:
2288         * MiniBrowser/gtk/CMakeLists.txt:
2289         * MiniBrowser/gtk/main.c:
2290         (createBrowserTab):
2291         (aboutURISchemeRequestCallback):
2292         (main):
2293         (parseBackgroundColor): Deleted.
2294
2295 2016-07-14  Alex Christensen  <achristensen@webkit.org>
2296
2297         Allow RefPtrs of const RefCounted types
2298         https://bugs.webkit.org/show_bug.cgi?id=158269
2299
2300         Reviewed by Anders Carlsson.
2301
2302         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
2303         (TestWebKitAPI::TEST):
2304         (TestWebKitAPI::ConstRefCounted::create):
2305         (TestWebKitAPI::returnConstRefCountedRef):
2306         (TestWebKitAPI::returnRefCountedRef):
2307
2308 2016-07-13  Carlos Garcia Campos  <cgarcia@igalia.com>
2309
2310         Test WTF.StringViewIterators is crashing since r203119
2311         https://bugs.webkit.org/show_bug.cgi?id=159710
2312
2313         Reviewed by Darin Adler.
2314
2315         There are two problems in the test case added in r203119. First is that it's testing
2316         StringView::CodeUnits::Iterator instead of StringView::CodePoints::Iterator, and second is that
2317         StringView::codePoints() returns a temporary, so the iterator created from the temporary ends up pointing to a
2318         const reference to the string view member of the deleted CodePoints object.
2319
2320         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2321         (TestWebKitAPI::TEST):
2322
2323 2016-07-13  Daniel Bates  <dabates@apple.com>
2324
2325         [iOS] Copy WebKitTestRunnerInjectedBundle.bundle into PlugIns subdirectory and code sign it
2326         https://bugs.webkit.org/show_bug.cgi?id=159738
2327         <rdar://problem/27304649>
2328
2329         Reviewed by Dan Bernstein.
2330
2331         The bundle WebKitTestRunnerInjectedBundle.bundle contains executable code and should be
2332         code signed if applicable. We should also copy this bundle into the PlugIns subdirectory
2333         of the WebKitTestRunnerApp.app bundle instead of the top-level bundle directory as the
2334         PlugIns subdirectory is the directory where loadable bundles of an app are expected to live.
2335
2336         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2337         * WebKitTestRunner/ios/TestControllerIOS.mm:
2338         (WTR::TestController::initializeInjectedBundlePath): Modified code to look for the
2339         bundle WebKitTestRunnerInjectedBundle.bundle in the plugin directory of the main bundle.
2340
2341 2016-07-13  Beth Dakin  <bdakin@apple.com>
2342
2343         Attempted build fix.
2344
2345         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2346
2347 2016-07-12  Ryosuke Niwa  <rniwa@webkit.org>
2348
2349         REGRESSION(r202953): Clicking on input[type=file] doesn't open a file picker
2350         https://bugs.webkit.org/show_bug.cgi?id=159686
2351
2352         Reviewed by Chris Dumez.
2353
2354         Added a code to print "OPEN FILE PANEL" in the text when runOpenPanel is called in the UI delegate.
2355
2356         * WebKitTestRunner/TestController.cpp:
2357         (WTR::runOpenPanel):
2358         (WTR::TestController::createOtherPage):
2359         (WTR::TestController::createWebViewWithOptions):
2360
2361 2016-07-13  Beth Dakin  <bdakin@apple.com>
2362
2363         Add more candidate tests
2364         https://bugs.webkit.org/show_bug.cgi?id=159730
2365
2366         Reviewed by Tim Horton.
2367
2368         This patch re-names ViewWithEditableAreaLeak.mm to CandidateTests.mm and adds
2369         two new tests to that file.
2370         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2371         * TestWebKitAPI/Tests/WebKit2Cocoa/focus-inputs.html: Added.
2372         * TestWebKitAPI/Tests/mac/CandidateTests.mm: Copied from TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm.
2373         (-[CandidateRequestFrameLoadDelegate webView:didFinishLoadForFrame:]):
2374         (TestWebKitAPI::TEST):
2375         * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm: Removed.
2376
2377 2016-07-13  Joanmarie Diggs  <jdiggs@igalia.com>
2378
2379         AX: [ATK] spinbutton-crash.html fails
2380         https://bugs.webkit.org/show_bug.cgi?id=159723
2381
2382         Reviewed by Chris Fleizach.
2383
2384         Implement support for AXDecrementButton and AXIncrementButton in
2385         ATK's AccessibilityUIElement::uiElementAttributeValue().
2386
2387         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2388         (WTR::AccessibilityUIElement::uiElementAttributeValue):
2389
2390 2016-07-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2391
2392         [EFL] [GTK] Enable back crypto subtle on development builds.
2393         https://bugs.webkit.org/show_bug.cgi?id=159260
2394
2395         Reviewed by Carlos Garcia Campos.
2396
2397         * Scripts/webkitperl/FeatureList.pm:
2398
2399 2016-07-12  Mark Lam  <mark.lam@apple.com>
2400
2401         We should use different stack limits for stack checks from JS and host code.
2402         https://bugs.webkit.org/show_bug.cgi?id=159442
2403         <rdar://problem/26889188>
2404
2405         Reviewed by Geoffrey Garen.
2406
2407         In http://trac.webkit.org/r203067, we limited the amount of stack that tests will
2408         run with to keep stack overflow tests sane.  Turns out, we also need to teach the
2409         LayoutTestRelay to pass env vars over to the iOS simulator.  This is needed in
2410         order to keep the js/regress-139548.html test happy with this patch.
2411
2412         Also fixed up run_webkit_tests.py to explicitly pass an int size value for the
2413         JSC_maxPerThreadStackUsage option.  Otherwise, it will pass a float value.
2414
2415         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2416         (-[LTRelayController _environmentVariables]):
2417         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2418         (main):
2419
2420 2016-07-12  Filip Pizlo  <fpizlo@apple.com>
2421
2422         platformUserPreferredLanguages on Mac should not try to put the region into the language
2423         https://bugs.webkit.org/show_bug.cgi?id=159693
2424
2425         Rubber stamped by Alexey Proskuryakov.
2426
2427         Revert the test change in r200105.
2428
2429         * TestWebKitAPI/Tests/mac/NavigatorLanguage.mm:
2430         (TestWebKitAPI::languageForSystemLanguage):
2431
2432 2016-07-12  Chris Dumez  <cdumez@apple.com>
2433
2434         [WK2] Protect against bad database data in LocalStorageDatabase::importItems()
2435         https://bugs.webkit.org/show_bug.cgi?id=159663
2436         <rdar://problem/18995873>
2437
2438         Reviewed by Benjamin Poulain.
2439
2440         Add API test coverage.
2441
2442         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2443         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.html: Added.
2444         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage: Added.
2445         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage-shm: Added.
2446         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.mm: Added.
2447         (-[LocalStorageNullEntriesMessageHandler userContentController:didReceiveScriptMessage:]):
2448         (TEST):
2449
2450 2016-07-12  Myles C. Maxfield  <mmaxfield@apple.com>
2451
2452         Relax ordering requirements on StringView::CodePoints iterator
2453         https://bugs.webkit.org/show_bug.cgi?id=159609
2454
2455         Reviewed by Darin Adler.
2456
2457         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2458         (TestWebKitAPI::TEST):
2459
2460 2016-07-12  Youenn Fablet  <youenn@apple.com>
2461
2462         Fixing Tools/Scripts/run-builtins-generator-tests after https://trac.webkit.org/changeset/202975
2463         https://bugs.webkit.org/show_bug.cgi?id=159564
2464
2465         Reviewed by Brian Burg.
2466
2467         * Scripts/webkitpy/codegen/main.py:
2468         (BuiltinsGeneratorTests.generate_from_js_builtins): Changing --with-wrapper-files option to --wrappers.
2469
2470 2016-07-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2471
2472         Remove ENABLE_CSS3_TEXT_LINE_BREAK flag
2473         https://bugs.webkit.org/show_bug.cgi?id=159671
2474
2475         Reviewed by Csaba Osztrogonác.
2476
2477         ENABLE_CSS3_TEXT_LINE_BREAK feature was implemented without guards.
2478         https://bugs.webkit.org/show_bug.cgi?id=89235
2479
2480         So this guard can be removed in build scripts.
2481
2482         * Scripts/webkitperl/FeatureList.pm:
2483         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2484
2485 2016-07-11  Jason Marcell  <jmarcell@apple.com>
2486
2487         SVN.create_patch should find svn-create-patch relative to the WebKit root.
2488         https://bugs.webkit.org/show_bug.cgi?id=159652
2489
2490         Reviewed by Daniel Bates.
2491
2492         * Scripts/webkitpy/common/checkout/scm/svn.py:
2493         (SVN.create_patch): Use WebKitFinder to find the WebKit checkout so that we can find svn-create-patch relative to it.
2494
2495 2016-07-11  Myles C. Maxfield  <mmaxfield@apple.com>
2496
2497         Implement grapheme cluster iterator on StringView
2498         https://bugs.webkit.org/show_bug.cgi?id=159598
2499
2500         Reviewed by Anders Carlsson.
2501
2502         This is in preparation for honoring the second argument to FontFaceSet.load().
2503
2504         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2505         (TestWebKitAPI::compareLoopIterations):
2506         (TestWebKitAPI::TEST):
2507
2508 2016-07-11  Nan Wang  <n_wang@apple.com>
2509
2510         AX: WKWebView should have API to prevent pinch-to-zoom always being allowed
2511         https://bugs.webkit.org/show_bug.cgi?id=158364
2512
2513         Reviewed by Anders Carlsson.
2514
2515         Added a function in TestRunner so that we can toggle the ignoring viewport
2516         scale limits setting. Also added a test option for that in order to change the
2517         configuration of the webview in test.
2518
2519         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2520         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2521         (WTR::TestRunner::setNavigationGesturesEnabled):
2522         (WTR::TestRunner::setIgnoresViewportScaleLimits):
2523         (WTR::nextUIScriptCallbackID):
2524         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2525         (WTR::TestRunner::shouldDecideNavigationPolicyAfterDelay):
2526         * WebKitTestRunner/TestController.cpp:
2527         (WTR::TestController::resetStateToConsistentValues):
2528         (WTR::updateTestOptionsFromTestHeader):
2529         (WTR::TestController::setNavigationGesturesEnabled):
2530         (WTR::TestController::setIgnoresViewportScaleLimits):
2531         (WTR::TestController::platformWillRunTest):
2532         * WebKitTestRunner/TestController.h:
2533         (WTR::TestController::setShouldDecideNavigationPolicyAfterDelay):
2534         * WebKitTestRunner/TestInvocation.cpp:
2535         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2536         * WebKitTestRunner/TestOptions.h:
2537         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2538         (WTR::TestController::platformCreateWebView):
2539
2540 2016-07-11  Konstantin Tokarev  <annulen@yandex.ru>
2541
2542         [GTK] install-dependencies should not install packages built by jhbuild.
2543         https://bugs.webkit.org/show_bug.cgi?id=159628
2544
2545         Reviewed by Michael Catanzaro.
2546
2547         * gtk/install-dependencies:
2548         Don't install icu, harfbuzz, orc, llvm, freetype, fontconfig.
2549
2550 2016-07-11  Olivier Blin  <olivier.blin@softathome.com>
2551
2552         System proxy settings not used when building deps with jhbuild
2553         https://bugs.webkit.org/show_bug.cgi?id=159567
2554
2555         Reviewed by Michael Catanzaro.
2556
2557         This adds the gsettings-desktop-schemas-devel build dep to enable
2558         the libgiognomeproxy.so gio module in glib-networking, which uses
2559         GSettings on org.gnome.system.proxy.
2560         This is needed to query system proxy settings for Gnome desktops.
2561
2562         dconf can be manually added to jhbuild to build the
2563         libdconfsettings.so gio module for GSettings, so that
2564         libgiognomeproxy.so can access system settings.
2565           https://trac.webkit.org/wiki/WebKitGTK/StartHacking#Workingbehindaproxy
2566
2567         As an alternative to dconf settings, this commit also adds the
2568         libproxy-devel build dep to enable the libgiolibproxy.so module in
2569         glib-networking (suggested by Fujii Hironori).
2570
2571         It is useful to read proxy settings from environment variables.
2572         From a Gnome desktop, one may unset the GNOME_DESKTOP_SESSION_ID
2573         environment variable to force using the envvar module in libproxy.
2574
2575         * gtk/install-dependencies:
2576
2577 2016-07-11  Mark Lam  <mark.lam@apple.com>
2578
2579         Change run-webkit-tests.py and run-jsc-stress-tests to use a smaller JS stack size for testing.
2580         https://bugs.webkit.org/show_bug.cgi?id=159524
2581
2582         Reviewed by Michael Saboff.
2583
2584         Forced tests to run with only a 1.5M JS stack size instead of the default 4M.
2585         Also fixed up some tests to behave better to work with this new limit.  This
2586         should make stack overflow tests complete sooner.
2587
2588         * Scripts/run-jsc-stress-tests:
2589         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2590         (main):
2591
2592 2016-07-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2593
2594         [GTK] Whitespace fixes in install-dependencies script
2595
2596         Unreviewed.
2597
2598         * gtk/install-dependencies:
2599
2600 2016-07-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2601
2602         [GTK] Install missing Fedora dependencies
2603
2604         Unreviewed.
2605
2606         * gtk/install-dependencies:
2607
2608 2016-07-09  Dan Bernstein  <mitz@apple.com>
2609
2610         Give git-add-reviewer an option to say “Rubber-stamped by” in non-interactive mode
2611         https://bugs.webkit.org/show_bug.cgi?id=159600
2612
2613         Reviewed by Daniel Bates.
2614
2615         * Scripts/git-add-reviewer:
2616         Added the -s|--rubber-stamp option.
2617         (nonInteractive): Set the rubberstamp key in the item passed to addReviewer() based on the
2618           new option.
2619
2620 2016-07-08  Andy Estes  <aestes@apple.com>
2621
2622         [Content Filtering] Load blocked pages more like other error pages are loaded
2623         https://bugs.webkit.org/show_bug.cgi?id=159485
2624         <rdar://problem/26014076>
2625
2626         Reviewed by Brady Eidson.
2627
2628         Added API tests for WebView and WKWebView to verify that alternate HTML loaded in response
2629         to a content filtering provisional navigation failure is ignored in preference of
2630         ContentFilter's own error page.
2631
2632         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2633         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2634         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
2635         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
2636         (-[LoadAlternateNavigationDelegate webView:didFinishNavigation:]):
2637         (loadAlternateTest):
2638         (TEST):
2639         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
2640         (-[MockContentFilterEnabler initWithCoder:]):
2641         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Added.
2642         (-[LoadAlternateFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2643         (-[LoadAlternateFrameLoadDelegate webView:didFinishLoadForFrame:]):
2644         (TestWebKitAPI::loadAlternateTest):
2645         (TestWebKitAPI::TEST):
2646
2647 2016-07-08  Commit Queue  <commit-queue@webkit.org>
2648
2649         Unreviewed, rolling out r202944.
2650         https://bugs.webkit.org/show_bug.cgi?id=159570
2651
2652         caused some tests to crash under GuardMalloc (Requested by
2653         estes on #webkit).
2654
2655         Reverted changeset:
2656
2657         "[Content Filtering] Load blocked pages more like other error
2658         pages are loaded"
2659         https://bugs.webkit.org/show_bug.cgi?id=159485
2660         http://trac.webkit.org/changeset/202944
2661
2662 2016-07-08  Martin Robinson  <mrobinson@igalia.com>
2663
2664         Remove mrobinson from the MathML watchlist
2665         https://bugs.webkit.org/show_bug.cgi?id=159559
2666
2667         Reviewed by Philippe Normand.
2668
2669         * Scripts/webkitpy/common/config/watchlist: Remove my email from the watchlist.
2670
2671 2016-07-08  Brady Eidson  <beidson@apple.com>
2672
2673         Clearing LocalStorage doesn't also delete -wal and -shm files.
2674         <rdar://problem/27206772> and https://bugs.webkit.org/show_bug.cgi?id=159566
2675
2676         Reviewed by Brent Fulgham.
2677         Also helpfully picked over by Andy "Never Forgets" Estes.
2678
2679         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2680         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.html: Added.
2681         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm: Added.
2682
2683 2016-07-08  Konstantin Tokarev  <annulen@yandex.ru>
2684
2685         Removed Qt leftovers from Tools.
2686         https://bugs.webkit.org/show_bug.cgi?id=159557
2687
2688         Reviewed by Csaba Osztrogonác.
2689
2690         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2691         Removed 'qt' platform config.
2692         * Scripts/webkitpy/common/net/bugzilla/bug.py:
2693         Deleted non-functional e-mail address.
2694
2695 2016-07-08  Commit Queue  <commit-queue@webkit.org>
2696
2697         Unreviewed, rolling out r202967.
2698         https://bugs.webkit.org/show_bug.cgi?id=159556
2699
2700         This patch caused crashes in https tests on Windows (Requested
2701         by perarne on #webkit).
2702
2703         Reverted changeset:
2704
2705         "[Win] The test http/tests/security/contentSecurityPolicy
2706         /upgrade-insecure-requests/basic-upgrade.https.html is
2707         failing."
2708         https://bugs.webkit.org/show_bug.cgi?id=159510
2709         http://trac.webkit.org/changeset/202967
2710
2711 2016-07-08  Youenn Fablet  <youenn@apple.com>
2712
2713         Generate WebCore builtin wrapper files
2714         https://bugs.webkit.org/show_bug.cgi?id=159461
2715
2716         Reviewed by Brian Burg.
2717
2718         * Scripts/webkitpy/codegen/main.py:
2719         (BuiltinsGeneratorTests.generate_from_js_builtins): Adding generate_wrapper option.
2720         (BuiltinsGeneratorTests.run_tests): Using this option in WebCore test cases.
2721
2722 2016-07-08  Hunseop Jeong  <hs85.jeong@samsung.com>
2723
2724         [EFL] Fix build when media-stream is enabled.
2725         https://bugs.webkit.org/show_bug.cgi?id=159206
2726
2727         Bump up the openwebrtc to find the correct package.
2728
2729         Reviewed by Gyuyoung Kim.
2730
2731         * efl/jhbuild.modules:
2732         * efl/patches/openwebrtc-clang-warning-fix.patch: Removed.
2733
2734 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
2735
2736         [Win] The test http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade.https.html is failing.
2737         https://bugs.webkit.org/show_bug.cgi?id=159510
2738
2739         Reviewed by Brent Fulgham.
2740
2741         Allow any https certificate when running tests.
2742
2743         * DumpRenderTree/win/DumpRenderTree.cpp:
2744         (runTest):
2745
2746 2016-07-07  Beth Dakin  <bdakin@apple.com>
2747
2748         API Test DoNotLeakWebView.ViewThatLoadsEditableArea times out on macOS Sierra
2749         https://bugs.webkit.org/show_bug.cgi?id=159532
2750         -and corresponding-
2751         rdar://problem/27177179
2752
2753         Reviewed by Tim Horton.
2754
2755         * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm:
2756         (-[DoNotLeakFrameLoadDelegate webView:didFinishLoadForFrame:]):
2757
2758 2016-07-07  Andy Estes  <aestes@apple.com>
2759
2760         [Content Filtering] Load blocked pages more like other error pages are loaded
2761         https://bugs.webkit.org/show_bug.cgi?id=159485
2762         <rdar://problem/26014076>
2763
2764         Reviewed by Brady Eidson.
2765
2766         Added API tests for WebView and WKWebView to verify that alternate HTML loaded in response
2767         to a content filtering provisional navigation failure is ignored in preference of
2768         ContentFilter's own error page.
2769
2770         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2771         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2772         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
2773         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
2774         (-[LoadAlternateNavigationDelegate webView:didFinishNavigation:]):
2775         (loadAlternateTest):
2776         (TEST):
2777         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
2778         (-[MockContentFilterEnabler initWithCoder:]):
2779         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Added.
2780         (-[LoadAlternateFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2781         (-[LoadAlternateFrameLoadDelegate webView:didFinishLoadForFrame:]):
2782         (TestWebKitAPI::loadAlternateTest):
2783         (TestWebKitAPI::TEST):
2784
2785 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
2786
2787         Unreviewed: add myself to the reviewers list.
2788
2789         * Scripts/webkitpy/common/config/contributors.json:
2790
2791 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
2792
2793         [Win] The test http/tests/loading/main-resource-delegates-on-back-navigation.html is failing.
2794         https://bugs.webkit.org/show_bug.cgi?id=159509
2795
2796         Reviewed by Alex Christensen.
2797
2798         We should always insert the url in the url map when identifierForInitialRequest
2799         is called. Otherwise we can end up with identifiers not having an entry in the
2800         url map when urls are written to the test output file.
2801
2802         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2803         (ResourceLoadDelegate::identifierForInitialRequest):
2804
2805 2016-07-06  Tim Horton  <timothy_horton@apple.com>
2806
2807         Email from June 1st containing text 'Today @ 7:10PM' is linkified, but shouldn't be
2808         https://bugs.webkit.org/show_bug.cgi?id=159498
2809         <rdar://problem/26719903>
2810
2811         Reviewed by Sam Weinig.
2812
2813         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2814         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm: Added.
2815         (-[DataDetectionNavigationDelegate webView:didFinishNavigation:]):
2816         (-[DataDetectionUIDelegate _dataDetectionContextForWebView:]):
2817         (expectLinkCount):
2818         (TEST):
2819         Add a test ensuring that ReferenceDate in the DataDetectors context is respected
2820         when deciding what to linkify.
2821
2822 2016-07-06  Alexey Proskuryakov  <ap@apple.com>
2823
2824         Build fix - work around rdar://problem/27196668.
2825
2826         * LayoutTestRelay/Configurations/Base.xcconfig:
2827
2828 2016-07-05  Per Arne Vollan  <pvollan@apple.com>
2829
2830         Enhance Windows DRT implementation to support platform scroll wheel events.
2831         https://bugs.webkit.org/show_bug.cgi?id=36002
2832
2833         Reviewed by Brent Fulgham.
2834
2835         Implement function continuousMouseScrollBy in Windows event sender.
2836
2837         * DumpRenderTree/win/EventSender.cpp:
2838         (mouseScrollBy):
2839         (continuousMouseScrollBy):
2840
2841 2016-07-05  Myles C. Maxfield  <mmaxfield@apple.com>
2842
2843         [Sierra] Rebaseline tests to use un-mocked system font metrics
2844         https://bugs.webkit.org/show_bug.cgi?id=159311
2845         <rdar://problem/24138411>
2846
2847         Reviewed in person by Alexey Proskuryakov.
2848
2849         Stop mocking the system font on Sierra.
2850
2851         * DumpRenderTree/mac/DumpRenderTree.mm:
2852         (setDefaultsToConsistentValuesForTesting):
2853         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2854         (WTR::InjectedBundle::platformInitialize):
2855
2856 2016-07-05  Brady Eidson  <beidson@apple.com>
2857
2858         Database process crashes deleting a corrupt SQLite database file (null deref).
2859         https://bugs.webkit.org/show_bug.cgi?id=155506.
2860
2861         Reviewed by Alex Christensen.
2862
2863         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2864         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.html: Added.
2865         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm: Added.
2866         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3: Added.
2867         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3-shm: Added.
2868         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3-wal: Added.
2869
2870 2016-07-05  Alexey Proskuryakov  <ap@apple.com>
2871
2872         run-webkit-tests should print more complete baseline search paths
2873         https://bugs.webkit.org/show_bug.cgi?id=159354
2874
2875         Reviewed by Daniel Bates.
2876
2877         run-webkit-tests used to only print directory names in baseline search paths.
2878         This was ok in basic usage, but quickly got confusing when using
2879         --additional-platform-directory flags.
2880
2881         * Scripts/webkitpy/layout_tests/views/printing.py:
2882         (Printer.print_config):
2883         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
2884         (Testprinter.test_print_config):
2885         (Testprinter.test_print_one_line_summary):
2886
2887 2016-07-04  Brady Eidson  <beidson@apple.com>
2888
2889         WebProcesses don't handle DatabaseProcess going away uncleanly..
2890         https://bugs.webkit.org/show_bug.cgi?id=159371
2891
2892         Reviewed by Alex Christensen.
2893
2894         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2895         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill-1.html: Added.
2896         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm: Added.
2897         (-[DatabaseProcessKillNavigationDelegate webView:didFinishNavigation:]):
2898         (-[DatabaseProcessKillMessageHandler userContentController:didReceiveScriptMessage:]):
2899
2900 2016-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2901
2902         [EFL][GTK] Layout Test doesn't run on Ubuntu 16.04
2903         https://bugs.webkit.org/show_bug.cgi?id=158141
2904
2905         Rubber-stamped by Michael Catanzaro.
2906
2907         Instead of checking for an specific Ubuntu version, query the apt
2908         database to see which version of PHP is available.
2909
2910         * efl/install-dependencies:
2911         * gtk/install-dependencies:
2912
2913 2016-07-04  Fujii Hironori  <Hironori.Fujii@sony.com>
2914
2915         webkit-patch failure-reason always raises TypeError
2916         https://bugs.webkit.org/show_bug.cgi?id=159394
2917
2918         Reviewed by Benjamin Poulain.
2919
2920         In r170637 (Bug 133067), the first and second arguments of
2921         pluralize were swapped.
2922
2923         * Scripts/webkitpy/tool/commands/queries.py:
2924         (FailureReason._builder_to_explain): Swap the first and second
2925         arguments of pluralize.
2926
2927 2016-07-02  Youenn Fablet  <youennf@gmail.com>
2928
2929         Make it straightforward to start the Web Platform Tests HTTP server using run-webkit-httpd
2930         https://bugs.webkit.org/show_bug.cgi?id=152486
2931
2932         Reviewed by Daniel Bates.
2933
2934         Add launch of web-platform-tests server by run-webkit-httpd.
2935         Add two options to disable starting httpd and web-platform-tests servers.
2936
2937         * Scripts/run-webkit-httpd:
2938         (parse_args):
2939         (main):
2940
2941 2016-07-01  Myles C. Maxfield  <mmaxfield@apple.com>
2942
2943         REGRESSION(r189668): Notification tests are flakey
2944         https://bugs.webkit.org/show_bug.cgi?id=159375
2945         <rdar://problem/22760990>
2946
2947         Reviewed by Alexey Proskuryakov.
2948
2949         Notifications are objects which must exist in both the UI Process and the Web Process. Each process
2950         identifies a notification object by a unique ID. When the Web Process sends a message regarding a
2951         notification to the UI Process, the UI Process's WebNotificationManagerProxy holds a map from
2952         (Page ID, Web Process notification ID) -> UI Process notification ID. This works as intended.
2953
2954         Our tests, however, include an additional method, simulateWebNotificationClick(), which is implemented
2955         by WebKitTestRunner in the Web Process via the Injected Bundle. This method involves sending a message
2956         to the UI process, to handle the simulated click. However, that RPC didn't perform the same local ->
2957         global notification ID mapping, causing the wrong notification to be investigated.
2958
2959         The solution is for WebNotificationProvider, implemented in WebKitTestRunner in the UI Process, to
2960         manually perform this same mapping. Luckily, this object already receives callbacks every time a
2961         notification is created or destroyed. However, because this object is implemented outside WebKit,
2962         it isn't privy to the internal Web Process ID used inside WebNotificationmanagerProxy. Therefore,
2963         this patch adds a private testing function which returns this internal ID. Once given this intenal ID,
2964         WebNotificationProvider can properly map between the different IDs.
2965
2966         * WebKitTestRunner/TestController.cpp:
2967         (WTR::TestController::runTestingServerLoop):
2968         (WTR::TestController::simulateWebNotificationClick):
2969         * WebKitTestRunner/WebNotificationProvider.cpp:
2970         (WTR::WebNotificationProvider::showWebNotification):
2971         (WTR::removeGlobalIDFromIDMap):
2972         (WTR::WebNotificationProvider::closeWebNotification):
2973         (WTR::WebNotificationProvider::removeNotificationManager):
2974         (WTR::WebNotificationProvider::simulateWebNotificationClick):
2975         (WTR::WebNotificationProvider::reset):
2976         * WebKitTestRunner/WebNotificationProvider.h:
2977
2978 2016-07-01  Alexey Proskuryakov  <ap@apple.com>
2979
2980         Simplify LayoutTestRelay
2981         https://bugs.webkit.org/show_bug.cgi?id=159353
2982
2983         Reviewed by Daniel Bates.
2984
2985         1. Use UDID to pass the device from webkitpy to LayoutTestRelay, searching for it
2986         by name and runtime makes no sense.
2987         2. Removed code to create devices, webkitpy always does this in advance.
2988         3. Don't create copies of testing apps - we can install the same one into
2989         each simulator, now that we don't run multiple tester processes in a single simulator.
2990         4. Pass information on how to find I/O pipes via environment, not via Info.plist.
2991         5. Removed code that kept testing apps alive in the background.
2992         6. Slightly updated coding style in functions that I touched.
2993
2994         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:
2995         Updated for what we acually use at this point.
2996
2997         * LayoutTestRelay/LayoutTestRelay/LTRelayController.h:
2998         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2999         (-[LTRelayController initWithDevice:productDir:appPath:deviceUDID:dumpToolArguments:]):
3000         (-[LTRelayController ipcIdentifier]):
3001         (-[LTRelayController processName]):
3002         (-[LTRelayController didReceiveStdoutData:]):
3003         (-[LTRelayController didCrashWithMessage:]):
3004         (-[LTRelayController installApp]):
3005         (-[LTRelayController _environmentVariables]):
3006         (-[LTRelayController launchApp]):
3007         (-[LTRelayController start]):
3008         (-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]): Deleted.
3009         (-[LTRelayController uniqueAppPath]): Deleted.
3010         (-[LTRelayController uniqueAppURL]): Deleted.
3011         (-[LTRelayController uniqueAppIdentifier]): Deleted.
3012         (-[LTRelayController createUniqueApp]): Deleted.
3013         * LayoutTestRelay/LayoutTestRelay/main.m:
3014         (usage):
3015         (getRequiredStringArgument):
3016         (main):
3017         (getTestingSimDevice): Deleted.
3018         * Scripts/webkitpy/port/driver.py:
3019         (IOSSimulatorDriver.cmd_line):
3020         * WebKitTestRunner/ios/TestControllerIOS.mm:
3021         (WTR::TestController::platformInitialize):
3022         * WebKitTestRunner/ios/mainIOS.mm:
3023         (-[WebKitTestRunnerApp applicationDidEnterBackground:]):
3024         * DumpRenderTree/mac/DumpRenderTree.mm:
3025         (dumpRenderTree):
3026         (-[DumpRenderTree applicationDidEnterBackground:]):
3027
3028 2016-07-01  Konstantin Tokarev  <annulen@yandex.ru>
3029
3030         [cmake] Build TestNetscapePlugin only if NPAPI is enabled.
3031         https://bugs.webkit.org/show_bug.cgi?id=159344
3032
3033         Reviewed by Alex Christensen.
3034
3035         * DumpRenderTree/CMakeLists.txt:
3036
3037 2016-07-01  Youenn Fablet  <youennf@gmail.com>
3038
3039         Add a runtime flag for DOM iterators
3040         https://bugs.webkit.org/show_bug.cgi?id=159300
3041
3042         Reviewed by Alex Christensen.
3043
3044         * DumpRenderTree/mac/DumpRenderTree.mm:
3045         (resetWebPreferencesToConsistentValues):
3046         * DumpRenderTree/win/DumpRenderTree.cpp:
3047         (resetWebPreferencesToConsistentValues):
3048         * Scripts/webkitperl/FeatureList.pm:
3049         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3050         (WTR::InjectedBundle::beginTesting):
3051         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3052         (WTR::TestRunner::setDOMIteratorEnabled):
3053         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3054
3055 2016-06-30  Tina Liu  <iting_liu@apple.com>
3056
3057         Add an API test for WKPageRestoreFromSessionStateWithoutNavigation.
3058         https://bugs.webkit.org/show_bug.cgi?id=159326
3059
3060         Reviewed by Brady Eidson.
3061
3062         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3063         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateWithoutNavigation.cpp: Added.
3064         (TestWebKitAPI::didFinishLoadForFrame):
3065         (TestWebKitAPI::didChangeBackForwardListForPage):
3066         (TestWebKitAPI::setPageLoaderClient):
3067         Set the page loader client and register for didFinishLoadForFrame and
3068         didChangeBackForwardList callbacks.
3069         (TestWebKitAPI::createSessionStateData):
3070         Load a webpage ("simple.html") and return the session state for this page.
3071         (TestWebKitAPI::TEST):
3072         Restore the page session state with that of "simple.html" without navigation.
3073         Verify that the committed URL is NULL since there's no navigation involved.
3074         Verify that the current item in the back forward list, which should be what
3075         we restored from the session state, has the expected URL.
3076
3077 2016-06-29  Filip Pizlo  <fpizlo@apple.com>
3078
3079         Generators violate bytecode liveness validation
3080         https://bugs.webkit.org/show_bug.cgi?id=159279
3081
3082         Reviewed by Yusuke Suzuki.
3083
3084         Add Basic to our test harness.
3085
3086         * Scripts/run-javascriptcore-tests:
3087         (runJSCStressTests):
3088
3089 2016-06-30  Per Arne Vollan  <pvollan@apple.com>
3090
3091         [Win][Debug] Assertion fails in TestWTF.
3092         https://bugs.webkit.org/show_bug.cgi?id=159299
3093
3094         Reviewed by Alex Christensen.
3095
3096         The assert in the & operator in the UniqueRef class fails, because the instance has been moved.
3097         The Windows version of the UNUSED_PARAM macro is getting the address of the parameter, causing
3098         the assertion failure. Since the variable is actually used, there is no need to use the
3099         UNUSED_PARAM macro.
3100
3101         * TestWebKitAPI/Tests/WTF/UniqueRef.cpp:
3102         (TestWebKitAPI::TEST):
3103
3104 2016-06-30  Youenn Fablet  <youennf@gmail.com>
3105
3106         LayoutTests intermittently failing to run due to issues starting Web Platform Test server
3107         https://bugs.webkit.org/show_bug.cgi?id=159166
3108         <rdar://problem/27051759>
3109
3110         Reviewed by Alexey Proskuryakov.
3111
3112         Setting the certificate directory to the copied config.json.
3113
3114         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3115         (WebPlatformTestServer._copy_webkit_test_files):
3116
3117 2016-06-29  Mark Lam  <mark.lam@apple.com>
3118
3119         Add support for collecting cumulative LLINT stats via a JSC_llintStatsFile option.
3120         https://bugs.webkit.org/show_bug.cgi?id=159274
3121
3122         Reviewed by Keith Miller.
3123
3124         * DumpRenderTree/mac/DumpRenderTree.mm:
3125         (DumpRenderTreeMain):
3126
3127 2016-06-29  Alex Christensen  <achristensen@webkit.org>
3128
3129         WKWebView should ask WKNavigationDelegate about bad ssl certificates
3130         https://bugs.webkit.org/show_bug.cgi?id=159176
3131
3132         Reviewed by Sam Weinig.
3133
3134         * MiniBrowser/mac/WK2BrowserWindowController.m:
3135         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
3136         (-[WK2BrowserWindowController webView:didReceiveAuthenticationChallenge:completionHandler:]):
3137         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
3138
3139 2016-06-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3140
3141         [GTK] Add missing install dependency after r202619
3142         https://bugs.webkit.org/show_bug.cgi?id=156716
3143
3144         Unreviewed.
3145
3146         * gtk/install-dependencies: Missed to add the GLES headers that are needed for building mesa on Debian.
3147
3148 2016-06-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3149
3150         [GTK][Wayland] Implement support for running the layout tests under a (virtualized) Wayland environment.
3151         https://bugs.webkit.org/show_bug.cgi?id=156716
3152
3153         Reviewed by Carlos Garcia Campos and Michael Catanzaro.
3154
3155         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Allow to run the layout tests on Wayland by passing --wayland
3156         (parse_args):
3157         * Scripts/webkitpy/port/gtk.py:
3158         (GtkPort.__init__):
3159         (GtkPort._driver_class):
3160         (GtkPort.setup_environ_for_server): Set the softgl renderer (now with EGL support) for the wayland tests.
3161         (GtkPort._search_paths): When running inside the wayland environment, use ${port}-wayland as an additional
3162         platform directory for storing the wayland specific layout test results and expectations for ${port}.
3163         For example, the file LayoutTests/platform/gtk-wayland/TestExpectations will be used as the most specific
3164         test expectations file on the GTK port when running the tests with the --wayland command line switch.
3165         Baseline search path: gtk-wayland -> gtk -> wk2 -> generic.
3166         * Scripts/webkitpy/port/westondriver.py: Run the weston display server inside Xvfb.
3167         (WestonDriver.check_driver):
3168         (WestonDriver.__init__):
3169         (WestonDriver._start):
3170         * Scripts/webkitpy/port/westondriver_unittest.py: Fix unittests for the new Weston inside Xvfb driver.
3171         (WestonXvfbDriverDisplayTest):
3172         (WestonXvfbDriverDisplayTest.__init__):
3173         (WestonXvfbDriverDisplayTest._xvfb_run):
3174         (WestonDriverTest.make_driver):
3175         (WestonDriverTest.test_start):
3176         * gtk/install-dependencies: Add the new dependencies that are required for either building weston,
3177         or to satisfy the pkg-config check of the new added modules in JHBuild.
3178         * gtk/jhbuild.modules: For building weston new enough on Debian Jessie we also need to build wayland
3179         and libinput. Declare a pkg-config entry on all this modules to avoid building them if the ones
3180         provided by the system are already new enough.
3181         Switch the Mesa software rasterizer from a Xlib based GLX renderer to a DRI based EGL/GLX one.
3182         It was the only way to get the software EGL rasterizer working without depending on user drivers.
3183         Due to this the Mesa build now depends on a modern enough libdrm, so we also use JHBuild pkg-config
3184         feature to avoid building libdrm when the one provided by the system is new enough.
3185         * gtk/jhbuildrc:
3186         * gtk/patches/xserver-search-for-DRI-drivers-at-LIBGL_DRIVERS_PATH-environ.patch: Added.
3187         Xorg had no support for searching the DRI drivers on a custom path at runtime.
3188         This patch implements support for that reusing the same variable that we use with Mesa to set the
3189         custom path for the DRI drivers path.
3190
3191 2016-06-29  Alejandro G. Castro  <alex@igalia.com>
3192
3193         [WebRTC][OWR] Bump gst-plugins-openwebrtc jhbuild version to get scream fixes
3194         https://bugs.webkit.org/show_bug.cgi?id=159256
3195
3196         Reviewed by Philippe Normand.
3197
3198         We need the last fixes in the repository to make the scream queue
3199         work with apprtc.
3200
3201         * gtk/jhbuild.modules:
3202
3203 2016-06-28  Commit Queue  <commit-queue@webkit.org>
3204
3205         Unreviewed, rolling out r202580.
3206         https://bugs.webkit.org/show_bug.cgi?id=159245
3207
3208         Caused all WKTR tests to fail on GuardMalloc and Production
3209         only for unknown reasons, investigating offline. (Requested by
3210         brrian on #webkit).
3211
3212         Reverted changeset:
3213
3214         "RunLoop::Timer should use constructor templates instead of
3215         class templates"
3216         https://bugs.webkit.org/show_bug.cgi?id=159153
3217         http://trac.webkit.org/changeset/202580
3218
3219 2016-06-28  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
3220
3221         Use a regex to check if a test step is for JavaScriptCore
3222         https://bugs.webkit.org/show_bug.cgi?id=159224
3223
3224         Reviewed by Geoffrey Garen.
3225
3226         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
3227         (BuildbotCombinedQueueView.prototype.update): Replace array membership test with regex test.
3228         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3229         (BuildbotIteration.prototype._parseData): Replace array membership test with regex test.
3230         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3231         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): Replace array membership test with regex test.
3232
3233 2016-06-28  Michael Saboff  <msaboff@apple.com>
3234
3235         btjs no longer accepts optional frame count argument
3236         https://bugs.webkit.org/show_bug.cgi?id=159235
3237
3238         Reviewed by Saam Barati.
3239
3240         Fix the detection of optional backtrace-depth parameter to use the length
3241         of the command.
3242
3243         * lldb/lldb_webkit.py:
3244         (btjs):
3245
3246 2016-06-28  Jon Lee  <jonlee@apple.com>
3247
3248         Update animometer.plan
3249
3250         Rubber-stamped by Said Abou-Hallawa.
3251
3252         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r202601.
3253
3254 2016-06-28  Filip Pizlo  <fpizlo@apple.com>
3255
3256         Unreviewed, fix JSC tests. Air.js moved, and the harness needs to know.
3257
3258         * Scripts/run-javascriptcore-tests:
3259         (runJSCStressTests):
3260
3261 2016-06-28  Brian Burg  <bburg@apple.com>
3262
3263         RunLoop::Timer should use constructor templates instead of class templates
3264         https://bugs.webkit.org/show_bug.cgi?id=159153
3265
3266         Reviewed by Alex Christensen.
3267
3268         Remove the RunLoop::Timer class template argument, and pass its constructor
3269         a reference to `this` instead of a pointer to `this`.
3270
3271         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3272         (WTR::TestRunner::TestRunner):
3273         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3274         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3275         (TestWebKitAPI::TEST):
3276
3277 2016-06-28  Ryosuke Niwa  <rniwa@webkit.org>
3278
3279         REGRESSION(r201471): FormClient.textFieldDidEndEditing is no longer called when a text field is removed
3280         https://bugs.webkit.org/show_bug.cgi?id=159199
3281
3282         Reviewed by Alexey Proskuryakov.
3283
3284         Added a test case for removing a text field. Also fixed the flakiness and re-enabled it on Mac.
3285
3286         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp:
3287         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing_Bundle.cpp:
3288         * TestWebKitAPI/Tests/WebKit2/input-focus-blur.html: Focus a div upfront to avoid the flakiness from
3289         an input element getting automatically focused on Mac.
3290
3291 2016-06-28  Per Arne Vollan  <pvollan@apple.com>
3292
3293         [Win] Custom elements tests are failing.
3294         https://bugs.webkit.org/show_bug.cgi?id=159139
3295
3296         Reviewed by Alex Christensen.
3297
3298         Enable custom element API when running tests.
3299
3300         * DumpRenderTree/win/DumpRenderTree.cpp:
3301         (resetWebPreferencesToConsistentValues):
3302
3303 2016-06-27  Lucas Forschler  <lforschler@apple.com>
3304
3305         Test commit. Please ignore.
3306
3307 2016-06-27  Michael Catanzaro  <mcatanzaro@igalia.com>
3308
3309         [GTK][EFL] Disable subtle-crypto in FeatureList.pm
3310         https://bugs.webkit.org/show_bug.cgi?id=155073
3311
3312         Reviewed by Daniel Bates.
3313
3314         * Scripts/webkitperl/FeatureList.pm:
3315
3316 2016-06-27  Simon Fraser  <simon.fraser@apple.com>
3317
3318         [iOS] Make DumpRenderTree and WebKitTestRunner in the simulator use render server snapshotting
3319         https://bugs.webkit.org/show_bug.cgi?id=159077
3320
3321         Reviewed by Tim Horton.
3322
3323         Re-enable render server snapshotting for iOS WTR via the change in InjectedBundlePage.cpp.
3324
3325         Fix WebPageProxy::forceRepaint() to correctly wait for the next commit from the web process,
3326         which is necessary for UI-side compositing.
3327
3328         Add some null checks to fix issues when the WKWebView gets resized to be empty, which
3329         seems to happen for some tests that call window.resizeTo().
3330
3331         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3332         (WTR::InjectedBundlePage::dump): Deleted.
3333         * WebKitTestRunner/TestInvocation.cpp:
3334         (WTR::TestInvocation::dumpResults):
3335         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3336         (WTR::createCGContextFromImage):
3337         (WTR::computeMD5HashStringForContext):
3338         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3339         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3340         (WTR::PlatformWebView::windowSnapshotImage):
3341
3342 2016-06-27  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3343
3344         [EFL] Support to build on Debian linux
3345         https://bugs.webkit.org/show_bug.cgi?id=159123
3346
3347         Reviewed by Antonio Gomes.
3348
3349         * efl/install-dependencies: Install libgnutls28-dev.
3350
3351 2016-06-27  Alex Christensen  <achristensen@webkit.org>
3352
3353         Send canAuthenticateAgainstProtectionSpace calls from NetworkProcess directly to UIProcess
3354         https://bugs.webkit.org/show_bug.cgi?id=159071
3355
3356         Reviewed by Brady Eidson.
3357
3358         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3359         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3360         (WTR::TestRunner::setHandlesAuthenticationChallenges):
3361         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
3362         (WTR::TestRunner::setAuthenticationUsername):
3363         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3364         * WebKitTestRunner/TestController.cpp:
3365         (WTR::TestController::TestController):
3366         (WTR::TestController::resetStateToConsistentValues):
3367         (WTR::TestController::didFinishNavigation):
3368         (WTR::TestController::canAuthenticateAgainstProtectionSpace):
3369         (WTR::TestController::didReceiveAuthenticationChallenge):
3370         (WTR::TestController::didCommitNavigation):
3371         * WebKitTestRunner/TestController.h:
3372         (WTR::TestController::setBlockAllPlugins):
3373         (WTR::TestController::setShouldLogHistoryClientCallbacks):
3374         (WTR::TestController::setShouldLogCanAuthenticateAgainstProtectionSpace):
3375         (WTR::TestController::isCurrentInvocation):
3376         * WebKitTestRunner/TestInvocation.cpp:
3377         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3378         Added output so we can see when canAuthenticateAgainstProtectionSpace is called from the test expectations.
3379
3380 2016-06-27  Per Arne Vollan  <pvollan@apple.com>
3381
3382         [Win] The test fast/events/wheel-event-outside-body.html is timing out.
3383         https://bugs.webkit.org/show_bug.cgi?id=159129
3384
3385         Reviewed by Alex Christensen.
3386
3387         Implement the function mouseScrollBy in the Windows event sender.
3388
3389         * DumpRenderTree/win/EventSender.cpp:
3390         (mouseScrollBy):
3391         (mouseScrollByWithWheelAndMomentumPhasesCallback):
3392
3393 2016-06-25  Filip Pizlo  <fpizlo@apple.com>
3394
3395         REGRESSION: Weak symbol warning when linking TestWebKitAPI
3396         https://bugs.webkit.org/show_bug.cgi?id=159104
3397
3398         Reviewed by Dan Bernstein.
3399
3400         This uses a better approach to turn on -fvisility=hidden. All of the other projects set
3401         this flag in xcconfig, using "GCC_SYMBOLS_PRIVATE_EXTERN = YES;".
3402
3403         * TestWebKitAPI/Configurations/TestWTFLibrary.xcconfig: Use GCC_SYMBOLS_PRIVATE_EXTERN here.
3404         * TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig: Use GCC_SYMBOLS_PRIVATE_EXTERN here.
3405         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Revert r202461.
3406
3407 2016-06-25  Per Arne Vollan  <pvollan@apple.com>
3408
3409         [Win] The test fast/events/wheel-event-destroys-frame.html is timing out.
3410         https://bugs.webkit.org/show_bug.cgi?id=159086
3411
3412         Reviewed by Alex Christensen.
3413
3414         Implement required wheel event function in event sender.
3415
3416         * DumpRenderTree/win/EventSender.cpp:
3417         (mouseScrollByWithWheelAndMomentumPhasesCallback):
3418
3419 2016-06-24  Filip Pizlo  <fpizlo@apple.com>
3420
3421         REGRESSION: Weak symbol warning when linking TestWebKitAPI
3422         https://bugs.webkit.org/show_bug.cgi?id=159104
3423
3424         Reviewed by Mark Lam.
3425
3426         The problem is that the tests were not compiled with -fvisibility=hidden like the rest of
3427         WK.
3428
3429         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3430
3431 2016-06-24  David Kilzer  <ddkilzer@apple.com>
3432
3433         parser_unittests.pl should not hardcode list of tests
3434         <https://webkit.org/b/159074>
3435
3436         Reviewed by Daniel Bates.
3437
3438         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
3439         Update to read the list of tests from the 'resources' directory,
3440         and instead map file extensions to subroutine names.  Switch to
3441         use File::Basename::fileparse() to get basename and file
3442         extension for each test.
3443         (readTestFiles): Added.  Reads files from the directory passed
3444         in and ignores: hidden files, anything that isn't a plain file,
3445         and expected test results files.
3446
3447 2016-06-23  Simon Fraser  <simon.fraser@apple.com>
3448
3449         Fix Windows build.
3450
3451         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
3452         * DumpRenderTree/cg/PixelDumpSupportCG.h:
3453
3454 2016-06-23  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3455
3456         [EFL] Change download path of libxslt
3457
3458         Unreviewed EFL build fix.
3459
3460         In Korea current download path can't be accessed. Change it.
3461
3462         * efl/jhbuild.modules:
3463
3464 2016-06-23  Simon Fraser  <simon.fraser@apple.com>
3465
3466         https://bugs.webkit.org/show_bug.cgi?id=159077
3467
3468         Turn off CARenderServer snapshotting in WTR for now, because it doesn't reliably
3469         snapshot the final state of the test in release builds.
3470
3471         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3472         (WTR::InjectedBundlePage::dump):
3473
3474 2016-06-23  Simon Fraser  <simon.fraser@apple.com>
3475
3476         Fix hardware builds, where USE(IOSURFACE) is true by #ifdeffing.
3477
3478         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3479         (createBitmapContextFromWebView):
3480         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3481         (WTR::PlatformWebView::windowSnapshotImage):
3482
3483 2016-06-23  Simon Fraser  <simon.fraser@apple.com>
3484
3485         [iOS] Make DumpRenderTree and WebKitTestRunner in the simulator use render server snapshotting
3486         https://bugs.webkit.org/show_bug.cgi?id=159077
3487
3488         Reviewed by Tim Horton.
3489
3490         Fix both DRT and WTR for iOS to use CARenderServerRenderLayerWithTransform() on the view's layer.
3491         This allows them to capture compositing layers in snapshots, rather than doing a software paint,
3492         thus enabling testing of more things.
3493
3494         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
3495         (createBitmapContext): Moved to this file to share it.
3496         * DumpRenderTree/cg/PixelDumpSupportCG.h:
3497         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3498         (createBitmapContextFromWebView):
3499         (BitmapContext::createFromUIImage): Deleted.
3500         (BitmapContext::pixelData): Deleted.
3501         (BitmapContext::BitmapContext): Deleted.
3502         (computeMD5HashStringForBitmapContext): Deleted.
3503         (dumpBitmap): Deleted.
3504         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig: Don't exclude PixelDumpSupportCG.cpp.
3505         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3506         (createPagedBitmapContext):
3507         (createBitmapContext): Deleted.
3508         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: link with QuartzCore.
3509         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3510         (WTR::InjectedBundlePage::dump): Deleted.
3511         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3512         (WTR::PlatformWebView::windowSnapshotImage):
3513
3514 2016-06-23  Konstantin Tokarev  <annulen@yandex.ru>
3515
3516         [jhbuild] Added libxslt module.
3517         https://bugs.webkit.org/show_bug.cgi?id=159034
3518
3519         Unreviewed, followup for r202373.
3520
3521         * efl/install-dependencies: Removed libxslt
3522         * gtk/install-dependencies: Ditto.
3523
3524 2016-06-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3525
3526         [EFL] Bump gstreamer version from 1.6.3 to 1.8.0
3527         https://bugs.webkit.org/show_bug.cgi?id=159050
3528
3529         Reviewed by Antonio Gomes.
3530
3531         To be sync with GTK port, this patch bumps gstreamer version for EFL port.
3532
3533         * efl/jhbuild.modules:
3534         * efl/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Added.
3535         * efl/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Added.
3536
3537 2016-06-23  Konstantin Tokarev  <annulen@yandex.ru>
3538
3539         [jhbuild] Added libxslt module.
3540         https://bugs.webkit.org/show_bug.cgi?id=159034
3541
3542         Reviewed by Michael Catanzaro.
3543
3544         * efl/jhbuild.modules:
3545         * gtk/jhbuild.modules:
3546
3547 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
3548
3549         [Win] Use Windows api function to find top level parent.
3550         https://bugs.webkit.org/show_bug.cgi?id=159021
3551
3552         Reviewed by Brent Fulgham.
3553
3554         Delete findTopLevelParent function, and use Win32 function GetAncestor instead.
3555
3556         * DumpRenderTree/win/UIDelegate.cpp:
3557         (UIDelegate::runModal):
3558         (findTopLevelParent): Deleted.
3559         * MiniBrowser/win/PrintWebUIDelegate.cpp:
3560         (PrintWebUIDelegate::runModal):
3561         (findTopLevelParent): Deleted.
3562
3563 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
3564
3565         [Win] The test storage/indexeddb/modern/handle-user-delete.html is timing out.
3566         https://bugs.webkit.org/show_bug.cgi?id=158934
3567
3568         Reviewed by Brent Fulgham.
3569
3570         DumpRenderTree should also delete indexed databases when clearAllDatabases() is called.
3571
3572         * DumpRenderTree/win/TestRunnerWin.cpp:
3573         (TestRunner::clearAllDatabases):
3574
3575 2016-06-22  Saam Barati  <sbarati@apple.com>
3576
3577         run-javascriptcore-tests should have some environment variables for commonly used settings
3578         https://bugs.webkit.org/show_bug.cgi?id=159047
3579
3580         Reviewed by Keith Miller.
3581
3582         This patch adds three environment variables that run-javascriptcore-tests
3583         consults:
3584         - RUN_JAVASCRIPTCORE_TESTS_TESTAPI can be set to 'true' or 'false'. It
3585           determines if we should run the api tests or not.
3586         - RUN_JAVASCRIPTCORE_TESTS_BUILD can be set to 'true' or 'false'. It
3587           determines if we will perform a build or not before running the tests.
3588           to set the default should-build setting.
3589         - RUN_JAVASCRIPTCORE_TESTS_EXTRA_TESTS can be set to a directory or to
3590           a yaml file. If set, we will run the extra tests it refers to.
3591
3592         All the values in these environment variables will be overridden if an
3593         option is explicitly passed in. For example, the following will run
3594         the api tests:
3595         `RUN_JAVASCRIPTCORE_TESTS_TESTAPI=false run-javascriptcore-tests --testapi`
3596
3597         * Scripts/run-javascriptcore-tests:
3598
3599 2016-06-22  Saam barati  <sbarati@apple.com>
3600
3601         TypeProfiler and TypeProfilerLog don't play nicely with the concurrent JIT
3602         https://bugs.webkit.org/show_bug.cgi?id=159037
3603         <rdar://problem/26935349>
3604
3605         Reviewed by Benjamin Poulain.
3606
3607         Run typeProfiler.yaml tests under an additional CJIT enabled mode.
3608
3609         * Scripts/run-jsc-stress-tests:
3610
3611 2016-06-22  Aakash Jain  <aakash_jain@apple.com>
3612
3613         Fix style issues in webkitpy
3614         https://bugs.webkit.org/show_bug.cgi?id=159019
3615
3616         Reviewed by Daniel Bates.
3617
3618         Fixed the formatting issues as reported by check-webkit-style in webkitpy.
3619         There is no functionality change.
3620         Only affected file names retained below for brevity.
3621
3622         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
3623         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
3624         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
3625         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
3626         * Scripts/webkitpy/benchmark_runner/utils.py:
3627         * Scripts/webkitpy/common/checkout/changelog.py:
3628         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3629         * Scripts/webkitpy/common/checkout/checkout.py:
3630         * Scripts/webkitpy/common/checkout/checkout_mock.py:
3631         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3632         * Scripts/webkitpy/common/checkout/commitinfo.py:
3633         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
3634         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
3635         * Scripts/webkitpy/common/checkout/scm/scm.py:
3636         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3637         * Scripts/webkitpy/common/config/committers_unittest.py:
3638         * Scripts/webkitpy/common/config/irc.py:
3639         * Scripts/webkitpy/common/config/ports.py:
3640         * Scripts/webkitpy/common/config/ports_unittest.py:
3641         * Scripts/webkitpy/common/config/urls.py:
3642         * Scripts/webkitpy/common/host_mock.py:
3643         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3644         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3645         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3646         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
3647         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3648         * Scripts/webkitpy/common/net/credentials_unittest.py:
3649         * Scripts/webkitpy/common/net/irc/ircproxy_unittest.py:
3650         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
3651         * Scripts/webkitpy/common/net/statusserver.py:
3652         * Scripts/webkitpy/common/system/autoinstall.py:
3653         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
3654         * Scripts/webkitpy/common/system/executive.py:
3655         * Scripts/webkitpy/common/system/executive_mock.py:
3656         * Scripts/webkitpy/common/system/executive_unittest.py:
3657         * Scripts/webkitpy/common/system/filesystem_mock.py:
3658         * Scripts/webkitpy/common/system/filesystem_unittest.py:
3659         * Scripts/webkitpy/common/system/logutils_unittest.py:
3660         * Scripts/webkitpy/common/system/path.py:
3661         * Scripts/webkitpy/common/system/path_unittest.py:
3662         * Scripts/webkitpy/common/system/platforminfo.py:
3663         * Scripts/webkitpy/common/system/user.py:
3664         * Scripts/webkitpy/common/system/user_unittest.py:
3665         * Scripts/webkitpy/common/system/workspace_unittest.py:
3666         * Scripts/webkitpy/common/thread/threadedmessagequeue.py:
3667         * Scripts/webkitpy/common/thread/threadedmessagequeue_unittest.py:
3668         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
3669         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3670         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3671         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3672         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
3673         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
3674         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3675         * Scripts/webkitpy/layout_tests/models/test_failures.py:
3676         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3677         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3678         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
3679         * Scripts/webkitpy/layout_tests/views/printing.py:
3680         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3681         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
3682         * Scripts/webkitpy/port/base_unittest.py:
3683         * Scripts/webkitpy/port/driver.py:
3684         * Scripts/webkitpy/port/driver_unittest.py:
3685         * Scripts/webkitpy/port/factory.py:
3686         * Scripts/webkitpy/port/gtk.py:
3687         * Scripts/webkitpy/port/server_process_unittest.py:
3688         * Scripts/webkitpy/port/test.py:
3689         * Scripts/webkitpy/port/win.py:
3690         * Scripts/webkitpy/style/checker.py:
3691         * Scripts/webkitpy/style/checkers/common_unittest.py:
3692         * Scripts/webkitpy/style/checkers/cpp.py:
3693         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3694         * Scripts/webkitpy/style/checkers/js.py:
3695         * Scripts/webkitpy/style/checkers/jsonchecker.py:
3696         * Scripts/webkitpy/style/checkers/png.py:
3697         * Scripts/webkitpy/style/checkers/text.py:
3698         * Scripts/webkitpy/style/checkers/text_unittest.py:
3699         * Scripts/webkitpy/style/error_handlers.py:
3700         * Scripts/webkitpy/style/filter.py:
3701         * Scripts/webkitpy/style/filter_unittest.py:
3702         * Scripts/webkitpy/style/optparser.py:
3703         * Scripts/webkitpy/style/optparser_unittest.py:
3704         * Scripts/webkitpy/test/main.py:
3705         * Scripts/webkitpy/w3c/test_converter.py:
3706         * Scripts/webkitpy/w3c/test_converter_unittest.py:
3707         * Scripts/webkitpy/w3c/test_importer_unittest.py:
3708         * Scripts/webkitpy/xcode/simulator.py:
3709
3710 2016-06-22  Brady Eidson  <beidson@apple.com>
3711
3712         DatabaseProcess doesn't handle WebProcesses going away uncleanly.
3713         https://bugs.webkit.org/show_bug.cgi?id=158894
3714
3715         Reviewed by Alex Christensen.
3716
3717         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3718         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-2.html:
3719         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-3.html: Added.
3720         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
3721
3722 2016-06-22  Jon Lee  <jonlee@apple.com>
3723
3724         Update animometer.plan
3725         https://bugs.webkit.org/show_bug.cgi?id=159012
3726
3727         Reviewed by Ryosuke Niwa.
3728
3729         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r202318.
3730
3731 2016-06-22  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3732
3733         W3C test importer should generate files to ignore by WebKit SCM
3734         https://bugs.webkit.org/show_bug.cgi?id=142743
3735
3736         Reviewed by Darin Adler.
3737
3738         TestDownloader generates the .gitignore file according submodules git repository information.
3739         TestImporter requests the generation of .gitignore and the main __init__.py according LayoutTests/imported/w3c/resources/TestRepositories options.
3740
3741         * Scripts/webkitpy/w3c/test_downloader.py:
3742         (TestDownloader.generate_gitignore): Generating .gitignore according submodules description.
3743         * Scripts/webkitpy/w3c/test_importer.py:
3744         (TestImporter.process_test_repositories_import_options): Added the generation of .gitignore/__init__.py if the repo has the right option.
3745         (TestImporter):
3746         (TestImporter.write_init_py): Writing not empty __init__.py files.
3747         (TestImporter.import_tests): Using  of write_init_py.
3748         * Scripts/webkitpy/w3c/test_importer_unittest.py:
3749         (TestImporterTest.test_git_ignore_generation): Added .gitignore test.
3750         (TestImporterTest):
3751         (TestImporterTest.test_initpy_generation): Added __init__.py test.
3752
3753 2016-06-21  Sam Weinig  <sam@webkit.org>
3754
3755         WKWebView with no WKNavigationDelegate does not follow universal links
3756         <rdar://problem/24374110>
3757         https://bugs.webkit.org/show_bug.cgi?id=158997
3758
3759         Reviewed by Dan Bernstein.
3760
3761         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3762         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDefaultNavigationDelegate.mm: Added.
3763         Add a new test that shows that we have a default navigation delegate by swizzling
3764         -[NSWorkspace openURL:]. This will only be called if there is a default client.
3765
3766 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
3767
3768         [Win] Implement modal dialog support in MiniBrowser.
3769         https://bugs.webkit.org/show_bug.cgi?id=158976
3770
3771         Reviewed by Brent Fulgham.
3772
3773         * MiniBrowser/win/PrintWebUIDelegate.cpp:
3774         (PrintWebUIDelegate::createWebViewWithRequest):
3775         (getHandleFromWebView):
3776         (PrintWebUIDelegate::webViewClose):
3777         (PrintWebUIDelegate::setFrame):
3778         (PrintWebUIDelegate::webViewFrame):
3779         (PrintWebUIDelegate::canRunModal):
3780         (findTopLevelParent):
3781         (PrintWebUIDelegate::runModal):
3782         (PrintWebUIDelegate::createModalDialog):
3783         * MiniBrowser/win/PrintWebUIDelegate.h:
3784         (PrintWebUIDelegate::webViewClose):
3785         (PrintWebUIDelegate::setFrame):
3786         (PrintWebUIDelegate::webViewFrame):
3787         (PrintWebUIDelegate::canRunModal):
3788         (PrintWebUIDelegate::runModal):
3789
3790 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
3791
3792         window.showModalDialog doesn't work in DumpRenderTree on Windows
3793         https://bugs.webkit.org/show_bug.cgi?id=53675
3794
3795         Reviewed by Brent Fulgham.
3796
3797         Implement modal dialog support in DumpRenderTree.
3798
3799         * DumpRenderTree/win/UIDelegate.cpp:
3800         (UIDelegate::canRunModal):
3801         (getHandleFromWebView):
3802         (UIDelegate::createModalDialog):
3803         (findTopLevelParent):
3804         (UIDelegate::runModal):
3805         (UIDelegate::webViewClose):
3806         * DumpRenderTree/win/UIDelegate.h:
3807
3808 2016-06-21  Aakash Jain  <aakash_jain@apple.com>
3809
3810         Fix formatting issues reported by check-webkit-style
3811         https://bugs.webkit.org/show_bug.cgi?id=159008
3812
3813         Reviewed by Alexey Proskuryakov.
3814
3815         Fixed the formatting issues as reported by check-webkit-style in webkitpy/tool folder.
3816         There is no functionality change.
3817
3818         * Scripts/webkitpy/tool/bot/irc_command.py:
3819         (Restart.execute):
3820         (Rollout):
3821         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
3822         (IRCBotTest.test_exception_during_command):
3823         (IRCBotTest.test_exception_during_command.CommandWithException):
3824         (IRCBotTest.test_exception_during_command.CommandWithException.execute):
3825         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
3826         (test_missing_unit_test_results_path):
3827         (test_layout_test_results):
3828         * Scripts/webkitpy/tool/bot/queueengine.py:
3829         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
3830         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
3831         (AbstractSequencedCommand):
3832         (AbstractSequencedCommand.__init__):
3833         * Scripts/webkitpy/tool/commands/download.py:
3834         (Land):
3835         * Scripts/webkitpy/tool/commands/openbugs.py:
3836         * Scripts/webkitpy/tool/commands/openbugs_unittest.py:
3837         (OpenBugsTest):
3838         * Scripts/webkitpy/tool/commands/queries.py:
3839         (PatchesToCommitQueue):
3840         (PatchesToCommitQueue.__init__):
3841         (PatchesToCommitQueue._needs_commit_queue):
3842         * Scripts/webkitpy/tool/commands/queries_unittest.py:
3843         (PrintExpectationsTest.test_platform):
3844         (PrintBaselinesTest):
3845         (PrintBaselinesTest.setUp):
3846         * Scripts/webkitpy/tool/commands/queues.py:
3847         (AbstractQueue):
3848         (AbstractQueue.__init__):
3849         (AbstractQueue.execute):
3850         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3851         (test_auto_retry):
3852         * Scripts/webkitpy/tool/commands/rebaseline.py:
3853         (AbstractParallelRebaselineCommand._files_to_add):
3854         (AbstractParallelRebaselineCommand):
3855         (AbstractParallelRebaselineCommand._rebaseline):
3856         * Scripts/webkitpy/tool/commands/setupgitclone.py:
3857         (SetupGitClone):
3858         * Scripts/webkitpy/tool/commands/sheriffbot.py:
3859         * Scripts/webkitpy/tool/commands/stepsequence.py:
3860         * Scripts/webkitpy/tool/commands/upload.py:
3861         (PostCommits._comment_text_for_commit):
3862         (PostCommits):
3863         (PostCommits.execute):
3864         (MarkBugFixed):
3865         (MarkBugFixed.__init__):
3866         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3867         (UploadCommandsTest):
3868         (UploadCommandsTest.test_commit_message_for_current_diff):
3869         * Scripts/webkitpy/tool/grammar_unittest.py:
3870         (GrammarTest):
3871         (GrammarTest.test_join_with_separators):
3872         * Scripts/webkitpy/tool/multicommandtool.py:
3873         (HelpCommand.__init__):
3874         (HelpCommand):
3875         (HelpCommand._help_epilog):
3876         (HelpCommand._remove_help_options):
3877         (MultiCommandTool):
3878         (MultiCommandTool.__init__):
3879         (MultiCommandTool.main):
3880         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
3881         (TrivialCommand):
3882         (TrivialCommand.__init__):
3883         (MultiCommandToolTest):
3884         (MultiCommandToolTest._assert_tool_main_outputs):
3885         (MultiCommandToolTest.test_retry):
3886         (test_command_help):
3887         * Scripts/webkitpy/tool/steps/__init__.py:
3888         * Scripts/webkitpy/tool/steps/abstractstep.py:
3889         * Scripts/webkitpy/tool/steps/applypatch.py:
3890         * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
3891         (ApplyPatchWithLocalCommit):
3892         (ApplyPatchWithLocalCommit.options):
3893         * Scripts/webkitpy/tool/steps/build.py:
3894         * Scripts/webkitpy/tool/steps/checkstyle.py:
3895         (CheckStyle):
3896         (CheckStyle.options):
3897         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
3898         * Scripts/webkitpy/tool/steps/closebug.py:
3899         * Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
3900         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
3901         (CloseBugForLandDiffTest):
3902         (CloseBugForLandDiffTest.test_empty_state):
3903         * Scripts/webkitpy/tool/steps/closepatch.py:
3904         * Scripts/webkitpy/tool/steps/commit.py:
3905         (Commit.run):
3906         * Scripts/webkitpy/tool/steps/confirmdiff.py:
3907         * Scripts/webkitpy/tool/steps/editchangelog.py:
3908         * Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
3909         * Scripts/webkitpy/tool/steps/metastep.py:
3910         (MetaStep):
3911         (MetaStep.__init__):
3912         (MetaStep.run):
3913         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
3914         * Scripts/webkitpy/tool/steps/options.py:
3915         (Options):
3916         * Scripts/webkitpy/tool/steps/postdiff.py:
3917         * Scripts/webkitpy/tool/steps/postdiffforcommit.py:
3918         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
3919         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3920         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
3921         (PrepareChangeLogTest):
3922         (PrepareChangeLogTest.test_resolve_existing_entry):
3923         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
3924         * Scripts/webkitpy/tool/steps/promptforbugortitle.py:
3925         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
3926         * Scripts/webkitpy/tool/steps/revertrevision.py:
3927         * Scripts/webkitpy/tool/steps/runtests.py:
3928         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
3929         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3930         (StepsTest):
3931         (StepsTest._step_options):
3932         * Scripts/webkitpy/tool/steps/update.py:
3933         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
3934         (UpdateChangeLogsWithReviewerTest):
3935         (UpdateChangeLogsWithReviewerTest.test_guess_reviewer_from_bug):
3936         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
3937         * Scripts/webkitpy/tool/steps/validatereviewer.py:
3938
3939 2016-06-21  Chris Dumez  <cdumez@apple.com>
3940
3941         Unreviewed, rolling out r202296.
3942
3943         Broke basic browsing in Safari
3944
3945         Reverted changeset:
3946
3947         "WKWebView with no WKNavigationDelegate does not follow
3948         universal links"
3949         https://bugs.webkit.org/show_bug.cgi?id=158997
3950         http://trac.webkit.org/changeset/202296
3951
3952 2016-06-21  Anders Carlsson  <andersca@apple.com>
3953
3954         Fix build.
3955
3956         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3957
3958 2016-06-21  Anders Carlsson  <andersca@apple.com>
3959
3960         Begin moving the Apple Pay code to the open source repository
3961         https://bugs.webkit.org/show_bug.cgi?id=158998
3962
3963         Reviewed by Tim Horton.
3964
3965         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3966         Add ENABLE_APPLE_PAY.
3967
3968 2016-06-21  Said Abou-Hallawa  <sabouhallawa@apple,com>
3969
3970         Add system tracing points for requestAnimationFrame() workflow
3971         https://bugs.webkit.org/show_bug.cgi?id=158723
3972
3973         Reviewed by Simon Fraser.
3974
3975         Add new plist entries to be used by kdebug_trace() viewing tools.
3976
3977         * Tracing/SystemTracePoints.plist:
3978
3979 2016-06-21  Sam Weinig  <sam@webkit.org>
3980
3981         WKWebView with no WKNavigationDelegate does not follow universal links
3982         <rdar://problem/24374110>
3983         https://bugs.webkit.org/show_bug.cgi?id=158997
3984
3985         Reviewed by Dan Bernstein.
3986
3987         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3988         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDefaultNavigationDelegate.mm: Added.
3989         Add a new test that shows that we have a default navigation delegate by swizzling
3990         -[NSWorkspace openURL:]. This will only be called if there is a default client.
3991
3992 2016-06-21  Aakash Jain  <aakash_jain@apple.com>
3993
3994         run-javascriptcore-tests should have flag to skip mozilla tests
3995         https://bugs.webkit.org/show_bug.cgi?id=158963
3996         rdar://problem/25838924
3997
3998         Reviewed by Alexey Proskuryakov.
3999
4000         * Scripts/run-javascriptcore-tests:
4001         (runJSCStressTests): Added flag to skip mozilla tests.
4002
4003 2016-06-20  Commit Queue  <commit-queue@webkit.org>
4004
4005         Unreviewed, rolling out r202136.
4006         https://bugs.webkit.org/show_bug.cgi?id=158932
4007
4008         JSBench wasn't regressed by r202002 and r202111 on iOS after
4009         all (Requested by rniwa_ on #webkit).
4010
4011         Reverted changeset:
4012
4013         "Unreviewed, rolling out r202002 and r202111."
4014         https://bugs.webkit.org/show_bug.cgi?id=158638
4015         http://trac.webkit.org/changeset/202136
4016
4017 2016-06-20  Keith Rollin  <krollin@apple.com>
4018
4019         Remove RefPtr::release() and change calls sites to use WTFMove()
4020         https://bugs.webkit.org/show_bug.cgi?id=158369
4021
4022         Reviewed by Chris Dumez.
4023
4024         RefPtr::release() releases its managed pointer awkwardly. It's more
4025         direct and clearer to use WTFMove to transfer ownership of the managed
4026         pointer.
4027
4028         As part of this cleanup, also change a lot of explicit data types to
4029         'auto'.
4030
4031         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
4032         (createBitmapContextFromWebView):
4033         (createPagedBitmapContext):
4034         * DumpRenderTree/mac/TestRunnerMac.mm:
4035         (TestRunner::setMockGeolocationPosition):
4036         * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp:
4037         (TestWebKitAPI::TEST):
4038         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
4039         (TestWebKitAPI::TEST):
4040
4041 2016-06-20  Tim Horton  <timothy_horton@apple.com>
4042
4043         Add a API test for *DeferringViewInWindowChanges as fixed in r202230
4044         https://bugs.webkit.org/show_bug.cgi?id=158947
4045
4046         Reviewed by Simon Fraser.
4047
4048         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4049         * TestWebKitAPI/Tests/WebKit2/DeferredViewInWindowStateChange.mm: Added.
4050         (TestWebKitAPI::didFinishLoadForFrame):
4051         (TestWebKitAPI::setPageLoaderClient):
4052         (TestWebKitAPI::TEST):
4053         Add a test ensuring that in-window state changes are deferred when using
4054         the SPI for deferring them, as fixed in r202230.
4055
4056 2016-06-20  Fujii Hironori  <Hironori.Fujii@sony.com>
4057
4058         WebKitTestRunner: Missing \n at the line of "#PROCESS UNRESPONSIVE"
4059         https://bugs.webkit.org/show_bug.cgi?id=158931
4060
4061         Reviewed by Alexey Proskuryakov.
4062
4063         * WebKitTestRunner/TestInvocation.cpp:
4064         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Appended missing \n at the end of line.
4065
4066 2016-06-17  Alexey Proskuryakov  <ap@apple.com>
4067
4068         Add test expectations for macOS Sierra
4069         https://bugs.webkit.org/show_bug.cgi?id=158903
4070
4071         Reviewed by Alex Christensen.
4072
4073         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png: Added.
4074         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png: Added.
4075         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
4076         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
4077         Added dashboard support.
4078
4079         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
4080         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
4081         Trigger the right build queues on check-in.
4082
4083         * Scripts/webkitpy/common/system/platforminfo.py:
4084         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
4085         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
4086         * Scripts/webkitpy/port/mac.py:
4087         * Scripts/webkitpy/port/mac_unittest.py:
4088         * TestResultServer/static-dashboards/flakiness_dashboard.js:
4089         Added cases for Sierra, and updated tests for new baseline search paths.
4090
4091 2016-06-19  Alexey Proskuryakov  <ap@apple.com>
4092
4093         Another buid fix for master.cfg.
4094
4095         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4096         (CompileWebKit.start):
4097
4098 2016-06-19  Alexey Proskuryakov  <ap@apple.com>
4099
4100         Another buid fix for master.cfg.
4101
4102         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4103         (CompileWebKit.start):
4104
4105 2016-06-19  Lucas Forschler  <lforschler@apple.com>
4106
4107         Fix master.cfg
4108
4109         Unreviewed build fix.
4110
4111         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4112         (CompileWebKit.start):
4113
4114 2016-06-19  Lucas Forschler  <lforschler@apple.com>
4115
4116         Test another commit.
4117
4118         Unreviewed.
4119
4120 2016-06-19  Lucas Forschler  <lforschler@apple.com>
4121
4122         Testing fix for trac-mirror.
4123
4124         Unreviewed.
4125
4126 2016-06-19  Lucas Forschler  <lforschler@apple.com>
4127
4128         Test a commit against the SVN 1.9 server upgrade.
4129
4130         Unreviewed.
4131
4132 2016-06-17  Daniel Bates  <dabates@apple.com>
4133
4134         Unreviewed, rolling out r202186.
4135
4136         Broke the Apple Windows, Apple Yosemite, GTK, and WinCairo
4137         builds.
4138
4139         Reverted changeset:
4140
4141         "File scheme should not allow access of a resource on a
4142         different volume."
4143         https://bugs.webkit.org/show_bug.cgi?id=158552
4144         http://trac.webkit.org/changeset/202186
4145
4146 2016-06-17  Pranjal Jumde  <pjumde@apple.com>
4147
4148         File scheme should not allow access of a resource on a different volume.
4149         https://bugs.webkit.org/show_bug.cgi?id=158552
4150         <rdar://problem/15307582>
4151
4152         Reviewed by Brent Fulgham.
4153
4154         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4155         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
4156         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
4157         (-[CrossPartitionFileSchemeAccessNavigationDelegate webView:didFinishNavigation:]):
4158         When the main page load is complete fetch the contents of the document to check if iframe was loaded
4159         (createPartition):
4160         Create a disk image and load the contents of the file.
4161         (cleanUp):
4162         (TestWebKitAPI::TEST):
4163
4164 2016-06-17  Enrique Ocaña González  <eocanha@igalia.com>
4165
4166         Unreviewed. Added myself to the list of committers.
4167
4168         * Scripts/webkitpy/common/config/contributors.json:
4169
4170 2016-06-16  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
4171
4172         [EFL][GTK] LayoutTest doesn't run on Ubuntu 16.04
4173         https://bugs.webkit.org/show_bug.cgi?id=158141
4174
4175         Reviewed by Michael Catanzaro.
4176
4177         * Scripts/webkitpy/port/base.py: Detect php version in system, then use it.
4178         (Port._is_debian_php_version_7):
4179         (Port._debian_php_version):
4180         (Port._apache_config_file_name_for_platform):
4181         * efl/install-dependencies:
4182         * gtk/install-dependencies:
4183
4184 2016-06-16  Filip Pizlo  <fpizlo@apple.com>
4185
4186         Baseline JIT should be concurrent
4187         https://bugs.webkit.org/show_bug.cgi?id=158755
4188
4189         Reviewed by Geoffrey Garen.
4190
4191         Need to disable concurrent JIT when running profiler tests. We should have been doing this
4192         all along.
4193
4194         * Scripts/run-jsc-stress-tests:
4195
4196 2016-06-16  Per Arne Vollan  <pvollan@apple.com>
4197
4198         [Win] Accessibility implementation unable to recurse through document (sometimes) to find named elements
4199         https://bugs.webkit.org/show_bug.cgi?id=140798
4200
4201         Reviewed by Brent Fulgham.
4202
4203         Make sure layout is up-to-date before trying to find named elements.
4204
4205         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
4206         (AccessibilityController::rootElement):
4207
4208 2016-06-16  Chris Dumez  <cdumez@apple.com>
4209
4210         Unreviewed, rolling out r202002 and r202111.
4211
4212         Ryosuke says this was a JSBench regression on iOS
4213
4214         Reverted changesets:
4215
4216         "Make HashMap and HashSet work with Refs"
4217         https://bugs.webkit.org/show_bug.cgi?id=158638
4218         http://trac.webkit.org/changeset/202002
4219
4220         "Improve HashMap and HashSet support for Ref"
4221         https://bugs.webkit.org/show_bug.cgi?id=158789
4222         http://trac.webkit.org/changeset/202111
4223
4224 2016-06-15  Simon Fraser  <simon.fraser@apple.com>
4225
4226         [iOS WK2] On iPad, indirect focussing of a text field doesn't always scroll to the correct location
4227         https://bugs.webkit.org/show_bug.cgi?id=158828
4228
4229         Reviewed by Enrica Casucci.
4230
4231         Expose "forceIPadStyleZoomOnInputFocus" on UIScriptController, which allows iPad-style
4232         zooming behavior on <input> focus in the iPhone simulator, which is used for testing.
4233
4234         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
4235         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
4236         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus):
4237         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus):
4238         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
4239         * WebKitTestRunner/ios/TestControllerIOS.mm:
4240         (WTR::TestController::platformResetStateToConsistentValues):
4241         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4242         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus):
4243         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus):
4244
4245 2016-06-15  Sam Weinig  <sam@webkit.org>
4246
4247         Forward/Back keyboard shortcuts need to flip for RTL
4248         https://bugs.webkit.org/show_bug.cgi?id=158823
4249         <rdar://problem/25975359>
4250
4251         Reviewed by Darin Adler.
4252
4253         Add tests for flipping the behavior of command-left and command-right
4254         under RTL mode.
4255
4256         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4257         * TestWebKitAPI/Tests/WebKit2Cocoa/CommandBackForward.mm: Added.
4258         (-[CommandBackForwardOffscreenWindow isKeyWindow]):
4259         (-[CommandBackForwardOffscreenWindow isVisible]):
4260         (simulateCommandArrow):
4261         (WebKit2_CommandBackForwardTest::SetUp):
4262         (WebKit2_CommandBackForwardTestWKView::didFinishLoadForFrame):
4263         (WebKit2_CommandBackForwardTestWKView::SetUp):
4264         (WebKit2_CommandBackForwardTestWKView::loadFiles):
4265         (-[CommandBackForwardNavigationDelegate webView:didFinishNavigation:]):
4266         (WebKit2_CommandBackForwardTestWKWebView::SetUp):
4267         (WebKit2_CommandBackForwardTestWKWebView::loadFiles):
4268
4269 2016-06-15  Tim Horton  <timothy_horton@apple.com>
4270
4271         Expose _shouldExpandContentToViewHeightForAutoLayout SPI on WKWebView
4272         https://bugs.webkit.org/show_bug.cgi?id=158824
4273         <rdar://problem/23713857>
4274
4275         Reviewed by Simon Fraser.
4276
4277         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
4278         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:]):
4279         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]):
4280         (-[AutoLayoutWKWebView layoutAtMinimumWidth:andExpectContentSizeChange:resettingWidth:]):
4281         (TEST):
4282         Add a test for _shouldExpandContentToViewHeightForAutoLayout.
4283
4284 2016-06-13  Simon Fraser  <simon.fraser@apple.com>
4285
4286         [iOS WK2] Make it possible to test the Next/Previous buttons in the keyboard accessory bar
4287         https://bugs.webkit.org/show_bug.cgi?id=158714
4288
4289         Reviewed by Enrica Casucci.
4290
4291         Add UIScriptController.keyboardAccessoryBar{Next,Previous} and hook it up to the WKContentView
4292         method that gets called from UIKit.
4293
4294         Add a test that exercises it.
4295
4296         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
4297         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
4298         (WTR::UIScriptController::keyboardAccessoryBarNext):
4299         (WTR::UIScriptController::keyboardAccessoryBarPrevious):
4300         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
4301         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4302         (WTR::UIScriptController::keyboardAccessoryBarNext):
4303         (WTR::UIScriptController::keyboardAccessoryBarPrevious):
4304
4305 2016-06-15  Sam Weinig  <sam@webkit.org>
4306
4307         Improve HashMap and HashSet support for Ref
4308         https://bugs.webkit.org/show_bug.cgi?id=158789
4309
4310         Reviewed by Chris Dumez.