3245f0d1d0c1f2a4ccf786fd908f130635db930c
[WebKit-https.git] / Tools / ChangeLog
1 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
2
3         [WebEditingTester] ARC-ify WebEditingTester
4         https://bugs.webkit.org/show_bug.cgi?id=141827
5
6         Reviewed by Sam Weinig.
7
8         * WebEditingTester/AppDelegate.m:
9         (-[WebEditingAppDelegate showOperations:]):
10         * WebEditingTester/EditingOperations.m:
11         (editingOperations):
12         * WebEditingTester/WK1WebDocumentController.m:
13         (-[WK1WebDocumentController dealloc]): Deleted.
14         * WebEditingTester/WK2WebDocumentController.m:
15         (-[WK2WebDocumentController dealloc]): Deleted.
16         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
17         Turn on ARC and remove a few retain/release/autorelease calls.
18         We don't need to implement dealloc in either document controller
19         because WebView and WKWebView's UIDelegate property does not hold a
20         strong reference.
21
22 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
23
24         [WebEditingTester] Factor out list of editing operations
25         https://bugs.webkit.org/show_bug.cgi?id=141826
26
27         Reviewed by Sam Weinig.
28
29         * WebEditingTester/AppDelegate.m:
30         (-[WebEditingAppDelegate showOperations:]):
31         * WebEditingTester/EditingOperations.h: Added.
32         * WebEditingTester/EditingOperations.m: Added.
33         (editingOperations):
34         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
35         Move EditingOperations array to its own file, and make it an NSArray
36         instead of a C array. Adjust accordingly in showOperations:.
37
38 2015-02-20  Michael Saboff  <msaboff@apple.com>
39
40         DFG JIT needs to check for stack overflow at the start of Program and Eval execution
41         https://bugs.webkit.org/show_bug.cgi?id=141676
42
43         Reviewed by Filip Pizlo.
44
45         Set the newly added --maximumEvalCacheableSourceLength option for eager test runs.  This is needed
46         to allow the eval out of stack tests to tier up.  Without this option, we don't cache the likely
47         large string expression that we want to eval.
48
49         * Scripts/run-jsc-stress-tests:
50
51 2015-02-19  Daniel Bates  <dabates@apple.com>
52
53         REGRESSION (r180239): run-webkit-test fails to boot simulator device that was booted by previous test run
54         https://bugs.webkit.org/show_bug.cgi?id=141815
55         <rdar://problem/19893933>
56
57         Reviewed by Simon Fraser.
58
59         Fixes an issue where run-webkit-tests would fail to boot the WebKit Tester simulator device if it
60         was booted by iOS Simulator in a previous run of run-webkit-test.
61
62         * Scripts/webkitpy/port/ios.py:
63         (IOSSimulatorPort.check_sys_deps): Added logic moved from IOSSimulatorPort.setup_test_run().
64         (IOSSimulatorPort.setup_test_run): Moved logic to quit the iOS Simulator app and wait for the
65         testing device to be in the shutdown state from here to IOSSimulatorPort.check_sys_deps().
66
67 2015-02-19  David Kilzer  <ddkilzer@apple.com>
68
69         check-webkit-style: do not warn about missing primary header for *SoftLink.cpp files
70         <http://webkit.org/b/141799>
71
72         Reviewed by Alex Christensen.
73
74         * Scripts/webkitpy/style/checkers/cpp.py:
75         (_IncludeState.check_next_include_order): Don't emit a warning
76         if the primary header exists and the source file name ends with
77         "SoftLink.cpp".  Add 'filename' argument to method.
78         (check_include_line): Pass in 'filename'.
79
80         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
81         (OrderOfIncludesTest.test_check_next_include_order__no_config):
82         (OrderOfIncludesTest.test_check_next_include_order__no_self):
83         (OrderOfIncludesTest.test_check_next_include_order__likely_then_config):
84         (OrderOfIncludesTest.test_check_next_include_order__other_then_config):
85         (OrderOfIncludesTest.test_check_next_include_order__config_then_other_then_likely):
86         - Add test filename arguments for calls to
87           check_next_include_order().
88         (OrderOfIncludesTest.test_primary_header): Add test for a file
89         name ending in "SoftLink.cpp".
90
91 2015-02-18  Enrica Casucci  <enrica@apple.com>
92
93         Add new tool to test editable Webviews.
94         https://bugs.webkit.org/show_bug.cgi?id=141772
95
96         Reviewed by Tim Horton.
97
98         Adding WebEditingTester, a Cocoa application to
99         test WK1 and Wk2 views in editable mode.
100
101         * WebEditingTester: Added.
102         * WebEditingTester/AppDelegate.h: Added.
103         * WebEditingTester/AppDelegate.m: Added.
104         (-[WebEditingAppDelegate init]):
105         (defaultConfiguration):
106         (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
107         (-[WebEditingAppDelegate applicationWillTerminate:]):
108         (-[WebEditingAppDelegate newEditor:]):
109         (-[WebEditingAppDelegate showOperations:]):
110         (-[WebEditingAppDelegate useWebKit2ByDefault]):
111         (-[WebEditingAppDelegate toggleUseWK2ByDefault:]):
112         (-[WebEditingAppDelegate validateMenuItem:]):
113         * WebEditingTester/Info.plist: Added.
114         * WebEditingTester/MainMenu.xib: Added.
115         * WebEditingTester/WK1WebDocumentController.h: Added.
116         * WebEditingTester/WK1WebDocumentController.m: Added.
117         (-[WK1WebDocumentController awakeFromNib]):
118         (-[WK1WebDocumentController loadContent]):
119         (-[WK1WebDocumentController dealloc]):
120         (-[WK1WebDocumentController pasteAsMarkup:]):
121         * WebEditingTester/WK2WebDocumentController.h: Added.
122         * WebEditingTester/WK2WebDocumentController.m: Added.
123         (-[WK2WebDocumentController initWithConfiguration:]):
124         (-[WK2WebDocumentController pasteAsMarkup:]):
125         (-[WK2WebDocumentController awakeFromNib]):
126         (-[WK2WebDocumentController dealloc]):
127         (-[WK2WebDocumentController loadContent]):
128         * WebEditingTester/WebDocument.xib: Added.
129         * WebEditingTester/WebDocumentController.h: Added.
130         * WebEditingTester/WebDocumentController.m: Added.
131         (-[WebDocumentController initWithWindow:]):
132         (-[WebDocumentController windowDidLoad]):
133         (-[WebDocumentController defaultEditingSource]):
134         (-[WebDocumentController applicationTerminating]):
135         (-[WebDocumentController loadContent]):
136         * WebEditingTester/WebEditingTester.xcodeproj: Added.
137         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj: Added.
138         * WebEditingTester/main.m: Added.
139         (main):
140
141 2015-02-18  Csaba Osztrogonác  <ossy@webkit.org>
142
143         Run JSC tests on ARM EFL bots
144         https://bugs.webkit.org/show_bug.cgi?id=141165
145
146         Reviewed by Alexey Proskuryakov.
147
148         * BuildSlaveSupport/build.webkit.org-config/config.json:
149         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
150         (RunJavaScriptCoreTests.countFailures):
151         (RunRemoteJavaScriptCoreTests):
152         (RunRemoteJavaScriptCoreTests.start):
153         (BuildAndRemoteJSCTestsFactory):
154         (BuildAndRemoteJSCTestsFactory.__init__):
155
156 2015-02-18  Alexey Proskuryakov  <ap@apple.com>
157
158         Streamline unexported function build fixes
159         https://bugs.webkit.org/show_bug.cgi?id=141761
160
161         Reviewed by Alex Christensen.
162
163         * Scripts/check-for-weak-vtables-and-externals: (readXcode5SymbolsToIgnore): Deleted.
164         We don't need to ignore symbols that are not exported due to the .unexp file.
165
166 2015-02-18  Timothy Horton  <timothy_horton@apple.com>
167
168         Remove more references to WebCore.exp.in
169         https://bugs.webkit.org/show_bug.cgi?id=141747
170
171         Reviewed by Alexey Proskuryakov.
172
173         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
174         (ShouldBuildTest):
175
176 2015-02-17  Myles C. Maxfield  <mmaxfield@apple.com>
177
178         Windows test results should not fall back to mac-mountainlion after r180176
179         https://bugs.webkit.org/show_bug.cgi?id=141719
180
181         Reviewed by Brent Fulgham.
182
183         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
184         (_should_file_trigger_build):
185         * Scripts/webkitpy/port/win.py:
186         (WinPort.default_baseline_search_path):
187         * Scripts/webkitpy/port/win_unittest.py:
188         (WinPortTest.test_baseline_search_path):
189
190 2015-02-17  Daniel Bates  <dabates@apple.com>
191
192         [iOS] run-webkit-tests should check that simctl can boot and shutdown simulator device before running tests
193         https://bugs.webkit.org/show_bug.cgi?id=141718
194
195         Reviewed by Alex Christensen.
196
197         We should only run layout tests if simctl can successfully boot and shutdown the testing device.
198
199         * Scripts/webkitpy/port/ios.py:
200         (IOSSimulatorPort.check_sys_deps): Modified to call Simulator.check_simulator_device_and_erase_if_needed().
201         Log a error and return False if we are unable to boot the simulator device so that the caller can take
202         appropriate action, say exit(3) before running any layout tests.
203         * Scripts/webkitpy/xcode/simulator.py:
204         (Simulator._boot_and_shutdown_simulator_device): Added. Boot and then shut down the simulator device
205         with the specified UDID.
206         (Simulator.check_simulator_device_and_erase_if_needed): Added. Checks that simulator device
207         with the specified UDID can successfully boot and shut down. We make at most two attempts to
208         boot and shut down the device, erasing the device between tries so as to restore the device
209         to a known good state.
210
211 2015-02-17  Daniel Bates  <dabates@apple.com>
212
213         run_webkit_tests.py should not know about iOS Simulator details
214         https://bugs.webkit.org/show_bug.cgi?id=141711
215
216         Reviewed by Alex Christensen.
217
218         Run_webkit_tests.py should only parse the iOS-specific command
219         line options --runtime and --device-type. Let the port-specific
220         logic in ios.py validate the parsed options and instantiate
221         internal data structures.
222
223         Currently run_webkit_tests.py parses the iOS-specific command
224         line options --runtime and --device-type, validates them, and
225         instantiates internal data structures from the parsed strings.
226         Instead the validation logic and instantiation of internal
227         data structures should be handled by the iOS port object.
228
229         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
230         (_set_up_derived_options): Remove logic to validate --runtime and --device-type
231         and instantiate internal data structures for them.
232         * Scripts/webkitpy/port/driver.py:
233         (IOSSimulatorDriver.cmd_line): Modified to reference IOSSimulatorPort.simulator_runtime
234         and IOSSimulatorPort.simulator_device_type for the iOS Simulator runtime and device type,
235         respectively.
236         * Scripts/webkitpy/port/ios.py: Sort the list of imports.
237         (IOSSimulatorPort.simulator_runtime): Added. Instantiates a Runtime
238         object from --runtime, if specified. Otherwise, instantiates a Runtime
239         object for the latest installed iphonesimulator SDK version.
240         (IOSSimulatorPort.simulator_device_type): Added. Instantiates a DeviceType
241         object from --device-type, if specified. Otherwise, instantiates
242         a DeviceType object for a iPhone 5 or iPhone 5s when on a 32-bit and 64-bit
243         machine, respectively.
244         (IOSSimulatorPort.check_sys_deps): Added. Validate if the chosen iOS simulator
245         runtime is available to use.
246         (IOSSimulatorPort.testing_device): Modified to make use of properties simulator_device_type
247         and simulator_runtime for the iOS Simulator device type and runtime, respectively.
248         * Scripts/webkitpy/xcode/simulator.py:
249         (Runtime.from_version_string): Added. Turns around and calls Runtime.from_identifier()
250         with a runtime identifier for the specified iOS version.
251
252 2015-02-17  Dana Burkart  <dburkart@apple.com>
253
254         ASan does not like JSC::MachineThreads::tryCopyOtherThreadStack
255         https://bugs.webkit.org/show_bug.cgi?id=141672
256
257         Reviewed by David Kilzer.
258
259         * asan/webkit-asan-ignore.txt:
260
261 2015-02-17  Alex Christensen  <achristensen@webkit.org>
262
263         Remove WebCore.exp.in and clean up.
264         https://bugs.webkit.org/show_bug.cgi?id=141491
265
266         Reviewed by Andreas Kling.
267
268         * Scripts/sort-export-file: Removed.
269         * Scripts/webkitpy/style/checker.py:
270         (_all_categories):
271         (FileType):
272         (CheckerDispatcher._file_type):
273         (CheckerDispatcher._create_checker):
274         Don't check if the export files are sorted.
275         * Scripts/webkitpy/style/checkers/exportfile.py: Removed.
276         * Scripts/webkitpy/style/checkers/exportfile_unittest.py: Removed.
277
278 2015-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
279
280         Unreviewed. Fix GTK+ make distcheck.
281
282         Do not exclude bmalloc directory from the tarball.
283
284         * gtk/manifest.txt.in:
285
286 2015-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
287
288         Unreviewed. Fix /webkit2/WebKitDOMNode/dom-cache after r180214.
289
290         I forgot to add the return of a bool function.
291
292         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
293         (WebKitDOMNodeTest::testDOMCache):
294
295 2015-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
296
297         [GTK] GObject DOM bindings object are cached forever
298         https://bugs.webkit.org/show_bug.cgi?id=141558
299
300         Reviewed by Sergio Villar Senin.
301
302         Add checks for all DOM objects to ensure they are not leaked. Also
303         add a dedicated test for the DOM Object Cache.
304
305         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
306         (WebKitDOMNodeFilterTest::testTreeWalker):
307         (WebKitDOMNodeFilterTest::testNodeIterator):
308         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
309         (WebKitDOMNodeTest::testHierarchyNavigation):
310         (WebKitDOMNodeTest::testInsertion):
311         (WebKitDOMNodeTest::testTagNames):
312         (WebKitDOMNodeTest::testDOMCache):
313         (registerTests):
314         * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:
315         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
316         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
317         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
318         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
319         (testWebKitDOMObjectCache):
320         (beforeAll):
321         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
322         (documentLoadedCallback):
323
324 2015-02-16  Carlos Garcia Campos  <cgarcia@igalia.com>
325
326         [GTK] WebKitFrame objects are never released
327         https://bugs.webkit.org/show_bug.cgi?id=141641
328
329         Reviewed by Martin Robinson.
330
331         Add a way to check GObjects leaks for WebProcess tests and check
332         WebKitFrame objects are not leaked.
333
334         * TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp:
335         (WebKitFrameTest::testMainFrame):
336         (WebKitFrameTest::testURI):
337         (WebKitFrameTest::testJavaScriptContext):
338         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
339         (WebProcessTest::assertObjectIsDeletedWhenTestFinishes):
340         (runTest):
341         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
342
343 2015-02-16  Tim Horton  <timothy_horton@apple.com>
344
345         Fix the MiniBrowser build with newer clang
346
347         * MiniBrowser/mac/SettingsController.m:
348         (-[SettingsController _toggleBooleanDefault:]):
349         * MiniBrowser/mac/WK1BrowserWindowController.m:
350         (-[WK1BrowserWindowController windowWillClose:]):
351         * MiniBrowser/mac/WK2BrowserWindowController.m:
352         (-[WK2BrowserWindowController windowWillClose:]):
353         NSApp is id and clang gets confused about which -delegate we're talking about.
354
355 2015-02-16  Antti Koivisto  <antti@apple.com>
356
357         Develop/Disable Caches does not properly disable disk cache
358         https://bugs.webkit.org/show_bug.cgi?id=141636
359
360         Reviewed by Anders Carlsson.
361
362         Make testRunner.setCacheModel() use the WKContext interface so the model gets passed to
363         the network process too.
364
365         This makes setCacheModel asynchronous but there don't seem to be any tests that expect otherwise.
366
367         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
368         (WTR::InjectedBundle::beginTesting):
369         (WTR::InjectedBundle::setCacheModel):
370         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
371         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
372
373             Forward to TestController.
374
375         (WTR::TestRunner::setCacheModel):
376         * WebKitTestRunner/TestInvocation.cpp:
377         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
378
379 2015-02-16  Andrzej Badowski  <a.badowski@samsung.com>
380
381         Unreviewed. Add myself as a committer.
382
383         * Scripts/webkitpy/common/config/contributors.json:
384
385 2015-02-15  David Kilzer  <ddkilzer@apple.com>
386
387         REGRESSION (r180082): WebCore Debug builds fail on Mavericks due to weak export symbols
388         <http://webkit.org/b/141607>
389
390         * Scripts/check-for-weak-vtables-and-externals: Ignore weak
391         externals in Source/WebCore/Configurations/WebCore.unexp when
392         building with Xcode 5.x.
393         (readXcode5SymbolsToIgnore): Add.
394
395 2015-02-15  KwangHyuk Kim  <hyuki.kim@samsung.com>
396
397         [EFL] fix Evas GL engine error.
398         https://bugs.webkit.org/show_bug.cgi?id=141621
399
400         Reviewed by Gyuyoung Kim.
401
402         As new elm engine api was added from efl 1.10, replace elm_config_preferred_engine_set with elm_config_accel_preference_set.
403
404         * MiniBrowser/efl/main.c:
405         (elm_main):
406
407 2015-02-14  Csaba Osztrogonác  <ossy@webkit.org>
408
409         [buildbot] Enable run-api-tests on release Mac bots
410         https://bugs.webkit.org/show_bug.cgi?id=141518
411
412         Reviewed by Darin Adler.
413
414         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
415         (RunUnitTests):
416         (BuildFactory.__init__):
417         (TestFactory.__init__):
418         (BuildAndTestFactory.__init__):
419         (RunUnitTests.start): Deleted.
420         (unitTestsSupported): Deleted.
421
422 2015-02-13  Anders Carlsson  <andersca@apple.com>
423
424         Add a move constructor and move assignment operator to Deque
425         https://bugs.webkit.org/show_bug.cgi?id=141571
426
427         Reviewed by Andreas Kling.
428
429         * TestWebKitAPI/Tests/WTF/Deque.cpp:
430         (TestWebKitAPI::TEST):
431
432 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
433
434         run-jsc-stress-tests --remote should skip profiler tests
435         https://bugs.webkit.org/show_bug.cgi?id=141470
436
437         Reviewed by Filip Pizlo.
438
439         * Scripts/run-jsc-stress-tests:
440
441 2015-02-13  Anders Carlsson  <andersca@apple.com>
442
443         Add an initializer list constructor to Deque
444         https://bugs.webkit.org/show_bug.cgi?id=141565
445
446         Reviewed by Andreas Kling.
447
448         * TestWebKitAPI/Tests/WTF/Deque.cpp:
449         (TestWebKitAPI::TEST):
450
451 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
452
453         [buildbot] Remove buildJSCTool cruft from master.cfg
454         https://bugs.webkit.org/show_bug.cgi?id=141513
455
456         Reviewed by Alexey Proskuryakov.
457
458         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
459         (RunJavaScriptCoreTests):
460         (RunJavaScriptCoreTests.start):
461         (RunWebKitTests):
462         (RunWebKitTests.start):
463         (TestFactory.__init__):
464         (TestLeaksFactory.__init__):
465         (RunJavaScriptCoreTests.__init__): Deleted.
466         (RunWebKitTests.__init__): Deleted.
467
468 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
469
470         Unreviewed, remove empty directories.
471
472         * DumpRenderTree/gtk: Removed.
473         * DumpRenderTree/gtk/fonts: Removed.
474         * DumpRenderTree/unix: Removed.
475         * DumpRenderTree/unix/TestNetscapePlugin: Removed.
476         * GtkLauncher: Removed.
477         * TestWebKitAPI/Tests/WebKitGtk: Removed.
478         * TestWebKitAPI/Tests/WebKitGtk/resources: Removed.
479         * WebKitTestRunner/WebKitTestRunnerAppTests: Removed.
480         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj: Removed.
481
482 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
483
484         Remove Windows cruft from Tools/Scripts/build-webkittestrunner
485         https://bugs.webkit.org/show_bug.cgi?id=141519
486
487         Reviewed by Alexey Proskuryakov.
488
489         * Scripts/build-webkittestrunner:
490
491 2015-02-12  Alex Christensen  <achristensen@webkit.org>
492
493         Removed empty directory.
494
495         * WinCELauncher: Removed.
496
497 2015-02-12  Csaba Osztrogonác  <ossy@webkit.org>
498
499         run-jsc-stress-tests --remote should be able add the necessary libraries to the bundle on Linux
500         https://bugs.webkit.org/show_bug.cgi?id=141202
501
502         Reviewed by Darin Adler.
503
504         * Scripts/run-jsc-stress-tests:
505
506 2015-02-12  Brent Fulgham  <bfulgham@apple.com>
507
508         [Win] Test bot infrastructure should not try to find/use old Safari DLLs
509         https://bugs.webkit.org/show_bug.cgi?id=141517
510
511         Reviewed by Anders Carlsson.
512
513         We do not need to locate or use the DLL's that came with Safari, so stop
514         failing when we cannot find them. Also remove some old Qt cruft from this
515         script.
516
517         * BuildSlaveSupport/built-product-archive:
518         (archiveBuiltProduct): 
519         (extractBuiltProduct):
520
521 2015-02-11  Brent Fulgham  <bfulgham@apple.com>
522
523         [Win] [64-bit] Work around MSVC2013 Runtime Bug
524         https://bugs.webkit.org/show_bug.cgi?id=141498
525         <rdar://problem/19803642>
526
527         Reviewed by Anders Carlsson.
528
529         Disable FMA3 instruction use in the MSVC math library to
530         work around a VS2013 runtime crash. We can remove this
531         workaround when we switch to VS2015.
532
533         * DumpRenderTree/cg/ImageDiffCG.cpp: Call _set_FMA3_enable(0) to
534         disable FMA3 support.
535         * DumpRenderTree/win/DumpRenderTree.cpp: Ditto.
536         * DumpRenderTree/win/ImageDiffCairo.cpp: Ditto.
537         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
538         * Scripts/webkitperl/httpd.pm: Ditto.
539         * TestWebKitAPI/win/main.cpp: Ditto.
540         * WinLauncher/Common.cpp: Ditto.
541         * win/DLLLauncher/DLLLauncherMain.cpp: Ditto.
542
543 2015-02-12  Csaba Osztrogonác  <ossy@webkit.org>
544
545         run-jsc-stress-tests should accept remote host config from JSON file
546         https://bugs.webkit.org/show_bug.cgi?id=141509
547
548         Reviewed by Michael Saboff.
549
550         * Scripts/run-javascriptcore-tests:
551         (runJSCStressTests):
552         * Scripts/run-jsc-stress-tests:
553
554 2015-02-12  Carlos Garcia Campos  <cgarcia@igalia.com>
555
556         [GTK] Add API to allow overriding the default color chooser implementation
557         https://bugs.webkit.org/show_bug.cgi?id=98935
558
559         Reviewed by Gustavo Noronha Silva.
560
561         Add a color chooser implementation for MiniBrowser using
562         GtkPopover when the GTK+ version is recent enough.
563         And a test case to check the new color chooser API.
564
565         * MiniBrowser/gtk/BrowserWindow.c:
566         (colorChooserRGBAChanged):
567         (popoverColorClosed):
568         (colorChooserRequestFinished):
569         (runColorChooserCallback):
570         (browserWindowConstructed):
571         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
572         (testWebViewColorChooserRequest):
573         (beforeAll):
574
575 2015-02-11  Csaba Osztrogonác  <ossy@webkit.org>
576
577         Make run-jsc-stress-tests --remote work with make-based runner
578         https://bugs.webkit.org/show_bug.cgi?id=141079
579
580         Reviewed by Darin Adler.
581
582         * Scripts/run-javascriptcore-tests:
583         (runJSCStressTests): Pass through the --shell-runner and --make-runner arguments.
584         * Scripts/run-jsc-stress-tests: Made the make-based runner the default runner,
585         except for remote testing on Darwin. Unified runShellTestRunner and runMakeTestRunner
586         to avoid code duplication.
587
588 2015-02-11  Csaba Osztrogonác  <ossy@webkit.org>
589
590         run-jsc-stress tests should detect the number of processors on the remote machine too
591         https://bugs.webkit.org/show_bug.cgi?id=141196
592
593         Reviewed by Darin Adler.
594
595         * Scripts/run-javascriptcore-tests:
596         (runJSCStressTests): Pass through the --child-processes argument.
597         * Scripts/run-jsc-stress-tests: Added determineNumberOfProcessors function
598         to detect the number of local and remote processors with the same algorithm.
599         Additionally introduced $numChildProcesses to emphasize it isn't necessarily
600         same as $numProcessors.
601
602 2015-02-11  Csaba Osztrogonác  <ossy@webkit.org>
603
604         run-jsc-stress-tests should pass JSC_timeout to remote hosts
605         https://bugs.webkit.org/show_bug.cgi?id=141164
606
607         Reviewed by Darin Adler.
608
609         Additonally removed IMPORTANT_ENVS, since JSC_timeout was the only one.
610
611         * Scripts/run-jsc-stress-tests:
612
613 2015-02-11  Carlos Garcia Campos  <cgarcia@igalia.com>
614
615         [GTK] Add default color chooser implementation using GtkColorChooserDialog
616         https://bugs.webkit.org/show_bug.cgi?id=141392
617
618         Reviewed by Gustavo Noronha Silva.
619
620         Enable INPUT_TYPE_COLOR by default for GTK+ port.
621
622         * Scripts/webkitperl/FeatureList.pm:
623
624 2015-02-09  Csaba Osztrogonác  <ossy@webkit.org>
625
626         run-jsc-stress-tests shell test runner should run tests in fixed order
627         https://bugs.webkit.org/show_bug.cgi?id=141383
628
629         Reviewed by Darin Adler.
630
631         * Scripts/jsc-stress-test-helpers/shell-runner.sh:
632
633 2015-02-08  Chris Fleizach  <cfleizach@apple.com>
634
635         AX: VoiceOver appears unresponsive when JavaScript alerts are triggered via focus or blur events
636         https://bugs.webkit.org/show_bug.cgi?id=140485
637
638         Reviewed by Anders Carlsson.
639
640         Implement takeFocus() as a way to set focus through accessibility wrappers.
641
642         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
643         (AccessibilityUIElement::takeFocus):
644         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
645         (WTR::AccessibilityUIElement::takeFocus):
646
647 2015-02-08  Darin Adler  <darin@apple.com>
648
649         Remove the SVG instance tree
650         https://bugs.webkit.org/show_bug.cgi?id=140602
651
652         Reviewed by Dean Jackson.
653
654         * Scripts/check-for-global-initializers: Removed special case for
655         SVGElementInstance.o.
656
657 2015-02-07  David Kilzer  <ddkilzer@apple.com>
658
659         [iOS] run-webkit-tests fails due to simulator devices from previous SDK installs being marked as unavailable
660         <http://webkit.org/b/141365>
661
662         Reviewed by Daniel Bates.
663
664         * Scripts/webkitpy/xcode/simulator.py:
665         (Simulator): Add unavailable_version_re precompiled regex.
666         (Simulator._parse_devices): Check for unavailable versions and
667         ignore them if found when parsing the output of
668         `xcrun simctl list`.
669         * Scripts/webkitpy/xcode/simulator_unittest.py:
670         (test_unavailable_devices): Add test with output from
671         `xcrun simctl list` with unavailable runtimes that fails before
672         the fix.
673
674 2015-02-07  Chris Dumez  <cdumez@apple.com>
675
676         Add Vector::removeFirstMatching() / removeAllMatching() methods taking lambda functions
677         https://bugs.webkit.org/show_bug.cgi?id=141321
678
679         Reviewed by Darin Adler.
680
681         Use new Vector::removeFirstMatching() / removeAllMatching() methods.
682
683 2015-02-07  David Kilzer  <ddkilzer@apple.com>
684
685         [iOS] Make Simulator class testable
686         <http://webkit.org/b/141358>
687
688         Rubber-stamped by Darin Adler.
689
690         * Scripts/webkitpy/common/system/platforminfo.py:
691         (PlatformInfo.xcode_simctl_list): Move `xcrun simctl list`
692         command to here from Simulator.refresh() in xcode/simulator.py
693         so that the output of the command can be mocked.
694
695         * Scripts/webkitpy/common/system/platforminfo_mock.py:
696         (MockPlatformInfo.__init__): Set self.expected_xcode_simctl_list
697         to None.
698         (MockPlatformInfo.xcode_simctl_list): Add method that returns
699         self.expected_xcode_simctl_list expectation.
700
701         * Scripts/webkitpy/xcode/simulator.py: Add missing copyright
702         and license header.
703         (Simulator.__init__): Add optional 'host' parameter to make it
704         possible to pass in a mock object for testing.  Set self._host
705         to 'host' parameter or create Host() object.
706         (Simulator.refresh): Call new PlatformInfo.xcode_simctl_list()
707         method.
708
709         * Scripts/webkitpy/xcode/simulator_unittest.py: Add unit test
710         for current code.
711         (SimulatorTest):
712         (SimulatorTest.setUp):
713         (SimulatorTest._set_expected_xcrun_simctl_list):
714         (SimulatorTest.test_simulator_device_types):
715         (test_invalid_device_types_header):
716         (test_invalid_runtimes_header):
717         (test_invalid_devices_header):
718
719 2015-02-07  Csaba Osztrogonác  <ossy@webkit.org>
720
721         run-jsc-stress-tests --remote should use the default ssh port
722         https://bugs.webkit.org/show_bug.cgi?id=141287
723
724         Reviewed by Darin Adler.
725
726         * Scripts/run-jsc-stress-tests: Extended URI module to be able to handle ssh scheme with the default 22 port number.
727
728 2015-02-06  Dana Burkart  <dburkart@apple.com>
729
730         dashboard: BuildbotTesterQueueView crashesOnly logic is wrong
731         https://bugs.webkit.org/show_bug.cgi?id=141349
732
733         Reviewed by Alexey Proskuryakov.
734
735         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
736         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
737         (BuildbotTesterQueueView.prototype.update):
738
739 2015-02-06  Alexey Proskuryakov  <ap@apple.com>
740
741         Report network process crashes during layout tests
742         https://bugs.webkit.org/show_bug.cgi?id=139646
743
744         Reviewed by Anders Carlsson.
745
746         * WebKitTestRunner/TestController.cpp:
747         (WTR::TestController::initialize):
748         (WTR::TestController::networkProcessName):
749         (WTR::TestController::networkProcessDidCrash):
750         * WebKitTestRunner/TestController.h:
751
752 2015-02-06  Csaba Osztrogonác  <ossy@webkit.org>
753
754         run-jsc-stress-tests --remote should create remote directory before copying the bundle
755         https://bugs.webkit.org/show_bug.cgi?id=141329
756
757         Reviewed by Michael Saboff.
758
759         * Scripts/run-jsc-stress-tests:
760
761 2015-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
762
763         [GTK] Remove WebKitWebView::close-notification signal
764         https://bugs.webkit.org/show_bug.cgi?id=141330
765
766         Reviewed by Gustavo Noronha Silva.
767
768         Update notifications unit tests according to the API changes, and
769         add a test case to check that onclose event is fired when a
770         notification is closed by the user.
771
772         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
773         (testWebViewNotification):
774
775 2015-02-05  Alexey Proskuryakov  <ap@apple.com>
776
777         Dashboard doesn't consider building ASan a productive step
778         https://bugs.webkit.org/show_bug.cgi?id=141312
779
780         Reviewed by Simon Fraser.
781
782         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
783
784 2015-02-05  Daniel Bates  <dabates@apple.com>
785
786         [iOS] webkitpy.xcode.simulator.Runtime.from_identifier() returns wrong result for non-existent runtime
787         https://bugs.webkit.org/show_bug.cgi?id=141306
788
789         Reviewed by Alexey Proskuryakov.
790
791         The function webkitpy.xcode.simulator.Runtime.from_identifier always returns a Runtime object
792         corresponding to the last-most runtime parsed from the output of `simctl list` for any non-
793         existent runtime.
794
795         * Scripts/webkitpy/xcode/simulator.py:
796         (Runtime.from_identifier):
797
798 2015-02-05  Daniel Bates  <dabates@apple.com>
799
800         LayoutTestRelay does not install DumpRenderTree.app/WebKitTestRunnerApp.app
801         https://bugs.webkit.org/show_bug.cgi?id=139746
802         <rdar://problem/19283658>
803
804         Reviewed by Alexey Proskuryakov.
805
806         Fixes an issues where LayoutTestRelay may fail to install DumpRenderTree.app/WebKitTestRunnerApp.app
807         if the simulator device is not in state Booted.
808
809         Currently run-webkit-test --ios-sim executes LayoutTestRelay immediately after
810         launching/relaunching the iOS Simulator app and a simulator app can only be installed
811         on a device that is in the Booted state. LayoutTestRelay may run before the
812         device is booted and hence fail to install DumpRenderTree.app/WebKitTestRunnerApp.app.
813         We should defer executing LayoutTestRelay until the simulator device booted by
814         iOS Simulator is in the Booted state.
815
816         * Scripts/webkitpy/port/ios.py: Import webkitpy.xcode.simulator.Simulator to avoid prefixing
817         Simulator methods with the module name, simulator.
818         (IOSSimulatorPort.setup_test_run): Wait for the simulator device to be in the Booted state
819         after launching iOS Simulator. Also, wait until the simulator device is in the Shutdown state
820         before launching iOS Simulator to boot it.
821         (IOSSimulatorPort.testing_device): Fix up caller since we now import webkitpy.xcode.simulator.Simulator.
822         (IOSSimulatorPort.simulator_path): Deleted; moved this function to class Simulator and renamed to device_directory().
823         * Scripts/webkitpy/xcode/simulator.py:
824         (Device.__init__): Remove parameter state and an instance variable of the same name, which represented
825         the state of the device when we created this object as part of parsing the output of `simctl list`. Callers
826         interested in the state of the device are more likely interested in the current state of the device as
827         opposed to the state of the device when the Device object was created.
828         (Device.state): Added; turn around and call Simulator.device_state() for the current state of the device.
829         (Device.path): Extracted implementation into Simulator.device_directory() so that it can be called
830         from both this function and Simulator.device_state().
831         (Device.create): Use Simulator.wait_until_device_is_in_state() to simplify the implementation of this function.
832         (Simulator.DeviceState): Added; class of constants.
833         (Simulator.wait_until_device_is_in_state): Added; this function does not return until the specified
834         device is in the specified state.
835         (Simulator.device_state): Added; parses the state of the device from the appropriate CoreSimulator device.plist file.
836         (Simulator.device_directory): Added.
837         (Simulator._parse_devices): Do not pass argument state to Device constructor as it no longer accepts it.
838
839 2015-02-05  Alexey Proskuryakov  <ap@apple.com>
840
841         Disable retries on Mac debug testers
842         https://bugs.webkit.org/show_bug.cgi?id=141296
843
844         Reviewed by Simon Fraser.
845
846         * BuildSlaveSupport/build.webkit.org-config/config.json:
847
848 2015-02-05  Dan Bernstein  <mitz@apple.com>
849
850         Need a way to force $xcodeSDK in webkitdirs.pm
851         https://bugs.webkit.org/show_bug.cgi?id=141291
852
853         Reviewed by Anders Carlsson.
854
855         * Scripts/webkitdirs.pm:
856         (setXcodeSDK): Added.
857
858 2015-02-05  Youenn Fablet  <youenn.fablet@crf.canon.fr> and Xabier Rodriguez Calvar <calvaris@igalia.com>
859
860         [Streams API] Implement a barebone ReadableStream interface
861         https://bugs.webkit.org/show_bug.cgi?id=141045
862
863         Reviewed by Benjamin Poulain.
864
865         * Scripts/webkitperl/FeatureList.pm: Added streams-api compilation switch.
866
867 2015-02-04  Joseph Pecoraro  <pecoraro@apple.com>
868
869         filter-build-webkit: reduce more unfiltered output
870         https://bugs.webkit.org/show_bug.cgi?id=141282
871
872         Reviewed by Daniel Bates.
873
874         * Scripts/filter-build-webkit:
875         Report CompileDTraceScript and Preprocess lines as successful.
876
877 2015-02-04  Dana Burkart  <dburkart@apple.com>
878
879         Botwatcher's Dashboard is cramped
880         https://bugs.webkit.org/show_bug.cgi?id=140273
881
882         Reviewed by Alexey Proskuryakov.
883
884         Add a heading key which will allow for arbitrary headings in builder queues.
885
886         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
887         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
888         (BuildbotBuilderQueueView.prototype.update):
889         (BuildbotBuilderQueueView.prototype.update.appendBuildArchitecture): Deleted.
890         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
891         (BuildbotIteration.prototype._parseData):
892         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
893         (BuildbotLeaksQueueView.prototype.update):
894         (BuildbotLeaksQueueView.prototype.update.appendBuild): Deleted.
895         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js:
896         (BuildbotPerformanceQueueView.prototype.update):
897         (BuildbotPerformanceQueueView.prototype.update.appendBuild): Deleted.
898         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
899         (BuildbotQueue):
900         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
901         (BuildbotQueueView.prototype._unauthorizedAccess):
902         (BuildbotQueueView.prototype._appendBuild):
903         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
904         (BuildbotTestResults):
905         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
906         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
907         (BuildbotTesterQueueView.prototype.update):
908         (BuildbotTesterQueueView.prototype.update.appendBuild): Deleted.
909
910 2015-02-04  Simon Fraser  <simon.fraser@apple.com>
911
912         WKTR should not use -mainScreen to pick a color profile
913         https://bugs.webkit.org/show_bug.cgi?id=141265
914
915         Reviewed by Tim Horton.
916         
917         -[NSScreen mainScreen] depends on the active window, so use the first screen
918         (which is the one we put the window on anyway).
919         
920         Do some cleanup in DRT that makes the code look similar.
921
922         * DumpRenderTree/mac/DumpRenderTree.mm:
923         (createWebViewAndOffscreenWindow):
924         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
925         (WTR::PlatformWebView::PlatformWebView):
926
927 2015-02-04  Simon Fraser  <simon.fraser@apple.com>
928
929         LayoutTestHelper should set the color profile of all displays
930         https://bugs.webkit.org/show_bug.cgi?id=141260
931
932         Reviewed by Tim Horton.
933         
934         WebKitTestRunner can (erroneously) grab the colorspace of the "main" screen.
935         which is the screen with the active window. Make things more robust by changing
936         the colorspace of all displays, not just the main screen, when running layout tests.
937
938         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig: Enable ARC
939         * DumpRenderTree/mac/LayoutTestHelper.m: 
940         (originalColorProfileURLs):
941         (colorProfileURLForDisplay):
942         (displayUUIDStrings):
943         (saveDisplayColorProfiles):
944         (setDisplayColorProfile):
945         (restoreDisplayColorProfiles):
946         (installLayoutTestColorProfile):
947         (restoreUserColorProfile):
948         (main):        
949         Store display color profiles by map of UUID strings to URLs (NSUUID and CFUUID are not
950         toll-free bridged, sadly). Use the map to restore all profiles on exit.
951         Convert to use more Obj-C types.
952
953 2015-02-04  Daniel Bates  <dabates@apple.com>
954
955         test-webkitpy fails on Mac without iphoneos SDK
956         https://bugs.webkit.org/show_bug.cgi?id=141255
957         <rdar://problem/19619691>
958
959         I inadvertently committed the wrong exception message. Fix up the exception message
960         to instruct a person to install the iOS SDK when it cannot be found.
961
962         * Scripts/webkitpy/port/ios.py:
963         (IOSPort.determine_full_port_name):
964
965 2015-02-04  Youenn Fablet  <youenn.fablet@crf.canon.fr>
966
967         W3C test importer should sort the list of files when generating the w3c-import.log
968         https://bugs.webkit.org/show_bug.cgi?id=141156
969
970         Reviewed by Bem Jones-Bey.
971
972         Sort explicitly the list of imported files written in the w3c-import.log.
973         Removed logging of the import date.
974
975         * Scripts/webkitpy/w3c/test_importer.py:
976         (TestImporter.write_import_log):
977
978 2015-02-04  Daniel Bates  <dabates@apple.com>
979
980         test-webkitpy fails on Mac without iphoneos SDK
981         https://bugs.webkit.org/show_bug.cgi?id=141255
982         <rdar://problem/19619691>
983
984         Reviewed by David Kilzer and Alexey Proskuryakov.
985
986         Fixes an issue where test-webkitpy fails on a Mac without the iOS SDK. We should
987         should not require the iphoneos SDK to be installed to run the webkitpy tests.
988
989         * Scripts/webkitpy/common/system/platforminfo.py:
990         (PlatformInfo.xcode_sdk_version): Added; return the version of the specified SDK, if
991         installed. We take advantage of the behavior that xcrun --show-sdk-version only writes
992         to standard output if the SDK is installed to return the empty string if the SDK is
993         not installed.
994         * Scripts/webkitpy/common/system/platforminfo_mock.py:
995         (MockPlatformInfo.xcode_sdk_version): Added.
996         * Scripts/webkitpy/port/ios.py:
997         (IOSPort.determine_full_port_name): Modified to call PlatformInfo.xcode_sdk_version()
998         to get the version of the iphoneos SDK, if installed.
999
1000 2015-02-04  Alexey Proskuryakov  <ap@apple.com>
1001
1002         run-webkit-tests doesn't always capture ASan violation reports
1003         https://bugs.webkit.org/show_bug.cgi?id=141231
1004
1005         Reviewed by Darin Adler.
1006
1007         * Scripts/webkitpy/port/driver.py:
1008         (Driver.run_test): Don't look for CrashReporter crash logs if a log was provided
1009         by the driver already (as is the case with ASan violations, which are printed to
1010         stderr).
1011         (Driver._check_for_address_sanitizer_violation): Check if the line is a start of ASan
1012         report.
1013         (Driver._read_block): Give ASan enough time to symbolicate a crash, and put it into
1014         a separate variable for reporting.
1015
1016 2015-02-03  Ryosuke Niwa  <rniwa@webkit.org>
1017
1018         [webkitpy] Add platform specific Skipped file mechanism for performance tests
1019         https://bugs.webkit.org/show_bug.cgi?id=141152
1020
1021         Reviewed by Csaba Osztrogonác.
1022
1023         Support a test-expectation-like syntax in performance tests' skipped files.
1024         e.g. [Mac] Parsed/BadTest.html will skip Parsed/BadTest.html on Mac ports.
1025
1026         * Scripts/webkitpy/port/base.py:
1027         (Port.skipped_perf_tests): Implemented the syntax support by a regular expression.
1028
1029         * Scripts/webkitpy/port/base_unittest.py:
1030         (PortTest.test_skipped_perf_tests): Test the new syntax.
1031
1032 2015-02-04  Alexey Proskuryakov  <ap@apple.com>
1033
1034         When tests fail on leaks bot so much that there are no leaks detected, dashboard erroneously shows green
1035         https://bugs.webkit.org/show_bug.cgi?id=141236
1036
1037         Reviewed by Sam Weinig.
1038
1039         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
1040         (BuildbotLeaksQueueView.prototype.update.appendLeaksQueueStatus):
1041
1042 2015-02-04  Chris Dumez  <cdumez@apple.com>
1043
1044         Add removeFirst(value) / removeAll(value) methods to WTF::Vector
1045         https://bugs.webkit.org/show_bug.cgi?id=141192
1046
1047         Reviewed by Benjamin Poulain.
1048
1049         Add API tests for Vector::removeFirst(value) and
1050         Vector::removeAll(value).
1051
1052         * TestWebKitAPI/Tests/WTF/Vector.cpp:
1053         (TestWebKitAPI::TEST):
1054
1055 2015-02-03  Tim Horton  <timothy_horton@apple.com>
1056
1057         Add WKPageNavigationClient as C SPI around API::NavigationClient, and adopt in WKTR
1058         https://bugs.webkit.org/show_bug.cgi?id=141217
1059
1060         Reviewed by Sam Weinig.
1061
1062         * WebKitTestRunner/TestController.cpp:
1063         (WTR::copyWebCryptoMasterKey):
1064         (WTR::TestController::createOtherPage):
1065         (WTR::TestController::createWebViewWithOptions):
1066         (WTR::TestController::ensureViewSupportsOptions):
1067         (WTR::TestController::didCommitNavigation):
1068         (WTR::TestController::didFinishNavigation):
1069         (WTR::TestController::canAuthenticateAgainstProtectionSpace):
1070         (WTR::TestController::didReceiveAuthenticationChallenge):
1071         (WTR::TestController::decidePolicyForPluginLoad):
1072         (WTR::TestController::decidePolicyForNavigationAction):
1073         (WTR::TestController::decidePolicyForNavigationResponse):
1074         (WTR::TestController::didCommitLoadForFrame): Deleted.
1075         (WTR::TestController::didFinishLoadForFrame): Deleted.
1076         * WebKitTestRunner/TestController.h:
1077         Adopt WKPageNavigationClient and adjust to its semantics (navigations are main-frame-only, etc.)
1078
1079 2015-02-03  Dhi Aurrahman  <diorahman@rockybars.com>
1080
1081         Unreviewed. Add myself as a committer.
1082
1083         * Scripts/webkitpy/common/config/contributors.json:
1084
1085 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
1086
1087         [Win] Unreviewed test fix.
1088
1089         * DumpRenderTree/win/PolicyDelegate.cpp:
1090         (PolicyDelegate::unableToImplementPolicyWithError): The message was missing a linefeed,
1091         so was not matching expected output.
1092
1093 2015-02-03  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1094
1095         Unreviewed. Moving myself to the committer section at last.
1096
1097         * Scripts/webkitpy/common/config/contributors.json:
1098
1099 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
1100
1101         [Win] Tests fail because DRT reports '(null)' instead of an empty string
1102         https://bugs.webkit.org/show_bug.cgi?id=141205
1103
1104         Reviewed by Anders Carlsson.
1105
1106         * DumpRenderTree/win/HistoryDelegate.cpp:
1107         (HistoryDelegate::didNavigateWithNavigationData): Deal with empty BSTR values
1108         properly so that we match expected DumpRenderTree output.
1109
1110 2015-02-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1111
1112         [GTK] TestWebKitAccessibility is not skipped
1113         https://bugs.webkit.org/show_bug.cgi?id=141179
1114
1115         Reviewed by Carlos Garcia Campos.
1116
1117         Don't attempt to skip TestWebKitAccessibility. This path is wrong so it was not being
1118         skipped, and it apparently works reliably on the bots.
1119
1120         * Scripts/run-gtk-tests:
1121         (TestRunner):
1122
1123 2015-02-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1124
1125         run-perf-tests: allow to specify a wrapper command.
1126         https://bugs.webkit.org/show_bug.cgi?id=141172
1127
1128         Reviewed by Ryosuke Niwa.
1129
1130         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1131         (parse_args): Update text to indicate is also valid for WTR.
1132         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1133         (PerfTestsRunner._parse_args): Add wrapper command.
1134
1135 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
1136
1137         [Win] Correct version parsing warning in update-webkit
1138         https://bugs.webkit.org/show_bug.cgi?id=141200
1139
1140         Reviewed by Anders Carlsson.
1141
1142         * Scripts/webkitdirs.pm:
1143         (setupAppleWinEnv): Strip out any specific version build level
1144         from the Cygwin version information.
1145   
1146
1147 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
1148
1149         [Win] Attempt to improve the reliability of HTTP service
1150         https://bugs.webkit.org/show_bug.cgi?id=141191
1151
1152         Reviewed by Darin Adler.
1153
1154         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1155         (LayoutTestApacheHttpd.__init__): Use default XAMPP pidfile location.
1156         (LayoutTestApacheHttpd._stop_running_server): Delete the abandoned PID file
1157         when stopping the service doesn't do so on its own (for Windows runs).
1158
1159 2015-02-03  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1160
1161         Web platform test server should not need to create __init__.py files
1162         https://bugs.webkit.org/show_bug.cgi?id=141030
1163
1164         Reviewed by Ryosuke Niwa.
1165
1166         W3C TestImporter ensures that copied __init__.py files are not empty.
1167         If needed, a comment is inserted in __init__.py files.
1168         Added a unit test to check that web-platform-tests tools and scripts python modules can be imported.
1169
1170         * Scripts/webkitpy/common/system/filesystem.py:
1171         (FileSystem.getsize):
1172         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
1173         (TestWebPlatformTestServer.test_start_cmd):
1174         (TestWebPlatformTestServer):
1175         (TestWebPlatformTestServer.test_import_web_platform_test_modules):
1176         * Scripts/webkitpy/w3c/test_importer.py:
1177         (TestImporter.import_tests):
1178
1179 2015-01-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1180
1181         Unreviewed. Moving myself to the committer section.
1182
1183         * Scripts/webkitpy/common/config/contributors.json:
1184
1185 2015-02-02  Saam Barati  <saambarati1@gmail.com>
1186
1187         Create tests for JSC's Control Flow Profiler
1188         https://bugs.webkit.org/show_bug.cgi?id=141123
1189
1190         Reviewed by Filip Pizlo.
1191
1192         * Scripts/run-javascriptcore-tests:
1193         (runJSCStressTests):
1194         * Scripts/run-jsc-stress-tests:
1195
1196 2015-02-02  Csaba Osztrogonác  <ossy@webkit.org>
1197
1198         Remove copy/paste code from run-jsc-stress-tests to determine numberOfTests
1199         https://bugs.webkit.org/show_bug.cgi?id=141158
1200
1201         Reviewed by Darin Adler.
1202
1203         * Scripts/run-jsc-stress-tests:
1204
1205 2015-02-02  Michael Catanzaro  <mcatanzaro@igalia.com>
1206
1207         [GTK] MiniBrowser should close itself on Ctrl+W or Ctrl+Q
1208         https://bugs.webkit.org/show_bug.cgi?id=141142
1209
1210         Reviewed by Carlos Garcia Campos.
1211
1212         * MiniBrowser/gtk/BrowserWindow.c:
1213         (browser_window_init): Quit on Ctrl+W or Ctrl+Q
1214
1215 2015-02-01  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1216
1217         Web platform test server is not always launching properly on Mac EWS bots
1218         https://bugs.webkit.org/show_bug.cgi?id=141141
1219
1220         Unreviewed.
1221
1222         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
1223         (create_wpt_empty_file_if_needed): Removed creation of empty __init.py__ files from AutoInstalled modules.
1224
1225 2015-01-31  Sam Weinig  <sam@webkit.org>
1226
1227         Remove even more Mountain Lion support
1228         https://bugs.webkit.org/show_bug.cgi?id=141124
1229
1230         Reviewed by Alexey Proskuryakov.
1231
1232         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1233         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
1234         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1235         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1236         * DumpRenderTree/mac/DumpRenderTree.mm:
1237         (activateTestingFonts):
1238         (prepareConsistentTestingEnvironment):
1239         * DumpRenderTree/mac/EventSendingController.mm:
1240         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
1241         (-[EventSendingController contextClick]):
1242         * DumpRenderTree/mac/TextInputController.m:
1243         * LayoutTestRelay/Configurations/Base.xcconfig:
1244         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
1245         * MiniBrowser/Configurations/Base.xcconfig:
1246         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1247         * MiniBrowser/mac/WK2BrowserWindowController.m:
1248         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1249         (-[WK2BrowserWindowController webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
1250         (-[WK2BrowserWindowController webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
1251         * TestWebKitAPI/Configurations/Base.xcconfig:
1252         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1253         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1254         (-[DownloadDelegate _downloadDidFinish:]):
1255         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
1256         (TestWebKitAPI::TEST):
1257         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
1258         (TestWebKitAPI::InjectedBundleController::platformInitialize):
1259         * WebKitLauncher/Configurations/Base.xcconfig:
1260         * WebKitTestRunner/Configurations/Base.xcconfig:
1261         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1262         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1263         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
1264         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
1265         (WTR::activateFonts):
1266         * WebKitTestRunner/TestController.cpp:
1267         (WTR::TestController::initialize):
1268         (WTR::TestController::webProcessName):
1269         * WebKitTestRunner/mac/EventSenderProxy.mm:
1270         * asan/asan.xcconfig:
1271
1272 2015-01-31  Commit Queue  <commit-queue@webkit.org>
1273
1274         Unreviewed, rolling out r179408.
1275         https://bugs.webkit.org/show_bug.cgi?id=141117
1276
1277         This didn't fully fix the issue (Requested by anttik on
1278         #webkit).
1279
1280         Reverted changeset:
1281
1282         "OSObjectPtr does not work with dispatch_data_t on Maverics"
1283         https://bugs.webkit.org/show_bug.cgi?id=141081
1284         http://trac.webkit.org/changeset/179408
1285
1286 2015-01-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1287
1288         https://trac.webkit.org/changeset/179439 breaks a python test
1289         https://bugs.webkit.org/show_bug.cgi?id=141114
1290
1291         Unreviewed.
1292
1293         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1294         (WebPlatformTestServer._install_modules): Checks whether WPTModules file exists before reading it as no such file exists in mock tests.  
1295
1296 2015-01-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1297
1298         Import W3C web platform tests infrastructure
1299         https://bugs.webkit.org/show_bug.cgi?id=140934
1300
1301         Reviewed by Ryosuke Niwa.
1302
1303         Loading necessary web platform tests modules before launching server.
1304         Ensuring that some empty __init__.py files are present and create them if necessary. 
1305
1306         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
1307         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1308
1309 2015-01-30  Brent Fulgham  <bfulgham@apple.com>
1310
1311         [Win] Another unreviewed test fix.
1312
1313         Correct copy/paste error in buildbot handling.
1314
1315         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1316         (LayoutTestApacheHttpd.__init__):
1317         (LayoutTestApacheHttpd._get_apache_config_file_path):
1318
1319 2015-01-30  Brent Fulgham  <bfulgham@apple.com>
1320
1321         [Win] Unreviewed test fix.
1322
1323         Correct path handling based on failures on test bots to get things running again.
1324
1325         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1326         (LayoutTestApacheHttpd.__init__):
1327         (LayoutTestApacheHttpd._get_apache_config_file_path):
1328
1329 2015-01-30  Chris Dumez  <cdumez@apple.com>
1330
1331         Unreviewed. Fix Windows build after r179409.
1332
1333         * DumpRenderTree/win/TestRunnerWin.cpp:
1334         (TestRunner::notifyDone):
1335         (TestRunner::queueLoad):
1336
1337 2015-01-30  Chris Dumez  <cdumez@apple.com>
1338
1339         Rename shared() static member functions to singleton() for singleton classes.
1340         https://bugs.webkit.org/show_bug.cgi?id=141088
1341
1342         Reviewed by Ryosuke Niwa and Benjamin Poulain.
1343
1344         Rename shared() static member functions to singleton() for singleton
1345         classes as per the recent coding style change.
1346
1347 2015-01-30  Antti Koivisto  <antti@apple.com>
1348
1349         OSObjectPtr does not work with dispatch_data_t on Maverics
1350         https://bugs.webkit.org/show_bug.cgi?id=141081
1351
1352         Reviewed by Pratik Solanki.
1353
1354         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp:
1355         (TestWebKitAPI::TEST):
1356
1357 2015-01-30  Brent Fulgham  <bfulgham@apple.com>
1358
1359         [Win] Switch to Apache on Windows
1360         https://bugs.webkit.org/show_bug.cgi?id=141060
1361
1362         Reviewed by Alexey Proskuryakov.
1363
1364         Update our scripts under Windows (and Cygwin) to locate and use
1365         the XAMPP installation of Apache for running tests.
1366
1367         * Scripts/run-webkit-httpd:
1368         * Scripts/webkitperl/httpd.pm:
1369         (getHTTPDPath):
1370         (getDefaultConfigForTestDirectory):
1371         (getHTTPDConfigPathForTestDirectory):
1372         * Scripts/webkitpy/common/system/executive_unittest.py:
1373         (ExecutiveTest.serial_test_kill_process):
1374         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1375         (LayoutTestApacheHttpd.__init__):
1376         (LayoutTestApacheHttpd._get_apache_config_file_path):
1377         (LayoutTestApacheHttpd._stop_running_server):
1378         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
1379         (HttpServerBase._is_server_running_on_all_ports):
1380         * Scripts/webkitpy/port/base.py:
1381         (Port._apache_config_file_name_for_platform):
1382         * Scripts/webkitpy/port/port_testcase.py:
1383         (test_apache_config_file_name_for_platform):
1384         * Scripts/webkitpy/port/win.py:
1385         (WinPort.show_results_html_file):
1386         (WinPort._uses_apache):
1387         (WinPort):
1388         (WinPort._path_to_apache):
1389
1390 2015-01-29  Alexey Proskuryakov  <ap@apple.com>
1391
1392         Built result takes too long to be compressed on bots
1393         https://bugs.webkit.org/show_bug.cgi?id=141056
1394
1395         Reviewed by Daniel Bates.
1396
1397         Reduces compression time from ~3.5 min to ~1.5 min. Archive size gets 2% bigger.
1398
1399         * BuildSlaveSupport/test-result-archive: (archiveTestResults):
1400
1401 2015-01-29  Sam Weinig  <sam@webkit.org>
1402
1403         Remove support for screen font substitution
1404         https://bugs.webkit.org/show_bug.cgi?id=141038
1405
1406         Reviewed by Tim Horton.
1407
1408         * DumpRenderTree/win/DumpRenderTree.cpp:
1409         (resetWebPreferencesToConsistentValues):
1410         Remove call to now setScreenFontSubstitutionEnabled() which is a no-op.
1411
1412 2015-01-29  Csaba Osztrogonác  <ossy@webkit.org>
1413
1414         Make run-jsc-stress-tests --remote work on Linux too
1415         https://bugs.webkit.org/show_bug.cgi?id=141000
1416
1417         Reviewed by Darin Adler.
1418
1419         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Omit error message of sysctl,
1420         use bash/dash compatible signal names, use Linux/Mac compatible find options,
1421         use bash/dash compatible functions.
1422         * Scripts/run-jsc-stress-tests: Use Linux/Mac compatible find options.
1423
1424 2015-01-29  Csaba Osztrogonác  <ossy@webkit.org>
1425
1426         [buildbot] Simplify jscore-test buildstep
1427         https://bugs.webkit.org/show_bug.cgi?id=140821
1428
1429         Reviewed by Alexey Proskuryakov.
1430
1431         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1432         (RunJavaScriptCoreTests): Inherited from TestWithFailureCount and removed useless actual.html logfile.
1433         (RunJavaScriptCoreTests.countFailures): Added.
1434         (RunJavaScriptCoreTests.commandComplete): Deleted.
1435         (RunJavaScriptCoreTests.evaluateCommand): Deleted.
1436         (RunJavaScriptCoreTests.getText): Deleted.
1437         (RunJavaScriptCoreTests.getText2): Deleted.
1438         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Updated.
1439         (RunJavaScriptCoreTestsTest.test_mozilla_failure_old_output):
1440         (RunJavaScriptCoreTestsTest.test_mozilla_failures_old_output):
1441         (RunJavaScriptCoreTestsTest.test_jsc_stress_failure_new_output):
1442         (RunJavaScriptCoreTestsTest.test_jsc_stress_failures_new_output):
1443
1444 2015-01-29  Csaba Osztrogonác  <ossy@webkit.org>
1445
1446         Unreviewed, revert r179337, we don't need this dependency.
1447
1448         * efl/install-dependencies:
1449         * gtk/install-dependencies:
1450
1451 2015-01-28  Shivakumar JM  <shiva.jm@samsung.com>
1452
1453         Unreviewed. Moving myself to the committer section.
1454
1455         * Scripts/webkitpy/common/config/contributors.json:
1456
1457 2015-01-28  Csaba Osztrogonác  <ossy@webkit.org>
1458
1459         URTBF after r179326, added uuid-dev package as new dependency.
1460
1461         * efl/install-dependencies:
1462         * gtk/install-dependencies:
1463
1464 2015-01-28  Timothy Horton  <timothy_horton@apple.com>
1465
1466         Add a WebKitMessageRecorder DTrace provider, exposing IPC details to DTrace
1467         https://bugs.webkit.org/show_bug.cgi?id=140673
1468
1469         Reviewed by Sam Weinig.
1470
1471         * Scripts/dtrace/trace-webkit2-messages.d: Added.
1472         Add a DTrace script that outputs a small blob of JSON per message.
1473
1474 2015-01-28  Geoffrey Garen  <ggaren@apple.com>
1475
1476         Removed fastMallocForbid / fastMallocAllow
1477         https://bugs.webkit.org/show_bug.cgi?id=141012
1478
1479         Reviewed by Mark Hahnenberg.
1480
1481         Fixed a test bug I noticed while testing.
1482
1483         * DumpRenderTree/JavaScriptThreading.cpp:
1484         (stopJavaScriptThreads): Lock the javaScriptThreads lock before
1485         accessing javaScriptThreads -- otherwise, you'll ASSERT.
1486
1487 2015-01-28  Dana Burkart  <dburkart@apple.com>
1488
1489         asan.xcconfig should use CLANG_ADDRESS_SANITIZER=YES instead of -fsanitize=address
1490         https://bugs.webkit.org/show_bug.cgi?id=141015
1491
1492         Reviewed by Alexey Proskuryakov.
1493
1494         * asan/asan.xcconfig:
1495
1496 2015-01-28  Sam Weinig  <sam@webkit.org>
1497
1498         Fix the build.
1499
1500         * Scripts/copy-webkitlibraries-to-product-directory:
1501
1502 2015-01-28  Lucas Forschler  <lforschler@apple.com>
1503
1504         Increase the FileUpload block size in an attempt to improve network performance.
1505         
1506         Reviewed by Alexey Proskuryakov.
1507         
1508         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1509         (UploadBuiltProduct.__init__):
1510
1511 2015-01-28  Dana Burkart  <dburkart@apple.com>
1512
1513         Move ASan flag settings from DebugRelease.xcconfig to Base.xcconfig
1514         https://bugs.webkit.org/show_bug.cgi?id=136765
1515
1516         Reviewed by Alexey Proskuryakov.
1517
1518         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1519         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1520         * LayoutTestRelay/Configurations/Base.xcconfig:
1521         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
1522         * MiniBrowser/Configurations/Base.xcconfig:
1523         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1524         * TestWebKitAPI/Configurations/Base.xcconfig:
1525         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1526         * WebKitLauncher/Configurations/Base.xcconfig:
1527         * WebKitTestRunner/Configurations/Base.xcconfig:
1528         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1529
1530 2015-01-28  Joanmarie Diggs  <jdiggs@igalia.com>
1531
1532         AX: [ATK] Implement support for new AtkRole types for MathML
1533         https://bugs.webkit.org/show_bug.cgi?id=140916
1534
1535         Reviewed by Chris Fleizach.
1536
1537         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: Add mapping for new ATK roles
1538         * gtk/jhbuild.modules: Bump minimum version of ATK used by jhbuild to 2.15.4
1539
1540 2015-01-28  Carlos Garcia Campos  <cgarcia@igalia.com>
1541
1542         [GTK] Stop removing color marks from unit tests output
1543         https://bugs.webkit.org/show_bug.cgi?id=140996
1544
1545         Reviewed by Philippe Normand.
1546
1547         Since r178236 google tests use a custom simplified output without
1548         any colors, so we don't need to handle the case of non ttys to
1549         remove the color marks.
1550
1551         * Scripts/run-gtk-tests:
1552         (TestRunner.__init__):
1553         (TestRunner._run_test_command.parse_line):
1554
1555 2015-01-28  Carlos Garcia Campos  <cgarcia@igalia.com>
1556
1557         [GTK] Unit test /webkit2/WebKitWebView/page-visibility from WebKit2Gtk/TestWebKitWebView fails
1558         https://bugs.webkit.org/show_bug.cgi?id=131731
1559
1560         Reviewed by Žan Doberšek.
1561
1562         A web page loaded offscreen is in prerender state not hidden.
1563
1564         * Scripts/run-gtk-tests:
1565         (TestRunner): Unskip /webkit2/WebKitWebView/page-visibility.
1566         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1567         (testWebViewPageVisibility):
1568
1569 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
1570
1571         Partially revert r178802.
1572
1573         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png:
1574         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png:
1575
1576 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
1577
1578         build.webkit.org/dashboard asserts on some commits
1579         https://bugs.webkit.org/show_bug.cgi?id=140926
1580
1581         Reviewed by Tim Horton.
1582
1583         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1584         (Trac.prototype._convertCommitInfoElementToObject): Added a case for another root directory.
1585
1586 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
1587
1588         Make flakiness dashboard OS list actually match test_expectations.py
1589         https://bugs.webkit.org/show_bug.cgi?id=140969
1590
1591         Reviewed by Ryosuke Niwa.
1592
1593         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1594
1595 2015-01-27  Brent Fulgham  <bfulgham@apple.com>
1596
1597         [Win] WinLauncher crashes on eleventh site visited
1598         https://bugs.webkit.org/show_bug.cgi?id=140960
1599
1600         Reviewed by Anders Carlsson.
1601
1602         * WinLauncher/WinLauncher.cpp:
1603         (WinLauncher::showLastVisitedSites): Don't access off the end of
1604         the history array.
1605
1606 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
1607
1608         [Mac] Disable building Java applets by default
1609         https://bugs.webkit.org/show_bug.cgi?id=140957
1610         rdar://problem/19619529
1611
1612         Reviewed by Anders Carlsson.
1613
1614         It was actually already disabled unconditionally, by accident.
1615
1616         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (parse_args):
1617         * Scripts/webkitpy/port/mac.py:
1618         (MacPort._check_port_build):
1619         (MacPort._build_java_test_support):
1620
1621 2015-01-27  Daniel Bates  <dabates@apple.com>
1622
1623         [iOS] run-webkit-tests --platform=ios* --lint-test-files does not work
1624         https://bugs.webkit.org/show_bug.cgi?id=140949
1625
1626         Reviewed by Alexey Proskuryakov.
1627
1628         Add "ios-simulator" and "ios-simulator-wk2" to the list of ports without
1629         builders so that run-webkit-tests can lint the appropriate TestExpectation
1630         files.
1631
1632         * Scripts/webkitpy/port/builders.py:
1633         * Scripts/webkitpy/port/ios.py:
1634         (IOSSimulatorPort.__init__): Move logic to query for the Mac build directory from here...
1635         (IOSSimulatorPort.relay_path): to here as this is the only caller that makes use of that
1636         information to find the LayoutTestRelay tool. Otherwise, "self.assertEqual(len(calls), 1)"
1637         in unit test webkitpy.tool.commands.rebaseline_unittest.TestRebaselineExpectations.test_rebaseline_expectations
1638         will fail because IOSSimulatorPort.__init__() ultimately calls Tools/Scripts/webkit-build-directory
1639         to determine the Mac build directory for each instantiation of IOSSimulatorPort. And this unit
1640         test instantiates a port object for each builder listed in file Scripts/webkitpy/port/builders.py.
1641
1642
1643 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
1644
1645         Update bots on the flakiness dashboard
1646         https://bugs.webkit.org/show_bug.cgi?id=140956
1647
1648         Reviewed by Ryosuke Niwa.
1649
1650         * TestResultServer/static-dashboards/builders.jsonp:
1651         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1652
1653 2015-01-27  Daniel Bates  <dabates@apple.com>
1654
1655         [iOS WK2] Add directory LayoutTests/platform/wk2 to the list of baseline search paths
1656         https://bugs.webkit.org/show_bug.cgi?id=140942
1657
1658         Reviewed by Alexey Proskuryakov.
1659
1660         The directory LayoutTests/platform/wk2 contains test expectations and test results that
1661         are applicable to all WebKit2 ports. We should make use of this information when
1662         running layout tests using iOS WebKit2.
1663
1664         Additionally, make use of the convenience function Port._wk2_port_name() for the name
1665         of the WebKit2 port instead of directly using string concatenation.
1666
1667         * Scripts/webkitpy/port/ios.py:
1668         (IOSSimulatorPort.default_baseline_search_path):
1669
1670 2015-01-27  Csaba Osztrogonác  <ossy@webkit.org>
1671
1672         [Win] Disable FTL stress tests
1673         https://bugs.webkit.org/show_bug.cgi?id=140932
1674
1675         Reviewed by Brent Fulgham.
1676
1677         * Scripts/run-javascriptcore-tests:
1678
1679 2015-01-27  Daniel Bates  <dabates@apple.com>
1680
1681         REGRESSION (r179130): Perl warns about subroutine redefinition when running configure-xcode-for-ios-development
1682         https://bugs.webkit.org/show_bug.cgi?id=140939
1683
1684         Reviewed by Eric Carlson.
1685
1686         Fixes the Perl warning: "Subroutine wanted redefined at Tools/Scripts/configure-xcode-for-ios-development line 106."
1687
1688         * Scripts/webkitdirs.pm:
1689         (hasUserInstalledAppInSimulatorDevice): Pass a reference to an anonymous function instead
1690         of a named function to find() to avoid redefinition warnings in scripts that include webkitdirs.pm
1691         and define a function called wanted.
1692
1693 2015-01-27  Daniel Bates  <dabates@apple.com>
1694
1695         Teach run-webkit-app --simulator how to install custom built app
1696         https://bugs.webkit.org/show_bug.cgi?id=140691
1697
1698         Fix inadvertent omission of directory test flag in expression to check for the
1699         existence of the iOS simulator device-specific directory for user installed apps.
1700
1701         * Scripts/webkitdirs.pm:
1702         (hasUserInstalledAppInSimulatorDevice):
1703
1704 2015-01-26  Brent Fulgham  <bfulgham@apple.com>
1705
1706         [Win] ASSERTION FAILED !m_ptr under AccessibilityController::winAddNotificationListener
1707         https://bugs.webkit.org/show_bug.cgi?id=87426
1708         <rdar://problem/11527899>
1709
1710         Reviewed by Darin Adler.
1711
1712         Revise COMPtr to work better with our HashMap implementation. Use
1713         modern loop syntax.
1714
1715         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1716         (AccessibilityController::~AccessibilityController):
1717         (AccessibilityController::winNotificationReceived):
1718         * DumpRenderTree/win/DumpRenderTree.cpp:
1719         (dumpBackForwardListForAllWindows):
1720
1721 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
1722
1723         [Win] Enable JSC stress tests by default
1724         https://bugs.webkit.org/show_bug.cgi?id=128307
1725
1726         Reviewed by Brent Fulgham.
1727
1728         * Scripts/run-javascriptcore-tests:
1729
1730 2015-01-26  Simon Fraser  <simon.fraser@apple.com>
1731
1732         [iOS] Remove the various aliases for --ios-simulator (--sim, --simulator, --ios-sim) in
1733         arguments for build and test scripts
1734         https://bugs.webkit.org/show_bug.cgi?id=139748
1735
1736         Reviewed by Daniel Bates.
1737
1738         There was much confusion resulting from the multitude of aliases used to build/test for
1739         the iOS simulator. Standardize on "--ios-simulator", which is also the name of the layout
1740         tests directory.
1741
1742         This fixes an issue where run-api-tests and some other scripts failed when run with
1743         --simulator.
1744
1745         * Scripts/build-webkit:
1746         * Scripts/package-root:
1747         (usage):
1748         * Scripts/webkitdirs.pm:
1749         (argumentsForConfiguration):
1750         (determineXcodeSDK):
1751         * Scripts/webkitpy/port/factory.py:
1752         (platform_options):
1753
1754 2015-01-26  Simon Fraser  <simon.fraser@apple.com>
1755
1756         [iOS WK2] Fix possible crash when -[WKWebView evaluateJavaScript:completionHandler:] was called then the WKWebView is destroyed
1757         https://bugs.webkit.org/show_bug.cgi?id=140203
1758         rdar://problem/19198492
1759
1760         Reviewed by Sam Weinig.
1761
1762         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1763         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm: Added.
1764         (TEST):
1765
1766 2015-01-26  David Kilzer  <ddkilzer@apple.com>
1767
1768         Add iOS EWS to build.webkit.org/dashboard
1769         <http://webkit.org/b/140627>
1770
1771         Reviewed by Alexey Proskuryakov.
1772
1773         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice.png: Add.
1774         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice@2x.png: Add.
1775         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1776         (BubbleQueueServer): Add ios-ews queue info.
1777         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1778         Add iOS8Device platform.
1779         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1780         (table.queue-grid tr.platform.ios-8 img.logo): Add CSS to draw
1781         iOS device logo.
1782
1783 2015-01-26  Filip Pizlo  <fpizlo@apple.com>
1784
1785         copy-webkitlibraries-to-product-directory's hack to build LLVM from source should be hardened for Xcode deciding it needs SDKROOT set
1786         https://bugs.webkit.org/show_bug.cgi?id=140896
1787
1788         Reviewed by Michael Saboff.
1789         
1790         I've encountered some Xcode setups where you need to set SDKROOT to get llvm to build. This
1791         makes our script do this.
1792         
1793         Note that an alternative would be to run clang via "xcrun clang" rather than directly, but
1794         this would be harder given llvm's autoconf setup.
1795
1796         * Scripts/copy-webkitlibraries-to-product-directory:
1797
1798 2015-01-26  Alexey Proskuryakov  <ap@apple.com>
1799
1800         Update bot assignments.
1801
1802         * BuildSlaveSupport/build.webkit.org-config/config.json:
1803
1804 2015-01-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1805
1806         Integrate WP python server into WebKit test framework
1807         https://bugs.webkit.org/show_bug.cgi?id=127094
1808
1809         Reviewed by Ryosuke Niwa.
1810
1811         This patch adds W3C web server (wptserver) as a new HTTP server.
1812         wptserver is used to serve all tests inside LayoutTests/imported/w3c/wpt.
1813         wptserver implementation should be imported within the import of the Web Platform Test suite (to ensure keeping server and tests in sync) in LayoutTests/imported/w3c/wpt.
1814
1815         Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py serves as main entry point to wpt spawned process.
1816         Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py is responsible to start/stop the wpt server process.
1817         It also sets up the server config and testharness.js/testharnessreport.js files at start and stop of the wpt server.
1818
1819         * Scripts/webkitpy/common/system/executive_mock.py:
1820         (MockProcess.communicate):
1821         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py: Adding start/stop of web platform test server according boolean parameter.
1822         (LayoutTestRunner.__init__):
1823         (LayoutTestRunner.run_tests):
1824         (LayoutTestRunner.start_servers):
1825         (LayoutTestRunner.stop_servers):
1826         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py: Updated to check for wpt server start/stop.
1827         (LayoutTestRunnerTests._run_tests):
1828         (LayoutTestRunnerTests.test_servers_started.start_web_platform_test_server):
1829         (LayoutTestRunnerTests.test_servers_started.stop_web_platform_test_server):
1830         (LayoutTestRunnerTests):
1831         (LayoutTestRunnerTests.test_servers_started):
1832         * Scripts/webkitpy/layout_tests/controllers/manager.py:  Updated to check whether a test is a wpt test and whether wpt server launch is needed.
1833         (Manager.__init__):
1834         (Manager._is_http_test):
1835         (Manager._is_web_platform_test):
1836         (Manager._run_tests):
1837         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1838         (ManagerTest.test_needs_servers.get_wpt_doc_root):
1839         (ManagerTest.test_needs_servers.get_manager):
1840         (ManagerTest.test_needs_servers):
1841         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Added an option to control the doc_root of the wpt server.
1842         (parse_args):
1843         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py: Added.
1844         (main):
1845         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py: Added.
1846         (doc_root):
1847         (base_url):
1848         (WebPlatformTestServer):
1849         (WebPlatformTestServer.__init__):
1850         (WebPlatformTestServer._set_start_cmd):
1851         (WebPlatformTestServer._copy_webkit_test_files):
1852         (WebPlatformTestServer._clean_webkit_test_files):
1853         (WebPlatformTestServer._prepare_config):
1854         (WebPlatformTestServer._spawn_process):
1855         (WebPlatformTestServer._stop_running_server):
1856         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py: Added.
1857         (TestWebPlatformTestServer):
1858         (TestWebPlatformTestServer.test_start_cmd):
1859         * Scripts/webkitpy/port/base.py:
1860         (Port.__init__):
1861         (Port.to.start_web_platform_test_server):
1862         (Port.to):
1863         (Port.to.web_platform_test_server_doc_root):
1864         (Port.to.web_platform_test_server_base_url):
1865         (Port.to.stop_web_platform_test_server):
1866         * Scripts/webkitpy/port/driver.py: Updated the test name <-> test URL conversion routines.
1867         (Driver.__init__):
1868         (Driver.is_web_platform_test):
1869         (Driver.test_to_uri):
1870         (Driver.uri_to_test):
1871         (Driver._command_from_driver_input):
1872         * Scripts/webkitpy/port/driver_unittest.py:  Updated tests according new conversion rules.
1873         (DriverTest.test_test_to_uri):
1874         (DriverTest.test_uri_to_test):
1875
1876 2015-01-26  Daniel Bates  <dabates@apple.com>
1877
1878         Teach run-webkit-app --simulator how to install custom built app
1879         https://bugs.webkit.org/show_bug.cgi?id=140691
1880
1881         Reviewed by David Kilzer.
1882
1883         We should teach run-webkit-app --simulator how to install a custom built app.
1884
1885         Currently run-webkit-app --simulator can only run a system app or an app that
1886         was installed using the simctl command line tool. For convenience we should
1887         teach run-webkit-app --simulator how to install a custom built app.
1888
1889         As a side effect of this change run-safari --simulator will install and run
1890         a custom built of MobileSafari (if it exists).
1891
1892         * Scripts/webkitdirs.pm:
1893         (iOSSimulatorDevices): Added FIXME comment to decouple device representation in
1894         Perl from the structure of the device.plist file.
1895         (plistPathFromBundle): Fix if-statement condition so that we actually perform a
1896         file system check to determine the plist path for a Mac app bundle.
1897         (appIdentifierFromBundle): Pass absolute files system path to defaults(1). Otherwise,
1898         it will complain that it cannot find the file: "Domain ... does not exist".
1899         (appDisplayNameFromBundle): Ditto.
1900         (waitUntilIOSSimulatorDeviceIsInState): Added; helper function that does not return
1901         until a simulator device is the specified state.
1902         (relaunchIOSSimulator): Renamed; formerly named openIOSSimulator. Quits iOS Simulator
1903         (if it's open) before opening it again so as to ensure that the iOS Simulator boots
1904         the specified device.
1905         (quitIOSSimulator): Added optional parameter, $waitForShutdownOfSimulatedDeviceUDID.
1906         As implied by its name, this function will not return until the specified simulator
1907         device UDID is in the shutdown state.
1908         (iosSimulatorDeviceByUDID): Added; returns the device dictionary object for the simulator
1909         device with the specified UDID.
1910         (isIOSSimulatorSystemInstalledApp): Resolve symbolic links in iosSimulatorApplicationsPath()
1911         before using it as part of a prefix match to avoid a mismatch. In the public iOS 8.1 SDK the
1912         return value of iosSimulatorApplicationsPath(), which returns a result analogous to the shell
1913         expression echo `xcrun --sdk iphonesimulator --show-sdk-path`/Applications/, contains a
1914         symbolic link. Specifically, echo `xcrun --sdk iphonesimulator --show-sdk-path` returns
1915         /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator8.1.sdk,
1916         which is a symbolic link to /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator.sdk.
1917         (hasUserInstalledAppInSimulatorDevice): Added.
1918         (isSimulatorDeviceBooted): Added; returns whether the specified simulator device is in the
1919         "Booted" state.
1920         (runIOSWebKitAppInSimulator): Modified to install a custom built app (if needed). For now,
1921         switching between a system installed app and a custom built version of the same app (e.g.
1922         custom build of MobileSafari) will erase all contents and settings in the simulator device.
1923         (eraseIOSSimulatorDevice): Deleted; inline implementation into runIOSWebKitAppInSimulator()
1924         as that was the only caller of this function.
1925         (bootedIOSSimulatorDevice): Deleted.
1926         (openIOSSimulator): Deleted.
1927
1928 2015-01-26  Alexey Proskuryakov  <ap@apple.com>
1929
1930         Update bot assignments.
1931
1932         * BuildSlaveSupport/build.webkit.org-config/config.json:
1933
1934 2015-01-26  Alexey Proskuryakov  <ap@apple.com>
1935
1936         Leaks bot shouldn't run JSC tests
1937         https://bugs.webkit.org/show_bug.cgi?id=140877
1938
1939         Reviewed by Darin Adler.
1940
1941         Shaves off 48 minutes of time.
1942
1943         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1944         (TestLeaksFactory): Slim down the leaks queue.
1945
1946         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1947         * Scripts/webkitpy/port/ios.py:
1948         (IOSSimulatorPort.print_leaks_summary):
1949         * Scripts/webkitpy/port/mac.py:
1950         (MacPort.print_leaks_summary):
1951         Don't yell when leaks are detected.
1952
1953 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
1954
1955         Refactor run-javascriptcore-tests
1956         https://bugs.webkit.org/show_bug.cgi?id=140824
1957
1958         Reviewed by Darin Adler.
1959
1960         Separated mozilla, stress test code paths and
1961         determining skipped mozilla tests into subroutines.
1962
1963         * Scripts/run-javascriptcore-tests:
1964         (runMozillaTests):
1965         (runJSCStressTests):
1966         (defaultJsDriverArgsForMozillaTests):
1967
1968 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
1969
1970         [buildbot] Fix grammar of TestWithFailureCount
1971         https://bugs.webkit.org/show_bug.cgi?id=140884
1972
1973         Reviewed by Alexey Proskuryakov.
1974
1975         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1976         (TestWithFailureCount):
1977         (TestWithFailureCount.commandComplete):
1978         (TestWithFailureCount.getText2):
1979         (RunUnitTests):
1980         (RunPythonTests):
1981         (RunPerlTests):
1982         (RunLLINTCLoopTests):
1983         (Run32bitJSCTests):
1984         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1985         (RunLLINTCLoopTestsTest.test_failure):
1986         (Run32bitJSCTestsTest.test_failure):
1987         (RunUnitTestsTest.assertFailures):
1988
1989 2015-01-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1990
1991         Unreviewed. Moving myself to the committer section.
1992
1993         * Scripts/webkitpy/common/config/contributors.json:
1994
1995 2015-01-26  Michael Catanzaro  <mcatanzaro@igalia.com> and Carlos Garcia Campos  <cgarcia@igalia.com>
1996
1997         [GTK] gtkdoc does not appear in DevHelp
1998         https://bugs.webkit.org/show_bug.cgi?id=139369
1999
2000         Reviewed by Philippe Normand.
2001
2002         * gtk/generate-gtkdoc: Create the generators in the main function
2003         and use them to get the local cross renference dependencies. Also
2004         pass the generator module name to webkitdom.write_doc_files().
2005         (get_gtkdoc_module_paths): Receive a list of local cross reference
2006         dependencies.
2007         (get_generator_for_config): Set the main_sgml_file property of the
2008         GtkDoc object from the configuration file.
2009         (generate_documentation): Generate the documentation for the given
2010         generator.
2011         (generate_documentation_for_config): Deleted.
2012         * gtk/manifest.txt.in: Expect the API version in the gtkdoc filenames.
2013         * gtk/webkitdom.py:
2014         (write_doc_files): Receive the module name used to build the
2015         -sections.txt filename.
2016
2017 2015-01-26  Commit Queue  <commit-queue@webkit.org>
2018
2019         Unreviewed, rolling out r179107.
2020         https://bugs.webkit.org/show_bug.cgi?id=140880
2021
2022         The GCC in the bots doesn't support the AsyncTask
2023         implementation (Requested by KaL on #webkit).
2024
2025         Reverted changeset:
2026
2027         "[GTK] Enable IndexedDB"
2028         https://bugs.webkit.org/show_bug.cgi?id=98932
2029         http://trac.webkit.org/changeset/179107
2030
2031 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
2032
2033         [EFL] Bump libseccomp version to 2.1.1
2034         https://bugs.webkit.org/show_bug.cgi?id=140357
2035
2036         Reviewed by Gyuyoung Kim.
2037
2038         * efl/jhbuild.modules:
2039
2040 2015-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2041
2042         [GTK] Enable IndexedDB
2043         https://bugs.webkit.org/show_bug.cgi?id=98932
2044
2045         Reviewed by Žan Doberšek.
2046
2047         * Scripts/webkitperl/FeatureList.pm: Enable IndexedDB for the GTK port.
2048
2049 2015-01-25  Alexey Proskuryakov  <ap@apple.com>
2050
2051         Would like leaks bot results at build.webkit.org/dashboard
2052         https://bugs.webkit.org/show_bug.cgi?id=122657
2053
2054         Reviewed by Darin Adler.
2055
2056         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2057         Record links provided by buildbot steps. Currently, the dashboard hardcodes more links
2058         than necessary, could use the ones from buildbot in more places.
2059
2060         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2061         (BuildbotQueue): Reflect configuration option for leaks queues.
2062
2063         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2064         Add leaks queues to performance column. First, leaks are about performance indeed,
2065         and second, this is where we have some space to spare.
2066
2067         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2068         (WebKitBuildbot): Added Yosemite Leaks queue, which was sitting neglected for at
2069         least a year.
2070
2071         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2072         (table.queue-grid td): Moved height from queue-view - we can now have more than one
2073         queue view per cell. The heigt is needed to avoid ugly overlapping while loading
2074         results - once the results are loaded, all rows are currently higher than that.
2075
2076         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
2077         (.leaks-popover): Added.
2078
2079         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
2080         Added.
2081
2082         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
2083         Load BuildbotLeaksQueueView.js.
2084
2085 2015-01-25  peavo@outlook.com  <peavo@outlook.com>
2086
2087         [Win] Add WebKit message loop interface.
2088         https://bugs.webkit.org/show_bug.cgi?id=140857
2089
2090         Reviewed by Brent Fulgham.
2091
2092         Added message loop interface which will run the message loop,
2093         and perform required tasks (like calling CFRunLoopRunInMode)
2094         on each iteration of the loop.
2095
2096         * WinLauncher/WinMain.cpp:
2097         (wWinMain): Use new message loop interface.
2098
2099 2015-01-24  Dan Bernstein  <mitz@apple.com>
2100
2101         update-webkit’s --internal option is unused
2102         https://bugs.webkit.org/show_bug.cgi?id=140861
2103
2104         Reviewed by Anders Carlsson.
2105
2106         * Scripts/update-webkit: Removed the option.
2107
2108 2015-01-24  Brent Fulgham  <bfulgham@apple.com>
2109
2110         DumpRenderTree needs to run with Windows native controls on Windows
2111         https://bugs.webkit.org/show_bug.cgi?id=25592
2112
2113         Reviewed by Anders Carlsson.
2114
2115         * DumpRenderTree/win/DumpRenderTree.cpp:
2116         (resetWebPreferencesToConsistentValues): Tell DRT to use native controls.
2117         (prepareConsistentTestingEnvironment): Ditto.
2118
2119 2015-01-23  David Kilzer  <ddkilzer@apple.com>
2120
2121         test-webkitpy: webkitpy.tool.commands.earlywarningsystem_unittest.EarlyWarningSystemTest.test_ewses fails on EFL, GTK, Win ports
2122         <http://webkit.org/b/140787>
2123
2124         Reviewed by Daniel Bates.
2125
2126         * Scripts/webkitpy/port/ios.py:
2127         (IOSPort.determine_full_port_name): Instead of checking the type
2128         of the current host, test if /usr/bin/xcrun exists before trying
2129         to use it.
2130
2131 2015-01-23  Csaba Osztrogonác  <ossy@webkit.org>
2132
2133         Fix the false positive build failures on the Windows buildbots
2134         https://bugs.webkit.org/show_bug.cgi?id=140819
2135
2136         Reviewed by Brent Fulgham.
2137
2138         Increase the build timeout (without producing output) to 2 hours for Windows bots,
2139         the default 20 minutes is enough for others since they produce output during the build.
2140
2141         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2142         (BuildFactory.__init__):
2143
2144 2015-01-23  Brent Fulgham  <bfulgham@apple.com>
2145
2146         [Win] Teach WebKit to provide IAccessible2 'get_language' and access AXLanguage
2147         https://bugs.webkit.org/show_bug.cgi?id=140839
2148
2149         Reviewed by Dean Jackson.
2150
2151         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2152         (AccessibilityUIElement::language): Retrieve the 'language' BSTR
2153         from the IA2Locale structure and pass it to DRT.
2154
2155 2015-01-23  Brent Fulgham  <bfulgham@apple.com>
2156
2157         [Win] Update DRT Accessibility implementation to better match Mac.
2158         https://bugs.webkit.org/show_bug.cgi?id=140830
2159
2160         Reviewed by Dean Jackson.
2161
2162         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2163         (AccessibilityUIElement::titleUIElement):
2164         (AccessibilityUIElement::parentElement):
2165         (convertToDRTLabel):
2166         (AccessibilityUIElement::role):
2167         (AccessibilityUIElement::title):
2168         (AccessibilityUIElement::description):
2169         (AccessibilityUIElement::stringValue):
2170         (AccessibilityUIElement::helpText):
2171         (AccessibilityUIElement::isFocused):
2172
2173 2015-01-23  Sergio Villar Senin  <svillar@igalia.com>
2174
2175         REGRESSION: run-perf-tests --profiler= seems to have broken
2176         https://bugs.webkit.org/show_bug.cgi?id=113528
2177
2178         Reviewed by Daniel Bates.
2179
2180         The problem is that "perf --record" (or the equivalent call for
2181         other profilers) is never called whenever there is a wrapper
2182         option in the port. We should inject the profiler call first
2183         (should it exists) and then use the port wrapper.
2184
2185         * Scripts/webkitpy/port/driver.py:
2186         (Driver._command_wrapper):
2187         * Scripts/webkitpy/port/driver_unittest.py:
2188         (DriverTest.test_profiler_and_wrapper): New unit test.
2189
2190 2015-01-22  David Kilzer  <ddkilzer@apple.com>
2191
2192         configure-xcode-for-ios-development needs to import webkitdirs.pm
2193         <http://webkit.org/b/140704>
2194
2195         Fixes the following runtime error:
2196
2197             Undefined subroutine &main::exitStatus called at ./Tools/Scripts/configure-xcode-for-ios-development line 167.
2198
2199         * Scripts/configure-xcode-for-ios-development: Add back code to
2200         import webkitdirs.pm for the exitStatus() method.  Not sure why
2201         I removed it before patch review.
2202
2203 2015-01-22  Timothy Horton  <timothy_horton@apple.com>
2204
2205         REGRESSION (r178847): Yosemite 32-bit bot isn't doing any work
2206         https://bugs.webkit.org/show_bug.cgi?id=140795
2207
2208         Reviewed by Jon Honeycutt.
2209
2210         * BuildSlaveSupport/build.webkit.org-config/config.json:
2211         r178847 accidentally remove the scheduler for this bot. Re-add it to the
2212         Yosemite scheduler.
2213
2214 2015-01-22  Brent Fulgham  <bfulgham@apple.com>
2215
2216         [Win] Expose missing editing features through WebView interface
2217         https://bugs.webkit.org/show_bug.cgi?id=140773
2218         <rdar://problem/19565421>
2219
2220         Reviewed by Dean Jackson.
2221
2222         Connect the various WebView editing delegate methods to our
2223         test infrastructure. Also prefer _bstr_t to raw BSTR types
2224         to simplify life cycle management.
2225
2226         * DumpRenderTree/win/DumpRenderTree.cpp:
2227         (resetWebViewToConsistentStateBeforeTesting):
2228         * DumpRenderTree/win/EditingDelegate.cpp:
2229         (EditingDelegate::QueryInterface):
2230         (dumpPath):
2231         (dump):
2232         (EditingDelegate::shouldBeginEditingInDOMRange):
2233         (EditingDelegate::shouldEndEditingInDOMRange):
2234         (EditingDelegate::shouldInsertNode):
2235         (EditingDelegate::shouldInsertText):
2236         (EditingDelegate::shouldDeleteDOMRange):
2237         (EditingDelegate::shouldChangeSelectedDOMRange):
2238         (EditingDelegate::shouldApplyStyle):
2239         (EditingDelegate::shouldChangeTypingStyle):
2240         (EditingDelegate::doPlatformCommand):
2241         (EditingDelegate::webViewDidBeginEditing):
2242         (EditingDelegate::webViewDidChange):
2243         (EditingDelegate::webViewDidEndEditing):
2244         (EditingDelegate::webViewDidChangeTypingStyle):
2245         (EditingDelegate::webViewDidChangeSelection):
2246         (EditingDelegate::checkSpellingOfString):
2247         (EditingDelegate::onNotify):
2248         * DumpRenderTree/win/EditingDelegate.h:
2249
2250 2015-01-22  Ryosuke Niwa  <rniwa@webkit.org>
2251
2252         Add a build flag for ES6 class syntax
2253         https://bugs.webkit.org/show_bug.cgi?id=140760
2254
2255         Reviewed by Michael Saboff.
2256
2257         * Scripts/webkitperl/FeatureList.pm:
2258
2259 2015-01-22  Daniel Bates  <dabates@apple.com>
2260
2261         [iOS] run-webkit-tests --ios-sim dies with an error; fails to parse Apple Internal
2262         runtime in simctl output
2263         https://bugs.webkit.org/show_bug.cgi?id=140751
2264
2265         Reviewed by David Kilzer.
2266
2267         Following the fix for <rdar://problem/19444383>, run-webkit-tests --ios-sim dies
2268         with an error because it does not know how to parse the output of the simctl tool
2269         to identify an Apple Internal runtime.
2270
2271         * Scripts/webkitpy/xcode/simulator.py:
2272         (Runtime.__init__): Add parameter is_internal_runtime (defaults to False).
2273         (Runtime.__eq__): Take is_internal_runtime when comparing two Runtime objects for equality.
2274         (Runtime.__repr__): Update printable representation of Runtime object to indicate whether
2275         the runtime is an internal runtime.
2276         (Simulator): Update regular expressions runtime_re and version_re to match an internal runtime.
2277         (Simulator._parse_runtimes): Pass is_internal_runtime to the Runtime constructor with the
2278         appropriate value.
2279         (Simulator._parse_devices): Pass argument is_internal_runtime to Simulator.runtime() so that
2280         it updates the appropriate Runtime object.
2281         (Simulator.runtime): Added optional parameter, is_internal_runtime. Modified to support
2282         looking up a Runtime object for an internal runtime.
2283
2284 2015-01-22  Alexey Proskuryakov  <ap@apple.com>
2285
2286         LeaksViewer doesn't show recent builds if there are less than 10
2287         https://bugs.webkit.org/show_bug.cgi?id=140716
2288
2289         Reviewed by Tim Horton.
2290
2291         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
2292
2293 2015-01-22  Lucas Forschler  <lforschler@apple.com>
2294
2295         Add Apple build slaves.
2296         Fixed text alignment for slave list.
2297         
2298         Unreviewed.
2299         
2300         * BuildSlaveSupport/build.webkit.org-config/config.json:
2301
2302 2015-01-21  Lucas Forschler  <lforschler@apple.com>
2303
2304         Teach build.webkit.org about bot308 and bot309.
2305         
2306         Unreviewed.
2307         
2308         * BuildSlaveSupport/build.webkit.org-config/config.json:
2309
2310 2015-01-21  Lucas Forschler  <lforschler@apple.com>
2311
2312         Add two Apple Mavericks slaves.
2313         
2314         Unreviewed.
2315         
2316         * BuildSlaveSupport/build.webkit.org-config/config.json:
2317
2318 2015-01-21  Daniel Bates  <dabates@apple.com>
2319
2320         Add iOS WebKit1 TestExpectation file
2321         https://bugs.webkit.org/show_bug.cgi?id=140739
2322
2323         Reviewed by David Kilzer.
2324
2325         Teach run-webkit-tests to look for iOS WebKit1-specific test results and
2326         expectations in directory LayoutTests/platform/ios-simulator-wk1.
2327
2328         * Scripts/webkitpy/port/ios.py:
2329         (IOSSimulatorPort.default_baseline_search_path):
2330
2331 2015-01-21  David Kilzer  <ddkilzer@apple.com>
2332
2333         [iOS] Update configure-xcode-for-ios-development to copy missing headers to iphoneos SDK
2334         <http://webkit.org/b/140704>
2335
2336         Reviewed by Daniel Bates.
2337
2338         * Scripts/configure-xcode-for-ios-development:
2339         - Update copyright.
2340         - Remove FIXME addressed by r178709.
2341         - Call copyMissingHeadersToIPhoneOSSDKIfNeeded().
2342         (copyMissingHeadersToIPhoneOSSDKIfNeeded): Add method to copy
2343         missing headers from iphonesimulator SDK to iphoneos SDK.
2344         (sdkDirectory): Add method that returns SDK directory.
2345         (sdkPlatformDirectory): Extract method from
2346         xcodeSDKSpecificationsPath() that returns SDK platform
2347         directory.
2348         (xcodeSDKSpecificationsPath): Update to use
2349         sdkPlatformDirectory().
2350
2351 2015-01-21  Alexey Proskuryakov  <ap@apple.com>
2352
2353         https://build.webkit.org/dashboard/metrics.html fails because of ios-ews
2354         https://bugs.webkit.org/show_bug.cgi?id=140731
2355
2356         Reviewed by Tim Horton.
2357
2358         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2359         (Analyzer.prototype._analyzeAllBubblesPerformance): Corrected a typo.
2360
2361 2015-01-21  Brent Fulgham  <bfulgham@apple.com>
2362
2363         [Win] eventSender does not support scalePageBy
2364         https://bugs.webkit.org/show_bug.cgi?id=140726
2365         <rdar://problem/19549865>
2366
2367         Reviewed by Dean Jackson.
2368
2369         * DumpRenderTree/win/EventSender.cpp:
2370         (scalePageByCallback): Provide implementation using new WebView method.
2371
2372 2015-01-21  Lucas Forschler  <lforschler@apple.com>
2373
2374         Remove Apple Mountain Lion Build & Test slaves.
2375         
2376         Unreviewed.
2377
2378         * BuildSlaveSupport/build.webkit.org-config/config.json:
2379
2380 2015-01-21  Csaba Osztrogonác  <ossy@webkit.org>
2381
2382         Remove ENABLE(INSPECTOR) ifdef guards
2383         https://bugs.webkit.org/show_bug.cgi?id=140668
2384
2385         Reviewed by Darin Adler.
2386
2387         * DumpRenderTree/mac/TestRunnerMac.mm:
2388         (TestRunner::showWebInspector):
2389         (TestRunner::closeWebInspector):
2390         (TestRunner::evaluateInWebInspector):
2391         * Scripts/webkitperl/FeatureList.pm:
2392         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2393         (WTR::TestRunner::showWebInspector):
2394         (WTR::TestRunner::closeWebInspector):
2395         (WTR::TestRunner::evaluateInWebInspector):
2396         * WebKitTestRunner/TestInvocation.cpp:
2397         (WTR::TestInvocation::invoke):
2398
2399 2015-01-20  Alexey Proskuryakov  <ap@apple.com>
2400
2401         Update build.webkit.org/dashboard to match current Mac queues.
2402
2403         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion.png: Removed.
2404         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion@2x.png: Removed.
2405         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png: Removed.
2406         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png: Removed.
2407         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2408         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2409         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2410         (table.queue-grid tr.platform.mac-os-x-mountain-lion img.logo): Deleted.
2411         (table.queue-grid tr.platform.mac-os-x-lion img.logo): Deleted.
2412
2413 2015-01-20  Lucas Forschler  <lforschler@apple.com>
2414
2415         Update Apple MountainLion Leaks slave to Yosemite
2416         Update Apple MountainLion Release (32-bit) Build slave to Yosemite
2417         
2418         Unreviewed.
2419
2420         * BuildSlaveSupport/build.webkit.org-config/config.json:
2421
2422 2015-01-20  Lucas Forschler  <lforschler@apple.com>
2423
2424         Update LeaksViewer from MountainLion to Yosemite
2425         
2426         Reviewed by Alexey Proskuryakov.
2427
2428         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
2429         (LeaksViewer._displayURLPrompt):
2430
2431 2015-01-20  Jake Nielsen  <jacob_nielsen@apple.com>
2432
2433         Fix EWS python unit tests and address code comments as per 140476
2434         https://bugs.webkit.org/show_bug.cgi?id=140637
2435
2436         Reviewed by David Kilzer.
2437
2438         * Scripts/webkitpy/port/base.py:
2439         (Port):
2440         (Port.__init__):
2441         Adds DEFAULT_ARCHITECTURE member.
2442         (Port.architecture):
2443         Removes architecture member and instead uses
2444         self.get_option('architecture'). Also removes redundant architecture
2445         method.
2446         (Port.set_architecture):
2447         Adds a setter for the architecture variable to be able to set a flag
2448         upon modification.
2449         (Port.test_configuration):
2450         Uses self.architecture() instead of self._architecture.
2451         * Scripts/webkitpy/port/ios.py:
2452         Overrides DEFAULT_ARCHITECTURE.
2453         (IOSPort):
2454         (IOSPort.determine_full_port_name):
2455         Uses subprocess.check_output instead of Popen. Uses rstrip instead of
2456         strip. Fixes regex to not match arbitrary characters after the
2457         relevent digits are matched.
2458         (IOSPort.__init__):
2459         Removes old _architecture defaulting strategy.
2460         (IOSPort._build_driver_flags):
2461         Uses self.architecture() instead of self._architecture.
2462         (IOSSimulatorPort):
2463         Overrides DEFAULT_ARCHITECTURE.
2464         (IOSSimulatorPort.__init__):
2465         Removes old _architecture defaulting strategy.
2466         * Scripts/webkitpy/port/mac.py:
2467         (MacPort):
2468         Overrides DEFAULT_ARCHITECTURE.
2469         (MacPort.__init__):
2470         Removes old _architecture defaulting strategy.
2471         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2472         (AbstractEarlyWarningSystem.run_command):
2473         Checks the did_override_architecture flag to determine whether to add
2474         the --architecture option.
2475         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2476         Uses ews.architecture rather than trying to discern the correct
2477         architecture using a port object.
2478         (EarlyWarningSystemTest._default_expected_logs):
2479         * Scripts/webkitpy/tool/commands/queues.py:
2480         Removes use of optparse, and removes the import statement.
2481         (AbstractQueue.__init__):
2482         (PatchProcessingQueue.begin_work_queue):
2483
2484 2015-01-20  Sam Weinig  <sam@webkit.org>
2485
2486         Attempt to fix Mountain Lion and EFL tests.
2487
2488         * WebKitTestRunner/TestController.cpp:
2489         (WTR::TestController::initialize):
2490         Disable Process-per-tab and network process on Mountain Lion and EFL.
2491
2492 2015-01-20  Darin Adler  <darin@apple.com>
2493
2494         Remove SVGElementInstanceList, m_instanceUnderMouse, DUMP_INSTANCE_TREE, DUMP_SHADOW_TREE
2495         https://bugs.webkit.org/show_bug.cgi?id=140679
2496
2497         Reviewed by Anders Carlsson.
2498
2499         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
2500         Removed a reference to SVGElementInstanceList.
2501
2502 2015-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
2503
2504         [GTK] WebViewTest should prohibit overriding initializeWebExtensions()
2505         https://bugs.webkit.org/show_bug.cgi?id=140028
2506
2507         Reviewed by Carlos Garcia Campos.
2508
2509         This won't work as expected, since this function is called before the
2510         WebViewTest constructor completes.
2511
2512         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
2513
2514 2015-01-20  David Kilzer  <ddkilzer@apple.com>
2515
2516         configure-xcode-for-ios-development needs to update iPhoneOS SDK
2517         <http://webkit.org/b/140661>
2518
2519         Reviewed by Daniel Bates.
2520
2521         * Scripts/configure-xcode-for-ios-development: Add for() loop to
2522         run createXcodeSpecificationFilesForSDKIfNeeded() for both
2523         "iphoneos" and "iphonesimulator" SDKs.
2524         (createXcodeSpecificationFilesForSDKIfNeeded): Extracted from
2525         the main body of the script.
2526
2527 2015-01-20  Tomas Popela  <tpopela@redhat.com>
2528
2529         [GTK] Add API to set the web view editable into WebKit2 GTK+ API
2530         https://bugs.webkit.org/show_bug.cgi?id=139443
2531
2532         Reviewed by Carlos Garcia Campos.
2533
2534         Create the new test cases for setting the editable property on the web
2535         view and on the contenteditable enabled document. Also rework the
2536         current tests that are expecting that the web view is editable.
2537
2538         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
2539         (loadTestHtml):
2540         (testWebViewEditorCutCopyPasteNonEditable):
2541         (testWebViewEditorCutCopyPasteEditable):
2542         (testWebViewEditorSelectAllNonEditable):
2543         (testWebViewEditorSelectAllEditable):
2544         (runEditorEditableCutTests):
2545         (testWebViewEditorEditableOnNonEditable):
2546         (testWebViewEditorEditableOnContentEditable):
2547         (testWebViewEditorNonEditable):
2548         (beforeAll):
2549         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2550         (WebViewTest::isEditable):
2551         (WebViewTest::setEditable):
2552
2553 2015-01-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2554
2555         [GTK] Add an option to create WebKitWebView snapshots with transparent background
2556         https://bugs.webkit.org/show_bug.cgi?id=140617
2557
2558         Reviewed by Gustavo Noronha Silva.
2559
2560         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2561         (testWebViewSnapshot): Check that the same snapshot with
2562         transparent background is different than the default one filled
2563         with white.
2564
2565 2015-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2566
2567         [GTK] Add API to change the WebKitWebView background color
2568         https://bugs.webkit.org/show_bug.cgi?id=140610
2569
2570         Reviewed by Gustavo Noronha Silva.
2571
2572         Add --bg-color command line option to MiniBrowser to be able to
2573         manually test the API passing any RGBA color to MiniBrowser.
2574         Also add a simple unit test to check that getting and setting
2575         colors from the API point of view.
2576
2577         * MiniBrowser/gtk/BrowserWindow.c:
2578         (browser_window_set_background_color):
2579         * MiniBrowser/gtk/BrowserWindow.h:
2580         * MiniBrowser/gtk/main.c:
2581         (createBrowserWindow):
2582         (parseBackgroundColor):
2583         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2584         (testWebViewBackgroundColor):
2585         (beforeAll):
2586
2587 2015-01-19  Brent Fulgham  <bfulgham@apple.com>
2588
2589         [Win] Layout Test fast/xmlhttprequest/xmlhttprequest-no-file-access.html is failing
2590         https://bugs.webkit.org/show_bug.cgi?id=140665
2591
2592         Reviewed by Brian Burg.
2593
2594         * DumpRenderTree/win/UIDelegate.cpp:
2595         (UIDelegate::webViewAddMessageToConsole): Correct string search and concatenation to
2596         match expected test output.
2597
2598 2015-01-19  Benjamin Poulain  <bpoulain@apple.com>
2599
2600         Remove the support for custom suffixes on ChangeLog
2601         https://bugs.webkit.org/show_bug.cgi?id=140648
2602
2603         Reviewed by David Kilzer.
2604
2605         Custom suffixes were used for the iOS branch of WebKit.
2606         Now that everything is opensource, there is no need for it.
2607
2608         * Scripts/VCSUtils.pm:
2609         (changeLogSuffix): Deleted.
2610         (changeLogFileName): Deleted.
2611         * Scripts/commit-log-editor:
2612         * Scripts/prepare-ChangeLog:
2613         (getLatestChangeLogs):
2614         (generateNewChangeLogs):
2615         (generateFileList):
2616         * Scripts/resolve-ChangeLogs:
2617         (findChangeLog):
2618
2619 2015-01-19  Timothy Horton  <timothy_horton@apple.com>
2620
2621         Adjust naming of action menu SPI
2622         https://bugs.webkit.org/show_bug.cgi?id=140644
2623         <rdar://problem/19448129>
2624
2625         Reviewed by Brian Weinstein.
2626
2627         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
2628         (-[ActionMenusTestWKView runMenuSequenceAtPoint:preDidCloseMenuHandler:]):
2629         (TestWebKitAPI::TEST):
2630
2631 2015-01-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2632
2633         [GTK] Generate the make dist manifest from a CMake template file
2634         https://bugs.webkit.org/show_bug.cgi?id=139387
2635
2636         Reviewed by Martin Robinson.
2637
2638         Remove the code that performs variable substitution on manifest.txt.
2639         Replace the custom variables used in that file with CMake variables.
2640
2641         * gtk/make-dist.py:
2642         (Manifest.add_directory):
2643         (Manifest.get_full_source_path):
2644         (Manifest.process_line):
2645         (Manifest.resolve_variables): Deleted.
2646         (Manifest.get_full_tarball_path): Deleted.
2647         * gtk/manifest.txt.in: Renamed from Tools/gtk/manifest.txt.
2648
2649 2015-01-19  Brent Fulgham  <bfulgham@apple.com>
2650
2651         [Win] Correct merge error in last commit.
2652
2653         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2654         (findAccessibleObjectById): Undo accidental paste made during landing.
2655
2656 2015-01-19  Brent Fulgham  <bfulgham@apple.com>
2657
2658         [Win] Periodic failure in DumpRenderTree related to WebActionPropertyBag::Read
2659         https://bugs.webkit.org/show_bug.cgi?id=139906
2660
2661         Reviewed by Dean Jackson.
2662
2663         WebKit on Windows was creating uninitialized VARIANT structures, then attempting
2664         to use them. This patch fixes that.
2665
2666         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2667         (findAccessibleObjectById):
2668         (AccessibilityController::focusedElement):
2669         (logEventProc):
2670         (notificationListenerProc):
2671         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2672         (AccessibilityUIElement::getChildAtIndex):
2673         (AccessibilityUIElement::titleUIElement):
2674         (self):
2675         (AccessibilityUIElement::role):
2676         (AccessibilityUIElement::valueDescription):
2677         (accessibilityState):
2678         (AccessibilityUIElement::isChecked):
2679         * DumpRenderTree/win/DumpRenderTree.cpp:
2680         (dumpFrameScrollPosition):
2681         (dumpFramesAsText):
2682         * DumpRenderTree/win/PolicyDelegate.cpp:
2683         (PolicyDelegate::decidePolicyForNavigationAction):
2684         * DumpRenderTree/win/UIDelegate.cpp:
2685         (UIDelegate::exceededDatabaseQuota):
2686         * WinLauncher/Common.cpp:
2687         (setWindowText):
2688
2689 2015-01-19  Dean Jackson  <dino@apple.com>
2690
2691         Add "override" to fix the build with newer clangs.
2692
2693         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
2694         (TestWebKitAPI::CalculationDeletionTestNode::operator==):
2695
2696 2015-01-19  David Kilzer  <ddkilzer@apple.com>
2697
2698         [iOS] Do not hard-code iphoneos.internal SDK in buildXCodeProject()
2699         <http://webkit.org/b/140623>
2700
2701         Reviewed by Daniel Bates.
2702
2703         * Scripts/build-webkit: Update help for --device switch.
2704         * Scripts/webkitdirs.pm:
2705         (determineXcodeSDK): When passing --device, prefer the internal
2706         iOS SDK if it exists, else fall back to the external iOS SDK.
2707         (buildXCodeProject): Use xcodeSDK() as -sdk argument for
2708         xcodebuild instead of trying to sanitize values.
2709
2710 2015-01-19  Alexey Proskuryakov  <ap@apple.com>
2711
2712         "Unknown option: sharedworkerglobalscopeconstructorsfile" when running bindings tests.
2713         https://bugs.webkit.org/show_bug.cgi?id=140606
2714
2715         Reviewed by Csaba Osztrogonác.
2716
2717         * Scripts/webkitpy/bindings/main.py:
2718         (BindingsTests.generate_supplemental_dependency):
2719         (BindingsTests.main):
2720
2721 2015-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2722
2723         [GTK] [WK2] TestWebKitWebView snapshot fails
2724         https://bugs.webkit.org/show_bug.cgi?id=120404
2725
2726         Reviewed by Žan Doberšek.
2727
2728         Rework the test to make sure the snapshot is always created at the
2729         desired size.
2730
2731         * Scripts/run-gtk-tests:
2732         (TestRunner): Unskip /webkit2/WebKitWebView/snapshot.
2733         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2734         (testWebViewSnapshot): Use a fixed size for the document, and
2735         disable scrollbars to make sure the visible area is always the
2736         WebView size.
2737         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2738         (WebViewTest::showInWindowAndWaitUntilMapped): Add optional width
2739         and height parameters to create the window with a given size.
2740         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
2741
2742 2015-01-18  David Kilzer  <ddkilzer@apple.com>
2743
2744         iOS EWS queue name should be consistent
2745         <http://webkit.org/b/140585>
2746
2747         Reviewed by Daniel Bates.
2748
2749         * Scripts/webkitpy/common/config/ews.json: Rename 'ios-device'
2750         to 'ios'.
2751         * Scripts/webkitpy/common/config/ports.py: Ditto.
2752         (DeprecatedPort.port):
2753         (IOSPort):
2754         * Scripts/webkitpy/port/ios.py: Ditto.
2755         (IOSPort):
2756
2757         * Scripts/webkitpy/port/factory.py:
2758         (PortFactory): Re-order PORT_CLASSES so ios.IOSSimulatorPort
2759         appears before ios.IOSPort.  If this is not done,
2760         `run-webkit-tests --ios-simulator` will get the wrong Port class
2761         (IOSPort instead of IOSSimulatorPort) due to the way that
2762         PortFactory.get() uses prefix matching of <Port>.port_name to
2763         find the correct class to use.
2764
2765 2015-01-18  Alexey Proskuryakov  <ap@apple.com>
2766
2767         build.webkit.org/dashboard: OS X EWS is now on Mavericks
2768         https://bugs.webkit.org/show_bug.cgi?id=140595
2769
2770         Reviewed by Csaba Osztrogonác.
2771
2772         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2773         (BubbleQueueServer):
2774
2775 2015-01-17  David Kilzer  <ddkilzer@apple.com>
2776
2777         Attempt to fix webkitpy tests on Mountain Lion, Mavericks bots
2778
2779         * Scripts/webkitpy/port/ios.py:
2780         (IOSPort): Add 'ios-device-7' to VERSION_FALLBACK_ORDER so that
2781         test-webkitpy doesn't fail since iOS 7.x SDKs are installed on
2782         the Mountain Lion and Mavericks bots.
2783
2784 2015-01-17  David Kilzer  <ddkilzer@apple.com>
2785
2786         Attempt to fix webkitpy tests on GTK Linux ports
2787
2788         * Scripts/webkitpy/port/ios.py:
2789         (IOSPort.determine_full_port_name): Set a sensible default if
2790         not running on a Mac platform or if no iOS SDK is installed.
2791
2792 2015-01-17  Jake Nielsen  <jacob_nielsen@apple.com>
2793
2794         Create iOS-EWS client queue
2795         https://bugs.webkit.org/show_bug.cgi?id=140476
2796
2797         Reviewed by Alexey Proskuryakov.
2798
2799         * EWSTools/start-queue-mac.sh:
2800         Adds call to configure-xcode-for-ios-development for iOS EWS.
2801         * Scripts/webkitpy/common/config/ews.json:
2802         Adds the iOS EWS config entry.
2803         * Scripts/webkitpy/common/config/ports.py:
2804         (DeprecatedPort.port):
2805         Adds IOSPort to the port map.
2806         (IOSPort):
2807         (IOSPort.build_webkit_command):
2808         Adds --sdk=iphoneos to the webkit build command.
2809         * Scripts/webkitpy/port/base.py:
2810         (Port.architecture):
2811         Adds an accessor for the architecture member variable.
2812         * Scripts/webkitpy/port/factory.py:
2813         (PortFactory):
2814         Adds IOSPort to the port class list.
2815         * Scripts/webkitpy/port/ios.py:
2816         Adds the IOSPort to encapsulate iOS-specific things.
2817         (IOSPort):
2818         (IOSPort.determine_full_port_name):
2819         (IOSPort.__init__):
2820         (IOSPort._build_driver_flags):
2821         (IOSPort.operating_system):
2822         * Scripts/webkitpy/tool/commands/download_unittest.py:
2823         Adds the archetecture option to the mock options.
2824         (DownloadCommandsTest._default_options):
2825         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2826         Appends the archetecture option into calls to webkit-patch.
2827         (AbstractEarlyWarningSystem.review_patch):
2828         (AbstractEarlyWarningSystem.run_command):
2829         (AbstractEarlyWarningSystem.load_ews_classes):
2830         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2831         Adds logic to soothe the unittest now that --architecture is being
2832         thrown around everywhere.
2833         (EarlyWarningSystemTest._default_expected_logs):
2834         * Scripts/webkitpy/tool/commands/queues.py:
2835         Adds glue code to ferry the --architecture option around.
2836         (AbstractQueue.__init__):
2837         (PatchProcessingQueue.begin_work_queue):
2838         * Scripts/webkitpy/tool/steps/abstractstep.py:
2839         Adds the archetecture option to all AbstractSteps so that
2840         EarlyWarningSystem doesn't start shoving --architecture into
2841         unsuspecting commands.
2842         (AbstractStep.options):
2843         * Scripts/webkitpy/tool/steps/build.py:
2844         Translates the --architecture option into an ARCHS= format to pass to
2845         build-webkit.
2846         (Build.build):
2847         * Scripts/webkitpy/tool/steps/options.py:
2848         Adds a definition for the --architecture option.
2849         (Options):
2850
2851 2015-01-16  Sam Weinig  <sam@webkit.org>
2852
2853         Add a basic configuration object for WKView
2854         https://bugs.webkit.org/show_bug.cgi?id=140559
2855
2856         Reviewed by Anders Carlsson.
2857
2858         Add tests for WKPageConfigurationRef.
2859
2860         * TestWebKitAPI/PlatformWebView.h:
2861         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2862         * TestWebKitAPI/Tests/WebKit2/WKPageConfiguration.cpp: Added.
2863         (TestWebKitAPI::TEST):
2864         (TestWebKitAPI::didFinishLoadForFrame):
2865         (TestWebKitAPI::setPageLoaderClient):
2866         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2867         (TestWebKitAPI::PlatformWebView::initialize):
2868         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2869
2870 2015-01-16  Myles C. Maxfield  <mmaxfield@apple.com>
2871
2872         WeakPtr functions crash when created with default constructor
2873         https://bugs.webkit.org/show_bug.cgi?id=140479
2874
2875         Reviewed by Andreas Kling.
2876
2877         Add WeakPtr API tests.
2878
2879         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2880         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp: Added.
2881         * TestWebKitAPI/Tests/WTF/Ref.cpp: Update to not use copy constructor.
2882
2883 2015-01-16  Chris Dumez  <cdumez@apple.com>
2884
2885         Regression(r178586): Caused webkitpy.w3c.test_converter_unittest.W3CTestConverterTest.test_convert_prefixed_properties to fail
2886         https://bugs.webkit.org/show_bug.cgi?id=140568
2887
2888         Reviewed by Alexey Proskuryakov.
2889
2890         Fix the script parsing CSSPropertyNames.in to stop splitting lines
2891         on '=' sign. The '=' sign is also used in StyleBuilder parameters:
2892         e.g. "Longhands=background-position-x|background-position-y".
2893         This would confuse the script and treat this as a CSS property:
2894         "background-position-x|background-position-y".
2895
2896         We now split on white space and treat the first string on the line
2897         to be the property name (this is the syntax in this file).
2898
2899         * Scripts/webkitpy/w3c/test_converter.py:
2900         (_W3CTestConverter.__init__):
2901         (_W3CTestConverter.read_webkit_prefixed_css_property_list):
2902
2903 2015-01-16  Daniel Bates  <dabates@apple.com>
2904
2905         REGRESSION (r171968): run-safari --simulator fails to launch Safari on iOS
2906         https://bugs.webkit.org/show_bug.cgi?id=135589
2907
2908         Reviewed by David Kilzer.
2909
2910         Derived from a patch by David Farler.
2911
2912         Following the removal IPhoneSimulatorNotification.pm in <http://trac.webkit.org/changeset/171968>
2913         run-safari --simulator fails to launch Safari on iOS. We need to implement run-safari
2914         in terms of the simctl command line utility.
2915
2916         * Scripts/webkitdirs.pm: Added constant SIMULATOR_DEVICE_STATE_BOOTED.
2917         (eraseIOSSimulatorDevice): Added.
2918         (bootedIOSSimulatorDevice): Added.
2919         (iosSimulatorApplicationsPath): Added.
2920         (installedMobileSafariBundle): Implemented in terms of iosSimulatorApplicationsPath().
2921         (openIOSSimulator): Modified to launch iOS Simulator using OPEN(1).
2922         (quitIOSSimulator): Added.
2923         (iosSimulatorDeviceByName): Modified to find the first simulator device that matches
2924         the specified name and currently selected iOS runtime.
2925         (isIOSSimulatorSystemInstalledApp): Added.
2926         (runIOSWebKitAppInSimulator): Modified to use simctl launch to launch an app in the simulator.
2927         (deleteiOSSimulatorDevice): Deleted.
2928         (loadIPhoneSimulatorNotificationIfNeeded): Deleted.
2929         (installAndLaunchIOSWebKitAppInSimulator): Deleted.
2930
2931 2015-01-16  Alex Christensen  <alex.christensen@flexsim.com>
2932
2933         Resurrect the WinCairo bot.
2934         https://bugs.webkit.org/show_bug.cgi?id=139908
2935
2936         Reviewed by Csaba Osztrogonác.
2937
2938         * BuildSlaveSupport/build.webkit.org-config/config.json:
2939         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2940         (appendCustomBuildFlags):
2941         * BuildSlaveSupport/test-result-archive:
2942         (archiveTestResults):
2943         Add WinCairo buildbot.
2944
2945 2015-01-16  Chris Dumez  <cdumez@apple.com>
2946
2947         webkit-patch should auto-install the keyring python module
2948         https://bugs.webkit.org/show_bug.cgi?id=140547
2949
2950         Reviewed by David Kilzer.
2951
2952         Auto-install the keyring python module. This is the module that
2953         webkit-patch uses for cross-platform access to the keyring
2954         service.
2955
2956         Without this module, if the password if not in the keychain,
2957         webkit-patch will keep asking for your username / password and
2958         never remember them.
2959
2960         * Scripts/webkitpy/common/net/credentials.py:
2961         * Scripts/webkitpy/thirdparty/__init__.py:
2962         (AutoinstallImportHook.find_module):
2963         (AutoinstallImportHook._install_keyring):
2964
2965 2015-01-15  Csaba Osztrogonác  <ossy@webkit.org>
2966
2967         Remove ENABLE(SQL_DATABASE) guards
2968         https://bugs.webkit.org/show_bug.cgi?id=140434
2969
2970         Reviewed by Darin Adler.
2971
2972         * Scripts/webkitperl/FeatureList.pm:
2973
2974 2015-01-15  Daniel Bates  <dabates@apple.com>
2975
2976         [iOS] REGRESSION (r174642): DumpRenderTree.app test may dump result twice
2977         https://bugs.webkit.org/show_bug.cgi?id=139685
2978         <rdar://problem/19281317>
2979
2980         Reviewed by Simon Fraser.
2981
2982         Fixes an issue where a test in DumpRenderTree.app may dump its result twice. In particular,
2983         the test LayoutTests/fast/dom/gc-10.html may dump its result twice.
2984
2985         Following <http://trac.webkit.org/changeset/174642>, we dump the test result asynchronously
2986         as opposed to synchronously. So, the WebThread or the main thread may perform other tasks
2987         before DRT dumps the output of a test. In particular, the WebThread may start a new page
2988         load (say, as a result of continued JavaScript execution), which will ultimately lead to
2989         dumping the test result again. Instead we want DRT to dump the test result synchronously
2990         such that we capture the state of the web page either when the page is loaded or when
2991         window.testRunner.notifyDone() is called.
2992
2993         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
2994         (createBitmapContextFromWebView): Moved logic to re-enable tile painting and update the
2995         state of the display from here to updateDisplay(). Added call to -[CATransaction flush] to
2996         flush CA transactions to the window.
2997         * DumpRenderTree/mac/DumpRenderTree.mm:
2998         (updateDisplay): Added iOS-specific code to update tiles and tell WebKit to flush
2999         compositing changes to ensure that we have up-to-date tile content for a pixel/ref-test.
3000         (dump): Renamed; formerly named dumpTestResults().
3001         (displayWebView): Removed outdated FIXME comment. Added FIXME comment to investigate
3002         enabling repaint support on iOS.
3003         (-[DumpRenderTree _deferDumpToMainThread]): Deleted.
3004         (-[DumpRenderTree _waitForWebThreadThenDump]): Deleted.
3005         (dumpTestResults): Deleted.
3006
3007 2015-01-15  Brent Fulgham  <bfulgham@apple.com>
3008
3009         [Win] Miscellaneous DRT fixes
3010         https://bugs.webkit.org/show_bug.cgi?id=116562
3011
3012         Reviewed by Tim Horton.
3013
3014         While investigating the cause of several Windows crashes, I found:
3015         (1) Messy conversions to and from BSTR types
3016         (2) Weird mixes of wide-string and narrow string conversions
3017         (3) Passing nullptr to some CoreFoundation routines that do not
3018             permit null arguments.
3019         (4) Commands to link the executable to the VS2005 runtime.
3020
3021         This patch cleans up these issues to improve DRT reliability on
3022         Windows.
3023
3024         * DumpRenderTree/cg/ImageDiffCG.cpp:
3025         (main): Get rid of VS2005 runtime linking.
3026         * DumpRenderTree/win/DumpRenderTree.cpp:
3027         (urlSuitableForTestResult): Protect against being asked
3028         to process an empty URL.
3029         (dumpHistoryItem): Do BSTR string building using _bstr_t, rather
3030         than converting to/from wchar_t buffers.
3031         (runTest): Simplify string and BSTR handling.
3032         (createWebViewAndOffscreenWindow): Ditto.
3033         (main): Get rid of VS2005 runtime linking.
3034         * DumpRenderTree/win/TestRunnerWin.cpp:
3035         (jsStringRefToWString): Simplify code.
3036         (TestRunner::pathToLocalResource):
3037         (TestRunner::setUserStyleSheetLocation):
3038         * TestWebKitAPI/win/main.cpp: Get rid of
3039         VS2005 runtime linking.
3040         * win/DLLLauncher/DLLLauncherMain.cpp:
3041         (wWinMain): Ditto.
3042
3043 2015-01-15  Alexey Proskuryakov  <ap@apple.com>
3044
3045         Stop hardcoding mac-mountainlion in commit queue
3046         https://bugs.webkit.org/show_bug.cgi?id=140492
3047
3048         Reviewed by Anders Carlsson.
3049
3050         Use "mac", not "mac-<platform>". This matches how EWS queues are initialized, and
3051         there should be no change in behavior, because:
3052         1. PatchProcessingQueue converts the name with _new_port_name_from_old() before
3053         using it to create a port object.
3054         2. Although it doesn't convert the name before using DeprecatedPort.port(), it
3055         is actually correct to use "mac" for the name there. We only used to get the expected
3056         behavior with "mac-mountainlion" accidentally, because of a fallback to "mac"
3057         for unknown deprecated port names.
3058
3059         * Scripts/webkitpy/tool/commands/queues.py: (CommitQueue):
3060
3061 2015-01-14  Jake Nielsen  <jacob_nielsen@apple.com>
3062
3063         Create iOS-EWS server queue
3064         https://bugs.webkit.org/show_bug.cgi?id=140473
3065
3066         Reviewed by Benjamin Poulain.
3067
3068         * QueueStatusServer/app.yaml: Updates the SVN version number.
3069         * QueueStatusServer/config/queues.py: Add ios-ews queue.
3070         * QueueStatusServer/model/queues.py:         
3071         (Queue.display_name): Makes sure the display name is pretty!
3072
3073 2015-01-14  Daniel Bates  <dabates@apple.com>
3074
3075         [iOS] run-webkit-tests --ios hangs trying to launch iOS Simulator with unavailable runtime
3076         https://bugs.webkit.org/show_bug.cgi?id=140301
3077         <rdar://problem/19389266>
3078
3079         Reviewed by Jon Honeycutt.
3080
3081         Fixes an issue where run-webkit-tests --ios will hang when trying to launch iOS Simulator
3082         with an unavailable runtime.
3083
3084         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3085         (_set_up_derived_options): Modified to access property Simulator.latest_available_runtime,
3086         which was formerly called Simulator.latest_runtime. Additionally, raise an exception if the
3087         specified runtime cannot be used because it is unavailable.
3088         * Scripts/webkitpy/port/ios.py:
3089         (IOSSimulatorPort.testing_device): Modified to call Simulator.lookup_or_create_device(),
3090         which was formerly named testing_device.
3091         * Scripts/webkitpy/xcode/simulator.py:
3092         (Device.create): Modified to lookup created device by the UDID returned by simctl, which is
3093         more robust than looking up the simulator device by name and runtime. This approach also
3094         avoids returning the wrong device due to <rdar://problem/19444383> (simctl list shows
3095         unavailable runtimes under the same iOS heading it would use to show it as available).
3096         (Simulator.find_device_by_udid): Added.
3097         (Simulator.device): Added optional parameter should_ignore_unavailable_devices (defaults
3098         to False) to ignore devices that are unavailable (say, because their runtime is unavailable).
3099         (Simulator.available_runtimes): Added.
3100         (Simulator.latest_available_runtime): Renamed; formerly named latest_runtime. Take advantage
3101         of the reverse=True argument to sorted() to sort the list of available runtimes such that the
3102         first element of the sorted list is the runtime with the highest version number.
3103         (Simulator.lookup_or_create_device): Renamed; formerly named testing_device.
3104
3105 2015-01-14  Csaba Osztrogonác  <ossy@webkit.org>
3106
3107         Remove WK2 Windows cruft
3108         https://bugs.webkit.org/show_bug.cgi?id=140440
3109
3110         Reviewed by Anders Carlsson.
3111
3112         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp: Removed.
3113         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp: Removed.
3114         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp: Removed.
3115
3116 2015-01-13  Hunseop Jeong  <hs85.jeong@samsung.com>
3117
3118         Fix TestWTF failed in TestWebKitAPI
3119         https://bugs.webkit.org/show_bug.cgi?id=140333
3120
3121         Reviewed by Sam Weinig.
3122
3123         Clear the std::ostringstream before starting test.
3124
3125         * TestWebKitAPI/Tests/WTF/RefLogger.h:
3126         (TestWebKitAPI::DerivedRefLogger::DerivedRefLogger):
3127
3128 2015-01-13  Michael Catanzaro  <mcatanzaro@igalia.com>
3129
3130         TestWebKitWebContext depends on British English spellcheck dictionary
3131         https://bugs.webkit.org/show_bug.cgi?id=140403
3132
3133         Reviewed by Martin Robinson.
3134
3135         Install all English hunspell dictionaries on Fedora and Arch.
3136
3137         * gtk/install-dependencies:
3138
3139 2015-01-13  Michael Catanzaro  <mcatanzaro@igalia.com>
3140
3141         [GTK] install-dependencies should grok dnf
3142         https://bugs.webkit.org/show_bug.cgi?id=140396
3143
3144         Reviewed by Martin Robinson.
3145
3146         Fedora: install dependencies with dnf if yum is not installed.
3147
3148         * gtk/install-dependencies:
3149
3150 2015-01-12  Hunseop Jeong  <hs85.jeong@samsung.com>
3151
3152         [EFL][GTK] Fix build after r178309  
3153         https://bugs.webkit.org/show_bug.cgi?id=140381
3154
3155         Reviewed by Gyuyoung Kim.
3156
3157         * TestWebKitAPI/CMakeLists.txt: Added the API directory
3158
3159 2015-01-11  Sam Weinig  <sam@webkit.org>
3160
3161         Remove support for SharedWorkers
3162         https://bugs.webkit.org/show_bug.cgi?id=140344
3163
3164         Reviewed by Anders Carlsson.
3165
3166         * Scripts/webkitperl/FeatureList.pm:
3167
3168 2015-01-12  Anders Carlsson  <andersca@apple.com>
3169
3170         Make delegates conform to formal delegate protocols
3171         https://bugs.webkit.org/show_bug.cgi?id=140370
3172
3173         Reviewed by Dan Bernstein.
3174
3175         * DumpRenderTree/mac/TestRunnerMac.mm:
3176         (TestRunner::numberOfPendingGeolocationPermissionRequests):
3177         (TestRunner::setGeolocationPermission):
3178
3179 2015-01-10  Michael Catanzaro  <mcatanzaro@igalia.com>
3180
3181         build-webkit: silence output of 'which'
3182         https://bugs.webkit.org/show_bug.cgi?id=140278
3183
3184         Reviewed by Daniel Bates.
3185
3186         Use a more elegent test for the existance of ninja and eclipse.
3187
3188         * Scripts/webkitdirs.pm:
3189         (commandExists): Don't assume the command supports --version
3190         (canUseNinja): Use commandExists()
3191         (canUseEclipse): Use commandExists()
3192
3193 2015-01-09  Sam Weinig  <sam@webkit.org>
3194
3195         Update the output format for run-api-tests
3196         https://bugs.webkit.org/show_bug.cgi?id=140332
3197
3198         Reviewed by Dan Bernstein.
3199
3200         Changes the output format for run-api-tests be a bit simpler (no longer 
3201         indented based on suite, as we were not really using suite very well) but
3202         also include details in the case of failure.
3203
3204         Changes verbose mode to no longer spew out the gtest default printer output,
3205         as the custom printer now includes the failure information.
3206
3207         * Scripts/run-api-tests:
3208         (runTestsBySuite):
3209         (runTest):
3210         Augment the custom gtest printer by replacing the tokens "**PASS**" and "**FAIL**"
3211         with colorized variants and strip out leaks spew (the leaks can be added back using
3212         the new --show-leaks argument).
3213
3214         * TestWebKitAPI/TestsController.cpp:
3215         (TestWebKitAPI::Printer::OnTestPartResult):
3216         (TestWebKitAPI::Printer::OnTestEnd):
3217         (TestWebKitAPI::TestsController::run):
3218         Implement a custom result printer that just prints out the information we want.
3219
3220 2015-01-09  Sam Weinig  <sam@webkit.org>
3221
3222         TestWebKitAPI should print out the lists that fail at the end
3223         https://bugs.webkit.org/show_bug.cgi?id=140329
3224
3225         Reviewed by Tim Horton.
3226
3227         * Scripts/run-api-tests:
3228         (runTestsBySuite):
3229         Print out failures and timeouts in all modes, not just verbose.
3230
3231 2015-01-07  Geoffrey Garen  <ggaren@apple.com>
3232
3233         Make bmalloc work with ASan
3234         https://bugs.webkit.org/show_bug.cgi?id=140194
3235
3236         Reviewed by Mark Lam.
3237
3238         * asan/asan.xcconfig: No need to disable FastMalloc; bmalloc supports
3239         ASan automatically (by forwarding to system malloc at runtime).
3240
3241 2015-01-09  Daniel Bates  <dabates@apple.com>
3242
3243         [iOS] Make DumpRenderTree build with public SDK
3244         https://bugs.webkit.org/show_bug.cgi?id=140311
3245
3246         Reviewed by Sam Weinig.
3247
3248         Use CGRound() instead of the obsolete macro function _ROUNDF_ (defined in
3249         header UIKit/UIMath.h), and std::max() instead of the macro function MAX.
3250         Additionally, remove unused header CoreGraphics/CGFontDB.h.
3251
3252         * DumpRenderTree/mac/DumpRenderTree.mm:
3253         (-[ScrollViewResizerDelegate view:didSetFrame:oldFrame:asResultOfZoom:]):
3254
3255 2015-01-09  Alexey Proskuryakov  <ap@apple.com>
3256
3257         platform/mac-wk2/tiled-drawing/tiled-drawing-scroll-position-page-cache-restoration.html fails on Retina machines
3258         https://bugs.webkit.org/show_bug.cgi?id=140300
3259
3260         Reviewed by Simon Fraser.
3261
3262         * WebKitTestRunner/TestController.cpp:
3263         (WTR::TestController::createOtherPage):
3264         (WTR::TestController::updateWindowScaleForTest):
3265         (WTR::TestController::configureViewForTest):
3266         * WebKitTestRunner/TestController.h:
3267
3268 2015-01-09  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
3269
3270         Unreviewed. Moving myself to the committer section.
3271
3272         * Scripts/webkitpy/common/config/contributors.json:
3273
3274 2015-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
3275
3276         Add a script to check for platform layering violations
3277         https://bugs.webkit.org/show_bug.cgi?id=140248
3278
3279         Reviewed by Darin Adler.
3280
3281         It prints all the cases where files inside platform include
3282         headers that are not in platform directory.
3283
3284         * Scripts/check-for-platform-layering-violations: Added.
3285         (get_platform_headers):
3286         (check_source_file):
3287
3288 2015-01-08  Alexey Proskuryakov  <ap@apple.com>
3289
3290         [Mac WK2] Test snapshots are 1600x1200 on Retina devices
3291         https://bugs.webkit.org/show_bug.cgi?id=139884
3292
3293         Reviewed by Tim Horton.
3294
3295         * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::windowSnapshotImage):
3296         Tell CGWindowListCreateImage to use the correct resolution. I don't really understand
3297         what the "nominal resolution" is, but this appears to work in practice.
3298
3299 2015-01-08  Brent Fulgham  <bfulgham@apple.com>
3300
3301         [Win] DumpRenderTree is always using 800x600 size, even if tests need other size.
3302         https://bugs.webkit.org/show_bug.cgi?id=140256
3303
3304         Reviewed by Anders Carlsson.
3305
3306         * DumpRenderTree/win/DumpRenderTree.cpp:
3307         (resetWebPreferencesToConsistentValues): Drive-by fix of a buffer overrun found while
3308         running with heap validation checks.
3309         (sizeWebViewForCurrentTest): Check both path separators ('/' and '\\') when checking for
3310         the "svg\\W3C-SVG-1.1" test directory.
3311         (removeFontFallbackIfPresent): Use nullptr instead of 0.
3312         * DumpRenderTree/win/TestRunnerWin.cpp:
3313         (TestRunner::clearPersistentUserStyleSheet): Ditto.
3314
3315 2015-01-08  Alexey Proskuryakov  <ap@apple.com>
3316
3317         Follow-up to:  When WebProcess is slow to respond to IPC, that's mistakenly reported as crash
3318         https://bugs.webkit.org/show_bug.cgi?id=140218
3319
3320         * Scripts/webkitpy/port/driver.py: (Driver._check_for_driver_crash_or_unresponsiveness):
3321         Undone an accidental change - check for self.has_crashed() again. This code path
3322         is for ports that don't have a signal handler printing #CRASHED when main process
3323         crashes.
3324
3325         * Scripts/webkitpy/port/driver_unittest.py:
3326         (DriverTest.test_check_for_driver_crash.assert_crash):
3327         (DriverTest.test_check_for_driver_crash):
3328         Updated the tests, all changes are expected.
3329
3330 2015-01-08  Alexey Proskuryakov  <ap@apple.com>
3331
3332         When WebProcess is slow to respond to IPC, that's mistakenly reported as crash
3333         https://bugs.webkit.org/show_bug.cgi?id=140218
3334
3335         Reviewed by Darin Adler.
3336
3337         * Scripts/webkitpy/port/driver.py:
3338         (Driver.__init__): Removed _subprocess_was_unresponsive that was a modifier for
3339         "process crashed" condition. These don't make sense together - it's either a crash
3340         or a timeout, and we should detect those properly at a much lower level.
3341         (Driver.run_test): Ditto.
3342         (Driver._check_for_driver_crash_or_unresponsiveness): Split crash and unresponsiveness
3343         cases.
3344
3345         * WebKitTestRunner/TestController.h:
3346         * WebKitTestRunner/TestController.cpp:
3347         (WTR::TestController::webProcessName): 
3348         (WTR::TestController::processDidCrash):
3349         Factored out hardcoded child process names, as we now use these in two places.
3350
3351         * WebKitTestRunner/TestInvocation.cpp:
3352         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Dump an accurate child
3353         process name, so that it can be sampled (fixes sampling on Mavericks and above).
3354
3355 2015-01-08  Zan Dobersek  <zdobersek@igalia.com>
3356
3357         Reorder my list of email addresses, keeping the Bugzilla address at the
3358         top since Bugzilla and other webkitpy scripts rely on that ordering.
3359
3360         * Scripts/webkitpy/common/config/contributors.json:
3361
3362 2015-01-08  Zan Dobersek  <zdobersek@igalia.com>
3363
3364         Moving myself to the reviewers section and updating
3365         the list of my email addresses.
3366
3367         * Scripts/webkitpy/common/config/contributors.json:
3368
3369 2015-01-07  Michael Catanzaro  <mcatanzaro@igalia.com>
3370
3371         [GTK] Build gtk-doc without gtkdoc-mktmpl
3372         https://bugs.webkit.org/show_bug.cgi?id=140225
3373
3374         Reviewed by Darin Adler.
3375
3376         Stop calling gtkdoc-mktmpl. It's being removed upstream, and since we
3377         don't modify the tmpl files that it generates, it's not doing anything
3378         for us.
3379
3380         * gtk/gtkdoc.py:
3381         (GTKDoc.generate):
3382         (GTKDoc._run_gtkdoc_scangobj):
3383         (GTKDoc._run_gtkdoc_mktmpl): Deleted.
3384
3385 2015-01-07  Gwang Yoon Hwang  <yoon@igalia.com>
3386
3387         [GTK][ThreadedCompositor] Add support for threaded compositor.
3388         https://bugs.webkit.org/show_bug.cgi?id=118265
3389
3390         Reviewed by Martin Robinson.
3391
3392         Added the ENABLE_THREADED_COMPOSITOR feature flag to the cmake and
3393         autotools build systems. The feature is disabled by default.
3394         And remove deprecated the WTF_USE_TILED_BACKING_STORE feature flag
3395         from the feature flags.
3396
3397         * Scripts/webkitperl/FeatureList.pm:
3398
3399 2015-01-07  Daniel Bates  <dabates@apple.com>
3400
3401         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
3402         https://bugs.webkit.org/show_bug.cgi?id=137371
3403
3404         Reviewed by David Kilzer.
3405
3406         Use SPI wrapper headers instead of directly referencing private SPI headers.
3407
3408         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
3409         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3410         * DumpRenderTree/mac/Configurations/Base.xcconfig: Append directory Source/WebKit2/Platform/spi/ios
3411         to the list of iOS header search directories so that we can include header UIKitSPI.h.
3412         * DumpRenderTree/mac/DumpRenderTree.mm:
3413         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3414         * DumpRenderTree/mac/EventSendingController.mm:
3415         * DumpRenderTree/mac/TestRunnerMac.mm:
3416
3417 2015-01-07  Commit Queue  <commit-queue@webkit.org>
3418
3419         Unreviewed, rolling out r178068.
3420         https://bugs.webkit.org/show_bug.cgi?id=140235
3421
3422         Breaks the iOS build (Requested by enrica on #webkit).
3423
3424         Reverted changeset:
3425
3426         "[iOS] Make WebKit2 build with public iOS SDK and more build
3427         fixes for DRT"
3428         https://bugs.webkit.org/show_bug.cgi?id=137371
3429         http://trac.webkit.org/changeset/178068
3430
3431 2015-01-07  Daniel Bates  <dabates@apple.com>
3432
3433         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
3434         https://bugs.webkit.org/show_bug.cgi?id=137371
3435
3436         Reviewed by David Kilzer.
3437
3438         Use SPI wrapper headers instead of directly referencing private SPI headers.
3439
3440         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
3441         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3442         * DumpRenderTree/mac/Configurations/Base.xcconfig: Append directory Source/WebKit2/Platform/spi/ios
3443         to the list of header search directories so that we can include header UIKitSPI.h.
3444         * DumpRenderTree/mac/DumpRenderTree.mm:
3445         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3446         * DumpRenderTree/mac/EventSendingController.mm:
3447         * DumpRenderTree/mac/TestRunnerMac.mm:
3448
3449 2015-01-07  Brent Fulgham  <bfulgham@apple.com>
3450
3451         [Win] Unreviewed test change to improve run reproducibility
3452
3453         * Scripts/webkitpy/port/win.py:
3454         (WinPort.default_child_processes): Run a single DRT instance to help
3455         identify failures caused by earlier test runs.
3456
3457 2015-01-07  Myles C. Maxfield  <mmaxfield@apple.com>
3458
3459         Myles C. Maxfield is a reviewer now
3460         https://bugs.webkit.org/show_bug.cgi?id=140196
3461
3462         Reviewed by Dean Jackson.
3463
3464         * Scripts/webkitpy/common/config/contributors.json:
3465
3466 2015-01-07  Myles C. Maxfield  <mmaxfield@apple.com>
3467
3468         Make webkit-patch try harder to find keychain credentials
3469         https://bugs.webkit.org/show_bug.cgi?id=140170
3470
3471         Reviewed by Ryosuke Niwa.
3472
3473         When the user manually enters a password into webkit-patch, we hand that off to the
3474         Keyring Python module. However, that module creates a generic password entry instead
3475         of an internet password entry. We should look for both kinds.
3476
3477         * Scripts/webkitpy/common/net/credentials.py:
3478         (Credentials._run_security_tool):
3479         (Credentials._credentials_from_keychain):
3480         * Scripts/webkitpy/common/net/credentials_unittest.py:
3481         (test_security_output_parse_entry_not_found):
3482         (_assert_security_call):
3483
3484 2015-01-06  Anders Carlsson  <andersca@apple.com>
3485
3486         Try to fix the Mountain Lion build.
3487
3488         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
3489         (TestWebKitAPI::didGetImageForMatchResult):
3490
3491 2015-01-06  Alexey Proskuryakov  <ap@apple.com>
3492
3493         Debug ASan builds frequently crash in Register::jsValue under DFG::prepareOSREntry
3494         https://bugs.webkit.org/show_bug.cgi?id=140095
3495
3496         Reviewed by Anders Carlsson.
3497
3498         * asan/webkit-asan-ignore.txt: Blacklist a function that gets inlined in release
3499         builds, but not in debug ones.
3500
3501 2015-01-06  Brent Fulgham  <bfulgham@apple.com>
3502
3503         [Win] Extend WinLauncher with support for Page Zoom
3504         https://bugs.webkit.org/show_bug.cgi?id=140152
3505
3506         Reviewed by Anders Carlsson.
3507
3508         * WinLauncher/Common.cpp:
3509         (WndProc):
3510         * WinLauncher/WinLauncher.cpp:
3511         (WinLauncher::resetZoom):
3512         (WinLauncher::zoomIn):
3513         (WinLauncher::zoomOut):
3514         * WinLauncher/WinLauncher.h:
3515         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc:
3516         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:
3517         * win/DLLLauncher/DLLLauncherMain.cpp:
3518         (wWinMain):
3519
3520 2015-01-06  Anders Carlsson  <andersca@apple.com>
3521
3522         Fix API tests that are broken under HiDPI
3523         https://bugs.webkit.org/show_bug.cgi?id=140146
3524
3525         Reviewed by Tim Horton.
3526
3527         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
3528         (TestWebKitAPI::didGetImageForMatchResult):
3529         NSImages are measured in points, so grab the underlying bitmap image and get its size in pixels.
3530
3531         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
3532         (TestWebKitAPI::DeviceScaleFactorOnBack::runTest):
3533         Don't assume that a web view not in a window has a backing scale factor of 1. Instead, always have web views start
3534         out in a window that has a backing scale factor of 1.
3535  
3536         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
3537         (TestWebKitAPI::DynamicDeviceScaleFactor::runTest):
3538         Ditto.
3539
3540 2015-01-06  Alexey Proskuryakov  <ap@apple.com>
3541
3542         ADDRESS_SANITIZER macro is overloaded
3543         https://bugs.webkit.org/show_bug.cgi?id=140130
3544
3545         Reviewed by Anders Carlsson.
3546
3547         * WebKitTestRunner/TestController.cpp: Use the new macro.
3548
3549 2015-01-05  Joseph Pecoraro  <pecoraro@apple.com>
3550
3551         Remove some stale class names in check-for-inappropriate-objc-class-names
3552         https://bugs.webkit.org/show_bug.cgi?id=140104
3553
3554         Reviewed by Darin Adler.
3555
3556         * Scripts/check-for-inappropriate-objc-class-names:
3557         These UIWK* classes no longer exist.
3558
3559 2015-01-05  Anders Carlsson  <andersca@apple.com>
3560
3561         heap-buffer-overflow on fast/loader/reload-zero-byte-plugin.html
3562         https://bugs.webkit.org/show_bug.cgi?id=140096
3563         rdar://problem/19368938
3564
3565         Reviewed by Alexey Proskuryakov.
3566
3567         When creating a new page, don't pass clientInfo when setting up the frame and policy clients,
3568         since clientInfo points to a web view, not the test controller.
3569
3570         * WebKitTestRunner/TestController.cpp:
3571         (WTR::TestController::createOtherPage):
3572
3573 2015-01-05  Hunseop Jeong  <hs85.jeong@samsung.com>
3574
3575         [EFL][GTK] WKPreferencesDefaults test failed after r177506 
3576         https://bugs.webkit.org/show_bug.cgi?id=140077
3577
3578         Reviewed by Csaba Osztrogonác.
3579
3580         WebKit C SPI is available on EFL,GTK.
3581         Changed the define order to pass the API test.
3582
3583         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3584         (TestWebKitAPI::TEST):
3585
3586 2015-01-01  Alexey Proskuryakov  <ap@apple.com>
3587
3588         Simplify WebKitTestRunner timeout tracking
3589         https://bugs.webkit.org/show_bug.cgi?id=140036
3590
3591         Reviewed by Darin Adler.
3592
3593         The code for configuring timeouts was mostly dead, because run-webkit-tests never
3594         passes the --timeout option to WebKitTestRunner.
3595
3596         * WebKitTestRunner/Options.h:
3597         * WebKitTestRunner/Options.cpp:
3598         (WTR::Options::Options):
3599         (WTR::OptionsHandler::OptionsHandler):
3600         (WTR::handleOptionTimeout): Deleted.
3601         Removed support for --timeout. Timeouts are passed for each test individually,
3602         and defaults are good enough for the rare cases where WebKitTestRunner is run
3603         manually without run-webkit-tests.
3604
3605         * WebKitTestRunner/TestController.cpp:
3606         (WTR::TestController::TestController):
3607         (WTR::TestController::initialize):
3608         (WTR::TestController::resetStateToConsistentValues):
3609         (WTR::TestController::reattachPageToWebProcess):
3610         (WTR::TestController::runUntil):
3611         * WebKitTestRunner/TestController.h:
3612         Simplified runUntil by passing the actual timeout, not an enum.
3613         Increased short timeout for ASan enabled builds, as WebProcess launching takes
3614         quite a while.
3615
3616         * WebKitTestRunner/TestInvocation.cpp:
3617         (WTR::TestInvocation::invoke): Removed dead code that handled a timeout from NoTimeout.
3618
3619         * WebKitTestRunner/efl/TestControllerEfl.cpp:
3620         (WTR::TestController::platformRunUntil):
3621         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3622         (WTR::TestController::platformRunUntil):
3623         Build fixes.
3624
3625 2015-01-02  Anders Carlsson  <andersca@apple.com>
3626
3627         Remove now unused storage tracker glue from DumpRenderTree
3628         https://bugs.webkit.org/show_bug.cgi?id=140045
3629
3630         Reviewed by Darin Adler.
3631
3632         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3633         * DumpRenderTree/StorageTrackerDelegate.h: Removed.
3634         * DumpRenderTree/StorageTrackerDelegate.mm: Removed.
3635         * DumpRenderTree/TestRunner.cpp:
3636         (TestRunner::staticFunctions):
3637         (syncLocalStorageCallback): Deleted.
3638         (observeStorageTrackerNotificationsCallback): Deleted.
3639         (deleteAllLocalStorageCallback): Deleted.
3640         (deleteLocalStorageForOriginCallback): Deleted.
3641         (localStorageDiskUsageForOriginCallback): Deleted.
3642         (originsWithLocalStorageCallback): Deleted.
3643         * DumpRenderTree/TestRunner.h:
3644         * DumpRenderTree/mac/DumpRenderTree.mm:
3645         (allocateGlobalControllers):
3646         (releaseGlobalControllers):
3647         * DumpRenderTree/mac/DumpRenderTreeMac.h:
3648         * DumpRenderTree/mac/TestRunnerMac.mm:
3649         (TestRunner::syncLocalStorage): Deleted.
3650         (TestRunner::localStorageDiskUsageForOrigin): Deleted.
3651         (TestRunner::observeStorageTrackerNotifications): Deleted.
3652         (TestRunner::deleteAllLocalStorage): Deleted.
3653         (TestRunner::originsWithLocalStorage): Deleted.
3654         (TestRunner::deleteLocalStorageForOrigin): Deleted.
3655         * DumpRenderTree/win/TestRunnerWin.cpp:
3656         (TestRunner::syncLocalStorage): Deleted.
3657         (TestRunner::localStorageDiskUsageForOrigin): Deleted.
3658         (TestRunner::observeStorageTrackerNotifications): Deleted.
3659         (TestRunner::deleteAllLocalStorage): Deleted.
3660         (TestRunner::originsWithLocalStorage): Deleted.
3661         (TestRunner::deleteLocalStorageForOrigin): Deleted.
3662
3663 2015-01-01  Darin Adler  <darin@apple.com>
3664
3665         We often misspell identifier as "identifer"
3666         https://bugs.webkit.org/show_bug.cgi?id=140025
3667
3668         Reviewed by Michael Saboff.
3669
3670         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3671         * Scripts/webkitdirs.pm:
3672         (appIdentifierFromBundle):
3673         (installAndLaunchIOSWebKitAppInSimulator):
3674         Fix misspellings
3675
3676 2015-01-01  Zalan Bujtas  <zalan@apple.com>
3677
3678         Saturated arithmetics: Incorrect float/double clamping.
3679         https://bugs.webkit.org/show_bug.cgi?id=139888
3680         rdar://problem/19330885
3681
3682         Reviewed by Simon Fraser.
3683
3684         Clamp float and double values correctly when applying saturated arithmetics.
3685
3686         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
3687         (TestWebKitAPI::TEST):
3688
3689 2014-12-30  Krzysztof Czech  <k.czech@samsung.com>
3690
3691         [EFL] Bump version of ATK used by jhbuild to 2.15.2
3692         https://bugs.webkit.org/show_bug.cgi?id=139816
3693
3694         Reviewed by Gyuyoung Kim.
3695
3696         Bump version of ATK used by jhbuild to 2.15.2
3697
3698         * efl/jhbuild.modules:
3699
3700 2014-12-29  Fabien Vallée  <fvallee@connected-labs.com>
3701
3702         [jhBuild] cairo build error (-flto)
3703         https://bugs.webkit.org/show_bug.cgi?id=139056
3704
3705         Reviewed by Philippe Normand.
3706
3707         cairo fails to link  with gcc 4.9 due to lto
3708         related issue. This problem has been partially
3709         addressed by cairo:
3710         http://cgit.freedesktop.org/cairo/commit/?id=c3645d97ebd24c6f7ad850785d585aebc706a11c
3711         use the cairo --disable-lto option and remove jhbuild
3712         makeargs fixes the issue.
3713
3714         * gtk/jhbuild.modules:
3715         * gtk/patches/cairo-1.12.8-add_disable-lto.patch: Added.
3716
3717 2014-12-27  Myles C. Maxfield  <mmaxfield@apple.com>
3718         [Mac] Enable kerning, ligatures, and printer fonts 
3719         https://bugs.webkit.org/show_bug.cgi?id=139970
3720
3721         Rubber stamped by Simon Fraser.
3722
3723         Flip the switch.
3724
3725         * DumpRenderTree/mac/DumpRenderTree.mm:
3726         * WebKitTestRunner/TestController.cpp:
3727         * WebKitTestRunner/mac/main.mm:
3728
3729 2014-12-26  Dan Bernstein  <mitz@apple.com>
3730
3731         <rdar://problem/19348208> REGRESSION (r177027): iOS builds use the wrong toolchain
3732         https://bugs.webkit.org/show_bug.cgi?id=139950
3733
3734         Reviewed by David Kilzer.
3735
3736         * asan/asan.xcconfig: Only define TOOLCHAINS when building for OS X, doing so
3737         in a manner that works with Xcode 5.1.1.
3738
3739 2014-12-24  Dan Bernstein  <mitz@apple.com>
3740
3741         Engineering builds of MiniBrowser ignore deprecated declaration warnings
3742         https://bugs.webkit.org/show_bug.cgi?id=139941
3743
3744         Reviewed by Darin Adler.
3745
3746         * MiniBrowser/Configurations/Base.xcconfig: Added semicolon.
3747         * MiniBrowser/Configurations/DebugRelease.xcconfig: Set GCC_WARN_ABOUT_DEPRECATED_FUNCTIONS
3748         to YES.
3749         * MiniBrowser/mac/AppDelegate.m:
3750         (-[BrowserAppDelegate openDocument:]): Use NSFileHandlingPanelOKButton instead of
3751         deprecated NSOKButton.
3752
3753 2014-12-24  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3754
3755         W3C test importer should have an option to disable testharness.js/testharnessreport.js link conversion
3756         https://bugs.webkit.org/show_bug.cgi?id=134763
3757
3758         Reviewed by Ryosuke Niwa.
3759
3760         Adding an option to disable test harness link conversion.
3761
3762         * Scripts/webkitpy/w3c/test_converter.py:
3763         (convert_for_webkit):
3764         (_W3CTestConverter.__init__):
3765         (_W3CTestConverter.convert_attributes_if_needed):
3766         * Scripts/webkitpy/w3c/test_importer.py:
3767         (parse_args):
3768         (TestImporter.import_tests):
3769
3770 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
3771
3772         DumpRenderTree crashes are mis-reported as timeouts on Yosemite
3773         https://bugs.webkit.org/show_bug.cgi?id=139933
3774
3775         Reviewed by Daniel Bates.
3776
3777         Crash logs take a very long time to be generated on Yosemite (rdar://problem/18701447),
3778         and there is no way for run-webkit-tests to tell a crashed process from a frozen one
3779         until ReportCrash lets it go.
3780
3781         Reuse existing machinery that tells run-webkit-tests about crashes. The script may
3782         even get the actual crash log eventually - even when it times out waiting for the log, it
3783         makes a second lookup at the very end, after all tests finish. There may be further
3784         improvements needed here, but this small fix addresses most cases that happen in practice.
3785
3786         * DumpRenderTree/mac/DumpRenderTree.mm:
3787         (writeCrashedMessageOnFatalError):
3788         (dumpRenderTree):
3789         Removed PLATFORM(IOS) ifdefs, this code is just as helpful on Mac.
3790
3791         * Scripts/webkitpy/port/driver.py: (Driver._check_for_driver_crash): Removed an
3792         unhelpful comment.
3793
3794 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
3795
3796         Don't force -O1 for debug ASan builds
3797         https://bugs.webkit.org/show_bug.cgi?id=139926
3798
3799         Reviewed by Darin Adler.
3800
3801         * asan/asan.xcconfig:
3802
3803 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
3804
3805         Simplify building with ASan
3806         https://bugs.webkit.org/show_bug.cgi?id=139916
3807
3808         Reviewed by Mark Rowe.
3809
3810         * Scripts/set-webkit-configuration: Store ASan state into a new configuration file.
3811         We could also update Configuration file format, but that's a little scary because
3812         of how many places in code read it.
3813
3814         * Scripts/webkitdirs.pm:
3815         (determineASanIsEnabled): Read it from ASan configuration file.
3816         (argumentsForConfiguration): Added a FIXME.
3817         (asanIsEnabled): A caching wrapper similar to what we have for other configuration options.
3818         (XcodeOptions): Pass the options needed for ASan.
3819
3820         * asan/asan.xcconfig: Use the right toolchains. Made warnings fatal again, as there
3821         no warnings to avoid. Removed explicit linking options, as -fsanitize=address does
3822         that automatically.
3823
3824 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
3825
3826         TestWebKitAPI build is broken when ASan is enabled
3827         https://bugs.webkit.org/show_bug.cgi?id=139902
3828
3829         Reviewed by Darin Adler.
3830
3831         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
3832         * TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig:
3833         Inherit linker flags from DebugRelease, which respects ASAN.
3834
3835 2014-12-22  Simon Fraser  <simon.fraser@apple.com>
3836
3837         Sort the Xcode project file.
3838
3839         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3840
3841 2014-12-22  Lucas Forschler  <lforschler@apple.com>
3842
3843         Update apple-mac-114 to bot629.
3844         
3845         Unreviewed.
3846         
3847         * BuildSlaveSupport/build.webkit.org-config/config.json:
3848
3849 2014-12-22  Lucas Forschler  <lforschler@apple.com>
3850
3851         Replace Apple bot104 with bot124.
3852         
3853         Unreviewed.
3854         
3855         * BuildSlaveSupport/build.webkit.org-config/config.json:
3856
3857 2014-12-22  Csaba Osztrogonác  <ossy@webkit.org>
3858
3859         URTBF after r177639.
3860
3861         * TestWebKitAPI/CMakeLists.txt:
3862
3863 2014-12-22  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
3864
3865         [EFL] MiniBrowser steals web view's focus
3866         https://bugs.webkit.org/show_bug.cgi?id=139482
3867
3868         Reviewed by Gyuyoung Kim.
3869
3870         Although we set focus on ewk_view while MiniBrowser initialization
3871         Ecore steals it in a favor of main window. As a result
3872         focused element on web page is unable to receive events.
3873
3874         * MiniBrowser/efl/main.c:
3875         (window_create):
3876         Prevent window from stealing web view's focus on start up.
3877
3878 2014-12-19  Brent Fulgham  <bfulgham@apple.com>
3879
3880         [Win] Revise DRT logic to match Mac.
3881
3882         Rubberstamped by Anders Carlsson.
3883
3884         Update the Windows logic to perform initialization of preferences and WebKit
3885         settings to match Mac. Also make sure that we only ever emit #EOF tokens under
3886         the same circumstances as the Mac version.
3887
3888         * DumpRenderTree/win/DumpRenderTree.cpp:
3889         (dump):
3890         (resetWebPreferencesToConsistentValues):
3891         (setDefaultsToConsistentValuesForTesting):
3892         (resetWebViewToConsistentStateBeforeTesting):
3893         (sizeWebViewForCurrentTest):
3894         (runTest):
3895         (createWebViewAndOffscreenWindow):
3896         (allocateGlobalControllers):
3897         (prepareConsistentTestingEnvironment):
3898         (main):
3899         (resetDefaultsToConsistentValues): Deleted.
3900
3901 2014-12-19  Roger Fong  <roger_fong@apple.com>
3902
3903         Unreviewed. Rollout r177605.
3904
3905         * EWSTools/start-queue-win.sh:
3906
3907 2014-12-19  Roger Fong  <roger_fong@apple.com>
3908
3909         Unreviewed. Try running EWS scripts without —no-confirm, since it defaults to true.
3910
3911         * EWSTools/start-queue-win.sh:
3912
3913 2014-12-19  Daniel Bates  <dabates@apple.com>
3914
3915         [iOS] Add WebKitSystemInterface for iOS 8.1
3916         https://bugs.webkit.org/show_bug.cgi?id=139831
3917
3918         Reviewed by Alexey Proskuryakov.
3919
3920         Implement support in copy-webkitlibraries-to-product-directory to copy
3921         WebKitSystemInterface for iOS to the product directory and have build-webkit
3922         pass --wksi to copy-webkitlibraries-to-product-directory when building for iOS.
3923
3924         * Scripts/build-webkit:
3925         * Scripts/copy-webkitlibraries-to-product-directory:
3926
3927 2014-12-19  Daniel Bates  <dabates@apple.com>
3928
3929         copy-webkitlibraries-to-product-directory uses wrong SDK when called from build-webkit
3930         https://bugs.webkit.org/show_bug.cgi?id=139829
3931
3932         Reviewed by Alexey Proskuryakov.
3933
3934         The script build-webkit calls script copy-webkitlibraries-to-product-directory with
3935         argument --sdk to specify the Xcode SDK to use, but copy-webkitlibraries-to-product-directory
3936         expects the Xcode SDK to be specified using the --sdk-name command line argument.
3937
3938         Currently copy-webkitlibraries-to-product-directory has its own logic to handle
3939         parsing for a specified Xcode SDK. Instead we should make use of the webkitdirs.pm
3940         logic to both avoid duplicating effort and make the command line options for
3941         copy-webkitlibraries-to-product-directory for specify the Xcode SDK consistent
3942         with the approach used in other WebKit tools.
3943
3944         As a side effect of making use of the webkitdirs.pm logic for determining the Xcode SDK
3945         copy-webkitlibraries-to-product-directory now recognizes --device and --simulator
3946         shorthands for --sdk=iphoneos.internal and --sdk=iphonesimulator, respectively.
3947
3948         * Scripts/copy-webkitlibraries-to-product-directory: Also, renamed some variables to
3949         improve the readability of the code.
3950         (executeRanlib): Added; convenience function that calls the RANLIB(1) with the appropriate
3951         Xcode SDK. We pass -no_warning_for_no_symbols to RANLIB(1) when using an Xcode SDK
3952         for iOS since it's acceptable that an empty object file (say, for a Mac-specific feature)
3953         be included in a library.
3954         (unpackIfNecessary): Modified to call executeRanlib().
3955
3956 2014-12-19  Alexey Proskuryakov  <ap@apple.com>
3957
3958         REGRESSION (177368): Some tests started to immediately time out
3959         https://bugs.webkit.org/show_bug.cgi?id=139826
3960
3961         Reviewed by Daniel Bates.
3962
3963         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::done):
3964         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::dump):
3965         Move invalidateWaitToDumpWatchdogTimer() call from dump() to done(). When a test
3966         ends in a load failure, we don't dump, so we used to leak the timer.
3967         
3968         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::notifyDone):
3969         Added a comment.
3970
3971 2014-12-19  Brent Fulgham  <bfulgham@apple.com>
3972
3973         [Win] Add accessor for serializing HTTP loads
3974         https://bugs.webkit.org/show_bug.cgi?id=139817
3975
3976         Reviewed by Mark Lam.
3977
3978         * DumpRenderTree/win/DumpRenderTree.cpp: Reset serialized HTTP loads in our reset method.
3979         * DumpRenderTree/win/TestRunnerWin.cpp: Provide implementation for serializing HTTP. Also
3980         remove some redundant code from the destructor.
3981
3982 2014-12-19  Alexey Proskuryakov  <ap@apple.com>
3983
3984         Clean up a fix for performance test bot failing to build
3985         https://bugs.webkit.org/show_bug.cgi?id=139818
3986
3987         Reviewed by Csaba Osztrogonác.
3988
3989         The "_1" in step name was annoying.
3990
3991         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3992         (CleanBuildIfScheduled.start):
3993         (RunAndUploadPerfTests):
3994         (DownloadAndPerfTestFactory.__init__):
3995         (DownloadAndPerfTestWebKit2Factory.__init__):
3996         (CleanBuildUnconditionally): Deleted.
3997         (CleanBuildUnconditionally.start): Deleted.
3998
3999 2014-12-19  Csaba Osztrogonác  <ossy@webkit.org>
4000
4001         REGRESSION(r177535): It broke the GTK performance bot
4002         https://bugs.webkit.org/show_bug.cgi?id=139811
4003
4004         Reviewed by Carlos Garcia Campos.
4005
4006         Trigger clean build only on mac platform.
4007
4008         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4009         (DownloadAndPerfTestFactory.__init__):
4010         (DownloadAndPerfTestWebKit2Factory.__init__):
4011
4012 2014-12-18  KwangHyuk Kim  <hyuki.kim@samsung.com>
4013
4014         Unreviewed, moved myself to the list of committers.
4015
4016         * Scripts/webkitpy/common/config/contributors.json:
4017
4018 2014-12-18  Brent Fulgham  <bfulgham@apple.com>
4019
4020         [Win] Update DumpRenderTree to more closely match Mac version
4021         https://bugs.webkit.org/show_bug.cgi?id=139799
4022
4023         Reviewed by Tim Horton.
4024
4025         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
4026         (AccessibilityController::accessibleElementById): Correct
4027         use of BSTR to avoid leak.
4028         * DumpRenderTree/win/DumpRenderTree.cpp: Reorder methods and
4029         update to match Mac version more closely.
4030         (dumpFramesAsText):
4031         (dump):
4032         (resetDefaultsToConsistentValues):
4033         (resetWebViewToConsistentStateBeforeTesting):
4034         (sizeWebViewForCurrentTest):
4035         (runTest):
4036         (openWindows):
4037         (windowToWebViewMap):
4038         (createWebViewAndOffscreenWindow):
4039         (sharedCFURLCache):
4040         (initializeGlobalsFromCommandLineOptions):
4041         (main):
4042         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
4043         (TestRunner::addDisallowedURL):
4044         (TestRunner::applicationCacheDiskUsageForOrigin):
4045         (TestRunner::syncLocalStorage):
4046         (TestRunner::localStorageDiskUsageForOrigin):
4047         (TestRunner::observeStorageTrackerNotifications):
4048         (TestRunner::clearApplicationCacheForOrigin):
4049         (TestRunner::originsWithApplicationCache):
4050         (TestRunner::deleteAllLocalStorage):
4051         (TestRunner::setStorageDatabaseIdleInterval):
4052         (TestRunner::closeIdleLocalStorageDatabases):
4053         (TestRunner::originsWithLocalStorage):
4054         (TestRunner::deleteLocalStorageForOrigin):
4055         (TestRunner::copyDecodedHostName):
4056         (TestRunner::copyEncodedHostName):
4057         (TestRunner::keepWebHistory):
4058         (TestRunner::numberOfPendingGeolocationPermissionRequests):
4059         (TestRunner::setAppCacheMaximumSize):
4060         (TestRunner::setCustomPolicyDelegate):
4061         (TestRunner::goBack):
4062         (TestRunner::setDefersLoading):
4063         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
4064         (TestRunner::setMockDeviceOrientation):
4065         (TestRunner::setMockGeolocationPosition):
4066         (TestRunner::setMockGeolocationPositionUnavailableError):
4067         (TestRunner::setIconDatabaseEnabled):
4068         (TestRunner::setMainFrameIsFirstResponder):
4069         (TestRunner::setSpatialNavigationEnabled):
4070         (TestRunner::setPluginsEnabled):
4071         (TestRunner::setAutomaticLinkDetectionEnabled):
4072         (TestRunner::setUseDashboardCompatibilityMode):
4073         (TestRunner::dispatchPendingLoadRequests):
4074         (TestRunner::findString):
4075         (TestRunner::setCacheModel):
4076         (TestRunner::apiTestNewWindowDataLoadBaseURL):
4077         (TestRunner::setWebViewEditable):
4078         (TestRunner::authenticateSession):
4079         (TestRunner::abortModal):
4080         (TestRunner::setSerializeHTTPLoads):
4081         (TestRunner::addChromeInputField):
4082         (TestRunner::removeChromeInputField):
4083         (TestRunner::focusWebView):
4084         (TestRunner::setBackingScaleFactor):
4085         (TestRunner::grantWebNotificationPermission):
4086         (TestRunner::denyWebNotificationPermission):
4087         (TestRunner::removeAllWebNotificationPermissions):
4088         (TestRunner::simulateWebNotificationClick):
4089
4090 2014-12-18  Gavin Barraclough  <barraclough@apple.com>
4091
4092         Add strong typing to RefCounter interface, return value as a bool.
4093         https://bugs.webkit.org/show_bug.cgi?id=139776
4094
4095         Reviewed by Geoff Garen.
4096
4097         Currently all token vended by a RefCounter have the same type - Ref<RefCounter::Count>.
4098         This means there is no compile time type checking to prevent mistakes. Update the count()
4099         method to token<>(), templated on type used to identify the token being returned.
4100         Calls to token<T>() will return a result of type RefCounter::Token<T>.
4101
4102         There are a few problems with the fact the counter will return you an exact count of the
4103         number of outstanding tokens:
4104           - It is desirable to only fire the callback on zero-edge changes; it is more consistent
4105             to do so if the value is only readable as a boolean.
4106           - It is desirable to provide the value as an argument to the callback, however to make
4107             this useful for integer values it is also necessary to indicate the direction of change
4108             (0->1 is often interesting where 2->1 is not).
4109           - There is a mismatch between the precision of returning a count, and the inherent
4110             imprecision of a token based mechanism, where it may be difficult to guarantee
4111             absolutely no unnecessary refcount churn, and thus unintentional counter values.
4112
4113         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
4114         (TestWebKitAPI::TEST):
4115             - update API test.
4116
4117 2014-12-18  Alexey Proskuryakov  <ap@apple.com>
4118
4119         Disable retries on Mac Release WK2 testers
4120         https://bugs.webkit.org/show_bug.cgi?id=139798
4121
4122         Reviewed by Simon Fraser.
4123
4124         * BuildSlaveSupport/build.webkit.org-config/config.json:
4125
4126 2014-12-18  Alexey Proskuryakov  <ap@apple.com>
4127
4128         Perf tests frequently fail saying "build not up to date"
4129         https://bugs.webkit.org/show_bug.cgi?id=139786
4130
4131         Illegitimately yet authoritatively reviewed by Lucas Forschler.
4132
4133         Undo the rest of the first fix, and implement the behavior differently.
4134
4135         is_clean isn't automatically forwarded from config.json to properties.
4136
4137         * BuildSlaveSupport/build.webkit.org-config/config.json:
4138         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4139         (CleanBuildUnconditionally):
4140         (CleanBuildUnconditionally.start):
4141         (DownloadAndPerfTestFactory.__init__):
4142         (DownloadAndPerfTestWebKit2Factory.__init__):
4143
4144 2014-12-18  Alexey Proskuryakov  <ap@apple.com>
4145
4146         Roll out part of the previous patch - BuildAndPerfTestWebKit2 is used by Efl.
4147         I thought that it was unused because grepping for BuildAndPerfTestWebKit2Factory
4148         found nothing.
4149
4150         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4151         (BuildAndPerfTestFactory):
4152         (BuildAndPerfTestWebKit2Factory):
4153
4154 2014-12-18  Alexey Proskuryakov  <ap@apple.com>
4155
4156         Perf tests frequently fail saying "build not up to date"
4157         https://bugs.webkit.org/show_bug.cgi?id=139786
4158
4159         Reviewed by Ryosuke Niwa.
4160
4161         Perf tests only build DumpRenderTree, not WebKit itself. Just clean the build
4162         directory to get rid of stale precompiled headers, and let it rebuild
4163         DumpRenderTree each time, that's fast.
4164
4165         Also, removed unused "build and perf test" code.
4166
4167         * BuildSlaveSupport/build.webkit.org-config/config.json:
4168
4169 2014-12-18  Brent Fulgham  <bfulgham@apple.com>
4170
4171         [Win] Unreviewed gardening. Reorder file contents to match Mac version.
4172
4173         Reorder the contents of the TestRunnerWin so that it matches TestRunnerMac. This makes
4174         it easier to see what steps are missing when running under Windows.
4175
4176         * DumpRenderTree/win/TestRunnerWin.cpp:
4177         (TestRunner::callShouldCloseOnWebView):
4178         (TestRunner::clearAllApplicationCaches):
4179         (TestRunner::applicationCacheDiskUsageForOrigin):
4180         (TestRunner::syncLocalStorage):
4181         (TestRunner::localStorageDiskUsageForOrigin):
4182         (TestRunner::observeStorageTrackerNotifications):
4183         (TestRunner::clearApplicationCacheForOrigin):
4184         (TestRunner::originsWithApplicationCache):
4185         (TestRunner::clearAllDatabases):
4186         (TestRunner::deleteAllLocalStorage):
4187         (TestRunner::setStorageDatabaseIdleInterval):
4188         (TestRunner::closeIdleLocalStorageDatabases):
4189         (TestRunner::originsWithLocalStorage):
4190         (TestRunner::deleteLocalStorageForOrigin):
4191         (TestRunner::numberOfPendingGeolocationPermissionRequests):
4192         (jsStringRefToWString):
4193         (TestRunner::setAppCacheMaximumSize):
4194         (TestRunner::setDatabaseQuota):
4195         (TestRunner::goBack):
4196         (TestRunner::setDefersLoading):
4197         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
4198         (TestRunner::setAutomaticLinkDetectionEnabled):
4199         (TestRunner::dispatchPendingLoadRequests):
4200         (TestRunner::overridePreference):
4201         (TestRunner::removeAllVisitedLinks):
4202         (TestRunner::waitForPolicyDelegate):
4203         (TestRunner::resetPageVisibility):
4204         (TestRunner::setPageVisibility):
4205         (TestRunner::grantWebNotificationPermission):
4206         (TestRunner::denyWebNotificationPermission):
4207         (TestRunner::removeAllWebNotificationPermissions):
4208         (TestRunner::simulateWebNotificationClick):
4209         (TestRunner::simulateLegacyWebNotificationClick):
4210
4211 2014-12-18  Brent Fulgham  <bfulgham@apple.com>
4212
4213         [Win] Correct Windows tests after Bug 139149 (edit)
4214         https://bugs.webkit.org/show_bug.cgi?id=139781
4215
4216         Reviewed by Anders Carlsson.
4217
4218         * DumpRenderTree/win/TestRunnerWin.cpp:
4219         (TestRunner::clearAllApplicationCaches): Use new WebApplicationCache
4220         interface.
4221
4222 2014-12-18  Simon Fraser  <simon.fraser@apple.com>
4223
4224         [iOS] Remove the various aliases for --ios-simulator (--sim, --simulator, --ios-sim) in arguments for build and test scripts
4225         https://bugs.webkit.org/show_bug.cgi?id=139748
4226
4227         Reviewed by Daniel Bates.
4228         
4229         Staging change to support --ios-sim and --ios-simulator temporarily until the bots
4230         have all been updated.
4231
4232         * Scripts/webkitpy/port/factory.py:
4233         (platform_options):
4234
4235 2014-12-18  Simon Fraser  <simon.fraser@apple.com>
4236
4237         Build more of TestWebKitAPI for iOS
4238         https://bugs.webkit.org/show_bug.cgi?id=139747
4239
4240         Reviewed by Daniel Bates.
4241         
4242         Base.xcconfig removed many test files from the iOS build via EXCLUDED_SOURCE_FILE_NAMES,
4243         which excluded some tests that should be run for iOS.
4244         
4245         Fix by removing some patterns from EXCLUDED_SOURCE_FILE_NAMES, and #ifdeffing
4246         source files instead. config.h defines WK_HAVE_C_SPI when the WebKit C SPI is
4247         available (i.e. Mac OS X), and most files use that. Some files with Mac-only
4248         functionality (ActionMenus, Downloads) use #if PLATFORM(MAC).
4249         
4250         Added PlatformUtilitiesCocoa.mm and moved WeakObjCPtr.mm into a cocoa directory
4251         to share code between Mac and iOS.
4252
4253         * TestWebKitAPI/Configurations/Base.xcconfig:
4254         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
4255         * TestWebKitAPI/InjectedBundleController.cpp:
4256         * TestWebKitAPI/InjectedBundleMain.cpp:
4257         * TestWebKitAPI/JavaScriptTest.cpp:
4258         * TestWebKitAPI/PlatformUtilities.cpp:
4259         * TestWebKitAPI/PlatformUtilities.h:
4260         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4261         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
4262         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
4263         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
4264         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
4265         * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp:
4266         * TestWebKitAPI/Tests/WebKit2/CloseThenTerminate.cpp:
4267         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
4268         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
4269         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
4270         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp:
4271         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
4272         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp:
4273         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
4274         * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp:
4275         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
4276         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
4277         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
4278         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
4279         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
4280         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
4281         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
4282         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
4283         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
4284         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
4285         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
4286         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
4287         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp:
4288         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback_Bundle.cpp:
4289         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
4290         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
4291         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
4292         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
4293         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp:
4294         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
4295         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp:
4296         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins_Bundle.cpp:
4297         * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp:
4298         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
4299         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
4300         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
4301         * TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:
4302         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
4303         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp:
4304         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
4305         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
4306         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle