Initialize the ArraySpecies watchpoint as Clear and transition to IsWatched once...
[WebKit-https.git] / Tools / ChangeLog
1 2017-01-13  Yusuke Suzuki  <utatane.tea@gmail.com>
2
3         run-jsc-benchmarks' echo should have -e option
4         https://bugs.webkit.org/show_bug.cgi?id=167009
5
6         Reviewed by Sam Weinig.
7
8         echo requires `-e` option to use escape sequence.
9         Without it, in some environment (in my Fedora 25), the escape sequence is not
10         recognized and just dumped as `\c` etc.
11
12         * Scripts/run-jsc-benchmarks:
13
14 2017-01-12  Chris Dumez  <cdumez@apple.com>
15
16         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
17         https://bugs.webkit.org/show_bug.cgi?id=166995
18
19         Reviewed by Jer Noble.
20
21         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
22         as some people are having trouble building without it.
23
24         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
25
26 2017-01-12  Sam Weinig  <sam@webkit.org>
27
28         Add the ability to filter the set of bindings tests you want to run
29         https://bugs.webkit.org/show_bug.cgi?id=166977
30
31         Reviewed by Tim Horton.
32
33         Allows doing things like:
34             run-bindings-tests TestObj* TestCEReactions*
35         
36         to run only those tests that match the patterns.
37
38         * Scripts/run-bindings-tests:
39         (main):
40         Switch to using optparse and pass the remaining args as the filters.
41
42         * Scripts/webkitpy/bindings/main.py:
43         (BindingsTests.__init__):
44         Store the pattens.
45
46         (BindingsTests.test_matches_patterns):
47         Add helper predicate to determine if a test should be run. When no
48         patterns are present, all tests should run.
49
50         (BindingsTests.run_tests):
51         Filter tests using the passed in patterns.
52
53 2017-01-12  Per Arne Vollan  <pvollan@apple.com>
54
55         Followup fix after r210503.
56         https://bugs.webkit.org/show_bug.cgi?id=166887
57
58         Reviewed by Alex Christensen.
59
60         After <http://trac.webkit.org/changeset/210503>, test results are written to a
61         duplicated file handle on Windows. This patch fixes the remaining call sites.
62
63         * DumpRenderTree/PixelDumpSupport.cpp:
64         * DumpRenderTree/TestRunner.cpp:
65         (TestRunner::waitToDumpWatchdogTimerFired):
66         * DumpRenderTree/TestRunner.h:
67         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
68         * DumpRenderTree/win/DumpRenderTree.cpp:
69         * DumpRenderTree/win/DumpRenderTreeWin.h:
70         * DumpRenderTree/win/TestRunnerWin.cpp:
71         (TestRunner::setSpellCheckerLoggingEnabled):
72
73 2017-01-11  Megan Gardner  <megan_gardner@apple.com>
74
75         Add committer status for Megan
76         https://bugs.webkit.org/show_bug.cgi?id=166954
77
78         Reviewed by Tim Horton.
79
80         Add committer status for Megan Gardner
81
82         * Scripts/webkitpy/common/config/contributors.json:
83
84 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
85
86         Unreviewed test fix after r210599.
87
88         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
89         (TestWebKitAPI::TEST): Remove debugging code that was causing a timeout.
90
91 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
92
93         Unreviewed build fix after r210599.
94
95         Add missing files.
96
97         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
98         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
99
100 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
101
102         File scheme should not allow access of a resource on a different volume.
103         https://bugs.webkit.org/show_bug.cgi?id=158552
104         <rdar://problem/15307582>
105
106         Reviewed by Alex Christensen.
107
108         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
109         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
110         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
111
112 2017-01-11  Ryan Haddad  <ryanhaddad@apple.com>
113
114         Unreviewed, rolling out r210571.
115
116         This change broke the 32-bit macOS build and caused LayoutTest
117         failures.
118
119         Reverted changeset:
120
121         "File scheme should not allow access of a resource on a
122         different volume."
123         https://bugs.webkit.org/show_bug.cgi?id=158552
124         http://trac.webkit.org/changeset/210571
125
126 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
127
128         [GTK] install-dependencies script misses gdb
129         https://bugs.webkit.org/show_bug.cgi?id=166917
130
131         Reviewed by Michael Catanzaro.
132
133         gdb is needed for generating the crash logs.
134
135         * gtk/install-dependencies:
136
137 2017-01-10  Michael Catanzaro  <mcatanzaro@igalia.com>
138
139         [GTK] No way for applications to set notification permissions without waiting for permission request
140         https://bugs.webkit.org/show_bug.cgi?id=163366
141
142         Reviewed by Carlos Garcia Campos.
143
144         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
145         (testWebViewNotification):
146         (setInitialNotificationPermissionsAllowedCallback):
147         (setInitialNotificationPermissionsDisallowedCallback):
148         (testWebViewNotificationInitialPermissionAllowed):
149         (testWebViewNotificationInitialPermissionDisallowed):
150         (beforeAll):
151         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
152         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
153         (WebViewTest::WebViewTest):
154         (WebViewTest::initializeWebView):
155         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
156
157 2017-01-10  Tim Horton  <timothy_horton@apple.com>
158
159         MobileMiniBrowser tests don't work by default
160         https://bugs.webkit.org/show_bug.cgi?id=166910
161
162         Reviewed by Alex Christensen.
163
164         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme: Added.
165         Add a shared scheme; the Makefile depends on the MobileMiniBrowserUITests scheme existing, at the very least.
166
167 2017-01-10  Brent Fulgham  <bfulgham@apple.com>
168
169         File scheme should not allow access of a resource on a different volume.
170         https://bugs.webkit.org/show_bug.cgi?id=158552
171         <rdar://problem/15307582>
172
173         Reviewed by Alex Christensen.
174
175         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
176         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
177         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
178
179 2017-01-10  Mark Lam  <mark.lam@apple.com>
180
181         Reverting run-jsc-stress-tests' $buildType to use string values.
182         https://bugs.webkit.org/show_bug.cgi?id=166912
183
184         Rubber stamped by Filip Pizlo.
185
186         This is so that we can test for it in the tests e.g.
187         //@ if $buildType == "debug" then runDefault("--maxSingleAllocationSize=1048576") else skip end
188
189         * Scripts/run-jsc-stress-tests:
190
191 2017-01-10  Ryosuke Niwa  <rniwa@webkit.org>
192
193         Temporarily add back the file removed in r210463 to unbreak internal bots.
194
195         * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Copied from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
196
197 2017-01-10  Jonathan Bedard  <jbedard@apple.com>
198
199         svn-apply failed to apply a patch (deleting file with svn property)
200         https://bugs.webkit.org/show_bug.cgi?id=165953
201
202         Reviewed by Daniel Bates.
203
204         * Scripts/VCSUtils.pm:
205         (parseSvnPropertyValue): The beginning of a diff will cause an early exit in the case of no empty newlines.
206         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl: Add tests without break between diffs for properties.
207
208 2017-01-10  Ryan Haddad  <ryanhaddad@apple.com>
209
210         Update flakiness dashboard configuration.
211         https://bugs.webkit.org/show_bug.cgi?id=166869
212
213         Reviewed by Alexey Proskuryakov.
214
215         * TestResultServer/static-dashboards/builders.jsonp:
216         * TestResultServer/static-dashboards/flakiness_dashboard.js:
217
218 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
219
220         [GTK] Stop honoring the environment variable USE_NATIVE_XDISPLAY
221         https://bugs.webkit.org/show_bug.cgi?id=165232
222
223         Unreviewed follow-up patch after r210539 and r210523.
224
225         Instead of using that environment variable, the argument
226         --display-server=xorg should be passed now.
227
228         The GTK+ performance bot was the only bot using this, and is
229         already passing --display-server=xorg after r210539.
230
231         * Scripts/webkitpy/port/gtk.py:
232         (GtkPort._driver_class):
233
234 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
235
236         [GTK] Add a new release test bot for Wayland and pass --display-server=xorg to the GTK Perf bot.
237         https://bugs.webkit.org/show_bug.cgi?id=166872
238
239         Reviewed by Michael Catanzaro.
240
241         Add the new wayland release test bot as a test-only bot. It will download the built product from the release build-only bot.
242         Define the required "--display-server=driver" in the bot additionalArguments config entry.
243         Implement support for honoring additionalArguments on the RunGtkAPITests and RunAndUploadPerfTests steps.
244         The step RunWebKitTests already has support for it.
245
246         * BuildSlaveSupport/build.webkit.org-config/config.json:
247         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
248         (RunGtkAPITests.start):
249         (RunAndUploadPerfTests.start):
250         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
251
252 2017-01-09  Ryan Haddad  <ryanhaddad@apple.com>
253
254         Unreviewed, rolling out r210531.
255
256         This change broke the 32-bit macOS build and caused LayoutTest
257         failures.
258
259         Reverted changeset:
260
261         "File scheme should not allow access of a resource on a
262         different volume."
263         https://bugs.webkit.org/show_bug.cgi?id=158552
264         http://trac.webkit.org/changeset/210531
265
266 2017-01-09  Brent Fulgham  <bfulgham@apple.com>
267
268         File scheme should not allow access of a resource on a different volume.
269         https://bugs.webkit.org/show_bug.cgi?id=158552
270         <rdar://problem/15307582>
271
272         Reviewed by Alex Christensen.
273
274         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
275         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
276         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
277
278 2017-01-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
279
280         [GTK][Wayland] Allow running the layout tests under a native Wayland environment.
281         https://bugs.webkit.org/show_bug.cgi?id=165232
282
283         Reviewed by Michael Catanzaro.
284
285         Add a new WaylandDriver to run the tests in the user current wayland session.
286
287         Also merge all the configuration options for selecting the display server inside one
288         switch --display-server=xvfb/xorg/wayland/weston (defaulting to xvfb).
289
290         This switch is supported on the scripts: run-gtk-tests, run-perf-tests and run-webkit-tests.
291
292         * Scripts/run-gtk-tests: Add missing logging.basicConfig() initialization for the error logger.
293         (TestRunner._create_driver):
294         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
295         (parse_args):
296         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
297         (PerfTestsRunner._parse_args):
298         * Scripts/webkitpy/port/gtk.py:
299         (GtkPort.__init__):
300         (GtkPort._driver_class):
301         (GtkPort._search_paths):
302         * Scripts/webkitpy/port/waylanddriver.py: Added.
303         (WaylandDriver):
304         (WaylandDriver.check_driver):
305         (WaylandDriver._setup_environ_for_test):
306         (WaylandDriver._start):
307
308 2017-01-09  Andy Estes  <aestes@apple.com>
309
310         [QuickLook] Add a layout test for webkit.org/b/135651
311         https://bugs.webkit.org/show_bug.cgi?id=166855
312
313         Reviewed by Andreas Kling.
314
315         * DumpRenderTree/mac/FrameLoadDelegate.mm:
316         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]): Added output for
317         errors with code WebKitErrorCannotShowURL.
318         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
319         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Made the error output
320         not specific to WebKit2 error codes.
321
322 2017-01-09  Antoine Quint  <graouts@apple.com>
323
324         Support webkit-test-runner key-value pairs in http tests in DumpRenderTree
325         https://bugs.webkit.org/show_bug.cgi?id=166837
326
327         Reviewed by Alex Christensen.
328
329         We now correctly handle the --absolutePath argument in DumpRenderTree and use
330         the provided value when trying to determine the path to the test file. Failing
331         that, we use the computed URL or the raw path provided to cover all cases.
332         
333         This was tested in the context of https://bugs.webkit.org/show_bug.cgi?id=165668
334         by applying this patch and seeing the number test failures dramatically reduced
335         with WK1 due to the option to turn modern media controls off for older media controls
336         tests.
337
338         * DumpRenderTree/DumpRenderTree.h:
339         * DumpRenderTree/DumpRenderTreeCommon.cpp:
340         (parseInputLine):
341         * DumpRenderTree/TestOptions.h:
342         * DumpRenderTree/TestOptions.mm:
343         (TestOptions::TestOptions):
344         * DumpRenderTree/mac/DumpRenderTree.mm:
345         (runTest):
346
347 2017-01-09  Milan Crha  <mcrha@redhat.com>
348
349         prepare-ChangeLog: Correct help string for --style option
350         https://bugs.webkit.org/show_bug.cgi?id=166725
351
352         Reviewed by Alexey Proskuryakov.
353
354         * Scripts/prepare-ChangeLog:
355         (main):
356
357 2017-01-09  Lucas Forschler  <lforschler@apple.com>
358
359         https://bugs.webkit.org/show_bug.cgi?id=166839
360         Add php7 support for macOS.
361         Mirror the debian logic to look for a php7 module on disk, and return the appropriate apache config file.
362
363         Reviewed by Alexey Proskuryakov.
364
365         * Scripts/webkitpy/port/base.py:
366         (Port._is_darwin_php_version_7):
367         (Port._debian_php_version):
368         (Port):
369         (Port._darwin_php_version):
370         (Port._apache_config_file_name_for_platform):
371
372 2017-01-06  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
373
374         [GTK] Should support key and code properties on keyboard events
375         https://bugs.webkit.org/show_bug.cgi?id=166759
376
377         Reviewed by Carlos Garcia Campos.
378
379         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
380         (WTR::getGDKKeySymForKeyRef): add missing modifier keys which were being reported as 'l' and 'r' only
381         on tests.
382
383 2017-01-06  Per Arne Vollan  <pvollan@apple.com>
384
385         [Win] Some tests are flaky because certain DLLs are writing to stdout.
386         https://bugs.webkit.org/show_bug.cgi?id=166760
387
388         Reviewed by Darin Adler.
389
390         Some tests are flaky because certain DLLs are writing to stdout, giving incorrect test results.
391         We can work around that by duplicating and redirecting stdout.
392
393         * DumpRenderTree/PixelDumpSupport.cpp:
394         (dumpWebViewAsPixelsAndCompareWithExpected):
395         (printPNG):
396         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
397         (logEventProc):
398         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
399         (DRTDesktopNotificationPresenter::showDesktopNotification):
400         (DRTDesktopNotificationPresenter::cancelDesktopNotification):
401         (DRTDesktopNotificationPresenter::requestNotificationPermission):
402         * DumpRenderTree/win/DumpRenderTree.cpp:
403         (dumpFrameScrollPosition):
404         (dumpHistoryItem):
405         (dumpBackForwardList):
406         (dump):
407         (runTest):
408         (main):
409         * DumpRenderTree/win/DumpRenderTreeWin.h:
410         * DumpRenderTree/win/EditingDelegate.cpp:
411         (EditingDelegate::shouldBeginEditingInDOMRange):
412         (EditingDelegate::shouldEndEditingInDOMRange):
413         (EditingDelegate::shouldInsertNode):
414         (EditingDelegate::shouldInsertText):
415         (EditingDelegate::shouldDeleteDOMRange):
416         (EditingDelegate::shouldChangeSelectedDOMRange):
417         (EditingDelegate::shouldApplyStyle):
418         (EditingDelegate::shouldChangeTypingStyle):
419         (EditingDelegate::doPlatformCommand):
420         (EditingDelegate::webViewDidBeginEditing):
421         (EditingDelegate::webViewDidChange):
422         (EditingDelegate::webViewDidEndEditing):
423         (EditingDelegate::webViewDidChangeTypingStyle):
424         (EditingDelegate::webViewDidChangeSelection):
425         * DumpRenderTree/win/FrameLoadDelegate.cpp:
426         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
427         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame):
428         (FrameLoadDelegate::didChangeLocationWithinPageForFrame):
429         (FrameLoadDelegate::didFailProvisionalLoadWithError):
430         (FrameLoadDelegate::didCommitLoadForFrame):
431         (FrameLoadDelegate::didReceiveTitle):
432         (FrameLoadDelegate::didFinishLoadForFrame):
433         (FrameLoadDelegate::didFailLoadWithError):
434         (FrameLoadDelegate::willPerformClientRedirectToURL):
435         (FrameLoadDelegate::didCancelClientRedirectForFrame):
436         (FrameLoadDelegate::windowScriptObjectAvailable):
437         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
438         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
439         (FrameLoadDelegate::didDisplayInsecureContent):
440         (FrameLoadDelegate::didRunInsecureContent):
441         (FrameLoadDelegate::webViewProgressFinishedNotification):
442         * DumpRenderTree/win/HistoryDelegate.cpp:
443         (HistoryDelegate::didNavigateWithNavigationData):
444         (HistoryDelegate::didPerformClientRedirectFromURL):
445         (HistoryDelegate::didPerformServerRedirectFromURL):
446         (HistoryDelegate::updateHistoryTitle):
447         (HistoryDelegate::populateVisitedLinksForWebView):
448         * DumpRenderTree/win/PolicyDelegate.cpp:
449         (PolicyDelegate::decidePolicyForNavigationAction):
450         (PolicyDelegate::unableToImplementPolicyWithError):
451         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
452         (ResourceLoadDelegate::willSendRequest):
453         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
454         (ResourceLoadDelegate::didReceiveResponse):
455         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
456         (ResourceLoadDelegate::didFailLoadingWithError):
457         * DumpRenderTree/win/TestRunnerWin.cpp:
458         (TestRunner::addDisallowedURL):
459         (TestRunner::originsWithApplicationCache):
460         (TestRunner::setStorageDatabaseIdleInterval):
461         (TestRunner::closeIdleLocalStorageDatabases):
462         (TestRunner::copyDecodedHostName):
463         (TestRunner::copyEncodedHostName):
464         (TestRunner::numberOfPendingGeolocationPermissionRequests):
465         (TestRunner::isGeolocationProviderActive):
466         (TestRunner::pathToLocalResource):
467         (TestRunner::setMockDeviceOrientation):
468         (TestRunner::setMockGeolocationPosition):
469         (TestRunner::setMockGeolocationPositionUnavailableError):
470         (TestRunner::setSpatialNavigationEnabled):
471         (TestRunner::setAutomaticLinkDetectionEnabled):
472         (TestRunner::isCommandEnabled):
473         (TestRunner::authenticateSession):
474         (TestRunner::addChromeInputField):
475         (TestRunner::removeChromeInputField):
476         (TestRunner::focusWebView):
477         (TestRunner::grantWebNotificationPermission):
478         (TestRunner::denyWebNotificationPermission):
479         (TestRunner::removeAllWebNotificationPermissions):
480         (TestRunner::simulateWebNotificationClick):
481         (TestRunner::imageCountInGeneralPasteboard):
482         * DumpRenderTree/win/UIDelegate.cpp:
483         (UIDelegate::runJavaScriptAlertPanelWithMessage):
484         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
485         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
486         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
487         (UIDelegate::webViewAddMessageToConsole):
488         (UIDelegate::exceededDatabaseQuota):
489         (UIDelegate::setStatusText):
490         (UIDelegate::didPressMissingPluginButton):
491
492 2017-01-07  Tim Horton  <timothy_horton@apple.com>
493
494         Add a setting to create editable MiniBrowser windows by default
495         https://bugs.webkit.org/show_bug.cgi?id=166806
496
497         Reviewed by Beth Dakin.
498
499         * MiniBrowser/mac/AppDelegate.m:
500         (-[BrowserAppDelegate createBrowserWindowController:]):
501         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
502         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
503         * MiniBrowser/mac/SettingsController.h:
504         * MiniBrowser/mac/SettingsController.m:
505         (-[SettingsController _populateMenu]):
506         (-[SettingsController validateMenuItem:]):
507         (-[SettingsController toggleCreateEditorByDefault:]):
508         (-[SettingsController createEditorByDefault]):
509         Add a setting and update the key equivalents accordingly.
510         Also make sure to make the right kind of window on launch.
511
512 2017-01-07  Tim Horton  <timothy_horton@apple.com>
513
514         Fix the 32-bit build.
515
516         * MiniBrowser/mac/BrowserWindowController.h:
517         * MiniBrowser/mac/BrowserWindowController.m:
518
519 2017-01-07  Tim Horton  <timothy_horton@apple.com>
520
521         Fix the 32-bit build.
522
523         * MiniBrowser/mac/BrowserWindowController.m:
524
525 2017-01-07  Tim Horton  <timothy_horton@apple.com>
526
527         Make it possible to drop HTML files on the MiniBrowser icon
528         https://bugs.webkit.org/show_bug.cgi?id=166802
529
530         Reviewed by Simon Fraser.
531
532         * MiniBrowser/mac/AppDelegate.m:
533         (-[BrowserAppDelegate application:openFile:]):
534         * MiniBrowser/mac/Info.plist:
535         If you're using an editable window, the usual trick of dropping on the
536         window doesn't work anymore (it makes an <attachment> instead).
537
538 2017-01-07  Tim Horton  <timothy_horton@apple.com>
539
540         MiniBrowser window gets smaller each time it is instantiated
541         https://bugs.webkit.org/show_bug.cgi?id=166807
542
543         Reviewed by Andy Estes.
544
545         * MiniBrowser/mac/BrowserWindowController.m:
546         (-[BrowserWindowController windowDidLoad]):
547         * MiniBrowser/mac/BrowserWindow.xib:
548         Turn on full-window content view support with IB, instead of waiting
549         until after the views have been loaded. This seems to resolve the
550         longstanding ever-shrinking-window problem.
551
552 2017-01-07  Tim Horton  <timothy_horton@apple.com>
553
554         Add indent/outdent items to MiniBrowser's new format menu
555         https://bugs.webkit.org/show_bug.cgi?id=166805
556
557         Reviewed by Dan Bernstein.
558
559         * MiniBrowser/mac/MainMenu.xib:
560
561 2017-01-07  Tim Horton  <timothy_horton@apple.com>
562
563         Add a stock Format menu to MiniBrowser
564         https://bugs.webkit.org/show_bug.cgi?id=166804
565
566         Reviewed by Andy Estes.
567
568         * MiniBrowser/mac/MainMenu.xib:
569         Many of the features automatically work with editable web views.
570         However, this seems to expose a bug where none of the font-related features
571         (Cmd-B, for example) work until the first time the font panel is shown,
572         per process, which will need to be investigated separately.
573
574 2017-01-07  Tim Horton  <timothy_horton@apple.com>
575
576         Remove unused applicationWillTerminate methods from MiniBrowser
577         https://bugs.webkit.org/show_bug.cgi?id=166803
578
579         Reviewed by Andy Estes.
580
581         * MiniBrowser/mac/AppDelegate.m:
582         (-[BrowserAppDelegate applicationWillTerminate:]): Deleted.
583         * MiniBrowser/mac/BrowserWindowController.h:
584         * MiniBrowser/mac/BrowserWindowController.m:
585         (-[BrowserWindowController applicationTerminating]): Deleted.
586         * MiniBrowser/mac/WK1BrowserWindowController.m:
587         (-[WK1BrowserWindowController applicationTerminating]): Deleted.
588         * MiniBrowser/mac/WK2BrowserWindowController.m:
589         (-[WK2BrowserWindowController applicationTerminating]): Deleted.
590
591 2017-01-07  Tim Horton  <timothy_horton@apple.com>
592
593         Add the ability to create empty contentEditable windows in MiniBrowser
594         https://bugs.webkit.org/show_bug.cgi?id=166801
595
596         Reviewed by Wenson Hsieh.
597
598         * MiniBrowser/mac/AppDelegate.h:
599         * MiniBrowser/mac/AppDelegate.m:
600         (-[BrowserAppDelegate createBrowserWindowController:]):
601         (-[BrowserAppDelegate newWindow:]):
602         (-[BrowserAppDelegate newEditorWindow:]):
603         (-[BrowserAppDelegate openDocument:]):
604         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
605         * MiniBrowser/mac/BrowserWindowController.h:
606         * MiniBrowser/mac/BrowserWindowController.m:
607         (-[BrowserWindowController loadHTMLString:]):
608         (-[BrowserWindowController toggleEditable:]):
609         * MiniBrowser/mac/MainMenu.xib:
610         * MiniBrowser/mac/WK1BrowserWindowController.m:
611         (-[WK1BrowserWindowController awakeFromNib]):
612         (-[WK1BrowserWindowController loadHTMLString:]):
613         (-[WK1BrowserWindowController validateMenuItem:]):
614         (-[WK1BrowserWindowController setEditable:]):
615         (-[WK1BrowserWindowController updateTitle:]):
616         * MiniBrowser/mac/WK2BrowserWindowController.m:
617         (-[WK2BrowserWindowController awakeFromNib]):
618         (-[WK2BrowserWindowController validateMenuItem:]):
619         (-[WK2BrowserWindowController setEditable:]):
620         (-[WK2BrowserWindowController updateTitle:]):
621         (-[WK2BrowserWindowController loadHTMLString:]):
622         Merge more functionality from WebEditingTester.
623         Add two menu items for creating empty editable WebKit1/2 windows.
624         Add a menu item to the Edit menu to toggle editability on any window.
625
626 2017-01-07  Tim Horton  <timothy_horton@apple.com>
627
628         Implement find-in-page in MiniBrowser
629         https://bugs.webkit.org/show_bug.cgi?id=166799
630
631         Reviewed by Andy Estes.
632
633         * MiniBrowser/mac/BrowserWindow.xib:
634         * MiniBrowser/mac/BrowserWindowController.h:
635         * MiniBrowser/mac/BrowserWindowController.m:
636         (-[BrowserWindowController find:]): Deleted.
637         * MiniBrowser/mac/MainMenu.xib:
638         * MiniBrowser/mac/WK1BrowserWindowController.m:
639         (-[WK1BrowserWindowController toggleShrinkToFit:]):
640         (-[WK1BrowserWindowController find:]): Deleted.
641         * MiniBrowser/mac/WK2BrowserWindowController.m:
642         (-[WK2BrowserWindowController awakeFromNib]):
643         (-[WK2BrowserWindowController dealloc]):
644         (-[WK2BrowserWindowController validateMenuItem:]):
645         (-[WK2BrowserWindowController performTextFinderAction:]):
646         (-[WK2BrowserWindowController findBarView]):
647         (-[WK2BrowserWindowController setFindBarView:]):
648         (-[WK2BrowserWindowController isFindBarVisible]):
649         (-[WK2BrowserWindowController setFindBarVisible:]):
650         (-[WK2BrowserWindowController contentView]):
651         (-[WK2BrowserWindowController findBarViewDidChangeHeight]):
652         (-[WK2BrowserWindowController performFindPanelAction:]): Deleted.
653         (-[WK2BrowserWindowController find:]): Deleted.
654         Implement find-in-page using WKWebView's conformance to the NSTextFinderClient
655         protocol. At first glance, it's pretty broken, but vaguely works.
656
657 2017-01-07  Tim Horton  <timothy_horton@apple.com>
658
659         Share the implementation of MiniBrowser view hiding functionality
660         https://bugs.webkit.org/show_bug.cgi?id=166800
661
662         Reviewed by Andy Estes.
663
664         * MiniBrowser/mac/BrowserWindowController.m:
665         (-[BrowserWindowController showHideWebView:]):
666         (-[BrowserWindowController removeReinsertWebView:]):
667         * MiniBrowser/mac/WK1BrowserWindowController.m:
668         (-[WK1BrowserWindowController showHideWebView:]): Deleted.
669         (-[WK1BrowserWindowController removeReinsertWebView:]): Deleted.
670         * MiniBrowser/mac/WK2BrowserWindowController.m:
671         (-[WK2BrowserWindowController showHideWebView:]): Deleted.
672         (-[WK2BrowserWindowController removeReinsertWebView:]): Deleted.
673         Move the implementation of these two things to the shared superclass,
674         since they don't depend on WebKit-specific things.
675         Also, there was no reason to retain the (WK)WebView while it was unparented,
676         as the BrowserWindowController maintains a reference the entire time.
677
678 2017-01-06  Andy Estes  <aestes@apple.com>
679
680         [Cocoa] Consolidate duplicate copies of WebArchiveDumpSupport in DRT and WKTR into WebCoreTestSupport
681         https://bugs.webkit.org/show_bug.cgi?id=166789
682
683         Reviewed by Alex Christensen.
684
685         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
686         * DumpRenderTree/PlatformMac.cmake:
687         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp: Removed.
688         * DumpRenderTree/cf/WebArchiveDumpSupport.h: Removed.
689         * DumpRenderTree/mac/DumpRenderTree.mm:
690         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
691         createXMLStringFromWebArchiveData().
692         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm: Removed.
693         * WebKitTestRunner/Configurations/Base.xcconfig:
694         Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to HEADER_SEARCH_PATHS.
695         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
696         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
697         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
698         createXMLStringFromWebArchiveData().
699         * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Removed.
700         * WebKitTestRunner/PlatformMac.cmake:
701         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
702         * WebKitTestRunner/cf/WebArchiveDumpSupport.h: Removed.
703
704 2017-01-06  Tim Horton  <timothy_horton@apple.com>
705
706         Minor cleanups to IndentOutdentCommand and related code
707         https://bugs.webkit.org/show_bug.cgi?id=166791
708
709         Reviewed by Simon Fraser.
710
711         * WebEditingTester/EditingOperations.m:
712         (editingOperations):
713         Add the outdent operation to WebEditingTester.
714
715 2017-01-06  Said Abou-Hallawa  <sabouhallawa@apple.com>
716
717         Create a plan and a patch files for MotionMark and delete the Animometer's ones
718         https://bugs.webkit.org/show_bug.cgi?id=166785
719
720         Reviewed by Ryosuke Niwa.
721
722         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
723         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan.
724
725 2017-01-06  Antoine Quint  <graouts@apple.com>
726
727         Support webkit-test-runner key-value pairs in http tests
728         https://bugs.webkit.org/show_bug.cgi?id=149812
729
730         Reviewed by Alex Christensen.
731
732         We pass the absolute path for a test through to WKTR so that we can parse
733         tests that are running as URLs for webkit-test-runner options.
734
735         * DumpRenderTree/DumpRenderTreeCommon.cpp:
736         (parseInputLine):
737
738         Explicitly skip the --absolute-path option in DRT or else we'd crash.
739
740         * Scripts/webkitpy/port/driver.py:
741         (Driver._command_from_driver_input):
742
743         Pass the absolute path to the file through the CLI.
744
745         * WebKitTestRunner/TestController.cpp:
746         (WTR::updateTestOptionsFromTestHeader):
747         (WTR::TestController::testOptionsForTest):
748         (WTR::parseInputLine):
749         (WTR::TestController::runTest):
750         * WebKitTestRunner/TestController.h:
751
752 2017-01-06  Tim Horton  <timothy_horton@apple.com>
753
754         Warning about unconnectable outlets when opening a MiniBrowser window
755         https://bugs.webkit.org/show_bug.cgi?id=166756
756
757         Reviewed by Dan Bernstein.
758
759         * MiniBrowser/mac/BrowserWindow.xib:
760         When launching MiniBrowser, it says:
761         Failed to connect (Share) outlet from (WK1BrowserWindowController) to
762             (MBToolbarItem): missing setter or instance variable
763         Failed to connect (shareButton) outlet from (WK1BrowserWindowController) to
764             (NSButtonCell): missing setter or instance variable.
765
766         It looks like someone added the connection from the share button
767         to the BrowserWindowController three times; only one of the connections
768         is valid. Remove the other two.
769
770 2017-01-05  Keith Rollin  <krollin@apple.com>
771
772         Add WebCore::URL::protocolHostAndPort
773         https://bugs.webkit.org/show_bug.cgi?id=166426
774
775         Reviewed by Alex Christensen.
776
777         Add test for protocolHostAndPort.
778
779         * TestWebKitAPI/Tests/WebCore/URL.cpp:
780         (TestWebKitAPI::TEST_F):
781
782 2017-01-05  Per Arne Vollan  <pvollan@apple.com>
783
784         [Win] Archive test result is failing.
785         https://bugs.webkit.org/show_bug.cgi?id=166720
786
787         Reviewed by Alex Christensen.
788
789         Deleting the layout test result folder is sometimes failing
790         on Windows. This is not a critical error.
791
792         * BuildSlaveSupport/test-result-archive:
793         (archiveTestResults):
794
795 2017-01-04  Tomas Popela  <tpopela@redhat.com>
796
797         [GTK] Minibrowser: Add printing support
798         https://bugs.webkit.org/show_bug.cgi?id=165298
799
800         Open a print dialog when the Ctrl + P shortcut is pressed. If there is
801         an error during the print, it's printed on the console.
802
803         Reviewed by Michael Catanzaro.
804
805         * MiniBrowser/gtk/BrowserWindow.c:
806         (webKitPrintOperationFailedCallback):
807         (printPage):
808         (browser_window_init):
809
810 2017-01-04  Manuel Rego Casasnovas  <rego@igalia.com>
811
812         [css-grid] Fix crash clamping grid lines
813         https://bugs.webkit.org/show_bug.cgi?id=166637
814
815         Reviewed by Darin Adler.
816
817         Creates new unit test to verify that the maximum tracks limit
818         is used in GridPosition too.
819
820         * TestWebKitAPI/PlatformEfl.cmake:
821         * TestWebKitAPI/PlatformGTK.cmake:
822         * TestWebKitAPI/PlatformWin.cmake:
823         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
824         * TestWebKitAPI/Tests/WebCore/GridPosition.cpp: Added.
825         (TestWebKitAPI::TEST):
826
827 2017-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
828
829         Move editing history scripts to WebCore PrivateHeaders
830         https://bugs.webkit.org/show_bug.cgi?id=166709
831         <rdar://problem/29876612>
832
833         Reviewed by Dan Bernstein.
834
835         Update references to editing script files in WebCore that were moved.
836
837         * EditingHistory/EditingHistory.xcodeproj/project.pbxproj:
838
839 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
840
841         Unreviewed, build fix after r210313 part 2
842         https://bugs.webkit.org/show_bug.cgi?id=166676
843
844         Add 'U' suffix.
845
846         * TestWebKitAPI/Tests/WTF/StringView.cpp:
847         (TestWebKitAPI::TEST):
848         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
849         (TestWebKitAPI::TEST):
850
851 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
852
853         Limit thread name appropriately
854         https://bugs.webkit.org/show_bug.cgi?id=166676
855
856         Reviewed by Sam Weinig.
857
858         * TestWebKitAPI/Tests/WTF/StringView.cpp:
859         (TestWebKitAPI::TEST):
860         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
861         (TestWebKitAPI::TEST):
862
863 2017-01-04  Andy Estes  <aestes@apple.com>
864
865         [Cocoa] Teach SharedBuffer to return an NSArray of data segments to avoid flattening
866         https://bugs.webkit.org/show_bug.cgi?id=166696
867
868         Reviewed by Tim Horton.
869
870         * TestWebKitAPI/PlatformGTK.cmake:
871         * TestWebKitAPI/PlatformWin.cmake:
872         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
873         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp: Moved class SharedBufferTest to SharedBufferTest.{cpp,h}.
874         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp: Moved class SharedBufferTest from SharedBuffer.cpp.
875         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.h: Ditto.
876         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm: Added.
877         (TestWebKitAPI::expectDataArraysEqual): Added a helper to assert that two NSArrays of NSData are equal.
878         (TestWebKitAPI::TEST_F): Added a test for createNSDataArray.
879
880 2017-01-03  Brian Burg  <bburg@apple.com>
881
882         Web Inspector: teach the protocol generator about platform-specific types, events, and commands
883         https://bugs.webkit.org/show_bug.cgi?id=166003
884         <rdar://problem/28718990>
885
886         Reviewed by Joseph Pecoraro.
887
888         Teach run-inspector-generator-tests to generate test output using the platform name
889         derived from the directory that the test is in. For example, tests in the /generic/
890         subdirectory will pass `--platform generic` to generate-inspector-protocol-bindings.py.
891
892         * Scripts/webkitpy/inspector/main.py:
893         (InspectorGeneratorTests.generate_from_json):
894         (InspectorGeneratorTests.run_tests):
895         (InspectorGeneratorTests.main):
896
897 2017-01-04  Csaba Osztrogonác  <ossy@webkit.org>
898
899         Unreviewed cmake buildfix after r210266.
900
901         * DumpRenderTree/PlatformMac.cmake:
902
903 2017-01-04  Tim Horton  <timothy_horton@apple.com>
904
905         Provide a setting for clients to always prefer low-power WebGL
906         https://bugs.webkit.org/show_bug.cgi?id=166675
907         <rdar://problem/29834093>
908
909         Reviewed by Dan Bernstein.
910
911         * MiniBrowser/mac/Info.plist:
912         Have MiniBrowser claim to be a modern app that supports
913         automatic graphics switching. WebKit needs to support automatic
914         graphics switching, so our test app might as well. Without this
915         Info.plist parameter, this change has no effect, and bringing up
916         a WebGL context still brings up the discrete GPU (also true of the
917         existing web-exposed preferLowPowerToHighPerformance API).
918
919 2017-01-03  Yusuke Suzuki  <utatane.tea@gmail.com>
920
921         WorkQueueGeneric's platformInvalidate() can deadlock when called on the RunLoop's thread
922         https://bugs.webkit.org/show_bug.cgi?id=166645
923
924         Reviewed by Carlos Garcia Campos.
925
926         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
927         (TestWebKitAPI::TEST):
928
929 2017-01-03  Andy Estes  <aestes@apple.com>
930
931         Place all the Cocoa WebCore API tests in the same directory
932         https://bugs.webkit.org/show_bug.cgi?id=166673
933
934         Reviewed by Michael Catanzaro.
935
936         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
937         * TestWebKitAPI/Tests/WebCore/cocoa/SerializedCryptoKeyWrap.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/SerializedCryptoKeyWrap.mm.
938         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/Cocoa/URLExtras.mm.
939         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm.
940
941 2017-01-03  Tim Horton  <timothy_horton@apple.com>
942
943         NSSpellChecker's recordResponse isn't called for unseen automatic corrections
944         https://bugs.webkit.org/show_bug.cgi?id=166450
945         <rdar://problem/29447824>
946
947         Reviewed by Darin Adler.
948
949         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
950         * DumpRenderTree/TestRunner.cpp:
951         (TestRunner::staticFunctions):
952         * DumpRenderTree/mac/TestRunnerMac.mm:
953         (setSpellCheckerLoggingEnabledCallback):
954         * DumpRenderTree/win/TestRunnerWin.cpp:
955         (setSpellCheckerLoggingEnabledCallback):
956         * DumpRenderTree/mac/DumpRenderTree.mm:
957         (resetWebViewToConsistentStateBeforeTesting):
958         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.h: Added.
959         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.mm: Added.
960         (stringForCorrectionResponse):
961         (drt_NSSpellChecker_recordResponseToCorrection):
962         (swizzleNSSpellCheckerMethodsIfNeeded):
963         (setSpellCheckerLoggingEnabled):
964         Add a new testRunner method, setSpellCheckerLoggingEnabled, which, when
965         set to true, logs to stdout (which ends up in the test result) whenever
966         NSSpellChecker recordResponse:toCorrection:forWord:language:inSpellDocumentWithTag:
967         is called, and then calls the original method. It is reset to false between tests.
968
969 2017-01-03  Sam Weinig  <sam@webkit.org>
970
971         Make WTF::Expected support Ref template parameters
972         https://bugs.webkit.org/show_bug.cgi?id=166662
973
974         Reviewed by Alex Christensen.
975
976         * TestWebKitAPI/Tests/WTF/Expected.cpp:
977         (TestWebKitAPI::TEST):
978         Add tests for using Ref with Expected.
979
980 2017-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
981
982         [GTK] Expose WebKitSecurityOrigin API
983         https://bugs.webkit.org/show_bug.cgi?id=166632
984
985         Reviewed by Carlos Garcia Campos.
986
987         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
988         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSecurityOrigin.cpp: Added.
989         (testSecurityOriginBasicConstructor):
990         (testSecurityOriginURIConstructor):
991         (testSecurityOriginDefaultPort):
992         (testSecurityOriginFileURI):
993         (testSecurityOriginDataURI):
994         (beforeAll):
995         (afterAll):
996
997 2017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
998
999         [GTK] HTTP auth layout tests are flaky
1000         https://bugs.webkit.org/show_bug.cgi?id=158919
1001
1002         Reviewed by Michael Catanzaro.
1003
1004         * gtk/jhbuild.modules: Update libsoup to version 2.57.1.
1005         * gtk/jhbuildrc: Stop passing --enable-introspection unconditionally to all modules. We don't really need
1006         introspection for the dependencies in the internal build, and it makes newer libsoup build fail because of
1007         missing valac in the bots.
1008
1009 2017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1010
1011         REGRESSION(r173753): [GTK] Source/WebKit is distributed in tarballs
1012         https://bugs.webkit.org/show_bug.cgi?id=165797
1013
1014         Reviewed by Michael Catanzaro.
1015
1016         Move directory ruleset after all exclude rules of Source rulset.
1017
1018         * gtk/manifest.txt.in:
1019
1020 2017-01-02  Yusuke Suzuki  <utatane.tea@gmail.com>
1021
1022         Leverage Substring to create new AtomicStringImpl for StaticStringImpl and SymbolImpl
1023         https://bugs.webkit.org/show_bug.cgi?id=166636
1024
1025         Reviewed by Darin Adler.
1026
1027         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1028         (TestWebKitAPI::TEST):
1029
1030 2017-01-02  Manuel Rego Casasnovas  <rego@igalia.com>
1031
1032         [GTK] WebCore/CSSParser unit test is not being built
1033         https://bugs.webkit.org/show_bug.cgi?id=166492
1034
1035         Reviewed by Michael Catanzaro.
1036
1037         This test was introduced in r175930, but we were not building
1038         it on GTK+ port since r176015.
1039         This patch marks the test to be built again on GTK+.
1040         JFTR, the test is passing right now.
1041
1042         * TestWebKitAPI/PlatformGTK.cmake: Add CSSParser.cpp test file and use
1043         ADD_WHOLE_ARCHIVE_TO_LIBRARIES to avoid linking errors.
1044
1045 2017-01-02  Chris Fleizach  <cfleizach@apple.com>
1046
1047         AX: Expose block quote level to iOS API
1048         https://bugs.webkit.org/show_bug.cgi?id=166629
1049         <rdar://problem/29834793>
1050
1051         Reviewed by Darin Adler.
1052
1053         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1054         (AccessibilityUIElement::numberAttributeValue):
1055         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1056         (WTR::AccessibilityUIElement::numberAttributeValue):
1057
1058 2016-12-31  Michael Catanzaro  <mcatanzaro@igalia.com>
1059
1060         SecurityOrigin::create triplet constructor does not canonicalize port
1061         https://bugs.webkit.org/show_bug.cgi?id=166624
1062
1063         Reviewed by Daniel Bates.
1064
1065         * TestWebKitAPI/PlatformGTK.cmake:
1066         * TestWebKitAPI/PlatformWin.cmake:
1067         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1068         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Added.
1069         (TestWebKitAPI::SecurityOriginTest::SetUp):
1070         (TestWebKitAPI::TEST_F):
1071
1072 2016-12-30  Michael Catanzaro  <mcatanzaro@igalia.com>
1073
1074         [GTK] Improve user agent construction
1075         https://bugs.webkit.org/show_bug.cgi?id=142074
1076
1077         Reviewed by Carlos Garcia Campos.
1078
1079         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1080         (TestWebKitAPI::assertUserAgentForURLHasChromeBrowserQuirk):
1081         (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk):
1082         (TestWebKitAPI::assertUserAgentForURLHasLinuxPlatformQuirk):
1083         (TestWebKitAPI::assertUserAgentForURLHasMacPlatformQuirk):
1084         (TestWebKitAPI::TEST):
1085
1086 2016-12-27  Michael Catanzaro  <mcatanzaro@igalia.com>
1087
1088         [GTK] Improve user agent construction
1089         https://bugs.webkit.org/show_bug.cgi?id=142074
1090
1091         Reviewed by Carlos Garcia Campos.
1092
1093         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1094         (TestWebKitAPI::TEST):
1095
1096 2016-12-23  Simon Fraser  <simon.fraser@apple.com>
1097
1098         REGRESSION (r209299): Selection is broken when you zoom in webpage using trackpad
1099         https://bugs.webkit.org/show_bug.cgi?id=166472
1100         rdar://problem/29675551
1101
1102         Reviewed by Tim Horton.
1103
1104         These changes are necessary to allow the mouse to leave the WTR window while
1105         drag-scrolling, to test autoscroll. Previously, we were never calling -mouseDragged
1106         (which DRT does); we'd always go through mouseMoved, which hits an early return
1107         in WebViewImpl::mouseMoved() when the point is outside the view.
1108
1109         * WebKitTestRunner/mac/EventSenderProxy.mm:
1110         (WTR::EventSenderProxy::mouseMoveTo):
1111
1112 2016-12-23  Andy Estes  <aestes@apple.com>
1113
1114         [iOS] Fix some crashing webarchive tests
1115         https://bugs.webkit.org/show_bug.cgi?id=166470
1116
1117         Reviewed by Andreas Kling.
1118
1119         Tests that use TestRunner.dumpDOMAsWebArchive() crashed on iOS due to a stub implementation
1120         of WebArchiveDumpSupport in WebKitTestRunner. The Mac implementation works fine on iOS too,
1121         so this change uses that on both platforms.
1122
1123         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Removed
1124         WebArchiveDumpSupportMac.mm from EXCLUDED_SOURCE_FILE_NAMES.
1125         * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Renamed from
1126         Tools/WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm.
1127         * WebKitTestRunner/PlatformMac.cmake:
1128         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1129         * WebKitTestRunner/ios/WebArchiveDumpSupportIOS.mm: Removed.
1130
1131 2016-12-22  Saam Barati  <sbarati@apple.com>
1132
1133         WebAssembly: Silence the output of the spec-tests
1134         https://bugs.webkit.org/show_bug.cgi?id=166417
1135
1136         Reviewed by Mark Lam.
1137
1138         * Scripts/run-jsc-stress-tests:
1139
1140 2016-12-22  Zhuo Li  <zachli@apple.com>
1141
1142         [Cocoa] SPI for setloadsImagesAutomatically.
1143         https://bugs.webkit.org/show_bug.cgi?id=166401.
1144
1145         Reviewed by Darin Adler.
1146
1147         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
1148         (TEST): Test the _setLoadsImagesAutomatically SPI. By default,
1149         _loadsImagesAutomatically returns YES.
1150
1151 2016-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1152
1153         fast/events/ios/viewport-shrink-to-fit-allows-double-tap.html is flaky/order dependent
1154         https://bugs.webkit.org/show_bug.cgi?id=161328
1155         <rdar://problem/28475977>
1156
1157         Reviewed by Darin Adler.
1158
1159         Running a test that scales the viewport and listens to a didEndZooming callback (such as
1160         viewport-shrink-to-fit-allows-double-tap.html) immediately after a test that may begin to trigger viewport
1161         scaling as the test completes (such as viewport-device-width-at-initial-scale-fast-clicks.html) may result in
1162         the didEndZooming callback of the latter test being fired early due to the previous test triggering a zoom
1163         animation. Ideally, -[WKScrollView _stopScrollingAndZoomingAnimations], which is called when committing the page
1164         load, should prevent this from happening, but from reading documentation and code inspection, this is not
1165         intended to fire any associated delegate methods or notifications of the UIScrollView, instead deferring them
1166         for later. Instead, what we need in this case is to clear out any started but not yet completed animations after
1167         we finish running a test and before we load the next test.
1168
1169         One way to do this is to remove all animations from the WKScrollView's layer, and the layers of its children,
1170         recursively. Doing so causes scrollViewDidEndZooming:withView:atScale: to fire at the end of the runloop if the
1171         previous test started zooming and then finished before zooming completed. Since this happens before the next
1172         test has a chance to run UI-side scripts, we won't end up firing this callback prematurely during the next test.
1173
1174         * WebKitTestRunner/ios/TestControllerIOS.mm:
1175         (WTR::TestController::platformResetStateToConsistentValues):
1176
1177 2016-12-22  Jer Noble  <jer.noble@apple.com>
1178
1179         Muted media element playback should not interrupt other audio playback
1180         https://bugs.webkit.org/show_bug.cgi?id=166347
1181
1182         Reviewed by Eric Carlson.
1183
1184         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1185         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
1186         (TestWebKitAPI::TEST):
1187         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio.html: Added.
1188
1189 2016-12-22  Alejandro G. Castro  <alex@igalia.com>
1190
1191         [WebRTC] Add support for runtime PeeConnection setting, required after r209757
1192         https://bugs.webkit.org/show_bug.cgi?id=166346
1193
1194         Reviewed by Carlos Garcia Campos.
1195
1196         Enable WebRTC by default to simplify testing.
1197
1198         * MiniBrowser/gtk/main.c:
1199         (main):
1200
1201 2016-12-21  Alexey Proskuryakov  <ap@apple.com>
1202
1203         REGRESSION: API test failure: WKWebView.LocalStorageClear
1204         https://bugs.webkit.org/show_bug.cgi?id=166032
1205         <rdar://problem/29758423>
1206
1207         Reviewed by Simon Fraser.
1208
1209         Add an @autoreleasepool around the code that allocates then clears the WKWebView, 
1210         to ensure that the view is destroyed before the callback fires.
1211
1212         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
1213         (TEST):
1214
1215 2016-12-21  Saam Barati  <sbarati@apple.com>
1216
1217         WebAssembly: Import spec tests
1218         https://bugs.webkit.org/show_bug.cgi?id=166395
1219
1220         Rubber stamped by Keith Miller.
1221
1222         * Scripts/run-jsc-stress-tests:
1223
1224 2016-12-21  Alexey Proskuryakov  <ap@apple.com>
1225
1226         REGRESSION: API test failure: _WKDownload.OriginatingWebView
1227         https://bugs.webkit.org/show_bug.cgi?id=166033
1228         <rdar://problem/29758428>
1229
1230         Reviewed by Simon Fraser.
1231
1232         Add an @autoreleasepool around the code that allocates the WKWebView, 
1233         so that it can be destroyed by removing the last reference in _downloadDidStart.
1234
1235         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1236         (TEST):
1237
1238 2016-12-21  Daniel Bates  <dabates@apple.com>
1239
1240         WebKitTestRunner: Add comment to TestRunner::setCanOpenWindows()
1241         https://bugs.webkit.org/show_bug.cgi?id=166356
1242
1243         Add comment in TestRunner::setCanOpenWindows() to elaborate further on its purpose
1244         as a means to allow a test to explicit allow an embedding client to open a new windows
1245         such that the default behavior is for the embedding client to forbid such an action.
1246         The test plugins/get-url-with-blank-target.html assumes this default behavior though
1247         it is currently skipped on WebKit2 because questions were raised in the patch for
1248         <https://bugs.webkit.org/show_bug.cgi?id=43389> about its correctness and usefulness.
1249         We will need to implement TestRunner::setCanOpenWindows() should we decide to unskip
1250         this test.
1251
1252         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1253         (WTR::TestRunner::setCanOpenWindows):
1254
1255 2016-12-20  Simon Fraser  <simon.fraser@apple.com>
1256
1257         REGRESSION: API test failure: WKWebView.EvaluateJavaScriptBlockCrash
1258         https://bugs.webkit.org/show_bug.cgi?id=166031
1259
1260         Reviewed by Tim Horton.
1261         
1262         Add an @autoreleasepool around the code that allocates then clears the WKWebView, 
1263         to ensure that the view is destroyed before the callback fires.
1264
1265         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
1266
1267 2016-12-20  Megan Gardner  <megan_gardner@apple.com>
1268
1269         Throw Exception when test doesn't clean up HID Events properly
1270         https://bugs.webkit.org/show_bug.cgi?id=166271
1271
1272         Reviewed by Simon Fraser.
1273
1274         Add in a check when UIScriptController is deleted to make sure that the HID event
1275         callback dictionary is empty. If it is not, and a HID event is hit, this will cause
1276         the program to crash without any good information. Crashes are race-y, and will still
1277         happen with malformed test, but the information will be much more helpful. 
1278
1279         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1280         (WTR::UIScriptController::checkForClean):
1281         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
1282         (UIScriptContext::~UIScriptContext):
1283         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1284         (WTR::UIScriptController::checkForClean):
1285         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1286         * WebKitTestRunner/ios/HIDEventGenerator.h:
1287         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1288         (-[HIDEventGenerator checkHIDCallbacksClear]):
1289         * WebKitTestRunner/ios/TestControllerIOS.mm:
1290         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1291         (WTR::UIScriptController::checkForClean):
1292
1293 2016-12-20  Andy Estes  <aestes@apple.com>
1294
1295         [Cocoa] REGRESSION (r209558): Calling decisionHandler multiple times in webView:decidePolicyForNavigationAction:decisionHandler: leads to a crash
1296         https://bugs.webkit.org/show_bug.cgi?id=165992
1297
1298         Reviewed by Brady Eidson.
1299
1300         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1301         * TestWebKitAPI/Tests/WebKit2Cocoa/DuplicateCompletionHandlerCalls.mm: Added.
1302         (expectException):
1303         (-[DuplicateCompletionHandlerCallsDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1304         (-[DuplicateCompletionHandlerCallsDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1305         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1306         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
1307         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
1308         (-[DuplicateCompletionHandlerCallsDelegate _webView:decideDatabaseQuotaForSecurityOrigin:currentQuota:currentOriginUsage:currentDatabaseUsage:expectedUsage:decisionHandler:]):
1309         (-[DuplicateCompletionHandlerCallsDelegate _webView:willSubmitFormValues:userObject:submissionHandler:]):
1310         (TEST):
1311         * TestWebKitAPI/Tests/WebKit2Cocoa/duplicate-completion-handler-calls.html: Added.
1312
1313 2016-12-20  Dean Jackson  <dino@apple.com>
1314
1315         Remove INDIE_UI
1316         https://bugs.webkit.org/show_bug.cgi?id=165881
1317         <rdar://problem/29672532>
1318
1319         Reviewed by Simon Fraser.
1320
1321         The Indie UI work has been discontinued.
1322
1323         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1324
1325 2016-12-19  Yusuke Suzuki  <utatane.tea@gmail.com>
1326
1327         [ES6] Enable ES6 Modules
1328         https://bugs.webkit.org/show_bug.cgi?id=165849
1329
1330         Reviewed by Geoffrey Garen.
1331
1332         * DumpRenderTree/mac/DumpRenderTree.mm:
1333         (resetWebPreferencesToConsistentValues):
1334         * DumpRenderTree/win/DumpRenderTree.cpp:
1335         (resetWebPreferencesToConsistentValues):
1336         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1337         (WTR::InjectedBundle::beginTesting):
1338         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1339         (WTR::TestRunner::setES6ModulesEnabled): Deleted.
1340         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1341
1342 2016-12-19  Ryan Haddad  <ryanhaddad@apple.com>
1343
1344         Repurpose bots and clean up dashboard.
1345         https://bugs.webkit.org/show_bug.cgi?id=166045
1346
1347         Reviewed by Lucas Forschler.
1348
1349         * BuildSlaveSupport/build.webkit.org-config/config.json:
1350         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1351         (BubbleQueueServer):
1352         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1353         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1354         (WebKitBuildbot):
1355         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1356         (table.queue-grid tr.platform.mac-os-x-yosemite img.logo): Deleted.
1357
1358 2016-12-19  Michael Catanzaro  <mcatanzaro@igalia.com>
1359
1360         [CMake] TestWebKitAPIBase links to itself
1361         https://bugs.webkit.org/show_bug.cgi?id=165985
1362
1363         Reviewed by Alex Christensen.
1364
1365         Fix CMake warning about a target linking to itself, which makes no sense.
1366
1367         * TestWebKitAPI/CMakeLists.txt:
1368
1369 2016-12-19  Michael Catanzaro  <mcatanzaro@igalia.com>
1370
1371         [GTK] GtkDoc build should be quieter
1372         https://bugs.webkit.org/show_bug.cgi?id=165994
1373
1374         Reviewed by Carlos Garcia Campos.
1375
1376         Make it not print by default.
1377
1378         * gtk/generate-gtkdoc:
1379         (get_generator_for_config):
1380         (generate_doc):
1381         * gtk/gtkdoc.py:
1382         (GTKDoc._run_command):
1383         (GTKDoc._copy_doc_files_to_output_dir):
1384
1385 2016-12-18  Simon Fraser  <simon.fraser@apple.com>
1386
1387         Expose a way for MiniBrowser to simulate header and footer banners
1388         https://bugs.webkit.org/show_bug.cgi?id=166005
1389
1390         Reviewed by Wenson Hsieh.
1391         
1392         Add a MiniBrowser menu item and setting to toggle adding space for header and footer
1393         banners. This only works in WebKit2.
1394         
1395         We need to reset these on each navigation, since newly created FrameViews
1396         don't re-fetch the header and footer height stored on Page.
1397         
1398         Also fix the signature of webView:didFinishNavigation: to follow API changes,
1399         as well as fixing webViewWebContentProcessDidTerminate:
1400
1401         * MiniBrowser/mac/SettingsController.h:
1402         * MiniBrowser/mac/SettingsController.m:
1403         (-[SettingsController _populateMenu]):
1404         (-[SettingsController validateMenuItem:]):
1405         (-[SettingsController toggleReserveSpaceForBanners:]):
1406         (-[SettingsController isSpaceReservedForBanners]):
1407         * MiniBrowser/mac/WK2BrowserWindowController.m:
1408         (-[WK2BrowserWindowController didChangeSettings]):
1409         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
1410         (-[WK2BrowserWindowController webViewWebContentProcessDidTerminate:]):
1411         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]): Deleted.
1412         (-[WK2BrowserWindowController _webViewWebProcessDidCrash:]): Deleted.
1413
1414 2016-12-17  Simon Fraser  <simon.fraser@apple.com>
1415
1416         Fix iOS test results after r209967.
1417         
1418         Subtracting out the status bar height was erroneously happening for all tests,
1419         not just for flexible viewport tests.
1420         
1421         Fix by plumbing WebViewSizingMode through resizeTo() and setWindowFrame().
1422
1423         * WebKitTestRunner/PlatformWebView.h:
1424         * WebKitTestRunner/TestController.cpp:
1425         (WTR::TestController::resetStateToConsistentValues):
1426         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1427         (WTR::PlatformWebView::resizeTo):
1428         (WTR::PlatformWebView::setWindowFrame):
1429         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1430         (WTR::PlatformWebView::resizeTo):
1431         (WTR::PlatformWebView::setWindowFrame):
1432         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1433         (WTR::PlatformWebView::resizeTo):
1434         (WTR::PlatformWebView::setWindowFrame):
1435         * WebKitTestRunner/ios/TestControllerIOS.mm:
1436         (WTR::TestController::platformConfigureViewForTest):
1437         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1438         (WTR::PlatformWebView::resizeTo):
1439         (WTR::PlatformWebView::setWindowFrame):
1440
1441 2016-12-17  Joonghun Park  <jh718.park@samsung.com>
1442
1443         [EFL] bump EFL version to 1.18.4
1444         https://bugs.webkit.org/show_bug.cgi?id=166004
1445
1446         Reviewed by Gyuyoung Kim.
1447
1448         * efl/jhbuild.modules: Use efl-1.18.4 instead of 1.18.1.
1449
1450 2016-12-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1451
1452         Visual viewports: bottom fixed elements disappear behind the keyboard
1453         https://bugs.webkit.org/show_bug.cgi?id=165983
1454         <rdar://problem/29409852>
1455
1456         Reviewed by Simon Fraser.
1457
1458         Add support for UIScriptController.inputViewBounds, which UI-side scripts may use to fetch the bounding rect of
1459         the keyboard when it is up.
1460
1461         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1462         (WTR::UIScriptController::inputViewBounds):
1463         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1464         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1465         (WTR::UIScriptController::inputViewBounds):
1466         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1467         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1468         (WTR::viewRectForWindowRect):
1469
1470         Previously, we accounted for the status bar height by translating the entire web view down by the height of the
1471         status bar. However, we did not shrink the height of the web view itself, which means that for tests which
1472         involve scrolling past the end of the document, the bottom strip of the web view is out of bounds of the window.
1473
1474         (WTR::PlatformWebView::PlatformWebView):
1475         (WTR::PlatformWebView::setWindowFrame):
1476         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1477         (WTR::UIScriptController::inputViewBounds):
1478
1479 2016-12-16  Ryosuke Niwa  <rniwa@webkit.org>
1480
1481         Deleting a character converted from pinyin after an image causes a Safari crash
1482         https://bugs.webkit.org/show_bug.cgi?id=165839
1483         <rdar://problem/27951933>
1484
1485         Reviewed by Wenson Hsieh.
1486
1487         Add a WebKit API test to call attributedSubstringForProposedRange on a WKWebView
1488         while the proposed range contains an image. This should not cause a WebProcess to crash
1489         or send an invalid message to the UIProcess.
1490
1491         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1492         * TestWebKitAPI/Tests/WebKit2/chinese-character-with-image.html: Added.
1493         * TestWebKitAPI/Tests/WebKit2/mac/AttributedSubstringForProposedRangeWithImage.mm: Added.
1494         (TestWebKitAPI::didFinishLoadForFrame):
1495         (TestWebKitAPI::processDidCrash):
1496         (TestWebKitAPI::invalidMessageFunction):
1497         (TestWebKitAPI::WebKit2.AttributedSubstringForProposedRangeWithImage):
1498
1499 2016-12-16  Wenson Hsieh  <wenson_hsieh@apple.com>
1500
1501         Visual viewports: carets and selection UI are incorrectly positioned when editing fixed elements
1502         https://bugs.webkit.org/show_bug.cgi?id=165767
1503         <rdar://problem/29602382>
1504
1505         Reviewed by Simon Fraser.
1506
1507         Introduces two new UIScriptController methods: doAfterWebPageIsInStableState and textSelectionCaretRect. See
1508         WebKit2 ChangeLog for more details.
1509
1510         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1511         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
1512         (WTR::UIScriptController::textSelectionCaretRect):
1513         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1514         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
1515         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1516         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1517         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
1518         (WTR::UIScriptController::textSelectionCaretRect):
1519         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1520         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1521         (-[TestRunnerWKWebView _setStableStateOverride:]):
1522
1523         Force the WKWebView to update its visible content rects when changing the stable state override.
1524
1525         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1526         (WTR::toNSDictionary):
1527         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
1528         (WTR::UIScriptController::selectionRangeViewRects):
1529         (WTR::UIScriptController::textSelectionCaretRect):
1530         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1531         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
1532
1533 2016-12-15  Brent Fulgham  <bfulgham@apple.com>
1534
1535         Arguments called in wrong order
1536         https://bugs.webkit.org/show_bug.cgi?id=165923
1537
1538         Reviewed by Simon Fraser.
1539
1540         The 'audioDeviceUIDs' array is being passed to the argument that expects video devices,
1541         and the 'videoDeviceUIDs' array is being passed to the audo device argument. Fix this.
1542
1543         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
1544         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): The
1545         order of arguments to WKUserMediaPermissionRequestAllow are flipped.
1546
1547 2016-12-16  Hunseop Jeong  <hs85.jeong@samsung.com>
1548
1549         [EFL] Disable non-srcdir builds for failing libraries
1550         https://bugs.webkit.org/show_bug.cgi?id=165896
1551
1552         Reviewed by Gyuyoung Kim.
1553
1554         * efl/jhbuild.modules: Set non srcdir builds to no
1555
1556 2016-12-15  Daniel Bates  <dabates@apple.com>
1557
1558         check-style should not complain about code in icu directories
1559         https://bugs.webkit.org/show_bug.cgi?id=53929
1560
1561         Reviewed by Darin Adler.
1562
1563         Skip style checking of imported ICU headers to avoid a deluge of style issues
1564         as they do not conform to the WebKit Code Style guideline. We want to preserve
1565         the formatting of these headers so as to make it straightforward to merge
1566         changes to them, if necessary.
1567
1568         * Scripts/webkitpy/style/checker.py:
1569
1570 2016-12-15  Alexey Proskuryakov  <ap@apple.com>
1571
1572         Move JSC testers from Yosemite to Sierra
1573         https://bugs.webkit.org/show_bug.cgi?id=165925
1574
1575         Reviewed by Lucas Forschler.
1576
1577         * BuildSlaveSupport/build.webkit.org-config/config.json:
1578         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1579         (WebKitBuildbot):
1580
1581 2016-12-15  Megan Gardner  <megan_gardner@apple.com>
1582
1583         Add coordinate space to event streams and streamline tests
1584         https://bugs.webkit.org/show_bug.cgi?id=165119
1585
1586         Reviewed by Simon Fraser.
1587
1588         Update event streams to allow for both content and global coordinate space.
1589         Update example script to more accurately show all the available options.
1590
1591         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1592         * WebKitTestRunner/ios/HIDEventGenerator.h:
1593         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1594         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1595         (WTR::convertCoordinates):
1596         (WTR::UIScriptController::sendEventStream):
1597
1598 2016-12-15  Claudio Saavedra  <csaavedra@igalia.com>
1599
1600         [GTK] Ensure gst* docs are not built with update-webkitgtk-libs
1601         https://bugs.webkit.org/show_bug.cgi?id=165855
1602
1603         Reviewed by Philippe Normand.
1604
1605         GStreamer's autogen.sh enables gtk-doc always so we end up building
1606         docs even if we disable them. Use the configure script instead, since
1607         we build from packages and these include it already.
1608
1609         * gtk/jhbuild.modules: Use shipped configure instead of autogen.sh for
1610         upstream gstreamer packages.
1611
1612 2016-12-15  Alex Christensen  <achristensen@webkit.org>
1613
1614         REGRESSION (r208902) Null pointer dereference in wkIsPublicSuffix
1615         https://bugs.webkit.org/show_bug.cgi?id=165885
1616         <rdar://problem/29476917>
1617
1618         Reviewed by Darin Adler.
1619
1620         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1621         (TestWebKitAPI::utf16String): Deleted.
1622         * TestWebKitAPI/Tests/mac/PublicSuffix.mm:
1623         (TestWebKitAPI::TEST_F):
1624         * TestWebKitAPI/WTFStringUtilities.h:
1625         (utf16String):
1626         Moved from URLParser to share with other tests.
1627
1628 2016-12-14  Ryosuke Niwa  <rniwa@webkit.org>
1629
1630         iOS: An element with tabindex is not focusable unless there is no mouse event handler
1631         https://bugs.webkit.org/show_bug.cgi?id=165843
1632
1633         Reviewed by Antti Koivisto.
1634
1635         Add testRunner.isWebKit2 which is always true in WebKitTestRunner.
1636         Without this, it's really hard to reliably differentiate DumpRenderTree and WebKitTestRunner,
1637         and DumpRenderTree's runUIScript would hit an assertion :(
1638
1639         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1640         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1641         (WTR::TestRunner::isWebKit2):
1642
1643 2016-12-14  Brady Eidson  <beidson@apple.com>
1644
1645         IndexedDB 2.0: Massively speedup IDBIndex.get().
1646         https://bugs.webkit.org/show_bug.cgi?id=165802
1647
1648         Reviewed by Alex Christensen.
1649
1650         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1651         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.html: Added.
1652         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm: Added.
1653         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.blob: Added.
1654         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.sqlite3: Added.
1655
1656 2016-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1657
1658         [GTK][EFL] Update the JHBuild version.
1659         https://bugs.webkit.org/show_bug.cgi?id=165838
1660
1661         Reviewed by Michael Catanzaro.
1662
1663         * jhbuild/jhbuild-wrapper: This new version fixes a bug with the
1664         usage of the JHBUILD_MIRROR feature with git repositories.
1665
1666 2016-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1667
1668         [GTK] Yasm is needed for building the JHBuild after r208940
1669         https://bugs.webkit.org/show_bug.cgi?id=165837
1670
1671         Reviewed by Alejandro G. Castro.
1672
1673         * gtk/install-dependencies: Yasm is needed for building libvpx.
1674
1675 2016-12-14  Youenn Fablet  <youenn@apple.com>
1676
1677         Test infrastructure should allow to filter out text output before doing a comparison with the baseline
1678         https://bugs.webkit.org/show_bug.cgi?id=161310
1679
1680         Reviewed by Ryosuke Niwa.
1681
1682         Adding --dump-jsconsolelog-in-stderr test option for DRT and WTR.
1683         When set, WTR and DRT output JS console log in the stderr and not the test output.
1684         This allows removing potentially flaky information while still being able to read it for investigation.
1685
1686         Updated webkitpy infrastructure to use this test option in case of DumpJSConsoleLogInStdErr modifier.
1687
1688         Changes are covered by updating a fetch test to output console log and set its option to --dump-jsconsolelog-in-stderr in TestExpectations.
1689         This test should have this option when fetch API will start logging resource loader errors.
1690
1691         * DumpRenderTree/DumpRenderTree.h:
1692         (TestCommand::TestCommand): Deleted.
1693         * DumpRenderTree/DumpRenderTreeCommon.cpp:
1694         (parseInputLine):
1695         * DumpRenderTree/TestRunner.h:
1696         (TestRunner::setDumpJSConsoleLogInStdErr):
1697         (TestRunner::dumpJSConsoleLogInStdErr):
1698         * DumpRenderTree/mac/DumpRenderTree.mm:
1699         (runTest):
1700         * DumpRenderTree/mac/UIDelegate.mm:
1701         (-[UIDelegate webView:addMessageToConsole:withSource:]):
1702         * DumpRenderTree/win/DumpRenderTree.cpp:
1703         (runTest):
1704         * DumpRenderTree/win/UIDelegate.cpp:
1705         (UIDelegate::webViewAddMessageToConsole):
1706         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1707         (TestExpectationParser._tokenize_line):
1708         * Scripts/webkitpy/port/driver.py:
1709         (Driver._command_from_driver_input):
1710         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1711         (WTR::InjectedBundle::didReceiveMessageToPage):
1712         (WTR::InjectedBundle::dumpToStdErr):
1713         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1714         (WTR::InjectedBundle::dumpJSConsoleLogInStdErr):
1715         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1716         (WTR::InjectedBundlePage::willAddMessageToConsole):
1717         * WebKitTestRunner/TestController.cpp:
1718         (WTR::parseInputLine):
1719         (WTR::TestController::runTest):
1720         (WTR::TestCommand::TestCommand): Deleted.
1721         * WebKitTestRunner/TestInvocation.cpp:
1722         (WTR::TestInvocation::invoke):
1723         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1724         * WebKitTestRunner/TestInvocation.h:
1725         (WTR::TestInvocation::setDumpJSConsoleLogInStdErr):
1726
1727
1728 2016-12-14  Enrique Ocaña González  <eocanha@igalia.com>
1729
1730         REGRESSION(r207879-207891): [GStreamer] Introduced many layout test failures and crashes, bots exiting early
1731         https://bugs.webkit.org/show_bug.cgi?id=164022
1732
1733         Reviewed by Xabier Rodriguez-Calvar.
1734
1735         * Scripts/webkitperl/FeatureList.pm:
1736           Re-enable MEDIA_SOURCE for the GTK+ port.
1737
1738 2016-12-13  Alex Christensen  <achristensen@webkit.org>
1739
1740         Fix CMake build.
1741
1742         * DumpRenderTree/PlatformMac.cmake:
1743         Define NS_RETURNS_RETAINED as nothing for now.
1744
1745 2016-12-13  Jer Noble  <jer.noble@apple.com>
1746
1747         Fullscreen in WebKit2 does not restore topContentInset upon exiting; leaves top of page not visible
1748         https://bugs.webkit.org/show_bug.cgi?id=165697
1749
1750         Reviewed by Tim Horton.
1751
1752         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm:
1753         (TestWebKitAPI::TEST):
1754
1755 2016-12-13  Andy Estes  <aestes@apple.com>
1756
1757         [Cocoa] Implement -shouldInsertText: on WKWebProcessPlugInEditingDelegate
1758         https://bugs.webkit.org/show_bug.cgi?id=165785
1759         <rdar://problem/26929398>
1760
1761         Reviewed by Darin Adler.
1762
1763         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
1764         (-[BundleEditingDelegateRemoteObject shouldInsertText:replacingRange:givenAction:]): Added
1765         expectations for the text, range, and action.
1766         (TEST): Set the "EditingDelegateShouldInsertText" bundle parameter to NO so that the plug-in
1767         will return NO in -_webProcessPlugInBrowserContextController:willInsertText:. Added a
1768         plain-text string to the pasteboard, executed a paste action, and verified that the selected
1769         text in the web view did not change.
1770         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegatePlugIn.mm:
1771         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]): Set
1772         _editingDelegateShouldInsertText according to the "EditingDelegateShouldInsertText" bundle
1773         parameter.
1774         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:shouldInsertText:replacingRange:givenAction:]):
1775         Added. Called -shouldInsertText:replacingRange:givenAction: on the remote object proxy
1776         and returned the value of _editingDelegateShouldInsertText.
1777         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegateProtocol.h: Declared
1778         -shouldInsertText:replacingRange:givenAction:.
1779
1780 2016-12-13  Chris Dumez  <cdumez@apple.com>
1781
1782         Unreviewed, rolling out r209544.
1783
1784         Looks like r209489 did not cause the performance regression
1785         after all
1786
1787         Reverted changeset:
1788
1789         "Unreviewed, rolling out r209489."
1790         https://bugs.webkit.org/show_bug.cgi?id=165550
1791         http://trac.webkit.org/changeset/209544
1792
1793 2016-12-12  Sam Weinig  <sam@webkit.org>
1794
1795         [WebIDL] Remove use of Dictionary in ApplePaySession
1796         https://bugs.webkit.org/show_bug.cgi?id=165787
1797
1798         Reviewed by Anders Carlsson.
1799
1800         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1801         (WTR::initializeWebViewConfiguration):
1802         (WTR::TestController::platformCreateWebView):
1803         Enable ApplePay for the tests (where supported).
1804
1805 2016-12-13  Eric Carlson  <eric.carlson@apple.com>
1806
1807         Annotate MediaStream and WebRTC idl with EnabledAtRuntime flag
1808         https://bugs.webkit.org/show_bug.cgi?id=165251
1809
1810         Reviewed by Youenn Fablet.
1811
1812         * TestWebKitAPI/Tests/WebKit2/EnumerateMediaDevices.cpp:
1813         (TestWebKitAPI::TEST): Enable MediaStream, create web view from the page group upon which
1814         the preferences have been set.
1815
1816 2016-12-08  Antti Koivisto  <antti@apple.com>
1817
1818         Enable network cache speculative revalidation in MiniBrowser
1819         https://bugs.webkit.org/show_bug.cgi?id=165616
1820
1821         Reviewed by Darin Adler.
1822
1823         Match Safari. Also add a menu item to disable it.
1824
1825         * MiniBrowser/mac/AppDelegate.m:
1826         (defaultConfiguration):
1827         * MiniBrowser/mac/SettingsController.h:
1828         * MiniBrowser/mac/SettingsController.m:
1829         (-[SettingsController _populateMenu]):
1830         (-[SettingsController validateMenuItem:]):
1831         (-[SettingsController networkCacheSpeculativeRevalidationDisabled]):
1832         (-[SettingsController toggleNetworkCacheSpeculativeRevalidationDisabled:]):
1833
1834 2016-12-12  Alexey Proskuryakov  <ap@apple.com>
1835
1836         ChangeLogs become readonly after resolving a conflict
1837         https://bugs.webkit.org/show_bug.cgi?id=165440
1838         rdar://problem/29491002
1839
1840         Reviewed by Darin Adler.
1841
1842         * Scripts/resolve-ChangeLogs: (resolveChangeLog): Set correct permissions when
1843         moving the file.
1844
1845 2016-12-12  Filip Pizlo  <fpizlo@apple.com>
1846
1847         Re-enable collectContinuously since it doesn't crash anymore
1848
1849         Rubber stamped by Michael Saboff.
1850
1851         * Scripts/run-jsc-stress-tests:
1852
1853 2016-12-11  Konstantin Tokarev  <annulen@yandex.ru>
1854
1855         Unreviewed attempt to fix EFL and Mac/cmake builds after r209665.
1856         https://bugs.webkit.org/show_bug.cgi?id=165686
1857
1858         * DumpRenderTree/CMakeLists.txt: WebKit2 should precede other target
1859         so that right config.h comes first in include path.
1860
1861 2016-12-11  Dave Hyatt  <hyatt@apple.com>
1862
1863         [CSS Parser] Make sure content extensions initialize AtomicString
1864         https://bugs.webkit.org/show_bug.cgi?id=165737
1865
1866         Reviewed by Darin Adler.
1867
1868         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1869         (TestWebKitAPI::makeBackend):
1870
1871 2016-12-08  Dave Hyatt  <hyatt@apple.com>
1872
1873         [CSS Parser] Remove the old CSS Parser
1874         https://bugs.webkit.org/show_bug.cgi?id=165645
1875
1876         Reviewed by Daniel Bates.
1877
1878         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp:
1879         (TestWebKitAPI::TEST):
1880
1881 2016-12-10  Konstantin Tokarev  <annulen@yandex.ru>
1882
1883         [cmake] Include WTF, JSC, and WebCore headers automatically to targers using them
1884         https://bugs.webkit.org/show_bug.cgi?id=165686
1885
1886         Reviewed by Michael Catanzaro.
1887
1888         This change reduces duplication of include path lists between modules,
1889         and reduces future need for fixes like r209605 (broken build because of
1890         WebCore header suddenly becoming used in WebKit2).
1891
1892         * DumpRenderTree/CMakeLists.txt:
1893         * DumpRenderTree/PlatformMac.cmake:
1894         * ImageDiff/CMakeLists.txt:
1895         * MiniBrowser/gtk/CMakeLists.txt:
1896         * MiniBrowser/mac/CMakeLists.txt:
1897         * MiniBrowser/win/CMakeLists.txt:
1898         * TestWebKitAPI/CMakeLists.txt:
1899         * TestWebKitAPI/PlatformEfl.cmake:
1900         * TestWebKitAPI/PlatformJSCOnly.cmake:
1901         * TestWebKitAPI/PlatformMac.cmake:
1902         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1903         * WebKitTestRunner/CMakeLists.txt:
1904         * WebKitTestRunner/PlatformGTK.cmake:
1905         * WebKitTestRunner/PlatformMac.cmake:
1906
1907 2016-12-09  Csaba Osztrogonác  <ossy@webkit.org>
1908
1909         Unreviewed buildfix after r209630.
1910
1911         * Scripts/build-jsc: Remove building the non-existing testWASM.
1912
1913 2016-12-09  Eric Carlson  <eric.carlson@apple.com>
1914
1915         Annotate MediaStream and WebRTC idl with EnabledAtRuntime flag
1916         https://bugs.webkit.org/show_bug.cgi?id=165251
1917
1918         Reviewed by Dean Jackson.
1919
1920         Based on a patch by Dr Alex Gouaillard <agouaillard@gmail.com>
1921
1922         * DumpRenderTree/mac/DumpRenderTree.mm:
1923         (resetWebPreferencesToConsistentValues): Enable MediaStream and PeerConnection.
1924
1925         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1926         (WTR::InjectedBundle::beginTesting): Ditto.
1927
1928         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1929         (WTR::TestRunner::setMediaStreamEnabled): New.
1930         (WTR::TestRunner::setPeerConnectionEnabled): New.
1931         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1932
1933 2016-12-09  Brady Eidson  <beidson@apple.com> 
1934  
1935         Re-landing:
1936         Add _WKIconLoadingDelegate SPI. 
1937         https://bugs.webkit.org/show_bug.cgi?id=164894 
1938  
1939         Reviewed by Alex Christensen. 
1940         
1941         Add MiniBrowser support for this new SPI, configurable with a setting. 
1942  
1943         * MiniBrowser/mac/SettingsController.h: 
1944         * MiniBrowser/mac/SettingsController.m: 
1945         (-[SettingsController _populateMenu]): 
1946         (-[SettingsController validateMenuItem:]): 
1947         (-[SettingsController loadsAllSiteIcons]): 
1948         (-[SettingsController toggleLoadsAllSiteIcons:]): 
1949         * MiniBrowser/mac/WK2BrowserWindowController.m: 
1950         (-[WK2BrowserWindowController awakeFromNib]): 
1951         (-[WK2BrowserWindowController webView:shouldLoadIconWithParameters:completionHandler:]): 
1952
1953 2016-12-09  Ryan Haddad  <ryanhaddad@apple.com>
1954
1955         Fix the 32-bit build.
1956
1957         Unreviewed build fix.
1958
1959         * MiniBrowser/mac/SettingsController.h:
1960
1961 2016-12-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1962
1963         Fedora also needs a PHP7 config file alternative
1964         https://bugs.webkit.org/show_bug.cgi?id=165606
1965
1966         Reviewed by Michael Catanzaro.
1967
1968         * Scripts/webkitpy/port/base.py:
1969         (Port._is_fedora_php_version_7): check for the php7 library.
1970         (Port._fedora_php_version): get the appropriate filename for Fedora.
1971         (Port._apache_config_file_name_for_platform):
1972
1973 2016-12-09  Ryan Haddad  <ryanhaddad@apple.com>
1974
1975         Complete the revert of r208865.
1976         https://bugs.webkit.org/show_bug.cgi?id=164894
1977
1978         Unreviewed build fix.
1979
1980         * MiniBrowser/mac/SettingsController.h:
1981         * MiniBrowser/mac/SettingsController.m:
1982         (-[SettingsController _populateMenu]):
1983         (-[SettingsController validateMenuItem:]):
1984         (-[SettingsController loadsAllSiteIcons]): Deleted.
1985         (-[SettingsController toggleLoadsAllSiteIcons:]): Deleted.
1986         * MiniBrowser/mac/WK2BrowserWindowController.m:
1987         (-[WK2BrowserWindowController awakeFromNib]):
1988         (-[WK2BrowserWindowController webView:shouldLoadIconWithParameters:completionHandler:]): Deleted.
1989
1990 2016-12-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1991
1992         [GTK] Force GDK backend to x11 when running with XvfbDriver
1993         https://bugs.webkit.org/show_bug.cgi?id=165612
1994
1995         Reviewed by Michael Catanzaro.
1996
1997         When the developer is running a Wayland session, GDK may get confused
1998         and try to use its Wayland backend (which is higher priority) instead.
1999         This ensures it will use the appropriate backend when running under
2000         Xvfb.
2001
2002         * Scripts/webkitpy/port/gtk.py:
2003         (GtkPort.setup_environ_for_server): when running with XvfbDriver,
2004         force GDK_BACKEND to x11.
2005
2006 2016-12-08  Keith Miller  <keith_miller@apple.com>
2007
2008         Add 64-bit signed LEB decode method
2009         https://bugs.webkit.org/show_bug.cgi?id=165630
2010
2011         Reviewed by Ryosuke Niwa.
2012
2013         Add tests for LEB int64 and uint64 decode since I guess
2014         I forgot to add tests before.
2015
2016         * TestWebKitAPI/Tests/WTF/LEBDecoder.cpp:
2017         (TestWebKitAPI::testUInt32LEBDecode):
2018         (TestWebKitAPI::TEST):
2019         (TestWebKitAPI::testUInt64LEBDecode):
2020         (TestWebKitAPI::testInt32LEBDecode):
2021         (TestWebKitAPI::testInt64LEBDecode):
2022         (TestWebKitAPI::testUnsignedLEBDecode): Deleted.
2023
2024 2016-12-08  Filip Pizlo  <fpizlo@apple.com>
2025
2026         Make it easy to enable --force-collectContinuously
2027         https://bugs.webkit.org/show_bug.cgi?id=165638
2028
2029         Reviewed by Keith Miller.
2030
2031         * Scripts/run-javascriptcore-tests:
2032         (runJSCStressTests):
2033
2034 2016-12-08  Filip Pizlo  <fpizlo@apple.com>
2035
2036         Disable the collectContinuously mode until I investigate failures.
2037
2038         Rubber stamped by Keith Miller.
2039         
2040         I'm seeing collectContinuously crashes on some platforms. Disabling that testing mode
2041         while I investigate.
2042
2043         * Scripts/run-jsc-stress-tests:
2044
2045 2016-12-08  Alex Christensen  <achristensen@webkit.org>
2046
2047         REGRESSION (URL parser): Relative URLs aren’t resolved correctly when the base URL is an applewebdata: URL
2048         https://bugs.webkit.org/show_bug.cgi?id=165621
2049
2050         Reviewed by Dan Bernstein.
2051
2052         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2053         (TestWebKitAPI::TEST_F):
2054
2055 2016-12-06  Filip Pizlo  <fpizlo@apple.com>
2056
2057         Concurrent GC should be stable enough to land enabled
2058         https://bugs.webkit.org/show_bug.cgi?id=164990
2059
2060         Reviewed by Geoffrey Garen.
2061         
2062         Add a new mode that runs GC continuously. Also made eager modes run GC continuously.
2063         
2064         It's clear that this works just fine in release, but I'm still trying to figure out if it's
2065         safe for debug. It might be too slow for debug.
2066
2067         * Scripts/run-jsc-stress-tests:
2068
2069 2016-12-08  Alex Christensen  <achristensen@webkit.org>
2070
2071         Add SPI for sending WebsiteSettings to WebProcess during navigation
2072         https://bugs.webkit.org/show_bug.cgi?id=165517
2073         <rdar://29341068>
2074
2075         Reviewed by Anders Carlsson.
2076
2077         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2078         * TestWebKitAPI/Tests/WebKit2/contentBlockerCheck.html: Added.
2079         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm: Added.
2080         (-[WebsitePoliciesDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2081         (-[WebsitePoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
2082         (-[WebsitePoliciesDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2083         (TEST):
2084
2085 2016-12-08  Chris Dumez  <cdumez@apple.com>
2086
2087         Unreviewed, rolling out r209489.
2088
2089         Likely caused large regressions on JetStream, Sunspider and
2090         Speedometer
2091
2092         Reverted changeset:
2093
2094         "Add system trace points for JavaScript VM entry/exit"
2095         https://bugs.webkit.org/show_bug.cgi?id=165550
2096         http://trac.webkit.org/changeset/209489
2097
2098 2016-12-08  Keith Miller  <keith_miller@apple.com>
2099
2100         Move LEB tests to API tests
2101         https://bugs.webkit.org/show_bug.cgi?id=165586
2102
2103         Reviewed by Saam Barati.
2104
2105         Move the tests from testWasm.cpp and make them functions
2106         rather than macros.
2107
2108         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2109         * TestWebKitAPI/Tests/WTF/LEBDecoder.cpp: Added.
2110         (TestWebKitAPI::testUnsignedLEBDecode):
2111         (TestWebKitAPI::TEST):
2112         (TestWebKitAPI::testInt32LEBDecode):
2113
2114 2016-12-08  Chris Dumez  <cdumez@apple.com>
2115
2116         Support running the layout tests offline
2117         https://bugs.webkit.org/show_bug.cgi?id=165534
2118
2119         Reviewed by Ryosuke Niwa.
2120
2121         * Scripts/webkitpy/common/system/autoinstall.py:
2122         (AutoInstaller._download_to_stream):
2123         getcode() returns None for file URLs so handle this.
2124
2125         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2126         (WebPlatformTestServer._install_modules):
2127         Deal with local path in the json file and resolve them into file URLs
2128         before using AutoInstall.
2129
2130 2016-12-08  Alex Christensen  <achristensen@webkit.org>
2131
2132         Fix CMake build.
2133
2134         * DumpRenderTree/PlatformMac.cmake:
2135         Remove CheckedMalloc.cpp after r209516.
2136
2137 2016-12-07  Mark Lam  <mark.lam@apple.com>
2138
2139         DumpRenderTree should stop using CheckedMalloc.
2140         https://bugs.webkit.org/show_bug.cgi?id=165563
2141         <rdar://problem/28945820>
2142
2143         Reviewed by Geoffrey Garen.
2144
2145         1. WebKitTestRunner does not have equivalent behavior to that which is implemented
2146            in CheckedMalloc.
2147         2. bmalloc does not honor the settings of CheckedMalloc.
2148
2149         The only time CheckedMalloc comes into play is when DRT uses gmalloc or system
2150         malloc.  As a result, DRT exhibits different behavior from the normal way we run
2151         our tests.  We should obsolete CheckedMalloc and make DRT behave consistently
2152         with WKTR.
2153
2154         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2155         * DumpRenderTree/mac/CheckedMalloc.cpp: Removed.
2156         * DumpRenderTree/mac/CheckedMalloc.h: Removed.
2157         * DumpRenderTree/mac/DumpRenderTree.mm:
2158         (prepareConsistentTestingEnvironment):
2159
2160 2016-12-07  Dean Jackson  <dino@apple.com>
2161
2162         Remove runtime toggle for pointer-lock
2163         https://bugs.webkit.org/show_bug.cgi?id=165577
2164         <rdar://problems/29566996>
2165
2166         Reviewed by Jon Lee.
2167
2168         Remove any runtime calls to check if pointer-lock is enabled. It's
2169         either compiled in or out.
2170
2171         * DumpRenderTree/mac/DumpRenderTree.mm:
2172         (resetWebPreferencesToConsistentValues):
2173         * WebKitTestRunner/TestController.cpp:
2174         (WTR::TestController::resetPreferencesToConsistentValues):
2175
2176 2016-12-07  Eric Carlson  <eric.carlson@apple.com>
2177
2178         [MediaStream][Mac] Revoke sandbox extensions when capture ends
2179         https://bugs.webkit.org/show_bug.cgi?id=165476
2180
2181         Reviewed by Brady Eidson.
2182         
2183         Add a test which loads a page that calls navigator.mediaDevices.enumerateDevices, kills the
2184         page, and loads the same page again to ensure that the WK2 UserMediaPermissionRequestManagerProxy
2185         is reset and recreated when a web page exits and is reloaded.
2186
2187         * TestWebKitAPI/PlatformGTK.cmake:
2188         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2189         * TestWebKitAPI/Tests/WebKit2/EnumerateMediaDevices.cpp: Added.
2190         (TestWebKitAPI::checkUserMediaPermissionCallback):
2191         (TestWebKitAPI::TEST):
2192         * TestWebKitAPI/Tests/WebKit2/enumerateMediaDevices.html: Added.
2193
2194 2016-12-07  Jeremy Jones  <jeremyj@apple.com>
2195
2196         One esc to exit fullscreen and pointer lock
2197         https://bugs.webkit.org/show_bug.cgi?id=165416
2198         rdar://problem/29430711
2199
2200         Reviewed by Jer Noble.
2201
2202         Implement WKPageUIClientV8 for pointer lock support.
2203         Add "escape" key support in EventSenderProxy.
2204
2205         * WebKitTestRunner/TestController.cpp:
2206         (WTR::requestPointerLock):
2207         (WTR::TestController::createOtherPage):
2208         (WTR::TestController::createWebViewWithOptions):
2209         * WebKitTestRunner/mac/EventSenderProxy.mm:
2210         (WTR::EventSenderProxy::keyDown):
2211
2212 2016-12-07  Simon Fraser  <simon.fraser@apple.com>
2213
2214         Add system trace points for JavaScript VM entry/exit
2215         https://bugs.webkit.org/show_bug.cgi?id=165550
2216
2217         Reviewed by Tim Horton.
2218
2219         Add trace points for entry/exit into/out of the JS VM.
2220
2221         * Tracing/SystemTracePoints.plist:
2222
2223 2016-12-07  ChangSeok Oh  <changseok@webkit.org>
2224
2225         [GTK] Cannot build GTK+ with CUPS 2.* versions
2226         https://bugs.webkit.org/show_bug.cgi?id=163591
2227
2228         Reviewed by Michael Catanzaro.
2229
2230         GTK+ build has failed on the system which CUPS 2.x is installed in. GTK+ 3.16.4
2231         does not assume to use the recent CUPS thus it fails to detect the CUPS in configuration.
2232         GTK+ upstream fixed this issue but it is not easy to apply the original patch to our
2233         old gtk+ since it requires not only bumping up glib accordingly and its consequence
2234         causes many printing test failures. So, I propose to fix the configuration issue by
2235         applying the change to the configure file directly. By doing this, we don't need to
2236         upgrade glib and worry about any test failures as a consequence of the upgraded glib.
2237
2238         * gtk/jhbuild.modules:
2239         * gtk/patches/gtk+-configure-fix-detecting-CUPS-2.x.patch: Added.
2240
2241 2016-12-07  Simon Fraser  <simon.fraser@apple.com>
2242
2243         Fix use of enum in a WK2 C SPI header.
2244         rdar://problem/28725583
2245
2246         Followup to correctly prefix the enum values.
2247
2248         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2249         (WTR::InjectedBundlePage::prepare):
2250
2251 2016-12-07  Simon Fraser  <simon.fraser@apple.com>
2252
2253         Fix use of enum in a WK2 C SPI header.
2254         rdar://problem/28725583
2255
2256         Reviewed by Dan Bernstein.
2257
2258         Use correct enum style for a C SPI header and fix the callers.
2259
2260         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2261         (WTR::InjectedBundlePage::prepare):
2262
2263 2016-12-07  Wenson Hsieh  <wenson_hsieh@apple.com>
2264
2265         Add a new project for recording and playing back editing commands in editable web content
2266         https://bugs.webkit.org/show_bug.cgi?id=165114
2267         <rdar://problem/29408135>
2268
2269         Reviewed by Beth Dakin.
2270
2271         Adds a new Xcode project containing work towards rewinding and playing back editing commands. This work is
2272         wrapped in an Xcode project to take advantage of the XCTest framework. To manually test recording, open the
2273         capture test harness, edit the contenteditable body, and then hit cmd-S. This downloads a .json file which may
2274         then be dragged into the playback test harness.
2275
2276         Also adds 3 new unit tests in EditingHistoryTests/RewindAndPlaybackTests.m. These tests carry out the following
2277         steps:
2278
2279         1. Load the capture harness and perform test-specific editing on the web view.
2280         2. Let originalState be a dump of the DOM at this point in time.
2281         3. Extract the JSON-serialized editing history data and load the playback harness with this data.
2282         4. Rewind all editing to the beginning.
2283         5. Playback all editing to the end.
2284         6. Dump the state of the DOM. This should be identical to originalState.
2285
2286         * EditingHistory/EditingHistory.xcodeproj/project.pbxproj: Added.
2287         * EditingHistory/EditingHistory/Info.plist: Added.
2288         * EditingHistory/EditingHistory/Resources/CaptureHarness.html: Added.
2289         * EditingHistory/EditingHistory/Resources/DOMTestingUtil.js: Added.
2290         * EditingHistory/EditingHistory/Resources/PlaybackHarness.html: Added.
2291         * EditingHistory/EditingHistory/TestRunner.h: Added.
2292         * EditingHistory/EditingHistory/TestRunner.m: Added.
2293         (injectedMessageEventHandlerScript):
2294         (-[TestRunner init]):
2295         (-[TestRunner deleteBackwards:]):
2296         (-[TestRunner typeString:]):
2297         (-[TestRunner bodyElementSubtree]):
2298         (-[TestRunner bodyTextContent]):
2299         (-[TestRunner editingHistoryJSON]):
2300         (-[TestRunner loadPlaybackTestHarnessWithJSON:]):
2301         (-[TestRunner numberOfUpdates]):
2302         (-[TestRunner jumpToUpdateIndex:]):
2303         (-[TestRunner expectEvents:afterPerforming:]):
2304         (-[TestRunner loadCaptureTestHarness]):
2305         (-[TestRunner setTextObfuscationEnabled:]):
2306         (-[TestRunner isDoneWaitingForPendingEvents]):
2307         (-[TestRunner userContentController:didReceiveScriptMessage:]):
2308
2309         The TestRunner provides utilities that a unit test should use to drive the test forward (e.g. loading harnesses)
2310         or inspect the state of the loaded page (e.g. extracting JSON editing history data from the capture harness).
2311
2312         * EditingHistory/EditingHistory/TestUtil.h: Added.
2313         * EditingHistory/EditingHistory/TestUtil.m: Added.
2314         (waitUntilWithTimeout):
2315         (waitUntil):
2316
2317         Provides utilities for running tests. For now, this is just spinning the runloop on a given condition.
2318
2319         * EditingHistory/EditingHistory/WKWebViewAdditions.h: Added.
2320         * EditingHistory/EditingHistory/WKWebViewAdditions.m: Added.
2321         (-[WKWebView loadPageFromBundleNamed:]):
2322         (-[WKWebView typeCharacter:]):
2323         (-[WKWebView keyPressWithCharacters:keyCode:]):
2324         (-[WKWebView stringByEvaluatingJavaScriptFromString:]):
2325
2326         Provides utilities for simulating interaction in a web view.
2327
2328         * EditingHistory/EditingHistory/main.m: Added.
2329         (main):
2330         * EditingHistory/EditingHistoryTests/Info.plist: Added.
2331         * EditingHistory/EditingHistoryTests/RewindAndPlaybackTests.m: Added.
2332         (-[RewindAndPlaybackTests setUp]):
2333         (-[RewindAndPlaybackTests tearDown]):
2334         (-[RewindAndPlaybackTests testTypingSingleLineOfText]):
2335         (-[RewindAndPlaybackTests testTypingMultipleLinesOfText]):
2336         (-[RewindAndPlaybackTests testTypingAndDeletingText]):
2337         (-[RewindAndPlaybackTests rewindAndPlaybackEditingInPlaybackTestHarness]):
2338         (-[RewindAndPlaybackTests originalBodySubtree:isEqualToFinalSubtree:]):
2339
2340 2016-12-07  Philippe Normand  <pnormand@igalia.com>
2341
2342         [GTK][jhbuild] missing dependency on libvpx in gst-plugins-good
2343         https://bugs.webkit.org/show_bug.cgi?id=165525
2344
2345         Reviewed by Carlos Garcia Campos.
2346
2347         * gtk/jhbuild.modules: gst-plugins-good should depend on the
2348         libvpx package built within jhbuild.
2349
2350 2016-12-07  Philippe Normand  <pnormand@igalia.com>
2351
2352         [GTK][jhbuild] gst-plugins-bad fails to build with OpenSSL 1.1.0
2353         https://bugs.webkit.org/show_bug.cgi?id=165520
2354
2355         Reviewed by Carlos Garcia Campos.
2356
2357         * gtk/jhbuild.modules: Added missing dependency on openh264 in
2358         gst-plugins-bad, along with 2 upstream patches fixing the build
2359         against OpenSSL 1.1.0.
2360         * gtk/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Added.
2361         * gtk/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Added.
2362
2363 2016-12-06  Alexey Proskuryakov  <ap@apple.com>
2364
2365         Correct SDKROOT values in xcconfig files
2366         https://bugs.webkit.org/show_bug.cgi?id=165487
2367         rdar://problem/29539209
2368
2369         Reviewed by Dan Bernstein.
2370
2371         Fix suggested by Dan Bernstein.
2372
2373         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
2374         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2375         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2376         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2377         * WebEditingTester/Configurations/DebugRelease.xcconfig:
2378         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2379
2380 2016-12-06  Daniel Bates  <dabates@apple.com>
2381
2382         WebKitTestRunner: Plugins are disabled in new windows
2383         https://bugs.webkit.org/show_bug.cgi?id=165410
2384
2385         Reviewed by Alex Christensen.
2386
2387         Currently WebKitTestRunner only enables plugins in the main window. So, a test that opens
2388         a new window and loads a plugin will fail. We should enable plugins in all windows by
2389         default. Moreover toggling testRunner.setPluginsEnabled() should effect all windows.
2390
2391         Making these changes is a step towards running plugins/open-and-close-window-with-plugin.html
2392         in WebKitTestRunner (we still need to fix <https://bugs.webkit.org/show_bug.cgi?id=46714>) and
2393         will make the behavior of WebKitTestRunner more closely match the behavior DumpRenderTree.
2394
2395         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2396         (WTR::InjectedBundle::beginTesting): Call TestRunner::setPluginsEnabled() instead of
2397         WKBundleSetPluginsEnabled().
2398         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2399         (WTR::TestRunner::setPluginsEnabled): Take a similar approach as TestRunner::setXSSAuditorEnabled()
2400         and make use of WKBundleOverrideBoolPreferenceForTestRunner().
2401
2402 2016-12-05  Dean Jackson  <dino@apple.com>
2403
2404         pointer lock needs to be feature detectable
2405         https://bugs.webkit.org/show_bug.cgi?id=165426
2406         <rdar://problem/29486715>
2407
2408         Reviewed by Antoine Quint.
2409
2410         Expose the comment line to turn on/off pointer lock.
2411
2412         * DumpRenderTree/TestOptions.h:
2413         * DumpRenderTree/TestOptions.mm:
2414         (TestOptions::TestOptions):
2415         * DumpRenderTree/mac/DumpRenderTree.mm:
2416         (resetWebPreferencesToConsistentValues):
2417         * WebKitTestRunner/TestController.cpp:
2418         (WTR::TestController::resetPreferencesToConsistentValues):
2419         (WTR::updateTestOptionsFromTestHeader):
2420         * WebKitTestRunner/TestOptions.h:
2421         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2422         (WTR::PlatformWebView::viewSupportsOptions):
2423         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2424         (WTR::PlatformWebView::viewSupportsOptions):
2425
2426 2016-12-05  Jonathan Bedard  <jbedard@apple.com>
2427
2428         Make it possible to use an existing simulator instance for one-off testing
2429         https://bugs.webkit.org/show_bug.cgi?id=164568
2430         <rdar://problem/29189133>
2431
2432         Reviewed by Daniel Bates.
2433
2434         With this patch, if a simulator is currently running on the machine and
2435         '--dedicated-simulators' is not passed into the application, only one simulator
2436         instance will be used, and this instance will be the existing instance.
2437         If no simulator is running or '--dedicated-simulators' is passed to the script,
2438         previous behavior will be used.
2439
2440         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2441         (parse_args):
2442         * Scripts/webkitpy/port/ios.py:
2443         (IOSSimulatorPort.__init__): Logic for enabling usage of currently running simulator.
2444         (IOSSimulatorPort._create_simulators): Only create simulators when needed, don't reset already running simulators.
2445         (IOSSimulatorPort.setup_test_run): Don't open already running simulators.
2446         (IOSSimulatorPort._quit_ios_simulator): Only quit simulators if we manage them.
2447         (IOSSimulatorPort.clean_up_test_run): Only clean up simulators if we manage them. 
2448         (IOSSimulatorPort._using_dedicated_simulators): True if simulators need to be managed, false if using an existing instance.
2449         (IOSSimulatorPort.device_id_for_worker_number): Access currently running simulator if not managing devices.
2450         * Scripts/webkitpy/xcode/simulator.py:
2451         (Simulator.refresh): Check if xcode_simctl_list returned None instead of a generator.
2452         (Simulator.current_device): Get currently running device.
2453
2454 2016-12-05  Dan Bernstein  <mitz@apple.com>
2455
2456         Disable a crashing test on iOS.
2457
2458         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
2459
2460 2016-12-04  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2461
2462         Fix a build break on EFL since r209303.
2463
2464         Unreviewed build fix.
2465
2466         * Scripts/webkitperl/FeatureList.pm: Disable SS Device Adaptation temporarily.
2467
2468 2016-12-03  Yusuke Suzuki  <utatane.tea@gmail.com>
2469
2470         Refactor SymbolImpl layout
2471         https://bugs.webkit.org/show_bug.cgi?id=165247
2472
2473         Reviewed by Darin Adler.
2474
2475         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2476         (TestWebKitAPI::TEST):
2477
2478 2016-12-03  Dan Bernstein  <mitz@apple.com>
2479
2480         Fixed the build after r209307.
2481
2482         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
2483         (TEST):
2484
2485 2016-12-03  Dan Bernstein  <mitz@apple.com>
2486
2487         [Cocoa] Expose InjectedBundlePageEditorClient via the Objective-C bundle SPI
2488         https://bugs.webkit.org/show_bug.cgi?id=165276
2489         <rdar://problem/29467040>
2490
2491         Reviewed by Darin Adler.
2492
2493         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2494         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm: Added.
2495         (-[BundleEditingDelegateRemoteObject willWriteToPasteboard:]):
2496         (-[BundleEditingDelegateRemoteObject didWriteToPasteboard]):
2497         (TEST):
2498         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegatePlugIn.mm: Added.
2499         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2500         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:willWriteRangeToPasteboard:]):
2501         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:pasteboardDataForRange:]):
2502         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextControllerDidWriteToPasteboard:]):
2503         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegateProtocol.h: Added.
2504
2505 2016-12-02  Andy Estes  <aestes@apple.com>
2506
2507         [Cocoa] Adopt the PRODUCT_BUNDLE_IDENTIFIER build setting
2508         https://bugs.webkit.org/show_bug.cgi?id=164492
2509
2510         Reviewed by Dan Bernstein.
2511
2512         * DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Changed CFBundleIdentifier's value from
2513         com.apple.testnetscapeplugin to ${PRODUCT_BUNDLE_IDENTIFIER}.
2514         * DumpRenderTree/ios/Info.plist: Changed CFBundleIdentifier's value from
2515         org.webkit.DumpRenderTree to ${PRODUCT_BUNDLE_IDENTIFIER}.
2516         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig: Set
2517         PRODUCT_BUNDLE_IDENTIFIER to org.webkit.DumpRenderTree.
2518         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Set
2519         PRODUCT_BUNDLE_IDENTIFIER to com.apple.testnetscapeplugin.
2520         * MiniBrowser/Configurations/MiniBrowser.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
2521         org.webkit.$(PRODUCT_NAME:rfc1034identifier).
2522         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
2523         com.apple.$(PRODUCT_NAME:rfc1034identifier).
2524         * MiniBrowser/mac/Bundle/Info.plist: Changed CFBundleIdentifier's value from
2525         com.apple.${PRODUCT_NAME:rfc1034identifier} to ${PRODUCT_BUNDLE_IDENTIFIER}.
2526         * MiniBrowser/mac/Info.plist: Changed CFBundleIdentifier's value from
2527         org.webkit.${PRODUCT_NAME} to ${PRODUCT_BUNDLE_IDENTIFIER}.
2528         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig: Set INFOPLIST_FILE to
2529         InjectedBundle-Info.plist and set PRODUCT_BUNDLE_IDENTIFIER to
2530         com.apple.$(PRODUCT_NAME:rfc1034identifier).
2531         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
2532         com.apple.$(PRODUCT_NAME:rfc1034identifier).
2533         * TestWebKitAPI/InjectedBundle-Info.plist: Changed CFBundleIdentifier's value from
2534         com.yourcompany.${PRODUCT_NAME:rfc1034identifier} to ${PRODUCT_BUNDLE_IDENTIFIER}.
2535         * TestWebKitAPI/cocoa/WebProcessPlugIn/Info.plist: Added a CFBundleIdentifier key with the
2536         value ${PRODUCT_BUNDLE_IDENTIFIER}.
2537         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Set INFOPLIST_FILE to
2538         InjectedBundle-Info.plist and set PRODUCT_BUNDLE_IDENTIFIER to
2539         com.apple.WebKitTestRunner.InjectedBundle.
2540         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Set
2541         PRODUCT_BUNDLE_IDENTIFIER to org.webkit.$(PRODUCT_NAME:rfc1034identifier).
2542         * WebKitTestRunner/InjectedBundle-Info.plist: Changed CFBundleIdentifier's value from
2543         com.apple.WebKitTestRunner.InjectedBundle to ${PRODUCT_BUNDLE_IDENTIFIER}.
2544         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist: Changed
2545         CFBundleIdentifier's value from org.webkit.${PRODUCT_NAME:rfc1034identifier} to
2546         ${PRODUCT_BUNDLE_IDENTIFIER}.
2547
2548 2016-12-02  Brady Eidson  <beidson@apple.com>
2549
2550         Make IndexedDB.WebProcessKillIDBCleanup even more reliable.
2551         https://bugs.webkit.org/show_bug.cgi?id=165330
2552
2553         Reviewed by Alex Christensen.
2554
2555         The test currently nulls out a RetainPtr<WKWebView> to try to destroy the view and kill the process.
2556
2557         Problem is that doesn't reliably destroy the view.
2558         We should explicitly kill the process instead.
2559
2560         Also, by relocating when we kill the process, we can better test behavior of the IndexedDB mechanism.
2561         e.g. We explicitly confirm that a second WebProcess can simultaneously attach to the same unique database as the first.
2562
2563         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
2564         (TEST):
2565
2566 2016-12-02  Commit Queue  <commit-queue@webkit.org>
2567
2568         Unreviewed, rolling out r209136.
2569         https://bugs.webkit.org/show_bug.cgi?id=165337
2570
2571         broke 36 webkitpy tests (Requested by mcatanzaro on #webkit).
2572
2573         Reverted changeset:
2574
2575         "Make it possible to use an existing simulator instance for
2576         one-off testing"
2577         https://bugs.webkit.org/show_bug.cgi?id=164568
2578         http://trac.webkit.org/changeset/209136
2579
2580 2016-12-02  Chris Dumez  <cdumez@apple.com>
2581
2582         [Mac][WK1] Implement new HTML interactive form validation user interface
2583         https://bugs.webkit.org/show_bug.cgi?id=164483
2584
2585         Reviewed by Simon Fraser.
2586
2587         Add support for UIScriptController's contentsOfUserInterfaceItem("validationBubble")
2588         on Mac DRT as this is needed by the HTML form validation layout tests.
2589
2590         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2591         (WTR::UIScriptController::contentsOfUserInterfaceItem):
2592
2593 2016-12-02  Brady Eidson  <beidson@apple.com>
2594
2595         IndexedDB.IndexedDBMultiProcess and IndexedDB.WebProcessKillIDBCleanup sometimes timeout.
2596         https://bugs.webkit.org/show_bug.cgi?id=160780 and https://bugs.webkit.org/show_bug.cgi?id=161001
2597
2598         Reviewed by Alexey Proskuryakov.
2599
2600         These tests had "run-loop races."
2601         
2602         The test spins the runloop waiting for one message.
2603         Two messages might come in from the WebProcess in short succession, and both be delivered to the
2604         UIProcess in the same spin of the runloop.
2605
2606         Therefore by the time the test stops spinning the runloop, notified that a message was received,
2607         the first message has been overwritten by the second.
2608
2609         These tests are fixed by queueing the incoming messages instead of just storing one.
2610
2611         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
2612         (-[IndexedDBMPMessageHandler userContentController:didReceiveScriptMessage:]):
2613         (getNextMessage):
2614         (TEST):
2615
2616         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
2617         (-[IndexedDBWebProcessKillMessageHandler userContentController:didReceiveScriptMessage:]):
2618         (getNextMessage):
2619         (TEST):
2620
2621 2016-12-01  Jiewen Tan  <jiewen_tan@apple.com>
2622
2623         Add a runtime flag for SubtleCrypto
2624         https://bugs.webkit.org/show_bug.cgi?id=164982
2625
2626         Reviewed by Brent Fulgham.
2627
2628         * DumpRenderTree/mac/DumpRenderTree.mm:
2629         (resetWebPreferencesToConsistentValues):
2630         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2631         (WTR::InjectedBundle::beginTesting):
2632         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2633         (WTR::TestRunner::setSubtleCryptoEnabled):
2634         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2635
2636 2016-12-01  Alexey Proskuryakov  <ap@apple.com>
2637
2638         Remove webkitpy dependency on Eliza
2639         https://bugs.webkit.org/show_bug.cgi?id=164979
2640
2641         Reviewed by Daniel Bates.
2642
2643         This module is not on pypi, so installing it is a challenge. The jokes feel pretty old too!
2644
2645         * Scripts/webkitpy/thirdparty/__init__.py:
2646         * Scripts/webkitpy/thirdparty/__init___unittest.py: Changed mock import hook to
2647         test buildbot instead of eliza.
2648         * Scripts/webkitpy/tool/bot/ircbot.py:
2649         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
2650
2651 2016-12-01  Beth Dakin  <bdakin@apple.com>
2652
2653         Force clicking tests fail on some machines
2654         https://bugs.webkit.org/show_bug.cgi?id=165263
2655
2656         Reviewed by Tim Horton.
2657
2658         Initialize com.apple.trackpad.forceClick to 1 so that we don’t have to depend on 
2659         the user account having this feature enabled. 
2660         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2661         (WTR::InjectedBundle::platformInitialize):
2662         * WebKitTestRunner/mac/main.mm:
2663         (setDefaultsToConsistentValuesForTesting):
2664
2665 2016-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
2666
2667         Introduce StringImpl::StaticStringImpl with constexpr constructor
2668         https://bugs.webkit.org/show_bug.cgi?id=165093
2669
2670         Reviewed by Darin Adler.
2671
2672         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2673         (TestWebKitAPI::TEST):
2674
2675 2016-11-30  Antoine Quint  <graouts@apple.com>
2676
2677         [Modern Media Controls] Add an HTML comment flag to turn the feature on
2678         https://bugs.webkit.org/show_bug.cgi?id=165226
2679
2680         Reviewed by Dean Jackson.
2681
2682         Add a new flag to turn Modern Media Controls on in the test runners.
2683
2684         * DumpRenderTree/TestOptions.h:
2685         * DumpRenderTree/TestOptions.mm:
2686         (TestOptions::TestOptions):
2687         * DumpRenderTree/mac/DumpRenderTree.mm:
2688         (resetWebPreferencesToConsistentValues):
2689         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2690         (WTR::InjectedBundle::beginTesting):
2691         * WebKitTestRunner/TestController.cpp:
2692         (WTR::TestController::resetPreferencesToConsistentValues):
2693         (WTR::updateTestOptionsFromTestHeader):
2694         * WebKitTestRunner/TestOptions.h:
2695         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2696         (WTR::PlatformWebView::viewSupportsOptions):
2697         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2698         (WTR::PlatformWebView::viewSupportsOptions):
2699
2700 2016-11-30  Said Abou-Hallawa  <sabouhallawa@apple.com>
2701
2702         Add separate settings and preferences to enable/disable async decoding for large images and animated images
2703         https://bugs.webkit.org/show_bug.cgi?id=165177
2704
2705         Reviewed by Simon Fraser.
2706         
2707         Pref and a menu item to toggle async image decoding settings for WebKits 1 and 2.
2708
2709         * MiniBrowser/mac/SettingsController.h:
2710         * MiniBrowser/mac/SettingsController.m:
2711         (-[SettingsController _populateMenu]):
2712         (-[SettingsController validateMenuItem:]):
2713         (-[SettingsController toggleLargeImageAsyncDecodingEnabled:]):
2714         (-[SettingsController largeImageAsyncDecodingEnabled]):
2715         (-[SettingsController toggleAnimatedImageAsyncDecodingEnabled:]):
2716         (-[SettingsController animatedImageAsyncDecodingEnabled]):
2717         (-[SettingsController toggleAsyncImageDecodingEnabled:]): Deleted.
2718         (-[SettingsController asyncImageDecodingEnabled]): Deleted.
2719         * MiniBrowser/mac/WK1BrowserWindowController.m:
2720         (-[WK1BrowserWindowController didChangeSettings]):
2721         * MiniBrowser/mac/WK2BrowserWindowController.m:
2722         (-[WK2BrowserWindowController didChangeSettings]):
2723
2724 2016-11-30  Jonathan Bedard  <jbedard@apple.com>
2725
2726         Make it possible to use an existing simulator instance for one-off testing
2727         https://bugs.webkit.org/show_bug.cgi?id=164568
2728         <rdar://problem/29189133>
2729
2730         Reviewed by Daniel Bates.
2731
2732         With this patch, if a simulator is currently running on the machine and
2733         '--dedicated-simulators' is not passed into the application, only one simulator
2734         instance will be used, and this instance will be the existing instance.
2735         If no simulator is running or '--dedicated-simulators' is passed to the script,
2736         previous behavior will be used.
2737
2738         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2739         (parse_args):
2740         * Scripts/webkitpy/port/ios.py:
2741         (IOSSimulatorPort.__init__): Logic for enabling usage of currently running simulator.
2742         (IOSSimulatorPort._create_simulators): Only create simulators when needed, don't reset already running simulators.
2743         (IOSSimulatorPort.setup_test_run): Don't open already running simulators.
2744         (IOSSimulatorPort._quit_ios_simulator): Only quit simulators if we manage them.
2745         (IOSSimulatorPort.clean_up_test_run): Only clean up simulators if we manage them. 
2746         (IOSSimulatorPort._using_dedicated_simulators): True if simulators need to be managed, false if using an existing instance.
2747         (IOSSimulatorPort.device_id_for_worker_number): Access currently running simulator if not managing devices.
2748         * Scripts/webkitpy/xcode/simulator.py:
2749         (Simulator.current_device): Get currently running device.
2750
2751 2016-11-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2752
2753         [Linux] run-benchmark should be able to execute the benchmarks with more browsers.
2754         https://bugs.webkit.org/show_bug.cgi?id=164792
2755
2756         Reviewed by Michael Catanzaro.
2757
2758         This removes the GTKBrowserDriver (and the platform 'gtk') from the run-benchmark script,
2759         and adds a new LinuxBrowserDriver with a platform 'linux'.
2760
2761         It add also drivers for Chrome (Chromium), Firefox, Epiphany and MiniBrowser-GTK (previously MiniBrowser).
2762
2763         The detection of the platform is now done automatically, so it is not longer needed to pass a "--platform" parameter.
2764
2765         The tracking of the browser process is now more robust, we track the pid of the browser process and we only try to
2766         kill the ones that were executed by this script, instead of doing a 'killall $browser' (like before).
2767         We also check for browser process childs and we kill them if they are still alive after the main browser process has been killed.
2768         This depends on psutil, so this will only be done if psutil is installed.
2769
2770         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2771         (RunBenchmarkTests.start): The platform is now autodetected and the MiniBrowser driver is renamed to MiniBrowser-GTK.
2772         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2773         (BenchmarkRunner._run_benchmark): Fix a bug that caused close_browsers to be called twice. Its already called inside BenchmarkRunner._run_one_test.
2774         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py: Added.
2775         (LinuxBrowserDriver): Implement base class that has all the needed functionality for driving the browsers.
2776         (LinuxBrowserDriver.__init__):
2777         (LinuxBrowserDriver.prepare_env):
2778         (LinuxBrowserDriver.restore_env):
2779         (LinuxBrowserDriver.close_browsers): Made the dependency on psutil optional (because it was listed as such on the README file <Tools/Scripts/webkitpy/benchmark_runner/README.md>)
2780         (LinuxBrowserDriver.launch_url):
2781         (LinuxBrowserDriver._get_first_executable_path_from_list):
2782         (LinuxBrowserDriver._screen_size):
2783         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py: Copied from Tools/Scripts/webkitpy/benchmark_runner/browser_driver/gtk_minibrowser_driver.py.
2784         (LinuxChromeDriver):
2785         (LinuxChromeDriver.launch_url):
2786         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_epiphany_driver.py: Renamed from Tools/Scripts/webkitpy/benchmark_runner/browser_driver/gtk_browser_driver.py.
2787         (EpiphanyBrowserDriver):
2788         (EpiphanyBrowserDriver.launch_url):
2789         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py: Copied from Tools/Scripts/webkitpy/benchmark_runner/browser_driver/gtk_minibrowser_driver.py.
2790         (LinuxFirefoxDriver):
2791         (LinuxFirefoxDriver.launch_url):
2792         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py: Renamed from Tools/Scripts/webkitpy/benchmark_runner/browser_driver/gtk_minibrowser_driver.py.
2793         (GTKMiniBrowserDriver):
2794         (GTKMiniBrowserDriver.launch_url):
2795         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
2796         (SimpleHTTPServerDriver):
2797         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
2798         (getplatform):
2799         (getdefaultbrowser):
2800         (parse_args):
2801         * Scripts/webkitpy/benchmark_runner/utils.py:
2802         (load_subclasses): The loading of subclasses was still (even after r196979) sensitive to the order in which the modules are loaded.
2803         We have to ensure that the files containing subclasses of the base_class_file are loaded after the base_class_file,
2804         we can do that by matching against the base_class_file pattern when the list is created.
2805
2806 2016-11-29  Andy Estes  <aestes@apple.com>
2807
2808         [Cocoa] Enable two clang warnings recommended by Xcode
2809         https://bugs.webkit.org/show_bug.cgi?id=164498
2810
2811         Reviewed by Mark Lam.
2812
2813         * DumpRenderTree/mac/Configurations/Base.xcconfig: Enabled CLANG_WARN_INFINITE_RECURSION and CLANG_WARN_SUSPICIOUS_MOVE.
2814         * MiniBrowser/Configurations/Base.xcconfig: Ditto.
2815         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
2816         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
2817
2818 2016-11-29  Eric Carlson  <eric.carlson@apple.com>
2819
2820         [MediaStream] Don't request user permission for a device if it has already been granted in the current browsing context
2821         https://bugs.webkit.org/show_bug.cgi?id=164760
2822         <rdar://problem/29261266>
2823
2824         Reviewed by Youenn Fablet.
2825         
2826         Allow scripts to determine the number of times the user has been prompted for capture device access.
2827
2828         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2829         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2830         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
2831         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin):
2832         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
2833         (WTR::InjectedBundle::setUserMediaPermissionForOrigin): Deleted.
2834         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2835         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2836         (WTR::TestRunner::setUserMediaPersistentPermissionForOrigin):
2837         (WTR::TestRunner::userMediaPermissionRequestCountForOrigin):
2838         (WTR::TestRunner::resetUserMediaPermissionRequestCountForOrigin):
2839         (WTR::TestRunner::setUserMediaPermissionForOrigin): Deleted.
2840         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2841         * WebKitTestRunner/TestController.cpp:
2842         (WTR::TestController::resetStateToConsistentValues):
2843         (WTR::OriginSettings::incrementRequestCount):
2844         (WTR::OriginSettings::resetRequestCount):
2845         (WTR::OriginSettings::requestCount):
2846         (WTR::TestController::saltForOrigin):
2847         (WTR::TestController::setUserMediaPersistentPermissionForOrigin):
2848         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin):
2849         (WTR::TestController::settingsForOrigin):
2850         (WTR::TestController::userMediaPermissionRequestCountForOrigin):
2851         (WTR::TestController::resetUserMediaPermissionRequestCountForOrigin):
2852         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
2853         (WTR::TestController::setUserMediaPermissionForOrigin): Deleted.
2854         * WebKitTestRunner/TestController.h:
2855         * WebKitTestRunner/TestInvocation.cpp:
2856         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2857         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2858
2859 2016-11-29  Simon Fraser  <simon.fraser@apple.com>
2860
2861         intersection-observer-entry-interface.html test fails on the bots
2862         https://bugs.webkit.org/show_bug.cgi?id=165133
2863
2864         Reviewed by Darin Adler.
2865         
2866         Tests that enabled Intersection Observer via <!-- webkit-test-runner [ enableIntersectionObserver=true ] -->
2867         would fail sometimes, because TestController::ensureViewSupportsOptionsForTest() failed to check
2868         to see if this option required creating a new web view, so would just use the old view without
2869         even resetting preferences.
2870         
2871         In general, TestController doesn't distinguish properly between options that require the creation
2872         of a new view (like mock scrollbars), and those that can be simply reset as resetPreferencesToConsistentValues()
2873         does.
2874         
2875         Do the easy fix of having viewSupportsOptions() check options.enableIntersectionObserver. We should probably
2876         just call resetPreferencesToConsistentValues() even when re-use the same view.
2877         
2878         * WebKitTestRunner/TestController.cpp:
2879         (WTR::TestController::resetPreferencesToConsistentValues):
2880         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2881         (WTR::PlatformWebView::viewSupportsOptions):
2882         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2883         (WTR::PlatformWebView::viewSupportsOptions):
2884
2885 2016-11-28  Ryan Haddad  <ryanhaddad@apple.com>
2886
2887         Unreviewed, rolling out r209008.
2888
2889         This change appears to have caused two fast/mediastrem
2890         LayoutTests to fail.
2891
2892         Reverted changeset:
2893
2894         "[MediaStream] Don't request user permission for a device if
2895         it has already been granted in the current browsing context"
2896         https://bugs.webkit.org/show_bug.cgi?id=164760
2897         http://trac.webkit.org/changeset/209008
2898
2899 2016-11-28  Daniel Bates  <dabates@apple.com>
2900
2901         Teach webkitpy how to read CSSProperties.json r209001
2902         https://bugs.webkit.org/show_bug.cgi?id=165108
2903
2904         Reviewed by Simon Fraser.
2905
2906         Fix webkitpy logic so that it can read CSS property names from CSSProperties.json following r209001.
2907
2908         Following r209001 CSSPropertyNames.in no longer exists as it was replaced with CSSProperties.json.
2909         We need to modify the webkitpy machinery that processed CSSPropertyNames.in to process CSSProperties.json.
2910
2911         * Scripts/webkitpy/w3c/test_converter.py:
2912         (_W3CTestConverter.__init__): Make self._css_property_file and self._css_property_value_file local
2913         variables as it is unnecessary for them to be instance variables. Call read_webkit_prefixed_css_property_list()
2914         to read the property names from file CSSProperties.json. Call legacy_read_webkit_prefixed_css_property_list() to
2915         read CSS keyword values from CSSValueKeywords.in.
2916         (_W3CTestConverter.read_webkit_prefixed_css_property_list): Added.
2917         (_W3CTestConverter):
2918         (_W3CTestConverter.legacy_read_webkit_prefixed_css_property_list): Renamed from read_webkit_prefixed_css_property_list.
2919         * Scripts/webkitpy/w3c/test_importer_unittest.py:
2920         (TestImporterTest.test_harnesslinks_conversion): Substitute CSSProperties.json for CSSPropertyNames.in.
2921
2922 2016-11-28  Eric Carlson  <eric.carlson@apple.com>
2923
2924         [MediaStream] Don't request user permission for a device if it has already been granted in the current browsing context
2925         https://bugs.webkit.org/show_bug.cgi?id=164760
2926         <rdar://problem/29261266>
2927
2928         Reviewed by Youenn Fablet.
2929         
2930         Allow scripts to determine the number of times the user has been prompted for capture device access.
2931
2932         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2933         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2934         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
2935         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin):
2936         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
2937         (WTR::InjectedBundle::setUserMediaPermissionForOrigin): Deleted.
2938         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2939         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2940         (WTR::TestRunner::setUserMediaPersistentPermissionForOrigin):
2941         (WTR::TestRunner::userMediaPermissionRequestCountForOrigin):
2942         (WTR::TestRunner::resetUserMediaPermissionRequestCountForOrigin):
2943         (WTR::TestRunner::setUserMediaPermissionForOrigin): Deleted.
2944         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2945         * WebKitTestRunner/TestController.cpp:
2946         (WTR::TestController::resetStateToConsistentValues):
2947         (WTR::OriginSettings::incrementRequestCount):
2948         (WTR::OriginSettings::resetRequestCount):
2949         (WTR::OriginSettings::requestCount):
2950         (WTR::TestController::saltForOrigin):
2951         (WTR::TestController::setUserMediaPersistentPermissionForOrigin):
2952         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin):
2953         (WTR::TestController::settingsForOrigin):
2954         (WTR::TestController::userMediaPermissionRequestCountForOrigin):
2955         (WTR::TestController::resetUserMediaPermissionRequestCountForOrigin):
2956         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
2957         (WTR::TestController::setUserMediaPermissionForOrigin): Deleted.
2958         * WebKitTestRunner/TestController.h:
2959         * WebKitTestRunner/TestInvocation.cpp:
2960         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2961         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2962
2963 2016-11-18  Jer Noble  <jer.noble@apple.com>
2964
2965         Add some performance tests for various aspects of media loading and playback.
2966         https://bugs.webkit.org/show_bug.cgi?id=164977
2967
2968         Reviewed by Darin Adler.
2969
2970         Allow callers to pass in extra alias/directory pairs to run-webkit-httpd.
2971
2972         * Scripts/run-webkit-httpd:
2973         (parse_args):
2974         (main):
2975
2976 2016-11-27  Simon Fraser  <simon.fraser@apple.com>
2977
2978         Another fix for CMake.
2979
2980         * DumpRenderTree/TestOptions.h:
2981         * DumpRenderTree/TestOptions.mm:
2982
2983 2016-11-26  Simon Fraser  <simon.fraser@apple.com>
2984
2985         Better fix for the Mac CMake build.
2986
2987         * DumpRenderTree/PlatformMac.cmake:
2988
2989 2016-11-26  Simon Fraser  <simon.fraser@apple.com>
2990
2991         Attempt to fix Mac CMake build.
2992
2993         * DumpRenderTree/PlatformMac.cmake:
2994
2995 2016-11-26  Yusuke Suzuki  <utatane.tea@gmail.com>
2996
2997         [WTF] Import std::optional reference implementation as WTF::Optional
2998         https://bugs.webkit.org/show_bug.cgi?id=164199
2999
3000         Reviewed by Saam Barati and Sam Weinig.
3001
3002         Use WTF::Optional::value_or.
3003
3004         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3005         (WTR::UIScriptController::stableStateOverride):
3006         (WTR::UIScriptController::setStableStateOverride):
3007         * TestRunnerShared/Bindings/JSWrappable.h:
3008         (WTR::JSValueMakeBooleanOrNull):
3009         (WTR::JSValueToNullableBoolean):
3010         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3011         (WTR::UIScriptController::stableStateOverride):
3012         (WTR::UIScriptController::setStableStateOverride):
3013         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3014         * TestWebKitAPI/Tests/WTF/Optional.cpp:
3015         (TestWebKitAPI::TEST):
3016         * TestWebKitAPI/Tests/WebCore/HTMLParserIdioms.cpp:
3017         (TestWebKitAPI::testParseHTMLInteger):
3018         (TestWebKitAPI::testParseHTMLNonNegativeInteger):
3019         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3020         (TestWebKitAPI::checkURL):
3021         (TestWebKitAPI::checkRelativeURL):
3022         (TestWebKitAPI::checkURLDifferences):
3023         (TestWebKitAPI::checkRelativeURLDifferences):
3024         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3025         (WTR::UIScriptController::stableStateOverride):
3026         (WTR::UIScriptController::setStableStateOverride):
3027
3028 2016-11-26  Sam Weinig  <sam@webkit.org>
3029
3030         Convert IntersectionObserver over to using RuntimeEnabledFeatures so it can be properly excluded from script
3031         https://bugs.webkit.org/show_bug.cgi?id=164965
3032
3033         Reviewed by Simon Fraser.
3034
3035         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3036         Add new files.
3037
3038         * DumpRenderTree/TestOptions.h: Added.
3039         * DumpRenderTree/TestOptions.mm: Added.
3040         (parseBooleanTestHeaderValue):
3041         (TestOptions::TestOptions):
3042         Port TestOption parsing from WKTR to DRT.
3043
3044         * DumpRenderTree/mac/DumpRenderTree.mm:
3045         (resetWebPreferencesToConsistentValues):
3046         (resetWebViewToConsistentStateBeforeTesting):
3047         (runTest):
3048         * WebKitTestRunner/TestController.cpp:
3049         Pass TestOptions down to resetWebPreferencesToConsistentValues to allow setting
3050         preferences conditionally.
3051
3052         (WTR::TestController::resetPreferencesToConsistentValues):
3053         (WTR::updateTestOptionsFromTestHeader):
3054         * WebKitTestRunner/TestOptions.h:
3055         Add a new test option header, enableIntersectionObserver, to enable IntersectionObserver.
3056
3057 2016-11-26  Simon Fraser  <simon.fraser@apple.com>
3058
3059         Migrate some layout timer-related code from std::chrono to Seconds and MonotonicTime
3060         https://bugs.webkit.org/show_bug.cgi?id=164992
3061
3062         Reviewed by Darin Adler.
3063         
3064         Use Seconds::zero().
3065
3066         * TestWebKitAPI/Tests/WTF/Condition.cpp:
3067
3068 2016-11-26  Simon Fraser  <simon.fraser@apple.com>
3069
3070         Add literals for various time units
3071         https://bugs.webkit.org/show_bug.cgi?id=165074
3072
3073         Reviewed by Filip Pizlo.
3074         
3075         Add tests for new time literals. Add new tests for units.
3076
3077         * TestWebKitAPI/Tests/WTF/Time.cpp:
3078         (TestWebKitAPI::TEST):
3079
3080 2016-11-25  Csaba Osztrogonác  <ossy@webkit.org>
3081
3082         Fix compile warnings after r208415
3083         https://bugs.webkit.org/show_bug.cgi?id=165061
3084
3085         Reviewed by Andy Estes.
3086
3087         * TestWebKitAPI/Tests/WTF/Time.cpp:
3088         (TestWebKitAPI::TEST):
3089
3090 2016-11-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3091
3092         [GTK] Notifications API does not expose or respect the "tag" attribute
3093         https://bugs.webkit.org/show_bug.cgi?id=164771
3094
3095         Reviewed by Gustavo Noronha Silva.
3096
3097         Verify that showing a notification with the same tag as another notification closes the
3098         previous notification before the new notification is shown.
3099
3100         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3101         (testWebViewNotification):
3102
3103 2016-11-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3104
3105         Unreviewed. Fix GTK+ test /webkit2/WebKitWebContext/get-plugins after r208429.
3106
3107         Test plugin library was renamed as libTestNetscapePlugIn.so in r208429.
3108
3109         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
3110         (testWebContextGetPlugins): Update the library name.
3111
3112 2016-11-22  Darin Adler  <darin@apple.com>
3113
3114         Make normal case fast in the input element limitString function
3115         https://bugs.webkit.org/show_bug.cgi?id=165023
3116
3117         Reviewed by Dan Bernstein.
3118
3119         * TestWebKitAPI/CMakeLists.txt: Added TextBreakIterator.cpp.
3120         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
3121         * TestWebKitAPI/Tests/WTF/TextBreakIterator.cpp: Added.
3122         Contains some tests for the numGraphemeClusters and
3123         numCharactersInGraphemeClusters functions that I used to make sure
3124         that the new fast paths I added work correctly.
3125
3126 2016-11-22  Tomas Popela  <tpopela@redhat.com>
3127
3128         Unreviewed, add myself as a WebKit committer.
3129
3130         * Scripts/webkitpy/common/config/contributors.json:
3131
3132 2016-11-21  Mark Lam  <mark.lam@apple.com>
3133
3134         Hasher::addCharacters() should be able to handle zero length strings.
3135         https://bugs.webkit.org/show_bug.cgi?id=165024
3136
3137         Reviewed by Yusuke Suzuki.
3138
3139         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
3140         (TestWebKitAPI::TEST):
3141
3142 2016-11-21  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3143
3144         [CMake] build fails after update to cmake 3.7
3145         https://bugs.webkit.org/show_bug.cgi?id=165008
3146
3147         Reviewed by Dan Bernstein.
3148
3149         When we remove the CMake cache, we should remove both the
3150         CMakeCache.txt file and the CMakeFiles directory.
3151         See: https://gitlab.kitware.com/cmake/cmake/issues/14820
3152
3153         * Scripts/webkitdirs.pm:
3154         (cmakeFilesPath):
3155         (removeCMakeCache):
3156
3157 2016-11-16  Philippe Normand  <pnormand@igalia.com>
3158
3159         [GTK][WebRTC] Switch to downstream OpenWebRTC and more recent GStreamer
3160         https://bugs.webkit.org/show_bug.cgi?id=164817
3161
3162         Reviewed by Alejandro G. Castro.
3163
3164         This is temporary, hopefully. The OpenWebRTC patches will/should
3165         be soon reviewed and upstream but meanwhile it makes sense to use
3166         the Igalia downstream fork so that the WebRTC testing is easier.
3167
3168         Recent GStreamer patches are also needed for RTP bundling support
3169         and RTP retransmission fixes.
3170
3171         * gtk/jhbuild.modules:
3172         * gtk/openwebrtc.modules: Removed.
3173         * gtk/patches/gst-plugins-good-0001-rtpbin-pipeline-gets-an-EOS-when-any-rtpsources-byes.patch: Added.
3174         * gtk/patches/gst-plugins-good-0002-rtpbin-avoid-generating-errors-when-rtcp-messages-ar.patch: Added.
3175         * gtk/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Added.
3176
3177 2016-11-20  Zan Dobersek  <zdobersek@igalia.com>
3178
3179         [EncryptedMedia] Make EME API runtime-enabled
3180         https://bugs.webkit.org/show_bug.cgi?id=164927
3181
3182         Reviewed by Jer Noble.
3183
3184         Enable the EME API via the WKTR InjectedBundle whenever testing
3185         commences. This does not have any effect unless the EME feature
3186         is enabled at compile-time, but it's still added to match other
3187         features and for future use.
3188
3189         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3190         (WTR::InjectedBundle::beginTesting):
3191         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3192         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
3193         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3194
3195 2016-11-19  Simon Fraser  <simon.fraser@apple.com>
3196
3197         Fix the Mac and iOS bulds.
3198
3199         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3200         (-[TestRunnerWKWebView _stableStateOverride]):
3201         (-[TestRunnerWKWebView _setStableStateOverride:]):
3202
3203 2016-11-18  Simon Fraser  <simon.fraser@apple.com>
3204
3205         Make it possible to test non-stable-state scrolling on iOS
3206         https://bugs.webkit.org/show_bug.cgi?id=164905
3207
3208         Reviewed by Dan Bernstein.
3209
3210         Make it possible for an iOS layout test to force every visible rect update
3211         from the UI process to the web process to be in a non-stable state. This emulates
3212         what happens during panning and zooming interactions, and allows us to test the
3213         scrolling and layer trees in these transient states.
3214         
3215         This is done by adding a testing property on WKWebView, _stableStateOverride, whose
3216         getters and setters are overridden in TestRunnerWKWebView. When non-nil, we _updateVisibleContentRectAfterScrollInView
3217         consults the NSNumber's boolValue and uses it to override the stable state.
3218         
3219         To facilitate this kind of testing, also add immediateScrollToOffset() and
3220         immediateZoomToScale() to UIScriptController. Finally, add doAfterPresentationUpdate()
3221         which provides a callback that fires after one trip to the web process and back.
3222         
3223         Add code generation support for optional boolean attributes in IDL.
3224
3225         Align CodeGeneratorDumpRenderTree.pm and CodeGeneratorTestRunner.pm.
3226
3227         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
3228         (_generateImplementationFile):
3229         (_platformTypeConstructor):
3230         (_returnExpression):
3231         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3232         (WTR::UIScriptController::doAfterPresentationUpdate):
3233         (WTR::contentOffsetBoundedInValidRange):
3234         (WTR::UIScriptController::scrollToOffset):
3235         (WTR::UIScriptController::immediateScrollToOffset):
3236         (WTR::UIScriptController::immediateZoomToScale):
3237         (WTR::UIScriptController::stableStateOverride):
3238         (WTR::UIScriptController::setStableStateOverride):
3239         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3240         (WTR::UIScriptController::doAfterPresentationUpdate):
3241         * TestRunnerShared/Bindings/JSWrappable.h:
3242         (WTR::JSValueMakeBooleanOrNull):
3243         (WTR::JSValueToNullableBoolean):
3244         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3245         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3246         (WTR::UIScriptController::immediateScrollToOffset):
3247         (WTR::UIScriptController::immediateZoomToScale):
3248         (WTR::UIScriptController::stableStateOverride):
3249         (WTR::UIScriptController::setStableStateOverride):
3250         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3251         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
3252         (_classRefGetter):
3253         (_platformTypeConstructor):
3254         (_returnExpression):
3255         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3256         (-[TestRunnerWKWebView dealloc]):
3257         (-[TestRunnerWKWebView _stableStateOverride]):
3258         (-[TestRunnerWKWebView _setStableStateOverride:]):
3259         * WebKitTestRunner/ios/TestControllerIOS.mm:
3260         (WTR::TestController::platformResetStateToConsistentValues):
3261         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3262         (WTR::UIScriptController::doAsyncTask):
3263         (WTR::UIScriptController::doAfterPresentationUpdate):
3264         (WTR::UIScriptController::zoomToScale):
3265         (WTR::UIScriptController::immediateScrollToOffset):
3266         (WTR::UIScriptController::immediateZoomToScale):
3267         (WTR::UIScriptController::stableStateOverride):
3268         (WTR::UIScriptController::setStableStateOverride):
3269         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3270         (WTR::UIScriptController::doAfterPresentationUpdate):
3271
3272 2016-11-19  Joanmarie Diggs  <jdiggs@igalia.com>
3273
3274         AX: [ATK] Expose aria-busy via ATK_STATE_BUSY
3275         https://bugs.webkit.org/show_bug.cgi?id=164909
3276
3277         Reviewed by Chris Fleizach.
3278
3279         Implement boolAttributeValue() for ATK so we can test AXElementBusy.
3280
3281         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3282         (WTR::AccessibilityUIElement::boolAttributeValue):
3283
3284 2016-11-18  Simon Fraser  <simon.fraser@apple.com>
3285
3286         [iOS WK2] Eliminate a source of flakiness in layout tests by forcing WebPage into "responsive" mode for all tests, with an internals override
3287         https://bugs.webkit.org/show_bug.cgi?id=164980
3288
3289         Reviewed by Chris Dumez.
3290
3291         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3292         (WTR::InjectedBundlePage::prepare):
3293
3294 2016-11-18  Dean Jackson  <dino@apple.com>
3295
3296         AX: "(inverted-colors)" media query only matches on page reload; should match on change
3297         https://bugs.webkit.org/show_bug.cgi?id=163564
3298         <rdar://problem/28807350>
3299
3300         Reviewed by Simon Fraser.
3301
3302         Add a UIScriptController method that tricks WebKit into thinking
3303         it has received a notification that accessibility settings have
3304         changed. Combined with our forced overrides, this allows us to
3305         test if a page would react to the notifications.
3306
3307         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3308         (WTR::UIScriptController::simulateAccessibilitySettingsChangeNotification):
3309         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3310         (WTR::UIScriptController::simulateAccessibilitySettingsChangeNotification):
3311         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3312         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3313         (WTR::simulateAccessibilitySettingsChangeNotification):
3314         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3315         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3316         (WTR::UIScriptController::simulateAccessibilitySettingsChangeNotification):
3317         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3318         (WTR::UIScriptController::simulateAccessibilitySettingsChangeNotification):
3319
3320 2016-11-18  Alex Christensen  <achristensen@webkit.org>
3321
3322         Fix API test after r208902
3323         https://bugs.webkit.org/show_bug.cgi?id=144194
3324
3325         * TestWebKitAPI/Tests/Cocoa/URLExtras.mm:
3326         (TestWebKitAPI::TEST):
3327         The fullwidth solidus, U+FF0F, changed encoding from IDN2003 to IDN2008, probably to prevent domains from using it
3328         to spoof other domains.  https://webkit.org/blog/ and https://webkit.org\uFF0Fblog/ would otherwise look 
3329         too similar when rendered.
3330
3331 2016-11-17  Alex Christensen  <achristensen@webkit.org>
3332
3333         Support IDN2008 with UTS #46 instead of IDN2003
3334         https://bugs.webkit.org/show_bug.cgi?id=144194
3335
3336         Reviewed by Darin Adler.
3337
3338         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3339         (TestWebKitAPI::TEST_F):
3340         Add some tests from http://unicode.org/faq/idn.html verifying that we follow UTS46's deviations from IDN2008.
3341         Add some tests based on https://tools.ietf.org/html/rfc5893 verifying that we check for bidirectional text.
3342         Add a test based on https://tools.ietf.org/html/rfc5892 verifying that we do not do ContextO check.
3343         Add a test for U+321D and U+321E which have particularly interesting punycode encodings.  We match Firefox here now.
3344         Also add a test from http://www.unicode.org/reports/tr46/#IDNAComparison verifying we are not using IDN2003.
3345         We should consider importing all of http://www.unicode.org/Public/idna/9.0.0/IdnaTest.txt as URL domain tests.
3346
3347 2016-11-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3348
3349         Downloads started by context menu actions should also have a web view associated
3350         https://bugs.webkit.org/show_bug.cgi?id=164364
3351
3352         Reviewed by Michael Catanzaro.
3353
3354         Add a GTK+ unit tests to check that downloads started by the context menu have a web view associated.
3355
3356         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
3357         (downloadLocalFileSuccessfully):
3358         (testDownloadOverwriteDestinationDisallowed):
3359         (testDownloadLocalFileError):
3360         (testDownloadRemoteFile):
3361         (testDownloadRemoteFileError):
3362         (testDownloadMIMEType):
3363         (contextMenuCallback):
3364         (testContextMenuDownloadActions):
3365         (beforeAll):
3366
3367 2016-11-17  Ryosuke Niwa  <rniwa@webkit.org>
3368
3369         Add an experimental API to find elements across shadow boundaries
3370         https://bugs.webkit.org/show_bug.cgi?id=164851
3371         <rdar://problem/28220092>
3372
3373         Reviewed by Sam Weinig.
3374
3375         Added test cases for window.collectMatchingElementsInFlatTree to WebKit2.InjectedBundleMakeAllShadowRootOpen.
3376
3377         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3378         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRoot*s*Open_Bundle.cpp: Renamed
3379         from InjectedBundleMakeAllShadowRootOpen_Bundle.cpp.
3380         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize): Added test cases for
3381         window.collectMatchingElementsInFlatTree by calling alert() many times.
3382         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp:
3383         (TestWebKitAPI::runJavaScriptAlert): Added expectations for multiple test cases. Each test case
3384         finishes with a call to alert, and moves testNumber forward.
3385         (TestWebKitAPI::TEST): Use the newly added closed-shadow-tree-test.html
3386         * TestWebKitAPI/Tests/WebKit2/closed-shadow-tree-test.html: Added. Creates a shadow tree with slots
3387         and tests that window.collectMatchingElementsInFlatTree is not present when
3388         an event named "testnormalworld" is dispatched by the injected bundle.
3389
3390 2016-11-17  Brady Eidson  <beidson@apple.com>
3391
3392         Add _WKIconLoadingDelegate SPI.
3393         https://bugs.webkit.org/show_bug.cgi?id=164894
3394
3395         Reviewed by Alex Christensen.
3396
3397         Add MiniBrowser support for this new SPI, configurable with a setting.
3398
3399         * MiniBrowser/mac/SettingsController.h:
3400         * MiniBrowser/mac/SettingsController.m:
3401         (-[SettingsController _populateMenu]):
3402         (-[SettingsController validateMenuItem:]):
3403         (-[SettingsController loadsAllSiteIcons]):
3404         (-[SettingsController toggleLoadsAllSiteIcons:]):
3405         * MiniBrowser/mac/WK2BrowserWindowController.m:
3406         (-[WK2BrowserWindowController awakeFromNib]):
3407         (-[WK2BrowserWindowController webView:shouldLoadIconWithParameters:completionHandler:]):
3408
3409 2016-11-17  Caitlin Potter  <caitp@igalia.com>
3410
3411         [JSC] remove leftover references to ES2017_ASYNCFUNCTION_SYNTAX flag
3412         https://bugs.webkit.org/show_bug.cgi?id=164879
3413
3414         Reviewed by Alex Christensen.
3415
3416         The flag was referenced in FeatureList.pm and in one of the
3417         FeatureDefines.xcconfig files, despite being removed.
3418
3419         * Scripts/webkitperl/FeatureList.pm:
3420         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3421
3422 2016-11-17  Per Arne Vollan  <pvollan@apple.com>
3423
3424         [Win] run-api-tests is failing.
3425         https://bugs.webkit.org/show_bug.cgi?id=164818
3426
3427         Reviewed by Alexey Proskuryakov.
3428
3429         Make sure Visual Studio interprets string literal as utf8.
3430  
3431         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3432         (TestWebKitAPI::TEST_F):
3433
3434 2016-11-17  Yusuke Suzuki  <utatane.tea@gmail.com>
3435
3436         [JSC] WTF::TemporaryChange with WTF::SetForScope
3437         https://bugs.webkit.org/show_bug.cgi?id=164761
3438
3439         Reviewed by Saam Barati.
3440
3441         * TestWebKitAPI/CMakeLists.txt:
3442         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3443         * TestWebKitAPI/Tests/WTF/SetForScope.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/TemporaryChange.cpp.
3444         (TestWebKitAPI::TEST):
3445         * WebKitTestRunner/TestController.cpp:
3446         (WTR::TestController::resetStateToConsistentValues):
3447
3448 2016-11-16  Alexey Proskuryakov  <ap@apple.com>
3449
3450         REGRESSION (r208455): LayoutTests swipe/pushState-cached-back-swipe.html and swipe/main-frame-pinning-requirement.html are failing
3451         https://bugs.webkit.org/show_bug.cgi?id=164572
3452
3453         Reviewed by Tim Horton.
3454
3455         * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformResetStateToConsistentValues):
3456         Use the correct constant.
3457
3458 2016-11-16  Yusuke Suzuki  <utatane.tea@gmail.com>
3459
3460         [ES6][WebCore] Change ES6_MODULES compile time flag to runtime flag
3461         https://bugs.webkit.org/show_bug.cgi?id=164827
3462
3463         Reviewed by Ryosuke Niwa.
3464
3465         Enabled ES6 Modules in test runners.
3466
3467         * DumpRenderTree/mac/DumpRenderTree.mm:
3468         (resetWebPreferencesToConsistentValues):
3469         * DumpRenderTree/win/DumpRenderTree.cpp:
3470         (resetWebPreferencesToConsistentValues):
3471         * Scripts/webkitperl/FeatureList.pm:
3472         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3473         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3474         (WTR::InjectedBundle::beginTesting):
3475         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3476         (WTR::TestRunner::setES6ModulesEnabled):
3477         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3478
3479 2016-11-16  Simon Fraser  <simon.fraser@apple.com>
3480
3481         Hard to write reliable UIScriptController scrollingTreeAsText tests
3482         https://bugs.webkit.org/show_bug.cgi?id=164764
3483
3484         Reviewed by Wenson Hsieh.
3485
3486         Fix one cause of flakiness by resetting the WKWebView's UIScrollView scale
3487         and scroll position between tests.
3488
3489         * WebKitTestRunner/ios/TestControllerIOS.mm:
3490         (WTR::TestController::platformResetStateToConsistentValues):
3491
3492 2016-11-16  Simon Fraser  <simon.fraser@apple.com>
3493
3494         UIScriptController: script with no async tasks fails if an earlier script registered a callback
3495         https://bugs.webkit.org/show_bug.cgi?id=164762
3496
3497         Reviewed by Wenson Hsieh.
3498         
3499         Make TestRunner::callUIScriptCallback() async in DumpRenderTree to match WebKitTestRunner behavior.
3500         This fixes ui-side-script-with-callback.html in WK1, which failed because the second runUIScript()
3501         would occur inside the completion callback from the first. This no longer happens.
3502
3503         * DumpRenderTree/TestRunner.cpp:
3504         (TestRunner::callUIScriptCallback):
3505         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
3506         (UIScriptContext::tryToCompleteUIScriptForCurrentParentCallback):
3507
3508 2016-11-16  Ryan Haddad  <ryanhaddad@apple.com>
3509
3510         Unreviewed, rolling out r208770.
3511
3512         The test added with this change is timing out on mac-wk1.
3513
3514         Reverted changeset:
3515
3516         "UIScriptController: script with no async tasks fails if an
3517         earlier script registered a callback"
3518         https://bugs.webkit.org/show_bug.cgi?id=164762
3519         http://trac.webkit.org/changeset/208770
3520
3521 2016-11-16  Per Arne Vollan  <pvollan@apple.com>
3522
3523         [Win] WebCore test is failing.
3524         https://bugs.webkit.org/show_bug.cgi?id=164772
3525
3526         Reviewed by Brent Fulgham.
3527
3528         The value of CGRectInfinite is not the same on Windows as on Mac.
3529
3530         * TestWebKitAPI/Tests/WebCore/FloatRect.cpp:
3531         (TestWebKitAPI::TEST):
3532
3533 2016-11-15  Alexey Proskuryakov  <ap@apple.com>
3534
3535         Update Youenn's e-mail addresses.
3536
3537         * Scripts/webkitpy/common/config/contributors.json:
3538
3539 2016-11-15  Simon Fraser  <simon.fraser@apple.com>
3540
3541         UIScriptController: script with no async tasks fails if an earlier script registered a callback
3542         https://bugs.webkit.org/show_bug.cgi?id=164762
3543
3544         Reviewed by Wenson Hsieh.
3545         
3546         UIScriptContext::runUIScript() considers a script to be "immediate" if that script doesn't
3547         queue any async tasks. However, if an earlier UI script registered a callback, UIScriptContext::runUIScript()
3548         would consider that an outstanding task.
3549         
3550         Fix by unregistering any callbacks associated with the current UI script when uiScriptComplete() is called.
3551
3552         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
3553         (UIScriptContext::tryToCompleteUIScriptForCurrentParentCallback):
3554
3555 2016-11-15  Simon Fraser  <simon.fraser@apple.com>
3556
3557         UIScriptController: setting a callback to undefined should unregister it
3558         https://bugs.webkit.org/show_bug.cgi?id=164796
3559
3560         Reviewed by Dean Jackson.
3561         
3562         "Immediate" UI scripts (those that don't schedule any async tasks) should return
3563         immediately, without the need to call uiScriptComplete(). However, this is broken if
3564         an earlier UI script registered a callback (since no-one clears that callback after the
3565         first script completes).
3566
3567         Make possible the workaround of setting the callback to undefined, which previously did
3568         not clear the callback registration.
3569
3570         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
3571         (UIScriptContext::registerCallback):
3572         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
3573         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3574         (WTR::UIScriptController::platformClearAllCallbacks):
3575
3576 2016-11-14  Mark Lam  <mark.lam@apple.com>
3577
3578         Enhance run-jsc-stress-test script to allow optional test specific options to be added for all test run configurations.
3579         https://bugs.webkit.org/show_bug.cgi?id=164695
3580
3581         Reviewed by Keith Miller.
3582
3583         This gives us more flexibility when specific tests needs to enable special JSC
3584         options in order to exercise specific code paths to be tested.  It also saves us
3585         from having to create duplicate test run configurations e.g. runMiscFTLNoCJITTest.
3586         We can now just use runFTLNoCJIT in its place.
3587
3588         Also replaced the ifJSCArgIsntProvidedAreWeReleaseBuild variable with $buildType
3589         so that we have the ability to skip certain tests for release or debug builds.
3590         This will be needed in the upcoming patch for https://webkit.org/b/155145.
3591
3592         * Scripts/run-jsc-stress-tests:
3593
3594 2016-11-14  Joanmarie Diggs  <jdiggs@igalia.com>
3595
3596         AX: [ATK] Expose STATE_SINGLE_LINE and STATE_MULTI_LINE for ARIA searchbox role
3597         https://bugs.webkit.org/show_bug.cgi?id=164712
3598
3599         Reviewed by Chris Fleizach.
3600
3601         Add AccessibilityUIElement::isSingleLine, AccessibilityUIElement::isMultiLine
3602         to DRT and WKTR. Implement it for ATK.
3603
3604         * DumpRenderTree/AccessibilityUIElement.h:
3605         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3606         (AccessibilityUIElement::isSingleLine):
3607         (AccessibilityUIElement::isMultiLine):
3608         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3609         (AccessibilityUIElement::isSingleLine):
3610         (AccessibilityUIElement::isMultiLine):
3611         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3612         (AccessibilityUIElement::isSingleLine):
3613         (AccessibilityUIElement::isMultiLine):
3614         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3615         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3616         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: