Need to specify a django version, instead of using default
[WebKit-https.git] / Tools / ChangeLog
1 2011-09-20  Tom Zakrajsek  <tomz@codeaurora.org>
2
3         Need to specify a django version, instead of using default
4         https://bugs.webkit.org/show_bug.cgi?id=68398
5
6         Reviewed by Eric Seidel.
7
8         * QueueStatusServer/__init__.py:
9         * QueueStatusServer/main.py:
10
11 2011-09-20  Tom Zakrajsek  <tomz@codeaurora.org>
12
13         Update committers.py with a few more contributor contacts
14         https://bugs.webkit.org/show_bug.cgi?id=68487
15
16         Reviewed by Eric Seidel.
17
18         * Scripts/webkitpy/common/config/committers.py:
19
20 2011-09-20  Leandro Pereira  <leandro@profusion.mobi>
21
22         Fix webkitpy unit tests after 95547 and 95549
23         https://bugs.webkit.org/show_bug.cgi?id=68483
24
25         Reviewed by Adam Barth.
26         
27         Fix tests for ChangeLog.touched_files() and ChangeLog.parse_entries_from_file().
28
29         * Scripts/webkitpy/common/checkout/changelog_unittest.py: While testing
30         parse_entries_from_file(), use StringIO and entry.reviewer_text().
31         While testing parse_latest_entry_from_file(), expect the correct
32         touched_files() list.
33
34 2011-09-20  Adam Barth  <abarth@webkit.org>
35
36         garden-o-matic makes it hard to compare images when scroll bars appear
37         https://bugs.webkit.org/show_bug.cgi?id=68482
38
39         Reviewed by Eric Seidel.
40
41         Because we autoscale image width, the images rescale if we overflow
42         vertically and get a scrollbar.  That makes it hard to compare two sets
43         of images.  This patch reserves space for the scrollbar so we won't
44         have the layout change.
45
46         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
47
48 2011-09-20  Sheriff Bot  <webkit.review.bot@gmail.com>
49
50         Unreviewed, rolling out r95565.
51         http://trac.webkit.org/changeset/95565
52         https://bugs.webkit.org/show_bug.cgi?id=68470
53
54         Broke builds (Requested by andersca on #webkit).
55
56         * MiniBrowser/gtk/BrowserWindow.c:
57         (mouseDidMoveOverElement):
58
59 2011-09-20  Nayan Kumar K  <nayankk@motorola.com>
60
61         Get hover'ed element URL from HitTest.
62         
63         mouseDidMoveOverElement now gets the hover'ed element link using
64         WKHitTestResult API's.
65         https://bugs.webkit.org/show_bug.cgi?id=68426
66
67         Reviewed by Anders Carlsson.
68
69         * MiniBrowser/gtk/BrowserWindow.c:
70         (mouseDidMoveOverElement):
71
72 2011-09-20  Leandro Pereira  <leandro@profusion.mobi>
73
74         Changelog class should have a method to return all entries
75         https://bugs.webkit.org/show_bug.cgi?id=68399
76         
77         Implement ChangeLog.parse_entries_from_file(). This method returns a generator
78         of ChangeLogEntry objects, ordered from the latest to the oldest entry in the file.
79
80         Reviewed by Ryosuke Niwa.
81
82         * Scripts/webkitpy/common/checkout/changelog.py: Copy parse_latest_entry_from_file()
83         and adapt it to become a generator.
84         * Scripts/webkitpy/common/checkout/changelog_unittest.py: Add test case.
85
86 2011-09-20  Jarred Nicholls  <jarred@sencha.com>
87
88         [Qt] Permit qrc resources to load in QWebSettings::setUserStyleSheetUrl()
89         https://bugs.webkit.org/show_bug.cgi?id=51159
90
91         Permit any URL with a local scheme to set a user style sheet. Allow qrc
92         resource URLs as arguments to QWebSettings::setUserStyleSheetUrl().
93         
94         Add DRT/WKTR qrc resource to test loading user style sheets from a qrc URL.
95
96         Reviewed by Kenneth Rohde Christiansen.
97
98         * DumpRenderTree/qt/DumpRenderTree.pro:
99         * DumpRenderTree/qt/DumpRenderTree.qrc: Added.
100         * DumpRenderTree/qt/resources/user.css: Added.
101         (body):
102         * WebKitTestRunner/qt/WebKitTestRunner.pro:
103         * WebKitTestRunner/qt/WebKitTestRunner.qrc: Added.
104         * WebKitTestRunner/qt/resources/user.css: Added.
105         (body):
106
107 2011-09-20  Leandro Pereira  <leandro@profusion.mobi>
108
109         ChangeLogEntry class should contain a list of touched files
110         https://bugs.webkit.org/show_bug.cgi?id=68115
111
112         Reviewed by Eric Seidel.
113         
114         Add method to return the list of files touched in a ChangeLog entry.
115
116         * Scripts/webkitpy/common/checkout/changelog.py: Add
117         touched_files_regexp and touched_files() method.
118         * Scripts/webkitpy/common/checkout/changelog_unittest.py: Implement
119         unit tests for touched_files() method.
120
121 2011-09-20  Sheriff Bot  <webkit.review.bot@gmail.com>
122
123         Unreviewed, rolling out r95526 and r95541.
124         http://trac.webkit.org/changeset/95526
125         http://trac.webkit.org/changeset/95541
126         https://bugs.webkit.org/show_bug.cgi?id=68443
127
128         It broke 6 tests (Requested by ossy_ on #webkit).
129
130         * DumpRenderTree/qt/main.cpp:
131         (main):
132         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
133         (WTR::activateFonts):
134
135 2011-09-20  Tom Zakrajsek  <tomz@codeaurora.org>
136
137         Fix patch and bug numbering in the mocktool simulation code
138         https://bugs.webkit.org/show_bug.cgi?id=68374
139
140         Reviewed by Adam Barth.
141
142         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
143         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
144         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
145         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
146         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
147         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
148         * Scripts/webkitpy/tool/commands/download_unittest.py:
149         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
150         * Scripts/webkitpy/tool/commands/queries_unittest.py:
151         * Scripts/webkitpy/tool/commands/queues_unittest.py:
152         * Scripts/webkitpy/tool/commands/queuestest.py:
153         * Scripts/webkitpy/tool/commands/upload_unittest.py:
154         * Scripts/webkitpy/tool/mocktool.py:
155         * Scripts/webkitpy/tool/steps/steps_unittest.py:
156         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
157
158 2011-09-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
159
160         [Qt] Don't override default QApplication font for DRT and WTR
161
162         Revision 95526 moved the relevant code below the QApplication
163         constructor, to fix a potential crash, and that made the code
164         take effect, breaking 6 tests.
165
166         We should rely on the QWebSettings to set default fonts, and
167         this QApplication::setFont() is a relic from when we didn't
168         have that option, so we remove the code.
169
170         Reviewed by Csaba Osztrogonác.
171
172         * DumpRenderTree/qt/main.cpp:
173         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
174
175 2011-09-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
176
177         WebKitTestRunner: Provide usage if run without arguments
178
179         If WTR is run without either one or more filenames, or
180         a '-' to indicate server mode, we don't need to start
181         up the test machinery. Doing so might actually crash,
182         as we'll exit the application immedeatly after anyways.
183
184         Reviewed by Simon Hausmann.
185
186         * WebKitTestRunner/TestController.cpp:
187         (WTR::TestController::initialize):
188
189 2011-09-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
190
191         [Qt] Don't use QFont before initializing QApplication
192
193         Could potentially result in crash.
194
195         Reviewed by Simon Hausmann.
196
197         * DumpRenderTree/qt/main.cpp:
198         (main):
199
200 2011-09-19  Adam Barth  <abarth@webkit.org>
201
202         Always enable ENABLE(EVENTSOURCE)
203         https://bugs.webkit.org/show_bug.cgi?id=68414
204
205         Reviewed by Eric Seidel.
206
207         * Scripts/build-webkit:
208
209 2011-09-19  David Levin  <levin@chromium.org>
210
211         Sheriffbot rollout should be more intuitive.
212         https://bugs.webkit.org/show_bug.cgi?id=68415
213
214         Reviewed by Adam Barth.
215
216         * Scripts/webkitpy/tool/bot/irc_command.py: Add support for revert and comma separated args.
217         * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Add parsing tests for comma separated args
218           and a few others cases.
219         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: Verify that revert works.
220
221 2011-09-19  David Levin  <levin@chromium.org>
222
223         check-webkit-style generates bogus warning for StructuredExceptionHandlerSupressor.h
224         https://bugs.webkit.org/show_bug.cgi?id=68391
225
226         Reviewed by Darin Adler.
227
228         * Scripts/webkitpy/style/checkers/cpp.py: Skip __asm lines when doing style checks on a line.
229         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added a test for this.
230
231 2011-09-19  Alexis Menard  <alexis.menard@openbossa.org>
232
233         Style checker should not check public Qt WK2 API for parameter_name.
234         https://bugs.webkit.org/show_bug.cgi?id=68359
235
236         Reviewed by Andreas Kling.
237
238         The public Qt WK2 APIs have different rules than WebKit for parameters of methods in h files.
239         Add an exception in the style checker to disable the check. Also added the test for it.
240
241         * Scripts/webkitpy/style/checker.py:
242         * Scripts/webkitpy/style/checker_unittest.py:
243
244 2011-09-19  Leandro Pereira  <leandro@profusion.mobi>
245
246         GTK DRT leaks memory while comparing history items
247         https://bugs.webkit.org/show_bug.cgi?id=68086
248
249         Reviewed by Martin Robinson.
250         
251         webkit_web_history_item_get_target() returns a g_strdup()'d string,
252         so memory must be freed before compareHistoryItems() returns.
253
254         * DumpRenderTree/gtk/DumpRenderTree.cpp:
255         (compareHistoryItems): Use GOwnPtr to manage memory automatically.
256
257 2011-09-19  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
258
259         Buildbot marks a nrwt bot red when tests are missing results
260         https://bugs.webkit.org/show_bug.cgi?id=64812
261
262         Reviewed by Ryosuke Niwa.
263
264         * Scripts/webkitpy/layout_tests/controllers/manager.py:
265         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
266
267 2011-09-19  Jessie Berlin  <jberlin@apple.com>
268
269         Sites that use history pushState or replaceState are recorded in history in Private Browsing
270         mode.
271         https://bugs.webkit.org/show_bug.cgi?id=68208
272
273         Reviewed by Brady Eidson.
274
275         Add a test that the WKContextDidNavigateWithNavigationDataCallback (which is invoked by
276         updateGlobalHistory) is not called in Private Browsing when the page does history.pushState.
277
278         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp: Added.
279         (TestWebKitAPI::didNavigateWithNavigationData):
280         This is a context history client callback, so it should not be called when in Private
281         Browsing. Add a call to FAIL().
282         (TestWebKitAPI::didSameDocumentNavigationForFrame):
283         This is a page load client callback that happens after the didNavigateWithNavigationData
284         callback. End the test.
285         (TestWebKitAPI::TEST):
286         Enable Private Browsing and load a page that uses history.pushState.
287
288         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
289         Add PrivateBrowsingPushStateNoHistoryCallback.cpp and push-state.html.
290         * TestWebKitAPI/Tests/WebKit2/push-state.html: Added.
291         Ditto.
292         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
293         Ditto.
294         * TestWebKitAPI/win/copy-resources.cmd:
295         Ditto.
296
297 2011-09-16  Elliot Poger  <epoger@google.com>
298
299         add non-CG Webkit-Mac builds to flakiness dashboard
300         https://bugs.webkit.org/show_bug.cgi?id=68265
301
302         Reviewed by Adam Barth.
303
304         As Chromium-on-Mac approaches the switchover from Core Graphics to
305         Skia, we need to add the Skia version to the flakiness dashboard.
306
307         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
308         * TestResultServer/static-dashboards/builders.js:
309         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
310
311 2011-09-16  Jochen Eisinger  <jochen@chromium.org>
312
313         Rename FrameLoaderClient::allowImages to FrameLoaderClient::allowImage and include the image URL as parameter
314         https://bugs.webkit.org/show_bug.cgi?id=68071
315
316         Reviewed by Adam Barth.
317
318         * DumpRenderTree/chromium/WebPermissions.cpp:
319         (WebPermissions::allowImage):
320         * DumpRenderTree/chromium/WebPermissions.h:
321
322 2011-09-16  Tom Zakrajsek  <tomz@codeaurora.org>
323
324         update-webkit-chromium should retry the gclient call if it fails once
325         https://bugs.webkit.org/show_bug.cgi?id=68252
326
327         Reviewed by Adam Barth.
328
329         * Scripts/update-webkit-chromium:
330
331 2011-09-16  Rob Buis  <rbuis@rim.com>
332
333         Add Eli's rim address and change the nick.
334
335         * Scripts/webkitpy/common/config/committers.py:
336
337 2011-09-16  Anders Carlsson  <andersca@apple.com>
338
339         Add back the WKHitTestResultRef parameter to mouseDidMoveOverElement in an ABI preserving way
340         https://bugs.webkit.org/show_bug.cgi?id=68269
341
342         Reviewed by Geoffrey Garen.
343
344         Update client function signatures.
345
346         * MiniBrowser/gtk/BrowserWindow.c:
347         (browserWindowUIClientInit):
348         * MiniBrowser/mac/BrowserWindowController.m:
349         (mouseDidMoveOverElement):
350         (-[BrowserWindowController awakeFromNib]):
351         * MiniBrowser/win/BrowserView.cpp:
352         (BrowserView::create):
353         * WebKitTestRunner/TestController.cpp:
354         (WTR::TestController::createOtherPage):
355         (WTR::TestController::initialize):
356
357 2011-09-16  Anders Carlsson  <andersca@apple.com>
358
359         Temporarily remove the WKHitTestResultRef parameter to avoid breaking the WK2 ABI/API
360         https://bugs.webkit.org/show_bug.cgi?id=68266
361
362         Reviewed by John Sullivan.
363
364         * MiniBrowser/mac/BrowserWindowController.m:
365         (mouseDidMoveOverElement):
366
367 2011-09-16  Vincent Scheib  <scheib@chromium.org>
368
369         Add Vincent Scheib to the committers list.
370
371         * Scripts/webkitpy/common/config/committers.py:
372
373 2011-09-16  Sheriff Bot  <webkit.review.bot@gmail.com>
374
375         Unreviewed, rolling out r95285.
376         http://trac.webkit.org/changeset/95285
377         https://bugs.webkit.org/show_bug.cgi?id=68247
378
379         It broke a webkitpy test (Requested by ossy on #webkit).
380
381         * Scripts/webkitpy/layout_tests/controllers/manager.py:
382
383 2011-09-16  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
384
385         Buildbot marks a nrwt bot red when tests are missing results
386         https://bugs.webkit.org/show_bug.cgi?id=64812
387
388         Reviewed by Dirk Pranke.
389
390         * Scripts/webkitpy/layout_tests/controllers/manager.py:
391
392 2011-09-16  Martin Robinson  <mrobinson@igalia.com>
393
394         [GTK] Disable WebKit2 by default in configure.ac, but enable it with build-webkit
395         https://bugs.webkit.org/show_bug.cgi?id=68178
396
397         Reviewed by Xan Lopez.
398
399         Add a work-around to enable WebKit2 when using build-webkit.
400
401         * Scripts/webkitdirs.pm:
402         (buildAutotoolsProject): 
403
404 2011-09-15  James Robinson  <jamesr@chromium.org>
405
406         Add Antoine Labour and Shawn Singh to the contributors-but-not-committers list.
407
408         * Scripts/webkitpy/common/config/committers.py:
409
410 2011-09-15  Tom Zakrajsek  <tomz@codeaurora.org>
411
412         UpdateChangeLogsWithReviewer should be able to determine reviewer of latest reviewed patch in a bug
413         https://bugs.webkit.org/show_bug.cgi?id=68003
414
415         Reviewed by Adam Barth.
416
417         * Scripts/webkitpy/tool/mocktool.py:
418         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
419         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
420
421 2011-09-15  Tom Zakrajsek  <tomz@codeaurora.org>
422
423         Python version check is confusing in test-webkitpy
424         https://bugs.webkit.org/show_bug.cgi?id=68004
425
426         Reviewed by Adam Barth.
427
428         * Scripts/test-webkitpy:
429
430 2011-09-15  Eric Seidel  <eric@webkit.org>
431
432         Reviewed by Adam Barth.
433
434         webkit-patch should be able to find users and add them to bugzilla groups
435         https://bugs.webkit.org/show_bug.cgi?id=63351
436
437         These are both very basic commands.  But it's now possible to find
438         all users matching a regexp, as well as add all users matching a regexp
439         to a set of groups.
440
441         bugzilla.py already knew how to find users (for validate-committer-lists)
442         but now it has the ability to modify the user records.
443
444         I split some of the logic out into a new EditUsersParser class
445         to try and reduce the amount of code in Bugzilla/BugzillaQueries.
446
447         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
448         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
449         * Scripts/webkitpy/tool/commands/__init__.py:
450         * Scripts/webkitpy/tool/commands/adduserstogroups.py: Added.
451         * Scripts/webkitpy/tool/commands/findusers.py: Added.
452
453 2011-09-15  Eric Seidel  <eric@webkit.org>
454
455         Remove ENABLE(SVG_AS_IMAGE) since all major ports have it on by default
456         https://bugs.webkit.org/show_bug.cgi?id=68182
457
458         Reviewed by Adam Barth.
459
460         * Scripts/build-webkit:
461         * waf/build/settings.py:
462
463 2011-09-15  Eric Seidel  <eric@webkit.org>
464
465         Unreviewed.  Make contributor email look-up case-insensitive.
466
467         validate-committer-list was incorrectly reporting that "chang.shu@nokia.com"
468         was missing from committers.py due to case sensitivity.
469
470         This also includes a test expectations update to committers_unittest.py
471         after my previous change.
472
473         * Scripts/webkitpy/common/config/committers.py:
474         * Scripts/webkitpy/common/config/committers_unittest.py:
475         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
476
477 2011-09-15  Eric Seidel  <eric@webkit.org>
478
479         Unreviewed.  Updated this based on webkit-patch suggest-nominations and validate-committer-list output.
480
481         Add a bunch of email aliases to committers.py for regular contributors
482         who are committing using other email addresses than they have listed in the file.
483
484         * Scripts/webkitpy/common/config/committers.py:
485
486 2011-09-15  Eric Seidel  <eric@webkit.org>
487
488         Remove ENABLE_SVG_ANIMATION as all major ports have it on by default
489         https://bugs.webkit.org/show_bug.cgi?id=68022
490
491         Reviewed by Ryosuke Niwa.
492
493         * Scripts/build-webkit:
494         * waf/build/settings.py:
495
496 2011-09-15  Anders Carlsson  <andersca@apple.com>
497
498         Fix Mac build by including config.h where needed.
499
500         * TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
501         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
502         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
503         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
504         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp:
505         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
506         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
507         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
508         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
509         * TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
510         * TestWebKitAPI/mac/JavaScriptTestMac.mm:
511         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
512         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
513         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m:
514         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
515         * TestWebKitAPI/mac/main.mm:
516
517 2011-09-15  Xianzhu Wang  <wangxianzhu@chromium.org>
518
519         Let TestWebKitAPI work for chromium
520         https://bugs.webkit.org/show_bug.cgi?id=67756
521
522         Reviewed by Sam Weinig.
523
524         * Scripts/build-api-tests:
525         * Scripts/run-api-tests:
526         (isSupportedPlatform):
527         (runTest):
528         (populateTests):
529         * Scripts/webkitdirs.pm:
530         (determineBaseProductDir):
531         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
532         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
533         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
534         * TestWebKitAPI/InjectedBundleController.cpp:
535         * TestWebKitAPI/InjectedBundleMain.cpp:
536         * TestWebKitAPI/JavaScriptTest.cpp:
537         * TestWebKitAPI/PlatformUtilities.cpp:
538         * TestWebKitAPI/TestWebKitAPI.gypi: Added.
539         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
540         * TestWebKitAPI/TestWebKitAPIPrefix.h: Removed.
541         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
542         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
543         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
544         * TestWebKitAPI/Tests/WTF/VectorReverse.cpp:
545         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
546         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
547         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
548         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
549         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
550         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
551         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
552         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
553         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
554         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
555         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
556         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
557         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
558         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
559         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
560         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
561         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
562         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
563         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
564         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
565         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp:
566         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
567         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
568         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
569         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
570         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp:
571         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
572         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
573         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
574         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
575         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
576         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
577         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
578         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
579         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
580         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
581         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
582         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
583         * TestWebKitAPI/TestsController.cpp:
584         * TestWebKitAPI/config.h: Copied from TestWebKitAPI/TestWebKitAPIPrefix.h.
585         * TestWebKitAPI/win/InjectedBundleControllerWin.cpp:
586         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
587         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
588         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
589         * TestWebKitAPI/win/main.cpp:
590
591 2011-09-15  Jochen Eisinger  <jochen@chromium.org>
592
593         [chromium] extract normalization of LayoutTests URLs to a method of TestShell
594         https://bugs.webkit.org/show_bug.cgi?id=68145
595
596         This will allow for other classes in DumpRenderTree to reuse this functionality
597
598         Reviewed by David Levin.
599
600         * DumpRenderTree/chromium/TestShell.cpp:
601         (normalizeLayoutTestURLInternal):
602         (dumpHistoryItem):
603         (TestShell::normalizeLayoutTestURL):
604         * DumpRenderTree/chromium/TestShell.h:
605
606 2011-09-14  Ada Chan  <adachan@apple.com>
607
608         Add test for WKBundleFrameCopyWebArchive().
609         https://bugs.webkit.org/show_bug.cgi?id=67857
610
611         Reviewed by Anders Carlsson.
612
613         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp: Added.
614         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Do some basic sanity checks to make sure
615         the returned data is a valid webarchive.
616         (TestWebKitAPI::setInjectedBundleClient):
617         (TestWebKitAPI::didFinishLoadForFrame):
618         (TestWebKitAPI::TEST): Load simple.html in a WebView.  Wait for it to finish loading, and then ask the
619         injected bundle for the webarchive and check the returned webarchive.
620         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp: Added.
621         (TestWebKitAPI::WebArchiveTest::WebArchiveTest):
622         (TestWebKitAPI::WebArchiveTest::didReceiveMessage): Handle the "GetWebArchive" message and return
623         the web archive.
624
625         Add files to project.
626         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Also let Visual Studio reorder a file.
627         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
628         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
629
630 2011-09-14  Ryosuke Niwa  <rniwa@webkit.org>
631
632         committers.py should support multiple IRC nicknames
633         https://bugs.webkit.org/show_bug.cgi?id=68110
634
635         Reviewed by Eric Seidel.
636
637         Add multiple IRC nickname support to committers.py
638
639         * Scripts/webkitpy/common/config/committers.py:
640         * Scripts/webkitpy/common/config/committers_unittest.py:
641         * Scripts/webkitpy/tool/bot/irc_command.py:
642         * Scripts/webkitpy/tool/bot/sheriff.py:
643
644 2011-09-14  Jon Lee  <jonlee@apple.com>
645
646         Implement globalFlag for WebKitTestRunner
647         https://bugs.webkit.org/show_bug.cgi?id=68033
648         <rdar://problem/10119204>
649
650         Reviewed by Sam Weinig.
651
652         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Porting globalFlag from DRT
653         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
654         (WTR::LayoutTestController::LayoutTestController): initialize m_globalFlag to false
655         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: add m_globalFlag
656         (WTR::LayoutTestController::globalFlag): simple getter
657         (WTR::LayoutTestController::setGlobalFlag): simple setter
658
659 2011-09-13  Eric Seidel  <eric@webkit.org>
660
661         Remove ENABLE_SVG_USE as <use> is required by HTML5
662         https://bugs.webkit.org/show_bug.cgi?id=68019
663
664         Reviewed by Ryosuke Niwa.
665
666         * Scripts/build-webkit:
667         * waf/build/settings.py:
668
669 2011-09-14  Ryosuke Niwa  <rniwa@webkit.org>
670
671         Remove Jan Erik Hanssen (added in my r95078) from the list for now
672         since I can't confirm acceptable his committership.
673
674         * Scripts/webkitpy/common/config/committers.py:
675
676 2011-09-14  Jochen Eisinger  <jochen@chromium.org>
677
678         [chromium] Remove obsolete WebViewClient methods from DumpRenderTree.
679         https://bugs.webkit.org/show_bug.cgi?id=68066
680
681         Reviewed by Adam Barth.
682
683         * DumpRenderTree/chromium/WebViewHost.cpp:
684         * DumpRenderTree/chromium/WebViewHost.h:
685
686 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
687
688         committers.py is missing some contributors
689         https://bugs.webkit.org/show_bug.cgi?id=68059
690
691         Reviewed by Adam Barth.
692
693         Add David Barr, Jan Erik Hanssen, and Kim Grönholm.
694
695         Also add nicks of Alejandro G. Castro, Collin Jackson, and Matt Lilek.
696
697         * Scripts/webkitpy/common/config/committers.py:
698
699 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
700
701         Fix webkit python test after r95061.
702
703         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
704
705 2011-09-13  Xianzhu Wang  <wangxianzhu@chromium.org>
706
707         Add myself as a contributor. No review needed.
708
709         * Scripts/webkitpy/common/config/committers.py:
710
711 2011-09-13  Adam Barth  <abarth@webkit.org>
712
713         garden-o-matic has unfriendly error messages when the local server is not available
714         https://bugs.webkit.org/show_bug.cgi?id=68042
715
716         Reviewed by Dimitri Glazkov.
717
718         This patch moves us from using alert to showing the error inline in the
719         progress dialog.
720
721         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
722         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
723         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
724         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
725         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
726
727 2011-09-13  Adam Barth  <abarth@webkit.org>
728
729         FailureGrid in garden-o-matic should link to the builder's waterfall page
730         https://bugs.webkit.org/show_bug.cgi?id=68036
731
732         Reviewed by Dimitri Glazkov.
733
734         One of the users in the user study thought the configurations names in
735         the failure grid would link to the underlying bots.  That makes sense,
736         so this patch adds the behavior.
737
738         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
739         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
740         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
741         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
742
743 2011-09-13  Adam Barth  <abarth@webkit.org>
744
745         garden-o-matic should be able to mark failures as expected
746         https://bugs.webkit.org/show_bug.cgi?id=68027
747
748         Reviewed by Dimitri Glazkov.
749
750         All the back-end infrastructure exists for this operation.  This patch
751         just adds some UI to the front-end and wires that UI up to the back
752         end.  This exact UI will likely need some more polish, but this should
753         be a reasonable first cut.
754
755         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
756         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
757         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
758         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
759         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
760
761 2011-09-13  Adam Barth  <abarth@webkit.org>
762
763         garden-o-matic should tell you about the progress of your rebaseline
764         https://bugs.webkit.org/show_bug.cgi?id=67967
765
766         Reviewed by Dimitri Glazkov.
767
768         This patch adds ui.MessageBox, which is a light wrapper around jQuery
769         UI's dialog widget.  We then use ui.MessageBox to show status messages
770         about in-progress rebaselines.  As each baseline is downloaded, the
771         MessageBox updates.  This UI replaces our temporary "alert"-based UI.
772
773         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
774         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
775         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
776         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
777         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
778         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
779
780 2011-09-13  Leandro Pereira  <leandro@profusion.mobi>
781
782         GTK DumpRenderTree uses inefficient idioms to iterate over G[S]Lists
783         https://bugs.webkit.org/show_bug.cgi?id=68024
784
785         Reviewed by Gustavo Noronha Silva.
786         
787         Using g_list_count() and g_list_nth_data() together on a loop is
788         inneficient since they're both O(n). Iterate over lists in a saner
789         way.
790
791         * DumpRenderTree/gtk/DumpRenderTree.cpp:
792         (dumpHistoryItem): Reduce the scope for the 'kids' variable, and
793         iterate on it using g_list_next(). Free the list after done with it.
794         (dumpBackForwardListForWebView): Instead of appending (which is
795         expensive in GLists) history items and then iterating from the tail
796         of the itemsToPrint list, prepend items and walk forwards as usual.
797         (dumpBackForwardListForAllWebViews): Walk the list in a saner way,
798         remove the (unneeded) viewList variable.
799
800 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
801
802         Add Eric's IRC nick.
803
804         * Scripts/webkitpy/common/config/committers.py:
805
806 2011-09-13  Anders Carlsson  <andersca@apple.com>
807
808         Disable C++ exceptions when building with clang
809         https://bugs.webkit.org/show_bug.cgi?id=68031
810         <rdar://problem/9556880>
811
812         Reviewed by Mark Rowe.
813
814         * MiniBrowser/Configurations/Base.xcconfig:
815         * TestWebKitAPI/Configurations/Base.xcconfig:
816         * WebKitTestRunner/Configurations/Base.xcconfig:
817
818 2011-09-13  Ojan Vafai  <ojan@chromium.org>
819
820         [chromium] fix flakiness dashboard for chromium interactive tests
821         https://bugs.webkit.org/show_bug.cgi?id=68029
822
823         Reviewed by Tony Chang.
824
825         * TestResultServer/static-dashboards/flakiness_dashboard.html:
826         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
827
828 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
829
830         Add Alice and Aryeh to the list of contributors.
831
832         * Scripts/webkitpy/common/config/committers.py:
833
834 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
835
836         sheriffbot whois should also tell us email addresses
837         https://bugs.webkit.org/show_bug.cgi?id=67975
838
839         Reviewed by Eric Seidel and David Levin.
840
841         Taught sheriffbot how to tell us contributor's email addresses.
842
843         * Scripts/webkitpy/tool/bot/irc_command.py:
844         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
845
846 2011-09-13  Eric Seidel  <eric@webkit.org>
847
848         Remove ENABLE_SVG_FOREIGN_OBJECT as it is a required part of HTML5
849         https://bugs.webkit.org/show_bug.cgi?id=68018
850
851         Reviewed by Ryosuke Niwa.
852
853         * Scripts/build-webkit:
854         * waf/build/settings.py:
855
856 2011-09-13  Chang Shu  <cshu@webkit.org>
857
858         [WK2] [Mac] Implement KeyDown function for WebKit2 EventSender.
859         https://bugs.webkit.org/show_bug.cgi?id=57515
860
861         The code change in WebKitTestRunner first sends keydown event from InjectedBundle to
862         TestController synchronously. The latter then sends simulated event to WebKit2 module,
863         which is synchronous, too.
864
865         Reviewed by Darin Adler.
866
867         * WebKitTestRunner/EventSenderProxy.h: Added.
868         (WTR::EventSenderProxy::EventSenderProxy):
869         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
870         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
871         (WTR::EventSendingController::keyDown):
872         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
873         * WebKitTestRunner/PlatformWebView.h:
874         (WTR::PlatformWebView::platformWindow):
875         * WebKitTestRunner/TestController.cpp:
876         (WTR::TestController::TestController):
877         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
878         * WebKitTestRunner/TestController.h:
879         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
880         * WebKitTestRunner/mac/EventSenderProxy.mm: Added.
881         (WTR::buildModifierFlags):
882         (WTR::EventSenderProxy::keyDown):
883
884 2011-09-12  Leandro Pereira  <leandro@profusion.mobi>
885
886         [EFL] DRT: Add DumpRenderTreeEfl.h
887         https://bugs.webkit.org/show_bug.cgi?id=63993
888
889         Reviewed by Eric Seidel.
890         
891         This header contains some global variables used by EFL's
892         DumpRenderTree implementation.
893
894         * DumpRenderTree/DumpRenderTree.h: Include DumpRenderTreeEfl.h when
895         appropriate.
896         * DumpRenderTree/efl/DumpRenderTreeEfl.h: Added.
897
898 2011-09-12  Raphael Kubo da Costa  <kubo@profusion.mobi>
899
900         [EFL] Send the right key names for PageUp and PageDown.
901         https://bugs.webkit.org/show_bug.cgi?id=67044
902
903         Reviewed by Kenneth Rohde Christiansen.
904
905         PlatformKeyboardEventEfl uses "Prior" and "Next" to refer to PageUp and
906         PageDown (which is close to the defines in WindowsKeyboardCodes.h).
907         However, EventSender was sending "Page_Up" and "Page_Down", so tests
908         such as editing/input/page-up-down-scrolls.html were timing out due to
909         the right key down events not being sent.
910
911         * DumpRenderTree/efl/EventSender.cpp:
912         (keyPadNameFromJSValue):
913         (keyNameFromJSValue):
914
915 2011-09-12  Eric Seidel  <eric@webkit.org>
916
917         sheriffbot whois is case sensitive
918         https://bugs.webkit.org/show_bug.cgi?id=67972
919
920         Reviewed by Adam Barth.
921
922         I also fixed a typo in the "More than 5 contributors" message
923         from my previous commit.
924
925         * Scripts/webkitpy/common/config/committers.py:
926         * Scripts/webkitpy/common/config/committers_unittest.py:
927         * Scripts/webkitpy/tool/bot/irc_command.py:
928         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
929
930 2011-09-12  Eric Seidel  <eric@webkit.org>
931
932         sheriffbot whois should be smarter
933         https://bugs.webkit.org/show_bug.cgi?id=67971
934
935         Reviewed by Adam Barth.
936
937         This makes sheriffbot whois basically grep the committers list
938         making it much easier to find a contributor by name.
939
940         Unfortunately the current unittests depend on the real committers.py
941         file, so as we add more eric's to the project, this unittest result will
942         change.  I think that's OK for now.  We'll fix it when it breaks.
943
944         * Scripts/webkitpy/common/config/committers.py:
945         * Scripts/webkitpy/tool/bot/irc_command.py:
946         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
947
948 2011-09-12  Sheriff Bot  <webkit.review.bot@gmail.com>
949
950         Unreviewed, rolling out r94976.
951         http://trac.webkit.org/changeset/94976
952         https://bugs.webkit.org/show_bug.cgi?id=67953
953
954         Broke a bunch of security/load& tests (Requested by rniwa on
955         #webkit).
956
957         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
958         (LayoutTestController::pathToLocalResource):
959
960 2011-09-12  Eric Seidel  <eric@webkit.org>
961
962         Rubber-stamped by Adam Barth.
963
964         Remove the "the tree is burning!" warning previously shown
965         when landing patches.  It was a dream.  But it's just noise now.
966
967         Some bots will require a restart to notice the removal of the option
968         so I've left the --ignore-builders option in for now.
969
970         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
971         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
972         * Scripts/webkitpy/tool/commands/download.py:
973         * Scripts/webkitpy/tool/commands/download_unittest.py:
974         * Scripts/webkitpy/tool/commands/queues_unittest.py:
975         * Scripts/webkitpy/tool/steps/__init__.py:
976         * Scripts/webkitpy/tool/steps/commit.py:
977         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py: Removed.
978         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
979
980 2011-09-12  Eric Seidel  <eric@webkit.org>
981
982         [NRWT] REGRESSION: Local loader tests are failing on machines that lost /tmp/LayoutTests symlink
983         https://bugs.webkit.org/show_bug.cgi?id=65781
984
985         Reviewed by Ryosuke Niwa.
986
987         Instead of making NRWT create the symlink, I just made DumpRenderTree smart enough
988         to resolve the passed in url relative to the absolute url for the test.
989
990         I believe this is a better approach than the on used in the Qt and Chromium DRT's
991         (which resolves the path relative to the built location of the DRT executable)
992         and we should move this new code into a shared location in a follow-up patch.
993
994         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
995         (LayoutTestController::pathToLocalResource):
996
997 2011-09-12  Eric Seidel  <eric@webkit.org>
998
999         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
1000         https://bugs.webkit.org/show_bug.cgi?id=67530
1001
1002         Reviewed by Adam Barth.
1003
1004         I believe I've fixed the bug in the original patch which prompted the rollout.
1005         The previous patch was using the wrong deadline for the initial read,
1006         subtracting time.time() twice from the deadline value.
1007
1008         * Scripts/webkitpy/layout_tests/port/webkit.py:
1009         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1010
1011 2011-09-12  Balazs Kelemen  <kbalazs@webkit.org>
1012
1013         [Qt][WK2] WebKitTestRunner does not produce crash logs
1014         https://bugs.webkit.org/show_bug.cgi?id=67714
1015
1016         Reviewed by Chang Shu.
1017
1018         Added a simple way of generating backtrace on crash
1019         to the web process. The implementation is similar what
1020         we have in DRT. It depends on GNU libc functionality
1021         so it is only enabled where we are running in such an environment.
1022
1023         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
1024         (WTR::printBacktrace):
1025         (WTR::crashHandler):
1026         (WTR::InjectedBundle::platformInitialize):
1027
1028 2011-09-11  Filip Pizlo  <fpizlo@apple.com>
1029
1030         Added my IRC nick to the committers file.
1031
1032         * Scripts/webkitpy/common/config/committers.py:
1033
1034 2011-09-01  Filip Pizlo  <fpizlo@apple.com>
1035
1036         The executable allocator makes it difficult to free individual
1037         chunks of executable memory
1038         https://bugs.webkit.org/show_bug.cgi?id=66363
1039
1040         Reviewed by Oliver Hunt.
1041         
1042         Introduced a best-fit, balanced-tree based allocator. The allocator
1043         required a balanced tree that does not allocate memory and that
1044         permits the removal of individual nodes directly (as opposed to by
1045         key); neither AVLTree nor WebCore's PODRedBlackTree supported this.
1046         Changed all references to executable code to use a reference counted
1047         handle.
1048
1049         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1050         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp: Added.
1051         (TestWebKitAPI::TEST_F):
1052         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp: Added.
1053         (TestWebKitAPI::Pair::findExact):
1054         (TestWebKitAPI::Pair::remove):
1055         (TestWebKitAPI::Pair::findLeastGreaterThanOrEqual):
1056         (TestWebKitAPI::Pair::assertFoundAndRemove):
1057         (TestWebKitAPI::Pair::assertEqual):
1058         (TestWebKitAPI::Pair::assertSameValuesForKey):
1059         (TestWebKitAPI::Pair::testDriver):
1060         (TestWebKitAPI::TEST_F):
1061
1062 2011-09-10  Andy Estes  <aestes@apple.com>
1063
1064         Move myself from committers_unable_to_review to reviewers_list.
1065
1066         * Scripts/webkitpy/common/config/committers.py:
1067
1068 2011-09-10  Kevin Ollivier  <kevino@theolliviers.com>
1069
1070         [wx] Unreviewed build fix. MSW build fixes.
1071
1072         * DumpRenderTree/config.h:
1073         * waf/build/wxpresets.py:
1074
1075 2011-09-10  Andreas Kling  <kling@webkit.org>
1076
1077         Crash beneath WKURLIsEqual() when reloading in MiniBrowser.
1078         https://bugs.webkit.org/show_bug.cgi?id=59328
1079
1080         Reviewed by Kenneth Rohde Christiansen.
1081
1082         * MiniBrowser/mac/BrowserWindowController.m:
1083         (-[BrowserWindowController updateProvisionalURLForFrame:]): Add missing null check.
1084
1085 2011-09-10  Adam Barth  <abarth@webkit.org>
1086
1087         Build fix for Android.  DumpRenderTree is a client of the WebKit API
1088         and does not have access to notImplemented().
1089
1090         * DumpRenderTree/chromium/TestShellAndroid.cpp:
1091         (openStartupDialog):
1092
1093 2011-09-09  Alexey Proskuryakov  <ap@apple.com>
1094
1095         Add a script to create a monolithic script-test
1096         https://bugs.webkit.org/show_bug.cgi?id=67747
1097
1098         Reviewed by Darin Adler.
1099
1100         * Scripts/make-new-script-test: Added.
1101
1102 2011-09-09  Luiz Agostini  <luiz@webkit.org>
1103
1104         Adding myself to the reviewers list.
1105
1106         * Scripts/webkitpy/common/config/committers.py:
1107
1108 2011-09-09  Ryosuke Niwa  <rniwa@webkit.org>
1109
1110         Buildbot may use RunWebKitTest's evaluateCommand on bots that run nrwt
1111         https://bugs.webkit.org/show_bug.cgi?id=67855
1112
1113         Reviewed by Dirk Pranke.
1114
1115         The bug was caused by the fact some ports use RunWebKitTests instead of NewRunWebKitTests to run tests,
1116         and using RunWebKitTests.evaluateCommand after calling _parseNewRunWebKitTestsOutput.
1117
1118         Fixed the bug by merging evaluateCommand of RunWebKitTests and NewRunWebKitTests.
1119
1120         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1121
1122 2011-09-09  Mark Hahnenberg  <mhahnenberg@apple.com>
1123
1124         Add myself to committers.py
1125         https://bugs.webkit.org/show_bug.cgi?id=67853
1126
1127         Reviewed by Darin Adler.
1128
1129         * Scripts/webkitpy/common/config/committers.py:
1130
1131 2011-09-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1132
1133         [Qt] Remove common.pri
1134         https://bugs.webkit.org/show_bug.cgi?id=67814
1135
1136         Reviewed by Andreas Kling.
1137
1138         * Tools.pro:
1139
1140 2011-09-09  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1141
1142         [NRWT] the nrwt check httpd with --no-http option
1143         https://bugs.webkit.org/show_bug.cgi?id=67835
1144
1145         Reviewed by Tony Chang.
1146
1147         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1148         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1149
1150 2011-09-09  Hao Zheng  <zhenghao@chromium.org>
1151
1152         [chromium] Implement DRT support for Android.
1153         https://bugs.webkit.org/show_bug.cgi?id=67590
1154
1155         Reviewed by Tony Chang.
1156
1157         Add 2 mechanism to make DRT interaction more robust on Android:
1158         - Send 'QUIT' to DRT to make it stop.
1159         - Wait until receiving '#READY' from DRT, so that DRT won't miss any
1160         input commands before it starts.
1161         And LayoutTestController.cpp needs to include <cctype> for 'tolower'
1162         and <clocale> for 'LC_ALL' to compile on Android.
1163
1164         Also change to use sigaction instead of signal for TestShellGtk.cpp,
1165         as signal() man page recommends using sigaction().
1166
1167         * DumpRenderTree/DumpRenderTree.gypi:
1168         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1169         (main):
1170         * DumpRenderTree/chromium/LayoutTestController.cpp:
1171         * DumpRenderTree/chromium/TestShellAndroid.cpp: Added.
1172         (AlarmHandler):
1173         (TestShell::waitTestFinished):
1174         (platformInit):
1175         (openStartupDialog):
1176         (checkLayoutTestSystemDependencies):
1177         * DumpRenderTree/chromium/TestShellGtk.cpp:
1178         (AlarmHandler):
1179         (TestShell::waitTestFinished):
1180
1181 2011-09-09  Kevin Ollivier  <kevino@theolliviers.com>
1182
1183         [wx] Unreviewed build fix. Add Source/JavaScriptCore/dfg directory to the build.
1184
1185         * waf/build/settings.py:
1186
1187 2011-09-09  Sheriff Bot  <webkit.review.bot@gmail.com>
1188
1189         Unreviewed, rolling out r94851.
1190         http://trac.webkit.org/changeset/94851
1191         https://bugs.webkit.org/show_bug.cgi?id=67847
1192
1193         It broke a webkitpy test (Requested by ossy on #webkit).
1194
1195         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1196
1197 2011-09-09  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1198
1199         [NRWT] the nrwt check httpd with --no-http option
1200         https://bugs.webkit.org/show_bug.cgi?id=67835
1201
1202         Reviewed by Csaba Osztrogonác.
1203
1204         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1205
1206 2011-09-08  Brian Weinstein  <bweinstein@apple.com>
1207
1208         WebKit2: Assertion when calling didPerform*Redirect on null source/destination URL string
1209         https://bugs.webkit.org/show_bug.cgi?id=67794
1210         <rdar://problem/9892024>
1211         
1212         Add a test that we don't send a didPerformServerRedirect when a load is cancelled from willSendRequest.
1213
1214         Reviewed by Brady Eidson.
1215
1216         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp: Added.
1217         (TestWebKitAPI::didFinishLoadForFrame): Set flags on whether we've loaded the main frame, iframe, or both.
1218         (TestWebKitAPI::didPerformServerRedirect): Set a flag for whether we've performed a server redirect.
1219         (TestWebKitAPI::TEST): Set up a WKPageLoaderClient and WKContextHistoryClient, and load simple-iframe.html.
1220             Once both frames have loaded (main frame and blocked iframe), make sure that we have never called
1221             didPerformServerRedirect.
1222
1223         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp: Added.
1224         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::LoadCanceledNoServerRedirectCallbackTest): Initialize
1225             our InjectedBundleTest.
1226         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::willSendRequestForFrame): If we are dealing with a request
1227             from the main frame (the main resource in simple-iframe.html), allow it. If not (dealing with the iframe), block
1228             the request.
1229         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::didCreatePage): Set up the WKBundlePageResourceLoadClient.
1230
1231         * TestWebKitAPI/Tests/WebKit2/simple-iframe.html: Added.
1232         
1233         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
1234         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto.
1235         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: Ditto.
1236         * TestWebKitAPI/win/copy-resources.cmd: Ditto.
1237
1238 2011-09-08  David Levin  <levin@chromium.org>
1239
1240         check-webkit-style: Ref|Own Ptr& should be allowed as a parameter.
1241         https://bugs.webkit.org/show_bug.cgi?id=67797
1242
1243         Reviewed by Eric Seidel.
1244
1245         * Scripts/webkitpy/style/checkers/cpp.py: Allow Ref/Own Ptr when it ends with &.
1246         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added test cases for this.
1247
1248 2011-09-08  Fady Samuel  <fsamuel@chromium.org>
1249
1250         Fixed Layout Mode should be adjustable from layoutTestController for testing on Chromium platforms
1251         https://bugs.webkit.org/show_bug.cgi?id=67723
1252
1253         Reviewed by Adam Barth.
1254
1255         * DumpRenderTree/chromium/EventSender.h:
1256         * DumpRenderTree/chromium/LayoutTestController.cpp:
1257         (LayoutTestController::LayoutTestController):
1258         (LayoutTestController::enableFixedLayoutMode):
1259         (LayoutTestController::setFixedLayoutSize):
1260         * DumpRenderTree/chromium/LayoutTestController.h:
1261
1262 2011-09-07  Matthew Delaney  <mdelaney@apple.com>
1263
1264         Add standalone script that filters the output of build-webkit to be more human-readable
1265         https://bugs.webkit.org/show_bug.cgi?id=44081
1266
1267         Reviewed by Daniel Bates.
1268
1269         * Scripts/filter-build-webkit: Added. Just need to feed it the output of
1270         a build script (e.g. build-webkit) and it spits out a prettier version.
1271         * Scripts/VCSUtils.pm: Refactored "possiblyColored" out of run-api-tests into VCSUtils.
1272         * Scripts/run-api-tests: Now includes VCSUtils to use "possiblyColored"
1273
1274 2011-09-07  Noel Gordon  <noel.gordon@gmail.com>
1275
1276         Add myself to committers.py                 
1277         https://bugs.webkit.org/show_bug.cgi?id=67696
1278
1279         Reviewed by Kent Tamura.
1280
1281         * Scripts/webkitpy/common/config/committers.py:
1282
1283 2011-09-07  Adam Barth  <abarth@webkit.org>
1284
1285         rebaseline button in garden-o-matic details view should work
1286         https://bugs.webkit.org/show_bug.cgi?id=67738
1287
1288         Reviewed by Dimitri Glazkov.
1289
1290         This patch wires up the rebaseline button in garden-o-matic results
1291         details view.  The button is current per-test, so there isn't a way to
1292         rebaseline individual bots.  This is a place to start.  If we decide we
1293         want per-bot rebaselining, we'll need to think of some better UI.
1294
1295         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1296         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
1297         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1298         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
1299
1300 2011-09-07  Eric Seidel  <eric@webkit.org>
1301
1302         Teach the PortFactory object how to pass along executive/user/filesystem to port objects (which fixes the failing rebaseline_test on bots)
1303         https://bugs.webkit.org/show_bug.cgi?id=67737
1304
1305         Reviewed by Adam Barth.
1306
1307         I got a little over-eager when deprecating host.port_factory in the previous commit.
1308         Turns out that Host.port_factory was already the "modern" port/factory.py
1309         it was just the Module object.  I un-deprecated the variable, and changed it from
1310         being the module to being an actual PortFactory, passing it a host object.
1311         I also taught PortFactory how to set user/executive/filesystem in the kwargs
1312         when instantiating a new Port object.
1313         This magically fixed the test_rebaseline test, since its now no longer talking
1314         to the real filesystem.
1315
1316         * Scripts/webkitpy/common/host.py:
1317         * Scripts/webkitpy/layout_tests/port/factory.py:
1318         * Scripts/webkitpy/tool/commands/queries.py:
1319         * Scripts/webkitpy/tool/mocktool.py:
1320
1321 2011-09-07  Eric Seidel  <eric@webkit.org>
1322
1323         Add a new PortFactory class for creating new-style ports and deprecate the old PortFactory
1324         https://bugs.webkit.org/show_bug.cgi?id=67734
1325
1326         Reviewed by Adam Barth.
1327
1328         Right now every place that creates a Port object has to be very careful
1329         to pass in a MockSCM/MockUser/MockFilesystem when appropriate.
1330         The correct fix is for port/factory.py (which creates most port objects)
1331         to know how to pass these in automatically.  However, currently all port/factory.py
1332         functions are free functions instead of being on an object.  This patch
1333         adds a new PortFactory object and deprecates the PortFactory for the old-style Port objects.
1334
1335         In a follow-up patch I will add PortFactory to the Host object and teach PortFactory how to
1336         pass along the proper scm/user/filesystem to the Port object.
1337
1338         * Scripts/webkitpy/common/host.py:
1339         * Scripts/webkitpy/layout_tests/port/factory.py:
1340         * Scripts/webkitpy/tool/commands/queries.py:
1341         * Scripts/webkitpy/tool/mocktool.py:
1342
1343 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
1344
1345         Unreviewed, rolling out r94441.
1346         http://trac.webkit.org/changeset/94441
1347         https://bugs.webkit.org/show_bug.cgi?id=67731
1348
1349         "MacEWSes are backed up due to new machines not able to reach
1350         git.webkit.org.  Disabling tests for now" (Requested by
1351         eseidel2 on #webkit).
1352
1353         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1354
1355 2011-09-07  Elliot Poger  <epoger@google.com>
1356
1357         filter test_expectations properly for chromium-mac vs chromium-cg-mac
1358         https://bugs.webkit.org/show_bug.cgi?id=67324
1359
1360         Reviewed by Dirk Pranke.
1361
1362         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1363         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1364         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1365         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1366         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1367
1368 2011-09-07  Eric Boren  <borenet@gmail.com>
1369
1370         [Chromium] Modify WebTouchEvent structure to match WebCore::TouchEvent
1371         https://bugs.webkit.org/show_bug.cgi?id=66800
1372
1373         Reviewed by Darin Fisher.
1374
1375         * DumpRenderTree/chromium/EventSender.cpp:
1376         (EventSender::sendCurrentTouchEvent):
1377
1378 2011-09-07  Jarred Nicholls  <jarred@sencha.com>
1379
1380         [Qt][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
1381         https://bugs.webkit.org/show_bug.cgi?id=67254
1382
1383         Reviewed by Csaba Osztrogonác.
1384
1385         Translate file:///tmp/LayoutTests/* urls into the repository LayoutTests directory, which is
1386         derived from the running location of DumpRenderTree binary.
1387
1388         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1389         (LayoutTestController::pathToLocalResource):
1390         (LayoutTestController::setUserStyleSheetLocation): pass the url through pathToLocalResource
1391
1392 2011-09-07  Csaba Osztrogonác  <ossy@webkit.org>
1393
1394         REGRESSION(r94288) build-webkit doesn't work on Symbian
1395         https://bugs.webkit.org/show_bug.cgi?id=67706
1396
1397         * Scripts/webkitdirs.pm: Disable automatic clean build on Symbian, because it doesn't support shadow build.
1398         (buildQMakeProject):
1399
1400 2011-09-07  Csaba Osztrogonác  <ossy@webkit.org>
1401
1402         REGRESSION(r94288) build-webkit doesn't work on Windows
1403         https://bugs.webkit.org/show_bug.cgi?id=67646
1404
1405         Roll back r94655 with a small fix.
1406
1407         * Scripts/webkitdirs.pm:
1408         (buildQMakeProject):
1409
1410 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
1411
1412         Unreviewed, rolling out r94635.
1413         http://trac.webkit.org/changeset/94635
1414         https://bugs.webkit.org/show_bug.cgi?id=67704
1415
1416         Linux Touch build is failing to compile this change.
1417         (Requested by loislo on #webkit).
1418
1419         * DumpRenderTree/chromium/EventSender.cpp:
1420         (EventSender::sendCurrentTouchEvent):
1421
1422 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
1423
1424         Unreviewed, rolling out r94655.
1425         http://trac.webkit.org/changeset/94655
1426         https://bugs.webkit.org/show_bug.cgi?id=67703
1427
1428         It broke Leopard debug bot (Requested by ossy on #webkit).
1429
1430         * Scripts/webkitdirs.pm:
1431
1432 2011-09-07  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1433
1434         REGRESSION(r94288) build-webkit doesn't work on Windows
1435         https://bugs.webkit.org/show_bug.cgi?id=67646
1436
1437         Reviewed by Csaba Osztrogonác.
1438
1439         * Scripts/webkitdirs.pm:
1440
1441 2011-09-06  Eric Boren  <borenet@gmail.com>
1442
1443         [Chromium] Modify WebTouchEvent structure to match WebCore::TouchEvent
1444         https://bugs.webkit.org/show_bug.cgi?id=66800
1445
1446         Reviewed by Darin Fisher.
1447
1448         * DumpRenderTree/chromium/EventSender.cpp:
1449         (EventSender::sendCurrentTouchEvent):
1450
1451 2011-09-06  Adam Barth  <abarth@webkit.org>
1452
1453         garden-o-matic details view should having working rebaseline and next/previous buttons
1454         https://bugs.webkit.org/show_bug.cgi?id=67659
1455
1456         Reviewed by Dimitri Glazkov.
1457
1458         This patch wires up basic back/forward buttons that let you traverse
1459         through the results we're examining in the details view.  This ended up
1460         being more code than I expected, but I wanted to keep all the state
1461         information in the DOM itself.
1462
1463         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1464         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
1465         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
1466
1467 2011-09-01  Dirk Pranke  <dpranke@chromium.org>
1468
1469         fix MockFileSystem.glob(), refactor filesystem tests
1470         https://bugs.webkit.org/show_bug.cgi?id=67462
1471
1472         Reviewed by Eric Seidel.
1473
1474         In debugging why my proposed change for MockFileSystem.glob()
1475         in bug 66228 didn't work, I stumbled across two real bugs
1476         that cancelled each other out for the unit tests. I fixed those
1477         (glob shouldn't recurse into subdirs, and we weren't populating
1478         self.dirs from self.files properly).
1479
1480         I have also created a "mixin" class for tests that can be shared
1481         between the real filesystem and the mock filesystem - MockFileSystem
1482         is being used enough it needs its own tests.
1483
1484         * Scripts/webkitpy/common/system/filesystem_mock.py:
1485         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py: Added.
1486         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1487
1488 2011-09-06  Anders Carlsson  <andersca@apple.com>
1489
1490         Move NPAPI headers in bridge to plugins
1491         https://bugs.webkit.org/show_bug.cgi?id=67661
1492
1493         Update forwarding headers.
1494
1495         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
1496         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
1497
1498 2011-09-06  Tony Chang  <tony@chromium.org>
1499
1500         [chromium] Check in 'build' for compiled binaries first
1501         https://bugs.webkit.org/show_bug.cgi?id=67549
1502
1503         Reviewed by Dirk Pranke.
1504
1505         I'm working on moving the windows build output to a common location
1506         rather than relative to the sln file.  Because of that, we need to
1507         check those build locations first for DumpRenderTree.exe.
1508
1509         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1510
1511 2011-09-06  Adam Barth  <abarth@webkit.org>
1512
1513         Use a hierarchial structure for the garden-o-matic results view
1514         https://bugs.webkit.org/show_bug.cgi?id=67620
1515
1516         Reviewed by Dimitri Glazkov.
1517
1518         This patch re-organizes the results view to use a hierachial structure
1519         for selection.  At the top-level are sections for each test.  Expanding
1520         the test section shows a tab selector for builders.
1521
1522         This structure prepares us for wiring up various actions to this view.
1523
1524         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1525         (.):
1526         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1527         ():
1528         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1529         (.):
1530         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
1531         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
1532         (.results-view>.toolbar):
1533         (.results-view>.toolbar ul.actions):
1534         (.results-view>.toolbar ul.actions li):
1535         (.results-grid table):
1536         (.results-grid table td, .results-view table th):
1537         (.results-grid table th):
1538         (.results-grid .text-result):
1539         (.results-grid .image-result):
1540
1541 2011-09-06  Adam Barth  <abarth@webkit.org>
1542
1543         garden-o-matic's base.probe generates spam in the JavaScript console
1544         https://bugs.webkit.org/show_bug.cgi?id=67622
1545
1546         Reviewed by Dimitri Glazkov.
1547
1548         Now that we have CORS set up on the buildbot, we can use XMLHttpRequest
1549         instead of HTMLScriptElement to test whether results exist.  This
1550         reduces the console.log spam and saves bandwidth because we can use a
1551         HEAD request instead of a GET request.
1552
1553         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
1554
1555 2011-09-05  Adam Barth  <abarth@webkit.org>
1556
1557         Add a tab to garden-o-matic for viewing expected failures
1558         https://bugs.webkit.org/show_bug.cgi?id=67619
1559
1560         Reviewed by Dimitri Glazkov.
1561
1562         This patch adds a basic tab to garden-o-matic that shows all the tests
1563         failing on the bots, including the expected failures.  This patch
1564         mostly involves refactoring existing classes to allow new subclasses.
1565
1566         This view is useful for when gardeners mark tests as expected to fail
1567         and then rebaseline them later.
1568
1569         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1570         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
1571         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
1572         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js:
1573         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1574         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1575         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1576
1577 2011-09-05  Adam Barth  <abarth@webkit.org>
1578
1579         Fix global variable leak in garden-o-matic
1580         https://bugs.webkit.org/show_bug.cgi?id=67617
1581
1582         Reviewed by Dimitri Glazkov.
1583
1584         Caught by running the unit tests with noglobals turned on.
1585
1586         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1587
1588 2011-09-05  Balazs Kelemen  <kbalazs@webkit.org>
1589
1590         [Qt][WK2] Add pixel test support
1591         https://bugs.webkit.org/show_bug.cgi?id=66283
1592
1593         Reviewed by Andreas Kling.
1594
1595         Implemented pixel result generation by reusing the logic
1596         that we have in DumpRenderTree.
1597         * WebKitTestRunner/qt/TestInvocationQt.cpp:
1598         (WTR::dumpImage):
1599         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1600
1601 2011-09-04  Robin Dunn  <robin@alldunn.com>
1602
1603         [wx] Enable wxWebKit to run using the wxGC Cairo backend on platforms other than GTK.
1604         https://bugs.webkit.org/show_bug.cgi?id=67577
1605
1606         Reviewed by Kevin Ollivier.
1607
1608         * waf/build/settings.py:
1609
1610 2011-09-03  Kevin Ollivier  <kevino@theolliviers.com>
1611
1612         [wx] Unreviewed build fix. Add wtf/dtoa directory to build.
1613
1614         * waf/build/settings.py:
1615
1616 2011-09-03  Dan Bernstein  <mitz@apple.com>
1617
1618         32-bit build fix.
1619
1620         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1621         (TestWebKitAPI::Util::toSTD):
1622
1623 2011-09-03  Dan Bernstein  <mitz@apple.com>
1624
1625         Move testStringByEvaluatingJavaScriptFromString() from DumpRenderTree to TestWebKitAPI
1626         https://bugs.webkit.org/show_bug.cgi?id=67559
1627
1628         Reviewed by Darin Adler.
1629
1630         * DumpRenderTree/mac/DumpRenderTree.mm:
1631         (dumpRenderTree): Moved testStringByEvaluatingJavaScriptFromString() from here and removed
1632         the call to it.
1633         * TestWebKitAPI/PlatformUtilities.h: Declared Util::toSTD(NSString *)
1634         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added StringByEvaluatingJavaScriptFromString.mm.
1635         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm: Added.
1636         (TestWebKitAPI::TEST): Added. Moved testStringByEvaluatingJavaScriptFromString() to here.
1637         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1638         (TestWebKitAPI::Util::toSTD): Added.
1639
1640 2011-09-03  Adam Barth  <abarth@webkit.org>
1641
1642         garden-o-matic results view should have a better results selector
1643         https://bugs.webkit.org/show_bug.cgi?id=67542
1644
1645         Reviewed by Dimitri Glazkov.
1646
1647         This patch adds a basic grid-based results selector to the results
1648         view.  Currently, this grid just shows how the tests fail on the
1649         various bots.  A future patch will let you select which failure to view
1650         and to mark the failures for rebaselining.
1651
1652         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1653         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
1654           - Add some more basic functions for manipulating dictionaries.
1655         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1656         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1657         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
1658
1659 2011-09-03  Adam Barth  <abarth@webkit.org>
1660
1661         garden-o-matic results view should show Actual and Expected results for text failures
1662         https://bugs.webkit.org/show_bug.cgi?id=67536
1663
1664         Reviewed by Eric Seidel.
1665
1666         In the past, we didn't show actual and expected text results (we just
1667         showed the diff) because we didn't have the awesome six-by-two results
1668         grid.  Now that we do, we can move show these results.
1669
1670         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1671         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
1672           - Fixed some typos that were preventing these unit tests from running.
1673         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1674         (.):
1675         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
1676           - Report -actual.txt and -expected.txt as possible results URLs.
1677
1678 2011-09-03  Adam Barth  <abarth@webkit.org>
1679
1680         garden-o-matic shows "ghost" failures that are already fixed
1681         https://bugs.webkit.org/show_bug.cgi?id=67535
1682
1683         Reviewed by Eric Seidel.
1684
1685         About 10% of writes fail to stick on test-results.appspot.com.  This
1686         patch causes us to fetch the full_results.json blob directly from
1687         build.chromium.org rather than relying upon AppEngine.
1688
1689         Unforuntately, we still need to get historical information from
1690         AppEngine.  That will take several patches to fix becuase I need to
1691         change the bots to write the full_results.json file to the
1692         build-specific directory in addition to the zip file.
1693
1694         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1695         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
1696         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1697
1698 2011-09-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1699
1700         Unreviewed, rolling out r94458.
1701         http://trac.webkit.org/changeset/94458
1702         https://bugs.webkit.org/show_bug.cgi?id=67558
1703
1704         Caused appcache test to fail on various bots (Requested by
1705         rniwa on #webkit).
1706
1707         * Scripts/webkitpy/layout_tests/port/webkit.py:
1708         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1709
1710 2011-09-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1711
1712         Unreviewed, rolling out r94453.
1713         http://trac.webkit.org/changeset/94453
1714         https://bugs.webkit.org/show_bug.cgi?id=67557
1715
1716         Caused appcache test to fail on various bots (Requested by
1717         rniwa on #webkit).
1718
1719         * Scripts/webkitpy/layout_tests/port/webkit.py:
1720
1721 2011-09-02  Michael Saboff  <msaboff@apple.com>
1722
1723         Add JSC:RegExp functional tests
1724         https://bugs.webkit.org/show_bug.cgi?id=67339
1725
1726         New perl script to build JavaScriptCore and run the RegExp tests.
1727
1728         Reviewed by Gavin Barraclough.
1729
1730         * Scripts/run-regexp-tests: Added.
1731
1732 2011-09-02  Michael Saboff  <msaboff@apple.com>
1733
1734         Add JSC:RegExp functional tests
1735         https://bugs.webkit.org/show_bug.cgi?id=67339
1736
1737         New perl script to build JavaScriptCore and run the RegExp tests.
1738
1739         Reviewed by Gavin Barraclough.
1740
1741         * Scripts/run-regexp-tests: Added.
1742
1743 2011-09-02  Eric Seidel  <eric@webkit.org>
1744
1745         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
1746         https://bugs.webkit.org/show_bug.cgi?id=67530
1747
1748         Unreviewed.  Fixing typo from previous commit.
1749
1750         Turns out there was *no* unittesting of WebKitDriver.  Added a basic test of _read_block
1751         which exercises the code I previously made a typo in.
1752
1753         * Scripts/webkitpy/layout_tests/port/webkit.py:
1754         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1755
1756 2011-09-02  Eric Seidel  <eric@webkit.org>
1757
1758         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
1759         https://bugs.webkit.org/show_bug.cgi?id=67530
1760
1761         Reviewed by Adam Barth.
1762
1763         No functional change, just reshuffling code.
1764
1765         * Scripts/webkitpy/layout_tests/port/webkit.py:
1766
1767 2011-09-02  Darin Adler  <darin@apple.com>
1768
1769         Added Subversion ignore for .pyc generated files.
1770
1771         * Scripts/webkitpy/layout_tests/models: Added property svn:ignore.
1772         * Scripts/webkitpy/layout_tests/servers: Added property svn:ignore.
1773         * Scripts/webkitpy/tool/servers: Added property svn:ignore.
1774
1775 2011-09-02  Adam Barth  <abarth@webkit.org>
1776
1777         Enable testing on mac-ews
1778         https://bugs.webkit.org/show_bug.cgi?id=67505
1779
1780         Reviewed by Eric Seidel.
1781
1782         This patch enables testing on the Mac EWS, which should help
1783         contributors not turn the Mac bots red.
1784
1785         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1786
1787 2011-09-01  Beth Dakin  <bdakin@apple.com>
1788
1789         https://bugs.webkit.org/show_bug.cgi?id=67451
1790         Add a test for going back to a cached page after changing the device scale factor
1791
1792         Reviewed by Adam Roben.
1793
1794         New test DeviceScaleFactorOnBack.mm inherits from WebKitAgnosticTest.
1795         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1796         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm: Added.
1797         (TestWebKitAPI::DeviceScaleFactorOnBack::url):
1798         (TestWebKitAPI::DeviceScaleFactorOnBack::didLoadURL):
1799         (TestWebKitAPI::DeviceScaleFactorOnBack::createWindow):
1800         (TestWebKitAPI::DeviceScaleFactorOnBack::initializeView):
1801         (TestWebKitAPI::DeviceScaleFactorOnBack::runTest):
1802         (TestWebKitAPI::TEST_F):
1803
1804         Added new function to WebKitAgnosticTest to goBack. Separated 
1805         waitForLoadToFinish() into its own function (instead of being a part of 
1806         loadAndWaitUntilFinished()) so that it can be called from goBack as 
1807         well. Also added initializeView() so we can set the cache model.
1808         * TestWebKitAPI/mac/WebKitAgnosticTest.h:
1809         (TestWebKitAPI::WebKitAgnosticTest::initializeView):
1810         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
1811         (TestWebKitAPI::WebKitAgnosticTest::WebKitAgnosticTest):
1812         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
1813         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
1814         (TestWebKitAPI::WebKitAgnosticTest::loadURL):
1815         (TestWebKitAPI::WebKitAgnosticTest::goBack):
1816         (TestWebKitAPI::WebKitAgnosticTest::waitForLoadToFinish):
1817
1818 2011-09-02  Anders Carlsson  <andersca@apple.com>
1819
1820         Build fix.
1821
1822         * DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp:
1823         (PrivateBrowsing::ScriptableObject::pluginTest):
1824
1825 2011-09-02  Anders Carlsson  <andersca@apple.com>
1826
1827         Move private browsing test to a PluginTest subclass
1828         https://bugs.webkit.org/show_bug.cgi?id=67498
1829
1830         Reviewed by Darin Adler.
1831
1832         * DumpRenderTree/DumpRenderTree.gypi:
1833         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1834         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1835         (pluginGetProperty):
1836         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
1837         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1838         (PluginTest::NPP_SetValue):
1839         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1840         * DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp: Added.
1841         (PrivateBrowsing::PrivateBrowsing):
1842         (PrivateBrowsing::privateBrowsingEnabled):
1843         (PrivateBrowsing::cachedPrivateBrowsingEnabled):
1844         (PrivateBrowsing::ScriptableObject::hasProperty):
1845         (PrivateBrowsing::ScriptableObject::getProperty):
1846         (PrivateBrowsing::ScriptableObject::pluginTest):
1847         (PrivateBrowsing::NPP_New):
1848         (PrivateBrowsing::NPP_GetValue):
1849         (PrivateBrowsing::NPP_SetValue):
1850         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1851         (NPP_New):
1852         (NPP_SetValue):
1853         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1854         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1855         * GNUmakefile.am:
1856
1857 2011-09-02  Csaba Osztrogonác  <ossy@webkit.org>
1858
1859         [Qt] Build dependency problems
1860         https://bugs.webkit.org/show_bug.cgi?id=38054
1861
1862         Trivial fix after r94288.
1863
1864         Rubber-stamped by Andras Becsi.
1865
1866         * Scripts/webkitdirs.pm: We should read the whole defaults.txt, not only the first two lines.
1867         (buildQMakeProject):
1868
1869 2011-09-02  Andras Becsi  <andras.becsi@nokia.com>
1870
1871         Remove my old e-mail address and add my new one.
1872
1873         Rubber-stamped by Tor Arne Vestbø.
1874
1875         * Scripts/webkitpy/common/config/committers.py:
1876
1877 2011-09-02  Philippe Normand  <pnormand@igalia.com>
1878
1879         [GTK] run-gtk-tests leaves a zombie Xvfb process
1880         https://bugs.webkit.org/show_bug.cgi?id=67389
1881
1882         Reviewed by Martin Robinson.
1883
1884         * Scripts/run-gtk-tests: Properly close STDIN and STDERR on the
1885         child process instead of doing shell redirection.
1886
1887 2011-09-01  Mark Rowe  <mrowe@apple.com>
1888
1889         Fix the build by adding some more missing return types.
1890
1891         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1892         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1893
1894 2011-09-01  Eric Seidel  <eric@webkit.org>
1895
1896         REGRESSION (NRWT): Leaks Viewer can't load leaks from test runs that used NRWT
1897         https://bugs.webkit.org/show_bug.cgi?id=66228
1898
1899         Reviewed by Dirk Pranke.
1900
1901         ORWT used $(PROCESS)$(NUMBER)-leaks.txt for leaks filenames.
1902         The LeaksViewer tool globs for all *-leaks.txt files.
1903         This patch makes NRWT output $(PROCESS)-$(PID)-leaks.txt which should match.
1904
1905         In order to test this I had to fix a limitation in our MockFileSystem.glob
1906         method.  However, doing so uncovered a typo and bug in the integration tests.
1907         I've disabled the offending integration tests.
1908
1909         * Scripts/webkitpy/common/system/filesystem_mock.py:
1910         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
1911         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
1912
1913 2011-09-01  Dominic Mazzoni  <dmazzoni@google.com>
1914
1915         Adds a LayoutTestController method to make it possible to test
1916         starting speech input via an API call.
1917         https://bugs.webkit.org/show_bug.cgi?id=60170
1918
1919         Reviewed by Dimitri Glazkov.
1920
1921         * DumpRenderTree/LayoutTestController.h:
1922         * DumpRenderTree/chromium/LayoutTestController.cpp:
1923         (LayoutTestController::LayoutTestController):
1924         (LayoutTestController::startSpeechInput):
1925         * DumpRenderTree/chromium/LayoutTestController.h:
1926         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1927         (LayoutTestController::startSpeechInput):
1928         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1929         (LayoutTestController::startSpeechInput):
1930         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1931         (LayoutTestController::startSpeechInput):
1932         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1933         (LayoutTestController::startSpeechInput):
1934         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1935         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1936         (LayoutTestController::startSpeechInput):
1937         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1938         (LayoutTestController::startSpeechInput):
1939
1940 2011-09-01  Tim Horton  <hortont424@gmail.com>
1941
1942         Fix TestWebKitAPI build on clang-2.0
1943
1944         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
1945
1946 2011-09-01  Adam Barth  <abarth@webkit.org>
1947
1948         Remove unused "extension" parameter from rebaseline gardeningserver handler
1949         https://bugs.webkit.org/show_bug.cgi?id=67384
1950
1951         Reviewed by James Robinson.
1952
1953         This parameter hasn't done anything in a while.
1954
1955         * Scripts/webkitpy/tool/commands/rebaseline.py:
1956         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1957         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1958
1959 2011-09-01  Eric Seidel  <eric@webkit.org>
1960
1961         Unreviewed.
1962
1963         Fix a typo in unittests.  Unfortunately fixing it
1964         caused several assertions.  Just disabling the test
1965         instead, since it was providing no value before due to the typo.
1966
1967         * Scripts/webkitpy/layout_tests/port/test.py:
1968
1969 2011-09-01  Adam Barth  <abarth@webkit.org>
1970
1971         Add a "rebaseline" button to the garden-o-matic summary page
1972         https://bugs.webkit.org/show_bug.cgi?id=67382
1973
1974         Reviewed by Dimitri Glazkov.
1975
1976         As much as we might wish folks to not rebaseline entire test groups at
1977         once, the truth is that doing so is a common operation.  Adding a
1978         button for this operation is likely to make folks happy.
1979
1980         This patch also cleans up a bunch of plumbing surrounding failureInfo
1981         objects.
1982
1983         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1984         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
1985         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
1986         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
1987         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1988         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
1989         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1990         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
1991         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1992         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1993
1994 2011-09-01  Adam Barth  <abarth@webkit.org>
1995
1996         garden-o-matic should let the gardener assign blame for a group of test failures
1997         https://bugs.webkit.org/show_bug.cgi?id=67379
1998
1999         Reviewed by Dimitri Glazkov.
2000
2001         If a group of test failures has a large revision range, the gardener
2002         might wish to blame a specific revision for the failure.  Currently,
2003         this only effect of assigning blame in this way is to hide the other
2004         suspect commits.
2005
2006         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2007         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
2008         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2009
2010 2011-09-01  Adam Barth  <abarth@webkit.org>
2011
2012         Hide garden-o-matic failure table until hover
2013         https://bugs.webkit.org/show_bug.cgi?id=67376
2014
2015         Reviewed by Dimitri Glazkov.
2016
2017         This patch removes the failure table for build failures (because it
2018         does not make sense) and hides the failure table for test groups until
2019         the user hovers over the test failure block, reducing visual noise.
2020
2021         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2022         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2023         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
2024
2025 2011-09-01  Adam Barth  <abarth@webkit.org>
2026
2027         Switch garden-o-matic from commitData.title to commitData.summary
2028         https://bugs.webkit.org/show_bug.cgi?id=67375
2029
2030         Reviewed by Dimitri Glazkov.
2031
2032         commitData.title is a string provided by Trac, which isn't great in all
2033         cases.  commitData.summary is my attempt to find the most important
2034         one-line summary of the commit.  This patch switches garden-o-matic
2035         over to summary.
2036
2037         Also, this patch tweaks a bunch of CSS to tighten up the summary page
2038         and reduce visual noise.
2039
2040         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2041         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2042         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
2043
2044 2011-09-01  Adam Barth  <abarth@webkit.org>
2045
2046         Group failing tests in garden-o-matic if there are more than three in a folder
2047         https://bugs.webkit.org/show_bug.cgi?id=67373
2048
2049         Reviewed by Dimitri Glazkov.
2050
2051         Sometimes a failure will cause many tests in a given directory to fail.
2052         When that happens, it's better to list the directory as a single item
2053         (with a count) rather than spamming all the test names.
2054
2055         (This patch also updates a bunch of unit test expected results after my last commit.)
2056
2057         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
2058         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
2059         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
2060         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2061         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2062
2063 2011-09-01  Adam Barth  <abarth@webkit.org>
2064
2065         Lower the visual noise from the failing builders display
2066         https://bugs.webkit.org/show_bug.cgi?id=67369
2067
2068         Reviewed by Dimitri Glazkov.
2069
2070         This patch ensures that the "Building" row in the failing builders
2071         display is always last and dims it by 50% to reduce visual noise.  This
2072         lets the gardener focus on the actual failures.
2073
2074         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2075         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
2076         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css: Added.
2077
2078 2011-09-01  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2079
2080         [Qt] Build dependency problems
2081         https://bugs.webkit.org/show_bug.cgi?id=38054
2082
2083         Make clean build after the defines are changed.
2084
2085         Reviewed by Csaba Osztrogonác.
2086
2087         * Scripts/webkitdirs.pm:
2088         (buildQMakeProject):
2089
2090 2011-08-31  Adam Barth  <abarth@webkit.org>
2091
2092         Move DumpRenderTree to WebKitPlatformSupport
2093         https://bugs.webkit.org/show_bug.cgi?id=67331
2094
2095         Reviewed by Darin Fisher.
2096
2097         This patch update DumpRenderTree to account for the WebKitClient =>
2098         WebKitPlatformSupport rename.
2099
2100         * DumpRenderTree/chromium/NotificationPresenter.cpp:
2101         (NotificationPresenter::show):
2102         * DumpRenderTree/chromium/Task.cpp:
2103         (postTask):
2104
2105 2011-08-31  Eric Seidel  <eric@webkit.org>
2106
2107         Add queues.webkit.org/active-bots page to make it easy to see which bots are down
2108         https://bugs.webkit.org/show_bug.cgi?id=67314
2109
2110         Reviewed by Adam Barth.
2111
2112         Very simple page.  Just lists all the bots, what queue they belong to and what we last heard from them.
2113         If we haven't heard from a bot in the last 500 messages (last day or so), then it won't show up here.
2114         This makes it very easy for me to see which of my cr-jail bots might be down at any one time.
2115
2116         I also moved a bunch of code into dashboard.css which belonged there.
2117
2118         * QueueStatusServer/handlers/activebots.py: Added.
2119         * QueueStatusServer/main.py:
2120         * QueueStatusServer/stylesheets/dashboard.css:
2121         (.queue_bubble):
2122         (.queue_name):
2123         (.last_heard_from):
2124         (.status_text):
2125         (.alive):
2126         (.behind):
2127         (.dead):
2128         * QueueStatusServer/templates/activebots.html: Added.
2129         * QueueStatusServer/templates/dashboard.html:
2130         * QueueStatusServer/templates/recentstatus.html:
2131
2132 2011-08-31  Oliver Hunt  <oliver@apple.com>
2133
2134         Move CheckedArithmeticOperations.cpp to the intended location
2135
2136         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2137         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp: Renamed from Tools/TestWebKitAPI/Tests/CheckedArithmeticOperations.cpp.
2138
2139 2011-08-31  Elliot Poger  <epoger@google.com>
2140
2141         add unittest to validate the complete set of Chromium configurations
2142         https://bugs.webkit.org/show_bug.cgi?id=67211
2143
2144         Reviewed by Adam Barth.
2145
2146         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2147
2148 2011-08-31  Nico Weber  <thakis@chromium.org>
2149
2150         Make ScrollAnimator(Chromium)?Mac check scrollAnimatorEnabled()
2151         https://bugs.webkit.org/show_bug.cgi?id=67297
2152
2153         Reviewed by Tony Chang.
2154
2155         Explicitly disable smooth scrolling in chromium's DRT.
2156
2157         * DumpRenderTree/chromium/WebPreferences.cpp:
2158         (WebPreferences::applyTo):
2159
2160 2011-08-31  Oliver Hunt  <oliver@apple.com>
2161
2162         Add Checked<> tests to windows build
2163
2164         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2165
2166 2011-08-30  Oliver Hunt  <oliver@apple.com>
2167
2168         Add support for checked arithmetic
2169         https://bugs.webkit.org/show_bug.cgi?id=67095
2170
2171         Reviewed by Sam Weinig.
2172
2173         Add test cases for Checked<>
2174
2175         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2176         * TestWebKitAPI/Tests/CheckedArithmeticOperations.cpp: Added.
2177
2178 2011-08-31  Adam Barth  <abarth@webkit.org>
2179
2180         Move summary.html to garden-o-matic.html.
2181
2182         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html.
2183         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js.
2184         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Removed.
2185         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Removed.
2186
2187 2011-08-31  Noel Gordon  <noel.gordon@gmail.com>
2188
2189         [chromium] DRT linux should pass nativeKeyCode to plugins
2190         https://bugs.webkit.org/show_bug.cgi?id=66679
2191
2192         Reviewed by Tony Chang.
2193
2194         * DumpRenderTree/chromium/EventSender.cpp:
2195         (EventSender::keyDown):  Call a Chromium Linux GTK helper routine that returns the
2196         (simulated) nativeKeyCode for the given input keyboard code.
2197
2198 2011-08-31  Adam Barth  <abarth@webkit.org>
2199
2200         Tighen up UI for garden-o-matic tab strip
2201         https://bugs.webkit.org/show_bug.cgi?id=67266
2202
2203         Reviewed by Dimitri Glazkov.
2204
2205         This patch add CSS to move the tab strip to the edges of the page and
2206         to remove some gratuitous border-radius.
2207
2208         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
2209         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
2210
2211 2011-08-31  Adam Barth  <abarth@webkit.org>
2212
2213         garden-o-matic results view shouldn't be horrifically ugly
2214         https://bugs.webkit.org/show_bug.cgi?id=67264
2215
2216         Reviewed by Dimitri Glazkov.
2217
2218         Minor tweak to the results view CSS to make it fit in better with the new tabbed UI.
2219
2220         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2221         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2222         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
2223
2224 2011-08-31  Adam Barth  <abarth@webkit.org>
2225
2226         garden-o-matic needs a tabstrip
2227         https://bugs.webkit.org/show_bug.cgi?id=67263
2228
2229         Reviewed by Dimitri Glazkov.
2230
2231         This patch adds a basic tabstrip to garden-o-matic.  The results
2232         details view now opens in the "Results" tab, and the user can flip back
2233         and forth between the Summary and the Results tab quickly.  There's
2234         also a stub for a "Commits" tab, which is disabled.
2235
2236         This patch isn't the most beautiful in the world, but it gets the ball
2237         rolling on a multi-modal UI.
2238
2239         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2240         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
2241         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2242         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
2243         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
2244
2245 2011-08-31  Ai Makabi  <makabi@google.com>
2246
2247         Extract reference links from reftest test file.
2248         https://bugs.webkit.org/show_bug.cgi?id=66838
2249
2250         Reviewed by Shinichiro Hamaji.
2251
2252         * Scripts/webkitpy/layout_tests/reftests/__init__.py: Added.
2253         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link.py: Added.
2254         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link_unittest.py: Added.
2255
2256 2011-08-03  Philippe Normand  <pnormand@igalia.com>
2257
2258         [webkitpy] missing log import in common/net/resultsjsonparser.py
2259         https://bugs.webkit.org/show_bug.cgi?id=65606
2260
2261         Reviewed by Martin Robinson.
2262
2263         * Scripts/webkitpy/common/net/resultsjsonparser.py: Import the logging module.
2264
2265 2011-08-30  Philippe Normand  <pnormand@igalia.com>
2266
2267         [stylechecker] complains about NULL usage in some gst_structure_ calls
2268         https://bugs.webkit.org/show_bug.cgi?id=67194
2269
2270         Reviewed by Martin Robinson.
2271
2272         Don't warn about NULL in some gst_structure_ calls. 0 can't be
2273         used for these, a proper sentinel is required.
2274
2275         * Scripts/webkitpy/style/checkers/cpp.py:
2276         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2277
2278 2011-08-30  Adam Barth  <abarth@webkit.org>
2279
2280         Remove old-style UI from garden-o-matic
2281         https://bugs.webkit.org/show_bug.cgi?id=67257
2282
2283         Reviewed by Dimitri Glazkov.
2284
2285         This code is nowhere near as awesome as the new hotness.  Let's remove
2286         it so it doesn't weigh us down.
2287
2288         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Removed.
2289         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Removed.
2290         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2291         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
2292         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/unexpected-passes.js: Removed.
2293         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html: Removed.
2294
2295 2011-08-30  Takashi Toyoshima  <toyoshim@chromium.org>
2296
2297         [WebSocket] update pywebsocket to 0.6b5.
2298         https://bugs.webkit.org/show_bug.cgi?id=66924
2299
2300         Reviewed by Kent Tamura.
2301
2302         pywebsocket 0.6b2 supported minimum features of Hybi-08 specification.
2303         Now, pywebsocket 0.6b5 supports full features of Hybi-10 specification.
2304         0.6b3 or later supports a closing handshake handler and it is useful to
2305         verify client's closing handshake implementation.
2306         0.6b4 supports AbortedByUserException. It is useful to eliminate
2307         unnecessary server warning messages on intended abnormal closures.
2308         0.6b5 supports Python 2.5.1 or Mac 10.5.
2309
2310         * Scripts/webkitpy/thirdparty/__init__.py:
2311         Update download URL and directory path.
2312
2313 2011-08-30  Dan Bernstein  <mitz@apple.com>
2314
2315         Test for <rdar://problem/9281695> Add text search API for getting the DOM range of a text match
2316         https://bugs.webkit.org/show_bug.cgi?id=67230
2317
2318         Reviewed by Darin Adler.
2319
2320         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2321         * TestWebKitAPI/Tests/mac/DOMRangeOfString.html: Added.
2322         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm: Added.
2323         (-[DOMRangeOfStringFrameLoadDelegate webView:didFinishLoadForFrame:]):
2324         (TestWebKitAPI::TEST):
2325
2326 2011-08-30  Aaron Colwell  <acolwell@chromium.org>
2327
2328         Add MediaSource API to HTMLMediaElement
2329         https://bugs.webkit.org/show_bug.cgi?id=64731
2330
2331         Reviewed by Eric Carlson.
2332
2333         * Scripts/build-webkit:
2334
2335 2011-08-30  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2336
2337         Emit last progress notification before calling dispatchDidFinishLoad
2338         https://bugs.webkit.org/show_bug.cgi?id=28851
2339
2340         Reviewed by Adam Barth.
2341
2342         Implement dumpProgressFinishedCallback() in the layoutTestController for Qt,
2343         Chromium and GTK ports. The first two were simple changes.
2344
2345         Some refactoring was needed in GTK port to assure that the dumps are emitted
2346         correctly and the processing after the page load finished is in the right place.
2347
2348         To detect the load finished, we use the callback for the "load-status" notifier
2349         signal of the top loading frame. And we use the deprecated "load-finished" signal
2350         for dumping (if enabled) the progress finished expected output.
2351
2352         * DumpRenderTree/LayoutTestController.cpp:
2353         (LayoutTestController::LayoutTestController):
2354         (dumpProgressFinishedCallbackCallback):
2355         (LayoutTestController::staticFunctions):
2356         * DumpRenderTree/LayoutTestController.h:
2357         (LayoutTestController::dumpProgressFinishedCallback):
2358         (LayoutTestController::setDumpProgressFinishedCallback):
2359         * DumpRenderTree/chromium/LayoutTestController.cpp:
2360         (LayoutTestController::LayoutTestController):
2361         (LayoutTestController::dumpProgressFinishedCallback):
2362         (LayoutTestController::reset):
2363         * DumpRenderTree/chromium/LayoutTestController.h:
2364         (LayoutTestController::shouldDumpProgressFinishedCallback):
2365         (LayoutTestController::setShouldDumpProgressFinishedCallback):
2366         * DumpRenderTree/chromium/WebViewHost.cpp:
2367         (WebViewHost::didStopLoading):
2368         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2369         (webViewLoadFinished):
2370         (topLoadingFrameLoadFinished):
2371         (webFrameLoadStatusNotified):
2372         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2373         (LayoutTestController::reset):
2374         (LayoutTestController::dumpProgressFinishedCallback):
2375         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2376
2377 2011-08-30  Filip Pizlo  <fpizlo@apple.com>
2378
2379         JavaScriptCore does not have a good mechanism for performance
2380         regression testing
2381         https://bugs.webkit.org/show_bug.cgi?id=67177
2382
2383         Reviewed by Darin Adler.
2384         
2385         Added a new script, which allows for testing one, two, or more VMs
2386         at once on SunSpider, V8, and Kraken benchmarks.  Benchmark/VM runs
2387         are interleaved at random to minimize systematics.  The results
2388         that bencher prints includes all possible relevant information about
2389         how bencher was invoked.  Bencher can be easily used to measure
2390         performance changes down to fractions of a percent.
2391         
2392         Bencher also includes experimental support for running benchmarks in
2393         a DumpRenderTree release build.  This works in SunSpider and V8, but
2394         not yet in Kraken.  Running benchmarks in DumpRenderTree more
2395         closely mimics the performance when running in browser.
2396
2397         * Scripts/bencher: Added.
2398
2399 2011-08-29  Alexey Proskuryakov  <ap@apple.com>
2400
2401         DumpRenderTree should begin each test with an empty cookie store
2402         https://bugs.webkit.org/show_bug.cgi?id=63545
2403         <rdar://problem/5666907>
2404
2405         Reviewed by Darin Adler.
2406
2407         * DumpRenderTree/mac/DumpRenderTree.mm:
2408         (resetDefaultsToConsistentValues):
2409         (setDefaultsToConsistentValuesForTesting):
2410         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2411         (LayoutTestController::setAlwaysAcceptCookies):
2412         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2413         (WTR::InjectedBundle::beginTesting):
2414         Use new SPIs to manipulate sessions.
2415
2416 2011-08-30  Sheriff Bot  <webkit.review.bot@gmail.com>
2417
2418         Unreviewed, rolling out r94055 and r94057.
2419         http://trac.webkit.org/changeset/94055
2420         http://trac.webkit.org/changeset/94057
2421         https://bugs.webkit.org/show_bug.cgi?id=67191
2422
2423         Many failures on Mac 10.5 (Requested by toyoshim on #webkit).
2424
2425         * Scripts/webkitpy/thirdparty/__init__.py:
2426
2427 2011-08-30  Adam Barth  <abarth@webkit.org>
2428
2429         Chromium Android should not be a core builder
2430         https://bugs.webkit.org/show_bug.cgi?id=67184
2431
2432         Reviewed by Ryosuke Niwa.
2433
2434         This bot hasn't been consistently green yet because it has never actually run!
2435
2436         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2437         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2438
2439 2011-08-30  Takashi Toyoshima  <toyoshim@chromium.org>
2440
2441         [WebSocket] update pywebsocket to 0.6b4.
2442         https://bugs.webkit.org/show_bug.cgi?id=66924
2443
2444         Reviewed by Kent Tamura.
2445
2446         pywebsocket 0.6b2 supported minimum features of Hybi-08 specification.
2447         Now, pywebsocket 0.6b4 supports full features of Hybi-10 specification.
2448         0.6b3 or later supports a closing handshake handler and it is useful to
2449         verify client's closing handshake implementation.
2450         0.6b4 supports AbortedByUserException. It is useful to eliminate
2451         unnecessary server warning messages on intended abnormal closures.
2452
2453         * Scripts/webkitpy/thirdparty/__init__.py:
2454         Update download URL and directory path.
2455
2456 2011-08-29  Tom Zakrajsek  <tomz@codeaurora.org>
2457
2458         sheriffbot "usage" help statements are wrong
2459         https://bugs.webkit.org/show_bug.cgi?id=67170
2460
2461         Reviewed by Adam Barth.
2462
2463         * Scripts/webkitpy/tool/bot/irc_command.py:
2464         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2465         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2466
2467 2011-08-29  Adam Barth  <abarth@webkit.org>
2468
2469         Add support for chomium-mac (non-CoreGraphics) baselines
2470         https://bugs.webkit.org/show_bug.cgi?id=67163
2471
2472         Reviewed by Eric Seidel.
2473
2474         This patch teaches the non-CG chromium-mac bots to look at non-CG
2475         baselines.  However, the patch still leaves CG as the default set of
2476         baselines.
2477
2478         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
2479         * Scripts/webkitpy/common/config/build.py:
2480         * Scripts/webkitpy/common/config/build_unittest.py:
2481         * Scripts/webkitpy/layout_tests/port/builders.py:
2482         * Scripts/webkitpy/layout_tests/port/chromium.py:
2483         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2484         * Scripts/webkitpy/layout_tests/port/factory.py:
2485         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2486         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
2487         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
2488         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2489
2490 2011-08-29  Shawn Singh  <shawnsingh@chromium.org>
2491
2492         Small fix in chromium port of new-run-webkit-tests.
2493         https://bugs.webkit.org/show_bug.cgi?id=67078
2494
2495         Reviewed by Dirk Pranke.
2496
2497         * Scripts/webkitpy/layout_tests/port/chromium.py:
2498
2499 2011-08-29  Sheriff Bot  <webkit.review.bot@gmail.com>
2500
2501         Unreviewed, rolling out r93987, r93992, r93995, r93998, and
2502         r93999.
2503         http://trac.webkit.org/changeset/93987
2504         http://trac.webkit.org/changeset/93992
2505         http://trac.webkit.org/changeset/93995
2506         http://trac.webkit.org/changeset/93998
2507         http://trac.webkit.org/changeset/93999
2508         https://bugs.webkit.org/show_bug.cgi?id=67147
2509
2510         Many failing tests (Requested by ap on #webkit).
2511
2512         * DumpRenderTree/mac/DumpRenderTree.mm:
2513         (setDefaultsToConsistentValuesForTesting):
2514         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2515         (WTR::InjectedBundle::beginTesting):
2516
2517 2011-08-26  Alexey Proskuryakov  <ap@apple.com>
2518
2519         DumpRenderTree should begin each test with an empty cookie store
2520         https://bugs.webkit.org/show_bug.cgi?id=63545
2521         <rdar://problem/5666907>
2522
2523         Reviewed by Darin Adler.
2524
2525         * DumpRenderTree/mac/DumpRenderTree.mm:
2526         (setDefaultsToConsistentValuesForTesting):
2527         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2528         (WTR::InjectedBundle::beginTesting):
2529         Tell WebCore to use a temporary session, starting with a clean cookie store.
2530
2531 2011-08-23  Chris Marrin  <cmarrin@apple.com>
2532
2533         [mac] requestAnimationFrame support for mac port
2534         https://bugs.webkit.org/show_bug.cgi?id=59146
2535
2536         Reviewed by Simon Fraser.
2537
2538         Add support for request-animation-callback flag
2539
2540         * Scripts/build-webkit:
2541
2542 2011-08-27  Peter Beverloo  <peter@chromium.org>
2543
2544         Add a build bot for Chromium with OS(ANDROID)
2545         https://bugs.webkit.org/show_bug.cgi?id=66687
2546
2547         Reviewed by Adam Barth.
2548
2549         * BuildSlaveSupport/build.webkit.org-config/config.json:
2550
2551 2011-08-27  Peter Beverloo  <peter@chromium.org>
2552
2553         Update the master build bot configuration script to properly
2554         deal with the --chromium-android switch.
2555         https://bugs.webkit.org/show_bug.cgi?id=66687
2556
2557         The --chromium-android switch is needed when running
2558         update-webkit-chromium and build-webkit, as it'll tell the
2559         scripts to pull in the right dependencies and cross-compile
2560         WebKit using the Android NDK.
2561
2562         Reviewed by Adam Barth.
2563
2564         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2565
2566 2011-08-27  Peter Beverloo  <peter@chromium.org>
2567
2568         Teach the update and build scripts how to handle dependencies
2569         and cross-compiling rules for the Chromium port on OS(ANDROID).
2570         https://bugs.webkit.org/show_bug.cgi?id=66687
2571
2572         Reviewed by Adam Barth.
2573
2574         * Scripts/build-webkit:
2575         * Scripts/update-webkit:
2576         * Scripts/update-webkit-chromium:
2577         * Scripts/webkitdirs.pm:
2578         (argumentsForConfiguration):
2579         (isChromium):
2580         (isChromiumAndroid):
2581         (determineIsChromiumAndroid):
2582         (buildChromium):
2583
2584 2011-08-26  Adam Barth  <abarth@webkit.org>
2585
2586         garden-o-matic should let me know that I need to run the local server
2587         https://bugs.webkit.org/show_bug.cgi?id=66985
2588
2589         Reviewed by Dimitri Glazkov.
2590
2591         The patch triggers an alert dialog whenever the user tries to use a
2592         feature that requires the local server.
2593
2594         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
2595         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
2596         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
2597
2598 2011-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
2599
2600         garden-o-matic summary view should have pretty commit data information.
2601         https://bugs.webkit.org/show_bug.cgi?id=67069
2602
2603         Reviewed by Adam Barth.
2604
2605         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added support for styling commit data.
2606         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Changed tests.
2607         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Defined global anchor color.
2608         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Styled commit data.
2609
2610 2011-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
2611
2612         Tweak the use of Open Sans in garden-o-matic summary view to make it look decent on Windows and Linux.
2613         https://bugs.webkit.org/show_bug.cgi?id=67066
2614
2615         Reviewed by Adam Barth.
2616
2617         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Tweaked.
2618         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
2619
2620 2011-08-26  Raphael Kubo da Costa  <kubo@profusion.mobi>
2621
2622         [DRT] Include cairo.h in PixelDumpSupportCairo.h for EFL too.
2623         https://bugs.webkit.org/show_bug.cgi?id=67041
2624
2625         Reviewed by Martin Robinson.
2626
2627         This is a follow-up to r89053: EFL's PixelDumpSupportEfl.cpp includes
2628         PixelDumpSupportCairo.h, but the latter was #including cairo.h only
2629         when the GTK+ port was being built.
2630
2631         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
2632
2633 2011-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
2634
2635         Clean up and line up layout in garden-o-matic summary view.
2636         https://bugs.webkit.org/show_bug.cgi?id=67057
2637
2638         1) Renamed ui.notifications.TestFailures to ui.notifications.TestsFailing to match BuildersFailing;
2639         2) Rearranged DOM structure a bit to accommodate recent changes;
2640         3) Added minimal CSS to line things up.
2641
2642         Reviewed by Adam Barth.
2643
2644         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Renamed TestFailures to TestsFailing.
2645         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Added mocks for BuildersFailing.
2646         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Renamed TestFailures to TestsFailing.
2647         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Updated tests.
2648         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed DOM structure.
2649         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated tests.
2650         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Tweaked common appearance.
2651         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added minimal layout/style.
2652         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Added Google Web Fonts hook.
2653         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
2654
2655 2011-08-26  Alice Liu  <alice.liu@apple.com>
2656
2657         https://bugs.webkit.org/show_bug.cgi?id=66823
2658         Add the request info to the WebPageProxy::CreateNewPage message
2659
2660         Reviewed by Anders Carlsson.
2661
2662         Update function declarations with additional parameter:
2663         * MiniBrowser/gtk/BrowserWindow.c:
2664         (createNewPage):
2665         * MiniBrowser/mac/BrowserWindowController.m:
2666         (createNewPage):
2667         * MiniBrowser/win/BrowserView.cpp:
2668         (createNewPage):
2669         * WebKitTestRunner/TestController.cpp:
2670         (WTR::TestController::createOtherPage):
2671         * WebKitTestRunner/TestController.h:
2672
2673 2011-08-26  Noel Gordon  <noel.gordon@gmail.com>
2674
2675         Make show-pretty-diff work on linux
2676         https://bugs.webkit.org/show_bug.cgi?id=67017
2677
2678         Reviewed by Adam Barth.
2679
2680         * Scripts/show-pretty-diff:
2681
2682 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
2683
2684         Reorganize garden-o-matic CSS files to match JS-built views.
2685         https://bugs.webkit.org/show_bug.cgi?id=66998
2686
2687         Reviewed by Adam Barth.
2688
2689         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Added.
2690         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added.
2691         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css: Added.
2692         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css: Removed.
2693         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Changed to use new CSS files.
2694         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
2695
2696 2011-08-25  Adam Barth  <abarth@webkit.org>
2697
2698         garden-o-matic should be able to roll out patches
2699         https://bugs.webkit.org/show_bug.cgi?id=66982
2700
2701         Reviewed by Dimitri Glazkov.
2702
2703         This patch just wires the rollout event through the controller to the
2704         local server, which is already set up to perform rollouts.
2705
2706         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
2707         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2708         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2709         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
2710
2711 2011-08-25  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
2712
2713         [Qt] [WK2] Assert in computeViewportAttributes when MiniBrowser started with -touch
2714         https://bugs.webkit.org/show_bug.cgi?id=66951
2715
2716         Reviewed by Andreas Kling.
2717
2718         Function computeViewportAttributes() gets called when height is still 0 because MiniBrowser sets
2719         width and height one by one and setWidth cause geometryChange event in QTouchWebView. 
2720
2721         * MiniBrowser/qt/BrowserView.cpp:
2722         (BrowserView::resizeEvent):
2723
2724 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
2725
2726         garden-o-matic summary view should provide information on builders still in flight.
2727         https://bugs.webkit.org/show_bug.cgi?id=66992
2728
2729         Reviewed by Adam Barth.
2730
2731         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Added grabbing the list of in-flight builders.
2732         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Added buildersInFlightForRevision.
2733         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js: Added tests.
2734         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Split off updating builder results to own method.
2735         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added tests.
2736
2737 2011-08-25  Adam Barth  <abarth@webkit.org>
2738
2739         webkit-patch rebaseline-expectations don't work when run outside the root
2740         https://bugs.webkit.org/show_bug.cgi?id=66966
2741
2742         Reviewed by Eric Seidel.
2743
2744         Turns out tool.path() used to be relative, which caused problems when
2745         running webkit-patch outside the root directory.  This patch makes it
2746         absolute.  I checked all callers, and they all appear to want this
2747         behavior.
2748
2749         It was unclear to me how to test this change because we only really
2750         have a testing strategy for webkitpy, not for the main script.
2751
2752         * Scripts/webkit-patch:
2753
2754 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
2755
2756         garden-o-matic summary needs a mock view that could be used for working on styling
2757         https://bugs.webkit.org/show_bug.cgi?id=66971
2758
2759         Reviewed by Adam Barth.
2760
2761         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Added.
2762         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Added.
2763
2764 2011-08-25  Anders Carlsson  <andersca@apple.com>
2765
2766         Return the correct value for NPNVsupportsCarbonBool
2767         https://bugs.webkit.org/show_bug.cgi?id=66964
2768
2769         Add a test.
2770
2771         Reviewed by Adam Roben.
2772
2773         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2774         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Added.
2775         (SupportsCarbonEventModel::SupportsCarbonEventModel):
2776         (SupportsCarbonEventModel::testConvert):
2777         (SupportsCarbonEventModel::runTest):
2778         (SupportsCarbonEventModel::NPP_New):
2779
2780 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
2781
2782         garden-o-matic summary view should not be broken.
2783
2784         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css:
2785         (table.comparison): Added more specificity.
2786
2787 2011-08-25  Adam Barth  <abarth@webkit.org>
2788
2789         This command has been broken for a while.  This patch updates the
2790         callsite to the new API.
2791
2792         * Scripts/webkitpy/tool/commands/rebaseline.py:
2793
2794 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
2795
2796         garden-o-matic needs a way to report where and how tests are failing in the summary view.
2797         https://bugs.webkit.org/show_bug.cgi?id=66955
2798
2799         Introduce FailureGrid, your one-stop failure-indicating destination. 
2800
2801         Reviewed by Adam Barth.
2802
2803         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html: Added new scripts.
2804         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Added.
2805         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Added.
2806         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Updated to use FailureGrid.
2807         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated tests.
2808         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Added new scripts.
2809
2810 2011-08-25  Igor Oliveira  <igor.oliveira@openbossa.org>
2811
2812         Add myself to the committers list
2813         https://bugs.webkit.org/show_bug.cgi?id=66941
2814
2815         Reviewed by Andreas Kling.
2816
2817         * Scripts/webkitpy/common/config/committers.py:
2818
2819 2011-08-25  Sheriff Bot  <webkit.review.bot@gmail.com>
2820
2821         Unreviewed, rolling out r93767.
2822         http://trac.webkit.org/changeset/93767
2823         https://bugs.webkit.org/show_bug.cgi?id=66931
2824
2825         Broke Qt bot. (Requested by yutak on #webkit).
2826
2827         * Scripts/webkitpy/thirdparty/__init__.py:
2828
2829 2011-08-25  Takashi Toyoshima  <toyoshim@chromium.org>
2830
2831         [WebSocket] update pywebsocket to 0.6b3 which supports closing handshake test
2832         https://bugs.webkit.org/show_bug.cgi?id=66924
2833
2834         Reviewed by Kent Tamura.
2835
2836         * Scripts/webkitpy/thirdparty/__init__.py:
2837
2838 2011-08-24  Adam Barth  <abarth@webkit.org>
2839
2840         The user can't close the details view in garden-o-matic
2841         https://bugs.webkit.org/show_bug.cgi?id=66911
2842
2843         Reviewed by Dimitri Glazkov.
2844
2845         In addition to adding a close button, this patch changes the test
2846         selector to use a <select> element and refactors the test selector to
2847         share code with the builder selector.
2848
2849         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2850         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
2851         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
2852         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2853
2854 2011-08-24  James Robinson  <jamesr@chromium.org>
2855
2856         [chromium] Stacktrace not in test output when a test crashes
2857         https://bugs.webkit.org/show_bug.cgi?id=66806
2858
2859         Reviewed by Dirk Pranke.
2860
2861         Appends the .error and .text output when a test crashes since on chromium the .text contains the actual stack
2862         trace.
2863
2864         * Scripts/webkitpy/layout_tests/port/chromium.py:
2865
2866 2011-08-24  Adam Barth  <abarth@webkit.org>
2867
2868         Remove empty directory.
2869
2870         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui: Removed.
2871
2872 2011-08-24  Adam Barth  <abarth@webkit.org>
2873
2874         Finish writing up details-view in garden-o-matic
2875         https://bugs.webkit.org/show_bug.cgi?id=66891
2876
2877         Reviewed by Dimitri Glazkov.
2878
2879         This patch mostly just copies a bunch of CSS from main.css to
2880         summary.css.  Presumably we'll delete main.css soon.
2881
2882         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2883         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
2884         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
2885         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css:
2886         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
2887
2888 2011-08-24  James Robinson  <jamesr@chromium.org>
2889
2890         Some compositing LayoutTests flakily crashing on Mac 10.6
2891         https://bugs.webkit.org/show_bug.cgi?id=66740
2892
2893         Reviewed by Adam Barth.
2894
2895         Null-check obj->pluginTest before dereferencing it. This can be null in chromium if the plugin load fails, for
2896         example if the test attempts to load a PDF plugin the load will fail since we don't have such a thing in the
2897         chromium configuration.
2898
2899         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2900         (NPP_Destroy):
2901
2902 2011-08-24  Anton D'Auria  <adauria@apple.com>
2903
2904         No review necessary.
2905
2906         Adding myself to list of committers.
2907
2908         * Scripts/webkitpy/common/config/committers.py:
2909
2910 2011-08-24  Avi Drissman  <avi@google.com>
2911
2912         Crash when restoring NSGraphicsContext when running the Chromium GPU layout tests on Mac
2913         https://bugs.webkit.org/show_bug.cgi?id=66875
2914
2915         Reviewed by James Robinson.
2916
2917         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
2918         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2919
2920 2011-08-23  Dimitri Glazkov  <dglazkov@chromium.org>
2921
2922         Make notifications appear in time order again.
2923         https://bugs.webkit.org/show_bug.cgi?id=66815
2924
2925         Reviewed by Adam Barth.
2926
2927         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added setting index of the notification.
2928         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated the test.
2929
2930 2011-08-23  James Robinson  <jamesr@chromium.org>
2931
2932         [chromium] Need a way to test lost compositor context recovery
2933         https://bugs.webkit.org/show_bug.cgi?id=66820
2934
2935         Reviewed by Kenneth Russell.
2936
2937         Exposes a LayoutTestController interface in chromium to simulate a
2938         lost compositor context.
2939
2940         * DumpRenderTree/chromium/LayoutTestController.cpp:
2941         (LayoutTestController::LayoutTestController):
2942         (LayoutTestController::loseCompositorContext):
2943         * DumpRenderTree/chromium/LayoutTestController.h:
2944
2945 2011-08-23  Dimitri Glazkov  <dglazkov@chromium.org>
2946
2947         Change garden-o-matic frontend builder array to be a configuration map.
2948         https://bugs.webkit.org/show_bug.cgi?id=66816
2949
2950         Reviewed by Adam Barth.
2951
2952         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js: Made kBuilders a map, with value being a configuration object.
2953         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Adjusted callsites to expect a map.
2954         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Ditto.
2955         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Ditto.
2956         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Ditto.
2957
2958 2011-08-23  Cary Clark  <caryclark@google.com>
2959
2960         Turn WebCanvas into CGContext before drawing scrollbar (DRT using Skia on Mac)
2961         https://bugs.webkit.org/show_bug.cgi?id=66803
2962
2963         This fixes the WebKit Canaries, in particular avoids a crash on tests
2964         like css1/basic/comments.html.
2965
2966         Reviewed by James Robinson.
2967
2968         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
2969         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2970         The NSGraphicsContext call graphicsContextWithGraphicsPort takes a void*
2971         parameter, so it took a WebCanvas* (mapped to SkCanvas* in Skia-land)
2972         and treated it as if it were a CGContextRef.
2973
2974 2011-08-23  Patrick Gansterer  <paroga@webkit.org>
2975
2976         Fix mergeChangeLogs test on native windows
2977         https://bugs.webkit.org/show_bug.cgi?id=66797
2978
2979         Reviewed by Adam Roben.
2980
2981         Windows has no /tmp/ directory and the "TMPDIR" environment variable isn't set in the default setup.
2982         Add the "TEMP" environment variable as additional source for the temporary directory used in writeTempFile.
2983
2984         * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl:
2985         (writeTempFile):
2986
2987 2011-08-23  Dimitri Glazkov  <dglazkov@chromium.org>
2988
2989         garden-o-matic relative time is wrong and updates too frequently.
2990         https://bugs.webkit.org/show_bug.cgi?id=66802
2991
2992         Reviewed by Adam Barth.
2993
2994         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Changed to account for rounding correctly.
2995         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js: Updated tests.
2996         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Upped the interval to 1 minute.
2997
2998 2011-08-23  Patrick Gansterer  <paroga@webkit.org>
2999
3000         Add missing quotes around filenames in mergeChangeLogs
3001         https://bugs.webkit.org/show_bug.cgi?id=66794
3002
3003         Reviewed by Adam Roben.
3004
3005         * Scripts/VCSUtils.pm:
3006         (mergeChangeLogs):
3007
3008 2011-08-23  Patrick Gansterer  <paroga@webkit.org>
3009
3010         webkit-perl tests fail on win32 Perl due to lack of list form of pipe open implementation
3011         https://bugs.webkit.org/show_bug.cgi?id=49080
3012
3013         Reviewed by Adam Roben.
3014
3015         Use the string form of pipe open instead (like we do at all other places).
3016
3017         * Scripts/VCSUtils.pm:
3018         (mergeChangeLogs):
3019
3020 2011-08-23  Adam Barth  <abarth@webkit.org>
3021
3022         garden-o-matic summary should be able to examine failures
3023         https://bugs.webkit.org/show_bug.cgi?id=66748
3024
3025         Reviewed by Dimitri Glazkov.
3026
3027         This patch refactors a bunch of code from summary.js to independent
3028         controllers in controllers.js.  This patch also contains the first
3029         iteration of binding the "examine" event to a the behavior showing the
3030         details view for the tests.  There's more work to do here to make this
3031         work properly (and elegantly), but this patch is a start.
3032
3033         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
3034         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
3035         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3036         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers/rebaseline.js:
3037         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
3038         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3039         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3040         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
3041         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
3042
3043 2011-08-23  Adam Barth  <abarth@webkit.org>
3044
3045         webkitpy/common/config/build.py shouldn't mention non-existant Android directory
3046         https://bugs.webkit.org/show_bug.cgi?id=66737
3047
3048         Reviewed by Steve Block.
3049
3050         This directory doesn't exist anymore now that the Android port shares
3051         more code with Chromium.
3052
3053         * Scripts/webkitpy/common/config/build.py:
3054
3055 2011-08-22  Eric Seidel  <eric@webkit.org>
3056
3057         Hack start-queue.sh in an attempt to resurrect the cr-jail-1 cr-mac-ews bot.
3058         I won't have ssh access to the bot again for a couple days, so
3059         attempting to fix by changing this script.  If this doesn't
3060         work we'll just live with the it hung for now.
3061
3062         Unreviewed.
3063
3064         * EWSTools/start-queue.sh:
3065
3066 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
3067
3068         webkit-patch rebaseline-expectations command should not rearrange the entire test_expectations.txt file.
3069         https://bugs.webkit.org/show_bug.cgi?id=66727
3070
3071         Reviewed by Adam Barth.
3072
3073         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Made it possible to run TestExpectationSerializer without a TestConfigurationConverter,
3074             in which case the serializer treats all expectations as unparsed.
3075         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added unit tests.
3076
3077 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
3078
3079         Update unit test expectations after r93530.
3080
3081         * Scripts/webkitpy/layout_tests/port/factory_unittest.py: Updated.
3082         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Ditto.
3083
3084 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
3085
3086         [Chromium] Expand CPU/GPU/Skia/CG into a matrix in graphics_type.
3087         https://bugs.webkit.org/show_bug.cgi?id=66705
3088
3089         Reviewed by Adam Barth.
3090
3091         * Scripts/webkitpy/layout_tests/port/chromium.py: Added plumbing for CG graphics types.
3092         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Adjusted unit test.
3093
3094 2011-08-22  James Robinson  <jamesr@chromium.org>
3095
3096         [chromium] Update builder names for chromium gpu bots due to CG switchover
3097         https://bugs.webkit.org/show_bug.cgi?id=66693
3098
3099         Reviewed by Dirk Pranke.
3100
3101         Update the port and builder names for the chromium mac gpu bots to
3102         account for the CG transition.
3103
3104         * Scripts/webkitpy/layout_tests/port/builders.py:
3105
3106 2011-08-22  Dirk Pranke  <dpranke@chromium.org>
3107
3108         fix the GPU bot names on the layout test dashboard
3109         https://bugs.webkit.org/show_bug.cgi?id=66697
3110
3111         Reviewed by Dimitri Glazkov.
3112
3113         * TestResultServer/static-dashboards/builders.js:
3114
3115 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
3116
3117         garden-o-matic's relative time display should be updated regularly.
3118         https://bugs.webkit.org/show_bug.cgi?id=66682
3119
3120         Reviewed by Adam Barth.
3121
3122         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Moved Time to ui.Time, added code for regular updates.
3123         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed to use ui.Time.
3124         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Added tests.
3125
3126 2011-08-22  Xianzhu Wang  <wangxianzhu@chromium.org>
3127
3128         Pass --makeargs of build-webkit to chromium linux builder
3129         https://bugs.webkit.org/show_bug.cgi?id=66361
3130
3131         Reviewed by Tony Chang.
3132
3133         * Scripts/build-webkit:
3134         * Scripts/webkitdirs.pm:
3135         (buildChromiumMakefile):
3136         (buildChromium):
3137
3138 2011-08-22  Peter Beverloo  <peter@chromium.org>
3139
3140         Add myself to the contributor list.
3141         https://bugs.webkit.org/show_bug.cgi?id=66674
3142
3143         Reviewed by Tony Gentilcore.
3144
3145         * Scripts/webkitpy/common/config/committers.py:
3146
3147 2011-08-22  Balazs Kelemen  <kbalazs@webkit.org>
3148
3149         [Qt] ImageDiff does not consider --tolerance
3150         https://bugs.webkit.org/show_bug.cgi?id=66299
3151
3152         Reviewed by Csaba Osztrogonác.
3153
3154         * DumpRenderTree/qt/ImageDiff.cpp:
3155         (main):
3156
3157 2011-08-22  Csaba Osztrogonác  <ossy@webkit.org>
3158
3159         Update contributor list.
3160
3161         Reviewed by Zoltan Herczeg.
3162
3163         * Scripts/webkitpy/common/config/committers.py:
3164
3165 2011-08-22  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
3166
3167         [ORWT] Fix --reset-results --add-platform-exceptions combo
3168         https://bugs.webkit.org/show_bug.cgi?id=65464
3169
3170         Reviewed by Csaba Osztrogonác.
3171
3172         * Scripts/old-run-webkit-tests:
3173
3174 2011-08-20  Adam Barth  <abarth@webkit.org>
3175
3176         garden-o-matic summary.html should have UI for examining failures
3177         https://bugs.webkit.org/show_bug.cgi?id=66625
3178
3179         Reviewed by Dimitri Glazkov.
3180
3181         This patch introduces the notion of UI actions and converts our
3182         existing manual <button> manipulation with this new abstraction.  The
3183         patch also adds an Examine button to failure notifications.  In a
3184         future patch, I'll add a controller that wires this button up to
3185         something useful.
3186
3187         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
3188         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
3189         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js: Added.
3190         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js: Added.
3191         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3192         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3193         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3194         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
3195
3196 2011-08-20  Adam Barth  <abarth@webkit.org>
3197
3198         garden-o-matic summary page should indiciate compile failures
3199         https://bugs.webkit.org/show_bug.cgi?id=66624
3200
3201         Reviewed by Dimitri Glazkov.
3202
3203         This patch creates a notification-based UI for build failures.  The new
3204         UI displays the same information that used to be displayed in the
3205         infobar.  There's lots of room for improvement in surfacing more
3206         information, but this is a start.
3207
3208         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
3209         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3210         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3211
3212 2011-08-19  James Robinson  <jamesr@chromium.org>
3213
3214         [chromium] Default to experimental-fully-parallel mode for chromium gpu port
3215         https://bugs.webkit.org/show_bug.cgi?id=66606
3216
3217         Reviewed by Dirk Pranke.
3218
3219         The chromium GPU configuration does not (currently) contain any tests
3220         incompatible with --experimental-fully-parallel, and this flag is a
3221         significan speedup because of the directory canvas/philip/tests which
3222         contains 802 tests in the same directory. Setting this option by
3223         default on this configuration is a 2x speed in release, 44s to 22s,
3224         and a 3x speedup in debug, 223s to 77s, on linux on a 16 core machine.
3225
3226         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3227         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3228         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3229
3230 2011-08-19  Sheriff Bot  <webkit.review.bot@gmail.com>
3231
3232         Unreviewed, rolling out r93426.
3233         http://trac.webkit.org/changeset/93426
3234         https://bugs.webkit.org/show_bug.cgi?id=66607
3235
3236         Broke the Mac build by not building gtest.framework anymore
3237         (Requested by andersca on #webkit).
3238
3239         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3240
3241 2011-08-19  James Robinson  <jamesr@chromium.org>
3242
3243         [chromium] Chromium GPU layout tests should use the normal process number selection, not force 1 worker
3244         https://bugs.webkit.org/show_bug.cgi?id=66603
3245
3246         Reviewed by Dirk Pranke.
3247
3248         The various ChromiumGpu ports should use the same child worker
3249         selection logic as other ports so they can run with full
3250         parallelization on multicore systems.
3251
3252         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3253         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3254
3255 2011-08-19  Alok Priyadarshi  <alokp@chromium.org>
3256
3257         [chromium] Remove dependency of WebThemeControlDRTWin on skia::PlatformCanvas
3258         https://bugs.webkit.org/show_bug.cgi?id=66570
3259
3260         Reviewed by Mihai Parparita.
3261
3262         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
3263         (WebThemeControlDRTWin::draw):
3264         (WebThemeControlDRTWin::drawTextField):
3265         (WebThemeControlDRTWin::drawProgressBar):
3266         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
3267
3268 2011-08-18  Dmitry Lomov  <dslomov@google.com>
3269
3270         TestWebKitAPI breaks on Windows due to fast malloc incompatibility.
3271         https://bugs.webkit.org/show_bug.cgi?id=66521
3272
3273         This patch ensures that gtest uses new and delete operators that are defined in JavaScriptCore.
3274
3275         Reviewed by David Levin.
3276
3277         * TestWebKitAPI/Tests/WTF/StringOperators.cpp: Removed redefinition of JS_EXPORTDATA.
3278
3279 2011-08-19  Adam Roben  <aroben@apple.com>
3280
3281         Add project file changes I left out in r93417
3282
3283         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3284
3285 2011-08-19  Adam Roben  <aroben@apple.com>
3286
3287         Add a helper class for swizzling ObjC instance methods to TestWebKitAPI
3288
3289         Fixes <http://webkit.org/b/66565> TestWebKitAPI needs a way to override instance methods of
3290         NSScreen
3291
3292         Reviewed by Anders Carlsson.
3293
3294         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
3295
3296         * TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Added.
3297         (-[SimpleObject setValue:]): Original implementation.
3298
3299         (TestWebKitAPI::setValue2):
3300         (TestWebKitAPI::setValue3):
3301         Swizzled implementations.
3302
3303         (TestWebKitAPI::TEST): Test that we can swizzle and re-swizzle and un-swizzle an ObjC
3304         instance method.
3305
3306         * TestWebKitAPI/mac/InstanceMethodSwizzler.h: Added.
3307         * TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Added.
3308         (TestWebKitAPI::InstanceMethodSwizzler::InstanceMethodSwizzler): Swizzle the method.
3309         (TestWebKitAPI::InstanceMethodSwizzler::~InstanceMethodSwizzler): Unswizzle the method.
3310
3311 2011-08-19  Tom Zakrajsek  <tomz@codeaurora.org>
3312
3313         Fix _path_to_apache() error reporting
3314         https://bugs.webkit.org/show_bug.cgi?id=66486
3315
3316         Reviewed by Ryosuke Niwa.
3317
3318         * Scripts/webkitpy/layout_tests/port/webkit.py:
3319
3320 2011-08-19  Adam Roben  <aroben@apple.com>
3321
3322         Windows build fix after r93404
3323
3324         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp: Added missing #include.
3325
3326 2011-08-19  Tony Gentilcore  <tonyg@chromium.org>
3327
3328         Add leandrogracia to the committers list
3329         https://bugs.webkit.org/show_bug.cgi?id=66552
3330
3331         Also fix line endings in file.
3332
3333         No reviewed required.
3334
3335         * Scripts/webkitpy/common/config/committers.py:
3336
3337 2011-08-19  Amruth Raj  <amruthraj@motorola.com>
3338
3339         Fix compilation issue in WebKitTestRunner
3340         https://bugs.webkit.org/show_bug.cgi?id=66554
3341
3342         Reviewed by Martin Robinson.
3343
3344         * WebKitTestRunner/PixelDumpSupport.cpp:
3345
3346 2011-08-19  Adam Roben  <aroben@apple.com>
3347
3348         Pull some of DynamicDeviceScaleFactor's code up into a shareable base class
3349
3350         This will make it easier to write other WebKit-agnostic tests
3351
3352         Fixes <http://webkit.org/b/66558> Would like to be able to reuse DynamicDeviceScaleFactor's
3353         code in other WebKit-agnostic tests
3354
3355         Reviewed by Anders Carlsson.
3356
3357         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
3358
3359         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm: Fixed copyright. Moved a bunch of
3360         code to WebKitAgnosticTest.h/mm. Changed to inherit from WebKitAgnosticTest.
3361         (TestWebKitAPI::DynamicDeviceScaleFactor::url): Simple getter.
3362         (TestWebKitAPI::DynamicDeviceScaleFactor::didLoadURL): Calls through to runTest.
3363         (TestWebKitAPI::DynamicDeviceScaleFactor::runTest): Removed loading code which
3364         WebKitAgnosticTest handles for us.
3365         (TestWebKitAPI::TEST_F): Removed view-creation code which WebKitAgnosticTest handles for us.
3366
3367         * TestWebKitAPI/mac/WebKitAgnosticTest.h: Added. Code came from DynamicDeviceScaleFactor.
3368         (TestWebKitAPI::WebKitAgnosticTest::loadAndWaitUntilDone): Code came from
3369         DynamicDeviceScaleFactor::runTest.
3370
3371         * TestWebKitAPI/mac/WebKitAgnosticTest.mm: Copied from Tools/TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm.
3372         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test): Code came from
3373         DynamicDeviceScaleFactor.WebKit.
3374         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test): Code came from
3375         DynamicDeviceScaleFactor.WebKit2.
3376
3377 2011-08-19  Adam Roben  <aroben@apple.com>
3378
3379         Clean up #includes in TestWebKitAPI
3380
3381         Fixes <http://webkit.org/b/66556> TestWebKitAPI's prefix header isn't very helpful
3382
3383         Reviewed by Anders Carlsson.
3384
3385         * TestWebKitAPI/TestWebKitAPIPrefix.h: Added wtf/Platform.h. Added gtest/gtest.h for C++
3386         files and WebKit/WebKit.h for ObjC files.
3387
3388         * TestWebKitAPI/InjectedBundleController.cpp:
3389         * TestWebKitAPI/JavaScriptTest.h:
3390         * TestWebKitAPI/PlatformUtilities.h:
3391         * TestWebKitAPI/PlatformWebView.h:
3392         * TestWebKitAPI/Test.h:
3393         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3394         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
3395         * TestWebKitAPI/Tests/WTF/VectorReverse.cpp:
3396         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
3397         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
3398         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
3399         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
3400         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
3401         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
3402         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
3403         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
3404         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
3405         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
3406         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
3407         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
3408         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
3409         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
3410         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
3411         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
3412         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
3413         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3414         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3415         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
3416         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
3417         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
3418         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
3419         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3420         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
3421         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
3422         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
3423         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
3424         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
3425         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
3426         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
3427         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
3428         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
3429         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
3430         * TestWebKitAPI/TestsController.cpp:
3431         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
3432         Removed now-unnecessary #includes. Moved #includes of Test.h in with the rest of the
3433         #includes since it is no longer a special header.
3434
3435 2011-08-18  Dirk Pranke  <dpranke@chromium.org>
3436
3437         new-run-webkit-tests hung while acquiring http lock on snow leopard bots
3438         https://bugs.webkit.org/show_bug.cgi?id=64886
3439
3440         Temporarily disable the http locking to work around the issue.
3441         I'm not actually sure if this is going to work or improve things
3442         much.
3443
3444         Reviewed by Ryosuke Niwa.
3445
3446         * Scripts/webkitpy/layout_tests/port/mac.py:
3447
3448 2011-08-18  Tony Chang  <tony@chromium.org>
3449
3450         add embedded png checksums to WebKitTestRunner
3451         https://bugs.webkit.org/show_bug.cgi?id=66494
3452
3453         Looks like WebKitTestRunner has never supported embedded checksums.  This copies
3454         some code from DRT and adds it to the WebKitTestRunner.
3455
3456         Reviewed by Darin Adler.
3457
3458         * WebKitTestRunner/CyclicRedundancyCheck.cpp: Copied from Tools/DumpRenderTree
3459         * WebKitTestRunner/CyclicRedundancyCheck.h: Copied from Tools/DumpRenderTree
3460         * WebKitTestRunner/GNUmakefile.am: Add new files
3461         * WebKitTestRunner/PixelDumpSupport.cpp: Copied from Tools/DumpRenderTree
3462         * WebKitTestRunner/PixelDumpSupport.h: Copied from Tools/DumpRenderTree
3463         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Add new files
3464         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
3465         (WTR::dumpBitmap): Refactor to use PixelDumpSupport.
3466         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3467         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3468         (WTR::dumpBitmap): Refactor to use PixelDumpSupport.
3469         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3470         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Add new files
3471
3472 2011-08-18  Shawn Singh  <shawnsingh@chromium.org>
3473
3474         https://bugs.webkit.org/show_bug.cgi?id=47240
3475
3476         Fixed a cygwin path problem in the chromium port of diff_image;
3477         Also made the return values of the diff_image function more consistent.
3478
3479         Reviewed by Dirk Pranke.
3480
3481         * Scripts/webkitpy/layout_tests/port/chromium.py:
3482
3483 2011-08-17  Alejandro G. Castro  <alex@igalia.com>
3484
3485         [GTK] Fix compilation problems with deprecations in gtk+
3486         https://bugs.webkit.org/show_bug.cgi?id=66073
3487
3488         Reviewed by Martin Robinson.
3489
3490         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3491         (main): G_CONST_RETURN was deprecated
3492         * GtkLauncher/main.c:
3493         (createWindow): Added gtk_box_new conditional compilation for
3494         gtk+-3.
3495         * MiniBrowser/gtk/BrowserWindow.c:
3496         (browser_window_init): Replaced gtk_vbox_new with gtk_box_new, we
3497         are just supporting gtk+-3 for WebKit2.
3498
3499 2011-08-18  Anders Carlsson  <andersca@apple.com>
3500
3501         Fix libc++ C++0x build
3502         https://bugs.webkit.org/show_bug.cgi?id=66479
3503
3504         Reviewed by Adam Roben.
3505
3506         Add missing includes.
3507
3508         * DumpRenderTree/LayoutTestController.cpp:
3509         * DumpRenderTree/mac/CheckedMalloc.cpp:
3510
3511 2011-08-18  Adam Roben  <aroben@apple.com>
3512
3513         Test that WebKit updates style when a WebView is moved between differently-scaled windows
3514
3515         Test for <http://webkit.org/b/66412> <rdar://problem/9971958> WebKit doesn't react when a
3516         WebView is moved between windows with different backing scale factors
3517
3518         Reviewed by Anders Carlsson.
3519
3520         * TestWebKitAPI/JavaScriptTest.cpp:
3521         (TestWebKitAPI::runJSTest): Moved a little bit of code from here...
3522         (TestWebKitAPI::compareJSResult): ...to here. Also made the error message more similar to
3523         gtest's built-in error messages.
3524
3525         * TestWebKitAPI/JavaScriptTest.h: Added overloads of runJSTest that take a WebView * and
3526         WKView * for convenience on Mac. Added compareJSResult helper function for implementing
3527         those overloads.
3528
3529         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
3530
3531         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm: Added.
3532         (-[FrameLoadDelegate initWithDidFinishLoadBoolean:]): Simple initializer.
3533         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): Record that the load finished.
3534         (TestWebKitAPI::didFinishLoadForFrame): Record that the load finished.
3535         (TestWebKitAPI::setPageLoaderClient): Set up the client.
3536         (TestWebKitAPI::DynamicDeviceScaleFactor::DynamicDeviceScaleFactor): Simple constructor.
3537         (TestWebKitAPI::DynamicDeviceScaleFactor::createWindow): Creates a
3538         SyntheticBackingScaleFactorWindow and returns it.
3539         (TestWebKitAPI::DynamicDeviceScaleFactor::runTest): Loads devicePixelRatio.html and checks
3540         that WebKit uses the correct scale factor when the WebView is not in a window, is put in a
3541         window, is moved to a differently-scaled window, and is taken out of the window.
3542         (TestWebKitAPI::DynamicDeviceScaleFactor::loadURL): Helper function with overloads for
3543         WebKit1 and WebKit2.
3544         (TestWebKitAPI::TEST_F): Runs the test, with overloads for WebKit1 and WebKit2.
3545
3546         * TestWebKitAPI/Tests/mac/devicePixelRatio.html: Added.
3547
3548         * TestWebKitAPI/mac/JavaScriptTestMac.mm: Added.
3549         (TestWebKitAPI::runJSTest): Fairly simple overloads for WebView * and WKView *.
3550
3551         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.h: Added.
3552         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m: Added.
3553         (-[SyntheticBackingScaleFactorWindow initWithContentRect:styleMask:backing:defer:]): Simple
3554         initializer.
3555         (-[SyntheticBackingScaleFactorWindow setBackingScaleFactor:]): Simple setter.
3556
3557         (-[SyntheticBackingScaleFactorWindow backingScaleFactor]):
3558         (-[SyntheticBackingScaleFactorWindow userSpaceScaleFactor]):
3559         Overrides of NSWindow methods that WebKit uses to determine the device scale factor.
3560
3561 2011-08-18  Dmitry Lomov  <dslomov@google.com>
3562
3563         https://bugs.webkit.org/show_bug.cgi?id=66425
3564         check-webkit-style should detect incorrectly formatted file change descriptions.
3565         Description, if present, should be separated from colon with a space.
3566
3567         Reviewed by David Levin.
3568
3569         * Scripts/webkitpy/style/checkers/changelog.py: Fix.
3570         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Unit tests.
3571
3572 2011-08-18  Adam Barth  <abarth@webkit.org>
3573
3574         webkit-patch pretty-diff should be shown in main help
3575         https://bugs.webkit.org/show_bug.cgi?id=66404
3576
3577         Reviewed by Dimitri Glazkov.
3578
3579         As requested by dglazkov.
3580
3581         * Scripts/webkitpy/tool/commands/prettydiff.py:
3582
3583 2011-08-17  Dmitry Lomov  <dslomov@google.com>
3584
3585         https://bugs.webkit.org/show_bug.cgi?id=66400
3586         Fix TestWebKitAPI build on Mac OS.
3587
3588         Reviewed by David Levin.
3589
3590         * TestWebKitAPI/Configurations/Base.xcconfig: Added ICU headers to the HEADER_SEARCH_PATH.
3591
3592 2011-08-17  Dimitri Glazkov  <dglazkov@chromium.org>
3593
3594         garden-o-matic spring cleaning: move scripts, styles, and images in the respective directories.
3595         https://bugs.webkit.org/show_bug.cgi?id=66427
3596
3597         Reviewed by Adam Barth.
3598
3599         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js: Removed.
3600         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js: Removed.
3601         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot_unittests.js: Removed.
3602         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js: Removed.
3603         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js: Removed.
3604         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js: Removed.
3605         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js: Removed.
3606         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js: Removed.
3607         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js: Removed.
3608         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js: Removed.
3609         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js: Removed.
3610         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js: Removed.
3611         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js: Removed.
3612         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NRWTResultsParser.js: Removed.
3613         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm.js: Removed.
3614         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm_unittests.js: Removed.
3615         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ORWTResultsParser.js: Removed.
3616         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/PersistentCache.js: Removed.
3617         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css: Removed.
3618         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js: Removed.
3619         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js: Removed.
3620         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js: Removed.
3621         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js: Removed.
3622         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities_unittests.js: Removed.
3623         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js: Removed.
3624         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBugzilla.js: Removed.
3625         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js: Removed.
3626         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Removed.
3627         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Removed.
3628         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/bugzilla_unittests.js: Removed.
3629         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js: Removed.
3630         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js: Removed.
3631         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js: Removed.
3632         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js: Removed.
3633         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js: Removed.
3634         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers: Removed.
3635         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js: Removed.
3636         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers/rebaseline.js: Removed.
3637         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-green.png: Removed.
3638         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-red.png: Removed.
3639         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
3640         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images: Added.
3641         * BuildSlaveSupport/build.webkit.org-config/public_html/T