WKWebView with no WKNavigationDelegate does not follow universal links
[WebKit-https.git] / Tools / ChangeLog
1 2016-06-21  Sam Weinig  <sam@webkit.org>
2
3         WKWebView with no WKNavigationDelegate does not follow universal links
4         <rdar://problem/24374110>
5         https://bugs.webkit.org/show_bug.cgi?id=158997
6
7         Reviewed by Dan Bernstein.
8
9         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
10         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDefaultNavigationDelegate.mm: Added.
11         Add a new test that shows that we have a default navigation delegate by swizzling
12         -[NSWorkspace openURL:]. This will only be called if there is a default client.
13
14 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
15
16         [Win] Implement modal dialog support in MiniBrowser.
17         https://bugs.webkit.org/show_bug.cgi?id=158976
18
19         Reviewed by Brent Fulgham.
20
21         * MiniBrowser/win/PrintWebUIDelegate.cpp:
22         (PrintWebUIDelegate::createWebViewWithRequest):
23         (getHandleFromWebView):
24         (PrintWebUIDelegate::webViewClose):
25         (PrintWebUIDelegate::setFrame):
26         (PrintWebUIDelegate::webViewFrame):
27         (PrintWebUIDelegate::canRunModal):
28         (findTopLevelParent):
29         (PrintWebUIDelegate::runModal):
30         (PrintWebUIDelegate::createModalDialog):
31         * MiniBrowser/win/PrintWebUIDelegate.h:
32         (PrintWebUIDelegate::webViewClose):
33         (PrintWebUIDelegate::setFrame):
34         (PrintWebUIDelegate::webViewFrame):
35         (PrintWebUIDelegate::canRunModal):
36         (PrintWebUIDelegate::runModal):
37
38 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
39
40         window.showModalDialog doesn't work in DumpRenderTree on Windows
41         https://bugs.webkit.org/show_bug.cgi?id=53675
42
43         Reviewed by Brent Fulgham.
44
45         Implement modal dialog support in DumpRenderTree.
46
47         * DumpRenderTree/win/UIDelegate.cpp:
48         (UIDelegate::canRunModal):
49         (getHandleFromWebView):
50         (UIDelegate::createModalDialog):
51         (findTopLevelParent):
52         (UIDelegate::runModal):
53         (UIDelegate::webViewClose):
54         * DumpRenderTree/win/UIDelegate.h:
55
56 2016-06-21  Aakash Jain  <aakash_jain@apple.com>
57
58         Fix formatting issues reported by check-webkit-style
59         https://bugs.webkit.org/show_bug.cgi?id=159008
60
61         Reviewed by Alexey Proskuryakov.
62
63         Fixed the formatting issues as reported by check-webkit-style in webkitpy/tool folder.
64         There is no functionality change.
65
66         * Scripts/webkitpy/tool/bot/irc_command.py:
67         (Restart.execute):
68         (Rollout):
69         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
70         (IRCBotTest.test_exception_during_command):
71         (IRCBotTest.test_exception_during_command.CommandWithException):
72         (IRCBotTest.test_exception_during_command.CommandWithException.execute):
73         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
74         (test_missing_unit_test_results_path):
75         (test_layout_test_results):
76         * Scripts/webkitpy/tool/bot/queueengine.py:
77         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
78         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
79         (AbstractSequencedCommand):
80         (AbstractSequencedCommand.__init__):
81         * Scripts/webkitpy/tool/commands/download.py:
82         (Land):
83         * Scripts/webkitpy/tool/commands/openbugs.py:
84         * Scripts/webkitpy/tool/commands/openbugs_unittest.py:
85         (OpenBugsTest):
86         * Scripts/webkitpy/tool/commands/queries.py:
87         (PatchesToCommitQueue):
88         (PatchesToCommitQueue.__init__):
89         (PatchesToCommitQueue._needs_commit_queue):
90         * Scripts/webkitpy/tool/commands/queries_unittest.py:
91         (PrintExpectationsTest.test_platform):
92         (PrintBaselinesTest):
93         (PrintBaselinesTest.setUp):
94         * Scripts/webkitpy/tool/commands/queues.py:
95         (AbstractQueue):
96         (AbstractQueue.__init__):
97         (AbstractQueue.execute):
98         * Scripts/webkitpy/tool/commands/queues_unittest.py:
99         (test_auto_retry):
100         * Scripts/webkitpy/tool/commands/rebaseline.py:
101         (AbstractParallelRebaselineCommand._files_to_add):
102         (AbstractParallelRebaselineCommand):
103         (AbstractParallelRebaselineCommand._rebaseline):
104         * Scripts/webkitpy/tool/commands/setupgitclone.py:
105         (SetupGitClone):
106         * Scripts/webkitpy/tool/commands/sheriffbot.py:
107         * Scripts/webkitpy/tool/commands/stepsequence.py:
108         * Scripts/webkitpy/tool/commands/upload.py:
109         (PostCommits._comment_text_for_commit):
110         (PostCommits):
111         (PostCommits.execute):
112         (MarkBugFixed):
113         (MarkBugFixed.__init__):
114         * Scripts/webkitpy/tool/commands/upload_unittest.py:
115         (UploadCommandsTest):
116         (UploadCommandsTest.test_commit_message_for_current_diff):
117         * Scripts/webkitpy/tool/grammar_unittest.py:
118         (GrammarTest):
119         (GrammarTest.test_join_with_separators):
120         * Scripts/webkitpy/tool/multicommandtool.py:
121         (HelpCommand.__init__):
122         (HelpCommand):
123         (HelpCommand._help_epilog):
124         (HelpCommand._remove_help_options):
125         (MultiCommandTool):
126         (MultiCommandTool.__init__):
127         (MultiCommandTool.main):
128         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
129         (TrivialCommand):
130         (TrivialCommand.__init__):
131         (MultiCommandToolTest):
132         (MultiCommandToolTest._assert_tool_main_outputs):
133         (MultiCommandToolTest.test_retry):
134         (test_command_help):
135         * Scripts/webkitpy/tool/steps/__init__.py:
136         * Scripts/webkitpy/tool/steps/abstractstep.py:
137         * Scripts/webkitpy/tool/steps/applypatch.py:
138         * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
139         (ApplyPatchWithLocalCommit):
140         (ApplyPatchWithLocalCommit.options):
141         * Scripts/webkitpy/tool/steps/build.py:
142         * Scripts/webkitpy/tool/steps/checkstyle.py:
143         (CheckStyle):
144         (CheckStyle.options):
145         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
146         * Scripts/webkitpy/tool/steps/closebug.py:
147         * Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
148         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
149         (CloseBugForLandDiffTest):
150         (CloseBugForLandDiffTest.test_empty_state):
151         * Scripts/webkitpy/tool/steps/closepatch.py:
152         * Scripts/webkitpy/tool/steps/commit.py:
153         (Commit.run):
154         * Scripts/webkitpy/tool/steps/confirmdiff.py:
155         * Scripts/webkitpy/tool/steps/editchangelog.py:
156         * Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
157         * Scripts/webkitpy/tool/steps/metastep.py:
158         (MetaStep):
159         (MetaStep.__init__):
160         (MetaStep.run):
161         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
162         * Scripts/webkitpy/tool/steps/options.py:
163         (Options):
164         * Scripts/webkitpy/tool/steps/postdiff.py:
165         * Scripts/webkitpy/tool/steps/postdiffforcommit.py:
166         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
167         * Scripts/webkitpy/tool/steps/preparechangelog.py:
168         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
169         (PrepareChangeLogTest):
170         (PrepareChangeLogTest.test_resolve_existing_entry):
171         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
172         * Scripts/webkitpy/tool/steps/promptforbugortitle.py:
173         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
174         * Scripts/webkitpy/tool/steps/revertrevision.py:
175         * Scripts/webkitpy/tool/steps/runtests.py:
176         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
177         * Scripts/webkitpy/tool/steps/steps_unittest.py:
178         (StepsTest):
179         (StepsTest._step_options):
180         * Scripts/webkitpy/tool/steps/update.py:
181         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
182         (UpdateChangeLogsWithReviewerTest):
183         (UpdateChangeLogsWithReviewerTest.test_guess_reviewer_from_bug):
184         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
185         * Scripts/webkitpy/tool/steps/validatereviewer.py:
186
187 2016-06-21  Chris Dumez  <cdumez@apple.com>
188
189         Unreviewed, rolling out r202296.
190
191         Broke basic browsing in Safari
192
193         Reverted changeset:
194
195         "WKWebView with no WKNavigationDelegate does not follow
196         universal links"
197         https://bugs.webkit.org/show_bug.cgi?id=158997
198         http://trac.webkit.org/changeset/202296
199
200 2016-06-21  Anders Carlsson  <andersca@apple.com>
201
202         Fix build.
203
204         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
205
206 2016-06-21  Anders Carlsson  <andersca@apple.com>
207
208         Begin moving the Apple Pay code to the open source repository
209         https://bugs.webkit.org/show_bug.cgi?id=158998
210
211         Reviewed by Tim Horton.
212
213         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
214         Add ENABLE_APPLE_PAY.
215
216 2016-06-21  Said Abou-Hallawa  <sabouhallawa@apple,com>
217
218         Add system tracing points for requestAnimationFrame() workflow
219         https://bugs.webkit.org/show_bug.cgi?id=158723
220
221         Reviewed by Simon Fraser.
222
223         Add new plist entries to be used by kdebug_trace() viewing tools.
224
225         * Tracing/SystemTracePoints.plist:
226
227 2016-06-21  Sam Weinig  <sam@webkit.org>
228
229         WKWebView with no WKNavigationDelegate does not follow universal links
230         <rdar://problem/24374110>
231         https://bugs.webkit.org/show_bug.cgi?id=158997
232
233         Reviewed by Dan Bernstein.
234
235         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
236         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDefaultNavigationDelegate.mm: Added.
237         Add a new test that shows that we have a default navigation delegate by swizzling
238         -[NSWorkspace openURL:]. This will only be called if there is a default client.
239
240 2016-06-21  Aakash Jain  <aakash_jain@apple.com>
241
242         run-javascriptcore-tests should have flag to skip mozilla tests
243         https://bugs.webkit.org/show_bug.cgi?id=158963
244         rdar://problem/25838924
245
246         Reviewed by Alexey Proskuryakov.
247
248         * Scripts/run-javascriptcore-tests:
249         (runJSCStressTests): Added flag to skip mozilla tests.
250
251 2016-06-20  Commit Queue  <commit-queue@webkit.org>
252
253         Unreviewed, rolling out r202136.
254         https://bugs.webkit.org/show_bug.cgi?id=158932
255
256         JSBench wasn't regressed by r202002 and r202111 on iOS after
257         all (Requested by rniwa_ on #webkit).
258
259         Reverted changeset:
260
261         "Unreviewed, rolling out r202002 and r202111."
262         https://bugs.webkit.org/show_bug.cgi?id=158638
263         http://trac.webkit.org/changeset/202136
264
265 2016-06-20  Keith Rollin  <krollin@apple.com>
266
267         Remove RefPtr::release() and change calls sites to use WTFMove()
268         https://bugs.webkit.org/show_bug.cgi?id=158369
269
270         Reviewed by Chris Dumez.
271
272         RefPtr::release() releases its managed pointer awkwardly. It's more
273         direct and clearer to use WTFMove to transfer ownership of the managed
274         pointer.
275
276         As part of this cleanup, also change a lot of explicit data types to
277         'auto'.
278
279         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
280         (createBitmapContextFromWebView):
281         (createPagedBitmapContext):
282         * DumpRenderTree/mac/TestRunnerMac.mm:
283         (TestRunner::setMockGeolocationPosition):
284         * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp:
285         (TestWebKitAPI::TEST):
286         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
287         (TestWebKitAPI::TEST):
288
289 2016-06-20  Tim Horton  <timothy_horton@apple.com>
290
291         Add a API test for *DeferringViewInWindowChanges as fixed in r202230
292         https://bugs.webkit.org/show_bug.cgi?id=158947
293
294         Reviewed by Simon Fraser.
295
296         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
297         * TestWebKitAPI/Tests/WebKit2/DeferredViewInWindowStateChange.mm: Added.
298         (TestWebKitAPI::didFinishLoadForFrame):
299         (TestWebKitAPI::setPageLoaderClient):
300         (TestWebKitAPI::TEST):
301         Add a test ensuring that in-window state changes are deferred when using
302         the SPI for deferring them, as fixed in r202230.
303
304 2016-06-20  Fujii Hironori  <Hironori.Fujii@sony.com>
305
306         WebKitTestRunner: Missing \n at the line of "#PROCESS UNRESPONSIVE"
307         https://bugs.webkit.org/show_bug.cgi?id=158931
308
309         Reviewed by Alexey Proskuryakov.
310
311         * WebKitTestRunner/TestInvocation.cpp:
312         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Appended missing \n at the end of line.
313
314 2016-06-17  Alexey Proskuryakov  <ap@apple.com>
315
316         Add test expectations for macOS Sierra
317         https://bugs.webkit.org/show_bug.cgi?id=158903
318
319         Reviewed by Alex Christensen.
320
321         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png: Added.
322         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png: Added.
323         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
324         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
325         Added dashboard support.
326
327         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
328         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
329         Trigger the right build queues on check-in.
330
331         * Scripts/webkitpy/common/system/platforminfo.py:
332         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
333         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
334         * Scripts/webkitpy/port/mac.py:
335         * Scripts/webkitpy/port/mac_unittest.py:
336         * TestResultServer/static-dashboards/flakiness_dashboard.js:
337         Added cases for Sierra, and updated tests for new baseline search paths.
338
339 2016-06-19  Alexey Proskuryakov  <ap@apple.com>
340
341         Another buid fix for master.cfg.
342
343         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
344         (CompileWebKit.start):
345
346 2016-06-19  Alexey Proskuryakov  <ap@apple.com>
347
348         Another buid fix for master.cfg.
349
350         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
351         (CompileWebKit.start):
352
353 2016-06-19  Lucas Forschler  <lforschler@apple.com>
354
355         Fix master.cfg
356         
357         Unreviewed build fix.
358
359         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
360         (CompileWebKit.start):
361
362 2016-06-19  Lucas Forschler  <lforschler@apple.com>
363
364         Test another commit.
365         
366         Unreviewed.
367
368 2016-06-19  Lucas Forschler  <lforschler@apple.com>
369
370         Testing fix for trac-mirror.
371         
372         Unreviewed.
373
374 2016-06-19  Lucas Forschler  <lforschler@apple.com>
375
376         Test a commit against the SVN 1.9 server upgrade.
377         
378         Unreviewed.
379         
380 2016-06-17  Daniel Bates  <dabates@apple.com>
381
382         Unreviewed, rolling out r202186.
383
384         Broke the Apple Windows, Apple Yosemite, GTK, and WinCairo
385         builds.
386
387         Reverted changeset:
388
389         "File scheme should not allow access of a resource on a
390         different volume."
391         https://bugs.webkit.org/show_bug.cgi?id=158552
392         http://trac.webkit.org/changeset/202186
393
394 2016-06-17  Pranjal Jumde  <pjumde@apple.com>
395
396         File scheme should not allow access of a resource on a different volume.
397         https://bugs.webkit.org/show_bug.cgi?id=158552
398         <rdar://problem/15307582>
399
400         Reviewed by Brent Fulgham.
401
402         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
403         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
404         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
405         (-[CrossPartitionFileSchemeAccessNavigationDelegate webView:didFinishNavigation:]):
406         When the main page load is complete fetch the contents of the document to check if iframe was loaded
407         (createPartition):
408         Create a disk image and load the contents of the file.
409         (cleanUp):
410         (TestWebKitAPI::TEST):
411
412 2016-06-17  Enrique Ocaña González  <eocanha@igalia.com>
413
414         Unreviewed. Added myself to the list of committers.
415
416         * Scripts/webkitpy/common/config/contributors.json:
417
418 2016-06-16  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
419
420         [EFL][GTK] LayoutTest doesn't run on Ubuntu 16.04
421         https://bugs.webkit.org/show_bug.cgi?id=158141
422
423         Reviewed by Michael Catanzaro.
424
425         * Scripts/webkitpy/port/base.py: Detect php version in system, then use it.
426         (Port._is_debian_php_version_7):
427         (Port._debian_php_version):
428         (Port._apache_config_file_name_for_platform):
429         * efl/install-dependencies:
430         * gtk/install-dependencies:
431
432 2016-06-16  Filip Pizlo  <fpizlo@apple.com>
433
434         Baseline JIT should be concurrent
435         https://bugs.webkit.org/show_bug.cgi?id=158755
436
437         Reviewed by Geoffrey Garen.
438         
439         Need to disable concurrent JIT when running profiler tests. We should have been doing this
440         all along.
441
442         * Scripts/run-jsc-stress-tests:
443
444 2016-06-16  Per Arne Vollan  <pvollan@apple.com>
445
446         [Win] Accessibility implementation unable to recurse through document (sometimes) to find named elements
447         https://bugs.webkit.org/show_bug.cgi?id=140798
448
449         Reviewed by Brent Fulgham.
450        
451         Make sure layout is up-to-date before trying to find named elements. 
452
453         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
454         (AccessibilityController::rootElement):
455
456 2016-06-16  Chris Dumez  <cdumez@apple.com>
457
458         Unreviewed, rolling out r202002 and r202111.
459
460         Ryosuke says this was a JSBench regression on iOS
461
462         Reverted changesets:
463
464         "Make HashMap and HashSet work with Refs"
465         https://bugs.webkit.org/show_bug.cgi?id=158638
466         http://trac.webkit.org/changeset/202002
467
468         "Improve HashMap and HashSet support for Ref"
469         https://bugs.webkit.org/show_bug.cgi?id=158789
470         http://trac.webkit.org/changeset/202111
471
472 2016-06-15  Simon Fraser  <simon.fraser@apple.com>
473
474         [iOS WK2] On iPad, indirect focussing of a text field doesn't always scroll to the correct location
475         https://bugs.webkit.org/show_bug.cgi?id=158828
476
477         Reviewed by Enrica Casucci.
478         
479         Expose "forceIPadStyleZoomOnInputFocus" on UIScriptController, which allows iPad-style
480         zooming behavior on <input> focus in the iPhone simulator, which is used for testing.
481
482         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
483         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
484         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus):
485         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus):
486         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
487         * WebKitTestRunner/ios/TestControllerIOS.mm:
488         (WTR::TestController::platformResetStateToConsistentValues):
489         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
490         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus):
491         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus):
492
493 2016-06-15  Sam Weinig  <sam@webkit.org>
494
495         Forward/Back keyboard shortcuts need to flip for RTL
496         https://bugs.webkit.org/show_bug.cgi?id=158823
497         <rdar://problem/25975359>
498
499         Reviewed by Darin Adler.
500
501         Add tests for flipping the behavior of command-left and command-right
502         under RTL mode.
503
504         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
505         * TestWebKitAPI/Tests/WebKit2Cocoa/CommandBackForward.mm: Added.
506         (-[CommandBackForwardOffscreenWindow isKeyWindow]):
507         (-[CommandBackForwardOffscreenWindow isVisible]):
508         (simulateCommandArrow):
509         (WebKit2_CommandBackForwardTest::SetUp):
510         (WebKit2_CommandBackForwardTestWKView::didFinishLoadForFrame):
511         (WebKit2_CommandBackForwardTestWKView::SetUp):
512         (WebKit2_CommandBackForwardTestWKView::loadFiles):
513         (-[CommandBackForwardNavigationDelegate webView:didFinishNavigation:]):
514         (WebKit2_CommandBackForwardTestWKWebView::SetUp):
515         (WebKit2_CommandBackForwardTestWKWebView::loadFiles):
516
517 2016-06-15  Tim Horton  <timothy_horton@apple.com>
518
519         Expose _shouldExpandContentToViewHeightForAutoLayout SPI on WKWebView
520         https://bugs.webkit.org/show_bug.cgi?id=158824
521         <rdar://problem/23713857>
522
523         Reviewed by Simon Fraser.
524
525         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
526         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:]):
527         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]):
528         (-[AutoLayoutWKWebView layoutAtMinimumWidth:andExpectContentSizeChange:resettingWidth:]):
529         (TEST):
530         Add a test for _shouldExpandContentToViewHeightForAutoLayout.
531
532 2016-06-13  Simon Fraser  <simon.fraser@apple.com>
533
534         [iOS WK2] Make it possible to test the Next/Previous buttons in the keyboard accessory bar
535         https://bugs.webkit.org/show_bug.cgi?id=158714
536
537         Reviewed by Enrica Casucci.
538
539         Add UIScriptController.keyboardAccessoryBar{Next,Previous} and hook it up to the WKContentView
540         method that gets called from UIKit.
541
542         Add a test that exercises it.
543
544         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
545         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
546         (WTR::UIScriptController::keyboardAccessoryBarNext):
547         (WTR::UIScriptController::keyboardAccessoryBarPrevious):
548         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
549         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
550         (WTR::UIScriptController::keyboardAccessoryBarNext):
551         (WTR::UIScriptController::keyboardAccessoryBarPrevious):
552
553 2016-06-15  Sam Weinig  <sam@webkit.org>
554
555         Improve HashMap and HashSet support for Ref
556         https://bugs.webkit.org/show_bug.cgi?id=158789
557
558         Reviewed by Chris Dumez.
559
560         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
561         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
562         Add more cases to WTF_HashMap.Ref_Key, WTF_HashMap.Ref_Value and WTF_HashSet.Ref
563
564 2016-06-15  Aakash Jain  <aakash_jain@apple.com>
565
566         Too much log data generated during layout-tests on iOS Simulator
567         https://bugs.webkit.org/show_bug.cgi?id=158751
568
569         Reviewed by Alexey Proskuryakov.
570
571         * Scripts/webkitpy/port/ios.py:
572         (IOSSimulatorPort.developer_dir): memoized the property so that it is not called
573         repeatedly.
574
575 2016-06-15  Per Arne Vollan  <pvollan@apple.com>
576
577         [Win][CMake] Changes in WebKit options are not reflected in incremental builds.
578         https://bugs.webkit.org/show_bug.cgi?id=158727
579
580         Reviewed by Alex Christensen.
581
582         Delete CMake cache file if WebKit options have been modified.
583
584         * Scripts/build-webkit:
585         * Scripts/webkitdirs.pm:
586         (shouldRemoveCMakeCache):
587
588 2016-06-15  Romain Bellessort  <romain.bellessort@crf.canon.fr>
589
590         Enabling Shadow DOM for all platforms
591         https://bugs.webkit.org/show_bug.cgi?id=158738
592
593         Reviewed by Ryosuke Niwa.
594
595         Removed Shadow DOM from options (enabled by default)
596
597         * Scripts/webkitperl/FeatureList.pm:
598         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
599
600 2016-06-15  Per Arne Vollan  <pvollan@apple.com>
601
602         [Win] The test accessibility/selected-text-range-aria-elements.html is failing.
603         https://bugs.webkit.org/show_bug.cgi?id=158732
604
605         Reviewed by Brent Fulgham.
606
607         Implement selectedTextRange() method.
608
609         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
610         (AccessibilityUIElement::selectedTextRange):
611
612 2016-06-15  Per Arne Vollan  <pvollan@apple.com>
613
614         [Win] MiniBrowser is not DPI aware.
615         https://bugs.webkit.org/show_bug.cgi?id=158733
616
617         Reviewed by Brent Fulgham.
618
619         Call Win32 api function to let Windows know that we will scale the contents ourselves.
620
621         * MiniBrowser/win/WinMain.cpp:
622         (wWinMain):
623
624 2016-06-15  Per Arne Vollan  <pvollan@apple.com>
625
626         Unreviewed: add new email address to contributors.json.
627
628         * Scripts/webkitpy/common/config/contributors.json:
629
630 2016-06-14  Keith Miller  <keith_miller@apple.com>
631
632         JSBench should use geometric mean
633         https://bugs.webkit.org/show_bug.cgi?id=158775
634
635         Reviewed by Mark Lam.
636
637         For some reason JSBench was using algebraic mean. Since each test
638         is pretty substantially different it should use geometric mean
639         instead.
640
641         * Scripts/run-jsc-benchmarks:
642
643 2016-06-14  Alexey Proskuryakov  <ap@apple.com>
644
645         Debug crash logs are not fully symbolicated on Yosemite
646         https://bugs.webkit.org/show_bug.cgi?id=158760
647
648         Reviewed by Darin Adler.
649
650         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Don't enable dSYM generation
651         for debug builds on Yosemite.
652
653 2016-06-14  Alexey Proskuryakov  <ap@apple.com>
654
655         Tests don't work in iOS Simulator when ASan is enabled
656         https://bugs.webkit.org/show_bug.cgi?id=158726
657
658         Reviewed by David Kilzer.
659
660         * Scripts/webkitpy/port/driver.py:
661         (Driver._setup_environ_for_driver): Added a FIXME.
662         * Scripts/webkitpy/port/ios.py:
663         (IOSSimulatorPort.setup_environ_for_server): Don't try to insert a dylib built for
664         simulator into LayoutTestRelay, which is a macOS tool.
665
666 2016-06-14  Aakash Jain  <aakash_jain@apple.com>
667
668         Continuous "Reentrancy avoided" error messages in run-webkit-tests if Simulator quits unexpectedly
669         https://bugs.webkit.org/show_bug.cgi?id=158756
670
671         Reviewed by Alexey Proskuryakov.
672
673         * Scripts/webkitpy/xcode/simulator.py:
674         (Simulator.wait_until_device_is_booted): If checking Simulator boot state fails, verify if
675         the "simulator device" is still in booted state. Since we ensured that simulator device 
676         was in booted state earlier in this method, this indicates that simulator device has shut down
677         unexpectedly.
678
679 2016-06-14  David Kilzer  <ddkilzer@apple.com>
680
681         Follow-up fix #2: REGRESSION (r202020): El Capitan CMake Debug build broken
682         <https://webkit.org/b/158743>
683
684         Unreviewed build fix.
685
686         * DumpRenderTree/PlatformMac.cmake: Fix silly typo.
687
688 2016-06-14  Aakash Jain  <aakash_jain@apple.com>
689
690         Too much log data generated during layout-tests on iOS Simulator
691         https://bugs.webkit.org/show_bug.cgi?id=158751
692
693         Reviewed by Alexey Proskuryakov.
694
695         * Scripts/webkitpy/port/ios.py:
696         (IOSSimulatorPort._quit_ios_simulator): Do not use -v flag.
697         (IOSSimulatorPort.clean_up_test_run): Ditto.
698         (IOSSimulatorPort._createSimulatorApp): Ditto.
699
700 2016-06-14  David Kilzer  <ddkilzer@apple.com>
701
702         Follow-up fix: REGRESSION (r202020): El Capitan CMake Debug build broken
703         <https://webkit.org/b/158743>
704
705         Unreviewed build fix.
706
707         The fix in r202056 clobbered DumpRenderTree_SOURCES and
708         TestNetscapePlugin_SOURCES from DumpRenderTree/CMakeLists.txt,
709         so the build failure is now that we're not building the common
710         sources.
711
712         Fix that by saving the common sources (which are all C++ source
713         files) into *_Cpp_SOURCES lists first, then setting the compiler
714         flags, then creating the final *_SOURCES lists.
715
716         * DumpRenderTree/PlatformMac.cmake: Add
717         ${TestNetscapePlugin_Cpp_SOURCES} to list that needs
718         "-std=c++14" compiler switch.
719         (TestNetscapePlugin_Cpp_SOURCES): Add new list for C++ source
720         files for TestNetscapePlugin.  Seeded with
721         ${TestNetscapePlugin_SOURCES} from CMakeLists.txt.
722         (TestNetscapePlugin_SOURCES): Add
723         ${TestNetscapePlugin_Cpp_SOURCES} to the list of files.
724         (DumpRenderTree_Cpp_SOURCES): Seed list for C++ source files
725         with ${DumpRenderTree_SOURCES} from CMakeLists.txt.
726         (DumpRenderTree_SOURCES): Reformat and sort source lists.
727
728 2016-06-14  David Kilzer  <ddkilzer@apple.com>
729
730         REGRESSION (r202020): El Capitan CMake Debug build broken
731         <https://webkit.org/b/158743>
732
733         Reviewed by Alex Christensen.
734
735         The bug was that pure C++ source files (and Objective-C source
736         files) were being compiled as Objective-C++ source files.  This
737         is obviously incorrect, so the fix was to split out the list of
738         source files by language, then define compiler switches based on
739         each file type.
740
741         * DumpRenderTree/PlatformMac.cmake: Replace add_definitions()
742         with separate foreach loops that set compiler flags based on
743         each source file's type.
744         (TestNetscapePlugin_ObjCpp_SOURCES): Rename from
745         TestNetscapePlugin_SOURCES.
746         (TestNetscapePlugin_SOURCES): Create based on
747         ${TestNetscapePlugin_ObjCpp_SOURCES}.
748         (DumpRenderTree_ObjC_SOURCES): Split from DumpRenderTree_SOURCES.
749         (DumpRenderTree_Cpp_SOURCES): Ditto.
750         (DumpRenderTree_ObjCpp_SOURCES): Ditto.
751         (DumpRenderTree_SOURCES): Create from above three lists.
752
753 2016-06-14  Lucas Forschler  <lforschler@apple.com>
754
755         <rdar://problem/26685782>
756         Teach the copy-webkitlibraries-to-product-directory script about WebKitSystemInterfaceOSX10.12
757
758         Rubber-stamped by Jessie Berlin.
759
760         * Scripts/copy-webkitlibraries-to-product-directory:
761
762 2016-06-14  Youenn Fablet  <youenn.fablet@crf.canon.fr>
763
764         Activate CMake export compile commands option
765         https://bugs.webkit.org/show_bug.cgi?id=158734
766
767         Reviewed by Alex Christensen.
768
769         * Scripts/webkitdirs.pm:
770         (generateBuildSystemFromCMakeProject): Activating this option for all CMake builds.
771         This allows using ymcd for WebKit hacking.
772
773 2016-06-14  David Kilzer  <ddkilzer@apple.com>
774
775         Modernize DumpRenderTreeMac.h
776         <https://webkit.org/b/158721>
777
778         Reviewed by Andy Estes.
779
780         * DumpRenderTree/mac/DumpRenderTreeMac.h:
781         - Update copyright.
782         - Update license.
783         - Use #pragma once.
784         - Use OBJC_CLASS macro.
785
786 2016-06-13  David Kilzer  <ddkilzer@apple.com>
787
788         False-positive over-release of WebView in destroyWebViewAndOffscreenWindow() in DumpRenderTree.mm
789         <https://webkit.org/b/158716>
790
791         Reviewed by Andy Estes.
792
793         * DumpRenderTree/mac/DumpRenderTree.mm:
794         (destroyWebViewAndOffscreenWindow): Change this function to take
795         a WebView, and assert that it's the same as [mainFrame webView].
796         (dumpRenderTree): Pass 'webView' into
797         destroyWebViewAndOffscreenWindow().
798         * DumpRenderTree/mac/DumpRenderTreeMac.h:
799         (createWebViewAndOffscreenWindow): Add NS_RETURNS_RETAINED since
800         this function returns a +1 WebView.  Declare this method only for
801         Objective-C[++] source.
802
803 2016-06-13  Sam Weinig  <sam@webkit.org>
804
805         Make HashMap and HashSet work with Refs
806         https://bugs.webkit.org/show_bug.cgi?id=158638
807
808         Reviewed by Darin Adler.
809
810         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
811         (TestWebKitAPI::TEST):
812         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
813         (TestWebKitAPI::TEST):
814         Add tests for using Refs in HashMaps (both as key and value) and HashSets.
815
816 2016-06-13  Mark Lam  <mark.lam@apple.com>
817
818         Add a mechanism for collecting LLINT stats.
819         https://bugs.webkit.org/show_bug.cgi?id=158668
820
821         Reviewed by Filip Pizlo.
822
823         * DumpRenderTree/mac/DumpRenderTree.mm:
824         (DumpRenderTreeMain):
825
826 2016-06-13  Romain Bellessort  <romain.bellessort@crf.canon.fr>
827
828         [GTK] Enabling Shadow DOM by default
829         https://bugs.webkit.org/show_bug.cgi?id=158686
830
831         Reviewed by Carlos Garcia Campos.
832
833         Added support for enabling Shadow DOM by default for GTK.
834         Changed GTK test expectations for fast/shadow-dom tests (most tests
835         pass).
836
837         * Scripts/webkitperl/FeatureList.pm:
838
839 2016-06-12  Aakash Jain  <aakash_jain@apple.com>
840
841         run-safari/run-webkit-app fail to quit iOS simulator after Xcode installation
842         https://bugs.webkit.org/show_bug.cgi?id=158651
843         rdar://problem/26499824
844
845         Reviewed by Daniel Bates.
846
847         This change is to make our tools more robust. Sometimes run-safari/run-webkit-app fails 
848         to start the tests as one of the first thing these scripts do is to relaunch iOS Simulators,
849         and in process call quitIOSSimulator. In case the Simulator is not registered in LaunchServices
850         for some reason, quitIOSSimulator fails and the script stops. This change will make the scripts
851         still continue when they fail to quit iOS Simuator, and modify the way Simulator is opened, 
852         so that Simulator is implicitly registered with LaunchServices while opening it.
853
854         * Scripts/webkitdirs.pm:
855         (relaunchIOSSimulator):
856         Launch iOS Simulator using complete path. Partially reverting http://trac.webkit.org/changeset/184202.
857         (quitIOSSimulator):
858         Do not die if quitting ios Simulator fails, so that relaunchIOSSimulator can still 
859         attempt to launch the simulator.
860         (waitUntilIOSSimulatorDeviceIsInState):
861         Added a FIXME.
862
863 2016-06-11  Myles C. Maxfield  <mmaxfield@apple.com>
864
865         Addressing post-review comments after r201978.
866         https://bugs.webkit.org/show_bug.cgi?id=158649
867         <rdar://problem/13258122>
868
869         Unreviewed.
870
871         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
872         (TestWebKitAPI::TEST):
873
874 2016-06-11  Alexey Proskuryakov  <ap@apple.com>
875
876         Unreviewed leak fix after r201863.
877
878         * DumpRenderTree/mac/DumpRenderTree.mm:
879         (dumpFramesAsText):
880
881 2016-06-11  Myles C. Maxfield  <mmaxfield@apple.com>
882
883         [Cocoa] Map commonly used Chinese Windows font names to names present on Cocoa operating systems
884         https://bugs.webkit.org/show_bug.cgi?id=158649
885         <rdar://problem/13258122>
886
887         Reviewed by Darin Adler.
888
889         * TestWebKitAPI/Tests/WTF/WTFString.h:
890         (TestWebKitAPI::TEST):
891
892 2016-06-10  Alex Christensen  <achristensen@webkit.org>
893
894         Fix CMake build.
895
896         * TestWebKitAPI/PlatformMac.cmake:
897
898 2016-06-10  Filip Pizlo  <fpizlo@apple.com>
899
900         Rename JSAir to Air.js
901
902         Rubber stamped by Mark Lam.
903
904         * Scripts/run-javascriptcore-tests:
905
906 2016-06-10  Filip Pizlo  <fpizlo@apple.com>
907
908         JSC Stress Test failing: jsair-tests.yaml/test.js.ftl-eager-no-cjit
909         https://bugs.webkit.org/show_bug.cgi?id=158571
910
911         Reviewed by Keith Miller.
912         
913         Unskip the JSAir test.
914
915         * Scripts/run-javascriptcore-tests:
916         (runJSCStressTests):
917
918 2016-06-10  Sam Weinig  <sam@webkit.org>
919
920         Re-disable the UserMedia tests which are timing out.
921
922         They used to be accidentally disabled, due to not including
923         the FeatureDefines correctly, but not we explicitly disable it.
924
925         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
926         (TestWebKitAPI::TEST):
927
928 2016-06-10  Alex Christensen  <achristensen@webkit.org>
929
930         Introduce WTF::UniqueRef
931         https://bugs.webkit.org/show_bug.cgi?id=158596
932
933         Reviewed by Brady Eidson.
934
935         * TestWebKitAPI/CMakeLists.txt:
936         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
937         * TestWebKitAPI/Tests/WTF/UniqueRef.cpp: Added.
938         (TestWebKitAPI::B::B):
939         (TestWebKitAPI::C::C):
940         (TestWebKitAPI::function):
941         (TestWebKitAPI::TEST):
942
943 2016-06-10  Sam Weinig  <sam@webkit.org>
944
945         Refactor TestWebKitAPI to allow just testing WTF
946         https://bugs.webkit.org/show_bug.cgi?id=158625
947
948         Reviewed by Tim Horton.
949
950         Extract all the WTF tests into a new target to allow a faster build / test / fix
951         cycle when working on WTF bugs and features.
952         
953         By calling `run-api-tests --wtf-only`, you don't need to have a build of JavaScriptCore/WebCore/etc
954         to test WTF only changes.
955
956         * Scripts/build-api-tests:
957         * Scripts/run-api-tests:
958         (buildTestTool):
959         (testToolPaths):
960         Add new options to build-api-tests and run-api-tests to only build/run the WTF test runner.
961
962         * TestWebKitAPI/CMakeLists.txt:
963         * TestWebKitAPI/Configurations/TestWTF.xcconfig: Added.
964         * TestWebKitAPI/Configurations/TestWTFLibrary.xcconfig: Added.
965         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
966         Add two new targets, TestWTFLibrary which contains all the WTF tests, and TestWTF,
967         the test runner that runs the WTF tests.
968     
969         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
970         Use Utilities.h rather than PlatformUtilities.h.
971
972         * TestWebKitAPI/Utilities.h: Added.
973         * TestWebKitAPI/PlatformUtilities.h:
974         * TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm:
975         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm: Added.
976         Move the sleep and run functions into a new Utilities.h/cpp file. This file contains utilities
977         that don't depend on anything in the WebKit project. 
978
979 2016-06-10  Brady Eidson  <beidson@apple.com>
980
981         REGRESSION(r201928?) API test WTF.StringOperators failing
982         https://bugs.webkit.org/show_bug.cgi?id=158623
983
984         Unreviewed, but buddy coded with Alex Christensen.
985
986         * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
987         (TestWebKitAPI::LifetimeLogger::fullName): Only one file in all of TestWebKitAPI is allowed
988           to use string concatenation, otherwise the linker will mess up on the symbol related to
989           this bizarre WTF_STRINGTYPEADAPTER_COPIED_WTF_STRING macro expansion.
990
991 2016-06-10  Brady Eidson  <beidson@apple.com>
992
993         WTF_CrossThreadTask.Basic fails in all non mac ports.
994         https://bugs.webkit.org/show_bug.cgi?id=158612
995
996         Reviewed by Alex Christensen.
997
998         The test is very sensitive to argument evaluation order which is explicitly undefined in C++.
999         
1000         Instead, we should just count the appropriate events to forget their order.
1001         
1002         * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
1003         (TestWebKitAPI::LifetimeLogger::LifetimeLogger):
1004         (TestWebKitAPI::LifetimeLogger::~LifetimeLogger):
1005         (TestWebKitAPI::LifetimeLogger::isolatedCopy):
1006         (TestWebKitAPI::LifetimeLogger::fullName):
1007         (TestWebKitAPI::testFunction):
1008         (TestWebKitAPI::TEST):
1009         (TestWebKitAPI::LifetimeLogger::log): Deleted.
1010         (TestWebKitAPI::LifetimeLogger::takeLogStr): Deleted.
1011
1012 2016-06-09  Alex Christensen  <achristensen@webkit.org>
1013
1014         Clean up Tools *.vcxproj after switching to CMake.
1015
1016         * DumpRenderTree/DumpRenderTree.sln: Removed.
1017         * DumpRenderTree/DumpRenderTree.vcxproj: Removed.
1018         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin: Removed.
1019         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.def: Removed.
1020         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.rc: Removed.
1021         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/resource.h: Removed.
1022         * DumpRenderTree/PlatformWin.cmake:
1023         * DumpRenderTree/win/TestNetscapePlugin.def: Copied from DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.def.
1024         * DumpRenderTree/win/TestNetscapePlugin.rc: Copied from DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.rc.
1025         * DumpRenderTree/win/resource.h: Copied from DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/resource.h.
1026         * MiniBrowser/MiniBrowser.vcxproj: Removed.
1027         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.ico: Removed.
1028         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.rc: Removed.
1029         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Removed.
1030         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Removed.
1031         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserResource.h: Removed.
1032         * MiniBrowser/MiniBrowser.vcxproj/small.ico: Removed.
1033         * MiniBrowser/win/CMakeLists.txt:
1034         * MiniBrowser/win/MiniBrowser.ico: Copied from MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.ico.
1035         * MiniBrowser/win/MiniBrowser.rc: Copied from MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.rc.
1036         * MiniBrowser/win/MiniBrowserLib.rc: Copied from MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc.
1037         * MiniBrowser/win/MiniBrowserLibResource.h: Copied from MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h.
1038         * MiniBrowser/win/MiniBrowserResource.h: Copied from MiniBrowser/MiniBrowser.vcxproj/MiniBrowserResource.h.
1039         * MiniBrowser/win/small.ico: Copied from MiniBrowser/MiniBrowser.vcxproj/small.ico.
1040         * WebKitTestRunner/WebKitTestRunner.sln: Removed.
1041         * win/DLLLauncher/DLLLauncherWinCairo.props: Removed.
1042
1043 2016-06-09  Zalan Bujtas  <zalan@apple.com>
1044
1045         Add testing support for 3x device scale factor.
1046         https://bugs.webkit.org/show_bug.cgi?id=158597
1047
1048         Reviewed by Simon Fraser.
1049
1050         Set 3x device scale factor on the test canvas when the test url is prefixed with hidpi-3x-. 
1051
1052         * DumpRenderTree/mac/DumpRenderTree.mm:
1053         (changeWindowScaleIfNeeded):
1054         * WebKitTestRunner/TestController.cpp:
1055         (WTR::TestController::updateWindowScaleForTest):
1056         * WebKitTestRunner/TestOptions.cpp:
1057         (WTR::deviceScaleFactorForTest):
1058         (WTR::TestOptions::TestOptions):
1059         (WTR::isHiDPITestPath): Deleted.
1060         * WebKitTestRunner/TestOptions.h:
1061
1062 2016-06-09  Michael Catanzaro  <mcatanzaro@igalia.com>
1063
1064         Add comments to clarify feature enablement
1065         https://bugs.webkit.org/show_bug.cgi?id=158567
1066
1067         Reviewed by Alex Christensen.
1068
1069         * Scripts/webkitperl/FeatureList.pm:
1070
1071 2016-06-09  Filip Pizlo  <fpizlo@apple.com>
1072
1073         Unreviewed, skip jsair tests while we figure out the debug timeouts.
1074
1075         * Scripts/run-javascriptcore-tests:
1076         (runJSCStressTests):
1077
1078 2016-06-09  Commit Queue  <commit-queue@webkit.org>
1079
1080         Unreviewed, rolling out r201815.
1081         https://bugs.webkit.org/show_bug.cgi?id=158570
1082
1083         This broke the cmake build. (Requested by lforschler on
1084         #webkit).
1085
1086         Reverted changeset:
1087
1088         "Teach cmake about libWebKitSystemInterfaceOSX10.12"
1089         http://trac.webkit.org/changeset/201815
1090
1091 2016-06-09  Brady Eidson  <beidson@apple.com>
1092
1093         Greatly simplify CrossThreadTask.h.
1094         https://bugs.webkit.org/show_bug.cgi?id=158542
1095
1096         Reviewed by Darin Adler.
1097
1098         * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
1099         (TestWebKitAPI::TEST):
1100
1101 2016-06-09  Chris Dumez  <cdumez@apple.com>
1102
1103         Unreviewed, rolling out r201836, r201845, and r201848.
1104
1105         Looks like a 1-2% PLT regression on iOS
1106
1107         Reverted changesets:
1108
1109         "[JSC] Change some parameters based on a random search"
1110         https://bugs.webkit.org/show_bug.cgi?id=158514
1111         http://trac.webkit.org/changeset/201836
1112
1113         "Tempory fix for the debug bots"
1114         http://trac.webkit.org/changeset/201845
1115
1116         "Change thresholdForOptimizeSoon to match
1117         thresholdForOptimizeAfterWarmUp"
1118         http://trac.webkit.org/changeset/201848
1119
1120 2016-06-09  Michael Saboff  <msaboff@apple.com>
1121
1122         WebKitTestRunner and DumpRenderTree do not handle dangling surrogate characters
1123         https://bugs.webkit.org/show_bug.cgi?id=154863
1124
1125         Reviewed by Alexey Proskuryakov.
1126
1127         Added a non-strict verions of WKStringGetUTF8CString() that will handle dangling
1128         surrogates.  Changed the extraction of inner text from frames in DumpRenderTree
1129         to use the new WKStringGetUTF8CStringNonStrict() function instead of NSString
1130         conversion since NSString doesn't have a way to handle dangling surrogates.
1131         The code added in DumpRenderTree matches what was changed in WebKitTestRunner.
1132
1133         * DumpRenderTree/mac/DumpRenderTree.mm:
1134         (dumpFramesAsText):
1135         * WebKitTestRunner/StringFunctions.h:
1136         (WTR::toWTFString):
1137
1138 2016-06-08  Hunseop Jeong  <hs85.jeong@samsung.com>
1139
1140         Try to fix the EFL build. 
1141
1142         Unreviewed. 
1143
1144         * TestWebKitAPI/CMakeLists.txt:
1145
1146 2016-06-08  Alex Christensen  <achristensen@webkit.org>
1147
1148        Fix WinCairo build
1149
1150         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
1151
1152 2016-06-08  Alex Christensen  <achristensen@webkit.org>
1153
1154         Fix WinCairo build
1155
1156         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
1157         (BitmapContext::createByAdoptingBitmapAndContext):
1158         (BitmapContext::~BitmapContext):
1159
1160 2016-06-08  Benjamin Poulain  <benjamin@webkit.org>
1161
1162         [JSC] Change some parameters based on a random search
1163         https://bugs.webkit.org/show_bug.cgi?id=158514
1164
1165         Reviewed by Filip Pizlo.
1166
1167         * Scripts/run-jsc-stress-tests:
1168
1169 2016-06-08  Aakash Jain  <aakash_jain@apple.com>
1170
1171         tests fail if display sleeps while run-webkit-tests is running
1172         https://bugs.webkit.org/show_bug.cgi?id=153919
1173
1174         Reviewed by Alexey Proskuryakov.
1175
1176         * DumpRenderTree/mac/LayoutTestHelper.m:
1177         (releaseSleepAssertions): Release both Display sleep and System sleep assertions.
1178         (addSleepAssertions): Add sleep assertion for both Display sleep and System sleep.
1179
1180 2016-06-08  Lucas Forschler  <lforschler@apple.com>
1181
1182         Reverted changeset 201814.
1183
1184         * Scripts/copy-webkitlibraries-to-product-directory:
1185
1186 2016-06-08  Per Arne Vollan  <pvollan@apple.com>
1187
1188         [Win] Shadow DOM tests are failing.
1189         https://bugs.webkit.org/show_bug.cgi?id=158524
1190
1191         Reviewed by Brent Fulgham.
1192
1193         Enable Shadow DOM when running tests.
1194
1195         * DumpRenderTree/win/DumpRenderTree.cpp:
1196         (resetWebPreferencesToConsistentValues):
1197
1198 2016-06-08  Lucas Forschler  <lforschler@apple.com>
1199
1200         Teach cmake about libWebKitSystemInterfaceOSX10.12
1201         This patch also removes duplicated logic inside DumpRenderTree/PlatformMac.cmake
1202
1203         Rubber-stamped by Alex Christensen.
1204  
1205         * DumpRenderTree/PlatformMac.cmake:
1206         * WebKitTestRunner/PlatformMac.cmake:
1207
1208 2016-06-07  Lucas Forschler  <lforschler@apple.com>
1209
1210         <rdar://problem/26685782>
1211         Teach the copy-webkitlibraries-to-product-directory script about WebKitSystemInterfaceOSX10.12
1212
1213         Rubber-stamped by Jessie Berlin.
1214
1215         * Scripts/copy-webkitlibraries-to-product-directory:
1216
1217 2016-06-08  Aakash Jain  <aakash_jain@apple.com>
1218
1219         Don't try to cleanup non-existing ios Simulators
1220         https://bugs.webkit.org/show_bug.cgi?id=158510
1221
1222         Reviewed by Alexey Proskuryakov.
1223
1224         * Scripts/webkitpy/port/ios.py:
1225         (IOSSimulatorPort.clean_up_test_run): 
1226         Check if simulator exists before trying to clean it up.
1227
1228 2016-06-08  Brady Eidson  <beidson@apple.com>
1229
1230         Try to fix the Windows build.
1231
1232         Unreviewed.
1233
1234         * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
1235         (TestWebKitAPI::LifetimeLogger::log):
1236         (TestWebKitAPI::LifetimeLogger::takeLogStr):
1237         (TestWebKitAPI::testFunction):
1238         (TestWebKitAPI::TEST):
1239         (TestWebKitAPI::log): Deleted. (VS was seeing it as a dupe symbol)
1240         (TestWebKitAPI::takeLogStr): Deleted. (VS was seeing it as a dupe symbol)
1241
1242 2016-06-08  Brady Eidson  <beidson@apple.com>
1243
1244         Make CrossThreadCopier more efficient (fewer copies!).
1245         https://bugs.webkit.org/show_bug.cgi?id=158456
1246
1247         Reviewed by Alex Christensen.
1248
1249         * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
1250         (TestWebKitAPI::TEST):
1251
1252 2016-06-07  Filip Pizlo  <fpizlo@apple.com>
1253
1254         Add result validation to JSAir
1255         https://bugs.webkit.org/show_bug.cgi?id=158493
1256
1257         Reviewed by Saam Barati.
1258         
1259         Run JSAir.
1260
1261         * Scripts/run-javascriptcore-tests:
1262         (runJSCStressTests):
1263
1264 2016-06-08  Brady Eidson  <beidson@apple.com>
1265
1266         Add an API test that confirms object constructor/destructor calls during creation of a CrossThreadTask.
1267         https://bugs.webkit.org/show_bug.cgi?id=158528
1268
1269         Reviewed by Alex Christensen.
1270
1271         * TestWebKitAPI/CMakeLists.txt:
1272         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1273         * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp: Added.
1274         (TestWebKitAPI::log):
1275         (TestWebKitAPI::takeLogStr):
1276         (TestWebKitAPI::LifetimeLogger::LifetimeLogger):
1277         (TestWebKitAPI::LifetimeLogger::~LifetimeLogger):
1278         (TestWebKitAPI::LifetimeLogger::isolatedCopy):
1279         (TestWebKitAPI::testFunction):
1280         (TestWebKitAPI::TEST):
1281
1282 2016-06-08  Konstantin Tokarev  <annulen@yandex.ru>
1283
1284         TestWebKitAPI: Removed redunandant check PLATFORM(GTK) && !defined(BUILDING_WEBKIT2__)
1285         https://bugs.webkit.org/show_bug.cgi?id=158521
1286
1287         Reviewed by Carlos Garcia Campos.
1288
1289         * TestWebKitAPI/config.h:
1290
1291 2016-06-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1292
1293         [GTK] Use a longer timeout for glib unit tests
1294         https://bugs.webkit.org/show_bug.cgi?id=158476
1295
1296         Reviewed by Darin Adler.
1297
1298         The timeout is supposed to be per test case, but in the case of GLib tests it affects all the tests cases of the
1299         same test program. Some test programs like TestLoaderClient, that have a lot of test cases, often time out in
1300         the bots because the timeout is not enough to run all the tests cases. So, we should use a longer timeout for
1301         GLib tests.
1302
1303         * Scripts/run-gtk-tests:
1304         (TestRunner._run_test_glib):
1305
1306 2016-06-07  Keith Rollin  <krollin@apple.com>
1307
1308         Remove all uses of PassRefPtr in WTF
1309         https://bugs.webkit.org/show_bug.cgi?id=157596
1310         <rdar://problem/26234391>
1311
1312         Reviewed by Chris Dumez.
1313
1314         Update calls to interfaces that no longer take or return PassRefPtrs.
1315
1316         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1317         (TestWebKitAPI::stringFromUTF8):
1318         (TestWebKitAPI::TEST):
1319
1320 2016-06-07  Per Arne Vollan  <pvollan@apple.com>
1321
1322         [Win] Imported markup insertion test is failing.
1323         https://bugs.webkit.org/show_bug.cgi?id=158477
1324
1325         Reviewed by Darin Adler.
1326
1327         Make sure the empty synchronous request is loaded after each test.
1328
1329         * DumpRenderTree/win/DumpRenderTree.cpp:
1330         (runTest):
1331
1332 2016-06-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1333
1334         REGRESSION(r201449) [GTK] ARMv7 build fails with libicudata.so.55: cannot open shared object file on gtkdoc-scangobj step.
1335         https://bugs.webkit.org/show_bug.cgi?id=158417
1336
1337         Reviewed by Michael Catanzaro.
1338
1339         The toolchain on armhf (ARMv7) seems unable to properly handle
1340         a shared library that doesn't link with anything.
1341
1342         And libicudata is built by default in this way because it only
1343         contains static data.
1344
1345         That makes icu unusable on armhf because the linker will be
1346         unable to resolve the libicudata dependencies.
1347
1348         Most (if not all) distributions workaround this by linking
1349         libicudata with libc6, which is already a needed dependency for
1350         any of the other icu shared libraries.
1351
1352         So import here the Debian patch fixing this issue. For further
1353         details check https://bugs.debian.org/653457
1354
1355         * gtk/jhbuild.modules:
1356         * gtk/patches/icudata-stdlibs.patch: Added.
1357
1358 2016-06-06  Per Arne Vollan  <pvollan@apple.com>
1359
1360         REGRESSION (r104174): 500+ tests failing on Windows
1361         https://bugs.webkit.org/show_bug.cgi?id=75965
1362
1363         Reviewed by Michael Catanzaro.
1364
1365         Reset WebView scale factors before running next test.
1366
1367         * DumpRenderTree/win/DumpRenderTree.cpp:
1368         (resetWebViewToConsistentStateBeforeTesting):
1369
1370 2016-06-04  Alexey Proskuryakov  <ap@apple.com>
1371
1372         REGRESSION (r201263): Some tests have become flaky timeouts.
1373         https://bugs.webkit.org/show_bug.cgi?id=157990
1374
1375         Reviewed by Darin Adler.
1376
1377         * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::invoke):
1378         It is somewhat legitimate for WebContent to not respond to messages after the test
1379         is done; it can be e.g. re-doing a costly repaint. So, we should restart is silently,
1380         without making the current test fail.
1381
1382 2016-06-03  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1383
1384         [GTK] Update YouCompleteMe script to make all include paths absolute
1385         https://bugs.webkit.org/show_bug.cgi?id=158301
1386
1387         Reviewed by Michael Catanzaro.
1388
1389         Before this patch, some include paths were not made absolute.
1390         This could make YouCompleteMe plugin to fail extracting information or validating cpp files.
1391
1392         * gtk/ycm_extra_conf.py:
1393
1394 2016-06-03  Nael Ouedraogo  <nael.ouedraogo@crf.canon.fr>
1395
1396         Unreviewed: add myself to the committers list.
1397
1398         * Scripts/webkitpy/common/config/contributors.json:
1399
1400 2016-06-02  Per Arne Vollan  <pvollan@apple.com>
1401
1402         [Win] Fetch API tests are failing.
1403         https://bugs.webkit.org/show_bug.cgi?id=158296
1404
1405         Reviewed by Alex Christensen.
1406
1407         Enable Fetch API when running tests.
1408
1409         * DumpRenderTree/win/DumpRenderTree.cpp:
1410         (resetWebPreferencesToConsistentValues):
1411
1412 2016-06-02  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
1413
1414         Really display failing JSC stress tests in buildbot dashboard
1415         https://bugs.webkit.org/show_bug.cgi?id=158324
1416
1417         Reviewed by Alexey Proskuryakov.
1418
1419         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
1420         (BuildbotCombinedQueueView.prototype.update): Correctly check for string membership in array.
1421         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1422         (BuildbotIteration.prototype._parseData): Correctly check for string membership in array.
1423         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1424         (BuildbotQueueView.prototype._popoverContentForJavaScriptCoreTestRegressions): Correctly check for string
1425         membership in array.
1426         (BuildbotQueueView.prototype._presentPopoverForJavaScriptCoreTestRegressions): Ensure that the correct URL is
1427         generated after the first time.
1428         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1429         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): Correctly check for string membership in array.
1430
1431 2016-06-02  Michael Saboff  <msaboff@apple.com>
1432
1433         [iOS]: Some JSC stress tests fail running out of executable memory when the LLInt is disabled
1434         https://bugs.webkit.org/show_bug.cgi?id=158317
1435
1436         Reviewed by Saam Barati.
1437
1438         Added defaultNoNoLLIntRun variant to run the default tests with the exception of the no-llint
1439         variant.
1440
1441         * Scripts/run-jsc-stress-tests:
1442
1443 2016-06-02  Aakash Jain  <aakash_jain@apple.com>
1444
1445         LayoutTests time out intermittently due to alert about reopening Simulator after it unexpectedly quit
1446         https://bugs.webkit.org/show_bug.cgi?id=158305
1447
1448         Reviewed by Alexey Proskuryakov.
1449
1450         * Scripts/webkitpy/port/ios.py:
1451         (IOSSimulatorPort.clean_up_test_run): Delete simulator's savedState directories during cleanup.
1452
1453 2016-06-01  Brian Burg  <bburg@apple.com>
1454
1455         REGRESSION(r191907): Can't enter combining diacritic marks in Web Inspector fields
1456         https://bugs.webkit.org/show_bug.cgi?id=158227
1457         <rdar://problem/26232464>
1458
1459         Reviewed by Alexey Proskuryakov.
1460
1461         Add a regression test that runs on Mac only.
1462
1463         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1464         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewTextInput.mm: Added.
1465         (-[DummyNavigationDelegate webView:didFinishNavigation:]):
1466         (TEST):
1467         * TestWebKitAPI/Tests/WebKit2Cocoa/editable-body.html: Added.
1468
1469 2016-06-01  Chris Fleizach  <cfleizach@apple.com>
1470
1471         AX: iOS: VoiceOver can't access attachments in mail messages
1472         https://bugs.webkit.org/show_bug.cgi?id=158198
1473
1474         Reviewed by Joanmarie Diggs.
1475
1476         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1477         (AccessibilityUIElement::stringForRange):
1478         (AccessibilityUIElement::attributedStringForRange):
1479         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
1480         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1481         (WTR::AccessibilityUIElement::attributedStringForRange):
1482         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
1483
1484 2016-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1485
1486         Unreviewed. Mark GTK+ test /webkit2/WebKitWebInspectorServer/test-open-debugging-session as slow.
1487
1488         It's timing out in the bots, but it seems to pass when running run-gtk-tests with no timeout. For GLib tests the
1489         timeout is applied per tester program not per test case, so we need to mark the whole test
1490         WebKit2Gtk/TestInspectorServer as slow.
1491
1492         * Scripts/run-gtk-tests:
1493         (TestRunner):
1494         (TestRunner._run_test_glib):
1495
1496 2016-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1497
1498         Unreviewed. Skip media permission request GTK+ unit tests.
1499
1500         They are timing out in the bots.
1501
1502         * Scripts/run-gtk-tests:
1503         (TestRunner):
1504
1505 2016-05-31  Jer Noble  <jer.noble@apple.com>
1506
1507         Yet another unreviewed build fix; move the closing brace of the namespace declaration inside
1508         the #if check.
1509
1510         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm:
1511
1512 2016-05-31  Jer Noble  <jer.noble@apple.com>
1513
1514         Further unreviewed build fix; only run FullscreenTopContentInset test on Mac.
1515
1516         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm:
1517
1518 2016-05-31  Jer Noble  <jer.noble@apple.com>
1519
1520         Unreviewed build fix; only run FullscreetTopContentInset test on platforms
1521         where WK_API_ENABLED is set.
1522
1523         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm:
1524
1525 2016-05-31  Jer Noble  <jer.noble@apple.com>
1526
1527         REGRESSION (r201405): trailers.apple.com HUD is missing in fullscreen
1528         https://bugs.webkit.org/show_bug.cgi?id=158156
1529         <rdar://problem/26519589>
1530
1531         Reviewed by Darin Adler.
1532
1533         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1534         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.html: Added.
1535         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm: Added.
1536         (-[FullscreenChangeMessageHandler userContentController:didReceiveScriptMessage:]):
1537         (TestWebKitAPI::TEST):
1538
1539 2016-05-31  Jon Lee  <jonlee@apple.com>
1540
1541         Unreviewed: add myself to the reviewers list.
1542
1543         * Scripts/webkitpy/common/config/contributors.json:
1544
1545 2016-05-31  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1546
1547         [GTK] Provide alternative mirror for the ICU tarball.
1548         https://bugs.webkit.org/show_bug.cgi?id=154530
1549
1550         Unreviewed.
1551
1552         * gtk/jhbuild.modules: After r201449 the GTK+ ARM buildbot is having
1553         a hard time trying to download the ICU tarball from download.icu-project.org
1554         (which redirects to sourceforge and gives problems with something related to
1555         SSL). Provide this alternative mirror to make things working back.
1556
1557 2016-05-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1558
1559         [GTK] Test /webkit2/WebKitWebView/geolocation-permission-requests is failing since r201423
1560         https://bugs.webkit.org/show_bug.cgi?id=158200
1561
1562         Reviewed by Philippe Normand.
1563
1564         This is because geolocation is no longer allowed for non secure sites, like HTTP. In that case
1565         POSITION_UNAVAILABLE is returned without asking the API layer.
1566
1567         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1568         (testWebViewGeolocationPermissionRequests): Keep the HTTP case to check that it indeed returns
1569         POSITION_UNAVAILABLE and use HTTPS URLs to check permission requests are allowed or denied. Also stop using the
1570         document title, and use user script messages that are more reliable instead.
1571
1572 2016-05-28  Aakash Jain  <aakash_jain@apple.com>
1573
1574         tests fail if display sleeps while run-webkit-tests is running
1575         https://bugs.webkit.org/show_bug.cgi?id=153919
1576
1577         Reviewed by Darin Adler.
1578
1579         * DumpRenderTree/mac/LayoutTestHelper.m:
1580         (addDisplaySleepAssertion): Use PreventUserIdleSystemSleep flag, same as set by caffeinate tool.
1581
1582 2016-05-27  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
1583
1584         Display failing JSC stress tests in buildbot dashboard
1585         https://bugs.webkit.org/show_bug.cgi?id=156595
1586
1587         Reviewed by Alexey Proskuryakov.
1588
1589         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1590         (Buildbot.prototype.javaScriptCoreTestFailuresURLForIteration):
1591         (Buildbot.prototype.javaScriptCoreTestStdioUrlForIteration):
1592         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
1593         (BuildbotCombinedQueueView.prototype.update):
1594         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1595         (BuildbotIteration):
1596         (BuildbotIteration.prototype._parseData):
1597         (BuildbotIteration.prototype.loadLayoutTestResults):
1598         (BuildbotIteration.prototype.):
1599         (BuildbotIteration.prototype.loadJavaScriptCoreTestResults):
1600         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1601         (BuildbotQueueView.prototype._createLoadingIndicator):
1602         (BuildbotQueueView.prototype.):
1603         (BuildbotQueueView.prototype._onPopoverCopy):
1604         (BuildbotQueueView.prototype._popoverContentForJavaScriptCoreTestRegressions):
1605         (BuildbotQueueView.prototype._presentPopoverForJavaScriptCoreTestRegressions):
1606         (BuildbotQueueView.prototype._addIterationHeadingToPopover):
1607         (BuildbotQueueView.prototype._testStepFailureDescription):
1608         (BuildbotQueueView.prototype._testStepFailureDescriptionWithCount):
1609         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1610         (BuildbotTestResults.prototype.addJavaScriptCoreTestFailures):
1611         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1612         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus):
1613         (BuildbotTesterQueueView.prototype.update):
1614         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):
1615         (BuildbotTesterQueueView.prototype._presentPopoverForLayoutTestRegressions):
1616         (BuildbotTesterQueueView.prototype._testStepFailureDescription): Deleted.
1617         (BuildbotTesterQueueView.prototype._testStepFailureDescriptionWithCount): Deleted.
1618         (BuildbotTesterQueueView.prototype.): Deleted.
1619         (BuildbotTesterQueueView.prototype.content.oncopy): Deleted.
1620         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html:
1621         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbot.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueue.js.
1622         (MockBuildbot):
1623         (MockBuildbot.prototype.buildPageURLForIteration):
1624         (MockBuildbot.prototype.javaScriptCoreTestFailuresURLForIteration):
1625         (MockBuildbot.prototype.javaScriptCoreTestStdioUrlForIteration):
1626         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueue.js:
1627         (MockBuildbotQueue):
1628         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotTestResults.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueue.js.
1629         (MockBuildbotTestResults):
1630         (MockBuildbotTestResults.prototype.addJavaScriptCoreTestFailures):
1631         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/test-jsc-results.json: Added.
1632         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
1633
1634 2016-05-27  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
1635
1636         Display failing JSC stress tests in buildbot dashboard
1637         https://bugs.webkit.org/show_bug.cgi?id=156595
1638
1639         Reviewed by Alexey Proskuryakov.
1640
1641         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1642         (Buildbot.prototype.javaScriptCoreTestFailuresURLForIteration): Generate the URL for raw JSON output of
1643         JSC tests.
1644         (Buildbot.prototype.javaScriptCoreTestStdioURLForIteration): Generate the URL for human-readable stdio output
1645         of JSC tests.
1646         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
1647         (BuildbotCombinedQueueView.prototype.update): Display JSC test results in popover.
1648         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1649         (BuildbotIteration): Add javaScriptCoreTestResults variable.
1650         (BuildbotIteration.prototype.): Check for javascriptcore tests step.
1651         (BuildbotIteration.prototype.loadLayoutTestResults): Add comma at closing brace.
1652         (BuildbotIteration.prototype.loadJavaScriptCoreTestResults): Fetch JSON from Buildbot server.
1653         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1654         (BuildbotQueueView.prototype._createLoadingIndicator): Reusable function.
1655         (BuildbotQueueView.prototype._onPopoverCopy): Reusable copy event handler to allow accurate copying of text
1656         from popovers.
1657         (BuildbotQueueView.prototype._popoverContentForJavaScriptCoreTestRegressions): Generates the popover bubble's
1658         inner HTML from the JSC failure data.
1659         (BuildbotQueueView.prototype._presentPopoverForJavaScriptCoreTestRegressions): Generate the popover bubble
1660         for JSC results and handle request failures.
1661         (BuildbotQueueView.prototype._testStepFailureDescription): Moved from subclass.
1662         (BuildbotQueueView.prototype._testStepFailureDescriptionWithCount): Moved from subclass.
1663         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1664         (BuildbotTestResults.prototype.addJavaScriptCoreTestFailures): Parse JSON into a list of failing tests.
1665         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1666         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): Instantiate PopoverTrackers for builds whose 
1667         only failures are JSC tests.
1668         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions): Use _onPopoverCopy.
1669         (BuildbotTesterQueueView.prototype._presentPopoverForLayoutTestRegressions): Use _createLoadingIndicator.
1670         (BuildbotTesterQueueView.prototype._testStepFailureDescription): Deleted. Moved to superclass.
1671         (BuildbotTesterQueueView.prototype._testStepFailureDescriptionWithCount): Deleted. Moved to superclass.
1672         (BuildbotTesterQueueView.prototype.content.oncopy): Deleted. Using superclass's reusable function as copy handler instead.
1673         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html: Add new script files.
1674         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbot.js: Added.
1675         (MockBuildbot): Mocked version of Buildbot, only containing URL methods.
1676         (MockBuildbot.prototype.buildPageURLForIteration): Same as real Buildbot.js
1677         (MockBuildbot.prototype.javaScriptCoreTestFailuresURLForIteration): Points to local file containing JSON for test.
1678         (MockBuildbot.prototype.javaScriptCoreTestStdioURLForIteration): Same as real Buildbot.js
1679         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueue.js:
1680         (MockBuildbotQueue): Use a MockBuildbot() instead of a string.
1681         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotTestResults.js: Added.
1682         (MockBuildbotTestResults): Mocked version of BuildbotTestResults.
1683         (MockBuildbotTestResults.prototype.addJavaScriptCoreTestFailures): Sets the 'regressions' variable.
1684         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/test-jsc-results.json: Added.
1685         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js: Add four groups of tests.
1686
1687 2016-05-27  Chris Dumez  <cdumez@apple.com>
1688
1689         WorkQueue::dispatch() / RunLoop::dispatch() should not copy captured lambda variables
1690         https://bugs.webkit.org/show_bug.cgi?id=158111
1691
1692         Reviewed by Darin Adler.
1693
1694         WorkQueue::dispatch() / RunLoop::dispatch() should not copy captured lambda variables.
1695         These are often used cross-thread and copying the captured lambda variables can be
1696         dangerous (e.g. we do not want to copy a String after calling isolatedCopy() upon
1697         capture).
1698
1699         * WebKitTestRunner/TestController.cpp:
1700         (WTR::TestController::decidePolicyForNavigationAction):
1701
1702 2016-05-27  Brady Eidson  <beidson@apple.com>
1703
1704         Modern IDB: After closing a Netflix video, trying to watch it again fails.
1705         <rdar://problem/25092473> and https://bugs.webkit.org/show_bug.cgi?id=158160
1706
1707         Reviewed by Alex Christensen.
1708
1709         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1710         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup-1.html: Added.
1711         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup-2.html: Added.
1712         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm: Added.
1713
1714 2016-05-27  Joanmarie Diggs  <jdiggs@igalia.com>
1715
1716         AX: [ATK] accessibility/gtk/no-notification-for-unrendered-iframe-children.html began failing after r201416
1717         https://bugs.webkit.org/show_bug.cgi?id=158152
1718
1719         Reviewed by Chris Fleizach.
1720
1721         The failure is actually a bug fix because only one child is being added, but two
1722         notifications were being emitted. Now there is only one notification. To verify
1723         this was the case, we really should examine the child reportedly being added. That
1724         child is the ATK event's any_data, so pass along that child to the listener.
1725
1726         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1727
1728 2016-05-26  Alex Christensen  <achristensen@webkit.org>
1729
1730         Expose content extension failure error codes in SPI
1731         https://bugs.webkit.org/show_bug.cgi?id=158095
1732         rdar://problem/26475651
1733
1734         Reviewed by Anders Carlsson.
1735
1736         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm:
1737         (checkDomain):
1738         (TEST_F):
1739         Add tests that use the new enum.
1740
1741 2016-05-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1742
1743         New intl-numberformat.js test fails on many Linux platforms
1744         https://bugs.webkit.org/show_bug.cgi?id=154530
1745
1746         Reviewed by Darin Adler.
1747
1748         The test is actually failing because of a bug in the icu version installed in the bots, using a newer version of
1749         icu makes the tests pass and explains why it worked for some people. So, let's add icu 55.1 to the internal
1750         jhbuild to ensure JSC tests pass in the bots no matter what the icu version installed is.
1751
1752         * gtk/jhbuild.modules:
1753
1754 2016-05-26  Yusuke Suzuki  <utatane.tea@gmail.com>
1755
1756         [JSC] Allow JSBench to use precise time
1757         https://bugs.webkit.org/show_bug.cgi?id=158050
1758
1759         Reviewed by Geoffrey Garen.
1760
1761         JSBench use `new Date().getTime()` without options and there is no way to use precise time.
1762         This patch modifies the JSBench code to inject the code taking the precise time.
1763         `currentTimeInMS` is given by the benchmerk harness and JSBench uses it.
1764         run-jsc-benchmark switches this function's implementation between `Date.now()` and
1765         testRunner's precise time one.
1766
1767         While this patch modifies the code of JSBench, the last release of JSBench is Jan 2013 and
1768         the contents are not changed for a long time. As described in the original paper[1], the
1769         tests can be generated by using JSBench's record & replay system, but in that case, we can
1770         adopt this modification by changing the tool side.
1771
1772         We also add currentTimeInMS implementation in harness.js and u?rem.js directly.
1773         u?rem.js implementation is required when it is executed in u?rem.html without harness.
1774         And harness.js implementation is required when it is executed in the JSBench's harness.
1775         In these implementation, we follow the JetStream's time measuring function: performance.now(),
1776         preciseTime(), or Date.now().
1777
1778         [1]: http://dl.acm.org/citation.cfm?id=2048119
1779
1780         * Scripts/run-jsc-benchmarks:
1781
1782 2016-05-26  Brent Fulgham  <bfulgham@apple.com>
1783
1784         Unreviewed test fix after r201427.
1785         https://bugs.webkit.org/show_bug.cgi?id=157423
1786         <rdar://problem/23751632>
1787
1788         A debug assertion was firing during some test runs due to the Geolocation permission
1789         being turned off during the test. The timer logic was originally written to assert
1790         if the timer fired when permissions were disabled. But this is no longer valid,
1791         because we expect the Geolocation system to be active and become deactivated if the
1792         browsing context violates one of the security criteria.
1793
1794         * DumpRenderTree/mac/UIDelegate.mm:
1795         (-[UIDelegate timerFired]): Remove invalid assertion.
1796
1797 2016-05-26  Filip Pizlo  <fpizlo@apple.com>
1798
1799         ScopedLambda should have a lifetime story that makes sense to the compiler
1800         https://bugs.webkit.org/show_bug.cgi?id=158118
1801
1802         Reviewed by Mark Lam.
1803         
1804         Added a test case. This test crashes before the fix and now it passes.
1805
1806         * TestWebKitAPI/CMakeLists.txt:
1807         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1808         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp: Added.
1809         (TestWebKitAPI::TEST):
1810
1811 2016-05-26  Myles C. Maxfield  <mmaxfield@apple.com>
1812
1813         Build fix
1814
1815         Rubber stamped by Lucas Forschler.
1816
1817         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1818         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1819
1820 2016-05-25  Anders Carlsson  <andersca@apple.com>
1821
1822         Get rid of WTF/Functional.h
1823         https://bugs.webkit.org/show_bug.cgi?id=158081
1824
1825         Reviewed by Chris Dumez.
1826
1827         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1828         * TestWebKitAPI/Tests/WTF/Functional.cpp: Removed.
1829         (TestWebKitAPI::returnFortyTwo): Deleted.
1830         (TestWebKitAPI::TEST): Deleted.
1831         (TestWebKitAPI::multiplyByTwo): Deleted.
1832         (TestWebKitAPI::multiplyByOneAndAHalf): Deleted.
1833         (TestWebKitAPI::multiply): Deleted.
1834         (TestWebKitAPI::subtract): Deleted.
1835         (TestWebKitAPI::A::A): Deleted.
1836         (TestWebKitAPI::A::f): Deleted.
1837         (TestWebKitAPI::A::addF): Deleted.
1838         (TestWebKitAPI::B::B): Deleted.
1839         (TestWebKitAPI::B::~B): Deleted.
1840         (TestWebKitAPI::B::ref): Deleted.
1841         (TestWebKitAPI::B::deref): Deleted.
1842         (TestWebKitAPI::B::f): Deleted.
1843         (TestWebKitAPI::B::g): Deleted.
1844         (TestWebKitAPI::Number::create): Deleted.
1845         (TestWebKitAPI::Number::~Number): Deleted.
1846         (TestWebKitAPI::Number::value): Deleted.
1847         (TestWebKitAPI::Number::Number): Deleted.
1848         (TestWebKitAPI::multiplyNumberByTwo): Deleted.
1849
1850 2016-05-25  Daniel Bates  <dabates@apple.com> and Brent Fulgham  <bfulgham@apple.com>
1851
1852         [WebSockets] No infrastructure for testing secure web sockets (wss)
1853         https://bugs.webkit.org/show_bug.cgi?id=157884
1854         <rdar://problem/26477197>
1855
1856         Reviewed by Andy Estes.
1857
1858         Add support to webkitpy to start and stop a secure Web Socket server running on port 9323
1859         using the certificate, private-key from file LayoutTests/http/conf/webkit-httpd.pem. Also
1860         teaches run-webkit-httpd to start and stop the Web Socket servers.
1861
1862         Modify DumpRenderTree and WebKitTestRunner to understand a new testRunner method,
1863         'setAllowsAnySSLCertificate', which allows us to use the same self-signed test certificate
1864         we do for our HTTPS tests.
1865         
1866         * DumpRenderTree/TestRunner.cpp:
1867         (setAllowsAnySSLCertificateCallback):
1868         (TestRunner::setAllowsAnySSLCertificate):
1869         * DumpRenderTree/TestRunner.h:
1870         * DumpRenderTree/mac/DumpRenderTree.mm:
1871         (resetWebViewToConsistentStateBeforeTesting): Make sure we turn off the new flag between tests.
1872         * Scripts/run-webkit-httpd:
1873         (main): Start the websocket server at launch.
1874         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1875         (Manager.__init__): Remove dead code.
1876         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
1877         (PyWebSocket.__init__): Cleanup code.
1878         (PyWebSocket): Pass '--tls-client-ca' to start command.
1879         (PyWebSocket._prepare_config): Cleanups.
1880         * Scripts/webkitpy/port/base.py:
1881         (Port.to.start_http_server):
1882         (Port.to):
1883         (Port.to._extract_certificate_from_pem): Added.
1884         (Port.to._extract_private_key_from_pem): Added.
1885         (Port.to.start_websocket_server): Start secure socket server.
1886         (Port.to.stop_websocket_server): Stop secure socket server.
1887         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Add new API.
1888         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1889         (WTR::InjectedBundle::setAllowsAnySSLCertificate): Added.
1890         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1891         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1892         (WTR::TestRunner::setAllowsAnySSLCertificate): Added.
1893         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1894
1895 2016-05-25  Keith Miller  <keith_miller@apple.com>
1896
1897         run-jsc-benchmarks should use the new JSBench rather than look for it in the config file.
1898         https://bugs.webkit.org/show_bug.cgi?id=158077
1899
1900         Reviewed by Mark Lam.
1901
1902         Since we didn't have JSBench in the tree before we needed to lookup the path to it from
1903         benchmark config file. That's no longer the case so we should just fix it in the script.
1904
1905         * Scripts/run-jsc-benchmarks:
1906
1907 2016-05-24  Aakash Jain  <aakash_jain@apple.com>
1908
1909         Reorganize dashboard code: move code from _timeIntervalString to base class
1910         https://bugs.webkit.org/show_bug.cgi?id=158047
1911         rdar://problem/26457274
1912
1913         Reviewed by Alexey Proskuryakov and Dean Johnson.
1914
1915         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js:
1916         (BubbleQueueView.prototype._timeIntervalString): Moved core logic to base class so as to make it re-usable.
1917         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
1918         (QueueView.prototype._readableTimeString): Same.
1919
1920 2016-05-24  Yusuke Suzuki  <utatane.tea@gmail.com>
1921
1922         [JSC][GTK][EFL] Allow run-jsc-benchmark to use WebKitTestRunner in EFL / GTK ports
1923         https://bugs.webkit.org/show_bug.cgi?id=158016
1924
1925         Reviewed by Darin Adler.
1926
1927         This patch easily allows run-jsc-benchmark to run WebKitTestRunner-based tests in GTK / EFL ports.
1928         This change encourages us to run tests with the browser-heap in nix environments.
1929         Two things are modified.
1930
1931         1. Add a fall-back to look up the library path in GTK / EFL / JSCOnly environment.
1932
1933             In GTK / EFL / JSCOnly ports, the hierarchy of the build directory is slightly different from Apple port.
1934             For example, the jsc bin locate at "WebKitBuild/XXX/Release/bin/jsc" and the lib path is "WebKitBuild/XXX/Release/lib"
1935             while the one of Apple port is "WebKitBuild/XXX/Release/jsc" and "WebKitBuild/XXX/Release/lib".
1936             And based on this library path, we configure the required environment variables to run WebKitTestRunner in GTK / EFL ports.
1937
1938         2. Add --dependencies option to add dependent library paths.
1939
1940             While Apple ports does not require any additional dependent library path, GTK and EFL ports require this path,
1941             typically WebKitBuild/DependenciesGTK and WebKitBuild/DependenciesEFL respectively. So we need to add such paths to LD_LIBRARY_PATH.
1942             Instead of adding platform options like --gtk / --efl, we add --dependencies option to add the additional dependent library paths.
1943             The platform options still require the build path to look up the dependent library directory. So we pass it directly through --dependencies.
1944             Multiple additional dependent library paths can be added by using --dependencies multiple times.
1945
1946         By using these change, we can run benchmarks that require WebKitTestRunner in GTK / EFL ports (If you would like to run them in a headless manner, you can use xvbuf.).
1947         Example:
1948             `Tools/Scripts/run-jsc-benchmarks baseline:WebKitBuild/baseline/Release/bin/WebKitTestRunner patched:WebKitBuild/patched/Release/bin/WebKitTestRunner --dependencies WebKitBuild/DependenciesGTK/Root/lib --js-bench`
1949
1950         * Scripts/run-jsc-benchmarks:
1951
1952 2016-05-20  Keith Miller  <keith_miller@apple.com>
1953         We should have JSBench in PerformanceTests
1954         https://bugs.webkit.org/show_bug.cgi?id=157952
1955
1956         Rubber-stamped by Saam Barati.
1957
1958         This changes the runner to use the layout of the newest version of JSBench.
1959
1960         * Scripts/run-jsc-benchmarks:
1961
1962 2016-05-24  Chris Dumez  <cdumez@apple.com>
1963
1964         Use auto for some of our lambda function parameters
1965         https://bugs.webkit.org/show_bug.cgi?id=158001
1966
1967         Reviewed by Darin Adler.
1968
1969         Use auto for some of our lambda function parameters now that we build with c++14.
1970
1971         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1972         (WTR::InjectedBundle::willDestroyPage):
1973
1974 2016-05-23  Brady Eidson  <beidson@apple.com>
1975
1976         check-webkit-style gets flags std::literals::chrono_literals as bad naming.
1977         https://bugs.webkit.org/show_bug.cgi?id=157969
1978
1979         Reviewed by Alex Christensen.
1980
1981         * Scripts/webkitpy/style/checkers/cpp.py:
1982         (check_identifier_name_in_declaration):
1983         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1984         (WebKitStyleTest.test_names):
1985
1986 2016-05-22  Alexey Proskuryakov  <ap@apple.com>
1987
1988         RELEASE_ASSERT(TestController::singleton().isCurrentInvocation(testInvocation)) is sometimes hit when running tests
1989         https://bugs.webkit.org/show_bug.cgi?id=157977
1990         rdar://problem/20874156
1991
1992         Reviewed by David Kilzer.
1993
1994         * WebKitTestRunner/TestInvocation.cpp:
1995         (WTR::TestInvocation::invoke): Be more certain to launch a new process when there was
1996         a timeout detected. If we don't, there is a chance that the process is not quite frozen,
1997         and will still send a response that we no longer expect.
1998         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Print timeout details to stderr
1999         too, as stdout is not available, at least not in the case that I was observing.
2000
2001 2016-05-22  Brady Eidson  <beidson@apple.com>
2002
2003         Move to C++14.
2004         https://bugs.webkit.org/show_bug.cgi?id=157948
2005
2006         Reviewed by Michael Catanzaro.
2007
2008         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2009         * MiniBrowser/Configurations/Base.xcconfig:
2010         * TestWebKitAPI/Configurations/Base.xcconfig:
2011         * WebKitTestRunner/Configurations/Base.xcconfig:
2012
2013 2016-05-21  Aakash Jain  <aakash_jain@apple.com>
2014
2015         Simulator launch fails intermittently due to failure in checking simulator boot status
2016         https://bugs.webkit.org/show_bug.cgi?id=157965
2017         rdar://problem/26402404
2018
2019         Reviewed by Alexey Proskuryakov.
2020
2021         * Scripts/webkitpy/xcode/simulator.py:
2022         (Simulator.wait_until_device_is_booted): Ignore CalledProcessError exception while checking
2023         whether simulator has finished booting.
2024
2025 2016-05-21  Dan Bernstein  <mitz@apple.com>
2026
2027         Silence warnings from svn propget when using newer versions of Subversion.
2028         https://bugs.webkit.org/show_bug.cgi?id=157879
2029
2030         Reviewed by Daniel Bates.
2031
2032         * Scripts/prepare-ChangeLog:
2033         (attributeCommand): Redirect svn propget stderr to /dev/null.
2034         * Scripts/svn-create-patch:
2035         (findMimeType): Ditto.
2036
2037 2016-05-20  Ryosuke Niwa  <rniwa@webkit.org>
2038
2039         run-benchmark's results should contain Animometer's debug output
2040         https://bugs.webkit.org/show_bug.cgi?id=157941
2041
2042         Reviewed by Stephanie Lewis.
2043
2044         Modified the Animometer patch to store debug output and made benchmark_runner extract them together as a single array.
2045         The result can be dragged and dropped into Animometer's developer.html page.
2046
2047         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2048         (BenchmarkRunner._run_one_test): Parse JSON here instead of doing it in multiple call sites.
2049         (BenchmarkRunner._run_benchmark): Strip debugOutput from individual test result, and merge them together separately.
2050         * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch:
2051         Modified the patch to store the debug output.
2052         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
2053         (ServerControl.render_POST): Fixed a bug that POST to /report results in 500 because getvalue is not defined
2054         when the request body is larger than a certain size on twisted.
2055
2056 2016-05-20  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
2057
2058         Use clearer names for JSON output of javascriptcore test results
2059         https://bugs.webkit.org/show_bug.cgi?id=157921
2060
2061         Reviewed by Alexey Proskuryakov.
2062
2063         "failures" and "apiTestResult" were somewhat ambiguous names. 
2064         
2065         * Scripts/run-javascriptcore-tests:
2066         (runJSCStressTests): "failures" -> "stressFailures", "apiTestResult" -> "allApiTestsPassed".
2067
2068 2016-05-20  Chris Dumez  <cdumez@apple.com>
2069
2070         Unreviewed, fix API test introduced in r201213.
2071
2072         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
2073         (TestWebKitAPI::TEST):
2074
2075 2016-05-20  Rawinder Singh  <rawinder.singh-webkit@cisra.canon.com.au>
2076
2077         Implement operator== for WeakPtr
2078         https://bugs.webkit.org/show_bug.cgi?id=157883
2079
2080         Reviewed by Chris Dumez.
2081
2082         Implement operator== and operator!= for WeakPtr and update code to use the operators.
2083
2084         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
2085         (TestWebKitAPI::TEST):
2086
2087 2016-05-19  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
2088
2089         Add JSON results to 32-bit and CLoop JSC tests
2090         https://bugs.webkit.org/show_bug.cgi?id=157929
2091
2092         Reviewed by Alexey Proskuryakov.
2093
2094         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2095         (RunLLINTCLoopTests): Change command-line parameters to run-javascriptcore-tests in order to get JSON output.
2096         (Run32bitJSCTests): Change command-line parameters to run-javascriptcore-tests in order to get JSON output.
2097
2098 2016-05-19  Csaba Osztrogonác  <ossy@webkit.org>
2099
2100         Typo fix in import-test262-tests
2101         https://bugs.webkit.org/show_bug.cgi?id=157902
2102
2103         Reviewed by Keith Miller.
2104
2105         * Scripts/import-test262-tests:
2106
2107 2016-05-19  Csaba Osztrogonác  <ossy@webkit.org>
2108
2109         [EFL] Fix the gst-libav build on ARM Thumb2 after r199649
2110         https://bugs.webkit.org/show_bug.cgi?id=157893
2111
2112         Reviewed by Antonio Gomes.
2113
2114         * efl/patches/gst-libav.patch:
2115
2116 2016-05-19  Jer Noble  <jer.noble@apple.com>
2117
2118         REGRESSION(r200951): VideoControlsManager API tests time out
2119         https://bugs.webkit.org/show_bug.cgi?id=157896
2120         <rdar://problem/26326293>
2121
2122         Reviewed by Eric Carlson.
2123
2124         Explicitly disable user gesture requirements for playback.
2125
2126         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2127         (TestWebKitAPI::TEST):
2128
2129 2016-05-19  Csaba Osztrogonác  <ossy@webkit.org>
2130
2131         Slow JSC stress tests times out in 32 bit debug mode
2132         https://bugs.webkit.org/show_bug.cgi?id=154964
2133
2134         Reviewed by Michael Catanzaro.
2135
2136         * Scripts/run-javascriptcore-tests:
2137         (runJSCStressTests): Pass through the --debug option.
2138         * Scripts/run-jsc-stress-tests: Increase the timeout for debug builds.
2139
2140 2016-05-18  Aakash Jain  <aakash_jain@apple.com>
2141
2142         Remove underline from Status Bubbles on dashboard
2143         https://bugs.webkit.org/show_bug.cgi?id=157870
2144         rdar://problem/26332321
2145
2146         Reviewed by Alexey Proskuryakov.
2147
2148         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css: Reverted style 
2149         change made in http://trac.webkit.org/r200880
2150
2151 2016-05-18  Michael Saboff  <msaboff@apple.com>
2152
2153         r199812 broke test262
2154         https://bugs.webkit.org/show_bug.cgi?id=157595
2155
2156         Reviewed by Filip Pizlo.
2157
2158         Added a new run type, runOneLargeHeap, for tests that use a large amount of memory.
2159         This run type will not run with the --memory-limited option.  Without that option,
2160         we'll only the default test variant.
2161
2162         * Scripts/run-jsc-stress-tests:
2163
2164 2016-05-18  Simon Fraser  <simon.fraser@apple.com>
2165
2166         REGRESSION (r200534) Command-+ no longer zooms pages 
2167         https://bugs.webkit.org/show_bug.cgi?id=157826
2168         rdar://problem/26334636
2169
2170         Reviewed by Dean Jackson.
2171
2172         * DumpRenderTree/mac/DumpRenderTree.mm:
2173         (resetWebPreferencesToConsistentValues): Remove ENABLE() #ifdefs that do nothing (see http://webkit.org/b/157828).
2174
2175 2016-05-18  Joanmarie Diggs  <jdiggs@igalia.com>
2176
2177         [GTK] accessibility/meter-element.html is failing
2178         https://bugs.webkit.org/show_bug.cgi?id=115633
2179
2180         Reviewed by Chris Fleizach.
2181
2182         Implement AccessibilityUIElement::valueDescription() and add mapping
2183         from ATK_ROLE_LEVEL_BAR to AXProgressIndicator.
2184
2185         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2186         (WTR::AccessibilityUIElement::valueDescription):
2187
2188 2016-05-18  Brady Eidson  <beidson@apple.com>
2189
2190         Modern IDB: Make TestRunner.clearAllDatabases also delete IndexedDB databases (once doing so is supported).
2191         https://bugs.webkit.org/show_bug.cgi?id=157823
2192
2193         Reviewed by Alex Christensen.
2194
2195         * DumpRenderTree/mac/TestRunnerMac.mm:
2196         (TestRunner::clearAllDatabases):
2197         
2198         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2199         (WTR::TestRunner::clearAllDatabases):
2200         
2201         * WebKitTestRunner/TestInvocation.cpp:
2202         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2203
2204 2016-05-18  Joanmarie Diggs  <jdiggs@igalia.com>
2205
2206         AX: [ATK] Use WebCore Accessibility's AccessibilityText for AtkObject name and description
2207         https://bugs.webkit.org/show_bug.cgi?id=157822
2208
2209         Reviewed by Chris Fleizach.
2210
2211         Fix AccessibilityUIElement::helpText() so that it returns an empty string rather than
2212         nullptr upon failure.
2213
2214         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2215         (WTR::AccessibilityUIElement::helpText):
2216
2217 2016-05-17  Beth Dakin  <bdakin@apple.com>
2218
2219         Make handleAcceptedCandidate a public function
2220         https://bugs.webkit.org/show_bug.cgi?id=157763
2221         -and corresponding-
2222         rdar://problem/26206397
2223
2224         Reviewed by Tim Horton.
2225
2226         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2227         * TestWebKitAPI/Tests/WebKit2Cocoa/autofocused-text-input.html: Added.
2228         * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm: Added.
2229         (-[DoNotLeakWebView dealloc]):
2230         (-[DoNotLeakWebView showCandidates:forString:inRect:forSelectedRange:view:completionHandler:]):
2231         (-[DoNotLeakFrameLoadDelegate webView:didFinishLoadForFrame:]):
2232         (TestWebKitAPI::TEST):
2233
2234 2016-05-17  Keith Miller  <keith_miller@apple.com>
2235
2236         Add test262 harness support code
2237         https://bugs.webkit.org/show_bug.cgi?id=157797
2238
2239         Reviewed by Filip Pizlo.
2240
2241         The import-test262-tests script is used to generate the yaml file used to run test262. It
2242         takes a path to the local copy of the Test262 repository as well as an optional path to file
2243         containing a list of failures. This script currently just creates the yaml file used to run
2244         the script. It does not relocate the test files into our tests directory. In the future I
2245         plan to add that feature but it didn't seem essential for the first iteration. Since many
2246         test262 tests need to be run in both strict and non-strict mode, import-test262-tests
2247         creates two separate runs for those tests. This enables us to distinguish between failures
2248         in only one of the two modes.
2249
2250         This patch also updates the run-jsc-stress-tests Script to run tests from Test262. In order
2251         to do so two new run commands were needed runTest262 and prepareTest262Fixture. runTest262
2252         takes an actual test file along with the metadata associated with it. prepareTest262Fixture
2253         takes a fixture file (used by module tests for importing) and makes sure that file is
2254         properly relocated to the test runner directory.
2255
2256         The proccess I used to import the tests was to first run import-test262-tests to create a
2257         yaml for all the tests (import-test262-tests assumes all tests pass if to failures file is
2258         passed). Then I ran the generated yaml file with "run-jsc-stress-tests -v -c 1" piping the
2259         output to a file and collected all the lines with "FAIL" in it. Finally, I reran
2260         import-test262-tests with the new failure file to create the final yaml.
2261
2262         * Scripts/import-test262-tests: Added.
2263         * Scripts/run-jsc-stress-tests:
2264
2265 2016-05-16  Enrica Casucci  <enrica@apple.com>
2266
2267         build fix after r200968 and r200969
2268
2269         Unreviewed.
2270
2271         * DumpRenderTree/mac/EventSendingController.mm:
2272         (-[EventSendingController keyDown:withModifiers:withLocation:]):
2273
2274 2016-05-16  Jer Noble  <jer.noble@apple.com>
2275
2276         API test WebKit2.MSEIsPlayingAudio timing out after r200951
2277         https://bugs.webkit.org/show_bug.cgi?id=157748
2278
2279         Reviewed by Eric Carlson.
2280
2281         The file-with-mse.html testcase only calls play() once it's own XHR loading is complete; the
2282         "user gesture" check fails at that point.  Call play() up front; playback will begin as soon
2283         as enough data is loaded.
2284
2285         * TestWebKitAPI/Tests/WebKit2/file-with-mse.html:
2286
2287 2016-05-16  Enrica Casucci  <enrica@apple.com>
2288
2289         Remove unused initializer for WebEvent on iOS.
2290         https://bugs.webkit.org/show_bug.cgi?id=157689
2291
2292         Reviewed by Anders Carlsson.
2293
2294         Adopting different initializer for WebEvent to fix the build.
2295
2296         * DumpRenderTree/mac/EventSendingController.mm:
2297         (-[EventSendingController keyDown:withModifiers:withLocation:]):
2298
2299 2016-05-16  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
2300
2301         Add machine-readable results for JSC API tests to the Buildbot json log
2302         https://bugs.webkit.org/show_bug.cgi?id=157642
2303
2304         Reviewed by Geoffrey Garen.
2305
2306         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2307         (RunJavaScriptCoreTests): Use --no-fail-fast option on run-javascriptcore-tests
2308         * Scripts/run-javascriptcore-tests:
2309         (runJSCStressTests): Abstracted out writing JSON to file (new function below)
2310         (writeJsonDataIfApplicable): Added
2311
2312 2016-04-06  Jer Noble  <jer.noble@apple.com>
2313
2314         [WK2] Add API to WKWebViewConfiguration to control autoplay policy.
2315         https://bugs.webkit.org/show_bug.cgi?id=156312
2316
2317         Reviewed by Dan Bernstein.
2318
2319         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2320         (WTR::initializeWebViewConfiguration):
2321         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
2322         (TEST_F):
2323
2324 2016-05-16  Brent Fulgham  <bfulgham@apple.com>
2325
2326         REGRESSION (r192098): Content missing after copy and paste to Notes App on retina displays
2327         https://bugs.webkit.org/show_bug.cgi?id=157630
2328         <rdar://problem/25277577>
2329
2330         Reviewed by Simon Fraser.
2331
2332         Update test infrastructure to support checking the number of images in the pasteboard.
2333
2334         * DumpRenderTree/TestRunner.cpp:
2335         (imageCountInGeneralPasteboardCallback): Added.
2336         (TestRunner::staticFunctions):
2337         * DumpRenderTree/TestRunner.h:
2338         * DumpRenderTree/mac/TestRunnerMac.mm:
2339         (TestRunner::imageCountInGeneralPasteboard): Added.
2340         * DumpRenderTree/win/TestRunnerWin.cpp:
2341         (TestRunner::imageCountInGeneralPasteboard): Added stub method.
2342         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2343         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2344         (WTR::InjectedBundle::imageCountInGeneralPasteboard): Added.
2345         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2346         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2347         (WTR::TestRunner::imageCountInGeneralPasteboard): Added.
2348         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2349         * WebKitTestRunner/TestController.cpp:
2350         (WTR::TestController::imageCountInGeneralPasteboard): Added stub implementation.
2351         * WebKitTestRunner/TestController.h:
2352         * WebKitTestRunner/TestInvocation.cpp:
2353         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle): Handle copy message.
2354         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2355         (WTR::TestController::imageCountInGeneralPasteboard): Added.
2356
2357 2016-05-13  Dewei Zhu  <dewei_zhu@apple.com>
2358
2359         Fix JSBench which causes math domain error in run-benchmark script.
2360         https://bugs.webkit.org/show_bug.cgi?id=157697
2361         <rdar://problem/26279292>
2362
2363         Reviewed by Ryosuke Niwa.
2364
2365         Some tests of JSBench give time usage to be 0 ms which will causes error while calculating geometric mean.
2366         Also fix a round-off error while calculating stdev.
2367
2368         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
2369         (BenchmarkResults._format_values):
2370         * Scripts/webkitpy/benchmark_runner/data/patches/JSBench.patch:
2371
2372 2016-05-13  Brady Eidson  <beidson@apple.com>
2373
2374         Extend protector naming code style guideline to cover operator= assignment.
2375         https://bugs.webkit.org/show_bug.cgi?id=157693
2376
2377         Reviewed by Darin Adler.
2378
2379         * Scripts/webkitpy/style/checkers/cpp.py:
2380         (check_identifier_name_in_declaration):
2381         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2382         (WebKitStyleTest.test_names):
2383
2384 2016-05-13  Aakash Jain  <aakash_jain@apple.com>
2385
2386         Dashboard code restructuring
2387         https://bugs.webkit.org/show_bug.cgi?id=157680
2388         <rdar://problem/14736888>
2389
2390         Reviewed by Alexey Proskuryakov.
2391
2392         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js:
2393         (BubbleQueueView.prototype.addLinkToRow): Moved to base class.
2394         (BubbleQueueView.prototype.addTextToRow): Moved to base class.
2395         (BubbleQueueView.prototype._addDividerToPopover): Moved to base class.
2396         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
2397         (BuildbotBuilderQueueView.prototype.update): Passing additional argument to _appendPendingRevisionCount.
2398         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
2399         (BuildbotCombinedQueueView.prototype.update): Passing additional argument to _appendPendingRevisionCount.
2400         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2401         (BuildbotTesterQueueView.prototype.update): Passing additional argument to _appendPendingRevisionCount.
2402         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2403         (BuildbotQueueView.prototype._appendPendingRevisionCount): Moved to base class and modified to take
2404         additional argument.
2405         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Moved to base class.
2406         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Moved to base class.
2407         (BuildbotQueueView.prototype._addDividerToPopover): Moved to base class.
2408         (BuildbotQueueView.prototype._formatRevisionForDisplay): Moved to base class.
2409         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2410         (documentReady): Display any customView if available.
2411         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
2412         (QueueView.prototype.addLinkToRow): Moved from child class, no changes.
2413         (QueueView.prototype.addTextToRow): Moved from child class, no changes.
2414         (QueueView.prototype._addDividerToPopover): Moved from child class, no changes.
2415         (QueueView.prototype._appendPendingRevisionCount): Moved from child class, made it more generic
2416         by taking latestIterationGetter method as an argument.
2417         (QueueView.prototype._popoverLinesForCommitRange): Moved from child class, no changes.
2418         (QueueView.prototype._presentPopoverForPendingCommits): Moved from child class, no changes.
2419         (QueueView.prototype._formatRevisionForDisplay): Moved from child class, no changes.
2420         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2421         (a:hover:link): Underline only when there is a link.
2422
2423 2016-05-13  Yoav Weiss  <yoav@yoav.ws>
2424
2425         Turn on WEB_TIMING for all ports
2426         https://bugs.webkit.org/show_bug.cgi?id=157673
2427
2428         Reviewed by Alex Christensen.
2429
2430         * Scripts/webkitperl/FeatureList.pm: Make sure that WEB_TIMING is on by default.
2431
2432 2016-05-13  Brady Eidson  <beidson@apple.com>
2433
2434         Protector Ref/RefPtrs should have a specified naming style.
2435         https://bugs.webkit.org/show_bug.cgi?id=157591
2436
2437         Reviewed by Darin Adler.
2438
2439         * Scripts/webkitpy/style/checkers/cpp.py:
2440         (check_identifier_name_in_declaration):
2441         (CppChecker):
2442         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2443         (WebKitStyleTest.test_names):
2444
2445 2016-05-12  Csaba Osztrogonác  <ossy@webkit.org>
2446
2447         Remove ENABLE(ES6_ARROWFUNCTION_SYNTAX) guards
2448         https://bugs.webkit.org/show_bug.cgi?id=157564
2449
2450         Reviewed by Darin Adler.
2451
2452         * Scripts/webkitperl/FeatureList.pm:
2453         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2454
2455 2016-05-11  Joanmarie Diggs  <jdiggs@igalia.com>
2456
2457         [GTK] accessibility/aria-readonly.html is failing
2458         https://bugs.webkit.org/show_bug.cgi?id=98357
2459
2460         Reviewed by Chris Fleizach.
2461
2462         Add checks to isAttributeSettable() for ATK_STATE_READ_ONLY and the 'readonly'
2463         AtkObject attribute along with ATK_STATE_CHECKABLE for toggle-able elements,
2464         ATK_STATE_SELECTABLE for select elements, and ATK_STATE_FOCUSABLE combined
2465         with range verification for inputs which implement AtkValue. The latter two
2466         additions are admittedly a heuristic workaround for platform accessibility
2467         API differences. But they should be sufficient to facilitate cross-platform
2468         testing of isAttributeSettable() for form elements which lack ARIA attributes.
2469
2470         Bump the minimum version of at-spi2-core and at-spi2-atk
2471         to 2.15.4 (earliest version that supports STATE_READ_ONLY).
2472
2473         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2474         (WTR::AccessibilityUIElement::isAttributeSettable):
2475         * gtk/jhbuild.modules:
2476
2477 2016-05-10  Ryan Haddad  <ryanhaddad@apple.com>
2478
2479         Another attempt to fix the build after r200668.
2480
2481         Unreviewed build fix.
2482
2483         * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
2484         (TEST):
2485
2486 2016-05-10  Dan Bernstein  <mitz@apple.com>
2487
2488         Tried to fix the Mac build after r200668.
2489
2490         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2491         (WTR::TestController::platformCreateWebView):
2492
2493 2016-05-10  Sam Weinig  <sam@webkit.org>
2494
2495         Tweak underline style for data detected links
2496         https://bugs.webkit.org/show_bug.cgi?id=157546
2497
2498         Reviewed by Tim Horton.
2499
2500         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2501         * TestWebKitAPI/Tests/WebCore/Color.cpp: Added.
2502         (TestWebKitAPI::TEST):
2503         Add tests for the new Color::getHSV() function.
2504
2505 2016-05-10  Filip Pizlo  <fpizlo@apple.com>
2506
2507         Internal JSC profiler should have a timestamped log of events for each code block
2508         https://bugs.webkit.org/show_bug.cgi?id=157538
2509
2510         Reviewed by Benjamin Poulain.
2511
2512         * Scripts/display-profiler-output:
2513
2514 2016-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
2515
2516         [Linux] Remove seccomp filters support
2517         https://bugs.webkit.org/show_bug.cgi?id=157380
2518
2519         Reviewed by Darin Adler.
2520
2521         * Scripts/webkitperl/FeatureList.pm:
2522         * TestWebKitAPI/PlatformEfl.cmake:
2523         * TestWebKitAPI/PlatformGTK.cmake:
2524         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp: Removed.
2525         * efl/jhbuild.modules:
2526         * gtk/jhbuild.modules:
2527
2528 2016-05-09  Simon Fraser  <simon.fraser@apple.com>
2529
2530         [iOS] visibility:hidden -webkit-overflow-scrolling: touch divs can interfere with page scrolling
2531         https://bugs.webkit.org/show_bug.cgi?id=157496
2532         rdar://problem/22963278
2533
2534         Reviewed by Tim Horton.
2535
2536         Enhance UIScriptController to generate a drag, which is useful for scrolling.
2537
2538         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
2539         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
2540         (WTR::UIScriptController::dragFromPointToPoint):
2541         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
2542         * WebKitTestRunner/ios/HIDEventGenerator.h:
2543         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2544         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
2545         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2546         (WTR::UIScriptController::dragFromPointToPoint):
2547
2548 2016-05-09  Simon Fraser  <simon.fraser@apple.com>
2549
2550         Remove testRunner.setTextAutosizingEnabled and migrate the one test that uses it
2551         https://bugs.webkit.org/show_bug.cgi?id=157480
2552
2553         Reviewed by Zalan Bujtas.
2554
2555         Migrate the one test that used testRunner.setTextAutosizingEnabled() to window.internals.settings.setTextAutosizingEnabled()
2556         and move it next to the other iOS text autosizing tests.
2557         
2558         Remove testRunner.setTextAutosizingEnabled(), which was only implemented in DumpRenderTree.
2559
2560         * DumpRenderTree/TestRunner.cpp:
2561         (setTextAutosizingEnabledCallback): Deleted.
2562         (TestRunner::staticFunctions): Deleted.
2563         * DumpRenderTree/mac/TestRunnerMac.mm:
2564         (TestRunner::setTextAutosizingEnabled): Deleted.
2565
2566 2016-05-07  Darin Adler  <darin@apple.com>
2567
2568         Next step on dictionary bindings, along with other bindings refinements
2569         https://bugs.webkit.org/show_bug.cgi?id=157451
2570
2571         Reviewed by Chris Dumez.
2572
2573         * Scripts/do-webcore-rename: Use this to rename JSDOMBuild.h to JSDOMConvert.h.
2574         Also skip test expectations in a directory that this was modifying unnecessarily.
2575
2576 2016-05-06  Simon Fraser  <simon.fraser@apple.com>
2577
2578         Enable IOS_TEXT_AUTOSIZING on Mac and make it testable
2579         https://bugs.webkit.org/show_bug.cgi?id=157432
2580         rdar://problem/16406720
2581
2582         Reviewed by Dean Jackson.
2583
2584         Enable IOS_TEXT_AUTOSIZING on Mac so it can be tested.
2585
2586         Make the setTextAutosizingEnabled() Setting work, and plumb it through WK1 and WK2
2587         preferences for WTR and DRT. Make textAutosizingWindowSizeOverride() work, for layout tests.
2588         These two settings are shared with TEXT_AUTOSIZING.
2589
2590         Add a TextAutosizing log channel, which is useful for generated -expected.html results.
2591
2592         Move adjustComputedFontSizesOnBlocks() and related code from RenderObject to RenderElement
2593         without changes.
2594
2595         An implication of this set of changes is that the way clients enable text autosizing
2596         has changed. Previously, they set the "MinimumZoomFontSize" preference to 0.
2597         Settings::defaultMinimumZoomFontSize() used to do this in order to enable text autosizing
2598         on iPhone only, not iPad.
2599
2600         Now the preferred technique is to leave minimumZoomFontSize alone, and to use textAutosizingEnabled()
2601         instead. Settings::defaultTextAutosizingEnabled() now does the check for iPhone.
2602
2603         UIWebView calls WebKitGetMinimumZoomFontSize() to setup the default minimum font zoom size,
2604         which will now always return 15, but had no other code that toggled this. So it's safe to just rely
2605         on Settings::defaultTextAutosizingEnabled() doing the right thing for iPhone/iPad.
2606
2607         * DumpRenderTree/mac/DumpRenderTree.mm:
2608         (resetWebPreferencesToConsistentValues):
2609         * DumpRenderTree/mac/TestRunnerMac.mm:
2610         (TestRunner::setTextAutosizingEnabled):
2611         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2612         * WebKitTestRunner/ios/TestControllerIOS.mm:
2613         (WTR::TestController::platformResetPreferencesToConsistentValues):
2614
2615 2016-05-06  Dean Jackson  <dino@apple.com>
2616
2617         Regions, Shapes and Tracks don't need runtime features
2618         https://bugs.webkit.org/show_bug.cgi?id=157426
2619         <rdar://problem/26146262>
2620
2621         Reviewed by Simon Fraser.
2622
2623         The following RuntimeEnabledFeatures can be removed since
2624         we have no need to disable them (they are stable and have
2625         shipped for a while):
2626         - CSS Regions
2627         - CSS Shapes
2628         - Media tracks
2629
2630         * DumpRenderTree/mac/DumpRenderTree.mm:
2631         (resetWebPreferencesToConsistentValues): Deleted.
2632
2633 2016-05-06  Ryan Haddad  <ryanhaddad@apple.com>
2634
2635         Increase delay when launching multiple ios-simulators in parallel
2636         https://bugs.webkit.org/show_bug.cgi?id=157422
2637
2638         Reviewed by Alexey Proskuryakov.
2639
2640         Tests are intermittently failing when launching multiple simulators in parallel due to "You are opening
2641         this application for the first time" confirmation dialogs. Increasing the delay to alleviate this issue.
2642
2643         * Scripts/webkitpy/port/ios.py:
2644         (IOSSimulatorPort.setup_test_run):
2645
2646 2016-05-06  Per Arne Vollan  <peavo@outlook.com>
2647
2648         [Win] Remove WinXP support.
2649         https://bugs.webkit.org/show_bug.cgi?id=157416
2650
2651         Reviewed by Brent Fulgham.
2652
2653         * win/DLLLauncher/DLLLauncherMain.cpp:
2654         (enableTerminationOnHeapCorruption):
2655
2656 2016-05-06  Manuel Rego Casasnovas  <rego@igalia.com>
2657
2658         [css-grid] Unprefix CSS Grid Layout properties
2659         https://bugs.webkit.org/show_bug.cgi?id=157137
2660
2661         Reviewed by Simon Fraser.
2662
2663         Remove "-webkit" prefix from all the grid layout properties,
2664         including the display value.
2665         Update the source code to remove the prefix where it was used too.
2666
2667         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp:
2668         (TestWebKitAPI::TEST):
2669
2670 2016-05-05  Alexey Proskuryakov  <ap@apple.com>
2671
2672         Partially revert http://trac.webkit.org/r200504
2673         Improve HTTP test names in WebKitTestRunner's crash report information
2674         https://bugs.webkit.org/show_bug.cgi?id=157389
2675
2676         * WebKitTestRunner/cocoa/CrashReporterInfo.mm: Turns out that we can't have URLs
2677         in crash reporter information.
2678
2679 2016-05-05  Alexey Proskuryakov  <ap@apple.com>
2680
2681         Improve HTTP test names in WebKitTestRunner's crash report information
2682         https://bugs.webkit.org/show_bug.cgi?id=157389
2683
2684         Reviewed by Alex Christensen.
2685
2686         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
2687         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Added a FIXME.
2688
2689         * WebKitTestRunner/cocoa/CrashReporterInfo.mm:
2690         (WTR::testDescription): Don't bail out if the port is neither 8000 nor 8443; we
2691         use other port numbers too. For http tests, return the complete URL string, not
2692         just the path.
2693
2694 2016-05-04  Alex Christensen  <achristensen@webkit.org>
2695
2696         Blocked redirected main resource requests need descriptive errors
2697         https://bugs.webkit.org/show_bug.cgi?id=156828
2698         rdar://problem/25711316
2699
2700         Reviewed by Daniel Bates.
2701
2702         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2703         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
2704         Print out the error type to make sure we have the most descriptive error type.
2705
2706 2016-05-05  Enrique Ocaña González  <eocanha@igalia.com>
2707
2708         [GStreamer] Bump internal jhbuild versions to 1.8.0 and patches to support MSE
2709         https://bugs.webkit.org/show_bug.cgi?id=157341
2710
2711         Reviewed by Xabier Rodriguez-Calvar.
2712
2713         * gtk/jhbuild.modules:
2714         * gtk/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Added.
2715         * gtk/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Added.
2716
2717 2016-05-04  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
2718
2719         Add JSC test results in JSON format to a Buildbot log
2720         https://bugs.webkit.org/show_bug.cgi?id=156920
2721
2722         Reviewed by Daniel Bates.
2723
2724         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2725         (RunJavaScriptCoreTests): Move command-line option for output file out
2726         of WithProperties.
2727
2728 2016-05-04  Dean Jackson  <dino@apple.com>
2729
2730         TestRunner should always enable all the experimental features
2731         https://bugs.webkit.org/show_bug.cgi?id=157360
2732         <rdar://problem/26099748>
2733
2734         Reviewed by Anders Carlsson.
2735
2736         Call the new SPI that enables all the experimental features.
2737
2738         * WebKitTestRunner/TestController.cpp:
2739         (WTR::TestController::resetPreferencesToConsistentValues):
2740
2741 2016-05-04  Mark Lam  <mark.lam@apple.com>
2742
2743         ES6 Function.name inferred from property names of literal objects can break some websites.
2744         https://bugs.webkit.org/show_bug.cgi?id=157246
2745
2746         Reviewed by Geoffrey Garen.
2747
2748         * WebKitTestRunner/TestController.cpp:
2749         (WTR::TestController::resetPreferencesToConsistentValues):
2750         (WTR::updateTestOptionsFromTestHeader):
2751         * WebKitTestRunner/TestOptions.h:
2752
2753         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2754         (WTR::PlatformWebView::viewSupportsOptions):
2755         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2756         (WTR::PlatformWebView::viewSupportsOptions):
2757         - Add needsSiteSpecificQuirks to WKTR options that can be set. 
2758
2759 2016-05-04  Joanmarie Diggs  <jdiggs@igalia.com>
2760
2761         AX: ARIA 'region' role is now a landmark; HTML 'section' element should be a landmark only if named
2762         https://bugs.webkit.org/show_bug.cgi?id=157331
2763
2764         Reviewed by Chris Fleizach.
2765
2766         Add AXLandmarkRegion to the landmark strings handled by roleToString
2767         for objects with ATK_ROLE_LANDMARK.
2768
2769         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2770
2771 2016-05-03  Beth Dakin  <bdakin@apple.com>
2772
2773         Add VideoControlsManager tests
2774         https://bugs.webkit.org/show_bug.cgi?id=157332
2775         -and corresponding-
2776         rdar://problem/24358431
2777
2778         Reviewed by Sam Weinig.
2779
2780         This patch adds three VideoControlsManager tests.
2781
2782         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2783         * TestWebKitAPI/Tests/WebKit/ios/video-with-audio.html:
2784         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: Added.
2785         (-[DidPlayMessageHandler initWithWKWebView:]):
2786         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]):
2787         (TestWebKitAPI::TEST):
2788         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html: Added.
2789         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.mp4: Added.
2790         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-without-audio.html: Added.
2791
2792 2016-05-03  Joanmarie Diggs  <jdiggs@igalia.com>
2793
2794         [ATK] accessibility/document-attributes.html is failing
2795         https://bugs.webkit.org/show_bug.cgi?id=125348
2796
2797         Reviewed by Chris Fleizach.
2798
2799         The test was failing because the WebArea is now being exposed with the role of
2800         ATK_ROLE_DOCUMENT_WEB; not ATK_ROLE_DOCUMENT_FRAME. Unfortunately, when that
2801         change was made, documentEncoding() and documentURI() were not updated accordingly.
2802
2803         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2804         (WTR::AccessibilityUIElement::documentEncoding):
2805         (WTR::AccessibilityUIElement::documentURI):
2806
2807 2016-05-03  Brent Fulgham  <bfulgham@apple.com>
2808
2809         [Win] Unreviewed build fix.
2810
2811         * EWSTools/start-queue-win.sh: Establish proper VS2015 build
2812         environment at start of queue run.
2813
2814 2016-05-03  Joanmarie Diggs  <jdiggs@igalia.com>
2815
2816         [ATK] accessibility/content-editable-as-textarea.html fails
2817         https://bugs.webkit.org/show_bug.cgi?id=155353
2818
2819         Reviewed by Darin Adler.
2820
2821         The test was timing out because it expected an AXValueChanged notification.
2822         In ATK, AXValueChanged notifications are made for widgets which implement
2823         the AtkValue interface (sliders, progress bars, etc.). We should be listening
2824         for AXTextChanged instead. AtkText's text-insert and text-remove have been
2825         added to the AccessibilityNotificationHandler.
2826
2827         Also, ATK's AccessibilityUIElement support had a number of unimplemented
2828         methods that are being used as part of the previously-failing test. Those
2829         methods are now implemented so that the ATK results are much more similar
2830         to those on the Mac.
2831
2832         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2833         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
2834         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2835         (WTR::AccessibilityUIElement::stringAttributeValue):
2836         (WTR::AccessibilityUIElement::rangeForLine):
2837         (WTR::AccessibilityUIElement::boundsForRange):
2838         (WTR::AccessibilityUIElement::attributedStringForRange):
2839
2840 2016-05-02  Brady Eidson  <beidson@apple.com>
2841
2842         Add the ability to accumulate logs for specific logging channels to help diagnose test timeouts.
2843         https://bugs.webkit.org/show_bug.cgi?id=157274
2844
2845         Reviewed by Alex Christensen.
2846
2847         Add the new accumulate method to DRT's TestRunner, dump the accumulated logs if there's a timeout,
2848         and reset them in between tests:
2849         * DumpRenderTree/TestRunner.cpp:
2850         (accummulateLogsForChannel):
2851         (TestRunner::staticFunctions):
2852         (TestRunner::waitToDumpWatchdogTimerFired):
2853         (TestRunner::setAccummulateLogsForChannel):
2854         * DumpRenderTree/TestRunner.h:
2855         * DumpRenderTree/mac/DumpRenderTree.mm:
2856         (resetWebViewToConsistentStateBeforeTesting):
2857
2858         Also add the new method to WKTR's TestRunner, but just stubbed for now:
2859         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2860         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2861         (WTR::TestRunner::accummulateLogsForChannel):
2862         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2863
2864 2016-05-02  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
2865
2866         Add fail-fast option to run-javascriptcore-tests
2867         https://bugs.webkit.org/show_bug.cgi?id=157270
2868
2869         Reviewed by Geoffrey Garen.
2870
2871         * Scripts/run-javascriptcore-tests: Add fail-fast command line option.
2872         Defaults to yes, which is the current behavior.
2873
2874 2016-05-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2875
2876         [CMake] MiniBrowser fails to build because libsoup link flags are not defined.
2877         https://bugs.webkit.org/show_bug.cgi?id=157268
2878
2879         Reviewed by Michael Catanzaro.
2880
2881         * MiniBrowser/gtk/CMakeLists.txt:
2882
2883 2016-04-30  Darin Adler  <darin@apple.com>
2884
2885         Streamline and remove unused bindings generation code
2886         https://bugs.webkit.org/show_bug.cgi?id=157237
2887
2888         Reviewed by Chris Dumez.
2889
2890         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
2891         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2892         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2893         Replace non-standard "int" with standard "long", which means the same thing.
2894
2895 2016-04-30  Darin Adler  <darin@apple.com>
2896
2897         Next batch of conversions to use C++ enum class instead of strings for enumerations
2898         https://bugs.webkit.org/show_bug.cgi?id=157232
2899
2900         Reviewed by Chris Dumez.
2901
2902         * Scripts/webkitpy/style/checker.py: Skip the bindings script tests when doing style
2903         checking. We don't want to waste time trying to make our generated code match our style.
2904
2905 2016-04-29  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
2906
2907         Add JSC test results in JSON format to a Buildbot log.
2908         https://bugs.webkit.org/show_bug.cgi?id=156920
2909
2910         Reviewed by Daniel Bates.
2911
2912         Generate JSON results for JSC tests and upload them to the master
2913         using Buildbot's logfiles machinery.
2914
2915         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2916         (RunJavaScriptCoreTests): Use --json-output option when invoking the
2917         run-javascriptcore-tests Perl script, and expose this JSON output as a 
2918         Buildbot log.
2919         * Scripts/run-javascriptcore-tests:
2920         (runJSCStressTests): Change key names and remove redundant count key.
2921
2922 2016-04-29  Joanmarie Diggs  <jdiggs@igalia.com>
2923
2924         [ATK] Expose the value of aria-roledescription via an AtkObject attribute
2925         https://bugs.webkit.org/show_bug.cgi?id=146719
2926
2927         Reviewed by Chris Fleizach.
2928
2929         Implement roleDescription() so that the implementation can be tested.
2930
2931         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2932         (WTR::AccessibilityUIElement::roleDescription):
2933
2934 2016-04-27  Alexey Proskuryakov  <ap@apple.com>
2935
2936         Don't throttle GuardMalloc on 8-core Macs
2937         https://bugs.webkit.org/show_bug.cgi?id=157108
2938
2939         Reviewed by Alex Christensen.
2940
2941         This was making them slower unnecessarily.
2942
2943         * Scripts/webkitpy/port/mac.py: (MacPort.default_child_processes):
2944
2945 2016-04-26  Konstantin Tokarev  <annulen@yandex.ru>
2946
2947         Unreviewed: add myself to the committers list.
2948
2949         * Scripts/webkitpy/common/config/contributors.json:
2950
2951 2016-04-26  Ryosuke Niwa  <rniwa@webkit.org>
2952
2953         Fix text in log files autogenerated by import-w3c-tests
2954         https://bugs.webkit.org/show_bug.cgi?id=157021
2955
2956         Unreviewed. Fixing the second typo.
2957
2958         * Scripts/webkitpy/w3c/test_importer.py:
2959         (TestImporter.write_import_log):
2960
2961 2016-04-26  Filip Pizlo  <fpizlo@apple.com>
2962
2963         WebCore on Mac ignores the user's preferred region (country) while getting the language
2964         https://bugs.webkit.org/show_bug.cgi?id=156993
2965
2966         Reviewed by Geoffrey Garen.
2967
2968         Change the test expectations for this test. If the variant is not explicitly specified in
2969         the AppleLanguage, then we use the locale's country code, which this test assumes is US.
2970
2971         * TestWebKitAPI/Tests/mac/NavigatorLanguage.mm:
2972         (TestWebKitAPI::languageForSystemLanguage):
2973         (TestWebKitAPI::TEST):
2974
2975 2016-04-25  Ryosuke Niwa  <rniwa@webkit.org>
2976
2977         Remove the build flag for template elements
2978         https://bugs.webkit.org/show_bug.cgi?id=157022
2979
2980         Reviewed by Daniel Bates.
2981
2982         Removed the build option.
2983
2984         * Scripts/webkitperl/FeatureList.pm:
2985
2986 2016-04-25  Ryosuke Niwa  <rniwa@webkit.org>
2987
2988         Fix text in log files autogenerated by import-w3c-tests
2989         https://bugs.webkit.org/show_bug.cgi?id=157021
2990
2991         Reviewed by Chris Dumez.
2992
2993         s/Webkit/WebKit/ and end each sentence with a period.
2994
2995         * Scripts/webkitpy/w3c/test_importer.py:
2996         (TestImporter.write_import_log):
2997
2998 2016-04-25  Myles C. Maxfield  <mmaxfield@apple.com>
2999
3000         [Cocoa] Guarantee FontPlatformData's m_cgFont is never nullptr
3001         https://bugs.webkit.org/show_bug.cgi?id=156929
3002
3003         Reviewed by Darin Adler.
3004
3005         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
3006         (TestWebKitAPI::TEST):
3007
3008 2016-04-25  Caitlin Potter  <caitp@igalia.com>
3009
3010         [Tools] whitelist all-uppercase JSTokenType enum in JavaScriptCore
3011         https://bugs.webkit.org/show_bug.cgi?id=156976
3012
3013         Reviewed by Darin Adler.
3014
3015         Mitigate style-checker spam on bugs which introduce new JavaScript
3016         token types.
3017
3018         * Scripts/webkitpy/style/checkers/cpp.py:
3019         (_EnumState.__init__):
3020         (_EnumState.process_clean_line):
3021         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3022         (NoNonVirtualDestructorsTest.test_enum_casing):
3023
3024 2016-04-25  Simon Fraser  <simon.fraser@apple.com>
3025
3026         Fix issues with content-animation performance tests
3027         https://bugs.webkit.org/show_bug.cgi?id=157001
3028
3029         Reviewed by Sam Weinig.
3030
3031         Add patch content for svg-animation.html, and fix the paths in the patch so
3032         it applies correctly.
3033
3034         Add the patch file to the .plan file.
3035
3036         * Scripts/webkitpy/benchmark_runner/data/patches/ContentAnimation.patch:
3037         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
3038
3039 2016-04-25  Brady Eidson  <beidson@apple.com>
3040
3041         Tweaking IndexedDB watchlist and adding myself to it.
3042
3043         * Scripts/webkitpy/common/config/watchlist:
3044
3045 2016-04-25  Commit Queue  <commit-queue@webkit.org>
3046
3047         Unreviewed, rolling out r199916.
3048         https://bugs.webkit.org/show_bug.cgi?id=156989
3049
3050         Might break buildbot when master is restarted (Requested by
3051         Srinivasan Vijayaraghava, Guest100, on #webkit).
3052
3053         Reverted changeset:
3054
3055         "Add JSC test results in json format to a buildbot log"
3056         https://bugs.webkit.org/show_bug.cgi?id=156920
3057         http://trac.webkit.org/changeset/199916
3058
3059 2016-04-23  Chris Dumez  <cdumez@apple.com>
3060
3061         [WebIDL] Drop [Default] WebKit-IDL extended attribute
3062         https://bugs.webkit.org/show_bug.cgi?id=156955
3063
3064         Reviewed by Darin Adler.
3065
3066         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3067
3068 2016-04-23  Csaba Osztrogonác  <ossy@webkit.org>
3069
3070         Really enable INDEXED_DATABASE on Apple Mac cmake build
3071         https://bugs.webkit.org/show_bug.cgi?id=156902
3072
3073         Reviewed by Michael Catanzaro.
3074
3075         * Scripts/webkitperl/FeatureList.pm:
3076
3077 2016-04-23  Andy Estes  <aestes@apple.com>
3078
3079         check-webkit-style: fix false-positive warnings about @synchronized
3080         https://bugs.webkit.org/show_bug.cgi?id=156957
3081
3082         Reviewed by Dan Bernstein.
3083
3084         * Scripts/webkitpy/style/checkers/cpp.py:
3085         (check_spacing_for_function_call): Ignore @synchronized lines.
3086         (check_braces): Ditto.
3087         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3088         (CppStyleTest.test_brace_at_begin_of_line): Added a test case.
3089
3090 2016-04-22  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
3091
3092         Add JSC test results in json format to a buildbot log
3093         https://bugs.webkit.org/show_bug.cgi?id=156920
3094
3095         Reviewed by Alexey Proskuryakov.
3096
3097         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3098         (RunJavaScriptCoreTests):
3099         Add runtime flag to output json into buildbot
3100         * Scripts/run-javascriptcore-tests:
3101         (runJSCStressTests):
3102         Change key names and remove redundant count key
3103
3104 2016-04-22  Ryan Haddad  <ryanhaddad@apple.com>
3105
3106         Update expected result for WKPreferencesGetOfflineWebApplicationCacheEnabled after r199854
3107
3108         Unreviewed test gardening.
3109
3110         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3111         (TestWebKitAPI::TEST):
3112
3113 2016-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3114
3115         [GTK] Enable the download attribute support
3116         https://bugs.webkit.org/show_bug.cgi?id=99025
3117
3118         Reviewed by Žan Doberšek.
3119
3120         * Scripts/webkitperl/FeatureList.pm:
3121
3122 2016-04-21  Keith Miller  <keith_miller@apple.com>
3123
3124         WebScriptObject description swizzler should work in a multi-threaded world
3125         https://bugs.webkit.org/show_bug.cgi?id=156808
3126
3127         Add a test for our NSObject swizzling TLS implementation. The test runs on
3128         two threads. One in JS and another in Objective-C. We expect the JS thread
3129         to use our NSObject description override and the Objective-C thread to act
3130         as though it was using the original NSObject description method.
3131
3132         Reviewed by Geoffrey Garen.
3133
3134         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3135         * TestWebKitAPI/Tests/mac/WebScriptObjectDescription.html: Added.
3136         * TestWebKitAPI/Tests/mac/WebScriptObjectDescription.mm: Added.
3137         (nsObjectDescriptionTest):
3138         (-[WebScriptDescriptionTest webView:didFinishLoadForFrame:]):
3139         (TestWebKitAPI::TEST):
3140
3141 2016-04-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3142
3143         [GTK] WebKitWebView should claim the contents size as its natural size
3144         https://bugs.webkit.org/show_bug.cgi?id=156835
3145
3146         Reviewed by Žan Doberšek.
3147
3148         Add test case to check the WebKitWebView preferred size.
3149
3150         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3151         (testWebViewPreferredSize):
3152         (beforeAll):
3153
3154 2016-04-20  Simon Fraser  <simon.fraser@apple.com>
3155
3156         Add content animation tests to benchmark_runner, and allow the runner to collect device data as part of the results
3157         https://bugs.webkit.org/show_bug.cgi?id=156827
3158         
3159         Update the .plan file now that the files are present in SVN.
3160
3161         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
3162
3163 2016-04-20  Simon Fraser  <simon.fraser@apple.com>
3164
3165         Add content animation tests to benchmark_runner, and allow the runner to collect device data as part of the results
3166         https://bugs.webkit.org/show_bug.cgi?id=156827
3167         rdar://problem/24358135
3168
3169         Reviewed by Stephanie Lewis.
3170
3171         Enhance benchmark_runner so that a benchmark can load a set of tests sequentially,
3172         and collate results across them. Also add the ability for the browser_driver to supply
3173         additional results, allowing for tests that collect results data in native code, rather
3174         than generating it in the web page.
3175
3176         Add a set of "content animation" tests that use this new functionality, which test
3177         CSS animation and requestAnimationFrame performance.
3178
3179         'plan' files have two new optional keys:
3180             'test_files': a list of files to run as a suite
3181             'options': optional parameters. Currently supports one new option,
3182                 'animation_command', which affects the way that iOS tests are run,
3183                 and is passed to MobileSafari as a parameter on launch.
3184
3185         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
3186         (BenchmarkRunner.__init__): If options is not specified in the plan file, set it to an empty dictionary.
3187         (BenchmarkRunner._get_result): Allow the browser_driver to modify the test results.
3188         (BenchmarkRunner):
3189         (BenchmarkRunner._run_one_test): Factored out of _run_benchmark, this contains logic for
3190         running a single test. It starts and stops the http_server_driver.
3191         (BenchmarkRunner._run_benchmark): Run a test in the traditional way if the plan has an 'entry_point'
3192         key, otherwise look for the new 'test_files' and load each in a loop.
3193         (BenchmarkRunner._dump):
3194         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
3195         (BrowserDriver.launch_url): Pass options.
3196         (BrowserDriver.add_additional_results): Allow a driver to supply additional results.
3197         (BrowserDriver):
3198         * Scripts/webkitpy/benchmark_runner/browser_driver/gtk_minibrowser_driver.py:
3199         (GTKMiniBrowserDriver.launch_url):
3200         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3201         (OSXBrowserDriver.close_browsers):
3202         (OSXBrowserDriver._terminate_processes): Fix spelling mistake.
3203         (OSXBrowserDriver._terminiate_processes): Deleted.
3204         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
3205         (OSXChromeDriver.launch_url):
3206         (OSXChromeCanaryDriver.launch_url):
3207         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
3208         (OSXFirefoxDriver.launch_url):
3209         (OSXFirefoxNightlyDriver.launch_url):
3210         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
3211         (OSXSafariDriver.launch_url):
3212         * Scripts/webkitpy/benchmark_runner/data/patches/ContentAnimation.patch: Added.
3213         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan: Added.
3214
3215 2016-04-20  Dustin Falgout  <dustin@falgout.us>
3216
3217         [GTK] Expose AllowUniversalAccessFromFileURLs preference now that calling localStorage.getItem() results in SecurityError: DOM Exception 18
3218         https://bugs.webkit.org/show_bug.cgi?id=156651
3219
3220         Reviewed by Michael Catanzaro.
3221
3222         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
3223         (testWebKitSettings):
3224
3225 2016-04-20  Brady Eidson  <beidson@apple.com>
3226
3227         Modern IDB (Workers): Enable INDEXED_DATABASE_IN_WORKERS compile time flag, but disabled in RuntimeEnabledFeatures.
3228         https://bugs.webkit.org/show_bug.cgi?id=156782
3229
3230         Reviewed by Alex Christensen.
3231
3232         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3233
3234 2016-04-19  Brent Fulgham  <bfulgham@apple.com>
3235
3236         Unreviewed build fix after r199752.
3237
3238         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3239         (FrameLoadDelegate::didChangeIcons): Remove call to removed function.
3240
3241 2016-04-19  Brent Fulgham  <bfulgham@apple.com>
3242
3243         Remove remaining bits of dynamic <link> rel='icon' loading
3244         https://bugs.webkit.org/show_bug.cgi?id=156727
3245
3246         Reviewed by Darin Adler.
3247
3248         Remove unused test infrastructure. This code never existed in WebKit2
3249         testing since was only used on Windows.
3250
3251         * DumpRenderTree/TestRunner.cpp:
3252         (dumpIconChangesCallback): Deleted.
3253         * DumpRenderTree/TestRunner.h:
3254         (TestRunner::dumpIconChanges): Deleted.
3255         (TestRunner::setDumpIconChanges): Deleted.
3256
3257 2016-04-19  Keith Miller  <keith_miller@apple.com>
3258
3259         ObjcInstance::stringValue should not call NSObject's description method
3260         https://bugs.webkit.org/show_bug.cgi?id=156758
3261
3262         Reviewed by Geoffrey Garen.
3263
3264         Add new methods to ObjCController that expose two Types of WebScriptObjects. The first is
3265         an NSObject and the second is an NSArray of NSObjects. These are used to test that we don't
3266         call the NSObjects description method without first swizzling it.
3267
3268         * DumpRenderTree/mac/ObjCController.m:
3269         (+[ObjCController isSelectorExcludedFromWebScript:]):
3270         (+[ObjCController webScriptNameForSelector:]):
3271         (-[ObjCController testArrayOfObjects]):
3272         (-[ObjCController testObject]):
3273
3274 2016-04-18  Dan Bernstein  <mitz@apple.com>
3275
3276         Fixed building with old Xcode.
3277
3278         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
3279         (TEST):
3280
3281 2016-04-18  Dean Jackson  <dino@apple.com>
3282
3283         New SPI to export a dictionary of runtime features
3284         https://bugs.webkit.org/show_bug.cgi?id=156645
3285         <rdar://problem/23621666>
3286
3287         Reviewed by Darin Adler.
3288
3289         Test the experimental features SPI on WKPreferences.
3290
3291         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
3292
3293 2016-04-18  Yusuke Suzuki  <utatane.tea@gmail.com>
3294
3295         [JSCOnly] Implement RunLoop and remove glib dependency
3296         https://bugs.webkit.org/show_bug.cgi?id=155706
3297
3298         Reviewed by Michael Catanzaro.
3299
3300         Add TestWTF to JSCOnly port to test WorkQueue and RunLoop.
3301         Platform specific ones locate under jsconly directory since
3302         it is not `generic` (Since it includes the GLIB event loop case).
3303
3304         * CMakeLists.txt:
3305         * TestWebKitAPI/PlatformJSCOnly.cmake: Added.
3306         * TestWebKitAPI/PlatformUtilities.h:
3307         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3308         (TestWebKitAPI::TEST):
3309         * TestWebKitAPI/config.h:
3310         * TestWebKitAPI/jsconly/PlatformUtilitiesJSCOnly.cpp: Renamed from Source/WTF/wtf/none/RunLoopNone.cpp.
3311         (TestWebKitAPI::Util::run):
3312         (TestWebKitAPI::Util::sleep):
3313         * TestWebKitAPI/jsconly/main.cpp: Renamed from Source/WTF/wtf/none/WorkQueueNone.cpp.
3314         (main):
3315
3316 2016-04-18  Jon Lee  <jonlee@apple.com>
3317
3318         Update Animometer plan.
3319         https://bugs.webkit.org/show_bug.cgi?id=156652
3320
3321         Reviewed by Darin Adler.
3322
3323         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r199616.
3324
3325 2016-04-18  Dana Burkart  <dburkart@apple.com>
3326
3327         svn-apply: add option for ignoring changes to ChangeLog files
3328         https://bugs.webkit.org/show_bug.cgi?id=156618
3329
3330         Reviewed by Darin Adler.
3331
3332         This change adds a new option to svn-apply, --skip-changelogs, which short-circuits out of
3333         patch() if the file in question is a ChangeLog.
3334
3335         * Scripts/svn-apply:
3336         (patch):
3337
3338 2016-04-18  Carlos Garcia Campos  <cgarcia@igalia.com>
3339
3340         Pending API Request URL is wrong after reloading
3341         https://bugs.webkit.org/show_bug.cgi?id=139342
3342
3343         Reviewed by Darin Adler.
3344
3345         Update test case to check that the active URL should remain the
3346         same after a reload.
3347
3348         * TestWebKitAPI/Tests/WebKit2/PendingAPIRequestURL.cpp:
3349         (TestWebKitAPI::TEST):
3350
3351 2016-04-18  Carlos Garcia Campos  <cgarcia@igalia.com>
3352
3353         Pending API request URL no set when loading Data, Alternate HTML or plain text
3354         https://bugs.webkit.org/show_bug.cgi?id=136916
3355
3356         Reviewed by Darin Adler.
3357
3358         Add new test to check that active URL is the requested one right
3359         after calling WKPage load methods.
3360
3361         * TestWebKitAPI/PlatformEfl.cmake:
3362         * TestWebKitAPI/PlatformGTK.cmake:
3363         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3364         * TestWebKitAPI/Tests/WebKit2/PendingAPIRequestURL.cpp: Added.
3365         (TestWebKitAPI::TEST):
3366         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
3367         (WebViewTest::loadPlainText): Remove FIXME.
3368         (WebViewTest::loadBytes): Ditto.
3369         (WebViewTest::loadAlternateHTML): Ditto.
3370
3371 2016-04-18  Commit Queue  <commit-queue@webkit.org>
3372
3373         Unreviewed, rolling out r199660.
3374         https://bugs.webkit.org/show_bug.cgi?id=156691
3375
3376         It broke the iOS build (Requested by KaL on #webkit).
3377
3378         Reverted changeset:
3379
3380         "Pending API request URL no set when loading Data, Alternate
3381         HTML or plain text"
3382         https://bugs.webkit.org/show_bug.cgi?id=136916
3383         http://trac.webkit.org/changeset/199660
3384
3385 2016-04-18  Carlos Garcia Campos  <cgarcia@igalia.com>
3386
3387         Pending API request URL no set when loading Data, Alternate HTML or plain text
3388         https://bugs.webkit.org/show_bug.cgi?id=136916
3389
3390         Reviewed by Darin Adler.
3391
3392         Add new test to check that active URL is the requested one right
3393         after calling WKPage load methods.
3394
3395         * TestWebKitAPI/PlatformEfl.cmake:
3396         * TestWebKitAPI/PlatformGTK.cmake:
3397         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3398         * TestWebKitAPI/Tests/WebKit2/PendingAPIRequestURL.cpp: Added.
3399         (TestWebKitAPI::TEST):
3400         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
3401         (WebViewTest::loadPlainText): Remove FIXME.
3402         (WebViewTest::loadBytes): Ditto.
3403         (WebViewTest::loadAlternateHTML): Ditto.
3404
3405 2016-04-18  Jeremy Huddleston Sequoia  <jeremyhu@apple.com>
3406
3407         Fix incorrect assumption that APPLE implies Mac.
3408         https://bugs.webkit.org/show_bug.cgi?id=156679
3409
3410         Addresses build failure introduced in r198947
3411
3412         Reviewed by Alex Christensen.
3413
3414         * CMakeLists.txt:
3415
3416 2016-04-18  Carlos Garcia Campos  <cgarcia@igalia.com>
3417
3418         [GTK] Test /webkit2/WebKitWebView/mouse-target fails with overlay scrollbars
3419         https://bugs.webkit.org/show_bug.cgi?id=156621
3420
3421         Reviewed by Martin Robinson.
3422
3423         This is a problem of the test itself, we are using an overflow that is not actually scrollable, but that shows
3424         scrollbar troughs when not using overlay scrollbars because it's marked as scrollable. It would be easier to
3425         simply use the main frame scrollbars to test that and it will work no matter of scrollbars are overlay or not.
3426
3427         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
3428         (testWebViewMouseTarget): Remove the div and move the mouse over the main frame scrollbar to test scrolbars hit test.
3429
3430 2016-04-17  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3431
3432         [EFL] Bump gstreamer from 1.4.4 to 1.6.3
3433         https://bugs.webkit.org/show_bug.cgi?id=156655
3434
3435         Reviewed by Antonio Gomes.
3436
3437         To support html5 video feature, we should bump gstreamer version.
3438
3439         * efl/jhbuild.modules:
3440         * efl/patches/gst-libav.patch: Update against newer version.
3441         * efl/patches/gst-plugins-bad-remove-gnustep-support.patch: Removed because this patch was merged.
3442
3443 2016-04-16  Sam Weinig  <sam@webkit.org>
3444
3445         More build fixing.
3446
3447         * MiniBrowser/mac/BrowserWindowController.m:
3448         (-[BrowserWindowController share:]):
3449
3450 2016-04-16  Sam Weinig  <sam@webkit.org>
3451
3452         Another build fix.
3453
3454         * MiniBrowser/mac/BrowserWindowController.m:
3455         (-[BrowserWindowController sharingServicePicker:sharingServicesForItems:proposedSharingServices:]):
3456
3457 2016-04-16  Sam Weinig  <sam@webkit.org>
3458
3459         Fix 32-bit build.
3460
3461         * MiniBrowser/mac/BrowserWindowController.m:
3462         (-[BrowserWindowController share:]):
3463         (-[BrowserWindowController fetch:]):
3464         (-[BrowserWindowController sharingService:transitionImageForShareItem:contentRect:]):
3465
3466 2016-04-15  Sam Weinig  <sam@webkit.org>
3467
3468         Add support for NSSharingService to MiniBrowser, for no great reasons
3469         https://bugs.webkit.org/show_bug.cgi?id=156658
3470
3471         Reviewed by Darin Adler.
3472
3473         * MiniBrowser/mac/BrowserWindow.xib:
3474         * MiniBrowser/mac/BrowserWindowController.h:
3475         Add the share button.
3476
3477         * MiniBrowser/mac/BrowserWindowController.m:
3478         (-[BrowserWindowController windowDidLoad]):
3479         Set the share button to fire it's actions on mouse down, as it is supposed to act like a menu.
3480
3481         (-[BrowserWindowController share:]):
3482         Show the picker when the button is pressed.
3483         (-[BrowserWindowController mainContentView]):
3484         Add a new override to get the main content view of derived classes (either a WKWebView or the WebView).
3485
3486         (-[BrowserWindowController sharingServicePicker:sharingServicesForItems:proposedSharingServices:]):
3487         (-[BrowserWindowController sharingServicePicker:delegateForSharingService:]):
3488         (-[BrowserWindowController sharingServicePicker:didChooseSharingService:]):
3489         (-[BrowserWindowController sharingService:sourceFrameOnScreenForShareItem:]):
3490         (-[BrowserWindowController sharingService:transitionImageForShareItem:contentRect:]):
3491         (-[BrowserWindowController sharingService:sourceWindowForShareItems:sharingContentScope:]):
3492         Add delegate methods.
3493
3494         * MiniBrowser/mac/WK1BrowserWindowController.m:
3495         (-[WK1BrowserWindowController mainContentView]):
3496         * MiniBrowser/mac/WK2BrowserWindowController.m:
3497         (-[WK2BrowserWindowController mainContentView]):
3498         Implement to return the web view.
3499
3500 2016-04-16  Alexey Proskuryakov  <ap@apple.com>
3501
3502         Build fix.
3503
3504         Temporary workaround for rdar://problem/25754945.
3505
3506         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:
3507
3508 2016-04-15  Commit Queue  <commit-queue@webkit.org>
3509
3510         Unreviewed, rolling out r199600.
3511         https://bugs.webkit.org/show_bug.cgi?id=156642
3512
3513         It didn't help (Requested by ap_ on #webkit).
3514
3515         Reverted changeset:
3516
3517         "Build fix."
3518         http://trac.webkit.org/changeset/199600
3519
3520 2016-04-15  Alexey Proskuryakov  <ap@apple.com>
3521
3522         Build fix.
3523
3524         * LayoutTestRelay/LayoutTestRelay/main.m: Allow some deprecated methods.
3525
3526 2016-04-14  Alexey Proskuryakov  <ap@apple.com>
3527
3528         Some GuardMalloc bots are not happy when running many parallel processes
3529         https://bugs.webkit.org/show_bug.cgi?id=156614
3530         rdar://problem/24711525
3531
3532         Reviewed by David Kilzer.
3533
3534         * Scripts/webkitpy/port/mac.py: (MacPort.default_child_processes):
3535
3536 2016-04-14  Brent Fulgham  <bfulgham@apple.com>
3537
3538         Make <a download> a runtime enabled option
3539         https://bugs.webkit.org/show_bug.cgi?id=156583
3540         <rdar://problem/25733449>
3541
3542         Reviewed by Alex Christensen.
3543
3544         * DumpRenderTree/mac/DumpRenderTree.mm:
3545         (resetWebPreferencesToConsistentValues):
3546         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3547         (WTR::InjectedBundle::beginTesting):
3548         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3549         (WTR::TestRunner::setDownloadAttributeEnabled):
3550         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3551
3552 2016-04-14  Anders Carlsson  <andersca@apple.com>
3553
3554         Another build fix attempt.
3555
3556         * MiniBrowser/mac/WK2BrowserWindowController.m:
3557
3558 2016-04-14  Anders Carlsson  <andersca@apple.com>
3559
3560         Fix build.
3561
3562         * MiniBrowser/mac/WK2BrowserWindowController.m:
3563         (-[WK2BrowserWindowController webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
3564
3565 2016-04-14  Anders Carlsson  <andersca@apple.com>
3566
3567         [Mac] Add API for open panel handling to WKWebView
3568         https://bugs.webkit.org/show_bug.cgi?id=137759
3569         rdar://problem/23278623
3570
3571         Reviewed by Tim Horton.
3572
3573         Have MiniBrowser implement the new delegate method.
3574
3575         * MiniBrowser/mac/WK2BrowserWindowController.m:
3576         (-[WK2BrowserWindowController webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
3577
3578 2016-04-14  Jiewen Tan  <jiewen_tan@apple.com>
3579
3580         Unreviewed, rolling out r199554.
3581
3582         The change breaks Yosemite Release/Debug build
3583
3584         Reverted changeset:
3585
3586         "[Mac] Add API for open panel handling to WKWebView"
3587         https://bugs.webkit.org/show_bug.cgi?id=137759
3588         http://trac.webkit.org/changeset/199554
3589
3590 2016-04-14  Anders Carlsson  <andersca@apple.com>
3591
3592         [Mac] Add API for open panel handling to WKWebView
3593         https://bugs.webkit.org/show_bug.cgi?id=137759
3594         rdar://problem/23278623
3595
3596         Reviewed by Tim Horton.
3597
3598         Have MiniBrowser implement the new delegate method.
3599
3600         * MiniBrowser/mac/WK2BrowserWindowController.m:
3601         (-[WK2BrowserWindowController webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
3602
3603 2016-04-14  Jon Lee  <jonlee@apple.com>
3604
3605         Update Animometer plan
3606         https://bugs.webkit.org/show_bug.cgi?id=156569
3607
3608         Reviewed by Alex Christensen.
3609
3610         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r199328. Includes update to screen
3611         resolution, starting with complexity of 1, and fixing SVG, multiply, and text tests.
3612
3613 2016-04-13  Alex Christensen  <achristensen@webkit.org>
3614
3615         CMake MiniBrowser should be an app bundle
3616         https://bugs.webkit.org/show_bug.cgi?id=156521
3617
3618         Reviewed by Brent Fulgham.
3619
3620         * MiniBrowser/mac/CMakeLists.txt:
3621         Make an app bundle and compile nibs.
3622         * MiniBrowser/mac/Info.plist:
3623         CMake doesn't know what to do with :rfc1034identifier and there's no reason to keep it.  This is just MiniBrowser.
3624
3625 2016-04-13  Chris Dumez  <cdumez@apple.com>
3626
3627         We should not speculatively revalidate cached redirects
3628         https://bugs.webkit.org/show_bug.cgi?id=156548
3629         <rdar://problem/25583886>
3630
3631         Reviewed by Darin Adler.
3632
3633         Re-enable speculative loading in the context of layout tests. This was
3634         turned off by mistake when speculative loading was turned into a
3635         setting recently.
3636
3637         * WebKitTestRunner/TestController.cpp:
3638         (WTR::TestController::generatePageConfiguration):
3639
3640 2016-04-12  Alexey Proskuryakov  <ap@apple.com>
3641
3642         Python test webkitpy.common.system.executive_unittest.ExecutiveTest.serial_test_kill_process is flaky
3643         https://bugs.webkit.org/show_bug.cgi?id=155367
3644
3645         Reviewed by Darin Adler.
3646
3647         * Scripts/webkitpy/common/system/executive.py: (Executive.kill_process):
3648         Don't flakily consume the return code with waitpid, callers need to do waitpid on
3649         their own. Not sure if this line of code was even intentional.
3650
3651 2016-04-12  Myles C. Maxfield  <mmaxfield@apple.com>
3652
3653         [OS X] Flakey crash after ScrollAnimatorMac destruction
3654         https://bugs.webkit.org/show_bug.cgi?id=156372
3655
3656         Reviewed by Darin Adler.
3657
3658         Implement the new <!-- webkit-test-runner --> flag.
3659
3660         * WebKitTestRunner/TestController.cpp: