3014a68edbb701749eb1fb62c5b65052245760c3
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
2
3         webkitpy: Respect --dedicated-simulators flag
4         https://bugs.webkit.org/show_bug.cgi?id=194416
5         <rdar://problem/47894722>
6
7         Reviewed by Lucas Forschler.
8
9         * Scripts/webkitpy/port/device_port.py:
10         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
11         available devices can be safely ignored.
12
13 2019-02-07  Keith Rollin  <krollin@apple.com>
14
15         Remove extra copy of 100x100-red.tga
16         https://bugs.webkit.org/show_bug.cgi?id=194371
17         <rdar://problem/47873465>
18
19         Reviewed by Said Abou-Hallawa.
20
21         In order to help it pass its tests, Bug 194190 added a second copy of
22         the file 100x100-red.tga. However, it turns out that this additional
23         file wasn't actually needed, and that that sole previous copy was
24         sufficient. At the same time, this second copy -- which was copied to
25         the same location in the build output as the first copy -- now caused
26         XCBuild to complain because there were two production rules for the
27         same output file. Address this by removing the newly-added extra copy.
28
29         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
30         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
31
32 2019-02-07  Alex Christensen  <achristensen@webkit.org>
33
34         Deprecate WKBundlePageSetDefersLoading
35         https://bugs.webkit.org/show_bug.cgi?id=191394
36
37         Reviewed by Dean Jackson.
38
39         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
40         (WTR::TestRunner::setDefersLoading):
41
42 2019-02-07  Zalan Bujtas  <zalan@apple.com>
43
44         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
45         https://bugs.webkit.org/show_bug.cgi?id=194391
46
47         Reviewed by Antti Koivisto.
48
49         * LayoutReloaded/misc/LFC-passing-tests.txt:
50
51 2019-02-06  Keith Rollin  <krollin@apple.com>
52
53         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
54         https://bugs.webkit.org/show_bug.cgi?id=193975
55         <rdar://problem/47643306>
56
57         Reviewed by Tim Horton.
58
59         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
60         the Info.plist file into the bundle. This step is not necessary as the
61         implicit "bundle up all the build products into a framework" build
62         phase does this already. Having the Copy Bundle Resources phase do
63         this causes a conflict under XCBuild, which objects to two build
64         phases producing the same file (Info.plist). Address this by removing
65         Info.plist from the Copy Bundle Resources phase.
66
67         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
68
69 2019-02-06  Keith Rollin  <krollin@apple.com>
70
71         Really enable the automatic checking and regenerations of .xcfilelists during builds
72         https://bugs.webkit.org/show_bug.cgi?id=194357
73         <rdar://problem/47861231>
74
75         Reviewed by Chris Dumez.
76
77         Bug 194124 was supposed to enable the automatic checking and
78         regenerating of .xcfilelist files during the build. While related
79         changes were included in that patch, the change to actually enable the
80         operation somehow was omitted. This patch actually enables the
81         operation. The check-xcfilelist.sh scripts now check
82         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
83         from the checking.
84
85         * DumpRenderTree/Scripts/check-xcfilelists.sh:
86         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
87
88 2019-02-06  David Kilzer  <ddkilzer@apple.com>
89
90         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
91         <https://webkit.org/b/194286>
92         <rdar://problem/47815558>
93
94         Reviewed by Alexey Proskuryakov.
95
96         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
97         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
98         WKRetainPtr<> to avoid leaking the WKDataRef.
99
100 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
101
102         Unreviewed, fix a typo
103
104         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
105
106 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
107
108         [GTK][WPE] force libpsl build to use ICU in jhbuild
109         https://bugs.webkit.org/show_bug.cgi?id=194288
110
111         Reviewed by Carlos Garcia Campos.
112
113         * gtk/jhbuild.modules:
114         Require ICU for libpsl build in jhbuild, like done in WPE.
115
116 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
117
118         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
119         https://bugs.webkit.org/show_bug.cgi?id=194209
120
121         Reviewed by Carlos Garcia Campos.
122
123         Enhance TestCookieManager to ensure this doesn't happen again.
124
125         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
126         (testCookieManagerPersistentStorage):
127         (beforeAll):
128
129 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
130
131         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
132         https://bugs.webkit.org/show_bug.cgi?id=194324
133
134         Reviewed by Andy Estes.
135
136         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
137         part of the name is already implicit, since this is in testing code in TestOptions.
138
139         * WebKitTestRunner/TestController.cpp:
140         (WTR::TestController::generateContextConfiguration const):
141         (WTR::updateTestOptionsFromTestHeader):
142         * WebKitTestRunner/TestOptions.h:
143         (WTR::TestOptions::hasSameInitializationOptions const):
144
145 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
146
147         [ews-build] Allow * as platform for builders and workers
148         https://bugs.webkit.org/show_bug.cgi?id=188533
149
150         Reviewed by Lucas Forschler.
151
152         * BuildSlaveSupport/ews-build/loadConfig.py:
153         (checkWorkersAndBuildersForConsistency):
154
155 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
156
157         [ews-build] Add few bots to config.json
158         https://bugs.webkit.org/show_bug.cgi?id=194304
159
160         Reviewed by Lucas Forschler.
161
162         * BuildSlaveSupport/ews-build/config.json:
163
164 2019-02-05  Keith Rollin  <krollin@apple.com>
165
166         Enable the automatic checking and regenerations of .xcfilelists during builds
167         https://bugs.webkit.org/show_bug.cgi?id=194124
168         <rdar://problem/47721277>
169
170         Reviewed by Tim Horton.
171
172         Bug 193790 add a facility for checking -- during build time -- that
173         any needed .xcfilelist files are up-to-date and for updating them if
174         they are not. This facility was initially opt-in by setting
175         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
176         the process seemed robust. Its now time to enable this facility and
177         make it opt-out. If there is a need to disable this facility, set and
178         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
179         running `make` or `build-webkit`, or before running Xcode from the
180         command line.
181
182         Additionally, remove the step that generates a list of source files
183         going into the UnifiedSources build step. It's only necessarily to
184         specify Sources.txt and SourcesCocoa.txt as inputs.
185
186         * Scripts/generate-xcfilelists:
187
188 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
189
190         [GTK][WPE] force libpsl build to use ICU in jhbuild
191         https://bugs.webkit.org/show_bug.cgi?id=194288
192
193         Reviewed by Philippe Normand.
194
195         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
196         This can cause build failures if libidn is detected but libunistring is not available.
197
198         Make sure that ICU is used for runtime and builtin PSL data.
199
200         * gtk/jhbuild.modules:
201         * wpe/jhbuild.modules:
202
203 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
204
205         [ews-app] Modified timestamp should be updated on updating data
206         https://bugs.webkit.org/show_bug.cgi?id=194295
207
208         Reviewed by Lucas Forschler.
209
210         * BuildSlaveSupport/ews-app/ews/models/build.py:
211         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
212         * BuildSlaveSupport/ews-app/ews/models/step.py:
213
214 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
215
216         Unreviewed, rolling out r240742.
217
218         Causes crashes on iOS simulator.
219
220         Reverted changeset:
221
222         "[iOS] Keyups for non-modifier keys identified as "Dead" when
223         not focused in a content-editable element"
224         https://bugs.webkit.org/show_bug.cgi?id=192824
225         https://trac.webkit.org/changeset/240742
226
227 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
228
229         run-webkit-tests emits message "...running None" when running tests
230         https://bugs.webkit.org/show_bug.cgi?id=194133
231         <rdar://problem/47724738>
232
233         Reviewed by Lucas Forschler.
234
235         * Scripts/webkitpy/xcode/device_type.py:
236         (DeviceType.__str__): Use both version mapping tables and use just the variant
237         name if no version name is available.
238         * Scripts/webkitpy/xcode/device_type_unittest.py:
239         (DeviceTypeTest):
240         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
241         an associated named.
242
243 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
244
245         [WPE] require python3-setuptools for meson build in jhbuild
246         https://bugs.webkit.org/show_bug.cgi?id=194287
247
248         Reviewed by Philippe Normand.
249
250         python3-setuptools is needed to build meson in jhbuild.
251         It is already required by the GTK port.
252
253         * wpe/install-dependencies:
254
255 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
256
257         [ews-app] Add method to save BuilderMapping to database
258         https://bugs.webkit.org/show_bug.cgi?id=194264
259
260         Reviewed by Lucas Forschler.
261
262         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
263         (BuilderMapping.__str__):
264         (BuilderMapping):
265         (BuilderMapping.save_mapping):
266         (BuilderMapping.update_mapping):
267         (BuilderMapping.get_existing_mapping):
268         (BuilderMapping.is_valid_mapping):
269
270 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
271
272         [ews-app] Add timestamp fields for BuilderMappings
273         https://bugs.webkit.org/show_bug.cgi?id=194266
274
275         Reviewed by Lucas Forschler.
276
277         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
278         (BuilderMapping):
279
280 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
281
282         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
283         https://bugs.webkit.org/show_bug.cgi?id=174816
284
285         Reviewed by Michael Catanzaro.
286
287         Add tests for webkit_uri_for_display().
288
289         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
290         (testURIForDisplayUnaffected):
291         (testURIForDisplayAffected):
292         (beforeAll):
293         (afterAll):
294         * TestWebKitAPI/glib/CMakeLists.txt:
295
296 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
297
298         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
299         https://bugs.webkit.org/show_bug.cgi?id=194158
300         <rdar://problem/47737268>
301
302         Rubber-stamped by Aakash Jain.
303
304         * Scripts/webkitpy/port/device_port.py:
305         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
306
307 2019-02-04  Said Abou-Hallawa  <said@apple.com>
308
309         [CG] Enable setAdditionalSupportedImageTypes for WK1
310         https://bugs.webkit.org/show_bug.cgi?id=194190
311
312         Reviewed by Tim Horton.
313
314         Add a test similar to the one under WebKit Cocoa but make it create a
315         WebView instead of a WKWebView.
316
317         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
318         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
319         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
320         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
321         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
322         (TestWebKitAPI::runTest):
323         (TestWebKitAPI::TEST):
324
325 2019-02-04  Zalan Bujtas  <zalan@apple.com>
326
327         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
328         https://bugs.webkit.org/show_bug.cgi?id=194168
329
330         Reviewed by Simon Fraser.
331
332         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
333
334         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
335         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
336         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
337         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
338         (TEST):
339         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
340         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
341
342 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
343
344         REGRESSION (r237269): webkit-patch what-broke is broken 
345         https://bugs.webkit.org/show_bug.cgi?id=193025
346
347         Reviewed by Aakash Jain.
348
349         * Scripts/webkitpy/common/host.py:
350         (Host.buildbot):
351         (Host.bugzilla): Renamed to 'buildbot'.
352
353 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
354
355         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
356         https://bugs.webkit.org/show_bug.cgi?id=194207
357
358         Reviewed by Tim Horton.
359
360         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
361         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
362         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
363         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
364         start and delete forwards to remove the original attachment.
365
366         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
367         (TestWebKitAPI::TEST):
368
369 2019-02-04  Youenn Fablet  <youenn@apple.com>
370
371         Capture state should be managed consistently when doing process swapping
372         https://bugs.webkit.org/show_bug.cgi?id=194122
373         <rdar://problem/47609293>
374
375         Reviewed by Eric Carlson.
376
377         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
378         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
379         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
380         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
381         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
382         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
383         (WTR::TestRunner::isDoingMediaCapture const):
384         * WebKitTestRunner/InjectedBundle/TestRunner.h:
385         * WebKitTestRunner/TestController.cpp:
386         (WTR::TestController::isDoingMediaCapture const):
387         * WebKitTestRunner/TestController.h:
388         * WebKitTestRunner/TestInvocation.cpp:
389         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
390         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
391         (WTR::TestController::isDoingMediaCapture const):
392
393 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
394
395         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
396         https://bugs.webkit.org/show_bug.cgi?id=194142
397
398         Reviewed by Ross Kirsling.
399
400         There three 'separator' variables in TestController.cpp. Renamed
401         it 'pathSeparator', and unified them.
402
403         * WebKitTestRunner/TestController.cpp:
404         (WTR::TestController::generateContextConfiguration const):
405         (WTR::createTestURL):
406         (WTR::TestController::platformAdjustContext):
407
408 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
409
410         Make setNeedsLayout on the root more explicitly about triggering its side-effects
411         https://bugs.webkit.org/show_bug.cgi?id=194198
412
413         Reviewed by Antti Koivisto.
414
415         No need to set the banner heights on navigation now, since Page stores them.
416
417         * MiniBrowser/mac/WK2BrowserWindowController.m:
418         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
419
420 2019-02-03  John Wilander  <wilander@apple.com>
421
422         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
423         https://bugs.webkit.org/show_bug.cgi?id=194104
424         <rdar://problem/47649991>
425
426         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
427
428         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
429         (TestWebKitAPI::TEST):
430             Changed numeric types from unsigned short to uint32_t.
431
432 2019-02-02  David Kilzer  <ddkilzer@apple.com>
433
434         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
435         <https://webkit.org/b/194178>
436         <rdar://problem/47753473>
437
438         Reviewed by Alexey Proskuryakov.
439
440         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
441         (WTR::uninstallFakeHelvetica): Pass nullptr into
442         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
443
444 2019-02-02  Zalan Bujtas  <zalan@apple.com>
445
446         [LFC] Initialize ICB's style with fixed width/height.
447         https://bugs.webkit.org/show_bug.cgi?id=194188
448
449         Reviewed by Antti Koivisto.
450
451         * LayoutReloaded/misc/LFC-passing-tests.txt:
452
453 2019-02-02  Zalan Bujtas  <zalan@apple.com>
454
455         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
456         https://bugs.webkit.org/show_bug.cgi?id=194185
457
458         Reviewed by Antti Koivisto.
459
460         * LayoutReloaded/misc/LFC-passing-tests.txt:
461
462 2018-12-16  Darin Adler  <darin@apple.com>
463
464         Convert additional String::format clients to alternative approaches
465         https://bugs.webkit.org/show_bug.cgi?id=192746
466
467         Reviewed by Alexey Proskuryakov.
468
469         * WebKitTestRunner/TestController.cpp:
470         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
471         as an intermediate in code that ultimately constructs a WTF::String.
472         (WTR::userMediaOriginHash): Use makeString.
473         (WTR::TestController::didNavigateWithNavigationData): More of the same.
474         (WTR::TestController::didPerformClientRedirect): Ditto.
475         (WTR::TestController::didPerformServerRedirect): Ditto.
476         (WTR::TestController::didUpdateHistoryTitle): Ditto.
477
478 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
479
480         [ews-build] Add unit test to verify builder keys
481         https://bugs.webkit.org/show_bug.cgi?id=194152
482
483         Reviewed by Lucas Forschler.
484
485         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
486         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
487
488 2019-02-01  Zalan Bujtas  <zalan@apple.com>
489
490         [LFC] Expand tests coverage (12 new tests -> 787)
491
492         Unreviewed test gardening.
493
494         * LayoutReloaded/misc/LFC-passing-tests.txt:
495
496 2019-02-01  Zalan Bujtas  <zalan@apple.com>
497
498         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
499         https://bugs.webkit.org/show_bug.cgi?id=194163
500
501         Reviewed by Simon Fraser.
502
503         775
504
505         * LayoutReloaded/misc/LFC-passing-tests.txt:
506
507 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
508
509         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
510         https://bugs.webkit.org/show_bug.cgi?id=194140
511         <rdar://problem/47728098>
512
513         Reviewed by Tim Horton.
514
515         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
516         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
517         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
518
519         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
520         test to induce an IPC deadlock when presenting a modal alert during touch start.
521
522         * WebKitTestRunner/InjectedBundle/TestRunner.h:
523         * WebKitTestRunner/TestController.cpp:
524         (WTR::runJavaScriptAlert):
525
526         Add a client callback function for running JavaScript alerts.
527
528         (WTR::TestController::createOtherPage):
529         (WTR::TestController::generateContextConfiguration const):
530
531         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
532         the fix in this patch.
533
534         (WTR::TestController::createWebViewWithOptions):
535
536         Plumb TestOptions to generateContextConfiguration.
537
538         (WTR::TestController::resetPreferencesToConsistentValues):
539         (WTR::TestController::resetStateToConsistentValues):
540         (WTR::updateTestOptionsFromTestHeader):
541         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
542         (WTR::TestController::handleJavaScriptAlert):
543         * WebKitTestRunner/TestController.h:
544         * WebKitTestRunner/TestInvocation.cpp:
545         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
546         * WebKitTestRunner/TestOptions.h:
547         (WTR::TestOptions::hasSameInitializationOptions const):
548
549 2019-02-01  Chris Dumez  <cdumez@apple.com>
550
551         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
552         https://bugs.webkit.org/show_bug.cgi?id=193740
553         <rdar://problem/47527267>
554
555         Reviewed by Alex Christensen.
556
557         Add API test coverage.
558
559         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
560
561 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
562
563         [ews-app] Add display name field to BuilderMapping model
564         https://bugs.webkit.org/show_bug.cgi?id=194153
565
566         Reviewed by Lucas Forschler.
567
568         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
569         (BuilderMapping):
570
571 2019-02-01  Youenn Fablet  <youenn@apple.com>
572
573         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
574         https://bugs.webkit.org/show_bug.cgi?id=194155
575
576         Reviewed by Eric Carlson.
577
578         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
579         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
580         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
581
582 2019-02-01  Zalan Bujtas  <zalan@apple.com>
583
584         [LFC] Adjust replaced element's intrinsic ratio
585         https://bugs.webkit.org/show_bug.cgi?id=194154
586
587         Reviewed by Antti Koivisto.
588
589         761
590
591         * LayoutReloaded/misc/LFC-passing-tests.txt:
592
593 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
594
595         [WPE] Show test results in minibrowser
596         https://bugs.webkit.org/show_bug.cgi?id=194150
597
598         Reviewed by Žan Doberšek.
599
600         * Scripts/webkitpy/port/wpe.py:
601         (WPEPort.show_results_html_file):
602
603 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
604
605         [WPE] MiniBrowser: add ky bindings for back/forward navigation
606         https://bugs.webkit.org/show_bug.cgi?id=194151
607
608         Reviewed by Žan Doberšek.
609
610         ALT + <- go back
611         ALT + -> go forward
612
613         * MiniBrowser/wpe/main.cpp:
614         (main):
615
616 2019-02-01  Zalan Bujtas  <zalan@apple.com>
617
618         [LFC] Set intrinsic size on Layout::Replaced
619         https://bugs.webkit.org/show_bug.cgi?id=194139
620
621         Reviewed by Antti Koivisto.
622
623         744
624
625         * LayoutReloaded/misc/LFC-passing-tests.txt:
626
627 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
628
629         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
630         https://bugs.webkit.org/show_bug.cgi?id=194146
631
632         Reviewed by Xabier Rodriguez-Calvar.
633
634         It allows to open relative paths.
635
636         * MiniBrowser/wpe/main.cpp:
637         (main):
638
639 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
640
641         Update flakiness dashboard configuration after recent queue changes
642         https://bugs.webkit.org/show_bug.cgi?id=194127
643
644         Rubber-stamped by Aakash Jain.
645
646         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
647
648         * TestResultServer/static-dashboards/builders.jsonp:
649
650 2019-01-31  Youenn Fablet  <youenn@apple.com>
651
652         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
653         https://bugs.webkit.org/show_bug.cgi?id=194106
654         <rdar://problem/47676333>
655
656         Reviewed by Ryosuke Niwa.
657
658         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
659         (TestWebKitAPI::didFinishNavigation):
660         (TestWebKitAPI::TEST):
661         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
662
663 2019-01-31  Chris Dumez  <cdumez@apple.com>
664
665         Page zoom level is lost after a process swap or a crash
666         https://bugs.webkit.org/show_bug.cgi?id=194105
667         <rdar://problem/47610781>
668
669         Reviewed by Alex Christensen.
670
671         Add API test coverage.
672
673         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
674         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
675
676 2019-01-31  Alex Christensen  <achristensen@webkit.org>
677
678         Revert r238819 which is unneeded and caused a performance regression.
679         https://bugs.webkit.org/show_bug.cgi?id=192272
680         <rdar://problem/46664625>
681
682         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
683         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
684         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
685
686 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
687
688         Formalize WebKitAdditions mechanism of LoadOptimizer
689         https://bugs.webkit.org/show_bug.cgi?id=193886
690         <rdar://problem/47696809>
691
692         Reviewed by Brent Fulgham.
693
694         * MiniBrowser/MiniBrowser.entitlements:
695         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
696
697 2019-01-31  Zalan Bujtas  <zalan@apple.com>
698
699         [LFC] Margin before/after/start/end initial value is 0 and not auto.
700         https://bugs.webkit.org/show_bug.cgi?id=194090
701
702         Reviewed by Antti Koivisto.
703
704         * LayoutReloaded/misc/LFC-passing-tests.txt:
705
706 2019-01-31  Zalan Bujtas  <zalan@apple.com>
707
708         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
709         https://bugs.webkit.org/show_bug.cgi?id=194074
710
711         Reviewed by Antti Koivisto.
712
713         * LayoutReloaded/misc/LFC-passing-tests.txt:
714
715 2019-01-31  Zalan Bujtas  <zalan@apple.com>
716
717         [LFC][BFC] Add support for block level replaced box.
718         https://bugs.webkit.org/show_bug.cgi?id=194071
719
720         Reviewed by Antti Koivisto.
721
722         * LayoutReloaded/misc/LFC-passing-tests.txt:
723
724 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
725
726         Fix WebKitTestRunner's testPath with Windows full paths
727         https://bugs.webkit.org/show_bug.cgi?id=194012
728
729         Reviewed by Alex Christensen.
730
731         updateTestOptionsFromTestHeader failed to open test files because
732         testPath returned wrong file paths. It returned a path "/C:/..."
733         if a URL "file:///C:/..." was given.
734
735         * WebKitTestRunner/TestController.cpp:
736         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
737
738 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
739
740         [WPE] Bump font related dependencies to match the GTK+ port
741         https://bugs.webkit.org/show_bug.cgi?id=194017
742
743         Reviewed by Žan Doberšek.
744
745         * wpe/jhbuild.modules:
746         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
747         * wpe/patches/icudata-stdlibs.patch: Added.
748
749 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
750
751         Enable swipe tests on iOS
752         https://bugs.webkit.org/show_bug.cgi?id=194076
753
754         Reviewed by Geoffrey Garen.
755
756         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
757         it causes a debug assertion failure in runUIScript.
758
759         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
760         (WTR::UIScriptController::beginBackSwipe):
761         (WTR::UIScriptController::completeBackSwipe):
762
763 2019-01-30  Keith Rollin  <krollin@apple.com>
764
765         Use correct printf format specifier
766         https://bugs.webkit.org/show_bug.cgi?id=194062
767         <rdar://problem/47686167>
768
769         Reviewed by Alexey Proskuryakov.
770
771         LayoutTestSpellChecker.mm is trying to format a variable of type
772         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
773         actually an unsigned long long. Fix this by formatting with %llu.
774
775         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
776         (-[LayoutTestTextCheckingResult description]):
777
778 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
779
780         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
781         https://bugs.webkit.org/show_bug.cgi?id=193979
782
783         Reviewed by Wenson Hsieh.
784
785         Fix the test for iOS. Make the test work with iOS UA string.
786
787         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
788
789 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
790
791         Replace High Sierra LLINT CLoop bot due to hardware failure
792         https://bugs.webkit.org/show_bug.cgi?id=194066
793
794         Reviewed by Aakash Jain.
795
796         * BuildSlaveSupport/build.webkit.org-config/config.json:
797
798 2019-01-30  Keith Rollin  <krollin@apple.com>
799
800         [NSDragItem init] is unavailable
801         https://bugs.webkit.org/show_bug.cgi?id=194059
802         <rdar://problem/47685715>
803
804         Reviewed by Wenson Hsieh.
805
806         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
807         DumpRenderTree and TestWebKitAPI, which both try to create an
808         NSDragItem in a manner that invokes this method. Address this by using
809         -initWithPasteboardWriter instead.
810
811         Note that the parameter passed to initWithPasteboardWriter is likely
812         incorrect. In both cases, the object passed does not conform to
813         NSPasteboardWriting. However, with this fix, we're no worse off than
814         before, and can now perform builds with newer compilers and SDKs until
815         a real fix can be crafted. That work is tracked in
816         https://bugs.webkit.org/show_bug.cgi?id=194060
817
818         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
819         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
820         * TestWebKitAPI/mac/TestDraggingInfo.mm:
821         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
822
823 2019-01-30  Daniel Bates  <dabates@apple.com>
824
825         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
826         https://bugs.webkit.org/show_bug.cgi?id=192824
827         <rdar://problem/47100332>
828
829         Reviewed by Wenson Hsieh.
830
831         Fix a bug where the wrong usage code was used for F13 thru F24.
832
833         * WebKitTestRunner/ios/HIDEventGenerator.mm:
834         (keyCodeForDOMFunctionKey):
835
836 2019-01-30  Chris Dumez  <cdumez@apple.com>
837
838         Regression(PSON) Load hang can occur on history navigation
839         https://bugs.webkit.org/show_bug.cgi?id=194030
840         <rdar://problem/47656939>
841
842         Reviewed by Antti Koivisto.
843
844         Add API test coverage.
845
846         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
847
848 2019-01-30  Zalan Bujtas  <zalan@apple.com>
849
850         [LFC] Expand tests coverage.
851
852         Unreviewed test gardening.
853
854         * LayoutReloaded/misc/LFC-passing-tests.txt:
855
856 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
857
858         [Flatpak] Add openjpeg support
859         https://bugs.webkit.org/show_bug.cgi?id=194019
860
861         Reviewed by Michael Catanzaro.
862
863         * flatpak/org.webkit.CommonModules.yaml:
864
865 2019-01-30  Commit Queue  <commit-queue@webkit.org>
866
867         Unreviewed, rolling out r240708.
868         https://bugs.webkit.org/show_bug.cgi?id=194022
869
870         It broke WPE build (Requested by KaL on #webkit).
871
872         Reverted changeset:
873
874         "[WPE] Bump font related dependencies to match the GTK+ port"
875         https://bugs.webkit.org/show_bug.cgi?id=194017
876         https://trac.webkit.org/changeset/240708
877
878 2019-01-30  Zalan Bujtas  <zalan@apple.com>
879
880         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
881         https://bugs.webkit.org/show_bug.cgi?id=194001
882
883         Reviewed by Antti Koivisto.
884
885         * LayoutReloaded/misc/LFC-passing-tests.txt:
886
887 2019-01-30  Zalan Bujtas  <zalan@apple.com>
888
889         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
890         https://bugs.webkit.org/show_bug.cgi?id=194020
891
892         Reviewed by Antti Koivisto.
893
894         * LayoutReloaded/misc/LFC-passing-tests.txt:
895
896 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
897
898         AX: Support color well on iOS
899         https://bugs.webkit.org/show_bug.cgi?id=194010
900
901         Reviewed by Joanmarie Diggs.
902
903         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
904         (WTR::AccessibilityUIElement::stringAttributeValue):
905
906 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
907
908         [WPE] Bump font related dependencies to match the GTK+ port
909         https://bugs.webkit.org/show_bug.cgi?id=194017
910
911         Reviewed by Žan Doberšek.
912
913         * wpe/jhbuild.modules:
914         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
915         * wpe/patches/icudata-stdlibs.patch: Added.
916
917 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
918
919         [Mac] Update window scale API usage
920         https://bugs.webkit.org/show_bug.cgi?id=193991
921         rdar://problem/47614795
922
923         Reviewed by Tim Horton.
924
925         * DumpRenderTree/mac/DumpRenderTree.mm:
926         (changeWindowScaleIfNeeded):
927         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
928         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
929         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
930
931 2019-01-29  Chris Dumez  <cdumez@apple.com>
932
933         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
934         https://bugs.webkit.org/show_bug.cgi?id=193977
935         <rdar://problem/47643716>
936
937         Reviewed by Geoff Garen.
938
939         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
940         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
941         to the previous provisional committing *before* we make the last load. 
942
943         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
944
945 2019-01-29  Youenn Fablet  <youenn@apple.com>
946
947         Adopt new SPI to evaluate server certificate trust
948         https://bugs.webkit.org/show_bug.cgi?id=193355
949
950         Reviewed by Alex Christensen.
951
952         Add infrastructure to handle HTTPS server trust evaluation testing.
953
954         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
955         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
956         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
957         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
958         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
959         * WebKitTestRunner/InjectedBundle/TestRunner.h:
960         * WebKitTestRunner/TestController.cpp:
961         (WTR::TestController::resetPreferencesToConsistentValues):
962         (WTR::TestController::didReceiveAuthenticationChallenge):
963         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
964         * WebKitTestRunner/TestController.h:
965         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
966         * WebKitTestRunner/TestInvocation.cpp:
967         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
968         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
969         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
970
971 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
972
973         [ews-build] Add build step to print bot Configuration
974         https://bugs.webkit.org/show_bug.cgi?id=193887
975
976         Reviewed by Lucas Forschler.
977
978         * BuildSlaveSupport/ews-build/steps.py:
979         (PrintConfiguration): Build step to print configuration.
980         * BuildSlaveSupport/ews-build/factories.py:
981
982 2019-01-29  Chris Dumez  <cdumez@apple.com>
983
984         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
985         https://bugs.webkit.org/show_bug.cgi?id=193967
986         <rdar://problem/47635348>
987
988         Reviewed by Alex Christensen.
989
990         Add API test coverage.
991
992         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
993         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
994
995 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
996
997         [ews-app] Handle incoming results data
998         https://bugs.webkit.org/show_bug.cgi?id=193973
999
1000         Reviewed by Lucas Forschler.
1001
1002         * BuildSlaveSupport/ews-app/ews/views/results.py:
1003
1004 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1005
1006         [ews-app] Make the results url generic
1007         https://bugs.webkit.org/show_bug.cgi?id=193928
1008
1009         Reviewed by Lucas Forschler.
1010
1011         * BuildSlaveSupport/ews-app/ews/urls.py:
1012
1013 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1014
1015         [ews-build] Configure buildbot to send events to ews-app
1016         https://bugs.webkit.org/show_bug.cgi?id=193968
1017
1018         Reviewed by Lucas Forschler.
1019
1020         * BuildSlaveSupport/ews-build/events.py: Added.
1021         * BuildSlaveSupport/ews-build/master.cfg:
1022
1023 2019-01-29  Keith Rollin  <krollin@apple.com>
1024
1025         Add .xcfilelists to Run Script build phases
1026         https://bugs.webkit.org/show_bug.cgi?id=193792
1027         <rdar://problem/47201785>
1028
1029         Reviewed by Alex Christensen.
1030
1031         As part of supporting XCBuild, update the necessary Run Script build
1032         phases in their Xcode projects to refer to their associated
1033         .xcfilelist files.
1034
1035         Note that the addition of these files bumps the Xcode project version
1036         number to something that's Xcode 10 compatible. This change means that
1037         older versions of the Xcode IDE can't read these projects. Nor can it
1038         fully load workspaces that refer to these projects (the updated
1039         projects are shown as non-expandable placeholders). `xcodebuild` can
1040         still build these projects; it's just that the IDE can't open them.
1041
1042         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1043         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1044
1045 2019-01-29  John Wilander  <wilander@apple.com>
1046
1047         Add data abstraction and validation for Ad Click Attribution
1048         https://bugs.webkit.org/show_bug.cgi?id=193916
1049         <rdar://problem/47603481>
1050
1051         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
1052
1053         Ad click attribution has two steps. First, the storage of an ad
1054         campaign ID for a click that takes the user to a destination
1055         site. Second, a conversion on the destination site that can be
1056         attributed to the ad click.
1057
1058         This patch adds a class that represents a request for ad click
1059         attribution. Validation makes sure that the bits of entropy
1060         reported through this mechanism is limited.
1061
1062         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1063         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
1064         (TestWebKitAPI::TEST):
1065
1066 2019-01-29  Chris Dumez  <cdumez@apple.com>
1067
1068         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
1069         https://bugs.webkit.org/show_bug.cgi?id=193932
1070         <rdar://problem/47598947>
1071
1072         Reviewed by Brady Eidson.
1073
1074         Add API test coverage.
1075
1076         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1077
1078 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1079
1080         Adding new passing LFC tests.
1081
1082         Unreviewed test gardening.
1083
1084         * LayoutReloaded/misc/LFC-passing-tests.txt:
1085
1086 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1087
1088         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
1089         https://bugs.webkit.org/show_bug.cgi?id=193964
1090
1091         Reviewed by Antti Koivisto.
1092
1093         * LayoutReloaded/misc/LFC-passing-tests.txt:
1094
1095 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1096
1097         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
1098         https://bugs.webkit.org/show_bug.cgi?id=193954
1099
1100         Reviewed by Antti Koivisto.
1101
1102         * LayoutReloaded/misc/LFC-passing-tests.txt:
1103
1104 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1105
1106         WebDriver: add support for running subtests
1107         https://bugs.webkit.org/show_bug.cgi?id=193904
1108
1109         Reviewed by Michael Catanzaro.
1110
1111         pytest already supports it by passing test.py::subtest, so we can do the same.
1112
1113         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
1114         (get_item_name): Made this global.
1115         (CollectRecorder.__init__): Receive the parameter to ignore.
1116         (CollectRecorder.pytest_collectreport): Collect also the subtests.
1117         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
1118         (collect): Add parameter to ignore.
1119         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
1120         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
1121         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
1122         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
1123         (WebDriverTestRunnerSelenium.run): Ditto.
1124         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
1125         (WebDriverTestRunnerW3C.collect_tests): Ditto.
1126         (WebDriverTestRunnerW3C.run): Ditto.
1127
1128 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
1129
1130         User agent string override for navigator.userAgent should be site specific quirks
1131         https://bugs.webkit.org/show_bug.cgi?id=193950
1132
1133         Reviewed by Brent Fulgham.
1134
1135         Updated per the _WKWebsitePolicies rename.
1136
1137         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1138         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1139
1140 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
1141
1142         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
1143         https://bugs.webkit.org/show_bug.cgi?id=193941
1144
1145         Reviewed by Alex Christensen.
1146
1147         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
1148         * TestWebKitAPI/Tests/WTF/Condition.cpp:
1149         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1150         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1151         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1152         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
1153         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
1154         * TestWebKitAPI/Tests/WTF/Time.cpp:
1155         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
1156         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
1157         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1158         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1159
1160 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
1161
1162         Unreviewed, reorder my emails to fix autocomplete in bugzilla
1163
1164         * Scripts/webkitpy/common/config/contributors.json:
1165
1166 2019-01-28  Andy Estes  <aestes@apple.com>
1167
1168         [watchOS] Enable Parental Controls content filtering
1169         https://bugs.webkit.org/show_bug.cgi?id=193939
1170         <rdar://problem/46641912>
1171
1172         Reviewed by Ryosuke Niwa.
1173
1174         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1175
1176 2019-01-28  David Kilzer  <ddkilzer@apple.com>
1177
1178         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
1179         <https://webkit.org/b/193884>
1180
1181         Reviewed by Jiewen Tan.
1182
1183         * Scripts/webkitpy/style/checkers/cpp.py:
1184         (check_language): Add LocalAuthentication to
1185         `frameworks_with_soft_links`.
1186
1187 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
1188
1189         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
1190         https://bugs.webkit.org/show_bug.cgi?id=193891
1191
1192         Reviewed by Ross Kirsling.
1193
1194         There were three problems in window sizes of WebView and the host window.
1195         1. The sizes of pixel image output were incorrect.
1196         2. The host window is going to appear after window.resize was invoked.
1197         3. window.resize resized only the host window, not WebView.
1198
1199         This change solves them with a following approach.
1200         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
1201         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
1202            as well as DumpRenderTree in order to match the client area and the window area.
1203         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
1204         d. PlatformWebView::setWindowFrame changes both window sizes.
1205         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
1206
1207         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1208         (WTR::PlatformWebView::PlatformWebView): Create the host window
1209         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
1210         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
1211         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
1212
1213 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1214
1215         [ews-app] Add method to save Step data to database
1216         https://bugs.webkit.org/show_bug.cgi?id=193890
1217
1218         Reviewed by Lucas Forschler.
1219
1220         * BuildSlaveSupport/ews-app/ews/models/step.py:
1221         (Step.save_step): Method to save step data.
1222         (Step.update_step): Method to update step data.
1223         (Step.get_existing_step): Method to fetch existing step from database.
1224         (Step.is_valid_result): Method to validate valid step result.
1225
1226 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1227
1228         [ews-app] Add method to save Build data to database
1229         https://bugs.webkit.org/show_bug.cgi?id=193735
1230
1231         Reviewed by Lucas Forschler.
1232
1233         * BuildSlaveSupport/ews-app/ews/models/build.py:
1234         (Build.save_build): Method to save build information to database.
1235         (Build.get_existing_build): Method to fetch existing build from database.
1236         (Build.is_valid_result): Method to validate build result.
1237         * BuildSlaveSupport/ews-app/ews/common/util.py:
1238         (is_valid_int_id): Method to validate valid id.
1239
1240 2019-01-28  Chris Dumez  <cdumez@apple.com>
1241
1242         Regression(PSON) Crash under WebPageProxy::didStartProgress()
1243         https://bugs.webkit.org/show_bug.cgi?id=193915
1244         <rdar://problem/47560907>
1245
1246         Reviewed by Alex Christensen.
1247
1248         Add API test coverage.
1249
1250         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1251
1252 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1253
1254         [ews-app] Rename id variables
1255         https://bugs.webkit.org/show_bug.cgi?id=193883
1256
1257         Reviewed by Lucas Forschler.
1258
1259         * BuildSlaveSupport/ews-app/ews/models/build.py:
1260         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1261         * BuildSlaveSupport/ews-app/ews/models/step.py:
1262         * BuildSlaveSupport/ews-app/ews/urls.py:
1263         * BuildSlaveSupport/ews-app/ews/views/patch.py:
1264         * BuildSlaveSupport/ews-app/ews/views/results.py:
1265         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1266
1267 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1268
1269         [ews-app] Allow certain fields to be empty
1270         https://bugs.webkit.org/show_bug.cgi?id=193892
1271
1272         Reviewed by Lucas Forschler.
1273
1274         * BuildSlaveSupport/ews-app/ews/models/build.py:
1275         * BuildSlaveSupport/ews-app/ews/models/step.py:
1276
1277 2019-01-28  Rob Buis  <rbuis@igalia.com>
1278
1279         Update MIME type parser
1280         https://bugs.webkit.org/show_bug.cgi?id=180526
1281
1282         Reviewed by Frédéric Wang.
1283
1284         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1285         (TestWebKitAPI::TEST):
1286
1287 2019-01-28  Zalan Bujtas  <zalan@apple.com>
1288
1289         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
1290         https://bugs.webkit.org/show_bug.cgi?id=193896
1291
1292         Reviewed by Antti Koivisto.
1293
1294         * LayoutReloaded/misc/LFC-passing-tests.txt:
1295
1296 2018-12-15  Darin Adler  <darin@apple.com>
1297
1298         Replace many uses of String::format with more type-safe alternatives
1299         https://bugs.webkit.org/show_bug.cgi?id=192742
1300
1301         Reviewed by Mark Lam.
1302
1303         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1304         (WTR::cacheTestRunnerCallback): Use makeString.
1305         * WebKitTestRunner/TestController.cpp:
1306         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
1307         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
1308
1309 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
1310
1311         Use a load optimizer for some sites
1312         https://bugs.webkit.org/show_bug.cgi?id=193881
1313         <rdar://problem/46325455>
1314
1315         Reviewed by Brent Fulgham.
1316
1317         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1318         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
1319
1320 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
1321
1322         AX: Introduce a static accessibility tree
1323         https://bugs.webkit.org/show_bug.cgi?id=193348
1324         <rdar://problem/47203295>
1325
1326         Reviewed by Ryosuke Niwa.
1327
1328         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1329
1330 2019-01-26  Zalan Bujtas  <zalan@apple.com>
1331
1332         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
1333         https://bugs.webkit.org/show_bug.cgi?id=193867
1334
1335         Reviewed by Antti Koivisto.
1336
1337         * LayoutReloaded/misc/LFC-passing-tests.txt:
1338
1339 2019-01-26  Zalan Bujtas  <zalan@apple.com>
1340
1341         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
1342         https://bugs.webkit.org/show_bug.cgi?id=193865
1343
1344         Reviewed by Antti Koivisto.
1345
1346         * LayoutReloaded/misc/LFC-passing-tests.txt:
1347
1348 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1349
1350         Need a mechanism to override navigator.userAgent
1351         https://bugs.webkit.org/show_bug.cgi?id=193762
1352         <rdar://problem/47504939>
1353
1354         Reviewed by Brent Fulgham.
1355
1356         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
1357
1358         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1359         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1360         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
1361
1362 2019-01-25  Dean Jackson  <dino@apple.com>
1363
1364         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
1365         https://bugs.webkit.org/show_bug.cgi?id=193831
1366         <rdar://problem/47399263>
1367
1368         Reviewed by Chris Dumez.
1369
1370         Two new tests that exercise cross-origin and same-origin System
1371         Previews.
1372
1373         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1374
1375 2019-01-25  Keith Rollin  <krollin@apple.com>
1376
1377         Update Xcode projects with "Check .xcfilelists" build phase
1378         https://bugs.webkit.org/show_bug.cgi?id=193790
1379         <rdar://problem/47201374>
1380
1381         Reviewed by Alex Christensen.
1382
1383         Support for XCBuild includes specifying inputs and outputs to various
1384         Run Script build phases. These inputs and outputs are specified as
1385         .xcfilelist files. Once created, these .xcfilelist files need to be
1386         kept up-to-date. In order to check that they are up-to-date or not,
1387         add an Xcode build step that invokes an external script that performs
1388         the checking. If the .xcfilelists are found to be out-of-date, update
1389         them, halt the build, and instruct the developer to restart the build
1390         with up-to-date files.
1391
1392         At this time, the checking and regenerating is performed only if the
1393         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
1394         who want to use this facility can set this variable and test out the
1395         checking/regenerating. Once it seems like there are no egregious
1396         issues that upset a developer's workflow, we'll unconditionally enable
1397         this facility.
1398
1399         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1400         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
1401         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
1402         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1403
1404 2019-01-25  Keith Rollin  <krollin@apple.com>
1405
1406         Update Xcode projects with "Apply Configuration to XCFileLists" build target
1407         https://bugs.webkit.org/show_bug.cgi?id=193781
1408         <rdar://problem/47201153>
1409
1410         Reviewed by Alex Christensen.
1411
1412         Part of generating the .xcfilelists used as part of adopting XCBuild
1413         includes running `make DerivedSources.make` from a standalone script.
1414         It’s important for this invocation to have the same environment as
1415         when the actual build invokes `make DerivedSources.make`. If the
1416         environments are different, then the two invocations will provide
1417         different results. In order to get the same environment in the
1418         standalone script, have the script launch xcodebuild targeting the
1419         "Apply Configuration to XCFileLists" build target, which will then
1420         re-invoke our standalone script. The script is now running again, this
1421         time in an environment with all workspace, project, target, xcconfig
1422         and other environment variables established.
1423
1424         The "Apply Configuration to XCFileLists" build target accomplishes
1425         this task via a small embedded shell script that consists only of:
1426
1427             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
1428
1429         The process that invokes "Apply Configuration to XCFileLists" first
1430         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
1431         evaluated and exports it into the shell environment. When xcodebuild
1432         is invoked, it inherits the value of this variable and can `eval` the
1433         contents of that variable. Our external standalone script can then set
1434         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
1435         of command-line parameters needed to restart itself in the appropriate
1436         state.
1437
1438         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1439         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1440
1441 2019-01-25  Alex Christensen  <achristensen@webkit.org>
1442
1443         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
1444         https://bugs.webkit.org/show_bug.cgi?id=193802
1445         <rdar://problem/46010580>
1446
1447         Reviewed by Andy Estes.
1448
1449         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1450         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
1451         (TEST):
1452
1453 2019-01-25  Daniel Bates  <dabates@apple.com>
1454
1455         [iOS] uiController.keyDown() does not translate Control modified key
1456         https://bugs.webkit.org/show_bug.cgi?id=192898
1457
1458         Reviewed by Wenson Hsieh.
1459
1460         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
1461         key translation, as applicable. Among other cases, key translation occurs when performing
1462         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
1463         also makes the behavior of uiController.keyDown() more closely match the behavior of a
1464         human pressing down and releasing key(s) using a hardware keyboard.
1465
1466         * WebKitTestRunner/ios/HIDEventGenerator.h:
1467         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1468         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
1469
1470         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
1471         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
1472         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1473         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1474         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
1475         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1476         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
1477         (-[HIDEventGenerator longPress:completionBlock:]):
1478         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
1479         Update code for above renaming.
1480
1481         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
1482         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
1483
1484         (-[HIDEventGenerator keyDown:]): Added.
1485         (-[HIDEventGenerator keyUp:]): Added.
1486         (-[HIDEventGenerator keyPress:completionBlock:]):
1487         (-[HIDEventGenerator eventDispatchThreadEntry:]):
1488         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
1489         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1490         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
1491         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
1492         (WTR::parseModifier): Deleted.
1493
1494 2019-01-25  Keith Rollin  <krollin@apple.com>
1495
1496         Complete the implementation of generate-xcfilelists
1497         https://bugs.webkit.org/show_bug.cgi?id=193782
1498
1499         Reviewed by Alex Christensen.
1500
1501         A preliminary version of generate-xcfilelists was added in r238008.
1502         This patch updates that script in order to:
1503
1504         - Support checking of .xcfilelists
1505         - Perform better execution of `make DerivedSources.make` by
1506           relaunching generate-xcfilelists under xcodebuild
1507         - Support incremental generation and checking of .xcfilelists
1508         - Support supplementary .xcfilelists files from WebKitAdditions
1509         - Support being wrapped by parallel version of generate-xcfilelists in
1510           Internal that adds support for (re)generating WebKit projects in
1511           that repo.
1512         - Support builds that have been performed in WebKitBuild as well as
1513           ~/Library/Developer/code/DerivedData
1514         - Increase robustness and debugging facilities.
1515
1516         * Scripts/generate-xcfilelists:
1517
1518 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
1519
1520         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1521         https://bugs.webkit.org/show_bug.cgi?id=193297
1522         <rdar://problem/47158841>
1523
1524         Unreviewed test case fix.
1525
1526         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
1527         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
1528
1529         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1530         (TEST):
1531
1532 2019-01-25  Keith Rollin  <krollin@apple.com>
1533
1534         Update existing .xcfilelists
1535         https://bugs.webkit.org/show_bug.cgi?id=193791
1536         <rdar://problem/47201706>
1537
1538         Reviewed by Alex Christensen.
1539
1540         Many .xcfilelist files were added in r238824 in order to support
1541         XCBuild. Update these with recent changes to the set of build files
1542         and with the current generate-xcfilelist script.
1543
1544         * DumpRenderTree/DerivedSources-input.xcfilelist:
1545         * DumpRenderTree/DerivedSources-output.xcfilelist:
1546         * WebKitTestRunner/DerivedSources-input.xcfilelist:
1547         * WebKitTestRunner/DerivedSources-output.xcfilelist:
1548
1549 2019-01-25  Keith Rollin  <krollin@apple.com>
1550
1551         Fix missing dependencies in extract-dependencies-from-makefile
1552         https://bugs.webkit.org/show_bug.cgi?id=193783
1553         <rdar://problem/47201571>
1554
1555         Reviewed by Alex Christensen.
1556
1557         The extract-dependencies-from-makefile script generates .xcfilelists
1558         for XCBuild by invoking a makefile in --debug mode, parsing the
1559         dependency information in the output, and extracting information
1560         regarding targets and dependents. However, the way `make` emits this
1561         dependency information is not rigorous, and so we need to determine
1562         what lines to look for and parse by trial and error. This approach
1563         didn't coriginally atch all the information we needed to collect, so
1564         update the script to look for the additional lines we now know to look
1565         for.
1566
1567         * Scripts/extract-dependencies-from-makefile:
1568         (Parser):
1569         (Parser.addTarget):
1570         (Parser.addPrereq):
1571         (Parser.doParse):
1572
1573 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
1574
1575         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1576         https://bugs.webkit.org/show_bug.cgi?id=193297
1577         <rdar://problem/47158841>
1578
1579         Reviewed by Alex Christensen.
1580
1581         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
1582             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
1583         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1584         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
1585         activating the message used to trigger the callback when it is set.
1586
1587 2019-01-25  Alex Christensen  <achristensen@webkit.org>
1588
1589         WKWebView.goBack should reload if there is a safe browsing warning
1590         https://bugs.webkit.org/show_bug.cgi?id=193805
1591         <rdar://problem/46908216>
1592
1593         Reviewed by Geoff Garen.
1594
1595         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1596         (+[Simple3LookupContext sharedLookupContext]):
1597         (-[Simple3LookupContext lookUpURL:completionHandler:]):
1598         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
1599         (TEST):
1600
1601 2019-01-25  Chris Dumez  <cdumez@apple.com>
1602
1603         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
1604         https://bugs.webkit.org/show_bug.cgi?id=193788
1605         <rdar://problem/47531231>
1606
1607         Reviewed by Alex Christensen.
1608
1609         Add API test coverage.
1610
1611         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1612         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
1613
1614 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
1615
1616         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
1617         https://bugs.webkit.org/show_bug.cgi?id=193771
1618
1619         Unreviewed infrastructure fix.
1620
1621         * Scripts/webkitpy/port/darwin.py:
1622         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
1623
1624 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
1625
1626         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
1627
1628 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
1629
1630         Add contributors.json entries for Ling Ho and for a new bot watchers group.
1631
1632         * Scripts/webkitpy/common/config/contributors.json:
1633
1634 2019-01-25  Chris Dumez  <cdumez@apple.com>
1635
1636         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
1637         https://bugs.webkit.org/show_bug.cgi?id=193779
1638         <rdar://problem/46170903>
1639
1640         Reviewed by Antti Koivisto.
1641
1642         Add API test that quickly navigates forward to a previous process without waiting for it to
1643         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
1644         the process' previous page when reconnecting the it for the forward navigation.
1645
1646         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1647
1648 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1649
1650         Need a way for JavaScript (or bundle) code to participate in undo
1651         https://bugs.webkit.org/show_bug.cgi?id=190009
1652         <rdar://problem/44807048>
1653
1654         Reviewed by Ryosuke Niwa.
1655
1656         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
1657         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
1658
1659         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1660         (WTR::UIScriptController::lastUndoLabel const):
1661         (WTR::UIScriptController::firstRedoLabel const):
1662         (WTR::UIScriptController::platformUndoManager const):
1663         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1664         (WTR::UIScriptController::lastUndoLabel const):
1665         (WTR::UIScriptController::firstRedoLabel const):
1666         (WTR::UIScriptController::platformUndoManager const):
1667         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1668         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1669         (WTR::UIScriptController::lastUndoLabel const):
1670         (WTR::UIScriptController::firstRedoLabel const):
1671         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1672         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1673         (WTR::UIScriptController::lastUndoLabel const):
1674         (WTR::UIScriptController::firstRedoLabel const):
1675         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1676         (WTR::UIScriptController::platformUndoManager const):
1677         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1678         (WTR::UIScriptController::platformUndoManager const):
1679
1680 2019-01-25  Zalan Bujtas  <zalan@apple.com>
1681
1682         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
1683         https://bugs.webkit.org/show_bug.cgi?id=193824
1684
1685         Reviewed by Antti Koivisto.
1686
1687         * LayoutReloaded/misc/LFC-passing-tests.txt:
1688
1689 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
1690
1691         Update macOS JSC bot configurations
1692         https://bugs.webkit.org/show_bug.cgi?id=193739
1693
1694         Reviewed by Alexey Proskuryakov.
1695
1696         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
1697         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1698         (BubbleQueueServer): Move JSC EWS to Mojave section.
1699         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1700         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
1701         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
1702
1703 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
1704
1705         [Win][WebKitTestRunner] Implement EventSenderProxy
1706         https://bugs.webkit.org/show_bug.cgi?id=193755
1707
1708         Reviewed by Don Olmstead.
1709
1710         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
1711         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
1712         (WTR::EventSenderProxy::dispatchMessage):
1713         (WTR::EventSenderProxy::EventSenderProxy):
1714         (WTR::EventSenderProxy::mouseDown):
1715         (WTR::EventSenderProxy::mouseUp):
1716         (WTR::EventSenderProxy::mouseMoveTo):
1717         (WTR::EventSenderProxy::mouseScrollBy):
1718         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
1719
1720 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
1721
1722         Unreviewed fix for API test failure after r240437.
1723
1724         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
1725
1726         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
1727
1728 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
1729
1730         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
1731         https://bugs.webkit.org/show_bug.cgi?id=193787
1732         <rdar://problem/47497634>
1733
1734         Reviewed by Alexey Proskuryakov.
1735
1736         * Scripts/webkitdirs.pm:
1737         (iosSimulatorApplicationsPath): Pick from available runtime directories.
1738
1739 2019-01-24  Truitt Savell  <tsavell@apple.com>
1740
1741         Unreviewed, rolling out r240446.
1742
1743         Casued 5 API failures
1744
1745         Reverted changeset:
1746
1747         "Activate the WebResourceLoadStatisticsStore in the
1748         NetworkProcess and deactivate it in the UIProcess."
1749         https://bugs.webkit.org/show_bug.cgi?id=193297
1750         https://trac.webkit.org/changeset/240446
1751
1752 2019-01-24  Zalan Bujtas  <zalan@apple.com>
1753
1754         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
1755         https://bugs.webkit.org/show_bug.cgi?id=193741
1756         <rdar://problem/47135030>
1757
1758         Reviewed by Antti Koivisto and Simon Fraser.
1759
1760         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1761         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
1762         (TestWebKitAPI::TEST):
1763
1764 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
1765
1766         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1767         https://bugs.webkit.org/show_bug.cgi?id=193297
1768         <rdar://problem/47158841>
1769
1770         Reviewed by Alex Christensen.
1771
1772         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1773         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
1774         activating the message used to trigger the callback when it is set.
1775
1776 2019-01-24  John Wilander  <wilander@apple.com>
1777
1778         Add Ad Click Attribution as an internal/experimental feature
1779         https://bugs.webkit.org/show_bug.cgi?id=193685
1780         <rdar://problem/47450399>
1781
1782         Reviewed by Brent Fulgham.
1783
1784         Added test option adClickAttributionEnabled.
1785
1786         * DumpRenderTree/TestOptions.cpp:
1787         (TestOptions::TestOptions):
1788         * DumpRenderTree/TestOptions.h:
1789         * DumpRenderTree/mac/DumpRenderTree.mm:
1790         (setWebPreferencesForTestOptions):
1791
1792 2019-01-24  Antti Koivisto  <antti@apple.com>
1793
1794         [PSON] Flash on back navigation on Mac
1795         https://bugs.webkit.org/show_bug.cgi?id=193716
1796         <rdar://problem/47148458>
1797
1798         Reviewed by Chris Dumez.
1799
1800         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1801
1802         Closing of the previous page is delayed so waiting for didFinishNavigation is
1803         not sufficient to guarantee we have received all the messages. Wait for them.
1804
1805 2019-01-24  Chris Dumez  <cdumez@apple.com>
1806
1807         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
1808         https://bugs.webkit.org/show_bug.cgi?id=193761
1809         <rdar://problem/47456405>
1810
1811         Reviewed by Alex Christensen.
1812
1813         Add API test coverage.
1814
1815         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1816
1817 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
1818
1819         webkitpy: Missing PID in crashlog name should not be fatal
1820         https://bugs.webkit.org/show_bug.cgi?id=193771
1821
1822         If we can't determine the PID of a crashlog, just ignore the crashlog instead
1823         of raising an exception.
1824
1825         Reviewed by Lucas Forschler.
1826
1827         * Scripts/webkitpy/port/darwin.py:
1828         (DarwinPort._merge_crash_logs):
1829
1830 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
1831
1832         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
1833         https://bugs.webkit.org/show_bug.cgi?id=193746
1834
1835         Reviewed by Youenn Fablet.
1836
1837         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
1838         so we'd best just not call it.
1839
1840         * Scripts/webkitpy/w3c/test_exporter.py:
1841         (WebPlatformTestExporter.create_branch_with_patch):
1842
1843 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
1844
1845         Move FileSystem to WTF
1846         https://bugs.webkit.org/show_bug.cgi?id=193602
1847
1848         Reviewed by Yusuke Suzuki.
1849
1850         * DumpRenderTree/win/DumpRenderTree.cpp:
1851         * TestWebKitAPI/CMakeLists.txt:
1852         * TestWebKitAPI/PlatformGTK.cmake:
1853         * TestWebKitAPI/PlatformJSCOnly.cmake:
1854         * TestWebKitAPI/PlatformPlayStation.cmake:
1855         * TestWebKitAPI/PlatformWPE.cmake:
1856         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1857         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
1858         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
1859         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
1860         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
1861         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
1862         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
1863         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1864         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
1865         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1866
1867 2019-01-24  Philippe Normand  <pnormand@igalia.com>
1868
1869         [WPE] Remove hard dependency on subprocess32 for the API tests
1870
1871         Rubber-stamped by Carlos Garcia Campos.
1872
1873         * glib/api_test_runner.py:
1874         (TestRunner._run_test_qt): Lazily import subprocess32 and check
1875         its presence only when running WPEQt tests.
1876
1877 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1878
1879         [GLIB] Expose JavaScriptCore options in GLib public API
1880         https://bugs.webkit.org/show_bug.cgi?id=188742
1881
1882         Reviewed by Michael Catanzaro.
1883
1884         Add a test for the new API.
1885
1886         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1887         (testsJSCOptions):
1888         (main):
1889
1890 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1891
1892         [GTK][WPE] Support JPEG 2000 images
1893         https://bugs.webkit.org/show_bug.cgi?id=186272
1894
1895         Reviewed by Žan Doberšek.
1896
1897         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
1898
1899         * gtk/jhbuild.modules:
1900         * wpe/jhbuild.modules:
1901
1902 2019-01-23  David Kilzer  <ddkilzer@apple.com>
1903
1904         check-webkit-style should warn when using soft-linking macros in a header
1905         <https://webkit.org/b/193750>
1906
1907         Reviewed by Darin Adler.
1908
1909         * Scripts/webkitpy/style/checkers/cpp.py:
1910         (check_language): Add softlink/header check by refactoring the
1911         softlink/framework check.
1912         (CppChecker): Enable softlink/header check by default.
1913         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1914         (CppStyleTest.test_softlink_framework): Rename from
1915         CppStyleTest.test_softlink() and change test framework name in
1916         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
1917         files. Set file_name for macros that only appear in headers.
1918         (CppStyleTest.test_softlink_header): Add tests for using
1919         soft-link macros in headers.
1920
1921 2019-01-23  Chris Dumez  <cdumez@apple.com>
1922
1923         Deprecate API to limit the maximum number of WebProcesses
1924         https://bugs.webkit.org/show_bug.cgi?id=193725
1925         <rdar://problem/47464879>
1926
1927         Reviewed by Geoff Garen.
1928
1929         Update existing API tests to stop using deprecated API.
1930
1931         * MiniBrowser/mac/AppDelegate.m:
1932         (defaultConfiguration):
1933         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1934         (TestWebKitAPI::TEST):
1935         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
1936         (TestWebKitAPI::TEST):
1937         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1938         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
1939         (TEST):
1940         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1941         (TEST):
1942
1943 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
1944
1945         [ews-app] Rename ews model buildermappings to buildermapping
1946         https://bugs.webkit.org/show_bug.cgi?id=193729
1947
1948         Reviewed by Lucas Forschler.
1949
1950         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
1951         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
1952         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
1953
1954 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
1955
1956         [ews-app] Rename ews model steps to step
1957         https://bugs.webkit.org/show_bug.cgi?id=193697
1958
1959         Reviewed by Lucas Forschler.
1960
1961         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
1962         (Step): Renamed Steps to Step.
1963
1964 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
1965
1966         Clean up IndexedDB files between tests
1967         https://bugs.webkit.org/show_bug.cgi?id=192796
1968         <rdar://problem/46824999>
1969
1970         Reviewed by Geoffrey Garen.
1971
1972         * DumpRenderTree/mac/DumpRenderTree.mm:
1973         (runTest):
1974         * WebKitTestRunner/TestController.cpp:
1975         (WTR::TestController::resetStateToConsistentValues):
1976         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
1977         (WTR::RemoveAllIndexedDatabasesCallback):
1978         (WTR::TestController::ClearIndexedDatabases):
1979         * WebKitTestRunner/TestController.h:
1980         * WebKitTestRunner/TestInvocation.cpp:
1981         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1982
1983 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
1984
1985         [ews-app] Rename ews model Builds to Build
1986         https://bugs.webkit.org/show_bug.cgi?id=193695
1987
1988         Reviewed by Lucas Forschler.
1989
1990         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
1991         (Build): Renamed Builds to Build.
1992
1993 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
1994
1995         webkitpy: Wait longer when launching WebKitTestRunner
1996         https://bugs.webkit.org/show_bug.cgi?id=193734
1997
1998         Reviewed by Aakash Jain.
1999
2000         * Scripts/webkitpy/port/simulator_process.py:
2001         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
2002
2003 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
2004
2005         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
2006         https://bugs.webkit.org/show_bug.cgi?id=193182
2007         <rdar://problem/47452154>
2008
2009         Reviewed by Tim Horton.
2010
2011         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
2012         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
2013         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
2014
2015         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
2016         preventing later tests from recognizing gestures.
2017
2018         * WebKitTestRunner/ios/TestControllerIOS.mm:
2019         (WTR::TestController::platformResetStateToConsistentValues):
2020
2021         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
2022
2023 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
2024
2025         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
2026         https://bugs.webkit.org/show_bug.cgi?id=193722
2027         <rdar://problem/47481475>
2028
2029         Reviewed by Lucas Forschler.
2030
2031         iPhone and iPad ports should both use the iOS config.
2032
2033         * Scripts/webkitpy/port/ios_simulator.py:
2034         (IPhoneSimulatorPort.__init__):
2035         (IPadSimulatorPort.__init__):
2036
2037 2019-01-23  Rob Buis  <rbuis@igalia.com>
2038
2039         Update MIME type parser
2040         https://bugs.webkit.org/show_bug.cgi?id=180526
2041
2042         Reviewed by Frédéric Wang.
2043
2044         Add unit tests for both parse modes of ParsedContentType.
2045
2046         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2047         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
2048         (TestWebKitAPI::TEST):
2049
2050 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
2051
2052         [ews-app] fetch loop should not stop on network issues
2053         https://bugs.webkit.org/show_bug.cgi?id=193666
2054
2055         Reviewed by Lucas Forschler.
2056
2057         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2058         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
2059
2060 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2061
2062         [iOS] Multiple WKWebViewAutofillTests are flaky failures
2063         https://bugs.webkit.org/show_bug.cgi?id=189165
2064         <rdar://problem/47433765>
2065
2066         Reviewed by Tim Horton.
2067
2068         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
2069         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
2070         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
2071         process in sufficient to ensure that any previous action that blurred the focused element in the web process
2072         would make its way to the UI process by the time the layer tree commit is finished.
2073
2074         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
2075         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
2076         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
2077         will fail because it asks for -_autofillContext too early.
2078
2079         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
2080         is handled in the UI process.
2081
2082         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2083
2084         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
2085         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
2086         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
2087         input session.
2088
2089         (-[AutofillTestView textInputHasAutofillContext]):
2090
2091         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
2092
2093         * TestWebKitAPI/cocoa/TestWKWebView.h:
2094         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2095         (nextInputSessionChangeCount):
2096
2097         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
2098         This includes changing the focused element from one to another.
2099
2100         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
2101         (-[TestWKWebView didStartFormControlInteraction]):
2102         (-[TestWKWebView didEndFormControlInteraction]):
2103         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
2104
2105         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
2106         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
2107         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
2108         that doesn't require an input session to one that doesn't.
2109
2110 2019-01-22  David Kilzer  <ddkilzer@apple.com>
2111
2112         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
2113         <https://webkit.org/b/193676>
2114
2115         Reviewed by Alexey Proskuryakov.
2116
2117         * Scripts/webkitpy/style/checkers/cpp.py:
2118         (check_member_initialization_list):
2119         - Don't report missing whitespace around colon if the colon at
2120           the start of the line is formatted correctly.
2121         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2122         (WebKitStyleTest.test_member_initialization_list):
2123         - Add a test for a missing permutation of existing tests.
2124         - Add a test this false-positive.
2125         - Add blank lines between subtests to make them easier to read.
2126
2127 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
2128
2129         [build.webkit.org] Unit-test failure after r237113
2130         https://bugs.webkit.org/show_bug.cgi?id=193669
2131
2132         Reviewed by Michael Catanzaro.
2133
2134         * BuildSlaveSupport/build.webkit.org-config/factories.py:
2135         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
2136         multiple or zero flags.
2137
2138 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
2139
2140         Cache bytecode to disk
2141         https://bugs.webkit.org/show_bug.cgi?id=192782
2142         <rdar://problem/46084932>
2143
2144         Reviewed by Keith Miller.
2145
2146         Add test helper to execute bytecode-cache tests: it executes each test
2147         twice, the first with JSC_diskCachePath set to a temporary directory
2148         and second with JSC_forceDiskCache=true (in addition to the cache path)
2149         to guarantee that only the disk cache is being used and no new
2150         UnlinkedCodeBlocks are being created.
2151
2152         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
2153         * Scripts/run-jsc-stress-tests:
2154
2155 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
2156
2157         [css-logical] Implement flow-relative margin, padding and border shorthands
2158         https://bugs.webkit.org/show_bug.cgi?id=188697
2159
2160         Reviewed by Simon Fraser and Antti Koivisto.
2161
2162         * DumpRenderTree/TestOptions.cpp:
2163         (TestOptions::TestOptions):
2164         * DumpRenderTree/TestOptions.h:
2165         * DumpRenderTree/mac/DumpRenderTree.mm:
2166         (setWebPreferencesForTestOptions):
2167         Allow tests to enable the CSSLogicalEnabled flag in WK1.
2168
2169         * Scripts/webkitpy/style/checkers/jsonchecker.py:
2170         (JSONCSSPropertiesChecker.check_codegen_properties):
2171         Allow CSS property definitions to have a 'runtime-flag' parameter which
2172         disables the property when the specified runtime flag is disabled.
2173
2174 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
2175
2176         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
2177         https://bugs.webkit.org/show_bug.cgi?id=193643
2178
2179         Reviewed by Michael Catanzaro.
2180
2181         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
2182         * wpe/jhbuild.modules: Ditto.
2183
2184 2019-01-21  Zalan Bujtas  <zalan@apple.com>
2185
2186         [LFC][Floats] Take float top position into account when computing containing block height.
2187         https://bugs.webkit.org/show_bug.cgi?id=193655
2188
2189         Reviewed by Antti Koivisto.
2190
2191         * LayoutReloaded/misc/LFC-passing-tests.txt:
2192
2193 2019-01-21  David Kilzer  <ddkilzer@apple.com>
2194
2195         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
2196         <https://webkit.org/b/193645>
2197         <rdar://problem/47421574>
2198
2199         Reviewed by Alex Christensen.
2200
2201         - Now checks for local soft-linking of all frameworks that have
2202           their own *SoftLinking.{cpp,h,mm} files.
2203         - Changes softlink/uikit warning to softlink/framework.
2204
2205         * Scripts/webkitpy/style/checkers/cpp.py:
2206         (check_language):
2207         (CppChecker):
2208         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2209         (CppStyleTest):
2210
2211 2019-01-20  Saam Barati  <sbarati@apple.com>
2212
2213         Rollout r240210: It broke tests on iOS
2214         https://bugs.webkit.org/show_bug.cgi?id=193640
2215
2216         Unreviewed.
2217
2218         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
2219         * Scripts/run-jsc-stress-tests:
2220
2221 2019-01-20  chris fleizach  <cfleizach@apple.com>
2222
2223         AX: Support returning relative frames for accessibility
2224         https://bugs.webkit.org/show_bug.cgi?id=193414
2225         <rdar://problem/47268501>
2226
2227         Reviewed by Zalan Bujtas.
2228
2229         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2230         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2231         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2232         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2233         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2234         (WTR::attributesOfElement):
2235         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2236
2237 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
2238
2239         Unreviewed, add my new email address
2240
2241         * Scripts/webkitpy/common/config/contributors.json:
2242
2243 2019-01-19  Zalan Bujtas  <zalan@apple.com>
2244
2245         [LFC][BFC] <body>'s overflow property value is propagated to viewport
2246         https://bugs.webkit.org/show_bug.cgi?id=193617
2247
2248         Reviewed by Antti Koivisto.
2249
2250         * LayoutReloaded/misc/LFC-passing-tests.txt:
2251
2252 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
2253
2254         Unreviewed, rolling out r240209.
2255
2256         Broke GTK/WPE injected bundle
2257
2258         Reverted changeset:
2259
2260         "AX: Support returning relative frames for accessibility"
2261         https://bugs.webkit.org/show_bug.cgi?id=193414
2262         https://trac.webkit.org/changeset/240209
2263
2264 2019-01-12  Dan Bernstein  <mitz@apple.com>
2265
2266         [Cocoa] Avoid importing directly from subumbrella frameworks
2267         https://bugs.webkit.org/show_bug.cgi?id=186016
2268         <rdar://problem/40591038>
2269
2270         Reviewed by Sam Weinig.
2271
2272         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
2273           LaunchServices header.
2274         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2275           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2276         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
2277           when using SDKs earlier than 10.13.
2278         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
2279           and OTHER_CPLUSPLUSFLAGS.
2280         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2281           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2282         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
2283           LaunchServices header.
2284
2285 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
2286
2287         Cache bytecode to disk
2288         https://bugs.webkit.org/show_bug.cgi?id=192782
2289         <rdar://problem/46084932>
2290
2291         Reviewed by Keith Miller.
2292
2293         Add test helper to execute bytecode-cache tests: it executes each test
2294         twice, the first with JSC_diskCachePath set to a temporary directory
2295         and second with JSC_forceDiskCache=true (in addition to the cache path)
2296         to guarantee that only the disk cache is being used and no new
2297         UnlinkedCodeBlocks are being created.
2298
2299         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
2300         * Scripts/run-jsc-stress-tests:
2301
2302 2019-01-20  chris fleizach  <cfleizach@apple.com>
2303
2304         AX: Support returning relative frames for accessibility
2305         https://bugs.webkit.org/show_bug.cgi?id=193414
2306         <rdar://problem/47268501>
2307
2308         Reviewed by Zalan Bujtas.
2309
2310         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2311         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2312         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2313         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2314         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2315         (WTR::attributesOfElement):
2316         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2317
2318 2019-01-20  Antoine Quint  <graouts@apple.com>
2319
2320         Add a POINTER_EVENTS feature flag
2321         https://bugs.webkit.org/show_bug.cgi?id=193577
2322         <rdar://problem/47408511>
2323
2324         Unreviewed. Also enable Pointer Events for iosmac.
2325
2326         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2327
2328 2019-01-19  Zalan Bujtas  <zalan@apple.com>
2329
2330         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
2331         https://bugs.webkit.org/show_bug.cgi?id=193613
2332
2333         Reviewed by Antti Koivisto.
2334
2335         * LayoutReloaded/misc/LFC-passing-tests.txt:
2336
2337 2019-01-19  Antoine Quint  <graouts@apple.com>
2338
2339         Add a POINTER_EVENTS feature flag
2340         https://bugs.webkit.org/show_bug.cgi?id=193577
2341
2342         Reviewed by Dean Jackson.
2343
2344         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2345
2346 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
2347
2348         Disable the run-jsc-stress-test remote host key check [second round].
2349         https://bugs.webkit.org/show_bug.cgi?id=192988
2350
2351         Reviewed by Dewei Zhu.
2352
2353         * Scripts/run-jsc-stress-tests:
2354
2355 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2356
2357         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
2358         https://bugs.webkit.org/show_bug.cgi?id=193597
2359
2360         Reviewed by Lucas Forschler.
2361
2362         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2363
2364 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2365
2366         [build.webkit.org] api tests failures are incorrectly named as unit test failures
2367         https://bugs.webkit.org/show_bug.cgi?id=193595
2368
2369         Reviewed by Lucas Forschler.
2370
2371         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
2372         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
2373         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
2374
2375 2019-01-18  Chris Dumez  <cdumez@apple.com>
2376
2377         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
2378         https://bugs.webkit.org/show_bug.cgi?id=193588
2379         <rdar://problem/47131566>
2380
2381         Reviewed by Alex Christensen.
2382
2383         Add layout test coverage.
2384
2385         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2386
2387 2019-01-18  Jer Noble  <jer.noble@apple.com>
2388
2389         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
2390         https://bugs.webkit.org/show_bug.cgi?id=189553
2391
2392         Reviewed by Tim Horton.
2393
2394         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
2395
2396         * ContentExtensionTester/Configurations/Base.xcconfig:
2397         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
2398         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2399         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
2400         * ImageDiff/cg/Configurations/Base.xcconfig:
2401         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
2402         * MiniBrowser/Configurations/Base.xcconfig:
2403         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2404         * MobileMiniBrowser/Configurations/Base.xcconfig:
2405         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2406         * Scripts/webkitpy/style/checker.py:
2407         (_all_categories):
2408         (FileType):
2409         (CheckerDispatcher._file_type):
2410         (CheckerDispatcher._create_checker):
2411         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
2412         (SDKVariantChecker):
2413         (SDKVariantChecker.__init__):
2414         (SDKVariantChecker.check):
2415         * TestWebKitAPI/Configurations/Base.xcconfig:
2416         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
2417         * WebEditingTester/Configurations/Base.xcconfig:
2418         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
2419         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
2420         * WebKitTestRunner/Configurations/Base.xcconfig:
2421         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
2422         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
2423         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
2424
2425 2019-01-18  David Kilzer  <ddkilzer@apple.com>
2426
2427         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
2428         <https://webkit.org/b/193568>
2429         <rdar://problem/47381130>
2430
2431         Reviewed by Alex Christensen.
2432
2433         Make sure no one re-introduces UIKit soft-linking by adding a
2434         style rule.
2435
2436         * Scripts/webkitpy/style/checkers/cpp.py:
2437         (check_language): Add softlink/uikit check.
2438         (CppChecker): Enable softlink/uikit check.
2439         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2440         (CppStyleTest): Add test for softlink/uikit.
2441
2442 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
2443
2444         [GTK] install-dependencies tool looks for libunistring-dev for dnf
2445         https://bugs.webkit.org/show_bug.cgi?id=193584
2446
2447         Change "-dev" to "-devel".
2448
2449         Reviewed by Michael Catanzaro.
2450
2451         * gtk/install-dependencies:
2452
2453 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2454
2455         webkitpy: Add iPhone and iPad ports
2456         https://bugs.webkit.org/show_bug.cgi?id=193537
2457         <rdar://problem/47353390>
2458
2459         Reviewed by Lucas Forschler.
2460
2461         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
2462         ports. Note that this separation is optional, the --ios-simulator command remains.
2463
2464         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2465         (RunTest.test_device_type_test_division): Drive-by fix.
2466         (RunTest.test_device_type_specific_listing): Ditto.
2467         (RunTest.test_ipad_test_division):
2468         (RunTest):
2469         (RunTest.test_ipad_listing):
2470         * Scripts/webkitpy/port/factory.py:
2471         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
2472         (PortFactory):
2473         * Scripts/webkitpy/port/ios_simulator.py:
2474         (IPhoneSimulatorPort):
2475         (IPadSimulatorPort):
2476
2477 2019-01-18  Chris Dumez  <cdumez@apple.com>
2478
2479         Regression(PSON) Scroll position is not always restored properly when navigating back
2480         https://bugs.webkit.org/show_bug.cgi?id=193578
2481         <rdar://problem/47386331>
2482
2483         Reviewed by Tim Horton.
2484
2485         Add API test coverage.
2486
2487         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2488
2489 2019-01-18  Youenn Fablet  <youenn@apple.com>
2490
2491         Add a new SPI to request for cache storage quota increase
2492         https://bugs.webkit.org/show_bug.cgi?id=193323
2493
2494         Reviewed by Alex Christensen.
2495
2496         Implement WebsiteDataStore quota delegate to handle quota requests.
2497         By default, do not update quota.
2498         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
2499
2500         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2501         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2502         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
2503         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2504         * WebKitTestRunner/TestController.cpp:
2505         (WTR::TestController::allowCacheStorageQuotaIncrease):
2506         * WebKitTestRunner/TestController.h:
2507         * WebKitTestRunner/TestInvocation.cpp:
2508         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2509         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2510         (-[CacheStorageQuotaManager init]):
2511         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2512         (WTR::initializeWebViewConfiguration):
2513         (WTR::TestController::cocoaResetStateToConsistentValues):
2514         (WTR::TestController::allowCacheStorageQuotaIncrease):
2515
2516 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2517
2518         [ews-build] Pass owner to the triggered builds
2519         https://bugs.webkit.org/show_bug.cgi?id=193574
2520
2521         Reviewed by Lucas Forschler.
2522
2523         * BuildSlaveSupport/ews-build/factories.py:
2524         (BuildFactory.propertiesToPassToTriggers):
2525
2526 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2527
2528         [ews-app] Send patch author as a build property
2529         https://bugs.webkit.org/show_bug.cgi?id=193560
2530
2531         Reviewed by Lucas Forschler.
2532
2533         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2534         (BugzillaPatchFetcher.fetch):
2535
2536 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2537
2538         webkitpy: Implement device type specific expected results (Follow-up fix)
2539         https://bugs.webkit.org/show_bug.cgi?id=192162
2540         <rdar://problem/46345449>
2541
2542         Unreviewed infrastructure fix.
2543
2544         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2545         (Manager.run): Don't boot a device if no tests are available to run on it.
2546
2547 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2548
2549         webkitpy: Implement device type specific expected results (Follow-up fix)
2550         https://bugs.webkit.org/show_bug.cgi?id=192162
2551         <rdar://problem/46345449>
2552
2553         Unreviewed infrastructure fix.
2554
2555         * Scripts/webkitpy/api_tests/manager.py:
2556         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
2557
2558 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2559
2560         webkitpy: Implement device type specific expected results (Part 2)
2561         https://bugs.webkit.org/show_bug.cgi?id=192162
2562         <rdar://problem/46345449>
2563
2564         Rubber-stamped by Aakash Jain.
2565
2566         This change uses device_type to select a different set of TestExpectation files based on the type of device running
2567         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
2568         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
2569
2570         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
2571         (LayoutTestFinder.find_tests): Pass device_type through.
2572         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
2573         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
2574         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2575         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
2576         (Manager._collect_tests): Pass device type to test finder.
2577         (Manager._needs_web_platform_test):
2578         (Manager._prepare_lists): Index _expectations by device type.
2579         (Manager._test_input_for_file):
2580         (Manager._test_is_slow): Ditto.
2581         (Manager._test_should_dump_jsconsolelog_in_stderr):
2582         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
2583         (Manager._get_test_inputs):
2584         (Manager._update_worker_count):
2585         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
2586         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
2587         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
2588         the one which runs the test.
2589         (Manager._run_test_subset):
2590         (Manager._run_tests): Index _expectations by current_device_type.
2591         (Manager._print_expectation_line_for_test): Ditto.
2592         (Manager._print_expectations_for_subset): Ditto.
2593         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
2594         Unlike run, this function will behave the same regardless of what devices are available.
2595         (Manager._custom_device_for_test): Deleted.
2596         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2597         (ManagerTest.test_uses_custom_device): Deleted.
2598         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
2599         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2600         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
2601         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
2602         all of the expectations.
2603         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
2604         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
2605         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2606         (TestExpectations.__init__): Allow device_type to be passed through.
2607         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
2608         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
2609         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2610         (summarize_results):
2611         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
2612         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
2613         a test ran with, one must check all expectations to find the first non-skip expectation.
2614         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2615         (RunTest.test_device_type_test_division):
2616         (RunTest):
2617         (RunTest.test_device_type_specific_listing):
2618         * Scripts/webkitpy/port/base.py:
2619         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
2620         (Port.supported_device_types): The result of this function will change based on what devices are available.
2621         * Scripts/webkitpy/port/device_port.py:
2622         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
2623         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
2624         can be used.
2625         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
2626         any, or the DEFAULT_DEVICE_TYPES of the port.
2627         * Scripts/webkitpy/port/ios.py:
2628         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
2629         * Scripts/webkitpy/port/ios_simulator.py:
2630         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
2631         * Scripts/webkitpy/port/watch.py:
2632         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
2633         * Scripts/webkitpy/port/watch_simulator.py:
2634         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
2635         * Scripts/webkitpy/xcode/device_type.py:
2636         (DeviceType):
2637         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
2638
2639 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2640
2641         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
2642         https://bugs.webkit.org/show_bug.cgi?id=193575
2643
2644         Reviewed by Michael Catanzaro.
2645
2646         Allow the script to run without explicit port argument because
2647         it's specific to the WPE port anyway.
2648
2649         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
2650         and simplify the rest of the code accordingly.
2651
2652 2019-01-18  Charlie Turner  <cturner@igalia.com>
2653
2654         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
2655         https://bugs.webkit.org/show_bug.cgi?id=192229
2656
2657         Reviewed by Xabier Rodriguez-Calvar.
2658
2659         * MiniBrowser/wpe/main.cpp:
2660         (main): Enable encrypted-media by default.
2661
2662 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2663
2664         [Flatpak] Missing KeyboardInterrupt exception handler
2665         https://bugs.webkit.org/show_bug.cgi?id=193570
2666
2667         Reviewed by Michael Catanzaro.
2668
2669         * flatpak/flatpakutils.py:
2670         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
2671
2672 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2673
2674         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
2675         https://bugs.webkit.org/show_bug.cgi?id=193564
2676
2677         Reviewed by Antti Koivisto.
2678
2679         * LayoutReloaded/misc/LFC-passing-tests.txt:
2680
2681 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2682
2683         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
2684         https://bugs.webkit.org/show_bug.cgi?id=193562
2685
2686         Reviewed by Antti Koivisto.
2687
2688         * LayoutReloaded/misc/LFC-passing-tests.txt:
2689
2690 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2691
2692         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
2693         https://bugs.webkit.org/show_bug.cgi?id=193555
2694
2695         Reviewed by Antti Koivisto.
2696
2697         * LayoutReloaded/misc/LFC-passing-tests.txt:
2698
2699 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2700
2701         [WPE] Add Qt extension
2702         https://bugs.webkit.org/show_bug.cgi?id=191464
2703
2704         Reviewed by Carlos Garcia Campos.
2705
2706         MiniBrowser and API tests for the WPE Qt API. To run the
2707         MiniBrowser a new script is introduced. Example invocation:
2708
2709         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
2710
2711         Also note-worthy is the introduction of the python2-subprocess32
2712         dependency to run the GLib API tests.
2713
2714         * MiniBrowser/wpe/CMakeLists.txt:
2715         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
2716         * MiniBrowser/wpe/qt/main.cpp: Added.
2717         (main):
2718         * MiniBrowser/wpe/qt/main.qml: Added.
2719         * MiniBrowser/wpe/qt/qml.qrc: Added.
2720         * Scripts/run-gtk-tests:
2721         (GtkTestRunner.is_google_test):
2722         (GtkTestRunner):
2723         (GtkTestRunner.is_qt_test):
2724         * Scripts/run-qt-wpe-minibrowser: Added.
2725         * Scripts/run-wpe-tests:
2726         (WPETestRunner):
2727         (WPETestRunner.is_google_test):
2728         (WPETestRunner.is_qt_test):
2729         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
2730         (TestLoad::main):
2731         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
2732         (TestLoadHtml::main):
2733         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
2734         (TestLoadRequest::main):
2735         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
2736         (TestRunJavaScript::main):
2737         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
2738         (waitForSignal):
2739         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
2740         (LoadSpy::LoadSpy):
2741         (LoadSpy::~LoadSpy):
2742         (LoadSpy::onLoadingChanged):
2743         (LoadStartedCatcher::LoadStartedCatcher):
2744         (LoadStartedCatcher::~LoadStartedCatcher):
2745         (LoadStartedCatcher::onLoadingChanged):
2746         (waitForLoadSucceeded):
2747         (waitForLoadFailed):
2748         * TestWebKitAPI/glib/CMakeLists.txt:
2749         * flatpak/flatpakutils.py:
2750         (WebkitFlatpak.load_from_args):
2751         (WebkitFlatpak.__init__):
2752         (WebkitFlatpak.clean_args):
2753         (WebkitFlatpak.run_in_sandbox):
2754         * flatpak/org.webkit.CommonModules.yaml:
2755         * flatpak/org.webkit.WPE.yaml:
2756         * flatpak/org.webkit.WPEModules.yaml:
2757         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
2758         * flatpak/org.webkit.WebKit.yaml:
2759         * glib/api_test_runner.py:
2760         (TestRunner._run_test_qt):
2761         (TestRunner.is_qt_test):
2762         (TestRunner._run_test):
2763
2764 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2765
2766         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
2767         https://bugs.webkit.org/show_bug.cgi?id=193494
2768         <rdar://problem/46859627>
2769
2770         Reviewed by Simon Fraser and Tim Horton.
2771
2772         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
2773         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
2774
2775         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2776         (WTR::UIScriptController::contentOffsetX const):
2777         (WTR::UIScriptController::contentOffsetY const):
2778         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2779         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2780         (WTR::UIScriptController::contentOffsetX const):
2781         (WTR::UIScriptController::contentOffsetY const):
2782         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2783
2784         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
2785
2786         * WebKitTestRunner/TestController.cpp:
2787         (WTR::updateTestOptionsFromTestHeader):
2788         * WebKitTestRunner/TestOptions.h:
2789         (WTR::TestOptions::hasSameInitializationOptions const):
2790         * WebKitTestRunner/ios/TestControllerIOS.mm:
2791         (WTR::TestController::platformResetStateToConsistentValues):
2792         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2793         (WTR::UIScriptController::contentOffsetX const):
2794         (WTR::UIScriptController::contentOffsetY const):
2795
2796 2019-01-17  Truitt Savell  <tsavell@apple.com>
2797
2798         Unreviewed, rolling out r240124.
2799
2800         This commit broke an internal build.
2801
2802         Reverted changeset:
2803
2804         "SDK_VARIANT build destinations should be separate from non-
2805         SDK_VARIANT builds"
2806         https://bugs.webkit.org/show_bug.cgi?id=189553
2807         https://trac.webkit.org/changeset/240124
2808
2809 2019-01-17  Alex Christensen  <achristensen@webkit.org>
2810
2811         Fix string concatenation API test after r239920
2812         https://bugs.webkit.org/show_bug.cgi?id=193551
2813         <rdar://problem/47359304>
2814
2815         Reviewed by Youenn Fablet.
2816
2817         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
2818         (TestWebKitAPI::TEST):
2819         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
2820         in WebKit's build configuration like it apparently is on Linux.
2821
2822 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2823
2824         [ews-build] validate-patch should handle the case when bug_id is None
2825         https://bugs.webkit.org/show_bug.cgi?id=193547
2826
2827         Reviewed by Lucas Forschler.
2828
2829         * BuildSlaveSupport/ews-build/steps.py:
2830         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
2831         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
2832
2833 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2834
2835         [ews-build] Add patch author information in build
2836         https://bugs.webkit.org/show_bug.cgi?id=193465
2837
2838         Reviewed by Lucas Forschler.
2839
2840         * BuildSlaveSupport/ews-build/steps.py:
2841         (ValidatePatch._is_patch_obsolete):
2842
2843 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2844
2845         [ews-build] Pass bug_id to the triggered builds
2846         https://bugs.webkit.org/show_bug.cgi?id=193548
2847
2848         Reviewed by Lucas Forschler.
2849
2850         * BuildSlaveSupport/ews-build/factories.py:
2851         (BuildFactory.propertiesToPassToTriggers):
2852
2853 2019-01-17  Jer Noble  <jer.noble@apple.com>
2854
2855         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
2856         https://bugs.webkit.org/show_bug.cgi?id=189553
2857
2858         Reviewed by Tim Horton.
2859
2860         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
2861
2862         * ContentExtensionTester/Configurations/Base.xcconfig:
2863         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
2864         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2865         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
2866         * ImageDiff/cg/Configurations/Base.xcconfig:
2867         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
2868         * MiniBrowser/Configurations/Base.xcconfig:
2869         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2870         * MobileMiniBrowser/Configurations/Base.xcconfig:
2871         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2872         * Scripts/webkitpy/style/checker.py:
2873         (_all_categories):
2874         (FileType):
2875         (CheckerDispatcher._file_type):
2876         (CheckerDispatcher._create_checker):
2877         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
2878         (SDKVariantChecker):
2879         (SDKVariantChecker.__init__):
2880         (SDKVariantChecker.check):
2881         * TestWebKitAPI/Configurations/Base.xcconfig:
2882         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
2883         * WebEditingTester/Configurations/Base.xcconfig:
2884         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
2885         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
2886         * WebKitTestRunner/Configurations/Base.xcconfig:
2887         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
2888         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
2889         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
2890
2891 2019-01-17  Zalan Bujtas  <zalan@apple.com>
2892
2893         [LFC][BFC] An element with transform is a containing block for positioned descendants.
2894         https://bugs.webkit.org/show_bug.cgi?id=193534
2895
2896         Reviewed by Antti Koivisto.
2897
2898         * LayoutReloaded/misc/LFC-passing-tests.txt:
2899
2900 2019-01-17  Zalan Bujtas  <zalan@apple.com>
2901
2902         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
2903         https://bugs.webkit.org/show_bug.cgi?id=193528
2904
2905         Reviewed by Antti Koivisto.
2906
2907         * LayoutReloaded/misc/LFC-passing-tests.txt:
2908
2909 2019-01-17  Zalan Bujtas  <zalan@apple.com>
2910
2911         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
2912         https://bugs.webkit.org/show_bug.cgi?id=193520
2913
2914         Reviewed by Antti Koivisto.
2915
2916         * LayoutReloaded/misc/LFC-passing-tests.txt:
2917
2918 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2919
2920         [ews-build] unapply-patch step should not update source
2921         https://bugs.webkit.org/show_bug.cgi?id=193234
2922
2923         Reviewed by Lucas Forschler.
2924
2925         * BuildSlaveSupport/ews-build/steps.py:
2926         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
2927         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
2928
2929 2019-01-16  Youenn Fablet  <youenn@apple.com>
2930
2931         Add a new SPI for controlling getUserMedia
2932         https://bugs.webkit.org/show_bug.cgi?id=192793
2933
2934         Reviewed by Eric Carlson.
2935
2936         * MiniBrowser/mac/WK2BrowserWindowController.m:
2937         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
2938         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
2939         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
2940         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2941         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
2942         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2943         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
2944         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2945         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
2946         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2947         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
2948         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
2949         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2950         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
2951
2952 2019-01-16  Zalan Bujtas  <zalan@apple.com>
2953
2954         [LFC][BFC] Inflow non-replaced used width should not be negative.
2955         https://bugs.webkit.org/show_bug.cgi?id=193495
2956
2957         Reviewed by Antti Koivisto.
2958
2959         * LayoutReloaded/misc/LFC-passing-tests.txt:
2960
2961 2019-01-16  Chris Dumez  <cdumez@apple.com>
2962
2963         Regression(PSON) View becomes blank after click a cross-site download link
2964         https://bugs.webkit.org/show_bug.cgi?id=193361
2965         <rdar://problem/47099573>
2966
2967         Reviewed by Geoffrey Garen.
2968
2969         Add API test coverage.
2970
2971         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2972         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2973
2974 2019-01-16  Zalan Bujtas  <zalan@apple.com>
2975
2976         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
2977         https://bugs.webkit.org/show_bug.cgi?id=193470
2978
2979         Reviewed by Antti Koivisto.
2980
2981         * LayoutReloaded/misc/LFC-passing-tests.txt:
2982
2983 2019-01-16  Zalan Bujtas  <zalan@apple.com>
2984
2985         [LFC] Adjust margin box verification.
2986         https://bugs.webkit.org/show_bug.cgi?id=193482
2987
2988         Reviewed by Antti Koivisto.
2989
2990         * LayoutReloaded/misc/LFC-passing-tests.txt:
2991
2992 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
2993
2994         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
2995         https://bugs.webkit.org/show_bug.cgi?id=193451
2996
2997         Reviewed by Geoffrey Garen.
2998
2999         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
3000         (TEST):
3001         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3002         (runWebsiteDataStoreCustomPaths):
3003
3004 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
3005
3006         webkitpy: Support boolean simctl isAvailable
3007         https://bugs.webkit.org/show_bug.cgi?id=193472
3008         <rdar://problem/47296150>
3009
3010         Reviewed by Ryosuke Niwa.
3011
3012         * Scripts/webkitpy/xcode/simulated_device.py:
3013         (SimulatedDeviceManager._create_runtimes):
3014         (SimulatedDeviceManager._create_device_with_runtime):
3015
3016 2019-01-15  Chris Dumez  <cdumez@apple.com>
3017
3018         Unreviewed, rolling out r239993, r239995, r239997, and
3019         r239999.
3020
3021         Caused assertions under
3022         ViewGestureController::disconnectFromProcess()
3023
3024         Reverted changesets:
3025
3026         "Regression(PSON) View becomes blank after click a cross-site
3027         download link"
3028         https://bugs.webkit.org/show_bug.cgi?id=193361
3029         https://trac.webkit.org/changeset/239993
3030
3031         "Unreviewed iOS build fix after r239993."
3032         https://trac.webkit.org/changeset/239995
3033
3034         "Fix iOS build after r239993"
3035         https://bugs.webkit.org/show_bug.cgi?id=193361
3036         https://trac.webkit.org/changeset/239997
3037
3038         "Unreviewed, revert part of r239997 as it is not needed to fix
3039         the build."
3040         https://trac.webkit.org/changeset/239999
3041
3042 2019-01-15  Tim Horton  <timothy_horton@apple.com>
3043
3044         Cannot tab out of WKWebView on macOS
3045         https://bugs.webkit.org/show_bug.cgi?id=161448
3046         <rdar://problem/28100085>
3047
3048         Reviewed by Dean Jackson.
3049
3050         Add a test that tabbing into and out of WKWebView works correctly.
3051
3052         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3053         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
3054         (WebKit2_CommandBackForwardTest::SetUp):
3055         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
3056         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
3057         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
3058         (-[FocusableView canBecomeKeyView]):
3059         (TEST):
3060         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
3061         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
3062         (-[OffscreenWindow initWithSize:]):
3063         (-[OffscreenWindow isKeyWindow]):
3064         (-[OffscreenWindow isVisible]):
3065         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3066         (TestWebKitAPI::PlatformWebView::initialize):
3067         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
3068         (-[ActiveOffscreenWindow isVisible]): Deleted.
3069         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
3070
3071 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
3072
3073         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
3074         https://bugs.webkit.org/show_bug.cgi?id=193459
3075
3076         Reviewed by Mark Lam.
3077
3078         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3079         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
3080
3081 2019-01-15  Chris Dumez  <cdumez@apple.com>
3082
3083         Regression(PSON) View becomes blank after click a cross-site download link
3084         https://bugs.webkit.org/show_bug.cgi?id=193361
3085         <rdar://problem/47099573>
3086
3087         Reviewed by Geoff Garen.
3088
3089         Add API test coverage.
3090
3091         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3092         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3093
3094 2019-01-15  Zalan Bujtas  <zalan@apple.com>
3095
3096         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
3097         https://bugs.webkit.org/show_bug.cgi?id=193448
3098
3099         Reviewed by Antti Koivisto.
3100
3101         * LayoutReloaded/misc/LFC-passing-tests.txt:
3102
3103 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
3104
3105         webkitpy: Implement device type specific expected results (Part 1)
3106         https://bugs.webkit.org/show_bug.cgi?id=192162
3107
3108         Reviewed by Lucas Forschler.
3109
3110         Device type specific expected results covers two related ideas. The first (covered by this change)
3111         is where to search for -expected.* files. The second is which tests to run based on the
3112         TestExpectations.txt file.
3113
3114         After this change, the baseline search path will be determined by the type of device running a
3115         test. Device type will be passed into any function which picks a file based on the baseline search
3116         path.
3117
3118         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3119         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
3120         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3121         (Manager.run): Print baseline search path for each round of devices.
3122         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3123         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
3124         (SingleTestRunner._expected_driver_output): Ditto.
3125         (SingleTestRunner._driver_input): Ditto.
3126         * Scripts/webkitpy/layout_tests/views/printing.py:
3127         (Printer.print_config): Move printing of baseline search path to a separate function.
3128         (Printer.print_baseline_search_path): Moved from Printer.print_config.
3129         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3130         (Testprinter.test_print_config):
3131         (Testprinter.test_print_baseline_search_path):
3132         * Scripts/webkitpy/port/base.py:
3133         (Port.baseline_search_path): Pass device_type through.
3134         (Port._expected_baselines_for_suffixes): Ditto.
3135         (Port.expected_baselines): Ditto.
3136         (Port.expected_filename): Ditto.
3137         (Port.expected_checksum): Ditto.
3138         (Port.expected_image): Ditto.
3139         (Port.expected_audio): Ditto.
3140         (Port.expected_text): Ditto.
3141         (Port.reference_files): Ditto.
3142         (Port.tests): Ditto.
3143         (Port._expanded_paths): Ditto.
3144         (Port.skipped_layout_tests): Ditto.
3145         (Port.expectations_dict): Ditto.
3146         (Port._port_specific_expectations_files): Ditto.
3147         (Port.expectations_files): Ditto.
3148         (Port.test_search_path): Ditto.
3149         (Port._tests_for_other_platforms): Ditto.
3150         * Scripts/webkitpy/port/base_unittest.py:
3151         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
3152         (PortTest.test_nonexistant_expectations): Ditto.
3153         (test_ref_tests_platform_directory): Ditto.
3154         * Scripts/webkitpy/port/darwin.py:
3155         (DarwinPort._port_specific_expectations_files): Accept device_type.
3156         * Scripts/webkitpy/port/driver.py:
3157         (DriverProxy):
3158         (DriverProxy.host): Expose _target_host for device_type information.
3159         * Scripts/webkitpy/port/gtk.py:
3160         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
3161         * Scripts/webkitpy/port/ios.py:
3162         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
3163         * Scripts/webkitpy/port/mac.py:
3164         (MacPort. default_baseline_search_path): Ditto.
3165         * Scripts/webkitpy/port/port_testcase.py:
3166         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
3167         * Scripts/webkitpy/port/test.py:
3168         * Scripts/webkitpy/port/watch.py:
3169         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
3170         * Scripts/webkitpy/port/win.py:
3171         (WinPort.test_search_path): Accept, but do not use, device_type.
3172         * Scripts/webkitpy/port/wpe.py:
3173         (WPEPort._port_specific_expectations_files): Ditto.
3174         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
3175         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
3176
3177 2019-01-15  Zalan Bujtas  <zalan@apple.com>
3178
3179         [LFC] Use the containing block's padding box to position out-of-flow elements.
3180         https://bugs.webkit.org/show_bug.cgi?id=193431
3181
3182         Reviewed by Antti Koivisto.
3183
3184         * LayoutReloaded/misc/LFC-passing-tests.txt:
3185
3186 2019-01-14  Tim Horton  <timothy_horton@apple.com>
3187
3188         Move a test implementation file that got misplaced in the Xcode project
3189
3190         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3191
3192 2019-01-14  Commit Queue  <commit-queue@webkit.org>
3193
3194         Unreviewed, rolling out r239901, r239909, r239910, r239912,
3195         r239913, and r239914.
3196         https://bugs.webkit.org/show_bug.cgi?id=193407
3197
3198         These revisions caused an internal failure (Requested by
3199         Truitt on #webkit).
3200
3201         Reverted changesets:
3202
3203         "[Cocoa] Avoid importing directly from subumbrella frameworks"
3204         https://bugs.webkit.org/show_bug.cgi?id=186016
3205         https://trac.webkit.org/changeset/239901
3206
3207         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
3208         https://trac.webkit.org/changeset/239909
3209
3210         "Tried to fix the build."
3211         https://trac.webkit.org/changeset/239910
3212
3213         "Fixed iOS builds after r239910."
3214         https://trac.webkit.org/changeset/239912
3215
3216         "More build fixing."
3217         https://trac.webkit.org/changeset/239913
3218
3219         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
3220         https://trac.webkit.org/changeset/239914
3221
3222 2019-01-14  Mark Lam  <mark.lam@apple.com>
3223
3224         Re-enable ability to build --cloop builds.
3225         https://bugs.webkit.org/show_bug.cgi?id=192955
3226         <rdar://problem/46882363>
3227
3228         Reviewed by Saam barati and Keith Miller.
3229
3230         The --cloop build option was being ignored this whole time since r236381.
3231         This patch makes it possible to build CLoop builds again.
3232
3233         * Scripts/build-jsc:
3234         * Scripts/webkitperl/FeatureList.pm:
3235         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3236
3237 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
3238
3239         webkitpy: Expose device_type from host-like objects
3240         https://bugs.webkit.org/show_bug.cgi?id=193406
3241         <rdar://problem/47262305>
3242
3243         Reviewed by Lucas Forschler.
3244
3245         Devices should expose device_type. As a result, all host objects should
3246         provide a device_type property, even if they do not yet define a device_type.
3247
3248         * Scripts/webkitpy/common/system/systemhost.py:
3249         (SystemHost):
3250         (SystemHost.device_type):
3251         * Scripts/webkitpy/common/system/systemhost_mock.py:
3252         (MockSystemHost):
3253         (MockSystemHost.device_type):
3254         * Scripts/webkitpy/port/device.py:
3255         (Device):
3256         (Device.device_type):
3257         * Scripts/webkitpy/xcode/simulated_device.py:
3258         (SimulatedDeviceManager._find_exisiting_device_for_request):
3259         (SimulatedDeviceManager._disambiguate_device_type):
3260         (SimulatedDeviceManager._does_fulfill_request):
3261         (SimulatedDeviceManager.device_count_for_type):
3262         (SimulatedDeviceManager.initialize_devices):
3263         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
3264         (test_available_devices):
3265         (test_swapping_devices):
3266
3267 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
3268
3269         webkitpy: Support alternate simctl device list output (Follow-up fix)
3270         https://bugs.webkit.org/show_bug.cgi?id=193362
3271         <rdar://problem/47122965>
3272
3273         Rubber-stamped by Lucas Forschler.
3274
3275         * Scripts/webkitpy/xcode/simulated_device.py:
3276         (SimulatedDeviceManager.populate_available_devices):
3277
3278 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
3279
3280         [iOS] Expose SPI to access the current sentence boundary and selection state
3281         https://bugs.webkit.org/show_bug.cgi?id=193398
3282         <rdar://problem/45893108>
3283
3284         Reviewed by Dean Jackson.
3285
3286         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
3287         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
3288         expected.
3289
3290         * TestWebKitAPI/EditingTestHarness.h:
3291         * TestWebKitAPI/EditingTestHarness.mm:
3292         (-[EditingTestHarness moveBackward]):
3293         (-[EditingTestHarness moveForward]):
3294         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
3295
3296         Add a couple of new helper methods on EditingTestHarness.
3297
3298         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
3299         (-[SelectionChangeObserver initWithWebView:]):
3300         (-[SelectionChangeObserver webView]):
3301         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
3302         (-[SelectionChangeObserver currentSelectionAttributes]):
3303
3304 2019-01-14  Zalan Bujtas  <zalan@apple.com>
3305
3306         [LFC][BFC] Add basic box-sizing support.
3307         https://bugs.webkit.org/show_bug.cgi?id=193392
3308
3309         Reviewed by Antti Koivisto.
3310
3311         * LayoutReloaded/misc/LFC-passing-tests.txt:
3312
3313 2019-01-14  Charlie Turner  <cturner@igalia.com>
3314
3315         [WPE] API test gardening
3316         https://bugs.webkit.org/show_bug.cgi?id=193319
3317
3318         Reviewed by Michael Catanzaro.
3319
3320         * TestWebKitAPI/glib/TestExpectations.json: Remove some now
3321         passing tests.
3322
3323 2019-01-14  Charlie Turner  <cturner@igalia.com>
3324
3325         [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
3326         https://bugs.webkit.org/show_bug.cgi?id=192977
3327
3328         Reviewed by Carlos Garcia Campos.
3329
3330         * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
3331         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
3332         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
3333         (TestWebKitAPI::GStreamerTest::SetUp):
3334         (TestWebKitAPI::GStreamerTest::TearDown):
3335         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
3336         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
3337         (TestWebKitAPI::TEST_F):
3338
3339 2019-01-14  Charlie Turner  <cturner@igalia.com>
3340
3341         [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
3342         https://bugs.webkit.org/show_bug.cgi?id=193332
3343
3344         Reviewed by Michael Catanzaro.
3345
3346         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
3347         defined as a char16_t, which changed in ICU 59, the
3348         StringTypeAdapter<UnsignedInt, ...> overload catches casts to
3349         unsigned short. This test is relying on the behaviour that
3350         UChar=unsigned short, which doesn't hold across platforms and ICU
3351         library versions. The full fix would be a special syntax for
3352         literal characters so that these ambiguities do not arise. That
3353         work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
3354         (TestWebKitAPI::TEST):
3355
3356 2019-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
3357
3358         Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
3359
3360         * Scripts/make-dist:
3361         (Distcheck.configure):
3362
3363 2019-01-13  Aakash Jain  <aakash_jain@apple.com>
3364
3365         [ews-build] Update macOS queue configurations
3366         https://bugs.webkit.org/show_bug.cgi?id=193365
3367         <rdar://problem/47221073>
3368
3369         Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
3370
3371         * BuildSlaveSupport/ews-build/config.json:
3372
3373 2019-01-13  Zalan Bujtas  <zalan@apple.com>
3374
3375         [LFC] Adjust assert for statically positioned fixed elements
3376         https://bugs.webkit.org/show_bug.cgi?id=193385
3377
3378         Reviewed by Antti Koivisto.
3379
3380         * LayoutReloaded/misc/LFC-passing-tests.txt:
3381
3382 2019-01-13  Philippe Normand  <pnormand@igalia.com>
3383
3384         [WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
3385         https://bugs.webkit.org/show_bug.cgi?id=193387
3386
3387         Reviewed by Carlos Garcia Campos.
3388
3389         * MiniBrowser/wpe/main.cpp:
3390         (main):
3391
3392 2019-01-12  Timothy Hatcher  <timothy@apple.com>
3393
3394         Have prefers-color-scheme: light always match on macOS versions before Mojave.
3395         https://bugs.webkit.org/show_bug.cgi?id=191655
3396         rdar://problem/46074680
3397
3398         Reviewed by Megan Gardner.
3399
3400         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
3401         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
3402
3403 2019-01-12  Dan Bernstein  <mitz@apple.com>
3404
3405         [Cocoa] Avoid importing directly from subumbrella frameworks
3406         https://bugs.webkit.org/show_bug.cgi?id=186016
3407         <rdar://problem/40591038>
3408
3409         Reviewed by Sam Weinig.
3410
3411         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
3412           LaunchServices header.
3413         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3414           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3415         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
3416           when using SDKs earlier than 10.13.
3417         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
3418           and OTHER_CPLUSPLUSFLAGS.
3419         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3420           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3421         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
3422           LaunchServices header.
3423
3424 2019-01-11  John Wilander  <wilander@apple.com>
3425
3426         Compile out Web API Statistics Collection
3427         https://bugs.webkit.org/show_bug.cgi?id=193370
3428         <rdar://problem/45388584>
3429
3430         Reviewed by Brent Fulgham.
3431
3432         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3433             Defined ENABLE_WEB_API_STATISTICS, off by default.
3434
3435 2019-01-11  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
3436
3437         [WPE] Add gtk-doc
3438         https://bugs.webkit.org/show_bug.cgi?id=178900
3439
3440         Reviewed by Michael Catanzaro.
3441
3442         Add Tools/gtkdoc to manifest.txt.in files.
3443         This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
3444
3445         * gtk/manifest.txt.in: Add Tools/gtkdoc directory.
3446         * wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
3447
3448 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3449
3450         [iOS] Precision drop state thrashes when dragging near the top edge of an editable element
3451         https://bugs.webkit.org/show_bug.cgi?id=193364
3452         <rdar://problem/47214117>
3453
3454         Reviewed by Tim Horton.
3455
3456         Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
3457         precise, whereas dragging near the middle of the textarea does.
3458
3459         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3460         (TestWebKitAPI::TEST):
3461
3462 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3463
3464         webkitpy: Support alternate simctl device list output
3465         https://bugs.webkit.org/show_bug.cgi?id=193362
3466         <rdar://problem/47122965>
3467
3468         Reviewed by Lucas Forschler.
3469
3470         * Scripts/webkitpy/xcode/simulated_device.py:
3471         (SimulatedDeviceManager.populate_available_devices):
3472
3473 2019-01-11  Aakash Jain  <aakash_jain@apple.com>
3474
3475         [ews-build] Update macOS queue configurations
3476         https://bugs.webkit.org/show_bug.cgi?id=193365
3477
3478         Reviewed by Lucas Forschler.
3479
3480         * BuildSlaveSupport/ews-build/config.json:
3481
3482 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3483
3484         webkitpy: Incorporate device type into baseline search path
3485         https://bugs.webkit.org/show_bug.cgi?id=193356
3486         <rdar://problem/47215515>
3487
3488         Reviewed by Lucas Forschler.
3489
3490         We need a way to include device type in the baseline search path for iOS to support device specific test expectations.
3491
3492         * Scripts/webkitpy/port/base.py:
3493         (Port.default_baseline_search_path): Allow device type to be passed in.
3494         * Scripts/webkitpy/port/gtk.py:
3495         (GtkPort.default_baseline_search_path): Ignore device type.
3496         * Scripts/webkitpy/port/ios.py:
3497         (IOSPort.default_baseline_search_path): Optionally allow device type to be incorporated into the baseline search path.
3498         (IOSPort.test_expectations_file_position): Update index for the additional device-type specific baseline search path.
3499         * Scripts/webkitpy/port/ios_device_unittest.py:
3500         (IOSDeviceTest):
3501         * Scripts/webkitpy/port/ios_simulator_unittest.py:
3502         (IOSSimulatorTest):
3503         * Scripts/webkitpy/port/mac.py:
3504         (MacPort.default_baseline_search_path): Ignore device type.
3505         * Scripts/webkitpy/port/watch.py:
3506         (WatchPort.default_baseline_search_path): Ditto.
3507         * Scripts/webkitpy/port/win.py:
3508         (WinPort.default_baseline_search_path): Ditto.
3509         (WinCairoPort.default_baseline_search_path): Ditto.
3510         * Scripts/webkitpy/port/wpe.py:
3511         (WPEPort.default_baseline_search_path): Ditto.
3512
3513 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3514
3515         webkitpy: Print abbreviated baseline search path that includes only folders that exist
3516         https://bugs.webkit.org/show_bug.cgi?id=193352
3517         <rdar://problem/47210736>
3518
3519         Reviewed by Lucas Forschler.
3520
3521         * Scripts/webkitpy/layout_tests/views/printing.py:
3522         (Printer.print_config): Print list on only baseline search paths which exist. 
3523         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3524         (Testprinter.test_print_config):
3525
3526 2019-01-11  Joseph Pecoraro  <pecoraro@apple.com>
3527
3528         Cleanup possible WK*Copy/Create leaks in WebKitTestRunner
3529         https://bugs.webkit.org/show_bug.cgi?id=193340
3530
3531         Reviewed by David Kilzer.
3532
3533         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3534         (WTR::InjectedBundle::didReceiveMessageToPage):
3535         Pull the strings out into a WKRetainPtr.
3536
3537         * WebKitTestRunner/WebNotificationProvider.cpp:
3538         (WTR::WebNotificationProvider::closeWebNotification):
3539         Adopt the created value into the WKRetainPtr.
3540
3541         * WebKitTestRunner/mac/TestControllerMac.mm:
3542         (WTR::generateWhitelist):
3543         Immediately adopt a created value to avoid potential mistakes.
3544
3545 2019-01-11  Dominik Infuehr  <dinfuehr@igalia.com>
3546
3547         Enable DFG on ARM/Linux again
3548         https://bugs.webkit.org/show_bug.cgi?id=192496
3549
3550         Reviewed by Yusuke Suzuki.
3551
3552         After changing the bytecode format DFG was disabled on all 32-bit
3553         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
3554         on ARM by default.
3555
3556         * Scripts/run-jsc-stress-tests:
3557
3558 2019-01-11  Timothy Hatcher  <timothy@apple.com>
3559
3560         Unreviewed, fix #ifdef in API test added in r239851.
3561         https://bugs.webkit.org/show_bug.cgi?id=193327
3562         rdar://problem/47093222
3563
3564         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
3565
3566 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3567
3568         Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
3569         https://bugs.webkit.org/show_bug.cgi?id=193109
3570         <rdar://problem/44807048>
3571
3572         Reviewed by Ryosuke Niwa.
3573
3574         Introduce and respect a test option to enable the UndoManager API.
3575
3576         * WebKitTestRunner/TestController.cpp:
3577         (WTR::updateTestOptionsFromTestHeader):
3578         * WebKitTestRunner/TestOptions.h:
3579         (WTR::TestOptions::hasSameInitializationOptions const):
3580         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3581         (WTR::TestController::platformCreateWebView):
3582
3583 2019-01-11  Zalan Bujtas  <zalan@apple.com>
3584
3585         [LFC][BFC][MarginCollapsing] Adjust vertical position when box margin collapses through.
3586         https://bugs.webkit.org/show_bug.cgi?id=193346
3587
3588         Reviewed by Antti Koivisto.
3589
3590         * LayoutReloaded/misc/LFC-passing-tests.txt:
3591
3592 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
3593
3594         Unreviewed, fix typo that breaks dashboard link.
3595
3596         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3597         (WebKitBuildbot):
3598
3599 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
3600
3601         Update macOS queue configurations
3602         https://bugs.webkit.org/show_bug.cgi?id=193329
3603
3604         Reviewed by Alexey Proskuryakov.
3605
3606         * BuildSlaveSupport/build.webkit.org-config/config.json:
3607         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3608         (BubbleQueueServer):
3609         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3610         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3611         (WebKitBuildbot):
3612         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3613         (table.queue-grid tr.platform.macos-sierra img.logo): Deleted.
3614         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3615
3616 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
3617
3618         MiniBrowser should be able to navigate to about:blank
3619         https://bugs.webkit.org/show_bug.cgi?id=193345
3620
3621         Reviewed by Simon Fraser.
3622
3623         * MiniBrowser/mac/BrowserWindowController.m:
3624         (-[BrowserWindowController addProtocolIfNecessary:]):
3625         Don't prepend "http://" to "about:" prefixed URLs like "about:blank".
3626
3627         * MiniBrowser/mac/WK1BrowserWindowController.m:
3628         (-[WK1BrowserWindowController fetch:]):
3629         * MiniBrowser/mac/WK2BrowserWindowController.m:
3630         (-[WK2BrowserWindowController fetch:]):
3631         Clean up the code that uses this to match style.
3632
3633 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
3634
3635         Remove MiniBrowser custom "Process Swap" menu item which does not work
3636         https://bugs.webkit.org/show_bug.cgi?id=193344
3637
3638         Reviewed by Simon Fraser.
3639
3640         There is a menu item under the Experimental menu that does work.
3641
3642         * MiniBrowser/mac/AppDelegate.m:
3643         (defaultConfiguration):
3644         * MiniBrowser/mac/SettingsController.h:
3645         * MiniBrowser/mac/SettingsController.m:
3646         (-[SettingsController _populateMenu]):
3647         (-[SettingsController validateMenuItem:]):
3648         (-[SettingsController processSwapOnNavigationEnabled]): Deleted.
3649         (-[SettingsController toggleProcessSwapOnNavigation:]): Deleted.
3650
3651 2019-01-10  Timothy Hatcher  <timothy@apple.com>
3652
3653         Add WKBundlePage SPI to temporarily force light or dark appearance on a page.
3654         https://bugs.webkit.org/show_bug.cgi?id=193327
3655         rdar://problem/47093222
3656
3657         Reviewed by Tim Horton.
3658
3659         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3660         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: Added.
3661         (TestWebKitAPI::didFinishNavigation):
3662         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
3663         (TestWebKitAPI::TEST):
3664         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm: Added.
3665         (TestWebKitAPI::ForceLightAppearanceInBundleTest::ForceLightAppearanceInBundleTest):
3666         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didCreatePage):
3667         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didReceiveMessage):
3668         * TestWebKitAPI/Tests/WebKit/mac/dark-mode.html: Added.
3669
3670 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
3671
3672         Leak of WKWebProcessPlugInHitTestResult (160 bytes) in com.apple.WebKit.WebContent running layout tests
3673         https://bugs.webkit.org/show_bug.cgi?id=193338
3674         <rdar://problem/46664774>
3675
3676         Reviewed by David Kilzer.
3677
3678         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3679         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
3680
3681 2019-01-10  Commit Queue  <commit-queue@webkit.org>
3682
3683         Unreviewed, rolling out r239825.
3684         https://bugs.webkit.org/show_bug.cgi?id=193330
3685
3686         Broke tests on armv7/linux bots (Requested by guijemont on
3687         #webkit).
3688
3689         Reverted changeset:
3690
3691         "Enable DFG on ARM/Linux again"
3692         https://bugs.webkit.org/show_bug.cgi?id=192496
3693         https://trac.webkit.org/changeset/239825
3694
3695 2019-01-10  Zhifei Fang  <zhifei_fang@apple.com>
3696
3697         Disable the run-jsc-stress-test remote host key check.
3698         https://bugs.webkit.org/show_bug.cgi?id=192988
3699
3700         Reviewed by Alexey Proskuryakov.
3701
3702         * Scripts/run-jsc-stress-tests:
3703
3704 2019-01-10  John Wilander  <wilander@apple.com>
3705
3706         Override the session configuration for cookieAcceptPolicy
3707         https://bugs.webkit.org/show_bug.cgi?id=190925
3708         <rdar://problem/45497382>
3709
3710         Reviewed by Alexey Proskuryakov and Alex Christensen.
3711
3712         Test infrastructure for setting a first-party-only cookie policy.
3713
3714         * DumpRenderTree/TestRunner.cpp:
3715         (setOnlyAcceptFirstPartyCookiesCallback):
3716         (TestRunner::staticFunctions):
3717         * DumpRenderTree/TestRunner.h:
3718         * DumpRenderTree/mac/TestRunnerMac.mm:
3719         (TestRunner::setOnlyAcceptFirstPartyCookies):
3720         * DumpRenderTree/win/TestRunnerWin.cpp:
3721         (TestRunner::setOnlyAcceptFirstPartyCookies):
3722         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3723         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3724         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
3725         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3726         * WebKitTestRunner/TestInvocation.cpp:
3727         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3728
3729 2019-01-09  Matt Rajca  <mrajca@apple.com>
3730
3731         Put per-document autoplay behavior behind runtime website policies quirk instead of a compile time flag
3732         https://bugs.webkit.org/show_bug.cgi?id=193301
3733
3734         Reviewed by Jer Noble.
3735         
3736         Added API tests.
3737
3738         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3739         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3740         (TEST):
3741         * TestWebKitAPI/Tests/WebKitCocoa/autoplaying-multiple-media-elements.html: Added.
3742
3743 2019-01-10  Zalan Bujtas  <zalan@apple.com>
3744
3745         [LFC][BFC][MarginCollapsing] Take collapsed through siblings into account when computing vertical position
3746         https://bugs.webkit.org/show_bug.cgi?id=193310
3747
3748         Reviewed by Antti Koivisto.
3749
3750         * LayoutReloaded/misc/LFC-passing-tests.txt:
3751
3752 2019-01-10  Dominik Infuehr  <dinfuehr@igalia.com>
3753
3754         Enable DFG on ARM/Linux again
3755         https://bugs.webkit.org/show_bug.cgi?id=192496
3756
3757         Reviewed by Yusuke Suzuki.
3758
3759         After changing the bytecode format DFG was disabled on all 32-bit
3760         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
3761         on ARM by default.
3762
3763         * Scripts/run-jsc-stress-tests:
3764
3765 2019-01-09  Fujii Hironori  <Hironori.Fujii@sony.com>
3766
3767         [Win][MiniBrowser] wchar_t strings shouldn't be treated as BSTR
3768         https://bugs.webkit.org/show_bug.cgi?id=193271
3769
3770         Reviewed by Brent Fulgham.
3771
3772         BSTR is a special data structure created by SysAllocString, not a
3773         wchar_t null-terminated string.
3774
3775         * DumpRenderTree/win/TestRunnerWin.cpp:
3776         (TestRunner::setDatabaseQuota): Use L"" instead of "" for _bstr_t.
3777         * MiniBrowser/win/MiniBrowserWebHost.cpp:
3778         (MiniBrowserWebHost::didFinishLoadForFrame): Use _bstr_t to create
3779         BSTR from wide string literals.
3780
3781 2019-01-09  Alexey Proskuryakov  <ap@apple.com>
3782
3783         Tweak wording for build/version_check style checker error
3784         https://bugs.webkit.org/show_bug.cgi?id=193256
3785
3786         Reviewed by Tim Horton.
3787
3788         * Scripts/webkitpy/style/checkers/cpp.py:
3789         (check_os_version_checks):
3790         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3791         (WebKitStyleTest.test_os_version_checks):
3792
3793 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
3794
3795         [ews-build] Add link to bug along with bug title
3796         https://bugs.webkit.org/show_bug.cgi?id=193293
3797
3798         Reviewed by Lucas Forschler.
3799
3800         * BuildSlaveSupport/ews-build/steps.py:
3801         (ValidatePatch._is_bug_closed): Fetch bug title from Bugzilla and add it to the build.
3802         (ConfigureBuild.add_bug_id_url): Deleted.
3803         (ConfigureBuild.getBugURL): Deleted.
3804
3805 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
3806
3807         [ews-build] Use https for ews-build server
3808         https://bugs.webkit.org/show_bug.cgi?id=193193
3809
3810         Reviewed by Lucas Forschler.
3811
3812         * BuildSlaveSupport/ews-build/steps.py:
3813
3814 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
3815
3816         [ews-build] Parse and display number of style failures
3817         https://bugs.webkit.org/show_bug.cgi?id=193280
3818
3819         Reviewed by Lucas Forschler.
3820
3821         * BuildSlaveSupport/ews-build/steps.py:
3822         (CheckStyle): Use TestWithFailureCount as base class.
3823         (CheckStyle.countFailures): Count the number of style failures.
3824
3825 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
3826
3827         [ews-build] use patch_id instead of ewspatchid
3828         https://bugs.webkit.org/show_bug.cgi?id=193235
3829
3830         Reviewed by Lucas Forschler.
3831
3832         * BuildSlaveSupport/ews-build/factories.py: Replaced ewspatchid with patch_id.
3833         * BuildSlaveSupport/ews-build/steps.py: Ditto.
3834         * BuildSlaveSupport/ews-build/steps_unittest.py: Ditto.
3835
3836 2019-01-09  Zalan Bujtas  <zalan@apple.com>
3837
3838         [LFC][BFC][MarginCollapsing] Add support for peculiar cases.
3839         https://bugs.webkit.org/show_bug.cgi?id=192625
3840
3841         Reviewed by Antti Koivisto.
3842
3843         * LayoutReloaded/misc/LFC-passing-tests.txt:
3844
3845 2019-01-09  Michael Catanzaro  <mcatanzaro@igalia.com>
3846
3847         [WPE][GTK] Purge use of g_assert() under TestWebKitAPI
3848         https://bugs.webkit.org/show_bug.cgi?id=192841
3849
3850         Reviewed by Carlos Garcia Campos.
3851
3852         There are separate g_assert_*() macros for use in tests, which we use inconsistently
3853         currently. Use them always. We'll get nicer error messages now when tests fail, and the
3854         assertions will now run during tests even if G_DISABLE_ASSERT is used when building.
3855
3856         Note that the documentation of g_assert() says that it is not to be used when writing tests.
3857
3858         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3859         * TestWebKitAPI/Tests/WebKitGLib/EditorTest.cpp:
3860         (WebKitWebEditorTest::testSelectionChanged):
3861         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
3862         (WebKitFrameTest::testMainFrame):
3863         (WebKitFrameTest::testURI):
3864         (WebKitFrameTest::testJavaScriptContext):
3865         (WebKitFrameTest::testJavaScriptValues):
3866         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
3867         (testWebViewAuthenticationRequest):
3868         (testWebViewAuthenticationLoadCancelled):
3869         (testWebViewAuthenticationFailure):
3870         (testWebViewAuthenticationStorage):
3871         (ProxyAuthenticationTest::ProxyAuthenticationTest):
3872         (testWebViewAuthenticationProxy):
3873         (testWebViewAuthenticationProxyHTTPS):
3874         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
3875         (testAutomationSessionRequestSession):
3876         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
3877         (testBackForwardListNavigation):
3878         (testWebKitWebViewSessionState):
3879         (testWebKitWebViewSessionStateWithFormData):
3880         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
3881         (ConsoleMessageTest::consoleMessageReceivedCallback):
3882         (testWebKitConsoleMessageConsoleAPI):
3883         (testWebKitConsoleMessageJavaScriptException):
3884         (testWebKitConsoleMessageNetworkError):
3885         (testWebKitConsoleMessageSecurityError):
3886         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
3887         (testCookieManagerAcceptPolicy):
3888         (testCookieManagerCookiesChanged):
3889         (testCookieManagerPersistentStorage):
3890         (testCookieManagerPersistentStorageDeleteAll):
3891         (testCookieManagerEphemeral):
3892         * TestWebKitAPI/Tests/WebKitGLib/TestDOMElement.cpp:
3893         (testWebKitDOMElementAutoFill):
3894         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
3895         (downloadLocalFileSuccessfully):
3896         (createFileAtDestination):
3897         (testDownloadOverwriteDestinationDisallowed):
3898         (testDownloadLocalFileError):
3899         (testDownloadRemoteFile):
3900         (testDownloadRemoteFileError):
3901         (testWebViewDownloadURI):
3902         (testPolicyResponseDownload):
3903         (testPolicyResponseDownloadCancel):
3904         (testDownloadMIMEType):
3905         (contextMenuCallback):
3906         (testContextMenuDownloadActions):
3907         (testBlobDownload):
3908         * TestWebKitAPI/Tests/WebKitGLib/TestEditor.cpp:
3909         (testWebKitWebEditorSelectionChanged):
3910         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
3911         (testWebKitFrameMainFrame):
3912         (testWebKitFrameURI):
3913         (testWebKitFrameJavaScriptContext):
3914         (testWebKitFrameJavaScriptValues):
3915         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3916         (LoadStopTrackingTest::loadFailed):
3917         (testWebViewTitle):
3918         (testURIRequestHTTPHeaders):
3919         (testURIRequestHTTPMethod):
3920         (testURIResponseHTTPHeaders):
3921         (testRedirectToDataURI):
3922         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
3923         (testProcessPerWebView):
3924         (testWebProcessLimit):
3925         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
3926         (testWebViewResources):
3927         (testWebResourceLoading):
3928         (testWebResourceSuggestedFilename):
3929         (testWebResourceGetData):
3930         (testWebResourceGetDataError):
3931         (testWebViewResourcesHistoryCache):
3932         (testWebResourceSendRequest):
3933         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
3934         (testSSL):
3935         (testInsecureContent):
3936         (testTLSErrorsPolicy):
3937         (testTLSErrorsRedirect):
3938         (testTLSErrorsHTTPAuth):
3939         (testLoadFailedWithTLSErrors):
3940         (testSubresourceLoadFailedWithTLSErrors):
3941         (httpsServerCallback):
3942         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3943         (testWebViewCreateNavigationData):
3944         (testWebViewJavaScriptDialogs):
3945         (testWebViewWindowProperties):
3946         (testWebViewMouseTarget):
3947         (testWebViewFileChooserRequest):
3948         (testWebViewColorChooserRequest):
3949         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
3950         (testWebExtensionGetTitle):
3951         (testDocumentLoadedSignal):
3952         (testWebKitWebViewProcessCrashed):
3953         (testWebExtensionWindowObjectCleared):
3954         (testWebExtensionIsolatedWorld):
3955         (permissionRequestCallback):
3956         (didAssociateFormControlsCallback):
3957         (testWebExtensionFormControlsAssociated):
3958         (FormSubmissionTest::FormSubmissionTest):
3959         (FormSubmissionTest::testFormSubmissionResult):
3960         (testWebExtensionFormSubmissionSteps):
3961         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
3962         (testNotInitialized):
3963         (testClearDatabase):
3964         (testPrivateBrowsing):
3965         (testGetFavicon):
3966         (testWebViewFavicon):
3967         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
3968         (testFindControllerTextFound):
3969         (testFindControllerTextNotFound):
3970         (testFindControllerMatchCount):
3971         (testFindControllerMaxMatchCount):
3972         (testFindControllerNext):
3973         (testFindControllerPrevious):
3974         (testFindControllerCountedMatches):
3975         (testFindControllerOptions):
3976         (testFindControllerHide):
3977         (testFindControllerInstance):
3978         (testFindControllerGetters):
3979         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp:
3980         (testNavigationPolicy):
3981         (testResponsePolicy):
3982         (testNewWindowPolicy):
3983         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
3984         (testSecurityOriginBasicConstructor):
3985         (testSecurityOriginURIConstructor):
3986         (testSecurityOriginDefaultPort):
3987         (testSecurityOriginFileURI):
3988         (testOpaqueSecurityOrigin):
3989         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3990         (testWebKitSettings):
3991         (testWebKitSettingsNewWithSettings):
3992         (testWebKitSettingsUserAgent):
3993         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
3994         (testWebViewNewWithUserContentManager):
3995         (isStyleSheetInjectedForURLAtPath):
3996         (isScriptInjectedForURLAtPath):
3997         (testUserContentManagerInjectedStyleSheet):
3998         (testUserContentManagerInjectedScript):
3999         (UserScriptMessageTest::scriptMessageReceived):
4000         (UserScriptMessageTest::waitUntilMessageReceived):
4001         (UserScriptMessageTest::runJavaScriptFinished):
4002         (testUserContentManagerScriptMessageReceived):
4003         (testUserContentManagerScriptMessageInWorldReceived):
4004         (testUserContentManagerScriptMessageFromDOMBindings):
4005         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
4006         (testWebContextDefault):
4007         (testWebContextEphemeral):
4008         (testWebContextGetPlugins):
4009         (testWebContextURIScheme):
4010         (testWebContextSpellChecker):
4011         (testWebContextLanguages):
4012         (consoleMessageReceivedCallback):
4013         (testWebContextSecurityFileXHR):
4014         (ProxyTest::ProxyTest):
4015         (testWebContextProxySettings):
4016         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
4017         (testWebViewWebContext):
4018         (testWebViewWebBackend):
4019         (testWebViewEphemeral):
4020         (testWebViewCustomCharset):
4021         (testWebViewSettings):
4022         (testWebViewRunJavaScript):
4023         (testWebViewCanShowMIMEType):
4024         (testWebViewSubmitForm):
4025         (testWebViewSave):
4026         (testWebViewPageVisibility):
4027         (testWebViewSnapshot):
4028         (testWebViewNotification):
4029         (testWebViewNotificationInitialPermissionAllowed):
4030         (testWebViewNotificationInitialPermissionDisallowed):
4031         (testWebViewIsPlayingAudio):
4032         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
4033         (WebsiteDataTest::WebsiteDataTest):
4034         (WebsiteDataTest::remove):
4035         (WebsiteDataTest::clear):
4036         (testWebsiteDataConfiguration):
4037         (testWebsiteDataEphemeral):
4038         (testWebsiteDataCache):
4039         (testWebsiteDataStorage):
4040         (testWebsiteDataDatabases):
4041         (testWebsiteDataAppcache):
4042         (testWebsiteDataCookies):
4043         (testWebsiteDataDeviceIdHashSalt):
4044         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
4045         (emitDocumentLoaded):
4046         (emitURIChanged):
4047         (sendRequestCallback):
4048         (contextMenuCallback):
4049         (consoleMessageSentCallback):
4050         (emitFormControlsAssociated):
4051         (formControlsAssociatedCallback):
4052         (emitFormSubmissionEvent):
4053         (willSubmitFormCallback):
4054         (windowObjectCleared):
4055         (methodCallCallback):
4056         (registerGResource):
4057         (webkit_web_extension_initialize_with_user_data):
4058         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp:
4059         (checkLeaks):
4060         (WebProcessTest::create):
4061         (runTest):
4062         * TestWebKitAPI/Tests/WebKitGtk/AutocleanupsTest.cpp:
4063         (AutocleanupsTest::testWebProcessAutocleanups):
4064         * TestWebKitAPI/Tests/WebKitGtk/DOMClientRectTest.cpp:
4065         (WebKitDOMClientRectTest::testDivBoundingClientRectPosition):
4066         (WebKitDOMClientRectTest::testDivClientRectsPositionAndLength):
4067         * TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp:
4068         (WebKitDOMDOMWindowTest::testSignals):
4069         (WebKitDOMDOMWindowTest::testDispatchEvent):
4070         (WebKitDOMDOMWindowTest::testGetComputedStyle):
4071         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeFilterTest.cpp:
4072         (WebKitDOMNodeFilterTest::testTreeWalker):
4073         (WebKitDOMNodeFilterTest::testNodeIterator):
4074         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeTest.cpp:
4075         (WebKitDOMNodeTest::testHierarchyNavigation):
4076         (WebKitDOMNodeTest::testInsertion):
4077         (WebKitDOMNodeTest::testTagNamesNodeList):
4078         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
4079         (WebKitDOMNodeTest::testDOMCache):
4080         * TestWebKitAPI/Tests/WebKitGtk/DOMXPathNSResolverTest.cpp:
4081         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
4082         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
4083         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
4084         * TestWebKitAPI/Tests/WebKitGtk/TestAutocleanups.cpp:
4085         (testUIProcessAutocleanups):
4086         (testWebProcessAutocleanups):
4087         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
4088         (testContextMenuPopulateMenu):
4089         (testContextMenuDismissed):
4090         * TestWebKitAPI/Tests/WebKitGtk/TestDOMClientRect.cpp:
4091         (testWebKitDOMClientRectDivBoundingClientRectPosition):
4092         (testWebKitDOMClientRectDivClientRectsPositionAndLength):
4093         * TestWebKitAPI/Tests/WebKitGtk/TestDOMDOMWindow.cpp:
4094         (testWebKitDOMDOMWindowSignals):
4095         (testWebKitDOMDOMWindowDispatchEvent):
4096         (testWebKitDOMDOMWindowGetComputedStyle):
4097         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNode.cpp:
4098         (testWebKitDOMNodeHierarchyNavigation):
4099         (testWebKitDOMNodeInsertion):
4100         (testWebKitDOMNodeTagNamesNodeList):
4101         (testWebKitDOMNodeTagNamesHTMLCollection):
4102         (testWebKitDOMObjectCache):
4103         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNodeFilter.cpp:
4104         (testWebKitDOMNodeFilterTreeWalker):
4105         (testWebKitDOMNodeFilterNodeIterator):
4106         * TestWebKitAPI/Tests/WebKitGtk/TestDOMXPathNSResolver.cpp:
4107         (testWebKitDOMXPathNSResolverNative):
4108         (testWebKitDOMXPathNSResolverCustom):
4109         * TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp:
4110         (testInspectorDefault):
4111         (testInspectorManualAttachDetach):
4112         (testInspectorCustomContainerDestroyed):
4113         * TestWebKitAPI/Tests/WebKitGtk/TestInspectorServer.cpp:
4114         (startTestServer):
4115         (testInspectorServerPageList):
4116         * TestWebKitAPI/Tests/WebKitGtk/TestOptionMenu.cpp:
4117         (OptionMenuTest::showOptionMenuCallback):
4118         (OptionMenuTest::menuCloseCallback):
4119         (OptionMenuTest::close):
4120         (OptionMenuTest::activateItem):
4121         (OptionMenuTest::selectItem):
4122         (testOptionMenuSimple):
4123         (testOptionMenuGroups):
4124         (testOptionMenuActivate):
4125         (testOptionMenuSelect):
4126         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
4127         (testPrintOperationPrintSettings):
4128         (webViewPrintCallback):
4129         (testPrintOperationPrint):
4130         (testPrintCustomWidget):
4131         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
4132         (checkAtspiAccessible):
4133         (testAtspiBasicHierarchy):
4134         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitVersion.cpp:
4135         (testWebKitCheckVersion):
4136         * TestWebKitAPI/Tests/WebKitGtk/TestWebViewEditor.cpp:
4137         (testWebViewEditorCutCopyPasteNonEditable):
4138         (testWebViewEditorCutCopyPasteEditable):
4139         (testWebViewEditorSelectAllNonEditable):
4140         (testWebViewEditorSelectAllEditable):
4141         (loadContentsAndTryToCutSelection):
4142         (testWebViewEditorNonEditable):
4143         (testWebViewEditorEditable):
4144         (testWebViewEditorEditorStateTypingAttributes):
4145         (testWebViewEditorInsertImage):
4146         (testWebViewEditorCreateLink):
4147         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
4148         (loadChangedCallback):
4149         (loadFailedCallback):
4150         (loadFailedWithTLSErrorsCallback):
4151         (LoadTrackingTest::LoadTrackingTest):
4152         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
4153         (registerGResource):
4154         (removeNonEmptyDirectory):
4155         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
4156         (Test::adoptView):
4157         (Test::~Test):
4158         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
4159         (WebKitTestBus::getOrCreateConnection):
4160         (WebKitTestBus::createProxy):
4161         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
4162         (WebKitTestServer::getWebSocketURIForPath const):
4163         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
4164         (WebViewTest::initializeWebView):
4165         (WebViewTest::loadURI):
4166         (WebViewTest::loadHtml):
4167         (WebViewTest::loadPlainText):
4168         (WebViewTest::loadBytes):
4169         (WebViewTest::loadRequest):
4170         (WebViewTest::loadAlternateHTML):
4171         (WebViewTest::goBack):
4172         (WebViewTest::goForward):
4173         (WebViewTest::goToBackForwardListItem):
4174         (resourceGetDataCallback):
4175         (WebViewTest::mainResourceData):
4176         (WebViewTest::javascriptResultToCString):
4177         (WebViewTest::javascriptResultToNumber):
4178         (WebViewTest::javascriptResultToBoolean):
4179         (WebViewTest::javascriptResultIsNull):
4180         (WebViewTest::javascriptResultIsUndefined):
4181         (onSnapshotReady):
4182         (WebViewTest::runWebProcessTest):
4183         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp:
4184         (WebViewTest::platformInitializeWebView):
4185         (WebViewTest::showInWindow):
4186         (WebViewTest::showInWindowAndWaitUntilMapped):
4187         (WebViewTest::mouseMoveTo):
4188         (WebViewTest::emitPopupMenuSignal):
4189         (WebViewTest::keyStroke):
4190         (WebViewTest::doMouseButtonEvent):
4191
4192 2019-01-09  Philippe Normand  <pnormand@igalia.com>
4193
4194         [WPE] API tests can't run in flatpak environment
4195         https://bugs.webkit.org/show_bug.cgi?id=193242
4196
4197         Reviewed by Michael Catanzaro.
4198
4199         * Scripts/run-wpe-tests: Add --wpe to arguments passed to
4200         flatpakutils so that it knows which port it's dealing with.
4201         * glib/common.py: Remove build_dir globals so that subsequent
4202         calls actually take args into account.
4203         (library_build_path):
4204         (binary_build_path):
4205
4206 2019-01-08  Dean Jackson  <dino@apple.com>
4207
4208         Blob references for System Previews don't get a correct file extension
4209         https://bugs.webkit.org/show_bug.cgi?id=193268
4210         <rdar://problem/47133037>
4211
4212         Reviewed by Tim Horton.
4213
4214         New test that a Blob download of a USDZ file gets named correctly.
4215
4216         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4217         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
4218         (-[BlobWithUSDZExtensionDownloadDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
4219         (-[BlobWithUSDZExtensionDownloadDelegate _downloadDidFinish:]):
4220         (TEST):
4221         * TestWebKitAPI/Tests/WebKitCocoa/SystemPreviewBlobNaming.html: Added.
4222
4223 2019-01-08  Jiewen Tan  <jiewen_tan@apple.com>
4224
4225         [WebAuthN] Support U2F HID Authenticators on macOS
4226         https://bugs.webkit.org/show_bug.cgi?id=191535
4227         <rdar://problem/47102027>
4228
4229         Reviewed by Brent Fulgham.
4230
4231         This patch:
4232         1) adds support for U2F mocking mechanism;
4233         2) updates tests to reflect U2fCommandConstructor changes.
4234
4235         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
4236         (TestWebKitAPI::TEST):
4237         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
4238         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4239         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
4240
4241 2019-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
4242
4243         [iOS] Dispatch a synthetic mousedown event prior to starting drags
4244         https://bugs.webkit.org/show_bug.cgi?id=193229
4245         <rdar://problem/46717097>
4246
4247         Reviewed by Tim Horton.
4248
4249         Add a cross-platform drag and drop test to verify that calling `preventDefault()` on the mousedown event
4250         prevents a drag from starting.
4251
4252         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
4253         * TestWebKitAPI/Tests/WebKitCocoa/link-and-target-div.html:
4254
4255         Tweak this test to make it robust when dragging the link to the target element multiple times in a single test.
4256
4257 2019-01-08  Zhifei Fang  <zhifei_fang@apple.com>
4258   
4259         Layout test will generate a perf metric file to results dir.
4260         https://bugs.webkit.org/show_bug.cgi?id=192030
4261         <rdar://problem/32779516>
4262
4263         Reviewed by Aakash Jain.
4264
4265         Layout test running time will be collected to a perf metric file.
4266         For now, instead of outputing running time of all tests (which is huge),
4267         we aggregate them by test directories which are at most two level deep. 
4268
4269         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4270         (Manager._end_test_run):
4271         (Manager._output_perf_metrics):
4272         (Manager._print_expectation_line_for_test):
4273         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
4274         (add_test_perf_metric):
4275         (test_perf_metrics):
4276         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
4277         (JSONGeneratorTest.test_test_timings_trie):
4278         (JSONGeneratorTest):
4279         (JSONGeneratorTest.test_test_perf_metrics):
4280         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
4281         (RebaselineTest.test_reset_results):
4282         (RebaselineTest.test_missing_results):
4283         (RebaselineTest.test_new_baseline):
4284
4285 2019-01-08  Patrick Griffis  <pgriffis@igalia.com>
4286
4287         [WPE][GTK] Add php-json to install-dependencies
4288         https://bugs.webkit.org/show_bug.cgi?id=193233
4289
4290         Reviewed by Michael Catanzaro.
4291
4292         * gtk/install-dependencies:
4293         * wpe/install-dependencies:
4294
4295 2019-01-08  Chris Dumez  <cdumez@apple.com>
4296
4297         Regression(PSON-r239182): Blank view when navigating back and forth between google.com and stack overflow
4298         https://bugs.webkit.org/show_bug.cgi?id=193224
4299         <rdar://problem/47097726>
4300
4301         Reviewed by Alex Christensen.
4302
4303         Add API test coverage.
4304
4305         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4306
4307 2019-01-07  David Kilzer  <ddkilzer@apple.com>
4308
4309         Leak of ScrollCompletionCallbackData (16 bytes) in com.apple.WebKit.WebContent running WebKit layout tests
4310         <https://webkit.org/b/193222>
4311         <rdar://problem/46862309>
4312
4313         Reviewed by Joseph Pecoraro.
4314
4315         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
4316         (WTR::executeCallback): Fix camel case of variable name.
4317         (WTR::EventSendingController::callAfterScrollingCompletes): If
4318         WKBundlePageRegisterScrollOperationCompletionCallback() returns
4319         false, make sure to release the ScrollCompletionCallbackData
4320         object.  This fixes the leak.
4321
4322 2019-01-07  Fujii Hironori  <Hironori.Fujii@sony.com>
4323
4324         [Win] EWS: wincairo-ews cannot apply a patch with *.png
4325         https://bugs.webkit.org/show_bug.cgi?id=193044
4326
4327         Reviewed by Daniel Bates.
4328
4329         WinCairo EWS bots are using Windows Perl. Binary files should be
4330         opened as binary mode.
4331
4332         * Scripts/svn-apply:
4333         (handleGitBinaryChange): Use 'binmode' for binary file handles.
4334
4335 2019-01-07  Don Olmstead  <don.olmstead@sony.com>
4336
4337         [CMake] Add ENABLE_CSS_TYPED_OM option
4338         https://bugs.webkit.org/show_bug.cgi?id=193216
4339
4340         Reviewed by Michael Catanzaro.
4341
4342         * Scripts/webkitperl/FeatureList.pm:
4343
4344 2019-01-07  David Kilzer  <ddkilzer@apple.com>
4345
4346         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
4347         <https://webkit.org/b/193056>
4348