3005fc5a2ca309066c709287417b9e549cf722b8
[WebKit-https.git] / Tools / ChangeLog
1 2018-11-14  Chris Dumez  <cdumez@apple.com>
2
3         WebKit.WKHTTPCookieStoreWithoutProcessPool API test is failing with process prewarming is enabled
4         https://bugs.webkit.org/show_bug.cgi?id=191624
5
6         Reviewed by Alex Christensen.
7
8         Add API test coverage.
9
10         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
11         (runWKHTTPCookieStoreWithoutProcessPool):
12         (TEST):
13
14 2018-11-13  Jiewen Tan  <jiewen_tan@apple.com>
15
16         [WebAuthN] Support CTAP HID authenticators on macOS
17         https://bugs.webkit.org/show_bug.cgi?id=188623
18         <rdar://problem/43353777>
19
20         Reviewed by Brent Fulgham and Chris Dumez.
21
22         This patch adds support for the mock testing and entitlements to allow minibrowser to talk
23         to hid devices.
24
25         * MiniBrowser/MiniBrowser.entitlements:
26         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
27         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
28
29 2018-11-13  Ryosuke Niwa  <rniwa@webkit.org>
30
31         WebKit.GeolocationTransitionToLowAccuracy API crashes when enabling PSON
32         https://bugs.webkit.org/show_bug.cgi?id=191616
33
34         Reviewed by Chris Dumez.
35
36         The crash was caused by WKView in autorelease pool invoking stopUpdatingCallback after
37         GeolocationTransitionToLowAccuracyStateTracker in the stack had been destroyed,
38         resulting in the use-after-free.
39
40         Made the tests more robust by clearing geolocation provider before exiting each test
41         since we can't really prevent WKView from entering an autorelease pool.
42
43         Also made WebKit.GeolocationTransitionToLowAccuracy wait for the success callback
44         instead of simply the end of the navigation so that the test would continue to work
45         even if a web content process was created for the second web view (lowAccuracyWebView)
46
47         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
48         (TestWebKitAPI::setupGeolocationProvider): Moved "*" to match the WebKit coding style guideline.
49         (TestWebKitAPI::clearGeolocationProvider): Added.
50         (TestWebKitAPI::runJavaScriptAlert): Added.
51         (TestWebKitAPI::didFinishNavigation): Deleted.
52         * TestWebKitAPI/Tests/WebKit/geolocationWatchPosition.html:
53
54 2018-11-13  Chris Dumez  <cdumez@apple.com>
55
56         WKProcessPool.InitialWarmedProcessUsed API is failing with PSON enabled
57         https://bugs.webkit.org/show_bug.cgi?id=191618
58
59         Reviewed by Ryosuke Niwa.
60
61         Update API test to explicitly disable automatic process prewarning since it is testing
62         manual prewarming.
63
64         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
65         (TEST):
66
67 2018-11-13  Chris Dumez  <cdumez@apple.com>
68
69         Several Service Worker API tests are failing when enabling PSON
70         https://bugs.webkit.org/show_bug.cgi?id=191619
71
72         Reviewed by Youenn Fablet.
73
74         Update tests to use _webProcessCountIgnoringPrewarmed instead of _webProcessCount so that they are
75         not impacted by process prewarming.
76
77         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
78
79 2018-11-13  Wenson Hsieh  <wenson_hsieh@apple.com>
80
81         [iOS] Do not show selection UI for editable elements with opacity near zero
82         https://bugs.webkit.org/show_bug.cgi?id=191442
83         <rdar://problem/45958625>
84
85         Reviewed by Simon Fraser.
86
87         Add a couple of new testing helpers to UIScriptController.
88
89         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
90         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
91         (WTR::UIScriptController::textSelectionRangeRects const):
92         (WTR::UIScriptController::selectionCaretViewRect const):
93         (WTR::UIScriptController::selectionRangeViewRects const):
94         * TestRunnerShared/UIScriptContext/UIScriptController.h:
95         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
96         (WTR::UIScriptController::textSelectionRangeRects const):
97
98         Rename `selectionRangeViewRects` to `textSelectionRangeRects`. This allows us to draw a distinction between
99         `textSelectionRangeRects`/`textSelectionCaretRect`, which retrieve information about selection rects known
100         to the text interaction assistant, and `selectionCaretViewRect`/`selectionRangeViewRects`, which retrieve the
101         actual frames of the selection views used to draw overlaid selection UI. This difference is important in the
102         new layout tests added in this patch, which only suppress caret rendering (i.e. selection views remain hidden).
103
104         Also, drive-by fix a leaked `NSMutableArray`.
105
106         (WTR::UIScriptController::selectionStartGrabberViewRect const):
107         (WTR::UIScriptController::selectionEndGrabberViewRect const):
108         (WTR::UIScriptController::selectionCaretViewRect const):
109         (WTR::UIScriptController::selectionRangeViewRects const):
110
111         Testing helpers to grab the frames of caret and selection views, in WKContentView's coordinate space. These
112         rects are also clamped to WKContentView bounds.
113
114 2018-11-13  Daniel Bates  <dabates@apple.com>
115
116         Consolidate WebKit UIKitSPI.h and UIKitTestSPI.h
117         https://bugs.webkit.org/show_bug.cgi?id=173341
118         <rdar://problem/32752890>
119
120         Reviewed by Simon Fraser.
121
122         There is little value to making a distinction between forward declarations
123         of UIKit SPI needed in the WebKit layer and just for testing. Moreover,
124         the contents of these two headers can conflict with each other following
125         r218275 as DumpRenderTree includes both headers. Instead we should remove
126         UIKitTestSPI.h and have WebKitTestRunner include the WebKit variant, UIKitSPI.h.
127
128         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
129         * DumpRenderTree/mac/DumpRenderTree.mm:
130         * TestRunnerShared/spi/UIKitTestSPI.h: Removed.
131         * WebKitTestRunner/Configurations/Base.xcconfig:
132         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
133         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
134         * WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:
135         * WebKitTestRunner/ios/HIDEventGenerator.h:
136         * WebKitTestRunner/ios/HIDEventGenerator.mm:
137         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
138         * WebKitTestRunner/ios/TestControllerIOS.mm:
139         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
140         * WebKitTestRunner/ios/mainIOS.mm:
141
142 2018-11-13  Takashi Komori  <Takashi.Komori@sony.com>
143
144         Remove WebKitTestRunnerLib's build warnings.
145         https://bugs.webkit.org/show_bug.cgi?id=191580
146
147         Reviewed by Fujii Hironori.
148
149         Include cmakeconfig.h in precompiled header.
150
151         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
152
153 2018-11-12  Darshan Kadu  <darsh7807@gmail.com>
154
155         Implement Cache API support for WPE/GTK
156         https://bugs.webkit.org/show_bug.cgi?id=178316
157
158         Reviewed by Michael Catanzaro.
159
160         Called WKWebsiteDataStoreSetCacheStoragePerOriginQuota function to set the cache limit to 400 * 1200
161         on all the platforms in TestController.cpp. Also, removed the setCacheStoragePerOriginQuota call from TestControllerCocoa.mm
162
163         * WebKitTestRunner/TestController.cpp:
164         (WTR::TestController::generatePageConfiguration):
165         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
166         (WTR::initializeWebViewConfiguration):
167
168 2018-11-12  Christopher Reid  <chris.reid@sony.com>
169
170         [Curl] Reject entire cookie if the domain fails a tailmatch.
171         https://bugs.webkit.org/show_bug.cgi?id=191406
172
173         Reviewed by Youenn Fablet.
174
175         Added unittests for Curl cookie implementation.
176
177         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
178         (TestWebKitAPI::Curl::CurlCookies::RejectTailmatchFailureDomain):
179
180 2018-11-12  Alex Christensen  <achristensen@webkit.org>
181
182         [iOS] Implement safe browsing in WebKit
183         https://bugs.webkit.org/show_bug.cgi?id=191441
184
185         Reviewed by Tim Horton.
186
187         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
188         (checkTitleAndClick):
189         (TEST):
190
191 2018-11-12  Basuke Suzuki  <basuke.suzuki@sony.com>
192
193         [Curl] Add API Test for Curl cookie backend.
194         https://bugs.webkit.org/show_bug.cgi?id=191493
195
196         Reviewed by Youenn Fablet.
197
198         Add unit test to TestWebCore.
199
200         * TestWebKitAPI/PlatformWin.cmake:
201         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp: Added.
202
203 2018-11-12  Tim Horton  <timothy_horton@apple.com>
204
205         Make it possible to edit images inline
206         https://bugs.webkit.org/show_bug.cgi?id=191352
207         <rdar://problem/30107985>
208
209         Reviewed by Dean Jackson.
210
211         * WebKitTestRunner/TestController.cpp:
212         (WTR::updateTestOptionsFromTestHeader):
213         * WebKitTestRunner/TestOptions.h:
214         (WTR::TestOptions::hasSameInitializationOptions const):
215         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
216         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
217         (WTR::TestController::platformCreateWebView):
218         Add a test option to enable editable images.
219
220         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
221         (WTR::UIScriptController::drawSquareInEditableImage):
222         (WTR::UIScriptController::numberOfStrokesInEditableImage):
223         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
224         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
225         (WTR::UIScriptController::drawSquareInEditableImage):
226         (WTR::UIScriptController::numberOfStrokesInEditableImage):
227         * TestRunnerShared/UIScriptContext/UIScriptController.h:
228         * TestRunnerShared/spi/PencilKitTestSPI.h: Added.
229         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
230         (WTR::findEditableImageCanvas):
231         (WTR::UIScriptController::drawSquareInEditableImage):
232         (WTR::UIScriptController::numberOfStrokesInEditableImage):
233         Add the ability to draw on a PKCanvasView that is a subview of the WKWebView,
234         and also to retrieve the number of strokes currently on the PKCanvasView.
235         Currently this just takes the first canvas; we might need to make it
236         take an identifier or something in the future if we need tests with multiple
237         canvases. The indirect testing mechanism is required because PKCanvasView
238         can currently not actually paint its strokes in the Simulator.
239
240 2018-11-12  Ryan Haddad  <ryanhaddad@apple.com>
241
242         [MediaStream] Screen capture should be an experimental feature on OSX only
243         https://bugs.webkit.org/show_bug.cgi?id=191552
244
245         Unreviewed test gardening.
246
247         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm: Only run these tests on macOS.
248
249 2018-11-12  Don Olmstead  <don.olmstead@sony.com>
250
251         Shipped PNGs include bad profiles: iCCP: known incorrect sRGB profile
252         https://bugs.webkit.org/show_bug.cgi?id=189230
253         <rdar://problem/44050379>
254
255         Reviewed by Joseph Pecoraro.
256
257         Runs all png images through zopflipng. This results in a smaller file
258         size and takes care of this issue as a byproduct.
259
260         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-green.png:
261         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-red.png:
262         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/ElCapitan.png:
263         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/ElCapitan@2x.png:
264         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK.png:
265         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK@2x.png:
266         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra.png:
267         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra@2x.png:
268         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10.png:
269         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10@2x.png:
270         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10Simulator.png:
271         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10Simulator@2x.png:
272         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11.png:
273         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11@2x.png:
274         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11Simulator.png:
275         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11Simulator@2x.png:
276         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12.png:
277         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12@2x.png:
278         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12Simulator.png:
279         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12Simulator@2x.png:
280         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9.png:
281         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9@2x.png:
282         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator.png:
283         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator@2x.png:
284         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice.png:
285         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice@2x.png:
286         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSSimulator.png:
287         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSSimulator@2x.png:
288         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks.png:
289         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks@2x.png:
290         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mojave.png:
291         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mojave@2x.png:
292         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png:
293         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png:
294         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing.png:
295         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing@2x.png:
296         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
297         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
298         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE.png:
299         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE@2x.png:
300         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows10.png:
301         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows10@2x.png:
302         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7.png:
303         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7@2x.png:
304         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8.png:
305         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8@2x.png:
306         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP.png:
307         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP@2x.png:
308         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite.png:
309         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite@2x.png:
310
311 2018-11-12  Tim Horton  <timothy_horton@apple.com>
312
313         Modernize WebKit Tools Xcode projects for localization's sake
314         https://bugs.webkit.org/show_bug.cgi?id=191495
315
316         Reviewed by Alexey Proskuryakov.
317
318         * ContentExtensionTester/ContentExtensionTester.xcodeproj/project.pbxproj:
319         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
320         * EditingHistory/EditingHistory.xcodeproj/project.pbxproj:
321         * FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj:
322         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
323         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
324         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
325         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
326         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
327         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
328         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
329         * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj:
330         These are less important because they're not localized, but since
331         I made the style checker complain, it now complains any time anyone
332         touches any of these projects... so upgrade them.
333
334 2018-11-12  Jonathan Bedard  <jbedard@apple.com>
335
336         webkitpy: Check for specific process instead of using data migrator
337         https://bugs.webkit.org/show_bug.cgi?id=191551
338         <rdar://problem/45993156>
339
340         Rubber-stamped by Aakash Jain.
341
342         It's possible for the data migrator process to be stuck, but for a simulator to be
343         usable. Use device-specific processes to detect when a device is usable.
344
345         * Scripts/webkitpy/xcode/simulated_device.py:
346         (SimulatedDeviceManager._wait_until_device_is_usable):
347         (SimulatedDeviceManager):
348         (SimulatedDeviceManager.initialize_devices): Explicitly wait until a device is usable
349         since this implies that a device is booted.
350         (SimulatedDeviceManager.swap): Ditto.
351         (SimulatedDevice.is_usable): Check that a device is booted and that a device-specific
352         process indicating the device is usable can be found.
353         (SimulatedDeviceManager.wait_until_data_migration_is_done): Deleted.
354         * Scripts/webkitpy/xcode/simulated_device_unittest.py: Update simctl_json so that
355         it triggers the logic in is_usable()
356
357 2018-11-12  Takashi Komori  <Takashi.Komori@sony.com>
358
359         Resurrect WebKitTestRunner for Windows port
360         https://bugs.webkit.org/show_bug.cgi?id=189257
361
362         Reviewed by Fujii Hironori.
363
364         Implement WebKitTestRunner for WinCairo.
365
366         * PlatformWin.cmake:
367         * Scripts/build-webkittestrunner:
368         * WebKitTestRunner/CMakeLists.txt:
369         * WebKitTestRunner/EventSenderProxy.h:
370         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
371         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
372         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
373         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
374         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
375         (WTR::rangeToStr):
376         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
377         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
378         (WTR::TestRunner::TestRunner):
379         * WebKitTestRunner/InjectedBundle/TestRunner.h:
380         * WebKitTestRunner/InjectedBundle/win/AccessibilityControllerWin.cpp: Added.
381         (WTR::AccessibilityController::resetToConsistentState):
382         (WTR::AccessibilityController::accessibleElementById):
383         (WTR::AccessibilityController::platformName):
384         (WTR::AccessibilityController::rootElement):
385         (WTR::AccessibilityController::focusedElement):
386         (WTR::AccessibilityController::addNotificationListener):
387         (WTR::AccessibilityController::removeNotificationListener):
388         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp: Added.
389         (WTR::AccessibilityUIElement::AccessibilityUIElement):
390         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
391         (WTR::AccessibilityUIElement::isEqual):
392         (WTR::AccessibilityUIElement::getChildren):
393         (WTR::AccessibilityUIElement::getChildrenWithRange):
394         (WTR::AccessibilityUIElement::childrenCount):
395         (WTR::AccessibilityUIElement::elementAtPoint):
396         (WTR::AccessibilityUIElement::indexOfChild):
397         (WTR::AccessibilityUIElement::childAtIndex):
398         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
399         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
400         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
401         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
402         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
403         (WTR::AccessibilityUIElement::rowAtIndex):
404         (WTR::AccessibilityUIElement::selectedChildAtIndex const):
405         (WTR::AccessibilityUIElement::selectedChildrenCount const):
406         (WTR::AccessibilityUIElement::selectedRowAtIndex):
407         (WTR::AccessibilityUIElement::titleUIElement):
408         (WTR::AccessibilityUIElement::parentElement):
409         (WTR::AccessibilityUIElement::disclosedByRow):
410         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
411         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
412         (WTR::AccessibilityUIElement::attributesOfChildren):
413         (WTR::AccessibilityUIElement::allAttributes):
414         (WTR::AccessibilityUIElement::stringAttributeValue):
415         (WTR::AccessibilityUIElement::numberAttributeValue):
416         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue const):
417         (WTR::AccessibilityUIElement::rowHeaders const):
418         (WTR::AccessibilityUIElement::columnHeaders const):
419         (WTR::AccessibilityUIElement::uiElementAttributeValue const):
420         (WTR::AccessibilityUIElement::boolAttributeValue):
421         (WTR::AccessibilityUIElement::isAttributeSettable):
422         (WTR::AccessibilityUIElement::isAttributeSupported):
423         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
424         (WTR::AccessibilityUIElement::role):
425         (WTR::AccessibilityUIElement::subrole):
426         (WTR::AccessibilityUIElement::roleDescription):
427         (WTR::AccessibilityUIElement::computedRoleString):
428         (WTR::AccessibilityUIElement::title):
429         (WTR::AccessibilityUIElement::description):
430         (WTR::AccessibilityUIElement::orientation const):
431         (WTR::AccessibilityUIElement::stringValue):
432         (WTR::AccessibilityUIElement::language):
433         (WTR::AccessibilityUIElement::helpText const):
434         (WTR::AccessibilityUIElement::x):
435         (WTR::AccessibilityUIElement::y):
436         (WTR::AccessibilityUIElement::width):
437         (WTR::AccessibilityUIElement::height):
438         (WTR::AccessibilityUIElement::clickPointX):
439         (WTR::AccessibilityUIElement::clickPointY):
440         (WTR::AccessibilityUIElement::intValue const):
441         (WTR::AccessibilityUIElement::minValue):
442         (WTR::AccessibilityUIElement::maxValue):
443         (WTR::AccessibilityUIElement::valueDescription):
444         (WTR::AccessibilityUIElement::insertionPointLineNumber):
445         (WTR::AccessibilityUIElement::isPressActionSupported):
446         (WTR::AccessibilityUIElement::isIncrementActionSupported):
447         (WTR::AccessibilityUIElement::isDecrementActionSupported):
448         (WTR::AccessibilityUIElement::isEnabled):
449         (WTR::AccessibilityUIElement::isRequired const):
450         (WTR::AccessibilityUIElement::isFocused const):
451         (WTR::AccessibilityUIElement::isSelected const):
452         (WTR::AccessibilityUIElement::isSelectedOptionActive const):
453         (WTR::AccessibilityUIElement::isExpanded const):
454         (WTR::AccessibilityUIElement::isChecked const):
455         (WTR::AccessibilityUIElement::isIndeterminate const):
456         (WTR::AccessibilityUIElement::hierarchicalLevel const):
457         (WTR::AccessibilityUIElement::speakAs):
458         (WTR::AccessibilityUIElement::ariaIsGrabbed const):
459         (WTR::AccessibilityUIElement::ariaDropEffects const):
460         (WTR::AccessibilityUIElement::lineForIndex):
461         (WTR::AccessibilityUIElement::rangeForLine):
462         (WTR::AccessibilityUIElement::rangeForPosition):
463         (WTR::AccessibilityUIElement::boundsForRange):
464         (WTR::AccessibilityUIElement::stringForRange):
465         (WTR::AccessibilityUIElement::attributedStringForRange):
466         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
467         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
468         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
469         (WTR::AccessibilityUIElement::selectTextWithCriteria):
470         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
471         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
472         (WTR::AccessibilityUIElement::attributesOfColumns):
473         (WTR::AccessibilityUIElement::attributesOfRows):
474         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
475         (WTR::AccessibilityUIElement::attributesOfHeader):
476         (WTR::AccessibilityUIElement::rowCount):
477         (WTR::AccessibilityUIElement::columnCount):
478         (WTR::AccessibilityUIElement::indexInTable):
479         (WTR::AccessibilityUIElement::rowIndexRange):
480         (WTR::AccessibilityUIElement::columnIndexRange):
481         (WTR::AccessibilityUIElement::cellForColumnAndRow):
482         (WTR::AccessibilityUIElement::horizontalScrollbar const):
483         (WTR::AccessibilityUIElement::verticalScrollbar const):
484         (WTR::AccessibilityUIElement::selectedTextRange):
485         (WTR::AccessibilityUIElement::setSelectedTextRange):
486         (WTR::AccessibilityUIElement::increment):
487         (WTR::AccessibilityUIElement::decrement):
488         (WTR::AccessibilityUIElement::showMenu):
489         (WTR::AccessibilityUIElement::press):
490         (WTR::AccessibilityUIElement::setSelectedChild const):
491         (WTR::AccessibilityUIElement::setSelectedChildAtIndex const):
492         (WTR::AccessibilityUIElement::removeSelectionAtIndex const):
493         (WTR::AccessibilityUIElement::clearSelectedChildren const):
494         (WTR::AccessibilityUIElement::accessibilityValue const):
495         (WTR::AccessibilityUIElement::documentEncoding):
496         (WTR::AccessibilityUIElement::documentURI):
497         (WTR::AccessibilityUIElement::url):
498         (WTR::AccessibilityUIElement::addNotificationListener):
499         (WTR::AccessibilityUIElement::removeNotificationListener):
500         (WTR::AccessibilityUIElement::isFocusable const):
501         (WTR::AccessibilityUIElement::isSelectable const):
502         (WTR::AccessibilityUIElement::isMultiSelectable const):
503         (WTR::AccessibilityUIElement::isVisible const):
504         (WTR::AccessibilityUIElement::isOffScreen const):
505         (WTR::AccessibilityUIElement::isCollapsed const):
506         (WTR::AccessibilityUIElement::isIgnored const):
507         (WTR::AccessibilityUIElement::isSingleLine const):
508         (WTR::AccessibilityUIElement::isMultiLine const):
509         (WTR::AccessibilityUIElement::hasPopup const):
510         (WTR::AccessibilityUIElement::takeFocus):
511         (WTR::AccessibilityUIElement::takeSelection):
512         (WTR::AccessibilityUIElement::addSelection):
513         (WTR::AccessibilityUIElement::removeSelection):
514         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
515         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
516         (WTR::AccessibilityUIElement::textMarkerRangeLength):
517         (WTR::AccessibilityUIElement::previousTextMarker):
518         (WTR::AccessibilityUIElement::nextTextMarker):
519         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
520         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
521         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
522         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
523         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
524         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
525         (WTR::AccessibilityUIElement::textMarkerForPoint):
526         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
527         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRange):
528         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions):
529         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
530         (WTR::AccessibilityUIElement::indexForTextMarker):
531         (WTR::AccessibilityUIElement::isTextMarkerValid):
532         (WTR::AccessibilityUIElement::textMarkerForIndex):
533         (WTR::AccessibilityUIElement::startTextMarker):
534         (WTR::AccessibilityUIElement::endTextMarker):
535         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
536         (WTR::AccessibilityUIElement::scrollToMakeVisible):
537         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
538         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
539         (WTR::AccessibilityUIElement::supportedActions const):
540         (WTR::AccessibilityUIElement::pathDescription const):
541         (WTR::AccessibilityUIElement::mathPostscriptsDescription const):
542         (WTR::AccessibilityUIElement::mathPrescriptsDescription const):
543         (WTR::AccessibilityUIElement::classList const):
544         (WTR::AccessibilityUIElement::characterAtOffset):
545         (WTR::AccessibilityUIElement::wordAtOffset):
546         (WTR::AccessibilityUIElement::lineAtOffset):
547         (WTR::AccessibilityUIElement::sentenceAtOffset):
548         * WebKitTestRunner/InjectedBundle/win/ActivateFontsWin.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.
549         (WTR::activateFonts):
550         (WTR::installFakeHelvetica):
551         (WTR::uninstallFakeHelvetica):
552         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.
553         (WTR::InjectedBundle::platformInitialize):
554         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.cpp: Added.
555         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.
556         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.
557         (WTR::TestRunner::pathToLocalResource):
558         (WTR::TestRunner::inspectorTestStubURL):
559         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
560         (WTR::TestRunner::platformInitialize):
561         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
562         (WTR::TestRunner::installFakeHelvetica):
563         * WebKitTestRunner/PlatformWebView.h:
564         * WebKitTestRunner/PlatformWin.cmake: Added.
565         * WebKitTestRunner/TestController.cpp:
566         (WTR::TestController::resetStateToConsistentValues):
567         (WTR::createTestURL):
568         * WebKitTestRunner/TestInvocation.cpp:
569         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
570         * WebKitTestRunner/win/EventSenderProxyWin.cpp: Added.
571         (WTR::EventSenderProxy::EventSenderProxy):
572         (WTR::EventSenderProxy::~EventSenderProxy):
573         (WTR::EventSenderProxy::mouseDown):
574         (WTR::EventSenderProxy::mouseUp):
575         (WTR::EventSenderProxy::mouseMoveTo):
576         (WTR::EventSenderProxy::mouseScrollBy):
577         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
578         (WTR::EventSenderProxy::continuousMouseScrollBy):
579         (WTR::EventSenderProxy::leapForward):
580         (WTR::EventSenderProxy::keyDown):
581         * WebKitTestRunner/win/PlatformWebViewWin.cpp: Added.
582         (WTR::registerWindowClass):
583         (WTR::PlatformWebView::PlatformWebView):
584         (WTR::PlatformWebView::~PlatformWebView):
585         (WTR::PlatformWebView::resizeTo):
586         (WTR::PlatformWebView::page):
587         (WTR::PlatformWebView::focus):
588         (WTR::PlatformWebView::windowFrame):
589         (WTR::PlatformWebView::setWindowFrame):
590         (WTR::PlatformWebView::didInitializeClients):
591         (WTR::PlatformWebView::addChromeInputField):
592         (WTR::PlatformWebView::removeChromeInputField):
593         (WTR::PlatformWebView::addToWindow):
594         (WTR::PlatformWebView::removeFromWindow):
595         (WTR::PlatformWebView::setWindowIsKey):
596         (WTR::PlatformWebView::makeWebViewFirstResponder):
597         (WTR::generateCairoSurfaceFromBitmap):
598         (WTR::PlatformWebView::windowSnapshotImage):
599         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
600         (WTR::PlatformWebView::setNavigationGesturesEnabled):
601         (WTR::PlatformWebView::forceWindowFramesChanged):
602         (WTR::PlatformWebView::drawsBackground const):
603         (WTR::PlatformWebView::setDrawsBackground):
604         * WebKitTestRunner/win/TestControllerWin.cpp: Added.
605         (WTR::exceptionFilter):
606         (WTR::runRunLoopUntil):
607         (WTR::TestController::notifyDone):
608         (WTR::TestController::setHidden):
609         (WTR::TestController::platformInitialize):
610         (WTR::TestController::platformPreferences):
611         (WTR::TestController::platformDestroy):
612         (WTR::toWK):
613         (WTR::TestController::platformInitializeContext):
614         (WTR::TestController::platformRunUntil):
615         (WTR::TestController::platformDidCommitLoadForFrame):
616         (WTR::TestController::initializeInjectedBundlePath):
617         (WTR::TestController::initializeTestPluginDirectory):
618         (WTR::TestController::runModal):
619         (WTR::TestController::platformContext):
620         (WTR::TestController::platformLibraryPathForTesting):
621         (WTR::TestController::platformConfigureViewForTest):
622         (WTR::TestController::platformResetPreferencesToConsistentValues):
623         (WTR::TestController::updatePlatformSpecificTestOptionsForTest const):
624         * WebKitTestRunner/win/WebKitTestRunnerPrefix.cpp: Added.
625         * WebKitTestRunner/win/main.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.
626         (dllLauncherEntryPoint):
627
628 2018-11-12  Alicia Boya García  <aboya@igalia.com>
629
630         [MSE][GStreamer] Introduce AbortableTaskQueue
631         https://bugs.webkit.org/show_bug.cgi?id=190902
632
633         Reviewed by Xabier Rodriguez-Calvar.
634
635         Tests for AbortableTaskQueue are included.
636
637         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
638         * TestWebKitAPI/PlatformGTK.cmake:
639         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp: Added.
640         (TestWebKitAPI::TEST):
641         (TestWebKitAPI::FancyResponse::FancyResponse):
642         (TestWebKitAPI::FancyResponse::operator=):
643         (TestWebKitAPI::DeterministicScheduler::DeterministicScheduler):
644         (TestWebKitAPI::DeterministicScheduler::ThreadContext::ThreadContext):
645         (TestWebKitAPI::DeterministicScheduler::ThreadContext::waitMyTurn):
646         (TestWebKitAPI::DeterministicScheduler::ThreadContext::yieldToThread):
647
648 2018-11-11  Fujii Hironori  <Hironori.Fujii@sony.com>
649
650         run-bindings-tests is timing out in some WinCairo bots
651         https://bugs.webkit.org/show_bug.cgi?id=191348
652
653         Reviewed by Alex Christensen.
654
655         BuildBot kills run-bindings-tests if it outputs nothing for 20
656         minutes. run-bindings-tests runs very slowly in WinCairo Docker,
657         and it takes more than 30 minutes to finish. And, Windows Python
658         buffers the progress output.
659
660         * Scripts/webkitpy/bindings/main.py:
661         (BindingsTests.detect_changes): Call sys.stdout.flush() after the
662         test case result is output.
663
664 2018-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
665
666         Implement a new edit command to change the enclosing list type
667         https://bugs.webkit.org/show_bug.cgi?id=191487
668         <rdar://problem/45955922>
669
670         Reviewed by Ryosuke Niwa.
671
672         Add a new API test to verify that `-[WKWebView _changeListType:]` is hooked up to the corresponding editing
673         command in WebCore. See the new layout test for a test that exercises more nuanced corner cases.
674
675         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
676         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
677         (-[TestWKWebView setPosition:offset:]):
678         (-[TestWKWebView setBase:baseOffset:extent:extentOffset:]):
679         (TestWebKitAPI::webViewForEditActionTestingWithPageNamed):
680         (TestWebKitAPI::TEST):
681         * TestWebKitAPI/Tests/WebKitCocoa/editable-nested-lists.html: Added.
682
683 2018-11-11  Dan Bernstein  <mitz@apple.com>
684
685         ProcessPoolConfiguration::copy() doesn’t copy m_customWebContentServiceBundleIdentifier
686         https://bugs.webkit.org/show_bug.cgi?id=191514
687
688         Reviewed by Geoffrey Garen.
689
690         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
691         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm: Added.
692         (TEST):
693
694 2018-11-11  Benjamin Poulain  <benjamin@webkit.org>
695
696         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
697         https://bugs.webkit.org/show_bug.cgi?id=191492
698
699         Reviewed by Alex Christensen.
700
701         Update file name.
702
703         * DumpRenderTree/mac/DumpRenderTree.mm:
704         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
705         * WebKitTestRunner/mac/TestControllerMac.mm:
706
707 2018-11-10  Benjamin Poulain  <benjamin@webkit.org>
708
709         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
710         https://bugs.webkit.org/show_bug.cgi?id=191492
711
712         Reviewed by Alex Christensen.
713
714         * DumpRenderTree/mac/DumpRenderTree.mm:
715         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
716         * WebKitTestRunner/mac/TestControllerMac.mm:
717
718 2018-11-10  Ryan Haddad  <ryanhaddad@apple.com>
719
720         Unreviewed, rolling out r238065.
721
722         Breaks internal builds.
723
724         Reverted changeset:
725
726         "Make it possible to edit images inline"
727         https://bugs.webkit.org/show_bug.cgi?id=191352
728         https://trac.webkit.org/changeset/238065
729
730 2018-11-10  Michael Catanzaro  <mcatanzaro@igalia.com>
731
732         [WPE][GTK] API test /webkit/WebKitSettings/webkit-settings is failing
733         https://bugs.webkit.org/show_bug.cgi?id=191221
734
735         Unreviewed, fix a typo from the previous patch. After disabling the setting, we should test
736         that it is disabled, but we're testing that it is enabled, because I failed to update this
737         line.
738
739         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
740         (testWebKitSettings):
741
742 2018-11-10  Tim Horton  <timothy_horton@apple.com>
743
744         Make it possible to edit images inline
745         https://bugs.webkit.org/show_bug.cgi?id=191352
746         <rdar://problem/30107985>
747
748         Reviewed by Dean Jackson.
749
750         * WebKitTestRunner/TestController.cpp:
751         (WTR::updateTestOptionsFromTestHeader):
752         * WebKitTestRunner/TestOptions.h:
753         (WTR::TestOptions::hasSameInitializationOptions const):
754         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
755         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
756         (WTR::TestController::platformCreateWebView):
757         Add a test option to enable editable images.
758
759         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
760         (WTR::UIScriptController::drawSquareInEditableImage):
761         (WTR::UIScriptController::numberOfStrokesInEditableImage):
762         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
763         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
764         (WTR::UIScriptController::drawSquareInEditableImage):
765         (WTR::UIScriptController::numberOfStrokesInEditableImage):
766         * TestRunnerShared/UIScriptContext/UIScriptController.h:
767         * TestRunnerShared/spi/PencilKitTestSPI.h: Added.
768         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
769         (WTR::findEditableImageCanvas):
770         (WTR::UIScriptController::drawSquareInEditableImage):
771         (WTR::UIScriptController::numberOfStrokesInEditableImage):
772         Add the ability to draw on a PKCanvasView that is a subview of the WKWebView,
773         and also to retrieve the number of strokes currently on the PKCanvasView.
774         Currently this just takes the first canvas; we might need to make it
775         take an identifier or something in the future if we need tests with multiple
776         canvases. The indirect testing mechanism is required because PKCanvasView
777         can currently not actually paint its strokes in the Simulator.
778
779 2018-11-09  Chris Dumez  <cdumez@apple.com>
780
781         Suspended page persists even after back/forward list item is gone
782         https://bugs.webkit.org/show_bug.cgi?id=191488
783         <rdar://problem/45953006>
784
785         Reviewed by Geoffrey Garen.
786
787         Add API test coverage.
788
789         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
790
791 2018-11-09  Wenson Hsieh  <wenson_hsieh@apple.com>
792
793         [Cocoa] Implement SPI on WKWebView to increase and decrease list levels
794         https://bugs.webkit.org/show_bug.cgi?id=191471
795         <rdar://problem/45952472>
796
797         Reviewed by Tim Horton.
798
799         Add an API test to ensure that list levels can be incremented and decremented via WKWebView SPI.
800
801         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
802         (TestWebKitAPI::webViewForEditActionTesting):
803         (TestWebKitAPI::TEST):
804
805 2018-11-09  Basuke Suzuki  <basuke.suzuki@sony.com>
806
807         [Curl][WebKit] Implement Proxy configuration API.
808         https://bugs.webkit.org/show_bug.cgi?id=189053
809
810         Reviewed by Youenn Fablet.
811
812         Added Proxy Settings dialog to call newly added API.
813
814         * MiniBrowser/win/BrowserWindow.h:
815         * MiniBrowser/win/Common.cpp:
816         (askProxySettings):
817         (askCredential):
818         (authDialogProc): Deleted.
819         * MiniBrowser/win/Common.h:
820         * MiniBrowser/win/DialogHelper.h: Added.
821         (Dialog::run):
822         (Dialog::doalogProc):
823         (Dialog::handle):
824         (Dialog::setup):
825         (Dialog::update):
826         (Dialog::validate):
827         (Dialog::updateOkButton):
828         (Dialog::command):
829         (Dialog::ok):
830         (Dialog::cancel):
831         (Dialog::close):
832         (Dialog::hDlg):
833         (Dialog::item):
834         (Dialog::setEnabled):
835         (Dialog::setText):
836         (Dialog::getText):
837         (Dialog::getTextLength):
838         (Dialog::RadioGroup::RadioGroup):
839         (Dialog::RadioGroup::set):
840         (Dialog::RadioGroup::get):
841         (Dialog::radioGroup):
842         * MiniBrowser/win/MainWindow.cpp:
843         (MainWindow::WndProc):
844         * MiniBrowser/win/MiniBrowserLib.rc:
845         * MiniBrowser/win/MiniBrowserLibResource.h:
846         * MiniBrowser/win/WebKitBrowserWindow.cpp:
847         (createWKURL):
848         (WebKitBrowserWindow::WebKitBrowserWindow):
849         (WebKitBrowserWindow::updateProxySettings):
850         (WebKitBrowserWindow::loadURL):
851         (WebKitBrowserWindow::loadHTMLString):
852         (WebKitBrowserWindow::openProxySettings):
853         * MiniBrowser/win/WebKitBrowserWindow.h:
854         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
855         (WebKitLegacyBrowserWindow::openProxySettings):
856         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
857
858 2018-11-09  Wenson Hsieh  <wenson_hsieh@apple.com>
859
860         [Cocoa] Introduce WKWebView SPI to insert nested ordered and unordered lists
861         https://bugs.webkit.org/show_bug.cgi?id=191410
862         <rdar://problem/45898610>
863
864         Reviewed by Dean Jackson.
865
866         Move WKWebViewEditActions from iOS to WebKitCocoa, and enable the relevant WKWebViewEditActions tests on macOS.
867         Additionally, add new API tests to verify that `-_pasteAsQuotation:` and `-_insertNested(Un)OrderedList:` are
868         hooked up to their respective editing commands.
869
870         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
871         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm: Renamed from Tools/TestWebKitAPI/Tests/ios/WKWebViewEditActions.mm.
872         (-[TestWKWebView querySelectorExists:]):
873         (-[TestWKWebView insertString:]):
874
875         Add a helper method to insert a piece of text. This abstracts platform differences between iOS and macOS, by
876         invoking the WKWebView directly on macOS and calling on the content view on iOS.
877
878         (TestWebKitAPI::webViewForEditActionTesting):
879         (TestWebKitAPI::TEST):
880
881 2018-11-09  Philippe Normand  <pnormand@igalia.com>
882
883         [Flatpak] Refactoring and drive-by fixes
884         https://bugs.webkit.org/show_bug.cgi?id=191421
885
886         Reviewed by Michael Catanzaro.
887
888         * Scripts/webkitdirs.pm:
889         (inFlatpakSandbox): Flatpak now has a /.flatpak-info file when in
890         the sandbox, so rely on this.
891         * flatpak/flatpakutils.py:
892         (expand_manifest): Pass explicit keywords to load_manifest() and
893         remove unused local variable.
894         (WebkitFlatpak.clean_args): Move hard-coded sdk/runtime infos to the manifest file.
895         (WebkitFlatpak.run_in_sandbox): Add support for extra environment variables.
896         (WebkitFlatpak.setup_dev_env): Stop build at final app. Refactor
897         build_type handling a bit.
898         * flatpak/org.webkit.CommonModules.yaml: Added.
899         * flatpak/org.webkit.WPE.yaml: wpebackend upstream was renamed to libwpe.
900         * flatpak/org.webkit.WebKit.yaml: Move common dependencies
901         declaration to CommonModules, so it can be reused later when we
902         add support for building extra libraries depending on WPE.
903
904 2018-11-08  Said Abou-Hallawa  <sabouhallawa@apple.com>
905
906 onal supported image formats
907         https://bugs.webkit.org/show_bug.cgi?id=190454
908
909         Reviewed by Simon Fraser.
910
911         Test opening a TGA image in WebView which is not allowed by default. The
912         TGA format will be allowed through WKWebViewConfiguration.
913
914         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
915         * TestWebKitAPI/Tests/WebKitCocoa/100x100-red.tga: Added.
916         * TestWebKitAPI/Tests/WebKitCocoa/400x400-green.png: Added.
917         * TestWebKitAPI/Tests/WebKitCocoa/AdditionalSupportedImageTypes.mm: Added.
918         (runTest):
919         (TEST):
920
921 2018-11-08  Jiewen Tan  <jiewen_tan@apple.com>
922
923         Unreviewed, a proper build fix for r237983
924
925         Don't include header PublicKeyCredential.h in CtapResponseTest.cpp.
926
927         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
928         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/CtapRequestTest.cpp.
929         (TestWebKitAPI::TEST):
930         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/CtapResponseTest.cpp.
931         (TestWebKitAPI::getTestCorruptedSignResponse):
932         (TestWebKitAPI::getTestCredentialRawIdBytes):
933         (TestWebKitAPI::convertToVector):
934         (TestWebKitAPI::TEST):
935
936 2018-11-08  Keith Rollin  <krollin@apple.com>
937
938         Create .xcfilelist files
939         https://bugs.webkit.org/show_bug.cgi?id=191324
940         <rdar://problem/45852819>
941
942         Reviewed by Alex Christensen.
943
944         As part of preparing for enabling XCBuild, create and use .xcfilelist
945         files. These files are using during Run Script build phases in an
946         Xcode project. If a Run Script build phase produces new files that are
947         used later as inputs to subsequent build phases, XCBuild needs to know
948         about these files. These files can be either specified in an "output
949         files" section of the Run Script phase editor, or in .xcfilelist files
950         that are associated with the Run Script build phase.
951
952         This patch takes the second approach. It consists of three sets of changes:
953
954         - Modify the DerivedSources.make files to have a
955           'print_all_generated_files" target that produces a list of the files
956           they create.
957
958         - Create a shell script that produces .xcfilelist files from the
959           output of the previous step, as well as for the files created in the
960           Generate Unified Sources build steps.
961
962         - Add the new .xcfilelist files to the associated projects.
963
964         Note that, with these changes, the Xcode workspace and projects can no
965         longer be fully loaded into Xcode 9. Xcode will attempt to load the
966         projects that have .xcfilelist files associated with them, but will
967         fail and display a placeholder for those projects instead. It's
968         expected that all developers are using Xcode 10 by now and that not
969         being able to load into Xcode 9 is not a practical issue. Keep in mind
970         that this is strictly an IDE issue, and that the projects can still be
971         built with `xcodebuild`.
972
973         Also note that the shell script that creates the .xcfilelist files can
974         also be used to verify that the set of files that's currently checked
975         in is up-to-date. This checking can be used as part of a check-in hook
976         or part of check-webkit-style to sooner catch cases where the
977         .xcfilelist files need to be regenerated.
978
979         * DumpRenderTree/DerivedSources.make:
980         * DumpRenderTree/DerivedSources.xcfilelist: Added.
981         * Scripts/generate-xcfilelists: Added.
982         * WebKitTestRunner/DerivedSources.make:
983         * WebKitTestRunner/DerivedSources.xcfilelist: Added.
984
985 2018-11-08  Jiewen Tan  <jiewen_tan@apple.com>
986
987         Unreviewed, a quick build fix for r237983
988
989         Temporarily make CtapRequestTest.cpp/CtapResponseTest.cpp to mac only to avoid iOS build failures.
990
991         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
992         * TestWebKitAPI/Tests/WebCore/mac/CtapRequestTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp.
993         (TestWebKitAPI::TEST):
994         * TestWebKitAPI/Tests/WebCore/mac/CtapResponseTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp.
995         (TestWebKitAPI::getTestCorruptedSignResponse):
996         (TestWebKitAPI::getTestCredentialRawIdBytes):
997         (TestWebKitAPI::convertToVector):
998         (TestWebKitAPI::TEST):
999
1000 2018-11-05  Ryan Haddad  <ryanhaddad@apple.com>
1001
1002         Fix steps_unittest.py failures related to recent Win10/Win7 changes
1003         https://bugs.webkit.org/show_bug.cgi?id=191290
1004
1005         Reviewed by Alexey Proskuryakov.
1006
1007         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update expected results.
1008
1009 2018-11-08  Dean Jackson  <dino@apple.com>
1010
1011         Add a String literal that returns a String
1012         https://bugs.webkit.org/show_bug.cgi?id=191425
1013         <rdar://problem/45914556>
1014
1015         Reviewed by Sam Weinig.
1016
1017         Test _str.
1018
1019         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1020         (TestWebKitAPI::TEST):
1021
1022 2018-11-08  Jonathan Bedard  <jbedard@apple.com>
1023
1024         webkitpy: Generalize trailing SDK specifier (Part 2)
1025         https://bugs.webkit.org/show_bug.cgi?id=191275
1026         <rdar://problem/45703660>
1027
1028         Rubber-stamped by Aakash Jain.
1029
1030         Re-landing this change, configuration issues have been resolved.
1031
1032         * Scripts/webkitpy/port/ios_device.py:
1033         (IOSDevicePort): Use normalized SDK.
1034         * Scripts/webkitpy/port/ios_simulator.py:
1035         (IOSSimulatorPort): Use normalized SDK.
1036         (IOSSimulatorPort._build_driver_flags): Use platform SDK in build driver flags.
1037
1038 2018-11-08  Jiewen Tan  <jiewen_tan@apple.com>
1039
1040         [WebAuthN] Import CTAP device request/response converters from Chromium
1041         https://bugs.webkit.org/show_bug.cgi?id=190784
1042         <rdar://problem/45460333>
1043
1044         Reviewed by Brent Fulgham.
1045
1046         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1047         * TestWebKitAPI/Tests/WebCore/CBORValueTest.cpp:
1048         (TestWebKitAPI::TEST):
1049         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp: Added.
1050         (TestWebKitAPI::TEST):
1051         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp: Added.
1052         (TestWebKitAPI::getTestCorruptedSignResponse):
1053         (TestWebKitAPI::getTestCredentialRawIdBytes):
1054         (TestWebKitAPI::convertToVector):
1055         (TestWebKitAPI::TEST):
1056         * TestWebKitAPI/Tests/WebCore/FidoTestData.h: Added.
1057
1058 2018-11-07  Caio Lima  <ticaiolima@gmail.com>
1059
1060         [BigInt] Add support to BigInt into ValueAdd
1061         https://bugs.webkit.org/show_bug.cgi?id=186177
1062
1063         Reviewed by Keith Miller.
1064
1065         * Scripts/run-jsc-benchmarks:
1066
1067 2018-11-07  Sihui Liu  <sihui_liu@apple.com>
1068
1069         RELEASE_ASSERT(!m_hardClosedForUserDelete) fails in WebCore::IDBServer::UniqueIDBDatabase::invokeOperationAndTransactionTimer
1070         https://bugs.webkit.org/show_bug.cgi?id=191326
1071         <rdar://problem/45769269>
1072
1073         Reviewed by Geoffrey Garen.
1074
1075         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1076         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.html: Added.
1077         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm: Added.
1078         (-[IndexedDBUserDeleteMessageHandler userContentController:didReceiveScriptMessage:]):
1079         (TEST):
1080
1081 2018-11-07  Daniel Bates  <dabates@apple.com>
1082
1083         Override +[UIKeyboard isInHardwareKeyboardMode] in WebKitTestRunner and DumpRenderTree
1084         https://bugs.webkit.org/show_bug.cgi?id=190141
1085
1086         Reviewed by Darin Adler.
1087
1088         Override +[UIKeyboard isInHardwareKeyboardMode] to always return NO so as to make test
1089         runs deterministic regardless of whether a hardware keyboard is attached.
1090
1091         * DumpRenderTree/mac/DumpRenderTree.mm:
1092         (overrideIsInHardwareKeyboardMode): Added.
1093         (prepareConsistentTestingEnvironment):
1094         * TestRunnerShared/spi/UIKitTestSPI.h: Forward declare SPI.
1095         * WebKitTestRunner/ios/TestControllerIOS.mm:
1096         (overrideIsInHardwareKeyboardMode): Added.
1097         (WTR::TestController::platformInitialize):
1098
1099 2018-11-07  Jonathan Bedard  <jbedard@apple.com>
1100
1101         Unreviewed, rolling out r237913.
1102
1103         Breaks running tests on Mac without iOS SDK installed
1104
1105         Reverted changeset:
1106
1107         "webkitpy: Generalize trailing SDK specifier (Part 2)"
1108         https://bugs.webkit.org/show_bug.cgi?id=191275
1109         https://trac.webkit.org/changeset/237913
1110
1111 2018-11-07  Zamiul Haque  <zhaque@apple.com>
1112
1113         Force a gregorian calendar to show for credit card expiration date inputs
1114         (autocomplete='cc-exp'*) regardless of default system settings.
1115         https://bugs.webkit.org/show_bug.cgi?id=191096
1116         rdar://problem/42640256
1117
1118         Reviewed by Tim Horton.
1119
1120         Implemented simulateForeignDefaultCalendar and calendarType to be used
1121         for changing the default calendar returned by the system (ie. [NSCalendar
1122         currentCalendar]) and getting the calendar type identifier of a presented date
1123         picker.
1124
1125         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1126         (WTR::UIScriptController::isShowingDataListSuggestions const):
1127         (WTR::UIScriptController::calendarType const):
1128         (WTR::UIScriptController::setDefaultCalendarType):
1129         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1130         (WTR::UIScriptController::calendarType const):
1131         (WTR::UIScriptController::setDefaultCalendarType):
1132         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1133         (WTR::UIScriptController::selectionEndGrabberViewRect const):
1134         (WTR::UIScriptController::calendarType const): Deleted.
1135         * WebKitTestRunner/TestController.cpp:
1136         * WebKitTestRunner/TestController.h:
1137         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1138         (WTR::UIScriptController::calendarType const):
1139         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1140         (WTR::swizzledCalendar):
1141         (WTR::TestController::getOverriddenCalendarIdentifier const):
1142         (WTR::TestController::setDefaultCalendarType):
1143         (WTR::TestController::cocoaResetStateToConsistentValues):
1144         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1145         (WTR::UIScriptController::selectionEndGrabberViewRect const):
1146         (WTR::UIScriptController::calendarType const): Deleted.
1147
1148 2018-11-06  Jonathan Bedard  <jbedard@apple.com>
1149
1150         webkitpy: Boot a single worker for custom devices
1151         https://bugs.webkit.org/show_bug.cgi?id=191312
1152         <rdar://problem/45848717>
1153
1154         Rubber-stamped by Aakash Jain.
1155
1156         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1157         (Manager.run): Custom devices only run a hand-full of tests. Booting multiple
1158         simulators is expensive and unneeded for these tests.
1159         * Scripts/webkitpy/port/ios.py:
1160         (IOSPort. child_processes): No reason to memoize this call, and it prevents
1161         overriding the number of child processes when booting custom devices.
1162
1163 2018-11-06  Jonathan Bedard  <jbedard@apple.com>
1164
1165         webkitpy: Generalize trailing SDK specifier (Part 2)
1166         https://bugs.webkit.org/show_bug.cgi?id=191275
1167         <rdar://problem/45703660>
1168
1169         Reviewed by Aakash Jain.
1170
1171         * Scripts/webkitpy/port/ios_device.py:
1172         (IOSDevicePort): Use normalized SDK.
1173         * Scripts/webkitpy/port/ios_simulator.py:
1174         (IOSSimulatorPort): Use normalized SDK.
1175         (IOSSimulatorPort._build_driver_flags): Use platform SDK in build driver flags.
1176
1177 2018-11-06  Justin Fan  <justin_fan@apple.com>
1178
1179         [WebGPU] Experimental prototype for WebGPURenderPipeline and WebGPUSwapChain
1180         https://bugs.webkit.org/show_bug.cgi?id=191291
1181
1182         Reviewed by Myles Maxfield.
1183
1184         Properly disable WEBGPU on all non-Metal platforms for now.
1185
1186         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1187
1188 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
1189
1190         [ews-app] Add URL configuration for OpenSource EWS Django app
1191         https://bugs.webkit.org/show_bug.cgi?id=191132
1192
1193         Rubber-stamped by Lucas Forschler.
1194
1195         * BuildSlaveSupport/ews-app/ews-app/urls.py: Added entry for ews.urls.
1196         * BuildSlaveSupport/ews-app/ews/urls.py: Added.
1197
1198 2018-11-06  Youenn Fablet  <youenn@apple.com>
1199
1200         Make mDNS ICE Candidate an experimental flag again
1201         https://bugs.webkit.org/show_bug.cgi?id=191262
1202
1203         Reviewed by Dean Jackson.
1204
1205         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1206         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1207         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
1208         (WTR::TestRunner::setMDNSICECandidatesEnabled): Deleted.
1209         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1210
1211 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
1212
1213         [ews-app] Add views for OpenSource EWS Django app
1214         https://bugs.webkit.org/show_bug.cgi?id=191131
1215
1216         Rubber-stamped by Lucas Forschler.
1217
1218         * BuildSlaveSupport/ews-app/ews/views/index.py: Added.
1219         * BuildSlaveSupport/ews-app/ews/views/patch.py:
1220         * BuildSlaveSupport/ews-app/ews/views/results.py: Added.
1221         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Added.
1222
1223 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
1224
1225         [ews-app] Add models for OpenSource EWS Django app
1226         https://bugs.webkit.org/show_bug.cgi?id=191123
1227
1228         Reviewed by Lucas Forschler.
1229
1230         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
1231         * BuildSlaveSupport/ews-app/ews/models/buildermappings.py: Added.
1232         * BuildSlaveSupport/ews-app/ews/models/builds.py: Added.
1233         * BuildSlaveSupport/ews-app/ews/models/patch.py:
1234         * BuildSlaveSupport/ews-app/ews/models/steps.py: Added.
1235
1236 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
1237
1238         [ews-app] Fix Invalid HTTP_HOST header
1239         https://bugs.webkit.org/show_bug.cgi?id=191325
1240
1241         Reviewed by Lucas Forschler.
1242
1243         Changing ALLOWED_HOSTS to * as the landing page should be publicly accessible.
1244
1245         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1246
1247 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
1248
1249         [ews-app] Rename EWS_app to ews-app - part 2
1250         https://bugs.webkit.org/show_bug.cgi?id=191317
1251
1252         Reviewed by Lucas Forschler.
1253
1254         * BuildSlaveSupport/ews-app/EWS_app: Removed.
1255         * BuildSlaveSupport/ews-app/ews-app: Moved from BuildSlaveSupport/ews-app/EWS_app.
1256         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1257         * BuildSlaveSupport/ews-app/ews-app/urls.py:
1258         * BuildSlaveSupport/ews-app/ews-app/wsgi.py:
1259         * BuildSlaveSupport/ews-app/manage.py:
1260
1261 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
1262
1263         [ews-app] Rename EWS_app to ews-app - part 1
1264         https://bugs.webkit.org/show_bug.cgi?id=191317
1265
1266         Reviewed by Lucas Forschler.
1267
1268         * BuildSlaveSupport/EWS_app: Removed.
1269         * BuildSlaveSupport/ews-app: Moved from BuildSlaveSupport/EWS_app.
1270
1271 2018-11-06  Myles C. Maxfield  <mmaxfield@apple.com>
1272
1273         Spelling dots are drawn in the wrong place
1274         https://bugs.webkit.org/show_bug.cgi?id=190764
1275
1276         Reviewed by Dean Jackson.
1277
1278         Previously, it was impossible for WebKitTestRunner to draw spelling dots. This patch adds support for a header
1279         at the top of test files, of the form <!-- webkit-test-runner [ spellCheckingDots=true ] --> which will cause
1280         dots to be drawn.
1281
1282         * WebKitTestRunner/TestController.cpp:
1283         (WTR::TestController::resetStateToConsistentValues):
1284         (WTR::updateTestOptionsFromTestHeader):
1285         (WTR::TestController::platformResetStateToConsistentValues):
1286         * WebKitTestRunner/TestController.h:
1287         * WebKitTestRunner/TestOptions.h:
1288         (WTR::TestOptions::hasSameInitializationOptions const):
1289         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1290         (WTR::TestController::cocoaResetStateToConsistentValues):
1291         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1292         * WebKitTestRunner/ios/TestControllerIOS.mm:
1293         (WTR::TestController::platformResetStateToConsistentValues):
1294         * WebKitTestRunner/mac/TestControllerMac.mm:
1295         (WTR::TestController::platformResetStateToConsistentValues):
1296
1297 2018-11-06  Don Olmstead  <don.olmstead@sony.com>
1298
1299         Feature flags not present for Visual Studio when using build-webkit
1300         https://bugs.webkit.org/show_bug.cgi?id=191288
1301
1302         Reviewed by Fujii Hironori.
1303
1304         Passes feature flags to Visual studio builds within build-webkit.
1305         Removes cmakeBasedPortArguments as it is no longer in use.
1306
1307         * Scripts/build-jsc:
1308         * Scripts/build-webkit:
1309         * Scripts/webkitdirs.pm:
1310         (cmakeBasedPortArguments): Deleted.
1311
1312 2018-11-06  Per Arne Vollan  <pvollan@apple.com>
1313
1314         REGRESSION (r230523): Caps lock indicator not shown in password field
1315         https://bugs.webkit.org/show_bug.cgi?id=190056
1316
1317         Reviewed by Ryosuke Niwa.
1318
1319         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1320         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1321         (WTR::TestRunner::toggleCapsLock):
1322         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1323         * WebKitTestRunner/TestController.h:
1324         * WebKitTestRunner/TestInvocation.cpp:
1325         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1326         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1327         (WTR::TestController::toggleCapsLock):
1328
1329 2018-11-06  Sihui Liu  <sihui_liu@apple.com>
1330
1331         IndexedDB: WAL file keeps growing
1332         https://bugs.webkit.org/show_bug.cgi?id=191294
1333         <rdar://problem/41333493>
1334
1335         Reviewed by Chris Dumez.
1336
1337         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1338         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize-1.html: Added.
1339         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize-2.html: Added.
1340         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm: Added.
1341         (-[IndexedDBFileSizeMessageHandler userContentController:didReceiveScriptMessage:]):
1342         (TEST):
1343
1344 2018-11-06  Alex Christensen  <achristensen@webkit.org>
1345
1346         Fix tests after r237863
1347         https://bugs.webkit.org/show_bug.cgi?id=191315
1348
1349         Reviewed by Chris Dumez.
1350
1351         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1352         With the timing change of r237863, the WKWebView progressed further than before when loading main.html so it completed before main2.html.
1353         This test was meant to test that main2.html does eventually load, and it doesn't matter if main.html loads before it.  I updated the test
1354         to verify that main2.html eventually loads, making this test less timing dependent.
1355
1356 2018-11-06  Ryan Haddad  <ryanhaddad@apple.com>
1357
1358         Unreviewed, rolling out r237834.
1359
1360         Tests for this change crash on iOS Simulator
1361
1362         Reverted changeset:
1363
1364         "Spelling dots are drawn in the wrong place"
1365         https://bugs.webkit.org/show_bug.cgi?id=190764
1366         https://trac.webkit.org/changeset/237834
1367
1368 2018-11-05  Alex Christensen  <achristensen@webkit.org>
1369
1370         [Mac] Implement safe browsing in WebKit
1371         https://bugs.webkit.org/show_bug.cgi?id=188871
1372
1373         Reviewed by Tim Horton.
1374
1375         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1376         (-[SafeBrowsingNavigationDelegate webView:didCommitNavigation:]):
1377         (+[TestServiceLookupResult resultWithProvider:phishing:malware:unwantedSoftware:]):
1378         (-[TestLookupContext lookUpURL:completionHandler:]):
1379         (simpleURL):
1380         (safeBrowsingView):
1381         (TEST):
1382         (-[SafeBrowsingNavigationDelegate webView:didFinishNavigation:]): Deleted.
1383         (+[TestServiceLookupResult resultWithProvider:phishing:malware:unwantedSoftware:knownToBeUnsafe:]): Deleted.
1384         (-[TestServiceLookupResult isKnownToBeUnsafe]): Deleted.
1385         * TestWebKitAPI/Utilities.h:
1386
1387 2018-11-05  Jonathan Bedard  <jbedard@apple.com>
1388
1389         webkitpy: Generalize trailing SDK specifier (Part 1)
1390         https://bugs.webkit.org/show_bug.cgi?id=191275
1391         <rdar://problem/45703660>
1392
1393         Reviewed by Lucas Forschler.
1394
1395         * Scripts/webkitpy/common/system/platforminfo.py:
1396         (PlatformInfo.available_sdks): List all installed SDKs with version numbers stripped out.
1397         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
1398         (TestPlatformInfo):
1399         (TestPlatformInfo.test_available_sdks):
1400
1401 2018-11-05  Myles C. Maxfield  <mmaxfield@apple.com>
1402
1403         Spelling dots are drawn in the wrong place
1404         https://bugs.webkit.org/show_bug.cgi?id=190764
1405
1406         Reviewed by Dean Jackson.
1407
1408         Previously, it was impossible for WebKitTestRunner to draw spelling dots. This patch adds support for a header
1409         at the top of test files, of the form <!-- webkit-test-runner [ spellCheckingDots=true ] --> which will cause
1410         dots to be drawn.
1411
1412         * WebKitTestRunner/TestController.cpp:
1413         (WTR::TestController::resetStateToConsistentValues):
1414         (WTR::updateTestOptionsFromTestHeader):
1415         (WTR::TestController::platformResetStateToConsistentValues):
1416         * WebKitTestRunner/TestController.h:
1417         * WebKitTestRunner/TestOptions.h:
1418         (WTR::TestOptions::hasSameInitializationOptions const):
1419         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1420         (WTR::TestController::cocoaResetStateToConsistentValues):
1421         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1422         * WebKitTestRunner/ios/TestControllerIOS.mm:
1423         (WTR::TestController::platformResetStateToConsistentValues):
1424         * WebKitTestRunner/mac/TestControllerMac.mm:
1425         (WTR::TestController::platformResetStateToConsistentValues):
1426
1427 2018-11-05  Chris Dumez  <cdumez@apple.com>
1428
1429         Use same limit for page cache and suspended pages
1430         https://bugs.webkit.org/show_bug.cgi?id=191266
1431
1432         Reviewed by Geoffrey Garen.
1433
1434         Update API tests accordingly.
1435
1436         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1437
1438 2018-11-05  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1439
1440         [style] Exclude style check for auto generated files.
1441         https://bugs.webkit.org/show_bug.cgi?id=191118
1442
1443         Reviewed by Eric Carlson.
1444
1445         Some files checked in to the repository are generated by other tools. In this patch,
1446         "MiniBrowserLibResource.h" is the file generated and managed by resource editor of
1447         VisualStudio.
1448
1449         There's no need to check these files because it's not practical to fix the style errors
1450         or it's hard to maintain those fixes.
1451
1452         * Scripts/webkitpy/style/checkers/cpp.py:
1453         (is_generated_file):
1454         (CppChecker.check):
1455
1456 2018-11-05  Thibault Saunier  <tsaunier@igalia.com>
1457
1458         [Flatpak] Build libx264 as it is the h264 encoder we support in WebRTC
1459         https://bugs.webkit.org/show_bug.cgi?id=190680
1460
1461         Reviewed by Philippe Normand.
1462
1463         * flatpak/org.webkit.WebKit.yaml:
1464
1465 2018-11-05  Daniel Bates  <dabates@apple.com>
1466
1467         [lldb-webkit] Fix formatting nits in Document and Frame summary strings
1468         https://bugs.webkit.org/show_bug.cgi?id=191094
1469
1470         Reviewed by Andy Estes.
1471
1472         Format boolean as 1/0 when printing Frame summary to be consistent with the formatting of
1473         booleans in other summary strings, substitute "inMainFrame" for "isMainFrame" in the printed
1474         Document summary and add closing brace '}' to both Frame and Document summary strings to make
1475         them look pretty.
1476
1477         * lldb/lldb_webkit.py:
1478         (WebCoreFrame_SummaryProvider):
1479         (WebCoreDocument_SummaryProvider):
1480
1481 2018-11-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1482
1483         [iOS] Allow WKWebView clients to customize bar button item groups in the accessory view when editing
1484         https://bugs.webkit.org/show_bug.cgi?id=191240
1485         <rdar://problem/44872806>
1486
1487         Reviewed by Tim Horton.
1488
1489         Add new API tests to verify that setting leading and trailing bar button groups on WKWebView sets the first
1490         responder's (i.e. WKContentView's) leading and trailing bar button groups, and that this can also be achieved by
1491         overriding `-[WKWebView inputAssistantItem]`.
1492
1493         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1494         (-[InputAssistantItemTestingWebView fakeLeadingBarButtonItemAction]):
1495         (-[InputAssistantItemTestingWebView fakeTrailingBarButtonItemAction]):
1496         (+[InputAssistantItemTestingWebView barButtonIcon]):
1497         (+[InputAssistantItemTestingWebView leadingItemsForWebView:]):
1498         (+[InputAssistantItemTestingWebView trailingItemsForWebView:]):
1499         (-[InputAssistantItemTestingWebView inputAssistantItem]):
1500         (TestWebKitAPI::TEST):
1501
1502 2018-11-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1503
1504         [iOS] Changing view scale sometimes does not zoom the page to the new initial scale when the page is zoomed in when ignoring meta viewport
1505         https://bugs.webkit.org/show_bug.cgi?id=191226
1506         <rdar://problem/45781765>
1507
1508         Reviewed by Tim Horton.
1509
1510         Add a missing check for `shouldIgnoreMetaViewport` when comparing TestOptions, to ensure that "ignore meta
1511         viewport" state doesn't unexpectedly persist after running a layout test that ignores meta viewport.
1512
1513         * WebKitTestRunner/TestOptions.h:
1514         (WTR::TestOptions::hasSameInitializationOptions const):
1515
1516 2018-11-05  Commit Queue  <commit-queue@webkit.org>
1517
1518         Unreviewed, rolling out r237784 and r237788.
1519         https://bugs.webkit.org/show_bug.cgi?id=191270
1520
1521         Caused mediastream layout test failures (Requested by
1522         ryanhaddad on #webkit).
1523
1524         Reverted changesets:
1525
1526         "[MediaStream] User should not be prompted again after denying
1527         getDisplayMedia request"
1528         https://bugs.webkit.org/show_bug.cgi?id=191227
1529         https://trac.webkit.org/changeset/237784
1530
1531         "[MediaStream] User should not be prompted again after denying
1532         getDisplayMedia request"
1533         https://bugs.webkit.org/show_bug.cgi?id=191227
1534         https://trac.webkit.org/changeset/237788
1535
1536 2018-11-05  Lucas Forschler  <lforschler@apple.com>
1537
1538         https://bugs.webkit.org/show_bug.cgi?id=191268
1539         Remove unused bots.
1540
1541         rubber-stamped by Alexey Proskuryakov.
1542
1543         * BuildSlaveSupport/build.webkit.org-config/config.json:
1544         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1545         (WebKitBuildbot):
1546
1547 2018-11-05  Michael Catanzaro  <mcatanzaro@igalia.com>
1548
1549         [WPE][GTK] API test runner fails to respect default build type
1550         https://bugs.webkit.org/show_bug.cgi?id=190247
1551
1552         Reviewed by Carlos Garcia Campos.
1553
1554         Problem is it's looking for a release build, even though I've run set-webkit-configuration
1555         --debug. It should look for a debug build unless I explicitly pass --release.
1556
1557         * glib/api_test_runner.py:
1558         (TestRunner.__init__):
1559
1560 2018-11-05  Thibault Saunier  <tsaunier@igalia.com>
1561
1562         [GStreamer][WebRTC] Add webrtcencoder bin to cleanup and refactor the way we set encoders
1563         https://bugs.webkit.org/show_bug.cgi?id=190674
1564
1565         Reviewed by Philippe Normand.
1566
1567         webrtcencoder is a simple GstBin with a set of well known GStreamer encoders which
1568         it can use to implement encoding for different formats exposing a trimmed down unified API.
1569
1570         It also adds proper handling of H264 profiles.
1571
1572         The added files follow GStreamer coding style as we aim at upstreaming the element
1573         in the future.
1574
1575         Reviewed by Philippe Normand.
1576
1577         * Scripts/webkitpy/style/checker.py:
1578
1579 2018-11-05  Michael Catanzaro  <mcatanzaro@igalia.com>
1580
1581         [WPE][GTK] API test /webkit/WebKitSettings/webkit-settings is failing
1582         https://bugs.webkit.org/show_bug.cgi?id=191221
1583
1584         Reviewed by Carlos Garcia Campos.
1585
1586         This test ensures that MSE is disabled by default, but we now enable it by default, so
1587         reverse the semantics of the test.
1588
1589         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1590         (testWebKitSettings):
1591
1592 2018-11-05  Michael Catanzaro  <mcatanzaro@igalia.com>
1593
1594         REGRESSION(r237031): [GTK] Test /webkit/WebKitWebView/settings is failing
1595         https://bugs.webkit.org/show_bug.cgi?id=191225
1596
1597         Reviewed by Alejandro G. Castro.
1598
1599         Fix a memory leak causing this test to fail.
1600
1601         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
1602         (WebViewTest::initializeWebView):
1603
1604 2018-11-04  Zan Dobersek  <zdobersek@igalia.com>
1605
1606         [webkitpy] Support WPE in the run-web-platform-tests script
1607         https://bugs.webkit.org/show_bug.cgi?id=191183
1608
1609         Reviewed by Alex Christensen.
1610
1611         * Scripts/webkitpy/w3c/wpt_runner.py:
1612         (parse_args): Support `--wpe` as an argument that specifies WPE as the
1613         target port. Additionally, the `--display-server` flag now accepts
1614         `headless` as a valid value, enabling the WPE WebDriver to run in
1615         headless mode.
1616
1617 2018-11-04  Fujii Hironori  <Hironori.Fujii@sony.com>
1618
1619         [Win] Use C++14, not C++17
1620         https://bugs.webkit.org/show_bug.cgi?id=191101
1621
1622         Reviewed by Alex Christensen.
1623
1624         std::basic_string::data() returns a read-only const buffer in
1625         C++14.
1626
1627         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1628         (createString): Use std::vector instead of std::wstring.
1629         (createUTF8String): Use std::vector instead of std::string.
1630
1631 2018-11-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1632
1633         [Cocoa] Fold common UIScriptController functionality on macOS and iOS into UIScriptControllerCocoa.mm
1634         https://bugs.webkit.org/show_bug.cgi?id=191231
1635
1636         Reviewed by Simon Fraser.
1637
1638         Moves some UIScriptController method implementations specific to iOS and macOS into UIScriptControllerCocoa, so
1639         it can be shared between iOS-family and macOS platforms. See below for more details.
1640
1641         No change in behavior.
1642
1643         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1644         (WTR::UIScriptController::overridePreference):
1645
1646         Add a method stub for DumpRenderTree.
1647
1648         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1649         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1650         (WTR::UIScriptController::doAsyncTask):
1651         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
1652
1653         Unify these method implementations.
1654
1655         (WTR::UIScriptController::removeViewFromWindow):
1656         (WTR::UIScriptController::addViewToWindow):
1657
1658         Move the macOS implementation to UIScriptControllerCocoa. On iOS, this method currently only adds the web view
1659         to the window, and does not attempt to invoke the given completion block; additionally, invoking the completion
1660         block after a presentation update (as done on macOS) causes pageoverlay/overlay-remove-reinsert-view.html to
1661         begin failing consistently. This patch does not attempt to change behavior, but adds a FIXME describing this.
1662
1663         (WTR::UIScriptController::overridePreference):
1664         (WTR::UIScriptController::findString):
1665         (WTR::UIScriptController::contentsOfUserInterfaceItem const):
1666
1667         Move these from UIScriptControllerMac to UIScriptControllerCocoa, so that it is now implemented on iOS as well.
1668
1669         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1670         (WTR::UIScriptController::doAsyncTask): Deleted.
1671         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution): Deleted.
1672         (WTR::UIScriptController::contentsOfUserInterfaceItem const): Deleted.
1673         (WTR::UIScriptController::findString): Deleted.
1674         (WTR::UIScriptController::removeViewFromWindow): Deleted.
1675         (WTR::UIScriptController::addViewToWindow): Deleted.
1676         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1677         (WTR::UIScriptController::doAsyncTask): Deleted.
1678         (WTR::UIScriptController::contentsOfUserInterfaceItem const): Deleted.
1679         (WTR::UIScriptController::overridePreference): Deleted.
1680         (WTR::UIScriptController::findString): Deleted.
1681         (WTR::UIScriptController::removeViewFromWindow): Deleted.
1682         (WTR::UIScriptController::addViewToWindow): Deleted.
1683         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution): Deleted.
1684
1685 2018-11-04  Eric Carlson  <eric.carlson@apple.com>
1686
1687         [MediaStream] User should not be prompted again after denying getDisplayMedia request
1688         https://bugs.webkit.org/show_bug.cgi?id=191227
1689         <rdar://problem/45784512>
1690
1691         Reviewed by Youenn Fablet.
1692
1693         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
1694         (-[GetDisplayMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1695         (TestWebKitAPI::GetDisplayMediaTest::promptForCapture):
1696         (TestWebKitAPI::TEST_F):
1697
1698 2018-11-04  Zalan Bujtas  <zalan@apple.com>
1699
1700         [LFC][BFC] Add support for percentage height in quirks mode.
1701         https://bugs.webkit.org/show_bug.cgi?id=191232
1702
1703         Reviewed by Antti Koivisto.
1704
1705         * LayoutReloaded/misc/LFC-passing-tests.txt:
1706
1707 2018-11-04  Zalan Bujtas  <zalan@apple.com>
1708
1709         [LFC][BCF] Add support for block level non-replaced inflow height percentage
1710         https://bugs.webkit.org/show_bug.cgi?id=191229
1711
1712         Reviewed by Antti Koivisto.
1713
1714         * LayoutReloaded/misc/LFC-passing-tests.txt:
1715
1716 2018-11-02  Zalan Bujtas  <zalan@apple.com>
1717
1718         [LFC][BFC] Resolve percentage height values.
1719         https://bugs.webkit.org/show_bug.cgi?id=191224
1720
1721         Reviewed by Antti Koivisto.
1722
1723         * LayoutReloaded/misc/LFC-passing-tests.txt:
1724
1725 2018-11-03  Alex Christensen  <achristensen@webkit.org>
1726
1727         Mac production builds should sign the network process xpc service with entitlements
1728         https://bugs.webkit.org/show_bug.cgi?id=191209
1729         <rdar://problem/45377609>
1730
1731         Reviewed by Geoff Garen.
1732
1733         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1734         * TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm: Added.
1735         (TEST):
1736
1737 2018-11-02  Alex Christensen  <achristensen@webkit.org>
1738
1739         Unreviewed, rolling out r237761.
1740
1741         Makes most API tests timeout and WK2 tests crash
1742
1743         Reverted changeset:
1744
1745         "Mac production builds should sign the network process xpc
1746         service with entitlements"
1747         https://bugs.webkit.org/show_bug.cgi?id=191209
1748         https://trac.webkit.org/changeset/237761
1749
1750 2018-11-02  Michael Catanzaro  <mcatanzaro@igalia.com>
1751
1752         Unreviewed API test gardening
1753
1754         * TestWebKitAPI/glib/TestExpectations.json:
1755
1756 2018-11-02  Justin Michaud  <justin_michaud@apple.com>
1757
1758         Add new global object and preliminary Worklets support for CSS painting api
1759         https://bugs.webkit.org/show_bug.cgi?id=190979
1760
1761         Reviewed by Chris Dumez.
1762
1763         * Scripts/webkitpy/bindings/main.py:
1764         (BindingsTests.generate_supplemental_dependency):
1765         (BindingsTests.main):
1766
1767 2018-11-02  Alex Christensen  <achristensen@webkit.org>
1768
1769         Mac production builds should sign the network process xpc service with entitlements
1770         https://bugs.webkit.org/show_bug.cgi?id=191209
1771         <rdar://problem/45377609>
1772
1773         Reviewed by Geoff Garen.
1774
1775         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1776         * TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm: Added.
1777         (TEST):
1778
1779 2018-11-02  Lucas Forschler  <lforschler@apple.com>
1780
1781         Add Windows 10 archive bots
1782         https://bugs.webkit.org/show_bug.cgi?id=190964
1783         
1784         This Change updates the Apple Windows Buildbot configuration.
1785         - Add Windows 10 specific builders and testers for release and debug.
1786         - Refactor Windows -> Windows 7.
1787         - Remove Windows 7 Debug.
1788
1789         Reviewed by Aakash Jain.
1790
1791         * BuildSlaveSupport/build.webkit.org-config/config.json:
1792
1793 2018-11-02  Philippe Normand  <pnormand@igalia.com>
1794
1795         [GTK][WPE] Enable GST_DEBUG_NO_COLOR environment variable pass-through
1796
1797         Rubber-stamped by Michael Catanzaro.
1798
1799         This variable is useful to get rid of shell color escapes in tests stderr files.
1800
1801         * Scripts/webkitpy/port/gtk.py:
1802         (GtkPort.setup_environ_for_server):
1803         * Scripts/webkitpy/port/wpe.py:
1804         (WPEPort.setup_environ_for_server):
1805
1806 2018-11-02  Aakash Jain  <aakash_jain@apple.com>
1807
1808         Add Basic Django web app for OpenSource EWS
1809         https://bugs.webkit.org/show_bug.cgi?id=191091
1810
1811         Reviewed by Lucas Forschler.
1812
1813         * BuildSlaveSupport/EWS_app/manage.py: Added, auto-generated by Django.
1814         * BuildSlaveSupport/EWS_app/EWS_app/__init__.py: Added, auto-generated by Django.
1815         * BuildSlaveSupport/EWS_app/EWS_app/settings.py: Added, auto-generated by Django.
1816         * BuildSlaveSupport/EWS_app/EWS_app/urls.py: Added, auto-generated by Django.
1817         * BuildSlaveSupport/EWS_app/EWS_app/wsgi.py: Added, auto-generated by Django.
1818         * BuildSlaveSupport/EWS_app/ews/__init__.py: Added.
1819         * BuildSlaveSupport/EWS_app/ews/admin.py: Added, auto-generated by Django.
1820         * BuildSlaveSupport/EWS_app/ews/apps.py: Added, auto-generated by Django.
1821         * BuildSlaveSupport/EWS_app/ews/migrations/__init__.py: Added.
1822         * BuildSlaveSupport/EWS_app/ews/tests.py: Added, auto-generated by Django.
1823         * BuildSlaveSupport/EWS_app/ews/models/__init__.py: Added.
1824         * BuildSlaveSupport/EWS_app/ews/models/patch.py: Added.
1825         * BuildSlaveSupport/EWS_app/ews/views/__init__.py: Added.
1826         * BuildSlaveSupport/EWS_app/ews/views/patch.py: Added.
1827
1828 2018-11-02  Daniel Bates  <dabates@apple.com>
1829
1830         [iOS] WebKit should dispatch DOM events when a modifier key is pressed
1831         https://bugs.webkit.org/show_bug.cgi?id=190487
1832
1833         Reviewed by Tim Horton.
1834
1835         Update the code for renamed enumerations. For WebKitTestRunner, removed comment that does not
1836         match my observations when using the simulator to simulate iOS 12 and add support for testing
1837         right-hand side modifiers.
1838
1839         * DumpRenderTree/mac/EventSendingController.mm:
1840         (modifierFlags):
1841         (-[EventSendingController keyDown:withModifiers:withLocation:]):
1842         (-[EventSendingController setTouchModifier:value:]):
1843         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1844         (hidUsageCodeForCharacter):
1845
1846 2018-11-02  Chris Dumez  <cdumez@apple.com>
1847
1848         [PSON] Reuse SuspendedPages' process when possible, for performance
1849         https://bugs.webkit.org/show_bug.cgi?id=191166
1850
1851         Reviewed by Geoffrey Garen.
1852
1853         Add API test coverage.
1854
1855         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1856
1857 2018-11-02  Zalan Bujtas  <zalan@apple.com>
1858
1859         [LFC][IFC] Add support for intrinsic width calculation
1860         https://bugs.webkit.org/show_bug.cgi?id=191144
1861
1862         Reviewed by Antti Koivisto.
1863
1864         * LayoutReloaded/misc/LFC-passing-tests.txt:
1865
1866 2018-11-01  Philippe Normand  <pnormand@igalia.com>
1867
1868         [Apache] Self-signed SSL certificate RSA key is considered too weak
1869         https://bugs.webkit.org/show_bug.cgi?id=191156
1870
1871         Reviewed by Michael Catanzaro.
1872
1873         * Scripts/webkitpy/common/system/pemfile.py:
1874
1875 2018-11-02  Zan Dobersek  <zdobersek@igalia.com>
1876
1877         Unreviewed follow-up to r237678.
1878
1879         * wpe/jhbuild.modules: The patch element apparently has to be a child
1880         of the branch in order for Jhbuild to properly detect and apply the
1881         patch file.
1882
1883 2018-11-01  Ross Kirsling  <ross.kirsling@sony.com>
1884
1885         build-jsc --wincairo should update WinCairo libraries
1886         https://bugs.webkit.org/show_bug.cgi?id=191170
1887
1888         Reviewed by Fujii Hironori.
1889
1890         * Scripts/build-jsc:
1891
1892 2018-11-01  John Wilander  <wilander@apple.com>
1893
1894         In WebCore::ResourceLoadObserver, use document.sessionID().isEphemeral() when possible and check for page existence when not
1895         https://bugs.webkit.org/show_bug.cgi?id=191119
1896         <rdar://problem/44176965>
1897
1898         Reviewed by Chris Dumez.
1899
1900         This is an API test for a WebKitLegacy WebView that is first closed and then
1901         JavaScript is handed a keyboard event.
1902
1903         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1904         * TestWebKitAPI/Tests/WebKitLegacy/mac/ClosingWebView.mm: Added.
1905         (-[ClosingWebViewThenSendingItAKeyDownEventLoadDelegate webView:didFinishLoadForFrame:]):
1906         (-[KeyboardEventListener handleEvent:]):
1907         (TestWebKitAPI::TEST):
1908
1909 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
1910
1911         Add a storage limit for IndexedDB
1912         https://bugs.webkit.org/show_bug.cgi?id=190598
1913         <rdar://problem/44654715>
1914
1915         Reviewed by Chris Dumez.
1916
1917         Add API for testing.
1918
1919         * DumpRenderTree/TestRunner.cpp:
1920         (setIDBPerOriginQuotaCallback):
1921         (TestRunner::staticFunctions):
1922         * DumpRenderTree/TestRunner.h:
1923         * DumpRenderTree/mac/TestRunnerMac.mm:
1924         (TestRunner::setIDBPerOriginQuota):
1925         * DumpRenderTree/win/TestRunnerWin.cpp:
1926         (TestRunner::setIDBPerOriginQuota):
1927         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1928         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1929         (WTR::TestRunner::setIDBPerOriginQuota):
1930         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1931         * WebKitTestRunner/TestController.cpp:
1932         (WTR::TestController::setIDBPerOriginQuota):
1933         * WebKitTestRunner/TestController.h:
1934         * WebKitTestRunner/TestInvocation.cpp:
1935         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1936
1937 2018-11-01  Chris Dumez  <cdumez@apple.com>
1938
1939         [PSON] WebPageProxy::receivedNavigationPolicyDecision() should not schedule the new load asynchronously when process-swapping
1940         https://bugs.webkit.org/show_bug.cgi?id=191076
1941
1942         Reviewed by Geoffrey Garen.
1943
1944         Add API test coverage.
1945
1946         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1947         (-[PSONNavigationDelegate init]):
1948         (-[PSONNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1949
1950 2018-11-01  Adrian Perez de Castro  <aperez@igalia.com>
1951
1952         Fix build with VIDEO and WEB_AUDIO disabled
1953         https://bugs.webkit.org/show_bug.cgi?id=191147
1954         <rdar://problem/45726710>
1955
1956         Unreviewed build fix.
1957
1958         This adds the missing compilation guards in the WPE MiniBrowser.
1959
1960         * MiniBrowser/wpe/main.cpp:
1961         (main): Condition GST includes and calls.
1962
1963 2018-10-31  Zalan Bujtas  <zalan@apple.com>
1964
1965         [LFC][IFC] Add support for inline-block elements.
1966         https://bugs.webkit.org/show_bug.cgi?id=191143
1967
1968         Reviewed by Antti Koivisto.
1969
1970         * LayoutReloaded/misc/LFC-passing-tests.txt:
1971
1972 2018-11-01  Claudio Saavedra  <csaavedra@igalia.com>
1973
1974         [WPE] Add missing libsoup patch to jhbuild
1975         https://bugs.webkit.org/show_bug.cgi?id=191149
1976
1977         Reviewed by Žan Doberšek.
1978
1979         * wpe/jhbuild.modules:
1980         * wpe/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Added.
1981
1982 2018-11-01  Claudio Saavedra  <csaavedra@igalia.com>
1983
1984         Fix build with VIDEO and WEB_AUDIO disabled
1985         https://bugs.webkit.org/show_bug.cgi?id=191147
1986
1987         Reviewed by Philippe Normand.
1988
1989         * MiniBrowser/gtk/main.c:
1990         (main): Condition GST includes and calls
1991
1992 2018-10-31  Justin Michaud  <justin_michaud@apple.com>
1993
1994         Add Justin Michaud to the list of WebKit Committers
1995         https://bugs.webkit.org/show_bug.cgi?id=191142
1996
1997         * Scripts/webkitpy/common/config/contributors.json:
1998
1999 2018-10-31  Guillaume Emont  <guijemont@igalia.com>
2000
2001         Don't run JIT tests on 32-bit platforms
2002         https://bugs.webkit.org/show_bug.cgi?id=191074
2003
2004         Reviewed by Michael Catanzaro.
2005
2006         * Scripts/run-jsc-stress-tests:
2007
2008 2018-10-30  Wenson Hsieh  <wenson_hsieh@apple.com>
2009
2010         [Cocoa] Attachment dropped from one web view to another is missing its file wrapper
2011         https://bugs.webkit.org/show_bug.cgi?id=190530
2012         <rdar://problem/45232149>
2013
2014         Reviewed by Tim Horton.
2015
2016         Add a test to verify that copying different types of attachments and pasting in a new web view inserts
2017         attachments in the second web view that are backed by _WKAttachment objects, whose NSFileWrappers hold data that
2018         is equivalent to the original file wrappers used to insert attachments in the first web view.
2019
2020         Existing API tests verify that when copying and pasting within a single web view, the pasted attachment element
2021         is still backed by the same NSFileWrapper instance.
2022
2023         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2024         (TestWebKitAPI::TEST):
2025
2026 2018-10-30  Fujii Hironori  <Hironori.Fujii@sony.com>
2027
2028         [Win] Remove obsolete code for Visual Studio Express in webkitdirs.pm
2029         https://bugs.webkit.org/show_bug.cgi?id=190949
2030
2031         Reviewed by Alex Christensen.
2032
2033         Visual Studio 2017 Community is the alternative.
2034
2035         * Scripts/webkitdirs.pm: Remove $willUseVCExpressWhenBuilding variable.
2036         (setupCygwinEnv): Remove obsolete code for Visual Studio Express.
2037         (buildVisualStudioProject): Ditto.
2038         (dieIfWindowsPlatformSDKNotInstalled): Deleted.
2039         (usingVisualStudioExpress): Deleted.
2040
2041 2018-10-30  Fujii Hironori  <Hironori.Fujii@sony.com>
2042
2043         [Win][Direct2D] Support building DumpRenderTree for Direct2D
2044         https://bugs.webkit.org/show_bug.cgi?id=191093
2045         <rdar://problem/45685706>
2046
2047         Unreviewed build fix.
2048
2049         error C2065: 'renderTarget': undeclared identifier
2050
2051         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
2052         (createBitmapContextFromWebView): Restored the previous implementation.
2053
2054 2018-10-30  Don Olmstead  <don.olmstead@sony.com>
2055
2056         [PlayStation] Enable JavaScriptCore
2057         https://bugs.webkit.org/show_bug.cgi?id=191072
2058
2059         Reviewed by Brent Fulgham.
2060
2061         Add platform scripts for building the PlayStation port.
2062         perl Tools/Scripts/build-webkit --playstation
2063
2064         * Scripts/build-webkit:
2065         * Scripts/build-webkittestrunner:
2066         * Scripts/webkitdirs.pm:
2067         (argumentsForConfiguration):
2068         (determineConfigurationProductDir):
2069         (isPlayStation): Added.
2070         (getMSBuildPlatformArgument): Added.
2071         (buildVisualStudioProject):
2072         (wrapperPrefixIfNeeded):
2073         (generateBuildSystemFromCMakeProject):
2074         * TestWebKitAPI/PlatformPlayStation.cmake: Added.
2075
2076 2018-10-30  Brent Fulgham  <bfulgham@apple.com>
2077
2078         [Win][Direct2D] Support building DumpRenderTree for Direct2D
2079         https://bugs.webkit.org/show_bug.cgi?id=191093
2080         <rdar://problem/45685706>
2081
2082         Reviewed by Alex Christensen.
2083
2084         * DumpRenderTree/PixelDumpSupport.cpp: Update for Direct2D use.
2085         * DumpRenderTree/PlatformWin.cmake: Add support for Direct2D build.
2086         * DumpRenderTree/win/PixelDumpSupportDirect2D.cpp: Added.
2087         (pixelDumpSystemFactory): Added.
2088         (printPNG): Create stub.
2089         (computeMD5HashStringForBitmapContext): Ditto.
2090         (dumpBitmap): Ditto.
2091         * DumpRenderTree/win/PixelDumpSupportDirect2D.h: Added.
2092         (BitmapContext::createByAdoptingBitmapAndContext):
2093         (BitmapContext::~BitmapContext):
2094         (BitmapContext::platformContext const):
2095         (BitmapContext::BitmapContext):
2096         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
2097         (createBitmapContextFromWebView): Update to support Direct2D.
2098         * MiniBrowser/win/MiniBrowserReplace.h: Drive-by fix: The old WebKit
2099         logo is no longer available at this location. Switch to the new logo.
2100
2101 2018-10-30  Jonathan Bedard  <jbedard@apple.com>
2102
2103         webkitpy: Support alternate simctl list outputs
2104         https://bugs.webkit.org/show_bug.cgi?id=191090
2105         <rdar://problem/45684255>
2106
2107         Rubber-stamped by Aakash Jain.
2108
2109         * Scripts/webkitpy/xcode/simulated_device.py:
2110         (SimulatedDeviceManager._create_runtimes): Support alternative availability format.
2111         (SimulatedDeviceManager._create_device_with_runtime): Ditto.
2112         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
2113         (test_available_devices): Add iOS 12 with alternative availability format.
2114
2115 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
2116
2117         Clean up some obsolete MAX_ALLOWED macros
2118         https://bugs.webkit.org/show_bug.cgi?id=190916
2119
2120         Reviewed by Tim Horton.
2121
2122         * TestWebKitAPI/Tests/WTF/darwin/WeakLinking.cpp:
2123         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
2124         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2125
2126 2018-10-30  Claudio Saavedra  <csaavedra@igalia.com>
2127
2128         [GTK][WPE] Fixes to the PublicSuffix implementation
2129         https://bugs.webkit.org/show_bug.cgi?id=191031
2130
2131         Reviewed by Michael Catanzaro.
2132
2133         * TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:
2134         (TestWebKitAPI::TEST_F): Remove a test for a domain
2135         that is not registrable and shouldn't be tested there.
2136
2137 2018-10-29  Tim Horton  <timothy_horton@apple.com>
2138
2139         Modernize WebKit nibs and lprojs for localization's sake
2140         https://bugs.webkit.org/show_bug.cgi?id=190911
2141         <rdar://problem/45349466>
2142
2143         Reviewed by Dan Bernstein.
2144
2145         * Scripts/check-inspector-strings:
2146         * Scripts/update-webkit-localizable-strings:
2147         * gtk/manifest.txt.in:
2148         * wpe/manifest.txt.in:
2149         English->en
2150
2151 2018-10-29  Daniel Bates  <dabates@apple.com>
2152
2153         [lldb-webkit] Last aliased enumerator in OptionSet is printed; should print first enumerator
2154         https://bugs.webkit.org/show_bug.cgi?id=191036
2155
2156         Reviewed by Andy Estes.
2157
2158         Prefer the first enumerator (in parse order) when pretty-printing an OptionSet that is parameterized
2159         by an enum that contains two or more enumerators with the same value. For example, suppose
2160         you have the following enum:
2161
2162         enum Flag {
2163             A = 1 << 0,
2164             AAlias = A,
2165         };
2166
2167         Then pretty-printing OptionSet<Flag>(Flag::A) should print A instead of AAlias. A side effect of
2168         this change is that OptionSet<Flag>(Flag::AAlias) will also print A as its only member as we cannot
2169         differentiate between A and Alias. This should be acceptable in practice as aliased enumerators
2170         tend to be used in bounds checks as opposed to code that adds to a set.
2171
2172         * lldb/lldbWebKitTester/main.cpp:
2173         (testSummaryProviders):
2174         * lldb/lldb_webkit.py:
2175         (WTFOptionSetProvider.update):
2176         * lldb/lldb_webkit_unittest.py:
2177         (TestSummaryProviders.serial_test_WTFOptionSetProvider_simple):
2178         (TestSummaryProviders):
2179         (TestSummaryProviders.serial_test_WTFOptionSetProvider_aliased_flag):
2180
2181 2018-10-29  Daniel Bates  <dabates@apple.com>
2182
2183         [llbd-webkit] Add summaries for Document, Frame, and SecurityOrigin
2184         https://bugs.webkit.org/show_bug.cgi?id=191033
2185
2186         Reviewed by Andy Estes.
2187
2188         For Documents we display its origin, URL, whether it's in the main frame, and its page cache state.
2189         We display the same details in the summary for a Frame because its Document tends to be the most
2190         interesting aspect of it. For SecurityOrigin we display its origin, domain (affects cookie access),
2191         and whether the origin has universal access.
2192
2193         * lldb/lldb_webkit.py:
2194         (__lldb_init_module):
2195         Register new summary providers.
2196
2197         (WebCoreSecurityOrigin_SummaryProvider):
2198         (WebCoreFrame_SummaryProvider):
2199         (WebCoreDocument_SummaryProvider):
2200         Add new summary providers.
2201
2202         (StdOptionalWrapper):
2203         (StdOptionalWrapper.__init__):
2204         (StdOptionalWrapper.has_value):
2205         (StdOptionalWrapper.value):
2206         Convenience data type that provides access to the fields of a std::optional<>.
2207         
2208         (WebCoreSecurityOriginProvider):
2209         (WebCoreSecurityOriginProvider.__init__):
2210         (WebCoreSecurityOriginProvider.is_unique):
2211         (WebCoreSecurityOriginProvider.scheme):
2212         (WebCoreSecurityOriginProvider.host):
2213         (WebCoreSecurityOriginProvider.port):
2214         (WebCoreSecurityOriginProvider.domain):
2215         (WebCoreSecurityOriginProvider.has_universal_access):
2216         (WebCoreSecurityOriginProvider.to_string):
2217         (WebCoreFrameProvider):
2218         (WebCoreFrameProvider.__init__):
2219         (WebCoreFrameProvider.is_main_frame):
2220         (WebCoreFrameProvider.document):
2221         (WebCoreDocumentProvider):
2222         (WebCoreDocumentProvider.__init__):
2223         (WebCoreDocumentProvider.url):
2224         (WebCoreDocumentProvider.origin):
2225         (WebCoreDocumentProvider.page_cache_state):
2226         (WebCoreDocumentProvider.frame):
2227
2228 2018-10-29  Chris Dumez  <cdumez@apple.com>
2229
2230         [PSON] When Safari restores session state after launching, going back and forward does not swap processes
2231         https://bugs.webkit.org/show_bug.cgi?id=190975
2232         <rdar://problem/45059256>
2233
2234         Reviewed by Antti Koivisto.
2235
2236         Add API test coverage.
2237
2238         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2239
2240 2018-10-29  Zalan Bujtas  <zalan@apple.com>
2241
2242         [LFC][IFC] Compute estimated margin top for inline formatting root's ancestors
2243         https://bugs.webkit.org/show_bug.cgi?id=191018
2244
2245         Reviewed by Antti Koivisto.
2246
2247         * LayoutReloaded/misc/LFC-passing-tests.txt:
2248
2249 2018-10-29  Zalan Bujtas  <zalan@apple.com>
2250
2251         [LFC] Add support for inflow non replaced content height when the box is an inline formatting root.
2252         https://bugs.webkit.org/show_bug.cgi?id=191011
2253
2254         Reviewed by Antti Koivisto.
2255
2256         * LayoutReloaded/misc/LFC-passing-tests.txt:
2257
2258 2018-10-29  Zalan Bujtas  <zalan@apple.com>
2259
2260         Missing from r237549
2261
2262         Reviewed by Antti Koivisto.
2263
2264         * LayoutReloaded/misc/LFC-passing-tests.txt:
2265
2266 2018-10-29  Zalan Bujtas  <zalan@apple.com>
2267
2268         [LFC][IFC] Add support for simple intruding floats.
2269         https://bugs.webkit.org/show_bug.cgi?id=190998
2270
2271         Reviewed by Antti Koivisto.
2272
2273         * LayoutReloaded/misc/LFC-passing-tests.txt:
2274
2275 2018-10-29  Zalan Bujtas  <zalan@apple.com>
2276
2277         [LFC][IFC] Inline layout produces separate runs when float is present.
2278         https://bugs.webkit.org/show_bug.cgi?id=190980
2279
2280         Reviewed by Antti Koivisto.
2281
2282         * LayoutReloaded/misc/LFC-passing-tests.txt:
2283
2284 2018-10-29  Tadeu Zagallo  <tzagallo@apple.com>
2285
2286         New bytecode format for JSC
2287         https://bugs.webkit.org/show_bug.cgi?id=187373
2288         <rdar://problem/44186758>
2289
2290         Reviewed by Filip Pizlo.
2291
2292         Do not force ENABLE_JIT=true when $forceCLoop is false.
2293
2294         * Scripts/build-jsc:
2295
2296 2018-10-29  Claudio Saavedra  <csaavedra@igalia.com>
2297
2298         [GTK] Try to fix the xserver-xorg build in the Ubuntu LTS bot
2299
2300         Unreviewed build fix
2301
2302         The build fails because of some array-bound check related
2303         to strcmp() macro optimizations. Disabling selective Werrors
2304         when building xserver-xorg might get past this.
2305
2306         * gtk/jhbuild.modules: Add --disable-selective-werror to xserver-xorg
2307         configuration.
2308
2309 2018-10-29  Claudio Saavedra  <csaavedra@igalia.com>
2310
2311         [GTK] Update API test expectations after r237383
2312         https://bugs.webkit.org/show_bug.cgi?id=186913
2313
2314         Unreviewed gardening.
2315
2316         * TestWebKitAPI/glib/TestExpectations.json: Remove
2317         passing TestSSL tests.
2318
2319 2018-10-28  Zan Dobersek  <zdobersek@igalia.com>
2320
2321         [WPE] Add the WebKitVersion.h header
2322         https://bugs.webkit.org/show_bug.cgi?id=191015
2323
2324         Reviewed by Michael Catanzaro.
2325
2326         * MiniBrowser/wpe/main.cpp:
2327         (automationStartedCallback): Remove the FIXME and finally enable the
2328         webkit_application_info_set_version() call.
2329         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp: Remove
2330         this FIXME as well and remove the custom WEBKIT_*_VERSION macros.
2331
2332 2018-10-28  Fujii Hironori  <Hironori.Fujii@sony.com>
2333
2334         [Win] Remove obsolete code for vcxproj builds in build-api-tests and build-jsc
2335         https://bugs.webkit.org/show_bug.cgi?id=190948
2336
2337         Reviewed by Brent Fulgham.
2338
2339         vcxproj files have been removed in Bug 154388.
2340
2341         * Scripts/build-api-tests: Removed obsolete code to build vcproj.
2342         * Scripts/build-jsc:
2343         (buildMyProject): Ditto. Removed a condition of buiding bmalloc
2344         which is not used because Windows ports are using CMake.
2345
2346 2018-10-28  Geoffrey Garen  <ggaren@apple.com>
2347
2348         HashMap should support selecting a random entry
2349         https://bugs.webkit.org/show_bug.cgi?id=190814
2350
2351         Reviewed by Ryosuke Niwa.
2352
2353         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Renamed IsRandom to
2354         IsEvenlyDistributed to reflect the fact that we're only testing the
2355         distribution. Added a test case that covers more table densities and
2356         the remove() operation.
2357
2358 2018-10-27  Charlie Turner  <cturner@igalia.com>
2359
2360         [GTK] Add bubblewrap feature option
2361         https://bugs.webkit.org/show_bug.cgi?id=190981
2362
2363         Reviewed by Xabier Rodriguez-Calvar.
2364
2365         Without this, it was not possible to disable the bubblewrap sandbox
2366         from the webkit build scripts.
2367
2368         * Scripts/webkitperl/FeatureList.pm:
2369
2370 2018-10-26  Commit Queue  <commit-queue@webkit.org>
2371
2372         Unreviewed, rolling out r237479 and r237484.
2373         https://bugs.webkit.org/show_bug.cgi?id=190978
2374
2375         broke JSC on iOS (Requested by tadeuzagallo on #webkit).
2376
2377         Reverted changesets:
2378
2379         "New bytecode format for JSC"
2380         https://bugs.webkit.org/show_bug.cgi?id=187373
2381         https://trac.webkit.org/changeset/237479
2382
2383         "Gardening: Build fix after r237479."
2384         https://bugs.webkit.org/show_bug.cgi?id=187373
2385         https://trac.webkit.org/changeset/237484
2386
2387 2018-10-26  Tadeu Zagallo  <tzagallo@apple.com>
2388
2389         New bytecode format for JSC
2390         https://bugs.webkit.org/show_bug.cgi?id=187373
2391         <rdar://problem/44186758>
2392
2393         Reviewed by Filip Pizlo.
2394
2395         Do not force ENABLE_JIT=true when $forceCLoop is false.
2396
2397         * Scripts/build-jsc:
2398
2399 2018-10-26  Geoffrey Garen  <ggaren@apple.com>
2400
2401         HashMap should support selecting a random entry
2402         https://bugs.webkit.org/show_bug.cgi?id=190814
2403
2404         Reviewed by Antti Koivisto.
2405
2406         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Updated the Random_IsRandom to
2407         more thoroughly test for randomness.
2408
2409 2018-10-26  Antti Koivisto  <antti@apple.com>
2410
2411         hashSet.remove(hashSet.random()) doesn't build
2412         https://bugs.webkit.org/show_bug.cgi?id=190953
2413
2414         Reviewed by Chris Dumez.
2415
2416         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2417         (TestWebKitAPI::TEST):
2418
2419 2018-10-26  Zalan Bujtas  <zalan@apple.com>
2420
2421         [LFC][IFC] Layout floats as part of the inline content
2422         https://bugs.webkit.org/show_bug.cgi?id=190942
2423
2424         Reviewed by Antti Koivisto.
2425
2426         * LayoutReloaded/misc/LFC-passing-tests.txt:
2427
2428 2018-10-26  Alicia Boya García  <aboya@igalia.com>
2429
2430         [MSE][WTF][Media] Invalid MediaTime should be falsy
2431         https://bugs.webkit.org/show_bug.cgi?id=190893
2432
2433         Reviewed by Jer Noble.
2434
2435         This patch adds additional API tests for the conversions from
2436         MediaTime to boolean.
2437
2438         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
2439         (TestWebKitAPI::TEST):
2440
2441 2018-10-25  Chris Dumez  <cdumez@apple.com>
2442
2443         [PSON] Navigating cross-site with locked history but unlocked back/forward list fails to create a new BackForwardListItem
2444         https://bugs.webkit.org/show_bug.cgi?id=190915
2445         <rdar://problem/45059069>
2446
2447         Reviewed by Geoffrey Garen.
2448
2449         Add API test coverage.
2450
2451         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2452
2453 2018-10-25  Joseph Pecoraro  <pecoraro@apple.com>
2454
2455         Web Inspector: Add a watchlist message rule to warn about feature checking new inspector protocol changes
2456         https://bugs.webkit.org/show_bug.cgi?id=190896
2457
2458         Reviewed by Matt Baker.
2459
2460         * Scripts/webkitpy/common/config/watchlist:
2461
2462 2018-10-25  Geoffrey Garen  <ggaren@apple.com>
2463
2464         HashMap should support selecting a random entry
2465         https://bugs.webkit.org/show_bug.cgi?id=190814
2466
2467         Reviewed by Antti Koivisto.
2468
2469         Unit testing is fun and easy!
2470
2471         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2472         (TestWebKitAPI::ZeroHash::hash):
2473         (TestWebKitAPI::TEST):
2474
2475 2018-10-24  Tim Horton  <timothy_horton@apple.com>
2476
2477         REGRESSION (r237331): DismissingActionSheetShouldNotDismissPresentingViewController times out
2478         https://bugs.webkit.org/show_bug.cgi?id=190897
2479
2480         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2481         (TestWebKitAPI::TEST):
2482         Disable the test for now.
2483
2484 2018-10-24  Alexey Proskuryakov  <ap@apple.com>
2485
2486         Clean up some obsolete macOS version guards
2487         https://bugs.webkit.org/show_bug.cgi?id=190887
2488
2489         Reviewed by Dan Bernstein.
2490
2491         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2492         (__simulated_forceClickAssociatedEventsMask):
2493         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:clickCount:]):
2494         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2495         (WTR::initializeWebViewConfiguration):
2496         * WebKitTestRunner/mac/EventSenderProxy.mm:
2497         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
2498
2499 2018-10-24  Megan Gardner  <megan_gardner@apple.com>
2500
2501         Turn on Conic Gradients
2502         https://bugs.webkit.org/show_bug.cgi?id=190810
2503
2504         Reviewed by Tim Horton.
2505
2506         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2507
2508 2018-10-24  Pablo Saavedra  <psaavedra@igalia.com>
2509
2510         [WPE] Fix CMake rules in for TestWebKitAPIBase library building in developer mode
2511         https://bugs.webkit.org/show_bug.cgi?id=190328
2512
2513         Reviewed by Michael Catanzaro.
2514
2515         * TestWebKitAPI/CMakeLists.txt:
2516         * TestWebKitAPI/PlatformWPE.cmake:
2517
2518 2018-10-24  Chris Dumez  <cdumez@apple.com>
2519
2520         [PSON] When navigating back and forth, 'about:blank' shows up in the back/forward list
2521         https://bugs.webkit.org/show_bug.cgi?id=190846
2522         <rdar://problem/45058938>
2523
2524         Reviewed by Antti Koivisto.
2525
2526         Add API test coverage.
2527
2528         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2529
2530 2018-10-24  Claudio Saavedra  <csaavedra@igalia.com>
2531
2532         [GTK] TestSSL failing because of missing libsoup patch
2533         https://bugs.webkit.org/show_bug.cgi?id=190869
2534
2535         Reviewed by Michael Catanzaro.
2536
2537         * gtk/jhbuild.modules: Add the patch below to fix the API test TestSSL
2538         * gtk/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Added.
2539
2540 2018-10-23  Justin Fan  <justin_fan@apple.com>
2541
2542         [WebGPU] Rename old GPU* implementation files to GPULegacy* for WebMetal
2543         https://bugs.webkit.org/show_bug.cgi?id=190817
2544
2545         Reviewed by Dean Jackson.
2546
2547         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2548         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUBuffer.mm.
2549         (TestWebKitAPI::TEST_F):
2550         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Copied from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm.
2551         (TestWebKitAPI::TEST_F):
2552         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUDevice.mm.
2553         (TestWebKitAPI::TEST_F):
2554         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm.
2555         (TestWebKitAPI::TEST_F):
2556         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPULibrary.mm.
2557         (TestWebKitAPI::TEST_F):
2558         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUTest.h.
2559
2560 2018-10-23  Chris Dumez  <cdumez@apple.com>
2561
2562         [PSON] Add support for cross-site client-side redirects
2563         https://bugs.webkit.org/show_bug.cgi?id=190806
2564         <rdar://problem/45047344>
2565
2566         Reviewed by Geoffrey Garen.
2567
2568         Add API test coverage.
2569
2570         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2571         (-[PSONNavigationDelegate _webView:willPerformClientRedirectToURL:delay:]):
2572         (-[PSONNavigationDelegate _webView:didPerformClientRedirectFromURL:toURL:]):
2573
2574 2018-10-23  Claudio Saavedra  <csaavedra@igalia.com>
2575
2576         [WPE][GTK] Pass full certificate chain in CertificateInfo coder
2577         https://bugs.webkit.org/show_bug.cgi?id=190789
2578
2579         Reviewed by Michael Catanzaro.
2580
2581         When the network process serializes certificate data to other
2582         processes through the argument coders, the certificate chain, if
2583         present, is lost. In practice this means that applications using
2584         the public API to process certificate info have no details on the
2585         certificate chain, other than the very basics included in the
2586         certificate. Serialize the entire chain if available in the
2587         certificate.
2588
2589         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
2590         (testSSL): Test that the self-signed certificate has no bogus
2591         issuer certificate.
2592
2593 2018-10-22  Tim Horton  <timothy_horton@apple.com>
2594
2595         REGRESSION (r237331): InteractionDeadlockAfterCrash API test fails
2596         https://bugs.webkit.org/show_bug.cgi?id=190801
2597         <rdar://problem/43674361>
2598
2599         * TestWebKitAPI/Tests/WebKitCocoa/InteractionDeadlockAfterCrash.mm:
2600         (TEST):
2601         Use a parented WKWebView for this test, otherwise none of the assertions
2602         about gesture recognizers work anymore.
2603
2604 2018-10-22  Ryan Haddad  <ryanhaddad@apple.com>
2605
2606         REGRESSION (r234081): TestWebKitAPI.VideoControlsManager.VideoControlsManagerAudioElementFollowingUserInteraction is a flaky timeout
2607         https://bugs.webkit.org/show_bug.cgi?id=187972
2608
2609         Unreviewed test gardening.
2610
2611         * TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm:
2612         (TestWebKitAPI::TEST): Disable the flaky test.
2613
2614 2018-10-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2615
2616         [iOS] [Datalist] fast/forms/datalist/datalist-show-hide.html fails
2617         https://bugs.webkit.org/show_bug.cgi?id=190777
2618
2619         Reviewed by Tim Horton.
2620
2621         Implement isShowingDataListSuggestions on iOS. See below for more details.
2622
2623         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2624         (WTR::UIScriptController::isShowingDataListSuggestions const):
2625
2626         Add a stub implementation for DumpRenderTree.
2627
2628         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2629         (WTR::UIScriptController::isShowingDataListSuggestions const):
2630
2631         Move this stub implementation to !PLATFORM(COCOA).
2632
2633         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2634         (WTR::forEachViewInHierarchy):
2635
2636         Add a helper function to apply a given function to a UIView and each of its subviews, recursively.
2637
2638         (WTR::UIScriptController::isShowingDataListSuggestions const):
2639
2640         For iOS, return whether the UIRemoteKeyboardWindow contains a subview of type WKDataListSuggestionsPickerView.
2641
2642 2018-10-19  Dan Bernstein  <mitz@apple.com>
2643
2644         [macOS] MiniBrowser has an unused injected bundle
2645         https://bugs.webkit.org/show_bug.cgi?id=190770
2646
2647         Reviewed by Tim Horton.
2648
2649         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Removed.
2650         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Removed the MiniBrowserBundle target,
2651           the Copy Bundle build phase in the MiniBrowser target, and references to removed files.
2652         * MiniBrowser/MiniBrowserWebProcessPlugIn.h: Removed.
2653         * MiniBrowser/MiniBrowserWebProcessPlugIn.m: Removed.
2654         * MiniBrowser/mac/Bundle: Removed.
2655
2656 2018-10-19  Wenson Hsieh  <wenson_hsieh@apple.com>
2657
2658         [iOS] [Datalist] Can't pick datalist suggestions in a stock WKWebView
2659         https://bugs.webkit.org/show_bug.cgi?id=190621
2660         <rdar://problem/45310649>
2661
2662         Reviewed by Tim Horton.
2663
2664         Add a UIScriptController hook to resign first responder on WKWebView. See LayoutTests/ChangeLog for more detail.
2665
2666         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2667         (WTR::UIScriptController::resignFirstResponder):
2668         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2669         (WTR::UIScriptController::resignFirstResponder):
2670         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2671         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2672         (WTR::UIScriptController::resignFirstResponder):
2673         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2674         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2675         (WTR::UIScriptController::resignFirstResponder):
2676         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2677         (WTR::PlatformWebView::makeWebViewFirstResponder):
2678
2679         Implement this method stub on iOS, to ensure that TestController::resetStateToConsistentValues restores first
2680         responder on the WKWebView when running iOS layout tests.
2681
2682         * WebKitTestRunner/ios/TestControllerIOS.mm:
2683         (WTR::TestController::platformResetStateToConsistentValues):
2684
2685         After resigning first responder to dismiss any on-screen keyboard, ensure that we restore first responder.
2686
2687 2018-10-19  Dean Jackson  <dino@apple.com>
2688
2689         ASSERTION FAILED: !frame().animation().hasAnimations() in WebCore::FrameView::didDestroyRenderTree()
2690         https://bugs.webkit.org/show_bug.cgi?id=186946
2691         <rdar://problem/41724248>
2692
2693         Reviewed by Antoine Quint.
2694
2695         If the incoming test has different enableWebAnimationsCSSIntegration options,
2696         then we need to create a new WebView.
2697
2698         * DumpRenderTree/TestOptions.cpp:
2699         (TestOptions::webViewIsCompatibleWithOptions const):
2700
2701 2018-10-19  Charlie Turner  <cturner@igalia.com>
2702
2703         [EME] Fix crash during tracing in  gst_qtdemux_request_protection_context
2704         https://bugs.webkit.org/show_bug.cgi?id=190738
2705
2706         Reviewed by Xabier Rodriguez-Calvar.
2707
2708         Add a GStreamer patch to avoid crashing when the run-time logging
2709         level is TRACE. There was a missing null check which caused many
2710         tests to crash.
2711
2712         * gstreamer/patches/gst-plugins-good-0013-Avoid-warning-when-reporting-about-decryptors.patch: Added.
2713
2714 2018-10-18  Alicia Boya García  <aboya@igalia.com>
2715
2716         [Media] Use nanoseconds as MaximumTimeScale
2717         https://bugs.webkit.org/show_bug.cgi?id=190631
2718
2719         Rebased MediaTime tests covering timescales over the maximum.
2720
2721         Reviewed by Jer Noble.
2722
2723         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
2724         (TestWebKitAPI::TEST):
2725
2726 2018-10-18  Dean Johnson  <dean_johnson@apple.com>
2727
2728         clean-webkit pulls in many unnecessary dependencies in webkitpy
2729         https://bugs.webkit.org/show_bug.cgi?id=190732
2730
2731         Reviewed by Alexey Proskuryakov.
2732
2733         * Scripts/webkitpy/common/host.py:
2734         (Host.__init__): Split out 'bugs', 'bugzilla', and 'web' to only be created when used.
2735         (Host):
2736         (Host.bugs):
2737         (Host.bugzilla):
2738         (Host.web):
2739
2740 2018-10-18  Chris Dumez  <cdumez@apple.com>
2741
2742         [PSON] SuspendedPages do not report meaningful domains in Activity Monitor
2743         https://bugs.webkit.org/show_bug.cgi?id=190721
2744         <rdar://problem/45059699>
2745
2746         Reviewed by Alex Christensen.
2747
2748         Add API test coverage.
2749
2750         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2751
2752 2018-10-18  Alexey Proskuryakov  <ap@apple.com>
2753
2754         Switch from PLATFORM(IOS) to PLATFORM(IOS_FAMILY)
2755         https://bugs.webkit.org/show_bug.cgi?id=190729
2756
2757         Reviewed by Tim Horton.
2758
2759         * DumpRenderTree/AccessibilityController.h:
2760         * DumpRenderTree/AccessibilityTextMarker.h:
2761         * DumpRenderTree/AccessibilityUIElement.cpp:
2762         (AccessibilityUIElement::getJSClass):
2763         * DumpRenderTree/AccessibilityUIElement.h:
2764         * DumpRenderTree/DumpRenderTreeFileDraggingSource.h:
2765         * DumpRenderTree/TestRunner.cpp:
2766         (getSecureEventInputIsEnabledCallback):
2767         (TestRunner::staticFunctions):
2768         (TestRunner::callUIScriptCallback):
2769         * DumpRenderTree/TestRunner.h:
2770         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2771         * DumpRenderTree/ios/AccessibilityTextMarkerIOS.mm:
2772         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2773         * DumpRenderTree/ios/DumpRenderTreeAppMain.mm:
2774         * DumpRenderTree/ios/DumpRenderTreeBrowserView.mm:
2775         * DumpRenderTree/ios/TextInputControllerIOS.m:
2776         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2777         * DumpRenderTree/mac/AppleScriptController.m:
2778         * DumpRenderTree/mac/DumpRenderTree.mm:
2779         (createWebViewAndOffscreenWindow):
2780         (destroyWebViewAndOffscreenWindow):
2781         (resetWebPreferencesToConsistentValues):
2782         (setDefaultsToConsistentValuesForTesting):
2783         (allocateGlobalControllers):
2784         (releaseGlobalControllers):
2785         (addTestPluginsToPluginSearchPath):
2786         (prepareConsistentTestingEnvironment):
2787         (dumpRenderTree):
2788         (DumpRenderTreeMain):
2789         (dumpFrameAsPDF):
2790         (dumpBackForwardListForAllWindows):
2791         (updateDisplay):
2792         (dump):
2793         (resetWebViewToConsistentStateBeforeTesting):
2794         (runTest):
2795         (displayWebView):
2796         (displayAndTrackRepaintsWebView):
2797         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
2798         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2799         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2800         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
2801         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2802         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2803         (-[DumpRenderTreeWindow close]):
2804         (-[DumpRenderTreeWindow webView]):
2805         (-[DumpRenderTreeWindow webViewStartedAcceleratedCompositing:]):
2806         * DumpRenderTree/mac/EventSendingController.h:
2807         * DumpRenderTree/mac/EventSendingController.mm:
2808         (+[EventSendingController isSelectorExcludedFromWebScript:]):
2809         (+[EventSendingController webScriptNameForSelector:]):
2810         (-[EventSendingController dealloc]):
2811         (-[EventSendingController currentEventTime]):
2812         (-[EventSendingController clearKillRing]):
2813         (modifierFlags):
2814         (-[EventSendingController mouseDown:withModifiers:]):
2815         (-[EventSendingController scalePageBy:atX:andY:]):
2816         (-[EventSendingController mouseUp:withModifiers:]):
2817         (-[EventSendingController mouseMoveToX:Y:]):
2818         (-[EventSendingController mouseScrollByX:andY:continuously:]):
2819         (-[EventSendingController keyDown:withModifiers:withLocation:]):
2820         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2821         (-[FrameLoadDelegate init]):
2822         (-[FrameLoadDelegate dealloc]):
2823         (-[FrameLoadDelegate processWork:]):
2824         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2825         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
2826         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
2827         * DumpRenderTree/mac/LayoutTestHelper.m:
2828         * DumpRenderTree/mac/MockGeolocationProvider.mm:
2829         (-[MockGeolocationProvider timerFired]):
2830         * DumpRenderTree/mac/TestRunnerMac.mm:
2831         (TestRunner::setMainFrameIsFirstResponder):
2832         (TestRunner::setAutomaticLinkDetectionEnabled):
2833         (TestRunner::setUseDashboardCompatibilityMode):
2834         (TestRunner::isCommandEnabled):
2835         (TestRunner::inspectorTestStubURL):
2836         (TestRunner::apiTestNewWindowDataLoadBaseURL):
2837         (TestRunner::abortModal):
2838         (TestRunner::setTextDirection):
2839         (TestRunner::addChromeInputField):
2840         (TestRunner::removeChromeInputField):
2841         (TestRunner::focusWebView):
2842         (TestRunner::setBackingScaleFactor):
2843         (TestRunner::imageCountInGeneralPasteboard const):
2844         * DumpRenderTree/mac/UIDelegate.h:
2845         * DumpRenderTree/mac/UIDelegate.mm:
2846         (-[UIDelegate modalWindowWillClose:]):
2847         (-[UIDelegate webViewRunModal:]):
2848         (-[UIDelegate webView:supportsFullScreenForElement:withKeyboard:]):
2849         (-[UIDelegate dealloc]):
2850         * Scripts/check-for-inappropriate-objc-class-names:
2851         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2852         * TestRunnerShared/spi/UIKitTestSPI.h:
2853         * TestWebKitAPI/Tests/WTF/darwin/WeakLinking.cpp:
2854         * TestWebKitAPI/Tests/WebCore/MarkedText.cpp:
2855         (WebCore::operator<<):
2856         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
2857         (TestWebKitAPI::TEST):
2858         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
2859         (TestWebKitAPI::WebCoreNSURLSessionTest::SetUp):
2860         * TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp:
2861         * TestWebKitAPI/Tests/WebKit/NoHistoryItemScrollToFragment.mm:
2862         (TestWebKitAPI::TEST):
2863         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
2864         (TestWebKitAPI::TEST):
2865         * TestWebKitAPI/Tests/WebKitCocoa/AdditionalReadAccessAllowedURLs.mm:
2866         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
2867         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegate.mm:
2868         (TEST):
2869         * TestWebKitAPI/Tests/WebKitCocoa/BundleRangeHandle.mm:
2870         (TEST):
2871         * TestWebKitAPI/Tests/WebKitCocoa/BundleRangeHandlePlugIn.mm:
2872         (-[BundleRangeHandlePlugIn webProcessPlugInBrowserContextController:didFinishDocumentLoadForFrame:]):
2873         * TestWebKitAPI/Tests/WebKitCocoa/Coding.mm:
2874         (TEST):
2875         * TestWebKitAPI/Tests/WebKitCocoa/CopyHTML.mm:
2876         * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
2877         (createWebViewWithCustomPasteboardDataEnabled):
2878         * TestWebKitAPI/Tests/WebKitCocoa/Copying.mm:
2879         (TEST):
2880         * TestWebKitAPI/Tests/WebKitCocoa/DataDetection.mm:
2881         * TestWebKitAPI/Tests/WebKitCocoa/DoAfterNextPresentationUpdateAfterCrash.mm:
2882         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
2883         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
2884         * TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:
2885         * TestWebKitAPI/Tests/WebKitCocoa/FixedLayoutSize.mm:
2886         * TestWebKitAPI/Tests/WebKitCocoa/FontAttributes.mm:
2887         * TestWebKitAPI/Tests/WebKitCocoa/Geolocation.mm:
2888         * TestWebKitAPI/Tests/WebKitCocoa/InteractionDeadlockAfterCrash.mm:
2889         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageClear.mm:
2890         (defaultWebsiteCacheDirectory):
2891         (defaultApplicationCacheDirectory):
2892         (TEST):
2893         * TestWebKitAPI/Tests/WebKitCocoa/NSFileManagerExtras.mm:
2894         * TestWebKitAPI/Tests/WebKitCocoa/NowPlaying.mm:
2895         * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
2896         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
2897         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
2898         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:
2899         (TestWebKitAPI::TEST):
2900         * TestWebKitAPI/Tests/WebKitCocoa/PasteRTFD.mm:
2901         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
2902         * TestWebKitAPI/Tests/WebKitCocoa/RenderedImageWithOptions.mm:
2903         (runTestWithWidth):
2904         * TestWebKitAPI/Tests/WebKitCocoa/RenderedImageWithOptionsPlugIn.mm:
2905         (-[RenderedImageWithOptionsPlugIn renderImageWithWidth:completionHandler:]):
2906         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2907         * TestWebKitAPI/Tests/WebKitCocoa/ShrinkToFit.mm:
2908         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
2909         * TestWebKitAPI/Tests/WebKitCocoa/VisibleContentRect.mm:
2910         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2911         (platformCopyRichTextWithMultipleAttachments):
2912         (platformCopyRichTextWithImage):
2913         (platformCopyPNG):
2914         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
2915         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewTargetForAction.mm:
2916         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
2917         * TestWebKitAPI/Tests/WebKitCocoa/WKPDFViewStablePresentationUpdateCallback.mm:
2918         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
2919         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-leaks.mm:
2920         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
2921         (TEST):
2922         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2923         (TEST):
2924         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2925         (TEST):
2926         * TestWebKitAPI/Tests/WebKitCocoa/_WKInputDelegate.mm:
2927         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
2928         * TestWebKitAPI/Tests/WebKitLegacy/ios/SnapshotViaRenderInContext.mm:
2929         * TestWebKitAPI/Tests/WebKitLegacy/mac/AccessingPastedImage.mm:
2930         * TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:
2931         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2932         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2933         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2934         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2935         * TestWebKitAPI/Tests/ios/RenderingProgressTests.mm:
2936         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
2937         * TestWebKitAPI/Tests/ios/SetTimeoutFunction.mm:
2938         * TestWebKitAPI/Tests/ios/SynchronousTimeoutTests.mm:
2939         * TestWebKitAPI/Tests/ios/TestInputDelegate.h:
2940         * TestWebKitAPI/Tests/ios/TestInputDelegate.mm:
2941         * TestWebKitAPI/Tests/ios/TextAutosizingBoost.mm:
2942         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2943         * TestWebKitAPI/Tests/ios/WKScrollViewDelegate.mm:
2944         * TestWebKitAPI/Tests/ios/WKScrollViewTests.mm:
2945         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2946         * TestWebKitAPI/Tests/ios/WKWebViewEditActions.mm:
2947         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
2948         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
2949         (-[WKWebView _test_waitForDidFinishNavigation]):
2950         * TestWebKitAPI/cocoa/TestWKWebView.h:
2951         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2952         * TestWebKitAPI/config.h:
2953         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2954         * TestWebKitAPI/ios/TestWKWebViewController.h:
2955         * TestWebKitAPI/ios/TestWKWebViewController.mm:
2956         * TestWebKitAPI/ios/UIKitSPI.h:
2957         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2958         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2959         (WTR::InjectedBundle::beginTesting):
2960         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2961         (WTR::TestRunner::inspectorTestStubURL):
2962         * WebKitTestRunner/TestController.cpp:
2963         (WTR::TestController::webProcessName):
2964         (WTR::TestController::networkProcessName):
2965         * WebKitTestRunner/TestInvocation.cpp:
2966         (WTR::TestInvocation::invoke):
2967         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2968         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2969         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2970         (WTR::initializeWebViewConfiguration):
2971         (WTR::TestController::platformCreateWebView):
2972         (WTR::TestController::imageCountInGeneralPasteboard const):
2973         (WTR::TestController::addTestKeyToKeychain):
2974         (WTR::TestController::cleanUpKeychain):
2975         (WTR::TestController::keyExistsInKeychain):
2976         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2977         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2978         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2979
2980 2018-10-18  Chris Dumez  <cdumez@apple.com>
2981
2982         [PSON] Cap number of SuspendedPageProxy objects and allow a WebPageProxy to have more than one
2983         https://bugs.webkit.org/show_bug.cgi?id=190688
2984         <rdar://problem/45354095>
2985
2986         Reviewed by Antti Koivisto.
2987
2988         Extended API test coverage to confirm that:
2989         - We do not accumulate more than 3 suspended processes.
2990         - We can navigate back 3 times and use the page cache for each of these loads.
2991
2992         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2993
2994 2018-10-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2995
2996         Enable the datalist element by default on iOS and macOS
2997         https://bugs.webkit.org/show_bug.cgi?id=190594
2998         <rdar://problem/45281159>
2999
3000         Reviewed by Ryosuke Niwa and Tim Horton.
3001
3002         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3003
3004 2018-10-17  Chris Fleizach  <cfleizach@apple.com>
3005
3006         AX: Certain tags should identify their context to iOS API
3007         https://bugs.webkit.org/show_bug.cgi?id=190622
3008         <rdar://problem/45308194>
3009
3010         Reviewed by Zalan Bujtas.
3011
3012         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3013         (AccessibilityUIElement::stringAttributeValue):
3014         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3015         (WTR::AccessibilityUIElement::stringAttributeValue):
3016
3017 2018-10-16  Sihui Liu  <sihui_liu@apple.com>
3018
3019         Add a switch for Web SQL
3020         https://bugs.webkit.org/show_bug.cgi?id=190271
3021
3022         Reviewed by Ryosuke Niwa.
3023
3024         * WebKitTestRunner/TestController.cpp:
3025         (WTR::TestController::resetPreferencesToConsistentValues):
3026
3027 2018-10-16  Alex Christensen  <achristensen@webkit.org>
3028
3029         Remove InjectedBundleBackForwardList
3030         https://bugs.webkit.org/show_bug.cgi?id=190640
3031
3032         Reviewed by Chris Dumez.
3033
3034         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3035         (WTR::InjectedBundle::dumpBackForwardListsForAllPages):
3036         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3037         (WTR::InjectedBundlePage::prepare):
3038         (WTR::InjectedBundlePage::dumpHistory):
3039         (WTR::hasPrefix): Deleted.
3040         (WTR::compareByTargetName): Deleted.
3041         (WTR::dumpBackForwardListItem): Deleted.
3042         (WTR::InjectedBundlePage::dumpBackForwardList): Deleted.
3043         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3044         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3045         (WTR::TestRunner::clearBackForwardList):
3046
3047 2018-10-16  Dominik Infuehr  <dinfuehr@igalia.com>
3048
3049         Unreviewed, added myself to contributors.json.
3050
3051         * Scripts/webkitpy/common/config/contributors.json:
3052
3053 2018-10-16  Justin Michaud  <justin_michaud@apple.com>
3054
3055         Implement feature flag and bindings for CSS Painting API
3056         https://bugs.webkit.org/show_bug.cgi?id=190237
3057
3058         Reviewed by Ryosuke Niwa.
3059
3060         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3061
3062 2018-10-16  Philippe Normand  <pnormand@igalia.com>
3063
3064         Unreviewed, GTK Ubuntu LTS Jhbuild prospective build fix
3065
3066         * gstreamer/jhbuild.modules:
3067
3068 2018-10-16  Philippe Normand  <pnormand@igalia.com>
3069
3070         [GTK][JHBuild] Disable libmount support in glib
3071
3072         Rubber-stamped by Alejandro G. Castro.
3073
3074         This feature doesn't seem required for our setup.
3075
3076         * gtk/jhbuild.modules:
3077
3078 2018-10-15  Justin Fan  <justin_fan@apple.com>
3079
3080         Add WebGPU 2018 feature flag and experimental feature flag
3081         https://bugs.webkit.org/show_bug.cgi?id=190509
3082
3083         Reviewed by Dean Jackson.
3084
3085         Re-add ENABLE_WEBGPU, an experimental feature flag, and a RuntimeEnabledFeature
3086         for the 2018 WebGPU prototype.
3087
3088         * DumpRenderTree/TestOptions.cpp:
3089         (TestOptions::TestOptions):
3090         * DumpRenderTree/TestOptions.h:
3091         * DumpRenderTree/mac/DumpRenderTree.mm:
3092         (setWebPreferencesForTestOptions):
3093         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3094
3095 2018-10-15  Ryan Haddad  <ryanhaddad@apple.com>
3096
3097         Update bot configuration for Sierra archive queues
3098         https://bugs.webkit.org/show_bug.cgi?id=190605
3099
3100         Reviewed by Aakash Jain.
3101
3102         * BuildSlaveSupport/build.webkit.org-config/config.json:
3103
3104 2018-10-15  Timothy Hatcher  <timothy@apple.com>
3105
3106         Add support for prefers-color-scheme media query
3107         https://bugs.webkit.org/show_bug.cgi?id=190499
3108         rdar://problem/45212025
3109
3110         Reviewed by Dean Jackson.
3111
3112         * Scripts/webkitperl/FeatureList.pm: Added ENABLE_DARK_MODE_CSS as dark-mode-css.
3113         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS.
3114
3115 2018-10-15  Patrick Griffis  <pgriffis@igalia.com>
3116
3117         [JHBuild] Add xdg-dbus-proxy module
3118         https://bugs.webkit.org/show_bug.cgi?id=190589
3119
3120         Reviewed by Michael Catanzaro.
3121
3122         * gtk/jhbuild.modules:
3123
3124 2018-10-15  Patrick Griffis  <pgriffis@igalia.com>
3125
3126         [GTK] Add new sandboxing dependencies to install-dependencies
3127         https://bugs.webkit.org/show_bug.cgi?id=190588
3128
3129         Reviewed by Michael Catanzaro.
3130
3131         * gtk/install-dependencies:
3132
3133 2018-10-15  Chris Dumez  <cdumez@apple.com>
3134
3135         Experiment: target=_blank on anchors should imply rel=noopener
3136         https://bugs.webkit.org/show_bug.cgi?id=190481
3137
3138         Reviewed by Alex Christensen.
3139
3140         Add API test coverage to make sure we can now swap process when target=_blank
3141         is specified on an anchor but rel=noopener is not.
3142
3143         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3144
3145 2018-10-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3146
3147         [iOS] Can't select text after dismissing the keyboard when changing focus
3148         https://bugs.webkit.org/show_bug.cgi?id=190563
3149         <rdar://problem/44613559>
3150
3151         Reviewed by Tim Horton.
3152
3153         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3154         (WTR::UIScriptController::isShowingKeyboard const):
3155
3156         Add a new UIScriptController method that returns whether the keyboard is shown. See `ui-helper.js` for more
3157         details.
3158
3159         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3160         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3161         (WTR::UIScriptController::isShowingKeyboard const):
3162         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3163         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3164         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3165
3166         Also rename the `isShowingKeyboard` Objective-C property to the more canonical `showingKeyboard`, with
3167         `isShowingKeyboard` as the getter method.
3168
3169         (-[TestRunnerWKWebView _invokeShowKeyboardCallbackIfNecessary]):
3170         (-[TestRunnerWKWebView _invokeHideKeyboardCallbackIfNecessary]):
3171         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3172         (WTR::UIScriptController::isShowingKeyboard const):
3173
3174 2018-10-15  Ryan Haddad  <ryanhaddad@apple.com>
3175
3176         Unreviewed, fix JSC tests after WebGPUShadingLanguageRI directory was removed in r237115.
3177
3178         * Scripts/run-javascriptcore-tests:
3179         (runJSCStressTests): Remove wsl-tests.yaml.
3180
3181 2018-10-15  Christopher Reid  <chris.reid@sony.com>
3182
3183         [Curl][WinCairo] Add Public Suffix support to WinCairo
3184         https://bugs.webkit.org/show_bug.cgi?id=183060
3185
3186         Reviewed by Alex Christensen.
3187
3188         Share mac's PublicSuffix tests with all ports.
3189
3190         * TestWebKitAPI/PlatformWin.cmake:
3191         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3192         * TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:
3193         * TestWebKitAPI/Tests/mac/PublicSuffix.mm: Removed.
3194
3195 2018-10-15  Myles C. Maxfield  <mmaxfield@apple.com>
3196
3197         [WHLSL] Migrated WebGPUShadingLanguageRI to the W3C
3198         https://bugs.webkit.org/show_bug.cgi?id=190555
3199
3200         Unreviewed.
3201
3202         Migrated to https://github.com/gpuweb/WHLSL/tree/master/Source
3203
3204         * WebGPUShadingLanguageRI/AddressSpace.js: Removed.
3205         * WebGPUShadingLanguageRI/All.js: Removed.
3206         * WebGPUShadingLanguageRI/AllocateAtEntryPoints.js: Removed.
3207         * WebGPUShadingLanguageRI/AnonymousVariable.js: Removed.
3208         * WebGPUShadingLanguageRI/ArrayRefType.js: Removed.
3209         * WebGPUShadingLanguageRI/ArrayType.js: Removed.
3210         * WebGPUShadingLanguageRI/Assignment.js: Removed.
3211         * WebGPUShadingLanguageRI/AutoWrapper.js: Removed.
3212         * WebGPUShadingLanguageRI/Block.js: Removed.
3213         * WebGPUShadingLanguageRI/BoolLiteral.js: Removed.
3214         * WebGPUShadingLanguageRI/Break.js: Removed.
3215         * WebGPUShadingLanguageRI/BuiltInSemantic.js: Removed.
3216         * WebGPUShadingLanguageRI/BuiltinMatrixGetter.js: Removed.
3217         * WebGPUShadingLanguageRI/BuiltinMatrixSetter.js: Removed.
3218         * WebGPUShadingLanguageRI/BuiltinVectorGetter.js: Removed.
3219         * WebGPUShadingLanguageRI/BuiltinVectorSetter.js: Removed.
3220         * WebGPUShadingLanguageRI/CallExpression.js: Removed.
3221         * WebGPUShadingLanguageRI/CallFunction.js: Removed.
3222         * WebGPUShadingLanguageRI/Casts.js: Removed.
3223         * WebGPUShadingLanguageRI/Check.js: Removed.
3224         * WebGPUShadingLanguageRI/CheckLiteralTypes.js: Removed.
3225         * WebGPUShadingLanguageRI/CheckLoops.js: Removed.
3226         * WebGPUShadingLanguageRI/CheckNativeFuncStages.js: Removed.
3227         * WebGPUShadingLanguageRI/CheckRecursion.js: Removed.
3228         * WebGPUShadingLanguageRI/CheckRecursiveTypes.js: Removed.
3229         * WebGPUShadingLanguageRI/CheckReturns.js: Removed.
3230         * WebGPUShadingLanguageRI/CheckTypesWithArguments.js: Removed.
3231         * WebGPUShadingLanguageRI/CheckUnreachableCode.js: Removed.
3232         * WebGPUShadingLanguageRI/CheckWrapped.js: Removed.
3233         * WebGPUShadingLanguageRI/Checker.js: Removed.
3234         * WebGPUShadingLanguageRI/CloneProgram.js: Removed.
3235         * WebGPUShadingLanguageRI/CommaExpression.js: Removed.
3236         * WebGPUShadingLanguageRI/ConstexprFolder.js: Removed.
3237         * WebGPUShadingLanguageRI/Continue.js: Removed.
3238         * WebGPUShadingLanguageRI/ConvertPtrToArrayRefExpression.js: Removed.
3239         * WebGPUShadingLanguageRI/CreateLiteral.js: Removed.
3240         * WebGPUShadingLanguageRI/CreateLiteralType.js: Removed.
3241         * WebGPUShadingLanguageRI/DereferenceExpression.js: Removed.
3242         * WebGPUShadingLanguageRI/DoWhileLoop.js: Removed.
3243         * WebGPUShadingLanguageRI/DotExpression.js: Removed.
3244         * WebGPUShadingLanguageRI/EArrayRef.js: Removed.
3245         * WebGPUShadingLanguageRI/EBuffer.js: Removed.
3246         * WebGPUShadingLanguageRI/EBufferBuilder.js: Removed.
3247         * WebGPUShadingLanguageRI/EPtr.js: Removed.
3248         * WebGPUShadingLanguageRI/EnumLiteral.js: Removed.
3249         * WebGPUShadingLanguageRI/EnumMember.js: Removed.
3250         * WebGPUShadingLanguageRI/EnumType.js: Removed.
3251         * WebGPUShadingLanguageRI/EvaluationCommon.js: Removed.
3252         * WebGPUShadingLanguageRI/Evaluator.js: Removed.
3253         * WebGPUShadingLanguageRI/Expression.js: Removed.
3254         * WebGPUShadingLanguageRI/ExpressionFinder.js: Removed.
3255         * WebGPUShadingLanguageRI/ExternalOrigin.js: Removed.
3256         * WebGPUShadingLanguageRI/Field.js: Removed.
3257         * WebGPUShadingLanguageRI/FindHighZombies.js: Removed.
3258         * WebGPUShadingLanguageRI/FlattenedStructOffsetGatherer.js: Removed.
3259         * WebGPUShadingLanguageRI/FloatLiteral.js: Removed.
3260         * WebGPUShadingLanguageRI/FloatLiteralType.js: Removed.
3261         * WebGPUShadingLanguageRI/FoldConstexprs.js: Removed.
3262         * WebGPUShadingLanguageRI/ForLoop.js: Removed.
3263         * WebGPUShadingLanguageRI/Func.js: Removed.
3264         * WebGPUShadingLanguageRI/FuncAttribute.js: Removed.
3265         * WebGPUShadingLanguageRI/FuncDef.js: Removed.
3266         * WebGPUShadingLanguageRI/FuncNumThreadsAttribute.js: Removed.
3267         * WebGPUShadingLanguageRI/FuncParameter.js: Removed.
3268         * WebGPUShadingLanguageRI/FunctionLikeBlock.js: Removed.
3269         * WebGPUShadingLanguageRI/HighZombieFinder.js: Removed.
3270         * WebGPUShadingLanguageRI/IdentityExpression.js: Removed.
3271         * WebGPUShadingLanguageRI/IfStatement.js: Removed.
3272         * WebGPUShadingLanguageRI/IndexExpression.js: Removed.
3273         * WebGPUShadingLanguageRI/InferTypesForCall.js: Removed.
3274         * WebGPUShadingLanguageRI/Inline.js: Removed.
3275         * WebGPUShadingLanguageRI/Inliner.js: Removed.
3276         * WebGPUShadingLanguageRI/IntLiteral.js: Removed.
3277         * WebGPUShadingLanguageRI/IntLiteralType.js: Removed.
3278         * WebGPUShadingLanguageRI/Intrinsics.js: Removed.
3279         * WebGPUShadingLanguageRI/LayoutBuffers.js: Removed.
3280         * WebGPUShadingLanguageRI/Lexer.js: Removed.
3281         * WebGPUShadingLanguageRI/LexerToken.js: Removed.
3282         * WebGPUShadingLanguageRI/LiteralTypeChecker.js: Removed.
3283         * WebGPUShadingLanguageRI/LogicalExpression.js: Removed.
3284         * WebGPUShadingLanguageRI/LogicalNot.js: Removed.
3285         * WebGPUShadingLanguageRI/LoopChecker.js: Removed.
3286         * WebGPUShadingLanguageRI/MakeArrayRefExpression.js: Removed.
3287         * WebGPUShadingLanguageRI/MakePtrExpression.js: Removed.
3288         * WebGPUShadingLanguageRI/MatrixType.js: Removed.
3289         * WebGPUShadingLanguageRI/Metal/MSLBackend.js: Removed.
3290         * WebGPUShadingLanguageRI/Metal/MSLCodegenAll.js: Removed.
3291         * WebGPUShadingLanguageRI/Metal/MSLCompileResult.js: Removed.
3292         * WebGPUShadingLanguageRI/Metal/MSLConstexprEmitter.js: Removed.
3293         * WebGPUShadingLanguageRI/Metal/MSLFunctionDeclaration.js: Removed.
3294         * WebGPUShadingLanguageRI/Metal/MSLFunctionDefinition.js: Removed.
3295         * WebGPUShadingLanguageRI/Metal/MSLFunctionForwardDeclaration.js: Removed.
3296         * WebGPUShadingLanguageRI/Metal/MSLInsertTrapParameter.js: Removed.
3297         * WebGPUShadingLanguageRI/Metal/MSLNameMangler.js: Removed.
3298         * WebGPUShadingLanguageRI/Metal/MSLNativeFunctionCall.js: Removed.
3299         * WebGPUShadingLanguageRI/Metal/MSLStatementEmitter.js: Removed.
3300         * WebGPUShadingLanguageRI/Metal/MSLTypeAttributes.js: Removed.
3301         * WebGPUShadingLanguageRI/Metal/MSLTypeAttributesMap.js: Removed.
3302         * WebGPUShadingLanguageRI/Metal/MSLTypeUnifier.js: Removed.
3303         * WebGPUShadingLanguageRI/Metal/TypeOf.js: Removed.
3304         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/.gitignore: Removed.
3305         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/AppDelegate.h: Removed.
3306         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/AppDelegate.m: Removed.
3307         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Assets.xcassets/AppIcon.appiconset/Contents.json: Removed.
3308         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Assets.xcassets/Contents.json: Removed.
3309         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Base.lproj/Main.storyboard: Removed.
3310         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.h: Removed.
3311         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.m: Removed.
3312         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.h: Removed.
3313         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m: Removed.
3314         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CustomMetalView.h: Removed.
3315         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CustomMetalView.m: Removed.
3316         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Default.whlsl: Removed.
3317         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Julia.whlsl: Removed.
3318         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Mandelbrot.whlsl: Removed.
3319         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Info.plist: Removed.
3320         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.h: Removed.
3321         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.m: Removed.
3322         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.h: Removed.
3323         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.m: Removed.
3324         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/Renderer.h: Removed.
3325         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/Renderer.m: Removed.
3326         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.h: Removed.
3327         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.m: Removed.
3328         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.h: Removed.
3329         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.m: Removed.
3330         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.h: Removed.
3331         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m: Removed.
3332         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.h: Removed.
3333         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m: Removed.
3334         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.h: Removed.
3335         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m: Removed.
3336         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/WHLSL.entitlements: Removed.
3337         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/_SharedMetal.txt: Removed.
3338         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/main.m: Removed.
3339         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL Tests.xcodeproj/project.pbxproj: Removed.
3340         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL ToyTests/Info.plist: Removed.
3341         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL ToyTests/WHLSL_ToyTests.m: Removed.
3342         * WebGPUShadingLanguageRI/Metal/WhlslToMsl.html: Removed.
3343         * WebGPUShadingLanguageRI/Metal/WhlslToMsl.js: Removed.
3344         * WebGPUShadingLanguageRI/NameContext.js: Removed.
3345         * WebGPUShadingLanguageRI/NameFinder.js: Removed.
3346         * WebGPUShadingLanguageRI/NameResolver.js: Removed.
3347         * WebGPUShadingLanguageRI/NativeFunc.js: Removed.
3348         * WebGPUShadingLanguageRI/NativeType.js: Removed.
3349         * WebGPUShadingLanguageRI/Node.js: Removed.
3350         * WebGPUShadingLanguageRI/NormalUsePropertyResolver.js: Removed.
3351         * WebGPUShadingLanguageRI/NullLiteral.js: Removed.
3352         * WebGPUShadingLanguageRI/NullType.js: Removed.
3353         * WebGPUShadingLanguageRI/OperatorAnderIndexer.js: Removed.
3354         * WebGPUShadingLanguageRI/OperatorArrayRefLength.js: Removed.
3355         * WebGPUShadingLanguageRI/OriginKind.js: Removed.
3356         * WebGPUShadingLanguageRI/OverloadResolutionFailure.js: Removed.
3357         * WebGPUShadingLanguageRI/Parse.js: Removed.
3358         * WebGPUShadingLanguageRI/Prepare.js: Removed.
3359         * WebGPUShadingLanguageRI/Program.js: Removed.
3360         * WebGPUShadingLanguageRI/ProgramWithUnnecessaryThingsRemoved.js: Removed.
3361         * WebGPUShadingLanguageRI/PropertyAccessExpression.js: Removed.
3362         * WebGPUShadingLanguageRI/PropertyResolver.js: Removed.
3363         * WebGPUShadingLanguageRI/PtrType.js: Removed.
3364         * WebGPUShadingLanguageRI/ReadModifyWriteExpression.js: Removed.
3365         * WebGPUShadingLanguageRI/RecursionChecker.js: Removed.
3366         * WebGPUShadingLanguageRI/RecursiveTypeChecker.js: Removed.
3367         * WebGPUShadingLanguageRI/ReferenceType.js: Removed.
3368         * WebGPUShadingLanguageRI/ResolveNames.js: Removed.
3369         * WebGPUShadingLanguageRI/ResolveOverloadImpl.js: Removed.
3370         * WebGPUShadingLanguageRI/ResolveProperties.js: Removed.
3371         * WebGPUShadingLanguageRI/ResolveTypeDefs.js: Removed.
3372         * WebGPUShadingLanguageRI/ResourceSemantic.js: Removed.
3373         * WebGPUShadingLanguageRI/Return.js: Removed.
3374         * WebGPUShadingLanguageRI/ReturnChecker.js: Removed.
3375         * WebGPUShadingLanguageRI/ReturnException.js: Removed.
3376         * WebGPUShadingLanguageRI/Rewriter.js: Removed.
3377         * WebGPUShadingLanguageRI/SPIR-V.js: Removed.
3378         * WebGPUShadingLanguageRI/SPIRV.html: Removed.
3379         * WebGPUShadingLanguageRI/SPIRVCodegen.js: Removed.
3380         * WebGPUShadingLanguageRI/SPIRVTypeAnalyzer.js: Removed.
3381         * WebGPUShadingLanguageRI/SPIRVVariableAnalyzer.js: Removed.
3382         * WebGPUShadingLanguageRI/Sampler.js: Removed.
3383         * WebGPUShadingLanguageRI/Semantic.js: Removed.
3384         * WebGPUShadingLanguageRI/SpecializationConstantSemantic.js: Removed.
3385         * WebGPUShadingLanguageRI/StageInOutSemantic.js: Removed.
3386         * WebGPUShadingLanguageRI/StandardLibrary.js: Removed.
3387         * WebGPUShadingLanguageRI/StatementCloner.js: Removed.
3388         * WebGPUShadingLanguageRI/StructLayoutBuilder.js: Removed.
3389         * WebGPUShadingLanguageRI/StructType.js: Removed.
3390         * WebGPUShadingLanguageRI/SwitchCase.js: Removed.
3391         * WebGPUShadingLanguageRI/SwitchStatement.js: Removed.
3392         * WebGPUShadingLanguageRI/SynthesizeArrayOperatorLength.js: Removed.
3393         * WebGPUShadingLanguageRI/SynthesizeCopyConstructorOperator.js: Removed.
3394         * WebGPUShadingLanguageRI/SynthesizeDefaultConstructorOperator.js: Removed.
3395         * WebGPUShadingLanguageRI/SynthesizeEnumFunctions.js: Removed.
3396         * WebGPUShadingLanguageRI/SynthesizeStructAccessors.js: Removed.
3397         * WebGPUShadingLanguageRI/TernaryExpression.js: Removed.
3398         * WebGPUShadingLanguageRI/Test.html: Removed.
3399         * WebGPUShadingLanguageRI/Test.js: Removed.
3400         * WebGPUShadingLanguageRI/Texture.js: Removed.
3401         * WebGPUShadingLanguageRI/TextureOperations.js: Removed.
3402         * WebGPUShadingLanguageRI/TrapStatement.js: Removed.
3403         * WebGPUShadingLanguageRI/Type.js: Removed.
3404         * WebGPUShadingLanguageRI/TypeDef.js: Removed.
3405         * WebGPUShadingLanguageRI/TypeDefResolver.js: Removed.
3406         * WebGPUShadingLanguageRI/TypeOverloadResolutionFailure.js: Removed.
3407         * WebGPUShadingLanguageRI/TypeRef.js: Removed.
3408         * WebGPUShadingLanguageRI/TypedValue.js: Removed.
3409         * WebGPUShadingLanguageRI/UintLiteral.js: Removed.
3410         * WebGPUShadingLanguageRI/UintLiteralType.js: Removed.
3411         * WebGPUShadingLanguageRI/UnificationContext.js: Removed.
3412         * WebGPUShadingLanguageRI/UnreachableCodeChecker.js: Removed.
3413         * WebGPUShadingLanguageRI/Value.js: Removed.
3414         * WebGPUShadingLanguageRI/VariableDecl.js: Removed.
3415         * WebGPUShadingLanguageRI/VariableRef.js: Removed.
3416         * WebGPUShadingLanguageRI/VectorType.js: Removed.
3417         * WebGPUShadingLanguageRI/VisitingSet.js: Removed.
3418         * WebGPUShadingLanguageRI/Visitor.js: Removed.
3419         * WebGPUShadingLanguageRI/WLexicalError.js: Removed.
3420         * WebGPUShadingLanguageRI/WSyntaxError.js: Removed.
3421         * WebGPUShadingLanguageRI/WTrapError.js: Removed.
3422         * WebGPUShadingLanguageRI/WTypeError.js: Removed.
3423         * WebGPUShadingLanguageRI/WhileLoop.js: Removed.
3424         * WebGPUShadingLanguageRI/WrapChecker.js: Removed.
3425         * WebGPUShadingLanguageRI/index.html: Removed.
3426         * WebGPUShadingLanguageRI/spirv.core.grammar.json: Removed.
3427         * WebGPUShadingLanguageRI/wsl-tests.yaml: Removed.
3428
3429 2018-10-15  Philippe Normand  <pnormand@igalia.com>
3430
3431         [GTK] Disable MSE build support on Debian and Ubuntu LTS bots
3432         https://bugs.webkit.org/show_bug.cgi?id=190581
3433
3434         Reviewed by Michael Catanzaro.
3435
3436         These bots don't use JHBuild and their host GStreamer version is
3437         too old for the GStreamer MSE backend. Version 1.14 is needed at least.
3438
3439         * BuildSlaveSupport/build.webkit.org-config/config.json:
3440
3441 2018-10-15  Alex Christensen  <achristensen@webkit.org>
3442
3443         Use pragma once in WTF
3444         https://bugs.webkit.org/show_bug.cgi?id=190527
3445
3446         Reviewed by Chris Dumez.
3447
3448         Put WorkQueue in namespace DRT so it does not conflict with WTF::WorkQueue.
3449
3450         * DumpRenderTree/TestRunner.cpp:
3451         (TestRunner::queueLoadHTMLString):
3452         (TestRunner::queueLoadAlternateHTMLString):
3453         (TestRunner::queueBackNavigation):
3454         (TestRunner::queueForwardNavigation):
3455         (TestRunner::queueLoadingScript):
3456         (TestRunner::queueNonLoadingScript):
3457         (TestRunner::queueReload):
3458         * DumpRenderTree/WorkQueue.cpp:
3459         (WorkQueue::singleton): Deleted.
3460         (WorkQueue::WorkQueue): Deleted.
3461         (WorkQueue::queue): Deleted.
3462         (WorkQueue::dequeue): Deleted.
3463         (WorkQueue::count): Deleted.
3464         (WorkQueue::clear): Deleted.
3465         (WorkQueue::processWork): Deleted.
3466         * DumpRenderTree/WorkQueue.h:
3467         (WorkQueue::setFrozen): Deleted.
3468         * DumpRenderTree/WorkQueueItem.h:
3469         * DumpRenderTree/mac/DumpRenderTree.mm:
3470         (runTest):
3471         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3472         (-[FrameLoadDelegate processWork:]):
3473         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
3474         * DumpRenderTree/mac/TestRunnerMac.mm:
3475         (TestRunner::notifyDone):
3476         (TestRunner::forceImmediateCompletion):
3477         (TestRunner::queueLoad):
3478         * DumpRenderTree/win/DumpRenderTree.cpp:
3479         (runTest):
3480         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3481         (FrameLoadDelegate::processWork):
3482         (FrameLoadDelegate::locationChangeDone):
3483         * DumpRenderTree/win/TestRunnerWin.cpp:
3484         (TestRunner::notifyDone):
3485         (TestRunner::forceImmediateCompletion):
3486         (TestRunner::queueLoad):
3487
3488 2018-10-14  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
3489
3490         [JSC] Remove Option::useAsyncIterator
3491         https://bugs.webkit.org/show_bug.cgi?id=190567
3492
3493         Reviewed by Saam Barati.
3494
3495         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3496
3497 2018-10-15  Claudio Saavedra  <csaavedra@igalia.com>
3498
3499         [WPE] Silence a unused-parameter warning
3500
3501         Unreviewed.
3502         * MiniBrowser/wpe/main.cpp:
3503         (decidePermissionRequest):
3504
3505 2018-10-12  Guillaume Emont  <guijemont@igalia.com>
3506
3507         [Tools][webkitpy] fix handling of JSCTESTS_OPTIONS
3508         https://bugs.webkit.org/show_bug.cgi?id=190537
3509
3510         Reviewed by Alexey Proskuryakov.
3511
3512         In DeprecatedPort.run_javascriptcore_tests_command() JSCTESTS_OPTIONS
3513         needs to be split before adding it to the command since it is treated
3514         as a list of args.
3515
3516         * Scripts/webkitpy/common/config/ports.py:
3517         (DeprecatedPort.run_javascriptcore_tests_command):
3518
3519 2018-10-12  Wenson Hsieh  <wenson_hsieh@apple.com>
3520
3521         [iOS] Allow SPI clients to lay out at arbitrarily scaled sizes and scale to fit the view
3522         https://bugs.webkit.org/show_bug.cgi?id=190504
3523         <rdar://problem/45117760>
3524
3525         Reviewed by Tim Horton.
3526
3527         Teach UIScriptController to set WKWebView's view scale via a new `setViewScale` method, supported in WebKit2 on
3528         macOS and iOS.
3529
3530         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3531         (WTR::UIScriptController::setViewScale):
3532         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3533         (WTR::UIScriptController::setViewScale):
3534         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3535         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3536         (WTR::UIScriptController::setViewScale):
3537         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3538         * WebKitTestRunner/UIScriptControllerCocoa.mm: Added.
3539
3540         Add a new file for UIScriptController methods on Cocoa platforms.
3541
3542         (WTR::UIScriptController::setViewScale):
3543         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3544         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3545         (WTR::TestController::cocoaResetStateToConsistentValues):
3546
3547         Ensure that _viewScale is reset to 1 after running a layout test.
3548
3549 2018-10-12  Aakash Jain  <aakash_jain@apple.com>
3550
3551         [ews-build] Rename iOS-11-Simulator-Tests-EWS to iOS-11-Simulator-WK2-Tests-EWS
3552         https://bugs.webkit.org/show_bug.cgi?id=190536
3553
3554         Reviewed by Alexey Proskuryakov.
3555
3556         * BuildSlaveSupport/ews-build/config.json: Renamed iOS-11-Simulator-Tests-EWS to iOS-11-Simulator-WK2-Tests-EWS.
3557
3558 2018-10-11  Youenn Fablet  <youenn@apple.com>
3559
3560         IOS 12 - Service worker cache not shared when added to homescreen
3561         https://bugs.webkit.org/show_bug.cgi?id=190269
3562         <rdar://problem/45009961>
3563
3564         Reviewed by Alex Christensen.
3565
3566         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3567         Add test to ensure that CacheStorage use the default website data store parameters.
3568
3569 2018-10-11  Tim Horton  <timothy_horton@apple.com>
3570
3571         Clicking on bookmarklet crashes at NavigationState::willRecordNavigationSnapshot
3572         https://bugs.webkit.org/show_bug.cgi?id=190476
3573         <rdar://problem/32757191>
3574
3575         Reviewed by Megan Gardner.
3576
3577         * TestWebKitAPI/Tests/WebKitCocoa/SnapshotStore.mm:
3578         (TEST):
3579         Add a test that we don't crash.
3580
3581 2018-10-11  Tim Horton  <timothy_horton@apple.com>
3582
3583         REGRESSION (r237037): Cannot use webkit-patch upload, always fails with unknown 'cc_radar'
3584
3585         * Scripts/webkitpy/tool/steps/options.py:
3586         (Options):
3587         Fix the name of the variable that the --cc-radar option writes into.
3588
3589 2018-10-10  Dean Jackson  <dino@apple.com>
3590
3591         Add --cc-radar option to webkit-patch bug creation
3592         https://bugs.webkit.org/show_bug.cgi?id=190451
3593         <rdar://problem/45176671>
3594
3595         Reviewed by Antoine Quint.
3596
3597         Add a new command line option to automatically
3598         CC radar to new or updated bugs.
3599
3600         * Scripts/webkitpy/tool/commands/commandtest.py:
3601         (CommandsTest.assert_execute_outputs):
3602         * Scripts/webkitpy/tool/commands/upload.py:
3603         (CreateBug.__init__):
3604         (CreateBug.execute):
3605         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3606         (test_prepare_with_cc):
3607         (test_prepare_with_radar):
3608         (test_prepare_with_cc_and_radar):
3609         * Scripts/webkitpy/tool/steps/createbug.py:
3610         (CreateBug.options):
3611         (CreateBug.run):
3612         * Scripts/webkitpy/tool/steps/options.py:
3613         (Options):
3614
3615 2018-10-11  Claudio Saavedra  <csaavedra@igalia.com>
3616
3617         [GStreamer] Do not build gstgtk plugins
3618         https://bugs.webkit.org/show_bug.cgi?id=190463
3619
3620         Reviewed by Xabier Rodriguez-Calvar.
3621
3622         These plugins pull a GTK+ dependency that, at least in WPE,
3623         is unnecessary. The GTK+ port doesn't need it either, as far
3624         as I can tell.
3625
3626         * gstreamer/jhbuild.modules: Disable gstgtk plugins
3627
3628 2018-10-11  Alejandro G. Castro  <alex@igalia.com>
3629
3630         [GTK][WPE] Add mediaDevices.enumerateDevices support
3631         https://bugs.webkit.org/show_bug.cgi?id=185761
3632
3633         Reviewed by Youenn Fablet.
3634
3635         Added new API test for the mediaDevices.enumerateDevices:
3636         usermedia-enumeratedevices-permission-check. And a new API test
3637         for the WebsiteDataStore: testWebsiteDataDeviceIdHashSalt.
3638
3639         * MiniBrowser/gtk/main.c:
3640         (gotWebsiteDataCallback): Added a new section to the about:data
3641         webpage to include the information about the hash salt.
3642         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3643         (testWebViewUserMediaEnumerateDevicesPermissionCheck): Added the
3644         new test checking the enumerateDevices API when permission is
3645         denied and when permission is allowed for the origin.
3646         (beforeAll): Defined the new test.
3647         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
3648         (serverCallback): Register a new URI for the enumerateDevices.
3649         (testWebsiteDataConfiguration): Remove the hash salts from the
3650         directories.
3651         (testWebsiteDataDeviceIdHashSalt): New test cheking the
3652         enumerateDevices API.
3653         (beforeAll): Added the new test testWebsiteDataDeviceIdHashSalt to
3654         the init structure.
3655         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
3656         (WebViewTest::initializeWebView): Make sure the media-stream is
3657         activated in the webView.
3658
3659 2018-10-10  Fujii Hironori  <Hironori.Fujii@sony.com>
3660
3661         Add WinCairo to the flakiness dashboard
3662         https://bugs.webkit.org/show_bug.cgi?id=188345
3663
3664         Reviewed by Lucas Forschler.
3665
3666         * TestResultServer/static-dashboards/builders.jsonp: Regenerated by generate_builders_json.py.
3667         * TestResultServer/static-dashboards/flakiness_dashboard.js: Added a new platform 'WINCAIRO'.
3668
3669 2018-10-10  Dean Jackson  <dino@apple.com>
3670
3671         [WHSL -> MSL] Annotate semantics correctly in generated MSL
3672         https://bugs.webkit.org/show_bug.cgi?id=190452
3673         <rdar://problem/45178272>
3674
3675         Reviewed by Myles Maxfield.
3676
3677         Correctly label the appropriate semantics as [[position]]
3678         and [[color(N)]].
3679
3680         * WebGPUShadingLanguageRI/Metal/MSLBackend.js: Identify position
3681         and color attributes. Also use the semantic's index rather than
3682         a counter.
3683         * WebGPUShadingLanguageRI/Metal/WhlslToMsl.html: Use a <pre> for
3684         output, and only include the actual shader code.
3685
3686 2018-10-10  Ross Kirsling  <ross.kirsling@sony.com>
3687
3688         build-webkit --inspector-frontend shouldn't have a nonzero exit code
3689         https://bugs.webkit.org/show_bug.cgi?id=190430
3690
3691         Reviewed by Brian Burg.
3692
3693         * Scripts/webkitdirs.pm:
3694         (argumentsForConfiguration):
3695         --inspector-frontend should only be popped off of argv by determineIsInspectorFrontend;
3696         it shouldn't be re-inserted as a CLI option by argumentsForConfiguration.
3697
3698 2018-10-10  Tim Horton  <timothy_horton@apple.com>
3699
3700         Share more WKShareSheet code between macOS and iOS, and fix a few bugs
3701         https://bugs.webkit.org/show_bug.cgi?id=190420
3702
3703         Reviewed by Simon Fraser.
3704
3705         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3706         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
3707         (WTR::UIScriptController::invokeShareSheetWithResolution): Deleted.
3708         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3709         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
3710         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3711         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3712         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
3713         (WTR::UIScriptController::invokeShareSheetWithResolution): Deleted.
3714         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3715         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3716         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
3717         (WTR::UIScriptController::invokeShareSheetWithResolution): Deleted.
3718         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3719         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
3720         Change the testing mechanism for the share sheet such that we up-front
3721         set that it should immediately return with a particular state, instead
3722         of programmatically dismissing the sheet.
3723
3724         Otherwise, running the tests on macOS doesn't work, because we pop
3725         a context menu, which spins the runloop and prevents dismissal from
3726         going through.
3727
3728 2018-10-10  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
3729
3730         [JSC] Rename createXXX to tryCreateXXX if it can return RefPtr
3731         https://bugs.webkit.org/show_bug.cgi?id=190429
3732
3733         Reviewed by Saam Barati.
3734
3735         * TestWebKitAPI/Tests/WebCore/mac/GPUBuffer.mm:
3736         (TestWebKitAPI::TEST_F):
3737
3738 2018-10-10  Chris Dumez  <cdumez@apple.com>
3739
3740         Regression(PSON): Assertion hit under WebPageProxy::didNavigateWithNavigationData()
3741         https://bugs.webkit.org/show_bug.cgi?id=190418
3742         <rdar://problem/45059769>
3743
3744         Reviewed by Geoffrey Garen.
3745
3746         Add API test coverage.
3747
3748         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3749
3750 2018-10-10  Guillaume Emont  <guijemont@igalia.com>
3751
3752         [JSCOnly Add an armv7 JSCOnly EWS that runs tests
3753         https://bugs.webkit.org/show_bug.cgi?id=190191
3754
3755         Reviewed by Michael Catanzaro.
3756
3757         * QueueStatusServer/config/queues.py:
3758         * Scripts/webkitpy/common/config/ews.json:
3759         * Scripts/webkitpy/common/config/ports.py:
3760         (DeprecatedPort.run_javascriptcore_tests_command):
3761         Add the possibility to pass arguments to run-javascriptcore-tests with
3762         the JSCTESTS_OPTIONS environment variable
3763         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3764         (test_ews_name):
3765
3766
3767 2018-10-09  Guillaume Emont  <guijemont@igalia.com>
3768
3769         Allow run-javascriptcore-tests to distribute tests between devices
3770         https://bugs.webkit.org/show_bug.cgi?id=190190
3771
3772         Reviewed by Michael Catanzaro.
3773
3774         * Scripts/run-jsc-stress-tests:
3775         * Scripts/webkitruby/jsc-stress-test-writer-default.rb:
3776         * Scripts/webkitruby/jsc-stress-test-writer-ruby.rb:
3777
3778 2018-10-09  Dean Jackson  <dino@apple.com>
3779
3780         Update WHLSL to Metal tester with semantics
3781         https://bugs.webkit.org/show_bug.cgi?id=190416
3782         <rdar://problem/45145139>
3783
3784         Reviewed by Myles Maxfield.
3785
3786         A few small changes to the WHLSL to Metal tools:
3787         - Make it compile by adding some missing JS files :)
3788         - Add semantics to the default shader
3789         - Add FIXMEs to the other shaders
3790         - Create an in-browser test for the WHLSLToMetal codepath
3791         - Fix typos in the semantics checker
3792
3793         * WebGPUShadingLanguageRI/Checker.js:
3794         (Checker.prototype._checkSemantics.checkSemanticTypes):
3795         (Checker.prototype._checkSemantics.checkSemanticForShaderType):
3796         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m:
3797         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Default.whlsl:
3798         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Julia.whlsl:
3799         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Mandelbrot.whlsl:
3800         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL Tests.xcodeproj/project.pbxproj:
3801         * WebGPUShadingLanguageRI/Metal/WhlslToMsl.html: Added.
3802
3803 2018-10-09  Jer Noble  <jer.noble@apple.com>
3804
3805         Crash when closing WKWebView during enter fullscreen animation
3806         https://bugs.webkit.org/show_bug.cgi?id=190412
3807
3808         Reviewed by Brian Burg.
3809
3810         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3811         * TestWebKitAPI/Tests/WebKitCocoa/CloseWebViewDuringEnterFullscreen.mm: Added.
3812         (-[CloseWebViewDuringEnterFullscreenUIDelegate _webViewWillEnterFullscreen:]):
3813         (-[CloseWebViewDuringEnterFullscreenUIDelegate _webViewWillExitFullscreen:]):
3814         (TestWebKitAPI::TEST):
3815
3816 2018-10-09  Chris Dumez  <cdumez@apple.com>
3817
3818         Anchor target should be ignored on activation when the download attribute is set
3819         https://bugs.webkit.org/show_bug.cgi?id=190408
3820
3821         Reviewed by Geoffrey Garen.
3822
3823         Update WebKitTestRunner to block popups by default and add support for testRunner.setCanOpenWindows()
3824         for tests that need popups. This aligns WebKitTestRunner with DumpRenderTree and allows testing
3825         popup blocking.
3826
3827         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3828         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3829         (WTR::TestRunner::setCanOpenWindows):
3830         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3831         * WebKitTestRunner/TestController.cpp:
3832         (WTR::TestController::createOtherPage):
3833         * WebKitTestRunner/TestController.h:
3834         * WebKitTestRunner/TestInvocation.cpp:
3835         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3836         * WebKitTestRunner/TestInvocation.h:
3837
3838 2018-10-09  Jer Noble  <jer.noble@apple.com>
3839
3840         WebDriver: thrown ObjC exception under -[WKFullScreenWindowController windowDidFailToEnterFullScreen:] when session is terminated
3841         https://bugs.webkit.org/show_bug.cgi?id=190098
3842         <rdar://problem/42822671>
3843
3844         Reviewed by Brian Burg.
3845
3846         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3847         * TestWebKitAPI/Tests/WebKitCocoa/CloseWebViewAfterEnterFullscreen.mm: Added.
3848         (-[CloseWebViewAfterEnterFullscreenUIDelegate _webViewDidEnterFullscreen:]):
3849         (-[CloseWebViewAfterEnterFullscreenUIDelegate _webViewDidExitFullscreen:]):
3850         (TestWebKitAPI::TEST):
3851
3852 2018-10-09  Jiewen Tan  <jiewen_tan@apple.com>
3853
3854         [WebAuthN] Import CTAP HID message and packet structure from Chromium
3855         https://bugs.webkit.org/show_bug.cgi?id=189289
3856         <rdar://problem/44120310>
3857
3858         Reviewed by Brent Fulgham.
3859
3860         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3861         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp: Added.
3862         (TestWebKitAPI::TEST):
3863
3864 2018-10-09  Chris Dumez  <cdumez@apple.com>
3865
3866         PSON: Doing a cross-site navigation via the URL bar does not swap process on iOS
3867         https://bugs.webkit.org/show_bug.cgi?id=190378
3868         <rdar://problem/45059466>
3869
3870         Reviewed by Geoffrey Garen.
3871
3872         Add API test coverage.
3873
3874         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3875
3876 2018-10-09  Jer Noble  <jer.noble@apple.com>
3877
3878         ISOTrackEncryptionBox returns incorrect defaultKeyID
3879         https://bugs.webkit.org/show_bug.cgi?id=190368
3880
3881         Reviewed by Eric Carlson.
3882
3883         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3884         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp: Added.
3885         (TestWebKitAPI::TEST):
3886
3887 2018-10-09  Philippe Normand  <pnormand@igalia.com>
3888
3889         [JHBuild] Update to GStreamer 1.14.4
3890         https://bugs.webkit.org/show_bug.cgi?id=190395
3891
3892         Reviewed by Xabier Rodriguez-Calvar.
3893
3894         * gstreamer/jhbuild.modules: Remove patches merged in 1.14.4 and bump version of GStreamer modules.
3895         * gstreamer/patches/gst-plugins-good-0007-matroskademux-Allow-Matroska-headers-to-be-read-more.patch: Removed.
3896         * gstreamer/patches/gst-plugins-good-0008-matroskademux-Refactor-track-parsing-out-from-adding.patch: Removed.
3897         * gstreamer/patches/gst-plugins-good-0009-matroskademux-Parse-successive-Tracks-elements.patch: Removed.
3898         * gstreamer/patches/gst-plugins-good-0010-matroskademux-Emit-no-more-pads-after-parsing-Tracks.patch: Removed.
3899
3900 2018-10-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3901
3902         [macOS] API test DragAndDropTests.DropColor is failing on macOS 10.12
3903         https://bugs.webkit.org/show_bug.cgi?id=190386
3904
3905         Reviewed by Ryosuke Niwa.
3906
3907         Unlike macOS 10.13 and 10.14, -[NSColor redColor] is not equivalent to a fully red color in sRGB on macOS 10.12.
3908         Fix the test by dragging and dropping an NSColor that is equivalent to rgb(255, 0, 0) on all relevant versions
3909         of macOS.
3910
3911         * TestWebKitAPI/Tests/mac/DragAndDropTestsMac.mm:
3912         (TEST):
3913
3914 2018-10-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3915
3916         [Cocoa] [WK2] Add support for text alignment and text lists in font attributes
3917         https://bugs.webkit.org/show_bug.cgi?id=190342
3918         <rdar://problem/44767118>
3919
3920         Reviewed by Tim Horton.
3921
3922         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3923         * TestWebKitAPI/Tests/WebKitCocoa/FontAttributes.mm:
3924
3925         Add a new API test to check that the font attributes dictionary contains the correct NSParagraphStyles when
3926         moving the selection around text inside nested list elements.
3927
3928         (TestWebKitAPI::checkParagraphStyles):
3929
3930         Add a new helper to check an NSParagraphStyle against expected results.
3931
3932         (TestWebKitAPI::webViewForTestingFontAttributes):
3933
3934         Allow each test to pass in the name of the test page to load.
3935
3936         (TestWebKitAPI::TEST):
3937         * TestWebKitAPI/Tests/WebKitCocoa/nested-lists.html: Added.
3938
3939         Add a new test page that contains text enclosed in multiple levels of unordered and ordered lists.
3940
3941         * TestWebKitAPI/Tests/WebKitCocoa/rich-text-attributes.html:
3942
3943         Remove `text-align: left` from one of these elements, to test for NSTextAlignmentNatural.
3944
3945 2018-10-08  Justin Fan  <justin_fan@apple.com>
3946
3947         WebGPU: Rename old WebGPU prototype to WebMetal
3948         https://bugs.webkit.org/show_bug.cgi?id=190325
3949         <rdar://problem/44990443>
3950
3951         Reviewed by Dean Jackson.
3952
3953         Rename WebGPU prototype files to WebMetal in preparation for implementing the new (Oct 2018) WebGPU interface.
3954
3955         * DumpRenderTree/mac/DumpRenderTree.mm:
3956         (enableExperimentalFeatures):
3957         (resetWebPreferencesToConsistentValues):
3958         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3959         * TestWebKitAPI/Tests/WebCore/mac/GPUBuffer.mm:
3960         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm:
3961         * TestWebKitAPI/Tests/WebCore/mac/GPUDevice.mm:
3962         * TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm:
3963         * TestWebKitAPI/Tests/WebCore/mac/GPULibrary.mm:
3964         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3965         (WTR::InjectedBundle::beginTesting):
3966         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3967         (WTR::TestRunner::setWebMetalEnabled):
3968         (WTR::TestRunner::setWebGPUEnabled): Deleted.
3969         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3970
3971 2018-10-08  Commit Queue  <commit-queue@webkit.org>
3972
3973         Unreviewed, rolling out r236941.
3974         https://bugs.webkit.org/show_bug.cgi?id=190374
3975
3976         Causing API test failures in new test (Requested by jernoble
3977         on #webkit).
3978
3979         Reverted changeset:
3980
3981         "ISOTrackEncryptionBox returns incorrect defaultKeyID"
3982         https://bugs.webkit.org/show_bug.cgi?id=190368
3983         https://trac.webkit.org/changeset/236941
3984
3985 2018-10-08  Aditya Keerthi  <akeerthi@apple.com>
3986
3987         Make <input type=color> a runtime enabled (on-by-default) feature
3988         https://bugs.webkit.org/show_bug.cgi?id=189162
3989
3990         Reviewed by Wenson Hsieh and Tim Horton.
3991
3992         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3993
3994 2018-10-08  Jer Noble  <jer.noble@apple.com>
3995
3996         ISOTrackEncryptionBox returns incorrect defaultKeyID
3997         https://bugs.webkit.org/show_bug.cgi?id=190368
3998
3999         Reviewed by Eric Carlson.
4000
4001         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4002         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp: Added.
4003         (TestWebKitAPI::TEST):
4004
4005 2018-10-08  Alex Christensen  <achristensen@webkit.org>
4006
4007         Remove WKBundleFileHandleRef
4008         https://bugs.webkit.org/show_bug.cgi?id=190360
4009
4010         Reviewed by Tim Horton.
4011
4012         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4013         * TestWebKitAPI/Tests/WebKit/WKBundleFileHandle.cpp: Removed.
4014         * TestWebKitAPI/Tests/WebKit/WKBundleFileHandle_Bundle.cpp: Removed.
4015
4016 2018-10-08  Dan Bernstein  <mitz@apple.com>
4017
4018         Tools part of [Xcode] Update some build settings as recommended by Xcode 10
4019         https://bugs.webkit.org/show_bug.cgi?id=190250
4020
4021         Reviewed by Anders Carlsson.
4022
4023         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
4024
4025         * DumpRenderTree/mac/Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA,
4026           CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS,
4027           CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
4028
4029         * DumpRenderTree/mac/DumpRenderTreeMac.h: Addressed the strict prototype warning.
4030
4031         * DumpRenderTree/mac/EditingDelegate.mm: Suppressed the deprecated implementations warning
4032           around deprecated methods or categories on deprecated classes.
4033         * DumpRenderTree/mac/FrameLoadDelegate.mm: Ditto.
4034         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
4035         * DumpRenderTree/mac/TestRunnerMac.mm: Ditto.
4036         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]):
4037
4038         * MiniBrowser/Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA,
4039           CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS,
4040           CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
4041
4042         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
4043
4044         * MiniBrowser/mac/AppDelegate.h: Addressed the strict prototypes warning.
4045         * MiniBrowser/mac/WK2BrowserWindowController.m: Removed an unused #import to avoid having to
4046           address the fact that many of the WebKit C SPI headers trigger the strict prototypes warning.
4047
4048         * MobileMiniBrowser/Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA,
4049           CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_SUSPICIOUS_MOVE (by fixing a typo),
4050           CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF.
4051
4052         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj: Let Xcode update
4053           LastUpgradeCheck and remove the .xcconfig files from the Copy Bundle Resources build phase.
4054
4055         * TestWebKitAPI/Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA,
4056           CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS,
4057           CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
4058           Made the WebKit headers be treated as system headers to avoid dealing with the fact that
4059           many C SPI headers trigger the strict prototypes warning.
4060
4061         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
4062
4063         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
4064         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
4065         (-[BlobDownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
4066         (-[UIDownloadAsFileTestDelegate _webView:contextMenu:forElement:]):
4067         (-[RedirectedDownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
4068         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4069         (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
4070         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
4071         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
4072         (-[AudioSessionCategoryUIWebViewDelegate webView:shouldStartLoadWithRequest:navigationType:]):
4073         * TestWebKitAPI/Tests/WebKitLegacy/ios/SnapshotViaRenderInContext.mm:
4074         (-[RenderInContextWebViewDelegate webViewDidFinishLoad:]):
4075         (-[RenderInContextWebViewDelegate webView:didFailLoadWithError:]):
4076         * TestWebKitAPI/Tests/ios/SetTimeoutFunction.mm:
4077         (-[SetTimeoutFunctionWebViewDelegate webViewDidFinishLoad:]):
4078         (-[SetTimeoutFunctionWebViewDelegate webView:didFailLoadWithError:]):
4079         (-[SetTimeoutFunctionWebViewDelegate webView:shouldStartLoadWithRequest:navigationType:]):
4080         * TestWebKitAPI/Tests/mac/LegacyDragAndDropTests.mm:
4081         (-[DragInfo namesOfPromisedFilesDroppedAtDestination:]):
4082         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
4083         (-[DragAndDropTestWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]):
4084         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m:
4085         (-[SyntheticBackingScaleFactorWindow IGNORE_WARNINGS_END]):
4086         (-[SyntheticBackingScaleFactorWindow userSpaceScaleFactor]): Deleted.
4087         * TestWebKitAPI/mac/TestDraggingInfo.mm:
4088         (-[TestDraggingInfo namesOfPromisedFilesDroppedAtDestination:]):
4089
4090         In all of the above, suppressed the deprecated implementations warning where needed.
4091
4092         * WebKitTestRunner/Configurations/Base.xcconfig: Enabled ENABLE_STRICT_OBJC_MSGSEND,
4093           CLANG_WARN_BOOL_CONVERSION, CLANG_WARN_COMMA, CLANG_WARN_CONSTANT_CONVERSION,
4094           CLANG_WARN_EMPTY_BODY, CLANG_WARN_ENUM_CONVERSION, CLANG_WARN_INT_CONVERSION,
4095           CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_UNREACHABLE_CODE, CLANG_WARN__DUPLICATE_METHOD_MATCH,
4096           GCC_WARN_UNDECLARED_SELECTOR, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
4097           CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS,
4098           and GCC_NO_COMMON_BLOCKS.
4099
4100         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
4101
4102         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
4103         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]): Suppressed
4104           the deprecated implementations warning.
4105
4106         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
4107         (WTR::UIScriptController::replaceTextAtRange): Addressed an int-conversion warning.
4108
4109 2018-10-07  Yacine Bandou  <yacine.bandou@softathome.com>
4110
4111         [GStreamer][EME][webm] Add the WebM encrypted content support in matroskademux
4112         https://bugs.webkit.org/show_bug.cgi?id=189238
4113
4114         Reviewed by Xabier Rodriguez-Calvar.
4115
4116         Modifications on GStreamer, tracked in GStreamer bugzilla:
4117         https://bugzilla.gnome.org/show_bug.cgi?id=797231
4118         https://bugzilla.gnome.org/show_bug.cgi?id=765275
4119
4120         * gstreamer/jhbuild.modules: Add new patches.
4121         * gstreamer/patches/gstreamer-0001-protection-Add-a-new-definition-for-unspecified-syst.patch: Added.
4122         * gstreamer/patches/gstreamer-0002-protection-Fix-the-string-to-define-unspecified-syst.patch: Added.
4123         * gstreamer/patches/gst-plugins-good-0011-matroska-Add-the-WebM-encrypted-content-support-in-m.patch: Added.
4124         * gstreamer/patches/gst-plugins-good-0012-matroskdemux-do-not-use-MapInfo.data-after-unmapping.patch: Added.
4125
4126 2018-10-06  Dan Bernstein  <mitz@apple.com>
4127
4128         [Xcode] Never build yasm with ASAN
4129         https://bugs.webkit.org/show_bug.cgi?id=190327
4130
4131         Reviewed by Youenn Fablet.
4132
4133         * asan/asan.xcconfig: Allow targets to opt out of building with ASAN by setting
4134           the WK_ASAN_DISALLOWED build setting to YES (or, actually, anything other than NO or unset).
4135
4136 2018-10-05  Chris Dumez  <cdumez@apple.com>
4137
4138         Regression(r236862): Crash under DOMWindowExtension::willDetachGlobalObjectFromFrame()
4139         https://bugs.webkit.org/show_bug.cgi?id=190320
4140         <rdar://problem/45044814>
4141
4142         Reviewed by Geoffrey Garen.
4143
4144         Add API test coverage.
4145
4146         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
4147         (TestWebKitAPI::TEST):
4148         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
4149         (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyGlobalObjectForDOMWindowExtension):
4150
4151 2018-10-03  Jer Noble  <jer.noble@apple.com>
4152
4153         Add support for reporting "display composited video frames" through the VideoPlaybackQuality object.
4154         https://bugs.webkit.org/show_bug.cgi?id=190266
4155
4156         Reviewed by Eric Carlson.
4157
4158         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4159         * TestWebKitAPI/Tests/WebKitCocoa/VideoQualityDisplayCompositing.mm: Added.
4160         (TestWebKitAPI::TEST):
4161
4162 2018-10-05  Ryan Haddad  <ryanhaddad@apple.com>
4163
4164         Unreviewed, rolling out r236866.
4165
4166         Breaks internal builds.
4167
4168         Reverted changeset:
4169
4170         "Add support for reporting "display composited video frames"
4171         through the VideoPlaybackQuality object."
4172         https://bugs.webkit.org/show_bug.cgi?id=190266
4173         https://trac.webkit.org/changeset/236866
4174
4175 2018-10-05  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
4176
4177         [WPE][JSC] Use Unified Sources for Platform-specific sources
4178         https://bugs.webkit.org/show_bug.cgi?id=190300
4179
4180         Reviewed by Yusuke Suzuki.
4181
4182         Currently the GTK port already used Unified Sources with the same source files.
4183         As WPE has conditional code using gmodule, we need to add GLIB_GMODULE_LIBRARIES
4184         to the list of libraries to link with.
4185
4186         * TestWebKitAPI/PlatformWPE.cmake:
4187
4188 2018-10-05  Zach Li  <zachli@apple.com>
4189
4190         Expose whether WKWebProcessPlugInNodeHandle is a select element to clients
4191         https://bugs.webkit.org/show_bug.cgi?id=190302
4192         <rdar://problem/45031469>
4193
4194         Reviewed by Tim Horton.
4195
4196         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4197         * TestWebKitAPI/Tests/WebKitCocoa/InjectedBundleNodeHandleIsSelectElement.mm: Added.
4198         (-[InjectedBundleNodeHandleIsSelectElement verifySelectElementForHTMLElementTag:document:jsContext:expectedResult:failedElementTags:]):
4199         (-[InjectedBundleNodeHandleIsSelectElement webProcessPlugIn:didCreateBrowserContextController:]):
4200         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
4201         (-[InjectedBundleNodeHandleIsSelectElementDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
4202         (TEST):
4203
4204 2018-10-04  Wenson Hsieh  <wenson_hsieh@apple.com>
4205
4206         [iOS] [WK2] Expose some more editing SPI on WKWebView
4207         https://bugs.webkit.org/show_bug.cgi?id=190232
4208         <rdar://problem/44963368>
4209
4210         Reviewed by Tim Horton.
4211
4212         Adds new API tests to exercise the new SPIs.
4213
4214         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4215         * TestWebKitAPI/Tests/ios/WKWebViewEditActions.mm: Added.
4216         (-[TestWKWebView querySelectorExists:]):
4217         (TestWebKitAPI::webViewForEditActionTesting):
4218         (TestWebKitAPI::TEST):
4219         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
4220         (-[TestWKWebView collapseToStart]): Deleted.
4221         (-[TestWKWebView collapseToEnd]): Deleted.
4222         (-[TestWKWebView stylePropertyAtSelectionStart:]): Deleted.
4223         (-[TestWKWebView stylePropertyAtSelectionEnd:]): Deleted.
4224         * TestWebKitAPI/cocoa/TestWKWebView.h:
4225         * TestWebKitAPI/cocoa/TestWKWebView.mm:
4226         (-[TestWKWebView stylePropertyAtSelectionStart:]):
4227         (-[TestWKWebView stylePropertyAtSelectionEnd:]):
4228         (-[TestWKWebView collapseToStart]):
4229         (-[TestWKWebView collapseToEnd]):
4230
4231         Pull some common testing helpers out of NSFontManager and into TestWKWebView.
4232
4233 2018-10-04  Jer Noble  <jer.noble@apple.com>
4234
4235         Add support for reporting "display composited video frames" through the VideoPlaybackQuality object.
4236         https://bugs.webkit.org/show_bug.cgi?id=190266
4237
4238         Reviewed by Eric Carlson.
4239
4240         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4241         * TestWebKitAPI/Tests/WebKitCocoa/VideoQualityDisplayCompositing.mm: Added.
4242         (TestWebKitAPI::TEST):
4243
4244 2018-10-04  Wenson Hsieh  <wenson_hsieh@apple.com>
4245
4246         [Cocoa] Add SPI to expose typing attributes at the current selection on WKWebView
4247         https://bugs.webkit.org/show_bug.cgi?id=190119
4248         <rdar://problem/44767062>
4249
4250         Reviewed by Tim Horton.
4251
4252         Add a new API test that loads a document containing various rich text styles. This test moves the selection
4253         around the document and checks the last set of font attributes received via the new UI delegate hook.
4254
4255         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4256         * TestWebKitAPI/Tests/WebKitCocoa/FontAttributes.mm: Added.
4257         (-[FontAttributesListener _webView:didChangeFontAttributes:]):
4258         (-[FontAttributesListener lastFontAttributes]):
4259         (-[TestWKWebView selectElementWithIdentifier:]):
4260         (-[TestWKWebView fontAttributesAfterNextPresentationUpdate]):
4261         (ColorExpectation::ColorExpectation):
4262         (ShadowExpectation::ShadowExpectation):
4263         (checkColor):
4264         (checkShadow):
4265         (checkFont):
4266         (webViewForTestingFontAttributes):