2fd4eb0bf58d2a0e9e865683fdadc191e6abfd41
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-21  David Kilzer  <ddkilzer@apple.com>
2
3         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
4         <https://webkit.org/b/194761>
5
6         Reviewed by Myles Maxfield.
7
8         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
9         (WTR::activateSystemCoreWebFonts): Log `error` to console if
10         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
11         to use ARC-compliant cast.
12         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
13         ARC-compliant cast.
14         (WTR::installFakeHelvetica): Log `error` to console if
15         CTFontManagerRegisterFontsForURL() fails, but only on supported
16         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
17         Call CFRelease() on `error` to fix the leak.  Update to use
18         ARC-compliant cast.
19         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
20         cast.
21
22 2019-02-21  Chris Dumez  <cdumez@apple.com>
23
24         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
25         https://bugs.webkit.org/show_bug.cgi?id=194481
26
27         Reviewed by Alex Christensen.
28
29         Give the processes a chance to shutdown and wait until we reached the expected number
30         of processes.
31
32         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
33
34 2019-02-21  Tim Horton  <timothy_horton@apple.com>
35
36         Fix the macOS build
37
38         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
39
40 2019-02-21  Tim Horton  <timothy_horton@apple.com>
41
42         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
43
44         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
45         I am a backwards.
46
47 2019-02-21  Tim Horton  <timothy_horton@apple.com>
48
49         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
50
51         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
52         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
53         We could force on UI-side compositing, but I feel like the test might be more
54         valuable exercising the normal path on each platform (though the original
55         bug was also UI-side specific). Though we can't validate that the overlay
56         layer was installed successfully, there are layout tests that do that.
57
58 2019-02-21  Tim Horton  <timothy_horton@apple.com>
59
60         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
61         https://bugs.webkit.org/show_bug.cgi?id=194845
62         <rdar://problem/47944579>
63
64         Reviewed by Antti Koivisto.
65
66         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
67         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
68
69 2019-02-21  Zalan Bujtas  <zalan@apple.com>
70
71         [LFC][Floats] Add support for placing formatting roots in-between floats.
72         https://bugs.webkit.org/show_bug.cgi?id=194902
73
74         Reviewed by Antti Koivisto.
75
76         * LayoutReloaded/misc/LFC-passing-tests.txt:
77
78 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
79
80         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
81         https://bugs.webkit.org/show_bug.cgi?id=194901
82
83         Unreviewed build fix.
84
85         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
86         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
87         WPEBackend-fdo-0.1 as library name.
88
89 2019-02-21  Rob Buis  <rbuis@igalia.com>
90
91         Update MIME type parser
92         https://bugs.webkit.org/show_bug.cgi?id=180526
93
94         Reviewed by Darin Adler.
95
96         Add tests involving leading and trailing whitespace, non-token
97         characters and quoted strings.
98
99         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
100         (TestWebKitAPI::TEST):
101
102 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
103
104         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
105         https://bugs.webkit.org/show_bug.cgi?id=194884
106
107         Reviewed by Michael Catanzaro.
108
109         * PlatformWin.cmake:
110
111 2019-02-20  Chris Dumez  <cdumez@apple.com>
112
113         Add API test for <rdar://problem/47471222>
114         https://bugs.webkit.org/show_bug.cgi?id=194847
115
116         Reviewed by Alex Christensen.
117
118         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
119
120 2019-02-20  Chris Dumez  <cdumez@apple.com>
121
122         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
123         https://bugs.webkit.org/show_bug.cgi?id=194872
124         <rdar://problem/47924500>
125
126         Reviewed by Alex Christensen.
127
128         Add API test coverage.
129
130         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
131
132 2019-02-20  Jer Noble  <jer.noble@apple.com>
133
134         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
135         https://bugs.webkit.org/show_bug.cgi?id=191332
136
137         Reviewed by Dean Jackson.
138
139         * Scripts/git-is-in-range: Added.
140
141 2019-02-20  Andy Estes  <aestes@apple.com>
142
143         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
144         https://bugs.webkit.org/show_bug.cgi?id=194869
145
146         Rubber-stamped by Jer Noble.
147
148         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
149         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
150         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
151         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
152         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
153         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
154
155 2019-02-20  Chris Dumez  <cdumez@apple.com>
156
157         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
158         https://bugs.webkit.org/show_bug.cgi?id=194857
159         <rdar://problem/47759323>
160
161         Reviewed by Alex Christensen.
162
163         Add API test coverage.
164
165         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
166
167 2019-02-20  Chris Dumez  <cdumez@apple.com>
168
169         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
170         https://bugs.webkit.org/show_bug.cgi?id=194829
171         <rdar://problem/47889906>
172
173         Reviewed by Alexey Proskuryakov.
174
175         Every time the TestOptions were changing we were creating both a new Web view and
176         a new WKContext, which would start a new Network process. In most cases, we only
177         need to contruct a new Web view and we do can keep reusing the same WKContext.
178         This patch implements this optimization and thus avoids spinning a lot of new
179         Network processes while running the layout tests.
180
181         * WebKitTestRunner/TestController.cpp:
182         (WTR::TestController::generateContextConfiguration const):
183         (WTR::TestController::generatePageConfiguration):
184         (WTR::TestController::createWebViewWithOptions):
185         (WTR::TestController::resetPreferencesToConsistentValues):
186         (WTR::updateTestOptionsFromTestHeader):
187         * WebKitTestRunner/TestController.h:
188         * WebKitTestRunner/TestOptions.h:
189         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
190         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
191         (WTR::TestOptions::hasSameInitializationOptions const):
192         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
193         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
194         (WTR::TestController::platformAddTestOptions const):
195
196 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
197
198         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
199         https://bugs.webkit.org/show_bug.cgi?id=167941
200
201         Reviewed by Carlos Garcia Campos.
202
203         * MiniBrowser/gtk/main.c:
204         (filterSavedCallback): Added.
205         (main): Support loading a JSON rule set file for content filtering.
206         * MiniBrowser/wpe/main.cpp:
207         (filterSavedCallback): Added.
208         (main): Support loading a JSON rule set file for content filtering.
209         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
210         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
211         (WTF::derefGPtr): Ditto.
212         (testEmptyStore):
213         (testSaveInvalidFilter):
214         (testSaveLoadFilter):
215         (testSavedFilterIdentifierMatch):
216         (testRemoveFilter):
217         (testSaveMultipleFilters):
218         (testSaveFilterFromFile):
219         (testFilterPersistence):
220         (beforeAll):
221         (afterAll):
222         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
223         (removeOldInjectedContentAndResetLists): Also reset content filters.
224         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
225         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
226         the element affected by the style sheet.
227         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
228         and returns it to be used by tests.
229         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
230         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
231         (serverCallback): Add support for serving a CSS style sheet for testing.
232         (beforeAll): Add call to testUserContentManagerContentFilter().
233         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
234
235 2019-02-19  Keith Rollin  <krollin@apple.com>
236
237         Add timing information to build output
238         https://bugs.webkit.org/show_bug.cgi?id=194839
239         <rdar://problem/48219609>
240
241         Reviewed by Alexey Proskuryakov.
242
243         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
244         emit each project's build time to its output. E.g.,
245
246             ** BUILD SUCCEEDED ** [0.132 sec]
247
248         * Scripts/webkitdirs.pm:
249         (XcodeOptions):
250
251 2019-02-19  Truitt Savell  <tsavell@apple.com>
252
253         Unreviewed, rolling out r241784.
254
255         Broke all OpenSource builds.
256
257         Reverted changeset:
258
259         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
260         instances view"
261         https://bugs.webkit.org/show_bug.cgi?id=172848
262         https://trac.webkit.org/changeset/241784
263
264 2019-02-19  Zalan Bujtas  <zalan@apple.com>
265
266         [LFC][Floats] Remove redundant intersecting logic
267         https://bugs.webkit.org/show_bug.cgi?id=194804
268
269         Reviewed by Antti Koivisto.
270
271         * LayoutReloaded/misc/LFC-passing-tests.txt:
272
273 2019-02-19  Dean Jackson  <dino@apple.com>
274
275         Clean-up output from generate-xcfilelists so it can be filtered
276         https://bugs.webkit.org/show_bug.cgi?id=194795
277
278         Reviewed by Joseph Pecoraro (and Keith Rollin).
279
280         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
281         make a slight tweak to filter-build-webkit so such lines are marked
282         as plain.
283
284         * Scripts/filter-build-webkit:
285         * Scripts/generate-xcfilelists:
286
287 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
288
289         pytest is not correctly auto-installed
290         https://bugs.webkit.org/show_bug.cgi?id=194707
291
292         Reviewed by Carlos Garcia Campos.
293
294         * Scripts/webkitpy/thirdparty/__init__.py:
295         (AutoinstallImportHook._install_pytest):
296
297 2019-02-18  Chris Dumez  <cdumez@apple.com>
298
299         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
300         https://bugs.webkit.org/show_bug.cgi?id=194797
301         <rdar://problem/48055151>
302
303         Reviewed by Geoffrey Garen.
304
305         Add API test coverage.
306
307         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
308
309 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
310
311         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
312         https://bugs.webkit.org/show_bug.cgi?id=194670
313         <rdar://problem/39066529>
314
315         Reviewed by Tim Horton.
316
317         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
318         pasted in an editable area as attachment elements.
319
320         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
321         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
322         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
323         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
324         (TestWebKitAPI::TEST):
325         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
326         (WTR::InjectedBundlePage::InjectedBundlePage):
327
328 2019-02-18  Alex Christensen  <achristensen@webkit.org>
329
330         Fix API test after r241728
331        ​https://bugs.webkit.org/show_bug.cgi?id=194723
332
333         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
334         (TEST):
335         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
336
337 2019-02-18  Daniel Bates  <dabates@apple.com>
338
339         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
340         https://bugs.webkit.org/show_bug.cgi?id=192824
341         <rdar://problem/47100332>
342
343         Reviewed by Wenson Hsieh.
344
345         Fix a bug where the wrong usage code was used for F13 thru F24.
346
347         * WebKitTestRunner/ios/HIDEventGenerator.mm:
348         (keyCodeForDOMFunctionKey):
349
350 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
351
352         Bytecode cache should a have a boot-specific validation
353         https://bugs.webkit.org/show_bug.cgi?id=194769
354         <rdar://problem/48149509>
355
356         Reviewed by Keith Miller.
357
358         Add test for WTF::bootSessionUUIDString()
359
360         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
361         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
362         (TEST):
363
364 2019-02-18  Alex Christensen  <achristensen@webkit.org>
365
366         Disable safe browsing in WKWebView and remove its WKPreferences API
367         https://bugs.webkit.org/show_bug.cgi?id=194723
368         <rdar://problem/48122993>
369
370         Reviewed by Geoffrey Garen.
371
372         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
373         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
374         (TEST):
375         (safeBrowsingView):
376         Make tests use SPI instead of API.
377
378 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
379
380         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
381         https://bugs.webkit.org/show_bug.cgi?id=194586
382
383         Reviewed by Ross Kirsling.
384
385         * DumpRenderTree/win/DumpRenderTree.cpp:
386         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
387         * Scripts/webkitpy/port/driver.py:
388         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
389
390 2019-02-17  David Kilzer  <ddkilzer@apple.com>
391
392         Unreviewed, rolling out r241620.
393
394         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
395         (Requested by ddkilzer on #webkit.)
396
397         Reverted changeset:
398
399         "[WTF] Add environment variable helpers"
400         https://bugs.webkit.org/show_bug.cgi?id=192405
401         https://trac.webkit.org/changeset/241620
402
403 2019-02-16  Zalan Bujtas  <zalan@apple.com>
404
405         [LFC] RenderImage's default intrinsic size is 0.
406         https://bugs.webkit.org/show_bug.cgi?id=194745
407
408         Reviewed by Antti Koivisto.
409
410         * LayoutReloaded/misc/LFC-passing-tests.txt:
411
412 2019-02-16  Zalan Bujtas  <zalan@apple.com>
413
414         [LFC][BFC] Add support for block replaced intrinsic width.
415         https://bugs.webkit.org/show_bug.cgi?id=194705
416
417         Reviewed by Simon Fraser.
418
419         * LayoutReloaded/misc/LFC-passing-tests.txt:
420
421 2019-02-16  Zalan Bujtas  <zalan@apple.com>
422
423         [LFC] Apply min/max width constraints to preferred width computation
424         https://bugs.webkit.org/show_bug.cgi?id=194739
425
426         Reviewed by Simon Fraser.
427
428         * LayoutReloaded/misc/LFC-passing-tests.txt:
429
430 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
431
432         [WTF] Add environment variable helpers
433         https://bugs.webkit.org/show_bug.cgi?id=192405
434
435         Reviewed by Michael Catanzaro.
436
437         * DumpRenderTree/mac/DumpRenderTree.mm:
438         (libraryPathForDumpRenderTree):
439         * DumpRenderTree/win/DumpRenderTree.cpp:
440         (libraryPathForDumpRenderTree):
441         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
442         (setUpIOSLayoutTestCommunication):
443         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
444         (beforeAll):
445         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
446         (main):
447         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
448         (WebKitTestBus::run):
449         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
450         (WTR::getOutputDir):
451         (WTR::initializeFontConfigSetting):
452         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
453         (WTR::InjectedBundle::platformInitialize):
454         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
455         (WTR::topLevelPath):
456         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
457         (WTR::topLevelPath):
458         (WTR::getOutputDir):
459         (WTR::activateFonts):
460         * WebKitTestRunner/TestController.cpp:
461         (WTR::TestController::libraryPathForTesting):
462         (WTR::TestController::generateContextConfiguration const):
463         (WTR::TestController::generatePageConfiguration):
464         (WTR::TestController::decideDestinationWithSuggestedFilename):
465         (WTR::TestController::platformAdjustContext):
466         * WebKitTestRunner/TestController.h:
467         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
468         (WTR::TestController::cocoaPlatformInitialize):
469         (WTR::TestController::platformAdjustContext):
470         * WebKitTestRunner/gtk/main.cpp:
471         (main):
472         * WebKitTestRunner/mac/TestControllerMac.mm:
473         (WTR::TestController::configureContentExtensionForTest):
474         * WebKitTestRunner/wpe/main.cpp:
475         (main):
476         Utilize WTF::Environment where possible.
477
478 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
479
480         [iOS] WKWebView callout bar is missing Change Writing Direction item
481         https://bugs.webkit.org/show_bug.cgi?id=190015
482         <rdar://problem/44810366>
483
484         Reviewed by Tim Horton.
485
486         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
487         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
488
489         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
490         (TestWebKitAPI::TEST):
491
492 2019-02-15  Chris Dumez  <cdumez@apple.com>
493
494         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
495         https://bugs.webkit.org/show_bug.cgi?id=194717
496         <rdar://problem/47884404>
497
498         Reviewed by Brady Eidson.
499
500         Add API test coverage.
501
502         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
503
504 2019-02-15  Youenn Fablet  <youenn@apple.com>
505
506         Make navigator.mediaDevices SecureContext
507         https://bugs.webkit.org/show_bug.cgi?id=194666
508
509         Reviewed by Eric Carlson.
510
511         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
512         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
513         (TEST_F):
514
515 2019-02-15  Brian Burg  <bburg@apple.com>
516
517         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
518         https://bugs.webkit.org/show_bug.cgi?id=194411
519         <rdar://problem/47787614>
520
521         Reviewed by Joseph Pecoraro.
522
523         Remove unnecessary soft linking macro usage.
524
525         * DumpRenderTree/mac/TestRunnerMac.mm:
526         (TestRunner::inspectorTestStubURL):
527         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
528         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
529         (WTR::TestRunner::inspectorTestStubURL):
530
531 2019-02-15  Commit Queue  <commit-queue@webkit.org>
532
533         Unreviewed, rolling out r241559 and r241566.
534         https://bugs.webkit.org/show_bug.cgi?id=194710
535
536         Causes layout test crashes under GuardMalloc (Requested by
537         ryanhaddad on #webkit).
538
539         Reverted changesets:
540
541         "[WTF] Add environment variable helpers"
542         https://bugs.webkit.org/show_bug.cgi?id=192405
543         https://trac.webkit.org/changeset/241559
544
545         "Unreviewed build fix for WinCairo Debug after r241559."
546         https://trac.webkit.org/changeset/241566
547
548 2019-02-15  Zalan Bujtas  <zalan@apple.com>
549
550         [LFC] Out-of-flow box is never a float box
551         https://bugs.webkit.org/show_bug.cgi?id=194704
552
553         Reviewed by Antti Koivisto.
554
555         * LayoutReloaded/misc/LFC-passing-tests.txt:
556
557 2019-02-10  Darin Adler  <darin@apple.com>
558
559         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
560         https://bugs.webkit.org/show_bug.cgi?id=194487
561
562         Reviewed by Daniel Bates.
563
564         * DumpRenderTree/win/DumpRenderTree.cpp:
565         (applicationId): Use makeString instead of String::format.
566         (main): Ditto.
567         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
568         (TestWebKitAPI::Util::createURLForResource): Ditto.
569         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
570         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
571
572         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
573         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
574         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
575         (WTR::createStringWithAttributes): Use appendLiteral.
576         (WTR::AccessibilityUIElement::helpText const): Ditto.
577         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
578         directly instead of using String::format.
579         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
580         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
581
582 2019-02-15  Truitt Savell  <tsavell@apple.com>
583
584         Unreviewed, rolling out r241564.
585
586         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
587
588         Reverted changeset:
589
590         "[Mac] WebInspectorUI.framework does not need to be soft-
591         linked anymore"
592         https://bugs.webkit.org/show_bug.cgi?id=194411
593         https://trac.webkit.org/changeset/241564
594
595 2019-02-15  Saam barati  <sbarati@apple.com>
596
597         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
598         https://bugs.webkit.org/show_bug.cgi?id=194036
599
600         Reviewed by Yusuke Suzuki.
601
602         * Scripts/run-jsc-stress-tests:
603
604 2019-02-14  Tim Horton  <timothy_horton@apple.com>
605
606         Fix the build.
607
608         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
609         (WTR::UIScriptController::drawSquareInEditableImage):
610         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
611         (TestWebKitAPI::drawSquareInEditableImage):
612
613 2019-02-14  Tim Horton  <timothy_horton@apple.com>
614
615         Fix the build.
616
617         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
618         (WTR::UIScriptController::drawSquareInEditableImage):
619         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
620         (TestWebKitAPI::drawSquareInEditableImage):
621
622 2019-02-14  Brian Burg  <bburg@apple.com>
623
624         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
625         https://bugs.webkit.org/show_bug.cgi?id=194411
626         <rdar://problem/47787614>
627
628         Reviewed by Joseph Pecoraro.
629
630         Remove unnecessary soft linking macro usage.
631
632         * DumpRenderTree/mac/TestRunnerMac.mm:
633         (TestRunner::inspectorTestStubURL):
634         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
635         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
636         (WTR::TestRunner::inspectorTestStubURL):
637
638 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
639
640         [ews-app] status bubble should fetch builder name info from BuilderMapping table
641         https://bugs.webkit.org/show_bug.cgi?id=194599
642
643         Reviewed by Lucas Forschler.
644
645         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
646         (StatusBubble._build_bubble):
647
648 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
649
650         [ews-app] Set Foreign Key in Django build model
651         https://bugs.webkit.org/show_bug.cgi?id=194667
652
653         Reviewed by Lucas Forschler.
654
655         * BuildSlaveSupport/ews-app/ews/models/build.py:
656         (Build):
657
658 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
659
660         [WTF] Add environment variable helpers
661         https://bugs.webkit.org/show_bug.cgi?id=192405
662
663         Reviewed by Michael Catanzaro.
664
665         * DumpRenderTree/mac/DumpRenderTree.mm:
666         (libraryPathForDumpRenderTree):
667         * DumpRenderTree/win/DumpRenderTree.cpp:
668         (libraryPathForDumpRenderTree):
669         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
670         (setUpIOSLayoutTestCommunication):
671         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
672         (TestWebKitAPI::strip):
673         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
674         (beforeAll):
675         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
676         (main):
677         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
678         (WebKitTestBus::run):
679         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
680         (WTR::getOutputDir):
681         (WTR::initializeFontConfigSetting):
682         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
683         (WTR::InjectedBundle::platformInitialize):
684         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
685         (WTR::topLevelPath):
686         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
687         (WTR::topLevelPath):
688         (WTR::getOutputDir):
689         (WTR::activateFonts):
690         * WebKitTestRunner/TestController.cpp:
691         (WTR::TestController::libraryPathForTesting):
692         (WTR::TestController::generateContextConfiguration const):
693         (WTR::TestController::generatePageConfiguration):
694         (WTR::TestController::decideDestinationWithSuggestedFilename):
695         (WTR::TestController::platformAdjustContext):
696         * WebKitTestRunner/TestController.h:
697         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
698         (WTR::TestController::cocoaPlatformInitialize):
699         (WTR::TestController::platformAdjustContext):
700         * WebKitTestRunner/gtk/main.cpp:
701         (main):
702         * WebKitTestRunner/mac/TestControllerMac.mm:
703         (WTR::TestController::configureContentExtensionForTest):
704         * WebKitTestRunner/wpe/main.cpp:
705         (main):
706         Utilize WTF::Environment where possible.
707
708 2019-02-14  Chris Dumez  <cdumez@apple.com>
709
710         [PSON] Introduce a WebContent Process cache
711         https://bugs.webkit.org/show_bug.cgi?id=194594
712         <rdar://problem/46793397>
713
714         Reviewed by Geoff Garen.
715
716         Update API tests to turn on the WebContent Process cache.
717
718         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
719
720 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
721
722         Unreviewed, build fix after r241480
723
724         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
725         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
726         (-[DragAndDropSimulator initWithWebView:]):
727
728 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
729
730         AX: ARIA Reflection was disabled in error
731         https://bugs.webkit.org/show_bug.cgi?id=194647
732         <rdar://problem/48068336>
733
734         Reviewed by Ryosuke Niwa.
735
736         Remove test override now that this feature should be enabled by default.
737
738         * WebKitTestRunner/TestController.cpp:
739         (WTR::TestController::resetPreferencesToConsistentValues):
740
741 2019-02-14  Commit Queue  <commit-queue@webkit.org>
742
743         Unreviewed, rolling out r241486.
744         https://bugs.webkit.org/show_bug.cgi?id=194655
745
746         causing API failures in builds (Requested by ShawnRoberts on
747         #webkit).
748
749         Reverted changeset:
750
751         "[Cocoa] Media elements will restart network buffering just
752         before suspending"
753         https://bugs.webkit.org/show_bug.cgi?id=193691
754         https://trac.webkit.org/changeset/241486
755
756 2019-02-14  Zalan Bujtas  <zalan@apple.com>
757
758         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
759         https://bugs.webkit.org/show_bug.cgi?id=194622
760
761         Reviewed by Antti Koivisto.
762
763         * LayoutReloaded/misc/LFC-passing-tests.txt:
764
765 2019-02-14  Zalan Bujtas  <zalan@apple.com>
766
767         [LFC] Shrink-to-fit-width should be constrained by min/max width
768         https://bugs.webkit.org/show_bug.cgi?id=194653
769
770         Reviewed by Antti Koivisto.
771
772         * LayoutReloaded/misc/LFC-passing-tests.txt:
773
774 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
775
776         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
777         https://bugs.webkit.org/show_bug.cgi?id=194641
778
779         Reviewed by Geoffrey Garen.
780
781         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
782         so that the test would fail without this fix.
783
784         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
785         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
786
787 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
788
789         [ews-app] Change log level for a log statement
790
791         Unreviewed minor fix.
792
793         * BuildSlaveSupport/ews-app/ews/models/patch.py:
794         (Patch.save_patch):
795
796 2019-02-13  Jer Noble  <jer.noble@apple.com>
797
798         [Cocoa] Media elements will restart network buffering just before suspending
799         https://bugs.webkit.org/show_bug.cgi?id=193691
800
801         Reviewed by Eric Carlson.
802
803         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
804         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
805         (TEST):
806
807 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
808
809         [ews-app] Fetch builder id to name mapping
810         https://bugs.webkit.org/show_bug.cgi?id=194355
811
812         Reviewed by Lucas Forschler.
813
814         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
815         (Buildbot.get_builder_id_to_name_mapping):
816         (Buildbot._get_display_name_from_builder_name):
817
818 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
819
820         Further restricting webarchive loads
821         https://bugs.webkit.org/show_bug.cgi?id=194567
822         <rdar://problem/47610130>
823
824         Reviewed by Youenn Fablet.
825
826         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
827         navigations on drop.
828
829         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
830         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
831         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
832         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
833         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
834         (TestWebKitAPI::TEST):
835         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
836         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
837         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
838         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
839         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
840         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
841         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
842
843 2019-02-13  John Wilander  <wilander@apple.com>
844
845         Store Ad Click Attribution requests in the network process
846         https://bugs.webkit.org/show_bug.cgi?id=194510
847         <rdar://problem/47650118>
848
849         Reviewed by Alex Christensen and Daniel Bates.
850
851         This patch adds two TestRunner functions:
852         - dumpAdClickAttribution()
853         - clearAdClickAttribution()
854
855         They call into the network process to dump and clear Ad Click
856         Attribution state, respectively.
857
858         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
859         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
860         (WTR::TestRunner::dumpAdClickAttribution):
861         (WTR::TestRunner::clearAdClickAttribution):
862         * WebKitTestRunner/InjectedBundle/TestRunner.h:
863         * WebKitTestRunner/TestController.cpp:
864         (WTR::TestController::resetStateToConsistentValues):
865         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
866         (WTR::adClickAttributionStringResultCallback):
867         (WTR::TestController::dumpAdClickAttribution):
868         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
869         (WTR::adClickAttributionVoidCallback):
870         (WTR::TestController::clearAdClickAttribution):
871         * WebKitTestRunner/TestController.h:
872         * WebKitTestRunner/TestInvocation.cpp:
873         (WTR::TestInvocation::dumpResults):
874         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
875         (WTR::TestInvocation::dumpAdClickAttribution):
876         * WebKitTestRunner/TestInvocation.h:
877
878 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
879
880         [ews-app] Generate status-bubble
881         https://bugs.webkit.org/show_bug.cgi?id=194572
882
883         Reviewed by Lucas Forschler.
884
885         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
886         (StatusBubble._build_bubble):
887         (StatusBubble._should_show_bubble_for):
888         (StatusBubble._build_bubbles_for_patch):
889
890 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
891
892         [ews-app] Add status bubble html template
893         https://bugs.webkit.org/show_bug.cgi?id=194571
894
895         Reviewed by Lucas Forschler.
896
897         * BuildSlaveSupport/ews-app/ews/templates: Added.
898         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
899
900 2019-02-12  Chris Dumez  <cdumez@apple.com>
901
902         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
903         https://bugs.webkit.org/show_bug.cgi?id=194568
904         <rdar://problem/47944490>
905
906         Reviewed by Ryosuke Niwa.
907
908         Add API test coverage.
909
910         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
911         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
912
913 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
914
915         webkitpy: Remove bug_dummy from parsed test expectations
916         https://bugs.webkit.org/show_bug.cgi?id=194562
917         <rdar://problem/47853999>
918
919         Reviewed by Lucas Forschler.
920
921         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
922         (TestExpectationParser):
923         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
924         skipped tests.
925         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
926
927 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
928
929         [ews-app] Add method to fetch patch
930         https://bugs.webkit.org/show_bug.cgi?id=194518
931
932         Reviewed by Lucas Forschler.
933
934         * BuildSlaveSupport/ews-app/ews/models/patch.py:
935         (Patch.get_patch):
936
937 2019-02-12  Zalan Bujtas  <zalan@apple.com>
938
939         [LFC] Expand tests coverage (60 new tests -> 860)
940
941         Unreviewed test gardening (run-singly, --child-processes=1).
942
943         * LayoutReloaded/misc/LFC-passing-tests.txt:
944
945 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
946
947         Allow pages to trigger programmatic paste from script on iOS
948         https://bugs.webkit.org/show_bug.cgi?id=194271
949         <rdar://problem/47808810>
950
951         Reviewed by Tim Horton.
952
953         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
954
955         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
956         (WTR::UIScriptController::platformSetDidShowMenuCallback):
957         (WTR::UIScriptController::platformSetDidHideMenuCallback):
958         (WTR::UIScriptController::rectForMenuAction const):
959
960         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
961         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
962         for when the menu is shown or hidden.
963
964         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
965         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
966         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
967         (WTR::UIScriptController::setDidShowMenuCallback):
968         (WTR::UIScriptController::didShowMenuCallback const):
969         (WTR::UIScriptController::setDidHideMenuCallback):
970         (WTR::UIScriptController::didHideMenuCallback const):
971         (WTR::UIScriptController::platformSetDidShowMenuCallback):
972         (WTR::UIScriptController::platformSetDidHideMenuCallback):
973         (WTR::UIScriptController::rectForMenuAction const):
974         * TestRunnerShared/UIScriptContext/UIScriptController.h:
975         * WebKitTestRunner/TestController.cpp:
976         (WTR::TestController::resetPreferencesToConsistentValues):
977         (WTR::updateTestOptionsFromTestHeader):
978         * WebKitTestRunner/TestOptions.h:
979
980         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
981         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
982
983         (WTR::TestOptions::hasSameInitializationOptions const):
984         * WebKitTestRunner/UIScriptControllerCocoa.mm:
985         (WTR::UIScriptController::calendarType const):
986         (WTR::UIScriptController::platformUndoManager const):
987         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
988         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
989         (-[TestRunnerWKWebView initWithFrame:configuration:]):
990         (-[TestRunnerWKWebView dealloc]):
991         (-[TestRunnerWKWebView _didShowMenu]):
992         (-[TestRunnerWKWebView _didHideMenu]):
993
994         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
995
996         * WebKitTestRunner/ios/TestControllerIOS.mm:
997         (WTR::handleMenuWillHideNotification):
998         (WTR::handleMenuDidHideNotification):
999         (WTR::TestController::platformInitialize):
1000         (WTR::TestController::platformDestroy):
1001         (WTR::TestController::platformResetStateToConsistentValues):
1002
1003         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
1004         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
1005
1006         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1007         (WTR::forEachViewInHierarchy):
1008         (WTR::findViewInHierarchyOfType):
1009
1010         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
1011         functions that dig through a given view's hierarchy in search of a view of a given class.
1012
1013         (WTR::UIScriptController::selectionStartGrabberViewRect const):
1014         (WTR::UIScriptController::selectionEndGrabberViewRect const):
1015         (WTR::UIScriptController::selectionCaretViewRect const):
1016         (WTR::UIScriptController::selectionRangeViewRects const):
1017         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1018         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1019
1020         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
1021
1022         (WTR::UIScriptController::rectForMenuAction const):
1023
1024         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
1025         callout bar) whose label matches the given string.
1026
1027         (WTR::UIScriptController::platformContentView const):
1028
1029         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
1030         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
1031         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
1032
1033         (WTR::UIScriptController::platformUndoManager const): Deleted.
1034         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1035         (WTR::UIScriptController::platformContentView const):
1036         (WTR::UIScriptController::platformUndoManager const): Deleted.
1037
1038 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
1039
1040         webkitpy: No option to only show unexpected failures in results.html for iPad
1041         https://bugs.webkit.org/show_bug.cgi?id=194554
1042         <rdar://problem/47922442>
1043
1044         Rubber-stamped by Aakash Jain.
1045
1046         Just because a TestExpecations file does not exist for a specific platform does not mean that
1047         TestExpecations are not being used, given that platforms inherit test expectations.
1048
1049         * Scripts/webkitpy/port/base.py:
1050         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
1051         * Scripts/webkitpy/port/base_unittest.py:
1052         (PortTest.test_uses_test_expectations_file):
1053
1054 2019-02-12  Alex Christensen  <achristensen@webkit.org>
1055
1056         Remove setDefersLoading infrastructure from WebKit2
1057         https://bugs.webkit.org/show_bug.cgi?id=194506
1058
1059         Reviewed by Brady Eidson.
1060
1061         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1062         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1063         (WTR::TestRunner::setDefersLoading): Deleted.
1064         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1065
1066 2019-02-12  Alex Christensen  <achristensen@webkit.org>
1067
1068         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
1069         https://bugs.webkit.org/show_bug.cgi?id=194522
1070         <rdar://problem/47789393>
1071
1072         Reviewed by Chris Dumez.
1073
1074         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1075         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
1076         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1077         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1078
1079 2019-02-12  Andy Estes  <aestes@apple.com>
1080
1081         [iOSMac] Enable Parental Controls Content Filtering
1082         https://bugs.webkit.org/show_bug.cgi?id=194521
1083         <rdar://39732376>
1084
1085         Reviewed by Tim Horton.
1086
1087         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1088
1089 2019-02-12  Zalan Bujtas  <zalan@apple.com>
1090
1091         [LFC][IFC] Add intrinsic width support for float boxes.
1092         https://bugs.webkit.org/show_bug.cgi?id=194528
1093
1094         Reviewed by Antti Koivisto.
1095
1096         Expand tests coverage (2 new tests -> 800).
1097         (This is the correct test ordering --runs-singly --child-processes=1)
1098
1099         * LayoutReloaded/misc/LFC-passing-tests.txt:
1100
1101 2019-02-12  Rob Buis  <rbuis@igalia.com>
1102
1103         Implement serializing in MIME type parser
1104         https://bugs.webkit.org/show_bug.cgi?id=193909
1105
1106         Reviewed by Darin Adler.
1107
1108         Add various tests involving upper case, non-ASCII, control/null characters,
1109         various HTTP whitespace, single quotes and an unpaired surrogate.
1110
1111         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1112         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
1113         (TestWebKitAPI::serializeIfValid):
1114         (TestWebKitAPI::TEST):
1115
1116 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
1117
1118         [Cocoa] Ask platform for generic font family mappings
1119         https://bugs.webkit.org/show_bug.cgi?id=187723
1120         <rdar://problem/41892438>
1121
1122         Reviewed by Brent Fulgham.
1123
1124         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
1125
1126         * DumpRenderTree/mac/DumpRenderTree.mm:
1127         (allowedFontFamilySet):
1128         * WebKitTestRunner/mac/TestControllerMac.mm:
1129         (WTR::allowedFontFamilySet):
1130
1131 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
1132
1133         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
1134         https://bugs.webkit.org/show_bug.cgi?id=193622
1135
1136         Reviewed by Michael Catanzaro.
1137
1138         This adds support for loading content extension rule sets from the JSON files which
1139         accompany the corresponding layout test, using the C API. The Cocoa specific parts
1140         of WKTR for this could be removed, but that is left for a follow-up patch with
1141         cleanups.
1142
1143         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
1144         * WebKitTestRunner/TestController.cpp:
1145         (WTR::testPath): Subtract one from the length when constructing the result std::string to
1146         avoid having the null-terminator copied into the result.
1147         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
1148         part of the preparations to run a test.
1149         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
1150         (WTR::contentExtensionStoreCallback): Added.
1151         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
1152         used for content extensions test.
1153         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
1154         extensions and compiling the JSON rule set for tests involving content extensions.
1155         (WTR::TestController::resetContentExtensions): Removes the content extension built for
1156         testing and disables content extensions.
1157         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
1158         resetContentExtensions().
1159         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
1160         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
1161         configureContentExtensionForTest(), and userContentController().
1162
1163 2019-02-11  Daniel Bates  <dabates@apple.com>
1164
1165         [iOS] Mouse/Touch/Pointer events are missing modifier keys
1166         https://bugs.webkit.org/show_bug.cgi?id=191446
1167         <rdar://problem/45929460>
1168
1169         Reviewed by Tim Horton.
1170
1171         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
1172
1173         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1174         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1175         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1176         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1177         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1178         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1179         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1180         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1181         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1182         (WTR::arrayLength):
1183         (WTR::parseModifierArray):
1184         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
1185         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1186         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
1187         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1188
1189 2019-02-11  Commit Queue  <commit-queue@webkit.org>
1190
1191         Unreviewed, rolling out r241272 and r241276.
1192         https://bugs.webkit.org/show_bug.cgi?id=194514
1193
1194         Broke the Apple Internal build and the fix requires human
1195         intervention :( (Requested by dydz on #webkit).
1196
1197         Reverted changesets:
1198
1199         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
1200         https://bugs.webkit.org/show_bug.cgi?id=191446
1201         https://trac.webkit.org/changeset/241272
1202
1203         "Fix internal iOS build after r241272"
1204         https://bugs.webkit.org/show_bug.cgi?id=191446
1205         https://trac.webkit.org/changeset/241276
1206
1207 2019-02-11  Truitt Savell  <tsavell@apple.com>
1208
1209         Unreviewed, rolling out r241269.
1210
1211         Caused 5 layout tests crashes on Mac WK1
1212
1213         Reverted changeset:
1214
1215         "DumpRenderTree should report unknown options"
1216         https://bugs.webkit.org/show_bug.cgi?id=191303
1217         https://trac.webkit.org/changeset/241269
1218
1219 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1220
1221         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
1222         https://bugs.webkit.org/show_bug.cgi?id=194313
1223
1224         Reviewed by Tim Horton.
1225
1226         Add a helper to determine whether the web view is presenting modal UI.
1227
1228         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1229         (WTR::UIScriptController::isPresentingModally const):
1230         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1231         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1232         (WTR::UIScriptController::isPresentingModally const):
1233         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1234         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1235         (WTR::UIScriptController::calendarType const): Deleted.
1236         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1237         (WTR::UIScriptController::isPresentingModally const):
1238         (WTR::UIScriptController::calendarType const):
1239         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1240         (WTR::UIScriptController::calendarType const):
1241
1242 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
1243
1244         GCHeapInspector: Show the retained sizes in more places
1245         https://bugs.webkit.org/show_bug.cgi?id=194464
1246
1247         Reviewed by Simon Fraser.
1248
1249         * GCHeapInspector/gc-heap-inspector.html:
1250         * GCHeapInspector/script/interface.js:
1251         (HeapInspectorUtils.humanReadableSize):
1252         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
1253         (HeapInspectorUtils.spanForNode.span.span):
1254         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
1255         (HeapSnapshotInspector.prototype.buildRoots):
1256
1257 2019-02-11  Daniel Bates  <dabates@apple.com>
1258
1259         [iOS] Mouse/Touch/Pointer events are missing modifier keys
1260         https://bugs.webkit.org/show_bug.cgi?id=191446
1261         <rdar://problem/45929460>
1262
1263         Reviewed by Tim Horton.
1264
1265         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
1266
1267         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1268         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1269         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1270         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1271         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1272         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1273         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1274         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1275         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1276         (WTR::arrayLength):
1277         (WTR::parseModifierArray):
1278         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
1279         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1280         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
1281         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1282
1283 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
1284
1285         DumpRenderTree should report unknown options
1286         https://bugs.webkit.org/show_bug.cgi?id=191303
1287
1288         Reviewed by Frédéric Wang.
1289
1290         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
1291         to report unknown options.
1292         Added and assigned test options which are currently used in tests.
1293
1294         * DumpRenderTree/TestOptions.cpp:
1295         (TestOptions::TestOptions):
1296
1297 2019-02-11  Truitt Savell  <tsavell@apple.com>
1298
1299         Unreviewed, rolling out r241229.
1300
1301         Revision broke internal builds for watchOS.
1302
1303         Reverted changeset:
1304
1305         "[Cocoa] Ask platform for generic font family mappings"
1306         https://bugs.webkit.org/show_bug.cgi?id=187723
1307         https://trac.webkit.org/changeset/241229
1308
1309 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
1310
1311         [WinCairo][MiniBrowser] Basic authentication always fails.
1312         https://bugs.webkit.org/show_bug.cgi?id=194496
1313
1314         Reviewed by Don Olmstead.
1315
1316         * MiniBrowser/win/DialogHelper.h:
1317         (Dialog::getText):
1318
1319 2019-02-11  Philippe Normand  <pnormand@igalia.com>
1320
1321         [GStreamer] GstMappedBuffer testsuite build fails
1322         https://bugs.webkit.org/show_bug.cgi?id=194495
1323
1324         Reviewed by Carlos Garcia Campos.
1325
1326         Fix the build by explicitely adding the gstreamer1.0-audio include
1327         directories to the include path.
1328
1329         * TestWebKitAPI/PlatformGTK.cmake:
1330         * TestWebKitAPI/PlatformWPE.cmake:
1331
1332 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
1333
1334         [GTK][WPE] Add enable-javascript-markup setting
1335         https://bugs.webkit.org/show_bug.cgi?id=193439
1336
1337         Reviewed by Michael Catanzaro.
1338
1339         Add test cases to check the new setting.
1340
1341         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1342         (testWebKitSettings):
1343         (testWebKitSettingsJavaScriptMarkup):
1344         (beforeAll):
1345
1346 2019-02-10  Darin Adler  <darin@apple.com>
1347
1348         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
1349         https://bugs.webkit.org/show_bug.cgi?id=194485
1350
1351         Reviewed by Daniel Bates.
1352
1353         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
1354
1355 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
1356
1357         Add more tests for clampTo<>()
1358         https://bugs.webkit.org/show_bug.cgi?id=194462
1359
1360         Reviewed by Geoffrey Garen.
1361
1362         Darin suggested to test the very last floating point number
1363         at the boundaries when truncating to integer.
1364         I added test for max/min and max-1/min-1.
1365
1366         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1367         (TestWebKitAPI::TEST):
1368
1369 2019-02-09  Darin Adler  <darin@apple.com>
1370
1371         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
1372         https://bugs.webkit.org/show_bug.cgi?id=194021
1373
1374         Reviewed by Geoffrey Garen.
1375
1376         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
1377         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
1378         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
1379
1380 2019-02-09  Zalan Bujtas  <zalan@apple.com>
1381
1382         [LFC][IFC] Add intrinsic width support for basic inline containers
1383         https://bugs.webkit.org/show_bug.cgi?id=194473
1384
1385         Reviewed by Antti Koivisto.
1386
1387         Expand tests coverage (11 new tests -> 798)
1388
1389         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
1390
1391 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
1392
1393         Fix MiniBrowser's entitlements
1394         https://bugs.webkit.org/show_bug.cgi?id=192431
1395
1396         Reviewed by Joseph Pecoraro.
1397
1398         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
1399         files, making it impossible to load any extension.
1400
1401         * MiniBrowser/MiniBrowser.entitlements:
1402
1403 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
1404
1405         [Cocoa] Ask platform for generic font family mappings
1406         https://bugs.webkit.org/show_bug.cgi?id=187723
1407         <rdar://problem/41892438>
1408
1409         Reviewed by Brent Fulgham.
1410
1411         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
1412
1413         * DumpRenderTree/mac/DumpRenderTree.mm:
1414         (allowedFontFamilySet):
1415         * WebKitTestRunner/mac/TestControllerMac.mm:
1416         (WTR::allowedFontFamilySet):
1417
1418 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
1419
1420         [GTK] Implement back/forward touchpad gesture
1421         https://bugs.webkit.org/show_bug.cgi?id=193919
1422
1423         Reviewed by Michael Catanzaro.
1424
1425         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1426         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
1427
1428 2019-02-08  Alex Christensen  <achristensen@webkit.org>
1429
1430         Add SPI to use networking daemon instead of XPC service
1431         https://bugs.webkit.org/show_bug.cgi?id=194427
1432
1433         Reviewed by Geoffrey Garen
1434
1435         * MiniBrowser/MiniBrowser.entitlements:
1436
1437 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
1438
1439         [ews-build] Ensure that every builder in config.json has short name
1440         https://bugs.webkit.org/show_bug.cgi?id=194461
1441
1442         Reviewed by Lucas Forschler.
1443
1444         * BuildSlaveSupport/ews-build/loadConfig.py:
1445         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
1446
1447 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
1448
1449         [ews-build] Add short name to config.json
1450         https://bugs.webkit.org/show_bug.cgi?id=194456
1451
1452         Reviewed by Lucas Forschler.
1453
1454         * BuildSlaveSupport/ews-build/config.json: Added short name.
1455         * BuildSlaveSupport/ews-build/loadConfig.py:
1456         (loadBuilderConfig): Set the short name as the builder description.
1457
1458 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
1459
1460         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
1461         https://bugs.webkit.org/show_bug.cgi?id=194418
1462
1463         Reviewed by Lucas Forschler.
1464
1465         Do not include errors trying when finding crashlogs at the end of
1466         a run-webkit-tests run since we don't process those errors.
1467
1468         * Scripts/webkitpy/port/darwin.py:
1469         (DarwinPort._look_for_all_crash_logs_in_log_dir):
1470         * Scripts/webkitpy/port/ios_device.py:
1471         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
1472         * Scripts/webkitpy/port/watch_device.py:
1473         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
1474
1475 2019-02-08  Beth Dakin  <bdakin@apple.com>
1476
1477         Add afterScreenUpdates to WKSnapshotConfiguration
1478         https://bugs.webkit.org/show_bug.cgi?id=194362
1479         -and corresponding-
1480         <rdar://problem/40655528> Please add an "after screen updates" property to 
1481         WKSnapshotConfiguration (to solve blank snapshots)
1482
1483         Reviewed by Tim Horton.
1484
1485         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
1486         (TEST):
1487
1488 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
1489
1490         clampTo(): do not convert the input to double when dealing with integers
1491         https://bugs.webkit.org/show_bug.cgi?id=194263
1492         <rdar://problem/47692312>
1493
1494         Reviewed by Darin Adler.
1495
1496         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1497         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
1498         (TestWebKitAPI::testClampFloatingPointToInteger):
1499         (TestWebKitAPI::testClampSameSignIntegers):
1500         (TestWebKitAPI::testClampUnsignedToSigned):
1501         (TestWebKitAPI::testClampSignedToUnsigned):
1502
1503 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
1504
1505         webkitpy: Respect --dedicated-simulators flag
1506         https://bugs.webkit.org/show_bug.cgi?id=194416
1507         <rdar://problem/47894722>
1508
1509         Reviewed by Lucas Forschler.
1510
1511         * Scripts/webkitpy/port/device_port.py:
1512         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
1513         available devices can be safely ignored.
1514
1515 2019-02-07  Keith Rollin  <krollin@apple.com>
1516
1517         Remove extra copy of 100x100-red.tga
1518         https://bugs.webkit.org/show_bug.cgi?id=194371
1519         <rdar://problem/47873465>
1520
1521         Reviewed by Said Abou-Hallawa.
1522
1523         In order to help it pass its tests, Bug 194190 added a second copy of
1524         the file 100x100-red.tga. However, it turns out that this additional
1525         file wasn't actually needed, and that that sole previous copy was
1526         sufficient. At the same time, this second copy -- which was copied to
1527         the same location in the build output as the first copy -- now caused
1528         XCBuild to complain because there were two production rules for the
1529         same output file. Address this by removing the newly-added extra copy.
1530
1531         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1532         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
1533
1534 2019-02-07  Alex Christensen  <achristensen@webkit.org>
1535
1536         Deprecate WKBundlePageSetDefersLoading
1537         https://bugs.webkit.org/show_bug.cgi?id=191394
1538
1539         Reviewed by Dean Jackson.
1540
1541         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1542         (WTR::TestRunner::setDefersLoading):
1543
1544 2019-02-07  Zalan Bujtas  <zalan@apple.com>
1545
1546         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
1547         https://bugs.webkit.org/show_bug.cgi?id=194391
1548
1549         Reviewed by Antti Koivisto.
1550
1551         * LayoutReloaded/misc/LFC-passing-tests.txt:
1552
1553 2019-02-06  Keith Rollin  <krollin@apple.com>
1554
1555         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
1556         https://bugs.webkit.org/show_bug.cgi?id=193975
1557         <rdar://problem/47643306>
1558
1559         Reviewed by Tim Horton.
1560
1561         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
1562         the Info.plist file into the bundle. This step is not necessary as the
1563         implicit "bundle up all the build products into a framework" build
1564         phase does this already. Having the Copy Bundle Resources phase do
1565         this causes a conflict under XCBuild, which objects to two build
1566         phases producing the same file (Info.plist). Address this by removing
1567         Info.plist from the Copy Bundle Resources phase.
1568
1569         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1570
1571 2019-02-06  Keith Rollin  <krollin@apple.com>
1572
1573         Really enable the automatic checking and regenerations of .xcfilelists during builds
1574         https://bugs.webkit.org/show_bug.cgi?id=194357
1575         <rdar://problem/47861231>
1576
1577         Reviewed by Chris Dumez.
1578
1579         Bug 194124 was supposed to enable the automatic checking and
1580         regenerating of .xcfilelist files during the build. While related
1581         changes were included in that patch, the change to actually enable the
1582         operation somehow was omitted. This patch actually enables the
1583         operation. The check-xcfilelist.sh scripts now check
1584         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
1585         from the checking.
1586
1587         * DumpRenderTree/Scripts/check-xcfilelists.sh:
1588         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
1589
1590 2019-02-06  David Kilzer  <ddkilzer@apple.com>
1591
1592         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
1593         <https://webkit.org/b/194286>
1594         <rdar://problem/47815558>
1595
1596         Reviewed by Alexey Proskuryakov.
1597
1598         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1599         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
1600         WKRetainPtr<> to avoid leaking the WKDataRef.
1601
1602 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1603
1604         Unreviewed, fix a typo
1605
1606         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1607
1608 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
1609
1610         [GTK][WPE] force libpsl build to use ICU in jhbuild
1611         https://bugs.webkit.org/show_bug.cgi?id=194288
1612
1613         Reviewed by Carlos Garcia Campos.
1614
1615         * gtk/jhbuild.modules:
1616         Require ICU for libpsl build in jhbuild, like done in WPE.
1617
1618 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1619
1620         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
1621         https://bugs.webkit.org/show_bug.cgi?id=194209
1622
1623         Reviewed by Carlos Garcia Campos.
1624
1625         Enhance TestCookieManager to ensure this doesn't happen again.
1626
1627         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1628         (testCookieManagerPersistentStorage):
1629         (beforeAll):
1630
1631 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1632
1633         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
1634         https://bugs.webkit.org/show_bug.cgi?id=194324
1635
1636         Reviewed by Andy Estes.
1637
1638         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
1639         part of the name is already implicit, since this is in testing code in TestOptions.
1640
1641         * WebKitTestRunner/TestController.cpp:
1642         (WTR::TestController::generateContextConfiguration const):
1643         (WTR::updateTestOptionsFromTestHeader):
1644         * WebKitTestRunner/TestOptions.h:
1645         (WTR::TestOptions::hasSameInitializationOptions const):
1646
1647 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1648
1649         [ews-build] Allow * as platform for builders and workers
1650         https://bugs.webkit.org/show_bug.cgi?id=188533
1651
1652         Reviewed by Lucas Forschler.
1653
1654         * BuildSlaveSupport/ews-build/loadConfig.py:
1655         (checkWorkersAndBuildersForConsistency):
1656
1657 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1658
1659         [ews-build] Add few bots to config.json
1660         https://bugs.webkit.org/show_bug.cgi?id=194304
1661
1662         Reviewed by Lucas Forschler.
1663
1664         * BuildSlaveSupport/ews-build/config.json:
1665
1666 2019-02-05  Keith Rollin  <krollin@apple.com>
1667
1668         Enable the automatic checking and regenerations of .xcfilelists during builds
1669         https://bugs.webkit.org/show_bug.cgi?id=194124
1670         <rdar://problem/47721277>
1671
1672         Reviewed by Tim Horton.
1673
1674         Bug 193790 add a facility for checking -- during build time -- that
1675         any needed .xcfilelist files are up-to-date and for updating them if
1676         they are not. This facility was initially opt-in by setting
1677         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
1678         the process seemed robust. Its now time to enable this facility and
1679         make it opt-out. If there is a need to disable this facility, set and
1680         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
1681         running `make` or `build-webkit`, or before running Xcode from the
1682         command line.
1683
1684         Additionally, remove the step that generates a list of source files
1685         going into the UnifiedSources build step. It's only necessarily to
1686         specify Sources.txt and SourcesCocoa.txt as inputs.
1687
1688         * Scripts/generate-xcfilelists:
1689
1690 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
1691
1692         [GTK][WPE] force libpsl build to use ICU in jhbuild
1693         https://bugs.webkit.org/show_bug.cgi?id=194288
1694
1695         Reviewed by Philippe Normand.
1696
1697         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
1698         This can cause build failures if libidn is detected but libunistring is not available.
1699
1700         Make sure that ICU is used for runtime and builtin PSL data.
1701
1702         * gtk/jhbuild.modules:
1703         * wpe/jhbuild.modules:
1704
1705 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1706
1707         [ews-app] Modified timestamp should be updated on updating data
1708         https://bugs.webkit.org/show_bug.cgi?id=194295
1709
1710         Reviewed by Lucas Forschler.
1711
1712         * BuildSlaveSupport/ews-app/ews/models/build.py:
1713         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1714         * BuildSlaveSupport/ews-app/ews/models/step.py:
1715
1716 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
1717
1718         Unreviewed, rolling out r240742.
1719
1720         Causes crashes on iOS simulator.
1721
1722         Reverted changeset:
1723
1724         "[iOS] Keyups for non-modifier keys identified as "Dead" when
1725         not focused in a content-editable element"
1726         https://bugs.webkit.org/show_bug.cgi?id=192824
1727         https://trac.webkit.org/changeset/240742
1728
1729 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
1730
1731         run-webkit-tests emits message "...running None" when running tests
1732         https://bugs.webkit.org/show_bug.cgi?id=194133
1733         <rdar://problem/47724738>
1734
1735         Reviewed by Lucas Forschler.
1736
1737         * Scripts/webkitpy/xcode/device_type.py:
1738         (DeviceType.__str__): Use both version mapping tables and use just the variant
1739         name if no version name is available.
1740         * Scripts/webkitpy/xcode/device_type_unittest.py:
1741         (DeviceTypeTest):
1742         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
1743         an associated named.
1744
1745 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
1746
1747         [WPE] require python3-setuptools for meson build in jhbuild
1748         https://bugs.webkit.org/show_bug.cgi?id=194287
1749
1750         Reviewed by Philippe Normand.
1751
1752         python3-setuptools is needed to build meson in jhbuild.
1753         It is already required by the GTK port.
1754
1755         * wpe/install-dependencies:
1756
1757 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1758
1759         [ews-app] Add method to save BuilderMapping to database
1760         https://bugs.webkit.org/show_bug.cgi?id=194264
1761
1762         Reviewed by Lucas Forschler.
1763
1764         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1765         (BuilderMapping.__str__):
1766         (BuilderMapping):
1767         (BuilderMapping.save_mapping):
1768         (BuilderMapping.update_mapping):
1769         (BuilderMapping.get_existing_mapping):
1770         (BuilderMapping.is_valid_mapping):
1771
1772 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1773
1774         [ews-app] Add timestamp fields for BuilderMappings
1775         https://bugs.webkit.org/show_bug.cgi?id=194266
1776
1777         Reviewed by Lucas Forschler.
1778
1779         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1780         (BuilderMapping):
1781
1782 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
1783
1784         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
1785         https://bugs.webkit.org/show_bug.cgi?id=174816
1786
1787         Reviewed by Michael Catanzaro.
1788
1789         Add tests for webkit_uri_for_display().
1790
1791         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
1792         (testURIForDisplayUnaffected):
1793         (testURIForDisplayAffected):
1794         (beforeAll):
1795         (afterAll):
1796         * TestWebKitAPI/glib/CMakeLists.txt:
1797
1798 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
1799
1800         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
1801         https://bugs.webkit.org/show_bug.cgi?id=194158
1802         <rdar://problem/47737268>
1803
1804         Rubber-stamped by Aakash Jain.
1805
1806         * Scripts/webkitpy/port/device_port.py:
1807         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
1808
1809 2019-02-04  Said Abou-Hallawa  <said@apple.com>
1810
1811         [CG] Enable setAdditionalSupportedImageTypes for WK1
1812         https://bugs.webkit.org/show_bug.cgi?id=194190
1813
1814         Reviewed by Tim Horton.
1815
1816         Add a test similar to the one under WebKit Cocoa but make it create a
1817         WebView instead of a WKWebView.
1818
1819         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1820         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
1821         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
1822         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
1823         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
1824         (TestWebKitAPI::runTest):
1825         (TestWebKitAPI::TEST):
1826
1827 2019-02-04  Zalan Bujtas  <zalan@apple.com>
1828
1829         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
1830         https://bugs.webkit.org/show_bug.cgi?id=194168
1831
1832         Reviewed by Simon Fraser.
1833
1834         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
1835
1836         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1837         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
1838         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
1839         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
1840         (TEST):
1841         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
1842         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
1843
1844 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
1845
1846         REGRESSION (r237269): webkit-patch what-broke is broken 
1847         https://bugs.webkit.org/show_bug.cgi?id=193025
1848
1849         Reviewed by Aakash Jain.
1850
1851         * Scripts/webkitpy/common/host.py:
1852         (Host.buildbot):
1853         (Host.bugzilla): Renamed to 'buildbot'.
1854
1855 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1856
1857         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
1858         https://bugs.webkit.org/show_bug.cgi?id=194207
1859
1860         Reviewed by Tim Horton.
1861
1862         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
1863         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
1864         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
1865         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
1866         start and delete forwards to remove the original attachment.
1867
1868         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1869         (TestWebKitAPI::TEST):
1870
1871 2019-02-04  Youenn Fablet  <youenn@apple.com>
1872
1873         Capture state should be managed consistently when doing process swapping
1874         https://bugs.webkit.org/show_bug.cgi?id=194122
1875         <rdar://problem/47609293>
1876
1877         Reviewed by Eric Carlson.
1878
1879         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1880         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1881         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1882         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
1883         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1884         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1885         (WTR::TestRunner::isDoingMediaCapture const):
1886         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1887         * WebKitTestRunner/TestController.cpp:
1888         (WTR::TestController::isDoingMediaCapture const):
1889         * WebKitTestRunner/TestController.h:
1890         * WebKitTestRunner/TestInvocation.cpp:
1891         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1892         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1893         (WTR::TestController::isDoingMediaCapture const):
1894
1895 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
1896
1897         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
1898         https://bugs.webkit.org/show_bug.cgi?id=194142
1899
1900         Reviewed by Ross Kirsling.
1901
1902         There three 'separator' variables in TestController.cpp. Renamed
1903         it 'pathSeparator', and unified them.
1904
1905         * WebKitTestRunner/TestController.cpp:
1906         (WTR::TestController::generateContextConfiguration const):
1907         (WTR::createTestURL):
1908         (WTR::TestController::platformAdjustContext):
1909
1910 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
1911
1912         Make setNeedsLayout on the root more explicitly about triggering its side-effects
1913         https://bugs.webkit.org/show_bug.cgi?id=194198
1914
1915         Reviewed by Antti Koivisto.
1916
1917         No need to set the banner heights on navigation now, since Page stores them.
1918
1919         * MiniBrowser/mac/WK2BrowserWindowController.m:
1920         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
1921
1922 2019-02-03  John Wilander  <wilander@apple.com>
1923
1924         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
1925         https://bugs.webkit.org/show_bug.cgi?id=194104
1926         <rdar://problem/47649991>
1927
1928         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
1929
1930         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1931         (TestWebKitAPI::TEST):
1932             Changed numeric types from unsigned short to uint32_t.
1933
1934 2019-02-02  David Kilzer  <ddkilzer@apple.com>
1935
1936         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
1937         <https://webkit.org/b/194178>
1938         <rdar://problem/47753473>
1939
1940         Reviewed by Alexey Proskuryakov.
1941
1942         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1943         (WTR::uninstallFakeHelvetica): Pass nullptr into
1944         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
1945
1946 2019-02-02  Zalan Bujtas  <zalan@apple.com>
1947
1948         [LFC] Initialize ICB's style with fixed width/height.
1949         https://bugs.webkit.org/show_bug.cgi?id=194188
1950
1951         Reviewed by Antti Koivisto.
1952
1953         * LayoutReloaded/misc/LFC-passing-tests.txt:
1954
1955 2019-02-02  Zalan Bujtas  <zalan@apple.com>
1956
1957         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
1958         https://bugs.webkit.org/show_bug.cgi?id=194185
1959
1960         Reviewed by Antti Koivisto.
1961
1962         * LayoutReloaded/misc/LFC-passing-tests.txt:
1963
1964 2018-12-16  Darin Adler  <darin@apple.com>
1965
1966         Convert additional String::format clients to alternative approaches
1967         https://bugs.webkit.org/show_bug.cgi?id=192746
1968
1969         Reviewed by Alexey Proskuryakov.
1970
1971         * WebKitTestRunner/TestController.cpp:
1972         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
1973         as an intermediate in code that ultimately constructs a WTF::String.
1974         (WTR::userMediaOriginHash): Use makeString.
1975         (WTR::TestController::didNavigateWithNavigationData): More of the same.
1976         (WTR::TestController::didPerformClientRedirect): Ditto.
1977         (WTR::TestController::didPerformServerRedirect): Ditto.
1978         (WTR::TestController::didUpdateHistoryTitle): Ditto.
1979
1980 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
1981
1982         [ews-build] Add unit test to verify builder keys
1983         https://bugs.webkit.org/show_bug.cgi?id=194152
1984
1985         Reviewed by Lucas Forschler.
1986
1987         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
1988         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
1989
1990 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1991
1992         [LFC] Expand tests coverage (12 new tests -> 787)
1993
1994         Unreviewed test gardening.
1995
1996         * LayoutReloaded/misc/LFC-passing-tests.txt:
1997
1998 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1999
2000         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
2001         https://bugs.webkit.org/show_bug.cgi?id=194163
2002
2003         Reviewed by Simon Fraser.
2004
2005         775
2006
2007         * LayoutReloaded/misc/LFC-passing-tests.txt:
2008
2009 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2010
2011         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
2012         https://bugs.webkit.org/show_bug.cgi?id=194140
2013         <rdar://problem/47728098>
2014
2015         Reviewed by Tim Horton.
2016
2017         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2018         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2019         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
2020
2021         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
2022         test to induce an IPC deadlock when presenting a modal alert during touch start.
2023
2024         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2025         * WebKitTestRunner/TestController.cpp:
2026         (WTR::runJavaScriptAlert):
2027
2028         Add a client callback function for running JavaScript alerts.
2029
2030         (WTR::TestController::createOtherPage):
2031         (WTR::TestController::generateContextConfiguration const):
2032
2033         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
2034         the fix in this patch.
2035
2036         (WTR::TestController::createWebViewWithOptions):
2037
2038         Plumb TestOptions to generateContextConfiguration.
2039
2040         (WTR::TestController::resetPreferencesToConsistentValues):
2041         (WTR::TestController::resetStateToConsistentValues):
2042         (WTR::updateTestOptionsFromTestHeader):
2043         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
2044         (WTR::TestController::handleJavaScriptAlert):
2045         * WebKitTestRunner/TestController.h:
2046         * WebKitTestRunner/TestInvocation.cpp:
2047         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2048         * WebKitTestRunner/TestOptions.h:
2049         (WTR::TestOptions::hasSameInitializationOptions const):
2050
2051 2019-02-01  Chris Dumez  <cdumez@apple.com>
2052
2053         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
2054         https://bugs.webkit.org/show_bug.cgi?id=193740
2055         <rdar://problem/47527267>
2056
2057         Reviewed by Alex Christensen.
2058
2059         Add API test coverage.
2060
2061         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2062
2063 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
2064
2065         [ews-app] Add display name field to BuilderMapping model
2066         https://bugs.webkit.org/show_bug.cgi?id=194153
2067
2068         Reviewed by Lucas Forschler.
2069
2070         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2071         (BuilderMapping):
2072
2073 2019-02-01  Youenn Fablet  <youenn@apple.com>
2074
2075         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
2076         https://bugs.webkit.org/show_bug.cgi?id=194155
2077
2078         Reviewed by Eric Carlson.
2079
2080         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
2081         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
2082         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
2083
2084 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2085
2086         [LFC] Adjust replaced element's intrinsic ratio
2087         https://bugs.webkit.org/show_bug.cgi?id=194154
2088
2089         Reviewed by Antti Koivisto.
2090
2091         761
2092
2093         * LayoutReloaded/misc/LFC-passing-tests.txt:
2094
2095 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2096
2097         [WPE] Show test results in minibrowser
2098         https://bugs.webkit.org/show_bug.cgi?id=194150
2099
2100         Reviewed by Žan Doberšek.
2101
2102         * Scripts/webkitpy/port/wpe.py:
2103         (WPEPort.show_results_html_file):
2104
2105 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2106
2107         [WPE] MiniBrowser: add ky bindings for back/forward navigation
2108         https://bugs.webkit.org/show_bug.cgi?id=194151
2109
2110         Reviewed by Žan Doberšek.
2111
2112         ALT + <- go back
2113         ALT + -> go forward
2114
2115         * MiniBrowser/wpe/main.cpp:
2116         (main):
2117
2118 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2119
2120         [LFC] Set intrinsic size on Layout::Replaced
2121         https://bugs.webkit.org/show_bug.cgi?id=194139
2122
2123         Reviewed by Antti Koivisto.
2124
2125         744
2126
2127         * LayoutReloaded/misc/LFC-passing-tests.txt:
2128
2129 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2130
2131         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
2132         https://bugs.webkit.org/show_bug.cgi?id=194146
2133
2134         Reviewed by Xabier Rodriguez-Calvar.
2135
2136         It allows to open relative paths.
2137
2138         * MiniBrowser/wpe/main.cpp:
2139         (main):
2140
2141 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
2142
2143         Update flakiness dashboard configuration after recent queue changes
2144         https://bugs.webkit.org/show_bug.cgi?id=194127
2145
2146         Rubber-stamped by Aakash Jain.
2147
2148         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
2149
2150         * TestResultServer/static-dashboards/builders.jsonp:
2151
2152 2019-01-31  Youenn Fablet  <youenn@apple.com>
2153
2154         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
2155         https://bugs.webkit.org/show_bug.cgi?id=194106
2156         <rdar://problem/47676333>
2157
2158         Reviewed by Ryosuke Niwa.
2159
2160         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2161         (TestWebKitAPI::didFinishNavigation):
2162         (TestWebKitAPI::TEST):
2163         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
2164
2165 2019-01-31  Chris Dumez  <cdumez@apple.com>
2166
2167         Page zoom level is lost after a process swap or a crash
2168         https://bugs.webkit.org/show_bug.cgi?id=194105
2169         <rdar://problem/47610781>
2170
2171         Reviewed by Alex Christensen.
2172
2173         Add API test coverage.
2174
2175         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2176         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
2177
2178 2019-01-31  Alex Christensen  <achristensen@webkit.org>
2179
2180         Revert r238819 which is unneeded and caused a performance regression.
2181         https://bugs.webkit.org/show_bug.cgi?id=192272
2182         <rdar://problem/46664625>
2183
2184         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
2185         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
2186         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
2187
2188 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
2189
2190         Formalize WebKitAdditions mechanism of LoadOptimizer
2191         https://bugs.webkit.org/show_bug.cgi?id=193886
2192         <rdar://problem/47696809>
2193
2194         Reviewed by Brent Fulgham.
2195
2196         * MiniBrowser/MiniBrowser.entitlements:
2197         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
2198
2199 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2200
2201         [LFC] Margin before/after/start/end initial value is 0 and not auto.
2202         https://bugs.webkit.org/show_bug.cgi?id=194090
2203
2204         Reviewed by Antti Koivisto.
2205
2206         * LayoutReloaded/misc/LFC-passing-tests.txt:
2207
2208 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2209
2210         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
2211         https://bugs.webkit.org/show_bug.cgi?id=194074
2212
2213         Reviewed by Antti Koivisto.
2214
2215         * LayoutReloaded/misc/LFC-passing-tests.txt:
2216
2217 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2218
2219         [LFC][BFC] Add support for block level replaced box.
2220         https://bugs.webkit.org/show_bug.cgi?id=194071
2221
2222         Reviewed by Antti Koivisto.
2223
2224         * LayoutReloaded/misc/LFC-passing-tests.txt:
2225
2226 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
2227
2228         Fix WebKitTestRunner's testPath with Windows full paths
2229         https://bugs.webkit.org/show_bug.cgi?id=194012
2230
2231         Reviewed by Alex Christensen.
2232
2233         updateTestOptionsFromTestHeader failed to open test files because
2234         testPath returned wrong file paths. It returned a path "/C:/..."
2235         if a URL "file:///C:/..." was given.
2236
2237         * WebKitTestRunner/TestController.cpp:
2238         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
2239
2240 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2241
2242         [WPE] Bump font related dependencies to match the GTK+ port
2243         https://bugs.webkit.org/show_bug.cgi?id=194017
2244
2245         Reviewed by Žan Doberšek.
2246
2247         * wpe/jhbuild.modules:
2248         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
2249         * wpe/patches/icudata-stdlibs.patch: Added.
2250
2251 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
2252
2253         Enable swipe tests on iOS
2254         https://bugs.webkit.org/show_bug.cgi?id=194076
2255
2256         Reviewed by Geoffrey Garen.
2257
2258         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
2259         it causes a debug assertion failure in runUIScript.
2260
2261         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2262         (WTR::UIScriptController::beginBackSwipe):
2263         (WTR::UIScriptController::completeBackSwipe):
2264
2265 2019-01-30  Keith Rollin  <krollin@apple.com>
2266
2267         Use correct printf format specifier
2268         https://bugs.webkit.org/show_bug.cgi?id=194062
2269         <rdar://problem/47686167>
2270
2271         Reviewed by Alexey Proskuryakov.
2272
2273         LayoutTestSpellChecker.mm is trying to format a variable of type
2274         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
2275         actually an unsigned long long. Fix this by formatting with %llu.
2276
2277         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
2278         (-[LayoutTestTextCheckingResult description]):
2279
2280 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
2281
2282         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
2283         https://bugs.webkit.org/show_bug.cgi?id=193979
2284
2285         Reviewed by Wenson Hsieh.
2286
2287         Fix the test for iOS. Make the test work with iOS UA string.
2288
2289         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2290
2291 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
2292
2293         Replace High Sierra LLINT CLoop bot due to hardware failure
2294         https://bugs.webkit.org/show_bug.cgi?id=194066
2295
2296         Reviewed by Aakash Jain.
2297
2298         * BuildSlaveSupport/build.webkit.org-config/config.json:
2299
2300 2019-01-30  Keith Rollin  <krollin@apple.com>
2301
2302         [NSDragItem init] is unavailable
2303         https://bugs.webkit.org/show_bug.cgi?id=194059
2304         <rdar://problem/47685715>
2305
2306         Reviewed by Wenson Hsieh.
2307
2308         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
2309         DumpRenderTree and TestWebKitAPI, which both try to create an
2310         NSDragItem in a manner that invokes this method. Address this by using
2311         -initWithPasteboardWriter instead.
2312
2313         Note that the parameter passed to initWithPasteboardWriter is likely
2314         incorrect. In both cases, the object passed does not conform to
2315         NSPasteboardWriting. However, with this fix, we're no worse off than
2316         before, and can now perform builds with newer compilers and SDKs until
2317         a real fix can be crafted. That work is tracked in
2318         https://bugs.webkit.org/show_bug.cgi?id=194060
2319
2320         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2321         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
2322         * TestWebKitAPI/mac/TestDraggingInfo.mm:
2323         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
2324
2325 2019-01-30  Daniel Bates  <dabates@apple.com>
2326
2327         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
2328         https://bugs.webkit.org/show_bug.cgi?id=192824
2329         <rdar://problem/47100332>
2330
2331         Reviewed by Wenson Hsieh.
2332
2333         Fix a bug where the wrong usage code was used for F13 thru F24.
2334
2335         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2336         (keyCodeForDOMFunctionKey):
2337
2338 2019-01-30  Chris Dumez  <cdumez@apple.com>
2339
2340         Regression(PSON) Load hang can occur on history navigation
2341         https://bugs.webkit.org/show_bug.cgi?id=194030
2342         <rdar://problem/47656939>
2343
2344         Reviewed by Antti Koivisto.
2345
2346         Add API test coverage.
2347
2348         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2349
2350 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2351
2352         [LFC] Expand tests coverage.
2353
2354         Unreviewed test gardening.
2355
2356         * LayoutReloaded/misc/LFC-passing-tests.txt:
2357
2358 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
2359
2360         [Flatpak] Add openjpeg support
2361         https://bugs.webkit.org/show_bug.cgi?id=194019
2362
2363         Reviewed by Michael Catanzaro.
2364
2365         * flatpak/org.webkit.CommonModules.yaml:
2366
2367 2019-01-30  Commit Queue  <commit-queue@webkit.org>
2368
2369         Unreviewed, rolling out r240708.
2370         https://bugs.webkit.org/show_bug.cgi?id=194022
2371
2372         It broke WPE build (Requested by KaL on #webkit).
2373
2374         Reverted changeset:
2375
2376         "[WPE] Bump font related dependencies to match the GTK+ port"
2377         https://bugs.webkit.org/show_bug.cgi?id=194017
2378         https://trac.webkit.org/changeset/240708
2379
2380 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2381
2382         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
2383         https://bugs.webkit.org/show_bug.cgi?id=194001
2384
2385         Reviewed by Antti Koivisto.
2386
2387         * LayoutReloaded/misc/LFC-passing-tests.txt:
2388
2389 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2390
2391         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
2392         https://bugs.webkit.org/show_bug.cgi?id=194020
2393
2394         Reviewed by Antti Koivisto.
2395
2396         * LayoutReloaded/misc/LFC-passing-tests.txt:
2397
2398 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
2399
2400         AX: Support color well on iOS
2401         https://bugs.webkit.org/show_bug.cgi?id=194010
2402
2403         Reviewed by Joanmarie Diggs.
2404
2405         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2406         (WTR::AccessibilityUIElement::stringAttributeValue):
2407
2408 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2409
2410         [WPE] Bump font related dependencies to match the GTK+ port
2411         https://bugs.webkit.org/show_bug.cgi?id=194017
2412
2413         Reviewed by Žan Doberšek.
2414
2415         * wpe/jhbuild.modules:
2416         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
2417         * wpe/patches/icudata-stdlibs.patch: Added.
2418
2419 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
2420
2421         [Mac] Update window scale API usage
2422         https://bugs.webkit.org/show_bug.cgi?id=193991
2423         rdar://problem/47614795
2424
2425         Reviewed by Tim Horton.
2426
2427         * DumpRenderTree/mac/DumpRenderTree.mm:
2428         (changeWindowScaleIfNeeded):
2429         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2430         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2431         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
2432
2433 2019-01-29  Chris Dumez  <cdumez@apple.com>
2434
2435         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
2436         https://bugs.webkit.org/show_bug.cgi?id=193977
2437         <rdar://problem/47643716>
2438
2439         Reviewed by Geoff Garen.
2440
2441         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
2442         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
2443         to the previous provisional committing *before* we make the last load. 
2444
2445         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2446
2447 2019-01-29  Youenn Fablet  <youenn@apple.com>
2448
2449         Adopt new SPI to evaluate server certificate trust
2450         https://bugs.webkit.org/show_bug.cgi?id=193355
2451
2452         Reviewed by Alex Christensen.
2453
2454         Add infrastructure to handle HTTPS server trust evaluation testing.
2455
2456         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2457         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2458         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
2459         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
2460         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
2461         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2462         * WebKitTestRunner/TestController.cpp:
2463         (WTR::TestController::resetPreferencesToConsistentValues):
2464         (WTR::TestController::didReceiveAuthenticationChallenge):
2465         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
2466         * WebKitTestRunner/TestController.h:
2467         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
2468         * WebKitTestRunner/TestInvocation.cpp:
2469         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2470         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2471         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
2472
2473 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2474
2475         [ews-build] Add build step to print bot Configuration
2476         https://bugs.webkit.org/show_bug.cgi?id=193887
2477
2478         Reviewed by Lucas Forschler.
2479
2480         * BuildSlaveSupport/ews-build/steps.py:
2481         (PrintConfiguration): Build step to print configuration.
2482         * BuildSlaveSupport/ews-build/factories.py:
2483
2484 2019-01-29  Chris Dumez  <cdumez@apple.com>
2485
2486         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
2487         https://bugs.webkit.org/show_bug.cgi?id=193967
2488         <rdar://problem/47635348>
2489
2490         Reviewed by Alex Christensen.
2491
2492         Add API test coverage.
2493
2494         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2495         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
2496
2497 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2498
2499         [ews-app] Handle incoming results data
2500         https://bugs.webkit.org/show_bug.cgi?id=193973
2501
2502         Reviewed by Lucas Forschler.
2503
2504         * BuildSlaveSupport/ews-app/ews/views/results.py:
2505
2506 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2507
2508         [ews-app] Make the results url generic
2509         https://bugs.webkit.org/show_bug.cgi?id=193928
2510
2511         Reviewed by Lucas Forschler.
2512
2513         * BuildSlaveSupport/ews-app/ews/urls.py:
2514
2515 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2516
2517         [ews-build] Configure buildbot to send events to ews-app
2518         https://bugs.webkit.org/show_bug.cgi?id=193968
2519
2520         Reviewed by Lucas Forschler.
2521
2522         * BuildSlaveSupport/ews-build/events.py: Added.
2523         * BuildSlaveSupport/ews-build/master.cfg:
2524
2525 2019-01-29  Keith Rollin  <krollin@apple.com>
2526
2527         Add .xcfilelists to Run Script build phases
2528         https://bugs.webkit.org/show_bug.cgi?id=193792
2529         <rdar://problem/47201785>
2530
2531         Reviewed by Alex Christensen.
2532
2533         As part of supporting XCBuild, update the necessary Run Script build
2534         phases in their Xcode projects to refer to their associated
2535         .xcfilelist files.
2536
2537         Note that the addition of these files bumps the Xcode project version
2538         number to something that's Xcode 10 compatible. This change means that
2539         older versions of the Xcode IDE can't read these projects. Nor can it
2540         fully load workspaces that refer to these projects (the updated
2541         projects are shown as non-expandable placeholders). `xcodebuild` can
2542         still build these projects; it's just that the IDE can't open them.
2543
2544         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2545         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2546
2547 2019-01-29  John Wilander  <wilander@apple.com>
2548
2549         Add data abstraction and validation for Ad Click Attribution
2550         https://bugs.webkit.org/show_bug.cgi?id=193916
2551         <rdar://problem/47603481>
2552
2553         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
2554
2555         Ad click attribution has two steps. First, the storage of an ad
2556         campaign ID for a click that takes the user to a destination
2557         site. Second, a conversion on the destination site that can be
2558         attributed to the ad click.
2559
2560         This patch adds a class that represents a request for ad click
2561         attribution. Validation makes sure that the bits of entropy
2562         reported through this mechanism is limited.
2563
2564         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2565         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
2566         (TestWebKitAPI::TEST):
2567
2568 2019-01-29  Chris Dumez  <cdumez@apple.com>
2569
2570         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
2571         https://bugs.webkit.org/show_bug.cgi?id=193932
2572         <rdar://problem/47598947>
2573
2574         Reviewed by Brady Eidson.
2575
2576         Add API test coverage.
2577
2578         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2579
2580 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2581
2582         Adding new passing LFC tests.
2583
2584         Unreviewed test gardening.
2585
2586         * LayoutReloaded/misc/LFC-passing-tests.txt:
2587
2588 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2589
2590         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
2591         https://bugs.webkit.org/show_bug.cgi?id=193964
2592
2593         Reviewed by Antti Koivisto.
2594
2595         * LayoutReloaded/misc/LFC-passing-tests.txt:
2596
2597 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2598
2599         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
2600         https://bugs.webkit.org/show_bug.cgi?id=193954
2601
2602         Reviewed by Antti Koivisto.
2603
2604         * LayoutReloaded/misc/LFC-passing-tests.txt:
2605
2606 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2607
2608         WebDriver: add support for running subtests
2609         https://bugs.webkit.org/show_bug.cgi?id=193904
2610
2611         Reviewed by Michael Catanzaro.
2612
2613         pytest already supports it by passing test.py::subtest, so we can do the same.
2614
2615         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
2616         (get_item_name): Made this global.
2617         (CollectRecorder.__init__): Receive the parameter to ignore.
2618         (CollectRecorder.pytest_collectreport): Collect also the subtests.
2619         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
2620         (collect): Add parameter to ignore.
2621         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
2622         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
2623         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
2624         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
2625         (WebDriverTestRunnerSelenium.run): Ditto.
2626         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
2627         (WebDriverTestRunnerW3C.collect_tests): Ditto.
2628         (WebDriverTestRunnerW3C.run): Ditto.
2629
2630 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
2631
2632         User agent string override for navigator.userAgent should be site specific quirks
2633         https://bugs.webkit.org/show_bug.cgi?id=193950
2634
2635         Reviewed by Brent Fulgham.
2636
2637         Updated per the _WKWebsitePolicies rename.
2638
2639         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2640         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2641
2642 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
2643
2644         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
2645         https://bugs.webkit.org/show_bug.cgi?id=193941
2646
2647         Reviewed by Alex Christensen.
2648
2649         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
2650         * TestWebKitAPI/Tests/WTF/Condition.cpp:
2651         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2652         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
2653         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2654         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
2655         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
2656         * TestWebKitAPI/Tests/WTF/Time.cpp:
2657         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
2658         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
2659         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2660         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
2661
2662 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
2663
2664         Unreviewed, reorder my emails to fix autocomplete in bugzilla
2665
2666         * Scripts/webkitpy/common/config/contributors.json:
2667
2668 2019-01-28  Andy Estes  <aestes@apple.com>
2669
2670         [watchOS] Enable Parental Controls content filtering
2671         https://bugs.webkit.org/show_bug.cgi?id=193939
2672         <rdar://problem/46641912>
2673
2674         Reviewed by Ryosuke Niwa.
2675
2676         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2677
2678 2019-01-28  David Kilzer  <ddkilzer@apple.com>
2679
2680         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
2681         <https://webkit.org/b/193884>
2682
2683         Reviewed by Jiewen Tan.
2684
2685         * Scripts/webkitpy/style/checkers/cpp.py:
2686         (check_language): Add LocalAuthentication to
2687         `frameworks_with_soft_links`.
2688
2689 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
2690
2691         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
2692         https://bugs.webkit.org/show_bug.cgi?id=193891
2693
2694         Reviewed by Ross Kirsling.
2695
2696         There were three problems in window sizes of WebView and the host window.
2697         1. The sizes of pixel image output were incorrect.
2698         2. The host window is going to appear after window.resize was invoked.
2699         3. window.resize resized only the host window, not WebView.
2700
2701         This change solves them with a following approach.
2702         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
2703         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
2704            as well as DumpRenderTree in order to match the client area and the window area.
2705         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
2706         d. PlatformWebView::setWindowFrame changes both window sizes.
2707         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
2708
2709         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2710         (WTR::PlatformWebView::PlatformWebView): Create the host window
2711         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
2712         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
2713         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
2714
2715 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2716
2717         [ews-app] Add method to save Step data to database
2718         https://bugs.webkit.org/show_bug.cgi?id=193890
2719
2720         Reviewed by Lucas Forschler.
2721
2722         * BuildSlaveSupport/ews-app/ews/models/step.py:
2723         (Step.save_step): Method to save step data.
2724         (Step.update_step): Method to update step data.
2725         (Step.get_existing_step): Method to fetch existing step from database.
2726         (Step.is_valid_result): Method to validate valid step result.
2727
2728 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2729
2730         [ews-app] Add method to save Build data to database
2731         https://bugs.webkit.org/show_bug.cgi?id=193735
2732
2733         Reviewed by Lucas Forschler.
2734
2735         * BuildSlaveSupport/ews-app/ews/models/build.py:
2736         (Build.save_build): Method to save build information to database.
2737         (Build.get_existing_build): Method to fetch existing build from database.
2738         (Build.is_valid_result): Method to validate build result.
2739         * BuildSlaveSupport/ews-app/ews/common/util.py:
2740         (is_valid_int_id): Method to validate valid id.
2741
2742 2019-01-28  Chris Dumez  <cdumez@apple.com>
2743
2744         Regression(PSON) Crash under WebPageProxy::didStartProgress()
2745         https://bugs.webkit.org/show_bug.cgi?id=193915
2746         <rdar://problem/47560907>
2747
2748         Reviewed by Alex Christensen.
2749
2750         Add API test coverage.
2751
2752         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2753
2754 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2755
2756         [ews-app] Rename id variables
2757         https://bugs.webkit.org/show_bug.cgi?id=193883
2758
2759         Reviewed by Lucas Forschler.
2760
2761         * BuildSlaveSupport/ews-app/ews/models/build.py:
2762         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2763         * BuildSlaveSupport/ews-app/ews/models/step.py:
2764         * BuildSlaveSupport/ews-app/ews/urls.py:
2765         * BuildSlaveSupport/ews-app/ews/views/patch.py:
2766         * BuildSlaveSupport/ews-app/ews/views/results.py:
2767         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2768
2769 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2770
2771         [ews-app] Allow certain fields to be empty
2772         https://bugs.webkit.org/show_bug.cgi?id=193892
2773
2774         Reviewed by Lucas Forschler.
2775
2776         * BuildSlaveSupport/ews-app/ews/models/build.py:
2777         * BuildSlaveSupport/ews-app/ews/models/step.py:
2778
2779 2019-01-28  Rob Buis  <rbuis@igalia.com>
2780
2781         Update MIME type parser
2782         https://bugs.webkit.org/show_bug.cgi?id=180526
2783
2784         Reviewed by Frédéric Wang.
2785
2786         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
2787         (TestWebKitAPI::TEST):
2788
2789 2019-01-28  Zalan Bujtas  <zalan@apple.com>
2790
2791         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
2792         https://bugs.webkit.org/show_bug.cgi?id=193896
2793
2794         Reviewed by Antti Koivisto.
2795
2796         * LayoutReloaded/misc/LFC-passing-tests.txt:
2797
2798 2018-12-15  Darin Adler  <darin@apple.com>
2799
2800         Replace many uses of String::format with more type-safe alternatives
2801         https://bugs.webkit.org/show_bug.cgi?id=192742
2802
2803         Reviewed by Mark Lam.
2804
2805         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2806         (WTR::cacheTestRunnerCallback): Use makeString.
2807         * WebKitTestRunner/TestController.cpp:
2808         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
2809         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
2810
2811 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
2812
2813         Use a load optimizer for some sites
2814         https://bugs.webkit.org/show_bug.cgi?id=193881
2815         <rdar://problem/46325455>
2816
2817         Reviewed by Brent Fulgham.
2818
2819         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2820         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
2821
2822 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
2823
2824         AX: Introduce a static accessibility tree
2825         https://bugs.webkit.org/show_bug.cgi?id=193348
2826         <rdar://problem/47203295>
2827
2828         Reviewed by Ryosuke Niwa.
2829
2830         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2831
2832 2019-01-26  Zalan Bujtas  <zalan@apple.com>
2833
2834         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
2835         https://bugs.webkit.org/show_bug.cgi?id=193867
2836
2837         Reviewed by Antti Koivisto.
2838
2839         * LayoutReloaded/misc/LFC-passing-tests.txt:
2840
2841 2019-01-26  Zalan Bujtas  <zalan@apple.com>
2842
2843         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
2844         https://bugs.webkit.org/show_bug.cgi?id=193865
2845
2846         Reviewed by Antti Koivisto.
2847
2848         * LayoutReloaded/misc/LFC-passing-tests.txt:
2849
2850 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
2851
2852         Need a mechanism to override navigator.userAgent
2853         https://bugs.webkit.org/show_bug.cgi?id=193762
2854         <rdar://problem/47504939>
2855
2856         Reviewed by Brent Fulgham.
2857
2858         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
2859
2860         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2861         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2862         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
2863
2864 2019-01-25  Dean Jackson  <dino@apple.com>
2865
2866         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
2867         https://bugs.webkit.org/show_bug.cgi?id=193831
2868         <rdar://problem/47399263>
2869
2870         Reviewed by Chris Dumez.
2871
2872         Two new tests that exercise cross-origin and same-origin System
2873         Previews.
2874
2875         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2876
2877 2019-01-25  Keith Rollin  <krollin@apple.com>
2878
2879         Update Xcode projects with "Check .xcfilelists" build phase
2880         https://bugs.webkit.org/show_bug.cgi?id=193790
2881         <rdar://problem/47201374>
2882
2883         Reviewed by Alex Christensen.
2884
2885         Support for XCBuild includes specifying inputs and outputs to various
2886         Run Script build phases. These inputs and outputs are specified as
2887         .xcfilelist files. Once created, these .xcfilelist files need to be
2888         kept up-to-date. In order to check that they are up-to-date or not,
2889         add an Xcode build step that invokes an external script that performs
2890         the checking. If the .xcfilelists are found to be out-of-date, update
2891         them, halt the build, and instruct the developer to restart the build
2892         with up-to-date files.
2893
2894         At this time, the checking and regenerating is performed only if the
2895         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
2896         who want to use this facility can set this variable and test out the
2897         checking/regenerating. Once it seems like there are no egregious
2898         issues that upset a developer's workflow, we'll unconditionally enable
2899         this facility.
2900
2901         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2902         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
2903         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
2904         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2905
2906 2019-01-25  Keith Rollin  <krollin@apple.com>
2907
2908         Update Xcode projects with "Apply Configuration to XCFileLists" build target
2909         https://bugs.webkit.org/show_bug.cgi?id=193781
2910         <rdar://problem/47201153>
2911
2912         Reviewed by Alex Christensen.
2913
2914         Part of generating the .xcfilelists used as part of adopting XCBuild
2915         includes running `make DerivedSources.make` from a standalone script.
2916         It’s important for this invocation to have the same environment as
2917         when the actual build invokes `make DerivedSources.make`. If the
2918         environments are different, then the two invocations will provide
2919         different results. In order to get the same environment in the
2920         standalone script, have the script launch xcodebuild targeting the
2921         "Apply Configuration to XCFileLists" build target, which will then
2922         re-invoke our standalone script. The script is now running again, this
2923         time in an environment with all workspace, project, target, xcconfig
2924         and other environment variables established.
2925
2926         The "Apply Configuration to XCFileLists" build target accomplishes
2927         this task via a small embedded shell script that consists only of:
2928
2929             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
2930
2931         The process that invokes "Apply Configuration to XCFileLists" first
2932         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
2933         evaluated and exports it into the shell environment. When xcodebuild
2934         is invoked, it inherits the value of this variable and can `eval` the
2935         contents of that variable. Our external standalone script can then set
2936         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
2937         of command-line parameters needed to restart itself in the appropriate
2938         state.
2939
2940         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2941         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2942
2943 2019-01-25  Alex Christensen  <achristensen@webkit.org>
2944
2945         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
2946         https://bugs.webkit.org/show_bug.cgi?id=193802
2947         <rdar://problem/46010580>
2948
2949         Reviewed by Andy Estes.
2950
2951         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2952         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
2953         (TEST):
2954
2955 2019-01-25  Daniel Bates  <dabates@apple.com>
2956
2957         [iOS] uiController.keyDown() does not translate Control modified key
2958         https://bugs.webkit.org/show_bug.cgi?id=192898
2959
2960         Reviewed by Wenson Hsieh.
2961
2962         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
2963         key translation, as applicable. Among other cases, key translation occurs when performing
2964         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
2965         also makes the behavior of uiController.keyDown() more closely match the behavior of a
2966         human pressing down and releasing key(s) using a hardware keyboard.
2967
2968         * WebKitTestRunner/ios/HIDEventGenerator.h:
2969         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2970         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
2971
2972         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
2973         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
2974         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2975         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2976         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
2977         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2978         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
2979         (-[HIDEventGenerator longPress:completionBlock:]):
2980         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
2981         Update code for above renaming.
2982
2983         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
2984         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
2985
2986         (-[HIDEventGenerator keyDown:]): Added.
2987         (-[HIDEventGenerator keyUp:]): Added.
2988         (-[HIDEventGenerator keyPress:completionBlock:]):
2989         (-[HIDEventGenerator eventDispatchThreadEntry:]):
2990         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
2991         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2992         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
2993         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
2994         (WTR::parseModifier): Deleted.
2995
2996 2019-01-25  Keith Rollin  <krollin@apple.com>
2997
2998         Complete the implementation of generate-xcfilelists
2999         https://bugs.webkit.org/show_bug.cgi?id=193782
3000
3001         Reviewed by Alex Christensen.
3002
3003         A preliminary version of generate-xcfilelists was added in r238008.
3004         This patch updates that script in order to:
3005
3006         - Support checking of .xcfilelists
3007         - Perform better execution of `make DerivedSources.make` by
3008           relaunching generate-xcfilelists under xcodebuild
3009         - Support incremental generation and checking of .xcfilelists
3010         - Support supplementary .xcfilelists files from WebKitAdditions
3011         - Support being wrapped by parallel version of generate-xcfilelists in
3012           Internal that adds support for (re)generating WebKit projects in
3013           that repo.
3014         - Support builds that have been performed in WebKitBuild as well as
3015           ~/Library/Developer/code/DerivedData
3016         - Increase robustness and debugging facilities.
3017
3018         * Scripts/generate-xcfilelists:
3019
3020 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
3021
3022         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3023         https://bugs.webkit.org/show_bug.cgi?id=193297
3024         <rdar://problem/47158841>
3025
3026         Unreviewed test case fix.
3027
3028         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
3029         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
3030
3031         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3032         (TEST):
3033
3034 2019-01-25  Keith Rollin  <krollin@apple.com>
3035
3036         Update existing .xcfilelists
3037         https://bugs.webkit.org/show_bug.cgi?id=193791
3038         <rdar://problem/47201706>
3039
3040         Reviewed by Alex Christensen.
3041
3042         Many .xcfilelist files were added in r238824 in order to support
3043         XCBuild. Update these with recent changes to the set of build files
3044         and with the current generate-xcfilelist script.
3045
3046         * DumpRenderTree/DerivedSources-input.xcfilelist:
3047         * DumpRenderTree/DerivedSources-output.xcfilelist:
3048         * WebKitTestRunner/DerivedSources-input.xcfilelist:
3049         * WebKitTestRunner/DerivedSources-output.xcfilelist:
3050
3051 2019-01-25  Keith Rollin  <krollin@apple.com>
3052
3053         Fix missing dependencies in extract-dependencies-from-makefile
3054         https://bugs.webkit.org/show_bug.cgi?id=193783
3055         <rdar://problem/47201571>
3056
3057         Reviewed by Alex Christensen.
3058
3059         The extract-dependencies-from-makefile script generates .xcfilelists
3060         for XCBuild by invoking a makefile in --debug mode, parsing the
3061         dependency information in the output, and extracting information
3062         regarding targets and dependents. However, the way `make` emits this
3063         dependency information is not rigorous, and so we need to determine
3064         what lines to look for and parse by trial and error. This approach
3065         didn't coriginally atch all the information we needed to collect, so
3066         update the script to look for the additional lines we now know to look
3067         for.
3068
3069         * Scripts/extract-dependencies-from-makefile:
3070         (Parser):
3071         (Parser.addTarget):
3072         (Parser.addPrereq):
3073         (Parser.doParse):
3074
3075 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
3076
3077         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3078         https://bugs.webkit.org/show_bug.cgi?id=193297
3079         <rdar://problem/47158841>
3080
3081         Reviewed by Alex Christensen.
3082
3083         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
3084             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
3085         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3086         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
3087         activating the message used to trigger the callback when it is set.
3088
3089 2019-01-25  Alex Christensen  <achristensen@webkit.org>
3090
3091         WKWebView.goBack should reload if there is a safe browsing warning
3092         https://bugs.webkit.org/show_bug.cgi?id=193805
3093         <rdar://problem/46908216>
3094
3095         Reviewed by Geoff Garen.
3096
3097         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3098         (+[Simple3LookupContext sharedLookupContext]):
3099         (-[Simple3LookupContext lookUpURL:completionHandler:]):
3100         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
3101         (TEST):
3102
3103 2019-01-25  Chris Dumez  <cdumez@apple.com>
3104
3105         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
3106         https://bugs.webkit.org/show_bug.cgi?id=193788
3107         <rdar://problem/47531231>
3108
3109         Reviewed by Alex Christensen.
3110
3111         Add API test coverage.
3112
3113         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3114         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
3115
3116 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
3117
3118         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
3119         https://bugs.webkit.org/show_bug.cgi?id=193771
3120
3121         Unreviewed infrastructure fix.
3122
3123         * Scripts/webkitpy/port/darwin.py:
3124         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
3125
3126 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
3127
3128         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
3129
3130 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
3131
3132         Add contributors.json entries for Ling Ho and for a new bot watchers group.
3133
3134         * Scripts/webkitpy/common/config/contributors.json:
3135
3136 2019-01-25  Chris Dumez  <cdumez@apple.com>
3137
3138         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
3139         https://bugs.webkit.org/show_bug.cgi?id=193779
3140         <rdar://problem/46170903>
3141
3142         Reviewed by Antti Koivisto.
3143
3144         Add API test that quickly navigates forward to a previous process without waiting for it to
3145         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
3146         the process' previous page when reconnecting the it for the forward navigation.
3147
3148         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3149
3150 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3151
3152         Need a way for JavaScript (or bundle) code to participate in undo
3153         https://bugs.webkit.org/show_bug.cgi?id=190009
3154         <rdar://problem/44807048>
3155
3156         Reviewed by Ryosuke Niwa.
3157
3158         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
3159         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
3160
3161         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3162         (WTR::UIScriptController::lastUndoLabel const):
3163         (WTR::UIScriptController::firstRedoLabel const):
3164         (WTR::UIScriptController::platformUndoManager const):
3165         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3166         (WTR::UIScriptController::lastUndoLabel const):
3167         (WTR::UIScriptController::firstRedoLabel const):
3168         (WTR::UIScriptController::platformUndoManager const):
3169         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3170         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3171         (WTR::UIScriptController::lastUndoLabel const):
3172         (WTR::UIScriptController::firstRedoLabel const):
3173         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3174         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3175         (WTR::UIScriptController::lastUndoLabel const):
3176         (WTR::UIScriptController::firstRedoLabel const):
3177         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3178         (WTR::UIScriptController::platformUndoManager const):
3179         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3180         (WTR::UIScriptController::platformUndoManager const):
3181
3182 2019-01-25  Zalan Bujtas  <zalan@apple.com>
3183
3184         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
3185         https://bugs.webkit.org/show_bug.cgi?id=193824
3186
3187         Reviewed by Antti Koivisto.
3188
3189         * LayoutReloaded/misc/LFC-passing-tests.txt:
3190
3191 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
3192
3193         Update macOS JSC bot configurations
3194         https://bugs.webkit.org/show_bug.cgi?id=193739
3195
3196         Reviewed by Alexey Proskuryakov.
3197
3198         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
3199         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3200         (BubbleQueueServer): Move JSC EWS to Mojave section.
3201         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3202         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
3203         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
3204
3205 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
3206
3207         [Win][WebKitTestRunner] Implement EventSenderProxy
3208         https://bugs.webkit.org/show_bug.cgi?id=193755
3209
3210         Reviewed by Don Olmstead.
3211
3212         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
3213         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
3214         (WTR::EventSenderProxy::dispatchMessage):
3215         (WTR::EventSenderProxy::EventSenderProxy):
3216         (WTR::EventSenderProxy::mouseDown):
3217         (WTR::EventSenderProxy::mouseUp):
3218         (WTR::EventSenderProxy::mouseMoveTo):
3219         (WTR::EventSenderProxy::mouseScrollBy):
3220         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
3221
3222 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
3223
3224         Unreviewed fix for API test failure after r240437.
3225
3226         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
3227
3228         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
3229
3230 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
3231
3232         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
3233         https://bugs.webkit.org/show_bug.cgi?id=193787
3234         <rdar://problem/47497634>
3235
3236         Reviewed by Alexey Proskuryakov.
3237
3238         * Scripts/webkitdirs.pm:
3239         (iosSimulatorApplicationsPath): Pick from available runtime directories.
3240
3241 2019-01-24  Truitt Savell  <tsavell@apple.com>
3242
3243         Unreviewed, rolling out r240446.
3244
3245         Casued 5 API failures
3246
3247         Reverted changeset:
3248
3249         "Activate the WebResourceLoadStatisticsStore in the
3250         NetworkProcess and deactivate it in the UIProcess."
3251         https://bugs.webkit.org/show_bug.cgi?id=193297
3252         https://trac.webkit.org/changeset/240446
3253
3254 2019-01-24  Zalan Bujtas  <zalan@apple.com>
3255
3256         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
3257         https://bugs.webkit.org/show_bug.cgi?id=193741
3258         <rdar://problem/47135030>
3259
3260         Reviewed by Antti Koivisto and Simon Fraser.
3261
3262         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3263         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
3264         (TestWebKitAPI::TEST):
3265
3266 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
3267
3268         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3269         https://bugs.webkit.org/show_bug.cgi?id=193297
3270         <rdar://problem/47158841>
3271
3272         Reviewed by Alex Christensen.
3273
3274         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3275         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
3276         activating the message used to trigger the callback when it is set.
3277
3278 2019-01-24  John Wilander  <wilander@apple.com>
3279
3280         Add Ad Click Attribution as an internal/experimental feature
3281         https://bugs.webkit.org/show_bug.cgi?id=193685
3282         <rdar://problem/47450399>
3283
3284         Reviewed by Brent Fulgham.
3285
3286         Added test option adClickAttributionEnabled.
3287
3288         * DumpRenderTree/TestOptions.cpp:
3289         (TestOptions::TestOptions):
3290         * DumpRenderTree/TestOptions.h:
3291         * DumpRenderTree/mac/DumpRenderTree.mm:
3292         (setWebPreferencesForTestOptions):
3293
3294 2019-01-24  Antti Koivisto  <antti@apple.com>
3295
3296         [PSON] Flash on back navigation on Mac
3297         https://bugs.webkit.org/show_bug.cgi?id=193716
3298         <rdar://problem/47148458>
3299
3300         Reviewed by Chris Dumez.
3301
3302         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3303
3304         Closing of the previous page is delayed so waiting for didFinishNavigation is
3305         not sufficient to guarantee we have received all the messages. Wait for them.
3306
3307 2019-01-24  Chris Dumez  <cdumez@apple.com>
3308
3309         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
3310         https://bugs.webkit.org/show_bug.cgi?id=193761
3311         <rdar://problem/47456405>
3312
3313         Reviewed by Alex Christensen.
3314
3315         Add API test coverage.
3316
3317         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3318
3319 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
3320
3321         webkitpy: Missing PID in crashlog name should not be fatal
3322         https://bugs.webkit.org/show_bug.cgi?id=193771
3323
3324         If we can't determine the PID of a crashlog, just ignore the crashlog instead
3325         of raising an exception.
3326
3327         Reviewed by Lucas Forschler.
3328
3329         * Scripts/webkitpy/port/darwin.py:
3330         (DarwinPort._merge_crash_logs):
3331
3332 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3333
3334         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
3335         https://bugs.webkit.org/show_bug.cgi?id=193746
3336
3337         Reviewed by Youenn Fablet.
3338
3339         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
3340         so we'd best just not call it.
3341
3342         * Scripts/webkitpy/w3c/test_exporter.py:
3343         (WebPlatformTestExporter.create_branch_with_patch):
3344
3345 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
3346
3347         Move FileSystem to WTF
3348         https://bugs.webkit.org/show_bug.cgi?id=193602
3349
3350         Reviewed by Yusuke Suzuki.
3351
3352         * DumpRenderTree/win/DumpRenderTree.cpp:
3353         * TestWebKitAPI/CMakeLists.txt:
3354         * TestWebKitAPI/PlatformGTK.cmake:
3355         * TestWebKitAPI/PlatformJSCOnly.cmake:
3356         * TestWebKitAPI/PlatformPlayStation.cmake:
3357         * TestWebKitAPI/PlatformWPE.cmake:
3358         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3359         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
3360         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
3361         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
3362         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
3363         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
3364         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3365         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3366         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
3367         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3368
3369 2019-01-24  Philippe Normand  <pnormand@igalia.com>
3370
3371         [WPE] Remove hard dependency on subprocess32 for the API tests
3372
3373         Rubber-stamped by Carlos Garcia Campos.
3374
3375         * glib/api_test_runner.py:
3376         (TestRunner._run_test_qt): Lazily import subprocess32 and check
3377         its presence only when running WPEQt tests.
3378
3379 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3380
3381         [GLIB] Expose JavaScriptCore options in GLib public API
3382         https://bugs.webkit.org/show_bug.cgi?id=188742
3383
3384         Reviewed by Michael Catanzaro.
3385
3386         Add a test for the new API.
3387
3388         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3389         (testsJSCOptions):
3390         (main):
3391
3392 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3393
3394         [GTK][WPE] Support JPEG 2000 images
3395         https://bugs.webkit.org/show_bug.cgi?id=186272
3396
3397         Reviewed by Žan Doberšek.
3398
3399         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
3400
3401         * gtk/jhbuild.modules:
3402         * wpe/jhbuild.modules:
3403
3404 2019-01-23  David Kilzer  <ddkilzer@apple.com>
3405
3406         check-webkit-style should warn when using soft-linking macros in a header
3407         <https://webkit.org/b/193750>
3408
3409         Reviewed by Darin Adler.
3410
3411         * Scripts/webkitpy/style/checkers/cpp.py:
3412         (check_language): Add softlink/header check by refactoring the
3413         softlink/framework check.
3414         (CppChecker): Enable softlink/header check by default.
3415         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3416         (CppStyleTest.test_softlink_framework): Rename from
3417         CppStyleTest.test_softlink() and change test framework name in
3418         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
3419         files. Set file_name for macros that only appear in headers.
3420         (CppStyleTest.test_softlink_header): Add tests for using
3421         soft-link macros in headers.
3422
3423 2019-01-23  Chris Dumez  <cdumez@apple.com>
3424
3425         Deprecate API to limit the maximum number of WebProcesses
3426         https://bugs.webkit.org/show_bug.cgi?id=193725
3427         <rdar://problem/47464879>
3428
3429         Reviewed by Geoff Garen.
3430
3431         Update existing API tests to stop using deprecated API.
3432
3433         * MiniBrowser/mac/AppDelegate.m:
3434         (defaultConfiguration):
3435         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3436         (TestWebKitAPI::TEST):
3437         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
3438         (TestWebKitAPI::TEST):
3439         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3440         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
3441         (TEST):
3442         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
3443         (TEST):
3444
3445 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3446
3447         [ews-app] Rename ews model buildermappings to buildermapping
3448         https://bugs.webkit.org/show_bug.cgi?id=193729
3449
3450         Reviewed by Lucas Forschler.
3451
3452         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
3453         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
3454         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
3455
3456 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3457
3458         [ews-app] Rename ews model steps to step
3459         https://bugs.webkit.org/show_bug.cgi?id=193697
3460
3461         Reviewed by Lucas Forschler.
3462
3463         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
3464         (Step): Renamed Steps to Step.
3465
3466 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
3467
3468         Clean up IndexedDB files between tests
3469         https://bugs.webkit.org/show_bug.cgi?id=192796
3470         <rdar://problem/46824999>
3471
3472         Reviewed by Geoffrey Garen.
3473
3474         * DumpRenderTree/mac/DumpRenderTree.mm:
3475         (runTest):
3476         * WebKitTestRunner/TestController.cpp:
3477         (WTR::TestController::resetStateToConsistentValues):
3478         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
3479         (WTR::RemoveAllIndexedDatabasesCallback):
3480         (WTR::TestController::ClearIndexedDatabases):
3481         * WebKitTestRunner/TestController.h:
3482         * WebKitTestRunner/TestInvocation.cpp:
3483         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3484
3485 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3486
3487         [ews-app] Rename ews model Builds to Build
3488         https://bugs.webkit.org/show_bug.cgi?id=193695
3489
3490         Reviewed by Lucas Forschler.
3491
3492         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
3493         (Build): Renamed Builds to Build.
3494
3495 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
3496
3497         webkitpy: Wait longer when launching WebKitTestRunner
3498         https://bugs.webkit.org/show_bug.cgi?id=193734
3499
3500         Reviewed by Aakash Jain.
3501
3502         * Scripts/webkitpy/port/simulator_process.py:
3503         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
3504
3505 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
3506
3507         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
3508         https://bugs.webkit.org/show_bug.cgi?id=193182
3509         <rdar://problem/47452154>
3510
3511         Reviewed by Tim Horton.
3512
3513         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
3514         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
3515         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
3516
3517         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
3518         preventing later tests from recognizing gestures.
3519
3520         * WebKitTestRunner/ios/TestControllerIOS.mm:
3521         (WTR::TestController::platformResetStateToConsistentValues):
3522
3523         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
3524
3525 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
3526
3527         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
3528         https://bugs.webkit.org/show_bug.cgi?id=193722
3529         <rdar://problem/47481475>
3530
3531         Reviewed by Lucas Forschler.
3532
3533         iPhone and iPad ports should both use the iOS config.
3534
3535         * Scripts/webkitpy/port/ios_simulator.py:
3536         (IPhoneSimulatorPort.__init__):
3537         (IPadSimulatorPort.__init__):
3538
3539 2019-01-23  Rob Buis  <rbuis@igalia.com>
3540
3541         Update MIME type parser
3542         https://bugs.webkit.org/show_bug.cgi?id=180526
3543
3544         Reviewed by Frédéric Wang.
3545
3546         Add unit tests for both parse modes of ParsedContentType.
3547
3548         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3549         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
3550         (TestWebKitAPI::TEST):
3551
3552 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
3553
3554         [ews-app] fetch loop should not stop on network issues
3555         https://bugs.webkit.org/show_bug.cgi?id=193666
3556
3557         Reviewed by Lucas Forschler.
3558
3559         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3560         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
3561
3562 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3563
3564         [iOS] Multiple WKWebViewAutofillTests are flaky failures
3565         https://bugs.webkit.org/show_bug.cgi?id=189165
3566         <rdar://problem/47433765>
3567
3568         Reviewed by Tim Horton.
3569
3570         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
3571         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
3572         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
3573         process in sufficient to ensure that any previous action that blurred the focused element in the web process
3574         would make its way to the UI process by the time the layer tree commit is finished.
3575
3576         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
3577         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
3578         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
3579         will fail because it asks for -_autofillContext too early.
3580
3581         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
3582         is handled in the UI process.
3583
3584         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
3585
3586         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
3587         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
3588         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
3589         input session.
3590
3591         (-[AutofillTestView textInputHasAutofillContext]):
3592
3593         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
3594
3595         * TestWebKitAPI/cocoa/TestWKWebView.h:
3596         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3597         (nextInputSessionChangeCount):
3598
3599         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
3600         This includes changing the focused element from one to another.
3601
3602         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
3603         (-[TestWKWebView didStartFormControlInteraction]):
3604         (-[TestWKWebView didEndFormControlInteraction]):
3605         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
3606
3607         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
3608         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
3609         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
3610         that doesn't require an input session to one that doesn't.
3611
3612 2019-01-22  David Kilzer  <ddkilzer@apple.com>
3613
3614         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
3615         <https://webkit.org/b/193676>
3616
3617         Reviewed by Alexey Proskuryakov.
3618
3619         * Scripts/webkitpy/style/checkers/cpp.py:
3620         (check_member_initialization_list):
3621         - Don't report missing whitespace around colon if the colon at
3622           the start of the line is formatted correctly.
3623         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3624         (WebKitStyleTest.test_member_initialization_list):
3625         - Add a test for a missing permutation of existing tests.
3626         - Add a test this false-positive.
3627         - Add blank lines between subtests to make them easier to read.
3628
3629 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
3630
3631         [build.webkit.org] Unit-test failure after r237113
3632         https://bugs.webkit.org/show_bug.cgi?id=193669
3633
3634         Reviewed by Michael Catanzaro.
3635
3636         * BuildSlaveSupport/build.webkit.org-config/factories.py:
3637         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
3638         multiple or zero flags.
3639
3640 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
3641
3642         Cache bytecode to disk
3643         https://bugs.webkit.org/show_bug.cgi?id=192782
3644         <rdar://problem/46084932>
3645
3646         Reviewed by Keith Miller.
3647
3648         Add test helper to execute bytecode-cache tests: it executes each test
3649         twice, the first with JSC_diskCachePath set to a temporary directory
3650         and second with JSC_forceDiskCache=true (in addition to the cache path)
3651         to guarantee that only the disk cache is being used and no new
3652         UnlinkedCodeBlocks are being created.
3653
3654         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
3655         * Scripts/run-jsc-stress-tests:
3656
3657 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
3658
3659         [css-logical] Implement flow-relative margin, padding and border shorthands
3660         https://bugs.webkit.org/show_bug.cgi?id=188697
3661
3662         Reviewed by Simon Fraser and Antti Koivisto.
3663
3664         * DumpRenderTree/TestOptions.cpp:
3665         (TestOptions::TestOptions):
3666         * DumpRenderTree/TestOptions.h:
3667         * DumpRenderTree/mac/DumpRenderTree.mm:
3668         (setWebPreferencesForTestOptions):
3669         Allow tests to enable the CSSLogicalEnabled flag in WK1.
3670
3671         * Scripts/webkitpy/style/checkers/jsonchecker.py:
3672         (JSONCSSPropertiesChecker.check_codegen_properties):
3673         Allow CSS property definitions to have a 'runtime-flag' parameter which
3674         disables the property when the specified runtime flag is disabled.
3675
3676 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
3677
3678         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
3679         https://bugs.webkit.org/show_bug.cgi?id=193643
3680
3681         Reviewed by Michael Catanzaro.
3682
3683         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
3684         * wpe/jhbuild.modules: Ditto.
3685
3686 2019-01-21  Zalan Bujtas  <zalan@apple.com>
3687
3688         [LFC][Floats] Take float top position into account when computing containing block height.
3689         https://bugs.webkit.org/show_bug.cgi?id=193655
3690
3691         Reviewed by Antti Koivisto.
3692
3693         * LayoutReloaded/misc/LFC-passing-tests.txt:
3694
3695 2019-01-21  David Kilzer  <ddkilzer@apple.com>
3696
3697         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
3698         <https://webkit.org/b/193645>
3699         <rdar://problem/47421574>
3700
3701         Reviewed by Alex Christensen.
3702
3703         - Now checks for local soft-linking of all frameworks that have
3704           their own *SoftLinking.{cpp,h,mm} files.
3705         - Changes softlink/uikit warning to softlink/framework.
3706
3707         * Scripts/webkitpy/style/checkers/cpp.py:
3708         (check_language):
3709         (CppChecker):
3710         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3711         (CppStyleTest):
3712
3713 2019-01-20  Saam Barati  <sbarati@apple.com>
3714
3715         Rollout r240210: It broke tests on iOS
3716         https://bugs.webkit.org/show_bug.cgi?id=193640
3717
3718         Unreviewed.
3719
3720         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
3721         * Scripts/run-jsc-stress-tests:
3722
3723 2019-01-20  chris fleizach  <cfleizach@apple.com>
3724
3725         AX: Support returning relative frames for accessibility
3726         https://bugs.webkit.org/show_bug.cgi?id=193414
3727         <rdar://problem/47268501>
3728
3729         Reviewed by Zalan Bujtas.
3730
3731         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3732         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3733         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3734         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3735         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3736         (WTR::attributesOfElement):
3737         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3738
3739 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
3740
3741         Unreviewed, add my new email address
3742
3743         * Scripts/webkitpy/common/config/contributors.json:
3744
3745 2019-01-19  Zalan Bujtas  <zalan@apple.com>
3746
3747         [LFC][BFC] <body>'s overflow property value is propagated to viewport
3748         https://bugs.webkit.org/show_bug.cgi?id=193617
3749
3750         Reviewed by Antti Koivisto.
3751
3752         * LayoutReloaded/misc/LFC-passing-tests.txt:
3753
3754 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
3755
3756         Unreviewed, rolling out r240209.
3757
3758         Broke GTK/WPE injected bundle
3759
3760         Reverted changeset:
3761
3762         "AX: Support returning relative frames for accessibility"
3763         https://bugs.webkit.org/show_bug.cgi?id=193414
3764         https://trac.webkit.org/changeset/240209
3765
3766 2019-01-12  Dan Bernstein  <mitz@apple.com>
3767
3768         [Cocoa] Avoid importing directly from subumbrella frameworks
3769         https://bugs.webkit.org/show_bug.cgi?id=186016
3770         <rdar://problem/40591038>
3771
3772         Reviewed by Sam Weinig.
3773
3774         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
3775           LaunchServices header.
3776         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3777           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3778         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
3779           when using SDKs earlier than 10.13.
3780         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
3781           and OTHER_CPLUSPLUSFLAGS.
3782         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3783           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3784         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
3785           LaunchServices header.
3786
3787 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
3788
3789         Cache bytecode to disk
3790         https://bugs.webkit.org/show_bug.cgi?id=192782
3791         <rdar://problem/46084932>
3792
3793         Reviewed by Keith Miller.
3794
3795         Add test helper to execute bytecode-cache tests: it executes each test
3796         twice, the first with JSC_diskCachePath set to a temporary directory
3797         and second with JSC_forceDiskCache=true (in addition to the cache path)
3798         to guarantee that only the disk cache is being used and no new
3799         UnlinkedCodeBlocks are being created.
3800
3801         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
3802         * Scripts/run-jsc-stress-tests:
3803
3804 2019-01-20  chris fleizach  <cfleizach@apple.com>
3805
3806         AX: Support returning relative frames for accessibility
3807         https://bugs.webkit.org/show_bug.cgi?id=193414
3808         <rdar://problem/47268501>
3809
3810         Reviewed by Zalan Bujtas.
3811
3812         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3813         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3814         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3815         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3816         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3817         (WTR::attributesOfElement):
3818         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3819
3820 2019-01-20  Antoine Quint  <graouts@apple.com>
3821
3822         Add a POINTER_EVENTS feature flag
3823         https://bugs.webkit.org/show_bug.cgi?id=193577
3824         <rdar://problem/47408511>
3825
3826         Unreviewed. Also enable Pointer Events for iosmac.
3827
3828         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3829
3830 2019-01-19  Zalan Bujtas  <zalan@apple.com>
3831
3832         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
3833         https://bugs.webkit.org/show_bug.cgi?id=193613
3834
3835         Reviewed by Antti Koivisto.
3836
3837         * LayoutReloaded/misc/LFC-passing-tests.txt:
3838
3839 2019-01-19  Antoine Quint  <graouts@apple.com>
3840
3841         Add a POINTER_EVENTS feature flag
3842         https://bugs.webkit.org/show_bug.cgi?id=193577
3843
3844         Reviewed by Dean Jackson.
3845
3846         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3847
3848 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
3849
3850         Disable the run-jsc-stress-test remote host key check [second round].
3851         https://bugs.webkit.org/show_bug.cgi?id=192988
3852
3853         Reviewed by Dewei Zhu.
3854
3855         * Scripts/run-jsc-stress-tests:
3856
3857 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3858
3859         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
3860         https://bugs.webkit.org/show_bug.cgi?id=193597
3861
3862         Reviewed by Lucas Forschler.
3863
3864         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3865
3866 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3867
3868         [build.webkit.org] api tests failures are incorrectly named as unit test failures
3869         https://bugs.webkit.org/show_bug.cgi?id=193595
3870
3871         Reviewed by Lucas Forschler.
3872
3873         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
3874         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
3875         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
3876
3877 2019-01-18  Chris Dumez  <cdumez@apple.com>
3878
3879         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
3880         https://bugs.webkit.org/show_bug.cgi?id=193588
3881         <rdar://problem/47131566>
3882
3883         Reviewed by Alex Christensen.
3884
3885         Add layout test coverage.
3886
3887         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3888
3889 2019-01-18  Jer Noble  <jer.noble@apple.com>
3890
3891         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
3892         https://bugs.webkit.org/show_bug.cgi?id=189553
3893
3894         Reviewed by Tim Horton.
3895
3896         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
3897
3898         * ContentExtensionTester/Configurations/Base.xcconfig:
3899         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
3900         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3901         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
3902         * ImageDiff/cg/Configurations/Base.xcconfig:
3903         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
3904         * MiniBrowser/Configurations/Base.xcconfig:
3905         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3906         * MobileMiniBrowser/Configurations/Base.xcconfig:
3907         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3908         * Scripts/webkitpy/style/checker.py:
3909         (_all_categories):
3910         (FileType):
3911         (CheckerDispatcher._file_type):
3912         (CheckerDispatcher._create_checker):
3913         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
3914         (SDKVariantChecker):
3915         (SDKVariantChecker.__init__):
3916         (SDKVariantChecker.check):
3917         * TestWebKitAPI/Configurations/Base.xcconfig:
3918         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
3919         * WebEditingTester/Configurations/Base.xcconfig:
3920         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
3921         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
3922         * WebKitTestRunner/Configurations/Base.xcconfig:
3923         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
3924         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
3925         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
3926
3927 2019-01-18  David Kilzer  <ddkilzer@apple.com>
3928
3929         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
3930         <https://webkit.org/b/193568>
3931         <rdar://problem/47381130>
3932
3933         Reviewed by Alex Christensen.
3934
3935         Make sure no one re-introduces UIKit soft-linking by adding a
3936         style rule.
3937
3938         * Scripts/webkitpy/style/checkers/cpp.py:
3939         (check_language): Add softlink/uikit check.
3940         (CppChecker): Enable softlink/uikit check.
3941         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3942         (CppStyleTest): Add test for softlink/uikit.
3943
3944 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
3945
3946         [GTK] install-dependencies tool looks for libunistring-dev for dnf
3947         https://bugs.webkit.org/show_bug.cgi?id=193584
3948
3949         Change "-dev" to "-devel".
3950
3951         Reviewed by Michael Catanzaro.
3952
3953         * gtk/install-dependencies:
3954
3955 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3956
3957         webkitpy: Add iPhone and iPad ports
3958         https://bugs.webkit.org/show_bug.cgi?id=193537
3959         <rdar://problem/47353390>
3960
3961         Reviewed by Lucas Forschler.
3962
3963         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
3964         ports. Note that this separation is optional, the --ios-simulator command remains.
3965
3966         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3967         (RunTest.test_device_type_test_division): Drive-by fix.
3968         (RunTest.test_device_type_specific_listing): Ditto.
3969         (RunTest.test_ipad_test_division):
3970         (RunTest):
3971         (RunTest.test_ipad_listing):
3972         * Scripts/webkitpy/port/factory.py:
3973         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
3974         (PortFactory):
3975         * Scripts/webkitpy/port/ios_simulator.py:
3976         (IPhoneSimulatorPort):
3977         (IPadSimulatorPort):
3978
3979 2019-01-18  Chris Dumez  <cdumez@apple.com>
3980
3981         Regression(PSON) Scroll position is not always restored properly when navigating back
3982         https://bugs.webkit.org/show_bug.cgi?id=193578
3983         <rdar://problem/47386331>
3984
3985         Reviewed by Tim Horton.
3986
3987         Add API test coverage.
3988
3989         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3990
3991 2019-01-18  Youenn Fablet  <youenn@apple.com>
3992
3993         Add a new SPI to request for cache storage quota increase
3994         https://bugs.webkit.org/show_bug.cgi?id=193323
3995
3996         Reviewed by Alex Christensen.
3997
3998         Implement WebsiteDataStore quota delegate to handle quota requests.
3999         By default, do not update quota.
4000         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
4001
4002         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4003         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4004         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
4005         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4006         * WebKitTestRunner/TestController.cpp:
4007         (WTR::TestController::allowCacheStorageQuotaIncrease):
4008         * WebKitTestRunner/TestController.h:
4009         * WebKitTestRunner/TestInvocation.cpp:
4010         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
4011         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4012         (-[CacheStorageQuotaManager init]):
4013         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
4014         (WTR::initializeWebViewConfiguration):
4015         (WTR::TestController::cocoaResetStateToConsistentValues):
4016         (WTR::TestController::allowCacheStorageQuotaIncrease):
4017
4018 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
4019
4020         [ews-build] Pass owner to the triggered builds
4021         https://bugs.webkit.org/show_bug.cgi?id=193574
4022
4023         Reviewed by Lucas Forschler.
4024
4025         * BuildSlaveSupport/ews-build/factories.py:
4026         (BuildFactory.propertiesToPassToTriggers):
4027
4028 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
4029
4030         [ews-app] Send patch author as a build property
4031         https://bugs.webkit.org/show_bug.cgi?id=193560
4032
4033         Reviewed by Lucas Forschler.
4034
4035         * BuildSlaveSupport/ews-app/ews/fetcher.py:
4036         (BugzillaPatchFetcher.fetch):
4037
4038 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
4039
4040         webkitpy: Implement device type specific expected results (Follow-up fix)
4041         https://bugs.webkit.org/show_bug.cgi?id=192162
4042         <rdar://problem/46345449>
4043
4044         Unreviewed infrastructure fix.
4045
4046         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4047         (Manager.run): Don't boot a device if no tests are available to run on it.
4048
4049 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
4050
4051         webkitpy: Implement device type specific expected results (Follow-up fix)
4052         https://bugs.webkit.org/show_bug.cgi?id=192162
4053         <rdar://problem/46345449>
4054
4055         Unreviewed infrastructure fix.
4056
4057         * Scripts/webkitpy/api_tests/manager.py:
4058         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
4059
4060 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
4061
4062         webkitpy: Implement device type specific expected results (Part 2)
4063         https://bugs.webkit.org/show_bug.cgi?id=192162
4064         <rdar://problem/46345449>
4065
4066         Rubber-stamped by Aakash Jain.
4067
4068         This change uses device_type to select a different set of TestExpectation files based on the type of device running
4069         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
4070         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
4071
4072         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
4073         (LayoutTestFinder.find_tests): Pass device_type through.
4074         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
4075         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
4076         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4077         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
4078         (Manager._collect_tests): Pass device type to test finder.
4079         (Manager._needs_web_platform_test):
4080         (Manager._prepare_lists): Index _expectations by device type.
4081         (Manager._test_input_for_file):
4082         (Manager._test_is_slow): Ditto.
4083         (Manager._test_should_dump_jsconsolelog_in_stderr):
4084         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
4085         (Manager._get_test_inputs):
4086         (Manager._update_worker_count):
4087         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
4088         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
4089         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
4090         the one which runs the test.
4091         (Manager._run_test_subset):
4092         (Manager._run_tests): Index _expectations by current_device_type.
4093         (Manager._print_expectation_line_for_test): Ditto.
4094         (Manager._print_expectations_for_subset): Ditto.
4095         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
4096         Unlike run, this function will behave the same regardless of what devices are available.
4097         (Manager._custom_device_for_test): Deleted.
4098         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
4099         (ManagerTest.test_uses_custom_device): Deleted.
4100         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
4101         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
4102         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
4103         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
4104         all of the expectations.
4105         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
4106         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
4107         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
4108         (TestExpectations.__init__): Allow device_type to be passed through.
4109         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
4110         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
4111         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
4112         (summarize_results):
4113         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
4114         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
4115         a test ran with, one must check all expectations to find the first non-skip expectation.
4116         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
4117         (RunTest.test_device_type_test_division):
4118         (RunTest):
4119         (RunTest.test_device_type_specific_listing):
4120         * Scripts/webkitpy/port/base.py:
4121         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
4122         (Port.supported_device_types): The result of this function will change based on what devices are available.
4123         * Scripts/webkitpy/port/device_port.py:
4124         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
4125         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
4126         can be used.
4127         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
4128         any, or the DEFAULT_DEVICE_TYPES of the port.
4129         * Scripts/webkitpy/port/ios.py:
4130         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
4131         * Scripts/webkitpy/port/ios_simulator.py:
4132         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
4133         * Scripts/webkitpy/port/watch.py:
4134         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
4135         * Scripts/webkitpy/port/watch_simulator.py:
4136         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
4137         * Scripts/webkitpy/xcode/device_type.py:
4138         (DeviceType):
4139         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
4140
4141 2019-01-18  Philippe Normand  <pnormand@igalia.com>
4142
4143         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
4144         https://bugs.webkit.org/show_bug.cgi?id=193575
4145
4146         Reviewed by Michael Catanzaro.
4147
4148         Allow the script to run without explicit port argument because
4149         it's specific to the WPE port anyway.
4150
4151         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
4152         and simplify the rest of the code accordingly.
4153
4154 2019-01-18  Charlie Turner  <cturner@igalia.com>
4155
4156         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
4157         https://bugs.webkit.org/show_bug.cgi?id=192229
4158
4159         Reviewed by Xabier Rodriguez-Calvar.
4160
4161         * MiniBrowser/wpe/main.cpp:
4162         (main): Enable encrypted-media by default.
4163
4164 2019-01-18  Philippe Normand  <pnormand@igalia.com>
4165
4166         [Flatpak] Missing KeyboardInterrupt exception handler
4167         https://bugs.webkit.org/show_bug.cgi?id=193570
4168
4169         Reviewed by Michael Catanzaro.
4170
4171         * flatpak/flatpakutils.py:
4172         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
4173
4174 2019-01-18  Zalan Bujtas  <zalan@apple.com>
4175
4176         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
4177         https://bugs.webkit.org/show_bug.cgi?id=193564
4178
4179         Reviewed by Antti Koivisto.
4180
4181         * LayoutReloaded/misc/LFC-passing-tests.txt:
4182
4183 2019-01-18  Zalan Bujtas  <zalan@apple.com>
4184
4185         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
4186         https://bugs.webkit.org/show_bug.cgi?id=193562
4187
4188         Reviewed by Antti Koivisto.
4189
4190         * LayoutReloaded/misc/LFC-passing-tests.txt:
4191
4192 2019-01-18  Zalan Bujtas  <zalan@apple.com>
4193
4194         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
4195         https://bugs.webkit.org/show_bug.cgi?id=193555
4196
4197         Reviewed by Antti Koivisto.
4198
4199         * LayoutReloaded/misc/LFC-passing-tests.txt:
4200
4201 2019-01-18  Philippe Normand  <pnormand@igalia.com>
4202
4203         [WPE] Add Qt extension
4204         https://bugs.webkit.org/show_bug.cgi?id=191464
4205
4206         Reviewed by Carlos Garcia Campos.
4207
4208         MiniBrowser and API tests for the WPE Qt API. To run the
4209         MiniBrowser a new script is introduced. Example invocation:
4210
4211         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
4212
4213         Also note-worthy is the introduction of the python2-subprocess32
4214         dependency to run the GLib API tests.
4215
4216         * MiniBrowser/wpe/CMakeLists.txt:
4217         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
4218         * MiniBrowser/wpe/qt/main.cpp: Added.
4219         (main):
4220         * MiniBrowser/wpe/qt/main.qml: Added.
4221         * MiniBrowser/wpe/qt/qml.qrc: Added.
4222         * Scripts/run-gtk-tests:
4223         (GtkTestRunner.is_google_test):
4224         (GtkTestRunner):
4225         (GtkTestRunner.is_qt_test):
4226         * Scripts/run-qt-wpe-minibrowser: Added.
4227         * Scripts/run-wpe-tests:
4228         (WPETestRunner):
4229         (WPETestRunner.is_google_test):
4230         (WPETestRunner.is_qt_test):
4231         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
4232         (TestLoad::main):
4233         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
4234         (TestLoadHtml::main):
4235         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
4236         (TestLoadRequest::main):
4237         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
4238         (TestRunJavaScript::main):
4239         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
4240         (waitForSignal):
4241         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
4242         (LoadSpy::LoadSpy):
4243         (LoadSpy::~LoadSpy):
4244         (LoadSpy::onLoadingChanged):
4245         (LoadStartedCatcher::LoadStartedCatcher):
4246         (LoadStartedCatcher::~LoadStartedCatcher):
4247         (LoadStartedCatcher::onLoadingChanged):
4248         (waitForLoadSucceeded):
4249         (waitForLoadFailed):
4250         * TestWebKitAPI/glib/CMakeLists.txt:
4251         * flatpak/flatpakutils.py:
4252         (WebkitFlatpak.load_from_args):
4253         (WebkitFlatpak.__init__):
4254         (WebkitFlatpak.clean_args):
4255         (WebkitFlatpak.run_in_sandbox):
4256         * flatpak/org.webkit.CommonModules.yaml:
4257         * flatpak/org.webkit.WPE.yaml:
4258         * flatpak/org.webkit.WPEModules.yaml:
4259         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
4260         * flatpak/org.webkit.WebKit.yaml:
4261         * glib/api_test_runner.py:
4262         (TestRunner._run_test_qt):
4263         (TestRunner.is_qt_test):
4264         (TestRunner._run_test):
4265
4266 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
4267
4268         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
4269         https://bugs.webkit.org/show_bug.cgi?id=193494
4270         <rdar://problem/46859627>
4271
4272         Reviewed by Simon Fraser and Tim Horton.
4273
4274         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
4275         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
4276
4277         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4278         (WTR::UIScriptController::contentOffsetX const):
4279         (WTR::UIScriptController::contentOffsetY const):
4280         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4281         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4282         (WTR::UIScriptController::contentOffsetX const):
4283         (WTR::UIScriptController::contentOffsetY const):
4284         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4285
4286         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
4287
4288         * WebKitTestRunner/TestController.cpp:
4289         (WTR::updateTestOptionsFromTestHeader):
4290         * WebKitTestRunner/TestOptions.h:
4291         (WTR::TestOptions::hasSameInitializationOptions const):
4292         * WebKitTestRunner/ios/TestControllerIOS.mm:
4293         (WTR::TestController::platformResetStateToConsistentValues):
4294         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4295         (WTR::UIScriptController::contentOffsetX const):
4296         (WTR::UIScriptController::contentOffsetY const):
4297
4298 2019-01-17  Truitt Savell  <tsavell@apple.com>
4299
4300         Unreviewed, rolling out r240124.
4301
4302         This commit broke an internal build.
4303
4304         Reverted changeset:
4305
4306         "SDK_VARIANT build destinations should be separate from non-
4307         SDK_VARIANT builds"
4308         https://bugs.webkit.org/show_bug.cgi?id=189553
4309         https://trac.webkit.org/changeset/240124
4310
4311 2019-01-17  Alex Christensen  <achristensen@webkit.org>
4312
4313         Fix string concatenation API test after r239920
4314         https://bugs.webkit.org/show_bug.cgi?id=193551
4315         <rdar://problem/47359304>
4316
4317         Reviewed by Youenn Fablet.
4318
4319         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
4320         (TestWebKitAPI::TEST):
4321         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
4322         in WebKit's build configuration like it apparently is on Linux.
4323
4324 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
4325
4326         [ews-build] validate-patch should handle the case when bug_id is None
4327         https://bugs.webkit.org/show_bug.cgi?id=193547
4328
4329         Reviewed by Lucas Forschler.
4330
4331         * BuildSlaveSupport/ews-build/steps.py:
4332         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
4333         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
4334
4335 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
4336
4337         [ews-build] Add patch author information in build
4338         https://bugs.webkit.org/show_bug.cgi?id=193465
4339
4340         Reviewed by Lucas Forschler.
4341
4342         * BuildSlaveSupport/ews-build/steps.py:
4343         (ValidatePatch._is_patch_obsolete):
4344
4345 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
4346
4347         [ews-build] Pass bug_id to the triggered builds
4348         https://bugs.webkit.org/show_bug.cgi?id=193548
4349
4350         Reviewed by Lucas Forschler.
4351
4352         * BuildSlaveSupport/ews-build/factories.py:
4353         (BuildFactory.propertiesToPassToTriggers):
4354
4355 2019-01-17  Jer Noble  <jer.noble@apple.com>
4356
4357         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
4358         https://bugs.webkit.org/show_bug.cgi?id=189553
4359
4360         Reviewed by Tim Horton.
4361
4362         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
4363
4364         * ContentExtensionTester/Configurations/Base.xcconfig: