run-perf-tests should record indivisual value instead of statistics
[WebKit-https.git] / Tools / ChangeLog
1 2012-09-19  Ryosuke Niwa  <rniwa@webkit.org>
2
3         run-perf-tests should record indivisual value instead of statistics
4         https://bugs.webkit.org/show_bug.cgi?id=97155
5
6         Reviewed by Hajime Morita.
7
8         Parse the list of indivisual value reported by tests and include them as "values".
9         We strip "values" from the output JSON when uploading it to the perf-o-matic
10         since it doesn't know how to parse "values" or ignore it.
11
12         * Scripts/webkitpy/performance_tests/perftest.py:
13         (PerfTest):
14         (PerfTest.parse_output): Parse and report "values".
15         (PageLoadingPerfTest.run): Report indivisual page loading time in "values".
16         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
17         (MainTest.test_parse_output):
18         (MainTest.test_parse_output_with_failing_line):
19         (TestPageLoadingPerfTest.test_run):
20         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
21         (PerfTestsRunner._generate_and_show_results): Strip "values" from each result
22         until we update perf-o-matic.
23         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
24         (test_run_memory_test):
25         (test_run_with_json_output):
26         (test_run_with_description):
27         (test_run_with_slave_config_json):
28         (test_run_with_multiple_repositories):
29
30 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
31
32         Fix regex groups for bug matching in flakiness dashboard.
33         https://bugs.webkit.org/show_bug.cgi?id=97152
34
35         Unreviewed, build fix.
36
37         * TestResultServer/static-dashboards/flakiness_dashboard.js:
38         (htmlForBugs):
39
40 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
41
42         nrwt: print unexpected results using new TestExpectations syntax
43         https://bugs.webkit.org/show_bug.cgi?id=97159
44
45         Unreviewed, build fix.
46
47         Change new-run-webkit-tests to print out failures using the new
48         syntax when there are unexpected results, e.g.:
49
50         52 tests ran as expected, 19 didn't:
51
52
53         Regressions: Unexpected failures : (2)
54           failures/flaky/text.html [ Failure ]
55           failures/unexpected/text-image-checksum.html [ Failure ]
56
57         and so forth
58
59         * Scripts/webkitpy/layout_tests/views/printing.py:
60         (Printer._print_unexpected_results):
61
62 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
63
64         update flakiness dashboard after cutover to new test expectations syntax
65         https://bugs.webkit.org/show_bug.cgi?id=97152
66
67         Unreviewed, build fix.
68
69         Handle (??) the new Bug notations as well. Hopefully we don't
70         still need the old ones.
71
72         * TestResultServer/static-dashboards/flakiness_dashboard.js:
73         (filterBugs):
74         (htmlForBugs):
75         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
76
77 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
78
79         update flakiness dashboard after cutover to new test expectations syntax
80         https://bugs.webkit.org/show_bug.cgi?id=97152
81
82         Reviewed by Ryosuke Niwa.
83
84         This change clones the TestExpectation parsing state machine
85         from python into javascript.
86
87         * TestResultServer/static-dashboards/flakiness_dashboard.js:
88         (parsedExpectations.lines.forEach):
89         (parsedExpectations):
90         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
91
92 2012-09-19  Dana Jansens  <danakj@chromium.org>
93
94         Add backer@chromium.org as contributor
95         https://bugs.webkit.org/show_bug.cgi?id=97150
96
97         * Scripts/webkitpy/common/config/committers.py:
98
99 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
100
101         fix MISSING after TestExpectations conversion
102         https://bugs.webkit.org/show_bug.cgi?id=97148
103
104         Unreviewed, expectations change / build fix.
105
106         * Scripts/convert-test-expectations:
107         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
108         (TestExpectationParser):
109
110 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
111
112         nrwt: convert chromium TestExpectations to the new syntax
113         https://bugs.webkit.org/show_bug.cgi?id=97139
114
115         Reviewed by Ryosuke Niwa.
116     
117         Add in a file temporarily that does the conversion of
118         test expectations formats
119
120         * Tools/Scripts/convert-test-expectations: Added.
121
122 2012-09-19  Ryosuke Niwa  <rniwa@webkit.org>
123
124         REGRESSION: run-perf-tests no longer reports the total test time
125         https://bugs.webkit.org/show_bug.cgi?id=97138
126
127         Reviewed by Tony Chang.
128
129         Report the finished time as a info-level log as opposed to a debug level log.
130
131         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
132         (PerfTestsRunner._run_single_test):
133         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
134         (MainTest.normalizeFinishedTime): Added. It replaces all finished times by 0.1 seconds.
135         (test_run_test_pause_before_testing):
136         (test_run_test_set_for_parser_tests):
137         (test_run_memory_test):
138         (_test_run_with_json_output):
139
140 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
141
142         Support new TestExpectations format alongside old one
143         https://bugs.webkit.org/show_bug.cgi?id=96588
144
145         Reviewed by Ojan Vafai.
146
147         This patch adds support for actually reading in lines formatted
148         in the new style, and when we re-serialize/write out the file,
149         all lines will be written in the new style. Note that reading in
150         the old style is still supported, and no updates are being made
151         to the actual TestExpectations files as part of this change.
152
153         This change updates most but not all of the unit tests to use
154         the new syntax. I will update the rest when (or before where
155         possible) I drop support for the old format.
156
157         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
158         (TestExpectationParser):
159         (TestExpectationParser._tokenize_line):
160         (TestExpectationParser._tokenize_line_using_new_format):
161         (TestExpectationLine.to_string):
162         (TestExpectationLine._format_line):
163         (TestExpectations):
164         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
165         (test_parse_warning):
166         (SkippedTests.test_skipped_entry_dont_exist):
167         (NewExpectationSyntaxTests.test_warnings):
168         (RemoveConfigurationsTest.test_remove):
169         (test_remove_line):
170         (RebaseliningTest.test_remove):
171         (RebaseliningTest.test_no_get_rebaselining_failures):
172         (TestExpectationParserTests.test_tokenize_blank):
173         (TestExpectationParserTests.test_tokenize_extra_colon):
174         (TestExpectationParserTests.test_tokenize_missing_equal):
175         (TestExpectationParserTests.test_tokenize_extra_equal):
176         (TestExpectationSerializationTests.test_unparsed_to_string):
177         (TestExpectationSerializationTests.test_unparsed_list_to_string):
178         (TestExpectationSerializationTests.test_parsed_to_string):
179         (TestExpectationSerializationTests.test_format_line):
180         (TestExpectationSerializationTests.test_string_roundtrip):
181         (TestExpectationSerializationTests.test_list_roundtrip):
182         (TestExpectationSerializationTests.test_reconstitute_only_these):
183         (TestExpectationSerializationTests.test_string_whitespace_stripping):
184         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
185         (LintTest.test_lint_test_files__errors):
186         * Scripts/webkitpy/tool/commands/queries_unittest.py:
187         (PrintExpectationsTest.test_basic):
188         (PrintExpectationsTest.test_multiple):
189         (PrintExpectationsTest.test_full):
190         (PrintExpectationsTest.test_exclude):
191         * Scripts/webkitpy/tool/commands/rebaseline.py:
192         (RebaselineExpectations.execute):
193         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
194         (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
195         (test_rebaseline_updates_expectations_file):
196         (test_rebaseline_does_not_include_overrides):
197         (test_rebaseline_expectations_noop):
198         (test_overrides_are_included_correctly):
199
200 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
201
202         implement first part of support for the new TestExpectations syntax
203         https://bugs.webkit.org/show_bug.cgi?id=96569
204
205         Reviewed by Ryosuke Niwa.
206
207         This patch implements support for parsing a line of the new
208         format for the TestExpectations file and converting it back into
209         the old format for compatibility. This routine is not yet used
210         by anything.
211
212         The new format is documented at:
213           http://trac.webkit.org/wiki/TestExpectations
214
215         but, in short:
216
217           [bugs] [ "[" modifiers "]" ] test_name [ "[" expectations "]" ]
218
219         - Comments are indicated with "#" instead of "//"
220         - If no expectations are specified we default to Skip for
221           compatibility with the Skipped files (these two changes make
222           Skipped files a subset of TestExpectations files)
223
224         - All of the tokens are now CamelCase instead of ALLCAPS.
225         - FAIL -> Failure
226         - IMAGE -> ImageOnlyFailure
227         - WONTFIX -> WontFix
228         - modifiers refer to just the platforms and configurations
229           (release/debug) that the line applies to.
230         - WontFix, Rebaseline, Slow, and Skip move to the right-hand side as
231           expectations
232         - expectations will typically be written out in lexicographic order
233         - We use webkit.org/b/12345, crbug.com/12345, and Bug(dpranke)
234           instead of BUGWK12345, BUGCR12345, and BUGDPRANKE.
235
236         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
237         (TestExpectationParser):
238         (TestExpectationParser._tokenize_line_using_new_format):
239         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
240         (NewExpectationSyntaxTests):
241         (NewExpectationSyntaxTests.assert_exp):
242         (NewExpectationSyntaxTests.test_bare_name):
243         (NewExpectationSyntaxTests.test_bare_name_and_bugs):
244         (NewExpectationSyntaxTests.test_comments):
245         (NewExpectationSyntaxTests.test_config_modifiers):
246         (NewExpectationSyntaxTests.test_unknown_config):
247         (NewExpectationSyntaxTests.test_unknown_expectation):
248         (NewExpectationSyntaxTests.test_skip):
249         (NewExpectationSyntaxTests.test_slow):
250         (NewExpectationSyntaxTests.test_wontfix):
251         (NewExpectationSyntaxTests.test_blank_line):
252         (NewExpectationSyntaxTests.test_warnings):
253
254 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
255
256         nrwt: replace TEXT, AUDIO, and IMAGE+TEXT with FAIL
257         https://bugs.webkit.org/show_bug.cgi?id=96845
258
259         Reviewed by Ojan Vafai.
260
261         In preparation for the new TestExpectations syntax, we replace
262         all TEXT, IMAGE+TEXT, and AUDIO failures with FAIL. This will
263         make switching to the new syntax lossless (i.e., we lose
264         information now, not then).
265
266         Note that we can still parse in results.json files that have the
267         old data for backwards compatibility.
268         
269
270         * Scripts/webkitpy/common/net/resultsjsonparser.py:
271         (JSONTestResult._failure_types_from_actual_result):
272         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
273         (ResultsJSONParserTest):
274         (test_basic):
275         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
276         (ResultSummaryTest.test_summarized_results_wontfix):
277         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
278         (JSONLayoutResultsGenerator):
279         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
280         (TestExpectations):
281         (TestExpectations.remove_pixel_failures):
282         (TestExpectations.has_pixel_failures):
283         (TestExpectations.suffixes_for_expectations):
284         (TestExpectations.get_rebaselining_failures):
285         (TestExpectations.remove_configuration_from_test):
286         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
287         (assert_bad_expectations):
288         (BasicTests):
289         (BasicTests.test_basic):
290         (MiscTests):
291         (MiscTests.test_multiple_results):
292         (MiscTests.test_result_was_expected):
293         (MiscTests.test_remove_pixel_failures):
294         (MiscTests.test_suffixes_for_expectations):
295         (test_get_expectations_string):
296         (test_parse_warning):
297         (test_error_on_different_platform):
298         (test_error_on_different_build_type):
299         (test_overrides):
300         (test_overrides__directory):
301         (test_overrides__duplicate):
302         (test_pixel_tests_flag):
303         (test_more_specific_override_resets_skip):
304         (SkippedTests.test_skipped_file_overrides_expectations):
305         (SkippedTests.test_skipped_dir_overrides_expectations):
306         (SkippedTests.test_skipped_file_overrides_overrides):
307         (SkippedTests.test_skipped_dir_overrides_overrides):
308         (ExpectationSyntaxTests.test_missing_colon):
309         (ExpectationSyntaxTests.test_too_many_equals_signs):
310         (SemanticTests.test_bug_format):
311         (SemanticTests.test_bad_bugid):
312         (SemanticTests.test_missing_bugid):
313         (SemanticTests.test_rebaseline):
314         (test_missing_file):
315         (test_more_modifiers):
316         (test_order_in_file):
317         (test_macro_overrides):
318         (RemoveConfigurationsTest.test_remove):
319         (test_remove_line):
320         (RebaseliningTest.test_remove):
321         (TestExpectationSerializationTests.test_serialize_parsed_expectations):
322         * Scripts/webkitpy/layout_tests/models/test_failures.py:
323         (determine_result_type):
324         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
325         (test_test_expectations):
326         * Scripts/webkitpy/layout_tests/port/test.py:
327         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
328         (MainTest.test_missing_and_unexpected_results):
329         (MainTest.test_retrying_and_flaky_tests):
330         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
331         (TestExpectationsTestCase.test_valid_expectations):
332         * Scripts/webkitpy/tool/commands/queries_unittest.py:
333         (PrintExpectationsTest.test_basic):
334         (PrintExpectationsTest.test_multiple):
335         (PrintExpectationsTest.test_full):
336         (PrintExpectationsTest.test_exclude):
337         (PrintExpectationsTest.test_csv):
338         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
339         (test_rebaseline_does_not_include_overrides):
340         (test_overrides_are_included_correctly):
341
342 2012-09-19  Dominic Mazzoni  <dmazzoni@google.com>
343
344         AX: A few control types are returning the wrong answer for isReadOnly
345         https://bugs.webkit.org/show_bug.cgi?id=96735
346
347         Reviewed by Chris Fleizach.
348
349         Exposing isReadOnly in an AccessibilityObject to DumpRenderTree.
350
351         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
352         (AccessibilityUIElement::AccessibilityUIElement):
353         (AccessibilityUIElement::isReadOnlyGetterCallback):
354         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h:
355         (AccessibilityUIElement):
356
357 2012-09-19  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
358
359         [WTR] Memory leaks in TestRunner::deliverWebIntent()
360         https://bugs.webkit.org/show_bug.cgi?id=97111
361
362         Reviewed by Kenneth Rohde Christiansen.
363
364         Fix memory leaks in deliverWebIntent() by adopting strings
365         created with WKStringCreateWithUTF8CString().
366
367         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
368         (WTR::TestRunner::deliverWebIntent):
369
370 2012-09-19  Simon Hausmann  <simon.hausmann@digia.com>
371
372         [Qt] Fix incremental builds with all-in-one-files and gccdepends
373
374         Reviewed by Tor Arne Vestbø.
375
376         Pass -MP to gcc when we use the gcc depends feature, to ensure that implicit rules
377         are not only created for header files but also for .cpp files. AllInOne.cpp files
378         include other .cpp files, and when those are removed we need those dummy rules to
379         avoid a "No rule to make Foo.cpp required by AllInOne.o" error.
380
381         * qmake/config.tests/gccdepends/empty.cpp:
382         (main):
383         * qmake/config.tests/gccdepends/gccdepends.pro:
384         * qmake/mkspecs/features/default_pre.prf:
385
386 2012-09-19  Rick Byers  <rbyers@chromium.org>
387
388         Do touch adjustment on GestureTapDown
389         https://bugs.webkit.org/show_bug.cgi?id=96677
390
391         Reviewed by Antonio Gomes.
392
393         Allow radius to be set for GestureTapDown events.
394         * DumpRenderTree/chromium/TestRunner/EventSender.cpp:
395         (EventSender::gestureEvent):
396
397 2012-09-19  Christophe Dumez  <christophe.dumez@intel.com>
398
399         [EFL] EFL's DRT does not support overriding 'WebKitCSSRegionsEnabled' preference
400         https://bugs.webkit.org/show_bug.cgi?id=97100
401
402         Reviewed by Gyuyoung Kim.
403
404         EFL's DRT now supports overriding the 'WebKitCSSRegionsEnabled'
405         preference, in order to match WebKitTestRunner functionality.
406
407         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
408         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
409         * DumpRenderTree/efl/TestRunnerEfl.cpp:
410         (TestRunner::overridePreference):
411
412 2012-09-18  Kangil Han  <kangil.han@samsung.com>
413
414         [WK2][WTR] CodeGeneratorTestRunner could keep original copyright.
415         https://bugs.webkit.org/show_bug.cgi?id=96181
416
417         Reviewed by Daniel Bates.
418
419         This patch enabled derived files, in DerivedSources/InjectedBundle, to keep original copyright.
420
421         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
422         (new):
423         (_parseLicenseBlock):
424         (_parseLicenseBlockFromFile):
425         (_defaultLicenseBlock):
426         (_licenseBlock):
427         (_generateHeaderFile):
428         (_generateImplementationFile):
429
430 2012-09-18  Byungwoo Lee  <bw80.lee@samsung.com>
431
432         Title string should be changed when document.title is set to ''.
433         https://bugs.webkit.org/show_bug.cgi?id=96793
434
435         Reviewed by Kenneth Rohde Christiansen.
436
437         Change dump format of dumpTitleChanges more understandable.
438         Uses single quotation marks for the title string.
439
440         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
441         (BlackBerry::WebKit::DumpRenderTree::didReceiveTitleForFrame):
442         * DumpRenderTree/chromium/WebViewHost.cpp:
443         (WebViewHost::didReceiveTitle):
444         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
445         (DumpRenderTreeChrome::onFrameTitleChanged):
446         * DumpRenderTree/gtk/DumpRenderTree.cpp:
447         (webViewTitleChanged):
448         * DumpRenderTree/mac/FrameLoadDelegate.mm:
449         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
450         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
451         (WebCore::DumpRenderTree::titleChanged):
452         * DumpRenderTree/win/FrameLoadDelegate.cpp:
453         (FrameLoadDelegate::didReceiveTitle):
454         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
455         (LayoutWebViewEventHandler::OnReceivedTitleEvent):
456         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
457         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
458
459 2012-09-18  Szilard Ledan  <szledan@inf.u-szeged.hu>
460
461         EWS shouldn't sleep if there are new patches in its queue
462         https://bugs.webkit.org/show_bug.cgi?id=83038
463
464         Reviewed by Eric Seidel.
465
466         EWS tries to process a security patch. Of course it can't, because the EWS isn't
467         the member of the security group. But the problem is that after it can't process
468         the attachment, it says that queue is empty (but it isn't!) and it sleeps 2 minutes
469         and push the security patch to the end of the queue.
470         Now it stays in the loop until it finds a patch or the queue gets empty.
471
472         * Scripts/webkitpy/tool/commands/queues.py:
473         (AbstractPatchQueue._next_patch):
474         * Scripts/webkitpy/tool/commands/queues_unittest.py:
475         (AbstractPatchQueueTest.test_next_patch):
476
477 2012-09-18  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
478
479         [WK2][WTR] InjectedBundle::booleanForKey() should handle literals effectively
480         https://bugs.webkit.org/show_bug.cgi?id=97014
481
482         Reviewed by Kenneth Rohde Christiansen.
483
484         According to http://trac.webkit.org/wiki/EfficientStrings WTF::StringBuilder::appendLiteral() shall
485         be used for literals rather than WTF::StringBuilder::append().
486
487         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
488         (WTR::InjectedBundle::booleanForKey):
489
490 2012-09-18  Simon Hausmann  <simon.hausmann@digia.com>
491
492         Update my e-mail address.
493
494         * Scripts/webkitpy/common/config/committers.py:
495
496 2012-09-18  Andras Becsi  <andras.becsi@digia.com>
497
498         Update my e-mail address.
499
500         Unreviewed.
501
502         * Scripts/webkitpy/common/config/committers.py:
503
504 2012-09-18  Andras Becsi  <andras.becsi@digia.com>
505
506         [Qt] qt_webkit.pri should not be listed in Tools.pro
507
508         Reviewed and rubber-stamped by Simon Hausmann and Tor Arne Vestbø.
509
510         Since r128751 the module pri file is auto-generated
511         but it was still listed in OTHER_FILES.
512
513         * Tools.pro: Remove unneeded line.
514
515 2012-09-18  Simon Hausmann  <simon.hausmann@digia.com>
516
517         [Qt] Fix build with some versions of the gold linker
518
519         Reviewed by Tor Arne Vestbø.
520
521         Don't unconditionally pass --no-keep-memory to the linker, some versions might not support it.
522         Instead run a compile/link test first to see if it works.
523
524         * qmake/config.tests/gnuld/gnuld.pro: Added.
525         * qmake/config.tests/gnuld/main.cpp: Added.
526         (main):
527         * qmake/mkspecs/features/unix/default_post.prf:
528
529 2012-09-18  Simon Hausmann  <simon.hausmann@digia.com>
530
531         [Qt] Remove forced use of gold.
532
533         Reviewed by Tor Arne Vestbø.
534
535         The choice of what linker to use with WebKit should be taken by Qt's build system and ideally the same for all
536         modules of Qt. Then in turn it is usually up to the administrator of the machine. Recent Debian based systems
537         often offer the automatic use of gold through a symlink and a dpkg-diversion when installing the gold package.
538
539         * qmake/mkspecs/features/unix/default_post.prf:
540
541 2012-09-18  Simon Hausmann  <simon.hausmann@digia.com>
542
543         [Qt] Prospective Qt/Windows cross-compiling fix
544
545         Reviewed by Tor Arne Vestbø.
546
547         The win32 scope is not set when cross-compiling from Linux to Windows.
548
549         * qmake/mkspecs/features/functions.prf:
550
551 2012-09-18  Seokju Kwon  <seokju.kwon@samsung.com>
552
553         [EFL] Remove background view on EWebLauncher and MiniBrowser
554         https://bugs.webkit.org/show_bug.cgi?id=96905
555
556         Reviewed by Gyuyoung Kim.
557
558         The size of webview was changed after adding url bar.
559         And the background view is not necessary anymore, since it was used for debugging back in the day.
560
561         * EWebLauncher/main.c:
562         (_ELauncher):
563         (on_ecore_evas_resize):
564         (browserCreate):
565         * MiniBrowser/efl/main.c:
566         (_MiniBrowser):
567         (on_ecore_evas_resize):
568         (browserCreate):
569
570 2012-09-18  Sergio Villar Senin  <svillar@igalia.com>
571
572         [GTK] run-webkit-tests unable to find TestExpectations for WK2
573         https://bugs.webkit.org/show_bug.cgi?id=96998
574
575         Reviewed by Philippe Normand.
576
577         We should look for TestExpectations files in all the locations where
578         we currently look for Skipped files. This will allow
579         run-webkit-tests to look for TestExpectations files in
580         platform/gtk-wk2 and platform/wk2 if the "-2" flag is used.
581
582         * Scripts/webkitpy/layout_tests/port/gtk.py:
583         (GtkPort.expectations_files):
584
585 2012-09-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
586
587         [Qt] Fix build without the QtQuick module
588
589         Reviewed by Simon Hausmann.
590
591         * qmake/mkspecs/features/features.prf:
592
593 2012-09-18  Stephanie Lewis  <slewis@apple.com>
594
595         Build fix after http://trac.webkit.org/projects/webkit/changeset/128852.
596
597         Unreviewed.
598
599         * DumpRenderTree/mac/DumpRenderTree.mm:
600         (poseAsClass):
601
602 2012-09-18  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
603
604         Unreviewed update of email addresses for Berlin QtWebKit office.
605
606         * Scripts/webkitpy/common/config/committers.py:
607
608 2012-09-17  Zan Dobersek  <zandobersek@gmail.com>
609
610         [GTK] fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html failing after r128645
611         https://bugs.webkit.org/show_bug.cgi?id=96899
612
613         Reviewed by Martin Robinson.
614
615         When overriding the 'WebKitDisplayImageKey' preference, use the
616         'auto-load-images' property of WebKitWebSettings as the property which
617         should be updated with the corresponding preference value.
618
619         * DumpRenderTree/gtk/DumpRenderTree.cpp:
620         (resetDefaultsToConsistentValues):
621         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
622         (TestRunner::overridePreference):
623
624 2012-09-17  Pratik Solanki  <psolanki@apple.com>
625
626         DumpRenderTree and WebKitTestRunner should compile with -Wundef on Mac
627         https://bugs.webkit.org/show_bug.cgi?id=96973
628
629         Reviewed by Dan Bernstein.
630
631         * DumpRenderTree/mac/Configurations/Base.xcconfig:
632         * WebKitTestRunner/Configurations/Base.xcconfig:
633         * WebKitTestRunner/PlatformWebView.h: Use #ifdef __OBJC__ and not #if.
634
635 2012-09-17  Dirk Pranke  <dpranke@chromium.org>
636
637         nrwt: remove "unexpected EOF" warnings
638         https://bugs.webkit.org/show_bug.cgi?id=96970
639
640         Reviewed by Ojan Vafai.
641
642         After debugging this a bit, it looks like there aren't any cases
643         that I can reproduce where a read() of zero indicates something
644         actually wrong; either it is a prelude to a crash, or a false
645         negative. So, I'm removing these warnings and adding a comment.
646
647         * Scripts/webkitpy/layout_tests/port/server_process.py:
648         (ServerProcess._wait_for_data_and_update_buffers_using_select):
649
650 2012-09-17  Dirk Pranke  <dpranke@chromium.org>
651
652         [chromium] ASAN bot is crashing at the end of the run
653         https://bugs.webkit.org/show_bug.cgi?id=96967
654
655         Reviewed by Abhishek Arya.
656
657         The ASAN bot is crashing attempting to decode some output into
658         UTF-8; there's no reason to do this, so let's not do this and
659         see if something else is going on as well.
660
661         * Scripts/webkitpy/layout_tests/port/chromium.py:
662         (ChromiumPort._get_crash_log):
663
664 2012-09-17  Dirk Pranke  <dpranke@chromium.org>
665
666         nrwt: --results-directory isn't getting printed properly
667         https://bugs.webkit.org/show_bug.cgi?id=96965
668
669         Reviewed by Ojan Vafai.
670
671         options.results_directory isn't actually initialized with the
672         default values until after we call print_config(), so this
673         changes things to print the value directly.
674
675         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
676         (run):
677         * Scripts/webkitpy/layout_tests/views/printing.py:
678         (Printer.print_config):
679         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
680         (Testprinter.test_print_config):
681
682 2012-09-17  Rob Buis  <rbuis@rim.com>
683
684         [BlackBerry] Enable VIDEO_TRACK
685         https://bugs.webkit.org/show_bug.cgi?id=96949
686
687         Reviewed by Antonio Gomes.
688
689         * Scripts/webkitperl/FeatureList.pm:
690
691 2012-09-17  Rick Byers  <rbyers@chromium.org>
692
693         Add handling of new GestureTapCancel in DRT
694
695         https://bugs.webkit.org/show_bug.cgi?id=96183
696
697         Reviewed by Antonio Gomes.
698
699         * DumpRenderTree/chromium/TestWebPlugin.cpp:
700         (TestWebPlugin::handleInputEvent):
701         * DumpRenderTree/chromium/EventSender.cpp:
702         (EventSender::gestureTapCancel):
703
704 2012-09-17  Philip Rogers  <pdr@google.com>
705
706         Teach style checker about preprocessor directive indentation rules
707         https://bugs.webkit.org/show_bug.cgi?id=96874
708
709         Reviewed by Adam Barth.
710
711         Preprocessor directives (#ifdef, #include, #define, etc.) should not be indented.
712         This is not explicit in our style guide but is generally followed in our code.
713         Searching for violations in our codebase shows these are rarely indented:
714             #include - indented in 6 files
715             #ifdef - indented in 0 files
716             #ifndef - indented in 1 file
717             #define - indented in 11 files
718             #if - indented in 7 files
719
720         * Scripts/webkitpy/style/checkers/cpp.py:
721         (check_directive_indentation):
722
723             This is the simple test where we look for spaces followed by a #.
724
725         (check_style):
726         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
727
728             A few tests needed to be modified because they had unintentionally indented
729             preprocessor directives.
730
731         (CppStyleTest.test_build_class.Foo):
732         (CppStyleTest.test_build_class):
733         (CppStyleTest.test_build_class.DERIVE_FROM_GOO):
734         (WebKitStyleTest.test_line_breaking):
735         (WebKitStyleTest.test_directive_indentation):
736
737 2012-09-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
738
739         [Qt] Auto-generate the module pri file for QtWebKit
740
741         Reviewed by Simon Hausmann.
742
743         * qmake/qt_webkit.pri: Removed.
744
745 2012-09-14  Dirk Pranke  <dpranke@chromium.org>
746
747         nrwt: --additional-platform-dir is broken on chromium ports
748         https://bugs.webkit.org/show_bug.cgi?id=96840
749
750         Reviewed by Ojan Vafai.
751
752         Looks like I broke this when cleaning things up as part of
753         adding ML support. Fixing and adding a test.
754
755         * Scripts/webkitpy/layout_tests/port/chromium.py:
756         (ChromiumPort.default_baseline_search_path):
757         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
758         (ChromiumAndroidPort.default_baseline_search_path):
759         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
760         (ChromiumLinuxPort.default_baseline_search_path):
761         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
762         (ChromiumMacPort.__init__):
763         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
764         (ChromiumWinPort.setup_environ_for_server):
765         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
766         (test_check_build):
767         (test_additional_platform_directory):
768
769 2012-09-13  Stephanie Lewis  <slewis@apple.com>
770
771         mac-future ignores previous platform TestExpectations.
772         https://bugs.webkit.org/show_bug.cgi?id=96718.
773
774         Reviewed by Dirk Pranke.
775
776         TestExpectations match an expectation's configuraton against a list of configurations that are 
777         valid for that port.  That list does not contain mac-future so none of the expectations can be
778         applied.
779
780         * Scripts/webkitpy/layout_tests/port/apple.py:
781         (ApplePort._generate_all_test_configurations):
782
783 2012-09-14  Adam Barth  <abarth@webkit.org>
784
785         Remove webkitPostMessage
786         https://bugs.webkit.org/show_bug.cgi?id=96577
787
788         Reviewed by Ojan Vafai.
789
790         Add ENABLE_LEGACY_VENDOR_PREFIXES flag.
791
792         * Scripts/webkitperl/FeatureList.pm:
793         * qmake/mkspecs/features/features.pri:
794
795 2012-09-14  Alexey Proskuryakov  <ap@apple.com>
796
797         [WK2] webarchive/loading/javascript-url-iframe-crash.html fails
798         https://bugs.webkit.org/show_bug.cgi?id=96817
799
800         Reviewed by Kenneth Rohde Christiansen.
801
802         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
803         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): This callback
804         got overlooked when adding logging elsewhere.
805
806 2012-09-14  Peter Beverloo  <peter@chromium.org>
807
808         [Chromium] Build fix for DumpRenderTree following r128628
809         https://bugs.webkit.org/show_bug.cgi?id=96808
810
811         Reviewed by Tony Chang.
812
813         When building DumpRenderTree from the Chromium project, a compile error
814         shows up because including the header ForwardIOStreamsAndroid.h cannot
815         be located. TestWebKitAPI does this correctly.
816
817         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
818
819 2012-09-14  Dana Jansens  <danakj@chromium.org>
820
821         Change cc-bugs@google.com watchlist to cc-bugs@chromium.org
822         https://bugs.webkit.org/show_bug.cgi?id=96805
823
824         Reviewed by Dirk Pranke.
825
826         * Scripts/webkitpy/common/config/committers.py:
827         * Scripts/webkitpy/common/config/watchlist:
828
829 2012-09-14  Peter Beverloo  <peter@chromium.org>
830
831         [Chromium] Support the --{in,out,err}-fifo arguments on TestWebKitAPI and webkit_unit_tests
832         https://bugs.webkit.org/show_bug.cgi?id=96687
833
834         Reviewed by Tony Chang.
835
836         Android's DumpRenderTree currently supports these arguments, implemented
837         as part of TestShellAndroid:
838         http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/chromium/TestShellAndroid.cpp?rev=128496
839
840         They're used by the layout test runner to get the STDOUT and STDERR while
841         a layout test run is in process, which is a safer alternative to parsing
842         all the logcat output manually. The implementation can be seen here:
843         http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py?rev=128496#L590
844
845         This patch generalizes parsing of and applying the effects of these arguments
846         so that they can be used for TestWebKitAPI and webkit_unit_tests as well.
847         After this patch, this will make it possible to pull out the output-reading
848         code from Android's layout test port and generalize it so it can be re-used
849         in the new test-runner for the other two test suites.
850
851         This has no effect when compiling and running these tests as part of Chromium
852         code, which has a much more advanced test-runner that does parse complete log
853         output, but also directly depends on code licensed under Apache 2.
854
855         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
856         * DumpRenderTree/chromium/TestShellAndroid.cpp:
857         (platformInit):
858         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
859
860 2012-09-14  Zoltan Horvath  <zoltan@webkit.org>
861
862         check-webkit-style should not warn in case of NONCOPYABLE and FAST_ALLOCATED macros
863         https://bugs.webkit.org/show_bug.cgi?id=96656
864
865         Reviewed by Adam Barth.
866
867         We should allow to use WTF_MAKE_NONCOPYABLE(ClassName) and WTF_MAKE_FAST_ALLOCATED
868         macros in 1 line.
869
870         * Scripts/webkitpy/style/checkers/cpp.py:
871         (check_style.definitions):
872         (check_style): Add rule.
873         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
874         (WebKitStyleTest.test_line_breaking): Add unittest.
875
876 2012-09-14  Christophe Dumez  <christophe.dumez@intel.com>
877
878         WebKitTestRunner needs layoutTestController.dumpDatabaseCallbacks
879         https://bugs.webkit.org/show_bug.cgi?id=57570
880
881         Reviewed by Kenneth Rohde Christiansen.
882
883         Implement testRunner.dumpDatabaseCallbacks in WebKitTestRunner
884         and dump the information expected by the test cases.
885
886         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
887         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
888         (WTR::InjectedBundle::beginTesting): Explicitly set the default
889         database quota.
890         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
891         (WTR::securityOriginToStr): New convenience function to convert
892         a security origin to the string expected in test results.
893         (WTR):
894         (WTR::InjectedBundlePage::InjectedBundlePage):
895         (WTR::InjectedBundlePage::didExceedDatabaseQuota):
896         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota): Minor
897         refactoring to share code with didExceedDatabaseQuota.
898         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
899         (InjectedBundlePage):
900         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
901         (WTR::TestRunner::TestRunner):
902         * WebKitTestRunner/InjectedBundle/TestRunner.h:
903         (WTR::TestRunner::dumpDatabaseCallbacks):
904         (WTR::TestRunner::shouldDumpDatabaseCallbacks):
905         (TestRunner):
906
907 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
908
909         [Qt] Set force_static_libs_as_shared early enough to be caught by configure
910
911         Rubber-stamped by Simon Hausmann.
912
913         * qmake/mkspecs/features/default_post.prf:
914
915 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
916
917         [Qt] Remove old cruft from the qmake build system
918
919         Rubber-stamped by Simon Hausmann.
920
921         * DumpRenderTree/qt/DumpRenderTree.pro:
922         * qmake/mkspecs/features/default_post.prf:
923
924 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
925
926         [Qt] Enable force_static_libs_as_shared for development
927
928         Not enabled for buildbots or production-builds (part of Qt5)
929
930         Reviewed by Simon Hausmann.
931
932         * qmake/mkspecs/features/default_post.prf:
933
934 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
935
936         [Qt] Make force_static_libs_as_shared work on Mac OS
937
938         We had to move a few LIBS += around that were in the wrong place,
939         and not caught when everything was just linked into the final
940         QtWebKit library.
941
942         Reviewed by Simon Hausmann.
943
944         * qmake/mkspecs/features/default_post.prf:
945         * qmake/mkspecs/features/force_static_libs_as_shared.prf:
946
947 2012-09-14  Simon Hausmann  <simon.hausmann@nokia.com>
948
949         [Qt] Fix build of WTR on Windows
950
951         Reviewed by Tor Arne Vestbø.
952
953         WTR/qt/main.cpp includes TestController.h, which lives in just WTR/
954         With qmake's unix makefile generator as well as with the MingW generator,
955         the directory where the pro file lives (WTR/) is automatically added to
956         the include search path, but not so with MSVC. Instead of relying on qmake's
957         implicit feature here, add WTR/ explicitly to the include search path.
958
959         * WebKitTestRunner/Target.pri:
960
961 2012-09-14  Christophe Dumez  <christophe.dumez@intel.com>
962
963         WebKitTestRunner needs layoutTestController.setStopProvisionalFrameLoads
964         https://bugs.webkit.org/show_bug.cgi?id=42691
965
966         Reviewed by Kenneth Rohde Christiansen.
967
968         Add implementation for testrunner.setStopProvisionalFrameLoads()
969         in WebKitTestRunner.
970
971         Original patch by Alexey Proskuryakov.
972
973         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
974         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
975         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
976         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
977         (WTR::TestRunner::TestRunner):
978         * WebKitTestRunner/InjectedBundle/TestRunner.h:
979         (TestRunner):
980         (WTR::TestRunner::setStopProvisionalFrameLoads):
981         (WTR::TestRunner::shouldStopProvisionalFrameLoads):
982
983 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
984
985         [Qt] Fix handling of debug/release/debug_and_release/build_all
986
987         We now pick up the defaults from Qt, in default_pre (CONFIG already
988         contains the appropriate values for debug and release). We then let
989         the command line arguments to qmake, or the project files themselves,
990         override the configuration, and finally we sanitize the configuration
991         in default_post.
992
993         Reviewed by Simon Hausmann.
994
995         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
996         * Scripts/webkitdirs.pm:
997         (buildQMakeProjects):
998         * qmake/mkspecs/features/default_post.prf:
999         * qmake/mkspecs/features/default_pre.prf:
1000         * qmake/mkspecs/features/mac/default_pre.prf:
1001
1002 2012-09-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1003
1004         WebKitTestRunner needs layoutTestController.setTabKeyCyclesThroughElements
1005         https://bugs.webkit.org/show_bug.cgi?id=42687
1006
1007         Reviewed by Kenneth Rohde Christiansen.
1008
1009         Implement testRunner.setTabKeyCyclesThroughElements for
1010         WebKitTestRunner.
1011
1012         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1013         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1014         (WTR::InjectedBundle::beginTesting):
1015         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1016         (WTR::TestRunner::setTabKeyCyclesThroughElements):
1017         (WTR):
1018         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1019         (TestRunner):
1020
1021 2012-09-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1022
1023         EventSendingController::keyDown does not support non-array modifier arguments
1024         https://bugs.webkit.org/show_bug.cgi?id=96727
1025
1026         Reviewed by Kenneth Rohde Christiansen.
1027
1028         Add support for handling a string as modifier argument to
1029         EventSendingController::keyDown.
1030
1031         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1032         (WTR::parseModifierArray):
1033
1034 2012-09-14  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1035
1036         WebKitTestRunner needs layoutTestController.setCustomPolicyDelegate
1037         https://bugs.webkit.org/show_bug.cgi?id=42546
1038
1039         Reviewed by Kenneth Rohde Christiansen.
1040
1041         Exported TestRunner::setCustomPolicyDelegate() method.
1042         Allowed Policy Delegate dumping even if we're not in 'waitUntilDone' mode.
1043
1044         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1045         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1046         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
1047
1048 2012-09-14  Zan Dobersek  <zandobersek@gmail.com>
1049
1050         [GTK] Clear application cache between tests in DumpRenderTree
1051         https://bugs.webkit.org/show_bug.cgi?id=96543
1052
1053         Reviewed by Philippe Normand.
1054
1055         Call the new DumpRenderTreeSupportGtk method to clear application cache
1056         after each test in DumpRenderTree.
1057
1058         Set the XDG_CACHE_HOME environment variable when running DumpRenderTree
1059         as well. It's now being set in XvfbDriver._start so that each driver is assigned
1060         a cache directory that's constructed out of the driver's name and its worker
1061         number. These directories are located in the layout tests results directory.
1062         At least on the builders this ensures a driver-specific empty cache directory
1063         with each test run.
1064
1065         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1066         (runTest):
1067         * Scripts/webkitpy/layout_tests/port/gtk.py:
1068         (GtkPort.setup_environ_for_server):
1069         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
1070         (XvfbDriver._start):
1071
1072 2012-09-14  Simon Hausmann  <simon.hausmann@nokia.com>
1073
1074         [Qt] Fix linking on Windows
1075
1076         Reviewed by Tor Arne Vestbø.
1077
1078         When compiling code _after_ QtWebKit.dll, we need to make sure that the QWEBKIT_EXPORT
1079         macro turns into an import macro, which means QT_MAKEDLL should only be set _up until_
1080         the QtWebKit.dll creation in the build process and be off afterwards. This is done in
1081         win32/default_post.prf using a !contains(QT, webkit): DEFINES += QT_MAKEDLL.
1082
1083         r128450 sanitized the values of QT and PKGCONFIG to only contain the dependencies we
1084         want for QtWebKit.dll, but unfortunately that code was applied to any binary built also
1085         after the module. Therefore QT did never contain webkit anymore and we always passed
1086         QT_MAKEDLL to DEFINES, resulting in QWEBKIT_EXPORT to _not_ turn into an import macro.
1087
1088         This patch introduces a creating_module configuration that is used to
1089         scope the qt/pkgconfig sanitization.
1090
1091         * qmake/mkspecs/features/default_post.prf:
1092
1093 2012-09-14  Christophe Dumez  <christophe.dumez@intel.com>
1094
1095         [WK2][WKTR] TestRunner is not dumping some frame load callbacks information
1096         https://bugs.webkit.org/show_bug.cgi?id=96740
1097
1098         Reviewed by Kenneth Rohde Christiansen.
1099
1100         Dump information expected by the test cases about the following
1101         frame load callbacks:
1102         "didDisplayInsecureContentForFrame"
1103         "didRunInsecureContentForFrame"
1104         "didDetectXSSForFrame"
1105
1106         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1107         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame): Print a URL
1108         as expected by test results by calling pathSuitableForTestResult() instead
1109         of printing raw URL.
1110         (WTR::InjectedBundlePage::didDisplayInsecureContentForFrame):
1111         (WTR::InjectedBundlePage::didRunInsecureContentForFrame):
1112         (WTR::InjectedBundlePage::didDetectXSSForFrame):
1113
1114 2012-09-14  Peter Beverloo  <peter@chromium.org>
1115
1116         The runtime/unsigned category should be valid in the cpp style-checker.
1117         https://bugs.webkit.org/show_bug.cgi?id=96748
1118
1119         Reviewed by Csaba Osztrogonác.
1120
1121         This is causing the webkitpy tests to fail because it's not listed in the
1122         category array. Furthermore, change an "int" to "long" because it's
1123         throwing a double error in one of the earlier asserts.
1124
1125         * Scripts/webkitpy/style/checkers/cpp.py:
1126         (CppChecker):
1127         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1128         (WebKitStyleTest.test_names):
1129
1130 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1131
1132         Evas_Object* is a ref'ed structure, so tread it as such
1133         https://bugs.webkit.org/show_bug.cgi?id=96659
1134
1135         Reviewed by Adam Barth.
1136
1137         Replace OwnPtr<Evas_Object> with RefPtr.
1138
1139         * DumpRenderTree/efl/ImageDiff.cpp:
1140         (calculateDifference):
1141         (printImageDifferences):
1142         (readImageFromStdin):
1143         (main):
1144
1145 2012-09-14  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1146
1147         Unreviewed, rolling out r128507.
1148         http://trac.webkit.org/changeset/128507
1149         https://bugs.webkit.org/show_bug.cgi?id=96659
1150
1151         Revert. r128507 makes too many crashes in EFL layout test bots.
1152
1153         * DumpRenderTree/efl/ImageDiff.cpp:
1154         (calculateDifference):
1155         (printImageDifferences):
1156         (readImageFromStdin):
1157         (main):
1158
1159 2012-09-13  Kevin Funk  <kevin.funk@kdab.com>
1160
1161         Make compile with both OS(WINCE) and PLATFORM(QT) support
1162         https://bugs.webkit.org/show_bug.cgi?id=95536
1163
1164         Reviewed by Simon Hausmann.
1165
1166         Fix wince support in qmake files
1167
1168         * Tools.pro:
1169         * qmake/mkspecs/features/configure.prf:
1170         * qmake/mkspecs/features/default_post.prf:
1171         * qmake/mkspecs/features/features.prf:
1172         * qmake/mkspecs/features/functions.prf:
1173
1174 2012-09-13  KwangYong Choi  <ky0.choi@samsung.com>
1175
1176         [WK2] Add color picker API support for WebKit2
1177         https://bugs.webkit.org/show_bug.cgi?id=95058
1178
1179         Reviewed by Gyuyoung Kim.
1180
1181         Initialization code for color picker callbacks in UI client.
1182
1183         * MiniBrowser/mac/BrowserWindowController.m:
1184         (-[BrowserWindowController awakeFromNib]):
1185         * MiniBrowser/win/BrowserView.cpp:
1186         (BrowserView::create):
1187         * WebKitTestRunner/TestController.cpp:
1188         (WTR::TestController::createOtherPage):
1189         (WTR::TestController::initialize):
1190
1191 2012-09-13  Yuta Kitamura  <yutak@chromium.org>
1192
1193         Upgrade yutak to reviewer
1194         https://bugs.webkit.org/show_bug.cgi?id=96721
1195
1196         Reviewed by Kent Tamura.
1197
1198         * Scripts/webkitpy/common/config/committers.py:
1199
1200 2012-09-13  Adenilson Cavalcanti  <cavalcantii@gmail.com>
1201
1202         Make the style checker report usage of "unsigned int"
1203         https://bugs.webkit.org/show_bug.cgi?id=96693
1204
1205         Reviewed by Dirk Pranke.
1206
1207         Add a rule to check for uses of unsigned int, as the updated coding style recomends.
1208
1209         * Scripts/webkitpy/style/checkers/cpp.py:
1210         (check_language):
1211
1212 2012-09-13  Philip Rogers  <pdr@google.com>
1213
1214         Add gender-neutral form of webkit-patch land-cowboy
1215         https://bugs.webkit.org/show_bug.cgi?id=96709
1216
1217         Reviewed by Adam Barth.
1218
1219         Add webkit-patch land-cowhand, the confident and courageous form of webkit-patch for everyone.
1220
1221         * Scripts/webkitpy/tool/commands/download.py:
1222         (LandCowhand):
1223
1224 2012-09-13  Seokju Kwon  <seokju.kwon@samsung.com>
1225
1226         [EFL] Remove some parameters in browserCreate()
1227         https://bugs.webkit.org/show_bug.cgi?id=96499
1228
1229         Reviewed by Kenneth Rohde Christiansen.
1230
1231         There are too many parameters in browserCreate(). Lots of it seems like settings from command line argument.
1232         And I have moved some parameters into User_Arguments.
1233
1234         * EWebLauncher/main.c:
1235         (_User_Arguments):
1236         (_ELauncher):
1237         (on_key_down):
1238         (browserCreate):
1239         (findThemePath):
1240         (parseUserArguments):
1241         (main):
1242
1243 2012-09-13  Mark Lam  <mark.lam@apple.com>
1244
1245         Unreviewed. Adding myself to the committers list.
1246
1247         * Scripts/webkitpy/common/config/committers.py:
1248
1249 2012-09-13  Ryosuke Niwa  <rniwa@webkit.org>
1250
1251         run-perf-tests output cryptic error when the config file is missing.
1252         https://bugs.webkit.org/show_bug.cgi?id=96453
1253
1254         Reviewed by Tony Chang.
1255
1256         Add a special error message when a configuration file is missing.
1257
1258         Also update the help message of --source-json-path to signify the fact it specifies
1259         the configuration file on performance tests bots.
1260
1261         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1262         (PerfTestsRunner._parse_args):
1263         (PerfTestsRunner._generate_and_show_results):
1264         (PerfTestsRunner._merge_slave_config_json):
1265         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1266         (_test_run_with_json_output): Make upload to fail by default and assert the result
1267         in the function so that we can return logs instead.
1268         (_test_run_with_json_output.mock_upload_json):
1269         (test_run_with_json_output):
1270         (test_run_with_description):
1271         (test_run_respects_no_results):
1272         (test_run_with_slave_config_json):
1273         (test_run_with_bad_slave_config_json):
1274         (test_run_with_multiple_repositories):
1275
1276 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1277
1278         Evas_Object* is a ref'ed structure, so tread it as such
1279         https://bugs.webkit.org/show_bug.cgi?id=96659
1280
1281         Reviewed by Adam Barth.
1282
1283         Replace OwnPtr<Evas_Object> with RefPtr.
1284
1285         * DumpRenderTree/efl/ImageDiff.cpp:
1286         (calculateDifference):
1287         (printImageDifferences):
1288         (readImageFromStdin):
1289         (main):
1290
1291 2012-09-13  Csaba Osztrogonác  <ossy@webkit.org>
1292
1293         One more unreviewed trivial fix after r128399.
1294
1295         * BuildSlaveSupport/build.webkit.org-config/config.json: Fix URLs of the SVN mirror server.
1296
1297 2012-09-13  Csaba Osztrogonác  <ossy@webkit.org>
1298
1299         Unreviewed trivial fix after r128399.
1300
1301         * BuildSlaveSupport/wait-for-SVN-server.py: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/wait-for-SVN-server.py.
1302         (getLatestSVNRevision):
1303         (waitForSVNRevision):
1304
1305 2012-09-13  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1306
1307         [WK2][WTR] WebKitTestRunner needs testRunner.callShouldCloseOnWebView
1308         https://bugs.webkit.org/show_bug.cgi?id=96366
1309
1310         Reviewed by Anders Carlsson.
1311
1312         Implement testRunner.callShouldCloseOnWebView for WebKitTestRunner
1313         by calling shouldClose() on the FrameLoader.
1314
1315         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1316         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1317         (WTR::TestRunner::callShouldCloseOnWebView):
1318         (WTR):
1319         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1320         (TestRunner):
1321
1322 2012-09-13  Sheriff Bot  <webkit.review.bot@gmail.com>
1323
1324         Unreviewed, rolling out r128453.
1325         http://trac.webkit.org/changeset/128453
1326         https://bugs.webkit.org/show_bug.cgi?id=96681
1327
1328         Having tests use the same appcache directory leads to timeouts
1329         (Requested by zdobersek on #webkit).
1330
1331         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1332         (runTest):
1333         * Scripts/webkitpy/layout_tests/port/gtk.py:
1334         (GtkPort.setup_environ_for_server):
1335
1336 2012-09-13  James Robinson  <jamesr@chromium.org>
1337
1338         [chromium] Temporarily remove Android Builder (dbg) from garden-o-matic view
1339         https://bugs.webkit.org/show_bug.cgi?id=96678
1340
1341         Reviewed by Dirk Pranke.
1342
1343         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1344         (.):
1345
1346 2012-09-13  Rob Buis  <rbuis@rim.com>
1347
1348         Unreviewed changes to watchlist.
1349
1350         - Add myself to BlackBerry bugs
1351
1352         * Scripts/webkitpy/common/config/watchlist:
1353
1354 2012-09-13  Stephen Chenney  <schenney@chromium.org>
1355
1356         Add an SVG entry to the watchlist
1357
1358         Unreviewed config change.
1359
1360         * Scripts/webkitpy/common/config/watchlist:
1361         - Created a new SVG watchlist label covering WebCore/svg and WebCore/rendering/svg
1362         - Added myself and pdr as watchers
1363
1364 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1365
1366         [Qt] Make WebKit2 work on Windows with Qt 5
1367         https://bugs.webkit.org/show_bug.cgi?id=76776
1368
1369         Reviewed by Tor Arne Vestbø.
1370
1371         WebKit2 should compile with Qt on Windows now, so enable it. This patch in fact corrects
1372         the check to disable WebKit when we don't have USE_3D_GRAPHICS available, because we need
1373         that for the GL TextureMapper (it's only built when that feature is set).
1374
1375         * qmake/mkspecs/features/configure.prf:
1376
1377 2012-09-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1378
1379         [Qt] Ensure that QT is finalized before loading qt_module.prf
1380
1381         As qt_module.prf does dependency tracking based on the content of the
1382         QT variable. The intermediate WebKit modules modify the variable in
1383         their .pri files, so we have to ensure we've loaded all the modules
1384         before loading qt_module.
1385
1386         Reviewed by Tor Arne Vestbø.
1387         Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-09-13
1388
1389         * qmake/mkspecs/features/default_post.prf:
1390         * qmake/mkspecs/features/webkit_modules.prf: Added.
1391
1392 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1393
1394         [Qt] Fix build of Qt WTR/MiniBrowser with MSVC and nmake
1395         https://bugs.webkit.org/show_bug.cgi?id=96633
1396
1397         Reviewed by Csaba Osztrogonác.
1398
1399         WTR and MiniBrowser both have DRT in their include path (for the shared font stuff). Batch
1400         builds with MSVC and nmake result in nmake picking up main.cpp from the wrong directory.
1401         It's the usual problem and the usual solution is to rename one of the conflicting files.
1402         This patch chooses to rename DRT instead of WTR and MBR.
1403
1404         Fixed include order at the same time to match style guide.
1405
1406         * DumpRenderTree/qt/DumpRenderTree.pro:
1407         * DumpRenderTree/qt/DumpRenderTreeMain.cpp: Renamed from Tools/DumpRenderTree/qt/main.cpp.
1408         (messageHandler):
1409         (isOption):
1410         (takeOptionValue):
1411         (printUsage):
1412         (main):
1413
1414 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1415
1416         The Script run-launcher should support -2 in combination with --efl
1417         https://bugs.webkit.org/show_bug.cgi?id=96639
1418
1419         Reviewed by Simon Hausmann.
1420
1421         Support running the MiniBrowser then supplied -2 as argument.
1422
1423         * Scripts/run-launcher:
1424
1425 2012-09-13  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1426
1427         Unreviewed, add my Intel email address to the list.
1428
1429         * Scripts/webkitpy/common/config/committers.py:
1430
1431 2012-09-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1432
1433         [Qt] Don't overwrite LIBS_PRIVATE when sanitizing LIBS
1434
1435         Reviewed by Ossy.
1436
1437         * qmake/mkspecs/features/default_post.prf:
1438
1439 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1440
1441         [EFL][DRT] Implement LayoutTestController::layerTreeAsText
1442         https://bugs.webkit.org/show_bug.cgi?id=82294
1443
1444         Reviewed by Gyuyoung Kim.
1445
1446         Implement layerTreeAsText using the DumpRenderTreeSupportEfl method.
1447
1448         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1449         (TestRunner::layerTreeAsText):
1450
1451 2012-09-13  Zan Dobersek  <zandobersek@gmail.com>
1452
1453         [GTK] Clear application cache between tests in DumpRenderTree
1454         https://bugs.webkit.org/show_bug.cgi?id=96543
1455
1456         Reviewed by Philippe Normand.
1457
1458         Call the new DumpRenderTreeSupportGtk method to clear application cache
1459         after each test.
1460
1461         Set the XDG_CACHE_HOME environment variable when running DumpRenderTree
1462         as well. Currently it points to a subdirectory in the layout tests results
1463         directory. At least on the builders this ensures an empty cache directory
1464         with each test run.
1465
1466         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1467         (runTest):
1468         * Scripts/webkitpy/layout_tests/port/gtk.py:
1469         (GtkPort.setup_environ_for_server):
1470
1471 2012-09-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1472
1473         [Qt] Make sure LIBS, PKGCONFIG, and QT, do not affect QtWebKit's prl file
1474
1475         Unless it's actually a dependency of the public QtWebKit API.
1476
1477         We could replace every occurance of LIBS, PKGCONFIG, and QT, in the pri
1478         files with their _PRIVATE equivivalent, but that's likely to break when
1479         someone adds a new QT/LIBS/PKGCONFIG += foo line somewhere. Instead we
1480         clean up the variables in default_post.
1481
1482         This means that the CONFIG -= explicitlib in linkAgainstLibrary() is no
1483         longer needed, as it was a workaround for the intermediate libraries ending
1484         up in the prl file. And, since CONFIG -= staticlib was there to support
1485         the explicitlib option, we can remove that too (as well as the exception
1486         for gprof, since it would be empty). If gprof needs tweaks to always link
1487         statically they should go in gprof.prf.
1488
1489         Reviewed by Simon Hausmann.
1490
1491         * qmake/mkspecs/features/default_post.prf:
1492         * qmake/mkspecs/features/functions.prf:
1493
1494 2012-09-13  Mario Sanchez Prada  <msanchez@igalia.com>
1495
1496         [GTK] "Infinite" loop in AccessibilityUIElementGtk.cpp
1497         https://bugs.webkit.org/show_bug.cgi?id=96632
1498
1499         Reviewed by Carlos Garcia Campos.
1500
1501         Fix this by using atk_object_get_n_accessible_children instead of
1502         calling getChildren() from childCount.
1503
1504         * WebKitTestRunner/InjectedBundle/gtk/AccessibilityUIElementGtk.cpp:
1505         (WTR::AccessibilityUIElement::childrenCount): Avoid the infinite
1506         loop by using atk_object_get_n_accessible_children().
1507
1508 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1509
1510         [Qt][Win] Enable USE(3D_GRAPHICS)
1511         https://bugs.webkit.org/show_bug.cgi?id=90879
1512
1513         Reviewed by Kenneth Rohde Christiansen.
1514
1515         Enable it on Windows as well as on QNX (bug fixed).
1516
1517         * qmake/mkspecs/features/features.prf:
1518
1519 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1520
1521         [Qt] The ANGLE build on Windows breaks with GnuWin32's flex because it is too old
1522         https://bugs.webkit.org/show_bug.cgi?id=96359
1523
1524         Reviewed by Tor Arne Vestbø.
1525
1526         GnuWin32's flex is 2.5.4 and that is too old for ANGLE's preprocessor
1527         lexer. The only viable alternative I could find on Windows that provides
1528         binaries is the winflexbison distribution (http://sourceforge.net/projects/winflexbison/),
1529         so let's use that one instead.
1530
1531         * Scripts/webkitdirs.pm:
1532         (checkRequiredSystemConfig):
1533         * qmake/mkspecs/features/default_pre.prf:
1534
1535 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1536
1537         [Qt] Add configuration for production builds
1538         https://bugs.webkit.org/show_bug.cgi?id=96607
1539
1540         Reviewed by Kenneth Rohde Christiansen.
1541
1542         Add configuration tweaks for production builds, to ease memory pressure with the GNU toolchain
1543         and enable all-in-one-files optimizations.
1544
1545         * qmake/mkspecs/features/production_build.prf: Added.
1546
1547 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1548
1549         [Qt] GStreamer detection does not work when cross-compiling
1550         https://bugs.webkit.org/show_bug.cgi?id=96608
1551
1552         Reviewed by Kenneth Rohde Christiansen.
1553
1554         When cross-compiling it is not safe to just use system(pkg-config),
1555         because there is a high probability that it will find packages in the
1556         host system instead of in the target one. Instead use qmake's new
1557         packagesExist() function that takes care of this delicate aspect of
1558         cross compilation by setting PKG_CONFIG_SYSROOT_DIR and
1559         PKG_CONFIG_LIBDIR accordingly.
1560
1561         * qmake/mkspecs/features/features.prf:
1562
1563 2012-09-13  Christophe Dumez  <christophe.dumez@intel.com>
1564
1565         [WK2][WTR] More efficient string handling in InjectedBundlePage
1566         https://bugs.webkit.org/show_bug.cgi?id=96609
1567
1568         Reviewed by Kenneth Rohde Christiansen.
1569
1570         Update StringBuilder usage in InjectedBundlePage to follow
1571         the latest recommandations for efficient string handling:
1572         http://trac.webkit.org/wiki/EfficientStrings
1573
1574         This involves using appendLiteral() or appendNumber()
1575         instead of append() whenever possible.
1576
1577         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1578         (WTR::dumpPath):
1579         (WTR::rangeToStr):
1580         (WTR::styleDecToStr):
1581         (WTR::frameToStr):
1582         (WTR::dumpResourceURL):
1583         (WTR):
1584         (WTR::dumpFrameDescriptionSuitableForTestResult):
1585         (WTR::dumpRequestDescriptionSuitableForTestResult):
1586         (WTR::dumpResponseDescriptionSuitableForTestResult):
1587         (WTR::dumpErrorDescriptionSuitableForTestResult):
1588         (WTR::InjectedBundlePage::didReceiveIntentForFrame):
1589         (WTR::InjectedBundlePage::registerIntentServiceForFrame):
1590         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
1591         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
1592         (WTR::InjectedBundlePage::didCommitLoadForFrame):
1593         (WTR::InjectedBundlePage::didFinishProgress):
1594         (WTR::dumpFrameScrollPosition):
1595         (WTR::dumpFrameText):
1596         (WTR::dumpDescendantFramesText):
1597         (WTR::InjectedBundlePage::didFinishLoadForFrame):
1598         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
1599         (WTR::InjectedBundlePage::didCancelClientRedirectForFrame):
1600         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
1601         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
1602         (WTR::InjectedBundlePage::didHandleOnloadEventsForFrame):
1603         (WTR::InjectedBundlePage::willSendRequestForFrame):
1604         (WTR::InjectedBundlePage::didReceiveResponseForResource):
1605         (WTR::InjectedBundlePage::didFinishLoadForResource):
1606         (WTR::InjectedBundlePage::didFailLoadForResource):
1607         (WTR::InjectedBundlePage::shouldCacheResponse):
1608         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
1609         (WTR::InjectedBundlePage::willAddMessageToConsole):
1610         (WTR::InjectedBundlePage::willSetStatusbarText):
1611         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
1612         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
1613         (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
1614         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
1615         (WTR::InjectedBundlePage::shouldBeginEditing):
1616         (WTR::InjectedBundlePage::shouldEndEditing):
1617         (WTR::InjectedBundlePage::shouldInsertNode):
1618         (WTR::InjectedBundlePage::shouldInsertText):
1619         (WTR::InjectedBundlePage::shouldDeleteRange):
1620         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
1621         (WTR::InjectedBundlePage::shouldApplyStyle):
1622         (WTR::InjectedBundlePage::didBeginEditing):
1623         (WTR::InjectedBundlePage::didEndEditing):
1624         (WTR::InjectedBundlePage::didChange):
1625         (WTR::InjectedBundlePage::didChangeSelection):
1626         (WTR::InjectedBundlePage::supportsFullScreen):
1627         (WTR::InjectedBundlePage::enterFullScreenForElement):
1628         (WTR::InjectedBundlePage::exitFullScreenForElement):
1629         (WTR::InjectedBundlePage::beganEnterFullScreen):
1630         (WTR::InjectedBundlePage::beganExitFullScreen):
1631         (WTR::InjectedBundlePage::closeFullScreen):
1632         (WTR::dumpBackForwardListItem):
1633         (WTR::InjectedBundlePage::dumpBackForwardList):
1634
1635 2012-09-13  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1636
1637         [Qt][WK2] Memory leaks in Qt's TestRunner
1638         https://bugs.webkit.org/show_bug.cgi?id=96603
1639
1640         Reviewed by Csaba Osztrogonác.
1641
1642         Fix memory leaks in Qt's TestRunner code by adopting WKString
1643         created with WKStringCreateWithUTF8CString().
1644
1645         * WebKitTestRunner/qt/TestControllerQt.cpp:
1646         (WTR::TestController::initializeInjectedBundlePath):
1647         (WTR::TestController::initializeTestPluginDirectory):
1648
1649 2012-09-13  Zan Dobersek  <zandobersek@gmail.com>
1650
1651         [GTK][NRWT] Lower timeout value to 6 seconds (12 for debug configuration)
1652         https://bugs.webkit.org/show_bug.cgi?id=96506
1653
1654         Reviewed by Dirk Pranke.
1655
1656         Lower the timeout value to 6 seconds for release configuration and 12 seconds
1657         for debug configuration. These are the same values the Chromium port uses.
1658
1659         Currently the value is lowered only for the DumpRenderTree, WebKitTestRunner (and
1660         the layout tests under WebKit2 generally) requires more attention and gardening
1661         than what the current effort produces.
1662
1663         The unit test is updated as well to test these changes.
1664
1665         * Scripts/webkitpy/layout_tests/port/gtk.py:
1666         (GtkPort.default_timeout_ms):
1667         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
1668         (GtkPortTest.test_default_timeout_ms):
1669         (GtkPortTest.assertLinesEqual):
1670
1671 2012-09-12  Csaba Osztrogonác  <ossy@webkit.org>
1672
1673         Add SVN mirror handling feature to build.webkit.org
1674         https://bugs.webkit.org/show_bug.cgi?id=85887
1675
1676         Reviewed by Dirk Pranke.
1677
1678         * BuildSlaveSupport/build.webkit.org-config/config.json: Add SVN mirrors for Qt buildslaves hosted in Szeged.
1679         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1680         (ConfigureBuild.__init__): Add SVNMirror property to be able to watch which slaves use which mirror on build.webkit.org.
1681         (ConfigureBuild.start):
1682         (CheckOutSource.__init__): Set baseURL to the SVNMirror or the default http://svn.webkit.org/repository/webkit/
1683         (WaitForSVNServer): Add new buildstep for waiting the SVNMirror to be in sync with http://svn.webkit.org/repository/webkit/
1684         (Factory.__init__):
1685         (BuildFactory.__init__):
1686         (TestFactory.__init__):
1687         (BuildAndTestFactory.__init__):
1688         (BuildAndPerfTestFactory.__init__):
1689         (BuildAndPerfTestWebKit2Factory.__init__):
1690         (DownloadAndPerfTestFactory.__init__):
1691         (DownloadAndPerfTestWebKit2Factory.__init__):
1692         (loadBuilderConfig): Use kwargs instead of args to be able to add the optional SVNMirror factory argument.
1693         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1694         (SVNMirrorTest):
1695         (SVNMirrorTest.setUp): Load config.json once at startup.
1696         (SVNMirrorTest.get_SVNMirrorFromConfig): Get the SVNMirror from config.json for a given buildslave.
1697         (SVNMirrorTest.test_CheckOutSource): Compare CheckOutSource.baseURL with SVNMirror in config.json for all builders
1698         * BuildSlaveSupport/build.webkit.org-config/wait-for-SVN-server.py: Added.
1699         (getLatestSVNRevision): Get the latest SVN revison from the given server.
1700         (waitForSVNRevision): Wait until the given SVN revision is committed to the given server. It doesn't wait if the
1701                               SVN revision is empty (force build triggered without revision) or the server is unavailable.
1702
1703 2012-09-12  Kangil Han  <kangil.han@samsung.com>
1704
1705         [WK2][WTR] Set waitUntilDone watchdog timer value equal to WK1.
1706         https://bugs.webkit.org/show_bug.cgi?id=81606
1707
1708         Reviewed by Tim Horton.
1709
1710         6 seconds is harsh for some jquery test cases.
1711         Therefore, adjust the value to match DumpRenderTree.
1712
1713         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1714         (WTR):
1715
1716 2012-09-12  KyungTae Kim  <ktf.kim@samsung.com>
1717
1718         [EFL] Support download attribute feature
1719         https://bugs.webkit.org/show_bug.cgi?id=96462
1720
1721         Reviewed by Gyuyoung Kim.
1722
1723         Enable DOWNLOAD_ATTRIBUTE feature for EFL port,
1724         and add "download,request" callback to the DumpRenderTree for EFL.
1725
1726         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1727         (DumpRenderTreeChrome::createView):
1728         (DumpRenderTreeChrome::onDownloadRequest):
1729         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1730         (DumpRenderTreeChrome):
1731         * Scripts/webkitperl/FeatureList.pm:
1732
1733 2012-09-12  Stephanie Lewis  <slewis@apple.com>
1734
1735         Reduce parallism on the wk2 testers.
1736         https://bugs.webkit.org/show_bug.cgi?id=95906
1737
1738         Reviewed by Dirk Pranke.
1739
1740         The wk2 testers on Mountain Lion are getting stuck and timing out.  The problem appears to be due to
1741         resource contention.  Reducing the number of processes alleviates the issue.  
1742
1743         Starting by reducing 25%.
1744
1745         * Scripts/webkitpy/layout_tests/port/mac.py:
1746         (MacPort.default_child_processes):
1747
1748 2012-09-12  Brady Eidson  <beidson@apple.com>
1749
1750         Assert in NetscapePlugin::destroy() with async plugin init
1751         <rdar://problem/12277595> and https://bugs.webkit.org/show_bug.cgi?id=96576
1752
1753         Reviewed by Anders Carlsson.
1754
1755         Expose NPN_Invoke to plug-in tests:
1756         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1757         (PluginTest::NPN_Invoke):
1758         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1759         (PluginTest):
1760
1761         Add a test that uses NPN_Invoke on the window object from inside NPP_New to remove the plug-in element:
1762         * DumpRenderTree/TestNetscapePlugIn/Tests/InvokeDestroysPluginWithinNPP_New.cpp: Added.
1763         (InvokeDestroysPluginWithinNPP_New):
1764         (InvokeDestroysPluginWithinNPP_New::InvokeDestroysPluginWithinNPP_New):
1765         (InvokeDestroysPluginWithinNPP_New::NPP_New):
1766         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1767
1768 2012-09-12  Dirk Pranke  <dpranke@chromium.org>
1769
1770         refactor TestExpectations tokenization slightly in preparation for the new syntax
1771         https://bugs.webkit.org/show_bug.cgi?id=96564
1772
1773         Reviewed by Ojan Vafai.
1774
1775         This change changes how we will tokenize/lex the
1776         TestExpectations files, in preparation for supporting both the
1777         old syntax and the new one. This change by itself should be a
1778         no-op.
1779
1780         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1781         (TestExpectationParser._tokenize_line):
1782         (TestExpectationParser):
1783         (TestExpectationParser._tokenize_line_using_old_format):
1784         (TestExpectationParser._tokenize_line_using_new_format):
1785
1786 2012-09-12  Dirk Pranke  <dpranke@chromium.org>
1787
1788         remove unused testexpectations editing code from webkitpy, garden-o-matic
1789         https://bugs.webkit.org/show_bug.cgi?id=96562
1790
1791         Reviewed by Adam Barth.
1792
1793         This code was prototyped but never fully realized. Removing
1794         until it reanimates :).
1795
1796         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
1797         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
1798         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor.py: Removed.
1799         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py: Removed.
1800         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1801         (BuildCoverageExtrapolator.extrapolate_test_configurations):
1802         (GardeningHTTPRequestHandler._run_webkit_patch):
1803         (GardeningHTTPRequestHandler.ping):
1804         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1805         (BuildCoverageExtrapolatorTest.test_extrapolate):
1806         (GardeningServerTest.test_rebaseline_new_port):
1807
1808 2012-09-12  Lucas Forschler  <lforschler@apple.com>
1809
1810         Remove unused bot, apple-xserve-1.
1811         https://bugs.webkit.org/show_bug.cgi?id=96570
1812         
1813         Reviewed by Stephanie Lewis.
1814
1815         * BuildSlaveSupport/build.webkit.org-config/config.json:
1816
1817 2012-09-12  Xan Lopez  <xlopez@igalia.com>
1818
1819         [GTK] We attempt to rebase documentation even if it's not present
1820         https://bugs.webkit.org/show_bug.cgi?id=96553
1821
1822         Reviewed by Martin Robinson.
1823
1824         Do not make the documentation rebase step fatal. This allows make
1825         install to succeed when there's no documentation generated.
1826
1827         * gtk/generate-gtkdoc:
1828
1829 2012-09-12  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1830
1831         Respect WEBKITOUTPUTDIR when running EFL tests
1832         https://bugs.webkit.org/show_bug.cgi?id=96528
1833
1834         Reviewed by Dirk Pranke.
1835
1836         Expose user set WEBKITOUTPUTDIR to the web process.
1837
1838         * Scripts/webkitpy/layout_tests/port/driver.py:
1839         (Driver._start): Add WEBKITOUTPUTDIR to the environment
1840         of the web process and its potential jhbuild wrapper.
1841
1842 2012-09-12  Dirk Pranke  <dpranke@chromium.org>
1843
1844         webkitdirs: fix uname version handling for cygwin
1845         https://bugs.webkit.org/show_bug.cgi?id=96436
1846
1847         Reviewed by Jon Honeycutt.
1848
1849         Newer versions of cygwin embed an additional version string
1850         inside parentheses, so you get "1.7.16(0.249/5/3)" instead of "1.7.16".
1851         Update the code to handle that.
1852
1853         * Scripts/webkitdirs.pm:
1854         (setupAppleWinEnv):
1855
1856 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
1857
1858         Regression(r128338): Broke Windows build
1859         https://bugs.webkit.org/show_bug.cgi?id=96537
1860
1861         Unreviewed build fix.
1862
1863         Fix Apple-Win build by allocating array dynamically
1864         since its size is not constant.
1865
1866         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1867         (WTR::stringArrayToJS):
1868
1869 2012-09-12  Alex Sakhartchouk  <alexst@chromium.org>
1870
1871         [chromium] Add a virtual test suite for fast/hidpi
1872         https://bugs.webkit.org/show_bug.cgi?id=90192
1873
1874         Reviewed by Dirk Pranke.
1875
1876         Add a virtual test suite to make sure the pixel tests in fast/hidpi give the same result
1877         on the hardware accelerated path as the software path.
1878
1879         * DumpRenderTree/chromium/WebPreferences.cpp:
1880         (WebPreferences::applyTo):
1881         * Scripts/webkitpy/layout_tests/port/chromium.py:
1882         (ChromiumPort.virtual_test_suites):
1883
1884 2012-09-12  Adam Klein  <adamk@chromium.org>
1885
1886         [chromium] Add content_browsertests to the flakiness dashboard
1887         https://bugs.webkit.org/show_bug.cgi?id=96535
1888
1889         Reviewed by Ojan Vafai.
1890
1891         * TestResultServer/static-dashboards/dashboard_base.js:
1892
1893 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
1894
1895         [WK2][WKTR] TestRunner needs to implement originsWithApplicationCache
1896         https://bugs.webkit.org/show_bug.cgi?id=96496
1897
1898         Reviewed by Kenneth Rohde Christiansen.
1899
1900         Add implementation for originsWithApplicationCache to
1901         WebKitTestRunner.
1902
1903         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1904         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1905         (WTR::stringArrayToJS):
1906         (WTR):
1907         (WTR::TestRunner::originsWithApplicationCache):
1908         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1909         (TestRunner):
1910
1911 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
1912
1913         Fix Qt/Windows build with Python3
1914         https://bugs.webkit.org/show_bug.cgi?id=96473
1915
1916         Reviewed by Csaba Osztrogonác.
1917
1918         In Python 3 print is a real function, so we must use parentheses around
1919         the function parameters. This is backwards compatible with Python 2.
1920
1921         * Scripts/generate-win32-export-forwards:
1922
1923 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
1924
1925         Unreviewed trivial build fix for Qt/Windows after bug #96358.
1926
1927         As pointed out by Kevin, we should inject the "set PATH=..." statement
1928         to add the GnuWin32 directory only if that directory actually exists.
1929
1930         * qmake/mkspecs/features/default_post.prf:
1931
1932 2012-09-12  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1933
1934         [EFL] [WK2] Memory leaks in TestControllerEfl
1935         https://bugs.webkit.org/show_bug.cgi?id=96525
1936
1937         Reviewed by Kenneth Rohde Christiansen.
1938
1939         Fix memory leaks in EFL's TestRunner code by adopting an allocation
1940         of WKString created with WKStringCreateWithUTF8CString().
1941
1942         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1943         (WTR::TestController::initializeInjectedBundlePath):
1944         (WTR::TestController::initializeTestPluginDirectory):
1945
1946 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
1947
1948         [WK2][WKTR] TestRunner needs to implement dumpApplicationCacheDelegateCallbacks
1949         https://bugs.webkit.org/show_bug.cgi?id=96374
1950
1951         Reviewed by Kenneth Rohde Christiansen.
1952
1953         Implement support for dumpApplicationCacheDelegateCallbacks
1954         and disallowIncreaseForApplicationCacheQuota in
1955         WebKitTestRunner and properly dump the information
1956         expected by the tests.
1957
1958         If the application cache quota is reached for a given
1959         security origin, WebKitTestRunner will reset the quota
1960         to its default value, unless intructed not to via
1961         disallowIncreaseForApplicationCacheQuota().
1962
1963         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1964         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1965         (WTR::InjectedBundlePage::InjectedBundlePage):
1966         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
1967         (WTR):
1968         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1969         (InjectedBundlePage):
1970         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1971         (WTR::TestRunner::TestRunner):
1972         (WTR::TestRunner::disallowIncreaseForApplicationCacheQuota):
1973         (WTR):
1974         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1975         (WTR::TestRunner::dumpApplicationCacheDelegateCallbacks):
1976         (TestRunner):
1977         (WTR::TestRunner::shouldDisallowIncreaseForApplicationCacheQuota):
1978         (WTR::TestRunner::shouldDumpApplicationCacheDelegateCallbacks):
1979
1980 2012-09-12  Jochen Eisinger  <jochen@chromium.org>
1981
1982         [chromium] remove deprecated and unused sets import from chromium_android driver
1983         https://bugs.webkit.org/show_bug.cgi?id=96485
1984
1985         Reviewed by Dirk Pranke.
1986
1987         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1988
1989 2012-09-12  Zan Dobersek  <zandobersek@gmail.com>
1990
1991         Flakiness dashboard doesn't recognize new Chromium Android test builder
1992         https://bugs.webkit.org/show_bug.cgi?id=96523
1993
1994         Reviewed by Ojan Vafai.
1995
1996         Properly return 'ANDROID' as the Chromium platform for Android builders.
1997
1998         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1999         (chromiumPlatform):
2000         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2001         (test):
2002
2003 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
2004
2005         [Qt] Build on Windows requires bison/flex in PATH
2006         https://bugs.webkit.org/show_bug.cgi?id=96358
2007
2008         Reviewed by Tor Arne Vestbø.
2009
2010         The build requires flex, bison, etc. and they need to be in the PATH when building. On Mac OS X
2011         and Linux that is rarely a problem given how easily available the tools are. On Windows however
2012         a separate installation of various GNU tools is required as the operating system doesn't come with
2013         them. To make the development more convenient, Qt 5 provides a copy of the most essential tools in
2014         the gnuwin32 directory of the qt5.git top-level repository.
2015
2016         This patch tries to detect the presence of those tools and prepends them to the PATH if found.
2017
2018         This is required in preparation for the elimination of qt5/qtwebkit.pri, which currently expands
2019         PATH before calling build-webkit. It it also required for the upcoming introduction of win_flex
2020         as dependency over flex, which can be done with less hassle when qt5's gnuwin32 directory has been
2021         updated with the new tool.
2022
2023         * Scripts/webkitdirs.pm:
2024         (checkRequiredSystemConfig):
2025         * qmake/mkspecs/features/default_post.prf:
2026
2027 2012-09-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2028
2029         [Qt] Update build-jsc after r128174
2030
2031         Reviewed by Ossy.
2032
2033         * Scripts/build-jsc:
2034
2035 2012-09-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2036
2037         [Qt] Teach addStrictSubdirOrderBetween to handle more than two targets
2038
2039         By hard-coding the names of the targets we defined we ended up just
2040         redefining the previous target when using addStrictSubdirOrderBetween
2041         more than once in a single project file.
2042
2043         We now embed the two base targets into the target names.
2044
2045         Reviewed by Simon Hausmann.
2046
2047         * qmake/mkspecs/features/functions.prf:
2048
2049 2012-09-12  Philippe Liard  <pliard@google.com>
2050
2051         Depend on {base,net} GYP targets rather than {base,net}_java.
2052         https://bugs.webkit.org/show_bug.cgi?id=95690
2053
2054         Reviewed by Adam Barth.
2055
2056         {base,net}_java became 'private' targets on the Chromium side that
2057         clients should not depend on (see
2058         https://chromiumcodereview.appspot.com/10913083/).
2059         This removes a bunch of trailing white spaces additionally in
2060         TestWebkitAPI.gyp (which includes non-trailing white space changes).
2061
2062         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2063         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
2064
2065 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
2066
2067         [Qt] Fix the build with ENABLE_NETSCAPE_PLUGIN_API=0
2068         https://bugs.webkit.org/show_bug.cgi?id=96494
2069
2070         Reviewed by Tor Arne Vestbø.
2071
2072         WK2's ENABLE_PLUGIN_PROCESS uses the NPAPI functions unconditionally, so disable the
2073         plugin process feature if we don't have NPAPI.
2074
2075         * qmake/mkspecs/features/features.prf:
2076
2077 2012-09-12  Sheriff Bot  <webkit.review.bot@gmail.com>
2078
2079         Unreviewed, rolling out r128280.
2080         http://trac.webkit.org/changeset/128280
2081         https://bugs.webkit.org/show_bug.cgi?id=96498
2082
2083         it broke compilation on windows debug bot (Requested by loislo
2084         on #webkit).
2085
2086         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2087         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2088         (WTR::InjectedBundlePage::InjectedBundlePage):
2089         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2090         (InjectedBundlePage):
2091         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2092         (WTR::TestRunner::TestRunner):
2093         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2094         (TestRunner):
2095
2096 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
2097
2098         [Qt] Make it possible to build with "make release" and "make debug" on Windows
2099         https://bugs.webkit.org/show_bug.cgi?id=96488
2100
2101         Reviewed by Tor Arne Vestbø.
2102
2103         A "make debug" is passed through recursively and currently it aborts at Makefile.DerivedSources
2104         because there are no such targets. We want the generated sources to be independent from release
2105         or debug build configurations, so it is sufficient to provide fake debug and release targets that
2106         redirect to the same general-purpose target (first) of creating the derived sources.
2107
2108         * qmake/mkspecs/features/default_post.prf:
2109
2110 2012-09-12  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2111
2112         [EFL] Make DumpRenderTree smarter at finding the fonts
2113         http://webkit.org/b/96281
2114
2115         Reviewed by Gyuyoung Kim.
2116
2117         Respect WEBKITOUTPUTDIR and expand the font dir from it.
2118         Use CString consistently.
2119
2120         * DumpRenderTree/efl/FontManagement.cpp:
2121         (buildPath):
2122         (getCoreFontFiles):
2123         (addFontDirectory):
2124         (addFontFiles):
2125         (getCustomBuildDir):
2126         (getPlatformFontsPath):
2127         (addFontsToEnvironment):
2128
2129 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
2130
2131         [WK2][WKTR] TestRunner needs to implement dumpApplicationCacheDelegateCallbacks
2132         https://bugs.webkit.org/show_bug.cgi?id=96374
2133
2134         Reviewed by Kenneth Rohde Christiansen.
2135
2136         Implement support for dumpApplicationCacheDelegateCallbacks
2137         and disallowIncreaseForApplicationCacheQuota in
2138         WebKitTestRunner and properly dump the information
2139         expected by the tests.
2140
2141         If the application cache quota is reached for a given
2142         security origin, WebKitTestRunner will reset the quota
2143         to its default value, unless intructed not to via
2144         disallowIncreaseForApplicationCacheQuota().
2145
2146         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2147         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2148         (WTR::InjectedBundlePage::InjectedBundlePage):
2149         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
2150         (WTR):
2151         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2152         (InjectedBundlePage):
2153         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2154         (WTR::TestRunner::TestRunner):
2155         (WTR::TestRunner::disallowIncreaseForApplicationCacheQuota):
2156         (WTR):
2157         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2158         (WTR::TestRunner::dumpApplicationCacheDelegateCallbacks):
2159         (TestRunner):
2160         (WTR::TestRunner::shouldDisallowIncreaseForApplicationCacheQuota):
2161         (WTR::TestRunner::shouldDumpApplicationCacheDelegateCallbacks):
2162
2163 2012-09-12  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2164
2165         [WK2] [WTR] WebKitTestRunner needs TestRunner.workerThreadCount
2166         https://bugs.webkit.org/show_bug.cgi?id=96388
2167
2168         Reviewed by Kenneth Rohde Christiansen.
2169
2170         Exported TestRunner.workerThreadCount as readonly attribute.
2171
2172         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2173         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Added workerThreadCount() method implementation.
2174         (WTR::TestRunner::workerThreadCount): Returns count of worker threads.
2175         (WTR):
2176         * WebKitTestRunner/InjectedBundle/TestRunner.h: Added workerThreadCount() method. 
2177         (TestRunner):
2178
2179 2012-09-12  Jochen Eisinger  <jochen@chromium.org>
2180
2181         [chromium] Consume a user gesture when creating a new view.
2182         https://bugs.webkit.org/show_bug.cgi?id=96373
2183
2184         Reviewed by Adam Barth.
2185
2186         * DumpRenderTree/chromium/WebViewHost.cpp:
2187         (WebViewHost::createView):
2188
2189 2012-09-12  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2190
2191         [WK2][WTR] Some of TestRunner special options are not reset before testing
2192         https://bugs.webkit.org/show_bug.cgi?id=96384
2193
2194         Reviewed by Kenneth Rohde Christiansen.
2195
2196         Now values of the following special options are reset:
2197         void setAcceptsEditing(in boolean value);
2198         void setCloseRemainingWindowsWhenComplete(in boolean value);
2199         void setXSSAuditorEnabled(in boolean value);
2200         void setAllowFileAccessFromFileURLs(in boolean value);
2201         void setPluginsEnabled(in boolean value);
2202         void setPopupBlockingEnabled(in boolean value);
2203
2204         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2205         (WTR::InjectedBundle::beginTesting):
2206
2207 2012-09-11  Ryuan Choi  <ryuan.choi@samsung.com>
2208
2209         [CMAKE] Supply feature defines to CodeGeneratorTestRunner.
2210         https://bugs.webkit.org/show_bug.cgi?id=96273
2211
2212         Reviewed by Gyuyoung Kim.
2213
2214         Passed FEATURE_DEFINES_WITH_SPACE_SEPARATOR to CodeGeneratorTestRunner
2215         in order to distinguish compile time options such as ENABLE(TOUCH_EVENTS).
2216
2217         * WebKitTestRunner/CMakeLists.txt:
2218
2219 2012-09-11  Dirk Pranke  <dpranke@chromium.org>
2220
2221         [chromium] rename webkit_resources
2222         https://bugs.webkit.org/show_bug.cgi?id=95874
2223
2224         Reviewed by James Robinson.
2225
2226         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2227
2228 2012-09-11  Jochen Eisinger  <jochen@chromium.org>
2229
2230         [chromium] don't include content shell builders in the garden-o-matic view
2231         https://bugs.webkit.org/show_bug.cgi?id=96418
2232
2233         Reviewed by James Robinson.
2234
2235         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2236
2237 2012-09-11  Adam Klein  <adamk@chromium.org>
2238
2239         Garden-o-matic should ignore a wider variety of warnings in buildbot json
2240         https://bugs.webkit.org/show_bug.cgi?id=96411
2241
2242         Reviewed by Adam Barth.
2243
2244         Previously only the exact string "warning" was treated as a warning
2245         result. This patch treats any string with "warning" as a substring
2246         as a warning (e.g., "warnings", as seen on the cr-win buildbots).
2247
2248         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
2249         (.):
2250         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
2251
2252 2012-09-11  Marcelo Lira  <marcelo.lira@openbossa.org>
2253
2254         Restore original value of mock scrollbars enabled in InternalSettings
2255         https://bugs.webkit.org/show_bug.cgi?id=87680
2256
2257         Reviewed by Adam Barth.
2258
2259         Added backup support for mock scrollbars state in
2260         InternalSettings::Backup, and removed support for these
2261         from Qt's DumpRenderTree.
2262
2263         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2264         (WebCore::WebPage::resetSettings):
2265         * DumpRenderTree/qt/TestRunnerQt.cpp:
2266         (TestRunner::setFrameFlatteningEnabled):
2267         * DumpRenderTree/qt/TestRunnerQt.h:
2268         (TestRunner):
2269
2270 2012-09-11  Dan Bernstein  <mitz@apple.com>
2271
2272         Fixed a bug where kill-old-processes failed to kill clang++.
2273
2274         Rubber-stamped by Alexey Proskuryakov.
2275
2276         * BuildSlaveSupport/kill-old-processes: Escape the + signs in "clang++"
2277         where it is passed as a regular expression to killall.
2278
2279 2012-09-11  Philippe Liard  <pliard@google.com>
2280
2281         Make sure that md5sum is not setup on non-Chromium Android platforms.
2282         https://bugs.webkit.org/show_bug.cgi?id=96393
2283
2284         Reviewed by Adam Barth.
2285
2286         Previously md5sum was setup in ChromiumAndroidDriver's constructor
2287         which is also invoked on non-Chromium Android platforms. The following patch
2288         moves this logic to _startup_test() which is guaranteed to be invoked
2289         only on Android.
2290
2291         This also updates the prompt unit test in chromium_android_unittest.py.
2292
2293         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2294         (ChromiumAndroidDriver.__init__):
2295         (ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
2296         (ChromiumAndroidDriver._setup_test):
2297
2298 2012-09-11  Raphael Kubo da Costa  <rakuco@webkit.org>
2299
2300         [EFL] Rewrite the EFL-related Find modules
2301         https://bugs.webkit.org/show_bug.cgi?id=95237
2302
2303         Reviewed by Kenneth Rohde Christiansen.
2304
2305         * DumpRenderTree/efl/CMakeLists.txt: Stop setting the LINK_FLAGS
2306         property and include all the Enlightenment Foundation Libraries
2307         required by the target.
2308         * EWebLauncher/CMakeLists.txt: Ditto.
2309         * MiniBrowser/efl/CMakeLists.txt: Ditto.
2310         * TestWebKitAPI/PlatformEfl.cmake: Add missing include directories
2311         now that they are not added implicitly.
2312         * WebKitTestRunner/CMakeLists.txt: Stop setting the LINK_FLAGS
2313         property.
2314         * WebKitTestRunner/PlatformEfl.cmake: Stop setting the LINK_FLAGS
2315         property and include all the Enlightenment Foundation Libraries
2316         required by the target.
2317
2318 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
2319
2320         [WK2][WKTR] TestRunner needs to implement setApplicationCacheOriginQuota
2321         https://bugs.webkit.org/show_bug.cgi?id=96379
2322
2323         Reviewed by Kenneth Rohde Christiansen.
2324
2325         Add implementation for setApplicationCacheOriginQuota
2326         to WebKitTestRunner.
2327
2328         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2329         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2330         (WTR::TestRunner::setApplicationCacheOriginQuota):
2331         (WTR):
2332         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2333         (TestRunner):
2334
2335 2012-09-11  Luciano Wolf  <luciano.wolf@openbossa.org>
2336
2337         [Qt] [WK2] editing/inserting/typing-tab-designmode tests are failing
2338         https://bugs.webkit.org/show_bug.cgi?id=91988
2339
2340         Reviewed by Kenneth Rohde Christiansen.
2341
2342         Regular key events generated by Qt for the tab key fill both
2343         keyCode and keyText, so we should do the same for our fake events.
2344
2345         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
2346         (WTR::EventSenderProxy::keyDown):
2347
2348 2012-09-11  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2349
2350         [WK2][WTR] WebKitTestRunner needs testRunner.setSpatialNavigationEnabled
2351         https://bugs.webkit.org/show_bug.cgi?id=96269
2352
2353         Reviewed by Kenneth Rohde Christiansen.
2354
2355         Exported missing testRunner.setSpatialNavigationEnabled() method.
2356
2357         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2358         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2359         (WTR::InjectedBundle::beginTesting):
2360         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2361         (WTR::TestRunner::setSpatialNavigationEnabled):
2362         (WTR):
2363         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2364         (TestRunner):
2365
2366 2012-09-11  Philippe Liard  <pliard@chromium.org>
2367
2368         Support LayoutTests on non-rooted devices for Chromium Android.
2369         https://bugs.webkit.org/show_bug.cgi?id=95346
2370
2371         Reviewed by Dirk Pranke.
2372
2373         We were requiring root permissions to sync resource files with the
2374         device by comparing host and device files' timestamp after we
2375         synchronized the device and host clocks.
2376         We now rely on md5sum provided by Chromium to handle data files
2377         synchronization.
2378
2379         * Scripts/webkitpy/layout_tests/port/chromium.py:
2380         (ChromiumPort._check_driver_build_up_to_date):
2381         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2382         (ChromiumAndroidDriver.__init__):
2383         (ChromiumAndroidDriver._setup_test):
2384         (ChromiumAndroidDriver._push_executable):
2385         (ChromiumAndroidDriver._push_test_resources):
2386         (ChromiumAndroidDriver._read_prompt):
2387
2388 2012-09-11  Simon Hausmann  <simon.hausmann@nokia.com>
2389
2390         [Qt] Fix output paths on Windows
2391
2392         Reviewed by Tor Arne Vestbø.
2393
2394         BUILD_ROOT_RELATIVE_TO_OUT_PWD was calculated incorrectly Windows, resulting in an incorrect
2395         DESTDIR transformation at the end of default_post.prf. The calculation should be baased no qmake
2396         paths, which can use drive letters but always use forward slashes. So the use of QMAKE_DIR_SEP is
2397         incorrect here and instead for the calculation we should use forward slashes.
2398
2399         * qmake/mkspecs/features/default_pre.prf:
2400
2401 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2402
2403         [Qt] Fix passing of defines from the build system
2404
2405         We explicitly have to pass -DENABLE_FOO=0 for every single feature
2406         that's not explicitly enabled in WEBKIT_CONFIG, since Platform.h
2407         will add it's own defaults if the features are not defined.
2408
2409         At some point we might want to run a configure-test to inspect what
2410         Platform.h will do, so we can sync up the build system's view of
2411         the feature-defines with the compile-time situation.
2412
2413         Reviewed by Simon Hausmann.
2414
2415         * qmake/mkspecs/features/functions.prf:
2416
2417 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2418
2419         [Qt] Fix --qt option to build-webkit
2420
2421         Reviewed by Ossy.
2422
2423         * Scripts/webkitdirs.pm:
2424         (buildQMakeProjects):
2425
2426 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2427
2428         [Qt] Add a configure step to the Qt build system
2429
2430         This allows building the Qt port using just 'qmake WebKit.pro'. Using
2431         the build-webkit script is still supported, and will add slightly more
2432         logic to the build, such as detecting the need for clean or incremental
2433         builds.
2434
2435         Internally, the build system now uses a new variable, WEBKIT_CONFIG, for
2436         all things related to configuring the build, such as use/have/enable flags,
2437         and these are translated to defines in default_post. Project files should
2438         no longer check contains(DEFINES,...) to detect features, but use the new
2439         enable?(), use?(), and have?() functions. The no_webkit1 and no_webkit2
2440         options have been translated into WEBKIT_CONFIG options as well, and can
2441         be checked using build?().
2442
2443         Reviewed by Simon Hausmann.
2444
2445         * DumpRenderTree/qt/DumpRenderTree.pro:
2446         * MiniBrowser/qt/MiniBrowser.pro:
2447         * QtTestBrowser/QtTestBrowser.pro:
2448         * Scripts/build-webkit:
2449         * Scripts/webkitdirs.pm:
2450         (qtFeatureDefaults):
2451         (buildQMakeProjects):
2452         * Tools.pro:
2453         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
2454         * WebKitTestRunner/InjectedBundle/Target.pri:
2455         * WebKitTestRunner/Target.pri:
2456         * qmake/.qmake.cache: Added.
2457         * qmake/configure.pri: Removed.
2458         * qmake/configure.pro: Removed.
2459         * qmake/dump-features: Added.
2460         * qmake/mkspecs/features/configure.prf: Added.
2461         * qmake/mkspecs/features/default_post.prf:
2462         * qmake/mkspecs/features/default_pre.prf:
2463         * qmake/mkspecs/features/features.prf:
2464         * qmake/mkspecs/features/features.pri:
2465         * qmake/mkspecs/features/functions.prf:
2466         * qmake/mkspecs/features/gprof.prf:
2467         * qmake/mkspecs/features/mac/default_pre.prf:
2468         * qmake/mkspecs/features/win32/default_pre.prf:
2469
2470 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
2471
2472         [WK2][WKTR] TestRunner needs to implement clearApplicationCacheForOrigin
2473         https://bugs.webkit.org/show_bug.cgi?id=96372
2474
2475         Reviewed by Kenneth Rohde Christiansen.
2476
2477         Implement clearApplicationCacheForOrigin() in WebKitTestRunner.
2478
2479         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2480         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2481         (WTR::TestRunner::clearApplicationCacheForOrigin):
2482         (WTR):
2483         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2484         (TestRunner):
2485
2486 2012-09-11  Peter Beverloo  <peter@chromium.org>
2487
2488         Don't ignore .pak files when making an archive for Android
2489         https://bugs.webkit.org/show_bug.cgi?id=96375
2490
2491         Reviewed by Jochen Eisinger.
2492
2493         The .pak files do need to be pushed to the device, which is currently
2494         preventing the layout test runner from correctly pushing all files.
2495
2496         * BuildSlaveSupport/built-product-archive:
2497         (archiveBuiltProduct):
2498
2499 2012-09-11  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2500
2501         [WK2][WTR] WebKitTestRunner needs layoutTestController.setMinimumTimerInterval
2502         https://bugs.webkit.org/show_bug.cgi?id=96256
2503
2504         Reviewed by Kenneth Rohde Christiansen.
2505
2506         Exported TestRunner::setMinimumTimerInterval() method.
2507
2508         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2509         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2510         (WTR::InjectedBundle::beginTesting):
2511         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2512         (WTR::TestRunner::setMinimumTimerInterval):
2513         (WTR):
2514         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2515         (TestRunner):
2516
2517 2012-09-11  Tommy Widenflycht  <tommyw@google.com>
2518
2519         MediaStream API: add RTCPeerConnection::onnegotiationneeded
2520         https://bugs.webkit.org/show_bug.cgi?id=96097
2521
2522         Reviewed by Adam Barth.
2523
2524         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2525         (MockWebRTCPeerConnectionHandler::addStream):
2526         (MockWebRTCPeerConnectionHandler::removeStream):
2527
2528 2012-09-11  Peter Beverloo  <peter@chromium.org>
2529
2530         Recognize the "--chromium-android" argument in run-webkit-tests
2531         https://bugs.webkit.org/show_bug.cgi?id=96369
2532
2533         Reviewed by Jochen Eisinger.
2534
2535         Chromium for the Android platform cannot determine the platform based on
2536         the host itself, so we'll use the --chromium-android argument as the build
2537         master passes to run-webkit-tests. Make sure the layout test runner
2538         can pick the right port when doing so.
2539
2540         * Scripts/run-webkit-tests:
2541         * Scripts/webkitpy/layout_tests/port/factory.py:
2542         (port_options):
2543
2544 2012-09-11  Simon Hausmann  <simon.hausmann@nokia.com>
2545
2546         [QT] Fix build with newer qmake from Qt 5
2547
2548         Rubber-stamped by Tor Arne Vestbø.
2549
2550         Support for "qmake -query QMAKE_MKSPECS" was removed from qmake. Replace
2551         it with the use of QT_HOST_DATA/mkspecs.
2552         Based on patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com>.
2553
2554         * Scripts/webkitdirs.pm:
2555         (builtDylibPathForName):
2556         (qtMakeCommand):
2557
2558 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2559
2560         [Qt] Remove Qt 4 syncqt, no longer needed
2561
2562         Reviewed by Simon Hausmann.
2563
2564         * qmake/syncqt-4.8: Removed.
2565
2566 2012-09-11  Andras Becsi  <andras.becsi@nokia.com>
2567
2568         [Qt][WK2] Fix the build with recent Qt5
2569         https://bugs.webkit.org/show_bug.cgi?id=96283
2570
2571         Reviewed by Simon Hausmann.
2572
2573         We should not use deprecated Qt API because doing that results
2574         in build failure since all the deprecated API was disabled
2575         in qtbase (https://codereview.qt-project.org/#change,24890).
2576
2577         * DumpRenderTree/qt/main.cpp:
2578         (main):
2579         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2580         (MiniBrowserApplication::notify):
2581         * MiniBrowser/qt/raw/View.cpp:
2582         (View::exposeEvent):
2583         (main):
2584
2585 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
2586
2587         WTR needs an implementation of applicationCacheDiskUsageForOrigin
2588         https://bugs.webkit.org/show_bug.cgi?id=87188
2589
2590         Reviewed by Kenneth Rohde Christiansen.
2591
2592         Add implementation for applicationCacheDiskUsageForOrigin()
2593         in WebKitTestRunner.
2594
2595         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2596         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2597         (WTR::TestRunner::applicationCacheDiskUsageForOrigin):
2598         (WTR):
2599         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2600         (TestRunner):
2601
2602 2012-09-10  Joanmarie Diggs  <jdiggs@igalia.com>
2603
2604         Properly expose <legend> elements to ATs
2605         https://bugs.webkit.org/show_bug.cgi?id=84137
2606
2607         Reviewed by Chris Fleizach.
2608
2609         Created a new WebCore Accessibility Role, LegendRole. Used it to map to
2610         the expected platform role, ATK_ROLE_LABEL. Also established the needed
2611         AtkRelation pair, label-for/labelled-by between the legend and fieldset.
2612
2613         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
2614         (roleToString): added "Legend" string for WebAccessibilityRoleLegend
2615
2616 2012-09-10  Jer Noble  <jer.noble@apple.com>
2617
2618         Unreviewed; rolling out r128081.
2619         http://trac.webkit.org/changeset/128081
2620         https://bugs.webkit.org/show_bug.cgi?id=96134
2621
2622         New test http/tests/media/video-donottrack.html fails to run on Apple test bots.
2623
2624         * DumpRenderTree/TestRunner.cpp:
2625         (TestRunner::TestRunner):
2626         (TestRunner::staticFunctions):
2627         * DumpRenderTree/TestRunner.h:
2628         (TestRunner):
2629         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2630         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2631         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2632         (WTR::InjectedBundlePage::InjectedBundlePage):
2633         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2634         (InjectedBundlePage):
2635         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2636         (WTR::TestRunner::TestRunner):
2637         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2638         (TestRunner):
2639
2640 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
2641
2642         TestExpectationsChecker._determine_port_from_expectations_path() does not support cascaded TestExpectations
2643         https://bugs.webkit.org/show_bug.cgi?id=96205
2644
2645         Reviewed by Tony Chang.
2646
2647         _determine_port_from_expectations_path() was calling port.path_to_test_expectations_file()
2648         internally, which means that it would support only 1 TestExpectations file per port. This
2649         is an issue for ports such as EFL that support cascased TestExpectations (efl-wk2 -> efl
2650         and efl-wk1 -> efl).
2651
2652         This patch makes _determine_port_from_expectations_path() call port.expectations_files()
2653         instead so that all the ports TestExpectations are recognized. The ports are also
2654         constructed twice, with "webkit_test_runner" option set to True and False so that we
2655         retrieve the TestExpectations paths for both WebKit1 and WebKit2.
2656
2657         * Scripts/webkitpy/style/checkers/test_expectations.py:
2658         (TestExpectationsChecker._determine_port_from_expectations_path):
2659         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Add corresponding unit test.
2660         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
2661
2662 2012-09-10  Ryuan Choi  <ryuan.choi@samsung.com>
2663
2664         [WTR] Generated source files should include config.h
2665         https://bugs.webkit.org/show_bug.cgi?id=96254
2666
2667         Reviewed by Benjamin Poulain.
2668
2669         Current coding style has encouraged to include config.h at the first position,
2670         But derived sources, generated by CodeGeneratorTestRunner.pm, don't follow
2671         this rule.
2672         Therefore, this patch added it.
2673
2674         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2675         (_generateImplementationFile):
2676
2677 2012-09-10  Rick Byers  <rbyers@chromium.org>
2678
2679         Add handling of new GestureTapCancel in DRT
2680         
2681         https://bugs.webkit.org/show_bug.cgi?id=96183
2682
2683         Reviewed by Adam Barth.
2684
2685         * DumpRenderTree/chromium/TestWebPlugin.cpp:
2686         (TestWebPlugin::handleInputEvent):
2687
2688 2012-09-10  Brady Eidson  <beidson@apple.com>
2689
2690         Javascript in foreground tabs should not wait synchronously for plug-ins to load
2691         <rdar://problem/12067415> and https://bugs.webkit.org/show_bug.cgi?id=96167
2692
2693         Reviewed by Geoff Garen.
2694
2695         Enhance the "Slow NPP_New" plug-in to also be able to return properties to javascript.
2696
2697         * DumpRenderTree/TestNetscapePlugIn/Tests/SlowNPPNew.cpp:
2698         (PluginObject):
2699         (SlowNPPNew::PluginObject::PluginObject):
2700         (SlowNPPNew::PluginObject::~PluginObject):
2701         (SlowNPPNew::PluginObject::hasProperty):
2702         (SlowNPPNew::PluginObject::getProperty):
2703         (SlowNPPNew::NPP_GetValue):
2704         (SlowNPPNew):
2705
2706 2012-09-10  Tim Horton  <timothy_horton@apple.com>
2707
2708         WKTR often reports an unresponsive WebProcess on Mac bots
2709         https://bugs.webkit.org/show_bug.cgi?id=95906
2710
2711         Reviewed by Dan Bernstein.
2712
2713         Attempt to work around resource contention issues by increasing the NRWT
2714         timeout when running against WKTR, as well as WKTR's own WebProcess timeout.
2715
2716         * Scripts/webkitpy/layout_tests/port/base.py:
2717         (Port.default_timeout_ms): Default timeout when using WKTR -> 80 seconds.
2718         * WebKitTestRunner/TestController.cpp:
2719         (WTR): LongTimeout (used when waiting for WebProcess to finish) -> 60 seconds.
2720
2721 2012-09-07  Jer Noble  <jer.noble@apple.com>
2722
2723         <audio> and <video> should send Do Not Track when appropriate
2724         https://bugs.webkit.org/show_bug.cgi?id=96134
2725
2726         Reviewed by Eric Carlson.
2727
2728         Add a testRunner JS API for calling setShouldSendDoNotTrackHTTPHeader to DRT and 
2729         WTR. Add FrameLoaderClient client methods for retrieving that value.
2730
2731         * DumpRenderTree/TestRunner.cpp:
2732         (setShouldSendDoNotTrackHTTPHeaderCallback): Pass through to the TestRunner.
2733         (TestRunner::staticFunctions): Add the setShouldSendDoNotTrackHTTPHeader function.
2734         * DumpRenderTree/TestRunner.h:
2735         (TestRunner::setShouldSendDoNotTrackHTTPHeader): Simple setter.
2736         (TestRunner::shouldSendDoNotTrackHTTPHeader): Simple getter.
2737         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2738         (-[FrameLoadDelegate webViewShouldSendDoNotTrackHTTPHeader:]): 
2739             Pass the question on to the TestRunner.
2740         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2741         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2742         (WTR::InjectedBundlePage::InjectedBundlePage):
2743             Add the setShouldSendDoNotTrackHTTPHeader client function.
2744         (WTR::InjectedBundlePage::shouldSendDoNotTrackHTTPHeader):
2745             Pass the question on to the TestRunner.
2746         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2747         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2748         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2749         (WTR::TestRunner::shouldSendDoNotTrackHTTPHeader): Simple getter.
2750         (WTR::TestRunner::setShouldSendDoNotTrackHTTPHeader): Simple Setter.
2751
2752 2012-09-10  Ojan Vafai  <ojan@chromium.org>
2753
2754         Make EFL bots work on the flakiness dashboard
2755         https://bugs.webkit.org/show_bug.cgi?id=96164
2756
2757         Reviewed by Tony Chang.
2758
2759         Also, update outdated unittests that had started failing.
2760
2761         * TestResultServer/static-dashboards/builders.js:
2762         (isWebkitTestRunner):
2763         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2764         (nonChromiumPlatform):
2765         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2766         (test):
2767
2768 2012-09-10  Tommy Widenflycht  <tommyw@google.com>
2769
2770         [chromium] MediaStream API: Remove the Descriptor postfix
2771         https://bugs.webkit.org/show_bug.cgi?id=96268
2772
2773         Reviewed by Adam Barth.
2774
2775         After consideration I realized that there is no need whatsoever in using the Descriptor prefix
2776         in the WekKit embedder API. Removed from WebRTCSessionDescription and WebRTCICECandidate to start with.
2777
2778         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2779         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
2780         (MockWebRTCPeerConnectionHandler::createOffer):
2781         (MockWebRTCPeerConnectionHandler::createAnswer):
2782         (MockWebRTCPeerConnectionHandler::setLocalDescription):
2783         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
2784         (MockWebRTCPeerConnectionHandler::localDescription):
2785         (MockWebRTCPeerConnectionHandler::remoteDescription):
2786         (MockWebRTCPeerConnectionHandler::addICECandidate):
2787         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2788         (MockWebRTCPeerConnectionHandler):
2789
2790 2012-09-10  Arnaud Renevier  <a.renevier@sisa.samsung.com>
2791
2792         [Gtk] failure to build jhbuild dependencies with cups 1.6
2793         https://bugs.webkit.org/show_bug.cgi?id=95991
2794
2795         Reviewed by Gustavo Noronha Silva.
2796
2797         Bump gtk+ and gnome-themes-standard dependencies to 3.4.2 to allow
2798         building with cups >= 1.6 [GNOME #670373].
2799
2800         * gtk/jhbuild.modules:
2801
2802 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
2803
2804         [EFL][DRT] Encoding issue in printed console messages
2805         https://bugs.webkit.org/show_bug.cgi?id=96263
2806
2807         Reviewed by Kenneth Rohde Christiansen.
2808
2809         Correctly handle CONSOLE messages that contain non-ascii
2810         characters in EFL's DRT. We need to use String::fromUTF8()
2811         to construct a WTF::String from a raw string.
2812
2813         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
2814         (onConsoleMessage):
2815
2816 2012-09-10  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2817
2818         [WK2][WTR] User style sheet location should be reset before each test
2819         https://bugs.webkit.org/show_bug.cgi?id=96262
2820
2821         Reviewed by Kenneth Rohde Christiansen.
2822
2823         User style sheet location is reset before each test now.
2824
2825         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2826         (WTR::InjectedBundle::beginTesting):
2827
2828 2012-09-10  Simon Hausmann  <simon.hausmann@nokia.com>
2829
2830         Fix build of WTR with Qt on Windows
2831         https://bugs.webkit.org/show_bug.cgi?id=96249
2832
2833         Reviewed by Kenneth Rohde Christiansen.
2834
2835         Windows loves to define min and max as macros, which beautifully
2836         clashes in many places where min and max are used as variable or method
2837         names. It can be convinced not to do this when min and max are already
2838         define as macros (expanding to themselves). We have this kind of
2839         workaround in config.h files all over WebKit and as it turns out when
2840         building WTR with Qt on Windows we do end up with such a clash. Therefore
2841         we need the same workaround.
2842
2843         * WebKitTestRunner/config.h:
2844
2845 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
2846
2847         [WK2] New fast/forms/number/number-interactive-validation-required.html fails
2848         https://bugs.webkit.org/show_bug.cgi?id=95936
2849
2850         Reviewed by Kenneth Rohde Christiansen.
2851
2852         Enable interactive form validation setting in WebKitTestRunner as
2853         we are currently doing in DumpRenderTree. This is needed for some
2854         tests to pass.
2855
2856         * WebKitTestRunner/TestController.cpp:
2857         (WTR::TestController::resetStateToConsistentValues):
2858
2859 2012-09-09  Zan Dobersek  <zandobersek@gmail.com>
2860
2861         Clean up the code in XvfbDriver
2862         https://bugs.webkit.org/show_bug.cgi?id=96202
2863
2864         Reviewed by Philippe Normand.
2865
2866         Changes:
2867         - Remove unneeded imports,
2868         - assign the _lock_file member variable when the display number is determined,
2869         - no need for parentheses around a single string format argument,
2870         - use FileSystem.exists method when checking if lock file is present as it
2871         makes the intention much more clearer.
2872
2873         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
2874         (XvfbDriver._start):
2875         (XvfbDriver.stop):
2876
2877 2012-09-09  Patrick Gansterer  <paroga@webkit.org>
2878
2879         Make the String initialization on the function side of String::number()
2880         https://bugs.webkit.org/show_bug.cgi?id=95940
2881
2882         Reviewed by Benjamin Poulain.
2883
2884         * TestWebKitAPI/Tests/WTF/IntegerToStringConversion.cpp:
2885         (testBoundaries):
2886         (testNumbers):
2887
2888 2012-09-09  Pierre Rossi  <pierre.rossi@gmail.com>
2889
2890         [WK2] expose element rect for color input type
2891         https://bugs.webkit.org/show_bug.cgi?id=91664
2892
2893         Reviewed by Simon Hausmann.
2894
2895         Update the QML logic in MiniBrowser to take advantage of this.
2896         The picker size is now hardcoded and we try to place it below the
2897         input element if possible.
2898
2899         * MiniBrowser/qt/qml/ColorChooser.qml:
2900
2901 2012-09-08  Christophe Dumez  <christophe.dumez@intel.com>
2902
2903         [WK2] New fast/events/tab-focus-link-in-canvas fails from r126908
2904         https://bugs.webkit.org/show_bug.cgi?id=95329
2905
2906         Reviewed by Kenneth Rohde Christiansen.
2907
2908         Explicitely disable TabToLinks setting in WebKitTestRunner.
2909         Tests override the "WebKitTabToLinksPreferenceKey" preference
2910         to enable it.
2911
2912         * WebKitTestRunner/TestController.cpp:
2913         (WTR::TestController::resetStateToConsistentValues):
2914
2915 2012-09-08  Kenichi Ishibashi  <bashi@chromium.org>
2916
2917         webkit.py gdb pretty printer can't print CString
2918         https://bugs.webkit.org/show_bug.cgi?id=96068
2919
2920         Reviewed by Tony Chang.
2921
2922         Update WTFCStringPrinter to follow r126191.
2923
2924         * gdb/webkit.py:
2925         (WTFCStringPrinter.to_string):
2926
2927 2012-09-07  Benjamin Poulain  <bpoulain@apple.com>
2928
2929         Rename the ustring() accessor to string()
2930         https://bugs.webkit.org/show_bug.cgi?id=95919
2931
2932         Reviewed by Geoffrey Garen.
2933
2934         Update EFL's DRT.
2935
2936         Fix some string conversion that have been made useless
2937         with recent changes.
2938
2939         * DumpRenderTree/efl/EventSender.cpp:
2940         (keyPadNameFromJSValue):
2941         (keyNameFromJSValue):
2942         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2943         (TestRunner::queueLoad):
2944         (TestRunner::addOriginAccessWhitelistEntry):
2945         (TestRunner::removeOriginAccessWhitelistEntry):
2946         (TestRunner::setUserStyleSheetLocation):
2947         (TestRunner::setValueForUser):
2948         (TestRunner::elementDoesAutoCompleteForElementWithId):
2949         (TestRunner::execCommand):
2950         (TestRunner::findString):
2951         (TestRunner::isCommandEnabled):
2952         (TestRunner::clearApplicationCacheForOrigin):
2953         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
2954         (TestRunner::pauseAnimationAtTimeOnElementWithId):
2955         (TestRunner::pauseTransitionAtTimeOnElementWithId):
2956         (toInt):
2957         (TestRunner::overridePreference):
2958         (TestRunner::addUserScript):
2959         (TestRunner::addUserStyleSheet):
2960         (TestRunner::evaluateInWebInspector):
2961         (TestRunner::evaluateScriptInIsolatedWorld):
2962         (TestRunner::setTextDirection):
2963         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
2964         (LoadItem::invoke):
2965         (LoadHTMLStringItem::invoke):
2966         (ScriptItem::invoke):
2967
2968 2012-09-06  Jeffrey Pfau  <jpfau@apple.com>
2969
2970         Extend third-party storage blocking API to optionally allow blocking all storage
2971         https://bugs.webkit.org/show_bug.cgi?id=95915
2972
2973         Reviewed by Brady Eidson.
2974
2975         Modified API test to use new revised API.
2976
2977         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2978         (TestWebKitAPI::TEST):
2979
2980 2012-09-07  Dominic Mazzoni  <dmazzoni@google.com>
2981
2982         AX: WebCore accessibility roles should be cross-platform
2983         https://bugs.webkit.org/show_bug.cgi?id=94870
2984
2985         Reviewed by Chris Fleizach.
2986
2987         Add debug strings to Chromium for new accessibility roles.
2988
2989         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
2990         (roleToString):
2991
2992 2012-09-07  Dominic Mazzoni  <dmazzoni@google.com>
2993
2994         AX: Chromium needs access to canvasHasFallbackContent
2995         https://bugs.webkit.org/show_bug.cgi?id=96124
2996
2997         Reviewed by Chris Fleizach.
2998
2999         Distinguish between canvas roles with and without fallback
3000         content on Chromium.
3001
3002         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
3003         (getRole):
3004
3005 2012-09-07  Ojan Vafai  <ojan@chromium.org>
3006
3007         Handle non-existant TestExpectations files gracefully
3008         https://bugs.webkit.org/show_bug.cgi?id=96149
3009
3010         Reviewed by Eric Seidel.
3011
3012         Even when we get rid of Skipped files, we shouldn't have each port
3013         require a TestExpectations file for each platform if it doesn't
3014         need one.
3015
3016         * Scripts/webkitpy/layout_tests/port/base.py:
3017         (Port.expectations_dict):
3018         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3019         (PortTest.test_nonexistant_expectations):
3020
3021 2012-09-07  Tony Chang  <tony@chromium.org>
3022
3023         Regression: check-webkit-style no longer checks TestExpectations for syntax errors
3024         https://bugs.webkit.org/show_bug.cgi?id=96136
3025
3026         Reviewed by Ojan Vafai.
3027
3028         When we renamed the file to TestExpectations, it was no longer considered a text file so
3029         it was no longer being checked. Since then, test_expectations_overrides() has been removed
3030         from the port object, so I've removed that from the check. I'm not sure what it was
3031         supposed to do.
3032
3033         * Scripts/webkitpy/style/checker.py:
3034         (CheckerDispatcher._file_type): Mark TestExpectations as a text file.
3035         * Scripts/webkitpy/style/checkers/test_expectations.py:
3036         (TestExpectationsChecker.check_test_expectations): Remove overrides param.
3037         (TestExpectationsChecker.check): Remove overrides param.
3038         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3039         (TestExpectationsTestCase.assert_lines_lint): Remove overrides param.
3040
3041 2012-09-07  Christophe Dumez  <christophe.dumez@intel.com>
3042
3043         [EFL] Use same default minimum logical font size in DRT and WTR
3044         https://bugs.webkit.org/show_bug.cgi?id=96116
3045
3046         Reviewed by Martin Robinson.
3047
3048         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3049         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Set minimum
3050         logical font size to 9 to match the value used in WTR.
3051         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3052         (WTR::InjectedBundle::beginTesting): Explicitly set the minimum
3053         logical font size to 9 (default value in WK2)
3054
3055 2012-09-07  Tommy Widenflycht  <tommyw@google.com>
3056
3057         MediaStream API: add RTCPeerConnection::createAnswer
3058         https://bugs.webkit.org/show_bug.cgi?id=96092
3059
3060         Reviewed by Adam Barth.
3061
3062         Expanding and enhancing MockWebRTCPeerConnectionHandler.
3063
3064         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3065         (MockWebRTCPeerConnectionHandler::createOffer):
3066         (MockWebRTCPeerConnectionHandler::createAnswer):
3067         (MockWebRTCPeerConnectionHandler::setLocalDescription):
3068         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
3069         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3070         (MockWebRTCPeerConnectionHandler):
3071
3072 2012-09-07  Dean Jackson  <dino@apple.com>
3073
3074         Unreviewed changes to watchlist.
3075
3076         - Add new WebGL and Filters definitions
3077         - Add myself to OpenGL bugs
3078
3079         * Scripts/webkitpy/common/config/watchlist:
3080
3081 2012-09-07  Peter Beverloo  <peter@chromium.org>
3082
3083         Actually trigger the Android Tester
3084         https://bugs.webkit.org/show_bug.cgi?id=96118
3085
3086         Reviewed by Adam Barth.
3087
3088         * BuildSlaveSupport/build.webkit.org-config/config.json:
3089
3090 2012-09-07  Dominic Mazzoni <dmazzoni@google.com>
3091
3092         New time input needs accessibility
3093         https://bugs.webkit.org/show_bug.cgi?id=96032
3094
3095         Reviewed by Chris Fleizach.
3096
3097         Add support for valueDescription for testing.
3098
3099         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
3100         (getValueDescription):
3101         (AccessibilityUIElement::AccessibilityUIElement):
3102         (AccessibilityUIElement::valueDescriptionGetterCallback):
3103         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h:
3104         (AccessibilityUIElement):
3105
3106 2012-09-07  Peter Beverloo  <peter@chromium.org>
3107
3108         Add the google-android-tests build slave to the master's config
3109         https://bugs.webkit.org/show_bug.cgi?id=96113
3110
3111         Reviewed by Csaba Osztrogonác.
3112
3113         * BuildSlaveSupport/build.webkit.org-config/config.json:
3114
3115 2012-09-07  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
3116
3117         [WK2] [EFL] Set theme for WebKit2 API test runner
3118         https://bugs.webkit.org/show_bug.cgi?id=96100
3119
3120         Reviewed by Kenneth Rohde Christiansen.
3121
3122         Set the theme generated by the build for the WebKit2 API test runner.
3123
3124         * TestWebKitAPI/PlatformEfl.cmake:
3125         * TestWebKitAPI/efl/PlatformWebView.cpp:
3126         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3127
3128 2012-09-07  Csaba Osztrogonác  <ossy@webkit.org>
3129
3130         Unreviewed. Add Gábor Ballabás as contributor.
3131
3132         * Scripts/webkitpy/common/config/committers.py:
3133
3134 2012-09-07  Zoltan Arvai  <zarvai@inf.u-szeged.hu>
3135
3136         [Qt] Fix ROOT_BUILD_DIR on Windows MSVC build.
3137         https://bugs.webkit.org/show_bug.cgi?id=96078
3138
3139         Reviewed by Tor Arne Vestbø.
3140
3141         Correct JSC, DumpRenderTree, ImageDiff, QtTestBrowser binaries location by adding $$toSystemPath to ROOT_BUILD_DIR generation.
3142
3143         * qmake/mkspecs/features/default_pre.prf:
3144
3145 2012-09-07  Christophe Dumez  <christophe.dumez@intel.com>
3146
3147         [EFL] Add TestExpectations file for efl-wk1
3148         https://bugs.webkit.org/show_bug.cgi?id=96019
3149
3150         Reviewed by Gyuyoung Kim.
3151
3152         Update TestExpectations cascading for EFL port
3153         so that we use efl-wk1 -> efl search paths
3154         for WebKit1 EFL.
3155
3156         * Scripts/webkitpy/layout_tests/port/efl.py:
3157         (EflPort._search_paths):
3158
3159 2012-09-07  Zan Dobersek  <zandobersek@gmail.com>
3160
3161         [NRWT] XvfbDriver should stop the Xvfb more aggressively
3162         https://bugs.webkit.org/show_bug.cgi?id=95097
3163
3164         Reviewed by Dirk Pranke.
3165
3166         The Xvfb process is now killed when the XvfbDriver is stopping. Simply
3167         terminating the process does not always work as expected, leading to timeouts
3168         in run-webkit-tests on the buildbot. The lock file Xvfb creates is also removed
3169         as it's not removed by the killed Xvfb process.
3170
3171         Also included is a thorough unittest for XvfbDriver. Proper starting of the driver
3172         is tested in different circumstances - whether pixel tests are enabled or not,
3173         with an arbitrary worker number or with an Xorg process already running on the system.
3174         The stopping of the driver is tested by checking that the Xvfb process is truly killed
3175         and then set to None.
3176
3177         * BuildSlaveSupport/kill-old-processes:
3178         Kill any stale Xvfb processes at the start of the build cycle so no Xvfb
3179         is left running, potentially clogging up a display at a certain position.
3180         * Scripts/webkitpy/common/system/executive_mock.py:
3181         (MockExecutive.__init__):
3182         The _running_pids is now a dictionary with process names as keys and pids
3183         as values.
3184         (MockExecutive.check_running_pid):
3185         Check whether the passed-in pid is in the _running_pids dictionary's values.
3186         (MockExecutive):
3187         (MockExecutive.running_pids):
3188         This method returns the list of all the process pids of which the name passes
3189         through the process_name_filter.
3190         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
3191         Use the Executive object of the port's host to check for running pids and open
3192         new subprocesses or kill them throughout the class.
3193         (XvfbDriver._start):
3194         Use the _server_process_constructor to make testing the XvfbDriver possible. Also,
3195         start the server process after it's created.
3196         (XvfbDriver.stop):
3197         Now kills the Xvfb process instead of terminating it and waiting for it to close.
3198         * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py: Added.
3199         (XvfbDriverTest):
3200         (XvfbDriverTest.make_driver):
3201         (XvfbDriverTest.assertDriverStartSuccessful):
3202         (XvfbDriverTest.test_start_no_pixel_tests):
3203         (XvfbDriverTest.test_start_pixel_tests):
3204         (XvfbDriverTest.test_start_arbitrary_worker_number):
3205         (XvfbDriverTest.test_start_existing_xorg_process):
3206         (XvfbDriverTest.test_stop):
3207         (XvfbDriverTest.test_stop.FakeXvfbProcess):
3208
3209 2012-09-06  Peter Beverloo  <peter@chromium.org>
3210
3211         Introduce the Chromium Android Release (Tests) bot
3212         https://bugs.webkit.org/show_bug.cgi?id=95980
3213
3214         Reviewed by Adam Barth.
3215
3216         This adds the Chromium Android Release (Tests) bot to the WebKit waterfall,
3217         which will be running layout tests on actual Android devices. Right now,
3218         four Galaxy Nexus phones are attached.
3219
3220         * BuildSlaveSupport/build.webkit.org-config/config.json:
3221
3222 2012-09-06  James Robinson  <jamesr@chromium.org>
3223
3224         [chromium] Use WebCompositorSupport functions instead of WebCompositor statics
3225         https://bugs.webkit.org/show_bug.cgi?id=96007
3226
3227         Reviewed by Adrienne Walker.
3228
3229         Fixes initialization / settings code to use WebCompositorSupport.
3230
3231         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3232         (main):
3233         * DumpRenderTree/chromium/TestShell.cpp:
3234         (TestShell::initialize):
3235         (TestShell::setPerTilePaintingEnabled):
3236
3237 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
3238
3239         [EFL][WK2] Provide implementation for PlatformWebView::windowFrame()
3240         https://bugs.webkit.org/show_bug.cgi?id=95995
3241
3242         Reviewed by Kenneth Rohde Christiansen.
3243
3244         Provide proper implementation for PlatformWebView::windowFrame()
3245         in EFL's WebKitTestRunner.
3246
3247         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3248         (WTR::PlatformWebView::windowFrame):
3249
3250 2012-09-06  Fady Samuel  <fsamuel@chromium.org>
3251
3252         Fix WTF.Lrint on 32-bit platforms
3253         https://bugs.webkit.org/show_bug.cgi?id=96003
3254
3255         Reviewed by Benjamin Poulain.
3256
3257         Fixed failing WTF.Lrint test on 32-bit platforms.
3258
3259         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
3260         (TestWebKitAPI::TEST):
3261
3262 2012-09-06  Tommy Widenflycht  <tommyw@google.com>
3263
3264         MediaStream API: Add the local and remote description functionality to RTCPeerConnection
3265         https://bugs.webkit.org/show_bug.cgi?id=95839
3266
3267         Reviewed by Adam Barth.
3268
3269         In addition to adding the new methods to MockWebRTCPeerConnectionHandler I cleaned
3270         up the task definitions a bit. There was no need to have them in the header file.
3271
3272         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3273         (RTCSessionDescriptionRequestSuccededTask):
3274         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
3275         (RTCSessionDescriptionRequestFailedTask):
3276         (RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
3277         (RTCVoidRequestTask):
3278         (RTCVoidRequestTask::RTCVoidRequestTask):
3279         (MockWebRTCPeerConnectionHandler::createOffer):
3280         (MockWebRTCPeerConnectionHandler::setLocalDescription):
3281         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
3282         (MockWebRTCPeerConnectionHandler::localDescription):
3283         (MockWebRTCPeerConnectionHandler::remoteDescription):
3284         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3285         (MockWebRTCPeerConnectionHandler):
3286
3287 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
3288
3289         [Qt] Fix build on Mac OS X 10.6
3290         https://bugs.webkit.org/show_bug.cgi?id=95200
3291
3292         Reviewed by Tor Arne Vestbø.
3293
3294         The build on Mac OS X 10.6 is broken when using QuickTime. Enable it only for
3295         10.7 and newer.
3296
3297         * qmake/mkspecs/features/features.prf:
3298
3299 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
3300
3301         [WKTR] addSelectionKey should be mapped to "Control" modifiers on other OSes than Mac
3302         https://bugs.webkit.org/show_bug.cgi?id=95973
3303
3304         Reviewed by Kenneth Rohde Christiansen.
3305
3306         Correctly map "addSelectionKey" to "Control" modifier
3307         in WKTR's EventSender on other OSes than Mac OS X,
3308         instead of mapping it to the "Meta" modifier.
3309
3310         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3311         (WTR::parseModifier):
3312
3313 2012-09-06  Balazs Kelemen  <kbalazs@webkit.org>
3314
3315         [nrwt] Harden against empty stdout/stderr after stopping a crashed/timed out driver
3316         https://bugs.webkit.org/show_bug.cgi?id=95710
3317
3318         Reviewed by Dirk Pranke.
3319
3320         The stdout / stderr output can be None so make sure
3321         we won't raise an exception in this case.
3322
3323         * Scripts/webkitpy/layout_tests/port/driver.py:
3324         (Driver.run_test):
3325
3326 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
3327
3328         [EFL] Sanitize URLs in EWebLauncher / Minibrowser
3329         https://bugs.webkit.org/show_bug.cgi?id=95849
3330
3331         Reviewed by Kenneth Rohde Christiansen.
3332
3333         Sanitize URLs passed by the user as program
3334         argument or typed in the URL bar in order to
3335         be more tolerant.
3336
3337         * EWebLauncher/CMakeLists.txt:
3338         * EWebLauncher/main.c:
3339         (main):
3340         * EWebLauncher/url_bar.c:
3341         (_url_bar_url_get_with_protocol):
3342         (on_urlbar_key_down):
3343         * EWebLauncher/url_utils.c: Added.
3344         (has_scheme):
3345         (url_from_user_input): Add utility function to construct a
3346         URL from user input.
3347         * EWebLauncher/url_utils.h: Added.
3348         * MiniBrowser/efl/CMakeLists.txt:
3349         * MiniBrowser/efl/main.c:
3350         (main):
3351
3352 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
3353
3354         [Qt] Various small Windows / MSVC build fixes
3355         https://bugs.webkit.org/show_bug.cgi?id=95934
3356
3357         Reviewed by Kenneth Rohde Christiansen.
3358
3359         setFocus takes a boolean as argument: Don't try to implicitly convert
3360         an enum to a boolean, MSVC doesn't like that. The intent here is to
3361         enable focus, so just pass true.
3362
3363         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3364         (WTR::PlatformWebView::focus):
3365
3366 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
3367
3368         [Qt] Fix build with ANGLE on platforms that provide EGL/GLESv2
3369         https://bugs.webkit.org/show_bug.cgi?id=95965
3370
3371         Reviewed by Tor Arne Vestbø.
3372
3373         Add ANGLE as a static library module to the Qt WebKit build system.
3374
3375         * qmake/mkspecs/features/default_post.prf:
3376         * qmake/mkspecs/modules/angle.prf: Added.
3377
3378 2012-09-06  Andras Becsi  <andras.becsi@nokia.com>
3379
3380         [WK2] Make [Qt]ViewportHandler cross platform
3381         https://bugs.webkit.org/show_bug.cgi?id=91257
3382
3383         Reviewed by Kenneth Rohde Christiansen.
3384
3385         Remove initial scale from viewport info item since it is
3386         set to -1 after applied thus it does not hold any valuable
3387         information.
3388
3389         * MiniBrowser/qt/qml/ViewportInfoItem.qml:
3390
3391 2012-09-05  Tony Chang  <tony@chromium.org>
3392
3393         [chromium] Remove dependency on webkit_user_agent
3394         https://bugs.webkit.org/show_bug.cgi?id=95886
3395
3396         Reviewed by Adam Barth.
3397
3398         The code isn't used by DumpRenderTree.
3399
3400         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3401
3402 2012-09-05  Rick Byers  <rbyers@chromium.org>
3403
3404         Update chromium DumpRenderTree for new WebGestureEvent fields
3405         https://bugs.webkit.org/show_bug.cgi?id=95573
3406
3407         Reviewed by James Robinson.
3408
3409         Update EventSender to write gesture details into the appropriate
3410         type-specific WebGestureEvent fields.
3411         * DumpRenderTree/chromium/TestRunner/EventSender.cpp:
3412         (EventSender::gestureEvent):
3413         (EventSender::gestureFlingStart):
3414
3415 2012-09-05  Dirk Pranke  <dpranke@chromium.org>
3416
3417         NRWT lies about the number of tests that it's skipping when used with --repeat-each
3418         https://bugs.webkit.org/show_bug.cgi?id=95789
3419
3420         Reviewed by Ojan Vafai.
3421
3422         Fix miscalculation in log message.
3423
3424         * Scripts/webkitpy/layout_tests/views/printing.py:
3425         (Printer.print_found):
3426
3427 2012-09-05  Kenichi Ishibashi  <bashi@chromium.org>
3428
3429         Unreviewed, rolling out r127612, r127660, and r127664.
3430         http://trac.webkit.org/changeset/127612
3431         http://trac.webkit.org/changeset/127660
3432         http://trac.webkit.org/changeset/127664
3433         https://bugs.webkit.org/show_bug.cgi?id=95920
3434
3435         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3436         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::SuccessCallbackTask):
3437         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::runIfValid):
3438         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::FailureCallbackTask):
3439         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::runIfValid):
3440         (MockWebRTCPeerConnectionHandler::createOffer):
3441         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3442         (MockWebRTCPeerConnectionHandler):
3443         (SuccessCallbackTask):
3444         (FailureCallbackTask):
3445
3446 2012-09-05  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
3447
3448         Ignore-metrics includes scroll offsets.
3449         https://bugs.webkit.org/show_bug.cgi?id=95845
3450
3451         Reviewed by Dirk Pranke.
3452
3453         Strip scroll-offsets the same way scroll-height and scroll-width is stripped.
3454
3455         * Scripts/old-run-webkit-tests:
3456         (stripMetrics):
3457         * Scripts/webkitpy/layout_tests/port/driver.py:
3458         (DriverOutput):
3459
3460 2012-09-05  Zan Dobersek  <zandobersek@gmail.com>
3461
3462         Unreviewed test fix.
3463
3464         Including a plugin source file into the build that was added in r127595.
3465
3466         * GNUmakefile.am:
3467
3468 2012-09-05  Tommy Widenflycht  <tommyw@google.com>
3469
3470         MediaStream API: Add the local and remote description functionality to RTCPeerConnection
3471         https://bugs.webkit.org/show_bug.cgi?id=95839
3472
3473         Reviewed by Adam Barth.
3474
3475         In addition to adding the new methods to MockWebRTCPeerConnectionHandler I cleaned
3476         up the task definitions a bit. There was no need to have them in the header file.
3477
3478         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3479         (RTCSessionDescriptionRequestSuccededTask):
3480         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
3481         (RTCSessionDescriptionRequestFailedTask):
3482         (RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
3483         (RTCVoidRequestTask):
3484         (RTCVoidRequestTask::RTCVoidRequestTask):
3485         (MockWebRTCPeerConnectionHandler::createOffer):
3486         (MockWebRTCPeerConnectionHandler::setLocalDescription):
3487         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
3488         (MockWebRTCPeerConnectionHandler::localDescription):
3489         (MockWebRTCPeerConnectionHandler::remoteDescription):
3490         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3491         (MockWebRTCPeerConnectionHandler):
3492
3493 2012-09-05  Kangil Han  <kangil.han@samsung.com>
3494
3495         [EFL] Remove '+=' usage in String
3496         https://bugs.webkit.org/show_bug.cgi?id=95808
3497
3498         Reviewed by Benjamin Poulain.
3499
3500         Replaced use of String operator '+=' with StringBuilder.append*() in order to adopt efficient String concatenation.
3501
3502         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3503         (descriptionSuitableForTestResult):
3504
3505 2012-09-05  Christophe Dumez  <christophe.dumez@intel.com>
3506
3507         [EFL][WK2] Provide implementation for TestRunner::pathToLocalResource()
3508         https://bugs.webkit.org/show_bug.cgi?id=95842
3509
3510         Reviewed by Kenneth Rohde Christiansen.
3511
3512         Provide proper implementation for TestRunner::pathToLocalResource()
3513         in EFL WKTR, identical to the one for DumpRenderTree.
3514
3515         Map /tmp to ${DUMPRENDERTREE_TEMP} environment variable and
3516         /tmp/LayoutTests to ${LOCAL_RESOURCE_ROOT} so that local resources
3517         are found my WebKitTestRunner.
3518
3519         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
3520         (WTR::TestRunner::pathToLocalResource):
3521
3522 2012-09-05  Brady Eidson  <beidson@apple.com>
3523
3524         Frequent crashes in PluginView::scriptObject under runtimeObjectCustomGetOwnPropertySlot
3525         <rdar://problem/12142226> and https://bugs.webkit.org/show_bug.cgi?id=95026
3526
3527         Reviewed by Andy Estes.
3528
3529         Add a plug-in that always fails to initialize:
3530         * DumpRenderTree/TestNetscapePlugIn/Tests/NPPNewFails.cpp: Added.
3531         (NPPNewFails):
3532         (NPPNewFails::NPPNewFails):
3533         (NPPNewFails::NPP_New):
3534
3535         Add it to all the project files:
3536         * DumpRenderTree/DumpRenderTree.gypi:
3537         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3538         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
3539         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3540         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3541
3542 2012-09-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3543
3544         [Qt] Fix makefile race condition between derived sources and target
3545
3546         r121966 removed too much of the old qmake logic, including the rule
3547         that ensured that qmake_all would not trigger dual runs of qmake --
3548         one of the derived sources -qmake-all rule, and one for making the
3549         derived sources.
3550
3551         We now follow a similar pattern as before, by introducing a custom
3552         target that explicitly depends on the derived sources' qmake-all before
3553         doing a manual run of make. That ensures a single qmake run for the derived
3554         sources.
3555
3556         https://bugs.webkit.org/show_bug.cgi?id=93847
3557
3558         Reviewed by Csaba Osztrogonác.
3559
3560         * qmake/mkspecs/features/functions.prf:
3561
3562 2012-09-05  Christophe Dumez  <christophe.dumez@intel.com>
3563
3564         WKTR doesn't implement dumpWillCacheResponse()
3565         https://bugs.webkit.org/show_bug.cgi?id=94607
3566
3567         Reviewed by Kenneth Rohde Christiansen.
3568
3569         Define shouldCacheResponse() callback in resource
3570         load client and provide implementation for
3571         dumpWillCacheResponse() in WebKitTestRunner.
3572
3573         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3574         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3575         (WTR::InjectedBundlePage::InjectedBundlePage):
3576         (WTR::InjectedBundlePage::shouldCacheResponse):
3577         (WTR):
3578         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3579         (InjectedBundlePage):
3580         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3581         (WTR::TestRunner::TestRunner):
3582         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3583         (WTR::TestRunner::dumpWillCacheResponse):
3584         (WTR::TestRunner::shouldDumpWillCacheResponse):
3585         (TestRunner):
3586
3587 2012-09-05  Kaustubh Atrawalkar  <kaustubh@motorola.com>
3588
3589         [DRT] LTC:: Move printing related APIs from LayoutTestController to Internals
3590         https://bugs.webkit.org/show_bug.cgi?id=92735
3591
3592         Reviewed by Hajime Morita.
3593
3594         Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
3595
3596         * DumpRenderTree/TestRunner.cpp:
3597         (TestRunner::staticFunctions):
3598         * DumpRenderTree/TestRunner.h:
3599         (TestRunner):
3600         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
3601         (TestRunner::addUserStyleSheet):
3602         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3603         (DRTTestRunner::DRTTestRunner):
3604         (DRTTestRunner::hasCustomPageSizeStyle):
3605         * DumpRenderTree/chromium/DRTTestRunner.h:
3606         (DRTTestRunner):
3607         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3608         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3609         * DumpRenderTree/mac/TestRunnerMac.mm:
3610         * DumpRenderTree/qt/TestRunnerQt.cpp:
3611         (TestRunner::evaluateScriptInIsolatedWorld):
3612         * DumpRenderTree/qt/TestRunnerQt.h:
3613         (TestRunner):
3614         * DumpRenderTree/win/TestRunnerWin.cpp:
3615         * DumpRenderTree/wx/TestRunnerWx.cpp:
3616         (TestRunner::abortModal):
3617         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3618         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3619         (WTR):
3620         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3621         (TestRunner):
3622
3623 2012-09-05  Simon Hausmann  <simon.hausmann@nokia.com>
3624
3625         [Qt] Automate the use of AllInOne files in the Qt build
3626         https://bugs.webkit.org/show_bug.cgi?id=95837
3627
3628         Reviewed by Tor Arne Vestbø.
3629
3630         New feature file that implements the all-in-one file automation by
3631         adding the requested all-in-one files to SOURCES and removing the files
3632         it includes from SOURCES.
3633
3634         * qmake/mkspecs/features/use_all_in_one_files.prf: Added.
3635
3636 2012-09-04  Tim Horton  <timothy_horton@apple.com>
3637
3638         Have NRWT log more output when crash logs are missing
3639         https://bugs.webkit.org/show_bug.cgi?id=95814
3640
3641         Reviewed by Dan Bernstein.
3642
3643         Log the stderr and stdout of the test, in order to provide slightly more
3644         context when the WebProcess times out while running tests.
3645
3646         * Scripts/webkitpy/layout_tests/port/driver.py:
3647         (Driver.run_test):
3648
3649 2012-09-04  Xianzhu Wang  <wangxianzhu@chromium.org>
3650
3651         [Chromium-Android] Include device serial number in ChromiumAndroidDriver log messages
3652         https://bugs.webkit.org/show_bug.cgi?id=95770
3653
3654         Reviewed by Adam Barth.
3655
3656         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3657         (ChromiumAndroidDriver.__init__):
3658         (ChromiumAndroidDriver._log_error): Added to replace original _log.error().
3659         (ChromiumAndroidDriver._log_debug): Added to replace original _log.debug().
3660         (ChromiumAndroidDriver._abort): Added to replace original raise AssertionError().
3661         (ChromiumAndroidDriver._push_executable):
3662         (ChromiumAndroidDriver._push_fonts):
3663         (ChromiumAndroidDriver._push_test_resources):
3664         (ChromiumAndroidDriver._run_adb_command):
3665         (ChromiumAndroidDriver._get_last_stacktrace):
3666         (ChromiumAndroidDriver._get_crash_log):
3667         (ChromiumAndroidDriver._start):
3668         (ChromiumAndroidDriver._start_once):
3669         (ChromiumAndroidDriver._start_once.deadlock_detector):
3670         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
3671         (ChromiumAndroidDriverTest.test_get_crash_log):
3672
3673 2012-09-04  Satish Sampath  <satish@chromium.org>
3674
3675         Run git commands within the checkout directory
3676         https://bugs.webkit.org/show_bug.cgi?id=95742
3677
3678         Reviewed by Eric Seidel.
3679
3680         git&nbs