Resource Load Statistics: Add alternate classification method
[WebKit-https.git] / Tools / ChangeLog
1 2017-02-21  John Wilander  <wilander@apple.com>
2
3         Resource Load Statistics: Add alternate classification method
4         https://bugs.webkit.org/show_bug.cgi?id=168347
5         <rdar://problem/30352793>
6
7         Reviewed by Alex Christensen.
8
9         Added three testRunner functions to facilitate layout tests:
10         - setStatisticsSubframeUnderTopFrameOrigin()
11         - setStatisticsSubresourceUnderTopFrameOrigin()
12         - setStatisticsSubresourceUniqueRedirectTo()
13
14         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
15         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
16         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
17         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
18         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
19         * WebKitTestRunner/InjectedBundle/TestRunner.h:
20         * WebKitTestRunner/TestController.cpp:
21         (WTR::TestController::setStatisticsSubframeUnderTopFrameOrigin):
22         (WTR::TestController::setStatisticsSubresourceUnderTopFrameOrigin):
23         (WTR::TestController::setStatisticsSubresourceUniqueRedirectTo):
24         * WebKitTestRunner/TestController.h:
25         * WebKitTestRunner/TestInvocation.cpp:
26         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
27
28 2017-02-21  Jonathan Bedard  <jbedard@apple.com>
29
30         webkitpy: Refactor Device class
31         https://bugs.webkit.org/show_bug.cgi?id=168332
32
33         Reviewed by Alexey Proskuryakov.
34
35         Separate the more specific SimulatedDevice from the abstract
36         idea of a device.
37
38         * Scripts/webkitpy/xcode/device.py: Added.
39         (Device):  Base device class.
40         (Device.__init__): Initialize _host, name and udid.
41         (Device.install_app): Function declaration.
42         (Device.launch_app): Ditto.
43         (Device.__eq__): Compare two devices by udid.
44         (Device.__ne__): Ditto.
45         (Device.__repr__): Return device name and udid in formatted string.
46         * Scripts/webkitpy/xcode/simulated_device.py: Copied from Tools/Scripts/webkitpy/xcode/simulator.py.
47         (SimulatedDevice):
48         (SimulatedDevice.__init__): Call Device.__init__ first.
49         (SimulatedDevice.delete): Device -> SimulatedDevice.
50         (SimulatedDevice.reset): Ditto.
51         (SimulatedDevice.__eq__): Moved to device.py.
52         (SimulatedDevice.__ne__): Ditto.
53         (SimulatedDevice.__repr__): Call Device __repr__ first.
54         (DeviceType): Kept in Scripts/webkitpy/xcode/simulator.py.
55         (Runtime): Kept in Scripts/webkitpy/xcode/simulator.py.
56         (Device): Renamed SimulatedDevice.
57         (Simulator): Kept in Scripts/webkitpy/xcode/simulator.py.
58         * Scripts/webkitpy/xcode/simulator.py:
59         (Simulator): Define Simulator.Device class as None.
60         (Simulator.__init__): Import SimulatedDevice as Simulator.Device.
61         (Simulator.delete_device): Use Simulator.Device.
62         (Simulator.reset_device): Ditto.
63         (Simulator._parse_devices): Ditto.
64         (Simulator.lookup_or_create_device): Make 
65         (Device): Moved to simulated_device as SimulatedDevice.
66
67 2017-02-21  JF Bastien  <jfbastien@apple.com>
68
69         Fix cmake build
70         https://bugs.webkit.org/show_bug.cgi?id=168665
71
72         Reviewed by Mark Lam.
73
74         It was broken by r212555 and r212681.
75
76         * DumpRenderTree/PlatformMac.cmake:
77
78 2017-02-21  Alexey Proskuryakov  <ap@apple.com>
79
80         Improve bot watcher's dashboard performance
81         https://bugs.webkit.org/show_bug.cgi?id=168624
82         <rdar://problem/30190109>
83
84         Reviewed by Daniel Bates.
85
86         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
87         There was an unnecessary linear complexity algorithm in indexOfRevision().
88
89 2017-02-21  Alex Christensen  <achristensen@webkit.org>
90
91         Unreviewed, rolling out r212699.
92
93         Internal build not ready
94
95         Reverted changeset:
96
97         "[WebRTC][Mac] Activate libwebrtc"
98         https://bugs.webkit.org/show_bug.cgi?id=167293
99         http://trac.webkit.org/changeset/212699
100
101 2017-02-20  Carlos Garcia Campos  <cgarcia@igalia.com>
102
103         Remove ENABLE_THREADED_COMPOSITOR build option
104         https://bugs.webkit.org/show_bug.cgi?id=168606
105
106         Reviewed by Michael Catanzaro.
107
108         * Scripts/webkitperl/FeatureList.pm:
109
110 2017-02-20  Youenn Fablet  <youenn@apple.com>
111
112         [WebRTC][Mac] Activate libwebrtc
113         https://bugs.webkit.org/show_bug.cgi?id=167293
114         <rdar://problem/30401864>
115
116         Reviewed by Alex Christensen.
117
118         Fixing paths to allow loading libwebrtc.dylib successfully.
119
120         * Scripts/build-webkit:
121         * Scripts/webkitdirs.pm:
122         (setupMacWebKitEnvironment):
123         (setupIOSWebKitEnvironment):
124
125 2017-02-20  Ryan Haddad  <ryanhaddad@apple.com>
126
127         Unreviewed, rolling out r212685.
128
129         This change broke the 32-bit Sierra build.
130
131         Reverted changeset:
132
133         "Resource Load Statistics: Add alternate classification
134         method"
135         https://bugs.webkit.org/show_bug.cgi?id=168347
136         http://trac.webkit.org/changeset/212685
137
138 2017-02-20  John Wilander  <wilander@apple.com>
139
140         Resource Load Statistics: Add alternate classification method
141         https://bugs.webkit.org/show_bug.cgi?id=168347
142         <rdar://problem/30352793>
143
144         Reviewed by Alex Christensen.
145
146         Added three testRunner functions to facilitate layout tests:
147         - setStatisticsSubframeUnderTopFrameOrigin()
148         - setStatisticsSubresourceUnderTopFrameOrigin()
149         - setStatisticsSubresourceUniqueRedirectTo()
150
151         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
152         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
153         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
154         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
155         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
156         * WebKitTestRunner/InjectedBundle/TestRunner.h:
157         * WebKitTestRunner/TestController.cpp:
158         (WTR::TestController::setStatisticsSubframeUnderTopFrameOrigin):
159         (WTR::TestController::setStatisticsSubresourceUnderTopFrameOrigin):
160         (WTR::TestController::setStatisticsSubresourceUniqueRedirectTo):
161         * WebKitTestRunner/TestController.h:
162         * WebKitTestRunner/TestInvocation.cpp:
163         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
164
165 2017-02-20  Anders Carlsson  <andersca@apple.com>
166
167         Use the new drag code path when dragging links
168         https://bugs.webkit.org/show_bug.cgi?id=168612
169
170         Reviewed by Tim Horton.
171
172         If a type is not dynamic, just use the static UTI.
173
174         * DumpRenderTree/mac/DumpRenderTreePasteboard.mm:
175         (-[LocalPasteboard writeObjects:]):
176
177 2017-02-17  Anders Carlsson  <andersca@apple.com>
178
179         Add a new drag code path and use it for dragging plain text
180         https://bugs.webkit.org/show_bug.cgi?id=168534
181
182         Reviewed by Geoffrey Garen.
183
184         Update the testing infrastructure to handle NSDraggingSession.
185
186         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
187         * DumpRenderTree/mac/DumpRenderTreePasteboard.mm: Renamed from Tools/DumpRenderTree/mac/DumpRenderTreePasteboard.m.
188         (-[LocalPasteboard writeObjects:]):
189         Implement this in terms of the legacy pasteboard API.
190
191         * DumpRenderTree/mac/EventSendingController.mm:
192         (drt_WebHTMLView_beginDraggingSessionWithItemsEventSource):
193         (+[EventSendingController initialize]):
194         Swizzle the drag method instead of adding a delegate method (like the old code does).
195
196 2017-02-20  Florian Bruhin  <git@the-compiler.org>
197
198         Handle EINTR during webkitpy server process select()
199         https://bugs.webkit.org/show_bug.cgi?id=168361
200
201         Reviewed by Michael Catanzaro.
202
203         Otherwise, on my machine, resizing the terminal run-webkit-tests is running in
204         makes it die.
205
206         * Scripts/webkitpy/port/server_process.py:
207         (ServerProcess._wait_for_data_and_update_buffers_using_select):
208
209 2017-02-20  Carlos Garcia Campos  <cgarcia@igalia.com>
210
211         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/default-menu.
212
213         It can happen that the window onload event is dispatched after the load finished is received in the UI
214         process. Move the script to select the text to the body instead of using a window onload handler.
215
216         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
217         (testContextMenuDefaultMenu):
218
219 2017-02-20  Manuel Rego Casasnovas  <rego@igalia.com>
220
221         [css-grid] Remove compilation flag ENABLE_CSS_GRID_LAYOUT
222         https://bugs.webkit.org/show_bug.cgi?id=167693
223
224         Reviewed by Sergio Villar Senin.
225
226         * Scripts/webkitperl/FeatureList.pm:
227         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
228         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp:
229         (TestWebKitAPI::computeNumberOfTracks):
230         (TestWebKitAPI::TEST):
231         * TestWebKitAPI/Tests/WebCore/GridPosition.cpp:
232         (TestWebKitAPI::TEST):
233
234 2017-02-19  Commit Queue  <commit-queue@webkit.org>
235
236         Unreviewed, rolling out r212466.
237         https://bugs.webkit.org/show_bug.cgi?id=168577
238
239         causes crashes on AArch64 on linux, maybe it's causing crashes
240         on iOS too (Requested by pizlo on #webkit).
241
242         Reverted changeset:
243
244         "The collector thread should only start when the mutator
245         doesn't have heap access"
246         https://bugs.webkit.org/show_bug.cgi?id=167737
247         http://trac.webkit.org/changeset/212466
248
249 2017-02-17  Aakash Jain  <aakash_jain@apple.com>
250
251         Fix failure from r212579.
252
253         Unreviewed build-fix.
254
255         * Scripts/webkitpy/tool/steps/checkpatchrelevance.py:
256         (CheckPatchRelevance._changes_are_relevant): Return true for all groups others than jsc for now.
257
258 2017-02-17  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
259
260         EWS should run JavaScriptCore tests
261         https://bugs.webkit.org/show_bug.cgi?id=162458
262
263         Reviewed by Alexey Proskuryakov.
264
265         * QueueStatusServer/config/queues.py: Add jsc-ews queue.
266         * QueueStatusServer/model/queuestatus.py:
267         (QueueStatus.did_skip): Returns whether patch was skipped, based on status.
268         * QueueStatusServer/handlers/statusbubble.py:
269         (StatusBubble._should_show_bubble_for): Add logic to hide jsc-ews bubble if the patch does not touch jsc.
270         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
271         (MockSCM.__init__): Add _mockChangedFiles variable.
272         (MockSCM.changed_files): Change to use _mockChangedFiles variables.
273         * Scripts/webkitpy/common/config/ews.json: Add config info for JSC EWS.
274         * Scripts/webkitpy/common/config/ports.py: Add support for JSC EWS in Mac Port.
275         (DeprecatedPort._append_build_style_flag): Helper function to append build_style to a command.
276         (DeprecatedPort.build_jsc_command): Added - command to build JSC only (quicker than building all of WebKit).
277         (DeprecatedPort.run_javascriptcore_tests_command): Allow JSC EWS to only run JSC tests.
278         (MacPort.run_webkit_tests_command): Check for JSC.
279         * Scripts/webkitpy/common/config/ports_mock.py:
280         (MockPort.run_javascriptcore_tests_command): Add build_style argument.
281         * Scripts/webkitpy/common/config/ports_unittest.py:
282         (DeprecatedPortTest.test_mac_port): Add unit tests for build-jsc shell command.
283         * Scripts/webkitpy/common/net/abstracttestresults.py: Added.
284         (AbstractTestResults): Abstract superclass of JSCTestResults and JSCTestResults.
285         (AbstractTestResults.test_results): Stub.
286         (AbstractTestResults.failing_tests): Stub.
287         (AbstractTestResults.did_exceed_test_failure_limit): Stub.
288         * Scripts/webkitpy/common/net/jsctestresults.py: Added.
289         (JSCTestResults): Added.
290         (JSCTestResults.intersection): Return a JSCTestResults object with failures common to both input objects.
291         (JSCTestResults.results_from_string): Use json library to parse results.
292         (JSCTestResults.__init__): Initialize members.
293         (JSCTestResults.equals): This enables unit testing.
294         (JSCTestResults.is_subset): Checks if one set of failures is a subset of another.
295         (JSCTestResults.all_passed): Getter.
296         (JSCTestResults.failing_tests): Getter.
297         (JSCTestResults.did_exceed_test_failure_limit): Getter.
298         * Scripts/webkitpy/common/net/jsctestresults_unittest.py: Added.
299         (JSCTestResultsTest): Class to test JSCTestResults.
300         (JSCTestResultsTest.test_results_from_string): Tests parsing.
301         (JSCTestResultsTest.test_intersection_api_tests): Unit test for intersection() class method.
302         (JSCTestResultsTest.test_intersection_stress_tests): Unit test for intersection() class method.
303         (JSCTestResultsTest.test_intersection_general_case): Unit test for intersection() class method.
304         * Scripts/webkitpy/port/base.py:
305         (Port.jsc_results_directory): Returns the directory for the JSC test results JSON file.
306         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
307         (EarlyWarningSystemTask.run): Add check_patch_relevance step.
308         * Scripts/webkitpy/tool/bot/jscews_unittest.py: Added.
309         (MockPatchAnalysisTask): Mocked-out version of PatchAnalysisTask that doesn't run commands.
310         (MockPatchAnalysisTask.__init__): Sets attributes.
311         (MockPatchAnalysisTask._test): Override to not run command.
312         (MockPatchAnalysisTask._build_and_test_without_patch): Override to not run command.
313         (MockPatchAnalysisTask.validate): Assume mocked patch is valid for purposes of testing retry logic.
314         (MockPatchAnalysisTask.test_run_count): Specific to the mocked version, to test retry logic.
315         (MockJSCEarlyWarningSystem): Mocked-out version of AbstarctEarlyWarningSystem so we can provide test results.
316         (MockJSCEarlyWarningSystem.__init__): Sets attributes, also sets group to jsc.
317         (MockJSCEarlyWarningSystem.test_results): Returns test results provided by us, instead of using a JSON reader.
318         (JSCEarlyWarningSystemTest): Class to test retry logic in below situations.
319         (JSCEarlyWarningSystemTest._create_task): Helper function to abstract out common code.
320         (JSCEarlyWarningSystemTest._results_indicate_all_passed): False if input is None or has failures, else True.
321         (JSCEarlyWarningSystemTest.test_success_case): Clean patch on clean tree.
322         (JSCEarlyWarningSystemTest.test_test_failure): Failed patch on clean tree.
323         (JSCEarlyWarningSystemTest.test_fix): Patch that fixes all tree redness.
324         (JSCEarlyWarningSystemTest.test_ineffective_patch): Patch that has same failures as tree.
325         (JSCEarlyWarningSystemTest.test_partially_effective_patch): Patch fixes some failures but adds no new failures.
326         (JSCEarlyWarningSystemTest.test_different_test_failures_in_patch_and_tree): Patch has some failures not in tree.
327         (JSCEarlyWarningSystemTest.test_first_results_could_not_be_read): Patch results not readable.
328         (JSCEarlyWarningSystemTest.test_second_results_could_not_be_read): Patch results not readable on second run.
329         (JSCEarlyWarningSystemTest.test_clean_results_could_not_be_read): Results from clean tree not readable.
330         (JSCEarlyWarningSystemTest.test_flaky_results_on_clean_tree_pass): Patch has one flake and no failures.
331         (JSCEarlyWarningSystemTest.test_flaky_results_on_clean_tree_pass_v2): Patch has one flake and no failures.
332         (JSCEarlyWarningSystemTest.test_flaky_results_on_clean_tree_failure): Patch has flakes and failed tests.
333         (JSCEarlyWarningSystemTest.test_flaky_results_on_red_tree_pass): Patch has same failures as tree, plus a flake.
334         * Scripts/webkitpy/tool/bot/jsctestresultsreader.py: Added.
335         (JSCTestResultsReader): Reads results file.
336         (JSCTestResultsReader.__init__): Sets attributes.
337         (JSCTestResultsReader._read_file_contents): Reads file.
338         (JSCTestResultsReader.results): Reads the results file and returns a JSCTestResults object.
339         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
340         (PatchIsNotApplicable): Exception for when patch doesn't have relevant changes.
341         (PatchAnalysisTask._check_patch_relevance): Added.
342         (PatchAnalysisTask._build): Check for JSC.
343         (PatchAnalysisTask._build_without_patch): Check for JSC.
344         (PatchAnalysisTask._test): Check for JSC.
345         (PatchAnalysisTask._build_and_test_without_patch): Check for JSC.
346         (PatchAnalysisTask._retry_jsc_tests): Retry logic for JSC EWS.
347         (PatchAnalysisTask._retry_layout_tests): Retry logic for layout tests EWS.
348         (PatchAnalysisTask._test_patch): Add retry logic for JSC.
349         * Scripts/webkitpy/tool/commands/download.py:
350         (CheckPatchRelevance): Add check-patch-relevance command.
351         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
352         (AbstractEarlyWarningSystem._create_task): Abstract out to enable mocking.
353         (AbstractEarlyWarningSystem.begin_work_queue): Use JSCTestResultsReader not LayoutTestResultsReader in JSC EWS.
354         (AbstractEarlyWarningSystem.review_patch): Handle PatchIsApplicable.
355         (AbstractEarlyWarningSystem.test_results): _layout_test_results_reader -> _test_results_reader.
356         (AbstractEarlyWarningSystem.archive_last_test_results): _layout_test_results_reader -> _test_results_reader.
357         (AbstractEarlyWarningSystem.group): This attribute determines the type of EWS (eg. JSC).
358         (AbstractEarlyWarningSystem.load_ews_classes): Add _group, and make classes of type cls to enable mocking.
359         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
360         (TestEWS): Sample layout test EWS class used for unit testing.
361         (TestJSCEWS): Sample JSC EWS class used for unit testing.
362         (AbstractEarlyWarningSystemTest.test_failing_tests_message.TestEWS): Add _group.
363         (AbstractEarlyWarningSystemTest.test_failing_jsc_tests_message.TestEWS): Added test for jsc failures message.
364         (AbstractEarlyWarningSystemTest): Add _group variable.
365         (EarlyWarningSystemTest._default_expected_logs): Add check-patch-relevance step, inconclusive logs, and group.
366         (EarlyWarningSystemTest._test_ews): Add logs_are_conclusive option to pass through to default_expected_logs().
367         (EarlyWarningSystemTest.test_inconclusive_test_results): Test not removing patch from queue if not conclusive.
368         (MockAbstractEarlyWarningSystemForInconclusiveJSCResults): Added.
369         (MockAbstractEarlyWarningSystemForInconclusiveJSCResults._test_patch): Simulates running tests but not getting a conclusive result.
370         (MockEarlyWarningSystemTaskForInconclusiveJSCResults): Added.
371         (MockEarlyWarningSystemTaskForInconclusiveJSCResults._create_task): Use MockEarlyWarningSystemTask (not EarlyWarningSystemTask).
372         * Scripts/webkitpy/tool/steps/__init__.py: Add CheckPatchRelevance import.
373         * Scripts/webkitpy/tool/steps/build.py:
374         (Build.options): Check for JSC.
375         (Build.build): Check for JSC.
376         (Build.run): Check for JSC.
377         * Scripts/webkitpy/tool/steps/checkpatchrelevance.py: Added.
378         (CheckPatchRelevance): Added.
379         (CheckPatchRelevance._does_contain_change_in_paths): Abstract function to perform regex matching.
380         (CheckPatchRelevance.run): Check if changed files in patch belong in certain folders.
381         * Scripts/webkitpy/tool/steps/options.py:
382         (Options): Add --group command line option.
383         * Scripts/webkitpy/tool/steps/runtests.py:
384         (RunTests.options): Add group.
385         (RunTests.run): Check for JSC.
386         (RunTests._run_webkit_tests): Check for JSC.
387         (RunTests): Add _group attribute.
388         (RunTests._run_javascriptcore_tests): New.
389         * Scripts/webkitpy/tool/steps/steps_unittest.py: Unit tests.
390
391 2017-02-17  Aakash Jain  <aakash_jain@apple.com>
392
393         Fix tools that were broken by Efl removal
394         https://bugs.webkit.org/show_bug.cgi?id=168496
395
396         Reviewed by Alexey Proskuryakov.
397
398         * QueueStatusServer/config/queues.py:
399         * Scripts/webkitpy/common/config/ews.json:
400         * TestResultServer/static-dashboards/builders.jsonp:
401         * TestResultServer/static-dashboards/flakiness_dashboard.js:
402         * TestResultServer/static-dashboards/loader_unittests.js:
403
404 2017-02-16  Lucas Forschler  <lforschler@apple.com>
405
406         https://bugs.webkit.org/show_bug.cgi?id=168442
407         Move the SVN checkout from http -> https.
408         Update unit tests.
409
410         Reviewed by Alexey Proskuryakov.
411
412         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
413         (CheckOutSource.__init__):
414         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
415         (SVNMirrorTest.get_SVNMirrorFromConfig):
416         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
417
418 2017-02-16  Commit Queue  <commit-queue@webkit.org>
419
420         Unreviewed, rolling out r212514.
421         https://bugs.webkit.org/show_bug.cgi?id=168489
422
423         broke test runner (Requested by alexchristensen on #webkit).
424
425         Reverted changeset:
426
427         "Remove EFL-specific files in Tools."
428         http://trac.webkit.org/changeset/212514
429
430 2017-02-16  Alex Christensen  <achristensen@webkit.org>
431
432         Remove EFL-specific files in Tools.
433
434         Rubber-stamped by Anders Carlsson.
435
436         * ImageDiff/efl: Removed.
437         * ImageDiff/efl/ImageDiff.cpp: Removed.
438         * MiniBrowser/efl: Removed.
439         * MiniBrowser/efl/CMakeLists.txt: Removed.
440         * MiniBrowser/efl/main.c: Removed.
441         * Scripts/run-efl-tests: Removed.
442         * Scripts/update-webkitefl-libs: Removed.
443         * Scripts/webkitpy/port/efl.py: Removed.
444         * Scripts/webkitpy/port/efl_unittest.py: Removed.
445         * TestWebKitAPI/Tests/WebKit2/efl: Removed.
446         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp: Removed.
447         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp: Removed.
448         * TestWebKitAPI/Tests/WebKit2/efl/WKViewScrollTo.cpp: Removed.
449         * TestWebKitAPI/Tests/WebKit2/efl/scrollTo.html: Removed.
450         * TestWebKitAPI/efl: Removed.
451         * TestWebKitAPI/efl/InjectedBundleController.cpp: Removed.
452         * TestWebKitAPI/efl/PlatformUtilities.cpp: Removed.
453         * TestWebKitAPI/efl/PlatformWebView.cpp: Removed.
454         * TestWebKitAPI/efl/main.cpp: Removed.
455         * WebKitTestRunner/InjectedBundle/efl: Removed.
456         * WebKitTestRunner/InjectedBundle/efl/ActivateFontsEfl.cpp: Removed.
457         * WebKitTestRunner/InjectedBundle/efl/FontManagement.cpp: Removed.
458         * WebKitTestRunner/InjectedBundle/efl/FontManagement.h: Removed.
459         * WebKitTestRunner/InjectedBundle/efl/InjectedBundleEfl.cpp: Removed.
460         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp: Removed.
461         * WebKitTestRunner/efl: Removed.
462         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp: Removed.
463         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp: Removed.
464         * WebKitTestRunner/efl/TestControllerEfl.cpp: Removed.
465         * WebKitTestRunner/efl/main.cpp: Removed.
466         * efl: Removed.
467         * efl/install-dependencies: Removed.
468         * efl/jhbuild-optional.modules: Removed.
469         * efl/jhbuild.modules: Removed.
470         * efl/jhbuildrc: Removed.
471         * efl/patches: Removed.
472         * efl/patches/evas-fix-build-with-giflib5.patch: Removed.
473         * efl/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Removed.
474         * efl/patches/gst-libav.patch: Removed.
475         * efl/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Removed.
476         * efl/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
477         * efl/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
478         * efl/patches/openwebrtc-gst-plugins-clang-warning-fix.patch: Removed.
479
480 2017-02-16  Myles C. Maxfield  <mmaxfield@apple.com>
481
482         font-weight in @font-face can cause a font to be downloaded even when it's not used
483         https://bugs.webkit.org/show_bug.cgi?id=168114
484         <rdar://problem/30301317>
485
486         Reviewed by Darin Adler.
487
488         LastResort needs to be usable in tests.
489
490         * DumpRenderTree/mac/DumpRenderTree.mm:
491         (allowedFontFamilySet):
492         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
493         (WTR::allowedFontFamilySet):
494         * WebKitTestRunner/mac/TestControllerMac.mm:
495         (WTR::allowedFontFamilySet):
496
497 2017-02-16  Alex Christensen  <achristensen@webkit.org>
498
499         Remove old URL parser
500         https://bugs.webkit.org/show_bug.cgi?id=168483
501
502         Reviewed by Tim Horton.
503
504         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
505         (TestWebKitAPI::checkURL):
506         (TestWebKitAPI::checkRelativeURL):
507         (TestWebKitAPI::checkURLDifferences):
508         (TestWebKitAPI::checkRelativeURLDifferences):
509
510 2017-02-16  Wenson Hsieh  <wenson_hsieh@apple.com>
511
512         [WK2] Add additional test infrastructure and unit tests for data interaction
513         https://bugs.webkit.org/show_bug.cgi?id=168439
514         <rdar://problem/30557942>
515
516         Reviewed by Tim Horton.
517
518         Adds test support for additional data interaction scenarios that we currently cannot test, and also adds 7 new
519         test cases to DataInteractionTests. Most of the changes here refactor and augment DataInteractionSimulator to
520         support data interaction from  See per-method descriptions below for more details.
521
522         * Configurations/TestWebKitAPI.xcconfig:
523
524         Add MobileCoreServices to the list of additional frameworks to link against on iOS.
525
526         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
527
528         Add a new build phase that copies additional resources from WebKitAdditions/Resources/TestWebKitAPI and dumps
529         them into TestWebKitAPI.resources/ in the build directory, if the WebKitAdditions folder exists.
530
531         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
532         (-[TestWKWebView editorContainsImageElement]):
533         (-[TestWKWebView editorValue]):
534
535         New helper methods for querying information from the "editor" element in a test page.
536
537         (TestWebKitAPI::TEST):
538         (TestWebKitAPI::runTestsExpectingToObserveEvents): Deleted.
539
540         Moves logic for capturing events during a simulated data interaction run from the test file to
541         DataInteractionSimulator. See -[DataInteractionSimulator observedEventNames].
542
543         * TestWebKitAPI/cocoa/TestWKWebView.h:
544         * TestWebKitAPI/cocoa/TestWKWebView.mm:
545         (-[TestMessageHandler removeMessage:]):
546         (-[TestWKWebView clearMessageHandlers:]):
547
548         Add the ability to clear message handlers from the TestWKWebView.
549
550         * TestWebKitAPI/ios/DataInteractionSimulator.h:
551         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
552         (dataInteractionEventNames):
553         (-[DataInteractionSimulator initWithWebView:]):
554         (-[DataInteractionSimulator _resetSimulatedState]):
555
556         Moves logic to clear test harness state from any previous runs into a helper. Called at the beginning when
557         simulating data interaction.
558
559         (-[DataInteractionSimulator observedEventNames]):
560
561         Returns a list of the names of events relevant to data interaction that were observed over the course of the
562         most recent run.
563
564         (-[DataInteractionSimulator runFrom:to:]):
565
566         Changes -run to -runFrom:to:, which takes window-relative start and end locations. This allows the test harness
567         to run the same data interaction for multiple simulated gestures.
568
569         (-[DataInteractionSimulator _advanceProgress]):
570         (-[DataInteractionSimulator _finishDataInteraction]):
571         (-[DataInteractionSimulator externalItemProvider]):
572         (-[DataInteractionSimulator setExternalItemProvider:]):
573
574         Adds the -externalItemProvider property to DataInteractionSimulator. Setting this skips the gesture recognition
575         phase of a test run.
576
577         (-[DataInteractionSimulator webViewDidPerformDataInteractionControllerOperation:]):
578         (-[DataInteractionSimulator webView:beginDataInteractionWithSourceIndex:gestureRecognizer:]):
579         (-[DataInteractionSimulator webViewDidSendDataInteractionStartRequest:]):
580         (-[DataInteractionSimulator webView:didReceiveDataInteractionStartResponse:]):
581
582         While a request to start data interaction is in flight, put the remainder of the test on hold until the web
583         process returns. Then continue the test by scheduling a progress advance call. This addresses a race condition
584         wherein the the web process might take longer than usual to process the request to start data interaction, and
585         in the meantime, DataInteractionSimulator would end up completing the rest of the test before a response from
586         the web process is received, which then causes no simulated delegate methods to be fired.
587
588         (-[DataInteractionSimulator initWithWebView:startLocation:endLocation:]): Deleted.
589         (-[DataInteractionSimulator run]): Deleted.
590
591 2017-02-16  Wenson Hsieh  <wenson_hsieh@apple.com>
592
593         Remove unused test pages in TestWebKitAPI
594         https://bugs.webkit.org/show_bug.cgi?id=168462
595
596         Reviewed by Anders Carlsson.
597
598         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
599         * TestWebKitAPI/Tests/WebKit2Cocoa/autofocus-contenteditable.html: Removed.
600         * TestWebKitAPI/Tests/WebKit2Cocoa/background-image-link-and-input.html: Removed.
601         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-contenteditable.html: Removed.
602         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html: Removed.
603         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-input.html: Removed.
604
605 2017-02-16  Alex Christensen  <achristensen@webkit.org>
606
607         Special URLs without a host are invalid
608         https://bugs.webkit.org/show_bug.cgi?id=168461
609
610         Reviewed by Tim Horton.
611
612         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
613         (TestWebKitAPI::TEST_F):
614
615 2017-02-10  Filip Pizlo  <fpizlo@apple.com>
616
617         The collector thread should only start when the mutator doesn't have heap access
618         https://bugs.webkit.org/show_bug.cgi?id=167737
619
620         Reviewed by Keith Miller.
621         
622         Make more tests collect continuously.
623
624         * Scripts/run-jsc-stress-tests:
625
626 2017-02-16  Tim Horton  <timothy_horton@apple.com>
627
628         WKWebView inside a UICollectionView flashes when items are inserted above it
629         https://bugs.webkit.org/show_bug.cgi?id=168376
630         <rdar://problem/29322051>
631
632         Reviewed by Simon Fraser.
633
634         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
635         (-[TestRunnerWKWebView _setStableStateOverride:]):
636         Update the one external caller of this internal method...
637
638         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
639         (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
640         * DumpRenderTree/mac/UIScriptControllerMac.mm:
641         (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
642         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
643         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
644         (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
645         * TestRunnerShared/UIScriptContext/UIScriptController.h:
646         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
647         (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
648         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
649         (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
650         Expose doAfterVisibleContentRectUpdate to DRT and WKTR. It is called
651         back after we dispatch a visible content rect update from the UI process
652         to the Web Content process, so any messages sent from the block will arrive
653         after the visible content rect update.
654
655 2017-02-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
656
657         [GTK] Add two new buildbots that build-only test on Debian stable and Ubuntu LTS.
658         https://bugs.webkit.org/show_bug.cgi?id=168321
659
660         This bots should be added to the trunk build scheduler.
661         Unreviewed fix after r212429.
662
663         * BuildSlaveSupport/build.webkit.org-config/config.json:
664
665 2017-02-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
666
667         [GTK] Add two new buildbots that build-only test on Debian stable and Ubuntu LTS
668         https://bugs.webkit.org/show_bug.cgi?id=168321
669
670         Reviewed by Michael Catanzaro.
671
672         The additionalArgument --default-cmake-features is used both to
673         skip the JHBuild (InstallGtkDependencies) build step and to build
674         with the default features from the CMake config.
675
676         * BuildSlaveSupport/build.webkit.org-config/config.json:
677         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
678         (Factory.__init__):
679         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
680
681 2017-02-15  Lucas Forschler  <lforschler@apple.com>
682
683         https://bugs.webkit.org/show_bug.cgi?id=168386
684         Remove EFL from build.webkit.org
685
686         Reviewed by Alex Christensen
687
688         * BuildSlaveSupport/build.webkit.org-config/config.json:
689         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
690         (DeleteStaleBuildFiles.start):
691         (appendCustomBuildFlags):
692         (RunWebKitTests.start):
693         (RunBuiltinsTests):
694         (Factory.__init__):
695         (TestFactory.__init__):
696         (loadBuilderConfig):
697         (InstallEflDependencies): Deleted.
698         (RunEflAPITests): Deleted.
699         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
700         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
701         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
702         (BubbleQueueServer):
703         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
704         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
705         (Analyzer.prototype._triggeringQueue):
706         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
707         (WebKitBuildbot):
708         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
709         (table.queue-grid tr.platform.linux-efl img.logo): Deleted.
710         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
711         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
712         (_should_file_trigger_build):
713
714 2017-02-15  Alex Christensen  <achristensen@webkit.org>
715
716         Unreviewed, rolling out r212169.
717
718         Broke iOS WebInspector
719
720         Reverted changeset:
721
722         "WebInspector: refactor RemoteInspector to move cocoa specific
723         code to their own files"
724         https://bugs.webkit.org/show_bug.cgi?id=166681
725         http://trac.webkit.org/changeset/212169
726
727 2017-02-15  Jonathan Bedard  <jbedard@apple.com>
728
729         webkitpy: Fix DarwinPort._get_crash_log()
730         https://bugs.webkit.org/show_bug.cgi?id=168372
731         <rdar://problem/30535156>
732
733         Reviewed by Daniel Bates.
734
735         Callers of _get_crash_log expect a pair to be returned and do not check it's return value.  
736         DarwinPort should return the expected return value for _get_crash_log.
737
738         * Scripts/webkitpy/port/darwin.py:
739         (DarwinPort._get_crash_log): Call parent class's implementation of _get_crash_log.
740
741 2017-02-15  Chris Dumez  <cdumez@apple.com>
742
743         [iOS] Form Validation Bubble should be sensitive to Dynamic Type
744         https://bugs.webkit.org/show_bug.cgi?id=168291
745         <rdar://problem/30508593>
746
747         Reviewed by Tim Horton.
748
749         Drop overridePreference() implementation in iOS's UIScriptController
750         as it was only used for the minimum font size setting and this setting
751         is not exposed on iOS.
752
753         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
754         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
755         (WTR::UIScriptController::overridePreference):
756         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
757
758 2017-02-15  Jonathan Bedard  <jbedard@apple.com>
759
760         webkitpy: Memoize app_identifier_from_bundle for efficiency, call parent class for _get_crash_log
761         https://bugs.webkit.org/show_bug.cgi?id=168329
762         <rdar://problem/30518832>
763
764         Reviewed by Daniel Bates.
765
766         When testing on device, app_identifier_from_bundle is repeatedly called but the return value will
767         never change given the same input arguments.  Memoize function for efficiency.
768
769         * Scripts/webkitpy/port/darwin.py: Add memoized import.
770         (DarwinPort):
771         (DarwinPort.app_identifier_from_bundle): Memoize to avoid extra executions of PlistBuddy.
772         
773
774 2017-02-15  Jonathan Bedard  <jbedard@apple.com>
775
776         webkitpy: Remove unused import from darwin.py
777         https://bugs.webkit.org/show_bug.cgi?id=168371
778
779         Reviewed by Alex Christensen.
780
781         * Scripts/webkitpy/port/darwin.py: Remove unused 'time' module.
782
783 2017-02-15  Carlos Garcia Campos  <cgarcia@igalia.com>
784
785         [SOUP] Credentials stored by libsoup are used even StoredCredentials policy is DoNotAllowStoredCredentials
786         https://bugs.webkit.org/show_bug.cgi?id=168364
787
788         Reviewed by Michael Catanzaro.
789
790         This can happen if a previous load with allowed to use stored credentials authenticated successfully, saving the
791         credentials in libsoup. It's actually a libsoup bug, but since it's causing layout test failures and we have
792         patches for them, let's patch out jhbuild until we have a new libsoup version to depend on.
793
794         Fixes: http/tests/security/credentials-from-different-domains.html
795                http/tests/xmlhttprequest/cross-origin-no-authorization.html
796
797         * gtk/jhbuild.modules:
798         * gtk/patches/libsoup-auth-Fix-async-authentication-when-flag-SOUP_MESSAGE.patch: Added.
799         * gtk/patches/libsoup-auth-do-not-use-cached-credentials-in-lookup-method-.patch: Added.
800
801 2017-02-14  Carlos Garcia Campos  <cgarcia@igalia.com>
802
803         [GTK] Update cookie manager API to properly work with ephemeral sessions
804         https://bugs.webkit.org/show_bug.cgi?id=168230
805
806         Reviewed by Michael Catanzaro.
807
808         Update unit tests and add new cases for the new API.
809
810         * MiniBrowser/gtk/main.c:
811         (gotWebsiteDataCallback):
812         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
813         (testCookieManagerEphemeral):
814         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
815         (testWebContextEphemeral):
816         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
817         (testWebViewEphemeral):
818         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp:
819         (serverCallback):
820         (testWebsiteDataEphemeral):
821         (testWebsiteDataCookies):
822         (beforeAll):
823
824 2017-02-14  Wenson Hsieh  <wenson_hsieh@apple.com>
825
826         [WK2] Support data interaction on links
827         https://bugs.webkit.org/show_bug.cgi?id=168331
828         <rdar://problem/30200837>
829
830         Reviewed by Tim Horton.
831
832         Adds 2 unit tests checking that data interaction from a link (with or without a background image) into an
833         editable area results in the link URL being inserted.
834
835         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
836         * TestWebKitAPI/Tests/WebKit2Cocoa/background-image-link-and-input.html: Added.
837         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-input.html: Added.
838         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
839         (TestWebKitAPI::TEST):
840
841 2017-02-14  Jason Rinn  <jrinn@apple.com>
842
843         Add a test for new WebKit Cocoa API, _getContentsAsString.
844         https://bugs.webkit.org/show_bug.cgi?id=168147
845         <rdar://problem/30502539>
846
847         Reviewed by Tim Horton.
848
849         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
850         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewGetContents.mm: Added.
851         (TEST):
852
853 2017-02-14  Matt Rajca  <mrajca@apple.com>
854
855         Website policies: iframes should respect the autoplay policy of the top-level document
856         https://bugs.webkit.org/show_bug.cgi?id=168333
857
858         Reviewed by Alex Christensen.
859
860         * TestWebKitAPI/Tests/WebKit2/autoplay-check-frame.html: Added.
861         * TestWebKitAPI/Tests/WebKit2/autoplay-check-in-iframe.html: Added.
862         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
863         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
864         (TEST):
865
866 2017-02-14  Chris Dumez  <cdumez@apple.com>
867
868         HTML Form Validation bubble should take minimum font size setting into consideration
869         https://bugs.webkit.org/show_bug.cgi?id=168271
870         <rdar://problem/29869869>
871
872         Reviewed by Simon Fraser.
873
874         Extend UIScriptController's contentsOfUserInterfaceItem() to also return the
875         font size of the validation bubble.
876
877         Add an overridePreference() method to UIScriptController. This is currently
878         used to override the value of the minimumFontSize setting. testRunner's
879         overridePreference() is not usable on WK2 because it does not update the
880         value of the preference on the UIProcess side.
881
882         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
883         (WTR::UIScriptController::overridePreference):
884         * DumpRenderTree/mac/UIScriptControllerMac.mm:
885         (WTR::UIScriptController::overridePreference):
886         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
887         * TestRunnerShared/UIScriptContext/UIScriptController.h:
888         * WebKitTestRunner/TestController.cpp:
889         (WTR::TestController::resetPreferencesToConsistentValues):
890         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
891         (WTR::UIScriptController::overridePreference):
892         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
893         (WTR::UIScriptController::contentsOfUserInterfaceItem):
894         (WTR::UIScriptController::overridePreference):
895
896 2017-02-14  Florian Bruhin  <git@the-compiler.org>
897
898         Use a set instead of a list for tests when parsing expectations
899         https://bugs.webkit.org/show_bug.cgi?id=168304
900
901         In _collect_matching_tests, a lot of membership tests are done on a giant list
902         of strings. By making it a set instead, we can make those much faster, and
903         there's no reason for it to be a list.
904
905         With ~45k tests and some 1000 expectations, this reduces the parse time from 34s
906         to 3s on my machine.
907
908         Reviewed by Ryosuke Niwa.
909
910         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
911         (TestExpectationParser.__init__):
912         (TestExpectationParser._collect_matching_tests):
913
914 2017-02-14  Jonathan Bedard  <jbedard@apple.com>
915
916         Unreviewed build-fix after r212297.
917
918         * Scripts/webkitpy/port/simulator_process.py:
919         (SimulatorProcess.stop): Should return value of the ServerProcess's stop.
920
921 2017-02-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
922
923         [CMake] build-webkit should allow building with the default cmake configuration
924         https://bugs.webkit.org/show_bug.cgi?id=168323
925
926         Reviewed by Michael Catanzaro.
927
928         Add a --default-cmake-features switch that makes the script pass
929         no value for any of the features defined by build-webkit, that
930         way the default values from the port cmake config will be used.
931
932         * Scripts/build-webkit:
933         (cMakeArgsFromFeatures):
934
935 2017-02-14  Jonathan Bedard  <jbedard@apple.com>
936
937         Unreviewed build-fix after r212297.
938
939         * Scripts/webkitpy/port/simulator_process.py:
940         (SimulatorProcess.stop): Handle case where there is no process to kill.
941
942 2017-02-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
943
944         [CMake] build-webkit should print the cmake command executed
945         https://bugs.webkit.org/show_bug.cgi?id=168318
946
947         Reviewed by Michael Catanzaro.
948
949         Run the cmake commands to configure or start the build through
950         a wrapper that prints the command before executing it.
951
952         * Scripts/webkitdirs.pm:
953         (systemVerbose):
954         (generateBuildSystemFromCMakeProject):
955         (buildCMakeGeneratedProject):
956         (cleanCMakeGeneratedProject):
957
958 2017-02-14  Jonathan Bedard  <jbedard@apple.com>
959
960         run-webkit-tests for iOS Simulator always complains that stopping WebKitTestRunnerApp.app times out
961         https://bugs.webkit.org/show_bug.cgi?id=168150
962
963         Reviewed by Alexey Proskuryakov.
964
965         * Scripts/webkitpy/port/simulator_process.py:
966         (SimulatorProcess.stop): Close app before calling ServerProcess's stop.
967         (SimulatorProcess._kill): Move closing of app into stop().
968         * Scripts/webkitpy/xcode/simulator.py:
969         (Device.launch_app):
970         (Device.terminate_app): Deleted.
971
972 2017-02-14  Carlos Garcia Campos  <cgarcia@igalia.com>
973
974         REGRESSION(r212192): [GTK] Broke downloads API tests
975         https://bugs.webkit.org/show_bug.cgi?id=168193
976
977         Unreviewed. Update test expectations after r212192.
978
979         The suggested filename now includes a file extensions if the MIME type is known.
980
981         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
982         (testDownloadRemoteFile):
983         (testDownloadMIMEType):
984
985 2017-02-14  Commit Queue  <commit-queue@webkit.org>
986
987         Unreviewed, rolling out r212237.
988         https://bugs.webkit.org/show_bug.cgi?id=168298
989
990         This was a wrong fix (Requested by rniwa on #webkit).
991
992         Reverted changeset:
993
994         "Nwtr unexpectedly passes mismatch ref test if the hashes
995         doesn't match but no diff"
996         https://bugs.webkit.org/show_bug.cgi?id=168221
997         http://trac.webkit.org/changeset/212237
998
999 2017-02-13  Alex Christensen  <achristensen@webkit.org>
1000
1001         URLs with an invalid IPv4 address should be invalid
1002         https://bugs.webkit.org/show_bug.cgi?id=168260
1003
1004         Reviewed by Tim Horton.
1005
1006         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1007         (TestWebKitAPI::TEST_F):
1008         Update tests to reflect new correct behavior.
1009
1010 2017-02-13  Don Olmstead  <don.olmstead@am.sony.com>
1011
1012         [WinCairo] Add Build Slave
1013         https://bugs.webkit.org/show_bug.cgi?id=168263
1014
1015         Reviewed by Lucas Forschler.
1016
1017         * BuildSlaveSupport/build.webkit.org-config/config.json:
1018
1019 2017-02-13  Wenson Hsieh  <wenson_hsieh@apple.com>
1020
1021         Fix the build after r212254
1022
1023         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1024         (-[DataInteractionSimulator _currentLocation]):
1025
1026 2017-02-13  Wenson Hsieh  <wenson_hsieh@apple.com>
1027
1028         [WK2] Add test infrastructure and unit tests for data interaction
1029         https://bugs.webkit.org/show_bug.cgi?id=168159
1030         <rdar://problem/30477634>
1031
1032         Reviewed by Tim Horton.
1033
1034         Uses the testing delegate introduced in WebKit2 to override the gesture recognizer used to initiate data
1035         interaction. Instead of being driven by UIKit, the DataInteractionSimulator drives this overridden gesture
1036         recognizer by making the WKContentView call its dataInteractionGestureRecognized method. To simulate an actual
1037         gesture being performed, we fire the gesture recognizer (or call the data interaction delegate methods, if the
1038         gesture has already been recognized) at regular intervals over the course of the test.
1039
1040         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1041         * TestWebKitAPI/Tests/WebKit2Cocoa/autofocus-contenteditable.html: Added.
1042         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-contenteditable.html: Added.
1043         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html: Added.
1044
1045         New test pages for data interaction.
1046
1047         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Added.
1048         (TestWebKitAPI::runTestsExpectingToObserveEvents):
1049         (TestWebKitAPI::TEST):
1050         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1051         (-[TestWKWebView stringByEvaluatingJavaScript:]):
1052         * TestWebKitAPI/ios/DataInteractionSimulator.h: Added.
1053         * TestWebKitAPI/ios/DataInteractionSimulator.mm: Added.
1054         (-[MockLongPressGestureRecognizer initWithWindow:]):
1055         (-[MockLongPressGestureRecognizer locationInView:]):
1056         (-[MockLongPressGestureRecognizer state]):
1057         (-[MockLongPressGestureRecognizer numberOfTouches]):
1058         (-[DataInteractionSimulator initWithWebView:startLocation:endLocation:]):
1059         (-[DataInteractionSimulator dealloc]):
1060         (-[DataInteractionSimulator run]):
1061
1062         Performs a data interaction gesture from the start location to the end location with linear interpolation. For
1063         now, the timestep and progress per tick are 30ms and 3.33%, respectively, which means that tests should complete
1064         in a little under 1 second, though this can be easily changed to be configurable in the future if needed.
1065
1066         (-[DataInteractionSimulator _advanceProgress]):
1067
1068         Fired periodically to drive the data interaction gesture. Schedules a call of itself until the test is
1069         completed, and calls _finishDataInteraction when progress is at 1.
1070
1071         (-[DataInteractionSimulator _finishDataInteraction]):
1072         (-[DataInteractionSimulator _currentLocation]):
1073         (-[DataInteractionSimulator _scheduleAdvanceProgress]):
1074         (-[DataInteractionSimulator _recognizeGestureAtLocation:withState:]):
1075         (-[DataInteractionSimulator dataInteractionGestureRecognizer]):
1076         (-[DataInteractionSimulator webViewDidPerformDataInteractionControllerOperation:]):
1077         (-[DataInteractionSimulator webView:beginDataInteractionWithSourceIndex:gestureRecognizer:]):
1078
1079 2017-02-13  Alex Christensen  <achristensen@webkit.org>
1080
1081         Percent should be allowed in non-special URL hosts
1082         https://bugs.webkit.org/show_bug.cgi?id=168255
1083
1084         Reviewed by Tim Horton.
1085
1086         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1087         (TestWebKitAPI::TEST_F):
1088
1089 2017-02-13  Fujii Hironori  <Hironori.Fujii@sony.com>
1090
1091         Nwtr unexpectedly passes mismatch ref test if the hashes doesn't match but no diff
1092         https://bugs.webkit.org/show_bug.cgi?id=168221
1093
1094         Reviewed by Ryosuke Niwa.
1095
1096         There is a logic error in comparing mismatch ref test images. In
1097         mismatch ref tests, it should be failed if two images has no diff.
1098         But, if the hashes are different, nwtr unexpectedly pass the
1099         mismatch ref test.
1100
1101         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1102         (SingleTestRunner._compare_output_with_reference): Fail the
1103         mismatch ref test if hashes of two images are equal. Invoke
1104         ImageDiff if the hashes don't match.
1105
1106 2017-02-13  Myles C. Maxfield  <mmaxfield@apple.com>
1107
1108         Update custom line breaking iterators to the latest version of Unicode
1109         https://bugs.webkit.org/show_bug.cgi?id=168182
1110
1111         Reviewed by Zalan Bujtas.
1112
1113         Treat the system's ICU as the source of truth to compare breaking positions against.
1114
1115         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1116         * TestWebKitAPI/Tests/WebCore/LineBreaking.mm: Added.
1117         (generateJavaScriptForTest):
1118         (breakingLocationsFromICU):
1119         (testAFewStrings):
1120         (TEST):
1121         * TestWebKitAPI/Tests/WebKit2Cocoa/AllAhem.svg: Renamed from LayoutTests/css3/line-break/resources/AllAhem.svg.
1122         * TestWebKitAPI/Tests/WebKit2Cocoa/LineBreaking.html: Added.
1123
1124 2017-02-12  Michael Catanzaro  <mcatanzaro@igalia.com>
1125
1126         [GTK] Several failing WebViewEditor API tests
1127         https://bugs.webkit.org/show_bug.cgi?id=161608
1128
1129         Reviewed by Carlos Garcia Campos.
1130
1131         Selection.collapse() requires arguments; passing no arguments means the JS that selects the
1132         text range here never gets evaluated. Perhaps there was a DOM API change? Changing it to use
1133         Selection.removeAllRanges(), which seems like a better function anyway, fixes all the tests
1134         except the first one, which is still broken due to unrelated bug #151654.
1135
1136         * Scripts/run-gtk-tests:
1137         (TestRunner):
1138         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
1139
1140 2017-02-12  Michael Catanzaro  <mcatanzaro@igalia.com>
1141
1142         Unreviewed, skip flaky WebKitPrintOperation/custom-widget test
1143
1144         * Scripts/run-gtk-tests:
1145         (TestRunner):
1146
1147 2017-02-12  Michael Catanzaro  <mcatanzaro@igalia.com>
1148
1149         Unreviewed, skip flaky form-controls-associated-signal test
1150
1151         * Scripts/run-gtk-tests:
1152         (TestRunner):
1153
1154 2017-02-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1155
1156         [GTK] Handle caps lock indicator in event modifiers
1157         https://bugs.webkit.org/show_bug.cgi?id=168186
1158
1159         Reviewed by Michael Catanzaro.
1160
1161         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1162         (WTR::webkitModifiersToGDKModifiers): Handle kWKEventModifiersCapsLockKey.
1163
1164 2017-02-11  Simon Fraser  <simon.fraser@apple.com>
1165
1166         MiniBrowser WK1 fails to update URL for within-page navigations
1167         https://bugs.webkit.org/show_bug.cgi?id=168173
1168
1169         Reviewed by Tim Horton.
1170         
1171         Implement -webView:didChangeLocationWithinPageForFrame: so that clicking on named
1172         anchors updates the URL field.
1173
1174         * MiniBrowser/mac/WK1BrowserWindowController.m:
1175         (-[WK1BrowserWindowController webView:didChangeLocationWithinPageForFrame:]):
1176
1177 2017-02-10  John Wilander  <wilander@apple.com>
1178
1179         Updates to Resource Load Statistics: Get the right website data store and introduce timeout for user interaction
1180         https://bugs.webkit.org/show_bug.cgi?id=167474
1181         <rdar://problem/24681808>
1182         <rdar://problem/24703286>
1183         <rdar://problem/30290270>
1184
1185         This patch adds test infrastructure to allow testing 
1186         of the various rules in place for data records removal.
1187
1188         Reviewed by Andy Estes.
1189
1190         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1191         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1192         (WTR::InjectedBundle::didReceiveMessageToPage):
1193             Callback mechanism to tell pages that a website data store
1194             scan has happened.
1195         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1196         (WTR::TestRunner::setStatisticsPrevalentResource):
1197         (WTR::TestRunner::isStatisticsPrevalentResource):
1198         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
1199         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
1200         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
1201         (WTR::TestRunner::installStatisticsDidModifyDataRecordsCallback):
1202         (WTR::TestRunner::statisticsDidModifyDataRecordsCallback):
1203         (WTR::TestRunner::statisticsFireDataModificationHandler):
1204         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
1205         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
1206         (WTR::TestRunner::setStatisticsMinimumTimeBetweeenDataRecordsRemoval):
1207         (WTR::TestRunner::statisticsResetToConsistentState):
1208         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1209         * WebKitTestRunner/TestController.cpp:
1210         (WTR::TestController::setStatisticsPrevalentResource):
1211         (WTR::TestController::isStatisticsPrevalentResource):
1212         (WTR::TestController::setStatisticsHasHadUserInteraction):
1213         (WTR::TestController::isStatisticsHasHadUserInteraction):
1214         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
1215         (WTR::TestController::statisticsFireDataModificationHandler):
1216         (WTR::TestController::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
1217         (WTR::TestController::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
1218         (WTR::TestController::setStatisticsMinimumTimeBetweeenDataRecordsRemoval):
1219         (WTR::TestController::statisticsResetToConsistentState):
1220         * WebKitTestRunner/TestController.h:
1221             These are all configuration and test functions.
1222         * WebKitTestRunner/TestInvocation.cpp:
1223         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1224
1225 2017-02-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1226
1227         REGRESSION(r182916) run-perf-tests never timeouts
1228         https://bugs.webkit.org/show_bug.cgi?id=167626
1229
1230         Reviewed by Ryosuke Niwa.
1231
1232         The --time-out-ms value (defaults to 600 seconds) of run-perf-tests
1233         was beeing ignored because the driver was created with no_timeout=True
1234         unconditionally.
1235         This adds a new parameter --no-timeout (disabled by default), that
1236         allows to use the driver with the expected timeout values.
1237         It also passes --no-timeout to DRT/WTR to ensure that timeouts
1238         are always controlled by the Python Driver.
1239
1240         * Scripts/webkitpy/performance_tests/perftest.py:
1241         (PerfTest._create_driver): Only disable timeout if --no-timeout is passed.
1242         (PerfTest.run): Disabling timeout should be done when the Driver is created.
1243         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1244         (PerfTestsRunner.__init__): Ensure --no-timeout is passed to DRT/WTR
1245         (PerfTestsRunner._parse_args): Add a --no-timeout parameter.
1246         (_run_tests_set): Pass the no-timeout parameter.
1247         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1248         (MainTest.test_drt_notimeout): Test --no-timeout is passed to DRT/WTR
1249         (MainTest.test_default_args): Test default values for additional_drt_flag and no_timeout.
1250         (MainTest.test_parse_args): Test that the argument no-timeout.
1251
1252 2017-02-10  Daniel Bates  <dabates@apple.com>
1253
1254         Detach frame from document when entering page cache
1255         https://bugs.webkit.org/show_bug.cgi?id=166774
1256         <rdar://problem/29904368>
1257
1258         Reviewed by Chris Dumez.
1259
1260         * DumpRenderTree/mac/DumpRenderTree.mm:
1261         (resetWebPreferencesToConsistentValues):
1262         * DumpRenderTree/win/DumpRenderTree.cpp:
1263         (resetWebPreferencesToConsistentValues):
1264         * WebKitTestRunner/TestController.cpp:
1265         (WTR::TestController::resetPreferencesToConsistentValues):
1266
1267 2017-02-10  Tim Horton  <timothy_horton@apple.com>
1268
1269         Infinite UI process hang under ensurePositionInformationIsUpToDate
1270         https://bugs.webkit.org/show_bug.cgi?id=168154
1271         <rdar://problem/30428673>
1272
1273         Reviewed by Simon Fraser.
1274
1275         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1276         * TestWebKitAPI/Tests/WebKit2Cocoa/InteractionDeadlockAfterCrash.mm: Added.
1277         (recursiveFindHighlightLongPressRecognizer):
1278         (TEST):
1279         Add a somewhat nasty test that does an async interaction information update, but
1280         kills the Web process before it arrives, and then does a sync interaction
1281         information update, which will wait for the oustanding async interaction
1282         information update if we still think it's coming. Before the patch, this
1283         test times out with the UI process stuck under ensurePositionInformationIsUpToDate.
1284
1285 2017-02-10  Simon Fraser  <simon.fraser@apple.com>
1286
1287         Make sure the "inwindow" flag propagates to TiledBackings for masks and reflections
1288         https://bugs.webkit.org/show_bug.cgi?id=168127
1289         rdar://problem/30467120
1290
1291         Reviewed by Tim Horton.
1292
1293         Reparent the web view before we try to fetch it via:
1294             [[[window contentView] subviews] objectAtIndex:0];
1295         which would throw an exception if the test unparented it.
1296
1297         * DumpRenderTree/mac/DumpRenderTree.mm:
1298         (resetWebViewToConsistentStateBeforeTesting):
1299         (runTest):
1300
1301 2017-02-10  Joseph Pecoraro  <pecoraro@apple.com>
1302
1303         [Resource Timing] Enable Resource Timing by default in Tests
1304         https://bugs.webkit.org/show_bug.cgi?id=168145
1305
1306         Reviewed by Ryosuke Niwa.
1307
1308         * DumpRenderTree/mac/DumpRenderTree.mm:
1309         (resetWebPreferencesToConsistentValues):
1310         * DumpRenderTree/win/DumpRenderTree.cpp:
1311         (resetWebPreferencesToConsistentValues):
1312         * WebKitTestRunner/TestController.cpp:
1313         (WTR::TestController::resetPreferencesToConsistentValues):
1314
1315 2017-02-10  Jonathan Bedard  <jbedard@apple.com>
1316
1317         Removing LayoutTestRelay
1318         https://bugs.webkit.org/show_bug.cgi?id=165927
1319
1320         Reviewed by Daniel Bates.
1321         Part 2
1322
1323         LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
1324         simulators through simctl (iOS 10 and later), use this functionality instead.
1325
1326         * BuildSlaveSupport/built-product-archive:
1327         (archiveBuiltProduct): Remove archiving of LayoutTestRelay as it is no longer being built.
1328         Added a FIXME that we will need to implement similar archiving machinery once we build
1329         ImageDiff for Mac when building WebKit for iOS. Currently ImageDiff is built with the iOS SDK.
1330         * BuildSlaveSupport/kill-old-processes:
1331         (main): Remove LayoutTestRelay from list of processes.
1332         * LayoutTestRelay: Removed LayoutTestRelay.
1333         * Makefile:
1334         * Scripts/build-layouttestrelay: Removed.
1335         * Scripts/build-webkit: Removed LayoutTestRelay references.
1336
1337 2017-02-10  Jiewen Tan  <jiewen_tan@apple.com>
1338
1339         [WebCrypto] Add WebCryptoAPI to watchlist
1340         https://bugs.webkit.org/show_bug.cgi?id=168138
1341
1342         Reviewed by Youenn Fablet.
1343
1344         * Scripts/webkitpy/common/config/watchlist:
1345
1346 2017-02-10  Brady Eidson  <beidson@apple.com>
1347
1348         Replace all WebKit Library Version checks in WK2 with SDK version checks.
1349         https://bugs.webkit.org/show_bug.cgi?id=168124
1350
1351         Reviewed by Geoffrey Garen.
1352
1353         For each of our tools that use WebKit2, opt them in to the new linkedOnOrAfter(Everything) setting.
1354         
1355         * MiniBrowser/mac/main.m:
1356         (main):
1357         * MobileMiniBrowser/MobileMiniBrowser/main.m:
1358         (main):
1359         * TestWebKitAPI/ios/mainIOS.mm:
1360         (main):
1361         * TestWebKitAPI/mac/mainMac.mm:
1362         (main):
1363         * WebKitTestRunner/ios/mainIOS.mm:
1364         (main):
1365         * WebKitTestRunner/mac/main.mm:
1366         (setDefaultsToConsistentValuesForTesting):
1367
1368 2017-02-10  Alex Christensen  <achristensen@webkit.org>
1369
1370         Fix El Capitan build.
1371
1372         * Scripts/build-webkit:
1373         Don't build libwebrtc anywhere for now.
1374
1375 2017-02-10  Andy Estes  <aestes@apple.com>
1376
1377         Move two MiniBrowserBundle settings out of the .pbxproj
1378         https://bugs.webkit.org/show_bug.cgi?id=168106
1379
1380         Reviewed by Tim Horton.
1381
1382         INFOPLIST_FILE was specified in MiniBrowserBundle.xcconfig but overridden to "" in
1383         the project file. This removes the project file override.
1384
1385         WRAPPER_EXTENSION was moved from the project file to MiniBrowserBundle.xcconfig.
1386
1387         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig:
1388         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1389
1390 2017-02-10  Alex Christensen  <achristensen@webkit.org>
1391
1392         Fix 32-and-64-bit build on El Capitan.
1393
1394         * Scripts/build-webkit:
1395         Somebody's building with something like this:
1396         build-webkit ARCHS="i386 x86_64"
1397         We want this to also not build libwebrtc for now.
1398
1399 2017-02-10  Alex Christensen  <achristensen@webkit.org>
1400
1401         Fix 32-bit build on El Capitan.
1402
1403         * Scripts/build-webkit:
1404         The bot uses ARCHS=i386 instead of --32-bit.
1405         This is a hack, but it should fix the bot until I can do a better fix in the morning.
1406
1407 2017-02-10  Alex Christensen  <achristensen@webkit.org>
1408
1409         Fix 32-bit build on El Capitan.
1410
1411         * Scripts/build-webkit:
1412         Don't build i386 libwebrtc.
1413
1414 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1415
1416         Unreviewed, rolling out r212040.
1417
1418         Broke build.  I'm not surprised
1419
1420         Reverted changeset:
1421
1422         "[WebRTC][Mac] Activate libwebrtc"
1423         https://bugs.webkit.org/show_bug.cgi?id=167293
1424         http://trac.webkit.org/changeset/212040
1425
1426 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1427
1428         Build libwebrtc on bots without using it yet
1429         https://bugs.webkit.org/show_bug.cgi?id=168062
1430
1431         Reviewed by Brent Fulgham.
1432
1433         * Scripts/build-webkit:
1434
1435 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1436
1437         Don't build libwebrtc.
1438
1439         * Scripts/build-webkit:
1440         Not ready yet.  It broke El Capitan and iOS.
1441
1442 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1443
1444         Build libwebrtc on bots without using it yet
1445         https://bugs.webkit.org/show_bug.cgi?id=168062
1446
1447         Reviewed by Brent Fulgham.
1448
1449         * Scripts/build-webkit:
1450
1451 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1452
1453         Rename isAppleMacWebKit to isAppleCocoaWebKit
1454         https://bugs.webkit.org/show_bug.cgi?id=168075
1455
1456         Reviewed by Geoffrey Garen.
1457
1458         It returns true for Mac and iOS.  "isAppleMacWebKit" is confusing and wrong.
1459
1460         * Scripts/build-api-tests:
1461         * Scripts/build-dumprendertree:
1462         * Scripts/build-jsc:
1463         (buildMyProject):
1464         * Scripts/build-layouttestrelay:
1465         * Scripts/build-webkit:
1466         * Scripts/build-webkittestrunner:
1467         * Scripts/run-api-tests:
1468         (isSupportedPlatform):
1469         (runTest):
1470         (listAllTests):
1471         (prepareEnvironmentForRunningTestTool):
1472         * Scripts/run-content-extension-tester:
1473         * Scripts/run-javascriptcore-tests:
1474         * Scripts/run-minibrowser:
1475         * Scripts/show-pretty-diff:
1476         * Scripts/webkitdirs.pm:
1477         (determineBaseProductDir):
1478         (determineArchitecture):
1479         (determinePassedArchitecture):
1480         (safariPath):
1481         (builtDylibPathForName):
1482         (checkFrameworks):
1483         (isAppleWebKit):
1484         (isAppleCocoaWebKit):
1485         (determineNmPath):
1486         (launcherName):
1487         (wrapperPrefixIfNeeded):
1488         (isCMakeBuild):
1489         (mobileSafariBundle):
1490         (debugSafari):
1491         (runSafari):
1492         (runMiniBrowser):
1493         (debugMiniBrowser):
1494         (runWebKitTestRunner):
1495         (debugWebKitTestRunner):
1496         (isAppleMacWebKit): Deleted.
1497         * Scripts/webkitperl/FeatureList.pm:
1498
1499 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1500
1501         Revert r211991
1502         https://bugs.webkit.org/show_bug.cgi?id=168062
1503
1504         * Scripts/build-webkit:
1505         Not quite ready yet.
1506
1507 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1508
1509         Build libwebrtc on bots without using it yet
1510         https://bugs.webkit.org/show_bug.cgi?id=168062
1511
1512         Reviewed by Brent Fulgham.
1513
1514         * Scripts/build-webkit:
1515         Build libwebrtc on Mac when we build ANGLE.
1516
1517 2017-02-09  Youenn Fablet  <youenn@apple.com>
1518
1519         Improve W3C importer command line options
1520         https://bugs.webkit.org/show_bug.cgi?id=167448
1521
1522         Reviewed by Ryosuke Niwa.
1523
1524         Making the list of test paths to import the main arguments of the script.
1525         Allow passing the source directory to import as a -s option.
1526         Adding a warning when given test paths are skipped by default in ImportExpectations.
1527
1528         Making link conversion off by default when importing from a specific directory since this script is mostly used with web-platform-tests.
1529         Link conversion rules do not change when imported tests are downloaded by the script.
1530
1531         * Scripts/webkitpy/w3c/test_importer.py:
1532         (main):
1533         (parse_args):
1534         (TestImporter.__init__):
1535         (TestImporter.do_import):
1536         (TestImporter):
1537         (TestImporter.check_imported_expectations):
1538
1539 2017-02-08  Chris Dumez  <cdumez@apple.com>
1540
1541         Update web-platform-tests resources
1542         https://bugs.webkit.org/show_bug.cgi?id=168026
1543
1544         Reviewed by Youenn Fablet.
1545
1546         Stop copying testharness.js from resources/ to web-platform-tests/resources.
1547
1548         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1549         (WebPlatformTestServer._copy_webkit_test_files):
1550
1551 2017-02-08  Andy Estes  <aestes@apple.com>
1552
1553         Custom protocols should not continue loading after a network process crash
1554         https://bugs.webkit.org/show_bug.cgi?id=168028
1555         <rdar://problem/27607520>
1556
1557         Reviewed by Brady Eidson.
1558
1559         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1560         (processGroup):
1561         (-[CloseWhileStartingProtocol startLoading]):
1562         (-[CloseWhileStartingProtocol stopLoading]):
1563         (TestWebKitAPI::runTest):
1564         (TestWebKitAPI::TEST):
1565
1566 2017-02-08  Dan Bernstein  <mitz@apple.com>
1567
1568         [Cocoa] WKRemoteObjectCoder doesn’t handle CGSize
1569         https://bugs.webkit.org/show_bug.cgi?id=168031
1570
1571         Reviewed by Tim Horton.
1572
1573         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
1574         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
1575         (TEST):
1576         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
1577         (-[RemoteObjectRegistryPlugIn takeSize:completionHandler:]):
1578
1579 2017-02-08  Chris Dumez  <cdumez@apple.com>
1580
1581         Use smaller tiles in windows that are not active to facilitate App Napping
1582         https://bugs.webkit.org/show_bug.cgi?id=167997
1583         <rdar://problem/30358835>
1584
1585         Reviewed by Simon Fraser.
1586
1587         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1588         (WTR::PlatformWebView::setWindowIsKey):
1589         Actually update windowIsKey state of NSWindow so the WebView
1590         properly updates its activity state.
1591
1592 2017-02-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1593
1594         Add kUTTypeUTF8PlainText and kUTTypeJPEG to the list of compatible content types in DragData
1595         https://bugs.webkit.org/show_bug.cgi?id=167942
1596         <rdar://problem/30315079>
1597
1598         Reviewed by Tim Horton.
1599
1600         Adds a new test case that simulates dragging from a source that only vends JPEG images or UTF8 plaintext into a
1601         contenteditable area. An image element and the plain text content, respectively, should be inserted into the
1602         contenteditable in these cases.
1603
1604         The DragSource and DragInfo are used to mock dragging into the WebView. There is no reliance on using mouse
1605         events in this test, since we call the dragging delegate methods (draggingEntered:, draggingUpdated:, and
1606         performDragOperation:) directly.
1607
1608         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1609         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm: Added.
1610         (+[FrameLoadCompletionListener listenerWithCompletionBlock:]):
1611         (-[FrameLoadCompletionListener initWithCompletionBlock:]):
1612         (-[FrameLoadCompletionListener webView:didFinishLoadForFrame:]):
1613         (-[DragSource draggingSourceOperationMaskForLocal:]):
1614         (-[DragInfo initWithImage:offset:pasteboard:source:destinationWindow:]):
1615         (-[DragInfo lastMousePosition]):
1616         (-[DragInfo setLastMousePosition:]):
1617         (-[DragInfo draggingDestinationWindow]):
1618         (-[DragInfo draggingSourceOperationMask]):
1619         (-[DragInfo draggingLocation]):
1620         (-[DragInfo draggedImageLocation]):
1621         (-[DragInfo draggedImage]):
1622         (-[DragInfo draggingPasteboard]):
1623         (-[DragInfo draggingSource]):
1624         (-[DragInfo draggingSequenceNumber]):
1625         (-[DragInfo slideDraggedImageTo:]):
1626         (-[DragInfo namesOfPromisedFilesDroppedAtDestination:]):
1627         (-[DragInfo draggingFormation]):
1628         (-[DragInfo setDraggingFormation:]):
1629         (-[DragInfo animatesToDestination]):
1630         (-[DragInfo setAnimatesToDestination:]):
1631         (-[DragInfo numberOfValidItemsForDrop]):
1632         (-[DragInfo setNumberOfValidItemsForDrop:]):
1633         (-[DragInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1634         (-[DragInfo springLoadingHighlight]):
1635         (-[DragInfo resetSpringLoading]):
1636         (TestWebKitAPI::getTestImage):
1637         (TestWebKitAPI::webViewAfterPerformingDragOperation):
1638         (TestWebKitAPI::TEST):
1639         * TestWebKitAPI/Tests/mac/full-page-contenteditable.html: Added.
1640
1641 2017-02-08  Jer Noble  <jer.noble@apple.com>
1642
1643         Move FullscreenClient creation into WebViewImpl, for use in (deprecated) WKView.
1644         https://bugs.webkit.org/show_bug.cgi?id=168007
1645
1646         Reviewed by Alex Christensen.
1647
1648         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenDelegate.mm:
1649         (didFinishLoadForFrame):
1650         (TestWebKitAPI::TEST):
1651
1652 2017-02-08  Commit Queue  <commit-queue@webkit.org>
1653
1654         Unreviewed, rolling out r211873.
1655         https://bugs.webkit.org/show_bug.cgi?id=168001
1656
1657         It's in jhbuild for consistent layout tests (Requested by
1658         mcatanzaro on #webkit).
1659
1660         Reverted changeset:
1661
1662         "[GTK] Add icu packages to Tools/gtk/install-dependencies"
1663         https://bugs.webkit.org/show_bug.cgi?id=167993
1664         http://trac.webkit.org/changeset/211873
1665
1666 2017-02-08  Adrian Perez de Castro  <aperez@igalia.com>
1667
1668         [GTK] Add icu packages to Tools/gtk/install-dependencies
1669         https://bugs.webkit.org/show_bug.cgi?id=167993
1670
1671         Reviewed by Michael Catanzaro.
1672
1673         * gtk/install-dependencies: Add "icu" to the list of required packages (or "icu-dev", or "icu-devel"
1674         depending in the GNU/Linux distribution)
1675
1676 2017-02-07  Ryan Haddad  <ryanhaddad@apple.com>
1677
1678         Update flakiness dashboard configuration.
1679         https://bugs.webkit.org/show_bug.cgi?id=167957
1680
1681         Reviewed by Alexey Proskuryakov.
1682
1683         * TestResultServer/static-dashboards/builders.jsonp:
1684
1685 2017-02-07  Ryan Haddad  <ryanhaddad@apple.com>
1686
1687         Replace a bot that has an incorrect configuration.
1688         https://bugs.webkit.org/show_bug.cgi?id=167747
1689
1690         Rubber-stamped by Alexey Proskuryakov.
1691
1692         * BuildSlaveSupport/build.webkit.org-config/config.json:
1693
1694 2017-02-07  Myles C. Maxfield  <mmaxfield@apple.com>
1695
1696         [Win] [GTK] [EFL] Compile (but don't use, yet) the platform-independent piece of ComplexTextController
1697         https://bugs.webkit.org/show_bug.cgi?id=167927
1698
1699         Reviewed by Brent Fulgham.
1700
1701         Enable ComplexTextController API tests on the Win and GTK ports.
1702
1703         * TestWebKitAPI/PlatformGTK.cmake:
1704         * TestWebKitAPI/PlatformWin.cmake:
1705
1706 2017-02-07  Jonathan Bedard  <jbedard@apple.com>
1707
1708         File index appended to previous file in svn-create-patch with SVN 1.9
1709         https://bugs.webkit.org/show_bug.cgi?id=167903
1710         <rdar://problem/30387395>
1711
1712         Reviewed by Daniel Bates.
1713
1714         * Scripts/VCSUtils.pm:
1715         (fixSVNPatchForAdditionWithHistory): Append a trailing newline character.
1716         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Do not remove
1717         trailing newline character from the expected result before comparing it to the actual result.
1718
1719 2017-02-07  Olivier Blin  <olivier.blin@softathome.com>
1720
1721         [webkitdirs] remove unused host_processor variable in determineArchitecture()
1722         https://bugs.webkit.org/show_bug.cgi?id=167936
1723
1724         Reviewed by Michael Catanzaro.
1725
1726         * Scripts/webkitdirs.pm:
1727         (determineArchitecture):
1728         The host_processor variable in webkitdirs.pm's determineArchitecture() is not used anymore,
1729         since r195083.
1730
1731 2017-02-07  Youenn Fablet  <youenn@apple.com>
1732
1733         Use a JSON file to define which WPT files/folders to import
1734         https://bugs.webkit.org/show_bug.cgi?id=167923
1735
1736         Reviewed by Alex Christensen.
1737
1738         * Scripts/webkitpy/w3c/test_downloader.py:
1739         (TestDownloader.__init__):
1740         (TestDownloader._init_paths_from_expectations):
1741         * Scripts/webkitpy/w3c/test_importer.py:
1742         (parse_args):
1743         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1744
1745 2017-02-06  Fujii Hironori  <Hironori.Fujii@sony.com>
1746
1747         [GTK] jhbuild fails: mesa-11.0.6.tar.xz: 404 Not Found
1748         https://bugs.webkit.org/show_bug.cgi?id=167916
1749
1750         Reviewed by Carlos Garcia Campos.
1751
1752         URL of mesa-11.0.6.tar.xz has been moved.
1753
1754         * gtk/jhbuild.modules: Fix the module path.
1755
1756 2017-02-06  Joseph Pecoraro  <pecoraro@apple.com>
1757
1758         Static Analyzer: Address some leaks in MiniBrowser
1759         https://bugs.webkit.org/show_bug.cgi?id=167897
1760
1761         Reviewed by Alexey Proskuryakov.
1762
1763         * MiniBrowser/mac/BrowserWindowController.m:
1764         (-[BrowserWindowController sharingService:transitionImageForShareItem:contentRect:]):
1765         * MiniBrowser/mac/ExtensionManagerWindowController.m:
1766         (-[ExtensionManagerWindowController add:]):
1767         (-[ExtensionManagerWindowController remove:]):
1768         * MiniBrowser/mac/SettingsController.m:
1769         (-[SettingsController _populateMenu]):
1770         (-[SettingsController togglePerWindowWebProcessesDisabled:]):
1771         Address obvious leaks caught by the static analyzer.
1772
1773 2017-02-06  Myles C. Maxfield  <mmaxfield@apple.com>
1774
1775         Migrate ComplexTextController to use platform-independent types
1776         https://bugs.webkit.org/show_bug.cgi?id=167833
1777
1778         Reviewed by Brent Fulgham.
1779
1780         Migrate tests away from platform-dependent types.
1781
1782         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
1783         (TestWebKitAPI::TEST_F):
1784
1785 2017-02-06  Brent Fulgham  <bfulgham@apple.com>
1786
1787         Correct File Path Handling in SecurityOrigin and FileSystem
1788         https://bugs.webkit.org/show_bug.cgi?id=167894
1789         <rdar://problem/30380080>
1790
1791         Reviewed by Alexey Proskuryakov.
1792
1793         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp: Don't encode the temporary files,
1794         and perform same-volume checks using filesystem-compatible paths.        
1795         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Create SecurityOrigins from
1796         filesystem paths, and perform validation of same-volume checks.
1797         (TestWebKitAPI::SecurityOriginTest::tempFilePath): Added.
1798         (TestWebKitAPI::SecurityOriginTest::spaceContainingFilePath): Added.
1799         (TestWebKitAPI::SecurityOriginTest::bangContainingFilePath): Added.
1800         (TestWebKitAPI::SecurityOriginTest::quoteContainingFilePath): Added.
1801
1802 2017-02-06  Jer Noble  <jer.noble@apple.com>
1803
1804         Playback stalls when a SourceBuffer append causes frame eviction
1805         https://bugs.webkit.org/show_bug.cgi?id=167834
1806
1807         Reviewed by Eric Carlson.
1808
1809         Add new correctness tests for the Webcore::SampleMap class. Add additional subtests
1810         for the WTF::MediaTime class.
1811
1812         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1813         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
1814         (TestWebKitAPI::TEST):
1815         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp: Added.
1816         (WTF::operator<<):
1817         (TestWebKitAPI::TestSample::create):
1818         (TestWebKitAPI::TestSample::TestSample):
1819         (TestWebKitAPI::TEST_F):
1820
1821 2017-02-06  Ryan Haddad  <ryanhaddad@apple.com>
1822
1823         Change capitalization in platform name after r211735.
1824
1825         Unreviewed dashboard fix.
1826
1827         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1828         (WebKitBuildbot):
1829
1830 2017-02-06  Alexey Proskuryakov  <ap@apple.com>
1831
1832         Move the Leaks bot to Sierra
1833         https://bugs.webkit.org/show_bug.cgi?id=167886
1834
1835         Reviewed by Daniel Bates.
1836
1837         * BuildSlaveSupport/build.webkit.org-config/config.json:
1838         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1839         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
1840         (LeaksViewer._displayURLPrompt):
1841         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1842         (WebKitBuildbot):
1843
1844 2017-02-06  Jonathan Bedard  <jbedard@apple.com>
1845
1846         Prevent app crash on launch during simctl install workaround
1847         https://bugs.webkit.org/show_bug.cgi?id=167685
1848
1849         Reviewed by Daniel Bates.
1850
1851         * Scripts/webkitpy/port/simulator_process.py:
1852         (SimulatorProcess.__init__): Pass environment to install.
1853         * Scripts/webkitpy/xcode/simulator.py:
1854         (Device.install_app): Accept environment, pass environment to launch.
1855
1856 2017-02-06  Alex Christensen  <achristensen@webkit.org>
1857
1858         Rebase API tests after r211638
1859         https://bugs.webkit.org/show_bug.cgi?id=167779
1860
1861         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1862         (TestWebKitAPI::TEST_F):
1863         URLs with non-special schemes and characters like % in the host now fail to parse,
1864         more like their special counterparts and according to spec.
1865
1866 2017-02-06  Csaba Osztrogonác  <ossy@webkit.org>
1867
1868         Unreviewed trivial fix after r211697.
1869         https://bugs.webkit.org/show_bug.cgi?id=167863
1870
1871         * Scripts/run-javascriptcore-tests:
1872         (runJSCStressTests): Renamed ES6SampleBench to ARES-6.
1873
1874 2017-02-04  Simon Fraser  <simon.fraser@apple.com>
1875
1876         Clean up how GraphicsLayer's "inWindow" state is set, and fix some issues with Page Overlays
1877         https://bugs.webkit.org/show_bug.cgi?id=167850
1878
1879         Reviewed by Tim Horton.
1880
1881         * DumpRenderTree/TestRunner.cpp:
1882         (TestRunner::uiScriptDidComplete): Fix an assertion that fires for non-16-bit strings.
1883
1884 2017-02-04  Andreas Kling  <akling@apple.com>
1885
1886         Plug some leaks in TestController and UIScriptContext.
1887         <https://webkit.org/b/167839>
1888
1889         Reviewed by Alexey Proskuryakov.
1890
1891         Fix a couple of the leaks seen on the leaks bot.
1892
1893         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
1894         (UIScriptContext::runUIScript):
1895         * WebKitTestRunner/TestController.cpp:
1896         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin):
1897         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
1898
1899 2017-02-03  Jeremy Jones  <jeremyj@apple.com>
1900
1901         WK1 mouse events are missing movementX and movementY for pointerlock.
1902         https://bugs.webkit.org/show_bug.cgi?id=167775
1903         rdar://problem/30343810
1904
1905         Reviewed by Alexey Proskuryakov.
1906
1907         Set kCGMouseEventDeltaX and kCGMouseEventDeltaY when synthesizing mouse move events.
1908
1909         * DumpRenderTree/mac/EventSendingController.mm:
1910         (-[EventSendingController mouseMoveToX:Y:]):
1911         * WebKitTestRunner/mac/EventSenderProxy.mm:
1912         (WTR::EventSenderProxy::mouseMoveTo):
1913
1914 2017-02-03  Simon Fraser  <simon.fraser@apple.com>
1915
1916         Correctly set the "inWindow" flag for TileControllers that aren't the page tiles, and clarify "usingTiledBacking" logic
1917         https://bugs.webkit.org/show_bug.cgi?id=167774
1918
1919         Reviewed by Tim Horton.
1920
1921         Implement UIScriptController removeViewFromWindow() and addViewToWindow(), and hook
1922         up for Mac WK1 and WK2, and iOS WK2. It takes a callback because view state updates to the
1923         web process are async, so the callback fires after the web process gets the new state.
1924
1925         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1926         (WTR::UIScriptController::removeViewFromWindow):
1927         (WTR::UIScriptController::addViewToWindow):
1928         * DumpRenderTree/mac/DumpRenderTree.mm:
1929         (createWebViewAndOffscreenWindow):
1930         (resetWebViewToConsistentStateBeforeTesting):
1931         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1932         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1933         (WTR::UIScriptController::removeViewFromWindow):
1934         (WTR::UIScriptController::addViewToWindow):
1935         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1936         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1937         (WTR::UIScriptController::removeViewFromWindow):
1938         (WTR::UIScriptController::addViewToWindow):
1939         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1940         * WebKitTestRunner/PlatformWebView.h:
1941         * WebKitTestRunner/TestController.cpp:
1942         (WTR::TestController::resetStateToConsistentValues):
1943         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1944         (WTR::PlatformWebView::removeFromWindow):
1945         (WTR::PlatformWebView::addToWindow):
1946         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1947         (WTR::UIScriptController::removeViewFromWindow):
1948         (WTR::UIScriptController::addViewToWindow):
1949         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1950         (WTR::PlatformWebView::removeFromWindow):
1951         (WTR::PlatformWebView::addToWindow):
1952         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1953         (WTR::UIScriptController::removeViewFromWindow):
1954         (WTR::UIScriptController::addViewToWindow):
1955
1956 2017-02-03  Alexey Proskuryakov  <ap@apple.com>
1957
1958         Remove check for SkipSafariExecutableEntitlementChecks
1959         https://bugs.webkit.org/show_bug.cgi?id=167762
1960
1961         Reviewed by Dan Bernstein.
1962
1963         Follow-up fix: don't break internal behavior.
1964
1965         * Scripts/webkitdirs.pm:
1966         (safariPath):
1967         (executableHasEntitlements): Deleted.
1968         (safariPathFromSafariBundle): Deleted.
1969         (installedSafariPath): Deleted.
1970
1971 2017-02-03  Daniel Bates  <dabates@apple.com>
1972
1973         [Mac][WK2] Add SPI to override the Content Security Policy of a page
1974         https://bugs.webkit.org/show_bug.cgi?id=167810
1975         <rdar://problem/30102568>
1976
1977         Reviewed by Anders Carlsson.
1978
1979         Add tests to ensure that we do not regress -[WKWebView _setOverrideContentSecurityPolicy:].
1980
1981         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1982         * TestWebKitAPI/Tests/WebKit2Cocoa/OverrideContentSecurityPolicy.mm: Added.
1983         (TEST):
1984         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp-iframe.html: Added.
1985         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp.html: Added.
1986         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp-iframe.html: Added.
1987         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp.html: Added.
1988
1989 2017-02-02  Alex Christensen  <achristensen@webkit.org>
1990
1991         URLParser: Fix parsing invalid IPv4 addresses with non-ASCII characters
1992         https://bugs.webkit.org/show_bug.cgi?id=167773
1993         <rdar://problem/30221102>
1994
1995         Reviewed by Ryosuke Niwa.
1996
1997         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1998         (TestWebKitAPI::TEST_F):
1999
2000 2017-02-02  Alexey Proskuryakov  <ap@apple.com>
2001
2002         Remove check for SkipSafariExecutableEntitlementChecks
2003         https://bugs.webkit.org/show_bug.cgi?id=167762
2004         rdar://problem/22480673
2005
2006         Reviewed by Dan Bernstein.
2007
2008         * Scripts/webkitdirs.pm:
2009         (safariPathFromSafariBundle):
2010         (skipSafariExecutableEntitlementChecks): Deleted.
2011
2012 2017-02-02  Jonathan Bedard  <jbedard@apple.com>
2013
2014         Undefined subroutine in svn-create-patch
2015         https://bugs.webkit.org/show_bug.cgi?id=167742
2016
2017         Unreviewed build-fix after r211543.
2018
2019         * Scripts/VCSUtils.pm: fixSVNPatchForAdditionWithHistory was not exported.
2020
2021 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2022
2023         Unreviewed. Fix jhbuild dependencies build.
2024
2025         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch:
2026         Patch updated.
2027
2028 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2029
2030         [EME][GStreamer] Fixed decryptor selection
2031         https://bugs.webkit.org/show_bug.cgi?id=167588
2032
2033         Reviewed by Žan Doberšek.
2034
2035         This patches are pending at https://bugzilla.gnome.org/show_bug.cgi?id=770107
2036
2037         * gtk/jhbuild.modules: Added patches to gstreamer and
2038         gst-plugins-good packages.
2039         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch: Added.
2040         * gtk/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
2041
2042 2017-02-01  Dewei Zhu  <dewei_zhu@apple.com>
2043
2044         Make run-benchmark script supports 'config' key in test plan.
2045         https://bugs.webkit.org/show_bug.cgi?id=167715
2046
2047         Reviewed by Ryosuke Niwa.
2048
2049         Add support for 'config' key in test paln.
2050         'config' key is a dictionary that specifies environment configurations while test is running.
2051         Specifies orientation to be portrait in MotionMark benchmark.
2052
2053         * Scripts/webkitpy/benchmark_runner/README.md:
2054         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2055         (BenchmarkRunner.__init__):
2056         (BenchmarkRunner._run_benchmark):
2057         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2058         (BrowserDriver.prepare_env):
2059         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
2060         (LinuxBrowserDriver.prepare_env):
2061         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2062         (OSXBrowserDriver.prepare_env):
2063         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2064         (OSXSafariDriver.prepare_env):
2065         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
2066
2067 2017-02-01  Daniel Bates  <dabates@apple.com>
2068
2069         REGRESSION (r210820): svn-create-patch does not emit property change only diff
2070         https://bugs.webkit.org/show_bug.cgi?id=167169
2071
2072         Reviewed by David Kilzer.
2073
2074         More directly handle the SVN 1.9 or newer syntax change for a diff of a copied or moved file
2075         - a SVN diff header and an empty body. In particular, remove a duplicate leading SVN diff
2076         header from the output of "svn diff" on a file that was copied or moved.
2077
2078         Following r210820 svn-create-patch emits to standard output a diff only if it has at least one
2079         chunk range line (e.g. @@ -0,0 +1,7 @@) as a means to workaround a syntax change in the diff
2080         output of a copied or moved file in SVN version 1.9 or newer. In SVN 1.9 or newer "svn diff"
2081         of a copied or moved file always emits to standard output a leading SVN diff header (an "Index:"
2082         line followed by a separator line) with an empty body; => no chunk range lines. However a diff
2083         of a file with only a property change also does not contain any chunk range lines. Therefore
2084         svn-create-patch no longer emitted to standard output such a diff. Instead of indirectly detecting
2085         a SVN diff header with an empty body by counting the number of chunk range lines in the diff
2086         we should directly test for the presence of a leading SVN diff header with an empty body and
2087         remove such lines from the diff.
2088
2089         * Scripts/VCSUtils.pm:
2090         (fixSVNPatchForAdditionWithHistory): Added.
2091         * Scripts/svn-create-patch:
2092         (generateDiff): Pass the output from "svn diff" to fixSVNPatchForAdditionWithHistory() when
2093         we have a non empty patch for an added file with history (i.e. a copied or moved file).
2094         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Added.
2095
2096 2017-02-01  Eric Carlson  <eric.carlson@apple.com>
2097
2098         [Mac] Update CARingBuffer class
2099         https://bugs.webkit.org/show_bug.cgi?id=167656
2100
2101         Reviewed by Jer Noble.
2102
2103         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2104         * TestWebKitAPI/Tests/WebCore/CARingBuffer.cpp: Added.
2105         (TestWebKitAPI::CARingBufferTest::SetUp):
2106         (TestWebKitAPI::CARingBufferTest::setup):
2107         (TestWebKitAPI::CARingBufferTest::setListDataBuffer):
2108         (TestWebKitAPI::CARingBufferTest::description):
2109         (TestWebKitAPI::CARingBufferTest::bufferList):
2110         (TestWebKitAPI::CARingBufferTest::ringBuffer):
2111         (TestWebKitAPI::CARingBufferTest::capacity):
2112         (TestWebKitAPI::CARingBufferTest::audioBufferListSizeForStream):
2113         (TestWebKitAPI::CARingBufferTest::configureBufferListForStream):
2114         (TestWebKitAPI::TEST_F):
2115         (TestWebKitAPI::MixingTest::run):
2116
2117 2017-02-01  Alexey Proskuryakov  <ap@apple.com>
2118
2119         [Mac] TestWebKitAPI includes system frameworks incorrectly
2120         https://bugs.webkit.org/show_bug.cgi?id=167703
2121         rdar://problem/30301498
2122
2123         Reviewed by Ryosuke Niwa.
2124
2125         FRAMEWORK_SEARCH_PATH results in frameworks being treated as user ones, not system.
2126         Make TestWebKitAPI use -iframework instead, like the rest of WebKit does.
2127
2128         Also, reduced the number of subframework search paths, looks like we only need one now.
2129
2130         * TestWebKitAPI/Configurations/Base.xcconfig:
2131
2132 2017-02-01  Brent Fulgham  <bfulgham@apple.com>
2133
2134         Correct "filesHaveSameVolume" predicate
2135         https://bugs.webkit.org/show_bug.cgi?id=167696
2136         <rdar://problem/30298722>
2137
2138         Reviewed by David Kilzer.
2139
2140         Add new tests that confirm that the 'filesHaveSamePath' predicate properly handles
2141         percent-escaped path inputs.
2142
2143         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
2144         (TestWebKitAPI::FileSystemTest::spaceContainingFilePath):
2145         (TestWebKitAPI::FileSystemTest::bangContainingFilePath):
2146         (TestWebKitAPI::FileSystemTest::quoteContainingFilePath):
2147         (TestWebKitAPI::TEST_F):
2148
2149 2017-02-01  Tomas Popela  <tpopela@redhat.com>
2150
2151         Unreviewed. Fix coding style in MiniBrowser
2152
2153         * MiniBrowser/gtk/BrowserWindow.c:
2154         (editingCommandCallback):
2155         (insertImageCommandCallback):
2156         (insertLinkCommandCallback):
2157
2158 2017-02-01  Tomas Popela  <tpopela@redhat.com>
2159
2160         [GTK] Add an API to add a custom tab into the print dialog
2161         https://bugs.webkit.org/show_bug.cgi?id=151998
2162
2163         Reviewed by Carlos Garcia Campos.
2164
2165         Add a new WebKitPrintOperation/custom-widget test in TestPrinting
2166         that is testing a newly added API.
2167
2168         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
2169         (testPrintCustomWidget):
2170         (beforeAll):
2171
2172 2017-02-01  Enrique Ocaña González  <eocanha@igalia.com>
2173
2174         [GStreamer][MSE] qtdemux: Update the tfdt patch to the version finally accepted upstream
2175         https://bugs.webkit.org/show_bug.cgi?id=166529
2176
2177         Reviewed by Xabier Rodriguez-Calvar.
2178
2179         * gtk/patches/gst-plugins-good-use-the-tfdt-decode-time.patch:
2180         New patch version accepted in GStreamer upstream.
2181
2182 2017-02-01  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2183
2184         [GTK] Install either libxfont1-dev or libxfont-dev as dependency
2185         https://bugs.webkit.org/show_bug.cgi?id=167498
2186
2187         Reviewed by Carlos Garcia Campos.
2188
2189         Depending on the distro version you can need either libxfont1-dev
2190         or libfont-dev to build with jhbuild.
2191
2192         * gtk/install-dependencies:
2193
2194 2017-01-31  Ryan Haddad  <ryanhaddad@apple.com>
2195
2196         Disable API test WebKit2.WKWebProcessPlugInRangeHandle
2197         https://bugs.webkit.org/show_bug.cgi?id=167594
2198
2199         Unreviewed test gardening.
2200
2201         Disabling this test while we investigate the cause of a timeout on ios-simulator.
2202
2203         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
2204         (TEST):
2205
2206 2017-01-31  Filip Pizlo  <fpizlo@apple.com>
2207
2208         Move slow-running microbenchmarks out of JSTests/microbenchmarks
2209         https://bugs.webkit.org/show_bug.cgi?id=167676
2210
2211         Reviewed by Saam Barati.
2212
2213         * Scripts/run-javascriptcore-tests:
2214         (runJSCStressTests): Add slowMicrobenchmarks.yaml.
2215
2216 2017-01-31  Megan Gardner  <megan_gardner@apple.com>
2217
2218         Make Dump Render Tree not crash
2219         https://bugs.webkit.org/show_bug.cgi?id=167667
2220
2221         DumpRenderTree is crashing when running WK2 tests that it's not supposed to be running. 
2222         DumpRenderTree uses RunLoop::main.dispatch(), but that crashes because it's not set up on iOS.
2223         So we're making use of RunWebThread, which is the correct thing to do on iOS, and it doesn't crash.
2224         This does not fix any tests, it just fixes the crash.
2225         
2226         Reviewed by Simon Fraser.
2227
2228         * DumpRenderTree/TestRunner.cpp:
2229         (TestRunner::callUIScriptCallback):
2230
2231 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
2232
2233         Workaround for simctl install failing to report install failure
2234         https://bugs.webkit.org/show_bug.cgi?id=167654
2235
2236         Reviewed by Daniel Bates.
2237
2238         simctl install will sometimes report success even though install has failed.
2239         To workaround this bug, we attempt an app launch after install to ensure
2240         install has succeeded.
2241
2242         * Scripts/webkitpy/xcode/simulator.py:
2243         (Device.install_app): Attempt app launch after install, retry install if launch fails.
2244         (Device.launch_app): Correct comment.
2245
2246 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
2247
2248         Unreviewed webkitpy fix after r211405.
2249
2250         * Scripts/webkitpy/xcode/simulator.py:
2251         (Device.launch_app): Remove @staticmethod on _log_debug_error.
2252
2253 2017-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2254
2255         Unreviewed. Do not include libwebrtc and qunit in GTK+ tarballs.
2256
2257         * gtk/manifest.txt.in:
2258
2259 2017-01-31  Chris Fleizach  <cfleizach@apple.com>
2260
2261         AX: enable search predication for iOS
2262         https://bugs.webkit.org/show_bug.cgi?id=167558
2263         <rdar://problem/30251367>
2264
2265         Reviewed by Joanmarie Diggs.
2266
2267         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2268         (AccessibilityUIElement::uiElementForSearchPredicate):
2269         * DumpRenderTree/mac/AccessibilityCommonMac.h:
2270         * DumpRenderTree/mac/AccessibilityCommonMac.mm:
2271         (searchPredicateParameterizedAttributeForSearchCriteria):
2272         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2273         (searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
2274         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2275         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
2276         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2277         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:
2278         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm:
2279         (WTR::searchPredicateParameterizedAttributeForSearchCriteria):
2280         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2281         (WTR::searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
2282         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2283
2284 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
2285
2286         Workaround for simctl launch bug
2287         https://bugs.webkit.org/show_bug.cgi?id=167613
2288
2289         Reviewed by Daniel Bates.
2290
2291         simctl launch will sometimes fail because of a race condition when many
2292         simulators are being run simultaneously. These failures will always have
2293         an exit code of 1. This change attempts to launch an app multiple times
2294         before reporting a failure to workaround this bug.
2295
2296         * Scripts/webkitpy/xcode/simulator.py:
2297         (Device.launch_app): Execute multiple launch attempts, better logging of failures.
2298
2299 2017-01-30  Alexey Proskuryakov  <ap@apple.com>
2300
2301         Commit queue fails to look at real name aliases for the reviewer
2302         https://bugs.webkit.org/show_bug.cgi?id=167422
2303
2304         Reviewed by Joseph Pecoraro.
2305
2306         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2307         (test_has_valid_reviewer): Added tests.
2308
2309         * Scripts/webkitpy/common/config/committers.py:
2310         (CommitterList._name_to_contributor_map):
2311         Made _name_to_contributor_map include alias names.
2312
2313         * Scripts/webkitpy/common/config/committers_unittest.py:
2314         (CommittersTest.test_contributors_by_fuzzy_match):
2315         Removed subtests that are now obsolete, as these matches are strict. It is not
2316         obvious if distance based fuzzy matching for names is useful at all, but we can
2317         look into that some other time.
2318
2319 2017-01-30  Aakash Jain  <aakash_jain@apple.com>
2320
2321         QueueStatusServer should have an explicit timeout for _fetch_url
2322         https://bugs.webkit.org/show_bug.cgi?id=167467
2323
2324         Reviewed by Alexey Proskuryakov.
2325
2326         * Scripts/webkitpy/common/net/statusserver.py:
2327         (StatusServer._fetch_url): Add an explicit timeout of 300s.
2328
2329 2017-01-30  Kocsen Chung  <kocsen_chung@apple.com>
2330
2331         Add support for Trac instances that host multiple projects.
2332         https://bugs.webkit.org/show_bug.cgi?id=167524
2333
2334         Reviewed by Alexey Proskuryakov.
2335
2336         When multiple projects are hosted on a single Trac instance, the current
2337         behavior will retrieve changesets from all tracked projects.
2338         This patch teaches Trac.js to get project-specific changesets from Trac.
2339         We do this by replacing the parameter `changeset=on` to `repo-projectname=on`
2340         when querying the Trac timeline.
2341
2342         To tell Trac to be aware of multi-project instances we leverage the 
2343         `options` parameter when creating a new instance: 
2344
2345             new Trac("https://mytrac.com/", { projectIdentifier: "tracProjectName" });
2346
2347         If this option is not provided, the original behaviour will prevail.
2348         Additionally, add corresponding tests.
2349
2350         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
2351         (Trac): Reason about new optional parameter 'projectIdentifier'.
2352         (Trac.prototype.revisionURL): Given a projectIdentifier, append it to the end of the URL.
2353         (Trac.prototype._xmlTimelineURL): Given a projectIdentifier,
2354         replace default parameter `changeset=on` with `repo-projectname=on`.
2355         (Trac.prototype._convertCommitInfoElementToObject): Fix missing ';'.
2356         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js:
2357         (MockTrac): Add support for instantiating Trac with a projectIdentifier.
2358         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
2359         (setup): Provide a multiple-project MockTrac instance to all test cases for testing.
2360         Add the following tests:
2361             test("revisionURL")
2362             test("revisionURL with Trac Identifier")
2363             test("_xmlTimelineURL")
2364             test("_xmlTimelineURL with Trac Identifier")
2365         (this.view._latestProductiveIteration): Fix missing ';'.
2366
2367 2017-01-30  Myles C. Maxfield  <mmaxfield@apple.com>
2368
2369         Correct spacing regression on inter-element complex path shaping on some fonts
2370         https://bugs.webkit.org/show_bug.cgi?id=166013
2371
2372         Reviewed by Simon Fraser.
2373
2374         Unskip existing tests and make some new tests:
2375         - Testing complex text with no origins
2376         - Testing initial expansions
2377         - Testing the sign of vertical advances
2378
2379         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
2380         (TestWebKitAPI::TEST_F):
2381
2382 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2383
2384         [GTK][EFL] Avoid using a thin directory to create the built product on the archive-built-product step.
2385         https://bugs.webkit.org/show_bug.cgi?id=167596
2386
2387         Reviewed by Daniel Bates.
2388
2389         We avoid needing a thin directory by invoking the zip program with
2390         the list of directories from the build directory to be zipped,
2391         and by using the zip feature to exclude files matching a pattern.
2392
2393         * BuildSlaveSupport/built-product-archive:
2394         (copyBuildFiles):
2395         (createZipFromList):
2396         (archiveBuiltProduct):
2397
2398 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
2399
2400         Use simctl instead of LayoutTestRelay
2401         https://bugs.webkit.org/show_bug.cgi?id=165927
2402
2403         Reviewed by Daniel Bates.
2404
2405         Part 1
2406
2407         LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
2408         simulators through simctl (iOS 10 and later), use this functionality instead.
2409
2410         * Scripts/webkitpy/port/base.py:
2411         (Port.__init__): Added _test_runner_process_constructor.
2412         * Scripts/webkitpy/port/darwin.py:
2413         (DarwinPort.app_identifier_from_bundle): Added function to extract bundle ID from plist.
2414         * Scripts/webkitpy/port/driver.py:
2415         (Driver._start): Pass worker_number to server_process so we can look up the correct simulator device to use.
2416         (IOSSimulatorDriver): Deleted.
2417         * Scripts/webkitpy/port/driver_unittest.py:
2418         (DriverTest.test_stop_cleans_up_properly): Set _test_runner_process_constructor for testing.
2419         (DriverTest.test_two_starts_cleans_up_properly): Ditto.
2420         (DriverTest.test_start_actually_starts): Ditto.
2421         * Scripts/webkitpy/port/ios.py:
2422         (IOSSimulatorPort): Remove relay_name.
2423         (IOSSimulatorPort.__init__): Set _test_runner_process_constructor to SimulatorProcess for IOSSimulatorPort.
2424         (IOSSimulatorPort._create_simulators): Formatting change.
2425         (IOSSimulatorPort.relay_path): Deleted.
2426         (IOSSimulatorPort._check_relay): Deleted.
2427         (IOSSimulatorPort._check_port_build): Deleted. Use base class implementation
2428         (IOSSimulatorPort._build_relay): Deleted.
2429         (IOSSimulatorPort._build_driver): Deleted. Use base class implementation
2430         (IOSSimulatorPort._driver_class): Deleted. Use base class implementation
2431         * Scripts/webkitpy/port/ios_unittest.py:
2432         (iosTest.test_32bit): Update test.
2433         (iosTest.test_64bit): Update test.
2434         * Scripts/webkitpy/port/server_process.py:
2435         (ServerProcess.__init__): Added argument worker_number. This class does not make use of it. We will make use of this argument in SimulatorProcess to lookup the associated simulator device.
2436         (ServerProcess._set_file_nonblocking): Added to share common code.
2437         * Scripts/webkitpy/port/server_process_mock.py:
2438         (MockServerProcess.__init__): Added argument worker_number.
2439         * Scripts/webkitpy/port/simulator_process.py: Added.
2440         (SimulatorProcess): Added.
2441         (SimulatorProcess.Popen): Added.
2442         (SimulatorProcess.Popen.__init__): Added. Initialize Popen structure with stdin, stdout, stderr and pid.
2443         (SimulatorProcess.Popen.poll): Added. Check if the process is running.
2444         (SimulatorProcess.Popen.wait): Added. Wait for process to close.
2445         (SimulatorProcess.__init__): Added. Install app to device specified through port and worker_number.
2446         (SimulatorProcess._reset): Added. Unlink fifos.
2447         (SimulatorProcess._start): Added. Launch app on simulator, link fifos.
2448         (SimulatorProcess._kill): Added. Shutdown app on simulator.
2449         * Scripts/webkitpy/xcode/simulator.py:
2450         (Device.__init__): Accept host to run install/launch/terminate.
2451         (Device.install_app): Install app to target Device.
2452         (Device.launch_app): Launch app on target Device.
2453         (Device.terminate_app): Shutdown app on target Device.
2454         (Simulator._parse_devices): Pass host to Device.
2455
2456 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2457
2458         [GTK] pixman fails to compile on Raspberry Pi (GCC crash)
2459         https://bugs.webkit.org/show_bug.cgi?id=167411
2460
2461         Reviewed by Michael Catanzaro.
2462
2463         Disable the ARM iwMMXt fast path for pixman, because it triggers
2464         a GCC bug on the RPi with Raspbian/PIXEL causing a build failure.
2465
2466         * gtk/jhbuild.modules:
2467
2468 2017-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2469
2470         [GTK] Add API to handle the accelerated compositing policy
2471         https://bugs.webkit.org/show_bug.cgi?id=167509
2472
2473         Reviewed by Michael Catanzaro.
2474
2475         Handle new setting in MiniBrowser. The settings dialog doesn't support enum settings so it needs to be handled
2476         as a special case. Also add test cases to the get/set API.
2477
2478         * MiniBrowser/gtk/BrowserSettingsDialog.c:
2479         (hardwareAccelerationPolicyToString):
2480         (stringToHardwareAccelerationPolicy):
2481         (cellRendererChanged):
2482         (browserSettingsDialogConstructed):
2483         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
2484         (testWebKitSettings):
2485
2486 2017-01-29  Andy Estes  <aestes@apple.com>
2487
2488         [QuickLook] Add a WebPreference to enable saving QuickLook documents in WebKitLegacy
2489         https://bugs.webkit.org/show_bug.cgi?id=167563
2490         <rdar://problem/30253207>
2491
2492         Reviewed by Andreas Kling.
2493
2494         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm:
2495         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
2496         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
2497         (runTest):
2498         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
2499         (TEST):
2500
2501 2017-01-29  Dan Bernstein  <mitz@apple.com>
2502
2503         [iOS] Expose WebCore::DataDetection::detectContentInRange WKWebProcessPlugInRangeHandle
2504         https://bugs.webkit.org/show_bug.cgi?id=167565
2505
2506         Reviewed by Sam Weinig.
2507
2508         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2509         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm: Added.
2510         (-[BundleRangeHandleRemoteObject textFromBodyRange:]):
2511         (-[BundleRangeHandleRemoteObject bodyInnerHTMLAfterDetectingData:]):
2512         (TEST):
2513         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandlePlugIn.mm: Added.
2514         (-[BundleRangeHandlePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2515         (-[BundleRangeHandlePlugIn webProcessPlugInBrowserContextController:didFinishDocumentLoadForFrame:]):
2516         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandleProtocol.h: Added.
2517
2518 2017-01-28  Yoav Weiss  <yoav@yoav.ws>
2519
2520         Add Link Preload as an off-by-default experimental feature menu item.
2521         https://bugs.webkit.org/show_bug.cgi?id=167201
2522
2523         Reviewed by Ryosuke Niwa.
2524
2525         * DumpRenderTree/mac/DumpRenderTree.mm:
2526         (resetWebPreferencesToConsistentValues):
2527         * DumpRenderTree/win/DumpRenderTree.cpp:
2528         (resetWebPreferencesToConsistentValues):
2529
2530 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
2531
2532         Add User Timing Experimental Feature
2533         https://bugs.webkit.org/show_bug.cgi?id=167542
2534         <rdar://problem/22746307>
2535
2536         Reviewed by Ryosuke Niwa.
2537
2538         * DumpRenderTree/mac/DumpRenderTree.mm:
2539         (enableExperimentalFeatures):
2540         (resetWebPreferencesToConsistentValues):
2541         * DumpRenderTree/win/DumpRenderTree.cpp:
2542         (enableExperimentalFeatures):
2543
2544 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
2545
2546         Patch Review: EWS Bubbles wrap to multiple lines but can fit on one line
2547         https://bugs.webkit.org/show_bug.cgi?id=167519
2548
2549         Reviewed by Ryosuke Niwa.
2550
2551         * QueueStatusServer/templates/statusbubble.html:
2552         To measure the bubbleContainer's width, it must not be wrapping based
2553         on its parent container. So when measuring the width temporarily set
2554         the parent to a very large width so as to not artificially wrap us.
2555         Restore the parent's width after measuring.
2556
2557 2017-01-27  Andy Estes  <aestes@apple.com>
2558
2559         [iOS] Add a test for _WKNSFileManagerExtras
2560         https://bugs.webkit.org/show_bug.cgi?id=167478
2561
2562         Reviewed by Andreas Kling.
2563
2564         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2565         * TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm: Added.
2566         (expectAttributes):
2567         (TEST):
2568
2569 2017-01-27  Keith Miller  <keith_miller@apple.com>
2570
2571         run-benchmarks should make sure it passes the test url to the right application
2572         https://bugs.webkit.org/show_bug.cgi?id=167533
2573
2574         Reviewed by Joseph Pecoraro.
2575
2576         This fixes an issue when trying to run-benchmark script with the
2577         system default browser set to STP. Previously, it would run
2578         the test in STP rather than the provided build. Now, it should run
2579         in the provided build.
2580
2581         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2582         (OSXSafariDriver.launch_url):
2583
2584 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
2585
2586         [Cocoa] Prepare ComplexTextController for unit testing
2587         https://bugs.webkit.org/show_bug.cgi?id=167493
2588
2589         Reviewed by Simon Fraser.
2590
2591         Addressing post-review comments from Simon Fraser.
2592
2593         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
2594         (TestWebKitAPI::TEST_F):
2595
2596 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
2597
2598         [Cocoa] Prepare ComplexTextController for unit testing
2599         https://bugs.webkit.org/show_bug.cgi?id=167493
2600
2601         Reviewed by Dean Jackson.
2602
2603         Create four unit tests.
2604
2605         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2606         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp: Added.
2607         (TestWebKitAPI::ComplexTextControllerTest::SetUp):
2608         (TestWebKitAPI::TEST_F):
2609
2610 2017-01-26  Chris Dumez  <cdumez@apple.com>
2611
2612         Crash when navigating back to a page in PacheCache when one of its frames has been removed
2613         https://bugs.webkit.org/show_bug.cgi?id=167421
2614         <rdar://problem/30188490>
2615
2616         Reviewed by Darin Adler.
2617
2618         Add a new setting allowing layout tests to enable PageCache in a window
2619         that has an opener, for convenience.
2620
2621         * DumpRenderTree/mac/DumpRenderTree.mm:
2622         (resetWebPreferencesToConsistentValues):
2623         * DumpRenderTree/win/DumpRenderTree.cpp:
2624         (resetWebPreferencesToConsistentValues):
2625         * WebKitTestRunner/TestController.cpp:
2626         (WTR::TestController::resetPreferencesToConsistentValues):
2627
2628 2017-01-26  Keith Miller  <keith_miller@apple.com>
2629
2630         classInfo should take a VM so it is not materialized from the object on each call
2631         https://bugs.webkit.org/show_bug.cgi?id=167424
2632
2633         Rubber Stamped by Michael Saboff.
2634
2635         Previously, classInfo() would get the VM from the target's
2636         MarkedBlock.  Most callers already have a VM on hand, so it is
2637         wasteful to compute the VM from the marked block every time. This
2638         patch refactors some of the most common callers of classInfo(),
2639         jsDynamicCast and inherits to take a VM as well.
2640
2641         * DumpRenderTree/TestRunner.cpp:
2642         (setAudioResultCallback):
2643
2644 2017-01-26  Jer Noble  <jer.noble@apple.com>
2645
2646         Autoplay muted videos stop playback of any streaming app in the background
2647         https://bugs.webkit.org/show_bug.cgi?id=163993
2648         <rdar://problem/29020431>
2649
2650         Reviewed by Eric Carlson.
2651
2652         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2653         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
2654         (TestWebKitAPI::TEST):
2655         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio-and-webaudio.html: Added.
2656
2657 2017-01-26  Ryan Haddad  <ryanhaddad@apple.com>
2658
2659         Disable API test WebKit2.WebsitePoliciesPlayAfterPreventedAutoplay.
2660         https://bugs.webkit.org/show_bug.cgi?id=167466
2661
2662         Unreviewed test gardening.
2663
2664         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2665         (TEST):
2666
2667 2017-01-26  Matt Rajca  <mrajca@apple.com>
2668
2669         Notify clients when the user plays media otherwise prevented from autoplaying
2670         https://bugs.webkit.org/show_bug.cgi?id=167390
2671
2672         Reviewed by Alex Christensen.
2673
2674         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2675         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
2676         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
2677         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2678         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
2679         (TEST):
2680         * TestWebKitAPI/cocoa/TestWKWebView.h:
2681         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2682         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
2683         (-[TestWKWebView waitForLoad]):
2684         (-[TestWKWebView mouseUpAtPoint:]):
2685         * WebKitTestRunner/TestController.cpp:
2686         (WTR::TestController::createOtherPage):
2687         (WTR::TestController::createWebViewWithOptions):
2688
2689 2017-01-26  Per Arne Vollan  <pvollan@apple.com>
2690
2691         Crash when setting custom scale factor.
2692         https://bugs.webkit.org/show_bug.cgi?id=167369
2693
2694         Reviewed by Sam Weinig.
2695
2696         Added API test.
2697
2698         * TestWebKitAPI/PlatformWin.cmake:
2699         * TestWebKitAPI/Tests/WebKit/win/ScaleWebView.cpp: Added.
2700         (TestWebKitAPI::WebKitCreateInstance):
2701         (TestWebKitAPI::ScaleWebView::SetUp):
2702         (TestWebKitAPI::ScaleWebView::TearDown):
2703         (TestWebKitAPI::TEST_F):
2704
2705 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
2706
2707         run-benchmark nests MotionMark results by the suite name twice
2708         https://bugs.webkit.org/show_bug.cgi?id=164948
2709
2710         Reviewed by Said Abou-Hallawa.
2711
2712         Use a single level MotionMark now that this is the name of the benchmark,
2713         and we no longer have tests that aren't part of the MotionMark suite.
2714
2715         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch:
2716
2717 2017-01-25  Ryan Haddad  <ryanhaddad@apple.com>
2718
2719         Unreviewed, rolling out r211193.
2720
2721         This change broke internal builds.
2722
2723         Reverted changeset:
2724
2725         "Notify clients when the user plays media otherwise prevented
2726         from autoplaying"
2727         https://bugs.webkit.org/show_bug.cgi?id=167390
2728         http://trac.webkit.org/changeset/211193
2729
2730 2017-01-25  Matt Rajca  <mrajca@apple.com>
2731
2732         Notify clients when the user plays media otherwise prevented from autoplaying
2733         https://bugs.webkit.org/show_bug.cgi?id=167390
2734
2735         Reviewed by Alex Christensen.
2736
2737         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2738         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
2739         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
2740         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2741         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
2742         (TEST):
2743         * TestWebKitAPI/cocoa/TestWKWebView.h:
2744         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2745         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
2746         (-[TestWKWebView waitForLoad]):
2747         (-[TestWKWebView mouseUpAtPoint:]):
2748         * WebKitTestRunner/TestController.cpp:
2749         (WTR::TestController::createOtherPage):
2750         (WTR::TestController::createWebViewWithOptions):
2751
2752 2017-01-25  Matt Rajca  <mrajca@apple.com>
2753
2754         [ios-simulator] API test WebKit2.WebsitePoliciesAutoplayEnabled timing out
2755         https://bugs.webkit.org/show_bug.cgi?id=167385
2756
2757         Reviewed by Alex Christensen.
2758
2759         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Avoid arbitrary timeouts in favor of promises.
2760         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html:
2761         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2762         (TEST): Allow inline (rather than full screen) media playback on iOS.
2763
2764 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2765
2766         [GTK] Icon Database should be in private browsing mode for ephemeral web views
2767         https://bugs.webkit.org/show_bug.cgi?id=167414
2768
2769         Reviewed by Michael Catanzaro.
2770
2771         Add a test case to check ephemeral web views don't write favicons to the database.
2772
2773         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
2774         (ephemeralViewLoadChanged):
2775         (testPrivateBrowsing):
2776         (testFaviconDatabase):
2777
2778 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2779
2780         [GTK] Add a private browsing mode to MiniBrowser
2781         https://bugs.webkit.org/show_bug.cgi?id=167413
2782
2783         Reviewed by Michael Catanzaro.
2784
2785         Add -p/--private command line option to create a private instance. Also add CTRL+SHIFT+P shortcut to create
2786         private windows, even on non-private instances.
2787
2788         * MiniBrowser/gtk/BrowserWindow.c:
2789         (webViewTitleChanged): Add [Private] to title window for private windows.
2790         (webViewCreate): Pass web context to browser_window_new.
2791         (openPrivateWindow): Create a new ephemeral web view and add it to a new window.
2792         (browserWindowFinalize): Disconnect web context signal handlers.
2793         (browser_window_init): Add shortcut for opening private window.
2794         (browser_window_new): It now receives the context and connect to download-started here.
2795         (browser_window_get_web_context): Return the context.
2796         * MiniBrowser/gtk/BrowserWindow.h:
2797         * MiniBrowser/gtk/main.c:
2798         (createBrowserTab): Create the web view for the window web context.
2799         (aboutDataScriptMessageReceivedCallback): Do not use the default web context, but the window one.
2800         (aboutDataHandleRequest): Ditto.
2801         (aboutURISchemeRequestCallback): Ditto.
2802         (main): Create ephemeral web context if private command line option is used.
2803
2804 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
2805
2806         collectMatchingElementsInFlatTree should not find elements inside an user agent shadow tree
2807         https://bugs.webkit.org/show_bug.cgi?id=167409
2808
2809         Reviewed by Antti Koivisto.
2810
2811         Added a test case for collectMatchingElementsInFlatTree not finding elements inside an user agent shadow tree
2812         as well as tests for the newly added matchingElementInFlatTree.
2813
2814         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp:
2815         (TestWebKitAPI::runJavaScriptAlert):
2816         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
2817         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
2818         * TestWebKitAPI/Tests/WebKit2/closed-shadow-tree-test.html:
2819
2820 2017-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2821
2822         [GTK] Add API to create ephemeral web views and deprecate the private browsing setting
2823         https://bugs.webkit.org/show_bug.cgi?id=167370
2824
2825         Reviewed by Michael Catanzaro.
2826
2827         Add several test cases of ephemeral web views.
2828
2829         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
2830         (testWebViewAuthenticationStorage):
2831         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
2832         (ephemeralViewloadChanged):
2833         (testCookieManagerEphemeral):
2834         (beforeAll):
2835         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
2836         (testWebKitSettings):
2837         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2838         (testWebContextEphemeral):
2839         (ephemeralViewloadChanged):
2840         (testWebContextProxySettings):
2841         (beforeAll):
2842         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2843         (ephemeralViewloadChanged):
2844         (testWebViewEphemeral):
2845         (beforeAll):
2846         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp:
2847         (ephemeralViewloadChanged):
2848         (testWebsiteDataEphemeral):
2849         (beforeAll):
2850
2851 2017-01-24  Alex Christensen  <achristensen@webkit.org>
2852
2853         REGRESSION (r208902): URLWithUserTypedString returns nil with file URLs
2854         https://bugs.webkit.org/show_bug.cgi?id=167402
2855
2856         Reviewed by Ryosuke Niwa.
2857
2858         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
2859         (TestWebKitAPI::TEST):
2860
2861 2017-01-24  Zalan Bujtas  <zalan@apple.com>
2862
2863         Add simple line layout toggle to MiniBrowser
2864         https://bugs.webkit.org/show_bug.cgi?id=167405
2865
2866         Reviewed by Andreas Kling.
2867
2868         * MiniBrowser/mac/SettingsController.h:
2869         * MiniBrowser/mac/SettingsController.m:
2870         (-[SettingsController _populateMenu]):
2871         (-[SettingsController validateMenuItem:]):
2872         (-[SettingsController toggleSimpleLineLayoutEnabled:]):
2873         (-[SettingsController simpleLineLayoutEnabled]):
2874         * MiniBrowser/mac/WK1BrowserWindowController.m:
2875         (-[WK1BrowserWindowController didChangeSettings]):
2876         * MiniBrowser/mac/WK2BrowserWindowController.m:
2877         (-[WK2BrowserWindowController didChangeSettings]):
2878
2879 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
2880
2881         WKR does not include my nick when commit-queue lands my patch
2882         https://bugs.webkit.org/show_bug.cgi?id=167388
2883
2884         Reviewed by Ryosuke Niwa.
2885
2886         * Scripts/webkitpy/tool/commands/newcommitbot.py:
2887         (NewCommitBot._summarize_commit_log):
2888         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
2889         Perform nickname insertion before grabbing "Patch by" details.
2890         This way we can include the nickname with the full name.
2891
2892 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
2893
2894         Fold USER_TIMING into WEB_TIMING and make it a RuntimeEnabledFeature
2895         https://bugs.webkit.org/show_bug.cgi?id=167394
2896
2897         Reviewed by Ryosuke Niwa.
2898
2899         * Scripts/webkitperl/FeatureList.pm:
2900         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2901
2902 2017-01-24  Youenn Fablet  <youenn@apple.com>
2903
2904         [WebRTC] Use HAVE_PTHREAD_COND_TIMEDWAIT_RELATIVE for libwebrtc
2905         https://bugs.webkit.org/show_bug.cgi?id=167353
2906
2907         Reviewed by Alex Christensen.
2908
2909         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
2910         (CMakeGenerator.initialize_targets):
2911
2912 2017-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2913
2914         WKR should not confuse Miguel Gomez with Andres Gomez
2915         https://bugs.webkit.org/show_bug.cgi?id=167389
2916
2917         Reviewed by Lucas Forschler.
2918
2919         Andres's email is a substring of Miguel's, causing WKR to credit Miguel's commits to
2920         "mAndres Gomez". Fix this.
2921
2922         * Scripts/webkitpy/tool/commands/newcommitbot.py:
2923         (NewCommitBot._summarize_commit_log): Be stricter about matching emails. SVN logs include a
2924         space on each side of the email address, so expect both spaces to be there before
2925         considering the email for replacement.
2926         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py: Add a test.
2927
2928 2017-01-24  Matt Rajca  <mrajca@apple.com>
2929
2930         Pass down website autoplay policies to media elements
2931         https://bugs.webkit.org/show_bug.cgi?id=167355
2932
2933         Reviewed by Alex Christensen.
2934
2935         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2936         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/autoplayCheck.html to match our naming conventions.
2937         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html: Added.
2938         * TestWebKitAPI/Tests/WebKit2/test-without-audio-track.mp4: Added.
2939         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2940         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
2941         (TEST):
2942
2943 2017-01-24  Nan Wang  <n_wang@apple.com>
2944
2945         AX: Speak Selection does not work in an iframe
2946         https://bugs.webkit.org/show_bug.cgi?id=166794
2947         <rdar://problem/29913013>
2948
2949         Reviewed by Chris Fleizach.
2950
2951         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2952         (WTR::UIScriptController::retrieveSpeakSelectionContent):
2953         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
2954         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2955         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2956         (WTR::UIScriptController::retrieveSpeakSelectionContent):
2957         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
2958         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2959         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2960         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2961         (-[TestRunnerWKWebView dealloc]):
2962         (-[TestRunnerWKWebView _accessibilityDidGetSpeakSelectionContent:]):
2963         (-[TestRunnerWKWebView accessibilityRetrieveSpeakSelectionContentWithCompletionHandler:]):
2964         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2965         (WTR::UIScriptController::retrieveSpeakSelectionContent):
2966         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
2967
2968 2017-01-24  Daniel Bates  <dabates@apple.com>
2969
2970         StringView.split() should use an iterator design pattern instead of allocating a Vector
2971         https://bugs.webkit.org/show_bug.cgi?id=163225
2972
2973         Reviewed by Darin Adler.
2974
2975         Add unit tests for StringView.split().
2976
2977         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2978         (TestWebKitAPI::stringViewFromLiteral): Moved to the top of the file so that it can be
2979         used in the StringView.split() unit tests.
2980         (TestWebKitAPI::stringViewFromUTF8): Ditto.
2981         (TestWebKitAPI::vectorFromSplitResult): Convenience function to convert a StringView::SplitResult
2982         object to a Vector of String objects.
2983         (TestWebKitAPI::TEST): Added the following tests:
2984             - WTF.StringViewSplitEmptyAndNullStrings
2985             - WTF.StringViewSplitBasic
2986             - WTF.StringViewSplitWithConsecutiveSeparators
2987
2988 2017-01-23  Anders Carlsson  <andersca@apple.com>
2989
2990         The Score Esports crashes on launch
2991         https://bugs.webkit.org/show_bug.cgi?id=167338
2992         rdar://problem/29948645
2993
2994         Reviewed by Dan Bernstein.
2995
2996         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
2997         (TestWebKitAPI::TEST):
2998         Add a test.
2999
3000 2017-01-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3001
3002         [GTK] Add API to WebKitWebsiteDataManager to handle website data
3003         https://bugs.webkit.org/show_bug.cgi?id=146589
3004
3005         Reviewed by Michael Catanzaro.
3006
3007         Add about:data handler to MiniBrowser to manually test the website data API. Also add unit tests to test all the
3008         new API, moving the WebKitWebsiteDataManager configuration API to the new file too.
3009
3010         * MiniBrowser/gtk/BrowserWindow.c:
3011         (webViewDecidePolicy):
3012         (newTabCallback):
3013         * MiniBrowser/gtk/main.c:
3014         (createBrowserTab):
3015         (aboutDataRequestFree):
3016         (aboutDataRequestNew):
3017         (aboutDataRequestForView):
3018         (websiteDataRemovedCallback):
3019         (websiteDataClearedCallback):
3020         (aboutDataScriptMessageReceivedCallback):
3021         (domainListFree):
3022         (aboutDataFillTable):
3023         (gotWebsiteDataCallback):
3024         (aboutDataHandleRequest):
3025         (aboutURISchemeRequestCallback):
3026         (main):
3027         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3028         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
3029         (serverCallback):
3030         (beforeAll):
3031         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp: Added.
3032         (serverCallback):
3033         (WebsiteDataTest::WebsiteDataTest):
3034         (WebsiteDataTest::~WebsiteDataTest):
3035         (WebsiteDataTest::fetch):
3036         (WebsiteDataTest::remove):
3037         (WebsiteDataTest::clear):
3038         (testWebsiteDataConfiguration):
3039         (testWebsiteDataCache):
3040         (testWebsiteDataStorage):
3041         (testWebsiteDataDatabases):
3042         (testWebsiteDataAppcache):
3043         (beforeAll):
3044         (afterAll):
3045
3046 2017-01-23  Commit Queue  <commit-queue@webkit.org>
3047
3048         Unreviewed, rolling out r211062.
3049         https://bugs.webkit.org/show_bug.cgi?id=167354
3050
3051         broke API tests (Requested by alexchristensen on #webkit).
3052
3053         Reverted changeset:
3054
3055         "Pass down website autoplay policies to media elements"
3056         https://bugs.webkit.org/show_bug.cgi?id=167132
3057         http://trac.webkit.org/changeset/211062
3058
3059 2017-01-23  Alex Christensen  <achristensen@webkit.org>
3060
3061         URLParser should fail to parse percent-encoded invalid UTF-8 sequences
3062         https://bugs.webkit.org/show_bug.cgi?id=167330
3063
3064         Reviewed by Tim Horton.
3065
3066         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3067         (TestWebKitAPI::TEST_F):
3068
3069 2017-01-23  Alex Christensen  <achristensen@webkit.org>
3070
3071         Make URLs with non-special schemes and a query or fragment but no slash after the host more compatible
3072         https://bugs.webkit.org/show_bug.cgi?id=167317
3073
3074         Reviewed by Sam Weinig.
3075
3076         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3077         (TestWebKitAPI::TEST_F):
3078
3079 2017-01-23  Jonathan Bedard  <jbedard@apple.com>
3080
3081         svn-create-patch should emit properties when files are moved or copied
3082         https://bugs.webkit.org/show_bug.cgi?id=167264
3083
3084         Reviewed by Daniel Bates.
3085
3086         * Scripts/svn-create-patch:
3087         (manufacturePatchForAdditionWithHistory): Diff the source file against nothing to get properties.
3088
3089 2017-01-23  Youenn Fablet  <youenn@apple.com>
3090
3091         [WebRTC] Filter libwebrtc link flags
3092         https://bugs.webkit.org/show_bug.cgi?id=167287
3093
3094         Reviewed by Alex Christensen.
3095
3096         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
3097         (CMakeGenerator._compute_link_flags):
3098         (CMakeGenerator._compute_link_flags.keep_flag):
3099         (CMakeGenerator._generate_compile_target_options):
3100
3101 2017-01-23  Youenn Fablet  <youennf@gmail.com>
3102
3103         [WebRTC] Make VP8 optional in libwebrtc
3104         https://bugs.webkit.org/show_bug.cgi?id=167257
3105
3106         Reviewed by Darin Adler.
3107
3108         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
3109         (CMakeGenerator.remove_libvpx): Adding vp8_noop.cc to the build system.
3110
3111 2017-01-23  Jer Noble  <jer.noble@apple.com>
3112
3113         Video details does not apear and missing scrubber in Control Center
3114         https://bugs.webkit.org/show_bug.cgi?id=167233
3115
3116         Reviewed by Alex Christensen.
3117
3118         Refactor TestWKWebViewMac to work on PLATFORM(IOS). Add a new test to
3119         NowPlayingControlTests for iOS.
3120
3121         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3122         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
3123         (-[NowPlayingTestWebView setWindowVisible:]):
3124         (TestWebKitAPI::TEST):
3125         * TestWebKitAPI/Tests/WebKit2Cocoa/SnapshotStore.mm:
3126         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
3127         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
3128         * TestWebKitAPI/cocoa/TestWKWebView.h: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.h.
3129         * TestWebKitAPI/cocoa/TestWKWebView.mm: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.mm.
3130         (SOFT_LINK_CLASS):
3131         (-[TestMessageHandler addMessage:withHandler:]):
3132         (-[TestMessageHandler userContentController:didReceiveScriptMessage:]):
3133         (__simulated_forceClickAssociatedEventsMask):
3134         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:]):
3135         (-[TestWKWebViewHostWindow isKeyWindow]):
3136         (-[TestWKWebViewHostWindow makeKeyWindow]):
3137         (-[TestWKWebViewHostWindow resignKeyWindow]):
3138         (-[TestWKWebView initWithFrame:]):
3139         (-[TestWKWebView initWithFrame:configuration:]):
3140         (-[TestWKWebView _setUpTestWindow:]):
3141         (-[TestWKWebView performAfterReceivingMessage:action:]):
3142         (-[TestWKWebView loadTestPageNamed:]):
3143         (-[TestWKWebView synchronouslyLoadTestPageNamed:]):
3144         (-[TestWKWebView stringByEvaluatingJavaScript:]):
3145         (-[TestWKWebView waitForMessage:]):
3146         (-[TestWKWebView performAfterLoading:]):
3147         (-[TestWKWebView mouseDownAtPoint:simulatePressure:]):
3148         (-[TestWKWebView typeCharacter:]):
3149
3150 2017-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3151
3152         Unreviewed. Bring back gtk-doc error messages after r209981.
3153
3154         Since r209981, if gtk-doc shows warnings the build fails but those warnings are not printed to stdout so it's
3155         impossible to know what's wrong.
3156
3157         * gtk/gtkdoc.py:
3158         (GTKDoc._run_command): Make print_output True by default again and use debug instead of info to log "Running" messages.
3159
3160 2017-01-20  Youenn Fablet  <youennf@gmail.com>
3161
3162         [WebRTC] Update build system to make G711 optional in libwebrtc
3163         https://bugs.webkit.org/show_bug.cgi?id=167256
3164
3165         Reviewed by Alex Christensen.
3166
3167         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
3168         (CMakeGenerator.remove_webrtc_g711): Adding a missing file to the build system as this file includes generic pcm encoder functions.
3169
3170 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
3171
3172         Cleanup RuntimeEnabledFeatures
3173         https://bugs.webkit.org/show_bug.cgi?id=167228
3174
3175         Reviewed by Simon Fraser.
3176
3177         * DumpRenderTree/mac/DumpRenderTree.mm:
3178         (enableExperimentalFeatures):
3179         (resetWebPreferencesToConsistentValues):
3180         (setWebPreferencesForTestOptions):
3181         (resetWebViewToConsistentStateBeforeTesting):
3182         * DumpRenderTree/win/DumpRenderTree.cpp:
3183         (enableExperimentalFeatures):
3184         (resetWebPreferencesToConsistentValues):
3185         More closely match WebKitTestRunner initialization of preferences
3186         for experimental features.
3187
3188 2017-01-20  Alex Christensen  <achristensen@webkit.org>
3189
3190         Build Fix for Windows DumpRenderTree after r210976
3191         https://bugs.webkit.org/show_bug.cgi?id=167115
3192
3193         * DumpRenderTree/win/DumpRenderTree.cpp:
3194         (resetWebPreferencesToConsistentValues):
3195
3196 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
3197
3198         Remove outdated ENABLE(CSP_NEXT) build flag
3199         https://bugs.webkit.org/show_bug.cgi?id=167252
3200
3201         Reviewed by Brent Fulgham.
3202
3203         * Scripts/webkitperl/FeatureList.pm:
3204         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3205
3206 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
3207
3208         Build Fix for Windows DumpRenderTree after r210976
3209
3210         * DumpRenderTree/win/DumpRenderTree.cpp:
3211         (resetWebPreferencesToConsistentValues):
3212
3213 2017-01-20  Antoine Quint  <graouts@apple.com>
3214
3215         Web Animations should be off by default and enabled as an experimental feature
3216         https://bugs.webkit.org/show_bug.cgi?id=167115
3217         <rdar://problem/30048963>
3218
3219         Reviewed by Joseph Pecoraro.
3220
3221         Turn Web Animations on in DRT.
3222
3223         * DumpRenderTree/mac/DumpRenderTree.mm:
3224         (resetWebPreferencesToConsistentValues):
3225         * DumpRenderTree/win/DumpRenderTree.cpp:
3226         (resetWebPreferencesToConsistentValues):
3227
3228 2017-01-20  Youenn Fablet  <youenn@apple.com>
3229
3230         [WebRTC] Add libwebrtc build infrastructure
3231         https://bugs.webkit.org/show_bug.cgi?id=167207
3232
3233         Reviewed by Alex Christensen.
3234
3235         Adding a script doing the libwebrtc project json to CMake file conversion.
3236
3237         * Scripts/generate-libwebrtc-cmake: Added.
3238         * Scripts/webkitpy/libwebrtc/__init__.py: Added.
3239         * Scripts/webkitpy/libwebrtc/generate_cmake.py: Added.
3240
3241 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
3242
3243         Mini Browser: Show tooltip for Experimental Features
3244         https://bugs.webkit.org/show_bug.cgi?id=167225
3245
3246         Reviewed by Alex Christensen.
3247
3248         * MiniBrowser/mac/SettingsController.m:
3249         (-[SettingsController _populateMenu]):
3250         Include the full details string as a tooltip.
3251
3252 2017-01-20  Per Arne Vollan  <pvollan@apple.com>
3253
3254         [Win] Test output results should not be written twice.
3255         https://bugs.webkit.org/show_bug.cgi?id=167197
3256
3257         Reviewed by Brent Fulgham.
3258
3259         Prevent test output from being written twice by returning early from
3260         the dump() function, if it already has been called.
3261         This patch also adds a missing newline to a test output line. 
3262         
3263         * DumpRenderTree/win/DumpRenderTree.cpp:
3264         (dump):
3265
3266 2017-01-20  Antoine Quint  <graouts@apple.com>
3267
3268         [Modern Media Controls] Turn modern media controls on by default
3269         https://bugs.webkit.org/show_bug.cgi?id=165668
3270
3271         Reviewed by Dean Jackson.
3272
3273         Enabled modern media controls by default in test runners.
3274
3275         * DumpRenderTree/TestOptions.h:
3276         * WebKitTestRunner/TestOptions.h:
3277
3278 2017-01-19  Chris Dumez  <cdumez@apple.com>
3279
3280         iterable<> should be enabled on WK1
3281         https://bugs.webkit.org/show_bug.cgi?id=167221
3282         <rdar://problem/30108531>
3283
3284         Reviewed by Youenn Fablet.
3285
3286         * DumpRenderTree/mac/DumpRenderTree.mm:
3287         (resetWebPreferencesToConsistentValues):
3288         * DumpRenderTree/win/DumpRenderTree.cpp:
3289         (resetWebPreferencesToConsistentValues):
3290         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3291         (WTR::InjectedBundle::beginTesting):
3292         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3293         (WTR::TestRunner::setDOMIteratorEnabled): Deleted.
3294         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3295
3296 2017-01-19  Aakash Jain  <aakash_jain@apple.com>
3297
3298         Ensure status server logs go to log file
3299         https://bugs.webkit.org/show_bug.cgi?id=167210
3300
3301         Reviewed by Alexey Proskuryakov.
3302
3303         * Scripts/webkitpy/common/net/statusserver.py:
3304         (StatusServer.next_work_item): Change log level from debug to info in
3305         order to facilitate deubgging issues.
3306         (StatusServer.update_work_items): Same.
3307
3308 2017-01-19  Megan Gardner  <megan_gardner@apple.com>
3309
3310         Additional selection tests and interpolation fix
3311         https://bugs.webkit.org/show_bug.cgi?id=167171
3312
3313         Reviewed by Simon Fraser.
3314
3315         We weren't adding the final event when interpolating event streams.
3316
3317         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3318         (-[HIDEventGenerator interpolatedEvents:]):
3319
3320 2017-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
3321
3322         [Cocoa] Variation fonts are erroneously disabled on iOS
3323         https://bugs.webkit.org/show_bug.cgi?id=167172
3324
3325         Reviewed by Simon Fraser.
3326
3327         OpenSource builders don't seem to understand sdk=embedded*.
3328
3329         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3330
3331 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3332
3333         Unreviewed. Fix GTK+ unit tests failing since r210531.
3334
3335         Avoid using paths to files that don't actually exist.
3336
3337         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:
3338         (testWebKitConsoleMessageNetworkError):
3339         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
3340         (testContextMenuDefaultMenu):
3341         * TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg: Added.
3342         * TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json: Added.
3343         * TestWebKitAPI/Tests/WebKit2Gtk/resources/tracks.ogg: Added.
3344
3345 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3346
3347         [GTK] Provide API to set proxy settings
3348         https://bugs.webkit.org/show_bug.cgi?id=128674
3349
3350         Reviewed by Michael Catanzaro.
3351
3352         Add tests for new proxy settings API.
3353
3354         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
3355         (serverCallback):
3356         (ProxyTest::ProxyTest):
3357         (ProxyTest::~ProxyTest):
3358         (ProxyTest::loadURIAndGetMainResourceData):
3359         (ProxyTest::proxyServerPortAsString):
3360         (testWebContextProxySettings):
3361         (beforeAll):
3362
3363 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
3364
3365         Add back my old email address so old commits will still match it.
3366
3367         * Scripts/webkitpy/common/config/contributors.json:
3368
3369 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
3370
3371         Remove my old email address from contributors.json and watchlist.
3372
3373         * Scripts/validate-committer-lists:
3374         (CommitterListFromGit): Change the mapping to the correct email.
3375         * Scripts/webkitpy/common/config/contributors.json:
3376         * Scripts/webkitpy/common/config/watchlist:
3377
3378 2017-01-18  Ryan Haddad  <ryanhaddad@apple.com>
3379
3380         Unreviewed, rolling out r210848.
3381
3382         This change introduced media-related LayoutTest failures and
3383         crashes on macOS.
3384
3385         Reverted changeset:
3386
3387         "[Modern Media Controls] Turn modern media controls on by
3388         default"
3389         https://bugs.webkit.org/show_bug.cgi?id=165668
3390         http://trac.webkit.org/changeset/210848
3391
3392 2017-01-18  Andreas Kling  <akling@apple.com>
3393
3394         Document::securityOrigin() should return a reference.
3395         <https://webkit.org/b/167124>
3396
3397         Reviewed by Sam Weinig.
3398
3399         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
3400         (TestWebKitAPI::TEST_F):
3401
3402 2017-01-18  Per Arne Vollan  <pvollan@apple.com>
3403
3404         [Win] Clipboard tests are flaky.
3405         https://bugs.webkit.org/show_bug.cgi?id=167088
3406
3407         Reviewed by Brent Fulgham.
3408
3409         Tests involving the clipboard are flaky when running with multiple DRTs, since the clipboard is global. 
3410         We can fix this by assigning each DRT a separate window station (each window station has its own clipboard).
3411
3412         * DumpRenderTree/win/DumpRenderTree.cpp:
3413         (main):
3414
3415 2017-01-18  Antoine Quint  <graouts@apple.com>
3416
3417         [Modern Media Controls] Turn modern media controls on by default
3418         https://bugs.webkit.org/show_bug.cgi?id=165668
3419
3420         Reviewed by Dean Jackson.
3421
3422         Enabled modern media controls by default in test runners. 
3423
3424         * DumpRenderTree/TestOptions.h:
3425         * WebKitTestRunner/TestOptions.h:
3426
3427 2017-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
3428
3429         Unreviewed, rolling out r210834
3430         https://bugs.webkit.org/show_bug.cgi?id=165668
3431
3432         It introduced dozens of test timeouts.
3433
3434         Reverted changeset:
3435         "[Modern Media Controls] Turn modern media controls on by default"
3436         https://bugs.webkit.org/show_bug.cgi?id=165668
3437         http://trac.webkit.org/changeset/210834
3438
3439 2017-01-17  Antoine Quint  <graouts@apple.com>
3440
3441         [Modern Media Controls] Turn modern media controls on by default
3442         https://bugs.webkit.org/show_bug.cgi?id=165668
3443
3444         Reviewed by Dean Jackson.
3445
3446         Enabled modern media controls by default in test runners. 
3447
3448         * DumpRenderTree/TestOptions.h:
3449         * WebKitTestRunner/TestOptions.h:
3450
3451 2017-01-17  Chris Dumez  <cdumez@apple.com>
3452
3453         Document title changed twice when setting document.title
3454         https://bugs.webkit.org/show_bug.cgi?id=167065
3455
3456         Reviewed by Darin Adler.
3457
3458         Add WebKit2GTK API test that was written by Michael Catanzaro.
3459
3460         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3461         (testWebViewTitleChange):
3462         (beforeAll):
3463
3464 2017-01-17  Joseph Pecoraro  <pecoraro@apple.com>
3465
3466         ENABLE(USER_TIMING) Not Defined for Apple Windows or OS X Ports
3467         https://bugs.webkit.org/show_bug.cgi?id=116551
3468         <rdar://problem/13949830>
3469
3470         Reviewed by Alex Christensen.
3471
3472         * Scripts/webkitperl/FeatureList.pm:
3473         Remove stale RESOURCE_TIMING references which are now a runtime enabled feature
3474         that is part of the existing WEB_TIMING feature.
3475
3476         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3477
3478 2017-01-17  Jonathan Bedard  <jbedard@apple.com>
3479
3480         'webkit-patch post' no longer works with moved/copied files
3481         https://bugs.webkit.org/show_bug.cgi?id=166914
3482         <rdar://problem/29979707>
3483
3484         Reviewed by Daniel Bates.
3485
3486         SVN 1.9 has a bug where when a file has been moved or copied, the svn diff of the new
3487         file outputs only the "Index:" line with an empty body.  This workaround
3488         ignores such output from svn diff.  A issue has been filed with SVN, a link to the
3489         public email list tracking this bug is below.
3490         http://mail-archives.apache.org/mod_mbox/subversion-users/201701.mbox/%3cCF9BDE0A-7454-4405-8259-1120C6B76A03@apple.com%3e
3491         
3492
3493         * Scripts/svn-create-patch:
3494         (generateDiff): Ignore an "Index:" line with an empty body.
3495
3496 2017-01-16  Joseph Pecoraro  <pecoraro@apple.com>
3497
3498         Remove the REQUEST_ANIMATION_FRAME flag
3499         https://bugs.webkit.org/show_bug.cgi?id=156980
3500         <rdar://problem/25906849>
3501
3502         Reviewed by Simon Fraser.
3503
3504         * Scripts/webkitperl/FeatureList.pm:
3505         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3506
3507 2017-01-15  Sam Weinig  <sam@webkit.org>
3508
3509         Add the ability to use numbers in makeString()
3510         https://bugs.webkit.org/show_bug.cgi?id=167087
3511
3512         Reviewed by Darin Adler.
3513
3514         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3515         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Added.
3516         Add tests for StringConcatenate, focusing on new numeric additions.
3517
3518 2017-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
3519
3520         Unreviewed, remove stale comment.
3521
3522         This test was fixed by r163173.
3523
3524         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3525
3526 2017-01-14  Yusuke Suzuki  <utatane.tea@gmail.com>
3527
3528         Annotate large string tests with largeHeap
3529         https://bugs.webkit.org/show_bug.cgi?id=167054
3530
3531         Reviewed by Filip Pizlo.
3532
3533         * Scripts/run-javascriptcore-tests:
3534         * Scripts/run-jsc-stress-tests:
3535
3536 2017-01-14  Joseph Pecoraro  <pecoraro@apple.com>
3537
3538         Remove stale references to ENABLE_ES6_GENERATORS and ENABLE_PROMISES
3539         https://bugs.webkit.org/show_bug.cgi?id=167043
3540
3541         Reviewed by Darin Adler.
3542
3543         * Scripts/webkitperl/FeatureList.pm:
3544
3545 2017-01-13  Joseph Pecoraro  <pecoraro@apple.com>
3546
3547         Remove ENABLE(DETAILS_ELEMENT) guards
3548         https://bugs.webkit.org/show_bug.cgi?id=167042
3549
3550         Reviewed by Alex Christensen.
3551
3552         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3553
3554 2017-01-13  Said Abou-Hallawa  <sabouhallawa@apple.com>
3555
3556         26 MotionMark performance tests failing
3557         https://bugs.webkit.org/show_bug.cgi?id=166854
3558
3559         Reviewed by Ryosuke Niwa.
3560
3561         Unrelated change. This is the last place that we need to rename Animometer
3562         to MotionMark.
3563
3564         * Scripts/webkitpy/common/config/watchlist:
3565
3566 2017-01-13  Yusuke Suzuki  <utatane.tea@gmail.com>
3567
3568         run-jsc-benchmarks' echo should have -e option
3569         https://bugs.webkit.org/show_bug.cgi?id=167009
3570
3571         Reviewed by Sam Weinig.
3572
3573         echo requires `-e` option to use escape sequence.
3574         Without it, in some environment (in my Fedora 25), the escape sequence is not
3575         recognized and just dumped as `\c` etc.
3576
3577         * Scripts/run-jsc-benchmarks:
3578
3579 2017-01-12  Chris Dumez  <cdumez@apple.com>
3580
3581         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
3582         https://bugs.webkit.org/show_bug.cgi?id=166995
3583
3584         Reviewed by Jer Noble.
3585
3586         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
3587         as some people are having trouble building without it.
3588
3589         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3590
3591 2017-01-12  Sam Weinig  <sam@webkit.org>
3592
3593         Add the ability to filter the set of bindings tests you want to run
3594         https://bugs.webkit.org/show_bug.cgi?id=166977
3595
3596         Reviewed by Tim Horton.
3597
3598         Allows doing things like:
3599             run-bindings-tests TestObj* TestCEReactions*
3600         
3601         to run only those tests that match the patterns.
3602
3603         * Scripts/run-bindings-tests:
3604         (main):
3605         Switch to using optparse and pass the remaining args as the filters.
3606
3607         * Scripts/webkitpy/bindings/main.py:
3608         (BindingsTests.__init__):
3609         Store the pattens.
3610
3611         (BindingsTests.test_matches_patterns):
3612         Add helper predicate to determine if a test should be run. When no
3613         patterns are present, all tests should run.
3614
3615         (BindingsTests.run_tests):
3616         Filter tests using the passed in patterns.
3617
3618 2017-01-12  Per Arne Vollan  <pvollan@apple.com>
3619
3620         Followup fix after r210503.
3621         https://bugs.webkit.org/show_bug.cgi?id=166887
3622
3623         Reviewed by Alex Christensen.
3624
3625         After <http://trac.webkit.org/changeset/210503>, test results are written to a
3626         duplicated file handle on Windows. This patch fixes the remaining call sites.
3627
3628         * DumpRenderTree/PixelDumpSupport.cpp:
3629         * DumpRenderTree/TestRunner.cpp:
3630         (TestRunner::waitToDumpWatchdogTimerFired):
3631         * DumpRenderTree/TestRunner.h:
3632         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3633         * DumpRenderTree/win/DumpRenderTree.cpp:
3634         * DumpRenderTree/win/DumpRenderTreeWin.h:
3635         * DumpRenderTree/win/TestRunnerWin.cpp:
3636         (TestRunner::setSpellCheckerLoggingEnabled):
3637
3638 2017-01-11  Megan Gardner  <megan_gardner@apple.com>
3639
3640         Add committer status for Megan
3641         https://bugs.webkit.org/show_bug.cgi?id=166954
3642
3643         Reviewed by Tim