[GTK][WPE] Add enable-javascript-markup setting
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2
3         [GTK][WPE] Add enable-javascript-markup setting
4         https://bugs.webkit.org/show_bug.cgi?id=193439
5
6         Reviewed by Michael Catanzaro.
7
8         Add test cases to check the new setting.
9
10         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
11         (testWebKitSettings):
12         (testWebKitSettingsJavaScriptMarkup):
13         (beforeAll):
14
15 2019-02-10  Darin Adler  <darin@apple.com>
16
17         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
18         https://bugs.webkit.org/show_bug.cgi?id=194485
19
20         Reviewed by Daniel Bates.
21
22         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
23
24 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
25
26         Add more tests for clampTo<>()
27         https://bugs.webkit.org/show_bug.cgi?id=194462
28
29         Reviewed by Geoffrey Garen.
30
31         Darin suggested to test the very last floating point number
32         at the boundaries when truncating to integer.
33         I added test for max/min and max-1/min-1.
34
35         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
36         (TestWebKitAPI::TEST):
37
38 2019-02-09  Darin Adler  <darin@apple.com>
39
40         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
41         https://bugs.webkit.org/show_bug.cgi?id=194021
42
43         Reviewed by Geoffrey Garen.
44
45         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
46         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
47         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
48
49 2019-02-09  Zalan Bujtas  <zalan@apple.com>
50
51         [LFC][IFC] Add intrinsic width support for basic inline containers
52         https://bugs.webkit.org/show_bug.cgi?id=194473
53
54         Reviewed by Antti Koivisto.
55
56         Expand tests coverage (11 new tests -> 798)
57
58         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
59
60 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
61
62         Fix MiniBrowser's entitlements
63         https://bugs.webkit.org/show_bug.cgi?id=192431
64
65         Reviewed by Joseph Pecoraro.
66
67         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
68         files, making it impossible to load any extension.
69
70         * MiniBrowser/MiniBrowser.entitlements:
71
72 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
73
74         [Cocoa] Ask platform for generic font family mappings
75         https://bugs.webkit.org/show_bug.cgi?id=187723
76         <rdar://problem/41892438>
77
78         Reviewed by Brent Fulgham.
79
80         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
81
82         * DumpRenderTree/mac/DumpRenderTree.mm:
83         (allowedFontFamilySet):
84         * WebKitTestRunner/mac/TestControllerMac.mm:
85         (WTR::allowedFontFamilySet):
86
87 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
88
89         [GTK] Implement back/forward touchpad gesture
90         https://bugs.webkit.org/show_bug.cgi?id=193919
91
92         Reviewed by Michael Catanzaro.
93
94         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
95         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
96
97 2019-02-08  Alex Christensen  <achristensen@webkit.org>
98
99         Add SPI to use networking daemon instead of XPC service
100         https://bugs.webkit.org/show_bug.cgi?id=194427
101
102         Reviewed by Geoffrey Garen
103
104         * MiniBrowser/MiniBrowser.entitlements:
105
106 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
107
108         [ews-build] Ensure that every builder in config.json has short name
109         https://bugs.webkit.org/show_bug.cgi?id=194461
110
111         Reviewed by Lucas Forschler.
112
113         * BuildSlaveSupport/ews-build/loadConfig.py:
114         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
115
116 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
117
118         [ews-build] Add short name to config.json
119         https://bugs.webkit.org/show_bug.cgi?id=194456
120
121         Reviewed by Lucas Forschler.
122
123         * BuildSlaveSupport/ews-build/config.json: Added short name.
124         * BuildSlaveSupport/ews-build/loadConfig.py:
125         (loadBuilderConfig): Set the short name as the builder description.
126
127 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
128
129         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
130         https://bugs.webkit.org/show_bug.cgi?id=194418
131
132         Reviewed by Lucas Forschler.
133
134         Do not include errors trying when finding crashlogs at the end of
135         a run-webkit-tests run since we don't process those errors.
136
137         * Scripts/webkitpy/port/darwin.py:
138         (DarwinPort._look_for_all_crash_logs_in_log_dir):
139         * Scripts/webkitpy/port/ios_device.py:
140         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
141         * Scripts/webkitpy/port/watch_device.py:
142         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
143
144 2019-02-08  Beth Dakin  <bdakin@apple.com>
145
146         Add afterScreenUpdates to WKSnapshotConfiguration
147         https://bugs.webkit.org/show_bug.cgi?id=194362
148         -and corresponding-
149         <rdar://problem/40655528> Please add an "after screen updates" property to 
150         WKSnapshotConfiguration (to solve blank snapshots)
151
152         Reviewed by Tim Horton.
153
154         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
155         (TEST):
156
157 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
158
159         clampTo(): do not convert the input to double when dealing with integers
160         https://bugs.webkit.org/show_bug.cgi?id=194263
161         <rdar://problem/47692312>
162
163         Reviewed by Darin Adler.
164
165         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
166         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
167         (TestWebKitAPI::testClampFloatingPointToInteger):
168         (TestWebKitAPI::testClampSameSignIntegers):
169         (TestWebKitAPI::testClampUnsignedToSigned):
170         (TestWebKitAPI::testClampSignedToUnsigned):
171
172 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
173
174         webkitpy: Respect --dedicated-simulators flag
175         https://bugs.webkit.org/show_bug.cgi?id=194416
176         <rdar://problem/47894722>
177
178         Reviewed by Lucas Forschler.
179
180         * Scripts/webkitpy/port/device_port.py:
181         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
182         available devices can be safely ignored.
183
184 2019-02-07  Keith Rollin  <krollin@apple.com>
185
186         Remove extra copy of 100x100-red.tga
187         https://bugs.webkit.org/show_bug.cgi?id=194371
188         <rdar://problem/47873465>
189
190         Reviewed by Said Abou-Hallawa.
191
192         In order to help it pass its tests, Bug 194190 added a second copy of
193         the file 100x100-red.tga. However, it turns out that this additional
194         file wasn't actually needed, and that that sole previous copy was
195         sufficient. At the same time, this second copy -- which was copied to
196         the same location in the build output as the first copy -- now caused
197         XCBuild to complain because there were two production rules for the
198         same output file. Address this by removing the newly-added extra copy.
199
200         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
201         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
202
203 2019-02-07  Alex Christensen  <achristensen@webkit.org>
204
205         Deprecate WKBundlePageSetDefersLoading
206         https://bugs.webkit.org/show_bug.cgi?id=191394
207
208         Reviewed by Dean Jackson.
209
210         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
211         (WTR::TestRunner::setDefersLoading):
212
213 2019-02-07  Zalan Bujtas  <zalan@apple.com>
214
215         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
216         https://bugs.webkit.org/show_bug.cgi?id=194391
217
218         Reviewed by Antti Koivisto.
219
220         * LayoutReloaded/misc/LFC-passing-tests.txt:
221
222 2019-02-06  Keith Rollin  <krollin@apple.com>
223
224         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
225         https://bugs.webkit.org/show_bug.cgi?id=193975
226         <rdar://problem/47643306>
227
228         Reviewed by Tim Horton.
229
230         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
231         the Info.plist file into the bundle. This step is not necessary as the
232         implicit "bundle up all the build products into a framework" build
233         phase does this already. Having the Copy Bundle Resources phase do
234         this causes a conflict under XCBuild, which objects to two build
235         phases producing the same file (Info.plist). Address this by removing
236         Info.plist from the Copy Bundle Resources phase.
237
238         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
239
240 2019-02-06  Keith Rollin  <krollin@apple.com>
241
242         Really enable the automatic checking and regenerations of .xcfilelists during builds
243         https://bugs.webkit.org/show_bug.cgi?id=194357
244         <rdar://problem/47861231>
245
246         Reviewed by Chris Dumez.
247
248         Bug 194124 was supposed to enable the automatic checking and
249         regenerating of .xcfilelist files during the build. While related
250         changes were included in that patch, the change to actually enable the
251         operation somehow was omitted. This patch actually enables the
252         operation. The check-xcfilelist.sh scripts now check
253         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
254         from the checking.
255
256         * DumpRenderTree/Scripts/check-xcfilelists.sh:
257         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
258
259 2019-02-06  David Kilzer  <ddkilzer@apple.com>
260
261         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
262         <https://webkit.org/b/194286>
263         <rdar://problem/47815558>
264
265         Reviewed by Alexey Proskuryakov.
266
267         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
268         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
269         WKRetainPtr<> to avoid leaking the WKDataRef.
270
271 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
272
273         Unreviewed, fix a typo
274
275         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
276
277 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
278
279         [GTK][WPE] force libpsl build to use ICU in jhbuild
280         https://bugs.webkit.org/show_bug.cgi?id=194288
281
282         Reviewed by Carlos Garcia Campos.
283
284         * gtk/jhbuild.modules:
285         Require ICU for libpsl build in jhbuild, like done in WPE.
286
287 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
288
289         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
290         https://bugs.webkit.org/show_bug.cgi?id=194209
291
292         Reviewed by Carlos Garcia Campos.
293
294         Enhance TestCookieManager to ensure this doesn't happen again.
295
296         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
297         (testCookieManagerPersistentStorage):
298         (beforeAll):
299
300 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
301
302         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
303         https://bugs.webkit.org/show_bug.cgi?id=194324
304
305         Reviewed by Andy Estes.
306
307         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
308         part of the name is already implicit, since this is in testing code in TestOptions.
309
310         * WebKitTestRunner/TestController.cpp:
311         (WTR::TestController::generateContextConfiguration const):
312         (WTR::updateTestOptionsFromTestHeader):
313         * WebKitTestRunner/TestOptions.h:
314         (WTR::TestOptions::hasSameInitializationOptions const):
315
316 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
317
318         [ews-build] Allow * as platform for builders and workers
319         https://bugs.webkit.org/show_bug.cgi?id=188533
320
321         Reviewed by Lucas Forschler.
322
323         * BuildSlaveSupport/ews-build/loadConfig.py:
324         (checkWorkersAndBuildersForConsistency):
325
326 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
327
328         [ews-build] Add few bots to config.json
329         https://bugs.webkit.org/show_bug.cgi?id=194304
330
331         Reviewed by Lucas Forschler.
332
333         * BuildSlaveSupport/ews-build/config.json:
334
335 2019-02-05  Keith Rollin  <krollin@apple.com>
336
337         Enable the automatic checking and regenerations of .xcfilelists during builds
338         https://bugs.webkit.org/show_bug.cgi?id=194124
339         <rdar://problem/47721277>
340
341         Reviewed by Tim Horton.
342
343         Bug 193790 add a facility for checking -- during build time -- that
344         any needed .xcfilelist files are up-to-date and for updating them if
345         they are not. This facility was initially opt-in by setting
346         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
347         the process seemed robust. Its now time to enable this facility and
348         make it opt-out. If there is a need to disable this facility, set and
349         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
350         running `make` or `build-webkit`, or before running Xcode from the
351         command line.
352
353         Additionally, remove the step that generates a list of source files
354         going into the UnifiedSources build step. It's only necessarily to
355         specify Sources.txt and SourcesCocoa.txt as inputs.
356
357         * Scripts/generate-xcfilelists:
358
359 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
360
361         [GTK][WPE] force libpsl build to use ICU in jhbuild
362         https://bugs.webkit.org/show_bug.cgi?id=194288
363
364         Reviewed by Philippe Normand.
365
366         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
367         This can cause build failures if libidn is detected but libunistring is not available.
368
369         Make sure that ICU is used for runtime and builtin PSL data.
370
371         * gtk/jhbuild.modules:
372         * wpe/jhbuild.modules:
373
374 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
375
376         [ews-app] Modified timestamp should be updated on updating data
377         https://bugs.webkit.org/show_bug.cgi?id=194295
378
379         Reviewed by Lucas Forschler.
380
381         * BuildSlaveSupport/ews-app/ews/models/build.py:
382         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
383         * BuildSlaveSupport/ews-app/ews/models/step.py:
384
385 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
386
387         Unreviewed, rolling out r240742.
388
389         Causes crashes on iOS simulator.
390
391         Reverted changeset:
392
393         "[iOS] Keyups for non-modifier keys identified as "Dead" when
394         not focused in a content-editable element"
395         https://bugs.webkit.org/show_bug.cgi?id=192824
396         https://trac.webkit.org/changeset/240742
397
398 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
399
400         run-webkit-tests emits message "...running None" when running tests
401         https://bugs.webkit.org/show_bug.cgi?id=194133
402         <rdar://problem/47724738>
403
404         Reviewed by Lucas Forschler.
405
406         * Scripts/webkitpy/xcode/device_type.py:
407         (DeviceType.__str__): Use both version mapping tables and use just the variant
408         name if no version name is available.
409         * Scripts/webkitpy/xcode/device_type_unittest.py:
410         (DeviceTypeTest):
411         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
412         an associated named.
413
414 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
415
416         [WPE] require python3-setuptools for meson build in jhbuild
417         https://bugs.webkit.org/show_bug.cgi?id=194287
418
419         Reviewed by Philippe Normand.
420
421         python3-setuptools is needed to build meson in jhbuild.
422         It is already required by the GTK port.
423
424         * wpe/install-dependencies:
425
426 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
427
428         [ews-app] Add method to save BuilderMapping to database
429         https://bugs.webkit.org/show_bug.cgi?id=194264
430
431         Reviewed by Lucas Forschler.
432
433         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
434         (BuilderMapping.__str__):
435         (BuilderMapping):
436         (BuilderMapping.save_mapping):
437         (BuilderMapping.update_mapping):
438         (BuilderMapping.get_existing_mapping):
439         (BuilderMapping.is_valid_mapping):
440
441 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
442
443         [ews-app] Add timestamp fields for BuilderMappings
444         https://bugs.webkit.org/show_bug.cgi?id=194266
445
446         Reviewed by Lucas Forschler.
447
448         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
449         (BuilderMapping):
450
451 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
452
453         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
454         https://bugs.webkit.org/show_bug.cgi?id=174816
455
456         Reviewed by Michael Catanzaro.
457
458         Add tests for webkit_uri_for_display().
459
460         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
461         (testURIForDisplayUnaffected):
462         (testURIForDisplayAffected):
463         (beforeAll):
464         (afterAll):
465         * TestWebKitAPI/glib/CMakeLists.txt:
466
467 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
468
469         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
470         https://bugs.webkit.org/show_bug.cgi?id=194158
471         <rdar://problem/47737268>
472
473         Rubber-stamped by Aakash Jain.
474
475         * Scripts/webkitpy/port/device_port.py:
476         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
477
478 2019-02-04  Said Abou-Hallawa  <said@apple.com>
479
480         [CG] Enable setAdditionalSupportedImageTypes for WK1
481         https://bugs.webkit.org/show_bug.cgi?id=194190
482
483         Reviewed by Tim Horton.
484
485         Add a test similar to the one under WebKit Cocoa but make it create a
486         WebView instead of a WKWebView.
487
488         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
489         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
490         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
491         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
492         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
493         (TestWebKitAPI::runTest):
494         (TestWebKitAPI::TEST):
495
496 2019-02-04  Zalan Bujtas  <zalan@apple.com>
497
498         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
499         https://bugs.webkit.org/show_bug.cgi?id=194168
500
501         Reviewed by Simon Fraser.
502
503         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
504
505         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
506         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
507         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
508         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
509         (TEST):
510         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
511         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
512
513 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
514
515         REGRESSION (r237269): webkit-patch what-broke is broken 
516         https://bugs.webkit.org/show_bug.cgi?id=193025
517
518         Reviewed by Aakash Jain.
519
520         * Scripts/webkitpy/common/host.py:
521         (Host.buildbot):
522         (Host.bugzilla): Renamed to 'buildbot'.
523
524 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
525
526         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
527         https://bugs.webkit.org/show_bug.cgi?id=194207
528
529         Reviewed by Tim Horton.
530
531         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
532         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
533         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
534         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
535         start and delete forwards to remove the original attachment.
536
537         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
538         (TestWebKitAPI::TEST):
539
540 2019-02-04  Youenn Fablet  <youenn@apple.com>
541
542         Capture state should be managed consistently when doing process swapping
543         https://bugs.webkit.org/show_bug.cgi?id=194122
544         <rdar://problem/47609293>
545
546         Reviewed by Eric Carlson.
547
548         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
549         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
550         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
551         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
552         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
553         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
554         (WTR::TestRunner::isDoingMediaCapture const):
555         * WebKitTestRunner/InjectedBundle/TestRunner.h:
556         * WebKitTestRunner/TestController.cpp:
557         (WTR::TestController::isDoingMediaCapture const):
558         * WebKitTestRunner/TestController.h:
559         * WebKitTestRunner/TestInvocation.cpp:
560         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
561         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
562         (WTR::TestController::isDoingMediaCapture const):
563
564 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
565
566         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
567         https://bugs.webkit.org/show_bug.cgi?id=194142
568
569         Reviewed by Ross Kirsling.
570
571         There three 'separator' variables in TestController.cpp. Renamed
572         it 'pathSeparator', and unified them.
573
574         * WebKitTestRunner/TestController.cpp:
575         (WTR::TestController::generateContextConfiguration const):
576         (WTR::createTestURL):
577         (WTR::TestController::platformAdjustContext):
578
579 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
580
581         Make setNeedsLayout on the root more explicitly about triggering its side-effects
582         https://bugs.webkit.org/show_bug.cgi?id=194198
583
584         Reviewed by Antti Koivisto.
585
586         No need to set the banner heights on navigation now, since Page stores them.
587
588         * MiniBrowser/mac/WK2BrowserWindowController.m:
589         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
590
591 2019-02-03  John Wilander  <wilander@apple.com>
592
593         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
594         https://bugs.webkit.org/show_bug.cgi?id=194104
595         <rdar://problem/47649991>
596
597         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
598
599         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
600         (TestWebKitAPI::TEST):
601             Changed numeric types from unsigned short to uint32_t.
602
603 2019-02-02  David Kilzer  <ddkilzer@apple.com>
604
605         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
606         <https://webkit.org/b/194178>
607         <rdar://problem/47753473>
608
609         Reviewed by Alexey Proskuryakov.
610
611         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
612         (WTR::uninstallFakeHelvetica): Pass nullptr into
613         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
614
615 2019-02-02  Zalan Bujtas  <zalan@apple.com>
616
617         [LFC] Initialize ICB's style with fixed width/height.
618         https://bugs.webkit.org/show_bug.cgi?id=194188
619
620         Reviewed by Antti Koivisto.
621
622         * LayoutReloaded/misc/LFC-passing-tests.txt:
623
624 2019-02-02  Zalan Bujtas  <zalan@apple.com>
625
626         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
627         https://bugs.webkit.org/show_bug.cgi?id=194185
628
629         Reviewed by Antti Koivisto.
630
631         * LayoutReloaded/misc/LFC-passing-tests.txt:
632
633 2018-12-16  Darin Adler  <darin@apple.com>
634
635         Convert additional String::format clients to alternative approaches
636         https://bugs.webkit.org/show_bug.cgi?id=192746
637
638         Reviewed by Alexey Proskuryakov.
639
640         * WebKitTestRunner/TestController.cpp:
641         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
642         as an intermediate in code that ultimately constructs a WTF::String.
643         (WTR::userMediaOriginHash): Use makeString.
644         (WTR::TestController::didNavigateWithNavigationData): More of the same.
645         (WTR::TestController::didPerformClientRedirect): Ditto.
646         (WTR::TestController::didPerformServerRedirect): Ditto.
647         (WTR::TestController::didUpdateHistoryTitle): Ditto.
648
649 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
650
651         [ews-build] Add unit test to verify builder keys
652         https://bugs.webkit.org/show_bug.cgi?id=194152
653
654         Reviewed by Lucas Forschler.
655
656         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
657         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
658
659 2019-02-01  Zalan Bujtas  <zalan@apple.com>
660
661         [LFC] Expand tests coverage (12 new tests -> 787)
662
663         Unreviewed test gardening.
664
665         * LayoutReloaded/misc/LFC-passing-tests.txt:
666
667 2019-02-01  Zalan Bujtas  <zalan@apple.com>
668
669         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
670         https://bugs.webkit.org/show_bug.cgi?id=194163
671
672         Reviewed by Simon Fraser.
673
674         775
675
676         * LayoutReloaded/misc/LFC-passing-tests.txt:
677
678 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
679
680         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
681         https://bugs.webkit.org/show_bug.cgi?id=194140
682         <rdar://problem/47728098>
683
684         Reviewed by Tim Horton.
685
686         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
687         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
688         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
689
690         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
691         test to induce an IPC deadlock when presenting a modal alert during touch start.
692
693         * WebKitTestRunner/InjectedBundle/TestRunner.h:
694         * WebKitTestRunner/TestController.cpp:
695         (WTR::runJavaScriptAlert):
696
697         Add a client callback function for running JavaScript alerts.
698
699         (WTR::TestController::createOtherPage):
700         (WTR::TestController::generateContextConfiguration const):
701
702         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
703         the fix in this patch.
704
705         (WTR::TestController::createWebViewWithOptions):
706
707         Plumb TestOptions to generateContextConfiguration.
708
709         (WTR::TestController::resetPreferencesToConsistentValues):
710         (WTR::TestController::resetStateToConsistentValues):
711         (WTR::updateTestOptionsFromTestHeader):
712         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
713         (WTR::TestController::handleJavaScriptAlert):
714         * WebKitTestRunner/TestController.h:
715         * WebKitTestRunner/TestInvocation.cpp:
716         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
717         * WebKitTestRunner/TestOptions.h:
718         (WTR::TestOptions::hasSameInitializationOptions const):
719
720 2019-02-01  Chris Dumez  <cdumez@apple.com>
721
722         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
723         https://bugs.webkit.org/show_bug.cgi?id=193740
724         <rdar://problem/47527267>
725
726         Reviewed by Alex Christensen.
727
728         Add API test coverage.
729
730         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
731
732 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
733
734         [ews-app] Add display name field to BuilderMapping model
735         https://bugs.webkit.org/show_bug.cgi?id=194153
736
737         Reviewed by Lucas Forschler.
738
739         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
740         (BuilderMapping):
741
742 2019-02-01  Youenn Fablet  <youenn@apple.com>
743
744         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
745         https://bugs.webkit.org/show_bug.cgi?id=194155
746
747         Reviewed by Eric Carlson.
748
749         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
750         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
751         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
752
753 2019-02-01  Zalan Bujtas  <zalan@apple.com>
754
755         [LFC] Adjust replaced element's intrinsic ratio
756         https://bugs.webkit.org/show_bug.cgi?id=194154
757
758         Reviewed by Antti Koivisto.
759
760         761
761
762         * LayoutReloaded/misc/LFC-passing-tests.txt:
763
764 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
765
766         [WPE] Show test results in minibrowser
767         https://bugs.webkit.org/show_bug.cgi?id=194150
768
769         Reviewed by Žan Doberšek.
770
771         * Scripts/webkitpy/port/wpe.py:
772         (WPEPort.show_results_html_file):
773
774 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
775
776         [WPE] MiniBrowser: add ky bindings for back/forward navigation
777         https://bugs.webkit.org/show_bug.cgi?id=194151
778
779         Reviewed by Žan Doberšek.
780
781         ALT + <- go back
782         ALT + -> go forward
783
784         * MiniBrowser/wpe/main.cpp:
785         (main):
786
787 2019-02-01  Zalan Bujtas  <zalan@apple.com>
788
789         [LFC] Set intrinsic size on Layout::Replaced
790         https://bugs.webkit.org/show_bug.cgi?id=194139
791
792         Reviewed by Antti Koivisto.
793
794         744
795
796         * LayoutReloaded/misc/LFC-passing-tests.txt:
797
798 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
799
800         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
801         https://bugs.webkit.org/show_bug.cgi?id=194146
802
803         Reviewed by Xabier Rodriguez-Calvar.
804
805         It allows to open relative paths.
806
807         * MiniBrowser/wpe/main.cpp:
808         (main):
809
810 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
811
812         Update flakiness dashboard configuration after recent queue changes
813         https://bugs.webkit.org/show_bug.cgi?id=194127
814
815         Rubber-stamped by Aakash Jain.
816
817         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
818
819         * TestResultServer/static-dashboards/builders.jsonp:
820
821 2019-01-31  Youenn Fablet  <youenn@apple.com>
822
823         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
824         https://bugs.webkit.org/show_bug.cgi?id=194106
825         <rdar://problem/47676333>
826
827         Reviewed by Ryosuke Niwa.
828
829         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
830         (TestWebKitAPI::didFinishNavigation):
831         (TestWebKitAPI::TEST):
832         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
833
834 2019-01-31  Chris Dumez  <cdumez@apple.com>
835
836         Page zoom level is lost after a process swap or a crash
837         https://bugs.webkit.org/show_bug.cgi?id=194105
838         <rdar://problem/47610781>
839
840         Reviewed by Alex Christensen.
841
842         Add API test coverage.
843
844         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
845         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
846
847 2019-01-31  Alex Christensen  <achristensen@webkit.org>
848
849         Revert r238819 which is unneeded and caused a performance regression.
850         https://bugs.webkit.org/show_bug.cgi?id=192272
851         <rdar://problem/46664625>
852
853         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
854         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
855         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
856
857 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
858
859         Formalize WebKitAdditions mechanism of LoadOptimizer
860         https://bugs.webkit.org/show_bug.cgi?id=193886
861         <rdar://problem/47696809>
862
863         Reviewed by Brent Fulgham.
864
865         * MiniBrowser/MiniBrowser.entitlements:
866         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
867
868 2019-01-31  Zalan Bujtas  <zalan@apple.com>
869
870         [LFC] Margin before/after/start/end initial value is 0 and not auto.
871         https://bugs.webkit.org/show_bug.cgi?id=194090
872
873         Reviewed by Antti Koivisto.
874
875         * LayoutReloaded/misc/LFC-passing-tests.txt:
876
877 2019-01-31  Zalan Bujtas  <zalan@apple.com>
878
879         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
880         https://bugs.webkit.org/show_bug.cgi?id=194074
881
882         Reviewed by Antti Koivisto.
883
884         * LayoutReloaded/misc/LFC-passing-tests.txt:
885
886 2019-01-31  Zalan Bujtas  <zalan@apple.com>
887
888         [LFC][BFC] Add support for block level replaced box.
889         https://bugs.webkit.org/show_bug.cgi?id=194071
890
891         Reviewed by Antti Koivisto.
892
893         * LayoutReloaded/misc/LFC-passing-tests.txt:
894
895 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
896
897         Fix WebKitTestRunner's testPath with Windows full paths
898         https://bugs.webkit.org/show_bug.cgi?id=194012
899
900         Reviewed by Alex Christensen.
901
902         updateTestOptionsFromTestHeader failed to open test files because
903         testPath returned wrong file paths. It returned a path "/C:/..."
904         if a URL "file:///C:/..." was given.
905
906         * WebKitTestRunner/TestController.cpp:
907         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
908
909 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
910
911         [WPE] Bump font related dependencies to match the GTK+ port
912         https://bugs.webkit.org/show_bug.cgi?id=194017
913
914         Reviewed by Žan Doberšek.
915
916         * wpe/jhbuild.modules:
917         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
918         * wpe/patches/icudata-stdlibs.patch: Added.
919
920 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
921
922         Enable swipe tests on iOS
923         https://bugs.webkit.org/show_bug.cgi?id=194076
924
925         Reviewed by Geoffrey Garen.
926
927         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
928         it causes a debug assertion failure in runUIScript.
929
930         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
931         (WTR::UIScriptController::beginBackSwipe):
932         (WTR::UIScriptController::completeBackSwipe):
933
934 2019-01-30  Keith Rollin  <krollin@apple.com>
935
936         Use correct printf format specifier
937         https://bugs.webkit.org/show_bug.cgi?id=194062
938         <rdar://problem/47686167>
939
940         Reviewed by Alexey Proskuryakov.
941
942         LayoutTestSpellChecker.mm is trying to format a variable of type
943         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
944         actually an unsigned long long. Fix this by formatting with %llu.
945
946         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
947         (-[LayoutTestTextCheckingResult description]):
948
949 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
950
951         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
952         https://bugs.webkit.org/show_bug.cgi?id=193979
953
954         Reviewed by Wenson Hsieh.
955
956         Fix the test for iOS. Make the test work with iOS UA string.
957
958         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
959
960 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
961
962         Replace High Sierra LLINT CLoop bot due to hardware failure
963         https://bugs.webkit.org/show_bug.cgi?id=194066
964
965         Reviewed by Aakash Jain.
966
967         * BuildSlaveSupport/build.webkit.org-config/config.json:
968
969 2019-01-30  Keith Rollin  <krollin@apple.com>
970
971         [NSDragItem init] is unavailable
972         https://bugs.webkit.org/show_bug.cgi?id=194059
973         <rdar://problem/47685715>
974
975         Reviewed by Wenson Hsieh.
976
977         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
978         DumpRenderTree and TestWebKitAPI, which both try to create an
979         NSDragItem in a manner that invokes this method. Address this by using
980         -initWithPasteboardWriter instead.
981
982         Note that the parameter passed to initWithPasteboardWriter is likely
983         incorrect. In both cases, the object passed does not conform to
984         NSPasteboardWriting. However, with this fix, we're no worse off than
985         before, and can now perform builds with newer compilers and SDKs until
986         a real fix can be crafted. That work is tracked in
987         https://bugs.webkit.org/show_bug.cgi?id=194060
988
989         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
990         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
991         * TestWebKitAPI/mac/TestDraggingInfo.mm:
992         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
993
994 2019-01-30  Daniel Bates  <dabates@apple.com>
995
996         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
997         https://bugs.webkit.org/show_bug.cgi?id=192824
998         <rdar://problem/47100332>
999
1000         Reviewed by Wenson Hsieh.
1001
1002         Fix a bug where the wrong usage code was used for F13 thru F24.
1003
1004         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1005         (keyCodeForDOMFunctionKey):
1006
1007 2019-01-30  Chris Dumez  <cdumez@apple.com>
1008
1009         Regression(PSON) Load hang can occur on history navigation
1010         https://bugs.webkit.org/show_bug.cgi?id=194030
1011         <rdar://problem/47656939>
1012
1013         Reviewed by Antti Koivisto.
1014
1015         Add API test coverage.
1016
1017         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1018
1019 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1020
1021         [LFC] Expand tests coverage.
1022
1023         Unreviewed test gardening.
1024
1025         * LayoutReloaded/misc/LFC-passing-tests.txt:
1026
1027 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
1028
1029         [Flatpak] Add openjpeg support
1030         https://bugs.webkit.org/show_bug.cgi?id=194019
1031
1032         Reviewed by Michael Catanzaro.
1033
1034         * flatpak/org.webkit.CommonModules.yaml:
1035
1036 2019-01-30  Commit Queue  <commit-queue@webkit.org>
1037
1038         Unreviewed, rolling out r240708.
1039         https://bugs.webkit.org/show_bug.cgi?id=194022
1040
1041         It broke WPE build (Requested by KaL on #webkit).
1042
1043         Reverted changeset:
1044
1045         "[WPE] Bump font related dependencies to match the GTK+ port"
1046         https://bugs.webkit.org/show_bug.cgi?id=194017
1047         https://trac.webkit.org/changeset/240708
1048
1049 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1050
1051         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
1052         https://bugs.webkit.org/show_bug.cgi?id=194001
1053
1054         Reviewed by Antti Koivisto.
1055
1056         * LayoutReloaded/misc/LFC-passing-tests.txt:
1057
1058 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1059
1060         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
1061         https://bugs.webkit.org/show_bug.cgi?id=194020
1062
1063         Reviewed by Antti Koivisto.
1064
1065         * LayoutReloaded/misc/LFC-passing-tests.txt:
1066
1067 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
1068
1069         AX: Support color well on iOS
1070         https://bugs.webkit.org/show_bug.cgi?id=194010
1071
1072         Reviewed by Joanmarie Diggs.
1073
1074         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1075         (WTR::AccessibilityUIElement::stringAttributeValue):
1076
1077 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1078
1079         [WPE] Bump font related dependencies to match the GTK+ port
1080         https://bugs.webkit.org/show_bug.cgi?id=194017
1081
1082         Reviewed by Žan Doberšek.
1083
1084         * wpe/jhbuild.modules:
1085         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
1086         * wpe/patches/icudata-stdlibs.patch: Added.
1087
1088 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
1089
1090         [Mac] Update window scale API usage
1091         https://bugs.webkit.org/show_bug.cgi?id=193991
1092         rdar://problem/47614795
1093
1094         Reviewed by Tim Horton.
1095
1096         * DumpRenderTree/mac/DumpRenderTree.mm:
1097         (changeWindowScaleIfNeeded):
1098         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1099         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1100         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1101
1102 2019-01-29  Chris Dumez  <cdumez@apple.com>
1103
1104         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
1105         https://bugs.webkit.org/show_bug.cgi?id=193977
1106         <rdar://problem/47643716>
1107
1108         Reviewed by Geoff Garen.
1109
1110         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
1111         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
1112         to the previous provisional committing *before* we make the last load. 
1113
1114         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1115
1116 2019-01-29  Youenn Fablet  <youenn@apple.com>
1117
1118         Adopt new SPI to evaluate server certificate trust
1119         https://bugs.webkit.org/show_bug.cgi?id=193355
1120
1121         Reviewed by Alex Christensen.
1122
1123         Add infrastructure to handle HTTPS server trust evaluation testing.
1124
1125         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1126         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1127         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
1128         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
1129         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
1130         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1131         * WebKitTestRunner/TestController.cpp:
1132         (WTR::TestController::resetPreferencesToConsistentValues):
1133         (WTR::TestController::didReceiveAuthenticationChallenge):
1134         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
1135         * WebKitTestRunner/TestController.h:
1136         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
1137         * WebKitTestRunner/TestInvocation.cpp:
1138         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1139         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1140         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
1141
1142 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1143
1144         [ews-build] Add build step to print bot Configuration
1145         https://bugs.webkit.org/show_bug.cgi?id=193887
1146
1147         Reviewed by Lucas Forschler.
1148
1149         * BuildSlaveSupport/ews-build/steps.py:
1150         (PrintConfiguration): Build step to print configuration.
1151         * BuildSlaveSupport/ews-build/factories.py:
1152
1153 2019-01-29  Chris Dumez  <cdumez@apple.com>
1154
1155         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
1156         https://bugs.webkit.org/show_bug.cgi?id=193967
1157         <rdar://problem/47635348>
1158
1159         Reviewed by Alex Christensen.
1160
1161         Add API test coverage.
1162
1163         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1164         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
1165
1166 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1167
1168         [ews-app] Handle incoming results data
1169         https://bugs.webkit.org/show_bug.cgi?id=193973
1170
1171         Reviewed by Lucas Forschler.
1172
1173         * BuildSlaveSupport/ews-app/ews/views/results.py:
1174
1175 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1176
1177         [ews-app] Make the results url generic
1178         https://bugs.webkit.org/show_bug.cgi?id=193928
1179
1180         Reviewed by Lucas Forschler.
1181
1182         * BuildSlaveSupport/ews-app/ews/urls.py:
1183
1184 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1185
1186         [ews-build] Configure buildbot to send events to ews-app
1187         https://bugs.webkit.org/show_bug.cgi?id=193968
1188
1189         Reviewed by Lucas Forschler.
1190
1191         * BuildSlaveSupport/ews-build/events.py: Added.
1192         * BuildSlaveSupport/ews-build/master.cfg:
1193
1194 2019-01-29  Keith Rollin  <krollin@apple.com>
1195
1196         Add .xcfilelists to Run Script build phases
1197         https://bugs.webkit.org/show_bug.cgi?id=193792
1198         <rdar://problem/47201785>
1199
1200         Reviewed by Alex Christensen.
1201
1202         As part of supporting XCBuild, update the necessary Run Script build
1203         phases in their Xcode projects to refer to their associated
1204         .xcfilelist files.
1205
1206         Note that the addition of these files bumps the Xcode project version
1207         number to something that's Xcode 10 compatible. This change means that
1208         older versions of the Xcode IDE can't read these projects. Nor can it
1209         fully load workspaces that refer to these projects (the updated
1210         projects are shown as non-expandable placeholders). `xcodebuild` can
1211         still build these projects; it's just that the IDE can't open them.
1212
1213         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1214         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1215
1216 2019-01-29  John Wilander  <wilander@apple.com>
1217
1218         Add data abstraction and validation for Ad Click Attribution
1219         https://bugs.webkit.org/show_bug.cgi?id=193916
1220         <rdar://problem/47603481>
1221
1222         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
1223
1224         Ad click attribution has two steps. First, the storage of an ad
1225         campaign ID for a click that takes the user to a destination
1226         site. Second, a conversion on the destination site that can be
1227         attributed to the ad click.
1228
1229         This patch adds a class that represents a request for ad click
1230         attribution. Validation makes sure that the bits of entropy
1231         reported through this mechanism is limited.
1232
1233         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1234         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
1235         (TestWebKitAPI::TEST):
1236
1237 2019-01-29  Chris Dumez  <cdumez@apple.com>
1238
1239         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
1240         https://bugs.webkit.org/show_bug.cgi?id=193932
1241         <rdar://problem/47598947>
1242
1243         Reviewed by Brady Eidson.
1244
1245         Add API test coverage.
1246
1247         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1248
1249 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1250
1251         Adding new passing LFC tests.
1252
1253         Unreviewed test gardening.
1254
1255         * LayoutReloaded/misc/LFC-passing-tests.txt:
1256
1257 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1258
1259         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
1260         https://bugs.webkit.org/show_bug.cgi?id=193964
1261
1262         Reviewed by Antti Koivisto.
1263
1264         * LayoutReloaded/misc/LFC-passing-tests.txt:
1265
1266 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1267
1268         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
1269         https://bugs.webkit.org/show_bug.cgi?id=193954
1270
1271         Reviewed by Antti Koivisto.
1272
1273         * LayoutReloaded/misc/LFC-passing-tests.txt:
1274
1275 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1276
1277         WebDriver: add support for running subtests
1278         https://bugs.webkit.org/show_bug.cgi?id=193904
1279
1280         Reviewed by Michael Catanzaro.
1281
1282         pytest already supports it by passing test.py::subtest, so we can do the same.
1283
1284         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
1285         (get_item_name): Made this global.
1286         (CollectRecorder.__init__): Receive the parameter to ignore.
1287         (CollectRecorder.pytest_collectreport): Collect also the subtests.
1288         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
1289         (collect): Add parameter to ignore.
1290         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
1291         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
1292         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
1293         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
1294         (WebDriverTestRunnerSelenium.run): Ditto.
1295         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
1296         (WebDriverTestRunnerW3C.collect_tests): Ditto.
1297         (WebDriverTestRunnerW3C.run): Ditto.
1298
1299 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
1300
1301         User agent string override for navigator.userAgent should be site specific quirks
1302         https://bugs.webkit.org/show_bug.cgi?id=193950
1303
1304         Reviewed by Brent Fulgham.
1305
1306         Updated per the _WKWebsitePolicies rename.
1307
1308         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1309         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1310
1311 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
1312
1313         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
1314         https://bugs.webkit.org/show_bug.cgi?id=193941
1315
1316         Reviewed by Alex Christensen.
1317
1318         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
1319         * TestWebKitAPI/Tests/WTF/Condition.cpp:
1320         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1321         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1322         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1323         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
1324         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
1325         * TestWebKitAPI/Tests/WTF/Time.cpp:
1326         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
1327         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
1328         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1329         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1330
1331 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
1332
1333         Unreviewed, reorder my emails to fix autocomplete in bugzilla
1334
1335         * Scripts/webkitpy/common/config/contributors.json:
1336
1337 2019-01-28  Andy Estes  <aestes@apple.com>
1338
1339         [watchOS] Enable Parental Controls content filtering
1340         https://bugs.webkit.org/show_bug.cgi?id=193939
1341         <rdar://problem/46641912>
1342
1343         Reviewed by Ryosuke Niwa.
1344
1345         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1346
1347 2019-01-28  David Kilzer  <ddkilzer@apple.com>
1348
1349         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
1350         <https://webkit.org/b/193884>
1351
1352         Reviewed by Jiewen Tan.
1353
1354         * Scripts/webkitpy/style/checkers/cpp.py:
1355         (check_language): Add LocalAuthentication to
1356         `frameworks_with_soft_links`.
1357
1358 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
1359
1360         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
1361         https://bugs.webkit.org/show_bug.cgi?id=193891
1362
1363         Reviewed by Ross Kirsling.
1364
1365         There were three problems in window sizes of WebView and the host window.
1366         1. The sizes of pixel image output were incorrect.
1367         2. The host window is going to appear after window.resize was invoked.
1368         3. window.resize resized only the host window, not WebView.
1369
1370         This change solves them with a following approach.
1371         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
1372         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
1373            as well as DumpRenderTree in order to match the client area and the window area.
1374         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
1375         d. PlatformWebView::setWindowFrame changes both window sizes.
1376         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
1377
1378         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1379         (WTR::PlatformWebView::PlatformWebView): Create the host window
1380         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
1381         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
1382         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
1383
1384 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1385
1386         [ews-app] Add method to save Step data to database
1387         https://bugs.webkit.org/show_bug.cgi?id=193890
1388
1389         Reviewed by Lucas Forschler.
1390
1391         * BuildSlaveSupport/ews-app/ews/models/step.py:
1392         (Step.save_step): Method to save step data.
1393         (Step.update_step): Method to update step data.
1394         (Step.get_existing_step): Method to fetch existing step from database.
1395         (Step.is_valid_result): Method to validate valid step result.
1396
1397 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1398
1399         [ews-app] Add method to save Build data to database
1400         https://bugs.webkit.org/show_bug.cgi?id=193735
1401
1402         Reviewed by Lucas Forschler.
1403
1404         * BuildSlaveSupport/ews-app/ews/models/build.py:
1405         (Build.save_build): Method to save build information to database.
1406         (Build.get_existing_build): Method to fetch existing build from database.
1407         (Build.is_valid_result): Method to validate build result.
1408         * BuildSlaveSupport/ews-app/ews/common/util.py:
1409         (is_valid_int_id): Method to validate valid id.
1410
1411 2019-01-28  Chris Dumez  <cdumez@apple.com>
1412
1413         Regression(PSON) Crash under WebPageProxy::didStartProgress()
1414         https://bugs.webkit.org/show_bug.cgi?id=193915
1415         <rdar://problem/47560907>
1416
1417         Reviewed by Alex Christensen.
1418
1419         Add API test coverage.
1420
1421         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1422
1423 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1424
1425         [ews-app] Rename id variables
1426         https://bugs.webkit.org/show_bug.cgi?id=193883
1427
1428         Reviewed by Lucas Forschler.
1429
1430         * BuildSlaveSupport/ews-app/ews/models/build.py:
1431         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1432         * BuildSlaveSupport/ews-app/ews/models/step.py:
1433         * BuildSlaveSupport/ews-app/ews/urls.py:
1434         * BuildSlaveSupport/ews-app/ews/views/patch.py:
1435         * BuildSlaveSupport/ews-app/ews/views/results.py:
1436         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1437
1438 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1439
1440         [ews-app] Allow certain fields to be empty
1441         https://bugs.webkit.org/show_bug.cgi?id=193892
1442
1443         Reviewed by Lucas Forschler.
1444
1445         * BuildSlaveSupport/ews-app/ews/models/build.py:
1446         * BuildSlaveSupport/ews-app/ews/models/step.py:
1447
1448 2019-01-28  Rob Buis  <rbuis@igalia.com>
1449
1450         Update MIME type parser
1451         https://bugs.webkit.org/show_bug.cgi?id=180526
1452
1453         Reviewed by Frédéric Wang.
1454
1455         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1456         (TestWebKitAPI::TEST):
1457
1458 2019-01-28  Zalan Bujtas  <zalan@apple.com>
1459
1460         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
1461         https://bugs.webkit.org/show_bug.cgi?id=193896
1462
1463         Reviewed by Antti Koivisto.
1464
1465         * LayoutReloaded/misc/LFC-passing-tests.txt:
1466
1467 2018-12-15  Darin Adler  <darin@apple.com>
1468
1469         Replace many uses of String::format with more type-safe alternatives
1470         https://bugs.webkit.org/show_bug.cgi?id=192742
1471
1472         Reviewed by Mark Lam.
1473
1474         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1475         (WTR::cacheTestRunnerCallback): Use makeString.
1476         * WebKitTestRunner/TestController.cpp:
1477         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
1478         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
1479
1480 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
1481
1482         Use a load optimizer for some sites
1483         https://bugs.webkit.org/show_bug.cgi?id=193881
1484         <rdar://problem/46325455>
1485
1486         Reviewed by Brent Fulgham.
1487
1488         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1489         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
1490
1491 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
1492
1493         AX: Introduce a static accessibility tree
1494         https://bugs.webkit.org/show_bug.cgi?id=193348
1495         <rdar://problem/47203295>
1496
1497         Reviewed by Ryosuke Niwa.
1498
1499         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1500
1501 2019-01-26  Zalan Bujtas  <zalan@apple.com>
1502
1503         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
1504         https://bugs.webkit.org/show_bug.cgi?id=193867
1505
1506         Reviewed by Antti Koivisto.
1507
1508         * LayoutReloaded/misc/LFC-passing-tests.txt:
1509
1510 2019-01-26  Zalan Bujtas  <zalan@apple.com>
1511
1512         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
1513         https://bugs.webkit.org/show_bug.cgi?id=193865
1514
1515         Reviewed by Antti Koivisto.
1516
1517         * LayoutReloaded/misc/LFC-passing-tests.txt:
1518
1519 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1520
1521         Need a mechanism to override navigator.userAgent
1522         https://bugs.webkit.org/show_bug.cgi?id=193762
1523         <rdar://problem/47504939>
1524
1525         Reviewed by Brent Fulgham.
1526
1527         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
1528
1529         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1530         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1531         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
1532
1533 2019-01-25  Dean Jackson  <dino@apple.com>
1534
1535         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
1536         https://bugs.webkit.org/show_bug.cgi?id=193831
1537         <rdar://problem/47399263>
1538
1539         Reviewed by Chris Dumez.
1540
1541         Two new tests that exercise cross-origin and same-origin System
1542         Previews.
1543
1544         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1545
1546 2019-01-25  Keith Rollin  <krollin@apple.com>
1547
1548         Update Xcode projects with "Check .xcfilelists" build phase
1549         https://bugs.webkit.org/show_bug.cgi?id=193790
1550         <rdar://problem/47201374>
1551
1552         Reviewed by Alex Christensen.
1553
1554         Support for XCBuild includes specifying inputs and outputs to various
1555         Run Script build phases. These inputs and outputs are specified as
1556         .xcfilelist files. Once created, these .xcfilelist files need to be
1557         kept up-to-date. In order to check that they are up-to-date or not,
1558         add an Xcode build step that invokes an external script that performs
1559         the checking. If the .xcfilelists are found to be out-of-date, update
1560         them, halt the build, and instruct the developer to restart the build
1561         with up-to-date files.
1562
1563         At this time, the checking and regenerating is performed only if the
1564         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
1565         who want to use this facility can set this variable and test out the
1566         checking/regenerating. Once it seems like there are no egregious
1567         issues that upset a developer's workflow, we'll unconditionally enable
1568         this facility.
1569
1570         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1571         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
1572         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
1573         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1574
1575 2019-01-25  Keith Rollin  <krollin@apple.com>
1576
1577         Update Xcode projects with "Apply Configuration to XCFileLists" build target
1578         https://bugs.webkit.org/show_bug.cgi?id=193781
1579         <rdar://problem/47201153>
1580
1581         Reviewed by Alex Christensen.
1582
1583         Part of generating the .xcfilelists used as part of adopting XCBuild
1584         includes running `make DerivedSources.make` from a standalone script.
1585         It’s important for this invocation to have the same environment as
1586         when the actual build invokes `make DerivedSources.make`. If the
1587         environments are different, then the two invocations will provide
1588         different results. In order to get the same environment in the
1589         standalone script, have the script launch xcodebuild targeting the
1590         "Apply Configuration to XCFileLists" build target, which will then
1591         re-invoke our standalone script. The script is now running again, this
1592         time in an environment with all workspace, project, target, xcconfig
1593         and other environment variables established.
1594
1595         The "Apply Configuration to XCFileLists" build target accomplishes
1596         this task via a small embedded shell script that consists only of:
1597
1598             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
1599
1600         The process that invokes "Apply Configuration to XCFileLists" first
1601         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
1602         evaluated and exports it into the shell environment. When xcodebuild
1603         is invoked, it inherits the value of this variable and can `eval` the
1604         contents of that variable. Our external standalone script can then set
1605         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
1606         of command-line parameters needed to restart itself in the appropriate
1607         state.
1608
1609         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1610         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1611
1612 2019-01-25  Alex Christensen  <achristensen@webkit.org>
1613
1614         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
1615         https://bugs.webkit.org/show_bug.cgi?id=193802
1616         <rdar://problem/46010580>
1617
1618         Reviewed by Andy Estes.
1619
1620         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1621         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
1622         (TEST):
1623
1624 2019-01-25  Daniel Bates  <dabates@apple.com>
1625
1626         [iOS] uiController.keyDown() does not translate Control modified key
1627         https://bugs.webkit.org/show_bug.cgi?id=192898
1628
1629         Reviewed by Wenson Hsieh.
1630
1631         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
1632         key translation, as applicable. Among other cases, key translation occurs when performing
1633         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
1634         also makes the behavior of uiController.keyDown() more closely match the behavior of a
1635         human pressing down and releasing key(s) using a hardware keyboard.
1636
1637         * WebKitTestRunner/ios/HIDEventGenerator.h:
1638         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1639         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
1640
1641         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
1642         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
1643         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1644         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1645         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
1646         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1647         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
1648         (-[HIDEventGenerator longPress:completionBlock:]):
1649         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
1650         Update code for above renaming.
1651
1652         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
1653         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
1654
1655         (-[HIDEventGenerator keyDown:]): Added.
1656         (-[HIDEventGenerator keyUp:]): Added.
1657         (-[HIDEventGenerator keyPress:completionBlock:]):
1658         (-[HIDEventGenerator eventDispatchThreadEntry:]):
1659         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
1660         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1661         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
1662         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
1663         (WTR::parseModifier): Deleted.
1664
1665 2019-01-25  Keith Rollin  <krollin@apple.com>
1666
1667         Complete the implementation of generate-xcfilelists
1668         https://bugs.webkit.org/show_bug.cgi?id=193782
1669
1670         Reviewed by Alex Christensen.
1671
1672         A preliminary version of generate-xcfilelists was added in r238008.
1673         This patch updates that script in order to:
1674
1675         - Support checking of .xcfilelists
1676         - Perform better execution of `make DerivedSources.make` by
1677           relaunching generate-xcfilelists under xcodebuild
1678         - Support incremental generation and checking of .xcfilelists
1679         - Support supplementary .xcfilelists files from WebKitAdditions
1680         - Support being wrapped by parallel version of generate-xcfilelists in
1681           Internal that adds support for (re)generating WebKit projects in
1682           that repo.
1683         - Support builds that have been performed in WebKitBuild as well as
1684           ~/Library/Developer/code/DerivedData
1685         - Increase robustness and debugging facilities.
1686
1687         * Scripts/generate-xcfilelists:
1688
1689 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
1690
1691         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1692         https://bugs.webkit.org/show_bug.cgi?id=193297
1693         <rdar://problem/47158841>
1694
1695         Unreviewed test case fix.
1696
1697         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
1698         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
1699
1700         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1701         (TEST):
1702
1703 2019-01-25  Keith Rollin  <krollin@apple.com>
1704
1705         Update existing .xcfilelists
1706         https://bugs.webkit.org/show_bug.cgi?id=193791
1707         <rdar://problem/47201706>
1708
1709         Reviewed by Alex Christensen.
1710
1711         Many .xcfilelist files were added in r238824 in order to support
1712         XCBuild. Update these with recent changes to the set of build files
1713         and with the current generate-xcfilelist script.
1714
1715         * DumpRenderTree/DerivedSources-input.xcfilelist:
1716         * DumpRenderTree/DerivedSources-output.xcfilelist:
1717         * WebKitTestRunner/DerivedSources-input.xcfilelist:
1718         * WebKitTestRunner/DerivedSources-output.xcfilelist:
1719
1720 2019-01-25  Keith Rollin  <krollin@apple.com>
1721
1722         Fix missing dependencies in extract-dependencies-from-makefile
1723         https://bugs.webkit.org/show_bug.cgi?id=193783
1724         <rdar://problem/47201571>
1725
1726         Reviewed by Alex Christensen.
1727
1728         The extract-dependencies-from-makefile script generates .xcfilelists
1729         for XCBuild by invoking a makefile in --debug mode, parsing the
1730         dependency information in the output, and extracting information
1731         regarding targets and dependents. However, the way `make` emits this
1732         dependency information is not rigorous, and so we need to determine
1733         what lines to look for and parse by trial and error. This approach
1734         didn't coriginally atch all the information we needed to collect, so
1735         update the script to look for the additional lines we now know to look
1736         for.
1737
1738         * Scripts/extract-dependencies-from-makefile:
1739         (Parser):
1740         (Parser.addTarget):
1741         (Parser.addPrereq):
1742         (Parser.doParse):
1743
1744 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
1745
1746         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1747         https://bugs.webkit.org/show_bug.cgi?id=193297
1748         <rdar://problem/47158841>
1749
1750         Reviewed by Alex Christensen.
1751
1752         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
1753             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
1754         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1755         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
1756         activating the message used to trigger the callback when it is set.
1757
1758 2019-01-25  Alex Christensen  <achristensen@webkit.org>
1759
1760         WKWebView.goBack should reload if there is a safe browsing warning
1761         https://bugs.webkit.org/show_bug.cgi?id=193805
1762         <rdar://problem/46908216>
1763
1764         Reviewed by Geoff Garen.
1765
1766         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1767         (+[Simple3LookupContext sharedLookupContext]):
1768         (-[Simple3LookupContext lookUpURL:completionHandler:]):
1769         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
1770         (TEST):
1771
1772 2019-01-25  Chris Dumez  <cdumez@apple.com>
1773
1774         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
1775         https://bugs.webkit.org/show_bug.cgi?id=193788
1776         <rdar://problem/47531231>
1777
1778         Reviewed by Alex Christensen.
1779
1780         Add API test coverage.
1781
1782         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1783         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
1784
1785 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
1786
1787         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
1788         https://bugs.webkit.org/show_bug.cgi?id=193771
1789
1790         Unreviewed infrastructure fix.
1791
1792         * Scripts/webkitpy/port/darwin.py:
1793         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
1794
1795 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
1796
1797         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
1798
1799 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
1800
1801         Add contributors.json entries for Ling Ho and for a new bot watchers group.
1802
1803         * Scripts/webkitpy/common/config/contributors.json:
1804
1805 2019-01-25  Chris Dumez  <cdumez@apple.com>
1806
1807         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
1808         https://bugs.webkit.org/show_bug.cgi?id=193779
1809         <rdar://problem/46170903>
1810
1811         Reviewed by Antti Koivisto.
1812
1813         Add API test that quickly navigates forward to a previous process without waiting for it to
1814         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
1815         the process' previous page when reconnecting the it for the forward navigation.
1816
1817         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1818
1819 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1820
1821         Need a way for JavaScript (or bundle) code to participate in undo
1822         https://bugs.webkit.org/show_bug.cgi?id=190009
1823         <rdar://problem/44807048>
1824
1825         Reviewed by Ryosuke Niwa.
1826
1827         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
1828         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
1829
1830         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1831         (WTR::UIScriptController::lastUndoLabel const):
1832         (WTR::UIScriptController::firstRedoLabel const):
1833         (WTR::UIScriptController::platformUndoManager const):
1834         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1835         (WTR::UIScriptController::lastUndoLabel const):
1836         (WTR::UIScriptController::firstRedoLabel const):
1837         (WTR::UIScriptController::platformUndoManager const):
1838         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1839         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1840         (WTR::UIScriptController::lastUndoLabel const):
1841         (WTR::UIScriptController::firstRedoLabel const):
1842         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1843         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1844         (WTR::UIScriptController::lastUndoLabel const):
1845         (WTR::UIScriptController::firstRedoLabel const):
1846         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1847         (WTR::UIScriptController::platformUndoManager const):
1848         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1849         (WTR::UIScriptController::platformUndoManager const):
1850
1851 2019-01-25  Zalan Bujtas  <zalan@apple.com>
1852
1853         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
1854         https://bugs.webkit.org/show_bug.cgi?id=193824
1855
1856         Reviewed by Antti Koivisto.
1857
1858         * LayoutReloaded/misc/LFC-passing-tests.txt:
1859
1860 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
1861
1862         Update macOS JSC bot configurations
1863         https://bugs.webkit.org/show_bug.cgi?id=193739
1864
1865         Reviewed by Alexey Proskuryakov.
1866
1867         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
1868         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1869         (BubbleQueueServer): Move JSC EWS to Mojave section.
1870         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1871         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
1872         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
1873
1874 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
1875
1876         [Win][WebKitTestRunner] Implement EventSenderProxy
1877         https://bugs.webkit.org/show_bug.cgi?id=193755
1878
1879         Reviewed by Don Olmstead.
1880
1881         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
1882         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
1883         (WTR::EventSenderProxy::dispatchMessage):
1884         (WTR::EventSenderProxy::EventSenderProxy):
1885         (WTR::EventSenderProxy::mouseDown):
1886         (WTR::EventSenderProxy::mouseUp):
1887         (WTR::EventSenderProxy::mouseMoveTo):
1888         (WTR::EventSenderProxy::mouseScrollBy):
1889         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
1890
1891 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
1892
1893         Unreviewed fix for API test failure after r240437.
1894
1895         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
1896
1897         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
1898
1899 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
1900
1901         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
1902         https://bugs.webkit.org/show_bug.cgi?id=193787
1903         <rdar://problem/47497634>
1904
1905         Reviewed by Alexey Proskuryakov.
1906
1907         * Scripts/webkitdirs.pm:
1908         (iosSimulatorApplicationsPath): Pick from available runtime directories.
1909
1910 2019-01-24  Truitt Savell  <tsavell@apple.com>
1911
1912         Unreviewed, rolling out r240446.
1913
1914         Casued 5 API failures
1915
1916         Reverted changeset:
1917
1918         "Activate the WebResourceLoadStatisticsStore in the
1919         NetworkProcess and deactivate it in the UIProcess."
1920         https://bugs.webkit.org/show_bug.cgi?id=193297
1921         https://trac.webkit.org/changeset/240446
1922
1923 2019-01-24  Zalan Bujtas  <zalan@apple.com>
1924
1925         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
1926         https://bugs.webkit.org/show_bug.cgi?id=193741
1927         <rdar://problem/47135030>
1928
1929         Reviewed by Antti Koivisto and Simon Fraser.
1930
1931         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1932         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
1933         (TestWebKitAPI::TEST):
1934
1935 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
1936
1937         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1938         https://bugs.webkit.org/show_bug.cgi?id=193297
1939         <rdar://problem/47158841>
1940
1941         Reviewed by Alex Christensen.
1942
1943         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1944         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
1945         activating the message used to trigger the callback when it is set.
1946
1947 2019-01-24  John Wilander  <wilander@apple.com>
1948
1949         Add Ad Click Attribution as an internal/experimental feature
1950         https://bugs.webkit.org/show_bug.cgi?id=193685
1951         <rdar://problem/47450399>
1952
1953         Reviewed by Brent Fulgham.
1954
1955         Added test option adClickAttributionEnabled.
1956
1957         * DumpRenderTree/TestOptions.cpp:
1958         (TestOptions::TestOptions):
1959         * DumpRenderTree/TestOptions.h:
1960         * DumpRenderTree/mac/DumpRenderTree.mm:
1961         (setWebPreferencesForTestOptions):
1962
1963 2019-01-24  Antti Koivisto  <antti@apple.com>
1964
1965         [PSON] Flash on back navigation on Mac
1966         https://bugs.webkit.org/show_bug.cgi?id=193716
1967         <rdar://problem/47148458>
1968
1969         Reviewed by Chris Dumez.
1970
1971         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1972
1973         Closing of the previous page is delayed so waiting for didFinishNavigation is
1974         not sufficient to guarantee we have received all the messages. Wait for them.
1975
1976 2019-01-24  Chris Dumez  <cdumez@apple.com>
1977
1978         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
1979         https://bugs.webkit.org/show_bug.cgi?id=193761
1980         <rdar://problem/47456405>
1981
1982         Reviewed by Alex Christensen.
1983
1984         Add API test coverage.
1985
1986         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1987
1988 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
1989
1990         webkitpy: Missing PID in crashlog name should not be fatal
1991         https://bugs.webkit.org/show_bug.cgi?id=193771
1992
1993         If we can't determine the PID of a crashlog, just ignore the crashlog instead
1994         of raising an exception.
1995
1996         Reviewed by Lucas Forschler.
1997
1998         * Scripts/webkitpy/port/darwin.py:
1999         (DarwinPort._merge_crash_logs):
2000
2001 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2002
2003         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
2004         https://bugs.webkit.org/show_bug.cgi?id=193746
2005
2006         Reviewed by Youenn Fablet.
2007
2008         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
2009         so we'd best just not call it.
2010
2011         * Scripts/webkitpy/w3c/test_exporter.py:
2012         (WebPlatformTestExporter.create_branch_with_patch):
2013
2014 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
2015
2016         Move FileSystem to WTF
2017         https://bugs.webkit.org/show_bug.cgi?id=193602
2018
2019         Reviewed by Yusuke Suzuki.
2020
2021         * DumpRenderTree/win/DumpRenderTree.cpp:
2022         * TestWebKitAPI/CMakeLists.txt:
2023         * TestWebKitAPI/PlatformGTK.cmake:
2024         * TestWebKitAPI/PlatformJSCOnly.cmake:
2025         * TestWebKitAPI/PlatformPlayStation.cmake:
2026         * TestWebKitAPI/PlatformWPE.cmake:
2027         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2028         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
2029         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
2030         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
2031         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
2032         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
2033         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
2034         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2035         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
2036         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2037
2038 2019-01-24  Philippe Normand  <pnormand@igalia.com>
2039
2040         [WPE] Remove hard dependency on subprocess32 for the API tests
2041
2042         Rubber-stamped by Carlos Garcia Campos.
2043
2044         * glib/api_test_runner.py:
2045         (TestRunner._run_test_qt): Lazily import subprocess32 and check
2046         its presence only when running WPEQt tests.
2047
2048 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2049
2050         [GLIB] Expose JavaScriptCore options in GLib public API
2051         https://bugs.webkit.org/show_bug.cgi?id=188742
2052
2053         Reviewed by Michael Catanzaro.
2054
2055         Add a test for the new API.
2056
2057         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2058         (testsJSCOptions):
2059         (main):
2060
2061 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2062
2063         [GTK][WPE] Support JPEG 2000 images
2064         https://bugs.webkit.org/show_bug.cgi?id=186272
2065
2066         Reviewed by Žan Doberšek.
2067
2068         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
2069
2070         * gtk/jhbuild.modules:
2071         * wpe/jhbuild.modules:
2072
2073 2019-01-23  David Kilzer  <ddkilzer@apple.com>
2074
2075         check-webkit-style should warn when using soft-linking macros in a header
2076         <https://webkit.org/b/193750>
2077
2078         Reviewed by Darin Adler.
2079
2080         * Scripts/webkitpy/style/checkers/cpp.py:
2081         (check_language): Add softlink/header check by refactoring the
2082         softlink/framework check.
2083         (CppChecker): Enable softlink/header check by default.
2084         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2085         (CppStyleTest.test_softlink_framework): Rename from
2086         CppStyleTest.test_softlink() and change test framework name in
2087         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
2088         files. Set file_name for macros that only appear in headers.
2089         (CppStyleTest.test_softlink_header): Add tests for using
2090         soft-link macros in headers.
2091
2092 2019-01-23  Chris Dumez  <cdumez@apple.com>
2093
2094         Deprecate API to limit the maximum number of WebProcesses
2095         https://bugs.webkit.org/show_bug.cgi?id=193725
2096         <rdar://problem/47464879>
2097
2098         Reviewed by Geoff Garen.
2099
2100         Update existing API tests to stop using deprecated API.
2101
2102         * MiniBrowser/mac/AppDelegate.m:
2103         (defaultConfiguration):
2104         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2105         (TestWebKitAPI::TEST):
2106         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
2107         (TestWebKitAPI::TEST):
2108         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2109         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
2110         (TEST):
2111         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2112         (TEST):
2113
2114 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2115
2116         [ews-app] Rename ews model buildermappings to buildermapping
2117         https://bugs.webkit.org/show_bug.cgi?id=193729
2118
2119         Reviewed by Lucas Forschler.
2120
2121         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
2122         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
2123         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
2124
2125 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2126
2127         [ews-app] Rename ews model steps to step
2128         https://bugs.webkit.org/show_bug.cgi?id=193697
2129
2130         Reviewed by Lucas Forschler.
2131
2132         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
2133         (Step): Renamed Steps to Step.
2134
2135 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
2136
2137         Clean up IndexedDB files between tests
2138         https://bugs.webkit.org/show_bug.cgi?id=192796
2139         <rdar://problem/46824999>
2140
2141         Reviewed by Geoffrey Garen.
2142
2143         * DumpRenderTree/mac/DumpRenderTree.mm:
2144         (runTest):
2145         * WebKitTestRunner/TestController.cpp:
2146         (WTR::TestController::resetStateToConsistentValues):
2147         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
2148         (WTR::RemoveAllIndexedDatabasesCallback):
2149         (WTR::TestController::ClearIndexedDatabases):
2150         * WebKitTestRunner/TestController.h:
2151         * WebKitTestRunner/TestInvocation.cpp:
2152         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2153
2154 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2155
2156         [ews-app] Rename ews model Builds to Build
2157         https://bugs.webkit.org/show_bug.cgi?id=193695
2158
2159         Reviewed by Lucas Forschler.
2160
2161         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
2162         (Build): Renamed Builds to Build.
2163
2164 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
2165
2166         webkitpy: Wait longer when launching WebKitTestRunner
2167         https://bugs.webkit.org/show_bug.cgi?id=193734
2168
2169         Reviewed by Aakash Jain.
2170
2171         * Scripts/webkitpy/port/simulator_process.py:
2172         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
2173
2174 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
2175
2176         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
2177         https://bugs.webkit.org/show_bug.cgi?id=193182
2178         <rdar://problem/47452154>
2179
2180         Reviewed by Tim Horton.
2181
2182         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
2183         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
2184         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
2185
2186         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
2187         preventing later tests from recognizing gestures.
2188
2189         * WebKitTestRunner/ios/TestControllerIOS.mm:
2190         (WTR::TestController::platformResetStateToConsistentValues):
2191
2192         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
2193
2194 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
2195
2196         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
2197         https://bugs.webkit.org/show_bug.cgi?id=193722
2198         <rdar://problem/47481475>
2199
2200         Reviewed by Lucas Forschler.
2201
2202         iPhone and iPad ports should both use the iOS config.
2203
2204         * Scripts/webkitpy/port/ios_simulator.py:
2205         (IPhoneSimulatorPort.__init__):
2206         (IPadSimulatorPort.__init__):
2207
2208 2019-01-23  Rob Buis  <rbuis@igalia.com>
2209
2210         Update MIME type parser
2211         https://bugs.webkit.org/show_bug.cgi?id=180526
2212
2213         Reviewed by Frédéric Wang.
2214
2215         Add unit tests for both parse modes of ParsedContentType.
2216
2217         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2218         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
2219         (TestWebKitAPI::TEST):
2220
2221 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
2222
2223         [ews-app] fetch loop should not stop on network issues
2224         https://bugs.webkit.org/show_bug.cgi?id=193666
2225
2226         Reviewed by Lucas Forschler.
2227
2228         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2229         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
2230
2231 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2232
2233         [iOS] Multiple WKWebViewAutofillTests are flaky failures
2234         https://bugs.webkit.org/show_bug.cgi?id=189165
2235         <rdar://problem/47433765>
2236
2237         Reviewed by Tim Horton.
2238
2239         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
2240         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
2241         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
2242         process in sufficient to ensure that any previous action that blurred the focused element in the web process
2243         would make its way to the UI process by the time the layer tree commit is finished.
2244
2245         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
2246         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
2247         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
2248         will fail because it asks for -_autofillContext too early.
2249
2250         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
2251         is handled in the UI process.
2252
2253         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2254
2255         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
2256         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
2257         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
2258         input session.
2259
2260         (-[AutofillTestView textInputHasAutofillContext]):
2261
2262         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
2263
2264         * TestWebKitAPI/cocoa/TestWKWebView.h:
2265         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2266         (nextInputSessionChangeCount):
2267
2268         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
2269         This includes changing the focused element from one to another.
2270
2271         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
2272         (-[TestWKWebView didStartFormControlInteraction]):
2273         (-[TestWKWebView didEndFormControlInteraction]):
2274         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
2275
2276         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
2277         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
2278         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
2279         that doesn't require an input session to one that doesn't.
2280
2281 2019-01-22  David Kilzer  <ddkilzer@apple.com>
2282
2283         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
2284         <https://webkit.org/b/193676>
2285
2286         Reviewed by Alexey Proskuryakov.
2287
2288         * Scripts/webkitpy/style/checkers/cpp.py:
2289         (check_member_initialization_list):
2290         - Don't report missing whitespace around colon if the colon at
2291           the start of the line is formatted correctly.
2292         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2293         (WebKitStyleTest.test_member_initialization_list):
2294         - Add a test for a missing permutation of existing tests.
2295         - Add a test this false-positive.
2296         - Add blank lines between subtests to make them easier to read.
2297
2298 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
2299
2300         [build.webkit.org] Unit-test failure after r237113
2301         https://bugs.webkit.org/show_bug.cgi?id=193669
2302
2303         Reviewed by Michael Catanzaro.
2304
2305         * BuildSlaveSupport/build.webkit.org-config/factories.py:
2306         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
2307         multiple or zero flags.
2308
2309 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
2310
2311         Cache bytecode to disk
2312         https://bugs.webkit.org/show_bug.cgi?id=192782
2313         <rdar://problem/46084932>
2314
2315         Reviewed by Keith Miller.
2316
2317         Add test helper to execute bytecode-cache tests: it executes each test
2318         twice, the first with JSC_diskCachePath set to a temporary directory
2319         and second with JSC_forceDiskCache=true (in addition to the cache path)
2320         to guarantee that only the disk cache is being used and no new
2321         UnlinkedCodeBlocks are being created.
2322
2323         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
2324         * Scripts/run-jsc-stress-tests:
2325
2326 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
2327
2328         [css-logical] Implement flow-relative margin, padding and border shorthands
2329         https://bugs.webkit.org/show_bug.cgi?id=188697
2330
2331         Reviewed by Simon Fraser and Antti Koivisto.
2332
2333         * DumpRenderTree/TestOptions.cpp:
2334         (TestOptions::TestOptions):
2335         * DumpRenderTree/TestOptions.h:
2336         * DumpRenderTree/mac/DumpRenderTree.mm:
2337         (setWebPreferencesForTestOptions):
2338         Allow tests to enable the CSSLogicalEnabled flag in WK1.
2339
2340         * Scripts/webkitpy/style/checkers/jsonchecker.py:
2341         (JSONCSSPropertiesChecker.check_codegen_properties):
2342         Allow CSS property definitions to have a 'runtime-flag' parameter which
2343         disables the property when the specified runtime flag is disabled.
2344
2345 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
2346
2347         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
2348         https://bugs.webkit.org/show_bug.cgi?id=193643
2349
2350         Reviewed by Michael Catanzaro.
2351
2352         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
2353         * wpe/jhbuild.modules: Ditto.
2354
2355 2019-01-21  Zalan Bujtas  <zalan@apple.com>
2356
2357         [LFC][Floats] Take float top position into account when computing containing block height.
2358         https://bugs.webkit.org/show_bug.cgi?id=193655
2359
2360         Reviewed by Antti Koivisto.
2361
2362         * LayoutReloaded/misc/LFC-passing-tests.txt:
2363
2364 2019-01-21  David Kilzer  <ddkilzer@apple.com>
2365
2366         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
2367         <https://webkit.org/b/193645>
2368         <rdar://problem/47421574>
2369
2370         Reviewed by Alex Christensen.
2371
2372         - Now checks for local soft-linking of all frameworks that have
2373           their own *SoftLinking.{cpp,h,mm} files.
2374         - Changes softlink/uikit warning to softlink/framework.
2375
2376         * Scripts/webkitpy/style/checkers/cpp.py:
2377         (check_language):
2378         (CppChecker):
2379         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2380         (CppStyleTest):
2381
2382 2019-01-20  Saam Barati  <sbarati@apple.com>
2383
2384         Rollout r240210: It broke tests on iOS
2385         https://bugs.webkit.org/show_bug.cgi?id=193640
2386
2387         Unreviewed.
2388
2389         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
2390         * Scripts/run-jsc-stress-tests:
2391
2392 2019-01-20  chris fleizach  <cfleizach@apple.com>
2393
2394         AX: Support returning relative frames for accessibility
2395         https://bugs.webkit.org/show_bug.cgi?id=193414
2396         <rdar://problem/47268501>
2397
2398         Reviewed by Zalan Bujtas.
2399
2400         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2401         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2402         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2403         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2404         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2405         (WTR::attributesOfElement):
2406         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2407
2408 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
2409
2410         Unreviewed, add my new email address
2411
2412         * Scripts/webkitpy/common/config/contributors.json:
2413
2414 2019-01-19  Zalan Bujtas  <zalan@apple.com>
2415
2416         [LFC][BFC] <body>'s overflow property value is propagated to viewport
2417         https://bugs.webkit.org/show_bug.cgi?id=193617
2418
2419         Reviewed by Antti Koivisto.
2420
2421         * LayoutReloaded/misc/LFC-passing-tests.txt:
2422
2423 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
2424
2425         Unreviewed, rolling out r240209.
2426
2427         Broke GTK/WPE injected bundle
2428
2429         Reverted changeset:
2430
2431         "AX: Support returning relative frames for accessibility"
2432         https://bugs.webkit.org/show_bug.cgi?id=193414
2433         https://trac.webkit.org/changeset/240209
2434
2435 2019-01-12  Dan Bernstein  <mitz@apple.com>
2436
2437         [Cocoa] Avoid importing directly from subumbrella frameworks
2438         https://bugs.webkit.org/show_bug.cgi?id=186016
2439         <rdar://problem/40591038>
2440
2441         Reviewed by Sam Weinig.
2442
2443         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
2444           LaunchServices header.
2445         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2446           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2447         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
2448           when using SDKs earlier than 10.13.
2449         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
2450           and OTHER_CPLUSPLUSFLAGS.
2451         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2452           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2453         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
2454           LaunchServices header.
2455
2456 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
2457
2458         Cache bytecode to disk
2459         https://bugs.webkit.org/show_bug.cgi?id=192782
2460         <rdar://problem/46084932>
2461
2462         Reviewed by Keith Miller.
2463
2464         Add test helper to execute bytecode-cache tests: it executes each test
2465         twice, the first with JSC_diskCachePath set to a temporary directory
2466         and second with JSC_forceDiskCache=true (in addition to the cache path)
2467         to guarantee that only the disk cache is being used and no new
2468         UnlinkedCodeBlocks are being created.
2469
2470         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
2471         * Scripts/run-jsc-stress-tests:
2472
2473 2019-01-20  chris fleizach  <cfleizach@apple.com>
2474
2475         AX: Support returning relative frames for accessibility
2476         https://bugs.webkit.org/show_bug.cgi?id=193414
2477         <rdar://problem/47268501>
2478
2479         Reviewed by Zalan Bujtas.
2480
2481         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2482         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2483         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2484         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2485         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2486         (WTR::attributesOfElement):
2487         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2488
2489 2019-01-20  Antoine Quint  <graouts@apple.com>
2490
2491         Add a POINTER_EVENTS feature flag
2492         https://bugs.webkit.org/show_bug.cgi?id=193577
2493         <rdar://problem/47408511>
2494
2495         Unreviewed. Also enable Pointer Events for iosmac.
2496
2497         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2498
2499 2019-01-19  Zalan Bujtas  <zalan@apple.com>
2500
2501         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
2502         https://bugs.webkit.org/show_bug.cgi?id=193613
2503
2504         Reviewed by Antti Koivisto.
2505
2506         * LayoutReloaded/misc/LFC-passing-tests.txt:
2507
2508 2019-01-19  Antoine Quint  <graouts@apple.com>
2509
2510         Add a POINTER_EVENTS feature flag
2511         https://bugs.webkit.org/show_bug.cgi?id=193577
2512
2513         Reviewed by Dean Jackson.
2514
2515         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2516
2517 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
2518
2519         Disable the run-jsc-stress-test remote host key check [second round].
2520         https://bugs.webkit.org/show_bug.cgi?id=192988
2521
2522         Reviewed by Dewei Zhu.
2523
2524         * Scripts/run-jsc-stress-tests:
2525
2526 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2527
2528         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
2529         https://bugs.webkit.org/show_bug.cgi?id=193597
2530
2531         Reviewed by Lucas Forschler.
2532
2533         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2534
2535 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2536
2537         [build.webkit.org] api tests failures are incorrectly named as unit test failures
2538         https://bugs.webkit.org/show_bug.cgi?id=193595
2539
2540         Reviewed by Lucas Forschler.
2541
2542         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
2543         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
2544         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
2545
2546 2019-01-18  Chris Dumez  <cdumez@apple.com>
2547
2548         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
2549         https://bugs.webkit.org/show_bug.cgi?id=193588
2550         <rdar://problem/47131566>
2551
2552         Reviewed by Alex Christensen.
2553
2554         Add layout test coverage.
2555
2556         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2557
2558 2019-01-18  Jer Noble  <jer.noble@apple.com>
2559
2560         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
2561         https://bugs.webkit.org/show_bug.cgi?id=189553
2562
2563         Reviewed by Tim Horton.
2564
2565         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
2566
2567         * ContentExtensionTester/Configurations/Base.xcconfig:
2568         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
2569         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2570         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
2571         * ImageDiff/cg/Configurations/Base.xcconfig:
2572         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
2573         * MiniBrowser/Configurations/Base.xcconfig:
2574         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2575         * MobileMiniBrowser/Configurations/Base.xcconfig:
2576         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2577         * Scripts/webkitpy/style/checker.py:
2578         (_all_categories):
2579         (FileType):
2580         (CheckerDispatcher._file_type):
2581         (CheckerDispatcher._create_checker):
2582         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
2583         (SDKVariantChecker):
2584         (SDKVariantChecker.__init__):
2585         (SDKVariantChecker.check):
2586         * TestWebKitAPI/Configurations/Base.xcconfig:
2587         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
2588         * WebEditingTester/Configurations/Base.xcconfig:
2589         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
2590         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
2591         * WebKitTestRunner/Configurations/Base.xcconfig:
2592         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
2593         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
2594         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
2595
2596 2019-01-18  David Kilzer  <ddkilzer@apple.com>
2597
2598         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
2599         <https://webkit.org/b/193568>
2600         <rdar://problem/47381130>
2601
2602         Reviewed by Alex Christensen.
2603
2604         Make sure no one re-introduces UIKit soft-linking by adding a
2605         style rule.
2606
2607         * Scripts/webkitpy/style/checkers/cpp.py:
2608         (check_language): Add softlink/uikit check.
2609         (CppChecker): Enable softlink/uikit check.
2610         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2611         (CppStyleTest): Add test for softlink/uikit.
2612
2613 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
2614
2615         [GTK] install-dependencies tool looks for libunistring-dev for dnf
2616         https://bugs.webkit.org/show_bug.cgi?id=193584
2617
2618         Change "-dev" to "-devel".
2619
2620         Reviewed by Michael Catanzaro.
2621
2622         * gtk/install-dependencies:
2623
2624 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2625
2626         webkitpy: Add iPhone and iPad ports
2627         https://bugs.webkit.org/show_bug.cgi?id=193537
2628         <rdar://problem/47353390>
2629
2630         Reviewed by Lucas Forschler.
2631
2632         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
2633         ports. Note that this separation is optional, the --ios-simulator command remains.
2634
2635         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2636         (RunTest.test_device_type_test_division): Drive-by fix.
2637         (RunTest.test_device_type_specific_listing): Ditto.
2638         (RunTest.test_ipad_test_division):
2639         (RunTest):
2640         (RunTest.test_ipad_listing):
2641         * Scripts/webkitpy/port/factory.py:
2642         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
2643         (PortFactory):
2644         * Scripts/webkitpy/port/ios_simulator.py:
2645         (IPhoneSimulatorPort):
2646         (IPadSimulatorPort):
2647
2648 2019-01-18  Chris Dumez  <cdumez@apple.com>
2649
2650         Regression(PSON) Scroll position is not always restored properly when navigating back
2651         https://bugs.webkit.org/show_bug.cgi?id=193578
2652         <rdar://problem/47386331>
2653
2654         Reviewed by Tim Horton.
2655
2656         Add API test coverage.
2657
2658         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2659
2660 2019-01-18  Youenn Fablet  <youenn@apple.com>
2661
2662         Add a new SPI to request for cache storage quota increase
2663         https://bugs.webkit.org/show_bug.cgi?id=193323
2664
2665         Reviewed by Alex Christensen.
2666
2667         Implement WebsiteDataStore quota delegate to handle quota requests.
2668         By default, do not update quota.
2669         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
2670
2671         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2672         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2673         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
2674         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2675         * WebKitTestRunner/TestController.cpp:
2676         (WTR::TestController::allowCacheStorageQuotaIncrease):
2677         * WebKitTestRunner/TestController.h:
2678         * WebKitTestRunner/TestInvocation.cpp:
2679         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2680         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2681         (-[CacheStorageQuotaManager init]):
2682         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2683         (WTR::initializeWebViewConfiguration):
2684         (WTR::TestController::cocoaResetStateToConsistentValues):
2685         (WTR::TestController::allowCacheStorageQuotaIncrease):
2686
2687 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2688
2689         [ews-build] Pass owner to the triggered builds
2690         https://bugs.webkit.org/show_bug.cgi?id=193574
2691
2692         Reviewed by Lucas Forschler.
2693
2694         * BuildSlaveSupport/ews-build/factories.py:
2695         (BuildFactory.propertiesToPassToTriggers):
2696
2697 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2698
2699         [ews-app] Send patch author as a build property
2700         https://bugs.webkit.org/show_bug.cgi?id=193560
2701
2702         Reviewed by Lucas Forschler.
2703
2704         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2705         (BugzillaPatchFetcher.fetch):
2706
2707 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2708
2709         webkitpy: Implement device type specific expected results (Follow-up fix)
2710         https://bugs.webkit.org/show_bug.cgi?id=192162
2711         <rdar://problem/46345449>
2712
2713         Unreviewed infrastructure fix.
2714
2715         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2716         (Manager.run): Don't boot a device if no tests are available to run on it.
2717
2718 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2719
2720         webkitpy: Implement device type specific expected results (Follow-up fix)
2721         https://bugs.webkit.org/show_bug.cgi?id=192162
2722         <rdar://problem/46345449>
2723
2724         Unreviewed infrastructure fix.
2725
2726         * Scripts/webkitpy/api_tests/manager.py:
2727         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
2728
2729 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2730
2731         webkitpy: Implement device type specific expected results (Part 2)
2732         https://bugs.webkit.org/show_bug.cgi?id=192162
2733         <rdar://problem/46345449>
2734
2735         Rubber-stamped by Aakash Jain.
2736
2737         This change uses device_type to select a different set of TestExpectation files based on the type of device running
2738         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
2739         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
2740
2741         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
2742         (LayoutTestFinder.find_tests): Pass device_type through.
2743         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
2744         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
2745         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2746         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
2747         (Manager._collect_tests): Pass device type to test finder.
2748         (Manager._needs_web_platform_test):
2749         (Manager._prepare_lists): Index _expectations by device type.
2750         (Manager._test_input_for_file):
2751         (Manager._test_is_slow): Ditto.
2752         (Manager._test_should_dump_jsconsolelog_in_stderr):
2753         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
2754         (Manager._get_test_inputs):
2755         (Manager._update_worker_count):
2756         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
2757         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
2758         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
2759         the one which runs the test.
2760         (Manager._run_test_subset):
2761         (Manager._run_tests): Index _expectations by current_device_type.
2762         (Manager._print_expectation_line_for_test): Ditto.
2763         (Manager._print_expectations_for_subset): Ditto.
2764         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
2765         Unlike run, this function will behave the same regardless of what devices are available.
2766         (Manager._custom_device_for_test): Deleted.
2767         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2768         (ManagerTest.test_uses_custom_device): Deleted.
2769         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
2770         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2771         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
2772         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
2773         all of the expectations.
2774         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
2775         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
2776         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2777         (TestExpectations.__init__): Allow device_type to be passed through.
2778         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
2779         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
2780         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2781         (summarize_results):
2782         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
2783         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
2784         a test ran with, one must check all expectations to find the first non-skip expectation.
2785         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2786         (RunTest.test_device_type_test_division):
2787         (RunTest):
2788         (RunTest.test_device_type_specific_listing):
2789         * Scripts/webkitpy/port/base.py:
2790         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
2791         (Port.supported_device_types): The result of this function will change based on what devices are available.
2792         * Scripts/webkitpy/port/device_port.py:
2793         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
2794         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
2795         can be used.
2796         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
2797         any, or the DEFAULT_DEVICE_TYPES of the port.
2798         * Scripts/webkitpy/port/ios.py:
2799         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
2800         * Scripts/webkitpy/port/ios_simulator.py:
2801         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
2802         * Scripts/webkitpy/port/watch.py:
2803         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
2804         * Scripts/webkitpy/port/watch_simulator.py:
2805         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
2806         * Scripts/webkitpy/xcode/device_type.py:
2807         (DeviceType):
2808         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
2809
2810 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2811
2812         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
2813         https://bugs.webkit.org/show_bug.cgi?id=193575
2814
2815         Reviewed by Michael Catanzaro.
2816
2817         Allow the script to run without explicit port argument because
2818         it's specific to the WPE port anyway.
2819
2820         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
2821         and simplify the rest of the code accordingly.
2822
2823 2019-01-18  Charlie Turner  <cturner@igalia.com>
2824
2825         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
2826         https://bugs.webkit.org/show_bug.cgi?id=192229
2827
2828         Reviewed by Xabier Rodriguez-Calvar.
2829
2830         * MiniBrowser/wpe/main.cpp:
2831         (main): Enable encrypted-media by default.
2832
2833 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2834
2835         [Flatpak] Missing KeyboardInterrupt exception handler
2836         https://bugs.webkit.org/show_bug.cgi?id=193570
2837
2838         Reviewed by Michael Catanzaro.
2839
2840         * flatpak/flatpakutils.py:
2841         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
2842
2843 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2844
2845         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
2846         https://bugs.webkit.org/show_bug.cgi?id=193564
2847
2848         Reviewed by Antti Koivisto.
2849
2850         * LayoutReloaded/misc/LFC-passing-tests.txt:
2851
2852 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2853
2854         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
2855         https://bugs.webkit.org/show_bug.cgi?id=193562
2856
2857         Reviewed by Antti Koivisto.
2858
2859         * LayoutReloaded/misc/LFC-passing-tests.txt:
2860
2861 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2862
2863         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
2864         https://bugs.webkit.org/show_bug.cgi?id=193555
2865
2866         Reviewed by Antti Koivisto.
2867
2868         * LayoutReloaded/misc/LFC-passing-tests.txt:
2869
2870 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2871
2872         [WPE] Add Qt extension
2873         https://bugs.webkit.org/show_bug.cgi?id=191464
2874
2875         Reviewed by Carlos Garcia Campos.
2876
2877         MiniBrowser and API tests for the WPE Qt API. To run the
2878         MiniBrowser a new script is introduced. Example invocation:
2879
2880         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
2881
2882         Also note-worthy is the introduction of the python2-subprocess32
2883         dependency to run the GLib API tests.
2884
2885         * MiniBrowser/wpe/CMakeLists.txt:
2886         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
2887         * MiniBrowser/wpe/qt/main.cpp: Added.
2888         (main):
2889         * MiniBrowser/wpe/qt/main.qml: Added.
2890         * MiniBrowser/wpe/qt/qml.qrc: Added.
2891         * Scripts/run-gtk-tests:
2892         (GtkTestRunner.is_google_test):
2893         (GtkTestRunner):
2894         (GtkTestRunner.is_qt_test):
2895         * Scripts/run-qt-wpe-minibrowser: Added.
2896         * Scripts/run-wpe-tests:
2897         (WPETestRunner):
2898         (WPETestRunner.is_google_test):
2899         (WPETestRunner.is_qt_test):
2900         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
2901         (TestLoad::main):
2902         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
2903         (TestLoadHtml::main):
2904         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
2905         (TestLoadRequest::main):
2906         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
2907         (TestRunJavaScript::main):
2908         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
2909         (waitForSignal):
2910         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
2911         (LoadSpy::LoadSpy):
2912         (LoadSpy::~LoadSpy):
2913         (LoadSpy::onLoadingChanged):
2914         (LoadStartedCatcher::LoadStartedCatcher):
2915         (LoadStartedCatcher::~LoadStartedCatcher):
2916         (LoadStartedCatcher::onLoadingChanged):
2917         (waitForLoadSucceeded):
2918         (waitForLoadFailed):
2919         * TestWebKitAPI/glib/CMakeLists.txt:
2920         * flatpak/flatpakutils.py:
2921         (WebkitFlatpak.load_from_args):
2922         (WebkitFlatpak.__init__):
2923         (WebkitFlatpak.clean_args):
2924         (WebkitFlatpak.run_in_sandbox):
2925         * flatpak/org.webkit.CommonModules.yaml:
2926         * flatpak/org.webkit.WPE.yaml:
2927         * flatpak/org.webkit.WPEModules.yaml:
2928         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
2929         * flatpak/org.webkit.WebKit.yaml:
2930         * glib/api_test_runner.py:
2931         (TestRunner._run_test_qt):
2932         (TestRunner.is_qt_test):
2933         (TestRunner._run_test):
2934
2935 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2936
2937         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
2938         https://bugs.webkit.org/show_bug.cgi?id=193494
2939         <rdar://problem/46859627>
2940
2941         Reviewed by Simon Fraser and Tim Horton.
2942
2943         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
2944         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
2945
2946         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2947         (WTR::UIScriptController::contentOffsetX const):
2948         (WTR::UIScriptController::contentOffsetY const):
2949         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2950         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2951         (WTR::UIScriptController::contentOffsetX const):
2952         (WTR::UIScriptController::contentOffsetY const):
2953         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2954
2955         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
2956
2957         * WebKitTestRunner/TestController.cpp:
2958         (WTR::updateTestOptionsFromTestHeader):
2959         * WebKitTestRunner/TestOptions.h:
2960         (WTR::TestOptions::hasSameInitializationOptions const):
2961         * WebKitTestRunner/ios/TestControllerIOS.mm:
2962         (WTR::TestController::platformResetStateToConsistentValues):
2963         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2964         (WTR::UIScriptController::contentOffsetX const):
2965         (WTR::UIScriptController::contentOffsetY const):
2966
2967 2019-01-17  Truitt Savell  <tsavell@apple.com>
2968
2969         Unreviewed, rolling out r240124.
2970
2971         This commit broke an internal build.
2972
2973         Reverted changeset:
2974
2975         "SDK_VARIANT build destinations should be separate from non-
2976         SDK_VARIANT builds"
2977         https://bugs.webkit.org/show_bug.cgi?id=189553
2978         https://trac.webkit.org/changeset/240124
2979
2980 2019-01-17  Alex Christensen  <achristensen@webkit.org>
2981
2982         Fix string concatenation API test after r239920
2983         https://bugs.webkit.org/show_bug.cgi?id=193551
2984         <rdar://problem/47359304>
2985
2986         Reviewed by Youenn Fablet.
2987
2988         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
2989         (TestWebKitAPI::TEST):
2990         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
2991         in WebKit's build configuration like it apparently is on Linux.
2992
2993 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2994
2995         [ews-build] validate-patch should handle the case when bug_id is None
2996         https://bugs.webkit.org/show_bug.cgi?id=193547
2997
2998         Reviewed by Lucas Forschler.
2999
3000         * BuildSlaveSupport/ews-build/steps.py:
3001         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
3002         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
3003
3004 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3005
3006         [ews-build] Add patch author information in build
3007         https://bugs.webkit.org/show_bug.cgi?id=193465
3008
3009         Reviewed by Lucas Forschler.
3010
3011         * BuildSlaveSupport/ews-build/steps.py:
3012         (ValidatePatch._is_patch_obsolete):
3013
3014 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3015
3016         [ews-build] Pass bug_id to the triggered builds
3017         https://bugs.webkit.org/show_bug.cgi?id=193548
3018
3019         Reviewed by Lucas Forschler.
3020
3021         * BuildSlaveSupport/ews-build/factories.py:
3022         (BuildFactory.propertiesToPassToTriggers):
3023
3024 2019-01-17  Jer Noble  <jer.noble@apple.com>
3025
3026         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
3027         https://bugs.webkit.org/show_bug.cgi?id=189553
3028
3029         Reviewed by Tim Horton.
3030
3031         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
3032
3033         * ContentExtensionTester/Configurations/Base.xcconfig:
3034         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
3035         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3036         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
3037         * ImageDiff/cg/Configurations/Base.xcconfig:
3038         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
3039         * MiniBrowser/Configurations/Base.xcconfig:
3040         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3041         * MobileMiniBrowser/Configurations/Base.xcconfig:
3042         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3043         * Scripts/webkitpy/style/checker.py:
3044         (_all_categories):
3045         (FileType):
3046         (CheckerDispatcher._file_type):
3047         (CheckerDispatcher._create_checker):
3048         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
3049         (SDKVariantChecker):
3050         (SDKVariantChecker.__init__):
3051         (SDKVariantChecker.check):
3052         * TestWebKitAPI/Configurations/Base.xcconfig:
3053         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
3054         * WebEditingTester/Configurations/Base.xcconfig:
3055         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
3056         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
3057         * WebKitTestRunner/Configurations/Base.xcconfig:
3058         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
3059         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
3060         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
3061
3062 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3063
3064         [LFC][BFC] An element with transform is a containing block for positioned descendants.
3065         https://bugs.webkit.org/show_bug.cgi?id=193534
3066
3067         Reviewed by Antti Koivisto.
3068
3069         * LayoutReloaded/misc/LFC-passing-tests.txt:
3070
3071 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3072
3073         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
3074         https://bugs.webkit.org/show_bug.cgi?id=193528
3075
3076         Reviewed by Antti Koivisto.
3077
3078         * LayoutReloaded/misc/LFC-passing-tests.txt:
3079
3080 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3081
3082         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
3083         https://bugs.webkit.org/show_bug.cgi?id=193520
3084
3085         Reviewed by Antti Koivisto.
3086
3087         * LayoutReloaded/misc/LFC-passing-tests.txt:
3088
3089 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3090
3091         [ews-build] unapply-patch step should not update source
3092         https://bugs.webkit.org/show_bug.cgi?id=193234
3093
3094         Reviewed by Lucas Forschler.
3095
3096         * BuildSlaveSupport/ews-build/steps.py:
3097         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
3098         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
3099
3100 2019-01-16  Youenn Fablet  <youenn@apple.com>
3101
3102         Add a new SPI for controlling getUserMedia
3103         https://bugs.webkit.org/show_bug.cgi?id=192793
3104
3105         Reviewed by Eric Carlson.
3106
3107         * MiniBrowser/mac/WK2BrowserWindowController.m:
3108         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
3109         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3110         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
3111         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3112         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
3113         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3114         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
3115         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3116         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
3117         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3118         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3119         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
3120         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3121         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3122
3123 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3124
3125         [LFC][BFC] Inflow non-replaced used width should not be negative.
3126         https://bugs.webkit.org/show_bug.cgi?id=193495
3127
3128         Reviewed by Antti Koivisto.
3129
3130         * LayoutReloaded/misc/LFC-passing-tests.txt:
3131
3132 2019-01-16  Chris Dumez  <cdumez@apple.com>
3133
3134         Regression(PSON) View becomes blank after click a cross-site download link
3135         https://bugs.webkit.org/show_bug.cgi?id=193361
3136         <rdar://problem/47099573>
3137
3138         Reviewed by Geoffrey Garen.
3139
3140         Add API test coverage.
3141
3142         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3143         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3144
3145 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3146
3147         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
3148         https://bugs.webkit.org/show_bug.cgi?id=193470
3149
3150         Reviewed by Antti Koivisto.
3151
3152         * LayoutReloaded/misc/LFC-passing-tests.txt:
3153
3154 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3155
3156         [LFC] Adjust margin box verification.
3157         https://bugs.webkit.org/show_bug.cgi?id=193482
3158
3159         Reviewed by Antti Koivisto.
3160
3161         * LayoutReloaded/misc/LFC-passing-tests.txt:
3162
3163 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
3164
3165         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
3166         https://bugs.webkit.org/show_bug.cgi?id=193451
3167
3168         Reviewed by Geoffrey Garen.
3169
3170         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
3171         (TEST):
3172         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3173         (runWebsiteDataStoreCustomPaths):
3174
3175 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
3176
3177         webkitpy: Support boolean simctl isAvailable
3178         https://bugs.webkit.org/show_bug.cgi?id=193472
3179         <rdar://problem/47296150>
3180
3181         Reviewed by Ryosuke Niwa.
3182
3183         * Scripts/webkitpy/xcode/simulated_device.py:
3184         (SimulatedDeviceManager._create_runtimes):
3185         (SimulatedDeviceManager._create_device_with_runtime):
3186
3187 2019-01-15  Chris Dumez  <cdumez@apple.com>
3188
3189         Unreviewed, rolling out r239993, r239995, r239997, and
3190         r239999.
3191
3192         Caused assertions under
3193         ViewGestureController::disconnectFromProcess()
3194
3195         Reverted changesets:
3196
3197         "Regression(PSON) View becomes blank after click a cross-site
3198         download link"
3199         https://bugs.webkit.org/show_bug.cgi?id=193361
3200         https://trac.webkit.org/changeset/239993
3201
3202         "Unreviewed iOS build fix after r239993."
3203         https://trac.webkit.org/changeset/239995
3204
3205         "Fix iOS build after r239993"
3206         https://bugs.webkit.org/show_bug.cgi?id=193361
3207         https://trac.webkit.org/changeset/239997
3208
3209         "Unreviewed, revert part of r239997 as it is not needed to fix
3210         the build."
3211         https://trac.webkit.org/changeset/239999
3212
3213 2019-01-15  Tim Horton  <timothy_horton@apple.com>
3214
3215         Cannot tab out of WKWebView on macOS
3216         https://bugs.webkit.org/show_bug.cgi?id=161448
3217         <rdar://problem/28100085>
3218
3219         Reviewed by Dean Jackson.
3220
3221         Add a test that tabbing into and out of WKWebView works correctly.
3222
3223         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3224         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
3225         (WebKit2_CommandBackForwardTest::SetUp):
3226         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
3227         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
3228         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
3229         (-[FocusableView canBecomeKeyView]):
3230         (TEST):
3231         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
3232         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
3233         (-[OffscreenWindow initWithSize:]):
3234         (-[OffscreenWindow isKeyWindow]):
3235         (-[OffscreenWindow isVisible]):
3236         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3237         (TestWebKitAPI::PlatformWebView::initialize):
3238         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
3239         (-[ActiveOffscreenWindow isVisible]): Deleted.
3240         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
3241
3242 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
3243
3244         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
3245         https://bugs.webkit.org/show_bug.cgi?id=193459
3246
3247         Reviewed by Mark Lam.
3248
3249         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3250         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
3251
3252 2019-01-15  Chris Dumez  <cdumez@apple.com>
3253
3254         Regression(PSON) View becomes blank after click a cross-site download link
3255         https://bugs.webkit.org/show_bug.cgi?id=193361
3256         <rdar://problem/47099573>
3257
3258         Reviewed by Geoff Garen.
3259
3260         Add API test coverage.
3261
3262         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3263         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3264
3265 2019-01-15  Zalan Bujtas  <zalan@apple.com>
3266
3267         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
3268         https://bugs.webkit.org/show_bug.cgi?id=193448
3269
3270         Reviewed by Antti Koivisto.
3271
3272         * LayoutReloaded/misc/LFC-passing-tests.txt:
3273
3274 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
3275
3276         webkitpy: Implement device type specific expected results (Part 1)
3277         https://bugs.webkit.org/show_bug.cgi?id=192162
3278
3279         Reviewed by Lucas Forschler.
3280
3281         Device type specific expected results covers two related ideas. The first (covered by this change)
3282         is where to search for -expected.* files. The second is which tests to run based on the
3283         TestExpectations.txt file.
3284
3285         After this change, the baseline search path will be determined by the type of device running a
3286         test. Device type will be passed into any function which picks a file based on the baseline search
3287         path.
3288
3289         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3290         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
3291         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3292         (Manager.run): Print baseline search path for each round of devices.
3293         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3294         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
3295         (SingleTestRunner._expected_driver_output): Ditto.
3296         (SingleTestRunner._driver_input): Ditto.
3297         * Scripts/webkitpy/layout_tests/views/printing.py:
3298         (Printer.print_config): Move printing of baseline search path to a separate function.
3299         (Printer.print_baseline_search_path): Moved from Printer.print_config.
3300         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3301         (Testprinter.test_print_config):
3302         (Testprinter.test_print_baseline_search_path):
3303         * Scripts/webkitpy/port/base.py:
3304         (Port.baseline_search_path): Pass device_type through.
3305         (Port._expected_baselines_for_suffixes): Ditto.
3306         (Port.expected_baselines): Ditto.
3307         (Port.expected_filename): Ditto.
3308         (Port.expected_checksum): Ditto.
3309         (Port.expected_image): Ditto.
3310         (Port.expected_audio): Ditto.
3311         (Port.expected_text): Ditto.
3312         (Port.reference_files): Ditto.
3313         (Port.tests): Ditto.
3314         (Port._expanded_paths): Ditto.
3315         (Port.skipped_layout_tests): Ditto.
3316         (Port.expectations_dict): Ditto.
3317         (Port._port_specific_expectations_files): Ditto.
3318         (Port.expectations_files): Ditto.
3319         (Port.test_search_path): Ditto.
3320         (Port._tests_for_other_platforms): Ditto.
3321         * Scripts/webkitpy/port/base_unittest.py:
3322         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
3323         (PortTest.test_nonexistant_expectations): Ditto.
3324         (test_ref_tests_platform_directory): Ditto.
3325         * Scripts/webkitpy/port/darwin.py:
3326         (DarwinPort._port_specific_expectations_files): Accept device_type.
3327         * Scripts/webkitpy/port/driver.py:
3328         (DriverProxy):
3329         (DriverProxy.host): Expose _target_host for device_type information.
3330         * Scripts/webkitpy/port/gtk.py:
3331         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
3332         * Scripts/webkitpy/port/ios.py:
3333         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
3334         * Scripts/webkitpy/port/mac.py:
3335         (MacPort. default_baseline_search_path): Ditto.
3336         * Scripts/webkitpy/port/port_testcase.py:
3337         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
3338         * Scripts/webkitpy/port/test.py:
3339         * Scripts/webkitpy/port/watch.py:
3340         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
3341         * Scripts/webkitpy/port/win.py:
3342         (WinPort.test_search_path): Accept, but do not use, device_type.
3343         * Scripts/webkitpy/port/wpe.py:
3344         (WPEPort._port_specific_expectations_files): Ditto.
3345         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
3346         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
3347
3348 2019-01-15  Zalan Bujtas  <zalan@apple.com>
3349
3350         [LFC] Use the containing block's padding box to position out-of-flow elements.
3351         https://bugs.webkit.org/show_bug.cgi?id=193431
3352
3353         Reviewed by Antti Koivisto.
3354
3355         * LayoutReloaded/misc/LFC-passing-tests.txt:
3356
3357 2019-01-14  Tim Horton  <timothy_horton@apple.com>
3358
3359         Move a test implementation file that got misplaced in the Xcode project
3360
3361         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3362
3363 2019-01-14  Commit Queue  <commit-queue@webkit.org>
3364
3365         Unreviewed, rolling out r239901, r239909, r239910, r239912,
3366         r239913, and r239914.
3367         https://bugs.webkit.org/show_bug.cgi?id=193407
3368
3369         These revisions caused an internal failure (Requested by
3370         Truitt on #webkit).
3371
3372         Reverted changesets:
3373
3374         "[Cocoa] Avoid importing directly from subumbrella frameworks"
3375         https://bugs.webkit.org/show_bug.cgi?id=186016
3376         https://trac.webkit.org/changeset/239901
3377
3378         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
3379         https://trac.webkit.org/changeset/239909
3380
3381         "Tried to fix the build."
3382         https://trac.webkit.org/changeset/239910
3383
3384         "Fixed iOS builds after r239910."
3385         https://trac.webkit.org/changeset/239912
3386
3387         "More build fixing."
3388         https://trac.webkit.org/changeset/239913
3389
3390         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
3391         https://trac.webkit.org/changeset/239914
3392
3393 2019-01-14  Mark Lam  <mark.lam@apple.com>
3394
3395         Re-enable ability to build --cloop builds.
3396         https://bugs.webkit.org/show_bug.cgi?id=192955
3397         <rdar://problem/46882363>
3398
3399         Reviewed by Saam barati and Keith Miller.
3400
3401         The --cloop build option was being ignored this whole time since r236381.
3402         This patch makes it possible to build CLoop builds again.
3403
3404         * Scripts/build-jsc:
3405         * Scripts/webkitperl/FeatureList.pm:
3406         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3407
3408 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
3409
3410         webkitpy: Expose device_type from host-like objects
3411         https://bugs.webkit.org/show_bug.cgi?id=193406
3412         <rdar://problem/47262305>
3413
3414         Reviewed by Lucas Forschler.
3415
3416         Devices should expose device_type. As a result, all host objects should
3417         provide a device_type property, even if they do not yet define a device_type.
3418
3419         * Scripts/webkitpy/common/system/systemhost.py:
3420         (SystemHost):
3421         (SystemHost.device_type):
3422         * Scripts/webkitpy/common/system/systemhost_mock.py:
3423         (MockSystemHost):
3424         (MockSystemHost.device_type):
3425         * Scripts/webkitpy/port/device.py:
3426         (Device):
3427         (Device.device_type):
3428         * Scripts/webkitpy/xcode/simulated_device.py:
3429         (SimulatedDeviceManager._find_exisiting_device_for_request):
3430         (SimulatedDeviceManager._disambiguate_device_type):
3431         (SimulatedDeviceManager._does_fulfill_request):
3432         (SimulatedDeviceManager.device_count_for_type):
3433         (SimulatedDeviceManager.initialize_devices):
3434         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
3435         (test_available_devices):
3436         (test_swapping_devices):
3437
3438 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
3439
3440         webkitpy: Support alternate simctl device list output (Follow-up fix)
3441         https://bugs.webkit.org/show_bug.cgi?id=193362
3442         <rdar://problem/47122965>
3443
3444         Rubber-stamped by Lucas Forschler.
3445
3446         * Scripts/webkitpy/xcode/simulated_device.py:
3447         (SimulatedDeviceManager.populate_available_devices):
3448
3449 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
3450
3451         [iOS] Expose SPI to access the current sentence boundary and selection state
3452         https://bugs.webkit.org/show_bug.cgi?id=193398
3453         <rdar://problem/45893108>
3454
3455         Reviewed by Dean Jackson.
3456
3457         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
3458         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
3459         expected.
3460
3461         * TestWebKitAPI/EditingTestHarness.h:
3462         * TestWebKitAPI/EditingTestHarness.mm:
3463         (-[EditingTestHarness moveBackward]):
3464         (-[EditingTestHarness moveForward]):
3465         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
3466
3467         Add a couple of new helper methods on EditingTestHarness.
3468
3469         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
3470         (-[SelectionChangeObserver initWithWebView:]):
3471         (-[SelectionChangeObserver webView]):
3472         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
3473         (-[SelectionChangeObserver currentSelectionAttributes]):
3474
3475 2019-01-14  Zalan Bujtas  <zalan@apple.com>
3476
3477         [LFC][BFC] Add basic box-sizing support.
3478         https://bugs.webkit.org/show_bug.cgi?id=193392
3479
3480         Reviewed by Antti Koivisto.
3481
3482         * LayoutReloaded/misc/LFC-passing-tests.txt:
3483
3484 2019-01-14  Charlie Turner  <cturner@igalia.com>
3485
3486         [WPE] API test gardening
3487         https://bugs.webkit.org/show_bug.cgi?id=193319
3488
3489         Reviewed by Michael Catanzaro.
3490
3491         * TestWebKitAPI/glib/TestExpectations.json: Remove some now
3492         passing tests.
3493
3494 2019-01-14  Charlie Turner  <cturner@igalia.com>
3495
3496         [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
3497         https://bugs.webkit.org/show_bug.cgi?id=192977
3498
3499         Reviewed by Carlos Garcia Campos.
3500
3501         * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
3502         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
3503         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
3504         (TestWebKitAPI::GStreamerTest::SetUp):
3505         (TestWebKitAPI::GStreamerTest::TearDown):
3506         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
3507         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
3508         (TestWebKitAPI::TEST_F):
3509
3510 2019-01-14  Charlie Turner  <cturner@igalia.com>
3511
3512         [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
3513         https://bugs.webkit.org/show_bug.cgi?id=193332
3514
3515         Reviewed by Michael Catanzaro.
3516
3517         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
3518         defined as a char16_t, which changed in ICU 59, the
3519         StringTypeAdapter<UnsignedInt, ...> overload catches casts to
3520         unsigned short. This test is relying on the behaviour that
3521         UChar=unsigned short, which doesn't hold across platforms and ICU
3522         library versions. The full fix would be a special syntax for
3523         literal characters so that these ambiguities do not arise. That
3524         work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
3525         (TestWebKitAPI::TEST):
3526
3527 2019-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
3528
3529         Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
3530
3531         * Scripts/make-dist:
3532         (Distcheck.configure):
3533
3534 2019-01-13  Aakash Jain  <aakash_jain@apple.com>
3535
3536         [ews-build] Update macOS queue configurations
3537         https://bugs.webkit.org/show_bug.cgi?id=193365
3538         <rdar://problem/47221073>
3539
3540         Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
3541
3542         * BuildSlaveSupport/ews-build/config.json:
3543
3544 2019-01-13  Zalan Bujtas  <zalan@apple.com>
3545
3546         [LFC] Adjust assert for statically positioned fixed elements
3547         https://bugs.webkit.org/show_bug.cgi?id=193385
3548
3549         Reviewed by Antti Koivisto.
3550
3551         * LayoutReloaded/misc/LFC-passing-tests.txt:
3552
3553 2019-01-13  Philippe Normand  <pnormand@igalia.com>
3554
3555         [WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
3556         https://bugs.webkit.org/show_bug.cgi?id=193387
3557
3558         Reviewed by Carlos Garcia Campos.
3559
3560         * MiniBrowser/wpe/main.cpp:
3561         (main):
3562
3563 2019-01-12  Timothy Hatcher  <timothy@apple.com>
3564
3565         Have prefers-color-scheme: light always match on macOS versions before Mojave.
3566         https://bugs.webkit.org/show_bug.cgi?id=191655
3567         rdar://problem/46074680
3568
3569         Reviewed by Megan Gardner.
3570
3571         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
3572         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
3573
3574 2019-01-12  Dan Bernstein  <mitz@apple.com>
3575
3576         [Cocoa] Avoid importing directly from subumbrella frameworks
3577         https://bugs.webkit.org/show_bug.cgi?id=186016
3578         <rdar://problem/40591038>
3579
3580         Reviewed by Sam Weinig.
3581
3582         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
3583           LaunchServices header.
3584         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3585           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3586         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
3587           when using SDKs earlier than 10.13.
3588         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
3589           and OTHER_CPLUSPLUSFLAGS.
3590         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3591           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3592         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
3593           LaunchServices header.
3594
3595 2019-01-11  John Wilander  <wilander@apple.com>
3596
3597         Compile out Web API Statistics Collection
3598         https://bugs.webkit.org/show_bug.cgi?id=193370
3599         <rdar://problem/45388584>
3600
3601         Reviewed by Brent Fulgham.
3602
3603         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3604             Defined ENABLE_WEB_API_STATISTICS, off by default.
3605
3606 2019-01-11  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
3607
3608         [WPE] Add gtk-doc
3609         https://bugs.webkit.org/show_bug.cgi?id=178900
3610
3611         Reviewed by Michael Catanzaro.
3612
3613         Add Tools/gtkdoc to manifest.txt.in files.
3614         This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
3615
3616         * gtk/manifest.txt.in: Add Tools/gtkdoc directory.
3617         * wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
3618
3619 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3620
3621         [iOS] Precision drop state thrashes when dragging near the top edge of an editable element
3622         https://bugs.webkit.org/show_bug.cgi?id=193364
3623         <rdar://problem/47214117>
3624
3625         Reviewed by Tim Horton.
3626
3627         Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
3628         precise, whereas dragging near the middle of the textarea does.
3629
3630         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3631         (TestWebKitAPI::TEST):
3632
3633 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3634
3635         webkitpy: Support alternate simctl device list output
3636         https://bugs.webkit.org/show_bug.cgi?id=193362
3637         <rdar://problem/47122965>
3638
3639         Reviewed by Lucas Forschler.
3640
3641         * Scripts/webkitpy/xcode/simulated_device.py:
3642         (SimulatedDeviceManager.populate_available_devices):
3643
3644 2019-01-11  Aakash Jain  <aakash_jain@apple.com>
3645
3646         [ews-build] Update macOS queue configurations
3647         https://bugs.webkit.org/show_bug.cgi?id=193365
3648
3649         Reviewed by Lucas Forschler.
3650
3651         * BuildSlaveSupport/ews-build/config.json:
3652
3653 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3654
3655         webkitpy: Incorporate device type into baseline search path
3656         https://bugs.webkit.org/show_bug.cgi?id=193356
3657         <rdar://problem/47215515>
3658
3659         Reviewed by Lucas Forschler.
3660
3661         We need a way to include device type in the baseline search path for iOS to support device specific test expectations.
3662
3663         * Scripts/webkitpy/port/base.py:
3664         (Port.default_baseline_search_path): Allow device type to be passed in.
3665         * Scripts/webkitpy/port/gtk.py:
3666         (GtkPort.default_baseline_search_path): Ignore device type.
3667         * Scripts/webkitpy/port/ios.py:
3668         (IOSPort.default_baseline_search_path): Optionally allow device type to be incorporated into the baseline search path.
3669         (IOSPort.test_expectations_file_position): Update index for the additional device-type specific baseline search path.
3670         * Scripts/webkitpy/port/ios_device_unittest.py:
3671         (IOSDeviceTest):
3672         * Scripts/webkitpy/port/ios_simulator_unittest.py:
3673         (IOSSimulatorTest):
3674         * Scripts/webkitpy/port/mac.py:
3675         (MacPort.default_baseline_search_path): Ignore device type.
3676         * Scripts/webkitpy/port/watch.py:
3677         (WatchPort.default_baseline_search_path): Ditto.
3678         * Scripts/webkitpy/port/win.py: