2f211fe7f61086ee968ef0e8fb071b9fd29901da
[WebKit-https.git] / Tools / ChangeLog
1 2015-04-16  Anders Carlsson  <andersca@apple.com>
2
3         Deprecate _WKWebsiteDataStore in favor of WKWebsiteDataStore
4         https://bugs.webkit.org/show_bug.cgi?id=143844
5
6         Reviewed by Dan Bernstein.
7
8         * MiniBrowser/mac/AppDelegate.m:
9         (-[BrowserAppDelegate newPrivateWindow:]):
10         * MiniBrowser/mac/WK2BrowserWindowController.m:
11         (-[WK2BrowserWindowController initWithConfiguration:]):
12         (-[WK2BrowserWindowController fetchWebsiteData:]):
13         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
14         (-[WK2BrowserWindowController clearWebsiteData:]):
15
16 2015-04-16  Alex Christensen  <achristensen@webkit.org>
17
18         32-bit build fix.
19
20         * WebKitTestRunner/mac/TestControllerMac.mm:
21         (WTR::TestController::platformResetPreferencesToConsistentValues):
22         (WTR::TestController::platformConfigureViewForTest):
23         Added WK_API_ENABLED.
24
25 2015-04-16  Alex Christensen  <achristensen@webkit.org>
26
27         Removed unused WKUserContentFilterRef.
28         https://bugs.webkit.org/show_bug.cgi?id=143852
29
30         Reviewed by Sam Weinig.
31
32         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm:
33         * WebKitTestRunner/mac/TestControllerMac.mm:
34         (WTR::TestController::platformResetPreferencesToConsistentValues):
35         (WTR::TestController::platformConfigureViewForTest):
36
37 2015-04-16  Jake Nielsen  <jacob_nielsen@apple.com>
38
39         Unreviewed. Adding myself as a commiter in contributers.json.
40
41         * Scripts/webkitpy/common/config/contributors.json:
42
43 2015-04-16  Alexey Proskuryakov  <ap@apple.com>
44
45         It is very hard to attach a debugger to WebProcess to debug tests
46         https://bugs.webkit.org/show_bug.cgi?id=143837
47
48         Reviewed by Chris Dumez.
49
50         --no-timeout used to only affect waitUntilDone timeout, but not IPC timeout in
51         WebKitTestRunner, and not pipe reading timeout in run-webkit-tests.
52
53         Now it disables all timeouts in tools, as is best for debugging tests.
54
55         * Scripts/webkitpy/port/driver.py: (Driver.run_test): Respect --no-timeout, so
56         that the script doesn't terminate DRT/WKTR when there is no output for a long time.
57
58         * WebKitTestRunner/Options.cpp: Removed --no-timeout-at-all, as --no-timeout
59         now has the same functionality.
60
61 2015-04-16  Beth Dakin  <bdakin@apple.com>
62
63         Force mouse events should go through normal mouse event handling code paths
64         https://bugs.webkit.org/show_bug.cgi?id=143749
65         -and corresponding-
66         rdar://problem/20472895
67
68         Reviewed by Dean Jackson.
69
70         Add mouseForceDown/mouseForceUp/mouseForceChanged support to WebKitTestRunner. 
71         Since there is not a way to create an NSEventTypePressure from scratch, we 
72         subclass NSEvent and override all of the critical methods.
73
74         * WebKitTestRunner/EventSenderProxy.h:
75         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
76         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
77         (WTR::EventSendingController::mouseForceDown):
78         (WTR::EventSendingController::mouseForceUp):
79         (WTR::EventSendingController::mouseForceChanged):
80         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
81         * WebKitTestRunner/TestController.cpp:
82         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
83         * WebKitTestRunner/mac/EventSenderProxy.mm:
84         (-[EventSenderPressureEvent initAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
85         (-[EventSenderPressureEvent timestamp]):
86         (-[EventSenderPressureEvent type]):
87         (-[EventSenderPressureEvent locationInWindow]):
88         (-[EventSenderPressureEvent location]):
89         (-[EventSenderPressureEvent stage]):
90         (-[EventSenderPressureEvent pressure]):
91         (-[EventSenderPressureEvent phase]):
92         (-[EventSenderPressureEvent eventNumber]):
93         (WTR::EventSenderProxy::mouseForceDown):
94         (WTR::EventSenderProxy::mouseForceUp):
95         (WTR::EventSenderProxy::mouseForceChanged):
96
97 2015-04-16  Csaba Osztrogonác  <ossy@webkit.org>
98
99         [EFL] Bump LLVM to version 3.6.0 on X86_64
100         https://bugs.webkit.org/show_bug.cgi?id=143604
101
102         Reviewed by Gyuyoung Kim.
103
104         * efl/jhbuild.modules:
105         * efl/patches/llvm-elf-add-stackmaps-arm64.patch: Added the necessary part of llvm-elf-add-stackmaps.patch.
106         * efl/patches/llvm-elf-add-stackmaps.patch: Removed, it is included in LLVM 3.6.0 release.
107         * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Removed, it is included in LLVM 3.6.0 release.
108         * efl/patches/llvm-version-arm64.patch: Added. Set PACKAGE_VERSION to "3.5.0ftl" to be able to ensure we use patched LLVM on AArch64.
109
110 2015-04-16  Csaba Osztrogonác  <ossy@webkit.org>
111
112         [EFL] Remove an unnecessary workaround from jhbuildrc
113         https://bugs.webkit.org/show_bug.cgi?id=143823
114
115         Reviewed by Gyuyoung Kim.
116
117         * efl/jhbuildrc:
118
119 2015-04-16  Csaba Osztrogonác  <ossy@webkit.org>
120
121         [GTK] Run forwarding headers generator unconditionally
122         https://bugs.webkit.org/show_bug.cgi?id=143819
123
124         Reviewed by Carlos Garcia Campos.
125
126         * TestWebKitAPI/PlatformGTK.cmake:
127         * WebKitTestRunner/PlatformGTK.cmake:
128
129 2015-04-15  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
130
131         [EFL] Add gnutls to jhbuild.module
132         https://bugs.webkit.org/show_bug.cgi?id=143777
133
134         Reviewed by Csaba Osztrogonác.
135
136         EFL port has required at least 3.0.0 version of gnutls since r176712.
137         However some old linux distributions don't support 3.0.0 version. Besides
138         other projects sometimes need to use lower version of gnutls.
139
140         This patch supports to download gnutls through jhbuild, and use it.
141
142         * efl/install-dependencies: Add nettle-dev dependency and remove libgnutls28-dev. 
143         * efl/jhbuild.modules: Download 3.3 version because 3.3 version is stable version.
144
145 2015-04-15  Mark Lam  <mark.lam@apple.com>
146
147         Remove obsolete VMInspector debugging tool.
148         https://bugs.webkit.org/show_bug.cgi?id=143798
149
150         Reviewed by Michael Saboff.
151
152         * TestWebKitAPI/CMakeLists.txt:
153         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
154         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
155         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
156         * TestWebKitAPI/Tests/JavaScriptCore/VMInspector.cpp: Removed.
157
158 2015-04-15  Jer Noble  <jer.noble@apple.com>
159
160         Unreviewed gardening; Make the previous commit apply only _post_ Yosemite.
161
162         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
163
164 2015-04-15  Jer Noble  <jer.noble@apple.com>
165
166         Unreviewed gardening; disable FullscreenZoomInitialFrame.WebKit2 API test post-Yosemite.
167
168         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
169         (TestWebKitAPI::TEST_F):
170
171 2015-04-15  Chris Dumez  <cdumez@apple.com>
172
173         [Win] DRT does not seem to reset the 'UsesPageCache' setting between tests
174         https://bugs.webkit.org/show_bug.cgi?id=143779
175
176         Reviewed by Brent Fulgham.
177
178         Reset the 'UsesPageCache' setting to FALSE between tests on Windows,
179         similarly to what is done on Mac / WK1. Without this, PageCache could
180         stay enabled after page cache tests and cause weird behaviors.
181
182         * DumpRenderTree/win/DumpRenderTree.cpp:
183         (resetWebPreferencesToConsistentValues):
184
185 2015-04-14  Simon Fraser  <simon.fraser@apple.com>
186
187         Re-enable custom dilation for antialiased fonts
188         https://bugs.webkit.org/show_bug.cgi?id=143738
189
190         Reviewed by Tim Horton.
191         
192         Enabling custom dilation for antialised fonts broke layout tests, so re-land it,
193         but disable in WebKitTestRunner and DumpRenderTree. The latter requires adding
194         a private WebKit pref. This pref defaults to YES, enabling the feature by default
195         in WK1 as we do for WK2.
196
197         * DumpRenderTree/mac/DumpRenderTree.mm:
198         (resetWebPreferencesToConsistentValues):
199         * WebKitTestRunner/TestController.cpp:
200         (WTR::TestController::resetPreferencesToConsistentValues):
201
202 2015-04-14  Brent Fulgham  <bfulgham@apple.com>
203
204         Correct layering violation in DumpRenderTree Build
205         https://bugs.webkit.org/show_bug.cgi?id=143732
206
207         Reviewed by Simon Fraser.
208
209         Correct a layering violation in DumpRenderTree by calling functions on the
210         WebCoreTestSupport library, rather than attempting to work with WebCore
211         types directly.
212
213         * DumpRenderTree/mac/EventSendingController.mm:
214         (-[EventSendingController monitorWheelEvents]): Call methods on WebCoreTestSupport, rather
215         than WebCore itself.,
216         (-[EventSendingController callAfterScrollingCompletes:]): Ditto.
217
218 2015-04-14  Benjamin Poulain  <benjamin@webkit.org>
219
220         Add a conservative DFA minimizer for the content extension matcher
221         https://bugs.webkit.org/show_bug.cgi?id=143501
222
223         Reviewed by Alex Christensen.
224
225         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
226         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
227
228 2015-04-14  Daniel Bates  <dabates@apple.com>
229
230         Skip failing test Tests/WebKit2Cocoa/FixedLayoutSize.mm on iOS
231         https://bugs.webkit.org/show_bug.cgi?id=143693
232         <rdar://problem/20530316>
233
234         Reviewed by Tim Horton.
235
236         Skip the test Tests/WebKit2Cocoa/FixedLayoutSize.mm as we do not plan
237         to use the fixed layout code on iOS at this time.
238
239         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: Add !PLATFORM(IOS)-guard.
240
241 2015-04-14  Dominik Röttsches  <dominik.rottsches@intel.com>
242
243         Remove myself from watchlist, remove empty Cairo and HarfBuzz watchlists
244         https://bugs.webkit.org/show_bug.cgi?id=143705
245
246         Unreviewed change to watchlist file.
247
248         * Scripts/webkitpy/common/config/watchlist:
249
250 2015-04-14  KwangHyuk Kim  <hyuki.kim@samsung.com>
251
252         [EFL] favicon wasn't updated for google.com sometimes.
253         https://bugs.webkit.org/show_bug.cgi?id=141940
254
255         Reviewed by Gyuyoung Kim.
256
257         As elm_entry_utf8_to_markup can include additional characters, parameter for the
258         on_icon_changed_cb was just set by using url string retrieved by ewk_view_url_get().
259
260         * MiniBrowser/efl/main.c:
261         (on_url_changed):
262
263 2015-04-13  Tim Horton  <timothy_horton@apple.com>
264
265         Add a persistent, fixed scale factor to make it easy to scale down WK(Web)Views
266         https://bugs.webkit.org/show_bug.cgi?id=143560
267         <rdar://problem/16302047>
268
269         Reviewed by Darin Adler.
270
271         * MiniBrowser/mac/BrowserWindowController.h:
272         * MiniBrowser/mac/MainMenu.xib:
273         * MiniBrowser/mac/WK1BrowserWindowController.m:
274         (-[WK1BrowserWindowController setScale:]):
275         * MiniBrowser/mac/WK2BrowserWindowController.m:
276         (viewScaleForMenuItemTag):
277         (-[WK2BrowserWindowController setScale:]):
278         (-[WK2BrowserWindowController validateMenuItem:]):
279         Add a submenu with four view scale options: 100%, 75%, 50%, and 25%.
280         When in use, we resize the window so that the view fits correctly, and
281         use automaticallyComputesFixedlayoutSizeFromViewScale so that the page's
282         layout size will not change when scaling down (but will update appropriately
283         when the view is resized).
284
285 2015-04-13  Alexey Proskuryakov  <ap@apple.com>
286
287         build.webkit.org/dashboard shows obsolete results when builds are substantially out of order
288         https://bugs.webkit.org/show_bug.cgi?id=138630
289
290         Reviewed by Tim Horton.
291
292         Make sure that we always load at least one in order productive iteration.
293
294         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
295         (BuildbotQueue): Added _hasLoadedIterationForInOrderResult to track whether the queue
296         is done loading at least one iteration that wasn't an out of order build.
297         (BuildbotQueue.prototype.loadMoreHistoricalIterations): Listen for iteration load
298         when that's needed to check for out of order builds.
299         (BuildbotQueue.prototype.update): Ditto.
300         (BuildbotQueue.prototype._checkForInOrderResult): Check if the queue has an in order
301         result, and if it does not, load more iterations.
302         (BuildbotQueue.prototype.loadAll): We have everything loaded, so we certainly have
303         an in order iteration loaded too.
304         (BuildbotQueue.prototype.compareIterations): Extracted from sortIterations(), and
305         corrected to always sort loaded iterations before unloaded ones.
306
307 2015-04-10  Brent Fulgham  <bfulgham@apple.com>
308
309         Expand test infrastructure to support scrolling tests
310         https://bugs.webkit.org/show_bug.cgi?id=143286
311         <rdar://problem/20375516>
312
313         Reviewed by Simon Fraser.
314
315         Extend the WK1 and WK2 test programs to support two new EventSender commands:
316         (1) monitorWheelEvents: Tells DRT and WKTR to track the wheel event and animation state, so that we can
317         block executing tests until WebKit has completed any rubberband, scroll, or scroll-snap animations.
318         (2) callAfterScrollingCompletes: Provide a callback method to be executed when WebKit determines that
319         relevant rubberband, scroll, and scroll-snap animations are finished.
320
321         * DumpRenderTree/mac/EventSendingController.mm:
322         (+[EventSendingController isSelectorExcludedFromWebScript:]): Update to recognize 'callAfterScrollingCompletes:'
323         and 'monitorWheelEvents'.
324         (+[EventSendingController webScriptNameForSelector:]): Ditto.
325         (-[EventSendingController mouseScrollByX:andY:continuously:]): Add some stderr logging to help when
326         debugging test failures.
327         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]): Ditto.
328         (-[EventSendingController callAfterScrollingCompletes:]): Added. Protects the JSObject representing the callback
329         function, then passes it to WebCore to be called once the test deferrals have been cleared.
330         (-[EventSendingController monitorWheelEvents:]): Added. Activates the wheel event tracking used by the
331         'callAfterScrollingCompletes' method.
332         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Added signatures for 'callAfterScrollingCompletes'
333         and 'monitorWheelEvents'.
334         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
335         (WTR::EventSendingController::callAfterScrollingCompletes): Added. Protects the JSObject representing the
336         callback function, then passes it to WebCore to be called once the test deferrals have been cleared
337         (WTR::EventSendingController::monitorWheelEvents): Added. Activates the wheel event tracking used by the
338         'callAfterScrollingComplates' method.
339         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
340
341 2015-04-13  Alexey Proskuryakov  <ap@apple.com>
342
343         build.webkit.org/dashboard: Crash-only queues should show failure when testing fails to start
344         https://bugs.webkit.org/show_bug.cgi?id=143656
345
346         Reviewed by Darin Adler.
347
348         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
349         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
350
351 2015-04-13  Sergio Villar Senin  <svillar@igalia.com>
352
353         REGRESSION(r181134): [GTK] Test /webkit2/WebKitWebView/insecure-content is failing after r181134
354         https://bugs.webkit.org/show_bug.cgi?id=142387
355
356         Reviewed by Carlos Garcia Campos.
357
358         Running mixed content is blocked by default since r181134. Updated
359         the test case to reflect the new default settings.
360
361         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
362         (testInsecureContent):
363
364 2015-04-13  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
365
366         Fix wrong value variable in ENABLE_NAVIGATOR_HWCONCURRENCY
367         https://bugs.webkit.org/show_bug.cgi?id=143667
368
369         Reviewed by Csaba Osztrogonác.
370
371         ENABLE_NAVIGATOR_HWCONCURRENCY has used $registerProtocolHandlerSupport value variable
372         since r169017. Added $hardwareConcurrencySupport for it.
373
374         Additionally networkInfoSupport is removed because this feature was removed due to spec out.
375
376         * Scripts/webkitperl/FeatureList.pm:
377
378 2015-04-13  Csaba Osztrogonác  <ossy@webkit.org>
379
380         [cmake] Add ENABLE(ATTACHMENT_ELEMENT) to the build system
381         https://bugs.webkit.org/show_bug.cgi?id=143664
382
383         Reviewed by Gyuyoung Kim.
384
385         * Scripts/webkitperl/FeatureList.pm:
386
387 2015-04-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
388
389         [EFL] Enable Media Source
390         https://bugs.webkit.org/show_bug.cgi?id=143635
391
392         Reviewed by Csaba Osztrogonác.
393
394         * Scripts/webkitperl/FeatureList.pm: Enable media source on efl port.
395
396 2015-04-12  Alexey Proskuryakov  <ap@apple.com>
397
398         build.webkit.org/dashboard: Crash-only queues should show failure when failure limit is exceeded
399         https://bugs.webkit.org/show_bug.cgi?id=143646
400
401         Reviewed by David Kilzer.
402
403         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
404         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
405
406 2015-04-11  Alexey Proskuryakov  <ap@apple.com>
407
408         Use en_US spell checker for tests on Mac instead of Multilingual
409         https://bugs.webkit.org/show_bug.cgi?id=143641
410
411         Reviewed by Dan Bernstein.
412
413         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
414         While at it, override NSUserDictionaryReplacementItems, so that user replacements
415         cannot affect tests.
416
417         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize):
418         Made this more like WebKit1 version.
419
420 2015-04-10  Tim Horton  <timothy_horton@apple.com>
421
422         Replace setFixedLayoutSizeEnabled: with an enum of layout modes
423         https://bugs.webkit.org/show_bug.cgi?id=143576
424
425         Reviewed by Simon Fraser.
426
427         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm:
428         (TEST):
429         Adopt.
430
431 2015-04-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
432
433         Update my email address and expertise.
434         https://bugs.webkit.org/show_bug.cgi?id=143586
435
436         Unreviewed, just update my info.
437
438         * Scripts/webkitpy/common/config/contributors.json:
439
440 2015-04-09  Joseph Pecoraro  <pecoraro@apple.com>
441
442         Flakiness Dashboard not loading insecure content if loaded with https URL
443         https://bugs.webkit.org/show_bug.cgi?id=143570
444
445         Reviewed by Alexey Proskuryakov.
446
447         * TestResultServer/app.yaml:
448         * TestResultServer/static-dashboards/loader.js:
449         Switch to https scheme.
450
451 2015-04-09  Csaba Osztrogonác  <ossy@webkit.org>
452
453         [EFL][GTK] WebKit2's generate-forwarding-headers.pl runs too many times
454         https://bugs.webkit.org/show_bug.cgi?id=142907
455
456         Reviewed by Carlos Garcia Campos.
457
458         * TestWebKitAPI/PlatformEfl.cmake:
459         * TestWebKitAPI/PlatformGTK.cmake:
460         * WebKitTestRunner/PlatformEfl.cmake:
461         * WebKitTestRunner/PlatformGTK.cmake:
462
463 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
464
465         [Mac] Unreviewed test fix after r182584
466         https://bugs.webkit.org/show_bug.cgi?id=143452
467
468         Put both of these tests back to their original state now that the underlying
469         problem is fixed.
470
471         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp:
472         (TestWebKitAPI::TEST):
473         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
474         (TestWebKitAPI::TEST):
475
476 2015-04-08  Filip Pizlo  <fpizlo@apple.com>
477
478         run-jsc-benchmarks geomean of preferred means shouldn't print the VMs header twice
479         https://bugs.webkit.org/show_bug.cgi?id=143553
480
481         Reviewed by Ryosuke Niwa.
482         
483         Remove the spurious printVMs left over from an earlier change.
484
485         * Scripts/run-jsc-benchmarks:
486
487 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
488
489         [Mac] Unreviewed test fix after r182581
490
491         The behavior of control-left-click is controlled by a system preference.
492         Our test bots have this turned off.
493
494         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp:
495         (TestWebKitAPI::TEST):
496         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
497         (TestWebKitAPI::TEST):
498
499 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
500
501         [Mac] WebKit is not honoring OS preferences for secondary click behaviors
502         https://bugs.webkit.org/show_bug.cgi?id=143452
503         <rdar://problem/20437483>
504
505         Reviewed by Tim Horton.
506
507         Add a new API test to confirm that Cocoa mouse button press events are properly
508         tagged with the desired menu behavior (i.e., 'None', 'Context', or 'Action'.)
509
510         The WK2 test dispatches mouse down events to a PlatformWebView, and checks with
511         some registered event handlers that the expected button press and context menu
512         events are received.
513
514         The WK1 unit test creates an NSEvent with the desired button press state, and then
515         uses WebCore::PlatformEventFactory::createPlatformMouseEvent to create a WebCore event.
516         We check the resulting PlatformMouseEvent for proper state.
517
518         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test files.
519         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp: Added.
520         (TestWebKitAPI::buildAndPerformTest): Helper function to build/run an individual test.
521         * TestWebKitAPI/Tests/WebKit2/mouse-button-listener.html: Added.
522         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm: Added.
523         (TestWebKitAPI::canCallMenuTypeForEvent): Helper function.
524         (TestWebKitAPI::buildAndPerformTest): Helper function to build/run an individual test.
525         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
526         (TestWebKitAPI::PlatformWebView::simulateButtonClick): Added method to support firing
527         mouse down events.
528         * TestWebKitAPI/mac/PlatformWebViewMac.h:
529
530 2015-04-08  Michael Catanzaro  <mcatanzaro@igalia.com>
531
532         [GTK] Add pango to jhbuild-optional.modules
533         https://bugs.webkit.org/show_bug.cgi?id=143537
534
535         Reviewed by Martin Robinson.
536
537         * gtk/jhbuild-optional.modules: Add pango.
538
539 2015-04-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
540
541         [XvfbDriver] Regular expression used to match running X servers fails on Fedora 22.
542         https://bugs.webkit.org/show_bug.cgi?id=143530
543
544         Reviewed by Žan Doberšek.
545
546         Assume that the default value for display (:0) is reserved and start checking on :1
547         Adjust webkitpy test and include two new test cases for this bug (display number not specified)
548         and for X server named Xorg.bin (previous bug 1376599)
549
550         * Scripts/webkitpy/port/xvfbdriver.py:
551         (XvfbDriver._next_free_display)
552         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
553         (XvfbDriverTest.test_start_no_pixel_tests):
554         (XvfbDriverTest.test_start_pixel_tests):
555         (XvfbDriverTest.test_start_arbitrary_worker_number):
556         (XvfbDriverTest.test_next_free_display):
557         (XvfbDriverTest.test_start_next_worker):
558 2015-04-08  Alex Christensen  <achristensen@webkit.org>
559
560         Block popups from content extensions.
561         https://bugs.webkit.org/show_bug.cgi?id=143497
562
563         Reviewed by Brady Eidson.
564
565         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
566         (TestWebKitAPI::TEST_F):
567         Added popup test.
568
569 2015-04-08  Alex Christensen  <achristensen@webkit.org> and Patrick Gansterer  <paroga@webkit.org>
570
571         Add CMake build system for WinCairo port.
572         https://bugs.webkit.org/show_bug.cgi?id=115944
573
574         Reviewed by Chris Dumez.
575
576         * CMakeLists.txt:
577         * WinLauncher/CMakeLists.txt: Added.
578
579 2015-04-08  Carlos Garcia Campos  <cgarcia@igalia.com>
580
581         [GTK] Crash in DOMObjectCache when a wrapped object owned by the cache is unreffed by the user
582         https://bugs.webkit.org/show_bug.cgi?id=143521
583
584         Reviewed by Martin Robinson.
585
586         Add a way to detect unexpected web process crashes to WebViewTest,
587         and a test case to testDOMCache to trigger the crash.
588
589         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
590         (WebKitDOMNodeTest::testDOMCache):
591         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
592         (testWebKitWebViewProcessCrashed):
593         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
594         (WebViewTest::WebViewTest):
595         (WebViewTest::webProcessCrashed):
596         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
597
598 2015-04-07  Alexey Proskuryakov  <ap@apple.com>
599
600         PageVisibilityStateWithWindowChanges should only be enabled on Yosemite
601         rdar://problem/20461342
602
603         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
604
605 2015-04-07  Commit Queue  <commit-queue@webkit.org>
606
607         Unreviewed, rolling out r182511.
608         https://bugs.webkit.org/show_bug.cgi?id=143507
609
610         caused debug test failures (Requested by alexchristensen on
611         #webkit).
612
613         Reverted changeset:
614
615         "Block popups from content extensions."
616         https://bugs.webkit.org/show_bug.cgi?id=143497
617         http://trac.webkit.org/changeset/182511
618
619 2015-04-07  Alex Christensen  <achristensen@webkit.org>
620
621         Block popups from content extensions.
622         https://bugs.webkit.org/show_bug.cgi?id=143497
623
624         Reviewed by Brady Eidson.
625
626         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
627         (TestWebKitAPI::TEST_F):
628         Added popup test.
629
630 2015-04-07  Benjamin Poulain  <benjamin@webkit.org>
631
632         Get the features.json files ready for open contributions
633         https://bugs.webkit.org/show_bug.cgi?id=143436
634
635         Reviewed by Darin Adler.
636
637         * Scripts/webkitpy/style/checkers/jsonchecker.py:
638         (JSONFeaturesChecker.check):
639         Extend the syntax checking a bit, but leave everything non-mandatory
640         very loose until we figure what fields are important.
641
642 2015-04-07  Tim Horton  <timothy_horton@apple.com>
643
644         Expose and test fixedLayoutSize via modern WebKit SPI
645         https://bugs.webkit.org/show_bug.cgi?id=143500
646
647         Reviewed by Simon Fraser.
648
649         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
650         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: Added.
651         (-[FixedLayoutSizeNavigationDelegate webView:didFinishNavigation:]):
652         (TEST):
653         Add a test that verifies that fixedLayoutSize works at all, that
654         it persists through a navigation, and that turning it back off reverts to
655         laying out at the size of the view.
656
657 2015-04-07  Michael Catanzaro  <mcatanzaro@igalia.com>
658
659         Unreviewed. Add myself as a committer.
660
661         * Scripts/webkitpy/common/config/contributors.json:
662
663 2015-04-07  Brent Fulgham  <bfulgham@apple.com>
664
665         [Win] Bots complain about missing /etc/catalog
666         https://bugs.webkit.org/show_bug.cgi?id=143484
667
668         Reviewed by Chris Dumez.
669
670         The libxml2 build on Mac, iOS, and Windows does not provide the set
671         of default catalog files. We do not actually need these for our
672         purposes, but we get warnings and some bot flakiness because they
673         are not present.
674
675         We can avoid both problems the same way the Mac and iOS ports do,
676         by setting the XML_CATALOG_FILES environment variable to 'empty string',
677         which avoid the warnings and bot problems.
678
679         * Scripts/webkitpy/port/win.py:
680         (WinPort.setup_environ_for_server): Added.
681
682 2015-04-06  Sam Weinig  <sam@webkit.org>
683
684         Use content extensions in MiniBrowser.
685         https://bugs.webkit.org/show_bug.cgi?id=143446
686
687         Reviewed by Alex Christensen.
688
689         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
690         * MiniBrowser/mac/AppDelegate.h:
691         * MiniBrowser/mac/AppDelegate.m:
692         (-[BrowserAppDelegate init]):
693         (-[BrowserAppDelegate showExtensionsManager:]):
694         (-[BrowserAppDelegate userContentContoller]):
695         * MiniBrowser/mac/ExtensionManagerWindowController.h: Added.
696         * MiniBrowser/mac/ExtensionManagerWindowController.m: Added.
697         (-[ExtensionManagerWindowController init]):
698         (-[ExtensionManagerWindowController windowDidLoad]):
699         (-[ExtensionManagerWindowController add:]):
700         (-[ExtensionManagerWindowController remove:]):
701         * MiniBrowser/mac/ExtensionManagerWindowController.xib: Added.
702         * MiniBrowser/mac/MainMenu.xib:
703
704 2015-04-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
705
706         web-platform-tests server should retrieve the modules file relatively to its docroot path
707         https://bugs.webkit.org/show_bug.cgi?id=142742
708
709         Reviewed by Darin Adler.
710
711         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
712         (WebPlatformTestServer._install_modules): Compute the modules description file path according wpt server doc root path.
713
714 2015-04-06  Commit Queue  <commit-queue@webkit.org>
715
716         Unreviewed, rolling out r182445.
717         https://bugs.webkit.org/show_bug.cgi?id=143459
718
719         broke 32 bit build (Requested by alexchristensen on #webkit).
720
721         Reverted changeset:
722
723         "Use content extensions in MiniBrowser."
724         https://bugs.webkit.org/show_bug.cgi?id=143446
725         http://trac.webkit.org/changeset/182445
726
727 2015-04-06  Sam Weinig  <sam@webkit.org>
728
729         Use content extensions in MiniBrowser.
730         https://bugs.webkit.org/show_bug.cgi?id=143446
731
732         Reviewed by Alex Christensen.
733
734         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
735         * MiniBrowser/mac/AppDelegate.h:
736         * MiniBrowser/mac/AppDelegate.m:
737         (-[BrowserAppDelegate init]):
738         (-[BrowserAppDelegate showExtensionsManager:]):
739         (-[BrowserAppDelegate userContentContoller]):
740         * MiniBrowser/mac/ExtensionManagerWindowController.h: Added.
741         * MiniBrowser/mac/ExtensionManagerWindowController.m: Added.
742         (-[ExtensionManagerWindowController init]):
743         (-[ExtensionManagerWindowController windowDidLoad]):
744         (-[ExtensionManagerWindowController add:]):
745         (-[ExtensionManagerWindowController remove:]):
746         * MiniBrowser/mac/ExtensionManagerWindowController.xib: Added.
747         * MiniBrowser/mac/MainMenu.xib:
748
749 2015-04-06  Michael Catanzaro  <mcatanzaro@gnome.org>
750
751         [GTK] install-dependencies should prefer dnf to yum
752         https://bugs.webkit.org/show_bug.cgi?id=143441
753
754         Reviewed by Martin Robinson.
755
756         Test for the existance of dnf before yum, and only try to use yum if dnf does not exist.
757
758         * gtk/install-dependencies:
759
760 2015-04-06  Andy Estes  <aestes@apple.com>
761
762         [iOS] 'make clean' fails in Tools/WebKitTestRunner
763         https://bugs.webkit.org/show_bug.cgi?id=143455
764
765         Reviewed by Dan Bernstein.
766
767         This Makefile adds '-target WebKitTestRunnerApp' to OTHER_OPTIONS during iOS builds, but the top-level
768         Makefile.shared adds '-alltargets' for clean builds, and xcodebuild does not allow both -target and -alltargets.
769
770         * WebKitTestRunner/Makefile: Don't add '-target WebKitTestRunerApp' to OTHER_OPTIONS on clean builds.
771
772 2015-04-06  Alexey Proskuryakov  <ap@apple.com>
773
774         WebKit1.SetAndUpdateCacheModelPreferencesChangeMix fails on some machines
775         https://bugs.webkit.org/show_bug.cgi?id=143450
776
777         Reviewed by Anders Carlsson.
778
779         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm: (TestWebKitAPI::TEST):
780         Make sure that the view is actually closed, regardless of anything else that happens beneath.
781         Also, removed unnecessary get() calls.
782
783 2015-04-03  Alexey Proskuryakov  <ap@apple.com>
784
785         Reduce the dependency on Flash in regression tests
786         https://bugs.webkit.org/show_bug.cgi?id=143391
787
788         Reviewed by Anders Carlsson.
789
790         * WebKitTestRunner/TestController.cpp: (WTR::TestController::decidePolicyForPluginLoad):
791         Only allow QuickTime and the test plug-in.
792
793 2015-04-06  Youenn Fablet  <youenn.fablet@crf.canon.fr>
794
795         W3C test importer should generate the modules installed dynamically to run wpt tests
796         https://bugs.webkit.org/show_bug.cgi?id=142738
797
798         Reviewed by Ryosuke Niwa.
799
800         The test importer can now generate the submodules description file based on information extracted from the corresponding git repository.
801         The implementation is done within TestDownloader and it is activated for the WPT repository.
802         LayoutTests/imported/w3c/resources/WPTModules is renamed as LayoutTests/imported/w3c/resources/web-platform-tests-modules.json for that reason.
803
804         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
805         (WebPlatformTestServer._install_modules): Updated to cope with path as array.
806         * Scripts/webkitpy/w3c/test_downloader.py:
807         (TestDownloader._git_submodules_status): Added so that it can be overriden for unit tests.
808         (TestDownloader):
809         (TestDownloader._git_submodules_description): Computes submodule description.
810         (TestDownloader.generate_git_submodules_description): Write submodule description in a file.
811         * Scripts/webkitpy/w3c/test_importer.py:
812         (TestImporter.do_import): Added the possibility to post process the tests.
813         (TestImporter):
814         (TestImporter.generate_git_submodules_description_for_all_repositories): Enable generating module description file.
815         (TestImporter.should_convert_test_harness_links): Updated according new options format.
816         * Scripts/webkitpy/w3c/test_importer_unittest.py:
817         (TestImporterTest.import_downloaded_tests): Making use of TestDownloaderMock. 
818         (TestImporterTest.import_downloaded_tests.TestDownloaderMock): Added to override submodule status gathering.
819         (TestImporterTest.import_downloaded_tests.TestDownloaderMock.__init__):
820         (TestImporterTest.import_downloaded_tests.TestDownloaderMock._git_submodules_status):
821         (TestImporterTest.test_submodules_generation): Added to check that modules description files works.
822
823 2015-04-05  Antti Koivisto  <antti@apple.com>
824
825         Bloom filter should support longer hashes
826         https://bugs.webkit.org/show_bug.cgi?id=143419
827
828         Reviewed by Dan Bernstein.
829
830         * TestWebKitAPI/Tests/WTF/BloomFilter.cpp:
831         (TestWebKitAPI::generateRandomDigests):
832         (TestWebKitAPI::TEST):
833
834 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
835
836         run-jsc-stress-tests --remote should add libllvmForJSC.so to the bundle on Linux
837         https://bugs.webkit.org/show_bug.cgi?id=143372
838
839         Reviewed by Darin Adler.
840
841         * Scripts/run-jsc-stress-tests:
842
843 2015-04-03  Antti Koivisto  <antti@apple.com>
844
845         Add non-counting bloom filter class
846         https://bugs.webkit.org/show_bug.cgi?id=143366
847
848         Reviewed by Sam Weinig.
849
850         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
851         * TestWebKitAPI/Tests/WTF/BloomFilter.cpp: Added.
852         (TestWebKitAPI::generateRandomHashes):
853         (TestWebKitAPI::TEST):
854
855 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
856
857         FTL JIT tests should fail if LLVM library isn't available
858         https://bugs.webkit.org/show_bug.cgi?id=143374
859
860         Reviewed by Mark Lam.
861
862         * Scripts/run-jsc-stress-tests:
863
864 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
865
866         [EFL] Speedup jhbuild with disable running autogen.sh
867         https://bugs.webkit.org/show_bug.cgi?id=143369
868
869         Reviewed by Gyuyoung Kim.
870
871         * efl/jhbuild.modules:
872
873 2015-04-01  Alexey Proskuryakov  <ap@apple.com>
874
875         filter-webkit-build should filter out "created by an unsupported XCDependencyGraph build" lines
876         https://bugs.webkit.org/show_bug.cgi?id=143282
877
878         Reviewed by Daniel Bates.
879
880         * Scripts/filter-build-webkit: (shouldIgnoreLine): Do it.
881
882 2015-04-01  Alexey Proskuryakov  <ap@apple.com>
883
884         When LayoutTestHelper fails to start, we continue to run the tests, ending up with mysterious failures
885         https://bugs.webkit.org/show_bug.cgi?id=143240
886         rdar://problem/19990425
887
888         Reviewed by Tim Horton.
889
890         * DumpRenderTree/mac/LayoutTestHelper.m:
891         (colorProfileURLForDisplay):
892         (saveDisplayColorProfiles):
893         Gracefully handle it when the current profile cannot be retrieved, fixing at
894         least one case when LayoutTestHelper couldn't start.
895
896         * Scripts/webkitpy/layout_tests/controllers/manager.py:
897         (Manager._set_up_run):
898         (Manager._force_pixel_tests_if_needed):
899         * Scripts/webkitpy/port/base.py: (Port.to.start_helper):
900         * Scripts/webkitpy/port/mac.py: (MacPort.start_helper):
901         Return and check an error from start_helper().
902
903 2015-04-01  Brent Fulgham  <bfulgham@apple.com>
904
905         [Win] Run test-webkitpy as part of EWS (just like we do on other platforms)
906         https://bugs.webkit.org/show_bug.cgi?id=143321
907
908         Reviewed by Alexey Proskuryakov.
909
910         * EWSTools/start-queue-win.sh: Add commands to run 'test-webkitpy' during processing loop.
911
912 2015-04-01  Enrica Casucci  <enrica@apple.com>
913
914         Injected bundle messages should be at the page level.
915         https://bugs.webkit.org/show_bug.cgi?id=143283
916
917         Reviewed by Alexey Proskuryakov.
918
919         Updating WebKitTestRunner to use the new page level messaging.
920         The author of this patch is Tim Horton, I just finished it.
921
922         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
923         (WTR::EventSendingController::mouseDown):
924         (WTR::EventSendingController::mouseUp):
925         (WTR::EventSendingController::mouseMoveTo):
926         (WTR::EventSendingController::leapForward):
927         (WTR::EventSendingController::scheduleAsynchronousClick):
928         (WTR::EventSendingController::keyDown):
929         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
930         (WTR::EventSendingController::mouseScrollBy):
931         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
932         (WTR::EventSendingController::continuousMouseScrollBy):
933         (WTR::EventSendingController::addTouchPoint):
934         (WTR::EventSendingController::updateTouchPoint):
935         (WTR::EventSendingController::setTouchModifier):
936         (WTR::EventSendingController::setTouchPointRadius):
937         (WTR::EventSendingController::touchStart):
938         (WTR::EventSendingController::touchMove):
939         (WTR::EventSendingController::touchEnd):
940         (WTR::EventSendingController::touchCancel):
941         (WTR::EventSendingController::clearTouchPoints):
942         (WTR::EventSendingController::releaseTouchPoint):
943         (WTR::EventSendingController::cancelTouchPoint):
944         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
945         (WTR::InjectedBundle::didReceiveMessage):
946         (WTR::InjectedBundle::didReceiveMessageToPage):
947         (WTR::InjectedBundle::done):
948         (WTR::InjectedBundle::outputText):
949         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
950         (WTR::InjectedBundle::postAddChromeInputField):
951         (WTR::InjectedBundle::postRemoveChromeInputField):
952         (WTR::InjectedBundle::postFocusWebView):
953         (WTR::InjectedBundle::postSetBackingScaleFactor):
954         (WTR::InjectedBundle::postSetWindowIsKey):
955         (WTR::InjectedBundle::postSimulateWebNotificationClick):
956         (WTR::InjectedBundle::postSetAddsVisitedLinks):
957         (WTR::InjectedBundle::setGeolocationPermission):
958         (WTR::InjectedBundle::setMockGeolocationPosition):
959         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
960         (WTR::InjectedBundle::setUserMediaPermission):
961         (WTR::InjectedBundle::setCustomPolicyDelegate):
962         (WTR::InjectedBundle::setHidden):
963         (WTR::InjectedBundle::setCacheModel):
964         (WTR::InjectedBundle::shouldProcessWorkQueue):
965         (WTR::InjectedBundle::processWorkQueue):
966         (WTR::InjectedBundle::queueBackNavigation):
967         (WTR::InjectedBundle::queueForwardNavigation):
968         (WTR::InjectedBundle::queueLoad):
969         (WTR::InjectedBundle::queueLoadHTMLString):
970         (WTR::InjectedBundle::queueReload):
971         (WTR::InjectedBundle::queueLoadingScript):
972         (WTR::InjectedBundle::queueNonLoadingScript):
973         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
974         (WTR::TestRunner::setHandlesAuthenticationChallenges):
975         (WTR::TestRunner::setAuthenticationUsername):
976         (WTR::TestRunner::setAuthenticationPassword):
977         (WTR::TestRunner::secureEventInputIsEnabled):
978         (WTR::TestRunner::setBlockAllPlugins):
979         * WebKitTestRunner/TestController.cpp:
980         (WTR::TestController::createWebViewWithOptions):
981         (WTR::TestController::resetStateToConsistentValues):
982         (WTR::TestController::didReceivePageMessageFromInjectedBundle):
983         (WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundle):
984         * WebKitTestRunner/TestController.h:
985         * WebKitTestRunner/TestInvocation.cpp:
986         (WTR::TestInvocation::invoke):
987         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
988
989 2015-04-01  Commit Queue  <commit-queue@webkit.org>
990
991         Unreviewed, rolling out r182174 and r182177.
992         https://bugs.webkit.org/show_bug.cgi?id=143314
993
994         Try to correct EWS failures (Requested by bfulgham on
995         #webkit).
996
997         Reverted changesets:
998
999         "Python SCM should be able to retrieve untracked files"
1000         https://bugs.webkit.org/show_bug.cgi?id=143135
1001         http://trac.webkit.org/changeset/182174
1002
1003         "[buildbot] clean-build script should remove untracked files
1004         and revert local changes too"
1005         https://bugs.webkit.org/show_bug.cgi?id=142400
1006         http://trac.webkit.org/changeset/182177
1007
1008 2015-04-01  Alex Christensen  <achristensen@webkit.org>
1009
1010         [Content Extensions] Properly handle regexes that match everything.
1011         https://bugs.webkit.org/show_bug.cgi?id=143281
1012
1013         Reviewed by Benjamin Poulain.
1014
1015         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1016         (TestWebKitAPI::testRequest):
1017         (TestWebKitAPI::makeBackend):
1018         (TestWebKitAPI::TEST_F):
1019         Removed duplicate code and added test.
1020
1021 2015-03-31  Benjamin Poulain  <bpoulain@apple.com>
1022
1023         Content Extensions: split the state machines to minimize prefix states
1024         https://bugs.webkit.org/show_bug.cgi?id=143253
1025
1026         Reviewed by Alex Christensen.
1027
1028         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1029         (TestWebKitAPI::TEST_F):
1030         (TestWebKitAPI::testPatternStatus):
1031
1032 2015-03-31  Yusuke Suzuki  <utatane.tea@gmail.com>
1033
1034         Clean up Identifier factories to clarify the meaning of StringImpl*
1035         https://bugs.webkit.org/show_bug.cgi?id=143146
1036
1037         Reviewed by Filip Pizlo.
1038
1039         Simple API tests for StringImpl are added.
1040
1041         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1042         (TestWebKitAPI::TEST):
1043
1044 2015-03-31  Csaba Osztrogonác  <ossy@webkit.org>
1045
1046         [EFL] Add AArch64 builder and tester bot to build.webkit.org
1047         https://bugs.webkit.org/show_bug.cgi?id=143092
1048
1049         Reviewed by Gyuyoung Kim.
1050
1051         * BuildSlaveSupport/build.webkit.org-config/config.json:
1052         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1053         (Factory.__init__):
1054         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1055
1056 2015-03-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1057
1058         [buildbot] clean-build script should remove untracked files and revert local changes too
1059         https://bugs.webkit.org/show_bug.cgi?id=142400
1060
1061         Reviewed by Ryosuke Niwa.
1062
1063         This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
1064         A helper routine SCM.discard_untracked_files is added for that purpose.
1065
1066         * BuildSlaveSupport/clean-build:
1067         (main): Making call to Scripts/clean-webkit
1068         * Scripts/clean-webkit: Added.
1069         (main): Revert changes and delete untracked files.
1070         * Scripts/webkitpy/common/checkout/scm/scm.py:
1071         (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.
1072         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1073         (SCMTest._shared_test_discard_untracked_files):
1074         (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.
1075
1076 2015-03-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1077
1078         Python SCM should be able to retrieve untracked files
1079         https://bugs.webkit.org/show_bug.cgi?id=143135
1080
1081         Reviewed by Ryosuke Niwa.
1082
1083         This patch introduces SCM.untracked_files to retrieve a list of untracked files.
1084         Ignored files may be included or not in this list according boolean passed to the function.
1085
1086         * Scripts/webkitpy/common/checkout/scm/git.py:
1087         (Git.untracked_files):
1088         * Scripts/webkitpy/common/checkout/scm/scm.py:
1089         (SCM.untracked_files):
1090         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1091         (SCMTest._shared_test_untracked_files):
1092         (test_untracked_files):
1093         (GitSVNTest.test_untracked_files):
1094         * Scripts/webkitpy/common/checkout/scm/svn.py:
1095         (SVN.untracked_files):
1096
1097 2015-03-30  Alex Christensen  <achristensen@webkit.org>
1098
1099         [Content Extensions] Correctly handle regular expressions matching everything
1100         https://bugs.webkit.org/show_bug.cgi?id=143235
1101
1102         Reviewed by Benjamin Poulain.
1103
1104         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1105         (TestWebKitAPI::checkCompilerError):
1106         (TestWebKitAPI::TEST_F):
1107         Test ContentExtensionErrors.
1108
1109 2015-03-30  Alexey Proskuryakov  <ap@apple.com>
1110
1111         DumpRenderTree should set NSWindowDisplayWithRunLoopObserver
1112         https://bugs.webkit.org/show_bug.cgi?id=143241
1113         rdar://problem/20351297
1114
1115         Reviewed by Mark Lam.
1116
1117         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
1118
1119 2015-03-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1120
1121         [CMake][EFL] Remove redundant library link and include path
1122         https://bugs.webkit.org/show_bug.cgi?id=143221
1123
1124         Reviewed by Csaba Osztrogonác.
1125
1126         * ImageDiff/PlatformEfl.cmake: Remove unnecessary library link and include path.
1127
1128 2015-03-30  Sam Weinig  <sam@webkit.org>
1129
1130         [Content Extensions] Flesh out the UserContentExtensionStore
1131         https://bugs.webkit.org/show_bug.cgi?id=143123
1132
1133         Reviewed by Benjamin Poulain.
1134
1135         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1136         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm: Added.
1137         Add tests for _WKUserContentExtensionStore.
1138
1139 2015-03-30  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
1140
1141         Update install-dependencies Fedora packages after r181624
1142         https://bugs.webkit.org/show_bug.cgi?id=143215
1143
1144         Add json-glib, libv4l, openssl and pulseaudio development packages to
1145         the Fedora list providing we need them to build WebKit dependencies
1146         for this distribution.
1147
1148         Reviewed by Philippe Normand.
1149
1150         * gtk/install-dependencies:
1151
1152 2015-03-30  Commit Queue  <commit-queue@webkit.org>
1153
1154         Unreviewed, rolling out r182119.
1155         https://bugs.webkit.org/show_bug.cgi?id=143196
1156
1157         problem with syntax (Requested by youenn on #webkit).
1158
1159         Reverted changeset:
1160
1161         "[buildbot] clean-build script should remove untracked files
1162         and revert local changes too"
1163         https://bugs.webkit.org/show_bug.cgi?id=142400
1164         http://trac.webkit.org/changeset/182119
1165
1166 2015-03-30  Benjamin Poulain  <benjamin@webkit.org>
1167
1168         Start the features.json files
1169         https://bugs.webkit.org/show_bug.cgi?id=143207
1170
1171         Reviewed by Darin Adler.
1172
1173         I kept the style checking light. We'll have to figure
1174         what is the best format for each field.
1175
1176         * Scripts/webkitpy/style/checker.py:
1177         (CheckerDispatcher._create_checker):
1178         * Scripts/webkitpy/style/checkers/jsonchecker.py:
1179         (JSONContributorsChecker.check):
1180         (JSONFeaturesChecker):
1181         (JSONFeaturesChecker.check):
1182
1183 2015-03-29  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1184
1185         [buildbot] clean-build script should remove untracked files and revert local changes too
1186         https://bugs.webkit.org/show_bug.cgi?id=142400
1187
1188         Reviewed by Ryosuke Niwa.
1189
1190         This patch cleans the WebKit folder by deleting SCM untracked files and reverting changes for tracked files.
1191
1192         * BuildSlaveSupport/clean-build:
1193         (main): Adding call to Tools/Scripts/clean-webkit.
1194         * Scripts/clean-webkit: Added.
1195         (main): Removes untracked and changed files.
1196         * Scripts/webkitpy/common/checkout/scm/git.py:
1197         (Git.untracked_files): Retrieves GIT untracked files.
1198         * Scripts/webkitpy/common/checkout/scm/scm.py:
1199         (SCM.untracked_files): Retrieves SVN untracked files.
1200         (SCM):
1201         (SCM.discard_untracked_files): Deletes untracked files/folders.
1202         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1203         (SCMTest._shared_test_untracked_files): Unit testing for untracked files.
1204         (test_untracked_files):
1205         (GitSVNTest.test_untracked_files):
1206         * Scripts/webkitpy/common/checkout/scm/svn.py:
1207         (SVN.untracked_files):
1208
1209 2015-03-27  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1210
1211         [CMake] Remove unnecessary INCLUDE_IF_EXISTS macro 
1212         https://bugs.webkit.org/show_bug.cgi?id=143138
1213
1214         Reviewed by Csaba Osztrogonác.
1215
1216         INCLUDE_IF_EXISTS isn't used except for 2 places. However those uses can
1217         be replaced with WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS.
1218
1219         * ImageDiff/CMakeLists.txt:
1220         Use WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS() instead of INCLUDE_IF_EXISTS.
1221         * WebKitTestRunner/CMakeLists.txt: ditto.
1222
1223 2015-03-27  Myles C. Maxfield  <mmaxfield@apple.com>
1224
1225         Support building WTF on Windows without Cygwin
1226         https://bugs.webkit.org/show_bug.cgi?id=143084
1227
1228         Reviewed by Brent Fulgham.
1229
1230         Windows without Cygwin doesn't have curl, unzip, or grep. Luckily, Perl does all of these things.
1231         This patch also migrates to using File::Spec->catfile() for directory separators.
1232
1233         * Scripts/update-webkit-dependency:
1234         (wanted):
1235         * Scripts/update-webkit-support-libs:
1236         (wanted):
1237         (downloadExpectedVersionNumber):
1238         (zipFileVersion):
1239         (toUnixPath): Deleted.
1240         * Scripts/webkitdirs.pm:
1241         (determineSourceDir):
1242         (windowsSourceSourceDir):
1243         (windowsLibrariesDir):
1244         (windowsOutputDir):
1245         (checkInstalledTools):
1246         (buildVisualStudioProject):
1247
1248 2015-03-27  Alex Christensen  <achristensen@webkit.org>
1249
1250         Fix WinCairo bot.
1251         https://bugs.webkit.org/show_bug.cgi?id=143086
1252
1253         Reviewed by Brent Fulgham.
1254
1255         * Scripts/webkitdirs.pm:
1256         (buildVisualStudioProject):
1257         (runSvnUpdateAndResolveChangeLogs):
1258         Use ActivePerl-friendly perl.
1259
1260 2015-03-27  Csaba Osztrogonác  <ossy@webkit.org>
1261
1262         URTBF after r182059 to fix the EFL build.
1263
1264         * TestWebKitAPI/CMakeLists.txt:
1265
1266 2015-03-26  Alexey Proskuryakov  <ap@apple.com>
1267
1268         Layout test results URL loads in WK1 but not WK2 minibrowser
1269         https://bugs.webkit.org/show_bug.cgi?id=143117
1270
1271         Reviewed by Tim Horton.
1272
1273         * MiniBrowser/mac/WK2BrowserWindowController.m:
1274         (-[WK2BrowserWindowController fetch:]): Fix this, international domain names, and
1275         everything.
1276         (-[WK2BrowserWindowController updateTextFieldFromURL:]): Ditto.
1277
1278 2015-03-26  Jer Noble  <jer.noble@apple.com>
1279
1280         Add --allowed-host support to run-webkit-tests
1281         https://bugs.webkit.org/show_bug.cgi?id=142938
1282
1283         Reviewed by Brent Fulgham.
1284
1285         Accept --allowed-host arguments from run-webkit-tests and pass them through to
1286         DumpRenderTree and WebKitTestRunner.
1287
1288         Drive-by fix: Depending on the value of the --layout-test-dir parameter, layout test results
1289         are placed in the wrong location. The argument is compared with each tests's path, and if a
1290         relative path or a path with '..' was used, results are placed alongside the test. Take the
1291         absolute path of the --layout-test-dir argument, collapsing path components like '..'.
1292
1293         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1294         (parse_args):
1295         * Scripts/webkitpy/port/base.py:
1296         (Port.__init__):
1297         (Port.allowed_hosts):
1298         * Scripts/webkitpy/port/driver.py:
1299         (Driver.cmd_line):
1300
1301 2015-03-26  Jer Noble  <jer.noble@apple.com>
1302
1303         [Mac] Add an --allowed-host argument to DRT and WKTR to allow tests to connect to non-localhost servers
1304         https://bugs.webkit.org/show_bug.cgi?id=142931
1305
1306         Reviewed by Brent Fulgham.
1307
1308         Currently, both DRT and WKTR will refuse to allow network connections to non-localhost servers
1309         over HTTP/HTTPS. For certain testing scenarios, however, it would be useful if both DRT and
1310         WKTR could be allowed to make HTTP/HTTPS connections to certain, specific servers defined at
1311         runtime.
1312
1313         To allow this, add an optional argument to DRT and WKTR, --allowed-host, which will add the specified
1314         hostname to a whitelist; requests to these hosts will allowed to proceed normally.
1315
1316         Drive-by fix: in InjectedBundlePage::willSendRequestForFrame, we get the top loading frame from the
1317         injected bundle. But after the main resource load completes, the bundle nulls out it's pointer to the
1318         top loading frame, which causes a subsequent crash when further resources are requested. Instead, get
1319         the top loading frame from the page, as we do elsewhere in this class.
1320
1321         * DumpRenderTree/TestRunner.h:
1322         (TestRunner::allowedHosts):
1323         (TestRunner::setAllowedHosts):
1324         * DumpRenderTree/mac/DumpRenderTree.mm:
1325         (initializeGlobalsFromCommandLineOptions):
1326         (runTest):
1327         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1328         (isAllowedHost):
1329         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
1330         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1331         (WTR::InjectedBundle::didReceiveMessage):
1332         (WTR::InjectedBundle::isAllowedHost):
1333         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1334         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1335         (WTR::isAllowedHost):
1336         (WTR::InjectedBundlePage::willSendRequestForFrame):
1337         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1338         * WebKitTestRunner/Options.cpp:
1339         (WTR::handleOptionAllowedHost):
1340         (WTR::OptionsHandler::OptionsHandler):
1341         * WebKitTestRunner/Options.h:
1342         * WebKitTestRunner/TestController.cpp:
1343         (WTR::TestController::initialize):
1344         (WTR::TestController::resetStateToConsistentValues):
1345         * WebKitTestRunner/TestController.h:
1346
1347 2015-03-26  Brady Eidson  <beidson@apple.com>
1348
1349         Apply ContentExtension actions after redirects.
1350         <rdar://problem/20062613> and https://bugs.webkit.org/show_bug.cgi?id=143055
1351
1352         Reviewed by Alex Christensen.
1353
1354         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1355         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Dump the fact that the load error is kWKErrorCodeCannotShowURL
1356           which is specifically interesting to a new test.
1357
1358 2015-03-26  Csaba Osztrogonác  <ossy@webkit.org>
1359
1360         [EFL] Disable building libseccomp on AArch64
1361         https://bugs.webkit.org/show_bug.cgi?id=143094
1362
1363         Reviewed by Gyuyoung Kim.
1364
1365         * efl/jhbuildrc:
1366
1367 2015-03-26  Csaba Osztrogonác  <ossy@webkit.org>
1368
1369         [jhbuild] git should use only 1 thread for cloning jhbuild
1370         https://bugs.webkit.org/show_bug.cgi?id=143095
1371
1372         Reviewed by Gyuyoung Kim.
1373
1374         * jhbuild/jhbuild-wrapper:
1375         (clone_jhbuild):
1376
1377 2015-03-25  Joseph Pecoraro  <pecoraro@apple.com>
1378
1379         Update prepare-ChangeLog to work with ES6 Class syntax
1380         https://bugs.webkit.org/show_bug.cgi?id=143069
1381
1382         Reviewed by Timothy Hatcher.
1383
1384         * Scripts/prepare-ChangeLog:
1385         (get_function_line_ranges_for_javascript):
1386         Better handle ES6 Class syntax.
1387
1388         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt:
1389         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js:
1390         (BaseClass):
1391         (DerivedClass):
1392         (DerivedClass.staticMethod):
1393         (DerivedClass.prototype.method.nestedFunctionInsideMethod):
1394         (DerivedClass.prototype.method):
1395         (DerivedClass.prototype.get getter):
1396         (namespace.MyClass):
1397         (namespace.MyClass.staticMethod):
1398         (namespace.MyClass.prototype.method.nestedFunctionInsideMethod):
1399         (namespace.MyClass.prototype.method):
1400         (namespace.MyClass.prototype.get getter):
1401         Proof!
1402
1403 2015-03-25  Filip Pizlo  <fpizlo@apple.com>
1404
1405         Use JITCompilationCanFail in more places, and make the fail path of JITCompilationMustSucceed a crash instead of attempting GC
1406         https://bugs.webkit.org/show_bug.cgi?id=142993
1407
1408         Reviewed by Mark Lam.
1409         
1410         Bunch of support for testing executable allocation failure.
1411
1412         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz: Added.
1413         (fail):
1414         * Scripts/run-javascriptcore-tests:
1415         (runJSCStressTests):
1416         * Scripts/run-jsc-stress-tests:
1417
1418 2015-03-25  Myles C. Maxfield  <mmaxfield@apple.com>
1419
1420         Fix Windows build from r181977.
1421
1422         Unreviewed.
1423
1424         * Scripts/update-webkit-dependency:
1425
1426 2015-03-25  Sam Weinig  <sam@webkit.org>
1427
1428         Address additional review feedback from https://bugs.webkit.org/show_bug.cgi?id=143059.
1429
1430         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1431         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
1432
1433 2015-03-25  Myles C. Maxfield  <mmaxfield@apple.com>
1434
1435         Migrate update-webkit for Windows to not require Cygwin
1436         https://bugs.webkit.org/show_bug.cgi?id=143040
1437
1438         Reviewed by Brent Fulgham.
1439
1440         * Scripts/update-webkit-dependency:
1441         (wanted):
1442         (toUnixPath): Deleted.
1443         * Scripts/webkitdirs.pm:
1444         (fontExists):
1445         (checkInstalledTools):
1446         (setupAppleWinEnv):
1447
1448 2015-03-25  Sam Weinig  <sam@webkit.org>
1449
1450         [Content Extensions] Convert content extension compiling to return error codes and write its output using a client
1451         https://bugs.webkit.org/show_bug.cgi?id=143059
1452
1453         Reviewed by Alex Christensen.
1454
1455         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1456         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
1457         Update for new interface of compileRuleList().
1458
1459 2015-03-25  Alex Christensen  <achristensen@webkit.org>
1460
1461         [Content Extensions] Add multi-DFA compiling and interpreting.
1462         https://bugs.webkit.org/show_bug.cgi?id=143010
1463
1464         Reviewed by Benjamin Poulain.
1465
1466         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1467         (TestWebKitAPI::testRequest):
1468         (TestWebKitAPI::TEST_F):
1469         Add some tests for ignore-previous-rules and large rulesets.
1470
1471 2015-03-25  Alexey Proskuryakov  <ap@apple.com>
1472
1473         Mavericks WK1 still runs JSC tests
1474         https://bugs.webkit.org/show_bug.cgi?id=143035
1475
1476         Reviewed by Csaba Osztrogonác.
1477
1478         * BuildSlaveSupport/build.webkit.org-config/config.json: Bring Mavericks WK1 in line
1479         with other bots.
1480
1481         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Updated the tests
1482         accordingly.
1483
1484 2015-03-25  Commit Queue  <commit-queue@webkit.org>
1485
1486         Unreviewed, rolling out r181932.
1487         https://bugs.webkit.org/show_bug.cgi?id=143041
1488
1489         The test fails most of the time on bots (Requested by ap on
1490         #webkit).
1491
1492         Reverted changeset:
1493
1494         "[Content Extensions] Add multi-DFA compiling and
1495         interpreting."
1496         https://bugs.webkit.org/show_bug.cgi?id=143010
1497         http://trac.webkit.org/changeset/181932
1498
1499 2015-03-24  Alex Christensen  <achristensen@webkit.org>
1500
1501         [Content Extensions] Add multi-DFA compiling and interpreting.
1502         https://bugs.webkit.org/show_bug.cgi?id=143010
1503
1504         Reviewed by Benjamin Poulain.
1505
1506         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1507         (TestWebKitAPI::testRequest):
1508         (TestWebKitAPI::TEST_F):
1509         Add some tests for ignore-previous-rules and large rulesets.
1510
1511 2015-03-24  Benjamin Poulain  <bpoulain@apple.com>
1512
1513         Make URL filter patterns matching consistent and add a simple canonicalization step
1514         https://bugs.webkit.org/show_bug.cgi?id=142998
1515
1516         Reviewed by Alex Christensen.
1517
1518         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1519
1520 2015-03-24  Csaba Osztrogonác  <ossy@webkit.org>
1521
1522         [EFL] Add OpenWebRTC in jhbuild
1523         https://bugs.webkit.org/show_bug.cgi?id=142778
1524
1525         Reviewed by Gyuyoung Kim.
1526
1527         Original patch by Philippe Normand <pnormand@igalia.com>
1528
1529         * efl/install-dependencies: Dependencies for OpenWebRTC.
1530         * efl/jhbuild.modules: build OpenWebRTC, libusrsctp, libnice and
1531         the openwebrtc gst plugins.
1532
1533 2015-03-23  Brent Fulgham  <bfulgham@apple.com>
1534
1535         Regression(r181257): WTF_WorkQueue.Simple is flaky
1536         https://bugs.webkit.org/show_bug.cgi?id=142560
1537
1538         Remove the check that the refCount has returned to one after the
1539         individual tasks have completed. It's too nondeterministic when
1540         the reference count will be reduced.
1541
1542         Reviewed by Alexey Proskuryakov
1543
1544         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
1545         (TestWebKitAPI::TEST): Remove test that refCount is back to 1.
1546
1547 2015-03-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1548
1549         [CMake][EFL] Put failure API test excutables into failure directory
1550         https://bugs.webkit.org/show_bug.cgi?id=142965
1551
1552         Reviewed by Csaba Osztrogonác.
1553
1554         Move failing WK2 API test executables to *bin/TestWebKitAPI/WebKit2/failure* directory.
1555
1556         * TestWebKitAPI/CMakeLists.txt: Fix a typo. Change *testBaseName* with *testName*.
1557         * TestWebKitAPI/PlatformEfl.cmake: Additionally remove unnecessary SHARED_CORE and comment for SeccompFilters test.
1558
1559 2015-03-22  Benjamin Poulain  <benjamin@webkit.org>
1560
1561         CSS Selectors: fix attribute case-insensitive matching of Contain and List
1562         https://bugs.webkit.org/show_bug.cgi?id=142932
1563
1564         Reviewed by Darin Adler.
1565
1566         Add tests for the new features and fix some existing tests using the 
1567         stringFromUTF8() utility recently added by Dhi.
1568
1569         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1570         (TestWebKitAPI::stringFromUTF8):
1571         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1572
1573 2015-03-22  Michael Catanzaro  <mcatanzaro@igalia.com>
1574
1575         [GTK] install-dependencies should install orc
1576         https://bugs.webkit.org/show_bug.cgi?id=142955
1577
1578         Reviewed by Martin Robinson.
1579
1580         Install orc, needed by openwebrtc
1581
1582         * gtk/install-dependencies:
1583
1584 2015-03-22  Benjamin Poulain  <bpoulain@apple.com>
1585
1586         Detect when url filter pattern with groups match the empty string
1587         https://bugs.webkit.org/show_bug.cgi?id=142930
1588
1589         Reviewed by Sam Weinig.
1590
1591         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1592
1593 2015-03-22  Anders Carlsson  <andersca@apple.com>
1594
1595         _WKWebsiteDataStore should clear WebSQL databases
1596         https://bugs.webkit.org/show_bug.cgi?id=142947
1597
1598         Reviewed by Sam Weinig.
1599
1600         Add a variable that keeps track of the types of data we want to operate on, for easier debugging.
1601
1602         * MiniBrowser/mac/WK2BrowserWindowController.m:
1603         (-[WK2BrowserWindowController fetchWebsiteData:]):
1604         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
1605         (-[WK2BrowserWindowController clearWebsiteData:]):
1606
1607 2015-03-20  Mark Hahnenberg  <mhahnenb@gmail.com>
1608
1609         GCTimer should know keep track of nested GC phases
1610         https://bugs.webkit.org/show_bug.cgi?id=142675
1611
1612         Reviewed by Darin Adler.
1613
1614         Adds a tool to aid in parsing the GC phase timing output into a
1615         tree-like structure based on the parent-child relationships
1616         of nested GC phases.
1617
1618         * Scripts/parse-gc-phase-timings: Added.
1619         (Timing):
1620         (Timing.__init__):
1621         (Timing.__unicode__):
1622         (Timing.__str__):
1623         (Timing.__repr__):
1624         (parse_input):
1625         (print_timing_node):
1626         (print_timing_tree):
1627         (link_parents):
1628         (main):
1629
1630 2015-03-20  Brent Fulgham  <bfulgham@apple.com>
1631
1632         [Win] Temporarily turn of EWS Windows tests while I debug the test failure.
1633
1634         * Scripts/webkitpy/common/config/ews.json:
1635
1636 2015-03-20  Philippe Normand  <pnormand@igalia.com>
1637
1638         [GTK][jhbuild] Fix flakey failures due to unstable googlecode repository
1639         https://bugs.webkit.org/show_bug.cgi?id=142867
1640
1641         Rubber-stamped by Csaba Osztrogon.
1642
1643         * gtk/jhbuild.modules: Use Ossy's libusrsctp Github fork. Also use
1644         a fixed revision for the openwebrtc-gst-plugins.
1645
1646 2015-03-19  Ryosuke Niwa  <rniwa@webkit.org>
1647
1648         Unreviewed build fix. Don't try to report stats for all benchmarks.
1649         Just report the geometric mean of preferred means.
1650
1651         * Scripts/run-jsc-benchmarks:
1652
1653 2015-03-19  Ryosuke Niwa  <rniwa@webkit.org>
1654
1655         run-jsc-benchmarks should only report preferred mean
1656         https://bugs.webkit.org/show_bug.cgi?id=142874
1657
1658         Reviewed by Geoffrey Garen.
1659
1660         Just collect statistics for the preferred mean.
1661
1662         * Scripts/run-jsc-benchmarks:
1663
1664 2015-03-19  Alex Christensen  <achristensen@webkit.org>
1665
1666         [Content Extensions] Test regular expression parse failures.
1667         https://bugs.webkit.org/show_bug.cgi?id=142872
1668
1669         Reviewed by Benjamin Poulain.
1670
1671         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1672         (TestWebKitAPI::testPatternStatus):
1673         (TestWebKitAPI::TEST_F):
1674         Added tests for each parsing status.
1675
1676 2015-03-19  Alex Christensen  <achristensen@webkit.org>
1677
1678         Fix API tests after r181754.
1679
1680         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1681         (TestWebKitAPI::testRequest):
1682
1683 2015-03-19  Brady Eidson  <beidson@apple.com>
1684
1685         Part of content extensions should apply css selectors
1686         https://bugs.webkit.org/show_bug.cgi?id=142604
1687
1688         Reviewed by Alex Christensen.
1689
1690         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1691         (WebCore::ContentExtensions::operator<<):
1692
1693 2015-03-19  Brent Fulgham  <bfulgham@apple.com>
1694
1695         [Win] Activate tests on EWS
1696         https://bugs.webkit.org/show_bug.cgi?id=142850
1697
1698         Reviewed by Alexey Proskuryakov.
1699
1700         * Scripts/webkitpy/common/config/ews.json: Add me as
1701         the EWS bot watcher, and activate tests.
1702
1703 2015-03-19  Csaba Osztrogonác  <ossy@webkit.org>
1704
1705         [GTK] Fix inspector userinterface related incremental build issue
1706         https://bugs.webkit.org/show_bug.cgi?id=142849
1707
1708         Reviewed by Carlos Garcia Campos.
1709
1710         * Scripts/webkitdirs.pm:
1711         (shouldRemoveCMakeCache):
1712
1713 2015-03-18  Alex Christensen  <achristensen@webkit.org>
1714
1715         [ContentExtensions] Prepare for compiling stylesheets of selectors to be used on every page.
1716         https://bugs.webkit.org/show_bug.cgi?id=142799
1717
1718         Reviewed by Brady Eidson.
1719
1720         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1721         (TestWebKitAPI::testPattern):
1722         (TestWebKitAPI::TEST_F):
1723         Start testing regex failures.
1724
1725 2015-03-18  Dhi Aurrahman  <diorahman@rockybars.com>
1726
1727         Fix StringView typos after r181525 and r181558
1728         https://bugs.webkit.org/show_bug.cgi?id=142772
1729
1730         Reviewed by Darin Adler.
1731
1732         Add some tests in [1] to cover the StringView::startsWith, 
1733         StringView::startsWithIgnoringASCIICase, StringView::endsWith and 
1734         StringView::endsWithIgnoringASCIICase implementations.
1735
1736         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1737         (TestWebKitAPI::TEST):
1738
1739 2015-03-18  Dana Burkart  <dburkart@apple.com>
1740
1741         Remove extraneous import to fix the build.
1742
1743         Unreviewed.
1744
1745         * Scripts/webkitpy/port/driver.py:
1746
1747 2015-03-18  Dana Burkart  <dburkart@apple.com>
1748
1749         ASAN_OPTIONS=allocator_may_return_null=1 needs to be set 
1750         https://bugs.webkit.org/show_bug.cgi?id=142547
1751
1752         Reviewed by Alexey Proskuryakov.
1753
1754         * Scripts/webkitpy/port/driver.py:
1755         (Driver._setup_environ_for_driver):
1756
1757 2015-03-18  Alexey Proskuryakov  <ap@apple.com>
1758
1759         Tweak how AppleSystemFontOSSubversion default is added
1760         https://bugs.webkit.org/show_bug.cgi?id=142835
1761
1762         Reviewed by Dan Bernstein.
1763
1764         * DumpRenderTree/mac/DumpRenderTree.mm:
1765         (setDefaultsToConsistentValuesForTesting):
1766
1767 2015-03-18  Dan Bernstein  <mitz@apple.com>
1768
1769         prepare-ChangeLog doesn't understand C string literals split across multiple lines with \
1770         https://bugs.webkit.org/show_bug.cgi?id=142815
1771
1772         Reviewed by Darin Adler.
1773
1774         * Scripts/prepare-ChangeLog:
1775         (get_function_line_ranges_for_cpp): If the line ends with a backslash instead of a matching
1776         quotation mark, use new variable $quotation_mark to remember what we are looking for, and
1777         keep consuming the quoted text until the matching quotation mark is reached. Emit the
1778         warning only if a line ends without a backslash before the matching quotation mark was found.
1779
1780 2015-03-18  Joseph Pecoraro  <pecoraro@apple.com>
1781
1782         Remove unused "preprocessor" parameter to sub-CodeGenerators
1783         https://bugs.webkit.org/show_bug.cgi?id=142793
1784
1785         Reviewed by Darin Adler.
1786
1787         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1788         (new):
1789
1790 2015-03-18  Csaba Osztrogonác  <ossy@webkit.org>
1791
1792         [EFL] Bump gstreamer version to 1.4.4
1793         https://bugs.webkit.org/show_bug.cgi?id=142782
1794
1795         Reviewed by Philippe Normand.
1796
1797         * efl/jhbuild.modules:
1798         * efl/patches/gst-libav.patch:
1799         * efl/patches/gst-plugins-bad-remove-gnustep-support.patch: Added.
1800         * efl/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
1801
1802 2015-03-17  Tim Horton  <timothy_horton@apple.com>
1803
1804         Fix the iOS build.
1805
1806         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
1807         (WTR::InjectedBundle::platformInitialize):
1808
1809 2015-03-17  Dean Jackson  <dino@apple.com>
1810
1811         check-webkit-style should allow "bool a : 1"
1812         https://bugs.webkit.org/show_bug.cgi?id=142794
1813
1814         Reviewed by Brent Fulgham.
1815
1816         We should allow member bitfields of the form:
1817
1818         bool m_var : 1;
1819
1820         It seems that Visual Studio 8 was the last compiler that
1821         wasn't happy about not using unsigned here. We already have
1822         about 500 cases (in WebCore) where people were ignoring this rule.
1823
1824         * Scripts/webkitpy/style/checkers/cpp.py:
1825         (check_language): Allow "bool".
1826         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add tests.
1827         (CppStyleTest.test_enum_bitfields):
1828         (CppStyleTest.test_plain_integral_bitfields):
1829
1830 2015-03-17  Benjamin Poulain  <bpoulain@apple.com>
1831
1832         Compile character ranges targeting the same state as range check in the bytecode
1833         https://bugs.webkit.org/show_bug.cgi?id=142759
1834
1835         Reviewed by Alex Christensen.
1836
1837         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1838         (TestWebKitAPI::TEST_F):
1839
1840 2015-03-17  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1841
1842         W3C test parser and converter should use test importer host
1843         https://bugs.webkit.org/show_bug.cgi?id=142729
1844
1845         Reviewed by Bem Jones-Bey.
1846
1847         When instantiated by TestImporter, TestParser and TestConverter are now using the same host.
1848         This enables adding more TestImporter unit testing.
1849         This patch also ensures that the git object instantiated by TestDownloader is using the
1850         same Executive and FileSystem object as TestDownloader, again to enable TestImporter/TestDownloader unit testing.
1851
1852         * Scripts/webkitpy/common/system/filesystem_mock.py:
1853         (MockFileSystem.copytree): Fixes implementation as it creates a runtime error.
1854         * Scripts/webkitpy/w3c/test_downloader.py:
1855         (TestDownloader.git): Set the executive of the git object to the one of TestDownloader. Refactoring in a new git function for future reuse.
1856         (TestDownloader.checkout_test_repository): Making use of the new git function.
1857         * Scripts/webkitpy/w3c/test_importer.py:
1858         (TestImporter.find_importable_tests): Adding host as parameter to the parser.
1859         (TestImporter.import_tests): Adding host as parameter to the converter.
1860         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1861         (TestImporterTest.create_test_download_importer): Creating a test downloader mock, to be reused by other tests.
1862         (TestImporterTest):
1863         (TestImporterTest.test_harnesslinks_conversion): Adding test to check that test harness links are converted for CSS tests but not WPT tests. 
1864         * Scripts/webkitpy/w3c/test_parser.py:
1865         (TestParser.__init__): Adding host as parameter constructor.
1866
1867 2015-03-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1868
1869         [GTK] WebKitDOM objects leaking
1870         https://bugs.webkit.org/show_bug.cgi?id=118788
1871
1872         Reviewed by Darin Adler and Sergio Villar Senin.
1873
1874         Update DOMObjectCache unit test to check that DOM objects are also
1875         released when new contents are loaded in the web view, and the old
1876         document is detached from the frame.
1877
1878         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
1879         (testWebKitDOMObjectCache):
1880         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
1881         (runTest):
1882
1883 2015-03-17  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1884
1885         W3C test importer default import folder should be LayoutTests/imported/w3c
1886         https://bugs.webkit.org/show_bug.cgi?id=142728
1887
1888         Reviewed by Bem Jones-Bey.
1889
1890         * Scripts/webkitpy/w3c/test_importer.py:
1891         (parse_args): Updating the default destination option value to 'imported/w3c'.
1892
1893 2015-03-17  Philippe Normand  <pnormand@igalia.com>
1894
1895         [GTK] basic OpenWebRTC build support
1896         https://bugs.webkit.org/show_bug.cgi?id=142393
1897
1898         Reviewed by Carlos Garcia Campos.
1899
1900         * gtk/jhbuild.modules: Add OpenWebRTC and its dependencies. This
1901         is not the upstream OpenWebRTC repository. This temporary fork
1902         contains a few patches needed by WebKit for audio/video rendering.
1903
1904 2015-03-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1905
1906         [CMake][EFL] Build test tools only for developer mode
1907         https://bugs.webkit.org/show_bug.cgi?id=142761
1908
1909         Reviewed by Csaba Osztrogonác.
1910
1911         Do not build EFL MiniBrowser, WebKitTestRunner, and ImageDiff on production mode.
1912
1913         * CMakeLists.txt:
1914
1915 2015-03-17  Joseph Pecoraro  <pecoraro@apple.com>
1916
1917         Remove never used "useLayerOnTop" bindings generator argument
1918         https://bugs.webkit.org/show_bug.cgi?id=142773
1919
1920         Reviewed by Darin Adler.
1921
1922         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1923         (new):
1924
1925 2015-03-16  Ryosuke Niwa  <rniwa@webkit.org>
1926
1927         Enable ES6 classes by default
1928         https://bugs.webkit.org/show_bug.cgi?id=142774
1929
1930         Reviewed by Gavin Barraclough.
1931
1932         * Scripts/webkitperl/FeatureList.pm:
1933
1934 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
1935
1936         Fix webkitpy tests after r181585.
1937
1938         Looks like "me" cannot be anyone's email, it's a special case.
1939
1940         * Scripts/webkitpy/common/config/contributors.json:
1941
1942 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
1943
1944         Add tolerance to WebAudio tests
1945         https://bugs.webkit.org/show_bug.cgi?id=142676
1946
1947         Reviewed by Tim Horton.
1948
1949         * Scripts/webkitpy/common/wavediff.py: Added. Based on Jer Noble's work.
1950
1951         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1952         (TestResultWriter.create_audio_diff_and_write_result):
1953         * Scripts/webkitpy/layout_tests/models/test_failures.py:
1954         (FailureAudio.write_failure):
1955         * Scripts/webkitpy/port/base.py:
1956         (Port.do_audio_results_differ):
1957         Diff audio failures.
1958
1959         * Scripts/webkitpy/port/test.py: Added a test for the tolerance, fixed existing
1960         tests to use real parseable WAV data, and got rid of base64, which there didn't
1961         seem to have been any reason for.
1962
1963 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
1964
1965         [Mac] fast/forms/text-control-intrinsic-widths.html fails when MS Office is installed
1966         https://bugs.webkit.org/show_bug.cgi?id=142720
1967
1968         Reviewed by Myles C. Maxfield.
1969
1970         Activate system copies of Microsoft fonts for the current process, thus overriding
1971         any other ones that could be preferred by the system otherwise.
1972
1973         * DumpRenderTree/mac/DumpRenderTree.mm:
1974         (activateSystemCoreWebFonts):
1975         (adjustFonts):
1976         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1977         (WTR::activateSystemCoreWebFonts):
1978         (WTR::activateFonts):
1979
1980 2015-03-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1981
1982         Created Streams API watchlist
1983         https://bugs.webkit.org/show_bug.cgi?id=142684
1984
1985         Reviewed by Benjamin Poulain.
1986
1987         * Scripts/webkitpy/common/config/watchlist: Created StreamsAPI
1988         watchlist and added Benjamin, Youenn and me to it.
1989
1990 2015-03-15  Benjamin Poulain  <benjamin@webkit.org>
1991
1992         CSS: fix the case-insensitive matching of the attribute selectors Begin, End and Hyphen
1993         https://bugs.webkit.org/show_bug.cgi?id=142715
1994
1995         Reviewed by Brent Fulgham.
1996
1997         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1998         (TestWebKitAPI::TEST):
1999
2000 2015-03-15  Benjamin Poulain  <bpoulain@apple.com>
2001
2002         Change the exact attribute matching to be ASCII case-insensitive
2003         https://bugs.webkit.org/show_bug.cgi?id=142609
2004
2005         Reviewed by Darin Adler.
2006
2007         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2008         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2009
2010 2015-03-13  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2011
2012         WebKit test infrastructure should automate the process of cloning W3C test suite and importing tests from it
2013         https://bugs.webkit.org/show_bug.cgi?id=134764
2014
2015         Reviewed by Ryosuke Niwa.
2016
2017         TestDownloader is introduced to download W3C tests from the official
2018         W3C tests repositories (https://github.com/w3c/web-platform-tests.git
2019         and https://github.com/w3c/csswg-test.git).
2020         TestDownloader clones the repositories and checkouts revisions of the tests
2021         defined in LayoutTests/imported/w3c/resources/TestRepositories.
2022
2023         Similarly to https://codereview.chromium.org/148173016,
2024         TestDownloader copies part of the files based on the rules
2025         defined in LayoutTests/imported/w3c/resources/ImportExpectations.
2026
2027         TestDownloader is used by TestImporter when no source directory is provided.
2028
2029         * Scripts/webkitpy/w3c/test_downloader.py: Added.
2030         (TestDownloader):
2031         (TestDownloader.default_options):
2032         (TestDownloader.load_test_repositories):
2033         (TestDownloader.__init__):
2034         (TestDownloader.checkout_test_repository):
2035         (TestDownloader._init_paths_from_expectations):
2036         (TestDownloader._add_test_suite_paths):
2037         (TestDownloader._empty_directory):
2038         (TestDownloader.copy_tests):
2039         (TestDownloader.download_tests):
2040         * Scripts/webkitpy/w3c/test_importer.py:
2041         (main):
2042         (parse_args):
2043         (TestImporter.__init__):
2044         (TestImporter.do_import):
2045         (TestImporter.test_downloader):
2046         (TestImporter.find_importable_tests.should_keep_subdir):
2047         (TestImporter.should_convert_test_harness_links):
2048         (TestImporter.import_tests):
2049         (TestImporter.write_import_log):
2050
2051 2015-03-12  Alexey Proskuryakov  <ap@apple.com>
2052
2053         [Mavericks] Test snapshots are 1600x1200 on Retina devices
2054         https://bugs.webkit.org/show_bug.cgi?id=142630
2055
2056         Reviewed by Tim Horton.
2057
2058         * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::windowSnapshotImage):
2059         Removed an ifdef that disabled the fix on Mavericks.
2060
2061 2015-03-12  Csaba Osztrogonác  <ossy@webkit.org>
2062
2063         Remove isWK2 cruft from webkitdirs.pm after r170426
2064         https://bugs.webkit.org/show_bug.cgi?id=142618
2065
2066         Reviewed by Daniel Bates.
2067
2068         * Scripts/webkitdirs.pm:
2069         (isWK2): Deleted.
2070
2071 2015-03-12  Alexey Proskuryakov  <ap@apple.com>
2072
2073         testRunner.setAlwaysAcceptCookies does not work with NetworkProcess
2074         https://bugs.webkit.org/show_bug.cgi?id=138687
2075
2076         Reviewed by Carlos Garcia Campos.
2077
2078         Always change cookie policy from UI process, as changing it from WebProcess doesn't
2079         affect other processes.
2080
2081         The implementation is imperfect, because the change happens asynchronously, but I
2082         don't expect it to be a problem in practice.
2083
2084         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2085         (WTR::InjectedBundle::beginTesting):
2086         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2087         (WTR::TestRunner::setAlwaysAcceptCookies):
2088         * WebKitTestRunner/TestInvocation.cpp:
2089         (WTR::TestInvocation::invoke):
2090         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2091
2092 2015-03-12  Csaba Osztrogonác  <ossy@webkit.org>
2093
2094         [EFL] Enable building EFL 1.13 with NEON support
2095         https://bugs.webkit.org/show_bug.cgi?id=142619
2096
2097         Reviewed by Gyuyoung Kim.
2098
2099         * efl/jhbuild.modules:
2100
2101 2015-03-11  Alex Christensen  <achristensen@webkit.org>
2102
2103         [Content Extensions] Add resource type and load type triggers.
2104         https://bugs.webkit.org/show_bug.cgi?id=142422
2105
2106         Reviewed by Benjamin Poulain.
2107
2108         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2109         (TestWebKitAPI::testRequest):
2110         (TestWebKitAPI::mainDocumentRequest):
2111         (TestWebKitAPI::TEST_F):
2112         (TestWebKitAPI::testURL): Deleted.
2113
2114 2015-03-10  Sam Weinig  <sam@webkit.org>
2115
2116         Allow adding a button in input elements for auto fill related functionality
2117         <rdar://problem/19782066>
2118         https://bugs.webkit.org/show_bug.cgi?id=142564
2119
2120         Reviewed by Anders Carlsson.
2121
2122         * WebKitTestRunner/TestController.cpp:
2123         (WTR::TestController::createOtherPage):
2124         (WTR::TestController::createWebViewWithOptions):
2125         Update for new callback.
2126
2127 2015-03-11  Benjamin Poulain  <bpoulain@apple.com>
2128
2129         Add basic support for BOL and EOL assertions to the URL Filter parser
2130         https://bugs.webkit.org/show_bug.cgi?id=142568
2131
2132         Reviewed by Alex Christensen.
2133
2134         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2135         (TestWebKitAPI::TEST_F):
2136
2137 2015-03-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2138
2139         [GTK] Add support for handling TLS errors to MiniBrowser
2140         https://bugs.webkit.org/show_bug.cgi?id=142576
2141
2142         Reviewed by Sergio Villar Senin.
2143
2144         It's useful for testing TLS errors handling itself, but also to
2145         allow ignoring TLS errors when testing.
2146
2147         * MiniBrowser/gtk/BrowserWindow.c:
2148         (webViewLoadFailedWithTLSerrors):
2149         (browserWindowConstructed):
2150
2151 2015-03-11  Myles C. Maxfield  <mmaxfield@apple.com>
2152
2153         Use out-of-band messaging for RenderBox::firstLineBaseline() and RenderBox::inlineBlockBaseline()
2154         https://bugs.webkit.org/show_bug.cgi?id=142569
2155
2156         Reviewed by David Hyatt.
2157
2158         Test Optional::valueOrCompute().
2159
2160         * TestWebKitAPI/Tests/WTF/Optional.cpp:
2161         (TestWebKitAPI::TEST):
2162
2163 2015-03-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2164
2165         [GTK] Add an option to enable MiniBrowser for non developer builds and always install it
2166         https://bugs.webkit.org/show_bug.cgi?id=126688
2167
2168         Reviewed by Gustavo Noronha Silva.
2169
2170         * CMakeLists.txt: Build testing tools only for developer builds,
2171         but MiniBrowser when ENABLE_MINIBROWSER option is ON.
2172         * MiniBrowser/gtk/CMakeLists.txt: Only add
2173         -DWEBKIT_INJECTED_BUNDLE_PATH to the build for developer builds,
2174         and add a rule to install the MiniBrowser.
2175         * MiniBrowser/gtk/main.c:
2176         (main): Only set WEBKIT_INJECTED_BUNDLE_PATH env var for developer
2177         builds.
2178
2179 2015-03-11  Brent Fulgham  <bfulgham@apple.com>
2180
2181         Add some DateMath tests to TestWebKitAPI
2182         https://bugs.webkit.org/show_bug.cgi?id=142565
2183
2184         Reviewed by Alexey Proskuryakov.
2185
2186         * TestWebKitAPI/CMakeLists.txt: Add new DateMath.cpp file.
2187         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Ditto.
2188         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Ditto.
2189         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto."
2190         * TestWebKitAPI/Tests/WTF/DateMath.cpp: Added.
2191
2192 2015-03-10  Brent Fulgham  <bfulgham@apple.com>
2193
2194         Regression(r181257): WTF_WorkQueue.Simple is flaky
2195         https://bugs.webkit.org/show_bug.cgi?id=142560
2196
2197         Unreviewed attempt to improve test stability.
2198
2199         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Check the reference count for
2200         the WorkQueue a little later to redue flakiness.
2201
2202 2015-03-10  Myles C. Maxfield  <mmaxfield@apple.com>
2203
2204         Migrate from SystemUIFontSelect to AppleSystemFontOSSubversion
2205         https://bugs.webkit.org/show_bug.cgi?id=142555
2206
2207         Reviewed by Simon Fraser.
2208
2209         * DumpRenderTree/mac/DumpRenderTree.mm:
2210         (setDefaultsToConsistentValuesForTesting):
2211         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2212         (WTR::InjectedBundle::platformInitialize):
2213
2214 2015-03-10  Alex Christensen  <achristensen@webkit.org>
2215
2216         Use unsigned for HashSet size.
2217         https://bugs.webkit.org/show_bug.cgi?id=142518
2218
2219         Reviewed by Benjamin Poulain.
2220
2221         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2222         (TestWebKitAPI::TEST):
2223         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2224         (TestWebKitAPI::testInitialCapacity):
2225         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
2226         (TestWebKitAPI::TEST):
2227
2228 2015-03-10  Daniel Bates  <dabates@apple.com>
2229
2230         [iOS] Add WebKitSystemInterface for iOS 8.2
2231         https://bugs.webkit.org/show_bug.cgi?id=142505
2232
2233         Rubber-stamped by Anders Carlsson.
2234
2235         Make copy-webkitlibraries-to-product-directory install libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a.
2236         I inadvertently forgot to add libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a to script
2237         copy-webkitlibraries-to-product-directory in r181286.
2238
2239         * Scripts/copy-webkitlibraries-to-product-directory:
2240
2241 2015-03-10  Benjamin Poulain  <bpoulain@apple.com>
2242
2243         Extend URL filter's Term definition to support groups/subpatterns
2244         https://bugs.webkit.org/show_bug.cgi?id=142519
2245
2246         Reviewed by Alex Christensen.
2247
2248         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2249         (TestWebKitAPI::testURL):
2250
2251 2015-03-06  Jer Noble  <jer.noble@apple.com>
2252
2253         Add an option to run-webkit-tests to override the LayoutTests/ directory
2254         https://bugs.webkit.org/show_bug.cgi?id=142418
2255
2256         Reviewed by David Kilzer.
2257
2258         Add an arugment to run-webkit-tests which, when set, overrides the port's default LayoutTests
2259         directory. The base port will parse the options during initialization and store the override
2260         location if present. layout_tests_dir() will return this overridden location if set.
2261
2262         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2263         (parse_args):
2264         * Scripts/webkitpy/port/base.py:
2265         (Port.__init__):
2266         (Port.layout_tests_dir):
2267
2268 2015-03-09  Martin Robinson  <mrobinson@igalia.com>
2269
2270         [CMake] Enable WorkQueue tests for CMake ports
2271         https://bugs.webkit.org/show_bug.cgi?id=142473
2272
2273         Reviewed by Darin Adler.
2274
2275         * TestWebKitAPI/CMakeLists.txt: Add the WorkQueue tests source file to
2276         the list of source files.
2277         * Tools/TestWebKitAPI/PlatformEfl.cmake: Add the DispatchQueueEfl directory
2278         to the list of include directories for EFL.
2279
2280 2015-03-09  David Kilzer  <ddkilzer@apple.com>
2281
2282         Attempt to fix timeouts on iOS Simulator layout tests
2283
2284         * Scripts/webkitpy/port/ios.py:
2285         (IOSSimulatorPort.setup_test_run): Most layout test runs on iOS
2286         Simulator end after the first 50 tests time out.  Some analysis
2287         this past weekend shows that the 'Booted' status in the output
2288         of `xcrun simctl list` is not sufficient (and watching the test
2289         run shows that SpringBoard hasn't fully started to the point
2290         where it's displaying icons on the home screen).  The workaround
2291         until we have a better fix is to add an arbitrary timeout to let
2292         SpringBoard finish launching.  In practice, 15 seconds is
2293         probably enough, but 30 seconds should nearly always work.
2294
2295 2015-03-09  Per Arne Vollan  <peavo@outlook.com>
2296
2297         Unreviewed. Add myself as a committer.
2298
2299         * Scripts/webkitpy/common/config/contributors.json:
2300
2301 2015-03-09  David Kilzer  <ddkilzer@apple.com>
2302
2303         Attempt to fix WTF_WorkQueue.TwoQueues timeout test failure
2304
2305         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2306         (TestWebKitAPI::TEST): Change delay from 50ns to 50ms, and add
2307         an expectation that will fail if we hit the race condition.
2308         This test is inherently racy and will deadlock if the first job
2309         for queue2 takes the mutex lock before the second job for
2310         queue1.
2311
2312 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
2313
2314         [Win] WTF::WorkQueue does not balance ref/deref properly
2315         https://bugs.webkit.org/show_bug.cgi?id=142471
2316
2317         Reviewed by Antti Koivisto.
2318
2319         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2320         (TestWebKitAPI::TEST): Check that the refcount is correct.
2321
2322 2015-03-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2323
2324         Do not show passing test result on output of EFL layout test
2325         https://bugs.webkit.org/show_bug.cgi?id=142380
2326
2327         Reviewed by Darin Adler.
2328
2329         To show passing tests has caused inconvenience when we detect problem tests
2330         in output of layout test. So this patch applies '--debug-rwt-logging' except for EFL port
2331         in order not to show passing tests in the output of EFL layout test.
2332
2333         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2334         (RunWebKitTests.start):
2335
2336 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
2337
2338         Unreviewed build fix.
2339
2340         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2341         (TestWebKitAPI::TEST): Remove two unused variables.
2342
2343 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
2344
2345         Add some WorkQueue tests to TestWebKitAPI
2346         https://bugs.webkit.org/show_bug.cgi?id=142447
2347
2348         Reviewed by Sam Weinig.
2349
2350         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2351         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
2352         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2353         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Added.
2354         (TestWebKitAPI::simpleTest):
2355         (TestWebKitAPI::longTest):
2356         (TestWebKitAPI::thirdTest):
2357         (TestWebKitAPI::finishedTests):
2358         (TestWebKitAPI::TEST):
2359         (TestWebKitAPI::longTest2):
2360
2361 2015-03-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2362
2363         Remove willDestroyFrame in WKBundlePageLoaderClient
2364         https://bugs.webkit.org/show_bug.cgi?id=142389
2365
2366         Reviewed by Anders Carlsson.
2367
2368         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2369         (WTR::InjectedBundlePage::InjectedBundlePage):
2370
2371 2015-03-07  Brent Fulgham  <bfulgham@apple.com>
2372
2373         [Win] Increase TestWebKitAPI Test Coverage[Win] Increase TestWebKitAPI Test Coverage
2374         https://bugs.webkit.org/show_bug.cgi?id=142433
2375
2376         Reviewed by Darin Adler.
2377
2378         Include more TestWebKitAPI tests when building for Windows. Also
2379         fix a build error in MetaAllocator.cpp caused by one of the
2380         Microsoft headers #defining 'small'.
2381
2382         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2383         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
2384         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
2385
2386 2015-03-06  Sam Weinig  <sam@webkit.org>
2387
2388         [Content Extensions] Move compiling of content extensions to the UIProcess
2389         https://bugs.webkit.org/show_bug.cgi?id=142402
2390
2391         Reviewed by Benjamin Poulain.
2392
2393         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2394         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: Copied from Tools/TestWebKitAPI/Tests/WebCore/ContentFilter.cpp.
2395         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
2396         (TestWebKitAPI::InMemoryCompiledContentExtension::~InMemoryCompiledContentExtension):
2397         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
2398         (TestWebKitAPI::TEST_F):
2399         * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Removed.
2400         Update test for new name (ContentFilter -> ContentExtensions) and API (CompiledContentExtension
2401         is now abstract).
2402
2403 2015-03-06  Brent Fulgham  <bfulgham@apple.com>
2404
2405         [Win] Correct Windows build.
2406
2407         Rubberstamped by Michael Saboff
2408
2409         * win/AssembleBuildLogs/AssembleLogs.cmd: Correct cut/paste error
2410         in the GOTO labels.
2411
2412 2015-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2413
2414         [GTK] Test /webkit2/WebKitWebView/sync-request-on-max-conns might fail after finished
2415         https://bugs.webkit.org/show_bug.cgi?id=142385
2416
2417         Reviewed by Sergio Villar Senin.
2418
2419         Use stack allocated GMainLoopSources to make sure they are
2420         cancelled automatically if the test finishes before they have
2421         been processed.
2422
2423         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2424         (testWebViewSyncRequestOnMaxConns):
2425
2426 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
2427
2428         Remove Mountain Lion libraries since ML isn't supported
2429         https://bugs.webkit.org/show_bug.cgi?id=142332
2430
2431         Reviewed by Darin Adler.
2432
2433         * Scripts/copy-webkitlibraries-to-product-directory:
2434
2435 2015-03-06  Carlos Alberto Lopez Perez <clopez@igalia.com> and Youenn Fablet  <youenn.fablet@crf.canon.fr>
2436
2437         Layout tests imported/w3c/web-platform-tests certificates should not be tracked on WebKit VCS
2438         https://bugs.webkit.org/show_bug.cgi?id=142083
2439
2440         Reviewed by Simon Fraser.
2441
2442         Modifying on the fly wpt config.json to set the directory where to generate/read certificates as a subfolder of the layout test results folder.
2443
2444         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2445         (WebPlatformTestServer._copy_webkit_test_files):
2446
2447 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
2448
2449         setup-git-clone fails due to the failure to download python-irclib-0.4.8
2450         https://bugs.webkit.org/show_bug.cgi?id=141946
2451
2452         Reviewed by Ryosuke Niwa.
2453
2454         Check in ircbot.py and irclib.py to avoid network problems in the future.
2455
2456         * Scripts/webkitpy/common/net/irc/ircbot.py:
2457         * Scripts/webkitpy/thirdparty/__init__.py:
2458         (AutoinstallImportHook.find_module):
2459         (AutoinstallImportHook._install_irc): Deleted.
2460         * Scripts/webkitpy/thirdparty/__init___unittest.py:
2461         (ThirdpartyTest.test_imports):
2462         * Scripts/webkitpy/thirdparty/irc/__init__.py: Added.
2463         * Scripts/webkitpy/thirdparty/irc/ircbot.py: Added.
2464         * Scripts/webkitpy/thirdparty/irc/irclib.py: Added.
2465
2466 2015-03-06  David Kilzer  <ddkilzer@apple.com>
2467
2468         Dashboard: Perf bot status is missing for Apple {Mavericks,Yosemite} Release builds
2469
2470         See also fix to config.json in r181097.
2471
2472         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2473         (WebKitBuildbot): Add missing "WK2" to the names of the perf
2474         bots.
2475
2476 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
2477
2478         run-jsc-stress-tests should determine the architecture from ELF binaries
2479         https://bugs.webkit.org/show_bug.cgi?id=142335
2480
2481         Reviewed by Darin Adler.
2482
2483         * Scripts/run-jsc-stress-tests:
2484
2485 2015-03-05  David Kilzer  <ddkilzer@apple.com>
2486
2487         [iOS] TestExpectations for ios-simulator-wk2 should fall back to 'wk2' after 'ios-simulator'
2488         <http://webkit.org/b/142226>
2489
2490         Reviewed by Darin Adler.
2491
2492         * Scripts/webkitpy/port/ios.py:
2493         (IOSSimulatorPort.default_baseline_search_path): Switch the
2494         TestExpectations order of ios-simulator-wk2 from this:
2495           ios-simulator-wk2, wk2, ios-simulator
2496         To this:
2497           ios-simulator-wk2, ios-simualtor, wk2
2498
2499 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
2500
2501         [Win] Provide tiered logging from MSBuild -- Errors on top, Warnings after
2502         https://bugs.webkit.org/show_bug.cgi?id=142370
2503
2504         Reviewed by Dean Jackson.
2505
2506         * Scripts/webkitdirs.pm:
2507         (buildVisualStudioProject): Tell MSBuild to output log files to two separate
2508         logs, one for warnings, the other for errors.
2509         * win/AssembleBuildLogs/AssembleLogs.cmd: Combine the error and warning logs
2510         into the standard BuildOutput.htm document.
2511
2512 2015-03-05  David Kilzer  <ddkilzer@apple.com>
2513
2514         Dashboard has trouble parsing iOS test output
2515         <http://webkit.org/b/142364>
2516
2517         Reviewed by Alex Christensen.
2518
2519         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
2520         (BuildbotTestResults.prototype._parseResults.resultSummarizer):
2521         Add fallback path to build a regex using 'matchString' so that
2522         it matches anywhere in the line.  In practice, 'matchString' is
2523         a prefix for the label following the number.
2524
2525 2015-03-05  Alex Christensen  <achristensen@webkit.org>
2526
2527         Fix linker warnings in TestWebKitAPI.
2528         https://bugs.webkit.org/show_bug.cgi?id=141912
2529
2530         Reviewed by David Kilzer.
2531
2532         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2533         Do not export TearDownTestCase or SetUpTestCase symbols.
2534
2535 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
2536
2537         [Win] Unreviewed EWS fix.
2538
2539         * Scripts/webkitdirs.pm:
2540         (buildVisualStudioProject): Dial logging back to 'ErrorsOnly' to see if that makes
2541         the EWS output more usable.
2542
2543 2015-03-05  Chris Dumez  <cdumez@apple.com>
2544
2545         Regression(r173761): ASSERTION FAILED: !is8Bit() in StringImpl::characters16()
2546         https://bugs.webkit.org/show_bug.cgi?id=142350
2547
2548         Reviewed by Michael Saboff and Benjamin Poulain.
2549
2550         Add API test for WTFString::hasInfixStartingAt() to make sure it doesn't
2551         crash if the string is 8-bit but the pattern is 16-bit (and vice-versa).
2552
2553         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2554         (TestWebKitAPI::TEST):
2555
2556 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
2557
2558         [Win] Ensure build target directory exists when launching MSBuild
2559         https://bugs.webkit.org/show_bug.cgi?id=142360
2560
2561         Reviewed by Dean Jackson.
2562
2563         Create the build output directory (if it doesn't exist) before
2564         launching MSBuild so that it can immediately begin writing logs.
2565
2566         * Scripts/webkitdirs.pm:
2567         (buildVisualStudioProject):
2568
2569 2015-03-05  Chris Dumez  <cdumez@apple.com>
2570
2571         run-webkit-tests and run-perf-tests should use WebKitTestRunner by default
2572         https://bugs.webkit.org/show_bug.cgi?id=142325
2573
2574         Reviewed by Csaba Osztrogonác.
2575
2576         run-webkit-tests and run-perf-tests now use WebKitTestRunner by default.
2577         As a result, "--webkit-test-runner / -2" parameters are replaced by
2578         "--dump-render-tree / -1" so developers can run DumpRenderTree rather
2579         than WebKitTestRunner.
2580
2581         * BuildSlaveSupport/build.webkit.org-config/config.json:
2582         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2583         (RunWebKit1Tests):
2584         (RunWebKit1Tests.start):
2585         (RunWebKit1LeakTests):
2586         (RunWebKit1LeakTests.start):
2587         (RunAndUploadPerfTestsWebKit1):
2588         (RunAndUploadPerfTestsWebKit1.start):
2589         (TestFactory):
2590         (TestWebKit1LeaksFactory):
2591         (TestWebKit1LeaksFactory.__init__):
2592         (TestWebKit1Factory):
2593         (TestWebKit1AllButJSCFactory):
2594         (TestAllButJSCFactory):
2595         (BuildAndPerfTestWebKit1Factory):
2596         (BuildAndPerfTestWebKit1Factory.__init__):
2597         (BuildAndPerfTestFactory):
2598         (BuildAndPerfTestFactory.__init__):
2599         (DownloadAndPerfTestWebKit1Factory):
2600         (DownloadAndPerfTestWebKit1Factory.__init__):
2601         (DownloadAndPerfTestFactory):
2602         (DownloadAndPerfTestFactory.__init__):
2603         (RunWebKitLeakTests): Deleted.
2604         (RunWebKitLeakTests.start): Deleted.
2605         (RunWebKit2Tests): Deleted.
2606         (RunWebKit2Tests.start): Deleted.
2607         (RunAndUploadPerfTestsWebKit2): Deleted.
2608         (RunAndUploadPerfTestsWebKit2.start): Deleted.
2609         (TestLeaksFactory): Deleted.
2610         (TestLeaksFactory.__init__): Deleted.
2611         (TestWebKit2Factory): Deleted.
2612         (TestWebKit2AndJSCFactory): Deleted.
2613         (BuildAndPerfTestWebKit2Factory): Deleted.
2614         (BuildAndPerfTestWebKit2Factory.__init__): Deleted.
2615         (DownloadAndPerfTestWebKit2Factory): Deleted.
2616         (DownloadAndPerfTestWebKit2Factory.__init__): Deleted.
2617         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2618         (parse_args):
2619         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2620         (PerfTestsRunner._parse_args):
2621         * Scripts/webkitpy/port/port_testcase.py:
2622         (PortTestCase.test_build_driver):
2623
2624 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
2625
2626         [Win] Switch to MSBuild so we get more useful stdout logging in buildbot
2627         https://bugs.webkit.org/show_bug.cgi?id=140845
2628
2629         Reviewed by David Kilzer.
2630
2631         Update 'webkitdirs.pm' to locate the MSBuild used with Visual Studio 2013
2632         and generate suitable build commands to drive a full build from our
2633         existing solution files.
2634
2635         * Scripts/webkitdirs.pm:
2636         (msBuildInstallDir): Added.
2637         (determineConfigurationForVisualStudio): Revise to use MSBuild command
2638         line arguments to drive the build.
2639         (setupCygwinEnv): Warn user if MSBuild cannot be located.
2640         (buildVisualStudioProject): Revise to use MSBuild command line arguments
2641         to specify build architecture.
2642         * win/AssembleBuildLogs/AssembleLogs.cmd: MSBuild doesn't produce individual
2643         output logs, so don't attempt to consolidate them. Also: Drive-by fix: Don't
2644         bother looking for CoreUI or SafariTheme build logs.
2645
2646 2015-03-05  Csaba Osztrogonác  <ossy@webkit.org>
2647
2648         [buildbot] mastercfg_unittest.py should be runnable easily
2649         https://bugs.webkit.org/show_bug.cgi?id=142219
2650
2651         Reviewed by Chris Dumez.
2652
2653         Buildbot 0.8.6p1 runs on build.webkit org with Twisted 12.1.0, which is
2654         the last Twisted version works together with this buildbot version.
2655
2656         * Scripts/webkitpy/common/system/autoinstall.py:
2657         (AutoInstaller): Added prepend_to_search_path argument to be able
2658         to prefer autoinstalled package to system package.
2659         (AutoInstaller.__init__):
2660         (AutoInstaller._set_up_target_dir):
2661         (AutoInstaller._extract_tar): Renamed from _extract_targz, now it works with tar.bz2 too.
2662         (AutoInstaller._prepare_package):
2663         (AutoInstaller._extract_targz): Renamed to _extract_tar.
2664         * Scripts/webkitpy/thirdparty/__init__.py:
2665         (AutoinstallImportHook._install_buildbot): Autoinstall Twisted 12.1.0.
2666
2667 2015-03-05  Lukasz Bialek  <l.bialek@samsung.com>
2668
2669         [EFL][WK2] Crash when "Download Linked File" from MiniBrowser context menu is clicked
2670         https://bugs.webkit.org/show_bug.cgi?id=131162
2671
2672         Reviewed by Gyuyoung Kim.
2673
2674         * MiniBrowser/efl/main.c:
2675         (on_download_request):
2676         (on_download_finished):
2677         (on_download_failed):
2678         (window_create):
2679         Adapt download callbacks to new callback mechanism
2680
2681 2015-03-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2682
2683         Unreviewed. Fix /webkit2/WebKitWebResource/mime-type after r180927.
2684
2685         In r180927 we updated the libsoup version used by the jhbuild. In
2686         this new version the sniffer uses image/x-icon instead of
2687         image/vnd.microsoft.icon for blank.ico resource.
2688
2689         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2690         (testWebResourceMimeType):
2691
2692 2015-03-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2693
2694         [SOUP] Check TLS errors as soon as they are set in the SoupMessage
2695         https://bugs.webkit.org/show_bug.cgi?id=142244
2696
2697         Reviewed by Sergio Villar Senin.
2698
2699         Check that the SSL server doesn't process any request in case of
2700         TLS errors when the policy is set to FAIL.
2701
2702         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
2703         (testTLSErrorsPolicy):
2704         (testTLSErrorsRedirect):
2705         (testTLSErrorsHTTPAuth):
2706         (testLoadFailedWithTLSErrors):
2707         (testSubresourceLoadFailedWithTLSErrors):
2708         (httpsServerCallback):
2709
2710 2015-03-05  Pawel Forysiuk  <p.forysiuk@samsung.com>
2711
2712         [EFL] REGRESSION (r178685): ASSERTION FAILED: !parameters.mediaKeyStorageDirectory.isEmpty()
2713         https://bugs.webkit.org/show_bug.cgi?id=141154
2714
2715         Reviewed by Jer Noble.
2716
2717         Unlike GTK, EFL port enables ENABLE_ENCRYPTED_MEDIA_V2 build option by default.
2718
2719         For the sake of completeness WebKitTestRunner should specify temporary
2720         folder for MediaKeysStorageDirecory as well as IndexedDB, LocalStorage, etc.
2721
2722         Default non legacy paths are set up in ProcessPoolConfiguration constructor.
2723         They use WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation
2724         to get data storage paths. Only Mac port has an actual implementation of it.
2725         However, WebKitTestRunner overrides them in favour of unique temporary dir
2726         which is taken from libraryPathForTesting().
2727
2728         Since WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation
2729         is not implemented for EFL and GTK ports it returns an empty string.
2730         All default data folders besides MediaKeys are overridden in TestRunner
2731         code with unique temporary folders derived from DUMPRENDERTREE_TEMP
2732         env variable.
2733
2734         GTK port does not enable encrypted keys by default so
2735         WebMediaKeyStorageManager::initialize() code path is never triggered.
2736
2737         * WebKitTestRunner/TestController.cpp:
2738         (WTR::TestController::initialize): Set MediaKeysStorageDirectory for all
2739         WebKit ports.
2740
2741 2015-03-05  Csaba Osztrogonác  <ossy@webkit.org>
2742
2743         [buildbot] Add regression test to check which builder runs which tests
2744         https://bugs.webkit.org/show_bug.cgi?id=142166
2745
2746         Reviewed by Alexey Proskuryakov.
2747
2748         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2749         (BuildStepsConstructorTest.createTest):
2750         (BuildStepsTest):
2751         (BuildStepsTest.generateTests):
2752         (BuildStepsTest.createTest):
2753         (BuildStepsTest.createTest.doTest):
2754         (BuildStepsTest.test_unnecessary_expected_results):
2755
2756 2015-03-04  Commit Queue  <commit-queue@webkit.org>
2757
2758         Unreviewed, rolling out r181054.
2759         https://bugs.webkit.org/show_bug.cgi?id=142320
2760
2761         Broke the api tests (Requested by sundiamonde on #webkit).
2762
2763         Reverted changeset:
2764
2765         "Fix linker warnings in TestWebKitAPI."
2766         https://bugs.webkit.org/show_bug.cgi?id=141912
2767         http://trac.webkit.org/changeset/181054
2768
2769 2015-03-04  Alex Christensen  <achristensen@webkit.org>
2770
2771         Fix linker warnings in TestWebKitAPI.
2772         https://bugs.webkit.org/show_bug.cgi?id=141912
2773
2774         Reviewed by David Kilzer.
2775
2776         * TestWebKitAPI/Configurations/Base.xcconfig:
2777         Use GCC_SYMBOLS_PRIVATE_EXTERN like we do in WebCore.
2778
2779 2015-03-04  Alexey Proskuryakov  <ap@apple.com>
2780
2781         [Mac] Set SystemUIFontSelect in DRT and WKTR
2782         https://bugs.webkit.org/show_bug.cgi?id=142303
2783
2784         Reviewed by Myles C. Maxfield.
2785
2786         * DumpRenderTree/mac/DumpRenderTree.mm:
2787         (setDefaultsToConsistentValuesForTesting):
2788         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2789         (WTR::InjectedBundle::platformInitialize):
2790
2791 2015-03-04  Chris Dumez  <cdumez@apple.com>
2792
2793         Mac Perf bots should use WebKitTestRunner instead of DumpRenderTree
2794         https://bugs.webkit.org/show_bug.cgi?id=142314
2795         <rdar://problem/20046835>
2796
2797         Reviewed by Ryosuke Niwa.
2798
2799         Mac Perf bots should use WebKitTestRunner instead of DumpRenderTree
2800         to get WK2 code coverage.
2801
2802         * BuildSlaveSupport/build.webkit.org-config/config.json:
2803
2804 2015-03-04  Alex Christensen  <achristensen@webkit.org>
2805
2806         Move content extensions test to properly named directory.
2807         https://bugs.webkit.org/show_bug.cgi?id=142299
2808
2809         Reviewed by Tim Horton.
2810
2811         * WebKitTestRunner/mac/TestControllerMac.mm:
2812         (WTR::TestController::platformConfigureViewForTest):
2813
2814 2015-03-04  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2815
2816         W3C test importer should use filesystem instead of os.walk
2817         https://bugs.webkit.org/show_bug.cgi?id=142085
2818
2819         Reviewed by Bem Jones-Bey.
2820
2821         Added FileSystem.dirs_under to remove the use of os.walk in test importer.
2822         Added MockFileSystem.dirs_under and MockFileSystem.getsize to enable unit testing of test importer.
2823         Added unit test for FileSystem.dirs_under and MockFileSystem.dirs_under.
2824
2825         Made use of FileSystem.dirs_under within TestImporter.find_importable_tests.
2826         Added a unit test to check that test importer is now black-box testable using a Mock system.
2827
2828         * Scripts/webkitpy/common/system/filesystem.py:
2829         (FileSystem.dirs_under): Returns a list of filtered sub-directories.
2830         (FileSystem.dirs_under.filter_all):
2831         * Scripts/webkitpy/common/system/filesystem_mock.py:
2832         (MockFileSystem.dirs_under):
2833         (MockFileSystem.dirs_under.filter_all):
2834         (MockFileSystem.getsize):
2835         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
2836         (MockFileSystemTest.test_dirs_under):
2837         (MockFileSystemTest.test_dirs_under.filter_dir):
2838         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2839         (RealFileSystemTest.test_sep):
2840         (RealFileSystemTest):
2841         (RealFileSystemTest.test_dirs_under):
2842         (RealFileSystemTest.test_dirs_under.filter_this_dir):
2843         * Scripts/webkitpy/w3c/test_importer.py:
2844         (TestImporter.do_import):
2845         (TestImporter.find_importable_tests.should_keep_subdir):
2846         (TestImporter.find_importable_tests):
2847         (TestImporter.should_keep_subdir): Deleted.
2848         (TestImporter.should_skip_file): Deleted.
2849         * Scripts/webkitpy/w3c/test_importer_unittest.py:
2850         (TestImporterTest.test_import_dir_with_empty_init_py): Added test to ensure empty __init__.py are no longer empty once imported.
2851
2852 2015-03-04  Timothy Horton  <timothy_horton@apple.com>
2853
2854         [WebEditingTester] Add support for the find and replace bar
2855         https://bugs.webkit.org/show_bug.cgi?id=142247
2856
2857         Reviewed by Enrica Casucci.
2858
2859         While it's not hooked up yet in WKWebView, adding support for the
2860         find bar to WebEditingTester will help us implement that functionality.
2861
2862         * WebEditingTester/AppDelegate.h:
2863         * WebEditingTester/AppDelegate.m:
2864         (-[WebEditingAppDelegate performTextFinderAction:]):
2865         * WebEditingTester/MainMenu.xib:
2866         Receive performTextFinderAction: and forward it to the frontmost WebDocumentController.
2867
2868         * WebEditingTester/WK2WebDocumentController.m:
2869         (-[WK2WebDocumentController awakeFromNib]):
2870         (-[WK2WebDocumentController performTextFinderAction:]):
2871         (-[WK2WebDocumentController findBarView]):
2872         (-[WK2WebDocumentController setFindBarView:]):
2873         (-[WK2WebDocumentController isFindBarVisible]):
2874         (-[WK2WebDocumentController setFindBarVisible:]):
2875         (-[WK2WebDocumentController findBarViewDidChangeHeight]):
2876         (-[WK2WebDocumentController layout]):
2877         Implement performTextFinderAction: for WebKit2, and have a NSTextFinder
2878         pointing at the WKWebView (currently nothing will work, but the bar will
2879         show up). Install and uninstall the bar as needed.
2880
2881         * WebEditingTester/WebDocument.xib:
2882         Don't use a full-size content view. There's no need, and it makes find
2883         bar layout harder.
2884
2885         * WebEditingTester/WebDocumentController.h:
2886         * WebEditingTester/WebDocumentController.m:
2887         (-[WebDocumentController performTextFinderAction:]):
2888
2889 2015-03-03  Sam Weinig  <sam@webkit.org>
2890
2891         [Content Extensions] Split parsing and compiling of content extensions into their own files
2892         https://bugs.webkit.org/show_bug.cgi?id=142259
2893
2894         Reviewed by Anders Carlsson.
2895
2896         Add basic unit test for the content filter compiler.
2897
2898         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2899         * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Added.
2900         (WebCore::ContentExtensions::operator<<):
2901         (TestWebKitAPI::ContentFilterTest::SetUp):
2902         (TestWebKitAPI::TEST_F):
2903
2904 2015-03-04  Matthew Mirman  <mmirman@apple.com>
2905
2906         Cleaned up BuildAndTestFactory to not be a near duplicate of TestFactory
2907         https://bugs.webkit.org/show_bug.cgi?id=142230
2908
2909         Reviewed by Csaba Osztrogonác.
2910
2911         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2912         (TestFactory):
2913         (TestFactory.getProduct): Added
2914         (TestFactory.__init__): moved downloader to getProduct
2915         (BuildAndTestFactory):        
2916         (BuildAndTestFactory.getProduct): Added
2917         (BuildAndTestFactory.__init__): made to call TestFactory.__init__ and append steps to the end.
2918         (BuildAndTestWebKit2Factory): Deleted.  Wasn't used anywhere.
2919
2920 2015-03-04  Debarshi Ray  <debarshir@gnome.org>
2921
2922         [GTK] WebView should hold a reference on WebContext because non-default contexts are a reality
2923         https://bugs.webkit.org/show_bug.cgi?id=142225
2924
2925         Reviewed by Carlos Garcia Campos.
2926
2927         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2928         (testWebViewWebContextLifetime):
2929         (beforeAll):
2930
2931 2015-03-03  David Kilzer  <ddkilzer@apple.com>
2932
2933         [iOS] Crash logs can't be found on ios-simulator because WebKitTestRunner returns the wrong process name
2934         <http://webkit.org/b/142243>
2935
2936         Reviewed by Alexey Proskuryakov.
2937
2938         * WebKitTestRunner/TestController.cpp:
2939         (WTR::TestController::webProcessName):
2940         (WTR::TestController::networkProcessName):
2941         - Return the same process name on iOS and Mac because they both
2942           use the same process name for local engineering builds.
2943
2944 2015-03-03  David Kilzer  <ddkilzer@apple.com>
2945
2946         check-webkit-style: Add exception for FrameworkSoftLink.h header order
2947         <http://webkit.org/b/141872>
2948
2949         Reviewed by Alex Christensen.
2950
2951         * Scripts/webkitpy/style/checkers/cpp.py: Remove unneeded
2952         semi-colons in various places and fix whitespace.
2953         (_IncludeState): Add _SOFT_LINK_HEADER and _SOFT_LINK_SECTION
2954         constants.
2955         (_IncludeState.__init__): Add self._visited_soft_link_section
2956         boolean state variable.
2957         (_IncludeState.visited_soft_link_section): Getter for
2958         self._visited_soft_link_section.
2959         (_IncludeState.check_next_include_order): Update state machine
2960         for soft-link headers.  Add check that soft-link headers always
2961         appear last.
2962         (_classify_include): Add check for soft-link header type.
2963         (check_include_line): Return early if there is a soft-link
2964         header error.
2965
2966         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2967         (OrderOfIncludesTest.test_public_primary_header): Add tests for
2968         including soft-link headers.
2969         (OrderOfIncludesTest.test_classify_include): Add test for
2970         _SOFT_LINK_HEADER type.
2971
2972 2015-03-03  Alexey Proskuryakov  <ap@apple.com>
2973
2974         build.webkit.org/dashboard: Don't repeatedly handle each test type
2975         https://bugs.webkit.org/show_bug.cgi?id=142211
2976
2977         Reviewed by Tim Horton and Matt Hanson.
2978
2979         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2980         (Buildbot.prototype.javascriptTestResultsURLForIteration): Deleted.
2981         (Buildbot.prototype.apiTestResultsURLForIteration): Deleted.
2982         (Buildbot.prototype.platformAPITestResultsURLForIteration): Deleted.
2983         (Buildbot.prototype.webkitpyTestResultsURLForIteration): Deleted.
2984         (Buildbot.prototype.webkitperlTestResultsURLForIteration): Deleted.
2985         (Buildbot.prototype.bindingsTestResultsURLForIteration): Deleted.
2986         Removed functions that build a link to test step results. The buildbot provides
2987         these links in JSON.
2988
2989         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2990         (BuildbotIteration): Put failing tests into an array, instead of named variables.
2991         (BuildbotIteration.ProductiveSteps): Removed step names that are not used on build.webkit.org.
2992         We can easily add them to the map as needed.
2993         (BuildbotIteration.TestSteps): Added a list of test steps to be displayed by test queues.
2994         (BuildbotIteration.prototype._parseData): Moved code for parsing step results away
2995         to BuildbotTestResults class. We used to parse here, build an intermediate data structure,
2996         and then build a BuildbotTestResults object, which was strange.
2997         (BuildbotIteration.prototype.loadLayoutTestResults): Ditto.
2998
2999         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3000         Corrected an unrelated assertion that was buggy, and kept firing.
3001
3002         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
3003         (BuildbotTestResults):
3004         (BuildbotTestResults.prototype._parseResults.resultSummarizer):
3005         (BuildbotTestResults.prototype._parseResults):
3006         (BuildbotTestResults.prototype.addFullLayoutTestResults):
3007         Moved the code for parsing JSON results for a single step here.
3008
3009         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3010         (BuildbotTesterQueueView.prototype._testStepFailureDescription):
3011         (BuildbotTesterQueueView.prototype._testStepFailureDescriptionWithCount):
3012         (BuildbotTesterQueueView.prototype._presentPopoverForGenericTestFailures):
3013         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Deleted.
3014         (BuildbotTesterQueueView.prototype.update): Deleted.
3015         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds): Deleted.
3016         Updated for the new data structures. One behavior change is that we now display individual
3017         counts when multiple test kinds fail, e.g. "1 javascript test failure, 83+ layout
3018         test failures, 3 platform api test failures".
3019
3020 2015-03-03  Matthew Mirman  <mmirman@apple.com>
3021
3022         JSC tests should not be repeated twice for each branch builder, and should if possible have their own queue.
3023         https://bugs.webkit.org/show_bug.cgi?id=142094
3024
3025         Reviewed by Csaba Osztrogonác.
3026
3027         * BuildSlaveSupport/build.webkit.org-config/config.json: Added bots 155 and 157
3028         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3029         (TestFactory):
3030         (TestFactory.__init__): Made running of JSC tests conditional.
3031         (TestAllButJSCFactory):
3032         (TestJSCFactory): Added.
3033         (TestJSCFactory.__init__):
3034         (TestWebKit2AndJSCFactory): Added factory to not run JSC tests on WebKit2.
3035
3036 2015-03-03  David Kilzer  <ddkilzer@apple.com>
3037
3038         `build-webkit --help` is wrong about how to build for the iOS simulator
3039         <http://webkit.org/b/142223>
3040
3041         Reviewed by Csaba Osztrogonác.
3042
3043         * Scripts/build-webkit: Fix help.
3044
3045 2015-03-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3046
3047         Unreviewed. Bump libsoup version to 2.49.91.1 to fix 32 bit build.
3048
3049         * gtk/jhbuild.modules:
3050
3051 2015-03-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3052
3053         [SOUP] Synchronous XMLHttpRequests can time out when we reach the max connections limit
3054         https://bugs.webkit.org/show_bug.cgi?id=141508
3055
3056         Reviewed by Sergio Villar Senin.
3057
3058         Add a unit test to check that synchronous XHRs load even if the
3059         maximum connection limits are reached.
3060
3061         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
3062         (testWebViewSyncRequestOnMaxConns):
3063         (serverCallback):
3064         (beforeAll):
3065         * gtk/jhbuild.modules: Bump libsoup version to 2.49.91.
3066
3067 2015-03-02  Alexey Proskuryakov  <ap@apple.com>
3068
3069         Update the name of ASan build step.
3070
3071         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3072
3073 2015-03-02  Jer Noble  <jer.noble@apple.com>
3074
3075         [WK1][WK2][Mac] Fullscreen animation is incorrect when page is scaled.
3076         https://bugs.webkit.org/show_bug.cgi?id=142121
3077
3078         Reviewed by Simon Fraser.
3079
3080         Add a test which changes the WebView's page scale, then enters fullscreen mode, and verifies
3081         that the initial and final screen rects for the web content are as expected.
3082
3083         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3084         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.html: Added.
3085         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm: Added.
3086         (-[FullscreenStateDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
3087         (runJavaScriptAlert):
3088         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
3089         (TestWebKitAPI::FullscreenZoomInitialFrame::teardownView):
3090         (TestWebKitAPI::FullscreenZoomInitialFrame::setPageScale):
3091         (TestWebKitAPI::FullscreenZoomInitialFrame::sendMouseDownEvent):
3092         (TestWebKitAPI::FullscreenZoomInitialFrame::runTest):
3093         (TestWebKitAPI::TEST_F):
3094
3095 2015-03-01  David Kilzer  <ddkilzer@apple.com>
3096
3097         LayoutTestRealy: Prepend __XPC_ to the key, not the value!
3098
3099         Follow-up fix for:
3100
3101         LayoutTestRelay: App environment variables not set for --guard-malloc or --leaks
3102         <http://webkit.org/b/142145>
3103
3104         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3105         (-[LTRelayController _environmentVariables]): Fix think-o.
3106
3107 2015-03-01  David Kilzer  <ddkilzer@apple.com>
3108
3109         LayoutTestRelay: App environment variables not set for --guard-malloc or --leaks
3110         <http://webkit.org/b/142145>
3111
3112         Reviewed by Simon Fraser.
3113
3114         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3115         (-[LTRelayController _environmentVariables]): Add.
3116         (-[LTRelayController launchApp]): Use -_environmentVariables.
3117
3118 2015-02-28  David Kilzer  <ddkilzer@apple.com>
3119
3120         [iOS] Stop running webkit-build-directory on every layout test
3121
3122         This was originally fixed by David Farler for Bug 135409 in
3123         r172602.
3124
3125         * Scripts/webkitpy/port/ios.py:
3126         (IOSSimulatorPort.relay_path): Mark as @memoized so it doesn't
3127         run webkit-build-directory every time it's called.
3128
3129 2015-02-28  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3130
3131         W3C importer should use filesystem instead of shutil/host
3132         https://bugs.webkit.org/show_bug.cgi?id=142012
3133
3134         Reviewed by Bem Jones-Bey.
3135
3136         Removed direct use of python shutil and os, except for os.walk which will require its own fix.
3137
3138         * Scripts/webkitpy/w3c/test_importer.py:
3139         (main):
3140         (TestImporter.do_import):
3141         (TestImporter.find_importable_tests):
3142         (TestImporter.import_tests):
3143         (TestImporter.remove_deleted_files):
3144         (TestImporter.write_import_log):
3145
3146 2015-02-28  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3147
3148         W3C test importer should use filesystem to read and write files
3149         https://bugs.webkit.org/show_bug.cgi?id=142084
3150
3151         Reviewed by Bem Jones-Bey.
3152
3153         Use of FileSystem.write_binary_file, read_text_file and write_text_file in lieu of open().
3154
3155         * Scripts/webkitpy/w3c/test_importer.py:
3156         (TestImporter.import_tests):
3157         (TestImporter.remove_deleted_files):
3158         (TestImporter.write_import_log):
3159
3160 2015-02-27  Sam Weinig  <sam@webkit.org>
3161
3162         Add WebKit2 SPI to create a DOM File object
3163         https://bugs.webkit.org/show_bug.cgi?id=142109
3164
3165         Reviewed by Tim Horton.
3166
3167         Add a test for WKBundleFileHandleRef.
3168
3169         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3170         * TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle.cpp: Added.
3171         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
3172         (TestWebKitAPI::didFinishLoadForFrame):
3173         (TestWebKitAPI::TEST):
3174         * TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle_Bundle.cpp: Added.
3175         (TestWebKitAPI::WKBundleFileHandleTest::WKBundleFileHandleTest):
3176         * TestWebKitAPI/Tests/WebKit2/bundle-file.html: Added.
3177
3178 2015-02-27  Michael Saboff  <msaboff@apple.com>
3179
3180         Add ability for run-jsc-benchmarks to set library path from test binary when run on a build bot
3181         https://bugs.webkit.org/show_bug.cgi?id=142112
3182
3183         Reviewed by Filip Pizlo.
3184
3185         Added check for VMs in the form of <someDir>/{DumpRenderTree,webkitTestRunner,jsc} and use
3186         <someDir> as the library path.
3187
3188         * Scripts/run-jsc-benchmarks:
3189
3190 2015-02-27  Alex Christensen  <achristensen@webkit.org>
3191
3192         [WinCairo] Unreviewed build fix.
3193
3194         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
3195         Use TestWebKitAPIPrefix.h like in TestWebKitAPICommon.props.
3196
3197 2015-02-27  Anders Carlsson  <andersca@apple.com>
3198
3199         Add infrastructure for handling website data in the network process
3200         https://bugs.webkit.org/show_bug.cgi?id=142092
3201
3202         Reviewed by Andreas Kling.
3203
3204         Add a menu item that will fetch all website data, delete the returned data records, and
3205         fetch all website data again so we can confirm that it's all empty.
3206
3207         * MiniBrowser/mac/WK2BrowserWindowController.m:
3208         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
3209
3210 2015-02-26  Brent Fulgham  <bfulgham@apple.com>
3211
3212         [Win] Remove remaining SafariTheme cruft
3213         https://bugs.webkit.org/show_bug.cgi?id=142075
3214
3215         Reviewed by Anders Carlsson.
3216
3217         Remove reference to SafariTheme-switching preference.
3218
3219         * DumpRenderTree/win/DumpRenderTree.cpp:
3220         (resetWebPreferencesToConsistentValues):
3221         (prepareConsistentTestingEnvironment):
3222
3223 2015-02-26  Doug Russell  <d_russell@apple.com>
3224
3225         AX: Expose caret browsing preference to accessibility API
3226         https://bugs.webkit.org/show_bug.cgi?id=141862
3227
3228         Reviewed by Chris Fleizach.
3229
3230         Exposing the caret browsing setting on WebCore::Frame via the accessibility API would allow assistive tech apps to enable it contextually (for example, when the assistive tech app is running).
3231         Enabling caret browsing when assistive tech apps are running greatly improves the reliability of keyboard navigation on the web. Most especially in cases where selection would be disrupted by focus events.
3232
3233         * DumpRenderTree/AccessibilityUIElement.cpp:
3234         (setBoolAttributeValueCallback):
3235         (selectedTextMarkerRangeCallback):
3236         (resetSelectedTextMarkerRangeCallback):
3237         (AccessibilityUIElement::setBoolAttributeValue):
3238         (AccessibilityUIElement::selectedTextMarkerRange):
3239         (AccessibilityUIElement::resetSelectedTextMarkerRange):
3240         (AccessibilityUIElement::getJSClass):
3241         * DumpRenderTree/AccessibilityUIElement.h:
3242         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3243         (AccessibilityUIElement::setBoolAttributeValue):
3244         (AccessibilityUIElement::selectedTextMarkerRange):
3245         (AccessibilityUIElement::resetSelectedTextMarkerRange):
3246         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3247         (WTR::AccessibilityUIElement::selectedTextMarkerRange):
3248         (WTR::AccessibilityUIElement::resetSelectedTextMarkerRange):
3249         (WTR::AccessibilityUIElement::setBoolAttributeValue):
3250         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3251         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3252         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3253         (WTR::AccessibilityUIElement::setBoolAttributeValue):
3254         (WTR::AccessibilityUIElement::selectedTextMarkerRange):
3255         (WTR::AccessibilityUIElement::resetSelectedTextMarkerRange):
3256
3257 2015-02-26  Brent Fulgham  <bfulgham@apple.com>
3258
3259         [Win] Remove WebKitExportGenerator project (and related)
3260         https://bugs.webkit.org/show_bug.cgi?id=142035
3261
3262         Reviewed by Dean Jackson.
3263
3264         * win/AssembleBuildLogs/AssembleLogs.cmd: Don't look for a
3265         build log from WebKitExportGenerator.
3266
3267 2015-02-26  Csaba Osztrogonác  <ossy@webkit.org>
3268
3269         [EFL] Bump EFL version to 1.13.0
3270         https://bugs.webkit.org/show_bug.cgi?id=141708
3271
3272         Reviewed by Gyuyoung Kim.
3273
3274         * efl/jhbuild.modules:
3275
3276 2015-02-26  Sam Weinig  <sam@webkit.org>
3277
3278         Check in missing WebEditingTester.xcconfig file.
3279
3280         * WebEditingTester/Configurations/WebEditingTester.xcconfig: Added.
3281
3282 2015-02-26  Csaba Osztrogonác  <ossy@webkit.org>
3283
3284         [webkitpy] Remove skipped file related crufts
3285         https://bugs.webkit.org/show_bug.cgi?id=142046
3286
3287         Reviewed by Ryosuke Niwa.
3288
3289         * Scripts/webkitpy/port/base.py:
3290         (Port.skipped_layout_tests):
3291         (Port._tests_from_skipped_file_contents): Deleted.
3292         (Port): Deleted.
3293         (Port._expectations_from_skipped_files): Deleted.
3294         * Scripts/webkitpy/port/mac_unittest.py:
3295         (MacTest.test_default_timeout_ms):
3296         (MacTest): Deleted.
3297         (test_tests_from_skipped_file_contents): Deleted.
3298
3299 2015-02-26  Brent Fulgham  <bfulgham@apple.com>
3300
3301         [Win] Unreviewed WinCairo build fix after r180653.
3302
3303         TestWebKitAPI should know about proper WEBCORE_EXPORT definitions.
3304
3305         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3306         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
3307         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
3308         * TestWebKitAPI/win/TestWebKitAPIPrefix.cpp: Added.
3309         * TestWebKitAPI/win/TestWebKitAPIPrefix.h: Added.
3310
3311 2015-02-25  Brent Fulgham  <bfulgham@apple.com>
3312
3313         [Win] Use WEBCORE_EXPORT instead of Definition file
3314         https://bugs.webkit.org/show_bug.cgi?id=141734
3315
3316         Reviewed by Alex Christensen.
3317
3318         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
3319         Use a precompiled header so we can define our export macros properly.
3320         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj.filters:
3321         Visual studio automatic update stuff.
3322         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
3323         Set up Precompiled Header use for project..
3324         * DumpRenderTree/win/DumpRenderTreePrefix.cpp: Added.
3325         * DumpRenderTree/DumpRenderTreePrefix.h: Update with proper export
3326         declarations for building DumpRenderTree as a client of
3327         WebCore/WebKit.
3328
3329 2015-02-25  Mark Lam  <mark.lam@apple.com>
3330
3331         ASan does not like JSC::MachineThreads::tryCopyOtherThreadStack.
3332         <https://webkit.org/b/141672>
3333
3334         Reviewed by Alexey Proskuryakov.
3335
3336         ASan does not like the fact that we memcpy the stack for GC scans.  So,
3337         we're working around this by using our own memcpy (asanUnsafeMemcpy)
3338         implementation that we can tell ASan to ignore.
3339
3340         Also removed the previous added directive to ignore *tryCopyOtherThreadStack*
3341         which isn't effective for working around this issue. 
3342
3343         * asan/webkit-asan-ignore.txt:
3344
3345 2015-02-25  Benjamin Poulain  <bpoulain@apple.com>
3346
3347         CodeBlock crashes when dumping op_push_name_scope
3348         https://bugs.webkit.org/show_bug.cgi?id=141953
3349
3350         Reviewed by Filip Pizlo.
3351
3352         * Scripts/run-jsc-stress-tests:
3353
3354 2015-02-25  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3355
3356         W3C test importer should use argparse instead of optparse
3357         https://bugs.webkit.org/show_bug.cgi?id=142013
3358
3359         Reviewed by Bem Jones-Bey.
3360
3361         * Scripts/webkitpy/w3c/test_importer.py:
3362         (main): Updating according argparse.
3363         (parse_args): Moving from optparse to argparse.
3364
3365 2015-02-25  Brady Eidson  <beidson@apple.com>
3366
3367         Get rid of TestInvocation::pathOrURL
3368         https://bugs.webkit.org/show_bug.cgi?id=142021
3369
3370         Reviewed by Tim Horton.
3371
3372         The pathOrURL string is a relative path used as an argument to WebKitTestRunner,
3373         but most code that uses it expected an absolute path.
3374
3375         This gets rid of the member and replaces all uses with a more descriptive "urlContains" method.
3376
3377         * WebKitTestRunner/TestController.cpp:
3378         (WTR::TestController::updateWebViewSizeForTest):
3379         (WTR::TestController::updateWindowScaleForTest):
3380         (WTR::shouldUseFixedLayout):
3381         (WTR::TestController::updateLayoutTypeForTest):
3382
3383         * WebKitTestRunner/TestInvocation.cpp:
3384         (WTR::TestInvocation::TestInvocation):
3385         (WTR::TestInvocation::urlContains):
3386         (WTR::TestInvocation::shouldLogFrameLoadDelegates):
3387         (WTR::TestInvocation::shouldLogHistoryClientCallbacks):
3388         (WTR::TestInvocation::invoke):
3389         (WTR::shouldLogFrameLoadDelegates): Deleted.
3390         (WTR::shouldLogHistoryClientCallbacks): Deleted.
3391         * WebKitTestRunner/TestInvocation.h:
3392         (WTR::TestInvocation::pathOrURL): Deleted.
3393
3394         * WebKitTestRunner/ios/TestControllerIOS.mm:
3395         (WTR::shouldMakeViewportFlexible):
3396         (WTR::TestController::platformConfigureViewForTest):
3397
3398         * WebKitTestRunner/mac/TestControllerMac.mm:
3399         (WTR::shouldUseThreadedScrolling):
3400         (WTR::TestController::platformConfigureViewForTest):
3401
3402 2015-02-25  Brady Eidson  <beidson@apple.com>
3403
3404         Layout test support for user content filters
3405         https://bugs.webkit.org/show_bug.cgi?id=142018
3406
3407         Reviewed by Tim Horton.
3408
3409         * WebKitTestRunner/TestController.cpp:
3410         (WTR::TestController::resetStateToConsistentValues): Clear all user content filters between tests.
3411
3412         * WebKitTestRunner/mac/TestControllerMac.mm:
3413         (WTR::TestController::platformConfigureViewForTest): For all tests with usercontentfilter/ in their path try to load a matching .json
3414           file before loading the test itself.
3415
3416 2015-02-24  Sam Weinig  <sam@webkit.org>
3417
3418         Convert WebEditingTester to use xcconfig files
3419         https://bugs.webkit.org/show_bug.cgi?id=141879
3420
3421         Reviewed by Darin Adler.
3422
3423         Add xcconfig files to WebEditingTester based on the ones used by MiniBrowser.
3424
3425         * WebEditingTester/Configurations: Added.
3426         * WebEditingTester/Configurations/Base.xcconfig: Added.
3427         * WebEditingTester/Configurations/DebugRelease.xcconfig: Added.
3428         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
3429
3430 2015-02-24  Andy Estes  <aestes@apple.com>
3431
3432         Teach MiniBrowser how to disable per-window web processes
3433         https://bugs.webkit.org/show_bug.cgi?id=141988
3434
3435         Reviewed by Darin Adler.
3436
3437         * MiniBrowser/mac/AppDelegate.m:
3438         (defaultConfiguration): Created a _WKProcessPoolConfiguration with maximumProcessCount == 1 if per-window web processes are disabled.
3439         * MiniBrowser/mac/SettingsController.h:
3440         * MiniBrowser/mac/SettingsController.m:
3441         (-[SettingsController _populateMenu]): Added a new Settings menu item.
3442         (-[SettingsController validateMenuItem:]): Validated the new Settings menu item.
3443         (-[SettingsController togglePerWindowWebProcessesDisabled:]): Displayed an alert informing the user that MiniBrowser must be restarted for the setting to take effect.
3444         (-[SettingsController perWindowWebProcessesDisabled]): Returned the value from user defaults.
3445
3446 2015-02-24  Alexey Proskuryakov  <ap@apple.com>
3447
3448         Bot watcher's dashboard sometimes hits an assertion: data.num_missing === this.layoutTestResults.testsWithMissingResults.length
3449         https://bugs.webkit.org/show_bug.cgi?id=141889
3450
3451         Reviewed by Darin Adler.
3452
3453         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3454
3455 2015-02-24  Yusuke Suzuki  <utatane.tea@gmail.com>
3456
3457         REGRESSION(r179429): Can't type comments in Facebook
3458         https://bugs.webkit.org/show_bug.cgi?id=141859
3459
3460         Reviewed by Brent Fulgham.
3461
3462         Drop javaScriptExperimentsEnabled and specify JavaScriptRuntimeFlagsAllEnabled as KJavaScriptRuntimeFlags.
3463
3464         * DumpRenderTree/mac/DumpRenderTree.mm:
3465         (resetWebPreferencesToConsistentValues):
3466         * DumpRenderTree/win/DumpRenderTree.cpp:
3467         (resetWebPreferencesToConsistentValues):
3468         * WebKitTestRunner/TestController.cpp:
3469         (WTR::TestController::resetPreferencesToConsistentValues):
3470
3471 2015-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3472
3473         Crash loading local file with WebPageProxy::loadAlternateHTMLString
3474         https://bugs.webkit.org/show_bug.cgi?id=141867
3475
3476         Reviewed by Anders Carlsson.
3477
3478         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
3479         (TestWebKitAPI::loadAlternateHTMLString): Split most of this test into a function so it can
3480         be shared with the new test.
3481         (TestWebKitAPI::TEST): Add a cross-platform test for this crash.
3482         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp: Add a GTK+ test for this crash.
3483         (testLoadAlternateHTMLForLocalPage):
3484         (beforeAll):
3485
3486 2015-02-24  David Kilzer  <ddkilzer@apple.com>
3487
3488         [iOS] Implement WTR::activateFonts() to fix missing fonts in WebKit2 test runs
3489         <http://webkit.org/b/141900>
3490
3491         Reviewed by Myles C. Maxfield.
3492
3493         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
3494         (OTHER_LDFLAGS_BASE): Link to CoreText.framework.
3495         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm: Rename from Tools/WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm.
3496         - Rename to share code with iOS.
3497         - Add USE(APPKIT) around AppKit-specific headers and code.
3498         - Fix a check-webkit-style warning.
3499         * WebKitTestRunner/InjectedBundle/ios/ActivateFontsIOS.mm: Remove.
3500         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3501         - Rename mac/ActivateFonts.mm to cocoa/ActivateFontsCocoa.mm.
3502         - Remove ios/ActivateFontsIOS.mm.
3503         - Fix InjectedBundle/cocoa group to represent the directory on
3504           disk.  Includes a change to InjectedBundlePageCocoa.mm.
3505
3506 2015-02-23  Commit Queue  <commit-queue@webkit.org>
3507
3508         Unreviewed, rolling out r180547 and r180550.
3509         https://bugs.webkit.org/show_bug.cgi?id=141957
3510
3511         Broke 10 Windows tests. (Requested by bfulgham_ on #webkit).
3512
3513         Reverted changesets:
3514
3515         "REGRESSION(r179429): Can't type comments in Facebook"
3516         https://bugs.webkit.org/show_bug.cgi?id=141859
3517         http://trac.webkit.org/changeset/180547
3518
3519         "Constructor returning null should construct an object instead
3520         of null"
3521         https://bugs.webkit.org/show_bug.cgi?id=141640
3522         http://trac.webkit.org/changeset/180550
3523
3524 2015-02-23  Yusuke Suzuki  <utatane.tea@gmail.com>
3525
3526         REGRESSION(r179429): Can't type comments in Facebook
3527         https://bugs.webkit.org/show_bug.cgi?id=141859
3528
3529         Reviewed by Geoffrey Garen.
3530
3531         Drop javaScriptExperimentsEnabled and specify JavaScriptRuntimeFlagsAllEnabled as KJavaScriptRuntimeFlags.
3532
3533         * DumpRenderTree/mac/DumpRenderTree.mm:
3534         (resetWebPreferencesToConsistentValues):
3535         * WebKitTestRunner/TestController.cpp:
3536         (WTR::TestController::resetPreferencesToConsistentValues):
3537
3538 2015-02-23  KwangHyuk Kim  <hyuki.kim@samsung.com>
3539
3540         [EFL] fix eo errors
3541         https://bugs.webkit.org/show_bug.cgi?id=141909
3542
3543         Reviewed by Gyuyoung Kim.
3544
3545         Fix eo errors that occur whenever minibrowser is launched.
3546         - elm_obj_entry_text_style_user_push can only be applied for elm_entry
3547         - elm_obj_win_resize_object_add's first parameter should be elm_win
3548
3549         * MiniBrowser/efl/main.c:
3550         (window_create):
3551
3552 2015-02-23  Ryosuke Niwa  <rniwa@webkit.org>
3553
3554         Unreviewed build fix after r180535. Removed the test case that wasn't compiling.
3555
3556         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3557         (TestWebKitAPI::TEST):
3558
3559 2015-02-23  Brent Fulgham  <bfulgham@apple.com>
3560
3561         WTF::WeakPtr should rename 'forgot' to 'clear' and support nullptr assignment
3562         https://bugs.webkit.org/show_bug.cgi?id=141935
3563
3564         Reviewed by Myles C. Maxfield.
3565
3566         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3567         (TestWebKitAPI::TEST): Updated for 'clear' method rename, and added a few
3568         tests for assigning from nullptr.
3569
3570 2015-02-23  Brent Fulgham  <bfulgham@apple.com>
3571
3572         WTF::WeakPtr should have a 'forget' method.
3573         https://bugs.webkit.org/show_bug.cgi?id=141923
3574
3575         Reviewed by Myles C. Maxfield.
3576
3577         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3578         (TestWebKitAPI::TEST): Added 'Forget' tests case.
3579
3580 2015-02-23  Alexey Proskuryakov  <ap@apple.com>
3581
3582         build.webkit.org/dashboard CrashOnly queues should not show two green bubbles
3583         https://bugs.webkit.org/show_bug.cgi?id=141920
3584
3585         Reviewed by Tim Horton.
3586
3587         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3588         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
3589         Do the same thing as we do for regular green bubbles.
3590
3591 2015-02-23  Alexey Proskuryakov  <ap@apple.com>
3592
3593         Bot watcher's dashboard doesn't show a popover for commit history when all commits were to another branch
3594         https://bugs.webkit.org/show_bug.cgi?id=141925
3595
3596         Reviewed by Tim Horton.
3597
3598         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3599         (BuildbotQueueView.prototype._presentPopoverForRevisionRange):
3600
3601 2015-02-23  Anders Carlsson  <andersca@apple.com>
3602
3603         Add API for fetching website data records to _WKWebsiteDataStore
3604         https://bugs.webkit.org/show_bug.cgi?id=141926
3605
3606         Reviewed by Beth Dakin.
3607
3608         * MiniBrowser/mac/MainMenu.xib:
3609         * MiniBrowser/mac/WK2BrowserWindowController.m:
3610         (-[WK2BrowserWindowController fetchWebsiteData:]):
3611         Add menu item to fetch and dump website data.
3612
3613 2015-02-23  David Kilzer  <ddkilzer@apple.com>
3614
3615         [iOS] run-webkit-tests --leaks is broken because IOSSimulatorPort has no is_snowleopard attribute
3616         <http://webkit.org/b/141884>
3617
3618         Reviewed by Alexey Proskuryakov.
3619
3620         * Scripts/webkitpy/port/leakdetector.py:
3621         (LeakDetector._callstacks_to_exclude_from_leaks): Remove
3622         snowleopard, lion and older leaks.  Add known leak for
3623         mavericks, but check Port.operating_system before calling
3624         Port.is_mavericks.
3625         * Scripts/webkitpy/port/mac.py:
3626         (MacPort.is_snowleopard): Delete.
3627         (MacPort.is_lion): Delete.
3628         (MacPort.is_mavericks): Add.
3629
3630 2015-02-23  Alexey Proskuryakov  <ap@apple.com>
3631
3632         build.webkit.org/dashboard should filter out commits to other branches
3633         https://bugs.webkit.org/show_bug.cgi?id=140362
3634
3635         Reviewed by Tim Horton.
3636
3637         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3638         (BuildbotQueue):
3639         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3640         (BuildbotQueueView.prototype._presentPopoverForPendingCommits):
3641         (BuildbotQueueView.prototype._presentPopoverForRevisionRange):
3642         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration):
3643         (BuildbotQueueView.prototype.revisionContentForIteration):
3644         (BuildbotQueueView.prototype._appendPendingRevisionCount): Deleted.
3645         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Deleted.
3646         (BuildbotQueueView.prototype._revisionPopoverContentForIteration): Deleted.
3647         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3648         (Trac.prototype.get oldestRecordedRevisionNumber):
3649         (Trac.prototype.commitsOnBranch):
3650         (Trac.prototype._xmlTimelineURL):
3651         (Trac.prototype._convertCommitInfoElementToObject):
3652         (Trac.prototype._update):
3653         (Trac.prototype.startPeriodicUpdates):
3654         (Trac.prototype.loadMoreHistoricalData):
3655         (Trac.prototype.update): Deleted.
3656
3657 2015-02-21  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3658
3659         Tests don't work on some bots: Failed to stop wptwk
3660         https://bugs.webkit.org/show_bug.cgi?id=141235
3661
3662         Reviewed by Ryosuke Niwa.
3663
3664         Logging of server subprocesses in launcher script.
3665         Killing of server subprocesses when stopping/before starting.
3666         Removed empty __init.py__ file creation as importer now ensures these files cannot be empty anymore.
3667
3668         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
3669         (main): Removed empty __init.py__ file creation as importer now ensures these files cannot be empty anymore. Added logging in a file of server subprocesses to clean them in case of abnormal shutdown. 
3670         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3671         (WebPlatformTestServer.__init__):
3672         (WebPlatformTestServer._stop_running_subservers): Kill server subprocesses based on file created by wpt launcher.
3673         (WebPlatformTestServer):
3674         (WebPlatformTestServer.stop): Overriden to ensure killing subprocesses in case of orphaned process.
3675         (WebPlatformTestServer._stop_running_server): Killing of wpt launcher process after regular shutdown. 
3676         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
3677         (TestWebPlatformTestServer.test_server_closes_previously_spawned_instance): Reworked the test to call start/stop with an existing pid file.
3678         (TestWebPlatformTestServer.test_import_web_platform_test_modules): No change.
3679         (TestWebPlatformTestServer):
3680         (TestWebPlatformTestServer.test_corrupted_subserver_files): Checked that server subprocess cleaning does not throw in case of bad server pid file.
3681
3682 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
3683
3684         [WebEditingTester] Allow dropping HTML files on the app
3685         https://bugs.webkit.org/show_bug.cgi?id=141834
3686
3687         Reviewed by Simon Fraser.
3688
3689         * WebEditingTester/AppDelegate.m:
3690         (-[WebEditingAppDelegate openDocument:]):
3691         (-[WebEditingAppDelegate application:openFile:]):
3692         Implement application:openFile:, factoring file loading code out of openDocument.
3693
3694         * WebEditingTester/Info.plist:
3695         Register as an editor for HTML files.
3696
3697         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
3698         Enrica is not an organization.
3699
3700 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
3701
3702         [WebEditingTester] Expand "WK" to "WebKit" in a few places
3703         https://bugs.webkit.org/show_bug.cgi?id=141833
3704
3705         Reviewed by Anders Carlsson.
3706
3707         * WebEditingTester/AppDelegate.h:
3708         * WebEditingTester/AppDelegate.m:
3709         (-[WebEditingAppDelegate newEditor:]):
3710         (-[WebEditingAppDelegate toggleUseWebKit2ByDefault:]):
3711         (-[WebEditingAppDelegate validateMenuItem:]):
3712         (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]):
3713         (-[WebEditingAppDelegate applicationDidFinishLaunching:]): Deleted.
3714         (-[WebEditingAppDelegate applicationWillTerminate:]): Deleted.
3715         (-[WebEditingAppDelegate showOperations:]): Deleted.
3716         * WebEditingTester/MainMenu.xib:
3717         The WK abbreviation is unnaturally grating in menu items for some reason.
3718
3719 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
3720
3721         [WebEditingTester] Add a custom protocol for loading canned content
3722         https://bugs.webkit.org/show_bug.cgi?id=141830
3723
3724         Reviewed by Enrica Casucci.
3725
3726         Add a canned:// protocol handler, which can be used to emulate behaviors
3727         in WebKit client apps (like Mail) that use custom protocol handlers,
3728         which can have important effects on editing (mostly, the URLs are only
3729         valid inside of the client application, but not when copied/dragged out).
3730
3731         For now, we only support two canned files:
3732
3733             canned://dice is a PNG of dice (stolen from LayoutTests/)
3734             canned://text is the string "canned text" served as text/html
3735
3736         In the future we could support things like very large (generated) files,
3737         progressive loading, etc. to further simulate conditions in other apps.
3738
3739         * WebEditingTester/AppDelegate.m:
3740         (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
3741         Register the protocol with CFNetwork, and the scheme with WebKit2.
3742
3743         * WebEditingTester/Canned Content/dice.png: Added.
3744         * WebEditingTester/CannedContent.h: Added.
3745         * WebEditingTester/CannedContent.m: Added.
3746         (-[CannedContent initWithRequest:cachedResponse:client:]):
3747         (+[CannedContent canonicalRequestForRequest:]):
3748         (+[CannedContent canInitWithRequest:]):
3749         We only want to handle canned:// URLs.
3750
3751         (-[CannedContent startLoading]):
3752         For now, immediately load the two files we know about.
3753         Otherwise, immediately fail the load.
3754
3755         (-[CannedContent stopLoading]):
3756         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
3757
3758 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
3759
3760         [WebEditingTester] Implement an open panel
3761         https://bugs.webkit.org/show_bug.cgi?id=141829
3762
3763         Reviewed by Simon Fraser.
3764
3765         * WebEditingTester/AppDelegate.m:
3766         (-[WebEditingAppDelegate _useWebKit1ForOpeningDocument:]):
3767         (-[WebEditingAppDelegate _useWebKit2ForOpeningDocument:]):
3768         (-[WebEditingAppDelegate openDocument:]):
3769         Add an open panel (with radio buttons to pick which WebKit to open with).
3770         Loads the file as an HTML string.
3771
3772 2015-02-20  Simon Fraser  <simon.fraser@apple.com>
3773
3774         [WebEditingTester] @properties, dot syntax, and remember the window position
3775         https://bugs.webkit.org/show_bug.cgi?id=141843
3776
3777         Reviewed by Tim Horton.
3778         
3779         Modernize a bit with more dot syntax, use @property for the web views,
3780         and give the main window an Autosave name so it remembers the widow position.
3781
3782         * WebEditingTester/WK1WebDocumentController.m:
3783         (-[WK1WebDocumentController awakeFromNib]):
3784         (-[WK1WebDocumentController loadHTMLString:]):
3785         * WebEditingTester/WK2WebDocumentController.m:
3786         (-[WK2WebDocumentController awakeFromNib]):
3787         * WebEditingTester/WebDocument.xib:
3788
3789 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
3790
3791         [WebEditingTester] Hook up key equivalents for new window action
3792         https://bugs.webkit.org/show_bug.cgi?id=141828
3793
3794         Reviewed by Enrica Casucci.
3795
3796         * WebEditingTester/AppDelegate.h:
3797         * WebEditingTester/AppDelegate.m:
3798         (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
3799         (-[WebEditingAppDelegate newEditor:]):
3800         (-[WebEditingAppDelegate _defaultWebDocumentControllerClass]):
3801         (-[WebEditingAppDelegate toggleUseWK2ByDefault:]):
3802         (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]):
3803         (defaultConfiguration): Deleted.
3804         (-[WebEditingAppDelegate applicationWillTerminate:]): Deleted.
3805         Move WKWebViewConfiguration setup into WK2WebDocumentController.
3806         Remove unused application termination code.
3807         Update new-window menu item key equivalents when launching and when
3808         changing the use-WebKit2-by-default setting.
3809         Make WebDocumentController subclasses all initialized the same way,
3810         and use that to factor out alloc/init.
3811         Rename loadContent to loadHTMLString for future use.
3812
3813         * WebEditingTester/MainMenu.xib:
3814         Add default key equivalents.
3815         Cmd-N will always make the default kind of window (controlled by the pref).
3816         Cmd-Opt-N will always make the other kind.
3817         The menu items are configured as alternates so they only show up if you
3818         press alt (just like in MiniBrowser).
3819
3820         * WebEditingTester/WK1WebDocumentController.m:
3821         (-[WK1WebDocumentController loadHTMLString:]):
3822         (-[WK1WebDocumentController loadContent]): Deleted.
3823         * WebEditingTester/WK2WebDocumentController.h:
3824         * WebEditingTester/WK2WebDocumentController.m:
3825         (defaultConfiguration):
3826         (-[WK2WebDocumentController awakeFromNib]):
3827         (-[WK2WebDocumentController loadHTMLString:]):
3828         (-[WK2WebDocumentController initWithConfiguration:]): Deleted.
3829         (-[WK2WebDocumentController dealloc]): Deleted.
3830         * WebEditingTester/WebDocumentController.h:
3831         * WebEditingTester/WebDocumentController.m:
3832         (-[WebDocumentController init]):
3833         (-[WebDocumentController initWithWindow:]):
3834         (+[WebDocumentController defaultEditingSource]):
3835         (-[WebDocumentController loadHTMLString:]):
3836         (-[WebDocumentController windowDidLoad]): Deleted.
3837         (-[WebDocumentController defaultEditingSource]): Deleted.
3838         (-[WebDocumentController applicationTerminating]): Deleted.
3839         (-[WebDocumentController loadContent]): Deleted.
3840
3841 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
3842
3843         [WebEditingTester] ARC-ify WebEditingTester
3844         https://bugs.webkit.org/show_bug.cgi?id=141827
3845
3846         Reviewed by Sam Weinig.
3847
3848         * WebEditingTester/AppDelegate.m:
3849         (-[WebEditingAppDelegate showOperations:]):
3850         * WebEditingTester/EditingOperations.m:
3851         (editingOperations):
3852         * WebEditingTester/WK1WebDocumentController.m:
3853         (-[WK1WebDocumentController dealloc]): Deleted.
3854         * WebEditingTester/WK2WebDocumentController.m:
3855         (-[WK2WebDocumentController dealloc]): Deleted.
3856         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
3857         Turn on ARC and remove a few retain/release/autorelease calls.
3858         We don't need to implement dealloc in either document controller
3859         because WebView and WKWebView's UIDelegate property does not hold a
3860         strong reference.
3861
3862 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
3863
3864         [WebEditingTester] Factor out list of editing operations
3865         https://bugs.webkit.org/show_bug.cgi?id=141826
3866
3867         Reviewed by Sam Weinig.
3868
3869         * WebEditingTester/AppDelegate.m:
3870         (-[WebEditingAppDelegate showOperations:]):
3871         * WebEditingTester/EditingOperations.h: Added.
3872         * WebEditingTester/EditingOperations.m: Added.
3873         (editingOperations):
3874         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
3875         Move EditingOperations array to its own file, and make it an NSArray
3876         instead of a C array. Adjust accordingly in showOperations:.
3877
3878 2015-02-20  Michael Saboff  <msaboff@apple.com>
3879
3880         DFG JIT needs to check for stack overflow at the start of Program and Eval execution
3881         https://bugs.webkit.org/show_bug.cgi?id=141676
3882
3883         Reviewed by Filip Pizlo.
3884
3885         Set the newly added --maximumEvalCacheableSourceLength option for eager test runs.  This is needed
3886         to allow the eval out of stack tests to tier up.  Without this option, we don't cache the likely
3887         large string expression that we want to eval.
3888
3889         * Scripts/run-jsc-stress-tests:
3890
3891 2015-02-19  Daniel Bates  <dabates@apple.com>
3892
3893         REGRESSION (r180239): run-webkit-test fails to boot simulator device that was booted by previous test run
3894         https://bugs.webkit.org/show_bug.cgi?id=141815
3895         <rdar://problem/19893933>
3896
3897         Reviewed by Simon Fraser.
3898
3899         Fixes an issue where run-webkit-tests would fail to boot the WebKit Tester simulator device if it
3900         was booted by iOS Simulator in a previous run of run-webkit-test.
3901
3902         * Scripts/webkitpy/port/ios.py:
3903         (IOSSimulatorPort.check_sys_deps): Added logic moved from IOSSimulatorPort.setup_test_run().
3904         (IOSSimulatorPort.setup_test_run): Moved logic to quit the iOS Simulator app and wait for the
3905         testing device to be in the shutdown state from here to IOSSimulatorPort.check_sys_deps().
3906
3907 2015-02-19  David Kilzer  <ddkilzer@apple.com>
3908
3909         check-webkit-style: do not warn about missing primary header for *SoftLink.cpp files
3910         <http://webkit.org/b/141799>
3911
3912         Reviewed by Alex Christensen.
3913
3914         * Scripts/webkitpy/style/checkers/cpp.py:
3915         (_IncludeState.check_next_include_order): Don't emit a warning
3916         if the primary header exists and the source file name ends with
3917         "SoftLink.cpp".  Add 'filename' argument to method.
3918         (check_include_line): Pass in 'filename'.
3919
3920         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3921         (OrderOfIncludesTest.test_check_next_include_order__no_config):
3922         (OrderOfIncludesTest.test_check_next_include_order__no_self):
3923         (OrderOfIncludesTest.test_check_next_include_order__likely_then_config):
3924         (OrderOfIncludesTest.test_check_next_include_order__other_then_config):
3925         (OrderOfIncludesTest.test_check_next_include_order__config_then_other_then_likely):
3926         - Add test filename arguments for calls to
3927           check_next_include_order().
3928         (OrderOfIncludesTest.test_primary_header): Add test for a file
3929         name ending in "SoftLink.cpp".
3930
3931 2015-02-18  Enrica Casucci  <enrica@apple.com>
3932
3933         Add new tool to test editable Webviews.
3934         https://bugs.webkit.org/show_bug.cgi?id=141772
3935
3936         Reviewed by Tim Horton.
3937
3938         Adding WebEditingTester, a Cocoa application to
3939         test WK1 and Wk2 views in editable mode.
3940
3941         * WebEditingTester: Added.
3942         * WebEditingTester/AppDelegate.h: Added.
3943         * WebEditingTester/AppDelegate.m: Added.
3944         (-[WebEditingAppDelegate init]):
3945         (defaultConfiguration):
3946         (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
3947         (-[WebEditingAppDelegate applicationWillTerminate:]):
3948         (-[WebEditingAppDelegate newEditor:]):
3949         (-[WebEditingAppDelegate showOperations:]):
3950         (-[WebEditingAppDelegate useWebKit2ByDefault]):
3951         (-[WebEditingAppDelegate toggleUseWK2ByDefault:]):
3952         (-[WebEditingAppDelegate validateMenuItem:]):
3953         * WebEditingTester/Info.plist: Added.
3954         * WebEditingTester/MainMenu.xib: Added.
3955         * WebEditingTester/WK1WebDocumentController.h: Added.
3956         * WebEditingTester/WK1WebDocumentController.m: Added.
3957         (-[WK1WebDocumentController awakeFromNib]):
3958         (-[WK1WebDocumentController loadContent]):
3959         (-[WK1WebDocumentController dealloc]):
3960         (-[WK1WebDocumentController pasteAsMarkup:]):
3961         * WebEditingTester/WK2WebDocumentController.h: Added.
3962         * WebEditingTester/WK2WebDocumentController.m: Added.
3963         (-[WK2WebDocumentController initWithConfiguration:]):
3964         (-[WK2WebDocumentController pasteAsMarkup:]):
3965         (-[WK2WebDocumentController awakeFromNib]):
3966         (-[WK2WebDocumentController dealloc]):
3967         (-[WK2WebDocumentController loadContent]):
3968         * WebEditingTester/WebDocument.xib: Added.
3969         * WebEditingTester/WebDocumentController.h: Added.
3970         * WebEditingTester/WebDocumentController.m: Added.
3971         (-[WebDocumentController initWithWindow:]):
3972         (-[WebDocumentController windowDidLoad]):
3973         (-[WebDocumentController defaultEditingSource]):
3974         (-[WebDocumentController applicationTerminating]):
3975         (-[WebDocumentController loadContent]):
3976         * WebEditingTester/WebEditingTester.xcodeproj: Added.
3977         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj: Added.
3978         * WebEditingTester/main.m: Added.
3979         (main):
3980
3981 2015-02-18  Csaba Osztrogonác  <ossy@webkit.org>
3982
3983         Run JSC tests on ARM EFL bots
3984         https://bugs.webkit.org/show_bug.cgi?id=141165
3985
3986         Reviewed by Alexey Proskuryakov.
3987
3988         * BuildSlaveSupport/build.webkit.org-config/config.json:
3989         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3990         (RunJavaScriptCoreTests.countFailures):
3991         (RunRemoteJavaScriptCoreTests):
3992         (RunRemoteJavaScriptCoreTests.start):
3993         (BuildAndRemoteJSCTestsFactory):
3994         (BuildAndRemoteJSCTestsFactory.__init__):
3995
3996 2015-02-18  Alexey Proskuryakov  <ap@apple.com>
3997
3998         Streamline unexported function build fixes
3999         https://bugs.webkit.org/show_bug.cgi?id=141761
4000
4001         Reviewed by Alex Christensen.
4002
4003         * Scripts/check-for-weak-vtables-and-externals: (readXcode5SymbolsToIgnore): Deleted.
4004         We don't need to ignore symbols that are not exported due to the .unexp file.
4005
4006 2015-02-18  Timothy Horton  <timothy_horton@apple.com>
4007
4008         Remove more references to WebCore.exp.in
4009         https://bugs.webkit.org/show_bug.cgi?id=141747
4010
4011         Reviewed by Alexey Proskuryakov.
4012
4013         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
4014         (ShouldBuildTest):
4015
4016 2015-02-17  Myles C. Maxfield  <mmaxfield@apple.com>
4017
4018         Windows test results should not fall back to mac-mountainlion after r180176
4019         https://bugs.webkit.org/show_bug.cgi?id=141719
4020
4021         Reviewed by Brent Fulgham.
4022
4023         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
4024         (_should_file_trigger_build):
4025         * Scripts/webkitpy/port/win.py:
4026         (WinPort.default_baseline_search_path):
4027         * Scripts/webkitpy/port/win_unittest.py:
4028         (WinPortTest.test_baseline_search_path):
4029
4030 2015-02-17  Daniel Bates  <dabates@apple.com>
4031
4032         [iOS] run-webkit-tests should check that simctl can boot and shutdown simulator device before running tests
4033         https://bugs.webkit.org/show_bug.cgi?id=141718
4034
4035         Reviewed by Alex Christensen.
4036
4037         We should only run layout tests if simctl can successfully boot and shutdown the testing device.
4038
4039         * Scripts/webkitpy/port/ios.py:
4040         (IOSSimulatorPort.check_sys_deps): Modified to call Simulator.check_simulator_device_and_erase_if_needed().
4041         Log a error and return False if we are unable to boot the simulator device so that the caller can take
4042         appropriate action, say exit(3) before running any layout tests.
4043         * Scripts/webkitpy/xcode/simulator.py:
4044         (Simulator._boot_and_shutdown_simulator_device): Added. Boot and then shut down the simulator device
4045         with the specified UDID.
4046         (Simulator.check_simulator_device_and_erase_if_needed): Added. Checks that simulator device
4047         with the specified UDID can successfully boot and shut down. We make at most two attempts to
4048         boot and shut down the device, erasing the device between tries so as to restore the device
4049         to a known good state.
4050
4051 2015-02-17  Daniel Bates  <dabates@apple.com>
4052
4053         run_webkit_tests.py should not know about iOS Simulator details
4054         https://bugs.webkit.org/show_bug.cgi?id=141711
4055
4056         Reviewed by Alex Christensen.
4057
4058         Run_webkit_tests.py should only parse the iOS-specific command
4059         line options --runtime and --device-type. Let the port-specific
4060         logic in ios.py validate the parsed options and instantiate
4061         internal data structures.
4062
4063         Currently run_webkit_tests.py parses the iOS-specific command
4064         line options --runtime and --device-type, validates them, and
4065         instantiates internal data structures from the parsed strings.
4066         Instead the validation logic and instantiation of internal
4067         data structures should be handled by the iOS port object.
4068
4069         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4070         (_set_up_derived_options): Remove logic to validate --runtime and --device-type
4071         and instantiate internal data structures for them.
4072         * Scripts/webkitpy/port/driver.py:
4073         (IOSSimulatorDriver.cmd_line): Modified to reference IOSSimulatorPort.simulator_runtime
4074         and IOSSimulatorPort.simulator_device_type for the iOS Simulator runtime and device type,
4075         respectively.
4076         * Scripts/webkitpy/port/ios.py: Sort the list of imports.
4077         (IOSSimulatorPort.simulator_runtime): Added. Instantiates a Runtime
4078         object from --runtime, if specified. Otherwise, instantiates a Runtime
4079         object for the latest installed iphonesimulator SDK version.
4080         (IOSSimulatorPort.simulator_device_type): Added. Instantiates a DeviceType
4081         object from --device-type, if specified. Otherwise, instantiates
4082         a DeviceType object for a iPhone 5 or iPhone 5s when on a 32-bit and 64-bit
4083         machine, respectively.
4084         (IOSSimulatorPort.check_sys_deps): Added. Validate if the chosen iOS simulator
4085         runtime is available to use.
4086         (IOSSimulatorPort.testing_device): Modified to make use of properties simulator_device_type
4087         and simulator_runtime for the iOS Simulator device type and runtime, respectively.
4088         * Scripts/webkitpy/xcode/simulator.py:
4089         (Runtime.from_version_string): Added. Turns around and calls Runtime.from_identifier()
4090         with a runtime identifier for the specified iOS version.
4091
4092 2015-02-17  Dana Burkart  <dburkart@apple.com>
4093
4094         ASan does not like JSC::MachineThreads::tryCopyOtherThreadStack
4095         https://bugs.webkit.org/show_bug.cgi?id=141672
4096
4097         Reviewed by David Kilzer.
4098
4099         * asan/webkit-asan-ignore.txt:
4100
4101 2015-02-17  Alex Christensen  <achristensen@webkit.org>
4102
4103         Remove WebCore.exp.in and clean up.
4104         https://bugs.webkit.org/show_bug.cgi?id=141491
4105
4106         Reviewed by Andreas Kling.
4107
4108         * Scripts/sort-export-file: Removed.
4109         * Scripts/webkitpy/style/checker.py:
4110         (_all_categories):
4111         (FileType):
4112         (CheckerDispatcher._file_type):
4113         (CheckerDispatcher._create_checker):
4114         Don't check if the export files are sorted.
4115         * Scripts/webkitpy/style/checkers/exportfile.py: Removed.
4116         * Scripts/webkitpy/style/checkers/exportfile_unittest.py: Removed.
4117
4118 2015-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
4119
4120         Unreviewed. Fix GTK+ make distcheck.
4121
4122         Do not exclude bmalloc directory from the tarball.
4123
4124         * gtk/manifest.txt.in:
4125
4126 2015-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
4127
4128         Unreviewed. Fix /webkit2/WebKitDOMNode/dom-cache after r180214.
4129
4130         I forgot to add the return of a bool function.
4131
4132         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
4133         (WebKitDOMNodeTest::testDOMCache):
4134
4135 2015-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
4136
4137         [GTK] GObject DOM bindings object are cached forever
4138         https://bugs.webkit.org/show_bug.cgi?id=141558
4139
4140         Reviewed by Sergio Villar Senin.
4141
4142         Add checks for all DOM objects to ensure they are not leaked. Also
4143         add a dedicated test for the DOM Object Cache.
4144
4145         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
4146         (WebKitDOMNodeFilterTest::testTreeWalker):
4147         (WebKitDOMNodeFilterTest::testNodeIterator):
4148         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
4149         (WebKitDOMNodeTest::testHierarchyNavigation):
4150         (WebKitDOMNodeTest::testInsertion):
4151         (WebKitDOMNodeTest::testTagNames):
4152         (WebKitDOMNodeTest::testDOMCache):
4153         (registerTests):
4154         * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:
4155         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
4156         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
4157         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
4158         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
4159         (testWebKitDOMObjectCache):
4160         (beforeAll):
4161         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
4162         (documentLoadedCallback):
4163
4164 2015-02-16  Carlos Garcia Campos  <cgarcia@igalia.com>
4165
4166         [GTK] WebKitFrame objects are never released
4167         https://bugs.webkit.org/show_bug.cgi?id=141641
4168
4169         Reviewed by Martin Robinson.
4170
4171         Add a way to check GObjects leaks for WebProcess tests and check
4172         WebKitFrame objects are not leaked.
4173
4174         * TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp:
4175         (WebKitFrameTest::testMainFrame):
4176         (WebKitFrameTest::testURI):
4177         (WebKitFrameTest::testJavaScriptContext):
4178         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
4179         (WebProcessTest::assertObjectIsDeletedWhenTestFinishes):
4180         (runTest):
4181         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
4182
4183 2015-02-16  Tim Horton  <timothy_horton@apple.com>
4184
4185         Fix the MiniBrowser build with newer clang
4186
4187         * MiniBrowser/mac/SettingsController.m:
4188         (-[SettingsController _toggleBooleanDefault:]):
4189         * MiniBrowser/mac/WK1BrowserWindowController.m:
4190         (-[WK1BrowserWindowController windowWillClose:]):
4191         * MiniBrowser/mac/WK2BrowserWindowController.m:
4192         (-[WK2BrowserWindowController windowWillClose:]):
4193         NSApp is id and clang gets confused about which -delegate we're talking about.
4194
4195 2015-02-16  Antti Koivisto  <antti@apple.com>
4196
4197         Develop/Disable Caches does not properly disable disk cache
4198         https://bugs.webkit.org/show_bug.cgi?id=141636
4199
4200         Reviewed by Anders Carlsson.
4201
4202         Make testRunner.setCacheModel() use the WKContext interface so the model gets passed to
4203         the network process too.
4204
4205         This makes setCacheModel asynchronous but there don't seem to be any tests that expect otherwise.
4206
4207         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4208         (WTR::InjectedBundle::beginTesting):
4209         (WTR::InjectedBundle::setCacheModel):
4210         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
4211         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4212
4213             Forward to TestController.
4214
4215         (WTR::TestRunner::setCacheModel):
4216         * WebKitTestRunner/TestInvocation.cpp:
4217         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
4218
4219 2015-02-16  Andrzej Badowski  <a.badowski@samsung.com>
4220
4221         Unreviewed. Add myself as a committer.
4222
4223         * Scripts/webkitpy/common/config/contributors.json:
4224
4225 2015-02-15  David Kilzer  <ddkilzer@apple.com>
4226
4227         REGRESSION (r180082): WebCore Debug builds fail on Mavericks due to weak export symbols
4228         <http://webkit.org/b/141607>
4229
4230         * Scripts/check-for-weak-vtables-and-externals: Ignore weak
4231         externals in Source/WebCore/Configurations/WebCore.unexp when
4232         building with Xcode 5.x.
4233         (readXcode5SymbolsToIgnore): Add.
4234
4235 2015-02-15  KwangHyuk Kim  <hyuki.kim@samsung.com>
4236
4237         [EFL] fix Evas GL engine error.
4238         https://bugs.webkit.org/show_bug.cgi?id=141621
4239
4240         Reviewed by Gyuyoung Kim.
4241
4242         As new elm engine api was added from efl 1.10, replace elm_config_preferred_engine_set with elm_config_accel_preference_set.
4243
4244         * MiniBrowser/efl/main.c:
4245         (elm_main):
4246
4247 2015-02-14  Csaba Osztrogonác  <ossy@webkit.org>
4248
4249         [buildbot] Enable run-api-tests on release Mac bots
4250         https://bugs.webkit.org/show_bug.cgi?id=141518
4251
4252         Reviewed by Darin Adler.
4253
4254         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4255         (RunUnitTests):
4256         (BuildFactory.__init__):
4257         (TestFactory.__init__):
4258         (BuildAndTestFactory.__init__):
4259         (RunUnitTests.start): Deleted.
4260         (unitTestsSupported): Deleted.
4261
4262 2015-02-13  Anders Carlsson  <andersca@apple.com>
4263
4264         Add a move constructor and move assignment operator to Deque
4265         https://bugs.webkit.org/show_bug.cgi?id=141571
4266
4267         Reviewed by Andreas Kling.
4268
4269         * TestWebKitAPI/Tests/WTF/Deque.cpp:
4270         (TestWebKitAPI::TEST):
4271
4272 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
4273
4274         run-jsc-stress-tests --remote should skip profiler tests
4275         https://bugs.webkit.org/show_bug.cgi?id=141470
4276
4277         Reviewed by Filip Pizlo.
4278
4279         * Scripts/run-jsc-stress-tests:
4280
4281 2015-02-13  Anders Carlsson  <andersca@apple.com>
4282
4283         Add an initializer list constructor to Deque
4284         https://bugs.webkit.org/show_bug.cgi?id=141565
4285
4286         Reviewed by Andreas Kling.
4287
4288         * TestWebKitAPI/Tests/WTF/Deque.cpp:
4289         (TestWebKitAPI::TEST):
4290
4291 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
4292
4293         [buildbot] Remove buildJSCTool cruft from master.cfg
4294         https://bugs.webkit.org/show_bug.cgi?id=141513
4295
4296         Reviewed by Alexey Proskuryakov.
4297
4298         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4299         (RunJavaScriptCoreTests):
4300         (RunJavaScriptCoreTests.start):
4301         (RunWebKitTests):
4302         (RunWebKitTests.start):
4303         (TestFactory.__init__):
4304         (TestLeaksFactory.__init__):
4305         (RunJavaScriptCoreTests.__init__): Deleted.
4306         (RunWebKitTests.__init__): Deleted.
4307
4308 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
4309
4310         Unreviewed, remove empty directories.
4311
4312         * DumpRenderTree/gtk: Removed.
4313         * DumpRenderTree/gtk/fonts: Removed.
4314         * DumpRenderTree/unix: Removed.
4315         * DumpRenderTree/unix/TestNetscapePlugin: Removed.
4316         * GtkLauncher: Removed.
4317         * TestWebKitAPI/Tests/WebKitGtk: Removed.
4318         * TestWebKitAPI/Tests/WebKitGtk/resources: Removed.
4319         * WebKitTestRunner/WebKitTestRunnerAppTests: Removed.
4320         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj: Removed.
4321
4322 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
4323
4324         Remove Windows cruft from Tools/Scripts/build-webkittestrunner
4325         https://bugs.webkit.org/show_bug.cgi?id=141519
4326
4327         Reviewed by Alexey Proskuryakov.
4328
4329         * Scripts/build-webkittestrunner:
4330
4331 2015-02-12  Alex Christensen  <achristensen@webkit.org>
4332
4333         Removed empty directory.
4334
4335         * WinCELauncher: Removed.
4336
4337 2015-02-12  Csaba Osztrogonác  <ossy@webkit.org>
4338
4339         run-jsc-stress-tests --remote should be able add the necessary libraries to the bundle on Linux
4340         https://bugs.webkit.org/show_bug.cgi?id=141202
4341
4342         Reviewed by Darin Adler.
4343
4344         * Scripts/run-jsc-stress-tests:
4345