Unreviewed. Adding myself as a commiter in contributers.json.
[WebKit-https.git] / Tools / ChangeLog
1 2015-04-16  Jake Nielsen  <jacob_nielsen@apple.com>
2
3         Unreviewed. Adding myself as a commiter in contributers.json.
4
5         * Scripts/webkitpy/common/config/contributors.json:
6
7 2015-04-16  Alexey Proskuryakov  <ap@apple.com>
8
9         It is very hard to attach a debugger to WebProcess to debug tests
10         https://bugs.webkit.org/show_bug.cgi?id=143837
11
12         Reviewed by Chris Dumez.
13
14         --no-timeout used to only affect waitUntilDone timeout, but not IPC timeout in
15         WebKitTestRunner, and not pipe reading timeout in run-webkit-tests.
16
17         Now it disables all timeouts in tools, as is best for debugging tests.
18
19         * Scripts/webkitpy/port/driver.py: (Driver.run_test): Respect --no-timeout, so
20         that the script doesn't terminate DRT/WKTR when there is no output for a long time.
21
22         * WebKitTestRunner/Options.cpp: Removed --no-timeout-at-all, as --no-timeout
23         now has the same functionality.
24
25 2015-04-16  Beth Dakin  <bdakin@apple.com>
26
27         Force mouse events should go through normal mouse event handling code paths
28         https://bugs.webkit.org/show_bug.cgi?id=143749
29         -and corresponding-
30         rdar://problem/20472895
31
32         Reviewed by Dean Jackson.
33
34         Add mouseForceDown/mouseForceUp/mouseForceChanged support to WebKitTestRunner. 
35         Since there is not a way to create an NSEventTypePressure from scratch, we 
36         subclass NSEvent and override all of the critical methods.
37
38         * WebKitTestRunner/EventSenderProxy.h:
39         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
40         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
41         (WTR::EventSendingController::mouseForceDown):
42         (WTR::EventSendingController::mouseForceUp):
43         (WTR::EventSendingController::mouseForceChanged):
44         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
45         * WebKitTestRunner/TestController.cpp:
46         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
47         * WebKitTestRunner/mac/EventSenderProxy.mm:
48         (-[EventSenderPressureEvent initAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
49         (-[EventSenderPressureEvent timestamp]):
50         (-[EventSenderPressureEvent type]):
51         (-[EventSenderPressureEvent locationInWindow]):
52         (-[EventSenderPressureEvent location]):
53         (-[EventSenderPressureEvent stage]):
54         (-[EventSenderPressureEvent pressure]):
55         (-[EventSenderPressureEvent phase]):
56         (-[EventSenderPressureEvent eventNumber]):
57         (WTR::EventSenderProxy::mouseForceDown):
58         (WTR::EventSenderProxy::mouseForceUp):
59         (WTR::EventSenderProxy::mouseForceChanged):
60
61 2015-04-16  Csaba Osztrogonác  <ossy@webkit.org>
62
63         [EFL] Bump LLVM to version 3.6.0 on X86_64
64         https://bugs.webkit.org/show_bug.cgi?id=143604
65
66         Reviewed by Gyuyoung Kim.
67
68         * efl/jhbuild.modules:
69         * efl/patches/llvm-elf-add-stackmaps-arm64.patch: Added the necessary part of llvm-elf-add-stackmaps.patch.
70         * efl/patches/llvm-elf-add-stackmaps.patch: Removed, it is included in LLVM 3.6.0 release.
71         * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Removed, it is included in LLVM 3.6.0 release.
72         * efl/patches/llvm-version-arm64.patch: Added. Set PACKAGE_VERSION to "3.5.0ftl" to be able to ensure we use patched LLVM on AArch64.
73
74 2015-04-16  Csaba Osztrogonác  <ossy@webkit.org>
75
76         [EFL] Remove an unnecessary workaround from jhbuildrc
77         https://bugs.webkit.org/show_bug.cgi?id=143823
78
79         Reviewed by Gyuyoung Kim.
80
81         * efl/jhbuildrc:
82
83 2015-04-16  Csaba Osztrogonác  <ossy@webkit.org>
84
85         [GTK] Run forwarding headers generator unconditionally
86         https://bugs.webkit.org/show_bug.cgi?id=143819
87
88         Reviewed by Carlos Garcia Campos.
89
90         * TestWebKitAPI/PlatformGTK.cmake:
91         * WebKitTestRunner/PlatformGTK.cmake:
92
93 2015-04-15  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
94
95         [EFL] Add gnutls to jhbuild.module
96         https://bugs.webkit.org/show_bug.cgi?id=143777
97
98         Reviewed by Csaba Osztrogonác.
99
100         EFL port has required at least 3.0.0 version of gnutls since r176712.
101         However some old linux distributions don't support 3.0.0 version. Besides
102         other projects sometimes need to use lower version of gnutls.
103
104         This patch supports to download gnutls through jhbuild, and use it.
105
106         * efl/install-dependencies: Add nettle-dev dependency and remove libgnutls28-dev. 
107         * efl/jhbuild.modules: Download 3.3 version because 3.3 version is stable version.
108
109 2015-04-15  Mark Lam  <mark.lam@apple.com>
110
111         Remove obsolete VMInspector debugging tool.
112         https://bugs.webkit.org/show_bug.cgi?id=143798
113
114         Reviewed by Michael Saboff.
115
116         * TestWebKitAPI/CMakeLists.txt:
117         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
118         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
119         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
120         * TestWebKitAPI/Tests/JavaScriptCore/VMInspector.cpp: Removed.
121
122 2015-04-15  Jer Noble  <jer.noble@apple.com>
123
124         Unreviewed gardening; Make the previous commit apply only _post_ Yosemite.
125
126         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
127
128 2015-04-15  Jer Noble  <jer.noble@apple.com>
129
130         Unreviewed gardening; disable FullscreenZoomInitialFrame.WebKit2 API test post-Yosemite.
131
132         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
133         (TestWebKitAPI::TEST_F):
134
135 2015-04-15  Chris Dumez  <cdumez@apple.com>
136
137         [Win] DRT does not seem to reset the 'UsesPageCache' setting between tests
138         https://bugs.webkit.org/show_bug.cgi?id=143779
139
140         Reviewed by Brent Fulgham.
141
142         Reset the 'UsesPageCache' setting to FALSE between tests on Windows,
143         similarly to what is done on Mac / WK1. Without this, PageCache could
144         stay enabled after page cache tests and cause weird behaviors.
145
146         * DumpRenderTree/win/DumpRenderTree.cpp:
147         (resetWebPreferencesToConsistentValues):
148
149 2015-04-14  Simon Fraser  <simon.fraser@apple.com>
150
151         Re-enable custom dilation for antialiased fonts
152         https://bugs.webkit.org/show_bug.cgi?id=143738
153
154         Reviewed by Tim Horton.
155         
156         Enabling custom dilation for antialised fonts broke layout tests, so re-land it,
157         but disable in WebKitTestRunner and DumpRenderTree. The latter requires adding
158         a private WebKit pref. This pref defaults to YES, enabling the feature by default
159         in WK1 as we do for WK2.
160
161         * DumpRenderTree/mac/DumpRenderTree.mm:
162         (resetWebPreferencesToConsistentValues):
163         * WebKitTestRunner/TestController.cpp:
164         (WTR::TestController::resetPreferencesToConsistentValues):
165
166 2015-04-14  Brent Fulgham  <bfulgham@apple.com>
167
168         Correct layering violation in DumpRenderTree Build
169         https://bugs.webkit.org/show_bug.cgi?id=143732
170
171         Reviewed by Simon Fraser.
172
173         Correct a layering violation in DumpRenderTree by calling functions on the
174         WebCoreTestSupport library, rather than attempting to work with WebCore
175         types directly.
176
177         * DumpRenderTree/mac/EventSendingController.mm:
178         (-[EventSendingController monitorWheelEvents]): Call methods on WebCoreTestSupport, rather
179         than WebCore itself.,
180         (-[EventSendingController callAfterScrollingCompletes:]): Ditto.
181
182 2015-04-14  Benjamin Poulain  <benjamin@webkit.org>
183
184         Add a conservative DFA minimizer for the content extension matcher
185         https://bugs.webkit.org/show_bug.cgi?id=143501
186
187         Reviewed by Alex Christensen.
188
189         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
190         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
191
192 2015-04-14  Daniel Bates  <dabates@apple.com>
193
194         Skip failing test Tests/WebKit2Cocoa/FixedLayoutSize.mm on iOS
195         https://bugs.webkit.org/show_bug.cgi?id=143693
196         <rdar://problem/20530316>
197
198         Reviewed by Tim Horton.
199
200         Skip the test Tests/WebKit2Cocoa/FixedLayoutSize.mm as we do not plan
201         to use the fixed layout code on iOS at this time.
202
203         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: Add !PLATFORM(IOS)-guard.
204
205 2015-04-14  Dominik Röttsches  <dominik.rottsches@intel.com>
206
207         Remove myself from watchlist, remove empty Cairo and HarfBuzz watchlists
208         https://bugs.webkit.org/show_bug.cgi?id=143705
209
210         Unreviewed change to watchlist file.
211
212         * Scripts/webkitpy/common/config/watchlist:
213
214 2015-04-14  KwangHyuk Kim  <hyuki.kim@samsung.com>
215
216         [EFL] favicon wasn't updated for google.com sometimes.
217         https://bugs.webkit.org/show_bug.cgi?id=141940
218
219         Reviewed by Gyuyoung Kim.
220
221         As elm_entry_utf8_to_markup can include additional characters, parameter for the
222         on_icon_changed_cb was just set by using url string retrieved by ewk_view_url_get().
223
224         * MiniBrowser/efl/main.c:
225         (on_url_changed):
226
227 2015-04-13  Tim Horton  <timothy_horton@apple.com>
228
229         Add a persistent, fixed scale factor to make it easy to scale down WK(Web)Views
230         https://bugs.webkit.org/show_bug.cgi?id=143560
231         <rdar://problem/16302047>
232
233         Reviewed by Darin Adler.
234
235         * MiniBrowser/mac/BrowserWindowController.h:
236         * MiniBrowser/mac/MainMenu.xib:
237         * MiniBrowser/mac/WK1BrowserWindowController.m:
238         (-[WK1BrowserWindowController setScale:]):
239         * MiniBrowser/mac/WK2BrowserWindowController.m:
240         (viewScaleForMenuItemTag):
241         (-[WK2BrowserWindowController setScale:]):
242         (-[WK2BrowserWindowController validateMenuItem:]):
243         Add a submenu with four view scale options: 100%, 75%, 50%, and 25%.
244         When in use, we resize the window so that the view fits correctly, and
245         use automaticallyComputesFixedlayoutSizeFromViewScale so that the page's
246         layout size will not change when scaling down (but will update appropriately
247         when the view is resized).
248
249 2015-04-13  Alexey Proskuryakov  <ap@apple.com>
250
251         build.webkit.org/dashboard shows obsolete results when builds are substantially out of order
252         https://bugs.webkit.org/show_bug.cgi?id=138630
253
254         Reviewed by Tim Horton.
255
256         Make sure that we always load at least one in order productive iteration.
257
258         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
259         (BuildbotQueue): Added _hasLoadedIterationForInOrderResult to track whether the queue
260         is done loading at least one iteration that wasn't an out of order build.
261         (BuildbotQueue.prototype.loadMoreHistoricalIterations): Listen for iteration load
262         when that's needed to check for out of order builds.
263         (BuildbotQueue.prototype.update): Ditto.
264         (BuildbotQueue.prototype._checkForInOrderResult): Check if the queue has an in order
265         result, and if it does not, load more iterations.
266         (BuildbotQueue.prototype.loadAll): We have everything loaded, so we certainly have
267         an in order iteration loaded too.
268         (BuildbotQueue.prototype.compareIterations): Extracted from sortIterations(), and
269         corrected to always sort loaded iterations before unloaded ones.
270
271 2015-04-10  Brent Fulgham  <bfulgham@apple.com>
272
273         Expand test infrastructure to support scrolling tests
274         https://bugs.webkit.org/show_bug.cgi?id=143286
275         <rdar://problem/20375516>
276
277         Reviewed by Simon Fraser.
278
279         Extend the WK1 and WK2 test programs to support two new EventSender commands:
280         (1) monitorWheelEvents: Tells DRT and WKTR to track the wheel event and animation state, so that we can
281         block executing tests until WebKit has completed any rubberband, scroll, or scroll-snap animations.
282         (2) callAfterScrollingCompletes: Provide a callback method to be executed when WebKit determines that
283         relevant rubberband, scroll, and scroll-snap animations are finished.
284
285         * DumpRenderTree/mac/EventSendingController.mm:
286         (+[EventSendingController isSelectorExcludedFromWebScript:]): Update to recognize 'callAfterScrollingCompletes:'
287         and 'monitorWheelEvents'.
288         (+[EventSendingController webScriptNameForSelector:]): Ditto.
289         (-[EventSendingController mouseScrollByX:andY:continuously:]): Add some stderr logging to help when
290         debugging test failures.
291         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]): Ditto.
292         (-[EventSendingController callAfterScrollingCompletes:]): Added. Protects the JSObject representing the callback
293         function, then passes it to WebCore to be called once the test deferrals have been cleared.
294         (-[EventSendingController monitorWheelEvents:]): Added. Activates the wheel event tracking used by the
295         'callAfterScrollingCompletes' method.
296         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Added signatures for 'callAfterScrollingCompletes'
297         and 'monitorWheelEvents'.
298         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
299         (WTR::EventSendingController::callAfterScrollingCompletes): Added. Protects the JSObject representing the
300         callback function, then passes it to WebCore to be called once the test deferrals have been cleared
301         (WTR::EventSendingController::monitorWheelEvents): Added. Activates the wheel event tracking used by the
302         'callAfterScrollingComplates' method.
303         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
304
305 2015-04-13  Alexey Proskuryakov  <ap@apple.com>
306
307         build.webkit.org/dashboard: Crash-only queues should show failure when testing fails to start
308         https://bugs.webkit.org/show_bug.cgi?id=143656
309
310         Reviewed by Darin Adler.
311
312         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
313         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
314
315 2015-04-13  Sergio Villar Senin  <svillar@igalia.com>
316
317         REGRESSION(r181134): [GTK] Test /webkit2/WebKitWebView/insecure-content is failing after r181134
318         https://bugs.webkit.org/show_bug.cgi?id=142387
319
320         Reviewed by Carlos Garcia Campos.
321
322         Running mixed content is blocked by default since r181134. Updated
323         the test case to reflect the new default settings.
324
325         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
326         (testInsecureContent):
327
328 2015-04-13  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
329
330         Fix wrong value variable in ENABLE_NAVIGATOR_HWCONCURRENCY
331         https://bugs.webkit.org/show_bug.cgi?id=143667
332
333         Reviewed by Csaba Osztrogonác.
334
335         ENABLE_NAVIGATOR_HWCONCURRENCY has used $registerProtocolHandlerSupport value variable
336         since r169017. Added $hardwareConcurrencySupport for it.
337
338         Additionally networkInfoSupport is removed because this feature was removed due to spec out.
339
340         * Scripts/webkitperl/FeatureList.pm:
341
342 2015-04-13  Csaba Osztrogonác  <ossy@webkit.org>
343
344         [cmake] Add ENABLE(ATTACHMENT_ELEMENT) to the build system
345         https://bugs.webkit.org/show_bug.cgi?id=143664
346
347         Reviewed by Gyuyoung Kim.
348
349         * Scripts/webkitperl/FeatureList.pm:
350
351 2015-04-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
352
353         [EFL] Enable Media Source
354         https://bugs.webkit.org/show_bug.cgi?id=143635
355
356         Reviewed by Csaba Osztrogonác.
357
358         * Scripts/webkitperl/FeatureList.pm: Enable media source on efl port.
359
360 2015-04-12  Alexey Proskuryakov  <ap@apple.com>
361
362         build.webkit.org/dashboard: Crash-only queues should show failure when failure limit is exceeded
363         https://bugs.webkit.org/show_bug.cgi?id=143646
364
365         Reviewed by David Kilzer.
366
367         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
368         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
369
370 2015-04-11  Alexey Proskuryakov  <ap@apple.com>
371
372         Use en_US spell checker for tests on Mac instead of Multilingual
373         https://bugs.webkit.org/show_bug.cgi?id=143641
374
375         Reviewed by Dan Bernstein.
376
377         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
378         While at it, override NSUserDictionaryReplacementItems, so that user replacements
379         cannot affect tests.
380
381         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize):
382         Made this more like WebKit1 version.
383
384 2015-04-10  Tim Horton  <timothy_horton@apple.com>
385
386         Replace setFixedLayoutSizeEnabled: with an enum of layout modes
387         https://bugs.webkit.org/show_bug.cgi?id=143576
388
389         Reviewed by Simon Fraser.
390
391         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm:
392         (TEST):
393         Adopt.
394
395 2015-04-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
396
397         Update my email address and expertise.
398         https://bugs.webkit.org/show_bug.cgi?id=143586
399
400         Unreviewed, just update my info.
401
402         * Scripts/webkitpy/common/config/contributors.json:
403
404 2015-04-09  Joseph Pecoraro  <pecoraro@apple.com>
405
406         Flakiness Dashboard not loading insecure content if loaded with https URL
407         https://bugs.webkit.org/show_bug.cgi?id=143570
408
409         Reviewed by Alexey Proskuryakov.
410
411         * TestResultServer/app.yaml:
412         * TestResultServer/static-dashboards/loader.js:
413         Switch to https scheme.
414
415 2015-04-09  Csaba Osztrogonác  <ossy@webkit.org>
416
417         [EFL][GTK] WebKit2's generate-forwarding-headers.pl runs too many times
418         https://bugs.webkit.org/show_bug.cgi?id=142907
419
420         Reviewed by Carlos Garcia Campos.
421
422         * TestWebKitAPI/PlatformEfl.cmake:
423         * TestWebKitAPI/PlatformGTK.cmake:
424         * WebKitTestRunner/PlatformEfl.cmake:
425         * WebKitTestRunner/PlatformGTK.cmake:
426
427 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
428
429         [Mac] Unreviewed test fix after r182584
430         https://bugs.webkit.org/show_bug.cgi?id=143452
431
432         Put both of these tests back to their original state now that the underlying
433         problem is fixed.
434
435         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp:
436         (TestWebKitAPI::TEST):
437         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
438         (TestWebKitAPI::TEST):
439
440 2015-04-08  Filip Pizlo  <fpizlo@apple.com>
441
442         run-jsc-benchmarks geomean of preferred means shouldn't print the VMs header twice
443         https://bugs.webkit.org/show_bug.cgi?id=143553
444
445         Reviewed by Ryosuke Niwa.
446         
447         Remove the spurious printVMs left over from an earlier change.
448
449         * Scripts/run-jsc-benchmarks:
450
451 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
452
453         [Mac] Unreviewed test fix after r182581
454
455         The behavior of control-left-click is controlled by a system preference.
456         Our test bots have this turned off.
457
458         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp:
459         (TestWebKitAPI::TEST):
460         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
461         (TestWebKitAPI::TEST):
462
463 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
464
465         [Mac] WebKit is not honoring OS preferences for secondary click behaviors
466         https://bugs.webkit.org/show_bug.cgi?id=143452
467         <rdar://problem/20437483>
468
469         Reviewed by Tim Horton.
470
471         Add a new API test to confirm that Cocoa mouse button press events are properly
472         tagged with the desired menu behavior (i.e., 'None', 'Context', or 'Action'.)
473
474         The WK2 test dispatches mouse down events to a PlatformWebView, and checks with
475         some registered event handlers that the expected button press and context menu
476         events are received.
477
478         The WK1 unit test creates an NSEvent with the desired button press state, and then
479         uses WebCore::PlatformEventFactory::createPlatformMouseEvent to create a WebCore event.
480         We check the resulting PlatformMouseEvent for proper state.
481
482         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test files.
483         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp: Added.
484         (TestWebKitAPI::buildAndPerformTest): Helper function to build/run an individual test.
485         * TestWebKitAPI/Tests/WebKit2/mouse-button-listener.html: Added.
486         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm: Added.
487         (TestWebKitAPI::canCallMenuTypeForEvent): Helper function.
488         (TestWebKitAPI::buildAndPerformTest): Helper function to build/run an individual test.
489         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
490         (TestWebKitAPI::PlatformWebView::simulateButtonClick): Added method to support firing
491         mouse down events.
492         * TestWebKitAPI/mac/PlatformWebViewMac.h:
493
494 2015-04-08  Michael Catanzaro  <mcatanzaro@igalia.com>
495
496         [GTK] Add pango to jhbuild-optional.modules
497         https://bugs.webkit.org/show_bug.cgi?id=143537
498
499         Reviewed by Martin Robinson.
500
501         * gtk/jhbuild-optional.modules: Add pango.
502
503 2015-04-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
504
505         [XvfbDriver] Regular expression used to match running X servers fails on Fedora 22.
506         https://bugs.webkit.org/show_bug.cgi?id=143530
507
508         Reviewed by Žan Doberšek.
509
510         Assume that the default value for display (:0) is reserved and start checking on :1
511         Adjust webkitpy test and include two new test cases for this bug (display number not specified)
512         and for X server named Xorg.bin (previous bug 1376599)
513
514         * Scripts/webkitpy/port/xvfbdriver.py:
515         (XvfbDriver._next_free_display)
516         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
517         (XvfbDriverTest.test_start_no_pixel_tests):
518         (XvfbDriverTest.test_start_pixel_tests):
519         (XvfbDriverTest.test_start_arbitrary_worker_number):
520         (XvfbDriverTest.test_next_free_display):
521         (XvfbDriverTest.test_start_next_worker):
522 2015-04-08  Alex Christensen  <achristensen@webkit.org>
523
524         Block popups from content extensions.
525         https://bugs.webkit.org/show_bug.cgi?id=143497
526
527         Reviewed by Brady Eidson.
528
529         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
530         (TestWebKitAPI::TEST_F):
531         Added popup test.
532
533 2015-04-08  Alex Christensen  <achristensen@webkit.org> and Patrick Gansterer  <paroga@webkit.org>
534
535         Add CMake build system for WinCairo port.
536         https://bugs.webkit.org/show_bug.cgi?id=115944
537
538         Reviewed by Chris Dumez.
539
540         * CMakeLists.txt:
541         * WinLauncher/CMakeLists.txt: Added.
542
543 2015-04-08  Carlos Garcia Campos  <cgarcia@igalia.com>
544
545         [GTK] Crash in DOMObjectCache when a wrapped object owned by the cache is unreffed by the user
546         https://bugs.webkit.org/show_bug.cgi?id=143521
547
548         Reviewed by Martin Robinson.
549
550         Add a way to detect unexpected web process crashes to WebViewTest,
551         and a test case to testDOMCache to trigger the crash.
552
553         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
554         (WebKitDOMNodeTest::testDOMCache):
555         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
556         (testWebKitWebViewProcessCrashed):
557         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
558         (WebViewTest::WebViewTest):
559         (WebViewTest::webProcessCrashed):
560         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
561
562 2015-04-07  Alexey Proskuryakov  <ap@apple.com>
563
564         PageVisibilityStateWithWindowChanges should only be enabled on Yosemite
565         rdar://problem/20461342
566
567         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
568
569 2015-04-07  Commit Queue  <commit-queue@webkit.org>
570
571         Unreviewed, rolling out r182511.
572         https://bugs.webkit.org/show_bug.cgi?id=143507
573
574         caused debug test failures (Requested by alexchristensen on
575         #webkit).
576
577         Reverted changeset:
578
579         "Block popups from content extensions."
580         https://bugs.webkit.org/show_bug.cgi?id=143497
581         http://trac.webkit.org/changeset/182511
582
583 2015-04-07  Alex Christensen  <achristensen@webkit.org>
584
585         Block popups from content extensions.
586         https://bugs.webkit.org/show_bug.cgi?id=143497
587
588         Reviewed by Brady Eidson.
589
590         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
591         (TestWebKitAPI::TEST_F):
592         Added popup test.
593
594 2015-04-07  Benjamin Poulain  <benjamin@webkit.org>
595
596         Get the features.json files ready for open contributions
597         https://bugs.webkit.org/show_bug.cgi?id=143436
598
599         Reviewed by Darin Adler.
600
601         * Scripts/webkitpy/style/checkers/jsonchecker.py:
602         (JSONFeaturesChecker.check):
603         Extend the syntax checking a bit, but leave everything non-mandatory
604         very loose until we figure what fields are important.
605
606 2015-04-07  Tim Horton  <timothy_horton@apple.com>
607
608         Expose and test fixedLayoutSize via modern WebKit SPI
609         https://bugs.webkit.org/show_bug.cgi?id=143500
610
611         Reviewed by Simon Fraser.
612
613         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
614         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: Added.
615         (-[FixedLayoutSizeNavigationDelegate webView:didFinishNavigation:]):
616         (TEST):
617         Add a test that verifies that fixedLayoutSize works at all, that
618         it persists through a navigation, and that turning it back off reverts to
619         laying out at the size of the view.
620
621 2015-04-07  Michael Catanzaro  <mcatanzaro@igalia.com>
622
623         Unreviewed. Add myself as a committer.
624
625         * Scripts/webkitpy/common/config/contributors.json:
626
627 2015-04-07  Brent Fulgham  <bfulgham@apple.com>
628
629         [Win] Bots complain about missing /etc/catalog
630         https://bugs.webkit.org/show_bug.cgi?id=143484
631
632         Reviewed by Chris Dumez.
633
634         The libxml2 build on Mac, iOS, and Windows does not provide the set
635         of default catalog files. We do not actually need these for our
636         purposes, but we get warnings and some bot flakiness because they
637         are not present.
638
639         We can avoid both problems the same way the Mac and iOS ports do,
640         by setting the XML_CATALOG_FILES environment variable to 'empty string',
641         which avoid the warnings and bot problems.
642
643         * Scripts/webkitpy/port/win.py:
644         (WinPort.setup_environ_for_server): Added.
645
646 2015-04-06  Sam Weinig  <sam@webkit.org>
647
648         Use content extensions in MiniBrowser.
649         https://bugs.webkit.org/show_bug.cgi?id=143446
650
651         Reviewed by Alex Christensen.
652
653         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
654         * MiniBrowser/mac/AppDelegate.h:
655         * MiniBrowser/mac/AppDelegate.m:
656         (-[BrowserAppDelegate init]):
657         (-[BrowserAppDelegate showExtensionsManager:]):
658         (-[BrowserAppDelegate userContentContoller]):
659         * MiniBrowser/mac/ExtensionManagerWindowController.h: Added.
660         * MiniBrowser/mac/ExtensionManagerWindowController.m: Added.
661         (-[ExtensionManagerWindowController init]):
662         (-[ExtensionManagerWindowController windowDidLoad]):
663         (-[ExtensionManagerWindowController add:]):
664         (-[ExtensionManagerWindowController remove:]):
665         * MiniBrowser/mac/ExtensionManagerWindowController.xib: Added.
666         * MiniBrowser/mac/MainMenu.xib:
667
668 2015-04-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
669
670         web-platform-tests server should retrieve the modules file relatively to its docroot path
671         https://bugs.webkit.org/show_bug.cgi?id=142742
672
673         Reviewed by Darin Adler.
674
675         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
676         (WebPlatformTestServer._install_modules): Compute the modules description file path according wpt server doc root path.
677
678 2015-04-06  Commit Queue  <commit-queue@webkit.org>
679
680         Unreviewed, rolling out r182445.
681         https://bugs.webkit.org/show_bug.cgi?id=143459
682
683         broke 32 bit build (Requested by alexchristensen on #webkit).
684
685         Reverted changeset:
686
687         "Use content extensions in MiniBrowser."
688         https://bugs.webkit.org/show_bug.cgi?id=143446
689         http://trac.webkit.org/changeset/182445
690
691 2015-04-06  Sam Weinig  <sam@webkit.org>
692
693         Use content extensions in MiniBrowser.
694         https://bugs.webkit.org/show_bug.cgi?id=143446
695
696         Reviewed by Alex Christensen.
697
698         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
699         * MiniBrowser/mac/AppDelegate.h:
700         * MiniBrowser/mac/AppDelegate.m:
701         (-[BrowserAppDelegate init]):
702         (-[BrowserAppDelegate showExtensionsManager:]):
703         (-[BrowserAppDelegate userContentContoller]):
704         * MiniBrowser/mac/ExtensionManagerWindowController.h: Added.
705         * MiniBrowser/mac/ExtensionManagerWindowController.m: Added.
706         (-[ExtensionManagerWindowController init]):
707         (-[ExtensionManagerWindowController windowDidLoad]):
708         (-[ExtensionManagerWindowController add:]):
709         (-[ExtensionManagerWindowController remove:]):
710         * MiniBrowser/mac/ExtensionManagerWindowController.xib: Added.
711         * MiniBrowser/mac/MainMenu.xib:
712
713 2015-04-06  Michael Catanzaro  <mcatanzaro@gnome.org>
714
715         [GTK] install-dependencies should prefer dnf to yum
716         https://bugs.webkit.org/show_bug.cgi?id=143441
717
718         Reviewed by Martin Robinson.
719
720         Test for the existance of dnf before yum, and only try to use yum if dnf does not exist.
721
722         * gtk/install-dependencies:
723
724 2015-04-06  Andy Estes  <aestes@apple.com>
725
726         [iOS] 'make clean' fails in Tools/WebKitTestRunner
727         https://bugs.webkit.org/show_bug.cgi?id=143455
728
729         Reviewed by Dan Bernstein.
730
731         This Makefile adds '-target WebKitTestRunnerApp' to OTHER_OPTIONS during iOS builds, but the top-level
732         Makefile.shared adds '-alltargets' for clean builds, and xcodebuild does not allow both -target and -alltargets.
733
734         * WebKitTestRunner/Makefile: Don't add '-target WebKitTestRunerApp' to OTHER_OPTIONS on clean builds.
735
736 2015-04-06  Alexey Proskuryakov  <ap@apple.com>
737
738         WebKit1.SetAndUpdateCacheModelPreferencesChangeMix fails on some machines
739         https://bugs.webkit.org/show_bug.cgi?id=143450
740
741         Reviewed by Anders Carlsson.
742
743         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm: (TestWebKitAPI::TEST):
744         Make sure that the view is actually closed, regardless of anything else that happens beneath.
745         Also, removed unnecessary get() calls.
746
747 2015-04-03  Alexey Proskuryakov  <ap@apple.com>
748
749         Reduce the dependency on Flash in regression tests
750         https://bugs.webkit.org/show_bug.cgi?id=143391
751
752         Reviewed by Anders Carlsson.
753
754         * WebKitTestRunner/TestController.cpp: (WTR::TestController::decidePolicyForPluginLoad):
755         Only allow QuickTime and the test plug-in.
756
757 2015-04-06  Youenn Fablet  <youenn.fablet@crf.canon.fr>
758
759         W3C test importer should generate the modules installed dynamically to run wpt tests
760         https://bugs.webkit.org/show_bug.cgi?id=142738
761
762         Reviewed by Ryosuke Niwa.
763
764         The test importer can now generate the submodules description file based on information extracted from the corresponding git repository.
765         The implementation is done within TestDownloader and it is activated for the WPT repository.
766         LayoutTests/imported/w3c/resources/WPTModules is renamed as LayoutTests/imported/w3c/resources/web-platform-tests-modules.json for that reason.
767
768         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
769         (WebPlatformTestServer._install_modules): Updated to cope with path as array.
770         * Scripts/webkitpy/w3c/test_downloader.py:
771         (TestDownloader._git_submodules_status): Added so that it can be overriden for unit tests.
772         (TestDownloader):
773         (TestDownloader._git_submodules_description): Computes submodule description.
774         (TestDownloader.generate_git_submodules_description): Write submodule description in a file.
775         * Scripts/webkitpy/w3c/test_importer.py:
776         (TestImporter.do_import): Added the possibility to post process the tests.
777         (TestImporter):
778         (TestImporter.generate_git_submodules_description_for_all_repositories): Enable generating module description file.
779         (TestImporter.should_convert_test_harness_links): Updated according new options format.
780         * Scripts/webkitpy/w3c/test_importer_unittest.py:
781         (TestImporterTest.import_downloaded_tests): Making use of TestDownloaderMock. 
782         (TestImporterTest.import_downloaded_tests.TestDownloaderMock): Added to override submodule status gathering.
783         (TestImporterTest.import_downloaded_tests.TestDownloaderMock.__init__):
784         (TestImporterTest.import_downloaded_tests.TestDownloaderMock._git_submodules_status):
785         (TestImporterTest.test_submodules_generation): Added to check that modules description files works.
786
787 2015-04-05  Antti Koivisto  <antti@apple.com>
788
789         Bloom filter should support longer hashes
790         https://bugs.webkit.org/show_bug.cgi?id=143419
791
792         Reviewed by Dan Bernstein.
793
794         * TestWebKitAPI/Tests/WTF/BloomFilter.cpp:
795         (TestWebKitAPI::generateRandomDigests):
796         (TestWebKitAPI::TEST):
797
798 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
799
800         run-jsc-stress-tests --remote should add libllvmForJSC.so to the bundle on Linux
801         https://bugs.webkit.org/show_bug.cgi?id=143372
802
803         Reviewed by Darin Adler.
804
805         * Scripts/run-jsc-stress-tests:
806
807 2015-04-03  Antti Koivisto  <antti@apple.com>
808
809         Add non-counting bloom filter class
810         https://bugs.webkit.org/show_bug.cgi?id=143366
811
812         Reviewed by Sam Weinig.
813
814         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
815         * TestWebKitAPI/Tests/WTF/BloomFilter.cpp: Added.
816         (TestWebKitAPI::generateRandomHashes):
817         (TestWebKitAPI::TEST):
818
819 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
820
821         FTL JIT tests should fail if LLVM library isn't available
822         https://bugs.webkit.org/show_bug.cgi?id=143374
823
824         Reviewed by Mark Lam.
825
826         * Scripts/run-jsc-stress-tests:
827
828 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
829
830         [EFL] Speedup jhbuild with disable running autogen.sh
831         https://bugs.webkit.org/show_bug.cgi?id=143369
832
833         Reviewed by Gyuyoung Kim.
834
835         * efl/jhbuild.modules:
836
837 2015-04-01  Alexey Proskuryakov  <ap@apple.com>
838
839         filter-webkit-build should filter out "created by an unsupported XCDependencyGraph build" lines
840         https://bugs.webkit.org/show_bug.cgi?id=143282
841
842         Reviewed by Daniel Bates.
843
844         * Scripts/filter-build-webkit: (shouldIgnoreLine): Do it.
845
846 2015-04-01  Alexey Proskuryakov  <ap@apple.com>
847
848         When LayoutTestHelper fails to start, we continue to run the tests, ending up with mysterious failures
849         https://bugs.webkit.org/show_bug.cgi?id=143240
850         rdar://problem/19990425
851
852         Reviewed by Tim Horton.
853
854         * DumpRenderTree/mac/LayoutTestHelper.m:
855         (colorProfileURLForDisplay):
856         (saveDisplayColorProfiles):
857         Gracefully handle it when the current profile cannot be retrieved, fixing at
858         least one case when LayoutTestHelper couldn't start.
859
860         * Scripts/webkitpy/layout_tests/controllers/manager.py:
861         (Manager._set_up_run):
862         (Manager._force_pixel_tests_if_needed):
863         * Scripts/webkitpy/port/base.py: (Port.to.start_helper):
864         * Scripts/webkitpy/port/mac.py: (MacPort.start_helper):
865         Return and check an error from start_helper().
866
867 2015-04-01  Brent Fulgham  <bfulgham@apple.com>
868
869         [Win] Run test-webkitpy as part of EWS (just like we do on other platforms)
870         https://bugs.webkit.org/show_bug.cgi?id=143321
871
872         Reviewed by Alexey Proskuryakov.
873
874         * EWSTools/start-queue-win.sh: Add commands to run 'test-webkitpy' during processing loop.
875
876 2015-04-01  Enrica Casucci  <enrica@apple.com>
877
878         Injected bundle messages should be at the page level.
879         https://bugs.webkit.org/show_bug.cgi?id=143283
880
881         Reviewed by Alexey Proskuryakov.
882
883         Updating WebKitTestRunner to use the new page level messaging.
884         The author of this patch is Tim Horton, I just finished it.
885
886         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
887         (WTR::EventSendingController::mouseDown):
888         (WTR::EventSendingController::mouseUp):
889         (WTR::EventSendingController::mouseMoveTo):
890         (WTR::EventSendingController::leapForward):
891         (WTR::EventSendingController::scheduleAsynchronousClick):
892         (WTR::EventSendingController::keyDown):
893         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
894         (WTR::EventSendingController::mouseScrollBy):
895         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
896         (WTR::EventSendingController::continuousMouseScrollBy):
897         (WTR::EventSendingController::addTouchPoint):
898         (WTR::EventSendingController::updateTouchPoint):
899         (WTR::EventSendingController::setTouchModifier):
900         (WTR::EventSendingController::setTouchPointRadius):
901         (WTR::EventSendingController::touchStart):
902         (WTR::EventSendingController::touchMove):
903         (WTR::EventSendingController::touchEnd):
904         (WTR::EventSendingController::touchCancel):
905         (WTR::EventSendingController::clearTouchPoints):
906         (WTR::EventSendingController::releaseTouchPoint):
907         (WTR::EventSendingController::cancelTouchPoint):
908         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
909         (WTR::InjectedBundle::didReceiveMessage):
910         (WTR::InjectedBundle::didReceiveMessageToPage):
911         (WTR::InjectedBundle::done):
912         (WTR::InjectedBundle::outputText):
913         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
914         (WTR::InjectedBundle::postAddChromeInputField):
915         (WTR::InjectedBundle::postRemoveChromeInputField):
916         (WTR::InjectedBundle::postFocusWebView):
917         (WTR::InjectedBundle::postSetBackingScaleFactor):
918         (WTR::InjectedBundle::postSetWindowIsKey):
919         (WTR::InjectedBundle::postSimulateWebNotificationClick):
920         (WTR::InjectedBundle::postSetAddsVisitedLinks):
921         (WTR::InjectedBundle::setGeolocationPermission):
922         (WTR::InjectedBundle::setMockGeolocationPosition):
923         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
924         (WTR::InjectedBundle::setUserMediaPermission):
925         (WTR::InjectedBundle::setCustomPolicyDelegate):
926         (WTR::InjectedBundle::setHidden):
927         (WTR::InjectedBundle::setCacheModel):
928         (WTR::InjectedBundle::shouldProcessWorkQueue):
929         (WTR::InjectedBundle::processWorkQueue):
930         (WTR::InjectedBundle::queueBackNavigation):
931         (WTR::InjectedBundle::queueForwardNavigation):
932         (WTR::InjectedBundle::queueLoad):
933         (WTR::InjectedBundle::queueLoadHTMLString):
934         (WTR::InjectedBundle::queueReload):
935         (WTR::InjectedBundle::queueLoadingScript):
936         (WTR::InjectedBundle::queueNonLoadingScript):
937         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
938         (WTR::TestRunner::setHandlesAuthenticationChallenges):
939         (WTR::TestRunner::setAuthenticationUsername):
940         (WTR::TestRunner::setAuthenticationPassword):
941         (WTR::TestRunner::secureEventInputIsEnabled):
942         (WTR::TestRunner::setBlockAllPlugins):
943         * WebKitTestRunner/TestController.cpp:
944         (WTR::TestController::createWebViewWithOptions):
945         (WTR::TestController::resetStateToConsistentValues):
946         (WTR::TestController::didReceivePageMessageFromInjectedBundle):
947         (WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundle):
948         * WebKitTestRunner/TestController.h:
949         * WebKitTestRunner/TestInvocation.cpp:
950         (WTR::TestInvocation::invoke):
951         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
952
953 2015-04-01  Commit Queue  <commit-queue@webkit.org>
954
955         Unreviewed, rolling out r182174 and r182177.
956         https://bugs.webkit.org/show_bug.cgi?id=143314
957
958         Try to correct EWS failures (Requested by bfulgham on
959         #webkit).
960
961         Reverted changesets:
962
963         "Python SCM should be able to retrieve untracked files"
964         https://bugs.webkit.org/show_bug.cgi?id=143135
965         http://trac.webkit.org/changeset/182174
966
967         "[buildbot] clean-build script should remove untracked files
968         and revert local changes too"
969         https://bugs.webkit.org/show_bug.cgi?id=142400
970         http://trac.webkit.org/changeset/182177
971
972 2015-04-01  Alex Christensen  <achristensen@webkit.org>
973
974         [Content Extensions] Properly handle regexes that match everything.
975         https://bugs.webkit.org/show_bug.cgi?id=143281
976
977         Reviewed by Benjamin Poulain.
978
979         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
980         (TestWebKitAPI::testRequest):
981         (TestWebKitAPI::makeBackend):
982         (TestWebKitAPI::TEST_F):
983         Removed duplicate code and added test.
984
985 2015-03-31  Benjamin Poulain  <bpoulain@apple.com>
986
987         Content Extensions: split the state machines to minimize prefix states
988         https://bugs.webkit.org/show_bug.cgi?id=143253
989
990         Reviewed by Alex Christensen.
991
992         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
993         (TestWebKitAPI::TEST_F):
994         (TestWebKitAPI::testPatternStatus):
995
996 2015-03-31  Yusuke Suzuki  <utatane.tea@gmail.com>
997
998         Clean up Identifier factories to clarify the meaning of StringImpl*
999         https://bugs.webkit.org/show_bug.cgi?id=143146
1000
1001         Reviewed by Filip Pizlo.
1002
1003         Simple API tests for StringImpl are added.
1004
1005         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1006         (TestWebKitAPI::TEST):
1007
1008 2015-03-31  Csaba Osztrogonác  <ossy@webkit.org>
1009
1010         [EFL] Add AArch64 builder and tester bot to build.webkit.org
1011         https://bugs.webkit.org/show_bug.cgi?id=143092
1012
1013         Reviewed by Gyuyoung Kim.
1014
1015         * BuildSlaveSupport/build.webkit.org-config/config.json:
1016         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1017         (Factory.__init__):
1018         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1019
1020 2015-03-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1021
1022         [buildbot] clean-build script should remove untracked files and revert local changes too
1023         https://bugs.webkit.org/show_bug.cgi?id=142400
1024
1025         Reviewed by Ryosuke Niwa.
1026
1027         This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
1028         A helper routine SCM.discard_untracked_files is added for that purpose.
1029
1030         * BuildSlaveSupport/clean-build:
1031         (main): Making call to Scripts/clean-webkit
1032         * Scripts/clean-webkit: Added.
1033         (main): Revert changes and delete untracked files.
1034         * Scripts/webkitpy/common/checkout/scm/scm.py:
1035         (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.
1036         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1037         (SCMTest._shared_test_discard_untracked_files):
1038         (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.
1039
1040 2015-03-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1041
1042         Python SCM should be able to retrieve untracked files
1043         https://bugs.webkit.org/show_bug.cgi?id=143135
1044
1045         Reviewed by Ryosuke Niwa.
1046
1047         This patch introduces SCM.untracked_files to retrieve a list of untracked files.
1048         Ignored files may be included or not in this list according boolean passed to the function.
1049
1050         * Scripts/webkitpy/common/checkout/scm/git.py:
1051         (Git.untracked_files):
1052         * Scripts/webkitpy/common/checkout/scm/scm.py:
1053         (SCM.untracked_files):
1054         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1055         (SCMTest._shared_test_untracked_files):
1056         (test_untracked_files):
1057         (GitSVNTest.test_untracked_files):
1058         * Scripts/webkitpy/common/checkout/scm/svn.py:
1059         (SVN.untracked_files):
1060
1061 2015-03-30  Alex Christensen  <achristensen@webkit.org>
1062
1063         [Content Extensions] Correctly handle regular expressions matching everything
1064         https://bugs.webkit.org/show_bug.cgi?id=143235
1065
1066         Reviewed by Benjamin Poulain.
1067
1068         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1069         (TestWebKitAPI::checkCompilerError):
1070         (TestWebKitAPI::TEST_F):
1071         Test ContentExtensionErrors.
1072
1073 2015-03-30  Alexey Proskuryakov  <ap@apple.com>
1074
1075         DumpRenderTree should set NSWindowDisplayWithRunLoopObserver
1076         https://bugs.webkit.org/show_bug.cgi?id=143241
1077         rdar://problem/20351297
1078
1079         Reviewed by Mark Lam.
1080
1081         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
1082
1083 2015-03-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1084
1085         [CMake][EFL] Remove redundant library link and include path
1086         https://bugs.webkit.org/show_bug.cgi?id=143221
1087
1088         Reviewed by Csaba Osztrogonác.
1089
1090         * ImageDiff/PlatformEfl.cmake: Remove unnecessary library link and include path.
1091
1092 2015-03-30  Sam Weinig  <sam@webkit.org>
1093
1094         [Content Extensions] Flesh out the UserContentExtensionStore
1095         https://bugs.webkit.org/show_bug.cgi?id=143123
1096
1097         Reviewed by Benjamin Poulain.
1098
1099         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1100         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm: Added.
1101         Add tests for _WKUserContentExtensionStore.
1102
1103 2015-03-30  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
1104
1105         Update install-dependencies Fedora packages after r181624
1106         https://bugs.webkit.org/show_bug.cgi?id=143215
1107
1108         Add json-glib, libv4l, openssl and pulseaudio development packages to
1109         the Fedora list providing we need them to build WebKit dependencies
1110         for this distribution.
1111
1112         Reviewed by Philippe Normand.
1113
1114         * gtk/install-dependencies:
1115
1116 2015-03-30  Commit Queue  <commit-queue@webkit.org>
1117
1118         Unreviewed, rolling out r182119.
1119         https://bugs.webkit.org/show_bug.cgi?id=143196
1120
1121         problem with syntax (Requested by youenn on #webkit).
1122
1123         Reverted changeset:
1124
1125         "[buildbot] clean-build script should remove untracked files
1126         and revert local changes too"
1127         https://bugs.webkit.org/show_bug.cgi?id=142400
1128         http://trac.webkit.org/changeset/182119
1129
1130 2015-03-30  Benjamin Poulain  <benjamin@webkit.org>
1131
1132         Start the features.json files
1133         https://bugs.webkit.org/show_bug.cgi?id=143207
1134
1135         Reviewed by Darin Adler.
1136
1137         I kept the style checking light. We'll have to figure
1138         what is the best format for each field.
1139
1140         * Scripts/webkitpy/style/checker.py:
1141         (CheckerDispatcher._create_checker):
1142         * Scripts/webkitpy/style/checkers/jsonchecker.py:
1143         (JSONContributorsChecker.check):
1144         (JSONFeaturesChecker):
1145         (JSONFeaturesChecker.check):
1146
1147 2015-03-29  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1148
1149         [buildbot] clean-build script should remove untracked files and revert local changes too
1150         https://bugs.webkit.org/show_bug.cgi?id=142400
1151
1152         Reviewed by Ryosuke Niwa.
1153
1154         This patch cleans the WebKit folder by deleting SCM untracked files and reverting changes for tracked files.
1155
1156         * BuildSlaveSupport/clean-build:
1157         (main): Adding call to Tools/Scripts/clean-webkit.
1158         * Scripts/clean-webkit: Added.
1159         (main): Removes untracked and changed files.
1160         * Scripts/webkitpy/common/checkout/scm/git.py:
1161         (Git.untracked_files): Retrieves GIT untracked files.
1162         * Scripts/webkitpy/common/checkout/scm/scm.py:
1163         (SCM.untracked_files): Retrieves SVN untracked files.
1164         (SCM):
1165         (SCM.discard_untracked_files): Deletes untracked files/folders.
1166         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1167         (SCMTest._shared_test_untracked_files): Unit testing for untracked files.
1168         (test_untracked_files):
1169         (GitSVNTest.test_untracked_files):
1170         * Scripts/webkitpy/common/checkout/scm/svn.py:
1171         (SVN.untracked_files):
1172
1173 2015-03-27  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1174
1175         [CMake] Remove unnecessary INCLUDE_IF_EXISTS macro 
1176         https://bugs.webkit.org/show_bug.cgi?id=143138
1177
1178         Reviewed by Csaba Osztrogonác.
1179
1180         INCLUDE_IF_EXISTS isn't used except for 2 places. However those uses can
1181         be replaced with WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS.
1182
1183         * ImageDiff/CMakeLists.txt:
1184         Use WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS() instead of INCLUDE_IF_EXISTS.
1185         * WebKitTestRunner/CMakeLists.txt: ditto.
1186
1187 2015-03-27  Myles C. Maxfield  <mmaxfield@apple.com>
1188
1189         Support building WTF on Windows without Cygwin
1190         https://bugs.webkit.org/show_bug.cgi?id=143084
1191
1192         Reviewed by Brent Fulgham.
1193
1194         Windows without Cygwin doesn't have curl, unzip, or grep. Luckily, Perl does all of these things.
1195         This patch also migrates to using File::Spec->catfile() for directory separators.
1196
1197         * Scripts/update-webkit-dependency:
1198         (wanted):
1199         * Scripts/update-webkit-support-libs:
1200         (wanted):
1201         (downloadExpectedVersionNumber):
1202         (zipFileVersion):
1203         (toUnixPath): Deleted.
1204         * Scripts/webkitdirs.pm:
1205         (determineSourceDir):
1206         (windowsSourceSourceDir):
1207         (windowsLibrariesDir):
1208         (windowsOutputDir):
1209         (checkInstalledTools):
1210         (buildVisualStudioProject):
1211
1212 2015-03-27  Alex Christensen  <achristensen@webkit.org>
1213
1214         Fix WinCairo bot.
1215         https://bugs.webkit.org/show_bug.cgi?id=143086
1216
1217         Reviewed by Brent Fulgham.
1218
1219         * Scripts/webkitdirs.pm:
1220         (buildVisualStudioProject):
1221         (runSvnUpdateAndResolveChangeLogs):
1222         Use ActivePerl-friendly perl.
1223
1224 2015-03-27  Csaba Osztrogonác  <ossy@webkit.org>
1225
1226         URTBF after r182059 to fix the EFL build.
1227
1228         * TestWebKitAPI/CMakeLists.txt:
1229
1230 2015-03-26  Alexey Proskuryakov  <ap@apple.com>
1231
1232         Layout test results URL loads in WK1 but not WK2 minibrowser
1233         https://bugs.webkit.org/show_bug.cgi?id=143117
1234
1235         Reviewed by Tim Horton.
1236
1237         * MiniBrowser/mac/WK2BrowserWindowController.m:
1238         (-[WK2BrowserWindowController fetch:]): Fix this, international domain names, and
1239         everything.
1240         (-[WK2BrowserWindowController updateTextFieldFromURL:]): Ditto.
1241
1242 2015-03-26  Jer Noble  <jer.noble@apple.com>
1243
1244         Add --allowed-host support to run-webkit-tests
1245         https://bugs.webkit.org/show_bug.cgi?id=142938
1246
1247         Reviewed by Brent Fulgham.
1248
1249         Accept --allowed-host arguments from run-webkit-tests and pass them through to
1250         DumpRenderTree and WebKitTestRunner.
1251
1252         Drive-by fix: Depending on the value of the --layout-test-dir parameter, layout test results
1253         are placed in the wrong location. The argument is compared with each tests's path, and if a
1254         relative path or a path with '..' was used, results are placed alongside the test. Take the
1255         absolute path of the --layout-test-dir argument, collapsing path components like '..'.
1256
1257         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1258         (parse_args):
1259         * Scripts/webkitpy/port/base.py:
1260         (Port.__init__):
1261         (Port.allowed_hosts):
1262         * Scripts/webkitpy/port/driver.py:
1263         (Driver.cmd_line):
1264
1265 2015-03-26  Jer Noble  <jer.noble@apple.com>
1266
1267         [Mac] Add an --allowed-host argument to DRT and WKTR to allow tests to connect to non-localhost servers
1268         https://bugs.webkit.org/show_bug.cgi?id=142931
1269
1270         Reviewed by Brent Fulgham.
1271
1272         Currently, both DRT and WKTR will refuse to allow network connections to non-localhost servers
1273         over HTTP/HTTPS. For certain testing scenarios, however, it would be useful if both DRT and
1274         WKTR could be allowed to make HTTP/HTTPS connections to certain, specific servers defined at
1275         runtime.
1276
1277         To allow this, add an optional argument to DRT and WKTR, --allowed-host, which will add the specified
1278         hostname to a whitelist; requests to these hosts will allowed to proceed normally.
1279
1280         Drive-by fix: in InjectedBundlePage::willSendRequestForFrame, we get the top loading frame from the
1281         injected bundle. But after the main resource load completes, the bundle nulls out it's pointer to the
1282         top loading frame, which causes a subsequent crash when further resources are requested. Instead, get
1283         the top loading frame from the page, as we do elsewhere in this class.
1284
1285         * DumpRenderTree/TestRunner.h:
1286         (TestRunner::allowedHosts):
1287         (TestRunner::setAllowedHosts):
1288         * DumpRenderTree/mac/DumpRenderTree.mm:
1289         (initializeGlobalsFromCommandLineOptions):
1290         (runTest):
1291         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1292         (isAllowedHost):
1293         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
1294         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1295         (WTR::InjectedBundle::didReceiveMessage):
1296         (WTR::InjectedBundle::isAllowedHost):
1297         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1298         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1299         (WTR::isAllowedHost):
1300         (WTR::InjectedBundlePage::willSendRequestForFrame):
1301         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1302         * WebKitTestRunner/Options.cpp:
1303         (WTR::handleOptionAllowedHost):
1304         (WTR::OptionsHandler::OptionsHandler):
1305         * WebKitTestRunner/Options.h:
1306         * WebKitTestRunner/TestController.cpp:
1307         (WTR::TestController::initialize):
1308         (WTR::TestController::resetStateToConsistentValues):
1309         * WebKitTestRunner/TestController.h:
1310
1311 2015-03-26  Brady Eidson  <beidson@apple.com>
1312
1313         Apply ContentExtension actions after redirects.
1314         <rdar://problem/20062613> and https://bugs.webkit.org/show_bug.cgi?id=143055
1315
1316         Reviewed by Alex Christensen.
1317
1318         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1319         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Dump the fact that the load error is kWKErrorCodeCannotShowURL
1320           which is specifically interesting to a new test.
1321
1322 2015-03-26  Csaba Osztrogonác  <ossy@webkit.org>
1323
1324         [EFL] Disable building libseccomp on AArch64
1325         https://bugs.webkit.org/show_bug.cgi?id=143094
1326
1327         Reviewed by Gyuyoung Kim.
1328
1329         * efl/jhbuildrc:
1330
1331 2015-03-26  Csaba Osztrogonác  <ossy@webkit.org>
1332
1333         [jhbuild] git should use only 1 thread for cloning jhbuild
1334         https://bugs.webkit.org/show_bug.cgi?id=143095
1335
1336         Reviewed by Gyuyoung Kim.
1337
1338         * jhbuild/jhbuild-wrapper:
1339         (clone_jhbuild):
1340
1341 2015-03-25  Joseph Pecoraro  <pecoraro@apple.com>
1342
1343         Update prepare-ChangeLog to work with ES6 Class syntax
1344         https://bugs.webkit.org/show_bug.cgi?id=143069
1345
1346         Reviewed by Timothy Hatcher.
1347
1348         * Scripts/prepare-ChangeLog:
1349         (get_function_line_ranges_for_javascript):
1350         Better handle ES6 Class syntax.
1351
1352         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt:
1353         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js:
1354         (BaseClass):
1355         (DerivedClass):
1356         (DerivedClass.staticMethod):
1357         (DerivedClass.prototype.method.nestedFunctionInsideMethod):
1358         (DerivedClass.prototype.method):
1359         (DerivedClass.prototype.get getter):
1360         (namespace.MyClass):
1361         (namespace.MyClass.staticMethod):
1362         (namespace.MyClass.prototype.method.nestedFunctionInsideMethod):
1363         (namespace.MyClass.prototype.method):
1364         (namespace.MyClass.prototype.get getter):
1365         Proof!
1366
1367 2015-03-25  Filip Pizlo  <fpizlo@apple.com>
1368
1369         Use JITCompilationCanFail in more places, and make the fail path of JITCompilationMustSucceed a crash instead of attempting GC
1370         https://bugs.webkit.org/show_bug.cgi?id=142993
1371
1372         Reviewed by Mark Lam.
1373         
1374         Bunch of support for testing executable allocation failure.
1375
1376         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz: Added.
1377         (fail):
1378         * Scripts/run-javascriptcore-tests:
1379         (runJSCStressTests):
1380         * Scripts/run-jsc-stress-tests:
1381
1382 2015-03-25  Myles C. Maxfield  <mmaxfield@apple.com>
1383
1384         Fix Windows build from r181977.
1385
1386         Unreviewed.
1387
1388         * Scripts/update-webkit-dependency:
1389
1390 2015-03-25  Sam Weinig  <sam@webkit.org>
1391
1392         Address additional review feedback from https://bugs.webkit.org/show_bug.cgi?id=143059.
1393
1394         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1395         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
1396
1397 2015-03-25  Myles C. Maxfield  <mmaxfield@apple.com>
1398
1399         Migrate update-webkit for Windows to not require Cygwin
1400         https://bugs.webkit.org/show_bug.cgi?id=143040
1401
1402         Reviewed by Brent Fulgham.
1403
1404         * Scripts/update-webkit-dependency:
1405         (wanted):
1406         (toUnixPath): Deleted.
1407         * Scripts/webkitdirs.pm:
1408         (fontExists):
1409         (checkInstalledTools):
1410         (setupAppleWinEnv):
1411
1412 2015-03-25  Sam Weinig  <sam@webkit.org>
1413
1414         [Content Extensions] Convert content extension compiling to return error codes and write its output using a client
1415         https://bugs.webkit.org/show_bug.cgi?id=143059
1416
1417         Reviewed by Alex Christensen.
1418
1419         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1420         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
1421         Update for new interface of compileRuleList().
1422
1423 2015-03-25  Alex Christensen  <achristensen@webkit.org>
1424
1425         [Content Extensions] Add multi-DFA compiling and interpreting.
1426         https://bugs.webkit.org/show_bug.cgi?id=143010
1427
1428         Reviewed by Benjamin Poulain.
1429
1430         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1431         (TestWebKitAPI::testRequest):
1432         (TestWebKitAPI::TEST_F):
1433         Add some tests for ignore-previous-rules and large rulesets.
1434
1435 2015-03-25  Alexey Proskuryakov  <ap@apple.com>
1436
1437         Mavericks WK1 still runs JSC tests
1438         https://bugs.webkit.org/show_bug.cgi?id=143035
1439
1440         Reviewed by Csaba Osztrogonác.
1441
1442         * BuildSlaveSupport/build.webkit.org-config/config.json: Bring Mavericks WK1 in line
1443         with other bots.
1444
1445         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Updated the tests
1446         accordingly.
1447
1448 2015-03-25  Commit Queue  <commit-queue@webkit.org>
1449
1450         Unreviewed, rolling out r181932.
1451         https://bugs.webkit.org/show_bug.cgi?id=143041
1452
1453         The test fails most of the time on bots (Requested by ap on
1454         #webkit).
1455
1456         Reverted changeset:
1457
1458         "[Content Extensions] Add multi-DFA compiling and
1459         interpreting."
1460         https://bugs.webkit.org/show_bug.cgi?id=143010
1461         http://trac.webkit.org/changeset/181932
1462
1463 2015-03-24  Alex Christensen  <achristensen@webkit.org>
1464
1465         [Content Extensions] Add multi-DFA compiling and interpreting.
1466         https://bugs.webkit.org/show_bug.cgi?id=143010
1467
1468         Reviewed by Benjamin Poulain.
1469
1470         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1471         (TestWebKitAPI::testRequest):
1472         (TestWebKitAPI::TEST_F):
1473         Add some tests for ignore-previous-rules and large rulesets.
1474
1475 2015-03-24  Benjamin Poulain  <bpoulain@apple.com>
1476
1477         Make URL filter patterns matching consistent and add a simple canonicalization step
1478         https://bugs.webkit.org/show_bug.cgi?id=142998
1479
1480         Reviewed by Alex Christensen.
1481
1482         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1483
1484 2015-03-24  Csaba Osztrogonác  <ossy@webkit.org>
1485
1486         [EFL] Add OpenWebRTC in jhbuild
1487         https://bugs.webkit.org/show_bug.cgi?id=142778
1488
1489         Reviewed by Gyuyoung Kim.
1490
1491         Original patch by Philippe Normand <pnormand@igalia.com>
1492
1493         * efl/install-dependencies: Dependencies for OpenWebRTC.
1494         * efl/jhbuild.modules: build OpenWebRTC, libusrsctp, libnice and
1495         the openwebrtc gst plugins.
1496
1497 2015-03-23  Brent Fulgham  <bfulgham@apple.com>
1498
1499         Regression(r181257): WTF_WorkQueue.Simple is flaky
1500         https://bugs.webkit.org/show_bug.cgi?id=142560
1501
1502         Remove the check that the refCount has returned to one after the
1503         individual tasks have completed. It's too nondeterministic when
1504         the reference count will be reduced.
1505
1506         Reviewed by Alexey Proskuryakov
1507
1508         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
1509         (TestWebKitAPI::TEST): Remove test that refCount is back to 1.
1510
1511 2015-03-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1512
1513         [CMake][EFL] Put failure API test excutables into failure directory
1514         https://bugs.webkit.org/show_bug.cgi?id=142965
1515
1516         Reviewed by Csaba Osztrogonác.
1517
1518         Move failing WK2 API test executables to *bin/TestWebKitAPI/WebKit2/failure* directory.
1519
1520         * TestWebKitAPI/CMakeLists.txt: Fix a typo. Change *testBaseName* with *testName*.
1521         * TestWebKitAPI/PlatformEfl.cmake: Additionally remove unnecessary SHARED_CORE and comment for SeccompFilters test.
1522
1523 2015-03-22  Benjamin Poulain  <benjamin@webkit.org>
1524
1525         CSS Selectors: fix attribute case-insensitive matching of Contain and List
1526         https://bugs.webkit.org/show_bug.cgi?id=142932
1527
1528         Reviewed by Darin Adler.
1529
1530         Add tests for the new features and fix some existing tests using the 
1531         stringFromUTF8() utility recently added by Dhi.
1532
1533         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1534         (TestWebKitAPI::stringFromUTF8):
1535         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1536
1537 2015-03-22  Michael Catanzaro  <mcatanzaro@igalia.com>
1538
1539         [GTK] install-dependencies should install orc
1540         https://bugs.webkit.org/show_bug.cgi?id=142955
1541
1542         Reviewed by Martin Robinson.
1543
1544         Install orc, needed by openwebrtc
1545
1546         * gtk/install-dependencies:
1547
1548 2015-03-22  Benjamin Poulain  <bpoulain@apple.com>
1549
1550         Detect when url filter pattern with groups match the empty string
1551         https://bugs.webkit.org/show_bug.cgi?id=142930
1552
1553         Reviewed by Sam Weinig.
1554
1555         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1556
1557 2015-03-22  Anders Carlsson  <andersca@apple.com>
1558
1559         _WKWebsiteDataStore should clear WebSQL databases
1560         https://bugs.webkit.org/show_bug.cgi?id=142947
1561
1562         Reviewed by Sam Weinig.
1563
1564         Add a variable that keeps track of the types of data we want to operate on, for easier debugging.
1565
1566         * MiniBrowser/mac/WK2BrowserWindowController.m:
1567         (-[WK2BrowserWindowController fetchWebsiteData:]):
1568         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
1569         (-[WK2BrowserWindowController clearWebsiteData:]):
1570
1571 2015-03-20  Mark Hahnenberg  <mhahnenb@gmail.com>
1572
1573         GCTimer should know keep track of nested GC phases
1574         https://bugs.webkit.org/show_bug.cgi?id=142675
1575
1576         Reviewed by Darin Adler.
1577
1578         Adds a tool to aid in parsing the GC phase timing output into a
1579         tree-like structure based on the parent-child relationships
1580         of nested GC phases.
1581
1582         * Scripts/parse-gc-phase-timings: Added.
1583         (Timing):
1584         (Timing.__init__):
1585         (Timing.__unicode__):
1586         (Timing.__str__):
1587         (Timing.__repr__):
1588         (parse_input):
1589         (print_timing_node):
1590         (print_timing_tree):
1591         (link_parents):
1592         (main):
1593
1594 2015-03-20  Brent Fulgham  <bfulgham@apple.com>
1595
1596         [Win] Temporarily turn of EWS Windows tests while I debug the test failure.
1597
1598         * Scripts/webkitpy/common/config/ews.json:
1599
1600 2015-03-20  Philippe Normand  <pnormand@igalia.com>
1601
1602         [GTK][jhbuild] Fix flakey failures due to unstable googlecode repository
1603         https://bugs.webkit.org/show_bug.cgi?id=142867
1604
1605         Rubber-stamped by Csaba Osztrogon.
1606
1607         * gtk/jhbuild.modules: Use Ossy's libusrsctp Github fork. Also use
1608         a fixed revision for the openwebrtc-gst-plugins.
1609
1610 2015-03-19  Ryosuke Niwa  <rniwa@webkit.org>
1611
1612         Unreviewed build fix. Don't try to report stats for all benchmarks.
1613         Just report the geometric mean of preferred means.
1614
1615         * Scripts/run-jsc-benchmarks:
1616
1617 2015-03-19  Ryosuke Niwa  <rniwa@webkit.org>
1618
1619         run-jsc-benchmarks should only report preferred mean
1620         https://bugs.webkit.org/show_bug.cgi?id=142874
1621
1622         Reviewed by Geoffrey Garen.
1623
1624         Just collect statistics for the preferred mean.
1625
1626         * Scripts/run-jsc-benchmarks:
1627
1628 2015-03-19  Alex Christensen  <achristensen@webkit.org>
1629
1630         [Content Extensions] Test regular expression parse failures.
1631         https://bugs.webkit.org/show_bug.cgi?id=142872
1632
1633         Reviewed by Benjamin Poulain.
1634
1635         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1636         (TestWebKitAPI::testPatternStatus):
1637         (TestWebKitAPI::TEST_F):
1638         Added tests for each parsing status.
1639
1640 2015-03-19  Alex Christensen  <achristensen@webkit.org>
1641
1642         Fix API tests after r181754.
1643
1644         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1645         (TestWebKitAPI::testRequest):
1646
1647 2015-03-19  Brady Eidson  <beidson@apple.com>
1648
1649         Part of content extensions should apply css selectors
1650         https://bugs.webkit.org/show_bug.cgi?id=142604
1651
1652         Reviewed by Alex Christensen.
1653
1654         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1655         (WebCore::ContentExtensions::operator<<):
1656
1657 2015-03-19  Brent Fulgham  <bfulgham@apple.com>
1658
1659         [Win] Activate tests on EWS
1660         https://bugs.webkit.org/show_bug.cgi?id=142850
1661
1662         Reviewed by Alexey Proskuryakov.
1663
1664         * Scripts/webkitpy/common/config/ews.json: Add me as
1665         the EWS bot watcher, and activate tests.
1666
1667 2015-03-19  Csaba Osztrogonác  <ossy@webkit.org>
1668
1669         [GTK] Fix inspector userinterface related incremental build issue
1670         https://bugs.webkit.org/show_bug.cgi?id=142849
1671
1672         Reviewed by Carlos Garcia Campos.
1673
1674         * Scripts/webkitdirs.pm:
1675         (shouldRemoveCMakeCache):
1676
1677 2015-03-18  Alex Christensen  <achristensen@webkit.org>
1678
1679         [ContentExtensions] Prepare for compiling stylesheets of selectors to be used on every page.
1680         https://bugs.webkit.org/show_bug.cgi?id=142799
1681
1682         Reviewed by Brady Eidson.
1683
1684         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1685         (TestWebKitAPI::testPattern):
1686         (TestWebKitAPI::TEST_F):
1687         Start testing regex failures.
1688
1689 2015-03-18  Dhi Aurrahman  <diorahman@rockybars.com>
1690
1691         Fix StringView typos after r181525 and r181558
1692         https://bugs.webkit.org/show_bug.cgi?id=142772
1693
1694         Reviewed by Darin Adler.
1695
1696         Add some tests in [1] to cover the StringView::startsWith, 
1697         StringView::startsWithIgnoringASCIICase, StringView::endsWith and 
1698         StringView::endsWithIgnoringASCIICase implementations.
1699
1700         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1701         (TestWebKitAPI::TEST):
1702
1703 2015-03-18  Dana Burkart  <dburkart@apple.com>
1704
1705         Remove extraneous import to fix the build.
1706
1707         Unreviewed.
1708
1709         * Scripts/webkitpy/port/driver.py:
1710
1711 2015-03-18  Dana Burkart  <dburkart@apple.com>
1712
1713         ASAN_OPTIONS=allocator_may_return_null=1 needs to be set 
1714         https://bugs.webkit.org/show_bug.cgi?id=142547
1715
1716         Reviewed by Alexey Proskuryakov.
1717
1718         * Scripts/webkitpy/port/driver.py:
1719         (Driver._setup_environ_for_driver):
1720
1721 2015-03-18  Alexey Proskuryakov  <ap@apple.com>
1722
1723         Tweak how AppleSystemFontOSSubversion default is added
1724         https://bugs.webkit.org/show_bug.cgi?id=142835
1725
1726         Reviewed by Dan Bernstein.
1727
1728         * DumpRenderTree/mac/DumpRenderTree.mm:
1729         (setDefaultsToConsistentValuesForTesting):
1730
1731 2015-03-18  Dan Bernstein  <mitz@apple.com>
1732
1733         prepare-ChangeLog doesn't understand C string literals split across multiple lines with \
1734         https://bugs.webkit.org/show_bug.cgi?id=142815
1735
1736         Reviewed by Darin Adler.
1737
1738         * Scripts/prepare-ChangeLog:
1739         (get_function_line_ranges_for_cpp): If the line ends with a backslash instead of a matching
1740         quotation mark, use new variable $quotation_mark to remember what we are looking for, and
1741         keep consuming the quoted text until the matching quotation mark is reached. Emit the
1742         warning only if a line ends without a backslash before the matching quotation mark was found.
1743
1744 2015-03-18  Joseph Pecoraro  <pecoraro@apple.com>
1745
1746         Remove unused "preprocessor" parameter to sub-CodeGenerators
1747         https://bugs.webkit.org/show_bug.cgi?id=142793
1748
1749         Reviewed by Darin Adler.
1750
1751         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1752         (new):
1753
1754 2015-03-18  Csaba Osztrogonác  <ossy@webkit.org>
1755
1756         [EFL] Bump gstreamer version to 1.4.4
1757         https://bugs.webkit.org/show_bug.cgi?id=142782
1758
1759         Reviewed by Philippe Normand.
1760
1761         * efl/jhbuild.modules:
1762         * efl/patches/gst-libav.patch:
1763         * efl/patches/gst-plugins-bad-remove-gnustep-support.patch: Added.
1764         * efl/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
1765
1766 2015-03-17  Tim Horton  <timothy_horton@apple.com>
1767
1768         Fix the iOS build.
1769
1770         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
1771         (WTR::InjectedBundle::platformInitialize):
1772
1773 2015-03-17  Dean Jackson  <dino@apple.com>
1774
1775         check-webkit-style should allow "bool a : 1"
1776         https://bugs.webkit.org/show_bug.cgi?id=142794
1777
1778         Reviewed by Brent Fulgham.
1779
1780         We should allow member bitfields of the form:
1781
1782         bool m_var : 1;
1783
1784         It seems that Visual Studio 8 was the last compiler that
1785         wasn't happy about not using unsigned here. We already have
1786         about 500 cases (in WebCore) where people were ignoring this rule.
1787
1788         * Scripts/webkitpy/style/checkers/cpp.py:
1789         (check_language): Allow "bool".
1790         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add tests.
1791         (CppStyleTest.test_enum_bitfields):
1792         (CppStyleTest.test_plain_integral_bitfields):
1793
1794 2015-03-17  Benjamin Poulain  <bpoulain@apple.com>
1795
1796         Compile character ranges targeting the same state as range check in the bytecode
1797         https://bugs.webkit.org/show_bug.cgi?id=142759
1798
1799         Reviewed by Alex Christensen.
1800
1801         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1802         (TestWebKitAPI::TEST_F):
1803
1804 2015-03-17  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1805
1806         W3C test parser and converter should use test importer host
1807         https://bugs.webkit.org/show_bug.cgi?id=142729
1808
1809         Reviewed by Bem Jones-Bey.
1810
1811         When instantiated by TestImporter, TestParser and TestConverter are now using the same host.
1812         This enables adding more TestImporter unit testing.
1813         This patch also ensures that the git object instantiated by TestDownloader is using the
1814         same Executive and FileSystem object as TestDownloader, again to enable TestImporter/TestDownloader unit testing.
1815
1816         * Scripts/webkitpy/common/system/filesystem_mock.py:
1817         (MockFileSystem.copytree): Fixes implementation as it creates a runtime error.
1818         * Scripts/webkitpy/w3c/test_downloader.py:
1819         (TestDownloader.git): Set the executive of the git object to the one of TestDownloader. Refactoring in a new git function for future reuse.
1820         (TestDownloader.checkout_test_repository): Making use of the new git function.
1821         * Scripts/webkitpy/w3c/test_importer.py:
1822         (TestImporter.find_importable_tests): Adding host as parameter to the parser.
1823         (TestImporter.import_tests): Adding host as parameter to the converter.
1824         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1825         (TestImporterTest.create_test_download_importer): Creating a test downloader mock, to be reused by other tests.
1826         (TestImporterTest):
1827         (TestImporterTest.test_harnesslinks_conversion): Adding test to check that test harness links are converted for CSS tests but not WPT tests. 
1828         * Scripts/webkitpy/w3c/test_parser.py:
1829         (TestParser.__init__): Adding host as parameter constructor.
1830
1831 2015-03-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1832
1833         [GTK] WebKitDOM objects leaking
1834         https://bugs.webkit.org/show_bug.cgi?id=118788
1835
1836         Reviewed by Darin Adler and Sergio Villar Senin.
1837
1838         Update DOMObjectCache unit test to check that DOM objects are also
1839         released when new contents are loaded in the web view, and the old
1840         document is detached from the frame.
1841
1842         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
1843         (testWebKitDOMObjectCache):
1844         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
1845         (runTest):
1846
1847 2015-03-17  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1848
1849         W3C test importer default import folder should be LayoutTests/imported/w3c
1850         https://bugs.webkit.org/show_bug.cgi?id=142728
1851
1852         Reviewed by Bem Jones-Bey.
1853
1854         * Scripts/webkitpy/w3c/test_importer.py:
1855         (parse_args): Updating the default destination option value to 'imported/w3c'.
1856
1857 2015-03-17  Philippe Normand  <pnormand@igalia.com>
1858
1859         [GTK] basic OpenWebRTC build support
1860         https://bugs.webkit.org/show_bug.cgi?id=142393
1861
1862         Reviewed by Carlos Garcia Campos.
1863
1864         * gtk/jhbuild.modules: Add OpenWebRTC and its dependencies. This
1865         is not the upstream OpenWebRTC repository. This temporary fork
1866         contains a few patches needed by WebKit for audio/video rendering.
1867
1868 2015-03-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1869
1870         [CMake][EFL] Build test tools only for developer mode
1871         https://bugs.webkit.org/show_bug.cgi?id=142761
1872
1873         Reviewed by Csaba Osztrogonác.
1874
1875         Do not build EFL MiniBrowser, WebKitTestRunner, and ImageDiff on production mode.
1876
1877         * CMakeLists.txt:
1878
1879 2015-03-17  Joseph Pecoraro  <pecoraro@apple.com>
1880
1881         Remove never used "useLayerOnTop" bindings generator argument
1882         https://bugs.webkit.org/show_bug.cgi?id=142773
1883
1884         Reviewed by Darin Adler.
1885
1886         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1887         (new):
1888
1889 2015-03-16  Ryosuke Niwa  <rniwa@webkit.org>
1890
1891         Enable ES6 classes by default
1892         https://bugs.webkit.org/show_bug.cgi?id=142774
1893
1894         Reviewed by Gavin Barraclough.
1895
1896         * Scripts/webkitperl/FeatureList.pm:
1897
1898 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
1899
1900         Fix webkitpy tests after r181585.
1901
1902         Looks like "me" cannot be anyone's email, it's a special case.
1903
1904         * Scripts/webkitpy/common/config/contributors.json:
1905
1906 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
1907
1908         Add tolerance to WebAudio tests
1909         https://bugs.webkit.org/show_bug.cgi?id=142676
1910
1911         Reviewed by Tim Horton.
1912
1913         * Scripts/webkitpy/common/wavediff.py: Added. Based on Jer Noble's work.
1914
1915         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1916         (TestResultWriter.create_audio_diff_and_write_result):
1917         * Scripts/webkitpy/layout_tests/models/test_failures.py:
1918         (FailureAudio.write_failure):
1919         * Scripts/webkitpy/port/base.py:
1920         (Port.do_audio_results_differ):
1921         Diff audio failures.
1922
1923         * Scripts/webkitpy/port/test.py: Added a test for the tolerance, fixed existing
1924         tests to use real parseable WAV data, and got rid of base64, which there didn't
1925         seem to have been any reason for.
1926
1927 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
1928
1929         [Mac] fast/forms/text-control-intrinsic-widths.html fails when MS Office is installed
1930         https://bugs.webkit.org/show_bug.cgi?id=142720
1931
1932         Reviewed by Myles C. Maxfield.
1933
1934         Activate system copies of Microsoft fonts for the current process, thus overriding
1935         any other ones that could be preferred by the system otherwise.
1936
1937         * DumpRenderTree/mac/DumpRenderTree.mm:
1938         (activateSystemCoreWebFonts):
1939         (adjustFonts):
1940         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1941         (WTR::activateSystemCoreWebFonts):
1942         (WTR::activateFonts):
1943
1944 2015-03-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1945
1946         Created Streams API watchlist
1947         https://bugs.webkit.org/show_bug.cgi?id=142684
1948
1949         Reviewed by Benjamin Poulain.
1950
1951         * Scripts/webkitpy/common/config/watchlist: Created StreamsAPI
1952         watchlist and added Benjamin, Youenn and me to it.
1953
1954 2015-03-15  Benjamin Poulain  <benjamin@webkit.org>
1955
1956         CSS: fix the case-insensitive matching of the attribute selectors Begin, End and Hyphen
1957         https://bugs.webkit.org/show_bug.cgi?id=142715
1958
1959         Reviewed by Brent Fulgham.
1960
1961         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1962         (TestWebKitAPI::TEST):
1963
1964 2015-03-15  Benjamin Poulain  <bpoulain@apple.com>
1965
1966         Change the exact attribute matching to be ASCII case-insensitive
1967         https://bugs.webkit.org/show_bug.cgi?id=142609
1968
1969         Reviewed by Darin Adler.
1970
1971         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1972         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1973
1974 2015-03-13  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1975
1976         WebKit test infrastructure should automate the process of cloning W3C test suite and importing tests from it
1977         https://bugs.webkit.org/show_bug.cgi?id=134764
1978
1979         Reviewed by Ryosuke Niwa.
1980
1981         TestDownloader is introduced to download W3C tests from the official
1982         W3C tests repositories (https://github.com/w3c/web-platform-tests.git
1983         and https://github.com/w3c/csswg-test.git).
1984         TestDownloader clones the repositories and checkouts revisions of the tests
1985         defined in LayoutTests/imported/w3c/resources/TestRepositories.
1986
1987         Similarly to https://codereview.chromium.org/148173016,
1988         TestDownloader copies part of the files based on the rules
1989         defined in LayoutTests/imported/w3c/resources/ImportExpectations.
1990
1991         TestDownloader is used by TestImporter when no source directory is provided.
1992
1993         * Scripts/webkitpy/w3c/test_downloader.py: Added.
1994         (TestDownloader):
1995         (TestDownloader.default_options):
1996         (TestDownloader.load_test_repositories):
1997         (TestDownloader.__init__):
1998         (TestDownloader.checkout_test_repository):
1999         (TestDownloader._init_paths_from_expectations):
2000         (TestDownloader._add_test_suite_paths):
2001         (TestDownloader._empty_directory):
2002         (TestDownloader.copy_tests):
2003         (TestDownloader.download_tests):
2004         * Scripts/webkitpy/w3c/test_importer.py:
2005         (main):
2006         (parse_args):
2007         (TestImporter.__init__):
2008         (TestImporter.do_import):
2009         (TestImporter.test_downloader):
2010         (TestImporter.find_importable_tests.should_keep_subdir):
2011         (TestImporter.should_convert_test_harness_links):
2012         (TestImporter.import_tests):
2013         (TestImporter.write_import_log):
2014
2015 2015-03-12  Alexey Proskuryakov  <ap@apple.com>
2016
2017         [Mavericks] Test snapshots are 1600x1200 on Retina devices
2018         https://bugs.webkit.org/show_bug.cgi?id=142630
2019
2020         Reviewed by Tim Horton.
2021
2022         * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::windowSnapshotImage):
2023         Removed an ifdef that disabled the fix on Mavericks.
2024
2025 2015-03-12  Csaba Osztrogonác  <ossy@webkit.org>
2026
2027         Remove isWK2 cruft from webkitdirs.pm after r170426
2028         https://bugs.webkit.org/show_bug.cgi?id=142618
2029
2030         Reviewed by Daniel Bates.
2031
2032         * Scripts/webkitdirs.pm:
2033         (isWK2): Deleted.
2034
2035 2015-03-12  Alexey Proskuryakov  <ap@apple.com>
2036
2037         testRunner.setAlwaysAcceptCookies does not work with NetworkProcess
2038         https://bugs.webkit.org/show_bug.cgi?id=138687
2039
2040         Reviewed by Carlos Garcia Campos.
2041
2042         Always change cookie policy from UI process, as changing it from WebProcess doesn't
2043         affect other processes.
2044
2045         The implementation is imperfect, because the change happens asynchronously, but I
2046         don't expect it to be a problem in practice.
2047
2048         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2049         (WTR::InjectedBundle::beginTesting):
2050         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2051         (WTR::TestRunner::setAlwaysAcceptCookies):
2052         * WebKitTestRunner/TestInvocation.cpp:
2053         (WTR::TestInvocation::invoke):
2054         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2055
2056 2015-03-12  Csaba Osztrogonác  <ossy@webkit.org>
2057
2058         [EFL] Enable building EFL 1.13 with NEON support
2059         https://bugs.webkit.org/show_bug.cgi?id=142619
2060
2061         Reviewed by Gyuyoung Kim.
2062
2063         * efl/jhbuild.modules:
2064
2065 2015-03-11  Alex Christensen  <achristensen@webkit.org>
2066
2067         [Content Extensions] Add resource type and load type triggers.
2068         https://bugs.webkit.org/show_bug.cgi?id=142422
2069
2070         Reviewed by Benjamin Poulain.
2071
2072         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2073         (TestWebKitAPI::testRequest):
2074         (TestWebKitAPI::mainDocumentRequest):
2075         (TestWebKitAPI::TEST_F):
2076         (TestWebKitAPI::testURL): Deleted.
2077
2078 2015-03-10  Sam Weinig  <sam@webkit.org>
2079
2080         Allow adding a button in input elements for auto fill related functionality
2081         <rdar://problem/19782066>
2082         https://bugs.webkit.org/show_bug.cgi?id=142564
2083
2084         Reviewed by Anders Carlsson.
2085
2086         * WebKitTestRunner/TestController.cpp:
2087         (WTR::TestController::createOtherPage):
2088         (WTR::TestController::createWebViewWithOptions):
2089         Update for new callback.
2090
2091 2015-03-11  Benjamin Poulain  <bpoulain@apple.com>
2092
2093         Add basic support for BOL and EOL assertions to the URL Filter parser
2094         https://bugs.webkit.org/show_bug.cgi?id=142568
2095
2096         Reviewed by Alex Christensen.
2097
2098         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2099         (TestWebKitAPI::TEST_F):
2100
2101 2015-03-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2102
2103         [GTK] Add support for handling TLS errors to MiniBrowser
2104         https://bugs.webkit.org/show_bug.cgi?id=142576
2105
2106         Reviewed by Sergio Villar Senin.
2107
2108         It's useful for testing TLS errors handling itself, but also to
2109         allow ignoring TLS errors when testing.
2110
2111         * MiniBrowser/gtk/BrowserWindow.c:
2112         (webViewLoadFailedWithTLSerrors):
2113         (browserWindowConstructed):
2114
2115 2015-03-11  Myles C. Maxfield  <mmaxfield@apple.com>
2116
2117         Use out-of-band messaging for RenderBox::firstLineBaseline() and RenderBox::inlineBlockBaseline()
2118         https://bugs.webkit.org/show_bug.cgi?id=142569
2119
2120         Reviewed by David Hyatt.
2121
2122         Test Optional::valueOrCompute().
2123
2124         * TestWebKitAPI/Tests/WTF/Optional.cpp:
2125         (TestWebKitAPI::TEST):
2126
2127 2015-03-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2128
2129         [GTK] Add an option to enable MiniBrowser for non developer builds and always install it
2130         https://bugs.webkit.org/show_bug.cgi?id=126688
2131
2132         Reviewed by Gustavo Noronha Silva.
2133
2134         * CMakeLists.txt: Build testing tools only for developer builds,
2135         but MiniBrowser when ENABLE_MINIBROWSER option is ON.
2136         * MiniBrowser/gtk/CMakeLists.txt: Only add
2137         -DWEBKIT_INJECTED_BUNDLE_PATH to the build for developer builds,
2138         and add a rule to install the MiniBrowser.
2139         * MiniBrowser/gtk/main.c:
2140         (main): Only set WEBKIT_INJECTED_BUNDLE_PATH env var for developer
2141         builds.
2142
2143 2015-03-11  Brent Fulgham  <bfulgham@apple.com>
2144
2145         Add some DateMath tests to TestWebKitAPI
2146         https://bugs.webkit.org/show_bug.cgi?id=142565
2147
2148         Reviewed by Alexey Proskuryakov.
2149
2150         * TestWebKitAPI/CMakeLists.txt: Add new DateMath.cpp file.
2151         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Ditto.
2152         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Ditto.
2153         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto."
2154         * TestWebKitAPI/Tests/WTF/DateMath.cpp: Added.
2155
2156 2015-03-10  Brent Fulgham  <bfulgham@apple.com>
2157
2158         Regression(r181257): WTF_WorkQueue.Simple is flaky
2159         https://bugs.webkit.org/show_bug.cgi?id=142560
2160
2161         Unreviewed attempt to improve test stability.
2162
2163         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Check the reference count for
2164         the WorkQueue a little later to redue flakiness.
2165
2166 2015-03-10  Myles C. Maxfield  <mmaxfield@apple.com>
2167
2168         Migrate from SystemUIFontSelect to AppleSystemFontOSSubversion
2169         https://bugs.webkit.org/show_bug.cgi?id=142555
2170
2171         Reviewed by Simon Fraser.
2172
2173         * DumpRenderTree/mac/DumpRenderTree.mm:
2174         (setDefaultsToConsistentValuesForTesting):
2175         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2176         (WTR::InjectedBundle::platformInitialize):
2177
2178 2015-03-10  Alex Christensen  <achristensen@webkit.org>
2179
2180         Use unsigned for HashSet size.
2181         https://bugs.webkit.org/show_bug.cgi?id=142518
2182
2183         Reviewed by Benjamin Poulain.
2184
2185         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2186         (TestWebKitAPI::TEST):
2187         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2188         (TestWebKitAPI::testInitialCapacity):
2189         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
2190         (TestWebKitAPI::TEST):
2191
2192 2015-03-10  Daniel Bates  <dabates@apple.com>
2193
2194         [iOS] Add WebKitSystemInterface for iOS 8.2
2195         https://bugs.webkit.org/show_bug.cgi?id=142505
2196
2197         Rubber-stamped by Anders Carlsson.
2198
2199         Make copy-webkitlibraries-to-product-directory install libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a.
2200         I inadvertently forgot to add libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a to script
2201         copy-webkitlibraries-to-product-directory in r181286.
2202
2203         * Scripts/copy-webkitlibraries-to-product-directory:
2204
2205 2015-03-10  Benjamin Poulain  <bpoulain@apple.com>
2206
2207         Extend URL filter's Term definition to support groups/subpatterns
2208         https://bugs.webkit.org/show_bug.cgi?id=142519
2209
2210         Reviewed by Alex Christensen.
2211
2212         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2213         (TestWebKitAPI::testURL):
2214
2215 2015-03-06  Jer Noble  <jer.noble@apple.com>
2216
2217         Add an option to run-webkit-tests to override the LayoutTests/ directory
2218         https://bugs.webkit.org/show_bug.cgi?id=142418
2219
2220         Reviewed by David Kilzer.
2221
2222         Add an arugment to run-webkit-tests which, when set, overrides the port's default LayoutTests
2223         directory. The base port will parse the options during initialization and store the override
2224         location if present. layout_tests_dir() will return this overridden location if set.
2225
2226         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2227         (parse_args):
2228         * Scripts/webkitpy/port/base.py:
2229         (Port.__init__):
2230         (Port.layout_tests_dir):
2231
2232 2015-03-09  Martin Robinson  <mrobinson@igalia.com>
2233
2234         [CMake] Enable WorkQueue tests for CMake ports
2235         https://bugs.webkit.org/show_bug.cgi?id=142473
2236
2237         Reviewed by Darin Adler.
2238
2239         * TestWebKitAPI/CMakeLists.txt: Add the WorkQueue tests source file to
2240         the list of source files.
2241         * Tools/TestWebKitAPI/PlatformEfl.cmake: Add the DispatchQueueEfl directory
2242         to the list of include directories for EFL.
2243
2244 2015-03-09  David Kilzer  <ddkilzer@apple.com>
2245
2246         Attempt to fix timeouts on iOS Simulator layout tests
2247
2248         * Scripts/webkitpy/port/ios.py:
2249         (IOSSimulatorPort.setup_test_run): Most layout test runs on iOS
2250         Simulator end after the first 50 tests time out.  Some analysis
2251         this past weekend shows that the 'Booted' status in the output
2252         of `xcrun simctl list` is not sufficient (and watching the test
2253         run shows that SpringBoard hasn't fully started to the point
2254         where it's displaying icons on the home screen).  The workaround
2255         until we have a better fix is to add an arbitrary timeout to let
2256         SpringBoard finish launching.  In practice, 15 seconds is
2257         probably enough, but 30 seconds should nearly always work.
2258
2259 2015-03-09  Per Arne Vollan  <peavo@outlook.com>
2260
2261         Unreviewed. Add myself as a committer.
2262
2263         * Scripts/webkitpy/common/config/contributors.json:
2264
2265 2015-03-09  David Kilzer  <ddkilzer@apple.com>
2266
2267         Attempt to fix WTF_WorkQueue.TwoQueues timeout test failure
2268
2269         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2270         (TestWebKitAPI::TEST): Change delay from 50ns to 50ms, and add
2271         an expectation that will fail if we hit the race condition.
2272         This test is inherently racy and will deadlock if the first job
2273         for queue2 takes the mutex lock before the second job for
2274         queue1.
2275
2276 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
2277
2278         [Win] WTF::WorkQueue does not balance ref/deref properly
2279         https://bugs.webkit.org/show_bug.cgi?id=142471
2280
2281         Reviewed by Antti Koivisto.
2282
2283         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2284         (TestWebKitAPI::TEST): Check that the refcount is correct.
2285
2286 2015-03-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2287
2288         Do not show passing test result on output of EFL layout test
2289         https://bugs.webkit.org/show_bug.cgi?id=142380
2290
2291         Reviewed by Darin Adler.
2292
2293         To show passing tests has caused inconvenience when we detect problem tests
2294         in output of layout test. So this patch applies '--debug-rwt-logging' except for EFL port
2295         in order not to show passing tests in the output of EFL layout test.
2296
2297         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2298         (RunWebKitTests.start):
2299
2300 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
2301
2302         Unreviewed build fix.
2303
2304         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2305         (TestWebKitAPI::TEST): Remove two unused variables.
2306
2307 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
2308
2309         Add some WorkQueue tests to TestWebKitAPI
2310         https://bugs.webkit.org/show_bug.cgi?id=142447
2311
2312         Reviewed by Sam Weinig.
2313
2314         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2315         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
2316         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2317         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Added.
2318         (TestWebKitAPI::simpleTest):
2319         (TestWebKitAPI::longTest):
2320         (TestWebKitAPI::thirdTest):
2321         (TestWebKitAPI::finishedTests):
2322         (TestWebKitAPI::TEST):
2323         (TestWebKitAPI::longTest2):
2324
2325 2015-03-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2326
2327         Remove willDestroyFrame in WKBundlePageLoaderClient
2328         https://bugs.webkit.org/show_bug.cgi?id=142389
2329
2330         Reviewed by Anders Carlsson.
2331
2332         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2333         (WTR::InjectedBundlePage::InjectedBundlePage):
2334
2335 2015-03-07  Brent Fulgham  <bfulgham@apple.com>
2336
2337         [Win] Increase TestWebKitAPI Test Coverage[Win] Increase TestWebKitAPI Test Coverage
2338         https://bugs.webkit.org/show_bug.cgi?id=142433
2339
2340         Reviewed by Darin Adler.
2341
2342         Include more TestWebKitAPI tests when building for Windows. Also
2343         fix a build error in MetaAllocator.cpp caused by one of the
2344         Microsoft headers #defining 'small'.
2345
2346         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2347         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
2348         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
2349
2350 2015-03-06  Sam Weinig  <sam@webkit.org>
2351
2352         [Content Extensions] Move compiling of content extensions to the UIProcess
2353         https://bugs.webkit.org/show_bug.cgi?id=142402
2354
2355         Reviewed by Benjamin Poulain.
2356
2357         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2358         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: Copied from Tools/TestWebKitAPI/Tests/WebCore/ContentFilter.cpp.
2359         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
2360         (TestWebKitAPI::InMemoryCompiledContentExtension::~InMemoryCompiledContentExtension):
2361         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
2362         (TestWebKitAPI::TEST_F):
2363         * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Removed.
2364         Update test for new name (ContentFilter -> ContentExtensions) and API (CompiledContentExtension
2365         is now abstract).
2366
2367 2015-03-06  Brent Fulgham  <bfulgham@apple.com>
2368
2369         [Win] Correct Windows build.
2370
2371         Rubberstamped by Michael Saboff
2372
2373         * win/AssembleBuildLogs/AssembleLogs.cmd: Correct cut/paste error
2374         in the GOTO labels.
2375
2376 2015-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2377
2378         [GTK] Test /webkit2/WebKitWebView/sync-request-on-max-conns might fail after finished
2379         https://bugs.webkit.org/show_bug.cgi?id=142385
2380
2381         Reviewed by Sergio Villar Senin.
2382
2383         Use stack allocated GMainLoopSources to make sure they are
2384         cancelled automatically if the test finishes before they have
2385         been processed.
2386
2387         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2388         (testWebViewSyncRequestOnMaxConns):
2389
2390 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
2391
2392         Remove Mountain Lion libraries since ML isn't supported
2393         https://bugs.webkit.org/show_bug.cgi?id=142332
2394
2395         Reviewed by Darin Adler.
2396
2397         * Scripts/copy-webkitlibraries-to-product-directory:
2398
2399 2015-03-06  Carlos Alberto Lopez Perez <clopez@igalia.com> and Youenn Fablet  <youenn.fablet@crf.canon.fr>
2400
2401         Layout tests imported/w3c/web-platform-tests certificates should not be tracked on WebKit VCS
2402         https://bugs.webkit.org/show_bug.cgi?id=142083
2403
2404         Reviewed by Simon Fraser.
2405
2406         Modifying on the fly wpt config.json to set the directory where to generate/read certificates as a subfolder of the layout test results folder.
2407
2408         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2409         (WebPlatformTestServer._copy_webkit_test_files):
2410
2411 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
2412
2413         setup-git-clone fails due to the failure to download python-irclib-0.4.8
2414         https://bugs.webkit.org/show_bug.cgi?id=141946
2415
2416         Reviewed by Ryosuke Niwa.
2417
2418         Check in ircbot.py and irclib.py to avoid network problems in the future.
2419
2420         * Scripts/webkitpy/common/net/irc/ircbot.py:
2421         * Scripts/webkitpy/thirdparty/__init__.py:
2422         (AutoinstallImportHook.find_module):
2423         (AutoinstallImportHook._install_irc): Deleted.
2424         * Scripts/webkitpy/thirdparty/__init___unittest.py:
2425         (ThirdpartyTest.test_imports):
2426         * Scripts/webkitpy/thirdparty/irc/__init__.py: Added.
2427         * Scripts/webkitpy/thirdparty/irc/ircbot.py: Added.
2428         * Scripts/webkitpy/thirdparty/irc/irclib.py: Added.
2429
2430 2015-03-06  David Kilzer  <ddkilzer@apple.com>
2431
2432         Dashboard: Perf bot status is missing for Apple {Mavericks,Yosemite} Release builds
2433
2434         See also fix to config.json in r181097.
2435
2436         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2437         (WebKitBuildbot): Add missing "WK2" to the names of the perf
2438         bots.
2439
2440 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
2441
2442         run-jsc-stress-tests should determine the architecture from ELF binaries
2443         https://bugs.webkit.org/show_bug.cgi?id=142335
2444
2445         Reviewed by Darin Adler.
2446
2447         * Scripts/run-jsc-stress-tests:
2448
2449 2015-03-05  David Kilzer  <ddkilzer@apple.com>
2450
2451         [iOS] TestExpectations for ios-simulator-wk2 should fall back to 'wk2' after 'ios-simulator'
2452         <http://webkit.org/b/142226>
2453
2454         Reviewed by Darin Adler.
2455
2456         * Scripts/webkitpy/port/ios.py:
2457         (IOSSimulatorPort.default_baseline_search_path): Switch the
2458         TestExpectations order of ios-simulator-wk2 from this:
2459           ios-simulator-wk2, wk2, ios-simulator
2460         To this:
2461           ios-simulator-wk2, ios-simualtor, wk2
2462
2463 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
2464
2465         [Win] Provide tiered logging from MSBuild -- Errors on top, Warnings after
2466         https://bugs.webkit.org/show_bug.cgi?id=142370
2467
2468         Reviewed by Dean Jackson.
2469
2470         * Scripts/webkitdirs.pm:
2471         (buildVisualStudioProject): Tell MSBuild to output log files to two separate
2472         logs, one for warnings, the other for errors.
2473         * win/AssembleBuildLogs/AssembleLogs.cmd: Combine the error and warning logs
2474         into the standard BuildOutput.htm document.
2475
2476 2015-03-05  David Kilzer  <ddkilzer@apple.com>
2477
2478         Dashboard has trouble parsing iOS test output
2479         <http://webkit.org/b/142364>
2480
2481         Reviewed by Alex Christensen.
2482
2483         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
2484         (BuildbotTestResults.prototype._parseResults.resultSummarizer):
2485         Add fallback path to build a regex using 'matchString' so that
2486         it matches anywhere in the line.  In practice, 'matchString' is
2487         a prefix for the label following the number.
2488
2489 2015-03-05  Alex Christensen  <achristensen@webkit.org>
2490
2491         Fix linker warnings in TestWebKitAPI.
2492         https://bugs.webkit.org/show_bug.cgi?id=141912
2493
2494         Reviewed by David Kilzer.
2495
2496         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2497         Do not export TearDownTestCase or SetUpTestCase symbols.
2498
2499 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
2500
2501         [Win] Unreviewed EWS fix.
2502
2503         * Scripts/webkitdirs.pm:
2504         (buildVisualStudioProject): Dial logging back to 'ErrorsOnly' to see if that makes
2505         the EWS output more usable.
2506
2507 2015-03-05  Chris Dumez  <cdumez@apple.com>
2508
2509         Regression(r173761): ASSERTION FAILED: !is8Bit() in StringImpl::characters16()
2510         https://bugs.webkit.org/show_bug.cgi?id=142350
2511
2512         Reviewed by Michael Saboff and Benjamin Poulain.
2513
2514         Add API test for WTFString::hasInfixStartingAt() to make sure it doesn't
2515         crash if the string is 8-bit but the pattern is 16-bit (and vice-versa).
2516
2517         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2518         (TestWebKitAPI::TEST):
2519
2520 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
2521
2522         [Win] Ensure build target directory exists when launching MSBuild
2523         https://bugs.webkit.org/show_bug.cgi?id=142360
2524
2525         Reviewed by Dean Jackson.
2526
2527         Create the build output directory (if it doesn't exist) before
2528         launching MSBuild so that it can immediately begin writing logs.
2529
2530         * Scripts/webkitdirs.pm:
2531         (buildVisualStudioProject):
2532
2533 2015-03-05  Chris Dumez  <cdumez@apple.com>
2534
2535         run-webkit-tests and run-perf-tests should use WebKitTestRunner by default
2536         https://bugs.webkit.org/show_bug.cgi?id=142325
2537
2538         Reviewed by Csaba Osztrogonác.
2539
2540         run-webkit-tests and run-perf-tests now use WebKitTestRunner by default.
2541         As a result, "--webkit-test-runner / -2" parameters are replaced by
2542         "--dump-render-tree / -1" so developers can run DumpRenderTree rather
2543         than WebKitTestRunner.
2544
2545         * BuildSlaveSupport/build.webkit.org-config/config.json:
2546         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2547         (RunWebKit1Tests):
2548         (RunWebKit1Tests.start):
2549         (RunWebKit1LeakTests):
2550         (RunWebKit1LeakTests.start):
2551         (RunAndUploadPerfTestsWebKit1):
2552         (RunAndUploadPerfTestsWebKit1.start):
2553         (TestFactory):
2554         (TestWebKit1LeaksFactory):
2555         (TestWebKit1LeaksFactory.__init__):
2556         (TestWebKit1Factory):
2557         (TestWebKit1AllButJSCFactory):
2558         (TestAllButJSCFactory):
2559         (BuildAndPerfTestWebKit1Factory):
2560         (BuildAndPerfTestWebKit1Factory.__init__):
2561         (BuildAndPerfTestFactory):
2562         (BuildAndPerfTestFactory.__init__):
2563         (DownloadAndPerfTestWebKit1Factory):
2564         (DownloadAndPerfTestWebKit1Factory.__init__):
2565         (DownloadAndPerfTestFactory):
2566         (DownloadAndPerfTestFactory.__init__):
2567         (RunWebKitLeakTests): Deleted.
2568         (RunWebKitLeakTests.start): Deleted.
2569         (RunWebKit2Tests): Deleted.
2570         (RunWebKit2Tests.start): Deleted.
2571         (RunAndUploadPerfTestsWebKit2): Deleted.
2572         (RunAndUploadPerfTestsWebKit2.start): Deleted.
2573         (TestLeaksFactory): Deleted.
2574         (TestLeaksFactory.__init__): Deleted.
2575         (TestWebKit2Factory): Deleted.
2576         (TestWebKit2AndJSCFactory): Deleted.
2577         (BuildAndPerfTestWebKit2Factory): Deleted.
2578         (BuildAndPerfTestWebKit2Factory.__init__): Deleted.
2579         (DownloadAndPerfTestWebKit2Factory): Deleted.
2580         (DownloadAndPerfTestWebKit2Factory.__init__): Deleted.
2581         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2582         (parse_args):
2583         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2584         (PerfTestsRunner._parse_args):
2585         * Scripts/webkitpy/port/port_testcase.py:
2586         (PortTestCase.test_build_driver):
2587
2588 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
2589
2590         [Win] Switch to MSBuild so we get more useful stdout logging in buildbot
2591         https://bugs.webkit.org/show_bug.cgi?id=140845
2592
2593         Reviewed by David Kilzer.
2594
2595         Update 'webkitdirs.pm' to locate the MSBuild used with Visual Studio 2013
2596         and generate suitable build commands to drive a full build from our
2597         existing solution files.
2598
2599         * Scripts/webkitdirs.pm:
2600         (msBuildInstallDir): Added.
2601         (determineConfigurationForVisualStudio): Revise to use MSBuild command
2602         line arguments to drive the build.
2603         (setupCygwinEnv): Warn user if MSBuild cannot be located.
2604         (buildVisualStudioProject): Revise to use MSBuild command line arguments
2605         to specify build architecture.
2606         * win/AssembleBuildLogs/AssembleLogs.cmd: MSBuild doesn't produce individual
2607         output logs, so don't attempt to consolidate them. Also: Drive-by fix: Don't
2608         bother looking for CoreUI or SafariTheme build logs.
2609
2610 2015-03-05  Csaba Osztrogonác  <ossy@webkit.org>
2611
2612         [buildbot] mastercfg_unittest.py should be runnable easily
2613         https://bugs.webkit.org/show_bug.cgi?id=142219
2614
2615         Reviewed by Chris Dumez.
2616
2617         Buildbot 0.8.6p1 runs on build.webkit org with Twisted 12.1.0, which is
2618         the last Twisted version works together with this buildbot version.
2619
2620         * Scripts/webkitpy/common/system/autoinstall.py:
2621         (AutoInstaller): Added prepend_to_search_path argument to be able
2622         to prefer autoinstalled package to system package.
2623         (AutoInstaller.__init__):
2624         (AutoInstaller._set_up_target_dir):
2625         (AutoInstaller._extract_tar): Renamed from _extract_targz, now it works with tar.bz2 too.
2626         (AutoInstaller._prepare_package):
2627         (AutoInstaller._extract_targz): Renamed to _extract_tar.
2628         * Scripts/webkitpy/thirdparty/__init__.py:
2629         (AutoinstallImportHook._install_buildbot): Autoinstall Twisted 12.1.0.
2630
2631 2015-03-05  Lukasz Bialek  <l.bialek@samsung.com>
2632
2633         [EFL][WK2] Crash when "Download Linked File" from MiniBrowser context menu is clicked
2634         https://bugs.webkit.org/show_bug.cgi?id=131162
2635
2636         Reviewed by Gyuyoung Kim.
2637
2638         * MiniBrowser/efl/main.c:
2639         (on_download_request):
2640         (on_download_finished):
2641         (on_download_failed):
2642         (window_create):
2643         Adapt download callbacks to new callback mechanism
2644
2645 2015-03-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2646
2647         Unreviewed. Fix /webkit2/WebKitWebResource/mime-type after r180927.
2648
2649         In r180927 we updated the libsoup version used by the jhbuild. In
2650         this new version the sniffer uses image/x-icon instead of
2651         image/vnd.microsoft.icon for blank.ico resource.
2652
2653         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2654         (testWebResourceMimeType):
2655
2656 2015-03-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2657
2658         [SOUP] Check TLS errors as soon as they are set in the SoupMessage
2659         https://bugs.webkit.org/show_bug.cgi?id=142244
2660
2661         Reviewed by Sergio Villar Senin.
2662
2663         Check that the SSL server doesn't process any request in case of
2664         TLS errors when the policy is set to FAIL.
2665
2666         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
2667         (testTLSErrorsPolicy):
2668         (testTLSErrorsRedirect):
2669         (testTLSErrorsHTTPAuth):
2670         (testLoadFailedWithTLSErrors):
2671         (testSubresourceLoadFailedWithTLSErrors):
2672         (httpsServerCallback):
2673
2674 2015-03-05  Pawel Forysiuk  <p.forysiuk@samsung.com>
2675
2676         [EFL] REGRESSION (r178685): ASSERTION FAILED: !parameters.mediaKeyStorageDirectory.isEmpty()
2677         https://bugs.webkit.org/show_bug.cgi?id=141154
2678
2679         Reviewed by Jer Noble.
2680
2681         Unlike GTK, EFL port enables ENABLE_ENCRYPTED_MEDIA_V2 build option by default.
2682
2683         For the sake of completeness WebKitTestRunner should specify temporary
2684         folder for MediaKeysStorageDirecory as well as IndexedDB, LocalStorage, etc.
2685
2686         Default non legacy paths are set up in ProcessPoolConfiguration constructor.
2687         They use WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation
2688         to get data storage paths. Only Mac port has an actual implementation of it.
2689         However, WebKitTestRunner overrides them in favour of unique temporary dir
2690         which is taken from libraryPathForTesting().
2691
2692         Since WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation
2693         is not implemented for EFL and GTK ports it returns an empty string.
2694         All default data folders besides MediaKeys are overridden in TestRunner
2695         code with unique temporary folders derived from DUMPRENDERTREE_TEMP
2696         env variable.
2697
2698         GTK port does not enable encrypted keys by default so
2699         WebMediaKeyStorageManager::initialize() code path is never triggered.
2700
2701         * WebKitTestRunner/TestController.cpp:
2702         (WTR::TestController::initialize): Set MediaKeysStorageDirectory for all
2703         WebKit ports.
2704
2705 2015-03-05  Csaba Osztrogonác  <ossy@webkit.org>
2706
2707         [buildbot] Add regression test to check which builder runs which tests
2708         https://bugs.webkit.org/show_bug.cgi?id=142166
2709
2710         Reviewed by Alexey Proskuryakov.
2711
2712         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2713         (BuildStepsConstructorTest.createTest):
2714         (BuildStepsTest):
2715         (BuildStepsTest.generateTests):
2716         (BuildStepsTest.createTest):
2717         (BuildStepsTest.createTest.doTest):
2718         (BuildStepsTest.test_unnecessary_expected_results):
2719
2720 2015-03-04  Commit Queue  <commit-queue@webkit.org>
2721
2722         Unreviewed, rolling out r181054.
2723         https://bugs.webkit.org/show_bug.cgi?id=142320
2724
2725         Broke the api tests (Requested by sundiamonde on #webkit).
2726
2727         Reverted changeset:
2728
2729         "Fix linker warnings in TestWebKitAPI."
2730         https://bugs.webkit.org/show_bug.cgi?id=141912
2731         http://trac.webkit.org/changeset/181054
2732
2733 2015-03-04  Alex Christensen  <achristensen@webkit.org>
2734
2735         Fix linker warnings in TestWebKitAPI.
2736         https://bugs.webkit.org/show_bug.cgi?id=141912
2737
2738         Reviewed by David Kilzer.
2739
2740         * TestWebKitAPI/Configurations/Base.xcconfig:
2741         Use GCC_SYMBOLS_PRIVATE_EXTERN like we do in WebCore.
2742
2743 2015-03-04  Alexey Proskuryakov  <ap@apple.com>
2744
2745         [Mac] Set SystemUIFontSelect in DRT and WKTR
2746         https://bugs.webkit.org/show_bug.cgi?id=142303
2747
2748         Reviewed by Myles C. Maxfield.
2749
2750         * DumpRenderTree/mac/DumpRenderTree.mm:
2751         (setDefaultsToConsistentValuesForTesting):
2752         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2753         (WTR::InjectedBundle::platformInitialize):
2754
2755 2015-03-04  Chris Dumez  <cdumez@apple.com>
2756
2757         Mac Perf bots should use WebKitTestRunner instead of DumpRenderTree
2758         https://bugs.webkit.org/show_bug.cgi?id=142314
2759         <rdar://problem/20046835>
2760
2761         Reviewed by Ryosuke Niwa.
2762
2763         Mac Perf bots should use WebKitTestRunner instead of DumpRenderTree
2764         to get WK2 code coverage.
2765
2766         * BuildSlaveSupport/build.webkit.org-config/config.json:
2767
2768 2015-03-04  Alex Christensen  <achristensen@webkit.org>
2769
2770         Move content extensions test to properly named directory.
2771         https://bugs.webkit.org/show_bug.cgi?id=142299
2772
2773         Reviewed by Tim Horton.
2774
2775         * WebKitTestRunner/mac/TestControllerMac.mm:
2776         (WTR::TestController::platformConfigureViewForTest):
2777
2778 2015-03-04  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2779
2780         W3C test importer should use filesystem instead of os.walk
2781         https://bugs.webkit.org/show_bug.cgi?id=142085
2782
2783         Reviewed by Bem Jones-Bey.
2784
2785         Added FileSystem.dirs_under to remove the use of os.walk in test importer.
2786         Added MockFileSystem.dirs_under and MockFileSystem.getsize to enable unit testing of test importer.
2787         Added unit test for FileSystem.dirs_under and MockFileSystem.dirs_under.
2788
2789         Made use of FileSystem.dirs_under within TestImporter.find_importable_tests.
2790         Added a unit test to check that test importer is now black-box testable using a Mock system.
2791
2792         * Scripts/webkitpy/common/system/filesystem.py:
2793         (FileSystem.dirs_under): Returns a list of filtered sub-directories.
2794         (FileSystem.dirs_under.filter_all):
2795         * Scripts/webkitpy/common/system/filesystem_mock.py:
2796         (MockFileSystem.dirs_under):
2797         (MockFileSystem.dirs_under.filter_all):
2798         (MockFileSystem.getsize):
2799         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
2800         (MockFileSystemTest.test_dirs_under):
2801         (MockFileSystemTest.test_dirs_under.filter_dir):
2802         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2803         (RealFileSystemTest.test_sep):
2804         (RealFileSystemTest):
2805         (RealFileSystemTest.test_dirs_under):
2806         (RealFileSystemTest.test_dirs_under.filter_this_dir):
2807         * Scripts/webkitpy/w3c/test_importer.py:
2808         (TestImporter.do_import):
2809         (TestImporter.find_importable_tests.should_keep_subdir):
2810         (TestImporter.find_importable_tests):
2811         (TestImporter.should_keep_subdir): Deleted.
2812         (TestImporter.should_skip_file): Deleted.
2813         * Scripts/webkitpy/w3c/test_importer_unittest.py:
2814         (TestImporterTest.test_import_dir_with_empty_init_py): Added test to ensure empty __init__.py are no longer empty once imported.
2815
2816 2015-03-04  Timothy Horton  <timothy_horton@apple.com>
2817
2818         [WebEditingTester] Add support for the find and replace bar
2819         https://bugs.webkit.org/show_bug.cgi?id=142247
2820
2821         Reviewed by Enrica Casucci.
2822
2823         While it's not hooked up yet in WKWebView, adding support for the
2824         find bar to WebEditingTester will help us implement that functionality.
2825
2826         * WebEditingTester/AppDelegate.h:
2827         * WebEditingTester/AppDelegate.m:
2828         (-[WebEditingAppDelegate performTextFinderAction:]):
2829         * WebEditingTester/MainMenu.xib:
2830         Receive performTextFinderAction: and forward it to the frontmost WebDocumentController.
2831
2832         * WebEditingTester/WK2WebDocumentController.m:
2833         (-[WK2WebDocumentController awakeFromNib]):
2834         (-[WK2WebDocumentController performTextFinderAction:]):
2835         (-[WK2WebDocumentController findBarView]):
2836         (-[WK2WebDocumentController setFindBarView:]):
2837         (-[WK2WebDocumentController isFindBarVisible]):
2838         (-[WK2WebDocumentController setFindBarVisible:]):
2839         (-[WK2WebDocumentController findBarViewDidChangeHeight]):
2840         (-[WK2WebDocumentController layout]):
2841         Implement performTextFinderAction: for WebKit2, and have a NSTextFinder
2842         pointing at the WKWebView (currently nothing will work, but the bar will
2843         show up). Install and uninstall the bar as needed.
2844
2845         * WebEditingTester/WebDocument.xib:
2846         Don't use a full-size content view. There's no need, and it makes find
2847         bar layout harder.
2848
2849         * WebEditingTester/WebDocumentController.h:
2850         * WebEditingTester/WebDocumentController.m:
2851         (-[WebDocumentController performTextFinderAction:]):
2852
2853 2015-03-03  Sam Weinig  <sam@webkit.org>
2854
2855         [Content Extensions] Split parsing and compiling of content extensions into their own files
2856         https://bugs.webkit.org/show_bug.cgi?id=142259
2857
2858         Reviewed by Anders Carlsson.
2859
2860         Add basic unit test for the content filter compiler.
2861
2862         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2863         * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Added.
2864         (WebCore::ContentExtensions::operator<<):
2865         (TestWebKitAPI::ContentFilterTest::SetUp):
2866         (TestWebKitAPI::TEST_F):
2867
2868 2015-03-04  Matthew Mirman  <mmirman@apple.com>
2869
2870         Cleaned up BuildAndTestFactory to not be a near duplicate of TestFactory
2871         https://bugs.webkit.org/show_bug.cgi?id=142230
2872
2873         Reviewed by Csaba Osztrogonác.
2874
2875         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2876         (TestFactory):
2877         (TestFactory.getProduct): Added
2878         (TestFactory.__init__): moved downloader to getProduct
2879         (BuildAndTestFactory):        
2880         (BuildAndTestFactory.getProduct): Added
2881         (BuildAndTestFactory.__init__): made to call TestFactory.__init__ and append steps to the end.
2882         (BuildAndTestWebKit2Factory): Deleted.  Wasn't used anywhere.
2883
2884 2015-03-04  Debarshi Ray  <debarshir@gnome.org>
2885
2886         [GTK] WebView should hold a reference on WebContext because non-default contexts are a reality
2887         https://bugs.webkit.org/show_bug.cgi?id=142225
2888
2889         Reviewed by Carlos Garcia Campos.
2890
2891         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2892         (testWebViewWebContextLifetime):
2893         (beforeAll):
2894
2895 2015-03-03  David Kilzer  <ddkilzer@apple.com>
2896
2897         [iOS] Crash logs can't be found on ios-simulator because WebKitTestRunner returns the wrong process name
2898         <http://webkit.org/b/142243>
2899
2900         Reviewed by Alexey Proskuryakov.
2901
2902         * WebKitTestRunner/TestController.cpp:
2903         (WTR::TestController::webProcessName):
2904         (WTR::TestController::networkProcessName):
2905         - Return the same process name on iOS and Mac because they both
2906           use the same process name for local engineering builds.
2907
2908 2015-03-03  David Kilzer  <ddkilzer@apple.com>
2909
2910         check-webkit-style: Add exception for FrameworkSoftLink.h header order
2911         <http://webkit.org/b/141872>
2912
2913         Reviewed by Alex Christensen.
2914
2915         * Scripts/webkitpy/style/checkers/cpp.py: Remove unneeded
2916         semi-colons in various places and fix whitespace.
2917         (_IncludeState): Add _SOFT_LINK_HEADER and _SOFT_LINK_SECTION
2918         constants.
2919         (_IncludeState.__init__): Add self._visited_soft_link_section
2920         boolean state variable.
2921         (_IncludeState.visited_soft_link_section): Getter for
2922         self._visited_soft_link_section.
2923         (_IncludeState.check_next_include_order): Update state machine
2924         for soft-link headers.  Add check that soft-link headers always
2925         appear last.
2926         (_classify_include): Add check for soft-link header type.
2927         (check_include_line): Return early if there is a soft-link
2928         header error.
2929
2930         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2931         (OrderOfIncludesTest.test_public_primary_header): Add tests for
2932         including soft-link headers.
2933         (OrderOfIncludesTest.test_classify_include): Add test for
2934         _SOFT_LINK_HEADER type.
2935
2936 2015-03-03  Alexey Proskuryakov  <ap@apple.com>
2937
2938         build.webkit.org/dashboard: Don't repeatedly handle each test type
2939         https://bugs.webkit.org/show_bug.cgi?id=142211
2940
2941         Reviewed by Tim Horton and Matt Hanson.
2942
2943         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2944         (Buildbot.prototype.javascriptTestResultsURLForIteration): Deleted.
2945         (Buildbot.prototype.apiTestResultsURLForIteration): Deleted.
2946         (Buildbot.prototype.platformAPITestResultsURLForIteration): Deleted.
2947         (Buildbot.prototype.webkitpyTestResultsURLForIteration): Deleted.
2948         (Buildbot.prototype.webkitperlTestResultsURLForIteration): Deleted.
2949         (Buildbot.prototype.bindingsTestResultsURLForIteration): Deleted.
2950         Removed functions that build a link to test step results. The buildbot provides
2951         these links in JSON.
2952
2953         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2954         (BuildbotIteration): Put failing tests into an array, instead of named variables.
2955         (BuildbotIteration.ProductiveSteps): Removed step names that are not used on build.webkit.org.
2956         We can easily add them to the map as needed.
2957         (BuildbotIteration.TestSteps): Added a list of test steps to be displayed by test queues.
2958         (BuildbotIteration.prototype._parseData): Moved code for parsing step results away
2959         to BuildbotTestResults class. We used to parse here, build an intermediate data structure,
2960         and then build a BuildbotTestResults object, which was strange.
2961         (BuildbotIteration.prototype.loadLayoutTestResults): Ditto.
2962
2963         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2964         Corrected an unrelated assertion that was buggy, and kept firing.
2965
2966         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
2967         (BuildbotTestResults):
2968         (BuildbotTestResults.prototype._parseResults.resultSummarizer):
2969         (BuildbotTestResults.prototype._parseResults):
2970         (BuildbotTestResults.prototype.addFullLayoutTestResults):
2971         Moved the code for parsing JSON results for a single step here.
2972
2973         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2974         (BuildbotTesterQueueView.prototype._testStepFailureDescription):
2975         (BuildbotTesterQueueView.prototype._testStepFailureDescriptionWithCount):
2976         (BuildbotTesterQueueView.prototype._presentPopoverForGenericTestFailures):
2977         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Deleted.
2978         (BuildbotTesterQueueView.prototype.update): Deleted.
2979         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds): Deleted.
2980         Updated for the new data structures. One behavior change is that we now display individual
2981         counts when multiple test kinds fail, e.g. "1 javascript test failure, 83+ layout
2982         test failures, 3 platform api test failures".
2983
2984 2015-03-03  Matthew Mirman  <mmirman@apple.com>
2985
2986         JSC tests should not be repeated twice for each branch builder, and should if possible have their own queue.
2987         https://bugs.webkit.org/show_bug.cgi?id=142094
2988
2989         Reviewed by Csaba Osztrogonác.
2990
2991         * BuildSlaveSupport/build.webkit.org-config/config.json: Added bots 155 and 157
2992         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2993         (TestFactory):
2994         (TestFactory.__init__): Made running of JSC tests conditional.
2995         (TestAllButJSCFactory):
2996         (TestJSCFactory): Added.
2997         (TestJSCFactory.__init__):
2998         (TestWebKit2AndJSCFactory): Added factory to not run JSC tests on WebKit2.
2999
3000 2015-03-03  David Kilzer  <ddkilzer@apple.com>
3001
3002         `build-webkit --help` is wrong about how to build for the iOS simulator
3003         <http://webkit.org/b/142223>
3004
3005         Reviewed by Csaba Osztrogonác.
3006
3007         * Scripts/build-webkit: Fix help.
3008
3009 2015-03-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3010
3011         Unreviewed. Bump libsoup version to 2.49.91.1 to fix 32 bit build.
3012
3013         * gtk/jhbuild.modules:
3014
3015 2015-03-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3016
3017         [SOUP] Synchronous XMLHttpRequests can time out when we reach the max connections limit
3018         https://bugs.webkit.org/show_bug.cgi?id=141508
3019
3020         Reviewed by Sergio Villar Senin.
3021
3022         Add a unit test to check that synchronous XHRs load even if the
3023         maximum connection limits are reached.
3024
3025         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
3026         (testWebViewSyncRequestOnMaxConns):
3027         (serverCallback):
3028         (beforeAll):
3029         * gtk/jhbuild.modules: Bump libsoup version to 2.49.91.
3030
3031 2015-03-02  Alexey Proskuryakov  <ap@apple.com>
3032
3033         Update the name of ASan build step.
3034
3035         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3036
3037 2015-03-02  Jer Noble  <jer.noble@apple.com>
3038
3039         [WK1][WK2][Mac] Fullscreen animation is incorrect when page is scaled.
3040         https://bugs.webkit.org/show_bug.cgi?id=142121
3041
3042         Reviewed by Simon Fraser.
3043
3044         Add a test which changes the WebView's page scale, then enters fullscreen mode, and verifies
3045         that the initial and final screen rects for the web content are as expected.
3046
3047         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3048         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.html: Added.
3049         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm: Added.
3050         (-[FullscreenStateDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
3051         (runJavaScriptAlert):
3052         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
3053         (TestWebKitAPI::FullscreenZoomInitialFrame::teardownView):
3054         (TestWebKitAPI::FullscreenZoomInitialFrame::setPageScale):
3055         (TestWebKitAPI::FullscreenZoomInitialFrame::sendMouseDownEvent):
3056         (TestWebKitAPI::FullscreenZoomInitialFrame::runTest):
3057         (TestWebKitAPI::TEST_F):
3058
3059 2015-03-01  David Kilzer  <ddkilzer@apple.com>
3060
3061         LayoutTestRealy: Prepend __XPC_ to the key, not the value!
3062
3063         Follow-up fix for:
3064
3065         LayoutTestRelay: App environment variables not set for --guard-malloc or --leaks
3066         <http://webkit.org/b/142145>
3067
3068         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3069         (-[LTRelayController _environmentVariables]): Fix think-o.
3070
3071 2015-03-01  David Kilzer  <ddkilzer@apple.com>
3072
3073         LayoutTestRelay: App environment variables not set for --guard-malloc or --leaks
3074         <http://webkit.org/b/142145>
3075
3076         Reviewed by Simon Fraser.
3077
3078         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3079         (-[LTRelayController _environmentVariables]): Add.
3080         (-[LTRelayController launchApp]): Use -_environmentVariables.
3081
3082 2015-02-28  David Kilzer  <ddkilzer@apple.com>
3083
3084         [iOS] Stop running webkit-build-directory on every layout test
3085
3086         This was originally fixed by David Farler for Bug 135409 in
3087         r172602.
3088
3089         * Scripts/webkitpy/port/ios.py:
3090         (IOSSimulatorPort.relay_path): Mark as @memoized so it doesn't
3091         run webkit-build-directory every time it's called.
3092
3093 2015-02-28  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3094
3095         W3C importer should use filesystem instead of shutil/host
3096         https://bugs.webkit.org/show_bug.cgi?id=142012
3097
3098         Reviewed by Bem Jones-Bey.
3099
3100         Removed direct use of python shutil and os, except for os.walk which will require its own fix.
3101
3102         * Scripts/webkitpy/w3c/test_importer.py:
3103         (main):
3104         (TestImporter.do_import):
3105         (TestImporter.find_importable_tests):
3106         (TestImporter.import_tests):
3107         (TestImporter.remove_deleted_files):
3108         (TestImporter.write_import_log):
3109
3110 2015-02-28  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3111
3112         W3C test importer should use filesystem to read and write files
3113         https://bugs.webkit.org/show_bug.cgi?id=142084
3114
3115         Reviewed by Bem Jones-Bey.
3116
3117         Use of FileSystem.write_binary_file, read_text_file and write_text_file in lieu of open().
3118
3119         * Scripts/webkitpy/w3c/test_importer.py:
3120         (TestImporter.import_tests):
3121         (TestImporter.remove_deleted_files):
3122         (TestImporter.write_import_log):
3123
3124 2015-02-27  Sam Weinig  <sam@webkit.org>
3125
3126         Add WebKit2 SPI to create a DOM File object
3127         https://bugs.webkit.org/show_bug.cgi?id=142109
3128
3129         Reviewed by Tim Horton.
3130
3131         Add a test for WKBundleFileHandleRef.
3132
3133         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3134         * TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle.cpp: Added.
3135         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
3136         (TestWebKitAPI::didFinishLoadForFrame):
3137         (TestWebKitAPI::TEST):
3138         * TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle_Bundle.cpp: Added.
3139         (TestWebKitAPI::WKBundleFileHandleTest::WKBundleFileHandleTest):
3140         * TestWebKitAPI/Tests/WebKit2/bundle-file.html: Added.
3141
3142 2015-02-27  Michael Saboff  <msaboff@apple.com>
3143
3144         Add ability for run-jsc-benchmarks to set library path from test binary when run on a build bot
3145         https://bugs.webkit.org/show_bug.cgi?id=142112
3146
3147         Reviewed by Filip Pizlo.
3148
3149         Added check for VMs in the form of <someDir>/{DumpRenderTree,webkitTestRunner,jsc} and use
3150         <someDir> as the library path.
3151
3152         * Scripts/run-jsc-benchmarks:
3153
3154 2015-02-27  Alex Christensen  <achristensen@webkit.org>
3155
3156         [WinCairo] Unreviewed build fix.
3157
3158         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
3159         Use TestWebKitAPIPrefix.h like in TestWebKitAPICommon.props.
3160
3161 2015-02-27  Anders Carlsson  <andersca@apple.com>
3162
3163         Add infrastructure for handling website data in the network process
3164         https://bugs.webkit.org/show_bug.cgi?id=142092
3165
3166         Reviewed by Andreas Kling.
3167
3168         Add a menu item that will fetch all website data, delete the returned data records, and
3169         fetch all website data again so we can confirm that it's all empty.
3170
3171         * MiniBrowser/mac/WK2BrowserWindowController.m:
3172         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
3173
3174 2015-02-26  Brent Fulgham  <bfulgham@apple.com>
3175
3176         [Win] Remove remaining SafariTheme cruft
3177         https://bugs.webkit.org/show_bug.cgi?id=142075
3178
3179         Reviewed by Anders Carlsson.
3180
3181         Remove reference to SafariTheme-switching preference.
3182
3183         * DumpRenderTree/win/DumpRenderTree.cpp:
3184         (resetWebPreferencesToConsistentValues):
3185         (prepareConsistentTestingEnvironment):
3186
3187 2015-02-26  Doug Russell  <d_russell@apple.com>
3188
3189         AX: Expose caret browsing preference to accessibility API
3190         https://bugs.webkit.org/show_bug.cgi?id=141862
3191
3192         Reviewed by Chris Fleizach.
3193
3194         Exposing the caret browsing setting on WebCore::Frame via the accessibility API would allow assistive tech apps to enable it contextually (for example, when the assistive tech app is running).
3195         Enabling caret browsing when assistive tech apps are running greatly improves the reliability of keyboard navigation on the web. Most especially in cases where selection would be disrupted by focus events.
3196
3197         * DumpRenderTree/AccessibilityUIElement.cpp:
3198         (setBoolAttributeValueCallback):
3199         (selectedTextMarkerRangeCallback):
3200         (resetSelectedTextMarkerRangeCallback):
3201         (AccessibilityUIElement::setBoolAttributeValue):
3202         (AccessibilityUIElement::selectedTextMarkerRange):
3203         (AccessibilityUIElement::resetSelectedTextMarkerRange):
3204         (AccessibilityUIElement::getJSClass):
3205         * DumpRenderTree/AccessibilityUIElement.h:
3206         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3207         (AccessibilityUIElement::setBoolAttributeValue):
3208         (AccessibilityUIElement::selectedTextMarkerRange):
3209         (AccessibilityUIElement::resetSelectedTextMarkerRange):
3210         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3211         (WTR::AccessibilityUIElement::selectedTextMarkerRange):
3212         (WTR::AccessibilityUIElement::resetSelectedTextMarkerRange):
3213         (WTR::AccessibilityUIElement::setBoolAttributeValue):
3214         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3215         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3216         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3217         (WTR::AccessibilityUIElement::setBoolAttributeValue):
3218         (WTR::AccessibilityUIElement::selectedTextMarkerRange):
3219         (WTR::AccessibilityUIElement::resetSelectedTextMarkerRange):
3220
3221 2015-02-26  Brent Fulgham  <bfulgham@apple.com>
3222
3223         [Win] Remove WebKitExportGenerator project (and related)
3224         https://bugs.webkit.org/show_bug.cgi?id=142035
3225
3226         Reviewed by Dean Jackson.
3227
3228         * win/AssembleBuildLogs/AssembleLogs.cmd: Don't look for a
3229         build log from WebKitExportGenerator.
3230
3231 2015-02-26  Csaba Osztrogonác  <ossy@webkit.org>
3232
3233         [EFL] Bump EFL version to 1.13.0
3234         https://bugs.webkit.org/show_bug.cgi?id=141708
3235
3236         Reviewed by Gyuyoung Kim.
3237
3238         * efl/jhbuild.modules:
3239
3240 2015-02-26  Sam Weinig  <sam@webkit.org>
3241
3242         Check in missing WebEditingTester.xcconfig file.
3243
3244         * WebEditingTester/Configurations/WebEditingTester.xcconfig: Added.
3245
3246 2015-02-26  Csaba Osztrogonác  <ossy@webkit.org>
3247
3248         [webkitpy] Remove skipped file related crufts
3249         https://bugs.webkit.org/show_bug.cgi?id=142046
3250
3251         Reviewed by Ryosuke Niwa.
3252
3253         * Scripts/webkitpy/port/base.py:
3254         (Port.skipped_layout_tests):
3255         (Port._tests_from_skipped_file_contents): Deleted.
3256         (Port): Deleted.
3257         (Port._expectations_from_skipped_files): Deleted.
3258         * Scripts/webkitpy/port/mac_unittest.py:
3259         (MacTest.test_default_timeout_ms):
3260         (MacTest): Deleted.
3261         (test_tests_from_skipped_file_contents): Deleted.
3262
3263 2015-02-26  Brent Fulgham  <bfulgham@apple.com>
3264
3265         [Win] Unreviewed WinCairo build fix after r180653.
3266
3267         TestWebKitAPI should know about proper WEBCORE_EXPORT definitions.
3268
3269         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3270         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
3271         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
3272         * TestWebKitAPI/win/TestWebKitAPIPrefix.cpp: Added.
3273         * TestWebKitAPI/win/TestWebKitAPIPrefix.h: Added.
3274
3275 2015-02-25  Brent Fulgham  <bfulgham@apple.com>
3276
3277         [Win] Use WEBCORE_EXPORT instead of Definition file
3278         https://bugs.webkit.org/show_bug.cgi?id=141734
3279
3280         Reviewed by Alex Christensen.
3281
3282         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
3283         Use a precompiled header so we can define our export macros properly.
3284         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj.filters:
3285         Visual studio automatic update stuff.
3286         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
3287         Set up Precompiled Header use for project..
3288         * DumpRenderTree/win/DumpRenderTreePrefix.cpp: Added.
3289         * DumpRenderTree/DumpRenderTreePrefix.h: Update with proper export
3290         declarations for building DumpRenderTree as a client of
3291         WebCore/WebKit.
3292
3293 2015-02-25  Mark Lam  <mark.lam@apple.com>
3294
3295         ASan does not like JSC::MachineThreads::tryCopyOtherThreadStack.
3296         <https://webkit.org/b/141672>
3297
3298         Reviewed by Alexey Proskuryakov.
3299
3300         ASan does not like the fact that we memcpy the stack for GC scans.  So,
3301         we're working around this by using our own memcpy (asanUnsafeMemcpy)
3302         implementation that we can tell ASan to ignore.
3303
3304         Also removed the previous added directive to ignore *tryCopyOtherThreadStack*
3305         which isn't effective for working around this issue. 
3306
3307         * asan/webkit-asan-ignore.txt:
3308
3309 2015-02-25  Benjamin Poulain  <bpoulain@apple.com>
3310
3311         CodeBlock crashes when dumping op_push_name_scope
3312         https://bugs.webkit.org/show_bug.cgi?id=141953
3313
3314         Reviewed by Filip Pizlo.
3315
3316         * Scripts/run-jsc-stress-tests:
3317
3318 2015-02-25  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3319
3320         W3C test importer should use argparse instead of optparse
3321         https://bugs.webkit.org/show_bug.cgi?id=142013
3322
3323         Reviewed by Bem Jones-Bey.
3324
3325         * Scripts/webkitpy/w3c/test_importer.py:
3326         (main): Updating according argparse.
3327         (parse_args): Moving from optparse to argparse.
3328
3329 2015-02-25  Brady Eidson  <beidson@apple.com>
3330
3331         Get rid of TestInvocation::pathOrURL
3332         https://bugs.webkit.org/show_bug.cgi?id=142021
3333
3334         Reviewed by Tim Horton.
3335
3336         The pathOrURL string is a relative path used as an argument to WebKitTestRunner,
3337         but most code that uses it expected an absolute path.
3338
3339         This gets rid of the member and replaces all uses with a more descriptive "urlContains" method.
3340
3341         * WebKitTestRunner/TestController.cpp:
3342         (WTR::TestController::updateWebViewSizeForTest):
3343         (WTR::TestController::updateWindowScaleForTest):
3344         (WTR::shouldUseFixedLayout):
3345         (WTR::TestController::updateLayoutTypeForTest):
3346
3347         * WebKitTestRunner/TestInvocation.cpp:
3348         (WTR::TestInvocation::TestInvocation):
3349         (WTR::TestInvocation::urlContains):
3350         (WTR::TestInvocation::shouldLogFrameLoadDelegates):
3351         (WTR::TestInvocation::shouldLogHistoryClientCallbacks):
3352         (WTR::TestInvocation::invoke):
3353         (WTR::shouldLogFrameLoadDelegates): Deleted.
3354         (WTR::shouldLogHistoryClientCallbacks): Deleted.
3355         * WebKitTestRunner/TestInvocation.h:
3356         (WTR::TestInvocation::pathOrURL): Deleted.
3357
3358         * WebKitTestRunner/ios/TestControllerIOS.mm:
3359         (WTR::shouldMakeViewportFlexible):
3360         (WTR::TestController::platformConfigureViewForTest):
3361
3362         * WebKitTestRunner/mac/TestControllerMac.mm:
3363         (WTR::shouldUseThreadedScrolling):
3364         (WTR::TestController::platformConfigureViewForTest):
3365
3366 2015-02-25  Brady Eidson  <beidson@apple.com>
3367
3368         Layout test support for user content filters
3369         https://bugs.webkit.org/show_bug.cgi?id=142018
3370
3371         Reviewed by Tim Horton.
3372
3373         * WebKitTestRunner/TestController.cpp:
3374         (WTR::TestController::resetStateToConsistentValues): Clear all user content filters between tests.
3375
3376         * WebKitTestRunner/mac/TestControllerMac.mm:
3377         (WTR::TestController::platformConfigureViewForTest): For all tests with usercontentfilter/ in their path try to load a matching .json
3378           file before loading the test itself.
3379
3380 2015-02-24  Sam Weinig  <sam@webkit.org>
3381
3382         Convert WebEditingTester to use xcconfig files
3383         https://bugs.webkit.org/show_bug.cgi?id=141879
3384
3385         Reviewed by Darin Adler.
3386
3387         Add xcconfig files to WebEditingTester based on the ones used by MiniBrowser.
3388
3389         * WebEditingTester/Configurations: Added.
3390         * WebEditingTester/Configurations/Base.xcconfig: Added.
3391         * WebEditingTester/Configurations/DebugRelease.xcconfig: Added.
3392         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
3393
3394 2015-02-24  Andy Estes  <aestes@apple.com>
3395
3396         Teach MiniBrowser how to disable per-window web processes
3397         https://bugs.webkit.org/show_bug.cgi?id=141988
3398
3399         Reviewed by Darin Adler.
3400
3401         * MiniBrowser/mac/AppDelegate.m:
3402         (defaultConfiguration): Created a _WKProcessPoolConfiguration with maximumProcessCount == 1 if per-window web processes are disabled.
3403         * MiniBrowser/mac/SettingsController.h:
3404         * MiniBrowser/mac/SettingsController.m:
3405         (-[SettingsController _populateMenu]): Added a new Settings menu item.
3406         (-[SettingsController validateMenuItem:]): Validated the new Settings menu item.
3407         (-[SettingsController togglePerWindowWebProcessesDisabled:]): Displayed an alert informing the user that MiniBrowser must be restarted for the setting to take effect.
3408         (-[SettingsController perWindowWebProcessesDisabled]): Returned the value from user defaults.
3409
3410 2015-02-24  Alexey Proskuryakov  <ap@apple.com>
3411
3412         Bot watcher's dashboard sometimes hits an assertion: data.num_missing === this.layoutTestResults.testsWithMissingResults.length
3413         https://bugs.webkit.org/show_bug.cgi?id=141889
3414
3415         Reviewed by Darin Adler.
3416
3417         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3418
3419 2015-02-24  Yusuke Suzuki  <utatane.tea@gmail.com>
3420
3421         REGRESSION(r179429): Can't type comments in Facebook
3422         https://bugs.webkit.org/show_bug.cgi?id=141859
3423
3424         Reviewed by Brent Fulgham.
3425
3426         Drop javaScriptExperimentsEnabled and specify JavaScriptRuntimeFlagsAllEnabled as KJavaScriptRuntimeFlags.
3427
3428         * DumpRenderTree/mac/DumpRenderTree.mm:
3429         (resetWebPreferencesToConsistentValues):
3430         * DumpRenderTree/win/DumpRenderTree.cpp:
3431         (resetWebPreferencesToConsistentValues):
3432         * WebKitTestRunner/TestController.cpp:
3433         (WTR::TestController::resetPreferencesToConsistentValues):
3434
3435 2015-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3436
3437         Crash loading local file with WebPageProxy::loadAlternateHTMLString
3438         https://bugs.webkit.org/show_bug.cgi?id=141867
3439
3440         Reviewed by Anders Carlsson.
3441
3442         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
3443         (TestWebKitAPI::loadAlternateHTMLString): Split most of this test into a function so it can
3444         be shared with the new test.
3445         (TestWebKitAPI::TEST): Add a cross-platform test for this crash.
3446         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp: Add a GTK+ test for this crash.
3447         (testLoadAlternateHTMLForLocalPage):
3448         (beforeAll):
3449
3450 2015-02-24  David Kilzer  <ddkilzer@apple.com>
3451
3452         [iOS] Implement WTR::activateFonts() to fix missing fonts in WebKit2 test runs
3453         <http://webkit.org/b/141900>
3454
3455         Reviewed by Myles C. Maxfield.
3456
3457         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
3458         (OTHER_LDFLAGS_BASE): Link to CoreText.framework.
3459         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm: Rename from Tools/WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm.
3460         - Rename to share code with iOS.
3461         - Add USE(APPKIT) around AppKit-specific headers and code.
3462         - Fix a check-webkit-style warning.
3463         * WebKitTestRunner/InjectedBundle/ios/ActivateFontsIOS.mm: Remove.
3464         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3465         - Rename mac/ActivateFonts.mm to cocoa/ActivateFontsCocoa.mm.
3466         - Remove ios/ActivateFontsIOS.mm.
3467         - Fix InjectedBundle/cocoa group to represent the directory on
3468           disk.  Includes a change to InjectedBundlePageCocoa.mm.
3469
3470 2015-02-23  Commit Queue  <commit-queue@webkit.org>
3471
3472         Unreviewed, rolling out r180547 and r180550.
3473         https://bugs.webkit.org/show_bug.cgi?id=141957
3474
3475         Broke 10 Windows tests. (Requested by bfulgham_ on #webkit).
3476
3477         Reverted changesets:
3478
3479         "REGRESSION(r179429): Can't type comments in Facebook"
3480         https://bugs.webkit.org/show_bug.cgi?id=141859
3481         http://trac.webkit.org/changeset/180547
3482
3483         "Constructor returning null should construct an object instead
3484         of null"
3485         https://bugs.webkit.org/show_bug.cgi?id=141640
3486         http://trac.webkit.org/changeset/180550
3487
3488 2015-02-23  Yusuke Suzuki  <utatane.tea@gmail.com>
3489
3490         REGRESSION(r179429): Can't type comments in Facebook
3491         https://bugs.webkit.org/show_bug.cgi?id=141859
3492
3493         Reviewed by Geoffrey Garen.
3494
3495         Drop javaScriptExperimentsEnabled and specify JavaScriptRuntimeFlagsAllEnabled as KJavaScriptRuntimeFlags.
3496
3497         * DumpRenderTree/mac/DumpRenderTree.mm:
3498         (resetWebPreferencesToConsistentValues):
3499         * WebKitTestRunner/TestController.cpp:
3500         (WTR::TestController::resetPreferencesToConsistentValues):
3501
3502 2015-02-23  KwangHyuk Kim  <hyuki.kim@samsung.com>
3503
3504         [EFL] fix eo errors
3505         https://bugs.webkit.org/show_bug.cgi?id=141909
3506
3507         Reviewed by Gyuyoung Kim.
3508
3509         Fix eo errors that occur whenever minibrowser is launched.
3510         - elm_obj_entry_text_style_user_push can only be applied for elm_entry
3511         - elm_obj_win_resize_object_add's first parameter should be elm_win
3512
3513         * MiniBrowser/efl/main.c:
3514         (window_create):
3515
3516 2015-02-23  Ryosuke Niwa  <rniwa@webkit.org>
3517
3518         Unreviewed build fix after r180535. Removed the test case that wasn't compiling.
3519
3520         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3521         (TestWebKitAPI::TEST):
3522
3523 2015-02-23  Brent Fulgham  <bfulgham@apple.com>
3524
3525         WTF::WeakPtr should rename 'forgot' to 'clear' and support nullptr assignment
3526         https://bugs.webkit.org/show_bug.cgi?id=141935
3527
3528         Reviewed by Myles C. Maxfield.
3529
3530         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3531         (TestWebKitAPI::TEST): Updated for 'clear' method rename, and added a few
3532         tests for assigning from nullptr.
3533
3534 2015-02-23  Brent Fulgham  <bfulgham@apple.com>
3535
3536         WTF::WeakPtr should have a 'forget' method.
3537         https://bugs.webkit.org/show_bug.cgi?id=141923
3538
3539         Reviewed by Myles C. Maxfield.
3540
3541         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3542         (TestWebKitAPI::TEST): Added 'Forget' tests case.
3543
3544 2015-02-23  Alexey Proskuryakov  <ap@apple.com>
3545
3546         build.webkit.org/dashboard CrashOnly queues should not show two green bubbles
3547         https://bugs.webkit.org/show_bug.cgi?id=141920
3548
3549         Reviewed by Tim Horton.
3550
3551         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3552         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
3553         Do the same thing as we do for regular green bubbles.
3554
3555 2015-02-23  Alexey Proskuryakov  <ap@apple.com>
3556
3557         Bot watcher's dashboard doesn't show a popover for commit history when all commits were to another branch
3558         https://bugs.webkit.org/show_bug.cgi?id=141925
3559
3560         Reviewed by Tim Horton.
3561
3562         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3563         (BuildbotQueueView.prototype._presentPopoverForRevisionRange):
3564
3565 2015-02-23  Anders Carlsson  <andersca@apple.com>
3566
3567         Add API for fetching website data records to _WKWebsiteDataStore
3568         https://bugs.webkit.org/show_bug.cgi?id=141926
3569
3570         Reviewed by Beth Dakin.
3571
3572         * MiniBrowser/mac/MainMenu.xib:
3573         * MiniBrowser/mac/WK2BrowserWindowController.m:
3574         (-[WK2BrowserWindowController fetchWebsiteData:]):
3575         Add menu item to fetch and dump website data.
3576
3577 2015-02-23  David Kilzer  <ddkilzer@apple.com>
3578
3579         [iOS] run-webkit-tests --leaks is broken because IOSSimulatorPort has no is_snowleopard attribute
3580         <http://webkit.org/b/141884>
3581
3582         Reviewed by Alexey Proskuryakov.
3583
3584         * Scripts/webkitpy/port/leakdetector.py:
3585         (LeakDetector._callstacks_to_exclude_from_leaks): Remove
3586         snowleopard, lion and older leaks.  Add known leak for
3587         mavericks, but check Port.operating_system before calling
3588         Port.is_mavericks.
3589         * Scripts/webkitpy/port/mac.py:
3590         (MacPort.is_snowleopard): Delete.
3591         (MacPort.is_lion): Delete.
3592         (MacPort.is_mavericks): Add.
3593
3594 2015-02-23  Alexey Proskuryakov  <ap@apple.com>
3595
3596         build.webkit.org/dashboard should filter out commits to other branches
3597         https://bugs.webkit.org/show_bug.cgi?id=140362
3598
3599         Reviewed by Tim Horton.
3600
3601         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3602         (BuildbotQueue):
3603         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3604         (BuildbotQueueView.prototype._presentPopoverForPendingCommits):
3605         (BuildbotQueueView.prototype._presentPopoverForRevisionRange):
3606         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration):
3607         (BuildbotQueueView.prototype.revisionContentForIteration):
3608         (BuildbotQueueView.prototype._appendPendingRevisionCount): Deleted.
3609         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Deleted.
3610         (BuildbotQueueView.prototype._revisionPopoverContentForIteration): Deleted.
3611         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3612         (Trac.prototype.get oldestRecordedRevisionNumber):
3613         (Trac.prototype.commitsOnBranch):
3614         (Trac.prototype._xmlTimelineURL):
3615         (Trac.prototype._convertCommitInfoElementToObject):
3616         (Trac.prototype._update):
3617         (Trac.prototype.startPeriodicUpdates):
3618         (Trac.prototype.loadMoreHistoricalData):
3619         (Trac.prototype.update): Deleted.
3620
3621 2015-02-21  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3622
3623         Tests don't work on some bots: Failed to stop wptwk
3624         https://bugs.webkit.org/show_bug.cgi?id=141235
3625
3626         Reviewed by Ryosuke Niwa.
3627
3628         Logging of server subprocesses in launcher script.
3629         Killing of server subprocesses when stopping/before starting.
3630         Removed empty __init.py__ file creation as importer now ensures these files cannot be empty anymore.
3631
3632         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
3633         (main): Removed empty __init.py__ file creation as importer now ensures these files cannot be empty anymore. Added logging in a file of server subprocesses to clean them in case of abnormal shutdown. 
3634         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3635         (WebPlatformTestServer.__init__):
3636         (WebPlatformTestServer._stop_running_subservers): Kill server subprocesses based on file created by wpt launcher.
3637         (WebPlatformTestServer):
3638         (WebPlatformTestServer.stop): Overriden to ensure killing subprocesses in case of orphaned process.
3639         (WebPlatformTestServer._stop_running_server): Killing of wpt launcher process after regular shutdown. 
3640         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
3641         (TestWebPlatformTestServer.test_server_closes_previously_spawned_instance): Reworked the test to call start/stop with an existing pid file.
3642         (TestWebPlatformTestServer.test_import_web_platform_test_modules): No change.
3643         (TestWebPlatformTestServer):
3644         (TestWebPlatformTestServer.test_corrupted_subserver_files): Checked that server subprocess cleaning does not throw in case of bad server pid file.
3645
3646 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
3647
3648         [WebEditingTester] Allow dropping HTML files on the app
3649         https://bugs.webkit.org/show_bug.cgi?id=141834
3650
3651         Reviewed by Simon Fraser.
3652
3653         * WebEditingTester/AppDelegate.m:
3654         (-[WebEditingAppDelegate openDocument:]):
3655         (-[WebEditingAppDelegate application:openFile:]):
3656         Implement application:openFile:, factoring file loading code out of openDocument.
3657
3658         * WebEditingTester/Info.plist:
3659         Register as an editor for HTML files.
3660
3661         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
3662         Enrica is not an organization.
3663
3664 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
3665
3666         [WebEditingTester] Expand "WK" to "WebKit" in a few places
3667         https://bugs.webkit.org/show_bug.cgi?id=141833
3668
3669         Reviewed by Anders Carlsson.
3670
3671         * WebEditingTester/AppDelegate.h:
3672         * WebEditingTester/AppDelegate.m:
3673         (-[WebEditingAppDelegate newEditor:]):
3674         (-[WebEditingAppDelegate toggleUseWebKit2ByDefault:]):
3675         (-[WebEditingAppDelegate validateMenuItem:]):
3676         (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]):
3677         (-[WebEditingAppDelegate applicationDidFinishLaunching:]): Deleted.
3678         (-[WebEditingAppDelegate applicationWillTerminate:]): Deleted.