Commit queue failed to land a bug, 'NoneType' object has no attribute 'strip'
[WebKit-https.git] / Tools / ChangeLog
1 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
2
3         Commit queue failed to land a bug, 'NoneType' object has no attribute 'strip'
4         https://bugs.webkit.org/show_bug.cgi?id=181561
5         <rdar://problem/36452652>
6
7         Reviewed by Aakash Jain.
8
9         BeautifulSoup.find may return None, this case should be gracefully handled.
10
11         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
12         (BugzillaQueries._parse_result_count):
13         (BugzillaQueries._fetch_bugs_from_advanced_query): Added logging.
14
15 2018-01-11  Alexey Proskuryakov  <ap@apple.com>
16
17         run-webkit-tests fails when there is a curly brace in Xcode build output
18         https://bugs.webkit.org/show_bug.cgi?id=181254
19
20         Reviewed by Daniel Bates.
21
22         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
23         (MeteredStream.write):
24
25 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
26
27         webkitpy: Reimplement simulator code (Part 3)
28         https://bugs.webkit.org/show_bug.cgi?id=180555
29         <rdar://problem/36131381>
30
31         Reviewed by Aakash Jain.
32
33         Remove old simulator code.
34
35         * Scripts/webkitpy/xcode/__init__.py: Remove import statement.
36         * Scripts/webkitpy/xcode/simulated_device.py: Removed.
37         * Scripts/webkitpy/xcode/simulator.py: Removed.
38         * Scripts/webkitpy/xcode/simulator_unittest.py: Removed.
39
40 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
41
42         [Attachment Support] Support moving attachment elements in editable areas using drag and drop
43         https://bugs.webkit.org/show_bug.cgi?id=181337
44         <rdar://problem/36324813>
45
46         Reviewed by Tim Horton.
47
48         Add 3 new API tests for attachment element dragging.
49
50         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
51         (-[TestWKWebView expectElementTag:toComeBefore:]):
52         (-[NSItemProvider expectType:withData:]):
53         (TestWebKitAPI::TEST):
54
55 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
56
57         REGRESSION(r225856): Incorrectly managing 'future' baseline_search_paths. 
58         https://bugs.webkit.org/show_bug.cgi?id=179621
59         <rdar://problem/35589585>
60
61         Unreviewed infrastructure fix.
62
63         * Scripts/webkitpy/port/mac.py:
64         (MacPort.default_baseline_search_path): Include 'future' in the version_fallback
65         list if we are the VERSION_MAX, which usually corresponds with future.
66
67 2018-01-11  Filip Pizlo  <fpizlo@apple.com>
68
69         CodeBlocks should be in IsoSubspaces
70         https://bugs.webkit.org/show_bug.cgi?id=180884
71
72         Reviewed by Saam Barati.
73         
74         Remove some less important benchmarks from the default run. Doing run-jsc-benchmarks
75         shouldn't take a long time due to benchmarks we don't optimize for.
76         
77         * Scripts/run-jsc-benchmarks:
78
79 2018-01-11  Ms2ger  <Ms2ger@igalia.com>
80
81         Test gardening for GTK.
82         https://bugs.webkit.org/show_bug.cgi?id=181477
83
84         Unreviewed test gardening.
85
86         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp: Correct the file name.
87         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp: Adjust the expected console message.
88
89 2018-01-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>
90
91         Add the new JSCOnly bot to the scheduler.
92         https://bugs.webkit.org/show_bug.cgi?id=181487
93
94         Unreviewed follow-up patch after r226729
95
96         On r226729 I missed to add the new JSCOnly bot the default scheduler.
97         This is needed to make the bot automatically pick each commit for testing.
98
99         * BuildSlaveSupport/build.webkit.org-config/config.json:
100
101 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
102
103         [Attachment Support] Support dragging attachment elements out as files on iOS
104         https://bugs.webkit.org/show_bug.cgi?id=181199
105         <rdar://problem/36299316>
106
107         Reviewed by Tim Horton, Andy Estes and Joseph Pecoraro.
108
109         Add support in the drag and drop simulator for testing blob-backed attachment element dragging, and also add new
110         attachment API tests.
111
112         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
113         (-[NSItemProvider expectType:withData:]):
114         (TestWebKitAPI::TEST):
115
116         Add two new WKAttachmentTests to exercise dragging data- and file-backed blobs via attachment elements. These
117         tests first insert attachments via drop or WKWebView SPI, and then drag these attachments out and use the
118         -expectType:withData: helper to inspect the item providers created from the drag source.
119
120         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
121         (TestWebKitAPI::TEST):
122         * TestWebKitAPI/ios/DataInteractionSimulator.h:
123         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
124         (-[MockDragSession localContext]):
125         (-[MockDragSession setLocalContext:]):
126         (-[DataInteractionSimulator _resetSimulatedState]):
127         (-[DataInteractionSimulator simulateAllTouchesCanceled:]):
128         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
129         (-[DataInteractionSimulator _advanceProgress]):
130         (-[DataInteractionSimulator endDataTransfer]):
131
132         Make some tweaks to the iOS drag and drop simulator. In particular, this patch (1) adds a new hook to tell
133         WebKit that data transfers have been completed, (2) fixes incorrect drop proposal handling when returning
134         UIDropOperationForbidden by replacing _shouldPerformOperation with a UIDropProposal, and (3) teach the
135         MockDragSession to hold on to a localContext.
136
137 2018-01-11  Ali Juma  <ajuma@chromium.org>
138
139         Unreviewed. Add Ali Juma as contributor
140
141         * Scripts/webkitpy/common/config/contributors.json:
142
143 2018-01-11  Carlos Garcia Campos  <cgarcia@igalia.com>
144
145         Unreviewed. Update Selenium WebDriver imported tests.
146
147         New version of selenium uses command line options to pass driver and browser binaries to pytest instead of
148         environment variables.
149
150         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
151         (collect): Reorder the arguments to make pytest happy.
152         (run): Ditto.
153         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
154         (WebDriverSeleniumExecutor.__init__): Add driver binary, browser binary and browser args as arguments.
155
156 2018-01-11  Ling Ho  <lingcherd_ho@apple.com>
157
158         Move Commit Queue and EWS Queues to Sierra on Bot Watcher's Dasboard
159         https://bugs.webkit.org/show_bug.cgi?id=181492
160         <rdar://problem/36359679>
161
162         Reviewed by Alexey Proskuryakov. 
163
164 2018-01-10  Adrian Perez de Castro  <aperez@igalia.com>
165
166         [GTK] Tools/gtk/install-dependencies: Packages geoclue, ruby-highline, xorg-utils do not exist in Arch Linux
167         https://bugs.webkit.org/show_bug.cgi?id=181475
168
169         Reviewed by Michael Catanzaro.
170
171         * gtk/install-dependencies: Update package list for Arch Linux, extend
172         message shown at end of installation with additional tips.
173
174 2018-01-10  Wenson Hsieh  <wenson_hsieh@apple.com>
175
176         REGRESSION(r222507): Composition highlight doesn't render when using IME
177         https://bugs.webkit.org/show_bug.cgi?id=181485
178         <rdar://problem/35896516>
179
180         Reviewed by Ryosuke Niwa.
181
182         Add a `suppressUnderline` argument to TextInputController.setMarkedText. This suppresses the custom underlines
183         rendered when testing IME on iOS in WebKit2. In this new test, suppressing underline rendering is needed to
184         allow rendering composition backgrounds (see InlineTextBox::paint).
185
186         * DumpRenderTree/ios/TextInputControllerIOS.m:
187         (+[TextInputController isSelectorExcludedFromWebScript:]):
188         (+[TextInputController webScriptNameForSelector:]):
189         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]):
190         (-[TextInputController setMarkedText:selectedFrom:length:]): Deleted.
191         * DumpRenderTree/mac/TextInputControllerMac.m:
192         (+[TextInputController isSelectorExcludedFromWebScript:]):
193         (+[TextInputController webScriptNameForSelector:]):
194         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]):
195         (-[TextInputController setMarkedText:selectedFrom:length:]): Deleted.
196         * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl:
197         * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
198         (WTR::TextInputController::setMarkedText):
199         * WebKitTestRunner/InjectedBundle/TextInputController.h:
200
201 2018-01-10  JF Bastien  <jfbastien@apple.com>
202
203         Poison small JSObject derivatives which only contain pointers
204         https://bugs.webkit.org/show_bug.cgi?id=181483
205         <rdar://problem/36407127>
206
207         Reviewed by Mark Lam.
208
209         Test the new move-assign and move-copy from unique_ptr, as well as
210         nullptr_t ctors.
211
212         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
213         (TestWebKitAPI::TEST):
214         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
215         (TestWebKitAPI::TEST):
216         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
217         (TestWebKitAPI::TEST):
218
219 2018-01-10  Chris Dumez  <cdumez@apple.com>
220
221         Multiple http/wpt/beacon/contentextensions/ test are flaky.
222         https://bugs.webkit.org/show_bug.cgi?id=179256
223         <rdar://problem/35401978>
224
225         Reviewed by Alex Christensen.
226
227         Update WebKitTestRunner to set a temporary path for content extensions so that its WKTR
228         instance gets its own folder to avoid conflicts and flakiness.
229
230         * WebKitTestRunner/mac/TestControllerMac.mm:
231         (WTR::TestController::platformConfigureViewForTest):
232
233 2018-01-10  Tim Horton  <timothy_horton@apple.com>
234
235         REGRESSION (r213590): Swipe from edge to go to previous page is significantly slower than tapping back button on Twitter
236         https://bugs.webkit.org/show_bug.cgi?id=181269
237         <rdar://problem/35110344>
238
239         Reviewed by Simon Fraser.
240
241         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
242         (WTR::UIScriptController::beginBackSwipe):
243         (WTR::UIScriptController::completeBackSwipe):
244         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
245         (WTR::UIScriptController::beginBackSwipe):
246         (WTR::UIScriptController::completeBackSwipe):
247         (WTR::UIScriptController::overridePreference):
248         (WTR::UIScriptController::replaceTextAtRange):
249         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
250         (WTR::PlatformWebView::setNavigationGesturesEnabled):
251         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
252         (WTR::UIScriptController::beginBackSwipe):
253         (WTR::UIScriptController::completeBackSwipe):
254         Implement beginBackSwipe and completeBackSwipe on iOS (they already
255         exist on Mac) in terms of the new WKWebView testing SPI.
256
257 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
258
259         REGRESSION (r226715): ignore WARNING output in linter tests
260         https://bugs.webkit.org/show_bug.cgi?id=181486
261         <rdar://problem/36408847>
262
263         Reviewed by Aakash Jain.
264
265         Linter unit tests should not be interested in logs at the the INFO or WARNING levels.
266
267         * Scripts/webkitpy/common/system/outputcapture.py:
268         (OutputCapture.__init__): Pass logging level to be captured.
269         * Scripts/webkitpy/style/main_unittest.py:
270         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors): Capture logging at the ERROR level.
271         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line): Ditto.
272         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit): Ditto.
273         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Ditto.
274         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_only_deletes): Ditto.
275         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Ditto.
276         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file): Ditto.
277         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit): Ditto.
278
279 2018-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
280
281         Add a JSCOnly MIPS buildbot
282         https://bugs.webkit.org/show_bug.cgi?id=181487
283
284         Reviewed by Michael Catanzaro.
285
286         Add the new bot configs definitions for the master and update the unit tests.
287
288         * BuildSlaveSupport/build.webkit.org-config/config.json:
289         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
290
291 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
292
293         REGRESSION (r226715): don't re-check number of simulators in child processes
294         https://bugs.webkit.org/show_bug.cgi?id=181484
295         <rdar://problem/36407151>
296
297         Reviewed by Aakash Jain.
298
299         * Scripts/webkitpy/port/ios_simulator.py:
300         (IOSSimulatorPort.__init__): Skip the number of simulators check if simulators
301         are already initialized.
302
303 2018-01-10  Commit Queue  <commit-queue@webkit.org>
304
305         Unreviewed, rolling out r226667 and r226673.
306         https://bugs.webkit.org/show_bug.cgi?id=181488
307
308         This caused a flaky crash. (Requested by mlewis13 on #webkit).
309
310         Reverted changesets:
311
312         "CodeBlocks should be in IsoSubspaces"
313         https://bugs.webkit.org/show_bug.cgi?id=180884
314         https://trac.webkit.org/changeset/226667
315
316         "REGRESSION (r226667): CodeBlocks should be in IsoSubspaces"
317         https://bugs.webkit.org/show_bug.cgi?id=180884
318         https://trac.webkit.org/changeset/226673
319
320 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
321
322         Follow-up fix to r226715
323         https://bugs.webkit.org/show_bug.cgi?id=180555
324         <rdar://problem/36131381>
325
326         Unreviewed infrastructure fix.
327
328         * Scripts/webkitpy/xcode/new_simulated_device.py:
329         (SimulatedDeviceManager._create_or_find_device_for_request): Use _delete instead
330         of delete.
331
332 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
333
334         webkitpy: Refactor simulator code (Part 2)
335         https://bugs.webkit.org/show_bug.cgi?id=180555
336         <rdar://problem/36131381>
337
338         Reviewed by Aakash Jain.
339
340         The patch leverages the SimulatedDeviceManager when running layout tests.
341         This patch is primarily code removal, since much of the IOSSimulatorPort
342         was dedicated to managing simulators. The removed code is either now owned by the
343         SimulatedDeviceManager (and committed in Part 1) or supported a technique to
344         boot multiple simulators which was made obsolete in Xcode 9.
345
346         * Scripts/webkitpy/layout_tests/controllers/manager.py:
347         (Manager._custom_device_for_test.in): Device names now have spaces in them,
348         strip those spaces.
349         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
350         (parse_args): Remove '--runtime' flag, this is achieved with the --version flag.
351         * Scripts/webkitpy/port/ios.py:
352         (IOSPort.__init__): The _current_device idiom is no longer required since the
353         SimulatedDeviceManager keeps track of any previously booted devices.
354         (IOSPort.target_host): Even when only a single device is used, it will be accessed
355         through the array of managed devices.
356         (IOSPort.using_multiple_devices): Deleted.
357         * Scripts/webkitpy/port/ios_device.py:
358         (IOSDevicePort.using_multiple_devices): Deleted.
359         * Scripts/webkitpy/port/ios_simulator.py:
360         (IOSSimulatorPort): Remove constants required to manage simulators, change device
361         class strings so they can be parsed by the DeviceType class.
362         (IOSSimulatorPort.__init__): Determine the number of processes to use by checking
363         the number of simulators currently booted, the number of child processes specified
364         and the maximum number of simulators supported by this system.
365         (IOSSimulatorPort._device_for_worker_number_map):Return the array of initialized
366         devices owned by the SimulatedDeviceManager.
367         (IOSSimulatorPort.ios_version): Remove support for the --runtime option.
368         (IOSSimulatorPort.default_child_processes): Use the SimulatedDeviceManager to check
369         the maximum number of supported simulators on this system.
370         (IOSSimulatorPort._create_devices): Construct a list of device requests with a
371         request for each child process and send this list to the SimulatedDeviceManager to
372         initialize the devices.
373         (IOSSimulatorPort.clean_up_test_run):
374         (IOSSimulatorPort.check_sys_deps): Check that there are simulators running the
375         specified version of iOS.
376         (IOSSimulatorPort.reset_preferences):
377         (IOSSimulatorPort.simulator_runtime): Deleted.
378         (IOSSimulatorPort.simulator_device_type): Deleted.
379         (IOSSimulatorPort._teardown_managed_simulators): Deleted.
380         (IOSSimulatorPort.use_multiple_simulator_apps): Deleted.
381         (IOSSimulatorPort._create_simulators): Deleted.
382         (IOSSimulatorPort._quit_ios_simulator): Deleted.
383         (IOSSimulatorPort._using_dedicated_simulators): Deleted.
384         (IOSSimulatorPort.using_multiple_devices): Deleted.
385         (IOSSimulatorPort._create_device): Deleted.
386         (IOSSimulatorPort.get_simulator_path): Deleted.
387         (IOSSimulatorPort._createSimulatorApps): Deleted.
388         (IOSSimulatorPort._createSimulatorApp): Deleted.
389         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
390         (TestRebaseline.test_rebaseline): Filter out commands run when determining the
391         maximum number of simulators run on this system.
392         (TestRebaselineExpectations.test_rebaseline_expectations): Ditto.
393         * Scripts/webkitpy/xcode/new_simulated_device.py:
394         (SimulatedDeviceManager._does_fulfill_request): Fixed log statement.
395
396 2018-01-10  Carlos Garcia Campos  <cgarcia@igalia.com>
397
398         WebDriver: run-webdriver-tests doesn't handle test names with a '/' correctly
399         https://bugs.webkit.org/show_bug.cgi?id=181474
400
401         Reviewed by Carlos Alberto Lopez Perez.
402
403         We use os.path.basename() to get the subtest name. If the test name contains a slash we get part of the subtest
404         name as the name.
405
406         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
407         (WebDriverTestRunnerW3C._subtest_name): Helper function to get the subtest name.
408         (WebDriverTestRunnerW3C.run): Use _subtest_name() instead of os.path.basename().
409
410 2018-01-09  Andy Estes  <aestes@apple.com>
411
412         [Xcode] Use the Apple Internal SDK if available when building ImageDiff
413         https://bugs.webkit.org/show_bug.cgi?id=181459
414
415         Reviewed by Dan Bernstein.
416
417         * ImageDiff/cg/Configurations/Base.xcconfig:
418
419 2018-01-09  Myles C. Maxfield  <mmaxfield@apple.com>
420
421         font-display:fallback can cause a visual flash (which is supposed to be impossible)
422         https://bugs.webkit.org/show_bug.cgi?id=181374
423
424         Reviewed by Simon Fraser.
425
426         The test requires Palatino.
427
428         * DumpRenderTree/mac/DumpRenderTree.mm:
429         (allowedFontFamilySet):
430         * WebKitTestRunner/mac/TestControllerMac.mm:
431         (WTR::allowedFontFamilySet):
432
433 2018-01-09  Saam Barati  <sbarati@apple.com>
434
435         Give some slack in display-profiler-outputs computation of the terminal window's number of columns
436         https://bugs.webkit.org/show_bug.cgi?id=181449
437
438         Reviewed by JF Bastien.
439
440         This allows me to Cmd+f in my terminal to search for things without
441         having the results become misaligned.
442
443         * Scripts/display-profiler-output:
444
445 2018-01-09  Basuke Suzuki  <Basuke.Suzuki@sony.com>
446
447         [webkitpy] PlatformInfo should have default argument for casual use
448         https://bugs.webkit.org/show_bug.cgi?id=180827
449
450         Reviewed by David Kilzer.
451
452         PlatformInfo should be the only way to check platform specific thing instead
453         of sys.platform or other various checks. If there is something you want to check,
454         it should be placed in PlatformInfo.
455
456         Currently to instantiate PlatformInfo, it requires arguments, which is usually
457         sys, platform and Executive(). They are straight forward and should be handled
458         by default arguments. Then we can instantiate PlatformInfo more casual.
459
460         * Scripts/webkitpy/common/system/platforminfo.py:
461         (PlatformInfo): Use relative module path import
462         (PlatformInfo.__init__):
463         (PlatformInfo.executive): Lazy instantiation of Executive()
464         (PlatformInfo.total_bytes_memory): Accessing via above property
465         (PlatformInfo.xcode_sdk_version): Ditto
466         (PlatformInfo.xcode_simctl_list): Ditto
467         (PlatformInfo.xcode_version): Ditto
468         (PlatformInfo._win_version_str): Ditto
469         * Scripts/webkitpy/common/system/systemhost.py:
470         (SystemHost.__init__):
471         * Scripts/webkitpy/common/system/user.py:
472         (User.__init__):
473
474 2018-01-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
475
476         [Win] Remove workaround for Bug 176442 after stopping MSVC 2015 support
477         https://bugs.webkit.org/show_bug.cgi?id=176443
478
479         Reviewed by Darin Adler.
480
481         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
482         (TEST):
483
484 2018-01-09  Frederic Wang  <fwang@igalia.com.fr>
485
486         check-webkit-style: Verify syntax for WK_API_AVAILABLE
487         https://bugs.webkit.org/show_bug.cgi?id=181394
488
489         Reviewed by Darin Adler.
490
491         A common syntax error for WK_API_AVAILABLE is to write ios(WK_MAC_TBA)
492         as the second parameter instead of ios(WK_IOS_TBA). This generally
493         builds for iOS on EWS but not when using the public SDK. See r224057,
494         r223207 and r226211 for example. This patch adds a basic style check
495         for that macro to prevent this kind of mistake.
496
497         * Scripts/webkitpy/style/checkers/cpp.py:
498         (check_min_versions_of_wk_api_available): New function to verify the parameters of WX_API_AVAILABLE.
499         (check_style): Run new style check.
500         (CppChecker): Add build type for the new style check.
501         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
502         (WebKitStyleTest.test_min_versions_of_wk_api_available): Add tests for the new style check.
503
504 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
505
506         [Attachment Support] Expose HTMLAttachmentElement.uniqueIdentifier to bindings
507         https://bugs.webkit.org/show_bug.cgi?id=181420
508         <rdar://problem/36365827>
509
510         Reviewed by Alex Christensen.
511
512         Adjusts some existing API tests to verify that attachment elements' uniqueIdentifiers match the uniqueIdentifier
513         of corresponding _WKAttachments.
514
515         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
516         (TestWebKitAPI::TEST):
517
518 2018-01-08  Alex Christensen  <achristensen@webkit.org>
519
520         Add WKNavigationDelegate SPI exposing WebProcess crash reason
521         https://bugs.webkit.org/show_bug.cgi?id=181410
522         <rdar://problem/36167199>
523
524         Reviewed by Wenson Hsieh.
525
526         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
527         (-[CrashReasonDelegate _webView:webContentProcessDidTerminateWithReason:]):
528         (TEST):
529
530 2018-01-08  Alex Christensen  <achristensen@webkit.org>
531
532         Add SPI for WKOpenPanelParameters._acceptedMIMETypes and _acceptedFileExtensions
533         https://bugs.webkit.org/show_bug.cgi?id=181408
534         <rdar://problem/35884960>
535
536         Reviewed by Tim Horton.
537
538         * TestWebKitAPI/Tests/WebKitCocoa/RunOpenPanel.mm:
539         (-[RunOpenPanelUIDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
540
541 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
542
543         [Attachment Support] Expose file name and content type of WKAttachment
544         https://bugs.webkit.org/show_bug.cgi?id=181390
545         <rdar://problem/36336837>
546
547         Reviewed by Tim Horton.
548
549         Adjusts some existing tests in WKAttachmentTests to exercise -requestInfo:.
550
551         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
552         (-[_WKAttachment synchronouslyRequestInfo:]):
553         (-[_WKAttachment synchronouslyRequestData:]):
554
555         Reimplement this in terms of -synchronouslyRequestInfo:.
556
557         (-[_WKAttachment expectRequestedDataToBe:]):
558         (TestWebKitAPI::TEST):
559
560 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
561
562         Copying, pasting, and then deleting an attachment element breaks attachment data requests
563         https://bugs.webkit.org/show_bug.cgi?id=181365
564         <rdar://problem/36340647>
565
566         Reviewed by Tim Horton.
567
568         Adds two new attachment API tests to verify that copying and pasting an existing attachment inserts an
569         attachment element that may be edited independently of the original attachment. See WebCore/ChangeLog for more
570         detail.
571
572         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
573         (TestWebKitAPI::TEST):
574
575 2018-01-08  Youenn Fablet  <youenn@apple.com>
576
577         navigator.onLine does not work inside service workers
578         https://bugs.webkit.org/show_bug.cgi?id=181079
579         <rdar://problem/36178606>
580
581         Reviewed by Darin Adler.
582
583         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
584         (WTR::InjectedBundle::initialize): Setting service worker creation callback to inject ServiceWorkerInternals object.
585
586 2018-01-07  Saam Barati  <sbarati@apple.com>
587
588         Add total exits and total compilations sorting mode to the "full" command in display-profiler-output
589         https://bugs.webkit.org/show_bug.cgi?id=181372
590
591         Reviewed by Filip Pizlo.
592
593         Adding these sorting modes makes it easier to analyze functions
594         that recompile a lot and exit a lot.
595
596         * Scripts/display-profiler-output:
597
598 2018-01-06  Julien Brianceau  <julien.brianceau@gmail.com>
599
600         Unreviewed, remove my Cisco email from contributors.json
601
602         * Scripts/webkitpy/common/config/contributors.json:
603
604 2018-01-05  JF Bastien  <jfbastien@apple.com>
605
606         WebAssembly: poison JS object's secrets
607         https://bugs.webkit.org/show_bug.cgi?id=181339
608         <rdar://problem/36325001>
609
610         Reviewed by Mark Lam.
611
612         Update tests for swap(Poisoned<k, T>, T*)
613
614         * TestWebKitAPI/Tests/WTF/ConstExprPoisoned.cpp:
615         (TestWebKitAPI::TEST):
616         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
617         (TestWebKitAPI::TEST):
618         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
619         (TestWebKitAPI::TEST):
620
621 2018-01-05  Wenson Hsieh  <wenson_hsieh@apple.com>
622
623         REGRESSION(r226396) DataInteractionTests: ContentEditableToContentEditable and ContentEditableToTextarea are failing
624         https://bugs.webkit.org/show_bug.cgi?id=181359
625
626         Reviewed by Tim Horton.
627
628         Ensure that these tests still pass using older SDKs.
629
630         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
631         (TestWebKitAPI::TEST):
632
633 2018-01-05  Alex Christensen  <achristensen@webkit.org>
634
635         Rebase API test after r226469
636         https://bugs.webkit.org/show_bug.cgi?id=181308
637
638         * TestWebKitAPI/Tests/WebKitCocoa/LoadInvalidURLRequest.mm:
639         (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
640         A URL with < or > in it is now recognized as invalid by WebKit.  This is intentional, and matches our behavior before enabling the new URLParser.
641
642 2018-01-05  Alex Christensen  <achristensen@webkit.org>
643
644         Restrict navigation-time WKWebsiteDataStore swapping to main frame navigations
645         https://bugs.webkit.org/show_bug.cgi?id=181217
646
647         Reviewed by Tim Horton.
648
649         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
650         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
651         (TEST):
652
653 2018-01-05  Alex Christensen  <achristensen@webkit.org>
654
655         Add WKBundleFrameCreateFrameHandle
656         https://bugs.webkit.org/show_bug.cgi?id=181232
657         <rdar://problem/35926696>
658
659         Reviewed by Tim Horton.
660
661         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
662         * TestWebKitAPI/Tests/WebKitCocoa/FrameHandleSerialization.mm: Added.
663         (mouseDidMoveOverElement):
664         (-[FrameHandleSerialization webProcessPlugIn:didCreateBrowserContextController:]):
665         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
666         (-[MouseMoveOverElementDelegate _webView:mouseDidMoveOverElement:withFlags:userInfo:]):
667         (TEST):
668
669 2018-01-05  Chris Fleizach  <cfleizach@apple.com>
670
671         iOS: Build fix after r226432.
672         
673         Unreviewed. Stop duplicating speakAs symbols for iOS.
674
675         * DumpRenderTree/AccessibilityUIElement.cpp:
676         (AccessibilityUIElement::speakAs):
677
678 2018-01-05  Javier Fernandez  <jfernandez@igalia.com>
679
680         Unreviewed, added myself as WebKit reviewer
681
682         * Scripts/webkitpy/common/config/contributors.json:
683
684 2018-01-05  Claudio Saavedra  <csaavedra@igalia.com>
685
686         WPE: Build fix after r226432.
687
688         Unreviewed. Rename ::speak() to ::speakAs().
689         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
690         (WTR::AccessibilityUIElement::speakAs):
691         (WTR::AccessibilityUIElement::speak): Deleted.
692
693 2018-01-04  Chris Fleizach  <cfleizach@apple.com>
694
695         AX: Implement updated CSS3 Speech for 'speak' and 'speak-as' properties
696         https://bugs.webkit.org/show_bug.cgi?id=180361
697
698         Reviewed by Zalan Bujtas.
699
700         * DumpRenderTree/AccessibilityUIElement.cpp:
701         (speakAsCallback):
702         (AccessibilityUIElement::speakAs):
703         (AccessibilityUIElement::getJSClass):
704         (speakCallback): Deleted.
705         (AccessibilityUIElement::speak): Deleted.
706         * DumpRenderTree/AccessibilityUIElement.h:
707         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
708         (AccessibilityUIElement::speakAs):
709         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
710         (AccessibilityUIElement::speakAs):
711         (AccessibilityUIElement::speak): Deleted.
712         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
713         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
714         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
715         (WTR::AccessibilityUIElement::speakAs):
716         (WTR::AccessibilityUIElement::speak): Deleted.
717         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
718         (WTR::AccessibilityUIElement::speakAs):
719         (WTR::AccessibilityUIElement::speak): Deleted.
720
721 2018-01-04  Jonathan Bedard  <jbedard@apple.com>
722
723         REGRESSION (r226395): test-webkitperl test expectations incorrect
724         https://bugs.webkit.org/show_bug.cgi?id=181307
725         <rdar://problem/36306558>
726
727         Rubber-stamped by Aakash Jain.
728
729         r226395 added two lines towards the beginning of
730         Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl, the line
731         numbers in the test expectations need to update.
732
733         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt:
734
735 2018-01-04  Tim Horton  <timothy_horton@apple.com>
736
737         WKWebView loses minimum layout size overrides that happen while the process is terminated
738         https://bugs.webkit.org/show_bug.cgi?id=181306
739         <rdar://problem/34398288>
740
741         Reviewed by Dan Bernstein.
742
743         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
744         (TEST):
745         Add a test that calling _overrideLayoutParametersWithMinimumLayoutSize
746         while the process is terminated results in the page getting the correct
747         minimum layout size.
748
749 2018-01-04  Eric Carlson  <eric.carlson@apple.com>
750
751         [MediaStream] Add Mock screen capture source
752         https://bugs.webkit.org/show_bug.cgi?id=181291
753         <rdar://problem/36298164>
754
755         Reviewed by Dean Jackson.
756
757         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test.
758         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
759         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
760
761 2018-01-04  Lucas Forschler  <lforschler@apple.com>
762
763         <rdar://problem/36300930> Change proxy server setting on master config to reach s3 servers
764
765         Reviewed by Ling Ho.
766
767         * BuildSlaveSupport/build.webkit.org-config/steps.py:
768
769 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
770
771         [Attachment Support] Create attachment elements when dropping files on iOS
772         https://bugs.webkit.org/show_bug.cgi?id=181192
773         <rdar://problem/36280945>
774
775         Reviewed by Tim Horton.
776
777         Adds 3 new API tests to exercise different use cases of dropping content as attachment elements when the runtime
778         switch is enabled. See below for more details.
779
780         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
781         (-[NSItemProvider registerData:type:]):
782         (platformCopyPNG):
783         (TestWebKitAPI::TEST):
784         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
785
786         Fix some currently failing iOS drag and drop tests. In this case, there's no reason RTFD should appear in the
787         source item provider when dragging rich text *without* attachments, so this should have been a check for just
788         kUTTypeRTF instead.
789
790         (TestWebKitAPI::TEST):
791
792         Tests a few cases of inserting attachment elements via drop:
793         1.  We should distinguish between drops containing rich/plain text files from just dropping rich/plain text.
794             Instead of inserting the contents as inline web content, this should generate attachment elements.
795         2.  Test the fallback mechanism for inserting attachment elements. If the preferred presentation style is not
796             explicitly set, but there's nothing WebKit would otherwise do with the dropped content, then we should fall
797             back to inserting the content as an attachment.
798         3.  Test that if multiple attachments and inline item providers are present, WebKit will respect the order in
799             which they were inserted by the source (as opposed to, for instance, putting all of the attachments in front
800             or at the end).
801
802         * TestWebKitAPI/cocoa/TestWKWebView.h:
803         * TestWebKitAPI/cocoa/TestWKWebView.mm:
804         (-[TestWKWebView objectByEvaluatingJavaScript:]):
805
806         Add a helper method to return an object that represents the result of evaluating some given script, and rewrite
807         -stringByEvaluatingJavaScript to just turn around and call this.
808
809         (-[TestWKWebView stringByEvaluatingJavaScript:]):
810
811 2018-01-03  Ting-Wei Lan  <lantw44@gmail.com>
812
813         Replace hard-coded paths in shebangs with #!/usr/bin/env
814         https://bugs.webkit.org/show_bug.cgi?id=181040
815
816         Reviewed by Alex Christensen.
817
818         * BuildSlaveSupport/build-launcher-app:
819         * BuildSlaveSupport/build-launcher-dmg:
820         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
821         * BuildSlaveSupport/built-product-archive:
822         * BuildSlaveSupport/clean-build:
823         * BuildSlaveSupport/delete-stale-build-files:
824         * BuildSlaveSupport/download-built-product:
825         * BuildSlaveSupport/gtk/buildbot/log/run:
826         * BuildSlaveSupport/gtk/buildbot/run:
827         * BuildSlaveSupport/gtk/pulseaudio/run:
828         * BuildSlaveSupport/kill-old-processes:
829         * BuildSlaveSupport/test-result-archive:
830         * BuildSlaveSupport/win/kill-old-processes:
831         * Scripts/SpacingHeuristics.pm:
832         * Scripts/add-include:
833         * Scripts/build-api-tests:
834         * Scripts/build-dumprendertree:
835         * Scripts/build-imagediff:
836         * Scripts/build-jsc:
837         * Scripts/build-webkit:
838         * Scripts/build-webkittestrunner:
839         * Scripts/check-Xcode-source-file-types:
840         * Scripts/check-dom-results:
841         * Scripts/check-for-exit-time-destructors:
842         * Scripts/check-for-global-initializers:
843         * Scripts/check-for-inappropriate-objc-class-names:
844         * Scripts/check-for-weak-vtables-and-externals:
845         * Scripts/clean-header-guards:
846         * Scripts/compare-timing-files:
847         * Scripts/configure-xcode-for-ios-development:
848         * Scripts/copy-webkitlibraries-to-product-directory:
849         * Scripts/create-exports:
850         * Scripts/debug-minibrowser:
851         * Scripts/debug-safari:
852         * Scripts/debug-test-runner:
853         * Scripts/do-file-rename:
854         * Scripts/do-webcore-rename:
855         * Scripts/dump-webkit-tests-run:
856         * Scripts/ensure-valid-python:
857         * Scripts/execAppWithEnv:
858         * Scripts/extract-localizable-js-strings:
859         * Scripts/filter-build-webkit:
860         * Scripts/find-extra-includes:
861         * Scripts/fix-blink-patch:
862         * Scripts/generate-coverage-data:
863         * Scripts/git-add-reviewer:
864         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
865         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz:
866         * Scripts/jsc-stress-test-helpers/js-osr-exit-fuzz:
867         * Scripts/make-new-script-test:
868         * Scripts/make-script-test-wrappers:
869         * Scripts/package-root:
870         * Scripts/parse-malloc-history:
871         * Scripts/report-include-statistics:
872         * Scripts/resolve-ChangeLogs:
873         * Scripts/run-api-tests:
874         * Scripts/run-bindings-tests:
875         * Scripts/run-content-extension-tester:
876         * Scripts/run-iexploder-tests:
877         * Scripts/run-javascriptcore-tests:
878         * Scripts/run-jsc:
879         * Scripts/run-leaks:
880         * Scripts/run-mangleme-tests:
881         * Scripts/run-minibrowser:
882         * Scripts/run-pageloadtest:
883         * Scripts/run-regexp-tests:
884         * Scripts/run-safari:
885         * Scripts/run-sunspider:
886         * Scripts/run-test-runner:
887         * Scripts/run-webkit-app:
888         * Scripts/run-webkit-httpd:
889         * Scripts/run-webkit-websocketserver:
890         * Scripts/set-webkit-configuration:
891         * Scripts/show-pretty-diff:
892         * Scripts/sort-Xcode-project-file:
893         * Scripts/split-file-by-class:
894         * Scripts/sunspider-compare-results:
895         * Scripts/svn-apply:
896         * Scripts/svn-unapply:
897         * Scripts/test-webkit-scripts:
898         * Scripts/test-webkitperl:
899         * Scripts/update-iexploder-cssproperties:
900         * Scripts/update-javascriptcore-test-results:
901         * Scripts/update-webkit:
902         * Scripts/update-webkit-auxiliary-libs:
903         * Scripts/update-webkit-dependency:
904         * Scripts/update-webkit-libs-jhbuild:
905         * Scripts/update-webkit-localizable-strings:
906         * Scripts/update-webkit-support-libs:
907         * Scripts/update-webkitgtk-libs:
908         * Scripts/update-webkitwpe-libs:
909         * Scripts/webkit-build-directory:
910         * Scripts/webkitperl/LoadAsModule.pm:
911         * Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl:
912         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
913         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl:
914         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl:
915         * Scripts/webkitperl/VCSUtils_unittest/generatePatchCommand.pl:
916         * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl:
917         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
918         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
919         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
920         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
921         * Scripts/webkitperl/VCSUtils_unittest/parseFirstEOL.pl:
922         * Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl:
923         * Scripts/webkitperl/VCSUtils_unittest/parsePatch.pl:
924         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
925         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
926         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
927         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
928         * Scripts/webkitperl/VCSUtils_unittest/parseUnifiedDiffHeader.pl:
929         * Scripts/webkitperl/VCSUtils_unittest/prepareParsedPatch.pl:
930         * Scripts/webkitperl/VCSUtils_unittest/removeEOL.pl:
931         * Scripts/webkitperl/VCSUtils_unittest/runCommand.pl:
932         * Scripts/webkitperl/VCSUtils_unittest/runPatchCommand.pl:
933         * Scripts/webkitperl/VCSUtils_unittest/setChangeLogDateAndReviewer.pl:
934         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl:
935         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl:
936         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
937         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl:
938         * Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl:
939         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl:
940         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
941         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
942         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:
943         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl:
944         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl:
945         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl:
946         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRef.pl:
947         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl:
948         * Scripts/webkitperl/webkitdirs_unittest/extractNonMacOSHostConfiguration.pl:
949         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl:
950         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
951         * ccache/ccache-clang:
952         * ccache/ccache-clang++:
953         * ccache/ccache-wrapper:
954         * gtk/install-dependencies:
955         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi:
956         * iExploder/iexploder-1.3.2/htdocs/webserver.rb:
957         * iExploder/iexploder-1.3.2/tools/lasthit.rb:
958         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb:
959         * iExploder/iexploder-1.3.2/tools/showtest.rb:
960         * iExploder/iexploder-1.7.2/src/browser_harness.rb:
961         * iExploder/iexploder-1.7.2/src/iexploder.cgi:
962         * iExploder/iexploder-1.7.2/src/webserver.rb:
963         * iExploder/iexploder-1.7.2/tools/lasthit.rb:
964         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb:
965         * wpe/install-dependencies:
966
967 2018-01-03  Simon Fraser  <simon.fraser@apple.com>
968
969         filter-build-webkit filters out useful compiler error lines
970         https://bugs.webkit.org/show_bug.cgi?id=179864
971
972         Reviewed by Tim Horton.
973
974         Don't filter out lines that contain information about build errors by always showing lines
975         after a line that contains "note:" or "error:".
976
977         * Scripts/filter-build-webkit:
978         (shouldShowSubsequentLine):
979         (shouldIgnoreLine):
980
981 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
982
983         REGRESSION(r226366): [GTK] Broke TestBackForwardList and TestWebKitWebView
984         https://bugs.webkit.org/show_bug.cgi?id=173915
985
986         Unreviewed follow-up. Fix /webkit2/WebKitWebView/session-state-with-form-data and
987         /webkit2/WebKitWebView/submit-form. The form ID may be NULL, but we can't put NULL into a
988         GVariant unless we use maybe types, and maybe types are incompatible with D-Bus. So use an
989         empty string in this case.
990
991         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
992         (emitFormSubmissionEvent):
993
994 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
995
996         [GTK] Add web process API to detect when form is submitted via JavaScript
997         https://bugs.webkit.org/show_bug.cgi?id=173915
998
999         Reviewed by Carlos Garcia Campos.
1000
1001         Test it.
1002
1003         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
1004         (FormSubmissionTest::FormSubmissionTest):
1005         (FormSubmissionTest::~FormSubmissionTest):
1006         (FormSubmissionTest::testFormSubmissionResult):
1007         (FormSubmissionTest::willSendDOMEventCallback):
1008         (FormSubmissionTest::willCompleteCallback):
1009         (FormSubmissionTest::runJavaScriptAndWaitUntilFormSubmitted):
1010         (testWebExtensionFormSubmissionSteps):
1011         (beforeAll):
1012         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1013         (DelayedSignal::DelayedSignal):
1014         (emitFormSubmissionEvent):
1015         (handleFormSubmissionCallback):
1016         (willSubmitFormCallback):
1017         (pageCreatedCallback):
1018
1019 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1020
1021         Unreviewed, skip broken API test /webkit2/WebKitWebsiteData/databases
1022         https://bugs.webkit.org/show_bug.cgi?id=181251
1023
1024         * Scripts/run-gtk-tests:
1025         (GtkTestRunner):
1026
1027 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1028
1029         Unreviewed, skip broken API test /webkit2/WebKitWebsiteData/ephemeral
1030         https://bugs.webkit.org/show_bug.cgi?id=181136
1031
1032         * Scripts/run-gtk-tests:
1033         (GtkTestRunner):
1034
1035 2018-01-02  Brent Fulgham  <bfulgham@apple.com>
1036
1037         [macOS, iOS] Adopt new secure coding APIs in WebKit
1038         https://bugs.webkit.org/show_bug.cgi?id=181085
1039         <rdar://problem/34837397>
1040
1041         Reviewed by Tim Horton.
1042
1043         Update API tests to use secure coding wherever possible. Currently, NSView/UIView-based classes are not
1044         capable of supporting NSSecureCoding, so pass through the current coding routines.
1045
1046         * TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm: Updated for NSSecureCoding.
1047         * TestWebKitAPI/Tests/WebKitCocoa/Coding.mm:
1048         (encodeAndDecode): Check if class supports the NSSecureCoding protocol and use non-secure coding
1049         routines if necessary.
1050         (TEST): Updated for NSSecureCoding.
1051         * TestWebKitAPI/Tests/mac/EarlyKVOCrash.mm:
1052         (TestWebKitAPI::TEST): Updated for NSSecureCoding.
1053
1054 2017-12-28  Yusuke Suzuki  <utatane.tea@gmail.com>
1055
1056         Remove std::chrono completely
1057         https://bugs.webkit.org/show_bug.cgi?id=181186
1058
1059         Reviewed by Alex Christensen.
1060
1061         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1062         (WTR::TestController::platformRunUntil):
1063
1064 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
1065
1066         REGRESSION(r223253): Broke ResourceLoadStatistics layout tests for non-Cocoa ports
1067         https://bugs.webkit.org/show_bug.cgi?id=181231
1068
1069         Reviewed by Alex Christensen.
1070
1071         Implement TestController APIs needed by ResourceLoadStatistics tests.
1072
1073         * WebKitTestRunner/TestController.cpp:
1074         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
1075         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
1076
1077 2018-01-02  Tim Horton  <timothy_horton@apple.com>
1078
1079         Disable WKAttachmentTests if UIPasteboard.itemProviders is not available
1080         https://bugs.webkit.org/show_bug.cgi?id=181219
1081
1082         Reviewed by Wenson Hsieh.
1083
1084         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1085
1086 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
1087
1088         Add a WebAuthentication runtime feature flag
1089         https://bugs.webkit.org/show_bug.cgi?id=181220
1090         <rdar://problem/36055305>
1091
1092         Reviewed by Brent Fulgham.
1093
1094         Renames the CredentialManagement runtime feature flag into WebAuthentication.
1095
1096         * DumpRenderTree/TestOptions.h:
1097         * DumpRenderTree/TestOptions.mm:
1098         (TestOptions::TestOptions):
1099         * DumpRenderTree/mac/DumpRenderTree.mm:
1100         (enableExperimentalFeatures):
1101         (setWebPreferencesForTestOptions):
1102         * WebKitTestRunner/TestController.cpp:
1103         (WTR::TestController::resetPreferencesToConsistentValues):
1104         (WTR::updateTestOptionsFromTestHeader):
1105         * WebKitTestRunner/TestOptions.h:
1106         (WTR::TestOptions::hasSameInitializationOptions const):
1107
1108 2018-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1109
1110         [Attachment Support] Don't Blob-convert images and attachments with https:, http: or data: urls
1111         https://bugs.webkit.org/show_bug.cgi?id=181143
1112         <rdar://problem/36200381>
1113
1114         Reviewed by Tim Horton.
1115
1116         Add a new API test to ensure that a copied image with a data URL does not get pasted as an attachment when
1117         attachment elements are enabled.
1118
1119         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1120         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1121         (TestWebKitAPI::TEST):
1122
1123 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
1124
1125         Update Credential Management API for WebAuthentication
1126         https://bugs.webkit.org/show_bug.cgi?id=181082
1127         <rdar://problem/36055239>
1128
1129         Reviewed by Brent Fulgham.
1130
1131         Enable Credential Management API for testing.
1132
1133         * DumpRenderTree/TestOptions.h:
1134         * WebKitTestRunner/TestOptions.h:
1135
1136 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
1137
1138         [GTK] Test /webkit2/WebKitWebExtension/form-controls-associated-signal is flaky
1139         https://bugs.webkit.org/show_bug.cgi?id=168194
1140
1141         Reviewed by Carlos Garcia Campos.
1142
1143         Fix an assertion and unskip the test. The order that form controls are associated is not
1144         guaranteed.
1145
1146         * Scripts/run-gtk-tests:
1147         (GtkTestRunner):
1148         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
1149         (didAssociateFormControlsCallback):
1150
1151 2018-01-02  Alex Christensen  <achristensen@webkit.org>
1152
1153         Use new WebsiteDataStore passed in through decidePolicyForNavigation SPI
1154         https://bugs.webkit.org/show_bug.cgi?id=180897
1155         <rdar://problem/35535328>
1156
1157         Reviewed by Brent Fulgham.
1158
1159         Test two forms of storage to be sure we are using a different WebsiteDataStore: cookies and sessionStorage.
1160
1161         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1162         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1163         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:startURLSchemeTask:]):
1164         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1165         (websiteDataStoreTestWebView):
1166         (TEST):
1167
1168 == Rolled over to ChangeLog-2018-01-01 ==