[LFC][BCF] Add support for block level non-replaced inflow height percentage
[WebKit-https.git] / Tools / ChangeLog
1 2018-11-04  Zalan Bujtas  <zalan@apple.com>
2
3         [LFC][BCF] Add support for block level non-replaced inflow height percentage
4         https://bugs.webkit.org/show_bug.cgi?id=191229
5
6         Reviewed by Antti Koivisto.
7
8         * LayoutReloaded/misc/LFC-passing-tests.txt:
9
10 2018-11-02  Zalan Bujtas  <zalan@apple.com>
11
12         [LFC][BFC] Resolve percentage height values.
13         https://bugs.webkit.org/show_bug.cgi?id=191224
14
15         Reviewed by Antti Koivisto.
16
17         * LayoutReloaded/misc/LFC-passing-tests.txt:
18
19 2018-11-03  Alex Christensen  <achristensen@webkit.org>
20
21         Mac production builds should sign the network process xpc service with entitlements
22         https://bugs.webkit.org/show_bug.cgi?id=191209
23         <rdar://problem/45377609>
24
25         Reviewed by Geoff Garen.
26
27         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
28         * TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm: Added.
29         (TEST):
30
31 2018-11-02  Alex Christensen  <achristensen@webkit.org>
32
33         Unreviewed, rolling out r237761.
34
35         Makes most API tests timeout and WK2 tests crash
36
37         Reverted changeset:
38
39         "Mac production builds should sign the network process xpc
40         service with entitlements"
41         https://bugs.webkit.org/show_bug.cgi?id=191209
42         https://trac.webkit.org/changeset/237761
43
44 2018-11-02  Michael Catanzaro  <mcatanzaro@igalia.com>
45
46         Unreviewed API test gardening
47
48         * TestWebKitAPI/glib/TestExpectations.json:
49
50 2018-11-02  Justin Michaud  <justin_michaud@apple.com>
51
52         Add new global object and preliminary Worklets support for CSS painting api
53         https://bugs.webkit.org/show_bug.cgi?id=190979
54
55         Reviewed by Chris Dumez.
56
57         * Scripts/webkitpy/bindings/main.py:
58         (BindingsTests.generate_supplemental_dependency):
59         (BindingsTests.main):
60
61 2018-11-02  Alex Christensen  <achristensen@webkit.org>
62
63         Mac production builds should sign the network process xpc service with entitlements
64         https://bugs.webkit.org/show_bug.cgi?id=191209
65         <rdar://problem/45377609>
66
67         Reviewed by Geoff Garen.
68
69         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
70         * TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm: Added.
71         (TEST):
72
73 2018-11-02  Lucas Forschler  <lforschler@apple.com>
74
75         Add Windows 10 archive bots
76         https://bugs.webkit.org/show_bug.cgi?id=190964
77         
78         This Change updates the Apple Windows Buildbot configuration.
79         - Add Windows 10 specific builders and testers for release and debug.
80         - Refactor Windows -> Windows 7.
81         - Remove Windows 7 Debug.
82
83         Reviewed by Aakash Jain.
84
85         * BuildSlaveSupport/build.webkit.org-config/config.json:
86
87 2018-11-02  Philippe Normand  <pnormand@igalia.com>
88
89         [GTK][WPE] Enable GST_DEBUG_NO_COLOR environment variable pass-through
90
91         Rubber-stamped by Michael Catanzaro.
92
93         This variable is useful to get rid of shell color escapes in tests stderr files.
94
95         * Scripts/webkitpy/port/gtk.py:
96         (GtkPort.setup_environ_for_server):
97         * Scripts/webkitpy/port/wpe.py:
98         (WPEPort.setup_environ_for_server):
99
100 2018-11-02  Aakash Jain  <aakash_jain@apple.com>
101
102         Add Basic Django web app for OpenSource EWS
103         https://bugs.webkit.org/show_bug.cgi?id=191091
104
105         Reviewed by Lucas Forschler.
106
107         * BuildSlaveSupport/EWS_app/manage.py: Added, auto-generated by Django.
108         * BuildSlaveSupport/EWS_app/EWS_app/__init__.py: Added, auto-generated by Django.
109         * BuildSlaveSupport/EWS_app/EWS_app/settings.py: Added, auto-generated by Django.
110         * BuildSlaveSupport/EWS_app/EWS_app/urls.py: Added, auto-generated by Django.
111         * BuildSlaveSupport/EWS_app/EWS_app/wsgi.py: Added, auto-generated by Django.
112         * BuildSlaveSupport/EWS_app/ews/__init__.py: Added.
113         * BuildSlaveSupport/EWS_app/ews/admin.py: Added, auto-generated by Django.
114         * BuildSlaveSupport/EWS_app/ews/apps.py: Added, auto-generated by Django.
115         * BuildSlaveSupport/EWS_app/ews/migrations/__init__.py: Added.
116         * BuildSlaveSupport/EWS_app/ews/tests.py: Added, auto-generated by Django.
117         * BuildSlaveSupport/EWS_app/ews/models/__init__.py: Added.
118         * BuildSlaveSupport/EWS_app/ews/models/patch.py: Added.
119         * BuildSlaveSupport/EWS_app/ews/views/__init__.py: Added.
120         * BuildSlaveSupport/EWS_app/ews/views/patch.py: Added.
121
122 2018-11-02  Daniel Bates  <dabates@apple.com>
123
124         [iOS] WebKit should dispatch DOM events when a modifier key is pressed
125         https://bugs.webkit.org/show_bug.cgi?id=190487
126
127         Reviewed by Tim Horton.
128
129         Update the code for renamed enumerations. For WebKitTestRunner, removed comment that does not
130         match my observations when using the simulator to simulate iOS 12 and add support for testing
131         right-hand side modifiers.
132
133         * DumpRenderTree/mac/EventSendingController.mm:
134         (modifierFlags):
135         (-[EventSendingController keyDown:withModifiers:withLocation:]):
136         (-[EventSendingController setTouchModifier:value:]):
137         * WebKitTestRunner/ios/HIDEventGenerator.mm:
138         (hidUsageCodeForCharacter):
139
140 2018-11-02  Chris Dumez  <cdumez@apple.com>
141
142         [PSON] Reuse SuspendedPages' process when possible, for performance
143         https://bugs.webkit.org/show_bug.cgi?id=191166
144
145         Reviewed by Geoffrey Garen.
146
147         Add API test coverage.
148
149         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
150
151 2018-11-02  Zalan Bujtas  <zalan@apple.com>
152
153         [LFC][IFC] Add support for intrinsic width calculation
154         https://bugs.webkit.org/show_bug.cgi?id=191144
155
156         Reviewed by Antti Koivisto.
157
158         * LayoutReloaded/misc/LFC-passing-tests.txt:
159
160 2018-11-01  Philippe Normand  <pnormand@igalia.com>
161
162         [Apache] Self-signed SSL certificate RSA key is considered too weak
163         https://bugs.webkit.org/show_bug.cgi?id=191156
164
165         Reviewed by Michael Catanzaro.
166
167         * Scripts/webkitpy/common/system/pemfile.py:
168
169 2018-11-02  Zan Dobersek  <zdobersek@igalia.com>
170
171         Unreviewed follow-up to r237678.
172
173         * wpe/jhbuild.modules: The patch element apparently has to be a child
174         of the branch in order for Jhbuild to properly detect and apply the
175         patch file.
176
177 2018-11-01  Ross Kirsling  <ross.kirsling@sony.com>
178
179         build-jsc --wincairo should update WinCairo libraries
180         https://bugs.webkit.org/show_bug.cgi?id=191170
181
182         Reviewed by Fujii Hironori.
183
184         * Scripts/build-jsc:
185
186 2018-11-01  John Wilander  <wilander@apple.com>
187
188         In WebCore::ResourceLoadObserver, use document.sessionID().isEphemeral() when possible and check for page existence when not
189         https://bugs.webkit.org/show_bug.cgi?id=191119
190         <rdar://problem/44176965>
191
192         Reviewed by Chris Dumez.
193
194         This is an API test for a WebKitLegacy WebView that is first closed and then
195         JavaScript is handed a keyboard event.
196
197         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
198         * TestWebKitAPI/Tests/WebKitLegacy/mac/ClosingWebView.mm: Added.
199         (-[ClosingWebViewThenSendingItAKeyDownEventLoadDelegate webView:didFinishLoadForFrame:]):
200         (-[KeyboardEventListener handleEvent:]):
201         (TestWebKitAPI::TEST):
202
203 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
204
205         Add a storage limit for IndexedDB
206         https://bugs.webkit.org/show_bug.cgi?id=190598
207         <rdar://problem/44654715>
208
209         Reviewed by Chris Dumez.
210
211         Add API for testing.
212
213         * DumpRenderTree/TestRunner.cpp:
214         (setIDBPerOriginQuotaCallback):
215         (TestRunner::staticFunctions):
216         * DumpRenderTree/TestRunner.h:
217         * DumpRenderTree/mac/TestRunnerMac.mm:
218         (TestRunner::setIDBPerOriginQuota):
219         * DumpRenderTree/win/TestRunnerWin.cpp:
220         (TestRunner::setIDBPerOriginQuota):
221         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
222         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
223         (WTR::TestRunner::setIDBPerOriginQuota):
224         * WebKitTestRunner/InjectedBundle/TestRunner.h:
225         * WebKitTestRunner/TestController.cpp:
226         (WTR::TestController::setIDBPerOriginQuota):
227         * WebKitTestRunner/TestController.h:
228         * WebKitTestRunner/TestInvocation.cpp:
229         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
230
231 2018-11-01  Chris Dumez  <cdumez@apple.com>
232
233         [PSON] WebPageProxy::receivedNavigationPolicyDecision() should not schedule the new load asynchronously when process-swapping
234         https://bugs.webkit.org/show_bug.cgi?id=191076
235
236         Reviewed by Geoffrey Garen.
237
238         Add API test coverage.
239
240         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
241         (-[PSONNavigationDelegate init]):
242         (-[PSONNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
243
244 2018-11-01  Adrian Perez de Castro  <aperez@igalia.com>
245
246         Fix build with VIDEO and WEB_AUDIO disabled
247         https://bugs.webkit.org/show_bug.cgi?id=191147
248         <rdar://problem/45726710>
249
250         Unreviewed build fix.
251
252         This adds the missing compilation guards in the WPE MiniBrowser.
253
254         * MiniBrowser/wpe/main.cpp:
255         (main): Condition GST includes and calls.
256
257 2018-10-31  Zalan Bujtas  <zalan@apple.com>
258
259         [LFC][IFC] Add support for inline-block elements.
260         https://bugs.webkit.org/show_bug.cgi?id=191143
261
262         Reviewed by Antti Koivisto.
263
264         * LayoutReloaded/misc/LFC-passing-tests.txt:
265
266 2018-11-01  Claudio Saavedra  <csaavedra@igalia.com>
267
268         [WPE] Add missing libsoup patch to jhbuild
269         https://bugs.webkit.org/show_bug.cgi?id=191149
270
271         Reviewed by Žan Doberšek.
272
273         * wpe/jhbuild.modules:
274         * wpe/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Added.
275
276 2018-11-01  Claudio Saavedra  <csaavedra@igalia.com>
277
278         Fix build with VIDEO and WEB_AUDIO disabled
279         https://bugs.webkit.org/show_bug.cgi?id=191147
280
281         Reviewed by Philippe Normand.
282
283         * MiniBrowser/gtk/main.c:
284         (main): Condition GST includes and calls
285
286 2018-10-31  Justin Michaud  <justin_michaud@apple.com>
287
288         Add Justin Michaud to the list of WebKit Committers
289         https://bugs.webkit.org/show_bug.cgi?id=191142
290
291         * Scripts/webkitpy/common/config/contributors.json:
292
293 2018-10-31  Guillaume Emont  <guijemont@igalia.com>
294
295         Don't run JIT tests on 32-bit platforms
296         https://bugs.webkit.org/show_bug.cgi?id=191074
297
298         Reviewed by Michael Catanzaro.
299
300         * Scripts/run-jsc-stress-tests:
301
302 2018-10-30  Wenson Hsieh  <wenson_hsieh@apple.com>
303
304         [Cocoa] Attachment dropped from one web view to another is missing its file wrapper
305         https://bugs.webkit.org/show_bug.cgi?id=190530
306         <rdar://problem/45232149>
307
308         Reviewed by Tim Horton.
309
310         Add a test to verify that copying different types of attachments and pasting in a new web view inserts
311         attachments in the second web view that are backed by _WKAttachment objects, whose NSFileWrappers hold data that
312         is equivalent to the original file wrappers used to insert attachments in the first web view.
313
314         Existing API tests verify that when copying and pasting within a single web view, the pasted attachment element
315         is still backed by the same NSFileWrapper instance.
316
317         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
318         (TestWebKitAPI::TEST):
319
320 2018-10-30  Fujii Hironori  <Hironori.Fujii@sony.com>
321
322         [Win] Remove obsolete code for Visual Studio Express in webkitdirs.pm
323         https://bugs.webkit.org/show_bug.cgi?id=190949
324
325         Reviewed by Alex Christensen.
326
327         Visual Studio 2017 Community is the alternative.
328
329         * Scripts/webkitdirs.pm: Remove $willUseVCExpressWhenBuilding variable.
330         (setupCygwinEnv): Remove obsolete code for Visual Studio Express.
331         (buildVisualStudioProject): Ditto.
332         (dieIfWindowsPlatformSDKNotInstalled): Deleted.
333         (usingVisualStudioExpress): Deleted.
334
335 2018-10-30  Fujii Hironori  <Hironori.Fujii@sony.com>
336
337         [Win][Direct2D] Support building DumpRenderTree for Direct2D
338         https://bugs.webkit.org/show_bug.cgi?id=191093
339         <rdar://problem/45685706>
340
341         Unreviewed build fix.
342
343         error C2065: 'renderTarget': undeclared identifier
344
345         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
346         (createBitmapContextFromWebView): Restored the previous implementation.
347
348 2018-10-30  Don Olmstead  <don.olmstead@sony.com>
349
350         [PlayStation] Enable JavaScriptCore
351         https://bugs.webkit.org/show_bug.cgi?id=191072
352
353         Reviewed by Brent Fulgham.
354
355         Add platform scripts for building the PlayStation port.
356         perl Tools/Scripts/build-webkit --playstation
357
358         * Scripts/build-webkit:
359         * Scripts/build-webkittestrunner:
360         * Scripts/webkitdirs.pm:
361         (argumentsForConfiguration):
362         (determineConfigurationProductDir):
363         (isPlayStation): Added.
364         (getMSBuildPlatformArgument): Added.
365         (buildVisualStudioProject):
366         (wrapperPrefixIfNeeded):
367         (generateBuildSystemFromCMakeProject):
368         * TestWebKitAPI/PlatformPlayStation.cmake: Added.
369
370 2018-10-30  Brent Fulgham  <bfulgham@apple.com>
371
372         [Win][Direct2D] Support building DumpRenderTree for Direct2D
373         https://bugs.webkit.org/show_bug.cgi?id=191093
374         <rdar://problem/45685706>
375
376         Reviewed by Alex Christensen.
377
378         * DumpRenderTree/PixelDumpSupport.cpp: Update for Direct2D use.
379         * DumpRenderTree/PlatformWin.cmake: Add support for Direct2D build.
380         * DumpRenderTree/win/PixelDumpSupportDirect2D.cpp: Added.
381         (pixelDumpSystemFactory): Added.
382         (printPNG): Create stub.
383         (computeMD5HashStringForBitmapContext): Ditto.
384         (dumpBitmap): Ditto.
385         * DumpRenderTree/win/PixelDumpSupportDirect2D.h: Added.
386         (BitmapContext::createByAdoptingBitmapAndContext):
387         (BitmapContext::~BitmapContext):
388         (BitmapContext::platformContext const):
389         (BitmapContext::BitmapContext):
390         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
391         (createBitmapContextFromWebView): Update to support Direct2D.
392         * MiniBrowser/win/MiniBrowserReplace.h: Drive-by fix: The old WebKit
393         logo is no longer available at this location. Switch to the new logo.
394
395 2018-10-30  Jonathan Bedard  <jbedard@apple.com>
396
397         webkitpy: Support alternate simctl list outputs
398         https://bugs.webkit.org/show_bug.cgi?id=191090
399         <rdar://problem/45684255>
400
401         Rubber-stamped by Aakash Jain.
402
403         * Scripts/webkitpy/xcode/simulated_device.py:
404         (SimulatedDeviceManager._create_runtimes): Support alternative availability format.
405         (SimulatedDeviceManager._create_device_with_runtime): Ditto.
406         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
407         (test_available_devices): Add iOS 12 with alternative availability format.
408
409 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
410
411         Clean up some obsolete MAX_ALLOWED macros
412         https://bugs.webkit.org/show_bug.cgi?id=190916
413
414         Reviewed by Tim Horton.
415
416         * TestWebKitAPI/Tests/WTF/darwin/WeakLinking.cpp:
417         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
418         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
419
420 2018-10-30  Claudio Saavedra  <csaavedra@igalia.com>
421
422         [GTK][WPE] Fixes to the PublicSuffix implementation
423         https://bugs.webkit.org/show_bug.cgi?id=191031
424
425         Reviewed by Michael Catanzaro.
426
427         * TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:
428         (TestWebKitAPI::TEST_F): Remove a test for a domain
429         that is not registrable and shouldn't be tested there.
430
431 2018-10-29  Tim Horton  <timothy_horton@apple.com>
432
433         Modernize WebKit nibs and lprojs for localization's sake
434         https://bugs.webkit.org/show_bug.cgi?id=190911
435         <rdar://problem/45349466>
436
437         Reviewed by Dan Bernstein.
438
439         * Scripts/check-inspector-strings:
440         * Scripts/update-webkit-localizable-strings:
441         * gtk/manifest.txt.in:
442         * wpe/manifest.txt.in:
443         English->en
444
445 2018-10-29  Daniel Bates  <dabates@apple.com>
446
447         [lldb-webkit] Last aliased enumerator in OptionSet is printed; should print first enumerator
448         https://bugs.webkit.org/show_bug.cgi?id=191036
449
450         Reviewed by Andy Estes.
451
452         Prefer the first enumerator (in parse order) when pretty-printing an OptionSet that is parameterized
453         by an enum that contains two or more enumerators with the same value. For example, suppose
454         you have the following enum:
455
456         enum Flag {
457             A = 1 << 0,
458             AAlias = A,
459         };
460
461         Then pretty-printing OptionSet<Flag>(Flag::A) should print A instead of AAlias. A side effect of
462         this change is that OptionSet<Flag>(Flag::AAlias) will also print A as its only member as we cannot
463         differentiate between A and Alias. This should be acceptable in practice as aliased enumerators
464         tend to be used in bounds checks as opposed to code that adds to a set.
465
466         * lldb/lldbWebKitTester/main.cpp:
467         (testSummaryProviders):
468         * lldb/lldb_webkit.py:
469         (WTFOptionSetProvider.update):
470         * lldb/lldb_webkit_unittest.py:
471         (TestSummaryProviders.serial_test_WTFOptionSetProvider_simple):
472         (TestSummaryProviders):
473         (TestSummaryProviders.serial_test_WTFOptionSetProvider_aliased_flag):
474
475 2018-10-29  Daniel Bates  <dabates@apple.com>
476
477         [llbd-webkit] Add summaries for Document, Frame, and SecurityOrigin
478         https://bugs.webkit.org/show_bug.cgi?id=191033
479
480         Reviewed by Andy Estes.
481
482         For Documents we display its origin, URL, whether it's in the main frame, and its page cache state.
483         We display the same details in the summary for a Frame because its Document tends to be the most
484         interesting aspect of it. For SecurityOrigin we display its origin, domain (affects cookie access),
485         and whether the origin has universal access.
486
487         * lldb/lldb_webkit.py:
488         (__lldb_init_module):
489         Register new summary providers.
490
491         (WebCoreSecurityOrigin_SummaryProvider):
492         (WebCoreFrame_SummaryProvider):
493         (WebCoreDocument_SummaryProvider):
494         Add new summary providers.
495
496         (StdOptionalWrapper):
497         (StdOptionalWrapper.__init__):
498         (StdOptionalWrapper.has_value):
499         (StdOptionalWrapper.value):
500         Convenience data type that provides access to the fields of a std::optional<>.
501         
502         (WebCoreSecurityOriginProvider):
503         (WebCoreSecurityOriginProvider.__init__):
504         (WebCoreSecurityOriginProvider.is_unique):
505         (WebCoreSecurityOriginProvider.scheme):
506         (WebCoreSecurityOriginProvider.host):
507         (WebCoreSecurityOriginProvider.port):
508         (WebCoreSecurityOriginProvider.domain):
509         (WebCoreSecurityOriginProvider.has_universal_access):
510         (WebCoreSecurityOriginProvider.to_string):
511         (WebCoreFrameProvider):
512         (WebCoreFrameProvider.__init__):
513         (WebCoreFrameProvider.is_main_frame):
514         (WebCoreFrameProvider.document):
515         (WebCoreDocumentProvider):
516         (WebCoreDocumentProvider.__init__):
517         (WebCoreDocumentProvider.url):
518         (WebCoreDocumentProvider.origin):
519         (WebCoreDocumentProvider.page_cache_state):
520         (WebCoreDocumentProvider.frame):
521
522 2018-10-29  Chris Dumez  <cdumez@apple.com>
523
524         [PSON] When Safari restores session state after launching, going back and forward does not swap processes
525         https://bugs.webkit.org/show_bug.cgi?id=190975
526         <rdar://problem/45059256>
527
528         Reviewed by Antti Koivisto.
529
530         Add API test coverage.
531
532         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
533
534 2018-10-29  Zalan Bujtas  <zalan@apple.com>
535
536         [LFC][IFC] Compute estimated margin top for inline formatting root's ancestors
537         https://bugs.webkit.org/show_bug.cgi?id=191018
538
539         Reviewed by Antti Koivisto.
540
541         * LayoutReloaded/misc/LFC-passing-tests.txt:
542
543 2018-10-29  Zalan Bujtas  <zalan@apple.com>
544
545         [LFC] Add support for inflow non replaced content height when the box is an inline formatting root.
546         https://bugs.webkit.org/show_bug.cgi?id=191011
547
548         Reviewed by Antti Koivisto.
549
550         * LayoutReloaded/misc/LFC-passing-tests.txt:
551
552 2018-10-29  Zalan Bujtas  <zalan@apple.com>
553
554         Missing from r237549
555
556         Reviewed by Antti Koivisto.
557
558         * LayoutReloaded/misc/LFC-passing-tests.txt:
559
560 2018-10-29  Zalan Bujtas  <zalan@apple.com>
561
562         [LFC][IFC] Add support for simple intruding floats.
563         https://bugs.webkit.org/show_bug.cgi?id=190998
564
565         Reviewed by Antti Koivisto.
566
567         * LayoutReloaded/misc/LFC-passing-tests.txt:
568
569 2018-10-29  Zalan Bujtas  <zalan@apple.com>
570
571         [LFC][IFC] Inline layout produces separate runs when float is present.
572         https://bugs.webkit.org/show_bug.cgi?id=190980
573
574         Reviewed by Antti Koivisto.
575
576         * LayoutReloaded/misc/LFC-passing-tests.txt:
577
578 2018-10-29  Tadeu Zagallo  <tzagallo@apple.com>
579
580         New bytecode format for JSC
581         https://bugs.webkit.org/show_bug.cgi?id=187373
582         <rdar://problem/44186758>
583
584         Reviewed by Filip Pizlo.
585
586         Do not force ENABLE_JIT=true when $forceCLoop is false.
587
588         * Scripts/build-jsc:
589
590 2018-10-29  Claudio Saavedra  <csaavedra@igalia.com>
591
592         [GTK] Try to fix the xserver-xorg build in the Ubuntu LTS bot
593
594         Unreviewed build fix
595
596         The build fails because of some array-bound check related
597         to strcmp() macro optimizations. Disabling selective Werrors
598         when building xserver-xorg might get past this.
599
600         * gtk/jhbuild.modules: Add --disable-selective-werror to xserver-xorg
601         configuration.
602
603 2018-10-29  Claudio Saavedra  <csaavedra@igalia.com>
604
605         [GTK] Update API test expectations after r237383
606         https://bugs.webkit.org/show_bug.cgi?id=186913
607
608         Unreviewed gardening.
609
610         * TestWebKitAPI/glib/TestExpectations.json: Remove
611         passing TestSSL tests.
612
613 2018-10-28  Zan Dobersek  <zdobersek@igalia.com>
614
615         [WPE] Add the WebKitVersion.h header
616         https://bugs.webkit.org/show_bug.cgi?id=191015
617
618         Reviewed by Michael Catanzaro.
619
620         * MiniBrowser/wpe/main.cpp:
621         (automationStartedCallback): Remove the FIXME and finally enable the
622         webkit_application_info_set_version() call.
623         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp: Remove
624         this FIXME as well and remove the custom WEBKIT_*_VERSION macros.
625
626 2018-10-28  Fujii Hironori  <Hironori.Fujii@sony.com>
627
628         [Win] Remove obsolete code for vcxproj builds in build-api-tests and build-jsc
629         https://bugs.webkit.org/show_bug.cgi?id=190948
630
631         Reviewed by Brent Fulgham.
632
633         vcxproj files have been removed in Bug 154388.
634
635         * Scripts/build-api-tests: Removed obsolete code to build vcproj.
636         * Scripts/build-jsc:
637         (buildMyProject): Ditto. Removed a condition of buiding bmalloc
638         which is not used because Windows ports are using CMake.
639
640 2018-10-28  Geoffrey Garen  <ggaren@apple.com>
641
642         HashMap should support selecting a random entry
643         https://bugs.webkit.org/show_bug.cgi?id=190814
644
645         Reviewed by Ryosuke Niwa.
646
647         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Renamed IsRandom to
648         IsEvenlyDistributed to reflect the fact that we're only testing the
649         distribution. Added a test case that covers more table densities and
650         the remove() operation.
651
652 2018-10-27  Charlie Turner  <cturner@igalia.com>
653
654         [GTK] Add bubblewrap feature option
655         https://bugs.webkit.org/show_bug.cgi?id=190981
656
657         Reviewed by Xabier Rodriguez-Calvar.
658
659         Without this, it was not possible to disable the bubblewrap sandbox
660         from the webkit build scripts.
661
662         * Scripts/webkitperl/FeatureList.pm:
663
664 2018-10-26  Commit Queue  <commit-queue@webkit.org>
665
666         Unreviewed, rolling out r237479 and r237484.
667         https://bugs.webkit.org/show_bug.cgi?id=190978
668
669         broke JSC on iOS (Requested by tadeuzagallo on #webkit).
670
671         Reverted changesets:
672
673         "New bytecode format for JSC"
674         https://bugs.webkit.org/show_bug.cgi?id=187373
675         https://trac.webkit.org/changeset/237479
676
677         "Gardening: Build fix after r237479."
678         https://bugs.webkit.org/show_bug.cgi?id=187373
679         https://trac.webkit.org/changeset/237484
680
681 2018-10-26  Tadeu Zagallo  <tzagallo@apple.com>
682
683         New bytecode format for JSC
684         https://bugs.webkit.org/show_bug.cgi?id=187373
685         <rdar://problem/44186758>
686
687         Reviewed by Filip Pizlo.
688
689         Do not force ENABLE_JIT=true when $forceCLoop is false.
690
691         * Scripts/build-jsc:
692
693 2018-10-26  Geoffrey Garen  <ggaren@apple.com>
694
695         HashMap should support selecting a random entry
696         https://bugs.webkit.org/show_bug.cgi?id=190814
697
698         Reviewed by Antti Koivisto.
699
700         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Updated the Random_IsRandom to
701         more thoroughly test for randomness.
702
703 2018-10-26  Antti Koivisto  <antti@apple.com>
704
705         hashSet.remove(hashSet.random()) doesn't build
706         https://bugs.webkit.org/show_bug.cgi?id=190953
707
708         Reviewed by Chris Dumez.
709
710         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
711         (TestWebKitAPI::TEST):
712
713 2018-10-26  Zalan Bujtas  <zalan@apple.com>
714
715         [LFC][IFC] Layout floats as part of the inline content
716         https://bugs.webkit.org/show_bug.cgi?id=190942
717
718         Reviewed by Antti Koivisto.
719
720         * LayoutReloaded/misc/LFC-passing-tests.txt:
721
722 2018-10-26  Alicia Boya García  <aboya@igalia.com>
723
724         [MSE][WTF][Media] Invalid MediaTime should be falsy
725         https://bugs.webkit.org/show_bug.cgi?id=190893
726
727         Reviewed by Jer Noble.
728
729         This patch adds additional API tests for the conversions from
730         MediaTime to boolean.
731
732         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
733         (TestWebKitAPI::TEST):
734
735 2018-10-25  Chris Dumez  <cdumez@apple.com>
736
737         [PSON] Navigating cross-site with locked history but unlocked back/forward list fails to create a new BackForwardListItem
738         https://bugs.webkit.org/show_bug.cgi?id=190915
739         <rdar://problem/45059069>
740
741         Reviewed by Geoffrey Garen.
742
743         Add API test coverage.
744
745         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
746
747 2018-10-25  Joseph Pecoraro  <pecoraro@apple.com>
748
749         Web Inspector: Add a watchlist message rule to warn about feature checking new inspector protocol changes
750         https://bugs.webkit.org/show_bug.cgi?id=190896
751
752         Reviewed by Matt Baker.
753
754         * Scripts/webkitpy/common/config/watchlist:
755
756 2018-10-25  Geoffrey Garen  <ggaren@apple.com>
757
758         HashMap should support selecting a random entry
759         https://bugs.webkit.org/show_bug.cgi?id=190814
760
761         Reviewed by Antti Koivisto.
762
763         Unit testing is fun and easy!
764
765         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
766         (TestWebKitAPI::ZeroHash::hash):
767         (TestWebKitAPI::TEST):
768
769 2018-10-24  Tim Horton  <timothy_horton@apple.com>
770
771         REGRESSION (r237331): DismissingActionSheetShouldNotDismissPresentingViewController times out
772         https://bugs.webkit.org/show_bug.cgi?id=190897
773
774         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
775         (TestWebKitAPI::TEST):
776         Disable the test for now.
777
778 2018-10-24  Alexey Proskuryakov  <ap@apple.com>
779
780         Clean up some obsolete macOS version guards
781         https://bugs.webkit.org/show_bug.cgi?id=190887
782
783         Reviewed by Dan Bernstein.
784
785         * TestWebKitAPI/cocoa/TestWKWebView.mm:
786         (__simulated_forceClickAssociatedEventsMask):
787         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:clickCount:]):
788         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
789         (WTR::initializeWebViewConfiguration):
790         * WebKitTestRunner/mac/EventSenderProxy.mm:
791         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
792
793 2018-10-24  Megan Gardner  <megan_gardner@apple.com>
794
795         Turn on Conic Gradients
796         https://bugs.webkit.org/show_bug.cgi?id=190810
797
798         Reviewed by Tim Horton.
799
800         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
801
802 2018-10-24  Pablo Saavedra  <psaavedra@igalia.com>
803
804         [WPE] Fix CMake rules in for TestWebKitAPIBase library building in developer mode
805         https://bugs.webkit.org/show_bug.cgi?id=190328
806
807         Reviewed by Michael Catanzaro.
808
809         * TestWebKitAPI/CMakeLists.txt:
810         * TestWebKitAPI/PlatformWPE.cmake:
811
812 2018-10-24  Chris Dumez  <cdumez@apple.com>
813
814         [PSON] When navigating back and forth, 'about:blank' shows up in the back/forward list
815         https://bugs.webkit.org/show_bug.cgi?id=190846
816         <rdar://problem/45058938>
817
818         Reviewed by Antti Koivisto.
819
820         Add API test coverage.
821
822         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
823
824 2018-10-24  Claudio Saavedra  <csaavedra@igalia.com>
825
826         [GTK] TestSSL failing because of missing libsoup patch
827         https://bugs.webkit.org/show_bug.cgi?id=190869
828
829         Reviewed by Michael Catanzaro.
830
831         * gtk/jhbuild.modules: Add the patch below to fix the API test TestSSL
832         * gtk/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Added.
833
834 2018-10-23  Justin Fan  <justin_fan@apple.com>
835
836         [WebGPU] Rename old GPU* implementation files to GPULegacy* for WebMetal
837         https://bugs.webkit.org/show_bug.cgi?id=190817
838
839         Reviewed by Dean Jackson.
840
841         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
842         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUBuffer.mm.
843         (TestWebKitAPI::TEST_F):
844         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Copied from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm.
845         (TestWebKitAPI::TEST_F):
846         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUDevice.mm.
847         (TestWebKitAPI::TEST_F):
848         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm.
849         (TestWebKitAPI::TEST_F):
850         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPULibrary.mm.
851         (TestWebKitAPI::TEST_F):
852         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUTest.h.
853
854 2018-10-23  Chris Dumez  <cdumez@apple.com>
855
856         [PSON] Add support for cross-site client-side redirects
857         https://bugs.webkit.org/show_bug.cgi?id=190806
858         <rdar://problem/45047344>
859
860         Reviewed by Geoffrey Garen.
861
862         Add API test coverage.
863
864         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
865         (-[PSONNavigationDelegate _webView:willPerformClientRedirectToURL:delay:]):
866         (-[PSONNavigationDelegate _webView:didPerformClientRedirectFromURL:toURL:]):
867
868 2018-10-23  Claudio Saavedra  <csaavedra@igalia.com>
869
870         [WPE][GTK] Pass full certificate chain in CertificateInfo coder
871         https://bugs.webkit.org/show_bug.cgi?id=190789
872
873         Reviewed by Michael Catanzaro.
874
875         When the network process serializes certificate data to other
876         processes through the argument coders, the certificate chain, if
877         present, is lost. In practice this means that applications using
878         the public API to process certificate info have no details on the
879         certificate chain, other than the very basics included in the
880         certificate. Serialize the entire chain if available in the
881         certificate.
882
883         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
884         (testSSL): Test that the self-signed certificate has no bogus
885         issuer certificate.
886
887 2018-10-22  Tim Horton  <timothy_horton@apple.com>
888
889         REGRESSION (r237331): InteractionDeadlockAfterCrash API test fails
890         https://bugs.webkit.org/show_bug.cgi?id=190801
891         <rdar://problem/43674361>
892
893         * TestWebKitAPI/Tests/WebKitCocoa/InteractionDeadlockAfterCrash.mm:
894         (TEST):
895         Use a parented WKWebView for this test, otherwise none of the assertions
896         about gesture recognizers work anymore.
897
898 2018-10-22  Ryan Haddad  <ryanhaddad@apple.com>
899
900         REGRESSION (r234081): TestWebKitAPI.VideoControlsManager.VideoControlsManagerAudioElementFollowingUserInteraction is a flaky timeout
901         https://bugs.webkit.org/show_bug.cgi?id=187972
902
903         Unreviewed test gardening.
904
905         * TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm:
906         (TestWebKitAPI::TEST): Disable the flaky test.
907
908 2018-10-22  Wenson Hsieh  <wenson_hsieh@apple.com>
909
910         [iOS] [Datalist] fast/forms/datalist/datalist-show-hide.html fails
911         https://bugs.webkit.org/show_bug.cgi?id=190777
912
913         Reviewed by Tim Horton.
914
915         Implement isShowingDataListSuggestions on iOS. See below for more details.
916
917         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
918         (WTR::UIScriptController::isShowingDataListSuggestions const):
919
920         Add a stub implementation for DumpRenderTree.
921
922         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
923         (WTR::UIScriptController::isShowingDataListSuggestions const):
924
925         Move this stub implementation to !PLATFORM(COCOA).
926
927         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
928         (WTR::forEachViewInHierarchy):
929
930         Add a helper function to apply a given function to a UIView and each of its subviews, recursively.
931
932         (WTR::UIScriptController::isShowingDataListSuggestions const):
933
934         For iOS, return whether the UIRemoteKeyboardWindow contains a subview of type WKDataListSuggestionsPickerView.
935
936 2018-10-19  Dan Bernstein  <mitz@apple.com>
937
938         [macOS] MiniBrowser has an unused injected bundle
939         https://bugs.webkit.org/show_bug.cgi?id=190770
940
941         Reviewed by Tim Horton.
942
943         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Removed.
944         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Removed the MiniBrowserBundle target,
945           the Copy Bundle build phase in the MiniBrowser target, and references to removed files.
946         * MiniBrowser/MiniBrowserWebProcessPlugIn.h: Removed.
947         * MiniBrowser/MiniBrowserWebProcessPlugIn.m: Removed.
948         * MiniBrowser/mac/Bundle: Removed.
949
950 2018-10-19  Wenson Hsieh  <wenson_hsieh@apple.com>
951
952         [iOS] [Datalist] Can't pick datalist suggestions in a stock WKWebView
953         https://bugs.webkit.org/show_bug.cgi?id=190621
954         <rdar://problem/45310649>
955
956         Reviewed by Tim Horton.
957
958         Add a UIScriptController hook to resign first responder on WKWebView. See LayoutTests/ChangeLog for more detail.
959
960         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
961         (WTR::UIScriptController::resignFirstResponder):
962         * DumpRenderTree/mac/UIScriptControllerMac.mm:
963         (WTR::UIScriptController::resignFirstResponder):
964         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
965         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
966         (WTR::UIScriptController::resignFirstResponder):
967         * TestRunnerShared/UIScriptContext/UIScriptController.h:
968         * WebKitTestRunner/UIScriptControllerCocoa.mm:
969         (WTR::UIScriptController::resignFirstResponder):
970         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
971         (WTR::PlatformWebView::makeWebViewFirstResponder):
972
973         Implement this method stub on iOS, to ensure that TestController::resetStateToConsistentValues restores first
974         responder on the WKWebView when running iOS layout tests.
975
976         * WebKitTestRunner/ios/TestControllerIOS.mm:
977         (WTR::TestController::platformResetStateToConsistentValues):
978
979         After resigning first responder to dismiss any on-screen keyboard, ensure that we restore first responder.
980
981 2018-10-19  Dean Jackson  <dino@apple.com>
982
983         ASSERTION FAILED: !frame().animation().hasAnimations() in WebCore::FrameView::didDestroyRenderTree()
984         https://bugs.webkit.org/show_bug.cgi?id=186946
985         <rdar://problem/41724248>
986
987         Reviewed by Antoine Quint.
988
989         If the incoming test has different enableWebAnimationsCSSIntegration options,
990         then we need to create a new WebView.
991
992         * DumpRenderTree/TestOptions.cpp:
993         (TestOptions::webViewIsCompatibleWithOptions const):
994
995 2018-10-19  Charlie Turner  <cturner@igalia.com>
996
997         [EME] Fix crash during tracing in  gst_qtdemux_request_protection_context
998         https://bugs.webkit.org/show_bug.cgi?id=190738
999
1000         Reviewed by Xabier Rodriguez-Calvar.
1001
1002         Add a GStreamer patch to avoid crashing when the run-time logging
1003         level is TRACE. There was a missing null check which caused many
1004         tests to crash.
1005
1006         * gstreamer/patches/gst-plugins-good-0013-Avoid-warning-when-reporting-about-decryptors.patch: Added.
1007
1008 2018-10-18  Alicia Boya García  <aboya@igalia.com>
1009
1010         [Media] Use nanoseconds as MaximumTimeScale
1011         https://bugs.webkit.org/show_bug.cgi?id=190631
1012
1013         Rebased MediaTime tests covering timescales over the maximum.
1014
1015         Reviewed by Jer Noble.
1016
1017         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
1018         (TestWebKitAPI::TEST):
1019
1020 2018-10-18  Dean Johnson  <dean_johnson@apple.com>
1021
1022         clean-webkit pulls in many unnecessary dependencies in webkitpy
1023         https://bugs.webkit.org/show_bug.cgi?id=190732
1024
1025         Reviewed by Alexey Proskuryakov.
1026
1027         * Scripts/webkitpy/common/host.py:
1028         (Host.__init__): Split out 'bugs', 'bugzilla', and 'web' to only be created when used.
1029         (Host):
1030         (Host.bugs):
1031         (Host.bugzilla):
1032         (Host.web):
1033
1034 2018-10-18  Chris Dumez  <cdumez@apple.com>
1035
1036         [PSON] SuspendedPages do not report meaningful domains in Activity Monitor
1037         https://bugs.webkit.org/show_bug.cgi?id=190721
1038         <rdar://problem/45059699>
1039
1040         Reviewed by Alex Christensen.
1041
1042         Add API test coverage.
1043
1044         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1045
1046 2018-10-18  Alexey Proskuryakov  <ap@apple.com>
1047
1048         Switch from PLATFORM(IOS) to PLATFORM(IOS_FAMILY)
1049         https://bugs.webkit.org/show_bug.cgi?id=190729
1050
1051         Reviewed by Tim Horton.
1052
1053         * DumpRenderTree/AccessibilityController.h:
1054         * DumpRenderTree/AccessibilityTextMarker.h:
1055         * DumpRenderTree/AccessibilityUIElement.cpp:
1056         (AccessibilityUIElement::getJSClass):
1057         * DumpRenderTree/AccessibilityUIElement.h:
1058         * DumpRenderTree/DumpRenderTreeFileDraggingSource.h:
1059         * DumpRenderTree/TestRunner.cpp:
1060         (getSecureEventInputIsEnabledCallback):
1061         (TestRunner::staticFunctions):
1062         (TestRunner::callUIScriptCallback):
1063         * DumpRenderTree/TestRunner.h:
1064         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1065         * DumpRenderTree/ios/AccessibilityTextMarkerIOS.mm:
1066         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1067         * DumpRenderTree/ios/DumpRenderTreeAppMain.mm:
1068         * DumpRenderTree/ios/DumpRenderTreeBrowserView.mm:
1069         * DumpRenderTree/ios/TextInputControllerIOS.m:
1070         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1071         * DumpRenderTree/mac/AppleScriptController.m:
1072         * DumpRenderTree/mac/DumpRenderTree.mm:
1073         (createWebViewAndOffscreenWindow):
1074         (destroyWebViewAndOffscreenWindow):
1075         (resetWebPreferencesToConsistentValues):
1076         (setDefaultsToConsistentValuesForTesting):
1077         (allocateGlobalControllers):
1078         (releaseGlobalControllers):
1079         (addTestPluginsToPluginSearchPath):
1080         (prepareConsistentTestingEnvironment):
1081         (dumpRenderTree):
1082         (DumpRenderTreeMain):
1083         (dumpFrameAsPDF):
1084         (dumpBackForwardListForAllWindows):
1085         (updateDisplay):
1086         (dump):
1087         (resetWebViewToConsistentStateBeforeTesting):
1088         (runTest):
1089         (displayWebView):
1090         (displayAndTrackRepaintsWebView):
1091         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
1092         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1093         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1094         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
1095         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1096         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1097         (-[DumpRenderTreeWindow close]):
1098         (-[DumpRenderTreeWindow webView]):
1099         (-[DumpRenderTreeWindow webViewStartedAcceleratedCompositing:]):
1100         * DumpRenderTree/mac/EventSendingController.h:
1101         * DumpRenderTree/mac/EventSendingController.mm:
1102         (+[EventSendingController isSelectorExcludedFromWebScript:]):
1103         (+[EventSendingController webScriptNameForSelector:]):
1104         (-[EventSendingController dealloc]):
1105         (-[EventSendingController currentEventTime]):
1106         (-[EventSendingController clearKillRing]):
1107         (modifierFlags):
1108         (-[EventSendingController mouseDown:withModifiers:]):
1109         (-[EventSendingController scalePageBy:atX:andY:]):
1110         (-[EventSendingController mouseUp:withModifiers:]):
1111         (-[EventSendingController mouseMoveToX:Y:]):
1112         (-[EventSendingController mouseScrollByX:andY:continuously:]):
1113         (-[EventSendingController keyDown:withModifiers:withLocation:]):
1114         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1115         (-[FrameLoadDelegate init]):
1116         (-[FrameLoadDelegate dealloc]):
1117         (-[FrameLoadDelegate processWork:]):
1118         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
1119         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
1120         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
1121         * DumpRenderTree/mac/LayoutTestHelper.m:
1122         * DumpRenderTree/mac/MockGeolocationProvider.mm:
1123         (-[MockGeolocationProvider timerFired]):
1124         * DumpRenderTree/mac/TestRunnerMac.mm:
1125         (TestRunner::setMainFrameIsFirstResponder):
1126         (TestRunner::setAutomaticLinkDetectionEnabled):
1127         (TestRunner::setUseDashboardCompatibilityMode):
1128         (TestRunner::isCommandEnabled):
1129         (TestRunner::inspectorTestStubURL):
1130         (TestRunner::apiTestNewWindowDataLoadBaseURL):
1131         (TestRunner::abortModal):
1132         (TestRunner::setTextDirection):
1133         (TestRunner::addChromeInputField):
1134         (TestRunner::removeChromeInputField):
1135         (TestRunner::focusWebView):
1136         (TestRunner::setBackingScaleFactor):
1137         (TestRunner::imageCountInGeneralPasteboard const):
1138         * DumpRenderTree/mac/UIDelegate.h:
1139         * DumpRenderTree/mac/UIDelegate.mm:
1140         (-[UIDelegate modalWindowWillClose:]):
1141         (-[UIDelegate webViewRunModal:]):
1142         (-[UIDelegate webView:supportsFullScreenForElement:withKeyboard:]):
1143         (-[UIDelegate dealloc]):
1144         * Scripts/check-for-inappropriate-objc-class-names:
1145         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1146         * TestRunnerShared/spi/UIKitTestSPI.h:
1147         * TestWebKitAPI/Tests/WTF/darwin/WeakLinking.cpp:
1148         * TestWebKitAPI/Tests/WebCore/MarkedText.cpp:
1149         (WebCore::operator<<):
1150         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
1151         (TestWebKitAPI::TEST):
1152         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
1153         (TestWebKitAPI::WebCoreNSURLSessionTest::SetUp):
1154         * TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp:
1155         * TestWebKitAPI/Tests/WebKit/NoHistoryItemScrollToFragment.mm:
1156         (TestWebKitAPI::TEST):
1157         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
1158         (TestWebKitAPI::TEST):
1159         * TestWebKitAPI/Tests/WebKitCocoa/AdditionalReadAccessAllowedURLs.mm:
1160         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
1161         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegate.mm:
1162         (TEST):
1163         * TestWebKitAPI/Tests/WebKitCocoa/BundleRangeHandle.mm:
1164         (TEST):
1165         * TestWebKitAPI/Tests/WebKitCocoa/BundleRangeHandlePlugIn.mm:
1166         (-[BundleRangeHandlePlugIn webProcessPlugInBrowserContextController:didFinishDocumentLoadForFrame:]):
1167         * TestWebKitAPI/Tests/WebKitCocoa/Coding.mm:
1168         (TEST):
1169         * TestWebKitAPI/Tests/WebKitCocoa/CopyHTML.mm:
1170         * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
1171         (createWebViewWithCustomPasteboardDataEnabled):
1172         * TestWebKitAPI/Tests/WebKitCocoa/Copying.mm:
1173         (TEST):
1174         * TestWebKitAPI/Tests/WebKitCocoa/DataDetection.mm:
1175         * TestWebKitAPI/Tests/WebKitCocoa/DoAfterNextPresentationUpdateAfterCrash.mm:
1176         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
1177         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
1178         * TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:
1179         * TestWebKitAPI/Tests/WebKitCocoa/FixedLayoutSize.mm:
1180         * TestWebKitAPI/Tests/WebKitCocoa/FontAttributes.mm:
1181         * TestWebKitAPI/Tests/WebKitCocoa/Geolocation.mm:
1182         * TestWebKitAPI/Tests/WebKitCocoa/InteractionDeadlockAfterCrash.mm:
1183         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageClear.mm:
1184         (defaultWebsiteCacheDirectory):
1185         (defaultApplicationCacheDirectory):
1186         (TEST):
1187         * TestWebKitAPI/Tests/WebKitCocoa/NSFileManagerExtras.mm:
1188         * TestWebKitAPI/Tests/WebKitCocoa/NowPlaying.mm:
1189         * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
1190         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
1191         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
1192         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:
1193         (TestWebKitAPI::TEST):
1194         * TestWebKitAPI/Tests/WebKitCocoa/PasteRTFD.mm:
1195         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1196         * TestWebKitAPI/Tests/WebKitCocoa/RenderedImageWithOptions.mm:
1197         (runTestWithWidth):
1198         * TestWebKitAPI/Tests/WebKitCocoa/RenderedImageWithOptionsPlugIn.mm:
1199         (-[RenderedImageWithOptionsPlugIn renderImageWithWidth:completionHandler:]):
1200         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1201         * TestWebKitAPI/Tests/WebKitCocoa/ShrinkToFit.mm:
1202         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
1203         * TestWebKitAPI/Tests/WebKitCocoa/VisibleContentRect.mm:
1204         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1205         (platformCopyRichTextWithMultipleAttachments):
1206         (platformCopyRichTextWithImage):
1207         (platformCopyPNG):
1208         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1209         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewTargetForAction.mm:
1210         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
1211         * TestWebKitAPI/Tests/WebKitCocoa/WKPDFViewStablePresentationUpdateCallback.mm:
1212         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
1213         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-leaks.mm:
1214         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
1215         (TEST):
1216         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1217         (TEST):
1218         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1219         (TEST):
1220         * TestWebKitAPI/Tests/WebKitCocoa/_WKInputDelegate.mm:
1221         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
1222         * TestWebKitAPI/Tests/WebKitLegacy/ios/SnapshotViaRenderInContext.mm:
1223         * TestWebKitAPI/Tests/WebKitLegacy/mac/AccessingPastedImage.mm:
1224         * TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:
1225         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1226         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1227         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1228         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1229         * TestWebKitAPI/Tests/ios/RenderingProgressTests.mm:
1230         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
1231         * TestWebKitAPI/Tests/ios/SetTimeoutFunction.mm:
1232         * TestWebKitAPI/Tests/ios/SynchronousTimeoutTests.mm:
1233         * TestWebKitAPI/Tests/ios/TestInputDelegate.h:
1234         * TestWebKitAPI/Tests/ios/TestInputDelegate.mm:
1235         * TestWebKitAPI/Tests/ios/TextAutosizingBoost.mm:
1236         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1237         * TestWebKitAPI/Tests/ios/WKScrollViewDelegate.mm:
1238         * TestWebKitAPI/Tests/ios/WKScrollViewTests.mm:
1239         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1240         * TestWebKitAPI/Tests/ios/WKWebViewEditActions.mm:
1241         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1242         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
1243         (-[WKWebView _test_waitForDidFinishNavigation]):
1244         * TestWebKitAPI/cocoa/TestWKWebView.h:
1245         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1246         * TestWebKitAPI/config.h:
1247         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1248         * TestWebKitAPI/ios/TestWKWebViewController.h:
1249         * TestWebKitAPI/ios/TestWKWebViewController.mm:
1250         * TestWebKitAPI/ios/UIKitSPI.h:
1251         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1252         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1253         (WTR::InjectedBundle::beginTesting):
1254         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1255         (WTR::TestRunner::inspectorTestStubURL):
1256         * WebKitTestRunner/TestController.cpp:
1257         (WTR::TestController::webProcessName):
1258         (WTR::TestController::networkProcessName):
1259         * WebKitTestRunner/TestInvocation.cpp:
1260         (WTR::TestInvocation::invoke):
1261         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1262         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1263         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1264         (WTR::initializeWebViewConfiguration):
1265         (WTR::TestController::platformCreateWebView):
1266         (WTR::TestController::imageCountInGeneralPasteboard const):
1267         (WTR::TestController::addTestKeyToKeychain):
1268         (WTR::TestController::cleanUpKeychain):
1269         (WTR::TestController::keyExistsInKeychain):
1270         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1271         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1272         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1273
1274 2018-10-18  Chris Dumez  <cdumez@apple.com>
1275
1276         [PSON] Cap number of SuspendedPageProxy objects and allow a WebPageProxy to have more than one
1277         https://bugs.webkit.org/show_bug.cgi?id=190688
1278         <rdar://problem/45354095>
1279
1280         Reviewed by Antti Koivisto.
1281
1282         Extended API test coverage to confirm that:
1283         - We do not accumulate more than 3 suspended processes.
1284         - We can navigate back 3 times and use the page cache for each of these loads.
1285
1286         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1287
1288 2018-10-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1289
1290         Enable the datalist element by default on iOS and macOS
1291         https://bugs.webkit.org/show_bug.cgi?id=190594
1292         <rdar://problem/45281159>
1293
1294         Reviewed by Ryosuke Niwa and Tim Horton.
1295
1296         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1297
1298 2018-10-17  Chris Fleizach  <cfleizach@apple.com>
1299
1300         AX: Certain tags should identify their context to iOS API
1301         https://bugs.webkit.org/show_bug.cgi?id=190622
1302         <rdar://problem/45308194>
1303
1304         Reviewed by Zalan Bujtas.
1305
1306         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1307         (AccessibilityUIElement::stringAttributeValue):
1308         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1309         (WTR::AccessibilityUIElement::stringAttributeValue):
1310
1311 2018-10-16  Sihui Liu  <sihui_liu@apple.com>
1312
1313         Add a switch for Web SQL
1314         https://bugs.webkit.org/show_bug.cgi?id=190271
1315
1316         Reviewed by Ryosuke Niwa.
1317
1318         * WebKitTestRunner/TestController.cpp:
1319         (WTR::TestController::resetPreferencesToConsistentValues):
1320
1321 2018-10-16  Alex Christensen  <achristensen@webkit.org>
1322
1323         Remove InjectedBundleBackForwardList
1324         https://bugs.webkit.org/show_bug.cgi?id=190640
1325
1326         Reviewed by Chris Dumez.
1327
1328         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1329         (WTR::InjectedBundle::dumpBackForwardListsForAllPages):
1330         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1331         (WTR::InjectedBundlePage::prepare):
1332         (WTR::InjectedBundlePage::dumpHistory):
1333         (WTR::hasPrefix): Deleted.
1334         (WTR::compareByTargetName): Deleted.
1335         (WTR::dumpBackForwardListItem): Deleted.
1336         (WTR::InjectedBundlePage::dumpBackForwardList): Deleted.
1337         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1338         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1339         (WTR::TestRunner::clearBackForwardList):
1340
1341 2018-10-16  Dominik Infuehr  <dinfuehr@igalia.com>
1342
1343         Unreviewed, added myself to contributors.json.
1344
1345         * Scripts/webkitpy/common/config/contributors.json:
1346
1347 2018-10-16  Justin Michaud  <justin_michaud@apple.com>
1348
1349         Implement feature flag and bindings for CSS Painting API
1350         https://bugs.webkit.org/show_bug.cgi?id=190237
1351
1352         Reviewed by Ryosuke Niwa.
1353
1354         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1355
1356 2018-10-16  Philippe Normand  <pnormand@igalia.com>
1357
1358         Unreviewed, GTK Ubuntu LTS Jhbuild prospective build fix
1359
1360         * gstreamer/jhbuild.modules:
1361
1362 2018-10-16  Philippe Normand  <pnormand@igalia.com>
1363
1364         [GTK][JHBuild] Disable libmount support in glib
1365
1366         Rubber-stamped by Alejandro G. Castro.
1367
1368         This feature doesn't seem required for our setup.
1369
1370         * gtk/jhbuild.modules:
1371
1372 2018-10-15  Justin Fan  <justin_fan@apple.com>
1373
1374         Add WebGPU 2018 feature flag and experimental feature flag
1375         https://bugs.webkit.org/show_bug.cgi?id=190509
1376
1377         Reviewed by Dean Jackson.
1378
1379         Re-add ENABLE_WEBGPU, an experimental feature flag, and a RuntimeEnabledFeature
1380         for the 2018 WebGPU prototype.
1381
1382         * DumpRenderTree/TestOptions.cpp:
1383         (TestOptions::TestOptions):
1384         * DumpRenderTree/TestOptions.h:
1385         * DumpRenderTree/mac/DumpRenderTree.mm:
1386         (setWebPreferencesForTestOptions):
1387         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1388
1389 2018-10-15  Ryan Haddad  <ryanhaddad@apple.com>
1390
1391         Update bot configuration for Sierra archive queues
1392         https://bugs.webkit.org/show_bug.cgi?id=190605
1393
1394         Reviewed by Aakash Jain.
1395
1396         * BuildSlaveSupport/build.webkit.org-config/config.json:
1397
1398 2018-10-15  Timothy Hatcher  <timothy@apple.com>
1399
1400         Add support for prefers-color-scheme media query
1401         https://bugs.webkit.org/show_bug.cgi?id=190499
1402         rdar://problem/45212025
1403
1404         Reviewed by Dean Jackson.
1405
1406         * Scripts/webkitperl/FeatureList.pm: Added ENABLE_DARK_MODE_CSS as dark-mode-css.
1407         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS.
1408
1409 2018-10-15  Patrick Griffis  <pgriffis@igalia.com>
1410
1411         [JHBuild] Add xdg-dbus-proxy module
1412         https://bugs.webkit.org/show_bug.cgi?id=190589
1413
1414         Reviewed by Michael Catanzaro.
1415
1416         * gtk/jhbuild.modules:
1417
1418 2018-10-15  Patrick Griffis  <pgriffis@igalia.com>
1419
1420         [GTK] Add new sandboxing dependencies to install-dependencies
1421         https://bugs.webkit.org/show_bug.cgi?id=190588
1422
1423         Reviewed by Michael Catanzaro.
1424
1425         * gtk/install-dependencies:
1426
1427 2018-10-15  Chris Dumez  <cdumez@apple.com>
1428
1429         Experiment: target=_blank on anchors should imply rel=noopener
1430         https://bugs.webkit.org/show_bug.cgi?id=190481
1431
1432         Reviewed by Alex Christensen.
1433
1434         Add API test coverage to make sure we can now swap process when target=_blank
1435         is specified on an anchor but rel=noopener is not.
1436
1437         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1438
1439 2018-10-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1440
1441         [iOS] Can't select text after dismissing the keyboard when changing focus
1442         https://bugs.webkit.org/show_bug.cgi?id=190563
1443         <rdar://problem/44613559>
1444
1445         Reviewed by Tim Horton.
1446
1447         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1448         (WTR::UIScriptController::isShowingKeyboard const):
1449
1450         Add a new UIScriptController method that returns whether the keyboard is shown. See `ui-helper.js` for more
1451         details.
1452
1453         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1454         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1455         (WTR::UIScriptController::isShowingKeyboard const):
1456         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1457         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1458         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1459
1460         Also rename the `isShowingKeyboard` Objective-C property to the more canonical `showingKeyboard`, with
1461         `isShowingKeyboard` as the getter method.
1462
1463         (-[TestRunnerWKWebView _invokeShowKeyboardCallbackIfNecessary]):
1464         (-[TestRunnerWKWebView _invokeHideKeyboardCallbackIfNecessary]):
1465         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1466         (WTR::UIScriptController::isShowingKeyboard const):
1467
1468 2018-10-15  Ryan Haddad  <ryanhaddad@apple.com>
1469
1470         Unreviewed, fix JSC tests after WebGPUShadingLanguageRI directory was removed in r237115.
1471
1472         * Scripts/run-javascriptcore-tests:
1473         (runJSCStressTests): Remove wsl-tests.yaml.
1474
1475 2018-10-15  Christopher Reid  <chris.reid@sony.com>
1476
1477         [Curl][WinCairo] Add Public Suffix support to WinCairo
1478         https://bugs.webkit.org/show_bug.cgi?id=183060
1479
1480         Reviewed by Alex Christensen.
1481
1482         Share mac's PublicSuffix tests with all ports.
1483
1484         * TestWebKitAPI/PlatformWin.cmake:
1485         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1486         * TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:
1487         * TestWebKitAPI/Tests/mac/PublicSuffix.mm: Removed.
1488
1489 2018-10-15  Myles C. Maxfield  <mmaxfield@apple.com>
1490
1491         [WHLSL] Migrated WebGPUShadingLanguageRI to the W3C
1492         https://bugs.webkit.org/show_bug.cgi?id=190555
1493
1494         Unreviewed.
1495
1496         Migrated to https://github.com/gpuweb/WHLSL/tree/master/Source
1497
1498         * WebGPUShadingLanguageRI/AddressSpace.js: Removed.
1499         * WebGPUShadingLanguageRI/All.js: Removed.
1500         * WebGPUShadingLanguageRI/AllocateAtEntryPoints.js: Removed.
1501         * WebGPUShadingLanguageRI/AnonymousVariable.js: Removed.
1502         * WebGPUShadingLanguageRI/ArrayRefType.js: Removed.
1503         * WebGPUShadingLanguageRI/ArrayType.js: Removed.
1504         * WebGPUShadingLanguageRI/Assignment.js: Removed.
1505         * WebGPUShadingLanguageRI/AutoWrapper.js: Removed.
1506         * WebGPUShadingLanguageRI/Block.js: Removed.
1507         * WebGPUShadingLanguageRI/BoolLiteral.js: Removed.
1508         * WebGPUShadingLanguageRI/Break.js: Removed.
1509         * WebGPUShadingLanguageRI/BuiltInSemantic.js: Removed.
1510         * WebGPUShadingLanguageRI/BuiltinMatrixGetter.js: Removed.
1511         * WebGPUShadingLanguageRI/BuiltinMatrixSetter.js: Removed.
1512         * WebGPUShadingLanguageRI/BuiltinVectorGetter.js: Removed.
1513         * WebGPUShadingLanguageRI/BuiltinVectorSetter.js: Removed.
1514         * WebGPUShadingLanguageRI/CallExpression.js: Removed.
1515         * WebGPUShadingLanguageRI/CallFunction.js: Removed.
1516         * WebGPUShadingLanguageRI/Casts.js: Removed.
1517         * WebGPUShadingLanguageRI/Check.js: Removed.
1518         * WebGPUShadingLanguageRI/CheckLiteralTypes.js: Removed.
1519         * WebGPUShadingLanguageRI/CheckLoops.js: Removed.
1520         * WebGPUShadingLanguageRI/CheckNativeFuncStages.js: Removed.
1521         * WebGPUShadingLanguageRI/CheckRecursion.js: Removed.
1522         * WebGPUShadingLanguageRI/CheckRecursiveTypes.js: Removed.
1523         * WebGPUShadingLanguageRI/CheckReturns.js: Removed.
1524         * WebGPUShadingLanguageRI/CheckTypesWithArguments.js: Removed.
1525         * WebGPUShadingLanguageRI/CheckUnreachableCode.js: Removed.
1526         * WebGPUShadingLanguageRI/CheckWrapped.js: Removed.
1527         * WebGPUShadingLanguageRI/Checker.js: Removed.
1528         * WebGPUShadingLanguageRI/CloneProgram.js: Removed.
1529         * WebGPUShadingLanguageRI/CommaExpression.js: Removed.
1530         * WebGPUShadingLanguageRI/ConstexprFolder.js: Removed.
1531         * WebGPUShadingLanguageRI/Continue.js: Removed.
1532         * WebGPUShadingLanguageRI/ConvertPtrToArrayRefExpression.js: Removed.
1533         * WebGPUShadingLanguageRI/CreateLiteral.js: Removed.
1534         * WebGPUShadingLanguageRI/CreateLiteralType.js: Removed.
1535         * WebGPUShadingLanguageRI/DereferenceExpression.js: Removed.
1536         * WebGPUShadingLanguageRI/DoWhileLoop.js: Removed.
1537         * WebGPUShadingLanguageRI/DotExpression.js: Removed.
1538         * WebGPUShadingLanguageRI/EArrayRef.js: Removed.
1539         * WebGPUShadingLanguageRI/EBuffer.js: Removed.
1540         * WebGPUShadingLanguageRI/EBufferBuilder.js: Removed.
1541         * WebGPUShadingLanguageRI/EPtr.js: Removed.
1542         * WebGPUShadingLanguageRI/EnumLiteral.js: Removed.
1543         * WebGPUShadingLanguageRI/EnumMember.js: Removed.
1544         * WebGPUShadingLanguageRI/EnumType.js: Removed.
1545         * WebGPUShadingLanguageRI/EvaluationCommon.js: Removed.
1546         * WebGPUShadingLanguageRI/Evaluator.js: Removed.
1547         * WebGPUShadingLanguageRI/Expression.js: Removed.
1548         * WebGPUShadingLanguageRI/ExpressionFinder.js: Removed.
1549         * WebGPUShadingLanguageRI/ExternalOrigin.js: Removed.
1550         * WebGPUShadingLanguageRI/Field.js: Removed.
1551         * WebGPUShadingLanguageRI/FindHighZombies.js: Removed.
1552         * WebGPUShadingLanguageRI/FlattenedStructOffsetGatherer.js: Removed.
1553         * WebGPUShadingLanguageRI/FloatLiteral.js: Removed.
1554         * WebGPUShadingLanguageRI/FloatLiteralType.js: Removed.
1555         * WebGPUShadingLanguageRI/FoldConstexprs.js: Removed.
1556         * WebGPUShadingLanguageRI/ForLoop.js: Removed.
1557         * WebGPUShadingLanguageRI/Func.js: Removed.
1558         * WebGPUShadingLanguageRI/FuncAttribute.js: Removed.
1559         * WebGPUShadingLanguageRI/FuncDef.js: Removed.
1560         * WebGPUShadingLanguageRI/FuncNumThreadsAttribute.js: Removed.
1561         * WebGPUShadingLanguageRI/FuncParameter.js: Removed.
1562         * WebGPUShadingLanguageRI/FunctionLikeBlock.js: Removed.
1563         * WebGPUShadingLanguageRI/HighZombieFinder.js: Removed.
1564         * WebGPUShadingLanguageRI/IdentityExpression.js: Removed.
1565         * WebGPUShadingLanguageRI/IfStatement.js: Removed.
1566         * WebGPUShadingLanguageRI/IndexExpression.js: Removed.
1567         * WebGPUShadingLanguageRI/InferTypesForCall.js: Removed.
1568         * WebGPUShadingLanguageRI/Inline.js: Removed.
1569         * WebGPUShadingLanguageRI/Inliner.js: Removed.
1570         * WebGPUShadingLanguageRI/IntLiteral.js: Removed.
1571         * WebGPUShadingLanguageRI/IntLiteralType.js: Removed.
1572         * WebGPUShadingLanguageRI/Intrinsics.js: Removed.
1573         * WebGPUShadingLanguageRI/LayoutBuffers.js: Removed.
1574         * WebGPUShadingLanguageRI/Lexer.js: Removed.
1575         * WebGPUShadingLanguageRI/LexerToken.js: Removed.
1576         * WebGPUShadingLanguageRI/LiteralTypeChecker.js: Removed.
1577         * WebGPUShadingLanguageRI/LogicalExpression.js: Removed.
1578         * WebGPUShadingLanguageRI/LogicalNot.js: Removed.
1579         * WebGPUShadingLanguageRI/LoopChecker.js: Removed.
1580         * WebGPUShadingLanguageRI/MakeArrayRefExpression.js: Removed.
1581         * WebGPUShadingLanguageRI/MakePtrExpression.js: Removed.
1582         * WebGPUShadingLanguageRI/MatrixType.js: Removed.
1583         * WebGPUShadingLanguageRI/Metal/MSLBackend.js: Removed.
1584         * WebGPUShadingLanguageRI/Metal/MSLCodegenAll.js: Removed.
1585         * WebGPUShadingLanguageRI/Metal/MSLCompileResult.js: Removed.
1586         * WebGPUShadingLanguageRI/Metal/MSLConstexprEmitter.js: Removed.
1587         * WebGPUShadingLanguageRI/Metal/MSLFunctionDeclaration.js: Removed.
1588         * WebGPUShadingLanguageRI/Metal/MSLFunctionDefinition.js: Removed.
1589         * WebGPUShadingLanguageRI/Metal/MSLFunctionForwardDeclaration.js: Removed.
1590         * WebGPUShadingLanguageRI/Metal/MSLInsertTrapParameter.js: Removed.
1591         * WebGPUShadingLanguageRI/Metal/MSLNameMangler.js: Removed.
1592         * WebGPUShadingLanguageRI/Metal/MSLNativeFunctionCall.js: Removed.
1593         * WebGPUShadingLanguageRI/Metal/MSLStatementEmitter.js: Removed.
1594         * WebGPUShadingLanguageRI/Metal/MSLTypeAttributes.js: Removed.
1595         * WebGPUShadingLanguageRI/Metal/MSLTypeAttributesMap.js: Removed.
1596         * WebGPUShadingLanguageRI/Metal/MSLTypeUnifier.js: Removed.
1597         * WebGPUShadingLanguageRI/Metal/TypeOf.js: Removed.
1598         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/.gitignore: Removed.
1599         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/AppDelegate.h: Removed.
1600         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/AppDelegate.m: Removed.
1601         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Assets.xcassets/AppIcon.appiconset/Contents.json: Removed.
1602         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Assets.xcassets/Contents.json: Removed.
1603         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Base.lproj/Main.storyboard: Removed.
1604         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.h: Removed.
1605         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.m: Removed.
1606         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.h: Removed.
1607         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m: Removed.
1608         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CustomMetalView.h: Removed.
1609         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CustomMetalView.m: Removed.
1610         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Default.whlsl: Removed.
1611         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Julia.whlsl: Removed.
1612         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Mandelbrot.whlsl: Removed.
1613         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Info.plist: Removed.
1614         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.h: Removed.
1615         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.m: Removed.
1616         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.h: Removed.
1617         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.m: Removed.
1618         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/Renderer.h: Removed.
1619         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/Renderer.m: Removed.
1620         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.h: Removed.
1621         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.m: Removed.
1622         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.h: Removed.
1623         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.m: Removed.
1624         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.h: Removed.
1625         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m: Removed.
1626         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.h: Removed.
1627         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m: Removed.
1628         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.h: Removed.
1629         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m: Removed.
1630         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/WHLSL.entitlements: Removed.
1631         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/_SharedMetal.txt: Removed.
1632         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/main.m: Removed.
1633         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL Tests.xcodeproj/project.pbxproj: Removed.
1634         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL ToyTests/Info.plist: Removed.
1635         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL ToyTests/WHLSL_ToyTests.m: Removed.
1636         * WebGPUShadingLanguageRI/Metal/WhlslToMsl.html: Removed.
1637         * WebGPUShadingLanguageRI/Metal/WhlslToMsl.js: Removed.
1638         * WebGPUShadingLanguageRI/NameContext.js: Removed.
1639         * WebGPUShadingLanguageRI/NameFinder.js: Removed.
1640         * WebGPUShadingLanguageRI/NameResolver.js: Removed.
1641         * WebGPUShadingLanguageRI/NativeFunc.js: Removed.
1642         * WebGPUShadingLanguageRI/NativeType.js: Removed.
1643         * WebGPUShadingLanguageRI/Node.js: Removed.
1644         * WebGPUShadingLanguageRI/NormalUsePropertyResolver.js: Removed.
1645         * WebGPUShadingLanguageRI/NullLiteral.js: Removed.
1646         * WebGPUShadingLanguageRI/NullType.js: Removed.
1647         * WebGPUShadingLanguageRI/OperatorAnderIndexer.js: Removed.
1648         * WebGPUShadingLanguageRI/OperatorArrayRefLength.js: Removed.
1649         * WebGPUShadingLanguageRI/OriginKind.js: Removed.
1650         * WebGPUShadingLanguageRI/OverloadResolutionFailure.js: Removed.
1651         * WebGPUShadingLanguageRI/Parse.js: Removed.
1652         * WebGPUShadingLanguageRI/Prepare.js: Removed.
1653         * WebGPUShadingLanguageRI/Program.js: Removed.
1654         * WebGPUShadingLanguageRI/ProgramWithUnnecessaryThingsRemoved.js: Removed.
1655         * WebGPUShadingLanguageRI/PropertyAccessExpression.js: Removed.
1656         * WebGPUShadingLanguageRI/PropertyResolver.js: Removed.
1657         * WebGPUShadingLanguageRI/PtrType.js: Removed.
1658         * WebGPUShadingLanguageRI/ReadModifyWriteExpression.js: Removed.
1659         * WebGPUShadingLanguageRI/RecursionChecker.js: Removed.
1660         * WebGPUShadingLanguageRI/RecursiveTypeChecker.js: Removed.
1661         * WebGPUShadingLanguageRI/ReferenceType.js: Removed.
1662         * WebGPUShadingLanguageRI/ResolveNames.js: Removed.
1663         * WebGPUShadingLanguageRI/ResolveOverloadImpl.js: Removed.
1664         * WebGPUShadingLanguageRI/ResolveProperties.js: Removed.
1665         * WebGPUShadingLanguageRI/ResolveTypeDefs.js: Removed.
1666         * WebGPUShadingLanguageRI/ResourceSemantic.js: Removed.
1667         * WebGPUShadingLanguageRI/Return.js: Removed.
1668         * WebGPUShadingLanguageRI/ReturnChecker.js: Removed.
1669         * WebGPUShadingLanguageRI/ReturnException.js: Removed.
1670         * WebGPUShadingLanguageRI/Rewriter.js: Removed.
1671         * WebGPUShadingLanguageRI/SPIR-V.js: Removed.
1672         * WebGPUShadingLanguageRI/SPIRV.html: Removed.
1673         * WebGPUShadingLanguageRI/SPIRVCodegen.js: Removed.
1674         * WebGPUShadingLanguageRI/SPIRVTypeAnalyzer.js: Removed.
1675         * WebGPUShadingLanguageRI/SPIRVVariableAnalyzer.js: Removed.
1676         * WebGPUShadingLanguageRI/Sampler.js: Removed.
1677         * WebGPUShadingLanguageRI/Semantic.js: Removed.
1678         * WebGPUShadingLanguageRI/SpecializationConstantSemantic.js: Removed.
1679         * WebGPUShadingLanguageRI/StageInOutSemantic.js: Removed.
1680         * WebGPUShadingLanguageRI/StandardLibrary.js: Removed.
1681         * WebGPUShadingLanguageRI/StatementCloner.js: Removed.
1682         * WebGPUShadingLanguageRI/StructLayoutBuilder.js: Removed.
1683         * WebGPUShadingLanguageRI/StructType.js: Removed.
1684         * WebGPUShadingLanguageRI/SwitchCase.js: Removed.
1685         * WebGPUShadingLanguageRI/SwitchStatement.js: Removed.
1686         * WebGPUShadingLanguageRI/SynthesizeArrayOperatorLength.js: Removed.
1687         * WebGPUShadingLanguageRI/SynthesizeCopyConstructorOperator.js: Removed.
1688         * WebGPUShadingLanguageRI/SynthesizeDefaultConstructorOperator.js: Removed.
1689         * WebGPUShadingLanguageRI/SynthesizeEnumFunctions.js: Removed.
1690         * WebGPUShadingLanguageRI/SynthesizeStructAccessors.js: Removed.
1691         * WebGPUShadingLanguageRI/TernaryExpression.js: Removed.
1692         * WebGPUShadingLanguageRI/Test.html: Removed.
1693         * WebGPUShadingLanguageRI/Test.js: Removed.
1694         * WebGPUShadingLanguageRI/Texture.js: Removed.
1695         * WebGPUShadingLanguageRI/TextureOperations.js: Removed.
1696         * WebGPUShadingLanguageRI/TrapStatement.js: Removed.
1697         * WebGPUShadingLanguageRI/Type.js: Removed.
1698         * WebGPUShadingLanguageRI/TypeDef.js: Removed.
1699         * WebGPUShadingLanguageRI/TypeDefResolver.js: Removed.
1700         * WebGPUShadingLanguageRI/TypeOverloadResolutionFailure.js: Removed.
1701         * WebGPUShadingLanguageRI/TypeRef.js: Removed.
1702         * WebGPUShadingLanguageRI/TypedValue.js: Removed.
1703         * WebGPUShadingLanguageRI/UintLiteral.js: Removed.
1704         * WebGPUShadingLanguageRI/UintLiteralType.js: Removed.
1705         * WebGPUShadingLanguageRI/UnificationContext.js: Removed.
1706         * WebGPUShadingLanguageRI/UnreachableCodeChecker.js: Removed.
1707         * WebGPUShadingLanguageRI/Value.js: Removed.
1708         * WebGPUShadingLanguageRI/VariableDecl.js: Removed.
1709         * WebGPUShadingLanguageRI/VariableRef.js: Removed.
1710         * WebGPUShadingLanguageRI/VectorType.js: Removed.
1711         * WebGPUShadingLanguageRI/VisitingSet.js: Removed.
1712         * WebGPUShadingLanguageRI/Visitor.js: Removed.
1713         * WebGPUShadingLanguageRI/WLexicalError.js: Removed.
1714         * WebGPUShadingLanguageRI/WSyntaxError.js: Removed.
1715         * WebGPUShadingLanguageRI/WTrapError.js: Removed.
1716         * WebGPUShadingLanguageRI/WTypeError.js: Removed.
1717         * WebGPUShadingLanguageRI/WhileLoop.js: Removed.
1718         * WebGPUShadingLanguageRI/WrapChecker.js: Removed.
1719         * WebGPUShadingLanguageRI/index.html: Removed.
1720         * WebGPUShadingLanguageRI/spirv.core.grammar.json: Removed.
1721         * WebGPUShadingLanguageRI/wsl-tests.yaml: Removed.
1722
1723 2018-10-15  Philippe Normand  <pnormand@igalia.com>
1724
1725         [GTK] Disable MSE build support on Debian and Ubuntu LTS bots
1726         https://bugs.webkit.org/show_bug.cgi?id=190581
1727
1728         Reviewed by Michael Catanzaro.
1729
1730         These bots don't use JHBuild and their host GStreamer version is
1731         too old for the GStreamer MSE backend. Version 1.14 is needed at least.
1732
1733         * BuildSlaveSupport/build.webkit.org-config/config.json:
1734
1735 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1736
1737         Use pragma once in WTF
1738         https://bugs.webkit.org/show_bug.cgi?id=190527
1739
1740         Reviewed by Chris Dumez.
1741
1742         Put WorkQueue in namespace DRT so it does not conflict with WTF::WorkQueue.
1743
1744         * DumpRenderTree/TestRunner.cpp:
1745         (TestRunner::queueLoadHTMLString):
1746         (TestRunner::queueLoadAlternateHTMLString):
1747         (TestRunner::queueBackNavigation):
1748         (TestRunner::queueForwardNavigation):
1749         (TestRunner::queueLoadingScript):
1750         (TestRunner::queueNonLoadingScript):
1751         (TestRunner::queueReload):
1752         * DumpRenderTree/WorkQueue.cpp:
1753         (WorkQueue::singleton): Deleted.
1754         (WorkQueue::WorkQueue): Deleted.
1755         (WorkQueue::queue): Deleted.
1756         (WorkQueue::dequeue): Deleted.
1757         (WorkQueue::count): Deleted.
1758         (WorkQueue::clear): Deleted.
1759         (WorkQueue::processWork): Deleted.
1760         * DumpRenderTree/WorkQueue.h:
1761         (WorkQueue::setFrozen): Deleted.
1762         * DumpRenderTree/WorkQueueItem.h:
1763         * DumpRenderTree/mac/DumpRenderTree.mm:
1764         (runTest):
1765         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1766         (-[FrameLoadDelegate processWork:]):
1767         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
1768         * DumpRenderTree/mac/TestRunnerMac.mm:
1769         (TestRunner::notifyDone):
1770         (TestRunner::forceImmediateCompletion):
1771         (TestRunner::queueLoad):
1772         * DumpRenderTree/win/DumpRenderTree.cpp:
1773         (runTest):
1774         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1775         (FrameLoadDelegate::processWork):
1776         (FrameLoadDelegate::locationChangeDone):
1777         * DumpRenderTree/win/TestRunnerWin.cpp:
1778         (TestRunner::notifyDone):
1779         (TestRunner::forceImmediateCompletion):
1780         (TestRunner::queueLoad):
1781
1782 2018-10-14  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
1783
1784         [JSC] Remove Option::useAsyncIterator
1785         https://bugs.webkit.org/show_bug.cgi?id=190567
1786
1787         Reviewed by Saam Barati.
1788
1789         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1790
1791 2018-10-15  Claudio Saavedra  <csaavedra@igalia.com>
1792
1793         [WPE] Silence a unused-parameter warning
1794
1795         Unreviewed.
1796         * MiniBrowser/wpe/main.cpp:
1797         (decidePermissionRequest):
1798
1799 2018-10-12  Guillaume Emont  <guijemont@igalia.com>
1800
1801         [Tools][webkitpy] fix handling of JSCTESTS_OPTIONS
1802         https://bugs.webkit.org/show_bug.cgi?id=190537
1803
1804         Reviewed by Alexey Proskuryakov.
1805
1806         In DeprecatedPort.run_javascriptcore_tests_command() JSCTESTS_OPTIONS
1807         needs to be split before adding it to the command since it is treated
1808         as a list of args.
1809
1810         * Scripts/webkitpy/common/config/ports.py:
1811         (DeprecatedPort.run_javascriptcore_tests_command):
1812
1813 2018-10-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1814
1815         [iOS] Allow SPI clients to lay out at arbitrarily scaled sizes and scale to fit the view
1816         https://bugs.webkit.org/show_bug.cgi?id=190504
1817         <rdar://problem/45117760>
1818
1819         Reviewed by Tim Horton.
1820
1821         Teach UIScriptController to set WKWebView's view scale via a new `setViewScale` method, supported in WebKit2 on
1822         macOS and iOS.
1823
1824         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1825         (WTR::UIScriptController::setViewScale):
1826         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1827         (WTR::UIScriptController::setViewScale):
1828         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1829         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1830         (WTR::UIScriptController::setViewScale):
1831         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1832         * WebKitTestRunner/UIScriptControllerCocoa.mm: Added.
1833
1834         Add a new file for UIScriptController methods on Cocoa platforms.
1835
1836         (WTR::UIScriptController::setViewScale):
1837         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1838         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1839         (WTR::TestController::cocoaResetStateToConsistentValues):
1840
1841         Ensure that _viewScale is reset to 1 after running a layout test.
1842
1843 2018-10-12  Aakash Jain  <aakash_jain@apple.com>
1844
1845         [ews-build] Rename iOS-11-Simulator-Tests-EWS to iOS-11-Simulator-WK2-Tests-EWS
1846         https://bugs.webkit.org/show_bug.cgi?id=190536
1847
1848         Reviewed by Alexey Proskuryakov.
1849
1850         * BuildSlaveSupport/ews-build/config.json: Renamed iOS-11-Simulator-Tests-EWS to iOS-11-Simulator-WK2-Tests-EWS.
1851
1852 2018-10-11  Youenn Fablet  <youenn@apple.com>
1853
1854         IOS 12 - Service worker cache not shared when added to homescreen
1855         https://bugs.webkit.org/show_bug.cgi?id=190269
1856         <rdar://problem/45009961>
1857
1858         Reviewed by Alex Christensen.
1859
1860         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1861         Add test to ensure that CacheStorage use the default website data store parameters.
1862
1863 2018-10-11  Tim Horton  <timothy_horton@apple.com>
1864
1865         Clicking on bookmarklet crashes at NavigationState::willRecordNavigationSnapshot
1866         https://bugs.webkit.org/show_bug.cgi?id=190476
1867         <rdar://problem/32757191>
1868
1869         Reviewed by Megan Gardner.
1870
1871         * TestWebKitAPI/Tests/WebKitCocoa/SnapshotStore.mm:
1872         (TEST):
1873         Add a test that we don't crash.
1874
1875 2018-10-11  Tim Horton  <timothy_horton@apple.com>
1876
1877         REGRESSION (r237037): Cannot use webkit-patch upload, always fails with unknown 'cc_radar'
1878
1879         * Scripts/webkitpy/tool/steps/options.py:
1880         (Options):
1881         Fix the name of the variable that the --cc-radar option writes into.
1882
1883 2018-10-10  Dean Jackson  <dino@apple.com>
1884
1885         Add --cc-radar option to webkit-patch bug creation
1886         https://bugs.webkit.org/show_bug.cgi?id=190451
1887         <rdar://problem/45176671>
1888
1889         Reviewed by Antoine Quint.
1890
1891         Add a new command line option to automatically
1892         CC radar to new or updated bugs.
1893
1894         * Scripts/webkitpy/tool/commands/commandtest.py:
1895         (CommandsTest.assert_execute_outputs):
1896         * Scripts/webkitpy/tool/commands/upload.py:
1897         (CreateBug.__init__):
1898         (CreateBug.execute):
1899         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1900         (test_prepare_with_cc):
1901         (test_prepare_with_radar):
1902         (test_prepare_with_cc_and_radar):
1903         * Scripts/webkitpy/tool/steps/createbug.py:
1904         (CreateBug.options):
1905         (CreateBug.run):
1906         * Scripts/webkitpy/tool/steps/options.py:
1907         (Options):
1908
1909 2018-10-11  Claudio Saavedra  <csaavedra@igalia.com>
1910
1911         [GStreamer] Do not build gstgtk plugins
1912         https://bugs.webkit.org/show_bug.cgi?id=190463
1913
1914         Reviewed by Xabier Rodriguez-Calvar.
1915
1916         These plugins pull a GTK+ dependency that, at least in WPE,
1917         is unnecessary. The GTK+ port doesn't need it either, as far
1918         as I can tell.
1919
1920         * gstreamer/jhbuild.modules: Disable gstgtk plugins
1921
1922 2018-10-11  Alejandro G. Castro  <alex@igalia.com>
1923
1924         [GTK][WPE] Add mediaDevices.enumerateDevices support
1925         https://bugs.webkit.org/show_bug.cgi?id=185761
1926
1927         Reviewed by Youenn Fablet.
1928
1929         Added new API test for the mediaDevices.enumerateDevices:
1930         usermedia-enumeratedevices-permission-check. And a new API test
1931         for the WebsiteDataStore: testWebsiteDataDeviceIdHashSalt.
1932
1933         * MiniBrowser/gtk/main.c:
1934         (gotWebsiteDataCallback): Added a new section to the about:data
1935         webpage to include the information about the hash salt.
1936         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1937         (testWebViewUserMediaEnumerateDevicesPermissionCheck): Added the
1938         new test checking the enumerateDevices API when permission is
1939         denied and when permission is allowed for the origin.
1940         (beforeAll): Defined the new test.
1941         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
1942         (serverCallback): Register a new URI for the enumerateDevices.
1943         (testWebsiteDataConfiguration): Remove the hash salts from the
1944         directories.
1945         (testWebsiteDataDeviceIdHashSalt): New test cheking the
1946         enumerateDevices API.
1947         (beforeAll): Added the new test testWebsiteDataDeviceIdHashSalt to
1948         the init structure.
1949         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
1950         (WebViewTest::initializeWebView): Make sure the media-stream is
1951         activated in the webView.
1952
1953 2018-10-10  Fujii Hironori  <Hironori.Fujii@sony.com>
1954
1955         Add WinCairo to the flakiness dashboard
1956         https://bugs.webkit.org/show_bug.cgi?id=188345
1957
1958         Reviewed by Lucas Forschler.
1959
1960         * TestResultServer/static-dashboards/builders.jsonp: Regenerated by generate_builders_json.py.
1961         * TestResultServer/static-dashboards/flakiness_dashboard.js: Added a new platform 'WINCAIRO'.
1962
1963 2018-10-10  Dean Jackson  <dino@apple.com>
1964
1965         [WHSL -> MSL] Annotate semantics correctly in generated MSL
1966         https://bugs.webkit.org/show_bug.cgi?id=190452
1967         <rdar://problem/45178272>
1968
1969         Reviewed by Myles Maxfield.
1970
1971         Correctly label the appropriate semantics as [[position]]
1972         and [[color(N)]].
1973
1974         * WebGPUShadingLanguageRI/Metal/MSLBackend.js: Identify position
1975         and color attributes. Also use the semantic's index rather than
1976         a counter.
1977         * WebGPUShadingLanguageRI/Metal/WhlslToMsl.html: Use a <pre> for
1978         output, and only include the actual shader code.
1979
1980 2018-10-10  Ross Kirsling  <ross.kirsling@sony.com>
1981
1982         build-webkit --inspector-frontend shouldn't have a nonzero exit code
1983         https://bugs.webkit.org/show_bug.cgi?id=190430
1984
1985         Reviewed by Brian Burg.
1986
1987         * Scripts/webkitdirs.pm:
1988         (argumentsForConfiguration):
1989         --inspector-frontend should only be popped off of argv by determineIsInspectorFrontend;
1990         it shouldn't be re-inserted as a CLI option by argumentsForConfiguration.
1991
1992 2018-10-10  Tim Horton  <timothy_horton@apple.com>
1993
1994         Share more WKShareSheet code between macOS and iOS, and fix a few bugs
1995         https://bugs.webkit.org/show_bug.cgi?id=190420
1996
1997         Reviewed by Simon Fraser.
1998
1999         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2000         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
2001         (WTR::UIScriptController::invokeShareSheetWithResolution): Deleted.
2002         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2003         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
2004         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2005         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2006         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
2007         (WTR::UIScriptController::invokeShareSheetWithResolution): Deleted.
2008         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2009         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2010         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
2011         (WTR::UIScriptController::invokeShareSheetWithResolution): Deleted.
2012         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2013         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
2014         Change the testing mechanism for the share sheet such that we up-front
2015         set that it should immediately return with a particular state, instead
2016         of programmatically dismissing the sheet.
2017
2018         Otherwise, running the tests on macOS doesn't work, because we pop
2019         a context menu, which spins the runloop and prevents dismissal from
2020         going through.
2021
2022 2018-10-10  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
2023
2024         [JSC] Rename createXXX to tryCreateXXX if it can return RefPtr
2025         https://bugs.webkit.org/show_bug.cgi?id=190429
2026
2027         Reviewed by Saam Barati.
2028
2029         * TestWebKitAPI/Tests/WebCore/mac/GPUBuffer.mm:
2030         (TestWebKitAPI::TEST_F):
2031
2032 2018-10-10  Chris Dumez  <cdumez@apple.com>
2033
2034         Regression(PSON): Assertion hit under WebPageProxy::didNavigateWithNavigationData()
2035         https://bugs.webkit.org/show_bug.cgi?id=190418
2036         <rdar://problem/45059769>
2037
2038         Reviewed by Geoffrey Garen.
2039
2040         Add API test coverage.
2041
2042         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2043
2044 2018-10-10  Guillaume Emont  <guijemont@igalia.com>
2045
2046         [JSCOnly Add an armv7 JSCOnly EWS that runs tests
2047         https://bugs.webkit.org/show_bug.cgi?id=190191
2048
2049         Reviewed by Michael Catanzaro.
2050
2051         * QueueStatusServer/config/queues.py:
2052         * Scripts/webkitpy/common/config/ews.json:
2053         * Scripts/webkitpy/common/config/ports.py:
2054         (DeprecatedPort.run_javascriptcore_tests_command):
2055         Add the possibility to pass arguments to run-javascriptcore-tests with
2056         the JSCTESTS_OPTIONS environment variable
2057         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2058         (test_ews_name):
2059
2060
2061 2018-10-09  Guillaume Emont  <guijemont@igalia.com>
2062
2063         Allow run-javascriptcore-tests to distribute tests between devices
2064         https://bugs.webkit.org/show_bug.cgi?id=190190
2065
2066         Reviewed by Michael Catanzaro.
2067
2068         * Scripts/run-jsc-stress-tests:
2069         * Scripts/webkitruby/jsc-stress-test-writer-default.rb:
2070         * Scripts/webkitruby/jsc-stress-test-writer-ruby.rb:
2071
2072 2018-10-09  Dean Jackson  <dino@apple.com>
2073
2074         Update WHLSL to Metal tester with semantics
2075         https://bugs.webkit.org/show_bug.cgi?id=190416
2076         <rdar://problem/45145139>
2077
2078         Reviewed by Myles Maxfield.
2079
2080         A few small changes to the WHLSL to Metal tools:
2081         - Make it compile by adding some missing JS files :)
2082         - Add semantics to the default shader
2083         - Add FIXMEs to the other shaders
2084         - Create an in-browser test for the WHLSLToMetal codepath
2085         - Fix typos in the semantics checker
2086
2087         * WebGPUShadingLanguageRI/Checker.js:
2088         (Checker.prototype._checkSemantics.checkSemanticTypes):
2089         (Checker.prototype._checkSemantics.checkSemanticForShaderType):
2090         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m:
2091         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Default.whlsl:
2092         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Julia.whlsl:
2093         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Mandelbrot.whlsl:
2094         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL Tests.xcodeproj/project.pbxproj:
2095         * WebGPUShadingLanguageRI/Metal/WhlslToMsl.html: Added.
2096
2097 2018-10-09  Jer Noble  <jer.noble@apple.com>
2098
2099         Crash when closing WKWebView during enter fullscreen animation
2100         https://bugs.webkit.org/show_bug.cgi?id=190412
2101
2102         Reviewed by Brian Burg.
2103
2104         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2105         * TestWebKitAPI/Tests/WebKitCocoa/CloseWebViewDuringEnterFullscreen.mm: Added.
2106         (-[CloseWebViewDuringEnterFullscreenUIDelegate _webViewWillEnterFullscreen:]):
2107         (-[CloseWebViewDuringEnterFullscreenUIDelegate _webViewWillExitFullscreen:]):
2108         (TestWebKitAPI::TEST):
2109
2110 2018-10-09  Chris Dumez  <cdumez@apple.com>
2111
2112         Anchor target should be ignored on activation when the download attribute is set
2113         https://bugs.webkit.org/show_bug.cgi?id=190408
2114
2115         Reviewed by Geoffrey Garen.
2116
2117         Update WebKitTestRunner to block popups by default and add support for testRunner.setCanOpenWindows()
2118         for tests that need popups. This aligns WebKitTestRunner with DumpRenderTree and allows testing
2119         popup blocking.
2120
2121         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2122         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2123         (WTR::TestRunner::setCanOpenWindows):
2124         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2125         * WebKitTestRunner/TestController.cpp:
2126         (WTR::TestController::createOtherPage):
2127         * WebKitTestRunner/TestController.h:
2128         * WebKitTestRunner/TestInvocation.cpp:
2129         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2130         * WebKitTestRunner/TestInvocation.h:
2131
2132 2018-10-09  Jer Noble  <jer.noble@apple.com>
2133
2134         WebDriver: thrown ObjC exception under -[WKFullScreenWindowController windowDidFailToEnterFullScreen:] when session is terminated
2135         https://bugs.webkit.org/show_bug.cgi?id=190098
2136         <rdar://problem/42822671>
2137
2138         Reviewed by Brian Burg.
2139
2140         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2141         * TestWebKitAPI/Tests/WebKitCocoa/CloseWebViewAfterEnterFullscreen.mm: Added.
2142         (-[CloseWebViewAfterEnterFullscreenUIDelegate _webViewDidEnterFullscreen:]):
2143         (-[CloseWebViewAfterEnterFullscreenUIDelegate _webViewDidExitFullscreen:]):
2144         (TestWebKitAPI::TEST):
2145
2146 2018-10-09  Jiewen Tan  <jiewen_tan@apple.com>
2147
2148         [WebAuthN] Import CTAP HID message and packet structure from Chromium
2149         https://bugs.webkit.org/show_bug.cgi?id=189289
2150         <rdar://problem/44120310>
2151
2152         Reviewed by Brent Fulgham.
2153
2154         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2155         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp: Added.
2156         (TestWebKitAPI::TEST):
2157
2158 2018-10-09  Chris Dumez  <cdumez@apple.com>
2159
2160         PSON: Doing a cross-site navigation via the URL bar does not swap process on iOS
2161         https://bugs.webkit.org/show_bug.cgi?id=190378
2162         <rdar://problem/45059466>
2163
2164         Reviewed by Geoffrey Garen.
2165
2166         Add API test coverage.
2167
2168         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2169
2170 2018-10-09  Jer Noble  <jer.noble@apple.com>
2171
2172         ISOTrackEncryptionBox returns incorrect defaultKeyID
2173         https://bugs.webkit.org/show_bug.cgi?id=190368
2174
2175         Reviewed by Eric Carlson.
2176
2177         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2178         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp: Added.
2179         (TestWebKitAPI::TEST):
2180
2181 2018-10-09  Philippe Normand  <pnormand@igalia.com>
2182
2183         [JHBuild] Update to GStreamer 1.14.4
2184         https://bugs.webkit.org/show_bug.cgi?id=190395
2185
2186         Reviewed by Xabier Rodriguez-Calvar.
2187
2188         * gstreamer/jhbuild.modules: Remove patches merged in 1.14.4 and bump version of GStreamer modules.
2189         * gstreamer/patches/gst-plugins-good-0007-matroskademux-Allow-Matroska-headers-to-be-read-more.patch: Removed.
2190         * gstreamer/patches/gst-plugins-good-0008-matroskademux-Refactor-track-parsing-out-from-adding.patch: Removed.
2191         * gstreamer/patches/gst-plugins-good-0009-matroskademux-Parse-successive-Tracks-elements.patch: Removed.
2192         * gstreamer/patches/gst-plugins-good-0010-matroskademux-Emit-no-more-pads-after-parsing-Tracks.patch: Removed.
2193
2194 2018-10-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2195
2196         [macOS] API test DragAndDropTests.DropColor is failing on macOS 10.12
2197         https://bugs.webkit.org/show_bug.cgi?id=190386
2198
2199         Reviewed by Ryosuke Niwa.
2200
2201         Unlike macOS 10.13 and 10.14, -[NSColor redColor] is not equivalent to a fully red color in sRGB on macOS 10.12.
2202         Fix the test by dragging and dropping an NSColor that is equivalent to rgb(255, 0, 0) on all relevant versions
2203         of macOS.
2204
2205         * TestWebKitAPI/Tests/mac/DragAndDropTestsMac.mm:
2206         (TEST):
2207
2208 2018-10-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2209
2210         [Cocoa] [WK2] Add support for text alignment and text lists in font attributes
2211         https://bugs.webkit.org/show_bug.cgi?id=190342
2212         <rdar://problem/44767118>
2213
2214         Reviewed by Tim Horton.
2215
2216         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2217         * TestWebKitAPI/Tests/WebKitCocoa/FontAttributes.mm:
2218
2219         Add a new API test to check that the font attributes dictionary contains the correct NSParagraphStyles when
2220         moving the selection around text inside nested list elements.
2221
2222         (TestWebKitAPI::checkParagraphStyles):
2223
2224         Add a new helper to check an NSParagraphStyle against expected results.
2225
2226         (TestWebKitAPI::webViewForTestingFontAttributes):
2227
2228         Allow each test to pass in the name of the test page to load.
2229
2230         (TestWebKitAPI::TEST):
2231         * TestWebKitAPI/Tests/WebKitCocoa/nested-lists.html: Added.
2232
2233         Add a new test page that contains text enclosed in multiple levels of unordered and ordered lists.
2234
2235         * TestWebKitAPI/Tests/WebKitCocoa/rich-text-attributes.html:
2236
2237         Remove `text-align: left` from one of these elements, to test for NSTextAlignmentNatural.
2238
2239 2018-10-08  Justin Fan  <justin_fan@apple.com>
2240
2241         WebGPU: Rename old WebGPU prototype to WebMetal
2242         https://bugs.webkit.org/show_bug.cgi?id=190325
2243         <rdar://problem/44990443>
2244
2245         Reviewed by Dean Jackson.
2246
2247         Rename WebGPU prototype files to WebMetal in preparation for implementing the new (Oct 2018) WebGPU interface.
2248
2249         * DumpRenderTree/mac/DumpRenderTree.mm:
2250         (enableExperimentalFeatures):
2251         (resetWebPreferencesToConsistentValues):
2252         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2253         * TestWebKitAPI/Tests/WebCore/mac/GPUBuffer.mm:
2254         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm:
2255         * TestWebKitAPI/Tests/WebCore/mac/GPUDevice.mm:
2256         * TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm:
2257         * TestWebKitAPI/Tests/WebCore/mac/GPULibrary.mm:
2258         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2259         (WTR::InjectedBundle::beginTesting):
2260         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2261         (WTR::TestRunner::setWebMetalEnabled):
2262         (WTR::TestRunner::setWebGPUEnabled): Deleted.
2263         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2264
2265 2018-10-08  Commit Queue  <commit-queue@webkit.org>
2266
2267         Unreviewed, rolling out r236941.
2268         https://bugs.webkit.org/show_bug.cgi?id=190374
2269
2270         Causing API test failures in new test (Requested by jernoble
2271         on #webkit).
2272
2273         Reverted changeset:
2274
2275         "ISOTrackEncryptionBox returns incorrect defaultKeyID"
2276         https://bugs.webkit.org/show_bug.cgi?id=190368
2277         https://trac.webkit.org/changeset/236941
2278
2279 2018-10-08  Aditya Keerthi  <akeerthi@apple.com>
2280
2281         Make <input type=color> a runtime enabled (on-by-default) feature
2282         https://bugs.webkit.org/show_bug.cgi?id=189162
2283
2284         Reviewed by Wenson Hsieh and Tim Horton.
2285
2286         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2287
2288 2018-10-08  Jer Noble  <jer.noble@apple.com>
2289
2290         ISOTrackEncryptionBox returns incorrect defaultKeyID
2291         https://bugs.webkit.org/show_bug.cgi?id=190368
2292
2293         Reviewed by Eric Carlson.
2294
2295         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2296         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp: Added.
2297         (TestWebKitAPI::TEST):
2298
2299 2018-10-08  Alex Christensen  <achristensen@webkit.org>
2300
2301         Remove WKBundleFileHandleRef
2302         https://bugs.webkit.org/show_bug.cgi?id=190360
2303
2304         Reviewed by Tim Horton.
2305
2306         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2307         * TestWebKitAPI/Tests/WebKit/WKBundleFileHandle.cpp: Removed.
2308         * TestWebKitAPI/Tests/WebKit/WKBundleFileHandle_Bundle.cpp: Removed.
2309
2310 2018-10-08  Dan Bernstein  <mitz@apple.com>
2311
2312         Tools part of [Xcode] Update some build settings as recommended by Xcode 10
2313         https://bugs.webkit.org/show_bug.cgi?id=190250
2314
2315         Reviewed by Anders Carlsson.
2316
2317         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
2318
2319         * DumpRenderTree/mac/Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA,
2320           CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS,
2321           CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
2322
2323         * DumpRenderTree/mac/DumpRenderTreeMac.h: Addressed the strict prototype warning.
2324
2325         * DumpRenderTree/mac/EditingDelegate.mm: Suppressed the deprecated implementations warning
2326           around deprecated methods or categories on deprecated classes.
2327         * DumpRenderTree/mac/FrameLoadDelegate.mm: Ditto.
2328         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
2329         * DumpRenderTree/mac/TestRunnerMac.mm: Ditto.
2330         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]):
2331
2332         * MiniBrowser/Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA,
2333           CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS,
2334           CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
2335
2336         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
2337
2338         * MiniBrowser/mac/AppDelegate.h: Addressed the strict prototypes warning.
2339         * MiniBrowser/mac/WK2BrowserWindowController.m: Removed an unused #import to avoid having to
2340           address the fact that many of the WebKit C SPI headers trigger the strict prototypes warning.
2341
2342         * MobileMiniBrowser/Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA,
2343           CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_SUSPICIOUS_MOVE (by fixing a typo),
2344           CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF.
2345
2346         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj: Let Xcode update
2347           LastUpgradeCheck and remove the .xcconfig files from the Copy Bundle Resources build phase.
2348
2349         * TestWebKitAPI/Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA,
2350           CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS,
2351           CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
2352           Made the WebKit headers be treated as system headers to avoid dealing with the fact that
2353           many C SPI headers trigger the strict prototypes warning.
2354
2355         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
2356
2357         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2358         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
2359         (-[BlobDownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
2360         (-[UIDownloadAsFileTestDelegate _webView:contextMenu:forElement:]):
2361         (-[RedirectedDownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
2362         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2363         (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
2364         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
2365         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
2366         (-[AudioSessionCategoryUIWebViewDelegate webView:shouldStartLoadWithRequest:navigationType:]):
2367         * TestWebKitAPI/Tests/WebKitLegacy/ios/SnapshotViaRenderInContext.mm:
2368         (-[RenderInContextWebViewDelegate webViewDidFinishLoad:]):
2369         (-[RenderInContextWebViewDelegate webView:didFailLoadWithError:]):
2370         * TestWebKitAPI/Tests/ios/SetTimeoutFunction.mm:
2371         (-[SetTimeoutFunctionWebViewDelegate webViewDidFinishLoad:]):
2372         (-[SetTimeoutFunctionWebViewDelegate webView:didFailLoadWithError:]):
2373         (-[SetTimeoutFunctionWebViewDelegate webView:shouldStartLoadWithRequest:navigationType:]):
2374         * TestWebKitAPI/Tests/mac/LegacyDragAndDropTests.mm:
2375         (-[DragInfo namesOfPromisedFilesDroppedAtDestination:]):
2376         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
2377         (-[DragAndDropTestWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]):
2378         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m:
2379         (-[SyntheticBackingScaleFactorWindow IGNORE_WARNINGS_END]):
2380         (-[SyntheticBackingScaleFactorWindow userSpaceScaleFactor]): Deleted.
2381         * TestWebKitAPI/mac/TestDraggingInfo.mm:
2382         (-[TestDraggingInfo namesOfPromisedFilesDroppedAtDestination:]):
2383
2384         In all of the above, suppressed the deprecated implementations warning where needed.
2385
2386         * WebKitTestRunner/Configurations/Base.xcconfig: Enabled ENABLE_STRICT_OBJC_MSGSEND,
2387           CLANG_WARN_BOOL_CONVERSION, CLANG_WARN_COMMA, CLANG_WARN_CONSTANT_CONVERSION,
2388           CLANG_WARN_EMPTY_BODY, CLANG_WARN_ENUM_CONVERSION, CLANG_WARN_INT_CONVERSION,
2389           CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_UNREACHABLE_CODE, CLANG_WARN__DUPLICATE_METHOD_MATCH,
2390           GCC_WARN_UNDECLARED_SELECTOR, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
2391           CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS,
2392           and GCC_NO_COMMON_BLOCKS.
2393
2394         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
2395
2396         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2397         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]): Suppressed
2398           the deprecated implementations warning.
2399
2400         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2401         (WTR::UIScriptController::replaceTextAtRange): Addressed an int-conversion warning.
2402
2403 2018-10-07  Yacine Bandou  <yacine.bandou@softathome.com>
2404
2405         [GStreamer][EME][webm] Add the WebM encrypted content support in matroskademux
2406         https://bugs.webkit.org/show_bug.cgi?id=189238
2407
2408         Reviewed by Xabier Rodriguez-Calvar.
2409
2410         Modifications on GStreamer, tracked in GStreamer bugzilla:
2411         https://bugzilla.gnome.org/show_bug.cgi?id=797231
2412         https://bugzilla.gnome.org/show_bug.cgi?id=765275
2413
2414         * gstreamer/jhbuild.modules: Add new patches.
2415         * gstreamer/patches/gstreamer-0001-protection-Add-a-new-definition-for-unspecified-syst.patch: Added.
2416         * gstreamer/patches/gstreamer-0002-protection-Fix-the-string-to-define-unspecified-syst.patch: Added.
2417         * gstreamer/patches/gst-plugins-good-0011-matroska-Add-the-WebM-encrypted-content-support-in-m.patch: Added.
2418         * gstreamer/patches/gst-plugins-good-0012-matroskdemux-do-not-use-MapInfo.data-after-unmapping.patch: Added.
2419
2420 2018-10-06  Dan Bernstein  <mitz@apple.com>
2421
2422         [Xcode] Never build yasm with ASAN
2423         https://bugs.webkit.org/show_bug.cgi?id=190327
2424
2425         Reviewed by Youenn Fablet.
2426
2427         * asan/asan.xcconfig: Allow targets to opt out of building with ASAN by setting
2428           the WK_ASAN_DISALLOWED build setting to YES (or, actually, anything other than NO or unset).
2429
2430 2018-10-05  Chris Dumez  <cdumez@apple.com>
2431
2432         Regression(r236862): Crash under DOMWindowExtension::willDetachGlobalObjectFromFrame()
2433         https://bugs.webkit.org/show_bug.cgi?id=190320
2434         <rdar://problem/45044814>
2435
2436         Reviewed by Geoffrey Garen.
2437
2438         Add API test coverage.
2439
2440         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
2441         (TestWebKitAPI::TEST):
2442         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
2443         (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyGlobalObjectForDOMWindowExtension):
2444
2445 2018-10-03  Jer Noble  <jer.noble@apple.com>
2446
2447         Add support for reporting "display composited video frames" through the VideoPlaybackQuality object.
2448         https://bugs.webkit.org/show_bug.cgi?id=190266
2449
2450         Reviewed by Eric Carlson.
2451
2452         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2453         * TestWebKitAPI/Tests/WebKitCocoa/VideoQualityDisplayCompositing.mm: Added.
2454         (TestWebKitAPI::TEST):
2455
2456 2018-10-05  Ryan Haddad  <ryanhaddad@apple.com>
2457
2458         Unreviewed, rolling out r236866.
2459
2460         Breaks internal builds.
2461
2462         Reverted changeset:
2463
2464         "Add support for reporting "display composited video frames"
2465         through the VideoPlaybackQuality object."
2466         https://bugs.webkit.org/show_bug.cgi?id=190266
2467         https://trac.webkit.org/changeset/236866
2468
2469 2018-10-05  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
2470
2471         [WPE][JSC] Use Unified Sources for Platform-specific sources
2472         https://bugs.webkit.org/show_bug.cgi?id=190300
2473
2474         Reviewed by Yusuke Suzuki.
2475
2476         Currently the GTK port already used Unified Sources with the same source files.
2477         As WPE has conditional code using gmodule, we need to add GLIB_GMODULE_LIBRARIES
2478         to the list of libraries to link with.
2479
2480         * TestWebKitAPI/PlatformWPE.cmake:
2481
2482 2018-10-05  Zach Li  <zachli@apple.com>
2483
2484         Expose whether WKWebProcessPlugInNodeHandle is a select element to clients
2485         https://bugs.webkit.org/show_bug.cgi?id=190302
2486         <rdar://problem/45031469>
2487
2488         Reviewed by Tim Horton.
2489
2490         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2491         * TestWebKitAPI/Tests/WebKitCocoa/InjectedBundleNodeHandleIsSelectElement.mm: Added.
2492         (-[InjectedBundleNodeHandleIsSelectElement verifySelectElementForHTMLElementTag:document:jsContext:expectedResult:failedElementTags:]):
2493         (-[InjectedBundleNodeHandleIsSelectElement webProcessPlugIn:didCreateBrowserContextController:]):
2494         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2495         (-[InjectedBundleNodeHandleIsSelectElementDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2496         (TEST):
2497
2498 2018-10-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2499
2500         [iOS] [WK2] Expose some more editing SPI on WKWebView
2501         https://bugs.webkit.org/show_bug.cgi?id=190232
2502         <rdar://problem/44963368>
2503
2504         Reviewed by Tim Horton.
2505
2506         Adds new API tests to exercise the new SPIs.
2507
2508         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2509         * TestWebKitAPI/Tests/ios/WKWebViewEditActions.mm: Added.
2510         (-[TestWKWebView querySelectorExists:]):
2511         (TestWebKitAPI::webViewForEditActionTesting):
2512         (TestWebKitAPI::TEST):
2513         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
2514         (-[TestWKWebView collapseToStart]): Deleted.
2515         (-[TestWKWebView collapseToEnd]): Deleted.
2516         (-[TestWKWebView stylePropertyAtSelectionStart:]): Deleted.
2517         (-[TestWKWebView stylePropertyAtSelectionEnd:]): Deleted.
2518         * TestWebKitAPI/cocoa/TestWKWebView.h:
2519         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2520         (-[TestWKWebView stylePropertyAtSelectionStart:]):
2521         (-[TestWKWebView stylePropertyAtSelectionEnd:]):
2522         (-[TestWKWebView collapseToStart]):
2523         (-[TestWKWebView collapseToEnd]):
2524
2525         Pull some common testing helpers out of NSFontManager and into TestWKWebView.
2526
2527 2018-10-04  Jer Noble  <jer.noble@apple.com>
2528
2529         Add support for reporting "display composited video frames" through the VideoPlaybackQuality object.
2530         https://bugs.webkit.org/show_bug.cgi?id=190266
2531
2532         Reviewed by Eric Carlson.
2533
2534         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2535         * TestWebKitAPI/Tests/WebKitCocoa/VideoQualityDisplayCompositing.mm: Added.
2536         (TestWebKitAPI::TEST):
2537
2538 2018-10-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2539
2540         [Cocoa] Add SPI to expose typing attributes at the current selection on WKWebView
2541         https://bugs.webkit.org/show_bug.cgi?id=190119
2542         <rdar://problem/44767062>
2543
2544         Reviewed by Tim Horton.
2545
2546         Add a new API test that loads a document containing various rich text styles. This test moves the selection
2547         around the document and checks the last set of font attributes received via the new UI delegate hook.
2548
2549         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2550         * TestWebKitAPI/Tests/WebKitCocoa/FontAttributes.mm: Added.
2551         (-[FontAttributesListener _webView:didChangeFontAttributes:]):
2552         (-[FontAttributesListener lastFontAttributes]):
2553         (-[TestWKWebView selectElementWithIdentifier:]):
2554         (-[TestWKWebView fontAttributesAfterNextPresentationUpdate]):
2555         (ColorExpectation::ColorExpectation):
2556         (ShadowExpectation::ShadowExpectation):
2557         (checkColor):
2558         (checkShadow):
2559         (checkFont):
2560         (webViewForTestingFontAttributes):
2561         * TestWebKitAPI/Tests/WebKitCocoa/rich-text-attributes.html: Added.
2562
2563 2018-10-04  Alan Coon  <alancoon@apple.com>
2564
2565         Unreviewed, add self as contributor.
2566
2567         * Scripts/webkitpy/common/config/contributors.json:
2568
2569 2018-10-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2570
2571         [macOS] Fix some font attribute conversion bugs in preparation for "Font > Styles…" support in WebKit2
2572         https://bugs.webkit.org/show_bug.cgi?id=190289
2573         <rdar://problem/45020806>
2574
2575         Reviewed by Ryosuke Niwa.
2576
2577         Add new API tests to exercise two corner cases when using NSFontOptions ("Font > Styles…") to change font
2578         attributes at the current selection.
2579
2580         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2581         * TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h:
2582         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
2583         (webViewForFontManagerTesting):
2584         (TestWebKitAPI::TEST):
2585         * TestWebKitAPI/mac/TestFontOptions.h: Copied from Source/WebCore/editing/cocoa/FontAttributesCocoa.mm.
2586         * TestWebKitAPI/mac/TestFontOptions.mm: Added.
2587
2588         Introduce TestFontOptions, which wraps the shared NSFontOptions and swizzles `-sharedFontOptions` to return a
2589         global instance of itself. TestFontOptions supports several testing helpers to add or remove font shadows,
2590         foreground colors, and background colors.
2591
2592         (sharedFontOptionsForTesting):
2593         (+[TestFontOptions sharedInstance]):
2594         (-[TestFontOptions initWithFontOptions:]):
2595         (-[TestFontOptions selectedAttributes]):
2596         (-[TestFontOptions fontOptions]):
2597         (-[TestFontOptions shadowWidth]):
2598         (-[TestFontOptions setShadowWidth:]):
2599         (-[TestFontOptions shadowHeight]):
2600         (-[TestFontOptions setShadowHeight:]):
2601         (-[TestFontOptions setShadowBlurRadius:]):
2602         (-[TestFontOptions setHasShadow:]):
2603         (-[TestFontOptions foregroundColor]):
2604         (-[TestFontOptions setForegroundColor:]):
2605         (-[TestFontOptions backgroundColor]):
2606         (-[TestFontOptions setBackgroundColor:]):
2607         (-[TestFontOptions _dispatchFontAttributeChanges]):
2608         (-[TestFontOptions convertAttributes:]):
2609         (-[TestFontOptions setSelectedAttributes:isMultiple:]):
2610         (-[TestFontOptions forwardInvocation:]):
2611
2612 2018-10-04  Jiewen Tan  <jiewen_tan@apple.com>
2613
2614         [WebAuthN] Move time out control from WebProcess to UIProcess
2615         https://bugs.webkit.org/show_bug.cgi?id=189642
2616         <rdar://problem/44476765>
2617
2618         Reviewed by Chris Dumez.
2619
2620         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2621         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
2622
2623 2018-10-04  YUHAN WU  <yuhan_wu@apple.com>
2624
2625         Runtime flag and IDL for MediaRecorder
2626         https://bugs.webkit.org/show_bug.cgi?id=190018
2627
2628         Reviewed by Youenn Fablet and Chris Dumez.
2629
2630         * DumpRenderTree/mac/DumpRenderTree.mm:
2631         (enableExperimentalFeatures):
2632
2633 2018-10-04  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2634
2635         [LayoutTests][Win] Stop wpt server correctly.
2636         https://bugs.webkit.org/show_bug.cgi?id=190248
2637
2638         Reviewed by Fujii Hironori.
2639
2640         Use signal.CTRL_C_EVENT instead of signal.SIGINT for Windows.
2641         Also refactoring the detection of Windows and cygwin environment check.
2642
2643         * Scripts/webkitpy/common/system/executive.py:
2644         (Executive.__init__): Check environment once.
2645         (Executive._should_close_fds):
2646         (Executive.kill_process):
2647         (Executive.check_running_pid):
2648         (Executive.running_pids):
2649         (Executive.interrupt): Use signal.CTRL_C_EVENT for Windows.
2650         (Executive.kill_all):
2651         (Executive._child_process_encoding):
2652         (Executive._should_encode_child_process_arguments):
2653         (Executive.popen):
2654         (Executive.run_in_parallel):
2655
2656 2018-10-04  Michael Catanzaro  <mcatanzaro@igalia.com>
2657
2658         Convert tests to use navigation client
2659         https://bugs.webkit.org/show_bug.cgi?id=190153
2660
2661         Reviewed by Alex Christensen.
2662
2663         Convert these tests from PagePolicyClient and PageLoaderClient to PageNavigationClient.
2664
2665         * TestWebKitAPI/Tests/WebKit/DownloadDecideDestinationCrash.cpp:
2666         (TestWebKitAPI::decidePolicyForNavigationAction):
2667         (TestWebKitAPI::setPagePolicyClient):
2668         * TestWebKitAPI/Tests/WebKit/ProvisionalURLAfterWillSendRequestCallback.cpp:
2669         (TestWebKitAPI::didCommitNavigationCallback):
2670         (TestWebKitAPI::TEST):
2671         (TestWebKitAPI::didCommitLoadForFrame): Deleted.
2672
2673 2018-10-03  Dan Bernstein  <mitz@apple.com>
2674
2675         [Cocoa] Let clients specify an NSFileWrapper subclassed to be used for _WKAttachment
2676         https://bugs.webkit.org/show_bug.cgi?id=190270
2677
2678         Reviewed by Wenson Hsieh.
2679
2680         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2681         (TestWebKitAPI::TEST):
2682
2683 2018-10-03  Ryosuke Niwa  <rniwa@webkit.org>
2684
2685         Enable selectionAcrossShadowBoundariesEnabled by default in WebKitLegacy
2686         https://bugs.webkit.org/show_bug.cgi?id=190238
2687
2688         Reviewed by Antti Koivisto.
2689
2690         * DumpRenderTree/TestOptions.h:
2691         * DumpRenderTree/mac/DumpRenderTree.mm:
2692         (resetWebPreferencesToConsistentValues):
2693
2694 2018-10-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2695
2696         [WebKit2] Format > Bold and Format > Italic don't toggle between bold and italic style
2697         https://bugs.webkit.org/show_bug.cgi?id=179787
2698         <rdar://problem/35593389>
2699
2700         Reviewed by Tim Horton.
2701
2702         Add a test to verify that NSFontManager's selected font is updated when applying italic and bold styles using
2703         menu items.
2704
2705         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
2706         (webViewForFontManagerTesting):
2707         (menuItemCellForFontAction):
2708         (TestWebKitAPI::TEST):
2709
2710 2018-10-02  Chris Dumez  <cdumez@apple.com>
2711
2712         REGRESSION: TestWebKitAPI.WKWebView.ProvisionalURLNotChange API test is failing
2713         https://bugs.webkit.org/show_bug.cgi?id=190176
2714         <rdar://problem/44925871>
2715
2716         Reviewed by Alex Christensen.
2717
2718         Use a URL that is truly recognized as invalid by WebCore's URL parser.
2719
2720         * TestWebKitAPI/Tests/WebKitCocoa/ProvisionalURLNotChange.mm:
2721         (TEST):
2722
2723 2018-10-02  Alex Christensen  <achristensen@webkit.org>
2724
2725         Remove ParsedURLString
2726         https://bugs.webkit.org/show_bug.cgi?id=190154
2727
2728         Reviewed by Chris Dumez.
2729
2730         * TestWebKitAPI/Tests/WebCore/URL.cpp:
2731         (TestWebKitAPI::TEST_F):
2732         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2733         (TestWebKitAPI::assertUserAgentForURLHasChromeBrowserQuirk):
2734         (TestWebKitAPI::assertUserAgentForURLHasLinuxPlatformQuirk):
2735         (TestWebKitAPI::assertUserAgentForURLHasMacPlatformQuirk):
2736         (TestWebKitAPI::TEST):
2737
2738 2018-10-02  Daniel Bates  <dabates@apple.com>
2739
2740         Fix iOS TestWebKitAPI failures following <https://trac.webkit.org/changeset/236619>
2741         (https://bugs.webkit.org/show_bug.cgi?id=190017)
2742
2743         For now swizzle +[UIKeyboard isInHardwareKeyboardMode] to return NO in the following tests:
2744             WKWebViewAutofillTests.AutofillRequiresInputSession
2745             DragAndDropTests.ExternalSourceJPEGOnly
2746             DragAndDropTests.ExternalSourceUTF8PlainTextOnly
2747
2748         so that the presence of a hardware keyboad does not effect their results. In <https://bugs.webkit.org/show_bug.cgi?id=190211>
2749         we will look to swizzle this method for all test by default.
2750
2751         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2752         (TestWebKitAPI::overrideIsInHardwareKeyboardMode):
2753         (TestWebKitAPI::TEST):
2754         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2755         (TestWebKitAPI::overrideIsInHardwareKeyboardMode):
2756         (TestWebKitAPI::TEST):
2757         * TestWebKitAPI/ios/UIKitSPI.h:
2758
2759 2018-10-02  Dawei Fenton  <realdawei@apple.com>
2760
2761         Unreviewed, rolling out r236751.
2762
2763         broke the iOS Build
2764
2765         Reverted changeset:
2766
2767         "Fix iOS TestWebKitAPI failures following
2768         <https://trac.webkit.org/changeset/236619>"
2769         https://bugs.webkit.org/show_bug.cgi?id=190017
2770         https://trac.webkit.org/changeset/236751
2771
2772 2018-10-02  Daniel Bates  <dabates@apple.com>
2773
2774         Fix iOS TestWebKitAPI failures following <https://trac.webkit.org/changeset/236619>
2775         (https://bugs.webkit.org/show_bug.cgi?id=190017)
2776
2777         For now swizzle +[UIKeyboard isInHardwareKeyboardMode] to return NO in the following tests:
2778             WKWebViewAutofillTests.AutofillRequiresInputSession
2779             DragAndDropTests.ExternalSourceJPEGOnly
2780             DragAndDropTests.ExternalSourceUTF8PlainTextOnly
2781
2782         so that the presence of a hardware keyboad does not effect their results. In <https://bugs.webkit.org/show_bug.cgi?id=190211>
2783         we will look to swizzle this method for all test by default.
2784
2785         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2786         (TestWebKitAPI::overrideIsInHardwareKeyboardMode):
2787         (TestWebKitAPI::TEST):
2788         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2789         (TestWebKitAPI::overrideIsInHardwareKeyboardMode):
2790         (TestWebKitAPI::TEST):
2791         * TestWebKitAPI/ios/UIKitSPI.h:
2792
2793 2018-10-01  Dean Jackson  <dino@apple.com>
2794
2795         Remove CSS Animation Triggers
2796         https://bugs.webkit.org/show_bug.cgi?id=190175
2797         <rdar://problem/44925626>
2798
2799         Reviewed by Simon Fraser.
2800
2801         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2802
2803 2018-10-02  Thibault Saunier  <tsaunier@igalia.com>
2804
2805         [Flatpak] Use our own check of flatpak repos
2806         https://bugs.webkit.org/show_bug.cgi?id=190194
2807
2808         Allowing us to not mess up with user installation
2809         and "--assumeyes" everywhere.
2810
2811         Reviewed by Michael Catanzaro.
2812
2813         * flatpak/flatpakutils.py:
2814         (FlatpakPackage.__init__):
2815         (FlatpakPackage.install):
2816         (FlatpakPackage.update):
2817         (WebkitFlatpak.load_from_args):
2818         (WebkitFlatpak.__init__):
2819         (WebkitFlatpak.clean_args):
2820
2821 2018-10-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2822
2823         [macOS] Implement a way for the UI process to request typing attributes at the current selection
2824         https://bugs.webkit.org/show_bug.cgi?id=189983
2825         <rdar://problem/44648705>
2826
2827         Reviewed by Ryosuke Niwa.
2828
2829         Adds new FontManagerTests that exercise -typingAttributesWithCompletionHandler:. See below for more detail.
2830
2831         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2832         * TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h:
2833         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
2834
2835         Add a new test that exercises font attribute modification via inspector bar. Also, add a new test that checks
2836         typing attributes when using subscript/superscript/unscript. Lastly, augment an existing NSFontPanel test to
2837         additionally check that shadowed text and strike-through are reflected in typing attributes.
2838
2839         (-[FontManagerTestWKWebView inspectorBarItemIdentifiers]):
2840         (-[TestWKWebView typingAttributes]):
2841
2842         Add a synchronous wrapper around `-typingAttributesWithCompletionHandler:` by spinning the runloop.
2843
2844         (-[TestWKWebView collapseToStart]):
2845         (webViewForFontManagerTesting):
2846         (TestWebKitAPI::TEST):
2847         * TestWebKitAPI/cocoa/TestWKWebView.h:
2848         * TestWebKitAPI/mac/TestInspectorBar.h: Copied from Tools/TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h.
2849         * TestWebKitAPI/mac/TestInspectorBar.mm: Added.
2850
2851         Introduce subclasses of `__InspectorBarItemController` and `NSInspectorBar` for testing inspector bar interaction.
2852
2853         (-[TestInspectorBarItemController initWithInspectorBar:]):
2854         (-[TestInspectorBarItemController inspectorBar]):
2855         (-[TestInspectorBarItemController updateSelectedAttributes]):
2856         (-[TestInspectorBar initWithWebView:]):
2857         (+[TestInspectorBar standardItemControllerClass]):
2858         (+[TestInspectorBar standardTextItemIdentifiers]):
2859         (-[TestInspectorBar _setStyleControlSelected:atIndex:]):
2860         (-[TestInspectorBar chooseFontSize:]):
2861         (-[TestInspectorBar chooseFontFamily:]):
2862         (-[TestInspectorBar _chooseColor:inColorWell:]):
2863         (-[TestInspectorBar chooseForegroundColor:]):
2864         (-[TestInspectorBar chooseBackgroundColor:]):
2865         (-[TestInspectorBar formatBold:]):
2866         (-[TestInspectorBar formatItalic:]):
2867         (-[TestInspectorBar formatUnderline:]):
2868
2869         Add helper methods to TestInspectorBar to simulate interacting with various controls (e.g. color wells and font
2870         styling controls).
2871
2872         (-[TestInspectorBar itemController]):
2873         (-[TestInspectorBar setItemController:]):
2874
2875 2018-10-02  Thibault Saunier  <tsaunier@igalia.com>
2876
2877         [Flatpak] Implement icecream and ccache support
2878         https://bugs.webkit.org/show_bug.cgi?id=190146
2879
2880         Reviewed by Alejandro G. Castro.
2881
2882         * flatpak/flatpakutils.py:
2883         (WebkitFlatpak.load_from_args):
2884         (WebkitFlatpak.__init__):
2885         (WebkitFlatpak.clean_args):
2886         (WebkitFlatpak.run_in_sandbox):
2887         (WebkitFlatpak.save_config):
2888         (WebkitFlatpak):
2889         (WebkitFlatpak.setup_ccache):
2890         (WebkitFlatpak.setup_icecc):
2891         (WebkitFlatpak.setup_dev_env):
2892         * flatpak/org.webkit.WebKit.yaml:
2893
2894 2018-10-02  Michael Catanzaro  <mcatanzaro@igalia.com>
2895
2896         Unreviewed, fix missing return value in TestController::keyExistsInKeychain
2897
2898         * WebKitTestRunner/TestController.cpp:
2899         (WTR::TestController::keyExistsInKeychain):
2900
2901 2018-10-02  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2902
2903         [WinCairo] Enable WPT tests environment.
2904         https://bugs.webkit.org/show_bug.cgi?id=190128
2905
2906         Reviewed by Youenn Fablet.
2907
2908         Escaping backslash of the path not to confuse the JSON parser.
2909
2910         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2911         (WebPlatformTestServer._prepare_config):
2912
2913 2018-10-01  Ross Kirsling  <ross.kirsling@sony.com>
2914
2915         [Win][DRT] Actually set "experimental:WebAnimationsCSSIntegrationEnabled" when requested
2916         https://bugs.webkit.org/show_bug.cgi?id=190150
2917
2918         Reviewed by Fujii Hironori.
2919
2920         * DumpRenderTree/win/DumpRenderTree.cpp:
2921         (setWebPreferencesForTestOptions):
2922         DRT has been recognizing this field, but not propagating its value to WebPreferences.
2923
2924 2018-10-01  Alex Christensen  <achristensen@webkit.org>
2925
2926         Unreviewed, rolling out r236551.
2927
2928         Fails URL validating too aggressively
2929
2930         Reverted changeset:
2931
2932         "URLWithUserTypedString should return nil for URLs deemed to
2933         be invalid by WebCore::URL"
2934         https://bugs.webkit.org/show_bug.cgi?id=189979
2935         https://trac.webkit.org/changeset/236551
2936
2937 2018-10-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2938
2939         [iOS] Add SPI to customize the input accessory view when focusing an element
2940         https://bugs.webkit.org/show_bug.cgi?id=190152
2941         <rdar://problem/42754975>
2942
2943         Reviewed by Dan Bernstein.
2944
2945         Add an API test to verify that setting a custom input accessory view and custom input view on the form input
2946         session when focusing an element overrides the first responder's (i.e. WKContentView's) `-inputView` and
2947         `-inputAccessoryView`.
2948
2949         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2950         (webViewWithAutofocusedInput):
2951         (TestWebKitAPI::TEST):
2952         * TestWebKitAPI/Tests/ios/TestInputDelegate.h:
2953         * TestWebKitAPI/Tests/ios/TestInputDelegate.mm:
2954         (-[TestInputDelegate setWillStartInputSessionHandler:]):
2955         (-[TestInputDelegate willStartInputSessionHandler]):
2956         (-[TestInputDelegate _webView:willStartInputSession:]):
2957
2958 2018-10-01  Sihui Liu  <sihui_liu@apple.com>
2959
2960         Remove StorageProcess
2961         https://bugs.webkit.org/show_bug.cgi?id=189975
2962
2963         Reviewed by Geoffrey Garen.
2964
2965         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2966         (TEST):
2967         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2968         * TestWebKitAPI/Tests/WebKitCocoa/WebProcessKillIDBCleanup.mm:
2969         (TEST):
2970         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2971         (TEST):
2972         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2973         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2974         (WTR::TestRunner::terminateStorageProcess): Deleted.
2975         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2976         * WebKitTestRunner/TestController.cpp:
2977         (WTR::TestController::generatePageConfiguration):
2978         (WTR::TestController::databaseProcessName): Deleted.
2979         (WTR::TestController::databaseProcessDidCrash): Deleted.
2980         (WTR::TestController::terminateStorageProcess): Deleted.
2981         * WebKitTestRunner/TestController.h:
2982         * WebKitTestRunner/TestInvocation.cpp:
2983         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2984
2985 2018-10-01  Jiewen Tan  <jiewen_tan@apple.com>
2986
2987         [WebAuthN] Import a JS CBOR coder
2988         https://bugs.webkit.org/show_bug.cgi?id=189877
2989         <rdar://problem/44701124>
2990
2991         Reviewed by Chris Dumez.
2992
2993         Add logic to only process privateKeyBase64, userCertificateBase64 and intermediateCACertificateBase64
2994         only if acceptAttestation is true.
2995
2996         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2997         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
2998
2999 2018-10-01  Chris Dumez  <cdumez@apple.com>
3000
3001         Regression(r236512): http/tests/navigation/keyboard-events-during-provisional-navigation.html is flaky
3002         https://bugs.webkit.org/show_bug.cgi?id=190052
3003
3004         Reviewed by Ryosuke Niwa.
3005
3006         The test relies on EventSender to send events to the page synchronously to the page and then uses console.log
3007         to log those events. It also uses console.log() before sending those events to indicate what the test is about
3008         to do. Note that console.log() normally causes the WebKitTestRunner to send an asynchronous IPC to the UIProcess
3009         so that it can log the message.
3010         The issue is that EventSender uses IPC::SendOption::UseFullySynchronousModeForTesting when sending the
3011         sync IPC to the UIProcess. This option causes follow-up *asynchronous* IPC sent from the synchronous IPC reply
3012         handler to be transformed into synchronous IPC.
3013         As a result, some of the console.log IPC ended up being asynchronous and some other ended up being synchronous.
3014         Because synchronous and asynchronous IPC is not necessarily processed in-order by the UIProcess, the logged
3015         messages may end up being out of order, leading to flakiness.
3016
3017         To address the issue, we now make sure that InjectedBundle::outputText() uses a new IPC::SendOption indicated
3018         that the IPC should always be sent asynchronously, even if the connection is in fully synchronous mode. As a
3019         result, all text outputing IPC to the UIProcess will be asynchronous, and thus in order.
3020
3021         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3022         (WTR::InjectedBundle::outputText):
3023
3024 2018-10-01  Daniel Bates  <dabates@apple.com>
3025
3026         [iOS] Special keys are misidentified in DOM keyboard events
3027         https://bugs.webkit.org/show_bug.cgi?id=189974
3028
3029         Reviewed by Wenson Hsieh.
3030
3031         Add support for testing keys Forward Delete and Num Lock / Clear.
3032
3033         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3034         (hidUsageCodeForCharacter):
3035
3036 2018-10-01  Alex Christensen  <achristensen@webkit.org>
3037
3038         URL should not use TextEncoding internally
3039         https://bugs.webkit.org/show_bug.cgi?id=190111
3040
3041         Reviewed by Andy Estes.
3042
3043         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3044         (TestWebKitAPI::testUserPass):
3045         (TestWebKitAPI::TEST_F):
3046
3047 2018-10-01  Daniel Bates  <dabates@apple.com>
3048
3049         LLDB tests may use wrong configuration of lldbWebKitTester
3050         https://bugs.webkit.org/show_bug.cgi?id=189011
3051
3052         Reviewed by Dean Jackson.
3053
3054         Fixes an issue where the LLDB unit tests may use the wrong configuration of lldbWebKitTester.
3055         Additionally, add back the unit tests originally added in r235376 (https://bugs.webkit.org/show_bug.cgi?id=188936).
3056
3057         Currently the unit tests pick the LLDBWebKitTester binary based on the configuration set by
3058         script set-webkit-configuration. This may not be the same configuration specified to test-webkitpy.
3059         So, the unit tests may use the wrong binary. Instead we have test-webkitpy store the path
3060         to the correct lldbWebKitTester binary that the unit tests should use in an environment variable,
3061         called LLDB_WEBKIT_TESTER_EXECUTABLE. (We use an environment variable because the test driver,
3062         test-webkitpy, and the unit tests cannot talk to each other directly due the limitations of
3063         the Python unittest module, the Python multiprocessing module, and the general principle of unit
3064         tests - to test code in isolation). The unit tests make use of the value of this environment
3065         variable to launch lldbWebKitTester binary.
3066
3067         * Scripts/build-lldbwebkittester: We only support building lldbWebKitTester on Mac for now. Error
3068         out if this script is invoked for a non-Mac platform.
3069         * Scripts/webkitpy/test/main.py:
3070         (Tester._run_tests): Build lldbWebKitTester and store the path to it in the environment variable
3071         LLDB_WEBKIT_TESTER_EXECUTABLE.
3072         (_build_lldb_webkit_tester): Deleted.
3073         * lldb/dump_class_layout_unittest.py:
3074         (TestDumpClassLayout.shouldSkip): Use SystemHost() here and remove the _host global variable as
3075         this is the only call site that needs the Host object now.
3076         (TestDumpClassLayout.setUpClass): Take the path to the lldbWebKitTester binary from the value of
3077         the environment variable LLDB_WEBKIT_TESTER_EXECUTABLE.
3078         * lldb/lldbWebKitTester/main.cpp:
3079         (testSummaryProviders): Add back unit test support infrastructure originally added in r235376 (https://bugs.webkit.org/show_bug.cgi?id=188936).
3080         * lldb/lldb_webkit_unittest.py:
3081         (LLDBDebugSession.setup): Take the path to the lldbWebKitTester binary from the value of the environment
3082         variable LLDB_WEBKIT_TESTER_EXECUTABLE.
3083         (TestSummaryProviders):
3084         (TestSummaryProviders.shouldSkip): Skip the tests on non-Mac platforms.
3085         (TestSummaryProviders.serial_test_WTFHashSet_tablesize_and_size):
3086         (TestSummaryProviders.serial_test_WTFOptionSet_SummaryProvider_empty):
3087         (TestSummaryProviders.serial_test_WTFOptionSet_SummaryProvider_simple):
3088         (TestSummaryProviders.serial_test_WTFOptionSetProvider_empty):
3089         (TestSummaryProviders.serial_test_WTFOptionSetProvider_simple):
3090         Add back the unit tests originally added in r235376 (https://bugs.webkit.org/show_bug.cgi?id=188936).
3091
3092 2018-10-01  Olivier Blin  <olivier.blin@softathome.com>
3093
3094         [WPE] Update install-dependencies
3095         https://bugs.webkit.org/show_bug.cgi?id=190127
3096
3097         Reviewed by Michael Catanzaro.
3098
3099         * wpe/install-dependencies:
3100         libxrandr-dev is needed for gstreamer-vaapi in jhbuild
3101         It is used by gstvaapidisplay_x11.c.
3102         Add it only for Apt, already ok for Pacman and DNF.
3103
3104         Install libevent-dev for WebRTC (like GTK)
3105
3106         Install libasound2-dev for WebRTC.
3107         Add it only for Apt, already ok for Pacam and DNF.
3108
3109         Install libgbm-dev for HeadlessViewBackend, which uses gbm.h
3110
3111 2018-10-01  Thibault Saunier  <tsaunier@igalia.com>
3112
3113         [Flatpak] Add libunwind in the sandbox
3114         https://bugs.webkit.org/show_bug.cgi?id=190123
3115
3116         Allowing us to get proper traces in GStreamer trace grabing
3117         debug functions.
3118
3119         Reviewed by Philippe Normand.
3120
3121         * flatpak/org.webkit.WebKit.yaml:
3122
3123 2018-09-29  Commit Queue  <commit-queue@webkit.org>
3124
3125         Unreviewed, rolling out r236631.
3126         https://bugs.webkit.org/show_bug.cgi?id=190112
3127
3128         Caused various eventSender tests, including fast/css/pseudo-
3129         active-style-sharing*, to fail (Requested by smfr on #webkit).
3130
3131         Reverted changeset:
3132
3133         "Regression(r236512): http/tests/navigation/keyboard-events-
3134         during-provisional-navigation.html is flaky"
3135         https://bugs.webkit.org/show_bug.cgi?id=190052
3136         https://trac.webkit.org/changeset/236631
3137
3138 2018-09-28  Myles C. Maxfield  <mmaxfield@apple.com>
3139
3140         [WHLSL] Fix build after r236635
3141         https://bugs.webkit.org/show_bug.cgi?id=189210
3142
3143         Unreviewed.
3144
3145         * WebGPUShadingLanguageRI/Intrinsics.js:
3146         (Intrinsics.):
3147         * WebGPUShadingLanguageRI/Test.js:
3148         (tests.atomicsNull):
3149         (tests.numThreads):
3150         (tests.textureDimensionsNull):
3151
3152 2018-09-28  Myles C. Maxfield  <mmaxfield@apple.com>
3153
3154         [WHLSL] Allow uniform buffers to be used in the interpreter
3155         https://bugs.webkit.org/show_bug.cgi?id=189210
3156
3157         Reviewed by Filip Pizlo.
3158
3159         Every lvalue is associated with an address space, and the propagation of these address spaces
3160         matches the propagation of lvalues. Luckily, there was already the infrastructure to do most
3161         of this, so this patch just goes the last few yards. It also updates the standard library to
3162         allow for writing into all writable address spaces for out-params.
3163
3164         * WebGPUShadingLanguageRI/Checker.js:
3165         (Checker.prototype.visitAssignment):
3166         (Checker.prototype._finishVisitingPropertyAccess):
3167         * WebGPUShadingLanguageRI/Intrinsics.js:
3168         (Intrinsics.):
3169         (Intrinsics.checkFalse):
3170         (Intrinsics):
3171         * WebGPUShadingLanguageRI/StandardLibrary.js:
3172         (let.standardLibrary):
3173         * WebGPUShadingLanguageRI/Test.js:
3174         (tests.threadArrayRefLoad):
3175         (tests.threadArrayRefLoadIntLiteral):
3176         (tests.deviceArrayRefLoad):
3177         (tests.threadArrayRefStore):
3178         (tests.deviceArrayRefStore):
3179         (tests.deviceArrayRefStoreIntLiteral):
3180         (tests.threadPointerLoad):
3181         (tests.threadPointerStore):
3182         (tests.devicePointerLoad):
3183         (tests.devicePointerStore):
3184         (tests.arrayLoad):
3185         (tests.constantAddressSpace):
3186         (tests.standardLibraryDevicePointers):
3187         (tests.threadArrayLoad): Deleted.
3188         (tests.threadArrayLoadIntLiteral): Deleted.
3189         (tests.deviceArrayLoad): Deleted.
3190         (tests.threadArrayStore): Deleted.
3191         (tests.deviceArrayStore): Deleted.
3192         (tests.deviceArrayStoreIntLiteral): Deleted.
3193
3194 2018-09-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3195
3196         No DOM API to instantiate an attachment for an img element
3197         https://bugs.webkit.org/show_bug.cgi?id=189934
3198         <rdar://problem/44743222>
3199
3200         Reviewed by Ryosuke Niwa.
3201
3202         Adds 3 new API tests in WKAttachmentTests:
3203
3204         `AddAttachmentToConnectedImageElement` verifies that an image element that's already in the document can gain an
3205         attachment element via `HTMLAttachmentElement.getAttachmentIdentifier`.
3206
3207         `ChangeFileWrapperForPastedImage` verifies that an image that has been pasted produces a _WKAttachment in the UI
3208         process, and changing the file wrapper of that _WKAttachment changes the pasted image.
3209
3210         `ConnectImageWithAttachmentToDocument` verifies that script can create an image element, ensure that it has an
3211         attachment, and set a file wrapper for the generated _WKAttachment. Connecting the image to the document should
3212         then result in an image element with the contents of the _WKAttachment's file wrapper.
3213
3214         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3215         (-[TestWKWebView imageElementSize]):
3216         (-[TestWKWebView waitForImageElementSizeToBecome:]):
3217         (TestWebKitAPI::TEST):
3218         (-[TestWKWebView waitForAttachmentElementSizeToBecome:]): Deleted.
3219
3220 2018-09-28  Chris Dumez  <cdumez@apple.com>
3221
3222         Regression(r236512): http/tests/navigation/keyboard-events-during-provisional-navigation.html is flaky
3223         https://bugs.webkit.org/show_bug.cgi?id=190052
3224
3225         Reviewed by Ryosuke Niwa.
3226
3227         The test relies on EventSender to send events to the page synchronously to the page and then uses console.log
3228         to log those events. It also uses console.log() before sending those events to indicate what the test is about
3229         to do. Note that console.log() normally causes the WebKitTestRunner to send an asynchronous IPC to the UIProcess
3230         so that it can log the message.
3231         The issue is that EventSender uses IPC::SendOption::UseFullySynchronousModeForTesting when sending the
3232         sync IPC to the UIProcess. This option causes follow-up *asynchronous* IPC sent from the synchronous IPC reply
3233         handler to be transformed into synchronous IPC.
3234         As a result, some of the console.log IPC ended up being asynchronous and some other ended up being synchronous.
3235         Because synchronous and asynchronous IPC is not necessarily processed in-order by the UIProcess, the logged
3236         messages may end up being out of order, leading to flakiness.
3237
3238         To address the issue, we now make sure that InjectedBundle::outputText() uses a new IPC::SendOption indicating
3239         that the IPC should always be sent asynchronously, even if the connection is in fully synchronous mode. As a
3240         result, all text outputing IPC to the UIProcess will be asynchronous, and thus in order.
3241
3242         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3243         (WTR::InjectedBundle::outputText):
3244
3245 2018-09-28  Myles C. Maxfield  <mmaxfield@apple.com>
3246
3247         [WHLSL] Pointers should have automatically-generated equality checks
3248         https://bugs.webkit.org/show_bug.cgi?id=189986
3249
3250         Reviewed by Filip Pizlo.
3251
3252         C allows for pointer equality, and we need it so people can do null checks.
3253         This is generated the same way all our other NativeFuncs are generated - by Checker
3254         creating NativeFuncs inside CallExpression.resolve().
3255
3256         This patch also does some general cleanup.
3257
3258         * WebGPUShadingLanguageRI/All.js: Everything the late checker does is no longer necessary.
3259         The last thing it was doing was making sure that only primitive types are in resources, but
3260         it's totally reasonable to put structs and arrays in resources, so I removed this pass. We
3261         still have to add a check to make sure resources can't live within resources, but I expect
3262         that will be done in the same place that semantics are checked.
3263         * WebGPUShadingLanguageRI/AllocateAtEntryPoints.js:
3264         (allocateAtEntryPoints.updateFunction.UpdateFunctions.prototype._addVariableDeclaration):
3265         Name the global struct for debugging purposes.
3266         * WebGPUShadingLanguageRI/CallExpression.js: 
3267         (CallExpression.prototype._resolveByInstantiation): Cleanup
3268         (CallExpression.prototype._resolveWithOperatorAnderIndexer): Ditto
3269         (CallExpression.prototype._resolveWithOperatorLength): Ditto
3270         (CallExpression.prototype._resolveWithReferenceComparator): Add support to automatically
3271         generate pointer equality NativeFuncs.
3272         * WebGPUShadingLanguageRI/EPtr.js: Implement pointer equality in the interpreter.
3273         * WebGPUShadingLanguageRI/LateChecker.js: Removed.
3274         * WebGPUShadingLanguageRI/LayoutBuffers.js: Renamed from Tools/WebGPUShadingLanguageRI/LateCheckAndLayoutBuffers.js.
3275         (layoutBuffers):
3276         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL Tests.xcodeproj/project.pbxproj:
3277         * WebGPUShadingLanguageRI/NativeFunc.js:
3278         * WebGPUShadingLanguageRI/OperatorArrayRefLength.js:
3279         (OperatorArrayRefLength.prototype.instantiateImplementation):
3280         (OperatorArrayRefLength):
3281         * WebGPUShadingLanguageRI/Prepare.js:
3282         (let.prepare):
3283         * WebGPUShadingLanguageRI/SPIRV.html:
3284         * WebGPUShadingLanguageRI/Test.html:
3285         * WebGPUShadingLanguageRI/Test.js:
3286         (tests.ternaryExpression):
3287         (tests.break): Speed up testing time
3288         (tests.doWhile): Ditto
3289         (tests.forLoop): Ditto
3290         (tests.atomics): Ditto
3291         (tests.atomicsNull): Ditto
3292         (tests.pointerEquality): Test pointer equality
3293         (tests.standardLibraryDevicePointers):
3294         (tests.devicePtrPtr): Deleted.
3295         (tests.threadgroupPtrPtr): Deleted.
3296         (tests.constantPtrPtr): Deleted.
3297         * WebGPUShadingLanguageRI/index.html:
3298
3299 2018-09-28  Jiewen Tan  <jiewen_tan@apple.com>
3300
3301         [WebAuthN] Polish WebAuthN auto-test environment
3302         https://bugs.webkit.org/show_bug.cgi?id=189283
3303         <rdar://problem/44117828>
3304
3305         Reviewed by Chris Dumez.
3306
3307         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3308         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
3309
3310 2018-09-28  Chris Dumez  <cdumez@apple.com>
3311
3312         Drop support for cross-origin-window-policy header
3313         https://bugs.webkit.org/show_bug.cgi?id=190081
3314
3315         Reviewed by Ryosuke Niwa.
3316
3317         190081_DropCrossOriginWindowPolicy
3318
3319         * DumpRenderTree/mac/DumpRenderTree.mm:
3320         (enableExperimentalFeatures):
3321         * DumpRenderTree/win/DumpRenderTree.cpp:
3322         (enableExperimentalFeatures):
3323         * WebKitTestRunner/TestController.cpp:
3324         (WTR::TestController::resetPreferencesToConsistentValues):
3325
3326 2018-09-28  Koby Boyango  <koby.b@mce.systems>
3327
3328         [WTF] Add ExternalStringImpl, a StringImpl for user controlled buffers
3329         https://bugs.webkit.org/show_bug.cgi?id=189991
3330
3331         Reviewed by Yusuke Suzuki.
3332
3333         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3334
3335 2018-09-27  Ryan Haddad  <ryanhaddad@apple.com>
3336
3337         Update flakiness dashboard configuration for Mojave queues
3338         https://bugs.webkit.org/show_bug.cgi?id=190068
3339
3340         Reviewed by Alexey Proskuryakov.
3341
3342         * TestResultServer/static-dashboards/builders.jsonp:
3343
3344 2018-09-27  Ryan Haddad  <ryanhaddad@apple.com>
3345
3346         Bring up queues for Mojave
3347         https://bugs.webkit.org/show_bug.cgi?id=189935
3348
3349         Unreviewed infrastructure fix.
3350
3351         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove trigger, update bot assignment.
3352
3353 2018-09-24  Ryan Haddad  <ryanhaddad@apple.com>
3354
3355         Bring up queues for Mojave
3356         https://bugs.webkit.org/show_bug.cgi?id=189935
3357
3358         Reviewed by Alexey Proskuryakov.
3359
3360         * BuildSlaveSupport/build.webkit.org-config/config.json:
3361         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3362         (WebKitBuildbot):
3363         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3364
3365 2018-09-27  Ryan Haddad  <ryanhaddad@apple.com>
3366
3367         Increase the timeout for iOS Simulator data migration
3368         https://bugs.webkit.org/show_bug.cgi?id=190059
3369
3370         Reviewed by Aakash Jain.
3371
3372         3 minutes isn't always enough time for the data migrator to complete
3373         when booting up multiple iOS Simulators. Change the timeout to 10 minutes.
3374
3375         * Scripts/webkitpy/xcode/simulated_device.py:
3376         (SimulatedDeviceManager): Create a constant for the default timeout.
3377         (SimulatedDeviceManager.initialize_devices): Use new constant.
3378         (SimulatedDeviceManager.swap): Ditto.
3379         (SimulatedDeviceManager.wait_until_data_migration_is_done): Ditto.
3380
3381 2018-09-27  Alex Christensen  <achristensen@webkit.org>
3382
3383         URLParser should use TextEncoding through an abstract class
3384         https://bugs.webkit.org/show_bug.cgi?id=190027
3385
3386         Reviewed by Andy Estes.
3387
3388         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3389         (TestWebKitAPI::checkURL):
3390         (TestWebKitAPI::TEST_F):
3391
3392 2018-09-27  Ryan Haddad  <ryanhaddad@apple.com>
3393
3394         iOS Simulator bots should pass '--dedicated-simulators' to run-webkit-tests
3395         https://bugs.webkit.org/show_bug.cgi?id=190042
3396
3397         Reviewed by Aakash Jain.
3398
3399         To make iOS Simulator bots resilient to issues that can arise from reusing
3400         existing simulators, ensure that dedicated simulators are created for each test run.
3401
3402         * Scripts/webkitpy/common/config/ports.py:
3403         (IOSSimulatorWK2Port.run_webkit_tests_command):
3404
3405 2018-09-27  Alex Christensen  <achristensen@webkit.org>
3406
3407         URLWithUserTypedString should return nil for URLs deemed to be invalid by WebCore::URL
3408         https://bugs.webkit.org/show_bug.cgi?id=189979
3409
3410         Reviewed by Youenn Fablet.
3411
3412         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
3413         (TestWebKitAPI::originalDataAsString):
3414         (TestWebKitAPI::TEST):
3415
3416 2018-09-27  Basuke Suzuki  <Basuke.Suzuki@sony.com>
3417
3418         [Win][WebKit] Implement authentication dialog on MiniBrowser.
3419         https://bugs.webkit.org/show_bug.cgi?id=189846
3420
3421         Reviewed by Fujii Hironori.
3422
3423         It was implemented for WebKitLegacy, but not for WebKit.
3424         Also added text field to display Realm information.
3425
3426         * MiniBrowser/win/Common.cpp:
3427         (authDialogProc):
3428         (askCredential):
3429         (displayAuthDialog): Deleted.
3430         * MiniBrowser/win/Common.h:
3431         * MiniBrowser/win/MiniBrowserLib.rc:
3432         * MiniBrowser/win/MiniBrowserLibResource.h:
3433         * MiniBrowser/win/ResourceLoadDelegate.cpp:
3434         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
3435         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3436         (createString):
3437         (createUTF8String):
3438         (createWKString):
3439         (createWKURL):
3440         (WebKitBrowserWindow::WebKitBrowserWindow):
3441         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
3442         (toNullTerminatedUTF8): Deleted.
3443         * MiniBrowser/win/WebKitBrowserWindow.h:
3444
3445 2018-09-27  Youenn Fablet  <youenn@apple.com>
3446
3447         Enable getUserMedia in mini browser
3448         https://bugs.webkit.org/show_bug.cgi?id=190012
3449
3450         Reviewed by Eric Carlson.
3451
3452         Enable MediaDevices and mock capture devices.
3453         Grant mock devices access to any getUserMedia call.
3454         Covered by manual testing.
3455
3456         * MiniBrowser/mac/AppDelegate.m:
3457         (defaultConfiguration):
3458         * MiniBrowser/mac/WK2BrowserWindowController.m:
3459         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
3460         (-[WK2BrowserWindowController _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
3461
3462 2018-09-27  Antoine Quint  <graouts@apple.com>
3463
3464         [Web Animations] Turn Web Animations with CSS integration on
3465         https://bugs.webkit.org/show_bug.cgi?id=184819
3466         <rdar://problem/39597337>
3467
3468         Reviewed by Dean Jackson.
3469
3470         * DumpRenderTree/TestOptions.h:
3471
3472 2018-09-26  Alex Christensen  <achristensen@webkit.org>
3473
3474         Unreviewed, rolling out r236524.
3475
3476         Broke API tests
3477
3478         Reverted changeset:
3479
3480         "URLWithUserTypedString should return nil for URLs deemed to
3481         be invalid by WebCore::URL"
3482         https://bugs.webkit.org/show_bug.cgi?id=189979
3483         https://trac.webkit.org/changeset/236524
3484
3485 2018-09-26  James Savage  <james.savage@apple.com>
3486
3487         Allow override of viewport configuration.
3488         https://bugs.webkit.org/show_bug.cgi?id=188772.
3489         <rdar://problem/43538892>.
3490
3491         Reviewed by Simon Fraser.
3492
3493         * WebKitTestRunner/TestController.cpp:
3494         (WTR::updateTestOptionsFromTestHeader): Parse new test option key from comments.
3495         * WebKitTestRunner/TestOptions.h:
3496         * WebKitTestRunner/ios/TestControllerIOS.mm:
3497         (WTR::TestController::platformConfigureViewForTest): Handle new test option by
3498         modifying the web view's preferences accordingly.
3499
3500 2018-09-26  Alex Christensen  <achristensen@webkit.org>
3501
3502         URLs with mismatched surrogate pairs in the host should fail to parse
3503         https://bugs.webkit.org/show_bug.cgi?id=190005
3504
3505         Reviewed by Chris Dumez.
3506
3507         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3508         (TestWebKitAPI::TEST_F):
3509
3510 2018-09-26  Alex Christensen  <achristensen@webkit.org>
3511
3512         URLWithUserTypedString should return nil for URLs deemed to be invalid by WebCore::URL
3513         https://bugs.webkit.org/show_bug.cgi?id=189979
3514         <rdar://problem/44119696>
3515
3516         Reviewed by Chris Dumez.
3517
3518         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
3519         (TestWebKitAPI::TEST):
3520
3521 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
3522
3523         Selection should work across shadow boundary when initiated by a mouse drag
3524         https://bugs.webkit.org/show_bug.cgi?id=151380
3525         <rdar://problem/24363872>
3526
3527         Reviewed by Wenson Hsieh.
3528
3529         Added the support for internal:selectionAcrossShadowBoundariesEnabled test option.
3530
3531         * DumpRenderTree/TestOptions.cpp:
3532         (TestOptions::TestOptions):
3533         * DumpRenderTree/TestOptions.h:
3534         * DumpRenderTree/mac/DumpRenderTree.mm:
3535         (resetWebPreferencesToConsistentValues):
3536         (setWebPreferencesForTestOptions):
3537
3538 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
3539
3540         MiniBrowser doesn't respect default enabled-ness of experimental and internal debug features
3541         https://bugs.webkit.org/show_bug.cgi?id=189989
3542
3543         Reviewed by Simon Fraser.
3544
3545         When the preference isn't found in user defaults, use the default value of each feature's enabledness.
3546
3547         * MiniBrowser/mac/AppDelegate.m:
3548         (defaultConfiguration):
3549
3550 2018-09-26  Philippe Normand  <pnormand@igalia.com>
3551
3552         [Flatpak] Bump to apr 1.6.5
3553
3554         Version 1.6.3 is no longer available on Apache's website.
3555
3556         Rubber-stamped by Michael Catanzaro.
3557
3558         * flatpak/org.webkit.WebKit.yaml:
3559
3560 2018-09-25  Jiewen Tan  <jiewen_tan@apple.com>
3561
3562         [WebAuthN] Make AuthenticatorManager
3563         https://bugs.webkit.org/show_bug.cgi?id=189279
3564         <rdar://problem/44116792>
3565
3566         Reviewed by Chris Dumez.
3567
3568         Besides the functionality to set the WebAuthenticationMockConfiguration. Three operations are
3569         added to manipulate Keychain: addTestKeyToKeychain, cleanUpKeychain and keyExistedInKeychain.
3570
3571         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3572         * TestWebKitAPI/Tests/ios/LocalAuthenticator.mm: Removed.
3573         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3574         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3575         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
3576         (WTR::TestRunner::addTestKeyToKeychain):
3577         (WTR::TestRunner::cleanUpKeychain):
3578         (WTR::TestRunner::isKeyExisted):
3579         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3580         * WebKitTestRunner/TestController.cpp:
3581         (WTR::TestController::addTestKeyToKeychain):
3582         (WTR::TestController::cleanUpKeychain):
3583         (WTR::TestController::isKeyExisted):
3584         (WTR::TestController::setWebAuthenticationMockConfiguration):
3585         * WebKitTestRunner/TestController.h:
3586         * WebKitTestRunner/TestInvocation.cpp:
3587         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3588         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3589         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3590         (WTR::TestController::addTestKeyToKeychain):
3591         (WTR::TestController::cleanUpKeychain):
3592         (WTR::TestController::keyExistedInKeychain):
3593
3594 2018-09-25  Sihui Liu  <sihui_liu@apple.com>
3595
3596         Move Service Worker Management from Storage Process to Network Process
3597         https://bugs.webkit.org/show_bug.cgi?id=189422
3598
3599         Reviewed by Youenn Fablet.
3600
3601         Change a check in ServiceWorkers.HasServiceWorkerRegistrationBit as storage process is not
3602         launched during service worker operations now.
3603
3604         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3605
3606 2018-09-25  Eric Carlson  <eric.carlson@apple.com>
3607
3608         [MediaStream] Update constraints supported by getDisplayMedia
3609         https://bugs.webkit.org/show_bug.cgi?id=189930
3610         <rdar://problem/44740305>
3611
3612         Unreviewed, fix test broken by r236465.
3613
3614         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
3615         (TestWebKitAPI::TEST_F):
3616
3617 2018-09-25  Myles C. Maxfield  <mmaxfield@apple.com>
3618
3619         [WHSL] Implement semantics
3620         https://bugs.webkit.org/show_bug.cgi?id=189134
3621
3622         Reviewed by Filip Pizlo.
3623
3624         This patch adds parsing support and adds the checks required to support HLSL-style semantics.
3625
3626         There are 3 places where semantics are allowed:
3627
3628         1. In a field in a struct. E.g.
3629
3630         struct R {
3631             float4 position : SV_Position;
3632         }
3633         vertex R foo() {
3634             ...
3635         }
3636
3637         2. In a parameter of a function. If the function is not an entry point, the semantic is ignored.
3638
3639         compute void foo(device float[] data : b