2011-04-06 Chang Shu <cshu@webkit.org>
[WebKit-https.git] / Tools / ChangeLog
1 2011-04-06  Chang Shu  <cshu@webkit.org>
2
3         Reviewed by Darin Adler.
4
5         WebKitTestRunner needs layoutTestController.pageSizeAndMarginsInPixels
6         https://bugs.webkit.org/show_bug.cgi?id=57984
7
8         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
9         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
10         (WTR::LayoutTestController::pageSizeAndMarginsInPixels):
11         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
12
13 2011-04-06  Chris Rogers  <crogers@google.com>
14
15         Reviewed by Tony Chang.
16
17         Add web audio support to DumpRenderTree (mac port)
18         https://bugs.webkit.org/show_bug.cgi?id=57969
19
20         * DumpRenderTree/LayoutTestController.cpp:
21         (LayoutTestController::LayoutTestController):
22         (setEncodedAudioDataCallback):
23         (LayoutTestController::staticFunctions):
24         * DumpRenderTree/LayoutTestController.h:
25         (LayoutTestController::dumpAsAudio):
26         (LayoutTestController::setDumpAsAudio):
27         (LayoutTestController::encodedAudioData):
28         (LayoutTestController::setEncodedAudioData):
29         * DumpRenderTree/mac/DumpRenderTree.mm:
30         (dumpAudio):
31         (dump):
32
33 2011-04-06  Benjamin Poulain  <benjamin.poulain@nokia.com>
34
35         Reviewed by Kenneth Rohde Christiansen.
36
37         [Qt] LayoutTestController needs to implement numberOfPendingGeolocationPermissionRequests
38         https://bugs.webkit.org/show_bug.cgi?id=56086
39
40         Add the missing method.
41
42         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
43         (WebCore::DumpRenderTree::getAllPages): Add a method to return all the pages allocated for the current test.
44         * DumpRenderTree/qt/DumpRenderTreeQt.h:
45         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
46         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
47
48 2011-04-06  Dai Mikurube  <dmikurube@chromium.org>
49
50         Reviewed by David Levin.
51
52         Add QUOTA build flag for unified quota API
53         https://bugs.webkit.org/show_bug.cgi?id=57918
54
55         * Scripts/build-webkit: Added QUOTA build flag
56
57 2011-04-06  Dirk Pranke  <dpranke@chromium.org>
58
59         Reviewed by Tony Chang.
60
61         Adjust the apple webkit port's default timeout to match
62         old-run-webkit-tests at 35 seconds.
63
64         https://bugs.webkit.org/show_bug.cgi?id=37738
65
66         * Scripts/webkitpy/layout_tests/port/mac.py:
67
68 2011-04-06  Scott Cameron  <sccameron@rim.com>
69
70         Reviewed by Eric Seidel.
71
72         Remove global variable $httpdPath and replace with the return value of
73         getHTTPDPath().  Also remove unnecessary calls to getHTTPDPath().
74         https://bugs.webkit.org/show_bug.cgi?id=53499
75
76         * Scripts/run-iexploder-tests:
77         * Scripts/webkitperl/httpd.pm:
78
79 2011-04-06  Kevin Ollivier  <kevino@theolliviers.com>
80
81         Reviewed by Darin Adler.
82
83         Make sure JS_EXPORT_PRIVATE is an empty define when we aren't using the export macros.
84         
85         https://bugs.webkit.org/show_bug.cgi?id=27551
86         
87         * DumpRenderTree/config.h:
88         * WebKitAPITest/config.h:
89         * WebKitTestRunner/config.h:
90
91 2011-04-06  Tony Chang  <tony@chromium.org>
92
93         Reviewed by Darin Adler.
94
95         teach run-webkit-tests to read checksums from png files
96         https://bugs.webkit.org/show_bug.cgi?id=57993
97
98         * Scripts/old-run-webkit-tests: Read the first 2k of a .png if there's
99           no .checksum and look for the checksum in there.
100
101 2011-04-06  David Dorwin  <ddorwin@chromium.org>
102
103         Reviewed by David Levin.
104
105         Enable fullscreen layout tests for Chromium
106         https://bugs.webkit.org/show_bug.cgi?id=55726
107
108         Make DumpRenderTree always run with fullscreen enabled (equivalent of --enable-fullscreen).
109
110         * DumpRenderTree/chromium/WebPreferences.cpp:
111         (WebPreferences::applyTo):
112
113 2011-04-06  Adam Roben  <aroben@apple.com>
114
115         Add a "view leaks" link to builds on SnowLeopard Intel Leaks
116
117         Fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks bot results page
118
119         Reviewed by David Kilzer.
120
121         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
122         (ExtractTestResults.resultDirectoryURL): Added. Moved code to calculate the URL for the
123         build's results directory here...
124         (ExtractTestResults.finished): ...from here.
125         (ExtractTestResultsAndLeaks): New class that's used by the leaks builder
126         (ExtractTestResultsAndLeaks.finished): Calls up to the base class, but also adds a "view
127         leaks" link to point to Leaks Viewer for this build.
128         (TestFactory): Added ExtractTestResultsClass abstraction. This isn't overridden anywhere,
129         but it seemed good to add for consistency with BuildAndTestFactory.
130         (BuildAndTestFactory): Added ExtractTestResultsClass abstraction.
131         (BuildAndTestLeaksFactory): Use ExtractTestResultsAndLeaks as our ExtractTestResultsClass so
132         that we'll get a "view leaks" link.
133
134 2011-04-06  Zan Dobersek  <zandobersek@gmail.com>
135
136         Reviewed by Eric Seidel.
137
138         [Gtk] plugins/set-status.html fails
139         https://bugs.webkit.org/show_bug.cgi?id=57844
140
141         Allow an empty status text to be dumped.
142
143         * DumpRenderTree/gtk/DumpRenderTree.cpp:
144         (webViewStatusBarTextChanged):
145
146 2011-04-06  Chang Shu  <cshu@webkit.org>
147
148         Reviewed by Darin Adler.
149
150         WebKitTestRunner needs layoutTestController.pageNumberForElementById
151         https://bugs.webkit.org/show_bug.cgi?id=42329
152
153         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
154         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
155         (WTR::LayoutTestController::pageNumberForElementById):
156         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
157
158 2011-04-06  Sergio Villar Senin  <svillar@igalia.com>
159
160         Reviewed by Martin Robinson.
161
162         [GTK] DumpRenderTree: do not try to free NULL SoupURIs
163         https://bugs.webkit.org/show_bug.cgi?id=57932
164
165         Some Layout tests have invalid URIs that do not generate valid
166         SoupURI instances. Do not try to free those NULL SoupURIs.
167
168         * DumpRenderTree/gtk/DumpRenderTree.cpp:
169         (willSendRequestCallback):
170
171 2011-04-06  Csaba Osztrogonác  <ossy@webkit.org>
172
173         Reviewed by Andreas Kling.
174
175         ORWT shouldn't generate diff files for tests without expected files
176         https://bugs.webkit.org/show_bug.cgi?id=57846
177
178         * Scripts/old-run-webkit-tests:
179
180 2011-04-05  Kevin Ollivier  <kevino@theolliviers.com>
181
182         [wx] Mac build fix. Handle cases where 10.4 SDK is not installed, and also add x86_64 arch
183         to deps.
184
185         * wx/install-unix-extras:
186
187 2011-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>
188
189         Unreviewed, rolling out r82978, r82999, and r83001.
190         http://trac.webkit.org/changeset/82978
191         http://trac.webkit.org/changeset/82999
192         http://trac.webkit.org/changeset/83001
193         https://bugs.webkit.org/show_bug.cgi?id=57913
194
195         Does not work in Python 2.5 (Requested by abarth on #webkit).
196
197         * Scripts/webkitpy/common/system/executive.py:
198         * Scripts/webkitpy/common/system/executive_unittest.py:
199
200 2011-04-05  Chang Shu  <cshu@webkit.org>
201
202         Reviewed by Darin Adler.
203
204         WebKitTestRunner needs layoutTestController.numberOfPages
205         https://bugs.webkit.org/show_bug.cgi?id=42694
206
207         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
208         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
209         (WTR::LayoutTestController::numberOfPages):
210         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
211
212 2011-04-05  Tony Chang  <tony@chromium.org>
213
214         Reviewed by Mihai Parparita.
215
216         [chromium] stop putting results downloaded from WebKit Linux in chromium-linux-x86_64
217         https://bugs.webkit.org/show_bug.cgi?id=57889
218
219         * Scripts/webkitpy/layout_tests/port/chromium.py:
220         * Scripts/webkitpy/layout_tests/port/test.py:
221         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
222
223 2011-04-05  Adam Barth  <abarth@webkit.org>
224
225         Silly with statement, from the future!
226
227         * Scripts/webkitpy/common/system/executive.py:
228
229 2011-04-05  Adam Barth  <abarth@webkit.org>
230
231         Reviewed by Tony Chang.
232
233         Don't use Exception.message because it's deprecated
234         https://bugs.webkit.org/show_bug.cgi?id=57892
235
236         Suppress the warning for now.  When we move to Python 3, we might need
237         to something more dramatic.
238
239         * Scripts/webkitpy/common/system/executive.py:
240
241 2011-04-05  Mihai Parparita  <mihaip@chromium.org>
242
243         Reviewed by Ojan Vafai.
244
245         Add builders.js to dashboard file list
246         https://bugs.webkit.org/show_bug.cgi?id=57899
247
248         Add file added by http://crrev.com/80538 to dashboard file list.
249
250         * TestResultServer/handlers/dashboardhandler.py:
251
252 2011-04-05  MORITA Hajime  <morrita@google.com>
253
254         Reviewed by Adam Barth.
255
256         webkit-patch should print git's stderr when git svn dcommit fail
257         http://webkit.org/b/57861
258
259         * Scripts/webkitpy/common/checkout/scm.py:
260
261 2011-04-05  Mihai Parparita  <mihaip@chromium.org>
262
263         Reviewed by Tony Chang.
264
265         Add --baseline-search-path to NRWT
266         https://bugs.webkit.org/show_bug.cgi?id=56233
267         
268         Add NRWT option to specify additional directories to look for baselines
269         (will be used by hardware GPU bots which will have local per-bot
270         expectations for some tests)
271
272         * Scripts/webkitpy/common/system/filesystem_mock.py:
273         * Scripts/webkitpy/layout_tests/port/base.py:
274         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
275         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
276
277 2011-04-05  Adam Roben  <aroben@apple.com>
278
279         Strip off /results.html from results URLs before trying to load leaks files from them
280
281         r82734 changed build.webkit.org's "view results" URLs to point straight to the results.html
282         files, rather than pointing to the directory that contains them. This is more convenient for
283         people browsing build.webkit.org, but confused Leaks Viewer.
284
285         Fixes <http://webkit.org/b/57869> REGRESSION (r82734): Links in Leaks Viewer's Recent Builds
286         list don't work
287
288         Reviewed by Joseph Pecoraro.
289
290         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
291         (RecentBuildsLoader.prototype.start): Strip off "/results.html" from the results URL.
292
293 2011-04-05  Carol Szabo  <carol@webkit.org>
294
295         Unreviewed.
296
297         Updated my info in committers.py
298
299         Scripts\webkitpy\common\config\committers.py 
300
301 2011-04-05  Csaba Osztrogonác  <ossy@webkit.org>
302
303         Reviewed by Laszlo Gombos.
304
305         [Qt] Make WebKitLibraries optional for building QtWebKit
306         https://bugs.webkit.org/show_bug.cgi?id=57542
307
308         * Scripts/build-webkit:
309
310 2011-04-05  Chang Shu  <cshu@webkit.org>
311
312         Reviewed by Laszlo Gombos.
313
314         [Qt] MiniBrowser defaultUrl does not work
315         https://bugs.webkit.org/show_bug.cgi?id=57021
316
317         Match the behavior and coding of MiniBrowser to QtTestBrowser.
318         * MiniBrowser/qt/main.cpp:
319         (main):
320
321 2011-04-05  Jade Han  <jade.han@nokia.com>
322
323         Reviewed by Laszlo Gombos.
324
325         [Qt] [Symbian] Disable WebKitTestRunner for Symbian
326         https://bugs.webkit.org/show_bug.cgi?id=54977
327
328         This change is a preparation to enable building webkit2 for Symbian.
329         Bug 57834 is filed to fix and enable WebKitTestRunner for Symbian.
330
331         * Tools.pro:
332
333 2011-04-05  Zoltan Horvath  <zoltan@webkit.org>
334
335         Reviewed by Andreas Kling.
336
337         [Qt] Fix timeoutTimer of MiniBrowser's UrlLoader
338         https://bugs.webkit.org/show_bug.cgi?id=57832
339
340         Only QWKPage has loadFinished signal so connect to it instead of BrowserWindow.
341
342         * MiniBrowser/qt/UrlLoader.cpp:
343         (UrlLoader::UrlLoader):
344
345 2011-04-05  Zoltan Horvath  <zoltan@webkit.org>
346
347         [Qt] Linux Release minimal build fix after r82919.
348
349         * MiniBrowser/qt/BrowserWindow.cpp:
350         (BrowserWindow::loadURLListFromFile):
351         * QtTestBrowser/launcherwindow.cpp:
352         (LauncherWindow::loadURLListFromFile):
353
354 2011-04-05  Zoltan Horvath  <zoltan@webkit.org>
355
356         Reviewed by Andreas Kling.
357
358         [Qt] Make URL loader accessible from testbrowser's menus
359         https://bugs.webkit.org/show_bug.cgi?id=57823
360
361         Add "Load URLs from file" to QtTestBrowser's and to MiniBrowser's menu.
362
363         * MiniBrowser/qt/BrowserWindow.cpp:
364         (BrowserWindow::BrowserWindow):
365         (BrowserWindow::loadURLListFromFile):
366         (BrowserWindow::~BrowserWindow):
367         * MiniBrowser/qt/BrowserWindow.h:
368         * QtTestBrowser/launcherwindow.cpp:
369         (LauncherWindow::LauncherWindow):
370         (LauncherWindow::~LauncherWindow):
371         (LauncherWindow::createChrome):
372         (LauncherWindow::loadURLListFromFile):
373         * QtTestBrowser/launcherwindow.h:
374
375 2011-04-04  Sam Weinig  <sam@webkit.org>
376
377         Reviewed by Brian Weinstein.
378
379         Remove duplicate API from WKContext
380         <rdar://problem/8727879>
381         https://bugs.webkit.org/show_bug.cgi?id=57815
382
383         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
384         * TestWebKitAPI/Tests/WebKit2/SendingMessagesToTheWebProcessBeforeItIsValid.cpp: Removed.
385         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
386         Remove SendingMessagesToTheWebProcessBeforeItIsValid since the API it was testing is now removed.
387
388 2011-04-04  Tony Chang  <tony@chromium.org>
389
390         Reviewed by Ojan Vafai.
391
392         [chromium] don't write .checksum files if a fallback platform has an embedded checksum
393         https://bugs.webkit.org/show_bug.cgi?id=57783
394
395         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
396         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
397
398 2011-04-04  Kevin Ollivier  <kevino@theolliviers.com>
399
400         [wx] Unreviewed build fix, run uninstall when cleaning to remove built files
401         from WebKitBuild.
402
403         * Scripts/webkitdirs.pm:
404
405 2011-04-04  Martin Robinson  <mrobinson@igalia.com>
406
407         Reviewed by Gustavo Noronha Silva.
408
409         [GTK] WebGL support
410         https://bugs.webkit.org/show_bug.cgi?id=31517
411
412         Add support to the DRT for turning on WebGL when a layout tests requests it.
413
414         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
415         (LayoutTestController::overridePreference): Allow turning on WebGL from tests.
416
417 2011-04-04  Chang Shu  <cshu@webkit.org>
418
419         Reviewed by Darin Adler.
420
421         WebKitTestRunner needs layoutTestController.setAllowFileAccessFromFileURLs
422         https://bugs.webkit.org/show_bug.cgi?id=57572
423
424         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
425         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
426         (WTR::LayoutTestController::setAllowFileAccessFromFileURLs):
427         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
428
429 2011-04-04  Keith Kyzivat  <keith.kyzivat@nokia.com>
430
431         Reviewed by Csaba Osztrogonác.
432
433         [Qt] DumpRenderTree breaks compilation in some uClibc environments
434         https://bugs.webkit.org/show_bug.cgi?id=57602
435
436         * DumpRenderTree/qt/main.cpp:
437         (get_backtrace):
438
439 2011-04-04  Kevin Ollivier  <kevino@theolliviers.com>
440
441         [wx] Unreviewed build fix, add new LayoutTestController method stub to wx.
442
443         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
444         (LayoutTestController::shadowRoot):
445
446 2011-04-04  Pavel Podivilov  <podivilov@chromium.org>
447
448         Unreviewed, fix exception in rebaseline tool.
449
450         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
451
452 2011-04-02  Beth Dakin  <bdakin@apple.com>
453
454         Rubber-stamped by Geoff Garen.
455
456         For Dan!
457         * DumpRenderTree/mac/DumpRenderTree.mm:
458         (resetWebViewToConsistentStateBeforeTesting):
459
460 2011-04-02  Beth Dakin  <bdakin@apple.com>
461
462         Rubber-stamped by Geoff Garen.
463
464         Need to reset the scale, much like zoom.
465         * DumpRenderTree/mac/DumpRenderTree.mm:
466         (resetWebViewToConsistentStateBeforeTesting):
467
468 2011-04-02  Sam Weinig  <sam@webkit.org>
469
470         Reviewed by Beth Dakin.
471
472         https://bugs.webkit.org/show_bug.cgi?id=57605
473         Frame::pageScaleFactor() should not affect getBoundingClientRect() or 
474         getClientRects()
475         -and corresponding-
476         <rdar://problem/9194541>
477
478         Add DRT support for the scaleWebView SPI.
479         * DumpRenderTree/mac/EventSendingController.mm:
480         (+[EventSendingController isSelectorExcludedFromWebScript:]):
481         (+[EventSendingController webScriptNameForSelector:]):
482         (-[EventSendingController scalePageBy:atX:andY:]):
483         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
484         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
485         (WTR::EventSendingController::scalePageBy):
486         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
487         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
488         (WTR::InjectedBundlePage::reset):
489
490 2011-04-02  Dominic Cooney  <dominicc@google.com>
491
492         Reviewed by Martin Robinson.
493
494         Add layoutTestController.shadowRoot to GTK DumpRenderTree.
495         https://bugs.webkit.org/show_bug.cgi?id=57551
496
497         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
498         (LayoutTestController::shadowRoot):
499
500 2011-04-02  Patrick Gansterer  <paroga@webkit.org>
501
502         Reviewed by Eric Seidel.
503
504         Remove AbstractStep._run_script and move script names to ports.py
505         https://bugs.webkit.org/show_bug.cgi?id=57704
506
507         Replace deprecated _run_script with _tool.executive.run_and_throw_if_fail.
508
509         * Scripts/webkitpy/common/config/ports.py:
510         * Scripts/webkitpy/tool/commands/download_unittest.py:
511         * Scripts/webkitpy/tool/commands/roll_unittest.py:
512         * Scripts/webkitpy/tool/commands/upload_unittest.py:
513         * Scripts/webkitpy/tool/steps/abstractstep.py:
514         * Scripts/webkitpy/tool/steps/checkstyle.py:
515         * Scripts/webkitpy/tool/steps/preparechangelog.py:
516         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
517         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
518
519 2011-04-02  Patrick Gansterer  <paroga@webkit.org>
520
521         Reviewed by Eric Seidel.
522
523         Emulate shebang on Win32
524         https://bugs.webkit.org/show_bug.cgi?id=55927
525
526         Scripts on Windows work only if they are called with the explicit interpreter.
527         Read the first line of scripts to detect the correct executable.
528
529         * Scripts/webkitpy/common/config/ports.py:
530         * Scripts/webkitpy/common/system/executive.py: Added interpreter_for_script().
531         * Scripts/webkitpy/common/system/executive_unittest.py:
532
533 2011-04-01  Adam Barth  <abarth@webkit.org>
534
535         Reviewed by Eric Seidel.
536
537         apos entities shouldn't show up in ChangeLogs when using webkit-patch
538         https://bugs.webkit.org/show_bug.cgi?id=57692
539
540         Previously, we were using BeautifulSoup to process XML from
541         bugs.webkit.org, but that's incorrect.  We should be using
542         BeautifulStoneSoup to process the XML.  We were getting the &apos;
543         entity wrong because &apos; is an XML entity but not an HTML entity.
544
545         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
546         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
547
548 2011-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
549
550         Unreviewed, rolling out r82721.
551         http://trac.webkit.org/changeset/82721
552         https://bugs.webkit.org/show_bug.cgi?id=57687
553
554         This patch introduced assertion failures on the GTK+ bots.
555         (Requested by mrobinson on #webkit).
556
557         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
558         (LayoutTestController::shadowRoot):
559
560 2011-04-01  Csaba Osztrogonác  <ossy@webkit.org>
561
562         Unreviewed buildfix.
563
564         [Qt][WK2] Build Webkit2 using "-2" option on Qt
565         https://bugs.webkit.org/show_bug.cgi?id=55074
566
567         * Scripts/build-webkit: Ensure that "-2" isn't passed to qmake.
568         (The isWK2() function removes it from @ARGV, but not from @options.)
569
570 2011-04-01  Keith Kyzivat  <keith.kyzivat@nokia.com>
571
572         Reviewed by Csaba Osztrogonác.
573
574         [Qt] [WK2] MiniBrowser.qrc not found - regression from rev 82671
575         https://bugs.webkit.org/show_bug.cgi?id=57666
576
577         * MiniBrowser/qt/MiniBrowser.qrc: Renamed from Tools/MiniBrowser/MiniBrowser.qrc.
578
579 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
580
581         Reviewed by Adam Barth.
582
583         new-run-webkit-tests: fix feature detection, skipped platform lists on mac
584
585         We apparently never implemented the code to skip tests based on
586         what was compiled into DRT. Also, change the logic used to skip
587         platform directories to match what old-run-webkit-tests does: 
588         skip every test not in a directory in the baseline search path.
589
590         https://bugs.webkit.org/show_bug.cgi?id=57662
591
592         * Scripts/webkitpy/layout_tests/port/mac.py:
593         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
594         * Scripts/webkitpy/layout_tests/port/webkit.py:
595
596 2011-03-29  Mark Rowe  <mrowe@apple.com>
597
598         Reviewed by Jon Honeycutt.
599
600         <http://webkit.org/b/56730> new-run-webkit-tests fails on Lion seed
601
602         Teach new-run-webkit-tests about the concept of an unreleased version of Mac OS X.
603
604         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
605         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
606         * Scripts/webkitpy/layout_tests/port/mac.py:
607         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
608
609 2011-04-01  Chang Shu  <cshu@webkit.org>
610
611         Reviewed by Csaba Osztrogonác.
612
613         [Qt][WK2] Build Webkit2 using "-2" option on Qt
614         https://bugs.webkit.org/show_bug.cgi?id=55074
615
616         * Scripts/build-webkit:
617
618 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
619
620         Reviewed by Tony Chang.
621
622         new-run-webkit-tests: remove spurious port version override in webkit.py
623         base.py provides a default implementation so this is just
624         breaking things.
625
626         https://bugs.webkit.org/show_bug.cgi?id=57667
627
628         * Scripts/webkitpy/layout_tests/port/webkit.py:
629         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
630
631 2011-04-01  Csaba Osztrogonác  <ossy@webkit.org>
632
633         Reviewed by Adam Roben.
634
635         Make view results on waterfall direct link to results.html
636         https://bugs.webkit.org/show_bug.cgi?id=57671
637
638         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add "/results.html" to the URL.
639         * Scripts/old-run-webkit-tests: Add links to httpd access and error logs.
640
641 2011-04-01  Sam Weinig  <sam@webkit.org>
642
643         Fix windows build.
644
645         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
646         (TestWebKitAPI::TEST):
647         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
648         (TestWebKitAPI::flushMessages):
649
650 2011-04-01  Sam Weinig  <sam@webkit.org>
651
652         Reviewed by Adam Roben.
653
654         Add adoptWK to WKRetainPtr.h
655         https://bugs.webkit.org/show_bug.cgi?id=57670
656
657         * TestWebKitAPI/PlatformUtilities.h:
658         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
659         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
660         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
661         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
662         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
663         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
664         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
665         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
666         (TestWebKitAPI::createSessionStateContainingFormData):
667         * WebKitTestRunner/StringFunctions.h:
668         Replace custom versions of adoptWK with the API on in WebKit2/WKRetainPtr.h.
669
670 2011-04-01  Sam Weinig  <sam@webkit.org>
671
672         Reviewed by Adam Roben.
673
674         Fix leak noticed by Adam Roben in LayoutTestController::shadowRoot.
675
676         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
677         (WTR::LayoutTestController::shadowRoot):
678         Make judicious use of adoptWK().
679
680 2011-04-01  Sam Weinig  <sam@webkit.org>
681
682         Reviewed by Timothy Hatcher.
683
684         Fix extract-localizable-strings for macro change from UI_STRING -> WEB_UI_STRING.
685
686         * Scripts/extract-localizable-strings:
687
688 2011-04-01  Anders Carlsson  <andersca@apple.com>
689
690         Reviewed by Sam Weinig.
691
692         Shockwave plug-in doesn't accept mouse events
693         https://bugs.webkit.org/show_bug.cgi?id=57653
694         <rdar://problem/8483273>
695
696         Add a plug-in test.
697
698         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
699         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
700         (PluginTest::indicateTestFailure):
701         Move code from NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject here.
702
703         (PluginTest::NPN_ConvertPoint):
704         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
705         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp:
706         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
707         Call indicateTestFailure.
708
709         * DumpRenderTree/TestNetscapePlugIn/Tests/mac: Added.
710         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp: Added.
711         (ConvertPoint::ConvertPoint):
712         (ConvertPoint::testConvert):
713         (ConvertPoint::NPP_New):
714
715 2011-04-01  Dominic Cooney  <dominicc@google.com>
716
717         Reviewed by Martin Robinson.
718
719         Add layoutTestController.shadowRoot to GTK DumpRenderTree.
720         https://bugs.webkit.org/show_bug.cgi?id=57551
721
722         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
723         (LayoutTestController::shadowRoot):
724
725 2011-04-01  Sam Weinig  <sam@webkit.org>
726
727         Reviewed by Anders Carlsson.
728
729         WebKitTestRunner needs layoutTestController.shadowRoot
730         https://bugs.webkit.org/show_bug.cgi?id=57661
731
732         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
733         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
734         (WTR::LayoutTestController::shadowRoot):
735         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
736         Implement layoutTestController.shadowRoot for WebKit2.
737
738 2011-04-01  Chang Shu  <cshu@webkit.org>
739
740         Reviewed by Darin Adler.
741
742         WebKitTestRunner needs layoutTestController.setDatabaseQuota
743         https://bugs.webkit.org/show_bug.cgi?id=57568
744
745         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
746         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
747         (WTR::LayoutTestController::setDatabaseQuota):
748         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
749
750 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
751
752         Reviewed by Tony Chang.
753
754         This patch completes the cleanup of
755         rebaseline-chromium-webkit-tests to work with all of the
756         variants of a platform (we can now rebaseline gpu- and non-gpu
757         files at the same time).
758
759         When the rebaselining is complete, any lines declared as
760         REBASELINE in the expectations file that matches a test that was
761         actually rebaselined will be deleted, even if only one of the
762         variants was actually rebaselined. This may cause odd problems,
763         but is better than where we're at today.
764
765         This change removes the -g flag and deprecates -w. The -g flag is gone
766         because GPU baselines are handled just like any other variant.
767         The -w flag is deprecated because this tool now only works
768         against the canaries, since that's the only place we have a full
769         set of bots. It will be trivial to change this to
770         build.webkit.org if we decide that's where we want them to be.
771
772         Also, this patch deletes a lot of cruft that is no longer needed
773         in the test_expectations code and the port-specific code.
774
775         https://bugs.webkit.org/show_bug.cgi?id=55191
776
777         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
778         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
779         * Scripts/webkitpy/layout_tests/port/base.py:
780         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
781         * Scripts/webkitpy/layout_tests/port/chromium.py:
782         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
783         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
784         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
785         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
786         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
787         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
788         * Scripts/webkitpy/layout_tests/port/mac.py:
789         * Scripts/webkitpy/layout_tests/port/test.py:
790         * Scripts/webkitpy/layout_tests/port/webkit.py:
791         * Scripts/webkitpy/layout_tests/port/win.py:
792         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
793         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
794
795 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
796
797         Reviewed by Adam Barth.
798
799         rebaseline-chromium-webkit-tests does not work correctly with
800         version-specific baselines. This patch updates the tool to use
801         all of the version-specific bots on the canaries, and will now
802         attempt to rebaseline all of the versions by default, although
803         it will not update both GPU and CPU versions.
804         
805         Also, it will no longer modify the test_expectations.txt file
806         *at all*. You will have to manually delete the REBASELINE lines
807         after running the tool and determining that it did what you
808         wanted it to do. This should be fixed in a separate bug - see
809         webkit bug #55191.
810
811         https://bugs.webkit.org/show_bug.cgi?id=55608
812
813         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
814         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
815         * Scripts/webkitpy/layout_tests/port/chromium.py:
816         * Scripts/webkitpy/layout_tests/port/test.py:
817         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
818         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
819
820 2011-03-31  Tony Chang  <tony@chromium.org>
821
822         Reviewed by Ojan Vafai.
823
824         [chromium] update the rebaseline tool to know about pngs with checksums
825         https://bugs.webkit.org/show_bug.cgi?id=57481
826
827         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Skip over .checksum files if the checksum is already in the png
828         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
829
830 2011-04-01  Adam Roben  <aroben@apple.com>
831
832         Retrieve revision numbers from the build's got_revision property in Leaks Viewer
833
834         Previously, we were getting the revision of the first revision that triggered a build.
835         Choosing the last revision would have been more accurate. But got_revision is what is used
836         everywhere else on build.webkit.org, and should work even when there were no changes that
837         triggered a build (e.g., if someone clicked the Force Build button).
838
839         Fixes <http://webkit.org/b/57630> Leaks viewer gets some revision numbers wrong in the
840         recent builds list
841
842         Reviewed by Anders Carlsson.
843
844         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
845         (RecentBuildsLoader.prototype.start): Pull the revision number out of the got_revision
846         property, rather than out of the first (i.e., earliest) change in the sourceStamp object.
847
848         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:
849         (Array.prototype.first): Added this helper function to return the first element in an array
850         that matches the given predicate, or null if no such element exists.
851
852 2011-03-31  Adam Roben  <aroben@apple.com>
853
854         Prefer (but don't require) bug URLs to be on their own line when parsing bug numbers from ChangeLogs
855
856         Fixes <http://webkit.org/b/57579> webkit-patch is too strict about bug URL formatting
857
858         Reviewed by Darin Adler.
859
860         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
861         (parse_bug_id_from_changelog): Fall back to parse_bug_id if we weren't able to find a bug
862         URL on its own line.
863
864         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
865         (BugzillaTest.test_parse_bug_id_from_changelog): Updated expected results for test
866         progression, and added a new test that uses a short bug URL while I was at it.
867
868 2011-04-01  Adam Roben  <aroben@apple.com>
869
870         Mark .vcproj/.vsprops/.sln files as being Windows-only
871
872         Fixes <http://webkit.org/b/57489> Mac builders built 82512, but shouldn't have
873
874         Reviewed by Anders Carlsson.
875
876         * Scripts/webkitpy/common/config/build.py:
877         (_should_file_trigger_build): Added patterns to mark .vcproj/.vsprops/.sln files and .vcproj
878         directories as Windows-only.
879
880         * Scripts/webkitpy/common/config/build_unittest.py:
881         (ShoulBuildTest): Added test cases for the above.
882
883 2011-04-01  Keith Kyzivat  <keith.kyzivat@nokia.com>
884
885         Reviewed by Laszlo Gombos.
886
887         [Qt] Build MiniBrowser for Symbian
888         https://bugs.webkit.org/show_bug.cgi?id=56319
889
890         Have MiniBrowser reference it's own copy of useragentlist.txt instead
891         of copying QtTestBrowser's.
892         Remove Tools/MiniBrowser/DerivedSources.pro
893         This reduces complexity in the Tools scripts due to Symbian limitations.
894
895         * DerivedSources.pro:
896         * MiniBrowser/DerivedSources.pro: Removed.
897         * MiniBrowser/MiniBrowser.qrc:
898         * MiniBrowser/qt/MiniBrowser.pro:
899         * Scripts/webkitdirs.pm:
900
901 2011-03-31  Chang Shu  <cshu@webkit.org>
902
903         Reviewed by Darin Adler.
904
905         WebKitTestRunner needs layoutTestController.clearAllDatabases
906         https://bugs.webkit.org/show_bug.cgi?id=42540
907
908         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
909         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
910         (WTR::InjectedBundle::beginTesting):
911         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
912         (WTR::LayoutTestController::clearAllDatabases):
913         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
914
915 2011-03-31  Chang Shu  <cshu@webkit.org>
916
917         Reviewed by Darin Adler.
918
919         WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
920         https://bugs.webkit.org/show_bug.cgi?id=42692
921
922         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
923
924 2011-03-31  Darin Adler  <darin@apple.com>
925
926         Reviewed by Sam Weinig.
927
928         Implement mouseDown, mouseUp, and mouseMoveTo in WebKitTestRunner
929         https://bugs.webkit.org/show_bug.cgi?id=57573
930
931         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
932         Added real definitions for mouseDown, mouseUp, mouseMoveTo and leapForward.
933         Removed fake definitions of keyDown and contextClick.
934
935         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
936         (WTR::operator==): Added. So we can compare two WKPoint structs.
937         (WTR::parseModifier): Added.
938         (WTR::parseModifierArray): Added.
939         (WTR::EventSendingController::EventSendingController): Initialize the
940         new data members.
941         (WTR::EventSendingController::mouseDown): Added. Calls
942         WKBundlePageSimulateMouseDown.
943         (WTR::EventSendingController::mouseUp): Added. Calls
944         WKBundlePageSimulateMouseUp.
945         (WTR::EventSendingController::mouseMoveTo): Added. Calls
946         WKBundlePageSimulateMouseMotion.
947         (WTR::EventSendingController::leapForward): Added.
948         (WTR::EventSendingController::updateClickCount): Added. Used by the
949         mouseDown/Up functions to create a click count.
950
951         * WebKitTestRunner/InjectedBundle/EventSendingController.h: Updated
952         for the changes above.
953
954 2011-03-31  Sergio Villar Senin  <svillar@igalia.com>
955
956         Reviewed by Martin Robinson.
957
958         [GTK] implement LayoutTestController::setWillSendRequestReturnsNull
959         https://bugs.webkit.org/show_bug.cgi?id=57362
960
961         Do not generate DRT output if willSendRequestReturnsNull is set.
962
963         * DumpRenderTree/gtk/DumpRenderTree.cpp:
964         (willSendRequestCallback):
965
966 2011-03-31  Vamshikrishna.Yellenki  <vamshi@motorola.com> and Alejandro G. Castro  <alex@igalia.com>
967
968         Reviewed by Martin Robinson.
969
970         Implement MiniBrowser for Gtk port.
971         https://bugs.webkit.org/show_bug.cgi?id=48512
972
973         Initial implementation of the Gtk MiniBrowser.
974
975         * MiniBrowser/gtk/GNUmakefile.am: Added.
976         * MiniBrowser/gtk/main.c: Added.
977         (activateUriEntryCallback):
978         (destroyCallback):
979         (goBackCallback):
980         (goForwardCallback):
981         (createToolbar):
982         (createWebView):
983         (createWindow):
984         (argumentToURL):
985         (main):
986
987 2011-03-30  Dominic Cooney  <dominicc@google.com>
988
989         Reviewed by Dimitri Glazkov.
990
991         Adds layoutTestController.shadowRoot accessor to Mac DRT.
992         https://bugs.webkit.org/show_bug.cgi?id=57415
993
994         * DumpRenderTree/LayoutTestController.cpp:
995         (shadowRootCallback):
996         (LayoutTestController::staticFunctions):
997         * DumpRenderTree/LayoutTestController.h:
998         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
999         (LayoutTestController::shadowRoot):
1000         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1001         (LayoutTestController::shadowRoot):
1002
1003 2011-03-30  Matthew Delaney  <mdelaney@apple.com>
1004
1005         Reviewed by Chris Marrin.
1006
1007         Update fast/canvas tests to avoid dumping the render tree when possible
1008         https://bugs.webkit.org/show_bug.cgi?id=57493
1009
1010         * DumpRenderTree/mac/DumpRenderTree.mm: Make DRT aware of new default values for
1011           accelerated drawing and accelerated drawing for canvas
1012
1013 2011-03-30  Adam Roben  <aroben@apple.com>
1014
1015         Stop ignoring leaks in CGGradientCreateWithColorStops
1016
1017         Fixes <rdar://problem/7888547>.
1018
1019         Rubber-stamped by John Sullivan.
1020
1021         * Scripts/old-run-webkit-tests:
1022         (countAndPrintLeaks): Removed some code to ignore those leaks.
1023
1024 2011-03-30  Timur Iskhodzhanov  <timurrrr@google.com>
1025
1026         Reviewed by Alexey Proskuryakov.
1027
1028         Add some dynamic annotations to JavaScriptCore/wtf
1029         https://bugs.webkit.org/show_bug.cgi?id=53747
1030
1031         By using these annotations we can improve the precision of finding
1032         WebKit errors using dynamic analysis tools like ThreadSanitizer and Valgrind.
1033         These annotations don't affect the compiled binaries unless USE(DYNAMIC_ANNOTATIONS) is "1".
1034
1035         These files don't add new functionality, so don't need extra tests.
1036
1037         * DumpRenderTree/ForwardingHeaders/wtf/DynamicAnnotations.h: Added.
1038
1039 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
1040
1041         Reviewed by Adam Roben.
1042
1043         Share most vsprops between Release and Production builds in releaseproduction.vsprops
1044         https://bugs.webkit.org/show_bug.cgi?id=57508
1045
1046         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
1047         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops:
1048         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops:
1049         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
1050         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops:
1051         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops:
1052         * DumpRenderTree/win/ImageDiffProduction.vsprops:
1053         * DumpRenderTree/win/ImageDiffRelease.vsprops:
1054         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops:
1055         * FindSafari/FindSafariProduction.vsprops:
1056         * FindSafari/FindSafariRelease.vsprops:
1057         * FindSafari/FindSafariReleaseCairoCFLite.vsprops:
1058         * FindSafari/FindSafariReleasePGO.vsprops:
1059         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
1060         * MiniBrowser/Configurations/MiniBrowserRelease.vsprops:
1061         * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops:
1062         * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops:
1063         * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops:
1064         * WebKitAPITest/WebKitAPITestProduction.vsprops:
1065         * WebKitAPITest/WebKitAPITestRelease.vsprops:
1066         * WebKitAPITest/WebKitAPITestReleaseCairoCFLite.vsprops:
1067         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
1068         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops:
1069         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops:
1070         * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
1071         * WebKitTestRunner/win/InjectedBundleRelease.vsprops:
1072         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops:
1073         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
1074         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops:
1075         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops:
1076         * WinLauncher/WinLauncherProduction.vsprops:
1077         * WinLauncher/WinLauncherRelease.vsprops:
1078         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops:
1079         * record-memory-win/record-memory-winProduction.vsprops:
1080         * record-memory-win/record-memory-winRelease.vsprops:
1081         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops:
1082
1083 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
1084
1085         Reviewed by Adam Roben.
1086
1087         Update Windows production build logic for new production configurations
1088         https://bugs.webkit.org/show_bug.cgi?id=57494
1089
1090         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
1091         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
1092         * DumpRenderTree/win/ImageDiffProduction.vsprops:
1093         * FindSafari/FindSafariProduction.vsprops:
1094         * FindSafari/FindSafariReleasePGO.vsprops:
1095         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
1096         * WebKitAPITest/WebKitAPITestProduction.vsprops:
1097         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
1098         * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
1099         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
1100         * WinLauncher/WinLauncherProduction.vsprops:
1101         * record-memory-win/record-memory-winProduction.vsprops:
1102
1103 2011-03-30  Robert Hogan  <robert@webkit.org>
1104
1105         Reviewed by Antonio Gomes.
1106
1107         [Qt] Fix LoadHTMLStringItem::invoke() after r75966
1108         Unskip http/tests/navigation/go-back-to-error-page.html
1109
1110         Also add the location of DumpRenderTreeSupportQt.h
1111         to DRT's include paths.
1112
1113         https://bugs.webkit.org/show_bug.cgi?id=52614
1114
1115         * DumpRenderTree/qt/DumpRenderTree.pro:
1116         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1117         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1118         * DumpRenderTree/qt/GCControllerQt.cpp:
1119         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1120         (LayoutTestController::queueLoadHTMLString):
1121         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1122         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
1123         * DumpRenderTree/qt/TextInputControllerQt.cpp:
1124         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
1125         (LoadAlternateHTMLStringItem::invoke):
1126         * DumpRenderTree/qt/WorkQueueItemQt.h:
1127         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
1128         * QtTestBrowser/QtTestBrowser.pro:
1129         * QtTestBrowser/launcherwindow.h:
1130
1131 2011-03-30  Adam Barth  <abarth@webkit.org>
1132
1133         Reviewed by Adam Roben.
1134
1135         SheriffBot rollouts take too long
1136         https://bugs.webkit.org/show_bug.cgi?id=57498
1137
1138         We used to build before landing rollouts via the commit-queue to
1139         prevent further breakage, but now that our individual commit-queue
1140         machines are slower, building takes too long.  I can't remember the
1141         last time a rollout broke compile.  It seems like just landing the
1142         patch is the better trade-off.
1143
1144         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1145         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1146
1147 2011-03-30  Adam Barth  <abarth@webkit.org>
1148
1149         Remove platform/chromium-mac-snowleopard
1150         https://bugs.webkit.org/show_bug.cgi?id=57486
1151
1152         This directory no longer exists, so we can remove it from the fallback
1153         chain.
1154
1155         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1156
1157 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
1158
1159         Reviewed by Adam Roben.
1160
1161         Rename Windows configuration Release_LTCG to Production for clarity
1162         https://bugs.webkit.org/show_bug.cgi?id=57465
1163
1164         * DumpRenderTree/DumpRenderTree.sln:
1165         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1166         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops: Copied from Tools/DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops.
1167         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops: Removed.
1168         * DumpRenderTree/win/DumpRenderTree.vcproj:
1169         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops: Copied from Tools/DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops.
1170         * DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops: Removed.
1171         * DumpRenderTree/win/ImageDiff.vcproj:
1172         * DumpRenderTree/win/ImageDiffProduction.vsprops: Copied from Tools/DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops.
1173         * DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops: Removed.
1174         * FindSafari/FindSafari.vcproj:
1175         * FindSafari/FindSafariProduction.vsprops: Copied from Tools/FindSafari/FindSafariReleaseLTCG.vsprops.
1176         * FindSafari/FindSafariReleaseLTCG.vsprops: Removed.
1177         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops: Copied from Tools/MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops.
1178         * MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops: Removed.
1179         * MiniBrowser/MiniBrowser.vcproj:
1180         * Scripts/webkitdirs.pm:
1181         * TestWebKitAPI/win/TestWebKitAPI.sln:
1182         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1183         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
1184         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
1185         * WebKitAPITest/WebKitAPITest.vcproj:
1186         * WebKitAPITest/WebKitAPITestProduction.vsprops: Copied from Tools/WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops.
1187         * WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops: Removed.
1188         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
1189         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops: Copied from Tools/WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops.
1190         * WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops: Removed.
1191         * WebKitTestRunner/WebKitTestRunner.sln:
1192         * WebKitTestRunner/win/InjectedBundle.vcproj:
1193         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
1194         * WebKitTestRunner/win/InjectedBundleProduction.vsprops: Copied from Tools/WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops.
1195         * WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops: Removed.
1196         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1197         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops: Copied from Tools/WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops.
1198         * WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops: Removed.
1199         * WinLauncher/WinLauncher.vcproj:
1200         * WinLauncher/WinLauncherProduction.vsprops: Copied from Tools/WinLauncher/WinLauncherReleaseLTCG.vsprops.
1201         * WinLauncher/WinLauncherReleaseLTCG.vsprops: Removed.
1202         * record-memory-win/record-memory-win.vcproj:
1203         * record-memory-win/record-memory-winProduction.vsprops: Copied from Tools/record-memory-win/record-memory-winReleaseLTCG.vsprops.
1204         * record-memory-win/record-memory-winReleaseLTCG.vsprops: Removed.
1205
1206 2011-03-30  MORITA Hajime  <morrita@google.com>
1207
1208         Reviewed by Dimitri Glazkov.
1209
1210         [Chromium] Expose the shadow DOM to DumpRenderTree JS tests.
1211         https://bugs.webkit.org/show_bug.cgi?id=56573
1212
1213         Added LayoutTestController.shadowRoot() to Chromium DRT.
1214
1215         * DumpRenderTree/chromium/LayoutTestController.cpp:
1216         (LayoutTestController::LayoutTestController):
1217         (LayoutTestController::shadowRoot):
1218         * DumpRenderTree/chromium/LayoutTestController.h:
1219
1220 2011-03-30  Yuta Kitamura  <yutak@chromium.org>
1221
1222         Reviewed by Kent Tamura.
1223
1224         [Chromium] DumpRenderTree: Implement LayoutTestController::setPluginsEnabled
1225         https://bugs.webkit.org/show_bug.cgi?id=57430
1226
1227         * DumpRenderTree/chromium/LayoutTestController.cpp:
1228         (LayoutTestController::LayoutTestController):
1229         (LayoutTestController::setPluginsEnabled):
1230         * DumpRenderTree/chromium/LayoutTestController.h:
1231
1232 2011-03-30  Maciej Stachowiak  <mjs@apple.com>
1233
1234         Reviewed by Adam Barth.
1235
1236         make webkit-patch upload respect -d
1237         https://bugs.webkit.org/show_bug.cgi?id=57425
1238
1239         * Scripts/webkitpy/common/checkout/scm.py:
1240         * Scripts/webkitpy/tool/steps/commit.py:
1241
1242 2011-03-30  Maciej Stachowiak  <mjs@apple.com>
1243
1244         Reviewed by Adam Barth.
1245
1246         Make "webkit-patch --dry-run --verbose land" log the SVN command it's going to use
1247         https://bugs.webkit.org/show_bug.cgi?id=57429
1248
1249         * Scripts/webkitpy/common/checkout/scm.py:
1250
1251 2011-03-29  Sheriff Bot  <webkit.review.bot@gmail.com>
1252
1253         Unreviewed, rolling out r82383.
1254         http://trac.webkit.org/changeset/82383
1255         https://bugs.webkit.org/show_bug.cgi?id=57417
1256
1257         "nrwt isn't shutting down cleanly" (Requested by dpranke on
1258         #webkit).
1259
1260         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1261         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1262         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1263
1264 2011-03-29  Kent Tamura  <tkent@chromium.org>
1265
1266         Reviewed by Dimitri Glazkov.
1267
1268         Make validation message bubble testable
1269         https://bugs.webkit.org/show_bug.cgi?id=57290
1270
1271         * DumpRenderTree/mac/DumpRenderTree.mm:
1272         (createWebViewAndOffscreenWindow): Change a setting so that validation
1273           bubbles isn't hidden automatically.
1274
1275 2011-03-29  Dirk Pranke  <dpranke@chromium.org>
1276
1277         Reviewed by Ojan Vafai.
1278
1279         new-run-webkit-tests: use 'threads' on win instead of 'old-threads'
1280
1281         It's a bit unclear whether multiple threads or multiple
1282         processes will be a better model on windows. This change will
1283         test threads for now while we're still working out the bugs in
1284         multiple-processes.
1285
1286         https://bugs.webkit.org/show_bug.cgi?id=57410
1287
1288         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1289         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1290         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1291
1292 2011-03-29  David Levin  <levin@chromium.org>
1293
1294         Reviewed by Shinichiro Hamaji.
1295
1296         check-webkit-style confused by two ChangeLog entries in a row from same user
1297         https://bugs.webkit.org/show_bug.cgi?id=57250
1298
1299         * Scripts/webkitpy/style/checker.py: Add the line should be checked function to ChangeLogChecker.
1300         * Scripts/webkitpy/style/checker_unittest.py: Fix test due to that new function.
1301         * Scripts/webkitpy/style/checkers/changelog.py: Made this code aware of what lines were being checked.
1302           It basically assumes only one ChangeLog entry is being processed because that is the standard case and
1303           checking more than that would be very messey.
1304         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Add testing to catch the broken case.
1305         * Scripts/webkitpy/style/error_handlers.py: Added should_line_be_checked.
1306
1307 2011-03-29  Kent Tamura  <tkent@chromium.org>
1308
1309         Reviewed by Dimitri Glazkov.
1310
1311         [Mac] Enable interactive-validation tests on Mac DRT
1312         https://bugs.webkit.org/show_bug.cgi?id=57308
1313
1314         * DumpRenderTree/mac/DumpRenderTree.mm:
1315         (createWebViewAndOffscreenWindow): Enable the form interactive validation feature.
1316
1317 2011-03-29  Chang Shu  <cshu@webkit.org>
1318
1319         Reviewed by Kenneth Rohde Christiansen.
1320
1321         WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
1322         https://bugs.webkit.org/show_bug.cgi?id=42692
1323
1324         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1325         (WTR::InjectedBundle::beginTesting):
1326         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1327         (WTR::LayoutTestController::setAllowUniversalAccessFromFileURLs):
1328         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1329
1330 2011-03-24  Martin Robinson  <mrobinson@igalia.com>
1331
1332         Reviewed by Xan Lopez.
1333
1334         [GTK] [DRT] GtkScrolledWindow adds three pixels of padding between the WebView and the scrollbar
1335         https://bugs.webkit.org/show_bug.cgi?id=57067
1336
1337         Eliminate extra spacing between the DRT GtkScrolledWindow and the DRT WebView. This
1338         will allow WebKit1GTK+ and WebKit2GTK+ to share test results. Followup commits will
1339         update DRT and pixel results as hundreds of results will need to be updated.
1340
1341         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1342         (setDefaultsToConsistentStateValuesForTesting): Eliminate spacing on the GtkScrolledWindow
1343         by overriding the theme RC/CSS files.
1344
1345 2011-03-29  Steve Falkenburg  <sfalken@apple.com>
1346
1347         Reviewed by Adam Roben.
1348
1349         Use per-configuration vsprops in tools projects to avoid WebKitVSPropsRedirectionDir removal by MSVC IDE
1350         https://bugs.webkit.org/show_bug.cgi?id=57394
1351
1352         Visual Studio's IDE was removing instances of $(WebKitVSPropsRedirectionDir) from
1353         InheritedPropertySheet rules in our vcproj files when the vcproj was edited from within
1354         the IDE. To avoid this, add a separate vsprops file for each project configuration that
1355         contains the required inherited property sheets.
1356
1357         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1358         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebug.vsprops: Added.
1359         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugAll.vsprops: Added.
1360         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugCairoCFLite.vsprops: Added.
1361         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops: Added.
1362         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops: Added.
1363         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops: Added.
1364         * DumpRenderTree/win/DumpRenderTree.vcproj:
1365         * DumpRenderTree/win/DumpRenderTreeDebug.vsprops: Added.
1366         * DumpRenderTree/win/DumpRenderTreeDebugAll.vsprops: Added.
1367         * DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops: Added.
1368         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops: Added.
1369         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops: Added.
1370         * DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops: Added.
1371         * DumpRenderTree/win/ImageDiff.vcproj:
1372         * DumpRenderTree/win/ImageDiffDebug.vsprops: Added.
1373         * DumpRenderTree/win/ImageDiffDebugAll.vsprops: Added.
1374         * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops: Added.
1375         * DumpRenderTree/win/ImageDiffRelease.vsprops: Added.
1376         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops: Added.
1377         * DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops: Added.
1378         * FindSafari/FindSafari.vcproj:
1379         * FindSafari/FindSafariDebug.vsprops: Added.
1380         * FindSafari/FindSafariDebugAll.vsprops: Added.
1381         * FindSafari/FindSafariDebugCairoCFLite.vsprops: Added.
1382         * FindSafari/FindSafariRelease.vsprops: Added.
1383         * FindSafari/FindSafariReleaseCairoCFLite.vsprops: Added.
1384         * FindSafari/FindSafariReleaseLTCG.vsprops: Added.
1385         * FindSafari/FindSafariReleasePGO.vsprops: Added.
1386         * MiniBrowser/Configurations/MiniBrowserDebug.vsprops: Added.
1387         * MiniBrowser/Configurations/MiniBrowserDebugAll.vsprops: Added.
1388         * MiniBrowser/Configurations/MiniBrowserDebugCairoCFLite.vsprops: Added.
1389         * MiniBrowser/Configurations/MiniBrowserRelease.vsprops: Added.
1390         * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops: Added.
1391         * MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops: Added.
1392         * MiniBrowser/MiniBrowser.vcproj:
1393         * WebKitAPITest/WebKitAPITest.vcproj:
1394         * WebKitAPITest/WebKitAPITestDebug.vsprops: Added.
1395         * WebKitAPITest/WebKitAPITestDebugAll.vsprops: Added.
1396         * WebKitAPITest/WebKitAPITestDebugCairoCFLite.vsprops: Added.
1397         * WebKitAPITest/WebKitAPITestRelease.vsprops: Added.
1398         * WebKitAPITest/WebKitAPITestReleaseCairoCFLite.vsprops: Added.
1399         * WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops: Added.
1400         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
1401         * WebKitLauncherWin/WebKitLauncherWinDebug.vsprops: Added.
1402         * WebKitLauncherWin/WebKitLauncherWinDebugAll.vsprops: Added.
1403         * WebKitLauncherWin/WebKitLauncherWinDebugCairoCFLite.vsprops: Added.
1404         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops: Added.
1405         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops: Added.
1406         * WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops: Added.
1407         * WebKitTestRunner/win/InjectedBundle.vcproj:
1408         * WebKitTestRunner/win/InjectedBundleDebug.vsprops: Added.
1409         * WebKitTestRunner/win/InjectedBundleDebugAll.vsprops: Added.
1410         * WebKitTestRunner/win/InjectedBundleDebugCairoCFLite.vsprops: Added.
1411         * WebKitTestRunner/win/InjectedBundleRelease.vsprops: Added.
1412         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops: Added.
1413         * WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops: Added.
1414         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1415         * WebKitTestRunner/win/WebKitTestRunnerDebug.vsprops: Added.
1416         * WebKitTestRunner/win/WebKitTestRunnerDebugAll.vsprops: Added.
1417         * WebKitTestRunner/win/WebKitTestRunnerDebugCairoCFLite.vsprops: Added.
1418         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops: Added.
1419         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops: Added.
1420         * WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops: Added.
1421         * WinLauncher/WinLauncher.vcproj:
1422         * WinLauncher/WinLauncherDebug.vsprops: Added.
1423         * WinLauncher/WinLauncherDebugAll.vsprops: Added.
1424         * WinLauncher/WinLauncherDebugCairoCFLite.vsprops: Added.
1425         * WinLauncher/WinLauncherRelease.vsprops: Added.
1426         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops: Added.
1427         * WinLauncher/WinLauncherReleaseLTCG.vsprops: Added.
1428         * record-memory-win/record-memory-win.vcproj:
1429         * record-memory-win/record-memory-winDebug.vsprops: Added.
1430         * record-memory-win/record-memory-winDebugAll.vsprops: Added.
1431         * record-memory-win/record-memory-winDebugCairoCFLite.vsprops: Added.
1432         * record-memory-win/record-memory-winRelease.vsprops: Added.
1433         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops: Added.
1434         * record-memory-win/record-memory-winReleaseLTCG.vsprops: Added.
1435
1436 2011-03-29  Adam Barth  <abarth@webkit.org>
1437
1438         Reviewed by Darin Adler.
1439
1440         test_runner2.py can crash due to undefined variable
1441         https://bugs.webkit.org/show_bug.cgi?id=57356
1442
1443         Replace reference to undefined variable with a variable that's actually
1444         defined.  AFAICT, there's no way to test this code.
1445
1446         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
1447
1448 2011-03-29  Tony Chang  <tony@chromium.org>
1449
1450         Reviewed by Eric Seidel.
1451
1452         cleanup rebaseline-chromium-webkit-tests
1453         https://bugs.webkit.org/show_bug.cgi?id=57375
1454
1455         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1456             - Split _extract_and_add_new_baselines into 3 functions
1457             - Reduce the amount of line wrapping (the file already has lines
1458               over 80 col, so may as well try to make the file consistent)
1459             - Remove unnecessary ()s
1460
1461 2011-03-29  Brent Fulgham  <bfulgham@webkit.org>
1462
1463         Reviewed by Adam Roben.
1464
1465         Make WinCairo a core builder.
1466         https://bugs.webkit.org/show_bug.cgi?id=57373
1467
1468         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Add WinCairo.
1469         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Add WinCairo.
1470
1471 2011-03-29  Timothy Hatcher  <timothy@apple.com>
1472
1473         Update update-webkit-localizable-strings to understand that WebKit and
1474         WebKit2 strings go in WebCore.
1475
1476         Also make extract-localizable-strings optionally use an exclude file. No individual
1477         warnings are produced about unlocalized strings when there is no exclude file. This
1478         is needed for WebCore, since there are too many bare strings.
1479
1480         https://webkit.org/b/57354
1481
1482         Reviewed by Sam Weinig.
1483
1484         * Scripts/extract-localizable-strings: Support "-" to mean no exclude file.
1485         * Scripts/update-webkit-localizable-strings: Update paths to scan WebCore and WebKit2.
1486
1487 2011-03-29  Darin Adler  <darin@apple.com>
1488
1489         Reviewed by Adam Roben.
1490
1491         WebKit2 bundle page needs to offer generated file hooks
1492         https://bugs.webkit.org/show_bug.cgi?id=57279
1493
1494         (Land missing part of the original patch after r82289.)
1495
1496         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1497         (WTR::InjectedBundlePage::InjectedBundlePage): Added new callbacks.
1498
1499 2011-03-29  Tony Chang  <tony@chromium.org>
1500
1501         Reviewed by Ojan Vafai.
1502
1503         [chromium] NRWT should be able to read checksums from png comments
1504         https://bugs.webkit.org/show_bug.cgi?id=57280
1505
1506         * Scripts/read-checksum-from-png: Added. Utility script to read the checksum
1507             from a file.
1508         * Scripts/webkitpy/common/system/filesystem.py: Add open_binary_file_for_reading
1509         * Scripts/webkitpy/common/system/filesystem_mock.py:
1510         * Scripts/webkitpy/layout_tests/port/base.py: When loading a checksum,
1511             if the -checksum.txt file doesn't exist, try looking in the png.
1512         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1513         * Scripts/webkitpy/layout_tests/port/test.py:
1514         * Scripts/webkitpy/layout_tests/read_checksum_from_png.py: Added. Scan the first
1515             2k for a png comment with the checksum
1516         * Scripts/webkitpy/layout_tests/read_checksum_from_png_unittest.py: Added.
1517
1518 2011-03-29  Philippe Normand  <pnormand@igalia.com>
1519
1520         Rubber-stamped by Gustavo Noronha Silva.
1521
1522         [GTK] http/tests/uri/username-with-no-hostname.html fails
1523         https://bugs.webkit.org/show_bug.cgi?id=57325
1524
1525         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1526         (willSendRequestCallback): URI host value check done case-insensitively.
1527
1528 2011-03-29  Philippe Normand  <pnormand@igalia.com>
1529
1530         Reviewed by Martin Robinson.
1531
1532         [GTK] http/tests/uri/username-with-no-hostname.html fails
1533         https://bugs.webkit.org/show_bug.cgi?id=57325
1534
1535         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1536         (willSendRequestCallback): Check URI before submitting the request
1537         to WebCore.
1538
1539 2011-03-29  Noel Gordon  <noel.gordon@gmail.com>
1540
1541         Reviewed by Ojan Vafai.
1542
1543         [chromium] DRT EventSender: remove identity from dragTargetDragEnter() calls
1544         https://bugs.webkit.org/show_bug.cgi?id=57303
1545
1546         * DumpRenderTree/chromium/EventSender.cpp:
1547         (EventSender::doDragDrop):
1548         (EventSender::beginDragWithFiles):
1549
1550 2011-03-29  Zoltan Horvath  <zoltan@webkit.org>
1551
1552         Reviewed by Andreas Kling.
1553
1554         [Qt] Add -print-loaded-urls option to Qt's MiniBrowser and to QtTestBrowser
1555         https://bugs.webkit.org/show_bug.cgi?id=57314
1556
1557         Provide possibility to print loaded urls to the standard output.
1558
1559         * MiniBrowser/qt/BrowserWindow.cpp:
1560         (BrowserWindow::BrowserWindow):
1561         (BrowserWindow::printURL):
1562         * MiniBrowser/qt/BrowserWindow.h:
1563         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1564         (MiniBrowserApplication::handleUserOptions):
1565         * MiniBrowser/qt/MiniBrowserApplication.h:
1566         (WindowOptions::WindowOptions):
1567         * QtTestBrowser/launcherwindow.cpp:
1568         (LauncherWindow::initializeView):
1569         (LauncherWindow::printURL):
1570         (LauncherWindow::cloneWindow):
1571         * QtTestBrowser/launcherwindow.h:
1572         (WindowOptions::WindowOptions):
1573         * QtTestBrowser/main.cpp:
1574         (LauncherApplication::handleUserOptions):
1575
1576 2011-03-29  Gabor Loki  <loki@webkit.org>
1577
1578         Rubber-stamped by Csaba Osztrogonác.
1579
1580         [Qt] Teach build-jsc how to build JavaScriptCore on Qt
1581         https://bugs.webkit.org/show_bug.cgi?id=56918
1582
1583         * Scripts/build-jsc: Remove duplicated --qt options to avoid passing them to qmake.
1584
1585 2011-03-28  Gabor Loki  <loki@webkit.org>
1586
1587         Reviewed by Csaba Osztrogonác.
1588
1589         [Qt] Teach build-jsc how to build JavaScriptCore on Qt
1590         https://bugs.webkit.org/show_bug.cgi?id=56918
1591
1592         * Scripts/build-jsc:
1593         * Scripts/webkitdirs.pm:
1594
1595 2011-03-28  Andrew Foster  <andrewf@chromium.org>
1596
1597         Reviewed by Ojan Vafai.
1598
1599         webkit-patch should be more intelligent about whether a bug applies to a patch
1600         Create a new function, parse_bug_id_from_changelog() which determines
1601         that a bug is related to a patch by parsing the output generated from
1602         prepare-ChangeLog, rather than arbitrarily matching a URL to a bug in
1603         the description of a patch.
1604         https://bugs.webkit.org/show_bug.cgi?id=56989
1605
1606         * Scripts/webkitpy/common/checkout/api.py:
1607         * Scripts/webkitpy/common/checkout/changelog.py:
1608         * Scripts/webkitpy/common/net/bugzilla/__init__.py:
1609         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1610         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1611         * Scripts/webkitpy/style/checkers/changelog.py:
1612         * Scripts/webkitpy/tool/commands/upload.py:
1613
1614 2011-03-28  Maciej Stachowiak  <mjs@apple.com>
1615
1616         Revert accidentally commited change.
1617
1618         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1619         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
1620
1621 2011-03-28  Tony Chang  <tony@chromium.org>
1622
1623         Reviewed by Adam Barth.
1624
1625         [chromium] have DRT write the png checksum into a png comment
1626         https://bugs.webkit.org/show_bug.cgi?id=57255
1627
1628         * DumpRenderTree/chromium/TestShell.cpp:
1629         (TestShell::dumpImage):
1630
1631 2011-03-28  Adele Peterson  <adele@apple.com>
1632
1633         Removing Qt stub, since it doesn't use the same header as the others.
1634
1635         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1636
1637 2011-03-28  Adele Peterson  <adele@apple.com>
1638
1639         Added a few more stubs.
1640
1641         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1642         (LayoutTestController::hasGrammarMarker):
1643         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1644         (LayoutTestController::hasGrammarMarker):
1645         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1646         (LayoutTestController::hasGrammarMarker):
1647
1648 2011-03-28  Adele Peterson  <adele@apple.com>
1649
1650         Build fix.
1651
1652         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1653         (LayoutTestController::hasGrammarMarker):
1654
1655 2011-03-28  Adele Peterson  <adele@apple.com>
1656
1657         Reviewed by Eric Seidel.
1658
1659         Testing support for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
1660         https://bugs.webkit.org/show_bug.cgi?id=57173
1661
1662         * DumpRenderTree/LayoutTestController.cpp:
1663         (hasGrammarMarkerCallback): Added.
1664         (LayoutTestController::staticFunctions): Added case for hasGrammarMarker.
1665         * DumpRenderTree/LayoutTestController.h:
1666         * DumpRenderTree/mac/DumpRenderTree.mm: (createWebViewAndOffscreenWindow): Call setGrammarCheckingEnabled.
1667         * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::hasGrammarMarker): Added. Call new hasGrammarMarker method.
1668
1669 2011-03-28  Csaba Osztrogonác  <ossy@webkit.org>
1670
1671         Reviewed by Benjamin Poulain.
1672
1673         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
1674         https://bugs.webkit.org/show_bug.cgi?id=57087
1675
1676         Trivial typo fix after r82082.
1677
1678         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1679         (WTR::activateFonts):
1680
1681 2011-03-28  Alexis Menard  <alexis.menard@openbossa.org>
1682
1683         Reviewed by Andreas Kling.
1684
1685         Add myself to the committers list.
1686
1687         * Scripts/webkitpy/common/config/committers.py:
1688
1689 2011-03-28  Simon Fraser  <simon.fraser@apple.com>
1690
1691         Reviewed by Sam Weinig.
1692
1693         WebKit2 unfortunately uses code from WebKit, so MiniBrowser needs
1694         to link against WebKit.framework for now.
1695
1696         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1697
1698 2011-03-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
1699
1700         Reviewed by Andreas Kling.
1701
1702         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
1703         https://bugs.webkit.org/show_bug.cgi?id=57087
1704
1705         Disable QT_ASCII_CAST_WARNINGS for applications.
1706
1707         * DumpRenderTree/qt/DumpRenderTree.pro:
1708         * DumpRenderTree/qt/ImageDiff.pro:
1709         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1710         * MiniBrowser/qt/MiniBrowser.pro:
1711         * QtTestBrowser/QtTestBrowser.pro:
1712         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1713
1714 2011-03-28  Andreas Kling  <kling@webkit.org>
1715
1716         Reviewed by Kenneth Rohde Christiansen.
1717
1718         [Qt] QtTestBrowser doesn't reset its window title when opening about:blank
1719         https://bugs.webkit.org/show_bug.cgi?id=57224
1720
1721         * QtTestBrowser/mainwindow.cpp:
1722         (MainWindow::buildUI):
1723         (MainWindow::onTitleChanged):
1724         * QtTestBrowser/mainwindow.h:
1725
1726 2011-03-27  Jer Noble  <jer.noble@apple.com>
1727
1728         Reviewed by Maciej Stachowiak.
1729
1730         Full Screen: disable keyboard access by default
1731         https://bugs.webkit.org/show_bug.cgi?id=56684
1732
1733         Accept the withKeyboard parameter to supportsFullScreenForElement.
1734
1735         * DumpRenderTree/mac/UIDelegate.mm:
1736         (-[UIDelegate webView:supportsFullScreenForElement:withKeyboard:]):
1737
1738 2011-03-27  Patrick Gansterer  <paroga@webkit.org>
1739
1740         Reviewed by David Levin.
1741
1742         check-webkit-style should check ChangeLog for a valid bug number
1743         https://bugs.webkit.org/show_bug.cgi?id=57184
1744
1745         * Scripts/webkitpy/style/checker.py:
1746         * Scripts/webkitpy/style/checker_unittest.py:
1747         * Scripts/webkitpy/style/checkers/changelog.py: Added.
1748         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Added.
1749
1750 2011-03-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
1751
1752         Reviewed by Andreas Kling.
1753
1754         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
1755         https://bugs.webkit.org/show_bug.cgi?id=57087
1756
1757         Use explicit conversion for string to avoid depending on the default codec
1758         installed by the user code.
1759
1760         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1761         (WTR::activateFonts):
1762
1763 2011-03-26  Maciej Stachowiak  <mjs@apple.com>
1764
1765         Revert inadvertantly committed changes.
1766
1767         * Scripts/old-run-webkit-tests:
1768         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1769
1770 2011-03-26  Andreas Kling  <kling@webkit.org>
1771
1772         Reviewed by Kenneth Rohde Christiansen.
1773
1774         [Qt] Show page icons (favicons) in QtTestBrowser location bar.
1775         https://bugs.webkit.org/show_bug.cgi?id=57162
1776
1777         * QtTestBrowser/QtTestBrowser.qrc:
1778         * QtTestBrowser/favicon.png: Added.
1779         * QtTestBrowser/locationedit.cpp:
1780         (defaultPageIcon):
1781         (LocationEdit::LocationEdit):
1782         (LocationEdit::setPageIcon):
1783         (LocationEdit::resizeEvent):
1784         (LocationEdit::updateInternalGeometry):
1785         * QtTestBrowser/locationedit.h:
1786         * QtTestBrowser/mainwindow.cpp:
1787         (MainWindow::buildUI):
1788         (MainWindow::onIconChanged):
1789         (MainWindow::onLoadStarted):
1790         * QtTestBrowser/mainwindow.h:
1791
1792 2011-03-23  Martin Robinson  <mrobinson@igalia.com>
1793
1794         Reviewed by Xan Lopez.
1795
1796         [GTK] Force DumpRenderTree to use 96 DPI
1797         https://bugs.webkit.org/show_bug.cgi?id=56866
1798
1799         Make sure that GTK+ is set to use 96 DPI when running tests. This ensures
1800         broader compatibility with WebKit2 and makes setting font sizes more straightforward.
1801
1802         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1803         (initializeGtkFontSettings): Set the screen resolution and GTK+ xft property to 96 DPI.
1804         (resetDefaultsToConsistentValues):Remove the call which repeatedly set the GDK screen resolution.
1805         (setDefaultsToConsistentStateValuesForTesting): Update the font sizes to reflect the new DPI.
1806
1807 2011-03-25  Andy Estes  <aestes@apple.com>
1808
1809         Reviewed by Adele Peterson.
1810
1811         REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
1812         https://bugs.webkit.org/show_bug.cgi?id=49016
1813
1814         TestNetscapePlugIn needs to register support for an image MIME type so
1815         we can test that the embed tag prefers plug-ins to render image MIME
1816         types.
1817
1818         * DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Register image/png.
1819         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1820         (NP_GetMIMEDescription): Ditto.
1821         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Ditto.
1822
1823 2011-03-25  Jessie Berlin  <jberlin@apple.com>
1824
1825         Reviewed by Sam Weinig.
1826
1827         WebKit2: Need to be able to set and get the Cookie Storage Policy.
1828         https://bugs.webkit.org/show_bug.cgi?id=50780
1829
1830         Add a test for getting and setting the HTTP Cookie Accept Policy in WebKit2.
1831
1832         The test is named "CookieManager" so that we can eventually exercise more of the
1833         CookieManager functionality in the test.
1834
1835         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp: Added.
1836         (TestWebKitAPI::didGetTestHTTPCookieAcceptPolicy):
1837         Assert that the policy returned is equal to the policy set in
1838         didGetUserHTTPCookieAcceptPolicy, and then restore the user's policy.
1839         (TestWebKitAPI::didGetUserHTTPCookieAcceptPolicy):
1840         Set the policy to something different than the user's policy and get the policy again.
1841         (TestWebKitAPI::didFinishLoadForFrame):
1842         Get the user's policy so that it can be restored at the end of the test.
1843         (TestWebKitAPI::TEST):
1844         Load about:blank so that the Web Process gets instatiated (needed to get the
1845         CookieManager).
1846
1847         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1848         Add CookieManager.cpp.
1849
1850 2011-03-24  Kevin Ollivier  <kevino@theolliviers.com>
1851
1852         [wx] Fix the build so that gcc-4.1 and up can be used to build on SnowLeopard.
1853
1854         * wx/build/settings.py:
1855
1856 2011-03-24  Ilya Sherman  <isherman@chromium.org>
1857
1858         Reviewed by Adam Roben.
1859
1860         Implement layoutTestController.setAutoFilled in DRT on Windows
1861         https://bugs.webkit.org/show_bug.cgi?id=56828
1862
1863         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1864         (LayoutTestController::setAutofilled): Implemented.
1865
1866 2011-03-24  Brent Fulgham  <bfulgham@webkit.org>
1867
1868         Unreviewed build correction.
1869
1870         Correct vsprops file for Debug variant of the CFLite build.
1871         Disable a CFNETWORK-specific test when building for CFLite.
1872
1873         * TestWebKitAPI/Configurations/TestWebKitAPIDebugCairoCFLite.vsprops:
1874         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1875
1876 2011-03-24  Dirk Pranke  <dpranke@chromium.org>
1877
1878         Reviewed by Adam Barth.
1879
1880         fix regressions introduced in 81908 - there were a couple of
1881         code paths that only fired under python 2.5 that I missed.
1882
1883         Also change a couple of 'python' references to sys.executable
1884         in order to handle runing test-webkitpy with a binary other than
1885         something called 'python'.
1886
1887         https://bugs.webkit.org/show_bug.cgi?id=57063
1888
1889         * Scripts/webkitpy/layout_tests/port/mac.py:
1890         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1891         * Scripts/webkitpy/test/cat.py:
1892         * Scripts/webkitpy/test/echo.py:
1893
1894 2011-03-24  Brent Fulgham  <bfulgham@webkit.org>
1895
1896         Unreviewed build correction.
1897
1898         Add a stub implementation of the TestInvocation dumping logic.
1899         Update project files to reflect new file.
1900
1901         * WebKitTestRunner/cairo: Added.
1902         * WebKitTestRunner/cairo/TestInvocationCairo.cpp: Added.
1903         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1904         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1905
1906 2011-03-24  Dirk Pranke  <dpranke@chromium.org>
1907
1908         Reviewed by Tony Chang.
1909
1910         new-run-webkit-tests: clean up worker model defaults. This
1911         changes the default behavior to 'threads' instead of
1912         'old-threads', and clarifies that chromium-win-* and
1913         chromium-mac-leopard are exceptions.
1914
1915         https://bugs.webkit.org/show_bug.cgi?id=56971
1916
1917         * Scripts/webkitpy/layout_tests/port/base.py:
1918         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1919         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1920         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1921         * Scripts/webkitpy/layout_tests/port/test.py:
1922         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1923
1924 2011-03-23  Leandro Gracia Gil  <leandrogracia@chromium.org>
1925
1926         Reviewed by Darin Adler.
1927
1928         Media Stream API: fix the order of the options in build-webkit.
1929         https://bugs.webkit.org/show_bug.cgi?id=56949
1930
1931         Fix the order of the options in build-webkit.
1932
1933         * Scripts/build-webkit:
1934
1935 2011-03-23  Adam Klein  <adamk@chromium.org>
1936
1937         Reviewed by Mihai Parparita.
1938
1939         Add an option to new-run-webkit-httpd to allow overriding the location of LayoutTests directory
1940         https://bugs.webkit.org/show_bug.cgi?id=56884
1941
1942         This option will be utilized by Chromium's ui_tests to allow
1943         referencing js-test-resources from a layout test over HTTP.
1944
1945         * Scripts/new-run-webkit-httpd:
1946         Added --layout_tests_dir option.
1947         * Scripts/webkitpy/layout_tests/port/http_server.py:
1948         Plumbed through as layout_tests_dir param.
1949
1950 2011-03-23  Dirk Pranke  <dpranke@chromium.org>
1951
1952         Reviewed by Mihai Parparita.
1953
1954         new-run-webkit-tests: run tests in ascending alphabetical order per
1955         dir. This is a second attempt at the fix; the first attempt, in 
1956         r81597, broke the behavior on the old-inline and old-threads
1957         worker models.
1958
1959         https://bugs.webkit.org/show_bug.cgi?id=56760
1960
1961         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1962         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1963         * Scripts/webkitpy/layout_tests/port/test.py:
1964         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1965
1966 2011-03-23  Mario Sanchez Prada  <msanchez@igalia.com>
1967
1968         Reviewed by Martin Robinson.
1969
1970         [GTK] GTK's DRT to ouput detail's string for the 'property-change' signal
1971         https://bugs.webkit.org/show_bug.cgi?id=56953
1972
1973         Print the string for the detail of 'property-change' signal.
1974
1975         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
1976         (axObjectEventListener): Print the detail string.
1977
1978 2011-03-23  Yury Semikhatsky  <yurys@chromium.org>
1979
1980         Reviewed by Pavel Feldman.
1981
1982         [V8] Web Inspector: compile DebuggerScript.js into DebuggerScriptSource.h
1983         https://bugs.webkit.org/show_bug.cgi?id=56843
1984
1985         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1986         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1987
1988 2011-03-22  Eric Seidel  <eric@webkit.org>
1989
1990         Reviewed by Adam Barth.
1991
1992         Teach update-webkit about gyp
1993         https://bugs.webkit.org/show_bug.cgi?id=56881
1994
1995         This makes it possible for someone who builds from Xcode
1996         to just run update-webkit --gyp and have the project files
1997         generated after update automatically.
1998
1999         I also added a stand-alone "generate-project-files" script
2000         wrapping Source/gyp/configure.  This makes running gyp simpler
2001         since most people will not have gyp or Source/gyp in their path.
2002
2003         * Scripts/build-webkit:
2004         * Scripts/generate-project-files: Added.
2005         * Scripts/update-webkit:
2006
2007 2011-03-22  Anton D'Auria  <adauria@apple.com>
2008
2009         Reviewed by Alexey Proskuryakov.
2010
2011         Add +[WebApplicationCache getOriginsWithCache]
2012         https://bugs.webkit.org/show_bug.cgi?id=56722
2013
2014         * DumpRenderTree/LayoutTestController.cpp:
2015         (originsWithApplicationCacheCallback):
2016         (LayoutTestController::staticFunctions):
2017         * DumpRenderTree/LayoutTestController.h:
2018         * DumpRenderTree/chromium/LayoutTestController.cpp: Added stub.
2019         (LayoutTestController::originsWithApplicationCache):
2020         * DumpRenderTree/chromium/LayoutTestController.h:
2021         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added stub.
2022         (LayoutTestController::originsWithApplicationCache):
2023         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Pass array of origin's database identifiers.
2024         (originsArrayToJS): Helper function for converting array of WebSecurityOrigins to a JS array of origin identifiers.
2025         (LayoutTestController::originsWithApplicationCache):
2026         (LayoutTestController::originsWithLocalStorage):
2027         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added stub.
2028         (LayoutTestController::originsWithApplicationCache):
2029         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2030         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Added stub.
2031         (LayoutTestController::originsWithApplicationCache):
2032         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Added stub.
2033         (LayoutTestController::originsWithApplicationCache):
2034
2035 2011-03-22  Eric Seidel  <eric@webkit.org>
2036
2037         Reviewed by Adam Barth.
2038
2039         Add support to build-webkit for building with gyp-generated project files
2040         https://bugs.webkit.org/show_bug.cgi?id=56877
2041
2042         build-webkit is a cesspool.  This change just hacks in --gyp support for Mac.
2043         Eventually we'll want to support gyp-generated projects in a more general manner.
2044
2045         * Scripts/build-webkit:
2046
2047 2011-03-22  David Kilzer  <ddkilzer@apple.com>
2048
2049         <http://webkit.org/b/56781> Add --dsym switch to enable dsym generation when building with Xcode
2050
2051         Reviewed by Joseph Pecoraro.
2052
2053         * Scripts/build-webkit: Updated usage statement to include
2054         --dsym.
2055         * Scripts/webkitdirs.pm: Added $generateDsym variable.
2056         (generateDsym): Added. Call determineGenerateDsym() and
2057         return $generateDsym.
2058         (determineGenerateDsym): Added.  Parse @ARGV for --dsym and set
2059         $generateDsym.
2060         (argumentsForXcode): Added.  Returns additional arguments for
2061         xcodebuild based on command-line switches.
2062         (XcodeOptions): Updated to include argumentsForXcode() in the
2063         array returned.
2064
2065 2011-03-22  Adam Roben  <aroben@apple.com>
2066
2067         Make Leopard Debug bots and Windows XP Debug (Tests) core builders
2068
2069         These bots are consistently green again.
2070
2071         Fixes <http://webkit.org/b/56830> Leopard Debug bots and Windows XP Debug (Tests) should be
2072         core builders
2073
2074         Rubber-stamped by Antti Koivisto.
2075
2076         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2077         (BuildBot.__init__): Loosened the regexps for Leopard and Windows.
2078
2079         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2080         (BuildBotTest.test_builder_name_regexps): Updated expectations.
2081
2082 2011-03-21  Sheriff Bot  <webkit.review.bot@gmail.com>
2083
2084         Unreviewed, rolling out r81597.
2085         http://trac.webkit.org/changeset/81597
2086         https://bugs.webkit.org/show_bug.cgi?id=56801
2087
2088         Change results in lots of unexpected flaky on the dashboard.
2089         (Requested by pfeldman on #webkit).
2090
2091         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2092         * Scripts/webkitpy/layout_tests/port/test.py:
2093         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2094
2095 2011-03-21  Sam Weinig  <sam@webkit.org>
2096
2097         Fix failing tests on the WebKit2 bots.
2098
2099         * WebKitTestRunner/TestController.cpp:
2100         (WTR::TestController::resetStateToConsistentValues):
2101
2102 2011-03-21  Daniel Sievers  <sievers@google.com>
2103
2104         Reviewed by Simon Fraser.
2105
2106         [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
2107         https://bugs.webkit.org/show_bug.cgi?id=56139
2108
2109         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2110         (main):
2111         * DumpRenderTree/chromium/LayoutTestController.cpp:
2112         (LayoutTestController::LayoutTestController):
2113         (LayoutTestController::layerTreeAsText):
2114         * DumpRenderTree/chromium/LayoutTestController.h:
2115         (LayoutTestController::setShowDebugLayerTree):
2116         * DumpRenderTree/chromium/TestShell.cpp:
2117         (TestShell::runFileTest):
2118         (TestShell::dump):
2119         * DumpRenderTree/chromium/TestShell.h:
2120         (TestParams::TestParams):
2121
2122 2011-03-21  Adam Roben  <aroben@apple.com>
2123
2124         Try again to get buildbot to show run-javascriptcore-tests's actual.html as an HTML file
2125
2126         Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
2127         output as plain text
2128
2129         Reviewed by David Kilzer.
2130
2131         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2132         (RunJavaScriptCoreTests): List actual.html as one of our log files so it will get uploaded
2133         to the master.
2134         (RunJavaScriptCoreTests.commandComplete): Reading the actual.html file here won't work,
2135         since we're running on the build master, not the slave. Instead, turn the raw source of
2136         actual.html which the build slave uploaded into an HTML log.
2137
2138 2011-03-21  Dirk Pranke  <dpranke@chromium.org>
2139
2140         Reviewed by Mihai Parparita.
2141
2142         new-run-webkit-tests: run tests in ascending alphabetical order per dir
2143         https://bugs.webkit.org/show_bug.cgi?id=56760
2144
2145         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2146         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2147         * Scripts/webkitpy/layout_tests/port/test.py:
2148
2149 2011-03-21  Leandro Gracia Gil  <leandrogracia@chromium.org>
2150
2151         Reviewed by Steve Block.
2152
2153         Media Stream API patch 0: adding compilation guards.
2154         https://bugs.webkit.org/show_bug.cgi?id=56458
2155
2156         Adding options to enable the media stream API feature in Chromium.
2157
2158         * Scripts/build-webkit:
2159
2160 2011-03-21  Qi Zhang  <qi.2.zhang@nokia.com>
2161
2162         Reviewed by Laszlo Gombos.
2163
2164         [Qt] Add a command line option to capture stdout and stderr for DumpRenderTree
2165         https://bugs.webkit.org/show_bug.cgi?id=56323
2166
2167         Using freopen to redirect STDOUT and STDERR when DumpRenderTree command line provide 
2168         "--stdout" or "--stderr" option.
2169
2170         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2171         (WebCore::DumpRenderTree::~DumpRenderTree):
2172         (WebCore::DumpRenderTree::processArgsLine):
2173         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
2174         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2175         (WebCore::DumpRenderTree::setRedirectOutputFileName):
2176         (WebCore::DumpRenderTree::setRedirectErrorFileName):
2177         * DumpRenderTree/qt/main.cpp:
2178         (isOption):
2179         (takeOptionValue):
2180         (printUsage):
2181         (main):
2182
2183 2011-03-21  Adam Roben  <aroben@apple.com>
2184
2185         Fix exceptions on the buildbot due to my last change
2186
2187         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2188         (RunJavaScriptCoreTests.commandComplete): Catch exceptions due to actual.html not existing.
2189
2190 2011-03-21  Adam Roben  <aroben@apple.com>
2191
2192         Teach buildbot to treat run-javascriptcore-tests's actual.html as an HTML file
2193
2194         Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
2195         output as plain text
2196
2197         Reviewed by Darin Adler.
2198
2199         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2200         (RunJavaScriptCoreTests): Removed the logfiles variable, which can only handle plaintext
2201         logs.
2202         (RunJavaScriptCoreTests.commandComplete): Use the addHTMLLog method to upload actual.html to
2203         the build master. This will correctly treat it as HTML.
2204
2205 2011-03-20  Bill Budge  <bbudge@chromium.org>
2206
2207         Reviewed by Adam Barth.
2208
2209         Rename ThreadSafeShared to ThreadSafeRefCounted
2210         https://bugs.webkit.org/show_bug.cgi?id=56714
2211
2212         No new tests. Exposes no new functionality.
2213
2214         * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeRefCounted.h: Copied from DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h.
2215         * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h: Removed.
2216         * Scripts/do-webcore-rename:
2217
2218 2011-03-19  Anton D'Auria  <adauria@apple.com>
2219
2220         Reviewed by Dan Bernstein.
2221
2222         Add stub to LayoutTestControllerGtk.cpp to fix GTK build
2223         https://bugs.webkit.org/show_bug.cgi?id=56719
2224
2225         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Adding stub.
2226         (LayoutTestController::clearApplicationCacheForOrigin):
2227
2228 2011-03-19  Anton D'Auria  <adauria@apple.com>
2229
2230         Reviewed by Alexey Proskuryakov.
2231
2232         ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
2233         https://bugs.webkit.org/show_bug.cgi?id=56415
2234
2235         * DumpRenderTree/LayoutTestController.cpp:
2236         (clearApplicationCacheForOriginCallback):
2237         (LayoutTestController::staticFunctions):
2238         * DumpRenderTree/LayoutTestController.h:
2239         * DumpRenderTree/chromium/LayoutTestController.cpp: Adding stubs.
2240         (LayoutTestController::LayoutTestController):
2241         (LayoutTestController::clearAllApplicationCaches):
2242         (LayoutTestController::clearApplicationCacheForOrigin): 
2243         * DumpRenderTree/chromium/LayoutTestController.h:
2244         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Adding stub.
2245         (LayoutTestController::clearApplicationCacheForOrigin):
2246         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Adding stub.
2247         (LayoutTestController::clearApplicationCacheForOrigin):
2248         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2249         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Adding stub.
2250         (LayoutTestController::clearApplicationCacheForOrigin):
2251         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Adding stub.
2252         (LayoutTestController::clearApplicationCacheForOrigin):
2253
2254 2011-03-18  Dan Bernstein  <mitz@apple.com>
2255
2256         Revised build fix for r81135.
2257
2258         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
2259         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2260
2261 2011-03-18  Adam Roben  <aroben@apple.com>
2262
2263         Windows build fix
2264
2265         * WebKitTestRunner/config.h: Add a missing #endif.
2266
2267 2011-03-18  Andreas Kling  <kling@webkit.org>
2268
2269         Unbreak Qt build after r81494.
2270
2271         * WebKitTestRunner/qt/TestInvocationQt.cpp:
2272         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2273
2274 2011-03-18  Sam Weinig  <sam@webkit.org>
2275
2276         Fix windows build. This was really Adam Roben's fault. I swear!
2277
2278         * WebKitTestRunner/config.h:
2279
2280 2011-03-18  Sam Weinig  <sam@webkit.org>
2281
2282         Reviewed by Adam Roben.
2283
2284         Pixel tests don't work in WebKitTestRunner on Windows
2285         https://bugs.webkit.org/show_bug.cgi?id=56630
2286
2287         Cross-platformize (Mac and Windows CG) the pixel dumping code in WebKitTestRunner to use WebKit2
2288         built-in snapshotting instead of using the window server on the Mac.
2289
2290         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2291         (WTR::InjectedBundle::InjectedBundle):
2292         (WTR::InjectedBundle::didReceiveMessage):
2293         (WTR::InjectedBundle::beginTesting):
2294         (WTR::InjectedBundle::done):
2295         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2296         (WTR::InjectedBundle::setPixelResult):
2297         (WTR::InjectedBundle::shouldDumpPixels):
2298         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2299         (WTR::InjectedBundlePage::dump):
2300         Take the snapshot in the bundle and send it to the UIProcess for dumping.
2301
2302         * WebKitTestRunner/TestInvocation.cpp:
2303         (WTR::TestInvocation::invoke):
2304         (WTR::TestInvocation::dump):
2305         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2306         * WebKitTestRunner/TestInvocation.h:
2307         * WebKitTestRunner/cg: Added.
2308         * WebKitTestRunner/cg/TestInvocationCG.cpp: Copied from WebKitTestRunner/mac/TestInvocationMac.mm.
2309         (WTR::createCGContextFromImage):
2310         (WTR::computeMD5HashStringForContext):
2311         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2312         * WebKitTestRunner/mac/TestInvocationMac.mm: Removed.
2313         Making pixel dumping code shared for CG ports. Also use the WTF/MD5 instead of platform specific code.
2314
2315         * WebKitTestRunner/win/TestInvocationWin.cpp:
2316         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2317         Keep stub for Cairo build.
2318
2319         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Added.
2320         Add CG configuration.
2321
2322         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2323         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2324         Add new files.
2325
2326 2011-03-18  Adam Roben  <aroben@apple.com>
2327
2328         Don't allow Leaks Viewer's vertical scrollbar to cover up long function names
2329
2330         Rubber-stamped by Simon Fraser.
2331
2332         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
2333         (.data-grid .data-container): Use overflow-y:auto instead of the Inspector's default
2334         overflow-y:overlay so that the scrollbar doesn't overlay the content.
2335
2336 2011-03-18  Adam Roben  <aroben@apple.com>
2337
2338         Don't ellipsize long or indented function names in Leaks Viewer
2339
2340         Fixes <http://webkit.org/b/56037> Leaks viewer needs horizontal
2341         scrollbar
2342
2343         Reviewed by Simon Fraser.
2344
2345         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
2346         (.data-grid .data-container):
2347         (.data-grid td > div, .data-grid th > div):
2348         Allow the contents to extend to the right.
2349
2350 2011-03-18  Adam Roben  <aroben@apple.com>
2351
2352         Fix some leaks in DRT seen on the leaks bot
2353
2354         Fixes <http://webkit.org/b/56638> addURLToRedirectCallback and
2355         setWillSendRequestClearHeaderCallback in DRT are leaky
2356
2357         Reviewed by Alexey Proskuryakov.
2358
2359         * DumpRenderTree/ForwardingHeaders/wtf/OwnArrayPtr.h: Added.
2360
2361         * DumpRenderTree/LayoutTestController.cpp:
2362         (addURLToRedirectCallback):
2363         (setWillSendRequestClearHeaderCallback):
2364         Use OwnArrayPtr to cause the strings to be deleted.
2365
2366 2011-03-18  Adam Roben  <aroben@apple.com>
2367
2368         Fix a NSURLCredential leak seen on the leaks bot
2369
2370         Fixes <http://webkit.org/b/56637> -[SynchronousLoader
2371         connection:didReceiveAuthenticationChallenge:] is leaky
2372
2373         Reviewed by John Sullivan.
2374
2375         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2376         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]): Use a RetainPtr to
2377         cause the NSURLCredential to be released.
2378
2379 2011-03-18  John Knottenbelt  <jknotten@chromium.org>
2380
2381         Unreviewed.
2382
2383         Remove unnecessary brackets around my email address.
2384
2385         * Scripts/webkitpy/common/config/committers.py:
2386
2387 2011-03-18  Adam Roben  <aroben@apple.com>
2388         
2389         Remove some files I accidentally added in r81454
2390
2391         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Removed.
2392         * WebKitTestRunner/cg/TestInvocationCG.cpp: Removed.
2393
2394 2011-03-18  Adam Roben  <aroben@apple.com>
2395
2396         Ignore an NSNumberFormatter leak on SnowLeopard
2397
2398         * Scripts/old-run-webkit-tests:
2399         (countAndPrintLeaks): Ignore leaks in -[NSNumberFormatter
2400         getObjectValue:forString:errorDescription:].
2401
2402 2011-03-18  Adam Roben  <aroben@apple.com>
2403
2404         Fix a leak beneath LayoutTestController::authenticateSession seen on the bots
2405
2406         Rubber-stamped by Mark Rowe.
2407
2408         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2409         (LayoutTestController::authenticateSession): Use a RetainPtr to cause the NSURLRequest to be
2410         released.
2411
2412 2011-03-17  Adam Roben  <aroben@apple.com>
2413
2414         Address a review comment I missed in r81445
2415
2416         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
2417         (LeaksParserWorker.prototype._parseLeaks): Anchor the RegExp used to find the number of
2418         leaked bytes to speed up searching on long lines.
2419
2420 2011-03-17  Adam Roben  <aroben@apple.com>
2421
2422         Mark leaky builds orange, even if all regression tests passed
2423
2424         Fixes <http://webkit.org/b/56609> SnowLeopard Intel Leaks bot appears green on
2425         build.webkit.org when all tests pass even though there are still leaks
2426
2427         Reviewed by Dan Bernstein.
2428
2429         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2430         (RunWebKitLeakTests): Set the warnOnWarnings property to True so that the entire build will
2431         be marked orange if this build step generates warnings.
2432
2433 2011-03-17  Adam Roben  <aroben@apple.com>
2434
2435         Allow values in Leaks Viewer to be shown as percentages
2436
2437         Double-clicking on a column will toggle between showing percentages and showing real values.
2438
2439         Fixes <http://webkit.org/b/56628> Would like to view values as percentages of the total
2440         number of leaked bytes in Leaks Viewer
2441
2442         Reviewed by Joe Pecoraro.
2443
2444         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
2445         (LeaksParserWorker.prototype._incorporateLeaks): Calculate the (never-shown) top-level
2446         node's totalTime, which is used in calculating percentages.
2447
2448         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
2449         (monkeyPatchInspectorObjects): Only format values as bytes if we aren't supposed to be
2450         showing them as percentages.
2451
2452 2011-03-17  Adam Roben  <aroben@apple.com>
2453
2454         Show the number of leaked bytes, not just leaked allocations, in Leaks Viewer
2455
2456         The Self and Total columns now report the number of leaked bytes. The new Calls column shows
2457         the number of leaked allocations. And the new Average column shows the average number of
2458         leaked bytes per call.
2459
2460         Fixes <http://webkit.org/b/56344> Leaks Viewer should show how many bytes were leaked, not
2461         just how many allocations
2462
2463         Reviewed by Joe Pecoraro.
2464
2465         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
2466         (LeaksParserWorker.prototype._parseLeaks): Parse the number of leaked bytes from the "Leak:"
2467         line and store it with the leak stack.
2468         (LeaksParserWorker.prototype._createNode): Initialize the averageTime and numberOfCalls
2469         properties.
2470         (LeaksParserWorker.prototype._incorporateLeaks): Updated to get the stack from the .stack
2471         property, and changed to store the number of leaked bytes in .selfTime/.totalTime.
2472         .numberOfCalls now holds the number of leaked allocations.
2473
2474         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
2475         (Preferences): Set samplingCPUProfiler to false so that the Average and Calls columns will
2476         appear.
2477         (monkeyPatchInspectorObjects): Format the values as bytes.
2478
2479 2011-03-17  Adam Roben  <aroben@apple.com>
2480
2481         Make Leaks Viewer able to count leaks in builds that didn't fail any regression tests
2482
2483         Fixes <http://webkit.org/b/56626> Leaks Viewer omits recent builds which didn't fail any
2484         regression tests
2485
2486         Reviewed by James Robinson.
2487
2488         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
2489         (RecentBuildsLoader.prototype.start): Get the number of leaks out of the "text" array, which
2490         is always populated, even when all regression tests pass.
2491
2492 2011-03-10  Hayato Ito  <hayato@chromium.org>
2493
2494         Reviewed by Tony Chang.
2495
2496         Add a check logic for reftests in case that a reftest is marked AS REBASELINE.
2497
2498         https://bugs.webkit.org/show_bug.cgi?id=56076
2499
2500         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2501
2502 2011-03-17  Adam Roben  <aroben@apple.com>
2503
2504         Skip a compositing-sensitive test when accelerated compositing is disabled
2505
2506         Reviewed by Sam Weinig.
2507
2508         * Scripts/old-run-webkit-tests: Skip media/media-document-audio-repaint.html when
2509         accelerated compositing is disabled.
2510
2511 2011-03-17  Adam Roben  <aroben@apple.com>
2512
2513         Start using PlatformSpecificScheduler for the Mac builders
2514
2515         The current set of file/directory patterns should work for Mac builders. We may discover
2516         that there are more files and directories we can exclude from the Mac builds, but they can
2517         be added later.
2518
2519         Fixes <http://webkit.org/b/56593> Mac builders do lots of unnecessary builds
2520
2521         Reviewed by Mark Rowe.
2522
2523         * BuildSlaveSupport/build.webkit.org-config/config.json: Moved the Mac builders into two
2524         PlatformSpecificSchedulers: one for Leopard, and one for SnowLeopard.
2525
2526         * Scripts/webkitpy/common/config/build.py:
2527         (_should_file_trigger_build): Allow "mac-leopard" and "mac-snowleopard" platforms, and
2528         cleaned up patterns a little bit.
2529
2530         * Scripts/webkitpy/common/config/build_unittest.py:
2531         (ShouldBuildTest): Fixed some expected results.
2532         (ShouldBuildTest.test_should_build): Start testing "mac-leopard" and "mac-snowleopard"
2533         platforms.
2534
2535 2011-03-17  Jeff Miller  <jeffm@apple.com>
2536
2537         Use a consistent set of file patterns in the svn:ignore property for all .xcodeproj directories, specifically:
2538         
2539         *.mode*
2540         *.pbxuser
2541         *.perspective*
2542         project.xcworkspace
2543         xcuserdata
2544
2545         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
2546         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
2547         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
2548         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
2549         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
2550
2551 2011-03-17  Adam Roben  <aroben@apple.com>
2552
2553         Make old-run-webkit-tests pick up mac-wk2 results when running in WebKit2 mode on Windows
2554
2555         Fixes <http://webkit.org/b/56563> Running WebKit2 tests on Windows should use results from
2556         mac-wk2
2557
2558         Reviewed by Anders Carlsson.
2559
2560         * Scripts/old-run-webkit-tests:
2561         (expectedDirectoryForTest): Clean up the code to search in extra Mac platform result
2562         directories on Windows. Add mac-wk2 to the set of extra platforms we look in on Windows when
2563         we're running in WebKit2 mode.
2564
2565 2011-03-17  Mikhail Naganov  <mnaganov@chromium.org>
2566
2567         Reviewed by Yury Semikhatsky.
2568
2569         Web Inspector: Clean up Inspector strings.
2570         https://bugs.webkit.org/show_bug.cgi?id=56557
2571
2572         Modify the script to deal correctly with "\xNN" escapes, and to
2573         check strings in Chromium's DevTools.js.
2574
2575         * Scripts/check-inspector-strings:
2576
2577 2011-03-17  Keith Kyzivat  <keith.kyzivat@nokia.com>
2578
2579         Reviewed by Benjamin Poulain.
2580
2581         Update autoinstall to install mechanize 0.2.4
2582         https://bugs.webkit.org/show_bug.cgi?id=56499
2583
2584         Newer versions of mechanize support HTTPS proxies, which is necessary
2585         for people using webkit-patch behind firewalls.
2586
2587         * Scripts/webkitpy/common/system/autoinstall.py:
2588         * Scripts/webkitpy/thirdparty/__init__.py:
2589
2590 2011-03-16  Sam Weinig  <sam@webkit.org>
2591
2592         Reviewed by Adam Roben.
2593
2594         REGRESSION (r81084): media/invalid-media-url-crash.html and editing/execCommand/indent-paragraphs.html failing on WebKit2
2595         https://bugs.webkit.org/show_bug.cgi?id=56541
2596
2597         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2598         (WTR::InjectedBundlePage::willSendRequestForFrame):
2599         Check for an empty host in addition to a null host.  This bug was introduced
2600         when porting off of the KURL code and onto the WKURLRef version.
2601
2602 2011-03-16  Sam Weinig  <sam@webkit.org>
2603
2604         Reviewed by Adam Roben.
2605
2606         Add Lucas Forschler to the list of WebKit committers.
2607
2608         * Scripts/webkitpy/common/config/committers.py:
2609
2610 2011-03-16  Sam Weinig  <sam@webkit.org>
2611
2612         Reviewed upon and dictated through Adam Roben.
2613
2614         Escape crashing function names in results.html. This fixes an issue
2615         when a crash involves a type with templates.
2616
2617         * Scripts/old-run-webkit-tests:
2618
2619 2011-03-16  Daniel Sievers  <sievers@google.com>
2620
2621         Reviewed by James Robinson.
2622
2623         Add setting to always force compositing mode
2624         https://bugs.webkit.org/show_bug.cgi?id=56156
2625
2626         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2627         (main):
2628         * DumpRenderTree/chromium/TestShell.cpp:
2629         (TestShell::TestShell):
2630         (TestShell::resetWebSettings):
2631         * DumpRenderTree/chromium/TestShell.h:
2632         (TestShell::setForceCompositingMode):
2633         * DumpRenderTree/chromium/WebPreferences.cpp:
2634         (WebPreferences::reset):
2635         (WebPreferences::applyTo):
2636         * DumpRenderTree/chromium/WebPreferences.h:
2637
2638 2011-03-15  Hayato Ito  <hayato@chromium.org>
2639
2640         Reviewed by Ojan Vafai.
2641
2642         Ignore files that will be used by reftests in old-run-webkit-tests.
2643
2644         https://bugs.webkit.org/show_bug.cgi?id=55936
2645
2646         * Scripts/old-run-webkit-tests:
2647
2648 2011-03-15  Felipe Oliveira da Silva Netto  <f.dachshund@gmail.com>
2649
2650         Reviewed by Adam Roben.
2651
2652         Function relativeScriptsDir doesn't return the correct relative
2653         Scripts directory.
2654
2655         * Scripts/webkitdirs.pm:
2656         (relativeScriptsDir): Ensure we use the directory that contains
2657         webkitdirs.pm, not the one that contains the original script that
2658         was invoked.
2659
2660 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
2661
2662         [wx] Build fixes for long linker commands on Win and method return error, plus a Mac
2663         fix to link against the Security framework after recent WebKitSystemInterface changes.
2664
2665         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2666         (LayoutTestController::originsWithLocalStorage):
2667         * wx/build/settings.py:
2668         * wx/build/waf_extensions.py:
2669
2670 2011-03-15  Sam Weinig  <sam@webkit.org>
2671
2672         Reviewed by Darin Adler.
2673
2674         Add script to convert a patch to a prettypatch and show in the default browser
2675         https://bugs.webkit.org/show_bug.cgi?id=56416
2676
2677         This can be used either like
2678             $ svn-create-patch | show-pretty-diff
2679         or
2680             $ show-pretty-diff patch.diff
2681
2682         * Scripts/show-pretty-diff: Added.
2683
2684 2011-03-15  Brian Weinstein  <bweinstein@apple.com>
2685
2686         Rubber-stamped by Adam Roben.
2687
2688         Adding myself as a reviewer.
2689
2690         * Scripts/webkitpy/common/config/committers.py:
2691
2692 2011-03-15  Anders Carlsson  <andersca@apple.com>
2693
2694         Try to fix the Windows build.
2695
2696         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp:
2697         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
2698
2699 2011-03-15  Anders Carlsson  <andersca@apple.com>
2700
2701         Reviewed by Sam Weinig.
2702
2703         Make sure that NP_Shutdown is always the last NPP function called
2704         https://bugs.webkit.org/show_bug.cgi?id=56391
2705
2706         Add a test that times out if an NP_Deallocate object is called after NP_Shutdown.
2707
2708         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2709         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2710         (PluginTest::PluginTest):
2711         (PluginTest::NP_Shutdown):
2712         (PluginTest::registerNPShutdownFunction):
2713         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2714         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp: Added.
2715         (NPDeallocateCalledBeforeNPShutdown::NPDeallocateCalledBeforeNPShutdown):
2716         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
2717         (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::hasProperty):
2718         (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::getProperty):
2719         (NPDeallocateCalledBeforeNPShutdown::NPP_New):
2720         (NPDeallocateCalledBeforeNPShutdown::NPP_GetValue):
2721         (NPDeallocateCalledBeforeNPShutdown::shutdown):
2722         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2723         (NP_Shutdown):
2724         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2725         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2726         * GNUmakefile.am:
2727
2728 2011-03-15  Ilya Sherman  <isherman@chromium.org>
2729
2730         Reviewed by Tony Chang.
2731
2732         Autofilled form elements are assigned fixed background color but not text color
2733         https://bugs.webkit.org/show_bug.cgi?id=48382
2734
2735         * DumpRenderTree/LayoutTestController.cpp:
2736         (setAutofilledCallback): Added.
2737         (LayoutTestController::staticFunctions):
2738         * DumpRenderTree/LayoutTestController.h:
2739         * DumpRenderTree/chromium/LayoutTestController.cpp:
2740         (LayoutTestController::LayoutTestController):
2741         (LayoutTestController::setAutofilled): Added.
2742         * DumpRenderTree/chromium/LayoutTestController.h:
2743         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2744         (LayoutTestController::setAutofilled): Added.
2745         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2746         (LayoutTestController::setAutofilled): Added.
2747         (LayoutTestController::setValueForUser): Style tweak.
2748         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2749         (LayoutTestController::setAutofilled): Added (stub).
2750         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2751         (LayoutTestController::setAutofilled): Added (stub).
2752
2753 2011-03-15  Dan Bernstein  <mitz@apple.com>
2754
2755         Build fix after r81135.
2756
2757         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
2758
2759 2011-03-15  Dan Bernstein  <mitz@apple.com>
2760
2761         Build fix after r81135.
2762
2763         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
2764         * WebKitTestRunner/mac/TestControllerMac.mm:
2765         * WebKitTestRunner/mac/TestInvocationMac.mm:
2766         * WebKitTestRunner/mac/main.mm:
2767
2768 2011-03-15  Balazs Kelemen  <kbalazs@webkit.org>
2769
2770         Reviewed by Adam Barth.
2771
2772         REGRESSION(80977): breaks Qt ARMv7 Linux Release bot
2773         https://bugs.webkit.org/show_bug.cgi?id=56349
2774
2775         * QtTestBrowser/QtTestBrowser.pro: Link against fontconfig
2776         on platforms where we use it. Copied from DumpRenderTree.pro.
2777
2778 2011-03-15  Dan Bernstein  <mitz@apple.com>
2779
2780         Build fix after r81135.
2781
2782         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
2783         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
2784
2785 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
2786
2787         Reviewed by Darin Adler.
2788
2789         Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export
2790         info into the headers rather than in export symbol definition files, but disable it on 
2791         all platforms initially so we can deal with port build issues one port at a time.
2792         
2793         https://bugs.webkit.org/show_bug.cgi?id=27551
2794
2795         * DumpRenderTree/cg/ImageDiffCG.cpp:
2796         * DumpRenderTree/chromium/config.h:
2797         * DumpRenderTree/config.h:
2798         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2799         * TestWebKitAPI/TestWebKitAPIPrefix.h:
2800         * WebKitAPITest/HostWindow.cpp:
2801         * WebKitAPITest/TestsController.cpp:
2802         * WebKitAPITest/config.h: Added.
2803         * WebKitAPITest/main.cpp:
2804         * WebKitAPITest/tests/WebViewDestruction.cpp:
2805         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp:
2806         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2807         * WebKitTestRunner/InjectedBundle/GCController.cpp:
2808         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2809         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
2810         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2811         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2812         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2813         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
2814         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
2815         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp:
2816         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp:
2817         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
2818         * WebKitTestRunner/TestController.cpp:
2819         * WebKitTestRunner/TestInvocation.cpp:
2820         * WebKitTestRunner/config.h: Added.
2821         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2822         * WebKitTestRunner/qt/TestControllerQt.cpp:
2823         * WebKitTestRunner/qt/TestInvocationQt.cpp:
2824         * WebKitTestRunner/qt/main.cpp:
2825         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2826         * WebKitTestRunner/win/TestControllerWin.cpp:
2827         * WebKitTestRunner/win/TestInvocationWin.cpp:
2828         * WebKitTestRunner/win/main.cpp:
2829         * wx/build/settings.py:
2830
2831 2011-03-15  Hayato Ito  <hayato@chromium.org>
2832
2833         Reviewed by Shinichiro Hamaji.
2834
2835         [NRWT] Add support for reftests to new-run-webkit-tests.
2836
2837         https://bugs.webkit.org/show_bug.cgi?id=55457
2838
2839         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
2840         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2841         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
2842         * Scripts/webkitpy/layout_tests/port/base.py:
2843         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2844         * Scripts/webkitpy/layout_tests/port/test.py:
2845         * Scripts/webkitpy/layout_tests/port/test_files.py:
2846         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2847
2848 2011-03-15  Alejandro G. Castro  <alex@igalia.com>
2849
2850         Reviewed by Martin Robinson.
2851
2852         [GTK] Fix compilation warning after r80892
2853         https://bugs.webkit.org/show_bug.cgi?id=56302
2854
2855         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2856         (LayoutTestController::originsWithLocalStorage):
2857
2858 2011-03-15  Robert Hogan  <robert@webkit.org>
2859
2860         Reviewed by Adam Barth.
2861
2862         Document the qmakearg argument, and hint how to build webkit2 on Qt
2863         https://bugs.webkit.org/show_bug.cgi?id=56326
2864
2865         * Scripts/build-webkit: add --qmakearg to build-webkit --help
2866
2867 2011-03-15  Adam Roben  <aroben@apple.com>
2868
2869         Make Windows 7 Release (Tests) a core builder
2870
2871         We can probably make Windows XP Debug (Tests) a core builder, too, but we should probably
2872         give it a few more days of greenness first.
2873
2874         Fixes <http://webkit.org/b/55665> Windows 7 Release (Tests) should be a core builder
2875
2876         Reviewed by Sam Weinig.
2877
2878         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2879         (BuildBot): Added a regexp to match Windows 7 Release (Tests).
2880
2881         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2882         (BuildBotTest): Updated the list of builders to match the current list on build.webkit.org.
2883         Updated the core regexps to match the buildbot module. Updated the expected results to match
2884         the current set of core builders.
2885
2886 2011-03-14  Adam Roben  <aroben@apple.com>
2887
2888         Add forgotten file from r81116
2889
2890         * TestWebKitAPI/Configurations/TestWebKitAPICFNetwork.vsprops: Added.
2891
2892 2011-03-14  Sam Weinig  <sam@webkit.org>
2893
2894         Reviewed by Adam Roben.
2895
2896         about:blank fake responses don't get serialized when sent the UIProcess
2897         <rdar://problem/9108119>
2898         https://bugs.webkit.org/show_bug.cgi?id=56357
2899
2900         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp: Added.
2901         (TestWebKitAPI::decidePolicyForResponse):
2902         (TestWebKitAPI::TEST):
2903         Add test that loads of about:blank have a response with a MIMEType of text/html.
2904
2905         * TestWebKitAPI/PlatformUtilities.h:
2906         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2907         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
2908         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2909         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
2910         Add helper to get the MIMEType from a WKURLResponse.
2911
2912         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2913         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2914         Add new files.
2915
2916 2011-03-14  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>
2917
2918         Reviewed by Kenneth Rohde Christiansen.
2919
2920         [Qt] Command-line options for QGLWidget and WebGL to QtTestBrowser
2921         https://bugs.webkit.org/show_bug.cgi?id=56006
2922
2923         * QtTestBrowser/launcherwindow.cpp:
2924         (LauncherWindow::initializeView):
2925         * QtTestBrowser/main.cpp:
2926         (LauncherApplication::handleUserOptions):
2927
2928 2011-03-14  James Kozianski  <koz@chromium.org>
2929
2930         Reviewed by Ojan Vafai.
2931
2932         Add method to make BuildBot return test outputs
2933         https://bugs.webkit.org/show_bug.cgi?id=54374
2934
2935         The Builder.latest_cached_build will be used by the new rebaseline
2936         script to determine the build to use baselines from.
2937
2938         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2939         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2940
2941 2011-03-14  Adam Roben  <aroben@apple.com>
2942
2943         Test that WKBundlePageCanHandleRequest returns true for empty document URLs
2944
2945         Reviewed by Sam Weinig.
2946
2947         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp: Added.
2948         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Store the result of the test.
2949         (TestWebKitAPI::setInjectedBundleClient): Hook up our callback.
2950         (TestWebKitAPI::TEST): Register "emptyscheme" as an empty document scheme, load a page to
2951         ensure the web process is initialized, then ask the bundle to run the test and assert that
2952         it succeeded.
2953
2954         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp: Added.
2955         (TestWebKitAPI::CanHandleRequestTest::CanHandleRequestTest): Just call up to the base class.
2956         (TestWebKitAPI::canHandleURL): Helper function to test whether WebKit2 claims to be able to
2957         handle a given URL.
2958         (TestWebKitAPI::runTest): Check that empty document URLs can be handled (and that an unknown
2959         URL type cannot be handled).
2960         (TestWebKitAPI::CanHandleRequestTest::didReceiveMessage): Run the test and return the
2961         result.
2962
2963         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2964         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2965         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
2966         Added new files to the project.
2967
2968 2011-03-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2969
2970         Unreviewed, rolling out r81094.
2971         http://trac.webkit.org/changeset/81094
2972         https://bugs.webkit.org/show_bug.cgi?id=56355
2973
2974         Broke the chromium DRT related build. (Requested by dave_levin
2975         on #webkit).
2976
2977         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2978         (main):
2979         * DumpRenderTree/chromium/LayoutTestController.cpp:
2980         (LayoutTestController::LayoutTestController):
2981         (LayoutTestController::layerTreeAsText):
2982         * DumpRenderTree/chromium/LayoutTestController.h:
2983         * DumpRenderTree/chromium/TestShell.cpp:
2984         (TestShell::runFileTest):
2985         (TestShell::dump):
2986         * DumpRenderTree/chromium/TestShell.h:
2987         (TestParams::TestParams):
2988
2989 2011-03-14  Daniel Sievers  <sievers@google.com>
2990
2991         Reviewed by Simon Fraser.
2992
2993         [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
2994         https://bugs.webkit.org/show_bug.cgi?id=56139
2995
2996         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2997         (main):
2998         * DumpRenderTree/chromium/LayoutTestController.cpp:
2999         (LayoutTestController::LayoutTestController):
3000         (LayoutTestController::layerTreeAsText):
3001         * DumpRenderTree/chromium/LayoutTestController.h:
3002         (LayoutTestController::setShowDebugLayerTree):
3003         * DumpRenderTree/chromium/TestShell.cpp:
3004         (TestShell::runFileTest):
3005         (TestShell::dump):
3006         * DumpRenderTree/chromium/TestShell.h:
3007         (TestParams::TestParams):
3008
3009 2011-03-14  Balazs Kelemen  <kbalazs@webkit.org>
3010
3011         Reviewed by Adam Roben.
3012
3013         [Qt][WK2]Unbreak InjectedBundle on Qt
3014         https://bugs.webkit.org/show_bug.cgi?id=54109
3015
3016         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3017         (WTR::InjectedBundlePage::willSendRequestForFrame): Use new WebKit2
3018         API's instead of KURL to analyze the URL.
3019         * WebKitTestRunner/StringFunctions.h:
3020         (WTR::adoptWK): Moved from InjectedBundlePage.cpp to make it available globally
3021         in the WebKitTestRunner project.
3022         (WTR::toWK): Use adoptWK.
3023         (WTR::operator<<): Added helper for printing a WKURL.
3024         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Do not link
3025         against WebCore.
3026
3027 2011-03-14  Balazs Kelemen  <kbalazs@webkit.org>
3028
3029         Reviewed by Kenneth Rohde Christiansen.
3030
3031         check-webkit-style falsely should not complain about WebKit2 API headers in the Shared directory
3032         https://bugs.webkit.org/show_bug.cgi?id=56321
3033
3034         * Scripts/webkitpy/style/checker.py: Add the patch "Source/WebKit2/Shared/API/c"
3035         to the list of exceptions for WebKit2 C API headers.
3036
3037 2011-03-14  Adam Roben  <aroben@apple.com>
3038
3039         Show the list of recent leaky builds in reverse chronological order
3040
3041         Previously they were being shown in a deterministic but surprising order based on
3042         lexicographically sorting the build offsets (-1, -10, -2, -3...).
3043
3044         Fixes <http://webkit.org/b/56342> Leaks Viewer shows recent builds in a strange order
3045
3046         Reviewed by Darin Adler.
3047
3048         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
3049         (RecentBuildsLoader.prototype.start): Sort the builds by revision before passing them to our
3050         callback.
3051
3052 2011-03-14  Adam Roben  <aroben@apple.com>
3053
3054         Show a list of up to 10 recent leaky builds when Leaks Viewer loads
3055
3056         Fixes <http://webkit.org/b/56043> Leaks Viewer should present a list of recent builds to
3057         analyze
3058
3059         Reviewed by David Kilzer and Joe Pecoraro.
3060
3061         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
3062         (#url-prompt): Made this a bit taller to make room for the list of builds.
3063
3064         (#recent-builds-loading-indicator):
3065         (#recent-builds-list):
3066         Added styles for the build list and loading indicator.
3067
3068         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
3069         (LeaksViewer.loaded): Pass the URL from the query through decodeURIComponent before loading
3070         it. This will unescape it.
3071         (LeaksViewer.urlPromptButtonClicked): Moved code from here to _urlChosenFromPrompt.
3072         (LeaksViewer._didLoadRecentBuilds): Added. Stores the builds and updates the prompt.
3073         (LeaksViewer._displayURLPrompt): Start loading the recent leaky builds.
3074         (LeaksViewer._updateURLPrompt): Create a list of the recent leaky builds and add them to the
3075         prompt UI.
3076         (LeaksViewer._urlChosenFromPrompt): Added. Code came from urlPromptButtonClicked. This is
3077         now also used when a recent build is clicked.
3078
3079         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js: Added.
3080         (RecentBuildsLoader): Store the callback.
3081         (RecentBuildsLoader.prototype.start): Load the N most recent builds from the specified
3082         builder. Find the revision number, leak count, and results URL for each one. Pass the
3083         resulting info to our callback.
3084
3085         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:
3086         (range): Added this helper function to return an array containing the integers [0, n).
3087
3088         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added
3089         RecentBuildsLoader.js and added text to the prompt UI to show the recent builds.
3090
3091 2011-03-14  Mark Rowe  <mrowe@apple.com>
3092
3093         Reviewed by Adam Roben.
3094
3095         Fix two memory leaks within LayoutTestController's storage support.
3096
3097         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3098         (LayoutTestController::originsWithLocalStorage): Don't leak the JSStringRef that is returned
3099         by JSStringCreateWithCFString.
3100         (LayoutTestController::deleteLocalStorageForOrigin): Don't leak the WebSecurityOrigin that we
3101         allocate.
3102
3103 2011-03-14  Mark Rowe  <mrowe@apple.com>
3104
3105         Reviewed by Oliver Hunt.
3106
3107         <http://webkit.org/b/56304> REGRESSION(r80892): 100,000+ leaks seen on the build bot
3108
3109         * DumpRenderTree/LayoutTestController.cpp:
3110         (LayoutTestController::staticFunctions): Remove duplicate entries.
3111
3112 2011-03-14  Alice Liu  <alice.liu@apple.com>
3113
3114         Reviewed by Dan Bernstein.
3115
3116         DumpRenderTree Perl Support fails to build with ARCHS="i386 x86_64"
3117
3118         * DumpRenderTree/mac/PerlSupport/Makefile:
3119         Add whitespace when joining "-arch" with the architectures passed in as arguments.
3120
3121 2011-03-14  Daniel Bates  <dbates@rim.com>
3122
3123         https://bugs.webkit.org/show_bug.cgi?id=55438
3124         Add double quotes around value of -DCMAKE_WINCE_SDK that I inadvertently did not add
3125         when landing changeset 81041 <http://trac.webkit.org/changeset/81041>.
3126
3127         * Scripts/build-webkit:
3128
3129 2011-03-14  Daniel Bates  <dbates@rim.com>
3130
3131         Reviewed by David Kilzer.
3132
3133         Cleanup: Separate port-specific implementation details from webkitdirs::buildCMakeProject()
3134         https://bugs.webkit.org/show_bug.cgi?id=55438
3135
3136         Separate out the EFL- and WinCE-specific logic from the port-independent logic in
3137         webkitdirs::buildCMakeProject(). Also, remove redundant code for generating the
3138         CMake arguments for feature defines.
3139
3140         * Scripts/build-webkit:
3141           - Added cMakeArgsFromFeatures() to convert the @features array to CMake arguments.
3142           - Modified EFL and WinCE-specific building logic to call buildCMakeProjectOrExit().
3143           - Sorted forward declarations.
3144           - Initialize $makeArgs with the empty string so as to simplify its use in string operations;
3145             Modified call sites as needed.
3146         * Scripts/webkitdirs.pm:
3147           - Added cleanCMakeGeneratedProject() to clean a CMake build.
3148           - Added buildCMakeGeneratedProject() to build using generated build system.
3149           - Added buildCMakeProjectOrExit() which is a facade for building a CMake project.
3150           - Added generateBuildSystemFromCMakeProject() to generate the build system from
3151             a CMake project.
3152           - Removed buildCMakeProject(). This functionality is in buildCMakeProjectOrExit().
3153
3154 2011-03-14  John Knottenbelt  <jknotten@chromium.org>
3155
3156         Reviewed by Steve Block.
3157
3158         Detach Geolocation from Frame when Page destroyed.
3159         https://bugs.webkit.org/show_bug.cgi?id=52877
3160
3161         Extend the layout test controller to expose the number of pending
3162         geolocation requests, so that we can test that the requests have
3163         been cancelled on page close.
3164
3165         * DumpRenderTree/LayoutTestController.cpp:
3166         (numberOfPendingGeolocationPermissionRequestsCallback):
3167         (LayoutTestController::staticFunctions):
3168         * DumpRenderTree/LayoutTestController.h:
3169         * DumpRenderTree/chromium/LayoutTestController.cpp:
3170         (LayoutTestController::LayoutTestController):
3171         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3172         * DumpRenderTree/chromium/LayoutTestController.h:
3173         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3174         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3175         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3176         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3177         * DumpRenderTree/mac/UIDelegate.h:
3178         * DumpRenderTree/mac/UIDelegate.mm:
3179         (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
3180         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3181         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3182         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3183         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3184         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3185         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3186         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3187
3188
3189 2011-03-14  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3190
3191         Unreviewed. Modify my email address in committers.py.
3192
3193         * Scripts/webkitpy/common/config/committers.py:
3194
3195 2011-03-13  Joe Wild  <joseph.wild@nokia.com>
3196
3197         Reviewed by Kenneth Rohde Christiansen.
3198
3199         [Qt] QtLauncher does not load the same set of fonts as the DRT
3200         https://bugs.webkit.org/show_bug.cgi?id=34959
3201
3202         This patch adds the option "-use-test-fonts" to the QtTestBrowser.
3203         When this option is used the webkit fonts are loaded the same
3204         as they are in DumpRenderTree.  This option can be used on
3205         QtTestBrowser and run-launcher.  It can only be used
3206         on Linux systems with FcInit and is configured as such.
3207
3208         * QtTestBrowser/launcherwindow.h:
3209         (WindowOptions::WindowOptions):
3210         * QtTestBrowser/main.cpp:
3211         (initWebKitTestFonts):
3212         (launcherMain):
3213         (LauncherApplication::handleUserOptions):
3214
3215 2011-03-12  Dan Bernstein  <mitz@apple.com>
3216
3217         Reviewed by Mark Rowe.
3218
3219         <rdar://problem/8995822> Build DumpRenderTree perl support only for the architectures
3220         DumpRenderTree is being built for.
3221
3222         * DumpRenderTree/mac/PerlSupport/Makefile:
3223
3224 2011-03-12  Dan Bernstein  <mitz@apple.com>
3225
3226         Suggested by Mark Rowe.
3227
3228         * DumpRenderTree/mac/Configurations/Base.xcconfig: Leave C++ exceptions enabled
3229         as they were before r80915.
3230
3231 2011-03-12  Anders Carlsson  <andersca@apple.com>
3232
3233         Reviewed by Sam Weinig.
3234
3235         Should be able to download a PDF to the Downloads folder
3236         https://bugs.webkit.org/show_bug.cgi?id=56256
3237
3238         * MiniBrowser/mac/BrowserWindowController.m:
3239         (-[BrowserWindowController awakeFromNib]):
3240         * WebKitTestRunner/TestController.cpp:
3241         (WTR::TestController::createOtherPage):
3242         (WTR::TestController::initialize):
3243         Update for API changes.
3244
3245 2011-03-11  Anton D'Auria  <adauria@apple.com>
3246
3247         Reviewed and landed by Brady Eidson.
3248
3249         https://bugs.webkit.org/show_bug.cgi?id=51878
3250         Add WebKit1 API to view and delete local storage
3251
3252         Added tests that write to LocalStorage, delete one origin, get list of origins with local storage, delete all origins.
3253
3254         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3255         * DumpRenderTree/LayoutTestController.cpp:
3256         (syncLocalStorageCallback):
3257         (observeStorageTrackerNotificationsCallback):
3258         (deleteAllLocalStorageCallback):
3259         (deleteLocalStorageForOriginCallback):
3260         (originsWithLocalStorageCallback):
3261         (LayoutTestController::staticFunctions):
3262         * DumpRenderTree/LayoutTestController.h:
3263         * DumpRenderTree/StorageTrackerDelegate.h: Added.
3264         * DumpRenderTree/StorageTrackerDelegate.mm: Added.
3265         (-[StorageTrackerDelegate init]):
3266         (-[StorageTrackerDelegate logNotifications:controller:]):
3267         (-[StorageTrackerDelegate originModified:]):
3268         (-[StorageTrackerDelegate dealloc]):
3269         (-[StorageTrackerDelegate setControllerToNotifyDone:]):
3270         * DumpRenderTree/chromium/LayoutTestController.cpp:
3271         (LayoutTestController::LayoutTestController):
3272         (LayoutTestController::deleteAllLocalStorage):
3273         (LayoutTestController::originsWithLocalStorage):
3274         (LayoutTestController::deleteLocalStorageForOrigin):
3275         (observeStorageTrackerNotifications):
3276         (syncLocalStorage):
3277         * DumpRenderTree/chromium/LayoutTestController.h:
3278         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3279         (LayoutTestController::originsWithLocalStorage):
3280         (LayoutTestController::deleteAllLocalStorage):
3281         (LayoutTestController::deleteLocalStorageForOrigin):
3282         (LayoutTestController::observeStorageTrackerNotifications):
3283         (LayoutTestController::syncLocalStorage):
3284         * DumpRenderTree/mac/DumpRenderTree.mm:
3285         (resetDefaultsToConsistentValues):
3286         (allocateGlobalControllers):
3287         (releaseGlobalControllers):
3288         * DumpRenderTree/mac/DumpRenderTreeMac.h:
3289         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3290         (LayoutTestController::syncLocalStorage):
3291         (LayoutTestController::observeStorageTrackerNotifications):
3292         (LayoutTestController::deleteAllLocalStorage):
3293         (LayoutTestController::originsWithLocalStorage):
3294         (LayoutTestController::deleteLocalStorageForOrigin):
3295         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3296         (LayoutTestController::originsWithLocalStorage):
3297         (LayoutTestController::deleteAllLocalStorage):
3298         (LayoutTestController::deleteLocalStorageForOrigin):
3299         (LayoutTestController::observeStorageTrackerNotifications):
3300         (LayoutTestController::syncLocalStorage):
3301         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3302         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3303         (LayoutTestController::clearAllApplicationCaches):
3304         (LayoutTestController::syncLocalStorage):
3305         (LayoutTestController::observeStorageTrackerNotifications):
3306         (LayoutTestController::clearAllDatabases):
3307         (LayoutTestController::deleteAllLocalStorage):
3308         (LayoutTestController::originsWithLocalStorage):
3309         (LayoutTestController::deleteLocalStorageForOrigin):
3310         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3311         (LayoutTestController::syncLocalStorage):
3312         (LayoutTestController::observeStorageTrackerNotifications):
3313         (LayoutTestController::clearAllDatabases):
3314         (LayoutTestController::deleteAllLocalStorage):
3315         (LayoutTestController::originsWithLocalStorage):
3316         (LayoutTestController::deleteLocalStorageForOrigin):
3317
3318 2011-03-11  Jessie Berlin  <jberlin@apple.com>
3319
3320         Reviewed by Adam Roben.
3321
3322         Crash calling WebContext::clearResourceCaches(InMemoryResourceCachesOnly) before the Web
3323         Process has finished launching.
3324         https://bugs.webkit.org/show_bug.cgi?id=56208
3325
3326         * TestWebKitAPI/Tests/WebKit2/SendingMessagesToTheWebProcessBeforeItIsValid.cpp: Added.
3327         (TestWebKitAPI::TEST):
3328         Test that calling WKContextClearResourceCaches works with both options when called before
3329         the Web Process is valid.
3330
3331         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3332         Add the new test.
3333         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3334         Ditto.
3335
3336 2011-03-11  Adam Roben  <aroben@apple.com>
3337
3338         Make it possible to view all leaks from a build at once in Leaks Viewer
3339
3340         You can now give Leaks Viewer the URL of a build results page (e.g.,
3341         <http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r80847%20(15493)/>), and it
3342         will load all the leaks files from that build.
3343
3344         Fixes <http://webkit.org/b/56030> Leaks Viewer: Would like to be able to look at all leaks
3345         files from a particular build at once, rather than one at a time
3346
3347         Reviewed by David Kilzer.
3348
3349         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksLoader.js: Added.
3350         (LeaksLoader): Initialize our properties.
3351         (LeaksLoader.prototype.start): If the URL ends in .txt, assume it's a single leaks file and
3352         load it. Otherwise assume it's a build results page URL and start fetching the leaks files
3353         from that page.
3354         (LeaksLoader.prototype._loadLeaksFiles): Tell our client how many leaks files we're loading
3355         so it can provide feedback. Then load each one and pass it to the client.
3356         (LeaksLoader.prototype._loadLeaksFromResultsPage): Load the HTML of the results page, parse
3357         it into a DOM, pull out all the links to leaks files, and load each one.
3358
3359         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParser.js: Added.
3360         (LeaksParser): Initialize our worker.
3361         (LeaksParser.prototype.addLeaksFile): Tell the worker about the leaks file's contents.
3362
3363         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js: Added.
3364         This code mostly came from Worker.js.
3365         (LeaksParserWorker): Initialize our profile.
3366         (LeaksParserWorker.prototype.addLeaksFile): Parse the leaks file and incorporate it into our
3367         profile.
3368         (LeaksParserWorker.prototype._parseLeaks):
3369         (LeaksParserWorker.prototype._createNode):
3370         (LeaksParserWorker.prototype._incorporateLeaks):
3371         Moved these functions here from LeaksViewer. _incorporateLeaks is essentially just a renamed
3372         version of createProfile which adds to this.profile instead of making a new profile each
3373         time.
3374         (onmessage): Parse the file and send back the new profile.
3375
3376         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
3377         (#loading-indicator):
3378         (#spinner):
3379         (#loading-indicator-label):
3380         Tweaked styles to accomodate a longer label.
3381
3382         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
3383         (LeaksViewer.loaded): Set up a loader and parser.
3384
3385         (LeaksViewer.get filesLeftToParse):
3386         (LeaksViewer.set filesLeftToParse):
3387         Added these simple accessors.
3388
3389         (LeaksViewer._didCountLeaksFiles): Callback from LeaksLoader. Stores the count.
3390         (LeaksViewer._didLoadLeaksFile): Callback from LeaksLoader. Passes the file contents off to
3391         the parser.
3392         (LeaksViewer._didParseLeaksFile): Callback from LeaksParser. If all files have been parsed,
3393         tell the ProfilerAgent and mark that we're done loading. (Code came from the old
3394         _loadLeaksFromURL function).
3395         (LeaksViewer._loadLeaksFromURL): Now just calls through to the loader.
3396         (LeaksViewer._loadingIndicatorText): Added. Returns the text that should show up in the
3397         loading indicator, including the number of files being loaded.
3398         (LeaksViewer._loadingStatusChanged): Update the loading indicator's label, too.
3399         (LeaksViewer._updateLoadingIndicatorLabel): Added. Just updates the label!
3400         (LeaksViewer._updateTitle): Moved code to compute the "Loading" text to
3401         _loadingIndicatorText.
3402
3403         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js: Added.
3404         (getResource): Moved here from LeaksViewer.js.
3405
3406         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Worker.js: Subsumed by
3407         LeaksParserWorker.js.
3408
3409         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added new JS
3410         files, added a #loading-indicator-label element, and tweaked the prompt wording.
3411
3412 2011-03-11  Adam Roben  <aroben@apple.com>
3413
3414         Don't trigger a build when build.webkit.org's HTML files are modified
3415
3416         Fixes <http://webkit.org/b/56190> Windows bots shouldn't have built r80848/r80851, but did
3417
3418         Reviewed by Dan Bernstein.
3419
3420         * Scripts/webkitpy/common/config/build.py:
3421         (_should_file_trigger_build): Added build.webkit.org's public_html directory to the list of
3422         directories that shouldn't trigger builds. Re-sorted the list.
3423
3424         * Scripts/webkitpy/common/config/build_unittest.py:
3425         (ShouldBuildTest): Added a test to cover the above change.
3426
3427 2011-03-11  Adam Roben  <aroben@apple.com>
3428
3429         Roll out r80848
3430
3431         It was accidentally committed.
3432
3433         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
3434         (LeaksViewer._loadLeaksFromURL):
3435
3436 2011-03-11  Tony Chang  <tony@chromium.org>
3437
3438         Reviewed by Ojan Vafai.
3439
3440         kill hung lighttpd processes on the chromium win bot
3441         https://bugs.webkit.org/show_bug.cgi?id=56152
3442
3443         Sometimes this process doesn't exit and it holds on to
3444         a log file that we can't delete or copy, causing the tests
3445         to go red.
3446
3447         * BuildSlaveSupport/win/kill-old-processes:
3448
3449 2011-03-11  Ilya Sherman  <isherman@chromium.org>
3450
3451         Reviewed by Kent Tamura.
3452
3453         [Chromium] missing HTMLInputElement::setValueForUser() to tests
3454         https://bugs.webkit.org/show_bug.cgi?id=55854
3455
3456         * DumpRenderTree/chromium/LayoutTestController.cpp:
3457         (LayoutTestController::LayoutTestController):
3458         (LayoutTestController::setValueForUser): Added.
3459         * DumpRenderTree/chromium/LayoutTestController.h:
3460
3461 2011-03-10  Peter Kasting  <pkasting@google.com>
3462
3463         Reviewed by Dimitri Glazkov.
3464
3465         Clean up some gross code in TestShellWin.cpp.  No functional change.
3466         https://bugs.webkit.org/show_bug.cgi?id=56048
3467
3468         * DumpRenderTree/chromium/TestShellWin.cpp:
3469         (checkLayoutTestSystemDependencies):
3470
3471 2011-03-10  Keith Kyzivat  <keith.kyzivat@nokia.com>
3472
3473         Reviewed by Laszlo Gombos.
3474
3475         [Qt] Buildfix for platforms where X11 is not available (e.g. Symbian)
3476
3477         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3478         (WTR::activateFonts): Guard X11-specific code with Q_WS_X11.
3479
3480 2011-03-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3481
3482         Reviewed by Kenneth Rohde Christiansen.
3483
3484         [EFL] Make single backing store the default for EWebLauncher
3485         https://bugs.webkit.org/show_bug.cgi?id=55753
3486
3487         Set single backing store the default for EWebLauncher.
3488
3489         * EWebLauncher/main.c:
3490         (main):
3491
3492 2011-03-10  Adam Roben  <aroben@apple.com>
3493
3494         Ignore errors from files being held open when creating a test result archive
3495
3496         Fixes <http://webkit.org/b/55581> Test results don't get uploaded if test-result-archive
3497         fails to delete the results directory
3498
3499         Reviewed by Mark Rowe.
3500
3501         * BuildSlaveSupport/test-result-archive:
3502         (archiveTestResults): Ignore errno 2 when deleting the results directory, since it can be
3503         thrown when a process is holding a file open.
3504
3505 2011-03-10  Sheriff Bot  <webkit.review.bot@gmail.com>
3506
3507         Unreviewed, rolling out r80701.
3508         http://trac.webkit.org/changeset/80701
3509         https://bugs.webkit.org/show_bug.cgi?id=56126
3510
3511         fast/dom/Geolocation/window-close-crash.html fails on Snow
3512         Leopard release builds (Requested by mihaip on #webkit).
3513
3514         * DumpRenderTree/LayoutTestController.cpp:
3515         (LayoutTestController::staticFunctions):
3516         * DumpRenderTree/LayoutTestController.h:
3517         * DumpRenderTree/chromium/LayoutTestController.cpp:
3518         (LayoutTestController::LayoutTestController):
3519         * DumpRenderTree/chromium/LayoutTestController.h:
3520         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3521         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3522         * DumpRenderTree/mac/UIDelegate.h:
3523         * DumpRenderTree/mac/UIDelegate.mm:
3524         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3525         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3526         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3527         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3528
3529 2011-03-10  Philippe Normand  <pnormand@igalia.com>
3530
3531         Reviewed by Gustavo Noronha Silva.
3532
3533         [GTK] run-gtk-tests doesn't fail if a test crashes
3534         https://bugs.webkit.org/show_bug.cgi?id=56089
3535
3536         * Scripts/run-gtk-tests: gtester -k exits with a 0 exit status
3537         even if a test crashes. So run the tests individually and if a
3538         test fails remember its exit code so run-gtk-test fails too, if
3539         required.
3540
3541 2011-01-26  John Knottenbelt  <jknotten@chromium.org>
3542
3543         Reviewed by Dmitry Titov.
3544
3545         Detach Geolocation from Frame when Page destroyed.
3546         https://bugs.webkit.org/show_bug.cgi?id=52877
3547
3548         Extend the layout test controller to expose the number of pending
3549         geolocation requests, so that we can test that the requests have
3550         been cancelled on page close.
3551
3552         * DumpRenderTree/LayoutTestController.cpp:
3553         (numberOfPendingGeolocationPermissionRequestsCallback):
3554         (LayoutTestController::staticFunctions):
3555         * DumpRenderTree/LayoutTestController.h:
3556         * DumpRenderTree/chromium/LayoutTestController.cpp:
3557         (LayoutTestController::LayoutTestController):
3558         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3559         * DumpRenderTree/chromium/LayoutTestController.h:
3560         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3561         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3562         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3563         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3564         * DumpRenderTree/mac/UIDelegate.h:
3565         * DumpRenderTree/mac/UIDelegate.mm:
3566         (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
3567         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3568         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3569         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3570         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3571         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3572         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3573         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3574
3575
3576 2011-03-09  Adam Roben  <aroben@apple.com>
3577
3578         Hide Leaks Viewer's URL prompt by default
3579
3580         We will show it as needed. I think I left it visible by default by accident after doing some
3581         testing.
3582
3583         Fixes <http://webkit.org/b/56031> Leaks Viewer: URL prompt overlay shouldn't appear when a
3584         URL is passed as a query parameter, but does
3585
3586         Reviewed by Simon Fraser.
3587
3588         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:
3589
3590 2011-03-09  Adam Roben  <aroben@apple.com>
3591
3592         Don't use Element.classList or box-shadow in Leaks Viewer
3593
3594         They aren't supported by Safari 5. Luckily we have substitutes for them!
3595
3596         Fixes <http://webkit.org/b/56035> Leaks viewer doesn't work in Safari 5
3597
3598         Reviewed by Simon Fraser.
3599
3600         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
3601         (#url-prompt): Use -webkit-box-shadow instead of box-shadow.
3602
3603         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
3604         (LeaksViewer.urlPromptButtonClicked):
3605         (LeaksViewer._displayURLPrompt):
3606         (LeaksViewer._setLoadingIndicatorHidden):
3607         Use add/removeStyleClass (from utilities.js) instead of Element.classList.
3608
3609 2011-03-09  Adam Roben  <aroben@apple.com>
3610
3611         Add a link to the Leaks Viewer tool on the build.webkit.org homepage
3612
3613         Rubber-stamped by David Kilzer.
3614
3615         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
3616
3617 2011-03-09  Adam Roben  <aroben@apple.com>
3618
3619         Add a Leaks Viewer tool to build.webkit.org
3620
3621         This tool parses leaks from the files generated by the leaks bot and displays them in a
3622         view similar to the Web Inspector's Profiles pane (in fact, it uses the Web Inspector's
3623         code).
3624
3625         The URL of the leaks file can be entered in a prompt when the tools is first shown, or can
3626         be passed to the tool via the "url" query parameter.
3627
3628         Only one leaks file can be viewed at a time for now. Only the number of leaks, as opposed to
3629         the number of leaked bytes, is shown. And this tool has made apparent some bugs in the Web
3630         Inspector's Heavy profile view. But it's still pretty useful as-is.
3631
3632         Fixes <http://webkit.org/b/56028> Would like a Shark-like tool for viewing leaks from leak bots
3633
3634         Reviewed by Darin Adler.
3635
3636         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css: Added.
3637         (#url-prompt-container): This is the dark overlay that is shown behind the URL prompt.
3638         (#url-prompt): This is the prompt itself.
3639
3640         (#loading-indicator):
3641         (#loading-indicator > img):
3642         These show a spinner in the bottom-right when we're loading a leaks file.
3643
3644         (.percent-time-status-bar-item): Hide the Percent button since we never want to show leaks
3645         as percentages.
3646
3647         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js: Added.
3648         (LeaksViewer.loaded): Initialize ourselves and start loading the leaks file (or prompt for a
3649         URL if one wasn't given to us as a query parameter).
3650
3651         (LeaksViewer.get loading):
3652         (LeaksViewer.set loading):
3653         (LeaksViewer.get url):
3654         (LeaksViewer.set url):
3655         Pretty simple accessors.
3656
3657         (LeaksViewer.urlPromptButtonClicked): Start loading the URL from the prompt and hide the
3658  &nb