run-bindings-tests is not Win32-compatible
[WebKit-https.git] / Tools / ChangeLog
1 2018-08-08  Ross Kirsling  <ross.kirsling@sony.com>
2
3         run-bindings-tests is not Win32-compatible
4         https://bugs.webkit.org/show_bug.cgi?id=188424
5
6         Reviewed by Fujii Hironori.
7
8         * Scripts/webkitpy/bindings/main.py:
9         (BindingsTests.main):
10         Stop leaking file descriptors.
11         (See https://www.logilab.org/blogentry/17873 for details, though the solution here is even simpler.)
12
13 2018-08-08  Alex Christensen  <achristensen@webkit.org>
14
15         Fix possible null dereference in WebBackForwardList::restoreFromState
16         https://bugs.webkit.org/show_bug.cgi?id=188418
17         <rdar://problem/42531726>
18
19         Reviewed by Chris Dumez.
20
21         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
22         (TestWebKitAPI::TEST):
23
24 2018-08-08  Ross Kirsling  <ross.kirsling@sony.com>
25
26         run-builtins-generator-tests does not correctly handle CRLFs from stderr
27         https://bugs.webkit.org/show_bug.cgi?id=188392
28
29         Reviewed by Fujii Hironori.
30
31         Background:
32         file.write converts LF to os.linesep, so if the input string contains CRLF, we end up writing CRCRLF to the file.
33
34         * Scripts/webkitpy/common/system/executive.py:
35         (Executive.run_command):
36         Normalize CRLF to LF in decoded stdout/stderr data, so that we don't return consumers a platform-specific string.
37
38 2018-08-08  Aditya Keerthi  <akeerthi@apple.com>
39
40         Unreviewed, add myself to committers list.
41
42         * Scripts/webkitpy/common/config/contributors.json:
43
44 2018-08-08  Commit Queue  <commit-queue@webkit.org>
45
46         Unreviewed, rolling out r234314, r234320, and r234321.
47         https://bugs.webkit.org/show_bug.cgi?id=188414
48
49         Caused email sign in issue (Requested by ryanhaddad on
50         #webkit).
51
52         Reverted changesets:
53
54         "Remove unused WKNavigationDelegatePrivate
55         decidePolicyForNavigationAction SPI"
56         https://bugs.webkit.org/show_bug.cgi?id=188077
57         https://trac.webkit.org/changeset/234314
58
59         "Fix API tests after r234314"
60         https://bugs.webkit.org/show_bug.cgi?id=188077
61         https://trac.webkit.org/changeset/234320
62
63         "Fix API tests after r234314"
64         https://bugs.webkit.org/show_bug.cgi?id=188077
65         https://trac.webkit.org/changeset/234321
66
67 2018-08-08  Wenson Hsieh  <wenson_hsieh@apple.com>
68
69         [iOS] fast/events/ios/contenteditable-autocapitalize.html is a flaky failure
70         https://bugs.webkit.org/show_bug.cgi?id=188401
71         <rdar://problem/32542300>
72
73         Reviewed by Ryosuke Niwa.
74
75         When run individually, fast/events/ios/contenteditable-autocapitalize.html passes consistently; however, when
76         run right after another layout test that finishes while the keyboard is shown, this test sometimes fails. This
77         is because each of the three steps of this test ends when UIScriptController's `didHideKeyboardCallback` is
78         invoked, and if the keyboard only begins to dismiss after the previous test completes, we have a race. When the
79         keyboard finishes dismissing after the UI script is evaluated, it will trigger UI script completion early and
80         skip over one of the steps in the layout test, resulting in a text diff failure.
81
82         To fix this, add a mechanism in WebKitTestRunner to wait until the keyboard is dismissed (with a short timeout)
83         as a part of resetting test controller state, before moving on to the next layout test.
84
85         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
86         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
87         (-[TestRunnerWKWebView didStartFormControlInteraction]):
88         (-[TestRunnerWKWebView didEndFormControlInteraction]):
89
90         Use these hooks to keep track of whether the previous test is presenting any form input UI.
91
92         (-[TestRunnerWKWebView isInteractingWithFormControl]):
93         * WebKitTestRunner/ios/TestControllerIOS.mm:
94         (WTR::handleKeyboardWillHideNotification):
95         (WTR::handleKeyboardDidHideNotification):
96         (WTR::TestController::platformInitialize):
97         (WTR::TestController::platformDestroy):
98
99         Register during initialization (and unregister during teardown) for keyboard hiding notifications, to keep track
100         of when the keyboard dismissal animation ends.
101
102         (WTR::TestController::platformResetStateToConsistentValues):
103
104         Make a couple of tweaks here: (1) if form input UI is being shown, tell the web view to resign first responder,
105         which causes the field to lose focus. (2) If necessary, wait for the current keyboard dismissal animation to
106         finish. This includes any keyboard dismissal animations triggered as a result of step (1).
107
108 2018-08-05  Darin Adler  <darin@apple.com>
109
110         [Cocoa] More tweaks and refactoring to prepare for ARC
111         https://bugs.webkit.org/show_bug.cgi?id=188245
112
113         Reviewed by Dan Bernstein.
114
115         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Use const void* for a
116         CFTypeRef instead of void*.
117
118         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
119         (createCoreAnimationLayer): Use CFBridgingRetain.
120
121         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
122         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker): Use bridging casts.
123         (AccessibilityUIElement::textMarkerRangeForElement): Ditto.
124         (AccessibilityUIElement::selectedTextMarkerRange): Ditto.
125         (AccessibilityUIElement::textMarkerRangeLength): Ditto.
126         (AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute): Ditto.
127         (AccessibilityUIElement::indexForTextMarker): Ditto.
128         (AccessibilityUIElement::textMarkerForIndex): Ditto.
129         (AccessibilityUIElement::isTextMarkerValid): Ditto.
130         (AccessibilityUIElement::previousTextMarker): Ditto.
131         (AccessibilityUIElement::nextTextMarker): Ditto.
132         (AccessibilityUIElement::stringForTextMarkerRange): Ditto.
133         (createJSStringRef): Ditto.
134         (AccessibilityUIElement::attributedStringForTextMarkerRange): Ditto.
135         (AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions): Ditto.
136         (AccessibilityUIElement::textMarkerRangeForMarkers): Ditto.
137         (AccessibilityUIElement::startTextMarkerForTextMarkerRange): Ditto.
138         (AccessibilityUIElement::endTextMarkerForTextMarkerRange): Ditto.
139         (AccessibilityUIElement::endTextMarkerForBounds): Ditto.
140         (AccessibilityUIElement::startTextMarkerForBounds): Ditto.
141         (AccessibilityUIElement::textMarkerForPoint): Ditto.
142         (AccessibilityUIElement::accessibilityElementForTextMarker): Ditto.
143         (AccessibilityUIElement::startTextMarker): Ditto.
144         (AccessibilityUIElement::endTextMarker): Ditto.
145         (AccessibilityUIElement::setSelectedVisibleTextRange): Ditto.
146         (AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker): Ditto.
147         (AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker): Ditto.
148         (AccessibilityUIElement::previousWordStartTextMarkerForTextMarker): Ditto.
149         (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker): Ditto.
150         (AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker): Ditto.
151         (AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker): Ditto.
152         (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker): Ditto.
153         (AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker): Ditto.
154         (AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker): Ditto.
155         (AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker): Ditto.
156
157         * DumpRenderTree/mac/DumpRenderTree.mm:
158         (resetWebPreferencesToConsistentValues): Use bridging cast.
159         (dumpFramesAsText): Ditto.
160         (dumpBackForwardListForAllWindows): Use a modern for loop instead of
161         CFArray functions to iterate the array.
162         (dump): Use bridging cast.
163         (runTest): Ditto.
164
165         * DumpRenderTree/mac/DumpRenderTreePasteboard.mm:
166         (+[LocalPasteboard alloc]): Use class_createInstance instead of NSAllocateObject.
167         (toUTI): Return a RetainPtr<CFStringRef>.
168         (-[LocalPasteboard types]): Use the above and bridging casts.
169         (-[LocalPasteboard availableTypeFromArray:]): Ditto.
170         (-[LocalPasteboard setData:forType:]): Ditto.
171         (-[LocalPasteboard dataForType:]): Ditto.
172         (-[LocalPasteboard setPropertyList:forType:]): Use NSPropertyListSerialization
173         instead of CFPropertyList.
174         (-[LocalPasteboard setString:forType:]): Use NSString method instead of
175         CFStringCreateExternalRepresentation.
176
177         * DumpRenderTree/mac/MockGeolocationProvider.h: Put CFTypeRef in a HashSet
178         instead of an Objective-C object pointer type.
179         * DumpRenderTree/mac/MockGeolocationProvider.mm:
180         (-[MockGeolocationProvider registerWebView:]): Update for above.
181         (-[MockGeolocationProvider unregisterWebView:]): Ditto.
182         (-[MockGeolocationProvider timerFired]): Ditto.
183
184         * DumpRenderTree/mac/MockWebNotificationProvider.h: Use CFTypeRef in
185         HashMap and HashSet instead of an Objective-C object pointer type.
186         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
187         (-[MockWebNotificationProvider registerWebView:]): Update for above.
188         (-[MockWebNotificationProvider unregisterWebView:]): Ditto.
189         (-[MockWebNotificationProvider showNotification:fromWebView:]): Ditto.
190         (-[MockWebNotificationProvider cancelNotification:]): Ditto.
191         (-[MockWebNotificationProvider simulateWebNotificationClick:]): Ditto.
192
193         * DumpRenderTree/mac/ObjCPlugin.m:
194         (-[JSObjC retainObject:]): Use CFRetain instead of -[NSObject retain].
195
196         * DumpRenderTree/mac/TestRunnerMac.mm:
197         (TestRunner::addDisallowedURL): Use bridging cast.
198         (TestRunner::applicationCacheDiskUsageForOrigin): Ditto.
199         (TestRunner::clearApplicationCacheForOrigin): Ditto.
200         (originsArrayToJS): Ditto.
201         (TestRunner::copyDecodedHostName): Ditto.
202         (TestRunner::copyEncodedHostName): Ditto.
203         (TestRunner::queueLoad): Ditto.
204         (TestRunner::setDomainRelaxationForbiddenForURLScheme): Ditto.
205         (TestRunner::setMockGeolocationPositionUnavailableError): Ditto.
206         (TestRunner::setUserStyleSheetLocation): Ditto.
207         (TestRunner::setValueForUser): Ditto.
208         (TestRunner::overridePreference): Ditto.
209         (TestRunner::execCommand): Ditto.
210         (TestRunner::findString): Ditto.
211         (TestRunner::isCommandEnabled): Ditto.
212         (TestRunner::addOriginAccessWhitelistEntry): Ditto.
213         (TestRunner::removeOriginAccessWhitelistEntry): Ditto.
214         (TestRunner::addUserScript): Ditto.
215         (TestRunner::addUserStyleSheet): Ditto.
216         (TestRunner::evaluateInWebInspector): Ditto.
217         (TestRunner::evaluateScriptInIsolatedWorld): Ditto.
218         (TestRunner::authenticateSession): Ditto.
219         (TestRunner::grantWebNotificationPermission): Ditto.
220         (TestRunner::denyWebNotificationPermission): Ditto.
221         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
222         (-[LayoutTestSpellChecker setResultsFromJSObject:inContext:]): Ditto.
223
224         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
225         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker): Use bridging cast.
226         (WTR::AccessibilityUIElement::textMarkerRangeForElement): Ditto.
227         (WTR::AccessibilityUIElement::previousTextMarker): Ditto.
228         (WTR::AccessibilityUIElement::nextTextMarker): Ditto.
229         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers): Ditto.
230         (WTR::AccessibilityUIElement::selectedTextMarkerRange): Ditto.
231         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange): Ditto.
232         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange): Ditto.
233         (WTR::AccessibilityUIElement::endTextMarkerForBounds): Ditto.
234         (WTR::AccessibilityUIElement::startTextMarkerForBounds): Ditto.
235         (WTR::AccessibilityUIElement::textMarkerForPoint): Ditto.
236         (WTR::AccessibilityUIElement::textMarkerForIndex): Ditto.
237         (WTR::AccessibilityUIElement::startTextMarker): Ditto.
238         (WTR::AccessibilityUIElement::endTextMarker): Ditto.
239         (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker): Ditto.
240         (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker): Ditto.
241         (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker): Ditto.
242         (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker): Ditto.
243         (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker): Ditto.
244         (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker): Ditto.
245         (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker): Ditto.
246         (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker): Ditto.
247         (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker): Ditto.
248         (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker): Ditto.
249
250         * WebKitTestRunner/PlatformMac.cmake: Added WebKitTestRunnerWindow.h and .mm files.
251         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Ditto.
252
253         * WebKitTestRunner/mac/EventSenderProxy.mm: Add include of WebKitTestRunnerWindow.h
254         so we can use the type and know it inherits from NSWindow.
255
256         * WebKitTestRunner/mac/PlatformWebViewMac.mm: Add include of WebKitTestRunnerWindow.h
257         so we can use the type and know it inherits from NSWindow. Moved WebKitTestRunnerWindow
258         class into a separate file.
259         (WTR::PlatformWebView::keyWindow): Call +[WebKitTestRunnerWindow _WTR_keyWindow]
260         instead of have a second copy of the implementation.
261
262         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm: Add include of WebKitTestRunnerWindow.h
263         so we can use the type and know it inherits from NSWindow. Also removed "using namespace".
264         (+[WebKitTestRunnerEvent mouseLocation]): Updated for above.
265
266         * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm:
267         (+[LocalPasteboard alloc]): Use class_createInstance instead of NSAllocateObject.
268         (-[LocalPasteboard availableTypeFromArray:]): Use modern for loop.
269         (-[LocalPasteboard setData:forType:]): Reordered method to be a tiny bit more efficient.
270         (-[LocalPasteboard setPropertyList:forType:]): Use NSPropertyListSerialization
271         instead of CFPropertyList.
272         (-[LocalPasteboard setString:forType:]): Use NSString method instead of
273         CFStringCreateExternalRepresentation.
274
275         * WebKitTestRunner/mac/WebKitTestRunnerWindow.h: Moved declaration of
276         WebKitTestRunnerWindow here so it can be included by files that need to know
277         what the type is and that it inherits from NSWindow.
278
279         * WebKitTestRunner/mac/WebKitTestRunnerWindow.mm: Added. Moved implementation here.
280         (+[WebKitTestRunnerWindow _WTR_keyWindow]): Use modern for loop instead of the old,
281         messier implementation.
282
283 2018-08-07  Alex Christensen  <achristensen@webkit.org>
284
285         Add a test for using SafeBrowsing
286         https://bugs.webkit.org/show_bug.cgi?id=188290
287
288         Reviewed by Chris Dumez.
289
290         Swizzle out SSBLookupContext to write tests for how WebKit responds when it responds in different ways.
291         We don't do anything with its results in WebKit yet, but when we do I'll add the expected behavior to this test.
292
293         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
294         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm: Added.
295         (-[SafeBrowsingDelegate webView:didFinishNavigation:]):
296         (TestWebKitAPI::TEST):
297
298 2018-08-07  Lucas Forschler  <lforschler@apple.com>
299
300         If there's a Radar in the ChangeLog, webkit-patch upload/create-bug should put the radar in the bug and set InRadar
301         https://bugs.webkit.org/show_bug.cgi?id=188235
302
303         Reviewed by Daniel Bates, Kocsen Chung, and Aakash Jain.
304
305         * Scripts/webkitpy/common/checkout/changelog.py: 
306         (ChangeLogEntry): Teach the ChangeLog tools how to parse a radar_id
307         * Scripts/webkitpy/common/checkout/changelog_unittest.py: Test out the new _parse_radar_id functionality
308         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
309         (Bugzilla.add_keyword_to_bug): Add logic to add keywords using the changeform
310         * Scripts/webkitpy/tool/commands/upload.py:
311         (Upload): Teach the upload step how to add radar information when creating a new bug.
312         * Scripts/webkitpy/tool/steps/__init__.py:
313         * Scripts/webkitpy/tool/steps/addradar.py: Added.
314         (AddRadar):
315         (AddRadar.run): Contains the logic to add the radar information to bugzilla.
316         * Scripts/webkitpy/tool/steps/createbug.py:
317         (CreateBug.run): set a "created_new_bug" state when creating a new bugzilla bug.
318
319 2018-08-07  Wenson Hsieh  <wenson_hsieh@apple.com>
320
321         Post-review feedback after r234614.
322         https://bugs.webkit.org/show_bug.cgi?id=188322
323         <rdar://problem/42455270>
324
325         Reviewed by Sam Weinig.
326
327         Use std::round instead of roundl — there's no reason to go from double to long double precision when rounding.
328
329         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
330         (rounded):
331
332 2018-08-07  Don Olmstead  <don.olmstead@sony.com>
333
334         [MiniBrowser][Win] Allow selection of recent user agents
335         https://bugs.webkit.org/show_bug.cgi?id=188371
336
337         Reviewed by Fujii Hironori.
338
339         Updates the user agent spoofing strings to the latest released
340         versions and adds Microsoft Edge's user agent.
341
342         Moves the menu item selection to the common base class, BrowserWindow
343         to support user agent spoofing in a WebKitLegacyBrowserWindow and
344         WebKitBrowserWindow.
345
346         * MiniBrowser/win/BrowserWindow.cpp: Added.
347         (BrowserWindow::setUserAgent):
348         * MiniBrowser/win/BrowserWindow.h:
349         * MiniBrowser/win/CMakeLists.txt:
350         * MiniBrowser/win/MainWindow.cpp:
351         (MainWindow::toggleMenuItem):
352         * MiniBrowser/win/MiniBrowserLib.rc:
353         * MiniBrowser/win/MiniBrowserLibResource.h:
354         * MiniBrowser/win/WebKitBrowserWindow.cpp:
355         * MiniBrowser/win/WebKitBrowserWindow.h:
356         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
357         (WebKitLegacyBrowserWindow::setUserAgent):
358         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
359
360 2018-08-07  Yusuke Suzuki  <utatane.tea@gmail.com>
361
362         Unreviewed, add a new address to my configuration
363
364         * Scripts/webkitpy/common/config/contributors.json:
365
366 2018-08-06  David Quesada  <david_quesada@apple.com>
367
368         webkitdirs.pm should default to iPhone SE for 64-bit testing
369         https://bugs.webkit.org/show_bug.cgi?id=188361
370
371         Reviewed by Daniel Bates.
372
373         Use iPhone SE as the default iOS Simulator device type. This corresponds to the change to webkitpy in r234467.
374
375         * Scripts/webkitdirs.pm:
376         (findOrCreateSimulatorForIOSDevice):
377         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
378         (parse_args):
379             Update the help text for --device-type to reflect the new default device.
380
381 2018-08-06  Wenson Hsieh  <wenson_hsieh@apple.com>
382
383         [iOS] Caret disappears after resigning and becoming first responder if active focus state is retained
384         https://bugs.webkit.org/show_bug.cgi?id=188322
385         <rdar://problem/42455270>
386
387         Reviewed by Tim Horton.
388
389         Fixes an API test added in r234600, which had incorrect test expectations — namely, the width of the caret rect
390         was not in content view coordinates, unlike the x, y, and height.
391
392         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
393         (rounded):
394         (-[TestWKWebView waitForCaretViewFrameToBecome:]):
395         (-[TestWKWebView waitForSelectionViewRectsToBecome:]):
396         (TestWebKitAPI::TEST):
397
398 2018-08-06  Ryan Haddad  <ryanhaddad@apple.com>
399
400         Unreviewed, rolling out r234569.
401
402         Breaks internal builds.
403
404         Reverted changeset:
405
406         "We should cache the compiled sandbox profile in a data vault"
407         https://bugs.webkit.org/show_bug.cgi?id=184991
408         https://trac.webkit.org/changeset/234569
409
410 2018-08-06  Fujii Hironori  <Hironori.Fujii@sony.com>
411
412         [Win][DLLLauncher] Remove --highDPI switch
413         https://bugs.webkit.org/show_bug.cgi?id=188255
414
415         Reviewed by Yusuke Suzuki.
416
417         Bug 149417 has added `--highDPI` switch to make MiniBrowser DPI
418         aware. But, Bug 158733 has made MiniBrowser always DPI aware. It
419         became useless since the change. Remove the switch.
420
421         This change fixes the issue all dump render tree tests are failing
422         in WinCairo port if high DPI display is connected.
423
424         * MiniBrowser/win/Common.cpp:
425         (parseCommandLine): Removed `--highDPI` switch.
426         * win/DLLLauncher/DLLLauncherMain.cpp:
427         (wWinMain): Do not call SetProcessDPIAware.
428         (shouldUseHighDPI): Deleted.
429
430 2018-08-06  Wenson Hsieh  <wenson_hsieh@apple.com>
431
432         [iOS] Tests that try to interact with the QuickType bar time out on iOS 11+
433         https://bugs.webkit.org/show_bug.cgi?id=188335
434         <rdar://problem/32542437> and <rdar://problem/32542433>
435
436         Reviewed by Tim Horton.
437
438         Remove a UIScriptController helper method that attempted to wait for QuickType buttons to appear, and then send
439         touch events to the buttons. These were only used for the two tests which this patch refactors. See the
440         LayoutTests ChangeLog for more detail.
441
442         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
443         (WTR::UIScriptController::selectTextCandidateAtIndex): Deleted.
444         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
445         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
446         (WTR::UIScriptController::selectTextCandidateAtIndex): Deleted.
447         (WTR::UIScriptController::waitForTextPredictionsViewAndSelectCandidateAtIndex): Deleted.
448         * TestRunnerShared/UIScriptContext/UIScriptController.h:
449         * TestRunnerShared/spi/UIKitTestSPI.h:
450
451         Remove an internal class declaration that is now unnecessary.
452
453         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
454         (WTR::UIScriptController::selectTextCandidateAtIndex): Deleted.
455         (WTR::UIScriptController::waitForTextPredictionsViewAndSelectCandidateAtIndex): Deleted.
456
457 2018-08-06  Wenson Hsieh  <wenson_hsieh@apple.com>
458
459         [iOS] Caret disappears after resigning and becoming first responder if active focus state is retained
460         https://bugs.webkit.org/show_bug.cgi?id=188322
461         <rdar://problem/42455270>
462
463         Reviewed by Tim Horton.
464
465         Adds plumbing in UIScriptController to grab the start and end selection handle rects for use in the new layout
466         test. Also adds new API tests to verify that when a web view resigns first responder, both caret and range
467         selection views are hidden, and when first responder status is restored, both caret and range selection views
468         are made visible again.
469
470         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
471         (WTR::UIScriptController::selectionStartGrabberViewRect const):
472         (WTR::UIScriptController::selectionEndGrabberViewRect const):
473         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
474         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
475         (WTR::UIScriptController::selectionStartGrabberViewRect const):
476         (WTR::UIScriptController::selectionEndGrabberViewRect const):
477         * TestRunnerShared/UIScriptContext/UIScriptController.h:
478         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
479         (-[TestWKWebView waitForCaretViewFrameToBecome:]):
480         (-[TestWKWebView waitForSelectionViewRectsToBecome:]):
481         (webViewWithAutofocusedInput):
482
483         Pull out some common logic for creating a web view that allows programmatic focus to present the keyboard, and
484         immediately loading a web page with an autofocusing text field.
485
486         (TestWebKitAPI::TEST):
487         * TestWebKitAPI/cocoa/TestWKWebView.h:
488         * TestWebKitAPI/cocoa/TestWKWebView.mm:
489         (-[TestWKWebView caretViewRectInContentCoordinates]):
490         (-[TestWKWebView selectionViewRectsInContentCoordinates]):
491         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
492         (WTR::UIScriptController::selectionStartGrabberViewRect const):
493         (WTR::UIScriptController::selectionEndGrabberViewRect const):
494
495 2018-08-06  Wenson Hsieh  <wenson_hsieh@apple.com>
496
497         [iOS] Layout tests that send HID events cause WebKitTestRunner to crash on recent SDKs
498         https://bugs.webkit.org/show_bug.cgi?id=188334
499         <rdar://problem/40630074>
500
501         Reviewed by Tim Horton.
502
503         To mark the end of previously dispatched IOHID events, HIDEventGenerator currently sends a vendor-defined event
504         and stores the completion callback ID for the previously dispatched events as vendor-defined data. When this
505         vendor-defined marker event is handled by the application, we then read the callback ID back from the event, map
506         it to a completion block, and invoke the completion block to signal that the previous HID event has been
507         processed.
508
509         This callback ID is an unsigned, so we tell IOKit that we need `sizeof(unsigned)` (4 bytes) to store it. On
510         shipping software, IOKit clamps this to a minimum of 8 bytes, i.e. `sizeof(CFIndex)`. When we later call
511         IOHIDEventGetIntegerValue to read the value of our vendor-defined data as a CFIndex, we get our expected
512         callback ID because the buffer was clamped to 8 bytes.
513
514         However, on recent iOS SDKs that contain the fix for <rdar://problem/20082284>, IOKit no longer clamps the size
515         of the vendor-defined data buffer to 8 bytes. This means that when we try to use IOHIDEventGetIntegerValue to
516         read our callback ID back, we end up getting a CFIndex where the lower 4 bytes are the callback ID we wrote, and
517         the upper 4 bytes are garbage. In the case where any of these upper 4 bytes are non-zero, we fail to map the
518         callback ID to a completion handler, and so we never finish dispatching the HID event, causing an exception to
519         be thrown.
520
521         To fix this, we adjust callback ID to be a CFIndex, which matches IOHIDEventGetIntegerValue's return type.
522
523         * WebKitTestRunner/ios/HIDEventGenerator.mm:
524         (+[HIDEventGenerator nextEventCallbackID]):
525         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
526
527         Also refactor a bit of `-_sendMarkerHIDEventWithCompletionBlock:` by using auto and move semantics.
528
529 2018-08-03  Ben Richards  <benton_richards@apple.com>
530
531         We should cache the compiled sandbox profile in a data vault
532         https://bugs.webkit.org/show_bug.cgi?id=184991
533
534         Reviewed by Ryosuke Niwa.
535
536         Added trace points for sandbox initialization
537
538         * Tracing/SystemTracePoints.plist:
539
540 2018-08-03  David Fenton  <david_fenton@apple.com>
541
542         Unreviewed, rolling out r234517.
543
544         Caused API test failures on iOS
545
546         Reverted changeset:
547
548         "[Cocoa] setCookie API fails to set session cookies for
549         defaultDataStore if processPool created but not used"
550         https://bugs.webkit.org/show_bug.cgi?id=188209
551         https://trac.webkit.org/changeset/234517
552
553 2018-08-03  Ben Richards  <benton_richards@apple.com>
554
555         Add configuration for automatic process pre-warming
556         https://bugs.webkit.org/show_bug.cgi?id=187108
557
558         Reviewed by Ryosuke Niwa.
559
560         Added new test case for setting maximum prewarmed process count and updated test case for process swap on navigation to set the maximum prewarmed process count to be 1 where relevant.
561
562         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
563         * TestWebKitAPI/Tests/WebKitCocoa/InitialWarmedProcessUsed.mm:
564         (TEST):
565         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
566         * TestWebKitAPI/Tests/WebKitCocoa/SetMaximumPrewarmedProcessCount.mm:
567         (TEST):
568
569 2018-08-03  Aakash Jain  <aakash_jain@apple.com>
570
571         [ews-build] Add build step to Check Patch Relevance
572         https://bugs.webkit.org/show_bug.cgi?id=188295
573
574         Reviewed by Lucas Forschler.
575
576         * BuildSlaveSupport/ews-build/steps.py:
577         (CheckPatchRelevance): Added step to check patch relevance.
578         (CheckPatchRelevance._patch_is_relevant): Checks if the patch is relevant.
579         (CheckPatchRelevance._get_patch): Retrieves the patch from buildbot.
580         (CheckPatchRelevance._addToLog): Add the log message.
581         (CheckPatchRelevance.start):
582         * BuildSlaveSupport/ews-build/factories.py: Added CheckPatchRelevance step appropriately.
583
584 2018-08-03  Jer Noble  <jer.noble@apple.com>
585
586         Unreviewed gardening; r234534 changed the policy for what audio session is set when a
587         media element is paused. Updating the test to reflect the new policy.
588
589         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
590         (TestWebKitAPI::TEST):
591
592 2018-08-03  Zalan Bujtas  <zalan@apple.com>
593
594         [LFC][Floating] Now that the document renderer belongs to "complicated cases", adjust viewport stretching.
595         https://bugs.webkit.org/show_bug.cgi?id=188306
596
597         Reviewed by Antti Koivisto.
598
599         * LayoutReloaded/misc/LFC-passing-tests.txt:
600
601 2018-08-03  Carlos Garcia Campos  <cgarcia@igalia.com>
602
603         [WPE] Use the new key mapper API from WPEBackend
604         https://bugs.webkit.org/show_bug.cgi?id=188216
605
606         Reviewed by Žan Doberšek.
607
608         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
609         (WTR::EventSenderProxy::keyDown): Use wpe_input_xkb_context_get_entries_for_key_code() to get the hardware key
610         code.
611         * wpe/backends/WindowViewBackend.cpp:
612         (WPEToolingBackends::WindowViewBackend::WindowViewBackend):
613         (WPEToolingBackends::WindowViewBackend::handleKeyEvent):
614         (WPEToolingBackends::WindowViewBackend::modifiers const):
615         * wpe/backends/WindowViewBackend.h:
616
617 2018-08-03  Carlos Garcia Campos  <cgarcia@igalia.com>
618
619         [WPE] Implement MouseEvent.buttons
620         https://bugs.webkit.org/show_bug.cgi?id=187998
621
622         Reviewed by Žan Doberšek.
623
624         Pass modifiers to mouse events.
625
626         * WebKitTestRunner/EventSenderProxy.h:
627         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
628         (WTR::senderButtonToWPEButton):
629         (WTR::modifierForButton):
630         (WTR::EventSenderProxy::mouseDown):
631         (WTR::EventSenderProxy::mouseUp):
632         (WTR::EventSenderProxy::mouseMoveTo):
633         (WTR::EventSenderProxy::mouseScrollBy):
634         (WTR::wkEventModifiersToWPE):
635         (WTR::wpeKeySymForKeyRef):
636         (WTR::EventSenderProxy::keyDown):
637         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
638         * wpe/backends/WindowViewBackend.cpp:
639         (WPEToolingBackends::WindowViewBackend::handleKeyEvent):
640         (WPEToolingBackends::WindowViewBackend::modifiers const):
641         * wpe/backends/WindowViewBackend.h:
642
643 2018-08-03  Carlos Garcia Campos  <cgarcia@igalia.com>
644
645         [WPE] Use WPE key symbols and new API instead of xkbcommon and the key mapper
646         https://bugs.webkit.org/show_bug.cgi?id=188093
647
648         Reviewed by Žan Doberšek.
649
650         * MiniBrowser/wpe/main.cpp: Use WPE key symbols.
651         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
652         (WTR::wpeKeySymForKeyRef): Use WPE key symbols and wpe_unicode_to_key_code().
653         (WTR::EventSenderProxy::keyDown): Do not set unicode char to the event since it was removed.
654         * flatpak/org.webkit.WPE.yaml: Bump WPEBackend and WPEBackend-fdo versions.
655         * wpe/backends/WindowViewBackend.cpp:
656         (WPEToolingBackends::WindowViewBackend::handleKeyEvent): Do not set unicode char to the event since it was removed.
657         * wpe/jhbuild.modules: Bump WPEBackend and WPEBackend-fdo versions.
658
659 2018-08-02  Nan Wang  <n_wang@apple.com>
660
661         AX: [iOS] add support to return the attributed string under the element
662         https://bugs.webkit.org/show_bug.cgi?id=188276
663         <rdar://problem/42872357>
664
665         Reviewed by Chris Fleizach.
666
667         * DumpRenderTree/AccessibilityUIElement.cpp:
668         (attributedStringForElementCallback):
669         (AccessibilityUIElement::getJSClass):
670         * DumpRenderTree/AccessibilityUIElement.h:
671         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
672         (AccessibilityUIElement::attributedStringForElement):
673         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
674         (WTR::AccessibilityUIElement::attributedStringForElement):
675         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
676         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
677         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
678         (WTR::AccessibilityUIElement::attributedStringForElement):
679
680 2018-08-02  Ryan Haddad  <ryanhaddad@apple.com>
681
682         Skip API test DataInteractionTests.CustomActionSheetPopover on current SDKs.
683         https://bugs.webkit.org/show_bug.cgi?id=175204
684
685         Unreviewed test gardening.
686
687         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
688
689 2018-08-02  Sihui Liu  <sihui_liu@apple.com>
690
691         [Cocoa] setCookie API fails to set session cookies for defaultDataStore if processPool created but not used
692         https://bugs.webkit.org/show_bug.cgi?id=188209
693
694         Reviewed by Geoffrey Garen.
695
696         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
697         (TEST):
698
699 2018-08-02  Dan Bernstein  <mitz@apple.com>
700
701         Fixed WebKit.AttrStyle timing out on build.webkit.org.
702
703         * TestWebKitAPI/Tests/WebKitCocoa/AttrStyle.html: Changed from a URL that requires network
704           access to one that doesn’t.
705         * TestWebKitAPI/Tests/WebKitCocoa/AttrStyle.mm:
706         (TEST): Updated expected value.
707
708 2018-08-02  Wenson Hsieh  <wenson_hsieh@apple.com>
709
710         [iOS] Keyboard becomes unresponsive after pressing delete while pressing down on a character key with accents
711         https://bugs.webkit.org/show_bug.cgi?id=188251
712         <rdar://problem/37842108>
713
714         Reviewed by Tim Horton.
715
716         Adds a new API test to verify that clients (in this case, UIKit) is allowed to invoke
717         -handleKeyWebEvent:withCompletionHandler: within the completion block of a prior invocation.
718
719         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
720         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm: Added.
721         (TestWebKitAPI::TEST):
722         * TestWebKitAPI/Tests/ios/TestInputDelegate.h: Added.
723
724         Pull some logic used to force an input session to start out from an existing API test file
725         (WKWebViewAutofillTests) and into a separate helper class that is used by both the existing API tests and the
726         new keyboard input test.
727
728         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
729         (-[AutofillTestView initWithFrame:]):
730         (TestWebKitAPI::TEST):
731         (-[TestInputDelegate init]): Deleted.
732         (-[TestInputDelegate _webView:focusShouldStartInputSession:]): Deleted.
733         * TestWebKitAPI/ios/UIKitSPI.h:
734
735         Add some UIKit SPI utilized by the new API test.
736
737 2018-08-01  Dan Bernstein  <mitz@apple.com>
738
739         Optionally expose Attr::style to JavaScript
740         https://bugs.webkit.org/show_bug.cgi?id=188226
741         <rdar://problem/42818113>
742
743         Reviewed by Darin Adler.
744
745         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
746         * TestWebKitAPI/Tests/WebKitCocoa/AttrStyle.html: Added.
747         * TestWebKitAPI/Tests/WebKitCocoa/AttrStyle.mm: Added.
748         (TEST):
749
750 2018-08-02  David Fenton  <david_fenton@apple.com>
751
752         Unreviewed, rolling out r234489.
753
754         Caused 50+ crashes and 60+ API failures on iOS
755
756         Reverted changeset:
757
758         "[WTF] Rename String::format to String::deprecatedFormat"
759         https://bugs.webkit.org/show_bug.cgi?id=188191
760         https://trac.webkit.org/changeset/234489
761
762 2018-08-01  Ross Kirsling  <ross.kirsling@sony.com>
763
764         TestWTF.WTF_NeverDestroyed.Construct output differs for MSVC in Debug mode
765         https://bugs.webkit.org/show_bug.cgi?id=188244
766
767         Reviewed by Daniel Bates.
768
769         Follow-up to r234179. MSVC chooses not to inline the lambda in Debug mode. 
770
771         * TestWebKitAPI/Tests/WTF/NeverDestroyed.cpp:
772
773 2018-08-01  Tomas Popela  <tpopela@redhat.com>
774
775         [WTF] Rename String::format to String::deprecatedFormat
776         https://bugs.webkit.org/show_bug.cgi?id=188191
777
778         Reviewed by Darin Adler.
779
780         It should be replaced with string concatenation.
781
782         * DumpRenderTree/win/DumpRenderTree.cpp:
783         (applicationId):
784         (main):
785         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
786         (TestWebKitAPI::Util::createURLForResource):
787         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
788         (WTR::cacheTestRunnerCallback):
789         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
790         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
791         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
792         (WTR::AccessibilityUIElement::attributedStringForRange):
793         (WTR::AccessibilityUIElement::url):
794         (WTR::stringAtOffset):
795         * WebKitTestRunner/TestController.cpp:
796         (WTR::TestController::didReceiveAuthenticationChallenge):
797         (WTR::TestController::downloadDidFail):
798         (WTR::originUserVisibleName):
799         (WTR::userMediaOriginHash):
800         (WTR::TestController::didNavigateWithNavigationData):
801         (WTR::TestController::didPerformClientRedirect):
802         (WTR::TestController::didPerformServerRedirect):
803         (WTR::TestController::didUpdateHistoryTitle):
804
805 2018-08-01  Nan Wang  <n_wang@apple.com>
806
807         AX: AOM: Add ARIA IDL Attribute Reflection
808         https://bugs.webkit.org/show_bug.cgi?id=184676
809         <rdar://problem/39476882>
810
811         Reviewed by Chris Fleizach.
812
813         * DumpRenderTree/mac/DumpRenderTree.mm:
814         (enableExperimentalFeatures):
815         * WebKitTestRunner/TestController.cpp:
816         (WTR::TestController::resetPreferencesToConsistentValues):
817
818 2018-08-01  Jonathan Bedard  <jbedard@apple.com>
819
820         Use iPhone SE as the default simulated device
821         https://bugs.webkit.org/show_bug.cgi?id=188227
822
823         Reviewed by Aakash Jain.
824
825         * Scripts/webkitpy/port/ios_simulator.py:
826         (IOSSimulatorPort):
827
828 2018-08-01  Commit Queue  <commit-queue@webkit.org>
829
830         Unreviewed, rolling out r234443 and r234445.
831         https://bugs.webkit.org/show_bug.cgi?id=188224
832
833         Revision caused 3 api failures across all platforms.
834         (Requested by Truitt on #webkit).
835
836         Reverted changesets:
837
838         "Add configuration for automatic process pre-warming"
839         https://bugs.webkit.org/show_bug.cgi?id=187108
840         https://trac.webkit.org/changeset/234443
841
842         "Add configuration for automatic process pre-warming"
843         https://bugs.webkit.org/show_bug.cgi?id=187108
844         https://trac.webkit.org/changeset/234445
845
846 2018-07-31  Ben Richards  <benton_richards@apple.com>
847
848         Add configuration for automatic process pre-warming
849         https://bugs.webkit.org/show_bug.cgi?id=187108
850
851         Reviewed by Ryosuke Niwa.
852
853         Added new test case for setting maximum prewarmed process count and updated test case for process swap on navigation to set the maximum prewarmed process count to be 1 where relevant.
854
855         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
856         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
857         * TestWebKitAPI/Tests/WebKitCocoa/SetMaximumPrewarmedProcessCount.mm: Added.
858         (TEST):
859
860 2018-07-31  John Wilander  <wilander@apple.com>
861
862         Resource Load Statistics: Remove partitioned cookies for reduced complexity, lower memory footprint, and ability to support more platforms
863         https://bugs.webkit.org/show_bug.cgi?id=188109
864         <rdar://problem/42664391>
865
866         Reviewed by Brent Fulgham, Chris Dumez, and Alex Christensen.
867
868         This patch removes cookie partitioning which reduces the model to just
869         blocked cookies (in third-party contexts) and first-party cookie access.
870
871         Several of the changes are renaming to reflect that there are no more
872         cookie partitions.
873
874         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
875            Removed or renamed functions to reflect that there are no more
876            partitioned cookies.
877         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
878         (WTR::InjectedBundle::didReceiveMessageToPage):
879         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
880         (WTR::TestRunner::statisticsUpdateCookieBlocking):
881         (WTR::TestRunner::statisticsCallDidSetBlockCookiesForHostCallback):
882         (WTR::TestRunner::setCookieStoragePartitioningEnabled): Deleted.
883         (WTR::TestRunner::setStatisticsHasHadNonRecentUserInteraction): Deleted.
884         (WTR::TestRunner::setStatisticsTimeToLiveCookiePartitionFree): Deleted.
885         (WTR::TestRunner::statisticsUpdateCookiePartitioning): Deleted.
886         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost): Deleted.
887         (WTR::TestRunner::statisticsCallDidSetPartitionOrBlockCookiesForHostCallback): Deleted.
888         * WebKitTestRunner/InjectedBundle/TestRunner.h:
889         * WebKitTestRunner/TestController.cpp:
890         (WTR::TestController::statisticsUpdateCookieBlocking):
891         (WTR::TestController::setStatisticsHasHadNonRecentUserInteraction): Deleted.
892         (WTR::TestController::setStatisticsTimeToLiveCookiePartitionFree): Deleted.
893         (WTR::TestController::statisticsUpdateCookiePartitioning): Deleted.
894         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost): Deleted.
895         * WebKitTestRunner/TestController.h:
896         * WebKitTestRunner/TestInvocation.cpp:
897         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
898         (WTR::TestInvocation::didSetBlockCookiesForHost):
899         (WTR::TestInvocation::didSetHasHadUserInteraction):
900         (WTR::TestInvocation::didSetPartitionOrBlockCookiesForHost): Deleted.
901         (WTR::TestInvocation::didSetHasHadNonRecentUserInteraction): Deleted.
902         * WebKitTestRunner/TestInvocation.h:
903         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
904         (WTR::initializeWebViewConfiguration):
905
906 2018-07-31  Alex Christensen  <achristensen@webkit.org>
907
908         Build fix.  Remove unused variable.
909
910         * TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp:
911         (TestWebKitAPI::TEST):
912         transform was never used. It was introduced in r205871
913         Apparently I'm the first one to build in a certain configuration that found it.
914
915 2018-07-31  Fujii Hironori  <Hironori.Fujii@sony.com>
916
917         server_process.py should print returncode in debug log if the process crashed
918         https://bugs.webkit.org/show_bug.cgi?id=188160
919
920         Reviewed by Konstantin Tokarev.
921
922         * Scripts/webkitpy/port/server_process.py:
923         (ServerProcess.has_crashed): Put self._proc.returncode into the debug log message.
924
925 2018-07-31  Tomas Popela  <tpopela@redhat.com>
926
927         [WTF] String::formatWithArguments() is unused
928         https://bugs.webkit.org/show_bug.cgi?id=187955
929
930         Reviewed by Darin Adler.
931
932         Remove tests for WTF::String::formatWithArguments() as it's unused and
933         we are removing it.
934
935         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
936
937 2018-07-30  Aakash Jain  <aakash_jain@apple.com>
938
939         [ews-build] Fix typo in builder name for Bindings-tests-EWS.
940
941         * BuildSlaveSupport/ews-build/config.json: Changed 'tests' to 'Tests' to make it consistent with
942         other builders.
943
944 2018-07-30 Aakash Jain  <aakash_jain@apple.com>
945
946         [ews-build] Add support for API tests in OpenSource EWS
947         https://bugs.webkit.org/show_bug.cgi?id=188156
948
949         Reviewed by Lucas Forschler.
950
951         * BuildSlaveSupport/ews-build/config.json:
952         * BuildSlaveSupport/ews-build/factories.py:
953         (BuildFactory.__init__): Added triggers parameter.
954         (BuildFactory): If trigger is defined, create and upload archive and trigger appropriate queues.
955         (BuildFactory.propertiesToPassToTriggers): Pass all the required properties to triggered queue.
956         (APITestsFactory): Factory for running API tests.
957         * BuildSlaveSupport/ews-build/steps.py:
958         (ConfigureBuild.start): Set the property only if property is defined in config.json. Also set the 
959         source of the property.
960
961 2018-07-30  Aakash Jain  <aakash_jain@apple.com>
962
963         [ews-build] loadConfig should ensure that the triggers are valid
964         https://bugs.webkit.org/show_bug.cgi?id=188134
965
966         Reviewed by Lucas Forschler.
967
968         * BuildSlaveSupport/ews-build/loadConfig.py:
969         (checkValidBuilder): Added a check to ensure that the builder doesn't refernce non-existing scheduler.
970         (checkValidSchedulers): Ensures that the scheduler is not un-used.
971         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
972
973 2018-07-27  Michael Catanzaro  <mcatanzaro@igalia.com>
974
975         Unreviewed, fix typo in test expectations and mark another test as timing out
976
977         * TestWebKitAPI/glib/TestExpectations.json:
978
979 2018-07-27  Michael Catanzaro  <mcatanzaro@igalia.com>
980
981         More unreviewed GTK test gardening
982
983         * TestWebKitAPI/glib/TestExpectations.json:
984
985 2018-07-27  Simon Fraser  <simon.fraser@apple.com>
986
987         Be more conservative with compositing layer creation when memory is low
988         https://bugs.webkit.org/show_bug.cgi?id=187866
989         rdar://problem/42366345
990
991         Reviewed by Zalan Bujtas.
992         
993         When process physical footprint is above a fraction of the jetsam limit, be more conservative in making
994         compositing layers. We avoid compositing for these situations:
995         1. Layers with 3D transforms which are affine (like translateZ(0)).
996         2. Layers with will-change
997         3. Layers for canvases (other than WebGL/WebGPU)
998         
999         We reuse some macOS code in MemoryPressureHandler() but choose different thresholds for iOS,
1000         falling into "conservative mode" at 50% of jetsam limit, and "strict mode" at 65%.
1001         Compositing chooses to be more conservative in either "conservative" or "strict" memory modes.
1002         
1003         Plumb through a "compositingPolicyOverride" both so that on-device testing isn't
1004         flakily falling into a different mode, and so that we can impose the conservative
1005         mode for testing.
1006
1007         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1008         (WTR::InjectedBundlePage::prepare):
1009
1010 2018-07-27  Michael Catanzaro  <mcatanzaro@igalia.com>
1011
1012         Unreviewed GTK test gardening
1013
1014         * TestWebKitAPI/glib/TestExpectations.json:
1015
1016 2018-07-27  Alex Christensen  <achristensen@webkit.org>
1017
1018         Fix API tests after r234314
1019         https://bugs.webkit.org/show_bug.cgi?id=188077
1020
1021         Make API tests use new delegate method.
1022
1023         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1024         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1025         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
1026
1027 2018-07-27  Alex Christensen  <achristensen@webkit.org>
1028
1029         Fix API tests after r234314
1030         https://bugs.webkit.org/show_bug.cgi?id=188077
1031
1032         Make API tests use new delegate method.
1033
1034         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1035         (-[ContentBlockingWebsitePoliciesDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1036         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1037         (-[AsyncAutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1038         (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1039         (-[PopUpPoliciesDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1040         (-[ContentBlockingWebsitePoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
1041         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
1042         (-[AsyncAutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
1043         (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
1044         (-[PopUpPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
1045
1046 2018-07-26  Andy VanWagoner  <andy@vanwagoner.family>
1047
1048         [INTL] Remove INTL sub-feature compile flags
1049         https://bugs.webkit.org/show_bug.cgi?id=188081
1050
1051         Reviewed by Michael Catanzaro.
1052
1053         * Scripts/webkitperl/FeatureList.pm:
1054         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1055
1056 2018-07-26  Chris Dumez  <cdumez@apple.com>
1057
1058         Loading a file URL and then issuing a reload right away causes the load to fail due to sandboxing
1059         https://bugs.webkit.org/show_bug.cgi?id=188078
1060         <rdar://problem/42562493>
1061
1062         Reviewed by Geoff Garen.
1063
1064         Add API test coverage. It exercises the right code path but unfortunately is not yet a regression
1065         test because TestWebKitAPI does not appear to be sandboxed (rdar://problem/42638129).
1066
1067         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1068         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileThenReload.mm: Added.
1069         (-[LoadFileThenReloadDelegate webView:didFinishNavigation:]):
1070         (-[LoadFileThenReloadDelegate webView:didFailProvisionalNavigation:withError:]):
1071         (-[LoadFileThenReloadDelegate webView:didFailNavigation:withError:]):
1072         (TEST):
1073
1074 2018-07-26  Aaron Chu  <aaron_chu@apple.com>
1075
1076         Add Aaron Chu as a committer to contributors.json
1077         https://bugs.webkit.org/show_bug.cgi?id=188066
1078
1079         Unreviwed. Added myself as committer.
1080
1081         * Scripts/webkitpy/common/config/contributors.json:
1082
1083 2018-07-26  Aakash Jain  <aakash_jain@apple.com>
1084
1085         [ews-build] Add build step to run API Tests
1086         https://bugs.webkit.org/show_bug.cgi?id=188079
1087
1088         Reviewed by Lucas Forschler.
1089
1090         * BuildSlaveSupport/ews-build/steps.py:
1091         (TestWithFailureCount): Common class for various tests with failure count.
1092         (TestWithFailureCount.start): Configure Buildbot's logobserver.
1093         (TestWithFailureCount.commandComplete): Updates the failure count.
1094         (TestWithFailureCount.evaluateCommand): Set the step status appropriately.
1095         (TestWithFailureCount.getResultSummary): Set the step summary appropriately.
1096         (RunAPITests): Build step to run API tests.
1097         (RunAPITests.countFailures): Count the failures by parsing the output.
1098         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1099
1100 2018-07-26  Ross Kirsling  <ross.kirsling@sony.com>
1101
1102         String(View) should have a splitAllowingEmptyEntries function instead of a flag parameter
1103         https://bugs.webkit.org/show_bug.cgi?id=187963
1104
1105         Reviewed by Alex Christensen.
1106
1107         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1108         Add tests for String::split and String::splitAllowingEmptyEntries.
1109
1110         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1111         * WebKitTestRunner/TestController.cpp:
1112         (WTR::updateTestOptionsFromTestHeader):
1113         Update split/splitAllowingEmptyEntries usage.
1114
1115 2018-07-26  Commit Queue  <commit-queue@webkit.org>
1116
1117         Unreviewed, rolling out r234181 and r234189.
1118         https://bugs.webkit.org/show_bug.cgi?id=188075
1119
1120         These are not needed right now (Requested by thorton on
1121         #webkit).
1122
1123         Reverted changesets:
1124
1125         "Enable Web Content Filtering on watchOS"
1126         https://bugs.webkit.org/show_bug.cgi?id=187979
1127         https://trac.webkit.org/changeset/234181
1128
1129         "HAVE(PARENTAL_CONTROLS) should be true on watchOS"
1130         https://bugs.webkit.org/show_bug.cgi?id=187985
1131         https://trac.webkit.org/changeset/234189
1132
1133 2018-07-04  Darin Adler  <darin@apple.com>
1134
1135         Improve WebGPU implementation, including using Metal Objective-C protocols more simply and correctly
1136         https://bugs.webkit.org/show_bug.cgi?id=187333
1137
1138         Reviewed by Sam Weinig.
1139
1140         * TestWebKitAPI/Tests/WebCore/mac/GPUBuffer.mm: Updated.
1141         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Updated.
1142         * TestWebKitAPI/Tests/WebCore/mac/GPUDevice.mm: Updated.
1143         * TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm: Updated.
1144         * TestWebKitAPI/Tests/WebCore/mac/GPULibrary.mm: Updated.
1145
1146 2018-07-25  Aakash Jain  <aakash_jain@apple.com>
1147
1148         [ews-build] Add build steps DownloadBuiltProduct and ExtractBuiltProduct
1149         https://bugs.webkit.org/show_bug.cgi?id=188031
1150
1151         Reviewed by Lucas Forschler.
1152
1153         * BuildSlaveSupport/ews-build/steps.py:
1154         (DownloadBuiltProduct): Added build step DownloadBuiltProduct.
1155         (ExtractBuiltProduct): Added build step ExtractBuiltProduct.
1156         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1157
1158 2018-07-25  Aakash Jain  <aakash_jain@apple.com>
1159
1160         [ews-build] Add build step UploadBuiltProduct
1161         https://bugs.webkit.org/show_bug.cgi?id=188016
1162
1163         Reviewed by Lucas Forschler.
1164
1165         * BuildSlaveSupport/ews-build/steps.py:
1166         (UploadBuiltProduct): Added build step UploadBuiltProduct.
1167         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test.
1168
1169 2018-07-25  Aakash Jain  <aakash_jain@apple.com>
1170
1171         [ews-build] Add build step ArchiveBuiltProduct
1172         https://bugs.webkit.org/show_bug.cgi?id=188014
1173
1174         Reviewed by Lucas Forschler.
1175
1176         * BuildSlaveSupport/ews-build/steps.py:
1177         (ArchiveBuiltProduct): Added build step ArchiveBuiltProduct.
1178         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1179
1180 2018-07-25  Chris Dumez  <cdumez@apple.com>
1181
1182         navigator.userAgent may return outdated value after webView.customUserAgent is set
1183         https://bugs.webkit.org/show_bug.cgi?id=188009
1184         <rdar://problem/42566456>
1185
1186         Reviewed by Alex Christensen.
1187
1188         Add API test coverage.
1189
1190         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1191         * TestWebKitAPI/Tests/WebKitCocoa/CustomUserAgent.mm: Added.
1192         (TEST):
1193
1194 2018-07-25  Charlie Turner  <cturner@igalia.com>
1195
1196         [Flatpak] Pass more environment variables to sandbox
1197         https://bugs.webkit.org/show_bug.cgi?id=188002
1198
1199         Reviewed by Michael Catanzaro.
1200
1201         * flatpak/flatpakutils.py:
1202         (WebkitFlatpak.run_in_sandbox):
1203
1204 2018-07-25  Zan Dobersek  <zdobersek@igalia.com>
1205
1206         [WPE] Switch ViewBackend to using wpe_view_backend_exportable_fdo_egl APIs
1207         https://bugs.webkit.org/show_bug.cgi?id=187997
1208
1209         Reviewed by Carlos Garcia Campos.
1210
1211         Instead of the raw wpe_view_backend_exportable_fdo API, switch to using
1212         the EGL-oriented API that simply serves EGLImageKHR objects instead of
1213         raw buffer resources. This allows us not to wrangle with creating and
1214         managing lifetime of the same EGLImageKHR by ourselves.
1215
1216         ViewBackend now defines a wpe_view_backend_exportable_fdo_egl_client
1217         struct and uses wpe_view_backend_exportable_fdo_egl_create() to create
1218         the exportable object. This means that for each frame we're served an
1219         EGLImageKHR object that is passed on to the displayBuffer()
1220         implementation.
1221
1222         HeadlessViewBackend now just manages the pending and committed image
1223         objects. Width and height values used during pixel data retrieval are
1224         gathered from the ViewBackend's size that was specified when
1225         constructed.
1226
1227         WindowViewBackend similarly only manages the committed image object,
1228         not having to create an equivalent EGLImageKHR object from the raw
1229         buffer resource anymore.
1230
1231         Unused EGL entrypoints in both HeadlessViewBackend and WindowViewBackend
1232         classes are removed, and destructors for both classes are made virtual.
1233
1234         The WPEBackend-fdo version is bumped in order to have the EGL-specific
1235         export API available.
1236
1237         * flatpak/org.webkit.WPE.yaml:
1238         * wpe/backends/HeadlessViewBackend.cpp:
1239         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend):
1240         (WPEToolingBackends::HeadlessViewBackend::~HeadlessViewBackend):
1241         (WPEToolingBackends::HeadlessViewBackend::createSnapshot):
1242         (WPEToolingBackends::HeadlessViewBackend::performUpdate):
1243         (WPEToolingBackends::HeadlessViewBackend::displayBuffer):
1244         * wpe/backends/HeadlessViewBackend.h:
1245         * wpe/backends/ViewBackend.cpp:
1246         (WPEToolingBackends::ViewBackend::initialize):
1247         * wpe/backends/ViewBackend.h:
1248         * wpe/backends/WindowViewBackend.cpp:
1249         (WPEToolingBackends::WindowViewBackend::WindowViewBackend):
1250         (WPEToolingBackends::WindowViewBackend::~WindowViewBackend):
1251         (WPEToolingBackends::WindowViewBackend::displayBuffer):
1252         * wpe/backends/WindowViewBackend.h:
1253         * wpe/jhbuild.modules:
1254
1255 2018-07-24  Thomas Denney  <tdenney@apple.com>
1256
1257         Remove support for the double type from WHLSL
1258         https://bugs.webkit.org/show_bug.cgi?id=187977
1259
1260         Reviewed by Myles C. Maxfield.
1261
1262         * WebGPUShadingLanguageRI/All.js: Removed DoubleLiteral.js and DoubleLiteralType.js include.
1263         * WebGPUShadingLanguageRI/DoubleLiteral.js: Removed.
1264         * WebGPUShadingLanguageRI/DoubleLiteralType.js: Removed.
1265         * WebGPUShadingLanguageRI/Intrinsics.js: Removed double arithmetic functions.
1266         * WebGPUShadingLanguageRI/Parse.js:
1267         (parseTerm): Removed parsing of double literals.
1268         * WebGPUShadingLanguageRI/SPIRV.html: Removed DoubleLiteral.js and DoubleLiteralType.js include.
1269         * WebGPUShadingLanguageRI/SPIRVCodegen.js: Removed double type logic.
1270         * WebGPUShadingLanguageRI/StandardLibrary.js: Removed double type declarations.
1271         * WebGPUShadingLanguageRI/Test.html: Removed DoubleLiteral.js and DoubleLiteralType.js include.
1272         * WebGPUShadingLanguageRI/Test.js: Removed tests that test doubles or ported them to use floats.
1273         * WebGPUShadingLanguageRI/index.html: Removed DoubleLiteral.js and DoubleLiteralType.js include.
1274
1275 2018-07-24  Tim Horton  <timothy_horton@apple.com>
1276
1277         Enable Web Content Filtering on watchOS
1278         https://bugs.webkit.org/show_bug.cgi?id=187979
1279         <rdar://problem/42559346>
1280
1281         Reviewed by Wenson Hsieh.
1282
1283         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1284
1285 2018-07-24  Daniel Bates  <dabates@apple.com>
1286
1287         Move-constructing NeverDestroyed should move construct underlying object instead of copy constructing it
1288         https://bugs.webkit.org/show_bug.cgi?id=187971
1289
1290         Reviewed by Saam Barati.
1291
1292         Add unit tests to cover move constructing a NeverDestroyed with a non-const and const data type
1293         as well as invoking makeNeverDestroyed() with the result of a function that returns a move-only
1294         data type.
1295
1296         * TestWebKitAPI/CMakeLists.txt:
1297         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1298         * TestWebKitAPI/Tests/WTF/MoveOnlyLifecycleLogger.cpp: Added.
1299         (TestWebKitAPI::MoveOnlyLifecycleLogger::MoveOnlyLifecycleLogger):
1300         (TestWebKitAPI::MoveOnlyLifecycleLogger::~MoveOnlyLifecycleLogger):
1301         (TestWebKitAPI::MoveOnlyLifecycleLogger::operator=):
1302         (TestWebKitAPI::MoveOnlyLifecycleLogger::setName):
1303         (TestWebKitAPI::TEST):
1304         * TestWebKitAPI/Tests/WTF/MoveOnlyLifecycleLogger.h: Added.
1305         * TestWebKitAPI/Tests/WTF/NeverDestroyed.cpp:
1306         (TestWebKitAPI::TEST):
1307
1308 2018-07-24  Thomas Denney  <tdenney@apple.com>
1309         Minor changes to the WHLSL interpreter to support the new compiler
1310         https://bugs.webkit.org/show_bug.cgi?id=187728
1311
1312         Reviewed by Myles C. Maxfield.
1313
1314         This bug contains small changes that are make minor changes to the
1315         behaviour of the existing interpreter (the tests are unaffected and all
1316         still pass).
1317
1318         * WebGPUShadingLanguageRI/EnumType.js:
1319         (EnumType.prototype.get isEnum): Property added to EnumType and Type
1320         * WebGPUShadingLanguageRI/Evaluator.js: Correct typo
1321         * WebGPUShadingLanguageRI/Func.js:
1322         (Func.prototype.get isEntryPoint): Add boolean property
1323         * WebGPUShadingLanguageRI/FuncInstantiator.js:
1324         (FuncInstantiator.prototype.get instances): Public accessor for existing
1325         private field
1326         * WebGPUShadingLanguageRI/FunctionLikeBlock.js: Refactored the class so
1327         that it directly wraps a Func instance (therefore the only interface
1328         change is to the constructor and the addition of the func accessor).
1329         This change allows the de-inlining of functions.
1330         (FunctionLikeBlock):
1331         (FunctionLikeBlock.prototype.get func):
1332         (FunctionLikeBlock.prototype.get returnType):
1333         (FunctionLikeBlock.prototype.get parameters):
1334         (FunctionLikeBlock.prototype.get body):
1335         * WebGPUShadingLanguageRI/Inliner.js: Use the new FunctionLikeBlock
1336         constructor
1337         (Inliner.prototype.visitCallExpression):
1338         (Inliner):
1339         * WebGPUShadingLanguageRI/Intrinsics.js: Migrate the swizzle operators
1340         to native functions (with additional support in StandardLibrary.js).
1341         This reduces first-time compile-time from around 4s to around 0.1s.
1342         (Intrinsics):
1343         * WebGPUShadingLanguageRI/Lexer.js: Ensure that the parsing of multiline
1344         comments completes correctly
1345         (Lexer.prototype.next):
1346         (Lexer):
1347         * WebGPUShadingLanguageRI/MakeArrayRefExpression.js: Addition of type
1348         property, which is based on the type of the lValue and the semantics of
1349         the language (the @ operator yields an array reference with the thread
1350         scope).
1351         (MakeArrayRefExpression):
1352         (MakeArrayRefExpression.prototype.get type):
1353         * WebGPUShadingLanguageRI/NativeFunc.js: Add setter/getter for
1354         implementationData to support swizzle operator change
1355         (NativeFunc.prototype.get implementationData):
1356         (NativeFunc.prototype.set implementationData):
1357         * WebGPUShadingLanguageRI/Rewriter.js: Use new FunctionLikeBlock
1358         constructor
1359         (Rewriter.prototype.visitFunctionLikeBlock):
1360         * WebGPUShadingLanguageRI/StandardLibrary.js:
1361         (_generateSwizzle): Deleted.
1362         * WebGPUShadingLanguageRI/SwizzleOp.js: Introduces a new class for
1363         carrying metadata about swizzle operators so that they are implemented
1364         as native functions rather than generated at compile time.
1365         (SwizzleOp):
1366         (SwizzleOp.prototype.get outSize):
1367         (SwizzleOp.prototype.get components):
1368         (SwizzleOp.prototype.get inSize):
1369         (SwizzleOp.prototype.toString):
1370         (SwizzleOp.allSwizzleOperators.):
1371         (SwizzleOp.allSwizzleOperators):
1372         * WebGPUShadingLanguageRI/StandardLibrary.js: +        (SwizzleOp):
1373         (SwizzleOp.prototype.get outSize):
1374         (SwizzleOp.prototype.get components):
1375         (SwizzleOp.prototype.get inSize):
1376         (SwizzleOp.prototype.toString):
1377         (generateSwizzles):
1378         (_generateSwizzle): Deleted.
1379         * WebGPUShadingLanguageRI/Type.js: Addition of isEnum property, as
1380         above.
1381         (Type.prototype.get isEnum):
1382
1383 2018-07-24  Ryan Haddad  <ryanhaddad@apple.com>
1384
1385         Unreviewed, rolling out r234121.
1386
1387         Caused perf test failures.
1388
1389         Reverted changeset:
1390
1391         "We should cache the compiled sandbox profile in a data vault"
1392         https://bugs.webkit.org/show_bug.cgi?id=184991
1393         https://trac.webkit.org/changeset/234121
1394
1395 2018-07-24  Thibault Saunier  <tsaunier@igalia.com>
1396
1397         [Flatpak] Add openh264 as needed by WebRTC
1398         https://bugs.webkit.org/show_bug.cgi?id=187956
1399
1400         Reviewed by Philippe Normand.
1401
1402         * flatpak/org.webkit.WebKit.yaml:
1403
1404 2018-07-24  Ross Kirsling  <ross.kirsling@sony.com>
1405
1406         WebCore::URL::hostIsIPAddress needs a Windows implementation
1407         https://bugs.webkit.org/show_bug.cgi?id=187859
1408
1409         Reviewed by Fujii Hironori.
1410
1411         * TestWebKitAPI/Tests/WebCore/URL.cpp:
1412         Check for a few other ways an IP address could be invalid.
1413
1414 2018-07-24  Charlie Turner  <cturner@igalia.com>
1415
1416         [Flatpak] Avoid consuming unknown arguments in flatpak wrapper
1417         https://bugs.webkit.org/show_bug.cgi?id=187951
1418
1419         When running run-webkit-tests --wpe --debug, it was observed that
1420         both self.platform != 'wpe' and self.debug != True. This turned
1421         out to be because of the "args" argument consuming the remainder
1422         of future arguments that came after it. Since the first argument
1423         to load_from_args was the test script to run, it would end up
1424         never processing the other arguments supplied to the wrapper
1425         script.
1426
1427         Tested this by rebuilding GTK in debug mode, running the
1428         minibrowser with various extra options, and running some tests
1429         with various extra options.
1430
1431         Reviewed by Michael Catanzaro.
1432
1433         * flatpak/flatpakutils.py:
1434         (WebkitFlatpak.load_from_args):
1435
1436 2018-07-24  Thibault Saunier  <tsaunier@igalia.com>
1437
1438         [Flatpak] Remove now unnecessary 'hacks' for running tests
1439         https://bugs.webkit.org/show_bug.cgi?id=187608
1440
1441         Reviewed by Philippe Normand.
1442
1443         We used to need to not share X11 with the sandbox when running tests
1444         but it is not needed anymore as we do not mount `/tmp` on `/tmp` in the
1445         sandbox (we mount it on `/run/host/tmp` now).
1446
1447         This has the advantage of making running the MiniBrowser to display test
1448         results working again.
1449
1450         * flatpak/flatpakutils.py:
1451         (WebkitFlatpak.clean_args):
1452         (WebkitFlatpak.run_in_sandbox):
1453         (WebkitFlatpak._cleanup_faltpak_args_for_tests_if_needed): Deleted.
1454
1455 2018-07-23  Fujii Hironori  <Hironori.Fujii@sony.com>
1456
1457         webkitpy.port.server_process_unittest.TestServerProcess.test_basic failed on Windows Python
1458         https://bugs.webkit.org/show_bug.cgi?id=187581
1459
1460         Reviewed by Daniel Bates.
1461
1462         There are two failures in this test case:
1463         1. proc.poll() doesn't return 0.
1464         2. stderr is not output.
1465
1466         For failure #1, this is expected. the process should not exit at
1467         the time. proc.poll() should return None because the process is
1468         still alive.
1469
1470         This change added a new test to check proc.poll() becomes 0 after
1471         the process successfully exits.
1472
1473         For failure #2, stderr is not flushed even though stdout is
1474         flushed. This change uses '-u' command switch to force stdin,
1475         stdout and stderr to be totally unbuffered.
1476
1477         * Scripts/webkitpy/port/server_process_unittest.py:
1478         (TestServerProcess.test_basic): Added -u command switch. Do not
1479         flush stdout. Removed the special condition for Windows. Add a new
1480         test to check proc.poll() returns 0.
1481         (TestServerProcess.test_process_crashing): Added -u command
1482         switch. Do not flush stdout.
1483
1484 2018-07-23  Ross Kirsling  <ross.kirsling@sony.com>
1485
1486         WTF::StringView::split should have an allowEmptyEntries flag
1487         https://bugs.webkit.org/show_bug.cgi?id=187864
1488
1489         Reviewed by Konstantin Tokarev.
1490
1491         * TestWebKitAPI/Tests/WTF/StringView.cpp: Add test.
1492
1493 2018-07-23  Ben Richards  <benton_richards@apple.com>
1494
1495         We should cache the compiled sandbox profile in a data vault
1496         https://bugs.webkit.org/show_bug.cgi?id=184991
1497
1498         Reviewed by Ryosuke Niwa.
1499
1500         Added trace points for sandbox initialization
1501
1502         * Tracing/SystemTracePoints.plist:
1503
1504 2018-07-23  Zalan Bujtas  <zalan@apple.com>
1505
1506         DRT relies on [webView display] to call -viewWillDraw on the WebHTMLView
1507         https://bugs.webkit.org/show_bug.cgi?id=187924
1508         <rdar://problem/41745884>
1509
1510         Reviewed by Simon Fraser.
1511
1512         WebKit relies on -viewWillDraw getting called on WebHTMLView, even though that view has not been marked as needing display.
1513
1514         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1515         (createBitmapContextFromWebView):
1516
1517 2018-07-23  Chris Dumez  <cdumez@apple.com>
1518
1519         WebResourceLoadStatisticsStore fails to unregister itself as a MessageReceiver in its destructor
1520         https://bugs.webkit.org/show_bug.cgi?id=187910
1521         <rdar://problem/42356526>
1522
1523         Reviewed by Brent Fulgham.
1524
1525         Add API test coverage.
1526
1527         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1528         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1529         (-[DisableITPDuringNavigationDelegate webView:didCommitNavigation:]):
1530         (-[DisableITPDuringNavigationDelegate webView:didFinishNavigation:]):
1531         (TEST):
1532         * TestWebKitAPI/Tests/WebKitCocoa/notify-resourceLoadObserver.html: Added.
1533
1534 2018-07-23  Daniel Bates  <dabates@apple.com>
1535
1536         test-webkitpy should take configuration command line options
1537         https://bugs.webkit.org/show_bug.cgi?id=187872
1538
1539         Reviewed by David Kilzer.
1540
1541         Add --debug and --release optional command line options and teach the test bots to invoke test-webkitpy
1542         with the appropriate configuration. At the moment these options are only meaningful on Mac since they
1543         effect the configuration lldbWebKitTester is built with and we only build lldbWebKitTester on Mac.
1544
1545         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1546         (RunPythonTests): Pass the configuration to test-webkitpy. On Mac this will effect
1547         how lldbWebKitTester is built. All other ports do not make use of the specified configuration.
1548         * Scripts/webkitpy/test/main.py:
1549         (_build_lldb_webkit_tester): Modified to take the configuration to build lldbWebKitTester. If
1550         the specified configuration is None then we fall back to using the default configuration (as set
1551         by script set-webkit-configuration).
1552         (Tester._parse_args): Add command line options --debug and --release to build lldbWebKitTester
1553         with a Debug configuration and a Release configuration, respectively
1554         (Tester._run_tests): Pass the configuration to build lldbWebKitTester that we parsed from
1555         the command line options. It may be None if neither --debug nor --release were passed.
1556
1557 2018-07-23  Commit Queue  <commit-queue@webkit.org>
1558
1559         Unreviewed, rolling out r233030.
1560         https://bugs.webkit.org/show_bug.cgi?id=187904
1561
1562         Broke tarball builds (Requested by mcatanzaro on #webkit).
1563
1564         Reverted changeset:
1565
1566         "run-gtk-tests (glib/common.py) cannot determine build
1567         directory when webKitBranchBuild=true"
1568         https://bugs.webkit.org/show_bug.cgi?id=185643
1569         https://trac.webkit.org/changeset/233030
1570
1571 2018-07-21  Simon Fraser  <simon.fraser@apple.com>
1572
1573         Fix lldb summarizers for HashMaps and HashSets
1574         https://bugs.webkit.org/show_bug.cgi?id=187883
1575
1576         Reviewed by Dan Bates.
1577         
1578         HashMap and HashSet summarizers were broken in various ways.
1579         
1580         The 'type summary add -x' regexp needs to match at the start and end of the string
1581         to avoid finding types nested inside other templates.
1582         
1583         The HashTable synthetic child code incorrectly used the type of the key, rather than
1584         the value when synthesizing children.
1585         
1586         Add HashMap and HashSet summarizers.
1587
1588         I tried to get synthetic children working directly for HashMap and HashSet, but was unable.
1589
1590         * lldb/lldbWebKitTester/main.cpp:
1591         (testSummaryProviders):
1592         * lldb/lldb_webkit.py:
1593         (__lldb_init_module):
1594         (__lldb_init_module.lldb_webkit):
1595         (WTFHashMap_SummaryProvider):
1596         (WTFHashSet_SummaryProvider):
1597         (WebCoreColorProvider._to_string_extended):
1598         (WebCoreURLProvider.to_string):
1599         (WTFHashMapProvider):
1600         (WTFHashMapProvider.__init__):
1601         (WTFHashMapProvider.tableSize):
1602         (WTFHashMapProvider.keyCount):
1603         (WTFHashSetProvider):
1604         (WTFHashSetProvider.__init__):
1605         (WTFHashSetProvider.tableSize):
1606         (WTFHashSetProvider.keyCount):
1607         (WTFHashTableProvider.tableSize):
1608         (WTFHashTableProvider):
1609         (WTFHashTableProvider.keyCount):
1610         (WTFHashTableProvider.get_child_at_index):
1611         (WTFHashTableProvider.update):
1612         * lldb/lldb_webkit_unittest.py:
1613         (TestSummaryProviders.serial_test_WTFVectorProvider_empty_vector):
1614         (TestSummaryProviders.serial_test_WTFVectorProvider_vector_size_and_capacity):
1615         (TestSummaryProviders):
1616         (TestSummaryProviders.serial_test_WTFHashMap_tablesize_and_size):
1617         (TestSummaryProviders.serial_test_WTFHashMap_of_vectors_tablesize_and_size):
1618         (TestSummaryProviders.serial_test_WTFHashSet_tablesize_and_size):
1619
1620 2018-07-21  Simon Fraser  <simon.fraser@apple.com>
1621
1622         Add lldb formatters for WebCore geometry types
1623         https://bugs.webkit.org/show_bug.cgi?id=187884
1624
1625         Reviewed by Daniel Bates.
1626         
1627         Add lldb formatters for IntPoint, IntSize, IntRect, FloatPoint, FloatSize, FloatRect
1628         and LayoutRect.
1629         
1630         Testing is blocked by webkit.org/b/187872.
1631
1632         * lldb/lldbWebKitTester/main.cpp:
1633         (testSummaryProviders):
1634         * lldb/lldb_webkit.py:
1635         (__lldb_init_module.lldb_webkit):
1636         (__lldb_init_module):
1637         (WebCoreLayoutRect_SummaryProvider):
1638         (WebCoreIntSize_SummaryProvider):
1639         (WebCoreIntPoint_SummaryProvider):
1640         (WebCoreFloatSize_SummaryProvider):
1641         (WebCoreFloatPoint_SummaryProvider):
1642         (WebCoreIntRect_SummaryProvider):
1643         (WebCoreFloatRect_SummaryProvider):
1644         (WebCoreLayoutRectProvider):
1645         (WebCoreLayoutRectProvider.__init__):
1646         (WebCoreLayoutRectProvider.get_x):
1647         (WebCoreLayoutRectProvider.get_y):
1648         (WebCoreLayoutRectProvider.get_width):
1649         (WebCoreLayoutRectProvider.get_height):
1650         (WebCoreIntPointProvider):
1651         (WebCoreIntPointProvider.__init__):
1652         (WebCoreIntPointProvider.get_x):
1653         (WebCoreIntPointProvider.get_y):
1654         (WebCoreIntSizeProvider):
1655         (WebCoreIntSizeProvider.__init__):
1656         (WebCoreIntSizeProvider.get_width):
1657         (WebCoreIntSizeProvider.get_height):
1658         (WebCoreIntRectProvider):
1659         (WebCoreIntRectProvider.__init__):
1660         (WebCoreIntRectProvider.get_x):
1661         (WebCoreIntRectProvider.get_y):
1662         (WebCoreIntRectProvider.get_width):
1663         (WebCoreIntRectProvider.get_height):
1664         (WebCoreFloatPointProvider):
1665         (WebCoreFloatPointProvider.__init__):
1666         (WebCoreFloatPointProvider.get_x):
1667         (WebCoreFloatPointProvider.get_y):
1668         (WebCoreFloatSizeProvider):
1669         (WebCoreFloatSizeProvider.__init__):
1670         (WebCoreFloatSizeProvider.get_width):
1671         (WebCoreFloatSizeProvider.get_height):
1672         (WebCoreFloatRectProvider):
1673         (WebCoreFloatRectProvider.__init__):
1674         (WebCoreFloatRectProvider.get_x):
1675         (WebCoreFloatRectProvider.get_y):
1676         (WebCoreFloatRectProvider.get_width):
1677         (WebCoreFloatRectProvider.get_height):
1678
1679 2018-07-20  John Wilander  <wilander@apple.com>
1680
1681         Resource Load Statistics: Enable basic functionality in experimental debug mode
1682         https://bugs.webkit.org/show_bug.cgi?id=187835
1683         <rdar://problem/42408590>
1684
1685         Reviewed by Chris Dumez.
1686
1687         This patch makes the experimental ITP Debug Mode feature work, at least
1688         to a basic level. All of the changes to TestRunner are to support the
1689         layout tests for the functionality.
1690
1691         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1692         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1693         (WTR::InjectedBundle::didReceiveMessageToPage):
1694         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1695         (WTR::TestRunner::setStatisticsDebugMode):
1696         (WTR::TestRunner::statisticsCallDidSetDebugModeCallback):
1697         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
1698         (WTR::TestRunner::statisticsCallDidSetPrevalentResourceForDebugModeCallback):
1699         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1700         * WebKitTestRunner/TestController.cpp:
1701         (WTR::TestController::setStatisticsDebugMode):
1702         (WTR::TestController::setStatisticsPrevalentResourceForDebugMode):
1703         * WebKitTestRunner/TestController.h:
1704         * WebKitTestRunner/TestInvocation.cpp:
1705         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1706         (WTR::TestInvocation::didSetStatisticsDebugMode):
1707         (WTR::TestInvocation::didSetPrevalentResourceForDebugMode):
1708         * WebKitTestRunner/TestInvocation.h:
1709
1710 2018-07-20  Ryosuke Niwa  <rniwa@apple.com>
1711
1712         Picking a color from the color panel for typing attributes needs to inverse transform through color-filter
1713         https://bugs.webkit.org/show_bug.cgi?id=187846
1714
1715         Reviewed by Simon Fraser.
1716
1717         Fixed the bug that testRunner.execCommand was using the second argument as the value.
1718
1719         The second argument, aShowDefaultUI, should always be ignored in testRunner.execCommand,
1720         and the third argument should be used as the value. DumpRenderTree's implementation does this already.
1721
1722         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1723         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1724         (WTR::TestRunner::execCommand):
1725         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1726
1727 2018-07-20  Dean Jackson  <dino@apple.com>
1728
1729         Accidentally checked in the wrong version of these files.
1730
1731         * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj:
1732         * lldb/lldbWebKitTester/main.cpp:
1733         (testSummaryProviders):
1734         * lldb/lldb_webkit_unittest.py:
1735         (TestSummaryProviders.serial_test_WTFVectorProvider_vector_size_and_capacity):
1736         (TestSummaryProviders.serial_test_WebCoreColorProvider_invalid_color): Deleted.
1737         (TestSummaryProviders.serial_test_WebCoreColorProvider_extended_color): Deleted.
1738         (TestSummaryProviders.serial_test_WebCoreColorProvider_rgb_color): Deleted.
1739         (TestSummaryProviders.serial_test_WebCoreColorProvider_rgba_color): Deleted.
1740         (TestSummaryProviders.serial_test_WebCoreColorProvider_semantic_color): Deleted.
1741
1742 2018-07-20  Dean Jackson  <dino@apple.com>
1743
1744         Provide an lldb type summary for WebCore::Color
1745         https://bugs.webkit.org/show_bug.cgi?id=187776
1746
1747         Reviewed by Dan Bates.
1748
1749         This time without the tests because we don't want to build
1750         all of WebKit just for python tests.
1751
1752         * lldb/lldb_webkit.py: Add a Color summary provider.
1753         (__lldb_init_module):
1754         (WebCoreColor_SummaryProvider):
1755         (WebCoreColorProvider):
1756         (WebCoreColorProvider.__init__):
1757         (WebCoreColorProvider._is_extended):
1758         (WebCoreColorProvider._is_valid):
1759         (WebCoreColorProvider._is_semantic):
1760         (WebCoreColorProvider._to_string_extended):
1761         (WebCoreColorProvider.to_string):
1762
1763 2018-07-20  Brady Eidson  <beidson@apple.com>
1764
1765         Add WKNavigation/WKNavigationAction related SPI.
1766         https://bugs.webkit.org/show_bug.cgi?id=187826
1767
1768         Reviewed by Chris Dumez.
1769
1770         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
1771         (-[NavigationActionHasNavigationDelegate webView:didFinishNavigation:]):
1772         (-[NavigationActionHasNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1773         (TEST):
1774
1775 2018-07-20  Commit Queue  <commit-queue@webkit.org>
1776
1777         Unreviewed, rolling out r233943, r233988, r234004, and
1778         r234012.
1779         https://bugs.webkit.org/show_bug.cgi?id=187856
1780
1781         webkitpy tests are failing to build lldbWebKitTester
1782         (Requested by ryanhaddad on #webkit).
1783
1784         Reverted changesets:
1785
1786         "Provide an lldb type summary for WebCore::Color"
1787         https://bugs.webkit.org/show_bug.cgi?id=187776
1788         https://trac.webkit.org/changeset/233943
1789
1790         "Provide an lldb type summary for WebCore::Color"
1791         https://bugs.webkit.org/show_bug.cgi?id=187776
1792         https://trac.webkit.org/changeset/233988
1793
1794         "Provide an lldb type summary for WebCore::Color"
1795         https://bugs.webkit.org/show_bug.cgi?id=187776
1796         https://trac.webkit.org/changeset/234004
1797
1798         "Provide an lldb type summary for WebCore::Color"
1799         https://bugs.webkit.org/show_bug.cgi?id=187776
1800         https://trac.webkit.org/changeset/234012
1801
1802 2018-07-20  Philippe Normand  <pnormand@igalia.com>
1803
1804         [GTK][WPE] enable-media-capabilities websetting
1805         https://bugs.webkit.org/show_bug.cgi?id=187847
1806
1807         Reviewed by Carlos Garcia Campos.
1808
1809         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1810         (testWebKitSettings): Unit test for the new enable-media-capabilities setting.
1811
1812 2018-07-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1813
1814         [GLIB] jsc_context_evaluate_in_object() should receive an instance when a JSCClass is given
1815         https://bugs.webkit.org/show_bug.cgi?id=187798
1816
1817         Reviewed by Michael Catanzaro.
1818
1819         Update test cases to the new API and use a destroy function and vtable in the test case of calling
1820         jsc_context_evaluate_in_object() with a JSCClass.
1821
1822         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1823         (testJSCEvaluateInObject):
1824
1825 2018-07-19  Ross Kirsling  <ross.kirsling@sony.com>
1826
1827         TestWTF.WTF.StringConcatenate_Unsigned fails for unsigned short on Windows
1828         https://bugs.webkit.org/show_bug.cgi?id=187712
1829
1830         Reviewed by Fujii Hironori.
1831
1832         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
1833         Mark result of unsigned short test case as platform-specific,
1834         since Windows' behavior is actually *less* surprising here.
1835
1836 2018-07-19  Lucas Forschler  <lforschler@apple.com>
1837
1838         Teach the AWS Lambda to use the [minified]-platforms database
1839         https://bugs.webkit.org/show_bug.cgi?id=187817
1840         
1841         Reviewed by David Kilzer.
1842
1843         * WebKitArchiveSupport/lambda/register-archive-in-dynamodb.py:
1844         (lambda_handler): Add support for the platforms.webkit.org database
1845         * WebKitArchiveSupport/lambda/register-minified-s3-archive-in-dynamodb.py:
1846         (lambda_handler): Add support for the minified-platforms.webkit.org database
1847
1848 2018-07-19  Dean Jackson  <dino@apple.com>
1849
1850         Provide an lldb type summary for WebCore::Color
1851         https://bugs.webkit.org/show_bug.cgi?id=187776
1852
1853         Dan Bates helped me with this attempted fix. Fingers crossed!
1854
1855         * Scripts/build-lldbwebkittester:
1856
1857 2018-07-19  Stephan Szabo  <stephan.szabo@sony.com>
1858
1859         [WinCairo] Support DEVELOPER_MODE for allowing inspection of web inspector
1860         https://bugs.webkit.org/show_bug.cgi?id=187786
1861
1862         Reviewed by Fujii Hironori.
1863
1864         * Scripts/webkitdirs.pm:
1865         (generateBuildSystemFromCMakeProject): Turn on DEVELOPER_MODE
1866         for WinCairo builds.
1867
1868 2018-07-19  Dean Jackson  <dino@apple.com>
1869
1870         Provide an lldb type summary for WebCore::Color
1871         https://bugs.webkit.org/show_bug.cgi?id=187776
1872
1873         Another attempted build fix for Debug.
1874
1875         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
1876         * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj:
1877
1878 2018-07-19  Thomas Denney  <tdenney@apple.com>
1879
1880         [WHLSL] The interpreter doesn't support boolean short-circuiting
1881         https://bugs.webkit.org/show_bug.cgi?id=187779
1882
1883         Reviewed by Alex Christensen.
1884
1885         * WebGPUShadingLanguageRI/Evaluator.js:
1886         (Evaluator.prototype.visitLogicalExpression): RHS is only evaluated when necessary
1887         * WebGPUShadingLanguageRI/Test.js:
1888         (tests.booleanShortcircuiting): Adds 4 tests for the evaluation of logical expresions
1889
1890 2018-07-19  Dean Jackson  <dino@apple.com>
1891
1892         Provide an lldb type summary for WebCore::Color
1893         https://bugs.webkit.org/show_bug.cgi?id=187776
1894
1895         Attempted build fix.
1896
1897         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
1898
1899 2018-07-19  Brady Eidson  <beidson@apple.com>
1900
1901         Add an SPI policy action to allow clients to explicitly ask for a new process on a navigation.
1902         https://bugs.webkit.org/show_bug.cgi?id=187789
1903
1904         Reviewed by Andy Estes.
1905
1906         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1907         (-[PSONNavigationDelegate init]):
1908         (-[PSONNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1909
1910 2018-07-19  Thibault Saunier  <tsaunier@igalia.com>
1911
1912         [Flatpak] Let flatpak process handle SIGINT
1913         https://bugs.webkit.org/show_bug.cgi?id=187521
1914
1915         Reviewed by Philippe Normand.
1916
1917         Ensuring that flatpak process ends properly and that the sandbox is teard down.
1918         It also avoids showing usless backtrace to the end user and makes gdb
1919         much more usable.
1920
1921         Also make flatpakutils not verbose by default
1922
1923         * flatpak/flatpakutils.py:
1924         (disable_signals):
1925         (WebkitFlatpak.run_in_sandbox):
1926         (WebkitFlatpak.run_gdb):
1927
1928 2018-07-18  Stephan Szabo  <stephan.szabo@sony.com>
1929
1930         Unreviewed. Fix contributors entry.
1931
1932         * Scripts/webkitpy/common/config/contributors.json:
1933
1934 2018-07-18  Dean Jackson  <dino@apple.com>
1935
1936         Provide an lldb type summary for WebCore::Color
1937         https://bugs.webkit.org/show_bug.cgi?id=187776
1938
1939         Reviewed by Dan Bates.
1940
1941         * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj: Link against WebKit
1942             to get to WebCore.
1943         * lldb/lldbWebKitTester/main.cpp:
1944         (testSummaryProviders): Create some Color objects for testing.
1945
1946         * lldb/lldb_webkit.py: Add a Color summary provider.
1947         (__lldb_init_module):
1948         (WebCoreColor_SummaryProvider):
1949         (WebCoreColorProvider):
1950         (WebCoreColorProvider.__init__):
1951         (WebCoreColorProvider._is_extended):
1952         (WebCoreColorProvider._is_valid):
1953         (WebCoreColorProvider._is_semantic):
1954         (WebCoreColorProvider._to_string_extended):
1955         (WebCoreColorProvider.to_string):
1956
1957         * lldb/lldb_webkit_unittest.py: Tests.
1958         (TestSummaryProviders.serial_test_WTFVectorProvider_vector_size_and_capacity):
1959         (TestSummaryProviders):
1960         (TestSummaryProviders.serial_test_WebCoreColorProvider_invalid_color):
1961         (TestSummaryProviders.serial_test_WebCoreColorProvider_extended_color):
1962         (TestSummaryProviders.serial_test_WebCoreColorProvider_rgb_color):
1963         (TestSummaryProviders.serial_test_WebCoreColorProvider_rgba_color):
1964
1965 2018-07-18  Truitt Savell  <tsavell@apple.com>
1966
1967         Unreviewed, rolling out r233934.
1968
1969         Revision caused 5 webkitpy failures on Mac and broke webkitpy
1970         testing on iOS simulator
1971
1972         Reverted changeset:
1973
1974         "Provide an lldb type summary for WebCore::Color"
1975         https://bugs.webkit.org/show_bug.cgi?id=187776
1976         https://trac.webkit.org/changeset/233934
1977
1978 2018-07-18  Chris Dumez  <cdumez@apple.com>
1979
1980         REGRESSION (r233897): CrashTracer: com.apple.WebKit.WebContent.Development at com.apple.WebKit: WKBooleanGetValue + 9
1981         https://bugs.webkit.org/show_bug.cgi?id=187784
1982         <rdar://problem/42329230>
1983
1984         Reviewed by Brady Eidson.
1985
1986         When process swapping on navigation, WebPageProxy::reattachToWebProcess() unregisters the page as a MessageReceiver
1987         from the old WebProcessProxy and registers itself as a MessageReceiver for the new WebProcessProxy instead. This
1988         means that after this point, IPC sent by the previous WebProcess to its WebPageProxy will fail.
1989
1990         When we process swap, we also navigate the page in the old WebProcess to about:blank, when the navigation to
1991         about:blank would complete, the WebKitTestRunner's injected bundle would try and send IPC to the WebPageProxy
1992         which would fail and would cause WKBundlePagePostSynchronousMessageForTesting() to return a null result. WKTR
1993         would crash when dereferencing this null result. This patch addresses this by dealing with the potential null
1994         result.
1995
1996         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1997         (WTR::InjectedBundle::shouldProcessWorkQueue const):
1998
1999 2018-07-18  Dean Jackson  <dino@apple.com>
2000
2001         Provide an lldb type summary for WebCore::Color
2002         https://bugs.webkit.org/show_bug.cgi?id=187776
2003
2004         Reviewed by Dan Bates.
2005
2006         * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj: Link against WebKit
2007             to get to WebCore.
2008         * lldb/lldbWebKitTester/main.cpp:
2009         (testSummaryProviders): Create some Color objects for testing.
2010
2011         * lldb/lldb_webkit.py: Add a Color summary provider.
2012         (__lldb_init_module):
2013         (WebCoreColor_SummaryProvider):
2014         (WebCoreColorProvider):
2015         (WebCoreColorProvider.__init__):
2016         (WebCoreColorProvider._is_extended):
2017         (WebCoreColorProvider._is_valid):
2018         (WebCoreColorProvider._is_semantic):
2019         (WebCoreColorProvider._to_string_extended):
2020         (WebCoreColorProvider.to_string):
2021
2022         * lldb/lldb_webkit_unittest.py: Tests.
2023         (TestSummaryProviders.serial_test_WTFVectorProvider_vector_size_and_capacity):
2024         (TestSummaryProviders):
2025         (TestSummaryProviders.serial_test_WebCoreColorProvider_invalid_color):
2026         (TestSummaryProviders.serial_test_WebCoreColorProvider_extended_color):
2027         (TestSummaryProviders.serial_test_WebCoreColorProvider_rgb_color):
2028         (TestSummaryProviders.serial_test_WebCoreColorProvider_rgba_color):
2029
2030 2018-07-18  Stephan Szabo  <stephan.szabo@sony.com>
2031
2032         Adding myself to contributors.json
2033
2034         Unreviewed contributors.json change.
2035
2036         * Scripts/webkitpy/common/config/contributors.json:
2037
2038 2018-07-18  Jer Noble  <jer.noble@apple.com>
2039
2040         -_beginAnimatedResizeWithUpdates: can leave view in bad state if called during an existing animation
2041         https://bugs.webkit.org/show_bug.cgi?id=187739
2042         <rdar://problem/42304518>
2043
2044         Reviewed by Tim Horton.
2045
2046         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
2047         (TEST):
2048
2049 2018-07-18  Jer Noble  <jer.noble@apple.com>
2050
2051         PiP from Element Fullscreen should match AVKit's behavior
2052         https://bugs.webkit.org/show_bug.cgi?id=187623
2053         <rdar://problem/41212379>
2054
2055         Reviewed by Jon Lee.
2056
2057         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2058         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.html: Added.
2059         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm: Added.
2060         (-[ExitFullscreenOnEnterPiPUIDelegate _webView:hasVideoInPictureInPictureDidChange:]):
2061         (-[ExitFullscreenOnEnterPiPUIDelegate _webViewDidEnterFullscreen:]):
2062         (-[ExitFullscreenOnEnterPiPUIDelegate _webViewDidExitFullscreen:]):
2063         (TestWebKitAPI::TEST):
2064
2065 2018-07-18  Aakash Jain  <aakash_jain@apple.com>
2066
2067         [ews-build] Add build step to run layout-test
2068         https://bugs.webkit.org/show_bug.cgi?id=187674
2069
2070         Reviewed by Lucas Forschler.
2071
2072         * BuildSlaveSupport/ews-build/steps.py:
2073         (RunWebKitTests): Added build step to run layout-tests. This is similar to current EWS.
2074         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2075         * BuildSlaveSupport/ews-build/factories.py: Added build-step to run layout-test in iOSSimulatorFactory.
2076
2077 2018-07-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2078
2079         Add SPI to defer running async script until after document load
2080         https://bugs.webkit.org/show_bug.cgi?id=187748
2081         <rdar://problem/42317378>
2082
2083         Reviewed by Ryosuke Niwa and Tim Horton.
2084
2085         Add an API test to verify that when the deferred async script configuration is set, async scripts will be
2086         executed after the DOMContentLoaded event.
2087
2088         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2089         * TestWebKitAPI/Tests/WebKitCocoa/RunScriptAfterDocumentLoad.mm: Added.
2090         (TEST):
2091
2092 2018-07-18  Charlie Turner  <cturner@igalia.com>
2093
2094         [WPE] Update WPEBackend in flatpak
2095         https://bugs.webkit.org/show_bug.cgi?id=187753
2096
2097         r233763 updated WPEBackend for the jhbuild, but not the flatpak. This
2098         caused WPE_BACKEND_CHECK_VERSION to not be defined, triggering a bug
2099         in the version guard,
2100
2101         #if defined(WPE_BACKEND_CHECK_VERSION) && WPE_BACKEND_CHECK_VERSION(0, 2, 0)
2102
2103         This doesn't work as intended, since the C preprocessor first expands
2104         all macro arguments in the #if expression before evaluating the
2105         expression. When WPE_BACKEND_CHECK_VERSION is not defined, this will
2106         lead to a syntax error and some head scratching.
2107
2108         A future patch should address the buggy macro check, when it is
2109         decided whether the assume the macro is always defined and bump
2110         the API requirements on WPEBackend, or to move the check into two
2111         conditionals to avoid the expansion problem.
2112
2113         Unreviewed build fix.
2114         
2115         * flatpak/org.webkit.WPE.yaml:
2116
2117 2018-07-18  Simon Fraser  <simon.fraser@apple.com>
2118
2119         Fix the parsing of colors in attributed string tests, and make it possible to dump the typing attributes
2120         https://bugs.webkit.org/show_bug.cgi?id=187747
2121
2122         Reviewed by Ryosuke Niwa.
2123         
2124         Add textInputController.attributedStringForTyping(), which returns a one-character
2125         attributed string whose attributes are the typing attributes, making it possible to
2126         test -[WebView typingAttributes].
2127         
2128         Sadly WebCore's convertObjcValueToValue() doesn't know how to convert NSDictionary,
2129         so we can't return -typingAttributes directly.
2130
2131         * DumpRenderTree/mac/TextInputControllerMac.m:
2132         (+[TextInputController isSelectorExcludedFromWebScript:]):
2133         (-[TextInputController attributedStringForTyping]):
2134
2135 2018-07-18  Carlos Garcia Campos  <cgarcia@igalia.com>
2136
2137         [GLIB] Add jsc_context_check_syntax() to GLib API
2138         https://bugs.webkit.org/show_bug.cgi?id=187694
2139
2140         Reviewed by Yusuke Suzuki.
2141
2142         Add a new test case.
2143
2144         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2145         (testJSCCheckSyntax):
2146         (main):
2147
2148 2018-07-17  Sihui Liu  <sihui_liu@apple.com>
2149
2150         REGRESSION: [macOS Sierra] TestWebKitAPI.WebKit.WebsiteDataStoreCustomPaths is a flaky failure
2151         https://bugs.webkit.org/show_bug.cgi?id=187066
2152         <rdar://problem/41609065>
2153
2154         Reviewed by Chris Dumez.
2155
2156         In r232668 we started to do reload if web process crashes by default. As we killed the web 
2157         process explicitly in this test, if web page got reloaded, messages would be sent again, 
2158         and flag set in message handler could keep the test continue to evaluate the expectation 
2159         without waiting for removeDataOfTypes to finish.
2160
2161         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2162         (-[WebsiteDataStoreCustomPathsMessageHandler webViewWebContentProcessDidTerminate:]):
2163         (TEST):
2164
2165 2018-07-17  Chris Dumez  <cdumez@apple.com>
2166
2167         Turn on PSON in WebKitTestRunner
2168         https://bugs.webkit.org/show_bug.cgi?id=186542
2169
2170         Reviewed by Brady Eidson.
2171
2172         Turn on PSON by default in WebKitTestRunner.
2173
2174         * WebKitTestRunner/TestOptions.h:
2175
2176 2018-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2177
2178         Add an SPI hook to allow clients to yield document parsing and script execution
2179         https://bugs.webkit.org/show_bug.cgi?id=187682
2180         <rdar://problem/42207453>
2181
2182         Reviewed by Ryosuke Niwa.
2183
2184         Add a few tests to exercise the new document yield token SPI, verifying that clients can use the SPI to defer
2185         document load, and that doing so doesn't cause deferred `script` to execute in the wrong order (i.e. before
2186         synchronous script, or after "DOMContentLoaded").
2187
2188         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2189         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm: Added.
2190         (-[ParserYieldTokenPlugIn takeDocumentParserTokenAfterCommittingLoad]):
2191         (-[ParserYieldTokenPlugIn releaseDocumentParserToken]):
2192         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
2193         (-[ParserYieldTokenPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2194         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didFinishDocumentLoadForFrame:]):
2195         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didFinishLoadForFrame:]):
2196
2197         Add an injected bundle object that knows how to take and release multiple document parser yield tokens.
2198
2199         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenTests.h: Added.
2200         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenTests.mm: Added.
2201         (+[ParserYieldTokenTestWebView webView]):
2202         (-[ParserYieldTokenTestWebView bundle]):
2203         (-[ParserYieldTokenTestWebView schemeHandler]):
2204         (-[ParserYieldTokenTestWebView didFinishDocumentLoad]):
2205         (-[ParserYieldTokenTestWebView didFinishLoad]):
2206         (waitForDelay):
2207         (TEST):
2208         * TestWebKitAPI/Tests/WebKitCocoa/TestURLSchemeHandler.h: Added.
2209         * TestWebKitAPI/Tests/WebKitCocoa/TestURLSchemeHandler.mm: Added.
2210         (-[TestURLSchemeHandler webView:startURLSchemeTask:]):
2211         (-[TestURLSchemeHandler webView:stopURLSchemeTask:]):
2212         (-[TestURLSchemeHandler setStartURLSchemeTaskHandler:]):
2213         (-[TestURLSchemeHandler startURLSchemeTaskHandler]):
2214         (-[TestURLSchemeHandler setStopURLSchemeTaskHandler:]):
2215         (-[TestURLSchemeHandler stopURLSchemeTaskHandler]):
2216
2217         Add a new test helper class to handle custom schemes via a block-based API.
2218
2219         * TestWebKitAPI/Tests/WebKitCocoa/text-with-async-script.html: Added.
2220
2221         New test HTML page that contains a deferred script element, a synchronous script element, another deferred
2222         script element, and then some text, images, and links.
2223
2224         * TestWebKitAPI/Tests/WebKitCocoa/text-with-deferred-script.html: Added.
2225
2226 2018-07-17  Truitt Savell  <tsavell@apple.com>
2227
2228         Adding myself to Contributors.json
2229
2230         Unreviewed
2231
2232         * Scripts/webkitpy/common/config/contributors.json:
2233
2234 2018-07-17  Aditya Keerthi  <akeerthi@apple.com>
2235
2236         [macOS] TestWebKitAPI.PictureInPicture.WKUIDelegate is timing out
2237         https://bugs.webkit.org/show_bug.cgi?id=187730
2238
2239         Reviewed by Jer Noble.
2240
2241         This regression was introduced by r233865. PIP can now only be initiated from a
2242         window that is on screen.
2243
2244         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
2245         (TestWebKitAPI::TEST):
2246
2247 2018-07-17  John Wilander  <wilander@apple.com>
2248
2249         Add completion handlers to TestRunner functions setStatisticsLastSeen(), setStatisticsPrevalentResource(), setStatisticsVeryPrevalentResource(), setStatisticsHasHadUserInteraction(), and setStatisticsHasHadNonRecentUserInteraction()
2250         https://bugs.webkit.org/show_bug.cgi?id=187710
2251         <rdar://problem/42252757>
2252
2253         Reviewed by Chris Dumez.
2254
2255         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2256         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2257         (WTR::InjectedBundle::didReceiveMessageToPage):
2258         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2259         (WTR::TestRunner::setStatisticsLastSeen):
2260         (WTR::TestRunner::statisticsCallDidSetLastSeenCallback):
2261         (WTR::TestRunner::setStatisticsPrevalentResource):
2262         (WTR::TestRunner::statisticsCallDidSetPrevalentResourceCallback):
2263         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
2264         (WTR::TestRunner::statisticsCallDidSetVeryPrevalentResourceCallback):
2265         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
2266         (WTR::TestRunner::setStatisticsHasHadNonRecentUserInteraction):
2267         (WTR::TestRunner::statisticsCallDidSetHasHadUserInteractionCallback):
2268         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2269         * WebKitTestRunner/TestController.cpp:
2270         (WTR::TestController::setStatisticsLastSeen):
2271         (WTR::TestController::setStatisticsPrevalentResource):
2272         (WTR::TestController::setStatisticsVeryPrevalentResource):
2273         (WTR::TestController::setStatisticsHasHadUserInteraction):
2274         (WTR::TestController::setStatisticsHasHadNonRecentUserInteraction):
2275         * WebKitTestRunner/TestInvocation.cpp:
2276         (WTR::TestInvocation::didSetLastSeen):
2277         (WTR::TestInvocation::didSetPrevalentResource):
2278         (WTR::TestInvocation::didSetVeryPrevalentResource):
2279         (WTR::TestInvocation::didSetHasHadUserInteraction):
2280         (WTR::TestInvocation::didSetHasHadNonRecentUserInteraction):
2281         * WebKitTestRunner/TestInvocation.h:
2282
2283 2018-07-16  Jeremy Jones  <jeremyj@apple.com>
2284
2285         Fix API Test failures introduced by r233865
2286         https://bugs.webkit.org/show_bug.cgi?id=187720
2287
2288         Unreviewed APITest fix after r233865.
2289
2290         Fullscreen can now only be initiated from a window that is on screen.
2291
2292         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
2293         (TestWebKitAPI::TEST):
2294         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenTopContentInset.mm:
2295         (TestWebKitAPI::TEST):
2296
2297 2018-07-11  Dean Jackson  <dino@apple.com>
2298
2299         Allow removal of white backgrounds
2300         https://bugs.webkit.org/show_bug.cgi?id=187574
2301         <rdar://problem/41146792>
2302
2303         Reviewed by Simon Fraser.
2304
2305         Add a new menu item for punching out white backgrounds in MiniBrowser.
2306         In WebKitTestRunner, expose the new setting and hook that up to
2307         drawing a background in the WebView.
2308
2309         * MiniBrowser/mac/AppDelegate.m:
2310         (defaultConfiguration): Add _punchOutWhiteBackgroundsInDarkMode.
2311
2312         * MiniBrowser/mac/SettingsController.h: Ditto.
2313         * MiniBrowser/mac/SettingsController.m:
2314         (-[SettingsController _populateMenu]):
2315         (-[SettingsController validateMenuItem:]):
2316         (-[SettingsController togglePunchOutWhiteBackgroundsInDarkMode:]):
2317         (-[SettingsController punchOutWhiteBackgroundsInDarkMode]):
2318
2319         * MiniBrowser/mac/WK1BrowserWindowController.m:
2320         (-[WK1BrowserWindowController didChangeSettings]): Set the new preference.
2321
2322         * WebKitTestRunner/PlatformWebView.h: Expose a drawsBackground property.
2323         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: Null implementation.
2324         (WTR::PlatformWebView::drawsBackground const):
2325         (WTR::PlatformWebView::setDrawsBackground):
2326         * WebKitTestRunner/wpe/PlatformWebViewWPE.cpp: Ditto.
2327         (WTR::PlatformWebView::drawsBackground const):
2328         (WTR::PlatformWebView::setDrawsBackground):
2329         * WebKitTestRunner/ios/PlatformWebViewIOS.mm: Call into the WKWebView and
2330         set its SPI.
2331         (WTR::PlatformWebView::drawsBackground const):
2332         (WTR::PlatformWebView::setDrawsBackground):
2333         * WebKitTestRunner/mac/PlatformWebViewMac.mm: Ditto.
2334         (WTR::PlatformWebView::drawsBackground const):
2335         (WTR::PlatformWebView::setDrawsBackground):
2336
2337         * WebKitTestRunner/TestController.cpp: Reset and copy the new preference.
2338         (WTR::TestController::resetPreferencesToConsistentValues):
2339         (WTR::updateTestOptionsFromTestHeader):
2340         * WebKitTestRunner/TestOptions.h:
2341         (WTR::TestOptions::hasSameInitializationOptions const):
2342
2343         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2344         (WTR::TestController::platformCreateWebView): If the option for punching
2345         out the background was set, tell the WebView to not draw its background.
2346
2347 2018-07-16  Aditya Keerthi  <akeerthi@apple.com>
2348
2349         [Datalist][macOS] Add suggestions UI for TextFieldInputTypes
2350         https://bugs.webkit.org/show_bug.cgi?id=186531
2351
2352         Reviewed by Tim Horton.
2353
2354         Added isShowingDatalistSuggestions testing hook in order to enable testing of the
2355         visibility of the suggestions view.
2356
2357         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2358         (WTR::UIScriptController::isShowingDataListSuggestions const):
2359         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2360         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2361         (WTR::UIScriptController::isShowingDataListSuggestions const):
2362         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2363         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2364         (WTR::UIScriptController::isShowingDataListSuggestions const):
2365
2366 2018-07-16  Yusuke Suzuki  <utatane.tea@gmail.com>
2367
2368         Add --target-path option to dump-class-layout
2369         https://bugs.webkit.org/show_bug.cgi?id=187687
2370
2371         Reviewed by Simon Fraser.
2372
2373         We add an escape hatch to dump-class-layout for specifying target path directly.
2374         This `--target-path` allows us to use dump-class-layout in the other ports
2375         like JSCOnly.
2376
2377         We can dump class layout if we build the target with clang by using the following command.
2378
2379         Tools/Scripts/dump-class-layout \
2380             --architecture=x86_64 \
2381             --target-path=path/to/libJavaScriptCore.so \
2382             JavaScriptCore \
2383             ScopeNode
2384
2385         * Scripts/dump-class-layout:
2386         (main):
2387
2388 2018-07-16  Sihui Liu  <sihui_liu@apple.com>
2389
2390         IndexedDB: closeAndDeleteDatabasesForOrigins should remove all databases for those origins
2391         https://bugs.webkit.org/show_bug.cgi?id=187631
2392         <rdar://problem/42164227>
2393
2394         Reviewed by Brady Eidson.
2395
2396         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2397         (TEST):
2398
2399 2018-07-15  Carlos Garcia Campos  <cgarcia@igalia.com>
2400
2401         [GLIB] Add API to evaluate code using a given object to store global symbols
2402         https://bugs.webkit.org/show_bug.cgi?id=187639
2403
2404         Reviewed by Michael Catanzaro.
2405
2406         Add a new test case.
2407
2408         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2409         (testJSCEvaluateInObject):
2410         (testJSCExceptions):
2411         (main):
2412
2413 2018-07-15  Zan Dobersek  <zdobersek@igalia.com>
2414
2415         [webkitpy] run-web-platform-tests should allow specifying custom WPT metadata directories
2416         https://bugs.webkit.org/show_bug.cgi?id=187353
2417
2418         Reviewed by Youenn Fablet.
2419
2420         When using run-web-platform-tests, allow specifying custom WPT metadata
2421         directory. This will avoid generating such metadata-filled directory
2422         from the port-specific JSON expectations file, and instead will search
2423         for the metadata files and the include manifest inside the specified
2424         directory. The MANIFEST.json file will also be generated under there.
2425
2426         Rationale for this change is prototyping using custom metadata
2427         directories and avoiding generating all this content from a JSON file.
2428         Using this by default in the future would avoid sporradic changes in how
2429         WPT handles metadata .ini files and releases us from the obligation of
2430         adjusting the generator for every such change. This would also allow
2431         managing this metadata content in a separate repository, avoiding
2432         polluting the main webkit.org repository with thousands of .ini files.
2433
2434         If this turns out to be the preferable way of managing the metadata
2435         content, the JSON files under WebPlatformTests/ and the related code in
2436         wpt_runner.py would be removed.
2437
2438         * Scripts/webkitpy/w3c/wpt_runner.py:
2439         (parse_args):
2440         (WPTRunner._wpt_run_paths):
2441         (WPTRunner.run):
2442         * Scripts/webkitpy/w3c/wpt_runner_unittest.py:
2443         (WPTRunnerTest.test_run_with_specified_options):
2444
2445 2018-07-13  Ross Kirsling  <ross.kirsling@sony.com>
2446
2447         [WinCairo] run-api-tests is timing out for almost all test cases
2448         https://bugs.webkit.org/show_bug.cgi?id=187547
2449
2450         Reviewed by Fujii Hironori.
2451
2452         * Scripts/webkitpy/port/server_process.py:
2453         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
2454         Still attempt to read from stdout/stderr even if the process has exited, as long as it's before the deadline.
2455
2456         * Scripts/webkitpy/port/server_process_unittest.py:
2457         (TestServerProcess.test_read_after_process_exits):
2458         Add test case.
2459
2460 2018-07-13  Ryan Haddad  <ryanhaddad@apple.com>
2461
2462         Add TestExpectations and baselines for iOS 12
2463         https://bugs.webkit.org/show_bug.cgi?id=187628
2464
2465         Reviewed by Alexey Proskuryakov.
2466
2467         * Scripts/webkitpy/port/ios.py:
2468         (IOSPort): Bump current version to 12.
2469
2470 2018-07-13  Ryan Haddad  <ryanhaddad@apple.com>
2471
2472         Add TestExpectations and baselines for Mojave.
2473         https://bugs.webkit.org/show_bug.cgi?id=187620
2474
2475         Reviewed by Alexey Proskuryakov.
2476
2477         * Scripts/webkitpy/port/mac.py:
2478         (MacPort): Bump current version to 10.14.
2479
2480 2018-07-13  Timothy Hatcher  <timothy@apple.com>
2481
2482         Add _drawsBackground to WKWebViewConfiguration.
2483         https://bugs.webkit.org/show_bug.cgi?id=187665
2484         rdar://problem/42182268
2485
2486         Reviewed by Tim Horton.
2487
2488         * TestWebKitAPI/Tests/WebKitCocoa/Configuration.mm:
2489         (TestWebKitAPI.WebKit.ConfigurationDrawsBackground): Added.
2490
2491 2018-07-13  Chris Dumez  <cdumez@apple.com>
2492
2493         Add a FrameLoaderClient willInjectUserScriptForFrame callback
2494         https://bugs.webkit.org/show_bug.cgi?id=187565
2495         <rdar://problem/42095701>
2496
2497         Unreviewed WKTR fix after r233782.
2498
2499         * WebKitTestRunner/TestInvocation.cpp:
2500         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2501
2502 2018-07-13  Chris Dumez  <cdumez@apple.com>
2503
2504         Reduce size of WebCore::URL
2505         https://bugs.webkit.org/show_bug.cgi?id=186820
2506         <rdar://problem/42087508>
2507
2508         Unreviewed, re-generates Service worker registrations database used by API tests after r233789.
2509
2510         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2511         * TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-2.sqlite3: Removed.
2512         * TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-2.sqlite3-shm: Removed.
2513         * TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-3.sqlite3: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-2.sqlite3-wal.
2514         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2515         (TEST):
2516
2517 2018-07-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2518
2519         Make it easier to hit the significant rendered text layout milestone on pages with main article elements
2520         https://bugs.webkit.org/show_bug.cgi?id=187578
2521         <rdar://problem/42104637>
2522
2523         Reviewed by Ryosuke Niwa.
2524
2525         Tweak an existing layout test to additionally check that the significant text layout milestone is fired on a
2526         page with an article element that is clearly the "main" content on the page (i.e. much taller than all other
2527         articles).
2528
2529         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2530         * TestWebKitAPI/Tests/WebKitCocoa/significant-text-milestone-article.html: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/significant-text-milestone.html.
2531         * TestWebKitAPI/Tests/WebKitCocoa/significant-text-milestone.html:
2532         * TestWebKitAPI/Tests/ios/RenderingProgressTests.mm:
2533         (TEST):
2534
2535 2018-07-12  Fujii Hironori  <Hironori.Fujii@sony.com>
2536
2537         Change my status to be a WebKit reviewer.
2538
2539         Unreviewed status update.
2540
2541         * Scripts/webkitpy/common/config/contributors.json:
2542
2543 2018-07-12  Fujii Hironori  <Hironori.Fujii@sony.com>
2544
2545         Unreviewed contributors.json update
2546
2547         Just run "validate-committer-lists -c" to canonicalize the style.
2548
2549         * Scripts/webkitpy/common/config/contributors.json:
2550
2551 2018-07-12  Alex Christensen  <achristensen@webkit.org>
2552
2553         Reduce size of WebCore::URL
2554         https://bugs.webkit.org/show_bug.cgi?id=186820
2555
2556         Reviewed by Yusuke Suzuki and Youenn Fablet.
2557
2558         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2559         (TestWebKitAPI::TEST_F):
2560
2561 2018-07-12  Brady Eidson  <beidson@apple.com>
2562
2563         Make process-swap-on-navigation an experimental feature.
2564         <rdar://problem/41995053> and https://bugs.webkit.org/show_bug.cgi?id=187558
2565
2566         Reviewed by Chris Dumez.
2567
2568         Make sure WKTR doesn't enable ProcessSwapOnNavigation by default simply because it's an experimental feature.
2569
2570         * WebKitTestRunner/TestController.cpp:
2571         (WTR::TestController::createWebViewWithOptions):
2572         (WTR::TestController::resetPreferencesToConsistentValues):
2573
2574         * WebKitTestRunner/TestOptions.h:
2575         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const):
2576
2577 2018-07-12  Youenn Fablet  <youenn@apple.com>
2578
2579         Add a FrameLoaderClient willInjectUserScriptForFrame callback
2580         https://bugs.webkit.org/show_bug.cgi?id=187565
2581
2582         Reviewed by Alex Christensen.
2583
2584         Added new test runner API to check for willInjectUserScriptForFrame callback.
2585
2586         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2587         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2588         (WTR::InjectedBundle::resetUserScriptInjectedCount):
2589         (WTR::InjectedBundle::increaseUserScriptInjectedCount):
2590         (WTR::InjectedBundle::userScriptInjectedCount const):
2591         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2592         (WTR::InjectedBundlePage::InjectedBundlePage):
2593         (WTR::InjectedBundlePage::resetAfterTest):
2594         (WTR::InjectedBundlePage::willInjectUserScriptForFrame):
2595         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2596         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2597         (WTR::TestRunner::userScriptInjectedCount const):
2598         (WTR::TestRunner::injectUserScript):
2599         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2600         * WebKitTestRunner/TestController.cpp:
2601         (WTR::TestController::injectUserScript):
2602         * WebKitTestRunner/TestController.h:
2603         * WebKitTestRunner/TestInvocation.cpp:
2604         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2605         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2606         (WTR::TestController::injectUserScript):
2607
2608 2018-07-12  Sihui Liu  <sihui_liu@apple.com>
2609
2610         IndexedDB: database file of subframe cannot be removed
2611         https://bugs.webkit.org/show_bug.cgi?id=187564
2612
2613         Reviewed by Youenn Fablet.
2614
2615         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2616         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2617         (TEST):
2618
2619 2018-07-12  Timothy Hatcher  <timothy@apple.com>
2620
2621         Make WebKit.LinkColorWithSystemAppearance work across system versions.
2622         https://bugs.webkit.org/show_bug.cgi?id=187573
2623
2624         Reviewed by Wenson Hsieh.
2625
2626         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
2627         (TestWebKitAPI.WebKit.LinkColorWithSystemAppearance): Dynamically generate the expected string.
2628
2629 2018-07-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2630
2631         [WPE] Pass the backend library name as command line parameter to the web process
2632         https://bugs.webkit.org/show_bug.cgi?id=186841
2633
2634         Reviewed by Žan Doberšek.
2635
2636         * MiniBrowser/wpe/main.cpp:
2637         (main): Stop using WPE_BACKEND_LIBRARY env var.
2638         * Scripts/run-wpe-tests:
2639         (WPETestRunner.__init__): Ditto.
2640         * Scripts/webkitpy/port/wpe.py:
2641         (WPEPort.setup_environ_for_server): Ditto.
2642         * wpe/backends/ViewBackend.cpp:
2643         (WPEToolingBackends::ViewBackend::ViewBackend): Call wpe_loader_init() to ensure WPEBackend-fdo is used.
2644         * wpe/jhbuild.modules: Upgrade WPEBackend to version 0.2.0.
2645
2646 2018-07-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2647
2648         [GLIB] Add API to allow creating variadic functions
2649         https://bugs.webkit.org/show_bug.cgi?id=187517
2650
2651         Reviewed by Michael Catanzaro.
2652
2653         Add test cases.
2654
2655         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2656         (testJSCFunction):
2657         (fooCreateWithFooV):
2658         (multiplyFooV):
2659
2660 2018-07-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2661
2662         [GLIB] Add jsc_context_get_global_object() to GLib API
2663         https://bugs.webkit.org/show_bug.cgi?id=187515
2664
2665         Reviewed by Michael Catanzaro.
2666
2667         Add test cases.
2668
2669         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2670         (testJSCGlobalObject):
2671         (main):
2672
2673 2018-07-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2674
2675         [GLIB] Handle G_TYPE_STRV in glib API
2676         https://bugs.webkit.org/show_bug.cgi?id=187512
2677
2678         Reviewed by Michael Catanzaro.
2679
2680         Add test cases.
2681
2682         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2683         (testJSCTypes):
2684         (joinFunction):
2685         (testJSCFunction):
2686
2687 2018-07-11  Aakash Jain  <aakash_jain@apple.com>
2688
2689         [ews-build] EWS should unapply patch and re-run jsc tests when patch fails jsc tests
2690         https://bugs.webkit.org/show_bug.cgi?id=187549
2691
2692         Reviewed by Alexey Proskuryakov.
2693
2694         * BuildSlaveSupport/ews-build/factories.py:
2695         (JSCTestsFactory.__init__):
2696         * BuildSlaveSupport/ews-build/steps.py:
2697         (CompileJSCOnlyToT): Build ToT without patch.
2698         (CompileJSCOnlyToT.doStepIf): Run this step only if patch failed to build.
2699         (RunJavaScriptCoreTests.evaluateCommand): Set patchFailedJSCTests property appropriately.
2700         (ReRunJavaScriptCoreTests): Re-runs JSC tests.
2701         (ReRunJavaScriptCoreTests.doStepIf): Run this step only if patch failed JSC tests.
2702         (ReRunJavaScriptCoreTests.evaluateCommand): Set patchFailedJSCTests property appropriately.
2703         (RunJavaScriptCoreTestsToT): Run JSC tests on ToT without patch.
2704         (RunJavaScriptCoreTestsToT.doStepIf): Run this step only if patch failed JSC tests.
2705         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2706
2707 2018-07-11  Commit Queue  <commit-queue@webkit.org>
2708
2709         Unreviewed, rolling out r233742.
2710         https://bugs.webkit.org/show_bug.cgi?id=187577
2711
2712         Binary incompatible change with respect to Service Worker
2713         registration map (Requested by dydz on #webkit).
2714
2715         Reverted changeset:
2716
2717         "Reduce size of WebCore::URL"
2718         https://bugs.webkit.org/show_bug.cgi?id=186820
2719         https://trac.webkit.org/changeset/233742
2720
2721 2018-07-11  Aditya Keerthi  <akeerthi@apple.com>
2722
2723         REGRESSION (231276): Attempting to copy an image fails
2724         https://bugs.webkit.org/show_bug.cgi?id=187212
2725
2726         Reviewed by Ryosuke Niwa.
2727         <rdar://problem/41540074>
2728
2729         Augmented test to include a URL where the lastPathComponent looks similar to a
2730         file URL.
2731
2732         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.html:
2733         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
2734         (TestWebKitAPI::TEST):
2735
2736 2018-07-11  Alex Christensen  <achristensen@webkit.org>
2737
2738         Add SPI for immediate injection of user scripts
2739         https://bugs.webkit.org/show_bug.cgi?id=173342
2740         <rdar://problem/29202285>
2741
2742         Reviewed by Brady Eidson, Youenn Fablet, and Geoff Garen.
2743
2744         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
2745         (waitForMessage):
2746         (TEST):
2747
2748 2018-07-11  Myles C. Maxfield  <mmaxfield@apple.com>
2749
2750         Move WHLSL spec work to the W3C GPUWeb GitHub repository
2751
2752         See https://github.com/gpuweb/WHLSL
2753
2754         * WebGPUShadingLanguageRI/SpecWork/Makefile: Removed.
2755         * WebGPUShadingLanguageRI/SpecWork/WSL.g4: Removed.
2756         * WebGPUShadingLanguageRI/SpecWork/WSL.ott: Removed.
2757         * WebGPUShadingLanguageRI/SpecWork/source/conf.py: Removed.
2758         * WebGPUShadingLanguageRI/SpecWork/source/index.rst: Removed.
2759
2760 2018-07-11  Dean Jackson  <dino@apple.com>
2761
2762         Force WKTR to use the light appearance
2763         https://bugs.webkit.org/show_bug.cgi?id=187572
2764         <rdar://problem/42097805>
2765
2766         Reviewed by Simon Fraser.
2767
2768         Set the NSAppearance on the NSWindow to light mode.
2769
2770         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2771         (WTR::PlatformWebView::PlatformWebView): Use the Aqua appearance.
2772
2773 2018-07-11  Alex Christensen  <achristensen@webkit.org>
2774
2775         Reduce size of WebCore::URL
2776         https://bugs.webkit.org/show_bug.cgi?id=186820
2777
2778         Reviewed by Yusuke Suzuki.
2779
2780         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2781         (TestWebKitAPI::TEST_F):
2782
2783 2018-07-11  Youenn Fablet  <youenn@apple.com>
2784
2785         Fix remaining Cross-Origin-Resource-Policy failures, if any
2786         https://bugs.webkit.org/show_bug.cgi?id=186761
2787         <rdar://problem/41209829>
2788
2789         Reviewed by Alex Christensen.
2790
2791         * TestWebKitAPI/Tests/WebCore/HTTPParsers.cpp:
2792         (TestWebKitAPI::TEST):
2793
2794  2018-07-11  Aakash Jain  <aakash_jain@apple.com>
2795  
2796         [ews-build] EWS should unapply the patch and build ToT when patch fails to build
2797         https://bugs.webkit.org/show_bug.cgi?id=187358
2798  
2799         Reviewed by Alexey Proskuryakov.
2800  
2801         * BuildSlaveSupport/ews-build/factories.py:
2802         (BuildFactory.__init__):
2803         * BuildSlaveSupport/ews-build/steps.py:
2804         (CompileWebKit): Set haltOnFailure to false so as to run next steps (e.g.: un-apply patch, compile ToT).
2805         (CompileWebKit.evaluateCommand): Set patchFailedToBuild property.
2806         (CompileWebKitToT): Build ToT without patch.
2807         (CompileWebKitToT.doStepIf): Run this step only if patch failed to build.
2808         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests. Also lower-cased Release and Debug.
2809
2810 2018-07-11  Robin Morisset  <rmorisset@apple.com>
2811
2812         [WSL] WIP, more of the spec
2813         https://bugs.webkit.org/show_bug.cgi?id=186310
2814
2815         Rubberstamped by Filip Pizlo.
2816
2817         Fixed a few issues with the formal rules (such as adding the restrictions on pointers for compilation to SpirV),
2818         and started writing some of the english in the spec.
2819
2820         * WebGPUShadingLanguageRI/SpecWork/WSL.ott:
2821         * WebGPUShadingLanguageRI/SpecWork/source/index.rst:
2822
2823 2018-07-10  Aakash Jain  <aakash_jain@apple.com>
2824
2825         [ews-build] Add build step to UnApply patch
2826         https://bugs.webkit.org/show_bug.cgi?id=187357
2827
2828         Reviewed by Alexey Proskuryakov.
2829
2830         * BuildSlaveSupport/ews-build/steps.py:
2831         (UnApplyPatchIfRequired.__init__): Pass alwaysUseLatest parameter in order to unapply the patch.
2832         (UnApplyPatchIfRequired.doStepIf): Run this step only if patch failed to build or failed test. These
2833         properties will be set by build-steps for build and test.
2834         (UnApplyPatchIfRequired.hideStepIf): Hide this step if it is not run.
2835
2836 2018-07-10  Dewei Zhu  <dewei_zhu@apple.com>
2837
2838         Update ARES-6.patch file accordingly for r233631.
2839         https://bugs.webkit.org/show_bug.cgi?id=187534
2840
2841         Reviewed by Saam Barati.
2842
2843         Update ARES-6.patch file acoordingly after ARES-6 plan file change to
2844         avoid warning while applying the patch.
2845
2846         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ARES-6.patch:
2847
2848 2018-07-10  Tim Horton  <timothy_horton@apple.com>
2849
2850         doAfterNextPresentationUpdate should not be called while content is hidden due to animated resize
2851         https://bugs.webkit.org/show_bug.cgi?id=187500
2852         <rdar://problem/41294139>
2853
2854         Reviewed by Simon Fraser.
2855
2856         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
2857         (-[AnimatedResizeWebView _endAnimatedResize]):
2858         Set didEndAnimatedResize before calling super, because it makes the
2859         new test easier and doesn't affect any of the existing ones.
2860
2861         (AnimatedResizeBlocksViewportFitChanges):
2862         This doAfterNextPresentationUpdate is always called during animated resize,
2863         and then synchronously waited for, so it /must/ use
2864         _doAfterNextPresentationUpdateWithoutWaitingForAnimatedResizeWithTesting.
2865         
2866         (AnimatedResizeBlocksDoAfterNextPresentationUpdate):
2867         Add a test ensuring that doAfterNextPresentationUpdate is deferred
2868         until endAnimatedResize is called.
2869
2870         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
2871         (-[WKWebView _test_waitForDidFinishNavigation]):
2872         _test_waitForDidFinishNavigation is sometimes called during animated resize,
2873         and synchronously waits for a doAfterNextPresentationUpdate, so
2874         it cannot wait for the animated resize to complete.
2875
2876 2018-07-10  Fujii Hironori  <Hironori.Fujii@sony.com>
2877
2878         [GTK][WPE] TestWTF and TestJSC fail to compile due to missing forwarding headers
2879         https://bugs.webkit.org/show_bug.cgi?id=184441
2880
2881         Reviewed by Michael Catanzaro.
2882
2883         All executables of TestWebKitAPI need the forwarding headers of
2884         WebCore and PAL because config.h includes
2885         <WebCore/PlatformExportMacros.h> and <pal/ExportMacros.h>.
2886
2887         The forwarding headers of WebCore are generated by
2888         generate-forwarding-headers.pl in GTK and WPE ports. The
2889         forwarding headers of PAL are generated by
2890         WEBKIT_MAKE_FORWARDING_HEADERS in all CMake ports.
2891
2892         * TestWebKitAPI/PlatformGTK.cmake: Added PALForwardingHeaders to
2893         ForwardingHeadersForTestWebKitAPI_NAME. Added dependencies of
2894         ${ForwardingHeadersForTestWebKitAPI_NAME} to TestJSC.
2895         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
2896
2897 2018-07-10  Stephan Szabo  <stephan.szabo@sony.com>
2898
2899         [WinCairo] Support display of webinspector ui on non-legacy minibrowser
2900         https://bugs.webkit.org/show_bug.cgi?id=187415
2901
2902         Reviewed by Brian Burg.
2903
2904         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2905         (WebKitBrowserWindow::WebKitBrowserWindow):
2906
2907 2018-07-10  John Wilander  <wilander@apple.com>
2908
2909         Resource Load Statistics: Make testRunner.statisticsResetToConsistentState() take a completion handler
2910         https://bugs.webkit.org/show_bug.cgi?id=187499
2911         <rdar://problem/41999431>
2912
2913         Reviewed by Chris Dumez.
2914
2915         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2916         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2917         (WTR::InjectedBundle::didReceiveMessageToPage):
2918         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2919         (WTR::TestRunner::statisticsResetToConsistentState):
2920         (WTR::TestRunner::statisticsCallDidResetToConsistentStateCallback):
2921         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2922         * WebKitTestRunner/TestController.cpp:
2923         (WTR::TestController::statisticsResetToConsistentState):
2924         * WebKitTestRunner/TestInvocation.cpp:
2925         (WTR::TestInvocation::didResetStatisticsToConsistentState):
2926         * WebKitTestRunner/TestInvocation.h:
2927
2928 2018-07-10  Ryosuke Niwa  <rniwa@webkit.org>
2929
2930         Disable cross-origin-window-policy by default
2931         https://bugs.webkit.org/show_bug.cgi?id=187509
2932
2933         Reviewed by Chris Dumez.
2934
2935         Enable the feature for testing purposes. DumpRenderTree does this already in enableExperimentalFeatures.
2936
2937         * WebKitTestRunner/TestController.cpp:
2938         (WTR::TestController::resetPreferencesToConsistentValues):
2939
2940 2018-07-10  Thibault Saunier  <tsaunier@igalia.com>
2941
2942         [Flatpak] Feature options to build-webkit and --makeargs are not passed inside the sandbox
2943         https://bugs.webkit.org/show_bug.cgi?id=187470
2944
2945         Reviewed by Philippe Normand.
2946
2947         Never force building, the user is responsible to make that decision and the workflow is
2948         now based on external scripts so it doesn't make sense anymore. Doing that leads
2949         to ignoring the options the user passed in.
2950
2951         * flatpak/flatpakutils.py:
2952         (WebkitFlatpak.setup_dev_env):
2953
2954 2018-07-10  Thibault Saunier  <tsaunier@igalia.com>
2955
2956         [Flatpak] Fix running wpt tests inside flatpak
2957         https://bugs.webkit.org/show_bug.cgi?id=187490
2958
2959         Reviewed by Philippe Normand.
2960
2961         Still not *all* passing but a big majority do.
2962
2963         * Scripts/webkitpy/w3c/wpt_runner.py:
2964         (main): Generate the /etc/hosts and mount it in flatpak as required.
2965         (WPTRunner.prepare_wpt_checkout): Renamed as we need to first checkout WPT code before generating /etc/hosts.
2966         (WPTRunner._prepare_wpt_checkout): Deleted.
2967         * flatpak/flatpakutils.py: Added a stdout= argument to run_in_sandbox() and
2968         added a way to pass extra env to flatpak itself (so we can mount /etc/hosts).
2969         Stopped passing `--device=all` as it is not required since r233638 (Bug 187400).
2970         * flatpak/org.webkit.WebKit.yaml: Added virtualenv for python2 as required by wpt.
2971
2972 2018-07-10  Thibault Saunier  <tsaunier@igalia.com>
2973
2974         [Flatpak] Use logging to print debug information
2975         https://bugs.webkit.org/show_bug.cgi?id=187496
2976
2977         Reviewed by Philippe Normand.
2978
2979         * flatpak/flatpakutils.py:
2980         (WebkitFlatpak.load_from_args):
2981         (WebkitFlatpak.clean_args):
2982         (WebkitFlatpak.run_in_sandbox):
2983
2984 2018-07-09  Timothy Hatcher  <timothy@apple.com>
2985
2986         Semantic colors don't update when accessibility Increase Contrast mode is enabled.
2987         https://bugs.webkit.org/show_bug.cgi?id=187425
2988         rdar://problem/39948240
2989         rdar://problem/41796865
2990
2991         Reviewed by Tim Horton.
2992
2993         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
2994         (TestWebKitAPI.WebKit.LinkColorWithSystemAppearance): Use new color value.
2995
2996 2018-07-09  Simon Fraser  <simon.fraser@apple.com>
2997
2998         Fix dump-class-layout to show bit padding, and fix issues with padding offsets
2999         https://bugs.webkit.org/show_bug.cgi?id=187442
3000
3001         Reviewed by Daniel Bates.
3002         
3003         Synthetic padding members were shown with the wrong offset because they used the
3004         absolute offset rather than the class-relative offset. This didn't change the padding
3005         math, but made the output confusing.
3006         
3007         Also add support for showing empty bits in bitfields, and fix computation of padding
3008         after bitfields. Empty bits are computed by inserting a bit padding member after
3009         a bitfield that is not followed by another bitfield (making the assumption that bit
3010         padding will fill to the next byte boundary).
3011         
3012         The computation of padding after bitfields was also wrong, since lldb's member_type.GetByteSize()
3013         just reports the size of the type without the bitfield modifier (e.g. for "unsigned : 2" it returned 4).
3014         Fix by setting the byte size for bitfield fields to the number of bits rounded up to the next byte;
3015         this allows byte padding following the bitfield to be computed correctly.
3016         
3017         Add or modify test to cover these issues.
3018
3019         * lldb/dump_class_layout_unittest.py:
3020         (serial_test_ClassWithPaddedBitfields):
3021         (serial_test_MemberHasBitfieldPadding):
3022         (serial_test_InheritsFromClassWithPaddedBitfields):
3023         * lldb/lldbWebKitTester/DumpClassLayoutTesting.cpp:
3024         (avoidClassDeadStripping):
3025         * lldb/lldb_dump_class_layout.py:
3026         (ClassLayoutBase):
3027         (ClassLayoutBase._to_string_recursive):
3028         (ClassLayout._parse):
3029         (ClassLayout._compute_padding_recursive):
3030
3031 2018-07-09  Youenn Fablet  <youenn@apple.com>
3032
3033         StringView operator==(char*) should check the length of the string
3034         https://bugs.webkit.org/show_bug.cgi?id=187422
3035
3036         Reviewed by Chris Dumez.
3037
3038         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3039         (TestWebKitAPI::equal2):
3040         (TestWebKitAPI::TEST):
3041
3042 2018-07-09  Ross Kirsling  <rkirsling@gmail.com>
3043
3044         [WinCairo] httpd service install needs to precede server start
3045         https://bugs.webkit.org/show_bug.cgi?id=187283
3046
3047         Reviewed by Daniel Bates.
3048
3049         * Scripts/webkitpy/port/base.py:
3050         (Port.check_build):
3051         Remove unused parameter `needs_http`.
3052         
3053         (Port.check_sys_deps):
3054         (Port.start_http_server):
3055         Move `check_httpd` call.
3056
3057         * Scripts/webkitpy/port/win.py:
3058         (WinPort.check_httpd): Added.
3059         (WinCairoPort.check_httpd): Deleted.
3060         Move `httpd -k install` logic to common Windows location.
3061
3062         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3063         (Manager._set_up_run):
3064         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3065         * Scripts/webkitpy/port/gtk.py:
3066         (GtkPort.check_sys_deps):
3067         * Scripts/webkitpy/port/ios_simulator.py:
3068         (IOSSimulatorPort.check_sys_deps):
3069         * Scripts/webkitpy/port/mock_drt.py:
3070         (MockDRTPort.check_build):
3071         (MockDRTPort.check_sys_deps):
3072         * Scripts/webkitpy/port/port_testcase.py:
3073         (PortTestCase.integration_test_check_sys_deps):
3074         (test_check_build):
3075         * Scripts/webkitpy/port/test.py:
3076         * Scripts/webkitpy/port/wpe.py:
3077         (WPEPort.check_sys_deps):
3078         * Scripts/webkitpy/tool/commands/perfalizer.py:
3079         (PerfalizerTask.run):
3080         Remove `needs_http` arguments.
3081
3082 2018-07-09  Philippe Normand  <pnormand@igalia.com>
3083
3084         [Flatpak] Unreviewed, switch to https for the gst-libav tarball.
3085         
3086         * flatpak/org.webkit.WebKit.yaml:
3087
3088 2018-07-09  Thibault Saunier  <tsaunier@igalia.com>
3089
3090         [Flatpak] HTTP layout tests broken due to missing CGI.pm in the sandbox
3091         https://bugs.webkit.org/show_bug.cgi?id=187384
3092
3093         Reviewed by Philippe Normand.
3094
3095         And make it usable inside the sandbox even when
3096         perl is launched "tainted" (as the PERL5LIB won't
3097         work otherwise).
3098
3099         * flatpak/flatpakutils.py:
3100         (WebkitFlatpak.run_in_sandbox):
3101         * flatpak/org.webkit.WebKit.yaml:
3102
3103 2018-07-09  Thibault Saunier  <tsaunier@igalia.com>
3104
3105         [WPE][GTK] Mount /dev/shm on /run/shm in sandbox
3106         https://bugs.webkit.org/show_bug.cgi?id=187400
3107
3108         Reviewed by Philippe Normand.
3109
3110         This is where it is expected to be when it is a symlink,
3111         without mounting it the websocket python server can't work
3112         inside the sandbox.
3113
3114         * flatpak/flatpakutils.py:
3115         (WebkitFlatpak.run_in_sandbox):
3116
3117 2018-07-08  Filip Pizlo  <fpizlo@apple.com>
3118
3119         run-benchmark should run ARES-6 1.0.1
3120         https://bugs.webkit.org/show_bug.cgi?id=187452
3121
3122         Reviewed by Sam Weinig.
3123         
3124         We forgot to update this when we released 1.0.1!
3125
3126         * Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan:
3127
3128 2018-07-07  Youenn Fablet  <youenn@apple.com>
3129
3130         WPT importer should create dummy HTML files for *.window.js script files
3131         https://bugs.webkit.org/show_bug.cgi?id=187426
3132
3133         Reviewed by Ryosuke Niwa.
3134
3135         Some WPT tests use *.window.js tests, which should be accessed as *.window.html.
3136         Do the same strategy as done for worker.js/any.js files.
3137
3138         * Scripts/webkitpy/w3c/test_importer.py:
3139         (TestImporter.write_html_files_for_templated_js_tests):
3140
3141 2018-07-07  Wenson Hsieh  <wenson_hsieh@apple.com>
3142
3143         Introduce a layout milestone to track when the document contains a large number of rendered characters
3144         https://bugs.webkit.org/show_bug.cgi?id=187412
3145         <rdar://problem/41744338>
3146
3147         Reviewed by Ryosuke Niwa.
3148
3149         Add a new API test to check that we observe the new rendering milestone in an article-like document.
3150
3151         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3152         * TestWebKitAPI/Tests/WebKitCocoa/significant-text-milestone.html: Added.
3153         * TestWebKitAPI/Tests/ios/RenderingProgressTests.mm:
3154         (TEST):
3155
3156 2018-06-30  Simon Fraser  <simon.fraser@apple.com>
3157
3158         dump-class-layout reports wrong padding in many cases
3159         https://bugs.webkit.org/show_bug.cgi?id=185801
3160
3161         Reviewed by Dan Bates.
3162         
3163         Enhance dump-class-layout, fixing bugs and adding unit tests. This also includes
3164         the patch from bug 187141.
3165         
3166         Move the code that uses lldb to fetch the class layout to its own module,
3167         lldb_dump_class_layout.py, so it can be unit tested. Change this code
3168         to build up a data structure for the class. This is necessary since correct
3169         padding computation is easier with second traversal over the data structure.
3170         
3171         Try to deal with the empty base class optimization, which is necessary to report
3172         correct padding in classes using std::unique_ptr, and correctly handle virtual base classes.
3173         
3174         The ClassLayoutBase class knows how to test for equality and generate a string
3175         or string list representation of itself. The derived ClassLayout class knows
3176         how to build up the class layout using the lldb Python bindings.
3177         
3178         Finally we wrap the lldb debugger instance in LLDBDebuggerInstance so that we don't
3179         have to make a new one for each unit test. The tests have to run serially.
3180         
3181         Add to lldbWebKitTester a .cpp file that contains a set of C++ classes to unit-test
3182         dump-class-layout.
3183
3184         * Scripts/dump-class-layout:
3185         (main):
3186         * lldb/dump_class_layout_unittest.py:
3187         (destroy_cached_debug_session):
3188         (TestDumpClassLayout):
3189         (TestDumpClassLayout.setUpClass):
3190         (TestDumpClassLayout.setUp):
3191         (TestDumpClassLayout.serial_test_BasicClassLayout):
3192         (serial_test_PaddingBetweenClassMembers):
3193         (serial_test_BoolPaddingClass):
3194         (serial_test_ClassWithEmptyClassMembers):
3195         (serial_test_SimpleVirtualClass):
3196         (serial_test_SimpleVirtualClassWithNonVirtualBase):
3197         (serial_test_InterleavedVirtualNonVirtual):
3198         (serial_test_ClassWithTwoVirtualBaseClasses):
3199         (serial_test_ClassWithClassMembers):
3200         (serial_test_ClassWithBitfields):
3201         (serial_test_ClassWithUniquePtrs):
3202         (serial_test_ClassWithOptionals):
3203         (TestDumpClassLayout.test_BasicClassLayout): Deleted.
3204         * lldb/lldbWebKitTester/DumpClassLayoutTesting.cpp:
3205         (EmptyClass::doStuff):
3206         (VirtualBaseClass::~VirtualBaseClass):
3207         (VirtualBaseClass2::~VirtualBaseClass2):
3208         (SimpleVirtualClass::~SimpleVirtualClass):
3209         (SimpleVirtualClass::doStuff):
3210         (SimpleVirtualClassWithNonVirtualBase::~SimpleVirtualClassWithNonVirtualBase):
3211         (SimpleVirtualClassWithNonVirtualBase::doStuff):
3212         (avoidClassDeadStripping):
3213         * lldb/lldb_dump_class_layout.py:
3214         (ansi_colors):
3215         (ClassLayoutBase):
3216         (ClassLayoutBase.__init__):
3217         (ClassLayoutBase.__ne__):
3218         (ClassLayoutBase.__eq__):
3219         (ClassLayoutBase._to_string_recursive):
3220         (ClassLayoutBase.as_string_list):
3221         (ClassLayoutBase.as_string):
3222         (ClassLayoutBase.dump):
3223         (ClassLayoutExpected):
3224         (ClassLayoutExpected.__init__):
3225         (ClassLayout):
3226         (ClassLayout.__init__):
3227         (ClassLayout._has_polymorphic_base_class):
3228         (ClassLayout._parse):
3229         (ClassLayout._probably_has_empty_base_class_optimization):
3230         (ClassLayout._compute_padding_recursive):
3231         (ClassLayout._compute_padding):
3232         (LLDBDebuggerInstance):
3233         (LLDBDebuggerInstance.__init__):
3234         (LLDBDebuggerInstance.__del__):
3235         (LLDBDebuggerInstance._get_first_file_architecture):
3236         (LLDBDebuggerInstance.layout_for_classname):
3237         (ClassLayoutDumper): Deleted.
3238         (ClassLayoutDumper.__init__): Deleted.
3239         (ClassLayoutDumper._get_first_file_architecture): Deleted.
3240         (ClassLayoutDumper.verify_type): Deleted.
3241         (ClassLayoutDumper.verify_type_recursive): Deleted.
3242         (ClassLayoutDumper._class_layout_as_string): Deleted.
3243         (ClassLayoutDumper.dump_to_string): Deleted.
3244         (ClassLayoutDumper.dump): Deleted.
3245
3246 2018-07-06  Christopher Reid  <chris.reid@sony.com>
3247
3248         [WinCairo] WebKit MiniBrowser crashes when attempting to navigate to certain URLs
3249         https://bugs.webkit.org/show_bug.cgi?id=187167
3250
3251         Reviewed by Alex Christensen.
3252
3253         A null byte was written past the end of the buffer causing the crash.
3254         Some of the heap allocated buffers were also not getting deleted.
3255
3256         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3257
3258 2018-07-06  Thibault Saunier  <tsaunier@igalia.com>
3259
3260         [WPE][GTK] Build php zlib plugin and enable sockets in flatpak
3261         https://bugs.webkit.org/show_bug.cgi?id=187401
3262
3263         Reviewed by Philippe Normand.
3264
3265         * flatpak/org.webkit.WebKit.yaml:
3266
3267 2018-07-06  Aakash Jain  <aakash_jain@apple.com>
3268
3269         [ews-build] EWS should run javascriptcore tests
3270         https://bugs.webkit.org/show_bug.cgi?id=187365
3271
3272         Reviewed by David Kilzer.
3273
3274         * BuildSlaveSupport/ews-build/steps.py: Added step to run JavaScriptCoreTests.
3275         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3276         * BuildSlaveSupport/ews-build/factories.py:
3277
3278 2018-07-06  Carlos Garcia Campos  <cgarcia@igalia.com>
3279
3280         [GTK][WPE] REGRESSION(r233111): Test /webkit/WebKitUserContentManager/script-message-received fails
3281         https://bugs.webkit.org/show_bug.cgi?id=187383
3282
3283         Reviewed by Žan Doberšek.
3284
3285         This is actually a problem in the test itself. The problem is that we run js, connect to message-received and
3286         quite the main loop when the message is received, which happens before the run js operation has been
3287         completed. The test finishes early and since r233111 an IPC message is still pending (I guess the run js
3288         callback) and the web page is still protected. Just adding a run loop operation before finishing the test would
3289         fix it. We should wait for the js run to complete, instead of the message.
3290
3291         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
3292         (UserScriptMessageTest::scriptMessageReceived):
3293         (UserScriptMessageTest::waitUntilMessageReceived):
3294         (UserScriptMessageTest::runJavaScriptFinished):
3295         (UserScriptMessageTest::postMessageAndWaitUntilReceived):
3296
3297 2018-07-05  Youenn Fablet  <youenn@apple.com>
3298
3299         REGRESSION (r230843): Flash doesn't work; Produces blue box on page
3300         https://bugs.webkit.org/show_bug.cgi?id=187346
3301         <rdar://problem/41773974>
3302
3303         Reviewed by Ryosuke Niwa.
3304
3305         * WebKitTestRunner/TestController.cpp:
3306         (WTR::TestController::resetStateToConsistentValues):
3307         (WTR::TestController::setBlockAllPlugins):
3308         When not blocked, set the load policy to allow once.
3309         * WebKitTestRunner/TestController.h:
3310
3311 2018-07-05  Aakash Jain  <aakash_jain@apple.com>
3312
3313         [ews-build] Bindings-tests-EWS should output result in json
3314         https://bugs.webkit.org/show_bug.cgi?id=187330
3315
3316         Reviewed by David Kilzer.
3317
3318         * BuildSlaveSupport/ews-build/steps.py:
3319         (RunBindingsTests):  Passed --json-output parameter to run-bindings-tests.
3320         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
3321
3322 2018-07-05  Aakash Jain  <aakash_jain@apple.com>
3323
3324         [ews-build] WebKitPy-Tests-EWS should output result in json
3325         https://bugs.webkit.org/show_bug.cgi?id=187331
3326
3327         Follow-up fix to r233527. Extracting jsonFileName as a variable and re-using it.
3328
3329 2018-07-05  Aakash Jain  <aakash_jain@apple.com>
3330
3331         [ews-build] WebKitPy-Tests-EWS should output result in json
3332         https://bugs.webkit.org/show_bug.cgi?id=187331
3333
3334         Reviewed by David Kilzer.
3335
3336         * BuildSlaveSupport/ews-build/steps.py:
3337         (RunWebKitPyTests): Passed --json-output parameter to test-webkitpy.
3338         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
3339
3340 2018-07-05  Philippe Normand  <pnormand@igalia.com>
3341
3342         [Flatpak] Add gst-libav to dependencies
3343         https://bugs.webkit.org/show_bug.cgi?id=187340
3344
3345         Reviewed by Žan Doberšek.
3346
3347         * flatpak/org.webkit.WebKit.yaml: Use tarballs instead of git
3348         clones because the FFMPeg git server doesn't support shallow
3349         clones.
3350
3351 2018-07-05  Thibault Saunier  <tsaunier@igalia.com>
3352
3353         [WPE][GTK]: Call gtk platform 'gtk' by default as this is what PortFactory expects
3354         https://bugs.webkit.org/show_bug.cgi?id=187322
3355
3356         Reviewed by Žan Doberšek.
3357
3358         * flatpak/flatpakutils.py:
3359         (WebkitFlatpak.__init__):
3360
3361 2018-07-05  Zan Dobersek  <zdobersek@igalia.com>
3362
3363         Unreviewed, rolling out r233511.
3364
3365         Proper fix provided in bug #187322
3366
3367         Reverted changeset:
3368
3369         "Unreviewed. Fixing a call in flatpakutils.py to
3370         PortFactory.get(),"
3371         https://trac.webkit.org/changeset/233511
3372
3373 2018-07-04  Zan Dobersek  <zdobersek@igalia.com>
3374
3375         Unreviewed. Fixing a call in flatpakutils.py to PortFactory.get(),
3376         enforcing the passed platform argument to always be lowercase, as is
3377         expected from the PortFactory code.
3378
3379         * flatpak/flatpakutils.py:
3380         (WebkitFlatpak.clean_args):
3381
3382 2018-07-04  Tim Horton  <timothy_horton@apple.com>
3383
3384         Introduce PLATFORM(IOSMAC)
3385         https://bugs.webkit.org/show_bug.cgi?id=187315
3386
3387         Reviewed by Dan Bernstein.
3388
3389         * TestWebKitAPI/Configurations/Base.xcconfig:
3390         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3391
3392 2018-07-03  Brady Eidson  <beidson@apple.com>
3393
3394         WebKit.ResponsivenessTimerCrash sometimes fails.
3395         https://bugs.webkit.org/show_bug.cgi?id=187314
3396
3397         Reviewed by Tim Horton.
3398
3399         Actually unregister observers from objects we're about to destroy before destroying them.
3400
3401         * TestWebKitAPI/Tests/WebKit/ResponsivenessTimerCrash.mm:
3402         (-[ResponsivenessTimerObserver observeValueForKeyPath:ofObject:change:context:]): 
3403
3404 2018-07-03  Fujii Hironori  <Hironori.Fujii@sony.com>
3405
3406         update-webkitgtk-flatpak fails if running with python2
3407         https://bugs.webkit.org/show_bug.cgi?id=187240
3408
3409         Reviewed by Michael Catanzaro.
3410
3411         urllib.urlretrieve of Python2 sends invalid requests. Use
3412         urllib2.urlopen instead.
3413
3414         * flatpak/flatpakutils.py: Import urllib2.urlopen for Python2,
3415         urllib.request.urlopen for Python3.
3416         (FlatpakRepo.repo_file): Copy the content of urlopen result to the
3417         temporary file.
3418
3419 2018-07-03  Chris Dumez  <cdumez@apple.com>
3420
3421         Make CallbackMap::invalidate() safe to re-enter
3422         https://bugs.webkit.org/show_bug.cgi?id=187298
3423         <rdar://problem/41057167>
3424
3425         Reviewed by Geoffrey Garen.
3426
3427         Add API test coverage.
3428
3429         * TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm:
3430         (TEST):
3431
3432 2018-07-03  Chris Dumez  <cdumez@apple.com>
3433
3434         [Cocoa] Disable vnode guard related simulated crashes for WKTR / DRT and WebSQL
3435         https://bugs.webkit.org/show_bug.cgi?id=187270
3436         <rdar://problem/40674034>
3437
3438         Reviewed by Geoffrey Garen.
3439
3440         Disable vnode guard related simulated crashes for WKTR / DRT by setting the
3441         expected environment variable in the test driver.
3442
3443         * Scripts/webkitpy/port/driver.py:
3444         (Driver._setup_environ_for_driver):
3445
3446 2018-07-03  Eric Carlson  <eric.carlson@apple.com>
3447
3448         Video sometimes flickers when playing to AppleTV
3449         https://bugs.webkit.org/show_bug.cgi?id=187193
3450         <rdar://problem/40153865>
3451
3452         Unreviewed, fix test broken by r233435.
3453
3454         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
3455         (TestWebKitAPI::waitUntilAudioSessionCategoryIsEqualTo): Poll for a change in audio session 
3456         category because it doesn't necessarily happen synchronously.
3457         (TestWebKitAPI::TEST):
3458
3459 2018-07-03  Thibault Saunier  <tsaunier@igalia.com>
3460
3461         Unreviewed, add myself as a WebKit committer.
3462
3463         And canonicalize the file as suggested by `check-webkit-style`
3464
3465         * Scripts/webkitpy/common/config/contributors.json:
3466
3467 2018-07-03  Basuke Suzuki  <Basuke.Suzuki@sony.com>
3468
3469         check-webkit-style: Run the tool without SVN client.
3470         https://bugs.webkit.org/show_bug.cgi?id=187294
3471
3472         Reviewed by Daniel Bates.
3473
3474         When invoking check-webkit-style without SVN client, the exception was raised and terminated.
3475         Using Git repository is acceptable workflow according to the wording on:
3476         <https://webkit.org/getting-the-code/#checking-out-with-git>
3477         and using Subversion is considered optional by following link:
3478         <https://webkit.org/webkit-on-windows/#installing-developer-tools>.
3479         This patch makes it so that people with only a Git checkout of WebKit that commit using
3480         the commit-queue (or another machine with an SVN checkout) can run check-webkit-style.
3481
3482         * Scripts/webkitpy/common/checkout/scm/svn.py:
3483         (SVN.in_working_directory):
3484
3485 2018-07-03  Aakash Jain  <aakash_jain@apple.com>
3486
3487         Remove old JSCTestsFactory
3488
3489         Follow-up fix to r233471.
3490
3491 2018-07-03  Aakash Jain  <aakash_jain@apple.com>
3492
3493         [ews-build] Add support for JSC-Tests-EWS
3494         https://bugs.webkit.org/show_bug.cgi?id=187201
3495
3496         Reviewed by Lucas Forschler.
3497
3498         * BuildSlaveSupport/ews-build/factories.py:
3499         (JSCTestsFactory): Added JSCTestsFactory.
3500         * BuildSlaveSupport/ews-build/steps.py:
3501         (CompileJSCOnly): Command to compile JSC.
3502         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
3503         * BuildSlaveSupport/ews-build/config.json: Changed platform to jsc-only. This matches with build.webkit.org configuration.
3504
3505 2018-07-03  Zalan Bujtas  <zalan@apple.com>
3506
3507         [LFC] Add test-list file for regression testing
3508         https://bugs.webkit.org/show_bug.cgi?id=187296
3509
3510         Reviewed by Antti Koivisto.
3511
3512         run-webkit-tests --test-list=./Tools/LayoutReloaded/misc/LFC-passing-tests.txt
3513
3514         * LayoutReloaded/misc/LFC-passing-tests.txt: Added.
3515
3516 2018-07-03  John Wilander  <wilander@apple.com>
3517
3518         Resource Load Statistics: Make WebsiteDataStore::getAllStorageAccessEntries() call the right network process instead of iterating over the process pools
3519         https://bugs.webkit.org/show_bug.cgi?id=187277
3520         <rdar://problem/41745510>
3521
3522         Reviewed by Chris Dumez.
3523
3524         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3525         (WTR::TestController::getAllStorageAccessEntries):
3526
3527 2018-07-02  Wenson Hsieh  <wenson_hsieh@apple.com>
3528
3529         Fix a leak in ActionSheetTests.DismissingActionSheetShouldNotDismissPresentingViewController
3530         https://bugs.webkit.org/show_bug.cgi?id=187280
3531
3532         Reviewed by Tim Horton.
3533
3534         Add a missing `adoptNS()`.
3535
3536         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
3537         (TestWebKitAPI::TEST):
3538
3539 2018-07-02  Myles C. Maxfield  <mmaxfield@apple.com>
3540
3541         [Cocoa] Google Fonts doesn't work if the user has the requested font locally-installed
3542         https://bugs.webkit.org/show_bug.cgi?id=187228
3543         <rdar://problem/40967280>
3544
3545         Reviewed by Brent Fulgham.
3546
3547         The test only fails before the patch if the lookup for Helvetica2 is allowed to occur.
3548
3549         * WebKitTestRunner/mac/TestControllerMac.mm:
3550         (WTR::allowedFontFamilySet):
3551
3552 2018-07-02  Ryosuke Niwa  <rniwa@webkit.org>
3553
3554         run-benchmark should include the version number of MotionMark's results
3555         https://bugs.webkit.org/show_bug.cgi?id=187274
3556
3557         Reviewed by Jon Lee.
3558
3559         Append the version number as a part of the suite name.
3560
3561         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/MotionMark.patch:
3562
3563 2018-07-02  Wenson Hsieh  <wenson_hsieh@apple.com>
3564
3565         [WK1] editing/spelling/markers.html is failing on recent builds of macOS Mojave
3566         https://bugs.webkit.org/show_bug.cgi?id=187253
3567
3568         Reviewed by Tim Horton.
3569
3570         Enhances and refactors LayoutTestSpellChecker, which was introduced in r233412.
3571
3572         * DumpRenderTree/TestRunner.cpp:
3573         (setSpellCheckerResultsCallback):
3574
3575         Rename setSpellCheckerTextReplacements to setSpellCheckerResults.
3576
3577         (TestRunner::staticFunctions):
3578         (setSpellCheckerTextReplacementsCallback): Deleted.
3579         * DumpRenderTree/TestRunner.h:
3580         * DumpRenderTree/mac/TestRunnerMac.mm:
3581         (TestRunner::setSpellCheckerResults):
3582         (TestRunner::setSpellCheckerTextReplacements): Deleted.
3583         * DumpRenderTree/win/TestRunnerWin.cpp:
3584         (TestRunner::setSpellCheckerResults):
3585         (TestRunner::setSpellCheckerTextReplacements): Deleted.
3586         * TestRunnerShared/cocoa/LayoutTestSpellChecker.h:
3587         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
3588         (-[LayoutTestTextCheckingResult initWithType:range:replacement:details:]):
3589         (-[LayoutTestTextCheckingResult grammarDetails]):
3590         (-[LayoutTestSpellChecker reset]):
3591         (-[LayoutTestSpellChecker results]):
3592         (-[LayoutTestSpellChecker setResults:]):
3593         (-[LayoutTestSpellChecker setResultsFromJSObject:inContext:]):
3594
3595         Add support for passing in a list of grammar correction detail ranges. Necessary for simulating grammar errors.
3596
3597         (-[LayoutTestSpellChecker checkString:range:types:options:inSpellDocumentWithTag:orthography:wordCount:]):
3598
3599         Tweaked to always call the superclass method. This ensures that we set the `orthography` and `wordCount`
3600         outpointers if applicable.
3601
3602         (-[LayoutTestSpellChecker requestCheckingOfString:range:types:options:inSpellDocumentWithTag:completionHandler:]):
3603
3604         Added support for simulating asynchronous spell checking.
3605
3606         (-[LayoutTestTextCheckingResult initWithType:range:replacement:]): Deleted.
3607         (-[LayoutTestSpellChecker replacements]): Deleted.
3608         (-[LayoutTestSpellChecker setReplacements:]): Deleted.
3609         (-[LayoutTestSpellChecker setReplacementsFromJSObject:inContext:]): Deleted.
3610
3611 2018-07-02  Brady Eidson  <beidson@apple.com>
3612
3613         Another unreviewed followup to:
3614         Crash notifying observers of responsiveness state change
3615
3616         * TestWebKitAPI/cocoa/TestWKWebView.h:
3617         * TestWebKitAPI/cocoa/TestWKWebView.mm: