2d31863bcfea7de9a7fb01676c526a9f2a00451e
[WebKit-https.git] / Tools / ChangeLog
1 2011-01-24  Mikhail Naganov  <mnaganov@chromium.org>
2
3         Reviewed by Yury Semikhatsky.
4
5         Web Inspector: Find duplicate strings in localizedStrings.js
6
7         https://bugs.webkit.org/show_bug.cgi?id=53005
8
9         * Scripts/check-inspector-strings:
10
11 2011-01-24  Zoltan Horvath  <zoltan@webkit.org>
12
13         Reviewed by Andreas Kling.
14
15         [Qt] Regroup MiniBrowser's menubar and add open file action
16         https://bugs.webkit.org/show_bug.cgi?id=53000
17
18         Add File and Develop menu to MiniBrowser's menubar and add open file action to File menu.
19
20         * MiniBrowser/qt/BrowserWindow.cpp:
21         (BrowserWindow::BrowserWindow):
22         (BrowserWindow::openFile):
23         (BrowserWindow::~BrowserWindow):
24         * MiniBrowser/qt/BrowserWindow.h:
25
26 2011-01-24  Csaba Osztrogonác  <ossy@webkit.org>
27
28         Unreviewed fix after r76496
29
30         [Qt] Move project files into Source
31         https://bugs.webkit.org/show_bug.cgi?id=52891
32
33         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Remove unnecessary "Source" from the path.
34         * BuildSlaveSupport/built-product-archive: Remove unnecessary "Source" from the path.
35         * Scripts/webkitdirs.pm: Add the accidentally removed slash to the path.
36
37 2011-01-24  Andras Becsi  <abecsi@webkit.org>
38
39         Reviewed by Csaba Osztrogonác.
40
41         [Qt] Move project files into Source
42         https://bugs.webkit.org/show_bug.cgi?id=52891
43
44         * DerivedSources.pro: Renamed from DerivedSources.pro.
45         * DumpRenderTree/qt/DumpRenderTree.pro:
46         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
47         * MiniBrowser/DerivedSources.pro:
48         * MiniBrowser/qt/MiniBrowser.pro:
49         * QtTestBrowser/QtTestBrowser.pro:
50         * Scripts/webkitdirs.pm:
51         * Tools.pro: Added.
52         * WebKitTestRunner/DerivedSources.pro:
53         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
54         * WebKitTestRunner/qt/WebKitTestRunner.pro:
55
56 2011-01-22  Geoffrey Garen  <ggaren@apple.com>
57
58         Reviewed by Dan Bernstein.
59
60         Beefed up --threaded mode to catch even more kinds of errors.
61         https://bugs.webkit.org/show_bug.cgi?id=52971
62
63         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Use a shared
64         context group to force JSC to mark multiple threads. (This used to be
65         the default, but it changed in SnowLeopard.)
66         (runJavaScriptThread): Do more locking and unlocking, and more allocation,
67         to give threading mistakes more chances to show themselves.
68         (startJavaScriptThreads):
69         (stopJavaScriptThreads):
70
71 2011-01-22  Robert Hogan  <robert@webkit.org>
72
73         Reviewed by Andreas Kling.
74
75         [Qt] Support layoutTestController.addURLToRedirect()
76         https://bugs.webkit.org/show_bug.cgi?id=52956
77
78         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
79         (LayoutTestController::addURLToRedirect):
80         * DumpRenderTree/qt/LayoutTestControllerQt.h:
81
82 2011-01-22  Robert Hogan  <robert@webkit.org>
83
84         Reviewed by Kenneth Rohde Christiansen.
85
86         [Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
87         https://bugs.webkit.org/show_bug.cgi?id=49802
88
89         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
90         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
91         (WebCore::DumpRenderTree::open):
92
93 2011-01-21  Adam Barth  <abarth@webkit.org>
94
95         Reviewed by Maciej Stachowiak.
96
97         Disable mac_unittest.py that fails on some of the Mac bots
98         https://bugs.webkit.org/show_bug.cgi?id=52947
99
100         As noted in the comment, this test does not appear to be correct
101         because the function this test is testing returns different results
102         depending on which flavor of Mac the test is run on.  This patch
103         disable the test.  Hopefully we can re-enable the test once we've
104         probably insulated the test from its environment.
105
106         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
107
108 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
109
110         Reviewed by Mihai Parparita.
111
112         Fix bug introduced in r76322 that caused NRWT to not actually
113         read the Skipped files properly.
114
115         https://bugs.webkit.org/show_bug.cgi?id=52771
116
117         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
118         * Scripts/webkitpy/layout_tests/port/webkit.py:
119         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
120
121 2011-01-21  Sam Weinig  <sam@webkit.org>
122
123         Reviewed by Geoffrey Sean Garen and Mark Rowe.
124
125         WebKitTestRunner needs the HOME environment variable to be set.
126         <rdar://problem/8896573>
127
128         * Scripts/old-run-webkit-tests: Set the HOME environment variable if
129         it exists.
130
131 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
132
133         Reviewed by Eric Seidel.
134
135         Suppress a few remaining integration tests so that none of the
136         layout_test unit tests ever read from the filesystem or launch
137         subprocesses that aren't part of the unit tests.
138
139         Also fix a minor bug in the printing unit tests that was
140         incorrectly relying on sys.argv.
141
142         https://bugs.webkit.org/show_bug.cgi?id=52863
143
144         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
145         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
146         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
147
148 2011-01-21  Darin Adler  <darin@apple.com>
149
150        Fix Mac build.
151
152         * MiniBrowser/mac/BrowserWindowController.m:
153         (-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.
154
155 2011-01-20  Darin Adler  <darin@apple.com>
156
157         Reviewed by Dan Bernstein.
158
159         WebKit2: Implement showModalDialog
160         https://bugs.webkit.org/show_bug.cgi?id=52855
161
162         This fixes WebKitTestRunner to compile, but more work is probably
163         needed to get it to pass the tests.
164
165         * WebKitTestRunner/TestController.cpp:
166         (WTR::TestController::runModal): Added. Calls through to the
167         platform-specific version of runModal.
168         (WTR::TestController::createOtherPage): Changed to be a private
169         static member function so it can refer to runModal, which is
170         a private static member function.
171         (WTR::TestController::initialize): Pass 0 for the runModal
172         function since we don't need to run the main window modal.
173         I suspect this is wrong and will need to change.
174         * WebKitTestRunner/TestController.h: Added declarations for
175         the functions added above.
176         * WebKitTestRunner/mac/TestControllerMac.mm:
177         (WTR::TestController::runModal): Added. Untested implementation.
178         * WebKitTestRunner/qt/TestControllerQt.cpp:
179         (WTR::TestController::runModal): Added.
180         * WebKitTestRunner/win/TestControllerWin.cpp:
181         (WTR::TestController::runModal): Added.
182
183 2011-01-21  Eric Seidel  <eric@webkit.org>
184
185         Reviewed by Adam Barth.
186
187         Split Host object off from WebKitPatch for easier re-use
188         https://bugs.webkit.org/show_bug.cgi?id=52284
189
190         new-run-webkit-tests and other tools are eventually going to want one of these.
191         Basically you need to inherit from this class if you want to pretend to be a
192         self.tool object for Steps/Commands.
193
194         * Scripts/webkitpy/common/host.py: Added.
195         * Scripts/webkitpy/tool/main.py:
196
197 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
198
199         Reviewed by Adam Barth.
200
201         Disable the tests that start and stop the http server and web
202         server, so that we don't have to worry about port collisions on
203         the bots.
204
205         https://bugs.webkit.org/show_bug.cgi?id=52861
206
207         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
208
209 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
210
211         Reviewed by Eric Seidel.
212
213         nrwt: rewrite google_chrome_unittest to use mock filesystem.
214         
215         https://bugs.webkit.org/show_bug.cgi?id=52772
216         
217         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
218
219 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
220
221         Reviewed by Eric Siedel.
222
223         nrwt: clean up almost all remaining port references, remove
224         unnecessary import clauses. The only remaining references are
225         in places where a mock filesystem makes no sense or can't be
226         used, and in one routine in port/google_chrome_unittest that
227         I'll rewrite in a separate patch.
228
229         https://bugs.webkit.org/show_bug.cgi?id=52771
230
231         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
232         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
233         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
234         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
235         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
236         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
237         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
238         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
239         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
240         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
241         * Scripts/webkitpy/layout_tests/port/gtk.py:
242         * Scripts/webkitpy/layout_tests/port/mac.py:
243         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
244         * Scripts/webkitpy/layout_tests/port/qt.py:
245         * Scripts/webkitpy/layout_tests/port/webkit.py:
246         * Scripts/webkitpy/layout_tests/port/win.py:
247         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
248
249 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
250
251         Reviewed by Mihai Parparita.
252
253         remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests
254
255         https://bugs.webkit.org/show_bug.cgi?id=52762
256
257         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
258         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
259
260 2011-01-20  Tony Chang  <tony@chromium.org>
261
262         Reviewed by Ojan Vafai.
263
264         [chromium] fix the paths used for the rebaseline tool
265         https://bugs.webkit.org/show_bug.cgi?id=52857
266
267         Some of the bots were renamed so the path to grab the results zip
268         file has changed.
269
270         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
271
272 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
273
274         Reviewed by Tony Chang.
275
276         Fix bug introduced in r72688 / bug 52768 that broke the
277         generation of the output filename links in the results.html
278         output. Apparently none of the unit tests actually checked to
279         make sure the generated links were correct :(
280
281         https://bugs.webkit.org/show_bug.cgi?id=52854
282
283         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
284         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
285
286 2011-01-20  Alexey Proskuryakov  <ap@apple.com>
287
288         Reviewed by Darin Adler.
289
290         https://bugs.webkit.org/show_bug.cgi?id=52849
291         Make window.print work with WebKit2
292
293         * MiniBrowser/mac/BrowserWindowController.m:
294         (-[BrowserWindowController awakeFromNib]):
295         * WebKitTestRunner/TestController.cpp:
296         (WTR::createOtherPage):
297         (WTR::TestController::initialize):
298         Added zeroes to WKPageUIClient structures to avoid build failures.
299
300 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
301
302         Reviewed by Eric Seidel.
303
304         nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
305
306         https://bugs.webkit.org/show_bug.cgi?id=52756
307
308         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
309         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
310         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
311         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
312         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
313         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
314
315 2011-01-20  Mansi Mithal  <mansi.mithal@nokia.com>
316
317         Reviewed by Antonio Gomes.
318
319         QtTestBrowser should have a seperate menu for Settings
320         https://bugs.webkit.org/show_bug.cgi?id=52817
321         
322         Added a new menu item named "Settings"
323         and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu 
324
325         * QtTestBrowser/launcherwindow.cpp:
326         (LauncherWindow::createChrome):
327
328 2011-01-20  Sam Weinig  <sam@webkit.org>
329
330         Reviewed by John Sullivan.
331
332         Update update-webkit-localizable-strings with new path to WebKit.
333
334         * Scripts/update-webkit-localizable-strings:
335
336 2011-01-20  James Robinson  <jamesr@chromium.org>
337
338         Reviewed by Darin Fisher.
339
340         Implement mozilla's requestAnimationFrame API
341         https://bugs.webkit.org/show_bug.cgi?id=51218
342
343         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
344
345         * DumpRenderTree/chromium/WebViewHost.cpp:
346         (invokeScheduleComposite):
347         (WebViewHost::scheduleAnimation):
348         (WebViewHost::paintInvalidatedRegion):
349         * DumpRenderTree/chromium/WebViewHost.h:
350
351 2011-01-20  Maciej Stachowiak  <mjs@apple.com>
352
353         Reviewed by Adam Roben.
354
355         WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
356         https://bugs.webkit.org/show_bug.cgi?id=42327
357
358         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
359         for methods that take their normal arguments but also a JSContextRef.
360         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
361         for evaluateScriptInIsolatedWorld.
362         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
363         (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
364         this call is for an isolated world.
365         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
366         (WTR::worldMap): Helper to create a world map.
367         (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
368         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
369         added LayoutTestController API.
370         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
371
372 2011-01-19  Adam Roben  <aroben@apple.com>
373
374         Convert paths in environment variables back to msys-style inside commit-log-editor
375
376         When this script gets run from inside git commit, msys-style paths in the environment will
377         have been turned into Windows-style paths with forward slashes. This screws up functions
378         like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
379         the paths back to msys-style before doing anything else.
380
381         Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
382         using msysgit's Perl and multiple ChangeLogs have been edited
383
384         Reviewed by David Kilzer.
385
386         * Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
387         (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
388         inside git commit), convert Windows-style paths in the environment back to msys-style paths.
389
390 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
391
392         [Win] Unreviewed build fix after r76248.
393
394         * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
395
396 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
397
398         Reviewed by Csaba Osztrogonác.
399
400         Refactoring of the custom allocation framework
401         https://bugs.webkit.org/show_bug.cgi?id=49897
402
403         Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
404         The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
405         equivalent macro implementation at the necessary places.
406 2011-01-20  Yi Shen  <yi.4.shen@nokia.com>
407
408         Unreviewed. 
409
410         Adding myself to committers.py.
411
412         * Scripts/webkitpy/common/config/committers.py:
413
414 2011-01-20  Adam Barth  <abarth@webkit.org>
415
416         Reviewed by Tony Chang.
417
418         Chromium builders don't delete unversioned directories when DEPS change
419         https://bugs.webkit.org/show_bug.cgi?id=52745
420
421         If we pass this option to gclient sync, gclient will delete directories
422         that are no longer part of DEPS instead of leaving them around to
423         confuse us later.  Apparently, the downstream buildbots use this option
424         already.
425
426         * Scripts/update-webkit-chromium:
427
428 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
429
430         Unreviewed, build fix - I pulled this patch in to fix an issue
431         revealed by r76195 running on some new bots). Also fix a couple
432         of other issues revealed in testing.
433
434         nrwt: remove fs refs from layout_package/json*
435
436         https://bugs.webkit.org/show_bug.cgi?id=52754
437
438         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
439         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
440         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
441         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
442         * Scripts/webkitpy/layout_tests/port/base.py:
443
444 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
445
446         Unreviewed, build fix.
447
448         Fix a couple of minor bugs discovered while bringing up new bots
449         for testing.
450
451         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
452         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
453
454 2011-01-19  James Robinson  <jamesr@chromium.org>
455
456         Unreviewed, rolling out r76194.
457         http://trac.webkit.org/changeset/76194
458         https://bugs.webkit.org/show_bug.cgi?id=51218
459
460         Caused mysterious compile failure on the chromium win
461         build.webkit.org bots
462
463         * DumpRenderTree/chromium/WebViewHost.cpp:
464         (WebViewHost::paintInvalidatedRegion):
465         * DumpRenderTree/chromium/WebViewHost.h:
466
467 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
468
469         Reviewed by Mihai Parparita.
470
471         remove fs refs from test_runner, dump_render_tree_thread
472
473         https://bugs.webkit.org/show_bug.cgi?id=52753
474
475         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
476         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
477         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
478         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
479
480 2011-01-19  James Robinson  <jamesr@chromium.org>
481
482         Reviewed by Darin Fisher.
483
484         Implement mozilla's requestAnimationFrame API
485         https://bugs.webkit.org/show_bug.cgi?id=51218
486
487         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
488
489         * DumpRenderTree/chromium/WebViewHost.cpp:
490         (invokeScheduleComposite):
491         (WebViewHost::scheduleAnimation):
492         (WebViewHost::paintInvalidatedRegion):
493         * DumpRenderTree/chromium/WebViewHost.h:
494
495 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
496
497         Unreviewed, build fix.
498
499         Fix a few incorrect "self._filesystem" references introduced in
500         r76184.
501
502         * Scripts/webkitpy/layout_tests/port/chromium.py:
503         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
504
505 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
506
507         Reviewed by Mihai Parparita.
508
509         add a .sep property, abspath(), isabs(), mtime(), and
510         open_text_file_for_writing() to filesystem modules. Some of
511         these properties are not needed in this patch but will be needed
512         in subsequent patches (I'm doing this to avoid having to track
513         multiple versions of a single file).
514
515         Also, change most of the port/* modules to use the filesystem
516         objects instead of referencing the filesystem directly.
517
518         https://bugs.webkit.org/show_bug.cgi?id=52748
519
520         * Scripts/webkitpy/common/system/filesystem.py:
521         * Scripts/webkitpy/common/system/filesystem_mock.py:
522         * Scripts/webkitpy/layout_tests/port/__init__.py:
523         * Scripts/webkitpy/layout_tests/port/base.py:
524         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
525         * Scripts/webkitpy/layout_tests/port/chromium.py:
526         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
527         * Scripts/webkitpy/layout_tests/port/config.py:
528         * Scripts/webkitpy/layout_tests/port/test.py:
529         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
530
531 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
532
533         Reviewed by Anders Carlsson.
534
535         If resetting between tests times out, treat it as a WebProcess crash
536         https://bugs.webkit.org/show_bug.cgi?id=52757
537
538         * WebKitTestRunner/TestController.cpp:
539         (WTR::TestController::runTest):
540
541 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
542
543         Reviewed by Darin Adler.
544
545         https://bugs.webkit.org/show_bug.cgi?id=52739
546         Make it possible for a WebKit2 client to print headers and footers
547
548         Added dummy implementations for new printing UIClient calls.
549
550         * MiniBrowser/mac/BrowserWindowController.m:
551         (-[BrowserWindowController awakeFromNib]):
552         * WebKitTestRunner/TestController.cpp:
553         (WTR::createOtherPage):
554         (WTR::TestController::initialize):
555
556 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
557
558         Reviewed by Ojan Vafai.
559
560         Change webkitpy/layout_tests/port/test.py to use the
561         in-memory filesystem for cleaner unit testing. This
562         change allows us to kill a lot of code that was
563         specific to the test port, at the cost of being a
564         little less clear about how things would work if
565         you didn't have a filesystem.
566
567         https://bugs.webkit.org/show_bug.cgi?id=52605
568
569         * Scripts/webkitpy/layout_tests/port/test.py:
570
571 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
572
573         Unreviewed, build fix.
574
575         Fix test failure caused by committing attachment 79368 instead
576         of attachment 79461 on bug 52604.
577
578         * Scripts/webkitpy/common/system/filesystem_mock.py:
579
580 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
581
582         Reviewed by Mihai Parparita.
583
584         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
585         unit testing. os.walk() is too much of a hassle to implement on
586         top of the in-memory mock filesystem and adding the necessary
587         interface to files_under() gives clients a cleaner API anyway
588         (for this particular usage model).
589
590         https://bugs.webkit.org/show_bug.cgi?id=52691
591
592         * Scripts/webkitpy/common/system/filesystem.py:
593         * Scripts/webkitpy/common/system/filesystem_mock.py:
594         * Scripts/webkitpy/layout_tests/port/test_files.py:
595         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
596
597 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
598
599         Reviewed by Tony Chang.
600
601         Change more modules in the layout-tests code to use the
602         filesystem wrapper for cleaner unit testing.
603
604         This patch also adds the glob() wrapper to the filesystem
605         abstraction.
606         
607         https://bugs.webkit.org/show_bug.cgi?id=52604
608
609         * Scripts/webkitpy/layout_tests/port/test_files.py:
610         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
611         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
612         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
613         * Scripts/webkitpy/common/system/filesystem.py:
614         * Scripts/webkitpy/common/system/filesystem_mock.py:
615
616 2011-01-19  Levi Weintraub  <leviw@chromium.org>
617
618         Unreviewed.
619
620         Updating my email addresses and irc nick.
621
622         * Scripts/webkitpy/common/config/committers.py:
623
624 2011-01-19  Tony Chang  <tony@chromium.org>
625
626         Reviewed by Mihai Parparita.
627
628         [chromium] [linux] if check-sys-deps fails, output the failure reason
629         https://bugs.webkit.org/show_bug.cgi?id=52671
630
631         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
632             error handler functions.
633         * Scripts/webkitpy/layout_tests/port/chromium.py:
634             output the error text from --check-sys-deps
635         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
636
637 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
638
639         Reviewed by Andreas Kling.
640
641         [Qt] QtTestBrowser crashes when closing if Facebook is opened
642         https://bugs.webkit.org/show_bug.cgi?id=52554
643         
644         QtNetworkAccessManager is created in a thread and set as
645         member variable in QWebPage. When the thread is destroyed
646         the object is still used. So fix will set the object to
647         NULL once the thread is destroyed.
648
649         * QtTestBrowser/launcherwindow.cpp:
650         (LauncherWindow::~LauncherWindow):
651
652 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
653
654         Rubber stamped by Csaba Osztrogonac
655
656         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
657
658 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
659
660         Reviewed by Tony Chang.
661
662         new-run-webkit-tests: add a --build-directory command line argument
663
664         Official Google Chrome builds use a non-standard build directory
665         location. This patch adds a --build-directory argument that
666         allows that location to be specified on the command line. Only
667         Chromium-based builds will use this flag for now, but anyone can
668         in the future.
669
670         There are no unit tests for this since it's difficult to test
671         until mock filesystems are fully supported in the code. This was
672         tested by hand for now.
673
674         https://bugs.webkit.org/show_bug.cgi?id=52694
675
676         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
677         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
678         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
679         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
680
681 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
682
683         Not reviewed. Bot fix.
684
685         Remove an inadvertently committed debugging print.
686
687         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
688         (LayoutTestController::notifyDone):
689
690 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
691
692         Reviewed by Sam Weinig.
693
694         WebKitTestRunner should track loading more like DumpRenderTree
695         https://bugs.webkit.org/show_bug.cgi?id=52692
696
697         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
698         This makes some tests that call notifyDone multiple times pass.
699         
700         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
701         (WTR::InjectedBundle::InjectedBundle):
702         (WTR::InjectedBundle::done):
703         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
704         (WTR::InjectedBundle::topLoadingFrame):
705         (WTR::InjectedBundle::setTopLoadingFrame):
706         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
707         (WTR::InjectedBundlePage::InjectedBundlePage):
708         (WTR::InjectedBundlePage::stopLoading):
709         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
710         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
711         (WTR::InjectedBundlePage::didFinishLoadForFrame):
712         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
713         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
714         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
715         (WTR::LayoutTestController::notifyDone):
716         * WebKitTestRunner/TestController.cpp:
717         (WTR::TestController::didReceiveMessageFromInjectedBundle):
718
719 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
720
721         Reviewed by Kent Tamura.
722
723         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
724         https://bugs.webkit.org/show_bug.cgi?id=52678
725         
726         Update path now that WebKit is inside Source.
727
728         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
729
730 2011-01-18  Robert Hogan  <robert@webkit.org>
731
732         Reviewed by Simon Hausmann.
733
734         [Qt] http/tests/incremental/slow-utf8-text.pl fails
735         https://bugs.webkit.org/show_bug.cgi?id=44282
736
737         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
738         (WebCore::DumpRenderTree::dump):
739
740 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
741
742         Reviewed by Mihai Parparita.
743
744         Fix a small race condition that could cause the unit tests for
745         new-run-webkit-tests to fail in a multithreaded environment.
746         There was a small window in the code where one thread would
747         check to see if a thread had raised an exception, do something,
748         and then check to see if the thread was alive. If the other
749         thread raised an exception and exited in between these two
750         steps, the exception would be lost. Flipping the order of the
751         two checks fixes the race, since we will now always check for an
752         exception on the thread before exiting.
753
754         https://bugs.webkit.org/show_bug.cgi?id=51579
755
756         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
757
758 2011-01-18  Eric Seidel  <eric@webkit.org>
759
760         Reviewed by Adam Barth.
761
762         commit-queue dies when test archiving fails
763         https://bugs.webkit.org/show_bug.cgi?id=52617
764
765         I looked at the machine and it had 10 archives already
766         thus find_unused_name was returning None.  I've upped
767         the limit to 100 (per bug) and tested the case where
768         find_unused_name returns None (making archive return None).
769
770         * Scripts/webkitpy/common/system/workspace.py:
771         * Scripts/webkitpy/common/system/workspace_unittest.py:
772         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
773         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
774         * Scripts/webkitpy/tool/commands/queues.py:
775
776 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
777
778         Reviewed by Ojan Vafai.
779
780         Update rebaseline-chromium-webkit-tests unit tests to use a mock
781         filesystem. Also fix a couple of "with" statements missed by
782         r76050.
783
784         https://bugs.webkit.org/show_bug.cgi?id=52487
785
786         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
787
788 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
789
790         Reviewed by Martin Robinson.
791
792         [Gtk] Build fixes for gtk3 build
793         https://bugs.webkit.org/show_bug.cgi?id=52648
794
795         * DumpRenderTree/gtk/EventSender.cpp:
796         (beginDragWithFilesCallback):
797
798 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
799
800         Reviewed by Mihai Parparita.
801
802         Update rebaseline-chromium-webkit-tests to use filesystem objects
803         instead of direct references to os.path, shutil, tempfile, etc.
804
805         This patch doesn't change anything, but will allow subsequent
806         patches to change the unit tests to no longer use the real
807         filesystem.
808
809         This patch adds a bunch more methods to the filesystem object as
810         well.
811
812         https://bugs.webkit.org/show_bug.cgi?id=52482
813
814         * Scripts/webkitpy/common/system/filesystem.py:
815         * Scripts/webkitpy/common/system/filesystem_mock.py:
816         * Scripts/webkitpy/tool/commands/queues.py:
817         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
818         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
819
820 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
821
822         Reviewed by Mihai Parparita.
823
824         new-run-webkit-tests shouldn't crash when you try to run a
825         directory containing only skipped files.
826
827         https://bugs.webkit.org/show_bug.cgi?id=52478
828         
829         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
830         * Scripts/webkitpy/layout_tests/port/test.py:
831         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
832
833 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
834
835         Reviewed by Gustavo Noronha Silva.
836
837         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
838         https://bugs.webkit.org/show_bug.cgi?id=40833
839
840         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
841         GTK+ event sender.
842         (dragWithFilesDragDataGetCallback): Added.
843         (dragWithFilesDragEndCallback): Added.
844         (beginDragWithFilesCallback): Added.
845
846 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
847
848         Reviewed by Adam Barth.
849
850         ews: Add additional watcher to efl ews
851         https://bugs.webkit.org/show_bug.cgi?id=52613
852
853         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
854
855         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
856
857 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
858
859         Reviewed by Alexey Proskuryakov.
860
861         Fix some headers with missing or misspelled #ifndef guards
862         https://bugs.webkit.org/show_bug.cgi?id=52545
863
864         * DumpRenderTree/chromium/TestEventPrinter.h:
865         * DumpRenderTree/chromium/WebPreferences.h:
866
867 2011-01-17  Jessie Berlin  <jberlin@apple.com>
868
869         Reviewed by Anders Carlsson.
870
871         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
872         navigating back to an unreachable URL
873         https://bugs.webkit.org/show_bug.cgi?id=52388
874
875         Add a third parameter (unreachableURL) to queueLoadHTMLString.
876
877         * DumpRenderTree/LayoutTestController.cpp:
878         (queueLoadHTMLStringCallback):
879         (LayoutTestController::queueLoadHTMLString):
880         (LayoutTestController::queueLoadAlternateHTMLString):
881         * DumpRenderTree/LayoutTestController.h:
882
883         * DumpRenderTree/WorkQueueItem.h:
884         (LoadHTMLStringItem::LoadHTMLStringItem):
885
886         * DumpRenderTree/chromium/LayoutTestController.cpp:
887         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
888         (WorkItemLoadHTMLString::run):
889         (LayoutTestController::queueLoadHTMLString):
890
891         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
892         (LoadHTMLStringItem::invoke):
893         * DumpRenderTree/mac/WorkQueueItemMac.mm:
894         (LoadHTMLStringItem::invoke):
895         * DumpRenderTree/win/WorkQueueItemWin.cpp:
896         (LoadHTMLStringItem::invoke):
897
898 2011-01-17  Dan Bernstein  <mitz@apple.com>
899
900         Rubber-stamped by Mark Rowe.
901
902         Update xcodeproj svn:ignore to include xcuserdata.
903
904         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
905         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
906         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
907         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
908         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
909
910 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
911
912         Unreviewed fix after r75908.
913
914         Move WebKit into Source
915         https://bugs.webkit.org/show_bug.cgi?id=52530
916
917         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
918
919 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
920
921         Unreviewed.
922
923         Remove accidentally committed debug printing after r75908.
924
925         * Scripts/webkitdirs.pm:
926
927 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
928
929         Unreviewed.
930
931         Add myself to committers list
932         https://bugs.webkit.org/show_bug.cgi?id=52566
933
934         * Scripts/webkitpy/common/config/committers.py:
935
936 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
937
938         Reviewed by Jeremy Orlow.
939
940         GeolocationController should call stopUpdating on destruction
941         https://bugs.webkit.org/show_bug.cgi?id=52216
942
943         fast/dom/Geolocation/window-close-crash.html requires that a
944         Geolocation watch be started in a secondary window. Consequently,
945         we need to allow geolocation permission and provide a mock
946         geolocation position for the secondary window's
947         GeolocationClientMock.
948
949         * DumpRenderTree/chromium/LayoutTestController.cpp:
950         (LayoutTestController::setGeolocationPermission):
951         (LayoutTestController::setMockGeolocationPosition):
952         (LayoutTestController::setMockGeolocationError):
953         * DumpRenderTree/chromium/TestShell.h:
954         (TestShell::windowList):
955
956 2011-01-16  Adam Barth  <abarth@webkit.org>
957
958         Update more include paths to reflect WebKit move.
959
960         * DumpRenderTree/chromium/EventSender.cpp:
961         (EventSender::keyDown):
962         (EventSender::needsShiftModifier):
963         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
964         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
965
966 2011-01-16  Kent Tamura  <tkent@chromium.org>
967
968         Unreviewed, Chromium build fix.
969
970         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
971
972 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
973
974         Build fix for GTK+ after source directory movement.
975
976         * GNUmakefile.am: Correct include paths.
977
978 2011-01-16  Adam Barth  <abarth@webkit.org>
979
980         Teach svn-apply about WebKit move.
981
982         * Scripts/VCSUtils.pm:
983
984 2011-01-16  Adam Barth  <abarth@webkit.org>
985
986         Rubber-stamped by Eric Seidel.
987
988         Move WebKit into Source
989         https://bugs.webkit.org/show_bug.cgi?id=52530
990
991         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
992         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
993         * DumpRenderTree/qt/DumpRenderTreeQt.h:
994         * DumpRenderTree/qt/GCControllerQt.cpp:
995         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
996         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
997         * DumpRenderTree/qt/TextInputControllerQt.cpp:
998         * DumpRenderTree/wscript:
999         * QtTestBrowser/launcherwindow.h:
1000         * Scripts/build-webkit:
1001         * Scripts/webkitdirs.pm:
1002
1003 2011-01-15  Adam Barth  <abarth@webkit.org>
1004
1005         Teach svn-apply about WebKit2 move.
1006
1007         * Scripts/VCSUtils.pm:
1008
1009 2011-01-15  Adam Barth  <abarth@webkit.org>
1010
1011         Rubber-stamped by Eric Seidel.
1012
1013         Move WebKit2 into Source
1014         https://bugs.webkit.org/show_bug.cgi?id=52438
1015
1016         * MiniBrowser/qt/MiniBrowser.pro:
1017         * Scripts/build-webkit:
1018         * Scripts/do-file-rename:
1019         * Scripts/do-webcore-rename:
1020         * Scripts/test-webkitpy:
1021         * Scripts/webkitdirs.pm:
1022         * Scripts/webkitpy/style/checker.py:
1023         * WebKitTestRunner/DerivedSources.pro:
1024         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1025         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1026
1027 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
1028
1029         Reviewed by David Levin.
1030
1031         [chromium] remove obsolete createView method
1032         https://bugs.webkit.org/show_bug.cgi?id=52437
1033
1034         * DumpRenderTree/chromium/WebViewHost.cpp:
1035         (WebViewHost::createView):
1036         * DumpRenderTree/chromium/WebViewHost.h:
1037
1038 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
1039
1040         Reviewed by Geoff Garen.
1041
1042         ShouldLoadResourceForFrame should use strings, not URLs.
1043         https://bugs.webkit.org/show_bug.cgi?id=52476
1044
1045         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1046         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
1047         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1048
1049 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
1050
1051         Reviewed by David Levin.
1052
1053         Add Tony Gentilcore as a reviewer
1054         https://bugs.webkit.org/show_bug.cgi?id=52480
1055
1056         * Scripts/webkitpy/common/config/committers.py:
1057
1058 2011-01-14  David Levin  <levin@chromium.org>
1059
1060         Reviewed by Eric Seidel.
1061
1062         check-webkit-style: _FunctionState should keep track of where the function name starts.
1063         https://bugs.webkit.org/show_bug.cgi?id=52454
1064
1065         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
1066         _FunctionState and logic for setting it correctly.
1067         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
1068
1069 2011-01-14  Vincent Scheib  <scheib@chromium.org>
1070
1071         Reviewed by David Levin.
1072
1073         Add support to DumpRenderTree to use the GPU rather than software renderer
1074         https://bugs.webkit.org/show_bug.cgi?id=52333
1075
1076         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1077         (main):
1078         * Scripts/webkitpy/layout_tests/port/chromium.py:
1079         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1080
1081 2011-01-14  Tony Chang  <tony@chromium.org>
1082
1083         Reviewed by Kent Tamura.
1084
1085         [chromium] update fonts.conf to fix 6 linux tests in drt
1086         https://bugs.webkit.org/show_bug.cgi?id=52411
1087
1088         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
1089             chromium's src/webkit/tools/test_shell/resources/fonts.conf
1090
1091 2011-01-14  Eric Seidel  <eric@webkit.org>
1092
1093         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
1094
1095         Reviewed by Adam Barth.
1096
1097         Fix when running Tools/Scripts/check-webkit-style without arguments.
1098         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
1099
1100         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
1101         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1102
1103 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
1104
1105         Reviewed by David Levin.
1106
1107         Store the tempdir object in a variable so it doesn't get deleted too early.
1108         https://bugs.webkit.org/show_bug.cgi?id=51875
1109
1110         * Scripts/update-webkit-auxiliary-libs:
1111         * Scripts/update-webkit-support-libs:
1112
1113 2011-01-14  Eric Seidel  <eric@webkit.org>
1114
1115         Unreviewed.  Make it work in python 2.5.
1116
1117         webkit-patch suggest-reviewers dies when ChangeLogs are missing
1118         https://bugs.webkit.org/show_bug.cgi?id=49158
1119
1120         * Scripts/webkitpy/common/checkout/api_unittest.py:
1121
1122 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1123
1124         Unreviewed, rolling out r75774.
1125         http://trac.webkit.org/changeset/75774
1126         https://bugs.webkit.org/show_bug.cgi?id=52431
1127
1128         gtk builds were broken (Requested by loislo2 on #webkit).
1129
1130         * Scripts/webkitpy/common/checkout/scm.py:
1131
1132 2011-01-14  David Levin  <levin@chromium.org>
1133
1134         Reviewed by Shinichiro Hamaji.
1135
1136         check-webkit-style: _FunctionState should detect pure functions.
1137         https://bugs.webkit.org/show_bug.cgi?id=52428
1138
1139         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
1140         is a pure virtual function.
1141         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
1142         virtual functions are correctly detected.
1143
1144 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
1145
1146         Reviewed by Yury Semikhatsky.
1147
1148         Just small fix for problem with check-webkit-style.
1149         It just didn't work for this patch.
1150         Old code can't concatenate a list of strings with None.
1151
1152         * Scripts/webkitpy/common/checkout/scm.py:
1153
1154 2011-01-13  David Levin  <levin@chromium.org>
1155
1156         Reviewed by Shinichiro Hamaji.
1157
1158         check-webkit-style: _FunctionState should use Position to know where items are.
1159         https://bugs.webkit.org/show_bug.cgi?id=52424
1160
1161         * Scripts/webkitpy/style/checkers/cpp.py:
1162         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
1163         (detect_functions): Changed to pass Position's to _FunctionState.begin and
1164         did some minor clean-up.
1165         (*): Other changes are simply about converting to use the Position's in_FunctionState
1166         instead of line numbers.
1167         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
1168         to verify the positions stored in _FunctionState.
1169
1170 2011-01-13  Eric Seidel  <eric@webkit.org>
1171
1172         Reviewed by David Levin.
1173
1174         webkit-patch suggest-reviewers dies when ChangeLogs are missing
1175         https://bugs.webkit.org/show_bug.cgi?id=49158
1176
1177         This is not the most elegant, but it is a very safe fix to this bug.
1178         One advantage of catching ScriptError like this instead of adding a
1179         new added_or_modified_files or fixing all changed_files callers
1180         to use a more specific change_files variant, is that we catch
1181         all kinds of ScriptErrors which might cause our (non-essential)
1182         suggest-reviewers code to fail out.  This should make passing
1183         --suggest-reviewers to webkit-patch upload much more robust
1184         and may even make it possible for us to make it default.
1185
1186         The root of the problem here is that SCM.changed_files includes
1187         deleted ChangeLog paths (from moves, etc) which then when we ask
1188         SVN/Git for the contents of the file at that revision, the command
1189         errors out and Executive.run_command raises a ScriptError.
1190
1191         In the future we might fix this differently by making all current
1192         callers of chagned_files use a more specific method for requesting
1193         what types of changes they're interested in (adds, modifies, deletes, etc.)
1194
1195         * Scripts/webkitpy/common/checkout/api.py:
1196         * Scripts/webkitpy/common/checkout/api_unittest.py:
1197
1198 2011-01-13  Dan Bernstein  <mitz@apple.com>
1199
1200         Reviewed by Alexey Proskuryakov.
1201
1202         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
1203         https://bugs.webkit.org/show_bug.cgi?id=52419
1204
1205         Allow to further control the behavior of the willSendRequest delegate callback by making it
1206         set a different URL in the new request.
1207
1208         * DumpRenderTree/LayoutTestController.cpp:
1209         (addURLToRedirectCallback): Added.
1210         (LayoutTestController::staticFunctions): Added addURLToRedirect.
1211         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
1212         (LayoutTestController::redirectionDestinationForURL): Added this getter.
1213         * DumpRenderTree/LayoutTestController.h:
1214         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1215         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
1216         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
1217         change the URL in the new request to the redirect destination.
1218
1219 2011-01-13  Eric Seidel  <eric@webkit.org>
1220
1221         Reviewed by Mihai Parparita.
1222
1223         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
1224         https://bugs.webkit.org/show_bug.cgi?id=52416
1225
1226         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
1227         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
1228
1229         I also added FIXMEs about the changed_files returning deleted files problem
1230         which is causing the other most common exception for suggest-reviewers
1231         (and is probably breaking sheriff-bots blame detection).
1232
1233         * Scripts/webkitpy/common/checkout/api.py:
1234         * Scripts/webkitpy/common/checkout/api_unittest.py:
1235         * Scripts/webkitpy/common/checkout/scm.py:
1236
1237 2011-01-13  Eric Seidel  <eric@webkit.org>
1238
1239         Reviewed by Adam Barth.
1240
1241         results archives from commit-queue are too large to upload
1242         https://bugs.webkit.org/show_bug.cgi?id=52405
1243
1244         * Scripts/webkitpy/common/system/filesystem.py:
1245         * Scripts/webkitpy/common/system/filesystem_mock.py:
1246         * Scripts/webkitpy/tool/commands/queues.py:
1247
1248 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
1249
1250         Reviewed by Martin Robinson.
1251
1252         [gtk] Zero-sized font does not yet work
1253         https://bugs.webkit.org/show_bug.cgi?id=49793
1254
1255         Set minimum-font-size to 0 for the DRT.
1256
1257         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1258         (resetDefaultsToConsistentValues):
1259
1260 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
1261
1262         Reviewed by Darin Adler.
1263
1264         Make old-run-webkit-tests more robust on buildbots
1265         https://bugs.webkit.org/show_bug.cgi?id=52364
1266
1267         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
1268
1269 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
1270
1271         Reviewed by Darin Adler.
1272
1273         Make old-run-webkit-tests more robust on buildbots
1274         https://bugs.webkit.org/show_bug.cgi?id=52364
1275
1276         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
1277
1278 2011-01-13  Tony Chang  <tony@chromium.org>
1279
1280         Reviewed by Kent Tamura.
1281
1282         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
1283         https://bugs.webkit.org/show_bug.cgi?id=52332
1284
1285         Forked Info.plist is not longer needed.
1286
1287         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
1288
1289 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
1290
1291         Reviewed by Timothy Hatcher.
1292
1293         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
1294         to be passed directly to WebInspector.UIString
1295
1296         https://bugs.webkit.org/show_bug.cgi?id=52365
1297
1298         * Scripts/check-inspector-strings:
1299
1300 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
1301
1302         Unreviewed, rolling out r74881.
1303         http://trac.webkit.org/changeset/74881
1304         https://bugs.webkit.org/show_bug.cgi?id=52357
1305
1306         The EFL builder has been red for days (Requested by abarth on
1307         #webkit).
1308
1309         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1310         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1311
1312 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1313
1314         Reviewed by David Levin.
1315
1316         Add beforeunload support to WebKitTestRunner
1317         https://bugs.webkit.org/show_bug.cgi?id=52353
1318         
1319         This makes a number of currently failing tests pass.
1320
1321         * WebKitTestRunner/TestController.cpp:
1322         (WTR::runBeforeUnloadConfirmPanel):
1323         (WTR::createOtherPage):
1324         (WTR::TestController::initialize):
1325
1326 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1327
1328         Reviewed by Sam Weinig.
1329
1330         Detect, identify and recover from WebProcess crashes in run-webkit-tests
1331         https://bugs.webkit.org/show_bug.cgi?id=52330
1332
1333         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
1334         a web process crash.
1335         * WebKitTestRunner/TestController.cpp:
1336         (WTR::TestController::initialize): Set up a processDidCrash
1337         callback.
1338         (WTR::TestController::processDidCrash): Report that the Web process
1339         crashed.
1340         * WebKitTestRunner/TestController.h:
1341
1342 2011-01-12  David Levin  <levin@chromium.org>
1343
1344         Reviewed by Shinichiro Hamaji.
1345
1346         check-webkit-style -- close_expression function doesn't work correctly.
1347         https://bugs.webkit.org/show_bug.cgi?id=52272
1348
1349         * Scripts/webkitpy/style/checkers/cpp.py:
1350         (Position.__str__): Added a way to convert it to a string which is useful in tests.
1351         (Position.__cmp__): Added a way to compare Position which is useful in tests and
1352         generally useful (for upcoming code changes).
1353         (close_expression): Changed to use Position for input and output.
1354         Also, fixed many bugs such as only working correctly for parenthesis,
1355         not working correctly if given an offset in a line and not finding
1356         the real closing element if there were multiple closing elements in
1357         the same line.
1358         (detect_functions): Adjusted due to the change in arguments for
1359         close_expression.
1360         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1361         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
1362         two positions are the same.
1363         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
1364         (CppStyleTest.test_close_expression): Added tests to catch the issues
1365         that were fixed.
1366
1367 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
1368
1369         Unreviewed, rolling out r75576.
1370         http://trac.webkit.org/changeset/75576
1371         https://bugs.webkit.org/show_bug.cgi?id=52304
1372
1373         broke rebaseline-chromium-webkit-test (Requested by thakis on
1374         #webkit).
1375
1376         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1377         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1378         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1379         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1380         * Scripts/webkitpy/layout_tests/port/base.py:
1381         * Scripts/webkitpy/layout_tests/port/chromium.py:
1382         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1383         * Scripts/webkitpy/layout_tests/port/test.py:
1384         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1385         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1386         * Scripts/webkitpy/style/checkers/test_expectations.py:
1387         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1388
1389 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1390
1391         Reviewed by Darin Adler.
1392
1393         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
1394         https://bugs.webkit.org/show_bug.cgi?id=52307
1395
1396         * Scripts/old-run-webkit-tests:
1397
1398 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
1399
1400         Reviewed by Martin Robinson.
1401
1402         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
1403         https://bugs.webkit.org/show_bug.cgi?id=50867
1404
1405         Fixed library extention for Mac in webkitdirs.pm and type conflict in
1406         TestNetscapePlugin.cpp 
1407
1408         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
1409         * Scripts/webkitdirs.pm:
1410
1411 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
1412
1413         Reviewed by Pavel Feldman.
1414
1415         Add check-inspector-strings script.
1416
1417         https://bugs.webkit.org/show_bug.cgi?id=52295
1418
1419         * Scripts/check-inspector-strings: Added.
1420
1421 2011-01-12  Adam Roben  <aroben@apple.com>
1422
1423         Advertise the .testnetscape file extension on Windows
1424
1425         Fixes <http://webkit.org/b/52298>
1426         plugins/no-mime-with-valid-extension.html fails on Windows
1427
1428         Reviewed by Dan Bernstein.
1429
1430         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
1431         FileExtents field to map the .testnetscape file extension to the
1432         application/x-webkit-test-netscape MIME type, just as we do on Mac.
1433
1434 2011-01-12  Adam Barth  <abarth@webkit.org>
1435
1436         Reviewed by Eric Seidel.
1437
1438         Make webkit-patch support subdirectories for SVN checkouts
1439         https://bugs.webkit.org/show_bug.cgi?id=52261
1440
1441         os.relpath does not exist on Python 2.5, so we need to call our version
1442         of the API.
1443
1444         * Scripts/webkitpy/common/checkout/scm.py:
1445
1446 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
1447
1448         Reviewed by Eric Seidel.
1449
1450         Close additional pages opened during a test once the test completes.
1451         https://bugs.webkit.org/show_bug.cgi?id=52276
1452
1453         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1454         (WTR::InjectedBundle::done):
1455
1456 2011-01-11  David Levin  <levin@chromium.org>
1457
1458         Reviewed by Eric Seidel.
1459
1460         Errors should be separated from the command line in bot messages.
1461         https://bugs.webkit.org/show_bug.cgi?id=52275
1462
1463         * Scripts/webkitpy/common/system/executive.py:
1464         (ScriptError.message_with_output): Added a newline to separate the command
1465         line from the errors.
1466         * Scripts/webkitpy/common/system/executive_unittest.py:
1467         (ScriptErrorTest.test_message_with_output): Added tests for the various code
1468         paths in message_with_output.
1469
1470 2011-01-11  Eric Seidel  <eric@webkit.org>
1471
1472         Unreviewed.
1473
1474         commit-queue should know how to upload archived results (for test flakes or general failures)
1475         https://bugs.webkit.org/show_bug.cgi?id=52048
1476
1477         The zips are mostly empty due to forgetting -r.
1478         Expected diffs were not being pulled from the archive due
1479         to the archive having longer paths than I realized.
1480
1481         * Scripts/webkitpy/common/system/workspace.py:
1482         * Scripts/webkitpy/common/system/workspace_unittest.py:
1483         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1484         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1485
1486 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
1487
1488         Reviewed by Ojan Vafai.
1489
1490         The current modifier parsing code in test_expectations is
1491         fragile and hard-coded, so it's not easy to understand the logic
1492         or easily add new types of modifiers (like GPU vs. CPU testing
1493         for graphics tests, or 32-bit vs. 64-bit differences).
1494
1495         This is the first of two patches that will add in more generic
1496         support and then eliminate the GPU-specific test expectations
1497         files for Chromium.
1498
1499         This patch adds two standalone objects for handling modifiers. The
1500         rules for interpreting modifiers, precedence, and conflicts are
1501         given in the docstring to the ModifierMatcher class, which
1502         returns ModifierMatchResult objects.
1503         
1504         This patch also adds routines to the Port interface and a
1505         default set of values in the base object, in order to obtain the
1506         values needed on a given test run. These values are then passed
1507         to the expectation parser. This also allows us to clean up the
1508         logic used to lint all of the different configurations in a
1509         single test_expectations.txt file.
1510
1511         The next patch will merge in the separate GPU expectations file.
1512
1513         https://bugs.webkit.org/show_bug.cgi?id=51222
1514
1515         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1516         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1517         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1518         * Scripts/webkitpy/layout_tests/port/base.py:
1519         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1520         * Scripts/webkitpy/layout_tests/port/chromium.py:
1521         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1522         * Scripts/webkitpy/layout_tests/port/test.py:
1523         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1524         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1525
1526 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
1527
1528         Reviewed by Adam Barth.
1529
1530         Make webkit-patch support subdirectories for SVN checkouts
1531         https://bugs.webkit.org/show_bug.cgi?id=52261
1532
1533         * Scripts/webkitpy/common/checkout/scm.py:
1534         * Scripts/webkitpy/style_references.py:
1535         * Scripts/webkitpy/tool/main.py:
1536         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1537
1538 2011-01-11  Eric Seidel  <eric@webkit.org>
1539
1540         Unreviewed.
1541
1542         commit-queue should know how to upload archived results (for test flakes or general failures)
1543         https://bugs.webkit.org/show_bug.cgi?id=52048
1544
1545         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
1546         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
1547
1548         * Scripts/webkitpy/common/system/workspace.py:
1549         * Scripts/webkitpy/common/system/workspace_unittest.py:
1550         * Scripts/webkitpy/tool/commands/queues.py:
1551
1552 2011-01-11  Sam Weinig  <sam@webkit.org>
1553
1554         Roll r75474 back in.
1555
1556 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1557
1558         Reviewed by Kenneth Rohde Christiansen.
1559
1560         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
1561         https://bugs.webkit.org/show_bug.cgi?id=51204
1562
1563         * QtTestBrowser/webpage.h:
1564         (QtNAMThread::QtNAMThread):
1565         (QtNAMThread::networkAccessManager):
1566         (QtNAMThread::run):
1567
1568 2011-01-11  Peter Varga  <pvarga@webkit.org>
1569
1570         Unreviewed.
1571
1572         Add myself to committers' list.
1573
1574         * Scripts/webkitpy/common/config/committers.py:
1575
1576 2011-01-11  Eric Seidel  <eric@webkit.org>
1577
1578         Reviewed by Adam Barth.
1579
1580         commit-queue should know how to upload archived results (for test flakes or general failures)
1581         https://bugs.webkit.org/show_bug.cgi?id=52048
1582
1583         Now the queue will always upload results.  Either the entire zip, or just
1584         the diffs.txt in the case of text failures.
1585
1586         This should make understanding flakes much easier, and paves the way
1587         for having the EWS run layout tests (and upload failures).
1588
1589         In order to upload .zip files I had to teach bugzilla.py to autodetect
1590         mime types from the filename.  Since mimetypes.py doesn't include a mapping
1591         for .patch files, I have it add one before calling guess_type.
1592
1593         We may find that always uploading the whole zip instead of just the -diffs.txt
1594         file is preferable, but for now I'm keeping the old behavior because it makes
1595         quickly understanding text failures easy.
1596
1597         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1598         * Scripts/webkitpy/common/system/workspace.py: Added.
1599         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
1600         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1601         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1602         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1603         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1604         * Scripts/webkitpy/tool/commands/queues.py:
1605         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1606
1607 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
1608
1609         Unreviewed, rolling out r75464.
1610         http://trac.webkit.org/changeset/75464
1611         https://bugs.webkit.org/show_bug.cgi?id=52193
1612
1613         Followup rollout for 75474 (Requested by Ossy on #webkit).
1614
1615         * MiniBrowser/mac/BrowserWindowController.m:
1616         (-[BrowserWindowController awakeFromNib]):
1617         * MiniBrowser/win/BrowserView.cpp:
1618         (BrowserView::create):
1619         * WebKitTestRunner/TestController.cpp:
1620         (WTR::createOtherPage):
1621         (WTR::TestController::initialize):
1622
1623 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1624
1625         Reviewed by Csaba Osztrogonác.
1626
1627         [Qt] Baseline qt_minimal configuration
1628         https://bugs.webkit.org/show_bug.cgi?id=51313
1629
1630         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1631         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
1632         QT_NO_UNDOSTACK guard.
1633
1634         * QtTestBrowser/launcherwindow.cpp:
1635         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
1636         guards.
1637         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
1638         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
1639         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
1640         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
1641
1642         * QtTestBrowser/launcherwindow.h:
1643         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
1644         * QtTestBrowser/locationedit.h: Ditto.
1645
1646         * QtTestBrowser/mainwindow.cpp:
1647         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
1648         QT_NO_UNDOSTACK guards.
1649         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
1650         (MainWindow::changeLocation): Ditto.
1651         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
1652         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
1653
1654         * QtTestBrowser/webpage.cpp:
1655         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
1656         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
1657
1658         * QtTestBrowser/webview.cpp:
1659         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
1660         (WebViewGraphicsBased::animatedYFlip): Ditto.
1661
1662 2011-01-10  Sam Weinig  <sam@webkit.org>
1663
1664         Fix build.
1665
1666         * MiniBrowser/mac/BrowserWindowController.m:
1667         (-[BrowserWindowController awakeFromNib]):
1668         * MiniBrowser/win/BrowserView.cpp:
1669         (BrowserView::create):
1670         * WebKitTestRunner/TestController.cpp:
1671         (WTR::createOtherPage):
1672         (WTR::TestController::initialize):
1673
1674 2011-01-10  Eric Seidel  <eric@webkit.org>
1675
1676         Reviewed by Ojan Vafai.
1677
1678         style-queue messages are way too long for big patches
1679         https://bugs.webkit.org/show_bug.cgi?id=52161
1680
1681         We definitely could build much fancier list-to-string-with-limit functions
1682         but this should be sufficient for our needs at the moment.
1683
1684         * Scripts/webkitpy/common/system/executive.py:
1685         * Scripts/webkitpy/common/system/executive_unittest.py:
1686
1687 2011-01-10  Tony Chang  <tony@chromium.org>
1688
1689         Unreviewed, rolling out r75398.
1690         http://trac.webkit.org/changeset/75398
1691         https://bugs.webkit.org/show_bug.cgi?id=52008
1692
1693         Some layout tests are crashing on Chromium Win.
1694
1695         * DumpRenderTree/chromium/WebViewHost.cpp:
1696         (WebViewHost::updatePaintRect):
1697         * DumpRenderTree/chromium/WebViewHost.h:
1698
1699 2011-01-10  Adam Roben  <aroben@apple.com>
1700
1701         Roll out r75392
1702
1703         It isn't needed now that r75289 has been rolled out.
1704
1705         * Scripts/run-javascriptcore-tests:
1706
1707 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
1708
1709         Reviewed by Anders Carlsson.
1710
1711         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
1712         https://bugs.webkit.org/show_bug.cgi?id=52160
1713
1714         * WebKitTestRunner/mac/TestControllerMac.mm:
1715         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
1716         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
1717         anyway.
1718
1719 2011-01-10  Tony Chang  <tony@chromium.org>
1720
1721         Reviewed by Mihai Parparita.
1722
1723         [chromium] fix for animated gif layout tests
1724         https://bugs.webkit.org/show_bug.cgi?id=52008
1725
1726         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
1727             to trigger gif animations.
1728         (WebViewHostPaintTask::WebViewHostPaintTask):
1729         (WebViewHostPaintTask::runIfValid):
1730         (WebViewHost::updatePaintRect):
1731         * DumpRenderTree/chromium/WebViewHost.h:
1732         (WebViewHost::taskList):
1733
1734 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
1735
1736         Reviewed by Xan Lopez.
1737
1738         [GTK] Fix gtk2 compilation for master
1739         https://bugs.webkit.org/show_bug.cgi?id=51885
1740
1741         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1742         (createBitmapContextFromWebView): Replaced the old
1743         gdk_drawable_get_size with gdk_pixmap_get_size.
1744
1745 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
1746
1747         Reviewed by Laszlo Gombos.
1748
1749         [WINCE] Reenable NPAPI after r75203
1750         https://bugs.webkit.org/show_bug.cgi?id=52109
1751
1752         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
1753         it with !isEfl(), because EFL port does not support NPAPI (yet).
1754
1755         * Scripts/build-webkit:
1756
1757 2011-01-10  Adam Roben  <aroben@apple.com>
1758
1759         Skip some asserting JS tests
1760
1761         See <http://webkit.org/b/52156>.
1762
1763         * Scripts/run-javascriptcore-tests:
1764
1765 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
1766
1767         Reviewed by Xan Lopez.
1768
1769         [GTK] build-webkit disable Blob support via arguments passed to automake
1770         https://bugs.webkit.org/show_bug.cgi?id=52097
1771
1772         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
1773         build-webkit.
1774
1775 2011-01-10  Adam Roben  <aroben@apple.com>
1776
1777         Use the same name and description for TestNetscapePlugin on Windows and
1778         Mac
1779
1780         Fixes <http://webkit.org/b/52151>
1781         fast/frames/iframe-reparenting-plugins.html fails on Windows
1782
1783         Reviewed by Steve Falkenburg.
1784
1785         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
1786         the name and description from Mac's Info.plist.
1787
1788 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
1789
1790         Reviewed by Laszlo Gombos.
1791
1792         [Qt][WK2] Guard gcc-specific syntax
1793
1794         Non-gcc based compliers choke on the "-include"
1795         syntax for preinclude, place guard around it.
1796
1797         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1798         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1799
1800 2011-01-10  Andreas Kling  <kling@webkit.org>
1801
1802         Reviewed by Simon Hausmann.
1803
1804         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
1805         https://bugs.webkit.org/show_bug.cgi?id=52111
1806
1807         When getting a createNewPage() callback from QWKPage, create the
1808         new page with the same QWKContext as the page that is passed to
1809         the callback.
1810
1811         * MiniBrowser/qt/BrowserView.h:
1812         * MiniBrowser/qt/BrowserWindow.cpp:
1813         (newPageFunction):
1814         (BrowserWindow::BrowserWindow):
1815         * MiniBrowser/qt/BrowserWindow.h:
1816
1817 2011-01-10  Andreas Kling  <kling@webkit.org>
1818
1819         Reviewed by Kenneth Rohde Christiansen.
1820
1821         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
1822
1823         BrowserView set its own useless createNewPage() callback on QWKPage.
1824         This was immediately overridden by BrowserWindow anyway, so remove
1825         the BrowserView one.
1826
1827         * MiniBrowser/qt/BrowserView.cpp:
1828         (BrowserView::BrowserView):
1829
1830 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
1831
1832         Reviewed by Jeremy Orlow.
1833
1834         [Chromium] Remove non-client-based Geolocation code
1835         https://bugs.webkit.org/show_bug.cgi?id=50921
1836
1837         * DumpRenderTree/chromium/LayoutTestController.cpp:
1838         (LayoutTestController::setGeolocationPermission):
1839         (LayoutTestController::setMockGeolocationPosition):
1840         (LayoutTestController::setMockGeolocationError):
1841         * DumpRenderTree/chromium/WebViewHost.cpp:
1842         (WebViewHost::geolocationClientMock):
1843         (WebViewHost::reset):
1844         * DumpRenderTree/chromium/WebViewHost.h:
1845
1846 2011-01-10  Eric Seidel  <eric@webkit.org>
1847
1848         Reviewed by Adam Barth.
1849
1850         Commit bot tried to land r? cq+ patch
1851         https://bugs.webkit.org/show_bug.cgi?id=36638
1852
1853         It should now be possible to post a patch with r? and cq+ and the
1854         commit-queue will correctly wait for the r+ before attempting to land the patch.
1855         (This was a feature requested by several users.)
1856
1857         One caveat: We don't actually reject r-, cq+ patches from the queue
1858         (we just ignore them), but I think that's OK for now.
1859
1860         I also noticed that setting r- once a commit-queue node had grabbed
1861         a patch would not properly cancel the landing.  That's fixed and
1862         tested in this patch.
1863
1864         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1865         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1866         * Scripts/webkitpy/tool/bot/feeders.py:
1867         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1868
1869 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
1870
1871         Reviewed by Kenneth Rohde Christiansen.
1872
1873         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
1874         https://bugs.webkit.org/show_bug.cgi?id=51934
1875
1876         When accessing the network from the destructor of QWebPage, the network access manager
1877         was already deleted because the object WebPage was already destructed.
1878
1879         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
1880         The object is now destructed in the destructor of QObject.
1881
1882         * QtTestBrowser/webpage.cpp:
1883         (WebPage::WebPage):
1884         (WebPage::setQnamThreaded):
1885         * QtTestBrowser/webpage.h:
1886         (QtNAMThread::QtNAMThread):
1887
1888 2011-01-08  Eric Seidel  <eric@webkit.org>
1889
1890         Reviewed by Ojan Vafai.
1891
1892         test_failures.py should not mention TestShell (long live DumpRenderTree!)
1893         https://bugs.webkit.org/show_bug.cgi?id=52067
1894
1895         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
1896         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
1897
1898         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1899
1900 2011-01-08  Eric Seidel  <eric@webkit.org>
1901
1902         Reviewed by Mihai Parparita.
1903
1904         commit-queue hangs when the ChangeLog diff is bad
1905         https://bugs.webkit.org/show_bug.cgi?id=52072
1906
1907         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
1908         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
1909
1910 2011-01-08  Adam Barth  <abarth@webkit.org>
1911
1912         Teach svn-apply how to re-write WebCore to Source/WebCore.
1913
1914         * Scripts/VCSUtils.pm:
1915
1916 2011-01-07  Adam Barth  <abarth@webkit.org>
1917
1918         Rubber-stamped by Eric Seidel.
1919
1920         Move WebCore to Source
1921         https://bugs.webkit.org/show_bug.cgi?id=52050
1922
1923         Update the tools to understand WebCore's new location.
1924
1925         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1926         * DumpRenderTree/wscript:
1927         * GNUmakefile.am:
1928         * Scripts/build-webkit:
1929         * Scripts/do-file-rename:
1930         * Scripts/do-webcore-rename:
1931         * Scripts/generate-qt-inspector-resource:
1932         * Scripts/prepare-ChangeLog:
1933         * Scripts/run-bindings-tests:
1934         * Scripts/update-iexploder-cssproperties:
1935         * Scripts/update-sources-list.py:
1936         * Scripts/update-webkit-localizable-strings:
1937         * Scripts/webkitdirs.pm:
1938         * Scripts/webkitpy/common/config/build.py:
1939         * Scripts/webkitpy/common/config/build_unittest.py:
1940         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1941         * Scripts/webkitpy/style/checker.py:
1942         * Scripts/webkitpy/style/checker_unittest.py:
1943         * WebKitTestRunner/DerivedSources.pro:
1944         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1945         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
1946         * wx/browser/wscript:
1947         * wx/build/settings.py:
1948
1949 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
1950
1951         Reviewed by Sam Weinig.
1952
1953         Make WebKitTestRunner rest between loads more robust to avoid test crashes
1954         https://bugs.webkit.org/show_bug.cgi?id=52086
1955
1956         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1957         (WTR::InjectedBundle::didReceiveMessage):
1958         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1959         (WTR::LayoutTestController::notifyDone):
1960         * WebKitTestRunner/TestController.cpp:
1961         (WTR::TestController::resetStateToConsistentValues):
1962         (WTR::TestController::run):
1963
1964 2011-01-07  James Robinson  <jamesr@chromium.org>
1965
1966         Revert "Implement mozilla's animationTime property"
1967         https://bugs.webkit.org/show_bug.cgi?id=51952
1968
1969         This approach isn't quite right.
1970
1971         * DumpRenderTree/chromium/WebViewHost.cpp:
1972         (WebViewHost::paintInvalidatedRegion):
1973
1974 2011-01-07  Adam Roben  <aroben@apple.com>
1975
1976         Build master fix
1977
1978         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1979         (RunWebKitTests.start): Don't try to concatenate a list and a string.
1980
1981 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
1982
1983         Reviewed by Csaba Osztrogonác.
1984
1985         run-qtwebkit-tests should be able to kill a testsuite.
1986
1987         Add new option in the script that can setup a timeout for a test.
1988         If the test execution takes more then specified time then the test
1989         would be terminated.
1990
1991         [Qt] run-qtwebkit-tests needs timeout
1992         https://bugs.webkit.org/show_bug.cgi?id=51894
1993
1994         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1995         * Scripts/run-qtwebkit-tests:
1996
1997 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
1998
1999         Unreviewed fix after r75233.
2000
2001         Based on idea from Eric Seidel.
2002
2003         Add remote zip file handling to webkitpy.
2004         https://bugs.webkit.org/show_bug.cgi?id=50901
2005
2006         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
2007
2008 2011-01-07  Shane Stephens  <shanestephens@google.com>
2009
2010         Reviewed by Eric Seidel.
2011
2012         svn-apply: should support git binary delta diffs
2013         https://bugs.webkit.org/show_bug.cgi?id=38864
2014
2015         * Scripts/VCSUtils.pm:
2016         * Scripts/svn-apply:
2017
2018 2011-01-06  Julie Parent  <jparent@chromium.org>
2019
2020         Reviewed by Eric Seidel.
2021
2022         Test Result Server not removing old results.
2023         https://bugs.webkit.org/show_bug.cgi?id=52012
2024
2025         * TestResultServer/model/jsonresults.py:
2026         Fix off-by-one: Truncate if >= num_runs, not just >.
2027         * TestResultServer/model/jsonresults_unittest.py:
2028         Add unit test to test that merging in a new result with the same value
2029         as the last result causes previous result to fall off.
2030
2031 2011-01-06  James Kozianski  <koz@chromium.org>
2032
2033         Reviewed by Mihai Parparita.
2034
2035         Add classes to provide a consistent interface to a set of files.
2036         https://bugs.webkit.org/show_bug.cgi?id=50901
2037
2038         These classes allow us to write code that is agnostic to whether a
2039         particular set of files resides in a local directory or in a zip file
2040         on a remote machine.
2041
2042         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
2043         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
2044         * Scripts/webkitpy/common/system/fileset.py: Added.
2045         * Scripts/webkitpy/common/system/filesystem.py:
2046         * Scripts/webkitpy/common/system/filesystem_mock.py:
2047         * Scripts/webkitpy/common/system/zipfileset.py: Added.
2048         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
2049
2050 2011-01-06  Eric Seidel  <eric@webkit.org>
2051
2052         Reviewed by Adam Barth.
2053
2054         NetworkTransaction should log the url it is retrying
2055         https://bugs.webkit.org/show_bug.cgi?id=52043
2056
2057         * Scripts/webkitpy/common/net/networktransaction.py:
2058         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
2059
2060 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
2061
2062         Windows build fix.
2063         Import os before using it.
2064
2065         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2066
2067 2011-01-06  Eric Seidel  <eric@webkit.org>
2068
2069         Reviewed by Adam Barth.
2070
2071         StyleQueue fails to report errors when patches have many files
2072         https://bugs.webkit.org/show_bug.cgi?id=52042
2073
2074         This is one of at least two errors preventing style error reporting at the moment.
2075         When we moved to passing the list of files to check explicitly,
2076         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
2077         We could change the type of the QueueStatus.message type, or we could
2078         just teach statusserver.py how to clamp values (and warn when it does).
2079         I chose the latter path.
2080
2081         * Scripts/webkitpy/common/net/statusserver.py:
2082
2083 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
2084
2085         Reviewed by Stephanie Lewis.
2086         
2087         Fix syntax error in script.
2088
2089         Windows bots need to archive/unarchive builds to/from configuration-specific directories
2090         https://bugs.webkit.org/show_bug.cgi?id=51996
2091
2092         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2093
2094 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2095
2096         Unreviewed, fixing WinCE build after r75196.
2097
2098         WinCE port does not (yet) support NPAPI.
2099
2100         * Scripts/build-webkit:
2101
2102 2011-01-06  Xan Lopez  <xlopez@igalia.com>
2103
2104         Reviewed by Darin Adler.
2105
2106         File::Spec->rel2abs in sunspider-compare-results mangles parameters
2107         https://bugs.webkit.org/show_bug.cgi?id=52015
2108
2109         * Scripts/sunspider-compare-results: call rel2abs on our arguments
2110         after the platform has been detected, otherwise the script will
2111         mangle things like '--gtk' into '/a/path/--gtk', breaking the
2112         detection.
2113
2114 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2115
2116         Reviewed by Eric Seidel.
2117
2118         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
2119         https://bugs.webkit.org/show_bug.cgi?id=51346
2120
2121         * Scripts/build-webkit:
2122
2123 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
2124
2125         Reviewed by Adam Roben.
2126
2127         Windows bots need to archive/unarchive builds to/from configuration-specific directories
2128         https://bugs.webkit.org/show_bug.cgi?id=51996
2129         
2130         After the configuration directory change, we were archiving the incorrect directory for
2131         build product, so we were running tests on the wrong binaries.
2132         
2133         This change archives the correct directory, and also unarchives it into a configuration-
2134         specific directory.
2135
2136         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
2137         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
2138
2139 2011-01-06  Eric Seidel  <eric@webkit.org>
2140
2141         Reviewed by Mihai Parparita.
2142
2143         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
2144         https://bugs.webkit.org/show_bug.cgi?id=52002
2145
2146         See an example of this here:
2147         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
2148
2149         It's due to the fact that we pass around TestFailure() instance
2150         objects and yet expect them to all compare to be the same.
2151
2152         This is bad.  We should either have shared instances of these values
2153         or we should just pass around the class names.  There are already hacks
2154         in place to make TestFailure objects pass equality tests, I just added
2155         a __hash__ implementation so they can be used in sets as expected.
2156
2157         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2158         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2159
2160 2011-01-06  Evan Martin  <evan@chromium.org>
2161
2162         Reviewed by Tony Chang.
2163
2164         [gdb] handle inaccessible memory and UChar*
2165         https://bugs.webkit.org/show_bug.cgi?id=52003
2166
2167         To pretty-print a UChar*, we just grope around in the memory
2168         looking for a terminating NUL.  We need to handle the exception
2169         that can occur when we poke into an invalid location.
2170
2171         Additionally, the logic for choosing which pretty-printer would
2172         early return before hitting the point where we'd use the UChar*
2173         printer.  (Did this ever work?  How did it regress?)
2174
2175         * gdb/webkit.py:
2176
2177 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
2178
2179         Reviewed by Ada Chan.
2180
2181         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
2182         https://bugs.webkit.org/show_bug.cgi?id=51969
2183         
2184         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
2185
2186         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2187         (WTR::InjectedBundlePage::InjectedBundlePage):
2188         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
2189         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2190
2191 2011-01-06  James Robinson  <jamesr@chromium.org>
2192
2193         Reviewed by Simon Fraser.
2194
2195         Implement mozilla's animationTime property
2196         https://bugs.webkit.org/show_bug.cgi?id=51952
2197
2198         Chromium DRT support for webkitAnimationTime.
2199
2200         * DumpRenderTree/chromium/WebViewHost.cpp:
2201         (WebViewHost::paintInvalidatedRegion):
2202
2203 2011-01-06  Julie Parent  <jparent@chromium.org>
2204
2205         Reviewed by Tony Chang.
2206
2207         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
2208         https://bugs.webkit.org/show_bug.cgi?id=51217
2209
2210         * TestResultServer/model/jsonresults.py:
2211         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
2212         Adds missing documentation.
2213         * TestResultServer/model/jsonresults_unittest.py:
2214         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
2215         Update test_merge to take a number of builds to truncate at.
2216
2217 2011-01-06  Adam Barth  <abarth@webkit.org>
2218
2219         Reviewed by Eric Seidel.
2220
2221         The EWS should log outside of the working directory
2222         https://bugs.webkit.org/show_bug.cgi?id=51986
2223
2224         This patch prepare us for using git clean -x -d -f in the EWS wrapper
2225         script, which will actually clean the working copy back to a pristine
2226         state instead of leaving untracked directories and ignored files.
2227
2228         * Scripts/webkitpy/tool/commands/queues.py:
2229         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2230
2231 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2232
2233         Windows build fix.
2234         Back out attempted change to built-product-archive.
2235
2236         * BuildSlaveSupport/built-product-archive:
2237
2238 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2239
2240         Windows build fix.
2241         Include configuration name when unpacking a build archive.
2242
2243         Needed, since we split Windows build results into configuration-specific directories
2244         under WebKitOutputDir.
2245
2246         * BuildSlaveSupport/built-product-archive:
2247
2248 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2249
2250         Reviewed by Darin Adler.
2251
2252         Debug and Release builds on Windows clobber each other
2253         https://bugs.webkit.org/show_bug.cgi?id=49185
2254
2255         Changes the structure of WebKitBuild build products directory so we
2256         completely separate each build configuration into independent directories.
2257         
2258         Although we previously had per-configuration directories for obj, this change adds
2259         per-configuration directories for bin, lib, obj, and include. Each configuration's
2260         build products are stored within a directory inside of WebKitBuild.
2261         
2262         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
2263         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
2264
2265         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
2266         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
2267         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
2268         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
2269         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
2270         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
2271         * DumpRenderTree/win/ImageDiffCommon.vsprops:
2272         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
2273         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
2274         * FindSafari/FindSafari.vcproj:
2275         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
2276         * MiniBrowser/MiniBrowserPostBuild.cmd:
2277         * MiniBrowser/MiniBrowserPreBuild.cmd:
2278         * Scripts/webkitdirs.pm:
2279         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
2280         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
2281         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
2282         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
2283         * TestWebKitAPI/win/copy-resources.cmd:
2284         * WebKitAPITest/WebKitAPITestCommon.vsprops:
2285         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
2286         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
2287         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
2288         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
2289         * WebKitTestRunner/win/InjectedBundle.vcproj:
2290         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
2291         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
2292         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
2293         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
2294         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
2295         * WinLauncher/WinLauncherCommon.vsprops:
2296         * WinLauncher/WinLauncherPostBuild.cmd:
2297         * WinLauncher/WinLauncherPreBuild.cmd:
2298
2299 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
2300
2301         Reviewed by Ariya Hidayat.
2302
2303         [Qt] TestNetscapePlugin doesn't link on OS X
2304         https://bugs.webkit.org/show_bug.cgi?id=51948
2305
2306         Only add a dependency on libX11 on X11 systems
2307
2308         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2309
2310 2011-01-05  Jeff Miller  <jeffm@apple.com>
2311
2312         Reviewed by Adam Roben.
2313
2314         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
2315         https://bugs.webkit.org/show_bug.cgi?id=51970
2316
2317         * Scripts/webkitpy/style/checker.py:
2318         Add -readability/naming for WebKit2 C API directories.
2319
2320 2011-01-05  Eric Seidel  <eric@webkit.org>
2321
2322         Unreviewed, just fixing one more log error from my previous python patch.
2323
2324         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2325         https://bugs.webkit.org/show_bug.cgi?id=51802
2326
2327         webkit-patch failure-reason was logging about parsing errors
2328         due to my misunderstanding of how BeautifulSoup.findAll worked.
2329
2330         Fixed, and added a unit test.
2331
2332         * Scripts/webkitpy/common/net/layouttestresults.py:
2333         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2334
2335 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
2336
2337         Reviewed by Kenneth Rohde Christiansen.
2338
2339         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
2340         https://bugs.webkit.org/show_bug.cgi?id=51951
2341
2342         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
2343         to create new window from WebKit.
2344
2345         * MiniBrowser/qt/BrowserWindow.cpp:
2346         (newPageFunction):
2347         (BrowserWindow::BrowserWindow):
2348         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
2349         (BrowserWindow::newWindow):
2350         (BrowserWindow::updateUserAgentList):
2351         (BrowserWindow::showUserAgentDialog):
2352         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
2353         define the type of the backing store used for new windows.
2354         * MiniBrowser/qt/main.cpp:
2355         (main):
2356
2357 2011-01-05  Eric Seidel  <eric@webkit.org>
2358
2359         Reviewed by Ojan Vafai.
2360
2361         commit-queue should report failure type when reporting flaky tests
2362         https://bugs.webkit.org/show_bug.cgi?id=51900
2363
2364         This patch was a ridiculous amount of plumbing.  In the end I like
2365         the NRWT-style TestResult class even less.  But now we're passing
2366         a list of TestResult objects from the queue to the FlakyTestReporter.
2367         Thus the FlakyTestReporter can more easily report what type of failure
2368         occurred.
2369
2370         In the process, I found that I was not alone in finding TestResult
2371         cumbersome to use.  A bunch of code was trying to create a TestResult
2372         object with default values.  However since the constructor didn't make
2373         this easy, some places were getting it wrong (including the TestResult unit test)!
2374         I've fixed the TestResult constructor to have default values for non-essential
2375         arguments.
2376
2377         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2378         * Scripts/webkitpy/common/net/layouttestresults.py:
2379         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2380         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2381         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2382         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2383         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
2384         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
2385         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2386         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2387         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2388         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2389         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2390         * Scripts/webkitpy/tool/commands/queues.py:
2391         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2392
2393 2011-01-05  Eric Seidel  <eric@webkit.org>
2394
2395         Unreviewed.
2396
2397         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2398         https://bugs.webkit.org/show_bug.cgi?id=51802
2399
2400         Add another unit test to cover a previously missing import.
2401
2402         * Scripts/webkitpy/common/net/layouttestresults.py:
2403         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2404
2405 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
2406
2407         Reviewed by David Levin.
2408
2409         Add mihaip@chromium.org as a reviewer
2410         https://bugs.webkit.org/show_bug.cgi?id=51966
2411         
2412         Add myself as a reviewer.
2413
2414         * Scripts/webkitpy/common/config/committers.py:
2415
2416 2011-01-05  James Simonsen  <simonjam@chromium.org>
2417
2418         Unreviewed. Adding myself to the list of committers.
2419
2420         * Scripts/webkitpy/common/config/committers.py:
2421
2422 2011-01-05  Eric Seidel  <eric@webkit.org>
2423
2424         Unreviewed.
2425
2426         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2427         https://bugs.webkit.org/show_bug.cgi?id=51802
2428
2429         Fix two exceptions seen on the bots after my original commit.
2430
2431         * Scripts/webkitpy/common/net/layouttestresults.py:
2432         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2433
2434 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
2435
2436         Reviewed by Andreas Kling.
2437
2438         [Qt]Add local storage settings to QtTestBrowser command line arguments 
2439         https://bugs.webkit.org/show_bug.cgi?id=51750
2440
2441         * QtTestBrowser/main.cpp:
2442         (LauncherApplication::handleUserOptions):
2443          Local storage settings can be enable form command line arguments for
2444          QtTestBrowser.
2445
2446 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
2447
2448         Reviewed by Martin Robinson.
2449
2450         GTK: AX: DRT needs to use correct root object method.
2451         https://bugs.webkit.org/show_bug.cgi?id=51911
2452
2453         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2454         (AccessibilityController::rootElement):
2455
2456 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2457
2458         Rubber-stamped by Csaba Osztrogonác.
2459
2460         Based on idea from Péter Gál.
2461
2462         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
2463
2464 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2465
2466         Reviewed by Adam Barth.
2467
2468         sheriff-bot should be able to do multi-revision rollouts
2469         https://bugs.webkit.org/show_bug.cgi?id=51176
2470
2471         * Scripts/webkitpy/tool/bot/irc_command.py:
2472         * Scripts/webkitpy/tool/bot/sheriff.py:
2473         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2474
2475 2011-01-05  Eric Seidel  <eric@webkit.org>
2476
2477         Reviewed by Adam Barth.
2478
2479         queues.webkit.org should have per-bot status pages
2480         https://bugs.webkit.org/show_bug.cgi?id=51906
2481
2482         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
2483         statuses from a single queue.  Now that we have many bots servicing
2484         some queues (commit-queue, win-ews, etc.) its easy to have the messages
2485         you care about scroll off the end of the 15-message limit on the main page.
2486
2487         Eventually we should probably rename /queue-status to /queue or /queues,
2488         but that's fodder for another patch.
2489
2490         * QueueStatusServer/handlers/queuestatus.py:
2491         * QueueStatusServer/index.yaml:
2492         * QueueStatusServer/main.py:
2493         * QueueStatusServer/templates/includes/singlequeuestatus.html:
2494          - This probably should use a custom filter instead of hard-coding
2495            the URL scheme here, but I couldn't figure out how to easily
2496            create such a filter.  Most filters work with "strings" so we can't
2497            pass the status object.  We could add a method to the status
2498            object and call that, but that seemed a bit strange too.
2499         * QueueStatusServer/templates/queuestatus.html:
2500
2501 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2502
2503         Unreviewed. Adding myself to the list of committers.
2504
2505         * Scripts/webkitpy/common/config/committers.py:
2506
2507 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
2508
2509         Reviewed by David Levin.
2510
2511         check-webkit-style treated some macros with parentheses after #elif as function calls
2512         https://bugs.webkit.org/show_bug.cgi?id=51695
2513
2514         Ingore function call space checking in any preprocessor directives
2515         (things starting with #). Change search() to match() because 
2516         preprocessor directives are supposed to be in the beginning of lines.
2517
2518         * Scripts/webkitpy/style/checkers/cpp.py:
2519         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
2520
2521 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
2522
2523         Reviewed by Tony Chang.
2524
2525         Change the --multi-load test option to --stress-opt
2526         https://bugs.webkit.org/show_bug.cgi?id=50751
2527
2528         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2529         (runTest):
2530         (main):
2531         * DumpRenderTree/chromium/TestShell.cpp:
2532         (TestShell::TestShell):
2533         * DumpRenderTree/chromium/TestShell.h:
2534         (TestShell::stressOpt):
2535         (TestShell::setStressOpt):
2536         (TestShell::stressDeopt):
2537         (TestShell::setStressDeopt):
2538         (TestShell::javaScriptFlags):
2539         (TestShell::setJavaScriptFlags):
2540         * Scripts/webkitpy/layout_tests/port/chromium.py:
2541         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2542
2543 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
2544
2545         Reviewed by Sam Weinig.
2546
2547         WK2: Support Accessibility
2548         https://bugs.webkit.org/show_bug.cgi?id=51859
2549
2550         Use rootObject() method to get top of accessibility tree.
2551
2552         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2553         (AccessibilityController::focusedElement):
2554         (AccessibilityController::rootElement):
2555
2556 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
2557
2558         Reviewed by Darin Adler.
2559
2560         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
2561         https://bugs.webkit.org/show_bug.cgi?id=51846
2562
2563         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
2564         back to GRefPtr.
2565
2566 2011-01-04  Zhe Su  <suzhe@chromium.org>
2567
2568         Reviewed by Kenneth Russell.
2569
2570         Fix insertText, setMarkedText and unmarkText methods of
2571         TextInputController to call corresponding methods of WebKit::WebView
2572         rather than WebKit::WebFrame. This change matches the behavior of
2573         chromium browser.
2574         insertText corresponds to WebView::confirmComposition(text)
2575         setMarkedText corresponds to WebView::setComposition(...)
2576         unmarkText corresponds to WebView::confirmComposition()
2577         https://bugs.webkit.org/show_bug.cgi?id=51693
2578
2579         * DumpRenderTree/chromium/TextInputController.cpp:
2580         (TextInputController::insertText):
2581         (TextInputController::setMarkedText):
2582         (TextInputController::unmarkText):
2583
2584 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
2585
2586         Reviewed by Laszlo Gombos.
2587
2588         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
2589
2590         On Symbian productDir points to the source directory. Removing all the
2591         empty files from the productDir directory corrupts the svn repository.
2592
2593         * Scripts/build-webkit:
2594
2595 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
2596
2597         Reviewed by Adam Barth.
2598
2599         [Qt] Add SelectAll option to the context menu for the editor
2600         https://bugs.webkit.org/show_bug.cgi?id=50049
2601
2602         Set shortcut for the SelectAll action.
2603
2604         * QtTestBrowser/mainwindow.cpp:
2605         (MainWindow::buildUI):
2606
2607 2011-01-03  David Levin  <levin@chromium.org>
2608
2609         Reviewed by Eric Seidel.
2610
2611         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
2612         https://bugs.webkit.org/show_bug.cgi?id=51842
2613
2614         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
2615         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
2616
2617 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
2618
2619         Reviewed by David Kilzer.
2620
2621         [WINCE] Adds a build slave.
2622         https://bugs.webkit.org/show_bug.cgi?id=50523
2623
2624         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
2625         entry for a release build of the WinCE port.
2626         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
2627         flag to build the WinCE port.
2628
2629 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
2630
2631         Reviewed by David Kilzer.
2632
2633         Add WinCE support to build-webkit
2634         https://bugs.webkit.org/show_bug.cgi?id=51642
2635
2636         * Scripts/build-webkit:
2637         * Scripts/webkitdirs.pm:
2638
2639 2011-01-03  Eric Seidel  <eric@webkit.org>
2640
2641         Reviewed by Adam Barth.
2642
2643         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2644         https://bugs.webkit.org/show_bug.cgi?id=51802
2645
2646         I'm not the biggest fan of the test_failures or test_results classes,
2647         but it's better to have one shared set of classes, than separate ones
2648         for new vs. old run-webkit-test result handling.
2649
2650         This moves the ORWT results class "LayoutTestResults" over to using
2651         TestResult and TestFailure classes, making it easy for us to
2652         make all our sheriff-bot and other webkitpy code NRWT ready.
2653
2654         This also makes it a trivial patch to generate results.json information
2655         from ORWT results.html files (for flaky test analysis, etc.) as well
2656         as making it a one-liner to report test failure types when the
2657         commit-queue sees flaky tests.
2658
2659         This patch tried not to add new functionality, but only to replace
2660         the guts of LayoutTestResults, while adding unit tests and hoping
2661         not to break anything.
2662
2663         I also moved callers which assumed User.prompt* were static/class methods
2664         to using them as instance methods (since we'll eventually want to make them such).
2665
2666         In the process of re-writing things, I broke the rebaseline command, so I wrote
2667         a unit test to catch my breakage were I do do so again in the future.
2668
2669         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2670         * Scripts/webkitpy/common/net/layouttestresults.py:
2671         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2672         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2673         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
2674         * Scripts/webkitpy/tool/commands/queries.py:
2675         * Scripts/webkitpy/tool/commands/rebaseline.py:
2676         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2677         * Scripts/webkitpy/tool/mocktool.py:
2678
2679 2011-01-03  Adam Barth  <abarth@webkit.org>
2680
2681         Reviewed by Simon Fraser.
2682
2683         webkit-patch shouldn't waste time cleaning a working directory that's already clean
2684         https://bugs.webkit.org/show_bug.cgi?id=51840
2685
2686         * Scripts/webkitpy/common/checkout/scm.py:
2687
2688 2011-01-03  Adam Barth  <abarth@webkit.org>
2689
2690         Reviewed by Simon Fraser.
2691
2692         webkit-patch should only hide update output if --quiet
2693         https://bugs.webkit.org/show_bug.cgi?id=51838
2694
2695         As requested by smfr.
2696
2697         * Scripts/webkitpy/tool/steps/update.py:
2698
2699 2011-01-03  Adam Barth  <abarth@webkit.org>
2700
2701         Reviewed by David Levin.
2702
2703         commit-queue shouldn't reject patches twice if two bots process the same patch
2704         https://bugs.webkit.org/show_bug.cgi?id=51805
2705
2706         Before raising an error, we first check whether the patch is still in
2707         the commit-queue.  This check is still racy, of course, but the time
2708         window is much smaller.
2709
2710         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2711
2712 2011-01-03  Sam Weinig  <sam@webkit.org>
2713
2714         Reviewed by Anders Carlsson.
2715
2716         Make run-api-tests less chatty.
2717         https://bugs.webkit.org/show_bug.cgi?id=51831
2718
2719         - Make script quiet by default and add --verbose option (replacing --quiet).
2720         - When not verbose, pipe stdout and stderr to devnull.
2721
2722         * Scripts/run-api-tests:
2723
2724 2011-01-03  Pratik Solanki  <psolanki@apple.com>
2725
2726         Unreviewed. Adding myself to committers.py.
2727
2728         * Scripts/webkitpy/common/config/committers.py:
2729
2730 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
2731
2732         Reviewed by Xan Lopez.
2733
2734         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
2735         https://bugs.webkit.org/show_bug.cgi?id=51806
2736
2737         Originally, the $libraryName is 'JavaScriptCore'. When building release 
2738         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
2739         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
2740         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 
2741         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
2742         so make it 'WebKitBuild/Release/.libs'
2743
2744         * Scripts/webkitdirs.pm: 
2745
2746 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
2747
2748         Reviewed by Adam Barth.
2749
2750         Make EFL a core builder
2751         https://bugs.webkit.org/show_bug.cgi?id=51804
2752
2753         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2754         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2755
2756 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2757
2758         [Qt] Unreviewed fix after r74855 and r74875.
2759
2760         * BuildSlaveSupport/built-product-archive:
2761          - Create directories explicitly.
2762          - Pass shell=True to subprocess.call().
2763
2764 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2765
2766         [Qt] Unreviewed fix after r74855.
2767
2768         Move JavaScriptCore to Source
2769         https://bugs.webkit.org/show_bug.cgi?id=51604
2770
2771         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
2772
2773 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2774
2775         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
2776
2777         Move JavaScriptCore to Source
2778         https://bugs.webkit.org/show_bug.cgi?id=51604
2779
2780         * Scripts/webkitdirs.pm:
2781
2782 2011-01-02  Robert Hogan  <robert@webkit.org>
2783
2784         Unreviewed, build fix.
2785
2786         [Qt] Fix DRT build after 74855
2787
2788         * DumpRenderTree/qt/DumpRenderTree.pro:
2789
2790 2011-01-01  Adam Barth  <abarth@webkit.org>
2791
2792         Remove the assumption from the Qt and Gtk builds that every project is
2793         in the root directory.
2794
2795         * Scripts/build-webkit:
2796
2797 2011-01-01  Adam Barth  <abarth@webkit.org>
2798
2799         Reviewed by Eric Seidel.
2800
2801         Teach svn-apply how to apply patches even though JavaScriptCore has moved
2802         https://bugs.webkit.org/show_bug.cgi?id=51796
2803
2804         After this change, svn-apply will magically apply patches to
2805         JavaScriptCore/foo to Source/JavaScriptCore/foo.
2806
2807         * Scripts/VCSUtils.pm:
2808
2809 2011-01-01  Adam Barth  <abarth@webkit.org>
2810
2811         Reviewed by Eric Seidel.
2812
2813         Move JavaScriptCore to Source
2814         https://bugs.webkit.org/show_bug.cgi?id=51604
2815
2816         Update references to JavaScriptCore to point to the new location.
2817
2818         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2819         * DumpRenderTree/qt/DumpRenderTree.pro:
2820         * DumpRenderTree/qt/ImageDiff.pro:
2821         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2822         * DumpRenderTree/wscript:
2823         * Scripts/build-jsc:
2824         * Scripts/build-webkit:
2825         * Scripts/do-file-rename:
2826         * Scripts/do-webcore-rename:
2827         * Scripts/run-javascriptcore-tests:
2828         * Scripts/update-javascriptcore-test-results:
2829         * Scripts/webkitdirs.pm:
2830         * Scripts/webkitpy/common/config/build_unittest.py:
2831         * Scripts/webkitpy/style/checker.py:
2832         * Scripts/webkitpy/style/checker_unittest.py:
2833         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2834         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2835         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2836         * wx/build/settings.py:
2837
2838 2011-01-01  Adam Barth  <abarth@webkit.org>
2839
2840         Reviewed by Eric Seidel.
2841
2842         Move Sources to Source
2843         https://bugs.webkit.org/show_bug.cgi?id=51794
2844
2845         Update scripts to point to the new location.
2846
2847         * Scripts/build-webkit:
2848         * Scripts/do-file-rename:
2849         * Scripts/do-webcore-rename:
2850         * Scripts/webkitpy/common/config/build.py:
2851         * Scripts/webkitpy/common/config/build_unittest.py:
2852
2853 2010-12-31  Kent Tamura  <tkent@chromium.org>
2854
2855         Reviewed by Eric Seidel.
2856
2857         [DRT/Chromium] Enable mock spell checker on non-OSX
2858         https://bugs.webkit.org/show_bug.cgi?id=51401
2859
2860         * DumpRenderTree/chromium/WebViewHost.cpp:
2861         (WebViewHost::spellCheck):
2862
2863 2010-12-31  Adam Barth  <abarth@webkit.org>
2864
2865         Reviewed by Ariya Hidayat.
2866
2867         Remove Tools/Scripts/wkstyle
2868         https://bugs.webkit.org/show_bug.cgi?id=51774
2869
2870         This script appears to not have been touched in a while and seems to
2871         have been replaced by check-webkit-style.
2872
2873         * Scripts/wkstyle: Removed.
2874
2875 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
2876
2877         Unreviewed. Coding style fix.
2878
2879         * DumpRenderTree/chromium/TestShell.h:
2880
2881 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
2882
2883         Reviewed by Pavel Feldman.
2884
2885         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
2886
2887         It was a problem with Chromium DRT. DevToolsAgent object instance was
2888         attached not only to the inspected page but to the DevTools window too.
2889         As result all the inspector files were interpreted as a content of inspected page
2890         and were transfered to the DevTools scripts panel for debugging etc.
2891
2892         https://bugs.webkit.org/show_bug.cgi?id=51735
2893
2894         * DumpRenderTree/chromium/TestShell.cpp:
2895         (TestShell::TestShell):
2896         (TestShell::bindJSObjectsToWindow):
2897         (TestShell::createNewWindow):
2898         * DumpRenderTree/chromium/TestShell.h:
2899
2900 2010-12-31  Adam Barth  <abarth@webkit.org>
2901
2902         Rubber-stamped by Eric Seidel.
2903
2904         Move PageLoadTests to PerformanceTests/PageLoad
2905         https://bugs.webkit.org/show_bug.cgi?id=51771
2906
2907         Update references to PageLoadTests to point to the new location.
2908
2909         * Scripts/run-pageloadtest:
2910         * Scripts/webkitpy/common/config/build.py:
2911
2912 2010-12-31  Adam Barth  <abarth@webkit.org>
2913
2914         Rubber-stamped by Eric Seidel.
2915
2916         Move SunSpider into PerformanceTests
2917         https://bugs.webkit.org/show_bug.cgi?id=51769
2918
2919         Update these scripts to point to the new location.
2920
2921         * Scripts/run-sunspider:
2922         * Scripts/sunspider-compare-results:
2923
2924 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
2925
2926         Reviewed by Kent Tamura.
2927
2928         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
2929         https://bugs.webkit.org/show_bug.cgi?id=51728
2930         
2931         Add implementation of the Mac WebThemeEngine that uses an NSScroller
2932         to render top-level scrollbars. This makes them match the Mac port's
2933         use of an NSScrollView, which means that we'll be able to share more
2934         pixel baselines.
2935         
2936         The new rendering code will not be activated until the 
2937         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
2938         ScrollbarThemeChromiumMac.
2939
2940         * DumpRenderTree/DumpRenderTree.gypi:
2941         * DumpRenderTree/chromium/TestShellMac.mm:
2942         (platformInit):
2943         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
2944         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
2945         (+[FakeActiveWindow alwaysActiveWindow]):
2946         (+[FakeActiveWindow alwaysInactiveWindow]):
2947         (-[FakeActiveWindow initWithActiveControls:]):
2948         (-[FakeActiveWindow _hasActiveControls]):
2949         (WebThemeEngineDRTMac::paintScrollbarThumb):
2950         (stateToHIEnableState):
2951         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2952         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2953
2954 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
2955
2956         Reviewed by David Kilzer.
2957
2958         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
2959         used
2960         https://bugs.webkit.org/show_bug.cgi?id=51672
2961
2962         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
2963         with USE_SYSTEM_MALLOC=1
2964         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
2965         with USE_SYSTEM_MALLOC=1
2966
2967 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2968
2969         Reviewed by David Kilzer.
2970
2971         [Qt] [Symbian] Fix build-webkit script for Symbian
2972         https://bugs.webkit.org/show_bug.cgi?id=51509
2973
2974         Set the OUTPUT_DIR for Symbian to be the same as the source
2975         directory.
2976
2977         * Scripts/webkitdirs.pm:
2978
2979 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
2980
2981         Reviewed by Darin Adler.
2982
2983         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
2984         https://bugs.webkit.org/show_bug.cgi?id=51758
2985
2986         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
2987
2988         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
2989         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
2990
2991 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
2992
2993         Unreviewed WinCE buildfix.
2994
2995         * WinCELauncher/main.cpp: Add missing include.
2996
2997 2010-12-29  Daniel Bates  <dbates@rim.com>
2998
2999         Reviewed by Darin Adler.
3000
3001         svn-apply updates date of wrong change log entry for a change log diff that
3002         contains two consecutive entries with the same author and date
3003         https://bugs.webkit.org/show_bug.cgi?id=46061
3004
3005         Fixes an issue where the date of the wrong change log entry may be modified.
3006         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
3007         in a ChangeLog file to the top of the file.
3008
3009         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
3010         diff when it detects that the diff inserts a change log entry earlier in a
3011         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
3012         change. With the advent of the commit-queue this functionality of bailing out
3013         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
3014         Instead, we should always move the change log entry to the top of the ChangeLog file.
3015
3016         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
3017         the date line of the correct change log entry in a ChangeLog diff.
3018
3019         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
3020
3021         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
3022           Updated the following unit tests now that we move entries inserted earlier to the top:
3023           - "fixChangeLogPatch: New entry inserted in middle."
3024             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
3025
3026           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
3027             (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
3028
3029         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
3030
3031 2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>
3032
3033         Reviewed by Eric Seidel.
3034
3035         [Qt] Fixed compatibility with gold linker on X11 platforms
3036         https://bugs.webkit.org/show_bug.cgi?id=51700
3037
3038         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3039         Linked TestNetscapePlugin with libX11 on Unix platforms
3040
3041 2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
3042
3043         Reviewed by Darin Adler.
3044
3045         Circular dependency in webkitpy.common.checkout.changelog module
3046         https://bugs.webkit.org/show_bug.cgi?id=50475
3047
3048         Remove automatic import of api.Checkout module when any checkout/
3049         submodule is imported (e.g.: when checkout.scm.Git is imported).
3050
3051         * Scripts/webkitpy/common/checkout/__init__.py:
3052
3053 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
3054
3055         Reviewed by Ojan Vafai.
3056
3057         prepare-ChangeLog should support the -g option for specifying the git-commit
3058         https://bugs.webkit.org/show_bug.cgi?id=51708
3059
3060         Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
3061         webkit-patch, though the exact meaning of the two options remain different.
3062
3063         * Scripts/prepare-ChangeLog: Add -g.
3064
3065 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
3066
3067         Reviewed by Simon Hausmann.
3068
3069         [Qt] Fix compilation with Qt in namespace
3070         https://bugs.webkit.org/show_bug.cgi?id=51701
3071
3072         * QtTestBrowser/webview.h:
3073
3074 2010-12-28  Daniel Bates  <dbates@rim.com>
3075
3076         Reviewed by Sam Weinig.
3077
3078         Substitute // MARK: for compiler-specific #pragma mark
3079         https://bugs.webkit.org/show_bug.cgi?id=51657
3080
3081         Fix future compilation warnings about "#pragma mark" on GTK+ bots by
3082         substituting  "// MARK:" for "#pragma mark", which provides
3083         analogous code-bookmarking functionality under Xcode.
3084
3085         Also, for consistency, we should substitute "// MARK:" for compiler-
3086         specific "#pragma mark" in the source files for the Mac port.
3087
3088         * DumpRenderTree/AccessibilityTextMarker.cpp:
3089         * DumpRenderTree/cf/WebArchiveDumpSupport.h:
3090         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
3091         * DumpRenderTree/mac/ObjCController.m:
3092         * MiniBrowser/mac/AppDelegate.m:
3093         * MiniBrowser/mac/BrowserWindowController.m:
3094
3095 2010-12-28  Xan Lopez  <xlopez@igalia.com>
3096
3097         Reviewed by Eric Seidel.
3098
3099         Add --no-build option to run-sunspider
3100         https://bugs.webkit.org/show_bug.cgi?id=51658
3101
3102         * Scripts/run-sunspider: add --no-build flag to skip building
3103         phase.
3104
3105 2010-12-27  Daniel Bates  <dbates@rim.com>
3106
3107         Rubber-stamped by Martin Robinson.
3108
3109         Append the directory Tools/DumpRenderTree to the list of directories that
3110         do-webcore-rename should search so that it can rename DRT files and
3111         source code.
3112
3113         * Scripts/do-webcore-rename:
3114
3115 2010-12-27  Eric Seidel  <eric@webkit.org>
3116
3117         Reviewed by Adam Barth.
3118
3119         build-webkit should detect missing Java SDK and explain how to install it
3120         https://bugs.webkit.org/show_bug.cgi?id=51651
3121
3122         * Scripts/build-webkit:
3123
3124 2010-12-26  Martin Robinson  <mrobinson@igalia.com>
3125
3126         Reviewed by Daniel Bates.
3127
3128         [GTK] Add support for build-jsc
3129         https://bugs.webkit.org/show_bug.cgi?id=51625
3130
3131         Add GTK+ support to build-jsc now that building the jsc executable as
3132         a standalone target is easy.
3133
3134         * Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
3135         * Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
3136         * Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject
3137         and pass it along to buildAutotoolsProject.
3138
3139 2010-12-27  David Levin  <levin@chromium.org>
3140
3141         Reviewed by Eric Seidel.
3142
3143         check-webkit-style check for meaningless variable names in function declarations.
3144         https://bugs.webkit.org/show_bug.cgi?id=51523
3145
3146         * Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp
3147         from the new check and whitespace/parens because the syntax is unusual and
3148         produced a fair number of positives for these checks.
3149         * Scripts/webkitpy/style/checkers/cpp.py:
3150         (_convert_to_lower_with_underscores): Used as a canonical form for type names
3151         and parameter names when determining if the parameter name is useless.
3152         (_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
3153         (Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
3154         format.
3155         (_check_parameter_name_against_text):  Checks to see if the parameter name is in the
3156         text or an acronym of it.
3157         (check_function_definition): Checks function definitions for meaningless variable names.
3158         (process_line): Added call to check_function_definition.
3159         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3160         (CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
3161         (CppFunctionsTest.test_create_acronym): Test for _create_acronym.
3162         (CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
3163         (CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
3164         because when only checking a snippet, there are a lot of bogus functions.
3165         (CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
3166         that I put there previously and just noticed.
3167         (WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
3168         check_function_definition and process_line.
3169
3170 2010-12-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3171
3172         Reviewed by Martin Robinson.
3173
3174         [GTK] Disable flash plugin in GtkLauncher when using gtk3
3175         https://bugs.webkit.org/show_bug.cgi?id=51591
3176
3177         Flash plugin uses gtk2 that is incompatible with gtk3 making
3178         webkit crash when it's built with gtk3.
3179
3180         * GtkLauncher/main.c:
3181         (main):
3182
3183 2010-12-25  Adam Barth  <abarth@webkit.org>
3184
3185         Reviewed by Eric Seidel.
3186
3187         Move ANGLE to Sources/ThirdParty
3188         https://bugs.webkit.org/show_bug.cgi?id=51605
3189
3190         * Scripts/build-webkit:
3191           - Point to the new ANGLE location.
3192
3193 2010-12-26  David Levin  <levin@chromium.org>
3194
3195         Reviewed by Eric Seidel.
3196
3197         check-webkit-style should be able to parse function declaration parameters.
3198         https://bugs.webkit.org/show_bug.cgi?id=51451
3199
3200         * Scripts/webkitpy/style/checkers/cpp.py:
3201         (Position.__init__): Holds simple position information (row, column).
3202         (Parameter.__init__): Holds information about a parameter.
3203         (SingleLineView.__init): Converts multiple lines into a single line for simpler searches.
3204         (SingleLineView.convert_column_to_row): Returns the original row given a column.
3205         (create_skeleton_parameters): Simplifies a parameter list for easier searching.
3206         (find_parameter_name_index): Finds where the parameter name is.
3207         (parameter_list): Generates the list of parameters for a function.
3208         (_FunctionState.begin): Added information to allow determining the parameters
3209         on demand.
3210         (_FunctionState.get_parameter_list): Returns a tuple of function parameters.
3211         (detect_functions): Improve function detection for operator functions and
3212         determine where the parameters end and pass that to _FunctionState.begin.
3213         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3214         (CppFunctionsTest.test_parameter): Verifies Parameter functionality.
3215         (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality.
3216         (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters.
3217         (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index.
3218         (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list.
3219         Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list.
3220         (FunctionDetectionTest.perform_function_detection): Added support for verifying
3221         the parameters found.
3222         (FunctionDetectionTest.test_function_declaration_detection): Added more function
3223         detection test to verify that we catch the operator functions.
3224         (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros.
3225         (FunctionDetectionTest.test_parameter_list): Added tests to verify the parameter parsing.
3226         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Removed
3227         because the error. The test is about the bad function name. Fixing the name makes the test exactly like
3228         test_function_length_check_definition_severity1_for_test.
3229
3230 2010-12-25  Patrick Gansterer  <paroga@webkit.org>
3231
3232         Unreviewed WinCE buildfix after r74334.
3233
3234         * CMakeListsWinCE.txt:
3235
3236 2010-12-24  Sheriff Bot  <webkit.review.bot@gmail.com>
3237
3238         Unreviewed, rolling out r74632.
3239         http://trac.webkit.org/changeset/74632
3240         https://bugs.webkit.org/show_bug.cgi?id=51600
3241
3242         makes test-webkitpy hang forever on GTK (Requested by philn-tp
3243         on #webkit).
3244
3245         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
3246         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
3247
3248 2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>
3249
3250         Reviewed by Kenneth Rohde Christiansen.
3251
3252         [EFL] Screen doesn't be rendered when changing size of EWebLauncher
3253         https://bugs.webkit.org/show_bug.cgi?id=43528
3254
3255         Remove on_resize because ewk_view_fixed_layout_size_set should not be
3256         called on callback of EVAS_CALLBACK_RESIZE. As it change size of
3257         FrameView, rendering was ignored when _ewk_view_smart_calculate was
3258         called.
3259
3260         * EWebLauncher/main.c:
3261         (browserCreate):
3262
3263 2010-12-24  Eric Seidel  <eric@webkit.org>
3264
3265         Reviewed by Adam Barth.
3266
3267         webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
3268         https://bugs.webkit.org/show_bug.cgi?id=28291
3269
3270         This is a start.  At least now webkit-patch will prompt when your ChangeLog looks questionable.
3271         We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
3272         to strings with find in the diff.
3273         Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.
3274
3275         * Scripts/webkitpy/common/checkout/api.py:
3276         * Scripts/webkitpy/common/checkout/diff_parser.py:
3277         * Scripts/webkitpy/tool/steps/abstractstep.py:
3278         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
3279         * Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
3280         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
3281         * Scripts/webkitpy/tool/steps/validatereviewer.py:
3282
3283 2010-12-24  Dirk Pranke  <dpranke@chromium.org>
3284
3285         Reviewed by Kenneth Russell.
3286
3287         Modify new-run-webkit-tests to shut up and exit when all the threads
3288         are wedged so that test runs complete faster and we don't end up
3289         w/ enormous log files.
3290
3291         https://bugs.webkit.org/show_bug.cgi?id=51572
3292
3293         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
3294         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
3295
3296 2010-12-24  Eric Seidel  <eric@webkit.org>
3297
3298         Reviewed by David Levin.
3299
3300         commit-queue should better explain how it will re-open bugs and follow duplicate chains
3301         https://bugs.webkit.org/show_bug.cgi?id=51549
3302
3303         I've had multiple people ask me about the commit-queue's behavior
3304         regarding reporting flaky tests.  I figured it would be best to just
3305         have the queue explain itself in the bugs it files.
3306
3307         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3308         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3309
3310 2010-12-24  Shinichiro Hamaji  <hamaji@chromium.org>
3311
3312         Reviewed by Eric Seidel.
3313
3314         check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt
3315         https://bugs.webkit.org/show_bug.cgi?id=51467
3316
3317         * Scripts/webkitpy/style/checker.py:
3318         * Scripts/webkitpy/style/checker_unittest.py:
3319
3320 2010-12-23  Adam Barth  <abarth@webkit.org>
3321
3322         Rubber-stamped by Eric Seidel.
3323
3324         Move JavaScriptGlue into Sources
3325         https://bugs.webkit.org/show_bug.cgi?id=51583
3326
3327         These tools refer to JavaScriptGlue and need to be updated to its new
3328         location.
3329
3330         * Scripts/build-webkit:
3331         * Scripts/do-file-rename:
3332         * Scripts/do-webcore-rename:
3333         * Scripts/webkitpy/common/config/build.py:
3334         * Scripts/webkitpy/common/config/build_unittest.py:
3335
3336 2010-12-23  Lucas Forschler  <lforschler@apple.com>
3337
3338         Reviewed by Eric Seidel.
3339
3340         Bug 51539 - update iexploder scripts to point to new location
3341
3342         * Scripts/run-iexploder-tests:
3343         * Scripts/update-iexploder-cssproperties:
3344
3345 2010-12-23  Evan Martin  <evan@chromium.org>
3346
3347         Reviewed by Ryosuke Niwa.
3348
3349         [chromium] LayoutTestController warning in float->int conversion
3350         https://bugs.webkit.org/show_bug.cgi?id=51553
3351
3352         Rather than reading an int, converting to a float, then getting a compiler
3353         warning on passing the float to something that expects an int, instead
3354         just pass around ints.
3355
3356         No tests, fixes a compiler warning.
3357
3358         * DumpRenderTree/chromium/LayoutTestController.cpp:
3359         (parsePageSizeParameters):
3360         (LayoutTestController::pageNumberForElementById):
3361         (LayoutTestController::numberOfPages):
3362
3363 2010-12-23  Lucas Forschler  <lforschler@apple.com>
3364
3365         Reviewed by Darin Adler.
3366
3367         Bug 51537 - iexploder needs cleanup
3368         
3369         * iExploder/htdocs: Removed.
3370         * iExploder/htdocs/config.rb: Removed.
3371         * iExploder/htdocs/cssproperties.in: Removed.
3372         * iExploder/htdocs/cssvalues.in: Removed.
3373         * iExploder/htdocs/htmlattrs.in: Removed.
3374         * iExploder/htdocs/htmltags.in: Removed.
3375         * iExploder/htdocs/htmlvalues.in: Removed.
3376         * iExploder/htdocs/iexploder.cgi: Removed.
3377         * iExploder/htdocs/iexploder.rb: Removed.
3378         * iExploder/htdocs/index.html: Removed.
3379         * iExploder/htdocs/webserver.rb: Removed.
3380         * iExploder/iexploder-1.7.2/output: Removed.
3381         * iExploder/tools: Removed.
3382         * iExploder/tools/lasthit.rb: Removed.
3383         * iExploder/tools/osx_last_crash.rb: Removed.
3384         * iExploder/tools/showtest.rb: Removed.
3385
3386 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3387
3388         Reviewed by Kenneth Rohde Christiansen.
3389
3390         [EFL] Make 'single' the default backing store in EWebLauncher
3391         https://bugs.webkit.org/show_bug.cgi?id=51534
3392
3393         'single' is the simplest backing store and the one intended to be the
3394         default in the test browser. By mistake the tiled backing store was
3395         left as default in r72617.
3396
3397         * EWebLauncher/main.c:
3398         (browserCreate): ditto.
3399
3400 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3401
3402         Reviewed by Kenneth Rohde Christiansen.
3403
3404         [EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround
3405         https://bugs.webkit.org/show_bug.cgi?id=51533
3406
3407         There's no point in concatenating env("HOME") with "blah", so remove
3408         option from EWebLauncher.
3409
3410         * EWebLauncher/main.c:
3411         (main): ditto.
3412
3413 2010-12-23  Ilya Tikhonovsky  <loislo@chromium.org>
3414
3415         Reviewed by Eric Seidel.
3416
3417         Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).
3418
3419         Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
3420         I just discovered that we have two additional GC runs per each WebViewHost.
3421         Test_shell had no such calls.
3422         These gc runs eat 15% of cpu time.
3423
3424         https://bugs.webkit.org/show_bug.cgi?id=51479
3425
3426         * DumpRenderTree/chromium/WebViewHost.cpp:
3427         (WebViewHost::~WebViewHost):
3428
3429 2010-12-22  Dirk Pranke  <dpranke@chromium.org>
3430
3431         Reviewed by Ojan Vafai.
3432
3433         This change splits out the TestRunner class into its own file.
3434         When we fork the code for message passing, we will create a new
3435         TestRunner, and this change will allow that to be more modular.
3436
3437         While we're at it, split out TestInput and ResultSummary into
3438         their own files, to reduce the size of run_webkit_tests to
3439         something more managable.
3440
3441         https://bugs.webkit.org/show_bug.cgi?id=51092
3442
3443         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3444         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
3445         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3446         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
3447         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
3448         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3449         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3450
3451  2010-12-22  Dirk Pranke  <dpranke@chromium.org>
3452
3453         Reviewed by Ojan Vafai.
3454
3455         nrwt multiprocessing - start over, prepare to fork the code
3456  
3457         This code cleans up the signatures and implementation of the
3458         TestRunner class so we can easily fork it to run either the
3459         stable implementation or the new, unstable message-passing
3460         implementation. The two variants will have different
3461         implementations of the run_tests() method. We will switch
3462         between the two based on the setting for the '--worker-model'
3463         switch. We rename the two currently valid values to 'old-inline'
3464         and 'old-threads'.
3465
3466         https://bugs.webkit.org/show_bug.cgi?id=51081
3467
3468         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3469         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3470
3471 2010-12-22  Victor Wang  <victorw@chromium.org>
3472
3473         Reviewed by Darin Fisher.
3474
3475         [Chromium] Update chromium archive test result url in rebaseline script.
3476
3477         https://bugs.webkit.org/show_bug.cgi?id=51503
3478
3479         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3480
3481 2010-12-22  Lucas Forschler  <lforschler@apple.com>
3482
3483         Reviewed by Alice Liu.
3484
3485         <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
3486         Verified on Chrome, Safari, and IE.
3487         With this change, we will record memory from a parent browser window and all child processes.
3488
3489         * record-memory-win/main.cpp:
3490         (ProcessArgs):
3491         (PrintUsage):
3492         (getMemoryInfo):
3493         (printProcessInfo):
3494         (evalProcesses):
3495         (UseImage):
3496         (QueryContinuously):
3497         (ElapsedTime):
3498
3499 2010-12-22  Lucas Forschler  <lforschler@apple.com>
3500
3501         Unreviewed rollout r74489, because it was missing changelog.
3502
3503         * record-memory-win/main.cpp:
3504         
3505 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
3506
3507         Adding myself as a reviewer.
3508
3509         * Scripts/webkitpy/common/config/committers.py:
3510
3511 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
3512
3513         Unreviewed.  Adding myself to committers.py.
3514
3515         * Scripts/webkitpy/common/config/committers.py:
3516
3517 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
3518
3519         Reviewed by Kenneth Rohde Christiansen.
3520
3521         TestNetscapePlugIn should use #if defined
3522         https://bugs.webkit.org/show_bug.cgi?id=51471
3523
3524         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3525         (NP_Initialize):
3526         (NPP_New):
3527
3528 2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
3529
3530         Reviewed by Yury Semikhatsky.
3531
3532         Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
3533
3534         DevTools window should be closed explicitly because it has custom deinitialization code.
3535
3536         https://bugs.webkit.org/show_bug.cgi?id=50722
3537
3538         * DumpRenderTree/chromium/TestShell.cpp:
3539         (TestShell::closeRemainingWindows):
3540
3541 2010-12-22  David Levin  <levin@chromium.org>
3542
3543         Reviewed by Shinichiro Hamaji.
3544
3545         check-webkit-style shouldn't complaint about underscores in variables in objective C files.
3546         https://bugs.webkit.org/show_bug.cgi?id=51452
3547
3548         * Scripts/webkitpy/style/checkers/cpp.py:
3549         (_FileState.__init__): Added the information to determine if a file is C or Objective C.
3550         Using the file extension if possible but falling back to the file contents if we have a header file.
3551         (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
3552         (_FileState.is_c_or_objective_c):
3553         (check_using_std): Changed to using _FileState to determine the file type.
3554         (check_max_min_macros): Ditto.
3555         (check_for_null): Ditto.
3556         (check_style): Changed the parameters to various calls since they now need _FileState
3557         to determine the file type.
3558         (check_language): Added the file_state parameter so it could be passed
3559         to check_identifier_name_in_declaration.
3560         (check_identifier_name_in_declaration): Don't warn about underscores in variables if
3561         this is an Objective C file.
3562         (_process_lines): Added information for the _FileState constructor (and moved the
3563         call to a place that had the information).
3564         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3565         (CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
3566         its functionality.
3567         (WebKitStyleTest.test_names): Add tests for underscores in Objective C files.
3568
3569 2010-12-21  Andy Estes  <aestes@apple.com>
3570
3571         Reviewed by Mark Rowe.
3572
3573         Do not build non-Intel architectures for WebKit2-related projects.
3574         https://bugs.webkit.org/show_bug.cgi?id=51440
3575
3576         * MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64.
3577         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
3578         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
3579
3580 2010-12-21  Mihai Parparita  <mihaip@chromium.org>
3581
3582         Reviewed by Darin Fisher.
3583
3584         [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
3585         https://bugs.webkit.org/show_bug.cgi?id=51406 
3586         
3587         Rename WebThemeControlDRT to WebThemeControlDRTWin and WebThemeEngineDRT
3588         to WebThemeEngineDRTWin and update references everywhere.
3589
3590         * DumpRenderTree/DumpRenderTree.gypi:
3591         * DumpRenderTree/chromium/TestShellWin.cpp:
3592         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.cpp.
3593         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.h.
3594         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp.
3595         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.h.
3596
3597 2010-12-21  Anders Carlsson  <andersca@apple.com>
3598
3599         Reviewed by John Sullivan.
3600
3601         Clicking missing plug-in text does not show a sheet
3602         https://bugs.webkit.org/show_bug.cgi?id=51403
3603
3604         Update for changes to the WebPageUIClient.
3605
3606         * MiniBrowser/mac/BrowserWindowController.m:
3607         (-[BrowserWindowController awakeFromNib]):
3608         * WebKitTestRunner/TestController.cpp:
3609         (WTR::createOtherPage):
3610         (WTR::TestController::initialize):
3611
3612 2010-12-21  Eric Seidel  <eric@webkit.org>
3613
3614         Reviewed by Adam Barth.
3615
3616         commit-queue will report constant failures as flaky if other tests flake
3617         https://bugs.webkit.org/show_bug.cgi?id=51272
3618
3619         This patch just removes functionality and adds testing.
3620         Previously we attempted to report flaky tests when we had
3621         two different tests fail in a row.  However, since we stop
3622         running the tests at the first failure, our code was wrong in
3623         trying to determine flakiness from the incomplete runs.
3624
3625         Originally I posted an alternate patch:
3626         https://bug-51272-attachments.webkit.org/attachment.cgi?id=77078
3627         which fixed our flaky logic in this case, however it was decided
3628         that that patch would be too difficult to maintain, so now
3629         I'm just removing the broken logic.
3630
3631         This will dramatically cut-down on our flaky-test false positives
3632         at the (small) cost of the queues being unable to report
3633         any flakiness if the tree is very flaky.  (With at least one test
3634         flaking on every run, we'll never report failures anymore.)  I think
3635         this is a tradeoff worth making.
3636
3637         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3638         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3639
3640 2010-12-20  Eric Seidel  <eric@webkit.org>
3641
3642         Reviewed by Adam Barth.
3643
3644         commit-queue wrongly rejects patches when it can't update itself
3645         https://bugs.webkit.org/show_bug.cgi?id=46636
3646
3647         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3648         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3649         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3650
3651 2010-12-20  Adam Barth  <abarth@webkit.org>
3652
3653         Move web sites to Websites directory
3654         https://bugs.webkit.org/show_bug.cgi?id=51323
3655
3656         Update references to BugsSite to point to the new location.
3657
3658         This patch was never officially reviewed (because it was too large to
3659         upload to bugs.webkit.org), but it was discussed on webkit-dev and Mark
3660         Rowe gave me the green light.
3661
3662         * Scripts/old-run-webkit-tests:
3663         * Scripts/webkitpy/common/config/build.py:
3664         * Scripts/webkitpy/common/config/build_unittest.py:
3665         * Scripts/webkitpy/common/prettypatch.py:
3666         * Scripts/webkitpy/layout_tests/port/base.py:
3667         * Scripts/webkitpy/style/main.py:
3668
3669 2010-12-20  Adrienne Walker  <enne@google.com>
3670
3671         Unreviewed. Adding myself to the list of committers.
3672
3673         * webkitpy/common/config/committers.py:
3674
3675 2010-12-20  Mark Rowe  <mrowe@apple.com>
3676
3677         Reviewed by Dan Bernstein.
3678
3679         <rdar://problem/8757601> Don't install header files in to the Resources directory.
3680
3681         * Scripts/check-for-inappropriate-files-in-framework: Don't allow .h files in the
3682         Resources directory.
3683
3684 2010-12-20  Eric Seidel  <eric@webkit.org>
3685
3686         Reviewed by Adam Barth.
3687
3688         commit-queue should include bot id when attaching failure diffs
3689         https://bugs.webkit.org/show_bug.cgi?id=51280
3690
3691         This is a tiny change to include the bot id in the name of the attachment.
3692         Most of this diff is just changing the unit test expectations
3693         now that I hid the comment printing when the comment is None.
3694
3695         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3696         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3697         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3698         * Scripts/webkitpy/tool/mocktool.py:
3699
3700 2010-12-20  Jeff Miller  <jeffm@apple.com>
3701
3702         Reviewed by Dan Bernstein.
3703
3704         Tools/vcbin/midl.exe needs to be rebuilt
3705         https://bugs.webkit.org/show_bug.cgi?id=51347
3706
3707         * vcbin/midl.exe: Rebuilt.
3708
3709 2010-12-20  David Levin  <levin@chromium.org>
3710
3711         Reviewed by Ariya Hidayat.
3712
3713         .gitignore and webkit-tools-completion.sh have references to WebKitTools that should be Tools.
3714         https://bugs.webkit.org/show_bug.cgi?id=51343
3715
3716         Follow up from the WebKitTools -> Tools rename.
3717
3718         * Scripts/webkit-tools-completion.sh:
3719
3720 2010-12-20  Cosmin Truta  <ctruta@chromium.org>
3721
3722         Reviewed by James Robinson.
3723
3724         new-run-webkit-tests ignores trailing EOL differences in text tests
3725         https://bugs.webkit.org/show_bug.cgi?id=36983
3726
3727         Changed the handling of new-line characters within new-run-webkit-tests
3728         to match old-run-webkit-tests.  Differences in leading and trailing empty
3729         lines in text expectation files are no longer ignored.
3730
3731         * Scripts/webkitpy/layout_tests/port/base.py:
3732         * Scripts/webkitpy/layout_tests/port/test.py:
3733         Added unit tests.  Removed old duplicate unit test entries.
3734         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3735
3736 2010-12-20  David Levin  <levin@chromium.org>
3737
3738         Reviewed by Shinichiro Hamaji.
3739
3740         check-webkit-style should detect function declarations (and trivial functions).
3741         https://bugs.webkit.org/show_bug.cgi?id=51303
3742
3743         * Scripts/webkitpy/style/checkers/cpp.py:
3744         (_FunctionState.begin): Add is_declaration and changed the line count
3745         start to begin at -1 (which will keep the results consistent, since
3746         the starting line number passed in is one less in this change).
3747         (detect_functions): changed function detection to now catch trivial
3748         functions and declarations.
3749         (check_pass_ptr_usage): Don't check for Pass*Ptr on the first line
3750         of the function as this may look at return values (when processing
3751         a declaration).
3752         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3753         (FunctionDetectionTest.perform_function_detection): Basic mechanics
3754         of testing the function detection.
3755         (FunctionDetectionTest.test_basic_function_detection): Test a simple
3756         function.
3757         (FunctionDetectionTest.test_function_declaration_detection): Test a
3758         declaration.
3759         (FunctionDetectionTest.test_non_functions): A test case for a case
3760         that caused the code to fail due to the { being in quotes.
3761         (PassPtrTest.test_pass_ref_ptr_return_value): Added some more test
3762         cases to help catch false alarms for return values.
3763         (PassPtrTest.test_pass_ref_ptr_member_variable): Ensure that
3764         we don't get false alarms for member variables either.
3765
3766 2010-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
3767
3768         Reviewed by Antonio Gomes.
3769
3770         [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR
3771         https://bugs.webkit.org/show_bug.cgi?id=51319
3772
3773         * CMakeListsEfl.txt:
3774
3775 2010-12-18  Adam Barth  <abarth@webkit.org>
3776
3777         Reviewed by Sam Weinig.
3778
3779         Move WebKitExamplePlugins to Examples
3780         https://bugs.webkit.org/show_bug.cgi?id=51291
3781
3782         * Scripts/webkitpy/common/config/build.py:
3783
3784 2010-12-17  Csaba Osztrogonác  <ossy@webkit.org>
3785
3786         Unreviewed Qt buildfix after r74301.
3787
3788         Rename WebKitTools to Tools
3789         https://bugs.webkit.org/show_bug.cgi?id=49861
3790
3791         * MiniBrowser/DerivedSources.pro:
3792         * MiniBrowser/qt/MiniBrowser.pro:
3793
3794 2010-12-17  Dan Bernstein  <mitz@apple.com>
3795
3796         Reviewed by Simon Fraser.
3797
3798         Rename WebKitTools to Tools
3799         https://bugs.webkit.org/show_bug.cgi?id=49861
3800
3801         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3802         * CodeCoverage/README:
3803         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3804         (WebCore::DumpRenderTree::initializeFonts):
3805         * EWSTools/start-commit-queue.sh:
3806         * EWSTools/start-queue.sh:
3807         * GNUmakefile.am:
3808         * MIDLWrapper/MIDLWrapper.cpp:
3809         (wmain):
3810         * MiniBrowser/qt/MiniBrowser.pro:
3811         * Scripts/build-api-tests:
3812         * Scripts/build-dumprendertree:
3813         * Scripts/build-webkit:
3814         * Scripts/build-webkittestrunner:
3815         * Scripts/generate-coverage-data:
3816         * Scripts/old-run-webkit-tests:
3817         * Scripts/run-api-tests:
3818         * Scripts/run-iexploder-tests:
3819         * Scripts/run-javascriptcore-tests:
3820         * Scripts/run-mangleme-tests:
3821         * Scripts/run-sunspider:
3822         * Scripts/run-webkit-websocketserver:
3823         * Scripts/sunspider-compare-results:
3824         * Scripts/test-webkitperl:
3825         * Scripts/test-webkitpy:
3826         * Scripts/update-iexploder-cssproperties:
3827         * Scripts/update-webkit:
3828         * Scripts/update-webkit-localizable-strings:
3829         * Scripts/webkitdirs.pm:
3830         * Scripts/webkitpy/common/checkout/scm.py:
3831         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3832         * Scripts/webkitpy/common/config/committervalidator.py:
3833         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
3834         * Scripts/webkitpy/common/config/ports.py:
3835         * Scripts/webkitpy/common/config/ports_unittest.py:
3836         * Scripts/webkitpy/common/system/logutils_unittest.py:
3837         * Scripts/webkitpy/common/system/ospath_unittest.py:
3838         * Scripts/webkitpy/layout_tests/port/chromium.py:
3839         * Scripts/webkitpy/layout_tests/port/config.py:
3840         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3841         * Scripts/webkitpy/layout_tests/port/http_server.py:
3842         * Scripts/webkitpy/layout_tests/port/test.py:
3843         * Scripts/webkitpy/style/checker.py:
3844         * Scripts/webkitpy/style/checker_unittest.py:
3845         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3846         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3847         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3848         * WebKitTestRunner/DerivedSources.pro:
3849         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3850         (WTR::activateFonts):
3851         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3852         * wx/build/build_utils.py:
3853
3854 2010-12-16  Antonio Gomes  <agomes@rim.com>
3855
3856         Reviewed by Martin Robinson.
3857
3858         Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
3859         https://bugs.webkit.org/show_bug.cgi?id=51163
3860
3861         Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
3862         GTK+'s DRT should also reset to UNIX after each test execution.
3863
3864         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3865         (resetDefaultsToConsistentValues):
3866
3867 2010-12-17  David Levin  <levin@chromium.org>
3868
3869         Reviewed by Eric Seidel.
3870
3871         check-webkit-style should understand WTF #include guards
3872         https://bugs.webkit.org/show_bug.cgi?id=44911
3873
3874         * Scripts/webkitpy/style/checkers/cpp.py:
3875         (get_header_guard_cpp_variable): modify to suggest the WTF style
3876         of header guard when appropriate.
3877         (check_for_header_guard): handle multiple return values from
3878         get_header_guard_cpp_variable
3879         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3880         (CppStyleTest.test_build_header_guard): Added tests for the WTF
3881         header style.
3882
3883 2010-12-16  David Levin  <levin@chromium.org>
3884
3885         Reviewed by Eric Seidel.
3886
3887         test-webkitpy: unittest for the xml.py checker displays a decprecation warning.
3888         https://bugs.webkit.org/show_bug.cgi?id=51210
3889
3890         The error only shows up when using python 2.6 or later.
3891
3892         * Scripts/webkitpy/style/checkers/xml.py: Replace the usage of
3893         the decprecated field error,message with something equivalent.
3894
3895 2010-12-16  Mihai Parparita  <mihaip@chromium.org>
3896
3897         Reviewed by Eric Seidel.
3898
3899         Add --exit-after-n-failures/crashes to NRWT
3900         https://bugs.webkit.org/show_bug.cgi?id=51160
3901         
3902         Abort test run (in a similar way to how control-C is handled) when
3903         --exit-after-n-failures/crashes-or-timeouts are passed and we've reached
3904         that number of unexpected failures/crashes/timeouts.
3905
3906         * Scripts/webkitpy/layout_tests/port/test.py:
3907         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3908         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3909
3910 2010-12-16  David Levin  <levin@chromium.org>
3911
3912         Reviewed by Shinichiro Hamaji.
3913
3914         check-webkit-style unit tests has some duplicate boilerplate code.
3915         https://bugs.webkit.org/show_bug.cgi?id=49519
3916
3917         * Scripts/webkitpy/style/checkers/cpp.py:
3918         (update_include_state): Replaced the "io" parameter with the global
3919         configuration _unit_test_config. This allowed not calling into
3920         functions at a low level and also not plumbing through the injection
3921         information through many levels of code.
3922         (check_for_include_what_you_use): Ditto.
3923         (process_file_data): Added the ability to set up the unit test config
3924         to allow for injection.
3925         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3926         (ErrorCollector.__init__): Added support for having a filter for errors.
3927         (ErrorCollector.__call__): Ditto.
3928         (CppStyleTestBase.process_file_data): Added the ability to set unit_test_config.
3929         (CppStyleTestBase.perform_lint): Consolidated logic for the perform functions.
3930         (CppStyleTestBase.perform_single_line_lint): Replace specific calls to
3931         functions in the cpp.py with generic processing and a filter that
3932         indicates what errors should be kept.
3933         (CppStyleTestBase.perform_multi_line_lint): Ditto.
3934         (CppStyleTestBase.perform_language_rules_check): Ditto.
3935         (CppStyleTestBase.perform_function_lengths_check): Ditto.
3936         (CppStyleTestBase.perform_pass_ptr_check): Ditto.
3937         (CppStyleTestBase.perform_include_what_you_use): Ditto.
3938         (CppStyleTest.test_multi_line_comments): Added another
3939         error message which applies to the test case.
3940         (CppStyleTest.test_spacing_for_binary_ops): Fixed test
3941         to not have config.h, since it is processed as a header file.
3942         (CppStyleTest.test_static_or_global_stlstrings): Fixed variable name
3943         style and indentation in checked code.
3944         (OrderOfIncludesTest.test_check_preprocessor_in_include_section):
3945         Fixed line number.
3946         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
3947         Ditto.
3948
3949 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
3950
3951         Unreviewed, rolling out r74136.
3952         http://trac.webkit.org/changeset/74136
3953         https://bugs.webkit.org/show_bug.cgi?id=51135
3954
3955         r74136 breaks chromium canary bots because some tests are not
3956         rebaselined correctly to resolve EOL differences (Requested by
3957         jianli on #webkit).
3958
3959         * Scripts/webkitpy/layout_tests/port/base.py:
3960         * Scripts/webkitpy/layout_tests/port/test.py:
3961         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3962
3963 2010-12-15  Adam Roben  <aroben@apple.com>
3964
3965         Teach check-webkit-style to check .vcproj and .vsprops files for XML
3966         syntax errors
3967
3968         Fixes <http://webkit.org/b/51103> check-webkit-style should check for
3969         XML syntax errors in .vcproj/.vsprops files
3970
3971         Reviewed by Dave Levin.
3972
3973         * Scripts/webkitpy/style/checker.py: Added lists of file extensions
3974         that should be treated as XML and that should be allowed to contain
3975         carriage returns. (These lists happen to be identical currently.)
3976         (FileType): Added a new XML type.
3977         (CheckerDispatcher.should_check_and_strip_carriage_returns): Added.
3978         Just does a simple file extension check.
3979         (CheckerDispatcher._file_type): Added a case for XML files.
3980         (CheckerDispatcher._create_checker): Ditto. We use XMLChecker for XML
3981         files (surprise!).
3982         (StyleProcessor.process): Ask the dispatcher whether we should pass the
3983         lines through the carriage checker.
3984
3985         * Scripts/webkitpy/style/checker_unittest.py:
3986         (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
3987         Added. Checks a few file names to see if carriage returns are allowed
3988         or not.
3989         (CheckerDispatcherDispatchTest.assert_checker_xml): Added. Similar to
3990         other assert_checker_* functions.
3991         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
3992         test_*_paths functions.
3993         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
3994         test_*_paths functions.
3995         (CheckerDispatcherDispatchTest.test_none_paths): Removed the vcproj
3996         file from this test case, as vcproj files now have a type.
3997         (StyleProcessor_CodeCoverageTest.MockDispatcher.should_check_and_strip_carriage_returns):
3998         Added. Similar to the other should_* functions.
3999         (StyleProcessor_CodeCoverageTest.test_process__carriage_returns_not_stripped):
4000         Added. Checks that carriage returns aren't checked for or stripped for
4001         allowed files.
4002
4003         * Scripts/webkitpy/style/checkers/xml.py: Added.
4004         (XMLChecker.__init__): Simple init method.
4005         (XMLChecker.check): Pass each line through the expat parser, and record
4006         a style error for any errors thrown by the parser.
4007
4008         * Scripts/webkitpy/style/checkers/xml_unittest.py: Added.
4009         (XMLCheckerTest.assert_no_error): Checks that the given XML does not
4010         produce a style error.
4011         (XMLCheckerTest.assert_error): Checks that the given XML produces an
4012         error of the given category on the given line.
4013         (XMLCheckerTest.mock_handle_style_error): Does nothing. Used for
4014         checking that the XMLChecker constructor works properly.
4015         (XMLCheckerTest.test_conflict_marker): Tests that conflict markers
4016         cause a style error (see, e.g., r73887).
4017         (XMLCheckerTest.test_extra_closing_tag): Tests that extra closing tags
4018         cause a style error (see, e.g., r73773).
4019         (XMLCheckerTest.test_init): Tests that the XMLChecker constructor works
4020         properly.
4021         (XMLCheckerTest.test_missing_closing_tag): Tests that missing closing
4022         tags cause a style error (see, e.g., r72795).
4023         (XMLCheckerTest.test_no_error): Tests that valid XML does not cause a
4024         style error.
4025
4026 2010-12-15  Lucas Forschler  <lforschler@apple.com>
4027
4028         Reviewed by Stephanie Lewis.
4029
4030         https://bugs.webkit.org/show_bug.cgi?id=51117
4031         Add a new leopard test bot
4032         really really commit to trunk this time.
4033
4034         * BuildSlaveSupport/build.webkit.org-config/config.json:
4035
4036 2010-12-15  Sam Weinig  <sam@webkit.org>
4037
4038         Reviewed by Anders Carlsson.
4039
4040         WebKit2: Can't add files to an <input type=file>
4041         https://bugs.webkit.org/show_bug.cgi?id=51087
4042
4043         * MiniBrowser/mac/BrowserWindowController.m:
4044         (runOpenPanel):
4045         (-[BrowserWindowController awakeFromNib]):
4046         Add simple implementation of runOpenPanel callback.
4047
4048         * MiniBrowser/win/BrowserView.cpp:
4049         (BrowserView::create):
4050         * WebKitTestRunner/TestController.cpp:
4051         (WTR::createOtherPage):
4052         (WTR::TestController::initialize):
4053         Stub out runOpenPanel callback. 
4054
4055 2010-12-14  Eric Seidel  <eric@webkit.org>
4056
4057         Reviewed by Adam Barth.
4058
4059         commit-queue should upload failure diffs when tests flake
4060         https://bugs.webkit.org/show_bug.cgi?id=51051
4061
4062         To make this testable I needed to pipe FileSystem down onto tool.
4063         We've wanted it there for a long time anyway.
4064
4065         This patch is kinda a big hack.  But we don't have a nice
4066         way to read results.html files.  I think this will need further
4067         revision before this code actually feels clean.
4068
4069         As part of testing this change, I had to make MockBugzilla.create_bug
4070         actually return an id (like it should) which required updating
4071         a few other unit test results (for the better).
4072
4073         The results_matching_keys change in layouttestresults/rebasline
4074         was an alternate path which I decided not to use in the end, but
4075         I left the change as it seemed an improvement.
4076
4077         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
4078         * Scripts/webkitpy/common/net/layouttestresults.py:
4079         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
4080         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
4081         * Scripts/webkitpy/tool/commands/queues.py:
4082         * Scripts/webkitpy/tool/commands/rebaseline.py:
4083         * Scripts/webkitpy/tool/main.py:
4084         * Scripts/webkitpy/tool/mocktool.py:
4085
4086 2010-12-15  Cosmin Truta  <ctruta@chromium.org>
4087
4088         Reviewed by James Robinson.
4089
4090         new-run-webkit-tests ignores trailing EOL differences in text tests
4091         https://bugs.webkit.org/show_bug.cgi?id=36983
4092
4093         Changed the handling of new-line characters within new-run-webkit-tests
4094         to match old-run-webkit-tests.  Differences in leading and trailing empty
4095         lines in text expectation files are no longer ignored.
4096
4097         * Scripts/webkitpy/layout_tests/port/base.py:
4098         * Scripts/webkitpy/layout_tests/port/test.py:
4099         Added unit tests.  Removed old duplicate unit test entries.
4100         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
4101
4102 2010-12-15  Ojan Vafai  <ojan@chromium.org>
4103
4104         Reviewed by Adam Barth.
4105
4106         make status-bubble white-space:nowrap so we can measure it's width without wrapping
4107         https://bugs.webkit.org/show_bug.cgi?id=51149
4108
4109         * QueueStatusServer/templates/statusbubble.html:
4110
4111 2010-12-15  Ojan Vafai  <ojan@chromium.org>
4112
4113         Reviewed by Adam Barth.
4114
4115         have the statusbubble postMessage it's metrics so that embedders can properly size the iframe
4116         https://bugs.webkit.org/show_bug.cgi?id=51125
4117
4118         * QueueStatusServer/templates/statusbubble.html:
4119
4120 2010-12-15  Darin Adler  <darin@apple.com>
4121
4122         * Scripts/webkitpy/common/net/buildbot: Added property svn:ignore.
4123
4124 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
4125
4126         Unreviewed, rolling out r74117.
4127         http://trac.webkit.org/changeset/74117
4128         https://bugs.webkit.org/show_bug.cgi?id=51113
4129
4130         This broke the GTK1 build. (Requested by mrobinson on
4131         #webkit).
4132
4133         * Scripts/webkitdirs.pm:
4134
4135 2010-12-15  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>
4136
4137         Reviewed by Martin Robinson.
4138
4139         Change generate-forwarding-headers.pl for GTK port usage 
4140         (https://bugs.webkit.org/show_bug.cgi?id=37369)
4141
4142         * Scripts/webkitdirs.pm: Added changes to build webkit2 for GTK port using build-webkit script.
4143
4144 2010-12-14  Kent Tamura  <tkent@chromium.org>
4145
4146         Reviewed by Jian Li.
4147
4148         [DRT/Chromium] Remove another unnecessary error message
4149         https://bugs.webkit.org/show_bug.cgi?id=51083
4150
4151         * DumpRenderTree/chromium/WebViewHost.cpp:
4152         (WebViewHost::didInvalidateRect):
4153
4154 2010-12-14  Lucas Forschler  <lforschler@apple.com>
4155
4156         Reviewed by Stephanie Lewis.
4157
4158         Add a new Leopard Debug Test WK2 Bot
4159
4160         * BuildSlaveSupport/build.webkit.org-config/config.json:
4161
4162 2010-12-14  Ojan Vafai  <ojan@chromium.org>
4163
4164         Fix python unittests after http://trac.webkit.org/changeset/74070.
4165
4166         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
4167
4168 2010-12-14  Kent Tamura  <tkent@chromium.org>
4169
4170         Reviewed by Jian Li.
4171
4172         [DRT/Chromium] Remove a unnecessary error message
4173         https://bugs.webkit.org/show_bug.cgi?id=51069
4174
4175         * DumpRenderTree/chromium/WebViewHost.cpp:
4176         (WebViewHost::paintInvalidatedRegion):
4177
4178 2010-12-14  Benjamin Kalman  <kalman@chromium.org>
4179
4180         Reviewed by Ojan Vafai.
4181
4182         Using BUG/BUGWK in test_expectations is error prone, should use BUGCR/BUGWK
4183         https://bugs.webkit.org/show_bug.cgi?id=48926
4184
4185         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
4186         Add presubmit check that BUG isn't used, either BUGCR/BUGWK/BUGV8_.
4187
4188 2010-12-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
4189
4190         Reviewed by Eric Seidel.
4191
4192         [Qt] [Symbian] Do not use pkg-config on Symbian as it is not supported
4193         https://bugs.webkit.org/show_bug.cgi?id=50231
4194
4195         Guard CONFIG+=link_pkgconfig with !symbian.
4196
4197         * DumpRenderTree/qt/DumpRenderTree.pro:
4198         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
4199         * WebKitTestRunner/qt/WebKitTestRunner.pro:
4200
4201 2010-12-14  Philippe Normand  <pnormand@igalia.com>
4202
4203         Reviewed by Ojan Vafai.
4204
4205         [new-run-webkit-tests] expectations parsing is slow
4206         https://bugs.webkit.org/show_bug.cgi?id=50635
4207
4208         Avoid expensive iteration of all the tests when checking if a test
4209         file is to be skipped or not.
4210
4211         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
4212         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
4213         * Scripts/webkitpy/layout_tests/port/test.py:
4214
4215 2010-12-14  Mario Sanchez Prada  <msanchez@igalia.com>
4216
4217         Reviewed by Xan Lopez.
4218
4219         [Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding events for text objects
4220         https://bugs.webkit.org/show_bug.cgi?id=27048
4221
4222         Add support in DRT for checking whether an accessibility UI
4223         element is focusable and/or focused. Implemented for GTK.
4224
4225         * DumpRenderTree/AccessibilityUIElement.cpp:
4226         (getIsFocusedCallback): New.
4227         (getIsFocusableCallback): New.
4228         (AccessibilityUIElement::getJSClass): Add the new available
4229         callbacks for isFocused and isFocusable.
4230         * DumpRenderTree/AccessibilityUIElement.h:
4231         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
4232         (AccessibilityUIElement::isFocused): New, implemented by checking
4233         whether the related AtkState value is in the object's state set.
4234         (AccessibilityUIElement::isFocusable): Ditto.
4235         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
4236         (AccessibilityUIElement::isFocused): New, dummy implementation.
4237         (AccessibilityUIElement::isFocusable): Ditto.
4238         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
4239         (AccessibilityUIElement::isFocused): Ditto.
4240         (AccessibilityUIElement::isFocusable): Ditto.
4241
4242 2010-12-14  Eric Seidel  <eric@webkit.org>
4243
4244         Reviewed by Ojan Vafai.
4245
4246         webkit-patch should warn users when they're using a 32-bit git on a 64-bit system
4247         https://bugs.webkit.org/show_bug.cgi?id=50715
4248
4249         This patch makes webkit-patch print the following:
4250
4251         Warning: This machine is 64-bit, but the git binary (/usr/local/git/bin/git) does not support 64-bit.
4252         Install a 64-bit git for better performance, see:
4253         https://lists.webkit.org/pipermail/webkit-dev/2010-December/015249.html
4254
4255         I wrote this mostly because I have approximately 8 machines that I use
4256         and making sure each one is using a good Git install seemed folly.
4257         webkit-patch makes a lot of git calls, so using a fast git can shave
4258         several seconds in every invocation.  See the webkit-dev thread for more info.
4259
4260         This message will print twice during 'webkit-patch upload',
4261         once from webkit-patch and once from check-webkit-style.
4262
4263         Unfortunately there is no good way to test this due to how machine-dependent
4264         the code is.  I considered writing a test for the log message, but it seemed not worth it.
4265
4266         * Scripts/webkitpy/common/checkout/scm.py:
4267
4268 2010-12-13  Eric Seidel  <eric@webkit.org>
4269
4270         Reviewed by Adam Barth.
4271
4272         FlakyTestReporter doesn't understand bots running from multiple email addresses
4273         https://bugs.webkit.org/show_bug.cgi?id=50960
4274
4275         This explains at least one of the dupes of:
4276         https://bugs.webkit.org/show_bug.cgi?id=50863
4277         that we saw filed by the commit-queue this morning.
4278         I think the other one was explained by my previous fix to result counting code.
4279
4280         Since this is really hard to test with a unit test, instead I
4281         create a new (possibly useful in the future) command
4282         which given a layout test path will return you
4283         the one bug which our tools would assume it the flaky test bug.
4284         If some other script wants to use bug-for-test we'll
4285         need to extend it with some options like --create-if-missing or similar.
4286
4287         * Scripts/webkitpy/common/net/bugzilla/bug.py:
4288         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
4289         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
4290         * Scripts/webkitpy/tool/commands/__init__.py:
4291         * Scripts/webkitpy/tool/commands/bugfortest.py: Added.
4292
4293 2010-12-13  Mihai Parparita  <mihaip@chromium.org>
4294
4295         Reviewed by James Robinson.
4296
4297         Add option to build-webkit to not build WebKit2
4298         https://bugs.webkit.org/show_bug.cgi?id=50988
4299         
4300         Add support for a --no-webkit2 option to build-webkit. It seems to save
4301         ~1 minute from clean builds and ~10 seconds from no-op builds.
4302
4303         * Scripts/build-webkit:
4304
4305 2010-12-13  Lucas Forschler  <lforschler@apple.com>
4306
4307         Reviewed by Dave Kilzer.
4308
4309         Update iexploder from 1.3.2 to 1.7.2
4310         Move 1.3.2 into its own subdir
4311         Add 1.7.2 into its own subdir
4312         update scripts to point to new 1.3.2 location (avoid breaking existing scripts)
4313
4314         * Scripts/run-iexploder-tests:
4315         * Scripts/update-iexploder-cssproperties:
4316         * iExploder/CHANGELOG.txt: Removed.
4317         * iExploder/LICENSE.txt: Removed.
4318         * iExploder/README.txt: Removed.
4319         * iExploder/htdocs: Removed.
4320         * iExploder/iexploder-1.3.2: Added.
4321         * iExploder/iexploder-1.3.2/CHANGELOG.txt: Copied from iExploder/CHANGELOG.txt.
4322         * iExploder/iexploder-1.3.2/LICENSE.txt: Copied from iExploder/LICENSE.txt.
4323         * iExploder/iexploder-1.3.2/README.txt: Copied from iExploder/README.txt.
4324         * iExploder/iexploder-1.3.2/htdocs: Added.
4325         * iExploder/iexploder-1.3.2/htdocs/config.rb: Copied from iExploder/htdocs/config.rb.
4326         * iExploder/iexploder-1.3.2/htdocs/cssproperties.in: Copied from iExploder/htdocs/cssproperties.in.
4327         * iExploder/iexploder-1.3.2/htdocs/cssvalues.in: Copied from iExploder/htdocs/cssvalues.in.
4328         * iExploder/iexploder-1.3.2/htdocs/htmlattrs.in: Copied from iExploder/htdocs/htmlattrs.in.
4329         * iExploder/iexploder-1.3.2/htdocs/htmltags.in: Copied from iExploder/htdocs/htmltags.in.
4330         * iExploder/iexploder-1.3.2/htdocs/htmlvalues.in: Copied from iExploder/htdocs/htmlvalues.in.
4331         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi: Copied from iExploder/htdocs/iexploder.cgi.
4332         * iExploder/iexploder-1.3.2/htdocs/iexploder.rb: Copied from iExploder/htdocs/iexploder.rb.
4333         * iExploder/iexploder-1.3.2/htdocs/index.html: Copied from iExploder/htdocs/index.html.
4334         * iExploder/iexploder-1.3.2/htdocs/webserver.rb: Copied from iExploder/htdocs/webserver.rb.
4335         * iExploder/iexploder-1.3.2/tools: Added.
4336         * iExploder/iexploder-1.3.2/tools/lasthit.rb: Copied from iExploder/tools/lasthit.rb.
4337         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb: Copied from iExploder/tools/osx_last_crash.rb.
4338         * iExploder/iexploder-1.3.2/tools/showtest.rb: Copied from iExploder/tools/showtest.rb.
4339         * iExploder/iexploder-1.7.2: Added.
4340         * iExploder/iexploder-1.7.2/ChangeLog.txt: Added.
4341         * iExploder/iexploder-1.7.2/LICENSE.txt: Added.
4342         * iExploder/iexploder-1.7.2/README.txt: Added.
4343         * iExploder/iexploder-1.7.2/output: Added.
4344         * iExploder/iexploder-1.7.2/src: Added.
4345         * iExploder/iexploder-1.7.2/src/browser_harness.rb: Added.
4346         * iExploder/iexploder-1.7.2/src/config.yaml: Added.
4347         * iExploder/iexploder-1.7.2/src/css-atrules: Added.
4348         * iExploder/iexploder-1.7.2/src/css-atrules/mozilla: Added.
4349         * iExploder/iexploder-1.7.2/src/css-atrules/webkit: Added.
4350         * iExploder/iexploder-1.7.2/src/css-properties: Added.
4351         * iExploder/iexploder-1.7.2/src/css-properties/dillo: Added.
4352         * iExploder/ie