2c8c67640eebe0dc9e2c77d2a02698e262247098
[WebKit-https.git] / Tools / ChangeLog
1 2013-07-31  Roger Fong  <roger_fong@apple.com>
2
3         Unreviewed. Re-enable WinEWS tests following r153527.
4
5         * Scripts/webkitpy/common/config/ews.json:
6
7 2013-07-31  Bem Jones-Bey  <bjonesbe@adobe.com>
8
9         Unreviewed: Adding myself to the committers' list.
10
11         * Scripts/webkitpy/common/config/contributors.json:
12
13 2013-07-31  Allan Sandfeld Jensen  <allan.jensen@digia.com>
14
15         [Qt] Build WebKit with C++11
16         https://bugs.webkit.org/show_bug.cgi?id=119337
17
18         Reviewed by Csaba Osztrogonác.
19
20         Enable building with C++11.
21
22         * qmake/mkspecs/features/default_pre.prf:
23         * qmake/mkspecs/features/unix/default_post.prf:
24         * qmake/mkspecs/features/unix/default_pre.prf:
25
26 2013-07-31  Allan Sandfeld Jensen  <allan.jensen@digia.com>
27
28         [Qt] ASSERTS trigger in release builds
29         https://bugs.webkit.org/show_bug.cgi?id=119336
30
31         Reviewed by Jocelyn Turcotte.
32
33         Ensure the qmake also defaults to release if no configuration is known.
34
35         * qmake/mkspecs/features/default_post.prf:
36
37 2013-07-31  Zan Dobersek  <zdobersek@igalia.com>
38
39         [texmap][GStreamer][GTK] composited video shows tearing
40         https://bugs.webkit.org/show_bug.cgi?id=118253
41
42         Reviewed by Martin Robinson.
43
44         * gtk/jhbuild.modules: Bump the Jhbuild versions of the Gdk-Pixbuf and GTK+ packages to 2.27.3 and 3.8.2, respectively.
45         The first is required by the second, and the GTK+ bump introduces proper display framerate synchronization that removes
46         screen tearing when enabling accelerated compositing and performing graphically heavy operations like viewing HD videos.
47
48 2013-07-30  Ruth Fong  <ruth_fong@apple.com>
49
50         Unreviewed: Adding myself to the committers' list.
51
52         * Scripts/webkitpy/common/config/contributors.json:
53
54 2013-07-30  Christophe Dumez  <ch.dumez@sisa.samsung.com>
55
56         Unreviewed, add my new email to contributors.json.
57
58         * Scripts/webkitpy/common/config/contributors.json:
59
60 2013-07-30  Krzysztof Czech  <k.czech@samsung.com>
61
62         [EFL] REGRESSION after r153439: layout tests do not run.
63         https://bugs.webkit.org/show_bug.cgi?id=119240
64
65         Reviewed by Christophe Dumez.
66
67         Changed attribute name from check_xvfb to check_driver.
68
69         * Scripts/webkitpy/port/efl.py:
70         (EflPort.check_sys_deps):
71
72 2013-07-29  Commit Queue  <commit-queue@webkit.org>
73
74         Unreviewed, rolling out r152860.
75         http://trac.webkit.org/changeset/152860
76         https://bugs.webkit.org/show_bug.cgi?id=119227
77
78         Disable WinEWS tests until tests stop crashing (Requested by
79         rfong on #webkit).
80
81         * Scripts/webkitpy/common/config/ews.json:
82
83 2013-07-29  Zan Dobersek  <zdobersek@igalia.com>
84
85         [GTK] Add WestonDriver, use it when appropriate
86         https://bugs.webkit.org/show_bug.cgi?id=119100
87
88         Reviewed by Dirk Pranke.
89
90         Introduce the WestonDriver, a Driver-implementing class that sets up an instance of Weston, the Wayland compositor,
91         and sets up an environment that enables the test runner to run inside it.
92
93         The design very much mimics the XvfbDriver class. It is currently used by the GTK port when the WAYLAND_DISPLAY
94         environment variable is set, that is when NRWT is being run under a Wayland display.
95
96         * Scripts/webkitpy/port/base.py:
97         (Port.to.setup_environ_for_server): Also copy the XDG_RUNTIME_DIR env from the original environment for Linux-using ports.
98         * Scripts/webkitpy/port/gtk.py:
99         (GtkPort):
100         (GtkPort._driver_class): Make the method memoized - the display type is not going to change during the testing, so we
101         should only check once for the presence of the WAYLAND_DISPLAY env and determine the proper driver class to use based on that.
102         (GtkPort.check_sys_deps): Call the static check_driver method on the class as returned by the _driver_class method
103         instead of hard-coding the XvfbDriver class in the check.
104         * Scripts/webkitpy/port/westondriver.py: Added.
105         (WestonDriver):
106         (WestonDriver.check_driver): Similarly to XvfbDriver, this checks for existance of the weston executable.
107         (WestonDriver.__init__): Again, like in XvfbDriver, we use a small delay between launching the Weston display and launching the driver.
108         (WestonDriver._start): Sets up the driver-specific temporary directory, launches the Weston display, sets up the environment for the
109         driver and then launches the driver in said environment, using the driver's Weston display.
110         (WestonDriver.stop): Cleans up the Weston instance and the temporary directory.
111         (WestonDriver._ensure_driver_tmpdir_subdirectory): A helper function that creates a subdirectory in the driver's temporary directory
112         and returns the absolute path to it.
113         * Scripts/webkitpy/port/xvfbdriver.py:
114         (XvfbDriver.check_driver): Renamed from check_xvfb.
115         (XvfbDriver._start): Access the FileSystem object through the Port's Host object, instead of the Port's private member.
116
117 2013-07-29  Mario Sanchez Prada  <mario.prada@samsung.com>
118
119         [ATK] Implement attributesOfChildren() for AccessibilityUIElement
120         https://bugs.webkit.org/show_bug.cgi?id=118967
121
122         Reviewed by Gustavo Noronha Silva.
123
124         Implemented AccessibilityUIElement::attributesOfChildren() both
125         in DumpRenderTree and the WebKitTestRunner.
126
127         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
128         (AccessibilityUIElement::attributesOfChildren): Implemented.
129
130         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
131         (WTR::AccessibilityUIElement::attributesOfChildren): Implemented.
132
133 2013-07-29  Mario Sanchez Prada  <mario.prada@samsung.com>
134
135         [ATK] Implement allAttributes() for AccessibilityUIElement
136         https://bugs.webkit.org/show_bug.cgi?id=118966
137
138         Reviewed by Gustavo Noronha Silva.
139
140         Implemented AccessibilityUIElement::allAttributes() both in
141         DumpRenderTree and the WebKitTestRunner.
142
143         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
144         (getAtkAttributeSetAsString): Moved up in the file, and refactored
145         to use StringBuilder and return a String instead of a gchar*.
146         (roleToString): Changed not to return the "AXRole: " prefix, so
147         we can use it as well from attributesOfElement().
148         (attributesOfElement): New function to dump attributes for an object.
149         (AccessibilityUIElement::allAttributes): Call attributesOfElement().
150         (AccessibilityUIElement::role): Updated to prefix "AXRole: ".
151
152         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
153         (getAtkAttributeSetAsString): Refactored to use StringBuilder and return
154         a String instead of a gchar*.
155
156         (WTF::roleToString): Changed not to return the "AXRole: " prefix,
157         so we can use it as well from attributesOfElement().
158         (WTF::attributesOfElement): New function to dump attributes for an object.
159         (WTR::AccessibilityUIElement::allAttributes): Call attributesOfElement().
160         (WTR::AccessibilityUIElement::role): Updated to prefix "AXRole: ".
161
162 2013-07-29  Daniel Bates  <dabates@apple.com>
163
164         Add support infrastructure for iOS WebKit port
165         https://bugs.webkit.org/show_bug.cgi?id=119168
166
167         Reviewed by Ryosuke Niwa.
168
169         Implement support infrastructure towards building iOS WebKit.
170
171         * Scripts/webkitdirs.pm:
172         (xcodeSDKPlatformName): Added.
173         (determineConfigurationProductDir):
174         (builtDylibPathForName):
175         (willUseIOSDeviceSDKWhenBuilding): Added.
176         (willUseIOSSimulatorSDKWhenBuilding): Added.
177         (isIOSWebKit): Added.
178         (copyInspectorFrontendFiles):
179
180 2013-07-29  Sergio Correia  <sergio.correia@openbossa.org>
181
182         CoordinatedGraphics: Add API to get and set the active state of a WebView
183         https://bugs.webkit.org/show_bug.cgi?id=119067
184
185         Reviewed by Noam Rosenthal.
186
187         Added API tests for WKViewIsActive and WKViewSetIsActive.
188
189         * TestWebKitAPI/PlatformEfl.cmake:
190         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp: Added.
191         (TestWebKitAPI::didFinishLoadForFrame):
192         (TestWebKitAPI::webProcessCrashed):
193         (TestWebKitAPI::webProcessRelaunched):
194         (TestWebKitAPI::TEST):
195         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive_Bundle.cpp:
196         Bundle added to allow crashing the WebProcess and testing the active state of a view
197         under such condition.
198         (TestWebKitAPI::WKViewIsActiveSetIsActiveTest::WKViewIsActiveSetIsActiveTest):
199         (TestWebKitAPI::WKViewIsActiveSetIsActiveTest::didReceiveMessage):
200
201 2013-07-29  Zan Dobersek  <zdobersek@igalia.com>
202
203         [Automake] Remove references to non-existent *_CFLAGS and *_LIBS variables
204         https://bugs.webkit.org/show_bug.cgi?id=119212
205
206         Reviewed by Carlos Garcia Campos.
207
208         * GNUmakefile.am: Remove references to GLOBALDEPS_(CFLAGS|LIBS) and CLUTTER_(CFLAGS|LIBS)
209         variables that are not defined during the configuration process.
210         * TestWebKitAPI/GNUmakefile.am: Ditto.
211         * WebKitTestRunner/GNUmakefile.am: Ditto.
212
213 2013-07-28  Andy Estes  <aestes@apple.com>
214
215         Include <stdio.h> to declare perror()
216         https://bugs.webkit.org/show_bug.cgi?id=119198
217
218         Reviewed by Andreas Kling.
219
220         Silences an implicit declaration warning.
221
222         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport.c:
223
224 2013-07-27  Ryuan Choi  <ryuan.choi@samsung.com>
225
226         [EFL] Bump required version of EFL to 1.7
227         https://bugs.webkit.org/show_bug.cgi?id=119144
228
229         Reviewed by Christophe Dumez.
230
231         * MiniBrowser/efl/CMakeLists.txt: Bumped EFL to 1.7
232
233 2013-07-26  Filip Pizlo  <fpizlo@apple.com>
234
235         WKTR should know about the JSC extensions to testRunner
236         https://bugs.webkit.org/show_bug.cgi?id=119154
237
238         Reviewed by Mark Hahnenberg and Geoffrey Garen.
239         
240         This makes some fast/js tests pass.
241
242         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
243         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
244         (WTR::TestRunner::numberOfDFGCompiles):
245         (WTR::TestRunner::neverInlineFunction):
246         * WebKitTestRunner/InjectedBundle/TestRunner.h:
247
248 2013-07-25  Mark Rowe  <mrowe@apple.com>
249
250         Fix build of DumpRenderTree and WebKitTestRunner when building against an SDK.
251
252         * DumpRenderTree/mac/Configurations/Base.xcconfig: Fix framework search path when building against an SDK.
253         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto. Also fix where our scripts look for WebCore.framework
254         so they pull the version out of the SDK.
255
256 2013-07-25  Anders Carlsson  <andersca@apple.com>
257
258         Localizable.strings generated by extract-localizable-strings should be UTF-8
259         https://bugs.webkit.org/show_bug.cgi?id=119106
260
261         Reviewed by Mark Rowe.
262
263         Output strings as UTF-8.
264
265         * Scripts/extract-localizable-strings:
266
267 2013-07-25  Sam Weinig  <sam@webkit.org>
268
269         -[WebHTMLView attributedSubstringForProposedRange:actualRange:] does not include strikethrough attribute in the returned attributed string
270         https://bugs.webkit.org/show_bug.cgi?id=119099
271         <rdar://problem/13439291>
272
273         Reviewed by Enrica Casucci.
274
275         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
276         * TestWebKitAPI/Tests/mac/AttributedString.mm:
277         (TestWebKitAPI::attributedString):
278         (TestWebKitAPI::AttributedStringTest_CustomFont::didLoadURL):
279         (TestWebKitAPI::AttributedStringTest_CustomFont::url):
280         (TestWebKitAPI::AttributedStringTest_CustomFont::runTest):
281         (TestWebKitAPI::TEST_F):
282         (TestWebKitAPI::AttributedStringTest_Strikethrough::didLoadURL):
283         (TestWebKitAPI::AttributedStringTest_Strikethrough::url):
284         (TestWebKitAPI::AttributedStringTest_Strikethrough::runTest):
285         * TestWebKitAPI/Tests/mac/attributedStringStrikethrough.html: Added.
286         Add tests for attributed strings with strikethrough.  Refactor the attributed string tests
287         to make adding more easier in the future.
288
289 2013-07-20  Filip Pizlo  <fpizlo@apple.com>
290
291         fourthTier: FTL should be able to generate LLVM IR that uses an intrinsic for OSR exit
292         https://bugs.webkit.org/show_bug.cgi?id=118948
293
294         Reviewed by Sam Weinig.
295         
296         - Make ReducedFTL capable of dealing with code that uses the fake OSR exit intrinsic,
297           by exporting it as a function.
298         
299         - Make combineModules.rb idempotent. Sometimes it's convenient to run a file through
300           it even if you know that you've already done so. See processIRDump.sh.
301         
302         - Add a script, processIRDump.sh, that takes the output of --dumpLLVMIR=true and
303           runs it through ReducedFTL automatically. You typically want to say something like:
304           
305           jsc --dumpLLVMIR=true <program(s)> > jsc-output.txt
306           ./processIRDump.sh --timing < jsc-output.txt
307
308         * ReducedFTL/ReducedFTL.c:
309         (webkit_osr_exit):
310         * ReducedFTL/combineModules.rb:
311         * ReducedFTL/processIRDump.sh: Added.
312
313 2013-07-20  Filip Pizlo  <fpizlo@apple.com>
314
315         fourthTier: We should use the no-asserts build of LLVM if that's what the user configured
316         https://bugs.webkit.org/show_bug.cgi?id=118947
317
318         Reviewed by Dan Bernstein.
319
320         * Scripts/copy-webkitlibraries-to-product-directory:
321
322 2013-07-16  Filip Pizlo  <fpizlo@apple.com>
323
324         fourthTier: We should have a reduced FTL LLVM pipeline tool in the repository
325         https://bugs.webkit.org/show_bug.cgi?id=118647
326
327         Rubber stamped by Geoffrey Garen and Mark Hahnenberg.
328
329         Add a tool that takes in an LLVM bitcode file and JITs it in exactly the same
330         way that the FTL would.
331         
332         Also add a tool that combines multiple LLVM modules generated by FTL into a
333         single module.
334
335         * ReducedFTL: Added.
336         * ReducedFTL/ReducedFTL.c: Added.
337         (usage):
338         (currentTime):
339         (MemorySection):
340         (mmAllocateCodeSection):
341         (mmAllocateDataSection):
342         (mmApplyPermissions):
343         (mmDestroy):
344         (symbolLookupCallback):
345         (main):
346         * ReducedFTL/build.sh: Added.
347         * ReducedFTL/combineModules.rb: Added.
348
349 2013-06-09  Filip Pizlo  <fpizlo@apple.com>
350
351         Unreviewed, fix minor goof in profiling output layout. We weren't accounting
352         for the "/" that is printed between engine counts.
353
354         * Scripts/display-profiler-output:
355
356 2013-05-28  Filip Pizlo  <fpizlo@apple.com>
357
358         testRunner should have a way of disabling inlining of functions
359         https://bugs.webkit.org/show_bug.cgi?id=116875
360
361         Reviewed by Mark Hahnenberg.
362
363         * DumpRenderTree/TestRunner.cpp:
364         (neverInlineFunction):
365         (TestRunner::staticFunctions):
366
367 2013-05-27  Filip Pizlo  <fpizlo@apple.com>
368
369         testRunner should be able to tell you if a function is DFG compiled
370         https://bugs.webkit.org/show_bug.cgi?id=116847
371
372         Reviewed by Mark Hahnenberg.
373
374         * DumpRenderTree/TestRunner.cpp:
375         (numberOfDFGCompiles):
376         (TestRunner::staticFunctions):
377
378 2013-05-21  Filip Pizlo  <fpizlo@apple.com>
379
380         fourthTier: display-profiler-output should make it even easier to diff the compilation story between two different runs
381         https://bugs.webkit.org/show_bug.cgi?id=116556
382
383         Reviewed by Oliver Hunt.
384         
385         This adds three new capabilities:
386         
387         - 'display' now accepts negative compilation indices, and allows specifying
388           wildcard hashes combined with combination indices. Previously you could say
389           'display <hash>', 'display <hash>-<index>-<engine>', or 'display *'. The
390           latter would display every compilation. This improves this so that you can
391           say 'display *-<index>-<engine>'. It also makes it so that you can give a
392           negative index, which allows you to say things like 'display blah--1-dfg',
393           which displays just the last DFG compilation. Also you can say
394           'display *--1-dfg', which displays the last DFG compilation for each code
395           block. I realize that this is kind of ugly, but gosh is it practical.
396         
397         - You can now say 'sort hash', which will henceforth sort all of the output
398           by code hash rather than by the time when it was compiled. This means that
399           if you're doing 'dispay *--1-dfg' and then want to diff the results against
400           something else, you can ensure that this doesn't get confused just by
401           changes in compilation order.
402         
403         - You can now say 'counts off', which will henceforth disable the display of
404           execution counts from 'bytecode' and 'display'. This is also useful for
405           diffs, since if you're trying to figure out why two compilations are
406           different, they probably have radically different counts. 'counts off' gets
407           this out of the output so that it doesn't confuse your diff.
408         
409         Note that to use this effectively you should also have a script that scrubs
410         pointers from text so that the diff doesn't get confused by pointers. I'll
411         post my elimptr script to the bug. Maybe at some point I'll integrate that
412         into display-profiler-output.
413         
414         Put together this is pretty awesome. I was able to do the following:
415         
416         (echo "counts off" && echo "sort hash" && echo "d *--1-dfg") | Tools/Scripts/display-profiler-output richards-serial.profile | elimptr > richards-serial.asm
417         (echo "counts off" && echo "sort hash" && echo "d *--1-dfg") | Tools/Scripts/display-profiler-output richards-concurrent.profile | elimptr > richards-concurrent.asm
418         diff -u richards-serial.asm richards-concurrent.asm
419         
420         And this immediately told me that the reason why richards is slower in the
421         concurrent compilation case is just that we end up compiling *tons* more
422         functions, most of which are trivially inlineable. Basically, concurrent
423         compilation breaks our previous heuristics for delaying compilation of
424         inlineables just enough that they never trigger compilation. We should fix
425         that in a separate bug.
426
427         * Scripts/display-profiler-output:
428
429 2013-04-30  Filip Pizlo  <fpizlo@apple.com>
430
431         fourthTier: Use hw.availcpu instead of hw.ncpu, and configure LLVM with --enable-zlib=no
432
433         Rubber stamped by Mark Rowe.
434
435         * Scripts/copy-webkitlibraries-to-product-directory:
436
437 2013-07-16  Oliver Hunt <oliver@apple.com>
438
439         Merge dfgFourthTier r148853
440
441     2013-04-21  Filip Pizlo  <fpizlo@apple.com>
442
443         fourthTier: tandem WebKit and LLVM builds should ./configure LLVM if needed
444         https://bugs.webkit.org/show_bug.cgi?id=114933
445
446         Reviewed by Andy Estes.
447         
448         This makes it easy to get set up for tandem LLVM builds.
449
450         * Scripts/copy-webkitlibraries-to-product-directory:
451
452 2013-07-16  Oliver Hunt <oliver@apple.com>
453
454         Merge dfgFourthTier r148850
455
456     2013-04-21  Filip Pizlo  <fpizlo@apple.com>
457
458         fourthTier: WebKit's build system should relink JavaScriptCore if LLVM's libraries changed but its headers didn't
459         https://bugs.webkit.org/show_bug.cgi?id=114926
460
461         Reviewed by Geoffrey Garen.
462         
463         If the LLVM libraries change, then touch a phony header, which will force relink
464         of JavaScriptCore.
465
466         * Scripts/copy-webkitlibraries-to-product-directory:
467         (unpackIfNecessary):
468
469 2013-07-16  Oliver Hunt <oliver@apple.com>
470
471         Merge dfgFourthTier r148848
472
473     2013-04-21  Filip Pizlo  <fpizlo@apple.com>
474
475         fourthTier: developing LLVM in tandem with WebKit should be fun and easy
476         https://bugs.webkit.org/show_bug.cgi?id=114925
477
478         Reviewed by Geoffrey Garen.
479         
480         This enables building LLVM along with WebKit, so that build-jsc and build-webkit
481         will also optionally build LLVM and quickly symlink LLVM's built products into
482         the right places.
483         
484         Most WebKit and JSC hackers will want to rely on the checked-in already-built
485         versions of LLVM in WebKitLibraries. But developing both systems in tandem is an
486         increasingly common use-case for me, and it may become a common use case for a
487         handful of others. Currently, this is really painful: you first have to build
488         LLVM, then you have to export-llvm-build (which takes a while), and then you
489         have to make sure that your LLVM_LIBRARY_PACKAGE and LLVM_INCLUDE_PACKAGE
490         variables are set to point to the thing you exported. The whole process loses
491         track of dependencies very quickly: making a tiny change in LLVM requires
492         packaging, and then unpackaging, a large number of potentially large headers and
493         static libraries. Not only is this slow but it then causes the WebKit build
494         system to rebuild anything that transitively includes any LLVM header, which is
495         now quite a few files. While this sort of use pattern is still worthwhile if
496         you're trying to package a binary drop and test it, it's not great if you're
497         just trying to do experimental development that involves making small changes
498         in both trees.
499         
500         This change fixes this use case while keeping the old use cases intact. You can
501         do tandem development using one of two modes:
502         
503         Your own LLVM directory: just set LLVM_SOURCE_PATH to the *absolute* path of
504         the LLVM directory you're using. Once this is done, any invocation of a WebKit
505         build via build-jsc or build-webkit will also build LLVM, and then quickly
506         symlink things into place without perturbing dependency tracking.
507         
508         Internal LLVM directory: if you check out llvm into a directory called 'llvm'
509         right off of the WebKit source tree, then the build system will automatically
510         use this.
511         
512         Here's how this takes care of dependencies:
513         
514         Headers: the include/llvm and include/llvm-c directories are symlinked into
515         $productsDir/usr/local/include. And then everything just works.
516         
517         Libraries: the build system detects, by reading LLVM's Makefile.config, which
518         mode LLVM is built in (like Release+Asserts or Debug+Asserts) and symlinks
519         the .a files into $productsDir/<thingy>. It will ranlib those libraries only
520         if they have changed, by checking both the modification time and also whether
521         the last time we had a symlink, that symlink was from the same directory.
522         This helps if you switch to an *older* LLVM build (using LLVM_SOURCE_PATH)
523         but that build wasn't yet ranlib'd.
524         
525         One problem that this does not yet solve is that xcodebuild will not relink
526         JavaScriptCore if the only thing that changed was the libraries. I will work
527         on this problem separately: https://bugs.webkit.org/show_bug.cgi?id=114926.
528
529         * Scripts/copy-webkitlibraries-to-product-directory:
530         (unpackIfNecessary):
531         (fileContains):
532         (fileContentsEquals):
533
534 2013-04-15  Filip Pizlo  <fpizlo@apple.com>
535
536         fourthTier: Update LLVM-related build scripts to copy generated headers as well
537         https://bugs.webkit.org/show_bug.cgi?id=114551
538
539         Reviewed by Oliver Hunt.
540         
541         Also added the ability to use something other than bzip2 compression, since although
542         it is great for checking things into the tree, it increases turn-around times when
543         experimenting.
544
545         * Scripts/copy-webkitlibraries-to-product-directory:
546         (unpackIfNecessary):
547         * Scripts/export-llvm-build:
548
549 2013-04-03  Filip Pizlo  <fpizlo@apple.com>
550
551         fourthTier: Include LLVM headers with surrounding #pragmas instead of using my #define
552         https://bugs.webkit.org/show_bug.cgi?id=113921
553
554         Reviewed by Oliver Hunt.
555
556         The LLVM community wants us to continue including all of LLVM's C++ headers. Change
557         the export script to do this.
558         
559         * Scripts/export-llvm-build:
560
561 2013-03-29  Filip Pizlo  <fpizlo@apple.com>
562
563         fourthTier: Check in a known-good build of LLVM into WebKitLibraries, and have a story for updating it
564         https://bugs.webkit.org/show_bug.cgi?id=113452
565
566         Rubber stamped by Mark Hahnenberg.
567
568         * Scripts/copy-webkitlibraries-to-product-directory:
569         * Scripts/export-llvm-build:
570
571 2013-03-29  Filip Pizlo  <fpizlo@apple.com>
572
573         fourthTier: FTL JIT should be able run some simple function
574         https://bugs.webkit.org/show_bug.cgi?id=113481
575
576         Reviewed by Geoffrey Garen.
577         
578         Give the scripts the ability to find an LLVM build and use it.
579         
580         Also added a script, export-llvm-build, that allows you to take your
581         own build of LLVM and package it for use by WebKit's build system.
582         
583         The build system treats a "build" of LLVM as a pair of .tar.bz2's,
584         one for the library archives and one for the headers. It then unpacks
585         them into your built products directory in a mannner that is mostly
586         analogous to how WebKitSystemInterface works.
587
588         * Scripts/build-jsc:
589         * Scripts/copy-webkitlibraries-to-product-directory:
590         (unpackIfNecessary):
591         (dittoHeaders):
592         * Scripts/export-llvm-build: Added.
593
594 2013-07-24  Anders Carlsson  <andersca@apple.com>
595
596         Crash when calling WKPageGetProcessIdentifier after aborted process launch
597         https://bugs.webkit.org/show_bug.cgi?id=119069
598         <rdar://problem/14494064>
599
600         Reviewed by Andreas Kling.
601
602         Add a test.
603
604         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
605         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp: Added.
606         (TestWebKitAPI::didFinishLoadForFrame):
607         (TestWebKitAPI::TEST):
608
609 2013-07-24  Zan Dobersek  <zdobersek@igalia.com>
610
611         Make KURL::hasPath private
612         https://bugs.webkit.org/show_bug.cgi?id=118279
613
614         Reviewed by Darin Adler.
615
616         * TestWebKitAPI/Tests/WebCore/KURL.cpp:
617         (TestWebKitAPI::TEST_F): Remove references to KURL::hasPath the method is now private and thus not accessible for testing.
618
619 2013-07-24  Anton Obzhirov  <a.obzhirov@samsung.com>
620
621         [GTK] TestInspectorServer unit test is timing out
622         https://bugs.webkit.org/show_bug.cgi?id=105866
623
624         Reviewed by Gustavo Noronha Silva.
625
626         * Scripts/run-gtk-tests:
627         (TestRunner):
628
629 2013-07-24  Anton Obzhirov  <a.obzhirov@samsung.com>
630
631         [GTK] [WK2] Handle wheel event with delta zero
632         https://bugs.webkit.org/show_bug.cgi?id=118973
633
634         Reviewed by Gustavo Noronha Silva.
635
636         Added handling of zero mouse scroll deltas in EventSenderProxy similar
637         to WK1 and Qt/EFL ports.
638
639         fast/events/platform-wheelevent-with-delta-zero-crash.html is no longer
640         failing on WK2.
641
642         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
643         (WTR::EventSenderProxy::mouseScrollBy):
644
645 2013-07-23  Andreas Kling  <akling@apple.com>
646
647         REGRESSION(r150867): FrameView auto-sizing + delegate denied image load may cause StyleResolver to re-enter itself.
648         <rdar://problem/14324895>
649         <http://webkit.org/b/119023>
650
651         Reviewed by Simon Fraser.
652
653         Add a test for this rather specific problem.
654
655         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
656         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm: Added.
657         (TestWebKitAPI::TEST):
658         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp: Added.
659         (TestWebKitAPI::DenyWillSendRequestTest::DenyWillSendRequestTest):
660         (TestWebKitAPI::DenyWillSendRequestTest::willSendRequestForFrame):
661         (TestWebKitAPI::DenyWillSendRequestTest::didCreatePage):
662
663 2013-07-23  Tim Horton  <timothy_horton@apple.com>
664
665         Add a test for plug-in unavailability indicator obscurity detection
666         https://bugs.webkit.org/show_bug.cgi?id=119007
667
668         Reviewed by Anders Carlsson.
669
670         Expose the ability to block plug-ins via pluginLoadPolicy to testRunner.
671
672         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
673         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
674         (WTR::TestRunner::setBlockAllPlugins):
675         * WebKitTestRunner/InjectedBundle/TestRunner.h:
676         * WebKitTestRunner/TestInvocation.cpp:
677         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
678         Add testRunner.setBlockAllPlugins function (and corresponding message to
679         forward it through to TestController).
680
681         * WebKitTestRunner/TestController.cpp:
682         Initialize m_shouldBlockAllPlugins to false (and drive-by initialize m_handlesAuthenticationChallenges).
683
684         (WTR::TestController::createWebViewWithOptions):
685         Register our pluginLoadPolicy callback.
686
687         (WTR::TestController::resetStateToConsistentValues):
688         Reset m_shouldBlockAllPlugins to false.
689
690         (WTR::TestController::pluginLoadPolicy):
691         Return the existing plugin load policy, unless setBlockAllPlugins(true)
692         was called, in which case we reject all plugins with kWKPluginLoadPolicyBlocked.
693
694         * WebKitTestRunner/TestController.h:
695         (WTR::TestController::setBlockAllPlugins):
696
697 2013-07-21  Andreas Kling  <akling@apple.com>
698
699         KURL creates duplicate strings when completing data: URIs.
700         <http://webkit.org/b/118952>
701         <rdar://problem/14504480>
702
703         Reviewed by Anders Carlsson.
704
705         * TestWebKitAPI/Tests/WebCore/KURL.cpp:
706         (TestWebKitAPI::TEST_F):
707
708 2013-07-19  Chris Fleizach  <cfleizach@apple.com>
709
710         AX: VoiceOver not detecting misspelled words don't work in all cases
711         https://bugs.webkit.org/show_bug.cgi?id=118924
712
713         Reviewed by Tim Horton.
714
715         Make the misspelled detection dependent on both types of attributes being present.
716
717         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
718         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
719         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
720         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
721
722 2013-07-19  Alex Christensen  <achristensen@apple.com>
723
724         Improved code coverage generation.
725         https://bugs.webkit.org/show_bug.cgi?id=118926
726
727         Reviewed by Tim Horton.
728
729         * Scripts/build-webkit: Removed exception preventing ANGLE code coverage support.
730         * Scripts/generate-coverage-data: Added --no-build to run-javascriptcore-tests call.
731         (generateReport): Moved report generation to a subroutine.
732
733 2013-07-19  Stephanie Lewis  <slewis@apple.com>
734
735         <rdar://problem/14499595> pagination wk2 api test failing on ML (118928)
736
737         Unreviewed.
738
739         Rebaseline pagination test after http://trac.webkit.org/changeset/152911
740
741         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
742         (TestWebKitAPI::didLayout):
743
744 2013-07-19  Daniel Bates  <dabates@apple.com>
745
746         Make Perl tools work when using git bisect with Git branch build setup
747         https://bugs.webkit.org/show_bug.cgi?id=118512
748
749         Reviewed by Martin Robinson.
750
751         The various Perl tools (run-webkit-app, {debug, run}-safari, et cetera) don't work
752         during a git bisect session with a Git branch build setup (i.e. git config
753         core.webKitBranchBuild true). Specifically, the tools cannot find the branch-
754         specific build of WebKit because they cannot determine the branch Git is on (since
755         git bisect puts Git into a detached HEAD state). We should teach our tooling to
756         parse the file .git/BISECT_START (created by git bisect start) for the name of the
757         branch Git was on when we began a git bisect session. Then the tools can determine
758         the path to the built WebKit.
759
760         * Scripts/VCSUtils.pm:
761         (gitDirectory): Added.
762         (gitBisectStartBranch): Added.
763         (gitBranch): Modified to call gitBisectStartBranch() when we have a detached
764         HEAD (e.g. running git bisect).
765         (determineVCSRoot): Modified to call gitDirectory() to determine the path to
766         the .git directory in the Git checkout.
767
768 2013-07-19  Alex Christensen  <achristensen@apple.com>
769
770         Added x64 configuration to Visual Studio build.
771         https://bugs.webkit.org/show_bug.cgi?id=118888
772
773         Reviewed by Brent Fulgham.
774
775         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
776         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj.filters:
777         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
778         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
779         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
780         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
781         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
782         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
783         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
784         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
785         * win/record-memory/record-memory.vcxproj:
786
787 2013-07-19  Martin Robinson  <mrobinson@igalia.com>
788
789         Add a couple people to the MathML watchlist
790         https://bugs.webkit.org/show_bug.cgi?id=118909
791
792         Reviewed by Andreas Kling.
793
794         Add a couple people to the MathML watchlist and add Kalyan's other
795         email address to fix style checker warnings about the watchlist
796         contents.
797
798         * Scripts/webkitpy/common/config/contributors.json: Add Frédéric to the
799         list of contributors and add Kalyan's second email address.
800         * Scripts/webkitpy/common/config/watchlist: Add myself and Frédéric to the MathML
801         watchlist.
802
803 2013-07-19  Simon Pena  <simon.pena@samsung.com>
804
805         [GTK] Fix regression in DumpRenderTree introduced in r152782 by checking if uri is valid
806         https://bugs.webkit.org/show_bug.cgi?id=118895
807
808         Reviewed by Philippe Normand.
809
810         In r152782 an uri is used to create an string representation without checking first if it
811         is valid. That fails later when the string is used to check for existing redirections. This
812         patch ensures that the uri is valid before using it.
813
814         * DumpRenderTree/gtk/DumpRenderTree.cpp:
815         (willSendRequestCallback): Ensure an uri is valid before using it.
816
817 2013-07-18  Timothy Hatcher  <timothy@apple.com>
818
819         Add extract-localizable-js-strings and use it for WebInspectorUI.
820
821         https://bugs.webkit.org/show_bug.cgi?id=118851
822
823         Reviewed by Joseph Pecoraro.
824
825         * Scripts/extract-localizable-js-strings: Added.
826         * Scripts/extract-localizable-strings: Drive-by-fix: disable deprecated warnings about "goto".
827         * Scripts/update-webkit-localizable-strings: Use extract-localizable-js-strings for
828         the WebInspectorUI project.
829
830 2013-07-18  Brent Fulgham  <bfulgham@apple.com>
831
832         [Windows] Build correction #2 after r152861.
833
834         * WinLauncher/WinLauncher.cpp: Declare proper linkage.
835
836 2013-07-18  Brent Fulgham  <bfulgham@apple.com>
837
838         [Windows] Build correction after r152861.
839
840         * WinLauncher/WinLauncher.cpp: Don't reference private header.
841
842 2013-07-16  Brent Fulgham  <bfulgham@apple.com>
843
844         [Win] Support in-band text tracks.
845         https://bugs.webkit.org/show_bug.cgi?id=103770
846
847         Reviewed by Eric Carlson.
848
849         Update WinLauncher to run in a CFRunLoop (rather than a hand-written Windows event loop) so that
850         libdispatch and CFRunLoop elements are services during the run loop.
851
852         * WinLauncher/WinLauncher.cpp:
853         (dllLauncherEntryPoint): Use CFRunLoopRun (rather than a Windows message loop) if running with
854         a CoreFoundation (or CFLite) support library.
855         * WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props: Added.
856         * WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props: Added.
857         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add references to WinLauncherCF.props
858         and WinLauncherCFLite.props.
859
860 2013-07-18  Roger Fong  <roger_fong@apple.com>
861
862         Unreviewed. Test enabling WinEWS tests now that queue is at a good state and NRWT with multiple processes is enabled.
863
864         * Scripts/webkitpy/common/config/ews.json:
865
866 2013-07-18  Daniel Bates  <dabates@apple.com>
867
868         REGRESSION (r132678): Tests that use SSL or port 8080 time out when run using old-run-webkit-tests
869         https://bugs.webkit.org/show_bug.cgi?id=118854
870         <rdar://problem/14081339>
871
872         Reviewed by David Kilzer.
873
874         Following <http://trac.webkit.org/changeset/132678> (https://bugs.webkit.org/show_bug.cgi?id=98602)
875         Apache no longer listens to ports 8443 (SSL) and 8080. So, tests that use these ports time out when
876         run using old-run-webkit-tests. We need to update old-run-webkit-tests to explicitly tell Apache to
877         listen on these ports so that we can run tests that use port 8443 and 8080.
878
879         * Scripts/old-run-webkit-tests:
880         (configureAndOpenHTTPDIfNeeded):
881
882 2013-07-17  Tim Horton  <timothy_horton@apple.com>
883
884         Update blocked/missing plug-in UI
885         https://bugs.webkit.org/show_bug.cgi?id=118347
886         <rdar://problem/14209318>
887
888         Reviewed by Sam Weinig.
889
890         * MiniBrowser/mac/WK2BrowserWindowController.m:
891         (-[WK2BrowserWindowController awakeFromNib]):
892         * WebKitTestRunner/TestController.cpp:
893         (WTR::TestController::createWebViewWithOptions):
894         Match new WKPageLoaderClient entry.
895
896 2013-07-17  Commit Queue  <commit-queue@webkit.org>
897
898         Unreviewed, rolling out r152701, r152703, r152739, r152754,
899         and r152756.
900         http://trac.webkit.org/changeset/152701
901         http://trac.webkit.org/changeset/152703
902         http://trac.webkit.org/changeset/152739
903         http://trac.webkit.org/changeset/152754
904         http://trac.webkit.org/changeset/152756
905         https://bugs.webkit.org/show_bug.cgi?id=118821
906
907         this was a buggy fix and we're going to try something
908         different (Requested by thorton on #webkit).
909
910         * MiniBrowser/mac/WK2BrowserWindowController.m:
911         (-[WK2BrowserWindowController awakeFromNib]):
912         * WebKitTestRunner/TestController.cpp:
913         (WTR::TestController::createWebViewWithOptions):
914
915 2013-07-17  Commit Queue  <commit-queue@webkit.org>
916
917         Unreviewed, rolling out r151535.
918         http://trac.webkit.org/changeset/151535
919         https://bugs.webkit.org/show_bug.cgi?id=118804
920
921         Re-disable WinEWS tests (Requested by rfong on #webkit).
922
923         * Scripts/webkitpy/common/config/ews.json:
924
925 2013-07-17  Simon Pena  <simon.pena@samsung.com>
926
927         [GTK] Make DRT obbey testRunner's addURLToRedirect
928         https://bugs.webkit.org/show_bug.cgi?id=118239
929
930         Reviewed by Gustavo Noronha Silva.
931
932         Support testRunner's addURLToRedirect in GTK's DRT, so it redirects
933         to the proper URI when indicated.
934
935         * DumpRenderTree/gtk/DumpRenderTree.cpp:
936         (willSendRequestCallback):
937
938 2013-07-17  Gabor Abraham  <abrhm@inf.u-szeged.hu>
939
940         Add a new find-resolved-bugs command to webkit-patch.
941         https://bugs.webkit.org/show_bug.cgi?id=118060
942
943         Reviewed by Csaba Osztrogonác.
944
945         * Scripts/webkitpy/tool/commands/queries.py:
946         (PrintBaselines._platform_for_path):
947         (FindResolvedBugs):
948         (FindResolvedBugs.execute):
949
950 2013-07-16  Balazs Kelemen  <kbalazs@webkit.org>
951
952         [CMake] Undefined references should be detected at build time
953         https://bugs.webkit.org/show_bug.cgi?id=110236
954
955         Reviewed by Christophe Dumez.
956
957         Add library dependencies that were not defined explicitly before.
958
959         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
960         * TestWebKitAPI/CMakeLists.txt:
961         * WebKitTestRunner/CMakeLists.txt:
962
963 2013-07-16  Kwang Yul Seo  <skyul@company100.net>
964
965         check-webkit-style: "using namespace foo;" should be flagged as an error only in headers
966         https://bugs.webkit.org/show_bug.cgi?id=118755
967
968         Reviewed by Ryosuke Niwa.
969
970         Fix r152719 to check "using namespace foo;" only in headers.
971
972         * Scripts/webkitpy/style/checkers/cpp.py:
973         (check_using_namespace):
974         (check_style):
975         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
976         (WebKitStyleTest.test_using_namespace):
977
978 2013-07-16  Christophe Dumez  <ch.dumez@sisa.samsung.com>
979
980         Get rid of multiple inheritance support from the bindings generators
981         https://bugs.webkit.org/show_bug.cgi?id=118353
982
983         Reviewed by Kentaro Hara.
984
985         Update CodeGeneratorTestRunner.pm to use domInterface->parent instead of
986         deprecated domInterface->parents.
987
988         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
989         (_parentInterface):
990
991 2013-07-16  Brian Holt  <brian.holt@samsung.com>
992
993         check-webkit-style: "using namespace foo;" should be flagged as an error in headers
994         https://bugs.webkit.org/show_bug.cgi?id=57241
995
996         Reviewed by Ryosuke Niwa.
997
998         Added check for "using namespace foo" and unit test.
999
1000         * Scripts/webkitpy/style/checkers/cpp.py:
1001         (check_using_namespace):
1002         (check_style):
1003         (CppChecker):
1004         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1005         (WebKitStyleTest.test_using_namespace):
1006
1007 2013-07-16  Anton Obzhirov  <a.obzhirov@samsung.com>
1008
1009         [GTK] fast/events/platform-wheelevent-with-delta-zero-crash.html is crashing
1010         https://bugs.webkit.org/show_bug.cgi?id=110222
1011
1012         Reviewed by Gustavo Noronha Silva.
1013
1014         Added handling of zero mouse scroll deltas in EventSender.
1015
1016         * DumpRenderTree/gtk/EventSender.cpp:
1017         (mouseScrollByCallback):
1018
1019 2013-07-16  Brian Holt  <brian.holt@samsung.com>
1020
1021         webkitpy: replace urllib with urllib2 for downloading additional modules
1022         https://bugs.webkit.org/show_bug.cgi?id=118671
1023
1024         Reviewed by Ryosuke Niwa.
1025
1026         Urllib2 is available whereever urllib is, but has better proxy support.
1027
1028         * Scripts/webkitpy/common/system/autoinstall.py:
1029         (AutoInstaller._download_to_stream):
1030
1031 2013-07-16  Krzysztof Czech  <k.czech@samsung.com>
1032
1033         [ATK] Adds support for aria-haspopup property.
1034         https://bugs.webkit.org/show_bug.cgi?id=117834
1035
1036         Reviewed by Christophe Dumez.
1037
1038         Adds implementation for testing aria-haspopup property.
1039
1040         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1041         (getAttributeSetValueForId):
1042         (AccessibilityUIElement::stringAttributeValue):
1043         (AccessibilityUIElement::hasPopup):
1044         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1045         (WTR::getAttributeSetValueForId):
1046         (WTR::AccessibilityUIElement::stringAttributeValue):
1047         (WTR::AccessibilityUIElement::hasPopup):
1048
1049 2013-07-16  Michael Brüning  <michael.bruning@digia.com>
1050
1051         [Qt] Replace Nokia references.
1052         https://bugs.webkit.org/show_bug.cgi?id=118728
1053
1054         Reviewed by Simon Hausmann.
1055
1056         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1057         (MiniBrowserApplication::MiniBrowserApplication):
1058         * QtTestBrowser/qttestbrowser.cpp:
1059         (LauncherApplication::LauncherApplication):
1060
1061 2013-07-15  Tim Horton  <timothy_horton@apple.com>
1062
1063         Update blocked/missing plug-in UI
1064         https://bugs.webkit.org/show_bug.cgi?id=118347
1065         <rdar://problem/14209318>
1066
1067         Reviewed by Sam Weinig.
1068
1069         * MiniBrowser/mac/WK2BrowserWindowController.m:
1070         (-[WK2BrowserWindowController awakeFromNib]):
1071         * WebKitTestRunner/TestController.cpp:
1072         (WTR::TestController::createWebViewWithOptions):
1073         Match new WKPageLoaderClient entry.
1074
1075 2013-07-15  Chris Fleizach  <cfleizach@apple.com>
1076
1077         Update James Craig's email address.
1078
1079         * Scripts/webkitpy/common/config/contributors.json:
1080
1081 2013-07-15  Dong-Gwan Kim  <donggwan.kim@samsung.com>
1082
1083         [EFL] Add fallback for TestWebKitAPI if opengl is not available.
1084         https://bugs.webkit.org/show_bug.cgi?id=118583
1085
1086         Reviewed by Christophe Dumez.
1087
1088         There're many fails on efl webkit2 API test if opengl is not available.
1089         So, add fallback to non-opengl evas engine.
1090
1091         * TestWebKitAPI/efl/PlatformWebView.cpp:
1092         (TestWebKitAPI::initEcoreEvas):
1093
1094 2013-07-15  Brian Holt  <brian.holt@samsung.com>
1095
1096         check-webkit-style: Ignore false positive: Instance of 'Popen' has no 'pid' member
1097         https://bugs.webkit.org/show_bug.cgi?id=118592
1098
1099         Reviewed by Martin Robinson.
1100
1101         Added a suppression for pylint false positives and a unit test.
1102
1103         * Scripts/webkitpy/style/checkers/python.py:
1104         (Pylinter):
1105         * Scripts/webkitpy/style/checkers/python_unittest.py:
1106         (PythonCheckerTest.test_check):
1107         (PythonCheckerTest):
1108         (PythonCheckerTest.test_pylint_false_positives):
1109         (PythonCheckerTest.test_pylint_false_positives._mock_handle_style_error):
1110         * Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py: Added.
1111         (test_popen):
1112
1113 2013-07-15  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1114
1115         [GTK] Increase the JHBuild version of GStreamer to 1.0.7
1116         https://bugs.webkit.org/show_bug.cgi?id=115166
1117
1118         Reviewed by Philippe Normand.
1119
1120         * gtk/jhbuild.modules: Bumping GStreamer version up to 1.0.8.
1121
1122 2013-07-12  Kwang Yul Seo  <skyul@company100.net>
1123
1124         Unreviewed. Add an email address and update my domain of experts.
1125
1126         * Scripts/webkitpy/common/config/contributors.json:
1127
1128 2013-07-12  Emanuele Aina  <emanuele.aina@collabora.com>
1129
1130         [jhbuild] Avoid restarting from scratch failed initial checkouts
1131         https://bugs.webkit.org/show_bug.cgi?id=118603
1132
1133         Reviewed by Martin Robinson.
1134
1135         If the initial checkout is interrupted midway (eg. because the internet
1136         connection went down) config files do not get generated and that causes
1137         the next checkout to start from scratch (the missing files cause the
1138         script to delete the build root and the downloaded sources).
1139
1140         By generating the files before invoking jhbuild, subsequent runs are able
1141         to start where the previous run left.
1142
1143         * Scripts/update-webkit-libs-jhbuild:
1144         (saveJhbuildMd5): invoke it before runJhbuild().
1145
1146 2013-07-12  Brent Fulgham  <bfulgham@apple.com>
1147
1148         [Windows] Remove single-worker restriction on tests.
1149
1150         * Scripts/webkitpy/port/win.py: Remove restriction of one worker.
1151
1152 2013-07-12  Commit Queue  <commit-queue@webkit.org>
1153
1154         Unreviewed, rolling out r152599.
1155         http://trac.webkit.org/changeset/152599
1156         https://bugs.webkit.org/show_bug.cgi?id=118612
1157
1158         This patch includes a failing unit test (Requested by
1159         mrobinson on #webkit).
1160
1161         * Scripts/webkitpy/style/checkers/python.py:
1162         (Pylinter):
1163         * Scripts/webkitpy/style/checkers/python_unittest.py:
1164         (PythonCheckerTest.test_check):
1165         * Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py: Removed.
1166
1167 2013-07-12  Emanuele Aina  <emanuele.aina@collabora.com>
1168
1169         [Tools] Ignore missing GNUmakefile when detecting previous arch in build-webkit
1170         https://bugs.webkit.org/show_bug.cgi?id=91223
1171
1172         Reviewed by Martin Robinson.
1173
1174         When run on a clean checkout, `build-webkit` complains that no
1175         GNUmakefile exists when trying to detect the previously configured
1176         architecture, but in this case there's no previous configuration so
1177         the warning is pointless.
1178
1179         * Scripts/webkitdirs.pm:
1180         (determineArchitecture): Redirect grep stderr to /dev/null.
1181
1182 2013-07-12  Brian Holt  <brian.holt@samsung.com>
1183
1184         check-webkit-style: Ignore false positive: Instance of 'Popen' has no 'pid' member
1185         https://bugs.webkit.org/show_bug.cgi?id=118592
1186
1187         Reviewed by Martin Robinson.
1188
1189         Added a suppression for pylint false positives and a unit test.
1190
1191         * Scripts/webkitpy/style/checkers/python.py:
1192         (Pylinter):
1193         * Scripts/webkitpy/style/checkers/python_unittest.py:
1194         (PythonCheckerTest.test_check):
1195         (PythonCheckerTest):
1196         (PythonCheckerTest.test_pylint_false_positives):
1197         (PythonCheckerTest.test_pylint_false_positives._mock_handle_pylint_false_positives):
1198         * Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py: Added.
1199         (test_popen):
1200
1201 2013-07-11  Arnaud Renevier  <a.renevier@samsung.com>
1202
1203         Unreviewed. Add myself as a committer.
1204
1205         * Scripts/webkitpy/common/config/contributors.json:
1206
1207 2013-07-10  Sergio Correia  <sergio.correia@openbossa.org>
1208
1209         Handle "load,provisional,failed" with the on_error callback on EFL MiniBrowser
1210         https://bugs.webkit.org/show_bug.cgi?id=118538
1211
1212         Reviewed by Christophe Dumez.
1213
1214         When attempting some odd url such as ``foo'', MiniBrowser will now show an
1215         error message such as "Cannot resolve hostname (foo)".
1216
1217         Previously, it had the following behavior if MiniBrowser was started with
1218         such urls, e.g ``./MiniBrowser foo'':
1219
1220         - Debug:
1221         It wouldt hit WebKit2/Platform/CoreIPC/unix/ConnectionUnix.cpp(460) and crash.
1222
1223         - Release:
1224         No asserts, naturally, but the view would remain blank, even if we tried to
1225         change to a valid url.
1226
1227         * MiniBrowser/efl/main.c:
1228         (window_create):
1229
1230 2013-07-10  Simon Pena  <simon.pena@samsung.com>
1231
1232         [GTK] WebKitTestRunner tries to remove an already deleted event in EventSenderProxy::replaySavedEvents
1233         https://bugs.webkit.org/show_bug.cgi?id=118509
1234
1235         Reviewed by Martin Robinson.
1236
1237         In EventSenderProxy::replaySavedEvents WebKitTestRunner can crash
1238         when trying to remove an event already removed, if another event is
1239         processed in the middle. By using a Deque's takeFirst, we ensure the
1240         element is removed before we dispatch it.
1241
1242         fast/events/mousedown-inside-dragstart-should-not-cause-crash.html no longer
1243         crashes after this fix is added.
1244
1245         * WebKitTestRunner/EventSenderProxy.h: Use a Deque instead of Vector in GTK
1246         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1247         (WTR::EventSenderProxy::replaySavedEvents): Use takeFirst to retrieve the event
1248         from the queue.
1249
1250 2013-07-09  Ryuan Choi  <ryuan.choi@samsung.com>
1251
1252         [EFL] Add ewk_view_device_pixel_ratio_set
1253         https://bugs.webkit.org/show_bug.cgi?id=118521
1254
1255         Reviewed by Gyuyoung Kim.
1256
1257         * EWebLauncher/main.c: Added new option(-r) to test device pixel ratio.
1258         (windowCreate):
1259         (parseUserArguments):
1260
1261 2013-07-09  Bruno de Oliveira Abinader  <brunoabinader@gmail.com>
1262
1263         Unreviewed change of my email addresses.
1264         https://bugs.webkit.org/show_bug.cgi?id=100122
1265
1266         * Scripts/webkitpy/common/config/contributors.json:
1267
1268 2013-07-09  Anders Carlsson  <andersca@apple.com>
1269
1270         DumpRenderTree should stop sending unsupported URLs to NSWorkspace
1271         https://bugs.webkit.org/show_bug.cgi?id=118514
1272         <rdar://problem/13686836>
1273
1274         Reviewed by Sam Weinig.
1275
1276         Add a new default policy delegate and override decidePolicyForNavigationAction: to not pass unhandled URLs to NSWorkspace.
1277
1278         * DumpRenderTree/DefaultPolicyDelegate.h: Added.
1279         * DumpRenderTree/DefaultPolicyDelegate.m: Added.
1280         (-[DefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
1281         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1282         Add DefaultPolicyDelegate.h and DefaultPolicyDelegate.m.
1283
1284         * DumpRenderTree/mac/DumpRenderTree.mm:
1285         (allocateGlobalControllers):
1286         Allocate a DefaultPolicyDelegate object.
1287
1288         (resetWebViewToConsistentStateBeforeTesting):
1289         Set the policy delegate to the default policy delegate.
1290
1291         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1292         Declare the defaultPolicyDelegate object.
1293
1294         * DumpRenderTree/mac/TestRunnerMac.mm:
1295         (TestRunner::setCustomPolicyDelegate):
1296         Set the policy delegate to the default delegate if setDelegate is false.
1297
1298 2013-07-08  Zan Dobersek  <zdobersek@igalia.com>
1299
1300         KURL unit test fixture class should have a meaningful name
1301         https://bugs.webkit.org/show_bug.cgi?id=118467
1302
1303         Reviewed by Sam Weinig.
1304
1305         * TestWebKitAPI/Tests/WebCore/KURL.cpp:
1306         (TestWebKitAPI::TEST_F): Use 'KURLTest' as the name for the KURL unit test's fixture class
1307         instead of the generic and inappropriate 'WebCore' name.
1308
1309 2013-07-08  Antti Koivisto  <antti@apple.com>
1310
1311         Add Deque::removeLast
1312         https://bugs.webkit.org/show_bug.cgi?id=118466
1313
1314         Reviewed by Andreas Kling.
1315
1316         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1317         * TestWebKitAPI/Tests/WTF/Deque.cpp: Added.
1318         (TestWebKitAPI::TEST):
1319
1320 2013-07-08  Brian Holt  <brian.holt@samsung.com>
1321
1322         [GTK] Leak: GFile* leaking in beginDragWithFilesCallback
1323         https://bugs.webkit.org/show_bug.cgi?id=118412
1324
1325         Reviewed by Martin Robinson.
1326
1327         An adoptRef is required to balance ref and deref calls.
1328
1329         * DumpRenderTree/gtk/EventSender.cpp:
1330         (beginDragWithFilesCallback):
1331
1332 2013-07-06  Sergio Correia  <sergio.correia@openbossa.org>
1333
1334         Update list of EFL WK2 API tests
1335         https://bugs.webkit.org/show_bug.cgi?id=118443
1336
1337         Reviewed by Christophe Dumez.
1338
1339         The following tests were included:
1340
1341         Passing:
1342         - CloseThenTerminate
1343         - DidAssociateFormControls
1344         - PageVisibilityState
1345         - ResponsivenessTimerDoesntFireEarly
1346         - TerminateTwice
1347         - WillLoad
1348
1349         Failing:
1350         - ResizeReversePaginatedWebView
1351         - ScrollPinningBehaviors
1352
1353         This patch also modified ``test_webkit2_api_BINARIES'' list so that it is in
1354         alphabetical order.
1355
1356         * TestWebKitAPI/CMakeLists.txt: Added Bundles for included tests.
1357         * TestWebKitAPI/PlatformEfl.cmake: Added a few tests.
1358
1359 2013-07-05  Tim Horton  <timothy_horton@apple.com>
1360
1361         Fix r152265: FrameView's pagination mode is only one of two, and the logic was totally wrong
1362         https://bugs.webkit.org/show_bug.cgi?id=118439
1363         <rdar://problem/14366120>
1364
1365         Reviewed by Anders Carlsson.
1366
1367         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
1368         (TestWebKitAPI::didLayout):
1369         (TestWebKitAPI::TEST):
1370         - Make use of EXPECT_JS_EQ instead of manually doing JavaScript stuff.
1371         - Assert that we got the right number of pages for sanity.
1372         - Reduce the page gap size so that DrawingAreaImpl doesn't try to allocate
1373             so much memory that SharedMemory asserts and makes the test time out.
1374         - Use didFirstLayoutAfterSuppressedIncrementalRendering instead of Paint
1375             because paint doesn't fire if the window is offscreen.
1376
1377 2013-07-05  Tim Horton  <timothy_horton@apple.com>
1378
1379         [wk2] Add API to lock the scroll position at the top or bottom of the page
1380         https://bugs.webkit.org/show_bug.cgi?id=118429
1381         <rdar://problem/14120323>
1382
1383         Reviewed by Anders Carlsson.
1384
1385         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1386         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp: Added.
1387         (TestWebKitAPI::didFinishDocumentLoadForFrame):
1388         (TestWebKitAPI::TEST):
1389         Add a test that ensures that the three pinning modes (DoNotPin, PinToTop, PinToBottom)
1390         all work correctly in the face of resizing the view and scrolling from JS.
1391
1392 2013-07-05  Michael Pruett  <michael@68k.org>
1393
1394         Unreviewed. Add myself as a committer.
1395
1396         * Scripts/webkitpy/common/config/contributors.json:
1397
1398 2013-07-05  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1399
1400         [GTK] WebKit2 test TestWebKitFaviconDatabase times out with recent glib
1401         https://bugs.webkit.org/show_bug.cgi?id=111434
1402
1403         Reviewed by Carlos Garcia Campos.
1404
1405         * Scripts/run-gtk-tests:
1406         (TestRunner): Unskipped TestWebKitFaviconDatabase tests.
1407
1408 2013-07-04  Viatcheslav Ostapenko  <sl.ostapenko@samsung.com>
1409
1410         [EFL] DumpRenderTree doesn't run if "opengl_x11" engine is not available
1411         https://bugs.webkit.org/show_bug.cgi?id=118370
1412
1413         Reviewed by Christophe Dumez.
1414
1415         Add fallback to software X11 engine if opengl_x11 engine creation fails.
1416
1417         * DumpRenderTree/efl/DumpRenderTree.cpp:
1418         (initEcoreEvas):
1419
1420 2013-07-04  Brian Holt  <brian.holt@samsung.com>
1421
1422         [ATK] Leak: AtkAttributeSet* should be freed
1423         https://bugs.webkit.org/show_bug.cgi?id=118307
1424
1425         Reviewed by Christophe Dumez.
1426
1427         Fixed memory leaks for AtkAttributeSet by calling
1428         atk_attribute_set_free().
1429
1430         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
1431         (AccessibilityController::childElementById):
1432         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1433         (getAtkAttributeSetAsString):
1434         (AccessibilityUIElement::allAttributes):
1435         (AccessibilityUIElement::stringAttributeValue):
1436         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
1437         (WTR::childElementById):
1438         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1439         (WTR::getAtkAttributeSetAsString):
1440         (WTR::AccessibilityUIElement::allAttributes):
1441         (WTR::AccessibilityUIElement::stringAttributeValue):
1442
1443 2013-07-03  David Farler  <dfarler@apple.com>
1444
1445         Add Makefile to WebKitLauncher
1446         https://bugs.webkit.org/show_bug.cgi?id=118365
1447
1448         Reviewed by Mark Rowe.
1449
1450         * WebKitLauncher/Makefile: Added.
1451
1452 2013-07-03  Brian Holt  <brian.holt@samsung.com>
1453
1454         [ATK] Leak: more leaks in AccessibilityUIElement
1455         https://bugs.webkit.org/show_bug.cgi?id=118362
1456
1457         Reviewed by Christophe Dumez.
1458
1459         Free the memory created by g_strdup_printf.
1460
1461         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1462         (AccessibilityUIElement::language):
1463         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1464         (WTR::AccessibilityUIElement::language):
1465
1466 2013-07-03  Jer Noble  <jer.noble@apple.com>
1467
1468         Xcode often gets in a state where the debugger is completely unresponsive
1469         https://bugs.webkit.org/show_bug.cgi?id=118157
1470
1471         The GetPointeeData() operations we use to retrieve strings is extremely expensive.
1472         Rather than pull the character data out of the debugger one byte at a time
1473         through the GetPointeeData() API, retrieve the memory contents of the string through
1474         the ReadMemory() API, and convert the retrieved memory into a python string.
1475
1476         Reviewed by Anders Carlsson.
1477
1478         * lldb/lldb_webkit.py:
1479         (__lldb_init_module.lldb_webkit):
1480         (guess_string_length):
1481         (ustring_to_string):
1482         (lstring_to_string):
1483
1484 2013-07-03  Morten Stenshorne  <mstensho@opera.com>
1485
1486         [GTK] Let F5 refresh the page in MiniBrowser
1487         https://bugs.webkit.org/show_bug.cgi?id=117638
1488
1489         Reviewed by Carlos Garcia Campos.
1490
1491         Also use the correct icon for the refresh button that was already there.
1492
1493         * MiniBrowser/gtk/BrowserWindow.c:
1494         (browser_window_init):
1495
1496 2013-07-02  Kondapally Kalyan  <kalyan.kondapally@intel.com>
1497
1498         Unreviewed. Add my email to a few watchlists.
1499
1500         * Scripts/webkitpy/common/config/watchlist:
1501
1502 2013-07-02  David Farler  <dfarler@apple.com>
1503
1504         Unreviewed. Adding myself to contributors.json.
1505
1506         * Scripts/webkitpy/common/config/contributors.json:
1507
1508 2013-07-02  Brian Holt  <brian.holt@samsung.com>
1509
1510         [ATK] Leak: leaks in AccessibilityUIElement
1511         https://bugs.webkit.org/show_bug.cgi?id=118297
1512
1513         Fixed memory leak.
1514
1515         Reviewed by Christophe Dumez.
1516
1517         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1518         (AccessibilityUIElement::stringValue):
1519
1520 2013-07-02  Byungwoo Lee  <bw80.lee@samsung.com>
1521
1522         Fix WebKitTestRunner crashes.
1523         https://bugs.webkit.org/show_bug.cgi?id=117630
1524
1525         Reviewed by Darin Adler.
1526
1527         Create static function to dump for WebProcess unresponsiveness status,
1528         and use it before calling TestController::runTest().
1529
1530         Accessing TestController::m_currentInvocation before calling
1531         TestController::runTest() can make crash because the invocation
1532         instance will be assigned at the function.
1533
1534         * WebKitTestRunner/TestController.cpp:
1535         (WTR::TestController::run):
1536         * WebKitTestRunner/TestInvocation.cpp:
1537         (WTR::TestInvocation::dumpWebProcessUnresponsiveness):
1538         * WebKitTestRunner/TestInvocation.h:
1539
1540 2013-07-02  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1541
1542         [Qt][WK1] Support WebGL with EGL on Linux
1543         https://bugs.webkit.org/show_bug.cgi?id=118251
1544
1545         Reviewed by Kenneth Rohde Christiansen.
1546
1547         * qmake/mkspecs/features/features.prf:
1548
1549 2013-07-01  Nick Diego Yamane  <nick.yamane@openbossa.org>
1550
1551         [Efl][Gtk] Look at WEBKIT_OUTPUTDIR instead of WEBKITOUTPUTDIR in jhbuildrc
1552         https://bugs.webkit.org/show_bug.cgi?id=118267
1553
1554         Reviewed by Gyuyoung Kim.
1555
1556         After r152226 (from https://bugs.webkit.org/show_bug.cgi?id=117249)
1557         WEBKIT_OUTPUTDIR should be used instead of WEBKITOUPUTDIR. However
1558         Efl's jhbuildrc is still using the WEBKITOUTPUTDIR environment variable.
1559
1560         * efl/jhbuildrc:
1561         * gtk/jhbuildrc:
1562
1563 2013-07-01  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1564
1565         [GTK] Remove unsupported AC backends
1566         https://bugs.webkit.org/show_bug.cgi?id=117362
1567
1568         Reviewed by Martin Robinson.
1569
1570         * gtk/jhbuild-optional.modules: no longer needs clutter-gtk, clutter
1571         and cogl, so removed.
1572
1573 2013-07-01  Timothy Hatcher  <timothy@apple.com>
1574
1575         Link to WebInspectorUI.framework at build time instead of soft linking.
1576
1577         https://bugs.webkit.org/show_bug.cgi?id=118261
1578
1579         Reviewed by Joseph Pecoraro.
1580
1581         * Scripts/build-webkit: Build WebInspectorUI before WebKit and WebKit2.
1582
1583 2013-07-01  Tim Horton  <timothy_horton@apple.com>
1584
1585         Maximum scroll position can be negative in some cases
1586         https://bugs.webkit.org/show_bug.cgi?id=118175
1587         <rdar://problem/14301217>
1588
1589         Reviewed by Anders Carlsson.
1590
1591         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1592         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp: Added.
1593         (TestWebKitAPI::didRunJavaScript):
1594         (TestWebKitAPI::didLayout):
1595         (TestWebKitAPI::TEST):
1596         * TestWebKitAPI/Tests/WebKit2/lots-of-text-vertical-lr.html: Added.
1597         Add a test that loads a vertical-lr document, paginates it horizontally
1598         from right to left, resizes the view to fit the entire document, and
1599         verifies that the scroll position is negative, as it must be for the
1600         document to be enclosed by the view.
1601
1602 2013-07-01  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1603
1604         [EFL][GTK] Migrate from WEBKITOUTPUTDIR to WEBKIT_OUTPUTDIR
1605         https://bugs.webkit.org/show_bug.cgi?id=117249
1606
1607         Reviewed by Brent Fulgham.
1608
1609         Finish converting all use cases of WEBKITOUTPUTDIR to
1610         WEBKIT_OUTPUTDIR, which seems to be preferred these days.
1611
1612         * DumpRenderTree/efl/FontManagement.cpp:
1613         (getCustomBuildDir):
1614         (getPlatformFontsPath):
1615         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1616         (getOutputDir):
1617         * Scripts/webkitdirs.pm:
1618         (determineBaseProductDir):
1619         (usesPerConfigurationBuildDirectory):
1620         * Scripts/webkitpy/port/base.py:
1621         (Port.to.setup_environ_for_server):
1622         * Scripts/webkitpy/port/driver.py:
1623         (Driver._setup_environ_for_driver):
1624         * Scripts/webkitpy/port/gtk.py:
1625         (GtkPort.setup_environ_for_server):
1626         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1627         (WTR::getOutputDir):
1628         * jhbuild/jhbuildutils.py:
1629         (get_dependencies_path):
1630
1631 2013-07-01  Rafael Brandao  <rafael.lobo@webkit.org>
1632
1633         Unreviewed change of my email address.
1634
1635         * Scripts/webkitpy/common/config/contributors.json:
1636
1637 2013-06-28  Andreas Kling  <akling@apple.com>
1638
1639         Fix Windows builds after deprecatedCharactersWithNullTermination() removal.
1640
1641         * DumpRenderTree/win/DumpRenderTree.cpp:
1642         (addFontFallbackIfPresent):
1643         (removeFontFallbackIfPresent):
1644
1645 2013-06-28  Anders Carlsson  <andersca@apple.com>
1646
1647         Remove String::deprecatedCharactersWithNullTermination() and related code
1648         https://bugs.webkit.org/show_bug.cgi?id=118211
1649
1650         Reviewed by Benjamin Poulain.
1651
1652         Remove all hasTerminatingNullCharacter() checks.
1653
1654         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
1655         (TestWebKitAPI::TEST):
1656         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1657         (TestWebKitAPI::TEST):
1658         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1659         (TestWebKitAPI::TEST):
1660
1661 2013-06-28  Alexey Proskuryakov  <ap@apple.com>
1662
1663         [Mac] Crash when loading is stopped from -didReceiveResponse
1664         https://bugs.webkit.org/show_bug.cgi?id=118209
1665         <rdar://problem/14259249>
1666
1667         Reviewed by Brady Eidson.
1668
1669         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1670         * TestWebKitAPI/Tests/mac/StopLoadingFromDidReceiveResponse.html: Added.
1671         * TestWebKitAPI/Tests/mac/StopLoadingFromDidReceiveResponse.mm: Added.
1672         (-[StopLoadingFromDidReceiveResponse webView:resource:didReceiveResponse:fromDataSource:]):
1673         (TestWebKitAPI::TEST):
1674
1675 2013-06-28  Andy Estes  <aestes@apple.com>
1676
1677         [Mac] Newer versions of clang use a default template instantiation depth that is too small for TestWebKitAPI
1678         https://bugs.webkit.org/show_bug.cgi?id=118208
1679
1680         Reviewed by Mark Rowe.
1681
1682         Newer versions of clang use a default template depth of 128, but this
1683         is too small for Tests/WTF/HashSet.cpp. Use 256 instead, which was the
1684         previous default.
1685
1686         Clang lowered the default to keep recursive template instantiation
1687         from overflowing the stack (see <rdar://problem/13935016>), but
1688         TestWebKitAPI's C++ files don't trigger a stack overflow even with the
1689         higher limit. If for some reason this starts happening then we can
1690         lower the limit back down.
1691
1692         * TestWebKitAPI/Configurations/Base.xcconfig: Build TestWebKitAPI with -ftemplate-depth=256.
1693
1694 2013-06-28  Nick Diego Yamane  <nick.yamane@openbossa.org>
1695
1696         [Tools] Add support for "webKitBranchBuild" git option when calculating jhbuildPath
1697         https://bugs.webkit.org/show_bug.cgi?id=118195
1698
1699         Reviewed by Daniel Bates.
1700
1701         Currently, ports that use jhbuild fail to determine jhbuild directory
1702         when "webKitBranchBuild" git configuration property is enabled. To reproduce
1703         that issue in Efl port, enable that flag in .git/config, switch to a git branch
1704         other than "master" and try to build webkit. The build will fail to
1705         locate dependencies due to lack of pkg-config paths which should be set
1706         by jhbuild.
1707
1708         For more details about "webKitBranchBuild" option, see:
1709         https://trac.webkit.org/wiki/UsingGitWithWebKit
1710
1711         * Scripts/webkitdirs.pm:
1712         (getJhbuildPath):
1713
1714 2013-06-28  Jessie Berlin  <jberlin@apple.com>
1715
1716         WebKitTestRunner should disable automatic quote and dash substitution like DumpRenderTree does
1717         https://bugs.webkit.org/show_bug.cgi?id=118201
1718
1719         Reviewed by Dean Jackson.
1720
1721         * WebKitTestRunner/mac/main.mm:
1722         (main):
1723         Modify NSUserDefaults directly since setAutomaticQuoteSubstitutionEnabled and
1724         setAutomaticDashSubstitutionEnabled are not exposed on WKView.
1725
1726 2013-06-28  David Farler  <dfarler@apple.com>
1727
1728         Upstream WebKit Nightly’s WebKitLauncher
1729         https://bugs.webkit.org/show_bug.cgi?id=117418
1730
1731         Reviewed by Mark Rowe.
1732
1733         Literal patch from Nightly's OpenSource repo.
1734
1735         * WebKitLauncher/Configurations/Base.xcconfig:
1736         * WebKitLauncher/Configurations/WebKitLauncher.xcconfig:
1737         * WebKitLauncher/Info.plist:
1738         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
1739         * WebKitLauncher/WebKitLauncherURLProtocol.m:
1740         (+[WebKitLauncherURLProtocol load]):
1741         (+[WebKitLauncherURLProtocol canInitWithRequest:]):
1742         (-[WebKitLauncherURLProtocol startLoading]):
1743         (-[WebKitLauncherURLProtocol handleWebKitVersionInformation]):
1744         (-[WebKitLauncherURLProtocol resourceNotFound]):
1745         * WebKitLauncher/WebKitNightlyEnablerSparkle.m:
1746         (initializeSparkle):
1747         * WebKitLauncher/main.m:
1748         (determineExecutablePath):
1749         (currentMacOSXVersion):
1750         (main):
1751         * WebKitLauncher/start.html:
1752
1753 2013-06-28  Balazs Kelemen  <b.kelemen@samsung.com>
1754
1755         [EFL] back/forward keyboard shortcuts are non-intuitive
1756         https://bugs.webkit.org/show_bug.cgi?id=118193
1757
1758         Reviewed by Christophe Dumez.
1759
1760         Changed shortcuts for go-back/go-forward to alt+left and alt+right.
1761
1762         * EWebLauncher/main.c:
1763         (on_key_down):
1764         * MiniBrowser/efl/main.c:
1765         (on_key_down):
1766
1767 2013-06-28  Roger Fong  <roger_fong@apple.com>
1768
1769         Enable AVFoundation in Web Prefs for WinLauncher and DumpRenderTree on Windows.
1770         https://bugs.webkit.org/show_bug.cgi?id=118194.
1771
1772         Reviewed by Brent Fulgham.
1773
1774         * DumpRenderTree/win/DumpRenderTree.cpp:
1775         (dllLauncherEntryPoint):
1776         * WinLauncher/WinLauncher.cpp:
1777         (dllLauncherEntryPoint):
1778
1779 2013-06-28  Roger Fong  <roger_fong@apple.com>
1780
1781         Unreviewed build fix for AppleWin port. Fix some file paths.
1782
1783         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
1784         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
1785
1786 2013-06-27  Roger Fong  <roger_fong@apple.com>
1787
1788         Add IAccessibilityDelegate implementation to WinLauncher for testing purposes.
1789         https://bugs.webkit.org/show_bug.cgi?id=118160.
1790
1791         Reviewed by Brent Fulgham.
1792
1793         * WinLauncher/AccessibilityDelegate.cpp: Added.
1794         (AccessibilityDelegate::QueryInterface):
1795         (AccessibilityDelegate::AddRef):
1796         (AccessibilityDelegate::Release):
1797         (AccessibilityDelegate::fireFrameLoadStartedEvents): Just returns S_OK;
1798         (AccessibilityDelegate::fireFrameLoadFinishedEvents): Ditto.
1799         * WinLauncher/AccessibilityDelegate.h: Added.
1800         (AccessibilityDelegate::AccessibilityDelegate):
1801         * WinLauncher/WinLauncher.cpp:
1802         (dllLauncherEntryPoint):
1803         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
1804         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
1805
1806 2013-06-28  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1807
1808         Clean up temporary files created by the bindings test script
1809         https://bugs.webkit.org/show_bug.cgi?id=118189
1810
1811         Reviewed by Kentaro Hara.
1812
1813         Remove temporary files created by preprocess-idls.pl script after
1814         the bindings tests are executed.
1815
1816         Based on Blink 153236 by Kentaro Hara <haraken@chromium.org>.
1817
1818         * Scripts/webkitpy/bindings/main.py:
1819         (BindingsTests.main):
1820
1821 2013-06-26  Dean Jackson  <dino@apple.com>
1822
1823         [Mac] Add Mavericks system font to Test systems
1824         https://bugs.webkit.org/show_bug.cgi?id=118109
1825
1826         Reviewed by Simon Fraser.
1827
1828         OS X Mavericks uses a different font for system controls. Tell DRT and
1829         WKTR about them otherwise they use a fallback font. Unfortunately the
1830         fonts are hidden (not found in the list of available fonts) so I
1831         had to add them manually.
1832
1833         Even though there is only one at the moment, I implemented this
1834         as a set so it will be easier to add new fonts if necessary.
1835
1836         * DumpRenderTree/mac/DumpRenderTree.mm:
1837         (allowedFontFamilySet): Fixed typo.
1838         (systemHiddenFontFamilySet): New method that returns the system control font.
1839         (drt_NSFontManager_availableFonts): Merge the hidden fonts.
1840         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
1841         (WTR::allowedFontFamilySet): Fixed typo.
1842         (WTR::systemHiddenFontFamilySet): As above.
1843         (WTR::wtr_NSFontManager_availableFonts):
1844
1845 2013-06-27  Anders Carlsson  <andersca@apple.com>
1846
1847         Get rid of the last uses of deprecatedCharactersWithNullTermination()
1848         https://bugs.webkit.org/show_bug.cgi?id=118159
1849
1850         Reviewed by Andreas Kling.
1851
1852         Replace calls to deprecatedCharactersWithNullTermination() with charactersWithNullTermination().data().
1853
1854         * DumpRenderTree/win/DumpRenderTree.cpp:
1855         (findFontFallback):
1856
1857 2013-06-27  Bem Jones-Bey  <bjonesbe@adobe.com>
1858
1859         Sync up w3c import script with changes in Blink
1860         https://bugs.webkit.org/show_bug.cgi?id=118149
1861
1862         Reviewed by Dirk Pranke.
1863
1864         This is a port of the following blink changes:
1865
1866         https://codereview.chromium.org/15366004
1867         https://chromiumcodereview.appspot.com/15592005
1868         https://codereview.chromium.org/16021006
1869         https://codereview.chromium.org/15590004
1870         https://codereview.chromium.org/15901008
1871         https://codereview.chromium.org/16171009
1872         https://codereview.chromium.org/16465007
1873         https://codereview.chromium.org/15981013
1874
1875         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1876         (setUp):
1877         (test_commit_message_for_this_commit):
1878         * Scripts/webkitpy/port/base.py:
1879         (Port):
1880         * Scripts/webkitpy/port/test.py:
1881         * Scripts/webkitpy/w3c/test_converter.py:
1882         (W3CTestConverter.__init__):
1883         (W3CTestConverter.read_webkit_prefixed_css_property_list):
1884         (W3CTestConverter.convert_for_webkit):
1885         (W3CTestConverter.convert_css):
1886         (W3CTestConverter.convert_html):
1887         (W3CTestConverter.convert_testharness_paths):
1888         (W3CTestConverter.convert_prefixed_properties):
1889         (W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
1890         * Scripts/webkitpy/w3c/test_converter_unittest.py:
1891         * Scripts/webkitpy/w3c/test_importer.py:
1892         (main):
1893         (configure_logging):
1894         (configure_logging.LogHandler):
1895         (configure_logging.LogHandler.format):
1896         (parse_args):
1897         (TestImporter.__init__):
1898         (TestImporter.find_importable_tests):
1899         (TestImporter.import_tests):
1900         (TestImporter.setup_destination_directory):
1901         (TestImporter.remove_deleted_files):
1902         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1903         (TestImporterTest.test_import_dir_with_no_tests_and_no_hg):
1904         (TestImporterTest.test_import_dir_with_no_tests):
1905         (TestImporterTest):
1906         * Scripts/webkitpy/w3c/test_parser.py:
1907         (TestParser.load_file):
1908         (TestParser.analyze_test):
1909         (TestParser.support_files):
1910         * Scripts/webkitpy/w3c/test_parser_unittest.py:
1911
1912 2013-06-27  Csaba Osztrogonác  <ossy@webkit.org>
1913
1914         [webkitpy] AbstractPatchSequencingCommand should have _prepare_state
1915         https://bugs.webkit.org/show_bug.cgi?id=118128
1916
1917         Reviewed by Ryosuke Niwa.
1918
1919         It is a preparation for a new webkit-patch command: run-tests-touched-by-attachment
1920         https://bugs.webkit.org/show_bug.cgi?id=117831
1921
1922         * Scripts/webkitpy/tool/commands/download.py:
1923         (AbstractPatchSequencingCommand):
1924         (AbstractPatchSequencingCommand._prepare_to_process): Call _prepare_state before prepare_steps.
1925         (AbstractPatchSequencingCommand._process_patch): Use the same initial state for each patch.
1926         (AbstractPatchSequencingCommand._prepare_state): Added.
1927
1928 2013-06-27  Brendan Long  <b.long@cablelabs.com>
1929
1930         [Qt] Build overrides -j when given --makeargs="-sj40"
1931         https://bugs.webkit.org/show_bug.cgi?id=116897
1932
1933         Reviewed by Csaba Osztrogonác.
1934
1935         * Scripts/webkitdirs.pm:
1936         (buildQMakeProjects):
1937         Change regex checking for -j* to also check for -*j*
1938
1939 2013-06-27  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1940
1941         Remove [NoInterfaceObject] from WorkerGlobalScope
1942         https://bugs.webkit.org/show_bug.cgi?id=118071
1943
1944         Reviewed by Kentaro Hara.
1945
1946         Update bindings test script to pass 2 additional parameters
1947         now needed by the preprocess-idls.pl script.
1948
1949         * Scripts/webkitpy/bindings/main.py:
1950         (BindingsTests.generate_supplemental_dependency):
1951         (BindingsTests.main):
1952
1953 2013-06-27  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1954
1955         Fixing some compiler warnings
1956         https://bugs.webkit.org/show_bug.cgi?id=117791
1957
1958         Reviewed by Martin Robinson.
1959
1960         * GNUmakefile.am: Silenced format warning.
1961         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
1962         (TestWebKitAPI::DOMWindowExtensionNoCache::globalObjectIsAvailableForFrame):
1963         Solved warning about uninitialized variable.
1964
1965 2013-06-27  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1966
1967         Fix bindings tests after r152080
1968         https://bugs.webkit.org/show_bug.cgi?id=118118
1969
1970         Reviewed by Gyuyoung Kim.
1971
1972         r152080 renamed argument to preprocess-idls.pl from --workerContextConstructorsFile
1973         to --workerGlobalScopeConstructorsFile. This patch updates to bindings test script
1974         accordingly.
1975
1976         * Scripts/webkitpy/bindings/main.py:
1977         (BindingsTests.generate_supplemental_dependency):
1978         (BindingsTests.main):
1979
1980 2013-06-26  Carlos Garcia Campos  <cargarcia@blackberry.com>
1981
1982         [BlackBerry] Handle testRunner.setCustomPolicyDelegate()
1983         https://bugs.webkit.org/show_bug.cgi?id=117982
1984
1985         Reviewed by Rob Buis.
1986
1987         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1988         (BlackBerry::WebKit::DumpRenderTree::DumpRenderTree): Initialize
1989         m_policyDelegateIsPermissive.
1990         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
1991         Reset m_policyDelegateIsPermissive.
1992         (BlackBerry::WebKit::DumpRenderTree::setCustomPolicyDelegate): Set
1993         m_policyDelegateIsPermissive.
1994         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
1995         (BlackBerry::WebKit::DumpRenderTree::policyDelegateEnabled):
1996         Return whether custom policy is enabled.
1997         (BlackBerry::WebKit::DumpRenderTree::policyDelegateIsPermissive):
1998         Return whether custom policy is permissive.
1999
2000 2013-06-26  Anders Carlsson  <andersca@apple.com>
2001
2002         Deprecate StringImpl::charactersWithNullTermination
2003         https://bugs.webkit.org/show_bug.cgi?id=118108
2004
2005         Reviewed by Beth Dakin.
2006
2007         Rename calls to charactersWithNullTermination to deprecatedCharactersWithNullTermination.
2008
2009         * DumpRenderTree/win/DumpRenderTree.cpp:
2010         (findFontFallback):
2011         (addFontFallbackIfPresent):
2012         (removeFontFallbackIfPresent):
2013
2014 2013-06-26  Nico Weber  <thakis@chromium.org>
2015
2016         Remove detect-mismached-virtual-const.
2017         https://bugs.webkit.org/show_bug.cgi?id=117999
2018
2019         Reviewed by Anders Carlsson.
2020
2021         Clang warns on mismatched virtual const, so there's no need for this
2022         script any more.
2023
2024         * Scripts/detect-mismatched-virtual-const: Removed.
2025
2026 2013-06-26  Alex Christensen  <achristensen@apple.com>
2027
2028         Added a code coverage report.
2029         https://bugs.webkit.org/show_bug.cgi?id=117941
2030
2031         Reviewed by Joseph Pecoraro.
2032
2033         * CodeCoverage: Added.
2034         * CodeCoverage/results-template.html: Added.
2035         * Scripts/generate-coverage-data: Generate and open the new report.
2036
2037 2013-06-25  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2038
2039         gdb: Remove the webcore.py pretty printer.
2040         https://bugs.webkit.org/show_bug.cgi?id=117992
2041
2042         Reviewed by Jochen Eisinger.
2043
2044         webcore.py has been only a placeholder for backwards compatibility
2045         for almost 3 years. It should be safe enough to remove it now.
2046
2047         * gdb/webcore.py: Removed.
2048
2049 2013-05-26  Peter Gal  <galpeter@inf.u-szeged.hu>
2050
2051         Creating cURL watchlist and adding myself to it.
2052
2053         Reviewed by Csaba Osztrogonác.
2054
2055         * Scripts/webkitpy/common/config/watchlist:
2056
2057 2013-06-25  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2058
2059         Unreviewed, change my email address for watch list.
2060
2061         * Scripts/webkitpy/common/config/watchlist:
2062
2063 2013-06-25  Byungwoo Lee  <bw80.lee@samsung.com>
2064
2065         [EFL] Add a script to install dependencies.
2066         https://bugs.webkit.org/show_bug.cgi?id=117968
2067
2068         Reviewed by Christophe Dumez.
2069
2070         Add a script which installs basic dependencies for building WebKit EFL.
2071
2072         The dependencies are from the current EFLWebKit wiki page.
2073         After this patch is landed, the wiki page will be updated to use
2074         this script.
2075
2076         * efl/install-dependencies: Added.
2077
2078 2013-06-24  Dean Jackson  <dino@apple.com>
2079
2080         [Mac] Update font used for Chinese in test systems
2081         https://bugs.webkit.org/show_bug.cgi?id=117970
2082
2083         Reviewed by Alexey Proskuryakov.
2084
2085         Add "Songti TC" and "Songti SC" to the list of allowed fonts
2086         in DRT and WKTR.
2087
2088         * DumpRenderTree/mac/DumpRenderTree.mm:
2089         (allowedFontFamilySet):
2090         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
2091         (WTR::allowedFontFamilySet):
2092
2093 2013-06-24  Tim Horton  <timothy_horton@apple.com>
2094
2095         Make MiniBrowser paginated mode work with WebKit1
2096         https://bugs.webkit.org/show_bug.cgi?id=117950
2097
2098         Reviewed by Beth Dakin.
2099
2100         * MiniBrowser/mac/WK1BrowserWindowController.m:
2101         (-[WK1BrowserWindowController isPaginated]):
2102         (-[WK1BrowserWindowController togglePaginationMode:]):
2103         Hook up isPaginated and togglePaginationMode just as for WebKit2.
2104
2105 2013-06-24  David Kilzer  <ddkilzer@apple.com>
2106
2107         bisect-builds: improve heuristic for choosing the next build after a broken build
2108         <http://webkit.org/b/117918>
2109
2110         Reviewed by Simon Fraser.
2111
2112         * Scripts/bisect-builds: When a build is broken, use a heuristic
2113         that "bisects" the left side or the right side of the remaining
2114         revisions to pick a revision that's sufficiently different from
2115         the revision of the broken build.  This heuristic assumes there
2116         is a sequential range of broken builds whenever one broken build
2117         is found.
2118
2119 2013-06-24  Chris Rogers  <crogers@google.com>
2120
2121         WaveTable name has changed to PeriodicWave
2122         https://bugs.webkit.org/show_bug.cgi?id=117748
2123
2124         Reviewed by Jer Noble.
2125
2126         * Scripts/do-webcore-rename:
2127
2128 2013-06-22  Santosh Mahto  <santosh.ma@samsung.com>
2129
2130         [EFL] Add support for MHTML save/load feature to MiniBrowser
2131         https://bugs.webkit.org/show_bug.cgi?id=106620
2132
2133         Reviewed by Christophe Dumez.
2134
2135         Enable CTRL + S as save page in mhtml and CTRL + L to load any page
2136         from filesystem.
2137
2138         * MiniBrowser/efl/CMakeLists.txt:
2139         * MiniBrowser/efl/main.c:
2140         (page_contents_callback):
2141         (on_key_down):
2142         (show_file_entry_dialog): generic function to show file enrty
2143         selector dialogue
2144
2145 2013-06-21  Brent Fulgham  <bfulgham@apple.com>
2146
2147         [Windows] Unreviewed crash protection for DRT
2148
2149         * DumpRenderTree/win/AccessibilityUIElementWin.cpp: Check for null elements in routines
2150         to avoid crashing during test runs.
2151
2152 2013-06-21  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2153
2154         REGRESSION (r150663): Using webkitAudioContext in Inspector makes it undefined everywhere
2155         https://bugs.webkit.org/show_bug.cgi?id=117825
2156
2157         Reviewed by Kentaro Hara.
2158
2159         DumpRenderTreeSupportEfl::setWebAudioEnabled() now requires an additional view argument.
2160
2161         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2162         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2163         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2164         (TestRunner::overridePreference):
2165
2166 2013-06-21  Krzysztof Czech  <k.czech@samsung.com>
2167
2168         [ATK] Added support for aria-required attribute.
2169         https://bugs.webkit.org/show_bug.cgi?id=117730
2170
2171         Reviewed by Chris Fleizach.
2172
2173         Added support for testing aria-required attribute.
2174
2175         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2176         (AccessibilityUIElement::isRequired):
2177         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2178         (WTR::AccessibilityUIElement::isRequired):
2179
2180 2013-06-20  Ryuan Choi  <ryuan.choi@samsung.com>
2181
2182         [CMAKE][EFL] Enable DOM4 Events Constructor
2183         https://bugs.webkit.org/show_bug.cgi?id=117858
2184
2185         Reviewed by Laszlo Gombos.
2186
2187         * Scripts/webkitperl/FeatureList.pm: Enable the feature for the EFL port.
2188
2189 2013-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2190
2191         [BlackBerry] Handle testRunner.setWillSendRequestReturnsNull() in DRT
2192         https://bugs.webkit.org/show_bug.cgi?id=117827
2193
2194         Reviewed by Rob Buis.
2195
2196         Reset the passed in request if willSendRequestReturnsNull() is
2197         true or willSendRequestReturnsNullOnRedirect() is true and it's a
2198         redirection.
2199
2200         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
2201         (BlackBerry::WebKit::DumpRenderTree::willSendRequestForFrame):
2202         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
2203
2204 2013-06-20  Csaba Osztrogonác  <ossy@webkit.org>
2205
2206         Commit queue shouldn't reopen unrelated bugs because of flakiness
2207         https://bugs.webkit.org/show_bug.cgi?id=117503
2208
2209         Reviewed by Ryosuke Niwa.
2210
2211         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2212         (_follow_duplicate_chain):
2213         (_update_bug_for_flaky_test):
2214
2215 2013-06-19  Brent Fulgham  <bfulgham@apple.com>
2216
2217         [Windows] AX: Expand notification support.
2218         https://bugs.webkit.org/show_bug.cgi?id=117761
2219
2220         Reviewed by Anders Carlsson.
2221
2222         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2223         (AccessibilityUIElement::isPressActionSupported): Provide implementation.
2224         (AccessibilityUIElement::press): Provide implementation.
2225
2226 2013-06-19  Benjamin Poulain  <bpoulain@apple.com>
2227
2228         Use the PlatformEvent timestamp when creating a DOM Event
2229         https://bugs.webkit.org/show_bug.cgi?id=117179
2230
2231         Reviewed by Darin Adler.
2232
2233         * WebKitTestRunner/mac/EventSenderProxy.mm:
2234         (WTR::EventSenderProxy::mouseDown):
2235         (WTR::EventSenderProxy::mouseUp):
2236         (WTR::EventSenderProxy::mouseMoveTo):
2237         (WTR::EventSenderProxy::keyDown):
2238
2239 2013-06-18  Alex Christensen  <achristensen@apple.com>
2240
2241         Working on coverage script, added xml to json data extraction script.
2242         https://bugs.webkit.org/show_bug.cgi?id=117648
2243
2244         This is part of a new test code coverage analysis tool.  This compiles WebKit to generate
2245         coverage data, runs the tests, and collects all of the data in json format.
2246
2247         Reviewed by Stephanie Lewis.
2248
2249         * Scripts/generate-coverage-data:
2250         (parseGcovrOutput):
2251         (getFileHitsAndBranches):
2252         (addLineCounts):
2253         (createResultName):
2254         * Scripts/webkitpy/tool/gcovr: Added.
2255
2256 2013-06-18  Ryuan Choi  <ryuan.choi@samsung.com>
2257
2258         Unreviewed build fix after r151699.
2259
2260         * TestWebKitAPI/CMakeLists.txt:
2261         * WebKitTestRunner/CMakeLists.txt:
2262         Added include dir for InjectedBundleHitTestResultMediaType.h and WKBundleHitTestResult.h
2263
2264 2013-06-18  Roger Fong  <roger_fong@apple.com>
2265
2266         Replace tools32 folder with tools and update WebKit Windows solution accordingly.
2267         <rdar://problem/14118143>.
2268
2269         Rubberstamped by Brent Fulgham.
2270
2271         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2272         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebug.props:
2273         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
2274         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
2275         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherDebug.props:
2276         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherProduction.props:
2277         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherRelease.props:
2278         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeProduction.props:
2279         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeRelease.props:
2280         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
2281         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
2282         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebug.props:
2283         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props:
2284         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2285         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherDebug.props:
2286         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherProduction.props:
2287         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherRelease.props:
2288         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffProduction.props:
2289         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffRelease.props:
2290         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props:
2291         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2292         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginDebug.props:
2293         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginProduction.props:
2294         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginRelease.props:
2295         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2296         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebug.props:
2297         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
2298         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIProduction.props:
2299         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIRelease.props:
2300         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
2301         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
2302         * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props:
2303         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
2304         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props:
2305         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props:
2306         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props:
2307         * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props:
2308         * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props:
2309         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
2310         * win/record-memory/record-memory.vcxproj:
2311         * win/record-memory/record-memoryDebug.props:
2312         * win/record-memory/record-memoryDebugWinCairo.props:
2313         * win/record-memory/record-memoryProduction.props:
2314         * win/record-memory/record-memoryRelease.props:
2315         * win/record-memory/record-memoryReleaseWinCairo.props:
2316
2317 2013-06-17  Kangil Han  <kangil.han@samsung.com>
2318
2319         Unreviewed. Add my email to a DOM watchlist.
2320
2321         * Scripts/webkitpy/common/config/watchlist:
2322
2323 2013-06-17  Zan Dobersek  <zdobersek@igalia.com>
2324
2325         Unreviewed GTK gardening.
2326
2327         * Scripts/run-gtk-tests:
2328         (TestRunner): Skip three WebKit2APITests suites that are currently timing out.
2329
2330 2013-06-15  Bruno de Oliveira Abinader  <brunoabinader@gmail.com>
2331
2332         Unreviewed. Reorder my email addresses.
2333         https://bugs.webkit.org/show_bug.cgi?id=100122
2334
2335         * Scripts/webkitpy/common/config/contributors.json:
2336
2337 2013-06-14  Enrica Casucci  <enrica@apple.com>
2338
2339         WKPageFindStringMatches ignores the kWKFindOptionsBackwards option.
2340         https://bugs.webkit.org/show_bug.cgi?id=117647
2341         <rdar://problem/13881024>
2342
2343         Reviewed by Darin Adler.
2344         
2345         The test now uses content with a selection and tests both
2346         forwards and backward find as well as the case of a find
2347         that has no matches after the user selection.
2348
2349         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2350         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
2351         (TestWebKitAPI::didFindStringMatches):
2352         * TestWebKitAPI/Tests/WebKit2/findRanges.html: Added.
2353
2354 2013-06-14  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
2355
2356         Remove myself from Qt build system watchlist
2357
2358         Reviewed by Simon Hausmann.
2359
2360         * Scripts/webkitpy/common/config/watchlist:
2361
2362 2013-06-13  Michael Brüning  <michael.bruning@digia.com>
2363
2364         [Qt][Mac] Disable QTKit video on OS X.
2365         https://bugs.webkit.org/show_bug.cgi?id=117591
2366
2367         Reviewed by Tor Arne Vestbø.
2368
2369         Deployment of Qt binaries to different Mac OS X
2370         platform version makes it impossible to link against
2371         the correct version of the WebKitSystemInterface library,
2372         so we need to disable QTKit for media elements.
2373
2374         * qmake/mkspecs/features/features.prf:
2375
2376 2013-06-13  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
2377
2378         [EFL][WK2] Wrong context menu and popup menu positions when scroll is applied
2379         https://bugs.webkit.org/show_bug.cgi?id=116610
2380
2381         Reviewed by Noam Rosenthal.
2382
2383         Remove unnecessary code adjusting context menu position to webview position.
2384         Now position is calculcated in EwkView.
2385
2386         * MiniBrowser/efl/main.c:
2387         (on_context_menu_show):
2388
2389 2013-06-12  Roger Fong  <roger_fong@apple.com>
2390
2391         Unreviewed. Turn on WinEWS test now that AppleWin port uses new-run-webkit-tests.
2392
2393         * Scripts/webkitpy/common/config/ews.json:
2394
2395 2013-06-12  Eduardo Lima Mitev  <elima@igalia.com>
2396
2397         [atk] Replace deprecated call to atk_document_get_locale() in DumpRenderTree
2398         https://bugs.webkit.org/show_bug.cgi?id=115647
2399
2400         Reviewed by Martin Robinson.
2401
2402         Locale resolution is moved to WebKitAccessibleWrapperAtk using
2403         AtkObject::get_object_locale() API. Now, implementation of
2404         AccessibilityUIElement::language() in both DumpRenderTree and WebKitTestRunner can
2405         be leveraged to get_object_locale() of AtkObject.
2406
2407         Apart from improving encapsulation, this avoids calling deprecated get_document_locale()
2408         method.
2409
2410         No new functionality, no new tests.
2411
2412         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2413         (AccessibilityUIElement::language): Leverage locale resolution to
2414         AtkObject::get_object_locale().
2415         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2416         (WTR::AccessibilityUIElement::language): Leverage locale resolution to
2417         AtkObject::get_object_locale().
2418
2419 2013-06-12  Hugo Parente Lima  <hugo.lima@openbossa.org>
2420
2421         Remove last bits of GYP from build-webkit and update-webkit scripts
2422         https://bugs.webkit.org/show_bug.cgi?id=117557
2423
2424         Reviewed by Ryosuke Niwa.
2425
2426         * Scripts/build-webkit:
2427         * Scripts/update-webkit:
2428
2429 2013-06-12  Hugo Parente Lima  <hugo.lima@openbossa.org>
2430
2431         Remove forgotten unused Tools/Script/make-gypi script
2432         https://bugs.webkit.org/show_bug.cgi?id=117558
2433
2434         Reviewed by Ryosuke Niwa.
2435
2436         This script isn't used since the GYP removal from WebKit.
2437
2438         * Scripts/make-gypi: Removed.
2439
2440 2013-06-12  Andres Gomez  <agomez@igalia.com>
2441
2442         [GTK] MiniBrowser to automatically download "non-showable" documents when left click in link
2443         https://bugs.webkit.org/show_bug.cgi?id=117533
2444
2445         Reviewed by Carlos Garcia Campos.
2446
2447         MiniBrowser now starts automatically the download of the documents
2448         that cannot be shown just by WebKit itself on link left clicking.
2449
2450         * MiniBrowser/gtk/BrowserWindow.c:
2451         (webViewDecidePolicy): handled the
2452         WEBKIT_POLICY_DECISION_TYPE_RESPONSE decision type too.
2453
2454 2013-06-12  Zan Dobersek  <zdobersek@igalia.com>
2455
2456         [GTK] Remove the WebCoreLayer(Gtk2).a archives before regenerating them
2457         https://bugs.webkit.org/show_bug.cgi?id=116723
2458
2459         Reviewed by Carlos Garcia Campos.
2460
2461         * TestWebKitAPI/GNUmakefile.am: When generating the WebCoreLayer.a archive from all the dependency archives,
2462         remove the current archive (if any). Updating an existent archive in an incremental build is not bulletproof
2463         and can lead to corrupt archives and subsequent build failures. On the other hand, the archive generation is
2464         not expensive and produces a working archive without problems even on incremental builds.
2465
2466 2013-06-11  Santosh Mahto  <santosh.ma@samsung.com>
2467
2468         [EFL] Window resize should close the popupmenu
2469         https://bugs.webkit.org/show_bug.cgi?id=117391
2470
2471         Reviewed by Christophe Dumez.
2472         
2473         Added the code to close the popup when main window is resized.
2474
2475         * MiniBrowser/efl/main.c:
2476         (on_window_resize):
2477
2478 2013-06-11  Alex Christensen  <achristensen@apple.com>
2479
2480         Removed old broken code coverage tool.
2481         https://bugs.webkit.org/show_bug.cgi?id=117520
2482
2483         Reviewed by Sam Weinig.
2484
2485         * CodeCoverage: Removed.
2486         * CodeCoverage/README: Removed.
2487         * CodeCoverage/amber.png: Removed.
2488         * CodeCoverage/cov.py: Removed.
2489         * CodeCoverage/emerald.png: Removed.
2490         * CodeCoverage/gcov.css: Removed.
2491         * CodeCoverage/glass.png: Removed.
2492         * CodeCoverage/regenerate-coverage-display: Removed.
2493         * CodeCoverage/ruby.png: Removed.
2494         * CodeCoverage/run-generate-coverage-data: Removed.
2495         * CodeCoverage/snow.png: Removed.
2496
2497 2013-06-11  Timothy Hatcher  <timothy@apple.com>
2498
2499         Have build-webkit build the WebInspectorUI project.
2500
2501         * Scripts/build-webkit:
2502
2503 2013-06-11  Ryosuke Niwa  <rniwa@webkit.org>
2504
2505         Add an option to run-webkit-tests to skip java dependency check
2506         https://bugs.webkit.org/show_bug.cgi?id=117516
2507
2508         Reviewed by Andreas Kling.
2509
2510         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2511         (parse_args):
2512         * Scripts/webkitpy/port/mac.py:
2513         (MacPort._check_port_build):
2514
2515 2013-06-11  Alex Christensen  <achristensen@apple.com>
2516
2517         https://bugs.webkit.org/show_bug.cgi?id=117514
2518         Removed extra Xcode code coverage flags.
2519
2520         Reviewed by Sam Weinig.
2521
2522         * Scripts/webkitdirs.pm:
2523         (XcodeCoverageSupportOptions):
2524
2525 2013-06-11  Brent Fulgham  <bfulgham@apple.com>
2526
2527         [Windows] Implement 'attributeValue' accessor to support testing
2528         https://bugs.webkit.org/show_bug.cgi?id=117513
2529
2530         Reviewed by Anders Carlsson.
2531
2532         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2533         (comparableObject): Move earlier in file.
2534         (findAccessibleObjectById): New implemenation.
2535         (AccessibilityController::accessibleElementById): New implementation.
2536
2537 2013-06-11  Csaba Osztrogonác  <ossy@webkit.org>
2538
2539         Make WTR use its own temporary directory for application cache
2540         https://bugs.webkit.org/show_bug.cgi?id=117143
2541
2542         Reviewed by Alexey Proskuryakov.
2543
2544         * WebKitTestRunner/TestController.cpp:
2545         (WTR::TestController::initialize):
2546
2547 2013-06-10  Alexey Proskuryakov  <ap@apple.com>
2548
2549         https://bugs.webkit.org/show_bug.cgi?id=117449
2550         Remove dead code for storing fonts in __DATA section
2551
2552         Reviewed by Dan Bernstein.
2553
2554         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2555         Don't copy font resources to __DATA, as we don't have any code that reads them
2556         from there (previously removed due to being under "defined(BUILDING_ON_LEOPARD)").
2557
2558         * DumpRenderTree/mac/DumpRenderTree.mm: (activateTestingFonts):
2559         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm: (WTR::activateFonts):
2560         Removed comments suggesting that we want to restore the old solution.
2561
2562 2013-06-10  Bear Travis  <betravis@adobe.com>
2563
2564         [CSS Shapes][CSS Exclusions] Split CSS Exclusions and CSS Shapes code
2565         https://bugs.webkit.org/show_bug.cgi?id=117162
2566
2567         Reviewed by Alexandru Chiculita.
2568
2569         Adding the WebCore/rendering/shapes directory to the include list.
2570
2571         * DumpRenderTree/efl/CMakeLists.txt:
2572
2573 2013-06-09  Brent Fulgham  <bfulgham@apple.com>
2574
2575         [Windows] Unreviewed test correction:  Prevent DumpRenderTree crashes
2576         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2577         (AccessibilityUIElement::role): Prevent crashes when m_element is null. This
2578         happends in some of the 'accessibility' test cases.
2579
2580 2013-06-08  peavo@outlook.com  <peavo@outlook.com>
2581
2582         [WinCairo] TestWebKitAPI fails to link.
2583         https://bugs.webkit.org/show_bug.cgi?id=117345
2584
2585         Reviewed by Brent Fulgham.
2586
2587         Need to link with WTF.lib.
2588
2589         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Link with WTF.lib.
2590
2591 2013-06-07  Roger Fong  <roger_fong@apple.com>
2592
2593         Get rid of not very helpful test that fails only on some machines because xcrun is not installed.
2594
2595         Rubberstamped by Ryousuke Niwa.
2596
2597         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2598         (RunTest.test_build_check):
2599
2600 2013-06-07  Hugo Parente Lima  <hugo.lima@openbossa.org>
2601
2602         [Qt] Remove Qt bits from Scripts/webkitperl/FeatureList.pm
2603         https://bugs.webkit.org/show_bug.cgi?id=117315
2604
2605         Reviewed by Benjamin Poulain.
2606
2607         Qt doesn't use the default values specified on FeatureList since r44681,
2608         this patch just remove a bit of noise.
2609
2610         * Scripts/webkitperl/FeatureList.pm:
2611
2612 2013-06-07  Jungsik Tae  <davidtlay88@gmail.com>
2613
2614         [EFL] Implement colorpicker for HTML5 input type color on Minibrowser
2615         https://bugs.webkit.org/show_bug.cgi?id=115890
2616
2617         Reviewed by Christophe Dumez.
2618
2619         When user clicks HTML5 input type color,
2620         color selector window is created on browser object by using elm_colorchooser_add().
2621         It can listen a signal dismissing colorpicker by calling the ewk_color_picker_color_set().
2622         The evas_object_color_set() sets a color value returning to browser.
2623
2624         * MiniBrowser/efl/main.c:
2625         (window_free): When we delete parent window, deleting the colorpicker object.
2626         (on_color_changed): Change color of rectangle to show color selected by user.
2627         (on_color_item_selected): Change color of rectangle when clicked color palettes offered by elm_color_chooser().
2628         (on_color_picker_ok_clicked): Call on_colorpicker_dismiss() and set the color.
2629         (on_color_picker_cancel_clicked): Get a preexisting color and call ewk_color_picker_color_set().
2630         (on_color_picker_dismiss): Delete colorpicker object.
2631         (on_color_picker_request): Create colorpicker window object.
2632         (window_create):
2633
2634 2013-06-06  Yuki Sekiguchi  <yuki.sekiguchi@access-company.com>
2635
2636         svn-apply cannot apply patches which is generated by git to files that contain space characters in their path
2637         https://bugs.webkit.org/show_bug.cgi?id=111066
2638
2639         Reviewed by Daniel Bates.
2640
2641         Fixes an issue where parseGitDiffHeader() would extract the wrong substring of the diff --git line as the target file path when the source file path contains a space character.
2642
2643         ParseGitDiffHeader() should support the path which line has space characters.
2644         To support this, I changed parsing algorithm like the following:
2645         - When the diff have prefix, we consider next characters after "b/" as part of a file path.
2646         - When the diff have no prefix, we assume that both path have same directory prefix, and we split the diff line using the prefix.
2647
2648         We only support --src-prefix and --dst-prefix don't contain a non-word character (\W) and end with '/' because we cannot distinguish the prefix from directory path.
2649
2650         If the path has a tab, the patch(1) command thinks file path is characters before the tab.
2651         I added a dummy tab and revision when we convert git diff to svn diff.
2652
2653         * Scripts/VCSUtils.pm:
2654         (parseGitDiffHeader):
2655         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: Update expectations for dummy revision.
2656         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl: Ditto.
2657         * Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl: Ditto.
2658           - Added test case for files which have space in their path and --src-prefix and --dst-prefix option.
2659
2660 2013-06-06  Simon Fraser  <simon.fraser@apple.com>
2661
2662         Add a menu item to MiniBrowser to toggle Transparent windows
2663         https://bugs.webkit.org/show_bug.cgi?id=117316
2664
2665         Reviewed by Anders Carlsson.
2666         
2667         Add a menu item that toggles "Transparent window" mode, which is exposed
2668         via private WebKit API and WebKit2 API.
2669
2670         * MiniBrowser/mac/BrowserWindowController.h:
2671         * MiniBrowser/mac/MainMenu.xib:
2672         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
2673         * MiniBrowser/mac/WK1BrowserWindowController.m:
2674         (-[WK1BrowserWindowController validateMenuItem:]):
2675         (-[WK1BrowserWindowController toggleTransparentWindow:]):
2676         * MiniBrowser/mac/WK2BrowserWindowController.m:
2677         (-[WK2BrowserWindowController validateMenuItem:]):
2678         (-[WK2BrowserWindowController toggleTransparentWindow:]):
2679         (-[WK2BrowserWindowController dumpSourceToConsole:]): Fix a crash that was seen
2680         when testing.
2681
2682 2013-06-06  Roger Fong  <roger_fong@apple.com>
2683
2684         Stop copying AAS binaries into build folder.
2685         https://bugs.webkit.org/show_bug.cgi?id=117319.
2686
2687         Rubberstamped by Darin Adler.
2688
2689         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd:
2690
2691 2013-06-06  Hugo Parente Lima  <hugo.lima@openbossa.org>
2692
2693         Aligning build-webkit command line switch names to the WebKit flag names
2694         https://bugs.webkit.org/show_bug.cgi?id=117254
2695
2696         Reviewed by Laszlo Gombos.
2697
2698         * Scripts/webkitperl/FeatureList.pm: Rename some command line switches.
2699
2700 2013-06-06  Chris Fleizach  <cfleizach@apple.com>
2701
2702         AX: iOS ignores ARIA progressbar elements
2703         https://bugs.webkit.org/show_bug.cgi?id=116727
2704
2705         Reviewed by David Kilzer.
2706
2707         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2708         (AccessibilityUIElement::minValue):
2709         (AccessibilityUIElement::maxValue):
2710
2711 2013-06-06  peavo@outlook.com  <peavo@outlook.com>
2712
2713         [WinCairo] Fix build-webkit to build WinCairo under VS2010.
2714         https://bugs.webkit.org/show_bug.cgi?id=117255
2715
2716         Reviewed by Daniel Bates.
2717
2718         Need to update configuration names according to solution file.
2719
2720         * Scripts/webkitdirs.pm:
2721         (determineConfiguration):
2722         (determinePassedConfiguration):
2723
2724 2013-06-06  Ryosuke Niwa  <rniwa@webkit.org>
2725
2726         Remove run-performance-tests
2727         https://bugs.webkit.org/show_bug.cgi?id=117285
2728
2729         Reviewed by Andreas Kling.
2730         
2731         Remove the script since it's not used anywhere.
2732
2733         * BuildSlaveSupport/run-performance-tests: Removed.
2734
2735 2013-06-05  Bear Travis  <betravis@adobe.com>
2736
2737         [CSS Exclusions][CSS Shapes] Split CSS Exclusions & Shapes compile & runtime flags
2738         https://bugs.webkit.org/show_bug.cgi?id=117172
2739
2740         Reviewed by Alexandru Chiculita.
2741
2742         Adding the CSS_SHAPES compile flag.
2743
2744         * Scripts/webkitperl/FeatureList.pm:
2745         * qmake/mkspecs/features/features.pri:
2746
2747 2013-06-05  Brent Fulgham  <bfulgham@apple.com>
2748
2749         [Windows] Unreviewed build fix. Add CRLF eol-style for DOS shell scripts; if they accidentally change
2750         to UNIX-style they will not execute properly.
2751
2752         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd: Added property svn:eol-style.
2753         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePreBuild.cmd: Added property svn:eol-style.
2754
2755 2013-06-05  Roger Fong  <roger_fong@apple.com>
2756
2757         Unreviewed build fix. Don't pass in --use-remote-links argument on Windows now that we use NRWT.
2758
2759         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2760         (RunWebKitTests.start):
2761
2762 2013-06-05  Brent Fulgham  <bfulgham@apple.com>
2763
2764         [Windows] Switch to NRWT
2765         https://bugs.webkit.org/show_bug.cgi?id=117200
2766
2767         Reviewed by Anders Carlsson.
2768
2769         * Scripts/run-webkit-tests:
2770         (useNewRunWebKitTests): No longer use old-run-webkit-tests for Windows port.
2771
2772 2013-06-05  Dominik Röttsches  <dominik.rottsches@intel.com>
2773
2774         Unreviewed name fix after r150662
2775
2776         My firstname got duplicated when fixing bug 116737.
2777
2778         * Scripts/webkitpy/common/config/contributors.json:
2779
2780 2013-06-05  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2781
2782         Use WEBKITOUTPUTDIR if WEBKIT_OUTPUTDIR is not present.
2783         https://bugs.webkit.org/show_bug.cgi?id=117244
2784
2785         Reviewed by Daniel Bates.
2786
2787         Fixed a regression introduced by r151196: not only does webkit.org
2788         still mention WEBKITOUTPUTDIR instead of WEBKIT_OUTPUTDIR, but the
2789         infrastructure used by ports such as GTK+ and EFL also use on it for
2790         things such as jhbuild.
2791
2792         While everything is not fully transitioned to WEBKIT_OUTPUTDIR, read
2793         both environment variables.
2794
2795         * Scripts/webkitdirs.pm:
2796         (determineBaseProductDir):
2797
2798 2013-06-05  Wojciech Bielawski  <w.bielawski@samsung.com>
2799
2800         [GTK] Forwarding headers not generated for incremental build
2801         https://bugs.webkit.org/show_bug.cgi?id=117198
2802
2803         Reviewed by Carlos Garcia Campos.
2804
2805         * WebKitTestRunner/GNUmakefile.am: libTestRunnerInjectedBundle added to dependencies.
2806
2807 2013-06-05  Andras Becsi  <andras.becsi@digia.com>
2808
2809         [Qt][WK2] Fix layout testing with Qt 5.1
2810         https://bugs.webkit.org/show_bug.cgi?id=117203
2811
2812         Reviewed by Jocelyn Turcotte.
2813
2814         With Qt 5.1 synchronous requests via QNetworkAccessManager do not
2815         go into loading state but directly call handler functions for
2816         finished state instead of relying on a connection.
2817         Our wrapper QQuickView uses a data URI scheme to create the root
2818         item for testing which results in a synchronous request when loading
2819         the QML data, therefore the state of the QQuickWindow immediately
2820         becomes Ready.
2821         Since the final initialization of the root item depended on the
2822         emission of QQuickView::statusChanged(QQuickView::Ready) we ended
2823         up with a partially initialized wrapper window, thus most of our
2824         layout tests were failing.
2825         For compatibility with pre-5.1 Qt versions keep the old behaviour
2826         in case the WrapperWindow is not ready in the constructor yet.
2827
2828         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2829         (WTR::WrapperWindow::WrapperWindow):
2830         * TestWebKitAPI/qt/PlatformWebViewQt.cpp:
2831         (TestWebKitAPI::WrapperWindow::WrapperWindow):
2832
2833 2013-06-05  Dariusz Frankiewicz  <d.frankiewic@samsung.com>
2834
2835         Bad value in tests counter at new-run-webkit-tests
2836         in --debug-rwt-logging mode
2837         https://bugs.webkit.org/show_bug.cgi?id=116858
2838
2839         Reviewed by Dirk Pranke.
2840
2841         Fix by moving counter incrementation, from after printing line,
2842         to before printing. Also changed variable name.
2843
2844         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2845         (LayoutTestRunner.run_tests):
2846         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
2847         (FakePrinter):
2848         * Scripts/webkitpy/layout_tests/views/printing.py:
2849         (Printer.__init__):
2850         (Printer._test_status_line):
2851         (Printer.print_started_test):
2852         (Printer.print_finished_test):
2853         * Scripts/webkitpy/test/printer.py:
2854         (Printer.__init__):
2855         (Printer.print_finished_test):
2856         (Printer._test_line):
2857         (Printer.print_result):
2858
2859 2013-06-05  Zan Dobersek  <zdobersek@igalia.com>
2860
2861         Move MemoryInfo under window.internals
2862         https://bugs.webkit.org/show_bug.cgi?id=117197
2863
2864         Reviewed by Ryosuke Niwa.
2865
2866         * GNUmakefile.am: Add the testing/MemoryInfo.(h|idl) files and the generated targets to
2867         the Automake build
2868         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl: List the
2869         testing/MemoryInfo.idl file instead of page/MemoryInfo.idl.
2870
2871 2013-06-03  Roger Fong  <roger_fong@apple.com>
2872
2873         Remove uses of VS2005 scripts, executables and associated environment variables from scripts.
2874         <rdar://problem/14042021>.
2875
2876         Reviewed by Brent Fulgham.
2877
2878         * Scripts/build-api-tests:
2879         * Scripts/build-dumprendertree:
2880         * Scripts/build-webkit:
2881         * Scripts/update-webkit-dependency:
2882         * Scripts/update-webkit-support-libs:
2883         * Scripts/webkitdirs.pm:
2884         (determineBaseProductDir):
2885         (setupAppleWinEnv):
2886         (setupCygwinEnv):
2887
2888 2013-06-04  Brent Fulgham  <bfulgham@apple.com>
2889
2890         [Windows] NRWT is not putting crash logs in proper place (corrections)
2891         https://bugs.webkit.org/show_bug.cgi?id=117212
2892
2893         Reviewed by Dirk Pranke.
2894
2895         * Scripts/webkitpy/common/system/crashlogs.py:
2896         (CrashLogs.__init__): Accept a result directory argument in constructor.
2897         (CrashLogs.find_newest_log): Don't require 'port' argument anymore.
2898         (CrashLogs._find_newest_log_win): No longer use 'port' argument.
2899         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
2900         (CrashLogsTest.test_find_log_win): Simplify test.
2901         * Scripts/webkitpy/common/system/executive.py:
2902         (Executive.running_pids): Handle "win32" case separately from "cygwin" case.
2903         * Scripts/webkitpy/port/win.py:
2904         (WinPort._get_crash_log): No longer require 'port' argument.
2905
2906 2013-06-04  Ryosuke Niwa  <rniwa@webkit.org>
2907
2908         Build fix after r150592. We need to disable \2 shouldn't be treated as an escape character.
2909
2910         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2911
2912 2013-06-04  Greg Hughes  <ghughes@apple.com>
2913
2914         Add "VisibleOnly" key to search predicate
2915         https://bugs.webkit.org/show_bug.cgi?id=115491
2916
2917         Reviewed by Chris Fleizach.
2918
2919         Added support for accessibility clients to use the search predicate to find only visible elements
2920
2921         * DumpRenderTree/AccessibilityUIElement.cpp:
2922         (uiElementForSearchPredicateCallback):
2923         * DumpRenderTree/AccessibilityUIElement.h:
2924         (AccessibilityUIElement):
2925         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2926         (AccessibilityUIElement::uiElementForSearchPredicate):
2927         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2928         (AccessibilityUIElement::uiElementForSearchPredicate):
2929         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2930         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2931         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2932         (AccessibilityUIElement):
2933         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2934         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2935         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2936
2937 2013-06-04  Brent Fulgham  <bfulgham@apple.com>
2938
2939         [Windows] Unreviewed build fix.  The last check-in lost CR/LF endings on the batch file,
2940         causing build failure.
2941
2942         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd: Revert to
2943         DOS-style CR/LF endings.
2944
2945 2013-06-04  Brent Fulgham  <bfulgham@apple.com>
2946
2947         [Windows] Unreviewed test correction.
2948
2949         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd: Also copy the
2950         QuartzCore dll's, which are needed by TestWebKitAPI.
2951         * TestWebKitAPI/win/main.cpp: Declare proper manfifest dependencies to ensure TestWebKitAPI built
2952         with VS2010 will run when linked against VS2005 support libraries.
2953
2954 2013-06-04  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2955
2956         Automatically generate WorkerContext constructor attributes
2957         https://bugs.webkit.org/show_bug.cgi?id=117183
2958
2959         Reviewed by Kentaro Hara.
2960
2961         Pass new --workerContextConstructorsFile to preprocess-idl.pl for bindings
2962         tests.
2963
2964         * Scripts/webkitpy/bindings/main.py:
2965         (BindingsTests.generate_supplemental_dependency):
2966         (BindingsTests.main):
2967
2968 2013-06-04  Ryuan Choi  <ryuan.choi@samsung.com>
2969
2970         [EFL] File dialog of MiniBrowser have broken background.
2971         https://bugs.webkit.org/show_bug.cgi?id=117189
2972
2973         Reviewed by Christophe Dumez.
2974
2975         * MiniBrowser/efl/main.c:
2976         (on_file_chooser_request): Added elm_bg for elm_win of file chooser.
2977
2978 2013-06-04  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2979
2980         [WKTR][WTK] Undefined symbols in libTestRunnerInjectedBundle.so after r151124
2981         https://bugs.webkit.org/show_bug.cgi?id=117184
2982
2983         Reviewed by Gyuyoung Kim.
2984
2985         Add ATK stubs for mathPostscriptsDescription() and mathPrescriptsDescription() so
2986         that we don't have undefined symbols in libTestRunnerInjectedBundle.so.
2987
2988         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2989         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
2990         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
2991
2992 2013-06-03  Simon Pena  <simon.pena@samsung.com>
2993
2994         validate-committer-lists script is now outdated and does not work
2995         https://bugs.webkit.org/show_bug.cgi?id=115860
2996
2997         Reviewed by Brent Fulgham.
2998
2999         The script validate-committer-lists was outdated, still using the deprecated log
3000         system and having the old addresses for the mailing lists, as well as still referring
3001         to committers.py, after this was renamed to contributors.json. This patch fixes that
3002         so it can be used again.
3003
3004         * Scripts/validate-committer-lists: Replace calls to log and error with the
3005         new logging mechanism, fix the URLs for the mailing lists, and fix the mentions
3006         to committers.py, which should be contributors.json.
3007         (CommitterListFromMailingList):
3008         (CommitterListFromMailingList.check_for_emails_missing_from_list):
3009         (CommitterListFromGit._fetch_authors_and_last_commit_time_from_git_log):
3010         (CommitterListFromGit._fill_in_emails_for_old_logins):
3011         (CommitterListFromGit.print_committers_missing_from_committer_list):
3012
3013 2013-06-03  Dirk Pranke  <dpranke@chromium.org>
3014
3015         add a script to dump the tests run most recently by a given worker
3016         https://bugs.webkit.org/show_bug.cgi?id=116571
3017
3018         Reviewed by Brent Fulgham.
3019
3020         The tests_run*.txt results files in layout-test-results/ were removed
3021         in r137356, in favor of collecting more data about how the tests were
3022         run and compressing it and storing it in stats.json. However, it was
3023         nice to just be able to look at a flat text file.
3024
3025         This script will extract the tests run by a given worker from a
3026         given stats.json file, and should help to address that.
3027
3028         * Scripts/dump-webkit-tests-run: Added.
3029         (main):
3030         (convert_trie_to_flat_paths):
3031
3032 2013-06-03  Brent Fulgham  <bfulgham@apple.com>
3033
3034         [Windows] NRWT is not putting crash logs in proper place
3035         https://bugs.webkit.org/show_bug.cgi?id=117098
3036
3037         Reviewed by Ryosuke Niwa.
3038
3039         Provide windows-specific overloads for various Port features needed to create and capture
3040         crash logs.  This change makes it possible to view crash logs (when created) as part of the
3041         summary report at the end of the NRWT run.
3042
3043         * Scripts/webkitpy/common/system/crashlogs.py:
3044         (CrashLogs.find_newest_log): Add support for win32 crash logs
3045         (CrashLogs._find_newest_log_win): Added
3046         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
3047         (make_mock_crash_report_win): Added
3048         (CrashLogsTest.test_find_log_win): Added.
3049         * Scripts/webkitpy/common/system/executive.py:
3050         (Executive.running_pids): Add support for Cygwin win32 crash logs
3051         * Scripts/webkitpy/common/system/executive_mock.py:
3052         (MockExecutive.__init__):
3053         * Scripts/webkitpy/common/system/filesystem_unittest.py:
3054         (RealFileSystemTest.test_read_and_write_file): Add tests for
3055         malformed ascii/utf8 handling (i.e., Windows log files)
3056         * Scripts/webkitpy/port/base.py:
3057         (Port.find_system_pid): Added
3058         * Scripts/webkitpy/port/server_process.py:
3059         (ServerProcess._start): Gather windows PIDs to match up with Cygwin PIDs
3060         * Scripts/webkitpy/port/win.py:
3061         (WinPort.setup_crash_log_saving): Don't open windows shell (which might get stuck waiting
3062         for user to hit enter.
3063         (WinPort._get_crash_log): Added
3064         (WinPort.look_for_new_crash_logs): Added
3065         (WinPort.find_system_pid): Added
3066         * Scripts/webkitpy/port/win_unittest.py:
3067         (WinPortTest.test_get_crash_log): Added test
3068
3069 2013-06-03  Eduardo Lima Mitev  <elima@igalia.com>
3070
3071         [EFL] Add ATK version 2.8.0 to efl jhbuild moduleset
3072         https://bugs.webkit.org/show_bug.cgi?id=116726
3073
3074         Reviewed by Gyuyoung Kim.
3075
3076         Current version of ATK in efl-ews environment is 2.4.0 and is taken from
3077         the platform (it is not listed in jhbuild moduleset). That version is
3078         old-ish and contain deprecated symbols and missing API, that are blocking
3079         patches in other ports (gtk). This patch adds ATK version 2.8.0 to efl
3080         moduleset, which is the same version the gtk port uses.
3081
3082         See bug https://bugs.webkit.org/show_bug.cgi?id=115647 for more details on
3083         why this is needed.
3084
3085         * efl/jhbuild.modules: Adds ATK module as dependency
3086
3087 2013-06-03  Erik van Pienbroek  <epienbro@fedoraproject.org>
3088
3089         [GTK] Respect PKG_CONFIG env variable when generating gtk-doc
3090         https://bugs.webkit.org/show_bug.cgi?id=117168
3091
3092         Reviewed by Martin Robinson.
3093
3094         The tool generate-gtkdoc internally calls pkg-config.
3095         When cross-compiling it shouldn't use pkg-config, but
3096         it should use the pkg-config which was detected by
3097         the ./configure script (for example this can be
3098         i686-w64-mingw32-pkg-config when cross-compiling)
3099
3100         * GNUmakefile.am:
3101         * gtk/gtkdoc.py:
3102         (PkgConfigGTKDoc.__init__):
3103
3104 2013-06-03  Brent Fulgham  <bfulgham@apple.com>
3105
3106         [Windows] Unreviewed build fix.
3107
3108         * TestWebKitAPI/win/main.cpp: Embed proper manifest information to
3109         allow VS2010 builds to use VS2005 runtime libraries as needed.
3110
3111 2013-06-03  Roger Fong  <roger_fong@apple.com>
3112
3113         Nuke VS2005 files from the tree.
3114         <rdar://problem/14042021>.
3115
3116         Rubberstamped by Brent Fulgham.
3117
3118         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.def: Removed.
3119         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Removed.
3120         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Removed.
3121         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Removed.
3122         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebug.vsprops: Removed.
3123         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugAll.vsprops: Removed.
3124         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugCairoCFLite.vsprops: Removed.
3125         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd: Removed.
3126         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd: Removed.
3127         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops: Removed.
3128         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops: Removed.
3129         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops: Removed.
3130         * DumpRenderTree/TestNetscapePlugIn/win/resource.h: Removed.
3131         * DumpRenderTree/win/DumpRenderTree.vcproj: Removed.
3132         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Removed.
3133         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Removed.
3134         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Removed.
3135         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Removed.
3136         * DumpRenderTree/win/DumpRenderTreeDebug.vsprops: Removed.
3137         * DumpRenderTree/win/DumpRenderTreeDebugAll.vsprops: Removed.
3138         * DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops: Removed.
3139         * DumpRenderTree/win/DumpRenderTreeLauncher.vcproj: Removed.
3140         * DumpRenderTree/win/DumpRenderTreeLauncherCommon.vsprops: Removed.
3141         * DumpRenderTree/win/DumpRenderTreeLauncherDebug.vsprops: Removed.
3142         * DumpRenderTree/win/DumpRenderTreeLauncherDebugAll.vsprops: Removed.
3143         * DumpRenderTree/win/DumpRenderTreeLauncherDebugCairoCFLite.vsprops: Removed.
3144         * DumpRenderTree/win/DumpRenderTreeLauncherProduction.vsprops: Removed.
3145         * DumpRenderTree/win/DumpRenderTreeLauncherRelease.vsprops: Removed.
3146         * DumpRenderTree/win/DumpRenderTreeLauncherReleaseCairoCFLite.vsprops: Removed.
3147         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Removed.
3148         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Removed.
3149         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops: Removed.
3150         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops: Removed.
3151         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops: Removed.
3152         * DumpRenderTree/win/ImageDiff.vcproj: Removed.
3153         * DumpRenderTree/win/ImageDiffCommon.vsprops: Removed.
3154         * DumpRenderTree/win/ImageDiffDebug.vsprops: Removed.
3155         * DumpRenderTree/win/ImageDiffDebugAll.vsprops: Removed.
3156         * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops: Removed.
3157         * DumpRenderTree/win/ImageDiffLauncher.vcproj: Removed.
3158         * DumpRenderTree/win/ImageDiffLauncherCommon.vsprops: Removed.
3159         * DumpRenderTree/win/ImageDiffLauncherDebug.vsprops: Removed.
3160         * DumpRenderTree/win/ImageDiffLauncherDebugAll.vsprops: Removed.
3161         * DumpRenderTree/win/ImageDiffLauncherDebugCairoCFLite.vsprops: Removed.
3162         * DumpRenderTree/win/ImageDiffLauncherProduction.vsprops: Removed.
3163         * DumpRenderTree/win/ImageDiffLauncherRelease.vsprops: Removed.
3164         * DumpRenderTree/win/ImageDiffLauncherReleaseCairoCFLite.vsprops: Removed.
3165         * DumpRenderTree/win/ImageDiffPostBuild.cmd: Removed.
3166         * DumpRenderTree/win/ImageDiffPreBuild.cmd: Removed.
3167         * DumpRenderTree/win/ImageDiffProduction.vsprops: Removed.
3168         * DumpRenderTree/win/ImageDiffRelease.vsprops: Removed.
3169         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops: Removed.
3170         * DumpRenderTree/win/ImageDiffWinCairoCommon.vsprops: Removed.
3171         * Scripts/pdevenv: Removed.
3172         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Removed.
3173         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd: Removed.
3174         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd: Removed.
3175         * WebKitLauncherWin: Removed.
3176         * WebKitLauncherWin/Resource.h: Removed.
3177         * WebKitLauncherWin/WebKitLauncherWin.cpp: Removed.
3178         * WebKitLauncherWin/WebKitLauncherWin.rc: Removed.
3179         * WebKitLauncherWin/WebKitLauncherWin.vcproj: Removed.
3180         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Removed.
3181         * WebKitLauncherWin/WebKitLauncherWinDebug.vsprops: Removed.
3182         * WebKitLauncherWin/WebKitLauncherWinDebugAll.vsprops: Removed.
3183         * WebKitLauncherWin/WebKitLauncherWinDebugCairoCFLite.vsprops: Removed.
3184         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops: Removed.
3185         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops: Removed.
3186         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops: Removed.
3187         * WebKitLauncherWin/webkit.ico: Removed.
3188         * WinLauncher/WinLauncher.ico: Removed.
3189         * WinLauncher/WinLauncher.rc: Removed.
3190         * WinLauncher/WinLauncher.vcproj: Removed.
3191         * WinLauncher/WinLauncherCommon.vsprops: Removed.
3192         * WinLauncher/WinLauncherDebug.vsprops: Removed.
3193         * WinLauncher/WinLauncherDebugAll.vsprops: Removed.
3194         * WinLauncher/WinLauncherDebugCairoCFLite.vsprops: Removed.
3195         * WinLauncher/WinLauncherLauncher.rc: Removed.
3196         * WinLauncher/WinLauncherLauncher.vcproj: Removed.
3197         * WinLauncher/WinLauncherLauncherCommon.vsprops: Removed.
3198         * WinLauncher/WinLauncherLauncherDebug.vsprops: Removed.
3199         * WinLauncher/WinLauncherLauncherDebugAll.vsprops: Removed.
3200         * WinLauncher/WinLauncherLauncherDebugCairoCFLite.vsprops: Removed.
3201         * WinLauncher/WinLauncherLauncherProduction.vsprops: Removed.
3202         * WinLauncher/WinLauncherLauncherRelease.vsprops: Removed.
3203         * WinLauncher/WinLauncherLauncherReleaseCairoCFLite.vsprops: Removed.
3204         * WinLauncher/WinLauncherLauncherResource.h: Removed.
3205         * WinLauncher/WinLauncherPostBuild.cmd: Removed.
3206         * WinLauncher/WinLauncherPreBuild.cmd: Removed.
3207         * WinLauncher/WinLauncherProduction.vsprops: Removed.
3208         * WinLauncher/WinLauncherRelease.vsprops: Removed.
3209         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops: Removed.
3210         * WinLauncher/small.ico: Removed.
3211         * record-memory-win: Removed.
3212         * record-memory-win/main.cpp: Removed.
3213         * record-memory-win/record-memory-win-common.vsprops: Removed.
3214         * record-memory-win/record-memory-win.vcproj: Removed.
3215         * record-memory-win/record-memory-winDebug.vsprops: Removed.
3216         * record-memory-win/record-memory-winDebugAll.vsprops: Removed.
3217         * record-memory-win/record-memory-winDebugCairoCFLite.vsprops: Removed.
3218         * record-memory-win/record-memory-winProduction.vsprops: Removed.
3219         * record-memory-win/record-memory-winRelease.vsprops: Removed.
3220         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops: Removed.
3221
3222 2013-06-03  Chris Fleizach  <cfleizach@apple.com>
3223
3224         AX: MathML multiscripts not exposed in Accessibility
3225         https://bugs.webkit.org/show_bug.cgi?id=115069
3226
3227         Reviewed by Tim Horton.
3228
3229         Add methods to help output components of math multiscripts for accessibility.
3230
3231         * DumpRenderTree/AccessibilityUIElement.cpp:
3232         (mathPostscriptsDescriptionCallback):
3233         (mathPrescriptsDescriptionCallback):
3234         (AccessibilityUIElement::getJSClass):
3235         * DumpRenderTree/AccessibilityUIElement.h:
3236         (AccessibilityUIElement):
3237         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3238         (convertMathMultiscriptPairsToString):
3239         (AccessibilityUIElement::mathPostscriptsDescription):
3240         (AccessibilityUIElement::mathPrescriptsDescription):
3241         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3242         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
3243         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
3244         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3245         (AccessibilityUIElement):
3246         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3247         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3248         (WTR::_convertMathMultiscriptPairsToString):
3249         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
3250         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
3251
3252 2013-06-03  Commit Queue  <commit-queue@webkit.org>
3253
3254         Unreviewed, rolling out r151109.
3255         http://trac.webkit.org/changeset/151109
3256         https://bugs.webkit.org/show_bug.cgi?id=117145
3257
3258         "Plugins in WK2 aren't implemented yet." (Requested by
3259         jturcotte on #webkit).
3260
3261         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3262         * qmake/mkspecs/features/features.prf:
3263         * qmake/mkspecs/features/unix/default_pre.prf:
3264
3265 2013-05-22  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
3266
3267         [Qt] Re-enable plugins on Mac.
3268         https://bugs.webkit.org/show_bug.cgi?id=116622
3269
3270         Reviewed by Tor Arne Vestbø.
3271
3272         Plugins on Mac were only enabled if !embedded but the later was set if
3273         QPA is enabled, which is the default since Qt 5.0.
3274
3275         Remove references to 'embedded' and fix various build issues,
3276         PluginViewMac.mm and PluginPackageMac.cpp haven't been compiled since a few
3277         months.
3278
3279         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3280         * qmake/mkspecs/features/features.prf:
3281         * qmake/mkspecs/features/unix/default_pre.prf:
3282
3283 2013-06-03  Krzysztof Czech  <k.czech@samsung.com>
3284
3285         [GTK][WK2] accessibility/placeholder.html is failing
3286         https://bugs.webkit.org/show_bug.cgi?id=106344
3287
3288         Reviewed by Gyuyoung Kim.
3289
3290         Adds support for retrieving attribute value.
3291
3292         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3293         (WTR::coreAttributeToAtkAttribute):
3294         (WTR::AccessibilityUIElement::stringAttributeValue):
3295
3296 2013-06-01  Tim Horton  <timothy_horton@apple.com>
3297
3298         Add a preferred email address and "expertise" for me.
3299
3300         * Scripts/webkitpy/common/config/contributors.json:
3301
3302 2013-05-31  Roger Fong  <roger_fong@apple.com>
3303
3304         Unreviewed. Make windows test bots search in the correct directory for build output.
3305
3306         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3307         (RunWebKitTests.start):
3308         * Scripts/webkitdirs.pm:
3309         (determineConfigurationProductDir):
3310
3311 2013-05-31  Roger Fong  <roger_fong@apple.com>
3312
3313         Unreviewed. Windows build fix...
3314
3315         * BuildSlaveSupport/built-product-archive:
3316         (createZip):
3317
3318 2013-05-31  Roger Fong  <roger_fong@apple.com>
3319
3320         Unreviewed. Windows build fix. One more time!
3321
3322         * BuildSlaveSupport/built-product-archive:
3323         (archiveBuiltProduct):
3324         (extractBuiltProduct):
3325
3326 2013-05-31  Roger Fong  <roger_fong@apple.com>
3327
3328         Unreviewed. Windows build fix.
3329
3330         * Scripts/build-webkit:
3331
3332 2013-05-31  Roger Fong  <roger_fong@apple.com>
3333
3334         Unreviewed. Windows build fix.
3335
3336         * Scripts/build-webkit:
3337
3338 2013-05-31  Roger Fong  <roger_fong@apple.com>
3339
3340         Make build-webkit output VCExpress 2010 build logs properly.
3341         https://bugs.webkit.org/show_bug.cgi?id=117096
3342
3343         Reviewed by Brent Fulgham.
3344
3345         Make it so that output from VCExpress is always printed to console.
3346         Get build log results from AssembleBuildLogs project output.
3347         We don't need those old VCExpress scripts anymore either. 
3348
3349         * Scripts/build-webkit:
3350         * Scripts/print-msvc-project-dependencies: Removed.
3351         * Scripts/print-vse-failure-logs: Removed.
3352
3353 2013-05-31  Brent Fulgham  <bfulgham@apple.com>
3354
3355         [Windows] Use WinLauncher to display LayoutTest results
3356         https://bugs.webkit.org/show_bug.cgi?id=117085
3357
3358         Reviewed by Oliver Hunt.
3359
3360         * Scripts/webkitdirs.pm:
3361         (runSafari): Use WinLauncher to display content
3362         * WinLauncher/WinLauncher.cpp:
3363         (dllLauncherEntryPoint): Check for URL argument.
3364
3365 2013-05-31  Roger Fong  <roger_fong@apple.com>
3366
3367         Unreviewed. Modify AssembleBuildLogs project to WebKit solution in preparation for moving buildbots to VCExpress 2010.
3368
3369         * win/AssembleBuildLogs/AssembleLogs.cmd:
3370
3371 2013-05-31  Commit Queue  <commit-queue@webkit.org>
3372
3373         Unreviewed, rolling out r151022.
3374         http://trac.webkit.org/changeset/151022
3375         https://bugs.webkit.org/show_bug.cgi?id=117084
3376
3377         Also breaks build by introducing duplicate symbols (Requested
3378         by bfulgham on #webkit).
3379
3380         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
3381
3382 2013-05-31  Brent Fulgham  <bfulgham@apple.com>
3383
3384         [Windows] Unreviewed build fix to NRWT
3385
3386         * Scripts/webkitpy/port/win.py:
3387         (WinPort.create_debugger_command_file): Use proper argument for _filesystem.write_text_file.
3388
3389 2013-05-31  Brent Fulgham  <bfulgham@apple.com>
3390
3391         [Windows] Unreviewed build fix after r151012
3392
3393         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Add dependency on
3394         WTF library to support SHA tests
3395
3396 2013-05-31  Brent Fulgham  <bfulgham@apple.com>
3397
3398         [Windows] Unreviewed build fix after r151012
3399
3400         * TestWebKitAPI/Tests/WTF/MD5.cpp: Include <wtf/StringExtras.h> to provide
3401         snprintf definition for Windows.
3402
3403 2013-05-31  Zan Dobersek  <zdobersek@igalia.com>
3404
3405         Move MD5, SHA1 unit tests from WTF to TestWebKitAPI
3406         https://bugs.webkit.org/show_bug.cgi?id=116445
3407
3408         Reviewed by Benjamin Poulain.
3409
3410         Add the MD5 and SHA1 unit tests that were previously located inside WTF.
3411
3412         * TestWebKitAPI/CMakeLists.txt:
3413         * TestWebKitAPI/GNUmakefile.am:
3414         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3415         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
3416         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3417         * TestWebKitAPI/Tests/WTF/MD5.cpp: Added.
3418         (TestWebKitAPI):
3419         (TestWebKitAPI::expectMD5):
3420         (TestWebKitAPI::TEST):
3421         * TestWebKitAPI/Tests/WTF/SHA1.cpp: Added.
3422         (TestWebKitAPI):
3423         (TestWebKitAPI::expectSHA1):
3424         (TestWebKitAPI::TEST):
3425         * TestWebKitAPI/Tests/WTF/WTF.pro:
3426         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3427
3428 2013-05-30  Brent Fulgham  <bfulgham@apple.com>
3429
3430         [Windows] Unreviewed build correction.
3431
3432         * Scripts/webkitpy/port/win.py:
3433         (WinPort.create_debugger_command_file): The directory needs to be
3434         a string, not a temporary directory object.
3435
3436 2013-05-30  Brent Fulgham  <bfulgham@apple.com>
3437
3438         [Windows] NRWT doesn't save crash logs on Apple's Windows port.
3439         https://bugs.webkit.org/show_bug.cgi?id=76935
3440
3441         Reviewed by Ryosuke Niwa.
3442
3443         Extend the WinPort class with commands to set and clean up various registry
3444         values needed to invoke the correct debugger to get crash files.
3445
3446         * Scripts/webkitpy/port/win.py:
3447         (WinPort): Added global caches for registry keys and settings
3448         (WinPort._ntsd_location): Added
3449         (WinPort.create_debugger_command_file): Added
3450         (WinPort.read_registry_string): Added
3451         (WinPort.write_registry_string): Added
3452         (WinPort.setup_crash_log_saving): Added
3453         (WinPort.restore_crash_log_saving): Added
3454         (WinPort.setup_test_run): Added overload to add registry settings.
3455         (WinPort.clean_up_test_run): Added overload to clean up registry settings.
3456
3457 2013-05-30  Roger Fong  <roger_fong@apple.com>
3458
3459         Get rid of JavaScript exports file on AppleWin port.
3460         https://bugs.webkit.org/show_bug.cgi?id=117050.
3461
3462         Reviewed by Darin Adler.
3463
3464         Start linking in WTF.lib now that it's a shared library.
3465
3466         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
3467         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommon.props:
3468         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
3469
3470 2013-05-30  Ryosuke Niwa  <rniwa@webkit.org>
3471
3472         Web Inspector: tests in PerformanceTests/inspector/ are timing out
3473         https://bugs.webkit.org/show_bug.cgi?id=77024
3474
3475         Reviewed by Andreas Kling.
3476
3477         Remove inspector performance tests since they have been disabled for ages,
3478         and they don't use the standard parser-style performance output.
3479
3480         It's adding a lot of code complexity to our infrastructure.
3481
3482         * Scripts/webkitpy/performance_tests/perftest.py:
3483         (SingleProcessPerfTest.__init__):
3484         (PerfTestFactory):
3485         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3486         (TestPerfTestFactory.test_regular_test):
3487         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
3488         (TestDriver.run_test):
3489         (MainTest.run_test):
3490         (MainTest._tests_for_runner):
3491         (MainTest.test_run_test_set_kills_drt_per_run):
3492         (MainTest._test_run_with_json_output):
3493         (MainTest):
3494         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json):
3495
3496 2013-05-30  Ryosuke Niwa  <rniwa@webkit.org>
3497
3498         Remove requires_http_server as Chromium Android was the only port that needed this
3499         https://bugs.webkit.org/show_bug.cgi?id=117018
3500
3501         Reviewed by Benjamin Poulain.
3502
3503         Removed the unused code that existed for Chromium Android port.
3504
3505         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3506         (LayoutTestRunner.run_tests):
3507         (LayoutTestRunner._handle_finished_test_list):
3508         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3509         (Manager._run_tests):
3510         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3511         (PerfTestsRunner._collect_tests):
3512         (PerfTestsRunner.run):
3513         * Scripts/webkitpy/port/base.py:
3514         (Port.to.start_helper):
3515         * Scripts/webkitpy/port/base_unittest.py:
3516         (PortTest.test_build_path):
3517
3518 2013-05-29  Ruth Fong  <ruth_fong@apple.com>
3519
3520         prepare-Changelog should not be generating namespace-only or class-name-only lines like "(WebCore):"
3521         https://bugs.webkit.org/show_bug.cgi?id=113221
3522
3523         Reviewed by Ryosuke Niwa.
3524
3525         Teach prepare-Changelog to not list the names of modified namespaces, 
3526         classes, or structs in C++ files. Thus, if a change is made 
3527         within a namespace/class/struct yet outside a function, it will 
3528         not be reflected in the ChangeLog entry. 
3529         See https://bugs.webkit.org/show_bug.cgi?id=113221#c8 
3530         for more details on how ChangeLog entries are affected.
3531
3532         * Scripts/prepare-ChangeLog:
3533         (get_function_line_ranges_for_cpp): 
3534         (delete_namespaces_from_ranges_for_cpp): Added.
3535         (is_function_in_namespace): Added.
3536         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt: Updated
3537         to reflect revised definition of a function (i.e. excludes namespaces, classes, structs)
3538
3539 2013-05-29  Praveen R Jadhav  <praveen.j@samsung.com>
3540
3541         Cleanup AudioSourceNode.idl from WebKit build.
3542         https://bugs.webkit.org/show_bug.cgi?id=116905.
3543
3544         Reviewed by Darin Adler.
3545
3546         AudioSourceNode.idl is not part of WebAudio Specifications anymore.
3547         AudioNode is inherited directly in all the audio source nodes.
3548
3549         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
3550
3551 2013-05-29  Andrew Lo  <anlo@rim.com>
3552
3553         Add Andrew Lo to contributors.json
3554         https://bugs.webkit.org/show_bug.cgi?id=116981
3555
3556         Reviewed by Rob Buis.
3557
3558         Adding Andrew Lo to contributors.json.
3559
3560         * Scripts/webkitpy/common/config/contributors.json:
3561
3562 2013-05-29  Adenilson Cavalcanti  <cavalcantii@gmail.com>
3563
3564         Unreviewed. Adding myself as a committer.
3565
3566         * Scripts/webkitpy/common/config/contributors.json:
3567
3568 2013-05-29  Marcelo Lira  <marcelo.lira@openbossa.org>
3569
3570         [WK2][CoordinatedGraphics][EFL] WKViewUserViewportToContents() function doesn't do what it says
3571         https://bugs.webkit.org/show_bug.cgi?id=116683
3572
3573         Reviewed by Noam Rosenthal.
3574
3575         A coordinates conversion test for WKViewUserViewportToContents was
3576         added to WebKit2 API tests.
3577
3578         * TestWebKitAPI/PlatformEfl.cmake:
3579         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp: Added.
3580         (TestWebKitAPI):
3581         (TestWebKitAPI::TEST):
3582
3583 2013-05-29  Yong Li  <yong.li.webkit@outlook.com>
3584
3585         Unreviewed. Update my info.
3586
3587         * Scripts/webkitpy/common/config/contributors.json:
3588
3589 2013-05-29  Dongseong Hwang  <dongseong.hwang@intel.com>
3590
3591         Unreviewed. Add myself as committer in contributors.json.
3592
3593         * Scripts/webkitpy/common/config/contributors.json:
3594
3595 2013-05-29  Carlos Garcia Campos  <cgarcia@igalia.com>
3596
3597         Unreviewed. Fix make distcheck.
3598
3599         * TestWebKitAPI/GNUmakefile.am: Add WebCoreLayer.a to
3600         DISTCLEANFILES.
3601
3602 2013-05-29  Mary Wu  <mawu@blackberry.com>
3603
3604         Unreviewed: update my email address in contributors.json.
3605
3606         * Scripts/webkitpy/common/config/contributors.json:
3607
3608 2013-05-29  Kalyan Kondapally  <kalyan.kondapally@intel.com>
3609
3610         Unreviewed: Adding myself to committers list.
3611
3612         * Scripts/webkitpy/common/config/contributors.json:
3613
3614 2013-05-28  Arpita Bahuguna  <a.bah@samsung.com>
3615
3616         Unreviewed: Adding myself to committers list.
3617
3618         * Scripts/webkitpy/common/config/contributors.json:
3619
3620 2013-05-28  Brent Fulgham  <bfulgham@webkit.org>
3621
3622         [Windows] Many CSS2.1 tests fail under NRWT.
3623         https://bugs.webkit.org/show_bug.cgi?id=75707
3624
3625         Reviewed by Darin Adler.
3626
3627         * DumpRenderTree/win/DumpRenderTree.cpp:
3628         (findFontFallback): Added
3629         (addFontFallbackIfPresent): Added
3630         (removeFontFallbackIfPresent): Added
3631         (runTest): Set up/remove font fallbacks when needed.
3632
3633 2013-05-28  Brent Fulgham  <bfulgham@apple.com>
3634
3635         [Windows] NRWT reports failure for 'mac' test cases.
3636         https://bugs.webkit.org/show_bug.cgi?id=116698
3637
3638         Reviewed by Ryosuke Niwa.
3639
3640         The Windows port falls back to the Mac port for many test results,
3641         and so adds the mac and mac-wk2 to its set of fallbacks.
3642         Unfortunately, NRWT thinks that this means that tests in these
3643         folders should be executed, resulting in many failures on
3644         Windows.
3645
3646         This change overloads the '_tests_for_other_platforms' method
3647         to return a subset of the result fallback list so that we do
3648         not attempt to execute Mac tests on Windows.
3649
3650         * Scripts/webkitpy/port/base.py:
3651         (Port.test_search_path): Added. Defaults to just calling the
3652         baseline_search_path method, which is how most ports behave.
3653         (Port._test_for_other_platforms): Modified to call the new
3654         test_search_path method.
3655
3656         * Scripts/webkitpy/port/win.py:
3657         (WinPort.test_search_path): Added custom overload. Strips
3658         out mac-specific test paths.
3659
3660 2013-05-28  Martin Robinson  <mrobinson@igalia.com>
3661
3662         Fix GTK+ CMake build
3663
3664         * MiniBrowser/gtk/CMakeLists.txt: After r150336, the name of the WebKit2
3665         library target is simply "WebKit2."
3666
3667 2013-05-28  Zan Dobersek  <zdobersek@igalia.com>
3668
3669         [webkitpy] Explicitly specify the reference file extensions
3670         https://bugs.webkit.org/show_bug.cgi?id=116333
3671
3672         Reviewed by Benjamin Poulain.
3673
3674         Explicitly specify the extensions that are valid for the reference files. This helps to differentiate
3675         between valid reference files required by reftests and text baselines that have the same extension as
3676         potential test files (specifically the current MHTML tests in the .mht files and the future .mht baselines
3677         that were until this change recognized as reference files).
3678
3679         Covered by existing tests and the new test_is_reference_html_file test in webkitpy.port.base_unittest.
3680
3681         * Scripts/webkitpy/port/base.py:
3682         (Port.reference_files): Iterate through the _supported_reference_extensions set.
3683         (Port): Rename the _supported_file_extensions set to _supported_test_extensions. Add the
3684         _supported_reference_extensions set, containing the extensions allowed for reference files.
3685         (Port.is_reference_html_file): Return False if the file's extension is not a supported reference file extension.
3686         (Port._has_supported_extension): Use _supported_test_extensions.
3687         * Scripts/webkitpy/port/base_unittest.py:
3688         (PortTest.test_is_reference_html_file): Add the unit test, testing various test cases around the
3689         Port.is_reference_html_file method.
3690
3691 2013-05-26  Ryosuke Niwa  <rniwa@webkit.org>
3692
3693         Yet another WKR build fix. Sorry for the mess. It seems like I can't win today :(
3694
3695         * Scripts/webkitpy/tool/commands/newcommitbot.py:
3696         (NewCommitBot.next_work_item):
3697
3698 2013-05-26  Ryosuke Niwa  <rniwa@webkit.org>
3699
3700         WKR and webkitbot build fixes.
3701
3702         * Scripts/webkitpy/tool/bot/irc_command.py:
3703         (RollChromiumDEPS.execute):
3704         * Scripts/webkitpy/tool/commands/newcommitbot.py:
3705         (NewCommitBot.next_work_item):
3706
3707 2013-05-26  Ryosuke Niwa  <rniwa@webkit.org>
3708
3709         roll-chromium-deps doesn't repeat the full name.
3710
3711         Rubber-stamped by Andreas Kling.
3712
3713         * Scripts/webkitpy/tool/bot/irc_command.py:
3714         (RollChromiumDEPS.execute):
3715
3716 2013-05-25  Ryosuke Niwa  <rniwa@webkit.org>
3717
3718         Revert another erroneous change.
3719
3720         * Scripts/webkitpy/tool/commands/newcommitbot.py:
3721         (NewCommitBot.next_work_item):
3722
3723 2013-05-25  Ryosuke Niwa  <rniwa@webkit.org>
3724
3725         Revert an erroneous change.
3726
3727         * Scripts/webkitpy/tool/commands/sheriffbot.py:
3728         (SheriffBot):
3729
3730 2013-05-25  Ryosuke Niwa  <rniwa@webkit.org>
3731
3732         Some build fixes for WKR and webkitbot.
3733
3734         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
3735         (IRCBotTest.test_help):
3736         * Scripts/webkitpy/tool/commands/newcommitbot.py:
3737         (Agent):
3738         (Agent.__init__):
3739         (Agent.name):
3740         (NewCommitBot):
3741         (NewCommitBot.begin_work_queue):
3742         (NewCommitBot.next_work_item):
3743         * Scripts/webkitpy/tool/commands/sheriffbot.py:
3744         (SheriffBot):
3745
3746 2013-05-25  Ryosuke Niwa  <rniwa@webkit.org>
3747
3748         Teach webkitbot and WKR how to respond to yt?
3749         https://bugs.webkit.org/show_bug.cgi?id=116775
3750
3751         Reviewed by Andreas Kling.
3752
3753         * Scripts/webkitpy/tool/bot/irc_command.py:
3754         (Hi): Fixed the usage string.
3755         (Hi.execute): Made it more generic so that it works in WKR.
3756         (YouThere): Added.
3757         (YouThere.execute): Added.
3758         * Scripts/webkitpy/tool/commands/newcommitbot.py:
3759
3760 2013-05-25  Simon Fraser  <simon.fraser@apple.com>
3761
3762         Try to fix the EFL build.
3763         
3764         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3765         (TestRunner::setPageVisibility):
3766
3767 2013-05-25  Simon Fraser  <simon.fraser@apple.com>
3768
3769         Unprefix Page Visibility API
3770         https://bugs.webkit.org/show_bug.cgi?id=102340
3771
3772         Reviewed by Tim Horton.
3773         
3774         Rename "preview" state to "unloaded" state, and adjust the tests
3775         to test for it.
3776
3777         * DumpRenderTree/mac/TestRunnerMac.mm:
3778         (TestRunner::setPageVisibility):
3779         * TestWebKitAPI/Tests/WebKit2/PageVisibilityState.cpp:
3780         (TestWebKitAPI::setPageVisibilityStateWithEvalContinuation):
3781         (TestWebKitAPI::didRunStep2StateChangeHiddenToPrerender):
3782         (TestWebKitAPI::didRunStep3StateChangePrerenderToUnloaded):
3783         (TestWebKitAPI::didRunStep4InStateUnloaded):
3784         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.html:
3785         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
3786         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
3787         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3788         (WTR::TestRunner::setPageVisibility):
3789
3790 2013-05-24  Brent Fulgham  <bfulgham@apple.com>
3791
3792         Unreviewed build fix. Don't use new NRWT logic needed
3793         by Windows yet. Activate (and fix test) when we cut over.
3794
3795         * Scripts/webkitpy/port/driver.py:
3796         (Driver._setup_environ_for_driver):
3797         (Driver._start):
3798
3799 2013-05-24  Brent Fulgham  <bfulgham@apple.com>
3800
3801         [Windows] Expose database storage and cache locations via preferences.
3802         https://bugs.webkit.org/show_bug.cgi?id=116729
3803
3804         Reviewed by Tim Horton.
3805
3806         Update DumpRenderTree to use CFPreferences to control where WebKit
3807         stores its local databases, URL caches, etc.
3808
3809         * DumpRenderTree/win/DumpRenderTree.cpp:
3810         (libraryPathForDumpRenderTree): Added.
3811         (dllLauncherEntryPoint): Set up DRT-specific cache locations.
3812         * Scripts/webkitpy/port/base.py:
3813         (Port._driver_tempdir): Added (to allow port-specific overload).
3814         (Port._driver_tempdir_for_environment): Ditto
3815         * Scripts/webkitpy/port/driver.py:
3816         (Driver._setup_environ_for_driver): Use new overload to set
3817         environment variable.
3818         (Driver._start): Use new overload for temp directory location.
3819         * Scripts/webkitpy/port/win.py:
3820         (WinPort._driver_tempdir_for_environment): New overload to supply
3821         Windows path to DumpRenderTree environment (while still using
3822         cygwin paths for internal operations.
3823
3824 2013-05-24  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3825
3826         Remove custom code for webkitAudioContext global constructor getter
3827         https://bugs.webkit.org/show_bug.cgi?id=116530
3828
3829         Reviewed by Geoffrey Garen.
3830
3831         Update EFL's DumpRenderTree to use DumpRenderTreeSupport to toggle
3832         WebAudio feature instead of public ewk_view API since that API was
3833         removed.
3834
3835         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3836         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3837         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3838         (TestRunner::overridePreference):
3839
3840 2013-05-24  Bem Jones-Bey  <bjonesbe@adobe.com>
3841
3842         Make team.html have each contributor's area of expertise
3843         https://bugs.webkit.org/show_bug.cgi?id=116737
3844
3845         Reviewed by Benjamin Poulain.
3846
3847         * Scripts/webkitpy/common/config/contributors.json:
3848         Add expertise to each contributor, taken from http://trac.webkit.org/wiki/WebKit%20Team
3849         
3850         Changed formatting of the file because the lines are getting way to
3851         long, and I generated this, so it's easier if the formatting of the
3852         file is regular.
3853
3854 2013-05-24  Simon Pena  <simon.pena@samsung.com>
3855
3856         Update WTF::Vector pretty printers
3857         https://bugs.webkit.org/show_bug.cgi?id=116719
3858
3859         Reviewed by Anders Carlsson.
3860
3861         After r148891, WTF::Vector pretty printers were left outdated, as
3862         the WTF::Vector was made to extend a VectorBuffer, instead of keeping
3863         one as a member. This patch updates the pretty printers so they work
3864         again. 
3865
3866         * gdb/webkit.py:
3867         (WTFVectorPrinter.children):
3868         (WTFVectorPrinter.to_string):
3869
3870 2013-05-24  Steve Falkenburg  <sfalken@apple.com>
3871
3872         Update prepareConsistentTestingEnvironment to use a non-deprecated API.
3873         https://bugs.webkit.org/show_bug.cgi?id=116710
3874
3875         Reviewed by Mark Rowe.
3876
3877         * DumpRenderTree/mac/DumpRenderTree.mm:
3878         (prepareConsistentTestingEnvironment): Use beginActivityWithOptions instead of beginSuspensionOfSystemBehaviors.
3879
3880 2013-05-23  Lauro Neto  <lauro.neto@openbossa.org>
3881
3882         Add missing dependencies to deps script.
3883
3884         [GTK] Missing packages in install-dependencies script.
3885         https://bugs.webkit.org/show_bug.cgi?id=116632
3886
3887         Reviewed by Martin Robinson.
3888
3889         * gtk/install-dependencies:
3890
3891 2013-05-23  Brent Fulgham  <bfulgham@apple.com>
3892
3893         [Windows] Unreviewed change for NRWT support.
3894
3895         * Scripts/webkitpy/port/win.py:
3896         (WinPort.default_child_processes): Added a default implementation
3897         that limits NRWT to a single instance.
3898
3899 2013-05-23  Brent Fulgham  <bfulgham@apple.com>
3900
3901         Remove meaningless "test_uses_apache" from Python test cases.
3902         https://bugs.webkit.org/show_bug.cgi?id=38756
3903
3904         Reviewed by Ryosuke Niwa.
3905
3906         * Scripts/webkitpy/port/port_testcase.py:
3907         (PortTestCase.test_driver_cmd_line): Remove the meaningless
3908         "test_uses_apache" test case from the Python test infrastructure.
3909         It was hard-coded to true, even though not all ports use
3910         Apache.
3911
3912 2013-05-23  Brent Fulgham  <bfulgham@webkit.org>
3913
3914         [Windows] Update new-run-webkit-tests for Windows port.
3915         https://bugs.webkit.org/show_bug.cgi?id=38756
3916
3917         Reviewed by Ryosuke Niwa.
3918
3919         * Scripts/new-run-webkit-httpd:
3920         (run): Switch from 'chromium' to 'win'
3921         * Scripts/webkitpy/port/win.py:
3922         (WinPort): Add support methods for lighttpd server.
3923         (WinPort._uses_apache):
3924         (WinPort._path_to_lighttpd):
3925         (WinPort._path_to_lighttpd_modules):
3926         (WinPort._path_to_lighttpd_php):
3927
3928 2013-05-23  Patrick Gansterer  <paroga@webkit.org>
3929
3930         Make default bug links in buildbot clickable
3931         https://bugs.webkit.org/show_bug.cgi?id=116673
3932
3933         Reviewed by Ryosuke Niwa.
3934
3935         Use changecommentlink of html.WebStatus to make the links clickable.
3936
3937         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3938
3939 2013-05-22  Ryosuke Niwa  <rniwa@webkit.org>
3940
3941         REGRESSION(r150491): WebKit2.DOMWindowExtensionNoCache fails
3942         https://bugs.webkit.org/show_bug.cgi?id=116595
3943
3944         Temporarily skip this test.
3945
3946         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp:
3947         (TestWebKitAPI::TEST):
3948
3949 2013-05-22  Alex Christensen  <achristensen@apple.com>
3950
3951         Unreviewed.  Added myself to contributors.json.
3952
3953         * Scripts/webkitpy/common/config/contributors.json:
3954         Added myself.
3955
3956 2013-05-22  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
3957
3958         [EFL][WK2] Add sub menus to MiniBrowser
3959         https://bugs.webkit.org/show_bug.cgi?id=114728
3960
3961         Reviewed by Christophe Dumez.
3962
3963         Elementary Ctxpopup widget API does not provide support for submenu item.
3964         To implement ewk submenus in Minibrowser, Ctxpopup has to be replaced with
3965         Elementary Menu widget.
3966
3967         * MiniBrowser/efl/main.c:
3968         (_Browser_Window):
3969         (on_window_resize):
3970         (window_free):
3971         (context_menu_item_selected_cb):
3972         (context_menu_populate):
3973         (on_context_menu_show):
3974         (on_context_menu_hide):
3975         (window_create):
3976
3977 2013-05-22  Andrzej Badowski  <a.badowski@samsung.com>
3978
3979         [EFL] Add command line option to MiniBrowser to set cookies policy.
3980         https://bugs.webkit.org/show_bug.cgi?id=115028
3981
3982         Reviewed by Christophe Dumez.
3983
3984         Add command line option to MiniBrowser EFL to set cookies policy:
3985         -p parameter with value from (always, never, no-third-party) respectively (EWK_COOKIE_ACCEPT_POLICY_ALWAYS,
3986         EWK_COOKIE_ACCEPT_POLICY_NEVER, EWK_COOKIE_ACCEPT_POLICY_NO_THIRD_PARTY).
3987
3988         * MiniBrowser/efl/main.c:
3989         (elm_main):
3990
3991 2013-05-21  Ryosuke Niwa  <rniwa@webkit.org>
3992
3993         REGRESSION(r150369): WebKit2WillLoadTest tests are failing
3994         https://bugs.webkit.org/show_bug.cgi?id=116585
3995
3996         Reviewed by Alexey Proskuryakov.
3997
3998         willLoadURLRequest and willLoadDataRequest require the API version 6.
3999
4000         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
4001
4002 2013-05-21  Ryosuke Niwa  <rniwa@webkit.org>
4003
4004         REGRESSION(r150393): editing/inserting/typing-at-end-of-line.html fails
4005         https://bugs.webkit.org/show_bug.cgi?id=116516
4006
4007         Reviewed by Alexey Proskuryakov.
4008
4009         Reset states in DumpRenderTree. The fix for WebKitTestRunner should be implemented in the bug 116577.
4010
4011         * DumpRenderTree/mac/DumpRenderTree.mm:
4012         (createWebViewAndOffscreenWindow): Match the ordering.
4013         (resetWebViewToConsistentStateBeforeTesting): Reset text replacement states.
4014
4015 2013-05-21  Alexey Proskuryakov  <ap@apple.com>
4016
4017         <rdar://problem/13929704> [WK2] WebKitTestRunner always crashes on exit
4018         https://bugs.webkit.org/show_bug.cgi?id=116568
4019
4020         Reviewed by Anders Carlsson.
4021
4022         * WebKitTestRunner/WebNotificationProvider.cpp:
4023         (WTR::WebNotificationProvider::~WebNotificationProvider):
4024         * WebKitTestRunner/WebNotificationProvider.h:
4025         When the provider is destroyed, it should no longer be registered with the manager.
4026
4027         * WebKitTestRunner/GeolocationProviderMock.cpp:
4028         (WTR::GeolocationProviderMock::~GeolocationProviderMock):
4029         * WebKitTestRunner/GeolocationProviderMock.h:
4030         I wasn't seeing a crash here, but this code has the same issue as notification
4031         provider, so applying the same fix.
4032
4033         * WebKitTestRunner/TestController.cpp: (WTR::TestController::~TestController):
4034         Close icon database. I started seeing ASSERT(!isOpen()) in WebCore IconDatabase
4035         destructor having fixed the above.
4036
4037 2013-05-21  Commit Queue  <commit-queue@webkit.org>
4038
4039         Unreviewed, rolling out r150386 and r150397.
4040         http://trac.webkit.org/changeset/150386
4041         http://trac.webkit.org/changeset/150397
4042         https://bugs.webkit.org/show_bug.cgi?id=116572
4043
4044         Broke a test; Alex is going to try again later. (Requested by
4045         thorton on #webkit).
4046
4047         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4048         (WTR::pathSuitableForTestResult):
4049         (WTR::dumpRequestDescriptionSuitableForTestResult):
4050         (WTR::dumpResponseDescriptionSuitableForTestResult):
4051         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
4052         (WTR::InjectedBundlePage::didInitiateLoadForResource):
4053         (WTR::InjectedBundlePage::willSendRequestForFrame):
4054         (WTR::InjectedBundlePage::didReceiveResponseForResource):
4055         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
4056         (InjectedBundlePage):
4057
4058 2013-05-21  Ryosuke Niwa  <rniwa@webkit.org>
4059
4060         Fix a python unittest after r149419. We need to support Python 2.6 on Windows.
4061
4062         * Scripts/webkitpy/tool/commands/suggestnominations.py:
4063         (AbstractCommitLogCommand._recent_commit_messages):
4064
4065 2013-05-21  Martin Robinson  <mrobinson@igalia.com>
4066
4067         [GTK] [CMake] Add support for building WebKit2
4068         https://bugs.webkit.org/show_bug.cgi?id=116372
4069
4070         Reviewed by Gustavo Noronha Silva.
4071
4072         * CMakeLists.txt: Do not build WebKitTestRunner yet for WebKitGTK+.
4073         * MiniBrowser/gtk/CMakeLists.txt: Added.
4074
4075 2013-05-21  Jessie Berlin  <jberlin@apple.com>
4076
4077         Revert r149635, it was too optimistic.
4078
4079         Rubber-stamped by Andreas Kling.
4080
4081         We are not at the point where we can always use more descriptive macros instead of PLATFORM()
4082         #ifdefs in WebCore code outside of WebCore/platform.
4083
4084         * Scripts/webkitpy/style/checkers/cpp.py:
4085         (check_invalid_increment):
4086         (process_line):
4087         (CppChecker):
4088         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4089         (CppStyleTest.test_plain_integral_bitfields):
4090
4091 2013-05-21  Jer Noble  <jer.noble@apple.com>
4092
4093         Unreviewed; fix lldb synthetic representation of WTF::Vector after r148891.
4094
4095         * lldb/lldb_webkit.py:
4096         (WTFVectorProvider.num_children):
4097         (WTFVectorProvider.get_child_index):
4098         (WTFVectorProvider.get_child_at_index):
4099         (WTFVectorProvider.update):
4100
4101 2013-05-21  Jessie Berlin  <jberlin@apple.com>
4102
4103         Expose a way to know when forms are added to a page or when form controls are added to a form
4104         in the injected bundle
4105         https://bugs.webkit.org/show_bug.cgi?id=116334
4106
4107         Reviewed by Alexey Proskuryakov.
4108
4109         Add tests for the new callbacks.
4110
4111         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4112         Add DidAssociateFormControls/_Bundle.cpp and associate-form-controls.html
4113
4114         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp: Added.
4115         (TestWebKitAPI::nullJavaScriptCallback):
4116         A "null" callback to handle the fact that WKPageRunJavaScriptInMainFrame cannot handle null
4117         being passed in for the callback.
4118         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
4119         After receiving the message that didAssociateFormControls callback was invoked from adding
4120         the form in the onload handler, tell the page to add a password field to the form, which
4121         should also invoke didAssociateFormControls callback.
4122         (TestWebKitAPI::setInjectedBundleClient):
4123         Register to receive messages.
4124         (TestWebKitAPI::TEST):
4125         Load associate-form-controls.html and wait until the didAssociateFormControls callback has
4126         been invoked for both adding the form and for adding a password field to the form.
4127
4128         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp: Added.
4129         (TestWebKitAPI::shouldNotifyOnFormChanges):
4130         Return true so the didAssociateFormControls callback is invoked.
4131         (TestWebKitAPI::didAssociateFormControls):
4132         Tell the UI process.
4133         (TestWebKitAPI::DidAssociateFormControlsTest::DidAssociateFormControlsTest):
4134         (TestWebKitAPI::DidAssociateFormControlsTest::didCreatePage):
4135         Register for the shouldNotifyOnFormChanges and didAssociateFormControls callbacks.
4136
4137         * TestWebKitAPI/Tests/WebKit2/associate-form-controls.html: Added.
4138         Add a form in response to the onload event. Add a button that will add the password field
4139         for manual testing.
4140
4141 2013-05-21  Krzysztof Czech  <k.czech@samsung.com>
4142
4143         [GTK][WK2] accessibility/label-for-control-hittest.html is failing
4144         https://bugs.webkit.org/show_bug.cgi?id=106341
4145
4146         Reviewed by Martin Robinson.
4147
4148         Adds support for retrieving accessibility element at exact point.
4149
4150         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4151         (WTR::AccessibilityUIElement::elementAtPoint):
4152
4153 2013-05-21  Krzysztof Czech  <k.czech@samsung.com>
4154
4155         [ATK] [WebKit2] AccessibilityUIElement often leaks its AtkObject
4156         https://bugs.webkit.org/show_bug.cgi?id=112913
4157
4158         Reviewed by Martin Robinson.
4159
4160         AccessibilityUIElement is often created by passing new reference to AtkObject (transfer full).
4161         AccessibilityUIElement::~AccessibilityUIElement does not decrement the reference of the element,
4162         so the leak appears.
4163
4164         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
4165         (WTR):
4166         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
4167         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
4168         (WTR::AccessibilityController::rootElement):
4169         (WTR):
4170         (WTR::AccessibilityController::focusedElement):
4171         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4172         (WTR::checkElementState):
4173         (WTR::indexRangeInTable):
4174         (WTR::alterCurrentValue):
4175         (WTR::AccessibilityUIElement::getChildren):
4176         (WTR::AccessibilityUIElement::getChildrenWithRange):
4177         (WTR::AccessibilityUIElement::childrenCount):
4178         (WTR::AccessibilityUIElement::indexOfChild):
4179         (WTR::AccessibilityUIElement::titleUIElement):
4180         (WTR::AccessibilityUIElement::parentElement):
4181         (WTR::AccessibilityUIElement::allAttributes):
4182         (WTR::AccessibilityUIElement::role):
4183         (WTR::AccessibilityUIElement::title):
4184         (WTR::AccessibilityUIElement::description):
4185         (WTR::AccessibilityUIElement::orientation):
4186         (WTR::AccessibilityUIElement::stringValue):
4187         (WTR::AccessibilityUIElement::language):
4188         (WTR::AccessibilityUIElement::x):
4189         (WTR::AccessibilityUIElement::y):
4190         (WTR::AccessibilityUIElement::width):
4191         (WTR::AccessibilityUIElement::height):
4192         (WTR::AccessibilityUIElement::intValue):
4193         (WTR::AccessibilityUIElement::minValue):
4194         (WTR::AccessibilityUIElement::maxValue):
4195         (WTR::AccessibilityUIElement::isEnabled):
4196         (WTR::AccessibilityUIElement::isFocused):
4197         (WTR::AccessibilityUIElement::isSelected):
4198         (WTR::AccessibilityUIElement::isExpanded):
4199         (WTR::AccessibilityUIElement::isChecked):
4200         (WTR::AccessibilityUIElement::rowCount):
4201         (WTR::AccessibilityUIElement::columnCount):
4202         (WTR::AccessibilityUIElement::rowIndexRange):
4203         (WTR::AccessibilityUIElement::columnIndexRange):
4204         (WTR::AccessibilityUIElement::cellForColumnAndRow):
4205         (WTR::AccessibilityUIElement::increment):
4206         (WTR::AccessibilityUIElement::decrement):
4207         (WTR::AccessibilityUIElement::press):
4208         (WTR::AccessibilityUIElement::documentEncoding):
4209         (WTR::AccessibilityUIElement::documentURI):
4210         (WTR::AccessibilityUIElement::isFocusable):
4211         (WTR::AccessibilityUIElement::isSelectable):
4212         (WTR::AccessibilityUIElement::isMultiSelectable):
4213         (WTR::AccessibilityUIElement::isVisible):
4214
4215 2013-05-20  Lucas Forschler  <lforschler@apple.com>
4216
4217     Rollout 150398.
4218     
4219 2013-05-20  Zan Dobersek  <zdobersek@igalia.com>
4220
4221         [GTK] Fix concatenations of string literals that are not C++11-compliant
4222         https://bugs.webkit.org/show_bug.cgi?id=116449
4223
4224         Reviewed by Martin Robinson.
4225
4226         Fix the problematic concatenations of string literals so they are compilable under the C++11 standard. This
4227         is simply a matter of separating the string and the string literal that are being concatenated with a space.
4228
4229         * ImageDiff/gtk/ImageDiff.cpp:
4230         (printImage):
4231
4232 2013-05-20  Zan Dobersek  <zdobersek@igalia.com>
4233
4234         [GTK] Pass GTEST_HAS_RTTI=0 cppflag to TestWebKitAPI programs at compilation-time
4235         https://bugs.webkit.org/show_bug.cgi?id=116450
4236
4237         Reviewed by Martin Robinson.
4238
4239         The -fno-rtti flag is used when compiling C++ source code throughout the project. The TestWebKitAPI
4240         programs fail to compile because of this when using the C++11 standard as the GTest headers assume by
4241         default that the RTTI support is available. This can be turned off by passing GTEST_HAS_RTTI=0 to the
4242         TestWebKitAPI programs when compiling them.
4243
4244         * TestWebKitAPI/GNUmakefile.am:
4245
4246 2013-05-20  Ryosuke Niwa  <rniwa@webkit.org>
4247
4248         Remove DriverProxy._running_drivers from webkitpy.layout_tests.port
4249         https://bugs.webkit.org/show_bug.cgi?id=116492
4250
4251         Reviewed by Dirk Pranke.
4252
4253         Merge https://chromium.googlesource.com/chromium/blink/+/1af2f0be5a1746784ff114952f29f7b8fa9895f3.
4254
4255         The DriverProxy class had the concept of keeping a pool of started DRTs around (indexed by command line)
4256         so that we didn't necessarily need to restart DRT when the command line for a test changed (e.g., when
4257         starting to run tests in a virtual suite). However, the pool was per-worker (so not shared across the machine)
4258         and we didn't cap the number of processes started, so we would end up with a whole bunch of DRTs (3x-4x
4259         the number of workers started). If anything, this seemed to make the tests slightly slower and probably added
4260         to memory pressure on the machine.
4261
4262         This change removes the pool code; now we'll simply restart DRT when the command line changes. With this change,
4263         we can actually fold the restarting code into Driver itself (and get rid of DriverProxy), but I'll leave that
4264         for a subsequent patch just to make things easier to follow.
4265
4266         * Scripts/webkitpy/port/driver.py:
4267         (DriverProxy.__init__):
4268         (DriverProxy.run_test):
4269         (DriverProxy.has_crashed):
4270         (DriverProxy.stop):
4271
4272 2013-05-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
4273
4274         Change EFL Linux 64-bit Release with EFL Linux 64-bit Release WK1
4275         https://bugs.webkit.org/show_bug.cgi?id=116423
4276
4277         Reviewed by Ryosuke Niwa.
4278
4279         EFL Linux 64-bit Release starts to support WK1's build and layout test from now on.
4280
4281         * BuildSlaveSupport/build.webkit.org-config/config.json:
4282
4283 2013-05-20  Seokju Kwon  <seokju.kwon@gmail.com>
4284
4285         Remove remaining link-prerender code
4286         https://bugs.webkit.org/show_bug.cgi?id=116429
4287
4288         Reviewed by Darin Adler.
4289
4290         Link prerendering code was removed in r150356.
4291
4292         * Scripts/webkitperl/FeatureList.pm:
4293         * qmake/mkspecs/features/features.pri:
4294
4295 2013-05-20  Ryosuke Niwa  <rniwa@webkit.org>
4296
4297         commit-queue should check for oops in changelog entries
4298         https://bugs.webkit.org/show_bug.cgi?id=116395
4299
4300         Reviewed by Martin Robinson.
4301
4302         Make changelog validation fail when it contains oops!.
4303
4304         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
4305         (CommitQueueTask._validate_changelog):
4306         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
4307         (CommitQueueTaskTest._run_through_task):
4308         * Scripts/webkitpy/tool/commands/queues_unittest.py:
4309         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
4310         (ValidateChangeLogs.options):
4311         (ValidateChangeLogs._check_changelog_diff):
4312         (ValidateChangeLogs._changelog_contains_oops):
4313         (ValidateChangeLogs.run):
4314         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
4315         (ValidateChangeLogsTest._assert_start_line_produces_output):
4316         (ValidateChangeLogsTest.test_check_changelog_diff):
4317         (ValidateChangeLogsTest):
4318         (ValidateChangeLogsTest.test_changelog_contains_oops):
4319
4320 2013-05-20  Jessie Berlin  <jberlin@apple.com>
4321
4322         Expose a way to know when forms are added to a page or when form controls are added to a form
4323         in the injected bundle
4324         https://bugs.webkit.org/show_bug.cgi?id=116334
4325
4326         Reviewed by Alexey Proskuryakov.
4327
4328         Add tests for the new callbacks.
4329
4330         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4331         Add DidAssociateFormControls/_Bundle.cpp and associate-form-controls.html
4332
4333         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp: Added.
4334         (TestWebKitAPI::nullJavaScriptCallback):
4335         A "null" callback to handle the fact that WKPageRunJavaScriptInMainFrame cannot handle null
4336        &