One more case of incorrect comparison in recordpatchevent.py
[WebKit-https.git] / Tools / ChangeLog
1 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
2
3         One more case of incorrect comparison in recordpatchevent.py
4         https://bugs.webkit.org/show_bug.cgi?id=137459
5
6         Reviewed by Tim Horton.
7
8         * QueueStatusServer/app.yaml:
9         * QueueStatusServer/loggers/recordpatchevent.py:
10         (RecordPatchEvent.started):
11
12 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
13
14         webkit-queues PatchLog is incorrect for patches that took less than a second
15         https://bugs.webkit.org/show_bug.cgi?id=137453
16
17         Reviewed by Tim Horton.
18
19         * QueueStatusServer/app.yaml: Updated app version.
20
21         * QueueStatusServer/loggers/recordpatchevent.py: (RecordPatchEvent.stopped):
22         Don't bail out for patches that took 0 seconds to process (as frequently happens
23         when a patch is obsolete).
24
25 2014-10-06  Csaba Osztrogonác  <ossy@webkit.org>
26
27         EWS bubble hover shows wrong timestamps
28         https://bugs.webkit.org/show_bug.cgi?id=137252
29
30         Reviewed by Alexey Proskuryakov.
31
32         Add "Z" suffix to timestamps to make sure if it is handled as UTC time.
33
34         * QueueStatusServer/handlers/queuestatusjson.py:
35         (QueueStatusJSON.get):
36         * QueueStatusServer/handlers/statusbubble.py:
37         (StatusBubble._iso_time):
38
39 2014-10-06  Mario Sanchez Prada  <mario@webkit.org>
40
41         Unreviewed, updated list of email addresses in contributors.json
42
43         * Scripts/webkitpy/common/config/contributors.json: Added my former
44         email address in Igalia, for the sake of completeness.
45
46 2014-10-06  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
47
48         Unreviewed, moved myself to the list of committers.
49
50         * Scripts/webkitpy/common/config/contributors.json:
51
52 2014-10-05  Ryuan Choi  <ryuan.choi@gmail.com>
53
54         [EFL] Introduce EWebKit_Extension
55         https://bugs.webkit.org/show_bug.cgi?id=134921
56
57         Reviewed by Gyuyoung Kim.
58
59         * MiniBrowser/efl/main.c: Added x option to test extension path.
60         (window_create):
61         (elm_main):
62         * Scripts/webkitpy/common/config/watchlist:
63         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFLWebKit2PublicAPI.
64         * Scripts/webkitpy/style/checker.py:
65         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFL exceptions.
66
67 2014-10-04  Csaba Osztrogonác  <ossy@webkit.org>
68
69         [jhbuild] Simplify platform detection in update-webkit-libs-jhbuild
70         https://bugs.webkit.org/show_bug.cgi?id=137390
71
72         Reviewed by Carlos Garcia Campos.
73
74         * Scripts/update-webkit-libs-jhbuild:
75
76 2014-10-04  Carlos Garcia Campos  <cgarcia@igalia.com>
77
78         [GTK] Do not generate webkit2gtk-tests-resources.gresource unconditionally
79         https://bugs.webkit.org/show_bug.cgi?id=137391
80
81         Reviewed by Martin Robinson.
82
83         Add a custom command to only re-generate
84         webkit2gtk-tests-resources.gresource when any of its dependencies changes.
85
86         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
87
88 2014-10-04  Carlos Garcia Campos  <cgarcia@igalia.com>
89
90         [GTK] generate-gtkdoc crashes when generating HTML due to encoding issues
91         https://bugs.webkit.org/show_bug.cgi?id=135502
92
93         Reviewed by Martin Robinson.
94
95         When writing to stdout/stderr fails due to a UnicodeDecodeError
96         exception, try again without encoding the output.
97
98         * gtk/gtkdoc.py:
99         (GTKDoc._run_command):
100
101 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
102
103         Bugzilla status bubble displays an exception showing attachment 175738
104         https://bugs.webkit.org/show_bug.cgi?id=137410
105
106         Reviewed by Tim Horton.
107
108         * QueueStatusServer/app.yaml: Update version.
109
110         * QueueStatusServer/handlers/statusbubble.py: (StatusBubble._build_bubble):
111         Don't fail even if expected status message is missing.
112
113         * QueueStatusServer/model/patchlog.py: (PatchLog): Quick unrelated fix - define
114         the field in the same way it's defined in QueueStatus table.
115
116 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
117
118         Record latest message in PatchLog for quick access
119         https://bugs.webkit.org/show_bug.cgi?id=137405
120
121         Fixing a typo.
122
123         * QueueStatusServer/app.yaml:
124         * QueueStatusServer/handlers/releasepatch.py:
125
126 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
127
128         Record latest message in PatchLog for quick access
129         https://bugs.webkit.org/show_bug.cgi?id=137405
130
131         Reviewed by Ryosuke Niwa.
132
133         It's no SQL...
134
135         * QueueStatusServer/handlers/releasepatch.py:
136         * QueueStatusServer/handlers/updatestatus.py:
137         * QueueStatusServer/loggers/recordpatchevent.py:
138         * QueueStatusServer/model/patchlog.py:
139
140 2014-10-02  David Farler  <dfarler@apple.com>
141
142         -asan-blacklist option also renamed to generic -fsanitize-blacklist
143         https://bugs.webkit.org/show_bug.cgi?id=137377
144
145         Reviewed by Daniel Bates.
146
147         * asan/asan.xcconfig:
148         -asan-blacklist -> -fsanitize-blacklist
149
150         http://llvm.org/viewvc/llvm-project?view=revision&revision=212505
151
152 2014-10-03  Roger Fong  <roger_fong@apple.com>
153
154         [Windows] Include batch size argument to layout tests on Windows.
155
156         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
157         (RunWebKitTests.start): 
158         This is a speculative fix for the the inconsistent crashes we are seeing on Windows.
159         These crashes seem to happen on random tests though generally in a spread out fashion.
160         It seems possible that the DRT instance is being clobbered somehow after running too many
161         tests in a row so we will try to mitigate this by just forcing DRT to restart periodically.
162
163 2014-10-03  Roger Fong  <roger_fong@apple.com>
164
165         [Windows] Settle for 2 chid processes running NRWT on Windows.
166
167         * Scripts/webkitpy/port/win.py:
168         (WinPort.default_child_processes): 3 child processes reintroduces the sporadic crashing, will settle for 2.
169
170 2014-10-03  Akos Kiss  <akiss@inf.u-szeged.hu>
171
172         [GTK] Bump up and patch dependencies to allow building for aarch64
173         https://bugs.webkit.org/show_bug.cgi?id=137147
174
175         Reviewed by Martin Robinson.
176
177         The currently used versions of pixman, libffi, librsvg, glib,
178         glib-networking, fontconfig, libxml2, gst-plugins-base fail to configure
179         and/or build for aarch64, so they are bumped up and patched where
180         necessary. Wherever possible, the same versions and patches were used as
181         for the EFL port bump-up
182         (https://bugs.webkit.org/show_bug.cgi?id=135885).
183
184         After the bump-up, a hitherto hidden bug in gst-plugins-good caused a
185         regression by crashing http/tests/media/video-redirect.html . A patch
186         already in upstream fixes that bug.
187
188         This change does not touch xserver, which also needs bumping up, but 
189         will be dealt with later.
190
191         * gtk/jhbuild.modules:
192         Specified versions and patches necessary to correctly build for aarch64.
193         * gtk/patches/gst-events-arent-gstobjects.patch:
194         Added. Patches gst-plugins-good to fix a bug in .mov file demuxing.
195         * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch:
196         Added. Patches gst-plugins-base to configure correctly for aarch64.
197         * gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch:
198         Added. Bumps up config.guess and config.sub in librsvg to recognize
199         aarch64.
200         * gtk/patches/libxml2-2.9.0-dtd.patch:
201         Removed. Not necessary for libxml2 v2.9.1 anymore.
202
203 2014-09-28  Sam Weinig  <sam@webkit.org>
204
205         Remove RefPtrHashMap
206         https://bugs.webkit.org/show_bug.cgi?id=137200
207
208         Reviewed by Darin Adler.
209
210         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
211         (TestWebKitAPI::TEST):
212         Add tests for using a HashMap with RefPtr keys, focusing on ensuring that
213         a minimum of refcount churn occurs.
214
215 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
216
217         Remove workarounds for versions of Python before 2.7
218         https://bugs.webkit.org/show_bug.cgi?id=137338
219
220         Reviewed by Csaba Osztrogonác.
221
222         * Scripts/webkitpy/common/system/autoinstall.py:
223         (AutoInstaller._extract_targz):
224         (AutoInstaller._unzip):
225         (AutoInstaller): Deleted.
226         (AutoInstaller._extract_all): Deleted.
227         * Scripts/webkitpy/common/webkitunittest.py:
228         (TestCase.setUp): Deleted.
229         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
230         (TestConfigurationConverter.collapse_macros):
231         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
232         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
233         (TestConfigurationConverter):
234         (TestConfigurationConverter.combinations): Deleted.
235         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
236         * Scripts/webkitpy/port/base.py:
237
238 2014-10-03  Commit Queue  <commit-queue@webkit.org>
239
240         Unreviewed, rolling out r174264.
241         https://bugs.webkit.org/show_bug.cgi?id=137392
242
243         It broke run-webkit-tests (Requested by ebalazsfalvi on
244         #webkit).
245
246         Reverted changeset:
247
248         "Remove workarounds for versions of Python before 2.7"
249         https://bugs.webkit.org/show_bug.cgi?id=137338
250         http://trac.webkit.org/changeset/174264
251
252 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
253
254         Remove workarounds for versions of Python before 2.7
255         https://bugs.webkit.org/show_bug.cgi?id=137338
256
257         Reviewed by Csaba Osztrogonác.
258
259         * Scripts/webkitpy/common/system/autoinstall.py:
260         (AutoInstaller._extract_targz):
261         (AutoInstaller._unzip):
262         (AutoInstaller): Deleted.
263         (AutoInstaller._extract_all): Deleted.
264         * Scripts/webkitpy/common/webkitunittest.py:
265         (TestCase.setUp): Deleted.
266         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
267         (TestConfigurationConverter.collapse_macros):
268         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
269         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
270         (TestConfigurationConverter):
271         (TestConfigurationConverter.combinations): Deleted.
272         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
273         * Scripts/webkitpy/port/base.py:
274         * Scripts/webkitpy/port/driver.py:
275         (ContentBlock.__init__):
276         * Scripts/webkitpy/port/server_process.py:
277         (ServerProcess._reset):
278
279 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
280
281         Remove autoinstaller workaround for python 2.6
282         https://bugs.webkit.org/show_bug.cgi?id=137343
283
284         Reviewed by Daniel Bates.
285
286         Reverting <http://trac.webkit.org/changeset/124928>, neither Python
287         2.6, nor Snow Leopard is supported anymore, so the workaround is not
288         needed anymore.
289
290         * Scripts/webkitpy/common/system/autoinstall.py:
291         (AutoInstaller.install):
292         * Scripts/webkitpy/test/main.py:
293         (Tester._run_tests):
294         * Scripts/webkitpy/thirdparty/__init__.py:
295         (AutoinstallImportHook._install_mechanize):
296         (AutoinstallImportHook._install_pep8):
297         (AutoinstallImportHook._install_pylint):
298         (AutoinstallImportHook._install_buildbot):
299         (AutoinstallImportHook._install_coverage):
300         (AutoinstallImportHook._install_eliza):
301         (AutoinstallImportHook._install_irc):
302         (AutoinstallImportHook._install):
303         (autoinstall_everything):
304
305 2014-10-02  Daniel Bates  <dabates@apple.com>
306
307         Use version number 101000 instead of 10100 for OS X Yosemite
308         https://bugs.webkit.org/show_bug.cgi?id=137372
309
310         Reviewed by Mark Rowe.
311
312         The version number for OS X Yosemite is 101000.
313
314         * DumpRenderTree/mac/TextInputController.m:
315
316 2014-10-02  Alexey Proskuryakov  <ap@apple.com>
317
318         update-work-items should never delete items
319         https://bugs.webkit.org/show_bug.cgi?id=137366
320
321         Reviewed by Ryosuke Niwa.
322
323         As we don't just replace the whole list any more, indicate which items are high
324         priority, and which are not. Hight priority ones will be prepended to the queue,
325         others will be appended.
326
327         This creates a bit of unfairness in that high priority item queue becomes a LIFO.
328         But hopefully we will never have many rollouts competing like that.
329
330         * QueueStatusServer/app.yaml: Update version.
331
332         * QueueStatusServer/handlers/updateworkitems.py: Never remove items. Pass high
333         priority and regular items separately. Removed some error handling that used to
334         end up in returning status 500 - an uncaught exception does that automatically.
335
336         * QueueStatusServer/main.py: Removed unnecessary regexps from URL matching code.
337
338         * QueueStatusServer/model/workitems.py: Added a way to add high priority items.
339
340         * QueueStatusServer/templates/updateworkitems.html: Added a field for high
341         priority items.
342
343         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
344         (BugzillaQueries._parse_attachment_ids_request_query): Removed an annoying log
345         line that complicated testing.
346
347         * Scripts/webkitpy/common/net/statusserver.py: Pass high priority items separately.
348
349         * Scripts/webkitpy/tool/bot/feeders.py: For commit queue, split high and regular
350         priority items into separate lists.
351
352         * Scripts/webkitpy/common/net/statusserver_mock.py:
353         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
354         * Scripts/webkitpy/tool/commands/queues_unittest.py:
355         Updated tests.
356
357 2014-10-02  Brendan Long  <b.long@cablelabs.com>
358
359         Annoying build warnings in WTFString API tests
360         https://bugs.webkit.org/show_bug.cgi?id=137360
361
362         Reviewed by Darin Adler.
363
364         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
365         (TestWebKitAPI::TEST): Change EXPECT_EQ(false, ok) to EXPECT_FALSE(ok) and EXPECT_EQ(true, ok) to EXPECT_TRUE(ok).
366
367 2014-10-02  Roger Fong  <roger_fong@apple.com>
368
369         [Windows] The number of processes did not affect the crash inconsistency, increase number of child processes again.
370
371         * Scripts/webkitpy/port/win.py:
372         (WinPort.default_child_processes): Ambitiously try 3 processes the testers are too slow now.
373
374 2014-10-02  David Farler  <dfarler@apple.com>
375
376         Move ASan arguments from LLVM (-mllvm) to the frontend
377         https://bugs.webkit.org/show_bug.cgi?id=137365
378
379         Reviewed by David Kilzer.
380
381         * asan/asan.xcconfig:
382         Remove the -mllvm prefix to the asan-blacklist argument, moving it
383         to the clang frontend.
384
385         http://llvm.org/viewvc/llvm-project?view=revision&revision=212505
386
387 2014-10-02  Commit Queue  <commit-queue@webkit.org>
388
389         Unreviewed, rolling out r174120.
390         https://bugs.webkit.org/show_bug.cgi?id=137350
391
392         While number of failures is reasonable with 2 processes, test
393         results seem to be inconsistent between runs (Requested by
394         rfong on #webkit).
395
396         Reverted changeset:
397
398         "[Windows] Back to 2 child processes for NRWT on Windows."
399         http://trac.webkit.org/changeset/174120
400
401 2014-10-02  Jeff Miller  <jeffm@apple.com>
402
403         DumpRenderTree and WebKitTestRunner should use WebKitystemInterfaceYosemite when building on Yosemite
404         https://bugs.webkit.org/show_bug.cgi?id=137347
405
406         Reviewed by Dan Bernstein.
407
408         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
409         Use WebKitSystemInterfaceYosemite on OS X 10.10.
410
411         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
412         Ditto.
413
414 2014-10-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
415
416         [GTK] [JHBuild] Switch sourceware.org mirror to http.
417
418         Unreviewed.
419
420         The ftp access is recently failing to work as expected, and the
421         bots fail to download the file.
422         The same mirror is available via http and seems to work better.
423
424         * gtk/jhbuild.modules:
425
426 2014-10-01  Commit Queue  <commit-queue@webkit.org>
427
428         Unreviewed, rolling out r174185.
429         https://bugs.webkit.org/show_bug.cgi?id=137334
430
431         Patch that adds logging causes webkitpy failures (Requested by
432         rfong on #webkit).
433
434         Reverted changeset:
435
436         "commitqueuetasks_unittest references a non-existent member
437         variable"
438         https://bugs.webkit.org/show_bug.cgi?id=137303
439         http://trac.webkit.org/changeset/174185
440
441 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
442
443         EWS and Commit Queue should know better than to spew 500 failed
444         results in the case of extremely red patches.
445         https://bugs.webkit.org/show_bug.cgi?id=137324
446
447         Reviewed by Alexey Proskuryakov.
448
449         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
450         Adds a check for did_exceed_test_failure_limit.
451         (AbstractEarlyWarningSystem._failing_tests_message):
452         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
453         Alters the task mock to respond properly to
454         results_from_patch_test_run(patch)
455         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
456         * Scripts/webkitpy/tool/commands/queues.py:
457         Adds a check for did_exceed_test_failure_limit.
458         (CommitQueue._failing_tests_message):
459
460 2014-10-01  Daniel Bates  <dabates@apple.com>
461
462         Unreviewed, rolling out r174192.
463
464         Revert the unit test fix in r174192 since we reverted r174187
465         in r174194 due to correctness issues. See
466         <http://webkit.org/b/137329> for more details.
467
468         Reverted changeset:
469
470         "Test fix after r174187"
471         http://trac.webkit.org/changeset/174192
472
473 2014-10-01  Mark Rowe  <mrowe@apple.com>
474
475         <https://webkit.org/b/137308> WebKit should build on OS X Yosemite for external users
476
477         Reviewed by Dan Bernstein.
478
479         * Scripts/copy-webkitlibraries-to-product-directory: Copy libWebKitSystemInterfaceYosemite.a
480         into the build directory. Use LLVMIncludesYosemite.tar.bz2 and LLVMLibrariesYosemite.tar.bz2
481         for the LLVM components when on Yosemite.
482
483 2014-10-01  Commit Queue  <commit-queue@webkit.org>
484
485         Unreviewed, rolling out r174187.
486         https://bugs.webkit.org/show_bug.cgi?id=137329
487
488         webkitpy failures, and thorton says the patch is wrong
489         (Requested by dethbakin on #webkit).
490
491         Reverted changeset:
492
493         "[Windows] Increase layout test timeout for Windows following
494         r174162."
495         http://trac.webkit.org/changeset/174187
496
497 2014-10-01  Brent Fulgham  <bfulgham@apple.com>
498
499         Test fix after r174187
500
501         * Scripts/webkitpy/port/win_unittest.py:
502         (WinPortTest.test_default_timeout_ms): Expect the new 50000 ms timeout for Windows tests.
503
504 2014-10-01  Roger Fong  <roger_fong@apple.com>
505
506         [Windows] Increase layout test timeout for Windows following r174162.
507
508         * Scripts/webkitpy/port/win.py:
509         (WinPort.default_timeout_ms):
510
511 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
512
513         commitqueuetasks_unittest references a non-existent member variable
514         when mock-reporting flaky tests.
515         https://bugs.webkit.org/show_bug.cgi?id=137303
516
517         Reviewed by Daniel Bates.
518
519         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
520         (MockCommitQueue.report_flaky_tests):
521         Makes the appropriate name change.
522         (test_simple_flaky_test_failure):
523         Adds a unit test to make sure that the code is excercised.
524
525 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
526
527         EWS is inconclusively spinning forever on a patch that breaks 500+
528         tests
529         https://bugs.webkit.org/show_bug.cgi?id=137223
530
531         Reviewed by Tim Horton.
532
533         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
534         Checks to see whether the tests have exceeded the failure limit, and
535         only spins off another test if they have not exceeded the limit.
536         (PatchAnalysisTask._test_patch):
537
538 2014-10-01  Brian J. Burg  <burg@cs.washington.edu>
539
540         Unreviewed, add Katie Madonna as a contributor.
541
542         * Scripts/webkitpy/common/config/contributors.json:
543
544 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
545
546         commitqueuetasks_unittest does not construct FailingTestCommitQueue
547         objects properly in its test cases.
548         https://bugs.webkit.org/show_bug.cgi?id=137281
549
550         Reviewed by Daniel Bates.
551
552         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
553         (FailingTestCommitQueue.test_results):
554         Adds an assert to make FailingTestCommitQueue harder to mis-use.
555         (test_double_flaky_test_failure):
556         Nests the intended test failure strings into one-length lists.
557         (test_red_test_failure):
558         Nests the intended test failure strings into one-length lists.
559
560 2014-10-01  Alexey Proskuryakov  <ap@apple.com>
561
562         REGRESSION (r172172): Multiple regression tests fail when primary system language is Russian
563         https://bugs.webkit.org/show_bug.cgi?id=136987
564
565         Reviewed by Daniel Bates.
566
567         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues):
568         Specify the default encoding for all WebKit developers to get consistent results.
569
570 2014-10-01  Alexey Proskuryakov  <ap@apple.com>
571
572         EWS is too eager to say that a patch does not apply to trunk of repository
573         https://bugs.webkit.org/show_bug.cgi?id=137290
574
575         Reviewed by Ryosuke Niwa.
576
577         * QueueStatusServer/app.yaml: Updated app version.
578
579         * QueueStatusServer/handlers/statusbubble.py:
580         (StatusBubble._build_bubble):
581         (StatusBubble._build_bubbles_for_attachment):
582         Rewrote to make more sense.
583
584 2014-09-30  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
585
586         Remove thirdparty/unittest2 from webkitpy
587         https://bugs.webkit.org/show_bug.cgi?id=137251
588
589         Reviewed by Brent Fulgham.
590
591         Additionally ordered imports in related webkitpy files and
592         removed unnecessary shebangs from unittest files.
593
594         * BuildSlaveSupport/build.webkit.org-config/htdigestparser_unittest.py:
595         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
596         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
597         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
598         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
599         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
600         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
601         * Scripts/webkitpy/common/config/committers_unittest.py:
602         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
603         * Scripts/webkitpy/common/config/contributionareas_unittest.py:
604         * Scripts/webkitpy/common/config/ports_unittest.py:
605         * Scripts/webkitpy/common/config/urls_unittest.py:
606         * Scripts/webkitpy/common/editdistance_unittest.py:
607         * Scripts/webkitpy/common/find_files_unittest.py:
608         * Scripts/webkitpy/common/lru_cache_unittest.py:
609         * Scripts/webkitpy/common/memoized_unittest.py:
610         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py:
611         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
612         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
613         * Scripts/webkitpy/common/net/credentials_unittest.py:
614         * Scripts/webkitpy/common/net/failuremap_unittest.py:
615         * Scripts/webkitpy/common/net/irc/ircproxy_unittest.py:
616         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
617         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
618         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
619         * Scripts/webkitpy/common/net/statusserver_unittest.py:
620         * Scripts/webkitpy/common/net/unittestresults_unittest.py:
621         * Scripts/webkitpy/common/newstringio_unittest.py:
622         * Scripts/webkitpy/common/prettypatch_unittest.py:
623         * Scripts/webkitpy/common/read_checksum_from_png_unittest.py:
624         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
625         * Scripts/webkitpy/common/system/environment_unittest.py:
626         * Scripts/webkitpy/common/system/executive.py: Ordered imports.
627         * Scripts/webkitpy/common/system/executive_mock.py: Ordered imports.
628         * Scripts/webkitpy/common/system/executive_unittest.py:
629         * Scripts/webkitpy/common/system/file_lock_integrationtest.py:
630         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
631         * Scripts/webkitpy/common/system/filesystem_unittest.py:
632         * Scripts/webkitpy/common/system/logtesting.py:
633         * Scripts/webkitpy/common/system/logutils_unittest.py:
634         * Scripts/webkitpy/common/system/outputcapture.py:
635         * Scripts/webkitpy/common/system/outputcapture_unittest.py:
636         * Scripts/webkitpy/common/system/outputtee_unittest.py:
637         * Scripts/webkitpy/common/system/path_unittest.py:
638         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
639         * Scripts/webkitpy/common/system/profiler_unittest.py:
640         * Scripts/webkitpy/common/system/stack_utils_unittest.py:
641         * Scripts/webkitpy/common/system/user_unittest.py:
642         * Scripts/webkitpy/common/system/workspace_unittest.py:
643         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
644         * Scripts/webkitpy/common/thread/messagepump_unittest.py:
645         * Scripts/webkitpy/common/thread/threadedmessagequeue_unittest.py:
646         * Scripts/webkitpy/common/watchlist/amountchangedpattern_unittest.py:
647         * Scripts/webkitpy/common/watchlist/changedlinepattern_unittest.py:
648         * Scripts/webkitpy/common/watchlist/filenamepattern_unittest.py:
649         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py:
650         * Scripts/webkitpy/common/watchlist/watchlistrule_unittest.py:
651         * Scripts/webkitpy/common/webkitunittest.py:
652         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
653         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
654         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
655         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
656         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
657         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
658         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
659         * Scripts/webkitpy/layout_tests/models/test_failures_unittest.py:
660         * Scripts/webkitpy/layout_tests/models/test_results_unittest.py:
661         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
662         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
663         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
664         * Scripts/webkitpy/layout_tests/servers/http_server_base_unittest.py:
665         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
666         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
667         * Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py:
668         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
669         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
670         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
671         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
672         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
673         * Scripts/webkitpy/port/base_unittest.py:
674         * Scripts/webkitpy/port/builders_unittest.py:
675         * Scripts/webkitpy/port/config_unittest.py:
676         * Scripts/webkitpy/port/driver_unittest.py:
677         * Scripts/webkitpy/port/efl_unittest.py:
678         * Scripts/webkitpy/port/factory_unittest.py:
679         * Scripts/webkitpy/port/gtk_unittest.py:
680         * Scripts/webkitpy/port/http_lock_unittest.py:
681         * Scripts/webkitpy/port/image_diff_unittest.py:
682         * Scripts/webkitpy/port/leakdetector_unittest.py:
683         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py:
684         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
685         * Scripts/webkitpy/port/mock_drt_unittest.py:
686         * Scripts/webkitpy/port/port_testcase.py:
687         * Scripts/webkitpy/port/server_process_unittest.py:
688         * Scripts/webkitpy/port/westondriver_unittest.py:
689         * Scripts/webkitpy/port/win_unittest.py:
690         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
691         * Scripts/webkitpy/style/checker_unittest.py:
692         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
693         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
694         * Scripts/webkitpy/style/checkers/common_unittest.py:
695         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
696         * Scripts/webkitpy/style/checkers/exportfile_unittest.py:
697         * Scripts/webkitpy/style/checkers/js_unittest.py:
698         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py:
699         * Scripts/webkitpy/style/checkers/messagesin_unittest.py:
700         * Scripts/webkitpy/style/checkers/png_unittest.py:
701         * Scripts/webkitpy/style/checkers/python_unittest.py:
702         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
703         * Scripts/webkitpy/style/checkers/text_unittest.py:
704         * Scripts/webkitpy/style/checkers/watchlist_unittest.py:
705         * Scripts/webkitpy/style/checkers/xcodeproj_unittest.py:
706         * Scripts/webkitpy/style/checkers/xml_unittest.py:
707         * Scripts/webkitpy/style/error_handlers_unittest.py:
708         * Scripts/webkitpy/style/filereader_unittest.py:
709         * Scripts/webkitpy/style/filter_unittest.py:
710         * Scripts/webkitpy/style/main_unittest.py:
711         * Scripts/webkitpy/style/optparser_unittest.py:
712         * Scripts/webkitpy/style/patchreader_unittest.py:
713         * Scripts/webkitpy/test/finder_unittest.py:
714         * Scripts/webkitpy/test/main.py: Ordered imports.
715         * Scripts/webkitpy/test/main_unittest.py:
716         * Scripts/webkitpy/test/printer.py: Ordered imports.
717         (Printer.configure):
718         * Scripts/webkitpy/test/runner_unittest.py:
719         * Scripts/webkitpy/test/skip_unittest.py:
720         * Scripts/webkitpy/thirdparty/__init__.py:
721         (AutoinstallImportHook._install_irc):
722         (AutoinstallImportHook._install_unittest2): Deleted.
723         * Scripts/webkitpy/thirdparty/__init___unittest.py:
724         * Scripts/webkitpy/thirdparty/ordered_dict.py: Removed.
725         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py:
726         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
727         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
728         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
729         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
730         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
731         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
732         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
733         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
734         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
735         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
736         * Scripts/webkitpy/tool/commands/download_unittest.py:
737         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
738         * Scripts/webkitpy/tool/commands/perfalizer_unittest.py:
739         * Scripts/webkitpy/tool/commands/queries_unittest.py:
740         * Scripts/webkitpy/tool/commands/queuestest.py:
741         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
742         * Scripts/webkitpy/tool/grammar_unittest.py:
743         * Scripts/webkitpy/tool/mocktool_unittest.py:
744         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
745         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
746         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
747         * Scripts/webkitpy/tool/servers/reflectionhandler_unittest.py:
748         * Scripts/webkitpy/tool/steps/addsvnmimetypeforpng_unittest.py:
749         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py:
750         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
751         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
752         * Scripts/webkitpy/tool/steps/commit_unittest.py:
753         * Scripts/webkitpy/tool/steps/discardlocalchanges_unittest.py:
754         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
755         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
756         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
757         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
758         * Scripts/webkitpy/tool/steps/steps_unittest.py:
759         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
760         * Scripts/webkitpy/tool/steps/update_unittest.py:
761         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
762         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
763         * Scripts/webkitpy/w3c/test_converter_unittest.py:
764         * Scripts/webkitpy/w3c/test_importer_unittest.py:
765         * Scripts/webkitpy/w3c/test_parser_unittest.py:
766
767 2014-09-30  Jake Nielsen  <jacob_nielsen@apple.com>
768
769         LayoutTestResults and ExpectedFailures should know about the
770         interrupted flag from the json results file
771         https://bugs.webkit.org/show_bug.cgi?id=137229
772
773         Reviewed by Daniel Bates.
774
775         Changes LayoutTestResults to use the interrupted flag instead of
776         counting failures.
777
778         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
779         (BuilderTest._install_fetch_build._mock_fetch_build):
780         (BuilderTest.test_latest_layout_test_results):
781         * Scripts/webkitpy/common/net/layouttestresults.py:
782         Removes notion of failure_limit_count, and adds
783         did_exceed_test_failure_limit.
784
785         (LayoutTestResults.results_from_string):
786         (LayoutTestResults.__init__):
787         (LayoutTestResults.did_exceed_test_failure_limit):
788         (LayoutTestResults): Deleted.
789         (LayoutTestResults.set_failure_limit_count): Deleted.
790         (LayoutTestResults.failure_limit_count): Deleted.
791         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
792         Removes unit test for failure_limit_count logic.
793
794         (LayoutTestResultsTest.test_set_failure_limit_count): Deleted.
795         * Scripts/webkitpy/common/net/resultsjsonparser.py:
796         Instead of providing a class method that returns a list of
797         TestResults objects, resultsjsonparser now provides a class
798         ParsedJSONResults that serves as an interface between the results.json
799         file and the rest of webkitpy.
800
801         (ParsedJSONResults):
802         (ParsedJSONResults.__init__):
803         (ParsedJSONResults.did_exceed_test_failure_limit):
804         (ParsedJSONResults.test_results):
805         (ResultsJSONParser): Deleted.
806         (ResultsJSONParser.parse_results_json): Deleted.
807         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
808         Updates the unit test so that it can test the new ResultsJSONParser
809         class.
810
811         (ParsedJSONResultsTest):
812         (test_basic):
813         (ResultsJSONParserTest): Deleted.
814         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
815         Updates the unit test to instantiate ResultsJSONParser objects rather
816         than simple lists of TestResult objects.
817
818         (MockCommitQueue.test_results):
819         (FailingTestCommitQueue.test_results):
820         (test_flaky_test_failure):
821         (test_failed_archive):
822         * Scripts/webkitpy/tool/bot/expectedfailures.py:
823         Updates ExpectedFailures to use the did_exceed_test_failure_limit
824         method rather than counting the number of failed tests.
825
826         (ExpectedFailures._should_trust):
827         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
828         Updates MockResults to more closely resemble the updated
829         LayoutTestResults class.
830
831         (MockResults.__init__):
832         (MockResults.did_exceed_test_failure_limit):
833         (ExpectedFailuresTest.test_can_trust_results):
834         (ExpectedFailuresTest.test_unexpected_failures_observed):
835         (ExpectedFailuresTest.test_unexpected_failures_observed_when_tree_is_hosed):
836         (MockResults.failure_limit_count): Deleted.
837         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
838         Removes a FIXME regarding the use of the
839         NON_INTERACTIVE_FAILURE_LIMIT_COUNT value.
840
841         (LayoutTestResultsReader.results):
842         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
843         Updates test to not check the now-nonexistant failure_count_limit
844         method.
845
846         (test_missing_unit_test_results_path):
847         (test_layout_test_results):
848         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
849         Accounts for name change: ResultsJSONParserTest ->
850         ParsedJSONParserTest.
851
852         (RebaselineTestTest.test_gather_baselines):
853
854 2014-09-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
855
856         [EFL] Rename TEST_THEME_DIR macro
857         https://bugs.webkit.org/show_bug.cgi?id=137244
858
859         Reviewed by Csaba Osztrogonác.
860
861         TEST_THEME_DIR is to get a path for default theme though, it has used TEST_ prefix.
862         DEFAULT_THEME_DIR is better than it.
863
864         * MiniBrowser/efl/main.c:
865         (window_create):
866         * TestWebKitAPI/efl/PlatformWebView.cpp:
867         (TestWebKitAPI::PlatformWebView::PlatformWebView):
868         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
869         (WTR::PlatformWebView::PlatformWebView):
870
871 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
872
873         Windows EWS went purple when it failed to build
874         https://bugs.webkit.org/show_bug.cgi?id=137267
875
876         Reviewed by Ryosuke Niwa.
877
878         * QueueStatusServer/app.yaml: Update the version.
879
880         * QueueStatusServer/model/attachment.py: (Attachment._calculate_queue_positions):
881         Make it work for style and win-ews queues.
882
883 2014-09-29  Filip Pizlo  <fpizlo@apple.com>
884
885         It should be fun and easy to run every possible JavaScript benchmark from the command line
886         https://bugs.webkit.org/show_bug.cgi?id=137245
887
888         Reviewed by Oliver Hunt.
889         
890         We previously had Tools/Scripts/bencher.  Then we stopped adding things to it because we
891         weren't sure about the licensing of things like Kraken and Octane.  Various people ended up
892         having their own private scripts for doing benchmark runs, and didn't share them in the open
893         source community, because of fears about the shady licensing of the benchmarks suites that
894         they were running. The dominant version of this was "run-jsc-benchmarks", which has a lot of
895         excellent power - it can run benchmarks through either jsc, DumpRenferTree, or
896         WebKitTestRunner; it can run tests on any number of remote machines; and it has inside
897         knowledge about how to run *a lot* of test suites. Many of those test suites are not public,
898         but some of them are. The non-public tests are exclusively those that were not made by any
899         WebKit contributor, but which JSC/WebKit devs found useful for testing.
900
901         This fixes this weirdness by releasing run-jsc-benchmarks. The paths to the test suites
902         whose licenses are incompatible with WebKit's (to the extent that they cannot be safely
903         checked into WebKit svn at all) can be run by passing the path to them via a configuration
904         file. The default configuration file is ~/.run-jsc-benchmarks. The most important benchmark
905         suites are Octane version 2 and Kraken version 1.1. We should probably check Octane 2 into
906         WebKit eventually because it seems that the license is fine. Kraken, on the other hand, will
907         probably never be checked in because there is no license text anywhere in that benchmark.
908         A valid ~/.run-jsc-benchmarks file will just be something like:
909         
910             {
911                 "OctanePath": "/path/to/Octane2",
912                 "KrakenPath": "/path/to/Kraken-1.1/tests/kraken-1.1"
913             }
914         
915         If your ~/.run-jsc-benchmarks file omits the directory for any particular test suite, then
916         run-jsc-benchmarks will just gracefully avoid running that test suite.
917         
918         Finally, a word about policy: it is understood that different organizations that do
919         development on JSC may find themselves having internal benchmarks that they cannot share
920         because of weird licensing. It happens - usually because the organization doing JSC
921         development found some test in the wild that is owned by someone else and therefore cannot
922         be shared. So, we should consider it acceptable to write patches against run-jsc-benchmarks
923         that add support for some new kind of benchmark suite even if the suite is not made public
924         as part of the same patch - so long as the patch isn't too invasive. An example of
925         non-invasiveness is the DSPJS suite, which is implemented using some new classes (like
926         DSPJSAmmoJSRegularBenchmark) and some calls to otherwise reusable functions (like
927         emitSelfContainedBenchRunCode). It is obviously super helpful if a benchmark suite can be
928         completely open-sourced and committed to the WebKit repo - but the reality is that this
929         can't always be done safely.
930
931         * Scripts/bencher: Removed.
932         * Scripts/run-jsc-benchmarks: Added.
933
934 2014-09-30  Roger Fong  <roger_fong@apple.com>
935
936         [Windows] Add some logging to webkitpy to debug timeout issues with running NRWT using multiple child processes.
937
938         * Scripts/webkitpy/port/drdiver.py:
939         (Driver.stop):
940         * Scripts/webkitpy/port/server_process.py:
941         (ServerProcess.stop):
942
943 2014-09-30  Roger Fong  <roger_fong@apple.com>
944
945         [Windows] Back to 2 child processes for NRWT on Windows.
946
947         * Scripts/webkitpy/port/win.py:
948         (WinPort.default_child_processes):
949         Changing the number of processes to 1 did not have an effect on the layout test results. 
950         It does introduce an issue with one of the workers hanging indefinitely and causing the 
951         layout tests to timeout as a whole occasionally, but we should just fix that.
952
953 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
954
955         Remove an accidentally committed line..
956
957         * QueueStatusServer/handlers/statusbubble.py:
958         (StatusBubble._build_bubble):
959
960 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
961
962         build.webkit.org/dashboard: Switch EWS view to using actual retry count
963         https://bugs.webkit.org/show_bug.cgi?id=137240
964
965         Reviewed by Ryosuke Niwa.
966
967         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
968         (EWSQueue.prototype.loadDetailedStatus):
969         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js:
970         (EWSQueueView.prototype._popoverContentForEWSQueue):
971         Use the new retry_count data member from JSON.
972
973         * QueueStatusServer/app.yaml: Updating the version.
974
975         * QueueStatusServer/handlers/queuestatusjson.py: (QueueStatusJSON._rows_for_work_items):
976         Instead of message_count, produce retry_count.
977
978 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
979
980         EWS doesn't need to show all the bubbles when a patch fails to apply
981         https://bugs.webkit.org/show_bug.cgi?id=137256
982
983         Reviewed by Ryosuke Niwa.
984
985         * QueueStatusServer/app.yaml: Updated app version.
986
987         * QueueStatusServer/handlers/statusbubble.py:
988         (StatusBubble._build_bubble):
989         (StatusBubble._build_bubbles_for_attachment):
990         (StatusBubble.get):
991         * QueueStatusServer/templates/statusbubble.html:
992         When some queues fail to apply, and no queues had meaningful output (meaning that
993         they will almost certainly fail to apply later), we can show a single bubble
994         telling the user just that.
995
996 2014-09-30  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
997
998         [EFL] Bump EFL version to 1.11.2
999         https://bugs.webkit.org/show_bug.cgi?id=137118
1000
1001         Reviewed by Gyuyoung Kim.
1002
1003         Disable NEON for EFL build because the build system doesn't pass the necessary -mfpu=neon flag to the compiler.
1004         Tools/efl/patches/ecore.patch: Removed, because this fix is already in EFL.
1005
1006         * efl/jhbuild.modules:
1007         * efl/patches/ecore.patch: Removed.
1008
1009 2014-09-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1010
1011         REGRESSION(r173929): [GTK] TestInspector fails after r173929
1012         https://bugs.webkit.org/show_bug.cgi?id=137247
1013
1014         Reviewed by Philippe Normand.
1015
1016         Wait until can-attach property changes before trying to attach the
1017         inspector after resizing the view.
1018
1019         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp:
1020         (testInspectorDefault):
1021
1022 2014-09-30  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1023
1024         Require Python 2.7 version
1025         https://bugs.webkit.org/show_bug.cgi?id=137112
1026
1027         Reviewed by Csaba Osztrogonác.
1028
1029         * Scripts/ensure-valid-python:
1030         (checkPythonVersion):
1031         * Scripts/webkitpy/common/version_check.py:
1032
1033 2014-09-30  Martin Hock  <mhock@apple.com>
1034
1035         Skip a JSC test after r174036.
1036         https://bugs.webkit.org/show_bug.cgi?id=137236
1037
1038         Reviewed by Csaba Osztrogonác.
1039
1040         * Scripts/run-javascriptcore-tests:
1041
1042 2014-09-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1043
1044         [GTK] [EFL] Install TestNetscapePlugin apart from the other libs.
1045         https://bugs.webkit.org/show_bug.cgi?id=137212
1046
1047         This moves TestNetscapePlugin to a new folder (lib/plugins).
1048         We should not use the same directory for TestNetscapePlugin and
1049         the other libraries, because we end up scanning all the .so in the
1050         lib dir for every test.
1051
1052         Reviewed by Carlos Garcia Campos.
1053
1054         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Set LIBRARY_OUTPUT_DIRECTORY to lib/plugins.
1055         * Scripts/webkitpy/port/efl.py:
1056         (EflPort.setup_environ_for_server): Update plugin path.
1057         * Scripts/webkitpy/port/gtk.py:
1058         (GtkPort.setup_environ_for_server): Update plugin path.
1059         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Update plugin path.
1060
1061 2014-09-29  Alexey Proskuryakov  <ap@apple.com>
1062
1063         A small change to EWS bubble text. Explain why there are messages for ineligible patches.
1064
1065         Rubber-stamped by Tim Horton.
1066
1067         * QueueStatusServer/app.yaml:
1068         * QueueStatusServer/handlers/statusbubble.py:
1069         (StatusBubble._build_bubble):
1070
1071 2014-09-29  Alexey Proskuryakov  <ap@apple.com>
1072
1073         Typo fix, suggested by Tim Horton.
1074
1075         * QueueStatusServer/handlers/statusbubble.py:
1076         (StatusBubble._build_message_for_provisional_failure):
1077
1078 2014-09-29  Alexey Proskuryakov  <ap@apple.com>
1079
1080         Improve Bugzilla status bubbles
1081         https://bugs.webkit.org/show_bug.cgi?id=137232
1082
1083         Reviewed by Ryosuke Niwa.
1084
1085         * QueueStatusServer/app.yaml: Will update again with an actual version when landing.
1086
1087         * QueueStatusServer/handlers/statusbubble.py: Eliminated yellow color, added
1088         blue and orange. Significantly extended tooltips. Made bubbles show up even for queues
1089         that are stuck, as it was only confusing that they disappeared after 99.
1090
1091         * QueueStatusServer/model/attachment.py: Removed functionality that was only used
1092         by old bubbles. We need a lot more information to determine color, so the implementation
1093         can not be here.
1094
1095         * QueueStatusServer/templates/statusbubble.html: Updated colors in CSS, made bubbles
1096         always have a link for consistency. Added code to convert timestamps in tooltips
1097         to local time zone.
1098
1099 2014-09-29  Commit Queue  <commit-queue@webkit.org>
1100
1101         Unreviewed, rolling out r174045.
1102         https://bugs.webkit.org/show_bug.cgi?id=137231
1103
1104         Introduced a crash during page loading tests on Mac (Requested
1105         by rniwa on #webkit).
1106
1107         Reverted changeset:
1108
1109         "Replace OSObjectPtr with RetainPtr/adoptOS"
1110         https://bugs.webkit.org/show_bug.cgi?id=137158
1111         http://trac.webkit.org/changeset/174045
1112
1113 2014-09-29  Tim Horton  <timothy_horton@apple.com>
1114
1115         Add Jake as a contributor.
1116
1117         * Scripts/webkitpy/common/config/contributors.json:
1118
1119 2014-09-29  Roger Fong  <roger_fong@apple.com>
1120
1121         [Windows] Skip a javascriptcore test following r174036.
1122
1123         * Scripts/run-javascriptcore-tests:
1124
1125 2014-09-29  Roger Fong  <roger_fong@apple.com>
1126
1127         [Windows] Reduce number of processes used by NRWT on Windows to 1.
1128
1129         * Scripts/webkitpy/port/win.py:
1130         (WinPort.default_child_processes):
1131         Reduce number of processes to 1 so we can get a good baseline for what failures
1132         we should be expecting to see from the Windows bots.
1133
1134 2014-09-29  Darin Adler  <darin@apple.com>
1135
1136         Tweak and tighten SVG font converter
1137         https://bugs.webkit.org/show_bug.cgi?id=136956
1138
1139         Reviewed by Myles Maxfield.
1140
1141         I was investigating behavior of String::toInt, String::toDouble, and
1142         String::toFloat for various failure cases, and decided to start some
1143         unit tests for those functions here.
1144
1145         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1146         (TestWebKitAPI::TEST): Addded a first small bit of StringToInt and
1147         StringToDouble testing.
1148
1149 2014-09-29  Philippe Normand  <pnormand@igalia.com>
1150
1151         [GTK][CMake] TestWebCore target build sometimes fail
1152         https://bugs.webkit.org/show_bug.cgi?id=137207
1153
1154         Reviewed by Csaba Osztrogon.
1155
1156         * TestWebKitAPI/PlatformGTK.cmake: Make sure the forwarding
1157         headers are generated before the TestWebCore target is built.
1158
1159 2014-09-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1160
1161         [GTK] Remove IntPointGtk.cpp and IntRectGtk.cpp
1162         https://bugs.webkit.org/show_bug.cgi?id=137209
1163
1164         Reviewed by Philippe Normand.
1165
1166         * TestWebKitAPI/PlatformGTK.cmake: Remove unneeded IntRectGtk.cpp
1167         from the WebCore test sources.
1168
1169 2014-09-28  Myles C. Maxfield  <mmaxfield@apple.com>
1170
1171         Allow webkit-patch upload to respect the --directory argument with git checkouts
1172         https://bugs.webkit.org/show_bug.cgi?id=137166
1173
1174         Reviewed by Darin Adler.
1175
1176         We simply hadn't plumbed it through.
1177
1178         * Scripts/webkitpy/common/checkout/scm/detection.py:
1179         (SCMDetector.detect_scm_system):
1180         * Scripts/webkitpy/common/checkout/scm/git.py:
1181         (Git.__init__):
1182         (Git.changed_files):
1183
1184 2014-09-26  Sam Weinig  <sam@webkit.org>
1185
1186         Replace OSObjectPtr with RetainPtr/adoptOS
1187         https://bugs.webkit.org/show_bug.cgi?id=137158
1188
1189         Reviewed by Dan Bernstein.
1190
1191         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1192         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp: Removed.
1193         * TestWebKitAPI/Tests/WTF/darwin/RetainPtrOSObject.cpp: Copied from Tools/TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp.
1194         Rename and change test to use RetainPtr. Remove now unneeded part testing WTF::retainOSObject/WTF::releaseOSObject.
1195
1196 2014-09-26  Filip Pizlo  <fpizlo@apple.com>
1197
1198         Disable function.arguments
1199         https://bugs.webkit.org/show_bug.cgi?id=137167
1200
1201         Rubber stamped by Geoffrey Garen
1202         
1203         Enable the feature by default during tests.
1204
1205         * Scripts/run-jsc-stress-tests:
1206
1207 2014-09-26  Beth Dakin  <bdakin@apple.com>
1208
1209         Many platform/mac-wk2/tiled-drawing/ tests fail when run on a retina device
1210         https://bugs.webkit.org/show_bug.cgi?id=137089
1211
1212         Reviewed by Tim Horton.
1213
1214         This is a little sneaky since updateWindowScaleForTest() should ensure that these 
1215         tests run at 1x, but that code does not seem to execute at the right time for 
1216         these tests, so if we just ensure we start out at 1x, that appears to fix these 
1217         tests and does not break the HiDPI tests either.
1218         * WebKitTestRunner/TestController.cpp:
1219         (WTR::TestController::createWebViewWithOptions):
1220
1221 2014-09-26  Roger Fong  <roger_fong@apple.com>
1222
1223         [Windows] Decrease default number of child processes used by Windows.
1224
1225         * Scripts/webkitpy/port/win.py:
1226         (WinPort.default_child_processes):
1227         Having too many seems to cause many tests to crash or timeout. 
1228         We may even need to make it have only 1 child process if we’re still seeing problems after this.
1229
1230 2014-09-26  Alexey Proskuryakov  <ap@apple.com>
1231
1232         Mac EWS bots do not keep logs as promised
1233         https://bugs.webkit.org/show_bug.cgi?id=137151
1234
1235         Reviewed by Ryosuke Niwa.
1236
1237         * EWSTools/start-queue-mac.sh: Actually keep the logs for 14 days.
1238
1239 2014-09-26  Alexey Proskuryakov  <ap@apple.com>
1240
1241         Get rid of webkit-queues dashboard
1242         https://bugs.webkit.org/show_bug.cgi?id=137141
1243
1244         Reviewed by Ryosuke Niwa.
1245
1246         * QueueStatusServer/app.yaml: Updated version.
1247
1248         * QueueStatusServer/templates/dashboard.html: Removed.
1249         * QueueStatusServer/handlers/dashboard.py: Removed.
1250         * QueueStatusServer/main.py:
1251         Kill it!
1252
1253         * QueueStatusServer/stylesheets/common.css: Copied from Tools/QueueStatusServer/stylesheets/dashboard.css.
1254         (.status-cell): Deleted.
1255         (.status-cell:hover): Deleted.
1256         (.status-cell.pass): Deleted.
1257         (.status-cell.fail): Deleted.
1258         (.status-cell.pending): Deleted.
1259         (.status-cell.error): Deleted.
1260         * QueueStatusServer/stylesheets/dashboard.css: Removed.
1261         * QueueStatusServer/templates/activebots.html:
1262         * QueueStatusServer/templates/patch.html:
1263         * QueueStatusServer/templates/queuestatus.html:
1264         * QueueStatusServer/templates/recentstatus.html:
1265         Renamed dashboard.css to common.css, and removed dashboard-only rules.
1266
1267 2014-09-26  Alexey Proskuryakov  <ap@apple.com>
1268
1269         Get rid of Retry status in webkit-queues
1270         https://bugs.webkit.org/show_bug.cgi?id=137135
1271
1272         Reviewed by Ryosuke Niwa.
1273
1274         * QueueStatusServer/config/messages.py: Removed Retry.
1275
1276         * QueueStatusServer/handlers/releasepatch.py: This is now straightforward, as it
1277         no longer needs to check the latest status. It just always both unlocks the patch
1278         and removes it from WorkItems.
1279
1280         * QueueStatusServer/handlers/submittoews.py: (SubmitToEWS._should_add_to_ews_queue):
1281         I don't understand why we even needed to check for retries here, but now that there
1282         are no retries, that code can go to /dev/null.
1283
1284         * QueueStatusServer/loggers/recordpatchevent.py:
1285         (RecordPatchEvent.started):
1286         (RecordPatchEvent.retrying): Deleted.
1287         Fixed retry counting, it should work for all queues now.
1288
1289         * QueueStatusServer/model/queuestatus.py:
1290         (QueueStatus.is_retry_request): Deleted. These are no more.
1291
1292         * Scripts/webkitpy/common/net/statusserver_mock.py:
1293         (MockStatusServer.release_lock):
1294         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1295         Did whatever it took to keep passing the tests. The particular test doesn't seem
1296         quite right, but whatever.
1297
1298         * Scripts/webkitpy/tool/commands/queues.py:
1299         (CommitQueue.process_work_item): Instead of posting a retry status, just unlock
1300         and let others pick up. Also, added explicit returns for clarity.
1301         (AbstractPatchQueue._did_retry): Deleted.
1302
1303 2014-09-26  Csaba Osztrogonác  <ossy@webkit.org>
1304
1305         [EFL] Fix the gst-libav build on ARM Thumb2
1306         https://bugs.webkit.org/show_bug.cgi?id=137022
1307
1308         Reviewed by Zoltan Herczeg.
1309
1310         * efl/jhbuild.modules:
1311         * efl/patches/gst-libav.patch: Added.
1312
1313 2014-09-26  Akos Kiss  <akiss@inf.u-szeged.hu>
1314
1315         [EFL] Bump up dependencies not to conflict with the GTK port.
1316         https://bugs.webkit.org/show_bug.cgi?id=137143
1317
1318         Reviewed by Gyuyoung Kim.
1319
1320         Tools/efl/install-dependencies and Tools/gtk/install-dependencies keep
1321         installing and removing different versions of libgnutls-dev, thus
1322         hindering the development for both ports on the same machine. GTK is
1323         using the newer version of the package, now bumping up EFL to use the 
1324         same.
1325
1326         * efl/install-dependencies:
1327
1328 2014-09-25  Rohit Kumar  <kumar.rohit@samsung.com>
1329
1330         [EFL][WK2] Minibrowser : Fix the 'Escape' button issue to exit fullscreen
1331         https://bugs.webkit.org/show_bug.cgi?id=136854
1332
1333         Reviewed by Gyuyoung Kim.
1334
1335         'Escape' key should exit fullscreen first and then should be used to stop page load.
1336
1337         * MiniBrowser/efl/main.c:
1338         (on_key_down):
1339
1340 2014-09-25  Dean Jackson  <dino@apple.com>
1341
1342         Add Said to the contributors list so his name completes in bugzilla.
1343
1344         * Scripts/webkitpy/common/config/contributors.json:
1345
1346 2014-09-25  Alexey Proskuryakov  <ap@apple.com>
1347
1348         EWS only repeats its cycle every two hours
1349         https://bugs.webkit.org/show_bug.cgi?id=137129
1350
1351         Reviewed by Ryosuke Niwa.
1352
1353         * QueueStatusServer/app.yaml: Updated version.
1354
1355         * QueueStatusServer/config/queues.py: Moved timeout from activeworkitems.py to configuration.
1356
1357         * QueueStatusServer/handlers/releaselock.py: Added. Releases the lock without removing
1358         the patch from work items.
1359
1360         * QueueStatusServer/index.yaml: No real change, just let AppEngine have its way with entry order.
1361
1362         * QueueStatusServer/main.py: Added release-lock.
1363
1364         * QueueStatusServer/model/activeworkitems.py:
1365         (ActiveWorkItems.deactivate_expired): Use timeout from configuration.
1366
1367         * QueueStatusServer/model/workitems.py: Added move_to_end. When we unlock a patch,
1368         we don't want it to be immediately picked up again, it's better to give other patches
1369         a chance.
1370
1371         * QueueStatusServer/templates/releaselock.html: Added. Not sure why all commands have
1372         these interactive versions, but OK.
1373
1374         * Scripts/webkitpy/tool/commands/earlywarningsystem.py: (AbstractEarlyWarningSystem.review_patch):
1375         Unlock the patch when a non-final failure occurs (e.g. can't build even without the patch,
1376         or svn is down).
1377
1378         * Scripts/webkitpy/tool/commands/queues.py:
1379         (AbstractReviewQueue.process_work_item): Do not try/catch ScriptError around review_patch.
1380         Style queue never raises these, and EWS already calls _did_fail, before re-throwing,
1381         meaning that these handlers could never do the right thing. We'd either get a duplicate
1382         _did_fail, or try to unlock an already unlocked patch.
1383         (StyleQueue.review_patch): Unlock the patch on transient failure (such as svn failure),
1384         making it eligible for retry immediately.
1385
1386         * Scripts/webkitpy/common/net/statusserver.py:
1387         (StatusServer._post_release_lock):
1388         (StatusServer.release_lock):
1389         Added a call to release-lock.
1390
1391 2014-09-25  Roger Fong  <roger_fong@apple.com>
1392
1393         [Windows] Followup to r173972. Don’t set child process to none before reading from stdout.
1394
1395         * Scripts/webkitpy/common/system/path.py:
1396         (_CygPath.convert):
1397
1398 2014-09-25  Roger Fong  <roger_fong@apple.com>
1399
1400         [Windows] Close stdin to force a flush to stdout if no test path is read during layout tests.
1401
1402         * Scripts/webkitpy/common/system/path.py:
1403         (_CygPath.convert):
1404
1405 2014-09-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1406
1407         [Gtk] build.sh needs a -- before make options when the build command is cmake --build
1408         https://bugs.webkit.org/show_bug.cgi?id=136377
1409
1410         Reviewed by Philippe Normand.
1411
1412         * Scripts/webkitdirs.pm:
1413         (buildCMakeGeneratedProject): Only use the build.sh script if it exists.
1414
1415 2014-09-25  Akos Kiss  <akiss@inf.u-szeged.hu>
1416
1417         [EFL] Split the list of dependencies to make sure that at least the universally available packages get installed
1418         https://bugs.webkit.org/show_bug.cgi?id=137117
1419
1420         Tools/efl/install-dependencies relies on apt-get to install packages.
1421         Unfortunately, if a package does not exist (e.g., for a given
1422         architecture) then apt-get install is not able to ignore the missing
1423         package and install the rest but fails to run entirely (and there
1424         seems to be no intent to change this behaviour).
1425
1426         On ARM64, the luajit package is missing and currently it needs manual
1427         editing of install-dependencies to get the script install as much as it
1428         can.
1429
1430         This patch separates the installation of the universally available
1431         packages from those which might not be available for all architectures.
1432
1433         Reviewed by Gyuyoung Kim.
1434
1435         * efl/install-dependencies:
1436
1437 2014-09-25  Csaba Osztrogonác  <ossy@webkit.org>
1438
1439         Remove WinCE port from trunk
1440         https://bugs.webkit.org/show_bug.cgi?id=136951
1441
1442         Reviewed by Alex Christensen.
1443
1444         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
1445         (_should_file_trigger_build):
1446         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1447         (ShouldBuildTest):
1448         * CMakeLists.txt:
1449         * DumpRenderTree/win/DRTDataObject.cpp:
1450         (DRTDataObject::CopyMedium):
1451         * Scripts/build-webkit:
1452         * Scripts/webkit-build-directory:
1453         * Scripts/webkitdirs.pm:
1454         (argumentsForConfiguration):
1455         (builtDylibPathForName):
1456         (isAppleWinWebKit):
1457         (launcherPath):
1458         (launcherName):
1459         (shouldRemoveCMakeCache):
1460         (cmakeBasedPortArguments):
1461         (cmakeBasedPortName):
1462         (isCMakeBuild):
1463         (isWinCE): Deleted.
1464         (determineIsWinCE): Deleted.
1465         * Scripts/webkitperl/FeatureList.pm:
1466         * Scripts/webkitpy/port/port_testcase.py:
1467         (test_apache_config_file_name_for_platform):
1468         * TestWebKitAPI/config.h:
1469         * WinCELauncher/CMakeLists.txt: Removed.
1470         * WinCELauncher/main.cpp: Removed.
1471         * gtk/manifest.txt:
1472
1473 2014-09-23  David Farler  <dfarler@apple.com>
1474
1475         [iOS] run-webkit-tests should support minor versions under devices and create a testing device under the right runtime
1476         https://bugs.webkit.org/show_bug.cgi?id=136895
1477
1478         Reviewed by David Kilzer.
1479
1480         Create Device, DeviceType, and Runtime data classes.
1481         Create Simulator class represent simctl output.
1482
1483         Wherever possible, use structured data classes anywhere a raw
1484         identifier or UDID string was used for a cleaner implementation
1485         and to encapsulate the inherent fragility of scraping simctl output.
1486
1487         Create a suitably named testing device if one doesn't exist.
1488
1489         Finally, accurately handle having multiple simulator runtimes (SDKs)
1490         installed in the active Xcode.app bundle.
1491
1492         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1493         (_set_up_derived_options):
1494         * Scripts/webkitpy/port/driver.py:
1495         (IOSSimulatorDriver.cmd_line):
1496         Construct DeviceType and Runtime objects from identifiers passed at the
1497         command line, still providing sensible defaults for 32- and 64-bit testing.
1498         * Scripts/webkitpy/port/ios.py:
1499         (IOSSimulatorPort.__init__):
1500         (IOSSimulatorPort.setup_test_run):
1501         (IOSSimulatorPort):
1502         (IOSSimulatorPort.testing_device):
1503         Cache the testing device once it is created or found.
1504         (IOSSimulatorPort.reset_preferences):
1505         Get the device path from the Device object instead of consructing it
1506         in the port class.
1507         (IOSSimulatorPort.simulator_udid): Deleted.
1508         Get the UDID from the testing_device :: Device object itself.
1509         * Scripts/webkitpy/xcode/simulator.py:
1510         Created Device, DeviceType, Runtime, and Simulator classes.
1511         (get_runtimes): Deleted.
1512         (get_devices): Deleted.
1513         (get_device_types): Deleted.
1514         (get_latest_runtime): Deleted.
1515
1516 2014-09-24  Roger Fong  <roger_fong@apple.com>
1517
1518         [Windows] Tentative fix for Windows test bots.
1519
1520         * Scripts/webkitpy/common/system/path.py:
1521         (_CygPath.convert):
1522
1523 2014-09-24  Alexey Proskuryakov  <ap@apple.com>
1524
1525         Change more build.webkit.org links to https
1526         https://bugs.webkit.org/show_bug.cgi?id=137049
1527
1528         Reviewed by Csaba Osztrogonác.
1529
1530         Fix appspot, svn.webkit.org and Trac links.
1531
1532         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1533         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:
1534         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1535         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
1536         (ViewController.prototype._domForBuildName):
1537         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
1538         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1539         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1540         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1541         (.):
1542         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
1543         (EWS):
1544         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
1545         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitTestHistory.js:
1546         (TestHistory):
1547         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1548
1549 2014-09-24  Langó László  <llango.u-szeged@partner.samsung.com>
1550
1551         Update the list of u-szeged contributors.
1552
1553         Rubber-stamped by Csaba Osztrogonác <ossy@webkit.org>.
1554
1555         * Scripts/webkitpy/common/config/contributors.json:
1556
1557 2014-09-23  Roger Fong  <roger_fong@apple.com>
1558
1559         [Windows] More debugging for the Windows bots.
1560
1561         * Scripts/webkitpy/common/system/path.py:
1562         (_CygPath):
1563
1564 2014-09-23  Roger Fong  <roger_fong@apple.com>
1565
1566         Unreviewed. Fix for r173899, those tabs should be spaces.
1567
1568         * Scripts/webkitpy/port/driver.py:
1569         (Driver._command_from_driver_input):
1570         (Driver): Deleted.
1571
1572 2014-09-23  Roger Fong  <roger_fong@apple.com>
1573
1574         [Windows] Add some logging to debug a problem with the Windows bots that causes layout tests to exit early.
1575
1576         * Scripts/webkitpy/port/driver.py:
1577         (Driver):
1578
1579 2014-09-23  Jer Noble  <jer.noble@apple.com>
1580
1581         [Tools] git-commit uses wrong ChangeLog when run from a subdirectory
1582         https://bugs.webkit.org/show_bug.cgi?id=137031
1583
1584         Reviewed by Joseph Pecoraro.
1585
1586         commit-log-editor is run from the top of the Git checkout, even when git-commit is invoked
1587         from a subdirectory, making the parsed locations of ChangeLog files incorrect. Git provides
1588         a mapping prefix in the GIT_PREFIX environment variable, so apply this prefix to the parsed
1589         ChangeLog locations before passing them to createCommitMessage().
1590
1591         * Scripts/commit-log-editor:
1592
1593 2014-09-23  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1594
1595         W3C test importer should detect manual and reference tests according their filenames
1596         https://bugs.webkit.org/show_bug.cgi?id=133852
1597
1598         Reviewed by Bem Jones-Bey.
1599
1600         * Scripts/webkitpy/w3c/test_parser.py:
1601         (TestParser.analyze_test): Adding checks based on WPT filename rules.
1602         (TestParser.is_wpt_manualtest): Detecting whether the test is a manual test based on its filename.
1603         (TestParser):
1604         (TestParser.potential_ref_filename): Getting the potential reference filename of a test from its filename.
1605         (TestParser.is_wpt_reftest): Detecting whether the test is a ref test based on its filename.
1606         * Scripts/webkitpy/w3c/test_parser_unittest.py:
1607         (test_analyze_manual_wpt_test): Adding a test for a "-manual.html" file with testharness.js link in it. 
1608
1609 2014-09-23  Bem Jones-Bey  <bjonesbe@adobe.com>
1610
1611         Unreviewed, add Rebecca Hauck as a contributor.
1612
1613         * Scripts/webkitpy/common/config/contributors.json:
1614
1615 2014-09-23  David Kilzer  <ddkilzer@apple.com>
1616
1617         Switch build.webkit.org URLs to https
1618
1619         Reviewed by Lucas Forschler and Alexey Proskuryakov.
1620
1621         * TestResultServer/app.yaml: Update version to this commit
1622         revision.
1623
1624         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1625         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
1626         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1627         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBuildbot.js:
1628         (WebKitBuildbot):
1629         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
1630         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1631         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
1632         (.):
1633         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1634         (WebKitBuildbot):
1635         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1636         * Scripts/webkitpy/common/config/urls.py:
1637         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1638         (test_builder_with_name):
1639         * Scripts/webkitpy/tool/commands/queries.py:
1640         (TreeStatus):
1641         * TestResultServer/generate_builders_json.py:
1642         (main):
1643         * TestResultServer/generate_builders_json_unittest.py:
1644         (GenerateBuildersJsonTest.test_generate_json_data.dummy_fetch_json):
1645         (GenerateBuildersJsonTest):
1646         (GenerateBuildersJsonTest.test_generate_json_data):
1647         * TestResultServer/static-dashboards/builders.jsonp:
1648         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1649         (loadExpectationsLayoutTests):
1650         * TestResultServer/static-dashboards/timeline_explorer.js:
1651
1652 2014-09-23  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1653
1654         W3C test importer should copy .htaccess files
1655         https://bugs.webkit.org/show_bug.cgi?id=136850
1656
1657         Reviewed by Bem Jones-Bey.
1658
1659         * Scripts/webkitpy/w3c/test_importer.py:
1660         (TestImporter.should_skip_file): Helper function to check whether to skip file or not. Added ".htaccess" file specific check.
1661         (TestImporter):
1662         (TestImporter.find_importable_tests): Making use of new helper function.
1663
1664 2014-09-23  Alexey Proskuryakov  <ap@apple.com>
1665
1666         Trying to revive bot watcher's dashboard after HSTS.
1667
1668         Unreviewed.
1669
1670         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1671         (WebKitBuildbot): It looks like XMLHttpRequest may not like HSTS redirects, let's try to avoid these.
1672
1673 2014-09-23  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1674
1675         Make Tools/BuildSlaveSupport/wait-for-SVN-server.py handle server donwtime
1676         https://bugs.webkit.org/show_bug.cgi?id=137026
1677
1678         Reviewed by Csaba Osztrogonác.
1679
1680         * BuildSlaveSupport/wait-for-SVN-server.py:
1681         (getLatestSVNRevision):
1682         (waitForSVNRevision):
1683
1684 2014-09-23  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1685
1686         Remove unlinkZeroFiles from build-webkit
1687         https://bugs.webkit.org/show_bug.cgi?id=137018
1688
1689         Reviewed by Csaba Osztrogonác.
1690
1691         * Scripts/build-webkit:
1692         (unlinkZeroFiles): Deleted.
1693
1694 2014-09-23  Rohit Kumar  <kumar.rohit@samsung.com>
1695
1696         [GTK] Minibrowser : Add keyboard support for stop page load
1697         https://bugs.webkit.org/show_bug.cgi?id=136857
1698
1699         Reviewed by Philippe Normand.
1700
1701         Keyboard support to stop page load in GTK Minibrowser using F6 and Escape keys.
1702
1703         * MiniBrowser/gtk/BrowserWindow.c:
1704         (stopPageLoad): Callback to stop page load.
1705         (browser_window_init):
1706
1707 2014-09-22  Rohit Kumar  <kumar.rohit@samsung.com>
1708
1709         [EFL][WK2] Minibrowser : Add keyboard support for page reload while ignoring cache
1710         https://bugs.webkit.org/show_bug.cgi?id=136813
1711
1712         Reviewed by Gyuyoung Kim.
1713
1714         Ctrl+r is used for page reload along with F5. Ctrl+Shift+r and Ctrl+F5 is used for page reload while ignoring cache.
1715
1716         * MiniBrowser/efl/main.c:
1717         (on_key_down):
1718
1719 2014-09-22  Daniel Bates  <dabates@apple.com>
1720
1721         [Cocoa] Add UI delegate callback when window.close() is called
1722         https://bugs.webkit.org/show_bug.cgi?id=137008
1723         <rdar://problem/17801001>
1724
1725         Reviewed by Anders Carlsson.
1726
1727         Add a test to ensure that -[WKUIDelegatePrivate _webViewClose:] is called on window.close()
1728         for window opened via JavaScript (i.e. window.open()).
1729
1730         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1731         * TestWebKitAPI/Tests/WebKit2/open-and-close-window.html: Added.
1732         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm: Added.
1733
1734 2014-09-22  Youenn Fablet  <youennf@gmail.com>
1735
1736         W3C importer should import html files within resources folders
1737         https://bugs.webkit.org/show_bug.cgi?id=127548
1738
1739         Reviewed by Ryosuke Niwa.
1740         
1741         Import HTML files in any folder named "resources" even if file is not detected as a HTML test file 
1742
1743         * Scripts/webkitpy/w3c/test_importer.py:
1744         (TestImporter.find_importable_tests):
1745
1746 2014-09-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1747
1748         [GTK] Test /webkit2/WebKitWebView/can-show-mime-type fails if evince browser plugin is installed
1749         https://bugs.webkit.org/show_bug.cgi?id=136998
1750
1751         Reviewed by Philippe Normand.
1752
1753         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1754         (testWebViewCanShowMIMEType): Remove the check of PDF as
1755         unsupported MIME type.
1756
1757 2014-09-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1758
1759         Unreviewed. Fix WebKitGTKTranslations rule in watchlist.
1760
1761         In r145081 GTK+ translations were moved from Source/WebKit/gtk/po/
1762         to Source/WebCore/platform/gtk/po/ but the rule was not updated.
1763
1764         * Scripts/webkitpy/common/config/watchlist: Use
1765         Source/WebCore/platform/gtk/po/ as directory to watch for
1766         WebKitGTKTranslations rule and add berto and myself to the list of
1767         watchers.
1768
1769 2014-09-22  Ryuan Choi  <ryuan.choi@gmail.com>
1770
1771         Fix syntaxError in watchlist since r173594
1772         https://bugs.webkit.org/show_bug.cgi?id=136996
1773
1774         Reviewed by Philippe Normand.
1775
1776         * Scripts/webkitpy/common/config/watchlist: Removed unnecessary comma.
1777
1778 2014-09-20  Sam Weinig  <sam@webkit.org>
1779
1780         Make possible HashSet<std::unique_ptr<>>
1781         https://bugs.webkit.org/show_bug.cgi?id=136166
1782
1783         Reviewed by Darin Adler.
1784
1785         * TestWebKitAPI/Tests/WTF/CopyMoveCounter.h: Removed.
1786         * TestWebKitAPI/Counters.cpp: Added.
1787         * TestWebKitAPI/Counters.h: Copied from Tools/TestWebKitAPI/Tests/WTF/CopyMoveCounter.h.
1788         Move the CopyMoveCounter helper from CopyMoveCounter.h to Counters.h, and add a ConstructorDestructorCounter
1789         helper to the mix as well. Add Counters.cpp to allow for the global variables to be used in more than one
1790         translation unit.
1791     
1792         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1793         Add new files.
1794
1795         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1796         Add tests for using std::unique_ptr and OwnPtr as the key's of a HashMap.
1797
1798         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1799         Add tests for using std::unique_ptr and OwnPtr as the values of a HashSet.
1800
1801 2014-09-21  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1802
1803         run-webkit-tests should count tests submitted as absolute paths once
1804         https://bugs.webkit.org/show_bug.cgi?id=136848
1805
1806         Reviewed by Darin Adler.
1807
1808         * Scripts/webkitpy/port/base.py:
1809         (Port._expanded_paths): In case of absolute path, do not search for platform specific tests.
1810
1811 2014-09-19  Joseph Pecoraro  <pecoraro@apple.com>
1812
1813         JSStringRef leak on the leaks bot allocation under selectTextWithCriteriaCallback
1814         https://bugs.webkit.org/show_bug.cgi?id=136974
1815
1816         Reviewed by Chris Fleizach.
1817
1818         * DumpRenderTree/AccessibilityUIElement.cpp:
1819         (selectTextWithCriteriaCallback):
1820         Be sure to release the string if it was allocated.
1821
1822 2014-09-19  Alexey Proskuryakov  <ap@apple.com>
1823
1824         build.webkit.org/dashboard: Pending builds don't show up when there is a commit with no comments
1825         https://bugs.webkit.org/show_bug.cgi?id=136966
1826
1827         Reviewed by Daniel Bates.
1828
1829         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1830         (Trac.prototype._convertCommitInfoElementToObject): Tolerate these horrible commits.
1831
1832 2014-09-19  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1833
1834         [CoordinatedGraphics][EFL] window.scrollTo(x, y) doesn't work when fixed layout is enabled
1835         https://bugs.webkit.org/show_bug.cgi?id=136917
1836
1837         Reviewed by Darin Adler.
1838
1839         Added WKViewScrollTo.cpp and scrollTo.html to test this issue.
1840
1841         * TestWebKitAPI/PlatformEfl.cmake:
1842         * TestWebKitAPI/Tests/WebKit2/efl/WKViewScrollTo.cpp: Added.
1843         (TestWebKitAPI::didFinishLoadForFrame):
1844         (TestWebKitAPI::TEST):
1845         * TestWebKitAPI/Tests/WebKit2/efl/scrollTo.html: Added.
1846
1847 2014-09-19  Daniel Bates  <dabates@apple.com>
1848
1849         Always assume internal SDK when building configuration Production
1850         https://bugs.webkit.org/show_bug.cgi?id=136925
1851         <rdar://problem/18362399>
1852
1853         Reviewed by Dan Bernstein.
1854
1855         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1856         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1857         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1858         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1859
1860 2014-09-19  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1861
1862         WTR and DRT didReceiveAuthenticationChallengeInFrame should print messages consistently
1863         https://bugs.webkit.org/show_bug.cgi?id=136847
1864
1865         Added protection space host and port logging to WTR didReceiveAuthenticationChallengeInFrame.
1866
1867         Reviewed by Alexey Proskuryakov.
1868
1869         * WebKitTestRunner/TestController.cpp:
1870         (WTR::TestController::didReceiveAuthenticationChallengeInFrame):
1871
1872 2014-09-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1873
1874         [GTK] Missing inspector files in the tarball
1875         https://bugs.webkit.org/show_bug.cgi?id=136952
1876
1877         Reviewed by Gustavo Noronha Silva.
1878
1879         * gtk/manifest.txt: Add
1880         Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
1881         to the tarball.
1882
1883 2014-09-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1884
1885         Webkitgtk 2.5.3: tarball contains APPLE LICENSE file - stating not distributable
1886         https://bugs.webkit.org/show_bug.cgi?id=136632
1887
1888         Reviewed by Gustavo Noronha Silva.
1889
1890         * gtk/generate-inspector-gresource-manifest.py: Use an alias for
1891         the gtk icons.
1892         * gtk/manifest.txt: Only include the free icons in the tarball.
1893
1894 2014-09-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1895
1896         [GTK] generate-inspector-gresource-manifest.py should receive the list of files from the makefile
1897         https://bugs.webkit.org/show_bug.cgi?id=136943
1898
1899         Reviewed by Philippe Normand.
1900
1901         Update the script to receive the list of files from the command
1902         line instead of scanning the given directories.
1903
1904         * gtk/generate-inspector-gresource-manifest.py:
1905         (get_filenames): Convert filenames to use relative paths.
1906         (find_all_files_in_directory): Deleted.
1907         (find_all_files_in_directory.select_file): Deleted.
1908
1909 2014-09-18  Tanay C  <tanay.c@samsung.com>
1910
1911         [EFL][WK2] Minibrowser : Support Zoom on Control key + scroll
1912         https://bugs.webkit.org/show_bug.cgi?id=136739
1913
1914         Reviewed by Gyuyoung Kim.
1915
1916         * MiniBrowser/efl/main.c: Add support for zoom on control key + mouse scroll
1917         (on_mouse_wheel): Modified.
1918
1919 2014-09-18  Carlos Garcia Campos  <cgarcia@igalia.com>
1920
1921         [GTK] Dot not allow to create delete-on-destroy GMainLoopSources
1922         https://bugs.webkit.org/show_bug.cgi?id=136923
1923
1924         Reviewed by Gustavo Noronha Silva.
1925
1926         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp:
1927         (TestWebKitAPI::TEST): Use the new API that doesn't allow to use
1928         the source.
1929
1930 2014-09-18  Csaba Osztrogonác  <ossy@webkit.org>
1931
1932         Fix countFailures of RunLLINTCLoopTests and Run32bitJSCTests (II)
1933         https://bugs.webkit.org/show_bug.cgi?id=136856
1934
1935         Reviewed by Darin Adler.
1936
1937         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1938         (RunLLINTCLoopTests.countFailures):
1939         (Run32bitJSCTests.countFailures):
1940         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1941         (RunLLINTCLoopTestsTest.test_failures):
1942         (RunLLINTCLoopTestsTest.test_failure):
1943         (RunLLINTCLoopTestsTest.test_no_failure):
1944         (Run32bitJSCTestsTest.test_failures):
1945         (Run32bitJSCTestsTest.test_failure):
1946         (Run32bitJSCTestsTest.test_no_failure):
1947
1948 2014-09-18  Zan Dobersek  <zdobersek@igalia.com>
1949
1950         GMainLoopSource is exposed to race conditions
1951         https://bugs.webkit.org/show_bug.cgi?id=135800
1952
1953         Reviewed by Carlos Garcia Campos.
1954
1955         Add unit tests for GMainLoopSource.
1956
1957         The tests check correct behavior of GMainLoopSource in various conditions --
1958         from the most simple rescheduling to rescheduling during dispatch, cancelling
1959         or destroying the GMainLoopSource during dispatch, proper destroy callback
1960         dispatching etc.
1961
1962         Scheduling both void (one-time) and bool (repeatable) callbacks is tested.
1963         State of the GMainLoopSource object (either ready, sheduled or active) is
1964         thoroughly tested throughout the lifetime of that object.
1965
1966         Still missing are tests for socket callbacks, which are a bit trickier because
1967         they rely on a GSocket object. The delete-on-destroy GMainLoopSource objects
1968         are also not tested thoroughly, simply because it is at the moment impossible
1969         to test that the objects are actually destroyed when the corresponding source
1970         is finally deleted.
1971
1972         * TestWebKitAPI/PlatformGTK.cmake:
1973         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp: Added.
1974         (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest):
1975         (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest):
1976         (TestWebKitAPI::GMainLoopSourceTest::runLoop):
1977         (TestWebKitAPI::GMainLoopSourceTest::delayedFinish):
1978         (TestWebKitAPI::GMainLoopSourceTest::finish):
1979         (TestWebKitAPI::GMainLoopSourceTest::source):
1980         (TestWebKitAPI::TEST):
1981
1982 2014-09-17  Ryuan Choi  <ryuan.choi@gmail.com>
1983
1984         Unreviewed, Update my email in contributors.json
1985
1986         * Scripts/webkitpy/common/config/contributors.json:
1987
1988 2014-09-17  Daniel Bates  <dabates@apple.com>
1989
1990         Unreviewed, rolling out r173695.
1991
1992         Broke building third-party Legacy WebKit apps; will
1993         investigate offline
1994
1995         Reverted changeset:
1996
1997         "[iOS] Make WebCore build with public iOS SDK"
1998         https://bugs.webkit.org/show_bug.cgi?id=136487
1999         http://trac.webkit.org/changeset/173695
2000
2001 2014-09-17  Daniel Bates  <dabates@apple.com>
2002
2003         [iOS] Make WebCore build with public iOS SDK
2004         https://bugs.webkit.org/show_bug.cgi?id=136487
2005
2006         Reviewed by David Kilzer.
2007
2008         Substitute <WebCore/MachVMSPI.h> for <mach/mach_vm.h>.
2009
2010         * DumpRenderTree/mac/CheckedMalloc.cpp:
2011
2012 2014-09-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2013
2014         [GTK] WebKitWebView::load-failed-with-tls-errors should receive the failing URI instead of a host
2015         https://bugs.webkit.org/show_bug.cgi?id=136889
2016
2017         Reviewed by Gustavo Noronha Silva.
2018
2019         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
2020         (testLoadFailedWithTLSErrors): Check that LoadFailedWithTLSErrors
2021         event was added to the events vector.
2022         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
2023         (loadFailedCallback): Do not assume the web view URI is the
2024         failing URI when the load fails before the committed state.
2025         (loadFailedWithTLSErrorsCallback): Handle the case of load failure
2026         because of TLS errors can call LoadTrackingTest::loadFailedWithTLSErrors.
2027         (LoadTrackingTest::LoadTrackingTest): Connect to WebKitWebView::load-failed-with-tls-errors.
2028         (LoadTrackingTest::loadFailedWithTLSErrors): Add
2029         LoadFailedWithTLSErrors event to the events vector.
2030         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
2031
2032 2014-09-17  Renato Nagy  <rnagy@inf.u-szeged.hu>
2033
2034         [EFL][GTK] Remove WebKit1 related codes
2035         https://bugs.webkit.org/show_bug.cgi?id=136853
2036
2037         Reviewed by Csaba Osztrogonác.
2038
2039         Gtk and EFL WebKit1 ports no longer exist. Webkit1 related codes were deleted
2040         from scripts.
2041
2042         * BuildSlaveSupport/build.webkit.org-config/config.json:
2043         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2044         (Compile32bitJSC):
2045         (BuildAndTestWebKit2Factory):
2046         (CompileWebKit1Only): Deleted.
2047         (CompileWebKit2Only): Deleted.
2048         (BuildAndTestWebKit1OnlyFactory): Deleted.
2049         (BuildAndTestWebKit2OnlyFactory): Deleted.
2050         * Scripts/build-webkit:
2051         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl:
2052         * Scripts/webkitpy/common/config/ports.py:
2053         (GtkWK2Port.build_webkit_command):
2054         (EflWK2Port.build_webkit_command):
2055         * Scripts/webkitpy/common/config/ports_unittest.py:
2056         (DeprecatedPortTest.test_gtk_wk2_port):
2057         * Scripts/webkitpy/port/efl.py:
2058         (EflPort.build_webkit_command):
2059         * Scripts/webkitpy/port/gtk.py:
2060         (GtkPort._built_libraries_path):
2061         (GtkPort._search_paths):
2062         (GtkPort.test_expectations_file_position):
2063         (GtkPort.build_webkit_command):
2064         (GtkPort.run_webkit_tests_command):
2065         (GtkPort.warn_if_bug_missing_in_test_expectations): Deleted.
2066
2067 2014-09-16  Daniel Bates  <dabates@apple.com>
2068
2069         [iOS] Add iOS SDK name and version suffix to WebKitSystemInterface debug/release product name
2070         https://bugs.webkit.org/show_bug.cgi?id=136862
2071
2072         Reviewed by David Kilzer.
2073
2074         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2075         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2076         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Remove hardcoded iOS 8.0
2077         IPHONEOS_DEPLOYMENT_TARGET to ensure we link against the latest version of WebKitSystemInterface.
2078
2079 2014-09-12  Ryosuke Niwa  <rniwa@webkit.org>
2080
2081         Mac queue slaves should reboot every so often
2082         https://bugs.webkit.org/show_bug.cgi?id=136791
2083
2084         Reviewed by Alexey Proskuryakov.
2085
2086         Reboot Mac queue slaves every night between 1 A.M. and 6 A.M.
2087
2088         * EWSTools/start-queue-mac.sh:
2089
2090 2014-09-16  Csaba Osztrogonác  <ossy@webkit.org>
2091
2092         Unreviewed gardening, skip one more tests on Windows.
2093
2094         * Scripts/run-javascriptcore-tests:
2095
2096 2014-09-16  Csaba Osztrogonác  <ossy@webkit.org>
2097
2098         JSC test gardening
2099         https://bugs.webkit.org/show_bug.cgi?id=136823
2100
2101         Reviewed by Geoffrey Garen.
2102
2103         * Scripts/run-javascriptcore-tests: Skip tests on only the affected platforms.
2104
2105 2014-09-16  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2106
2107         Remove shouldAbortEarly cruft from master.cfg
2108         https://bugs.webkit.org/show_bug.cgi?id=136779
2109
2110         Reviewed by Csaba Osztrogonác.
2111
2112         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2113         (ConfigureBuild.start):
2114         (RunWebKitTests.start):
2115         (RunWebKit2Tests.start): Deleted.
2116
2117 2014-09-15  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2118
2119         Remove ORWT related crufts from webkitdirs.pm
2120         https://bugs.webkit.org/show_bug.cgi?id=136821
2121
2122         Reviewed by Alexey Proskuryakov.
2123
2124         * Scripts/webkitdirs.pm:
2125         (isPerianInstalled): Deleted.
2126         (determineIPhoneSimulatorVersion): Deleted.
2127         (iPhoneSimulatorVersion): Deleted.
2128         (isSnowLeopard): Deleted.
2129         (isLion): Deleted.
2130         (quitIOSSimulator): Deleted.
2131
2132 2014-09-15  Roger Fong  <roger_fong@apple.com>
2133
2134         Unreviewed. Skip yet another ecma/Date test that fails only on Windows.
2135         https://bugs.webkit.org/show_bug.cgi?id=25160
2136
2137         * Scripts/run-javascriptcore-tests:
2138
2139 2014-09-15  Lucas Forschler  <lforschler@apple.com>
2140
2141         Add another Apple build slave to the Mountain Lion Debug WK1 queue
2142         
2143         Rubber stamped by Matt Hanson.
2144         
2145         * BuildSlaveSupport/build.webkit.org-config/config.json:
2146
2147 2014-09-15  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
2148
2149         [EFL] Ecore and Eina are initialized twice in TestWebKitAPI
2150         https://bugs.webkit.org/show_bug.cgi?id=136822
2151
2152         Reviewed by Gyuyoung Kim.
2153
2154         In TestWebKitAPI/efl/main.cpp, ecore and eina modules are unnecessarily
2155         initialized as we already does it in PlatformWebView::PlatformWebView
2156         calling ewk_init(). The reason for that was to ensure testing for example,
2157         WTF where creating the view is not mandatory.
2158
2159         Call ewk_init() and ewk_shutdown() in TestWebKitAPI/efl/main.cpp
2160         in order to properly initalize and release EWebKit.
2161
2162         * TestWebKitAPI/PlatformEfl.cmake:
2163         * TestWebKitAPI/efl/PlatformWebView.cpp:
2164         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2165         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
2166         * TestWebKitAPI/efl/main.cpp:
2167         (main):
2168
2169 2014-09-15  peavo@outlook.com  <peavo@outlook.com>
2170
2171         [WinCairo] Make it easier to enable/disable GStreamer.
2172         https://bugs.webkit.org/show_bug.cgi?id=135766
2173
2174         Reviewed by Brent Fulgham.
2175
2176         Make it possible to enable/disable GStreamer by editing the new user macro ENABLE_GSTREAMER_WINCAIRO.
2177
2178         * WinLauncher/WinMain.cpp: Compile fix when GStreamer is enabled.
2179
2180 2014-09-12  Brian J. Burg  <burg@cs.washington.edu>
2181
2182         Web Inspector: remind about rebaselining generator test results
2183         https://bugs.webkit.org/show_bug.cgi?id=136759
2184
2185         Reviewed by Joseph Pecoraro.
2186
2187         For now, we can implement this as a watchlist message. Add watchlist
2188         groups and messages for the inspector and web replay generators.
2189
2190         * Scripts/webkitpy/common/config/watchlist:
2191
2192 2014-09-12  Alexey Proskuryakov  <ap@apple.com>
2193
2194         build.webkit.org/dashboard: Overlapping text when status is long
2195         https://bugs.webkit.org/show_bug.cgi?id=136794
2196
2197         Reviewed by Timothy Hatcher.
2198
2199         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
2200         (.status-line): Replaces height with min-height.
2201
2202 2014-09-12  Timothy Hatcher  <timothy@apple.com>
2203
2204         Make Brian Burg a WebKit reviewer.
2205
2206         * Scripts/webkitpy/common/config/contributors.json: Move Brian Burg's entry.
2207
2208 2014-09-12  Alexey Proskuryakov  <ap@apple.com>
2209
2210         Multiple EWS or commit bots can pick up processing of the same patch
2211         https://bugs.webkit.org/show_bug.cgi?id=136793
2212
2213         Reviewed by Ryosuke Niwa.
2214
2215         Change timeout from one hour to two hours. This will let bots finish, and in the
2216         unlikely event of a bot being frozen, will only delay patch processing restart by
2217         one hour.
2218
2219         * QueueStatusServer/app.yaml:
2220         * QueueStatusServer/model/activeworkitems.py: (ActiveWorkItems.deactivate_expired):
2221
2222 2014-09-11  Andy Estes  <aestes@apple.com>
2223
2224         [WebKit2] WKImageCreateCGImage crashes when passed a null WKImage
2225         https://bugs.webkit.org/show_bug.cgi?id=136768
2226
2227         Reviewed by Tim Horton.
2228
2229         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2230         * TestWebKitAPI/Tests/WebKit2/WKImageCreateCGImageCrash.cpp: Added.
2231         (TestWebKitAPI::TEST):
2232
2233 2014-09-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2234
2235         REGRESSION(r173423): CertificateInfo is never sent to the UI process when using shared secondary process model
2236         https://bugs.webkit.org/show_bug.cgi?id=136669
2237
2238         Reviewed by Antti Koivisto.
2239
2240         * Scripts/run-gtk-tests:
2241         (TestRunner): Unskip SSL test.
2242
2243 2014-09-12  Eric Carlson  <eric.carlson@apple.com>
2244
2245         Strip extraneous AVFoundation and CoreMedia logging
2246         https://bugs.webkit.org/show_bug.cgi?id=136747
2247
2248         Reviewed by Jer Noble.
2249
2250         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2251         (SingleTestRunner._run_compare_test): Allow the port to specify patterns to strip from stderr.
2252
2253         * Scripts/webkitpy/port/base.py:
2254         (Port.stderr_patterns_to_strip): Base class, empty list
2255
2256         * Scripts/webkitpy/port/driver.py:
2257         (DriverOutput.strip_stderror_patterns): Strip the specified patterns from stderr.
2258
2259         * Scripts/webkitpy/port/ios.py:
2260         (IOSSimulatorPort.stderr_patterns_to_strip): iOS patterns - there are none.
2261
2262         * Scripts/webkitpy/port/mac.py:
2263         (MacPort.stderr_patterns_to_strip): CoreMedia and AVFoundation logging we can ignore.
2264
2265
2266 2014-09-11  Michael Saboff  <msaboff@apple.com>
2267
2268         lldb_webkit.py:btjs doesn't work with release builds
2269         https://bugs.webkit.org/show_bug.cgi?id=136760
2270
2271         Reviewed by Jer Noble.
2272
2273         If we can't get a result calling JSC::ExecState::describeFrame(), try calling the
2274         mangled name _ZN3JSC9ExecState13describeFrameEv.  Also cleaned up the handling if
2275         we can't get a valid result from trying either call.  In that case, we fallback to
2276         just showing the PC.  Also added check for both entry points.  If neither is found,
2277         we issue a warning and output the stack trace without JavaScript annotations.
2278
2279         * lldb/lldb_webkit.py:
2280         (btjs):
2281
2282 2014-09-11  Rebecca Hauck  <rhauck@adobe.com>
2283
2284         webkitpy test failures from import-w3c-tests
2285         https://bugs.webkit.org/show_bug.cgi?id=136752
2286
2287         Reviewed by Bem Jones-Bey.
2288
2289         This patch fixes a bug in import-w3c-tests where we were appending
2290         the wrong set of files to the copy_list. This also updates the tests
2291         to clear the failures introduced in the patch for bug 135929.
2292
2293         * Scripts/webkitpy/w3c/test_converter_unittest.py:
2294         (W3CTestConverterTest.test_read_prefixed_property_list):
2295         * Scripts/webkitpy/w3c/test_parser.py:
2296         (TestParser.analyze_test):
2297         (TestParser.support_files):
2298         * Scripts/webkitpy/w3c/test_parser_unittest.py:
2299
2300 2014-09-10  Brent Fulgham  <bfulgham@apple.com>
2301
2302         Blink merge: Speculative fix for windows run-webkit-tests hangs
2303         https://bugs.webkit.org/show_bug.cgi?id=136727
2304
2305         Reviewed by Csaba Osztrogonác.
2306
2307         Merged from Blink (patch by Dirk Pranke):
2308         <https://chromium.googlesource.com/chromium/blink/+/0cdd98d44a20c3951562ccf8b08b1fefba8dac67%5E%21/#F0>
2309
2310         * Scripts/webkitpy/common/system/executive.py:
2311         (Executive.kill_process):
2312
2313 2014-09-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2314
2315         Added myself as a committer.
2316
2317         Unreviewed.
2318
2319         * Scripts/webkitpy/common/config/contributors.json:
2320
2321 2014-09-11  László Langó  <llango.u-szeged@partner.samsung.com>
2322
2323         [JavaScriptCore] Fix FTL on platform EFL.
2324         https://bugs.webkit.org/show_bug.cgi?id=133571
2325
2326         Reviewed by Filip Pizlo.
2327
2328         * efl/install-dependencies: Revert r169181.
2329         * efl/jhbuild.modules: Clone and build a custom branch.
2330         This branch contains some fix for FTL of platform EFL.
2331         The branch is a fork of llvm r206311.
2332
2333 2014-09-10  Tanay C  <tanay.c@samsung.com>
2334
2335         [EFL][WK2] Minibrowser : Shift+Scroll navigate to back or forward url's
2336         https://bugs.webkit.org/show_bug.cgi?id=136698
2337
2338         Reviewed by Gyuyoung Kim.
2339
2340         * MiniBrowser/efl/main.c: Add functionality to support shift + mouse scroll navigation
2341         (on_mouse_wheel): Added.
2342         (window_free):
2343         (window_create):
2344
2345 2014-09-10  Rohit Kumar  <kumar.rohit@samsung.com>
2346
2347         [EFL][WK2] Minibrowser : Add tooltip for toolbar buttons in Minibrowser
2348         https://bugs.webkit.org/show_bug.cgi?id=136284
2349
2350         Reviewed by Gyuyoung Kim.
2351
2352         * MiniBrowser/efl/main.c:
2353         (window_create):
2354
2355 2014-09-10  Rebecca Hauck  <rhauck@adobe.com>
2356
2357         import-w3c-tests doesn't handle relative paths to support files in ref files correctly
2358         https://bugs.webkit.org/show_bug.cgi?id=135929
2359
2360         Reviewed by Bem Jones-Bey.
2361
2362         The recent refactor of the W3C test repo falsified a bunch of assmumptions that
2363         were made when this script was originally written with respect to relative paths
2364         in ref files. This patch updates import-w3c-tests to update paths in ref files if
2365         they move relative to the test file.
2366
2367
2368         * Scripts/webkitpy/w3c/test_converter.py:
2369         (convert_for_webkit):
2370         (_W3CTestConverter.__init__):
2371         (_W3CTestConverter.convert_reference_relpaths):
2372         (_W3CTestConverter.convert_style_data):
2373         (_W3CTestConverter.convert_attributes_if_needed):
2374         * Scripts/webkitpy/w3c/test_importer.py:
2375         (TestImporter.find_importable_tests):
2376         (TestImporter.import_tests):
2377         * Scripts/webkitpy/w3c/test_parser.py:
2378         (TestParser.load_file):
2379         (TestParser.analyze_test):
2380         (TestParser.support_files):
2381
2382 2014-09-10  Michael Catanzaro  <mcatanzaro@igalia.com>
2383
2384         [GTK] allow overwriting destination of download
2385         https://bugs.webkit.org/show_bug.cgi?id=136372
2386
2387         Reviewed by Carlos Garcia Campos.
2388
2389         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
2390         (downloadLocalFileSuccessfully): Split from testDownloadLocalFile
2391         (testDownloadLocalFile): Split off downloadLocalFileSuccessfully
2392         (createFileAtDestination): Added
2393         (testDownloadOverwriteDestinationAllowed): Added
2394         (testDownloadOverwriteDestinationDisallowed): Added
2395         (testDownloadLocalFileError): Use new DownloadErrorTest::ExpectedError
2396         (testDownloadRemoteFileError): Use new DownloadErrorTest::ExpectedError
2397         (beforeAll): New tests
2398
2399 2014-08-05  David Farler  <dfarler@apple.com>
2400
2401         iOS Simulator: run-webkit-tests chokes on unterminated UTF-8 when writing a test result
2402         https://bugs.webkit.org/show_bug.cgi?id=135551
2403
2404         Reviewed by Daniel Bates.
2405
2406         Prevent printing invalid Unicode strings going to stderr.
2407         Also, make filesystem.py more tolerant about receiving
2408         Unicode (encoded as UTF-8) when writing to files, in the
2409         rare case that an NSError description will make it to
2410         stderr, such as -[LTRelayController createUniqueApp].
2411
2412         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2413         (-[LTRelayController launchSimulator]): Removed.
2414         (-[LTRelayController createUniqueApp]):
2415         Don't explicitly try to uninstall the app. It is automatically handled
2416         when installing an app with the same bundle identifier.
2417         (-[LTRelayController start]):
2418         (-[LTRelayController bootDevice]): Removed.
2419         The device already boots as a part of starting the simulator. Attempting
2420         to boot a second time may cause spurious stderr output.
2421         * Scripts/webkitpy/port/driver.py:
2422         (IOSSimulatorDriver._setup_environ_for_driver):
2423         Explicitly set DEVELOPER_DIR once so xcode-select isn't called.
2424         Open the iOS Simulator once instead of the LayoutTestRelay trying
2425         to do it.
2426         * Scripts/webkitpy/port/ios.py:
2427         (IOSSimulatorPort._get_crash_log):
2428         Make sure stderr is at least an empty string.
2429         (IOSSimulatorPort):
2430         (IOSSimulatorPort.developer_dir):
2431         New property for setting up DEVELOPER_DIR in the driver environment.
2432
2433 2014-09-09  Dan Bernstein  <mitz@apple.com>
2434
2435         Clean up the MiniBrowser Xcode project
2436         https://bugs.webkit.org/show_bug.cgi?id=136684
2437
2438         Reviewed by Tim Horton.
2439
2440         * MiniBrowser/Configurations/Base.xcconfig: Enabled warnings recommended by Xcode 6.
2441         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Removed explicit linking against
2442         WebKit2.framework. Upgraded project file version.
2443
2444 2014-09-09  Daniel Bates  <dbates@webkit.org>
2445
2446         svn-{apply, unapply} fails to apply/unapply SVN 1.7 patch that adds new file with property change
2447         https://bugs.webkit.org/show_bug.cgi?id=136379
2448
2449         Reviewed by David Kilzer.
2450
2451         Fixes an issue where svn-{apply, unapply} fail to apply or unapply, respectively,
2452         a patch generated using Subversion 1.7.4 (r1295709) that both adds a new file F
2453         and sets a property on F (say, the executable bit).
2454
2455         * Scripts/svn-apply:
2456         (patch): Only add file if the diff has text chunks.
2457         * Scripts/svn-unapply:
2458         (patch): Only delete added file if the diff has text chunks.
2459
2460 2014-09-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2461
2462         [GTK] Unreviewed GTK gardening.
2463
2464         * Scripts/run-gtk-tests:
2465         (TestRunner): Skip TestSSL:webkit2/WebKitWebView/ssl (fails since r173423).
2466
2467 2014-09-09  Christophe Dumez  <cdumez@apple.com>
2468
2469         Update my email in contributors.json
2470         https://bugs.webkit.org/show_bug.cgi?id=136671
2471
2472         Reviewed by Andreas Kling.
2473
2474         * Scripts/webkitpy/common/config/contributors.json:
2475
2476 2014-09-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2477
2478         [EFL] Enable fixed layout by default
2479         https://bugs.webkit.org/show_bug.cgi?id=136607
2480
2481         Reviewed by Csaba Osztrogonác.
2482
2483         Fixed layout is being used by Tizen platform by default. However, the feature
2484         has still many defects now. So, we need to enable it by default, then should fix
2485         those bugs. 
2486
2487         * MiniBrowser/efl/main.c:
2488
2489 2014-09-08  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2490
2491         Remove FILTERS flag
2492         https://bugs.webkit.org/show_bug.cgi?id=136571
2493
2494         Reviewed by Darin Adler.
2495
2496         * Scripts/webkitperl/FeatureList.pm:
2497
2498 2014-09-08  Alexey Proskuryakov  <ap@apple.com>
2499
2500         Dashboard metrics should ignore commits that didn't trigger builds
2501         https://bugs.webkit.org/show_bug.cgi?id=136618
2502
2503         Reviewed by Darin Adler.
2504
2505         Commits that didn't trigger builds are ones like ChangeLog updates, patches for
2506         other platforms etc. It does not make sense to count wait time for these, as it
2507         can be arbitrarily long.
2508
2509         The new algorithm is much slower asymptotically, but it's OK, computers are fast.
2510
2511         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2512         (BuildbotIteration.prototype._parseData): Record changes that triggered the iteration.
2513
2514         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2515         We used to walk the timeline to see which revisions are fully tested, but that's not
2516         correct. A revision that's only tested by a subset of queues finishes independently
2517         of another that's tested by another subset. Now, we just search for the answer for
2518         each revision individually.
2519
2520         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsView.js:
2521         (MetricsView.prototype._update.appendQueueResults): Added worst revision number, which
2522         the analyzer now reports. Removed best time, which is more confusing than meaningful.
2523
2524 2014-09-08  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2525
2526         Remove EWebLauncher from webkitdirs.pm
2527         https://bugs.webkit.org/show_bug.cgi?id=136622
2528
2529         Reviewed by Gyuyoung Kim.
2530
2531         * Scripts/webkitdirs.pm:
2532         (launcherName):
2533
2534 2014-09-06  Sam Weinig  <sam@webkit.org>
2535
2536         XPCPtr should be converted into an all purpose smart pointer for os_objects
2537         https://bugs.webkit.org/show_bug.cgi?id=136602
2538
2539         Reviewed by Darin Adler.
2540
2541         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2542         * TestWebKitAPI/Tests/WTF/darwin: Added.
2543         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp: Added.
2544         Add basic unit tests for OSObjectPtr.
2545
2546 2014-09-06  Saam Barati  <saambarati1@gmail.com>
2547
2548         Unreviewed. Add myself as a committer.
2549
2550         * Scripts/webkitpy/common/config/contributors.json:
2551
2552 2014-09-06  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2553
2554         Unreviewed, EFL build fix when SHARED_CORE is on.
2555
2556         * TestWebKitAPI/PlatformEfl.cmake:
2557
2558 2014-09-05  Lucas Forschler  <lforschler@apple.com>
2559
2560         <https://webkit.org/b/136586> Add bots to Apple build/test queues
2561         
2562         Reviewed by Daniel Bates.
2563
2564         * BuildSlaveSupport/build.webkit.org-config/config.json:
2565
2566 2014-09-05  Alexey Proskuryakov  <ap@apple.com>
2567
2568         Buildbot metrics page gives wrong results after a new bot gets added
2569         https://bugs.webkit.org/show_bug.cgi?id=136516
2570
2571         Reviewed by Tim Horton.
2572
2573         Part 2: Fix elapsed times.
2574
2575         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2576         (Analyzer.prototype._countTimes): Made lastTestedRevisionByQueue contain undefined values
2577         until the first build in a queue. This happens to work as needed with _fullyTestedRevisionNumber().
2578
2579 2014-09-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2580
2581         [SOUP] Implement ResourceResponse::platformSuggestedFilename() when USE(SOUP) is enabled.
2582         https://bugs.webkit.org/show_bug.cgi?id=136562
2583
2584         Reviewed by Martin Robinson.
2585
2586         * Scripts/run-gtk-tests:
2587         (TestRunner): Remove failure expectations for tests that now pass.
2588
2589 2014-09-04  Alexey Proskuryakov  <ap@apple.com>
2590
2591         Dashboard metrics page wastes a lot of time sorting iterations
2592         https://bugs.webkit.org/show_bug.cgi?id=136559
2593
2594         Reviewed by Tim Horton.
2595
2596         Also fixes comments here and there, and adds a missing "var".
2597
2598         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2599         (BuildbotIteration.prototype._parseData):
2600         (BuildbotIteration.prototype._updateWithData):
2601         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2602         (BuildbotQueue.prototype.loadAll):
2603         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2604         (Analyzer.prototype._countTimes):
2605
2606 2014-09-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2607
2608         [GTK] Unreviewed GTK gardening.
2609
2610         * Scripts/run-gtk-tests:
2611         (TestRunner): Skip tests failing since r173272.
2612
2613 2014-09-04  Simon Fraser  <simon.fraser@apple.com>
2614
2615         Add some logging to help diagnose assertions in dumpWebViewAsPixelsAndCompareWithExpected() on bots
2616         https://bugs.webkit.org/show_bug.cgi?id=136561
2617
2618         Reviewed by Tim Horton.
2619         
2620         Log for calloc() and CGBitmapContextCreate() failures.
2621
2622         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2623         (createBitmapContext):
2624         (createBitmapContextFromWebView):
2625
2626 2014-09-04  Andy Estes  <aestes@apple.com>
2627
2628         Fix the Mac Production build after r173283.
2629
2630         * WebKitTestRunner/config.h: Reverted to defining WEBCORE_EXPORT for now.
2631
2632 2014-09-04  Brent Fulgham  <bfulgham@apple.com>
2633
2634         [Win] webkitpy test suite frequently fails to complete
2635         https://bugs.webkit.org/show_bug.cgi?id=136546
2636
2637         Reviewed by Daniel Bates.
2638
2639         Properly convert the ASCII crash log produced by ntsd into
2640         a unicode string as early as possible so that we handle it
2641         properly when generating our logs and other test support output.
2642
2643         We were mixing ASCII/unicode strings under Windows, which was
2644         causing test system failures when we processed some crash logs.
2645
2646         Also do a better job of handling garbage pid entries in the
2647         Cygwin lock files.
2648
2649         * Scripts/webkitpy/common/system/crashlogs.py:
2650         (CrashLogs._find_newest_log_win): The ntsd '.logopen' command
2651         creates an ASCII file. Decode it as ASCII, not 'utf-8', and
2652         handle the strings as unicode from that point on.
2653         * Scripts/webkitpy/port/http_lock.py:
2654         (HttpLock._current_lock_pid): Add logging and handle case of
2655         the current_pid failing to cleanly convert to 'int'.
2656         * Scripts/webkitpy/port/win.py:
2657         (WinPort): Add 64-bit architecture as a known target for the
2658         Windows build.
2659
2660 2014-09-04  Andy Estes  <aestes@apple.com>
2661
2662         Address additional review feedback after landing r173283.
2663
2664         Reviewed by Daniel Bates.
2665
2666         * DumpRenderTree/config.h: Removed redundant includes.
2667         * TestWebKitAPI/config.h: Ditto.
2668         * WebKitTestRunner/config.h: Ditto.
2669
2670 2014-09-03  Andy Estes  <aestes@apple.com>
2671
2672         [Cocoa] Some WebKitLegacy headers migrated from WebCore incorrectly contain WEBCORE_EXPORT
2673         https://bugs.webkit.org/show_bug.cgi?id=136521
2674
2675         Reviewed by Anders Carlsson.
2676
2677         * DumpRenderTree/config.h: Included <WebCore/PlatformExportMacros.h> instead of defining WEBCORE_EXPORT.
2678         * TestWebKitAPI/config.h: Ditto.
2679         * WebKitTestRunner/config.h: Ditto.
2680
2681 2014-09-04  Alexey Proskuryakov  <ap@apple.com>
2682
2683         REGRESSION: Dashboard metrics page aggregation counts performance bots
2684         https://bugs.webkit.org/show_bug.cgi?id=136539
2685
2686         Reviewed by Tim Horton.
2687
2688         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
2689
2690 2014-09-04  Brent Fulgham  <bfulgham@apple.com>
2691
2692         [Win] Perl test fix.
2693
2694         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl: Correct test to check for
2695         VersionStamp.exe tool, not just the driver script.
2696
2697 2014-09-04  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2698
2699         Remove CSS_FILTERS flag
2700         https://bugs.webkit.org/show_bug.cgi?id=136529
2701
2702         Reviewed by Dirk Schulze.
2703
2704         * Scripts/webkitperl/FeatureList.pm:
2705
2706 2014-09-04  Commit Queue  <commit-queue@webkit.org>
2707
2708         Unreviewed, rolling out r173201.
2709         https://bugs.webkit.org/show_bug.cgi?id=136538
2710
2711         Improves the situation but also introduces additional crashes.
2712         (Requested by zdobersek on #webkit).
2713
2714         Reverted changeset:
2715
2716         "GMainLoopSource is exposed to race conditions"
2717         https://bugs.webkit.org/show_bug.cgi?id=135800
2718         http://trac.webkit.org/changeset/173201
2719
2720 2014-09-03  Alexey Proskuryakov  <ap@apple.com>
2721
2722         Buildbot metrics page gives wrong results after a new bot gets added
2723         https://bugs.webkit.org/show_bug.cgi?id=136516
2724
2725         Part 1: Fix red/green counters. Dashboard is considered green at a given time
2726         if all the bots that ever had results before this time are green.
2727
2728         This doesn't (and cannot) address situations where the bot gets removed and then
2729         re-added. It also gives wrong results after a bot gets removed, because it doesn't
2730         know that it was ever displayed on the dashboard.
2731
2732         Reviewed by Darin Adler.
2733
2734         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2735         (Analyzer.prototype._dashboardIsAllGreen):
2736         (Analyzer.prototype._updateStretchOfRedCounters):
2737         (Analyzer.prototype._countPercentageOfGreen):
2738         (Analyzer.prototype._allQueuesAreSuccessful): Deleted.
2739
2740 2014-09-03  Brent Fulgham  <bfulgham@apple.com>
2741
2742         [Win] Unreviewed test fix.
2743
2744         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl: Don't fail
2745         test if user doesn't have the VersionStamp.exe program.
2746
2747 2014-09-03  Dana Burkart  <dburkart@apple.com>
2748
2749         Unreviewed. Add myself as a committer.
2750
2751         * Scripts/webkitpy/common/config/contributors.json:
2752
2753 2014-09-03  Alexey Proskuryakov  <ap@apple.com>
2754
2755         build.webkit.org/dashboard performance popover is unstyled
2756         https://bugs.webkit.org/show_bug.cgi?id=136499
2757
2758         Reviewed by Tim Horton.
2759
2760         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
2761         (.performance-popover):
2762         (.performance-popover .dashboard-link):
2763
2764 2014-09-03  Saam Barati  <saambarati1@gmail.com>
2765
2766         Create tests for type profiling
2767         https://bugs.webkit.org/show_bug.cgi?id=136161
2768
2769         Reviewed by Geoffrey Garen.
2770
2771         Have run-javascriptcore-tests run the newly created
2772         tests for the type profiler.
2773
2774         * Scripts/run-javascriptcore-tests:
2775         * Scripts/run-jsc-stress-tests:
2776
2777 2014-09-03  Brent Fulgham  <bfulgham@apple.com>
2778
2779         [Win] Revise test environment for Windows build.
2780         https://bugs.webkit.org/show_bug.cgi?id=136486
2781
2782         Reviewed by David Kilzer.
2783
2784         The various calls to get the Safari path really only have
2785         meaning on the Mac. Other ports get access to the build
2786         and test environment separately, so remove the various
2787         checks in the Safari-specific code to simplify things.
2788
2789         Remove some 64-bit hacks used on Windows now that the
2790         various tools know how to find the 64-bit runtime environment.
2791
2792         * Scripts/run-javascriptcore-tests: 
2793         * Scripts/webkitdirs.pm:
2794         (safariPathFromSafariBundle): Revise to expect Mac.
2795         (installedSafariPath): Ditto.
2796         (safariPath): Ditto.
2797         (appleApplicationSupportPath): Get rid of 64-bit Windows hack.
2798         (setPathForRunningWebKitApp): Get rid of unused SafariPath
2799         argument for Windows runs.
2800
2801 2014-09-03  Dana Burkart  <dburkart@apple.com>
2802
2803         Dashboard should show performance bots.
2804         https://bugs.webkit.org/show_bug.cgi?id=136386
2805
2806         Reviewed by Alexey Proskuryakov.
2807
2808         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2809         (BuildbotIteration.prototype._parseData.collectPerfTestResults):
2810         (BuildbotIteration.prototype._parseData):
2811         Support possible performance failures.
2812
2813         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js:
2814         New QueueView to manage the way we present performance data.
2815
2816         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2817         (BuildbotQueue):
2818         Support new 'performance' and 'performanceTestName' keys.
2819
2820
2821         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2822         Add performance column to the main page.
2823
2824         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2825         (WebKitBuildbot):
2826         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2827         (body):
2828         Make sure everything fits on 13 inch screens.
2829
2830         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
2831
2832 2014-09-03  Zan Dobersek  <zdobersek@igalia.com>
2833
2834         GMainLoopSource is exposed to race conditions
2835         https://bugs.webkit.org/show_bug.cgi?id=135800
2836
2837         Reviewed by Carlos Garcia Campos.
2838
2839         Add a unit test for GMainLoopSource that tests different
2840         types of rescheduling tasks on already-active sources.
2841
2842         * TestWebKitAPI/PlatformGTK.cmake:
2843         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp: Added.
2844         (GMainLoopSourceTest::GMainLoopSourceTest):
2845         (GMainLoopSourceTest::~GMainLoopSourceTest):
2846         (GMainLoopSourceTest::runLoop):
2847         (GMainLoopSourceTest::finish):
2848         (GMainLoopSourceTest::source):
2849         (testGMainLoopSourceBasicRescheduling):
2850         (testGMainLoopSourceReentrantRescheduling):
2851         (testGMainLoopSourceDifferentThreadRescheduling):
2852         (beforeAll):
2853         (afterAll):
2854         (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest):
2855         (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest):
2856         (TestWebKitAPI::GMainLoopSourceTest::runLoop):
2857         (TestWebKitAPI::GMainLoopSourceTest::finish):
2858         (TestWebKitAPI::GMainLoopSourceTest::source):
2859         (TestWebKitAPI::TEST):
2860
2861 2014-09-02  Simon Fraser  <simon.fraser@apple.com>
2862
2863         Make sure WK1 prefs are initialized in MiniBrowser
2864         https://bugs.webkit.org/show_bug.cgi?id=136465
2865
2866         Reviewed by Tim Horton.
2867         
2868         Call -didChangeSettings from -awakeFromNib for WK1 windows just as we do
2869         for WK2 windows, to make sure that WebPreferences are updated (to get
2870         layer borders to work consistently).
2871
2872         * MiniBrowser/mac/WK1BrowserWindowController.m:
2873         (-[WK1BrowserWindowController awakeFromNib]):
2874
2875 2014-09-02  Renato Nagy  <rnagy@inf.u-szeged.hu>
2876
2877         check-webkit-style should complain about C++ comments in Platform.h
2878         https://bugs.webkit.org/show_bug.cgi?id=133802
2879
2880         Reviewed by Csaba Osztrogonác.
2881
2882         * Scripts/webkitpy/style/checkers/cpp.py:
2883         (check_platformh_comments):
2884         (_process_lines):
2885         (CppChecker):
2886         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2887         (CppStyleTest.test_platformh_comment):
2888
2889 2014-09-02  Brendan Long  <self@brendanlong.com>
2890
2891         [Gtk] Make install-dependencies work on Arch Linux
2892         https://bugs.webkit.org/show_bug.cgi?id=136374
2893
2894         Reviewed by Philippe Normand.
2895
2896         * gtk/install-dependencies: Add dependencies for pacman (Arch Linux).
2897
2898 2014-09-01  Brian J. Burg  <burg@cs.washington.edu>
2899
2900         Provide column numbers to DTrace willExecute/didExecute probes
2901         https://bugs.webkit.org/show_bug.cgi?id=136434
2902
2903         Reviewed by Antti Koivisto.
2904
2905         Create a directory for DTrace scripts. Add an example script that
2906         shows how to use static probes provided by JavaScriptCore's profiler.
2907
2908         * Scripts/dtrace/jsc-trace-profiler-events.d: Added.
2909
2910 2014-09-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2911
2912         [GTK] [JHBuild] Cyclic dependency between cairo and librsvg.
2913         https://bugs.webkit.org/show_bug.cgi?id=136431
2914
2915         Reviewed by Martin Robinson.
2916
2917         * gtk/jhbuild.modules: Disable cairo SVG testsuite.
2918         Add missing dependencies for librsvg (glib and cairo).
2919
2920 2014-09-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2921
2922         [GTK] install-dependencies don't installs dbus-launch that is needed for the API tests.
2923         https://bugs.webkit.org/show_bug.cgi?id=136425
2924
2925         Reviewed by Martin Robinson.
2926
2927         * gtk/install-dependencies: Add dbus-x11 to the list of packages needed for running the tests.
2928
2929 2014-09-01  Ryuan Choi  <ryuan.choi@samsung.com>
2930
2931         Update my list of email addresses in contributors.json
2932         https://bugs.webkit.org/show_bug.cgi?id=136424
2933
2934         Reviewed by Gyuyoung Kim.
2935
2936         * Scripts/webkitpy/common/config/contributors.json:
2937
2938 2014-08-30  Filip Pizlo  <fpizlo@apple.com>
2939
2940         [RJST] eager-no-cjit should really mean eager
2941         https://bugs.webkit.org/show_bug.cgi?id=136407
2942
2943         Reviewed by Mark Hahnenberg.
2944         
2945         At some point we made NO_CJIT_OPTIONS force threshold settings to something reasonable
2946         and well-known. But the way we appended options was such that NO_CJIT_OPTIONS came in
2947         after EAGER_OPTIONS. The whole point of "eager" was to use eager tier-up thresholds. This
2948         all meant that NO_CJIT_OPTIONS was overriding the eagerness of EAGER_OPTIONS, for the one
2949         threshold setting that NO_CJIT_OPTIONS was currently setting
2950         (thresholdForJITAfterWarmUp). The solution is to make sure that we always append
2951         NO_CJIT_OPTIONS before we append EAGER_OPTIONS.
2952         
2953         Luckily, no tests regressed during the time that we lost eager-no-cjit coverage.
2954
2955         * Scripts/run-jsc-stress-tests:
2956
2957 2014-08-29  Daniel Bates  <dabates@apple.com>
2958
2959         [iOS] Configure Xcode to build a command line tool for the iOS Simulator
2960         https://bugs.webkit.org/show_bug.cgi?id=136388
2961
2962         Reviewed by David Kilzer.
2963
2964         Add a script, called configure-xcode-for-ios-development, to configure Xcode to
2965         support building a command line tool for the iOS Simulator. You must run this
2966         script as root.
2967
2968         The script uses the xcspec files in the OS X SDK to create xcspec files in the
2969         iOS Simulator SDK with the product- and package- type definitions to build a
2970         command line tool, if applicable.
2971
2972         * Scripts/configure-xcode-for-ios-development: Added.
2973
2974 2014-08-29  Tim Horton  <timothy_horton@apple.com>
2975
2976         Remove Windows WebKit2 code from TestWebKitAPI
2977         https://bugs.webkit.org/show_bug.cgi?id=136385
2978
2979         Reviewed by Alexey Proskuryakov.
2980
2981         * TestWebKitAPI/PlatformUtilities.h:
2982         * TestWebKitAPI/PlatformWebView.h:
2983         (TestWebKitAPI::PlatformWebView::setParentWindowMessageObserver): Deleted.
2984         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
2985         (TestWebKitAPI::TEST): Deleted.
2986         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
2987         (TestWebKitAPI::TEST):
2988         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2989         (TestWebKitAPI::TEST):
2990         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp: Removed.
2991         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp: Removed.
2992         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp: Removed.
2993         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp: Removed.
2994         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp: Removed.
2995         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp: Removed.
2996         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp: Removed.
2997
2998 2014-08-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2999
3000         [JSC] Some JSC tests are dependent on the machine time zone.
3001         https://bugs.webkit.org/show_bug.cgi?id=136363
3002
3003         Reviewed by Filip Pizlo.
3004
3005         * Scripts/run-javascriptcore-tests: Export TZ environment variable to US/Pacific.
3006         Unskip the tests that were skipped on r99580.
3007
3008 2014-08-29  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3009
3010         [EFL] Remove non Coordinated Graphics code path from cmake build system after r142169
3011         https://bugs.webkit.org/show_bug.cgi?id=135560
3012
3013         Reviewed by Gyuyoung Kim.
3014
3015         * Scripts/webkitperl/FeatureList.pm: Removed TILED_BACKING_STORE guard.
3016
3017 2014-08-28  Daniel Bates  <dabates@apple.com>
3018
3019         [Win] update-webkit should update auxiliary libs by default
3020
3021         Reviewed by Dan Bernstein.
3022
3023         The change set <http://trac.webkit.org/changeset/172795> inadvertently prevented update-webkit
3024         from updating the Windows auxiliary libs by default. We should make update-webkit update the
3025         Windows auxiliary libs by default. This will make its behavior match its usage text.
3026
3027         * Scripts/update-webkit:
3028
3029 2014-08-28  Brian J. Burg  <burg@cs.washington.edu>
3030
3031         build-webkit --inspector-frontend tries to copy files from old inspector path
3032         https://bugs.webkit.org/show_bug.cgi?id=136346
3033
3034         Reviewed by Timothy Hatcher.
3035
3036         Remove the old code path for copying inspector resources. It doesn't work.
3037         Complain if this option is passed to CMake-based builds.
3038
3039         * Scripts/build-webkit:
3040         * Scripts/webkitdirs.pm:
3041         (copyInspectorFrontendFiles): Deleted.
3042
3043 2014-08-28  Alexey Proskuryakov  <ap@apple.com>
3044
3045         Dashboard metrics page could show longest stretch of red
3046         https://bugs.webkit.org/show_bug.cgi?id=136334
3047
3048         Reviewed by Sam Weinig.
3049
3050         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
3051         (Analyzer.prototype._updateStretchOfRedCounters):
3052         (Analyzer.prototype._countPercentageOfGreen):
3053         When counting percentage of green, also keep track of how long the page was red.
3054
3055         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsView.js:
3056         (MetricsView.prototype._update.addDivider):
3057         (MetricsView.prototype._update.appendQueueResults):
3058         Show it in aggregate queues (can't think of a reason to have it in individual ones).
3059
3060         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Metrics.css:
3061         Changed to use an explicit divider element between green time and performance groups,
3062         as there are too many combinations to easily express in CSS.
3063
3064 2014-08-28  Carlos Garcia Campos  <cgarcia@igalia.com>
3065
3066         [GTK] Add webkit_uri_response_get_http_headers to WebKit2 GTK+ API
3067         https://bugs.webkit.org/show_bug.cgi?id=136248
3068
3069         Reviewed by Gustavo Noronha Silva.
3070
3071         Add new test case for webkit_uri_response_get_http_headers().
3072
3073         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
3074         (testURIResponseHTTPHeaders):
3075         (serverCallback):
3076         (beforeAll):
3077
3078 2014-08-27  Alexey Proskuryakov  <ap@apple.com>
3079
3080         EWS status link at build.webkit.org/dashboard is incorrect until EWS pop-up is opened
3081         https://bugs.webkit.org/show_bug.cgi?id=131668
3082
3083         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
3084         (EWSQueue.prototype.loadDetailedStatus): Fixed a typo in assertion.
3085
3086 2014-08-27  Zalan Bujtas  <zalan@apple.com>
3087
3088         Subpixel layout: Cleanup snapSizeToPixel/snapSizeToDevicePixel.
3089         https://bugs.webkit.org/show_bug.cgi?id=136264
3090
3091         Reviewed by Simon Fraser.
3092         
3093         1. Align snapSizeToPixel()/snapSizeToDevicePixel() function names with the rest of snapping
3094         functions. ->snappedIntSize()/snapSizeToDevicePixel().
3095         2. Operate on LayoutSize/LayoutPoint instead of LayoutUnit/LayoutUnit to reflect functionality.
3096
3097         Covered by existing tests.
3098
3099         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
3100         (TestWebKitAPI::TEST): Deleted.
3101
3102 2014-08-27  Alexey Proskuryakov  <ap@apple.com>
3103
3104         EWS status link at build.webkit.org/dashboard is incorrect until EWS pop-up is opened
3105         https://bugs.webkit.org/show_bug.cgi?id=131668
3106
3107         Reviewed by Daniel Bates.
3108
3109         We used to fetch the URL from EWS detailed status JSON, but there isn't much reason
3110         to not just hardcode.
3111
3112         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
3113         (EWS.prototype.queueStatusURL): Added.
3114
3115         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
3116         (EWSQueue.prototype.get statusPageURL): Use the above function.
3117         (EWSQueue.prototype.loadDetailedStatus): Changed assignment to an assertion.
3118
3119         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js:
3120         (EWSQueueView.prototype.update): While at it, made a popover show up even if there
3121         are no patches in the queue. The popover has other useful information, such as charts
3122         link and bot status.
3123
3124 2014-08-27  Alexey Proskuryakov  <ap@apple.com>
3125
3126         https://bugs.webkit.org/show_bug.cgi?id=136317
3127         Dashboard metrics page sometimes shows 0 for best time
3128
3129         Reviewed by Tim Horton.
3130
3131         This also affects regular dashboard display in a good way - iterations that failed
3132         due to infrastructure misbehavior will more reliably show up as yellow and not red.
3133
3134         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3135         (BuildbotIteration): Added a list of steps that we actually care about. It will need to be
3136         updated if we rename steps.
3137         (BuildbotIteration.prototype.get productive): Now that computation is more involved,
3138         do it once.
3139         (BuildbotIteration.prototype._parseData): Tweak computation of "productive" - builds
3140         that failed e.g. at downloading built archive step are not productive.
3141
3142 2014-08-27  Brent Fulgham  <bfulgham@apple.com>
3143
3144         [Win] Unreviewed gardening.
3145
3146         * win/AssembleBuildLogs/AssembleLogs.cmd: Add some missing build logs to the set
3147         of logs assembled into the final build output.
3148
3149 2014-08-27  Alexey Proskuryakov  <ap@apple.com>
3150
3151         build.webkit.org/dashboard: Add a metrics page with overall bot performance results
3152         https://bugs.webkit.org/show_bug.cgi?id=136196
3153
3154         Reviewed by Timothy Hatcher.
3155
3156         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External: Added.
3157         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/daterangepicker.css: Added.
3158         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/jquery-1.11.1.min.js: Added.
3159         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/jquery.daterangepicker.js: Added.
3160         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/moment.min.js: Added.
3161         A date range picker control with dependencies.
3162         There are a few modifications from upstream at <https://github.com/longbill/jquery-date-range-picker>:
3163         - Fixed a bug where selected dates were not at midnight the first time a range was chosen
3164         (it didn't happen again upon re-opening the picker).
3165         - Made made style tweaks to match Dashboard UI.
3166
3167         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
3168         Don't create objects that are not needed by the given app, and thus are not loaded at all.
3169
3170         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js: Added.
3171         Math to count all the things. Only supports open source tree and trunk at the moment,
3172         but written with internal tree and branches in mind.
3173
3174         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js: Added.
3175         Like dashboard Main.js, draws the UI and creates all necessary objects.
3176
3177         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsView.js: Added.
3178         A view for table cells.
3179
3180         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
3181         (Settings.prototype.toggleSettingsDisplay): Added an event for entering settings.
3182         Metrics page has individual platforms initially scrolled away form the view, so 
3183         it needs to scroll down to reveal what's being configured.
3184
3185         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
3186         Added Array.prototype.average and Array.prototype.median.
3187
3188         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3189         Made gear icon fixed instead of absolute, so that it's visible on metrics page when
3190         in settings mode.
3191
3192         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Metrics.css:
3193         Additional style rules.
3194
3195         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/metrics.html:
3196         The metrics page.
3197
3198 2014-08-27  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3199
3200         Remove networkinfo watch category in watchlist
3201         https://bugs.webkit.org/show_bug.cgi?id=136279
3202
3203         Reviewed by Alexey Proskuryakov.
3204
3205         Network info was removed. So, it is not needed anymore.
3206
3207         * Scripts/webkitpy/common/config/watchlist:
3208
3209 2014-08-26  Alexey Proskuryakov  <ap@apple.com>
3210
3211         build.webkit.org/dashboard: Poor performance when there are broken builds at initial load time
3212         https://bugs.webkit.org/show_bug.cgi?id=136281
3213
3214         Reviewed by Tim Horton.
3215
3216         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3217         Track and expose whether the itertion is being loaded. Made update() a no-op if
3218         the iteration is already being loaded.
3219
3220         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
3221         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus): Instead of
3222         loading everything at once, ask the queue to load a little more. We can always repeat
3223         if we still don't have enough data.
3224
3225         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3226         (BuildbotQueue.prototype.loadMoreHistoricalIterations): Added a function that loads
3227         10 more iterations intelligently.
3228
3229 2014-08-26  Alexey Proskuryakov  <ap@apple.com>
3230
3231         build.webkit.org/dashboard raises an exception when Trac RSS fails to load
3232         https://bugs.webkit.org/show_bug.cgi?id=136283
3233
3234         Reviewed by Tim Horton.
3235
3236         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3237         Don't.
3238
3239 2014-08-26  Alexey Proskuryakov  <ap@apple.com>
3240
3241         build.webkit.org/dashboard raises an exception after a hidden platform is removed
3242         https://bugs.webkit.org/show_bug.cgi?id=136282
3243
3244         Reviewed by Tim Horton.
3245
3246         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3247         (updateHiddenPlatforms): Check that the platform is still valid.
3248
3249 2014-08-26  Matt Lilek  <mrl@apple.com>
3250
3251         Add WebKit SPI to control the navigator.standalone property
3252         https://bugs.webkit.org/show_bug.cgi?id=136189
3253
3254         Reviewed by Andy Estes.
3255
3256         Add API test for WKPreferences
3257
3258         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3259         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
3260         (TEST):
3261
3262 2014-08-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3263
3264         Remove ENABLE_DRT environment variable to enable SHARED_CORE
3265         https://bugs.webkit.org/show_bug.cgi?id=136205
3266
3267         Reviewed by Andrei Bucur.
3268
3269         EFL port doesn't need to enable SHARED_CORE since r172894. Thus, we don't need to
3270         use ENABLE_DRT enviroment variable, which enables SHARED_CORE.
3271
3272         * Scripts/webkitdirs.pm:
3273         (generateBuildSystemFromCMakeProject):
3274
3275 2014-08-26  Brent Fulgham  <bfulgham@apple.com>
3276
3277         [Win] Version stamp should include package-level version
3278         https://bugs.webkit.org/show_bug.cgi?id=136266
3279         <rdar://problem/18134138>
3280
3281         Reviewed by David Kilzer.
3282
3283         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Add
3284         tests for the full 3+ digit version.
3285         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl:
3286         Confirm that the final output DLL uses the 3+ digit version.
3287
3288 2014-08-26  Brent Fulgham  <bfulgham@apple.com>
3289
3290         [Win] WebKit IDL incorrectly passes HWND as OLE_HANDLE
3291         https://bugs.webkit.org/show_bug.cgi?id=136258
3292         <rdar://problem/18134138>
3293
3294         Reviewed by Tim Horton.
3295
3296         Avoid 32/64-bit truncation by preventing 64-bit HWND (and other)
3297         values from passing through the 32-bit OLE_HANDLE data type.
3298
3299         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3300         (AccessibilityController::rootElement):
3301         * DumpRenderTree/win/DumpRenderTree.cpp:
3302         (resetWebViewToConsistentStateBeforeTesting):
3303         (runTest):
3304         (createWebViewAndOffscreenWindow):
3305         * DumpRenderTree/win/FrameLoadDelegate.h:
3306         (FrameLoadDelegate::didReceiveIcon):
3307         * DumpRenderTree/win/TestRunnerWin.cpp:
3308         (TestRunner::setWindowIsKey):
3309         * DumpRenderTree/win/UIDelegate.cpp:
3310         (UIDelegate::trackCustomPopupMenu):
3311         (UIDelegate::drawHeaderInRect):
3312         (UIDelegate::drawFooterInRect):
3313         (UIDelegate::webViewClose):
3314         (UIDelegate::webViewFocus):
3315         (UIDelegate::webViewSetCursor):
3316         (UIDelegate::drawBackground):
3317         * DumpRenderTree/win/UIDelegate.h:
3318         (UIDelegate::webViewFirstResponder):
3319         (UIDelegate::makeFirstResponder):
3320         (UIDelegate::contextMenuItemsForElement):
3321         (UIDelegate::addCustomMenuDrawingData):
3322         (UIDelegate::cleanUpCustomMenuDrawingData):
3323         (UIDelegate::webViewLostFocus):
3324         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
3325         (TestWebKitAPI::WebViewDestructionWithHostWindow::SetUp):
3326         * WinLauncher/PrintWebUIDelegate.cpp:
3327         (PrintWebUIDelegate::drawHeaderInRect):
3328         (PrintWebUIDelegate::drawFooterInRect):
3329         * WinLauncher/PrintWebUIDelegate.h:
3330         (PrintWebUIDelegate::webViewFirstResponder):
3331         (PrintWebUIDelegate::makeFirstResponder):
3332         (PrintWebUIDelegate::contextMenuItemsForElement):
3333         (PrintWebUIDelegate::trackCustomPopupMenu):
3334         (PrintWebUIDelegate::addCustomMenuDrawingData):
3335         (PrintWebUIDelegate::cleanUpCustomMenuDrawingData):
3336         * WinLauncher/WinLauncher.cpp:
3337         (WinLauncher::prepareViews):
3338         * WinLauncher/WinLauncherWebHost.h:
3339         (WinLauncherWebHost::didReceiveIcon):
3340
3341 2014-08-26  Daniel Bates  <dabates@apple.com>
3342
3343         Only define WEBCORE_EXPORT when building DumpRenderTree for Windows and iOS
3344
3345         Rubber-stamped by Tim Horton.
3346
3347         The Windows and iOS ports are the only ports that make use of WebCore headers
3348         in DumpRenderTree.
3349
3350         * DumpRenderTree/config.h:
3351
3352 2014-08-26  Dan Bernstein  <mitz@apple.com>
3353
3354         runSvnUpdateAndResolveChangeLogs() doesn’t work when invoked from a script outside Tools/Scripts
3355         https://bugs.webkit.org/show_bug.cgi?id=136254
3356
3357         Reviewed by Tim Horton.
3358
3359         * Scripts/webkitdirs.pm:
3360         (runSvnUpdateAndResolveChangeLogs): Locate resolve-ChangeLogs relative to the source tree,
3361         not the invoking script.
3362
3363 2014-08-26  Krzysztof Czech  <k.czech@samsung.com>
3364
3365         [EFL] Utilize espeak as a synthesizer back-end for WebSpeech
3366         https://bugs.webkit.org/show_bug.cgi?id=136127
3367
3368         Reviewed by Gyuyoung Kim.
3369
3370         Add espeak dependency.
3371
3372         * efl/install-dependencies:
3373
3374 2014-08-25  Alexey Proskuryakov  <ap@apple.com>
3375
3376         Remove a little more accidentally landed code from r172891.
3377
3378         iteration.branch also wasn't meant to be landed.
3379
3380         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3381         (BuildbotIteration.prototype._parseData):
3382
3383 2014-08-25  Alexey Proskuryakov  <ap@apple.com>
3384
3385         REGRESSION (r172891): Internal dashboard is broken.
3386
3387         Removing some accidentally landed code - I needed "changes" for another patch, but
3388         not here, and then I decided to not use it anyway.
3389
3390         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3391         (BuildbotIteration.prototype._parseData):
3392
3393 2014-08-25  Daniel Bates  <dabates@apple.com>
3394
3395         Fix the iOS DumpRenderTree build after <http://trac.webkit.org/changeset/172814/>
3396         (https://bugs.webkit.org/show_bug.cgi?id=136108)
3397
3398         Use a similar approach as in TestWebKitAPI/config.h and define a stub for the macro define WEBCORE_EXPORT
3399         so that we can compile DumpRenderTree for iOS.
3400
3401         * DumpRenderTree/config.h:
3402
3403 2014-08-25  Alexey Proskuryakov  <ap@apple.com>
3404
3405         Make build.webkit.org/dashboard work with changeset_show_files=location
3406         https://bugs.webkit.org/show_bug.cgi?id=136237
3407
3408         Reviewed by Tim Horton.
3409
3410         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3411         (Trac.prototype._convertCommitInfoElementToObject): Remove location information
3412         from description before getting title, and also actually parse the location into
3413         result object when available.
3414
3415         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
3416         (String.prototype.startsWith): Added.
3417
3418 2014-08-25  Tanay C  <tanay.c@samsung.com>
3419
3420         [EFL][WK2] Minibrowser : Enhance application to be able to support history list navigation
3421         https://bugs.webkit.org/show_bug.cgi?id=135795
3422
3423         Reviewed by Gyuyoung Kim.
3424
3425         * MiniBrowser/efl/main.c: Adding functionality for long press history list navigation
3426         (history_list_hide): Hiding and dereferencing the history list and items
3427         (on_key_down):
3428         (on_mouse_down):
3429         (on_back_button_clicked): Early return for longpress 
3430         (on_forward_button_clicked): Early return for longpress 
3431         (list_item_label_get): Populate item labels
3432         (on_list_item_select): Navigates on selection from history list
3433         (navigation_button_longpress_process): Populates the history list and displays it
3434         (on_forward_button_longpress):
3435         (on_back_button_longpress):
3436         (window_create): Add the widget for history list
3437
3438 2014-08-25  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3439
3440         [GTK] JHBuild module gst-plugins-base fails to build on x86 with GCC 4.9
3441         https://bugs.webkit.org/show_bug.cgi?id=136152
3442
3443         Reviewed by Philippe Normand.
3444
3445         * gtk/jhbuild.modules: Apply gst-plugins-base-fix-build-gcc-4.9-x86.patch.
3446         * gtk/patches/gst-plugins-base-fix-build-gcc-4.9-x86.patch: Added.
3447         Cherry pick upstream patches daa194 and 4e3d101.
3448
3449 2014-08-24  Zan Dobersek  <zdobersek@igalia.com>
3450
3451         GenericHashTraits::peek() is producing copies of passed-in temporary values
3452         https://bugs.webkit.org/show_bug.cgi?id=131461
3453
3454         Reviewed by Darin Adler.
3455
3456         Add a test case that checks the number of copies and moves of the mapped objects
3457         when calling HashMap::get(). Exactly one copy of the mapped value should be
3458         performed when there exists a value that is mapped to the specified key, and
3459         exactly one move and no copies of the empty value should be performed when there
3460         isn't any mapped value for the specified key.
3461
3462         * TestWebKitAPI/Tests/WTF/CopyMoveCounter.h: Added.
3463         (CopyMoveCounter::TestingScope::TestingScope):
3464         (CopyMoveCounter::CopyMoveCounter):
3465         (CopyMoveCounter::operator=):
3466         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3467         (TestWebKitAPI::TEST):
3468
3469 2014-08-24  Ryuan Choi  <ryuan.choi@samsung.com>
3470
3471         [EFL] Introduce DEVELOPER_MODE
3472         https://bugs.webkit.org/show_bug.cgi?id=135884
3473
3474         Reviewed by Gyuyoung Kim.
3475
3476         * Scripts/webkitdirs.pm: Turn on DEVELOPER_MODE for the EFL port.
3477         (generateBuildSystemFromCMakeProject):
3478
3479 2014-08-24  Alexey Proskuryakov  <ap@apple.com>
3480
3481         build.webkit.org/dashboard unnecessarily loads results of hidden queues
3482         https://bugs.webkit.org/show_bug.cgi?id=136195
3483
3484         Reviewed by Tim Horton.
3485
3486         This patch also makes it possible to avoid any automatic loading, as needed for metrics view.
3487
3488         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3489         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
3490         Don't start an update just because a queue object was created. Periodic updates
3491         are triggered by views, so it only makes sense to do the same for the initial update.
3492
3493         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3494         Now that Trac object doesn't auto-load, start loading here.
3495
3496         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
3497         (QueueView): Calling _updateHiddenState right away was wrong, because it accesses
3498         a data member added by subclasses later. With this.platform being undefined, it
3499         always looked like this queue was not hidden.
3500         (QueueView.prototype._updateHiddenState): Start an immediate update, too.
3501
3502         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3503         (Trac): Don't load anything here, the client may choose to load a custom date range.
3504         (Trac.prototype.startPeriodicUpdates): Added a function to start automatic loading.
3505
3506 2014-08-23  Alexey Proskuryakov  <ap@apple.com>
3507
3508         build.webkit.org/dashboard: Further improve Trac loading
3509         https://bugs.webkit.org/show_bug.cgi?id=136174
3510
3511         Reviewed by Timothy Hatcher.
3512
3513         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3514         (Trac.prototype._xmlTimelineURL): Passing -1 as "max" resulted in an off by one
3515         error, the oldest commit within the range wasn't returned. The correct argument for
3516         "no limit" is 0.
3517         (Trac.prototype.load): Added a function to load a specific time range.
3518         (Trac.prototype._loaded): Updated to support loading revisions that are arbitrarily
3519         positioned with regards to ones that were already known.
3520
3521 2014-08-23  Alexey Proskuryakov  <ap@apple.com>
3522
3523         build.webkit.org/dashboard: Make it possible to pull historic data from Buildbot
3524         https://bugs.webkit.org/show_bug.cgi?id=136182
3525
3526         Reviewed by Timothy Hatcher.
3527
3528         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3529         Make it possible to create a complete BuildbotIteration object with JSON, not only by
3530         loading data from the network.
3531
3532         An iteration has three states:
3533         1. Just created, it only knows the revision, and whether it's already finished.
3534         BuildbotIteration constructor used to create these.
3535         2. A complete JSON report loaded from buildbot. The new constructor form creates these.
3536         3. Data about tests is fetched.
3537
3538         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3539         Make it possible to pull all data from a buildbot queue. This needs to be better
3540         optimized eventually, as it's somewhat slow.
3541
3542 2014-08-22  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
3543
3544         Remove LevelDB.
3545         https://bugs.webkit.org/show_bug.cgi?id=136170
3546
3547         Reviewed by Gyuyoung Kim.
3548
3549         * Scripts/webkitpy/common/config/watchlist:
3550         * Scripts/webkitpy/style/checker.py:
3551
3552 2014-08-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3553
3554         [GTK] install-dependencies don't installs Xvfb that is needed for the tests.
3555         https://bugs.webkit.org/show_bug.cgi?id=136153
3556
3557         Reviewed by Martin Robinson.
3558
3559         * gtk/install-dependencies: Add Xvfb package to the list of dependencies necessary for running tests.
3560
3561 2014-08-21  Alex Christensen  <achristensen@webkit.org>
3562
3563         [Win] Another unreviewed build fix.
3564
3565         * DumpRenderTree/config.h:
3566         Defined WEBCORE_EXPORT on Windows.
3567
3568 2014-08-21  Rohit Kumar  <kumar.rohit@samsung.com>
3569
3570         [EFL][WK2] Minibrowser : Add stop button to abort page load
3571         https://bugs.webkit.org/show_bug.cgi?id=136122
3572
3573         Reviewed by Gyuyoung Kim.
3574
3575         * MiniBrowser/efl/main.c:
3576         (on_key_down):
3577         (on_stop_button_clicked): Callback for stop button press.
3578         (window_create):
3579
3580 2014-08-21  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3581
3582         [GTK] Load the llvmpipe (Mesa) libraries when running the tests with Xvfb.
3583         https://bugs.webkit.org/show_bug.cgi?id=134070
3584
3585         Reviewed by Martin Robinson.
3586
3587         * Scripts/webkitpy/port/base.py:
3588         (Port.__init__): Set default _jhbuild_wrapper variable.
3589         (Port._should_use_jhbuild): Implement generic check.
3590         * Scripts/webkitpy/port/efl.py: Rename to jhbuild_wrapper variable
3591         to make it consistent with the other ports.
3592         * Scripts/webkitpy/port/gtk.py:
3593         (GtkPort.__init__): Use the new _should_use_jhbuild() method.
3594         (GtkPort.setup_environ_for_server): Get the path for llvmpipe_libgl_path by
3595         querying the jhbuild with printenv. Also check that the path contains
3596         the libraries we expect. Preload this path only for XvfbDriver.
3597         * Scripts/webkitpy/port/xvfbdriver.py:
3598         (XvfbDriver.check_driver): Check for the jhbuild wrapper and use it.
3599         (XvfbDriver._start): The environment for llvmpipe_libgl_path is now
3600         configured at setup_environ_for_server()
3601         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
3602         (XvfbDriverTest.make_driver): Get the port default environment.
3603         (XvfbDriverTest.test_start_no_pixel_tests): The expected log now
3604         should include the environment that is passed when running Xvfb.
3605         (XvfbDriverTest.test_start_pixel_tests): Ditto.
3606         (XvfbDriverTest.test_start_arbitrary_worker_number): Ditto.
3607         (XvfbDriverTest.test_start_next_worker): Ditto.
3608         * gtk/jhbuild.modules: Rename checkoutdir to generic "Mesa" to
3609         prevent future problems when the version is raised. Add also a
3610         comment with a warning.
3611         * gtk/jhbuildrc: The path LLVMPIPE_LIBGL_PATH should be the one
3612         that has the llvm optimized Gallium libGL libraries.
3613
3614 2014-08-21  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
3615
3616         Fix countFailures of RunLLINTCLoopTests and Run32bitJSCTests.
3617         https://bugs.webkit.org/show_bug.cgi?id=136125
3618
3619         Reviewed by Csaba Osztrogonác.
3620
3621         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3622         (RunLLINTCLoopTests.countFailures):
3623         (Run32bitJSCTests.countFailures):
3624         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3625         (RunLLINTCLoopTestsTest):
3626         (RunLLINTCLoopTestsTest.assertResults):
3627         (RunLLINTCLoopTestsTest.test_failures):
3628         (RunLLINTCLoopTestsTest.test_failure):
3629         (RunLLINTCLoopTestsTest.test_no_failure):
3630         (Run32bitJSCTestsTest):
3631         (Run32bitJSCTestsTest.assertResults):
3632         (Run32bitJSCTestsTest.test_failures):
3633         (Run32bitJSCTestsTest.test_failure):
3634         (Run32bitJSCTestsTest.test_no_failure):
3635
3636 2014-08-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3637
3638         Unreviewed, EFL build fix since r172814.
3639
3640         * WebKitTestRunner/config.h: Define WEBCORE_EXPORT.
3641
3642 2014-08-20  Alex Christensen  <achristensen@webkit.org>
3643
3644    &nb