2b61e7a026e40097a53296c2f31703dd45a77dce
[WebKit-https.git] / Tools / ChangeLog
1 2011-04-06  Chris Rogers  <crogers@google.com>
2
3         Reviewed by Tony Chang.
4
5         Add web audio support to DumpRenderTree (mac port)
6         https://bugs.webkit.org/show_bug.cgi?id=57969
7
8         * DumpRenderTree/LayoutTestController.cpp:
9         (LayoutTestController::LayoutTestController):
10         (setEncodedAudioDataCallback):
11         (LayoutTestController::staticFunctions):
12         * DumpRenderTree/LayoutTestController.h:
13         (LayoutTestController::dumpAsAudio):
14         (LayoutTestController::setDumpAsAudio):
15         (LayoutTestController::encodedAudioData):
16         (LayoutTestController::setEncodedAudioData):
17         * DumpRenderTree/mac/DumpRenderTree.mm:
18         (dumpAudio):
19         (dump):
20
21 2011-04-06  Benjamin Poulain  <benjamin.poulain@nokia.com>
22
23         Reviewed by Kenneth Rohde Christiansen.
24
25         [Qt] LayoutTestController needs to implement numberOfPendingGeolocationPermissionRequests
26         https://bugs.webkit.org/show_bug.cgi?id=56086
27
28         Add the missing method.
29
30         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
31         (WebCore::DumpRenderTree::getAllPages): Add a method to return all the pages allocated for the current test.
32         * DumpRenderTree/qt/DumpRenderTreeQt.h:
33         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
34         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
35
36 2011-04-06  Dai Mikurube  <dmikurube@chromium.org>
37
38         Reviewed by David Levin.
39
40         Add QUOTA build flag for unified quota API
41         https://bugs.webkit.org/show_bug.cgi?id=57918
42
43         * Scripts/build-webkit: Added QUOTA build flag
44
45 2011-04-06  Dirk Pranke  <dpranke@chromium.org>
46
47         Reviewed by Tony Chang.
48
49         Adjust the apple webkit port's default timeout to match
50         old-run-webkit-tests at 35 seconds.
51
52         https://bugs.webkit.org/show_bug.cgi?id=37738
53
54         * Scripts/webkitpy/layout_tests/port/mac.py:
55
56 2011-04-06  Scott Cameron  <sccameron@rim.com>
57
58         Reviewed by Eric Seidel.
59
60         Remove global variable $httpdPath and replace with the return value of
61         getHTTPDPath().  Also remove unnecessary calls to getHTTPDPath().
62         https://bugs.webkit.org/show_bug.cgi?id=53499
63
64         * Scripts/run-iexploder-tests:
65         * Scripts/webkitperl/httpd.pm:
66
67 2011-04-06  Kevin Ollivier  <kevino@theolliviers.com>
68
69         Reviewed by Darin Adler.
70
71         Make sure JS_EXPORT_PRIVATE is an empty define when we aren't using the export macros.
72         
73         https://bugs.webkit.org/show_bug.cgi?id=27551
74         
75         * DumpRenderTree/config.h:
76         * WebKitAPITest/config.h:
77         * WebKitTestRunner/config.h:
78
79 2011-04-06  Tony Chang  <tony@chromium.org>
80
81         Reviewed by Darin Adler.
82
83         teach run-webkit-tests to read checksums from png files
84         https://bugs.webkit.org/show_bug.cgi?id=57993
85
86         * Scripts/old-run-webkit-tests: Read the first 2k of a .png if there's
87           no .checksum and look for the checksum in there.
88
89 2011-04-06  David Dorwin  <ddorwin@chromium.org>
90
91         Reviewed by David Levin.
92
93         Enable fullscreen layout tests for Chromium
94         https://bugs.webkit.org/show_bug.cgi?id=55726
95
96         Make DumpRenderTree always run with fullscreen enabled (equivalent of --enable-fullscreen).
97
98         * DumpRenderTree/chromium/WebPreferences.cpp:
99         (WebPreferences::applyTo):
100
101 2011-04-06  Adam Roben  <aroben@apple.com>
102
103         Add a "view leaks" link to builds on SnowLeopard Intel Leaks
104
105         Fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks bot results page
106
107         Reviewed by David Kilzer.
108
109         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
110         (ExtractTestResults.resultDirectoryURL): Added. Moved code to calculate the URL for the
111         build's results directory here...
112         (ExtractTestResults.finished): ...from here.
113         (ExtractTestResultsAndLeaks): New class that's used by the leaks builder
114         (ExtractTestResultsAndLeaks.finished): Calls up to the base class, but also adds a "view
115         leaks" link to point to Leaks Viewer for this build.
116         (TestFactory): Added ExtractTestResultsClass abstraction. This isn't overridden anywhere,
117         but it seemed good to add for consistency with BuildAndTestFactory.
118         (BuildAndTestFactory): Added ExtractTestResultsClass abstraction.
119         (BuildAndTestLeaksFactory): Use ExtractTestResultsAndLeaks as our ExtractTestResultsClass so
120         that we'll get a "view leaks" link.
121
122 2011-04-06  Zan Dobersek  <zandobersek@gmail.com>
123
124         Reviewed by Eric Seidel.
125
126         [Gtk] plugins/set-status.html fails
127         https://bugs.webkit.org/show_bug.cgi?id=57844
128
129         Allow an empty status text to be dumped.
130
131         * DumpRenderTree/gtk/DumpRenderTree.cpp:
132         (webViewStatusBarTextChanged):
133
134 2011-04-06  Chang Shu  <cshu@webkit.org>
135
136         Reviewed by Darin Adler.
137
138         WebKitTestRunner needs layoutTestController.pageNumberForElementById
139         https://bugs.webkit.org/show_bug.cgi?id=42329
140
141         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
142         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
143         (WTR::LayoutTestController::pageNumberForElementById):
144         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
145
146 2011-04-06  Sergio Villar Senin  <svillar@igalia.com>
147
148         Reviewed by Martin Robinson.
149
150         [GTK] DumpRenderTree: do not try to free NULL SoupURIs
151         https://bugs.webkit.org/show_bug.cgi?id=57932
152
153         Some Layout tests have invalid URIs that do not generate valid
154         SoupURI instances. Do not try to free those NULL SoupURIs.
155
156         * DumpRenderTree/gtk/DumpRenderTree.cpp:
157         (willSendRequestCallback):
158
159 2011-04-06  Csaba Osztrogonác  <ossy@webkit.org>
160
161         Reviewed by Andreas Kling.
162
163         ORWT shouldn't generate diff files for tests without expected files
164         https://bugs.webkit.org/show_bug.cgi?id=57846
165
166         * Scripts/old-run-webkit-tests:
167
168 2011-04-05  Kevin Ollivier  <kevino@theolliviers.com>
169
170         [wx] Mac build fix. Handle cases where 10.4 SDK is not installed, and also add x86_64 arch
171         to deps.
172
173         * wx/install-unix-extras:
174
175 2011-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>
176
177         Unreviewed, rolling out r82978, r82999, and r83001.
178         http://trac.webkit.org/changeset/82978
179         http://trac.webkit.org/changeset/82999
180         http://trac.webkit.org/changeset/83001
181         https://bugs.webkit.org/show_bug.cgi?id=57913
182
183         Does not work in Python 2.5 (Requested by abarth on #webkit).
184
185         * Scripts/webkitpy/common/system/executive.py:
186         * Scripts/webkitpy/common/system/executive_unittest.py:
187
188 2011-04-05  Chang Shu  <cshu@webkit.org>
189
190         Reviewed by Darin Adler.
191
192         WebKitTestRunner needs layoutTestController.numberOfPages
193         https://bugs.webkit.org/show_bug.cgi?id=42694
194
195         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
196         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
197         (WTR::LayoutTestController::numberOfPages):
198         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
199
200 2011-04-05  Tony Chang  <tony@chromium.org>
201
202         Reviewed by Mihai Parparita.
203
204         [chromium] stop putting results downloaded from WebKit Linux in chromium-linux-x86_64
205         https://bugs.webkit.org/show_bug.cgi?id=57889
206
207         * Scripts/webkitpy/layout_tests/port/chromium.py:
208         * Scripts/webkitpy/layout_tests/port/test.py:
209         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
210
211 2011-04-05  Adam Barth  <abarth@webkit.org>
212
213         Silly with statement, from the future!
214
215         * Scripts/webkitpy/common/system/executive.py:
216
217 2011-04-05  Adam Barth  <abarth@webkit.org>
218
219         Reviewed by Tony Chang.
220
221         Don't use Exception.message because it's deprecated
222         https://bugs.webkit.org/show_bug.cgi?id=57892
223
224         Suppress the warning for now.  When we move to Python 3, we might need
225         to something more dramatic.
226
227         * Scripts/webkitpy/common/system/executive.py:
228
229 2011-04-05  Mihai Parparita  <mihaip@chromium.org>
230
231         Reviewed by Ojan Vafai.
232
233         Add builders.js to dashboard file list
234         https://bugs.webkit.org/show_bug.cgi?id=57899
235
236         Add file added by http://crrev.com/80538 to dashboard file list.
237
238         * TestResultServer/handlers/dashboardhandler.py:
239
240 2011-04-05  MORITA Hajime  <morrita@google.com>
241
242         Reviewed by Adam Barth.
243
244         webkit-patch should print git's stderr when git svn dcommit fail
245         http://webkit.org/b/57861
246
247         * Scripts/webkitpy/common/checkout/scm.py:
248
249 2011-04-05  Mihai Parparita  <mihaip@chromium.org>
250
251         Reviewed by Tony Chang.
252
253         Add --baseline-search-path to NRWT
254         https://bugs.webkit.org/show_bug.cgi?id=56233
255         
256         Add NRWT option to specify additional directories to look for baselines
257         (will be used by hardware GPU bots which will have local per-bot
258         expectations for some tests)
259
260         * Scripts/webkitpy/common/system/filesystem_mock.py:
261         * Scripts/webkitpy/layout_tests/port/base.py:
262         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
263         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
264
265 2011-04-05  Adam Roben  <aroben@apple.com>
266
267         Strip off /results.html from results URLs before trying to load leaks files from them
268
269         r82734 changed build.webkit.org's "view results" URLs to point straight to the results.html
270         files, rather than pointing to the directory that contains them. This is more convenient for
271         people browsing build.webkit.org, but confused Leaks Viewer.
272
273         Fixes <http://webkit.org/b/57869> REGRESSION (r82734): Links in Leaks Viewer's Recent Builds
274         list don't work
275
276         Reviewed by Joseph Pecoraro.
277
278         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
279         (RecentBuildsLoader.prototype.start): Strip off "/results.html" from the results URL.
280
281 2011-04-05  Carol Szabo  <carol@webkit.org>
282
283         Unreviewed.
284
285         Updated my info in committers.py
286
287         Scripts\webkitpy\common\config\committers.py 
288
289 2011-04-05  Csaba Osztrogonác  <ossy@webkit.org>
290
291         Reviewed by Laszlo Gombos.
292
293         [Qt] Make WebKitLibraries optional for building QtWebKit
294         https://bugs.webkit.org/show_bug.cgi?id=57542
295
296         * Scripts/build-webkit:
297
298 2011-04-05  Chang Shu  <cshu@webkit.org>
299
300         Reviewed by Laszlo Gombos.
301
302         [Qt] MiniBrowser defaultUrl does not work
303         https://bugs.webkit.org/show_bug.cgi?id=57021
304
305         Match the behavior and coding of MiniBrowser to QtTestBrowser.
306         * MiniBrowser/qt/main.cpp:
307         (main):
308
309 2011-04-05  Jade Han  <jade.han@nokia.com>
310
311         Reviewed by Laszlo Gombos.
312
313         [Qt] [Symbian] Disable WebKitTestRunner for Symbian
314         https://bugs.webkit.org/show_bug.cgi?id=54977
315
316         This change is a preparation to enable building webkit2 for Symbian.
317         Bug 57834 is filed to fix and enable WebKitTestRunner for Symbian.
318
319         * Tools.pro:
320
321 2011-04-05  Zoltan Horvath  <zoltan@webkit.org>
322
323         Reviewed by Andreas Kling.
324
325         [Qt] Fix timeoutTimer of MiniBrowser's UrlLoader
326         https://bugs.webkit.org/show_bug.cgi?id=57832
327
328         Only QWKPage has loadFinished signal so connect to it instead of BrowserWindow.
329
330         * MiniBrowser/qt/UrlLoader.cpp:
331         (UrlLoader::UrlLoader):
332
333 2011-04-05  Zoltan Horvath  <zoltan@webkit.org>
334
335         [Qt] Linux Release minimal build fix after r82919.
336
337         * MiniBrowser/qt/BrowserWindow.cpp:
338         (BrowserWindow::loadURLListFromFile):
339         * QtTestBrowser/launcherwindow.cpp:
340         (LauncherWindow::loadURLListFromFile):
341
342 2011-04-05  Zoltan Horvath  <zoltan@webkit.org>
343
344         Reviewed by Andreas Kling.
345
346         [Qt] Make URL loader accessible from testbrowser's menus
347         https://bugs.webkit.org/show_bug.cgi?id=57823
348
349         Add "Load URLs from file" to QtTestBrowser's and to MiniBrowser's menu.
350
351         * MiniBrowser/qt/BrowserWindow.cpp:
352         (BrowserWindow::BrowserWindow):
353         (BrowserWindow::loadURLListFromFile):
354         (BrowserWindow::~BrowserWindow):
355         * MiniBrowser/qt/BrowserWindow.h:
356         * QtTestBrowser/launcherwindow.cpp:
357         (LauncherWindow::LauncherWindow):
358         (LauncherWindow::~LauncherWindow):
359         (LauncherWindow::createChrome):
360         (LauncherWindow::loadURLListFromFile):
361         * QtTestBrowser/launcherwindow.h:
362
363 2011-04-04  Sam Weinig  <sam@webkit.org>
364
365         Reviewed by Brian Weinstein.
366
367         Remove duplicate API from WKContext
368         <rdar://problem/8727879>
369         https://bugs.webkit.org/show_bug.cgi?id=57815
370
371         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
372         * TestWebKitAPI/Tests/WebKit2/SendingMessagesToTheWebProcessBeforeItIsValid.cpp: Removed.
373         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
374         Remove SendingMessagesToTheWebProcessBeforeItIsValid since the API it was testing is now removed.
375
376 2011-04-04  Tony Chang  <tony@chromium.org>
377
378         Reviewed by Ojan Vafai.
379
380         [chromium] don't write .checksum files if a fallback platform has an embedded checksum
381         https://bugs.webkit.org/show_bug.cgi?id=57783
382
383         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
384         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
385
386 2011-04-04  Kevin Ollivier  <kevino@theolliviers.com>
387
388         [wx] Unreviewed build fix, run uninstall when cleaning to remove built files
389         from WebKitBuild.
390
391         * Scripts/webkitdirs.pm:
392
393 2011-04-04  Martin Robinson  <mrobinson@igalia.com>
394
395         Reviewed by Gustavo Noronha Silva.
396
397         [GTK] WebGL support
398         https://bugs.webkit.org/show_bug.cgi?id=31517
399
400         Add support to the DRT for turning on WebGL when a layout tests requests it.
401
402         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
403         (LayoutTestController::overridePreference): Allow turning on WebGL from tests.
404
405 2011-04-04  Chang Shu  <cshu@webkit.org>
406
407         Reviewed by Darin Adler.
408
409         WebKitTestRunner needs layoutTestController.setAllowFileAccessFromFileURLs
410         https://bugs.webkit.org/show_bug.cgi?id=57572
411
412         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
413         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
414         (WTR::LayoutTestController::setAllowFileAccessFromFileURLs):
415         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
416
417 2011-04-04  Keith Kyzivat  <keith.kyzivat@nokia.com>
418
419         Reviewed by Csaba Osztrogonác.
420
421         [Qt] DumpRenderTree breaks compilation in some uClibc environments
422         https://bugs.webkit.org/show_bug.cgi?id=57602
423
424         * DumpRenderTree/qt/main.cpp:
425         (get_backtrace):
426
427 2011-04-04  Kevin Ollivier  <kevino@theolliviers.com>
428
429         [wx] Unreviewed build fix, add new LayoutTestController method stub to wx.
430
431         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
432         (LayoutTestController::shadowRoot):
433
434 2011-04-04  Pavel Podivilov  <podivilov@chromium.org>
435
436         Unreviewed, fix exception in rebaseline tool.
437
438         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
439
440 2011-04-02  Beth Dakin  <bdakin@apple.com>
441
442         Rubber-stamped by Geoff Garen.
443
444         For Dan!
445         * DumpRenderTree/mac/DumpRenderTree.mm:
446         (resetWebViewToConsistentStateBeforeTesting):
447
448 2011-04-02  Beth Dakin  <bdakin@apple.com>
449
450         Rubber-stamped by Geoff Garen.
451
452         Need to reset the scale, much like zoom.
453         * DumpRenderTree/mac/DumpRenderTree.mm:
454         (resetWebViewToConsistentStateBeforeTesting):
455
456 2011-04-02  Sam Weinig  <sam@webkit.org>
457
458         Reviewed by Beth Dakin.
459
460         https://bugs.webkit.org/show_bug.cgi?id=57605
461         Frame::pageScaleFactor() should not affect getBoundingClientRect() or 
462         getClientRects()
463         -and corresponding-
464         <rdar://problem/9194541>
465
466         Add DRT support for the scaleWebView SPI.
467         * DumpRenderTree/mac/EventSendingController.mm:
468         (+[EventSendingController isSelectorExcludedFromWebScript:]):
469         (+[EventSendingController webScriptNameForSelector:]):
470         (-[EventSendingController scalePageBy:atX:andY:]):
471         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
472         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
473         (WTR::EventSendingController::scalePageBy):
474         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
475         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
476         (WTR::InjectedBundlePage::reset):
477
478 2011-04-02  Dominic Cooney  <dominicc@google.com>
479
480         Reviewed by Martin Robinson.
481
482         Add layoutTestController.shadowRoot to GTK DumpRenderTree.
483         https://bugs.webkit.org/show_bug.cgi?id=57551
484
485         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
486         (LayoutTestController::shadowRoot):
487
488 2011-04-02  Patrick Gansterer  <paroga@webkit.org>
489
490         Reviewed by Eric Seidel.
491
492         Remove AbstractStep._run_script and move script names to ports.py
493         https://bugs.webkit.org/show_bug.cgi?id=57704
494
495         Replace deprecated _run_script with _tool.executive.run_and_throw_if_fail.
496
497         * Scripts/webkitpy/common/config/ports.py:
498         * Scripts/webkitpy/tool/commands/download_unittest.py:
499         * Scripts/webkitpy/tool/commands/roll_unittest.py:
500         * Scripts/webkitpy/tool/commands/upload_unittest.py:
501         * Scripts/webkitpy/tool/steps/abstractstep.py:
502         * Scripts/webkitpy/tool/steps/checkstyle.py:
503         * Scripts/webkitpy/tool/steps/preparechangelog.py:
504         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
505         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
506
507 2011-04-02  Patrick Gansterer  <paroga@webkit.org>
508
509         Reviewed by Eric Seidel.
510
511         Emulate shebang on Win32
512         https://bugs.webkit.org/show_bug.cgi?id=55927
513
514         Scripts on Windows work only if they are called with the explicit interpreter.
515         Read the first line of scripts to detect the correct executable.
516
517         * Scripts/webkitpy/common/config/ports.py:
518         * Scripts/webkitpy/common/system/executive.py: Added interpreter_for_script().
519         * Scripts/webkitpy/common/system/executive_unittest.py:
520
521 2011-04-01  Adam Barth  <abarth@webkit.org>
522
523         Reviewed by Eric Seidel.
524
525         apos entities shouldn't show up in ChangeLogs when using webkit-patch
526         https://bugs.webkit.org/show_bug.cgi?id=57692
527
528         Previously, we were using BeautifulSoup to process XML from
529         bugs.webkit.org, but that's incorrect.  We should be using
530         BeautifulStoneSoup to process the XML.  We were getting the &apos;
531         entity wrong because &apos; is an XML entity but not an HTML entity.
532
533         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
534         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
535
536 2011-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
537
538         Unreviewed, rolling out r82721.
539         http://trac.webkit.org/changeset/82721
540         https://bugs.webkit.org/show_bug.cgi?id=57687
541
542         This patch introduced assertion failures on the GTK+ bots.
543         (Requested by mrobinson on #webkit).
544
545         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
546         (LayoutTestController::shadowRoot):
547
548 2011-04-01  Csaba Osztrogonác  <ossy@webkit.org>
549
550         Unreviewed buildfix.
551
552         [Qt][WK2] Build Webkit2 using "-2" option on Qt
553         https://bugs.webkit.org/show_bug.cgi?id=55074
554
555         * Scripts/build-webkit: Ensure that "-2" isn't passed to qmake.
556         (The isWK2() function removes it from @ARGV, but not from @options.)
557
558 2011-04-01  Keith Kyzivat  <keith.kyzivat@nokia.com>
559
560         Reviewed by Csaba Osztrogonác.
561
562         [Qt] [WK2] MiniBrowser.qrc not found - regression from rev 82671
563         https://bugs.webkit.org/show_bug.cgi?id=57666
564
565         * MiniBrowser/qt/MiniBrowser.qrc: Renamed from Tools/MiniBrowser/MiniBrowser.qrc.
566
567 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
568
569         Reviewed by Adam Barth.
570
571         new-run-webkit-tests: fix feature detection, skipped platform lists on mac
572
573         We apparently never implemented the code to skip tests based on
574         what was compiled into DRT. Also, change the logic used to skip
575         platform directories to match what old-run-webkit-tests does: 
576         skip every test not in a directory in the baseline search path.
577
578         https://bugs.webkit.org/show_bug.cgi?id=57662
579
580         * Scripts/webkitpy/layout_tests/port/mac.py:
581         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
582         * Scripts/webkitpy/layout_tests/port/webkit.py:
583
584 2011-03-29  Mark Rowe  <mrowe@apple.com>
585
586         Reviewed by Jon Honeycutt.
587
588         <http://webkit.org/b/56730> new-run-webkit-tests fails on Lion seed
589
590         Teach new-run-webkit-tests about the concept of an unreleased version of Mac OS X.
591
592         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
593         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
594         * Scripts/webkitpy/layout_tests/port/mac.py:
595         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
596
597 2011-04-01  Chang Shu  <cshu@webkit.org>
598
599         Reviewed by Csaba Osztrogonác.
600
601         [Qt][WK2] Build Webkit2 using "-2" option on Qt
602         https://bugs.webkit.org/show_bug.cgi?id=55074
603
604         * Scripts/build-webkit:
605
606 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
607
608         Reviewed by Tony Chang.
609
610         new-run-webkit-tests: remove spurious port version override in webkit.py
611         base.py provides a default implementation so this is just
612         breaking things.
613
614         https://bugs.webkit.org/show_bug.cgi?id=57667
615
616         * Scripts/webkitpy/layout_tests/port/webkit.py:
617         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
618
619 2011-04-01  Csaba Osztrogonác  <ossy@webkit.org>
620
621         Reviewed by Adam Roben.
622
623         Make view results on waterfall direct link to results.html
624         https://bugs.webkit.org/show_bug.cgi?id=57671
625
626         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add "/results.html" to the URL.
627         * Scripts/old-run-webkit-tests: Add links to httpd access and error logs.
628
629 2011-04-01  Sam Weinig  <sam@webkit.org>
630
631         Fix windows build.
632
633         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
634         (TestWebKitAPI::TEST):
635         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
636         (TestWebKitAPI::flushMessages):
637
638 2011-04-01  Sam Weinig  <sam@webkit.org>
639
640         Reviewed by Adam Roben.
641
642         Add adoptWK to WKRetainPtr.h
643         https://bugs.webkit.org/show_bug.cgi?id=57670
644
645         * TestWebKitAPI/PlatformUtilities.h:
646         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
647         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
648         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
649         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
650         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
651         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
652         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
653         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
654         (TestWebKitAPI::createSessionStateContainingFormData):
655         * WebKitTestRunner/StringFunctions.h:
656         Replace custom versions of adoptWK with the API on in WebKit2/WKRetainPtr.h.
657
658 2011-04-01  Sam Weinig  <sam@webkit.org>
659
660         Reviewed by Adam Roben.
661
662         Fix leak noticed by Adam Roben in LayoutTestController::shadowRoot.
663
664         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
665         (WTR::LayoutTestController::shadowRoot):
666         Make judicious use of adoptWK().
667
668 2011-04-01  Sam Weinig  <sam@webkit.org>
669
670         Reviewed by Timothy Hatcher.
671
672         Fix extract-localizable-strings for macro change from UI_STRING -> WEB_UI_STRING.
673
674         * Scripts/extract-localizable-strings:
675
676 2011-04-01  Anders Carlsson  <andersca@apple.com>
677
678         Reviewed by Sam Weinig.
679
680         Shockwave plug-in doesn't accept mouse events
681         https://bugs.webkit.org/show_bug.cgi?id=57653
682         <rdar://problem/8483273>
683
684         Add a plug-in test.
685
686         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
687         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
688         (PluginTest::indicateTestFailure):
689         Move code from NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject here.
690
691         (PluginTest::NPN_ConvertPoint):
692         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
693         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp:
694         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
695         Call indicateTestFailure.
696
697         * DumpRenderTree/TestNetscapePlugIn/Tests/mac: Added.
698         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp: Added.
699         (ConvertPoint::ConvertPoint):
700         (ConvertPoint::testConvert):
701         (ConvertPoint::NPP_New):
702
703 2011-04-01  Dominic Cooney  <dominicc@google.com>
704
705         Reviewed by Martin Robinson.
706
707         Add layoutTestController.shadowRoot to GTK DumpRenderTree.
708         https://bugs.webkit.org/show_bug.cgi?id=57551
709
710         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
711         (LayoutTestController::shadowRoot):
712
713 2011-04-01  Sam Weinig  <sam@webkit.org>
714
715         Reviewed by Anders Carlsson.
716
717         WebKitTestRunner needs layoutTestController.shadowRoot
718         https://bugs.webkit.org/show_bug.cgi?id=57661
719
720         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
721         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
722         (WTR::LayoutTestController::shadowRoot):
723         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
724         Implement layoutTestController.shadowRoot for WebKit2.
725
726 2011-04-01  Chang Shu  <cshu@webkit.org>
727
728         Reviewed by Darin Adler.
729
730         WebKitTestRunner needs layoutTestController.setDatabaseQuota
731         https://bugs.webkit.org/show_bug.cgi?id=57568
732
733         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
734         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
735         (WTR::LayoutTestController::setDatabaseQuota):
736         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
737
738 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
739
740         Reviewed by Tony Chang.
741
742         This patch completes the cleanup of
743         rebaseline-chromium-webkit-tests to work with all of the
744         variants of a platform (we can now rebaseline gpu- and non-gpu
745         files at the same time).
746
747         When the rebaselining is complete, any lines declared as
748         REBASELINE in the expectations file that matches a test that was
749         actually rebaselined will be deleted, even if only one of the
750         variants was actually rebaselined. This may cause odd problems,
751         but is better than where we're at today.
752
753         This change removes the -g flag and deprecates -w. The -g flag is gone
754         because GPU baselines are handled just like any other variant.
755         The -w flag is deprecated because this tool now only works
756         against the canaries, since that's the only place we have a full
757         set of bots. It will be trivial to change this to
758         build.webkit.org if we decide that's where we want them to be.
759
760         Also, this patch deletes a lot of cruft that is no longer needed
761         in the test_expectations code and the port-specific code.
762
763         https://bugs.webkit.org/show_bug.cgi?id=55191
764
765         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
766         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
767         * Scripts/webkitpy/layout_tests/port/base.py:
768         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
769         * Scripts/webkitpy/layout_tests/port/chromium.py:
770         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
771         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
772         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
773         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
774         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
775         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
776         * Scripts/webkitpy/layout_tests/port/mac.py:
777         * Scripts/webkitpy/layout_tests/port/test.py:
778         * Scripts/webkitpy/layout_tests/port/webkit.py:
779         * Scripts/webkitpy/layout_tests/port/win.py:
780         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
781         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
782
783 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
784
785         Reviewed by Adam Barth.
786
787         rebaseline-chromium-webkit-tests does not work correctly with
788         version-specific baselines. This patch updates the tool to use
789         all of the version-specific bots on the canaries, and will now
790         attempt to rebaseline all of the versions by default, although
791         it will not update both GPU and CPU versions.
792         
793         Also, it will no longer modify the test_expectations.txt file
794         *at all*. You will have to manually delete the REBASELINE lines
795         after running the tool and determining that it did what you
796         wanted it to do. This should be fixed in a separate bug - see
797         webkit bug #55191.
798
799         https://bugs.webkit.org/show_bug.cgi?id=55608
800
801         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
802         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
803         * Scripts/webkitpy/layout_tests/port/chromium.py:
804         * Scripts/webkitpy/layout_tests/port/test.py:
805         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
806         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
807
808 2011-03-31  Tony Chang  <tony@chromium.org>
809
810         Reviewed by Ojan Vafai.
811
812         [chromium] update the rebaseline tool to know about pngs with checksums
813         https://bugs.webkit.org/show_bug.cgi?id=57481
814
815         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Skip over .checksum files if the checksum is already in the png
816         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
817
818 2011-04-01  Adam Roben  <aroben@apple.com>
819
820         Retrieve revision numbers from the build's got_revision property in Leaks Viewer
821
822         Previously, we were getting the revision of the first revision that triggered a build.
823         Choosing the last revision would have been more accurate. But got_revision is what is used
824         everywhere else on build.webkit.org, and should work even when there were no changes that
825         triggered a build (e.g., if someone clicked the Force Build button).
826
827         Fixes <http://webkit.org/b/57630> Leaks viewer gets some revision numbers wrong in the
828         recent builds list
829
830         Reviewed by Anders Carlsson.
831
832         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
833         (RecentBuildsLoader.prototype.start): Pull the revision number out of the got_revision
834         property, rather than out of the first (i.e., earliest) change in the sourceStamp object.
835
836         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:
837         (Array.prototype.first): Added this helper function to return the first element in an array
838         that matches the given predicate, or null if no such element exists.
839
840 2011-03-31  Adam Roben  <aroben@apple.com>
841
842         Prefer (but don't require) bug URLs to be on their own line when parsing bug numbers from ChangeLogs
843
844         Fixes <http://webkit.org/b/57579> webkit-patch is too strict about bug URL formatting
845
846         Reviewed by Darin Adler.
847
848         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
849         (parse_bug_id_from_changelog): Fall back to parse_bug_id if we weren't able to find a bug
850         URL on its own line.
851
852         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
853         (BugzillaTest.test_parse_bug_id_from_changelog): Updated expected results for test
854         progression, and added a new test that uses a short bug URL while I was at it.
855
856 2011-04-01  Adam Roben  <aroben@apple.com>
857
858         Mark .vcproj/.vsprops/.sln files as being Windows-only
859
860         Fixes <http://webkit.org/b/57489> Mac builders built 82512, but shouldn't have
861
862         Reviewed by Anders Carlsson.
863
864         * Scripts/webkitpy/common/config/build.py:
865         (_should_file_trigger_build): Added patterns to mark .vcproj/.vsprops/.sln files and .vcproj
866         directories as Windows-only.
867
868         * Scripts/webkitpy/common/config/build_unittest.py:
869         (ShoulBuildTest): Added test cases for the above.
870
871 2011-04-01  Keith Kyzivat  <keith.kyzivat@nokia.com>
872
873         Reviewed by Laszlo Gombos.
874
875         [Qt] Build MiniBrowser for Symbian
876         https://bugs.webkit.org/show_bug.cgi?id=56319
877
878         Have MiniBrowser reference it's own copy of useragentlist.txt instead
879         of copying QtTestBrowser's.
880         Remove Tools/MiniBrowser/DerivedSources.pro
881         This reduces complexity in the Tools scripts due to Symbian limitations.
882
883         * DerivedSources.pro:
884         * MiniBrowser/DerivedSources.pro: Removed.
885         * MiniBrowser/MiniBrowser.qrc:
886         * MiniBrowser/qt/MiniBrowser.pro:
887         * Scripts/webkitdirs.pm:
888
889 2011-03-31  Chang Shu  <cshu@webkit.org>
890
891         Reviewed by Darin Adler.
892
893         WebKitTestRunner needs layoutTestController.clearAllDatabases
894         https://bugs.webkit.org/show_bug.cgi?id=42540
895
896         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
897         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
898         (WTR::InjectedBundle::beginTesting):
899         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
900         (WTR::LayoutTestController::clearAllDatabases):
901         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
902
903 2011-03-31  Chang Shu  <cshu@webkit.org>
904
905         Reviewed by Darin Adler.
906
907         WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
908         https://bugs.webkit.org/show_bug.cgi?id=42692
909
910         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
911
912 2011-03-31  Darin Adler  <darin@apple.com>
913
914         Reviewed by Sam Weinig.
915
916         Implement mouseDown, mouseUp, and mouseMoveTo in WebKitTestRunner
917         https://bugs.webkit.org/show_bug.cgi?id=57573
918
919         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
920         Added real definitions for mouseDown, mouseUp, mouseMoveTo and leapForward.
921         Removed fake definitions of keyDown and contextClick.
922
923         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
924         (WTR::operator==): Added. So we can compare two WKPoint structs.
925         (WTR::parseModifier): Added.
926         (WTR::parseModifierArray): Added.
927         (WTR::EventSendingController::EventSendingController): Initialize the
928         new data members.
929         (WTR::EventSendingController::mouseDown): Added. Calls
930         WKBundlePageSimulateMouseDown.
931         (WTR::EventSendingController::mouseUp): Added. Calls
932         WKBundlePageSimulateMouseUp.
933         (WTR::EventSendingController::mouseMoveTo): Added. Calls
934         WKBundlePageSimulateMouseMotion.
935         (WTR::EventSendingController::leapForward): Added.
936         (WTR::EventSendingController::updateClickCount): Added. Used by the
937         mouseDown/Up functions to create a click count.
938
939         * WebKitTestRunner/InjectedBundle/EventSendingController.h: Updated
940         for the changes above.
941
942 2011-03-31  Sergio Villar Senin  <svillar@igalia.com>
943
944         Reviewed by Martin Robinson.
945
946         [GTK] implement LayoutTestController::setWillSendRequestReturnsNull
947         https://bugs.webkit.org/show_bug.cgi?id=57362
948
949         Do not generate DRT output if willSendRequestReturnsNull is set.
950
951         * DumpRenderTree/gtk/DumpRenderTree.cpp:
952         (willSendRequestCallback):
953
954 2011-03-31  Vamshikrishna.Yellenki  <vamshi@motorola.com> and Alejandro G. Castro  <alex@igalia.com>
955
956         Reviewed by Martin Robinson.
957
958         Implement MiniBrowser for Gtk port.
959         https://bugs.webkit.org/show_bug.cgi?id=48512
960
961         Initial implementation of the Gtk MiniBrowser.
962
963         * MiniBrowser/gtk/GNUmakefile.am: Added.
964         * MiniBrowser/gtk/main.c: Added.
965         (activateUriEntryCallback):
966         (destroyCallback):
967         (goBackCallback):
968         (goForwardCallback):
969         (createToolbar):
970         (createWebView):
971         (createWindow):
972         (argumentToURL):
973         (main):
974
975 2011-03-30  Dominic Cooney  <dominicc@google.com>
976
977         Reviewed by Dimitri Glazkov.
978
979         Adds layoutTestController.shadowRoot accessor to Mac DRT.
980         https://bugs.webkit.org/show_bug.cgi?id=57415
981
982         * DumpRenderTree/LayoutTestController.cpp:
983         (shadowRootCallback):
984         (LayoutTestController::staticFunctions):
985         * DumpRenderTree/LayoutTestController.h:
986         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
987         (LayoutTestController::shadowRoot):
988         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
989         (LayoutTestController::shadowRoot):
990
991 2011-03-30  Matthew Delaney  <mdelaney@apple.com>
992
993         Reviewed by Chris Marrin.
994
995         Update fast/canvas tests to avoid dumping the render tree when possible
996         https://bugs.webkit.org/show_bug.cgi?id=57493
997
998         * DumpRenderTree/mac/DumpRenderTree.mm: Make DRT aware of new default values for
999           accelerated drawing and accelerated drawing for canvas
1000
1001 2011-03-30  Adam Roben  <aroben@apple.com>
1002
1003         Stop ignoring leaks in CGGradientCreateWithColorStops
1004
1005         Fixes <rdar://problem/7888547>.
1006
1007         Rubber-stamped by John Sullivan.
1008
1009         * Scripts/old-run-webkit-tests:
1010         (countAndPrintLeaks): Removed some code to ignore those leaks.
1011
1012 2011-03-30  Timur Iskhodzhanov  <timurrrr@google.com>
1013
1014         Reviewed by Alexey Proskuryakov.
1015
1016         Add some dynamic annotations to JavaScriptCore/wtf
1017         https://bugs.webkit.org/show_bug.cgi?id=53747
1018
1019         By using these annotations we can improve the precision of finding
1020         WebKit errors using dynamic analysis tools like ThreadSanitizer and Valgrind.
1021         These annotations don't affect the compiled binaries unless USE(DYNAMIC_ANNOTATIONS) is "1".
1022
1023         These files don't add new functionality, so don't need extra tests.
1024
1025         * DumpRenderTree/ForwardingHeaders/wtf/DynamicAnnotations.h: Added.
1026
1027 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
1028
1029         Reviewed by Adam Roben.
1030
1031         Share most vsprops between Release and Production builds in releaseproduction.vsprops
1032         https://bugs.webkit.org/show_bug.cgi?id=57508
1033
1034         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
1035         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops:
1036         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops:
1037         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
1038         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops:
1039         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops:
1040         * DumpRenderTree/win/ImageDiffProduction.vsprops:
1041         * DumpRenderTree/win/ImageDiffRelease.vsprops:
1042         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops:
1043         * FindSafari/FindSafariProduction.vsprops:
1044         * FindSafari/FindSafariRelease.vsprops:
1045         * FindSafari/FindSafariReleaseCairoCFLite.vsprops:
1046         * FindSafari/FindSafariReleasePGO.vsprops:
1047         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
1048         * MiniBrowser/Configurations/MiniBrowserRelease.vsprops:
1049         * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops:
1050         * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops:
1051         * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops:
1052         * WebKitAPITest/WebKitAPITestProduction.vsprops:
1053         * WebKitAPITest/WebKitAPITestRelease.vsprops:
1054         * WebKitAPITest/WebKitAPITestReleaseCairoCFLite.vsprops:
1055         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
1056         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops:
1057         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops:
1058         * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
1059         * WebKitTestRunner/win/InjectedBundleRelease.vsprops:
1060         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops:
1061         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
1062         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops:
1063         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops:
1064         * WinLauncher/WinLauncherProduction.vsprops:
1065         * WinLauncher/WinLauncherRelease.vsprops:
1066         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops:
1067         * record-memory-win/record-memory-winProduction.vsprops:
1068         * record-memory-win/record-memory-winRelease.vsprops:
1069         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops:
1070
1071 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
1072
1073         Reviewed by Adam Roben.
1074
1075         Update Windows production build logic for new production configurations
1076         https://bugs.webkit.org/show_bug.cgi?id=57494
1077
1078         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
1079         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
1080         * DumpRenderTree/win/ImageDiffProduction.vsprops:
1081         * FindSafari/FindSafariProduction.vsprops:
1082         * FindSafari/FindSafariReleasePGO.vsprops:
1083         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
1084         * WebKitAPITest/WebKitAPITestProduction.vsprops:
1085         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
1086         * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
1087         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
1088         * WinLauncher/WinLauncherProduction.vsprops:
1089         * record-memory-win/record-memory-winProduction.vsprops:
1090
1091 2011-03-30  Robert Hogan  <robert@webkit.org>
1092
1093         Reviewed by Antonio Gomes.
1094
1095         [Qt] Fix LoadHTMLStringItem::invoke() after r75966
1096         Unskip http/tests/navigation/go-back-to-error-page.html
1097
1098         Also add the location of DumpRenderTreeSupportQt.h
1099         to DRT's include paths.
1100
1101         https://bugs.webkit.org/show_bug.cgi?id=52614
1102
1103         * DumpRenderTree/qt/DumpRenderTree.pro:
1104         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1105         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1106         * DumpRenderTree/qt/GCControllerQt.cpp:
1107         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1108         (LayoutTestController::queueLoadHTMLString):
1109         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1110         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
1111         * DumpRenderTree/qt/TextInputControllerQt.cpp:
1112         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
1113         (LoadAlternateHTMLStringItem::invoke):
1114         * DumpRenderTree/qt/WorkQueueItemQt.h:
1115         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
1116         * QtTestBrowser/QtTestBrowser.pro:
1117         * QtTestBrowser/launcherwindow.h:
1118
1119 2011-03-30  Adam Barth  <abarth@webkit.org>
1120
1121         Reviewed by Adam Roben.
1122
1123         SheriffBot rollouts take too long
1124         https://bugs.webkit.org/show_bug.cgi?id=57498
1125
1126         We used to build before landing rollouts via the commit-queue to
1127         prevent further breakage, but now that our individual commit-queue
1128         machines are slower, building takes too long.  I can't remember the
1129         last time a rollout broke compile.  It seems like just landing the
1130         patch is the better trade-off.
1131
1132         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1133         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1134
1135 2011-03-30  Adam Barth  <abarth@webkit.org>
1136
1137         Remove platform/chromium-mac-snowleopard
1138         https://bugs.webkit.org/show_bug.cgi?id=57486
1139
1140         This directory no longer exists, so we can remove it from the fallback
1141         chain.
1142
1143         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1144
1145 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
1146
1147         Reviewed by Adam Roben.
1148
1149         Rename Windows configuration Release_LTCG to Production for clarity
1150         https://bugs.webkit.org/show_bug.cgi?id=57465
1151
1152         * DumpRenderTree/DumpRenderTree.sln:
1153         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1154         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops: Copied from Tools/DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops.
1155         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops: Removed.
1156         * DumpRenderTree/win/DumpRenderTree.vcproj:
1157         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops: Copied from Tools/DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops.
1158         * DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops: Removed.
1159         * DumpRenderTree/win/ImageDiff.vcproj:
1160         * DumpRenderTree/win/ImageDiffProduction.vsprops: Copied from Tools/DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops.
1161         * DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops: Removed.
1162         * FindSafari/FindSafari.vcproj:
1163         * FindSafari/FindSafariProduction.vsprops: Copied from Tools/FindSafari/FindSafariReleaseLTCG.vsprops.
1164         * FindSafari/FindSafariReleaseLTCG.vsprops: Removed.
1165         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops: Copied from Tools/MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops.
1166         * MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops: Removed.
1167         * MiniBrowser/MiniBrowser.vcproj:
1168         * Scripts/webkitdirs.pm:
1169         * TestWebKitAPI/win/TestWebKitAPI.sln:
1170         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1171         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
1172         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
1173         * WebKitAPITest/WebKitAPITest.vcproj:
1174         * WebKitAPITest/WebKitAPITestProduction.vsprops: Copied from Tools/WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops.
1175         * WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops: Removed.
1176         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
1177         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops: Copied from Tools/WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops.
1178         * WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops: Removed.
1179         * WebKitTestRunner/WebKitTestRunner.sln:
1180         * WebKitTestRunner/win/InjectedBundle.vcproj:
1181         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
1182         * WebKitTestRunner/win/InjectedBundleProduction.vsprops: Copied from Tools/WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops.
1183         * WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops: Removed.
1184         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1185         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops: Copied from Tools/WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops.
1186         * WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops: Removed.
1187         * WinLauncher/WinLauncher.vcproj:
1188         * WinLauncher/WinLauncherProduction.vsprops: Copied from Tools/WinLauncher/WinLauncherReleaseLTCG.vsprops.
1189         * WinLauncher/WinLauncherReleaseLTCG.vsprops: Removed.
1190         * record-memory-win/record-memory-win.vcproj:
1191         * record-memory-win/record-memory-winProduction.vsprops: Copied from Tools/record-memory-win/record-memory-winReleaseLTCG.vsprops.
1192         * record-memory-win/record-memory-winReleaseLTCG.vsprops: Removed.
1193
1194 2011-03-30  MORITA Hajime  <morrita@google.com>
1195
1196         Reviewed by Dimitri Glazkov.
1197
1198         [Chromium] Expose the shadow DOM to DumpRenderTree JS tests.
1199         https://bugs.webkit.org/show_bug.cgi?id=56573
1200
1201         Added LayoutTestController.shadowRoot() to Chromium DRT.
1202
1203         * DumpRenderTree/chromium/LayoutTestController.cpp:
1204         (LayoutTestController::LayoutTestController):
1205         (LayoutTestController::shadowRoot):
1206         * DumpRenderTree/chromium/LayoutTestController.h:
1207
1208 2011-03-30  Yuta Kitamura  <yutak@chromium.org>
1209
1210         Reviewed by Kent Tamura.
1211
1212         [Chromium] DumpRenderTree: Implement LayoutTestController::setPluginsEnabled
1213         https://bugs.webkit.org/show_bug.cgi?id=57430
1214
1215         * DumpRenderTree/chromium/LayoutTestController.cpp:
1216         (LayoutTestController::LayoutTestController):
1217         (LayoutTestController::setPluginsEnabled):
1218         * DumpRenderTree/chromium/LayoutTestController.h:
1219
1220 2011-03-30  Maciej Stachowiak  <mjs@apple.com>
1221
1222         Reviewed by Adam Barth.
1223
1224         make webkit-patch upload respect -d
1225         https://bugs.webkit.org/show_bug.cgi?id=57425
1226
1227         * Scripts/webkitpy/common/checkout/scm.py:
1228         * Scripts/webkitpy/tool/steps/commit.py:
1229
1230 2011-03-30  Maciej Stachowiak  <mjs@apple.com>
1231
1232         Reviewed by Adam Barth.
1233
1234         Make "webkit-patch --dry-run --verbose land" log the SVN command it's going to use
1235         https://bugs.webkit.org/show_bug.cgi?id=57429
1236
1237         * Scripts/webkitpy/common/checkout/scm.py:
1238
1239 2011-03-29  Sheriff Bot  <webkit.review.bot@gmail.com>
1240
1241         Unreviewed, rolling out r82383.
1242         http://trac.webkit.org/changeset/82383
1243         https://bugs.webkit.org/show_bug.cgi?id=57417
1244
1245         "nrwt isn't shutting down cleanly" (Requested by dpranke on
1246         #webkit).
1247
1248         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1249         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1250         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1251
1252 2011-03-29  Kent Tamura  <tkent@chromium.org>
1253
1254         Reviewed by Dimitri Glazkov.
1255
1256         Make validation message bubble testable
1257         https://bugs.webkit.org/show_bug.cgi?id=57290
1258
1259         * DumpRenderTree/mac/DumpRenderTree.mm:
1260         (createWebViewAndOffscreenWindow): Change a setting so that validation
1261           bubbles isn't hidden automatically.
1262
1263 2011-03-29  Dirk Pranke  <dpranke@chromium.org>
1264
1265         Reviewed by Ojan Vafai.
1266
1267         new-run-webkit-tests: use 'threads' on win instead of 'old-threads'
1268
1269         It's a bit unclear whether multiple threads or multiple
1270         processes will be a better model on windows. This change will
1271         test threads for now while we're still working out the bugs in
1272         multiple-processes.
1273
1274         https://bugs.webkit.org/show_bug.cgi?id=57410
1275
1276         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1277         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1278         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1279
1280 2011-03-29  David Levin  <levin@chromium.org>
1281
1282         Reviewed by Shinichiro Hamaji.
1283
1284         check-webkit-style confused by two ChangeLog entries in a row from same user
1285         https://bugs.webkit.org/show_bug.cgi?id=57250
1286
1287         * Scripts/webkitpy/style/checker.py: Add the line should be checked function to ChangeLogChecker.
1288         * Scripts/webkitpy/style/checker_unittest.py: Fix test due to that new function.
1289         * Scripts/webkitpy/style/checkers/changelog.py: Made this code aware of what lines were being checked.
1290           It basically assumes only one ChangeLog entry is being processed because that is the standard case and
1291           checking more than that would be very messey.
1292         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Add testing to catch the broken case.
1293         * Scripts/webkitpy/style/error_handlers.py: Added should_line_be_checked.
1294
1295 2011-03-29  Kent Tamura  <tkent@chromium.org>
1296
1297         Reviewed by Dimitri Glazkov.
1298
1299         [Mac] Enable interactive-validation tests on Mac DRT
1300         https://bugs.webkit.org/show_bug.cgi?id=57308
1301
1302         * DumpRenderTree/mac/DumpRenderTree.mm:
1303         (createWebViewAndOffscreenWindow): Enable the form interactive validation feature.
1304
1305 2011-03-29  Chang Shu  <cshu@webkit.org>
1306
1307         Reviewed by Kenneth Rohde Christiansen.
1308
1309         WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
1310         https://bugs.webkit.org/show_bug.cgi?id=42692
1311
1312         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1313         (WTR::InjectedBundle::beginTesting):
1314         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1315         (WTR::LayoutTestController::setAllowUniversalAccessFromFileURLs):
1316         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1317
1318 2011-03-24  Martin Robinson  <mrobinson@igalia.com>
1319
1320         Reviewed by Xan Lopez.
1321
1322         [GTK] [DRT] GtkScrolledWindow adds three pixels of padding between the WebView and the scrollbar
1323         https://bugs.webkit.org/show_bug.cgi?id=57067
1324
1325         Eliminate extra spacing between the DRT GtkScrolledWindow and the DRT WebView. This
1326         will allow WebKit1GTK+ and WebKit2GTK+ to share test results. Followup commits will
1327         update DRT and pixel results as hundreds of results will need to be updated.
1328
1329         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1330         (setDefaultsToConsistentStateValuesForTesting): Eliminate spacing on the GtkScrolledWindow
1331         by overriding the theme RC/CSS files.
1332
1333 2011-03-29  Steve Falkenburg  <sfalken@apple.com>
1334
1335         Reviewed by Adam Roben.
1336
1337         Use per-configuration vsprops in tools projects to avoid WebKitVSPropsRedirectionDir removal by MSVC IDE
1338         https://bugs.webkit.org/show_bug.cgi?id=57394
1339
1340         Visual Studio's IDE was removing instances of $(WebKitVSPropsRedirectionDir) from
1341         InheritedPropertySheet rules in our vcproj files when the vcproj was edited from within
1342         the IDE. To avoid this, add a separate vsprops file for each project configuration that
1343         contains the required inherited property sheets.
1344
1345         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1346         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebug.vsprops: Added.
1347         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugAll.vsprops: Added.
1348         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugCairoCFLite.vsprops: Added.
1349         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops: Added.
1350         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops: Added.
1351         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops: Added.
1352         * DumpRenderTree/win/DumpRenderTree.vcproj:
1353         * DumpRenderTree/win/DumpRenderTreeDebug.vsprops: Added.
1354         * DumpRenderTree/win/DumpRenderTreeDebugAll.vsprops: Added.
1355         * DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops: Added.
1356         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops: Added.
1357         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops: Added.
1358         * DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops: Added.
1359         * DumpRenderTree/win/ImageDiff.vcproj:
1360         * DumpRenderTree/win/ImageDiffDebug.vsprops: Added.
1361         * DumpRenderTree/win/ImageDiffDebugAll.vsprops: Added.
1362         * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops: Added.
1363         * DumpRenderTree/win/ImageDiffRelease.vsprops: Added.
1364         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops: Added.
1365         * DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops: Added.
1366         * FindSafari/FindSafari.vcproj:
1367         * FindSafari/FindSafariDebug.vsprops: Added.
1368         * FindSafari/FindSafariDebugAll.vsprops: Added.
1369         * FindSafari/FindSafariDebugCairoCFLite.vsprops: Added.
1370         * FindSafari/FindSafariRelease.vsprops: Added.
1371         * FindSafari/FindSafariReleaseCairoCFLite.vsprops: Added.
1372         * FindSafari/FindSafariReleaseLTCG.vsprops: Added.
1373         * FindSafari/FindSafariReleasePGO.vsprops: Added.
1374         * MiniBrowser/Configurations/MiniBrowserDebug.vsprops: Added.
1375         * MiniBrowser/Configurations/MiniBrowserDebugAll.vsprops: Added.
1376         * MiniBrowser/Configurations/MiniBrowserDebugCairoCFLite.vsprops: Added.
1377         * MiniBrowser/Configurations/MiniBrowserRelease.vsprops: Added.
1378         * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops: Added.
1379         * MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops: Added.
1380         * MiniBrowser/MiniBrowser.vcproj:
1381         * WebKitAPITest/WebKitAPITest.vcproj:
1382         * WebKitAPITest/WebKitAPITestDebug.vsprops: Added.
1383         * WebKitAPITest/WebKitAPITestDebugAll.vsprops: Added.
1384         * WebKitAPITest/WebKitAPITestDebugCairoCFLite.vsprops: Added.
1385         * WebKitAPITest/WebKitAPITestRelease.vsprops: Added.
1386         * WebKitAPITest/WebKitAPITestReleaseCairoCFLite.vsprops: Added.
1387         * WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops: Added.
1388         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
1389         * WebKitLauncherWin/WebKitLauncherWinDebug.vsprops: Added.
1390         * WebKitLauncherWin/WebKitLauncherWinDebugAll.vsprops: Added.
1391         * WebKitLauncherWin/WebKitLauncherWinDebugCairoCFLite.vsprops: Added.
1392         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops: Added.
1393         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops: Added.
1394         * WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops: Added.
1395         * WebKitTestRunner/win/InjectedBundle.vcproj:
1396         * WebKitTestRunner/win/InjectedBundleDebug.vsprops: Added.
1397         * WebKitTestRunner/win/InjectedBundleDebugAll.vsprops: Added.
1398         * WebKitTestRunner/win/InjectedBundleDebugCairoCFLite.vsprops: Added.
1399         * WebKitTestRunner/win/InjectedBundleRelease.vsprops: Added.
1400         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops: Added.
1401         * WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops: Added.
1402         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1403         * WebKitTestRunner/win/WebKitTestRunnerDebug.vsprops: Added.
1404         * WebKitTestRunner/win/WebKitTestRunnerDebugAll.vsprops: Added.
1405         * WebKitTestRunner/win/WebKitTestRunnerDebugCairoCFLite.vsprops: Added.
1406         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops: Added.
1407         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops: Added.
1408         * WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops: Added.
1409         * WinLauncher/WinLauncher.vcproj:
1410         * WinLauncher/WinLauncherDebug.vsprops: Added.
1411         * WinLauncher/WinLauncherDebugAll.vsprops: Added.
1412         * WinLauncher/WinLauncherDebugCairoCFLite.vsprops: Added.
1413         * WinLauncher/WinLauncherRelease.vsprops: Added.
1414         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops: Added.
1415         * WinLauncher/WinLauncherReleaseLTCG.vsprops: Added.
1416         * record-memory-win/record-memory-win.vcproj:
1417         * record-memory-win/record-memory-winDebug.vsprops: Added.
1418         * record-memory-win/record-memory-winDebugAll.vsprops: Added.
1419         * record-memory-win/record-memory-winDebugCairoCFLite.vsprops: Added.
1420         * record-memory-win/record-memory-winRelease.vsprops: Added.
1421         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops: Added.
1422         * record-memory-win/record-memory-winReleaseLTCG.vsprops: Added.
1423
1424 2011-03-29  Adam Barth  <abarth@webkit.org>
1425
1426         Reviewed by Darin Adler.
1427
1428         test_runner2.py can crash due to undefined variable
1429         https://bugs.webkit.org/show_bug.cgi?id=57356
1430
1431         Replace reference to undefined variable with a variable that's actually
1432         defined.  AFAICT, there's no way to test this code.
1433
1434         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
1435
1436 2011-03-29  Tony Chang  <tony@chromium.org>
1437
1438         Reviewed by Eric Seidel.
1439
1440         cleanup rebaseline-chromium-webkit-tests
1441         https://bugs.webkit.org/show_bug.cgi?id=57375
1442
1443         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1444             - Split _extract_and_add_new_baselines into 3 functions
1445             - Reduce the amount of line wrapping (the file already has lines
1446               over 80 col, so may as well try to make the file consistent)
1447             - Remove unnecessary ()s
1448
1449 2011-03-29  Brent Fulgham  <bfulgham@webkit.org>
1450
1451         Reviewed by Adam Roben.
1452
1453         Make WinCairo a core builder.
1454         https://bugs.webkit.org/show_bug.cgi?id=57373
1455
1456         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Add WinCairo.
1457         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Add WinCairo.
1458
1459 2011-03-29  Timothy Hatcher  <timothy@apple.com>
1460
1461         Update update-webkit-localizable-strings to understand that WebKit and
1462         WebKit2 strings go in WebCore.
1463
1464         Also make extract-localizable-strings optionally use an exclude file. No individual
1465         warnings are produced about unlocalized strings when there is no exclude file. This
1466         is needed for WebCore, since there are too many bare strings.
1467
1468         https://webkit.org/b/57354
1469
1470         Reviewed by Sam Weinig.
1471
1472         * Scripts/extract-localizable-strings: Support "-" to mean no exclude file.
1473         * Scripts/update-webkit-localizable-strings: Update paths to scan WebCore and WebKit2.
1474
1475 2011-03-29  Darin Adler  <darin@apple.com>
1476
1477         Reviewed by Adam Roben.
1478
1479         WebKit2 bundle page needs to offer generated file hooks
1480         https://bugs.webkit.org/show_bug.cgi?id=57279
1481
1482         (Land missing part of the original patch after r82289.)
1483
1484         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1485         (WTR::InjectedBundlePage::InjectedBundlePage): Added new callbacks.
1486
1487 2011-03-29  Tony Chang  <tony@chromium.org>
1488
1489         Reviewed by Ojan Vafai.
1490
1491         [chromium] NRWT should be able to read checksums from png comments
1492         https://bugs.webkit.org/show_bug.cgi?id=57280
1493
1494         * Scripts/read-checksum-from-png: Added. Utility script to read the checksum
1495             from a file.
1496         * Scripts/webkitpy/common/system/filesystem.py: Add open_binary_file_for_reading
1497         * Scripts/webkitpy/common/system/filesystem_mock.py:
1498         * Scripts/webkitpy/layout_tests/port/base.py: When loading a checksum,
1499             if the -checksum.txt file doesn't exist, try looking in the png.
1500         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1501         * Scripts/webkitpy/layout_tests/port/test.py:
1502         * Scripts/webkitpy/layout_tests/read_checksum_from_png.py: Added. Scan the first
1503             2k for a png comment with the checksum
1504         * Scripts/webkitpy/layout_tests/read_checksum_from_png_unittest.py: Added.
1505
1506 2011-03-29  Philippe Normand  <pnormand@igalia.com>
1507
1508         Rubber-stamped by Gustavo Noronha Silva.
1509
1510         [GTK] http/tests/uri/username-with-no-hostname.html fails
1511         https://bugs.webkit.org/show_bug.cgi?id=57325
1512
1513         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1514         (willSendRequestCallback): URI host value check done case-insensitively.
1515
1516 2011-03-29  Philippe Normand  <pnormand@igalia.com>
1517
1518         Reviewed by Martin Robinson.
1519
1520         [GTK] http/tests/uri/username-with-no-hostname.html fails
1521         https://bugs.webkit.org/show_bug.cgi?id=57325
1522
1523         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1524         (willSendRequestCallback): Check URI before submitting the request
1525         to WebCore.
1526
1527 2011-03-29  Noel Gordon  <noel.gordon@gmail.com>
1528
1529         Reviewed by Ojan Vafai.
1530
1531         [chromium] DRT EventSender: remove identity from dragTargetDragEnter() calls
1532         https://bugs.webkit.org/show_bug.cgi?id=57303
1533
1534         * DumpRenderTree/chromium/EventSender.cpp:
1535         (EventSender::doDragDrop):
1536         (EventSender::beginDragWithFiles):
1537
1538 2011-03-29  Zoltan Horvath  <zoltan@webkit.org>
1539
1540         Reviewed by Andreas Kling.
1541
1542         [Qt] Add -print-loaded-urls option to Qt's MiniBrowser and to QtTestBrowser
1543         https://bugs.webkit.org/show_bug.cgi?id=57314
1544
1545         Provide possibility to print loaded urls to the standard output.
1546
1547         * MiniBrowser/qt/BrowserWindow.cpp:
1548         (BrowserWindow::BrowserWindow):
1549         (BrowserWindow::printURL):
1550         * MiniBrowser/qt/BrowserWindow.h:
1551         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1552         (MiniBrowserApplication::handleUserOptions):
1553         * MiniBrowser/qt/MiniBrowserApplication.h:
1554         (WindowOptions::WindowOptions):
1555         * QtTestBrowser/launcherwindow.cpp:
1556         (LauncherWindow::initializeView):
1557         (LauncherWindow::printURL):
1558         (LauncherWindow::cloneWindow):
1559         * QtTestBrowser/launcherwindow.h:
1560         (WindowOptions::WindowOptions):
1561         * QtTestBrowser/main.cpp:
1562         (LauncherApplication::handleUserOptions):
1563
1564 2011-03-29  Gabor Loki  <loki@webkit.org>
1565
1566         Rubber-stamped by Csaba Osztrogonác.
1567
1568         [Qt] Teach build-jsc how to build JavaScriptCore on Qt
1569         https://bugs.webkit.org/show_bug.cgi?id=56918
1570
1571         * Scripts/build-jsc: Remove duplicated --qt options to avoid passing them to qmake.
1572
1573 2011-03-28  Gabor Loki  <loki@webkit.org>
1574
1575         Reviewed by Csaba Osztrogonác.
1576
1577         [Qt] Teach build-jsc how to build JavaScriptCore on Qt
1578         https://bugs.webkit.org/show_bug.cgi?id=56918
1579
1580         * Scripts/build-jsc:
1581         * Scripts/webkitdirs.pm:
1582
1583 2011-03-28  Andrew Foster  <andrewf@chromium.org>
1584
1585         Reviewed by Ojan Vafai.
1586
1587         webkit-patch should be more intelligent about whether a bug applies to a patch
1588         Create a new function, parse_bug_id_from_changelog() which determines
1589         that a bug is related to a patch by parsing the output generated from
1590         prepare-ChangeLog, rather than arbitrarily matching a URL to a bug in
1591         the description of a patch.
1592         https://bugs.webkit.org/show_bug.cgi?id=56989
1593
1594         * Scripts/webkitpy/common/checkout/api.py:
1595         * Scripts/webkitpy/common/checkout/changelog.py:
1596         * Scripts/webkitpy/common/net/bugzilla/__init__.py:
1597         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1598         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1599         * Scripts/webkitpy/style/checkers/changelog.py:
1600         * Scripts/webkitpy/tool/commands/upload.py:
1601
1602 2011-03-28  Maciej Stachowiak  <mjs@apple.com>
1603
1604         Revert accidentally commited change.
1605
1606         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1607         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
1608
1609 2011-03-28  Tony Chang  <tony@chromium.org>
1610
1611         Reviewed by Adam Barth.
1612
1613         [chromium] have DRT write the png checksum into a png comment
1614         https://bugs.webkit.org/show_bug.cgi?id=57255
1615
1616         * DumpRenderTree/chromium/TestShell.cpp:
1617         (TestShell::dumpImage):
1618
1619 2011-03-28  Adele Peterson  <adele@apple.com>
1620
1621         Removing Qt stub, since it doesn't use the same header as the others.
1622
1623         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1624
1625 2011-03-28  Adele Peterson  <adele@apple.com>
1626
1627         Added a few more stubs.
1628
1629         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1630         (LayoutTestController::hasGrammarMarker):
1631         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1632         (LayoutTestController::hasGrammarMarker):
1633         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1634         (LayoutTestController::hasGrammarMarker):
1635
1636 2011-03-28  Adele Peterson  <adele@apple.com>
1637
1638         Build fix.
1639
1640         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1641         (LayoutTestController::hasGrammarMarker):
1642
1643 2011-03-28  Adele Peterson  <adele@apple.com>
1644
1645         Reviewed by Eric Seidel.
1646
1647         Testing support for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
1648         https://bugs.webkit.org/show_bug.cgi?id=57173
1649
1650         * DumpRenderTree/LayoutTestController.cpp:
1651         (hasGrammarMarkerCallback): Added.
1652         (LayoutTestController::staticFunctions): Added case for hasGrammarMarker.
1653         * DumpRenderTree/LayoutTestController.h:
1654         * DumpRenderTree/mac/DumpRenderTree.mm: (createWebViewAndOffscreenWindow): Call setGrammarCheckingEnabled.
1655         * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::hasGrammarMarker): Added. Call new hasGrammarMarker method.
1656
1657 2011-03-28  Csaba Osztrogonác  <ossy@webkit.org>
1658
1659         Reviewed by Benjamin Poulain.
1660
1661         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
1662         https://bugs.webkit.org/show_bug.cgi?id=57087
1663
1664         Trivial typo fix after r82082.
1665
1666         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1667         (WTR::activateFonts):
1668
1669 2011-03-28  Alexis Menard  <alexis.menard@openbossa.org>
1670
1671         Reviewed by Andreas Kling.
1672
1673         Add myself to the committers list.
1674
1675         * Scripts/webkitpy/common/config/committers.py:
1676
1677 2011-03-28  Simon Fraser  <simon.fraser@apple.com>
1678
1679         Reviewed by Sam Weinig.
1680
1681         WebKit2 unfortunately uses code from WebKit, so MiniBrowser needs
1682         to link against WebKit.framework for now.
1683
1684         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1685
1686 2011-03-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
1687
1688         Reviewed by Andreas Kling.
1689
1690         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
1691         https://bugs.webkit.org/show_bug.cgi?id=57087
1692
1693         Disable QT_ASCII_CAST_WARNINGS for applications.
1694
1695         * DumpRenderTree/qt/DumpRenderTree.pro:
1696         * DumpRenderTree/qt/ImageDiff.pro:
1697         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1698         * MiniBrowser/qt/MiniBrowser.pro:
1699         * QtTestBrowser/QtTestBrowser.pro:
1700         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1701
1702 2011-03-28  Andreas Kling  <kling@webkit.org>
1703
1704         Reviewed by Kenneth Rohde Christiansen.
1705
1706         [Qt] QtTestBrowser doesn't reset its window title when opening about:blank
1707         https://bugs.webkit.org/show_bug.cgi?id=57224
1708
1709         * QtTestBrowser/mainwindow.cpp:
1710         (MainWindow::buildUI):
1711         (MainWindow::onTitleChanged):
1712         * QtTestBrowser/mainwindow.h:
1713
1714 2011-03-27  Jer Noble  <jer.noble@apple.com>
1715
1716         Reviewed by Maciej Stachowiak.
1717
1718         Full Screen: disable keyboard access by default
1719         https://bugs.webkit.org/show_bug.cgi?id=56684
1720
1721         Accept the withKeyboard parameter to supportsFullScreenForElement.
1722
1723         * DumpRenderTree/mac/UIDelegate.mm:
1724         (-[UIDelegate webView:supportsFullScreenForElement:withKeyboard:]):
1725
1726 2011-03-27  Patrick Gansterer  <paroga@webkit.org>
1727
1728         Reviewed by David Levin.
1729
1730         check-webkit-style should check ChangeLog for a valid bug number
1731         https://bugs.webkit.org/show_bug.cgi?id=57184
1732
1733         * Scripts/webkitpy/style/checker.py:
1734         * Scripts/webkitpy/style/checker_unittest.py:
1735         * Scripts/webkitpy/style/checkers/changelog.py: Added.
1736         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Added.
1737
1738 2011-03-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
1739
1740         Reviewed by Andreas Kling.
1741
1742         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
1743         https://bugs.webkit.org/show_bug.cgi?id=57087
1744
1745         Use explicit conversion for string to avoid depending on the default codec
1746         installed by the user code.
1747
1748         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1749         (WTR::activateFonts):
1750
1751 2011-03-26  Maciej Stachowiak  <mjs@apple.com>
1752
1753         Revert inadvertantly committed changes.
1754
1755         * Scripts/old-run-webkit-tests:
1756         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1757
1758 2011-03-26  Andreas Kling  <kling@webkit.org>
1759
1760         Reviewed by Kenneth Rohde Christiansen.
1761
1762         [Qt] Show page icons (favicons) in QtTestBrowser location bar.
1763         https://bugs.webkit.org/show_bug.cgi?id=57162
1764
1765         * QtTestBrowser/QtTestBrowser.qrc:
1766         * QtTestBrowser/favicon.png: Added.
1767         * QtTestBrowser/locationedit.cpp:
1768         (defaultPageIcon):
1769         (LocationEdit::LocationEdit):
1770         (LocationEdit::setPageIcon):
1771         (LocationEdit::resizeEvent):
1772         (LocationEdit::updateInternalGeometry):
1773         * QtTestBrowser/locationedit.h:
1774         * QtTestBrowser/mainwindow.cpp:
1775         (MainWindow::buildUI):
1776         (MainWindow::onIconChanged):
1777         (MainWindow::onLoadStarted):
1778         * QtTestBrowser/mainwindow.h:
1779
1780 2011-03-23  Martin Robinson  <mrobinson@igalia.com>
1781
1782         Reviewed by Xan Lopez.
1783
1784         [GTK] Force DumpRenderTree to use 96 DPI
1785         https://bugs.webkit.org/show_bug.cgi?id=56866
1786
1787         Make sure that GTK+ is set to use 96 DPI when running tests. This ensures
1788         broader compatibility with WebKit2 and makes setting font sizes more straightforward.
1789
1790         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1791         (initializeGtkFontSettings): Set the screen resolution and GTK+ xft property to 96 DPI.
1792         (resetDefaultsToConsistentValues):Remove the call which repeatedly set the GDK screen resolution.
1793         (setDefaultsToConsistentStateValuesForTesting): Update the font sizes to reflect the new DPI.
1794
1795 2011-03-25  Andy Estes  <aestes@apple.com>
1796
1797         Reviewed by Adele Peterson.
1798
1799         REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
1800         https://bugs.webkit.org/show_bug.cgi?id=49016
1801
1802         TestNetscapePlugIn needs to register support for an image MIME type so
1803         we can test that the embed tag prefers plug-ins to render image MIME
1804         types.
1805
1806         * DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Register image/png.
1807         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1808         (NP_GetMIMEDescription): Ditto.
1809         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Ditto.
1810
1811 2011-03-25  Jessie Berlin  <jberlin@apple.com>
1812
1813         Reviewed by Sam Weinig.
1814
1815         WebKit2: Need to be able to set and get the Cookie Storage Policy.
1816         https://bugs.webkit.org/show_bug.cgi?id=50780
1817
1818         Add a test for getting and setting the HTTP Cookie Accept Policy in WebKit2.
1819
1820         The test is named "CookieManager" so that we can eventually exercise more of the
1821         CookieManager functionality in the test.
1822
1823         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp: Added.
1824         (TestWebKitAPI::didGetTestHTTPCookieAcceptPolicy):
1825         Assert that the policy returned is equal to the policy set in
1826         didGetUserHTTPCookieAcceptPolicy, and then restore the user's policy.
1827         (TestWebKitAPI::didGetUserHTTPCookieAcceptPolicy):
1828         Set the policy to something different than the user's policy and get the policy again.
1829         (TestWebKitAPI::didFinishLoadForFrame):
1830         Get the user's policy so that it can be restored at the end of the test.
1831         (TestWebKitAPI::TEST):
1832         Load about:blank so that the Web Process gets instatiated (needed to get the
1833         CookieManager).
1834
1835         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1836         Add CookieManager.cpp.
1837
1838 2011-03-24  Kevin Ollivier  <kevino@theolliviers.com>
1839
1840         [wx] Fix the build so that gcc-4.1 and up can be used to build on SnowLeopard.
1841
1842         * wx/build/settings.py:
1843
1844 2011-03-24  Ilya Sherman  <isherman@chromium.org>
1845
1846         Reviewed by Adam Roben.
1847
1848         Implement layoutTestController.setAutoFilled in DRT on Windows
1849         https://bugs.webkit.org/show_bug.cgi?id=56828
1850
1851         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1852         (LayoutTestController::setAutofilled): Implemented.
1853
1854 2011-03-24  Brent Fulgham  <bfulgham@webkit.org>
1855
1856         Unreviewed build correction.
1857
1858         Correct vsprops file for Debug variant of the CFLite build.
1859         Disable a CFNETWORK-specific test when building for CFLite.
1860
1861         * TestWebKitAPI/Configurations/TestWebKitAPIDebugCairoCFLite.vsprops:
1862         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1863
1864 2011-03-24  Dirk Pranke  <dpranke@chromium.org>
1865
1866         Reviewed by Adam Barth.
1867
1868         fix regressions introduced in 81908 - there were a couple of
1869         code paths that only fired under python 2.5 that I missed.
1870
1871         Also change a couple of 'python' references to sys.executable
1872         in order to handle runing test-webkitpy with a binary other than
1873         something called 'python'.
1874
1875         https://bugs.webkit.org/show_bug.cgi?id=57063
1876
1877         * Scripts/webkitpy/layout_tests/port/mac.py:
1878         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1879         * Scripts/webkitpy/test/cat.py:
1880         * Scripts/webkitpy/test/echo.py:
1881
1882 2011-03-24  Brent Fulgham  <bfulgham@webkit.org>
1883
1884         Unreviewed build correction.
1885
1886         Add a stub implementation of the TestInvocation dumping logic.
1887         Update project files to reflect new file.
1888
1889         * WebKitTestRunner/cairo: Added.
1890         * WebKitTestRunner/cairo/TestInvocationCairo.cpp: Added.
1891         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1892         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1893
1894 2011-03-24  Dirk Pranke  <dpranke@chromium.org>
1895
1896         Reviewed by Tony Chang.
1897
1898         new-run-webkit-tests: clean up worker model defaults. This
1899         changes the default behavior to 'threads' instead of
1900         'old-threads', and clarifies that chromium-win-* and
1901         chromium-mac-leopard are exceptions.
1902
1903         https://bugs.webkit.org/show_bug.cgi?id=56971
1904
1905         * Scripts/webkitpy/layout_tests/port/base.py:
1906         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1907         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1908         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1909         * Scripts/webkitpy/layout_tests/port/test.py:
1910         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1911
1912 2011-03-23  Leandro Gracia Gil  <leandrogracia@chromium.org>
1913
1914         Reviewed by Darin Adler.
1915
1916         Media Stream API: fix the order of the options in build-webkit.
1917         https://bugs.webkit.org/show_bug.cgi?id=56949
1918
1919         Fix the order of the options in build-webkit.
1920
1921         * Scripts/build-webkit:
1922
1923 2011-03-23  Adam Klein  <adamk@chromium.org>
1924
1925         Reviewed by Mihai Parparita.
1926
1927         Add an option to new-run-webkit-httpd to allow overriding the location of LayoutTests directory
1928         https://bugs.webkit.org/show_bug.cgi?id=56884
1929
1930         This option will be utilized by Chromium's ui_tests to allow
1931         referencing js-test-resources from a layout test over HTTP.
1932
1933         * Scripts/new-run-webkit-httpd:
1934         Added --layout_tests_dir option.
1935         * Scripts/webkitpy/layout_tests/port/http_server.py:
1936         Plumbed through as layout_tests_dir param.
1937
1938 2011-03-23  Dirk Pranke  <dpranke@chromium.org>
1939
1940         Reviewed by Mihai Parparita.
1941
1942         new-run-webkit-tests: run tests in ascending alphabetical order per
1943         dir. This is a second attempt at the fix; the first attempt, in 
1944         r81597, broke the behavior on the old-inline and old-threads
1945         worker models.
1946
1947         https://bugs.webkit.org/show_bug.cgi?id=56760
1948
1949         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1950         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1951         * Scripts/webkitpy/layout_tests/port/test.py:
1952         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1953
1954 2011-03-23  Mario Sanchez Prada  <msanchez@igalia.com>
1955
1956         Reviewed by Martin Robinson.
1957
1958         [GTK] GTK's DRT to ouput detail's string for the 'property-change' signal
1959         https://bugs.webkit.org/show_bug.cgi?id=56953
1960
1961         Print the string for the detail of 'property-change' signal.
1962
1963         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
1964         (axObjectEventListener): Print the detail string.
1965
1966 2011-03-23  Yury Semikhatsky  <yurys@chromium.org>
1967
1968         Reviewed by Pavel Feldman.
1969
1970         [V8] Web Inspector: compile DebuggerScript.js into DebuggerScriptSource.h
1971         https://bugs.webkit.org/show_bug.cgi?id=56843
1972
1973         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1974         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1975
1976 2011-03-22  Eric Seidel  <eric@webkit.org>
1977
1978         Reviewed by Adam Barth.
1979
1980         Teach update-webkit about gyp
1981         https://bugs.webkit.org/show_bug.cgi?id=56881
1982
1983         This makes it possible for someone who builds from Xcode
1984         to just run update-webkit --gyp and have the project files
1985         generated after update automatically.
1986
1987         I also added a stand-alone "generate-project-files" script
1988         wrapping Source/gyp/configure.  This makes running gyp simpler
1989         since most people will not have gyp or Source/gyp in their path.
1990
1991         * Scripts/build-webkit:
1992         * Scripts/generate-project-files: Added.
1993         * Scripts/update-webkit:
1994
1995 2011-03-22  Anton D'Auria  <adauria@apple.com>
1996
1997         Reviewed by Alexey Proskuryakov.
1998
1999         Add +[WebApplicationCache getOriginsWithCache]
2000         https://bugs.webkit.org/show_bug.cgi?id=56722
2001
2002         * DumpRenderTree/LayoutTestController.cpp:
2003         (originsWithApplicationCacheCallback):
2004         (LayoutTestController::staticFunctions):
2005         * DumpRenderTree/LayoutTestController.h:
2006         * DumpRenderTree/chromium/LayoutTestController.cpp: Added stub.
2007         (LayoutTestController::originsWithApplicationCache):
2008         * DumpRenderTree/chromium/LayoutTestController.h:
2009         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added stub.
2010         (LayoutTestController::originsWithApplicationCache):
2011         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Pass array of origin's database identifiers.
2012         (originsArrayToJS): Helper function for converting array of WebSecurityOrigins to a JS array of origin identifiers.
2013         (LayoutTestController::originsWithApplicationCache):
2014         (LayoutTestController::originsWithLocalStorage):
2015         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added stub.
2016         (LayoutTestController::originsWithApplicationCache):
2017         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2018         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Added stub.
2019         (LayoutTestController::originsWithApplicationCache):
2020         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Added stub.
2021         (LayoutTestController::originsWithApplicationCache):
2022
2023 2011-03-22  Eric Seidel  <eric@webkit.org>
2024
2025         Reviewed by Adam Barth.
2026
2027         Add support to build-webkit for building with gyp-generated project files
2028         https://bugs.webkit.org/show_bug.cgi?id=56877
2029
2030         build-webkit is a cesspool.  This change just hacks in --gyp support for Mac.
2031         Eventually we'll want to support gyp-generated projects in a more general manner.
2032
2033         * Scripts/build-webkit:
2034
2035 2011-03-22  David Kilzer  <ddkilzer@apple.com>
2036
2037         <http://webkit.org/b/56781> Add --dsym switch to enable dsym generation when building with Xcode
2038
2039         Reviewed by Joseph Pecoraro.
2040
2041         * Scripts/build-webkit: Updated usage statement to include
2042         --dsym.
2043         * Scripts/webkitdirs.pm: Added $generateDsym variable.
2044         (generateDsym): Added. Call determineGenerateDsym() and
2045         return $generateDsym.
2046         (determineGenerateDsym): Added.  Parse @ARGV for --dsym and set
2047         $generateDsym.
2048         (argumentsForXcode): Added.  Returns additional arguments for
2049         xcodebuild based on command-line switches.
2050         (XcodeOptions): Updated to include argumentsForXcode() in the
2051         array returned.
2052
2053 2011-03-22  Adam Roben  <aroben@apple.com>
2054
2055         Make Leopard Debug bots and Windows XP Debug (Tests) core builders
2056
2057         These bots are consistently green again.
2058
2059         Fixes <http://webkit.org/b/56830> Leopard Debug bots and Windows XP Debug (Tests) should be
2060         core builders
2061
2062         Rubber-stamped by Antti Koivisto.
2063
2064         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2065         (BuildBot.__init__): Loosened the regexps for Leopard and Windows.
2066
2067         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2068         (BuildBotTest.test_builder_name_regexps): Updated expectations.
2069
2070 2011-03-21  Sheriff Bot  <webkit.review.bot@gmail.com>
2071
2072         Unreviewed, rolling out r81597.
2073         http://trac.webkit.org/changeset/81597
2074         https://bugs.webkit.org/show_bug.cgi?id=56801
2075
2076         Change results in lots of unexpected flaky on the dashboard.
2077         (Requested by pfeldman on #webkit).
2078
2079         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2080         * Scripts/webkitpy/layout_tests/port/test.py:
2081         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2082
2083 2011-03-21  Sam Weinig  <sam@webkit.org>
2084
2085         Fix failing tests on the WebKit2 bots.
2086
2087         * WebKitTestRunner/TestController.cpp:
2088         (WTR::TestController::resetStateToConsistentValues):
2089
2090 2011-03-21  Daniel Sievers  <sievers@google.com>
2091
2092         Reviewed by Simon Fraser.
2093
2094         [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
2095         https://bugs.webkit.org/show_bug.cgi?id=56139
2096
2097         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2098         (main):
2099         * DumpRenderTree/chromium/LayoutTestController.cpp:
2100         (LayoutTestController::LayoutTestController):
2101         (LayoutTestController::layerTreeAsText):
2102         * DumpRenderTree/chromium/LayoutTestController.h:
2103         (LayoutTestController::setShowDebugLayerTree):
2104         * DumpRenderTree/chromium/TestShell.cpp:
2105         (TestShell::runFileTest):
2106         (TestShell::dump):
2107         * DumpRenderTree/chromium/TestShell.h:
2108         (TestParams::TestParams):
2109
2110 2011-03-21  Adam Roben  <aroben@apple.com>
2111
2112         Try again to get buildbot to show run-javascriptcore-tests's actual.html as an HTML file
2113
2114         Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
2115         output as plain text
2116
2117         Reviewed by David Kilzer.
2118
2119         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2120         (RunJavaScriptCoreTests): List actual.html as one of our log files so it will get uploaded
2121         to the master.
2122         (RunJavaScriptCoreTests.commandComplete): Reading the actual.html file here won't work,
2123         since we're running on the build master, not the slave. Instead, turn the raw source of
2124         actual.html which the build slave uploaded into an HTML log.
2125
2126 2011-03-21  Dirk Pranke  <dpranke@chromium.org>
2127
2128         Reviewed by Mihai Parparita.
2129
2130         new-run-webkit-tests: run tests in ascending alphabetical order per dir
2131         https://bugs.webkit.org/show_bug.cgi?id=56760
2132
2133         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2134         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2135         * Scripts/webkitpy/layout_tests/port/test.py:
2136
2137 2011-03-21  Leandro Gracia Gil  <leandrogracia@chromium.org>
2138
2139         Reviewed by Steve Block.
2140
2141         Media Stream API patch 0: adding compilation guards.
2142         https://bugs.webkit.org/show_bug.cgi?id=56458
2143
2144         Adding options to enable the media stream API feature in Chromium.
2145
2146         * Scripts/build-webkit:
2147
2148 2011-03-21  Qi Zhang  <qi.2.zhang@nokia.com>
2149
2150         Reviewed by Laszlo Gombos.
2151
2152         [Qt] Add a command line option to capture stdout and stderr for DumpRenderTree
2153         https://bugs.webkit.org/show_bug.cgi?id=56323
2154
2155         Using freopen to redirect STDOUT and STDERR when DumpRenderTree command line provide 
2156         "--stdout" or "--stderr" option.
2157
2158         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2159         (WebCore::DumpRenderTree::~DumpRenderTree):
2160         (WebCore::DumpRenderTree::processArgsLine):
2161         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
2162         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2163         (WebCore::DumpRenderTree::setRedirectOutputFileName):
2164         (WebCore::DumpRenderTree::setRedirectErrorFileName):
2165         * DumpRenderTree/qt/main.cpp:
2166         (isOption):
2167         (takeOptionValue):
2168         (printUsage):
2169         (main):
2170
2171 2011-03-21  Adam Roben  <aroben@apple.com>
2172
2173         Fix exceptions on the buildbot due to my last change
2174
2175         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2176         (RunJavaScriptCoreTests.commandComplete): Catch exceptions due to actual.html not existing.
2177
2178 2011-03-21  Adam Roben  <aroben@apple.com>
2179
2180         Teach buildbot to treat run-javascriptcore-tests's actual.html as an HTML file
2181
2182         Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
2183         output as plain text
2184
2185         Reviewed by Darin Adler.
2186
2187         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2188         (RunJavaScriptCoreTests): Removed the logfiles variable, which can only handle plaintext
2189         logs.
2190         (RunJavaScriptCoreTests.commandComplete): Use the addHTMLLog method to upload actual.html to
2191         the build master. This will correctly treat it as HTML.
2192
2193 2011-03-20  Bill Budge  <bbudge@chromium.org>
2194
2195         Reviewed by Adam Barth.
2196
2197         Rename ThreadSafeShared to ThreadSafeRefCounted
2198         https://bugs.webkit.org/show_bug.cgi?id=56714
2199
2200         No new tests. Exposes no new functionality.
2201
2202         * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeRefCounted.h: Copied from DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h.
2203         * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h: Removed.
2204         * Scripts/do-webcore-rename:
2205
2206 2011-03-19  Anton D'Auria  <adauria@apple.com>
2207
2208         Reviewed by Dan Bernstein.
2209
2210         Add stub to LayoutTestControllerGtk.cpp to fix GTK build
2211         https://bugs.webkit.org/show_bug.cgi?id=56719
2212
2213         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Adding stub.
2214         (LayoutTestController::clearApplicationCacheForOrigin):
2215
2216 2011-03-19  Anton D'Auria  <adauria@apple.com>
2217
2218         Reviewed by Alexey Proskuryakov.
2219
2220         ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
2221         https://bugs.webkit.org/show_bug.cgi?id=56415
2222
2223         * DumpRenderTree/LayoutTestController.cpp:
2224         (clearApplicationCacheForOriginCallback):
2225         (LayoutTestController::staticFunctions):
2226         * DumpRenderTree/LayoutTestController.h:
2227         * DumpRenderTree/chromium/LayoutTestController.cpp: Adding stubs.
2228         (LayoutTestController::LayoutTestController):
2229         (LayoutTestController::clearAllApplicationCaches):
2230         (LayoutTestController::clearApplicationCacheForOrigin): 
2231         * DumpRenderTree/chromium/LayoutTestController.h:
2232         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Adding stub.
2233         (LayoutTestController::clearApplicationCacheForOrigin):
2234         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Adding stub.
2235         (LayoutTestController::clearApplicationCacheForOrigin):
2236         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2237         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Adding stub.
2238         (LayoutTestController::clearApplicationCacheForOrigin):
2239         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Adding stub.
2240         (LayoutTestController::clearApplicationCacheForOrigin):
2241
2242 2011-03-18  Dan Bernstein  <mitz@apple.com>
2243
2244         Revised build fix for r81135.
2245
2246         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
2247         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2248
2249 2011-03-18  Adam Roben  <aroben@apple.com>
2250
2251         Windows build fix
2252
2253         * WebKitTestRunner/config.h: Add a missing #endif.
2254
2255 2011-03-18  Andreas Kling  <kling@webkit.org>
2256
2257         Unbreak Qt build after r81494.
2258
2259         * WebKitTestRunner/qt/TestInvocationQt.cpp:
2260         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2261
2262 2011-03-18  Sam Weinig  <sam@webkit.org>
2263
2264         Fix windows build. This was really Adam Roben's fault. I swear!
2265
2266         * WebKitTestRunner/config.h:
2267
2268 2011-03-18  Sam Weinig  <sam@webkit.org>
2269
2270         Reviewed by Adam Roben.
2271
2272         Pixel tests don't work in WebKitTestRunner on Windows
2273         https://bugs.webkit.org/show_bug.cgi?id=56630
2274
2275         Cross-platformize (Mac and Windows CG) the pixel dumping code in WebKitTestRunner to use WebKit2
2276         built-in snapshotting instead of using the window server on the Mac.
2277
2278         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2279         (WTR::InjectedBundle::InjectedBundle):
2280         (WTR::InjectedBundle::didReceiveMessage):
2281         (WTR::InjectedBundle::beginTesting):
2282         (WTR::InjectedBundle::done):
2283         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2284         (WTR::InjectedBundle::setPixelResult):
2285         (WTR::InjectedBundle::shouldDumpPixels):
2286         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2287         (WTR::InjectedBundlePage::dump):
2288         Take the snapshot in the bundle and send it to the UIProcess for dumping.
2289
2290         * WebKitTestRunner/TestInvocation.cpp:
2291         (WTR::TestInvocation::invoke):
2292         (WTR::TestInvocation::dump):
2293         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2294         * WebKitTestRunner/TestInvocation.h:
2295         * WebKitTestRunner/cg: Added.
2296         * WebKitTestRunner/cg/TestInvocationCG.cpp: Copied from WebKitTestRunner/mac/TestInvocationMac.mm.
2297         (WTR::createCGContextFromImage):
2298         (WTR::computeMD5HashStringForContext):
2299         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2300         * WebKitTestRunner/mac/TestInvocationMac.mm: Removed.
2301         Making pixel dumping code shared for CG ports. Also use the WTF/MD5 instead of platform specific code.
2302
2303         * WebKitTestRunner/win/TestInvocationWin.cpp:
2304         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2305         Keep stub for Cairo build.
2306
2307         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Added.
2308         Add CG configuration.
2309
2310         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2311         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2312         Add new files.
2313
2314 2011-03-18  Adam Roben  <aroben@apple.com>
2315
2316         Don't allow Leaks Viewer's vertical scrollbar to cover up long function names
2317
2318         Rubber-stamped by Simon Fraser.
2319
2320         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
2321         (.data-grid .data-container): Use overflow-y:auto instead of the Inspector's default
2322         overflow-y:overlay so that the scrollbar doesn't overlay the content.
2323
2324 2011-03-18  Adam Roben  <aroben@apple.com>
2325
2326         Don't ellipsize long or indented function names in Leaks Viewer
2327
2328         Fixes <http://webkit.org/b/56037> Leaks viewer needs horizontal
2329         scrollbar
2330
2331         Reviewed by Simon Fraser.
2332
2333         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
2334         (.data-grid .data-container):
2335         (.data-grid td > div, .data-grid th > div):
2336         Allow the contents to extend to the right.
2337
2338 2011-03-18  Adam Roben  <aroben@apple.com>
2339
2340         Fix some leaks in DRT seen on the leaks bot
2341
2342         Fixes <http://webkit.org/b/56638> addURLToRedirectCallback and
2343         setWillSendRequestClearHeaderCallback in DRT are leaky
2344
2345         Reviewed by Alexey Proskuryakov.
2346
2347         * DumpRenderTree/ForwardingHeaders/wtf/OwnArrayPtr.h: Added.
2348
2349         * DumpRenderTree/LayoutTestController.cpp:
2350         (addURLToRedirectCallback):
2351         (setWillSendRequestClearHeaderCallback):
2352         Use OwnArrayPtr to cause the strings to be deleted.
2353
2354 2011-03-18  Adam Roben  <aroben@apple.com>
2355
2356         Fix a NSURLCredential leak seen on the leaks bot
2357
2358         Fixes <http://webkit.org/b/56637> -[SynchronousLoader
2359         connection:didReceiveAuthenticationChallenge:] is leaky
2360
2361         Reviewed by John Sullivan.
2362
2363         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2364         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]): Use a RetainPtr to
2365         cause the NSURLCredential to be released.
2366
2367 2011-03-18  John Knottenbelt  <jknotten@chromium.org>
2368
2369         Unreviewed.
2370
2371         Remove unnecessary brackets around my email address.
2372
2373         * Scripts/webkitpy/common/config/committers.py:
2374
2375 2011-03-18  Adam Roben  <aroben@apple.com>
2376         
2377         Remove some files I accidentally added in r81454
2378
2379         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Removed.
2380         * WebKitTestRunner/cg/TestInvocationCG.cpp: Removed.
2381
2382 2011-03-18  Adam Roben  <aroben@apple.com>
2383
2384         Ignore an NSNumberFormatter leak on SnowLeopard
2385
2386         * Scripts/old-run-webkit-tests:
2387         (countAndPrintLeaks): Ignore leaks in -[NSNumberFormatter
2388         getObjectValue:forString:errorDescription:].
2389
2390 2011-03-18  Adam Roben  <aroben@apple.com>
2391
2392         Fix a leak beneath LayoutTestController::authenticateSession seen on the bots
2393
2394         Rubber-stamped by Mark Rowe.
2395
2396         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2397         (LayoutTestController::authenticateSession): Use a RetainPtr to cause the NSURLRequest to be
2398         released.
2399
2400 2011-03-17  Adam Roben  <aroben@apple.com>
2401
2402         Address a review comment I missed in r81445
2403
2404         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
2405         (LeaksParserWorker.prototype._parseLeaks): Anchor the RegExp used to find the number of
2406         leaked bytes to speed up searching on long lines.
2407
2408 2011-03-17  Adam Roben  <aroben@apple.com>
2409
2410         Mark leaky builds orange, even if all regression tests passed
2411
2412         Fixes <http://webkit.org/b/56609> SnowLeopard Intel Leaks bot appears green on
2413         build.webkit.org when all tests pass even though there are still leaks
2414
2415         Reviewed by Dan Bernstein.
2416
2417         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2418         (RunWebKitLeakTests): Set the warnOnWarnings property to True so that the entire build will
2419         be marked orange if this build step generates warnings.
2420
2421 2011-03-17  Adam Roben  <aroben@apple.com>
2422
2423         Allow values in Leaks Viewer to be shown as percentages
2424
2425         Double-clicking on a column will toggle between showing percentages and showing real values.
2426
2427         Fixes <http://webkit.org/b/56628> Would like to view values as percentages of the total
2428         number of leaked bytes in Leaks Viewer
2429
2430         Reviewed by Joe Pecoraro.
2431
2432         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
2433         (LeaksParserWorker.prototype._incorporateLeaks): Calculate the (never-shown) top-level
2434         node's totalTime, which is used in calculating percentages.
2435
2436         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
2437         (monkeyPatchInspectorObjects): Only format values as bytes if we aren't supposed to be
2438         showing them as percentages.
2439
2440 2011-03-17  Adam Roben  <aroben@apple.com>
2441
2442         Show the number of leaked bytes, not just leaked allocations, in Leaks Viewer
2443
2444         The Self and Total columns now report the number of leaked bytes. The new Calls column shows
2445         the number of leaked allocations. And the new Average column shows the average number of
2446         leaked bytes per call.
2447
2448         Fixes <http://webkit.org/b/56344> Leaks Viewer should show how many bytes were leaked, not
2449         just how many allocations
2450
2451         Reviewed by Joe Pecoraro.
2452
2453         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
2454         (LeaksParserWorker.prototype._parseLeaks): Parse the number of leaked bytes from the "Leak:"
2455         line and store it with the leak stack.
2456         (LeaksParserWorker.prototype._createNode): Initialize the averageTime and numberOfCalls
2457         properties.
2458         (LeaksParserWorker.prototype._incorporateLeaks): Updated to get the stack from the .stack
2459         property, and changed to store the number of leaked bytes in .selfTime/.totalTime.
2460         .numberOfCalls now holds the number of leaked allocations.
2461
2462         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
2463         (Preferences): Set samplingCPUProfiler to false so that the Average and Calls columns will
2464         appear.
2465         (monkeyPatchInspectorObjects): Format the values as bytes.
2466
2467 2011-03-17  Adam Roben  <aroben@apple.com>
2468
2469         Make Leaks Viewer able to count leaks in builds that didn't fail any regression tests
2470
2471         Fixes <http://webkit.org/b/56626> Leaks Viewer omits recent builds which didn't fail any
2472         regression tests
2473
2474         Reviewed by James Robinson.
2475
2476         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
2477         (RecentBuildsLoader.prototype.start): Get the number of leaks out of the "text" array, which
2478         is always populated, even when all regression tests pass.
2479
2480 2011-03-10  Hayato Ito  <hayato@chromium.org>
2481
2482         Reviewed by Tony Chang.
2483
2484         Add a check logic for reftests in case that a reftest is marked AS REBASELINE.
2485
2486         https://bugs.webkit.org/show_bug.cgi?id=56076
2487
2488         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2489
2490 2011-03-17  Adam Roben  <aroben@apple.com>
2491
2492         Skip a compositing-sensitive test when accelerated compositing is disabled
2493
2494         Reviewed by Sam Weinig.
2495
2496         * Scripts/old-run-webkit-tests: Skip media/media-document-audio-repaint.html when
2497         accelerated compositing is disabled.
2498
2499 2011-03-17  Adam Roben  <aroben@apple.com>
2500
2501         Start using PlatformSpecificScheduler for the Mac builders
2502
2503         The current set of file/directory patterns should work for Mac builders. We may discover
2504         that there are more files and directories we can exclude from the Mac builds, but they can
2505         be added later.
2506
2507         Fixes <http://webkit.org/b/56593> Mac builders do lots of unnecessary builds
2508
2509         Reviewed by Mark Rowe.
2510
2511         * BuildSlaveSupport/build.webkit.org-config/config.json: Moved the Mac builders into two
2512         PlatformSpecificSchedulers: one for Leopard, and one for SnowLeopard.
2513
2514         * Scripts/webkitpy/common/config/build.py:
2515         (_should_file_trigger_build): Allow "mac-leopard" and "mac-snowleopard" platforms, and
2516         cleaned up patterns a little bit.
2517
2518         * Scripts/webkitpy/common/config/build_unittest.py:
2519         (ShouldBuildTest): Fixed some expected results.
2520         (ShouldBuildTest.test_should_build): Start testing "mac-leopard" and "mac-snowleopard"
2521         platforms.
2522
2523 2011-03-17  Jeff Miller  <jeffm@apple.com>
2524
2525         Use a consistent set of file patterns in the svn:ignore property for all .xcodeproj directories, specifically:
2526         
2527         *.mode*
2528         *.pbxuser
2529         *.perspective*
2530         project.xcworkspace
2531         xcuserdata
2532
2533         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
2534         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
2535         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
2536         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
2537         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
2538
2539 2011-03-17  Adam Roben  <aroben@apple.com>
2540
2541         Make old-run-webkit-tests pick up mac-wk2 results when running in WebKit2 mode on Windows
2542
2543         Fixes <http://webkit.org/b/56563> Running WebKit2 tests on Windows should use results from
2544         mac-wk2
2545
2546         Reviewed by Anders Carlsson.
2547
2548         * Scripts/old-run-webkit-tests:
2549         (expectedDirectoryForTest): Clean up the code to search in extra Mac platform result
2550         directories on Windows. Add mac-wk2 to the set of extra platforms we look in on Windows when
2551         we're running in WebKit2 mode.
2552
2553 2011-03-17  Mikhail Naganov  <mnaganov@chromium.org>
2554
2555         Reviewed by Yury Semikhatsky.
2556
2557         Web Inspector: Clean up Inspector strings.
2558         https://bugs.webkit.org/show_bug.cgi?id=56557
2559
2560         Modify the script to deal correctly with "\xNN" escapes, and to
2561         check strings in Chromium's DevTools.js.
2562
2563         * Scripts/check-inspector-strings:
2564
2565 2011-03-17  Keith Kyzivat  <keith.kyzivat@nokia.com>
2566
2567         Reviewed by Benjamin Poulain.
2568
2569         Update autoinstall to install mechanize 0.2.4
2570         https://bugs.webkit.org/show_bug.cgi?id=56499
2571
2572         Newer versions of mechanize support HTTPS proxies, which is necessary
2573         for people using webkit-patch behind firewalls.
2574
2575         * Scripts/webkitpy/common/system/autoinstall.py:
2576         * Scripts/webkitpy/thirdparty/__init__.py:
2577
2578 2011-03-16  Sam Weinig  <sam@webkit.org>
2579
2580         Reviewed by Adam Roben.
2581
2582         REGRESSION (r81084): media/invalid-media-url-crash.html and editing/execCommand/indent-paragraphs.html failing on WebKit2
2583         https://bugs.webkit.org/show_bug.cgi?id=56541
2584
2585         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2586         (WTR::InjectedBundlePage::willSendRequestForFrame):
2587         Check for an empty host in addition to a null host.  This bug was introduced
2588         when porting off of the KURL code and onto the WKURLRef version.
2589
2590 2011-03-16  Sam Weinig  <sam@webkit.org>
2591
2592         Reviewed by Adam Roben.
2593
2594         Add Lucas Forschler to the list of WebKit committers.
2595
2596         * Scripts/webkitpy/common/config/committers.py:
2597
2598 2011-03-16  Sam Weinig  <sam@webkit.org>
2599
2600         Reviewed upon and dictated through Adam Roben.
2601
2602         Escape crashing function names in results.html. This fixes an issue
2603         when a crash involves a type with templates.
2604
2605         * Scripts/old-run-webkit-tests:
2606
2607 2011-03-16  Daniel Sievers  <sievers@google.com>
2608
2609         Reviewed by James Robinson.
2610
2611         Add setting to always force compositing mode
2612         https://bugs.webkit.org/show_bug.cgi?id=56156
2613
2614         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2615         (main):
2616         * DumpRenderTree/chromium/TestShell.cpp:
2617         (TestShell::TestShell):
2618         (TestShell::resetWebSettings):
2619         * DumpRenderTree/chromium/TestShell.h:
2620         (TestShell::setForceCompositingMode):
2621         * DumpRenderTree/chromium/WebPreferences.cpp:
2622         (WebPreferences::reset):
2623         (WebPreferences::applyTo):
2624         * DumpRenderTree/chromium/WebPreferences.h:
2625
2626 2011-03-15  Hayato Ito  <hayato@chromium.org>
2627
2628         Reviewed by Ojan Vafai.
2629
2630         Ignore files that will be used by reftests in old-run-webkit-tests.
2631
2632         https://bugs.webkit.org/show_bug.cgi?id=55936
2633
2634         * Scripts/old-run-webkit-tests:
2635
2636 2011-03-15  Felipe Oliveira da Silva Netto  <f.dachshund@gmail.com>
2637
2638         Reviewed by Adam Roben.
2639
2640         Function relativeScriptsDir doesn't return the correct relative
2641         Scripts directory.
2642
2643         * Scripts/webkitdirs.pm:
2644         (relativeScriptsDir): Ensure we use the directory that contains
2645         webkitdirs.pm, not the one that contains the original script that
2646         was invoked.
2647
2648 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
2649
2650         [wx] Build fixes for long linker commands on Win and method return error, plus a Mac
2651         fix to link against the Security framework after recent WebKitSystemInterface changes.
2652
2653         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2654         (LayoutTestController::originsWithLocalStorage):
2655         * wx/build/settings.py:
2656         * wx/build/waf_extensions.py:
2657
2658 2011-03-15  Sam Weinig  <sam@webkit.org>
2659
2660         Reviewed by Darin Adler.
2661
2662         Add script to convert a patch to a prettypatch and show in the default browser
2663         https://bugs.webkit.org/show_bug.cgi?id=56416
2664
2665         This can be used either like
2666             $ svn-create-patch | show-pretty-diff
2667         or
2668             $ show-pretty-diff patch.diff
2669
2670         * Scripts/show-pretty-diff: Added.
2671
2672 2011-03-15  Brian Weinstein  <bweinstein@apple.com>
2673
2674         Rubber-stamped by Adam Roben.
2675
2676         Adding myself as a reviewer.
2677
2678         * Scripts/webkitpy/common/config/committers.py:
2679
2680 2011-03-15  Anders Carlsson  <andersca@apple.com>
2681
2682         Try to fix the Windows build.
2683
2684         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp:
2685         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
2686
2687 2011-03-15  Anders Carlsson  <andersca@apple.com>
2688
2689         Reviewed by Sam Weinig.
2690
2691         Make sure that NP_Shutdown is always the last NPP function called
2692         https://bugs.webkit.org/show_bug.cgi?id=56391
2693
2694         Add a test that times out if an NP_Deallocate object is called after NP_Shutdown.
2695
2696         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2697         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2698         (PluginTest::PluginTest):
2699         (PluginTest::NP_Shutdown):
2700         (PluginTest::registerNPShutdownFunction):
2701         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2702         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp: Added.
2703         (NPDeallocateCalledBeforeNPShutdown::NPDeallocateCalledBeforeNPShutdown):
2704         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
2705         (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::hasProperty):
2706         (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::getProperty):
2707         (NPDeallocateCalledBeforeNPShutdown::NPP_New):
2708         (NPDeallocateCalledBeforeNPShutdown::NPP_GetValue):
2709         (NPDeallocateCalledBeforeNPShutdown::shutdown):
2710         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2711         (NP_Shutdown):
2712         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2713         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2714         * GNUmakefile.am:
2715
2716 2011-03-15  Ilya Sherman  <isherman@chromium.org>
2717
2718         Reviewed by Tony Chang.
2719
2720         Autofilled form elements are assigned fixed background color but not text color
2721         https://bugs.webkit.org/show_bug.cgi?id=48382
2722
2723         * DumpRenderTree/LayoutTestController.cpp:
2724         (setAutofilledCallback): Added.
2725         (LayoutTestController::staticFunctions):
2726         * DumpRenderTree/LayoutTestController.h:
2727         * DumpRenderTree/chromium/LayoutTestController.cpp:
2728         (LayoutTestController::LayoutTestController):
2729         (LayoutTestController::setAutofilled): Added.
2730         * DumpRenderTree/chromium/LayoutTestController.h:
2731         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2732         (LayoutTestController::setAutofilled): Added.
2733         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2734         (LayoutTestController::setAutofilled): Added.
2735         (LayoutTestController::setValueForUser): Style tweak.
2736         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2737         (LayoutTestController::setAutofilled): Added (stub).
2738         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2739         (LayoutTestController::setAutofilled): Added (stub).
2740
2741 2011-03-15  Dan Bernstein  <mitz@apple.com>
2742
2743         Build fix after r81135.
2744
2745         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
2746
2747 2011-03-15  Dan Bernstein  <mitz@apple.com>
2748
2749         Build fix after r81135.
2750
2751         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
2752         * WebKitTestRunner/mac/TestControllerMac.mm:
2753         * WebKitTestRunner/mac/TestInvocationMac.mm:
2754         * WebKitTestRunner/mac/main.mm:
2755
2756 2011-03-15  Balazs Kelemen  <kbalazs@webkit.org>
2757
2758         Reviewed by Adam Barth.
2759
2760         REGRESSION(80977): breaks Qt ARMv7 Linux Release bot
2761         https://bugs.webkit.org/show_bug.cgi?id=56349
2762
2763         * QtTestBrowser/QtTestBrowser.pro: Link against fontconfig
2764         on platforms where we use it. Copied from DumpRenderTree.pro.
2765
2766 2011-03-15  Dan Bernstein  <mitz@apple.com>
2767
2768         Build fix after r81135.
2769
2770         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
2771         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
2772
2773 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
2774
2775         Reviewed by Darin Adler.
2776
2777         Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export
2778         info into the headers rather than in export symbol definition files, but disable it on 
2779         all platforms initially so we can deal with port build issues one port at a time.
2780         
2781         https://bugs.webkit.org/show_bug.cgi?id=27551
2782
2783         * DumpRenderTree/cg/ImageDiffCG.cpp:
2784         * DumpRenderTree/chromium/config.h:
2785         * DumpRenderTree/config.h:
2786         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2787         * TestWebKitAPI/TestWebKitAPIPrefix.h:
2788         * WebKitAPITest/HostWindow.cpp:
2789         * WebKitAPITest/TestsController.cpp:
2790         * WebKitAPITest/config.h: Added.
2791         * WebKitAPITest/main.cpp:
2792         * WebKitAPITest/tests/WebViewDestruction.cpp:
2793         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp:
2794         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2795         * WebKitTestRunner/InjectedBundle/GCController.cpp:
2796         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2797         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
2798         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2799         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2800         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2801         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
2802         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
2803         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp:
2804         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp:
2805         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
2806         * WebKitTestRunner/TestController.cpp:
2807         * WebKitTestRunner/TestInvocation.cpp:
2808         * WebKitTestRunner/config.h: Added.
2809         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2810         * WebKitTestRunner/qt/TestControllerQt.cpp:
2811         * WebKitTestRunner/qt/TestInvocationQt.cpp:
2812         * WebKitTestRunner/qt/main.cpp:
2813         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2814         * WebKitTestRunner/win/TestControllerWin.cpp:
2815         * WebKitTestRunner/win/TestInvocationWin.cpp:
2816         * WebKitTestRunner/win/main.cpp:
2817         * wx/build/settings.py:
2818
2819 2011-03-15  Hayato Ito  <hayato@chromium.org>
2820
2821         Reviewed by Shinichiro Hamaji.
2822
2823         [NRWT] Add support for reftests to new-run-webkit-tests.
2824
2825         https://bugs.webkit.org/show_bug.cgi?id=55457
2826
2827         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
2828         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2829         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
2830         * Scripts/webkitpy/layout_tests/port/base.py:
2831         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2832         * Scripts/webkitpy/layout_tests/port/test.py:
2833         * Scripts/webkitpy/layout_tests/port/test_files.py:
2834         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2835
2836 2011-03-15  Alejandro G. Castro  <alex@igalia.com>
2837
2838         Reviewed by Martin Robinson.
2839
2840         [GTK] Fix compilation warning after r80892
2841         https://bugs.webkit.org/show_bug.cgi?id=56302
2842
2843         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2844         (LayoutTestController::originsWithLocalStorage):
2845
2846 2011-03-15  Robert Hogan  <robert@webkit.org>
2847
2848         Reviewed by Adam Barth.
2849
2850         Document the qmakearg argument, and hint how to build webkit2 on Qt
2851         https://bugs.webkit.org/show_bug.cgi?id=56326
2852
2853         * Scripts/build-webkit: add --qmakearg to build-webkit --help
2854
2855 2011-03-15  Adam Roben  <aroben@apple.com>
2856
2857         Make Windows 7 Release (Tests) a core builder
2858
2859         We can probably make Windows XP Debug (Tests) a core builder, too, but we should probably
2860         give it a few more days of greenness first.
2861
2862         Fixes <http://webkit.org/b/55665> Windows 7 Release (Tests) should be a core builder
2863
2864         Reviewed by Sam Weinig.
2865
2866         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2867         (BuildBot): Added a regexp to match Windows 7 Release (Tests).
2868
2869         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2870         (BuildBotTest): Updated the list of builders to match the current list on build.webkit.org.
2871         Updated the core regexps to match the buildbot module. Updated the expected results to match
2872         the current set of core builders.
2873
2874 2011-03-14  Adam Roben  <aroben@apple.com>
2875
2876         Add forgotten file from r81116
2877
2878         * TestWebKitAPI/Configurations/TestWebKitAPICFNetwork.vsprops: Added.
2879
2880 2011-03-14  Sam Weinig  <sam@webkit.org>
2881
2882         Reviewed by Adam Roben.
2883
2884         about:blank fake responses don't get serialized when sent the UIProcess
2885         <rdar://problem/9108119>
2886         https://bugs.webkit.org/show_bug.cgi?id=56357
2887
2888         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp: Added.
2889         (TestWebKitAPI::decidePolicyForResponse):
2890         (TestWebKitAPI::TEST):
2891         Add test that loads of about:blank have a response with a MIMEType of text/html.
2892
2893         * TestWebKitAPI/PlatformUtilities.h:
2894         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2895         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
2896         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2897         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
2898         Add helper to get the MIMEType from a WKURLResponse.
2899
2900         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2901         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2902         Add new files.
2903
2904 2011-03-14  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>
2905
2906         Reviewed by Kenneth Rohde Christiansen.
2907
2908         [Qt] Command-line options for QGLWidget and WebGL to QtTestBrowser
2909         https://bugs.webkit.org/show_bug.cgi?id=56006
2910
2911         * QtTestBrowser/launcherwindow.cpp:
2912         (LauncherWindow::initializeView):
2913         * QtTestBrowser/main.cpp:
2914         (LauncherApplication::handleUserOptions):
2915
2916 2011-03-14  James Kozianski  <koz@chromium.org>
2917
2918         Reviewed by Ojan Vafai.
2919
2920         Add method to make BuildBot return test outputs
2921         https://bugs.webkit.org/show_bug.cgi?id=54374
2922
2923         The Builder.latest_cached_build will be used by the new rebaseline
2924         script to determine the build to use baselines from.
2925
2926         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2927         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2928
2929 2011-03-14  Adam Roben  <aroben@apple.com>
2930
2931         Test that WKBundlePageCanHandleRequest returns true for empty document URLs
2932
2933         Reviewed by Sam Weinig.
2934
2935         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp: Added.
2936         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Store the result of the test.
2937         (TestWebKitAPI::setInjectedBundleClient): Hook up our callback.
2938         (TestWebKitAPI::TEST): Register "emptyscheme" as an empty document scheme, load a page to
2939         ensure the web process is initialized, then ask the bundle to run the test and assert that
2940         it succeeded.
2941
2942         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp: Added.
2943         (TestWebKitAPI::CanHandleRequestTest::CanHandleRequestTest): Just call up to the base class.
2944         (TestWebKitAPI::canHandleURL): Helper function to test whether WebKit2 claims to be able to
2945         handle a given URL.
2946         (TestWebKitAPI::runTest): Check that empty document URLs can be handled (and that an unknown
2947         URL type cannot be handled).
2948         (TestWebKitAPI::CanHandleRequestTest::didReceiveMessage): Run the test and return the
2949         result.
2950
2951         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2952         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2953         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
2954         Added new files to the project.
2955
2956 2011-03-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2957
2958         Unreviewed, rolling out r81094.
2959         http://trac.webkit.org/changeset/81094
2960         https://bugs.webkit.org/show_bug.cgi?id=56355
2961
2962         Broke the chromium DRT related build. (Requested by dave_levin
2963         on #webkit).
2964
2965         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2966         (main):
2967         * DumpRenderTree/chromium/LayoutTestController.cpp:
2968         (LayoutTestController::LayoutTestController):
2969         (LayoutTestController::layerTreeAsText):
2970         * DumpRenderTree/chromium/LayoutTestController.h:
2971         * DumpRenderTree/chromium/TestShell.cpp:
2972         (TestShell::runFileTest):
2973         (TestShell::dump):
2974         * DumpRenderTree/chromium/TestShell.h:
2975         (TestParams::TestParams):
2976
2977 2011-03-14  Daniel Sievers  <sievers@google.com>
2978
2979         Reviewed by Simon Fraser.
2980
2981         [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
2982         https://bugs.webkit.org/show_bug.cgi?id=56139
2983
2984         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2985         (main):
2986         * DumpRenderTree/chromium/LayoutTestController.cpp:
2987         (LayoutTestController::LayoutTestController):
2988         (LayoutTestController::layerTreeAsText):
2989         * DumpRenderTree/chromium/LayoutTestController.h:
2990         (LayoutTestController::setShowDebugLayerTree):
2991         * DumpRenderTree/chromium/TestShell.cpp:
2992         (TestShell::runFileTest):
2993         (TestShell::dump):
2994         * DumpRenderTree/chromium/TestShell.h:
2995         (TestParams::TestParams):
2996
2997 2011-03-14  Balazs Kelemen  <kbalazs@webkit.org>
2998
2999         Reviewed by Adam Roben.
3000
3001         [Qt][WK2]Unbreak InjectedBundle on Qt
3002         https://bugs.webkit.org/show_bug.cgi?id=54109
3003
3004         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3005         (WTR::InjectedBundlePage::willSendRequestForFrame): Use new WebKit2
3006         API's instead of KURL to analyze the URL.
3007         * WebKitTestRunner/StringFunctions.h:
3008         (WTR::adoptWK): Moved from InjectedBundlePage.cpp to make it available globally
3009         in the WebKitTestRunner project.
3010         (WTR::toWK): Use adoptWK.
3011         (WTR::operator<<): Added helper for printing a WKURL.
3012         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Do not link
3013         against WebCore.
3014
3015 2011-03-14  Balazs Kelemen  <kbalazs@webkit.org>
3016
3017         Reviewed by Kenneth Rohde Christiansen.
3018
3019         check-webkit-style falsely should not complain about WebKit2 API headers in the Shared directory
3020         https://bugs.webkit.org/show_bug.cgi?id=56321
3021
3022         * Scripts/webkitpy/style/checker.py: Add the patch "Source/WebKit2/Shared/API/c"
3023         to the list of exceptions for WebKit2 C API headers.
3024
3025 2011-03-14  Adam Roben  <aroben@apple.com>
3026
3027         Show the list of recent leaky builds in reverse chronological order
3028
3029         Previously they were being shown in a deterministic but surprising order based on
3030         lexicographically sorting the build offsets (-1, -10, -2, -3...).
3031
3032         Fixes <http://webkit.org/b/56342> Leaks Viewer shows recent builds in a strange order
3033
3034         Reviewed by Darin Adler.
3035
3036         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
3037         (RecentBuildsLoader.prototype.start): Sort the builds by revision before passing them to our
3038         callback.
3039
3040 2011-03-14  Adam Roben  <aroben@apple.com>
3041
3042         Show a list of up to 10 recent leaky builds when Leaks Viewer loads
3043
3044         Fixes <http://webkit.org/b/56043> Leaks Viewer should present a list of recent builds to
3045         analyze
3046
3047         Reviewed by David Kilzer and Joe Pecoraro.
3048
3049         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
3050         (#url-prompt): Made this a bit taller to make room for the list of builds.
3051
3052         (#recent-builds-loading-indicator):
3053         (#recent-builds-list):
3054         Added styles for the build list and loading indicator.
3055
3056         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
3057         (LeaksViewer.loaded): Pass the URL from the query through decodeURIComponent before loading
3058         it. This will unescape it.
3059         (LeaksViewer.urlPromptButtonClicked): Moved code from here to _urlChosenFromPrompt.
3060         (LeaksViewer._didLoadRecentBuilds): Added. Stores the builds and updates the prompt.
3061         (LeaksViewer._displayURLPrompt): Start loading the recent leaky builds.
3062         (LeaksViewer._updateURLPrompt): Create a list of the recent leaky builds and add them to the
3063         prompt UI.
3064         (LeaksViewer._urlChosenFromPrompt): Added. Code came from urlPromptButtonClicked. This is
3065         now also used when a recent build is clicked.
3066
3067         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js: Added.
3068         (RecentBuildsLoader): Store the callback.
3069         (RecentBuildsLoader.prototype.start): Load the N most recent builds from the specified
3070         builder. Find the revision number, leak count, and results URL for each one. Pass the
3071         resulting info to our callback.
3072
3073         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:
3074         (range): Added this helper function to return an array containing the integers [0, n).
3075
3076         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added
3077         RecentBuildsLoader.js and added text to the prompt UI to show the recent builds.
3078
3079 2011-03-14  Mark Rowe  <mrowe@apple.com>
3080
3081         Reviewed by Adam Roben.
3082
3083         Fix two memory leaks within LayoutTestController's storage support.
3084
3085         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3086         (LayoutTestController::originsWithLocalStorage): Don't leak the JSStringRef that is returned
3087         by JSStringCreateWithCFString.
3088         (LayoutTestController::deleteLocalStorageForOrigin): Don't leak the WebSecurityOrigin that we
3089         allocate.
3090
3091 2011-03-14  Mark Rowe  <mrowe@apple.com>
3092
3093         Reviewed by Oliver Hunt.
3094
3095         <http://webkit.org/b/56304> REGRESSION(r80892): 100,000+ leaks seen on the build bot
3096
3097         * DumpRenderTree/LayoutTestController.cpp:
3098         (LayoutTestController::staticFunctions): Remove duplicate entries.
3099
3100 2011-03-14  Alice Liu  <alice.liu@apple.com>
3101
3102         Reviewed by Dan Bernstein.
3103
3104         DumpRenderTree Perl Support fails to build with ARCHS="i386 x86_64"
3105
3106         * DumpRenderTree/mac/PerlSupport/Makefile:
3107         Add whitespace when joining "-arch" with the architectures passed in as arguments.
3108
3109 2011-03-14  Daniel Bates  <dbates@rim.com>
3110
3111         https://bugs.webkit.org/show_bug.cgi?id=55438
3112         Add double quotes around value of -DCMAKE_WINCE_SDK that I inadvertently did not add
3113         when landing changeset 81041 <http://trac.webkit.org/changeset/81041>.
3114
3115         * Scripts/build-webkit:
3116
3117 2011-03-14  Daniel Bates  <dbates@rim.com>
3118
3119         Reviewed by David Kilzer.
3120
3121         Cleanup: Separate port-specific implementation details from webkitdirs::buildCMakeProject()
3122         https://bugs.webkit.org/show_bug.cgi?id=55438
3123
3124         Separate out the EFL- and WinCE-specific logic from the port-independent logic in
3125         webkitdirs::buildCMakeProject(). Also, remove redundant code for generating the
3126         CMake arguments for feature defines.
3127
3128         * Scripts/build-webkit:
3129           - Added cMakeArgsFromFeatures() to convert the @features array to CMake arguments.
3130           - Modified EFL and WinCE-specific building logic to call buildCMakeProjectOrExit().
3131           - Sorted forward declarations.
3132           - Initialize $makeArgs with the empty string so as to simplify its use in string operations;
3133             Modified call sites as needed.
3134         * Scripts/webkitdirs.pm:
3135           - Added cleanCMakeGeneratedProject() to clean a CMake build.
3136           - Added buildCMakeGeneratedProject() to build using generated build system.
3137           - Added buildCMakeProjectOrExit() which is a facade for building a CMake project.
3138           - Added generateBuildSystemFromCMakeProject() to generate the build system from
3139             a CMake project.
3140           - Removed buildCMakeProject(). This functionality is in buildCMakeProjectOrExit().
3141
3142 2011-03-14  John Knottenbelt  <jknotten@chromium.org>
3143
3144         Reviewed by Steve Block.
3145
3146         Detach Geolocation from Frame when Page destroyed.
3147         https://bugs.webkit.org/show_bug.cgi?id=52877
3148
3149         Extend the layout test controller to expose the number of pending
3150         geolocation requests, so that we can test that the requests have
3151         been cancelled on page close.
3152
3153         * DumpRenderTree/LayoutTestController.cpp:
3154         (numberOfPendingGeolocationPermissionRequestsCallback):
3155         (LayoutTestController::staticFunctions):
3156         * DumpRenderTree/LayoutTestController.h:
3157         * DumpRenderTree/chromium/LayoutTestController.cpp:
3158         (LayoutTestController::LayoutTestController):
3159         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3160         * DumpRenderTree/chromium/LayoutTestController.h:
3161         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3162         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3163         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3164         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3165         * DumpRenderTree/mac/UIDelegate.h:
3166         * DumpRenderTree/mac/UIDelegate.mm:
3167         (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
3168         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3169         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3170         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3171         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3172         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3173         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3174         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3175
3176
3177 2011-03-14  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3178
3179         Unreviewed. Modify my email address in committers.py.
3180
3181         * Scripts/webkitpy/common/config/committers.py:
3182
3183 2011-03-13  Joe Wild  <joseph.wild@nokia.com>
3184
3185         Reviewed by Kenneth Rohde Christiansen.
3186
3187         [Qt] QtLauncher does not load the same set of fonts as the DRT
3188         https://bugs.webkit.org/show_bug.cgi?id=34959
3189
3190         This patch adds the option "-use-test-fonts" to the QtTestBrowser.
3191         When this option is used the webkit fonts are loaded the same
3192         as they are in DumpRenderTree.  This option can be used on
3193         QtTestBrowser and run-launcher.  It can only be used
3194         on Linux systems with FcInit and is configured as such.
3195
3196         * QtTestBrowser/launcherwindow.h:
3197         (WindowOptions::WindowOptions):
3198         * QtTestBrowser/main.cpp:
3199         (initWebKitTestFonts):
3200         (launcherMain):
3201         (LauncherApplication::handleUserOptions):
3202
3203 2011-03-12  Dan Bernstein  <mitz@apple.com>
3204
3205         Reviewed by Mark Rowe.
3206
3207         <rdar://problem/8995822> Build DumpRenderTree perl support only for the architectures
3208         DumpRenderTree is being built for.
3209
3210         * DumpRenderTree/mac/PerlSupport/Makefile:
3211
3212 2011-03-12  Dan Bernstein  <mitz@apple.com>
3213
3214         Suggested by Mark Rowe.
3215
3216         * DumpRenderTree/mac/Configurations/Base.xcconfig: Leave C++ exceptions enabled
3217         as they were before r80915.
3218
3219 2011-03-12  Anders Carlsson  <andersca@apple.com>
3220
3221         Reviewed by Sam Weinig.
3222
3223         Should be able to download a PDF to the Downloads folder
3224         https://bugs.webkit.org/show_bug.cgi?id=56256
3225
3226         * MiniBrowser/mac/BrowserWindowController.m:
3227         (-[BrowserWindowController awakeFromNib]):
3228         * WebKitTestRunner/TestController.cpp:
3229         (WTR::TestController::createOtherPage):
3230         (WTR::TestController::initialize):
3231         Update for API changes.
3232
3233 2011-03-11  Anton D'Auria  <adauria@apple.com>
3234
3235         Reviewed and landed by Brady Eidson.
3236
3237         https://bugs.webkit.org/show_bug.cgi?id=51878
3238         Add WebKit1 API to view and delete local storage
3239
3240         Added tests that write to LocalStorage, delete one origin, get list of origins with local storage, delete all origins.
3241
3242         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3243         * DumpRenderTree/LayoutTestController.cpp:
3244         (syncLocalStorageCallback):
3245         (observeStorageTrackerNotificationsCallback):
3246         (deleteAllLocalStorageCallback):
3247         (deleteLocalStorageForOriginCallback):
3248         (originsWithLocalStorageCallback):
3249         (LayoutTestController::staticFunctions):
3250         * DumpRenderTree/LayoutTestController.h:
3251         * DumpRenderTree/StorageTrackerDelegate.h: Added.
3252         * DumpRenderTree/StorageTrackerDelegate.mm: Added.
3253         (-[StorageTrackerDelegate init]):
3254         (-[StorageTrackerDelegate logNotifications:controller:]):
3255         (-[StorageTrackerDelegate originModified:]):
3256         (-[StorageTrackerDelegate dealloc]):
3257         (-[StorageTrackerDelegate setControllerToNotifyDone:]):
3258         * DumpRenderTree/chromium/LayoutTestController.cpp:
3259         (LayoutTestController::LayoutTestController):
3260         (LayoutTestController::deleteAllLocalStorage):
3261         (LayoutTestController::originsWithLocalStorage):
3262         (LayoutTestController::deleteLocalStorageForOrigin):
3263         (observeStorageTrackerNotifications):
3264         (syncLocalStorage):
3265         * DumpRenderTree/chromium/LayoutTestController.h:
3266         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3267         (LayoutTestController::originsWithLocalStorage):
3268         (LayoutTestController::deleteAllLocalStorage):
3269         (LayoutTestController::deleteLocalStorageForOrigin):
3270         (LayoutTestController::observeStorageTrackerNotifications):
3271         (LayoutTestController::syncLocalStorage):
3272         * DumpRenderTree/mac/DumpRenderTree.mm:
3273         (resetDefaultsToConsistentValues):
3274         (allocateGlobalControllers):
3275         (releaseGlobalControllers):
3276         * DumpRenderTree/mac/DumpRenderTreeMac.h:
3277         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3278         (LayoutTestController::syncLocalStorage):
3279         (LayoutTestController::observeStorageTrackerNotifications):
3280         (LayoutTestController::deleteAllLocalStorage):
3281         (LayoutTestController::originsWithLocalStorage):
3282         (LayoutTestController::deleteLocalStorageForOrigin):
3283         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3284         (LayoutTestController::originsWithLocalStorage):
3285         (LayoutTestController::deleteAllLocalStorage):
3286         (LayoutTestController::deleteLocalStorageForOrigin):
3287         (LayoutTestController::observeStorageTrackerNotifications):
3288         (LayoutTestController::syncLocalStorage):
3289         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3290         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3291         (LayoutTestController::clearAllApplicationCaches):
3292         (LayoutTestController::syncLocalStorage):
3293         (LayoutTestController::observeStorageTrackerNotifications):
3294         (LayoutTestController::clearAllDatabases):
3295         (LayoutTestController::deleteAllLocalStorage):
3296         (LayoutTestController::originsWithLocalStorage):
3297         (LayoutTestController::deleteLocalStorageForOrigin):
3298         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3299         (LayoutTestController::syncLocalStorage):
3300         (LayoutTestController::observeStorageTrackerNotifications):
3301         (LayoutTestController::clearAllDatabases):
3302         (LayoutTestController::deleteAllLocalStorage):
3303         (LayoutTestController::originsWithLocalStorage):
3304         (LayoutTestController::deleteLocalStorageForOrigin):
3305
3306 2011-03-11  Jessie Berlin  <jberlin@apple.com>
3307
3308         Reviewed by Adam Roben.
3309
3310         Crash calling WebContext::clearResourceCaches(InMemoryResourceCachesOnly) before the Web
3311         Process has finished launching.
3312         https://bugs.webkit.org/show_bug.cgi?id=56208
3313
3314         * TestWebKitAPI/Tests/WebKit2/SendingMessagesToTheWebProcessBeforeItIsValid.cpp: Added.
3315         (TestWebKitAPI::TEST):
3316         Test that calling WKContextClearResourceCaches works with both options when called before
3317         the Web Process is valid.
3318
3319         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3320         Add the new test.
3321         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3322         Ditto.
3323
3324 2011-03-11  Adam Roben  <aroben@apple.com>
3325
3326         Make it possible to view all leaks from a build at once in Leaks Viewer
3327
3328         You can now give Leaks Viewer the URL of a build results page (e.g.,
3329         <http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r80847%20(15493)/>), and it
3330         will load all the leaks files from that build.
3331
3332         Fixes <http://webkit.org/b/56030> Leaks Viewer: Would like to be able to look at all leaks
3333         files from a particular build at once, rather than one at a time
3334
3335         Reviewed by David Kilzer.
3336
3337         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksLoader.js: Added.
3338         (LeaksLoader): Initialize our properties.
3339         (LeaksLoader.prototype.start): If the URL ends in .txt, assume it's a single leaks file and
3340         load it. Otherwise assume it's a build results page URL and start fetching the leaks files
3341         from that page.
3342         (LeaksLoader.prototype._loadLeaksFiles): Tell our client how many leaks files we're loading
3343         so it can provide feedback. Then load each one and pass it to the client.
3344         (LeaksLoader.prototype._loadLeaksFromResultsPage): Load the HTML of the results page, parse
3345         it into a DOM, pull out all the links to leaks files, and load each one.
3346
3347         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParser.js: Added.
3348         (LeaksParser): Initialize our worker.
3349         (LeaksParser.prototype.addLeaksFile): Tell the worker about the leaks file's contents.
3350
3351         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js: Added.
3352         This code mostly came from Worker.js.
3353         (LeaksParserWorker): Initialize our profile.
3354         (LeaksParserWorker.prototype.addLeaksFile): Parse the leaks file and incorporate it into our
3355         profile.
3356         (LeaksParserWorker.prototype._parseLeaks):
3357         (LeaksParserWorker.prototype._createNode):
3358         (LeaksParserWorker.prototype._incorporateLeaks):
3359         Moved these functions here from LeaksViewer. _incorporateLeaks is essentially just a renamed
3360         version of createProfile which adds to this.profile instead of making a new profile each
3361         time.
3362         (onmessage): Parse the file and send back the new profile.
3363
3364         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
3365         (#loading-indicator):
3366         (#spinner):
3367         (#loading-indicator-label):
3368         Tweaked styles to accomodate a longer label.
3369
3370         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
3371         (LeaksViewer.loaded): Set up a loader and parser.
3372
3373         (LeaksViewer.get filesLeftToParse):
3374         (LeaksViewer.set filesLeftToParse):
3375         Added these simple accessors.
3376
3377         (LeaksViewer._didCountLeaksFiles): Callback from LeaksLoader. Stores the count.
3378         (LeaksViewer._didLoadLeaksFile): Callback from LeaksLoader. Passes the file contents off to
3379         the parser.
3380         (LeaksViewer._didParseLeaksFile): Callback from LeaksParser. If all files have been parsed,
3381         tell the ProfilerAgent and mark that we're done loading. (Code came from the old
3382         _loadLeaksFromURL function).
3383         (LeaksViewer._loadLeaksFromURL): Now just calls through to the loader.
3384         (LeaksViewer._loadingIndicatorText): Added. Returns the text that should show up in the
3385         loading indicator, including the number of files being loaded.
3386         (LeaksViewer._loadingStatusChanged): Update the loading indicator's label, too.
3387         (LeaksViewer._updateLoadingIndicatorLabel): Added. Just updates the label!
3388         (LeaksViewer._updateTitle): Moved code to compute the "Loading" text to
3389         _loadingIndicatorText.
3390
3391         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js: Added.
3392         (getResource): Moved here from LeaksViewer.js.
3393
3394         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Worker.js: Subsumed by
3395         LeaksParserWorker.js.
3396
3397         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added new JS
3398         files, added a #loading-indicator-label element, and tweaked the prompt wording.
3399
3400 2011-03-11  Adam Roben  <aroben@apple.com>
3401
3402         Don't trigger a build when build.webkit.org's HTML files are modified
3403
3404         Fixes <http://webkit.org/b/56190> Windows bots shouldn't have built r80848/r80851, but did
3405
3406         Reviewed by Dan Bernstein.
3407
3408         * Scripts/webkitpy/common/config/build.py:
3409         (_should_file_trigger_build): Added build.webkit.org's public_html directory to the list of
3410         directories that shouldn't trigger builds. Re-sorted the list.
3411
3412         * Scripts/webkitpy/common/config/build_unittest.py:
3413         (ShouldBuildTest): Added a test to cover the above change.
3414
3415 2011-03-11  Adam Roben  <aroben@apple.com>
3416
3417         Roll out r80848
3418
3419         It was accidentally committed.
3420
3421         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
3422         (LeaksViewer._loadLeaksFromURL):
3423
3424 2011-03-11  Tony Chang  <tony@chromium.org>
3425
3426         Reviewed by Ojan Vafai.
3427
3428         kill hung lighttpd processes on the chromium win bot
3429         https://bugs.webkit.org/show_bug.cgi?id=56152
3430
3431         Sometimes this process doesn't exit and it holds on to
3432         a log file that we can't delete or copy, causing the tests
3433         to go red.
3434
3435         * BuildSlaveSupport/win/kill-old-processes:
3436
3437 2011-03-11  Ilya Sherman  <isherman@chromium.org>
3438
3439         Reviewed by Kent Tamura.
3440
3441         [Chromium] missing HTMLInputElement::setValueForUser() to tests
3442         https://bugs.webkit.org/show_bug.cgi?id=55854
3443
3444         * DumpRenderTree/chromium/LayoutTestController.cpp:
3445         (LayoutTestController::LayoutTestController):
3446         (LayoutTestController::setValueForUser): Added.
3447         * DumpRenderTree/chromium/LayoutTestController.h:
3448
3449 2011-03-10  Peter Kasting  <pkasting@google.com>
3450
3451         Reviewed by Dimitri Glazkov.
3452
3453         Clean up some gross code in TestShellWin.cpp.  No functional change.
3454         https://bugs.webkit.org/show_bug.cgi?id=56048
3455
3456         * DumpRenderTree/chromium/TestShellWin.cpp:
3457         (checkLayoutTestSystemDependencies):
3458
3459 2011-03-10  Keith Kyzivat  <keith.kyzivat@nokia.com>
3460
3461         Reviewed by Laszlo Gombos.
3462
3463         [Qt] Buildfix for platforms where X11 is not available (e.g. Symbian)
3464
3465         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3466         (WTR::activateFonts): Guard X11-specific code with Q_WS_X11.
3467
3468 2011-03-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3469
3470         Reviewed by Kenneth Rohde Christiansen.
3471
3472         [EFL] Make single backing store the default for EWebLauncher
3473         https://bugs.webkit.org/show_bug.cgi?id=55753
3474
3475         Set single backing store the default for EWebLauncher.
3476
3477         * EWebLauncher/main.c:
3478         (main):
3479
3480 2011-03-10  Adam Roben  <aroben@apple.com>
3481
3482         Ignore errors from files being held open when creating a test result archive
3483
3484         Fixes <http://webkit.org/b/55581> Test results don't get uploaded if test-result-archive
3485         fails to delete the results directory
3486
3487         Reviewed by Mark Rowe.
3488
3489         * BuildSlaveSupport/test-result-archive:
3490         (archiveTestResults): Ignore errno 2 when deleting the results directory, since it can be
3491         thrown when a process is holding a file open.
3492
3493 2011-03-10  Sheriff Bot  <webkit.review.bot@gmail.com>
3494
3495         Unreviewed, rolling out r80701.
3496         http://trac.webkit.org/changeset/80701
3497         https://bugs.webkit.org/show_bug.cgi?id=56126
3498
3499         fast/dom/Geolocation/window-close-crash.html fails on Snow
3500         Leopard release builds (Requested by mihaip on #webkit).
3501
3502         * DumpRenderTree/LayoutTestController.cpp:
3503         (LayoutTestController::staticFunctions):
3504         * DumpRenderTree/LayoutTestController.h:
3505         * DumpRenderTree/chromium/LayoutTestController.cpp:
3506         (LayoutTestController::LayoutTestController):
3507         * DumpRenderTree/chromium/LayoutTestController.h:
3508         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3509         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3510         * DumpRenderTree/mac/UIDelegate.h:
3511         * DumpRenderTree/mac/UIDelegate.mm:
3512         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3513         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3514         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3515         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3516
3517 2011-03-10  Philippe Normand  <pnormand@igalia.com>
3518
3519         Reviewed by Gustavo Noronha Silva.
3520
3521         [GTK] run-gtk-tests doesn't fail if a test crashes
3522         https://bugs.webkit.org/show_bug.cgi?id=56089
3523
3524         * Scripts/run-gtk-tests: gtester -k exits with a 0 exit status
3525         even if a test crashes. So run the tests individually and if a
3526         test fails remember its exit code so run-gtk-test fails too, if
3527         required.
3528
3529 2011-01-26  John Knottenbelt  <jknotten@chromium.org>
3530
3531         Reviewed by Dmitry Titov.
3532
3533         Detach Geolocation from Frame when Page destroyed.
3534         https://bugs.webkit.org/show_bug.cgi?id=52877
3535
3536         Extend the layout test controller to expose the number of pending
3537         geolocation requests, so that we can test that the requests have
3538         been cancelled on page close.
3539
3540         * DumpRenderTree/LayoutTestController.cpp:
3541         (numberOfPendingGeolocationPermissionRequestsCallback):
3542         (LayoutTestController::staticFunctions):
3543         * DumpRenderTree/LayoutTestController.h:
3544         * DumpRenderTree/chromium/LayoutTestController.cpp:
3545         (LayoutTestController::LayoutTestController):
3546         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3547         * DumpRenderTree/chromium/LayoutTestController.h:
3548         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3549         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3550         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3551         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3552         * DumpRenderTree/mac/UIDelegate.h:
3553         * DumpRenderTree/mac/UIDelegate.mm:
3554         (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
3555         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3556         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3557         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3558         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3559         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3560         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3561         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3562
3563
3564 2011-03-09  Adam Roben  <aroben@apple.com>
3565
3566         Hide Leaks Viewer's URL prompt by default
3567
3568         We will show it as needed. I think I left it visible by default by accident after doing some
3569         testing.
3570
3571         Fixes <http://webkit.org/b/56031> Leaks Viewer: URL prompt overlay shouldn't appear when a
3572         URL is passed as a query parameter, but does
3573
3574         Reviewed by Simon Fraser.
3575
3576         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:
3577
3578 2011-03-09  Adam Roben  <aroben@apple.com>
3579
3580         Don't use Element.classList or box-shadow in Leaks Viewer
3581
3582         They aren't supported by Safari 5. Luckily we have substitutes for them!
3583
3584         Fixes <http://webkit.org/b/56035> Leaks viewer doesn't work in Safari 5
3585
3586         Reviewed by Simon Fraser.
3587
3588         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
3589         (#url-prompt): Use -webkit-box-shadow instead of box-shadow.
3590
3591         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
3592         (LeaksViewer.urlPromptButtonClicked):
3593         (LeaksViewer._displayURLPrompt):
3594         (LeaksViewer._setLoadingIndicatorHidden):
3595         Use add/removeStyleClass (from utilities.js) instead of Element.classList.
3596
3597 2011-03-09  Adam Roben  <aroben@apple.com>
3598
3599         Add a link to the Leaks Viewer tool on the build.webkit.org homepage
3600
3601         Rubber-stamped by David Kilzer.
3602
3603         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
3604
3605 2011-03-09  Adam Roben  <aroben@apple.com>
3606
3607         Add a Leaks Viewer tool to build.webkit.org
3608
3609         This tool parses leaks from the files generated by the leaks bot and displays them in a
3610         view similar to the Web Inspector's Profiles pane (in fact, it uses the Web Inspector's
3611         code).
3612
3613         The URL of the leaks file can be entered in a prompt when the tools is first shown, or can
3614         be passed to the tool via the "url" query parameter.
3615
3616         Only one leaks file can be viewed at a time for now. Only the number of leaks, as opposed to
3617         the number of leaked bytes, is shown. And this tool has made apparent some bugs in the Web
3618         Inspector's Heavy profile view. But it's still pretty useful as-is.
3619
3620         Fixes <http://webkit.org/b/56028> Would like a Shark-like tool for viewing leaks from leak bots
3621
3622         Reviewed by Darin Adler.
3623
3624         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css: Added.
3625         (#url-prompt-container): This is the dark overlay that is shown behind the URL prompt.
3626         (#url-prompt): This is the prompt itself.
3627
3628         (#loading-indicator):
3629         (#loading-indicator > img):
3630         These show a spinner in the bottom-right when we're loading a leaks file.
3631
3632         (.percent-time-status-bar-item): Hide the Percent button since we never want to show leaks
3633         as percentages.
3634
3635         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js: Added.
3636         (LeaksViewer.loaded): Initialize ourselves and start loading the leaks file (or prompt for a
3637         URL if one wasn't given to us as a query parameter).
3638
3639         (LeaksViewer.get loading):
3640         (LeaksViewer.set loading):
3641         (LeaksViewer.get url):
3642         (LeaksViewer.set url):
3643         Pretty simple accessors.
3644
3645         (LeaksViewer.urlPromptButtonClicked): Start loading the URL from the prompt and hide the
3646         prompt.
3647         (LeaksViewer._displayURLPrompt): Show the prompt and focus the URL input.
3648         (LeaksViewer._loadLeaksFromURL): Start fetching the leaks file. When we've retrieved the
3649         file, hand it off to a Web Worker that will parse it into a fake "profile", then hand off
3650         the profile to the Web Inspector code once it's been created.
3651         (LeaksViewer._loadingStatusChanged): Update our loading indicator and title.
3652         (LeaksViewer._setLoadingIndicatorHidden): Simply hide or show the indicator.
3653         (LeaksViewer._updateTitle): Set our title based on our URL and loading status.
3654         (getResource): Helper function to fetch a resource via XHR and pass it to a callback.
3655
3656         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js: Added.
3657         (WebInspector.UIString): Just a simple implementation since this tool isn't localized.
3658         (ProfilerAgent.getProfile): Store the callback.
3659         (ProfilerAgent.profileReady): Call the callback.
3660         (monkeyPatchInspectorObjects): Fix up WebInspector.ProfileDataGridNode to show the self leak
3661         count and total leak counts as real values, not percentages or milliseconds.
3662
3663         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Worker.js: Added.
3664         (onmessage): Create a profile based on the leaks file and pass it back to our caller.
3665         (parseLeaks): Extract call stacks out of a leaks file.
3666         (createNode): Helper function to create a new empty profile node.
3667         (createProfile): Take the leak stacks and turn them into a fake "profile" for consumption by
3668         WebInspector.ProfileView.
3669
3670         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added.
3671
3672 2011-03-09  Dan Bernstein  <mitz@apple.com>
3673
3674         Reviewed by Adam Roben.
3675
3676         Combine multiple --ignore-tests values
3677         https://bugs.webkit.org/show_bug.cgi?id=56016
3678
3679         * Scripts/old-run-webkit-tests:
3680
3681 2011-03-08  Kenji Imasaki  <imasaki@chromium.org>
3682
3683         Reviewed by David Levin.
3684
3685         Adding myself to the committer file.
3686
3687         * Scripts/webkitpy/common/config/committers.py:
3688
3689 2011-03-08  Jessie Berlin  <jberlin@apple.com>
3690
3691         Rubber-stamped by Adam Roben.
3692
3693         Fix two leaks I introduced into the API tests.
3694
3695         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
3696         (TestWebKitAPI::TEST):
3697
3698 2011-03-08  Jessie Berlin  <jberlin@apple.com>
3699
3700         Reviewed by Anders Carlsson.
3701
3702         Crash in CFNetwork visiting google.com
3703         https://bugs.webkit.org/show_bug.cgi?id=55958
3704
3705         Add a test for not trying to copy a null CFURLResponse.
3706
3707         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp: Added.
3708         (TestWebKitAPI::TEST):
3709         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3710
3711 2011-03-08  Hayato Ito  <hayato@chromium.org>
3712
3713         Reviewed by Ojan Vafai.
3714
3715         [NRWT] Renamed a FailureWithType class to a ComparisonTestFailure class.
3716
3717         FailureWithType is a confusing naming because we have removed test_type/* classes in r79840.
3718
3719         https://bugs.webkit.org/show_bug.cgi?id=55450
3720
3721         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3722
3723 2011-03-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3724
3725         Reviewed by Martin Robinson.
3726
3727         [GTK] Add layoutTestController.setValueForUser() after r80412
3728         https://bugs.webkit.org/show_bug.cgi?id=55862
3729
3730         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3731         (LayoutTestController::setValueForUser): Implement setValueForUser()
3732
3733 2011-03-08  Patrick Gansterer  <paroga@webkit.org>
3734
3735         Reviewed by Adam Barth.
3736
3737         Add script_shell_command to WebKitPort
3738         https://bugs.webkit.org/show_bug.cgi?id=55925
3739
3740         Add a central place where we generate the shell command from the script name.
3741         This function will be used later to detect the correct script interpreter on Win32.
3742
3743         * Scripts/webkitpy/common/config/ports.py:
3744         * Scripts/webkitpy/layout_tests/port/base.py:
3745         * Scripts/webkitpy/tool/steps/abstractstep.py:
3746         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3747
3748 2011-03-07  Ojan Vafai  <ojan@chromium.org>
3749
3750         Reviewed by Adam Barth.
3751
3752         add webkit-patch attach-to-bug for posting to bugzilla from the commandline
3753         https://bugs.webkit.org/show_bug.cgi?id=55749
3754
3755         * Scripts/webkitpy/tool/commands/upload.py:
3756         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3757         * Scripts/webkitpy/tool/steps/__init__.py:
3758         * Scripts/webkitpy/tool/steps/attachtobug.py: Added.
3759         * Scripts/webkitpy/tool/steps/options.py:
3760
3761 2011-03-07  Daniel Cheng  <dcheng@chromium.org>
3762
3763         Reviewed by David Levin.
3764
3765         Add support for DataTransferItems
3766         https://bugs.webkit.org/show_bug.cgi?id=55115
3767
3768         Enable data transfer items in DRT.
3769
3770         * DumpRenderTree/chromium/TestShell.cpp:
3771         (TestShell::TestShell):
3772
3773 2011-03-06  Ojan Vafai  <ojan@chromium.org>
3774
3775         Reviewed by Tony Chang.
3776
3777         [test dashboard] pull treemap files
3778         https://bugs.webkit.org/show_bug.cgi?id=55852
3779
3780         * TestResultServer/handlers/dashboardhandler.py:
3781
3782 2011-03-03  Hayato Ito  <hayato@chromium.org>
3783
3784         Reviewed by Mihai Parparita.
3785
3786         [NRWT] Clear output image file used by DumpRenderTree to make sure the
3787         previous image should not be used in the ChromiumDriver.
3788
3789         Also make sure that output image from the ChromiumDriver should be ''
3790         (empty string) if a test crashes for consistency with the WebKitDriver
3791         implementation.
3792
3793         https://bugs.webkit.org/show_bug.cgi?id=55746
3794
3795         * Scripts/webkitpy/layout_tests/port/chromium.py:
3796
3797 2011-03-07  Zan Dobersek  <zandobersek@gmail.com>
3798
3799         Reviewed by Martin Robinson.
3800
3801         [Gtk] fast/js/navigator-language.html fails locally
3802         https://bugs.webkit.org/show_bug.cgi?id=55880
3803
3804         Add LANG variable to the clean environment when running
3805         old-run-webkit-tests script.
3806
3807         * Scripts/old-run-webkit-tests:
3808
3809 2011-03-07  Tony Chang  <tony@chromium.org>
3810
3811         Reviewed by Mihai Parparita.
3812
3813         [Chromium] Find .checksum files without .pngs and vice-versa
3814         https://bugs.webkit.org/show_bug.cgi?id=55236
3815
3816         * Scripts/find-mismatched-layout-test-results: Added. A script for finding
3817             mismatched results.
3818
3819 2011-03-07  Chris Fleizach  <cfleizach@apple.com>
3820
3821         Reviewed by Beth Dakin.
3822
3823         AX: WK1 needs to use the ScrollView attachment for AXScrollArea, WK2 should not use this element.
3824         https://bugs.webkit.org/show_bug.cgi?id=55706
3825
3826         The rootElement in DRT should point to the scroll view. In WK1, that will be the parent of the rootObject.
3827
3828         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3829         (AccessibilityController::focusedElement):
3830            Remove FIXME comment about caching the focusedElement. In fact, we shouldn't cache this 
3831            because it could change at any time.
3832         (AccessibilityController::rootElement):
3833
3834 2011-03-07  Sam Weinig  <sam@webkit.org>
3835
3836         Reviewed by Anders Carlsson.
3837
3838         Add unableToImplementPolicy callback for WebKit2 policy client
3839         <rdar://problem/9071902>
3840         https://bugs.webkit.org/show_bug.cgi?id=55884
3841
3842         * MiniBrowser/mac/BrowserWindowController.m:
3843         (-[BrowserWindowController awakeFromNib]):
3844         Update policy client initialization struct for new member.
3845
3846 2011-03-07  Sam Weinig  <sam@webkit.org>
3847
3848         Reviewed by Anders Carlsson.
3849
3850         Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
3851         https://bugs.webkit.org/show_bug.cgi?id=55827
3852
3853         * MiniBrowser/mac/BrowserWindowController.m:
3854         (decidePolicyForResponse):
3855         (-[BrowserWindowController awakeFromNib]):
3856         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3857         (TestWebKitAPI::decidePolicyForResponse):
3858         (TestWebKitAPI::TEST):
3859         Update tools for new name.
3860
3861 2011-03-06  Daniel Bates  <dbates@rim.com>
3862
3863         Reviewed by Eric Seidel and David Kilzer.
3864
3865         Fix misspelled word in build-webkit's checkForJavaSDK() and sort forward declarations
3866         https://bugs.webkit.org/show_bug.cgi?id=55503
3867
3868         Fix misspelled word "Dowloads" [sic] in the message printed to standard output
3869         in checkForJavaSDK().
3870
3871         Also, remove extraneous space in function prototype for unlinkZeroFiles.
3872
3873         * Scripts/build-webkit:
3874
3875 2011-03-05  Brian Weinstein  <bweinstein@apple.com>
3876
3877         Reviewed by Sam Weinig.
3878
3879         Fix Web Process crashes caused by https://bugs.webkit.org/show_bug.cgi?id=53919.
3880
3881         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3882         (WTR::InjectedBundlePage::willSendRequestForFrame): Retain the WKURLRequestRef returned
3883             by willSendRequestForFrame. The API expects a retained reference to the URL request.
3884
3885 2011-03-05  Ilya Sherman  <isherman@chromium.org>
3886
3887         Reviewed by Darin Adler.
3888
3889         HTMLInputElement::setValue() should schedule change event when the element is focused
3890         In service of https://code.google.com/p/chromium/issues/detail?id=42716
3891         https://bugs.webkit.org/show_bug.cgi?id=53160
3892
3893         * DumpRenderTree/LayoutTestController.cpp:
3894         (setValueForUserCallback):
3895         (LayoutTestController::staticFunctions):
3896         * DumpRenderTree/LayoutTestController.h:
3897         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3898         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
3899         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3900         (LayoutTestController::setValueForUser): Expose HTMLInputElement::setValueForUser() to tests
3901         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3902         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
3903         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3904         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
3905         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3906         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
3907
3908 2011-03-04  Mark Rowe  <mrowe@apple.com>
3909
3910         Reviewed by Alexey Proskuryakov.
3911
3912         <rdar://problem/9055252> DumpRenderTree is crashing with GuardMalloc
3913
3914         GuardMalloc does not expect the memory containing its malloc_zone_t to ever be read-only.
3915         
3916         * DumpRenderTree/mac/CheckedMalloc.cpp:
3917         (protectionOfRegion): Retrieve the protection flags for the VM region containing the given address.
3918         (makeLargeMallocFailSilently): Save the initial protection flags, temporarily make the region writeable,
3919         and then restore the initial protection flags when we're done.
3920
3921 2011-03-04  Evan Martin  <evan@chromium.org>
3922
3923         Reviewed by Tony Chang.
3924
3925         [gdb] pretty-print KURL in gdb
3926         https://bugs.webkit.org/show_bug.cgi?id=55788
3927
3928         * gdb/webkit.py: extend the pretty-printers to print WTF::CString
3929         and KURLGooglePrivate.  As always, "p/r" can be used to sidestep
3930         pretty-printing.
3931
3932 2011-03-03  Timothy Hatcher  <timothy@apple.com>
3933
3934         Update the tests that use WKPageRunJavaScriptInMainFrame use the WKSerializedScriptValueRef.
3935
3936         Reviewed by Darin Adler.
3937
3938         * TestWebKitAPI/JavaScriptTest.cpp:
3939         (TestWebKitAPI::javaScriptCallback):
3940         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
3941         (TestWebKitAPI::didRunJavaScript):
3942         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3943         (TestWebKitAPI::nullJavaScriptCallback):
3944         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
3945         (TestWebKitAPI::didRunJavaScript):
3946
3947 2011-03-03  Timothy Hatcher  <timothy@apple.com>
3948
3949         Make run-api-tests show failed if a test fails.
3950
3951         https://webkit.org/b/55725
3952
3953         Reviewed by Sam Weinig.
3954
3955         * Scripts/run-api-tests:
3956         (runTest): Remove "my" from the nested $result assignment so the
3957         check outside the condition sees the real result.
3958
3959 2011-03-02  MORITA Hajime  <morrita@google.com>
3960
3961         Reviewed by Kent Tamura.
3962
3963         [Chromium][DRT] WebTask should use webkit_support::TaskAdaptor
3964         https://bugs.webkit.org/show_bug.cgi?id=55434
3965
3966         Changed WebTask to be a subclass of webkit_support::TaskAdaptor
3967         and passed the object webkit_support::PostDelayedTask directly.
3968
3969         Note that the change keeps postTask() as is because it has a
3970         semantics taht webkit_support::PostDelayedTask() has; It jumps to
3971         the main thread.
3972
3973         * DumpRenderTree/chromium/Task.cpp:
3974         (postDelayedTask):
3975         * DumpRenderTree/chromium/Task.h:
3976         (WebTask::Run):
3977
3978 2011-03-03  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
3979
3980         Reviewed by Kenneth Rohde Christiansen.
3981
3982         [QT] Implement mock client-based geolocation for layout testing
3983         https://bugs.webkit.org/show_bug.cgi?id=54334
3984
3985         Implement testing for Client-Based geolocation for QtWebkit.
3986
3987         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3988         (WebCore::DumpRenderTree::DumpRenderTree):
3989         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3990         (LayoutTestController::reset):
3991         (LayoutTestController::setGeolocationPermission):
3992         (LayoutTestController::setMockGeolocationError):
3993         (LayoutTestController::setMockGeolocationPosition):
3994
3995 2011-03-03  Sheriff Bot  <webkit.review.bot@gmail.com>
3996
3997         Unreviewed, rolling out r80237.
3998         http://trac.webkit.org/changeset/80237
3999         https://bugs.webkit.org/show_bug.cgi?id=55714
4000
4001         Windows bots aren't ready to be core (Requested by aroben on
4002         #webkit).
4003
4004         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
4005         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
4006
4007 2011-03-03  Mihai Parparita  <mihaip@chromium.org>
4008
4009         Reviewed by Tony Chang.
4010
4011         NRWT: AttributeError: TestRunner2 instance has no attribute '_cancel_workers'
4012         https://bugs.webkit.org/show_bug.cgi?id=55694
4013         
4014         Fixes for interruptions in NRWT:
4015         - Make TestRunInterruptedException be pickleable correctly (the base
4016           Exception class defines a __reduce__ that does not include the reason)
4017         - Fix ordering of returned arguments from TestRunner2._run_tests
4018           (interrupted and keyboard_interrupted were reversed)
4019         - Fix cancel_workers callsites (was using old name).
4020         - In handle_exception re-raise actual exception instance that was thrown
4021
4022         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
4023         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
4024         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
4025         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
4026
4027 2011-03-03  Qi Zhang  <qi.2.zhang@nokia.com>
4028
4029         Unreviewed.
4030
4031         Adding myself as a committer.
4032
4033         * Scripts/webkitpy/common/config/committers.py:
4034
4035 2011-03-03  Tony Gentilcore  <tonyg@chromium.org>
4036
4037         Reviewed by Mihai Parparita.
4038
4039         Teach sheriffbot to answer whois commands
4040         https://bugs.webkit.org/show_bug.cgi?id=55687
4041
4042         * Scripts/webkitpy/tool/bot/irc_command.py:
4043         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
4044         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
4045
4046 2011-03-03  Victoria Kirst  <vrk@google.com>
4047
4048         Reviewed by Eric Carlson.
4049
4050         Enable media tests in chromium-gpu/test_expectations
4051         https://bugs.webkit.org/show_bug.cgi?id=53608
4052
4053         Add media folder to the list of GPU test paths.
4054
4055         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
4056
4057 2011-03-03  Adam Roben  <aroben@apple.com>
4058
4059         Work around a bug in KURL's parsing of Windows-style absolute file: URLs
4060
4061         Fixes <http://webkit.org/b/55674> Many tests fail in WebKit2 mode on Windows due to
4062         incorrect parsing of absolute Windows-style file: URLs
4063
4064         Reviewed by Tim Hatcher.
4065
4066         * WebKitTestRunner/TestInvocation.cpp:
4067         (WTR::createWKURL): Add a "localhost" host to file: URLs we create to work around
4068         <http://webkit.org/b/55683>.
4069
4070 2011-03-03  Tony Chang  <tony@chromium.org>
4071
4072         Reviewed by Dimitri Glazkov.
4073
4074         [chromium] Run kill-old-processes on the chromium-win bot too
4075         https://bugs.webkit.org/show_bug.cgi?id=55630
4076
4077         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4078         * BuildSlaveSupport/win/kill-old-processes: Add wdiff.exe to the kill list.
4079
4080 2011-03-03  Carlos Garcia Campos  <cgarcia@igalia.com>
4081
4082         Reviewed by Martin Robinson.
4083
4084         [GTK] DRT needs implementation of EventSender.scheduleAsynchronousClick
4085         https://bugs.webkit.org/show_bug.cgi?id=53960
4086
4087         * DumpRenderTree/gtk/EventSender.cpp:
4088         (sendClick):
4089         (scheduleAsynchronousClickCallback):
4090
4091 2011-03-03  Adam Roben  <aroben@apple.com>
4092
4093         Look for Windows-style paths when checking whether a test is an Inspector test
4094
4095         WTR part of <http://webkit.org/b/55672> <rdar://problem/9080867> All inspector tests time
4096         out or crash on Windows 7 Release (WebKit2 Tests)
4097
4098         Reviewed by Darin Adler.
4099
4100         * WebKitTestRunner/TestInvocation.cpp:
4101         (WTR::shouldOpenWebInspector): Also look for backslashes, since that's what we'll get on
4102         Windows.
4103
4104 2011-03-03  Adam Roben  <aroben@apple.com>
4105
4106         Make Windows 7 Release (Tests) a core builder
4107
4108         We can probably make Windows XP Debug (Tests) a core builder, too, but we should probably
4109         give it a few more days of greenness first.
4110
4111         Fixes <http://webkit.org/b/55665> Windows 7 Release (Tests) should be a core builder
4112
4113         Reviewed by Andreas Kling.
4114
4115         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
4116         (BuildBot): Added a regexp to match Windows 7 Release (Tests).
4117
4118         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
4119         (BuildBotTest): Updated the list of builders to match the current list on build.webkit.org.
4120         Updated the core regexps to match the buildbot module. Updated the expected results to match
4121         the current set of core builders.
4122
4123 2011-03-03  Benjamin Poulain  <benjamin.poulain@nokia.com>
4124
4125         Reviewed by Andreas Kling.
4126
4127         Adding myself as a reviewer.
4128
4129         * Scripts/webkitpy/common/config/committers.py:
4130
4131 2011-03-03  Lukasz Slachciak  <l.slachciak@samsung.com>
4132
4133         Reviewed by Xan Lopez.
4134
4135         [GTK] Extended application cache database API and added unit tests file.
4136         https://bugs.webkit.org/show_bug.cgi?id=55335
4137
4138         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: removed external declaration
4139         of webkit_application_cache_set_maximum_size due to API exposal.
4140
4141 2011-03-02  Ojan Vafai  <ojan@chromium.org>
4142
4143         Reviewed by Adam Barth.
4144
4145         make webkit-patch upload work for security bugs
4146         https://bugs.webkit.org/show_bug.cgi?id=55655
4147
4148         The problem is that we shell out to prepare-ChangeLog,
4149         which does not authenticate with bugzilla. All it needs from
4150         bugzilla is the bug title though. We just pass it through from
4151         webkit-patch instead.
4152
4153         * Scripts/prepare-ChangeLog:
4154         * Scripts/webkitpy/common/net/bugzilla/bug.py:
4155         * Scripts/webkitpy/tool/steps/preparechangelog.py:
4156
4157 2011-03-01  Ojan Vafai  <ojan@chromium.org>
4158
4159         Reviewed by Tony Chang.
4160
4161         [test-dashboard] make gtest JSON match layout-tests JSON
4162         https://bugs.webkit.org/show_bug.cgi?id=55556
4163
4164         http://trac.webkit.org/changeset/80090 stopped converting time_ms to t.
4165         Make this code match.
4166
4167         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
4168
4169 2011-03-02  Dirk Pranke  <dpranke@chromium.org>
4170
4171         Reviewed by Tony Chang.
4172
4173         NRWT - implement Linux Hardy 64-bit port support. This involves
4174         adding support for non-'x86' architectures and updating the
4175         "deduplicate_tests" script to correctly understand that
4176         port.name() is not always equal to basename(port.baseline_path()).
4177
4178         This change introduces two new port names: 'chromium-linux-x86'
4179         and 'chromium-linux-x86_64'. Using the prior 'chromium-linux'
4180         flag will cause the code to determine which one to use at
4181         runtime, just like we currently do with 'chromium-win'.
4182
4183         https://bugs.webkit.org/show_bug.cgi?id=55535
4184
4185         * Scripts/webkitpy/common/system/executive_mock.py:
4186           Handle 'return_stderr' keyword arg to run_command()
4187         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
4188         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
4189         * Scripts/webkitpy/layout_tests/port/base.py:
4190         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
4191         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
4192         * Scripts/webkitpy/layout_tests/port/factory.py:
4193         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
4194
4195 2011-03-02  Kevin Ollivier  <kevino@theolliviers.com>
4196
4197         [wx] Build fix, make sure we put the wxWebKit dylib in the right directory and
4198         update symlinks accordingly.
4199
4200         * wx/packaging/build-mac-installer.py:
4201
4202 2011-03-02  Sheriff Bot  <webkit.review.bot@gmail.com>
4203
4204         Unreviewed, rolling out r80139.
4205         http://trac.webkit.org/changeset/80139
4206         https://bugs.webkit.org/show_bug.cgi?id=55620
4207
4208         failing and crashing tests on Snow Leopard bot (Requested by
4209         mihaip1 on #webkit).
4210
4211         * DumpRenderTree/LayoutTestController.cpp:
4212         (LayoutTestController::staticFunctions):
4213         * DumpRenderTree/LayoutTestController.h:
4214         * DumpRenderTree/chromium/LayoutTestController.cpp:
4215         (LayoutTestController::LayoutTestController):
4216         * DumpRenderTree/chromium/LayoutTestController.h:
4217         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4218         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4219         * DumpRenderTree/mac/UIDelegate.h:
4220         * DumpRenderTree/mac/UIDelegate.mm:
4221         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4222         * DumpRenderTree/qt/LayoutTestControllerQt.h:
4223         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4224         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
4225
4226 2011-03-02  Adam Roben  <aroben@apple.com>
4227
4228         Wait for force a paint in WebKitTestRunner until we're actually ready to dump the output
4229
4230         This matches DumpRenderTree on Windows.
4231
4232         Fixes <http://webkit.org/b/55469> <rdar://problem/9068539> REGRESSION (r79863): Lots of
4233         dom/html/level2/html/HTMLFrameElement*.html tests crashing in FrameView::paintOverhangAreas
4234         in WebKit2
4235
4236         Reviewed by Beth Dakin.
4237
4238         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4239         (WTR::InjectedBundlePage::dump): Moved code to force a paint here...
4240         (WTR::InjectedBundlePage::didFinishLoadForFrame): ...from here.
4241
4242 2011-03-02  Daniel Cheng  <dcheng@chromium.org>
4243
4244         Reviewed by David Levin.
4245
4246         Add feature define for data transfer items
4247         https://bugs.webkit.org/show_bug.cgi?id=55510
4248
4249         * Scripts/build-webkit:
4250
4251 2011-03-02  Adam Roben  <aroben@apple.com>
4252
4253         Look in the new-to-SnowLeopard location for crash logs on SnowLeopard and newer
4254
4255         ReportCrash saves logs to ~/Library/Logs/CrashReporter on Leopard, but to
4256         ~/Library/Logs/DiagnosticReports on SnowLeopard. old-run-webkit-tests was only looking in
4257         the former location, but was getting lucky on some SnowLeopard machines because symlinks
4258         were being created there pointing into DiagnosticReports. For machines without these
4259         symlinks, crash logs were not getting captured.
4260
4261         Fixes <http://webkit.org/b/55607> old-run-webkit-tests doesn't capture crash logs on some
4262         SnowLeopard machines
4263
4264         Reviewed by Eric Seidel.
4265
4266         * Scripts/old-run-webkit-tests:
4267         (captureSavedCrashLog): Look in ~/Library/Logs/DiagnosticReports on SnowLeopard and newer.
4268
4269 2011-03-02  Adam Roben  <aroben@apple.com>
4270
4271         Don't try to capture crash logs on platforms that haven't implemented that feature
4272
4273         Fixes <http://webkit.org/b/55504> Use of uninitialized value in numeric lt (<) at
4274         Tools/Scripts/old-run-webkit-tests line 1778 seen on Qt bots after a crash
4275
4276         Reviewed by Joseph Pecoraro.
4277
4278         * Scripts/old-run-webkit-tests:
4279         (captureSavedCrashLog): Bail if we don't have a crash log glob.
4280         (findNewestFileMatchingGlob): Fix a buggy test for when no paths match the glob. This isn't
4281         strictly required to fix bug 55504, but seems worthwhile.
4282
4283 2011-01-26  John Knottenbelt  <jknotten@chromium.org>
4284
4285         Reviewed by Dmitry Titov.
4286
4287         Detach Geolocation from Frame when Page destroyed.
4288         https://bugs.webkit.org/show_bug.cgi?id=52877
4289
4290         Extend the layout test controller to expose the number of pending
4291         geolocation requests, so that we can test that the requests have
4292         been cancelled on page close.
4293
4294         * DumpRenderTree/LayoutTestController.cpp:
4295         (numberOfPendingGeolocationPermissionRequestsCallback):
4296         (LayoutTestController::staticFunctions):
4297         * DumpRenderTree/LayoutTestController.h:
4298         * DumpRenderTree/chromium/LayoutTestController.cpp:
4299         (LayoutTestController::LayoutTestController):
4300         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
4301         * DumpRenderTree/chromium/LayoutTestController.h:
4302         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4303         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
4304         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4305         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
4306         * DumpRenderTree/mac/UIDelegate.h:
4307         * DumpRenderTree/mac/UIDelegate.mm:
4308         (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
4309         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4310         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
4311         * DumpRenderTree/qt/LayoutTestControllerQt.h:
4312         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4313         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
4314         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
4315         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
4316
4317
4318 2011-03-01  Kent Tamura  <tkent@chromium.org>
4319
4320         Reviewed by Dimitri Glazkov.
4321
4322         Assertion fails when a form validation bubble appears
4323         https://bugs.webkit.org/show_bug.cgi?id=55550
4324
4325         Test: fast/forms/interactive-validation-attach-assertion.html
4326
4327         * DumpRenderTree/chromium/WebPreferences.cpp:
4328         (WebPreferences::applyTo): Enable the interactive validation feature by
4329           default. This matches to Chromium browser.
4330
4331 2011-03-01  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
4332
4333         Reviewed by Kent Tamura.