Tools/ChangeLog

   1 2016-01-18  Carlos Alberto Lopez Perez  <clopez@igalia.com>
   2
   3         [GTK][EFL] Layout tests abort with PulseAudioSanitizer instance has no attribute '_pa_module_index' when the build is not ready.
   4         https://bugs.webkit.org/show_bug.cgi?id=153216
   5
   6         Reviewed by Michael Catanzaro.
   7
   8         * Scripts/webkitpy/port/pulseaudio_sanitizer.py:
   9         (PulseAudioSanitizer.__init__): initialize _pa_module_index in the constructor.
  10
  11 2016-01-18  Nan Wang  <n_wang@apple.com>
  12
  13         AX: [Mac] Implement next/previous text marker functions using TextIterator
  14         https://bugs.webkit.org/show_bug.cgi?id=152728
  15
  16         Reviewed by Chris Fleizach.
  17
  18         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
  19         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
  20
  21 2016-01-18  Csaba Osztrogonác  <ossy@webkit.org>
  22
  23         [cmake] Add testair to the build system
  24         https://bugs.webkit.org/show_bug.cgi?id=153126
  25
  26         Reviewed by Michael Catanzaro.
  27
  28         * Scripts/build-jsc:
  29
  30 2016-01-16  Myles C. Maxfield  <mmaxfield@apple.com>
  31
  32         Remove TextRun::allowsRoundingHacks()
  33         https://bugs.webkit.org/show_bug.cgi?id=153185
  34
  35         Reviewed by Simon Fraser.
  36
  37         * DumpRenderTree/mac/DumpRenderTree.mm:
  38         (resetWebViewToConsistentStateBeforeTesting): Deleted.
  39
  40 2016-01-15  Konstantin Tokarev  <annulen@yandex.ru>
  41
  42         [webkitdirs] Avoid list form of open because it broke WinCairo
  43         https://bugs.webkit.org/show_bug.cgi?id=153106
  44
  45         Reviewed by Alex Christensen.
  46
  47         * Scripts/webkitdirs.pm:
  48         (determineArchitecture):
  49
  50 2016-01-15  Simon Fraser  <simon.fraser@apple.com>
  51
  52         Add kdebug_trace signposts for a few WebCore operations
  53         https://bugs.webkit.org/show_bug.cgi?id=153136
  54         rdar://problem/24208487
  55
  56         Reviewed by Sam Weinig.
  57
  58         Plist used by kdebug_trace() viewing tools.
  59
  60         * Tracing/SystemTracePoints.plist: Added.
  61
  62 2016-01-14  Konstantin Tokarev  <annulen@yandex.ru>
  63
  64         [webkitdirs] Replaced grep invocation with perl code
  65         https://bugs.webkit.org/show_bug.cgi?id=153106
  66
  67         Reviewed by Alex Christensen.
  68
  69         * Scripts/webkitdirs.pm:
  70         (determineArchitecture):
  71
  72 2016-01-14  Brian Burg  <bburg@apple.com>
  73
  74         prepare-changelog does not read paths containing spaces properly
  75         https://bugs.webkit.org/show_bug.cgi?id=137982
  76
  77         Reviewed by Joseph Pecoraro.
  78
  79         Escape whitespace in filenames before passing the file path to other functions.
  80
  81         * Scripts/prepare-ChangeLog:
  82         (generateFunctionLists): Use the more explicit 3-argument form of 'open'.
  83
  84 2016-01-14  Jason Marcell  <jmarcell@apple.com>
  85
  86         Standardize the usage of "branch" vs. "branchName".
  87         https://bugs.webkit.org/show_bug.cgi?id=152982
  88
  89         Reviewed by Daniel Bates.
  90
  91         In an earlier patch we started using the name "branch" to indicate a branch object, whereas
  92         "branchName" implies that the variable or property in question is simply a string.
  93
  94         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
  95         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Change branch to branchName.
  96         (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Change branch to branch.name.
  97         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Change branch to branchName.
  98         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
  99         (Trac.prototype.commitsOnBranch): Change branch to branchName.
 100         (Trac.prototype._convertCommitInfoElementToObject): Ditto.
 101         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
 102         (MockTrac): Ditto.
 103
 104 2016-01-14  Jason Marcell  <jmarcell@apple.com>
 105
 106         Add a unit test to test BuildbotQueueView._appendPendingRevisionCount.
 107         https://bugs.webkit.org/show_bug.cgi?id=152910
 108
 109         Reviewed by Daniel Bates.
 110
 111         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueue.js: Added.
 112         (MockBuildbotQueue): Added. Mock BuildbotQueue object that doesn't need to talk to an actual Buildbot server.
 113         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js: Added.
 114         (MockBuildbotQueueView): Added. Mock BuildbotQueueView object that returns a pre-specified _latestProductiveIteration without
 115         the need to talk to a real Buildbot server.
 116         (MockBuildbotQueueView.prototype._latestProductiveIteration): Added. Returns a pre-specified _latestProductiveIteration
 117         without the need to talk to a real Buildbot server.
 118         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js: Added.
 119         (MockTrac): Added. Mock Trac constructor that has pre-populated "recordedCommits" and does not need to talk to a real Trac
 120         server.
 121         (MockTrac.prototype.get oldestRecordedRevisionNumber): Added. Returns a pre-specified revision.
 122         (MockTrac.prototype.get latestRecordedRevisionNumber): Ditto.
 123         (MockTrac.prototype.loadMoreHistoricalData): Added. Overrides the real loadMoreHistoricalData so that we don't waste time
 124         trying to talk to Trac.
 125         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html: Added. Web page container for
 126         QUnit unit tests.
 127         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added. QUnit unit tests.
 128
 129 2016-01-14  Nikos Andronikos  <nikos.andronikos-webkit@cisra.canon.com.au>
 130
 131         [CMake][GTK] CMake Error: Could not create named generator Eclipse CDT4 - Ninja
 132         https://bugs.webkit.org/show_bug.cgi?id=132599
 133
 134         Reviewed by Michael Catanzaro.
 135
 136         Check if cmake Ninja generators are installed.
 137
 138         * Scripts/webkitdirs.pm:
 139         (canUseNinjaGenerator):
 140         (canUseEclipseNinjaGenerator):
 141         (generateBuildSystemFromCMakeProject):
 142         (canUseEclipse): Deleted.
 143
 144 2016-01-13  Myles C. Maxfield  <mmaxfield@apple.com>
 145
 146         [Cocoa] Testing with font family name "System Font" is unused
 147         https://bugs.webkit.org/show_bug.cgi?id=153073
 148         <rdar://problem/24091683>
 149
 150         Reviewed by Brent Fulgham.
 151
 152         * DumpRenderTree/mac/DumpRenderTree.mm:
 153         (allowedFontFamilySet): Deleted.
 154         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
 155         (WTR::allowedFontFamilySet): Deleted.
 156         * WebKitTestRunner/mac/TestControllerMac.mm:
 157         (WTR::allowedFontFamilySet): Deleted.
 158
 159 2016-01-13  Daniel Bates  <dabates@apple.com>
 160
 161         [XSS Auditor] Add test when XSS payload is in the path portion of the URL
 162         https://bugs.webkit.org/show_bug.cgi?id=152871
 163
 164         Reviewed by Brent Fulgham.
 165
 166         Merged from Blink (patch by Tom Sepez <tsepez@chromium.org>):
 167         <https://src.chromium.org/viewvc/blink?revision=164746&view=revision>
 168
 169         * Scripts/webkitpy/layout_tests/servers/lighttpd.conf:
 170
 171 2016-01-08  Andy Estes  <aestes@apple.com>
 172
 173         [Content Filtering] Lazily load platform frameworks
 174         https://bugs.webkit.org/show_bug.cgi?id=152881
 175         rdar://problem/23270886
 176
 177         Reviewed by Brady Eidson.
 178
 179         Added an API test that verifies that the Parental Controls and Network Extension frameworks are loaded at the
 180         expected times. The test verifies that they are not loaded after creating a WKWebView, loading an HTML string,
 181         loading NSData, loading a file, or loading from a custom protocol. It verifies that Network Extension on Mac/iOS
 182         and Parental Controls on iOS are loaded after an HTTP request. It finally verifies that Parental Controls on Mac
 183         is loaded after an HTTPS request.
 184
 185         To accomplish this, TestProtocol was generalized to allow tests to specify the scheme they wish to use.
 186         Other tests that used TestProtocol were updated to account for this change. TestProtocol was removed from
 187         WebKit2.PreventImageLoadWithAutoResizingTest, which didn't actually need to use it. ContentFiltering tests were
 188         also re-enabled on iOS after mistakenly being disabled by r188892.
 189
 190         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 191         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
 192         (TestWebKitAPI::TEST):
 193         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.h: Added.
 194         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.html: Added.
 195         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
 196         (TEST):
 197         (downloadTest):
 198         (-[LazilyLoadPlatformFrameworksController init]):
 199         (-[LazilyLoadPlatformFrameworksController webView]):
 200         (-[LazilyLoadPlatformFrameworksController expectParentalControlsLoaded:networkExtensionLoaded:]):
 201         (-[LazilyLoadPlatformFrameworksController webView:didFinishNavigation:]):
 202         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
 203         (-[ContentFilteringPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
 204         (-[ContentFilteringPlugIn observeValueForKeyPath:ofObject:change:context:]):
 205         (-[ContentFilteringPlugIn checkIfPlatformFrameworksAreLoaded:]):
 206         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
 207         (TestWebKitAPI::TEST):
 208         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
 209         (TestWebKitAPI::TEST): Deleted.
 210         * TestWebKitAPI/cocoa/TestProtocol.h:
 211         * TestWebKitAPI/cocoa/TestProtocol.mm:
 212         (+[TestProtocol registerWithScheme:]):
 213         (+[TestProtocol unregister]):
 214
 215 2016-01-12  Dewei Zhu  <dewei_zhu@apple.com>
 216
 217         Fix the Sunpider converage in slow device.
 218         https://bugs.webkit.org/show_bug.cgi?id=152938
 219         <rdar://problem/22511411>
 220
 221         Reviewed by Ryosuke Niwa.
 222
 223         Updated the patch for RunBenchmark to resume sunspider coverage by removing unused subresources in sub-tests.
 224
 225         * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch:
 226
 227 2016-01-12  Ryosuke Niwa  <rniwa@webkit.org>
 228
 229         Add a build flag for custom element
 230         https://bugs.webkit.org/show_bug.cgi?id=153005
 231
 232         Reviewed by Alex Christensen.
 233
 234         Added --custom-elements option to enable custom elements support.
 235
 236         * Scripts/webkitperl/FeatureList.pm:
 237
 238 2016-01-12  Benjamin Poulain  <bpoulain@apple.com>
 239
 240         [JSC] Add a help message when run-jsc-stress-tests fails
 241         https://bugs.webkit.org/show_bug.cgi?id=153014
 242
 243         Reviewed by Csaba Osztrogonác.
 244
 245         * Scripts/run-jsc-stress-tests:
 246
 247 2016-01-11  Saam barati  <sbarati@apple.com>
 248
 249         run-jsc-stress-tests should try to figure out a JSC path
 250         https://bugs.webkit.org/show_bug.cgi?id=152971
 251
 252         Reviewed by Yusuke Suzuki.
 253
 254         This patch now allows run-jsc-stress-tests to be run
 255         without a "--jsc <jsc-path>" argument. It tries
 256         to take its best guess at a <jsc-path> automagically.
 257
 258         This makes it much easier to just run run-jsc-stress-tests
 259         with a directory or a yaml file as an argument.
 260         You now just do this:
 261         `run-jsc-stress-tests <path-to-yaml>`
 262         or
 263         `run-jsc-stress-tests <path-to-directory-of-js-files>`
 264
 265         I wrote this patch because I'd often find myself hacking the
 266         run-javascriptcore-tests file just to run a particular subset of tests.
 267         Because I always forget the arguments to run-jsc-stress-tests (which means
 268         I always forgot to provide a --jsc argument), I always found it easier to
 269         just hack on that file instead of calling run-jsc-stress-tests directly.
 270         No longer is this true!
 271
 272         * Scripts/run-jsc-stress-tests:
 273
 274 2016-01-09  Andy Estes  <aestes@apple.com>
 275
 276         [Cocoa] Add SPI to opt out a URL scheme from the memory cache
 277         https://bugs.webkit.org/show_bug.cgi?id=152950
 278         rdar://problem/24066652
 279
 280         Reviewed by Tim Horton.
 281
 282         Added an API test.
 283
 284         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 285         * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added.
 286         (+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]):
 287         (+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]):
 288         (+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]):
 289         (-[AlwaysRevalidatedURLSchemeProtocol startLoading]):
 290         (-[AlwaysRevalidatedURLSchemeProtocol stopLoading]):
 291         (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]):
 292         (TEST):
 293
 294 2016-01-11  Commit Queue  <commit-queue@webkit.org>
 295
 296         Unreviewed, rolling out r194866.
 297         https://bugs.webkit.org/show_bug.cgi?id=152986
 298
 299         This change broke the mac build (Requested by ryanhaddad on
 300         #webkit).
 301
 302         Reverted changeset:
 303
 304         "[Cocoa] Add SPI to opt out a URL scheme from the memory
 305         cache"
 306         https://bugs.webkit.org/show_bug.cgi?id=152950
 307         http://trac.webkit.org/changeset/194866
 308
 309 2016-01-11  Andy Estes  <aestes@apple.com>
 310
 311         [Cocoa] Add SPI to opt out a URL scheme from the memory cache
 312         https://bugs.webkit.org/show_bug.cgi?id=152950
 313         rdar://problem/24066652
 314
 315         Reviewed by Tim Horton.
 316
 317         Added an API test.
 318
 319         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 320         * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added.
 321         (+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]):
 322         (+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]):
 323         (+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]):
 324         (-[AlwaysRevalidatedURLSchemeProtocol startLoading]):
 325         (-[AlwaysRevalidatedURLSchemeProtocol stopLoading]):
 326         (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]):
 327         (TEST):
 328
 329 2016-01-11  Konstantin Tokarev  <annulen@yandex.ru>
 330
 331         [webkitdirs] Use CMake to determine architecture on isCMakeBuild()
 332         https://bugs.webkit.org/show_bug.cgi?id=152959
 333
 334         Reviewed by Brent Fulgham.
 335
 336         * Scripts/webkitdirs.pm:
 337         (determineArchitecture):
 338
 339 2016-01-11  Michael Catanzaro  <mcatanzaro@igalia.com>
 340
 341         [GTK] W3C CSS2.1 anonymous table tests are failing
 342         https://bugs.webkit.org/show_bug.cgi?id=152455
 343
 344         Reviewed by Mario Sanchez Prada.
 345
 346         Add shared-mime-info to the jhbuild environment, since it affects the results of layout
 347         tests. Add upstream patches to fix detection of XHTML files.
 348
 349         * gtk/jhbuild.modules:
 350         * gtk/patches/shared-mime-info-xht-glob.patch: Added.
 351         * gtk/patches/shared-mime-info-xhtml-magic.patch: Added.
 352
 353 2016-01-10  Saam barati  <sbarati@apple.com>
 354
 355         Implement a sampling profiler
 356         https://bugs.webkit.org/show_bug.cgi?id=151713
 357
 358         Reviewed by Filip Pizlo.
 359
 360         * Scripts/run-jsc-stress-tests:
 361
 362 2016-01-10  Konstantin Tokarev  <annulen@yandex.ru>
 363
 364         [webkitdirs] Try arch and uname commands on non-windows OS
 365         https://bugs.webkit.org/show_bug.cgi?id=152958
 366
 367         Reviewed by Michael Catanzaro.
 368
 369         Right now, determineArchitecture()  uses `arch` and `uname -m`
 370         commands to determine architecture in case of condition (isGtk() ||
 371         isAppleMacWebKit() || isEfl()) is true. This should be !anyWindows()
 372         instead, because this code is applicable to any non-windows OS WebKit
 373         supports (even Haiku which once was supported is moderately
 374         POSIX-compliant and has uname command).
 375
 376         * Scripts/webkitdirs.pm:
 377         (determineArchitecture):
 378
 379 2016-01-08  Aakash Jain  <aakash_jain@apple.com>
 380
 381         run-webkit-tests mis-counts totals when there are other crashes
 382         https://bugs.webkit.org/show_bug.cgi?id=152894
 383         <rdar://problem/24098697>
 384
 385         Reviewed by Alexey Proskuryakov.
 386
 387         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
 388         (TestRunResults.add): Do not update result counters for other crashes.
 389
 390 2016-01-08  Youenn Fablet  <youenn.fablet@crf.canon.fr>
 391
 392         webkit-patch build-and-test should have an option to iterate over new tests
 393         https://bugs.webkit.org/show_bug.cgi?id=143093
 394
 395         Reviewed by Michael Catanzaro.
 396
 397         This patch introduces the --iterate-on-new-tests option to webkit-patch build-and-test.
 398         It allows running run-webkit-tests on modified or new paths in LayoutTests.
 399         Computation of new or modified tests is done by LayoutTestFinder.find_touched_tests
 400         It implements the translation of -expected.* paths to their related tests.
 401         It also implements the removal of skipped tests.
 402
 403         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
 404         (LayoutTestFinder.find_touched_tests):
 405         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py: Added.
 406         (MockPort):
 407         (MockPort.__init__):
 408         (MockPort.tests):
 409         (LayoutTestFinderTests):
 410         (LayoutTestFinderTests.touched_files):
 411         (LayoutTestFinderTests.test_touched_test):
 412         (LayoutTestFinderTests.test_expected_touched_test):
 413         (LayoutTestFinderTests.test_platform_expected_touched_test):
 414         (LayoutTestFinderTests.test_platform_duplicate_touched_test):
 415         (LayoutTestFinderTests.test_touched_but_skipped_test):
 416         * Scripts/webkitpy/port/base.py:
 417         (Port.potential_test_names_from_expected_file):
 418         * Scripts/webkitpy/tool/commands/download_unittest.py:
 419         (DownloadCommandsTest._default_options):
 420         * Scripts/webkitpy/tool/steps/options.py:
 421         (Options):
 422         * Scripts/webkitpy/tool/steps/runtests.py:
 423         (RunTests.options):
 424         (RunTests.run):
 425         (RunTests):
 426         (RunTests._new_or_modified_tests):
 427         (RunTests._run_webkit_tests):
 428         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
 429         (RunTestsTest.test_webkit_run_unit_tests):
 430         * Scripts/webkitpy/tool/steps/steps_unittest.py:
 431         (StepsTest._step_options):
 432
 433 2016-01-07  Joseph Pecoraro  <pecoraro@apple.com>
 434
 435         prepare-ChangeLog should include radar number
 436         https://bugs.webkit.org/show_bug.cgi?id=152839
 437         <rdar://problem/24093563>
 438
 439         Reviewed by Daniel Bates.
 440
 441         When running `prepare-ChangeLog -b ###`, check for a bugzilla comment that
 442         starts with a "<rdar://problem/####>" URL. If found, include that radar URL
 443         in the ChangeLog description after the bug URL.
 444
 445         * Scripts/prepare-ChangeLog:
 446         (main): Update signatures.
 447         (fetchBugXMLData): XML Data is now used for multiple reasons. Extract this to just get the data.
 448         (fetchBugDescriptionFromBugXMLData): Search data for <short_desc>.
 449         (fetchRadarURLFromBugXMLData): Search comment text for radar URL.
 450         (generateNewChangeLogs): Include radar URL if we found one.
 451
 452         * Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl: Added.
 453         Tests for the radar URL extraction.
 454
 455 2016-01-07  Alexey Proskuryakov  <ap@apple.com>
 456
 457         testRunner.runUIScript crashes while running multiple tests in a row that invokes the same UIScript
 458         https://bugs.webkit.org/show_bug.cgi?id=152390
 459         <rdar://problem/23948321>
 460
 461         Reviewed by Simon Fraser.
 462
 463         Fix two use-after-frees.
 464
 465         1. WKPageCallAfterNextPresentationUpdate's callback has a pointer to TestInvocation,
 466         but we may have already progressed to another test by the time the callback fires,
 467         having destroyed the TestInvocation.
 468         2. UIScriptController is a RefCounted object, but it has a raw pointer to
 469         UIScriptContext which has the same lifetime as a TestInvocation.
 470         As a result, completion blocks of UIScriptController actions would use a destroyed
 471         TestInvocation.
 472
 473         * WebKitTestRunner/TestInvocation.cpp:
 474         (WTR::TestInvocation::~TestInvocation):
 475         (WTR::TestInvocation::url):
 476         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
 477         (WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
 478         (WTR::TestInvocation::runUISideScript):
 479         * WebKitTestRunner/TestInvocation.h:
 480         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
 481         (UIScriptContext::UIScriptContext):
 482         (UIScriptContext::~UIScriptContext):
 483         (UIScriptContext::runUIScript):
 484         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
 485         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
 486         (WTR::UIScriptController::UIScriptController):
 487         (WTR::UIScriptController::contextDestroyed):
 488         (WTR::UIScriptController::makeWindowObject):
 489         (WTR::UIScriptController::setWillBeginZoomingCallback):
 490         (WTR::UIScriptController::willBeginZoomingCallback):
 491         (WTR::UIScriptController::setDidEndZoomingCallback):
 492         (WTR::UIScriptController::didEndZoomingCallback):
 493         (WTR::UIScriptController::setDidEndScrollingCallback):
 494         (WTR::UIScriptController::didEndScrollingCallback):
 495         (WTR::UIScriptController::setDidShowKeyboardCallback):
 496         (WTR::UIScriptController::didShowKeyboardCallback):
 497         (WTR::UIScriptController::setDidHideKeyboardCallback):
 498         (WTR::UIScriptController::didHideKeyboardCallback):
 499         (WTR::UIScriptController::uiScriptComplete):
 500         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
 501         (WTR::UIScriptController::create):
 502         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
 503         (WTR::UIScriptController::doAsyncTask):
 504         (WTR::UIScriptController::zoomToScale):
 505         (WTR::UIScriptController::singleTapAtPoint):
 506         (WTR::UIScriptController::doubleTapAtPoint):
 507         (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
 508         (WTR::UIScriptController::contentVisibleRect):
 509         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
 510         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
 511         (WTR::UIScriptController::platformSetDidShowKeyboardCallback):
 512         (WTR::UIScriptController::platformSetDidHideKeyboardCallback):
 513         (WTR::UIScriptController::platformSetDidEndScrollingCallback):
 514         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
 515         (WTR::UIScriptController::doAsyncTask):
 516
 517 2016-01-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
 518
 519         [buildbot] clean-build script should remove untracked files and revert local changes too
 520         https://bugs.webkit.org/show_bug.cgi?id=142400
 521
 522         Reviewed by Ryosuke Niwa.
 523
 524         This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
 525         A helper routine SCM.discard_untracked_files is added for that purpose.
 526
 527         * BuildSlaveSupport/clean-build:
 528         (main): Making call to Scripts/clean-webkit
 529         * Scripts/clean-webkit: Added.
 530         (main): Revert changes and delete untracked files.
 531         * Scripts/webkitpy/common/checkout/scm/scm.py:
 532         (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.
 533         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
 534         (SCMTest._shared_test_discard_untracked_files):
 535         (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.
 536
 537 2016-01-06  Simon Fraser  <simon.fraser@apple.com>
 538
 539         Add a setting and preferences to enable display-list drawing. Does nothing yet.
 540         https://bugs.webkit.org/show_bug.cgi?id=152807
 541
 542         Reviewed by Zalan Bujtas.
 543
 544         Add an item to the Settings menu to toggle display-list drawing.
 545
 546         * MiniBrowser/mac/SettingsController.h:
 547         * MiniBrowser/mac/SettingsController.m:
 548         (-[SettingsController _populateMenu]):
 549         (-[SettingsController validateMenuItem:]):
 550         (-[SettingsController toggleDisplayListDrawingEnabled:]):
 551         (-[SettingsController displayListDrawingEnabled]):
 552         * MiniBrowser/mac/WK2BrowserWindowController.m:
 553         (-[WK2BrowserWindowController didChangeSettings]):
 554
 555 2016-01-06  Youenn Fablet  <youenn.fablet@crf.canon.fr>
 556
 557         Python SCM should be able to retrieve untracked files - Add GIT support
 558         https://bugs.webkit.org/show_bug.cgi?id=143135
 559
 560         Reviewed by Michael Catanzaro.
 561
 562         * Scripts/webkitpy/common/checkout/scm/git.py:
 563         (Git.untracked_files): Adding support for git.
 564         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
 565         (GitTest.setUp):
 566         (GitTest.test_untracked_files): Adding test.
 567
 568 2016-01-05  Mark Lam  <mark.lam@apple.com>
 569
 570         Rename badly named JSC_timeout env var to JSCTEST_timeout.
 571         https://bugs.webkit.org/show_bug.cgi?id=152748
 572
 573         Reviewed by Geoffrey Garen.
 574
 575         Now that we validate JSC options, the badly named JSC_timeout env var causes the
 576         bots to have a bad time.
 577
 578         * Scripts/run-javascriptcore-tests:
 579         * Scripts/run-jsc-stress-tests:
 580
 581 2016-01-04  Carlos Garcia Campos  <cgarcia@igalia.com>
 582
 583         [GTK] Allow to save and restore session
 584         https://bugs.webkit.org/show_bug.cgi?id=115600
 585
 586         Reviewed by Michael Catanzaro.
 587
 588         Add test case to check the new session API.
 589
 590         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
 591         (testWebKitWebViewSessionState):
 592         (testWebKitWebViewSessionStateWithFormData):
 593         (beforeAll):
 594
 595 2016-01-04  Csaba Osztrogonác  <ossy@webkit.org>
 596
 597         [EFL] Bump EFL version to 1.16.1
 598         https://bugs.webkit.org/show_bug.cgi?id=152688
 599
 600         Reviewed by Gyuyoung Kim.
 601
 602         * efl/jhbuild.modules:
 603
 604 2016-01-04  Aakash Jain  <aakash_jain@apple.com>
 605
 606         error running layout tests on iOS simulator on latest build
 607         https://bugs.webkit.org/show_bug.cgi?id=152719
 608         <rdar://problem/24009549>
 609
 610         Reviewed by Alexey Proskuryakov.
 611
 612         * Scripts/webkitpy/xcode/simulator.py:
 613         (Simulator.wait_until_device_is_booted): Ensure that simulator device is in booted state
 614           before running simctl spawn command.
 615
 616 2016-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
 617
 618         Unreviewed, move Frédéric Wang to committers list
 619
 620         He seems to be on the contributors list by accident. He has been landing his own commits for
 621         about two years now.
 622
 623         * Scripts/webkitpy/common/config/contributors.json:
 624
 625 2016-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
 626
 627         Unreviewed, move Sebastian Dröge to committers list harder
 628
 629         He accidentally added himself to the reviewers list because the file is confusing. Then I
 630         accidentially moved him to the contributors list because the file is confusing, even though
 631         I knew the contributors list existed in this file and was attempting to add him to the
 632         committers list. Really move him to the committers list now.
 633
 634         * Scripts/webkitpy/common/config/contributors.json:
 635
 636 2016-01-02  Youenn Fablet  <youenn.fablet@crf.canon.fr>
 637
 638         Python SCM should be able to retrieve untracked files - Add SVN support
 639         https://bugs.webkit.org/show_bug.cgi?id=152546
 640
 641         Reviewed by Michael Catanzaro.
 642
 643         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
 644         (test_untracked_files): Activating test for SVN.
 645         * Scripts/webkitpy/common/checkout/scm/svn.py:
 646         (SVN.untracked_files): Implementing untracked files retrieval for SVN.
 647
 648 2015-12-31  Andy Estes  <aestes@apple.com>
 649
 650         Replace WTF::move with WTFMove
 651         https://bugs.webkit.org/show_bug.cgi?id=152601
 652
 653         Reviewed by Brady Eidson.
 654
 655         * DumpRenderTree/TestRunner.h:
 656         (TestRunner::setAllowedHosts):
 657         * DumpRenderTree/win/DRTDataObject.cpp:
 658         (DRTDataObject::SetData):
 659         * TestWebKitAPI/Tests/WTF/Deque.cpp:
 660         (TestWebKitAPI::TEST):
 661         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
 662         (TestWebKitAPI::TEST):
 663         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
 664         (TestWebKitAPI::TEST):
 665         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
 666         (TestWebKitAPI::TEST):
 667         * TestWebKitAPI/Tests/WTF/Ref.cpp:
 668         (TestWebKitAPI::passWithRef):
 669         (TestWebKitAPI::TEST):
 670         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
 671         (TestWebKitAPI::TEST):
 672         * TestWebKitAPI/Tests/WTF/Vector.cpp:
 673         (TestWebKitAPI::TEST):
 674         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
 675         (TestWebKitAPI::TEST):
 676         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
 677         (TestWebKitAPI::TEST):
 678         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
 679         (TestWebKitAPI::createTestValue):
 680         (TestWebKitAPI::TEST):
 681         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
 682         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
 683         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
 684         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
 685         (TestWebKitAPI::createNFAs):
 686         (TestWebKitAPI::TEST_F):
 687         * TestWebKitAPI/Tests/WebCore/DFACombiner.cpp:
 688         (TestWebKitAPI::combine):
 689         * TestWebKitAPI/Tests/WebCore/DFAHelpers.h:
 690         (TestWebKitAPI::createNFAs):
 691         * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm:
 692         (TEST):
 693         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
 694         (WebProcessTest::add):
 695
 696 2016-01-01  Michael Catanzaro  <mcatanzaro@igalia.com>
 697
 698         [SOUP] REGRESSION(r192761): Broke resource URIs for applications that use g_resource_load in a web extension
 699         https://bugs.webkit.org/show_bug.cgi?id=152634
 700
 701         Reviewed by Carlos Garcia Campos.
 702
 703         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
 704         (testLoadFromGResource): Added test.
 705         (beforeAll):
 706         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
 707         (registerGResource): Added.
 708         (webkit_web_extension_initialize_with_user_data): Load the test gresource.
 709         * TestWebKitAPI/Tests/WebKit2Gtk/resources/boring.html: Added.
 710         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Add an HTML file.
 711
 712 2015-12-31  David Kilzer  <ddkilzer@apple.com>
 713
 714         REGRESSION (r194470): Fix warnings uncovered by migrating to WTF_MOVE
 715         <https://bugs.webkit.org/show_bug.cgi?id=152601>
 716
 717         Ignore unknown pragmas on older clangs.  Fixes the following
 718         build failure:
 719
 720             Tools/TestWebKitAPI/Tests/WTF/NakedPtr.cpp:184:34: error: unknown warning group '-Wself-move', ignored [-Werror,-Wunknown-pragmas]
 721             #pragma clang diagnostic ignored "-Wself-move"
 722                                              ^
 723             1 error generated.
 724
 725         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
 726         (TestWebKitAPI::TEST):
 727         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
 728         (TestWebKitAPI::TEST):
 729
 730 2015-12-31  Andy Estes  <aestes@apple.com>
 731
 732         Update the style checker to advise using WTFMove() instead of WTF::move()
 733         https://bugs.webkit.org/show_bug.cgi?id=152601
 734
 735         Reviewed by Daniel Bates.
 736
 737         * Scripts/webkitpy/style/checkers/cpp.py:
 738         (check_wtf_move):
 739         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
 740         (WebKitStyleTest.test_wtf_move):
 741
 742 2015-12-31  Andy Estes  <aestes@apple.com>
 743
 744         Fix warnings uncovered by migrating to WTF_MOVE
 745         https://bugs.webkit.org/show_bug.cgi?id=152601
 746
 747         Reviewed by Daniel Bates.
 748
 749         Ignored -Wself-move warnings in these two API tests. It's useful to test that these classes properly handle
 750         self-move, even if doing so would trigger a warning.
 751
 752         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
 753         (TestWebKitAPI::TEST):
 754         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
 755         (TestWebKitAPI::TEST):
 756
 757 2015-12-31  Martin Robinson  <mrobinson@igalia.com>
 758
 759         [GTK] The install-dependencies script has a syntax error
 760         https://bugs.webkit.org/show_bug.cgi?id=152613
 761
 762         Reviewed by Michael Catanzaro.
 763
 764         * gtk/install-dependencies: Add the missing 'then.'
 765
 766 2015-12-30  Philippe Normand  <pnormand@igalia.com>
 767
 768         [Mac][GTK] Jhbuild support for OSX
 769         https://bugs.webkit.org/show_bug.cgi?id=150799
 770
 771         Reviewed by Michael Catanzaro.
 772
 773         * gtk/install-dependencies: Install dependencies on OSX with Homebrew.
 774         * gtk/jhbuild.modules: Moved platform-specific build settings in condition tags.
 775         * gtk/patches/foxbntconfig-fix-osx-cache.diff: Added.
 776         * gtk/jhbuildrc: GTK+ makeargs clean-up, the 3.0.12 hack is no longer needed.
 777
 778 2015-12-28  Michael Catanzaro  <mcatanzaro@igalia.com>
 779
 780         Unreviewed, move Sebastian Dröge to committers list
 781
 782         He accidentally added himself to the reviewers list because the file is confusing.
 783
 784         * Scripts/webkitpy/common/config/contributors.json:
 785
 786 2015-12-24  Simon Fraser  <simon.fraser@apple.com>
 787
 788         Remove the unused #define _USE_MATH_DEFINES
 789         https://bugs.webkit.org/show_bug.cgi?id=152034
 790
 791         Reviewed by Tim Horton.
 792
 793         Update this test to use piDouble from MathExtras.h, and
 794         std::numeric_limits<>.
 795
 796         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
 797
 798 2015-12-24  Youenn Fablet  <youenn.fablet@crf.canon.fr>
 799
 800         Python SCM should be able to retrieve untracked files - Generic changes
 801         https://bugs.webkit.org/show_bug.cgi?id=152536
 802
 803         Reviewed by Brent Fulgham.
 804
 805         This patch introduces SCM.untracked_files to retrieve a list of untracked files.
 806         No support is yet added to GIT and SVN specific implementations.
 807
 808         * Scripts/webkitpy/common/checkout/scm/scm.py:
 809         (SCM.untracked_files):
 810         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
 811         (SCMTest._shared_test_untracked_files):
 812
 813 2015-12-23  Dewei Zhu  <dewei_zhu@apple.com>
 814
 815         SVN checkout used by RunBenchmark should be non-interactive
 816         https://bugs.webkit.org/show_bug.cgi?id=152542
 817
 818         Reviewed by Ryosuke Niwa.
 819
 820         RunBenchmark should not require user interaction while running.
 821
 822         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
 823         (BenchmarkBuilder._checkout_with_subversion):
 824
 825 2015-12-23  Brent Fulgham  <bfulgham@apple.com>
 826
 827         Web Inspector: add support for running protocol-test.js tests on Windows
 828         https://bugs.webkit.org/show_bug.cgi?id=148037
 829         <rdar://problem/22292237>
 830
 831         Reviewed by Simon Fraser.
 832
 833         * DumpRenderTree/win/TestRunnerWin.cpp:
 834         (TestRunner::inspectorTestStubURL): Provide implementation.
 835
 836 2015-12-23  Eric Carlson  <eric.carlson@apple.com>
 837
 838         [MediaStream] MediaDeviceInfo.label must be empty in some situations
 839         https://bugs.webkit.org/show_bug.cgi?id=152000
 840
 841         Reviewed by Brent Fulgham.
 842
 843         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
 844         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
 845         (WTR::InjectedBundle::setUserMediaPermission):
 846         (WTR::InjectedBundle::setUserMediaPermissionForOrigin): New.
 847         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
 848
 849         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
 850         (WTR::TestRunner::setUserMediaPermissionForOrigin): New.
 851         * WebKitTestRunner/InjectedBundle/TestRunner.h:
 852
 853         * WebKitTestRunner/TestController.cpp:
 854         (WTR::TestController::setUserMediaPermissionForOrigin):
 855         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Add NULL check.
 856         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Don't add
 857           persistent permission for origin, that can be done from script now.
 858         * WebKitTestRunner/TestController.h:
 859
 860         * WebKitTestRunner/TestInvocation.cpp:
 861         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Add support for
 862           SetUserMediaPermissionForOrigin.
 863
 864 2015-12-23  Brent Fulgham  <bfulgham@apple.com>
 865
 866         [Win] Unreviewed build fix: Recognize Windows 10 variants.
 867
 868         * Scripts/webkitpy/common/system/platforminfo.py:
 869         (PlatformInfo._determine_win_version):
 870
 871 2015-12-23  Chris Aljoudi <chris@chrismatic.io> and Alex Christensen <achristensen@webkit.org>
 872
 873         Content blockers should be able to promote http to https
 874         https://bugs.webkit.org/show_bug.cgi?id=148966
 875
 876         Reviewed by Benjamin Poulain.
 877
 878         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
 879         (WebCore::ContentExtensions::operator<<):
 880         (TestWebKitAPI::TEST_F):
 881
 882 2015-12-22  Hunseop Jeong  <hs85.jeong@samsung.com>
 883
 884         [EFL] MiniBrowser should be able to choose the offline-web-application-cache option
 885         https://bugs.webkit.org/show_bug.cgi?id=152516
 886
 887         Reviewed by Gyuyoung Kim.
 888
 889         * MiniBrowser/efl/main.c:
 890
 891 2015-12-22  Brent Fulgham  <bfulgham@apple.com>
 892
 893         Unreviewed: Add John Wilander as a contributor.
 894
 895         * Scripts/webkitpy/common/config/contributors.json:
 896
 897 2015-12-22  Chris Fleizach  <cfleizach@apple.com>
 898
 899         [WK2] Looping in testcase: fast/dom/Window/property-access-on-cached-window-after-frame-removed.html
 900         https://bugs.webkit.org/show_bug.cgi?id=152482
 901
 902         Reviewed by Brent Fulgham.
 903
 904         vertical/horizontalScrollbar returns an accessibility element. That element can also be queried
 905         for the same property. On WK2, the element returned will not be valid, but is still present and
 906         that can lead to looping.
 907
 908         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
 909         (AccessibilityUIElement::horizontalScrollbar):
 910         (AccessibilityUIElement::verticalScrollbar):
 911         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
 912         (WTR::AccessibilityUIElement::horizontalScrollbar):
 913         (WTR::AccessibilityUIElement::verticalScrollbar):
 914
 915 2015-12-22  Xabier Rodriguez Calvar  <calvaris@igalia.com>
 916
 917         Unreviewed.
 918
 919         * Scripts/webkitpy/common/config/contributors.json: Marking myself as reviewer.
 920
 921 2015-12-21  Hunseop Jeong  <hs85.jeong@samsung.com>
 922
 923         [EFL] test_ewk2_context failed after r192808
 924         https://bugs.webkit.org/show_bug.cgi?id=151846
 925
 926         Reviewed by Gyuyoung Kim.
 927
 928         Used the added ewk_context_web_process_count_limit_set api
 929         instead of the deprecated ewk_context_process_model_set.
 930
 931         * MiniBrowser/efl/main.c:
 932         (elm_main):
 933
 934 2015-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
 935
 936         Unreviewed, move myself to reviewer list.
 937
 938         * Scripts/webkitpy/common/config/contributors.json:
 939
 940 2015-12-21  Aakash Jain  <aakash_jain@apple.com>
 941
 942         Unreviewed, add myself to the committers list.
 943
 944         * Scripts/webkitpy/common/config/contributors.json:
 945
 946 2015-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
 947
 948         [GTK] jquery.min.js violates DFSG
 949         https://bugs.webkit.org/show_bug.cgi?id=152428
 950
 951         Reviewed by Joseph Pecoraro.
 952
 953         Stop distributing Source/WebInspectorUI/Tools. It is not needed in tarballs. This brings us
 954         into compliance with DFSG by removing a bundled, minified copy of jQuery from our tarball.
 955
 956         * gtk/manifest.txt.in:
 957
 958 2015-12-19  Dan Bernstein  <mitz@apple.com>
 959
 960         [Mac] WebKit contains dead source code for OS X Mavericks and earlier
 961         https://bugs.webkit.org/show_bug.cgi?id=152462
 962
 963         Reviewed by Alexey Proskuryakov.
 964
 965         - Removed definitions of MACOSX_DEPLOYMENT_TARGET and WEBKIT_SYSTEM_INTERFACE_LIBRARY for
 966           OS X 10.9:
 967
 968         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
 969         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
 970         * MiniBrowser/Configurations/DebugRelease.xcconfig:
 971         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
 972         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
 973
 974         - Simplified expressions involving __MAC_OS_X_VERSION_MIN_REQUIRED and removed code that was
 975           never getting compiled:
 976
 977         * DumpRenderTree/mac/TextInputController.m:
 978         * MiniBrowser/mac/BrowserWindowController.m:
 979         * TestWebKitAPI/Tests/mac/AttributedString.mm:
 980         * WebKitTestRunner/mac/EventSenderProxy.mm:
 981
 982 2015-12-18  Michael Catanzaro  <mcatanzaro@igalia.com>
 983
 984         Unreviewed, add WebKitGTK+ Bugzilla email to committers list
 985
 986         This is to make it easy to CC it on Bugzilla.
 987
 988         * Scripts/webkitpy/common/config/contributors.json:
 989
 990 2015-12-18  Aakash Jain  <aakash_jain@apple.com>
 991
 992         Pasteboard get messed up after running kill-old-processes
 993         https://bugs.webkit.org/show_bug.cgi?id=152426
 994
 995         Reviewed by Alexey Proskuryakov.
 996
 997         * BuildSlaveSupport/kill-old-processes:
 998         (main): Do not kill pasteboard anymore.
 999
1000 2015-12-17  Aakash Jain  <aakash_jain@apple.com>
1001
1002         run-webkit-tests shouldn't start multiple iOS simulators while only running one test
1003         https://bugs.webkit.org/show_bug.cgi?id=152157
1004         <rdar://problem/23851817>
1005
1006         Reviewed by Alexey Proskuryakov.
1007
1008         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1009         (LayoutTestRunner.get_worker_count): Calculate required number of workers.
1010         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1011         (Manager._get_test_inputs): Common method to calculate test_inputs.
1012         (Manager._update_worker_count): Calculate and update required number of workers.
1013
1014 2015-12-16  Aakash Jain  <aakash_jain@apple.com>
1015
1016         run-webkit-tests fails to delete Simulator device during cleanup
1017         https://bugs.webkit.org/show_bug.cgi?id=152363
1018
1019         Reviewed by Alexey Proskuryakov.
1020
1021         * Scripts/webkitpy/xcode/simulator.py:
1022         (Simulator.delete_device): Ensure that device is Shutdown before deleting it.
1023
1024 2015-12-16  Tim Horton  <timothy_horton@apple.com>
1025
1026         [mac-wk2] fast/events force click tests crashing
1027         https://bugs.webkit.org/show_bug.cgi?id=152339
1028
1029         Reviewed by Beth Dakin.
1030
1031         * WebKitTestRunner/mac/EventSenderProxy.mm:
1032         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
1033         Set the NSEvent's _type member in addition to overriding -type,
1034         because there are assertions in touch event handling code that depend on it.
1035
1036 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1037
1038         Enforce temporarily bots to sync WebKit and WPT testharness.js
1039         https://bugs.webkit.org/show_bug.cgi?id=152334
1040
1041         Reviewed by Darin Adler.
1042
1043         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1044         (WebPlatformTestServer._copy_webkit_test_files): Temporarily overwrite wpt testharness.js with WebKit testharness.js.
1045
1046 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1047
1048         [Fetch API] Add fetch API compile time flag
1049         https://bugs.webkit.org/show_bug.cgi?id=152254
1050
1051         Reviewed by Darin Adler.
1052
1053         * Scripts/webkitperl/FeatureList.pm:
1054
1055 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1056
1057         Unreviewed.
1058
1059         Added files that have impact in building Streams API to the watchlist.
1060
1061         * Scripts/webkitpy/common/config/watchlist:
1062
1063 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1064
1065         Unreviewed.
1066
1067         Added imported tests to Streams API watchlist.
1068
1069         * Scripts/webkitpy/common/config/watchlist:
1070
1071 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1072
1073         Remove default copy of wpt testharness.js when launching wpt server
1074         https://bugs.webkit.org/show_bug.cgi?id=152298
1075
1076         Reviewed by Darin Adler.
1077
1078         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1079         (WebPlatformTestServer._copy_webkit_test_files): Deleted default copy of WebKit testharness.js to WPT.
1080
1081 2015-12-15  David Kilzer  <ddkilzer@apple.com>
1082
1083         REGRESSION (r192375): DumpRenderTree.app exits immediately with no error
1084         <http://webkit.org/b/152314>
1085
1086         Reviewed by Daniel Bates.
1087
1088         The change to DumpRenderTreeMain.mm in r192375 caused the iOS
1089         code path to exit immediately when calling main().
1090         Unfortunately, DumpRenderTreeMain.mm was used for both
1091         DumpRenderTree command-line binary and DumpRenderTree.app, which
1092         meant that the app would exit immediately with no error code
1093         when run!
1094
1095         The workaround is to introduce a separate source file called
1096         DumpRenderTreeAppMain.mm, similar to what WebKitTestRunner
1097         already does.
1098
1099         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add
1100         DumpRenderTreeAppMain.mm to the project.  Make it the only
1101         compiled source for the DumpRenderTree.app target.
1102         * DumpRenderTree/ios/DumpRenderTreeAppMain.mm: Copied from Tools/DumpRenderTree/mac/DumpRenderTreeMain.mm.
1103         (main): Call DumpRenderTreeMain() on iOS.  Assert on OS X in
1104         case someone tries mistakenly to use the app.
1105         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1106         Link to JavaScriptCore.framework on iOS for the assert.
1107         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
1108         Link to JavaScriptCore.framework on OS X for the assert.  Remove
1109         unneeded EXCLUDED_SOURCE_FILE_NAMES setting.
1110         * DumpRenderTree/mac/DumpRenderTreeMain.mm:
1111         (main): Add assert for iOS so that a crash occurs if someone
1112         tries to run the wrong command.
1113
1114 2015-12-14  Tim Horton  <timothy_horton@apple.com>
1115
1116         Frequent crash under -[WKPDFView web_setMinimumSize:]_block_invoke
1117         https://bugs.webkit.org/show_bug.cgi?id=152266
1118         <rdar://problem/22092676>
1119
1120         Reviewed by Simon Fraser.
1121
1122         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1123         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewResizeCrash.mm: Added.
1124         Add a test that crashed before this change, and doesn't crash after.
1125
1126 2015-12-14  Chris Fleizach  <cfleizach@apple.com>
1127
1128         AX: iOS: Text field variations do not have the correct traits
1129         https://bugs.webkit.org/show_bug.cgi?id=152237
1130
1131         Reviewed by Mario Sanchez Prada.
1132
1133         Add iOS calls for determing if an object is a search field or a text area.
1134
1135         * DumpRenderTree/AccessibilityUIElement.cpp:
1136         (getIsSearchFieldCallback):
1137         (getIsTextAreaCallback):
1138         (stringForSelectionCallback):
1139         (AccessibilityUIElement::getJSClass):
1140         * DumpRenderTree/AccessibilityUIElement.h:
1141         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1142         (AccessibilityUIElement::identifier):
1143         (AccessibilityUIElement::isTextArea):
1144         (AccessibilityUIElement::isSearchField):
1145         (AccessibilityUIElement::traits):
1146         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1147         (WTR::AccessibilityUIElement::scrollPageRight):
1148         (WTR::AccessibilityUIElement::hasContainedByFieldsetTrait):
1149         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
1150         (WTR::AccessibilityUIElement::isSearchField):
1151         (WTR::AccessibilityUIElement::isTextArea):
1152         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1153         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1154         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1155         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
1156         (WTR::AccessibilityUIElement::isTextArea):
1157         (WTR::AccessibilityUIElement::isSearchField):
1158         (WTR::AccessibilityUIElement::rowCount):
1159
1160 2015-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1161
1162         [GTK] [JHBuild] package libtool-bin is now required on Debian systems.
1163         https://bugs.webkit.org/show_bug.cgi?id=152252
1164
1165         Reviewed by Sergio Villar Senin.
1166
1167         * gtk/install-dependencies: Add libtool-bin to the list of packages required
1168         for building the JHBuild on Debian systems.
1169
1170 2015-12-11  Joseph Pecoraro  <pecoraro@apple.com>
1171
1172         check-for-inappropriate-objc-class-names should check all class names, not just externally visible ones
1173         https://bugs.webkit.org/show_bug.cgi?id=152156
1174
1175         Reviewed by Dan Bernstein.
1176
1177         Our frameworks should appropriately prefix all ObjC classes,
1178         not just external symbols.
1179
1180         * Scripts/check-for-inappropriate-objc-class-names:
1181         Remove the -g switch to check all ObjC class names.
1182
1183 2015-12-10  Eric Carlson  <eric.carlson@apple.com>
1184
1185         [MediaStream] Expose media capture devices persistent permissions to WebCore
1186         https://bugs.webkit.org/show_bug.cgi?id=152087
1187
1188         Add support for the new user media permission checker page UI client method.
1189
1190         Reviewed by Chris Dumez.
1191
1192         * WebKitTestRunner/TestController.cpp:
1193         (WTR::decidePolicyForUserMediaPermissionRequest):
1194         (WTR::checkUserMediaPermissionForOrigin):
1195         (WTR::TestController::createOtherPage): Add checkUserMediaPermissionForOrigin.
1196         (WTR::TestController::createWebViewWithOptions): Ditto.
1197         (WTR::TestController::resetStateToConsistentValues): Clear m_userMediaOriginPermissions.
1198         (WTR::originUserVisibleName): New, create a string for the origin.
1199         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Set the WKUserMediaPermissionCheckRef
1200           according to the state of the origin permission map.
1201         (WTR::TestController::handleUserMediaPermissionRequest): Remember both the origin and the
1202           request so we can update the origin permission map in decidePolicyForUserMediaPermissionRequestIfPossible.
1203         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Update the
1204           origin permission map.
1205         * WebKitTestRunner/TestController.h:
1206
1207 2015-12-10  Alex Christensen  <achristensen@webkit.org>
1208
1209         REGRESSION (r192796) WKBundlePageResourceLoadClient should be able to setHTTPBody in willSendRequestForFrame
1210         https://bugs.webkit.org/show_bug.cgi?id=152022
1211         rdar://problem/23763584
1212
1213         Reviewed by Darin Adler.
1214
1215         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1216         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1217         (WTR::InjectedBundlePage::willSendRequestForFrame):
1218         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1219         (WTR::TestRunner::setWillSendRequestReturnsNull):
1220         (WTR::TestRunner::willSendRequestReturnsNullOnRedirect):
1221         (WTR::TestRunner::setWillSendRequestReturnsNullOnRedirect):
1222         (WTR::TestRunner::setWillSendRequestAddsHTTPBody):
1223         (WTR::TestRunner::willSendRequestHTTPBody):
1224         Added setWillSendRequestAddsHTTPBody that uses new SPI for testing.
1225
1226 2015-12-10  Aakash Jain  <aakash_jain@apple.com>
1227
1228         Remove additional simulator checks before running layout-tests
1229         https://bugs.webkit.org/show_bug.cgi?id=152146
1230
1231         Reviewed by Darin Adler.
1232
1233         * Scripts/webkitpy/port/ios.py:
1234         (IOSSimulatorPort.check_sys_deps): Removed additional simulators verifications.
1235         * Scripts/webkitpy/xcode/simulator.py:
1236         (Simulator._boot_and_shutdown_simulator_device): Deleted.
1237         (Simulator.check_simulator_device_and_erase_if_needed): Deleted.
1238
1239 2015-12-09  Aakash Jain  <aakash_jain@apple.com>
1240
1241         Run atleast one simulator even if max process limit is low
1242         https://bugs.webkit.org/show_bug.cgi?id=152081
1243         <rdar://problem/23819694>
1244
1245         Reviewed by Alexey Proskuryakov.
1246
1247 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
1248
1249         [GTK] Crash in WebProcess when loading large content with custom URI schemes
1250         https://bugs.webkit.org/show_bug.cgi?id=144262
1251
1252         Reviewed by Carlos Garcia Campos.
1253
1254         Added new unit test to check the additional scenarios we now
1255         handle for custom URI schemes.
1256
1257         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1258         (generateHTMLContent): New helper function to generate big enough content.
1259         (testWebContextURIScheme): New unit test.
1260
1261 2015-12-09  Ryuan Choi  <ryuan.choi@navercorp.com>
1262
1263         [EFL] Fix unhandled web process message when launching MiniBrowser
1264         https://bugs.webkit.org/show_bug.cgi?id=152048
1265
1266         Reviewed by Gyuyoung Kim.
1267
1268         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
1269         (TestWebKitAPI::TEST):
1270
1271 2015-12-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1272
1273         [GTK] Add API to handle beforeunload events
1274         https://bugs.webkit.org/show_bug.cgi?id=139090
1275
1276         Reviewed by Gustavo Noronha Silva.
1277
1278         * MiniBrowser/gtk/BrowserWindow.c:
1279         (browserWindowConstructed):
1280         (browserWindowDeleteEvent):
1281         (browser_window_class_init):
1282         Handle delete-event to prevent the window from being closed when
1283         the page has beforeunload handlers. Use
1284         webkit_web_view_try_close() when the window is requested to be
1285         closed.
1286         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1287         (testWebViewJavaScriptDialogs):
1288         Add a test case for the WEBKIT_SCRIPT_DIALOG_BEFORE_UNLOAD_CONFIRM
1289         script dialog type.
1290
1291 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
1292
1293         Refactored initialization code in LoadTrackingTest.
1294
1295         Rubber-stamped by Carlos Garcia Campos.
1296
1297         Small refactoring to make sure that the state of a LoadTrackingTest
1298         gets properly reset before loading new web content.
1299
1300         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
1301         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
1302         (LoadTrackingTest::reset): New, refactored code from *load*() and go*()
1303         functions and reset the remaining local variables.
1304         (LoadTrackingTest::loadURI): Call reset();
1305         (LoadTrackingTest::loadHtml): Ditto.
1306         (LoadTrackingTest::loadPlainText): Ditto.
1307         (LoadTrackingTest::loadBytes): Ditto.
1308         (LoadTrackingTest::loadRequest): Ditto.
1309         (LoadTrackingTest::reload): Ditto.
1310         (LoadTrackingTest::goBack): Ditto.
1311         (LoadTrackingTest::goForward): Ditto.
1312
1313 2015-12-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1314
1315         [EFL] REGRESSION(r193616): WKPreferences test has been failed since r193616
1316         https://bugs.webkit.org/show_bug.cgi?id=151942
1317
1318         Reviewed by Darin Adler.
1319
1320         * MiniBrowser/efl/main.c:
1321         (window_create): Enable offline web application cache feature on MiniBrowser.
1322         (elm_main):
1323
1324 2015-12-08  Aakash Jain  <aakash_jain@apple.com>
1325
1326         https://bugs.webkit.org/show_bug.cgi?id=151243
1327         <rdar://problem/22955197>
1328
1329         Reviewed by Alexey Proskuryakov.
1330
1331         * LayoutTestRelay/LayoutTestRelay/main.m:
1332         (getTestingSimDevice): Use separate testing device for each worker.
1333         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1334         (Manager.run): Perform cleanup even if setup fails.
1335         * Scripts/webkitpy/port/ios.py:
1336         (IOSSimulatorPort.default_child_processes): Calculate number of simulators to use.
1337         (IOSSimulatorPort.child_processes): Gets the number of simulators from options variable.
1338         (IOSSimulatorPort.setup_test_run): Handle mulitple simulators.
1339         (IOSSimulatorPort._quit_ios_simulator): Same
1340         (IOSSimulatorPort.clean_up_test_run): Same
1341         (IOSSimulatorPort.check_sys_deps): Same
1342         (IOSSimulatorPort.testing_device): Same
1343         (IOSSimulatorPort.reset_preferences): Same
1344         (IOSSimulatorPort.get_simulator_path): Return simulator path.
1345         (IOSSimulatorPort._createSimulatorApp): Create the copy of simulator app.
1346         * Scripts/webkitpy/xcode/simulator.py:
1347         (Device.delete): Delete the simulator device.
1348         (Simulator.delete_device): Same
1349         (Simulator.wait_until_device_is_booted): Wait for device booting.
1350
1351 2015-12-08  Ryuan Choi  <ryuan.choi@navercorp.com>
1352
1353         [EFL] Add API to provide preferences before creating ewk_view
1354         https://bugs.webkit.org/show_bug.cgi?id=151587
1355
1356         Reviewed by Gyuyoung Kim.
1357
1358         * MiniBrowser/efl/main.c:
1359         (on_key_down):
1360         (quit):
1361         (window_create):
1362         Moved settings related code to configuration() not to update settings
1363         whenever ewk_view is created.
1364         (configuration):
1365         (elm_main):
1366
1367 2015-12-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1368
1369         Unreviewed. Fix GTK+ API tests after r193639.
1370
1371         The new jhbuild version needs some more variables ot be present in
1372         the builtin dict, even if they are set to None.
1373
1374         * jhbuild/jhbuildutils.py:
1375         (enter_jhbuild_environment_if_available):
1376
1377 2015-12-07  Gustavo Noronha Silva  <gns@gnome.org>
1378
1379         [GTK] Notify WebCore when notification is clicked
1380         https://bugs.webkit.org/show_bug.cgi?id=151951
1381
1382         Reviewed by Carlos Garcia Campos.
1383
1384         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1385         (testWebViewNotification): test the new API.
1386
1387 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
1388
1389         'jhbuild build' should fail immediately when building any module fails
1390         https://bugs.webkit.org/show_bug.cgi?id=145697
1391
1392         Reviewed by Carlos Garcia Campos.
1393
1394         * efl/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
1395         * gtk/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
1396         Everything is placed under lib instead of lib64 now.
1397         * jhbuild/jhbuild-wrapper: Update jhbuild to the latest upstream commit, and pass
1398         --exit-on-error when running 'jhbuild build'.
1399         * jhbuild/jhbuildrc_common.py:
1400         (init): Don't override PKG_CONFIG_PATH, CMAKE_PREFIX_PATH, or CMAKE_LIBRARY_PATH. Modern
1401         jhbuild should be able to handle these for us without breaking things....
1402
1403 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1404
1405         Add support to import w3c tests from a repository with a different root that the main repo dir
1406         https://bugs.webkit.org/show_bug.cgi?id=151751
1407
1408         Reviewed by Ryosuke Niwa and Youenn Fablet.
1409
1410         We should be able to import tests from repositories that are not pure test repositories and where tests are kept
1411         in a different directory than the repository root.
1412
1413         This patch introduces a new parameter tests_directory that we will use as root directory to search for
1414         tests. All paths will be flattened when copying tests to have a less complicated directory structure. This
1415         requires having the copy_path lists including tuples of origin and destination directories.
1416
1417         * Scripts/webkitpy/w3c/test_downloader.py:
1418         (TestDownloader._add_test_suite_paths): Adds the paths as a tuple of origin and destination directory.
1419         (TestDownloader.copy_tests): Uses the origin and destination tuple for the paths to copy when copying files.
1420         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1421         (TestImporterTest.test_tests_directory): Test.
1422
1423 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1424
1425         Mock TestRepositories in W3C importer tests
1426         https://bugs.webkit.org/show_bug.cgi?id=151938
1427
1428         Reviewed by Youenn Fablet.
1429
1430         The test importer tests should use a fake repository instead of using the real one. The reason why this happened
1431         is because the test repository method reading the file was using the filesystem directly instead of taking the
1432         host one. This patch changes that.
1433
1434         * Scripts/webkitpy/w3c/test_downloader.py:
1435         (TestDownloader.load_test_repositories): Take a filesystem and use it. If we get no filesystem, we use the
1436         default one.
1437         (TestDownloader.__init__): When loading the repositories, pass the host filesystem.
1438         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1439         (TestImporterTest.test_harnesslinks_conversion):
1440         (TestImporterTest.test_submodules_generation): Use a fake test repository file.
1441
1442 2015-12-07  David Kilzer  <ddkilzer@apple.com>
1443
1444         TestNetscapePlugIn: Address review comment on 193607
1445         <http://webkit.org/b/151881>
1446
1447         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1448         (testSetStatus): Initializing std::unique_ptr<char[]> with
1449         nullptr is redundant.
1450
1451 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1452
1453         [GTK] Add webkit_uri_request_get_http_method
1454         https://bugs.webkit.org/show_bug.cgi?id=151601
1455
1456         Reviewed by Martin Robinson.
1457
1458         Add test case to check HTTP method of WebKitURIRequest.
1459
1460         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
1461         (testURIRequestHTTPMethod):
1462         (serverCallback):
1463         (beforeAll):
1464         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1465         (sendRequestCallback):
1466
1467 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1468
1469         [GTK] Add WebKitWebPage::console-message-sent signal to Web Extensions API
1470         https://bugs.webkit.org/show_bug.cgi?id=79918
1471
1472         Reviewed by Gustavo Noronha Silva.
1473
1474         Add unit tests to check the different console messages.
1475
1476         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1477         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp: Added.
1478         (ConsoleMessageTest::ConsoleMessage::operator==):
1479         (ConsoleMessageTest::consoleMessageReceivedCallback):
1480         (ConsoleMessageTest::ConsoleMessageTest):
1481         (ConsoleMessageTest::~ConsoleMessageTest):
1482         (ConsoleMessageTest::waitUntilConsoleMessageReceived):
1483         (testWebKitConsoleMessageConsoleAPI):
1484         (testWebKitConsoleMessageJavaScriptException):
1485         (testWebKitConsoleMessageNetworkError):
1486         (testWebKitConsoleMessageSecurityError):
1487         (beforeAll):
1488         (afterAll):
1489         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1490         (consoleMessageSentCallback):
1491         (pageCreatedCallback):
1492
1493 2015-12-07  Ryuan Choi  <ryuan.choi@navercorp.com>
1494
1495         [EFL] MiniBrowser doesn't exit when called ewk_view_try_close()
1496         https://bugs.webkit.org/show_bug.cgi?id=151934
1497
1498         Reviewed by Csaba Osztrogonác.
1499
1500         * MiniBrowser/efl/main.c:
1501         (on_window_deletion): Revert the changes of r192767.
1502
1503 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
1504
1505         [GTK] update-webkitgtk-libs cannot build mesa
1506         https://bugs.webkit.org/show_bug.cgi?id=151535
1507
1508         Reviewed by Martin Robinson.
1509
1510         Upgrade to newer mesa in order to build successfully against LLVM 3.7. Add missing
1511         dependency of mesa on LLVM, to ensure LLVM is built first. Build LLVM unconditionally, even
1512         on architectures where FTL is not supported, to ensure mesa is always buildable, since LLVM
1513         does not have a stable API and we cannot expect mesa to be buildable unless we control the
1514         LLVM version. Build mesa with --disable-egl since --enable-egl conflicts with
1515         --enable-xlib-glx. This fixes update-webkitgtk-libs on distros with LLVM 3.7.
1516
1517         * gtk/jhbuild.modules:
1518
1519 2015-12-07  Philippe Normand  <pnormand@igalia.com>
1520
1521         [GTK][Mac] libWebExtensionTest link error
1522         https://bugs.webkit.org/show_bug.cgi?id=150802
1523
1524         Reviewed by Carlos Garcia Campos.
1525
1526         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: add dependencies to the webextension library.
1527
1528 2015-12-06  David Kilzer  <ddkilzer@apple.com>
1529
1530         TestNetscapePlugIn: Fix leaks found by static analyzer
1531         <http://webkit.org/b/151881>
1532
1533         Reviewed by Darin Adler.
1534
1535         Fixes the following leaks found by the static analyzer:
1536             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'path'
1537                     return false;
1538                            ^~~~~
1539             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'target'
1540                     return false;
1541                            ^~~~~
1542             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'url'
1543                     return false;
1544                            ^~~~~
1545
1546         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1547         (toCString): Switch to returning std::unique_ptr<char[]>.  Add
1548         early return if allocation fails.
1549         (testPostURLFile): Switch to using std::unique_ptr<char[]>.
1550         Make sure to call fclose() on filehandle, even for an early
1551         return.
1552         (testSetStatus): Switch to using std::unique_ptr<char[]>.
1553
1554 2015-12-05  David Kilzer  <ddkilzer@apple.com>
1555
1556         prepare-ChangeLog: Fix some warning messages when using svn
1557         <http://webkit.org/b/151914>
1558
1559         Reviewed by Daniel Bates.
1560
1561         * Scripts/prepare-ChangeLog:
1562         (generateFunctionLists): Simplify logic so that we never call
1563         normalizePath() with an undefined value.
1564         (attributeCommand): Quote $subPath for the shell so that we
1565         don't try to run "svn propget" on invalid paths.
1566
1567 2015-12-04  David Kilzer  <ddkilzer@apple.com>
1568
1569         TestNetscapePlugIn: Fix remaining static analyzer warnings
1570         <http://webkit.org/b/151888>
1571
1572         Reviewed by Alexey Proskuryakov.
1573
1574         Fixes the following static analyzer warnings:
1575             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:101:9: warning: Called function pointer is null (null dereference)
1576                     CRASH();
1577                     ^~~~~~~
1578             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:46:5: note: expanded from macro 'CRASH'
1579                 ((void(*)())0)(); /* More reliable, but doesn't say BBADBEEF */ \
1580                 ^~~~~~~~~~~~~~~~
1581             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:375:12: warning: Access to field 'pluginTest' results in a dereference of a null pointer (loaded from variable 'obj')
1582                 return obj->pluginTest->NPP_SetWindow(window);
1583                        ^~~~~~~~~~~~~~~
1584             2 warnings generated.
1585
1586         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1587         (CRASH): Use __builtin_trap() for gcc/clang.
1588         (NPP_SetWindow): Add early return if obj is nullptr.
1589
1590 2015-12-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1591
1592         [GTK] Test /webkit2/WebKitWebResource/get-data is flaky
1593         https://bugs.webkit.org/show_bug.cgi?id=151797
1594
1595         Reviewed by Martin Robinson.
1596
1597         Since we switched to use the network process to run the unit tests
1598         the test /webkit2/WebKitWebResource/get-data sometimes fails and
1599         sometimes passes. We are now also getting the notification for the
1600         css image. Since we wait for 3 resources, sometimes the css image
1601         is loaded before and then checkResourceData is called for it, but
1602         not handled. When the css image is the last one loaded the test
1603         passes. So, we just need to wait for the 4 resources.
1604
1605         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1606         (testWebResourceGetData):
1607
1608 2015-12-03  David Kilzer  <ddkilzer@apple.com>
1609
1610         DumpRenderTree: Use-after-free in createBitmapContext() in PixelDumpSupportMac.mm
1611         <http://webkit.org/b/151845>
1612
1613         Reviewed by Simon Fraser.
1614
1615         Fixes the following static analyzer warning:
1616             DumpRenderTree/mac/PixelDumpSupportMac.mm:67:9: warning: Use of memory after it is freed
1617                     WTFLogAlways("DumpRenderTree: CGBitmapContextCreate(%p, %llu, %llu, 8, %llu, %p, 0x%x) failed\n", buffer, pixelsHigh, pixelsWide, rowBytes, colorSpace.get(), kCGImageAlphaPremultipliedFirst | kCGBitmapByteOrder32Host);
1618                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1619
1620         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1621         (createBitmapContext): Free 'buffer' after using it in logging
1622         to fix the use-after-free.  Assign a value of nullptr to buffer
1623         so we don't return with it set to a freed address.
1624
1625 2015-12-03  Jer Noble  <jer.noble@apple.com>
1626
1627         Expose WebCore's InvisibleAutoplayNotPermitted setting to WebKit & WebKit2
1628         https://bugs.webkit.org/show_bug.cgi?id=151830
1629
1630         Reviewed by Anders Carlsson.
1631
1632         Set invisibleAutoplayNotPermitted to NO by default both in WKTR and DRT.
1633
1634         * DumpRenderTree/mac/DumpRenderTree.mm:
1635         (resetWebPreferencesToConsistentValues):
1636         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1637         (WTR::initializeWebViewConfiguration):
1638
1639 2015-12-03  Anders Carlsson  <andersca@apple.com>
1640
1641         Remove Objective-C GC support
1642         https://bugs.webkit.org/show_bug.cgi?id=151819
1643         rdar://problem/23746991
1644
1645         Reviewed by Dan Bernstein.
1646
1647         * asan/asan.xcconfig:
1648
1649 2015-12-02  Yusuke Suzuki  <utatane.tea@gmail.com>
1650
1651         Allow nil for unspecified benchmark pathes
1652         https://bugs.webkit.org/show_bug.cgi?id=151784
1653
1654         Reviewed by Filip Pizlo.
1655
1656         `Pathname.new(nil)` will raise an error.
1657         Only generate Pathname if the benchmark path is specified.
1658
1659         * Scripts/run-jsc-benchmarks:
1660
1661 2015-12-02  Brent Fulgham  <bfulgham@apple.com>
1662
1663         [Win] Run non-http tests without Cygwin
1664         https://bugs.webkit.org/show_bug.cgi?id=151721
1665
1666         Reviewed by Andy Estes.
1667
1668         Support native 32-bit and 64-bit Python (and Perl) builds
1669         for running tests:
1670
1671         1. Use "startswith('win')", rather than "== 'win32'" to support
1672         various Windows build types.
1673         2. Supply full path for some native Windows utilities, since the
1674         path environment does not always have the specified, and they are
1675         guaranteed to exist in those specific locations.
1676         3. Make sure native Windows Python test runs pass proper environment
1677         variables to run programs.
1678         4. Append 'exe' suffix when running Windows executables.
1679         5. Use the _winreg Python module on Windows, since the Cygwin 'regtool'
1680         command doesn't exist.
1681
1682         * Scripts/update-webkit: Use Perl $^X command to refer to the path of
1683         the current Perl executable, rather than requiring a new path search.
1684         * Scripts/webkitpy/common/find_files_unittest.py:
1685         (TestWinNormalize.test_win): Use startswith('win').
1686         * Scripts/webkitpy/common/prettypatch_unittest.py:
1687         (test_pretty_diff_encodings): Ditto.
1688         * Scripts/webkitpy/common/system/executive.py:
1689         (Executive._should_close_fds): Ditto.
1690         (Executive.shell_command_for_script): Use startswith('win').
1691         (Executive.kill_process): Use full path to killall executable.
1692         (Executive.check_running_pid): Use startswith('win').
1693         (Executive.running_pids): Ditto.
1694         (Executive.kill_all): Ditto. Also use path to 'killall' executable when
1695         running under native Windows Python.
1696         (Executive._child_process_encoding): Use startswith('win').
1697         (Executive._should_encode_child_process_arguments): Ditto.
1698         (Executive.popen): Recognize proper script engine on Windows, since it
1699         does not support the shebang syntax.
1700         (Executive.run_in_parallel): Use startswith('win').
1701         * Scripts/webkitpy/common/system/executive_unittest.py:
1702         (never_ending_command): Ditto.
1703         (ExecutiveTest.test_run_command_with_unicode): Ditto.
1704         (ExecutiveTest.serial_test_kill_process): Ditto.
1705         (ExecutiveTest.serial_test_kill_all): Ditto.
1706         (ExecutiveTest.serial_test_check_running_pid): Ditto.
1707         (ExecutiveTest.serial_test_run_in_parallel): Ditto.
1708         (main): Ditto.
1709         * Scripts/webkitpy/common/system/file_lock.py:
1710         (FileLock._create_lock): Ditto.
1711         (FileLock._remove_lock): Ditto.
1712         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1713         (RealFileSystemTest.test_chdir): Ditto.
1714         (RealFileSystemTest.test_chdir__notexists): Ditto.
1715         (RealFileSystemTest.test_maybe_make_directory__failure): Ditto.
1716         * Scripts/webkitpy/common/system/path_unittest.py:
1717         (AbspathTest.test_abspath_to_uri_win): Ditto.
1718         * Scripts/webkitpy/common/system/platforminfo.py:
1719         (PlatformInfo._determine_os_name): Ditto.
1720         * Scripts/webkitpy/common/system/user.py: Ditto.
1721         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1722         (ManagerTest.integration_test_needs_servers): Ditto.
1723         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1724         (LayoutTestApacheHttpd.__init__): Handle upper and lower-case
1725         driver letters.
1726         (LayoutTestApacheHttpd._get_apache_config_file_path): Ditto.
1727         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
1728         (TestLayoutTestApacheHttpd.test_start_cmd): Ditto.
1729         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
1730         (HttpServerBase._check_that_all_ports_are_available): Ditto.
1731         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1732         (TestHttpServer.test_start_cmd): Ditto.
1733         * Scripts/webkitpy/port/base.py:
1734         (Port.to.setup_environ_for_server): Include 'COMSPEC', 'SYSTEMDRIVE',
1735         and 'SYSTEMROOT' in environment passed to test runners.
1736         (Port._apache_config_file_name_for_platform): Use startswith('win').
1737         (Port._build_path): Ditto.
1738         (Port._path_to_driver): Include 'exe' suffix when running under native
1739         Windows.
1740         * Scripts/webkitpy/port/driver.py:
1741         (Driver._setup_environ_for_driver): Explicitly make some environment
1742         variables strings.
1743         * Scripts/webkitpy/port/server_process.py:
1744         (ServerProcess.__init__): Use startswith('win').
1745         * Scripts/webkitpy/port/win.py:
1746         (WinPort): Use the win32 registry utilities on Windows, and appropriate
1747         registry key formats.
1748         (WinPort._ntsd_location): Revise tool search paths for Windows 10.
1749         (WinPort.read_registry_value): Revise to use _winreg library on Windows,
1750         and regtool on Cygwin.
1751         (WinPort.write_registry_value): Ditto.
1752         (WinPort.setup_crash_log_saving): Ditto.
1753         (WinPort.restore_crash_log_saving): Ditto.
1754         (WinPort.prevent_error_dialogs): Ditto.
1755         (WinPort.allow_error_dialogs): Ditto.
1756         (WinPort.find_system_pid): Revise to use Windows management
1757         infrastructure on native Windows, continue using 'ps' on Cygwin.
1758         (WinPort.read_registry_string): Deleted.
1759         (WinPort.write_registry_string): Deleted.
1760         * Scripts/webkitpy/test/main.py:
1761         (main): Use startswith('win').
1762         (Tester._parse_args): Ditto.
1763
1764 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
1765
1766         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
1767         https://bugs.webkit.org/show_bug.cgi?id=150792
1768
1769         Reviewed by Saam Barati.
1770
1771         * Scripts/webkitperl/FeatureList.pm:
1772
1773 2015-12-01  Commit Queue  <commit-queue@webkit.org>
1774
1775         Unreviewed, rolling out r192914.
1776         https://bugs.webkit.org/show_bug.cgi?id=151734
1777
1778         JSC tests for this change are failing on 32 and 64-bit bots
1779         (Requested by ryanhaddad on #webkit).
1780
1781         Reverted changeset:
1782
1783         "[ES6] Implement LLInt/Baseline Support for ES6 Generators and
1784         enable this feature"
1785         https://bugs.webkit.org/show_bug.cgi?id=150792
1786         http://trac.webkit.org/changeset/192914
1787
1788 2015-12-01  David Kilzer  <ddkilzer@apple.com>
1789
1790         EventSenderProxy::swipeGestureWithWheelAndMomentumPhases() leaks an EventSenderSyntheticEvent
1791         <http://webkit.org/b/151726>
1792
1793         Reviewed by Simon Fraser.
1794
1795         * WebKitTestRunner/mac/EventSenderProxy.mm:
1796         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
1797         Deploy RetainPtr<EventSenderSyntheticEvent> to fix leak.
1798
1799 2015-12-01  Myles C. Maxfield  <mmaxfield@apple.com>
1800
1801         Give String and AtomicString an existingHash() function
1802         https://bugs.webkit.org/show_bug.cgi?id=151717
1803
1804         Reviewed by Andreas Kling.
1805
1806         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
1807         (TestWebKitAPI::TEST):
1808         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1809         (TestWebKitAPI::TEST):
1810
1811 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
1812
1813         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
1814         https://bugs.webkit.org/show_bug.cgi?id=150792
1815
1816         Reviewed by Saam Barati.
1817
1818         * Scripts/webkitperl/FeatureList.pm:
1819
1820 2015-12-01  Sam Weinig  <sam@webkit.org>
1821
1822         Need completionHandler-based WebKit C SPI for alert, confirm, and prompt
1823         <rdar://problem/23320863>
1824         https://bugs.webkit.org/show_bug.cgi?id=151708
1825
1826         Reviewed by Anders Carlsson.
1827
1828         * WebKitTestRunner/TestController.cpp:
1829         (WTR::TestController::createOtherPage):
1830         (WTR::TestController::createWebViewWithOptions):
1831         Update for new WKPageUIClient.
1832
1833 2015-12-01  Anders Carlsson  <andersca@apple.com>
1834
1835         Remove WebKit2.framework
1836         https://bugs.webkit.org/show_bug.cgi?id=151715
1837
1838         Reviewed by Dan Bernstein.
1839
1840         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp:
1841         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp:
1842         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
1843         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1844         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
1845         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
1846         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
1847
1848 2015-12-01  Joseph Pecoraro  <pecoraro@apple.com>
1849
1850         Unreviewed common typo fix "occurance" => "occurrence".
1851
1852         * Scripts/webkitpy/tool/commands/queries.py:
1853         (FindFlakyTests._print_statistics):
1854
1855 2015-11-30  Alex Christensen  <achristensen@webkit.org>
1856
1857         Make ProcessModel always MultipleSecondaryProcesses
1858         https://bugs.webkit.org/show_bug.cgi?id=151662
1859
1860         Reviewed by Antti Koivisto.
1861
1862         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1863         (TestWebKitAPI::TEST):
1864         * WebKitTestRunner/TestController.cpp:
1865         (WTR::TestController::generatePageConfiguration):
1866
1867 2015-11-30  Alex Christensen  <achristensen@webkit.org>
1868
1869         Make usesNetworkProcess always true
1870         https://bugs.webkit.org/show_bug.cgi?id=151580
1871
1872         Reviewed by Darin Adler.
1873
1874         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1875         (TestWebKitAPI::TEST):
1876         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
1877         (TestWebKitAPI::TEST):
1878         * WebKitTestRunner/TestController.cpp:
1879         (WTR::TestController::generatePageConfiguration):
1880
1881 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1882
1883         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/editable/editable in Debug.
1884
1885         Add a way to skip unit tests only for Debug or Release builds and
1886         skipt the test /webkit2/WebKitWebView/editable/editable only for Debug.
1887
1888         * Scripts/run-gtk-tests:
1889         (SkippedTest):
1890         (SkippedTest.__init__):
1891         (SkippedTest.__str__):
1892         (SkippedTest.skip_entire_suite):
1893         (SkippedTest.skip_for_build_type):
1894         (TestRunner):
1895         (TestRunner.__init__):
1896
1897 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1898
1899         Unreviewed. Fix a crash in GTK+ test /webkit2/WebKitWebView/custom-charset.
1900
1901         It's an assert hit because we are reloading a view loaded with
1902         HTML data which is not supported. Use loadURI instead.
1903
1904         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1905         (testWebViewCustomCharset):
1906
1907 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1908
1909         [GLIB] Remove GMainLoopSource and GThreadSafeMainLoopSource
1910         https://bugs.webkit.org/show_bug.cgi?id=151633
1911
1912         Reviewed by Csaba Osztrogonác.
1913
1914         * TestWebKitAPI/PlatformGTK.cmake:
1915         * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp: Removed.
1916
1917 2015-11-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1918
1919         [GTK] Remove the remaining uses of GMainLoopSource
1920         https://bugs.webkit.org/show_bug.cgi?id=151632
1921
1922         Reviewed by Žan Doberšek.
1923
1924         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1925         (testWebViewSyncRequestOnMaxConns):
1926         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1927         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1928         (WTR::TestRunner::TestRunner):
1929         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1930         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1931         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
1932         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1933         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1934         (WTR::timeoutSource):
1935         (WTR::TestController::notifyDone):
1936         (WTR::TestController::platformRunUntil):
1937
1938 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
1939
1940         [cmake] Add testb3 to the build system
1941         https://bugs.webkit.org/show_bug.cgi?id=151619
1942
1943         Reviewed by Gyuyoung Kim.
1944
1945         * Scripts/build-jsc:
1946
1947 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
1948
1949         [jhbuild] Fix pixman build with clang
1950         https://bugs.webkit.org/show_bug.cgi?id=151441
1951
1952         Reviewed by Carlos Garcia Campos.
1953
1954         * efl/jhbuild.modules:
1955         * gtk/jhbuild.modules:
1956
1957 2015-11-26  David Kilzer  <ddkilzer@apple.com>
1958
1959         Extract prependToEnvironmentVariableList
1960         <http://webkit.org/b/151536>
1961
1962         Reviewed by Daniel Bates.
1963
1964         Tests: webkitdirs_unittest/appendToEnvironmentVariableList.pl
1965                webkitdirs_unittest/prependToEnvironmentVariableList.pl
1966
1967         * Scripts/webkitdirs.pm: Export appendToEnvironmentVariableList
1968         and prependToEnvironmentVariableList.
1969         (appendToEnvironmentVariableList): Simplify variable name.
1970         Switch to use $Config{path_sep}.
1971         (prependToEnvironmentVariableList): Add new method.
1972         (setupMacWebKitEnvironment): Switch to use
1973         prependToEnvironmentVariableList().
1974         (setupIOSWebKitEnvironment): Ditto.
1975
1976         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl: Added.
1977         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl: Added.
1978
1979 2015-11-24  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1980
1981         REGRESSION(r192053): MiniBrowser doesn't exit when clicking on the close-window button
1982         https://bugs.webkit.org/show_bug.cgi?id=151567
1983
1984         Reviewed by Darin Adler.
1985
1986         * MiniBrowser/efl/main.c: Call window_close() instead of ewk_view_try_close().
1987         (on_window_deletion):
1988
1989 2015-11-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1990
1991         [GTK] Use the network process unconditionally
1992         https://bugs.webkit.org/show_bug.cgi?id=151541
1993
1994         Reviewed by Alex Christensen.
1995
1996         Fix TestInspectorServer test. Do not assume we already have the
1997         title we want when the page has been loaded, since the title is
1998         changed afterwards. So, check if the title has already been set,
1999         and if not wait for it.
2000
2001         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
2002         (openRemoteDebuggingSession):
2003
2004 2015-11-23  Alex Christensen  <achristensen@webkit.org>
2005
2006         Fix crash in ~WebProcessPool when using Geolocation with useNetworkProcess=true
2007         https://bugs.webkit.org/show_bug.cgi?id=151532
2008
2009         Reviewed by Benjamin Poulain.
2010
2011         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
2012         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::eventsChanged):
2013         (TestWebKitAPI::TEST):
2014         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::eventsChanged):
2015         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::GeolocationTransitionToHighAccuracyStateTracker): Deleted.
2016         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::GeolocationTransitionToLowAccuracyStateTracker): Deleted.
2017         Properly load about:blank in all WebViews to clean up.  Without this change, we had a
2018         Geolocation provider stopping after its state tracker was destroyed with its stack frame,
2019         so it was calling a function on a test object that had gone out of scope.
2020         Also, call WKContextSetUsesNetworkProcess(context, true) to show what crash this fixed,
2021         but that will become the default soon and that call will be removed.
2022
2023 2015-11-22  David Kilzer  <ddkilzer@apple.com>
2024
2025         run-webkit-tests: http server for imported W3C tests doesn't work with --layout-tests-directory switch
2026         <http://webkit.org/b/151542>
2027
2028         Reviewed by Daniel Bates.
2029
2030         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2031         (base_url): Use the Port object (already passed in) to give us
2032         the path to the LayoutTests directory, which already checks for a
2033         --layout-tests-directory command-line switch.
2034         (WebPlatformTestServer.__init__): Remove layout_test_results_dir
2035         argument since we can get this from the Port object already
2036         passed in via Port.results_directory().  Also switch to use
2037         Port.layout_tests_dir() to get the LayoutTests directory.
2038
2039         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
2040         (TestWebPlatformTestServer.test_custom_layout_tests_directory):
2041         Add test case for custom LayoutTests directory.
2042         (TestWebPlatformTestServer.test_previously_spawned_instance):
2043         Update Port object to set mock results directory as if it was
2044         set on the command-line.  Remove unneeded argument from
2045         WebPlatformTestServer constructor.
2046         (TestWebPlatformTestServer.test_corrupted_subserver_files): Ditto.
2047
2048         * Scripts/webkitpy/port/base.py:
2049         (Port.to.start_web_platform_test_server): Remove unneeded
2050         argument from WebPlatformTestServer constuctor.
2051
2052 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2053
2054         [GTK] Some unit tests fail when using the network process
2055         https://bugs.webkit.org/show_bug.cgi?id=151490
2056
2057         Reviewed by Martin Robinson.
2058
2059         Run the soup server in a separate thread in TestResources test to
2060         avoid deadlocks.
2061
2062         This fixes /webkit2/WebKitWebView/sync-request-on-max-conns and
2063         /webkit2/WebKitWebResource/get-data when using the network process.
2064
2065         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2066         (beforeAll): Create the WebKitTestServer with ServerRunInThread flag.
2067         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
2068         (WebKitTestServer::WebKitTestServer): When ServerRunInThread is
2069         present, create a WorkQueue to run the server.
2070         (WebKitTestServer::run): Run the server in the work queue if it
2071         has been created.
2072         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h: Convert server
2073         type into server options as flags.
2074
2075 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2076
2077         [GTK] ImageDiff should normalize the diff image
2078         https://bugs.webkit.org/show_bug.cgi?id=151261
2079
2080         Reviewed by Sergio Villar Senin.
2081
2082         * ImageDiff/gtk/ImageDiff.cpp:
2083         (readPixbufFromStdin): Fix memory leak.
2084         (differenceImageFromDifferenceBuffer): Normalize diff buffer.
2085         (calculateDifference): Pass max distance to differenceImageFromDifferenceBuffer.
2086
2087 == Rolled over to ChangeLog-2015-11-21 ==