2ae60507ba1fe58ed650610016263a4c092205ac
[WebKit-https.git] / Tools / ChangeLog
1 2020-05-20  Kate Cheney  <katherine_cheney@apple.com>
2
3         Support operating dates in ResourceLoadStatisticsDatabaseStore
4         https://bugs.webkit.org/show_bug.cgi?id=212034
5         <rdar://problem/63349242>
6
7         Reviewed by Brent Fulgham.
8
9         Add a testing function to insert an expired statistic.
10
11         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
12         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
13         (WTR::InjectedBundle::didReceiveMessageToPage):
14         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
15         (WTR::TestRunner::setStatisticsExpiredStatistic):
16         (WTR::TestRunner::statisticsCallDidSetExpiredStatisticCallback):
17         * WebKitTestRunner/InjectedBundle/TestRunner.h:
18         * WebKitTestRunner/TestController.cpp:
19         (WTR::TestController::setStatisticsExpiredStatistic):
20         * WebKitTestRunner/TestController.h:
21         * WebKitTestRunner/TestInvocation.cpp:
22         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
23         (WTR::TestInvocation::didSetExpiredStatistic):
24         * WebKitTestRunner/TestInvocation.h:
25
26 2020-05-20  Chris Dumez  <cdumez@apple.com>
27
28         Deprecate WKBundlePageSetPolicyClient() Injected bundle C API
29         https://bugs.webkit.org/show_bug.cgi?id=212166
30
31         Reviewed by Alex Christensen.
32
33         * TestWebKitAPI/Tests/WebKitObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
34         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
35         (WTR::InjectedBundlePage::InjectedBundlePage):
36
37 2020-05-20  Myles C. Maxfield  <mmaxfield@apple.com>
38
39         [iPadOS] -webkit-text-size-adjust:percentage doesn't work in native apps
40         https://bugs.webkit.org/show_bug.cgi?id=212122
41         <rdar://problem/54560875>
42
43         Reviewed by Wenson Hsieh.
44
45         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
46         * TestWebKitAPI/Tests/WebKit/idempotent-mode-autosizing-only-honors-percentages.html: Added.
47         * TestWebKitAPI/ios/PreferredContentMode.mm:
48
49 2020-05-20  Lauro Moura  <lmoura@igalia.com>
50
51         [WPE][WebDriver] Allow subviews to create new views
52         https://bugs.webkit.org/show_bug.cgi?id=212118
53
54         Reviewed by Carlos Garcia Campos.
55
56         Required by some WebDriver tests.
57
58         * MiniBrowser/wpe/main.cpp:
59         (createWebView):
60
61 2020-05-20  Philippe Normand  <pnormand@igalia.com>
62
63         [FlatPak SDK] Missing ruby gems json and highline
64         https://bugs.webkit.org/show_bug.cgi?id=212086
65
66         Reviewed by Žan Doberšek.
67
68         Add the json and highline Ruby gems in the Flatpak SDK.
69
70         * buildstream/elements/sdk-platform.bst:
71         * buildstream/elements/sdk/ruby-highline.bst: Added.
72         * buildstream/elements/sdk/ruby-json.bst: Added.
73         * buildstream/project.conf:
74
75 2020-05-20  Diego Pino Garcia  <dpino@igalia.com>
76
77         Unreviewed, reverting r261909.
78
79         Execution of LayoutTests returns syntax error in the bots (GTK, WPE)
80
81         Reverted changeset:
82
83         "[Flatpak SDK] Add bubblewrap ... wrapper"
84         https://bugs.webkit.org/show_bug.cgi?id=212077
85         https://trac.webkit.org/changeset/261909
86
87 2020-05-20  Philippe Normand  <pnormand@igalia.com>
88
89         [Flatpak SDK] Bump rr and bst
90         https://bugs.webkit.org/show_bug.cgi?id=212074
91
92         Reviewed by Adrian Perez de Castro.
93
94         Update Buildstream to 1.4.3 which is their latest stable release. Also bump rr to their
95         latest git master commit, which makes it usable in the Flatpak sandbox.
96
97         * buildstream/Pipfile:
98         * buildstream/Pipfile.lock:
99         * buildstream/elements/sdk/rr.bst:
100
101 2020-05-20  Carlos Alberto Lopez Perez  <clopez@igalia.com>
102
103         update-test-expectations-from-bugzilla tool not working with new EWS
104         https://bugs.webkit.org/show_bug.cgi?id=210975
105
106         Reviewed by Youenn Fablet.
107
108         With the new EWS, the layout test archive results are not longer
109         posted to bugzilla as attachment. Now we need to inspect the EWS
110         server to get the status of the runs for the patch id, and then
111         query the EWS builbot server in order to get the details of each
112         run to finally obtain the URL with the zip file for the results.
113
114         The tool now automatically applies platform-specific and generic
115         results automatically (its not longer needed to specify whether
116         the result its generic or not). It uses mac-wk2 results as generic.
117
118         Also now it updates the test results for tests where the result
119         is MISSING.
120
121         * Scripts/webkitpy/common/net/bugzilla/test_expectation_updater.py:
122         (configure_logging):
123         (argument_parser):
124         (TestExpectationUpdater.__init__):
125         (TestExpectationUpdater._platform_name):
126         (TestExpectationUpdater):
127         (TestExpectationUpdater._get_layout_tests_run):
128         (TestExpectationUpdater._lookup_ews_results):
129         (TestExpectationUpdater._tests_to_update):
130         (TestExpectationUpdater._update_for_generic_bot):
131         (TestExpectationUpdater._update_for_platform_specific_bot):
132         (TestExpectationUpdater.do_update):
133         (main):
134         * Scripts/webkitpy/common/net/bugzilla/test_expectation_updater_unittest.py:
135         (MockAttachment.__init__):
136         (MockAttachment.is_patch):
137         (MockAttachment):
138         (MockAttachment.is_obsolete):
139         (MockBugzilla):
140         (MockBugzilla.attachments):
141         (MockRequests):
142         (MockRequests.__init__):
143         (MockRequests.get):
144         (MockRequests.content):
145         (MockRequests.text):
146         (MockZip.__init__):
147         (TestExpectationUpdaterTest.test_update_test_expectations):
148
149 2020-05-20  Carlos Garcia Campos  <cgarcia@igalia.com>
150
151         Unreviewed. Fix GTK4 build with GTK 3.98.4
152
153         * MiniBrowser/gtk/BrowserTab.c:
154         (loadChanged):
155         (browserTabConstructed):
156         * MiniBrowser/gtk/BrowserWindow.c:
157         (webViewClose):
158         (browserWindowSetupToolbarItem):
159         (browser_window_init):
160
161 2020-05-20  Sam Weinig  <weinig@apple.com>
162
163         Remove unused Color::getHSV function
164         https://bugs.webkit.org/show_bug.cgi?id=212119
165
166         Reviewed by Simon Fraser.
167
168         * TestWebKitAPI/Tests/WebCore/ColorTests.cpp:
169         Remove tests for Color::getHSV().
170
171 2020-05-20  Philippe Normand  <pnormand@igalia.com>
172
173         [Flatpak SDK] Add bubblewrap ... wrapper
174         https://bugs.webkit.org/show_bug.cgi?id=212077
175
176         Reviewed by Carlos Alberto Lopez Perez.
177
178         The bind-mounts are now handled through webkit-bwrap.
179
180         * flatpak/flatpakutils.py:
181         (WebkitFlatpak.execute_command):
182         (WebkitFlatpak.run_in_sandbox):
183         * flatpak/webkit-bwrap: Added.
184
185 2020-05-19  Darin Adler  <darin@apple.com>
186
187         REGRESSION (r259930): Dictation marker at start of text is removed when added trailing whitespace is collapsed
188         https://bugs.webkit.org/show_bug.cgi?id=212093
189
190         Reviewed by Daniel Bates.
191
192         * TestWebKitAPI/Tests/WebKitCocoa/InsertTextAlternatives.mm:
193         (TestWebKitAPI::TEST): Expect success rather than failure.
194
195 2020-05-19  Alex Christensen  <achristensen@webkit.org>
196
197         Add _WKDownloadDelegate callback including totalBytesWritten
198         https://bugs.webkit.org/show_bug.cgi?id=212110
199         <rdar://problem/63358981>
200
201         Reviewed by Geoffrey Garen.
202
203         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
204         (TEST):
205         * TestWebKitAPI/cocoa/TestDownloadDelegate.h:
206         * TestWebKitAPI/cocoa/TestDownloadDelegate.mm:
207         (-[TestDownloadDelegate _download:didWriteData:totalBytesWritten:totalBytesExpectedToWrite:]):
208         (-[TestDownloadDelegate _download:didReceiveData:]): Deleted.
209
210 2020-05-19  Daniel Bates  <dabates@apple.com>
211
212         Blue dotted underline with alternatives only shown for last word, gets lost for previous insertions
213         https://bugs.webkit.org/show_bug.cgi?id=212097
214         <rdar://problem/61913405>
215
216         Reviewed by Darin Adler.
217
218         Add tests. As I was writing them I discovered a few bugs in the existing code:
219                 1. <https://webkit.org/b/212093> REGRESSION (r259930): Dictation marker at start of text is removed when added trailing whitespace is collapsed
220                 2. <https://webkit.org/b/212098> Inserting a no-break space before or after a marker removes the marker
221
222         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
223         * TestWebKitAPI/Tests/WebKitCocoa/InsertTextAlternatives.mm: Added.
224         (TestWebKitAPI::TEST):
225         (TestWebKitAPI::makeNSStringWithCharacter): Added.
226
227 2020-05-19  Sergio Villar Senin  <svillar@igalia.com>
228
229         [WPE] Sync jhbuild to flatpak
230         https://bugs.webkit.org/show_bug.cgi?id=212087
231
232         Reviewed by Adrian Perez de Castro.
233
234         * wpe/jhbuild.modules: Updated meson, libwpe and wpebackend-fdo.
235
236 2020-05-19  Chris Dumez  <cdumez@apple.com>
237
238         Turn on ITP in TestController::resetStateToConsistentValues()
239         https://bugs.webkit.org/show_bug.cgi?id=212076
240
241         Reviewed by Darin Adler.
242
243         Turn on ITP in TestController::resetStateToConsistentValues(), in a single place
244         instead of doing it in different places depending on whether or not the session
245         is ephemeral or not. It is also important to do it in resetStateToConsistentValues()
246         instead of doing it on data store creation because there is a testRunner method
247         that allows tests to turn off ITP.
248
249         * WebKitTestRunner/TestController.cpp:
250         (WTR::TestController::generatePageConfiguration):
251         (WTR::TestController::resetStateToConsistentValues):
252         (WTR::TestController::platformAdjustContext):
253         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
254         (WTR::initializeWebViewConfiguration):
255         (WTR::TestController::platformInitializeDataStore):
256
257 2020-05-19  Lauro Moura  <lmoura@igalia.com>
258
259         [Flatpak SDK] Use items instead of iteritems to make Python 3 happier.
260
261         Rubber-stamped by Philippe Normand.
262
263         * flatpak/flatpakutils.py:
264         (WebkitFlatpak.pack_toolchain):
265
266 2020-05-19  Wenson Hsieh  <wenson_hsieh@apple.com>
267
268         [macOS] Drag and drop within a contenteditable area duplicates attachment-backed images
269         https://bugs.webkit.org/show_bug.cgi?id=212075
270         <rdar://problem/62434146>
271
272         Reviewed by Andy Estes.
273
274         Add a new API test to verify that starting a drag on an attachment-backed image in an editable container with
275         queued mouse move events does not cause the selection to collapse. See Source/WebKit/ChangeLog for more details.
276
277         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
278         * TestWebKitAPI/cocoa/TestWKWebView.h:
279         * TestWebKitAPI/cocoa/TestWKWebView.mm:
280         (-[TestWKWebView waitForPendingMouseEvents]):
281
282         Move this method from DragAndDropSimulator into TestWKWebView.
283
284         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
285         (-[DragAndDropTestWKWebView waitForPendingMouseEvents]): Deleted.
286
287 2020-05-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
288
289         [buildbot][GTK][WPE] Pass --verbose flag when running JavaScriptCore tests
290         https://bugs.webkit.org/show_bug.cgi?id=212088
291
292         Reviewed by Philippe Normand.
293
294         Pass the "--verbose" flag to run-javascriptcore-tests also for GTK and WPE.
295         Also change the way we are currently passing "--memory-limited" to make
296         it more obvious that this is needed for all Linux bots (GTK+WPE+JSCOnly).
297
298         * BuildSlaveSupport/build.webkit.org-config/steps.py:
299         (RunJavaScriptCoreTests.start):
300         (RunRemoteJavaScriptCoreTests.start):
301
302 2020-05-19  Michael Catanzaro  <mcatanzaro@gnome.org>
303
304         Fixups for r261689 "stress/array-buffer-view-watchpoint-can-be-fired-in-really-add-in-dfg.js failing on ppc64le and s390x"
305         https://bugs.webkit.org/show_bug.cgi?id=211724
306         <rdar://problem/63227393>
307
308         Reviewed by Carlos Alberto Lopez Perez.
309
310         Rewrite determineArchitectureFromELFBinary to properly handle big endian architectures.
311         Also, properly account for 32-bit PowerPC.
312
313         * Scripts/run-jsc-stress-tests:
314
315 2020-05-19  Michael Catanzaro  <mcatanzaro@gnome.org>
316
317         [GTK] Add WEBKIT_EDITING_COMMAND_PASTE_AS_PLAIN_TEXT
318         https://bugs.webkit.org/show_bug.cgi?id=212038
319
320         Reviewed by Carlos Garcia Campos.
321
322         * TestWebKitAPI/Tests/WebKitGtk/TestWebViewEditor.cpp:
323         (testWebViewEditorCutCopyPasteNonEditable):
324         (testWebViewEditorCutCopyPasteEditable):
325         (testWebViewEditorNonEditable):
326
327 2020-05-18  Zan Dobersek  <zdobersek@igalia.com>
328
329         [WPE] HeadlessViewBackend should exclusively use software rasterization mode
330         https://bugs.webkit.org/show_bug.cgi?id=211982
331
332         Reviewed by Carlos Garcia Campos.
333
334         Instead of using WPEBackend-fdo's EGL mode that optionally allows the
335         GL operations to be done through software rasterization, have the
336         HeadlessViewBackend use the SHM mode which enforces this behavior.
337
338         Under the hood, the graphics library will be forced to set up and use
339         the software rasterization mechanisms, and on our side we are required
340         to properly handle SHM-backed buffers. This avoids any use of EGL or
341         GL operations inside HeadlessViewBackend, enabling to use this setup
342         in systems and environments that don't have GPUs available.
343
344         All GL-y things are pushed into the WindowViewBackend class. Inside
345         HeadlessViewBackend, the whole SHM logic requires WPEBackend-fdo APIs
346         that are part of the current 1.7 development cycle. When building
347         against older versions, HeadlessViewBackend itself remains buildable
348         but is not operational otherwise.
349
350         * WebKitTestRunner/wpe/PlatformWebViewWPE.cpp:
351         (WTR::PlatformWebView::windowSnapshotImage):
352         * wpe/backends/HeadlessViewBackend.cpp:
353         (WPEToolingBackends::HeadlessInstance::singleton):
354         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend):
355         (WPEToolingBackends::HeadlessViewBackend::~HeadlessViewBackend):
356         (WPEToolingBackends::HeadlessViewBackend::backend const):
357         (WPEToolingBackends::HeadlessViewBackend::snapshot):
358         (WPEToolingBackends::HeadlessViewBackend::updateSnapshot):
359         (WPEToolingBackends::HeadlessViewBackend::vsync):
360         (): Deleted.
361         (WPEToolingBackends::HeadlessEGLConnection::singleton): Deleted.
362         (WPEToolingBackends::HeadlessViewBackend::createSnapshot): Deleted.
363         (WPEToolingBackends::HeadlessViewBackend::createEGLSnapshot): Deleted.
364         (WPEToolingBackends::HeadlessViewBackend::createSHMSnapshot): Deleted.
365         (WPEToolingBackends::HeadlessViewBackend::performUpdate): Deleted.
366         (WPEToolingBackends::HeadlessViewBackend::displayBuffer): Deleted.
367         * wpe/backends/HeadlessViewBackend.h:
368         * wpe/backends/ViewBackend.cpp:
369         (WPEToolingBackends::ViewBackend::initialize): Deleted.
370         (WPEToolingBackends::ViewBackend::deinitialize): Deleted.
371         (WPEToolingBackends::ViewBackend::backend const): Deleted.
372         * wpe/backends/ViewBackend.h:
373         * wpe/backends/WindowViewBackend.cpp:
374         (WPEToolingBackends::WindowViewBackend::backend const):
375         (WPEToolingBackends::WindowViewBackend::initialize):
376         (WPEToolingBackends::WindowViewBackend::deinitialize):
377         * wpe/backends/WindowViewBackend.h:
378
379 2020-05-18  Zan Dobersek  <zdobersek@igalia.com>
380
381         [WPE] Disable modern media controls for testing
382         https://bugs.webkit.org/show_bug.cgi?id=212023
383
384         Reviewed by Philippe Normand.
385
386         * WebKitTestRunner/wpe/TestControllerWPE.cpp:
387         (WTR::TestController::updatePlatformSpecificTestOptionsForTest const):
388         Since using the same Adwaita-based media controls as the GTK port, WPE
389         too should disable modern media controls during testing by overriding
390         the default value. This fixes a couple of obscure crashes in text track
391         tests.
392
393 2020-05-18  Christopher Reid  <chris.reid@sony.com>
394
395         [WinCairo] WKTR WebsiteDataStore is being overwritten by the default one
396         https://bugs.webkit.org/show_bug.cgi?id=212044
397
398         Reviewed by Fujii Hironori.
399
400         Ensure TestController::defaultWebSiteDataStore is being used for WinCairo as done in r259705.
401
402         Also consolidate platformInitializeDataStore implementations with GTK/WPE since WinCairo WKTR
403         also started crashing since r261758.
404
405         * WebKitTestRunner/TestController.cpp:
406         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
407         * WebKitTestRunner/wpe/TestControllerWPE.cpp:
408
409 2020-05-18  Andy Estes  <aestes@apple.com>
410
411         http/tests/ssl/applepay/ApplePayInstallmentConfiguration.https.html fails in public SDK builds
412         https://bugs.webkit.org/show_bug.cgi?id=212000
413         <rdar://problem/63323082>
414
415         Reviewed by Youenn Fablet.
416
417         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
418
419 2020-05-18  Wenson Hsieh  <wenson_hsieh@apple.com>
420
421         Replace uses of +self with +class
422         https://bugs.webkit.org/show_bug.cgi?id=212041
423
424         Reviewed by Darin Adler.
425
426         * DumpRenderTree/mac/EventSendingController.mm:
427         (-[EventSendingController monitorWheelEventsWithOptions:]):
428         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
429         (TestWebKitAPI::TEST):
430         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
431         (WTR::enclosingScrollViewIncludingSelf):
432
433 2020-05-18  Simon Fraser  <simon.fraser@apple.com>
434
435         Implement conversion between P3 and sRGB color
436         https://bugs.webkit.org/show_bug.cgi?id=211998
437
438         Reviewed by Daniel Bates.
439
440         API test for conversions from P3 to sRGB, and linearRGB to sRGB. Values were confirmed
441         as close to those provided by ColorSync Utility.
442
443         * TestWebKitAPI/Tests/WebCore/ExtendedColorTests.cpp:
444         (TestWebKitAPI::TEST):
445
446 2020-05-18  Mark Lam  <mark.lam@apple.com>
447
448         Implement a faster findBitInWord() using the hardware ctz instruction.
449         https://bugs.webkit.org/show_bug.cgi?id=212032
450         <rdar://problem/63348086>
451
452         Reviewed by Saam Barati.
453
454         Add tests to make sure that the ctz implementation matches the loop implementation
455         in behavior.
456
457         * TestWebKitAPI/CMakeLists.txt:
458         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
459         * TestWebKitAPI/Tests/WTF/StdLibExtras.cpp: Added.
460         (TestWebKitAPI::testFindBitInWord):
461         (TestWebKitAPI::TEST):
462
463 2020-05-18  Wenson Hsieh  <wenson_hsieh@apple.com>
464
465         Allow clipboard API access when pasting from a menu item or key binding
466         https://bugs.webkit.org/show_bug.cgi?id=211990
467         <rdar://problem/63308916>
468
469         Reviewed by Megan Gardner.
470
471         Add a UIScriptController method to trigger a paste from the application process.
472
473         * DumpRenderTree/cocoa/UIScriptControllerCocoa.h:
474         * DumpRenderTree/cocoa/UIScriptControllerCocoa.mm:
475         (WTR::UIScriptControllerCocoa::paste):
476         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
477         * TestRunnerShared/UIScriptContext/UIScriptController.h:
478         (WTR::UIScriptController::paste):
479         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.h:
480         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm:
481         (WTR::UIScriptControllerCocoa::paste):
482
483 2020-05-18  Darin Adler  <darin@apple.com>
484
485         Add iterator checking to ListHashSet
486         https://bugs.webkit.org/show_bug.cgi?id=211669
487
488         Reviewed by Anders Carlsson.
489
490         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp: Removed use of the DID_CREATE_WEAK_PTR_IMPL
491         and WILL_DESTROY_WEAK_PTR_IMPL, which didn't work consistently because of the
492         one-definition rule. Instead, this file parameterizes the WeakPtr family of
493         class templates with a counter class. To avoid having to rewrite test code, used
494         alias templates to insert these class template into the TestWebKitAPI namespace,
495         hiding the class templates from the WTF namespace.
496
497 2020-05-18  Peng Liu  <peng.liu6@apple.com>
498
499         [iPad Simulator] TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia is timing out
500         https://bugs.webkit.org/show_bug.cgi?id=211792
501
502         Reviewed by Daniel Bates.
503
504         Fix deadlocks in two API tests (only reproducible on iPad simulators).
505
506         * TestWebKitAPI/Tests/WebKitLegacy/ios/PreemptVideoFullscreen.mm:
507         (TestWebKitAPI::TEST):
508         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
509         (TestWebKitAPI::TEST):
510
511 2020-05-18  Wenson Hsieh  <wenson_hsieh@apple.com>
512
513         Single selection <select> with <optgroups> shows multiple selected options
514         https://bugs.webkit.org/show_bug.cgi?id=199485
515         <rdar://problem/52757531>
516
517         Reviewed by Megan Gardner.
518
519         Add a new helper method to check whether the currently presented form accessory is a select menu, and has a
520         checked menu item at the given row.
521
522         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
523         * TestRunnerShared/UIScriptContext/UIScriptController.h:
524         (WTR::UIScriptController::selectFormAccessoryHasCheckedItemAtRow const):
525         * WebKitTestRunner/ios/UIScriptControllerIOS.h:
526         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
527         (WTR::UIScriptControllerIOS::selectFormAccessoryHasCheckedItemAtRow const):
528
529 2020-05-18  Wenson Hsieh  <wenson_hsieh@apple.com>
530
531         [iOS] Unexpected capitalization of next word after repositioning caret
532         https://bugs.webkit.org/show_bug.cgi?id=211969
533         <rdar://problem/62605526>
534
535         Reviewed by Alex Christensen.
536
537         Add a new UIScriptController hook to query whether or not the software keyboard is in shifted state.
538
539         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
540         * TestRunnerShared/UIScriptContext/UIScriptController.h:
541         (WTR::UIScriptController::keyboardIsAutomaticallyShifted const):
542         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
543
544         Adjust a couple of API tests that copy and paste back-to-back, so that they wait for the copy to finish before
545         attempting to paste.
546
547         * WebKitTestRunner/ios/UIScriptControllerIOS.h:
548         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
549         (WTR::UIScriptControllerIOS::keyboardIsAutomaticallyShifted const):
550
551 2020-05-18  Carlos Garcia Campos  <cgarcia@igalia.com>
552
553         [GTK] Add WebKitContextMenuItemType for paste as plaintext
554         https://bugs.webkit.org/show_bug.cgi?id=177638
555
556         Reviewed by Michael Catanzaro.
557
558         Update default context menu test case to also test the context menu for rich editable content.
559
560         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
561         (prepareContextMenuTestView):
562         (testContextMenuDefaultMenu):
563
564 2020-05-17  Simon Fraser  <simon.fraser@apple.com>
565
566         Fix operator== and hash() for ExtendedColor
567         https://bugs.webkit.org/show_bug.cgi?id=211993
568
569         Reviewed by Sam Weinig.
570
571         * TestWebKitAPI/Tests/WebCore/ExtendedColorTests.cpp:
572         (TestWebKitAPI::TEST):
573
574 2020-05-16  Simon Fraser  <simon.fraser@apple.com>
575
576         Rename some API test files
577         https://bugs.webkit.org/show_bug.cgi?id=211992
578
579         Reviewed by Zalan Bujtas.
580
581         I'm tired of Quick Open of Color.cpp opening the test file rather than the one I want.
582
583         * TestWebKitAPI/CMakeLists.txt:
584         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
585         * TestWebKitAPI/Tests/WebCore/ColorTests.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/Color.cpp.
586         * TestWebKitAPI/Tests/WebCore/ExtendedColorTests.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ExtendedColor.cpp.
587         * TestWebKitAPI/Tests/WebCore/FloatPointTests.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FloatPoint.cpp.
588         * TestWebKitAPI/Tests/WebCore/FloatRectTests.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FloatRect.cpp.
589         * TestWebKitAPI/Tests/WebCore/FloatSizeTests.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FloatSize.cpp.
590         * TestWebKitAPI/Tests/WebCore/IntPointTests.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/IntPoint.cpp.
591         * TestWebKitAPI/Tests/WebCore/IntRectTests.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/IntRect.cpp.
592         * TestWebKitAPI/Tests/WebCore/IntSizeTests.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/IntSize.cpp.
593         * TestWebKitAPI/Tests/WebCore/LayoutUnitTests.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp.
594
595 2020-05-15  Lauro Moura  <lmoura@igalia.com>
596
597         [GTK][WPE] Add default initialization of WebsiteDataStore to WebKitTestRunner after r261758
598         https://bugs.webkit.org/show_bug.cgi?id=211977
599
600         As GTK/WPE does not explicitly create WebSiteDataStore for the tests,
601         assign the default one.
602
603         Not sure if this is the correct fix, but should allow running tests
604         again.
605
606         Reviewed by Žan Doberšek.
607
608         * WebKitTestRunner/TestController.cpp: Add GTK/WPE guards.
609         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
610         (WTR::TestController::platformInitializeDataStore): Use default
611         WebsiteDataStore.
612         * WebKitTestRunner/wpe/TestControllerWPE.cpp:
613         (WTR::TestController::platformInitializeDataStore): Use default
614         websiteDataStore.
615
616 2020-05-15  Alex Christensen  <achristensen@webkit.org>
617
618         Use enum serialization instead of casting to/from uint32_t
619         https://bugs.webkit.org/show_bug.cgi?id=211885
620
621         Reviewed by Geoffrey Garen.
622
623         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
624         (AccessibilityUIElement::increaseTextSelection):
625         (AccessibilityUIElement::decreaseTextSelection):
626         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
627         (WTR::AccessibilityUIElement::increaseTextSelection):
628         (WTR::AccessibilityUIElement::decreaseTextSelection):
629
630 2020-05-15  Ryan Haddad  <ryanhaddad@apple.com>
631
632         [iOS EWS] TestWebKitAPI.WKWebsiteDataStore.RemoveAndFetchData is failing
633         https://bugs.webkit.org/show_bug.cgi?id=208451
634
635         Unreviewed test gardening.
636
637         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
638         (TestWebKitAPI::TEST): Re-enable the test for iOS.
639
640 2020-05-15  Geoffrey Garen  <ggaren@apple.com>
641
642         Update Sihui Liu's status to reviewer
643         https://bugs.webkit.org/show_bug.cgi?id=211966
644
645         Reviewed by Per Arne Vollan.
646
647         See email thread on webkit-reviewers on 5/7, "Reviewer nomination:
648         Sihui Liu".
649
650         * Scripts/webkitpy/common/config/contributors.json:
651
652 2020-05-15  Alex Christensen  <achristensen@webkit.org>
653
654         TestWebKitAPI.WKHTTPCookieStore.Basic is a flaky failure
655         https://bugs.webkit.org/show_bug.cgi?id=211752
656
657         Reviewed by Geoffrey Garen.
658
659         The ordering of cookiesDidChangeInCookieStore callbacks with regard to other callbacks isn't quite deterministic.
660         No problem.  If the number of callbacks isn't what it is expected, wait until it is.
661         When I reproduce this test failure, I need to spin the run loop at max once to have it succeed, but the bots may take a few more run loop spins.
662         Spin until the number of callbacks is the expected value.
663
664         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
665         (runTestWithWebsiteDataStore):
666
667 2020-05-15  Alex Christensen  <achristensen@webkit.org>
668
669         [iOS Simulator] TestWebKitAPI._WKDownload.Resume is a flaky crash
670         https://bugs.webkit.org/show_bug.cgi?id=211786
671
672         Reviewed by Geoffrey Garen.
673
674         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
675         (TEST):
676         Add a short sleep (<1/10s) to make this test so it would've almost always failed without this fix.
677         Checking the file immediately usually succeeded, but waiting a few run loop iterations revealed that CFNetwork
678         was deleting resumed then finished downloads.
679
680 2020-05-15  Alex Christensen  <achristensen@webkit.org>
681
682         Regression (iOS 13.4, r249142): WKWebView.loading is never reset after a Back navigation in an iframe
683         https://bugs.webkit.org/show_bug.cgi?id=211449
684
685         Reviewed by Geoffrey Garen.
686
687         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
688         (-[LoadingObserver changesObserved]):
689         (-[LoadingObserver observeValueForKeyPath:ofObject:change:context:]):
690         (TEST):
691
692 2020-05-15  Chris Dumez  <cdumez@apple.com>
693
694         Make sure we use current data store in WKTR's TestController
695         https://bugs.webkit.org/show_bug.cgi?id=211920
696
697         Reviewed by Alex Christensen.
698
699         Make sure we use current data store in WKTR's TestController. Currently, a lot of code
700         uses defaultDataStore(), even though the test may be using another data store (e.g. an
701         ephemeral one). I suspect this is contributing to test flakiness.
702
703         We now also make sure that TestController::websiteDataStore() returns the actual store
704         that will be used by the test when resetPreferencesToConsistentValues() is called.
705         Previously, it would not since it would get the store from the m_mainView and m_mainView
706         would only get initialized after calling resetPreferencesToConsistentValues(). To support
707         this, we now initialize a m_websiteDataStore member in platformInitializeDataStore(),
708         which gets called right before resetPreferencesToConsistentValues(). When
709         platformCreateWebView() gets called right after resetPreferencesToConsistentValues(),
710         it now simply relies on m_websiteDataStore instead of creating the data store at this
711         point.
712
713         * WebKitTestRunner/TestController.cpp:
714         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
715         (WTR::TestController::clearServiceWorkerRegistrations):
716         (WTR::TestController::clearDOMCache):
717         (WTR::TestController::clearDOMCaches):
718         (WTR::TestController::hasDOMCache):
719         (WTR::TestController::domCacheSize):
720         (WTR::TestController::clearStatisticsDataForDomain):
721         * WebKitTestRunner/TestInvocation.cpp:
722         (WTR::TestInvocation::invoke):
723         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
724
725 2020-05-15  Diego Pino Garcia  <dpino@igalia.com>
726
727         [buildbot] Increase blocksize of file transfer in UploadTestResults step
728         https://bugs.webkit.org/show_bug.cgi?id=211847
729
730         Reviewed by Aakash Jain.
731
732         All other steps involving file transfer uploads use 256kb as block
733         size. Make this step in line with others.
734
735         * BuildSlaveSupport/build.webkit.org-config/steps.py:
736         (UploadTestResults.__init__):
737
738 2020-05-15  Adrian Perez de Castro  <aperez@igalia.com>
739
740         [GTK3] Bring back usage of GtkMenu for context menus
741         https://bugs.webkit.org/show_bug.cgi?id=211557
742
743         Reviewed by Carlos Garcia Campos.
744
745         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp: Add preprocessor conditionals
746         for GTK4 and bring back some bits previously removed in r260889 for GTK3.
747
748 2020-05-14  Kate Cheney  <katherine_cheney@apple.com>
749
750         Attribute non-network loads and loads with html strings as automatically app-bound
751         https://bugs.webkit.org/show_bug.cgi?id=211913
752         <rdar://problem/63157801
753
754         Reviewed by Brent Fulgham.
755
756         Adds new tests to check that WebView loads with HTML strings have
757         proper behavior.
758
759         Some tests need to test behavior on app-bound domains on webviews which do not specify
760         limitsNavigationsToAppBoundDomains. Since local files now do this
761         automatically, this patch updates those to use actual app-bound
762         domains from the WKAppBoundDomains list instead to maintain behavior.
763
764         Remove limitsNavigationsToAppBoundDomains for local files to make sure
765         they are forced into this mode automatically.
766
767         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
768         (-[InAppBrowserSchemeHandler webView:startURLSchemeTask:]):
769         (TEST):
770
771 2020-05-14  Jiewen Tan  <jiewen_tan@apple.com>
772
773         [WebAuthn] Relaxing signature length requirements for U2fRegister
774         https://bugs.webkit.org/show_bug.cgi?id=209645
775         <rdar://problem/63204591>
776
777         Reviewed by Brent Fulgham.
778
779         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
780         (TestWebKitAPI::TEST):
781
782 2020-05-14  Jonathan Bedard  <jbedard@apple.com>
783
784         run-webkit-tests shouldn't need Xcode to run Mac tests
785         https://bugs.webkit.org/show_bug.cgi?id=211903
786         <rdar://problem/63205839>
787
788         Reviewed by Stephanie Lewis.
789
790         * Scripts/webkitpy/common/system/platforminfo.py:
791         (PlatformInfo):
792         (PlatformInfo.xcode_sdk_version): Memoize SDK version retrieval.
793         (PlatformInfo.xcode_version): Only run xcodebuild if macosx SDK is present.
794         (PlatformInfo.available_sdks): Ditto.
795         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
796         (TestPlatformInfo.test_available_sdks):
797
798 2020-05-14  Daniel Bates  <dabates@apple.com>
799
800         Include LocalOverrides.xcconfig in all Tools projects
801         https://bugs.webkit.org/show_bug.cgi?id=211789
802
803         Reviewed by Dan Bernstein.
804
805         Matches what is done for all Source projects so as to support local overriding of configs.
806
807         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
808         * MiniBrowser/Configurations/DebugRelease.xcconfig:
809         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig:
810         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
811         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
812
813 2020-05-14  Andres Gonzalez  <andresg_22@apple.com>
814
815         Fix for crashes in LayoutTests related to TextMarkers in isolated tree mode.
816         https://bugs.webkit.org/show_bug.cgi?id=211912
817
818         Reviewed by Chris Fleizach.
819
820         Check for null pointer parameters before dereferencing.
821
822         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
823         (WTR::misspellingSearchParameterizedAttributeForCriteria):
824         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
825         (WTR::AccessibilityUIElement::textMarkerRangeLength):
826         (WTR::AccessibilityUIElement::previousTextMarker):
827         (WTR::AccessibilityUIElement::nextTextMarker):
828         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
829         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
830         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
831         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
832         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
833         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRange):
834         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions):
835         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
836         (WTR::AccessibilityUIElement::indexForTextMarker):
837         (WTR::AccessibilityUIElement::isTextMarkerValid):
838         (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
839         (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
840         (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
841         (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
842         (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
843         (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
844         (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
845         (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
846         (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
847         (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
848
849 2020-05-14  Michael Catanzaro  <mcatanzaro@gnome.org>
850
851         stress/array-buffer-view-watchpoint-can-be-fired-in-really-add-in-dfg.js failing on ppc64le and s390x
852         https://bugs.webkit.org/show_bug.cgi?id=211724
853
854         Reviewed by Carlos Alberto Lopez Perez.
855
856         Add architecture detection for PowerPC and S/390.
857
858         * Scripts/run-jsc-stress-tests:
859
860 2020-05-14  Philippe Normand  <pnormand@igalia.com>
861
862         [WPE] Tools/wpe/install-dependencies fails due to missing pipenv
863         https://bugs.webkit.org/show_bug.cgi?id=211849
864
865         Reviewed by Žan Doberšek.
866
867         Ubuntu Bionic doesn't ship pipenv. So fallback to the pip3 install path. Also remove the
868         libpng12-dev fallback, this doesn't seem necessary any longer (tested on a Ubuntu Bionic
869         docker).
870
871         * gtk/install-dependencies:
872         * wpe/install-dependencies:
873
874 2020-05-14  Philippe Normand  <pnormand@igalia.com>
875
876         [Flatpak SDK] Path references shouldn't point to the sandbox in compile_commands.json
877         https://bugs.webkit.org/show_bug.cgi?id=209901
878
879         Reviewed by Žan Doberšek.
880
881         Add ccls to the SDK. It can then be used through a wrapper script by Emacs's lsp-mode.
882         
883         * buildstream/elements/sdk-build-depends/rapidjson.bst: Added.
884         * buildstream/elements/sdk-platform.bst:
885         * buildstream/elements/sdk/ccls.bst: Added.
886
887 2020-05-13  Jer Noble  <jer.noble@apple.com>
888
889         Replace isNullFunctionPointer with real weak-linking support
890         https://bugs.webkit.org/show_bug.cgi?id=211751
891
892         Reviewed by Sam Weinig.
893
894         * TestWebKitAPI/Tests/WTF/darwin/WeakLinking.cpp:
895         (TestWebKitAPI::TEST):
896         * TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-iOS-v2.tbd:
897         * TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-iOS.tbd:
898         * TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-macOS-v2.tbd:
899         * TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-macOS.tbd:
900
901 2020-05-13  Tim Horton  <timothy_horton@apple.com>
902
903         Add SPI for reverting to touch events for iPad trackpad interactions
904         https://bugs.webkit.org/show_bug.cgi?id=211824
905         <rdar://problem/61363084>
906
907         Reviewed by Megan Gardner.
908
909         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
910         * TestWebKitAPI/Tests/WebKitCocoa/iOSMouseSupport.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/MacCatalystMouseSupport.mm.
911         (-[WKTestingEvent locationInView:]):
912         (-[WKTestingEvent _setButtonMask:]):
913         (-[WKTestingEvent _buttonMask]):
914         (-[WKTestingTouch locationInView:]):
915         (-[WKTestingTouch setTapCount:]):
916         (-[WKTestingTouch tapCount]):
917         (mouseGesture):
918         (TEST):
919         Rename and enable MacCatalystMouseSupport tests for iOS.
920         Add a test that ensures that the next load after setting the
921         WKWebpagePreference causes the WKMouseGestureRecognizer to get disabled.
922
923 2020-05-13  Wenson Hsieh  <wenson_hsieh@apple.com>
924
925         [iOS] "Copy" context menu action for attachment element does not work in Mail
926         https://bugs.webkit.org/show_bug.cgi?id=211817
927         <rdar://problem/58043110>
928
929         Reviewed by Tim Horton.
930
931         Add a new iOS API test that simulates the context menu action to "copy" on an attachment element.
932
933         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
934
935 2020-05-12  Matt Lewis  <jlewis3@apple.com>
936
937         Run-webkit-tests should not fail if all tests found to run are skipped.
938         https://bugs.webkit.org/show_bug.cgi?id=210880
939
940         Reviewed by Jonathan Bedard.
941
942         * Scripts/webkitpy/layout_tests/controllers/manager.py:
943         (Manager.run): Added a check to see if we skiped all tests. If so We return a successful exit
944         code as we performed as expected.
945         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
946         (RunDetails.__init__): Added in an additional class variable to be used as a way to record an
947         all skipped result check.
948         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
949         (main): Added a all test skipped check and we return early with the exit code.
950         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Added a new test and removed the old
951         ones that no longer test the correct functionality.
952         (RunTest.test_all_tests_skipped):
953         (RunTest.test_no_tests_found): Deleted.
954         (RunTest.test_no_tests_found_2): Deleted.
955
956 2020-05-13  Kate Cheney  <katherine_cheney@apple.com>
957
958         Add test for non-app-bound iframe under app-bound domain
959         https://bugs.webkit.org/show_bug.cgi?id=211815
960         <rdar://problem/63159707>
961
962         Reviewed by Brent Fulgham.
963
964         Clear the main frame app-bound session before loading the iframe so
965         we can be sure the iframe uses an app-bound session.
966
967         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
968         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
969         (WTR::TestRunner::clearAppBoundSession):
970         * WebKitTestRunner/InjectedBundle/TestRunner.h:
971         * WebKitTestRunner/TestInvocation.cpp:
972         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
973
974 2020-05-13  Philippe Normand  <pnormand@igalia.com>
975
976         [Flatpak SDK] Proper handling of sccache scheduler URL command-line argument
977
978         Rubber-stamped by Carlos Alberto Lopez Perez.
979
980         * flatpak/flatpakutils.py:
981         (WebkitFlatpak.load_from_args):
982         (WebkitFlatpak.__init__):
983
984 2020-05-13  Philippe Normand  <pnormand@igalia.com>
985
986         [Flatpak SDK] Craft a custom sccache config file from SDK toolchains
987         https://bugs.webkit.org/show_bug.cgi?id=211781
988
989         Reviewed by Carlos Alberto Lopez Perez.
990
991         Optionally generate a sccache config file and use it when building WebKit.
992
993         * Scripts/webkitpy/thirdparty/__init__.py:
994         (AutoinstallImportHook.find_module):
995         (AutoinstallImportHook._install_toml):
996         * flatpak/flatpakutils.py:
997         (WebkitFlatpak.load_from_args):
998         (WebkitFlatpak.__init__):
999         (WebkitFlatpak.clean_args):
1000         (WebkitFlatpak.host_path_to_sandbox_path):
1001         (WebkitFlatpak.run_in_sandbox):
1002         (WebkitFlatpak.main):
1003         (WebkitFlatpak.save_config):
1004         (WebkitFlatpak):
1005         (WebkitFlatpak.pack_toolchain):
1006         (WebkitFlatpak.setup_icecc): Deleted.
1007
1008 2020-05-13  Víctor Manuel Jáquez Leal  <vjaquez@igalia.com>
1009
1010         [Flatpak] *PROCESS_CMD_PREFIX are ignored
1011         https://bugs.webkit.org/show_bug.cgi?id=211830
1012
1013         Reviewed by Philippe Normand.
1014
1015         Checking the last slice of the splitted environment variable won't
1016         match with any of the list of suffixes since they are composed by
1017         several slices if they are splitted too.
1018
1019         A new internal function is defined where the suffixes list is
1020         traversed and matched with the end of the passend enviroment
1021         variable.
1022
1023         * flatpak/flatpakutils.py:
1024         (WebkitFlatpak.run_in_sandbox.envvar_in_suffixes_to_keep):
1025         (WebkitFlatpak.run_in_sandbox):
1026
1027 2020-05-12  Alex Christensen  <achristensen@webkit.org>
1028
1029         [iOS Simulator] TestWebKitAPI._WKDownload.Resume is a flaky crash
1030         https://bugs.webkit.org/show_bug.cgi?id=211786
1031
1032         Reviewed by Darin Adler.
1033
1034         This should turn the test crash into a failure, which is a step in the right direction.
1035         Still investigating...
1036
1037         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1038         (TEST):
1039
1040 2020-05-12  Ryan Haddad  <ryanhaddad@apple.com>
1041
1042         [iOS] TestWTF.WTF_Lock.ContendedShortSection is consistently timing out on debug
1043         https://bugs.webkit.org/show_bug.cgi?id=211650
1044
1045         Unreviewed test gardening.
1046
1047         * TestWebKitAPI/Tests/WTF/Lock.cpp: Skip the test for iOS Debug queues.
1048
1049 2020-05-12  Philippe Normand  <pnormand@igalia.com>
1050
1051         [FlatPak SDK] Some packages in the SDK have missing debug symbols
1052         https://bugs.webkit.org/show_bug.cgi?id=211621
1053
1054         Reviewed by Carlos Alberto Lopez Perez.
1055
1056         * flatpak/flatpakutils.py:
1057         (WebkitFlatpak._get_packages): Unconditionally install SDK Debug symbols, even for Release
1058         builds. This should help improve the crash reports on the bots.
1059
1060 2020-05-12  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1061
1062         WPT test importer fails to update references in <link> tags
1063         https://bugs.webkit.org/show_bug.cgi?id=211762
1064
1065         Reviewed by Youenn Fablet.
1066
1067         When importing WPT test references, ensure relative paths are also
1068         updated for the href attribute in <link> tags.
1069         Also fix a bug that was causing wrong updates on the paths due to
1070         the characters in reference_relpath not escaped when performing
1071         the regex substitution in convert_reference_relpaths(). For example:
1072         "resources/script.js" was changed to "resourcscript.js" when reference_relpath was '../'
1073
1074         Improve also the unit test case to check for the fixes in this patch.
1075
1076         * Scripts/webkitpy/w3c/test_converter.py:
1077         (_W3CTestConverter.convert_reference_relpaths):
1078         (_W3CTestConverter.convert_attributes_if_needed):
1079         * Scripts/webkitpy/w3c/test_converter_unittest.py:
1080
1081 2020-05-12  Philippe Normand  <pnormand@igalia.com>
1082
1083         [Flatpak SDK] Include clang++ and g++ in toolchains
1084         https://bugs.webkit.org/show_bug.cgi?id=211663
1085
1086         Reviewed by Adrian Perez de Castro.
1087
1088         /usr/bin/clang++ wasn't included before. Also a small unrelated drive-by, white-list RUST
1089         env vars, such as RUST_LOG, useful when debugging sccache.
1090
1091         * flatpak/flatpakutils.py:
1092         (WebkitFlatpak.run_in_sandbox):
1093         (WebkitFlatpak.main):
1094         (WebkitFlatpak.setup_icecc):
1095
1096 2020-05-11  Simon Fraser  <simon.fraser@apple.com>
1097
1098         [ macOS ] scrollingcoordinator/mac/latching/scrolling-select-should-not-latch-mainframe.html is a flaky failure
1099         https://bugs.webkit.org/show_bug.cgi?id=211747
1100
1101         Reviewed by Tim Horton.
1102
1103         Add an option to monitorWheelEvents to reset latching.
1104
1105         * DumpRenderTree/mac/EventSendingController.mm:
1106         (+[EventSendingController isSelectorExcludedFromWebScript:]):
1107         (+[EventSendingController webScriptNameForSelector:]):
1108         (-[EventSendingController monitorWheelEventsWithOptions:]):
1109         (-[EventSendingController monitorWheelEvents]): Deleted.
1110         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1111         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1112         (WTR::toMonitorWheelEventsOptions): We have to return a pointer to a static, because the generated code
1113         doesn't use smart pointers.
1114         (WTR::EventSendingController::monitorWheelEvents):
1115         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1116         (WTR::MonitorWheelEventsOptions::MonitorWheelEventsOptions):
1117
1118 2020-05-11  Kate Cheney  <katherine_cheney@apple.com>
1119
1120         Fail navigations to non app-bound domains after use of app-bound APIs
1121         https://bugs.webkit.org/show_bug.cgi?id=211647
1122         <rdar://problem/62978159>
1123
1124         Reviewed by Brent Fulgham.
1125
1126         Added a new test to confirm a non-app bound navigation fails after
1127         using script injection.
1128
1129         This fix also required changing any test which uses a restricted API
1130         to confirm behavior of another restricted API. Tests can set
1131         _setNeedsInAppBrowserPrivacyQuirks in the configuration to indicate
1132         APIs should not be blocked, then toggle it to test actual behavior.
1133
1134         Also, we can remove any calls to _setInAppBrowserPrivacyEnabled
1135         now that this is just an internal test flag. 
1136
1137         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
1138         (-[AppBoundDomainDelegate webView:didFinishNavigation:]):
1139         (-[AppBoundDomainDelegate webView:didFailProvisionalNavigation:withError:]):
1140         (-[AppBoundDomainDelegate waitForDidFinishNavigation]):
1141         (-[AppBoundDomainDelegate waitForDidFailProvisionalNavigationError]):
1142         (TEST):
1143
1144 2020-05-11  Alex Christensen  <achristensen@webkit.org>
1145
1146         Add some logs to diagnose why WebKitLegacy.CrossPartitionFileSchemeAccess API test times out in EWS
1147         https://bugs.webkit.org/show_bug.cgi?id=211738
1148
1149         Reviewed by Darin Adler.
1150
1151         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm:
1152         (TestWebKitAPI::TEST):
1153         I saw an instance of failing to make a partition because the "file" already existed.
1154         Try cleaning up anything left from last time this test timed out to prevent it from timing out again.
1155
1156 2020-05-11  Alex Christensen  <achristensen@webkit.org>
1157
1158         Add some logs to diagnose why WebKitLegacy.CrossPartitionFileSchemeAccess API test times out in EWS
1159         https://bugs.webkit.org/show_bug.cgi?id=211738
1160
1161         Reviewed by Mark Lam.
1162
1163         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm:
1164         (TestWebKitAPI::TEST):
1165
1166 2020-05-11  Andres Gonzalez  <andresg_22@apple.com>
1167
1168         Add mechanism to turn on accessibility isolated tree mode from WebKitTestRunner.
1169         https://bugs.webkit.org/show_bug.cgi?id=211725
1170
1171         Reviewed by Chris Fleizach.
1172
1173         Turn on isolated tree mode when appropriate.
1174
1175         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
1176         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1177         (WTR::AccessibilityController::updateIsolatedTreeMode):
1178
1179 2020-05-11  Per Arne Vollan  <pvollan@apple.com>
1180
1181         Unreviewed, reverting r261296.
1182
1183         Rolling r260769 back in, since this was not causing a
1184         regression.
1185
1186         Reverted changeset:
1187
1188         "Unreviewed, reverting r260769."
1189         https://bugs.webkit.org/show_bug.cgi?id=211578
1190         https://trac.webkit.org/changeset/261296
1191
1192 2020-05-11  Philippe Normand  <pnormand@igalia.com>
1193
1194         [GTK] Media and audio permission request unit tests are timing out
1195         https://bugs.webkit.org/show_bug.cgi?id=158257
1196
1197         Reviewed by Carlos Garcia Campos.
1198
1199         Fix getUserMedia glib tests. They require unsecure capture device context.
1200
1201         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1202         (testWebViewUserMediaEnumerateDevicesPermissionCheck):
1203         (testWebViewUserMediaPermissionRequests):
1204         (testWebViewAudioOnlyUserMediaPermissionRequests):
1205         * TestWebKitAPI/glib/TestExpectations.json:
1206
1207 2020-05-11  Paulo Matos  <pmatos@igalia.com>
1208
1209         Fix typo 'Detacted' -> 'Detected'
1210         https://bugs.webkit.org/show_bug.cgi?id=211715
1211
1212         Unreviewed.
1213
1214         * Scripts/run-jsc-stress-tests:
1215
1216 2020-05-10  Michael Catanzaro  <mcatanzaro@gnome.org>
1217
1218         Update user agent quirk for bankofamerica.com
1219         https://bugs.webkit.org/show_bug.cgi?id=211700
1220
1221         Reviewed by Carlos Garcia Campos.
1222
1223         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1224         (TestWebKitAPI::TEST):
1225
1226 2020-05-08  Darin Adler  <darin@apple.com>
1227
1228         Streamline MarkupAccumulator to improve efficiency a bit
1229         https://bugs.webkit.org/show_bug.cgi?id=211656
1230
1231         Reviewed by Anders Carlsson.
1232
1233         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1234         (TestWebKitAPI::TEST): Fix spellling error in the word "explicitly".
1235
1236 2020-05-08  David Kilzer  <ddkilzer@apple.com>
1237
1238         Remove empty directories from from svn.webkit.org repository
1239         <https://webkit.org/b/211644>
1240
1241         Reviewed by Darin Adler.
1242
1243         * BuildSlaveSupport/gtk: Removed.
1244         * flatpak/files: Removed.
1245         * flatpak/patches: Removed.
1246
1247 2020-05-08  Basuke Suzuki  <basuke.suzuki@sony.com>
1248
1249         [WTF] Share Linux's MemoryPressureHandler among other Unix ports
1250         https://bugs.webkit.org/show_bug.cgi?id=208955
1251
1252         Reviewed by Yusuke Suzuki.
1253
1254         Fix unneeded library dependency.
1255
1256         * TestWebKitAPI/CMakeLists.txt:
1257
1258 2020-05-08  Jonathan Bedard  <jbedard@apple.com>
1259
1260         webkitpy: 'iPhone SE' should match 'iPhone SE 1st generation'
1261         https://bugs.webkit.org/show_bug.cgi?id=211642
1262         <rdar://problems/62986242>
1263
1264         Rubber-stamped by Aakash Jain.
1265
1266         * Scripts/webkitpy/xcode/device_type.py:
1267         (DeviceType):
1268         (DeviceType.standardized_hardware_type): Strip '1st generation' from models.
1269         (DeviceType.__eq__): Use standardized hardware type.
1270         (DeviceType.__contains__): Ditto.
1271         (DeviceType.__hash__): Ditto.
1272         * Scripts/webkitpy/xcode/device_type_unittest.py:
1273         (DeviceTypeTest):
1274         (DeviceTypeTest.test_generation_matching):
1275         * Scripts/webkitpy/xcode/simulated_device.py:
1276         (SimulatedDeviceManager._get_device_identifier_for_type): Handle case where the requests model does not
1277         end with '(1st generation)', but the simctl model does.
1278         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
1279
1280 2020-05-08  Ryan Haddad  <ryanhaddad@apple.com>
1281
1282         TestWebKitAPI.WebKit.AllowsContentJavaScript fails on iPad simulator
1283         https://bugs.webkit.org/show_bug.cgi?id=207874
1284
1285         Unreviewed test gardening.
1286
1287         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
1288         Disable the test for iOS.
1289
1290 2020-05-08  David Kilzer  <ddkilzer@apple.com>
1291
1292         check-webkit-style false positive for [readability/naming/protected] with method declaration
1293         <https://webkit.org/b/210682>
1294
1295         Reviewed by Darin Adler.
1296
1297         * Scripts/webkitpy/style/checkers/cpp.py:
1298         (check_identifier_name_in_declaration):
1299         - Don't check for invalid protector name if the capitalized
1300           protected name is the same as the original protected name,
1301           indicating it's a type name.
1302         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1303         (WebKitStyleTest.test_names):
1304         - Add test cases.
1305
1306 2020-05-08  Alex Christensen  <achristensen@webkit.org>
1307
1308         Fix build on platforms without network framework.
1309         https://bugs.webkit.org/show_bug.cgi?id=211603
1310
1311         * TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:
1312         Add HAVE(NETWORK_FRAMEWORK) around test that uses network framework.
1313
1314 2020-05-08  Aakash Jain  <aakash_jain@apple.com>
1315
1316         Delete old ews client side code
1317         https://bugs.webkit.org/show_bug.cgi?id=211638
1318
1319         Reviewed by Jonathan Bedard.
1320
1321         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1322         * Scripts/webkitpy/common/config/urls.py: Removed old ews server url.
1323         * Scripts/webkitpy/common/net/statusserver.py: Removed.
1324         * Scripts/webkitpy/common/net/statusserver_mock.py: Removed.
1325         * Scripts/webkitpy/tool/bot/botinfo.py:
1326         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
1327         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1328         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1329         * Scripts/webkitpy/tool/bot/queueengine.py:
1330         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1331         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1332         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1333         * Scripts/webkitpy/tool/commands/perfalizer.py:
1334         * Scripts/webkitpy/tool/commands/queues.py:
1335         (AbstractQueue._log_from_script_error_for_upload): Deleted.
1336         (AbstractQueue._update_status_for_script_error): Deleted.
1337         (AbstractPatchQueue._update_status): Deleted.
1338         (AbstractPatchQueue._release_work_item): Deleted.
1339         (AbstractPatchQueue._did_pass): Deleted.
1340         (AbstractPatchQueue._did_fail): Deleted.
1341         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1342         (AbstractQueueTest._assert_run_webkit_patch):
1343         (AbstractQueueTest.test_no_iteration_count):
1344         (PatchProcessingQueueTest.test_upload_results_archive_for_patch):
1345         (AbstractQueueTest._assert_log_message): Deleted.
1346         (AbstractQueueTest.test_log_from_script_error_for_upload): Deleted.
1347         (AbstractPatchQueueTest): Deleted.
1348         (NeedsUpdateSequence): Deleted.
1349         (NeedsUpdateSequence._run): Deleted.
1350         (StyleQueueTest): Deleted.
1351         (StyleQueueTest.test_style_queue_with_style_exception): Deleted.
1352         * Scripts/webkitpy/tool/commands/queuestest.py:
1353         (QueuesTest._default_begin_work_queue_logs):
1354         (QueuesTest._default_begin_work_queue_stderr): Deleted.
1355         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1356         * Scripts/webkitpy/tool/main.py:
1357         * Scripts/webkitpy/tool/mocktool.py:
1358
1359 2020-05-08  Alex Christensen  <achristensen@webkit.org>
1360
1361         Limit HTTP referer to 4kb
1362         https://bugs.webkit.org/show_bug.cgi?id=211603
1363         <rdar://problem/56768823>
1364
1365         Reviewed by Chris Dumez.
1366
1367         * TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:
1368         (TEST):
1369
1370 2020-05-08  Dean Jackson  <dino@apple.com>
1371
1372         Allow run-safari to launch an iPad simulator
1373         https://bugs.webkit.org/show_bug.cgi?id=211606
1374         <rdar://problem/63002849>
1375
1376         Reviewed by Jon Lee.
1377
1378         Add an "--ipad-simulator" command line option to run-safari.
1379
1380         * Scripts/webkitdirs.pm:
1381         (argumentsForConfiguration):
1382         (determineXcodeSDK): Mark the device idiom depending on the command line argument.
1383         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded):
1384         (findOrCreateSimulatorForIOSDevice): Create an iPad Pro simulator if requested.
1385
1386 2020-05-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1387
1388         Preserve character set information when writing to the pasteboard when copying rich text
1389         https://bugs.webkit.org/show_bug.cgi?id=211524
1390
1391         Reviewed by Darin Adler.
1392
1393         Add a new API test to verify that the HTML data written to the pasteboard when copying a rich text selection
1394         can be converted into an `NSAttributedString` that contains correctly encoded non-Latin characters.
1395
1396         * TestWebKitAPI/Tests/WebKitCocoa/CopyHTML.mm:
1397
1398 2020-05-08  Chris Dumez  <cdumez@apple.com>
1399
1400         REGRESSION(r259209) Webview's pending URL is null after restoring session state
1401         https://bugs.webkit.org/show_bug.cgi?id=211626
1402         <rdar://problem/62992262>
1403
1404         Reviewed by Alex Christensen.
1405
1406         Add API test coverage.
1407
1408         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
1409         (TestWebKitAPI::TEST):
1410
1411 2020-05-08  Alex Christensen  <achristensen@webkit.org>
1412
1413         WKWebView.title should be safe browsing warning's title during a safe browsing warning
1414         https://bugs.webkit.org/show_bug.cgi?id=211403
1415
1416         Reviewed by Tim Horton.
1417
1418         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1419         (TEST):
1420
1421 2020-05-08  Lauro Moura  <lmoura@igalia.com>
1422
1423         [GTK][WPE] Create common glib expectation file
1424         https://bugs.webkit.org/show_bug.cgi?id=211183
1425
1426         Reviewed by Carlos Garcia Campos.
1427
1428         * Scripts/webkitpy/port/gtk.py:
1429         (GtkPort._search_paths): Add glib to expectations search path
1430         (GtkPort.test_expectations_file_position): Update test
1431         * Scripts/webkitpy/port/gtk_unittest.py:
1432         (GtkPortTest.test_default_baseline_search_path): Update test
1433         (GtkPortTest.test_port_specific_expectations_files): Update test and
1434         make check-webkit-style happier
1435         * Scripts/webkitpy/port/wpe.py:
1436         (WPEPort._search_paths): Add glib to expectations search path
1437         (WPEPort.test_expectations_file_position): Update test
1438         * Scripts/webkitpy/port/wpe_unittest.py:
1439         (WPEPortTest.test_default_baseline_search_path): Update test
1440         (WPEPortTest.test_port_specific_expectations_files): Update test and
1441         make check-webkit-style happier
1442
1443 2020-05-08  Paulo Matos  <pmatos@igalia.com>
1444
1445         Add myself as committer to contributors.json
1446
1447         * Scripts/webkitpy/common/config/contributors.json:
1448
1449 2020-05-07  Jiewen Tan  <jiewen_tan@apple.com>
1450
1451         [WebAuthn] Roll back newly created credentials if an error occurs
1452         https://bugs.webkit.org/show_bug.cgi?id=183530
1453         <rdar://problem/43357305>
1454
1455         Reviewed by Brent Fulgham.
1456
1457         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1458         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
1459         (TestWebKitAPI::TEST):
1460         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la-no-attestation.html: Added.
1461         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la.html:
1462
1463 2020-05-07  Saam Barati  <sbarati@apple.com>
1464
1465         run-javascriptcore-tests with remote should be verbose
1466         https://bugs.webkit.org/show_bug.cgi?id=211596
1467
1468         Reviewed by Alexey Proskuryakov.
1469
1470         Our iOS testing bots could use this better output.
1471
1472         * Scripts/run-javascriptcore-tests:
1473         (runJSCStressTests):
1474
1475 2020-05-07  Jonathan Bedard  <jbedard@apple.com>
1476
1477         webkitpy: Use apple_additions certificate path if available
1478         https://bugs.webkit.org/show_bug.cgi?id=211584
1479
1480         Rubber-stamped by Aakash Jain
1481
1482         * Scripts/webkitpy/results/upload.py:
1483         (Upload):
1484         (Upload.certificate_chain): Certificate chain to be used, prefer apple_additions
1485         over certifi.
1486         (Upload.upload): Use Upload.certificate_chain().
1487         (Upload.upload_archive): Ditto.
1488
1489 2020-05-07  Commit Queue  <commit-queue@webkit.org>
1490
1491         Unreviewed, reverting r260959.
1492         https://bugs.webkit.org/show_bug.cgi?id=211587
1493
1494         "Causes MiniBrowser to crash when closing a window" (Requested
1495         by ddkilzer on #webkit).
1496
1497         Reverted changeset:
1498
1499         "REGRESSION (r176862, r210483): Leaks of
1500         BrowserWindowController in MiniBrowser/mac/AppDelegate.m"
1501         https://bugs.webkit.org/show_bug.cgi?id=211243
1502         https://trac.webkit.org/changeset/260959
1503
1504 2020-05-07  Darin Adler  <darin@apple.com>
1505
1506         Remove USE(INSERTION_UNDO_GROUPING) checks in macOS platform code
1507         https://bugs.webkit.org/show_bug.cgi?id=211525
1508
1509         Reviewed by Anders Carlsson.
1510
1511         * DumpRenderTree/mac/TextInputControllerMac.m: Use NSTextInputContextSPI.h.
1512         (-[TextInputController stringWithUndoGroupingInsertion:]): Removed
1513         SUPPORT_INSERTION_UNDO_GROUPING.
1514         * DumpRenderTree/mac/UIScriptControllerMac.mm: Use NSTextInputContextSPI.h.
1515         * TestRunnerShared/spi/AppKitTestSPI.h: Removed
1516         NSTextInputContext_Private.h, clients can use NSTextInputContextSPI.h.
1517         * TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h: Ditto.
1518         * TestWebKitAPI/Tests/mac/CandidateTests.mm: Use NSTextInputContextSPI.h.
1519         * TestWebKitAPI/Tests/mac/WKWebViewMacEditingTests.mm: Ditto.
1520
1521 2020-05-07  Aakash Jain  <aakash_jain@apple.com>
1522
1523         Delete code for old commit queue
1524         https://bugs.webkit.org/show_bug.cgi?id=211581
1525
1526         Reviewed by Alexey Proskuryakov.
1527
1528         * Scripts/webkitpy/common/config/committervalidator.py: Removed.
1529         * Scripts/webkitpy/common/config/committervalidator_unittest.py: Removed.
1530         * Scripts/webkitpy/tool/bot/commitqueuetask.py: Removed.
1531         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: Removed.
1532         * Scripts/webkitpy/tool/commands/queues.py:
1533         (PatchProcessingQueue._upload_results_archive_for_patch):
1534         (CommitQueue): Deleted.
1535         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1536         (NeedsUpdateSequence._run):
1537         (TestCommitQueue): Deleted.
1538         (AlwaysCommitQueueTool): Deleted.
1539         (SecondThoughtsCommitQueue): Deleted.
1540         (CommitQueueTest): Deleted.
1541         (test_did_pass_testing_ews): Deleted.
1542         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
1543         * Scripts/webkitpy/tool/steps/validatereviewer.py:
1544
1545 2020-05-07  Ryan Haddad  <ryanhaddad@apple.com>
1546
1547         Unreviewed, reverting r261286.
1548
1549         Tests are still crashing / failing
1550
1551         Reverted changeset:
1552
1553         "Unskip the test since it should now be passing"
1554         https://trac.webkit.org/changeset/261286
1555
1556 2020-05-07  Commit Queue  <commit-queue@webkit.org>
1557
1558         Unreviewed, reverting r260769.
1559         https://bugs.webkit.org/show_bug.cgi?id=211578
1560
1561         Introduced regressions related to sharing (Requested by
1562         perarne on #webkit).
1563
1564         Reverted changeset:
1565
1566         "[Cocoa] After r258891, r255119 can be reverted"
1567         https://bugs.webkit.org/show_bug.cgi?id=211083
1568         https://trac.webkit.org/changeset/260769
1569
1570 2020-05-07  Lauro Moura  <lmoura@igalia.com>
1571
1572         [Flatpak SDK] Fix string.format invocation
1573
1574         Reviewed by Philippe Normand.
1575
1576         * flatpak/flatpakutils.py:
1577         (WebkitFlatpak.run_in_sandbox):
1578
1579 2020-05-07  Philippe Normand  <pnormand@igalia.com>
1580
1581         [Flatpak SDK] Doesn't generate crash logs on the bots
1582         https://bugs.webkit.org/show_bug.cgi?id=211568
1583
1584         Reviewed by Carlos Alberto Lopez Perez.
1585
1586         * flatpak/flatpakutils.py:
1587         (WebkitFlatpak.run_in_sandbox): Bind-mount the
1588         WEBKIT_CORE_DUMPS_DIRECTORY so that the crash-log generator is
1589         able to write crash log reports there.
1590
1591 2020-05-07  Truitt Savell  <tsavell@apple.com>
1592
1593         Unskip the test since it should now be passing
1594
1595         Unreviewed test gardening.
1596
1597         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
1598
1599 2020-05-07  Philippe Normand  <pnormand@igalia.com>
1600
1601         [GTK] Test failures after Flatpak upgrade
1602         https://bugs.webkit.org/show_bug.cgi?id=211497
1603
1604         Reviewed by Adrian Perez de Castro.
1605
1606         * flatpak/flatpakutils.py:
1607         (WebkitFlatpak.run_in_sandbox): Don't set WEBKIT_TOP_LEVEL. I'm
1608         not sure why it's needed at all. If it needs to be set it should
1609         be /app/webkit/ anyway. Setting it to /app triggers test failures
1610         due to invalid computed paths by internals' pathToLocalResource().
1611
1612 2020-05-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1613
1614         Unreviewed. Fix GTK4 build with current GTK
1615
1616         GtkWindow and GtkOverlay aren't a GtkContainer anymore.
1617
1618         * MiniBrowser/gtk/BrowserTab.c:
1619         (browserTabConstructed):
1620         * MiniBrowser/gtk/BrowserWindow.c:
1621         (browser_window_init):
1622
1623 2020-05-07  Philippe Normand  <pnormand@igalia.com>
1624
1625         [Flatpak SDK] Import build definitions
1626         https://bugs.webkit.org/show_bug.cgi?id=211448
1627
1628         Reviewed by Carlos Alberto Lopez Perez.
1629
1630         To build the SDK, run `Tools/Scripts/webkit-flatpak-sdk --build`,
1631         this can take hours and use gigabytes of your hard-drive. To build
1632         a single recipe, use something like:
1633
1634         `Tools/Scripts/bst-wrapper build sdk/gtk.bst`
1635
1636         To enter the Buildstream SDK shell and debug stuff when hacking on
1637         a specific dependency, `Tools/Scripts/bst-wrapper shell sdk/gtk.bst`.
1638
1639         To test your changes in WebKit:
1640         ```shell
1641         $ Tools/Scripts/webkit-flatpak -u --repo=Tools/buildstream/repo
1642         $ Tools/Scripts/run-minibrowser --gtk --flatpak-repo=Tools/buildstream/repo <url>
1643         ...
1644         ```
1645
1646         bst-wrapper has the same options as bst itself, documented on
1647         https://docs.buildstream.build/1.4.2/index.html.
1648
1649         Internally the bst-wrapper will install Buildstream and a few
1650         other python dependencies in a local virtualenv managed by pipenv.
1651         This is all abstracted though, in theory direct access to the
1652         pipenv environment shouldn't be needed.
1653
1654         * Scripts/bst-wrapper: Added.
1655         * Scripts/webkit-flatpak-sdk: Added.
1656         * buildstream/Makefile: Added.
1657         * buildstream/Pipfile: Added.
1658         * buildstream/Pipfile.lock: Added.
1659         * buildstream/elements/filtered-openh264.bst: Added.
1660         * buildstream/elements/filtered.bst: Added.
1661         * buildstream/elements/flatpak-platform-extensions.bst: Added.
1662         * buildstream/elements/flatpak-runtimes.bst: Added.
1663         * buildstream/elements/flatpak/platform-arch-libs-debug.bst: Added.
1664         * buildstream/elements/flatpak/platform-arch-libs.bst: Added.
1665         * buildstream/elements/flatpak/platform-image.bst: Added.
1666         * buildstream/elements/flatpak/platform-locale.bst: Added.
1667         * buildstream/elements/flatpak/platform.bst: Added.
1668         * buildstream/elements/flatpak/sdk-arch-libs-debug.bst: Added.
1669         * buildstream/elements/flatpak/sdk-arch-libs.bst: Added.
1670         * buildstream/elements/flatpak/sdk-debug.bst: Added.
1671         * buildstream/elements/flatpak/sdk-docs.bst: Added.
1672         * buildstream/elements/flatpak/sdk-image.bst: Added.
1673         * buildstream/elements/flatpak/sdk-locale.bst: Added.
1674         * buildstream/elements/flatpak/sdk.bst: Added.
1675         * buildstream/elements/freedesktop-sdk.bst: Added.
1676         * buildstream/elements/manifests/platform-manifest.bst: Added.
1677         * buildstream/elements/manifests/sdk-manifest.bst: Added.
1678         * buildstream/elements/qt5.bst: Added.
1679         * buildstream/elements/qt5/qtbase.bst: Added.
1680         * buildstream/elements/qt5/qtdeclarative.bst: Added.
1681         * buildstream/elements/qt5/qtquickcontrols.bst: Added.
1682         * buildstream/elements/qt5/qtquickcontrols2.bst: Added.
1683         * buildstream/elements/qt5/qtwayland.bst: Added.
1684         * buildstream/elements/qt5/qtx11extras.bst: Added.
1685         * buildstream/elements/sdk-build-depends/libusb.bst: Added.
1686         * buildstream/elements/sdk-build-depends/sassc.bst: Added.
1687         * buildstream/elements/sdk-build-depends/utf8proc.bst: Added.
1688         * buildstream/elements/sdk-depends/libsass.bst: Added.
1689         * buildstream/elements/sdk-platform.bst: Added.
1690         * buildstream/elements/sdk.bst: Added.
1691         * buildstream/elements/sdk/adwaita-icon-theme.bst: Added.
1692         * buildstream/elements/sdk/at-spi2-atk.bst: Added.
1693         * buildstream/elements/sdk/at-spi2-core.bst: Added.
1694         * buildstream/elements/sdk/atk.bst: Added.
1695         * buildstream/elements/sdk/brotli.bst: Added.
1696         * buildstream/elements/sdk/capnp.bst: Added.
1697         * buildstream/elements/sdk/enchant-2.bst: Added.
1698         * buildstream/elements/sdk/glib-networking.bst: Added.
1699         * buildstream/elements/sdk/glib.bst: Added.
1700         * buildstream/elements/sdk/gobject-introspection.bst: Added.
1701         * buildstream/elements/sdk/graphene.bst: Added.
1702         * buildstream/elements/sdk/graphviz.bst: Added.
1703         * buildstream/elements/sdk/gst-libav.bst: Added.
1704         * buildstream/elements/sdk/gst-plugins-bad.bst: Added.
1705         * buildstream/elements/sdk/gst-plugins-base.bst: Added.
1706         * buildstream/elements/sdk/gst-plugins-good.bst: Added.
1707         * buildstream/elements/sdk/gst-plugins-ugly.bst: Added.
1708         * buildstream/elements/sdk/gstreamer.bst: Added.
1709         * buildstream/elements/sdk/gtk+-3.bst: Added.
1710         * buildstream/elements/sdk/gtk.bst: Added.
1711         * buildstream/elements/sdk/icecc.bst: Added.
1712         * buildstream/elements/sdk/intltool.bst: Added.
1713         * buildstream/elements/sdk/krb5.bst: Added.
1714         * buildstream/elements/sdk/libcap-ng.bst: Added.
1715         * buildstream/elements/sdk/libevent.bst: Added.
1716         * buildstream/elements/sdk/libgcrypt.bst: Added.
1717         * buildstream/elements/sdk/libmanette.bst: Added.
1718         * buildstream/elements/sdk/libnotify.bst: Added.
1719         * buildstream/elements/sdk/libopenh264.bst: Added.
1720         * buildstream/elements/sdk/libsecret.bst: Added.
1721         * buildstream/elements/sdk/libsoup.bst: Added.
1722         * buildstream/elements/sdk/libsrtp2.bst: Added.
1723         * buildstream/elements/sdk/libusrsctp.bst: Added.
1724         * buildstream/elements/sdk/libwpe.bst: Added.
1725         * buildstream/elements/sdk/libzstd.bst: Added.
1726         * buildstream/elements/sdk/lzo2.bst: Added.
1727         * buildstream/elements/sdk/openjpeg.bst: Added.
1728         * buildstream/elements/sdk/openxr.bst: Added.
1729         * buildstream/elements/sdk/os-release.bst: Added.
1730         * buildstream/elements/sdk/patchelf.bst: Added.
1731         * buildstream/elements/sdk/psmisc.bst: Added.
1732         * buildstream/elements/sdk/pycairo.bst: Added.
1733         * buildstream/elements/sdk/pygobject.bst: Added.
1734         * buildstream/elements/sdk/python2-pycairo.bst: Added.
1735         * buildstream/elements/sdk/python2-pygobject.bst: Added.
1736         * buildstream/elements/sdk/python2-six.bst: Added.
1737         * buildstream/elements/sdk/python2-subprocess32.bst: Added.
1738         * buildstream/elements/sdk/python2.bst: Added.
1739         * buildstream/elements/sdk/rr.bst: Added.
1740         * buildstream/elements/sdk/sccache.bst: Added.
1741         * buildstream/elements/sdk/shared-mime-info.bst: Added.
1742         * buildstream/elements/sdk/subversion.bst: Added.
1743         * buildstream/elements/sdk/v4lutils.bst: Added.
1744         * buildstream/elements/sdk/woff2.bst: Added.
1745         * buildstream/elements/sdk/wpebackend-fdo.bst: Added.
1746         * buildstream/elements/sdk/x264.bst: Added.
1747         * buildstream/elements/sdk/xorg-server.bst: Added.
1748         * buildstream/elements/test-infra.bst: Added.
1749         * buildstream/elements/test-infra/apr-util.bst: Added.
1750         * buildstream/elements/test-infra/apr.bst: Added.
1751         * buildstream/elements/test-infra/httpd.bst: Added.
1752         * buildstream/elements/test-infra/perl-cgi-pm.bst: Added.
1753         * buildstream/elements/test-infra/perl-http-date-pm.bst: Added.
1754         * buildstream/elements/test-infra/php.bst: Added.
1755         * buildstream/elements/test-infra/webkitgtk-test-dicts.bst: Added.
1756         * buildstream/elements/test-infra/webkitgtk-test-fonts.bst: Added.
1757         * buildstream/files/krb5/krb5.conf: Added.
1758         * buildstream/files/os-release/issue.in: Added.
1759         * buildstream/files/os-release/issue.net.in: Added.
1760         * buildstream/files/os-release/org.webkit.Platform.appdata.xml.in: Added.
1761         * buildstream/files/os-release/org.webkit.Sdk.appdata.xml.in: Added.
1762         * buildstream/files/os-release/os-release.in: Added.
1763         * buildstream/patches/fdo-0001-Update-gcc-to-9.3.0.patch: Added.
1764         * buildstream/patches/fdo/0001-Add-Jack.patch: Added.
1765         * buildstream/patches/fdo/0001-components-xdg-desktop-portal.bst-Update-to-1.6.0.patch: Added.
1766         * buildstream/patches/fdo/0001-ffmpeg-Add-MS-MPEG-DivX-variants.patch: Added.
1767         * buildstream/patches/fdo/0002-Update-PipeWire-to-0.3.1.patch: Added.
1768         * buildstream/patches/fdo/0002-ffmpeg-Add-VP6-and-Sorenson-Spark-video-codecs.patch: Added.
1769         * buildstream/patches/fdo/0003-Add-Bluez.patch: Added.
1770         * buildstream/patches/fdo/0003-ffmpeg-Add-Intel-Indeo-and-Cinepak-video-support.patch: Added.
1771         * buildstream/patches/fdo/0004-ffmpeg-Add-MPEG-2-video-decoder.patch: Added.
1772         * buildstream/patches/fdo/0005-ffmpeg-Add-msmpeg4v3-support.patch: Added.
1773         * buildstream/patches/gst-libav-stop-caching-codecs.patch: Added.
1774         * buildstream/patches/gst-plugins-bad-0001-h264parse-Post-a-WARNING-when-data-is-broken.patch: Added.
1775         * buildstream/patches/gst-plugins-base-0001-glupload-Fix-fallback-from-direct-dmabuf-to-dmabuf-u.patch: Added.
1776         * buildstream/patches/gst-plugins-base-0001-playbin-Handle-error-message-with-redirection-indica.patch: Added.
1777         * buildstream/patches/gst-plugins-base-0002-glupload-fix-segfault.patch: Added.
1778         * buildstream/patches/gst-plugins-good-qtdemux-Specify-REDIRECT-information-in-error-messag.patch: Added.
1779         * buildstream/patches/gtk-meson-Bump-to-latest-version-of-the-3.24-branch.patch: Added.
1780         * buildstream/patches/httpd-0001-configure-use-pkg-config-for-PCRE-detection.patch: Added.
1781         * buildstream/patches/libav-0001-gstavviddec-Limit-default-number-of-decoder-threads.patch: Added.
1782         * buildstream/patches/libgcrypt-0001-Use-pkg-config-to-detect-gpg-error.patch: Added.
1783         * buildstream/patches/libgcrypt-use-only-dev-urandom-for-testing.patch: Added.
1784         * buildstream/patches/libsecret-b53e9876f4611525b7a8f69a3110fbec51dcede0.patch: Added.
1785         * buildstream/patches/nettle-no-debug.diff: Added.
1786         * buildstream/patches/qtbase-avoid-hardcoding-kernel-version.patch: Added.
1787         * buildstream/patches/qtbase-revert-correct-handling-for-xdg-runtime-dir.patch: Added.
1788         * buildstream/patches/qtbase-use-wayland-on-gnome.patch: Added.
1789         * buildstream/patches/qtdeclarative-use-python3.patch: Added.
1790         * buildstream/patches/qtwayland-use-gnome-platform-theme-on-gnome-based-desktops.patch: Added.
1791         * buildstream/patches/sccache-no-selenium.patch: Added.
1792         * buildstream/patches/xserver-search-for-DRI-drivers-at-LIBGL_DRIVERS_PATH-environ.patch: Added.
1793         * buildstream/project.conf: Added.
1794         * buildstream/utils/generate-version: Added.
1795         * gtk/install-dependencies:
1796         * wpe/install-dependencies:
1797
1798 2020-05-07  Mark Lam  <mark.lam@apple.com>
1799
1800         Fix broken exceptionFuzz tests.
1801         https://bugs.webkit.org/show_bug.cgi?id=211550
1802
1803         Reviewed by Yusuke Suzuki.
1804
1805         Pass the --useExceptionFuzz=true option from the command line for runExceptionFuzz.
1806
1807         * Scripts/run-jsc-stress-tests:
1808
1809 2020-05-06  Kate Cheney  <katherine_cheney@apple.com>
1810
1811         ResourceLoadStatistics data summary call should create a web process pool if one doesn't exist
1812         https://bugs.webkit.org/show_bug.cgi?id=211520
1813         <rdar://problem/59869619>
1814
1815         Reviewed by Chris Dumez.
1816
1817         Added API test coverage.
1818
1819         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1820         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1821         Removed stray comment from previous test.
1822
1823         (TEST):
1824         * TestWebKitAPI/basicITPDatabase.db: Added.
1825         * TestWebKitAPI/basicITPDatabase.db-shm: Added.
1826         * TestWebKitAPI/basicITPDatabase.db-wal: Added.
1827         New database resource with 2 entries: apple.com and webkit.org, with
1828         webkit.org registered as a subframe of apple.com
1829
1830 2020-05-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1831
1832         Cut and paste from Google Doc to Notes in several (non-Latin) languages doesn't work
1833         https://bugs.webkit.org/show_bug.cgi?id=211498
1834         <rdar://problem/56675345>
1835
1836         Reviewed by Darin Adler.
1837
1838         Add a test to verify that when writing markup to the clipboard via DOM API, if non-ASCII characters appear in
1839         the written markup, they can still be converted to `NSAttributedString`s containing the expected non-Latin text.
1840
1841         * TestWebKitAPI/Configurations/Base.xcconfig:
1842
1843         Adjust header search paths so that we can import CocoaColor.h in WebKit.
1844
1845         * TestWebKitAPI/Tests/WebKitCocoa/CopyHTML.mm:
1846         (readHTMLDataFromPasteboard):
1847         (readHTMLStringFromPasteboard):
1848         (readHTMLFromPasteboard): Deleted.
1849
1850 2020-05-06  Ryan Haddad  <ryanhaddad@apple.com>
1851
1852         REGRESSION (r260278): TestWebKitAPI.Fullscreen.Delegate is timing out on macOS bots
1853         https://bugs.webkit.org/show_bug.cgi?id=210676
1854
1855         Unreviewed test gardening.
1856
1857         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenAlert.mm:
1858         (TestWebKitAPI::TEST): Skip the test to get the bots to green.
1859
1860 2020-05-06  John Wilander  <wilander@apple.com>
1861
1862         Exempt app-bound domains from ITP's website data deletion and third-party cookie blocking between themselves
1863         https://bugs.webkit.org/show_bug.cgi?id=210674
1864         <rdar://problem/61950767>
1865
1866         Reviewed by Chris Dumez.
1867
1868         This change adds a new TestRunner function
1869         setAppBoundDomain() which takes an array of origin
1870         strings and sets them to app-bound domains.
1871
1872         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1873         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1874         (WTR::InjectedBundle::didReceiveMessageToPage):
1875         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1876         (WTR::TestRunner::setAppBoundDomains):
1877         (WTR::TestRunner::didSetAppBoundDomainsCallback):
1878         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1879         * WebKitTestRunner/TestController.cpp:
1880         (WTR::AppBoundDomainsCallbackContext::AppBoundDomainsCallbackContext):
1881         (WTR::didSetAppBoundDomainsCallback):
1882         (WTR::TestController::setAppBoundDomains):
1883         * WebKitTestRunner/TestController.h:
1884         * WebKitTestRunner/TestInvocation.cpp:
1885         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1886         (WTR::TestInvocation::didSetAppBoundDomains):
1887         * WebKitTestRunner/TestInvocation.h:
1888
1889 2020-05-06  Aakash Jain  <aakash_jain@apple.com>
1890
1891         Delete code for feeder queue
1892         https://bugs.webkit.org/show_bug.cgi?id=211518
1893
1894         Reviewed by Jonathan Bedard.
1895
1896         * Scripts/webkitpy/tool/bot/feeders.py: Removed.
1897         * Scripts/webkitpy/tool/bot/feeders_unittest.py: Removed.
1898         * Scripts/webkitpy/tool/commands/queues.py:
1899         (FeederQueue): Deleted.
1900         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1901         (TestFeederQueue): Deleted.
1902         (FeederQueueTest): Deleted.
1903         (PatchProcessingQueueTest): Deleted.
1904
1905 2020-05-06  Darin Adler  <darin@apple.com>
1906
1907         Eliminate checks of USE(DICTATION_ALTERNATIVES) in Cocoa-specific code
1908         https://bugs.webkit.org/show_bug.cgi?id=211460
1909
1910         Reviewed by Anders Carlsson.
1911
1912         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm: Remove USE(DICTATION_ALTERNATIVES).
1913
1914 2020-05-06  Pablo Saavedra  <psaavedra@igalia.com>
1915
1916         Python3: Support Python3 in Tools/webkitpy/benchmark_runner
1917         https://bugs.webkit.org/show_bug.cgi?id=211249
1918
1919         Reviewed by Jonathan Bedard.
1920
1921         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
1922         (BenchmarkBuilder._fetch_remote_archive):
1923         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
1924         (BenchmarkResults._format_values):
1925         (BenchmarkResults._subtest_values_by_config_iteration):
1926         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1927         (istext):
1928         (BenchmarkRunner._run_benchmark):
1929         (BenchmarkRunner._merge):
1930         (BenchmarkRunner.show_results):
1931         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1932         (OSXSafariDriver.launch_url):
1933         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
1934         (HTTPServerDriver):
1935         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
1936         (SimpleHTTPServerDriver.serve):
1937         (SimpleHTTPServerDriver._wait_for_http_server):
1938         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
1939         (parse_args):
1940         (list_benchmark_plans):
1941         * Scripts/webkitpy/style/checker.py:
1942         (CheckerDispatcher._create_checker):
1943
1944 2020-05-06  Aakash Jain  <aakash_jain@apple.com>
1945
1946         Delete code for QueueStatusServer
1947         https://bugs.webkit.org/show_bug.cgi?id=211504
1948
1949         Reviewed by Jonathan Bedard.
1950
1951         * QueueStatusServer: Removed.
1952         * BuildSlaveSupport/ews-build/steps.py:
1953         (CheckPatchRelevance): Removed QueueStatusServer.
1954         * Scripts/webkitpy/tool/steps/checkpatchrelevance.py:
1955         (CheckPatchRelevance): Removed QueueStatusServer.
1956         * Scripts/webkitpy/common/net/statusserver.py: Removed implementation of most methods. Will delete it completely
1957         in subsequent patch along-with all its callers.
1958         * Scripts/webkitpy/common/net/statusserver_unittest.py: Removed.
1959         * Scripts/webkitpy/test/main.py:
1960
1961 2020-05-05  Ross Kirsling  <ross.kirsling@sony.com>
1962
1963         [ECMA-402] Implement Intl.Locale
1964         https://bugs.webkit.org/show_bug.cgi?id=209772
1965
1966         Reviewed by Darin Adler and Saam Barati.
1967
1968         * Scripts/run-jsc-stress-tests:
1969         Add runIntlLocaleEnabled.
1970
1971 2020-05-05  Saam Barati  <sbarati@apple.com>
1972
1973         Don't use the DebugHeap for catalyst
1974         https://bugs.webkit.org/show_bug.cgi?id=211471
1975
1976         Reviewed by Tim Horton.
1977
1978         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
1979         (TEST):
1980
1981 2020-05-05  Daniel Bates  <dabates@apple.com>
1982
1983         Should show selection highlight during text interaction
1984         https://bugs.webkit.org/show_bug.cgi?id=211362
1985         <rdar://problem/59191873>
1986
1987         Reviewed by Wenson Hsieh.
1988
1989         Add a test to ensure the selection view has rects after selecting
1990         text during a text interaction. These rects represents the highlight.
1991
1992         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
1993         (TestWebKitAPI::TEST):
1994
1995 2020-05-05  Aakash Jain  <aakash_jain@apple.com>
1996
1997         webkitbot isn't responding properly in irc
1998         https://bugs.webkit.org/show_bug.cgi?id=211458
1999
2000         Reviewed by Jonathan Bedard.
2001
2002         * Scripts/webkitpy/tool/commands/queues.py:
2003         (AbstractQueue.run_webkit_patch): Removed status-host paramter since old ews server has been decommissioned.
2004         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: Updated unit-tests.
2005         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2006
2007 2020-05-05  Aakash Jain  <aakash_jain@apple.com>
2008
2009         EWS should skip Apple Win build and tests for patches that only change WebKit2 sources
2010         https://bugs.webkit.org/show_bug.cgi?id=211210
2011
2012         Reviewed by Jonathan Bedard.
2013
2014         * BuildSlaveSupport/ews-build/factories.py:
2015         (WindowsFactory.__init__): enabled relevance checking for windows ews.
2016         * BuildSlaveSupport/ews-build/factories_unittest.py: Updated unit-test.
2017         * BuildSlaveSupport/ews-build/steps.py:
2018         (CheckPatchRelevance): Defined relevance info for windows ews. 
2019         * BuildSlaveSupport/ews-build/steps_unittest.py:
2020         (TestCheckPatchRelevance.test_relevant_windows_wk1_patch): Added unit test.
2021         (TestCheckPatchRelevance.test_queues_without_relevance_info): Fixed unit-test.
2022
2023 2020-05-05  Mark Lam  <mark.lam@apple.com>
2024
2025         Allow Bitmap to use up to a UCPURegister word size for internal bit storage.
2026         https://bugs.webkit.org/show_bug.cgi?id=211328
2027         <rdar://problem/62755865>
2028
2029         Reviewed by Yusuke Suzuki.
2030
2031         Added API tests for WTF::Bitmap to make sure that Bitmap is behaving correctly.
2032         Since Bitmap is used in critical infrastructure like the GC, it is important to
2033         ensure that there are no latent bugs.
2034
2035         * TestWebKitAPI/CMakeLists.txt:
2036         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2037         * TestWebKitAPI/Tests/WTF/Bitmap.cpp: Added.
2038         (TestWebKitAPI::countBits):
2039         (TestWebKitAPI::testBitmapSize):
2040         (TestWebKitAPI::testBitmapConstructedEmpty):
2041         (TestWebKitAPI::testBitmapSetGet):
2042         (TestWebKitAPI::testBitmapTestAndSet):
2043         (TestWebKitAPI::testBitmapTestAndClear):
2044         (TestWebKitAPI::testBitmapConcurrentTestAndSet):
2045         (TestWebKitAPI::testBitmapConcurrentTestAndClear):
2046         (TestWebKitAPI::testBitmapClear):
2047         (TestWebKitAPI::testBitmapClearAll):
2048         (TestWebKitAPI::testBitmapInvert):
2049         (TestWebKitAPI::testBitmapFindRunOfZeros):
2050         (TestWebKitAPI::testBitmapCount):
2051         (TestWebKitAPI::testBitmapIsEmpty):
2052         (TestWebKitAPI::testBitmapIsFull):
2053         (TestWebKitAPI::testBitmapMerge):
2054         (TestWebKitAPI::testBitmapFilter):
2055         (TestWebKitAPI::testBitmapExclude):
2056         (TestWebKitAPI::testBitmapConcurrentFilter):
2057         (TestWebKitAPI::testBitmapSubsumes):
2058         (TestWebKitAPI::testBitmapForEachSetBit):
2059         (TestWebKitAPI::testBitmapFindBit):
2060         (TestWebKitAPI::testBitmapIteration):
2061         (TestWebKitAPI::testBitmapMergeAndClear):
2062         (TestWebKitAPI::testBitmapSetAndClear):
2063         (TestWebKitAPI::testBitmapOperatorEqual):
2064         (TestWebKitAPI::testBitmapOperatorNotEqual):
2065         (TestWebKitAPI::testBitmapHash):
2066         (TestWebKitAPI::TEST):
2067
2068 2020-05-05  Alexey Shvayka  <shvaikalesh@gmail.com>
2069
2070         Object.prototype.toString is not spec-perfect
2071         https://bugs.webkit.org/show_bug.cgi?id=199138
2072
2073         Reviewed by Darin Adler and Keith Miller.
2074
2075         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2076
2077 2020-05-05  Tim Horton  <timothy_horton@apple.com>
2078
2079         Excessive error logging from daemons trying to use WebKit, under -[UIDevice currentDevice]
2080         https://bugs.webkit.org/show_bug.cgi?id=211397
2081         <rdar://problem/61635403>
2082
2083         Reviewed by Simon Fraser.
2084
2085         * TestWebKitAPI/ios/UserInterfaceSwizzler.h:
2086         We need a UIApplication or WebKit won't look at UIDevice.
2087
2088 2020-05-04  Darin Adler  <darin@apple.com>
2089
2090         [Mac] Remove __MAC_OS_X_VERSION_MIN_REQUIRED checks for versions older than 10.14
2091         https://bugs.webkit.org/show_bug.cgi?id=211420
2092
2093         Reviewed by Alex Christensen.
2094
2095         * TestWebKitAPI/Tests/WebCore/CtapPinTest.cpp: Remove
2096         __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400.
2097
2098         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2099         Removed code disabling this test for __MAC_OS_X_VERSION_MIN_REQUIRED < 101400.
2100
2101         * TestWebKitAPI/config.h: Removed __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400.
2102
2103         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2104         (WTR::installFakeHelvetica): Removed __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400.
2105
2106 2020-05-04  Darin Adler  <darin@apple.com>
2107
2108         Remove now-unneeded HAVE(NETWORK_EXTENSION)
2109         https://bugs.webkit.org/show_bug.cgi?id=211424
2110
2111         Reviewed by Alex Christensen.
2112
2113         * TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.mm:
2114         (-[LazilyLoadPlatformFrameworksController expectParentalControlsLoaded:networkExtensionLoaded:]):
2115         Remove check of HAVE(NETWORK_EXTENSION).
2116         * TestWebKitAPI/Tests/WebKitCocoa/ContentFilteringPlugIn.mm:
2117         (-[ContentFilteringPlugIn checkIfPlatformFrameworksAreLoaded:]): Ditto.
2118
2119 2020-05-04  Ben Nham  <nham@apple.com>
2120
2121         IndexedDB WAL file keeps growing while app is in use
2122         https://bugs.webkit.org/show_bug.cgi?id=202137
2123
2124         Reviewed by Brady Eidson.
2125
2126         Add a test to make sure that WAL auto-checkpointing actually works.
2127
2128         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2129         * TestWebKitAPI/Tests/WebKitCocoa/IDBCheckpointWAL.html: Added.
2130         * TestWebKitAPI/Tests/WebKitCocoa/IDBCheckpointWAL.mm: Added.
2131         (-[IDBCheckpointWALMessageHandler userContentController:didReceiveScriptMessage:]):
2132         (fileSizeAtPath):
2133         (TEST):
2134
2135 2020-05-04  Darin Adler  <darin@apple.com>
2136
2137         Make __IPHONE_OS_VERSION_MIN_REQUIRED checks against old versions explicit about watchOS and tvOS
2138         https://bugs.webkit.org/show_bug.cgi?id=211402
2139
2140         Reviewed by Alexey Proskuryakov.
2141
2142         * TestWebKitAPI/Tests/WebKitCocoa/DataDetection.mm:
2143         Remove unneeded __IPHONE_OS_VERSION_MIN_REQUIRED check.
2144
2145         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2146         Move from __IPHONE_OS_VERSION_MIN_REQUIRED to
2147         !PLATFORM(WATCHOS) && !PLATFORM(APPLETV).
2148
2149         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
2150         Move from __IPHONE_OS_VERSION_MIN_REQUIRED to
2151         PLATFORM(IOS).
2152
2153         * TestWebKitAPI/Tests/ios/OverflowScrollViewTests.mm:
2154         Move from __IPHONE_OS_VERSION_MIN_REQUIRED to
2155         !PLATFORM(WATCHOS) && !PLATFORM(APPLETV).
2156         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2157         (-[TestRunnerWKWebView setOverrideSafeAreaInsets:]): Ditto.
2158
2159 2020-05-04  Darin Adler  <darin@apple.com>
2160
2161         [Cocoa] Remove a few unneeded __IPHONE_OS_VERSION_MIN_REQUIRED checks
2162         https://bugs.webkit.org/show_bug.cgi?id=211383
2163
2164         Reviewed by Alexey Proskuryakov.
2165
2166         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
2167         (TestWebKitAPI::TEST): Removed checks against iOS 12 and 13 in code that
2168         uses PLATFORM(IOS), not PLATFORM(IOS_FAMILY).
2169
2170         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm: Removed a
2171         check against iOS 11 in code using PLATFORM(IOS).
2172
2173 2020-05-04  Darin Adler  <darin@apple.com>
2174
2175         Remove HAVE(IOSURFACE) checks in Cocoa-platform-specific code
2176         https://bugs.webkit.org/show_bug.cgi?id=211389
2177
2178         Reviewed by Alexey Proskuryakov.
2179
2180         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
2181         (createBitmapContextFromWebView): Remove BEGIN/END_BLOCK_OBJC_EXCEPTIONS
2182         since they are not needed/appropriate in test code. Remove HAVE(IOSURFACE)
2183         since this is Cocoa-specific.
2184         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2185         (WTR::PlatformWebView::windowSnapshotImage): Ditto.
2186
2187 2020-05-04  Alexey Proskuryakov  <ap@apple.com>
2188
2189         block-spammers tool should hide attachments
2190         https://bugs.webkit.org/show_bug.cgi?id=211406
2191
2192         Reviewed by Darin Adler.
2193
2194         The logic is nearly identical to hiding comments. Just need to limit fields in the
2195         search, so that we don't have to download attachment data.
2196
2197         * Scripts/block-spammers:
2198         (get_comments):
2199         (get_bugs_with_attachments_created_by_user):
2200         (get_attachments):
2201         (hide_comments):
2202         (hide_attachments):
2203         (main):
2204
2205 2020-05-04  Darin Adler  <darin@apple.com>
2206
2207         Remove unneeded USE(MEDIAREMOTE)
2208         https://bugs.webkit.org/show_bug.cgi?id=211385
2209
2210         Reviewed by Eric Carlson.
2211
2212         * TestWebKitAPI/Tests/WebKitCocoa/NowPlaying.mm: Reverse conditional so it's
2213         consistently listing which platforms we do *not* compile the test on.
2214
2215 2020-05-04  Alex Christensen  <achristensen@webkit.org>
2216
2217         [Catalina] ASSERTION FAILED: Unsafe to ref/deref from different threads seen with TestWebKitAPI.MultipleClientCertificateConnections.Failure
2218         https://bugs.webkit.org/show_bug.cgi?id=211300
2219
2220         Reviewed by Youenn Fablet.
2221
2222         RequestData references are stored in blocks given to the network framework, which does things on background threads.
2223         To make them safe to ref and deref on non-main threads, make RequestData ThreadSafeRefCounted.
2224
2225         * TestWebKitAPI/cocoa/HTTPServer.mm:
2226
2227 2020-05-04  Darin Adler  <darin@apple.com>
2228
2229         Remove now-unneeded HAVE(MEDIA_PLAYER)
2230         https://bugs.webkit.org/show_bug.cgi?id=211378
2231
2232         Reviewed by Alex Christensen.
2233
2234         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
2235         (TestWebKitAPI::TEST): Removed HAVE(MEDIA_PLAYER) check since it's now always
2236         true in Objective-C source files.
2237
2238 2020-05-04  Michael Catanzaro  <mcatanzaro@gnome.org>
2239
2240         [WPE][GTK] Should install python3-secretstorage
2241         https://bugs.webkit.org/show_bug.cgi?id=207473
2242
2243         Reviewed by Adrian Perez de Castro.
2244
2245         If python3-secretstorage is not installed, webkit-patch will use a custom encrypted file
2246         for password storage instead of utilizing the system keyring. This means unnecessary
2247         password prompts to unlock the custom encrypted key storage.
2248
2249         There is no benefit to using custom key storage over the system keyring.
2250
2251         * gtk/install-dependencies:
2252         * wpe/install-dependencies:
2253
2254 2020-05-04  Andres Gonzalez  <andresg_22@apple.com>
2255
2256         Add WTR::AccessibilityUIElement::attributeValueAsync to retrieve attribute values in isolated tree mode.
2257         https://bugs.webkit.org/show_bug.cgi?id=211341
2258
2259         Reviewed by Chris Fleizach.
2260
2261         To simulate running WebAccessibilityObjectWrapper methods on the secondary
2262         thread, WTR::AccessibilityUIElement dispatches those calls to the AX
2263         thread. But some WebAccessibilityObjectWrapper calls cannot be fulfilled
2264         on the secondary thread and in turn have to be dispatched to the main
2265         thread. This was causing a thread lock during LayoutTests in isolated
2266         tree mode since the initial dispatch to the secondary thread blocks the
2267         main thread. The solution in this patch is to add an asynchronous
2268         mechanism to retrieve attribute values.
2269         - Added WTR::AccessibilityUIElement::attributeValueAsync.
2270         - Made several fixes consisting of retaining variables in the main
2271         thread whose values are computed on the secondary thread.
2272
2273         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2274         (WTR::AccessibilityController::executeOnAXThreadAndWait):
2275         (WTR::AccessibilityController::executeOnAXThread):
2276         (WTR::AccessibilityController::executeOnMainThread):
2277         (WTR::AXThread::dispatchBarrier):
2278         (WTR::AccessibilityController::executeOnAXThreadIfPossible): Renamed executeOnAXThreadAndWait.
2279         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
2280         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2281         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2282         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:
2283         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm:
2284         (WTR::webAccessibilityObjectWrapperClass):
2285         (WTR::makeArrayRefForArray):
2286         (WTR::makeObjectRefForDictionary):
2287         (WTR::makeValueRefForValue):
2288         (WTR::searchPredicateParameterizedAttributeForSearchCriteria):
2289         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
2290         (WTR::AccessibilityController::accessibleElementById):
2291         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
2292         (-[AccessibilityNotificationHandler startObserving]):
2293         (-[AccessibilityNotificationHandler _notificationReceived:]):
2294         (webAccessibilityObjectWrapperClass): Moved to AccessibilityCommonMac.
2295         (makeValueRefForValue): Moved to AccessibilityCommonMac.
2296         (makeArrayRefForArray): Moved to AccessibilityCommonMac.
2297         (makeObjectRefForDictionary): Moved to AccessibilityCommonMac.
2298         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2299         (WTR::supportedAttributes):
2300         (WTR::attributeValue):
2301         (WTR::setAttributeValue):
2302         (WTR::attributesOfElement):
2303         (WTR::AccessibilityUIElement::getChildrenWithRange):
2304         (WTR::AccessibilityUIElement::elementAtPoint):
2305         (WTR::AccessibilityUIElement::indexOfChild):
2306         (WTR::AccessibilityUIElement::selectedChildrenCount const):
2307         (WTR::AccessibilityUIElement::attributeValueAsync):
2308         (WTR::AccessibilityUIElement::selectTextWithCriteria):
2309
2310 2020-05-04  Commit Queue  <commit-queue@webkit.org>
2311
2312         Unreviewed, reverting r261076.
2313         https://bugs.webkit.org/show_bug.cgi?id=211371
2314
2315         Triggers obscure X11 error on GTK bots (Requested by philn on
2316         #webkit).
2317
2318         Reverted changeset:
2319
2320         "[Flatpak SDK] Query the doc portal path with DBus"
2321         https://bugs.webkit.org/show_bug.cgi?id=211281
2322         https://trac.webkit.org/changeset/261076
2323
2324 2020-05-04  Philippe Normand  <pnormand@igalia.com>
2325
2326         [Flatpak SDK] Support for local repository and drive-by fixes
2327         https://bugs.webkit.org/show_bug.cgi?id=211370
2328
2329         Reviewed by Žan Doberšek.
2330
2331         This patch adds a new --repo option to webkit-flatpak, allowing
2332         SDK developers to test local changes made to the SDK. As future
2333         versions of the SDK will depend on the ffmpeg FDO extension,
2334         flatpakutils installs it from now on. One consequence is that the
2335         LD_LIBRARY_PATH set in the GTK layout test driver is no longer
2336         overriden when running in the flatpak SDK, in order to allow the
2337         extension to set it correctly.
2338
2339         * Scripts/webkitpy/port/gtk.py:
2340         (GtkPort.setup_environ_for_server):
2341         * flatpak/flatpakutils.py:
2342         (FlatpakRepos.add):
2343         (FlatpakRepo.repo_file):
2344         (WebkitFlatpak.load_from_args):
2345         (WebkitFlatpak.__init__):
2346         (WebkitFlatpak.clean_args):
2347         (WebkitFlatpak._reset_repository):
2348         (WebkitFlatpak.run_in_sandbox):
2349         (WebkitFlatpak._get_packages):
2350         (run_in_sandbox_if_available):
2351
2352 2020-05-04  Philippe Normand  <pnormand@igalia.com>
2353
2354         [Flatpak SDK] Query the doc portal path with DBus
2355         https://bugs.webkit.org/show_bug.cgi?id=211281
2356
2357         Reviewed by Žan Doberšek.
2358
2359         * flatpak/flatpakutils.py:
2360         (WebkitFlatpak.run_in_sandbox):
2361
2362 2020-05-04  Emilio Cobos Álvarez  <emilio@crisal.io>
2363
2364         Put lh / rlh units behind a flag until bug 211351 is sorted out.
2365         https://bugs.webkit.org/show_bug.cgi?id=211356
2366
2367         Reviewed by Antti Koivisto.
2368
2369         * DumpRenderTree/TestOptions.cpp:
2370         (TestOptions::TestOptions):
2371         * DumpRenderTree/TestOptions.h:
2372         * DumpRenderTree/mac/DumpRenderTree.mm:
2373         (setWebPreferencesForTestOptions):
2374
2375 2020-05-04  Patrick Griffis  <pgriffis@igalia.com>
2376
2377         [Flatpak SDK] Misc flatpakutils.py fixes
2378         https://bugs.webkit.org/show_bug.cgi?id=211032
2379
2380         Reviewed by Philippe Normand.
2381
2382         Pass SSLKEYLOGFILE into sandbox which is useful for debugging with Wireshark.
2383
2384         Sanitize G_MESSAGES_DEBUG env var when checking output of flatpak command.
2385
2386         Fix check for --noninteractive support.
2387
2388         Fix python 3 exception when setting up icecc mixing strings and bytes.
2389
2390         * flatpak/flatpakutils.py:
2391         (Console.warning_message):
2392         (flatpak_check_output):
2393         (check_flatpak):
2394         (FlatpakObject.flatpak):
2395         * flatpak/flatpakutils.py:
2396         (WebkitFlatpak.run_in_sandbox):
2397
2398 2020-05-03  Daniel Bates  <dabates@apple.com>
2399
2400         Attempt to fix the iOS build after r261068
2401         (https://bugs.webkit.org/show_bug.cgi?id=208281)
2402
2403         Wrap TEST()s in namespace TestWebKitAPI so as to not need to qualify IPhoneUserInterfaceSwizzler.
2404
2405         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:
2406         (TEST): Deleted.
2407
2408 2020-05-03  Daniel Bates  <dabates@apple.com>
2409
2410         [iPad Simulator] TestWebKitAPI.UIWKInteractionViewProtocol.SelectPositionAtPointAfterBecomingFirstResponder is failing
2411         https://bugs.webkit.org/show_bug.cgi?id=208281
2412         <rdar://problem/59829265>
2413
2414         Reviewed by Wenson Hsieh.
2415
2416         I tried to write the test SelectPositionAtPointAfterBecomingFirstResponder for both iPad and iPhone,
2417         but it turns out that I forgot an impl detail on how form control dismissal works for iPad and fixing
2418         this would require adding more SPI/IPI. This is largely due to differences in form control UI and
2419         conventions for dismissing such UI. This test isn't testing such UI it just needs to ensure that the
2420         view is not first responder before it runs the actual test code. It uses an iPhone specific set of
2421         steps to do this. It's enough to test this functionality on iPhone.
2422
2423         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:
2424         (TEST):
2425
2426 2020-05-03  Daniel Bates  <dabates@apple.com>
2427
2428         Update info.
2429
2430         * Scripts/webkitpy/common/config/contributors.json:
2431
2432 2020-05-02  ChangSeok Oh  <changseok@webkit.org>
2433
2434         Unreviewed, add myself to some watch lists.
2435
2436         * Scripts/webkitpy/common/config/watchlist:
2437
2438 2020-05-02  Daniel Bates  <dabates@apple.com>
2439
2440         Page::editableElementsInRect() should return root editable elements
2441         https://bugs.webkit.org/show_bug.cgi?id=211343
2442         <rdar://problem/60015801>
2443
2444         Reviewed by Simon Fraser.
2445
2446         Add some tests.
2447
2448         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2449         (TestWebKitAPI::TEST):
2450
2451 2020-05-02  Diego Pino Garcia  <dpino@igalia.com>
2452
2453         [GTK] Gardening, update API test expectations
2454         https://bugs.webkit.org/show_bug.cgi?id=211337
2455
2456         Unreviewed gardening.
2457
2458         Some tests became flaky under Flatpak.
2459
2460         * TestWebKitAPI/glib/TestExpectations.json:
2461
2462 2020-05-01  Tim Horton  <timothy_horton@apple.com>
2463
2464         Books sometimes ends up with blank pages, especially after adjusting font size
2465         https://bugs.webkit.org/show_bug.cgi?id=211265
2466         <rdar://problem/59898144>
2467
2468         Reviewed by Darin Adler.
2469
2470         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2471         * TestWebKitAPI/Tests/WebKitCocoa/ViewExposedRect.mm: Added.
2472         (forceRepaintCallback):
2473         (TEST):
2474         Add a test for the first problem, which would previously attempt to allocate
2475         ~90TB of tiles, spinning and exploding, and now happily just allocates a few.
2476
2477 2020-05-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2478
2479         Text manipulation should observe the value attribute of some input elements
2480         https://bugs.webkit.org/show_bug.cgi?id=211307
2481         <rdar://problem/61568528>
2482
2483         Reviewed by Darin Adler.
2484
2485         Add a new API test that covers `<input type="submit">` and `<input type="button">`.
2486
2487         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
2488
2489 2020-05-01  Alex Christensen  <achristensen@webkit.org>
2490
2491         Add SPI to move localStorage to a different domain
2492         https://bugs.webkit.org/show_bug.cgi?id=209260
2493         <rdar://problem/60285683>
2494
2495         Reviewed by Brady Eidson.
2496
2497         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2498         (TEST):
2499
2500 2020-05-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2501
2502         Add a test for webkit.org/b/211311
2503         https://bugs.webkit.org/show_bug.cgi?id=211319
2504         <rdar://problem/62663459>
2505
2506         Reviewed by Tim Horton.
2507
2508         Exercise the crash fixed in r261017 with a new API test that loads a page and then uses
2509         `-[WebHTMLView attributedSubstringFromRange:]` to try and grab the contents of the page as an attributed string.
2510
2511         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2512         * TestWebKitAPI/Tests/mac/AttributedString.mm:
2513         (TestWebKitAPI::AttributedStringTest_NewlineAtEndOfDocument::didLoadURL):
2514         (TestWebKitAPI::AttributedStringTest_NewlineAtEndOfDocument::url const):
2515         (TestWebKitAPI::AttributedStringTest_NewlineAtEndOfDocument::runSyncTest):
2516         * TestWebKitAPI/Tests/mac/attributedStringNewlineAtEndOfDocument.html: Added.
2517
2518 2020-05-01  Per Arne Vollan  <pvollan@apple.com>
2519
2520         [iOS] Every running WebContent process should be granted access to frontboard services when Accessibility is enabled
2521         https://bugs.webkit.org/show_bug.cgi?id=211238
2522
2523         Reviewed by Daniel Bates.
2524
2525         * TestWebKitAPI/Tests/WebKit/EnableAccessibility.mm:
2526         (TEST):
2527
2528 2020-05-01  Don Olmstead  <don.olmstead@sony.com>
2529
2530         [GTK] Add additional exports to support hidden visibility
2531         https://bugs.webkit.org/show_bug.cgi?id=211246
2532
2533         Reviewed by Michael Catanzaro.
2534
2535         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2536         * TestWebKitAPI/InjectedBundleMain.cpp:
2537         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2538         (webkit_web_extension_initialize_with_user_data):
2539         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp:
2540         (webkit_web_extension_initialize):
2541         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
2542
2543 2020-05-01  Don Olmstead  <don.olmstead@sony.com>
2544
2545         Use export macros on all platforms
2546         https://bugs.webkit.org/show_bug.cgi?id=211293
2547
2548         Reviewed by Michael Catanzaro.
2549
2550         Remove uses of USE_EXPORT_MACROS from the DumpRenderTree xcode project. This
2551         is the only xcode project that had any references to this value.
2552
2553         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2554
2555 2020-05-01  Peng Liu  <peng.liu6@apple.com>
2556
2557         A PiP window doesn’t actually dismiss after the browser navigates to a different page within the same domain
2558         https://bugs.webkit.org/show_bug.cgi?id=211257
2559
2560         Reviewed by Jer Noble.
2561
2562         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2563         * TestWebKitAPI/Tests/WebKit/AGXCompilerService.mm:
2564         (TEST):
2565         * TestWebKitAPI/Tests/WebKitCocoa/ExitPiPOnSuspendVideoElement.mm: Added.
2566         (-[ExitPiPOnSuspendVideoElementUIDelegate _webView:hasVideoInPictureInPictureDidChange:]):
2567         (TestWebKitAPI::TEST):
2568
2569 2020-05-01  Jonathan Bedard  <jbedard@apple.com>
2570
2571         results.webkit.org: Dropped connections when uploading archives shouldn't be fatal
2572         https://bugs.webkit.org/show_bug.cgi?id=211248
2573
2574         Rubber-stamped by Aakash Jain.
2575
2576         * Scripts/webkitpy/results/upload.py:
2577         (Upload.upload_archive): Dropping a connection when uploading archives shouldn't
2578         be a fatal error.
2579         * Scripts/webkitpy/results/upload_unittest.py:
2580         (UploadTest.test_archive_upload):
2581
2582 2020-05-01  Lauro Moura  <lmoura@igalia.com>
2583
2584         [Flatpak SDK] Honor XDG_RUNTIME_DIR when setting the document path
2585         https://bugs.webkit.org/show_bug.cgi?id=211277
2586
2587         Reviewed by Philippe Normand.
2588
2589         * flatpak/flatpakutils.py:
2590         (WebkitFlatpak.run_in_sandbox): Prefer using the value of
2591         $XDG_RUNTIME_DIR instead of the hardcoded path when setting the
2592         document portal path mount.
2593
2594 2020-05-01  Adrian Perez de Castro  <aperez@igalia.com>
2595
2596         [GTK] File GtkVersioning.h should be excluded from the style checker
2597         https://bugs.webkit.org/show_bug.cgi?id=211262
2598
2599         Reviewed by Carlos Garcia Campos.
2600
2601         * Scripts/webkitpy/style/checker.py: Exclude Source/WebCore/platform/gtk/GtkVersioning.h
2602         from style checks.
2603
2604 2020-04-30  Jiewen Tan  <jiewen_tan@apple.com>
2605
2606         [WebAuthn] Require user gestures for LocalAuthenticator
2607         https://bugs.webkit.org/show_bug.cgi?id=182893
2608         <rdar://problem/43357293>
2609
2610         Reviewed by Brent Fulgham.
2611
2612         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2613         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
2614         (TestWebKitAPI::TEST):
2615         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-la-no-mock.html: Added.
2616         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la-no-mock.html: Added.
2617
2618 2020-04-30  Alex Christensen  <achristensen@webkit.org>
2619
2620         TestWebKitAPI.WebKit.DefaultDisplayName and TestWebKitAPI.WebKit.CustomDisplayName are flaky failures
2621         https://bugs.webkit.org/show_bug.cgi?id=209993
2622         <rdar://problem/61282602>
2623
2624         Reviewed by Chris Dumez.
2625
2626         The display name for the web process is set on a low-priority background queue in WebProcess::updateProcessName()
2627         so sometimes in our test it hasn't executed yet.  If it hasn't executed yet, it will soon, so try until it succeeds.
2628
2629         * TestWebKitAPI/Tests/WebKitCocoa/DisplayName.mm:
2630         (TestWebKitAPI::checkUntilDisplayNameIs):
2631         (TestWebKitAPI::TEST):
2632
2633 2020-04-30  Jiewen Tan  <jiewen_tan@apple.com>
2634
2635         [WebAuthn] Optimize LocalAuthenticator
2636         https://bugs.webkit.org/show_bug.cgi?id=183534
2637         <rdar://problem/43357408>
2638
2639         Reviewed by Brent Fulgham.
2640
2641         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
2642         (-[TestWebAuthenticationPanelDelegate panel:selectAssertionResponse:source:completionHandler:]):
2643         (TestWebKitAPI::TEST):
2644         Adds a new test case for the LRU.
2645
2646 2020-04-30  Kate Cheney  <katherine_cheney@apple.com>
2647
2648         Change default of "inAppBrowserPrivacyQuirks" testing toggle to use it for tests only
2649         https://bugs.webkit.org/show_bug.cgi?id=211209
2650         <rdar://problem/62619659>
2651
2652         Reviewed by Brent Fulgham.
2653
2654         Manually enable inAppBrowserPrivacyQuirks for certain tests which
2655         need script evaluation to test other aspects of In-App Browser Privacy.
2656
2657         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
2658         (TEST):
2659
2660 2020-04-30  Jonathan Bedard  <jbedard@apple.com>
2661
2662         results.webkit.org: Sort out certificates on Catalina
2663         https://bugs.webkit.org/show_bug.cgi?id=202837
2664         <rdar://problem/56177210>
2665
2666         Reviewed by Alex Christensen.
2667
2668         * Scripts/run-javascriptcore-tests:
2669         (uploadResults): Do not allow insecure requests.
2670         * Scripts/webkitpy/results/upload.py:
2671         (Upload.upload): Verify ssl certificates.
2672         (Upload.upload_archive): Ditto.
2673
2674 2020-04-30  Alex Christensen  <achristensen@webkit.org>
2675
2676         Add SPI to change a WKWebView's CORS disabling pattern after initialization
2677         https://bugs.webkit.org/show_bug.cgi?id=211211
2678         <rdar://problem/61837474>
2679
2680         Reviewed by Chris Dumez.
2681
2682         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
2683
2684 2020-04-30  Alex Christensen  <achristensen@webkit.org>
2685
2686         REGRESSION: [ iOS ] http/tests/resourceLoadStatistics/standalone-web-application-exempt-from-website-data-deletion tests are flaky crashing, failing an timing out.
2687         https://bugs.webkit.org/show_bug.cgi?id=211190
2688
2689         Reviewed by Chris Dumez.
2690
2691         * WebKitTestRunner/TestController.cpp:
2692         (WTR::TestController::configureWebsiteDataStoreTemporaryDirectories):
2693         In tests that swap out the WebsiteDataStore, don't use the same paths as the other WebsiteDataStore.
2694
2695 2020-04-30  David Kilzer  <ddkilzer@apple.com>
2696
2697         REGRESSION (r176862, r210483): Leaks of BrowserWindowController in MiniBrowser/mac/AppDelegate.m
2698         <https://webkit.org/b/211243>
2699
2700         Reviewed by Tim Horton.
2701
2702         * MiniBrowser/mac/AppDelegate.m:
2703         (-[BrowserAppDelegate createBrowserWindowController:]):
2704         - Autorelease return value to fix leak.
2705         (-[BrowserAppDelegate newPrivateWindow:]):
2706         - Release controller to fix leak.
2707
2708 2020-04-30  David Kilzer  <ddkilzer@apple.com>
2709
2710         REGRESSION (r247490): Leak of MiniBrowserNSTextFinder._hideInterfaceCallback
2711         <https://webkit.org/b/211242>
2712
2713         Reviewed by Tim Horton.
2714
2715         * MiniBrowser/mac/WK2BrowserWindowController.m:
2716         (-[MiniBrowserNSTextFinder dealloc]): Add.
2717         - Release _hideInterfaceCallback to fix the leak.
2718
2719 2020-04-30  Daniel Bates  <dabates@apple.com>
2720
2721         [iOS] Implement -markedTextRange
2722         https://bugs.webkit.org/show_bug.cgi?id=211148
2723         <rdar://problem/57865890>
2724
2725         Reviewed by Wenson Hsieh.
2726
2727         Add some tests.
2728
2729         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
2730         (TestWebKitAPI::applyAhemStyle): Added.
2731         (TestWebKitAPI::TEST):
2732         * TestWebKitAPI/cocoa/TestWKWebView.h:
2733         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2734         (-[TestWKWebView synchronouslyLoadHTMLStringAndWaitUntilAllImmediateChildFramesPaint:]): Added.
2735
2736 2020-04-30  Claudio Saavedra  <csaavedra@igalia.com>
2737
2738         [GTK4] Add navigation and reload buttons to MiniBrowser
2739         https://bugs.webkit.org/show_bug.cgi?id=211231
2740
2741         Reviewed by Adrian Perez de Castro.
2742
2743         * MiniBrowser/gtk/BrowserWindow.c:
2744         (browserWindowUpdateNavigationMenu):
2745         (webViewIsLoadingChanged):
2746         (browserWindowSetupToolbarItem):
2747         (browser_window_init):
2748
2749 2020-04-30  Philippe Normand  <pnormand@igalia.com>
2750
2751         [SOUP] http/tests/media/video-accept-encoding.html fails
2752         https://bugs.webkit.org/show_bug.cgi?id=211228
2753
2754         Reviewed by Carlos Garcia Campos.
2755
2756         * Scripts/webkitpy/port/gtk.py:
2757         (GtkPort.setup_environ_for_server):
2758         * Scripts/webkitpy/port/wpe.py:
2759         (WPEPort.setup_environ_for_server):
2760
2761 2020-04-30  Andres Gonzalez  <andresg_22@apple.com>
2762
2763         Fix for crashes in accessibility/accessibility-node-memory-management.html in isolated tree mode.
2764         https://bugs.webkit.org/show_bug.cgi?id=211215
2765
2766         Reviewed by Chris Fleizach.
2767
2768         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2769         (WTR::AccessibilityController::executeOnAXThreadIfPossible):
2770         Removed the call CFRunLoopRunInMode and instead we'll use setTimeout in
2771         each of the tests that require to complete a spin of the main run loop.
2772
2773         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
2774         (WTR::AccessibilityController::accessibleElementById):
2775         Need to retain ObjectiveC object when it is retrieved from the secondary thread.
2776
2777         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2778         (WTR::AccessibilityUIElement::getChildrenWithRange): Dito as above.
2779
2780 2020-04-30  Claudio Saavedra  <csaavedra@igalia.com>
2781
2782         [GTK4] Bring back the URI entry to MiniBrowser
2783         https://bugs.webkit.org/show_bug.cgi?id=211186
2784
2785         Reviewed by Carlos Garcia Campos.
2786
2787         GTK4 support for the URI entry added, using a GtkCenterBox
2788         to start layouting a modern version of the toolbar.
2789
2790         * MiniBrowser/gtk/BrowserWindow.c:
2791         (activateUriEntryCallback):
2792         (webViewURIChanged):
2793         (updateUriEntryIcon):
2794         (faviconChanged):
2795         (insertLinkCommandCallback):
2796         (browser_window_init):
2797
2798 2020-04-29  Simon Fraser  <simon.fraser@apple.com>
2799
2800         Add a MiniBrowser option to inset the web view so it doesn't fill the window
2801         https://bugs.webkit.org/show_bug.cgi?id=211216
2802
2803         Reviewed by Tim Horton.
2804
2805         Add a menu item, Debug > Inset Web View to MiniBrowser which insets the view from
2806         the edges of the window, making it possible to debug coordinate conversion issues.
2807
2808         The state is stored in Settings, but unlike other Settings this one doesn't
2809         get populated into the Settings menu because it makes more logical sense grouped
2810         with the options to Hide and Remove the web view.
2811
2812         * MiniBrowser/mac/BrowserWindowController.h:
2813         * MiniBrowser/mac/BrowserWindowController.m:
2814         (-[BrowserWindowController toggleFullWindowWebView:]):
2815         (-[BrowserWindowController webViewFillsWindow]):
2816         (-[BrowserWindowController setWebViewFillsWindow:]):
2817         * MiniBrowser/mac/MainMenu.xib:
2818         * MiniBrowser/mac/SettingsController.h:
2819         * MiniBrowser/mac/SettingsController.m:
2820         (-[SettingsController initWithMenu:]):
2821         (-[SettingsController webViewFillsWindow]):
2822         (-[SettingsController setWebViewFillsWindow:]):
2823         * MiniBrowser/mac/WK1BrowserWindowController.m:
2824         (-[WK1BrowserWindowController validateMenuItem:]):
2825         (-[WK1BrowserWindowController didChangeSettings]):
2826         * MiniBrowser/mac/WK2BrowserWindowController.m:
2827         (-[WK2BrowserWindowController validateMenuItem:]):
2828         (-[WK2BrowserWindowController didChangeSettings]):
2829
2830 2020-04-29  Chris Dumez  <cdumez@apple.com>
2831
2832         REGRESSION(r260791) Network process fails to suspend promptly
2833         https://bugs.webkit.org/show_bug.cgi?id=211207
2834         <rdar://problem/62620454>
2835
2836         Reviewed by Alex Christensen.
2837
2838         Add API test coverage.
2839
2840         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2841         (TEST):
2842
2843 2020-04-29  Kate Cheney  <katherine_cheney@apple.com>
2844
2845         Add better handling of an uncleared bundle identifier in WebKitTestRunner
2846         https://bugs.webkit.org/show_bug.cgi?id=211195
2847         <rdar://problem/62117145>
2848
2849         Reviewed by Alexey Proskuryakov.
2850
2851         * WebKitTestRunner/TestController.cpp:
2852         (WTR::TestController::createWebViewWithOptions):
2853
2854 2020-04-29  Saam Barati  <sbarati@apple.com>
2855
2856         build-jsc should quote the value of compile flags it forwards
2857         https://bugs.webkit.org/show_bug.cgi?id=211204
2858
2859         Reviewed by Mark Lam.
2860
2861         We should quote outgoing compile flags that have an equal in them. Before,
2862         if build-jsc were invoked like:
2863         $ build-jsc --release ARCHS="x86_64 i386"
2864         It'd invoke make like:
2865         $ make release ARCHS=x86_64 i386
2866         leading us to try to build the "i386" target, which doesn't exist.
2867         
2868         This patch makes us invoke make like so:
2869         $ make release ARCHS="x86_64 i386"
2870
2871         * Scripts/build-jsc:
2872         (buildMyProject):
2873
2874 2020-04-29  Alex Christensen  <achristensen@webkit.org>
2875
2876         Add WKNavigationDelegate API shouldAllowDeprecatedTLS
2877         https://bugs.webkit.org/show_bug.cgi?id=210981
2878         <rdar://problem/61742976>
2879
2880         Reviewed by Geoffrey Garen.
2881
2882         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
2883         (-[TLSNavigationDelegate receivedShouldAllowDeprecatedTLS]):
2884         (-[TLSNavigationDelegate webView:authenticationChallenge:shouldAllowDeprecatedTLS:]):
2885         (TestWebKitAPI::TEST):
2886         (-[TLSNavigationDelegate receivedShouldAllowLegacyTLS]): Deleted.
2887         (-[TLSNavigationDelegate _webView:authenticationChallenge:shouldAllowLegacyTLS:]): Deleted.
2888         * TestWebKitAPI/config.h:
2889
2890 2020-04-29  Kate Cheney  <katherine_cheney@apple.com>
2891
2892         Refactor layout tests after updates to In-App Browser Privacy
2893         https://bugs.webkit.org/show_bug.cgi?id=211146
2894         <rdar://problem/62524127>
2895
2896         Reviewed by Brent Fulgham.
2897
2898         Removes two unused functions after updating the test cases.
2899         setInAppBrowserPrivacyEnabled is no longer needed, setting this
2900         in TestOptions is enough. getWebViewCategory is not needed because
2901         this patch deletes the only test which uses it.
2902
2903         Adds a function to clear app-bound sessions between tests now that
2904         multiple tests check for them.
2905
2906         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2907         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2908         (WTR::InjectedBundle::didReceiveMessageToPage):
2909         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2910         (WTR::TestRunner::getWebViewCategory): Deleted.
2911         (WTR::TestRunner::callDidReceiveWebViewCategoryCallback): Deleted.
2912         (WTR::TestRunner::setInAppBrowserPrivacyEnabled): Deleted.
2913         (WTR::TestRunner::callDidSetInAppBrowserPrivacyEnabledCallback): Deleted.
2914         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2915         * WebKitTestRunner/TestController.cpp:
2916         (WTR::TestController::createWebViewWithOptions):
2917         (WTR::TestController::resetStateToConsistentValues):
2918         Move the call to clear the bundle id to happen in
2919         resetStateToConsistentValues to make sure the next test can set the
2920         value if needed (otherwise results in a call to exit(1)).
2921
2922         (WTR::updateTestOptionsFromTestHeader):
2923         (WTR::TestController::clearAppBoundSession):
2924         (WTR::TestController::getWebViewCategory): Deleted.
2925         (WTR::TestController::setInAppBrowserPrivacyEnabled): Deleted.
2926         * WebKitTestRunner/TestController.h:
2927         * WebKitTestRunner/TestInvocation.cpp:
2928         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2929         (WTR::TestInvocation::didSetInAppBrowserPrivacyEnabled): Deleted.
2930         (WTR::TestInvocation::didReceiveWebViewCategory): Deleted.
2931         * WebKitTestRunner/TestInvocation.h:
2932         * WebKitTestRunner/TestOptions.h:
2933         (WTR::TestOptions::hasSameInitializationOptions const):
2934         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2935         (WTR::TestController::platformCreateWebView):
2936         App-bound WebViews now require a special configuration argument. This
2937         patch adds logic to enable that using a new TestOption.
2938         (WTR::TestController::getWebViewCategory): Deleted.
2939
2940 2020-04-29  Aakash Jain  <aakash_jain@apple.com>
2941
2942         [ews] Display flaky test names in build summary when ReRunJavaScriptCoreTests passes
2943         https://bugs.webkit.org/show_bug.cgi?id=210855
2944
2945         Reviewed by Jonathan Bedard.
2946
2947         * BuildSlaveSupport/ews-build/steps.py:
2948         (ReRunJavaScriptCoreTests.evaluateCommand): Display flaky test names in build summary.
2949         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests and removed extra TestReRunJavaScriptCoreTests class.
2950
2951 2020-04-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2952
2953         Unreviewed. Fix GTK4 build after r260891
2954
2955         * MiniBrowser/gtk/BrowserWindow.c:
2956
2957 2020-04-29  Claudio Saavedra  <csaavedra@igalia.com>
2958
2959         [GTK] Remove deprecated GTK API calls from MiniBrowser
2960         https://bugs.webkit.org/show_bug.cgi?id=211171
2961
2962         Reviewed by Carlos Garcia Campos.
2963
2964         In preparation to porting MiniBrowser to GTK4, remove
2965         all deprecated API calls. Also get rid of the --geometry
2966         command-line argument and make it a no-op.
2967
2968         * MiniBrowser/gtk/BrowserDownloadsBar.c:
2969         (browser_downloads_bar_init):
2970         (browser_downloads_bar_new):
2971         (actionButtonClicked):
2972         (browser_download_init):
2973         (downloadFinished):
2974         * MiniBrowser/gtk/BrowserSearchBar.c:
2975         (doSearch):
2976         (searchEntryMenuIconPressedCallback):
2977         (browser_search_bar_init):
2978         * MiniBrowser/gtk/BrowserSettingsDialog.c:
2979         (browser_settings_dialog_init):
2980         * MiniBrowser/gtk/BrowserTab.c:
2981         (createInfoBarQuestionMessage):
2982         (browserTabConstructed):
2983         * MiniBrowser/gtk/BrowserWindow.c:
2984         (browserWindowHistoryItemSelected):
2985         (browserWindowHistoryItemActivated):
2986         (browserWindowCreateBackForwardMenu):
2987         (browserWindowUpdateNavigationMenu):
2988         (backForwardlistChanged):
2989         (updateUriEntryIcon):
2990         (webViewIsLoadingChanged):
2991         (browserWindowSetupEditorToolbarItem):
2992         (browserWindowSetupEditorToolbar):
2993         (browserWindowSwitchTab):
2994         (browserWindowSetupToolbarItem):
2995         (browser_window_init):
2996         (browserWindowUpdateNavigationActions): Deleted.
2997         * MiniBrowser/gtk/main.c:
2998         (main):
2999
3000 2020-04-29  Adrian Perez de Castro  <aperez@igalia.com>
3001
3002         [GTK] Misplaced right click menu on web page due to deprecated gtk_menu_popup()
3003         https://bugs.webkit.org/show_bug.cgi?id=170553
3004
3005         Minor adaptations needed in the API tests to account for the differences between
3006         GtkMenuShell and GtkPopoverMenu.
3007
3008         Reviewed by Carlos Garcia Campos.
3009
3010         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
3011         (lookupWidgetsWalkChild): Added.
3012         (lookupWidgets): Added.
3013
3014 2020-04-28  Said Abou-Hallawa  <sabouhallawa@apple.com>
3015
3016         Upgrade motionmark1.1.plan to r260656
3017         https://bugs.webkit.org/show_bug.cgi?id=211143
3018
3019         Reviewed by Darin Adler.
3020
3021         r260656 includes a fix for the Multiply test.
3022
3023         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan:
3024
3025 2020-04-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3026
3027         [Text manipulation] Add a userInfo dictionary to _WKTextManipulationToken
3028         https://bugs.webkit.org/show_bug.cgi?id=211151
3029         <rdar://problem/62329534>
3030
3031         Reviewed by Darin Adler.
3032
3033         Add a new API test to check the userInfo dictionary on text manipulation tokens.
3034
3035         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
3036
3037 2020-04-28  David Kilzer  <ddkilzer@apple.com>
3038
3039         check-webkit-style should suggest CheckedSize for Checked<size_t, RecordOverflow>
3040         <https://webkit.org/b/211158>
3041
3042         Reviewed by Darin Adler.
3043
3044         * Scripts/webkitpy/style/checkers/cpp.py:
3045         (check_wtf_checked_size): Add checker.
3046         (check_style): Call check_wtf_checked_size() to check.
3047         (CppChecker): Add 'runtime/wtf_checked_size'.
3048         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3049         (WebKitStyleTest.test_wtf_checked_size): Add tests.
3050
3051 2020-04-28  Lauro Moura  <lmoura@igalia.com>
3052
3053         [GTK] update-webkitgtk-libs: TypeError: cannot use a string pattern on a bytes-like object
3054         https://bugs.webkit.org/show_bug.cgi?id=211144
3055
3056         Reviewed by Michael Catanzaro.
3057
3058         Unconditionally decode the output from the 'id' command to make it
3059         work with python3.
3060
3061         Also check if the doc directory exists before passing it to bwrap.
3062         Should avoid errors like these:
3063
3064         bwrap: Can't find source path /run/user/1000/doc: No such file or directory
3065
3066         * flatpak/flatpakutils.py:
3067         (WebkitFlatpak.run_in_sandbox):
3068
3069 2020-04-28  Kate Cheney  <katherine_cheney@apple.com>
3070
3071         Create a mechanism to add missing ITP Database tables when the schema is updated
3072         https://bugs.webkit.org/show_bug.cgi?id=211004
3073         <rdar://problem/62261187>
3074
3075         Reviewed by John Wilander.
3076
3077         Add test case which copies a database schema with a missing table into
3078         the ITP database file, then ensures the pre-seeded data is
3079         migrated over and that the schema now has all tables (including the
3080         previously missing one).
3081
3082         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3083         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3084         (TEST):
3085         * TestWebKitAPI/Tests/WebKitCocoa/missingTopFrameUniqueRedirectSameSiteStrictTableSchema.db: Added.
3086         * TestWebKitAPI/Tests/WebKitCocoa/missingTopFrameUniqueRedirectSameSiteStrictTableSchema.db-shm: Added.
3087         * TestWebKitAPI/Tests/WebKitCocoa/missingTopFrameUniqueRedirectSameSiteStrictTableSchema.db-wal: Added.
3088
3089 2020-04-28  Per Arne Vollan  <pvollan@apple.com>
3090
3091         [Cocoa] Global preferences are not accessible in the WebContent process when CFPrefs direct mode is enabled
3092         https://bugs.webkit.org/show_bug.cgi?id=211075
3093
3094         Reviewed by Brent Fulgham.
3095
3096         * TestWebKitAPI/Tests/WebKit/PreferenceChanges.mm:
3097         (TEST):
3098
3099 2020-04-28  Jonathan Bedard  <jbedard@apple.com>
3100
3101         results.webkit.org: A suite running multiple times in a commit for a single configuration may overwrite upload metadata
3102         https://bugs.webkit.org/show_bug.cgi?id=211097
3103         <rdar://problem/62474538>
3104
3105         Rubber-stamped by Aakash Jain.
3106
3107         Create a new table for uploads which is indexed by both uuid and timestamp so that uploads which share
3108         a configuration and uuid but not a timestamp do not collide.
3109
3110         * resultsdbpy/resultsdbpy/model/upload_context.py:
3111         (UploadContext):
3112         (UploadContext.UploadsByConfigurationLegacy): Renamed from UploadContext.UploadsByConfiguration.
3113         (UploadContext.UploadsByConfiguration): New database table indexed by both timestamp and uuid.
3114         (UploadContext.UploadsByConfiguration.unpack):
3115         (UploadContext.__init__):
3116         (UploadContext.find_test_results): Search both versions of the UploadsByConfiguration table.
3117
3118 2020-04-28  Claudio Saavedra  <csaavedra@igalia.com>
3119
3120         [Linux] Replace --geometry with --fullscreen when using MiniBrowser for WebDriver tests
3121         https://bugs.webkit.org/show_bug.cgi?id=211123
3122
3123         Reviewed by Carlos Alberto Lopez Perez.
3124
3125         MiniBrowser's --geometry is on its way out, so use --fullscreen
3126         instead as it does the job.
3127
3128         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py:
3129         (GTKMiniBrowserDriver.launch_url):
3130
3131 2020-04-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3132
3133         [GTK4] Add support for motion events
3134         https://bugs.webkit.org/show_bug.cgi?id=211073
3135
3136         Reviewed by Adrian Perez de Castro.
3137
3138         Use the GtkOverlay in GTK4 too so that status label is shown when hovering elements.
3139
3140         * MiniBrowser/gtk/BrowserTab.c:
3141         (browserTabConstructed):
3142
3143 2020-04-28  Carlos Garcia Campos  <cgarcia@igalia.com>
3144
3145         [GTK4][Wayland] Add support for rendering web view contents
3146         https://bugs.webkit.org/show_bug.cgi?id=211021
3147
3148         Reviewed by Adrian Perez de Castro.
3149
3150         Set vertical expand of web view to TRUE.
3151
3152         * MiniBrowser/gtk/BrowserTab.c:
3153         (browserTabConstructed):
3154
3155 2020-04-27  Philippe Normand  <pnormand@igalia.com>
3156
3157         [GTK][WebInspector] platformSave broken when running within the Flatpak runtime
3158         https://bugs.webkit.org/show_bug.cgi?id=209473
3159
3160         Reviewed by Adrian Perez de Castro.
3161
3162         * flatpak/flatpakutils.py:
3163         (WebkitFlatpak.run_in_sandbox): White-list the user document
3164         folder into the sandbox. This seems needed by the file-chooser
3165         popup, somehow.
3166
3167 2020-04-27  Jonathan Bedard  <jbedard@apple.com>
3168
3169         results.webkit.org: A suite running multiple times in a commit for a single configuration may pre-empt processing
3170         https://bugs.webkit.org/show_bug.cgi?id=211094
3171         <rdar://problem/62470170>
3172
3173         Reviewed by Aakash Jain.
3174
3175         Hash collision in processing key when results only differ by upload time.
3176
3177         * resultsdbpy/resultsdbpy/model/upload_context.py:
3178         (UploadContext.process_test_results): Include upload timestamp in the hashed key.
3179
3180 2020-04-27  Zhifei Fang  <zhifei_fang@apple.com>
3181
3182         Add some debug output for run-jsc-stress-tests
3183         https://bugs.webkit.org/show_bug.cgi?id=210999
3184         <rdar://problem/61353156>
3185
3186         This will help to address where the script get stucked
3187
3188         Reviewed by Jonathan Bedard.
3189
3190         * Scripts/run-jsc-stress-tests:
3191
3192 2020-04-27  Wenson Hsieh  <wenson_hsieh@apple.com>
3193
3194         Text manipulation should not aggregate text from different navigation anchor elements
3195         https://bugs.webkit.org/show_bug.cgi?id=211081
3196         <rdar://problem/59553658>
3197
3198         Reviewed by Megan Gardner.
3199
3200         Add a new API test, and augment an existing test.
3201
3202         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
3203
3204 2020-04-27  Jonathan Bedard  <jbedard@apple.com>
3205
3206         results.webkit.og: Add investigation endpoint
3207         https://bugs.webkit.org/show_bug.cgi?id=209562
3208
3209         Rubber-stamped by Aakash Jain.
3210
3211         Add an endpoint that allows users to list all test failures given some criteria, and
3212         provide a partial list of failures in the investigation drawer.
3213
3214         * resultsdbpy/resultsdbpy/view/static/js/commit.js:
3215         (CommitTable): Link commit to investigation endpoint.
3216         (_CommitBank.prototype.latest): Populate the CommitBank with the last x commits.
3217         (_CommitBank.prototype.commitsDuringUuid): Renamed commitsDuring.
3218         (_CommitBank.prototype. commitsDuring): Accept a range Uuids instead of a single Uuid.
3219         (_CommitBank.prototype._load): Load a single commit if the before and after uuid match.
3220         * resultsdbpy/resultsdbpy/view/static/js/common.js:
3221         (paramsToQuery): False should be added as a parameter, if provided.
3222         (percentage): Moved from investigate.js.
3223         (elapsedTime): Ditto.
3224         * resultsdbpy/resultsdbpy/view/static/js/configuration.js:
3225         (Configuration.combine): Allow configurations to be combined to a single, more general, configuration.
3226         * resultsdbpy/resultsdbpy/view/static/js/failures.js: Added.
3227         (Failures.prototype.fromEndpoint): Construct a failure object from the failures endpoint.
3228         (Failures.combine): Combine two failure objects together.
3229         (Failures):
3230         (Failures.prototype.toParams): Convert object to parameters for other results database queries.
3231         * resultsdbpy/resultsdbpy/view/static/js/investigate.js:
3232         (elapsed): Used shared time elapsed function.
3233         (percentage): Moved to common.js.
3234         (prioritizedFailures): Return a div with a truncated list of tests which failed.
3235         (resultsForData): Include some number of prioritized test failures based on how many bubbles are
3236         already displayed.
3237         (_InvestigateDrawer.prototype.expand): Dispatch failure request.
3238         (_InvestigateDrawer.prototype.dispatch): Start request to failures endpoint.
3239         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
3240         (TimelineFromEndpoint.prototype.render.onDotEnterFactory): Add link to investigation endpoint.
3241         (Legend): When search parameters change, we need to re-dispatch failure requests.
3242         * resultsdbpy/resultsdbpy/view/suite_view.py:
3243         (SuiteView._suites_for_investigation): Filter parameters for investigation endpoint.
3244         (SuiteView.investigate): Return investigation endpoint html template.
3245         * resultsdbpy/resultsdbpy/view/templates/investigate.html: Added.
3246         (willFilterExpected): Check if the query parameters indicate that expected failures are to be ignored.
3247         (commitsForRange): Return a list of commits for a uuid range.
3248         (SuiteFailuresView.constructor): Abstraction to hold the investigation data for a single suite.
3249         (SuiteFailuresView.reload): Dispatch requests to the results and failures endpoint to populate
3250         investigation data.
3251         (SuiteFailuresView.select): By default, failures for different configurations are collapsed into a single
3252         view. Allows the user to iterate through each configuration that comprises the view.
3253         (SuiteFailuresView.toString):
3254         (populateRanges): Either convert the provided arguments to a range to search for failures and results
3255         in, or use the most recent commit.
3256         (reload): Force all suite views to re-dispatch results and failures requests.
3257         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Add space between suite content and
3258         top bar.
3259         * resultsdbpy/resultsdbpy/view/view_routes.py:
3260         (ViewRoutes.__init__): Add investigate endpoint.
3261
3262 2020-04-27  Tim Horton  <timothy_horton@apple.com>
3263
3264         WebKit.ResizeReversePaginatedWebView is failing (21 pages instead of 20)
3265         https://bugs.webkit.org/show_bug.cgi?id=211001
3266         <rdar://problem/60972357>
3267
3268         Reviewed by Wenson Hsieh.
3269
3270         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
3271         * TestWebKitAPI/Tests/WebKit/lots-of-text-vertical-lr.html:
3272         Use Ahem to keep the layout more stable.
3273
3274 2020-04-27  Per Arne Vollan  <pvollan@apple.com>
3275
3276         [Cocoa] After r258891, r255119 can be reverted
3277         https://bugs.webkit.org/show_bug.cgi?id=211083
3278
3279         Unreviewed revert of r255119.
3280
3281         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3282         * TestWebKitAPI/Tests/WebKit/MimeTypes.mm: Removed.
3283
3284 2020-04-27  Daniel Bates  <dabates@apple.com>
3285
3286         Caret may be placed in the wrong spot for text input context that is a form control
3287         https://bugs.webkit.org/show_bug.cgi?id=210939
3288         <rdar://problem/61943089>
3289
3290         Reviewed by Darin Adler.
3291
3292         Add a test.
3293
3294         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3295         (TestWebKitAPI::TEST):
3296
3297 2020-04-27  Alexey Proskuryakov  <ap@apple.com>
3298
3299         Make run-safari --ios-simulator work again
3300         https://bugs.webkit.org/show_bug.cgi?id=211008
3301
3302         Reviewed by Darin Adler.
3303
3304         While at it, removed all direct uses of device.plist, and all use of Foundation.
3305
3306         * Scripts/webkitdirs.pm: Stopped exporting unused simulator related functions. New
3307         code should be using webkitpy.
3308         (simulatorDeviceFromJSON): Helper function for parsing simctl output.
3309         (iOSSimulatorDevices): Use simctl instead of reading device.plist.
3310         (createiOSSimulatorDevice): Device creation appears to be synchronous, I couldn't
3311         find any reason for waiting and retrying.
3312         (iosSimulatorApplicationsPath): This is part of the actual fix - runtime path built
3313         here was incorrect; switched to one provided by simctl.
3314         (shutDownIOSSimulatorDevice): Added an early return to avoid stderr spew.
3315         (relaunchIOSSimulator): Another part of the actual fix: open Simulator.app before booting the
3316         simulator to have it visible; CurrentDeviceUDID doesn't work.
3317         (iosSimulatorDeviceByUDID): Stop using device.plist.
3318         (runIOSWebKitAppInSimulator): Stop quitting Simulator.app, we only needed to shut down
3319         the device.
3320         (iOSSimulatorDevicesPath): Deleted.
3321         (quitIOSSimulator): Deleted.
3322
3323 2020-04-27  Daniel Bates  <dabates@apple.com>
3324
3325         Text interaction tests should ensure view is not scroll instead of looking for a zoom change
3326         https://bugs.webkit.org/show_bug.cgi?id=211056
3327
3328         Reviewed by Dean Jackson.
3329
3330         For the text interaction sub-tests, override the scroll view's delegate so as to track
3331         whether a scroll occurred or not instead of looking at the zoom scale. As the tests are
3332         written looking at the zoom scale is racy. It is simpler and deterministic to detect
3333         whether the scroll view scrolled.
3334
3335         The purpose of the text interaction sub-tests are to ensure that zooming to reveal
3336         the focused element is suppressed until the interaction completes with a call to
3337         -_didFinishTextInteractionInTextInputContext. I added some more assertions to ensure this.
3338
3339         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3340         (-[TextInteractionScrollDelegate scrollViewDidScroll:]):
3341         (TestWebKitAPI::TEST):
3342
3343 2020-04-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3344
3345         [GTK4] Make it possible to build with GTK4 without errors
3346         https://bugs.webkit.org/show_bug.cgi?id=210967
3347
3348         Reviewed by Adrian Perez de Castro.
3349
3350         * MiniBrowser/gtk/BrowserCellRendererVariant.c:
3351         * MiniBrowser/gtk/BrowserCellRendererVariant.h:
3352         * MiniBrowser/gtk/BrowserDownloadsBar.c:
3353         * MiniBrowser/gtk/BrowserDownloadsBar.h:
3354         * MiniBrowser/gtk/BrowserMain.c: Added.
3355         (browser_main):
3356         (browser_main_quit):
3357         * MiniBrowser/gtk/BrowserMain.h: Added.
3358         * MiniBrowser/gtk/BrowserSearchBar.c:
3359         * MiniBrowser/gtk/BrowserSearchBar.h:
3360         * MiniBrowser/gtk/BrowserSettingsDialog.c:
3361         * MiniBrowser/gtk/BrowserSettingsDialog.h:
3362         * MiniBrowser/gtk/BrowserTab.c:
3363         (browserTabConstructed):
3364         (browser_tab_start_search):
3365         (browser_tab_stop_search):
3366         (browser_tab_enter_fullscreen):
3367         (browser_tab_leave_fullscreen):
3368         * MiniBrowser/gtk/BrowserTab.h:
3369         * MiniBrowser/gtk/BrowserWindow.c:
3370         (webViewURIChanged):
3371         (resetEntryProgress):
3372         (webViewLoadProgressChanged):
3373         (downloadStarted):
3374         (browserWindowUpdateNavigationActions):
3375         (webViewReadyToShow):
3376         (browserWindowUpdateZoomActions):
3377         (webViewZoomLevelChanged):
3378         (updateUriEntryIcon):
3379         (webViewIsLoadingChanged):
3380         (browserWindowFinalize):
3381         (browserWindowSetupEditorToolbar):
3382         (browserWindowSwitchTab):
3383         (browser_window_init):
3384         (browser_window_class_init):
3385         (browser_window_new):
3386         (browser_window_append_view):
3387         (browser_window_set_background_color):
3388         (browser_window_get_or_create_web_view_for_automation):
3389         * MiniBrowser/gtk/CMakeLists.txt:
3390         * MiniBrowser/gtk/main.c:
3391         (main):
3392         * PlatformGTK.cmake:
3393         * Scripts/webkitpy/style/checker.py:
3394         * TestWebKitAPI/glib/PlatformGTK.cmake:
3395
3396 2020-04-27  Philippe Normand  <pnormand@igalia.com>
3397
3398         [Flatpak SDK] Regenerate toolchains only if new updates were downloaded
3399         https://bugs.webkit.org/show_bug.cgi?id=210804
3400
3401         Reviewed by Žan Doberšek.
3402
3403         The SDK toolchain archives are now regenerated only if an actual
3404         update was downloaded from the Flatpak repository. Some redundant
3405         flatpak calls were removed as well, such as the GL extension and
3406         Debug reinstalls that were happening during webkit-flatpak
3407         updates.
3408
3409         * flatpak/flatpakutils.py:
3410         (FlatpakObject.flatpak):
3411         (FlatpakRepo.__init__):
3412         (WebkitFlatpak.main):
3413         (WebkitFlatpak.setup_dev_env):
3414
3415 2020-04-27  Philippe Normand  <pnormand@igalia.com>
3416
3417         unable to build from tot - linux - flatpakutils.py - TypeError: not enough arguments for format string
3418         https://bugs.webkit.org/show_bug.cgi?id=210941
3419
3420         Reviewed by Žan Doberšek.
3421
3422         * flatpak/flatpakutils.py:
3423         (check_flatpak): Fix error message formating.
3424
3425 2020-04-26  Yoshiaki Jitsukawa  <yoshiaki.jitsukawa@sony.com>
3426
3427         [PlayStation] Enable TestWTF and TestWebCore
3428         https://bugs.webkit.org/show_bug.cgi?id=208849
3429
3430         Reviewed by Don Olmstead.
3431
3432         * TestWebKitAPI/PlatformPlayStation.cmake:
3433         * TestWebKitAPI/playstation/main.cpp: Added.
3434         (main): Load runtime libraries.
3435
3436 2020-04-26  Yusuke Suzuki  <ysuzuki@apple.com>
3437
3438         Warn when NeverDestroyed<Lock> is used
3439         https://bugs.webkit.org/show_bug.cgi?id=211054
3440
3441         Reviewed by Darin Adler.
3442
3443         WTF::Lock and WTF::Condition are designed to be constant-initialize compliant. So NeverDestroyed<> for these types are not necessary,
3444         or rather, introducing race condition issue while `static Lock` doesn't have that issue. This patch adds lint rules which prevent
3445         us from using `NeverDestroyed<Lock>` and `LazyNeverDestroyed<Lock>`.
3446
3447         * Scripts/webkitpy/style/checkers/cpp.py:
3448         (check_wtf_never_destroyed):
3449         (check_style):
3450         (CppChecker):
3451         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3452         (WebKitStyleTest.test_wtf_never_destroyed):
3453
3454 2020-04-25  Darin Adler  <darin@apple.com>
3455
3456         [Cocoa] Deal with another round of Xcode upgrade checks
3457         https://bugs.webkit.org/show_bug.cgi?id=211027
3458
3459         Reviewed by Alexey Proskuryakov.
3460
3461         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Bump the upgrade check version.
3462
3463         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Bump the upgrade check version.
3464         Add a harmless base localization; this project contains nothing localized. Also let the
3465         script sort the project.
3466
3467         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Bump the upgrade check version.
3468         Add a harmless base localization; this project contains nothing localized. Also let the
3469         script sort the project.
3470
3471 2020-04-25  Darin Adler  <darin@apple.com>
3472
3473         Move URL to use StringView when returning substrings of the URL
3474         https://bugs.webkit.org/show_bug.cgi?id=210431
3475
3476         Reviewed by Anders Carlsson.
3477
3478         * TestWebKitAPI/Tests/WTF/URL.cpp: Removed the test for
3479         equalIgnoringQueryAndFragment since we removed that function.
3480         Updated for rename of URL::password from URL::pass.
3481         Updated arguments to isMatchingDomain to pass literals that can be converted
3482         to StringView rather than ASCIILiteral, which StringView doesn't yet support.
3483
3484         * TestWebKitAPI/Tests/WebCore/URLParserTextEncoding.cpp:
3485         (TestWebKitAPI::checkURL): Updated for rename of URL::password from URL::pass.
3486         (TestWebKitAPI::checkRelativeURL): Ditto.
3487         (TestWebKitAPI::checkURLDifferences): Ditto.
3488         (TestWebKitAPI::checkRelativeURLDifferences): Ditto.
3489         (TestWebKitAPI::testUserPassword): Ditto.
3490
3491 2020-04-25  Diego Pino Garcia  <dpino@igalia.com>
3492
3493         [Flatpak SDK][EWS] Install dependencies step needs configuration as argument
3494         https://bugs.webkit.org/show_bug.cgi?id=210913
3495
3496         Follow-up on r260560. The same change is needed for EWS bots.
3497
3498         Reviewed by Philippe Normand.
3499
3500         * BuildSlaveSupport/ews-build/steps.py:
3501         (InstallGtkDependencies): Pass 'configuration' value (Release, Debug).
3502         (InstallWpeDependencies): Pass 'configuration' value (Release, Debug).
3503
3504 2020-04-24  Alex Christensen  <achristensen@webkit.org>
3505
3506         REGRESSION(260485) Payment requests don't do anything
3507         https://bugs.webkit.org/show_bug.cgi?id=210997
3508
3509         Reviewed by Darin Adler.
3510
3511         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
3512         (TestWebKitAPI::TEST):
3513
3514 2020-04-24  Wenson Hsieh  <wenson_hsieh@apple.com>
3515
3516         Make some more adjustments to TextManipulationController's paragraph boundary heuristic
3517         https://bugs.webkit.org/show_bug.cgi?id=210993
3518         <rdar://problem/61571299>
3519
3520         Reviewed by Tim Horton.
3521
3522         Add a new API test with buttons and links styled with `display: inline-block;`. Additionally, rebaseline an
3523         existing API test that exercises inline-block list items.
3524
3525         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
3526
3527 2020-04-24  Chris Dumez  <cdumez@apple.com>
3528
3529         [iOS] Always run WKTR's WKWebViews at foreground priority
3530         https://bugs.webkit.org/show_bug.cgi?id=210991
3531
3532         Reviewed by Keith Miller.
3533
3534         Always run WKTR's WKWebViews at foreground priority. This makes sure that they don't suspend and
3535         run at foreground priority on iOS, even if those views are not visible on screen.
3536         This is an issue to address flakiness on the bots.
3537
3538         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3539         (WTR::initializeWebViewConfiguration):
3540
3541 2020-04-24  Kate Cheney  <katherine_cheney@apple.com>
3542
3543         Removing website data for a domain should delete corresponding ITP entry
3544         https://bugs.webkit.org/show_bug.cgi?id=210864
3545         <rdar://problem/59473193>
3546
3547         Reviewed by John Wilander.
3548
3549         Created 2 new APIs for testing. One to mimic clearing website data
3550         for a domain, and one to check if the domain exists in the database
3551         after a deletion was requested.
3552
3553         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3554         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3555         (WTR::TestRunner::doesStatisticsDomainIDExistInDatabase):
3556         (WTR::TestRunner::domainIDExistsInDatabase): Deleted.
3557         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3558         * WebKitTestRunner/TestController.cpp:
3559         (WTR::TestController::doesStatisticsDomainIDExistInDatabase):
3560         (WTR::TestController::domainIDExistsInDatabase): Deleted.
3561         * WebKitTestRunner/TestController.h:
3562         * WebKitTestRunner/TestInvocation.cpp:
3563         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3564
3565 2020-04-24  Antoine Quint  <graouts@apple.com>
3566
3567         Update the css/css-animations WPT tests
3568         https://bugs.webkit.org/show_bug.cgi?id=210964
3569
3570         Reviewed by Dean Jackson.
3571
3572         Turn on the CSSCustomPropertiesAndValues experimental feature which a new test relies on.
3573
3574         * DumpRenderTree/mac/DumpRenderTree.mm:
3575         (enableExperimentalFeatures):
3576         * DumpRenderTree/win/DumpRenderTree.cpp:
3577         (enableExperimentalFeatures):
3578
3579 2020-04-24  David Kilzer  <ddkilzer@apple.com>
3580
3581         check-webkit-style should recognize *Internal.h and *Private.h as primary headers
3582         <https://webkit.org/b/210979>
3583
3584         Reviewed by Darin Adler.
3585
3586         * Scripts/webkitpy/style/checkers/cpp.py:
3587         (_classify_include): If a header has an "Internal.h" or a
3588         "Private.h" suffix with the same base name as the source file,
3589         consider it a primary header--the header that comes after
3590         "config.h".
3591         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3592         (OrderOfIncludesTest.test_classify_include): Add tests.
3593
3594 2020-04-24  Alex Christensen  <achristensen@webkit.org>
3595
3596         SPI clients using fastServerTrustEvaluationEnabled need SPI to inform them of modern TLS negotiation
3597         https://bugs.webkit.org/show_bug.cgi?id=210533
3598
3599         Reviewed by Brady Eidson.
3600
3601         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
3602         (-[TLSNavigationDelegate waitForDidNegotiateModernTLS]):
3603         (-[TLSNavigationDelegate _webView:didNegotiateModernTLS:]):
3604         (TestWebKitAPI::TEST):
3605
3606 2020-04-24  Brian Burg  <bburg@apple.com>
3607
3608         webkitpy: update autoinstalled mozprocess dependency to 1.1.0 (adds python3 support)
3609         https://bugs.webkit.org/show_bug.cgi?id=210220
3610         <rdar://problem/58881483>
3611
3612         Reviewed by Anders Carlsson.
3613
3614         * Scripts/webkitpy/thirdparty/__init__.py:
3615         (AutoinstallImportHook._install_mozprocess):
3616
3617 2020-04-24  Philippe Normand  <pnormand@igalia.com>
3618
3619         [GTK][WPE] White-list more GStreamer environment variables in webkitpy
3620         https://bugs.webkit.org/show_bug.cgi?id=210854
3621         <rdar://problem/62238305>
3622
3623         Reviewed by Carlos Alberto Lopez Perez.
3624
3625         Extra variables need to be white-listed when the webkitpy tooling
3626         runs inside a gst-build environment, those variables are needed so
3627         that uninstalled GStreamer plugins are correctly picked up.
3628
3629         Additionally we now correctly white-list the
3630         WEBKIT_GST_USE_PLAYBIN3 env var. USE_PLAYBIN3 shouldn't be used
3631         anymore.
3632
3633         * Scripts/webkitpy/port/gtk.py:
3634         (GtkPort.setup_environ_for_server):
3635         * Scripts/webkitpy/port/wpe.py:
3636         (WPEPort.setup_environ_for_server):
3637
3638 2020-04-23  Yusuke Suzuki  <ysuzuki@apple.com>
3639
3640         stress/ensure-crash.js shouldn't spew stuff onto my screen
3641         https://bugs.webkit.org/show_bug.cgi?id=210931
3642
3643         Reviewed by Ross Kirsling.
3644
3645         Set noisyOutputHandler when crash! is specified. We also specify noisyOutputHandler for runComplexTest.
3646
3647         * Scripts/run-jsc-stress-tests:
3648         * Scripts/webkitruby/jsc-stress-test-writer-default.rb:
3649         * Scripts/webkitruby/jsc-stress-test-writer-playstation.rb:
3650         * Scripts/webkitruby/jsc-stress-test-writer-ruby.rb:
3651
3652 2020-04-23  Yusuke Suzuki  <ysuzuki@apple.com>
3653
3654         Disable useKernTCSM=false for JSC stress tests to make EWS faster
3655         https://bugs.webkit.org/show_bug.cgi?id=210950
3656
3657         Reviewed by Mark Lam.
3658
3659         This patch removes "JSC_useKernTCSM=false" environment variable in JSC stress tests.
3660         Alexey found that this causes EWS JSC stress tests slow down (from roughly 63 mins to 83 mins).
3661         This slow down happens in Mac Pro (which is used in JSC EWS right now), and this slow down does
3662         not happen in Mac mini (post-commit buildbot) and rather improves Mac Mini execution time by 15%,
3663         but keeping EWS faster is more important than making post-commit bots faster.
3664
3665         * Scripts/run-javascriptcore-tests:
3666
3667 2020-04-23  Yusuke Suzuki  <ysuzuki@apple.com>
3668
3669         Support `--report-execution-time` to report execution time for each JSC stress test
3670         https://bugs.webkit.org/show_bug.cgi?id=210938
3671
3672         Reviewed by Saam Barati.
3673
3674         We can run `run-javascriptcore-tests` with `--report-execution-time` option to report execution time for each JSC stress test,
3675         to figure out which test is taking a long time. It appends execution-time to the verbose log. To see it stderr, --verbose is also
3676         required.
3677
3678         $ run-javascriptcore-tests .... --verbose --report-execution-time
3679
3680         * Scripts/run-javascriptcore-tests:
3681         (runJSCStressTests):
3682         * Scripts/run-jsc-stress-tests:
3683         * Scripts/webkitruby/jsc-stress-test-writer-default.rb:
3684
3685 2020-04-23  Wenson Hsieh  <wenson_hsieh@apple.com>
3686
3687         Text manipulation does not account for text in fully clipped containers
3688         https://bugs.webkit.org/show_bug.cgi?id=210940
3689         <rdar://problem/61137648>
3690
3691         Reviewed by Tim Horton.
3692
3693         Add a new text manipulation API test.
3694
3695         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
3696         (TestWebKitAPI::TEST):
3697
3698 2020-04-23  Jer Noble  <jer.noble@apple.com>
3699
3700         REGRESSION (r260278): TestWebKitAPI.Fullscreen.Delegate is timing out on macOS bots
3701         https://bugs.webkit.org/show_bug.cgi?id=210676
3702         <rdar://problem/61953702>
3703
3704         Reviewed by Daniel Bates.
3705
3706         A number of API tests modify the WKWebViewConfiguration after calling -[WKWebView initWithFrame:configuration:], which
3707         could be a source of failures or flakiness. Update these tests to set those configuration values before passing the
3708         configuration to WKWebView.
3709
3710         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenAlert.mm:
3711         (TestWebKitAPI::TEST):
3712         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
3713         (TestWebKitAPI::TEST):
3714         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenLayoutConstraints.mm:
3715         (TestWebKitAPI::TEST):
3716         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
3717         (TestWebKitAPI::TEST):
3718         * TestWebKitAPI/Tests/WebKitCocoa/TopContentInset.mm:
3719         (TestWebKitAPI::TEST):
3720
3721 2020-04-23  Saam Barati  <sbarati@apple.com>
3722
3723         DumpRenderTree should have the JIT entitlement on Mac
3724         https://bugs.webkit.org/show_bug.cgi?id=210887
3725         <rdar://problem/62228740>
3726
3727         Reviewed by Tim Horton.
3728
3729         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3730         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3731         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3732         * DumpRenderTree/mac/Configurations/DumpRenderTree.entitlements: Added.
3733         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
3734
3735 2020-04-23  Kate Cheney  <katherine_cheney@apple.com>
3736
3737         All ITP database tables should reference the ObservedDomains table on DELETE CASCADE
3738         https://bugs.webkit.org/show_bug.cgi?id=210874
3739         <rdar://problem/62209438>
3740
3741         Reviewed by Brady Eidson.
3742
3743         Adds a new database file with pre-entered values and the old schema.
3744         Adds an API test which checks if the data was migrated after
3745         initializing the ITP database.
3746
3747         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3748         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3749         (TEST):
3750         * TestWebKitAPI/Tests/WebKitCocoa/incorrectCreateTableSchema.db: Added.
3751         * TestWebKitAPI/Tests/WebKitCocoa/incorrectCreateTableSchema.db-shm: Added.
3752         * TestWebKitAPI/Tests/WebKitCocoa/incorrectCreateTableSchema.db-wal: Added.
3753
3754 2020-04-23  Don Olmstead  <don.olmstead@sony.com>
3755
3756         [CMake] CMAKE_BINARY_DIR should always be a PRIVATE include directory
3757         https://bugs.webkit.org/show_bug.cgi?id=196717
3758
3759         Reviewed by Michael Catanzaro.
3760
3761         Include CMAKE_BINARY_DIR.
3762
3763         * MiniBrowser/gtk/CMakeLists.txt:
3764         * TestWebKitAPI/glib/CMakeLists.txt:
3765
3766 2020-04-23  Ryan Haddad  <ryanhaddad@apple.com>
3767
3768         Unreviewed, reverting r260552.
3769
3770         Broke internal builds.
3771
3772         Reverted changeset:
3773
3774         "DumpRenderTree should have the JIT entitlement on Mac"
3775         https://bugs.webkit.org/show_bug.cgi?id=210887
3776         https://trac.webkit.org/changeset/260552
3777
3778 2020-04-23  Wenson Hsieh  <wenson_hsieh@apple.com>
3779
3780         Add a heuristic for text manipulation to treat some list items as paragraph boundaries
3781         https://bugs.webkit.org/show_bug.cgi?id=210915
3782         <rdar://problem/61907080>
3783
3784         Reviewed by Megan Gardner.
3785
3786         Add a new API test to exercise text manipulation over several different cases of lists and list items.
3787
3788         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
3789         (TestWebKitAPI::TEST):
3790
3791 2020-04-23  Commit Queue  <commit-queue@webkit.org>
3792
3793         Unreviewed, reverting r260562.
3794         https://bugs.webkit.org/show_bug.cgi?id=210924
3795
3796         It caused 3 new failures and 1 timeout in GTK API tests
3797         (Requested by clopez on #webkit).
3798
3799         Reverted changeset:
3800
3801         "[GTK][WPE] White-list more GStreamer environment variables in
3802         webkitpy"
3803         https://bugs.webkit.org/show_bug.cgi?id=210854
3804         https://trac.webkit.org/changeset/260562
3805
3806 2020-04-23  Sihui Liu  <sihui_liu@apple.com>
3807
3808         TextManipulationController should set range of paragraph using token's positions
3809         https://bugs.webkit.org/show_bug.cgi?id=210866
3810         <rdar://problem/60646283>
3811
3812         Reviewed by Wenson Hsieh.
3813
3814         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
3815         (TestWebKitAPI::TEST):
3816
3817 2020-04-23  Emilio Cobos Álvarez  <emilio@crisal.io>
3818
3819         Unreviewed, add my bugzilla / slack nick to contributors.json
3820
3821         * Scripts/webkitpy/common/config/contributors.json:
3822
3823 2020-04-23  Philippe Normand  <pnormand@igalia.com>
3824
3825         [JHBuild] Add mock release/debug options to the update script
3826
3827         Rubber-stamped by Carlos Alberto Lopez Perez.
3828
3829         These options are now required after r260560. They're not used
3830         though because JHBuild itself doesn't have the notion of build
3831         configuration, unlike the Flatpak SDK.
3832
3833         * Scripts/update-webkit-libs-jhbuild:
3834
3835 2020-04-23  Philippe Normand  <pnormand@igalia.com>
3836
3837         [GTK][WPE] White-list more GStreamer environment variables in webkitpy
3838         https://bugs.webkit.org/show_bug.cgi?id=210854
3839
3840         Reviewed by Adrian Perez de Castro.
3841
3842         Extra variables need to be white-listed when the webkitpy tooling
3843         runs inside a gst-build environment, those variables are needed so
3844         that uninstalled GStreamer plugins are correctly picked up.
3845
3846         Additionally we now correctly white-list the
3847         WEBKIT_GST_USE_PLAYBIN3 env var. USE_PLAYBIN3 shouldn't be used
3848         anymore.
3849
3850         * Scripts/webkitpy/port/gtk.py:
3851         (GtkPort.setup_environ_for_server):
3852         * Scripts/webkitpy/port/wpe.py:
3853         (WPEPort.setup_environ_for_server):
3854
3855 2020-04-23  Diego Pino Garcia  <dpino@igalia.com>
3856
3857         [Flatpak SDK] Install dependencies step needs configuration as argument
3858         https://bugs.webkit.org/show_bug.cgi?id=210898
3859
3860         Reviewed by Philippe Normand.
3861
3862         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3863         (InstallGtkDependencies): Pass 'configuration' value (Release, Debug).
3864         (InstallWpeDependencies): Pass 'configuration' value (Release, Debug).
3865
3866 2020-04-22  Darin Adler  <darin@apple.com>
3867
3868         [Cocoa] Build with UChar as char16_t even in builds that use Apple's internal SDK
3869         https://bugs.webkit.org/show_bug.cgi?id=210845
3870
3871         Reviewed by Anders Carlsson.
3872
3873         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
3874         (TestWebKitAPI::TEST): Get rid of an obsolete cast to unsigned to work
3875         around uint16_t not being treated as a number by makeString.
3876         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
3877         (TestWebKitAPI::TEST): Ditto.
3878         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
3879         (TestWebKitAPI::TEST): Ditto.
3880         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
3881         (TestWebKitAPI::TEST): Ditto.
3882
3883         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3884         Add an include needed since EvironmentUtilities.h now includes less.
3885
3886 2020-04-22  Saam Barati  <sbarati@apple.com>
3887
3888         DumpRenderTree should have the JIT entitlement on Mac
3889         https://bugs.webkit.org/show_bug.cgi?id=210887
3890
3891         Reviewed by Tim Horton.
3892
3893         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3894         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig:
3895         * DumpRenderTree/mac/Configurations/DumpRenderTree.entitlements: Added.
3896         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
3897
3898 2020-04-22  Chris Dumez  <cdumez@apple.com>
3899
3900         [iOS] Expose -_webView:willGoToBackForwardListItem:inPageCache:
3901         https://bugs.webkit.org/show_bug.cgi?id=210878
3902         <rdar://problem/62202276>
3903
3904         Reviewed by Alex Christensen.
3905
3906         Enable corresponding API test on iOS.
3907
3908         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
3909
3910 2020-04-22  Daniel Bates  <dabates@apple.com>
3911
3912         Add a test for -focusTextInputContext on a field in detached frame
3913         https://bugs.webkit.org/show_bug.cgi?id=210704
3914
3915         Reviewed by Wenson Hsieh.
3916
3917         Calling -focusTextInputContext on a field in a detached frame should not
3918         cause a focus change. Add a test to ensure this behavior doesn't regress.
3919
3920         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3921         (TEST):
3922
3923 2020-04-22  Don Olmstead  <don.olmstead@sony.com>
3924
3925         [CMake] Use WEBKIT_EXECUTABLE in WebKitTestRunner
3926         https://bugs.webkit.org/show_bug.cgi?id=210132
3927
3928         Reviewed by Adrian Perez de Castro.
3929
3930         Modify CMake code to use WEBKIT_EXECUTABLE when creating WebKitTestRunner.
3931
3932         * WebKitTestRunner/CMakeLists.txt:
3933         * WebKitTestRunner/PlatformFTW.cmake:
3934         * WebKitTestRunner/PlatformGTK.cmake:
3935         * WebKitTestRunner/PlatformWPE.cmake:
3936         * WebKitTestRunner/PlatformWin.cmake:
3937
3938 2020-04-22  Don Olmstead  <don.olmstead@sony.com>
3939
3940         [CMake] Add WebKit::WebCoreTestSupport target
3941         https://bugs.webkit.org/show_bug.cgi?id=210867
3942
3943         Reviewed by Michael Catanzaro.
3944
3945         Use the WebKit::WebCoreTestSupport target in DumpRenderTree. Fix an
3946         include for WPE in WebKitTestRunner.
3947
3948         * DumpRenderTree/CMakeLists.txt:
3949         * DumpRenderTree/PlatformWin.cmake:
3950         * WebKitTestRunner/PlatformWPE.cmake:
3951
3952 2020-04-22  Sihui Liu  <sihui_liu@apple.com>
3953
3954         TextManipulation.CompleteTextManipulationAvoidCrashingWhenContentIsRemoved does not wait for result
3955         https://bugs.webkit.org/show_bug.cgi?id=210871
3956
3957         Reviewed by Alex Christensen.
3958
3959         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
3960         (TestWebKitAPI::TEST):
3961
3962 2020-04-22  Alex Christensen  <achristensen@webkit.org>
3963
3964         Add unit test for resuming downloads
3965         https://bugs.webkit.org/show_bug.cgi?id=210852
3966
3967         Reviewed by Brady Eidson.
3968
3969         This is a test that we should've written years ago.
3970         I made HTTPServer able to take a Function that takes a nw_connection_t to give it more power than declarative request/response pairs.
3971         I made TestDownloadDelegate to be reused by future tests, like those I'm going to add for  bug 210313.
3972
3973         * TestWebKitAPI/SourcesCocoa.txt:
3974         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3975         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3976         (longString):
3977         (TEST):
3978         * TestWebKitAPI/cocoa/HTTPServer.h:
3979         (TestWebKitAPI::HTTPServer::totalRequests const): Deleted.
3980         * TestWebKitAPI/cocoa/HTTPServer.mm:
3981         (TestWebKitAPI::HTTPServer::RequestData::RequestData):
3982         (TestWebKitAPI::HTTPServer::listenerParameters):
3983         (TestWebKitAPI::startListening):
3984         (TestWebKitAPI::HTTPServer::HTTPServer):
3985         (TestWebKitAPI::HTTPServer::totalRequests const):
3986         (TestWebKitAPI::dataFromString):
3987         (TestWebKitAPI::nullTerminatedRequest):
3988         (TestWebKitAPI::HTTPServer::respondToRequests):
3989         * TestWebKitAPI/cocoa/TestDownloadDelegate.h: Added.
3990         * TestWebKitAPI/cocoa/TestDownloadDelegate.mm: Added.
3991         (-[TestDownloadDelegate _downloadDidStart:]):
3992         (-[TestDownloadDelegate _download:didReceiveServerRedirectToURL:]):
3993         (-[TestDownloadDelegate _download:didReceiveResponse:]):
3994         (-[TestDownloadDelegate _download:didReceiveData:]):
3995         (-[TestDownloadDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3996         (-[TestDownloadDelegate _downloadDidFinish:]):
3997         (-[TestDownloadDelegate _download:didFailWithError:]):
3998         (-[TestDownloadDelegate _downloadDidCancel:]):
3999         (-[TestDownloadDelegate _download:didReceiveAuthenticationChallenge:completionHandler:]):
4000         (-[TestDownloadDelegate _download:didCreateDestination:]):
4001         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
4002         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
4003         (-[TestNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
4004
4005 2020-04-22  Saam Barati  <sbarati@apple.com>
4006
4007         makeValueRefForValue should be robust against the type encoding of a NSNumber backed by a boolean
4008         https://bugs.webkit.org/show_bug.cgi?id=210821
4009         <rdar://problem/62136598>
4010
4011         Reviewed by Tim Horton.
4012
4013         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
4014         (makeValueRefForValue):
4015
4016 2020-04-21  Ryan Haddad  <ryanhaddad@apple.com>
4017
4018         Unreviewed, reverting r260410.
4019
4020         Caused crashes in Safari
4021
4022         Reverted changeset:
4023
4024         "SPI clients using fastServerTrustEvaluationEnabled need SPI
4025         to inform them of modern TLS negotiation"
4026         https://bugs.webkit.org/show_bug.cgi?id=210533
4027         https://trac.webkit.org/changeset/260410
4028
4029 2020-04-21  Cathie Chen  <cathiechen@igalia.com>
4030
4031         REGRESSION (r254790): No longer get smooth scrolling on music.apple.com
4032         https://bugs.webkit.org/show_bug.cgi?id=210634
4033
4034         Reviewed by Darin Adler.
4035
4036         Add settings-flag. Add support for CSSOMViewSmoothScrolling on Windows DumpRenderTree.
4037
4038         * DumpRenderTree/win/DumpRenderTree.cpp:
4039         (enableExperimentalFeatures):
4040         (setWebPreferencesForTestOptions):
4041         * Scripts/webkitpy/style/checkers/jsonchecker.py:
4042         (JSONCSSPropertiesChecker.check_codegen_properties):
4043
4044 2020-04-21  Peng Liu  <peng.liu6@apple.com>
4045
4046         Fix MACCATALYST build failures
4047         https://bugs.webkit.org/show_bug.cgi?id=210815
4048
4049         Reviewed by Tim Horton.
4050
4051         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4052
4053 2020-04-19  Darin Adler  <darin@apple.com>
4054
4055         [Cocoa] Use createNSArray in many more places that build NSArray objects from C++ collections
4056         https://bugs.webkit.org/show_bug.cgi?id=210702
4057
4058         Reviewed by Alex Christensen.
4059
4060         * DumpRenderTree/mac/DumpRenderTree.mm:
4061         (activateTestingFonts): Use constexpr and NSString instead of a null-pointer terminated
4062         array for the font names. Use createNSArray.
4063
4064         * DumpRenderTree/mac/UIDelegate.mm:
4065         (-[UIDelegate webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
4066         Use createNSArray.
4067
4068         * Scripts/webkitpy/style/checkers/cpp.py:
4069         (find_parameter_name_index): Fixed a spelling error.
4070         (_check_parameter_name_against_text): Added a special case to not complain that
4071         parameters named "]" have redundant names. Not obvious to me how to write a test case for
4072         this and how to fix this in a more sensible way, but immediately helpful to not get this
4073         spurious warning.
4074
4075         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
4076         (WTR::activateSystemCoreWebFonts): Use constexpr array instead of NSArray for font names.
4077         (WTR::activateFonts): Use constexpr and NSString instead of a null-pointer terminated
4078         array for the font names. Use createNSArray.
4079
4080 2020-04-21  Matt Lewis  <jlewis3@apple.com>
4081
4082         Bindings-test should not depend on current working directory.
4083         https://bugs.webkit.org/show_bug.cgi?id=210831
4084
4085         Reviewed by Jonathan Bedard.
4086
4087         * Scripts/webkitpy/bindings/main.py:
4088         (BindingsTests.main):
4089
4090 2020-04-21  Daniel Bates  <dabates@apple.com>
4091
4092         Attempt to fix the build after r260449
4093         (https://bugs.webkit.org/show_bug.cgi?id=210697)
4094
4095         Wrap the C++ methods in namespace TestWebKitAPI so that IPhoneUserInterfaceSwizzler can be
4096         used unqualified.
4097
4098         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
4099
4100 2020-04-21  Darin Adler  <darin@apple.com>
4101
4102         WTF API test for StringConcatenate failing for internal Apple builds
4103         https://bugs.webkit.org/show_bug.cgi?id=210812
4104
4105         Reviewed by Brent Fulgham.
4106
4107         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
4108         (TestWebKitAPI::TEST): Add back a case for when UChar is uint16_t.
4109
4110 2020-04-21  Kate Cheney  <katherine_cheney@apple.com>
4111
4112         Move WebKit.WebViewCategory test to InAppBrowserPrivacy.mm
4113         https://bugs.webkit.org/show_bug.cgi?id=210811
4114         <rdar://problem/60972505> 
4115
4116         Reviewed by Alexey Proskuryakov.
4117
4118         This test was added before InAppBrowserPrivacy.mm existed. It should
4119         be moved here so it has access to all setup/cleanup needed by these
4120         tests.
4121
4122         * TestWebKitAPI/Tests/WebKitCocoa/Configuration.mm:
4123         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
4124
4125 2020-04-21  Daniel Bates  <dabates@apple.com>
4126
4127         [iOS] -_didFinishTextInteractionInTextInputContext should only zoom to reveal focused element if it changed
4128         https://bugs.webkit.org/show_bug.cgi?id=210697
4129         <rdar://problem/60997530>
4130
4131         Reviewed by Wenson Hsieh.
4132
4133         I use the term "assisted" below and in the tests to describe an element that is both DOM
4134         focused and the UI process is showing an input view (like the software keyboard) for it.
4135         For many of the tests I check for a zoom scale change as a way to detect if the page
4136         zoomed to reveal the focused element.
4137
4138         Add some tests for the following cases:
4139             1. Place the caret in a focused field that isn't being assisted.
4140             2. Focusing an assisted element should not scroll the page.
4141             3. Focusing an offscreen read-only element should not change zoom scale.
4142             4. Focusing an offscreen element should change the zoom scale.
4143             5. Calling -_focusTextInputContext on an offscreen element multiple times
4144             during a text interaction should change the zoom scale. The purpose of this test is
4145             to ensure that later calls that do not focus the element (because it is already focused)
4146             don't prevent zooming for the first call that did focus the element.
4147             6. Focusing an offscreen element, defocusing it, disabling it, and focusing it
4148             again during a text interaction should not change zoom scale.
4149             7. Focusing an offscreen element, defocusing it, and focusing it again during a
4150             text interaction should change zoom scale.
4151             8. Focusing an assisted element during a text interaction should not change zoom scale.
4152             9. Focusing a non-assisted focused element during a text interaction should change zoom scale.
4153
4154         While I am here, I consolidated the RAII helper classes IPhoneUserInterfaceSwizzler and
4155         IPadUserInterfaceSwizzler into a single UserInterfaceSwizzler templated class and defined
4156         the former two as template instances.
4157
4158         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
4159         (TextInteractionForScope::TextInteractionForScope):
4160         (TextInteractionForScope::~TextInteractionForScope):
4161         Added convenience RAII object to call -_willBeginTextInteractionInTextInputContext
4162         and -_didFinishTextInteractionInTextInputContext.
4163         (TEST): Added.
4164         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
4165         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
4166         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Removed.
4167         * TestWebKitAPI/ios/PreferredContentMode.mm:
4168         (IPhoneUserInterfaceSwizzler::IPhoneUserInterfaceSwizzler): Deleted; movedinto UserInterfaceSwizzler.h.
4169         (IPhoneUserInterfaceSwizzler::phoneUserInterfaceIdiom): Deleted; no longer needed.
4170         * TestWebKitAPI/ios/UserInterfaceSwizzler.h: Renamed from Tools/TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h.
4171         (TestWebKitAPI::UserInterfaceSwizzler::UserInterfaceSwizzler): Formerly named IPadUserInterfaceSwizzler;
4172         repurposed into general purpose template class, consolidating code from PreferredContentMode.mm.
4173         Privately inherits from InstanceMethodSwizzler instead of using composition as that simplifies
4174         the source code a tiny bit.
4175         (TestWebKitAPI::UserInterfaceSwizzler::effectiveUserInterfaceIdiom): Renamed; formerly padUserInterfaceIdiom.
4176
4177 2020-04-21  Timothy Hatcher  <timothy@apple.com>
4178
4179         Reset m_userScriptsNotified when web process crashes.
4180         https://bugs.webkit.org/show_bug.cgi?id=210807
4181
4182         Reviewed by Alex Christensen.
4183
4184         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
4185         (TEST): Test crashing the web process and reloading.
4186
4187 2020-04-21  Aakash Jain  <aakash_jain@apple.com>
4188
4189         [ews] Display error message when submit for EWS analysis button doesn't work
4190         https://bugs.webkit.org/show_bug.cgi?id=210803
4191
4192         Reviewed by Jonathan Bedard.
4193
4194         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
4195         (SubmitToEWS.post): Display relevant error message on submit for EWS analysis button failure.
4196         * BuildSlaveSupport/ews-app/ews/fetcher.py:
4197         (BugzillaPatchFetcher.fetch):
4198         (BugzillaPatchFetcher.send_patches_to_buildbot):
4199         * BuildSlaveSupport/ews-app/ews/config.py: Add few more error codes.
4200
4201 2020-04-21  Lauro Moura  <lmoura@igalia.com>
4202
4203         [GStreamer][JHBuild] Update to 1.16.2
4204         https://bugs.webkit.org/show_bug.cgi?id=210730
4205
4206         Reviewed by Philippe Normand.
4207
4208         Moving the bots closer to the flatpak SDK versions.
4209
4210         * gstreamer/jhbuild.modules:
4211         * gstreamer/patches/base-0001-glupload-Add-VideoMetas-and-GLSyncMeta-to-the-raw-up.patch: Removed.
4212
4213 2020-04-21  Alexey Proskuryakov  <ap@apple.com>
4214
4215         Correct the path to libclang_rt.asan_iossim_dynamic.dylib in LC_RPATH
4216         https://bugs.webkit.org/show_bug.cgi?id=210770
4217         rdar://problem/61904541
4218
4219         Reviewed by Alex Christensen.
4220
4221         * asan/asan.xcconfig:
4222
4223 2020-04-21  Diego Pino Garcia  <dpino@igalia.com>
4224
4225         [Flatpak SDK] Keep env variable 'RESULTS_SERVER_API_KEY'
4226         https://bugs.webkit.org/show_bug.cgi?id=210798
4227
4228         Reviewed by Philippe Normand.
4229
4230         The variable is needed by several bot steps to upload results.
4231
4232         * flatpak/flatpakutils.py:
4233         (WebkitFlatpak.run_in_sandbox):
4234
4235 2020-04-21  Adrian Perez de Castro  <aperez@igalia.com>
4236
4237         [GTK][CMake] Make gtk-unix-print a component of FindGTK.cmake
4238         https://bugs.webkit.org/show_bug.cgi?id=210792
4239
4240         Reviewed by Carlos Garcia Campos.
4241
4242         * TestWebKitAPI/glib/PlatformGTK.cmake: Use the GTK::UnixPrint imported target.
4243
4244 2020-04-21  Philippe Normand  <pnormand@igalia.com>
4245
4246         [Flatpak SDK] Silence git stderr output
4247         https://bugs.webkit.org/show_bug.cgi?id=210789
4248
4249         Reviewed by Sergio Villar Senin.
4250
4251         * flatpak/flatpakutils.py:
4252         (WebkitFlatpak.is_branch_build): Don't display git errors, usually
4253         emitted when operating on a SVN checkout.
4254
4255 2020-04-21  Philippe Normand  <pnormand@igalia.com>
4256
4257         [CMake][Flatpak SDK] gst-build-backed build fails
4258         https://bugs.webkit.org/show_bug.cgi?id=210742
4259
4260         Reviewed by Xabier Rodriguez-Calvar.
4261
4262         Add non-core GStreamer include-dirs necessary for the compilation
4263         of the GStreamer API test. Usually GSTREAMER_INCLUDE_DIRS is
4264         sufficient because on a GStreamer system-wide installation, all
4265         headers are stored in the same root include dir, the same as the
4266         core GStreamer library.
4267
4268         But when building with gst-build, include-dirs are scattered all
4269         over the place.
4270
4271         * TestWebKitAPI/PlatformGTK.cmake:
4272         * TestWebKitAPI/PlatformWPE.cmake:
4273
4274 2020-04-20  Ross Kirsling  <ross.kirsling@sony.com>
4275
4276         Classes marked final should not use protected access specifier
4277         https://bugs.webkit.org/show_bug.cgi?id=210775
4278
4279         Reviewed by Daniel Bates.
4280
4281         * DumpRenderTree/win/DefaultPolicyDelegate.h:
4282         * DumpRenderTree/win/UIDelegate.h:
4283
4284 2020-04-20  Peng Liu  <peng.liu6@apple.com>
4285
4286         Fix build failures when video fullscreen and picture-in-picture is disabled
4287         https://bugs.webkit.org/show_bug.cgi?id=210777
4288
4289         Reviewed by Eric Carlson.
4290
4291         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4292
4293 2020-04-20  Alex Christensen  <achristensen@webkit.org>
4294
4295         SPI clients using fastServerTrustEvaluationEnabled need SPI to inform them of modern TLS negotiation
4296         https://bugs.webkit.org/show_bug.cgi?id=210533
4297
4298         Reviewed by Brady Eidson.
4299
4300         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
4301         (-[TLSNavigationDelegate waitForDidNegotiateModernTLS]):
4302         (-[TLSNavigationDelegate _webView:didNegotiateModernTLS:]):
4303         (TestWebKitAPI::TEST):
4304
4305 2020-04-20  Kate Cheney  <katherine_cheney@apple.com>