1 2016-11-09 Alex Christensen <achristensen@webkit.org>
3 URLParser should not consider path of URLs with no host to start at the first slash after the colon
4 https://bugs.webkit.org/show_bug.cgi?id=164555
6 Reviewed by Tim Horton.
8 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
9 (TestWebKitAPI::TEST_F):
11 2016-11-09 Jonathan Bedard <jbedard@apple.com>
13 test-webkitpy failing test_create_patch_is_full_patch unit test
14 https://bugs.webkit.org/show_bug.cgi?id=164385
16 Reviewed by Darin Adler.
18 * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Fixed expected output to match output.
20 2016-11-09 Chris Dumez <cdumez@apple.com>
22 [Mac] Stop using deprecated AppKit enumeration values
23 https://bugs.webkit.org/show_bug.cgi?id=164494
25 Reviewed by Darin Adler.
27 Stop using deprecated AppKit enumeration values.
29 * DumpRenderTree/mac/EventSendingController.mm:
30 (eventTypeForMouseButtonAndAction):
32 (-[EventSendingController mouseMoveToX:Y:]):
33 (-[EventSendingController contextClick]):
34 (-[EventSendingController keyDown:withModifiers:withLocation:]):
35 * DumpRenderTree/mac/TextInputController.m:
36 (-[TextInputController interpretKeyEvents:withSender:]):
37 * TestWebKitAPI/Tests/WebKit2Cocoa/CommandBackForward.mm:
38 (simulateCommandArrow):
39 * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenDelegate.mm:
40 (TestWebKitAPI::TEST):
41 * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.mm:
42 (TestWebKitAPI::TEST):
43 * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm:
44 (TestWebKitAPI::TEST):
45 * TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
47 * TestWebKitAPI/Tests/WebKit2Cocoa/UserInitiatedActionInNavigationAction.mm:
48 (UserInitiatedActionTest::SetUp):
49 (UserInitiatedActionTest::click):
50 * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
51 (TestWebKitAPI::AcceptsFirstMouse::runTest):
52 * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
53 (TestWebKitAPI::contextMenuCopyLink):
54 (TestWebKitAPI::TEST):
55 * TestWebKitAPI/Tests/mac/ContextMenuDefaultItemsHaveTags.mm:
56 (TestWebKitAPI::TEST):
57 * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
58 (TestWebKitAPI::FullscreenZoomInitialFrame::runTest):
59 * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
60 (TestWebKitAPI::TEST):
61 * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
62 (TestWebKitAPI::Util::isKeyDown):
63 * TestWebKitAPI/mac/PlatformWebViewMac.mm:
64 (TestWebKitAPI::PlatformWebView::initialize):
65 (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
66 (TestWebKitAPI::PlatformWebView::simulateRightClick):
67 (TestWebKitAPI::PlatformWebView::simulateMouseMove):
68 (TestWebKitAPI::eventTypeForButton):
69 (TestWebKitAPI::modifierFlagsForWKModifiers):
70 * TestWebKitAPI/mac/TestWKWebViewMac.mm:
71 (__simulated_forceClickAssociatedEventsMask):
72 (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:]):
73 (-[TestWKWebView _setUpTestWindow:]):
74 (-[TestWKWebView typeCharacter:]):
75 * WebKitTestRunner/mac/EventSenderProxy.mm:
76 (WTR::eventTypeForMouseButtonAndAction):
77 (WTR::buildModifierFlags):
78 (WTR::EventSenderProxy::sendMouseDownToStartPressureEvents):
79 (WTR::EventSenderProxy::mouseForceClick):
80 (WTR::EventSenderProxy::startAndCancelMouseForceClick):
81 (WTR::EventSenderProxy::mouseMoveTo):
82 (WTR::EventSenderProxy::keyDown):
83 (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
84 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
85 (WTR::PlatformWebView::PlatformWebView):
86 * WebKitTestRunner/mac/TestControllerMac.mm:
87 (WTR::TestController::platformResetStateToConsistentValues):
89 2016-11-09 Beth Dakin <bdakin@apple.com>
91 Support TouchBar in WebKit
92 https://bugs.webkit.org/show_bug.cgi?id=164437
94 rdar://problem/28876524
96 Reviewed by Darin Adler.
98 This makes MiniBrowser support TouchBar customization.
100 * MiniBrowser/mac/AppDelegate.m:
101 (-[BrowserAppDelegate awakeFromNib]):
103 2016-11-09 Gyuyoung Kim <gyuyoung.kim@webkit.org>
105 [EFL] Use libgcrypt instead of GnuTLS for CryptoDigest
106 https://bugs.webkit.org/show_bug.cgi?id=164461
108 Reviewed by Michael Catanzaro.
110 As GTK port in r208297, EFL port starts to use libgcrypt instead of GnuTLS as well.
112 * efl/install-dependencies: Add libgcript package dependecy.
114 2016-11-09 Gyuyoung Kim <gyuyoung.kim@webkit.org>
116 [EFL] Remove unused function in MiniBrowser
117 https://bugs.webkit.org/show_bug.cgi?id=164398
119 Reviewed by Darin Adler.
121 * MiniBrowser/efl/main.c:
122 (window_find_with_elm_window): Deleted because it is not used anywhere.
124 2016-11-09 Chris Dumez <cdumez@apple.com>
126 [WK2][NETWORK_SESSION] Add support for downloading file backed blobs
127 https://bugs.webkit.org/show_bug.cgi?id=164458
128 <rdar://problem/28905514>
130 Reviewed by Darin Adler.
132 Add testRunner.setShouldDownloadUndisplayableMIMETypes(bool) API so that layout
133 tests can request that such resources are downloaded instead of being ignored.
135 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
136 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
137 (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
138 * WebKitTestRunner/InjectedBundle/TestRunner.h:
139 * WebKitTestRunner/TestController.cpp:
140 (WTR::TestController::decidePolicyForNavigationResponse):
141 * WebKitTestRunner/TestController.h:
142 (WTR::TestController::setShouldDownloadUndisplayableMIMETypes):
143 * WebKitTestRunner/TestInvocation.cpp:
144 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
146 2016-11-09 Jonathan Bedard <jbedard@apple.com>
148 Make rpaths more robust for iOS Simulators
149 https://bugs.webkit.org/show_bug.cgi?id=164521
151 Reviewed by Simon Fraser.
153 * Scripts/webkitpy/port/ios.py:
154 (IOSSimulatorPort._createSimulatorApp): Added more robust path.
156 2016-11-09 Csaba Osztrogonác <ossy@webkit.org>
158 Fix Tools build on case sensitive file systems
159 https://bugs.webkit.org/show_bug.cgi?id=164474
163 * DumpRenderTree/CMakeLists.txt:
164 * DumpRenderTree/PlatformMac.cmake:
165 * DumpRenderTree/PlatformWin.cmake:
166 * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
167 * MiniBrowser/mac/CMakeLists.txt:
169 2016-11-04 Filip Pizlo <fpizlo@apple.com>
171 WTF::ParkingLot should stop using std::chrono because std::chrono::duration casts are prone to overflows
172 https://bugs.webkit.org/show_bug.cgi?id=152045
174 Reviewed by Andy Estes.
176 * TestWebKitAPI/CMakeLists.txt:
177 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
178 * TestWebKitAPI/Tests/WTF/Condition.cpp:
179 (TestWebKitAPI::TEST):
180 * TestWebKitAPI/Tests/WTF/SynchronizedFixedQueue.cpp:
181 (TestWebKitAPI::ToUpperConverter::stopProducing):
182 (TestWebKitAPI::ToUpperConverter::stopConsuming):
183 * TestWebKitAPI/Tests/WTF/Time.cpp: Added.
185 (TestWebKitAPI::TEST):
187 2016-11-04 Alex Christensen <achristensen@webkit.org>
189 Unreviewed, rolling out r208293.
191 asserts in API tests.
195 "NetworkSession: Network process crash when converting main
196 resource to download"
197 https://bugs.webkit.org/show_bug.cgi?id=164220
198 http://trac.webkit.org/changeset/208293
200 2016-11-04 Said Abou-Hallawa <sabouhallawa@apple.com>
202 Add a setting and preferences to enable/disable async image decoding
203 https://bugs.webkit.org/show_bug.cgi?id=164417
205 Reviewed by Simon Fraser.
207 Pref and a menu item to toggle asyncImageDecodingEnabled for WebKits 1 and 2.
209 * MiniBrowser/mac/SettingsController.h:
210 * MiniBrowser/mac/SettingsController.m:
211 (-[SettingsController _populateMenu]):
212 (-[SettingsController validateMenuItem:]):
213 (-[SettingsController toggleAsyncImageDecodingEnabled:]):
214 (-[SettingsController asyncImageDecodingEnabled]):
215 * MiniBrowser/mac/WK1BrowserWindowController.m:
216 (-[WK1BrowserWindowController didChangeSettings]):
217 * MiniBrowser/mac/WK2BrowserWindowController.m:
218 (-[WK2BrowserWindowController didChangeSettings]):
220 2016-11-04 Brady Eidson <beidson@apple.com>
222 REGRESSION (r208349) StringHasher::hashMemory behavior changed, causing API tests to fail
223 https://bugs.webkit.org/show_bug.cgi?id=164390
225 Reviewed by Geoffrey Garen.
227 Operating under the assumption that the behavior change is okay/desirable, this updates the test.
229 * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
230 (TestWebKitAPI::TEST):
232 2016-11-04 Joanmarie Diggs <jdiggs@igalia.com>
234 AX: [ATK] Attempting to clear selection on ARIA listboxes results in crash
235 https://bugs.webkit.org/show_bug.cgi?id=164331
237 Reviewed by Chris Fleizach.
239 Add AccessibilityUIElement::clearSelectedChildren() to DRT and WKTR.
240 Implement it for ATK.
242 * DumpRenderTree/AccessibilityUIElement.h:
243 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
244 (AccessibilityUIElement::clearSelectedChildren):
245 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
246 (AccessibilityUIElement::clearSelectedChildren):
247 * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
248 (AccessibilityUIElement::clearSelectedChildren):
249 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
250 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
251 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
252 (WTR::AccessibilityUIElement::clearSelectedChildren):
253 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
254 (WTR::AccessibilityUIElement::clearSelectedChildren):
255 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
256 (WTR::AccessibilityUIElement::clearSelectedChildren):
258 2016-11-04 Per Arne Vollan <pvollan@apple.com>
260 [Win] Page visibility tests are timing out.
261 https://bugs.webkit.org/show_bug.cgi?id=164363
263 Reviewed by Brent Fulgham.
265 Implement methods to set page visibility.
267 * DumpRenderTree/win/TestRunnerWin.cpp:
268 (TestRunner::resetPageVisibility):
269 (TestRunner::setPageVisibility):
271 2016-11-03 Simon Fraser <simon.fraser@apple.com>
273 Give all the geometry classes a single-argument scale() function for consistency
274 https://bugs.webkit.org/show_bug.cgi?id=164400
276 Reviewed by Zalan Bujtas.
278 Test single-argument scale().
280 * TestWebKitAPI/Tests/WebCore/FloatPoint.cpp:
281 (TestWebKitAPI::TEST):
283 2016-11-03 Chris Dumez <cdumez@apple.com>
285 [WK2][Cocoa] Implement user interface for HTML form validation
286 https://bugs.webkit.org/show_bug.cgi?id=164143
287 <rdar://problem/28944652>
289 Reviewed by Simon Fraser.
291 Add support for UIScriptController::contentsOfUserInterfaceItem("validationBubble")
292 on both Mac and iOS to retrieve the currently displayed validation message.
294 * DumpRenderTree/mac/UIScriptControllerMac.mm:
295 (WTR::UIScriptController::contentsOfUserInterfaceItem):
296 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
297 (WTR::UIScriptController::contentsOfUserInterfaceItem):
298 (WTR::UIScriptController::selectFormAccessoryPickerRow):
299 * WebKitTestRunner/mac/UIScriptControllerMac.mm:
300 (WTR::UIScriptController::contentsOfUserInterfaceItem):
302 2016-11-03 Konstantin Tokarev <annulen@yandex.ru>
304 Fixes to build JSCOnly on macOS
305 https://bugs.webkit.org/show_bug.cgi?id=164379
307 Reviewed by Michael Catanzaro.
309 * TestWebKitAPI/PlatformJSCOnly.cmake: Moved BUILDING_JSCONLY__
310 definition to OptionsJSCOnly.cmake
312 2016-11-03 Dan Bernstein <mitz@apple.com>
314 WKWebView’s _observedRenderingProgressEvents not restored after web process crash
315 https://bugs.webkit.org/show_bug.cgi?id=164368
316 <rdar://problem/29091954>
318 Reviewed by Anders Carlsson.
320 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
321 * TestWebKitAPI/Tests/WebKit2Cocoa/ObservedRenderingProgressEventsAfterCrash.mm: Added.
324 2016-11-03 Alex Christensen <achristensen@webkit.org>
326 Purge PassRefPtr from Tools
327 https://bugs.webkit.org/show_bug.cgi?id=164358
329 Reviewed by Michael Catanzaro.
331 * ImageDiff/efl/ImageDiff.cpp:
332 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp:
333 * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
334 (WTR::AccessibilityController::create):
335 (WTR::AccessibilityController::rootElement):
336 (WTR::AccessibilityController::focusedElement):
337 (WTR::AccessibilityController::elementAtPoint):
338 (WTR::AccessibilityController::addNotificationListener): Deleted.
339 (WTR::AccessibilityController::removeNotificationListener): Deleted.
340 (WTR::AccessibilityController::accessibleElementById): Deleted.
341 (WTR::AccessibilityController::logAccessibilityEvents): Deleted.
342 (WTR::AccessibilityController::resetToConsistentState): Deleted.
343 (WTR::AccessibilityController::platformName): Deleted.
344 * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
345 (WTR::AccessibilityController::logAccessibilityEvents):
346 * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp:
347 (WTR::AccessibilityTextMarker::create):
348 * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.h:
349 * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp:
350 (WTR::AccessibilityTextMarkerRange::create):
351 * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.h:
352 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
353 (WTR::AccessibilityUIElement::create):
354 (WTR::AccessibilityUIElement::linkedElement):
355 (WTR::AccessibilityUIElement::headerElementAtIndex):
356 (WTR::AccessibilityUIElement::fieldsetAncestorElement):
357 (WTR::AccessibilityUIElement::characterAtOffset):
358 (WTR::AccessibilityUIElement::wordAtOffset):
359 (WTR::AccessibilityUIElement::lineAtOffset):
360 (WTR::AccessibilityUIElement::sentenceAtOffset):
361 (WTR::AccessibilityUIElement::selectedTextMarkerRange):
362 (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
363 (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
364 (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
365 (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
366 (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
367 (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
368 (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
369 (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
370 (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
371 (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
372 (WTR::AccessibilityUIElement::AccessibilityUIElement): Deleted.
373 (WTR::AccessibilityUIElement::~AccessibilityUIElement): Deleted.
374 (WTR::AccessibilityUIElement::isEqual): Deleted.
375 (WTR::AccessibilityUIElement::elementAtPoint): Deleted.
376 (WTR::AccessibilityUIElement::childAtIndex): Deleted.
377 (WTR::AccessibilityUIElement::indexOfChild): Deleted.
378 (WTR::AccessibilityUIElement::childrenCount): Deleted.
379 (WTR::AccessibilityUIElement::titleUIElement): Deleted.
380 (WTR::AccessibilityUIElement::parentElement): Deleted.
381 (WTR::AccessibilityUIElement::takeFocus): Deleted.
382 (WTR::AccessibilityUIElement::takeSelection): Deleted.
383 (WTR::AccessibilityUIElement::addSelection): Deleted.
384 (WTR::AccessibilityUIElement::removeSelection): Deleted.
385 (WTR::AccessibilityUIElement::allAttributes): Deleted.
386 (WTR::AccessibilityUIElement::attributesOfLinkedUIElements): Deleted.
387 (WTR::AccessibilityUIElement::linkedUIElementAtIndex): Deleted.
388 (WTR::AccessibilityUIElement::attributesOfDocumentLinks): Deleted.
389 (WTR::AccessibilityUIElement::attributesOfChildren): Deleted.
390 (WTR::AccessibilityUIElement::parameterizedAttributeNames): Deleted.
391 (WTR::AccessibilityUIElement::increment): Deleted.
392 (WTR::AccessibilityUIElement::decrement): Deleted.
393 (WTR::AccessibilityUIElement::showMenu): Deleted.
394 (WTR::AccessibilityUIElement::press): Deleted.
395 (WTR::AccessibilityUIElement::stringAttributeValue): Deleted.
396 (WTR::AccessibilityUIElement::uiElementArrayAttributeValue): Deleted.
397 (WTR::AccessibilityUIElement::uiElementAttributeValue): Deleted.
398 (WTR::AccessibilityUIElement::numberAttributeValue): Deleted.
399 (WTR::AccessibilityUIElement::boolAttributeValue): Deleted.
400 (WTR::AccessibilityUIElement::isAttributeSupported): Deleted.
401 (WTR::AccessibilityUIElement::isAttributeSettable): Deleted.
402 (WTR::AccessibilityUIElement::isPressActionSupported): Deleted.
403 (WTR::AccessibilityUIElement::isIncrementActionSupported): Deleted.
404 (WTR::AccessibilityUIElement::isDecrementActionSupported): Deleted.
405 (WTR::AccessibilityUIElement::role): Deleted.
406 (WTR::AccessibilityUIElement::subrole): Deleted.
407 (WTR::AccessibilityUIElement::roleDescription): Deleted.
408 (WTR::AccessibilityUIElement::computedRoleString): Deleted.
409 (WTR::AccessibilityUIElement::title): Deleted.
410 (WTR::AccessibilityUIElement::description): Deleted.
411 (WTR::AccessibilityUIElement::language): Deleted.
412 (WTR::AccessibilityUIElement::stringValue): Deleted.
413 (WTR::AccessibilityUIElement::accessibilityValue): Deleted.
414 (WTR::AccessibilityUIElement::helpText): Deleted.
415 (WTR::AccessibilityUIElement::orientation): Deleted.
416 (WTR::AccessibilityUIElement::x): Deleted.
417 (WTR::AccessibilityUIElement::y): Deleted.
418 (WTR::AccessibilityUIElement::width): Deleted.
419 (WTR::AccessibilityUIElement::height): Deleted.
420 (WTR::AccessibilityUIElement::intValue): Deleted.
421 (WTR::AccessibilityUIElement::minValue): Deleted.
422 (WTR::AccessibilityUIElement::maxValue): Deleted.
423 (WTR::AccessibilityUIElement::valueDescription): Deleted.
424 (WTR::AccessibilityUIElement::insertionPointLineNumber): Deleted.
425 (WTR::AccessibilityUIElement::selectedTextRange): Deleted.
426 (WTR::AccessibilityUIElement::isEnabled): Deleted.
427 (WTR::AccessibilityUIElement::isRequired): Deleted.
428 (WTR::AccessibilityUIElement::isFocused): Deleted.
429 (WTR::AccessibilityUIElement::isFocusable): Deleted.
430 (WTR::AccessibilityUIElement::isSelected): Deleted.
431 (WTR::AccessibilityUIElement::isSelectedOptionActive): Deleted.
432 (WTR::AccessibilityUIElement::isSelectable): Deleted.
433 (WTR::AccessibilityUIElement::isMultiSelectable): Deleted.
434 (WTR::AccessibilityUIElement::setSelectedChild): Deleted.
435 (WTR::AccessibilityUIElement::setSelectedChildAtIndex): Deleted.
436 (WTR::AccessibilityUIElement::removeSelectionAtIndex): Deleted.
437 (WTR::AccessibilityUIElement::selectedChildrenCount): Deleted.
438 (WTR::AccessibilityUIElement::selectedChildAtIndex): Deleted.
439 (WTR::AccessibilityUIElement::isExpanded): Deleted.
440 (WTR::AccessibilityUIElement::isChecked): Deleted.
441 (WTR::AccessibilityUIElement::isIndeterminate): Deleted.
442 (WTR::AccessibilityUIElement::isVisible): Deleted.
443 (WTR::AccessibilityUIElement::isOffScreen): Deleted.
444 (WTR::AccessibilityUIElement::isCollapsed): Deleted.
445 (WTR::AccessibilityUIElement::isIgnored): Deleted.
446 (WTR::AccessibilityUIElement::hasPopup): Deleted.
447 (WTR::AccessibilityUIElement::hierarchicalLevel): Deleted.
448 (WTR::AccessibilityUIElement::clickPointX): Deleted.
449 (WTR::AccessibilityUIElement::clickPointY): Deleted.
450 (WTR::AccessibilityUIElement::documentEncoding): Deleted.
451 (WTR::AccessibilityUIElement::documentURI): Deleted.
452 (WTR::AccessibilityUIElement::url): Deleted.
453 (WTR::AccessibilityUIElement::speak): Deleted.
454 (WTR::AccessibilityUIElement::attributesOfColumnHeaders): Deleted.
455 (WTR::AccessibilityUIElement::attributesOfRowHeaders): Deleted.
456 (WTR::AccessibilityUIElement::attributesOfColumns): Deleted.
457 (WTR::AccessibilityUIElement::attributesOfRows): Deleted.
458 (WTR::AccessibilityUIElement::attributesOfVisibleCells): Deleted.
459 (WTR::AccessibilityUIElement::attributesOfHeader): Deleted.
460 (WTR::AccessibilityUIElement::indexInTable): Deleted.
461 (WTR::AccessibilityUIElement::rowIndexRange): Deleted.
462 (WTR::AccessibilityUIElement::columnIndexRange): Deleted.
463 (WTR::AccessibilityUIElement::rowCount): Deleted.
464 (WTR::AccessibilityUIElement::columnCount): Deleted.
465 (WTR::AccessibilityUIElement::rowHeaders): Deleted.
466 (WTR::AccessibilityUIElement::columnHeaders): Deleted.
467 (WTR::AccessibilityUIElement::selectedRowAtIndex): Deleted.
468 (WTR::AccessibilityUIElement::disclosedByRow): Deleted.
469 (WTR::AccessibilityUIElement::disclosedRowAtIndex): Deleted.
470 (WTR::AccessibilityUIElement::rowAtIndex): Deleted.
471 (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex): Deleted.
472 (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex): Deleted.
473 (WTR::AccessibilityUIElement::ariaControlsElementAtIndex): Deleted.
474 (WTR::AccessibilityUIElement::ariaIsGrabbed): Deleted.
475 (WTR::AccessibilityUIElement::ariaDropEffects): Deleted.
476 (WTR::AccessibilityUIElement::classList): Deleted.
477 (WTR::AccessibilityUIElement::lineForIndex): Deleted.
478 (WTR::AccessibilityUIElement::rangeForLine): Deleted.
479 (WTR::AccessibilityUIElement::rangeForPosition): Deleted.
480 (WTR::AccessibilityUIElement::boundsForRange): Deleted.
481 (WTR::AccessibilityUIElement::setSelectedTextRange): Deleted.
482 (WTR::AccessibilityUIElement::setSelectedVisibleTextRange): Deleted.
483 (WTR::AccessibilityUIElement::stringForRange): Deleted.
484 (WTR::AccessibilityUIElement::attributedStringForRange): Deleted.
485 (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled): Deleted.
486 (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate): Deleted.
487 (WTR::AccessibilityUIElement::uiElementForSearchPredicate): Deleted.
488 (WTR::AccessibilityUIElement::selectTextWithCriteria): Deleted.
489 (WTR::AccessibilityUIElement::cellForColumnAndRow): Deleted.
490 (WTR::AccessibilityUIElement::horizontalScrollbar): Deleted.
491 (WTR::AccessibilityUIElement::verticalScrollbar): Deleted.
492 (WTR::AccessibilityUIElement::addNotificationListener): Deleted.
493 (WTR::AccessibilityUIElement::removeNotificationListener): Deleted.
494 (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker): Deleted.
495 (WTR::AccessibilityUIElement::textMarkerRangeForElement): Deleted.
496 (WTR::AccessibilityUIElement::textMarkerRangeLength): Deleted.
497 (WTR::AccessibilityUIElement::textMarkerRangeForMarkers): Deleted.
498 (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange): Deleted.
499 (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange): Deleted.
500 (WTR::AccessibilityUIElement::accessibilityElementForTextMarker): Deleted.
501 (WTR::AccessibilityUIElement::endTextMarkerForBounds): Deleted.
502 (WTR::AccessibilityUIElement::startTextMarkerForBounds): Deleted.
503 (WTR::AccessibilityUIElement::textMarkerForPoint): Deleted.
504 (WTR::AccessibilityUIElement::previousTextMarker): Deleted.
505 (WTR::AccessibilityUIElement::nextTextMarker): Deleted.
506 (WTR::AccessibilityUIElement::startTextMarker): Deleted.
507 (WTR::AccessibilityUIElement::endTextMarker): Deleted.
508 (WTR::AccessibilityUIElement::stringForTextMarkerRange): Deleted.
509 (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute): Deleted.
510 (WTR::AccessibilityUIElement::indexForTextMarker): Deleted.
511 (WTR::AccessibilityUIElement::isTextMarkerValid): Deleted.
512 (WTR::AccessibilityUIElement::textMarkerForIndex): Deleted.
513 (WTR::AccessibilityUIElement::scrollToMakeVisible): Deleted.
514 (WTR::AccessibilityUIElement::scrollToGlobalPoint): Deleted.
515 (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus): Deleted.
516 (WTR::AccessibilityUIElement::supportedActions): Deleted.
517 (WTR::AccessibilityUIElement::mathPostscriptsDescription): Deleted.
518 (WTR::AccessibilityUIElement::mathPrescriptsDescription): Deleted.
519 (WTR::AccessibilityUIElement::pathDescription): Deleted.
520 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
521 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
522 (WTR::EventSendingController::create):
523 * WebKitTestRunner/InjectedBundle/EventSendingController.h:
524 * WebKitTestRunner/InjectedBundle/GCController.cpp:
525 (WTR::GCController::create):
526 * WebKitTestRunner/InjectedBundle/GCController.h:
527 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
528 (WTR::InjectedBundle::beginTesting):
529 * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
530 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
531 (WTR::TestRunner::create):
532 * WebKitTestRunner/InjectedBundle/TestRunner.h:
533 * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
534 (WTR::TextInputController::create):
535 * WebKitTestRunner/InjectedBundle/TextInputController.h:
536 * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
537 (WTR::AccessibilityController::accessibleElementById):
538 (WTR::AccessibilityController::rootElement):
539 (WTR::AccessibilityController::focusedElement):
540 (WTR::AccessibilityController::logAccessibilityEvents): Deleted.
541 * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.h:
542 (WTR::AccessibilityNotificationHandler::create):
543 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
544 (WTR::AccessibilityUIElement::elementAtPoint):
545 (WTR::AccessibilityUIElement::childAtIndex):
546 (WTR::accessibilityElementAtIndex):
547 (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
548 (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
549 (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
550 (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
551 (WTR::AccessibilityUIElement::disclosedRowAtIndex):
552 (WTR::AccessibilityUIElement::rowAtIndex):
553 (WTR::AccessibilityUIElement::selectedChildAtIndex):
554 (WTR::AccessibilityUIElement::selectedRowAtIndex):
555 (WTR::AccessibilityUIElement::titleUIElement):
556 (WTR::AccessibilityUIElement::parentElement):
557 (WTR::AccessibilityUIElement::disclosedByRow):
558 (WTR::AccessibilityUIElement::uiElementAttributeValue):
559 (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
560 (WTR::AccessibilityUIElement::cellForColumnAndRow):
561 (WTR::AccessibilityUIElement::horizontalScrollbar):
562 (WTR::AccessibilityUIElement::verticalScrollbar):
563 (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
564 (WTR::AccessibilityUIElement::textMarkerRangeForElement):
565 (WTR::AccessibilityUIElement::previousTextMarker):
566 (WTR::AccessibilityUIElement::nextTextMarker):
567 (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
568 (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
569 (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
570 (WTR::AccessibilityUIElement::endTextMarkerForBounds):
571 (WTR::AccessibilityUIElement::startTextMarkerForBounds):
572 (WTR::AccessibilityUIElement::textMarkerForPoint):
573 (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
574 (WTR::AccessibilityUIElement::textMarkerForIndex):
575 (WTR::AccessibilityUIElement::startTextMarker):
576 (WTR::AccessibilityUIElement::endTextMarker):
577 * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
578 (WTR::AccessibilityController::accessibleElementById):
579 (WTR::AccessibilityController::logAccessibilityEvents): Deleted.
580 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
581 (WTR::AccessibilityUIElement::headerElementAtIndex):
582 (WTR::AccessibilityUIElement::linkedElement):
583 (WTR::AccessibilityUIElement::elementAtPoint):
584 (WTR::AccessibilityUIElement::childAtIndex):
585 (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
586 (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
587 (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
588 (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
589 (WTR::AccessibilityUIElement::disclosedRowAtIndex):
590 (WTR::AccessibilityUIElement::rowAtIndex):
591 (WTR::AccessibilityUIElement::selectedChildAtIndex):
592 (WTR::AccessibilityUIElement::selectedRowAtIndex):
593 (WTR::AccessibilityUIElement::titleUIElement):
594 (WTR::AccessibilityUIElement::parentElement):
595 (WTR::AccessibilityUIElement::disclosedByRow):
596 (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
597 (WTR::AccessibilityUIElement::uiElementAttributeValue):
598 (WTR::AccessibilityUIElement::rangeForLine):
599 (WTR::AccessibilityUIElement::rangeForPosition):
600 (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
601 (WTR::AccessibilityUIElement::fieldsetAncestorElement):
602 (WTR::AccessibilityUIElement::cellForColumnAndRow):
603 (WTR::AccessibilityUIElement::horizontalScrollbar):
604 (WTR::AccessibilityUIElement::verticalScrollbar):
605 (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
606 (WTR::AccessibilityUIElement::textMarkerRangeForElement):
607 (WTR::AccessibilityUIElement::previousTextMarker):
608 (WTR::AccessibilityUIElement::nextTextMarker):
609 (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
610 (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
611 (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
612 (WTR::AccessibilityUIElement::endTextMarkerForBounds):
613 (WTR::AccessibilityUIElement::startTextMarkerForBounds):
614 (WTR::AccessibilityUIElement::textMarkerForPoint):
615 (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
616 (WTR::AccessibilityUIElement::textMarkerForIndex):
617 (WTR::AccessibilityUIElement::startTextMarker):
618 (WTR::AccessibilityUIElement::endTextMarker):
619 (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
620 (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
621 (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
622 (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
623 (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
624 (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
625 (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
626 (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
627 (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
628 (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
629 (WTR::AccessibilityUIElement::mathPostscriptsDescription):
630 (WTR::AccessibilityUIElement::mathPrescriptsDescription):
631 (WTR::AccessibilityUIElement::supportedActions):
632 * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
633 (WTR::AccessibilityController::accessibleElementById):
634 (WTR::AccessibilityController::logAccessibilityEvents): Deleted.
635 * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
636 (makeValueRefForValue):
637 (-[AccessibilityNotificationHandler _notificationReceived:]):
638 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
639 (WTR::AccessibilityUIElement::elementAtPoint):
640 (WTR::AccessibilityUIElement::childAtIndex):
641 (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
642 (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
643 (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
644 (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
645 (WTR::AccessibilityUIElement::disclosedRowAtIndex):
646 (WTR::AccessibilityUIElement::rowAtIndex):
647 (WTR::AccessibilityUIElement::selectedChildAtIndex):
648 (WTR::AccessibilityUIElement::selectedRowAtIndex):
649 (WTR::AccessibilityUIElement::titleUIElement):
650 (WTR::AccessibilityUIElement::parentElement):
651 (WTR::AccessibilityUIElement::disclosedByRow):
652 (WTR::AccessibilityUIElement::uiElementAttributeValue):
653 (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
654 (WTR::AccessibilityUIElement::cellForColumnAndRow):
655 (WTR::AccessibilityUIElement::horizontalScrollbar):
656 (WTR::AccessibilityUIElement::verticalScrollbar):
657 (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
658 (WTR::AccessibilityUIElement::textMarkerRangeForElement):
659 (WTR::AccessibilityUIElement::previousTextMarker):
660 (WTR::AccessibilityUIElement::nextTextMarker):
661 (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
662 (WTR::AccessibilityUIElement::selectedTextMarkerRange):
663 (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
664 (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
665 (WTR::AccessibilityUIElement::endTextMarkerForBounds):
666 (WTR::AccessibilityUIElement::startTextMarkerForBounds):
667 (WTR::AccessibilityUIElement::textMarkerForPoint):
668 (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
669 (WTR::AccessibilityUIElement::textMarkerForIndex):
670 (WTR::AccessibilityUIElement::startTextMarker):
671 (WTR::AccessibilityUIElement::endTextMarker):
672 (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
673 (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
674 (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
675 (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
676 (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
677 (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
678 (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
679 (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
680 (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
681 (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
682 * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
686 2016-11-02 Alex Christensen <achristensen@webkit.org>
688 Remove Battery Status API from the tree
689 https://bugs.webkit.org/show_bug.cgi?id=164213
691 Reviewed by Sam Weinig.
693 * Scripts/webkitperl/FeatureList.pm:
694 * Scripts/webkitpy/common/config/watchlist:
696 2016-11-02 Olivier Blin <olivier.blin@softathome.com>
698 [GTK] Use libgcrypt instead of GnuTLS for CryptoDigest and SubtleCrypto HMAC implementation
699 https://bugs.webkit.org/show_bug.cgi?id=163125
701 Reviewed by Michael Catanzaro.
703 * gtk/install-dependencies: List libgcrypt for WebKitGTK+ build, and gnutls for jhbuild only.
704 gnutls is useful for glib-networking in jhbuild.
706 2016-11-02 Carlos Garcia Campos <cgarcia@igalia.com>
708 NetworkSession: Network process crash when converting main resource to download
709 https://bugs.webkit.org/show_bug.cgi?id=164220
711 Reviewed by Alex Christensen.
713 Split /webkit2/Downloads/policy-decision-download in two, one to test the full load when main resource is
714 converted to a download and another one to test the cancellation as the test was doing before. When doing the
715 full load, delay a bit the decide destination to ensure the load is aborted before the data task has became a
718 * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
719 (testPolicyResponseDownload):
720 (testPolicyResponseDownloadCancel):
723 2016-11-01 Alex Christensen <achristensen@webkit.org>
725 Remove PassRefPtr from DumpRenderTree
726 https://bugs.webkit.org/show_bug.cgi?id=164307
728 Reviewed by Sam Weinig.
730 * DumpRenderTree/PixelDumpSupport.h:
731 * DumpRenderTree/TestRunner.cpp:
732 (TestRunner::create):
733 * DumpRenderTree/TestRunner.h:
734 * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
735 (createBitmapContext):
736 * DumpRenderTree/cg/PixelDumpSupportCG.h:
737 (BitmapContext::createByAdoptingBitmapAndContext):
738 * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
739 (createBitmapContextFromWebView):
740 * DumpRenderTree/mac/PixelDumpSupportMac.mm:
741 (createBitmapContextFromWebView):
742 (createPagedBitmapContext):
743 * DumpRenderTree/mac/TestRunnerMac.mm:
744 * DumpRenderTree/win/PixelDumpSupportWin.cpp:
745 (createBitmapContextFromWebView):
746 * DumpRenderTree/win/TextInputController.h:
748 2016-11-02 Carlos Garcia Campos <cgarcia@igalia.com>
750 [GTK] Use GTestDBus instead of dbus-launch in WebKitTestBus.cpp
751 https://bugs.webkit.org/show_bug.cgi?id=161481
753 Reviewed by Michael Catanzaro.
755 * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp:
756 (WebKitTestBus::WebKitTestBus):
757 (WebKitTestBus::~WebKitTestBus):
758 (WebKitTestBus::run):
759 (WebKitTestBus::getOrCreateConnection):
760 (WebKitTestBus::createProxy):
761 * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.h:
763 2016-11-02 Carlos Garcia Campos <cgarcia@igalia.com>
765 Unreviewed. Fix /webkit2/WebKitWebContext/get-plugins in the bots after r208273.
767 The test fails now if WEBKIT_TEST_PLUGIN_DIR contains symlinks, which is the case of the GTK+ bots.
769 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
770 (testWebContextGetPlugins): Use realpath with WEBKIT_TEST_PLUGIN_DIR when building the expected plugins path.
772 2016-11-02 Romain Bellessort <romain.bellessort@crf.canon.fr>
774 [Readable Streams API] Enable creation of ReadableByteStreamController
775 https://bugs.webkit.org/show_bug.cgi?id=164014
777 Reviewed by Youenn Fablet.
779 Enable the byte stream part of Readable Streams API by default.
781 * Scripts/webkitperl/FeatureList.pm:
782 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
784 2016-11-01 Ryosuke Niwa <rniwa@webkit.org>
786 Remove CUSTOM_ELEMENTS build flag
787 https://bugs.webkit.org/show_bug.cgi?id=164267
789 Reviewed by Antti Koivisto.
791 Removed the build flag.
793 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
795 2016-11-01 Alex Christensen <achristensen@webkit.org>
797 Percent-encode non-ASCII code points in hosts of URLs with unrecognized schemes
798 https://bugs.webkit.org/show_bug.cgi?id=164290
800 Reviewed by Tim Horton.
802 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
803 (TestWebKitAPI::checkRelativeURL):
804 (TestWebKitAPI::checkURLDifferences):
805 (TestWebKitAPI::checkRelativeURLDifferences):
806 Move helper functions to the top so I can use them from any tests.
807 (TestWebKitAPI::shouldFail):
808 (TestWebKitAPI::checkURL):
809 (TestWebKitAPI::TEST_F):
811 2016-11-01 Hyowon Kim <hw1008.kim@samsung.com>
813 [GTK] Failed to generate GeoClue2Interface files.
814 https://bugs.webkit.org/show_bug.cgi?id=164270
816 Reviewed by Michael Catanzaro.
818 To generate codes for D-Bus interfaces,
819 geoclue-2.0 package including D-Bus introspection XML files should be installed.
821 * gtk/install-dependencies: add geoclue-2.0 package.
823 2016-11-01 Fujii Hironori <Hironori.Fujii@sony.com>
825 [CMake] generate-bindings-all.pl uses USES_TERMINAL which leaves a noisy line in interactive Ninja build
826 https://bugs.webkit.org/show_bug.cgi?id=163868
828 Reviewed by Michael Catanzaro.
830 It takes long time for generate-bindings-all.pl to generate all
831 bindings. So, it shows the progress while running and
832 USES_TERMINAL option of add_custom_target have been used to invoke
833 the command. However, USES_TERMINAL leaves a noisy line in
834 Ninja's neat build log of interactive build.
836 A new CMake option SHOW_BINDINGS_GENERATION_PROGRESS is added to
837 stop using USES_TERMINAL only in case of interactive Ninja build.
839 * Scripts/webkitdirs.pm:
840 (generateBuildSystemFromCMakeProject): Enable
841 SHOW_BINDINGS_GENERATION_PROGRESS not in case of interactive
844 2016-10-31 Simon Fraser <simon.fraser@apple.com>
846 Add basic visual/layout viewport support for fixed position layout
847 https://bugs.webkit.org/show_bug.cgi?id=164261
849 Reviewed by Dean Jackson.
851 Don't give tests in the "visual-viewport" directory a flexible viewport.
853 * DumpRenderTree/mac/DumpRenderTree.mm:
854 (shouldMakeViewportFlexible):
855 * WebKitTestRunner/TestOptions.cpp:
856 (WTR::shouldMakeViewportFlexible):
858 2016-10-29 Filip Pizlo <fpizlo@apple.com>
860 JSC should support SharedArrayBuffer
861 https://bugs.webkit.org/show_bug.cgi?id=163986
863 Reviewed by Keith Miller.
865 Use the right kind of typed array API.
867 * DumpRenderTree/TestRunner.cpp:
868 (setAudioResultCallback):
870 2016-10-31 Simon Fraser <simon.fraser@apple.com>
872 Make UIScriptController::zoomToScale() work on Mac WK1 and WK2
873 https://bugs.webkit.org/show_bug.cgi?id=164238
875 Reviewed by Dean Jackson.
877 Implement UIScriptController::zoomToScale() for WTR and DRT on Mac.
879 * DumpRenderTree/mac/UIScriptControllerMac.mm:
880 (WTR::UIScriptController::zoomToScale):
881 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
882 * WebKitTestRunner/mac/UIScriptControllerMac.mm:
883 (WTR::UIScriptController::zoomToScale):
885 2016-10-31 Dewei Zhu <dewei_zhu@apple.com>
887 Update twisted version in webkitpy.thirdparty.autoinstalled module.
888 https://bugs.webkit.org/show_bug.cgi?id=154667
890 Reviewed by Ryosuke Niwa.
892 Use twisted_15_5_0 for the twisted module used by run-benchmark because there is a bug in twisted 12.1.0 which sometimes stops the test.
893 Installing twisted was introduced in https://bugs.webkit.org/show_bug.cgi?id=147082 for run-benchmark script.
894 Since buildbot relies on twisted 12.1.0 and has not been verified the compatibility on twisted 15.5.0, it would be more secure to use an individual version for run-benchmark script.
896 * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
897 * Scripts/webkitpy/thirdparty/__init__.py:
898 (AutoinstallImportHook.find_module):
899 (AutoinstallImportHook._install_twisted_15_5_0):
900 (AutoinstallImportHook._install_twisted): Deleted.
902 2016-10-31 Ryosuke Niwa <rniwa@webkit.org>
904 Enable custom elements by default everywhere
905 https://bugs.webkit.org/show_bug.cgi?id=164242
907 Reviewed by Antti Koivisto.
909 Enable custom elements API on every port by default.
911 * Scripts/webkitperl/FeatureList.pm:
913 2016-10-31 Nan Wang <n_wang@apple.com>
915 AX: aria-sort is not exposed on iOS
916 https://bugs.webkit.org/show_bug.cgi?id=164245
918 Reviewed by Chris Fleizach.
920 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
921 (AccessibilityUIElement::stringAttributeValue):
922 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
923 (WTR::AccessibilityUIElement::stringAttributeValue):
925 2016-10-31 Simon Fraser <simon.fraser@apple.com>
927 Implement IntersectionObserver
928 https://bugs.webkit.org/show_bug.cgi?id=159475
930 Reviewed by Ryosuke Niwa.
932 Add ENABLE_INTERSECTION_OBSERVER, enabled by default.
934 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
936 2016-10-31 Ryan Haddad <ryanhaddad@apple.com>
938 Unreviewed, rolling out r208154.
940 This change caused an assertion failure during API tests on
945 "NetworkSession: Network process crash when converting main
946 resource to download"
947 https://bugs.webkit.org/show_bug.cgi?id=164220
948 http://trac.webkit.org/changeset/208154
950 2016-10-31 Said Abou-Hallawa <sabouhallawa@apple.com>
952 Unreviewed, change my status to be a WebKit reviewer
954 * Scripts/webkitpy/common/config/contributors.json:
956 2016-10-31 Carlos Garcia Campos <cgarcia@igalia.com>
958 NetworkSession: Network process crash when converting main resource to download
959 https://bugs.webkit.org/show_bug.cgi?id=164220
961 Reviewed by Alex Christensen.
963 Split /webkit2/Downloads/policy-decision-download in two, one to test the full load when main resource is
964 converted to a download and another one to test the cancellation as the test was doing before. When doing the
965 full load, delay a bit the decide destination to ensure the load is aborted before the data task has became a
968 * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
969 (testPolicyResponseDownload):
970 (testPolicyResponseDownloadCancel):
973 2016-10-31 Keith Miller <keith_miller@apple.com>
975 Unreviewed, fix watchlist regexp for wasm.
977 * Scripts/webkitpy/common/config/watchlist:
979 2016-10-31 Keith Miller <keith_miller@apple.com>
981 autogenerated files from wasm.json should be in derived sources.
982 https://bugs.webkit.org/show_bug.cgi?id=164152
984 Reviewed by Filip Pizlo.
986 Add message to make sure that people keep the wasm.jsons up to date.
988 * Scripts/webkitpy/common/config/watchlist:
990 2016-10-31 Wenson Hsieh <wenson_hsieh@apple.com>
992 Holding down a key to choose an accented character should fire "insertReplacementText" input events
993 https://bugs.webkit.org/show_bug.cgi?id=164209
994 <rdar://problem/29019305>
996 Reviewed by Darin Adler.
998 Adds test support for inserting replacement text on Mac. This is equivalent to holding down a vowel key (e.g.
999 'a') to bring up the menu containing accented version of the character, then selecting an accented character to
1000 insert in place of the typed character. This is exposed via UIScriptController.insertText, which takes a string
1001 and an insertion range.
1003 * DumpRenderTree/mac/UIScriptControllerMac.mm:
1004 (WTR::UIScriptController::insertText):
1005 * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1007 Note that there is no callback argument to insertText, since UIScriptController::insertText is synchronous in
1008 the UI process. The tests end when corresponding input events fired as a result of insertText have been received
1009 in the web process. Please see the new layout tests for more detail.
1011 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1012 (WTR::UIScriptController::insertText):
1013 * TestRunnerShared/UIScriptContext/UIScriptController.h:
1014 * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1015 (WTR::nsStringFromJSString):
1016 (WTR::UIScriptController::insertText):
1018 2016-10-30 Sam Weinig <sam@webkit.org>
1020 [WebIDL] Restructure IDLParser structs to better match modern WebIDL concepts
1021 https://bugs.webkit.org/show_bug.cgi?id=164208
1023 Reviewed by Darin Adler.
1025 * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
1026 * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1027 Update for new struct types.
1029 2016-10-29 Darin Adler <darin@apple.com>
1031 Fix failing ExtendedColor tests.
1033 * TestWebKitAPI/Tests/WebCore/ExtendedColor.cpp:
1034 Changed the tests in two ways: First, use EXPECT_EQ instead of EXPECT_TRUE
1035 for the string equality comparisons. This required including WTFStringUtilities.h.
1036 Second, change expected results to match what the code is currently generating,
1037 so alpha channels are "0.25" rather than "0.25 / 1". I'll let Dean fix both these
1038 tests and the code if these results are incorrect.
1040 2016-10-29 Wenson Hsieh <wenson_hsieh@apple.com>
1042 UIScriptControllerIOS.mm should not be soft-linking UIKit
1043 https://bugs.webkit.org/show_bug.cgi?id=164171
1045 Reviewed by Darin Adler.
1047 Follow-up to r208090. Instead of soft-linking, we can simply grab UIKeyboardPredictionView by name instead.
1049 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1050 (WTR::UIScriptController::waitForTextPredictionsViewAndSelectCandidateAtIndex):
1052 2016-10-28 Darin Adler <darin@apple.com>
1054 Move all classes in the HTML directory from ExceptionCode to Exception
1055 https://bugs.webkit.org/show_bug.cgi?id=163876
1057 Reviewed by Sam Weinig.
1059 * TestWebKitAPI/Tests/WebCore/TimeRanges.cpp:
1060 (TestWebKitAPI::ToString): Updated for changes to the TimeRanges class.
1061 (TestWebKitAPI::TEST): Ditto.
1063 2016-10-28 Devin Rousso <dcrousso+webkit@gmail.com>
1065 Unreviewed, changed Devin Rousso's email and nick.
1067 * Scripts/webkitpy/common/config/contributors.json:
1069 2016-10-28 Wenson Hsieh <wenson_hsieh@apple.com>
1071 Unreviewed, fix the iOS build after r208090.
1073 Use soft-linking as needed in UIScriptControllerIOS.mm.
1075 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1076 (WTR::UIScriptController::waitForTextPredictionsViewAndSelectCandidateAtIndex):
1078 2016-10-28 Wenson Hsieh <wenson_hsieh@apple.com>
1080 iOS autocorrection does not trigger an input event of inputType "insertReplacementText"
1081 https://bugs.webkit.org/show_bug.cgi?id=164077
1082 <rdar://problem/28987810>
1084 Reviewed by Simon Fraser.
1086 Adds test support for inserting text candidates on iOS in the form of
1087 UIScriptController.selectTextCandidateAtIndex(index, callback), which selects the text candidate at a given
1088 index (this needs to be a value between 0-2 on iOS) and fires the callback when done.
1090 To implement this, we wait for the text prediction view to have predictions (we determine this by polling at a
1091 given interval) and then tap the center of the text prediction view at the given index.
1093 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1094 (WTR::UIScriptController::selectTextCandidateAtIndex):
1095 * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1096 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1097 (WTR::UIScriptController::selectTextCandidateAtIndex):
1098 (WTR::UIScriptController::waitForTextPredictionsViewAndSelectCandidateAtIndex):
1099 * TestRunnerShared/UIScriptContext/UIScriptController.h:
1100 * WebKitTestRunner/ios/UIKitSPI.h:
1101 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1102 (WTR::UIScriptController::selectTextCandidateAtIndex):
1103 (WTR::UIScriptController::waitForTextPredictionsViewAndSelectCandidateAtIndex):
1105 2016-10-28 Commit Queue <commit-queue@webkit.org>
1107 Unreviewed, rolling out r207700.
1108 https://bugs.webkit.org/show_bug.cgi?id=164168
1110 We are ready after r208086 (Requested by alexchristensen on
1115 "Unreviewed, rolling out r207582."
1116 https://bugs.webkit.org/show_bug.cgi?id=163819
1117 http://trac.webkit.org/changeset/207700
1119 2016-10-28 Alex Christensen <achristensen@webkit.org>
1121 Partially revert 207805 after resolution in URL spec issue 87
1122 https://bugs.webkit.org/show_bug.cgi?id=164142
1124 Reviewed by Andy Estes.
1126 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1127 (TestWebKitAPI::TEST_F):
1129 2016-10-28 Alex Christensen <achristensen@webkit.org>
1131 URLParser should not try to interpret host of URLs with unrecognized schemes as IPv4 address
1132 https://bugs.webkit.org/show_bug.cgi?id=164154
1134 Reviewed by Andy Estes.
1136 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1137 (TestWebKitAPI::TEST_F):
1139 2016-10-28 Sam Weinig <sam@webkit.org>
1141 [WebIDL] Update parser and code generators to only access type information through the type property
1142 https://bugs.webkit.org/show_bug.cgi?id=164141
1144 Reviewed by Anders Carlsson.
1146 * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
1147 * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1148 Update to always access type information through type accessors. Remove use of removed
1151 2016-10-28 Frederic Wang <fwang@igalia.com>
1153 [GTK] Upgrade HarfBuzz to version 1.3.3
1154 https://bugs.webkit.org/show_bug.cgi?id=162719
1156 Reviewed by Michael Catanzaro.
1158 * gtk/jhbuild.modules:
1160 2016-10-27 Chris Dumez <cdumez@apple.com>
1162 Regression(r203601): Caused crashes in iBooks
1163 https://bugs.webkit.org/show_bug.cgi?id=164093
1164 <rdar://problem/28745634>
1166 Reviewed by Darin Adler.
1168 Add API test coverage.
1170 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1171 * TestWebKitAPI/Tests/mac/DOMNode.mm: Added.
1172 (-[DOMNodeTest webView:didFinishLoadForFrame:]):
1173 (TestWebKitAPI::TEST):
1175 2016-10-27 Sam Weinig <sam@webkit.org>
1177 [WebIDL] Move code generators off of domSignature::type and onto domSignature::idlType
1178 https://bugs.webkit.org/show_bug.cgi?id=164089
1180 Reviewed by Alex Christensen.
1182 * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
1183 * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1184 Update for the removal of domSignature::type, and new signatures of helper predicates.
1186 2016-10-27 Commit Queue <commit-queue@webkit.org>
1188 Unreviewed, rolling out r207992.
1189 https://bugs.webkit.org/show_bug.cgi?id=164070
1191 triggered aclocal version conflict (Requested by mcatanzaro on
1196 "[GTK] Bump glib to 2.50.1 (or find alternative solution to
1197 Gtk+ CUPS build issue)"
1198 https://bugs.webkit.org/show_bug.cgi?id=163689
1199 http://trac.webkit.org/changeset/207992
1201 2016-10-27 Joanmarie Diggs <jdiggs@igalia.com>
1203 [GTK] Bump glib to 2.50.1 (or find alternative solution to Gtk+ CUPS build issue)
1204 https://bugs.webkit.org/show_bug.cgi?id=163689
1206 Reviewed by Michael Catanzaro.
1208 In order to fix bug #163591, we need to apply an upstream patch to GTK+.
1209 But GTK+ won't build with that patch due to the following error:
1211 m4_copy: won't overwrite defined macro: glib_DEFUN
1213 There is an upstream GLib patch which solves that issue. We should apply
1214 that patch as well, until we bump GLib to 2.50.1 or later.
1216 * gtk/jhbuild.modules: Apply upstream GLib patch.
1217 * gtk/patches/glib-deprecate-am-glib-gnu-gettext.patch: Added.
1219 2016-10-27 Xabier Rodriguez Calvar <calvaris@igalia.com>
1221 Unreviewed fix of GTK and EFL test bots.
1223 * Scripts/webkitperl/FeatureList.pm: Deactivated media-source and
1224 legacy-encrypted-media by default for GTK and EFL.
1226 2016-10-26 Yusuke Suzuki <utatane.tea@gmail.com>
1228 [GTK] JSC test wasm.yaml/wasm/js-api/test_basic_api.js.default-wasm and wasm.yaml/wasm/js-api/test_Module.js.default-wasm fail with Exception: ReferenceError: Can't find variable: WebAssembly
1229 https://bugs.webkit.org/show_bug.cgi?id=163846
1231 Reviewed by Michael Catanzaro.
1233 WebAssembly is now developed for Darwin right now.
1234 Disable WASM tests in the other platforms.
1236 * Scripts/run-jsc-stress-tests:
1238 2016-10-26 Enrique Ocaña González <eocanha@igalia.com>
1240 [cmake][GStreamer][MSE][EME] Build MSE and EME code after refactoring
1241 https://bugs.webkit.org/show_bug.cgi?id=162928
1243 Reviewed by Xabier Rodriguez-Calvar.
1245 Explicitly enable MSE and EME on WebKitGTK+ buildbots.
1247 This patch is co-authored with Philippe Normand <philn@igalia.com> (EME support).
1249 * Scripts/webkitperl/FeatureList.pm:
1251 2016-10-25 Antoine Quint <graouts@apple.com>
1253 [Modern Media Controls] Media Controller: skip back support
1254 https://bugs.webkit.org/show_bug.cgi?id=163725
1255 <rdar://problem/27989480>
1257 Reviewed by Dean Jackson.
1259 * Scripts/webkitpy/layout_tests/servers/aliases.json: Adding a new alias such that we may
1260 access the modern-media-controls source files through the web server.
1262 2016-10-19 Jer Noble <jer.noble@apple.com>
1264 Add WKWebView fullscreen delegate SPI
1265 https://bugs.webkit.org/show_bug.cgi?id=163674
1267 Reviewed by Anders Carlsson.
1269 Add a new API test which verifies that the fullscreen delegate receives notifications.
1271 * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenDelegate.mm:
1272 (-[FullscreenDelegateMessageHandler userContentController:didReceiveScriptMessage:]):
1273 (-[FullscreenDelegateMessageHandler _webViewWillEnterFullscreen:]):
1274 (-[FullscreenDelegateMessageHandler _webViewDidEnterFullscreen:]):
1275 (-[FullscreenDelegateMessageHandler _webViewWillExitFullscreen:]):
1276 (-[FullscreenDelegateMessageHandler _webViewDidExitFullscreen:]):
1277 (TestWebKitAPI::TEST):
1279 2016-10-24 Alex Christensen <achristensen@webkit.org>
1281 URLParser should match old URL::parse with %2E in path
1282 https://bugs.webkit.org/show_bug.cgi?id=163929
1284 Reviewed by Alexey Proskuryakov.
1286 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1287 (TestWebKitAPI::TEST_F):
1289 2016-10-24 Ryan Haddad <ryanhaddad@apple.com>
1291 Unreviewed, rolling out r207795.
1293 Introduced API test failures on iOS and macOS.
1297 "URLParser should match old URL::parse with %2E in path"
1298 https://bugs.webkit.org/show_bug.cgi?id=163929
1299 http://trac.webkit.org/changeset/207795
1301 2016-10-24 Alex Christensen <achristensen@webkit.org>
1303 URLParser should match old URL::parse with %2E in path
1304 https://bugs.webkit.org/show_bug.cgi?id=163929
1306 Reviewed by Alexey Proskuryakov.
1308 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1309 (TestWebKitAPI::TEST_F):
1311 2016-10-21 Alex Christensen <achristensen@webkit.org>
1313 URL::port should return Optional<uint16_t>
1314 https://bugs.webkit.org/show_bug.cgi?id=163806
1316 Reviewed by Darin Adler.
1318 * TestWebKitAPI/Tests/WebCore/URL.cpp:
1319 (TestWebKitAPI::TEST_F):
1320 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1321 (TestWebKitAPI::checkURL):
1322 (TestWebKitAPI::checkRelativeURL):
1323 (TestWebKitAPI::checkURLDifferences):
1324 (TestWebKitAPI::checkRelativeURLDifferences):
1325 (TestWebKitAPI::TEST_F):
1327 2016-10-24 Youenn Fablet <youenn@apple.com>
1329 Activate WEB_RTC compilation flags for Mac bots
1330 https://bugs.webkit.org/show_bug.cgi?id=163886
1332 Reviewed by Eric Carlson.
1334 * Scripts/webkitperl/FeatureList.pm:
1335 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1337 2016-10-24 Wenson Hsieh <wenson_hsieh@apple.com>
1339 Unreviewed, add myself as a WebKit reviewer
1341 * Scripts/webkitpy/common/config/contributors.json:
1343 2016-10-22 Dan Bernstein <mitz@apple.com>
1345 Improve MiniBrowser window titles for URLs without paths and with no title
1346 <https://webkit.org/b/163843>
1348 Reviewed by Darin Adler.
1350 * MiniBrowser/mac/WK1BrowserWindowController.m:
1351 (-[WK1BrowserWindowController fetch:]): While we’re here, deploy
1352 +[NSURL _webkit_URLWithUserTypedString:] here to match the WK2BrowserWindowController
1353 version of this method.
1354 (-[WK1BrowserWindowController updateTitle:]): If the URL doesn’t have a lastPathComponent,
1356 (-[WK1BrowserWindowController webView:didCommitLoadForFrame:]): Also while we’re here,
1357 deploy +[NSURL _web_userVisibleString] here to match the WK2BrowserWindowController
1360 * MiniBrowser/mac/WK2BrowserWindowController.m:
1361 (-[WK2BrowserWindowController updateTitle:]): If the URL doesn’t have a lastPathComponent,
1364 2016-10-21 David Kilzer <ddkilzer@apple.com>
1366 Bug 163762: IntSize::area() should used checked arithmetic
1367 <https://webkit.org/b/163762>
1369 Reviewed by Darin Adler.
1371 * TestWebKitAPI/Tests/WebCore/IntRect.cpp:
1372 (TestWebKitAPI::TEST): Call unsafeGet().
1373 * TestWebKitAPI/Tests/WebCore/IntSize.cpp:
1374 (TestWebKitAPI::TEST): Ditto.
1376 2016-10-21 James Craig <jcraig@apple.com>
1378 Unreviewed: Added Aaron Chu <aaron_chu@apple.com> to contributors list.
1380 * Scripts/webkitpy/common/config/contributors.json:
1382 2016-10-21 Commit Queue <commit-queue@webkit.org>
1384 Unreviewed, rolling out r207582.
1385 https://bugs.webkit.org/show_bug.cgi?id=163819
1387 Not quite ready rdar://problem/28897179 (Requested by
1388 alexchristensen on #webkit).
1392 "Re-enable URLParser for non-Safari Cocoa apps after r207321"
1393 https://bugs.webkit.org/show_bug.cgi?id=163690
1394 http://trac.webkit.org/changeset/207582
1396 2016-10-21 Jonathan Bedard <jbedard@apple.com>
1398 WebKitTestRunnerApp packages .idl file
1399 https://bugs.webkit.org/show_bug.cgi?id=163788
1401 Reviewed by Darin Adler.
1403 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Removed .idl file from app package, removed bad reference to app icon.
1405 2016-10-21 Csaba Osztrogonác <ossy@webkit.org>
1407 [EFL] REGRESSION(r207616): Build is broken due to missing libgeoclue-dev package
1408 https://bugs.webkit.org/show_bug.cgi?id=163733
1410 Reviewed by Gyuyoung Kim.
1412 * efl/install-dependencies: Added geoclue-2.0 package.
1414 2016-10-21 Commit Queue <commit-queue@webkit.org>
1416 Unreviewed, rolling out r207609.
1417 https://bugs.webkit.org/show_bug.cgi?id=163776
1419 As glib bump was rollout, we need to rollout this too
1420 (Requested by rego on #webkit).
1424 "[GTK] Cannot build GTK+ with CUPS 2.* versions"
1425 https://bugs.webkit.org/show_bug.cgi?id=163591
1426 http://trac.webkit.org/changeset/207609
1428 2016-10-20 Chris Dumez <cdumez@apple.com>
1430 "Download Linked File" context menu action should use 'download' attribute as suggested filename
1431 https://bugs.webkit.org/show_bug.cgi?id=163742
1432 <rdar://problem/28840734>
1434 Reviewed by Darin Adler.
1436 Add API test coverage.
1438 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1439 * TestWebKitAPI/Tests/WebKit2/link-with-download-attribute.html: Added.
1440 * TestWebKitAPI/Tests/WebKit2/mac/ContextMenuDownload.mm: Added.
1441 (TestWebKitAPI::didFinishLoadForFrame):
1442 (TestWebKitAPI::getContextMenuFromProposedMenu):
1443 (TestWebKitAPI::decideDestinationWithSuggestedFilename):
1444 (TestWebKitAPI::TEST):
1446 2016-10-20 Commit Queue <commit-queue@webkit.org>
1448 Unreviewed, rolling out r207589.
1449 https://bugs.webkit.org/show_bug.cgi?id=163765
1451 Introduced 17 new layout test failures (Requested by
1452 mcatanzaro on #webkit).
1456 "[GTK] Bump glib to 2.50.1"
1457 https://bugs.webkit.org/show_bug.cgi?id=163689
1458 http://trac.webkit.org/changeset/207589
1460 2016-10-19 Myles C. Maxfield <mmaxfield@apple.com>
1462 [macOS] [iOS] Disable variation fonts on macOS El Capitan and iOS 9
1463 https://bugs.webkit.org/show_bug.cgi?id=163374
1465 Reviewed by Darin Adler.
1467 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1469 2016-10-20 Sam Weinig <sam@webkit.org>
1471 Add convenience function that combines WTF::visit(...) with WTF::makeVisitor(...)
1472 https://bugs.webkit.org/show_bug.cgi?id=163713
1474 Reviewed by Dan Bernstein.
1476 * TestWebKitAPI/Tests/WTF/Variant.cpp:
1477 Add test for WTF::switchOn()
1479 2016-10-20 Fujii Hironori <Hironori.Fujii@sony.com>
1481 [CMake] CMake does not support the dep files for implicit dependency
1482 https://bugs.webkit.org/show_bug.cgi?id=161433
1484 Reviewed by Brent Fulgham.
1486 Created a Perl script to generate all IDL bindings for CMake.
1487 This script can regenerate outdated bindings by based on the
1488 supplemental dependency and dep files created by
1489 '--write-dependencies' switch of generate-bindings.pl.
1491 add_custom_target is used to invoke the script instead of
1492 add_custom_command because Ninja deletes all output files before
1493 executing the command in case of add_custom_command.
1495 USES_TERMINAL option of add_custom_target has two effects:
1496 1) Not buffering output of the command
1497 2) Invoking the command in the special Ninja pool which inhibits parallel build
1498 One needs to use CMake 3.2 or later to enable this feature.
1500 * DumpRenderTree/CMakeLists.txt: Specified a target name for
1501 GENERATE_BINDINGS. Added dependency for the target.
1502 * WebKitTestRunner/CMakeLists.txt: Ditto.
1504 2016-10-20 Manuel Rego Casasnovas <rego@igalia.com>
1506 [GTK] Cannot build GTK+ with CUPS 2.* versions
1507 https://bugs.webkit.org/show_bug.cgi?id=163591
1509 Reviewed by Michael Catanzaro.
1511 GTK+ is wrongly checking about the available CUPS version,
1512 so if you have CUPS 2.* the configure step fails.
1514 This has been already fixed upstream and included in 2.30 series:
1515 https://git.gnome.org/browse/gtk+/commit/?id=631f6b536485829a0bd00532f5826ad302b4951b
1517 Added patch on JHBuild so we can now build GTK+ with CUPS 2.*.
1519 * gtk/jhbuild.modules: Applied patch and avoid using "configure" script directly
1520 as the patch modifies "configure.ac".
1521 * gtk/patches/configure-fix-detecting-CUPS-2.x.patch: Added.
1523 2016-10-20 Manuel Rego Casasnovas <rego@igalia.com>
1525 [GTK] Bump glib to 2.50.1
1526 https://bugs.webkit.org/show_bug.cgi?id=163689
1528 Reviewed by Michael Catanzaro.
1530 This is need in order to fix GTK+ build with CUPS 2.* (bug #163591).
1532 * gtk/jhbuild.modules: Bump glib version. Pass --disable-libmount to build properly.
1533 Also we don't need the patches anymore.
1534 * gtk/patches/gdate-suppress-string-format-literal-warning.patch: Removed.
1535 * gtk/patches/glib-warning-fix.patch: Removed.
1537 2016-10-19 Alex Christensen <achristensen@webkit.org>
1539 Re-enable URLParser for non-Safari Cocoa apps after r207321
1540 https://bugs.webkit.org/show_bug.cgi?id=163690
1542 Reviewed by Darin Adler.
1544 * DumpRenderTree/mac/DumpRenderTree.mm:
1545 (DumpRenderTreeMain):
1546 * TestWebKitAPI/Tests/WebKit2Cocoa/LoadInvalidURLRequest.mm:
1547 (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
1548 * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
1549 (TestWebKitAPI::TEST):
1550 * WebKitTestRunner/TestController.cpp:
1551 (WTR::TestController::TestController):
1553 2016-10-19 Ryan Haddad <ryanhaddad@apple.com>
1555 Unreviewed, rolling out r207557.
1557 This change caused animations/font-variations tests to time
1558 out on pre-Sierra Macs.
1562 "[macOS] [iOS] Disable variation fonts on macOS El Capitan and
1564 https://bugs.webkit.org/show_bug.cgi?id=163374
1565 http://trac.webkit.org/changeset/207557
1567 2016-10-19 Andy Estes <aestes@apple.com>
1569 Crash in ASCIICaseInsensitiveHash::hash() when a response has a null MIME type
1570 https://bugs.webkit.org/show_bug.cgi?id=163476
1571 <rdar://problem/26941395>
1573 Reviewed by Andreas Kling.
1575 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1576 * TestWebKitAPI/Tests/WebKit2Cocoa/LoadDataWithNilMIMEType.mm: Added.
1577 (TEST): Added an API test that passes a nil MIMEType to
1578 -[WKWebView loadData:MIMEType:characterEncodingName:baseURL:].
1580 2016-10-19 Jer Noble <jer.noble@apple.com>
1582 Modify testrunner to mute audio during tests
1583 https://bugs.webkit.org/show_bug.cgi?id=162582
1585 Reviewed by Alexey Proskuryakov.
1587 * DumpRenderTree/mac/DumpRenderTree.mm:
1588 (createWebViewAndOffscreenWindow):
1589 * WebKitTestRunner/TestController.cpp:
1590 (WTR::TestController::resetStateToConsistentValues):
1592 2016-10-19 Joseph Pecoraro <pecoraro@apple.com>
1594 check-webkit-style: fix false-positive warnings about using #pragma once header guard
1595 https://bugs.webkit.org/show_bug.cgi?id=163575
1597 Reviewed by Brady Eidson.
1599 There were some false positive warnings about header guards
1600 for ObjC headers that don't need guards. This changes the
1601 style checker to no longer warn if there is no #pragma once.
1602 It only warns if there are #ifndef that should be #pragma once.
1604 * Scripts/webkitpy/style/checkers/cpp.py:
1605 (check_for_header_guard):
1606 Change when we output an error.
1608 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1609 (CppStyleTest.test_build_header_guard):
1612 2016-10-19 Myles C. Maxfield <mmaxfield@apple.com>
1614 [macOS] [iOS] Disable variation fonts on macOS El Capitan and iOS 9
1615 https://bugs.webkit.org/show_bug.cgi?id=163374
1617 Reviewed by Darin Adler.
1619 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1621 2016-10-18 Philippe Normand <pnormand@igalia.com>
1623 WebRTC: [GTK] Update jhbuild environment for OpenWebRTC
1624 https://bugs.webkit.org/show_bug.cgi?id=163330
1626 Reviewed by Michael Catanzaro.
1628 Bring back the openwebrtc JHBuild moduleset in the time being. It
1629 should be removed after the bump to GStreamer 1.10 is complete and
1630 the libnice patches have been upstreamed. The GStreamer git
1631 snapshots used in this patch are the ones configured in Ericsson's
1632 GStreamer Cerbero fork.
1634 * gtk/openwebrtc.modules: Added.
1635 * gtk/patches/libnice-0001-TURN-allow-REALM-to-be-empty.patch: Added.
1636 * gtk/patches/libnice-0001-agent-Remove-unnecessary-NULL-check.patch: Added.
1637 * gtk/patches/libnice-0001-nicesrc-spin-the-agent-mainloop-in-a-separate-thread.patch: Added.
1638 * gtk/patches/libnice-0002-Do-not-update-a-remote-candidate-s-type.patch: Added.
1639 * gtk/patches/libnice-0002-TURN-handle-437-Allocation-Mismatch-responses.patch: Added.
1640 * gtk/patches/libnice-0003-Do-not-compare-scope-for-IPv6-address-when-scope-is-.patch: Added.
1641 * gtk/patches/libnice-0004-Removing-no-op-assignment.patch: Added.
1643 2016-10-18 Sam Weinig <sam@webkit.org>
1645 Replace std::experimental::variant with WTF::Variant (or similar)
1646 https://bugs.webkit.org/show_bug.cgi?id=163626
1648 Reviewed by Chris Dumez.
1650 Rename std::experimental::variant, Variant. Move helpers get/holds_alternative/etc.
1651 into the WTF namespace.
1653 * TestWebKitAPI/Tests/WTF/Variant.cpp:
1654 (TestWebKitAPI::TEST):
1656 2016-10-18 Simon Fraser <simon.fraser@apple.com>
1658 Add a MiniBrowser menu item to apply page scale in WK1 and WK2
1659 https://bugs.webkit.org/show_bug.cgi?id=163627
1661 Reviewed by Dean Jackson.
1663 Rename setScale: to setViewScale: and add setPageScale:, hooking it up for WK1 (via exisiting SPI)
1664 and WK2 (via new SPI).
1666 * MiniBrowser/mac/BrowserWindowController.h:
1667 * MiniBrowser/mac/BrowserWindowController.m:
1668 (-[BrowserWindowController pageScaleForMenuItemTag:]):
1669 (-[BrowserWindowController setPageScale:]):
1670 (-[BrowserWindowController setViewScale:]):
1671 (-[BrowserWindowController setScale:]): Deleted.
1672 * MiniBrowser/mac/MainMenu.xib:
1673 * MiniBrowser/mac/WK1BrowserWindowController.m:
1674 (-[WK1BrowserWindowController setPageScale:]):
1675 (-[WK1BrowserWindowController setViewScale:]):
1676 (areEssentiallyEqual):
1677 (-[WK1BrowserWindowController validateMenuItem:]):
1678 (-[WK1BrowserWindowController setScale:]): Deleted.
1679 * MiniBrowser/mac/WK2BrowserWindowController.m:
1680 (-[WK2BrowserWindowController setPageScale:]):
1681 (-[WK2BrowserWindowController viewScaleForMenuItemTag:]):
1682 (-[WK2BrowserWindowController setViewScale:]):
1683 (areEssentiallyEqual):
1684 (-[WK2BrowserWindowController validateMenuItem:]):
1685 (viewScaleForMenuItemTag): Deleted.
1686 (-[WK2BrowserWindowController setScale:]): Deleted.
1688 2016-10-18 Anders Carlsson <andersca@apple.com>
1690 Add an beforeunload alert to the WebKitLegacy MiniBrowser
1691 https://bugs.webkit.org/show_bug.cgi?id=163634
1693 Reviewed by Sam Weinig.
1695 * MiniBrowser/mac/WK1BrowserWindowController.m:
1696 (-[WK1BrowserWindowController webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:]):
1698 2016-10-18 Commit Queue <commit-queue@webkit.org>
1700 Unreviewed, rolling out r207443.
1701 https://bugs.webkit.org/show_bug.cgi?id=163616
1703 "Caused 5% PLT regression" (Requested by krollin on #webkit).
1707 "Crash in ASCIICaseInsensitiveHash::hash() when a response has
1709 https://bugs.webkit.org/show_bug.cgi?id=163476
1710 http://trac.webkit.org/changeset/207443
1712 2016-10-18 Eric Carlson <eric.carlson@apple.com>
1714 [MediaStream] Resolve constraints and enumerate devices in the UI process
1715 https://bugs.webkit.org/show_bug.cgi?id=162147
1716 <rdar://problem/28803569>
1718 Reviewed by Darin Adler.
1720 * WebKitTestRunner/TestController.cpp:
1721 (WTR::TestController::resetPreferencesToConsistentValues): Enable mock capture devices.
1722 (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Update for API changes.
1724 2016-10-17 Megan Gardner <megan_gardner@apple.com>
1726 Add test and infrastructure for link popover
1727 https://bugs.webkit.org/show_bug.cgi?id=163406
1729 Reviewed by Simon Fraser.
1731 Added functionality test for link popovers.
1732 Can query for what URL is loaded, and that the popover has appeared or has
1734 Added a link popover test.
1736 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1737 (WTR::UIScriptController::platformSetDidShowForcePressPreviewCallback):
1738 (WTR::UIScriptController::platformSetDidDismissForcePressPreviewCallback):
1739 (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback): Deleted.
1740 * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1741 * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1742 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1743 (WTR::UIScriptController::setDidShowForcePressPreviewCallback):
1744 (WTR::UIScriptController::didShowForcePressPreviewCallback):
1745 (WTR::UIScriptController::setDidDismissForcePressPreviewCallback):
1746 (WTR::UIScriptController::didDismissForcePressPreviewCallback):
1747 (WTR::UIScriptController::platformSetDidShowForcePressPreviewCallback):
1748 (WTR::UIScriptController::platformSetDidDismissForcePressPreviewCallback):
1749 (WTR::UIScriptController::didEndFormControlInteractionCallback): Deleted.
1750 (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback): Deleted.
1751 * TestRunnerShared/UIScriptContext/UIScriptController.h:
1752 * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1753 * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1754 (-[TestRunnerWKWebView dealloc]):
1755 (-[TestRunnerWKWebView didShowForcePressPreview]):
1756 (-[TestRunnerWKWebView didDismissForcePressPreview]):
1757 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1758 (WTR::UIScriptController::platformSetDidShowForcePressPreviewCallback):
1759 (WTR::UIScriptController::platformSetDidDismissForcePressPreviewCallback):
1760 (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback): Deleted.
1762 2016-10-17 Tim Horton <timothy_horton@apple.com>
1764 REGRESSION (r169805): WKWebView canGoBack returning YES when nothing is in the back-forward list after restoring session state
1765 https://bugs.webkit.org/show_bug.cgi?id=163573
1766 <rdar://problem/28744549>
1768 Reviewed by Dan Bernstein.
1770 * TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm:
1772 Add a test ensuring that canGoBack returns NO after restoring session state without navigating.
1774 2016-10-17 Andy Estes <aestes@apple.com>
1776 Crash in ASCIICaseInsensitiveHash::hash() when a response has a null MIME type
1777 https://bugs.webkit.org/show_bug.cgi?id=163476
1778 <rdar://problem/26941395>
1780 Reviewed by Tim Horton.
1782 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1783 * TestWebKitAPI/Tests/WebKit2Cocoa/LoadDataWithNilMIMEType.mm: Added.
1784 (TEST): Added an API test that passes a nil MIMEType to
1785 -[WKWebView loadData:MIMEType:characterEncodingName:baseURL:].
1787 2016-10-17 Dean Jackson <dino@apple.com>
1789 Allow creation of ExtendedColors and make Color immutable
1790 https://bugs.webkit.org/show_bug.cgi?id=163557
1791 <rdar://problem/28805360>
1793 Reviewed by Darin Adler and Dave Hyatt.
1795 API tests for ExtendedColor.
1797 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1798 * TestWebKitAPI/Tests/WebCore/ExtendedColor.cpp: Added.
1799 (TestWebKitAPI::TEST):
1800 (TestWebKitAPI::makeColor):
1802 2016-10-17 JF Bastien <jfbastien@apple.com>
1804 WebAssembly JS API: implement basic stub
1806 Implement the global WebAssembly JavaScript object, and its constructor +
1807 function properties as described in:
1808 https://github.com/WebAssembly/design/blob/master/JS.md
1810 These don't do anything at the moment, the parent bug will take care of adding
1811 more functionality and associated tests.
1813 WebAssembly JS API: implement basic stub
1814 https://bugs.webkit.org/show_bug.cgi?id=163404
1816 Reviewed by Keith Miller.
1818 * Scripts/run-jsc-stress-tests: use the new JSC option which exposes the WebAssembly object.
1820 2016-10-17 Fujii Hironori <Hironori.Fujii@sony.com>
1822 resolve-ChangeLogs: Specify --no-page to git diff
1823 https://bugs.webkit.org/show_bug.cgi?id=163441
1825 Reviewed by Darin Adler.
1827 resolve-ChangeLogs shows the result after resolving by invoking
1828 'git diff'. It runs a pager for every ChangeLog if it is under
1831 * Scripts/resolve-ChangeLogs:
1832 (showStatus): Specify '--no-page' to git diff.
1834 2016-10-17 Michael Catanzaro <mcatanzaro@igalia.com>
1836 Move user agent quirks to cross-platform location
1837 https://bugs.webkit.org/show_bug.cgi?id=163508
1839 Reviewed by Carlos Garcia Campos.
1841 Move the test to a cross-platform location and improve it to better check the full list of
1842 sites we have defined quirks for.
1844 * TestWebKitAPI/PlatformGTK.cmake:
1845 * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp.
1846 (TestWebKitAPI::assertUserAgentForURLHasChromeBrowserQuirk):
1847 (TestWebKitAPI::assertUserAgentForURLHasMacPlatformQuirk):
1848 (TestWebKitAPI::TEST):
1850 2016-10-17 Carlos Garcia Campos <cgarcia@igalia.com>
1852 [SOUP] Downloads should always sniff contents
1853 https://bugs.webkit.org/show_bug.cgi?id=163538
1855 Reviewed by Michael Catanzaro.
1857 Add a test case to check that the MIME type is correctly guessed for downloads.
1859 * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
1862 (testDownloadMIMEType):
1864 (writeNextChunkIdle): Deleted.
1866 2016-10-16 Daniel Bates <dabates@apple.com>
1868 Fix Perl warning about masked variable following <http://trac.webkit.org/changeset/207382>
1869 (https://bugs.webkit.org/show_bug.cgi?id=163456)
1871 * Scripts/prepare-ChangeLog:
1872 (actuallyGenerateFunctionLists):
1874 2016-10-16 Carlos Garcia Campos <cgarcia@igalia.com>
1876 Unreviewed. Fix GTK+ unit test /webkit2/WebKitWebContext/languages after r206949.
1878 After r206949 navigator.language returns en-US instead of en-us. Language tags in Accept-Language header are
1879 actually case-insensitive, so we should actually do case-insensitive comparisons, but we only have
1880 g_assert_cmpstr for tests.
1882 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1883 (testWebContextLanguages):
1885 2016-10-16 Carlos Garcia Campos <cgarcia@igalia.com>
1887 [GTK] WebKitWebPage URI not updated after URI is modified by InjectedBundlePageResourceLoadClient::willSendRequestForFrame
1888 https://bugs.webkit.org/show_bug.cgi?id=163389
1890 Reviewed by Michael Catanzaro.
1892 Update /webkit2/WebKitWebPage/get-uri test to check that web view and page uri always match even when request is
1893 modified by WebKitWebPage::send-request signal.
1895 * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
1898 2016-10-16 Carlos Garcia Campos <cgarcia@igalia.com>
1900 Document request not updated after willSendRequest is called for a redirect
1901 https://bugs.webkit.org/show_bug.cgi?id=163436
1903 Reviewed by Michael Catanzaro.
1905 Update /webkit2/WebKitWebView/active-uri test to check the active URI also when modified by
1906 WebKitPage::send-request signal in a web extension.
1908 * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
1909 (testWebViewActiveURI):
1911 * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1912 (sendRequestCallback):
1913 * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
1914 (loadChangedCallback):
1916 2016-10-15 Dan Bernstein <mitz@apple.com>
1918 REGRESSION (r191699): Contextual menu in Mail compose view doesn’t include any of the standard submenus
1919 https://bugs.webkit.org/show_bug.cgi?id=163492
1920 <rdar://problem/28654799>
1922 Reviewed by Darin Adler.
1924 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1925 * TestWebKitAPI/Tests/mac/ContextMenuDefaultItemsHaveTags.mm: Added.
1926 (-[ContextMenuDefaultItemsHaveTagsDelegate webView:didFinishLoadForFrame:]):
1927 (TestWebKitAPI::TEST):
1929 2016-10-15 Daniel Bates <dabates@apple.com>
1931 prepare-ChangeLog erroneously said that a python __init__ method was deleted
1932 https://bugs.webkit.org/show_bug.cgi?id=163456
1934 Reviewed by Simon Fraser.
1936 Fixes an issue where prepare-ChangeLog may list as deleted functions that are
1937 immediately above added code.
1939 Currently prepare-ChangeLog makes use of the same overlap detection algorithm
1940 to compute the list of deleted functions as it does to compute added and modified
1941 functions. We consider a function deleted if its entire function body and signature
1942 are removed. It is sufficient to compare the list of functions before the patch
1943 is applied and the list of functions are the patch is applied to identify
1946 * Scripts/prepare-ChangeLog: Fix some style nits, including using Camel Case for
1948 (actuallyGenerateFunctionLists): Modified to call computeModifiedFunctions(). Always
1949 compute the list of functions in the file after the patch regardless of whether the
1950 patch only contains deletions. We will compare this list against the list of functions
1951 before the patch was applied to determine the deleted functions.
1952 (computeModifiedFunctions): Renamed; formerly named generateFunctionListsByRanges.
1953 Removed out argument for the seen functions as we no longer make use of when computing
1954 the list of deleted functions.
1955 (diffCommand): Update comment.
1956 (generateFunctionListsByRanges): Deleted.
1957 * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl: Added more unit tests.
1959 2016-10-14 Simon Fraser <simon.fraser@apple.com>
1961 REGRESSION (r206973): Running "webkit-patch suggest-reviewers" throws an AttributeError: 'NoneType' object has no attribute 'full_name'
1962 https://bugs.webkit.org/show_bug.cgi?id=163478
1964 Reviewed by Daniel Bates.
1966 Handle a None other in Contributor.__eq__.
1968 * Scripts/webkitpy/common/config/committers.py:
1969 (Contributor.__eq__):
1971 2016-10-14 JF Bastien <jfbastien@apple.com>
1973 Basic WebAssembly testing
1975 Create a small DSL in JavaScript which can build WebAssembly binary modules based on the JSON description of the format as described in:
1976 https://github.com/WebAssembly/design/blob/master/BinaryEncoding.md
1978 This DSL can then be used to write small text description of valid and invalid WebAssembly binaries, making testing the JSC implementation much easier.
1980 Details and example in README.md.
1982 Basic WebAssembly testing
1983 https://bugs.webkit.org/show_bug.cgi?id=163267
1985 Reviewed by Keith Miller.
1987 * Scripts/run-javascriptcore-tests:
1988 (runJSCStressTests): run wasm.yaml tests
1989 * Scripts/run-jsc-stress-tests: add a WebAssembly-specific runner
1991 2016-10-14 Simon Fraser <simon.fraser@apple.com>
1993 Annotate bots in contributors.json and don't show them on webkit.org/team
1994 https://bugs.webkit.org/show_bug.cgi?id=163317
1996 Reviewed by Daniel Bates.
1998 Add "class" : "bot" for non-humans in contributors.json and round-trip it.
2000 * Scripts/webkitpy/common/config/committers.py:
2001 (Contributor.__init__):
2002 (Contributor.as_dict):
2005 (CommitterList.load_json):
2006 * Scripts/webkitpy/common/config/contributors.json:
2008 2016-10-14 Simon Fraser <simon.fraser@apple.com>
2010 Fix printing in WK2 MiniBrowser
2011 https://bugs.webkit.org/show_bug.cgi?id=163455
2013 Reviewed by Tim Horton.
2015 Call the basic -_printOperationWithPrintInfo: which doens't require a frame argument.
2017 * MiniBrowser/mac/WK2BrowserWindowController.m:
2018 (-[WK2BrowserWindowController printWebView:]):
2020 2016-10-14 Commit Queue <commit-queue@webkit.org>
2022 Unreviewed, rolling out r207335.
2023 https://bugs.webkit.org/show_bug.cgi?id=163445
2025 WebKit2.ProvisionalURLAfterWillSendRequestCallback is timing
2026 out on Mac bots (Requested by youenn on #webkit).
2030 "Add ProvisionalURLAfterWillSendRequestCallback.cpp and
2031 ProvisionalURLAfterWillSendRequestCallback_Bundle.cpp to Mac
2033 https://bugs.webkit.org/show_bug.cgi?id=163440
2034 http://trac.webkit.org/changeset/207335
2036 2016-10-14 Youenn Fablet <youenn@apple.com>
2038 Add ProvisionalURLAfterWillSendRequestCallback.cpp and ProvisionalURLAfterWillSendRequestCallback_Bundle.cpp to Mac builds
2039 https://bugs.webkit.org/show_bug.cgi?id=163440
2043 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Adding new test files introduced in
2044 https://bugs.webkit.org/show_bug.cgi?id=146306 patch.
2046 2016-10-13 Carlos Garcia Campos <cgarcia@igalia.com>
2048 Unreviewed. Removed myself from BindingsScripts watch list.
2050 * Scripts/webkitpy/common/config/watchlist:
2052 2016-10-13 Carlos Garcia Campos <cgarcia@igalia.com>
2054 WebView and WebPage URLs not updated after URL is modified by InjectedBundlePageResourceLoadClient::willSendRequestForFrame
2055 https://bugs.webkit.org/show_bug.cgi?id=146306
2057 Reviewed by Darin Adler.
2059 Add unit test to check that the committed URL is updated when changed in willSendRequest callback.
2061 * TestWebKitAPI/CMakeLists.txt:
2062 * TestWebKitAPI/PlatformEfl.cmake:
2063 * TestWebKitAPI/PlatformGTK.cmake:
2064 * TestWebKitAPI/Tests/WebKit2/ProvisionalURLAfterWillSendRequestCallback.cpp: Added.
2065 (TestWebKitAPI::didCommitLoadForFrame):
2066 (TestWebKitAPI::TEST):
2067 * TestWebKitAPI/Tests/WebKit2/ProvisionalURLAfterWillSendRequestCallback_Bundle.cpp: Added.
2068 (TestWebKitAPI::ProvisionalURLAfterWillSendRequestCallbackTest::ProvisionalURLAfterWillSendRequestCallbackTest):
2069 (TestWebKitAPI::ProvisionalURLAfterWillSendRequestCallbackTest::willSendRequestForFrame):
2070 (TestWebKitAPI::ProvisionalURLAfterWillSendRequestCallbackTest::didCommitLoadForFrame):
2072 2016-10-13 Alex Christensen <achristensen@webkit.org>
2074 Hosts of URLs with non-special schemes should be case-sensitive, and non-ASCII characters in such hosts should be punycode-encoded
2075 https://bugs.webkit.org/show_bug.cgi?id=163413
2077 Reviewed by Tim Horton.
2079 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2080 (TestWebKitAPI::TEST_F):
2081 Update parsing results. There are now fewer differences between the new URLParser and the old URL::parse.
2083 2016-10-13 Alex Christensen <achristensen@webkit.org>
2085 Rebase API tests after r207305.
2087 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2088 Actually build Tests/mac/LoadInvalidURLRequest.mm so we are running the WebKit1.LoadInvalidURLRequest API test.
2089 * TestWebKitAPI/Tests/WebKit2Cocoa/LoadInvalidURLRequest.mm:
2090 (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
2091 * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
2092 (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2093 Change results back to what they were before r207162, r207167, and r207184.
2095 2016-10-13 Alex Christensen <achristensen@webkit.org>
2097 Disable URLParser for non-Safari iOS and Mac apps for now
2098 https://bugs.webkit.org/show_bug.cgi?id=163397
2100 Reviewed by Tim Horton.
2102 * DumpRenderTree/mac/DumpRenderTree.mm:
2103 (DumpRenderTreeMain):
2104 * WebKitTestRunner/TestController.cpp:
2105 Enable the URLParser for testing.
2106 * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
2107 Link with WebCoreTestSupport so we can find setURLParserEnabled.
2109 2016-10-13 Ryan Haddad <ryanhaddad@apple.com>
2111 Unreviewed, rolling out r207297.
2113 This change broke the iOS build.
2117 "Disable URLParser for non-Safari iOS and Mac apps for now"
2118 https://bugs.webkit.org/show_bug.cgi?id=163397
2119 http://trac.webkit.org/changeset/207297
2121 2016-10-13 Alex Christensen <achristensen@webkit.org>
2123 Disable URLParser for non-Safari iOS and Mac apps for now
2124 https://bugs.webkit.org/show_bug.cgi?id=163397
2126 Reviewed by Tim Horton.
2128 * DumpRenderTree/mac/DumpRenderTree.mm:
2129 (DumpRenderTreeMain):
2130 * WebKitTestRunner/ios/mainIOS.mm:
2132 * WebKitTestRunner/mac/main.mm:
2135 2016-10-12 Alex Christensen <achristensen@webkit.org>
2137 Fix out-of-bounds reading in URLParser when parsing improperly percent-encoded values
2138 https://bugs.webkit.org/show_bug.cgi?id=163376
2140 Reviewed by Saam Barati.
2142 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2143 (TestWebKitAPI::TEST_F):
2145 2016-10-11 Dean Jackson <dino@apple.com>
2147 Add preliminary support for extended colors to WebCore::Color
2148 https://bugs.webkit.org/show_bug.cgi?id=162878
2149 <rdar://problem/28596413>
2151 Reviewed by Darin Adler.
2153 A new API test for Colors.
2155 * TestWebKitAPI/Tests/WebCore/Color.cpp:
2156 (TestWebKitAPI::TEST):
2158 2016-10-12 Ryan Haddad <ryanhaddad@apple.com>
2160 Unreviewed, rolling out r207225.
2162 This change causes debug tests to exit early with crashes.
2166 "Optional's move-constructor and move-assignment operator
2167 don't disengage the value being moved from"
2168 https://bugs.webkit.org/show_bug.cgi?id=163309
2169 http://trac.webkit.org/changeset/207225
2171 2016-10-12 Alex Christensen <achristensen@webkit.org>
2173 Fix assertion after switching to URLParser
2174 https://bugs.webkit.org/show_bug.cgi?id=163350
2175 rdar://problem/28739938
2177 Reviewed by Brady Eidson.
2179 * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
2182 2016-10-11 Sam Weinig <sam@webkit.org>
2184 Optional's move-constructor and move-assignment operator don't disengage the value being moved from
2185 https://bugs.webkit.org/show_bug.cgi?id=163309
2187 Reviewed by Anders Carlsson.
2189 * TestWebKitAPI/Tests/WTF/Optional.cpp:
2190 (TestWebKitAPI::TEST):
2191 Add tests for Optional's move-constructor and move-assignment operator.
2193 2016-10-12 Wenson Hsieh <wenson_hsieh@apple.com>
2195 Now playing media sessions are always cleared for the active foreground tab
2196 https://bugs.webkit.org/show_bug.cgi?id=163310
2197 <rdar://problem/28573301>
2199 Reviewed by Jer Noble.
2201 Tweaks existing unit tests to verify that media session info persists when backgrounding and foregrounding, but
2202 that media session info is correctly cleared out if the media session itself is no longer eligible for Now
2203 Playing (not accounting for foreground/active state). Previously, these tests were verifying that we would
2204 always clear out the information, but this is incorrect, and is the source of the problem.
2206 * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
2207 (-[NowPlayingTestWebView waitForNowPlayingInfoToChange]):
2208 (TestWebKitAPI::TEST):
2210 2016-10-12 Per Arne Vollan <pvollan@apple.com>
2212 [Win] Parallel DRTs are sharing preferences and cache.
2213 https://bugs.webkit.org/show_bug.cgi?id=163013
2215 Reviewed by Brent Fulgham.
2217 Use separate cache and preferences for each DRT instance.
2219 * DumpRenderTree/win/DumpRenderTree.cpp:
2223 (setDefaultsToConsistentValuesForTesting):
2224 * Scripts/webkitpy/port/win.py:
2225 (WinPort.setup_test_run):
2227 2016-10-11 Alex Christensen <achristensen@webkit.org>
2229 Update API test expectation after r207162.
2230 https://bugs.webkit.org/show_bug.cgi?id=162660
2232 * TestWebKitAPI/Tests/WebKit2Cocoa/LoadInvalidURLRequest.mm:
2233 (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
2234 Like r207167 but with a WebKit2 test.
2235 "https://www.example.com<>/" was an invalid URL with the old URL parser, is now valid with URLParser but not with NSURL's parser.
2237 2016-10-11 Alex Christensen <achristensen@webkit.org>
2239 Update API test expectation after r207162.
2240 https://bugs.webkit.org/show_bug.cgi?id=162660
2242 * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
2243 (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2244 "https://www.example.com<>/" was an invalid URL with the old URL parser.
2245 It is now a valid URL, but NSURL still considers it invalid.
2246 This will be looked into more with https://bugs.webkit.org/show_bug.cgi?id=163127
2248 2016-10-11 Edward O'Connor <eoconnor@apple.com>
2250 Update my name in contributors.json
2251 https://bugs.webkit.org/show_bug.cgi?id=163251
2253 Reviewed by Simon Fraser.
2255 * Scripts/webkitpy/common/config/contributors.json:
2257 2016-10-11 Said Abou-Hallawa <sabouhallawa@apple.com>
2259 Add SynchronizedFixedQueue class
2260 https://bugs.webkit.org/show_bug.cgi?id=162478
2262 Reviewed by Geoffrey Garen.
2264 Add a new test for SynchronizedFixedQueue. The test defines a new class
2265 called ToUpperConverter which converts strings from lower case to upper
2266 case. It creates two threads : (1) produce thread and (2) consume thread.
2267 Here is what each thread does:
2269 1. Main threads: Enqueues lower case strings into m_lowerQueue.
2270 2. Produce thread: Dequeues lower case strings from m_lowerQueue and
2271 enqueue their upper case strings in the m_upperQueue.
2272 3. Consume thread: Dequeues upper case strings from m_upperQueue.
2274 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2275 * TestWebKitAPI/Tests/WTF/SynchronizedFixedQueue.cpp: Added.
2276 (TestWebKitAPI::textItem): A helper function which returns a lower case string given an index.
2277 (TestWebKitAPI::toUpper): A helper function which Returns the upper case of a string.
2278 (TestWebKitAPI::ToUpperConverter::ToUpperConverter):
2279 (TestWebKitAPI::ToUpperConverter::produceQueue): Returns a workQueue for the produce thread.
2280 (TestWebKitAPI::ToUpperConverter::consumeQueue): Returns a workQueue for the consume thread.
2281 (TestWebKitAPI::ToUpperConverter::startProducing): Creates a thread for the producer.
2282 (TestWebKitAPI::ToUpperConverter::startConsuming): Creates a thread for the consumer.
2283 (TestWebKitAPI::ToUpperConverter::start): Starts both the producer and the consumer threads.
2284 (TestWebKitAPI::ToUpperConverter::stopProducing): Terminates the producer thread.
2285 (TestWebKitAPI::ToUpperConverter::stopConsuming): Terminates the consumer thread.
2286 (TestWebKitAPI::ToUpperConverter::stop): Terminates both the producer and the consumer threads.
2287 (TestWebKitAPI::ToUpperConverter::enqueueLower): Adds a lower case string to the m_lowerQueue on the main thread.
2288 (TestWebKitAPI::ToUpperConverter::isProducing): Returns whether the producing thread is active.
2289 (TestWebKitAPI::ToUpperConverter::isConsuming): Returns whether the consuming thread is active.
2290 (TestWebKitAPI::ToUpperConverter::produceCount): Returns the number of produced elements.
2291 (TestWebKitAPI::ToUpperConverter::consumeCount): Returns the number of consumed elements.
2292 (TestWebKitAPI::TEST):
2294 2016-10-11 Megan Gardner <megan_gardner@apple.com>
2296 Extend event stream to include interpolated events and add a force press test that uses that interpolation
2297 https://bugs.webkit.org/show_bug.cgi?id=163161
2299 Reviewed by Simon Fraser.
2301 Added functionality to the event stream to allow for interpolated events.
2302 Can now do long press, as well as a better way to do drag and other time-based
2303 events that require a large stream of descrete HID events.
2304 Added a basic force touch test to demostrate this interpolation.
2305 Also updated the script to allow for iPhone 7 specific tests, as force touch
2306 needs to be on a device that had force touch.
2308 * Scripts/webkitpy/port/ios.py:
2310 * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2311 * WebKitTestRunner/ios/HIDEventGenerator.mm:
2312 (linearInterpolation):
2313 (simpleCurveInterpolation):
2314 (calculateNextCurveLocation):
2316 (interpolationFromString):
2317 (-[HIDEventGenerator eventMaskFromEventInfo:]):
2318 (-[HIDEventGenerator _createIOHIDEventWithInfo:]):
2319 (-[HIDEventGenerator moveToPoints:touchCount:duration:]):
2320 (-[HIDEventGenerator interpolatedEvents:]):
2321 (-[HIDEventGenerator processEventsArray:withStartTime:]):
2322 (-[HIDEventGenerator eventDispatchThreadEntry:]):
2323 (simpleDragCurve): Deleted.
2324 (calculateNextLocation): Deleted.
2326 2016-10-11 Alex Christensen <achristensen@webkit.org>
2328 URLParser should percent-encode non-ASCII and non-printable characters in fragment
2329 https://bugs.webkit.org/show_bug.cgi?id=163287
2331 Reviewed by Brady Eidson.
2333 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2334 (TestWebKitAPI::TEST_F):
2336 2016-10-11 Alex Christensen <achristensen@webkit.org>
2338 Remove dead networking code
2339 https://bugs.webkit.org/show_bug.cgi?id=163263
2341 Reviewed by Daniel Bates.
2343 * DumpRenderTree/DumpRenderTree.h:
2344 * DumpRenderTree/config.h:
2345 * DumpRenderTree/win/DumpRenderTree.cpp:
2348 2016-10-11 John Wilander <wilander@apple.com>
2350 Modify check-webkit-style to prohibit sensitive phrases
2351 https://bugs.webkit.org/show_bug.cgi?id=163048
2352 <rdar://problem/28289755>
2354 Terms considered or found to be too general to flag:
2355 ASSERT_WITH_SECURITY_IMPLICATION, bad cast, bug, bypass, crash,
2356 denial of service, dereference, disclosure, error, exploit,
2357 failure, heap, integer overflow, leak, null dereference,
2358 null pointer dereference, out of bounds, overflow,
2359 race condition, sensitive information, stack, type confusion.
2361 Reviewed by Brent Fulgham.
2363 * Scripts/webkitpy/style/checkers/changelog.py:
2364 (ChangeLogChecker.check_entry):
2365 Now calls ChangeLogChecker.check_for_unwanted_security_terms().
2367 (ChangeLogChecker.check_for_unwanted_security_terms):
2368 New function to check for sensitive terms.
2369 (ChangeLogChecker.check_for_unwanted_security_terms.FoundUnwantedSecurityTerm):
2370 (ChangeLogChecker.check_for_unwanted_security_terms.FoundUnwantedSecurityTerm.__init__):
2372 * Scripts/webkitpy/style/checkers/changelog_unittest.py:
2373 (ChangeLogCheckerTest.test_unwanted_security_terms):
2375 2016-10-11 Ryan Haddad <ryanhaddad@apple.com>
2377 Unreviewed, rolling out r207067.
2379 This change caused webkitpy test failures.
2383 "[Win] Parallel DRTs are sharing preferences and cache."
2384 https://bugs.webkit.org/show_bug.cgi?id=163013
2385 http://trac.webkit.org/changeset/207067
2387 2016-10-11 Per Arne Vollan <pvollan@apple.com>
2389 [Win] Parallel DRTs are sharing preferences and cache.
2390 https://bugs.webkit.org/show_bug.cgi?id=163013
2392 Reviewed by Brent Fulgham.
2394 Use separate cache and preferences for each DRT instance.
2396 * DumpRenderTree/win/DumpRenderTree.cpp:
2400 (setDefaultsToConsistentValuesForTesting):
2401 * Scripts/webkitpy/port/win.py:
2402 (WinPort.setup_test_run):
2404 2016-10-10 Zan Dobersek <zdobersek@igalia.com>
2406 Add ENABLE_ENCRYPTED_MEDIA configuration option
2407 https://bugs.webkit.org/show_bug.cgi?id=163219
2409 Reviewed by Darin Adler.
2411 * Scripts/webkitperl/FeatureList.pm:
2412 Make the ENABLE_ENCRYPTED_MEDIA option overridable via build-webkit.
2413 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2414 Add the ENABLE_ENCRYPTED_MEDIA configuration option. It will be used
2415 to enable or disable the new EME implementation at build-time.
2417 2016-10-10 Commit Queue <commit-queue@webkit.org>
2419 Unreviewed, rolling out r206972.
2420 https://bugs.webkit.org/show_bug.cgi?id=163227
2422 Making EWS flaky (Requested by bfulgham_ on #webkit).
2426 "[CMake] CMake does not support the dep files for implicit
2428 https://bugs.webkit.org/show_bug.cgi?id=161433
2429 http://trac.webkit.org/changeset/206972
2431 2016-10-10 Youenn Fablet <youenn@apple.com>
2433 W3C test downloader should be able to import specific files/sub-directories in a skipped directory
2434 https://bugs.webkit.org/show_bug.cgi?id=161789
2436 Reviewed by Ryosuke Niwa.
2438 Removed tests_directory option and corresponding test.
2439 This option was allowing to import a sub-directory from a test repository.
2440 We can readd it if necessary.
2442 Adding support for finer-grained import rules.
2443 Previously skipped directories were fully removed.
2444 Now, directories may be skipped but sub directories of them may be imported.
2445 This currently happens in web-platform-tests repo.
2447 * Scripts/webkitpy/w3c/test_downloader.py:
2448 (TestDownloader._add_test_suite_paths): Removing tests_directory option.
2449 (TestDownloader.copy_tests): Refactoring file copy by generating the list of all directories for which direct files should be imported.
2450 (TestDownloader.copy_tests.should_copy_dir):
2451 (TestDownloader.copy_tests.should_copy_file):
2452 * Scripts/webkitpy/w3c/test_importer_unittest.py:
2453 (TestImporterTest.test_tests_directory): Deleted.
2454 (TestImporterTest.test_skip_test_import): Added.
2456 2016-10-09 Simon Fraser <simon.fraser@apple.com>
2458 Make validate-committer-lists show inactive reviewers
2459 https://bugs.webkit.org/show_bug.cgi?id=163193
2461 Reviewed by Sam Weinig.
2463 In preparation for updating contributors.json with the WebKit policy of retiring
2464 inactive reviewers, make validate-committer-lists show the list of reviewers who
2465 have not reviewed in the past year.
2467 This list is computed by grepping the output of 'git log --since=1.year" for
2468 the reviewer line, and looking up reviewers via Contributor.mentioned_in_text(),
2469 which looks for full names, aliases, irc nicks and email addresses.
2471 Support for aliases is added to Contributor. Aliases are alternates
2472 or misspellings of the reviewer's name. Some common aliases were added to
2473 contributors.json by manual examination of "Reviewed by" lines.
2475 * Scripts/validate-committer-lists:
2476 (CommitterListFromGit.possibly_expired_committers):
2477 (CommitterListFromGit):
2478 (CommitterListFromGit.possibly_inactive_reviewers):
2479 (CommitterListFromGit.print_possibly_expired_committers):
2480 (CommitterListFromGit.print_possibly_inactive_reviewers):
2481 * Scripts/webkitpy/common/config/committers.py:
2482 (Contributor.__init__):
2483 (Contributor.contains_string):
2484 (Contributor.mentioned_in_text):
2485 (Contributor.as_dict):
2486 (Committer.__init__):
2487 (Reviewer.__init__):
2488 (CommitterList.load_json):
2489 * Scripts/webkitpy/common/config/contributors.json:
2491 2016-10-09 Simon Fraser <simon.fraser@apple.com>
2493 Convert contributors.json to a flat list
2494 https://bugs.webkit.org/show_bug.cgi?id=163183
2496 Reviewed by Darin Adler.
2498 Make contributors.json easier to maintain by eliminating the big groupings ("Committers", "Reviewers" etc)
2499 and moving that data to a "status" property on each contributor.
2501 * Scripts/webkitpy/common/config/committers.py:
2502 (Contributor.__eq__): Implement this to fix unit tests, now that load_json() is not @memoized.
2503 (Contributor.as_dict): Include status in the dict.
2504 (CommitterList.__init__): Clean up to make the testing code path more explicit.
2505 (CommitterList.load_json):
2506 (CommitterList.load_test_data):
2507 (CommitterList.as_json):
2508 (Contributor.__unicode__): Deleted.
2509 * Scripts/webkitpy/common/config/contributors.json:
2510 * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2511 (IRCCommandTest.test_whois): The ordering here is now alphabetical.
2513 2016-10-09 Fujii Hironori <Hironori.Fujii@sony.com>
2515 [CMake] CMake does not support the dep files for implicit dependency
2516 https://bugs.webkit.org/show_bug.cgi?id=161433
2518 Reviewed by Brent Fulgham.
2520 Created a Perl script to generate all IDL bindings for CMake.
2521 This script can regenerate outdated bindings by based on the
2522 supplemental dependency and dep files created by
2523 '--write-dependencies' switch of generate-bindings.pl.
2525 add_custom_target is used to invoke the script instead of
2526 add_custom_command because Ninja deletes all output files before
2527 executing the command in case of add_custom_command.
2529 USES_TERMINAL option of add_custom_target has two effects:
2530 1) Not buffering output of the command
2531 2) Invoking the command in the special Ninja pool which inhibits parallel build
2532 One needs to use CMake 3.2 or later to enable this feature.
2534 * DumpRenderTree/CMakeLists.txt: Specified a target name for
2535 GENERATE_BINDINGS. Added dependency for the target.
2536 * WebKitTestRunner/CMakeLists.txt: Ditto.
2538 2016-10-09 Simon Fraser <simon.fraser@apple.com>
2540 Add support for canonicalizing contributors.json, and have check-webkit-style check the format.
2541 https://bugs.webkit.org/show_bug.cgi?id=163177
2545 For unknown reasons, overriding Commiter.__dict__() caused mysterious test failures.
2546 Rename it to as_dict().
2548 * Scripts/webkitpy/common/config/committers.py:
2549 (Contributor.as_dict):
2550 (CommitterList._contributor_list_to_dict):
2551 (Contributor.__dict__): Deleted.
2553 2016-10-08 Simon Fraser <simon.fraser@apple.com>
2555 Add support for canonicalizing contributors.json, and have check-webkit-style check the format.
2556 https://bugs.webkit.org/show_bug.cgi?id=163177
2558 Reviewed by Ryosuke Niwa.
2560 Make it possible to round-trip contributors.json through CommitterList, so we can
2561 support writing out contributors.json in canonical format. This requires saving
2562 the case-preserved email and expertise in Contributor. CommitterList also needs
2563 to be able to generate the "exclusive" lists, since it currently uses lists
2564 that are the union of, say, committers and reviewers.
2566 If contributors.json is malformed (invalid JSON), catch the Exception, report it
2567 and exit rather than allowing the exception to propagate. With an invalid file,
2568 an exception would be thrown before the JSON style checker reached this file, so
2569 the error was not correctly reported.
2571 Add style/checker/committer.py for checking that committers.json has the canonical format.
2573 Add support to validate-committer-lists to dump out the canonical json (-d) or update
2574 the file in-place (-c).
2576 * Scripts/validate-committer-lists:
2577 (CommitterListFromGit._print_three_column_row):
2578 (CommitterListFromGit.possibly_expired_committers):
2579 (CommitterListFromGit):
2580 (CommitterListFromGit.print_possibly_expired_committers):
2582 * Scripts/webkitpy/common/config/committers.py:
2583 (Contributor.__init__):
2584 (Contributor.__dict__):
2585 (Committer.__init__):
2586 (Reviewer.__init__):
2587 (CommitterList.load_json):
2589 (CommitterList._contributor_list_to_dict):
2590 (CommitterList.as_json):
2591 (CommitterList.reformat_in_place):
2592 (CommitterList._exclusive_contributors):
2593 (CommitterList._exclusive_committers):
2594 (Contributor.matches_glob): Deleted.
2595 (CommitterList.contributors): Deleted.
2596 * Scripts/webkitpy/common/config/contributors.json:
2597 * Scripts/webkitpy/style/checker.py:
2598 (CheckerDispatcher._create_checker):
2599 * Scripts/webkitpy/style/checkers/contributors.py: Added.
2600 (ContributorsChecker):
2601 (ContributorsChecker.__init__):
2602 (ContributorsChecker.check):
2603 (ContributorsChecker._unidiff_output):
2605 2016-10-06 Darin Adler <darin@apple.com>
2607 Next step on moving to modern way to return DOM exceptions
2608 https://bugs.webkit.org/show_bug.cgi?id=163016
2610 Reviewed by Ryosuke Niwa.
2612 * Scripts/do-webcore-rename: Add proposed name change of setDOMException
2613 to propagateException, since this function is primarily used to take an
2614 exception already effectively "thrown" by setting an ExceptionCode out
2615 argument and propagate it into the JavaScript engine's exception machinery.
2617 2016-10-07 Alex Christensen <achristensen@webkit.org>
2619 Non-special URL fragments should percent-encode non-ASCII characters
2620 https://bugs.webkit.org/show_bug.cgi?id=163153
2622 Reviewed by Tim Horton.
2624 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2625 (TestWebKitAPI::TEST_F):
2627 2016-10-07 Jonathan Bedard <jbedard@apple.com>
2629 Build fix for “Move functionality common to Darwin ports into a base class”
2630 https://bugs.webkit.org/show_bug.cgi?id=160709
2632 Unreviewed build fix.
2634 * Scripts/webkitpy/port/ios.py:
2635 (IOSSimulatorPort._get_crash_log): Added iOS implementation.
2636 * Scripts/webkitpy/port/mac.py:
2637 (MacPort._get_crash_log): Added Mac implementation.
2639 2016-10-07 Chelsea Pugh <cpugh@apple.com>
2641 Unreviewed. Added myself to the list of committers.
2643 * Scripts/webkitpy/common/config/contributors.json:
2645 2016-10-07 Jonathan Bedard <jbedard@apple.com>
2647 Move functionality common to Darwin ports into a base class
2648 https://bugs.webkit.org/show_bug.cgi?id=160709
2650 Reviewed by Darin Adler.
2652 * Scripts/webkitpy/port/apple.py:
2653 (ApplePort.determine_full_port_name): Specific iOS port check.
2654 (ApplePort.__init__): Move leak detector to DarwinPort.
2655 (ApplePort._make_leak_detector): Moved to DarwinPort.
2656 (ApplePort.supports_per_test_timeout): Moved to Port.
2657 (ApplePort.check_for_leaks): Moved to DarwinPort.
2658 (ApplePort.print_leaks_summary): Moved to DarwinPort.
2659 (ApplePort._path_to_webcore_library): Moved to DarwinPort.
2660 (ApplePort.show_results_html_file): Moved to DarwinPort.
2661 (ApplePort._merge_crash_logs): Moved to DarwinPort.
2662 (ApplePort._look_for_all_crash_logs_in_log_dir): Moved to DarwinPort.
2663 (ApplePort._get_crash_log): Moved to DarwinPort.
2664 (ApplePort.look_for_new_crash_logs): Moved to DarwinPort.
2665 (ApplePort.sample_process): Moved to DarwinPort.
2666 (ApplePort.sample_file_path): Moved to DarwinPort.
2667 (ApplePort.look_for_new_samples): Moved to DarwinPort.
2668 * Scripts/webkitpy/port/base.py:
2669 (Port.supports_per_test_timeout): Return true for all ports.
2670 * Scripts/webkitpy/port/darwin.py: Added.
2671 (DarwinPort): Shared iOS and Mac functions.
2672 * Scripts/webkitpy/port/darwin_testcase.py: Added.
2673 (DarwinTest): Shared iOS and Mac testing.
2674 * Scripts/webkitpy/port/efl.py:
2676 (EflPort.supports_per_test_timeout): Moved to Port.
2677 * Scripts/webkitpy/port/gtk.py:
2678 (GtkPort._driver_class):
2680 (GtkPort.supports_per_test_timeout): Moved to Port.
2681 * Scripts/webkitpy/port/ios.py:
2683 (IOSPort.operating_system):
2685 (IOSSimulatorPort.__init__): Inherits from DarwinPort.
2686 (IOSSimulatorPort._port_specific_expectations_files): Moved to DarwinPort.
2687 (IOSSimulatorPort._get_crash_log): Deleted.
2688 (IOSSimulatorPort.xcrun_find): Deleted.
2689 * Scripts/webkitpy/port/ios_unittest.py: Added.
2690 (iosTest): Unit tests for the iOS port.
2691 * Scripts/webkitpy/port/mac.py:
2693 (MacPort.__init__): Inherits from DarwinPort.
2694 (MacPort._port_specific_expectations_files): Moved to DarwinPort.
2695 (MacPort.make_command): Moved to DarwinPort.
2696 (MacPort._get_crash_log): Moved to DarwinPort.
2697 (MacPort.nm_command): Moved to DarwinPort.
2698 * Scripts/webkitpy/port/mac_unittest.py:
2700 (MacTest.test_sdk_name): Added test.
2701 (MacTest.test_xcrun): Added test.
2702 (MacTest.assert_skipped_file_search_paths): Moved to DarwinTest.
2703 (MacTest.test_default_timeout_ms): Moved to DarwinTest.
2704 (MacTest.assert_name): Moved to DarwinTest.
2705 (MacTest.test_helper_starts): Moved to DarwinTest.
2706 (MacTest.test_helper_fails_to_start): Moved to DarwinTest.
2707 (MacTest.test_helper_fails_to_stop): Moved to DarwinTest.
2708 (MacTest.test_spindump): Moved to DarwinTest.
2709 (MacTest.test_sample_process): Moved to DarwinTest.
2710 (MacTest.test_sample_process_exception): Moved to DarwinTest.
2711 * Scripts/webkitpy/port/port_testcase.py:
2713 (PortTestCase.test_diff_image): Added is_simulator flag.
2714 (PortTestCase.test_diff_image): Skip test if on a simulator.
2715 (PortTestCase.test_diff_image_crashed): Skip test if on a simulator.
2716 * Scripts/webkitpy/port/win.py:
2718 (WinPort.look_for_new_samples): Used default, ApplePort no longer implements.
2719 (WinPort.sample_process): Ditto.
2720 (WinPort._make_leak_detector): Ditto.
2721 (WinPort.check_for_leaks): Ditto.
2722 (WinPort.print_leaks_summary): Ditto.
2723 (WinPort._path_to_webcore_library): Ditto.
2725 2016-10-07 Anders Carlsson <andersca@apple.com>
2727 Get rid of WKPageSetSession
2728 https://bugs.webkit.org/show_bug.cgi?id=163129
2730 Reviewed by Tim Horton.
2732 Rewrite this test to use WKPageConfigurationRef and WKWebsiteDataStoreRef.
2734 * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
2735 (TestWebKitAPI::TEST):
2737 2016-10-07 Andreas Kling <akling@apple.com>
2739 [WK2] didRemoveFrameFromHierarchy callback doesn't fire for subframes when evicting from PageCache.
2740 <https://webkit.org/b/163098>
2741 <rdar://problem/28663488>
2743 Reviewed by Antti Koivisto.
2745 Add an API test that puts a 10-subframe page into the page cache, then loads other pages
2746 until the first page gets kicked out. The test succeeds if we receive didRemoveFrameFromHierarchy
2747 callbacks for all the subframes.
2749 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2750 * TestWebKitAPI/Tests/WebKit2/DidRemoveFrameFromHiearchyInPageCache.cpp: Added.
2751 (TestWebKitAPI::didFinishLoadForFrame):
2752 (TestWebKitAPI::setPageLoaderClient):
2753 (TestWebKitAPI::didReceivePageMessageFromInjectedBundle):
2754 (TestWebKitAPI::setInjectedBundleClient):
2755 (TestWebKitAPI::TEST):
2756 * TestWebKitAPI/Tests/WebKit2/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp: Added.
2757 (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
2758 (TestWebKitAPI::DidRemoveFrameFromHiearchyInPageCacheTest::DidRemoveFrameFromHiearchyInPageCacheTest):
2759 (TestWebKitAPI::DidRemoveFrameFromHiearchyInPageCacheTest::didCreatePage):
2760 * TestWebKitAPI/Tests/WebKit2/many-iframes.html: Added.
2762 2016-10-07 Emanuele Aina <emanuele.aina@collabora.com>
2764 Replace bug URL placeholders independently of the short desc one
2765 https://bugs.webkit.org/show_bug.cgi?id=161684
2767 Reviewed by Darin Adler.
2769 Instead of adding the bug URL when replacing the short description
2770 placeholder and then ignoring the bug URL placeholder, use the former
2771 to set the short description and the latter for the bug URL.
2772 This means that developers can fully prepare the changelog with short
2773 and long description before submission leaving the bug placeholder in
2774 place, and the changelog machinery will make sure to replace the
2775 latter with the URL of the newly created bug while submitting.
2777 Note that this also means that the short description placeholder alone
2778 no longer causes the bug URL to be added.
2780 * Scripts/webkitpy/common/checkout/changelog.py:
2781 (ChangeLog.set_short_description_and_bug_url):
2782 * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2783 (test_set_short_description_and_bug_url):
2785 2016-10-07 Jonathan Bedard <jbedard@apple.com>
2787 Style Checking Error when Objective C Blocks passed as Argument
2788 https://bugs.webkit.org/show_bug.cgi?id=162463
2790 Reviewed by Darin Adler.
2792 * Scripts/webkitpy/style/checkers/cpp.py:
2793 (regex_for_lambdas_and_blocks): Consider case where block is passed as a function argument.
2794 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2795 (CppStyleTest.test_objective_c_block_as_argument): Test case where block is passed as a function argument.
2797 2016-10-07 Philippe Normand <pnormand@igalia.com>
2799 [GTK] Docs build failure
2800 https://bugs.webkit.org/show_bug.cgi?id=163102
2802 Reviewed by Carlos Garcia Campos.
2804 * gtk/jhbuild.modules: Bump to gtk-doc 1.25 to fix build errors on Debian Testing.
2806 2016-10-06 Joseph Pecoraro <pecoraro@apple.com>
2808 check-webkit-style: Enable the legal/copyright rule for cpp/h files
2809 https://bugs.webkit.org/show_bug.cgi?id=162707
2811 Reviewed by Darin Adler.
2813 * Scripts/webkitpy/style/checker.py:
2814 Enable this rule by default.
2816 2016-10-06 Joseph Pecoraro <pecoraro@apple.com>
2818 Header guard style should be updated to be "#pragma once"
2819 https://bugs.webkit.org/show_bug.cgi?id=159785
2821 Reviewed by Darin Adler.
2823 * Scripts/webkitpy/style/checkers/cpp.py:
2824 (check_for_header_guard):
2826 Simplify header_guard check to warn for a missing #pragma once
2827 in header files. For legacy files that contain an #ifndef only
2828 warn if the #ifndef line itself is changing.
2830 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2831 (CppStyleTestBase.perform_header_guard_check):
2832 (CppStyleTestBase.assert_header_guard):
2833 Helpers for enabling just this warning.
2835 (CppStyleTest.test_build_header_guard):
2836 Test different header guard cases.
2838 * Scripts/webkitpy/style/error_handlers.py:
2839 (DefaultStyleErrorHandler.should_line_be_checked):
2840 Always allow warnings that output for "line 0" which won't be in
2841 the list of modified lines that are 1-based.
2843 2016-10-06 Commit Queue <commit-queue@webkit.org>
2845 Unreviewed, rolling out r206713.
2846 https://bugs.webkit.org/show_bug.cgi?id=163097
2848 triggers apparent codegen bug on ARM 32-bit (Requested by smfr
2853 "Support transitions/animations of background-position with
2854 right/bottom-relative values"
2855 https://bugs.webkit.org/show_bug.cgi?id=162048
2856 http://trac.webkit.org/changeset/206713
2858 2016-10-06 Alex Christensen <achristensen@webkit.org>
2860 URLParser: Non-ASCII characters in Non-UTF-8 encoded queries of relative URLs with ws, wss, or nonspecial schemes should be UTF-8 encoded
2861 https://bugs.webkit.org/show_bug.cgi?id=163089
2863 Reviewed by Tim Horton.
2865 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2866 (TestWebKitAPI::checkURL):
2867 (TestWebKitAPI::TEST_F):
2869 2016-10-06 Alex Christensen <achristensen@webkit.org>
2871 Skip tabs and newlines between end of query and beginning of fragment in non-UTF-8-encoded URLs
2872 https://bugs.webkit.org/show_bug.cgi?id=163071
2874 Reviewed by Tim Horton.
2876 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2877 (TestWebKitAPI::TEST_F):
2879 2016-10-06 Alex Christensen <achristensen@webkit.org>
2881 URLParser should parse file URLs with ports consistently
2882 https://bugs.webkit.org/show_bug.cgi?id=163075
2884 Reviewed by Brady Eidson.
2886 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2887 (TestWebKitAPI::TEST_F):
2889 2016-10-06 John Wilander <wilander@apple.com>
2891 Update Resource Load Statistics
2892 https://bugs.webkit.org/show_bug.cgi?id=162811
2894 Reviewed by Alex Christensen.
2896 * TestWebKitAPI/Tests/mac/PublicSuffix.mm:
2897 Change from USE(PUBLIC_SUFFIX_LIST) to ENABLE(PUBLIC_SUFFIX_LIST)
2899 2016-10-05 Philippe Normand <pnormand@igalia.com>
2901 [GStreamer][OWR] GL rendering support
2902 https://bugs.webkit.org/show_bug.cgi?id=162972
2904 Reviewed by Žan Doberšek.
2906 When GStreamer-GL is enabled the GL context needs to be properly passed
2907 to the GStreamer pipeline running within the OpenWebRTC video renderer.
2908 This is now supported using a new OpenWebRTC API that allows the
2909 renderer to request the context from the application using a callback
2910 registered within the renderer.
2912 * gtk/jhbuild.modules: Bump to latest OpenWebRTC for the new
2913 owr_video_renderer_set_request_context_callback API added
2916 2016-10-05 Youenn Fablet <youenn@apple.com>
2918 Reuse CodeGenerator::UpdateFile in Tools CodeGenerator
2919 https://bugs.webkit.org/show_bug.cgi?id=162960
2921 Reviewed by Alex Christensen.
2923 * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
2924 (WriteData): Using CodeGenerator::UpdateFile to do lazy generated file update when it is made feasible.
2925 * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2928 2016-10-05 Alex Christensen <achristensen@webkit.org>
2930 URLParser should parse IPv4 addresses as the last two pieces of an IPv6 address
2931 https://bugs.webkit.org/show_bug.cgi?id=162991
2933 Reviewed by Saam Barati.
2935 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2936 (TestWebKitAPI::TEST_F):
2938 2016-10-05 Tim Horton <timothy_horton@apple.com>
2940 Avoid automatically re-taking snapshots for back-forward items that were never loaded into the view
2941 https://bugs.webkit.org/show_bug.cgi?id=162955
2942 <rdar://problem/27659173>
2944 Reviewed by Simon Fraser.
2946 * TestWebKitAPI/Tests/WebKit2Cocoa/SnapshotStore.mm:
2947 (-[SnapshotTestWKWebView init]):
2948 (forceRepaintCallback):
2949 (-[SnapshotTestWKWebView synchronouslyForceRepaint]):
2950 (-[SnapshotTestWKWebView synchronouslyLoadTestPageAndForceRepaint:]):
2952 (makeRedSquareView):
2953 Add a test that restoring session state into a web view without navigating,
2954 then explicitly snapshotting and navigating away, leaves the original snapshot alone.
2956 Adjust the existing test, as well, to ensure that it will reliably fail
2957 if the feature is broken. Use an explicitly added and removed red square
2958 instead of scrolling, because we can't scroll in the restore-without-navigating case.
2960 Stop trying to override the window scale, because it's not working (we're getting partial snapshots)
2961 and isn't necessary; instead just multiply the expected value by the page scale.
2963 (-[SnapshotTestWKWebView loadPageNamed:]): Deleted.
2964 * TestWebKitAPI/mac/TestWKWebViewMac.h:
2965 * TestWebKitAPI/mac/TestWKWebViewMac.mm:
2966 (-[TestWKWebView synchronouslyLoadTestPageNamed:]):
2967 Reorganize to reduce duplication.
2969 2016-10-05 Tim Horton <timothy_horton@apple.com>
2971 Make it possible to test ViewSnapshotStore behaviors
2972 https://bugs.webkit.org/show_bug.cgi?id=162983
2974 Reviewed by Simon Fraser.
2976 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2977 * TestWebKitAPI/Tests/WebKit2Cocoa/SnapshotStore.mm: Added.
2978 (-[SnapshotTestWKWebView init]):
2979 (-[SnapshotTestWKWebView loadPageNamed:]):
2981 Add tests for existing basic snapshotting behavior:
2983 - a back-forward item shouldn't have a snapshot
2984 until it is navigated away from
2986 - causing a back-forward item to fall out of the
2987 back-forward list should remove the snapshot
2989 - calling the explicit snapshotting SPI, then navigating away from the page,
2990 should result in the snapshot being retaken
2992 2016-10-05 Chris Dumez <cdumez@apple.com>
2994 KeyboardEvent.getModifierState() should support "CapsLock" modifier
2995 https://bugs.webkit.org/show_bug.cgi?id=162861
2997 Reviewed by Darin Adler.
2999 Add support for 'capsLockKey' modifier for EventSender.keyDown() so
3000 that we can test this new modifier support for layout tests.
3002 * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3003 (TestWebKitAPI::modifierFlagsForWKModifiers):
3004 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3005 (WTR::parseModifier):
3006 * WebKitTestRunner/mac/EventSenderProxy.mm:
3007 (WTR::buildModifierFlags):
3009 2016-10-05 Jeremy Jones <jeremyj@apple.com>
3011 Add MobileMiniBrowser tests for control center and looping fullscreen.
3012 https://bugs.webkit.org/show_bug.cgi?id=162748
3014 Reviewed by Jer Noble.
3016 Refactor existing MobileMiniBrowserTests and add new tests for
3017 - fullscreen rotation
3018 - fullscreen looping (failing)
3019 - control center interruption (failing)
3021 * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
3022 * MobileMiniBrowser/MobileMiniBrowserFramework/Resources/looping2s.html: Added.
3023 * MobileMiniBrowser/MobileMiniBrowserFramework/test2s.mp4: Added.
3024 * MobileMiniBrowser/MobileMiniBrowserUITests/MobileMiniBrowserUITests.m:
3025 (-[MobileMiniBrowserUITests setUp]):
3026 (-[MobileMiniBrowserUITests waitToTapButtonNamed:forApp:]):
3027 (-[MobileMiniBrowserUITests loadURL:]):
3028 (-[MobileMiniBrowserUITests requireMinFPS:sampleDurationSeconds:message:]):
3029 (-[MobileMiniBrowserUITests ensureFullscreenControls]):
3030 (-[MobileMiniBrowserUITests timeForTimeString:]):
3031 (-[MobileMiniBrowserUITests testBasicVideoPlayback]):
3032 (-[MobileMiniBrowserUITests testBasicVideoFullscreen]):
3033 (-[MobileMiniBrowserUITests testVideoFullscreenAndRotationAnimation]):
3034 (-[MobileMiniBrowserUITests testVideoFullscreenControlCenter]):
3035 (-[MobileMiniBrowserUITests testLoopingFullscreenLockup]):
3037 2016-10-05 Alex Christensen <achristensen@webkit.org>
3039 URLParser should correctly strip unnecessary 0's in IPv6 addresses
3040 https://bugs.webkit.org/show_bug.cgi?id=162979
3042 Reviewed by Brady Eidson.
3044 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3045 (TestWebKitAPI::TEST_F):
3047 2016-10-05 Alex Christensen <achristensen@webkit.org>
3049 UTF-8 encode queries of nonspecial and websocket schemes
3050 https://bugs.webkit.org/show_bug.cgi?id=162956
3052 Reviewed by Geoffrey Garen and Brady Eidson.
3054 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3055 (TestWebKitAPI::TEST_F):
3057 2016-10-05 Alex Christensen <achristensen@webkit.org>
3059 Prepare to enable URLParser
3060 https://bugs.webkit.org/show_bug.cgi?id=162974
3062 Reviewed by Brady Eidson.
3064 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3065 (TestWebKitAPI::TEST_F):
3066 Added some tests that are unrelated to the code change, but these are
3067 reflected in changed LayoutTest results when enabling the URLParser,
3068 and they weren't in the URLParser tests yet. They should be.
3070 2016-10-05 Zan Dobersek <zdobersek@igalia.com>
3072 Rename ENABLE_ENCRYPTED_MEDIA_V2 to ENABLE_LEGACY_ENCRYPTED_MEDIA
3073 https://bugs.webkit.org/show_bug.cgi?id=162903
3075 Reviewed by Alex Christensen.
3077 Rename build guards for the remaining implementation of the legacy EME API
3078 to ENABLE_LEGACY_ENCRYPTED_MEDIA. This will allow for the future implementation
3079 of the near-finished API to be guarded with the simple ENABLE_ENCRYPTED_MEDIA guards.
3081 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Also remove the
3082 ENABLE_IOS_TEXT_AUTOSIZING feature define that was renamed in r206395 and was
3083 throwing up style checker errors.
3085 2016-10-04 Andy Estes <aestes@apple.com>
3087 [iOS] Crash in WebResourceLoaderQuickLookDelegate when the client cancels the navigation to a QuickLook resource
3088 https://bugs.webkit.org/show_bug.cgi?id=162950
3089 <rdar://problem/23759114>
3091 Reviewed by Brady Eidson.
3093 Added a new API test.
3095 * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm: Sorted imports and removed redundant
3096 initialization of static bools.
3097 (runTest): Factored out the common test logic between QuickLook.NavigationDelegate and
3098 QuickLook.CancelNavigationAfterResponse.
3099 (TEST): Added QuickLook.CancelNavigationAfterResponse.
3100 (-[QuickLookDecidePolicyDelegate
3101 webView:decidePolicyForNavigationResponse:decisionHandler:]): Canceled the navigation.
3102 (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Set
3105 2016-10-04 Ryosuke Niwa <rniwa@webkit.org>
3107 Add the support for running ES6SampleBench to run-benchmark
3108 https://bugs.webkit.org/show_bug.cgi?id=162890
3110 Reviewed by Saam Barati.
3112 Added the support for running ES6SampleBench as "es6bench".
3113 e.g. ./Tools/Scripts/run-benchmark --platform osx --plan es6bench --browser safari
3115 Instead of the default 10 iterations, run the test 4 iterations using 5 instances of browser
3116 for the total of 20 iterations.
3118 * Scripts/webkitpy/benchmark_runner/data/patches/ES6SampleBench.patch: Added.
3119 * Scripts/webkitpy/benchmark_runner/data/plans/es6bench.plan: Added.
3120 * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
3121 (start): Fixed the bug that the linter will complain about the presence of "debugOutput" by
3122 removing it if it's present.
3124 2016-10-04 Simon Fraser <simon.fraser@apple.com>
3126 [iOS WK2] Make it possible for a test to describe a user gesture as a stream of events in JSON format
3127 https://bugs.webkit.org/show_bug.cgi?id=162934
3129 Reviewed by Dean Jackson.
3131 With this change, a test can describe a user gesture in an "event stream", which is
3132 some JSON describing an array of events with their underlying touches. The added
3133 test describes a single tap.
3135 The implementation fires up an NSThread, and sleeps the thread between events to dispatch
3136 them at close to real time.
3138 In future, HIDEventGenerator could use this internally for all of the "compound" interactions.
3140 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3141 (WTR::UIScriptController::sendEventStream):
3142 * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3143 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3144 (WTR::UIScriptController::sendEventStream):
3145 * TestRunnerShared/UIScriptContext/UIScriptController.h:
3146 * WebKitTestRunner/ios/HIDEventGenerator.h:
3147 * WebKitTestRunner/ios/HIDEventGenerator.mm:
3148 (transducerTypeFromString):
3150 (-[HIDEventGenerator eventMaskFromEventInfo:]):
3151 (-[HIDEventGenerator touchFromEventInfo:]):
3152 (-[HIDEventGenerator _createIOHIDEventWithInfo:]):
3153 (-[HIDEventGenerator dispatchEventWithInfo:]):
3154 (-[HIDEventGenerator eventDispatchThreadEntry:]):
3155 (-[HIDEventGenerator sendEventStream:completionBlock:]):
3156 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3157 (WTR::UIScriptController::sendEventStream):
3159 2016-10-04 Megan Gardner <megan_gardner@apple.com>
3161 Add Megan to contributor's list
3162 https://bugs.webkit.org/show_bug.cgi?id=162944
3164 Reviewed by Tim Horton.
3166 Add Megan to the contributor's lists so that her e-mail autocompletes for CC
3168 * Scripts/webkitpy/common/config/contributors.json:
3170 2016-10-04 Alex Christensen <achristensen@webkit.org>
3172 Add tests verifying non-special URL hosts are parsed according to spec
3173 https://bugs.webkit.org/show_bug.cgi?id=162885
3175 Reviewed by Sam Weinig.
3177 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3178 (TestWebKitAPI::TEST_F):
3180 2016-10-04 Anders Carlsson <andersca@apple.com>
3182 Properly kill web processes in the launching state
3183 https://bugs.webkit.org/show_bug.cgi?id=162938
3185 Reviewed by Tim Horton.
3187 * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp:
3188 Enable this test again.
3190 2016-10-04 Alex Christensen <achristensen@webkit.org>
3192 URLParser: query-only URLs relative to file URLs should just add a query
3193 https://bugs.webkit.org/show_bug.cgi?id=162888
3195 Reviewed by Tim Horton.
3197 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3198 (TestWebKitAPI::TEST_F):
3200 2016-10-04 Alex Christensen <achristensen@webkit.org>
3202 URLParser should match URL::parse and other browsers when parsing a URL containing only scheme://
3203 https://bugs.webkit.org/show_bug.cgi?id=162909
3205 Reviewed by Tim Horton.
3207 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3208 (TestWebKitAPI::TEST_F):
3210 2016-10-04 Yusuke Suzuki <utatane.tea@gmail.com>
3212 [DOMJIT] Introduce DOMJIT::GetterSetter to tell JIT information
3213 https://bugs.webkit.org/show_bug.cgi?id=162916
3215 Reviewed by Filip Pizlo.
3217 * DumpRenderTree/CMakeLists.txt:
3219 2016-10-04 Wenson Hsieh <wenson_hsieh@apple.com>
3221 Media controls are displayed in the incorrect state momentarily after switching between tabs playing media
3222 https://bugs.webkit.org/show_bug.cgi?id=162766
3223 <rdar://problem/28533523>
3225 Reviewed by Jer Noble.
3227 Adds new tests and tweaks existing tests to verify last updated Now Playing information.
3229 * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
3230 (-[NowPlayingTestWebView _handleActiveNowPlayingSessionInfoResponse:title:duration:elapsedTime:]):
3231 (TestWebKitAPI::TEST):
3232 (-[NowPlayingTestWebView _handleActiveNowPlayingSessionInfoResponse:]): Deleted.
3233 * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-test-now-playing.html:
3235 2016-10-03 Alex Christensen <achristensen@webkit.org>
3237 URLParser should ignore tabs at all locations
3238 https://bugs.webkit.org/show_bug.cgi?id=162836
3240 Reviewed by Geoffrey Garen.
3242 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3243 (TestWebKitAPI::checkURL):
3244 (TestWebKitAPI::checkRelativeURL):
3245 (TestWebKitAPI::checkURLDifferences):
3246 (TestWebKitAPI::checkRelativeURLDifferences):
3247 (TestWebKitAPI::TEST_F):
3249 2016-10-03 Alex Christensen <achristensen@webkit.org>
3251 URLParser: fragment-only URLs relative to file URLs should just add a fragment
3252 https://bugs.webkit.org/show_bug.cgi?id=162871
3254 Reviewed by Geoffrey Garen.
3256 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3257 (TestWebKitAPI::TEST_F):
3259 2016-10-03 Per Arne Vollan <pvollan@apple.com>
3261 [Win] DRT temp folder is not used.
3262 https://bugs.webkit.org/show_bug.cgi?id=162863
3264 Reviewed by Alex Christensen.
3266 Convert DRT temp folder to DOS path, which DRT can use.
3268 * Scripts/webkitpy/port/driver.py:
3269 (Driver._setup_environ_for_driver):
3271 2016-10-03 Alex Christensen <achristensen@webkit.org>
3273 URLParser: empty relative URLs should not copy fragment from the base URL
3274 https://bugs.webkit.org/show_bug.cgi?id=162864
3276 Reviewed by Chris Dumez.
3278 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3279 (TestWebKitAPI::TEST_F):
3281 2016-10-03 Carlos Garcia Campos <cgarcia@igalia.com>
3283 [SOUP] Cleanup persistent credential storage code
3284 https://bugs.webkit.org/show_bug.cgi?id=162777
3286 Reviewed by Alex Christensen.
3288 Use USE(LIBSECRET) instead of ENABLE(CREDENTIAL_STORAGE).
3290 * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
3291 (testWebViewAuthenticationStorage):
3293 2016-10-02 Darin Adler <darin@apple.com>
3295 Rename ExceptionCode-based exception handling to "legacy"
3296 https://bugs.webkit.org/show_bug.cgi?id=162859
3298 Reviewed by Chris Dumez.
3300 * Scripts/do-webcore-rename: Updated script to do this round of renames.
3302 2016-10-02 Wenson Hsieh <wenson_hsieh@apple.com>
3304 Media controls for Soundcloud easily falls out of sync with what's actually playing
3305 https://bugs.webkit.org/show_bug.cgi?id=162843
3306 <rdar://problem/28176874>
3308 Reviewed by Beth Dakin.
3310 Adds two new tests simulating audio playback behavior on soundcloud. Also tweaks some of the WKWebView test
3311 message handling logic to support having multiple message-handler mappings.
3313 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3314 * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
3315 (TestWebKitAPI::TEST):
3316 * TestWebKitAPI/Tests/WebKit2Cocoa/play-audio-on-click.html: Added.
3317 * TestWebKitAPI/mac/TestWKWebViewMac.h:
3318 * TestWebKitAPI/mac/TestWKWebViewMac.mm:
3319 (-[TestMessageHandler addMessage:withHandler:]):
3320 (-[TestMessageHandler userContentController:didReceiveScriptMessage:]):
3321 (-[TestWKWebView performAfterReceivingMessage:action:]):
3322 (-[TestWKWebView performAfterLoading:]):
3323 (-[TestMessageHandler initWithMessage:handler:]): Deleted.
3325 2016-09-30 Alex Christensen <achristensen@webkit.org>
3327 Fix off-by-one error in URLParser::parseIPv4Host
3328 https://bugs.webkit.org/show_bug.cgi?id=162789
3330 Reviewed by Tim Horton.
3332 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3333 (TestWebKitAPI::TEST_F):
3335 2016-09-30 Alex Christensen <achristensen@webkit.org>
3337 URLParser: parsing a URL with an empty host and a colon should fail
3338 https://bugs.webkit.org/show_bug.cgi?id=162795
3340 Reviewed by Tim Horton.
3342 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3343 (TestWebKitAPI::TEST_F):
3345 2016-09-30 Alex Christensen <achristensen@webkit.org>
3347 URLParser: handle syntax violations in non-UTF-8 encoded queries
3348 https://bugs.webkit.org/show_bug.cgi?id=162770
3350 Reviewed by Tim Horton.
3352 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3353 (TestWebKitAPI::checkURL):
3354 (TestWebKitAPI::TEST_F):
3355 Tests with emoji change behavior when we insert a tab between the surrogates, so don't do the
3356 insert-tab-at-each-location verification that syntax violations are handled correctly.
3358 2016-09-30 Megan Gardner <megan_gardner@apple.com>
3360 Make it possible to test web-related user-interface features
3361 https://bugs.webkit.org/show_bug.cgi?id=162657
3363 Reviewed by Simon Fraser.
3365 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3366 (WTR::UIScriptController::contentsOfUserInterfaceItem):
3367 (WTR::UIScriptController::selectFormAccessoryPickerRow): Deleted.
3368 * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3369 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3370 (WTR::UIScriptController::contentsOfUserInterfaceItem):
3371 (WTR::UIScriptController::selectFormAccessoryPickerRow): Deleted.
3372 * TestRunnerShared/UIScriptContext/UIScriptController.h:
3373 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3374 (WTR::UIScriptController::contentsOfUserInterfaceItem):
3375 (WTR::UIScriptController::selectFormAccessoryPickerRow): Deleted.
3377 2016-09-29 Jiewen Tan <jiewen_tan@apple.com>
3379 Expose CryptoKey to web workers
3380 https://bugs.webkit.org/show_bug.cgi?id=162640
3381 <rdar://problem/28182204>
3383 Reviewed by Brent Fulgham.
3385 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3386 * TestWebKitAPI/Tests/WebCore/SerializedCryptoKeyWrap.mm: Added.
3387 (TestWebKitAPI::TEST_F):
3388 Add API tests for SerializedCryptoKeyWrap APIs.
3390 2016-09-29 Alex Christensen <achristensen@webkit.org>
3392 Fix syntax violation handling in IPv4 address parsing
3393 https://bugs.webkit.org/show_bug.cgi?id=162756
3395 Reviewed by Tim Horton.
3397 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3398 (TestWebKitAPI::TEST_F):
3400 2016-09-29 Alex Christensen <achristensen@webkit.org>
3402 URLParser should correctly parse ports with leading 0's
3403 https://bugs.webkit.org/show_bug.cgi?id=162752
3405 Reviewed by Tim Horton.
3407 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3408 (TestWebKitAPI::TEST_F):
3410 2016-09-29 Alex Christensen <achristensen@webkit.org>
3412 URLParser: make parsing invalid IPv4 addresses more robust and correct
3413 https://bugs.webkit.org/show_bug.cgi?id=162746
3415 Reviewed by Tim Horton.
3417 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3418 (TestWebKitAPI::TEST_F):
3420 2016-09-29 Alex Christensen <achristensen@webkit.org>
3422 URLParser: IPv6 addresses followed by a colon are invalid
3423 https://bugs.webkit.org/show_bug.cgi?id=162747
3425 Reviewed by Tim Horton.
3427 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3428 (TestWebKitAPI::TEST_F):
3430 2016-09-29 Alexey Proskuryakov <ap@apple.com>
3432 Make WKTR short timeout dynamic
3433 https://bugs.webkit.org/show_bug.cgi?id=162733
3435 Reviewed by Alex Christensen.
3437 WebKitTestRunner has a hardcoded value for how long to wait for IPC responses,
3438 which is 5 seconds, or 10 seconds under ASan. But some of the operations can be
3439 fairly time consuming - e.g. launching Networking process on demand.
3440 These may take longer under load, especially with GuardMalloc.
3442 * WebKitTestRunner/TestController.cpp:
3443 (WTR::TestController::resetStateToConsistentValues):
3444 (WTR::TestController::reattachPageToWebProcess):
3445 * WebKitTestRunner/TestController.h:
3446 * WebKitTestRunner/TestInvocation.cpp:
3447 (WTR::TestInvocation::shortTimeout):
3448 (WTR::TestInvocation::invoke):
3449 (WTR::TestInvocation::dumpResults):
3451 * WebKitTestRunner/TestInvocation.h:
3452 (WTR::TestInvocation::customTimeout): Deleted, this function was unused.
3454 2016-09-29 Alex Christensen <achristensen@webkit.org>
3456 URLParser should fail to parse unclosed IPv6 addresses
3457 https://bugs.webkit.org/show_bug.cgi?id=162715
3459 Reviewed by Tim Horton.
3461 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3462 (TestWebKitAPI::TEST_F):
3464 2016-09-29 Alex Christensen <achristensen@webkit.org>
3466 URLParser should ignore tabs at all possible locations
3467 https://bugs.webkit.org/show_bug.cgi?id=162711
3469 Reviewed by Tim Horton.
3471 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3472 (TestWebKitAPI::ExpectedParts::isInvalid):
3473 (TestWebKitAPI::checkURL):
3474 (TestWebKitAPI::TEST_F):
3476 2016-09-29 Gyuyoung Kim <gyuyoung.kim@navercorp.com>
3478 [EFL] Add search button to url bar in MiniBrowser
3479 https://bugs.webkit.org/show_bug.cgi?id=162716
3481 Reviewed by Michael Catanzaro.
3483 As a bug title, it would be good to add a search button to URL bar.
3484 Additionally this patch changes color of button to recognize the buttons.
3486 * MiniBrowser/efl/main.c:
3487 (_search_button_clicked_cb):
3488 (_create_toolbar_button):
3490 (create_toolbar_button): Deleted.
3492 2016-09-28 Tim Horton <timothy_horton@apple.com>
3494 API test WebKit2.AutoLayoutIntegration is a flaky timeout
3495 https://bugs.webkit.org/show_bug.cgi?id=160284
3497 Reviewed by Dan Bernstein.
3499 * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
3500 (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]):
3501 (-[AutoLayoutWKWebView beginLayoutAtMinimumWidth:andExpectContentSizeChange:]):
3502 (-[AutoLayoutWKWebView waitForContentSizeChangeResettingWidth:]):
3503 (-[AutoLayoutWKWebView layoutAtMinimumWidth:andExpectContentSizeChange:resettingWidth:]):
3504 (-[AutoLayoutWKWebView invalidateIntrinsicContentSize]):
3506 Make the autolayout tests a bit more flexible regarding the ordering of
3507 invalidateIntrinsicContentSize, to avoid a race between the load
3508 completing and the invalidation.
3510 Also, move the newly added test to use its own WKWebView, since once in a
3511 while we get a first layout notification from the previous page, causing the test to fail.
3513 Un-disable the tests, which now run without any flakes for me with quite a few iterations.
3515 2016-09-28 Alex Christensen <achristensen@webkit.org>
3517 URLParser should properly handle unexpected periods and overflows in IPv4 addresses
3518 https://bugs.webkit.org/show_bug.cgi?id=162655
3520 Reviewed by Geoffrey Garen.
3522 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3523 (TestWebKitAPI::TEST_F):
3525 2016-09-28 Ryan Haddad <ryanhaddad@apple.com>
3527 Disable flaky API test WebKit2.AutoLayoutIntegration.
3528 https://bugs.webkit.org/show_bug.cgi?id=160284
3530 Unreviewed test gardening.
3532 * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
3535 2016-09-28 Alex Christensen <achristensen@webkit.org>
3537 URLParser should ignore tabs in authority
3538 https://bugs.webkit.org/show_bug.cgi?id=162694
3540 Reviewed by Geoffrey Garen.
3542 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3543 (TestWebKitAPI::TEST_F):
3545 2016-09-28 Alex Christensen <achristensen@webkit.org>
3547 URLParser should ignore extra slashes after scheme:// and handle a missing slash after the port
3548 https://bugs.webkit.org/show_bug.cgi?id=162690
3550 Reviewed by Geoffrey Garen.
3552 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3553 (TestWebKitAPI::TEST_F):
3555 2016-09-28 Alex Christensen <achristensen@webkit.org>
3557 URLParser should correctly canonicalize uppercase IPv6 addresses
3558 https://bugs.webkit.org/show_bug.cgi?id=162680
3560 Reviewed by Tim Horton.
3562 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3563 (TestWebKitAPI::TEST_F):
3565 2016-09-27 Wenson Hsieh <wenson_hsieh@apple.com>
3567 Adopt MediaRemote SPI to achieve desired Now Playing behavior
3568 https://bugs.webkit.org/show_bug.cgi?id=162658
3569 <rdar://problem/28499358>
3571 Reviewed by Jer Noble.
3573 Introduces 2 unit tests in the new NowPlayingControlsTests test suite. Also provides some basic support for
3574 mocking key window status for TestWKWebViews.
3576 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3577 * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm: Added.
3578 (-[NowPlayingTestWebView hasActiveNowPlayingSession]):
3579 (-[NowPlayingTestWebView expectHasActiveNowPlayingSession:]):
3580 (-[NowPlayingTestWebView _handleActiveNowPlayingSessionInfoResponse:]):
3581 (TestWebKitAPI::TEST):
3582 * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-test-now-playing.html: Added.
3583 * TestWebKitAPI/mac/TestWKWebViewMac.mm:
3584 (-[TestWKWebViewHostWindow isKeyWindow]):
3585 (-[TestWKWebViewHostWindow makeKeyWindow]):
3586 (-[TestWKWebViewHostWindow resignKeyWindow]):
3588 2016-09-28 Per Arne Vollan <pvollan@apple.com>
3591 https://bugs.webkit.org/show_bug.cgi?id=162670
3593 Reviewed by Brent Fulgham.
3595 Make sure we include JavaScriptCore files from the forwarding headers folder.
3596 Otherwise we might get multiple definitions if a JSC file is included both
3597 from the forwarding headers folder and the JSC source folder, since
3598 #pragma once is used in the header files.
3600 * DumpRenderTree/TestRunner.cpp:
3602 2016-09-28 Michael Catanzaro <mcatanzaro@igalia.com>
3604 [GTK] Add Chrome UA quirk
3605 https://bugs.webkit.org/show_bug.cgi?id=162617
3607 Reviewed by Carlos Garcia Campos.
3609 Update test. This portion of the commit was actually unreviewed.
3611 * TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp:
3612 (TestWebKitAPI::TEST):
3614 2016-09-28 Michael Catanzaro <mcatanzaro@igalia.com>
3616 [GTK] Adjust OS X UA quirks list
3617 https://bugs.webkit.org/show_bug.cgi?id=162616
3619 "Reviewed" by Carlos Garcia Campos.
3621 Update test. This portion of the commit was actually unreviewed.
3623 * TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp:
3624 (TestWebKitAPI::TEST):
3626 2016-09-28 Carlos Garcia Campos <cgarcia@igalia.com>
3628 [GTK] Switch to use GMenu internally in the context menu implementation
3629 https://bugs.webkit.org/show_bug.cgi?id=162603
3631 Reviewed by Michael Catanzaro.
3633 Remove smart separators test, since that's now done automatically by GTK+.
3635 * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp: