2a01e811e8585b866487ca2d51dcbf9be7c6a4cf
[WebKit-https.git] / Tools / ChangeLog
1 2011-01-16  Adam Barth  <abarth@webkit.org>
2
3         Update more include paths to reflect WebKit move.
4
5         * DumpRenderTree/chromium/EventSender.cpp:
6         (EventSender::keyDown):
7         (EventSender::needsShiftModifier):
8         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
9         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
10
11 2011-01-16  Kent Tamura  <tkent@chromium.org>
12
13         Unreviewed, Chromium build fix.
14
15         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
16
17 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
18
19         Build fix for GTK+ after source directory movement.
20
21         * GNUmakefile.am: Correct include paths.
22
23 2011-01-16  Adam Barth  <abarth@webkit.org>
24
25         Teach svn-apply about WebKit move.
26
27         * Scripts/VCSUtils.pm:
28
29 2011-01-16  Adam Barth  <abarth@webkit.org>
30
31         Rubber-stamped by Eric Seidel.
32
33         Move WebKit into Source
34         https://bugs.webkit.org/show_bug.cgi?id=52530
35
36         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
37         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
38         * DumpRenderTree/qt/DumpRenderTreeQt.h:
39         * DumpRenderTree/qt/GCControllerQt.cpp:
40         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
41         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
42         * DumpRenderTree/qt/TextInputControllerQt.cpp:
43         * DumpRenderTree/wscript:
44         * QtTestBrowser/launcherwindow.h:
45         * Scripts/build-webkit:
46         * Scripts/webkitdirs.pm:
47
48 2011-01-15  Adam Barth  <abarth@webkit.org>
49
50         Teach svn-apply about WebKit2 move.
51
52         * Scripts/VCSUtils.pm:
53
54 2011-01-15  Adam Barth  <abarth@webkit.org>
55
56         Rubber-stamped by Eric Seidel.
57
58         Move WebKit2 into Source
59         https://bugs.webkit.org/show_bug.cgi?id=52438
60
61         * MiniBrowser/qt/MiniBrowser.pro:
62         * Scripts/build-webkit:
63         * Scripts/do-file-rename:
64         * Scripts/do-webcore-rename:
65         * Scripts/test-webkitpy:
66         * Scripts/webkitdirs.pm:
67         * Scripts/webkitpy/style/checker.py:
68         * WebKitTestRunner/DerivedSources.pro:
69         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
70         * WebKitTestRunner/qt/WebKitTestRunner.pro:
71
72 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
73
74         Reviewed by David Levin.
75
76         [chromium] remove obsolete createView method
77         https://bugs.webkit.org/show_bug.cgi?id=52437
78
79         * DumpRenderTree/chromium/WebViewHost.cpp:
80         (WebViewHost::createView):
81         * DumpRenderTree/chromium/WebViewHost.h:
82
83 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
84
85         Reviewed by Geoff Garen.
86
87         ShouldLoadResourceForFrame should use strings, not URLs.
88         https://bugs.webkit.org/show_bug.cgi?id=52476
89
90         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
91         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
92         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
93
94 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
95
96         Reviewed by David Levin.
97
98         Add Tony Gentilcore as a reviewer
99         https://bugs.webkit.org/show_bug.cgi?id=52480
100
101         * Scripts/webkitpy/common/config/committers.py:
102
103 2011-01-14  David Levin  <levin@chromium.org>
104
105         Reviewed by Eric Seidel.
106
107         check-webkit-style: _FunctionState should keep track of where the function name starts.
108         https://bugs.webkit.org/show_bug.cgi?id=52454
109
110         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
111         _FunctionState and logic for setting it correctly.
112         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
113
114 2011-01-14  Vincent Scheib  <scheib@chromium.org>
115
116         Reviewed by David Levin.
117
118         Add support to DumpRenderTree to use the GPU rather than software renderer
119         https://bugs.webkit.org/show_bug.cgi?id=52333
120
121         * DumpRenderTree/chromium/DumpRenderTree.cpp:
122         (main):
123         * Scripts/webkitpy/layout_tests/port/chromium.py:
124         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
125
126 2011-01-14  Tony Chang  <tony@chromium.org>
127
128         Reviewed by Kent Tamura.
129
130         [chromium] update fonts.conf to fix 6 linux tests in drt
131         https://bugs.webkit.org/show_bug.cgi?id=52411
132
133         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
134             chromium's src/webkit/tools/test_shell/resources/fonts.conf
135
136 2011-01-14  Eric Seidel  <eric@webkit.org>
137
138         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
139
140         Reviewed by Adam Barth.
141
142         Fix when running Tools/Scripts/check-webkit-style without arguments.
143         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
144
145         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
146         * Scripts/webkitpy/common/checkout/scm_unittest.py:
147
148 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
149
150         Reviewed by David Levin.
151
152         Store the tempdir object in a variable so it doesn't get deleted too early.
153         https://bugs.webkit.org/show_bug.cgi?id=51875
154
155         * Scripts/update-webkit-auxiliary-libs:
156         * Scripts/update-webkit-support-libs:
157
158 2011-01-14  Eric Seidel  <eric@webkit.org>
159
160         Unreviewed.  Make it work in python 2.5.
161
162         webkit-patch suggest-reviewers dies when ChangeLogs are missing
163         https://bugs.webkit.org/show_bug.cgi?id=49158
164
165         * Scripts/webkitpy/common/checkout/api_unittest.py:
166
167 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
168
169         Unreviewed, rolling out r75774.
170         http://trac.webkit.org/changeset/75774
171         https://bugs.webkit.org/show_bug.cgi?id=52431
172
173         gtk builds were broken (Requested by loislo2 on #webkit).
174
175         * Scripts/webkitpy/common/checkout/scm.py:
176
177 2011-01-14  David Levin  <levin@chromium.org>
178
179         Reviewed by Shinichiro Hamaji.
180
181         check-webkit-style: _FunctionState should detect pure functions.
182         https://bugs.webkit.org/show_bug.cgi?id=52428
183
184         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
185         is a pure virtual function.
186         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
187         virtual functions are correctly detected.
188
189 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
190
191         Reviewed by Yury Semikhatsky.
192
193         Just small fix for problem with check-webkit-style.
194         It just didn't work for this patch.
195         Old code can't concatenate a list of strings with None.
196
197         * Scripts/webkitpy/common/checkout/scm.py:
198
199 2011-01-13  David Levin  <levin@chromium.org>
200
201         Reviewed by Shinichiro Hamaji.
202
203         check-webkit-style: _FunctionState should use Position to know where items are.
204         https://bugs.webkit.org/show_bug.cgi?id=52424
205
206         * Scripts/webkitpy/style/checkers/cpp.py:
207         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
208         (detect_functions): Changed to pass Position's to _FunctionState.begin and
209         did some minor clean-up.
210         (*): Other changes are simply about converting to use the Position's in_FunctionState
211         instead of line numbers.
212         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
213         to verify the positions stored in _FunctionState.
214
215 2011-01-13  Eric Seidel  <eric@webkit.org>
216
217         Reviewed by David Levin.
218
219         webkit-patch suggest-reviewers dies when ChangeLogs are missing
220         https://bugs.webkit.org/show_bug.cgi?id=49158
221
222         This is not the most elegant, but it is a very safe fix to this bug.
223         One advantage of catching ScriptError like this instead of adding a
224         new added_or_modified_files or fixing all changed_files callers
225         to use a more specific change_files variant, is that we catch
226         all kinds of ScriptErrors which might cause our (non-essential)
227         suggest-reviewers code to fail out.  This should make passing
228         --suggest-reviewers to webkit-patch upload much more robust
229         and may even make it possible for us to make it default.
230
231         The root of the problem here is that SCM.changed_files includes
232         deleted ChangeLog paths (from moves, etc) which then when we ask
233         SVN/Git for the contents of the file at that revision, the command
234         errors out and Executive.run_command raises a ScriptError.
235
236         In the future we might fix this differently by making all current
237         callers of chagned_files use a more specific method for requesting
238         what types of changes they're interested in (adds, modifies, deletes, etc.)
239
240         * Scripts/webkitpy/common/checkout/api.py:
241         * Scripts/webkitpy/common/checkout/api_unittest.py:
242
243 2011-01-13  Dan Bernstein  <mitz@apple.com>
244
245         Reviewed by Alexey Proskuryakov.
246
247         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
248         https://bugs.webkit.org/show_bug.cgi?id=52419
249
250         Allow to further control the behavior of the willSendRequest delegate callback by making it
251         set a different URL in the new request.
252
253         * DumpRenderTree/LayoutTestController.cpp:
254         (addURLToRedirectCallback): Added.
255         (LayoutTestController::staticFunctions): Added addURLToRedirect.
256         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
257         (LayoutTestController::redirectionDestinationForURL): Added this getter.
258         * DumpRenderTree/LayoutTestController.h:
259         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
260         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
261         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
262         change the URL in the new request to the redirect destination.
263
264 2011-01-13  Eric Seidel  <eric@webkit.org>
265
266         Reviewed by Mihai Parparita.
267
268         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
269         https://bugs.webkit.org/show_bug.cgi?id=52416
270
271         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
272         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
273
274         I also added FIXMEs about the changed_files returning deleted files problem
275         which is causing the other most common exception for suggest-reviewers
276         (and is probably breaking sheriff-bots blame detection).
277
278         * Scripts/webkitpy/common/checkout/api.py:
279         * Scripts/webkitpy/common/checkout/api_unittest.py:
280         * Scripts/webkitpy/common/checkout/scm.py:
281
282 2011-01-13  Eric Seidel  <eric@webkit.org>
283
284         Reviewed by Adam Barth.
285
286         results archives from commit-queue are too large to upload
287         https://bugs.webkit.org/show_bug.cgi?id=52405
288
289         * Scripts/webkitpy/common/system/filesystem.py:
290         * Scripts/webkitpy/common/system/filesystem_mock.py:
291         * Scripts/webkitpy/tool/commands/queues.py:
292
293 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
294
295         Reviewed by Martin Robinson.
296
297         [gtk] Zero-sized font does not yet work
298         https://bugs.webkit.org/show_bug.cgi?id=49793
299
300         Set minimum-font-size to 0 for the DRT.
301
302         * DumpRenderTree/gtk/DumpRenderTree.cpp:
303         (resetDefaultsToConsistentValues):
304
305 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
306
307         Reviewed by Darin Adler.
308
309         Make old-run-webkit-tests more robust on buildbots
310         https://bugs.webkit.org/show_bug.cgi?id=52364
311
312         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
313
314 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
315
316         Reviewed by Darin Adler.
317
318         Make old-run-webkit-tests more robust on buildbots
319         https://bugs.webkit.org/show_bug.cgi?id=52364
320
321         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
322
323 2011-01-13  Tony Chang  <tony@chromium.org>
324
325         Reviewed by Kent Tamura.
326
327         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
328         https://bugs.webkit.org/show_bug.cgi?id=52332
329
330         Forked Info.plist is not longer needed.
331
332         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
333
334 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
335
336         Reviewed by Timothy Hatcher.
337
338         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
339         to be passed directly to WebInspector.UIString
340
341         https://bugs.webkit.org/show_bug.cgi?id=52365
342
343         * Scripts/check-inspector-strings:
344
345 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
346
347         Unreviewed, rolling out r74881.
348         http://trac.webkit.org/changeset/74881
349         https://bugs.webkit.org/show_bug.cgi?id=52357
350
351         The EFL builder has been red for days (Requested by abarth on
352         #webkit).
353
354         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
355         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
356
357 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
358
359         Reviewed by David Levin.
360
361         Add beforeunload support to WebKitTestRunner
362         https://bugs.webkit.org/show_bug.cgi?id=52353
363         
364         This makes a number of currently failing tests pass.
365
366         * WebKitTestRunner/TestController.cpp:
367         (WTR::runBeforeUnloadConfirmPanel):
368         (WTR::createOtherPage):
369         (WTR::TestController::initialize):
370
371 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
372
373         Reviewed by Sam Weinig.
374
375         Detect, identify and recover from WebProcess crashes in run-webkit-tests
376         https://bugs.webkit.org/show_bug.cgi?id=52330
377
378         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
379         a web process crash.
380         * WebKitTestRunner/TestController.cpp:
381         (WTR::TestController::initialize): Set up a processDidCrash
382         callback.
383         (WTR::TestController::processDidCrash): Report that the Web process
384         crashed.
385         * WebKitTestRunner/TestController.h:
386
387 2011-01-12  David Levin  <levin@chromium.org>
388
389         Reviewed by Shinichiro Hamaji.
390
391         check-webkit-style -- close_expression function doesn't work correctly.
392         https://bugs.webkit.org/show_bug.cgi?id=52272
393
394         * Scripts/webkitpy/style/checkers/cpp.py:
395         (Position.__str__): Added a way to convert it to a string which is useful in tests.
396         (Position.__cmp__): Added a way to compare Position which is useful in tests and
397         generally useful (for upcoming code changes).
398         (close_expression): Changed to use Position for input and output.
399         Also, fixed many bugs such as only working correctly for parenthesis,
400         not working correctly if given an offset in a line and not finding
401         the real closing element if there were multiple closing elements in
402         the same line.
403         (detect_functions): Adjusted due to the change in arguments for
404         close_expression.
405         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
406         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
407         two positions are the same.
408         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
409         (CppStyleTest.test_close_expression): Added tests to catch the issues
410         that were fixed.
411
412 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
413
414         Unreviewed, rolling out r75576.
415         http://trac.webkit.org/changeset/75576
416         https://bugs.webkit.org/show_bug.cgi?id=52304
417
418         broke rebaseline-chromium-webkit-test (Requested by thakis on
419         #webkit).
420
421         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
422         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
423         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
424         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
425         * Scripts/webkitpy/layout_tests/port/base.py:
426         * Scripts/webkitpy/layout_tests/port/chromium.py:
427         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
428         * Scripts/webkitpy/layout_tests/port/test.py:
429         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
430         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
431         * Scripts/webkitpy/style/checkers/test_expectations.py:
432         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
433
434 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
435
436         Reviewed by Darin Adler.
437
438         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
439         https://bugs.webkit.org/show_bug.cgi?id=52307
440
441         * Scripts/old-run-webkit-tests:
442
443 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
444
445         Reviewed by Martin Robinson.
446
447         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
448         https://bugs.webkit.org/show_bug.cgi?id=50867
449
450         Fixed library extention for Mac in webkitdirs.pm and type conflict in
451         TestNetscapePlugin.cpp 
452
453         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
454         * Scripts/webkitdirs.pm:
455
456 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
457
458         Reviewed by Pavel Feldman.
459
460         Add check-inspector-strings script.
461
462         https://bugs.webkit.org/show_bug.cgi?id=52295
463
464         * Scripts/check-inspector-strings: Added.
465
466 2011-01-12  Adam Roben  <aroben@apple.com>
467
468         Advertise the .testnetscape file extension on Windows
469
470         Fixes <http://webkit.org/b/52298>
471         plugins/no-mime-with-valid-extension.html fails on Windows
472
473         Reviewed by Dan Bernstein.
474
475         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
476         FileExtents field to map the .testnetscape file extension to the
477         application/x-webkit-test-netscape MIME type, just as we do on Mac.
478
479 2011-01-12  Adam Barth  <abarth@webkit.org>
480
481         Reviewed by Eric Seidel.
482
483         Make webkit-patch support subdirectories for SVN checkouts
484         https://bugs.webkit.org/show_bug.cgi?id=52261
485
486         os.relpath does not exist on Python 2.5, so we need to call our version
487         of the API.
488
489         * Scripts/webkitpy/common/checkout/scm.py:
490
491 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
492
493         Reviewed by Eric Seidel.
494
495         Close additional pages opened during a test once the test completes.
496         https://bugs.webkit.org/show_bug.cgi?id=52276
497
498         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
499         (WTR::InjectedBundle::done):
500
501 2011-01-11  David Levin  <levin@chromium.org>
502
503         Reviewed by Eric Seidel.
504
505         Errors should be separated from the command line in bot messages.
506         https://bugs.webkit.org/show_bug.cgi?id=52275
507
508         * Scripts/webkitpy/common/system/executive.py:
509         (ScriptError.message_with_output): Added a newline to separate the command
510         line from the errors.
511         * Scripts/webkitpy/common/system/executive_unittest.py:
512         (ScriptErrorTest.test_message_with_output): Added tests for the various code
513         paths in message_with_output.
514
515 2011-01-11  Eric Seidel  <eric@webkit.org>
516
517         Unreviewed.
518
519         commit-queue should know how to upload archived results (for test flakes or general failures)
520         https://bugs.webkit.org/show_bug.cgi?id=52048
521
522         The zips are mostly empty due to forgetting -r.
523         Expected diffs were not being pulled from the archive due
524         to the archive having longer paths than I realized.
525
526         * Scripts/webkitpy/common/system/workspace.py:
527         * Scripts/webkitpy/common/system/workspace_unittest.py:
528         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
529         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
530
531 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
532
533         Reviewed by Ojan Vafai.
534
535         The current modifier parsing code in test_expectations is
536         fragile and hard-coded, so it's not easy to understand the logic
537         or easily add new types of modifiers (like GPU vs. CPU testing
538         for graphics tests, or 32-bit vs. 64-bit differences).
539
540         This is the first of two patches that will add in more generic
541         support and then eliminate the GPU-specific test expectations
542         files for Chromium.
543
544         This patch adds two standalone objects for handling modifiers. The
545         rules for interpreting modifiers, precedence, and conflicts are
546         given in the docstring to the ModifierMatcher class, which
547         returns ModifierMatchResult objects.
548         
549         This patch also adds routines to the Port interface and a
550         default set of values in the base object, in order to obtain the
551         values needed on a given test run. These values are then passed
552         to the expectation parser. This also allows us to clean up the
553         logic used to lint all of the different configurations in a
554         single test_expectations.txt file.
555
556         The next patch will merge in the separate GPU expectations file.
557
558         https://bugs.webkit.org/show_bug.cgi?id=51222
559
560         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
561         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
562         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
563         * Scripts/webkitpy/layout_tests/port/base.py:
564         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
565         * Scripts/webkitpy/layout_tests/port/chromium.py:
566         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
567         * Scripts/webkitpy/layout_tests/port/test.py:
568         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
569         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
570
571 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
572
573         Reviewed by Adam Barth.
574
575         Make webkit-patch support subdirectories for SVN checkouts
576         https://bugs.webkit.org/show_bug.cgi?id=52261
577
578         * Scripts/webkitpy/common/checkout/scm.py:
579         * Scripts/webkitpy/style_references.py:
580         * Scripts/webkitpy/tool/main.py:
581         * Scripts/webkitpy/tool/steps/preparechangelog.py:
582
583 2011-01-11  Eric Seidel  <eric@webkit.org>
584
585         Unreviewed.
586
587         commit-queue should know how to upload archived results (for test flakes or general failures)
588         https://bugs.webkit.org/show_bug.cgi?id=52048
589
590         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
591         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
592
593         * Scripts/webkitpy/common/system/workspace.py:
594         * Scripts/webkitpy/common/system/workspace_unittest.py:
595         * Scripts/webkitpy/tool/commands/queues.py:
596
597 2011-01-11  Sam Weinig  <sam@webkit.org>
598
599         Roll r75474 back in.
600
601 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
602
603         Reviewed by Kenneth Rohde Christiansen.
604
605         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
606         https://bugs.webkit.org/show_bug.cgi?id=51204
607
608         * QtTestBrowser/webpage.h:
609         (QtNAMThread::QtNAMThread):
610         (QtNAMThread::networkAccessManager):
611         (QtNAMThread::run):
612
613 2011-01-11  Peter Varga  <pvarga@webkit.org>
614
615         Unreviewed.
616
617         Add myself to committers' list.
618
619         * Scripts/webkitpy/common/config/committers.py:
620
621 2011-01-11  Eric Seidel  <eric@webkit.org>
622
623         Reviewed by Adam Barth.
624
625         commit-queue should know how to upload archived results (for test flakes or general failures)
626         https://bugs.webkit.org/show_bug.cgi?id=52048
627
628         Now the queue will always upload results.  Either the entire zip, or just
629         the diffs.txt in the case of text failures.
630
631         This should make understanding flakes much easier, and paves the way
632         for having the EWS run layout tests (and upload failures).
633
634         In order to upload .zip files I had to teach bugzilla.py to autodetect
635         mime types from the filename.  Since mimetypes.py doesn't include a mapping
636         for .patch files, I have it add one before calling guess_type.
637
638         We may find that always uploading the whole zip instead of just the -diffs.txt
639         file is preferable, but for now I'm keeping the old behavior because it makes
640         quickly understanding text failures easy.
641
642         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
643         * Scripts/webkitpy/common/system/workspace.py: Added.
644         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
645         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
646         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
647         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
648         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
649         * Scripts/webkitpy/tool/commands/queues.py:
650         * Scripts/webkitpy/tool/commands/queues_unittest.py:
651
652 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
653
654         Unreviewed, rolling out r75464.
655         http://trac.webkit.org/changeset/75464
656         https://bugs.webkit.org/show_bug.cgi?id=52193
657
658         Followup rollout for 75474 (Requested by Ossy on #webkit).
659
660         * MiniBrowser/mac/BrowserWindowController.m:
661         (-[BrowserWindowController awakeFromNib]):
662         * MiniBrowser/win/BrowserView.cpp:
663         (BrowserView::create):
664         * WebKitTestRunner/TestController.cpp:
665         (WTR::createOtherPage):
666         (WTR::TestController::initialize):
667
668 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
669
670         Reviewed by Csaba Osztrogonác.
671
672         [Qt] Baseline qt_minimal configuration
673         https://bugs.webkit.org/show_bug.cgi?id=51313
674
675         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
676         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
677         QT_NO_UNDOSTACK guard.
678
679         * QtTestBrowser/launcherwindow.cpp:
680         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
681         guards.
682         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
683         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
684         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
685         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
686
687         * QtTestBrowser/launcherwindow.h:
688         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
689         * QtTestBrowser/locationedit.h: Ditto.
690
691         * QtTestBrowser/mainwindow.cpp:
692         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
693         QT_NO_UNDOSTACK guards.
694         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
695         (MainWindow::changeLocation): Ditto.
696         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
697         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
698
699         * QtTestBrowser/webpage.cpp:
700         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
701         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
702
703         * QtTestBrowser/webview.cpp:
704         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
705         (WebViewGraphicsBased::animatedYFlip): Ditto.
706
707 2011-01-10  Sam Weinig  <sam@webkit.org>
708
709         Fix build.
710
711         * MiniBrowser/mac/BrowserWindowController.m:
712         (-[BrowserWindowController awakeFromNib]):
713         * MiniBrowser/win/BrowserView.cpp:
714         (BrowserView::create):
715         * WebKitTestRunner/TestController.cpp:
716         (WTR::createOtherPage):
717         (WTR::TestController::initialize):
718
719 2011-01-10  Eric Seidel  <eric@webkit.org>
720
721         Reviewed by Ojan Vafai.
722
723         style-queue messages are way too long for big patches
724         https://bugs.webkit.org/show_bug.cgi?id=52161
725
726         We definitely could build much fancier list-to-string-with-limit functions
727         but this should be sufficient for our needs at the moment.
728
729         * Scripts/webkitpy/common/system/executive.py:
730         * Scripts/webkitpy/common/system/executive_unittest.py:
731
732 2011-01-10  Tony Chang  <tony@chromium.org>
733
734         Unreviewed, rolling out r75398.
735         http://trac.webkit.org/changeset/75398
736         https://bugs.webkit.org/show_bug.cgi?id=52008
737
738         Some layout tests are crashing on Chromium Win.
739
740         * DumpRenderTree/chromium/WebViewHost.cpp:
741         (WebViewHost::updatePaintRect):
742         * DumpRenderTree/chromium/WebViewHost.h:
743
744 2011-01-10  Adam Roben  <aroben@apple.com>
745
746         Roll out r75392
747
748         It isn't needed now that r75289 has been rolled out.
749
750         * Scripts/run-javascriptcore-tests:
751
752 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
753
754         Reviewed by Anders Carlsson.
755
756         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
757         https://bugs.webkit.org/show_bug.cgi?id=52160
758
759         * WebKitTestRunner/mac/TestControllerMac.mm:
760         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
761         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
762         anyway.
763
764 2011-01-10  Tony Chang  <tony@chromium.org>
765
766         Reviewed by Mihai Parparita.
767
768         [chromium] fix for animated gif layout tests
769         https://bugs.webkit.org/show_bug.cgi?id=52008
770
771         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
772             to trigger gif animations.
773         (WebViewHostPaintTask::WebViewHostPaintTask):
774         (WebViewHostPaintTask::runIfValid):
775         (WebViewHost::updatePaintRect):
776         * DumpRenderTree/chromium/WebViewHost.h:
777         (WebViewHost::taskList):
778
779 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
780
781         Reviewed by Xan Lopez.
782
783         [GTK] Fix gtk2 compilation for master
784         https://bugs.webkit.org/show_bug.cgi?id=51885
785
786         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
787         (createBitmapContextFromWebView): Replaced the old
788         gdk_drawable_get_size with gdk_pixmap_get_size.
789
790 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
791
792         Reviewed by Laszlo Gombos.
793
794         [WINCE] Reenable NPAPI after r75203
795         https://bugs.webkit.org/show_bug.cgi?id=52109
796
797         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
798         it with !isEfl(), because EFL port does not support NPAPI (yet).
799
800         * Scripts/build-webkit:
801
802 2011-01-10  Adam Roben  <aroben@apple.com>
803
804         Skip some asserting JS tests
805
806         See <http://webkit.org/b/52156>.
807
808         * Scripts/run-javascriptcore-tests:
809
810 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
811
812         Reviewed by Xan Lopez.
813
814         [GTK] build-webkit disable Blob support via arguments passed to automake
815         https://bugs.webkit.org/show_bug.cgi?id=52097
816
817         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
818         build-webkit.
819
820 2011-01-10  Adam Roben  <aroben@apple.com>
821
822         Use the same name and description for TestNetscapePlugin on Windows and
823         Mac
824
825         Fixes <http://webkit.org/b/52151>
826         fast/frames/iframe-reparenting-plugins.html fails on Windows
827
828         Reviewed by Steve Falkenburg.
829
830         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
831         the name and description from Mac's Info.plist.
832
833 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
834
835         Reviewed by Laszlo Gombos.
836
837         [Qt][WK2] Guard gcc-specific syntax
838
839         Non-gcc based compliers choke on the "-include"
840         syntax for preinclude, place guard around it.
841
842         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
843         * WebKitTestRunner/qt/WebKitTestRunner.pro:
844
845 2011-01-10  Andreas Kling  <kling@webkit.org>
846
847         Reviewed by Simon Hausmann.
848
849         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
850         https://bugs.webkit.org/show_bug.cgi?id=52111
851
852         When getting a createNewPage() callback from QWKPage, create the
853         new page with the same QWKContext as the page that is passed to
854         the callback.
855
856         * MiniBrowser/qt/BrowserView.h:
857         * MiniBrowser/qt/BrowserWindow.cpp:
858         (newPageFunction):
859         (BrowserWindow::BrowserWindow):
860         * MiniBrowser/qt/BrowserWindow.h:
861
862 2011-01-10  Andreas Kling  <kling@webkit.org>
863
864         Reviewed by Kenneth Rohde Christiansen.
865
866         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
867
868         BrowserView set its own useless createNewPage() callback on QWKPage.
869         This was immediately overridden by BrowserWindow anyway, so remove
870         the BrowserView one.
871
872         * MiniBrowser/qt/BrowserView.cpp:
873         (BrowserView::BrowserView):
874
875 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
876
877         Reviewed by Jeremy Orlow.
878
879         [Chromium] Remove non-client-based Geolocation code
880         https://bugs.webkit.org/show_bug.cgi?id=50921
881
882         * DumpRenderTree/chromium/LayoutTestController.cpp:
883         (LayoutTestController::setGeolocationPermission):
884         (LayoutTestController::setMockGeolocationPosition):
885         (LayoutTestController::setMockGeolocationError):
886         * DumpRenderTree/chromium/WebViewHost.cpp:
887         (WebViewHost::geolocationClientMock):
888         (WebViewHost::reset):
889         * DumpRenderTree/chromium/WebViewHost.h:
890
891 2011-01-10  Eric Seidel  <eric@webkit.org>
892
893         Reviewed by Adam Barth.
894
895         Commit bot tried to land r? cq+ patch
896         https://bugs.webkit.org/show_bug.cgi?id=36638
897
898         It should now be possible to post a patch with r? and cq+ and the
899         commit-queue will correctly wait for the r+ before attempting to land the patch.
900         (This was a feature requested by several users.)
901
902         One caveat: We don't actually reject r-, cq+ patches from the queue
903         (we just ignore them), but I think that's OK for now.
904
905         I also noticed that setting r- once a commit-queue node had grabbed
906         a patch would not properly cancel the landing.  That's fixed and
907         tested in this patch.
908
909         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
910         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
911         * Scripts/webkitpy/tool/bot/feeders.py:
912         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
913
914 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
915
916         Reviewed by Kenneth Rohde Christiansen.
917
918         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
919         https://bugs.webkit.org/show_bug.cgi?id=51934
920
921         When accessing the network from the destructor of QWebPage, the network access manager
922         was already deleted because the object WebPage was already destructed.
923
924         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
925         The object is now destructed in the destructor of QObject.
926
927         * QtTestBrowser/webpage.cpp:
928         (WebPage::WebPage):
929         (WebPage::setQnamThreaded):
930         * QtTestBrowser/webpage.h:
931         (QtNAMThread::QtNAMThread):
932
933 2011-01-08  Eric Seidel  <eric@webkit.org>
934
935         Reviewed by Ojan Vafai.
936
937         test_failures.py should not mention TestShell (long live DumpRenderTree!)
938         https://bugs.webkit.org/show_bug.cgi?id=52067
939
940         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
941         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
942
943         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
944
945 2011-01-08  Eric Seidel  <eric@webkit.org>
946
947         Reviewed by Mihai Parparita.
948
949         commit-queue hangs when the ChangeLog diff is bad
950         https://bugs.webkit.org/show_bug.cgi?id=52072
951
952         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
953         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
954
955 2011-01-08  Adam Barth  <abarth@webkit.org>
956
957         Teach svn-apply how to re-write WebCore to Source/WebCore.
958
959         * Scripts/VCSUtils.pm:
960
961 2011-01-07  Adam Barth  <abarth@webkit.org>
962
963         Rubber-stamped by Eric Seidel.
964
965         Move WebCore to Source
966         https://bugs.webkit.org/show_bug.cgi?id=52050
967
968         Update the tools to understand WebCore's new location.
969
970         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
971         * DumpRenderTree/wscript:
972         * GNUmakefile.am:
973         * Scripts/build-webkit:
974         * Scripts/do-file-rename:
975         * Scripts/do-webcore-rename:
976         * Scripts/generate-qt-inspector-resource:
977         * Scripts/prepare-ChangeLog:
978         * Scripts/run-bindings-tests:
979         * Scripts/update-iexploder-cssproperties:
980         * Scripts/update-sources-list.py:
981         * Scripts/update-webkit-localizable-strings:
982         * Scripts/webkitdirs.pm:
983         * Scripts/webkitpy/common/config/build.py:
984         * Scripts/webkitpy/common/config/build_unittest.py:
985         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
986         * Scripts/webkitpy/style/checker.py:
987         * Scripts/webkitpy/style/checker_unittest.py:
988         * WebKitTestRunner/DerivedSources.pro:
989         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
990         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
991         * wx/browser/wscript:
992         * wx/build/settings.py:
993
994 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
995
996         Reviewed by Sam Weinig.
997
998         Make WebKitTestRunner rest between loads more robust to avoid test crashes
999         https://bugs.webkit.org/show_bug.cgi?id=52086
1000
1001         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1002         (WTR::InjectedBundle::didReceiveMessage):
1003         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1004         (WTR::LayoutTestController::notifyDone):
1005         * WebKitTestRunner/TestController.cpp:
1006         (WTR::TestController::resetStateToConsistentValues):
1007         (WTR::TestController::run):
1008
1009 2011-01-07  James Robinson  <jamesr@chromium.org>
1010
1011         Revert "Implement mozilla's animationTime property"
1012         https://bugs.webkit.org/show_bug.cgi?id=51952
1013
1014         This approach isn't quite right.
1015
1016         * DumpRenderTree/chromium/WebViewHost.cpp:
1017         (WebViewHost::paintInvalidatedRegion):
1018
1019 2011-01-07  Adam Roben  <aroben@apple.com>
1020
1021         Build master fix
1022
1023         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1024         (RunWebKitTests.start): Don't try to concatenate a list and a string.
1025
1026 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
1027
1028         Reviewed by Csaba Osztrogonác.
1029
1030         run-qtwebkit-tests should be able to kill a testsuite.
1031
1032         Add new option in the script that can setup a timeout for a test.
1033         If the test execution takes more then specified time then the test
1034         would be terminated.
1035
1036         [Qt] run-qtwebkit-tests needs timeout
1037         https://bugs.webkit.org/show_bug.cgi?id=51894
1038
1039         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1040         * Scripts/run-qtwebkit-tests:
1041
1042 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
1043
1044         Unreviewed fix after r75233.
1045
1046         Based on idea from Eric Seidel.
1047
1048         Add remote zip file handling to webkitpy.
1049         https://bugs.webkit.org/show_bug.cgi?id=50901
1050
1051         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
1052
1053 2011-01-07  Shane Stephens  <shanestephens@google.com>
1054
1055         Reviewed by Eric Seidel.
1056
1057         svn-apply: should support git binary delta diffs
1058         https://bugs.webkit.org/show_bug.cgi?id=38864
1059
1060         * Scripts/VCSUtils.pm:
1061         * Scripts/svn-apply:
1062
1063 2011-01-06  Julie Parent  <jparent@chromium.org>
1064
1065         Reviewed by Eric Seidel.
1066
1067         Test Result Server not removing old results.
1068         https://bugs.webkit.org/show_bug.cgi?id=52012
1069
1070         * TestResultServer/model/jsonresults.py:
1071         Fix off-by-one: Truncate if >= num_runs, not just >.
1072         * TestResultServer/model/jsonresults_unittest.py:
1073         Add unit test to test that merging in a new result with the same value
1074         as the last result causes previous result to fall off.
1075
1076 2011-01-06  James Kozianski  <koz@chromium.org>
1077
1078         Reviewed by Mihai Parparita.
1079
1080         Add classes to provide a consistent interface to a set of files.
1081         https://bugs.webkit.org/show_bug.cgi?id=50901
1082
1083         These classes allow us to write code that is agnostic to whether a
1084         particular set of files resides in a local directory or in a zip file
1085         on a remote machine.
1086
1087         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
1088         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
1089         * Scripts/webkitpy/common/system/fileset.py: Added.
1090         * Scripts/webkitpy/common/system/filesystem.py:
1091         * Scripts/webkitpy/common/system/filesystem_mock.py:
1092         * Scripts/webkitpy/common/system/zipfileset.py: Added.
1093         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
1094
1095 2011-01-06  Eric Seidel  <eric@webkit.org>
1096
1097         Reviewed by Adam Barth.
1098
1099         NetworkTransaction should log the url it is retrying
1100         https://bugs.webkit.org/show_bug.cgi?id=52043
1101
1102         * Scripts/webkitpy/common/net/networktransaction.py:
1103         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
1104
1105 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1106
1107         Windows build fix.
1108         Import os before using it.
1109
1110         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1111
1112 2011-01-06  Eric Seidel  <eric@webkit.org>
1113
1114         Reviewed by Adam Barth.
1115
1116         StyleQueue fails to report errors when patches have many files
1117         https://bugs.webkit.org/show_bug.cgi?id=52042
1118
1119         This is one of at least two errors preventing style error reporting at the moment.
1120         When we moved to passing the list of files to check explicitly,
1121         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
1122         We could change the type of the QueueStatus.message type, or we could
1123         just teach statusserver.py how to clamp values (and warn when it does).
1124         I chose the latter path.
1125
1126         * Scripts/webkitpy/common/net/statusserver.py:
1127
1128 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1129
1130         Reviewed by Stephanie Lewis.
1131         
1132         Fix syntax error in script.
1133
1134         Windows bots need to archive/unarchive builds to/from configuration-specific directories
1135         https://bugs.webkit.org/show_bug.cgi?id=51996
1136
1137         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1138
1139 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1140
1141         Unreviewed, fixing WinCE build after r75196.
1142
1143         WinCE port does not (yet) support NPAPI.
1144
1145         * Scripts/build-webkit:
1146
1147 2011-01-06  Xan Lopez  <xlopez@igalia.com>
1148
1149         Reviewed by Darin Adler.
1150
1151         File::Spec->rel2abs in sunspider-compare-results mangles parameters
1152         https://bugs.webkit.org/show_bug.cgi?id=52015
1153
1154         * Scripts/sunspider-compare-results: call rel2abs on our arguments
1155         after the platform has been detected, otherwise the script will
1156         mangle things like '--gtk' into '/a/path/--gtk', breaking the
1157         detection.
1158
1159 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1160
1161         Reviewed by Eric Seidel.
1162
1163         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
1164         https://bugs.webkit.org/show_bug.cgi?id=51346
1165
1166         * Scripts/build-webkit:
1167
1168 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1169
1170         Reviewed by Adam Roben.
1171
1172         Windows bots need to archive/unarchive builds to/from configuration-specific directories
1173         https://bugs.webkit.org/show_bug.cgi?id=51996
1174         
1175         After the configuration directory change, we were archiving the incorrect directory for
1176         build product, so we were running tests on the wrong binaries.
1177         
1178         This change archives the correct directory, and also unarchives it into a configuration-
1179         specific directory.
1180
1181         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
1182         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
1183
1184 2011-01-06  Eric Seidel  <eric@webkit.org>
1185
1186         Reviewed by Mihai Parparita.
1187
1188         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
1189         https://bugs.webkit.org/show_bug.cgi?id=52002
1190
1191         See an example of this here:
1192         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
1193
1194         It's due to the fact that we pass around TestFailure() instance
1195         objects and yet expect them to all compare to be the same.
1196
1197         This is bad.  We should either have shared instances of these values
1198         or we should just pass around the class names.  There are already hacks
1199         in place to make TestFailure objects pass equality tests, I just added
1200         a __hash__ implementation so they can be used in sets as expected.
1201
1202         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1203         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1204
1205 2011-01-06  Evan Martin  <evan@chromium.org>
1206
1207         Reviewed by Tony Chang.
1208
1209         [gdb] handle inaccessible memory and UChar*
1210         https://bugs.webkit.org/show_bug.cgi?id=52003
1211
1212         To pretty-print a UChar*, we just grope around in the memory
1213         looking for a terminating NUL.  We need to handle the exception
1214         that can occur when we poke into an invalid location.
1215
1216         Additionally, the logic for choosing which pretty-printer would
1217         early return before hitting the point where we'd use the UChar*
1218         printer.  (Did this ever work?  How did it regress?)
1219
1220         * gdb/webkit.py:
1221
1222 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
1223
1224         Reviewed by Ada Chan.
1225
1226         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
1227         https://bugs.webkit.org/show_bug.cgi?id=51969
1228         
1229         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
1230
1231         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1232         (WTR::InjectedBundlePage::InjectedBundlePage):
1233         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
1234         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1235
1236 2011-01-06  James Robinson  <jamesr@chromium.org>
1237
1238         Reviewed by Simon Fraser.
1239
1240         Implement mozilla's animationTime property
1241         https://bugs.webkit.org/show_bug.cgi?id=51952
1242
1243         Chromium DRT support for webkitAnimationTime.
1244
1245         * DumpRenderTree/chromium/WebViewHost.cpp:
1246         (WebViewHost::paintInvalidatedRegion):
1247
1248 2011-01-06  Julie Parent  <jparent@chromium.org>
1249
1250         Reviewed by Tony Chang.
1251
1252         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
1253         https://bugs.webkit.org/show_bug.cgi?id=51217
1254
1255         * TestResultServer/model/jsonresults.py:
1256         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
1257         Adds missing documentation.
1258         * TestResultServer/model/jsonresults_unittest.py:
1259         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
1260         Update test_merge to take a number of builds to truncate at.
1261
1262 2011-01-06  Adam Barth  <abarth@webkit.org>
1263
1264         Reviewed by Eric Seidel.
1265
1266         The EWS should log outside of the working directory
1267         https://bugs.webkit.org/show_bug.cgi?id=51986
1268
1269         This patch prepare us for using git clean -x -d -f in the EWS wrapper
1270         script, which will actually clean the working copy back to a pristine
1271         state instead of leaving untracked directories and ignored files.
1272
1273         * Scripts/webkitpy/tool/commands/queues.py:
1274         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1275
1276 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1277
1278         Windows build fix.
1279         Back out attempted change to built-product-archive.
1280
1281         * BuildSlaveSupport/built-product-archive:
1282
1283 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1284
1285         Windows build fix.
1286         Include configuration name when unpacking a build archive.
1287
1288         Needed, since we split Windows build results into configuration-specific directories
1289         under WebKitOutputDir.
1290
1291         * BuildSlaveSupport/built-product-archive:
1292
1293 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1294
1295         Reviewed by Darin Adler.
1296
1297         Debug and Release builds on Windows clobber each other
1298         https://bugs.webkit.org/show_bug.cgi?id=49185
1299
1300         Changes the structure of WebKitBuild build products directory so we
1301         completely separate each build configuration into independent directories.
1302         
1303         Although we previously had per-configuration directories for obj, this change adds
1304         per-configuration directories for bin, lib, obj, and include. Each configuration's
1305         build products are stored within a directory inside of WebKitBuild.
1306         
1307         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
1308         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
1309
1310         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
1311         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
1312         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
1313         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
1314         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
1315         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
1316         * DumpRenderTree/win/ImageDiffCommon.vsprops:
1317         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
1318         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
1319         * FindSafari/FindSafari.vcproj:
1320         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
1321         * MiniBrowser/MiniBrowserPostBuild.cmd:
1322         * MiniBrowser/MiniBrowserPreBuild.cmd:
1323         * Scripts/webkitdirs.pm:
1324         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
1325         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
1326         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
1327         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
1328         * TestWebKitAPI/win/copy-resources.cmd:
1329         * WebKitAPITest/WebKitAPITestCommon.vsprops:
1330         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
1331         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
1332         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
1333         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
1334         * WebKitTestRunner/win/InjectedBundle.vcproj:
1335         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
1336         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
1337         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
1338         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
1339         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
1340         * WinLauncher/WinLauncherCommon.vsprops:
1341         * WinLauncher/WinLauncherPostBuild.cmd:
1342         * WinLauncher/WinLauncherPreBuild.cmd:
1343
1344 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
1345
1346         Reviewed by Ariya Hidayat.
1347
1348         [Qt] TestNetscapePlugin doesn't link on OS X
1349         https://bugs.webkit.org/show_bug.cgi?id=51948
1350
1351         Only add a dependency on libX11 on X11 systems
1352
1353         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1354
1355 2011-01-05  Jeff Miller  <jeffm@apple.com>
1356
1357         Reviewed by Adam Roben.
1358
1359         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
1360         https://bugs.webkit.org/show_bug.cgi?id=51970
1361
1362         * Scripts/webkitpy/style/checker.py:
1363         Add -readability/naming for WebKit2 C API directories.
1364
1365 2011-01-05  Eric Seidel  <eric@webkit.org>
1366
1367         Unreviewed, just fixing one more log error from my previous python patch.
1368
1369         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1370         https://bugs.webkit.org/show_bug.cgi?id=51802
1371
1372         webkit-patch failure-reason was logging about parsing errors
1373         due to my misunderstanding of how BeautifulSoup.findAll worked.
1374
1375         Fixed, and added a unit test.
1376
1377         * Scripts/webkitpy/common/net/layouttestresults.py:
1378         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1379
1380 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
1381
1382         Reviewed by Kenneth Rohde Christiansen.
1383
1384         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
1385         https://bugs.webkit.org/show_bug.cgi?id=51951
1386
1387         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
1388         to create new window from WebKit.
1389
1390         * MiniBrowser/qt/BrowserWindow.cpp:
1391         (newPageFunction):
1392         (BrowserWindow::BrowserWindow):
1393         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
1394         (BrowserWindow::newWindow):
1395         (BrowserWindow::updateUserAgentList):
1396         (BrowserWindow::showUserAgentDialog):
1397         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
1398         define the type of the backing store used for new windows.
1399         * MiniBrowser/qt/main.cpp:
1400         (main):
1401
1402 2011-01-05  Eric Seidel  <eric@webkit.org>
1403
1404         Reviewed by Ojan Vafai.
1405
1406         commit-queue should report failure type when reporting flaky tests
1407         https://bugs.webkit.org/show_bug.cgi?id=51900
1408
1409         This patch was a ridiculous amount of plumbing.  In the end I like
1410         the NRWT-style TestResult class even less.  But now we're passing
1411         a list of TestResult objects from the queue to the FlakyTestReporter.
1412         Thus the FlakyTestReporter can more easily report what type of failure
1413         occurred.
1414
1415         In the process, I found that I was not alone in finding TestResult
1416         cumbersome to use.  A bunch of code was trying to create a TestResult
1417         object with default values.  However since the constructor didn't make
1418         this easy, some places were getting it wrong (including the TestResult unit test)!
1419         I've fixed the TestResult constructor to have default values for non-essential
1420         arguments.
1421
1422         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1423         * Scripts/webkitpy/common/net/layouttestresults.py:
1424         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1425         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1426         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1427         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1428         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
1429         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
1430         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1431         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1432         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1433         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1434         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1435         * Scripts/webkitpy/tool/commands/queues.py:
1436         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1437
1438 2011-01-05  Eric Seidel  <eric@webkit.org>
1439
1440         Unreviewed.
1441
1442         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1443         https://bugs.webkit.org/show_bug.cgi?id=51802
1444
1445         Add another unit test to cover a previously missing import.
1446
1447         * Scripts/webkitpy/common/net/layouttestresults.py:
1448         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1449
1450 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
1451
1452         Reviewed by David Levin.
1453
1454         Add mihaip@chromium.org as a reviewer
1455         https://bugs.webkit.org/show_bug.cgi?id=51966
1456         
1457         Add myself as a reviewer.
1458
1459         * Scripts/webkitpy/common/config/committers.py:
1460
1461 2011-01-05  James Simonsen  <simonjam@chromium.org>
1462
1463         Unreviewed. Adding myself to the list of committers.
1464
1465         * Scripts/webkitpy/common/config/committers.py:
1466
1467 2011-01-05  Eric Seidel  <eric@webkit.org>
1468
1469         Unreviewed.
1470
1471         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1472         https://bugs.webkit.org/show_bug.cgi?id=51802
1473
1474         Fix two exceptions seen on the bots after my original commit.
1475
1476         * Scripts/webkitpy/common/net/layouttestresults.py:
1477         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1478
1479 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
1480
1481         Reviewed by Andreas Kling.
1482
1483         [Qt]Add local storage settings to QtTestBrowser command line arguments 
1484         https://bugs.webkit.org/show_bug.cgi?id=51750
1485
1486         * QtTestBrowser/main.cpp:
1487         (LauncherApplication::handleUserOptions):
1488          Local storage settings can be enable form command line arguments for
1489          QtTestBrowser.
1490
1491 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
1492
1493         Reviewed by Martin Robinson.
1494
1495         GTK: AX: DRT needs to use correct root object method.
1496         https://bugs.webkit.org/show_bug.cgi?id=51911
1497
1498         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1499         (AccessibilityController::rootElement):
1500
1501 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1502
1503         Rubber-stamped by Csaba Osztrogonác.
1504
1505         Based on idea from Péter Gál.
1506
1507         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
1508
1509 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1510
1511         Reviewed by Adam Barth.
1512
1513         sheriff-bot should be able to do multi-revision rollouts
1514         https://bugs.webkit.org/show_bug.cgi?id=51176
1515
1516         * Scripts/webkitpy/tool/bot/irc_command.py:
1517         * Scripts/webkitpy/tool/bot/sheriff.py:
1518         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1519
1520 2011-01-05  Eric Seidel  <eric@webkit.org>
1521
1522         Reviewed by Adam Barth.
1523
1524         queues.webkit.org should have per-bot status pages
1525         https://bugs.webkit.org/show_bug.cgi?id=51906
1526
1527         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
1528         statuses from a single queue.  Now that we have many bots servicing
1529         some queues (commit-queue, win-ews, etc.) its easy to have the messages
1530         you care about scroll off the end of the 15-message limit on the main page.
1531
1532         Eventually we should probably rename /queue-status to /queue or /queues,
1533         but that's fodder for another patch.
1534
1535         * QueueStatusServer/handlers/queuestatus.py:
1536         * QueueStatusServer/index.yaml:
1537         * QueueStatusServer/main.py:
1538         * QueueStatusServer/templates/includes/singlequeuestatus.html:
1539          - This probably should use a custom filter instead of hard-coding
1540            the URL scheme here, but I couldn't figure out how to easily
1541            create such a filter.  Most filters work with "strings" so we can't
1542            pass the status object.  We could add a method to the status
1543            object and call that, but that seemed a bit strange too.
1544         * QueueStatusServer/templates/queuestatus.html:
1545
1546 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1547
1548         Unreviewed. Adding myself to the list of committers.
1549
1550         * Scripts/webkitpy/common/config/committers.py:
1551
1552 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
1553
1554         Reviewed by David Levin.
1555
1556         check-webkit-style treated some macros with parentheses after #elif as function calls
1557         https://bugs.webkit.org/show_bug.cgi?id=51695
1558
1559         Ingore function call space checking in any preprocessor directives
1560         (things starting with #). Change search() to match() because 
1561         preprocessor directives are supposed to be in the beginning of lines.
1562
1563         * Scripts/webkitpy/style/checkers/cpp.py:
1564         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
1565
1566 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
1567
1568         Reviewed by Tony Chang.
1569
1570         Change the --multi-load test option to --stress-opt
1571         https://bugs.webkit.org/show_bug.cgi?id=50751
1572
1573         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1574         (runTest):
1575         (main):
1576         * DumpRenderTree/chromium/TestShell.cpp:
1577         (TestShell::TestShell):
1578         * DumpRenderTree/chromium/TestShell.h:
1579         (TestShell::stressOpt):
1580         (TestShell::setStressOpt):
1581         (TestShell::stressDeopt):
1582         (TestShell::setStressDeopt):
1583         (TestShell::javaScriptFlags):
1584         (TestShell::setJavaScriptFlags):
1585         * Scripts/webkitpy/layout_tests/port/chromium.py:
1586         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1587
1588 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
1589
1590         Reviewed by Sam Weinig.
1591
1592         WK2: Support Accessibility
1593         https://bugs.webkit.org/show_bug.cgi?id=51859
1594
1595         Use rootObject() method to get top of accessibility tree.
1596
1597         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1598         (AccessibilityController::focusedElement):
1599         (AccessibilityController::rootElement):
1600
1601 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
1602
1603         Reviewed by Darin Adler.
1604
1605         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
1606         https://bugs.webkit.org/show_bug.cgi?id=51846
1607
1608         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
1609         back to GRefPtr.
1610
1611 2011-01-04  Zhe Su  <suzhe@chromium.org>
1612
1613         Reviewed by Kenneth Russell.
1614
1615         Fix insertText, setMarkedText and unmarkText methods of
1616         TextInputController to call corresponding methods of WebKit::WebView
1617         rather than WebKit::WebFrame. This change matches the behavior of
1618         chromium browser.
1619         insertText corresponds to WebView::confirmComposition(text)
1620         setMarkedText corresponds to WebView::setComposition(...)
1621         unmarkText corresponds to WebView::confirmComposition()
1622         https://bugs.webkit.org/show_bug.cgi?id=51693
1623
1624         * DumpRenderTree/chromium/TextInputController.cpp:
1625         (TextInputController::insertText):
1626         (TextInputController::setMarkedText):
1627         (TextInputController::unmarkText):
1628
1629 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
1630
1631         Reviewed by Laszlo Gombos.
1632
1633         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
1634
1635         On Symbian productDir points to the source directory. Removing all the
1636         empty files from the productDir directory corrupts the svn repository.
1637
1638         * Scripts/build-webkit:
1639
1640 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
1641
1642         Reviewed by Adam Barth.
1643
1644         [Qt] Add SelectAll option to the context menu for the editor
1645         https://bugs.webkit.org/show_bug.cgi?id=50049
1646
1647         Set shortcut for the SelectAll action.
1648
1649         * QtTestBrowser/mainwindow.cpp:
1650         (MainWindow::buildUI):
1651
1652 2011-01-03  David Levin  <levin@chromium.org>
1653
1654         Reviewed by Eric Seidel.
1655
1656         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
1657         https://bugs.webkit.org/show_bug.cgi?id=51842
1658
1659         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
1660         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
1661
1662 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
1663
1664         Reviewed by David Kilzer.
1665
1666         [WINCE] Adds a build slave.
1667         https://bugs.webkit.org/show_bug.cgi?id=50523
1668
1669         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
1670         entry for a release build of the WinCE port.
1671         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
1672         flag to build the WinCE port.
1673
1674 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
1675
1676         Reviewed by David Kilzer.
1677
1678         Add WinCE support to build-webkit
1679         https://bugs.webkit.org/show_bug.cgi?id=51642
1680
1681         * Scripts/build-webkit:
1682         * Scripts/webkitdirs.pm:
1683
1684 2011-01-03  Eric Seidel  <eric@webkit.org>
1685
1686         Reviewed by Adam Barth.
1687
1688         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1689         https://bugs.webkit.org/show_bug.cgi?id=51802
1690
1691         I'm not the biggest fan of the test_failures or test_results classes,
1692         but it's better to have one shared set of classes, than separate ones
1693         for new vs. old run-webkit-test result handling.
1694
1695         This moves the ORWT results class "LayoutTestResults" over to using
1696         TestResult and TestFailure classes, making it easy for us to
1697         make all our sheriff-bot and other webkitpy code NRWT ready.
1698
1699         This also makes it a trivial patch to generate results.json information
1700         from ORWT results.html files (for flaky test analysis, etc.) as well
1701         as making it a one-liner to report test failure types when the
1702         commit-queue sees flaky tests.
1703
1704         This patch tried not to add new functionality, but only to replace
1705         the guts of LayoutTestResults, while adding unit tests and hoping
1706         not to break anything.
1707
1708         I also moved callers which assumed User.prompt* were static/class methods
1709         to using them as instance methods (since we'll eventually want to make them such).
1710
1711         In the process of re-writing things, I broke the rebaseline command, so I wrote
1712         a unit test to catch my breakage were I do do so again in the future.
1713
1714         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1715         * Scripts/webkitpy/common/net/layouttestresults.py:
1716         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1717         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1718         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
1719         * Scripts/webkitpy/tool/commands/queries.py:
1720         * Scripts/webkitpy/tool/commands/rebaseline.py:
1721         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1722         * Scripts/webkitpy/tool/mocktool.py:
1723
1724 2011-01-03  Adam Barth  <abarth@webkit.org>
1725
1726         Reviewed by Simon Fraser.
1727
1728         webkit-patch shouldn't waste time cleaning a working directory that's already clean
1729         https://bugs.webkit.org/show_bug.cgi?id=51840
1730
1731         * Scripts/webkitpy/common/checkout/scm.py:
1732
1733 2011-01-03  Adam Barth  <abarth@webkit.org>
1734
1735         Reviewed by Simon Fraser.
1736
1737         webkit-patch should only hide update output if --quiet
1738         https://bugs.webkit.org/show_bug.cgi?id=51838
1739
1740         As requested by smfr.
1741
1742         * Scripts/webkitpy/tool/steps/update.py:
1743
1744 2011-01-03  Adam Barth  <abarth@webkit.org>
1745
1746         Reviewed by David Levin.
1747
1748         commit-queue shouldn't reject patches twice if two bots process the same patch
1749         https://bugs.webkit.org/show_bug.cgi?id=51805
1750
1751         Before raising an error, we first check whether the patch is still in
1752         the commit-queue.  This check is still racy, of course, but the time
1753         window is much smaller.
1754
1755         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1756
1757 2011-01-03  Sam Weinig  <sam@webkit.org>
1758
1759         Reviewed by Anders Carlsson.
1760
1761         Make run-api-tests less chatty.
1762         https://bugs.webkit.org/show_bug.cgi?id=51831
1763
1764         - Make script quiet by default and add --verbose option (replacing --quiet).
1765         - When not verbose, pipe stdout and stderr to devnull.
1766
1767         * Scripts/run-api-tests:
1768
1769 2011-01-03  Pratik Solanki  <psolanki@apple.com>
1770
1771         Unreviewed. Adding myself to committers.py.
1772
1773         * Scripts/webkitpy/common/config/committers.py:
1774
1775 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
1776
1777         Reviewed by Xan Lopez.
1778
1779         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
1780         https://bugs.webkit.org/show_bug.cgi?id=51806
1781
1782         Originally, the $libraryName is 'JavaScriptCore'. When building release 
1783         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
1784         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
1785         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 
1786         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
1787         so make it 'WebKitBuild/Release/.libs'
1788
1789         * Scripts/webkitdirs.pm: 
1790
1791 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
1792
1793         Reviewed by Adam Barth.
1794
1795         Make EFL a core builder
1796         https://bugs.webkit.org/show_bug.cgi?id=51804
1797
1798         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1799         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1800
1801 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
1802
1803         [Qt] Unreviewed fix after r74855 and r74875.
1804
1805         * BuildSlaveSupport/built-product-archive:
1806          - Create directories explicitly.
1807          - Pass shell=True to subprocess.call().
1808
1809 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
1810
1811         [Qt] Unreviewed fix after r74855.
1812
1813         Move JavaScriptCore to Source
1814         https://bugs.webkit.org/show_bug.cgi?id=51604
1815
1816         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
1817
1818 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
1819
1820         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
1821
1822         Move JavaScriptCore to Source
1823         https://bugs.webkit.org/show_bug.cgi?id=51604
1824
1825         * Scripts/webkitdirs.pm:
1826
1827 2011-01-02  Robert Hogan  <robert@webkit.org>
1828
1829         Unreviewed, build fix.
1830
1831         [Qt] Fix DRT build after 74855
1832
1833         * DumpRenderTree/qt/DumpRenderTree.pro:
1834
1835 2011-01-01  Adam Barth  <abarth@webkit.org>
1836
1837         Remove the assumption from the Qt and Gtk builds that every project is
1838         in the root directory.
1839
1840         * Scripts/build-webkit:
1841
1842 2011-01-01  Adam Barth  <abarth@webkit.org>
1843
1844         Reviewed by Eric Seidel.
1845
1846         Teach svn-apply how to apply patches even though JavaScriptCore has moved
1847         https://bugs.webkit.org/show_bug.cgi?id=51796
1848
1849         After this change, svn-apply will magically apply patches to
1850         JavaScriptCore/foo to Source/JavaScriptCore/foo.
1851
1852         * Scripts/VCSUtils.pm:
1853
1854 2011-01-01  Adam Barth  <abarth@webkit.org>
1855
1856         Reviewed by Eric Seidel.
1857
1858         Move JavaScriptCore to Source
1859         https://bugs.webkit.org/show_bug.cgi?id=51604
1860
1861         Update references to JavaScriptCore to point to the new location.
1862
1863         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1864         * DumpRenderTree/qt/DumpRenderTree.pro:
1865         * DumpRenderTree/qt/ImageDiff.pro:
1866         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1867         * DumpRenderTree/wscript:
1868         * Scripts/build-jsc:
1869         * Scripts/build-webkit:
1870         * Scripts/do-file-rename:
1871         * Scripts/do-webcore-rename:
1872         * Scripts/run-javascriptcore-tests:
1873         * Scripts/update-javascriptcore-test-results:
1874         * Scripts/webkitdirs.pm:
1875         * Scripts/webkitpy/common/config/build_unittest.py:
1876         * Scripts/webkitpy/style/checker.py:
1877         * Scripts/webkitpy/style/checker_unittest.py:
1878         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1879         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1880         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1881         * wx/build/settings.py:
1882
1883 2011-01-01  Adam Barth  <abarth@webkit.org>
1884
1885         Reviewed by Eric Seidel.
1886
1887         Move Sources to Source
1888         https://bugs.webkit.org/show_bug.cgi?id=51794
1889
1890         Update scripts to point to the new location.
1891
1892         * Scripts/build-webkit:
1893         * Scripts/do-file-rename:
1894         * Scripts/do-webcore-rename:
1895         * Scripts/webkitpy/common/config/build.py:
1896         * Scripts/webkitpy/common/config/build_unittest.py:
1897
1898 2010-12-31  Kent Tamura  <tkent@chromium.org>
1899
1900         Reviewed by Eric Seidel.
1901
1902         [DRT/Chromium] Enable mock spell checker on non-OSX
1903         https://bugs.webkit.org/show_bug.cgi?id=51401
1904
1905         * DumpRenderTree/chromium/WebViewHost.cpp:
1906         (WebViewHost::spellCheck):
1907
1908 2010-12-31  Adam Barth  <abarth@webkit.org>
1909
1910         Reviewed by Ariya Hidayat.
1911
1912         Remove Tools/Scripts/wkstyle
1913         https://bugs.webkit.org/show_bug.cgi?id=51774
1914
1915         This script appears to not have been touched in a while and seems to
1916         have been replaced by check-webkit-style.
1917
1918         * Scripts/wkstyle: Removed.
1919
1920 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
1921
1922         Unreviewed. Coding style fix.
1923
1924         * DumpRenderTree/chromium/TestShell.h:
1925
1926 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
1927
1928         Reviewed by Pavel Feldman.
1929
1930         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
1931
1932         It was a problem with Chromium DRT. DevToolsAgent object instance was
1933         attached not only to the inspected page but to the DevTools window too.
1934         As result all the inspector files were interpreted as a content of inspected page
1935         and were transfered to the DevTools scripts panel for debugging etc.
1936
1937         https://bugs.webkit.org/show_bug.cgi?id=51735
1938
1939         * DumpRenderTree/chromium/TestShell.cpp:
1940         (TestShell::TestShell):
1941         (TestShell::bindJSObjectsToWindow):
1942         (TestShell::createNewWindow):
1943         * DumpRenderTree/chromium/TestShell.h:
1944
1945 2010-12-31  Adam Barth  <abarth@webkit.org>
1946
1947         Rubber-stamped by Eric Seidel.
1948
1949         Move PageLoadTests to PerformanceTests/PageLoad
1950         https://bugs.webkit.org/show_bug.cgi?id=51771
1951
1952         Update references to PageLoadTests to point to the new location.
1953
1954         * Scripts/run-pageloadtest:
1955         * Scripts/webkitpy/common/config/build.py:
1956
1957 2010-12-31  Adam Barth  <abarth@webkit.org>
1958
1959         Rubber-stamped by Eric Seidel.
1960
1961         Move SunSpider into PerformanceTests
1962         https://bugs.webkit.org/show_bug.cgi?id=51769
1963
1964         Update these scripts to point to the new location.
1965
1966         * Scripts/run-sunspider:
1967         * Scripts/sunspider-compare-results:
1968
1969 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
1970
1971         Reviewed by Kent Tamura.
1972
1973         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
1974         https://bugs.webkit.org/show_bug.cgi?id=51728
1975         
1976         Add implementation of the Mac WebThemeEngine that uses an NSScroller
1977         to render top-level scrollbars. This makes them match the Mac port's
1978         use of an NSScrollView, which means that we'll be able to share more
1979         pixel baselines.
1980         
1981         The new rendering code will not be activated until the 
1982         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
1983         ScrollbarThemeChromiumMac.
1984
1985         * DumpRenderTree/DumpRenderTree.gypi:
1986         * DumpRenderTree/chromium/TestShellMac.mm:
1987         (platformInit):
1988         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
1989         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
1990         (+[FakeActiveWindow alwaysActiveWindow]):
1991         (+[FakeActiveWindow alwaysInactiveWindow]):
1992         (-[FakeActiveWindow initWithActiveControls:]):
1993         (-[FakeActiveWindow _hasActiveControls]):
1994         (WebThemeEngineDRTMac::paintScrollbarThumb):
1995         (stateToHIEnableState):
1996         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
1997         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
1998
1999 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
2000
2001         Reviewed by David Kilzer.
2002
2003         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
2004         used
2005         https://bugs.webkit.org/show_bug.cgi?id=51672
2006
2007         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
2008         with USE_SYSTEM_MALLOC=1
2009         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
2010         with USE_SYSTEM_MALLOC=1
2011
2012 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2013
2014         Reviewed by David Kilzer.
2015
2016         [Qt] [Symbian] Fix build-webkit script for Symbian
2017         https://bugs.webkit.org/show_bug.cgi?id=51509
2018
2019         Set the OUTPUT_DIR for Symbian to be the same as the source
2020         directory.
2021
2022         * Scripts/webkitdirs.pm:
2023
2024 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
2025
2026         Reviewed by Darin Adler.
2027
2028         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
2029         https://bugs.webkit.org/show_bug.cgi?id=51758
2030
2031         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
2032
2033         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
2034         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
2035
2036 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
2037
2038         Unreviewed WinCE buildfix.
2039
2040         * WinCELauncher/main.cpp: Add missing include.
2041
2042 2010-12-29  Daniel Bates  <dbates@rim.com>
2043
2044         Reviewed by Darin Adler.
2045
2046         svn-apply updates date of wrong change log entry for a change log diff that
2047         contains two consecutive entries with the same author and date
2048         https://bugs.webkit.org/show_bug.cgi?id=46061
2049
2050         Fixes an issue where the date of the wrong change log entry may be modified.
2051         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
2052         in a ChangeLog file to the top of the file.
2053
2054         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
2055         diff when it detects that the diff inserts a change log entry earlier in a
2056         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
2057         change. With the advent of the commit-queue this functionality of bailing out
2058         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
2059         Instead, we should always move the change log entry to the top of the ChangeLog file.
2060
2061         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
2062         the date line of the correct change log entry in a ChangeLog diff.
2063
2064         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
2065
2066         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
2067           Updated the following unit tests now that we move entries inserted earlier to the top:
2068           - "fixChangeLogPatch: New entry inserted in middle."
2069             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
2070
2071           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
2072             (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
2073
2074         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
2075
2076 2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>
2077
2078         Reviewed by Eric Seidel.
2079
2080         [Qt] Fixed compatibility with gold linker on X11 platforms
2081         https://bugs.webkit.org/show_bug.cgi?id=51700
2082
2083         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2084         Linked TestNetscapePlugin with libX11 on Unix platforms
2085
2086 2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
2087
2088         Reviewed by Darin Adler.
2089
2090         Circular dependency in webkitpy.common.checkout.changelog module
2091         https://bugs.webkit.org/show_bug.cgi?id=50475
2092
2093         Remove automatic import of api.Checkout module when any checkout/
2094         submodule is imported (e.g.: when checkout.scm.Git is imported).
2095
2096         * Scripts/webkitpy/common/checkout/__init__.py:
2097
2098 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
2099
2100         Reviewed by Ojan Vafai.
2101
2102         prepare-ChangeLog should support the -g option for specifying the git-commit
2103         https://bugs.webkit.org/show_bug.cgi?id=51708
2104
2105         Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
2106         webkit-patch, though the exact meaning of the two options remain different.
2107
2108         * Scripts/prepare-ChangeLog: Add -g.
2109
2110 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
2111
2112         Reviewed by Simon Hausmann.
2113
2114         [Qt] Fix compilation with Qt in namespace
2115         https://bugs.webkit.org/show_bug.cgi?id=51701
2116
2117         * QtTestBrowser/webview.h:
2118
2119 2010-12-28  Daniel Bates  <dbates@rim.com>
2120
2121         Reviewed by Sam Weinig.
2122
2123         Substitute // MARK: for compiler-specific #pragma mark
2124         https://bugs.webkit.org/show_bug.cgi?id=51657
2125
2126         Fix future compilation warnings about "#pragma mark" on GTK+ bots by
2127         substituting  "// MARK:" for "#pragma mark", which provides
2128         analogous code-bookmarking functionality under Xcode.
2129
2130         Also, for consistency, we should substitute "// MARK:" for compiler-
2131         specific "#pragma mark" in the source files for the Mac port.
2132
2133         * DumpRenderTree/AccessibilityTextMarker.cpp:
2134         * DumpRenderTree/cf/WebArchiveDumpSupport.h:
2135         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
2136         * DumpRenderTree/mac/ObjCController.m:
2137         * MiniBrowser/mac/AppDelegate.m:
2138         * MiniBrowser/mac/BrowserWindowController.m:
2139
2140 2010-12-28  Xan Lopez  <xlopez@igalia.com>
2141
2142         Reviewed by Eric Seidel.
2143
2144         Add --no-build option to run-sunspider
2145         https://bugs.webkit.org/show_bug.cgi?id=51658
2146
2147         * Scripts/run-sunspider: add --no-build flag to skip building
2148         phase.
2149
2150 2010-12-27  Daniel Bates  <dbates@rim.com>
2151
2152         Rubber-stamped by Martin Robinson.
2153
2154         Append the directory Tools/DumpRenderTree to the list of directories that
2155         do-webcore-rename should search so that it can rename DRT files and
2156         source code.
2157
2158         * Scripts/do-webcore-rename:
2159
2160 2010-12-27  Eric Seidel  <eric@webkit.org>
2161
2162         Reviewed by Adam Barth.
2163
2164         build-webkit should detect missing Java SDK and explain how to install it
2165         https://bugs.webkit.org/show_bug.cgi?id=51651
2166
2167         * Scripts/build-webkit:
2168
2169 2010-12-26  Martin Robinson  <mrobinson@igalia.com>
2170
2171         Reviewed by Daniel Bates.
2172
2173         [GTK] Add support for build-jsc
2174         https://bugs.webkit.org/show_bug.cgi?id=51625
2175
2176         Add GTK+ support to build-jsc now that building the jsc executable as
2177         a standalone target is easy.
2178
2179         * Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
2180         * Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
2181         * Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject
2182         and pass it along to buildAutotoolsProject.
2183
2184 2010-12-27  David Levin  <levin@chromium.org>
2185
2186         Reviewed by Eric Seidel.
2187
2188         check-webkit-style check for meaningless variable names in function declarations.
2189         https://bugs.webkit.org/show_bug.cgi?id=51523
2190
2191         * Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp
2192         from the new check and whitespace/parens because the syntax is unusual and
2193         produced a fair number of positives for these checks.
2194         * Scripts/webkitpy/style/checkers/cpp.py:
2195         (_convert_to_lower_with_underscores): Used as a canonical form for type names
2196         and parameter names when determining if the parameter name is useless.
2197         (_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
2198         (Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
2199         format.
2200         (_check_parameter_name_against_text):  Checks to see if the parameter name is in the
2201         text or an acronym of it.
2202         (check_function_definition): Checks function definitions for meaningless variable names.
2203         (process_line): Added call to check_function_definition.
2204         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2205         (CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
2206         (CppFunctionsTest.test_create_acronym): Test for _create_acronym.
2207         (CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
2208         (CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
2209         because when only checking a snippet, there are a lot of bogus functions.
2210         (CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
2211         that I put there previously and just noticed.
2212         (WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
2213         check_function_definition and process_line.
2214
2215 2010-12-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2216
2217         Reviewed by Martin Robinson.
2218
2219         [GTK] Disable flash plugin in GtkLauncher when using gtk3
2220         https://bugs.webkit.org/show_bug.cgi?id=51591
2221
2222         Flash plugin uses gtk2 that is incompatible with gtk3 making
2223         webkit crash when it's built with gtk3.
2224
2225         * GtkLauncher/main.c:
2226         (main):
2227
2228 2010-12-25  Adam Barth  <abarth@webkit.org>
2229
2230         Reviewed by Eric Seidel.
2231
2232         Move ANGLE to Sources/ThirdParty
2233         https://bugs.webkit.org/show_bug.cgi?id=51605
2234
2235         * Scripts/build-webkit:
2236           - Point to the new ANGLE location.
2237
2238 2010-12-26  David Levin  <levin@chromium.org>
2239
2240         Reviewed by Eric Seidel.
2241
2242         check-webkit-style should be able to parse function declaration parameters.
2243         https://bugs.webkit.org/show_bug.cgi?id=51451
2244
2245         * Scripts/webkitpy/style/checkers/cpp.py:
2246         (Position.__init__): Holds simple position information (row, column).
2247         (Parameter.__init__): Holds information about a parameter.
2248         (SingleLineView.__init): Converts multiple lines into a single line for simpler searches.
2249         (SingleLineView.convert_column_to_row): Returns the original row given a column.
2250         (create_skeleton_parameters): Simplifies a parameter list for easier searching.
2251         (find_parameter_name_index): Finds where the parameter name is.
2252         (parameter_list): Generates the list of parameters for a function.
2253         (_FunctionState.begin): Added information to allow determining the parameters
2254         on demand.
2255         (_FunctionState.get_parameter_list): Returns a tuple of function parameters.
2256         (detect_functions): Improve function detection for operator functions and
2257         determine where the parameters end and pass that to _FunctionState.begin.
2258         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2259         (CppFunctionsTest.test_parameter): Verifies Parameter functionality.
2260         (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality.
2261         (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters.
2262         (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index.
2263         (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list.
2264         Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list.
2265         (FunctionDetectionTest.perform_function_detection): Added support for verifying
2266         the parameters found.
2267         (FunctionDetectionTest.test_function_declaration_detection): Added more function
2268         detection test to verify that we catch the operator functions.
2269         (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros.
2270         (FunctionDetectionTest.test_parameter_list): Added tests to verify the parameter parsing.
2271         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Removed
2272         because the error. The test is about the bad function name. Fixing the name makes the test exactly like
2273         test_function_length_check_definition_severity1_for_test.
2274
2275 2010-12-25  Patrick Gansterer  <paroga@webkit.org>
2276
2277         Unreviewed WinCE buildfix after r74334.
2278
2279         * CMakeListsWinCE.txt:
2280
2281 2010-12-24  Sheriff Bot  <webkit.review.bot@gmail.com>
2282
2283         Unreviewed, rolling out r74632.
2284         http://trac.webkit.org/changeset/74632
2285         https://bugs.webkit.org/show_bug.cgi?id=51600
2286
2287         makes test-webkitpy hang forever on GTK (Requested by philn-tp
2288         on #webkit).
2289
2290         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2291         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2292
2293 2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>
2294
2295         Reviewed by Kenneth Rohde Christiansen.
2296
2297         [EFL] Screen doesn't be rendered when changing size of EWebLauncher
2298         https://bugs.webkit.org/show_bug.cgi?id=43528
2299
2300         Remove on_resize because ewk_view_fixed_layout_size_set should not be
2301         called on callback of EVAS_CALLBACK_RESIZE. As it change size of
2302         FrameView, rendering was ignored when _ewk_view_smart_calculate was
2303         called.
2304
2305         * EWebLauncher/main.c:
2306         (browserCreate):
2307
2308 2010-12-24  Eric Seidel  <eric@webkit.org>
2309
2310         Reviewed by Adam Barth.
2311
2312         webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
2313         https://bugs.webkit.org/show_bug.cgi?id=28291
2314
2315         This is a start.  At least now webkit-patch will prompt when your ChangeLog looks questionable.
2316         We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
2317         to strings with find in the diff.
2318         Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.
2319
2320         * Scripts/webkitpy/common/checkout/api.py:
2321         * Scripts/webkitpy/common/checkout/diff_parser.py:
2322         * Scripts/webkitpy/tool/steps/abstractstep.py:
2323         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
2324         * Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
2325         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
2326         * Scripts/webkitpy/tool/steps/validatereviewer.py:
2327
2328 2010-12-24  Dirk Pranke  <dpranke@chromium.org>
2329
2330         Reviewed by Kenneth Russell.
2331
2332         Modify new-run-webkit-tests to shut up and exit when all the threads
2333         are wedged so that test runs complete faster and we don't end up
2334         w/ enormous log files.
2335
2336         https://bugs.webkit.org/show_bug.cgi?id=51572
2337
2338         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2339         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2340
2341 2010-12-24  Eric Seidel  <eric@webkit.org>
2342
2343         Reviewed by David Levin.
2344
2345         commit-queue should better explain how it will re-open bugs and follow duplicate chains
2346         https://bugs.webkit.org/show_bug.cgi?id=51549
2347
2348         I've had multiple people ask me about the commit-queue's behavior
2349         regarding reporting flaky tests.  I figured it would be best to just
2350         have the queue explain itself in the bugs it files.
2351
2352         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2353         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2354
2355 2010-12-24  Shinichiro Hamaji  <hamaji@chromium.org>
2356
2357         Reviewed by Eric Seidel.
2358
2359         check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt
2360         https://bugs.webkit.org/show_bug.cgi?id=51467
2361
2362         * Scripts/webkitpy/style/checker.py:
2363         * Scripts/webkitpy/style/checker_unittest.py:
2364
2365 2010-12-23  Adam Barth  <abarth@webkit.org>
2366
2367         Rubber-stamped by Eric Seidel.
2368
2369         Move JavaScriptGlue into Sources
2370         https://bugs.webkit.org/show_bug.cgi?id=51583
2371
2372         These tools refer to JavaScriptGlue and need to be updated to its new
2373         location.
2374
2375         * Scripts/build-webkit:
2376         * Scripts/do-file-rename:
2377         * Scripts/do-webcore-rename:
2378         * Scripts/webkitpy/common/config/build.py:
2379         * Scripts/webkitpy/common/config/build_unittest.py:
2380
2381 2010-12-23  Lucas Forschler  <lforschler@apple.com>
2382
2383         Reviewed by Eric Seidel.
2384
2385         Bug 51539 - update iexploder scripts to point to new location
2386
2387         * Scripts/run-iexploder-tests:
2388         * Scripts/update-iexploder-cssproperties:
2389
2390 2010-12-23  Evan Martin  <evan@chromium.org>
2391
2392         Reviewed by Ryosuke Niwa.
2393
2394         [chromium] LayoutTestController warning in float->int conversion
2395         https://bugs.webkit.org/show_bug.cgi?id=51553
2396
2397         Rather than reading an int, converting to a float, then getting a compiler
2398         warning on passing the float to something that expects an int, instead
2399         just pass around ints.
2400
2401         No tests, fixes a compiler warning.
2402
2403         * DumpRenderTree/chromium/LayoutTestController.cpp:
2404         (parsePageSizeParameters):
2405         (LayoutTestController::pageNumberForElementById):
2406         (LayoutTestController::numberOfPages):
2407
2408 2010-12-23  Lucas Forschler  <lforschler@apple.com>
2409
2410         Reviewed by Darin Adler.
2411
2412         Bug 51537 - iexploder needs cleanup
2413         
2414         * iExploder/htdocs: Removed.
2415         * iExploder/htdocs/config.rb: Removed.
2416         * iExploder/htdocs/cssproperties.in: Removed.
2417         * iExploder/htdocs/cssvalues.in: Removed.
2418         * iExploder/htdocs/htmlattrs.in: Removed.
2419         * iExploder/htdocs/htmltags.in: Removed.
2420         * iExploder/htdocs/htmlvalues.in: Removed.
2421         * iExploder/htdocs/iexploder.cgi: Removed.
2422         * iExploder/htdocs/iexploder.rb: Removed.
2423         * iExploder/htdocs/index.html: Removed.
2424         * iExploder/htdocs/webserver.rb: Removed.
2425         * iExploder/iexploder-1.7.2/output: Removed.
2426         * iExploder/tools: Removed.
2427         * iExploder/tools/lasthit.rb: Removed.
2428         * iExploder/tools/osx_last_crash.rb: Removed.
2429         * iExploder/tools/showtest.rb: Removed.
2430
2431 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2432
2433         Reviewed by Kenneth Rohde Christiansen.
2434
2435         [EFL] Make 'single' the default backing store in EWebLauncher
2436         https://bugs.webkit.org/show_bug.cgi?id=51534
2437
2438         'single' is the simplest backing store and the one intended to be the
2439         default in the test browser. By mistake the tiled backing store was
2440         left as default in r72617.
2441
2442         * EWebLauncher/main.c:
2443         (browserCreate): ditto.
2444
2445 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2446
2447         Reviewed by Kenneth Rohde Christiansen.
2448
2449         [EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround
2450         https://bugs.webkit.org/show_bug.cgi?id=51533
2451
2452         There's no point in concatenating env("HOME") with "blah", so remove
2453         option from EWebLauncher.
2454
2455         * EWebLauncher/main.c:
2456         (main): ditto.
2457
2458 2010-12-23  Ilya Tikhonovsky  <loislo@chromium.org>
2459
2460         Reviewed by Eric Seidel.
2461
2462         Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).
2463
2464         Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
2465         I just discovered that we have two additional GC runs per each WebViewHost.
2466         Test_shell had no such calls.
2467         These gc runs eat 15% of cpu time.
2468
2469         https://bugs.webkit.org/show_bug.cgi?id=51479
2470
2471         * DumpRenderTree/chromium/WebViewHost.cpp:
2472         (WebViewHost::~WebViewHost):
2473
2474 2010-12-22  Dirk Pranke  <dpranke@chromium.org>
2475
2476         Reviewed by Ojan Vafai.
2477
2478         This change splits out the TestRunner class into its own file.
2479         When we fork the code for message passing, we will create a new
2480         TestRunner, and this change will allow that to be more modular.
2481
2482         While we're at it, split out TestInput and ResultSummary into
2483         their own files, to reduce the size of run_webkit_tests to
2484         something more managable.
2485
2486         https://bugs.webkit.org/show_bug.cgi?id=51092
2487
2488         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2489         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
2490         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2491         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
2492         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
2493         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2494         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2495
2496  2010-12-22  Dirk Pranke  <dpranke@chromium.org>
2497
2498         Reviewed by Ojan Vafai.
2499
2500         nrwt multiprocessing - start over, prepare to fork the code
2501  
2502         This code cleans up the signatures and implementation of the
2503         TestRunner class so we can easily fork it to run either the
2504         stable implementation or the new, unstable message-passing
2505         implementation. The two variants will have different
2506         implementations of the run_tests() method. We will switch
2507         between the two based on the setting for the '--worker-model'
2508         switch. We rename the two currently valid values to 'old-inline'
2509         and 'old-threads'.
2510
2511         https://bugs.webkit.org/show_bug.cgi?id=51081
2512
2513         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2514         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2515
2516 2010-12-22  Victor Wang  <victorw@chromium.org>
2517
2518         Reviewed by Darin Fisher.
2519
2520         [Chromium] Update chromium archive test result url in rebaseline script.
2521
2522         https://bugs.webkit.org/show_bug.cgi?id=51503
2523
2524         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2525
2526 2010-12-22  Lucas Forschler  <lforschler@apple.com>
2527
2528         Reviewed by Alice Liu.
2529
2530         <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
2531         Verified on Chrome, Safari, and IE.
2532         With this change, we will record memory from a parent browser window and all child processes.
2533
2534         * record-memory-win/main.cpp:
2535         (ProcessArgs):
2536         (PrintUsage):
2537         (getMemoryInfo):
2538         (printProcessInfo):
2539         (evalProcesses):
2540         (UseImage):
2541         (QueryContinuously):
2542         (ElapsedTime):
2543
2544 2010-12-22  Lucas Forschler  <lforschler@apple.com>
2545
2546         Unreviewed rollout r74489, because it was missing changelog.
2547
2548         * record-memory-win/main.cpp:
2549         
2550 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
2551
2552         Adding myself as a reviewer.
2553
2554         * Scripts/webkitpy/common/config/committers.py:
2555
2556 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
2557
2558         Unreviewed.  Adding myself to committers.py.
2559
2560         * Scripts/webkitpy/common/config/committers.py:
2561
2562 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
2563
2564         Reviewed by Kenneth Rohde Christiansen.
2565
2566         TestNetscapePlugIn should use #if defined
2567         https://bugs.webkit.org/show_bug.cgi?id=51471
2568
2569         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2570         (NP_Initialize):
2571         (NPP_New):
2572
2573 2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
2574
2575         Reviewed by Yury Semikhatsky.
2576
2577         Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
2578
2579         DevTools window should be closed explicitly because it has custom deinitialization code.
2580
2581         https://bugs.webkit.org/show_bug.cgi?id=50722
2582
2583         * DumpRenderTree/chromium/TestShell.cpp:
2584         (TestShell::closeRemainingWindows):
2585
2586 2010-12-22  David Levin  <levin@chromium.org>
2587
2588         Reviewed by Shinichiro Hamaji.
2589
2590         check-webkit-style shouldn't complaint about underscores in variables in objective C files.
2591         https://bugs.webkit.org/show_bug.cgi?id=51452
2592
2593         * Scripts/webkitpy/style/checkers/cpp.py:
2594         (_FileState.__init__): Added the information to determine if a file is C or Objective C.
2595         Using the file extension if possible but falling back to the file contents if we have a header file.
2596         (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
2597         (_FileState.is_c_or_objective_c):
2598         (check_using_std): Changed to using _FileState to determine the file type.
2599         (check_max_min_macros): Ditto.
2600         (check_for_null): Ditto.
2601         (check_style): Changed the parameters to various calls since they now need _FileState
2602         to determine the file type.
2603         (check_language): Added the file_state parameter so it could be passed
2604         to check_identifier_name_in_declaration.
2605         (check_identifier_name_in_declaration): Don't warn about underscores in variables if
2606         this is an Objective C file.
2607         (_process_lines): Added information for the _FileState constructor (and moved the
2608         call to a place that had the information).
2609         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2610         (CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
2611         its functionality.
2612         (WebKitStyleTest.test_names): Add tests for underscores in Objective C files.
2613
2614 2010-12-21  Andy Estes  <aestes@apple.com>
2615
2616         Reviewed by Mark Rowe.
2617
2618         Do not build non-Intel architectures for WebKit2-related projects.
2619         https://bugs.webkit.org/show_bug.cgi?id=51440
2620
2621         * MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64.
2622         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
2623         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
2624
2625 2010-12-21  Mihai Parparita  <mihaip@chromium.org>
2626
2627         Reviewed by Darin Fisher.
2628
2629         [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
2630         https://bugs.webkit.org/show_bug.cgi?id=51406 
2631         
2632         Rename WebThemeControlDRT to WebThemeControlDRTWin and WebThemeEngineDRT
2633         to WebThemeEngineDRTWin and update references everywhere.
2634
2635         * DumpRenderTree/DumpRenderTree.gypi:
2636         * DumpRenderTree/chromium/TestShellWin.cpp:
2637         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.cpp.
2638         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.h.
2639         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp.
2640         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.h.
2641
2642 2010-12-21  Anders Carlsson  <andersca@apple.com>
2643
2644         Reviewed by John Sullivan.
2645
2646         Clicking missing plug-in text does not show a sheet
2647         https://bugs.webkit.org/show_bug.cgi?id=51403
2648
2649         Update for changes to the WebPageUIClient.
2650
2651         * MiniBrowser/mac/BrowserWindowController.m:
2652         (-[BrowserWindowController awakeFromNib]):
2653         * WebKitTestRunner/TestController.cpp:
2654         (WTR::createOtherPage):
2655         (WTR::TestController::initialize):
2656
2657 2010-12-21  Eric Seidel  <eric@webkit.org>
2658
2659         Reviewed by Adam Barth.
2660
2661         commit-queue will report constant failures as flaky if other tests flake
2662         https://bugs.webkit.org/show_bug.cgi?id=51272
2663
2664         This patch just removes functionality and adds testing.
2665         Previously we attempted to report flaky tests when we had
2666         two different tests fail in a row.  However, since we stop
2667         running the tests at the first failure, our code was wrong in
2668         trying to determine flakiness from the incomplete runs.
2669
2670         Originally I posted an alternate patch:
2671         https://bug-51272-attachments.webkit.org/attachment.cgi?id=77078
2672         which fixed our flaky logic in this case, however it was decided
2673         that that patch would be too difficult to maintain, so now
2674         I'm just removing the broken logic.
2675
2676         This will dramatically cut-down on our flaky-test false positives
2677         at the (small) cost of the queues being unable to report
2678         any flakiness if the tree is very flaky.  (With at least one test
2679         flaking on every run, we'll never report failures anymore.)  I think
2680         this is a tradeoff worth making.
2681
2682         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2683         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2684
2685 2010-12-20  Eric Seidel  <eric@webkit.org>
2686
2687         Reviewed by Adam Barth.
2688
2689         commit-queue wrongly rejects patches when it can't update itself
2690         https://bugs.webkit.org/show_bug.cgi?id=46636
2691
2692         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2693         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2694         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2695
2696 2010-12-20  Adam Barth  <abarth@webkit.org>
2697
2698         Move web sites to Websites directory
2699         https://bugs.webkit.org/show_bug.cgi?id=51323
2700
2701         Update references to BugsSite to point to the new location.
2702
2703         This patch was never officially reviewed (because it was too large to
2704         upload to bugs.webkit.org), but it was discussed on webkit-dev and Mark
2705         Rowe gave me the green light.
2706
2707         * Scripts/old-run-webkit-tests:
2708         * Scripts/webkitpy/common/config/build.py:
2709         * Scripts/webkitpy/common/config/build_unittest.py:
2710         * Scripts/webkitpy/common/prettypatch.py:
2711         * Scripts/webkitpy/layout_tests/port/base.py:
2712         * Scripts/webkitpy/style/main.py:
2713
2714 2010-12-20  Adrienne Walker  <enne@google.com>
2715
2716         Unreviewed. Adding myself to the list of committers.
2717
2718         * webkitpy/common/config/committers.py:
2719
2720 2010-12-20  Mark Rowe  <mrowe@apple.com>
2721
2722         Reviewed by Dan Bernstein.
2723
2724         <rdar://problem/8757601> Don't install header files in to the Resources directory.
2725
2726         * Scripts/check-for-inappropriate-files-in-framework: Don't allow .h files in the
2727         Resources directory.
2728
2729 2010-12-20  Eric Seidel  <eric@webkit.org>
2730
2731         Reviewed by Adam Barth.
2732
2733         commit-queue should include bot id when attaching failure diffs
2734         https://bugs.webkit.org/show_bug.cgi?id=51280
2735
2736         This is a tiny change to include the bot id in the name of the attachment.
2737         Most of this diff is just changing the unit test expectations
2738         now that I hid the comment printing when the comment is None.
2739
2740         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2741         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2742         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2743         * Scripts/webkitpy/tool/mocktool.py:
2744
2745 2010-12-20  Jeff Miller  <jeffm@apple.com>
2746
2747         Reviewed by Dan Bernstein.
2748
2749         Tools/vcbin/midl.exe needs to be rebuilt
2750         https://bugs.webkit.org/show_bug.cgi?id=51347
2751
2752         * vcbin/midl.exe: Rebuilt.
2753
2754 2010-12-20  David Levin  <levin@chromium.org>
2755
2756         Reviewed by Ariya Hidayat.
2757
2758         .gitignore and webkit-tools-completion.sh have references to WebKitTools that should be Tools.
2759         https://bugs.webkit.org/show_bug.cgi?id=51343
2760
2761         Follow up from the WebKitTools -> Tools rename.
2762
2763         * Scripts/webkit-tools-completion.sh:
2764
2765 2010-12-20  Cosmin Truta  <ctruta@chromium.org>
2766
2767         Reviewed by James Robinson.
2768
2769         new-run-webkit-tests ignores trailing EOL differences in text tests
2770         https://bugs.webkit.org/show_bug.cgi?id=36983
2771
2772         Changed the handling of new-line characters within new-run-webkit-tests
2773         to match old-run-webkit-tests.  Differences in leading and trailing empty
2774         lines in text expectation files are no longer ignored.
2775
2776         * Scripts/webkitpy/layout_tests/port/base.py:
2777         * Scripts/webkitpy/layout_tests/port/test.py:
2778         Added unit tests.  Removed old duplicate unit test entries.
2779         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2780
2781 2010-12-20  David Levin  <levin@chromium.org>
2782
2783         Reviewed by Shinichiro Hamaji.
2784
2785         check-webkit-style should detect function declarations (and trivial functions).
2786         https://bugs.webkit.org/show_bug.cgi?id=51303
2787
2788         * Scripts/webkitpy/style/checkers/cpp.py:
2789         (_FunctionState.begin): Add is_declaration and changed the line count
2790         start to begin at -1 (which will keep the results consistent, since
2791         the starting line number passed in is one less in this change).
2792         (detect_functions): changed function detection to now catch trivial
2793         functions and declarations.
2794         (check_pass_ptr_usage): Don't check for Pass*Ptr on the first line
2795         of the function as this may look at return values (when processing
2796         a declaration).
2797         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2798         (FunctionDetectionTest.perform_function_detection): Basic mechanics
2799         of testing the function detection.
2800         (FunctionDetectionTest.test_basic_function_detection): Test a simple
2801         function.
2802         (FunctionDetectionTest.test_function_declaration_detection): Test a
2803         declaration.
2804         (FunctionDetectionTest.test_non_functions): A test case for a case
2805         that caused the code to fail due to the { being in quotes.
2806         (PassPtrTest.test_pass_ref_ptr_return_value): Added some more test
2807         cases to help catch false alarms for return values.
2808         (PassPtrTest.test_pass_ref_ptr_member_variable): Ensure that
2809         we don't get false alarms for member variables either.
2810
2811 2010-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
2812
2813         Reviewed by Antonio Gomes.
2814
2815         [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR
2816         https://bugs.webkit.org/show_bug.cgi?id=51319
2817
2818         * CMakeListsEfl.txt:
2819
2820 2010-12-18  Adam Barth  <abarth@webkit.org>
2821
2822         Reviewed by Sam Weinig.
2823
2824         Move WebKitExamplePlugins to Examples
2825         https://bugs.webkit.org/show_bug.cgi?id=51291
2826
2827         * Scripts/webkitpy/common/config/build.py:
2828
2829 2010-12-17  Csaba Osztrogonác  <ossy@webkit.org>
2830
2831         Unreviewed Qt buildfix after r74301.
2832
2833         Rename WebKitTools to Tools
2834         https://bugs.webkit.org/show_bug.cgi?id=49861
2835
2836         * MiniBrowser/DerivedSources.pro:
2837         * MiniBrowser/qt/MiniBrowser.pro:
2838
2839 2010-12-17  Dan Bernstein  <mitz@apple.com>
2840
2841         Reviewed by Simon Fraser.
2842
2843         Rename WebKitTools to Tools
2844         https://bugs.webkit.org/show_bug.cgi?id=49861
2845
2846         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2847         * CodeCoverage/README:
2848         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2849         (WebCore::DumpRenderTree::initializeFonts):
2850         * EWSTools/start-commit-queue.sh:
2851         * EWSTools/start-queue.sh:
2852         * GNUmakefile.am:
2853         * MIDLWrapper/MIDLWrapper.cpp:
2854         (wmain):
2855         * MiniBrowser/qt/MiniBrowser.pro:
2856         * Scripts/build-api-tests:
2857         * Scripts/build-dumprendertree:
2858         * Scripts/build-webkit:
2859         * Scripts/build-webkittestrunner:
2860         * Scripts/generate-coverage-data:
2861         * Scripts/old-run-webkit-tests:
2862         * Scripts/run-api-tests:
2863         * Scripts/run-iexploder-tests:
2864         * Scripts/run-javascriptcore-tests:
2865         * Scripts/run-mangleme-tests:
2866         * Scripts/run-sunspider:
2867         * Scripts/run-webkit-websocketserver:
2868         * Scripts/sunspider-compare-results:
2869         * Scripts/test-webkitperl:
2870         * Scripts/test-webkitpy:
2871         * Scripts/update-iexploder-cssproperties:
2872         * Scripts/update-webkit:
2873         * Scripts/update-webkit-localizable-strings:
2874         * Scripts/webkitdirs.pm:
2875         * Scripts/webkitpy/common/checkout/scm.py:
2876         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2877         * Scripts/webkitpy/common/config/committervalidator.py:
2878         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
2879         * Scripts/webkitpy/common/config/ports.py:
2880         * Scripts/webkitpy/common/config/ports_unittest.py:
2881         * Scripts/webkitpy/common/system/logutils_unittest.py:
2882         * Scripts/webkitpy/common/system/ospath_unittest.py:
2883         * Scripts/webkitpy/layout_tests/port/chromium.py:
2884         * Scripts/webkitpy/layout_tests/port/config.py:
2885         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2886         * Scripts/webkitpy/layout_tests/port/http_server.py:
2887         * Scripts/webkitpy/layout_tests/port/test.py:
2888         * Scripts/webkitpy/style/checker.py:
2889         * Scripts/webkitpy/style/checker_unittest.py:
2890         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
2891         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2892         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2893         * WebKitTestRunner/DerivedSources.pro:
2894         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2895         (WTR::activateFonts):
2896         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2897         * wx/build/build_utils.py:
2898
2899 2010-12-16  Antonio Gomes  <agomes@rim.com>
2900
2901         Reviewed by Martin Robinson.
2902
2903         Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
2904         https://bugs.webkit.org/show_bug.cgi?id=51163
2905
2906         Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
2907         GTK+'s DRT should also reset to UNIX after each test execution.
2908
2909         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2910         (resetDefaultsToConsistentValues):
2911
2912 2010-12-17  David Levin  <levin@chromium.org>
2913
2914         Reviewed by Eric Seidel.
2915
2916         check-webkit-style should understand WTF #include guards
2917         https://bugs.webkit.org/show_bug.cgi?id=44911
2918
2919         * Scripts/webkitpy/style/checkers/cpp.py:
2920         (get_header_guard_cpp_variable): modify to suggest the WTF style
2921         of header guard when appropriate.
2922         (check_for_header_guard): handle multiple return values from
2923         get_header_guard_cpp_variable
2924         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2925         (CppStyleTest.test_build_header_guard): Added tests for the WTF
2926         header style.
2927
2928 2010-12-16  David Levin  <levin@chromium.org>
2929
2930         Reviewed by Eric Seidel.
2931
2932         test-webkitpy: unittest for the xml.py checker displays a decprecation warning.
2933         https://bugs.webkit.org/show_bug.cgi?id=51210
2934
2935         The error only shows up when using python 2.6 or later.
2936
2937         * Scripts/webkitpy/style/checkers/xml.py: Replace the usage of
2938         the decprecated field error,message with something equivalent.
2939
2940 2010-12-16  Mihai Parparita  <mihaip@chromium.org>
2941
2942         Reviewed by Eric Seidel.
2943
2944         Add --exit-after-n-failures/crashes to NRWT
2945         https://bugs.webkit.org/show_bug.cgi?id=51160
2946         
2947         Abort test run (in a similar way to how control-C is handled) when
2948         --exit-after-n-failures/crashes-or-timeouts are passed and we've reached
2949         that number of unexpected failures/crashes/timeouts.
2950
2951         * Scripts/webkitpy/layout_tests/port/test.py:
2952         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2953         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2954
2955 2010-12-16  David Levin  <levin@chromium.org>
2956
2957         Reviewed by Shinichiro Hamaji.
2958
2959         check-webkit-style unit tests has some duplicate boilerplate code.
2960         https://bugs.webkit.org/show_bug.cgi?id=49519
2961
2962         * Scripts/webkitpy/style/checkers/cpp.py:
2963         (update_include_state): Replaced the "io" parameter with the global
2964         configuration _unit_test_config. This allowed not calling into
2965         functions at a low level and also not plumbing through the injection
2966         information through many levels of code.
2967         (check_for_include_what_you_use): Ditto.
2968         (process_file_data): Added the ability to set up the unit test config
2969         to allow for injection.
2970         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2971         (ErrorCollector.__init__): Added support for having a filter for errors.
2972         (ErrorCollector.__call__): Ditto.
2973         (CppStyleTestBase.process_file_data): Added the ability to set unit_test_config.
2974         (CppStyleTestBase.perform_lint): Consolidated logic for the perform functions.
2975         (CppStyleTestBase.perform_single_line_lint): Replace specific calls to
2976         functions in the cpp.py with generic processing and a filter that
2977         indicates what errors should be kept.
2978         (CppStyleTestBase.perform_multi_line_lint): Ditto.
2979         (CppStyleTestBase.perform_language_rules_check): Ditto.
2980         (CppStyleTestBase.perform_function_lengths_check): Ditto.
2981         (CppStyleTestBase.perform_pass_ptr_check): Ditto.
2982         (CppStyleTestBase.perform_include_what_you_use): Ditto.
2983         (CppStyleTest.test_multi_line_comments): Added another
2984         error message which applies to the test case.
2985         (CppStyleTest.test_spacing_for_binary_ops): Fixed test
2986         to not have config.h, since it is processed as a header file.
2987         (CppStyleTest.test_static_or_global_stlstrings): Fixed variable name
2988         style and indentation in checked code.
2989         (OrderOfIncludesTest.test_check_preprocessor_in_include_section):
2990         Fixed line number.
2991         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
2992         Ditto.
2993
2994 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
2995
2996         Unreviewed, rolling out r74136.
2997         http://trac.webkit.org/changeset/74136
2998         https://bugs.webkit.org/show_bug.cgi?id=51135
2999
3000         r74136 breaks chromium canary bots because some tests are not
3001         rebaselined correctly to resolve EOL differences (Requested by
3002         jianli on #webkit).
3003
3004         * Scripts/webkitpy/layout_tests/port/base.py:
3005         * Scripts/webkitpy/layout_tests/port/test.py:
3006         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3007
3008 2010-12-15  Adam Roben  <aroben@apple.com>
3009
3010         Teach check-webkit-style to check .vcproj and .vsprops files for XML
3011         syntax errors
3012
3013         Fixes <http://webkit.org/b/51103> check-webkit-style should check for
3014         XML syntax errors in .vcproj/.vsprops files
3015
3016         Reviewed by Dave Levin.
3017
3018         * Scripts/webkitpy/style/checker.py: Added lists of file extensions
3019         that should be treated as XML and that should be allowed to contain
3020         carriage returns. (These lists happen to be identical currently.)
3021         (FileType): Added a new XML type.
3022         (CheckerDispatcher.should_check_and_strip_carriage_returns): Added.
3023         Just does a simple file extension check.
3024         (CheckerDispatcher._file_type): Added a case for XML files.
3025         (CheckerDispatcher._create_checker): Ditto. We use XMLChecker for XML
3026         files (surprise!).
3027         (StyleProcessor.process): Ask the dispatcher whether we should pass the
3028         lines through the carriage checker.
3029
3030         * Scripts/webkitpy/style/checker_unittest.py:
3031         (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
3032         Added. Checks a few file names to see if carriage returns are allowed
3033         or not.
3034         (CheckerDispatcherDispatchTest.assert_checker_xml): Added. Similar to
3035         other assert_checker_* functions.
3036         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
3037         test_*_paths functions.
3038         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
3039         test_*_paths functions.
3040         (CheckerDispatcherDispatchTest.test_none_paths): Removed the vcproj
3041         file from this test case, as vcproj files now have a type.
3042         (StyleProcessor_CodeCoverageTest.MockDispatcher.should_check_and_strip_carriage_returns):
3043         Added. Similar to the other should_* functions.
3044         (StyleProcessor_CodeCoverageTest.test_process__carriage_returns_not_stripped):
3045         Added. Checks that carriage returns aren't checked for or stripped for
3046         allowed files.
3047
3048         * Scripts/webkitpy/style/checkers/xml.py: Added.
3049         (XMLChecker.__init__): Simple init method.
3050         (XMLChecker.check): Pass each line through the expat parser, and record
3051         a style error for any errors thrown by the parser.
3052
3053         * Scripts/webkitpy/style/checkers/xml_unittest.py: Added.
3054         (XMLCheckerTest.assert_no_error): Checks that the given XML does not
3055         produce a style error.
3056         (XMLCheckerTest.assert_error): Checks that the given XML produces an
3057         error of the given category on the given line.
3058         (XMLCheckerTest.mock_handle_style_error): Does nothing. Used for
3059         checking that the XMLChecker constructor works properly.
3060         (XMLCheckerTest.test_conflict_marker): Tests that conflict markers
3061         cause a style error (see, e.g., r73887).
3062         (XMLCheckerTest.test_extra_closing_tag): Tests that extra closing tags
3063         cause a style error (see, e.g., r73773).
3064         (XMLCheckerTest.test_init): Tests that the XMLChecker constructor works
3065         properly.
3066         (XMLCheckerTest.test_missing_closing_tag): Tests that missing closing
3067         tags cause a style error (see, e.g., r72795).
3068         (XMLCheckerTest.test_no_error): Tests that valid XML does not cause a
3069         style error.
3070
3071 2010-12-15  Lucas Forschler  <lforschler@apple.com>
3072
3073         Reviewed by Stephanie Lewis.
3074
3075         https://bugs.webkit.org/show_bug.cgi?id=51117
3076         Add a new leopard test bot
3077         really really commit to trunk this time.
3078
3079         * BuildSlaveSupport/build.webkit.org-config/config.json:
3080
3081 2010-12-15  Sam Weinig  <sam@webkit.org>
3082
3083         Reviewed by Anders Carlsson.
3084
3085         WebKit2: Can't add files to an <input type=file>
3086         https://bugs.webkit.org/show_bug.cgi?id=51087
3087
3088         * MiniBrowser/mac/BrowserWindowController.m:
3089         (runOpenPanel):
3090         (-[BrowserWindowController awakeFromNib]):
3091         Add simple implementation of runOpenPanel callback.
3092
3093         * MiniBrowser/win/BrowserView.cpp:
3094         (BrowserView::create):
3095         * WebKitTestRunner/TestController.cpp:
3096         (WTR::createOtherPage):
3097         (WTR::TestController::initialize):
3098         Stub out runOpenPanel callback. 
3099
3100 2010-12-14  Eric Seidel  <eric@webkit.org>
3101
3102         Reviewed by Adam Barth.
3103
3104         commit-queue should upload failure diffs when tests flake
3105         https://bugs.webkit.org/show_bug.cgi?id=51051
3106
3107         To make this testable I needed to pipe FileSystem down onto tool.
3108         We've wanted it there for a long time anyway.
3109
3110         This patch is kinda a big hack.  But we don't have a nice
3111         way to read results.html files.  I think this will need further
3112         revision before this code actually feels clean.
3113
3114         As part of testing this change, I had to make MockBugzilla.create_bug
3115         actually return an id (like it should) which required updating
3116         a few other unit test results (for the better).
3117
3118         The results_matching_keys change in layouttestresults/rebasline
3119         was an alternate path which I decided not to use in the end, but
3120         I left the change as it seemed an improvement.
3121
3122         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3123         * Scripts/webkitpy/common/net/layouttestresults.py:
3124         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3125         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3126         * Scripts/webkitpy/tool/commands/queues.py:
3127         * Scripts/webkitpy/tool/commands/rebaseline.py:
3128         * Scripts/webkitpy/tool/main.py:
3129         * Scripts/webkitpy/tool/mocktool.py:
3130
3131 2010-12-15  Cosmin Truta  <ctruta@chromium.org>
3132
3133         Reviewed by James Robinson.
3134
3135         new-run-webkit-tests ignores trailing EOL differences in text tests
3136         https://bugs.webkit.org/show_bug.cgi?id=36983
3137
3138         Changed the handling of new-line characters within new-run-webkit-tests
3139         to match old-run-webkit-tests.  Differences in leading and trailing empty
3140         lines in text expectation files are no longer ignored.
3141
3142         * Scripts/webkitpy/layout_tests/port/base.py:
3143         * Scripts/webkitpy/layout_tests/port/test.py:
3144         Added unit tests.  Removed old duplicate unit test entries.
3145         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3146
3147 2010-12-15  Ojan Vafai  <ojan@chromium.org>
3148
3149         Reviewed by Adam Barth.
3150
3151         make status-bubble white-space:nowrap so we can measure it's width without wrapping
3152         https://bugs.webkit.org/show_bug.cgi?id=51149
3153
3154         * QueueStatusServer/templates/statusbubble.html:
3155
3156 2010-12-15  Ojan Vafai  <ojan@chromium.org>
3157
3158         Reviewed by Adam Barth.
3159
3160         have the statusbubble postMessage it's metrics so that embedders can properly size the iframe
3161         https://bugs.webkit.org/show_bug.cgi?id=51125
3162
3163         * QueueStatusServer/templates/statusbubble.html:
3164
3165 2010-12-15  Darin Adler  <darin@apple.com>
3166
3167         * Scripts/webkitpy/common/net/buildbot: Added property svn:ignore.
3168
3169 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
3170
3171         Unreviewed, rolling out r74117.
3172         http://trac.webkit.org/changeset/74117
3173         https://bugs.webkit.org/show_bug.cgi?id=51113
3174
3175         This broke the GTK1 build. (Requested by mrobinson on
3176         #webkit).
3177
3178         * Scripts/webkitdirs.pm:
3179
3180 2010-12-15  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>
3181
3182         Reviewed by Martin Robinson.
3183
3184         Change generate-forwarding-headers.pl for GTK port usage 
3185         (https://bugs.webkit.org/show_bug.cgi?id=37369)
3186
3187         * Scripts/webkitdirs.pm: Added changes to build webkit2 for GTK port using build-webkit script.
3188
3189 2010-12-14  Kent Tamura  <tkent@chromium.org>
3190
3191         Reviewed by Jian Li.
3192
3193         [DRT/Chromium] Remove another unnecessary error message
3194         https://bugs.webkit.org/show_bug.cgi?id=51083
3195
3196         * DumpRenderTree/chromium/WebViewHost.cpp:
3197         (WebViewHost::didInvalidateRect):
3198
3199 2010-12-14  Lucas Forschler  <lforschler@apple.com>
3200
3201         Reviewed by Stephanie Lewis.
3202
3203         Add a new Leopard Debug Test WK2 Bot
3204
3205         * BuildSlaveSupport/build.webkit.org-config/config.json:
3206
3207 2010-12-14  Ojan Vafai  <ojan@chromium.org>
3208
3209         Fix python unittests after http://trac.webkit.org/changeset/74070.
3210
3211         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3212
3213 2010-12-14  Kent Tamura  <tkent@chromium.org>
3214
3215         Reviewed by Jian Li.
3216
3217         [DRT/Chromium] Remove a unnecessary error message
3218         https://bugs.webkit.org/show_bug.cgi?id=51069
3219
3220         * DumpRenderTree/chromium/WebViewHost.cpp:
3221         (WebViewHost::paintInvalidatedRegion):
3222
3223 2010-12-14  Benjamin Kalman  <kalman@chromium.org>
3224
3225         Reviewed by Ojan Vafai.
3226
3227         Using BUG/BUGWK in test_expectations is error prone, should use BUGCR/BUGWK
3228         https://bugs.webkit.org/show_bug.cgi?id=48926
3229
3230         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3231         Add presubmit check that BUG isn't used, either BUGCR/BUGWK/BUGV8_.
3232
3233 2010-12-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3234
3235         Reviewed by Eric Seidel.
3236
3237         [Qt] [Symbian] Do not use pkg-config on Symbian as it is not supported
3238         https://bugs.webkit.org/show_bug.cgi?id=50231
3239
3240         Guard CONFIG+=link_pkgconfig with !symbian.
3241
3242         * DumpRenderTree/qt/DumpRenderTree.pro:
3243         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3244         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3245
3246 2010-12-14  Philippe Normand  <pnormand@igalia.com>
3247
3248         Reviewed by Ojan Vafai.
3249
3250         [new-run-webkit-tests] expectations parsing is slow
3251         https://bugs.webkit.org/show_bug.cgi?id=50635
3252
3253         Avoid expensive iteration of all the tests when checking if a test
3254         file is to be skipped or not.
3255
3256         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3257         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3258         * Scripts/webkitpy/layout_tests/port/test.py:
3259
3260 2010-12-14  Mario Sanchez Prada  <msanchez@igalia.com>
3261
3262         Reviewed by Xan Lopez.
3263
3264         [Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding events for text objects
3265         https://bugs.webkit.org/show_bug.cgi?id=27048
3266
3267         Add support in DRT for checking whether an accessibility UI
3268         element is focusable and/or focused. Implemented for GTK.
3269
3270         * DumpRenderTree/AccessibilityUIElement.cpp:
3271         (getIsFocusedCallback): New.
3272         (getIsFocusableCallback): New.
3273         (AccessibilityUIElement::getJSClass): Add the new available
3274         callbacks for isFocused and isFocusable.
3275         * DumpRenderTree/AccessibilityUIElement.h:
3276         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3277         (AccessibilityUIElement::isFocused): New, implemented by checking
3278         whether the related AtkState value is in the object's state set.
3279         (AccessibilityUIElement::isFocusable): Ditto.
3280         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3281         (AccessibilityUIElement::isFocused): New, dummy implementation.
3282         (AccessibilityUIElement::isFocusable): Ditto.
3283         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3284         (AccessibilityUIElement::isFocused): Ditto.
3285         (AccessibilityUIElement::isFocusable): Ditto.
3286
3287 2010-12-14  Eric Seidel  <eric@webkit.org>
3288
3289         Reviewed by Ojan Vafai.
3290
3291         webkit-patch should warn users when they're using a 32-bit git on a 64-bit system
3292         https://bugs.webkit.org/show_bug.cgi?id=50715
3293
3294         This patch makes webkit-patch print the following:
3295
3296         Warning: This machine is 64-bit, but the git binary (/usr/local/git/bin/git) does not support 64-bit.
3297         Install a 64-bit git for better performance, see:
3298         https://lists.webkit.org/pipermail/webkit-dev/2010-December/015249.html
3299
3300         I wrote this mostly because I have approximately 8 machines that I use
3301         and making sure each one is using a good Git install seemed folly.
3302         webkit-patch makes a lot of git calls, so using a fast git can shave
3303         several seconds in every invocation.  See the webkit-dev thread for more info.
3304
3305         This message will print twice during 'webkit-patch upload',
3306         once from webkit-patch and once from check-webkit-style.
3307
3308         Unfortunately there is no good way to test this due to how machine-dependent
3309         the code is.  I considered writing a test for the log message, but it seemed not worth it.
3310
3311         * Scripts/webkitpy/common/checkout/scm.py:
3312
3313 2010-12-13  Eric Seidel  <eric@webkit.org>
3314
3315         Reviewed by Adam Barth.
3316
3317         FlakyTestReporter doesn't understand bots running from multiple email addresses
3318         https://bugs.webkit.org/show_bug.cgi?id=50960
3319
3320         This explains at least one of the dupes of:
3321         https://bugs.webkit.org/show_bug.cgi?id=50863
3322         that we saw filed by the commit-queue this morning.
3323         I think the other one was explained by my previous fix to result counting code.
3324
3325         Since this is really hard to test with a unit test, instead I
3326         create a new (possibly useful in the future) command
3327         which given a layout test path will return you
3328         the one bug which our tools would assume it the flaky test bug.
3329         If some other script wants to use bug-for-test we'll
3330         need to extend it with some options like --create-if-missing or similar.
3331
3332         * Scripts/webkitpy/common/net/bugzilla/bug.py:
3333         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3334         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3335         * Scripts/webkitpy/tool/commands/__init__.py:
3336         * Scripts/webkitpy/tool/commands/bugfortest.py: Added.
3337
3338 2010-12-13  Mihai Parparita  <mihaip@chromium.org>
3339
3340         Reviewed by James Robinson.
3341
3342         Add option to build-webkit to not build WebKit2
3343         https://bugs.webkit.org/show_bug.cgi?id=50988
3344         
3345         Add support for a --no-webkit2 option to build-webkit. It seems to save
3346         ~1 minute from clean builds and ~10 seconds from no-op builds.
3347
3348         * Scripts/build-webkit:
3349
3350 2010-12-13  Lucas Forschler  <lforschler@apple.com>
3351
3352         Reviewed by Dave Kilzer.
3353
3354         Update iexploder from 1.3.2 to 1.7.2
3355         Move 1.3.2 into its own subdir
3356         Add 1.7.2 into its own subdir
3357         update scripts to point to new 1.3.2 location (avoid breaking existing scripts)
3358
3359         * Scripts/run-iexploder-tests:
3360         * Scripts/update-iexploder-cssproperties:
3361         * iExploder/CHANGELOG.txt: Removed.
3362         * iExploder/LICENSE.txt: Removed.
3363         * iExploder/README.txt: Removed.
3364         * iExploder/htdocs: Removed.
3365         * iExploder/iexploder-1.3.2: Added.
3366         * iExploder/iexploder-1.3.2/CHANGELOG.txt: Copied from iExploder/CHANGELOG.txt.
3367         * iExploder/iexploder-1.3.2/LICENSE.txt: Copied from iExploder/LICENSE.txt.
3368         * iExploder/iexploder-1.3.2/README.txt: Copied from iExploder/README.txt.
3369         * iExploder/iexploder-1.3.2/htdocs: Added.
3370         * iExploder/iexploder-1.3.2/htdocs/config.rb: Copied from iExploder/htdocs/config.rb.
3371         * iExploder/iexploder-1.3.2/htdocs/cssproperties.in: Copied from iExploder/htdocs/cssproperties.in.
3372         * iExploder/iexploder-1.3.2/htdocs/cssvalues.in: Copied from iExploder/htdocs/cssvalues.in.
3373         * iExploder/iexploder-1.3.2/htdocs/htmlattrs.in: Copied from iExploder/htdocs/htmlattrs.in.
3374         * iExploder/iexploder-1.3.2/htdocs/htmltags.in: Copied from iExploder/htdocs/htmltags.in.
3375         * iExploder/iexploder-1.3.2/htdocs/htmlvalues.in: Copied from iExploder/htdocs/htmlvalues.in.
3376         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi: Copied from iExploder/htdocs/iexploder.cgi.
3377         * iExploder/iexploder-1.3.2/htdocs/iexploder.rb: Copied from iExploder/htdocs/iexploder.rb.
3378         * iExploder/iexploder-1.3.2/htdocs/index.html: Copied from iExploder/htdocs/index.html.
3379         * iExploder/iexploder-1.3.2/htdocs/webserver.rb: Copied from iExploder/htdocs/webserver.rb.
3380         * iExploder/iexploder-1.3.2/tools: Added.
3381         * iExploder/iexploder-1.3.2/tools/lasthit.rb: Copied from iExploder/tools/lasthit.rb.
3382         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb: Copied from iExploder/tools/osx_last_crash.rb.
3383         * iExploder/iexploder-1.3.2/tools/showtest.rb: Copied from iExploder/tools/showtest.rb.
3384         * iExploder/iexploder-1.7.2: Added.
3385         * iExploder/iexploder-1.7.2/ChangeLog.txt: Added.
3386         * iExploder/iexploder-1.7.2/LICENSE.txt: Added.
3387         * iExploder/iexploder-1.7.2/README.txt: Added.
3388         * iExploder/iexploder-1.7.2/output: Added.
3389         * iExploder/iexploder-1.7.2/src: Added.
3390         * iExploder/iexploder-1.7.2/src/browser_harness.rb: Added.
3391         * iExploder/iexploder-1.7.2/src/config.yaml: Added.
3392         * iExploder/iexploder-1.7.2/src/css-atrules: Added.
3393         * iExploder/iexploder-1.7.2/src/css-atrules/mozilla: Added.
3394         * iExploder/iexploder-1.7.2/src/css-atrules/webkit: Added.
3395         * iExploder/iexploder-1.7.2/src/css-properties: Added.
3396         * iExploder/iexploder-1.7.2/src/css-properties/dillo: Added.
3397         * iExploder/iexploder-1.7.2/src/css-properties/gtkhtml: Added.
3398         * iExploder/iexploder-1.7.2/src/css-properties/internet_explorer6: Added.
3399         * iExploder/iexploder-1.7.2/src/css-properties/mozilla: Added.
3400         * iExploder/iexploder-1.7.2/src/css-properties/webkit: Added.
3401         * iExploder/iexploder-1.7.2/src/css-pseudo: Added.
3402         * iExploder/iexploder-1.7.2/src/css-pseudo/mozilla: Added.
3403         * iExploder/iexploder-1.7.2/src/css-pseudo/webkit: Added.
3404         * iExploder/iexploder-1.7.2/src/css-values: Added.
3405         * iExploder/iexploder-1.7.2/src/css-values/dillo: Added.
3406         * iExploder/iexploder-1.7.2/src/css-values/gtkhtml: Added.
3407         * iExploder/iexploder-1.7.2/src/css-values/mozilla: Added.
3408         * iExploder/iexploder-1.7.2/src/css-values/other: Added.
3409         * iExploder/iexploder-1.7.2/src/css-values/webkit: Added.
3410         * iExploder/iexploder-1.7.2/src/headers: Added.
3411         * iExploder/iexploder-1.7.2/src/headers/dillo: Added.
3412         * iExploder/iexploder-1.7.2/src/headers/gtkhtml: Added.
3413         * iExploder/iexploder-1.7.2/src/headers/mozilla: Added.
3414         * iExploder/iexploder-1.7.2/src/headers/webkit: Added.
3415         * iExploder/iexploder-1.7.2/src/html-attrs: Added.
3416         * iExploder/iexploder-1.7.2/src/html-attrs/dillo: Added.
3417         * iExploder/iexploder-1.7.2/src/html-attrs/gtkhtml: Added.
3418         * iExploder/iexploder-1.7.2/src/html-attrs/internet_explorer6: Added.
3419         * iExploder/iexploder-1.7.2/src/html-attrs/mozilla: Added.
3420         * iExploder/iexploder-1.7.2/src/html-attrs/other: Added.
3421         * iExploder/iexploder-1.7.2/src/html-attrs/webkit: Added.
3422         * iExploder/iexploder-1.7.2/src/html-tags: Added.
3423         * iExploder/iexploder-1.7.2/src/html-tags/dillo: Added.
3424         * iExploder/iexploder-1.7.2/src/html-tags/gtkhtml: Added.
3425         * iExploder/iexploder-1.7.2/src/html-tags/mozilla: Added.
3426         * iExploder/iexploder-1.7.2/src/html-tags/other: Added.
3427         * iExploder/iexploder-1.7.2/src/html-tags/webkit: Added.
3428         * iExploder/iexploder-1.7.2/src/html-values: Added.
3429         * iExploder/iexploder-1.7.2/src/html-values/dillo: Added.
3430         * iExploder/iexploder-1.7.2/src/html-values/gtkhtml: Added.
3431         * iExploder/iexploder-1.7.2/src/html-values/mozilla: Added.
3432         * iExploder/iexploder-1.7.2/src/html-values/other: Added.
3433         * iExploder/iexploder-1.7.2/src/html-values/webkit: Added.
3434         * iExploder/iexploder-1.7.2/src/iexploder.cgi: Added.
3435         * iExploder/iexploder-1.7.2/src/iexploder.rb: Added.
3436         * iExploder/iexploder-1.7.2/src/index.html: Added.
3437         * iExploder/iexploder-1.7.2/src/media: Added.
3438         * iExploder/iexploder-1.7.2/src/media/blank.ogg: Added.
3439         * iExploder/iexploder-1.7.2/src/media/blank.snd: Added.
3440         * iExploder/iexploder-1.7.2/src/media/blank.wav: Added.
3441         * iExploder/iexploder-1.7.2/src/media/bug.bmp: Added.
3442         * iExploder/iexploder-1.7.2/src/media/bug.gif: Added.
3443         * iExploder/iexploder-1.7.2/src/media/bug.ico: Added.
3444         * iExploder/iexploder-1.7.2/src/media/bug.jng: Added.
3445         * iExploder/iexploder-1.7.2/src/media/bug.jpg: Added.
3446         * iExploder/iexploder-1.7.2/src/media/bug.png: Added.
3447         * iExploder/iexploder-1.7.2/src/media/bug.svg: Added.
3448         * iExploder/iexploder-1.7.2/src/media/bug.tiff: Added.
3449         * iExploder/iexploder-1.7.2/src/media/bug.xbm: Added.
3450         * iExploder/iexploder-1.7.2/src/media/bug.xpm: Added.
3451         * iExploder/iexploder-1.7.2/src/mime-types: Added.
3452         * iExploder/iexploder-1.7.2/src/mime-types/dillo: Added.
3453         * iExploder/iexploder-1.7.2/src/mime-types/mozilla: Added.
3454         * iExploder/iexploder-1.7.2/src/mime-types/webkit: Added.
3455         * iExploder/iexploder-1.7.2/src/protocols: Added.
3456         * iExploder/iexploder-1.7.2/src/protocols/dillo: Added.
3457         * iExploder/iexploder-1.7.2/src/protocols/gtkhtml: Added.
3458         * iExploder/iexploder-1.7.2/src/protocols/mozilla: Added.
3459         * iExploder/iexploder-1.7.2/src/protocols/webkit: Added.
3460         * iExploder/iexploder-1.7.2/src/scanner.rb: Added.
3461         * iExploder/iexploder-1.7.2/src/version.rb: Added.
3462         * iExploder/iexploder-1.7.2/src/webserver.rb: Added.
3463         * iExploder/iexploder-1.7.2/testcases: Added.
3464         * iExploder/iexploder-1.7.2/testcases/testcase-Linux_x86_64_rv2.0b6pre_Gecko-20100904_Firefox-4.0b6pre-TEST-8375-1_59.html: Added.
3465         * iExploder/iexploder-1.7.2/testcases/testcase-Opera-9.80_Linux_x86_64_en_Presto-2.6.30_Version-10.61-16704-3_108,3.html: Added.
3466         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_Chrome-7.0.529.0-TEST-611-3_36,9.html: Added.
3467         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_hrome-7.0.529.0-TEST-55313622206-3_6,0.html: Added.
3468         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-120813-8_72,56,24,8,0.html: Added.
3469         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-121240-3_81,3.html: Added.
3470         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-4800-5_80,65,15.html: Added.
3471         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-TEST-23583190347-3_15,12.html: Added.
3472         * iExploder/iexploder-1.7.2/tools: Added.
3473         * iExploder/iexploder-1.7.2/tools/lasthit.rb: Added.
3474         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb: Added.
3475         * iExploder/iexploder-1.7.2/tools/release_src.sh: Added.
3476         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added.
3477         * iExploder/tools: Removed.
3478
3479 2010-12-13  Sam Weinig  <sam@webkit.org>
3480
3481         Reviewed by Anders Carlsson.
3482
3483         Remove associated page concept from WKView constructor
3484         https://bugs.webkit.org/show_bug.cgi?id=50983
3485
3486         Step 1: Remove associate page constructors from WKView and make
3487         all views use the shared namespace for the context.
3488
3489         * TestWebKitAPI/PlatformWebView.h:
3490         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3491         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3492         * WebKitTestRunner/PlatformWebView.h:
3493         * WebKitTestRunner/TestController.cpp:
3494         (WTR::createOtherPage):
3495         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3496         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3497         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3498
3499 2010-12-13  Sam Weinig  <sam@webkit.org>
3500
3501         Reviewed by Anders Carlsson.
3502
3503         Change the WebKit2 public API so there is no explicit WKPageNamespace object
3504         https://bugs.webkit.org/show_bug.cgi?id=50898
3505
3506         * MiniBrowser/mac/AppDelegate.h:
3507         * MiniBrowser/mac/AppDelegate.m:
3508         * MiniBrowser/mac/BrowserWindowController.h:
3509         * MiniBrowser/mac/BrowserWindowController.m:
3510         * MiniBrowser/win/BrowserView.cpp:
3511         Convert MiniBrowser to not use PageNamespaces.
3512
3513         * TestWebKitAPI/PlatformWebView.h:
3514         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
3515         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
3516         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
3517         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
3518         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
3519         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
3520         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
3521         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3522         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3523         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
3524         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
3525         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
3526         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
3527         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3528         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3529         Convert TestWebKitAPI to not use PageNamespaces.
3530
3531         * WebKitTestRunner/PlatformWebView.h:
3532         * WebKitTestRunner/TestController.cpp:
3533         * WebKitTestRunner/TestController.h:
3534         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3535         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3536         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3537         Convert WebKitTestRunner to not use PageNamespaces.
3538
3539 2010-12-13  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3540
3541         Reviewed by Eric Seidel.
3542
3543         webkit-patch rollout should be able to do multi-revision rollouts
3544         https://bugs.webkit.org/show_bug.cgi?id=33336
3545
3546         Make it possible to pass more than one revision to webkit-patch.
3547
3548         * Scripts/webkitpy/common/checkout/api.py:
3549         * Scripts/webkitpy/common/checkout/changelog.py:
3550         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3551         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
3552         * Scripts/webkitpy/tool/commands/download.py:
3553         * Scripts/webkitpy/tool/commands/download_unittest.py:
3554         * Scripts/webkitpy/tool/mocktool.py:
3555         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
3556         * Scripts/webkitpy/tool/steps/revertrevision.py:
3557
3558 2010-12-13  Eric Seidel  <eric@webkit.org>
3559
3560         Unreviewed.
3561
3562         Teach webkit-patch how to search bugzilla
3563         https://bugs.webkit.org/show_bug.cgi?id=50500
3564
3565         webkit-patch bug-search fails when there is only one result.
3566         Turns out we needed a bit more logic in our result count parsing code.
3567
3568         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3569         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3570
3571 2010-12-13  Antti Koivisto  <antti@apple.com>
3572
3573         Reviewed by Alexey Proskuryakov.
3574
3575         Add setSerializeHTTPLoads function to allow testing resource load order on OS X.
3576         https://bugs.webkit.org/show_bug.cgi?id=50758
3577
3578         * DumpRenderTree/LayoutTestController.cpp:
3579         (setSerializeHTTPLoadsCallback):
3580         (LayoutTestController::staticFunctions):
3581         * DumpRenderTree/LayoutTestController.h:
3582         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3583         (LayoutTestController::setSerializeHTTPLoads):
3584         * DumpRenderTree/mac/DumpRenderTree.mm:
3585         (resetDefaultsToConsistentValues):
3586         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3587         (LayoutTestController::setSerializeHTTPLoads):
3588         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3589         (LayoutTestController::setSerializeHTTPLoads):
3590
3591 2010-12-13  Dimitri Glazkov  <dglazkov@chromium.org>
3592
3593         Reviewed by Ojan Vafai.
3594
3595         Remove "use-drt" option from test step command line, since the option was removed in r73748.
3596         https://bugs.webkit.org/show_bug.cgi?id=50936
3597
3598         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed the option.
3599
3600 2010-12-13  Patrick Gansterer  <paroga@webkit.org>
3601
3602         Reviewed by Csaba Osztrogonác.
3603
3604         Add revlink to BuildBot status
3605         https://bugs.webkit.org/show_bug.cgi?id=50914
3606
3607         This adds a hyperlink to trac changeset on the revision numbers. 
3608
3609         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3610
3611 2010-12-13  Andras Becsi  <abecsi@webkit.org>
3612
3613         Reviewed by Csaba Osztrogonác.
3614
3615         [Qt][WK2] Fix build if WebKitTools are not available
3616         https://bugs.webkit.org/show_bug.cgi?id=50242
3617
3618         * MiniBrowser/qt/MiniBrowser.pro: Correct the comment.
3619         * Scripts/webkitdirs.pm: Added WebKitTools/MiniBrowser to $subdirs.
3620         * MiniBrowser/DerivedSources.pro: Added.
3621
3622 2010-12-13  Eric Seidel  <eric@webkit.org>
3623
3624         Reviewed by Adam Barth.
3625
3626         EWS Queues should remove orpahned pyc files before starting
3627         https://bugs.webkit.org/show_bug.cgi?id=50904
3628
3629         A previous check added a platform.py which caused
3630         EWS bots on some platforms to hit an import exception.
3631         The platform.py file was removed in a subsequent commit, but
3632         the EWS bots in question stayed stuck.  This change will
3633         fix those bots once restarted (and prevent this in the future).
3634
3635         I also went ahead and unified start-queue and start-commit-queue
3636         since they were nearly identical.  I also added bot_id support
3637         to both force all EWSes to have bot ids as well as get rid of the one
3638         remaining reason why I had my own copies of these scripts.
3639         Hopefully this will be enough to get all the other bot admins
3640         (ahem, Adam, ahem) to move to using these checked in copies as well.
3641
3642         * EWSTools/start-commit-queue.sh: Removed.
3643         * EWSTools/start-queue.sh:
3644
3645 2010-10-28  MORITA Hajime  <morrita@google.com>
3646
3647         Reviewed by Ojan Vafai.
3648
3649         spellcheck does not check pasted text
3650         https://bugs.webkit.org/show_bug.cgi?id=40092
3651
3652         Added LayoutTestController::setAsynchronousSpellCheckingEnabled()
3653         to control the setting.
3654
3655         * DumpRenderTree/LayoutTestController.cpp:
3656         (setAsynchronousSpellCheckingEnabledCallback):
3657         (LayoutTestController::staticFunctions):
3658         * DumpRenderTree/LayoutTestController.h:
3659         * DumpRenderTree/chromium/LayoutTestController.h:
3660         * DumpRenderTree/chromium/LayoutTestController.cpp:
3661         (LayoutTestController::LayoutTestController):
3662         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
3663         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3664         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
3665         * DumpRenderTree/mac/DumpRenderTree.mm:
3666         (resetDefaultsToConsistentValues):
3667         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3668         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
3669         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3670         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3671         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
3672         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3673         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
3674         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3675         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
3676
3677 2010-12-12  Sam Weinig  <sam@webkit.org>
3678
3679         Reviewed by Anders Carlsson.
3680
3681         Fix failing API test. It turns out that a pop-state event
3682         is sent before every fragment navigation, so we have to test
3683         for it in addition in PageLoadDidChangeLocationWithinPageForFrame.
3684
3685         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3686         (TestWebKitAPI::didSameDocumentNavigationForFrame):
3687
3688 2010-12-12  Alejandro G. Castro  <alex@igalia.com>
3689
3690         Reviewed by Eric Seidel.
3691
3692         [GTK] Add new-run-webkit-tests support to gtk
3693         https://bugs.webkit.org/show_bug.cgi?id=50681
3694
3695         Adding the basic support to run the new-run-webkit-tests.
3696
3697         * Scripts/webkitpy/layout_tests/port/gtk.py:
3698
3699 2010-10-11  Diego Gonzalez  <diegohcg@webkit.org>
3700
3701         Reviewed by Kenneth Rohde Christiansen.
3702
3703         [Qt] Mock DeviceOrientation client for DRT
3704         https://bugs.webkit.org/show_bug.cgi?id=47490
3705
3706         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3707         (WebCore::DumpRenderTree::DumpRenderTree):
3708         (WebCore::DumpRenderTree::~DumpRenderTree):
3709         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3710         (LayoutTestController::setMockDeviceOrientation):
3711
3712 2010-12-11  Philippe Normand  <pnormand@igalia.com>
3713
3714         Reviewed by Gustavo Noronha Silva.
3715
3716         [GTK] launcher: disable the Mozilla-style fullscreen API
3717         https://bugs.webkit.org/show_bug.cgi?id=50874
3718
3719         Disabling the fullscreen API until its implementation for GTK is
3720         mature enough. The webview setting for it is already FALSE by
3721         default.
3722
3723         * GtkLauncher/main.c:
3724         (createWindow):
3725
3726 2010-12-10  Eric Seidel  <eric@webkit.org>
3727
3728         Reviewed by Adam Barth.
3729
3730         commit-queue flaky test messages show cryptic version information for mac os x
3731         https://bugs.webkit.org/show_bug.cgi?id=50864
3732
3733         Turns out platform.platform() returns kernel version information
3734         which isn't helpful, and just plain confusing on Mac
3735         (OS X 10.6.5 uses Darwin Kernel 10.5.0).
3736
3737         So I've updated PlatformInfo.display_name() to special case
3738         mac.  I also found a bad use of sys.platform in the process
3739         and fixed that.  (sys.platform always returns 'darwin' on mac).
3740
3741         * Scripts/webkitpy/common/system/platforminfo.py:
3742         * Scripts/webkitpy/common/system/user.py:
3743         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3744         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3745         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3746
3747 2010-12-10  Eric Seidel  <eric@webkit.org>
3748
3749         Unreviewed.
3750
3751         Exception seen while reporting flaky test with commit-queue.
3752         Just a missing include.
3753
3754         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3755         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3756
3757 2010-12-10  Kinuko Yasuda  <kinuko@chromium.org>
3758
3759         Reviewed by Eric Seidel.
3760
3761         [Chromium] Remove old JSONResultsGenerator script that existed for backward-compatibility
3762         https://bugs.webkit.org/show_bug.cgi?id=50796
3763
3764         Also updating the test code to use JSONResultsGeneratorBase and
3765         to improve test coverage for incremental cases.
3766
3767         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3768         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3769
3770 2010-12-10  Joseph Pecoraro  <joepeck@webkit.org>
3771
3772         Reviewed by Darin Adler.
3773
3774         prepare-ChangeLog --help doesn't mention --bug shorthand -b
3775         https://bugs.webkit.org/show_bug.cgi?id=50835
3776
3777         * Scripts/prepare-ChangeLog: be more explicit about -b and match file style.
3778
3779 2010-12-10  Eric Seidel  <eric@webkit.org>
3780
3781         Reviewed by Adam Barth.
3782
3783         Bugs created by the commit-queue should all block on a master bug
3784         https://bugs.webkit.org/show_bug.cgi?id=50857
3785
3786         This makes all bugs created by the commit-queue block on:
3787         https://bugs.webkit.org/show_bug.cgi?id=50856
3788
3789         In the process of testing this, I found that the existing
3790         create_bug code was wrong.  I also found that existing
3791         unit tests for create-rollout used invalid values
3792         for options.blocks.  I fixed both issues and tested.
3793
3794         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3795         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3796         * Scripts/webkitpy/tool/commands/commandtest.py:
3797         * Scripts/webkitpy/tool/commands/download_unittest.py:
3798         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3799         * Scripts/webkitpy/tool/mocktool.py:
3800         * Scripts/webkitpy/tool/steps/options.py:
3801
3802 2010-12-10  Eric Seidel  <eric@webkit.org>
3803
3804         Reviewed by Adam Barth.
3805
3806         Teach webkitpy how to follow duplicate chains when posting comments on flake bugs
3807         https://bugs.webkit.org/show_bug.cgi?id=50853
3808
3809         I also discovered when doing this that the code was posting
3810         the comment on the wrong bug, but that's fixed here too.
3811
3812         * Scripts/webkitpy/common/net/bugzilla/bug.py:
3813         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3814         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3815         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3816         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3817         * Scripts/webkitpy/tool/mocktool.py:
3818
3819 2010-12-10  Anders Carlsson  <andersca@apple.com>
3820
3821         Reviewed by John Sullivan.
3822
3823         Make WKContextGetStatistics gather global statistics
3824         https://bugs.webkit.org/show_bug.cgi?id=50850
3825
3826         Remove the code that gets the statistics and fills in the per context
3827         statistics information for now.
3828
3829         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
3830         (-[BrowserStatisticsWindowController refreshStatistics:]):
3831
3832 2010-12-10  Eric Seidel  <eric@webkit.org>
3833
3834         Unreviewed.
3835
3836         commit-queue should report port/platform information when commenting on flaky test bugs
3837         https://bugs.webkit.org/show_bug.cgi?id=50839
3838
3839         Renamed platform.py to platforminfo.py.  This broke import platform in executive.py
3840         which was only used by new run webkit tests (and clearly not unit tested).
3841
3842         * Scripts/webkitpy/common/system/platforminfo.py: Renamed from WebKitTools/Scripts/webkitpy/common/system/platform.py.
3843         * Scripts/webkitpy/tool/main.py:
3844         * Scripts/webkitpy/tool/mocktool.py:
3845
3846 2010-12-10  Eric Seidel  <eric@webkit.org>
3847
3848         Reviewed by Tony Chang.
3849
3850         commit-queue should report port/platform information when commenting on flaky test bugs
3851         https://bugs.webkit.org/show_bug.cgi?id=50839
3852
3853         This was a suggestion from Tony Chang this morning.
3854         I added a platform.py class so I could easily mock the platform call,
3855         but that may not be the final solution for this mocking.
3856         We'll try it and see.
3857
3858         * Scripts/webkitpy/common/system/platform.py: Added.
3859         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3860         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3861         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3862         * Scripts/webkitpy/tool/main.py:
3863         * Scripts/webkitpy/tool/mocktool.py:
3864
3865 2010-12-10  Krithigassree Sambamurthy  <krithigassree.sambamurthy@nokia.com>
3866
3867         Reviewed by Joseph Pecoraro.
3868
3869         Bug 43455 - [Qt]: Implement Application Cache Quotas
3870         https://bugs.webkit.org/show_bug.cgi?id=43455
3871
3872         Introduce functions to allow new appcache layout test origin-quota.html
3873         to work correctly under Qt.
3874
3875         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3876         (WebCore::DumpRenderTree::DumpRenderTree):
3877         (WebCore::DumpRenderTree::dumpApplicationCacheQuota):
3878         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3879
3880         Introduce functions to allow new appcache layout test origin-quota.html
3881         to be successful under qt. Changes required because LayoutTestControllerQt
3882         does not inherit from LayoutController.
3883
3884         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3885         (LayoutTestController::reset):
3886         (LayoutTestController::clearAllApplicationCaches):
3887         (LayoutTestController::setApplicationCacheOriginQuota):
3888         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3889         (LayoutTestController::shouldDumpApplicationCacheDelegateCallbacks):
3890         (LayoutTestController::dumpApplicationCacheDelegateCallbacks):
3891
3892 2010-12-10  Eric Seidel  <eric@webkit.org>
3893
3894         Reviewed by Adam Barth.
3895
3896         Move buildbot.py into its own module so we can split it out into one-file-per-class
3897         https://bugs.webkit.org/show_bug.cgi?id=50806
3898
3899         We're adding more buildbot logic these days, so it makes sense
3900         to give buildbot its own module.
3901
3902         * Scripts/webkitpy/common/net/buildbot/__init__.py: Added.
3903         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot.py.
3904         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot_unittest.py.
3905         * Scripts/webkitpy/common/net/failuremap.py:
3906         * Scripts/webkitpy/common/net/regressionwindow.py:
3907         * Scripts/webkitpy/tool/commands/rebaseline.py:
3908
3909 2010-12-10  Tony Chang  <tony@chromium.org>
3910
3911         Reviewed by Eric Seidel.
3912
3913         Use FileSystem::remove when cleaning up http lock files
3914         https://bugs.webkit.org/show_bug.cgi?id=50830
3915
3916         * Scripts/webkitpy/layout_tests/port/http_lock.py:
3917
3918 2010-12-10  Joone Hur  <joone@kldp.org>
3919
3920         Reviewed by Martin Robinson.
3921
3922         [GTK] DRT needs layoutTestController.setCacheModel
3923         https://bugs.webkit.org/show_bug.cgi?id=50705
3924         
3925         webkit_set_cache_mode() is called to set the cache model.
3926         
3927         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3928         (LayoutTestController::setCacheModel): Set the cache model. 
3929
3930 2010-12-10  Tony Chang  <tony@chromium.org>
3931
3932         Reviewed by Ojan Vafai.
3933
3934         [chromium] remove --use-drt and add --use-test-shell
3935         https://bugs.webkit.org/show_bug.cgi?id=50701
3936
3937         * Scripts/webkitpy/common/config/ports.py:
3938         * Scripts/webkitpy/common/config/ports_unittest.py:
3939         * Scripts/webkitpy/layout_tests/port/chromium.py:
3940         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3941         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3942         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3943         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3944         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3945         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3946         * Scripts/webkitpy/layout_tests/port/webkit.py:
3947         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3948         * Scripts/webkitpy/style/checkers/test_expectations.py:
3949         * Scripts/webkitpy/tool/commands/queries.py:
3950
3951 2010-12-10  John Knottenbelt  <jknotten@chromium.org>
3952
3953         Reviewed by Steve Block.
3954
3955         [Chromium] Implement mocks for client-based geolocation
3956         https://bugs.webkit.org/show_bug.cgi?id=46895
3957
3958         * DumpRenderTree/chromium/LayoutTestController.cpp:
3959         (LayoutTestController::setGeolocationPermission):
3960         (LayoutTestController::setMockGeolocationPosition):
3961         (LayoutTestController::setMockGeolocationError):
3962         * DumpRenderTree/chromium/LayoutTestController.h:
3963         * DumpRenderTree/chromium/WebViewHost.cpp:
3964         (WebViewHost::geolocationClient):
3965         (WebViewHost::geolocationClientMock):
3966         (WebViewHost::reset):
3967         * DumpRenderTree/chromium/WebViewHost.h:
3968
3969 2010-12-10  Alejandro G. Castro  <alex@igalia.com>
3970
3971         Reviewed by Martin Robinson.
3972
3973         [GTK] Add hasSpellingMarker support to the DRT
3974         https://bugs.webkit.org/show_bug.cgi?id=50739
3975
3976         Implemented the hasSpellingMarker to support spelling tests.
3977
3978         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3979         (LayoutTestController::hasSpellingMarker):
3980
3981 2010-12-10  Eric Seidel  <eric@webkit.org>
3982
3983         Reviewed by Ojan Vafai.
3984
3985         webkit-patch: not possible to use build-and-test with local commits
3986         https://bugs.webkit.org/show_bug.cgi?id=33378
3987
3988         Make --no-clean not even check if we have local commits.
3989         It's unclear to me why the code was originally written this way.
3990         I was unable to dig up a reason from svn history.
3991
3992         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
3993         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
3994
3995 2010-12-10  Mario Sanchez Prada  <msanchez@igalia.com>
3996
3997         Reviewed by Martin Robinson.
3998
3999         [GTK] AX: implement isEnabled in DRT
4000         https://bugs.webkit.org/show_bug.cgi?id=50814
4001
4002         Implement AccessibilityUIElement::isEnabled() for GTK.
4003
4004         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
4005         (checkElementState): New function to refactor common code.
4006         (AccessibilityUIElement::isEnabled): Implement this by checking
4007         the current state of the AtkObject.
4008         (AccessibilityUIElement::isSelected): Use the new
4009         checkElementState function.
4010
4011 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
4012
4013         Reviewed by Kenneth Rohde Christiansen.
4014
4015         [Qt][WK2] Add the QWKContext API class to wrap the WebContext.
4016         https://bugs.webkit.org/show_bug.cgi?id=50750
4017
4018         * MiniBrowser/qt/BrowserView.cpp:
4019         (BrowserView::BrowserView):
4020         * MiniBrowser/qt/BrowserView.h:
4021         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
4022         (WTR::WebView::WebView):
4023
4024 2010-12-10  Joone Hur  <joone@kldp.org>
4025
4026         Reviewed by Xan Lopez.
4027
4028         [GTK] Unskipping some test cases in userscripts dependent on addUserStyleSheet
4029         https://bugs.webkit.org/show_bug.cgi?id=50808
4030
4031         Unskipping the following test cases:
4032         userscripts/mixed-case-stylesheet.html
4033         userscripts/simple-stylesheet.html
4034         userscripts/user-style-all-frames.html
4035
4036         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4037         (LayoutTestController::addUserStyleSheet):
4038
4039 2010-12-10  Joone Hur  <joone@kldp.org>
4040
4041         Reviewed by Eric Seidel.
4042
4043         [GTK] Add DRT support for pageProperty, isPageBoxVisible, pageSizeAndMarginsInPixels, and addUserStyleSheet
4044         https://bugs.webkit.org/show_bug.cgi?id=50783
4045
4046         This patch allows to unskip the following test cases:
4047         printing/page-rule-selection.html
4048         printing/page-format-data.html
4049
4050         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4051         (LayoutTestController::pageProperty): Added.
4052         (LayoutTestController::isPageBoxVisible): Ditto.
4053         (LayoutTestController::pageSizeAndMarginsInPixels): Ditto.
4054         (LayoutTestController::addUserStyleSheet): Ditto.
4055
4056 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
4057
4058         Reviewed by Kenneth Rohde Christiansen.
4059
4060         [Qt] Make QtTestBrowser spawn QNAM in a secondary thread.
4061
4062         A menu allows to switch QNAM back to the same thread.
4063
4064         * QtTestBrowser/launcherwindow.cpp:
4065         (LauncherWindow::initializeView):
4066         (LauncherWindow::createChrome):
4067         (LauncherWindow::toggleThreadedQnam):
4068         * QtTestBrowser/launcherwindow.h:
4069         (WindowOptions::WindowOptions):
4070         * QtTestBrowser/webpage.cpp:
4071         (WebPage::WebPage):
4072         (WebPage::setQnamThreaded):
4073         * QtTestBrowser/webpage.h:
4074         (QnamThread::QnamThread):
4075         (QnamThread::~QnamThread):
4076         (QnamThread::networkAccessManager):
4077         (QnamThread::run):
4078
4079 2010-12-10  Martin Robinson  <mrobinson@igalia.com>
4080
4081         Reviewed by Xan Lopez.
4082
4083         [Gtk] style="font-family: courier" makes text disappear
4084         https://bugs.webkit.org/show_bug.cgi?id=47452
4085
4086         Add a test that verifies that fonts without valid charmaps are
4087         never selected.
4088
4089         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4090         (initializeFonts): Initialize DRT with our font (derived from Ahem)
4091         that has no valid charmap.
4092         * DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon: Added.
4093         * DumpRenderTree/gtk/fonts/fonts.conf: Updated settings to override users'
4094         settings which may disable selection of bitmap fonts.
4095
4096 2010-12-10  Eric Seidel  <eric@webkit.org>
4097
4098         Unreviewed.
4099
4100         The commit-queue should file bugs about flaky tests it encounters
4101         https://bugs.webkit.org/show_bug.cgi?id=50803
4102
4103         create_bug_for_flaky_test was insufficiently tested, thus buggy.
4104         Now it's tested.
4105
4106         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
4107         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
4108
4109 2010-12-10  Eric Seidel  <eric@webkit.org>
4110
4111         Unreviewed.  Somehow this last-minute edit didn't quite get committed.
4112
4113         The commit-queue should file bugs about flaky tests it encounters
4114         https://bugs.webkit.org/show_bug.cgi?id=50803
4115
4116         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
4117
4118 2010-12-09  Eric Seidel  <eric@webkit.org>
4119
4120         Reviewed by Adam Barth.
4121
4122         The commit-queue should file bugs about flaky tests it encounters
4123         https://bugs.webkit.org/show_bug.cgi?id=50803
4124
4125         This change got a bit big.  I also added a new config.urls file
4126         because I needed to share the view_source_url code with committervalidator.py.
4127
4128         This adds a new class FlakyTestReporter which holds all the logic about
4129         reporting flaky tests to bugzilla.
4130
4131         Right now this code knows how to look up bugs for flaky tests.
4132         If it can't find a bug filed from the commit-queue, it will open a new
4133         one, ccing the relevant people and adding information about the failure.
4134
4135         It is not yet smart enough to chase down duplicate chains, or to include
4136         the actual failure diff.  But those can be added in later iterations.
4137
4138         * Scripts/webkitpy/common/checkout/api.py:
4139         * Scripts/webkitpy/common/checkout/changelog.py:
4140         * Scripts/webkitpy/common/checkout/commitinfo.py:
4141         * Scripts/webkitpy/common/config/committervalidator.py:
4142         * Scripts/webkitpy/common/config/urls.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
4143         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
4144         * Scripts/webkitpy/tool/bot/flakytestreporter.py: Added.
4145         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
4146         * Scripts/webkitpy/tool/bot/irc_command.py:
4147         * Scripts/webkitpy/tool/bot/sheriff.py:
4148         * Scripts/webkitpy/tool/commands/download.py:
4149         * Scripts/webkitpy/tool/commands/queues.py:
4150         * Scripts/webkitpy/tool/commands/queues_unittest.py:
4151         * Scripts/webkitpy/tool/comments.py:
4152         * Scripts/webkitpy/tool/mocktool.py:
4153         * Scripts/webkitpy/tool/steps/commit.py:
4154
4155 2010-12-09  Eric Seidel  <eric@webkit.org>
4156
4157         Reviewed by Adam Barth.
4158
4159         Teach webkit-patch how to search bugzilla
4160         https://bugs.webkit.org/show_bug.cgi?id=50500
4161
4162         This is a step towards teaching webkitpy how to file
4163         new bugs for flaky tests and update them when new flakes occur.
4164
4165         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
4166         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
4167         * Scripts/webkitpy/tool/commands/__init__.py:
4168         * Scripts/webkitpy/tool/commands/bugsearch.py: Added.
4169
4170 2010-12-09  Adam Barth  <abarth@webkit.org>
4171
4172         Reviewed by Ojan Vafai.
4173
4174         commit-queue errors out due to local commits
4175         https://bugs.webkit.org/show_bug.cgi?id=50766
4176
4177         We seem to be tripping over having local commits in the working copy a
4178         lot recently.  I don't quite fully understand what the issue is, but
4179         this patch attempts to solve the problem by adding an explicit clean
4180         step before processing a patch.  Previously, we did the cleaning as
4181         part of the apply-attachment step, so this might not actually fix the
4182         problem.
4183
4184         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
4185         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
4186         * Scripts/webkitpy/tool/commands/queues_unittest.py:
4187
4188 2010-12-09  Dirk Pranke  <dpranke@chromium.org>
4189
4190         Reviewed by Ojan Vafai.
4191
4192         Make new-run-webkit-tests --lint-test-files log slightly better
4193         messages and return -1 if lint fails. Remove the
4194         'suppress_errors' keyword param to the TestExpectationsFile
4195         class, and clean up logging and exception raising for error
4196         handling. Also add more unit tests and clean up the unit test code a bit.
4197
4198         https://bugs.webkit.org/show_bug.cgi?id=50205
4199
4200         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4201         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
4202         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py
4203         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py
4204         * Scripts/webkitpy/layout_tests/port/chromium.py:
4205         * Scripts/webkitpy/style/checkers/test_expectations.py:
4206         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
4207
4208 2010-12-09  Tony Chang  <tony@chromium.org>
4209
4210         Unreviewed, fix for windows code.  We were catching the wrong
4211         exception in Windows.
4212
4213         * Scripts/webkitpy/common/system/filesystem.py:
4214
4215 2010-12-09  Antonio Gomes  <agomes@rim.com>
4216
4217         Reviewed by Martin Robinson.
4218
4219         [Gtk] Populate DumpRenderTreeSupportGtk (part IV)
4220         https://bugs.webkit.org/show_bug.cgi?id=48429
4221
4222         Adjust call sites of webkit_thread_count to use the DumpRenderTreeSupportGtk version now.
4223
4224         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4225         (LayoutTestController::workerThreadCount):
4226
4227 2010-12-06  Philippe Normand  <pnormand@igalia.com>
4228
4229         Reviewed by Martin Robinson.
4230
4231         [GTK] Support the Mozilla-style Fullscreen Javascript API
4232         https://bugs.webkit.org/show_bug.cgi?id=50572
4233
4234         Enable the Javascript Fullscreen support in the GtkLauncher. Also
4235         make DRT update the Chrome when the WebView settings have been
4236         reset to consistent values.
4237
4238         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4239         (resetDefaultsToConsistentValues):
4240         * GtkLauncher/main.c:
4241         (create_window):
4242         * Scripts/build-webkit:
4243
4244 2010-12-09  Koan-Sin Tan  <koansin.tan@gmail.com>
4245
4246         Reviewed by Tor Arne Vestbø
4247
4248         [Qt] run-launcher doesn't start the browser on Mac OS X 10.6
4249         https://bugs.webkit.org/show_bug.cgi?id=50742
4250
4251         check not only QtWebKit.framework/QtWebKit but also libQtWebKit.dylib
4252
4253         * Scripts/webkitdirs.pm:
4254
4255 2010-12-09  Joone Hur  <joone@kldp.org>
4256
4257          Reviewed by Martin Robinson.
4258
4259          [GTK] Support for viewport meta tag
4260          https://bugs.webkit.org/show_bug.cgi?id=45443
4261
4262          Add support for testing the viewport properties for WebKitGtk.
4263
4264          * DumpRenderTree/LayoutTestController.cpp:
4265          (dumpConfigurationForViewportCallback): Added this JS callback to set the size of the visible viewport.
4266          (LayoutTestController::staticFunctions):
4267          * DumpRenderTree/LayoutTestController.h:
4268          * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4269          (LayoutTestController::dumpConfigurationForViewport): Added this function to test the viewport properties.
4270          * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4271          (LayoutTestController::dumpConfigurationForViewport): Ditto.
4272          * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4273          (LayoutTestController::dumpConfigurationForViewport): Ditto.
4274          * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4275          (LayoutTestController::dumpConfigurationForViewport): Ditto.
4276          * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
4277          (LayoutTestController::dumpConfigurationForViewport): Ditto.
4278
4279 2010-12-08  William Siegrist <wsiegrist@apple.com>
4280
4281         Reviewed by Eric Seidel.
4282
4283         Migrate buildbot.py from xmlrpc to json.
4284         https://bugs.webkit.org/show_bug.cgi?id=50647
4285
4286         * Scripts/webkitpy/common/net/buildbot.py:
4287
4288 2010-12-08  Tony Chang  <tony@chromium.org>
4289
4290         Reviewed by Eric Seidel.
4291
4292         make starting the websocket server more reliable on windows
4293         https://bugs.webkit.org/show_bug.cgi?id=50712
4294
4295         * Scripts/webkitpy/common/system/filesystem.py:
4296         (remove): Substitute method for os.remove to retry on error on Windows
4297         * Scripts/webkitpy/common/system/filesystem_unittest.py:
4298         * Scripts/webkitpy/layout_tests/port/http_server_base.py: Use FileSystem.remove
4299
4300 2010-12-08  Jessie Berlin  <jberlin@apple.com>
4301
4302         Reviewed by Adam Roben.
4303
4304         WebKit2: Implement WebChromeClient::exceededDatabaseQuota
4305         https://bugs.webkit.org/show_bug.cgi?id=50656
4306
4307         * MiniBrowser/mac/BrowserWindowController.m:
4308         (-[BrowserWindowController awakeFromNib]):
4309         Indicate that exceededDatabaseQuota is not implemented.
4310         * MiniBrowser/win/BrowserView.cpp:
4311         (BrowserView::create):
4312         Ditto.
4313         * WebKitTestRunner/TestController.cpp:
4314         (WTR::createOtherPage):
4315         Ditto.
4316         (WTR::TestController::initialize):
4317         Ditto.
4318
4319 2010-12-08  Antonio Gomes  <agomes@rim.com>
4320
4321         Reviewed by Martin Robinson.
4322
4323         [Gtk] Populate DumpRenderTreeSupportGtk (part III)
4324         https://bugs.webkit.org/show_bug.cgi?id=48429
4325