29bce7d7f43414bb46b4f98be48c1e2671915e41
[WebKit-https.git] / Tools / ChangeLog
1 2011-12-22  Adam Roben  <aroben@apple.com>
2
3         Add a --xml flag to test-webkitpy
4
5         test-webkitpy --xml will, in addition to providing the standard text output on stdout, write
6         JUnit-style XML files to a test-webkitpy-xml-reports subdirectory in the working directory.
7         This is useful for working with tools that consume JUnit-style XML files.
8
9         Fixes <http://webkit.org/b/75090> Would like a way to generate JUnit-style XML files when
10         running test-webkitpy
11
12         Reviewed by Darin Adler.
13
14         * Scripts/webkitpy/test/main.py:
15         (Tester.run_tests): If the --xml flag is passed, create an XMLTestRunner and pass it to
16         unittest.main(). Otherwise pass no test runner so that unittest will choose its own default.
17
18         * Scripts/webkitpy/thirdparty/__init__.py:
19         (AutoinstallImportHook.find_module):
20         (AutoinstallImportHook._install_xmlrunner):
21         Added code to install unittest-xml-reporting as webkitpy.thirdparty.autoinstalled.xmlrunner.
22         This change is untested because it's basically impossible to get a test to pass when --xml
23         is passed to test-webkitpy (because xmlrunner will already have been imported by the time
24         the test runs).
25
26 2011-12-22  David Kilzer  <ddkilzer@apple.com>
27
28         TestWebKitAPI: initialize the main thread before running tests
29         <http://webkit.org/b/75064>
30
31         Reviewed by Adam Roben.
32
33         * TestWebKitAPI/TestsController.cpp:
34         (TestWebKitAPI::TestsController::TestsController): Call
35         WTF::initializeMainThread() to prevent assertions in Debug
36         builds.
37
38 2011-12-22  David Kilzer  <ddkilzer@apple.com>
39
40         run-api-tests: dumpAllTests() should not use global variables
41
42         Reviewed by Adam Roben.
43
44         Part of: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
45
46         * Scripts/run-api-tests: Renamed $dump to $dumpTests.
47         (dumpTestsBySuite): Rename from dumpAllTests() and pass in
48         global data as an argument.  Sort suite names and test names
49         alphabetically to match output when running tests.
50
51 2011-12-22  Leo Yang  <leo.yang@torchmobile.com.cn>
52
53         [BlackBerry] Enable blob for the BlackBerry porting
54         https://bugs.webkit.org/show_bug.cgi?id=75074
55
56         Reviewed by George Staikos.
57
58         * Scripts/build-webkit:
59
60 2011-12-22  Kentaro Hara  <haraken@chromium.org>
61
62         Add unittests for the Perl parser of prepare-ChangeLog
63         https://bugs.webkit.org/show_bug.cgi?id=74994
64
65         Reviewed by David Kilzer.
66
67         This patch adds unittests for get_function_line_ranges_for_perl() of prepare-ChangeLog.
68
69         Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl
70
71         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl: Added.
72         Runs unittests specified in @testFiles.
73         You can reset expected results by specifying a --reset-results option.
74         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl: Added.
75         Contains simple methods.
76         (func1):
77         (func2):
78         (func3):
79         (func4):
80         (func5):
81         (func6):
82         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt: Added.
83         This test result is generated by the --reset-results option.
84
85 2011-12-21  Eric Seidel  <eric@webkit.org>
86
87         Add webkit.review.bot@gmail.com and commit-queue@webkit.org as "contributors"
88         so that they appear in the bugzilla autocomplete CC list.
89         I also removed the "radar" irc nick (which I believe does not exist)
90         and removed the uneeded [] around the radar bugzilla email.
91
92         Unreviewed.
93
94         * Scripts/webkitpy/common/config/committers.py:
95
96 2011-12-21  Daniel Bates  <dbates@rim.com>
97
98         Teach build-jsc how to build JavaScriptCore for the EFL, BlackBerry, and WinCE ports
99         https://bugs.webkit.org/show_bug.cgi?id=74985
100
101         Reviewed by Eric Seidel.
102
103         * Scripts/build-jsc:
104         * Scripts/webkitdirs.pm:
105         (cmakeBasedPortName): Added.
106
107 2011-12-21  Daniel Bates  <dbates@rim.com>
108
109         Extract BlackBerry CMake arguments from build-webkit into separate function
110         https://bugs.webkit.org/show_bug.cgi?id=74981
111
112         Reviewed by Rob Buis.
113
114         Towards adding support for using Tools/Scripts/build-jsc for the BlackBerry port, move
115         the CMake argument logic from Tools/Scripts/build-webkit to function webkitdirs::blackberryCMakeArguments()
116         and have cmakeBasedPortArguments() call this function for the BlackBerry CMake argument list.
117         This will allow us to get the BlackBerry CMake arguments in Tools/Scripts/build-jsc so
118         that we can pass them to the CMake build system when building JavaScriptCore.
119
120         * Scripts/build-webkit: Move construction of CMake argument list from here to
121         webkitdirs::blackberryCMakeArguments(). Also, remove exported function blackberryTargetArchitecture()
122         since it's only called within webkitdirs.pm now. Formerly we exported this function so that we could
123         call it from build-webkit.
124         * Scripts/webkitdirs.pm:
125         (blackberryCMakeArguments): Added.
126         (cmakeBasedPortArguments): Modified to call blackberryCMakeArguments() when building the
127         BlackBerry port.
128
129 2011-12-21  Daniel Bates  <dbates@webkit.org>
130
131         Extract WinCE CMake arguments from build-webkit into separate function
132         https://bugs.webkit.org/show_bug.cgi?id=74983
133
134         Reviewed by Rob Buis.
135
136         Towards adding support for using Tools/Scripts/build-jsc for the WinCE port, extract the
137         WinCE-specific CMake argument from Tools/Scripts/build-webkit into webkitdirs::cmakeBasedPortArguments().
138         This will allow us to get the WinCE-specific CMake argument in Tools/Scripts/build-jsc so
139         that we can pass it to the CMake build system when building JavaScriptCore.
140
141         * Scripts/build-webkit:
142         * Scripts/webkitdirs.pm:
143         (cmakeBasedPortArguments): Added.
144
145 2011-12-21  Kentaro Hara  <haraken@chromium.org>
146
147         In prepare-ChangeLog, replace constant global variables with "use constant"
148         https://bugs.webkit.org/show_bug.cgi?id=74992
149
150         Reviewed by Ryosuke Niwa.
151
152         This patch replaces the following constant global variables with "use constant"s.
153             - $changeLogTimeZone
154             - $SVN
155             - $GIT
156             - %supportedTestExtensions
157
158         * Scripts/prepare-ChangeLog:
159         (changeLogNameFromArgs):
160         (changeLogEmailAddressFromArgs):
161         (resolveConflictedChangeLogs):
162         (generateNewChangeLogs):
163         (diffCommand):
164         (statusCommand):
165         (createPatchCommand):
166         (findOriginalFileFromSvn):
167         (determinePropertyChanges):
168         (generateFileList):
169         (reviewerAndDescriptionForGitCommit):
170
171 2011-12-20  Dirk Pranke  <dpranke@chromium.org>
172
173         nrwt: rename field references from _fs to _filesystem
174         https://bugs.webkit.org/show_bug.cgi?id=74898
175
176         Reviewed by Adam Barth.
177
178         This is a simple cleanup; most of the code uses
179         self._filesystem, but some used self._fs; this change renames
180         the latter to the former to be more consistent.
181
182         * Scripts/webkitpy/layout_tests/controllers/manager.py:
183         (Manager.__init__):
184         (Manager.collect_tests):
185         (Manager._strip_test_dir_prefix):
186         (Manager._split_into_chunks_if_necessary):
187         (Manager.results_directory):
188         (Manager._clobber_old_results):
189         (Manager._upload_json_files):
190         (Manager.print_config):
191         (Manager._copy_results_html_file):
192         (Manager._show_results_html_file):
193         (Manager._log_worker_stack):
194         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
195         (JSONLayoutResultsGenerator._normalize_results_json):
196         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
197         (JSONResultsGeneratorBase.__init__):
198         (JSONResultsGeneratorBase.generate_json_output):
199         (JSONResultsGeneratorBase.generate_times_ms_file):
200         (JSONResultsGeneratorBase.upload_json_files):
201         (JSONResultsGeneratorBase._get_svn_revision):
202         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
203         (Base.__init__):
204
205 2011-12-20  Kentaro Hara  <haraken@chromium.org>
206
207         Replace webkitperl/run-leaks_unittest/RunLeaks.pm with webkitperl/LoadAsModule.pm
208         https://bugs.webkit.org/show_bug.cgi?id=74836
209
210         Reviewed by David Kilzer.
211
212         webkitperl/run-leaks_unittest/RunLeaks.pm can be used for unit-testing of run-leaks only.
213         This patch creates more generalized webkitperl/LoadAsModule.pm, which can be also used
214         for unit-testing of other Perl scripts. We are planning to use it for unit-testing
215         of prepare-ChangeLog.
216
217         Using LoadAsModule.pm, you can load a Perl script as follows.
218         The first argument is the arbitrary package name you want to use, and the second argument
219         is the name of the Perl script you want to load.
220
221             use LoadAsModule qw(RunLeaks run-leaks);
222             RunLeaks::someFunctionDefinedInRunLeaks(...);
223
224         Tests: Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl
225                Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl
226                Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl
227
228         * Scripts/webkitperl/LoadAsModule.pm: Added.
229         * Scripts/webkitperl/run-leaks_unittest/RunLeaks.pm: Removed.
230         (import):
231         (readFile):
232         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl: Used LoadAsModule instead of RunLeaks.
233         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Ditto.
234         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Ditto.
235
236 2011-12-20  Balazs Kelemen  <kbalazs@webkit.org>
237
238         [Qt] WK2 Debugging quirks need some improvement
239         https://bugs.webkit.org/show_bug.cgi?id=74859
240
241         Reviewed by Simon Hausmann.
242
243         Improvements added to make debugging WebKit2 more
244         confortable and efficient:
245         1. Unify debugging quirks. From now all of them are controlled
246         by the QT_WEBKIT2_DEBUG environment variable.
247         2. Disable crash handlers for WebKitTestRunner if debugging quirks
248         are used to make it possible to use postmortem debugging via core dumps
249         which is extremely useful for debugging bugs triggered by layout tests.
250         3. Disable test timeout for WebKitTestRunner if debugging quirks
251         are used because that makes debugging impossible.
252
253         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
254         (WTR::InjectedBundle::platformInitialize):
255         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
256         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
257         * WebKitTestRunner/qt/TestControllerQt.cpp:
258         (WTR::TestController::platformRunUntil):
259
260 2011-12-20  Rafael Brandao  <rafael.lobo@openbossa.org>
261
262         [Qt][WK2] Implement favicon support
263         https://bugs.webkit.org/show_bug.cgi?id=71082
264
265         Reviewed by Simon Hausmann.
266
267         A favorite icon was added on MiniBrowser's url bar as example.
268         We display a default icon when the page doesn't have an icon ready.
269
270         * MiniBrowser/qt/MiniBrowser.qrc:
271         * MiniBrowser/qt/icons/favicon.png: Added.
272         * MiniBrowser/qt/qml/BrowserWindow.qml:
273
274 2011-12-19  Sam Weinig  <sam@webkit.org>
275
276         Add support for scrollLineDown: and scrollLineUp: NSResponder selectors
277         https://bugs.webkit.org/show_bug.cgi?id=74907
278
279         Reviewed by Dan Bernstein.
280
281         Add ScrollByLineCommands API test.
282
283         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
284         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm: Added.
285         * TestWebKitAPI/Tests/WebKit2/simple-tall.html: Added.
286
287 2011-12-19  Dirk Pranke  <dpranke@chromium.org>
288
289         webkitpy: remove port.executive, port.filesystem, port.user properties
290         https://bugs.webkit.org/show_bug.cgi?id=74896
291
292         Reviewed by Eric Seidel.
293
294         Following on the refactoring of the port and host objects, this
295         removes the public executive, filesystem, and user properties
296         from the Port interface (protected versions of executive and
297         filesystem still exist). There is still some more clean up to
298         make the code more consistent and rearrange some other files to
299         talk to Hosts directly instead of getting them off of the Port
300         class.
301
302         * Scripts/webkitpy/layout_tests/controllers/manager.py:
303         (Manager.__init__):
304         (Manager.results_directory):
305         (Manager._log_worker_stack):
306         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
307         (ManagerTest.test_fallback_path_in_config):
308         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
309         (_InlineManager.start_worker):
310         (_InlineWorkerConnection.__init__):
311         * Scripts/webkitpy/layout_tests/controllers/worker.py:
312         (Worker.safe_init):
313         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
314         (TestConfiguration.from_port):
315         * Scripts/webkitpy/layout_tests/port/base.py:
316         (Port.__init__):
317         (Port.tests):
318         (Port.show_results_html_file):
319         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
320         (PortTest.test_layout_tests_skipping):
321         (PortTest.test_test_dirs):
322         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
323         (_set_up_derived_options):
324         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
325         (PerfTestsRunner.__init__):
326         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
327         (HtmlGenerator.__init__):
328         (HtmlGenerator.show_html):
329         (real_main):
330         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
331         (TestHtmlGenerator.make_generator):
332
333 2011-12-19  Daniel Bates  <dbates@webkit.org>
334
335         Pass command line arguments to GDB when debugging a Mac WebKit application
336         https://bugs.webkit.org/show_bug.cgi?id=72829
337
338         Reviewed by David Kilzer.
339
340         Pass through any command line arguments given to debug-{safari, minibrowser}
341         to GDB so that they may influence the application instance launched by GDB.
342
343         * Scripts/webkitdirs.pm:
344         (execMacWebKitAppForDebugging):
345
346 2011-12-19  Dirk Pranke  <dpranke@chromium.org>
347
348         webkitpy: remove executive,filesystem,user parameters from Port constructor
349         https://bugs.webkit.org/show_bug.cgi?id=74878
350
351         Reviewed by Eric Seidel.
352
353         This change concludes the refactoring that makes Host a required
354         parameter for Port and ensures that all access to filesystem,
355         executives, etc. is going through the Host.
356
357         * Scripts/webkitpy/layout_tests/port/base.py:
358         (Port.__init__):
359
360 2011-12-19  Dirk Pranke  <dpranke@chromium.org>
361
362         webkitpy: finish refactoring port classes to make a host mandatory
363         https://bugs.webkit.org/show_bug.cgi?id=74566
364
365         Reviewed by Eric Seidel.
366
367         This change makes all Port objects take a required (System)Host
368         parameter, and updates the TestPort object to no longer create a
369         mock filesystem or add files to the existing filesystem by
370         default.
371
372         * Scripts/webkitpy/layout_tests/port/base.py:
373         (Port.__init__):
374         * Scripts/webkitpy/layout_tests/port/factory.py:
375         (PortFactory.__init__):
376         (PortFactory._get_kwargs):
377         * Scripts/webkitpy/layout_tests/port/test.py:
378         (TestInstance.__init__):
379         (TestPort.__init__):
380         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
381         (passing_run):
382         (logging_run):
383         (get_tests_run):
384         (MainTest.test_single_file):
385         (MainTest.test_stderr_is_saved):
386         (MainTest.test_test_list):
387         (MainTest.test_test_list_with_prefix):
388         (MainTest.test_missing_and_unexpected_results):
389         (MainTest.test_missing_and_unexpected_results_with_custom_exit_code):
390         (MainTest.test_crash_with_stderr):
391         (MainTest.test_no_image_failure_with_image_diff):
392         (MainTest.test_crash_log):
393         (MainTest.test_web_process_crash_log):
394         (MainTest.test_exit_after_n_failures_upload):
395         (MainTest.test_results_directory_absolute):
396         (MainTest.test_results_directory_relative):
397         (MainTest.test_retries_directory):
398         (MainTest.test_tolerance.get_port_for_run):
399         (MainTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
400         (EndToEndTest.test_end_to_end):
401         (EndToEndTest.test_reftest_with_two_notrefs):
402         (RebaselineTest.test_reset_results):
403         (RebaselineTest.test_missing_results):
404         (RebaselineTest.test_new_baseline):
405         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
406         (Rebaseliner.__init__):
407         (main):
408         (real_main):
409         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
410         (test_host_port_and_filesystem):
411         (TestRebaseliner.make_rebaseliner):
412         (TestRealMain.test_all_platforms):
413         (TestHtmlGenerator.make_generator):
414
415 2011-12-19  Dirk Pranke  <dpranke@chromium.org>
416
417         webkitpy: update unit tests in preparation for making host a mandatory parameter to Port objects
418         https://bugs.webkit.org/show_bug.cgi?id=74562
419
420         Reviewed by Eric Seidel.
421
422         Apart from a minor change to style/checkers/test_expectations.py
423         to take a host as a parameter to a TestExpectationsChecker(),
424         there are only refactoring changes to unit tests here.
425
426         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
427         (TestResultWriterTest.test_reftest_diff_image):
428         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
429         (JSONGeneratorTest._test_json_generation):
430         (JSONGeneratorTest.test_test_timings_trie):
431         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
432         (Base.__init__):
433         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
434         (PortTest.make_port):
435         (PortTest.test_layout_tests_skipping):
436         (PortTest.test_test_dirs):
437         (PortTest.test_additional_platform_directory):
438         (PortTest.test_uses_test_expectations_file):
439         (PortTest.test_find_no_paths_specified):
440         (PortTest.test_find_one_test):
441         (PortTest.test_find_glob):
442         (PortTest.test_find_with_skipped_directories):
443         (PortTest.test_find_with_skipped_directories_2):
444         (PortTest.test_parse_reftest_list):
445         * Scripts/webkitpy/layout_tests/port/dryrun.py:
446         (DryRunPort.__init__):
447         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
448         (FactoryTest.setUp):
449         (FactoryTest.tearDown):
450         (FactoryTest.assert_port):
451         (FactoryTest.assert_platform_port):
452         (FactoryTest.test_unknown_specified):
453         (FactoryTest.test_unknown_default):
454         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
455         (GetGoogleChromePortTest._verify_expectations_overrides):
456         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
457         (MockDRTPortTest.make_port):
458         (MockDRTTest.assertTest):
459         (MockDRTTest.test_main):
460         (MockChromiumDRTTest.test_pixeltest__fails):
461         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
462         (QtPortTest._assert_search_path):
463         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
464         (TestWebKitPort.__init__):
465         (WebKitPortTest.test_skipped_directories_for_symbols):
466         (test_skipped_directories_for_features):
467         (test_skipped_layout_tests):
468         (test_skipped_file_search_paths):
469         (test_root_option):
470         (test_test_expectations):
471         (test_build_driver):
472         (test_linux_distro_detection):
473         (test_apache_config_file_name_for_platform):
474         (test_path_to_apache_config_file):
475         (WebKitDriverTest.test_read_block):
476         * Scripts/webkitpy/style/checkers/test_expectations.py:
477         (TestExpectationsChecker.__init__):
478         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
479         (TestExpectationsTestCase._expect_port_for_expectations_path):
480         (TestExpectationsTestCase.assert_lines_lint):
481         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
482         (get_test_config.TestMacPort):
483
484 2011-12-19  Raphael Kubo da Costa  <kubo@profusion.mobi>
485
486         [Efl] Fix path returned by builtDylibPathForName in webkitdirs.pm
487         https://bugs.webkit.org/show_bug.cgi?id=74854
488
489         Reviewed by Csaba Osztrogonác.
490
491         Since r101052, libewebkit.so is built in a different location, so we
492         need to adjust the path returned by builtDylibPathForName.
493
494         usesPerConfigurationBuildDirectory also needs to be fixed, as the Efl
495         port also respects Release/Debug configurations.
496
497         These changes should make run-launcher finally work correctly with
498         webkit-efl.
499
500         * Scripts/webkitdirs.pm:
501         (usesPerConfigurationBuildDirectory):
502         (builtDylibPathForName):
503
504 2011-12-19  Simon Hausmann  <simon.hausmann@nokia.com>
505
506         [Qt][WK2] Add support for modal event loop processing for WTR
507         https://bugs.webkit.org/show_bug.cgi?id=74852
508
509         Reviewed by Kenneth Rohde Christiansen.
510
511         Rewrote event loop processing: Instead of terminating the event loop
512         in notifyDone() - something no other platform does - we now respect the
513         "bool& condition" parameter passed to platformRunUntil. This ensures
514         proper termination even when the condition is changed from within a
515         nested event loop, because only when we _exit_ from the nested event
516         loop we will check the condition and terminate the test properly.
517
518         In addition this patch implements TestController::runModal by means of
519         a nested event loop, which is passed to the platform webview that is
520         supposed to be modal. It is that view's responsibility to exit the
521         loop, upon destruction. I believe that's similar to how it works on the Mac,
522         where it doesn't seem that NSApp's runModalForWindow is terminate via
523         abort/stopModal but simply because the window is closed.
524
525         * WebKitTestRunner/PlatformWebView.h:
526         (WTR::PlatformWebView::setModalEventLoop):
527         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
528         (WTR::PlatformWebView::PlatformWebView):
529         (WTR::PlatformWebView::~PlatformWebView):
530         * WebKitTestRunner/qt/TestControllerQt.cpp:
531         (WTR::TestController::notifyDone):
532         (WTR::TestController::platformRunUntil):
533         (WTR::TestController::runModal):
534
535 2011-12-18  Kentaro Hara  <haraken@chromium.org>
536
537         REGRESSION(r103149): prepare-ChangeLog outputs a warning
538         https://bugs.webkit.org/show_bug.cgi?id=74808
539
540         Reviewed by David Kilzer.
541
542         Added the prototype declaration of main() to avoid warning messages.
543         Sorted subroutine declarations in the alphabetical order.
544
545         * Scripts/prepare-ChangeLog:
546
547 2011-12-17  Adenilson Cavalcanti  <cavalcantii@gmail.com>
548
549         [Qt] Fix QtTestBrowser compilation with QtWidgets module
550         https://bugs.webkit.org/show_bug.cgi?id=74791
551
552         Reviewed by Andreas Kling.
553
554         * QtTestBrowser/QtTestBrowser.pro:
555
556 2011-12-17  Kentaro Hara  <haraken@chromium.org>
557
558         Remove top-level code completely from prepare-ChangeLog
559         https://bugs.webkit.org/show_bug.cgi?id=74698
560
561         Reviewed by Darin Adler.
562
563         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest manner.
564         This patch just moves all top-level code into main().
565
566         * Scripts/prepare-ChangeLog:
567         (main):
568
569 2011-12-16  Dean Jackson  <dino@apple.com>
570
571         Move webkit-bug-importer to Contributor. It won't
572         autocomplete as an Account.
573         See https://bugs.webkit.org/show_bug.cgi?id=74739
574         for some discussion.
575
576         Unreviewed.
577
578         * Scripts/webkitpy/common/config/committers.py:
579
580 2011-12-16  Dean Jackson  <dino@apple.com>
581
582         Add webkit-bug-importer@group.apple.com to accounts
583         so that it autocompletes in bugzilla.
584
585         Unreviewed.
586
587         * Scripts/webkitpy/common/config/committers.py:
588
589 2011-12-16  Philippe Normand  <pnormand@igalia.com>
590
591         Unreviewed, skipping 3 failing GTK API tests.
592
593         * Scripts/run-gtk-tests:
594
595 2011-12-16  Philippe Normand  <pnormand@igalia.com>
596
597         Unreviewed, GTK API tests build fix attempt.
598
599         * Scripts/run-gtk-tests: Run xvfb on a display not used by NRWT.
600
601 2011-12-16  Philippe Normand  <pnormand@igalia.com>
602
603         Unreviewed, unskipping GTK testdownload. Should pass on the bot now.
604
605         * Scripts/run-gtk-tests:
606
607 2011-12-16  Simon Hausmann  <simon.hausmann@nokia.com>
608
609         [Qt] Fix the build for newer Qt5
610         https://bugs.webkit.org/show_bug.cgi?id=74703
611
612         Reviewed by Csaba Osztrogonác.
613
614         * QtTestBrowser/launcherwindow.h: Add missing forward declaration.
615         * DumpRenderTree/qt/EventSenderQt.cpp:
616         (EventSender::sendTouchEvent): Allocate QTouchDevice and use with QTouchEvent constructor.
617         * WebKitTestRunner/qt/EventSenderProxyQt.cpp: Ditto.
618         (WTR::EventSenderProxy::sendTouchEvent):
619         * MiniBrowser/qt/MiniBrowserApplication.cpp:
620         (MiniBrowserApplication::sendTouchEvent): Ditto.
621         (MiniBrowserApplication::notify): Adapt to changed API for marking primary touch point.
622
623 2011-12-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
624
625         [Qt] Detect and force clean build when feature defines are added
626
627         Reviewed by Ossy.
628
629         https://bugs.webkit.org/show_bug.cgi?id=74689
630
631         * Scripts/webkitdirs.pm:
632
633 2011-12-16  Kentaro Hara  <haraken@chromium.org>
634
635         [Refactoring] Remove all global variables from prepare-ChangeLog
636         https://bugs.webkit.org/show_bug.cgi?id=74681
637
638         Reviewed by Ryosuke Niwa.
639
640         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
641         manner. This bug is one of the incremental refactorings to remove all top-level
642         code and global variables from prepare-ChangeLog. In this patch,
643         we make the following global variables be used only through parameter passing.
644         This patch removes all global variables from prepare-ChangeLog.
645             - $mergeBase
646             - $gitCommit
647             - $gitIndex
648
649         * Scripts/prepare-ChangeLog:
650         (generateFunctionLists):
651         (changeLogNameFromArgs):
652         (changeLogEmailAddressFromArgs):
653         (generateNewChangeLogs):
654         (printDiff):
655         (diffFromToString):
656         (diffCommand):
657         (statusCommand):
658         (createPatchCommand):
659         (generateFileList):
660         (isConflictStatus):
661
662 2011-12-15  Philippe Normand  <pnormand@igalia.com>
663
664         [GTK] Rounding errors on 32-bit machines causes tests to fail
665         https://bugs.webkit.org/show_bug.cgi?id=72254
666
667         Initial patch by vanuan@gmail.com.
668         Reviewed by Martin Robinson.
669
670         * Scripts/webkitdirs.pm:
671         (runAutogenForAutotoolsProjectIfNecessary): Pass additional
672         CXXFLAGS to autogen in an attempt to harmonize floating point
673         values between 32-bit and 64-bit architectures.
674
675 2011-12-16  Martin Robinson  <mrobinson@igalia.com>
676
677         [GTK] Make distcheck fails during the install
678         https://bugs.webkit.org/show_bug.cgi?id=74274
679
680         No review, since this is a build fix.
681
682         * GNUmakefile.am: Remove BUILT_SOURCES from the dependency list for the gtkdoc
683         step. BUILT_SOURCES includes forwarding header generation for WebKit2, which
684         always runs. This means that the gtkdoc step was always running when make was
685         invoked. Generating gtkdoc during 'make install' was triggering a race condition
686         with the library file. Later we can fix generate-forwarding-headers and unbreak
687         'make docs,' but this bandaid is sufficient to let us release.
688
689 2011-12-15  Eric Seidel  <eric@webkit.org>
690
691         NRWT should use free + inactive memory for default_child_processes on OS X (and never return < 1 process)
692         https://bugs.webkit.org/show_bug.cgi?id=74650
693
694         Reviewed by Adam Barth.
695
696         * Scripts/webkitpy/common/system/platforminfo.py:
697         (PlatformInfo._compute_bytes_from_vm_stat_output):
698         * Scripts/webkitpy/layout_tests/port/base.py:
699         (Port.default_child_processes):
700         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
701         (PortTest.test_default_child_processes):
702
703 2011-12-15  Filip Pizlo  <fpizlo@apple.com>
704
705         bencher script should support remote benchmarking on platforms that don't have ruby
706         https://bugs.webkit.org/show_bug.cgi?id=74659
707
708         Rubber-stamped by Sam Weinig.
709         
710         Added the ability to have bencher generate a benchmarking playload that consists of
711         copies of all of the benchmarks, optionally copies of all of the frameworks and
712         binaries to run all of the VMs, and a sh script that runs the benchmarks in random
713         order, which then spits out a raw results file that bencher can parse.
714         
715         In normal operating mode, you never see this, as it just generates the payload and
716         script internally, runs it, parses the results, and spits them out.
717         
718         The --remote mode has been changed to use this style, so any remote host that has
719         sshd, passwordless login support, a ~/.bencher file that points to a "tempPath", and
720         a sh-compatible shell can be used for remote benchmarking.
721         
722         The feature to include VMs in the benchmarking payload is by default only activated
723         when using --remote, but it can also be activated when doing local benchmarking; the
724         benefit is that you remove any pathname-related performance pathologies. All VMs
725         become equal because they are all located in
726         /path/to/bencher/directory/temp/benchdata/vmN where N is the configuration number
727         (usually 0 or 1).
728         
729         Also fixed bugs in the DumpRenderTree support. It's now possible to run all benchmarks
730         through DumpRenderTree. This is only a bit slower than running in jsc.
731
732         * Scripts/bencher:
733
734 2011-12-15  Dirk Pranke  <dpranke@chromium.org>
735
736         webkitpy: clean up TestPort to (mostly) not create a new filesystem
737         https://bugs.webkit.org/show_bug.cgi?id=74556
738
739         This change modifies the TestPort to be ready to add tests to an
740         existing filesystem instead of creating a new filesystem; we
741         leave unit_test_filesystem() in for now for compatibility.
742
743         * Scripts/webkitpy/common/host_mock.py:
744         (MockHost.__init__):
745           - call add_unit_tests_to_mock_filesystem by default to make
746             the MockHost more generally useful for layout_test unit tests.
747         * Scripts/webkitpy/layout_tests/port/test.py:
748         (TestInstance.__init__):
749         (add_unit_tests_to_mock_filesystem):
750         (add_file):
751         (unit_test_filesystem):
752         (TestPort.__init__):
753         (TestPort._set_default_overriding_none):
754
755 2011-12-15  Dirk Pranke  <dpranke@chromium.org>
756
757         webkitpy: cleanup prior to systemhostifying the layout_test/port* classes
758         https://bugs.webkit.org/show_bug.cgi?id=74551
759
760         This is some minor cleanup prior to making all of the host/port
761         changes described in bug 74138.
762
763         * Scripts/webkitpy/common/host_mock.py:
764         (MockHost.__init__):
765           - make sure the scm object is initialized with the same mock
766             executive and filesystem objects.
767
768         * Scripts/webkitpy/common/system/filesystem_mock.py:
769         (MockFileSystem.clear_written_files):
770           - add a routine that will be useful in testing.
771         (MockFileSystem.maybe_make_directory):
772         (MockFileSystem.write_binary_file):
773           - fix bugs to make sure directories are created properly.
774         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
775         (_Process.run):
776           - add clarifying comments.
777         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
778         (MockDRTPort.__init__):
779         (MockDRT.__init__):
780           - add clarifying comments.
781
782 2011-12-15  Anders Carlsson  <andersca@apple.com>
783
784         Regression (r102866): Navigating away from or closing a page with a plugin crashes
785         https://bugs.webkit.org/show_bug.cgi?id=74655
786
787         Reviewed by Sam Weinig.
788
789         Add a bunch of tests.
790
791         * TestWebKitAPI/Tests/WTF/Functional.cpp:
792
793 2011-12-15  Stephanie Lewis  <slewis@apple.com>
794
795         https://bugs.webkit.org/show_bug.cgi?id=74469
796         Escape paths to svn commands so our tools can handle filenames with @ symbols.
797
798         Reviewed by Adam Roben.
799
800         * Scripts/VCSUtils.pm:
801         (scmMoveOrRenameFile):
802         (scmAddExecutableBit):
803         (scmRemoveExecutableBit):
804         (determineSVNRoot):
805         (svnRevisionForDirectory):
806         (pathRelativeToSVNRepositoryRootForPath):
807         (svnStatus):
808         (escapeSubversionPath):
809         * Scripts/parse-malloc-history:
810         (main):
811         * Scripts/prepare-ChangeLog:
812         (diffCommand):
813         (statusCommand):
814         (findOriginalFileFromSvn):
815         (determinePropertyChanges):
816         * Scripts/resolve-ChangeLogs:
817         (conflictFiles):
818         (resolveConflict):
819         (showStatus):
820         * Scripts/svn-apply:
821         (patch):
822         (scmCopy):
823         (scmAdd):
824         (scmRemove):
825         * Scripts/svn-create-patch:
826         (findBaseUrl):
827         (findMimeType):
828         (findSourceFileAndRevision):
829         (generateDiff):
830         (generateFileList):
831         (manufacturePatchForAdditionWithHistory):
832         * Scripts/svn-unapply:
833         (patch):
834         (revertDirectories):
835
836 2011-12-15  Michael Bruning  <michael.bruning@nokia.com>
837
838         [qt][wk2] MiniBrowser: Add pressed state for viewport info button.
839         https://bugs.webkit.org/show_bug.cgi?id=74617
840
841         Reviewed by Kenneth Rohde Christiansen.
842
843         * MiniBrowser/qt/qml/BrowserWindow.qml: Added state dependent coloring
844         for viewport info button, adjusted height and added rounded corners.
845
846 2011-12-15  Andy Estes  <aestes@apple.com>
847
848         TestFailures: store the name of the buildbot results directory in a property
849         https://bugs.webkit.org/show_bug.cgi?id=74663
850
851         Reviewed by Adam Barth.
852         
853         Store the name of the results directory as a property on Buildbot's
854         prototype. This allows subclasses of Buildbot to customize the results
855         directory.
856
857         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot.js:
858         (Buildbot.prototype.resultsDirectoryURL):
859
860 2011-12-15  Tony Chang  <tony@chromium.org>
861
862         [chromium] pass --delete_unversioned_trees to gclient on the bots
863         https://bugs.webkit.org/show_bug.cgi?id=74565
864
865         Reviewed by Kenneth Russell.
866
867         It was temporarily removed in r102891 to keep the bots green.  Now
868         that the bots have cycled, we can add it back.
869
870         * Scripts/update-webkit-chromium:
871
872 2011-12-15  Kentaro Hara  <haraken@chromium.org>
873
874         [Refactoring] In prepare-ChangeLog, make several global variables be used only through parameter passing
875         https://bugs.webkit.org/show_bug.cgi?id=74497
876
877         Reviewed by Ryosuke Niwa.
878
879         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
880         manner. This bug is one of the incremental refactorings to remove all top-level
881         code and global variables from prepare-ChangeLog. In this patch,
882         we make the following global variables be used only through parameter passing.
883             - $bugDescription
884             - $bugNumber
885             - $name
886             - $emailAddress
887             - $gitReviewer
888             - $writeChangeLogs
889
890         * Scripts/prepare-ChangeLog:
891         (fetchBugDescriptionFromURL):
892         (generateNewChangeLogs):
893         (reviewerAndDescriptionForGitCommit):
894
895 2011-12-15  Raphael Kubo da Costa  <kubo@profusion.mobi>
896
897         [EFL] Add a few more web database functions to ewk_settings.
898         https://bugs.webkit.org/show_bug.cgi?id=72148
899
900         Reviewed by Antonio Gomes.
901
902         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
903         (LayoutTestController::clearAllDatabases):
904         (LayoutTestController::setDatabaseQuota):
905
906 2011-12-15  Martin Kosiba  <mkosiba@google.com>
907
908         Fix find on web pages with -webkit-user-select: none for Chromium
909         https://bugs.webkit.org/show_bug.cgi?id=72281
910
911         Reviewed by Ryosuke Niwa.
912
913         Provided a partial findString implementation. This doesn't support
914         all of the FindOptions since they're not exposed via WebFindOptions.
915
916         * DumpRenderTree/chromium/LayoutTestController.cpp:
917         (LayoutTestController::LayoutTestController):
918         (LayoutTestController::findString):
919         * DumpRenderTree/chromium/LayoutTestController.h:
920
921 2011-12-15  Kenneth Russell  <kbr@google.com>
922
923         [chromium] Add DRT support for WebKitPageCacheSupportsPluginsPreferenceKey
924         https://bugs.webkit.org/show_bug.cgi?id=74581
925
926         Reviewed by Darin Fisher.
927
928         * DumpRenderTree/chromium/LayoutTestController.cpp:
929         (LayoutTestController::overridePreference):
930         * DumpRenderTree/chromium/WebPreferences.cpp:
931         (WebPreferences::reset):
932         (WebPreferences::applyTo):
933         * DumpRenderTree/chromium/WebPreferences.h:
934
935 2011-12-15  Kenneth Rohde Christiansen  <kenneth@webkit.org>
936
937         [Qt] Improve the look of the viewport info overlay
938
939         Reviewed by Tor Arne Vestbø.
940
941         * MiniBrowser/qt/qml/ViewportInfoItem.qml:
942
943 2011-12-15  Igor Oliveira  <igor.oliveira@openbossa.org>
944
945         [Qt] Support requestAnimationFrame API
946         https://bugs.webkit.org/show_bug.cgi?id=74528
947
948         Add build-option for requestAnimationFrame feature.
949
950         Reviewed by Kenneth Rohde Christiansen.
951
952         * qmake/mkspecs/features/features.prf:
953
954 2011-12-15  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
955
956         [Qt] Don't add WebCoreSupport and WebKit APIs to include WebCore's include path
957
958         Reviewed by Simon Hausmann.
959
960         * qmake/mkspecs/features/webcore.prf:
961
962 2011-12-15  Michael Brüning  <michael.bruning@nokia.com>
963
964         [QT][WK2]Add (experimental) viewport info view to Minibrowser/qt.
965         https://bugs.webkit.org/show_bug.cgi?id=72893
966
967         Reviewed by Kenneth Rohde Christiansen.
968
969         This patch extends QQuickWebViewExperimental by a property named
970         viewportInfo, which contains the viewport scalability and
971         layout and contents size information. This property is exposed to
972         QML through the experimental extension for QQuickWebView.
973
974         * MiniBrowser/qt/MiniBrowser.pro:
975         * MiniBrowser/qt/MiniBrowser.qrc:
976         * MiniBrowser/qt/icons/info.png: Added.
977         * MiniBrowser/qt/qml/BrowserWindow.qml:
978         * MiniBrowser/qt/qml/ViewportInfoItem.qml: Added.
979
980 2011-12-15  Shinya Kawanaka  <shinyak@google.com>
981
982         [chromium] WebViewHost::requestCheckingOfText should return immediately if text is empty.
983         https://bugs.webkit.org/show_bug.cgi?id=74586
984
985         Reviewed by Hajime Morita.
986
987         No new tests. Covered by existing tests.
988
989         * DumpRenderTree/chromium/WebViewHost.cpp:
990         (WebViewHost::requestCheckingOfText):
991           Returns immediately if text is empty.
992
993 2011-12-15  Alexander Færøy  <ahf@0x90.dk>
994
995         [Qt] QtWebKit fails to build on Mac OS X after r102776
996         https://bugs.webkit.org/show_bug.cgi?id=74593
997
998         Reviewed by Simon Hausmann.
999
1000         CONFIG =+ link_pkgconfig is needed such that the correct parameters
1001         are passed to the compiler.
1002
1003         * DumpRenderTree/qt/DumpRenderTree.pro:
1004
1005 2011-12-14  Tony Chang  <tony@chromium.org>
1006
1007         [chromium] Remove redundant third_party entries from chromium DEPS
1008         https://bugs.webkit.org/show_bug.cgi?id=74472
1009
1010         Reviewed by Kenneth Russell.
1011
1012         * Scripts/update-webkit-chromium: Temporarily keep unversioned trees.
1013
1014 2011-12-14  Kentaro Hara  <haraken@chromium.org>
1015
1016         [Refactoring] In prepare-ChangeLog, replace $isGit and $isSVN with
1017         VCSUtils::isGit() and VCSUtils::isSVN().
1018         https://bugs.webkit.org/show_bug.cgi?id=74485
1019
1020         Reviewed by David Kilzer.
1021
1022         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
1023         manner. This bug is one of the incremental refactorings to remove all top-level
1024         code and global variables from prepare-ChangeLog. This patch replaces $isGit and $isSVN
1025         with VCSUtils::isGit() and VCSUtils::isSVN(). This patch also removes firstDirectoryOrCwd(),
1026         assuming that no user will mix Git/SVN checkouts and thus we can judge SVN or Git
1027         just by looking at the current working directory.
1028
1029         * Scripts/prepare-ChangeLog: Removed firstDirectoryOrCwd().
1030         (diffFromToString):
1031         (diffCommand):
1032         (statusCommand):
1033         (createPatchCommand):
1034         (diffHeaderFormat):
1035         (generateFileList):
1036         (isAddedStatus):
1037         (isConflictStatus):
1038         (statusDescription):
1039         (extractLineRange):
1040
1041 2011-12-14  Sam Weinig  <weinig@apple.com>
1042
1043         Remove whitespace from InheritedPropertySheets attributes in
1044         vsprops files to appease the Visual Studio project migrator.
1045
1046         Reviewed by Adam Roben.
1047
1048         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebug.vsprops:
1049         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugAll.vsprops:
1050         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugCairoCFLite.vsprops:
1051         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
1052         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops:
1053         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops:
1054         * DumpRenderTree/win/DumpRenderTreeDebug.vsprops:
1055         * DumpRenderTree/win/DumpRenderTreeDebugAll.vsprops:
1056         * DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops:
1057         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
1058         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops:
1059         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops:
1060         * DumpRenderTree/win/ImageDiffDebug.vsprops:
1061         * DumpRenderTree/win/ImageDiffDebugAll.vsprops:
1062         * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops:
1063         * DumpRenderTree/win/ImageDiffProduction.vsprops:
1064         * DumpRenderTree/win/ImageDiffRelease.vsprops:
1065         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops:
1066         * MiniBrowser/Configurations/MiniBrowserDebug.vsprops:
1067         * MiniBrowser/Configurations/MiniBrowserDebugAll.vsprops:
1068         * MiniBrowser/Configurations/MiniBrowserDebugCairoCFLite.vsprops:
1069         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
1070         * MiniBrowser/Configurations/MiniBrowserRelease.vsprops:
1071         * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops:
1072         * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops:
1073         * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops:
1074         * WebKitLauncherWin/WebKitLauncherWinDebug.vsprops:
1075         * WebKitLauncherWin/WebKitLauncherWinDebugAll.vsprops:
1076         * WebKitLauncherWin/WebKitLauncherWinDebugCairoCFLite.vsprops:
1077         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
1078         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops:
1079         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops:
1080         * WebKitTestRunner/win/InjectedBundleDebug.vsprops:
1081         * WebKitTestRunner/win/InjectedBundleDebugAll.vsprops:
1082         * WebKitTestRunner/win/InjectedBundleDebugCairoCFLite.vsprops:
1083         * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
1084         * WebKitTestRunner/win/InjectedBundleRelease.vsprops:
1085         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops:
1086         * WebKitTestRunner/win/WebKitTestRunnerDebug.vsprops:
1087         * WebKitTestRunner/win/WebKitTestRunnerDebugAll.vsprops:
1088         * WebKitTestRunner/win/WebKitTestRunnerDebugCairoCFLite.vsprops:
1089         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
1090         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops:
1091         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops:
1092         * WinLauncher/WinLauncherDebug.vsprops:
1093         * WinLauncher/WinLauncherDebugAll.vsprops:
1094         * WinLauncher/WinLauncherDebugCairoCFLite.vsprops:
1095         * WinLauncher/WinLauncherProduction.vsprops:
1096         * WinLauncher/WinLauncherRelease.vsprops:
1097         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops:
1098         * record-memory-win/record-memory-winDebug.vsprops:
1099         * record-memory-win/record-memory-winDebugAll.vsprops:
1100         * record-memory-win/record-memory-winDebugCairoCFLite.vsprops:
1101         * record-memory-win/record-memory-winProduction.vsprops:
1102         * record-memory-win/record-memory-winRelease.vsprops:
1103         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops:
1104
1105 2011-12-14  Anders Carlsson  <andersca@apple.com>
1106
1107         Windows build fix.
1108
1109         Move CHECKs out of the destructor.
1110
1111         * TestWebKitAPI/Tests/WTF/Functional.cpp:
1112         (TestWebKitAPI::B::~B):
1113         (TestWebKitAPI::TEST):
1114
1115 2011-12-14  Anders Carlsson  <andersca@apple.com>
1116
1117         binding a member function should ref/deref the object pointer if needed
1118         https://bugs.webkit.org/show_bug.cgi?id=74552
1119
1120         Reviewed by Sam Weinig.
1121
1122         Add new tests.
1123
1124         * TestWebKitAPI/Tests/WTF/Functional.cpp:
1125         (TestWebKitAPI::B::B):
1126         (TestWebKitAPI::B::~B):
1127         (TestWebKitAPI::B::ref):
1128         (TestWebKitAPI::B::deref):
1129         (TestWebKitAPI::B::f):
1130         (TestWebKitAPI::B::g):
1131         (TestWebKitAPI::TEST):
1132
1133 2011-12-14  Hajime Morrita  <morrita@chromium.org>
1134
1135         JS_INLINE and WTF_INLINE should be visible from WebCore
1136         https://bugs.webkit.org/show_bug.cgi?id=73191
1137
1138         Reviewed by Kevin Ollivier.
1139
1140         Removed macro definitions which is now provided by Platform.h
1141
1142         * DumpRenderTree/chromium/config.h:
1143         * DumpRenderTree/config.h:
1144         * DumpRenderTree/ForwardingHeaders/runtime/JSExportMacros.h: Added.
1145         * DumpRenderTree/ForwardingHeaders/wtf/ExportMacros.h: Added.
1146         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Add new ForwardingHeaders.
1147         * TestWebKitAPI/config.h:
1148         * WebKitTestRunner/config.h:
1149
1150 2011-12-14  Kentaro Hara  <haraken@chromium.org>
1151
1152         Unreviewed, rolling out r102761.
1153         http://trac.webkit.org/changeset/102761
1154         https://bugs.webkit.org/show_bug.cgi?id=74485
1155
1156         we came up with a better fix than this (see comments in bug
1157         74485)
1158
1159         * Scripts/prepare-ChangeLog:
1160         (generateFunctionLists):
1161         (printDiff):
1162         (diffCommand):
1163         (statusCommand):
1164         (createPatchCommand):
1165         (generateFileList):
1166         (isAddedStatus):
1167         (isConflictStatus):
1168         (statusDescription):
1169         (extractLineRange):
1170
1171 2011-12-14  Anders Carlsson  <andersca@apple.com>
1172
1173         Work around a bug in the MSVC2005 compiler
1174         https://bugs.webkit.org/show_bug.cgi?id=74550
1175
1176         Reviewed by Sam Weinig.
1177
1178         Re-enable tests.
1179
1180         * TestWebKitAPI/Tests/WTF/Functional.cpp:
1181
1182 2011-12-14  Csaba Osztrogonác  <ossy@webkit.org>
1183
1184         [Qt] Test fonts are not used with Qt5
1185         https://bugs.webkit.org/show_bug.cgi?id=72513
1186
1187         My last unreviewed buildfix for this crazy bug.
1188
1189         * qmake/mkspecs/features/features.prf:
1190
1191 2011-12-14  Anders Carlsson  <andersca@apple.com>
1192
1193         Another attempt at fixing the Windows build.
1194
1195         Disable all the tests until I can figure out what's going on here.
1196
1197         * TestWebKitAPI/Tests/WTF/Functional.cpp:
1198
1199 2011-12-14  Anders Carlsson  <andersca@apple.com>
1200
1201         Fix the Windows build.
1202
1203         Disable some of the tests for now.
1204
1205         * TestWebKitAPI/Tests/WTF/Functional.cpp:
1206
1207 2011-12-14  Anders Carlsson  <andersca@apple.com>
1208
1209         bind should handle member functions
1210         https://bugs.webkit.org/show_bug.cgi?id=74529
1211
1212         Reviewed by Sam Weinig.
1213
1214         Add tests.
1215
1216         * TestWebKitAPI/Tests/WTF/Functional.cpp:
1217         (TestWebKitAPI::A::A):
1218         (TestWebKitAPI::A::f):
1219         (TestWebKitAPI::A::addF):
1220         (TestWebKitAPI::TEST):
1221
1222 2011-12-14  Anders Carlsson  <andersca@apple.com>
1223
1224         Add unary and binary bind overloads
1225         https://bugs.webkit.org/show_bug.cgi?id=74524
1226
1227         Reviewed by Sam Weinig.
1228
1229         Add tests.
1230
1231         * TestWebKitAPI/Tests/WTF/Functional.cpp:
1232         (TestWebKitAPI::TEST):
1233         (TestWebKitAPI::multiplyByTwo):
1234         (TestWebKitAPI::multiplyByOneAndAHalf):
1235         (TestWebKitAPI::multiply):
1236         (TestWebKitAPI::subtract):
1237
1238 2011-12-14  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
1239
1240         [Qt] Test fonts are not used with Qt5
1241         https://bugs.webkit.org/show_bug.cgi?id=72513
1242
1243         MIPS and SH4 buildfix after r102776 and r102795.
1244
1245         Reviewed by Csaba Osztrogonác.
1246
1247         * qmake/mkspecs/features/features.prf:
1248
1249 2011-12-14  Csaba Osztrogonác  <ossy@webkit.org>
1250
1251         [Qt] Unreviewed speculative MIPS and SH4 buildfix after r102776.
1252
1253         * qmake/mkspecs/features/features.prf:
1254
1255 2011-12-14  Andreas Kling  <kling@webkit.org>
1256
1257         Make my e-mail address a little more awesome.
1258
1259         * Scripts/webkitpy/common/config/committers.py:
1260
1261 2011-12-14  Csaba Osztrogonác  <ossy@webkit.org>
1262
1263         [Qt] Rollout r102769, because it broke Qt-4.8 builds.
1264
1265         * qmake/mkspecs/features/webcore.prf:
1266
1267 2011-12-14  Balazs Kelemen  <kbalazs@webkit.org>
1268
1269         [Qt] Test fonts are not used with Qt5
1270         https://bugs.webkit.org/show_bug.cgi?id=72513
1271
1272         Reviewed by Simon Hausmann.
1273
1274         Don't depend on Q_WS_X11 anymore since it's not the Qt5
1275         way to detect the platform. Make the guards depend
1276         on our own configtest for fontconfig. For Qt4 we can still
1277         use the preassumption that we have it on Linux.
1278
1279         * DumpRenderTree/qt/DumpRenderTree.pro:
1280         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1281         (WebCore::DumpRenderTree::open):
1282         (WebCore::DumpRenderTree::initializeFonts):
1283         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1284         * DumpRenderTree/qt/main.cpp:
1285         (main): Additionally remove a nonsense piece of code that was
1286         trying to reset the font settings - which is not necessary -
1287         after we have already returned from main.
1288         * WebKitTestRunner/InjectedBundle/Target.pri:
1289         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1290         (WTR::activateFonts):
1291         * WebKitTestRunner/Target.pri: Remove unnecessary fontconfig linkage
1292         from WTR. It is not needed. We set up the fonts via the injected bundle.
1293         * qmake/config.tests/fontconfig/fontconfig.cpp: Added.
1294         (main):
1295         * qmake/config.tests/fontconfig/fontconfig.pro: Added.
1296         * qmake/mkspecs/features/features.prf:
1297         * qmake/sync.profile:
1298
1299 2011-12-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1300
1301         [Qt] Don't add WebCoreSupport and WebKit APIs to include WebCore's include path
1302
1303         Followup to r102679
1304
1305         https://bugs.webkit.org/show_bug.cgi?id=74413
1306
1307         Reviewed by Simon Hausmann.
1308
1309         * qmake/mkspecs/features/webcore.prf:
1310
1311 2011-12-14  Pierre Rossi  <pierre.rossi@gmail.com>
1312
1313         [Qt] Mobile theme could use a little refresh
1314         https://bugs.webkit.org/show_bug.cgi?id=74293
1315
1316         Have MiniBrowser use the mobile theme when not
1317         passed --desktop.
1318
1319         Reviewed by Kenneth Rohde Christiansen.
1320
1321         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1322         (MiniBrowserApplication::handleUserOptions):
1323
1324 2011-12-14  João Paulo Rechi Vita  <jprvita@openbossa.org>
1325
1326         [Qt] [Gardening] Remove qt-4.7 layout tests dir
1327         https://bugs.webkit.org/show_bug.cgi?id=74426
1328
1329         Building trunk now depends on Qt >= 4.8, so no need to keep this directory
1330         on the tree.
1331
1332         Reviewed by Csaba Osztrogonác.
1333
1334         * Scripts/webkitpy/layout_tests/port/qt.py:
1335         (QtPort.qt_version):
1336         (QtPort.baseline_search_path):
1337         (QtPort._skipped_file_search_paths):
1338         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1339         (QtPortTest._assert_search_path):
1340
1341 2011-12-14  Kentaro Hara  <haraken@chromium.org>
1342
1343         [Refactoring] In prepare-ChangeLog, make $isGit and $isSVN be used only
1344         through parameter passing
1345         https://bugs.webkit.org/show_bug.cgi?id=74485
1346
1347         Reviewed by Ryosuke Niwa.
1348
1349         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
1350         manner. This bug is one of the incremental refactorings to remove all top-level
1351         code and global variables from prepare-ChangeLog. In this patch,
1352         we make the following global variables be used only through parameter passing.
1353             - $isGit
1354             - $isSVN
1355
1356         * Scripts/prepare-ChangeLog:
1357         (generateFunctionLists):
1358         (printDiff):
1359         (diffFromToString):
1360         (diffCommand):
1361         (statusCommand):
1362         (createPatchCommand):
1363         (diffHeaderFormat):
1364         (generateFileList):
1365         (isAddedStatus):
1366         (isConflictStatus):
1367         (statusDescription):
1368         (extractLineRange):
1369
1370 2011-12-14  Alexander Færøy  <alexander.faeroy@nokia.com>
1371
1372         [Qt] DeviceOrientationClientMockQt should be removed in favor of DeviceOrientationClientMock
1373         https://bugs.webkit.org/show_bug.cgi?id=74417
1374
1375         Reviewed by Simon Hausmann.
1376
1377         Based on original patch by Kenneth Christiansen.
1378
1379         Already covered by current tests.
1380
1381         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1382         (WebCore::DumpRenderTree::DumpRenderTree):
1383         (WebCore::DumpRenderTree::~DumpRenderTree):
1384         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1385         (LayoutTestController::setMockDeviceOrientation):
1386
1387 2011-12-03  Philippe Normand  <pnormand@igalia.com>
1388
1389         [GTK] Bad text rendering since r101343
1390         https://bugs.webkit.org/show_bug.cgi?id=73744
1391
1392         Reviewed by Martin Robinson.
1393
1394         Turn cairo hint metrics off for better font metrics reporting in
1395         the tests. This is especially important for SVG.
1396
1397         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1398         (initializeGtkFontSettings):
1399         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1400         (WTR::initializeGtkSettings):
1401
1402 2011-12-13  Kentaro Hara  <haraken@chromium.org>
1403
1404         [Refactoring] Remove several global variables from prepare-ChangeLog
1405         https://bugs.webkit.org/show_bug.cgi?id=74389
1406
1407         Reviewed by David Kilzer.
1408
1409         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
1410         manner. This bug is one of the incremental refactorings to remove all top-level
1411         code and global variables from prepare-ChangeLog. In this patch,
1412         we make the following global variables being used only through parameter passing.
1413             - %paths
1414             - $changedFiles
1415             - $conflictFiles
1416             - $functionLists
1417             - $bugURL
1418
1419         * Scripts/prepare-ChangeLog:
1420         (findChangeLogs):
1421         (generateNewChangeLogs):
1422         (processPaths):
1423         (generateFileList):
1424         (firstDirectoryOrCwd):
1425
1426 2011-12-13  Anders Carlsson  <andersca@apple.com>
1427
1428         Add a very bare-bones implementation of bind and Function to WTF
1429         https://bugs.webkit.org/show_bug.cgi?id=74462
1430
1431         Reviewed by Sam Weinig.
1432
1433         Add basic tests for WTF::Function and WTF::bind.
1434
1435         * TestWebKitAPI/TestWebKitAPI.gypi:
1436         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1437         * TestWebKitAPI/Tests/Functional.cpp: Added.
1438         (TestWebKitAPI::returnFortyTwo):
1439         (TestWebKitAPI::TEST):
1440         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1441
1442 2011-12-13  Robin Dunn  <robin@alldunn.com>
1443
1444         [wx] Add a URL argument to wxWebView constructor.
1445         https://bugs.webkit.org/show_bug.cgi?id=74316
1446         
1447         Reviewed by Kevin Ollivier.
1448
1449         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
1450         (MyApp::OnInit):
1451         * wx/browser/browser.cpp:
1452         (MyApp::OnInit):
1453
1454 2011-12-13  Raphael Kubo da Costa  <kubo@profusion.mobi>
1455
1456         watchlist: Add watchlist for EFL, CMake and libsoup code and put myself on it.
1457         https://bugs.webkit.org/show_bug.cgi?id=74430
1458
1459         Reviewed by David Levin.
1460
1461         * Scripts/webkitpy/common/config/watchlist:
1462
1463 2011-12-13  Peter Beverloo  <peter@chromium.org>
1464
1465         [Chromium] Pull in FreeType and decrease check-out complexity for Android
1466         https://bugs.webkit.org/show_bug.cgi?id=74401
1467
1468         Decrease the check-out complexity by removing the need to first run
1469         "update-webkit-chromium --chromium" prior to running it with
1470         "--chromium-android", which was caused by an unversioned third_party/
1471         directory being created. This moves the Android NDK to Source/WebKit/
1472         chromium/, coming from third_party/ in that directory.
1473
1474         Reviewed by Adam Barth.
1475
1476         * Scripts/update-webkit-chromium:
1477         * Scripts/webkitdirs.pm:
1478         (buildChromiumMakefile):
1479
1480 2011-12-13  Andy Wingo  <wingo@igalia.com> and Martin Robinson <mrobinson@igalia.com>
1481
1482         build-jsc passing incorrect args to buildGtkProject
1483         https://bugs.webkit.org/show_bug.cgi?id=74308
1484
1485         Reviewed by Gustavo Noronha Silva.
1486
1487         * Scripts/build-webkit: Instead of invoking buildGtkProject with
1488         another argument about webkit2, unshift a --disable-webkit2
1489         argument onto the buildArgs.
1490         * Scripts/webkitdirs.pm: Remove $enableWebKit2 arg. Only save autogen.sh
1491         arguments for WebKit to prevent unnecessary reconfiguration when build-webkit
1492         and build-jsc are run one after the other.
1493
1494 2011-12-13  Csaba Osztrogonác  <ossy@webkit.org>
1495
1496         [Qt] REGRESSION(102679): It broke Qt5-WK1 build
1497         https://bugs.webkit.org/show_bug.cgi?id=74413
1498
1499         Unreviewed buildfix.
1500
1501         * qmake/mkspecs/features/webcore.prf: Temporarily revert a part of r102679 until a proper fix.
1502
1503 2011-12-13  Csaba Osztrogonác  <ossy@webkit.org>
1504
1505         [Qt] Unreviewed speculativ debug buildfix after r102679.
1506
1507         * QtTestBrowser/QtTestBrowser.pro:
1508         * QtTestBrowser/main.cpp:
1509
1510 2011-12-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1511
1512         [Qt] Get rid of layering violations in includes
1513
1514         WebKit/qt/API and WebKit/qt/WebCoreSupport should not be included
1515         in the webcore.prf, but rather in each target that specificly needs
1516         headers in these location. We used to include them directly in webcore
1517         since we had layering violations between WebCore and WebKit, but now
1518         that they are gone there's no reason to do that.
1519
1520         Reviewed by Simon Hausmann.
1521
1522         * DumpRenderTree/qt/DumpRenderTree.pro:
1523         * QtTestBrowser/launcherwindow.h:
1524         * WebKitTestRunner/InjectedBundle/Target.pri:
1525         * qmake/mkspecs/features/webcore.prf:
1526         * qmake/mkspecs/features/webkit2.prf:
1527
1528 2011-12-13  János Badics  <dicska@gmail.com>
1529
1530         [NRWT] It crashes intermittently when there are WebProcess crashes
1531         https://bugs.webkit.org/show_bug.cgi?id=73451
1532
1533         Use self.poll() instead of self._proc.poll() because it checks if self._proc is None or not.
1534
1535         Reviewed by Kenneth Rohde Christiansen.
1536
1537         * Scripts/webkitpy/layout_tests/port/server_process.py:
1538         (ServerProcess._check_for_crash):
1539
1540 2011-12-13  Carlos Garcia Campos  <cgarcia@igalia.com>
1541
1542         Unreviewed. Fix GTK+ API docs build.
1543
1544         * gtk/generate-gtkdoc:
1545         (get_webkit2_options): Ignore WebKitUIClient since it's private
1546         API.
1547
1548 2011-12-13  Kenichi Ishibashi  <bashi@chromium.org>
1549
1550         Reviewed, removed one of my email addresses to use the apprpriate one.
1551
1552         * Scripts/webkitpy/common/config/committers.py:
1553
1554 2011-12-12  Ádám Kallai  <Kallai.Adam@stud.u-szeged.hu>
1555
1556         [Qt] Fix skip list search path and expected file search path in ORWT
1557         https://bugs.webkit.org/show_bug.cgi?id=74281
1558
1559         Expected file search path fixed.
1560
1561         Print all used skipped list and expected search path in verbose mode similar to NRWT.
1562
1563         Reviewed by Csaba Osztrogonác.
1564
1565         * Scripts/old-run-webkit-tests:
1566         (buildPlatformResultHierarchy):
1567         (buildPlatformTestHierarchy):
1568         (readSkippedFiles):
1569
1570 2011-12-12  Nándor Huszka  <huszka.nandor@stud.u-szeged.hu>
1571
1572         [Qt] Missing layoutTestController.dumpWillCacheResponse
1573         https://bugs.webkit.org/show_bug.cgi?id=74287
1574
1575         Reviewed by Csaba Osztrogonác.
1576
1577         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1578         (LayoutTestController::reset):
1579         (LayoutTestController::dumpWillCacheResponse):
1580         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1581
1582 2011-12-12  Martin Robinson  <mrobinson@igalia.com>
1583
1584         [GTK] platform/gtk/fonts/custom-font-missing-glyphs.html fails on 64-bit Debug
1585         https://bugs.webkit.org/show_bug.cgi?id=73771
1586
1587         Reviewed by Gustavo Noronha Silva.
1588
1589         When using a fallback font during testing, always use DejaVu Sans. This prevents
1590         falling back to DejaVu Serif on some systems.
1591
1592         * DumpRenderTree/gtk/fonts/fonts.conf: Fall back to DejaVu Sans.
1593
1594 2011-12-08  Pierre Rossi  <pierre.rossi@gmail.com>
1595
1596         Add myself as a committer
1597
1598         * Scripts/webkitpy/common/config/committers.py:
1599
1600 2011-12-12  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1601
1602         [Qt] [WK2] Support customizing popup menus with QML
1603         https://bugs.webkit.org/show_bug.cgi?id=73560
1604
1605         Reviewed by Tor Arne Vestbø.
1606
1607         Add an Item Selector to our WebView using the experimental API.
1608
1609         * MiniBrowser/qt/MiniBrowser.pro:
1610         * MiniBrowser/qt/MiniBrowser.qrc:
1611         * MiniBrowser/qt/qml/BrowserWindow.qml:
1612         * MiniBrowser/qt/qml/ItemSelector.qml: Added.
1613
1614 2011-12-12  Alexander Færøy  <alexander.faeroy@nokia.com>
1615
1616         [Qt] MiniBrowser should only visualize mock touch points when in non-desktop mode
1617         https://bugs.webkit.org/show_bug.cgi?id=74283
1618
1619         Reviewed by Simon Hausmann.
1620
1621         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1622         (MiniBrowserApplication::sendTouchEvent):
1623
1624 2011-12-12  Kentaro Hara  <haraken@chromium.org>
1625
1626         [Refactoring] In prepare-ChangeLog, move into a method the top-level code
1627         to show ChangeLogs diff and open ChangeLogs in an editor
1628         https://bugs.webkit.org/show_bug.cgi?id=74266
1629
1630         Reviewed by Ryosuke Niwa.
1631
1632         We are planning to write unit-tests for prepare-ChangeLog
1633         in a run-leaks_unittest manner. This patch is one of the incremental
1634         refactorings to remove all top-level code and global variables from
1635         prepare-ChangeLog.
1636
1637         * Scripts/prepare-ChangeLog: Moved the top-level code to show ChangeLogs diff into printDiff().
1638         Moved the top-level code to open ChangeLogs in an editor into openChangeLogs().
1639         Renamed @changed_files to @changedFiles.
1640         Renamed %conflict_files to %conflictFiles.
1641         (generateFunctionLists):
1642         (printDiff):
1643         (openChangeLogs):
1644
1645 2011-12-11  Kentaro Hara  <haraken@chromium.org>
1646
1647         [Refactoring] Move top-level code to resolve conflicted ChangeLogs into a method
1648         https://bugs.webkit.org/show_bug.cgi?id=74257
1649
1650         Reviewed by Ryosuke Niwa.
1651
1652         We are planning to write unit-tests for prepare-ChangeLog
1653         in a run-leaks_unittest/ manner. This patch is one of the incremental
1654         refactorings to remove all top-level code and global variables from
1655         prepare-ChangeLog.
1656
1657         * Scripts/prepare-ChangeLog: Moved top-level code to get the latest ChangeLogs
1658         into getLatestChangeLogs(), and moved top-level code to resolve conflicted ChangeLogs
1659         into resolveConflictedChangeLogs().
1660         (getLatestChangeLogs):
1661         (resolveConflictedChangeLogs):
1662
1663 2011-12-11  Kentaro Hara  <haraken@chromium.org>
1664
1665         [Refactoring] Move top-level code to generate a new ChangeLog into a method
1666         https://bugs.webkit.org/show_bug.cgi?id=74253
1667
1668         Reviewed by David Kilzer.
1669
1670         The objective is to make prepare-ChangeLog a loadable Perl module for unit testing,
1671         which requires to remove top-level code and global variables. This patch is one of
1672         the incremental refactorings for that.
1673
1674         * Scripts/prepare-ChangeLog: Moved top-level code to generate a new ChangeLog into generateNewChangeLogs().
1675         (generateFunctionLists):
1676         (findChangeLogs):
1677         (generateNewChangeLogs):
1678         (generateFileList): Removed an unnecessary variable $didChangeRegressionTests.
1679
1680 2011-12-10  Kentaro Hara  <haraken@chromium.org>
1681
1682         [Refactoring] In prepare-ChangeLog, move top-level code to find ChangeLogs into a method
1683         https://bugs.webkit.org/show_bug.cgi?id=74175
1684
1685         Reviewed by Ryosuke Niwa.
1686
1687         The objective is to make prepare-ChangeLog a loadable Perl module for unit testing.
1688         This requires to remove top-level code. This patch is one of the incremental refactorings
1689         for that.
1690
1691         * Scripts/prepare-ChangeLog: Moved top-level code to find ChangeLogs into findChangeLogs().
1692         (findChangeLogs):
1693
1694 2011-12-10  Andreas Kling  <kling@webkit.org>
1695
1696         Add my Apple e-mail to committers.py.
1697
1698         * Scripts/webkitpy/common/config/committers.py:
1699
1700 2011-12-09  Dirk Pranke  <dpranke@chromium.org>
1701
1702         chromium win build: revert build_webkit_exes_from_webkit_gyp change
1703         https://bugs.webkit.org/show_bug.cgi?id=74225
1704
1705         This change sets build_webkit_exes_from_webkit_gyp back to 1;
1706         the "All.gyp" solution doesn't work on windows.
1707
1708         * Scripts/webkitdirs.pm:
1709         (buildChromium):
1710
1711 2011-12-09  Hugo Parente Lima  <hugo.lima@openbossa.org>
1712
1713         [Qt] Click's count is limited to three continuous clicks.
1714         https://bugs.webkit.org/show_bug.cgi?id=45666
1715
1716         Reviewed by Kenneth Rohde Christiansen.
1717
1718         Update m_time at every call to leapForward, so double clicks
1719         event are correctly sent by EventSender.
1720
1721         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
1722         (WTR::EventSenderProxy::updateClickCountForButton):
1723         (WTR::EventSenderProxy::leapForward):
1724
1725 2011-12-09  Kentaro Hara  <haraken@chromium.org>
1726
1727         [Refactoring] Reduce top-level code in prepare-ChangeLog
1728         https://bugs.webkit.org/show_bug.cgi?id=74172
1729
1730         Reviewed by Ryosuke Niwa.
1731
1732         The objective is to make prepare-ChangeLog a loadable Perl module for unit testing.
1733         This requires to remove top-level code. This patch is one of the incremental refactorings
1734         for that.
1735
1736         * Scripts/prepare-ChangeLog: Moved some top-level code into generateFunctionLists().
1737         (generateFunctionLists):
1738
1739 2011-12-09  Sam Weinig  <sam@webkit.org>
1740
1741         Expose a WKConnectionRef which represents the connection to/from the WebProcess/UIProcess
1742         https://bugs.webkit.org/show_bug.cgi?id=74218
1743
1744         Reviewed by Anders Carlsson.
1745
1746         Add a test of the WKConnectionRef API.
1747
1748         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1749         * TestWebKitAPI/Tests/WebKit2/WKConnection.cpp: Added.
1750         (TestWebKitAPI::didCreateConnection):
1751         (TestWebKitAPI::connectionDidReceiveMessage):
1752         (TestWebKitAPI::connectionDidClose):
1753         (TestWebKitAPI::TEST):
1754         * TestWebKitAPI/Tests/WebKit2/WKConnection_Bundle.cpp: Added.
1755         (TestWebKitAPI::connectionDidReceiveMessage):
1756         (TestWebKitAPI::WKConnectionTest::WKConnectionTest):
1757         (TestWebKitAPI::WKConnectionTest::initialize):
1758
1759 2011-12-09  David Levin  <levin@chromium.org>
1760
1761         Hash* iterators should allow comparison between const and const versions.
1762         https://bugs.webkit.org/show_bug.cgi?id=73370
1763
1764         Reviewed by Darin Adler.
1765
1766         * TestWebKitAPI/TestWebKitAPI.gypi: Add the new test file to the build.
1767         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
1768         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto.
1769         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Added.
1770         (TestWebKitAPI::TEST): Add a test for the new functionality.
1771
1772 2011-12-09  Dirk Pranke  <dpranke@chromium.org>
1773
1774         chromium: visual studio projects are busted when build_webkit_exes_from_webkit_gyp==0
1775         https://bugs.webkit.org/show_bug.cgi?id=74212
1776
1777         Reviewed by Tony Chang.
1778
1779         The change introduced in r102201 to split the executables out of
1780         WebKit.gyp apparently doesn't work right on Windows, since
1781         WebKit.gyp and Tools.gyp refer to dependent projects by
1782         different relative paths (it appears gyp doesn't normalize the
1783         paths). This change moves Tools.gyp to be in the same directory
1784         as WebKit.gyp (and All.gyp), which should fix this and
1785         conveniently will also solve the problem of how to add Tools.gyp
1786         to the chromium DEPS file.
1787
1788         * Tools.gyp: Renamed to ../Source/WebKit/chromium/Tools.gyp
1789
1790 2011-12-09  Kentaro Hara  <haraken@chromium.org>
1791
1792         [Refactoring] In prepare-ChangeLog, move top-level code to fetch a bug description from URL into a method
1793         https://bugs.webkit.org/show_bug.cgi?id=74173
1794
1795         Reviewed by Ryosuke Niwa.
1796
1797         The objective is to make prepare-ChangeLog a loadable Perl module for unit testing.
1798         This requires to remove top-level code. This patch is one of the incremental refactorings
1799         for that.
1800
1801         * Scripts/prepare-ChangeLog: Moved top-level code to fetch a bug description from URL into fetchBugDescriptionFromURL().
1802         (fetchBugDescriptionFromURL):
1803
1804 2011-12-09  Tony Chang  <tony@chromium.org>
1805
1806         Switch the chromium mac bots to using skia test results
1807         https://bugs.webkit.org/show_bug.cgi?id=74201
1808
1809         Reviewed by Ryosuke Niwa.
1810
1811         This is reverting http://trac.webkit.org/changeset/97781 and changing
1812         the name in master.cfg to no longer have cg in the name.
1813
1814         * BuildSlaveSupport/build.webkit.org-config/config.json:
1815         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1816         (appendCustomBuildFlags):
1817         (RunWebKitTests.start):
1818
1819 2011-12-09  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1820
1821         [Qt] Remove a wrongly placed ASSERT.
1822
1823         Reviewed by Tor Arne Vestbø.
1824
1825         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1826         (MiniBrowserApplication::notify):
1827
1828 2011-12-09  Cary Clark  <caryclark@google.com>
1829
1830         layout_test update to accommodate new use_skia=1 default on Chromium-Mac
1831         https://bugs.webkit.org/show_bug.cgi?id=74118
1832
1833         Reviewed by Adam Barth.
1834
1835         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1836         (get):
1837         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1838         (ChromiumMacPort.__init__):
1839         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1840         (ChromiumMacPortTest.test_versions):
1841         (ChromiumMacPortTest.test_graphics_type):
1842
1843 2011-12-09  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1844
1845         [Qt] Use new qmake option in Qt5 to prevent dependency issues with GNUmake
1846
1847         The GNUmake + gcc_MD_depends options together produce .d files using GCC, but
1848         this failed when moving files in the source tree, as the .d file would contain
1849         stale dependencies on the old source file location. By keeping the object files
1850         (and hence the depdendency files) in a proper tree structure inside the objects
1851         directory we can prevent this failure.
1852
1853         A side benefit is that we can also have objects with the same name inside the
1854         same project.
1855
1856         Reviewed by Simon Hausmann.
1857
1858         * qmake/mkspecs/features/unix/default_pre.prf:
1859
1860 2011-12-09  Csaba Osztrogonác  <ossy@webkit.org>
1861
1862         Unreviewed. Update unit test after r102412.
1863
1864         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1865         (IRCCommandTest.test_whois):
1866
1867 2011-12-09  Kentaro Hara  <haraken@chromium.org>
1868
1869         REGRESSION(r102105): run-bindings-tests should output full diff results
1870         https://bugs.webkit.org/show_bug.cgi?id=74166
1871
1872         Reviewed by Adam Barth.
1873
1874         Since r102105, the output of run-bindings-tests is truncated to 500 characters.
1875         run-bindings-tests should output full diff results.
1876
1877         * Scripts/webkitpy/bindings/main.py: Replaced e.message_with_output() with e.output.
1878         (BindingsTests.generate_from_idl):
1879         (BindingsTests.generate_supplemental_dependency):
1880         (BindingsTests.detect_changes):
1881
1882 2011-12-09  Simon Hausmann  <simon.hausmann@nokia.com>
1883
1884         [Qt] Fix compilation with newly separated Qt 5 QtQuick module
1885         https://bugs.webkit.org/show_bug.cgi?id=73990
1886
1887         Reviewed by Kenneth Rohde Christiansen, tweaked by Csaba Osztrogonác.
1888
1889         Fix QtQuick includes after move from QtDeclarative to QtQuick.
1890
1891         * MiniBrowser/qt/BrowserWindow.h:
1892         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1893
1894 2011-12-08  Adam Klein  <adamk@chromium.org>
1895
1896         [MutationObservers] V8LazyEventHandler breaks microtask delivery semantics
1897         https://bugs.webkit.org/show_bug.cgi?id=73492
1898
1899         Reviewed by Adam Barth.
1900
1901         Add eventSender.scheduleAsynchronousKeyDown, needed to cause a
1902         keypress event without any script on the stack.
1903
1904         * DumpRenderTree/chromium/EventSender.cpp:
1905         (EventSender::EventSender):
1906         (EventSender::keyDown):
1907         (KeyDownTask::KeyDownTask):
1908         (KeyDownTask::runIfValid):
1909         (EventSender::scheduleAsynchronousKeyDown):
1910         * DumpRenderTree/chromium/EventSender.h:
1911
1912 2011-12-08  Hayato Ito  <hayato@chromium.org>
1913
1914         [gdb] Pretty printer for a 8-bit version of WTF::StringImpl and LChar*.
1915         https://bugs.webkit.org/show_bug.cgi?id=73980
1916
1917         Reviewed by Tony Chang.
1918
1919         * gdb/webkit.py:
1920         (guess_string_length):
1921         (ustring_to_string):
1922         (lstring_to_string):
1923         (LCharStringPrinter):
1924         (LCharStringPrinter.to_string):
1925         (WTFStringImplPrinter.get_length):
1926         (WTFStringImplPrinter.to_string):
1927         (WTFStringImplPrinter.is_8bit):
1928         (WTFStringPrinter.stringimpl_ptr):
1929         (WTFStringPrinter.get_length):
1930         (WTFStringPrinter.to_string):
1931         (add_pretty_printers.lookup_function):
1932
1933 2011-12-08  Pierre Rossi  <pierre.rossi@gmail.com>
1934
1935         Drop ENABLE_NO_LISTBOX_RENDERING, and make it a runtime decision.
1936         https://bugs.webkit.org/show_bug.cgi?id=73916
1937
1938         Reviewed by Kent Tamura.
1939
1940         * qmake/mkspecs/features/features.prf:
1941
1942 2011-12-08  Adrienne Walker  <enne@google.com>
1943
1944         Unreviewed contributor additions to committers.py.
1945
1946         * Scripts/webkitpy/common/config/committers.py:
1947
1948 2011-12-08  David Reveman  <reveman@chromium.org>
1949
1950         [Chromium] Add per-tile painting flag to DumpRenderTree and rename AcceleratedDrawing to AcceleratedPainting in chromium specific code.
1951         https://bugs.webkit.org/show_bug.cgi?id=74017
1952
1953         Reviewed by James Robinson.
1954         
1955         Add support for command line flag enable-per-tile-painting in DumpRenderTree.
1956
1957         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1958         (main):
1959         * DumpRenderTree/chromium/TestShell.cpp:
1960         (TestShell::TestShell):
1961         (TestShell::resetWebSettings):
1962         * DumpRenderTree/chromium/TestShell.h:
1963         (TestShell::setAcceleratedPaintingEnabled):
1964         (TestShell::setPerTilePaintingEnabled):
1965         * DumpRenderTree/chromium/WebPreferences.cpp:
1966         (WebPreferences::reset):
1967         (WebPreferences::applyTo):
1968         * DumpRenderTree/chromium/WebPreferences.h:
1969         * Scripts/webkitpy/layout_tests/port/chromium.py:
1970         (ChromiumDriver._wrapper_options):
1971         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1972         (parse_args):
1973
1974 2011-12-08  Dirk Pranke  <dpranke@chromium.org>
1975
1976         create a "SystemHost" object for webkitpy to slim down the Host object
1977         https://bugs.webkit.org/show_bug.cgi?id=72680
1978
1979         Reviewed by Eric Siedel.
1980
1981         This creates a SystemHost object that other objects that should
1982         only have dependencies on functionality in webkitpy.common.system
1983         can use; this will allow them to not require a full Host.
1984
1985         * Scripts/webkitpy/common/host.py:
1986         * Scripts/webkitpy/common/host_mock.py:
1987         * Scripts/webkitpy/common/system/systemhost.py: Added.
1988         * Scripts/webkitpy/common/system/systemhost_mock.py: Added.
1989
1990 2011-12-08  Chris Fleizach  <cfleizach@apple.com>
1991
1992         AX: platform/mac/accessibility/search-with-frames.html crashes
1993         https://bugs.webkit.org/show_bug.cgi?id=74093
1994
1995         Reviewed by Darin Adler.
1996
1997         Take care of the case when an incoming element is null.
1998
1999         * DumpRenderTree/AccessibilityUIElement.cpp:
2000         (uiElementForSearchPredicateCallback):
2001         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2002         (AccessibilityUIElement::uiElementForSearchPredicate):
2003         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2004         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2005
2006 2011-12-08  Alexander Færøy  <ahf@0x90.dk>
2007
2008         [Qt] Visualize mock point ID's in the MiniBrowser
2009         https://bugs.webkit.org/show_bug.cgi?id=74098
2010
2011         Reviewed by Tor Arne Vestbø.
2012
2013         * MiniBrowser/qt/BrowserWindow.cpp:
2014         (BrowserWindow::updateVisualMockTouchPoints):
2015         * MiniBrowser/qt/qml/MockTouchPoint.qml:
2016
2017 2011-12-08  Dominic Mazzoni  <dmazzoni@google.com>
2018
2019         Accessibility: AccessibilityController should support listening to notifications on all elements.
2020         https://bugs.webkit.org/show_bug.cgi?id=72866
2021
2022         Adds addNotificationListener and removeNotificationListener methods
2023         to AccessibilityController, to listen to notifications on any element
2024         rather than a specific element. Mac (DRT and WKTR) and Chromium (DRT)
2025         implementations are all contained in this change.
2026
2027         On Mac, refactors AccessibilityNotificationHandler into its own
2028         source file that can be used by both AccessibilityController and
2029         AccessibilityUIElement. (Both DRT and WKTR.)
2030
2031         Reviewed by Chris Fleizach.
2032
2033         * DumpRenderTree/AccessibilityController.cpp:
2034         (addNotificationListenerCallback):
2035         (removeNotificationListenerCallback):
2036         (AccessibilityController::getJSClass):
2037         * DumpRenderTree/AccessibilityController.h:
2038         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2039         * DumpRenderTree/chromium/AccessibilityController.cpp:
2040         (AccessibilityController::AccessibilityController):
2041         (AccessibilityController::notificationReceived):
2042         (AccessibilityController::addNotificationListenerCallback):
2043         (AccessibilityController::removeNotificationListenerCallback):
2044         * DumpRenderTree/chromium/AccessibilityController.h:
2045         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2046         (AccessibilityController::addNotificationListener):
2047         (AccessibilityController::removeNotificationListener):
2048         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2049         (AccessibilityController::~AccessibilityController):
2050         (AccessibilityController::addNotificationListener):
2051         (AccessibilityController::removeNotificationListener):
2052         * DumpRenderTree/mac/AccessibilityNotificationHandler.h: Added.
2053         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm: Added.
2054         (-[NSString createJSStringRef]):
2055         (-[AccessibilityNotificationHandler init]):
2056         (-[AccessibilityNotificationHandler setPlatformElement:]):
2057         (-[AccessibilityNotificationHandler dealloc]):
2058         (-[AccessibilityNotificationHandler setCallback:]):
2059         (-[AccessibilityNotificationHandler startObserving]):
2060         (-[AccessibilityNotificationHandler _notificationReceived:]):
2061         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2062         (AccessibilityUIElement::addNotificationListener):
2063         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2064         (notificationListenerProc):
2065         (AccessibilityController::addNotificationListener):
2066         (AccessibilityController::removeNotificationListener):
2067         (AccessibilityController::winNotificationReceived):
2068         (AccessibilityController::winAddNotificationListener):
2069         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2070         (AccessibilityUIElement::addNotificationListener):
2071         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2072         (WTR::AccessibilityController::addNotificationListener):
2073         (WTR::AccessibilityController::removeNotificationListener):
2074         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
2075         (WTR::AccessibilityController::logAccessibilityEvents):
2076         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp:
2077         (WTR::AccessibilityTextMarker::AccessibilityTextMarker):
2078         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp:
2079         (WTR::AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
2080         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
2081         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm: Added.
2082         (WTR::AccessibilityController::addNotificationListener):
2083         (WTR::AccessibilityController::removeNotificationListener):
2084         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h: Added.
2085         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm: Added.
2086         (-[NSString createJSStringRef]):
2087         (-[AccessibilityNotificationHandler init]):
2088         (-[AccessibilityNotificationHandler setPlatformElement:]):
2089         (-[AccessibilityNotificationHandler dealloc]):
2090         (-[AccessibilityNotificationHandler setCallback:]):
2091         (-[AccessibilityNotificationHandler startObserving]):
2092         (-[AccessibilityNotificationHandler _notificationReceived:]):
2093         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2094         (WTR::AccessibilityUIElement::AccessibilityUIElement):
2095         (WTR::AccessibilityUIElement::verticalScrollbar):
2096         (WTR::AccessibilityUIElement::addNotificationListener):
2097         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2098
2099 2011-12-08  Csaba Osztrogonác  <ossy@webkit.org>
2100
2101         [Qt][WK2] Unreviewed buildfix after r102352.
2102
2103         * qmake/mkspecs/features/webkit2.prf:
2104
2105 2011-12-08  Adam Roben  <aroben@apple.com>
2106
2107         Make finding crash logs by PID work on Snow Leopard
2108
2109         Crash Reporter on Snow Leopard doesn't set the "app_description" extended attribute that we
2110         were using to check the PID of the crashed process. (Crash Reporter on Lion does.) Now we
2111         read the first line of the crash log and pull the PID out of there.
2112
2113         Fixes <http://webkit.org/b/74094> "webkit-patch crash-log <process> <PID>" doesn't work on
2114         Snow Leopard
2115
2116         Reviewed by Darin Adler.
2117
2118         * Scripts/webkitpy/common/system/crashlogs.py:
2119         (CrashLogs._find_newest_log_darwin): Read the first line of the crash log to get the process
2120         name and PID for the log, rather than checking the Lion-only app_description extended
2121         attribute. We now also reject the log if the process name doesn't match what we expect.
2122
2123         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
2124         (make_mock_crash_report_darwin): Added. Returns a mock crash report given a process name and
2125         PID.
2126         (CrashLogsTest.assertLinesEqual): Added. This is a compatibility shim around
2127         unittest.TestCase.assertMultiLineEqual, which didn't exist before Python 2.7.
2128         (CrashLogsTest.test_find_log_darwin): Made the mock crash reports more believable by using
2129         the new make_mock_crash_report_darwin function. Also added tests for files that can't be
2130         read, files that actually contain a crash log for some other process, and files that are
2131         misformatted.
2132
2133         * Scripts/webkitpy/common/system/filesystem.py: Removed FileSystem.getxattr, which is now
2134         unused.
2135
2136         * Scripts/webkitpy/common/system/filesystem_mock.py:
2137         (MockFileSystem.__init__): Removed xattr support, which is now unused.
2138         (MockFileSystem.open_text_file_for_reading): Changed to actually pass the file's data to
2139         ReadableTextFileObject. This function was completely broken before!
2140         (ReadableBinaryFileObject.__init__): Made the data parameter non-optional to try to prevent
2141         bugs like the above.
2142         (ReadableTextFileObject.__init__): Added. Wraps the data in a StringIO object so we can do
2143         things like readline() and seek().
2144
2145         (ReadableTextFileObject.close):
2146         (ReadableTextFileObject.read):
2147         Added. We override the superclass implementation to account for using a StringIO object.
2148
2149         (ReadableTextFileObject.readline):
2150         (ReadableTextFileObject.seek):
2151         Added. These just call through to StringIO.
2152
2153         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2154         (MainTest.test_crash_log):
2155         (MainTest.test_web_process_crash_log):
2156         Changed to use make_mock_crash_report_darwin.
2157
2158 2011-12-06  Jon Lee  <jonlee@apple.com>
2159
2160         [WK2] Add permissions support (73960)
2161         https://bugs.webkit.org/show_bug.cgi?id=73960
2162         <rdar://problem/10357008>
2163
2164         Reviewed by Darin Adler.
2165
2166         Add null function item to comply with added callback to WKPageUIClient.
2167
2168         * MiniBrowser/mac/BrowserWindowController.m:
2169         (-[BrowserWindowController awakeFromNib]):
2170         * WebKitTestRunner/TestController.cpp:
2171         (WTR::TestController::createOtherPage):
2172         (WTR::TestController::initialize):
2173
2174 2011-12-08  Alexander Færøy  <alexander.faeroy@nokia.com>
2175
2176         [Qt] Visualize mock points in the Qt MiniBrowser
2177         https://bugs.webkit.org/show_bug.cgi?id=74074
2178
2179         Reviewed by Tor Arne Vestbø.
2180
2181         * MiniBrowser/qt/BrowserWindow.cpp:
2182         (BrowserWindow::updateVisualMockTouchPoints):
2183         * MiniBrowser/qt/BrowserWindow.h:
2184         * MiniBrowser/qt/MiniBrowser.qrc:
2185         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2186         (MiniBrowserApplication::notify):
2187         (MiniBrowserApplication::sendTouchEvent):
2188         * MiniBrowser/qt/MiniBrowserApplication.h:
2189         * MiniBrowser/qt/icons/touchpoint.png: Added.
2190         * MiniBrowser/qt/qml/MockTouchPoint.qml: Added.
2191
2192 2011-12-08  Simon Hausmann  <simon.hausmann@nokia.com>
2193
2194         [Qt] WebKitTestRunner crashes with debug builds
2195         https://bugs.webkit.org/show_bug.cgi?id=74090
2196
2197         Reviewed by Tor Arne Vestbø.
2198
2199         * WebKitTestRunner/qt/TestControllerQt.cpp:
2200         (WTR::TestController::platformInitialize): Call QQuickWebView::platformInitialize
2201         to ensure WTF/JSC threading is initialized.
2202
2203 2011-12-08  Dirk Pranke  <dpranke@chromium.org>
2204
2205         fix build-webkit --chromium after breakage in r102201
2206         https://bugs.webkit.org/show_bug.cgi?id=74031
2207
2208         Reviewed by Tony Chang.
2209
2210         * Scripts/webkitdirs.pm:
2211         (buildChromium):
2212
2213 2011-12-08  Kentaro Hara  <haraken@chromium.org>
2214
2215         Unreviewed, rolling out r102280.
2216         http://trac.webkit.org/changeset/102280
2217         https://bugs.webkit.org/show_bug.cgi?id=74031
2218
2219         Chromium/Windows build is broken
2220
2221         * Scripts/webkitdirs.pm:
2222         (buildChromium):
2223
2224 2011-12-08  Nayan Kumar K  <nayankk@motorola.com>
2225
2226         Adding myself to committers list.
2227
2228         Unreviewed.
2229
2230         * Scripts/webkitpy/common/config/committers.py:
2231
2232 2011-12-07  Michael Saboff  <msaboff@apple.com>
2233
2234         StringBuilderTest.Append and StringBuilderTest.ToStringPreserveCapacity are failing.
2235         https://bugs.webkit.org/show_bug.cgi?id=73995
2236
2237         Reenabled failing tests that the code part of the patch fixes.
2238
2239         Reviewed by Geoffrey Garen.
2240
2241         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2242         (TestWebKitAPI::TEST):
2243
2244 2011-12-07  MORITA Hajime  <morrita@google.com>
2245
2246         [filter-build-webkit] should not emit reset color when --no-color is given
2247         https://bugs.webkit.org/show_bug.cgi?id=73992
2248
2249         Reviewed by Daniel Bates.
2250
2251         Stop printing control sequences when --no-color is given.
2252         After this change, the filter runs nicely even on environments
2253         like Emacs compilation-mode which cannot understand the control sequence.
2254
2255         * Scripts/filter-build-webkit:
2256         (printLine):
2257
2258 2011-12-07  Eric Seidel  <eric@webkit.org>
2259
2260         Use free memory to determine if we have space for DRT instances instead of total memory
2261         https://bugs.webkit.org/show_bug.cgi?id=74021
2262
2263         Reviewed by Adam Barth.
2264
2265         This will hopefully make the Mac buildbots behave better.
2266
2267         I also reduced the expected memory needed per DRT now that
2268         we're properly accounting for the system memory in our calculations.
2269
2270         * Scripts/webkitpy/common/system/platforminfo.py:
2271         (PlatformInfo.total_bytes_memory):
2272         (PlatformInfo._compute_free_bytes_from_vm_stat_output):
2273         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2274         (MockPlatformInfo.total_bytes_memory):
2275         * Scripts/webkitpy/layout_tests/port/base.py:
2276         (Port.default_child_processes):
2277         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2278         (PortTest.test_default_child_processes):
2279
2280 2011-12-07  Dirk Pranke  <dpranke@chromium.org>
2281
2282         fix build-webkit --chromium after breakage in r102201
2283         https://bugs.webkit.org/show_bug.cgi?id=74031
2284
2285         Reviewed by Tony Chang.
2286
2287         r102201 introduced a change to the chromium build that splits
2288         the executables out of WebKit.gyp into other gyp files, and adds
2289         a new "All.gyp" that builds everything. However, I forgot to
2290         update the build script to use All.gyp.
2291
2292         * Scripts/webkitdirs.pm:
2293         (buildChromium):
2294
2295 2011-12-07  Tom Zakrajsek  <tomz@codeaurora.org>
2296
2297         Moved myself to the committers list.
2298
2299         * Scripts/webkitpy/common/config/committers.py:
2300
2301 2011-11-30  Simon Hausmann  <simon.hausmann@nokia.com>
2302
2303         [Qt] Fix debug shlib build with V8.
2304
2305         Reviewed by Tor Arne Vestbø.
2306
2307         * qmake/mkspecs/features/qtwebkit.prf: Don't link jscore with
2308         v8 builds.
2309
2310 2011-11-30  Simon Hausmann  <simon.hausmann@nokia.com>
2311
2312         [Qt] V8 build fixes.
2313
2314         Reviewed by Tor Arne Vestbø.
2315
2316         * qmake/mkspecs/features/javascriptcore.prf: Don't add
2317         Source/Thirdparty to the include search path here.
2318         * qmake/mkspecs/features/webcore.prf: Instead it belongs here, because it's
2319         used when building WebCore as well as using it, because header files like
2320         GraphicsContext3D.h include stuff from ThirdParty.
2321
2322 2011-12-07  Peter Beverloo  <peter@chromium.org>
2323
2324         [Chromium] Fix project file generation for the Android bot after r102201
2325         https://bugs.webkit.org/show_bug.cgi?id=73996
2326
2327         The gyp refactoring in r102201 was didn't explicitly exclude
2328         the Android operating system in Tools/Tools.gyp, which broke
2329         as gcc_version is not defined for that configuration.
2330
2331         Reviewed by Andreas Kling.
2332
2333         * Tools.gyp:
2334
2335 2011-12-07  Vsevolod Vlasov  <vsevik@chromium.org>
2336
2337         Unreviewed. Disabled failing tests on chromium.
2338
2339         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2340         (TestWebKitAPI::TEST):
2341
2342 2011-12-06  Dirk Pranke  <dpranke@chromium.org>
2343
2344         binaries in webkit.gyp should be split into a new file to break circular dependencies on webkit_support
2345         https://bugs.webkit.org/show_bug.cgi?id=73382
2346
2347         Reviewed by Tony Chang.
2348
2349         XCode (and hence GYP) can't handle circular dependencies between
2350         files (and projects). Accordingly, although the binaries in
2351         WebKit.gyp depend on webkit_support and webkit_support depends
2352         on webkit, we don't mention the latter dependency in the file.
2353         To fix this, this change moves the binaries like DRT into a new
2354         GYP file, and modifies gyp_webkit to build from that file
2355         instead of WebKit.gyp.
2356
2357         * Tools.gyp: Added.
2358
2359 2011-12-06  Adam Roben  <aroben@apple.com>
2360
2361         Add a pid parameter to CrashLogs.find_newest_log
2362
2363         When a PID is passed, only crash logs corresponding to a crashed process with that PID are
2364         considered.
2365
2366         Fixes <http://webkit.org/b/73942> webkitpy provides no way to specify the PID of the crashed
2367         process whose crash log you want to find
2368
2369         Reviewed by Dirk Pranke.
2370
2371         * Scripts/webkitpy/common/system/crashlogs.py:
2372         (CrashLogs.find_newest_log): Added an optional pid parameter.
2373         (CrashLogs._find_newest_log_darwin): Added a pid parameter. When specified, we look at each
2374         candidate log's app_description extended attribute to see if that log corresponds to a
2375         crashed process with the specified PID.
2376
2377         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
2378         (CrashLogsTest.test_find_newest_log_darwin): Added a few more mock crash logs with various
2379         contents and PIDs. Added tests that show that the pid parameter to find_newest_log is
2380         respected. Also fixed an erroneous use of assertTrue instead of assertEqual.
2381
2382         * Scripts/webkitpy/common/system/filesystem.py:
2383         (FileSystem.getxattr): Added. On Darwin, calls through to the xattr module. On other
2384         systems, raises a KeyError, mimicking the behavior on Darwin when the given attribute isn't
2385         present.
2386
2387         * Scripts/webkitpy/common/system/filesystem_mock.py:
2388         (MockFileSystem.__init__): Added an optional xattrs parameter. Documented other parameters.
2389         (MockFileSystem.getxattr): Added. Just pulls the given attribute out of the xattrs
2390         dictionary.
2391
2392         * Scripts/webkitpy/tool/commands/queries.py:
2393         (CrashLog): Added help text. Added an optional PID parameter.
2394         (CrashLog.execute): Pass the PID, if any, through to find_newest_log.
2395
2396 2011-12-06  Adam Roben  <aroben@apple.com>
2397
2398         Wait for Crash Reporter to finish even when it lets the crashed process die quickly
2399
2400         NRWT was only waiting for Crash Reporter in cases where it was keeping the crashed process
2401         alive beyond the normal timeout limit. In cases where the crashed process was able to die
2402         faster, NRWT would assume that Crash Reporter had finished even though it often was still
2403         running, which would lead to an incorrect crash log being picked up.
2404
2405         Part of <http://webkit.org/b/71380> NRWT incorrectly associates crash logs with tests
2406
2407         Reviewed by Dirk Pranke.
2408
2409         * Scripts/webkitpy/layout_tests/port/server_process.py:
2410         (ServerProcess._reset):
2411         (ServerProcess.write):
2412         (ServerProcess._check_for_crash): Changed to use new set_crashed function instead of setting
2413         .crashed directly. Added wait_for_crash_reporter parameter, which we pass along to
2414         set_crashed.
2415
2416         (ServerProcess._handle_timeout): Fixed a logic error that would cause .crashed and
2417         .timed_out both to be set to True in cases where Crash Reporter took a long time to run. Now
2418         we bail out of handling the failure as a timeout if we find out that the process in fact
2419         crashed. We tell _check_for_crash not to wait for Crash Reporter because we've already done
2420         so.
2421         (ServerProcess.set_crashed): Added. When the process crashes, we wait for Crash Reporter to
2422         finish running (unless directed otherwise) so we can be sure the crash log has been saved to
2423         disk.
2424
2425         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
2426         (TrivialMockPort.is_crash_reporter): Added.
2427
2428         * Scripts/webkitpy/layout_tests/port/webkit.py:
2429         (WebKitDriver._check_for_driver_crash): Changed to use set_crashed. (This also fixed a typo
2430         that would have partially broken crash detection on Windows, if NRWT worked on Windows.)
2431
2432 2011-12-06  Adam Barth  <abarth@webkit.org>
2433
2434         NRWT fails on unreleased versions of Mac OS X
2435         https://bugs.webkit.org/show_bug.cgi?id=72748
2436
2437         Reviewed by Dirk Pranke.
2438
2439         Hopefully this patch will make NRWT work on future versions on Mac OS X.
2440         Most of the infrastructure was already in place, but there were some
2441         asserts that failed.  I've tested this patch by haxoring the version
2442         detection logic to simulate an unknown version.  We might need to
2443         iterate based on feedback from folks with a real future version.
2444
2445         * Scripts/webkitpy/layout_tests/port/apple.py:
2446         (ApplePort.__init__):
2447             - mac-future is an allowed port_name that's used internally by
2448               webkitpy to represent future versions of Mac OS X.
2449         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2450         (test_versions):
2451             - Test that we don't throw exceptions when dealing with future
2452               versions of Mac OS X.
2453         * Scripts/webkitpy/layout_tests/port/webkit.py:
2454         (WebKitPort._expectations_from_skipped_files):
2455             - Demote this logging message to "debug".  It's expected that
2456               mac-future doesn't have a Skipped file.
2457         * Scripts/webkitpy/layout_tests/port/mac.py:
2458         (MacPort.__init__):
2459         * Scripts/webkitpy/layout_tests/port/win.py:
2460         (WinPort.__init__):
2461             - Re-order some code in these constructors so that
2462               self._operating_system is available to the ApplePort constructor.
2463
2464 2011-12-06  Tommy Widenflycht  <tommyw@google.com>
2465
2466         Added myself as a committer.
2467
2468         * Scripts/webkitpy/common/config/committers.py:
2469
2470 2011-12-06  Peter Beverloo  <peter@chromium.org>
2471
2472         Added myself as a committer.
2473
2474         * Scripts/webkitpy/common/config/committers.py:
2475
2476 2011-12-06  Kentaro Hara  <haraken@chromium.org>
2477
2478         [Refactoring] In webkitpy/bindings/main.py, replace subprocess.Popen() with Executive
2479         https://bugs.webkit.org/show_bug.cgi?id=73637
2480
2481         Reviewed by Adam Barth.
2482
2483         This patch replaces subprocess.Popen() with Executive, similar to other
2484         Python scripts in webkitpy/. I manually confirmed that run-bindings-tests
2485         works well for cases where no exception is raised, no exception is raised
2486         but diff is found, and ScriptError is raised.
2487
2488         * Scripts/run-bindings-tests:
2489         (main):
2490         * Scripts/webkitpy/bindings/main.py: Replaces subprocess.Popen() with Executive.
2491         (BindingsTests.__init__):
2492         (BindingsTests.generate_from_idl):
2493         (BindingsTests.generate_supplemental_dependency):
2494         (BindingsTests.detect_changes):
2495
2496 2011-12-05  Alexander Færøy  <alexander.faeroy@nokia.com>
2497
2498         [Qt] MiniBrowser should default to touch behavior
2499         https://bugs.webkit.org/show_bug.cgi?id=73863
2500
2501         Reviewed by Chang Shu.
2502
2503         MiniBrowser currently defaults to the traditional desktop behaviour
2504         instead of touch behaviour which is prefered.
2505
2506         * MiniBrowser/qt/BrowserWindow.cpp:
2507         (BrowserWindow::BrowserWindow):
2508         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2509         (printHelp):
2510         (MiniBrowserApplication::handleUserOptions):
2511         * MiniBrowser/qt/MiniBrowserApplication.h:
2512         (WindowOptions::WindowOptions):
2513         (WindowOptions::setUseTraditionalDesktopBehavior):
2514         (WindowOptions::useTraditionalDesktopBehavior):
2515
2516 2011-12-05  Raphael Kubo da Costa  <kubo@profusion.mobi>
2517
2518         webkit.py: Really fix the printing of StringImpl now that 8-bit strings are present.
2519         https://bugs.webkit.org/show_bug.cgi?id=73878
2520
2521         Reviewed by Tony Chang.
2522
2523         r98624 turned StringImpl::m_data into StringImpl::{m_data8,m_data16}.
2524         r98785 made webkit.py always use m_data16, which does not work when
2525         the string is an 8-bit string (such as KURL::string()).
2526
2527         I was not able to directly call StringImpl::is8Bit() in the Python
2528         code, so I just reproduced the implementation there.
2529
2530         * gdb/webkit.py:
2531         (WTFStringPrinter.is_8bit): Reproduced StringImpl::is8Bit().
2532         (WTFStringPrinter.to_string):
2533         (JSCUStringPrinter.is_8bit): Reproduced StringImpl::is8Bit().
2534         (JSCUStringPrinter.to_string):
2535
2536 2011-12-05  Eric Seidel  <eric@webkit.org>
2537
2538         Up the "expected ram for each DRT instance" to 400MB instead of 300MB
2539         in hopes of making the Snow Leopard bot stop timing out.
2540
2541         Unreviewed.
2542
2543         * Scripts/webkitpy/layout_tests/port/base.py:
2544         (Port.default_child_processes):
2545         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2546         (PortTest.test_default_child_processes):
2547
2548 2011-12-05  Eric Seidel  <eric@webkit.org>
2549
2550         NRWT creates too many workers on RAM-limited machines
2551         https://bugs.webkit.org/show_bug.cgi?id=73847
2552
2553         Reviewed by Dirk Pranke.
2554
2555         Make NRWT restrict its number of workers when there isn't enough
2556         RAM to support them.
2557         Also re-enable parallel testing on the Mac bots which were
2558         failing due to not enough ram.
2559
2560         * Scripts/run-webkit-tests:
2561         (platformIsReadyForParallelTesting):
2562         * Scripts/webkitpy/common/host.py:
2563         (Host.__init__):
2564         * Scripts/webkitpy/common/system/executive_mock.py:
2565         (MockExecutive.cpu_count):
2566         * Scripts/webkitpy/common/system/platforminfo.py:
2567         (PlatformInfo.__init__):
2568         (PlatformInfo.display_name):
2569         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2570         (MockPlatformInfo.display_name):
2571         * Scripts/webkitpy/layout_tests/port/base.py:
2572         (Port.default_child_processes):
2573         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2574         (PortTest.test_default_child_processes):
2575         (PortTest.test_pretty_patch_os_error):
2576
2577 2011-12-05  Hugo Parente Lima  <hugo.lima@openbossa.org>
2578
2579         Last mouse event could be lost if a JS call to eventSender.leapForward is made
2580         https://bugs.webkit.org/show_bug.cgi?id=73366
2581
2582         Reviewed by Kenneth Rohde Christiansen.
2583
2584         Empty the entire event queue when requested besides using
2585         sendEvent instead of postEvent to make sure all events were
2586         delivered.
2587
2588         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
2589         (WTR::EventSenderProxy::EventSenderProxy):
2590         (WTR::EventSenderProxy::sendOrQueueEvent):
2591         (WTR::EventSenderProxy::replaySavedEvents):
2592
2593 2011-12-05  Adam Barth  <abarth@webkit.org>
2594
2595         [Chromium] Remove no-longer-used forwarding headers in the WebKit API
2596         https://bugs.webkit.org/show_bug.cgi?id=73845
2597
2598         Reviewed by Darin Fisher.
2599
2600         Update includes to point to the new header locations.
2601
2602         * DumpRenderTree/chromium/AccessibilityController.cpp:
2603         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2604         * DumpRenderTree/chromium/CppBoundClass.cpp:
2605         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2606         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2607         * DumpRenderTree/chromium/DRTDevToolsClient.h:
2608         * DumpRenderTree/chromium/EventSender.cpp:
2609         * DumpRenderTree/chromium/EventSender.h:
2610         * DumpRenderTree/chromium/GamepadController.h:
2611         * DumpRenderTree/chromium/LayoutTestController.cpp:
2612         * DumpRenderTree/chromium/LayoutTestController.h:
2613         * DumpRenderTree/chromium/MockSpellCheck.cpp:
2614         * DumpRenderTree/chromium/NotificationPresenter.cpp:
2615         * DumpRenderTree/chromium/PlainTextController.cpp:
2616         * DumpRenderTree/chromium/Task.cpp:
2617         * DumpRenderTree/chromium/TestNavigationController.h:
2618         * DumpRenderTree/chromium/TestShell.cpp:
2619         * DumpRenderTree/chromium/TestWebPlugin.cpp:
2620         * DumpRenderTree/chromium/TestWebPlugin.h:
2621         * DumpRenderTree/chromium/TextInputController.cpp:
2622         * DumpRenderTree/chromium/WebPermissions.cpp:
2623         * DumpRenderTree/chromium/WebPreferences.h:
2624         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
2625         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
2626         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
2627         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
2628         * DumpRenderTree/chromium/WebViewHost.cpp:
2629
2630 2011-12-05  Ryosuke Niwa  <rniwa@webkit.org>
2631
2632         Add Aharon Lanin to the contributors list.
2633
2634         * Scripts/webkitpy/common/config/committers.py:
2635
2636 2011-12-05  Jarred Nicholls  <jarred@sencha.com>
2637
2638         Moving myself from contributors to committers.
2639
2640         * Scripts/webkitpy/common/config/committers.py:
2641
2642 2011-12-05  Raphael Kubo da Costa  <kubo@profusion.mobi>
2643
2644         Add myself as a committer.
2645
2646         * Scripts/webkitpy/common/config/committers.py:
2647
2648 2011-12-05  Michael Brüning  <michael.bruning@nokia.com>
2649
2650         [Qt] Rename QQuickWebView::canStop property to just loading 
2651         https://bugs.webkit.org/show_bug.cgi?id=73813
2652
2653         Reviewed by Kenneth Rohde Christiansen.
2654
2655         Replaced references to WebView.canStop with WebView.loading.
2656
2657         * MiniBrowser/qt/qml/BrowserWindow.qml:
2658
2659 2011-12-05  Dirk Pranke  <dpranke@chromium.org>
2660
2661         run-webkit-tests: limit --child-processes properly on apple mac
2662         https://bugs.webkit.org/show_bug.cgi?id=73856
2663
2664         Reviewed by Adam Roben.
2665
2666         Fix typos in r102013 so that we correctly pass --child-processes=1 on
2667         the apple mac bots temporarily.
2668
2669         * Scripts/run-webkit-tests:
2670         (platformIsReadyForParallelTesting):
2671
2672 2011-12-05  Ryosuke Niwa  <rniwa@webkit.org>
2673
2674         Temporarily set --child-process=1 on Mac because 20+ tests are timing out
2675         https://bugs.webkit.org/show_bug.cgi?id=73840
2676
2677         Reviewed by Simon Fraser.
2678
2679         Temporarily go back to single process mode on Mac.
2680
2681         * Scripts/run-webkit-tests:
2682         (platformIsReadyForParallelTesting):
2683
2684 2011-12-05  Adam Roben  <aroben@apple.com>
2685
2686         Redeploy apple-macpro-7 and apple-xserve-1
2687
2688         These slaves have been sitting idle since we removed our Leopard builders in r97496.
2689
2690         Fixes <http://webkit.org/b/73829> REGRESSION (r97496): apple-macpro-7 and apple-xserve-1 are
2691         sitting idle
2692
2693         Reviewed by Sam Weinig.
2694
2695         * BuildSlaveSupport/build.webkit.org-config/config.json: Re-added apple-macpro-7 and
2696         apple-xserve-1. The former is now doing "SnowLeopard Intel Debug (WebKit2 Tests)", which
2697         allows apple-xserve-9 to be a build-only slave, and the latter is doing "Lion Intel Debug
2698         (WebKit2 Tests)".
2699
2700 2011-12-05  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2701
2702         [Qt] Make the UI of the MiniBrowser slightly nicer
2703
2704         Rubberstamped by Simon Hausmann.
2705
2706         - Add proper padding
2707         - Show feedback when pressing on the toolbar icons
2708         - Make the text entry better looking
2709
2710         * MiniBrowser/qt/qml/BrowserWindow.qml:
2711
2712 2011-12-05  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2713
2714         NRWT should handle duplicated expectations
2715         https://bugs.webkit.org/show_bug.cgi?id=69750
2716
2717         Reviewed by Dirk Pranke.
2718
2719         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2720         (TestExpectations.__init__):
2721         (TestExpectations._report_errors):
2722         (TestExpectations._add_expectations):
2723         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2724         (test_add_skipped_tests):
2725         * Scripts/webkitpy/layout_tests/port/base.py:
2726         (Port.skipped_tests):
2727         * Scripts/webkitpy/layout_tests/port/webkit.py:
2728         (WebKitPort.test_expectations):
2729         (WebKitPort.skipped_tests):
2730         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2731         (test_test_expectations):
2732
2733 2011-12-04  Eric Seidel  <eric@webkit.org>
2734
2735         After success with Mac, Win and Gtk, turning on parallel testing
2736         by default for all platforms (except Qt).
2737
2738         We'll add more platforms to the blacklist if we see problems.
2739
2740         Unreviewed.
2741
2742         * Scripts/run-webkit-tests:
2743         (platformIsReadyForParallelTesting):
2744
2745 2011-12-04  Sam Weinig  <sam@webkit.org>
2746
2747         Add tests for RetainPtr::adoptNS/adoptCF
2748         https://bugs.webkit.org/show_bug.cgi?id=73470
2749
2750         Reviewed by Adam Roben and Darin Adler.
2751
2752         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2753         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp: Added.
2754         (TestWebKitAPI::TEST):
2755         Test that adopting using adoptCF creates a RetainPtr with a
2756         value whose retain count is 1.
2757
2758         * TestWebKitAPI/Tests/WTF/ns: Added.
2759         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm: Added.
2760         (TestWebKitAPI::TEST):
2761         Test that adopting using adoptNS creates a RetainPtr with a
2762         value whose retain count is 1.
2763
2764 2011-12-04  Martin Robinson  <mrobinson@igalia.com>
2765
2766         [GTK] Include cairo, pixman and gnome-icon-theme in the jhbuild modules
2767         https://bugs.webkit.org/show_bug.cgi?id=73748
2768
2769         Reviewed by Gustavo Noronha Silva.
2770
2771         * gtk/jhbuild.modules: Add some new modules the jhbuild moduleset.
2772
2773 2011-12-04  Philippe Normand  <pnormand@igalia.com>
2774
2775         Another GTK build fix after r101922.
2776
2777         Rubber-stamped by Martin Robinson.
2778
2779         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2780         (LayoutTestController::pathToLocalResource): Plug possible String ref leak.
2781
2782 2011-12-04  Xan Lopez  <xlopez@igalia.com>
2783
2784         Fix compiler warning in LayoutTestController
2785
2786         Reviewed by Philippe Normand.
2787
2788         * DumpRenderTree/LayoutTestController.cpp:
2789         (LayoutTestController::LayoutTestController): fix warning.
2790
2791 2011-12-04  Alexandre Mazari  <scaroo@gmail.com>
2792
2793         Add missing methods used by fast/notifications tests to LayoutTestController
2794         https://bugs.webkit.org/show_bug.cgi?id=63616
2795
2796         Reviewed by Martin Robinson.
2797
2798         Add missing simulateDesktopNotificationClick method used by
2799         fast/notifications. Provide a default implementation for
2800         areDesktopNotificationPermissionRequestsIgnored and
2801         ignoreDesktopNotificationPermissionRequests.
2802
2803         * DumpRenderTree/LayoutTestController.cpp:
2804         (LayoutTestController::LayoutTestController): call into the port implementation.
2805         (simulateDesktopNotificationClickCallback): ditto.
2806         (ignoreDesktopNotificationPermissionRequestsCallback): default implementation.
2807         (LayoutTestController::staticFunctions): declare new methods.
2808         (LayoutTestController::ignoreDesktopNotificationPermissionRequests): default implementation.
2809         * DumpRenderTree/LayoutTestController.h:
2810         (LayoutTestController::areDesktopNotificationPermissionRequestsIgnored):
2811         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2812         (LayoutTestController::simulateDesktopNotificationClick): dummy implementation.
2813         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2814         (LayoutTestController::simulateDesktopNotificationClick): ditto.
2815         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2816         (LayoutTestController::simulateDesktopNotificationClick): ditto.
2817         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2818         (LayoutTestController::simulateDesktopNotificationClick): ditto.
2819         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2820         (LayoutTestController::simulateDesktopNotificationClick): ditto.
2821
2822 2011-12-03  Mario Sanchez Prada  <msanchez@igalia.com>
2823
2824         [GTK] Don't log document events in DRT
2825         https://bugs.webkit.org/show_bug.cgi?id=73746
2826
2827         Reviewed by Martin Robinson.
2828
2829         Stop connecting globally to document-related events.
2830
2831         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
2832         (connectAccessibilityCallbacks): Removed connections.
2833         (disconnectAccessibilityCallbacks): Removed disconnections.
2834
2835 2011-12-03  Dan Bernstein  <mitz@apple.com>
2836
2837         Added a test for <rdar://problem/10523721> Crash at WebCore::SubresourceLoader::releaseResources
2838
2839         Reviewed by Darin Adler.
2840
2841         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2842         * TestWebKitAPI/Tests/mac/SubresourceErrorCrash.mm: Added.
2843         (TestWebKitAPI::TEST):
2844
2845 2011-12-03  Philippe Normand  <pnormand@igalia.com>
2846
2847         Another GTK build fix after r101922.
2848
2849         Rubber-stamped by Martin James Robinson.
2850
2851         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2852         (LayoutTestController::pathToLocalResource): return value needs to
2853         be a URI.
2854
2855 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
2856
2857         Small fix for my previous patch. Do not try to delete a member
2858         of a dictionary that does not exist.
2859
2860         Reviewed by Gustavo Noronha Silva.
2861
2862         * gtk/run-with-jhbuild:
2863         (install_and_run_jhbuild):
2864
2865 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
2866
2867         Fix jhbuild installation for people who have unusual MAKE environment
2868         variables such as 'make -j4' as the jhbuild build does not handle it.
2869
2870         Reviewed by Gustavo Noronha Silva.
2871
2872         * gtk/run-with-jhbuild:
2873         (install_and_run_jhbuild): Remove any MAKE environment variable before building jhbuild.
2874
2875 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
2876
2877         Fix the update-webkitgtk-libs script to properly trigger a jhbuild installation
2878         when run for the first time.
2879
2880         Reviewed by Gustavo Noronha Silva.
2881
2882         * Scripts/update-webkitgtk-libs: Fix first run.
2883
2884 2011-12-03  Philippe Normand  <pnormand@igalia.com>
2885
2886         Unreviewed, GTK build fix after r101922.
2887
2888         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2889         (LayoutTestController::pathToLocalResource): Added sentinel in
2890         g_build_filename call.
2891
2892 2011-12-03  Philippe Normand  <pnormand@igalia.com>
2893
2894         GTK API tests build fix. Run the tests inside jhbuild.
2895
2896         Rubber-stamped by Gustavo Noronha Silva.
2897
2898         * Scripts/run-gtk-tests:
2899         (TestRunner.__init__):
2900         (TestRunner.run._error_handler):
2901         (TestRunner):
2902         (TestRunner.run):
2903
2904 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
2905
2906         Small build fix. Properly specify the path to the locally installed jhbuild.
2907
2908         * Scripts/update-webkitgtk-libs: Fix jhbuild path.
2909
2910 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
2911
2912         [GTK][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
2913         https://bugs.webkit.org/show_bug.cgi?id=67256
2914
2915         Reviewed by Philippe Normand.
2916
2917         Implement LayoutTestController::pathToLocalResource for GTK+. Instead of passing 
2918         WEBKIT_TEST_FONTS to the GTK+ test harnesses, pass a more generic WEBKIT_TOP_LEVEL,
2919         which points to the more generic top-level path of the WebKit checkout. This code is
2920         duplicated between WK1 and WK2 harnesses because we do not currently have a way to
2921         share code here.
2922
2923         If WEBKIT_TOP_LEVEL is not provided, we search for the top level based on the binary
2924         location. This will cause the fallback to fail if you build into a non-typical location
2925         or even fake it with a symlink. In this case it's important to use the environment variable.
2926
2927         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2928         (getTopLevelPath): Added.
2929         (initializeFonts): Use the new helper to get the font path.
2930         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Expose the new helper.
2931         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2932         (LayoutTestController::pathToLocalResource):Use the new helper to normalize
2933         test paths.
2934         * Scripts/webkitpy/layout_tests/port/gtk.py:
2935         (GtkPort.setup_environ_for_server):Pass the top-level path of the
2936         checkout instead of passing the font path.
2937         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2938         (WTR::getTopLevelPath): Added this helper.
2939         (WTR::inititializeFontConfigSetting): Use the helper to find the font path.
2940
2941 2011-12-02  David Levin  <levin@chromium.org>
2942
2943         Rename WTF class from TemporarilyChange to TemporaryChange.
2944         https://bugs.webkit.org/show_bug.cgi?id=73479
2945
2946         Reviewed by Eric Seidel.
2947
2948         * DumpRenderTree/ForwardingHeaders/wtf/TemporarilyChange.h: Removed.
2949         * DumpRenderTree/ForwardingHeaders/wtf/TemporaryChange.h: Added.
2950         * TestWebKitAPI/TestWebKitAPI.gypi:
2951         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2952         * TestWebKitAPI/Tests/WTF/TemporaryChange.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/TemporarilyChange.cpp.
2953         (TestWebKitAPI::TEST):
2954         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2955
2956 2011-12-02  Tony Chang  <tony@chromium.org>
2957
2958         [NRWT] reftest asserts intermittently on the Qt-WK2 bot
2959         https://bugs.webkit.org/show_bug.cgi?id=73453
2960
2961         Reviewed by Ryosuke Niwa.
2962
2963         We used to assert if a ref test didn't generate pixel results. Instead, just claim it is a failing test.
2964         The verbose output will include the failure reason.
2965
2966         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: Don't assert, return FailureReftestNoImagesGenerated instead.
2967         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2968         (write_test_result):
2969         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py: Remove stray letter t.
2970         * Scripts/webkitpy/layout_tests/models/test_failures.py: Add a new failure type: FailureReftestNoImagesGenerated
2971         (determine_result_type):
2972         (FailureReftestNoImagesGenerated.__init__):
2973         (FailureReftestNoImagesGenerated):
2974         (FailureReftestNoImagesGenerated.message):
2975         * Scripts/webkitpy/layout_tests/port/test.py: Add a test case for integration tests.
2976         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Update test counts.
2977         (MainTest.test_run_singly_actually_runs_tests):
2978         (MainTest.test_unexpected_failures):
2979         (EndToEndTest.test_end_to_end):
2980
2981 2011-12-02  Ryosuke Niwa  <rniwa@webkit.org>
2982
2983         ChangeLog should be able to parse annotated changelogs
2984         https://bugs.webkit.org/show_bug.cgi?id=72703
2985
2986         Reviewed by Eric Seidel.
2987
2988         Make parse_entries_from_file aware of svn blame annotation such as "100000 ossy@webkit.org ",
2989         and extract the revision number for each entry.
2990
2991         Also add a support to extract "svn blame" result from svn/git checkout to scm classes.
2992
2993         * Scripts/webkitpy/common/checkout/changelog.py:
2994         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2995         * Scripts/webkitpy/common/checkout/scm/git.py:
2996         * Scripts/webkitpy/common/checkout/scm/scm.py:
2997         * Scripts/webkitpy/common/checkout/scm/svn.py:
2998
2999 2011-12-02  Eric Seidel  <eric@webkit.org>
3000
3001         Enable parallel testing for Win and Gtk bots
3002         after confirming with Lucas and Martin the bots should be OK.
3003
3004         Unreviewed. (I ran the idea by Lucas and Martin.)
3005
3006         * Scripts/run-webkit-tests:
3007         (platformIsReadyForParallelTesting):
3008
3009 2011-12-02  Martin Robinson  <mrobinson@igalia.com>
3010
3011         Try to fix the GTK+ build.
3012
3013         * gtk/jhbuild.modules: Properly specify the glib-networking
3014         dependency for soup.
3015
3016 2011-12-02  Martin Robinson  <mrobinson@igalia.com>
3017
3018         Fix a syntax error in the committers.py file.
3019
3020         * Scripts/webkitpy/common/config/committers.py: Add a missing comma.
3021
3022 2011-12-02  Ryosuke Niwa  <rniwa@webkit.org>
3023
3024         Add Alan Stearns and Peter Linss to the contributors list.
3025
3026         * Scripts/webkitpy/common/config/committers.py:
3027
3028 2011-12-02  Kent Tamura  <tkent@chromium.org>
3029
3030         [Chromium] Fix compilation warnings for ASSERT()
3031         https://bugs.webkit.org/show_bug.cgi?id=73623
3032
3033         Reviewed by Tony Chang.
3034
3035         * DumpRenderTree/chromium/ImageDiff.cpp:
3036          - Fix fprintf format: %s -> %d for __LINE__
3037          - Do nothing for ASSERT() if NDEBUG.
3038
3039 2011-12-02  Eric Seidel  <eric@webkit.org>
3040
3041         Enable parallel testing for all Mac bots.
3042
3043         Unreviewed.
3044
3045         * Scripts/run-webkit-tests:
3046         (platformIsReadyForParallelTesting):
3047
3048 2011-12-02  Eric Seidel  <eric@webkit.org>
3049
3050         Enable parallel testing for run-webkit-tests on Mac Lion.
3051         I plan to move all the machines to parallel testing shortly
3052         but we're starting with Lion.
3053
3054         Unreviewed.
3055
3056         * Scripts/run-webkit-tests:
3057         (platformIsReadyForParallelTesting):
3058
3059 2011-12-02  Kausalya Madhusudhanan  <kmadhusu@chromium.org>
3060
3061         Added helper method to identify whether the page has custom page size style.
3062         https://bugs.webkit.org/show_bug.cgi?id=73585
3063
3064         Reviewed by Darin Fisher.
3065
3066         * DumpRenderTree/chromium/LayoutTestController.cpp:
3067         (LayoutTestController::LayoutTestController):
3068         (LayoutTestController::hasCustomPageSizeStyle):
3069         * DumpRenderTree/chromium/LayoutTestController.h:
3070
3071 2011-12-01  Ryosuke Niwa  <rniwa@webkit.org>
3072
3073         [NRWT] reftest should support having multiple references per test
3074         https://bugs.webkit.org/show_bug.cgi?id=73613
3075
3076         Reviewed by Dirk Pranke.
3077
3078         Add a support for having multiple reference files for a single test.
3079
3080         Because a reftest succeeds when it matches at least one of expected matches and fails when it matches
3081         at least one of expected mismatches, we compare expected mismatches first in order to minimize
3082         the number of reference files to open on DRT.
3083
3084         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3085         (interpret_test_failures): Remove checks no longer applicable.
3086         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3087         (ResultSummaryTest.test_interpret_test_failures): Ditto.
3088         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3089         (SingleTestRunner.__init__): Remove a bunch of code and just call port.reference_files.
3090         (SingleTestRunner._driver_input):
3091         (SingleTestRunner.run):
3092         (SingleTestRunner._run_reftest): Compare the output of the test to each reference file.
3093         * Scripts/webkitpy/layout_tests/models/test_input.py:
3094         (TestInput.__init__): Remove ref_file and is_mismatch_reftest because they are no longer used.
3095         * Scripts/webkitpy/layout_tests/port/base.py:
3096         (Port.reference_files): Renamed from _reference_file_for. Returns a list of expectation, filename pairs.
3097         (_parse_reftest_list): Now supports parsing multiple entries for a single test.
3098         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3099         (PortTest.test_parse_reftest_list):
3100         * Scripts/webkitpy/layout_tests/port/test.py:
3101         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3102         (MainTest.test_unexpected_failures):
3103         (MainTest.test_reftest_skipped_if_unlisted): Renamed from test_missing_and_unexpected_results.
3104         (EndToEndTest.test_end_to_end):
3105         (EndToEndTest.test_reftest_with_two_notrefs): Added.
3106
3107 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
3108
3109         Build libsoup without gnome dependencies (like keyring).
3110
3111         * gtk/jhbuild.modules:
3112
3113 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
3114
3115         Also build gcrypt and p11-kit, and make them dependencies of
3116         gnutls.
3117
3118         * gtk/jhbuild.modules:
3119
3120 2011-12-02  Kevin Ollivier  <kevino@theolliviers.com>
3121
3122         [wx] Unreviewed build fixes for Windows build.
3123
3124         * waf/build/wxpresets.py:
3125
3126 2011-12-01  Eric Seidel  <eric@webkit.org>
3127
3128         Reviewed by Adam Barth.
3129
3130         webkit-patch post, post-commits, upload should warn when posting to a closed bug, and offer to reopen it
3131         https://bugs.webkit.org/show_bug.cgi?id=32006
3132
3133         I decided not to make it warn, and just have it re-open the bug.
3134         That's not that different from today's behavior which will
3135         just silently attach the patch.
3136
3137         This patch makes behavior between upload and land-safely consistent
3138         (previously one would assign patches and the other would not)
3139         as well as adds the ability for both to ensure that the bug is open.
3140
3141         To test this I had to add a few more methods to MockBugzilla which
3142         (positively) affected a few other test results.
3143
3144         I also made AbstractStep keep a cached copy of the Bug object
3145         and used the cached copy where appropriate (including for 'bug_title').
3146         This should reduce the number of bug fetches we perform.
3147
3148         * Scripts/webkitpy/tool/commands/download_unittest.py:
3149         * Scripts/webkitpy/tool/commands/upload.py:
3150         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3151         * Scripts/webkitpy/tool/mocktool.py:
3152         * Scripts/webkitpy/tool/steps/__init__.py:
3153         * Scripts/webkitpy/tool/steps/abstractstep.py:
3154         * Scripts/webkitpy/tool/steps/closebug.py:
3155         * Scripts/webkitpy/tool/steps/ensurebugisopenandassigned.py: Added.
3156         * Scripts/webkitpy/tool/steps/postdiff.py:
3157         * Scripts/webkitpy/tool/steps/postdiffforcommit.py:
3158         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3159         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3160         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
3161
3162 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
3163
3164         Also pass --no-interact to jhbuild when updating dependencies.
3165
3166         * Scripts/update-webkitgtk-libs:
3167
3168 2011-12-02  Alice Boxhall  <aboxhall@chromium.org>
3169
3170         Make _build_path check more thoroughly that build paths exist.
3171         https://bugs.webkit.org/show_bug.cgi?id=73601
3172
3173         Reviewed by Ojan Vafai.
3174
3175         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3176         (ChromiumMacPort._build_path):
3177
3178 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
3179
3180         Add libffi to the jhbuild modules list as a glib dependency.
3181
3182         Rubber-stamped by Martin Robinson.
3183
3184         * gtk/jhbuild.modules:
3185
3186 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
3187
3188         Build fix. Use internal pcre on glib, make gnutls a dependency of
3189         glib-networking, unset AR_FLAGS for jhbuild builds, and run jhbuild
3190         in non-interactive mode.
3191
3192         * Scripts/update-webkitgtk-libs:
3193         * gtk/jhbuild.modules:
3194         * gtk/run-with-jhbuild:
3195
3196 2011-12-02  Adam Roben  <aroben@apple.com>
3197
3198         Fix for Python 2.6
3199
3200         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3201         (RunUnitTests.countFailures): Removed the flags parameter to re.split, which was only added
3202         in Python 2.7, and used whitespace instead of start-of-string/end-of-string markers when
3203         searching for "Tests that timed out:" etc. This makes our check less strict, but it
3204         shouldn't matter given the kinds of content we parse.
3205
3206 2011-12-02  Adam Roben  <aroben@apple.com>
3207
3208         Fix names of failed/timed out tests in run-api-tests output
3209
3210         Fixes <http://webkit.org/b/73663> run-api-tests prints suite names twice for failed or timed
3211         out tests
3212
3213         We were ending up with the suite name doubled (e.g., "WebKit2.WebKit2.MouseMoveAfterCrash").
3214
3215         Reviewed by Simon Fraser.
3216
3217         * Scripts/run-api-tests:
3218         (runTest): Don't prepend the suite name to $test. It's already been prepended at the start
3219         of this function.
3220
3221 2011-11-29  Martin Robinson  <mrobinson@igalia.com>
3222
3223         [GTK] generate-gtkdoc should respect build type
3224         https://bugs.webkit.org/show_bug.cgi?id=73296
3225
3226         Reviewed by Philippe Normand.
3227
3228         * Scripts/webkitdirs.pm:
3229         (buildAutotoolsProject): Pass the --debug to the generate-gtkdoc script.
3230         * gtk/common.py: If --build is passed give preference to the Debug build directory.
3231
3232 2011-12-02  Tony Chang  <tony@chromium.org>
3233
3234         [nrwt] fix wdiff output
3235         https://bugs.webkit.org/show_bug.cgi?id=73604
3236
3237         Reviewed by Adam Barth.
3238
3239         * Scripts/webkitpy/layout_tests/port/base.py:
3240         (Port.wdiff_text):
3241         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3242         (PortTest.test_wdiff_text):
3243
3244 2011-12-02  Adam Roben  <aroben@apple.com>
3245
3246         Teach build.webkit.org to display how many unit tests failed or timed out
3247
3248         Fixes <http://webkit.org/b/73659> It's hard to tell how many unit tests are failing on
3249         build.webkit.org
3250
3251         We now display something like "5 unit tests failed or timed out". Eventually we might want
3252         to split out how many failure vs. timeouts there were.
3253
3254         Reviewed by Darin Adler.
3255
3256         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3257         (TestWithFailureCount): Moved this class up to the top of the file so it is before any other
3258         classes that may want to subclass it.
3259         (RunUnitTests): Changed to inherit from TestWithFailureCount.
3260         (RunUnitTests.countFailures): Added. Counts the number of tests following the "Tests that
3261         timed out:" and "Tests that failed:" lines, if present.
3262
3263         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3264         (StubStdio):
3265         (StubRemoteCommand):
3266         Added these two stub classes to mimic buildbot's RemoteCommand and log classes.
3267
3268         (RunUnitTestsTest.assertFailures): Helper method to check that we interpreted the results of
3269         the test run correctly.
3270
3271         (RunUnitTestsTest.test_no_failures_or_timeouts):
3272         (RunUnitTestsTest.test_one_failure):
3273         (RunUnitTestsTest.test_multiple_failures):
3274         (RunUnitTestsTest.test_one_timeout):
3275         (RunUnitTestsTest.test_multiple_timeouts):
3276         (RunUnitTestsTest.test_multiple_failures_and_timeouts):
3277         Test various cases.
3278
3279 2011-12-02  Adam Roben  <aroben@apple.com>
3280
3281         Teach prepare-ChangeLog to treat master.cfg as a Python file
3282
3283         Fixes <http://webkit.org/b/73658> prepare-ChangeLog doesn't show modified classes/functions
3284         in buildbot's master.cfg
3285
3286         Reviewed by Darin Adler.
3287
3288         * Scripts/prepare-ChangeLog:
3289         (get_function_line_ranges): Use get_function_line_ranges_for_python if the filename is
3290         master.cfg.
3291
3292 2011-12-02  Martin Robinson  <mrobinson@igalia.com>
3293
3294         [GTK] Create a wrapper script that knows how to install jhbuild and run commands with it
3295         https://bugs.webkit.org/show_bug.cgi?id=73669
3296
3297         Reviewed by Gustavo Noronha Silva.
3298
3299         Add a wrapper script that knows how to install jhbuild and also to wrap commands
3300         in the jhbuild shell.
3301
3302         * Scripts/webkitdirs.pm:
3303         (runAutogenForAutotoolsProject): Use the new wrapper script.
3304         (mustReRunAutogen): Ditto.
3305         (buildAutotoolsProject): Ditto.
3306         * Scripts/webkitpy/layout_tests/port/gtk.py:
3307         (GtkDriver.cmd_line): Ditto.
3308         * gtk/run-with-jhbuild: Added.
3309
3310 2011-12-01  Adam Roben  <aroben@apple.com>
3311
3312         Teach check-webkit-style how to check the syntax of JSON files
3313
3314         Fixes <http://webkit.org/b/73590> check-webkit-style doesn't flag JSON syntax errors
3315
3316         I previously landed this patch as r101711, but the new tests failed on Snow Leopard. This
3317         patch is identical to that one except for two change: assertIn(a, b) (which is new to Python
3318         2.7) has been replaced with assertTrue(a in b), and the test_missing_closing_brace test has
3319         been removed, since its output differs by platform.
3320
3321         Reviewed by Darin Adler.
3322
3323         * Scripts/webkitpy/style/checker.py:
3324         (_all_categories): Added JSONChecker's categories to the set of all categories.
3325         (FileType): Added a JSON type. Incremented other types.
3326         (CheckerDispatcher._file_type): Use the JSON file type for .json files.
3327         (CheckerDispatcher._create_checker): Use a JSONChecker for JSON files.
3328
3329         * Scripts/webkitpy/style/checker_unittest.py:
3330         (CheckerDispatcherDispatchTest.assert_checker_json): Added this helper method.
3331         (CheckerDispatcherDispatchTest.test_json_paths): Added. Based on test_python_paths.
3332
3333         * Scripts/webkitpy/style/checkers/jsonchecker.py: Added. (I didn't name this just "json",
3334         which would have matched our other checkers, because I couldn't figure out how to call
3335         "json.loads" without hitting namespace conflicts.)
3336         (JSONChecker.__init__): Turn of line filtering so that we always check the whole file, not
3337         just the modified lines from a patch.
3338         (JSONChecker.check): Try to parse the lines as JSON. Mark an error if there was an
3339         exception.
3340         (JSONChecker.line_number_from_json_exception): Parse the json modules exception message to
3341         try to extract a line number.
3342
3343         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py: Added.
3344         (MockErrorHandler.__init__):
3345         (MockErrorHandler.turn_off_line_filtering):
3346         (MockErrorHandler.__call__):
3347         Helper class. Copied from xml_unittest.py.
3348
3349         (JSONCheckerTest.test_line_number_from_json_exception): Test the
3350         line_number_from_json_exception helper method.
3351
3352         (JSONCheckerTest.assert_no_error):
3353         (JSONCheckerTest.assert_error):
3354         Helper methods to assert that we did or didn't get an error.
3355
3356         (JSONCheckerTest.mock_handle_style_error): Helper method.
3357
3358         (JSONCheckerTest.test_conflict_marker):
3359         (JSONCheckerTest.test_single_quote):
3360         (JSONCheckerTest.test_init):
3361         (JSONCheckerTest.test_no_error):
3362         Test various cases.
3363
3364 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
3365
3366         [GTK] Add glib, glib-networking, gnutls and libsoup to jhbuild
3367         https://bugs.webkit.org/show_bug.cgi?id=73664
3368
3369         Reviewed by Martin Robinson.
3370
3371         This patch adds our HTTP library and its main dependencies; this
3372         should not affect layout or rendering.
3373
3374         * gtk/jhbuild.modules:
3375
3376 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
3377
3378         [GTK] Also run DumpRenderTree under jhbuild
3379         https://bugs.webkit.org/show_bug.cgi?id=73646
3380
3381         Reviewed by Martin Robinson.
3382
3383         * Scripts/webkitpy/layout_tests/port/gtk.py:
3384         (GtkDriver.cmd_line):
3385
3386 2011-12-02  Hajime Morrita  <morrita@chromium.org>
3387
3388         Unreviewed, rolling out r101751 and r101775.
3389         http://trac.webkit.org/changeset/101751
3390         http://trac.webkit.org/changeset/101775
3391         https://bugs.webkit.org/show_bug.cgi?id=73191
3392
3393         breaks Windows build
3394
3395         * DumpRenderTree/chromium/config.h:
3396         * DumpRenderTree/config.h:
3397         * TestWebKitAPI/config.h:
3398         * WebKitTestRunner/config.h:
3399
3400 2011-12-02  Kentaro Hara  <haraken@chromium.org>
3401
3402         Move run-bindings-tests implementation to webkitpy/bindings/main.py
3403         https://bugs.webkit.org/show_bug.cgi?id=73619
3404
3405         Reviewed by Adam Barth.
3406
3407         As run-bindings-tests has been growing, this patch just moves its implementation
3408         to webkitpy/bindings/main.py to integrate with the rest of webkitpy.
3409
3410         No change in behavior.
3411
3412         * Scripts/run-bindings-tests:
3413         (main):
3414         * Scripts/webkitpy/bindings/__init__.py: Added.
3415         * Scripts/webkitpy/bindings/main.py: Added.
3416         (BindingsTests.__init__):
3417         (BindingsTests.generate_from_idl):
3418         (BindingsTests.generate_supplemental_dependency):
3419         (BindingsTests.detect_changes):
3420         (BindingsTests.run_tests):
3421
3422 2011-12-01  Ilya Tikhonovsky  <loislo@chromium.org>
3423
3424         Tools/Scripts: eliminate find_test_files from Port class.
3425         https://bugs.webkit.org/show_bug.cgi?id=73553
3426
3427         rebaseline.py and chromium_gpu.py use Port.find_test_files() the same way as it is used in Port.tests()
3428         I'd like to replace all calls to find_test_files with tests and eliminate find_tests_files.
3429         Also I'll move _is_test_file() and related functions close to Port.tests().
3430
3431         Reviewed by Dirk Pranke.
3432
3433         * Scripts/webkitpy/layout_tests/port/base.py:
3434         (Port.tests):
3435         (Port.is_reference_html_file):
3436         (Port._has_supported_extension):
3437         (Port._is_test_file):
3438         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3439         (PortTest.test_find_no_paths_specified):
3440         (PortTest.test_find_one_test):
3441         (PortTest.test_find_glob):
3442         (PortTest.test_find_with_skipped_directories):
3443         (PortTest.test_find_with_skipped_directories_2):
3444         (PortTest.test_is_test_file):
3445         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3446         (_default_tests_paths):
3447         (ChromiumGpuLinuxPort.tests):
3448         (ChromiumGpuCgMacPort.tests):
3449         (ChromiumGpuMacPort.tests):
3450         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3451         (ChromiumGpuTest.test_default_tests_paths.test_paths):
3452         (ChromiumGpuTest.test_default_tests_paths):
3453         (ChromiumGpuTest.test_test_files.test_paths):
3454         (ChromiumGpuTest):
3455         (ChromiumGpuTest.test_test_files):
3456         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3457         (get_tests_run.RecordingTestDriver.run_test):
3458         * Scripts/webkitpy/tool/commands/rebaseline.py:
3459         (OptimizeBaselines._optimize_baseline):
3460         (OptimizeBaselines.execute):
3461         (AnalyzeBaselines._analyze_baseline):
3462         (AnalyzeBaselines.execute):
3463
3464 2011-12-01  Hajime Morrita  <morrita@chromium.org>
3465
3466         JS_INLINE and WTF_INLINE should be visible from WebCore
3467         https://bugs.webkit.org/show_bug.cgi?id=73191
3468
3469         Reviewed by Kevin Ollivier.
3470
3471         Removed macro definitions which is now provided by Platform.h
3472
3473         * DumpRenderTree/chromium/config.h:
3474         * DumpRenderTree/config.h:
3475         * TestWebKitAPI/config.h:
3476         * WebKitTestRunner/config.h:
3477
3478 2011-12-01  Hayato Ito  <hayato@chromium.org>
3479
3480         Explicitly pass tolerance=0 to port.diff_image in case of RefTestMismatch failure.
3481         https://bugs.webkit.org/show_bug.cgi?id=73406
3482
3483         Reviewed by Ryosuke Niwa.
3484
3485         WebKitPort's image_diff uses tolerance='0.1' in default.
3486         When reftests fail, we should use tolerace=0 when diff-ing images.
3487
3488         Since ImageDiff on chromium port doesn't use tolerance value as of now,
3489         this change doesn't affect chromium port's behavior.
3490
3491         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3492         (write_test_result):
3493         * Scripts/webkitpy/layout_tests/port/base.py:
3494         (Port.diff_image):
3495         * Scripts/webkitpy/layout_tests/port/chromium.py:
3496         (ChromiumPort.diff_image):
3497         * Scripts/webkitpy/layout_tests/port/test.py:
3498         (TestPort.diff_image):
3499         * Scripts/webkitpy/layout_tests/port/webkit.py:
3500         (WebKitPort.diff_image):
3501         (WebKitPort._start_image_diff_process):
3502         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3503         (MainTest.test_tolerance.ImageDiffTestPort.diff_image):
3504
3505 2011-12-01  Adam Klein  <adamk@chromium.org>
3506
3507         Add Chromium ToT GTest build bots (and group selection support) to flakiness dashboard
3508         https://bugs.webkit.org/show_bug.cgi?id=73599
3509
3510         Reviewed by Ojan Vafai.
3511
3512         * TestResultServer/static-dashboards/builders.js:
3513         * TestResultServer/static-dashboards/dashboard_base.js:
3514         ():
3515         (htmlForTestTypeSwitcher):
3516         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
3517         (testHtmlForTestTypeSwitcherGroup):
3518
3519 2011-12-01  Ryosuke Niwa  <rniwa@webkit.org>
3520
3521         Parse reftest.list and extract types of ref tests
3522         https://bugs.webkit.org/show_bug.cgi?id=66837
3523
3524         Reviewed by Dirk Pranke.
3525
3526         Add support for reftest.list to base port.
3527
3528         * Scripts/webkitpy/common/find_files.py:
3529         (find):
3530         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3531         (SingleTestRunner.__init__):
3532         * Scripts/webkitpy/layout_tests/port/base.py:
3533         (Port.__init__): Initialize self._reftest_list. It's a dictionary mapping from a test directory
3534         to a dictionary of {test path: ("==" or "!=", reference file path)}
3535         (Port._get_reftest_list): Added; calls test_file.parse_reftest_list to fill self._reftest_list.
3536         (Port._reference_file_for): Added; obtains the reference file name given a test name.
3537         (Port.is_reftest): Added; Calls _reference_file_for.
3538         (Port.reftest_expected_filename): Calls _reference_file_for.
3539         (Port.reftest_expected_mismatch_filename): Ditto.
3540         (Port.find_test_files):
3541         (is_reference_html_file): Treat any file that starts with ref- or notref- or ends with
3542         -expected, -expected-mismach, -ref, or -notref as a reference file.
3543         (_is_test_file):
3544         (_parse_reftest_list): Added.
3545         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3546         (PortTest.test_is_test_file):
3547         (PortTest.test_parse_reftest_list):
3548         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3549         (DryrunDriver.run_test):
3550         * Scripts/webkitpy/layout_tests/port/test.py:
3551         (unit_test_filesystem.add_test_file):
3552         (unit_test_filesystem.add_file):
3553         (unit_test_filesystem):
3554         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3555         (get_tests_run.RecordingTestDriver.run_test):
3556         (MainTest.test_unexpected_failures):
3557         (MainTest.test_missing_and_unexpected_results):
3558         (EndToEndTest.test_end_to_end):
3559         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
3560         (Rebaseliner._compile_rebaselining_tests):
3561
3562 2011-12-01  Sheriff Bot  <webkit.review.bot@gmail.com>
3563
3564         Unreviewed, rolling out r101711.
3565         http://trac.webkit.org/changeset/101711
3566         https://bugs.webkit.org/show_bug.cgi?id=73605
3567
3568         Broke 3 webkitpy tests (Requested by rniwa on #webkit).
3569
3570         * Scripts/webkitpy/style/checker.py:
3571         (_all_categories):
3572         (FileType):
3573         (CheckerDispatcher._file_type):
3574         (CheckerDispatcher._create_checker):
3575         * Scripts/webkitpy/style/checker_unittest.py:
3576         (CheckerDispatcherDispatchTest.assert_checker_cpp):
3577         (CheckerDispatcherDispatchTest.test_cpp_paths):
3578         * Scripts/webkitpy/style/checkers/jsonchecker.py: Removed.
3579         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py: Removed.
3580
3581 2011-12-01  Gustavo Noronha Silva  <gns@gnome.org>
3582
3583         Unreviewed. Add myself to GStreamer and WebKit2GTK+ watchlists.
3584
3585         * Scripts/webkitpy/common/config/watchlist:
3586
3587 2011-12-01  Martin Robinson  <mrobinson@igalia.com>
3588
3589         [GTK] Read fonts from the jhbuild root
3590         https://bugs.webkit.org/show_bug.cgi?id=73487
3591
3592         Reviewed by Gustavo Noronha Silva.
3593
3594         Read fonts from the jhbuild root instead of from the system. This will ensure
3595         that all testers use the same fonts instead of leaving this up to luck.
3596
3597         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3598         (initializeFonts): Load fonts from jhbuild root.
3599         * Scripts/webkitpy/layout_tests/port/gtk.py:
3600         (GtkPort.setup_environ_for_server): Pass an environment variable containing
3601         the path to the jhbuild root.
3602         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3603         (WTR::inititializeFontConfigSetting): Load fonts from the jhbuild root.
3604
3605 2011-12-01  Adam Roben  <aroben@apple.com>
3606
3607         Teach check-webkit-style how to check the syntax of JSON files
3608
3609         Fixes <http://webkit.org/b/73590> check-webkit-style doesn't flag JSON syntax errors
3610
3611         Reviewed by Darin Adler.
3612
3613         * Scripts/webkitpy/style/checker.py:
3614         (_all_categories): Added JSONChecker's categories to the set of all categories.
3615         (FileType): Added a JSON type. Incremented other types.
3616         (CheckerDispatcher._file_type): Use the JSON file type for .json files.
3617         (CheckerDispatcher._create_checker): Use a JSONChecker for JSON files.
3618
3619         * Scripts/webkitpy/style/checker_unittest.py:
3620         (CheckerDispatcherDispatchTest.assert_checker_json): Added this helper method.
3621         (CheckerDispatcherDispatchTest.test_json_paths): Added. Based on test_python_paths.
3622
3623         * Scripts/webkitpy/style/checkers/jsonchecker.py: Added. (I didn't name this just "json",
3624         which would have matched our other checkers, because I couldn't figure out how to call
3625         "json.loads" without hitting namespace conflicts.)
3626         (JSONChecker.__init__): Turn of line filtering so that we always check the whole file, not
3627         just the modified lines from a patch.
3628         (JSONChecker.check): Try to parse the lines as JSON. Mark an error if there was an
3629         exception.
3630         (JSONChecker.line_number_from_json_exception): Parse the json modules exception message to
3631         try to extract a line number.
3632
3633         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py: Added.
3634         (MockErrorHandler.__init__):
3635         (MockErrorHandler.turn_off_line_filtering):
3636         (MockErrorHandler.__call__):
3637         Helper class. Copied from xml_unittest.py.
3638
3639         (JSONCheckerTest.test_line_number_from_json_exception): Test the
3640         line_number_from_json_exception helper method.
3641
3642         (JSONCheckerTest.assert_no_error):
3643         (JSONCheckerTest.assert_error):
3644         Helper methods to assert that we did or didn't get an error.
3645
3646         (JSONCheckerTest.mock_handle_style_error): Helper method.
3647
3648         (JSONCheckerTest.test_conflict_marker):
3649         (JSONCheckerTest.test_single_quote):
3650         (JSONCheckerTest.test_init):
3651         (JSONCheckerTest.test_missing_closing_brace):
3652         (JSONCheckerTest.test_no_error):
3653         Test various cases.
3654
3655 2011-12-01  Martin Robinson  <mrobinson@igalia.com>
3656
3657         [GTK] Add a helper function to find the current executable's path
3658         https://bugs.webkit.org/show_bug.cgi?id=73473
3659
3660         Reviewed by Gustavo Noronha Silva.
3661
3662         Update MiniBrowser to not pass the binary directory as an environment variable.
3663         This means that you can move the binaries around without it breaking.
3664
3665         * MiniBrowser/gtk/main.c:
3666         (main): No longer set the environment variable.
3667         * WebKitTestRunner/GNUmakefile.am: No longer add the directory path define.
3668         * WebKitTestRunner/gtk/main.cpp:  Ditto.
3669
3670 2011-12-01  Gustavo Noronha Silva  <gns@gnome.org>
3671
3672         Unreviewed. Fix bad file =(.
3673
3674         * gtk/jhbuild.modules:
3675         * Scripts/webkitdirs.pm:
3676         (runAutogenForAutotoolsProject):
3677
3678 2011-12-01  Gustavo Noronha Silva  <gns@gnome.org>
3679
3680         [GTK] Add freetype to our jhbuild setup
3681         https://bugs.webkit.org/show_bug.cgi?id=73488
3682
3683         Reviewed by Martin Robinson.
3684
3685         This adds the first library to our jhbuild setup, and makes sure
3686         build-webkit calls autogen.sh and make with jhbuild, so that the
3687         environment is properly set.
3688
3689         * Scripts/webkitdirs.pm:
3690         (saveSum):
3691         (hashFile):
3692         (runAutogenForAutotoolsProject): save md5sum of jhbuild-related files, and
3693         call autogen under jhbuild run;
3694         (mustRunAutogen): generalized the arguments change checking to also force
3695         running autogen when jhbuild files change;
3696         (buildAutotoolsProject): run make under jhbuild;
3697         * gtk/jhbuild.modules: add freetype.
3698
3699 2011-12-01  Dominic Mazzoni  <dmazzoni@google.com>
3700
3701         Fix WebKitTestRunner compile warnings with XCode 3.2
3702         https://bugs.webkit.org/show_bug.cgi?id=73378
3703
3704         Reviewed by Chris Fleizach.
3705
3706         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp:
3707         (WTR::AccessibilityTextMarker::AccessibilityTextMarker):
3708         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp:
3709         (WTR::AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
3710         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3711         (WTR::AccessibilityUIElement::AccessibilityUIElement):
3712         (WTR::AccessibilityUIElement::verticalScrollbar):
3713
3714 2011-12-01  Adam Roben  <aroben@apple.com>
3715
3716         Allow committers to use their Trac credentials to force builds on the buildbots
3717
3718         Fixes <http://webkit.org/b/73353>
3719
3720         A new class, CommitterAuth, handles authentication of WebKit committers. CommitterAuth uses
3721         three files to do its job: a config file that contains a list of WebKit committer usernames,
3722         an htdigest file that contains Trac credentials, and JSON file that gives the paths for
3723         those two files.
3724
3725         Reviewed by Darin Adler.
3726
3727         * BuildSlaveSupport/build.webkit.org-config/committer_auth.py: Added.
3728         (Error): Basic wrapper around Exception that we use for cases where we couldn't even check
3729         whether credentials were valid or not.
3730         (CommitterAuth.__init__): Just store the path to auth.json.
3731         (CommitterAuth.auth_json): Load, parse, and return auth.json.
3732         (CommitterAuth.auth_json_filename): Return the path to auth.json.
3733         (CommitterAuth.authenticate): Return true if the user is a WebKit committer and their
3734         credentials are valid Trac credentials. Return false otherwise or if an error occurred while
3735         checking those conditions.
3736         (CommitterAuth.is_webkit_committer): Return true if the user is a WebKit committer. Return
3737         false otherwise or if an exception was thrown.
3738         (CommitterAuth.is_webkit_trac_user): Return true if the username/password are present in the
3739         Trac credentials htdigest file. Return false otherwise or if an exception was thrown.
3740
3741         (CommitterAuth.open_auth_json_file):
3742         (CommitterAuth.open_trac_credentials_file):
3743         (CommitterAuth.open_webkit_committers_file):
3744         Open the specified file. These are mostly useful for testing purposes.
3745
3746         (CommitterAuth.trac_credentials_filename):
3747         (CommitterAuth.webkit_committers_filename):
3748         Return the path to the specified file by retrieving it from auth.json.
3749
3750         (CommitterAuth.webkit_committers): Load and parse the committers file and extract the list
3751         of WebKit committers from it.
3752
3753         * BuildSlaveSupport/build.webkit.org-config/committer_auth_unittest.py: Added.
3754         (CMStringIO.__enter__):
3755         (CMStringIO.__exit__):
3756         Helper class that makes it possible to use StringIO with the "with" statement.
3757
3758         (open_override): Helper context manager for overriding the global "open" function
3759         temporarily.
3760
3761         (CommitterAuthTest.setUp): Set up a somewhat-mocked CommitterAuth that is used by most
3762         tests.
3763         (CommitterAuthTest.fake_open_function): Returns a function that can be used in place of
3764         "open" to test that the expected path was opened.
3765         (CommitterAuthTest.test_authentication_success): Test that committers can authenticate
3766         successfully.
3767         (CommitterAuthTest.test_committer_without_trac_credentials_fails): Test that committers who
3768         somehow have no Trac account can't authenticate.
3769
3770         (CommitterAuthTest.test_fail_to_open_auth_json_file):
3771         (CommitterAuthTest.test_fail_to_open_trac_credentials_file):
3772         (CommitterAuthTest.test_fail_to_open_webkit_committers_file):
3773         Test what happens when we can't open the three files we depend upon.
3774
3775         (CommitterAuthTest.test_implements_IAuth): Test that we fulfill buildbot's expectations for
3776         an authentication class.
3777
3778         (CommitterAuthTest.test_invalid_auth_json_file):
3779         (CommitterAuthTest.test_invalid_committers_file):
3780         (CommitterAuthTest.test_invalid_trac_credentials_file):
3781         (CommitterAuthTest.test_missing_auth_json_keys):
3782         Test what happens when the three files we depend upon are invalid in some way.
3783
3784         (CommitterAuthTest.test_open_auth_json_file):
3785         (CommitterAuthTest.test_open_trac_credentials_file):
3786         (CommitterAuthTest.test_open_webkit_committers_file):
3787         Test that we open the expected paths.
3788
3789         (CommitterAuthTest.test_trac_credentials_filename):
3790         (CommitterAuthTest.test_webkit_committers_filename):
3791         Test that we extract filenames out of auth.json correctly.
3792
3793         (CommitterAuthTest.test_non_committer_fails):
3794         (CommitterAuthTest.test_unknown_user_fails):
3795         (CommitterAuthTest.test_username_is_prefix_of_valid_user):
3796         (CommitterAuthTest.test_wrong_password_fails):
3797         Test various failed authentication attempts.
3798
3799         (CommitterAuthTest.test_webkit_committers): Test that we can parse the list of WebKit
3800         committers out of the committers file correctly.
3801
3802         (CommitterAuthTest.fake_auth_json_file):
3803         (CommitterAuthTest.invalid_auth_json_file):
3804         (CommitterAuthTest.fake_committers_file):
3805         (CommitterAuthTest.invalid_committers_file):
3806         (CommitterAuthTest.fake_htdigest_file):
3807         (CommitterAuthTest.invalid_htdigest_file):
3808         Return various fake files for testing.
3809
3810         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Specify an instance of CommitterAuth
3811         to be used for authentication in the web interface, and specify that only authenticated
3812         users may force builds.
3813
3814 2011-12-01  Adam Roben  <aroben@apple.com>
3815
3816         Add an HTDigestParser class to webkitpy
3817
3818         Fixes <http://webkit.org/b/73575> webkitpy doesn't provide a way to parse htdigest files
3819
3820         This class can be used to parse Apache's htdigest files and check whether a given
3821         username/realm/password tuple is present in the file. Eventually this will be used for
3822         authenticating users on build.webkit.org (<http://webkit.org/b/73353>).
3823
3824         Reviewed by Eric Seidel.
3825
3826         * Scripts/webkitpy/common/net/htdigestparser.py: Added.
3827         (HTDigestParser.__init__): Stores the parsed representation of the file.
3828         (HTDigestParser.authenticate): Hashes the username/realm/password tuple to generate a hashed
3829         password and returns whether the resulting tuple is present in the file.
3830         (HTDigestParser.entries): Just returns the parsed representation of the file.
3831         (HTDigestParser.parse_file): Splits each line on colons and checks that each line has the
3832         expected syntax ('username:realm:hashed_password'). If any line is invalid, we treat the
3833         whole file as invalid and all authentication attempts will fail.
3834
3835         * Scripts/webkitpy/common/net/htdigestparser_unittest.py: Added.
3836         (HTDigestParserTest.assertEntriesEqual): Helper method to assert that fake_htdigest_file,
3837         optionally appended with some extra data, generates the expected entries.
3838         (HTDigestParserTest.test_authenticate): Tests that tuples present in the file can
3839         authenticate, and tuples not present cannot.
3840         (HTDigestParserTest.test_entries): Tests that we get the expected entries from
3841         fake_htdigest_file.
3842
3843         (HTDigestParserTest.test_empty_file):
3844         (HTDigestParserTest.test_too_few_colons):
3845         (HTDigestParserTest.test_too_many_colons):
3846         (HTDigestParserTest.test_invalid_hash):
3847         Test various forms of invalid files.
3848
3849         (HTDigestParserTest.fake_htdigest_file): Returns a fake valid htdigest file for testing.
3850
3851 2011-12-01  Philippe Normand  <pnormand@igalia.com>
3852
3853         [GTK] Make the new 64-bit Release bot part of the core set
3854         https://bugs.webkit.org/show_bug.cgi?id=73570
3855
3856         Reviewed by Adam Roben.
3857
3858         The 64-bit Release bot re-introduced in r101676 replaces the 64-bit
3859         Debug bot which was already part of the core set. The GTK
3860         gardeners are willing to actively maintain it.
3861
3862         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3863         (BuildBot.__init__):
3864         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3865         (test_builder_name_regexps):
3866
3867 2011-12-01  Philippe Normand  <pnormand@igalia.com>
3868
3869         [GTK] Buildslave switch from 32-bit Debug to 64-bit Release
3870         https://bugs.webkit.org/show_bug.cgi?id=73547
3871
3872         Reviewed by Adam Roben.
3873
3874         * BuildSlaveSupport/build.webkit.org-config/config.json: Rename
3875         the 32-bit Debug configuration to 64-bit Release. The new slave is
3876         a 64-bit machine already. The 32-bit slave will be shut down.
3877
3878 2011-12-01  Martin Robinson  <mrobinson@igalia.com>
3879
3880         [GTK] build-jsc should not trigger gtkdoc generation
3881         https://bugs.webkit.org/show_bug.cgi?id=73552
3882
3883         Reviewed by Philippe Normand.
3884
3885         Do not generate gtkdoc when building projects other than WebKit. In particular, this ensures
3886         that build-jsc does not try to generate gtkdoc.
3887
3888         * Scripts/webkitdirs.pm:
3889         (buildAutotoolsProject): Only generate gtkdoc if the project is "WebKit".
3890
3891 2011-12-01  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
3892
3893         tests_run0.txt gets clobbered when re-running failing tests
3894         https://bugs.webkit.org/show_bug.cgi?id=63844
3895
3896         Reviewed by Dirk Pranke.
3897
3898         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3899         (Manager.results_directory):
3900         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3901         (AbstractWorker.__init__):
3902         (_ManagerConnection.start_worker):
3903         (_InlineManager.start_worker):
3904         (_MultiProcessManager.start_worker):
3905         (_WorkerConnection.__init__):
3906         (_InlineWorkerConnection.__init__):
3907         (_MultiProcessWorkerConnection.__init__):
3908         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
3909         (_TestWorker.__init__):
3910         (_TestsMixin.test_cancel):
3911         (_TestsMixin.test_done):
3912         (_TestsMixin.test_unknown_message):
3913         (InterfaceTest.test_managerconnection_is_abstract):
3914         (InterfaceTest.test_workerconnection_is_abstract):
3915         * Scripts/webkitpy/layout_tests/controllers/worker.py:
3916         (Worker.__init__):
3917         (Worker.safe_init):
3918         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3919         (MainTest.test_retries_directory):
3920
3921 2011-12-01  Adam Roben  <aroben@apple.com>
3922
3923         Buildbot fix
3924
3925         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Moved all of the initialization of
3926         BuildmasterConfig not performed by loadBuilderConfig up to the top of the file. This makes
3927         it possible for build steps to reference things like the buildbotURL property of the config.
3928
3929 2011-11-30  Adam Roben  <aroben@apple.com>
3930
3931         Use curl for downloading builds to test slaves
3932
3933         Buildbot's built-in file transfer capabilities are transferring files much more slowly than
3934         curl does. This seems to be due to a combination of buildbot being single-threaded (and thus
3935         often busy servicing web requests, etc.) and using an IPC mechanism with fairly high
3936         overhead (courtesy of the Twisted framework).
3937
3938         Eventually we'd like to make Buildbot's built-in transferring more efficient. In the
3939         meantime we'll try using curl for downloads and keep thinking about a solution for uploads.
3940         This should make the test slaves quite a bit faster, and should ease the CPU load on
3941         build.webkit.org a bit.
3942
3943         Part of <http://webkit.org/b/73484> Mac slaves take 7+ minutes to upload or download a build
3944
3945         Reviewed by Mark Rowe.
3946
3947         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added the CreateWebKitBuildDirectory
3948         to Test slaves. It's run just before DownloadBuiltProduct.
3949         (DownloadBuiltProduct): Changed to be a normal ShellCommand that invokes curl to perform the
3950         download.
3951         (CreateWebKitBuildDirectory): Added. Creates the WebKitBuild directory on a slave.
3952         FileDownload used to do this for us automatically.
3953
3954 2011-11-21  Philippe Normand  <pnormand@igalia.com>
3955
3956         [GTK] enable-webaudio websetting
3957         https://bugs.webkit.org/show_bug.cgi?id=69836
3958
3959         Reviewed by Martin Robinson.
3960
3961         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3962         (LayoutTestController::overridePreference): Update WebKitGTK
3963         enable-webaudio setting when a layout test requests it.
3964
3965 2011-11-30  Ilya Tikhonovsky  <loislo@chromium.org>
3966
3967         Web Inspector: chromium: I'd like to add a script for running perf tests for WebInspector.
3968         https://bugs.webkit.org/show_bug.cgi?id=73079
3969
3970         The idea is to have performance tests for WebInspector.
3971         I was suggested to put these tests into PerformanceTests/inspector.
3972         They produce output in a format that is suitable for chromium perf bot drawing scripts.
3973
3974         I'd like to reuse code for scanning folders for test files.
3975         Because of the fact that original test_files.py has common and layout specific parts
3976         I decided to extract the generic part and put it into webkitpy/common
3977         I think the two packages with name test_files look strange but I have no idea about a better name.
3978
3979         Reviewed by Dirk Pranke.
3980
3981         * Scripts/run-inspector-perf-tests.py: Added.
3982         * Scripts/webkitpy/common/find_files.py: Renamed from Tools/Scripts/webkitpy/layout_tests/port/test_files.py.
3983         (find):
3984         (_normalize):
3985         * Scripts/webkitpy/common/find_files_unittest.py: Added.
3986         (MockWinFileSystem.join):
3987         (MockWinFileSystem):
3988         (MockWinFileSystem.normpath):
3989         (TestWinNormalize.assert_filesystem_normalizes):
3990         (TestWinNormalize.test_mocked_win):
3991         (TestWinNormalize):
3992         (TestWinNormalize.test_win):
3993         * Scripts/webkitpy/layout_tests/port/base.py:
3994         (Port.tests):
3995         (Port.find_test_files):
3996         (Port._driver_class):
3997         (is_reference_html_file):
3998         (_has_supported_extension):
3999         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
4000         (PortTest.test_find_no_paths_specified):
4001         (PortTest.test_find_one_test):
4002         (PortTest.test_find_glob):
4003         (PortTest.test_find_with_skipped_directories):
4004         (PortTest.test_find_with_skipped_directories_2):
4005         (PortTest):
4006         (PortTest.test_is_test_file):
4007         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
4008         (_tests):
4009         * Scripts/webkitpy/layout_tests/port/test.py:
4010         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py: Removed.
4011         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
4012         * Scripts/webkitpy/performance_tests/__init__.py: Added.
4013         * Scripts/webkitpy/performance_tests/perftestsrunner.py: Added.
4014         (PerfTestsRunner.__init__):
4015         (PerfTestsRunner._parse_args):
4016         (PerfTestsRunner._collect_tests._is_test_file):
4017         (PerfTestsRunner._collect_tests):
4018         (PerfTestsRunner.run):
4019         (PerfTestsRunner._run_tests_set):
4020         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: Added.
4021         (MainTest.TestPort):
4022         (MainTest.TestPort.create_driver):
4023         (MainTest.TestDriver.run_test):
4024         (MainTest.TestDriver):
4025         (MainTest.TestDriver.stop):
4026         (MainTest.create_runner):
4027         (MainTest.run_test):
4028         (MainTest.test_run_passing_test):
4029         (MainTest.test_run_silent_test):
4030         (MainTest.test_run_failed_test):
4031         (MainTest.test_run_tonguey_test):
4032         (MainTest.test_run_timeout_test):
4033         (MainTest.test_run_crash_test):
4034         (MainTest.test_run_test_set):
4035         (MainTest.test_collect_tests):
4036         (MainTest):
4037         (MainTest.test_parse_args):
4038         * Scripts/webkitpy/tool/commands/rebaseline.py:
4039         (OptimizeBaselines.execute):
4040         (AnalyzeBaselines.execute):
4041
4042 2011-11-30  nduca@chromium.org  <nduca@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
4043
4044         [chromium] Enable threaded compositing via CCThreadProxy::hasThread only
4045         https://bugs.webkit.org/show_bug.cgi?id=70838
4046
4047         Reviewed by James Robinson.
4048
4049         * DumpRenderTree/chromium/TestShell.cpp:
4050         (TestShell::resetWebSettings):
4051         * DumpRenderTree/chromium/TestShell.h:
4052         (TestShell::threadedCompositingEnabled):
4053         * DumpRenderTree/chromium/WebPreferences.cpp:
4054         (WebPreferences::reset):
4055         (WebPreferences::applyTo):
4056         * DumpRenderTree/chromium/WebPreferences.h:
4057         * DumpRenderTree/chromium/WebViewHost.cpp:
4058         (WebViewHost::WebViewHost):
4059         (WebViewHost::~WebViewHost):
4060
4061 2011-11-30  Chris Fleizach  <cfleizach@apple.com>
4062
4063         AX: Nodes are reporting that focus can be set when they really can't
4064         https://bugs.webkit.org/show_bug.cgi?id=72791
4065
4066         Reviewed by Beth Dakin.
4067
4068         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
4069         (AccessibilityUIElement::isFocusable):
4070         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
4071         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
4072         (WTR::AccessibilityUIElement::isFocusable):
4073
4074 2011-11-30  Alejandro G. Castro  <alex@igalia.com>
4075
4076         Moved myself to the reviewers list.
4077
4078         * Scripts/webkitpy/common/config/committers.py:
4079
4080 2011-11-30  David Levin  <levin@chromium.org>
4081
4082         [chromium] Move didUpdateLayout from WebFrameClient to WebViewClient.
4083         https://bugs.webkit.org/show_bug.cgi?id=73415
4084
4085         Reviewed by Darin Fisher.
4086
4087         * DumpRenderTree/chromium/WebViewHost.cpp:
4088         (WebViewHost::didUpdateLayout): Move didUpdateLayout to account for
4089         it being moved to a new interface and having the parameter removed.
4090         * DumpRenderTree/chromium/WebViewHost.h: Ditto.
4091
4092 2011-11-30  Adam Roben  <aroben@apple.com>
4093
4094         Make NRWT show DRT/WTR build logs when the build fails or --verbose is passed
4095
4096         This will make it a lot easier to investigate build failures on the bots.
4097
4098         Fixes <http://webkit.org/b/71160> NRWT doesn't show build output when building DRT
4099
4100         Reviewed by Eric Seidel.
4101
4102         * Scripts/webkitpy/common/system/executive_mock.py:
4103         (MockExecutive.run_command): Include the mock output in the ScriptError we raise since it
4104         makes the expected output in WebKitPortTest.test_build_driver more closely mimic the output
4105         seen in practice.
4106
4107         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
4108         (ManagerTest.test_http_locking): Pass False for the configure_logging parameter to Printer.
4109         The Printer was modifying the root logger in way that would cause my new tests in
4110         WebKitPort.test_build_driver to fail. The value of the configure_logging parameter doesn't
4111         seem important to the functioning of this test, and passing False makes Printer not modify
4112         the root logger.
4113
4114         * Scripts/webkitpy/layout_tests/port/webkit.py:
4115         (WebKitPort._run_script): Log the output of the command at the DEBUG level so it will show
4116         up when --verbose is passed but not otherwise.
4117         (WebKitPort._build_driver): When an error occurs, log the error message and the script's
4118         output at the ERROR level so it will always show up.
4119
4120         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
4121         (WebKitPortTest.test_build_driver): Test that nothing is logged in the normal, successful
4122         cases. Test that the build scripts' output is logged when --verbose is passed or the build
4123         fails.
4124
4125 2011-11-30  Adam Roben  <aroben@apple.com>
4126
4127         Add a way to set OutputCapture's log level
4128
4129         This will be used by some unit tests I'm planning to add.
4130
4131         Fixes <http://webkit.org/b/73469> OutputCapture can't be used to capture DEBUG messages
4132
4133         Reviewed by Eric Seidel.
4134
4135         * Scripts/webkitpy/common/system/outputcapture.py:
4136         (OutputCapture.__init__): Initialize our internal logging level to INFO, which was the only
4137         level we ever used before this patch.
4138         (OutputCapture.set_log_level): Added. This is useful for testing what log level code that is
4139         being tested uses. Sets the log level for any current or future logging handlers.
4140         (OutputCapture.capture_output): Use our internal logging level instead of always using INFO.
4141
4142         * Scripts/webkitpy/common/system/outputcapture_unittest.py: Added.
4143         (OutputCaptureTest.setUp): Create an OutputCapture to test.
4144         (OutputCaptureTest.log_all_levels): Helper method to log a message at each log level.
4145         (OutputCaptureTest.assertLogged): Helper method to assert that a particular set of strings
4146         was logged.
4147         (OutputCaptureTest.test_initial_log_level): Test that we start out at the INFO level.
4148         (OutputCaptureTest.test_set_log_level): Test that set_log_level correctly modifies the log
4149         level.
4150
4151 2011-11-29  Beth Dakin  <bdakin@apple.com>
4152
4153         https://bugs.webkit.org/show_bug.cgi?id=72751
4154         WebKit2.MouseMoveAfterCrash API test is failing 
4155
4156         Reviewed by Sam Weinig.
4157
4158         Like DumpRenderTree, the NSWindow should act as an active window.
4159         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
4160         (-[ActiveOffscreenWindow isKeyWindow]):
4161         (TestWebKitAPI::PlatformWebView::PlatformWebView):
4162
4163 2011-11-30  Gustavo Noronha Silva  <gns@gnome.org>
4164
4165         Add step to update gtk dependencies to the buildbot
4166         https://bugs.webkit.org/show_bug.cgi?id=73455
4167
4168         Reviewed by Martin Robinson.
4169
4170         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4171
4172 2011-11-30  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
4173
4174         [Qt] Add a fullscreen option to MiniBrowser.
4175         https://bugs.webkit.org/show_bug.cgi?id=73445
4176
4177         Reviewed by Noam Rosenthal.
4178
4179         This bypasses the compositor on the N9 to increase performances
4180         and remove the huge useless gray bar part of the window frame
4181         at the bottom.
4182
4183         * MiniBrowser/qt/BrowserWindow.cpp:
4184         (BrowserWindow::BrowserWindow):
4185         * MiniBrowser/qt/MiniBrowserApplication.cpp:
4186         (printHelp):
4187         (MiniBrowserApplication::handleUserOptions):
4188         * MiniBrowser/qt/MiniBrowserApplication.h:
4189         (WindowOptions::setStartFullScreen):
4190         (WindowOptions::startFullScreen):
4191
4192 2011-11-30  Martin Robinson  <mrobinson@igalia.com>
4193
4194         [GTK] Add an initial jhbuild setup which installs fonts into the WebKitBuild
4195         https://bugs.webkit.org/show_bug.cgi?id=73425
4196
4197         Reviewed by Gustavo Noronha Silva.
4198
4199         Add initial jhbuild support to the GTK+ port. update-webkitgtk-libs will
4200         ensure that the jhbuild root is up-to-date. Currently the only module is
4201         the font module.
4202
4203         * Scripts/update-webkitgtk-libs: Added.
4204         * gtk/common.py: Added a helper to get the number of CPUs.
4205         * gtk/jhbuild.modules: Added.
4206         * gtk/jhbuildrc: Added.
4207
4208 2011-11-30  Simon Hausmann  <simon.hausmann@nokia.com>
4209
4210         [Qt] Remove dependency of Qt DRT on JavaScriptCore.
4211
4212         Reviewed by Csaba Osztrogonác.
4213
4214         * DumpRenderTree/WorkQueue.cpp: Include the correct header file we're using anyway,
4215         instead of one that pulls in JavaScriptCore headers.
4216         * DumpRenderTree/qt/DumpRenderTree.pro: There's no need to pull in the JSC headers
4217         with load(javascriptcore).
4218
4219 2011-11-30  Sheriff Bot  <webkit.review.bot@gmail.com>
4220
4221         Unreviewed, rolling out r101440 and r101442.
4222         http://trac.webkit.org/changeset/101440
4223         http://trac.webkit.org/changeset/101442
4224         https://bugs.webkit.org/show_bug.cgi?id=73429
4225
4226         multiple crashes on layout tests (Requested by hayato on
4227         #webkit).
4228
4229         * DumpRenderTree/chromium/TestShell.cpp:
4230         (TestShell::resetWebSettings):
4231         * DumpRenderTree/chromium/TestShell.h:
4232         * DumpRenderTree/chromium/WebPreferences.cpp:
4233         (WebPreferences::reset):
4234         (WebPreferences::applyTo):
4235         * DumpRenderTree/chromium/WebPreferences.h:
4236         * DumpRenderTree/chromium/WebViewHost.cpp:
4237         (WebViewHost::WebViewHost):
4238         (WebViewHost::~WebViewHost):
4239
4240 2011-11-30  Fady Samuel  <fsamuel@chromium.org>
4241
4242         [Chromium] Fix broken DRT build for Aura Linux
4243         https://bugs.webkit.org/show_bug.cgi?id=72667
4244
4245         Reviewed by Tony Chang.
4246
4247         DRT now builds for Aura Linux. This, more or less, shares the same code as Android.
4248
4249         The following changes have been made:
4250
4251           1. Renamed TestShellAndroid to TestShellLinux.
4252           2. Stub code moved added in TestShellStub that will only compile on non-GTK Linux builds.
4253           3. Code common to Gtk, Aura, and Android moved to TestShellLinux.
4254
4255         * DumpRenderTree/DumpRenderTree.gypi:
4256         * DumpRenderTree/chromium/EventSender.cpp:
4257         (EventSender::keyDown):
4258         * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
4259         * DumpRenderTree/chromium/TestShellGtk.cpp:
4260         * DumpRenderTree/chromium/TestShellLinux.cpp: Copied from Tools/DumpRenderTree/chromium/TestShellGtk.cpp.
4261         (AlarmHandler):
4262         (TestShell::waitTestFinished):
4263         (setupFontconfig):
4264         (platformInit):
4265         * DumpRenderTree/chromium/TestShellStub.cpp: Added.
4266         (checkLayoutTestSystemDependencies):
4267         (openStartupDialog):
4268
4269 2011-11-30  Fady Samuel  <fsamuel@chromium.org>
4270
4271         [Chromium] Set Result Before Early Exit for Fixed Layout Methods in LayoutTestController
4272         https://bugs.webkit.org/show_bug.cgi?id=73328
4273
4274         Reviewed by Kent Tamura.
4275
4276         * DumpRenderTree/chromium/LayoutTestController.cpp:
4277         (LayoutTestController::enableFixedLayoutMode):
4278         (LayoutTestController::setFixedLayoutSize):
4279
4280 2011-11-29  Hayato Ito  <hayato@chromium.org>
4281
4282         Skip writing the result of diff_image since non-chromium ports don't implement diff_image.
4283         https://bugs.webkit.org/show_bug.cgi?id=73381
4284
4285         Reviewed by Ryosuke Niwa.
4286
4287         This is a quick fix for the breakage of tests on non-chromium port.
4288         We should implement diff_image later on non-chromium ports.
4289
4290         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
4291         (write_test_result):
4292
4293 2011-11-29  Balazs Ankes  <Ankes.Balazs@stud.u-szeged.hu>
4294
4295         [NRWT] Fix --platform=qt-5.0 --new-baseline combo
4296         https://bugs.webkit.org/show_bug.cgi?id=72489
4297
<