29303d24e2bfd5fd492be3e2dc929011ed5845ac
[WebKit-https.git] / Tools / ChangeLog
1 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2
3         Reviewed by Mihai Parparita.
4
5         remove fs refs from test_runner, dump_render_tree_thread
6
7         https://bugs.webkit.org/show_bug.cgi?id=52753
8
9         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
10         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
11         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
12         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
13
14 2011-01-19  James Robinson  <jamesr@chromium.org>
15
16         Reviewed by Darin Fisher.
17
18         Implement mozilla's requestAnimationFrame API
19         https://bugs.webkit.org/show_bug.cgi?id=51218
20
21         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
22
23         * DumpRenderTree/chromium/WebViewHost.cpp:
24         (invokeScheduleComposite):
25         (WebViewHost::scheduleAnimation):
26         (WebViewHost::paintInvalidatedRegion):
27         * DumpRenderTree/chromium/WebViewHost.h:
28
29 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
30
31         Unreviewed, build fix.
32
33         Fix a few incorrect "self._filesystem" references introduced in
34         r76184.
35
36         * Scripts/webkitpy/layout_tests/port/chromium.py:
37         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
38
39 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
40
41         Reviewed by Mihai Parparita.
42
43         add a .sep property, abspath(), isabs(), mtime(), and
44         open_text_file_for_writing() to filesystem modules. Some of
45         these properties are not needed in this patch but will be needed
46         in subsequent patches (I'm doing this to avoid having to track
47         multiple versions of a single file).
48
49         Also, change most of the port/* modules to use the filesystem
50         objects instead of referencing the filesystem directly.
51
52         https://bugs.webkit.org/show_bug.cgi?id=52748
53
54         * Scripts/webkitpy/common/system/filesystem.py:
55         * Scripts/webkitpy/common/system/filesystem_mock.py:
56         * Scripts/webkitpy/layout_tests/port/__init__.py:
57         * Scripts/webkitpy/layout_tests/port/base.py:
58         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
59         * Scripts/webkitpy/layout_tests/port/chromium.py:
60         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
61         * Scripts/webkitpy/layout_tests/port/config.py:
62         * Scripts/webkitpy/layout_tests/port/test.py:
63         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
64
65 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
66
67         Reviewed by Anders Carlsson.
68
69         If resetting between tests times out, treat it as a WebProcess crash
70         https://bugs.webkit.org/show_bug.cgi?id=52757
71
72         * WebKitTestRunner/TestController.cpp:
73         (WTR::TestController::runTest):
74
75 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
76
77         Reviewed by Darin Adler.
78
79         https://bugs.webkit.org/show_bug.cgi?id=52739
80         Make it possible for a WebKit2 client to print headers and footers
81
82         Added dummy implementations for new printing UIClient calls.
83
84         * MiniBrowser/mac/BrowserWindowController.m:
85         (-[BrowserWindowController awakeFromNib]):
86         * WebKitTestRunner/TestController.cpp:
87         (WTR::createOtherPage):
88         (WTR::TestController::initialize):
89
90 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
91
92         Reviewed by Ojan Vafai.
93
94         Change webkitpy/layout_tests/port/test.py to use the
95         in-memory filesystem for cleaner unit testing. This
96         change allows us to kill a lot of code that was
97         specific to the test port, at the cost of being a
98         little less clear about how things would work if
99         you didn't have a filesystem.
100
101         https://bugs.webkit.org/show_bug.cgi?id=52605
102
103         * Scripts/webkitpy/layout_tests/port/test.py:
104
105 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
106
107         Unreviewed, build fix.
108
109         Fix test failure caused by committing attachment 79368 instead
110         of attachment 79461 on bug 52604.
111
112         * Scripts/webkitpy/common/system/filesystem_mock.py:
113
114 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
115
116         Reviewed by Mihai Parparita.
117
118         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
119         unit testing. os.walk() is too much of a hassle to implement on
120         top of the in-memory mock filesystem and adding the necessary
121         interface to files_under() gives clients a cleaner API anyway
122         (for this particular usage model).
123
124         https://bugs.webkit.org/show_bug.cgi?id=52691
125
126         * Scripts/webkitpy/common/system/filesystem.py:
127         * Scripts/webkitpy/common/system/filesystem_mock.py:
128         * Scripts/webkitpy/layout_tests/port/test_files.py:
129         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
130
131 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
132
133         Reviewed by Tony Chang.
134
135         Change more modules in the layout-tests code to use the
136         filesystem wrapper for cleaner unit testing.
137
138         This patch also adds the glob() wrapper to the filesystem
139         abstraction.
140         
141         https://bugs.webkit.org/show_bug.cgi?id=52604
142
143         * Scripts/webkitpy/layout_tests/port/test_files.py:
144         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
145         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
146         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
147         * Scripts/webkitpy/common/system/filesystem.py:
148         * Scripts/webkitpy/common/system/filesystem_mock.py:
149
150 2011-01-19  Levi Weintraub  <leviw@chromium.org>
151
152         Unreviewed.
153
154         Updating my email addresses and irc nick.
155
156         * Scripts/webkitpy/common/config/committers.py:
157
158 2011-01-19  Tony Chang  <tony@chromium.org>
159
160         Reviewed by Mihai Parparita.
161
162         [chromium] [linux] if check-sys-deps fails, output the failure reason
163         https://bugs.webkit.org/show_bug.cgi?id=52671
164
165         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
166             error handler functions.
167         * Scripts/webkitpy/layout_tests/port/chromium.py:
168             output the error text from --check-sys-deps
169         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
170
171 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
172
173         Reviewed by Andreas Kling.
174
175         [Qt] QtTestBrowser crashes when closing if Facebook is opened
176         https://bugs.webkit.org/show_bug.cgi?id=52554
177         
178         QtNetworkAccessManager is created in a thread and set as
179         member variable in QWebPage. When the thread is destroyed
180         the object is still used. So fix will set the object to
181         NULL once the thread is destroyed.
182
183         * QtTestBrowser/launcherwindow.cpp:
184         (LauncherWindow::~LauncherWindow):
185
186 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
187
188         Rubber stamped by Csaba Osztrogonac
189
190         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
191
192 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
193
194         Reviewed by Tony Chang.
195
196         new-run-webkit-tests: add a --build-directory command line argument
197
198         Official Google Chrome builds use a non-standard build directory
199         location. This patch adds a --build-directory argument that
200         allows that location to be specified on the command line. Only
201         Chromium-based builds will use this flag for now, but anyone can
202         in the future.
203
204         There are no unit tests for this since it's difficult to test
205         until mock filesystems are fully supported in the code. This was
206         tested by hand for now.
207
208         https://bugs.webkit.org/show_bug.cgi?id=52694
209
210         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
211         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
212         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
213         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
214
215 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
216
217         Not reviewed. Bot fix.
218
219         Remove an inadvertently committed debugging print.
220
221         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
222         (LayoutTestController::notifyDone):
223
224 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
225
226         Reviewed by Sam Weinig.
227
228         WebKitTestRunner should track loading more like DumpRenderTree
229         https://bugs.webkit.org/show_bug.cgi?id=52692
230
231         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
232         This makes some tests that call notifyDone multiple times pass.
233         
234         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
235         (WTR::InjectedBundle::InjectedBundle):
236         (WTR::InjectedBundle::done):
237         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
238         (WTR::InjectedBundle::topLoadingFrame):
239         (WTR::InjectedBundle::setTopLoadingFrame):
240         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
241         (WTR::InjectedBundlePage::InjectedBundlePage):
242         (WTR::InjectedBundlePage::stopLoading):
243         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
244         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
245         (WTR::InjectedBundlePage::didFinishLoadForFrame):
246         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
247         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
248         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
249         (WTR::LayoutTestController::notifyDone):
250         * WebKitTestRunner/TestController.cpp:
251         (WTR::TestController::didReceiveMessageFromInjectedBundle):
252
253 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
254
255         Reviewed by Kent Tamura.
256
257         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
258         https://bugs.webkit.org/show_bug.cgi?id=52678
259         
260         Update path now that WebKit is inside Source.
261
262         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
263
264 2011-01-18  Robert Hogan  <robert@webkit.org>
265
266         Reviewed by Simon Hausmann.
267
268         [Qt] http/tests/incremental/slow-utf8-text.pl fails
269         https://bugs.webkit.org/show_bug.cgi?id=44282
270
271         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
272         (WebCore::DumpRenderTree::dump):
273
274 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
275
276         Reviewed by Mihai Parparita.
277
278         Fix a small race condition that could cause the unit tests for
279         new-run-webkit-tests to fail in a multithreaded environment.
280         There was a small window in the code where one thread would
281         check to see if a thread had raised an exception, do something,
282         and then check to see if the thread was alive. If the other
283         thread raised an exception and exited in between these two
284         steps, the exception would be lost. Flipping the order of the
285         two checks fixes the race, since we will now always check for an
286         exception on the thread before exiting.
287
288         https://bugs.webkit.org/show_bug.cgi?id=51579
289
290         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
291
292 2011-01-18  Eric Seidel  <eric@webkit.org>
293
294         Reviewed by Adam Barth.
295
296         commit-queue dies when test archiving fails
297         https://bugs.webkit.org/show_bug.cgi?id=52617
298
299         I looked at the machine and it had 10 archives already
300         thus find_unused_name was returning None.  I've upped
301         the limit to 100 (per bug) and tested the case where
302         find_unused_name returns None (making archive return None).
303
304         * Scripts/webkitpy/common/system/workspace.py:
305         * Scripts/webkitpy/common/system/workspace_unittest.py:
306         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
307         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
308         * Scripts/webkitpy/tool/commands/queues.py:
309
310 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
311
312         Reviewed by Ojan Vafai.
313
314         Update rebaseline-chromium-webkit-tests unit tests to use a mock
315         filesystem. Also fix a couple of "with" statements missed by
316         r76050.
317
318         https://bugs.webkit.org/show_bug.cgi?id=52487
319
320         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
321
322 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
323
324         Reviewed by Martin Robinson.
325
326         [Gtk] Build fixes for gtk3 build
327         https://bugs.webkit.org/show_bug.cgi?id=52648
328
329         * DumpRenderTree/gtk/EventSender.cpp:
330         (beginDragWithFilesCallback):
331
332 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
333
334         Reviewed by Mihai Parparita.
335
336         Update rebaseline-chromium-webkit-tests to use filesystem objects
337         instead of direct references to os.path, shutil, tempfile, etc.
338
339         This patch doesn't change anything, but will allow subsequent
340         patches to change the unit tests to no longer use the real
341         filesystem.
342
343         This patch adds a bunch more methods to the filesystem object as
344         well.
345
346         https://bugs.webkit.org/show_bug.cgi?id=52482
347
348         * Scripts/webkitpy/common/system/filesystem.py:
349         * Scripts/webkitpy/common/system/filesystem_mock.py:
350         * Scripts/webkitpy/tool/commands/queues.py:
351         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
352         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
353
354 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
355
356         Reviewed by Mihai Parparita.
357
358         new-run-webkit-tests shouldn't crash when you try to run a
359         directory containing only skipped files.
360
361         https://bugs.webkit.org/show_bug.cgi?id=52478
362         
363         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
364         * Scripts/webkitpy/layout_tests/port/test.py:
365         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
366
367 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
368
369         Reviewed by Gustavo Noronha Silva.
370
371         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
372         https://bugs.webkit.org/show_bug.cgi?id=40833
373
374         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
375         GTK+ event sender.
376         (dragWithFilesDragDataGetCallback): Added.
377         (dragWithFilesDragEndCallback): Added.
378         (beginDragWithFilesCallback): Added.
379
380 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
381
382         Reviewed by Adam Barth.
383
384         ews: Add additional watcher to efl ews
385         https://bugs.webkit.org/show_bug.cgi?id=52613
386
387         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
388
389         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
390
391 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
392
393         Reviewed by Alexey Proskuryakov.
394
395         Fix some headers with missing or misspelled #ifndef guards
396         https://bugs.webkit.org/show_bug.cgi?id=52545
397
398         * DumpRenderTree/chromium/TestEventPrinter.h:
399         * DumpRenderTree/chromium/WebPreferences.h:
400
401 2011-01-17  Jessie Berlin  <jberlin@apple.com>
402
403         Reviewed by Anders Carlsson.
404
405         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
406         navigating back to an unreachable URL
407         https://bugs.webkit.org/show_bug.cgi?id=52388
408
409         Add a third parameter (unreachableURL) to queueLoadHTMLString.
410
411         * DumpRenderTree/LayoutTestController.cpp:
412         (queueLoadHTMLStringCallback):
413         (LayoutTestController::queueLoadHTMLString):
414         (LayoutTestController::queueLoadAlternateHTMLString):
415         * DumpRenderTree/LayoutTestController.h:
416
417         * DumpRenderTree/WorkQueueItem.h:
418         (LoadHTMLStringItem::LoadHTMLStringItem):
419
420         * DumpRenderTree/chromium/LayoutTestController.cpp:
421         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
422         (WorkItemLoadHTMLString::run):
423         (LayoutTestController::queueLoadHTMLString):
424
425         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
426         (LoadHTMLStringItem::invoke):
427         * DumpRenderTree/mac/WorkQueueItemMac.mm:
428         (LoadHTMLStringItem::invoke):
429         * DumpRenderTree/win/WorkQueueItemWin.cpp:
430         (LoadHTMLStringItem::invoke):
431
432 2011-01-17  Dan Bernstein  <mitz@apple.com>
433
434         Rubber-stamped by Mark Rowe.
435
436         Update xcodeproj svn:ignore to include xcuserdata.
437
438         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
439         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
440         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
441         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
442         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
443
444 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
445
446         Unreviewed fix after r75908.
447
448         Move WebKit into Source
449         https://bugs.webkit.org/show_bug.cgi?id=52530
450
451         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
452
453 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
454
455         Unreviewed.
456
457         Remove accidentally committed debug printing after r75908.
458
459         * Scripts/webkitdirs.pm:
460
461 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
462
463         Unreviewed.
464
465         Add myself to committers list
466         https://bugs.webkit.org/show_bug.cgi?id=52566
467
468         * Scripts/webkitpy/common/config/committers.py:
469
470 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
471
472         Reviewed by Jeremy Orlow.
473
474         GeolocationController should call stopUpdating on destruction
475         https://bugs.webkit.org/show_bug.cgi?id=52216
476
477         fast/dom/Geolocation/window-close-crash.html requires that a
478         Geolocation watch be started in a secondary window. Consequently,
479         we need to allow geolocation permission and provide a mock
480         geolocation position for the secondary window's
481         GeolocationClientMock.
482
483         * DumpRenderTree/chromium/LayoutTestController.cpp:
484         (LayoutTestController::setGeolocationPermission):
485         (LayoutTestController::setMockGeolocationPosition):
486         (LayoutTestController::setMockGeolocationError):
487         * DumpRenderTree/chromium/TestShell.h:
488         (TestShell::windowList):
489
490 2011-01-16  Adam Barth  <abarth@webkit.org>
491
492         Update more include paths to reflect WebKit move.
493
494         * DumpRenderTree/chromium/EventSender.cpp:
495         (EventSender::keyDown):
496         (EventSender::needsShiftModifier):
497         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
498         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
499
500 2011-01-16  Kent Tamura  <tkent@chromium.org>
501
502         Unreviewed, Chromium build fix.
503
504         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
505
506 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
507
508         Build fix for GTK+ after source directory movement.
509
510         * GNUmakefile.am: Correct include paths.
511
512 2011-01-16  Adam Barth  <abarth@webkit.org>
513
514         Teach svn-apply about WebKit move.
515
516         * Scripts/VCSUtils.pm:
517
518 2011-01-16  Adam Barth  <abarth@webkit.org>
519
520         Rubber-stamped by Eric Seidel.
521
522         Move WebKit into Source
523         https://bugs.webkit.org/show_bug.cgi?id=52530
524
525         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
526         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
527         * DumpRenderTree/qt/DumpRenderTreeQt.h:
528         * DumpRenderTree/qt/GCControllerQt.cpp:
529         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
530         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
531         * DumpRenderTree/qt/TextInputControllerQt.cpp:
532         * DumpRenderTree/wscript:
533         * QtTestBrowser/launcherwindow.h:
534         * Scripts/build-webkit:
535         * Scripts/webkitdirs.pm:
536
537 2011-01-15  Adam Barth  <abarth@webkit.org>
538
539         Teach svn-apply about WebKit2 move.
540
541         * Scripts/VCSUtils.pm:
542
543 2011-01-15  Adam Barth  <abarth@webkit.org>
544
545         Rubber-stamped by Eric Seidel.
546
547         Move WebKit2 into Source
548         https://bugs.webkit.org/show_bug.cgi?id=52438
549
550         * MiniBrowser/qt/MiniBrowser.pro:
551         * Scripts/build-webkit:
552         * Scripts/do-file-rename:
553         * Scripts/do-webcore-rename:
554         * Scripts/test-webkitpy:
555         * Scripts/webkitdirs.pm:
556         * Scripts/webkitpy/style/checker.py:
557         * WebKitTestRunner/DerivedSources.pro:
558         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
559         * WebKitTestRunner/qt/WebKitTestRunner.pro:
560
561 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
562
563         Reviewed by David Levin.
564
565         [chromium] remove obsolete createView method
566         https://bugs.webkit.org/show_bug.cgi?id=52437
567
568         * DumpRenderTree/chromium/WebViewHost.cpp:
569         (WebViewHost::createView):
570         * DumpRenderTree/chromium/WebViewHost.h:
571
572 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
573
574         Reviewed by Geoff Garen.
575
576         ShouldLoadResourceForFrame should use strings, not URLs.
577         https://bugs.webkit.org/show_bug.cgi?id=52476
578
579         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
580         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
581         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
582
583 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
584
585         Reviewed by David Levin.
586
587         Add Tony Gentilcore as a reviewer
588         https://bugs.webkit.org/show_bug.cgi?id=52480
589
590         * Scripts/webkitpy/common/config/committers.py:
591
592 2011-01-14  David Levin  <levin@chromium.org>
593
594         Reviewed by Eric Seidel.
595
596         check-webkit-style: _FunctionState should keep track of where the function name starts.
597         https://bugs.webkit.org/show_bug.cgi?id=52454
598
599         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
600         _FunctionState and logic for setting it correctly.
601         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
602
603 2011-01-14  Vincent Scheib  <scheib@chromium.org>
604
605         Reviewed by David Levin.
606
607         Add support to DumpRenderTree to use the GPU rather than software renderer
608         https://bugs.webkit.org/show_bug.cgi?id=52333
609
610         * DumpRenderTree/chromium/DumpRenderTree.cpp:
611         (main):
612         * Scripts/webkitpy/layout_tests/port/chromium.py:
613         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
614
615 2011-01-14  Tony Chang  <tony@chromium.org>
616
617         Reviewed by Kent Tamura.
618
619         [chromium] update fonts.conf to fix 6 linux tests in drt
620         https://bugs.webkit.org/show_bug.cgi?id=52411
621
622         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
623             chromium's src/webkit/tools/test_shell/resources/fonts.conf
624
625 2011-01-14  Eric Seidel  <eric@webkit.org>
626
627         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
628
629         Reviewed by Adam Barth.
630
631         Fix when running Tools/Scripts/check-webkit-style without arguments.
632         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
633
634         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
635         * Scripts/webkitpy/common/checkout/scm_unittest.py:
636
637 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
638
639         Reviewed by David Levin.
640
641         Store the tempdir object in a variable so it doesn't get deleted too early.
642         https://bugs.webkit.org/show_bug.cgi?id=51875
643
644         * Scripts/update-webkit-auxiliary-libs:
645         * Scripts/update-webkit-support-libs:
646
647 2011-01-14  Eric Seidel  <eric@webkit.org>
648
649         Unreviewed.  Make it work in python 2.5.
650
651         webkit-patch suggest-reviewers dies when ChangeLogs are missing
652         https://bugs.webkit.org/show_bug.cgi?id=49158
653
654         * Scripts/webkitpy/common/checkout/api_unittest.py:
655
656 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
657
658         Unreviewed, rolling out r75774.
659         http://trac.webkit.org/changeset/75774
660         https://bugs.webkit.org/show_bug.cgi?id=52431
661
662         gtk builds were broken (Requested by loislo2 on #webkit).
663
664         * Scripts/webkitpy/common/checkout/scm.py:
665
666 2011-01-14  David Levin  <levin@chromium.org>
667
668         Reviewed by Shinichiro Hamaji.
669
670         check-webkit-style: _FunctionState should detect pure functions.
671         https://bugs.webkit.org/show_bug.cgi?id=52428
672
673         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
674         is a pure virtual function.
675         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
676         virtual functions are correctly detected.
677
678 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
679
680         Reviewed by Yury Semikhatsky.
681
682         Just small fix for problem with check-webkit-style.
683         It just didn't work for this patch.
684         Old code can't concatenate a list of strings with None.
685
686         * Scripts/webkitpy/common/checkout/scm.py:
687
688 2011-01-13  David Levin  <levin@chromium.org>
689
690         Reviewed by Shinichiro Hamaji.
691
692         check-webkit-style: _FunctionState should use Position to know where items are.
693         https://bugs.webkit.org/show_bug.cgi?id=52424
694
695         * Scripts/webkitpy/style/checkers/cpp.py:
696         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
697         (detect_functions): Changed to pass Position's to _FunctionState.begin and
698         did some minor clean-up.
699         (*): Other changes are simply about converting to use the Position's in_FunctionState
700         instead of line numbers.
701         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
702         to verify the positions stored in _FunctionState.
703
704 2011-01-13  Eric Seidel  <eric@webkit.org>
705
706         Reviewed by David Levin.
707
708         webkit-patch suggest-reviewers dies when ChangeLogs are missing
709         https://bugs.webkit.org/show_bug.cgi?id=49158
710
711         This is not the most elegant, but it is a very safe fix to this bug.
712         One advantage of catching ScriptError like this instead of adding a
713         new added_or_modified_files or fixing all changed_files callers
714         to use a more specific change_files variant, is that we catch
715         all kinds of ScriptErrors which might cause our (non-essential)
716         suggest-reviewers code to fail out.  This should make passing
717         --suggest-reviewers to webkit-patch upload much more robust
718         and may even make it possible for us to make it default.
719
720         The root of the problem here is that SCM.changed_files includes
721         deleted ChangeLog paths (from moves, etc) which then when we ask
722         SVN/Git for the contents of the file at that revision, the command
723         errors out and Executive.run_command raises a ScriptError.
724
725         In the future we might fix this differently by making all current
726         callers of chagned_files use a more specific method for requesting
727         what types of changes they're interested in (adds, modifies, deletes, etc.)
728
729         * Scripts/webkitpy/common/checkout/api.py:
730         * Scripts/webkitpy/common/checkout/api_unittest.py:
731
732 2011-01-13  Dan Bernstein  <mitz@apple.com>
733
734         Reviewed by Alexey Proskuryakov.
735
736         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
737         https://bugs.webkit.org/show_bug.cgi?id=52419
738
739         Allow to further control the behavior of the willSendRequest delegate callback by making it
740         set a different URL in the new request.
741
742         * DumpRenderTree/LayoutTestController.cpp:
743         (addURLToRedirectCallback): Added.
744         (LayoutTestController::staticFunctions): Added addURLToRedirect.
745         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
746         (LayoutTestController::redirectionDestinationForURL): Added this getter.
747         * DumpRenderTree/LayoutTestController.h:
748         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
749         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
750         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
751         change the URL in the new request to the redirect destination.
752
753 2011-01-13  Eric Seidel  <eric@webkit.org>
754
755         Reviewed by Mihai Parparita.
756
757         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
758         https://bugs.webkit.org/show_bug.cgi?id=52416
759
760         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
761         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
762
763         I also added FIXMEs about the changed_files returning deleted files problem
764         which is causing the other most common exception for suggest-reviewers
765         (and is probably breaking sheriff-bots blame detection).
766
767         * Scripts/webkitpy/common/checkout/api.py:
768         * Scripts/webkitpy/common/checkout/api_unittest.py:
769         * Scripts/webkitpy/common/checkout/scm.py:
770
771 2011-01-13  Eric Seidel  <eric@webkit.org>
772
773         Reviewed by Adam Barth.
774
775         results archives from commit-queue are too large to upload
776         https://bugs.webkit.org/show_bug.cgi?id=52405
777
778         * Scripts/webkitpy/common/system/filesystem.py:
779         * Scripts/webkitpy/common/system/filesystem_mock.py:
780         * Scripts/webkitpy/tool/commands/queues.py:
781
782 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
783
784         Reviewed by Martin Robinson.
785
786         [gtk] Zero-sized font does not yet work
787         https://bugs.webkit.org/show_bug.cgi?id=49793
788
789         Set minimum-font-size to 0 for the DRT.
790
791         * DumpRenderTree/gtk/DumpRenderTree.cpp:
792         (resetDefaultsToConsistentValues):
793
794 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
795
796         Reviewed by Darin Adler.
797
798         Make old-run-webkit-tests more robust on buildbots
799         https://bugs.webkit.org/show_bug.cgi?id=52364
800
801         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
802
803 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
804
805         Reviewed by Darin Adler.
806
807         Make old-run-webkit-tests more robust on buildbots
808         https://bugs.webkit.org/show_bug.cgi?id=52364
809
810         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
811
812 2011-01-13  Tony Chang  <tony@chromium.org>
813
814         Reviewed by Kent Tamura.
815
816         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
817         https://bugs.webkit.org/show_bug.cgi?id=52332
818
819         Forked Info.plist is not longer needed.
820
821         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
822
823 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
824
825         Reviewed by Timothy Hatcher.
826
827         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
828         to be passed directly to WebInspector.UIString
829
830         https://bugs.webkit.org/show_bug.cgi?id=52365
831
832         * Scripts/check-inspector-strings:
833
834 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
835
836         Unreviewed, rolling out r74881.
837         http://trac.webkit.org/changeset/74881
838         https://bugs.webkit.org/show_bug.cgi?id=52357
839
840         The EFL builder has been red for days (Requested by abarth on
841         #webkit).
842
843         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
844         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
845
846 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
847
848         Reviewed by David Levin.
849
850         Add beforeunload support to WebKitTestRunner
851         https://bugs.webkit.org/show_bug.cgi?id=52353
852         
853         This makes a number of currently failing tests pass.
854
855         * WebKitTestRunner/TestController.cpp:
856         (WTR::runBeforeUnloadConfirmPanel):
857         (WTR::createOtherPage):
858         (WTR::TestController::initialize):
859
860 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
861
862         Reviewed by Sam Weinig.
863
864         Detect, identify and recover from WebProcess crashes in run-webkit-tests
865         https://bugs.webkit.org/show_bug.cgi?id=52330
866
867         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
868         a web process crash.
869         * WebKitTestRunner/TestController.cpp:
870         (WTR::TestController::initialize): Set up a processDidCrash
871         callback.
872         (WTR::TestController::processDidCrash): Report that the Web process
873         crashed.
874         * WebKitTestRunner/TestController.h:
875
876 2011-01-12  David Levin  <levin@chromium.org>
877
878         Reviewed by Shinichiro Hamaji.
879
880         check-webkit-style -- close_expression function doesn't work correctly.
881         https://bugs.webkit.org/show_bug.cgi?id=52272
882
883         * Scripts/webkitpy/style/checkers/cpp.py:
884         (Position.__str__): Added a way to convert it to a string which is useful in tests.
885         (Position.__cmp__): Added a way to compare Position which is useful in tests and
886         generally useful (for upcoming code changes).
887         (close_expression): Changed to use Position for input and output.
888         Also, fixed many bugs such as only working correctly for parenthesis,
889         not working correctly if given an offset in a line and not finding
890         the real closing element if there were multiple closing elements in
891         the same line.
892         (detect_functions): Adjusted due to the change in arguments for
893         close_expression.
894         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
895         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
896         two positions are the same.
897         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
898         (CppStyleTest.test_close_expression): Added tests to catch the issues
899         that were fixed.
900
901 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
902
903         Unreviewed, rolling out r75576.
904         http://trac.webkit.org/changeset/75576
905         https://bugs.webkit.org/show_bug.cgi?id=52304
906
907         broke rebaseline-chromium-webkit-test (Requested by thakis on
908         #webkit).
909
910         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
911         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
912         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
913         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
914         * Scripts/webkitpy/layout_tests/port/base.py:
915         * Scripts/webkitpy/layout_tests/port/chromium.py:
916         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
917         * Scripts/webkitpy/layout_tests/port/test.py:
918         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
919         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
920         * Scripts/webkitpy/style/checkers/test_expectations.py:
921         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
922
923 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
924
925         Reviewed by Darin Adler.
926
927         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
928         https://bugs.webkit.org/show_bug.cgi?id=52307
929
930         * Scripts/old-run-webkit-tests:
931
932 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
933
934         Reviewed by Martin Robinson.
935
936         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
937         https://bugs.webkit.org/show_bug.cgi?id=50867
938
939         Fixed library extention for Mac in webkitdirs.pm and type conflict in
940         TestNetscapePlugin.cpp 
941
942         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
943         * Scripts/webkitdirs.pm:
944
945 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
946
947         Reviewed by Pavel Feldman.
948
949         Add check-inspector-strings script.
950
951         https://bugs.webkit.org/show_bug.cgi?id=52295
952
953         * Scripts/check-inspector-strings: Added.
954
955 2011-01-12  Adam Roben  <aroben@apple.com>
956
957         Advertise the .testnetscape file extension on Windows
958
959         Fixes <http://webkit.org/b/52298>
960         plugins/no-mime-with-valid-extension.html fails on Windows
961
962         Reviewed by Dan Bernstein.
963
964         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
965         FileExtents field to map the .testnetscape file extension to the
966         application/x-webkit-test-netscape MIME type, just as we do on Mac.
967
968 2011-01-12  Adam Barth  <abarth@webkit.org>
969
970         Reviewed by Eric Seidel.
971
972         Make webkit-patch support subdirectories for SVN checkouts
973         https://bugs.webkit.org/show_bug.cgi?id=52261
974
975         os.relpath does not exist on Python 2.5, so we need to call our version
976         of the API.
977
978         * Scripts/webkitpy/common/checkout/scm.py:
979
980 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
981
982         Reviewed by Eric Seidel.
983
984         Close additional pages opened during a test once the test completes.
985         https://bugs.webkit.org/show_bug.cgi?id=52276
986
987         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
988         (WTR::InjectedBundle::done):
989
990 2011-01-11  David Levin  <levin@chromium.org>
991
992         Reviewed by Eric Seidel.
993
994         Errors should be separated from the command line in bot messages.
995         https://bugs.webkit.org/show_bug.cgi?id=52275
996
997         * Scripts/webkitpy/common/system/executive.py:
998         (ScriptError.message_with_output): Added a newline to separate the command
999         line from the errors.
1000         * Scripts/webkitpy/common/system/executive_unittest.py:
1001         (ScriptErrorTest.test_message_with_output): Added tests for the various code
1002         paths in message_with_output.
1003
1004 2011-01-11  Eric Seidel  <eric@webkit.org>
1005
1006         Unreviewed.
1007
1008         commit-queue should know how to upload archived results (for test flakes or general failures)
1009         https://bugs.webkit.org/show_bug.cgi?id=52048
1010
1011         The zips are mostly empty due to forgetting -r.
1012         Expected diffs were not being pulled from the archive due
1013         to the archive having longer paths than I realized.
1014
1015         * Scripts/webkitpy/common/system/workspace.py:
1016         * Scripts/webkitpy/common/system/workspace_unittest.py:
1017         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1018         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1019
1020 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
1021
1022         Reviewed by Ojan Vafai.
1023
1024         The current modifier parsing code in test_expectations is
1025         fragile and hard-coded, so it's not easy to understand the logic
1026         or easily add new types of modifiers (like GPU vs. CPU testing
1027         for graphics tests, or 32-bit vs. 64-bit differences).
1028
1029         This is the first of two patches that will add in more generic
1030         support and then eliminate the GPU-specific test expectations
1031         files for Chromium.
1032
1033         This patch adds two standalone objects for handling modifiers. The
1034         rules for interpreting modifiers, precedence, and conflicts are
1035         given in the docstring to the ModifierMatcher class, which
1036         returns ModifierMatchResult objects.
1037         
1038         This patch also adds routines to the Port interface and a
1039         default set of values in the base object, in order to obtain the
1040         values needed on a given test run. These values are then passed
1041         to the expectation parser. This also allows us to clean up the
1042         logic used to lint all of the different configurations in a
1043         single test_expectations.txt file.
1044
1045         The next patch will merge in the separate GPU expectations file.
1046
1047         https://bugs.webkit.org/show_bug.cgi?id=51222
1048
1049         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1050         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1051         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1052         * Scripts/webkitpy/layout_tests/port/base.py:
1053         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1054         * Scripts/webkitpy/layout_tests/port/chromium.py:
1055         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1056         * Scripts/webkitpy/layout_tests/port/test.py:
1057         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1058         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1059
1060 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
1061
1062         Reviewed by Adam Barth.
1063
1064         Make webkit-patch support subdirectories for SVN checkouts
1065         https://bugs.webkit.org/show_bug.cgi?id=52261
1066
1067         * Scripts/webkitpy/common/checkout/scm.py:
1068         * Scripts/webkitpy/style_references.py:
1069         * Scripts/webkitpy/tool/main.py:
1070         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1071
1072 2011-01-11  Eric Seidel  <eric@webkit.org>
1073
1074         Unreviewed.
1075
1076         commit-queue should know how to upload archived results (for test flakes or general failures)
1077         https://bugs.webkit.org/show_bug.cgi?id=52048
1078
1079         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
1080         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
1081
1082         * Scripts/webkitpy/common/system/workspace.py:
1083         * Scripts/webkitpy/common/system/workspace_unittest.py:
1084         * Scripts/webkitpy/tool/commands/queues.py:
1085
1086 2011-01-11  Sam Weinig  <sam@webkit.org>
1087
1088         Roll r75474 back in.
1089
1090 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1091
1092         Reviewed by Kenneth Rohde Christiansen.
1093
1094         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
1095         https://bugs.webkit.org/show_bug.cgi?id=51204
1096
1097         * QtTestBrowser/webpage.h:
1098         (QtNAMThread::QtNAMThread):
1099         (QtNAMThread::networkAccessManager):
1100         (QtNAMThread::run):
1101
1102 2011-01-11  Peter Varga  <pvarga@webkit.org>
1103
1104         Unreviewed.
1105
1106         Add myself to committers' list.
1107
1108         * Scripts/webkitpy/common/config/committers.py:
1109
1110 2011-01-11  Eric Seidel  <eric@webkit.org>
1111
1112         Reviewed by Adam Barth.
1113
1114         commit-queue should know how to upload archived results (for test flakes or general failures)
1115         https://bugs.webkit.org/show_bug.cgi?id=52048
1116
1117         Now the queue will always upload results.  Either the entire zip, or just
1118         the diffs.txt in the case of text failures.
1119
1120         This should make understanding flakes much easier, and paves the way
1121         for having the EWS run layout tests (and upload failures).
1122
1123         In order to upload .zip files I had to teach bugzilla.py to autodetect
1124         mime types from the filename.  Since mimetypes.py doesn't include a mapping
1125         for .patch files, I have it add one before calling guess_type.
1126
1127         We may find that always uploading the whole zip instead of just the -diffs.txt
1128         file is preferable, but for now I'm keeping the old behavior because it makes
1129         quickly understanding text failures easy.
1130
1131         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1132         * Scripts/webkitpy/common/system/workspace.py: Added.
1133         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
1134         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1135         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1136         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1137         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1138         * Scripts/webkitpy/tool/commands/queues.py:
1139         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1140
1141 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
1142
1143         Unreviewed, rolling out r75464.
1144         http://trac.webkit.org/changeset/75464
1145         https://bugs.webkit.org/show_bug.cgi?id=52193
1146
1147         Followup rollout for 75474 (Requested by Ossy on #webkit).
1148
1149         * MiniBrowser/mac/BrowserWindowController.m:
1150         (-[BrowserWindowController awakeFromNib]):
1151         * MiniBrowser/win/BrowserView.cpp:
1152         (BrowserView::create):
1153         * WebKitTestRunner/TestController.cpp:
1154         (WTR::createOtherPage):
1155         (WTR::TestController::initialize):
1156
1157 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1158
1159         Reviewed by Csaba Osztrogonác.
1160
1161         [Qt] Baseline qt_minimal configuration
1162         https://bugs.webkit.org/show_bug.cgi?id=51313
1163
1164         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1165         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
1166         QT_NO_UNDOSTACK guard.
1167
1168         * QtTestBrowser/launcherwindow.cpp:
1169         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
1170         guards.
1171         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
1172         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
1173         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
1174         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
1175
1176         * QtTestBrowser/launcherwindow.h:
1177         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
1178         * QtTestBrowser/locationedit.h: Ditto.
1179
1180         * QtTestBrowser/mainwindow.cpp:
1181         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
1182         QT_NO_UNDOSTACK guards.
1183         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
1184         (MainWindow::changeLocation): Ditto.
1185         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
1186         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
1187
1188         * QtTestBrowser/webpage.cpp:
1189         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
1190         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
1191
1192         * QtTestBrowser/webview.cpp:
1193         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
1194         (WebViewGraphicsBased::animatedYFlip): Ditto.
1195
1196 2011-01-10  Sam Weinig  <sam@webkit.org>
1197
1198         Fix build.
1199
1200         * MiniBrowser/mac/BrowserWindowController.m:
1201         (-[BrowserWindowController awakeFromNib]):
1202         * MiniBrowser/win/BrowserView.cpp:
1203         (BrowserView::create):
1204         * WebKitTestRunner/TestController.cpp:
1205         (WTR::createOtherPage):
1206         (WTR::TestController::initialize):
1207
1208 2011-01-10  Eric Seidel  <eric@webkit.org>
1209
1210         Reviewed by Ojan Vafai.
1211
1212         style-queue messages are way too long for big patches
1213         https://bugs.webkit.org/show_bug.cgi?id=52161
1214
1215         We definitely could build much fancier list-to-string-with-limit functions
1216         but this should be sufficient for our needs at the moment.
1217
1218         * Scripts/webkitpy/common/system/executive.py:
1219         * Scripts/webkitpy/common/system/executive_unittest.py:
1220
1221 2011-01-10  Tony Chang  <tony@chromium.org>
1222
1223         Unreviewed, rolling out r75398.
1224         http://trac.webkit.org/changeset/75398
1225         https://bugs.webkit.org/show_bug.cgi?id=52008
1226
1227         Some layout tests are crashing on Chromium Win.
1228
1229         * DumpRenderTree/chromium/WebViewHost.cpp:
1230         (WebViewHost::updatePaintRect):
1231         * DumpRenderTree/chromium/WebViewHost.h:
1232
1233 2011-01-10  Adam Roben  <aroben@apple.com>
1234
1235         Roll out r75392
1236
1237         It isn't needed now that r75289 has been rolled out.
1238
1239         * Scripts/run-javascriptcore-tests:
1240
1241 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
1242
1243         Reviewed by Anders Carlsson.
1244
1245         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
1246         https://bugs.webkit.org/show_bug.cgi?id=52160
1247
1248         * WebKitTestRunner/mac/TestControllerMac.mm:
1249         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
1250         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
1251         anyway.
1252
1253 2011-01-10  Tony Chang  <tony@chromium.org>
1254
1255         Reviewed by Mihai Parparita.
1256
1257         [chromium] fix for animated gif layout tests
1258         https://bugs.webkit.org/show_bug.cgi?id=52008
1259
1260         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
1261             to trigger gif animations.
1262         (WebViewHostPaintTask::WebViewHostPaintTask):
1263         (WebViewHostPaintTask::runIfValid):
1264         (WebViewHost::updatePaintRect):
1265         * DumpRenderTree/chromium/WebViewHost.h:
1266         (WebViewHost::taskList):
1267
1268 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
1269
1270         Reviewed by Xan Lopez.
1271
1272         [GTK] Fix gtk2 compilation for master
1273         https://bugs.webkit.org/show_bug.cgi?id=51885
1274
1275         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1276         (createBitmapContextFromWebView): Replaced the old
1277         gdk_drawable_get_size with gdk_pixmap_get_size.
1278
1279 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
1280
1281         Reviewed by Laszlo Gombos.
1282
1283         [WINCE] Reenable NPAPI after r75203
1284         https://bugs.webkit.org/show_bug.cgi?id=52109
1285
1286         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
1287         it with !isEfl(), because EFL port does not support NPAPI (yet).
1288
1289         * Scripts/build-webkit:
1290
1291 2011-01-10  Adam Roben  <aroben@apple.com>
1292
1293         Skip some asserting JS tests
1294
1295         See <http://webkit.org/b/52156>.
1296
1297         * Scripts/run-javascriptcore-tests:
1298
1299 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
1300
1301         Reviewed by Xan Lopez.
1302
1303         [GTK] build-webkit disable Blob support via arguments passed to automake
1304         https://bugs.webkit.org/show_bug.cgi?id=52097
1305
1306         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
1307         build-webkit.
1308
1309 2011-01-10  Adam Roben  <aroben@apple.com>
1310
1311         Use the same name and description for TestNetscapePlugin on Windows and
1312         Mac
1313
1314         Fixes <http://webkit.org/b/52151>
1315         fast/frames/iframe-reparenting-plugins.html fails on Windows
1316
1317         Reviewed by Steve Falkenburg.
1318
1319         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
1320         the name and description from Mac's Info.plist.
1321
1322 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
1323
1324         Reviewed by Laszlo Gombos.
1325
1326         [Qt][WK2] Guard gcc-specific syntax
1327
1328         Non-gcc based compliers choke on the "-include"
1329         syntax for preinclude, place guard around it.
1330
1331         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1332         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1333
1334 2011-01-10  Andreas Kling  <kling@webkit.org>
1335
1336         Reviewed by Simon Hausmann.
1337
1338         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
1339         https://bugs.webkit.org/show_bug.cgi?id=52111
1340
1341         When getting a createNewPage() callback from QWKPage, create the
1342         new page with the same QWKContext as the page that is passed to
1343         the callback.
1344
1345         * MiniBrowser/qt/BrowserView.h:
1346         * MiniBrowser/qt/BrowserWindow.cpp:
1347         (newPageFunction):
1348         (BrowserWindow::BrowserWindow):
1349         * MiniBrowser/qt/BrowserWindow.h:
1350
1351 2011-01-10  Andreas Kling  <kling@webkit.org>
1352
1353         Reviewed by Kenneth Rohde Christiansen.
1354
1355         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
1356
1357         BrowserView set its own useless createNewPage() callback on QWKPage.
1358         This was immediately overridden by BrowserWindow anyway, so remove
1359         the BrowserView one.
1360
1361         * MiniBrowser/qt/BrowserView.cpp:
1362         (BrowserView::BrowserView):
1363
1364 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
1365
1366         Reviewed by Jeremy Orlow.
1367
1368         [Chromium] Remove non-client-based Geolocation code
1369         https://bugs.webkit.org/show_bug.cgi?id=50921
1370
1371         * DumpRenderTree/chromium/LayoutTestController.cpp:
1372         (LayoutTestController::setGeolocationPermission):
1373         (LayoutTestController::setMockGeolocationPosition):
1374         (LayoutTestController::setMockGeolocationError):
1375         * DumpRenderTree/chromium/WebViewHost.cpp:
1376         (WebViewHost::geolocationClientMock):
1377         (WebViewHost::reset):
1378         * DumpRenderTree/chromium/WebViewHost.h:
1379
1380 2011-01-10  Eric Seidel  <eric@webkit.org>
1381
1382         Reviewed by Adam Barth.
1383
1384         Commit bot tried to land r? cq+ patch
1385         https://bugs.webkit.org/show_bug.cgi?id=36638
1386
1387         It should now be possible to post a patch with r? and cq+ and the
1388         commit-queue will correctly wait for the r+ before attempting to land the patch.
1389         (This was a feature requested by several users.)
1390
1391         One caveat: We don't actually reject r-, cq+ patches from the queue
1392         (we just ignore them), but I think that's OK for now.
1393
1394         I also noticed that setting r- once a commit-queue node had grabbed
1395         a patch would not properly cancel the landing.  That's fixed and
1396         tested in this patch.
1397
1398         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1399         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1400         * Scripts/webkitpy/tool/bot/feeders.py:
1401         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1402
1403 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
1404
1405         Reviewed by Kenneth Rohde Christiansen.
1406
1407         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
1408         https://bugs.webkit.org/show_bug.cgi?id=51934
1409
1410         When accessing the network from the destructor of QWebPage, the network access manager
1411         was already deleted because the object WebPage was already destructed.
1412
1413         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
1414         The object is now destructed in the destructor of QObject.
1415
1416         * QtTestBrowser/webpage.cpp:
1417         (WebPage::WebPage):
1418         (WebPage::setQnamThreaded):
1419         * QtTestBrowser/webpage.h:
1420         (QtNAMThread::QtNAMThread):
1421
1422 2011-01-08  Eric Seidel  <eric@webkit.org>
1423
1424         Reviewed by Ojan Vafai.
1425
1426         test_failures.py should not mention TestShell (long live DumpRenderTree!)
1427         https://bugs.webkit.org/show_bug.cgi?id=52067
1428
1429         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
1430         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
1431
1432         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1433
1434 2011-01-08  Eric Seidel  <eric@webkit.org>
1435
1436         Reviewed by Mihai Parparita.
1437
1438         commit-queue hangs when the ChangeLog diff is bad
1439         https://bugs.webkit.org/show_bug.cgi?id=52072
1440
1441         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
1442         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
1443
1444 2011-01-08  Adam Barth  <abarth@webkit.org>
1445
1446         Teach svn-apply how to re-write WebCore to Source/WebCore.
1447
1448         * Scripts/VCSUtils.pm:
1449
1450 2011-01-07  Adam Barth  <abarth@webkit.org>
1451
1452         Rubber-stamped by Eric Seidel.
1453
1454         Move WebCore to Source
1455         https://bugs.webkit.org/show_bug.cgi?id=52050
1456
1457         Update the tools to understand WebCore's new location.
1458
1459         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1460         * DumpRenderTree/wscript:
1461         * GNUmakefile.am:
1462         * Scripts/build-webkit:
1463         * Scripts/do-file-rename:
1464         * Scripts/do-webcore-rename:
1465         * Scripts/generate-qt-inspector-resource:
1466         * Scripts/prepare-ChangeLog:
1467         * Scripts/run-bindings-tests:
1468         * Scripts/update-iexploder-cssproperties:
1469         * Scripts/update-sources-list.py:
1470         * Scripts/update-webkit-localizable-strings:
1471         * Scripts/webkitdirs.pm:
1472         * Scripts/webkitpy/common/config/build.py:
1473         * Scripts/webkitpy/common/config/build_unittest.py:
1474         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1475         * Scripts/webkitpy/style/checker.py:
1476         * Scripts/webkitpy/style/checker_unittest.py:
1477         * WebKitTestRunner/DerivedSources.pro:
1478         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1479         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
1480         * wx/browser/wscript:
1481         * wx/build/settings.py:
1482
1483 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
1484
1485         Reviewed by Sam Weinig.
1486
1487         Make WebKitTestRunner rest between loads more robust to avoid test crashes
1488         https://bugs.webkit.org/show_bug.cgi?id=52086
1489
1490         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1491         (WTR::InjectedBundle::didReceiveMessage):
1492         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1493         (WTR::LayoutTestController::notifyDone):
1494         * WebKitTestRunner/TestController.cpp:
1495         (WTR::TestController::resetStateToConsistentValues):
1496         (WTR::TestController::run):
1497
1498 2011-01-07  James Robinson  <jamesr@chromium.org>
1499
1500         Revert "Implement mozilla's animationTime property"
1501         https://bugs.webkit.org/show_bug.cgi?id=51952
1502
1503         This approach isn't quite right.
1504
1505         * DumpRenderTree/chromium/WebViewHost.cpp:
1506         (WebViewHost::paintInvalidatedRegion):
1507
1508 2011-01-07  Adam Roben  <aroben@apple.com>
1509
1510         Build master fix
1511
1512         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1513         (RunWebKitTests.start): Don't try to concatenate a list and a string.
1514
1515 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
1516
1517         Reviewed by Csaba Osztrogonác.
1518
1519         run-qtwebkit-tests should be able to kill a testsuite.
1520
1521         Add new option in the script that can setup a timeout for a test.
1522         If the test execution takes more then specified time then the test
1523         would be terminated.
1524
1525         [Qt] run-qtwebkit-tests needs timeout
1526         https://bugs.webkit.org/show_bug.cgi?id=51894
1527
1528         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1529         * Scripts/run-qtwebkit-tests:
1530
1531 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
1532
1533         Unreviewed fix after r75233.
1534
1535         Based on idea from Eric Seidel.
1536
1537         Add remote zip file handling to webkitpy.
1538         https://bugs.webkit.org/show_bug.cgi?id=50901
1539
1540         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
1541
1542 2011-01-07  Shane Stephens  <shanestephens@google.com>
1543
1544         Reviewed by Eric Seidel.
1545
1546         svn-apply: should support git binary delta diffs
1547         https://bugs.webkit.org/show_bug.cgi?id=38864
1548
1549         * Scripts/VCSUtils.pm:
1550         * Scripts/svn-apply:
1551
1552 2011-01-06  Julie Parent  <jparent@chromium.org>
1553
1554         Reviewed by Eric Seidel.
1555
1556         Test Result Server not removing old results.
1557         https://bugs.webkit.org/show_bug.cgi?id=52012
1558
1559         * TestResultServer/model/jsonresults.py:
1560         Fix off-by-one: Truncate if >= num_runs, not just >.
1561         * TestResultServer/model/jsonresults_unittest.py:
1562         Add unit test to test that merging in a new result with the same value
1563         as the last result causes previous result to fall off.
1564
1565 2011-01-06  James Kozianski  <koz@chromium.org>
1566
1567         Reviewed by Mihai Parparita.
1568
1569         Add classes to provide a consistent interface to a set of files.
1570         https://bugs.webkit.org/show_bug.cgi?id=50901
1571
1572         These classes allow us to write code that is agnostic to whether a
1573         particular set of files resides in a local directory or in a zip file
1574         on a remote machine.
1575
1576         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
1577         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
1578         * Scripts/webkitpy/common/system/fileset.py: Added.
1579         * Scripts/webkitpy/common/system/filesystem.py:
1580         * Scripts/webkitpy/common/system/filesystem_mock.py:
1581         * Scripts/webkitpy/common/system/zipfileset.py: Added.
1582         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
1583
1584 2011-01-06  Eric Seidel  <eric@webkit.org>
1585
1586         Reviewed by Adam Barth.
1587
1588         NetworkTransaction should log the url it is retrying
1589         https://bugs.webkit.org/show_bug.cgi?id=52043
1590
1591         * Scripts/webkitpy/common/net/networktransaction.py:
1592         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
1593
1594 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1595
1596         Windows build fix.
1597         Import os before using it.
1598
1599         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1600
1601 2011-01-06  Eric Seidel  <eric@webkit.org>
1602
1603         Reviewed by Adam Barth.
1604
1605         StyleQueue fails to report errors when patches have many files
1606         https://bugs.webkit.org/show_bug.cgi?id=52042
1607
1608         This is one of at least two errors preventing style error reporting at the moment.
1609         When we moved to passing the list of files to check explicitly,
1610         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
1611         We could change the type of the QueueStatus.message type, or we could
1612         just teach statusserver.py how to clamp values (and warn when it does).
1613         I chose the latter path.
1614
1615         * Scripts/webkitpy/common/net/statusserver.py:
1616
1617 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1618
1619         Reviewed by Stephanie Lewis.
1620         
1621         Fix syntax error in script.
1622
1623         Windows bots need to archive/unarchive builds to/from configuration-specific directories
1624         https://bugs.webkit.org/show_bug.cgi?id=51996
1625
1626         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1627
1628 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1629
1630         Unreviewed, fixing WinCE build after r75196.
1631
1632         WinCE port does not (yet) support NPAPI.
1633
1634         * Scripts/build-webkit:
1635
1636 2011-01-06  Xan Lopez  <xlopez@igalia.com>
1637
1638         Reviewed by Darin Adler.
1639
1640         File::Spec->rel2abs in sunspider-compare-results mangles parameters
1641         https://bugs.webkit.org/show_bug.cgi?id=52015
1642
1643         * Scripts/sunspider-compare-results: call rel2abs on our arguments
1644         after the platform has been detected, otherwise the script will
1645         mangle things like '--gtk' into '/a/path/--gtk', breaking the
1646         detection.
1647
1648 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1649
1650         Reviewed by Eric Seidel.
1651
1652         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
1653         https://bugs.webkit.org/show_bug.cgi?id=51346
1654
1655         * Scripts/build-webkit:
1656
1657 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1658
1659         Reviewed by Adam Roben.
1660
1661         Windows bots need to archive/unarchive builds to/from configuration-specific directories
1662         https://bugs.webkit.org/show_bug.cgi?id=51996
1663         
1664         After the configuration directory change, we were archiving the incorrect directory for
1665         build product, so we were running tests on the wrong binaries.
1666         
1667         This change archives the correct directory, and also unarchives it into a configuration-
1668         specific directory.
1669
1670         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
1671         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
1672
1673 2011-01-06  Eric Seidel  <eric@webkit.org>
1674
1675         Reviewed by Mihai Parparita.
1676
1677         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
1678         https://bugs.webkit.org/show_bug.cgi?id=52002
1679
1680         See an example of this here:
1681         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
1682
1683         It's due to the fact that we pass around TestFailure() instance
1684         objects and yet expect them to all compare to be the same.
1685
1686         This is bad.  We should either have shared instances of these values
1687         or we should just pass around the class names.  There are already hacks
1688         in place to make TestFailure objects pass equality tests, I just added
1689         a __hash__ implementation so they can be used in sets as expected.
1690
1691         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1692         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1693
1694 2011-01-06  Evan Martin  <evan@chromium.org>
1695
1696         Reviewed by Tony Chang.
1697
1698         [gdb] handle inaccessible memory and UChar*
1699         https://bugs.webkit.org/show_bug.cgi?id=52003
1700
1701         To pretty-print a UChar*, we just grope around in the memory
1702         looking for a terminating NUL.  We need to handle the exception
1703         that can occur when we poke into an invalid location.
1704
1705         Additionally, the logic for choosing which pretty-printer would
1706         early return before hitting the point where we'd use the UChar*
1707         printer.  (Did this ever work?  How did it regress?)
1708
1709         * gdb/webkit.py:
1710
1711 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
1712
1713         Reviewed by Ada Chan.
1714
1715         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
1716         https://bugs.webkit.org/show_bug.cgi?id=51969
1717         
1718         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
1719
1720         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1721         (WTR::InjectedBundlePage::InjectedBundlePage):
1722         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
1723         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1724
1725 2011-01-06  James Robinson  <jamesr@chromium.org>
1726
1727         Reviewed by Simon Fraser.
1728
1729         Implement mozilla's animationTime property
1730         https://bugs.webkit.org/show_bug.cgi?id=51952
1731
1732         Chromium DRT support for webkitAnimationTime.
1733
1734         * DumpRenderTree/chromium/WebViewHost.cpp:
1735         (WebViewHost::paintInvalidatedRegion):
1736
1737 2011-01-06  Julie Parent  <jparent@chromium.org>
1738
1739         Reviewed by Tony Chang.
1740
1741         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
1742         https://bugs.webkit.org/show_bug.cgi?id=51217
1743
1744         * TestResultServer/model/jsonresults.py:
1745         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
1746         Adds missing documentation.
1747         * TestResultServer/model/jsonresults_unittest.py:
1748         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
1749         Update test_merge to take a number of builds to truncate at.
1750
1751 2011-01-06  Adam Barth  <abarth@webkit.org>
1752
1753         Reviewed by Eric Seidel.
1754
1755         The EWS should log outside of the working directory
1756         https://bugs.webkit.org/show_bug.cgi?id=51986
1757
1758         This patch prepare us for using git clean -x -d -f in the EWS wrapper
1759         script, which will actually clean the working copy back to a pristine
1760         state instead of leaving untracked directories and ignored files.
1761
1762         * Scripts/webkitpy/tool/commands/queues.py:
1763         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1764
1765 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1766
1767         Windows build fix.
1768         Back out attempted change to built-product-archive.
1769
1770         * BuildSlaveSupport/built-product-archive:
1771
1772 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1773
1774         Windows build fix.
1775         Include configuration name when unpacking a build archive.
1776
1777         Needed, since we split Windows build results into configuration-specific directories
1778         under WebKitOutputDir.
1779
1780         * BuildSlaveSupport/built-product-archive:
1781
1782 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1783
1784         Reviewed by Darin Adler.
1785
1786         Debug and Release builds on Windows clobber each other
1787         https://bugs.webkit.org/show_bug.cgi?id=49185
1788
1789         Changes the structure of WebKitBuild build products directory so we
1790         completely separate each build configuration into independent directories.
1791         
1792         Although we previously had per-configuration directories for obj, this change adds
1793         per-configuration directories for bin, lib, obj, and include. Each configuration's
1794         build products are stored within a directory inside of WebKitBuild.
1795         
1796         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
1797         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
1798
1799         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
1800         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
1801         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
1802         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
1803         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
1804         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
1805         * DumpRenderTree/win/ImageDiffCommon.vsprops:
1806         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
1807         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
1808         * FindSafari/FindSafari.vcproj:
1809         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
1810         * MiniBrowser/MiniBrowserPostBuild.cmd:
1811         * MiniBrowser/MiniBrowserPreBuild.cmd:
1812         * Scripts/webkitdirs.pm:
1813         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
1814         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
1815         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
1816         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
1817         * TestWebKitAPI/win/copy-resources.cmd:
1818         * WebKitAPITest/WebKitAPITestCommon.vsprops:
1819         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
1820         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
1821         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
1822         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
1823         * WebKitTestRunner/win/InjectedBundle.vcproj:
1824         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
1825         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
1826         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
1827         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
1828         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
1829         * WinLauncher/WinLauncherCommon.vsprops:
1830         * WinLauncher/WinLauncherPostBuild.cmd:
1831         * WinLauncher/WinLauncherPreBuild.cmd:
1832
1833 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
1834
1835         Reviewed by Ariya Hidayat.
1836
1837         [Qt] TestNetscapePlugin doesn't link on OS X
1838         https://bugs.webkit.org/show_bug.cgi?id=51948
1839
1840         Only add a dependency on libX11 on X11 systems
1841
1842         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1843
1844 2011-01-05  Jeff Miller  <jeffm@apple.com>
1845
1846         Reviewed by Adam Roben.
1847
1848         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
1849         https://bugs.webkit.org/show_bug.cgi?id=51970
1850
1851         * Scripts/webkitpy/style/checker.py:
1852         Add -readability/naming for WebKit2 C API directories.
1853
1854 2011-01-05  Eric Seidel  <eric@webkit.org>
1855
1856         Unreviewed, just fixing one more log error from my previous python patch.
1857
1858         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1859         https://bugs.webkit.org/show_bug.cgi?id=51802
1860
1861         webkit-patch failure-reason was logging about parsing errors
1862         due to my misunderstanding of how BeautifulSoup.findAll worked.
1863
1864         Fixed, and added a unit test.
1865
1866         * Scripts/webkitpy/common/net/layouttestresults.py:
1867         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1868
1869 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
1870
1871         Reviewed by Kenneth Rohde Christiansen.
1872
1873         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
1874         https://bugs.webkit.org/show_bug.cgi?id=51951
1875
1876         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
1877         to create new window from WebKit.
1878
1879         * MiniBrowser/qt/BrowserWindow.cpp:
1880         (newPageFunction):
1881         (BrowserWindow::BrowserWindow):
1882         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
1883         (BrowserWindow::newWindow):
1884         (BrowserWindow::updateUserAgentList):
1885         (BrowserWindow::showUserAgentDialog):
1886         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
1887         define the type of the backing store used for new windows.
1888         * MiniBrowser/qt/main.cpp:
1889         (main):
1890
1891 2011-01-05  Eric Seidel  <eric@webkit.org>
1892
1893         Reviewed by Ojan Vafai.
1894
1895         commit-queue should report failure type when reporting flaky tests
1896         https://bugs.webkit.org/show_bug.cgi?id=51900
1897
1898         This patch was a ridiculous amount of plumbing.  In the end I like
1899         the NRWT-style TestResult class even less.  But now we're passing
1900         a list of TestResult objects from the queue to the FlakyTestReporter.
1901         Thus the FlakyTestReporter can more easily report what type of failure
1902         occurred.
1903
1904         In the process, I found that I was not alone in finding TestResult
1905         cumbersome to use.  A bunch of code was trying to create a TestResult
1906         object with default values.  However since the constructor didn't make
1907         this easy, some places were getting it wrong (including the TestResult unit test)!
1908         I've fixed the TestResult constructor to have default values for non-essential
1909         arguments.
1910
1911         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1912         * Scripts/webkitpy/common/net/layouttestresults.py:
1913         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1914         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1915         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1916         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1917         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
1918         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
1919         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1920         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1921         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1922         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1923         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1924         * Scripts/webkitpy/tool/commands/queues.py:
1925         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1926
1927 2011-01-05  Eric Seidel  <eric@webkit.org>
1928
1929         Unreviewed.
1930
1931         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1932         https://bugs.webkit.org/show_bug.cgi?id=51802
1933
1934         Add another unit test to cover a previously missing import.
1935
1936         * Scripts/webkitpy/common/net/layouttestresults.py:
1937         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1938
1939 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
1940
1941         Reviewed by David Levin.
1942
1943         Add mihaip@chromium.org as a reviewer
1944         https://bugs.webkit.org/show_bug.cgi?id=51966
1945         
1946         Add myself as a reviewer.
1947
1948         * Scripts/webkitpy/common/config/committers.py:
1949
1950 2011-01-05  James Simonsen  <simonjam@chromium.org>
1951
1952         Unreviewed. Adding myself to the list of committers.
1953
1954         * Scripts/webkitpy/common/config/committers.py:
1955
1956 2011-01-05  Eric Seidel  <eric@webkit.org>
1957
1958         Unreviewed.
1959
1960         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1961         https://bugs.webkit.org/show_bug.cgi?id=51802
1962
1963         Fix two exceptions seen on the bots after my original commit.
1964
1965         * Scripts/webkitpy/common/net/layouttestresults.py:
1966         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1967
1968 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
1969
1970         Reviewed by Andreas Kling.
1971
1972         [Qt]Add local storage settings to QtTestBrowser command line arguments 
1973         https://bugs.webkit.org/show_bug.cgi?id=51750
1974
1975         * QtTestBrowser/main.cpp:
1976         (LauncherApplication::handleUserOptions):
1977          Local storage settings can be enable form command line arguments for
1978          QtTestBrowser.
1979
1980 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
1981
1982         Reviewed by Martin Robinson.
1983
1984         GTK: AX: DRT needs to use correct root object method.
1985         https://bugs.webkit.org/show_bug.cgi?id=51911
1986
1987         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1988         (AccessibilityController::rootElement):
1989
1990 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1991
1992         Rubber-stamped by Csaba Osztrogonác.
1993
1994         Based on idea from Péter Gál.
1995
1996         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
1997
1998 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1999
2000         Reviewed by Adam Barth.
2001
2002         sheriff-bot should be able to do multi-revision rollouts
2003         https://bugs.webkit.org/show_bug.cgi?id=51176
2004
2005         * Scripts/webkitpy/tool/bot/irc_command.py:
2006         * Scripts/webkitpy/tool/bot/sheriff.py:
2007         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2008
2009 2011-01-05  Eric Seidel  <eric@webkit.org>
2010
2011         Reviewed by Adam Barth.
2012
2013         queues.webkit.org should have per-bot status pages
2014         https://bugs.webkit.org/show_bug.cgi?id=51906
2015
2016         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
2017         statuses from a single queue.  Now that we have many bots servicing
2018         some queues (commit-queue, win-ews, etc.) its easy to have the messages
2019         you care about scroll off the end of the 15-message limit on the main page.
2020
2021         Eventually we should probably rename /queue-status to /queue or /queues,
2022         but that's fodder for another patch.
2023
2024         * QueueStatusServer/handlers/queuestatus.py:
2025         * QueueStatusServer/index.yaml:
2026         * QueueStatusServer/main.py:
2027         * QueueStatusServer/templates/includes/singlequeuestatus.html:
2028          - This probably should use a custom filter instead of hard-coding
2029            the URL scheme here, but I couldn't figure out how to easily
2030            create such a filter.  Most filters work with "strings" so we can't
2031            pass the status object.  We could add a method to the status
2032            object and call that, but that seemed a bit strange too.
2033         * QueueStatusServer/templates/queuestatus.html:
2034
2035 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2036
2037         Unreviewed. Adding myself to the list of committers.
2038
2039         * Scripts/webkitpy/common/config/committers.py:
2040
2041 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
2042
2043         Reviewed by David Levin.
2044
2045         check-webkit-style treated some macros with parentheses after #elif as function calls
2046         https://bugs.webkit.org/show_bug.cgi?id=51695
2047
2048         Ingore function call space checking in any preprocessor directives
2049         (things starting with #). Change search() to match() because 
2050         preprocessor directives are supposed to be in the beginning of lines.
2051
2052         * Scripts/webkitpy/style/checkers/cpp.py:
2053         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
2054
2055 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
2056
2057         Reviewed by Tony Chang.
2058
2059         Change the --multi-load test option to --stress-opt
2060         https://bugs.webkit.org/show_bug.cgi?id=50751
2061
2062         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2063         (runTest):
2064         (main):
2065         * DumpRenderTree/chromium/TestShell.cpp:
2066         (TestShell::TestShell):
2067         * DumpRenderTree/chromium/TestShell.h:
2068         (TestShell::stressOpt):
2069         (TestShell::setStressOpt):
2070         (TestShell::stressDeopt):
2071         (TestShell::setStressDeopt):
2072         (TestShell::javaScriptFlags):
2073         (TestShell::setJavaScriptFlags):
2074         * Scripts/webkitpy/layout_tests/port/chromium.py:
2075         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2076
2077 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
2078
2079         Reviewed by Sam Weinig.
2080
2081         WK2: Support Accessibility
2082         https://bugs.webkit.org/show_bug.cgi?id=51859
2083
2084         Use rootObject() method to get top of accessibility tree.
2085
2086         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2087         (AccessibilityController::focusedElement):
2088         (AccessibilityController::rootElement):
2089
2090 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
2091
2092         Reviewed by Darin Adler.
2093
2094         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
2095         https://bugs.webkit.org/show_bug.cgi?id=51846
2096
2097         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
2098         back to GRefPtr.
2099
2100 2011-01-04  Zhe Su  <suzhe@chromium.org>
2101
2102         Reviewed by Kenneth Russell.
2103
2104         Fix insertText, setMarkedText and unmarkText methods of
2105         TextInputController to call corresponding methods of WebKit::WebView
2106         rather than WebKit::WebFrame. This change matches the behavior of
2107         chromium browser.
2108         insertText corresponds to WebView::confirmComposition(text)
2109         setMarkedText corresponds to WebView::setComposition(...)
2110         unmarkText corresponds to WebView::confirmComposition()
2111         https://bugs.webkit.org/show_bug.cgi?id=51693
2112
2113         * DumpRenderTree/chromium/TextInputController.cpp:
2114         (TextInputController::insertText):
2115         (TextInputController::setMarkedText):
2116         (TextInputController::unmarkText):
2117
2118 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
2119
2120         Reviewed by Laszlo Gombos.
2121
2122         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
2123
2124         On Symbian productDir points to the source directory. Removing all the
2125         empty files from the productDir directory corrupts the svn repository.
2126
2127         * Scripts/build-webkit:
2128
2129 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
2130
2131         Reviewed by Adam Barth.
2132
2133         [Qt] Add SelectAll option to the context menu for the editor
2134         https://bugs.webkit.org/show_bug.cgi?id=50049
2135
2136         Set shortcut for the SelectAll action.
2137
2138         * QtTestBrowser/mainwindow.cpp:
2139         (MainWindow::buildUI):
2140
2141 2011-01-03  David Levin  <levin@chromium.org>
2142
2143         Reviewed by Eric Seidel.
2144
2145         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
2146         https://bugs.webkit.org/show_bug.cgi?id=51842
2147
2148         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
2149         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
2150
2151 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
2152
2153         Reviewed by David Kilzer.
2154
2155         [WINCE] Adds a build slave.
2156         https://bugs.webkit.org/show_bug.cgi?id=50523
2157
2158         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
2159         entry for a release build of the WinCE port.
2160         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
2161         flag to build the WinCE port.
2162
2163 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
2164
2165         Reviewed by David Kilzer.
2166
2167         Add WinCE support to build-webkit
2168         https://bugs.webkit.org/show_bug.cgi?id=51642
2169
2170         * Scripts/build-webkit:
2171         * Scripts/webkitdirs.pm:
2172
2173 2011-01-03  Eric Seidel  <eric@webkit.org>
2174
2175         Reviewed by Adam Barth.
2176
2177         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2178         https://bugs.webkit.org/show_bug.cgi?id=51802
2179
2180         I'm not the biggest fan of the test_failures or test_results classes,
2181         but it's better to have one shared set of classes, than separate ones
2182         for new vs. old run-webkit-test result handling.
2183
2184         This moves the ORWT results class "LayoutTestResults" over to using
2185         TestResult and TestFailure classes, making it easy for us to
2186         make all our sheriff-bot and other webkitpy code NRWT ready.
2187
2188         This also makes it a trivial patch to generate results.json information
2189         from ORWT results.html files (for flaky test analysis, etc.) as well
2190         as making it a one-liner to report test failure types when the
2191         commit-queue sees flaky tests.
2192
2193         This patch tried not to add new functionality, but only to replace
2194         the guts of LayoutTestResults, while adding unit tests and hoping
2195         not to break anything.
2196
2197         I also moved callers which assumed User.prompt* were static/class methods
2198         to using them as instance methods (since we'll eventually want to make them such).
2199
2200         In the process of re-writing things, I broke the rebaseline command, so I wrote
2201         a unit test to catch my breakage were I do do so again in the future.
2202
2203         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2204         * Scripts/webkitpy/common/net/layouttestresults.py:
2205         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2206         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2207         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
2208         * Scripts/webkitpy/tool/commands/queries.py:
2209         * Scripts/webkitpy/tool/commands/rebaseline.py:
2210         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2211         * Scripts/webkitpy/tool/mocktool.py:
2212
2213 2011-01-03  Adam Barth  <abarth@webkit.org>
2214
2215         Reviewed by Simon Fraser.
2216
2217         webkit-patch shouldn't waste time cleaning a working directory that's already clean
2218         https://bugs.webkit.org/show_bug.cgi?id=51840
2219
2220         * Scripts/webkitpy/common/checkout/scm.py:
2221
2222 2011-01-03  Adam Barth  <abarth@webkit.org>
2223
2224         Reviewed by Simon Fraser.
2225
2226         webkit-patch should only hide update output if --quiet
2227         https://bugs.webkit.org/show_bug.cgi?id=51838
2228
2229         As requested by smfr.
2230
2231         * Scripts/webkitpy/tool/steps/update.py:
2232
2233 2011-01-03  Adam Barth  <abarth@webkit.org>
2234
2235         Reviewed by David Levin.
2236
2237         commit-queue shouldn't reject patches twice if two bots process the same patch
2238         https://bugs.webkit.org/show_bug.cgi?id=51805
2239
2240         Before raising an error, we first check whether the patch is still in
2241         the commit-queue.  This check is still racy, of course, but the time
2242         window is much smaller.
2243
2244         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2245
2246 2011-01-03  Sam Weinig  <sam@webkit.org>
2247
2248         Reviewed by Anders Carlsson.
2249
2250         Make run-api-tests less chatty.
2251         https://bugs.webkit.org/show_bug.cgi?id=51831
2252
2253         - Make script quiet by default and add --verbose option (replacing --quiet).
2254         - When not verbose, pipe stdout and stderr to devnull.
2255
2256         * Scripts/run-api-tests:
2257
2258 2011-01-03  Pratik Solanki  <psolanki@apple.com>
2259
2260         Unreviewed. Adding myself to committers.py.
2261
2262         * Scripts/webkitpy/common/config/committers.py:
2263
2264 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
2265
2266         Reviewed by Xan Lopez.
2267
2268         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
2269         https://bugs.webkit.org/show_bug.cgi?id=51806
2270
2271         Originally, the $libraryName is 'JavaScriptCore'. When building release 
2272         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
2273         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
2274         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 
2275         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
2276         so make it 'WebKitBuild/Release/.libs'
2277
2278         * Scripts/webkitdirs.pm: 
2279
2280 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
2281
2282         Reviewed by Adam Barth.
2283
2284         Make EFL a core builder
2285         https://bugs.webkit.org/show_bug.cgi?id=51804
2286
2287         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2288         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2289
2290 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2291
2292         [Qt] Unreviewed fix after r74855 and r74875.
2293
2294         * BuildSlaveSupport/built-product-archive:
2295          - Create directories explicitly.
2296          - Pass shell=True to subprocess.call().
2297
2298 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2299
2300         [Qt] Unreviewed fix after r74855.
2301
2302         Move JavaScriptCore to Source
2303         https://bugs.webkit.org/show_bug.cgi?id=51604
2304
2305         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
2306
2307 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2308
2309         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
2310
2311         Move JavaScriptCore to Source
2312         https://bugs.webkit.org/show_bug.cgi?id=51604
2313
2314         * Scripts/webkitdirs.pm:
2315
2316 2011-01-02  Robert Hogan  <robert@webkit.org>
2317
2318         Unreviewed, build fix.
2319
2320         [Qt] Fix DRT build after 74855
2321
2322         * DumpRenderTree/qt/DumpRenderTree.pro:
2323
2324 2011-01-01  Adam Barth  <abarth@webkit.org>
2325
2326         Remove the assumption from the Qt and Gtk builds that every project is
2327         in the root directory.
2328
2329         * Scripts/build-webkit:
2330
2331 2011-01-01  Adam Barth  <abarth@webkit.org>
2332
2333         Reviewed by Eric Seidel.
2334
2335         Teach svn-apply how to apply patches even though JavaScriptCore has moved
2336         https://bugs.webkit.org/show_bug.cgi?id=51796
2337
2338         After this change, svn-apply will magically apply patches to
2339         JavaScriptCore/foo to Source/JavaScriptCore/foo.
2340
2341         * Scripts/VCSUtils.pm:
2342
2343 2011-01-01  Adam Barth  <abarth@webkit.org>
2344
2345         Reviewed by Eric Seidel.
2346
2347         Move JavaScriptCore to Source
2348         https://bugs.webkit.org/show_bug.cgi?id=51604
2349
2350         Update references to JavaScriptCore to point to the new location.
2351
2352         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2353         * DumpRenderTree/qt/DumpRenderTree.pro:
2354         * DumpRenderTree/qt/ImageDiff.pro:
2355         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2356         * DumpRenderTree/wscript:
2357         * Scripts/build-jsc:
2358         * Scripts/build-webkit:
2359         * Scripts/do-file-rename:
2360         * Scripts/do-webcore-rename:
2361         * Scripts/run-javascriptcore-tests:
2362         * Scripts/update-javascriptcore-test-results:
2363         * Scripts/webkitdirs.pm:
2364         * Scripts/webkitpy/common/config/build_unittest.py:
2365         * Scripts/webkitpy/style/checker.py:
2366         * Scripts/webkitpy/style/checker_unittest.py:
2367         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2368         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2369         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2370         * wx/build/settings.py:
2371
2372 2011-01-01  Adam Barth  <abarth@webkit.org>
2373
2374         Reviewed by Eric Seidel.
2375
2376         Move Sources to Source
2377         https://bugs.webkit.org/show_bug.cgi?id=51794
2378
2379         Update scripts to point to the new location.
2380
2381         * Scripts/build-webkit:
2382         * Scripts/do-file-rename:
2383         * Scripts/do-webcore-rename:
2384         * Scripts/webkitpy/common/config/build.py:
2385         * Scripts/webkitpy/common/config/build_unittest.py:
2386
2387 2010-12-31  Kent Tamura  <tkent@chromium.org>
2388
2389         Reviewed by Eric Seidel.
2390
2391         [DRT/Chromium] Enable mock spell checker on non-OSX
2392         https://bugs.webkit.org/show_bug.cgi?id=51401
2393
2394         * DumpRenderTree/chromium/WebViewHost.cpp:
2395         (WebViewHost::spellCheck):
2396
2397 2010-12-31  Adam Barth  <abarth@webkit.org>
2398
2399         Reviewed by Ariya Hidayat.
2400
2401         Remove Tools/Scripts/wkstyle
2402         https://bugs.webkit.org/show_bug.cgi?id=51774
2403
2404         This script appears to not have been touched in a while and seems to
2405         have been replaced by check-webkit-style.
2406
2407         * Scripts/wkstyle: Removed.
2408
2409 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
2410
2411         Unreviewed. Coding style fix.
2412
2413         * DumpRenderTree/chromium/TestShell.h:
2414
2415 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
2416
2417         Reviewed by Pavel Feldman.
2418
2419         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
2420
2421         It was a problem with Chromium DRT. DevToolsAgent object instance was
2422         attached not only to the inspected page but to the DevTools window too.
2423         As result all the inspector files were interpreted as a content of inspected page
2424         and were transfered to the DevTools scripts panel for debugging etc.
2425
2426         https://bugs.webkit.org/show_bug.cgi?id=51735
2427
2428         * DumpRenderTree/chromium/TestShell.cpp:
2429         (TestShell::TestShell):
2430         (TestShell::bindJSObjectsToWindow):
2431         (TestShell::createNewWindow):
2432         * DumpRenderTree/chromium/TestShell.h:
2433
2434 2010-12-31  Adam Barth  <abarth@webkit.org>
2435
2436         Rubber-stamped by Eric Seidel.
2437
2438         Move PageLoadTests to PerformanceTests/PageLoad
2439         https://bugs.webkit.org/show_bug.cgi?id=51771
2440
2441         Update references to PageLoadTests to point to the new location.
2442
2443         * Scripts/run-pageloadtest:
2444         * Scripts/webkitpy/common/config/build.py:
2445
2446 2010-12-31  Adam Barth  <abarth@webkit.org>
2447
2448         Rubber-stamped by Eric Seidel.
2449
2450         Move SunSpider into PerformanceTests
2451         https://bugs.webkit.org/show_bug.cgi?id=51769
2452
2453         Update these scripts to point to the new location.
2454
2455         * Scripts/run-sunspider:
2456         * Scripts/sunspider-compare-results:
2457
2458 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
2459
2460         Reviewed by Kent Tamura.
2461
2462         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
2463         https://bugs.webkit.org/show_bug.cgi?id=51728
2464         
2465         Add implementation of the Mac WebThemeEngine that uses an NSScroller
2466         to render top-level scrollbars. This makes them match the Mac port's
2467         use of an NSScrollView, which means that we'll be able to share more
2468         pixel baselines.
2469         
2470         The new rendering code will not be activated until the 
2471         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
2472         ScrollbarThemeChromiumMac.
2473
2474         * DumpRenderTree/DumpRenderTree.gypi:
2475         * DumpRenderTree/chromium/TestShellMac.mm:
2476         (platformInit):
2477         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
2478         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
2479         (+[FakeActiveWindow alwaysActiveWindow]):
2480         (+[FakeActiveWindow alwaysInactiveWindow]):
2481         (-[FakeActiveWindow initWithActiveControls:]):
2482         (-[FakeActiveWindow _hasActiveControls]):
2483         (WebThemeEngineDRTMac::paintScrollbarThumb):
2484         (stateToHIEnableState):
2485         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2486         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2487
2488 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
2489
2490         Reviewed by David Kilzer.
2491
2492         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
2493         used
2494         https://bugs.webkit.org/show_bug.cgi?id=51672
2495
2496         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
2497         with USE_SYSTEM_MALLOC=1
2498         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
2499         with USE_SYSTEM_MALLOC=1
2500
2501 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2502
2503         Reviewed by David Kilzer.
2504
2505         [Qt] [Symbian] Fix build-webkit script for Symbian
2506         https://bugs.webkit.org/show_bug.cgi?id=51509
2507
2508         Set the OUTPUT_DIR for Symbian to be the same as the source
2509         directory.
2510
2511         * Scripts/webkitdirs.pm:
2512
2513 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
2514
2515         Reviewed by Darin Adler.
2516
2517         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
2518         https://bugs.webkit.org/show_bug.cgi?id=51758
2519
2520         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
2521
2522         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
2523         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
2524
2525 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
2526
2527         Unreviewed WinCE buildfix.
2528
2529         * WinCELauncher/main.cpp: Add missing include.
2530
2531 2010-12-29  Daniel Bates  <dbates@rim.com>
2532
2533         Reviewed by Darin Adler.
2534
2535         svn-apply updates date of wrong change log entry for a change log diff that
2536         contains two consecutive entries with the same author and date
2537         https://bugs.webkit.org/show_bug.cgi?id=46061
2538
2539         Fixes an issue where the date of the wrong change log entry may be modified.
2540         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
2541         in a ChangeLog file to the top of the file.
2542
2543         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
2544         diff when it detects that the diff inserts a change log entry earlier in a
2545         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
2546         change. With the advent of the commit-queue this functionality of bailing out
2547         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
2548         Instead, we should always move the change log entry to the top of the ChangeLog file.
2549
2550         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
2551         the date line of the correct change log entry in a ChangeLog diff.
2552
2553         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
2554
2555         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
2556           Updated the following unit tests now that we move entries inserted earlier to the top:
2557           - "fixChangeLogPatch: New entry inserted in middle."
2558             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
2559
2560           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
2561             (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
2562
2563         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
2564
2565 2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>
2566
2567         Reviewed by Eric Seidel.
2568
2569         [Qt] Fixed compatibility with gold linker on X11 platforms
2570         https://bugs.webkit.org/show_bug.cgi?id=51700
2571
2572         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2573         Linked TestNetscapePlugin with libX11 on Unix platforms
2574
2575 2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
2576
2577         Reviewed by Darin Adler.
2578
2579         Circular dependency in webkitpy.common.checkout.changelog module
2580         https://bugs.webkit.org/show_bug.cgi?id=50475
2581
2582         Remove automatic import of api.Checkout module when any checkout/
2583         submodule is imported (e.g.: when checkout.scm.Git is imported).
2584
2585         * Scripts/webkitpy/common/checkout/__init__.py:
2586
2587 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
2588
2589         Reviewed by Ojan Vafai.
2590
2591         prepare-ChangeLog should support the -g option for specifying the git-commit
2592         https://bugs.webkit.org/show_bug.cgi?id=51708
2593
2594         Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
2595         webkit-patch, though the exact meaning of the two options remain different.
2596
2597         * Scripts/prepare-ChangeLog: Add -g.
2598
2599 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
2600
2601         Reviewed by Simon Hausmann.
2602
2603         [Qt] Fix compilation with Qt in namespace
2604         https://bugs.webkit.org/show_bug.cgi?id=51701
2605
2606         * QtTestBrowser/webview.h:
2607
2608 2010-12-28  Daniel Bates  <dbates@rim.com>
2609
2610         Reviewed by Sam Weinig.
2611
2612         Substitute // MARK: for compiler-specific #pragma mark
2613         https://bugs.webkit.org/show_bug.cgi?id=51657
2614
2615         Fix future compilation warnings about "#pragma mark" on GTK+ bots by
2616         substituting  "// MARK:" for "#pragma mark", which provides
2617         analogous code-bookmarking functionality under Xcode.
2618
2619         Also, for consistency, we should substitute "// MARK:" for compiler-
2620         specific "#pragma mark" in the source files for the Mac port.
2621
2622         * DumpRenderTree/AccessibilityTextMarker.cpp:
2623         * DumpRenderTree/cf/WebArchiveDumpSupport.h:
2624         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
2625         * DumpRenderTree/mac/ObjCController.m:
2626         * MiniBrowser/mac/AppDelegate.m:
2627         * MiniBrowser/mac/BrowserWindowController.m:
2628
2629 2010-12-28  Xan Lopez  <xlopez@igalia.com>
2630
2631         Reviewed by Eric Seidel.
2632
2633         Add --no-build option to run-sunspider
2634         https://bugs.webkit.org/show_bug.cgi?id=51658
2635
2636         * Scripts/run-sunspider: add --no-build flag to skip building
2637         phase.
2638
2639 2010-12-27  Daniel Bates  <dbates@rim.com>
2640
2641         Rubber-stamped by Martin Robinson.
2642
2643         Append the directory Tools/DumpRenderTree to the list of directories that
2644         do-webcore-rename should search so that it can rename DRT files and
2645         source code.
2646
2647         * Scripts/do-webcore-rename:
2648
2649 2010-12-27  Eric Seidel  <eric@webkit.org>
2650
2651         Reviewed by Adam Barth.
2652
2653         build-webkit should detect missing Java SDK and explain how to install it
2654         https://bugs.webkit.org/show_bug.cgi?id=51651
2655
2656         * Scripts/build-webkit:
2657
2658 2010-12-26  Martin Robinson  <mrobinson@igalia.com>
2659
2660         Reviewed by Daniel Bates.
2661
2662         [GTK] Add support for build-jsc
2663         https://bugs.webkit.org/show_bug.cgi?id=51625
2664
2665         Add GTK+ support to build-jsc now that building the jsc executable as
2666         a standalone target is easy.
2667
2668         * Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
2669         * Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
2670         * Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject
2671         and pass it along to buildAutotoolsProject.
2672
2673 2010-12-27  David Levin  <levin@chromium.org>
2674
2675         Reviewed by Eric Seidel.
2676
2677         check-webkit-style check for meaningless variable names in function declarations.
2678         https://bugs.webkit.org/show_bug.cgi?id=51523
2679
2680         * Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp
2681         from the new check and whitespace/parens because the syntax is unusual and
2682         produced a fair number of positives for these checks.
2683         * Scripts/webkitpy/style/checkers/cpp.py:
2684         (_convert_to_lower_with_underscores): Used as a canonical form for type names
2685         and parameter names when determining if the parameter name is useless.
2686         (_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
2687         (Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
2688         format.
2689         (_check_parameter_name_against_text):  Checks to see if the parameter name is in the
2690         text or an acronym of it.
2691         (check_function_definition): Checks function definitions for meaningless variable names.
2692         (process_line): Added call to check_function_definition.
2693         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2694         (CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
2695         (CppFunctionsTest.test_create_acronym): Test for _create_acronym.
2696         (CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
2697         (CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
2698         because when only checking a snippet, there are a lot of bogus functions.
2699         (CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
2700         that I put there previously and just noticed.
2701         (WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
2702         check_function_definition and process_line.
2703
2704 2010-12-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2705
2706         Reviewed by Martin Robinson.
2707
2708         [GTK] Disable flash plugin in GtkLauncher when using gtk3
2709         https://bugs.webkit.org/show_bug.cgi?id=51591
2710
2711         Flash plugin uses gtk2 that is incompatible with gtk3 making
2712         webkit crash when it's built with gtk3.
2713
2714         * GtkLauncher/main.c:
2715         (main):
2716
2717 2010-12-25  Adam Barth  <abarth@webkit.org>
2718
2719         Reviewed by Eric Seidel.
2720
2721         Move ANGLE to Sources/ThirdParty
2722         https://bugs.webkit.org/show_bug.cgi?id=51605
2723
2724         * Scripts/build-webkit:
2725           - Point to the new ANGLE location.
2726
2727 2010-12-26  David Levin  <levin@chromium.org>
2728
2729         Reviewed by Eric Seidel.
2730
2731         check-webkit-style should be able to parse function declaration parameters.
2732         https://bugs.webkit.org/show_bug.cgi?id=51451
2733
2734         * Scripts/webkitpy/style/checkers/cpp.py:
2735         (Position.__init__): Holds simple position information (row, column).
2736         (Parameter.__init__): Holds information about a parameter.
2737         (SingleLineView.__init): Converts multiple lines into a single line for simpler searches.
2738         (SingleLineView.convert_column_to_row): Returns the original row given a column.
2739         (create_skeleton_parameters): Simplifies a parameter list for easier searching.
2740         (find_parameter_name_index): Finds where the parameter name is.
2741         (parameter_list): Generates the list of parameters for a function.
2742         (_FunctionState.begin): Added information to allow determining the parameters
2743         on demand.
2744         (_FunctionState.get_parameter_list): Returns a tuple of function parameters.
2745         (detect_functions): Improve function detection for operator functions and
2746         determine where the parameters end and pass that to _FunctionState.begin.
2747         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2748         (CppFunctionsTest.test_parameter): Verifies Parameter functionality.
2749         (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality.
2750         (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters.
2751         (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index.
2752         (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list.
2753         Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list.
2754         (FunctionDetectionTest.perform_function_detection): Added support for verifying
2755         the parameters found.
2756         (FunctionDetectionTest.test_function_declaration_detection): Added more function
2757         detection test to verify that we catch the operator functions.
2758         (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros.
2759         (FunctionDetectionTest.test_parameter_list): Added tests to verify the parameter parsing.
2760         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Removed
2761         because the error. The test is about the bad function name. Fixing the name makes the test exactly like
2762         test_function_length_check_definition_severity1_for_test.
2763
2764 2010-12-25  Patrick Gansterer  <paroga@webkit.org>
2765
2766         Unreviewed WinCE buildfix after r74334.
2767
2768         * CMakeListsWinCE.txt:
2769
2770 2010-12-24  Sheriff Bot  <webkit.review.bot@gmail.com>
2771
2772         Unreviewed, rolling out r74632.
2773         http://trac.webkit.org/changeset/74632
2774         https://bugs.webkit.org/show_bug.cgi?id=51600
2775
2776         makes test-webkitpy hang forever on GTK (Requested by philn-tp
2777         on #webkit).
2778
2779         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2780         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2781
2782 2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>
2783
2784         Reviewed by Kenneth Rohde Christiansen.
2785
2786         [EFL] Screen doesn't be rendered when changing size of EWebLauncher
2787         https://bugs.webkit.org/show_bug.cgi?id=43528
2788
2789         Remove on_resize because ewk_view_fixed_layout_size_set should not be
2790         called on callback of EVAS_CALLBACK_RESIZE. As it change size of
2791         FrameView, rendering was ignored when _ewk_view_smart_calculate was
2792         called.
2793
2794         * EWebLauncher/main.c:
2795         (browserCreate):
2796
2797 2010-12-24  Eric Seidel  <eric@webkit.org>
2798
2799         Reviewed by Adam Barth.
2800
2801         webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
2802         https://bugs.webkit.org/show_bug.cgi?id=28291
2803
2804         This is a start.  At least now webkit-patch will prompt when your ChangeLog looks questionable.
2805         We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
2806         to strings with find in the diff.
2807         Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.
2808
2809         * Scripts/webkitpy/common/checkout/api.py:
2810         * Scripts/webkitpy/common/checkout/diff_parser.py:
2811         * Scripts/webkitpy/tool/steps/abstractstep.py:
2812         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
2813         * Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
2814         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
2815         * Scripts/webkitpy/tool/steps/validatereviewer.py:
2816
2817 2010-12-24  Dirk Pranke  <dpranke@chromium.org>
2818
2819         Reviewed by Kenneth Russell.
2820
2821         Modify new-run-webkit-tests to shut up and exit when all the threads
2822         are wedged so that test runs complete faster and we don't end up
2823         w/ enormous log files.
2824
2825         https://bugs.webkit.org/show_bug.cgi?id=51572
2826
2827         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2828         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2829
2830 2010-12-24  Eric Seidel  <eric@webkit.org>
2831
2832         Reviewed by David Levin.
2833
2834         commit-queue should better explain how it will re-open bugs and follow duplicate chains
2835         https://bugs.webkit.org/show_bug.cgi?id=51549
2836
2837         I've had multiple people ask me about the commit-queue's behavior
2838         regarding reporting flaky tests.  I figured it would be best to just
2839         have the queue explain itself in the bugs it files.
2840
2841         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2842         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2843
2844 2010-12-24  Shinichiro Hamaji  <hamaji@chromium.org>
2845
2846         Reviewed by Eric Seidel.
2847
2848         check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt
2849         https://bugs.webkit.org/show_bug.cgi?id=51467
2850
2851         * Scripts/webkitpy/style/checker.py:
2852         * Scripts/webkitpy/style/checker_unittest.py:
2853
2854 2010-12-23  Adam Barth  <abarth@webkit.org>
2855
2856         Rubber-stamped by Eric Seidel.
2857
2858         Move JavaScriptGlue into Sources
2859         https://bugs.webkit.org/show_bug.cgi?id=51583
2860
2861         These tools refer to JavaScriptGlue and need to be updated to its new
2862         location.
2863
2864         * Scripts/build-webkit:
2865         * Scripts/do-file-rename:
2866         * Scripts/do-webcore-rename:
2867         * Scripts/webkitpy/common/config/build.py:
2868         * Scripts/webkitpy/common/config/build_unittest.py:
2869
2870 2010-12-23  Lucas Forschler  <lforschler@apple.com>
2871
2872         Reviewed by Eric Seidel.
2873
2874         Bug 51539 - update iexploder scripts to point to new location
2875
2876         * Scripts/run-iexploder-tests:
2877         * Scripts/update-iexploder-cssproperties:
2878
2879 2010-12-23  Evan Martin  <evan@chromium.org>
2880
2881         Reviewed by Ryosuke Niwa.
2882
2883         [chromium] LayoutTestController warning in float->int conversion
2884         https://bugs.webkit.org/show_bug.cgi?id=51553
2885
2886         Rather than reading an int, converting to a float, then getting a compiler
2887         warning on passing the float to something that expects an int, instead
2888         just pass around ints.
2889
2890         No tests, fixes a compiler warning.
2891
2892         * DumpRenderTree/chromium/LayoutTestController.cpp:
2893         (parsePageSizeParameters):
2894         (LayoutTestController::pageNumberForElementById):
2895         (LayoutTestController::numberOfPages):
2896
2897 2010-12-23  Lucas Forschler  <lforschler@apple.com>
2898
2899         Reviewed by Darin Adler.
2900
2901         Bug 51537 - iexploder needs cleanup
2902         
2903         * iExploder/htdocs: Removed.
2904         * iExploder/htdocs/config.rb: Removed.
2905         * iExploder/htdocs/cssproperties.in: Removed.
2906         * iExploder/htdocs/cssvalues.in: Removed.
2907         * iExploder/htdocs/htmlattrs.in: Removed.
2908         * iExploder/htdocs/htmltags.in: Removed.
2909         * iExploder/htdocs/htmlvalues.in: Removed.
2910         * iExploder/htdocs/iexploder.cgi: Removed.
2911         * iExploder/htdocs/iexploder.rb: Removed.
2912         * iExploder/htdocs/index.html: Removed.
2913         * iExploder/htdocs/webserver.rb: Removed.
2914         * iExploder/iexploder-1.7.2/output: Removed.
2915         * iExploder/tools: Removed.
2916         * iExploder/tools/lasthit.rb: Removed.
2917         * iExploder/tools/osx_last_crash.rb: Removed.
2918         * iExploder/tools/showtest.rb: Removed.
2919
2920 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2921
2922         Reviewed by Kenneth Rohde Christiansen.
2923
2924         [EFL] Make 'single' the default backing store in EWebLauncher
2925         https://bugs.webkit.org/show_bug.cgi?id=51534
2926
2927         'single' is the simplest backing store and the one intended to be the
2928         default in the test browser. By mistake the tiled backing store was
2929         left as default in r72617.
2930
2931         * EWebLauncher/main.c:
2932         (browserCreate): ditto.
2933
2934 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2935
2936         Reviewed by Kenneth Rohde Christiansen.
2937
2938         [EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround
2939         https://bugs.webkit.org/show_bug.cgi?id=51533
2940
2941         There's no point in concatenating env("HOME") with "blah", so remove
2942         option from EWebLauncher.
2943
2944         * EWebLauncher/main.c:
2945         (main): ditto.
2946
2947 2010-12-23  Ilya Tikhonovsky  <loislo@chromium.org>
2948
2949         Reviewed by Eric Seidel.
2950
2951         Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).
2952
2953         Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
2954         I just discovered that we have two additional GC runs per each WebViewHost.
2955         Test_shell had no such calls.
2956         These gc runs eat 15% of cpu time.
2957
2958         https://bugs.webkit.org/show_bug.cgi?id=51479
2959
2960         * DumpRenderTree/chromium/WebViewHost.cpp:
2961         (WebViewHost::~WebViewHost):
2962
2963 2010-12-22  Dirk Pranke  <dpranke@chromium.org>
2964
2965         Reviewed by Ojan Vafai.
2966
2967         This change splits out the TestRunner class into its own file.
2968         When we fork the code for message passing, we will create a new
2969         TestRunner, and this change will allow that to be more modular.
2970
2971         While we're at it, split out TestInput and ResultSummary into
2972         their own files, to reduce the size of run_webkit_tests to
2973         something more managable.
2974
2975         https://bugs.webkit.org/show_bug.cgi?id=51092
2976
2977         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2978         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
2979         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2980         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
2981         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
2982         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2983         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2984
2985  2010-12-22  Dirk Pranke  <dpranke@chromium.org>
2986
2987         Reviewed by Ojan Vafai.
2988
2989         nrwt multiprocessing - start over, prepare to fork the code
2990  
2991         This code cleans up the signatures and implementation of the
2992         TestRunner class so we can easily fork it to run either the
2993         stable implementation or the new, unstable message-passing
2994         implementation. The two variants will have different
2995         implementations of the run_tests() method. We will switch
2996         between the two based on the setting for the '--worker-model'
2997         switch. We rename the two currently valid values to 'old-inline'
2998         and 'old-threads'.
2999
3000         https://bugs.webkit.org/show_bug.cgi?id=51081
3001
3002         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3003         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3004
3005 2010-12-22  Victor Wang  <victorw@chromium.org>
3006
3007         Reviewed by Darin Fisher.
3008
3009         [Chromium] Update chromium archive test result url in rebaseline script.
3010
3011         https://bugs.webkit.org/show_bug.cgi?id=51503
3012
3013         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3014
3015 2010-12-22  Lucas Forschler  <lforschler@apple.com>
3016
3017         Reviewed by Alice Liu.
3018
3019         <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
3020         Verified on Chrome, Safari, and IE.
3021         With this change, we will record memory from a parent browser window and all child processes.
3022
3023         * record-memory-win/main.cpp:
3024         (ProcessArgs):
3025         (PrintUsage):
3026         (getMemoryInfo):
3027         (printProcessInfo):
3028         (evalProcesses):
3029         (UseImage):
3030         (QueryContinuously):
3031         (ElapsedTime):
3032
3033 2010-12-22  Lucas Forschler  <lforschler@apple.com>
3034
3035         Unreviewed rollout r74489, because it was missing changelog.
3036
3037         * record-memory-win/main.cpp:
3038         
3039 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
3040
3041         Adding myself as a reviewer.
3042
3043         * Scripts/webkitpy/common/config/committers.py:
3044
3045 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
3046
3047         Unreviewed.  Adding myself to committers.py.
3048
3049         * Scripts/webkitpy/common/config/committers.py:
3050
3051 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
3052
3053         Reviewed by Kenneth Rohde Christiansen.
3054
3055         TestNetscapePlugIn should use #if defined
3056         https://bugs.webkit.org/show_bug.cgi?id=51471
3057
3058         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3059         (NP_Initialize):
3060         (NPP_New):
3061
3062 2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
3063
3064         Reviewed by Yury Semikhatsky.
3065
3066         Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
3067
3068         DevTools window should be closed explicitly because it has custom deinitialization code.
3069
3070         https://bugs.webkit.org/show_bug.cgi?id=50722
3071
3072         * DumpRenderTree/chromium/TestShell.cpp:
3073         (TestShell::closeRemainingWindows):
3074
3075 2010-12-22  David Levin  <levin@chromium.org>
3076
3077         Reviewed by Shinichiro Hamaji.
3078
3079         check-webkit-style shouldn't complaint about underscores in variables in objective C files.
3080         https://bugs.webkit.org/show_bug.cgi?id=51452
3081
3082         * Scripts/webkitpy/style/checkers/cpp.py:
3083         (_FileState.__init__): Added the information to determine if a file is C or Objective C.
3084         Using the file extension if possible but falling back to the file contents if we have a header file.
3085         (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
3086         (_FileState.is_c_or_objective_c):
3087         (check_using_std): Changed to using _FileState to determine the file type.
3088         (check_max_min_macros): Ditto.
3089         (check_for_null): Ditto.
3090         (check_style): Changed the parameters to various calls since they now need _FileState
3091         to determine the file type.
3092         (check_language): Added the file_state parameter so it could be passed
3093         to check_identifier_name_in_declaration.
3094         (check_identifier_name_in_declaration): Don't warn about underscores in variables if
3095         this is an Objective C file.
3096         (_process_lines): Added information for the _FileState constructor (and moved the
3097         call to a place that had the information).
3098         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3099         (CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
3100         its functionality.
3101         (WebKitStyleTest.test_names): Add tests for underscores in Objective C files.
3102
3103 2010-12-21  Andy Estes  <aestes@apple.com>
3104
3105         Reviewed by Mark Rowe.
3106
3107         Do not build non-Intel architectures for WebKit2-related projects.
3108         https://bugs.webkit.org/show_bug.cgi?id=51440
3109
3110         * MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64.
3111         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
3112         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
3113
3114 2010-12-21  Mihai Parparita  <mihaip@chromium.org>
3115
3116         Reviewed by Darin Fisher.
3117
3118         [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
3119         https://bugs.webkit.org/show_bug.cgi?id=51406 
3120         
3121         Rename WebThemeControlDRT to WebThemeControlDRTWin and WebThemeEngineDRT
3122         to WebThemeEngineDRTWin and update references everywhere.
3123
3124         * DumpRenderTree/DumpRenderTree.gypi:
3125         * DumpRenderTree/chromium/TestShellWin.cpp:
3126         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.cpp.
3127         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.h.
3128         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp.
3129         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.h.
3130
3131 2010-12-21  Anders Carlsson  <andersca@apple.com>
3132
3133         Reviewed by John Sullivan.
3134
3135         Clicking missing plug-in text does not show a sheet
3136         https://bugs.webkit.org/show_bug.cgi?id=51403
3137
3138         Update for changes to the WebPageUIClient.
3139
3140         * MiniBrowser/mac/BrowserWindowController.m:
3141         (-[BrowserWindowController awakeFromNib]):
3142         * WebKitTestRunner/TestController.cpp:
3143         (WTR::createOtherPage):
3144         (WTR::TestController::initialize):
3145
3146 2010-12-21  Eric Seidel  <eric@webkit.org>
3147
3148         Reviewed by Adam Barth.
3149
3150         commit-queue will report constant failures as flaky if other tests flake
3151         https://bugs.webkit.org/show_bug.cgi?id=51272
3152
3153         This patch just removes functionality and adds testing.
3154         Previously we attempted to report flaky tests when we had
3155         two different tests fail in a row.  However, since we stop
3156         running the tests at the first failure, our code was wrong in
3157         trying to determine flakiness from the incomplete runs.
3158
3159         Originally I posted an alternate patch:
3160         https://bug-51272-attachments.webkit.org/attachment.cgi?id=77078
3161         which fixed our flaky logic in this case, however it was decided
3162         that that patch would be too difficult to maintain, so now
3163         I'm just removing the broken logic.
3164
3165         This will dramatically cut-down on our flaky-test false positives
3166         at the (small) cost of the queues being unable to report
3167         any flakiness if the tree is very flaky.  (With at least one test
3168         flaking on every run, we'll never report failures anymore.)  I think
3169         this is a tradeoff worth making.
3170
3171         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3172         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3173
3174 2010-12-20  Eric Seidel  <eric@webkit.org>
3175
3176         Reviewed by Adam Barth.
3177
3178         commit-queue wrongly rejects patches when it can't update itself
3179         https://bugs.webkit.org/show_bug.cgi?id=46636
3180
3181         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3182         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3183         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3184
3185 2010-12-20  Adam Barth  <abarth@webkit.org>
3186
3187         Move web sites to Websites directory
3188         https://bugs.webkit.org/show_bug.cgi?id=51323
3189
3190         Update references to BugsSite to point to the new location.
3191
3192         This patch was never officially reviewed (because it was too large to
3193         upload to bugs.webkit.org), but it was discussed on webkit-dev and Mark
3194         Rowe gave me the green light.
3195
3196         * Scripts/old-run-webkit-tests:
3197         * Scripts/webkitpy/common/config/build.py:
3198         * Scripts/webkitpy/common/config/build_unittest.py:
3199         * Scripts/webkitpy/common/prettypatch.py:
3200         * Scripts/webkitpy/layout_tests/port/base.py:
3201         * Scripts/webkitpy/style/main.py:
3202
3203 2010-12-20  Adrienne Walker  <enne@google.com>
3204
3205         Unreviewed. Adding myself to the list of committers.
3206
3207         * webkitpy/common/config/committers.py:
3208
3209 2010-12-20  Mark Rowe  <mrowe@apple.com>
3210
3211         Reviewed by Dan Bernstein.
3212
3213         <rdar://problem/8757601> Don't install header files in to the Resources directory.
3214
3215         * Scripts/check-for-inappropriate-files-in-framework: Don't allow .h files in the
3216         Resources directory.
3217
3218 2010-12-20  Eric Seidel  <eric@webkit.org>
3219
3220         Reviewed by Adam Barth.
3221
3222         commit-queue should include bot id when attaching failure diffs
3223         https://bugs.webkit.org/show_bug.cgi?id=51280
3224
3225         This is a tiny change to include the bot id in the name of the attachment.
3226         Most of this diff is just changing the unit test expectations
3227         now that I hid the comment printing when the comment is None.
3228
3229         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3230         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3231         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3232         * Scripts/webkitpy/tool/mocktool.py:
3233
3234 2010-12-20  Jeff Miller  <jeffm@apple.com>
3235
3236         Reviewed by Dan Bernstein.
3237
3238         Tools/vcbin/midl.exe needs to be rebuilt
3239         https://bugs.webkit.org/show_bug.cgi?id=51347
3240
3241         * vcbin/midl.exe: Rebuilt.
3242
3243 2010-12-20  David Levin  <levin@chromium.org>
3244
3245         Reviewed by Ariya Hidayat.
3246
3247         .gitignore and webkit-tools-completion.sh have references to WebKitTools that should be Tools.
3248         https://bugs.webkit.org/show_bug.cgi?id=51343
3249
3250         Follow up from the WebKitTools -> Tools rename.
3251
3252         * Scripts/webkit-tools-completion.sh:
3253
3254 2010-12-20  Cosmin Truta  <ctruta@chromium.org>
3255
3256         Reviewed by James Robinson.
3257
3258         new-run-webkit-tests ignores trailing EOL differences in text tests
3259         https://bugs.webkit.org/show_bug.cgi?id=36983
3260
3261         Changed the handling of new-line characters within new-run-webkit-tests
3262         to match old-run-webkit-tests.  Differences in leading and trailing empty
3263         lines in text expectation files are no longer ignored.
3264
3265         * Scripts/webkitpy/layout_tests/port/base.py:
3266         * Scripts/webkitpy/layout_tests/port/test.py:
3267         Added unit tests.  Removed old duplicate unit test entries.
3268         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3269
3270 2010-12-20  David Levin  <levin@chromium.org>
3271
3272         Reviewed by Shinichiro Hamaji.
3273
3274         check-webkit-style should detect function declarations (and trivial functions).
3275         https://bugs.webkit.org/show_bug.cgi?id=51303
3276
3277         * Scripts/webkitpy/style/checkers/cpp.py:
3278         (_FunctionState.begin): Add is_declaration and changed the line count
3279         start to begin at -1 (which will keep the results consistent, since
3280         the starting line number passed in is one less in this change).
3281         (detect_functions): changed function detection to now catch trivial
3282         functions and declarations.
3283         (check_pass_ptr_usage): Don't check for Pass*Ptr on the first line
3284         of the function as this may look at return values (when processing
3285         a declaration).
3286         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3287         (FunctionDetectionTest.perform_function_detection): Basic mechanics
3288         of testing the function detection.
3289         (FunctionDetectionTest.test_basic_function_detection): Test a simple
3290         function.
3291         (FunctionDetectionTest.test_function_declaration_detection): Test a
3292         declaration.
3293         (FunctionDetectionTest.test_non_functions): A test case for a case
3294         that caused the code to fail due to the { being in quotes.
3295         (PassPtrTest.test_pass_ref_ptr_return_value): Added some more test
3296         cases to help catch false alarms for return values.
3297         (PassPtrTest.test_pass_ref_ptr_member_variable): Ensure that
3298         we don't get false alarms for member variables either.
3299
3300 2010-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
3301
3302         Reviewed by Antonio Gomes.
3303
3304         [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR
3305         https://bugs.webkit.org/show_bug.cgi?id=51319
3306
3307         * CMakeListsEfl.txt:
3308
3309 2010-12-18  Adam Barth  <abarth@webkit.org>
3310
3311         Reviewed by Sam Weinig.
3312
3313         Move WebKitExamplePlugins to Examples
3314         https://bugs.webkit.org/show_bug.cgi?id=51291
3315
3316         * Scripts/webkitpy/common/config/build.py:
3317
3318 2010-12-17  Csaba Osztrogonác  <ossy@webkit.org>
3319
3320         Unreviewed Qt buildfix after r74301.
3321
3322         Rename WebKitTools to Tools
3323         https://bugs.webkit.org/show_bug.cgi?id=49861
3324
3325         * MiniBrowser/DerivedSources.pro:
3326         * MiniBrowser/qt/MiniBrowser.pro:
3327
3328 2010-12-17  Dan Bernstein  <mitz@apple.com>
3329
3330         Reviewed by Simon Fraser.
3331
3332         Rename WebKitTools to Tools
3333         https://bugs.webkit.org/show_bug.cgi?id=49861
3334
3335         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3336         * CodeCoverage/README:
3337         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3338         (WebCore::DumpRenderTree::initializeFonts):
3339         * EWSTools/start-commit-queue.sh:
3340         * EWSTools/start-queue.sh:
3341         * GNUmakefile.am:
3342         * MIDLWrapper/MIDLWrapper.cpp:
3343         (wmain):
3344         * MiniBrowser/qt/MiniBrowser.pro:
3345         * Scripts/build-api-tests:
3346         * Scripts/build-dumprendertree:
3347         * Scripts/build-webkit:
3348         * Scripts/build-webkittestrunner:
3349         * Scripts/generate-coverage-data:
3350         * Scripts/old-run-webkit-tests:
3351         * Scripts/run-api-tests:
3352         * Scripts/run-iexploder-tests:
3353         * Scripts/run-javascriptcore-tests:
3354         * Scripts/run-mangleme-tests:
3355         * Scripts/run-sunspider:
3356         * Scripts/run-webkit-websocketserver:
3357         * Scripts/sunspider-compare-results:
3358         * Scripts/test-webkitperl:
3359         * Scripts/test-webkitpy:
3360         * Scripts/update-iexploder-cssproperties:
3361         * Scripts/update-webkit:
3362         * Scripts/update-webkit-localizable-strings:
3363         * Scripts/webkitdirs.pm:
3364         * Scripts/webkitpy/common/checkout/scm.py:
3365         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3366         * Scripts/webkitpy/common/config/committervalidator.py:
3367         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
3368         * Scripts/webkitpy/common/config/ports.py:
3369         * Scripts/webkitpy/common/config/ports_unittest.py:
3370         * Scripts/webkitpy/common/system/logutils_unittest.py:
3371         * Scripts/webkitpy/common/system/ospath_unittest.py:
3372         * Scripts/webkitpy/layout_tests/port/chromium.py:
3373         * Scripts/webkitpy/layout_tests/port/config.py:
3374         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3375         * Scripts/webkitpy/layout_tests/port/http_server.py:
3376         * Scripts/webkitpy/layout_tests/port/test.py:
3377         * Scripts/webkitpy/style/checker.py:
3378         * Scripts/webkitpy/style/checker_unittest.py:
3379         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3380         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3381         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3382         * WebKitTestRunner/DerivedSources.pro:
3383         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3384         (WTR::activateFonts):
3385         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3386         * wx/build/build_utils.py:
3387
3388 2010-12-16  Antonio Gomes  <agomes@rim.com>
3389
3390         Reviewed by Martin Robinson.
3391
3392         Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
3393         https://bugs.webkit.org/show_bug.cgi?id=51163
3394
3395         Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
3396         GTK+'s DRT should also reset to UNIX after each test execution.
3397
3398         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3399         (resetDefaultsToConsistentValues):
3400
3401 2010-12-17  David Levin  <levin@chromium.org>
3402
3403         Reviewed by Eric Seidel.
3404
3405         check-webkit-style should understand WTF #include guards
3406         https://bugs.webkit.org/show_bug.cgi?id=44911
3407
3408         * Scripts/webkitpy/style/checkers/cpp.py:
3409         (get_header_guard_cpp_variable): modify to suggest the WTF style
3410         of header guard when appropriate.
3411         (check_for_header_guard): handle multiple return values from
3412         get_header_guard_cpp_variable
3413         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3414         (CppStyleTest.test_build_header_guard): Added tests for the WTF
3415         header style.
3416
3417 2010-12-16  David Levin  <levin@chromium.org>
3418
3419         Reviewed by Eric Seidel.
3420
3421         test-webkitpy: unittest for the xml.py checker displays a decprecation warning.
3422         https://bugs.webkit.org/show_bug.cgi?id=51210
3423
3424         The error only shows up when using python 2.6 or later.
3425
3426         * Scripts/webkitpy/style/checkers/xml.py: Replace the usage of
3427         the decprecated field error,message with something equivalent.
3428
3429 2010-12-16  Mihai Parparita  <mihaip@chromium.org>
3430
3431         Reviewed by Eric Seidel.
3432
3433         Add --exit-after-n-failures/crashes to NRWT
3434         https://bugs.webkit.org/show_bug.cgi?id=51160
3435         
3436         Abort test run (in a similar way to how control-C is handled) when
3437         --exit-after-n-failures/crashes-or-timeouts are passed and we've reached
3438         that number of unexpected failures/crashes/timeouts.
3439
3440         * Scripts/webkitpy/layout_tests/port/test.py:
3441         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3442         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3443
3444 2010-12-16  David Levin  <levin@chromium.org>
3445
3446         Reviewed by Shinichiro Hamaji.
3447
3448         check-webkit-style unit tests has some duplicate boilerplate code.
3449         https://bugs.webkit.org/show_bug.cgi?id=49519
3450
3451         * Scripts/webkitpy/style/checkers/cpp.py:
3452         (update_include_state): Replaced the "io" parameter with the global
3453         configuration _unit_test_config. This allowed not calling into
3454         functions at a low level and also not plumbing through the injection
3455         information through many levels of code.
3456         (check_for_include_what_you_use): Ditto.
3457         (process_file_data): Added the ability to set up the unit test config
3458         to allow for injection.
3459         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3460         (ErrorCollector.__init__): Added support for having a filter for errors.
3461         (ErrorCollector.__call__): Ditto.
3462         (CppStyleTestBase.process_file_data): Added the ability to set unit_test_config.
3463         (CppStyleTestBase.perform_lint): Consolidated logic for the perform functions.
3464         (CppStyleTestBase.perform_single_line_lint): Replace specific calls to
3465         functions in the cpp.py with generic processing and a filter that
3466         indicates what errors should be kept.
3467         (CppStyleTestBase.perform_multi_line_lint): Ditto.
3468         (CppStyleTestBase.perform_language_rules_check): Ditto.
3469         (CppStyleTestBase.perform_function_lengths_check): Ditto.
3470         (CppStyleTestBase.perform_pass_ptr_check): Ditto.
3471         (CppStyleTestBase.perform_include_what_you_use): Ditto.
3472         (CppStyleTest.test_multi_line_comments): Added another
3473         error message which applies to the test case.
3474         (CppStyleTest.test_spacing_for_binary_ops): Fixed test
3475         to not have config.h, since it is processed as a header file.
3476         (CppStyleTest.test_static_or_global_stlstrings): Fixed variable name
3477         style and indentation in checked code.
3478         (OrderOfIncludesTest.test_check_preprocessor_in_include_section):
3479         Fixed line number.
3480         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
3481         Ditto.
3482
3483 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
3484
3485         Unreviewed, rolling out r74136.
3486         http://trac.webkit.org/changeset/74136
3487         https://bugs.webkit.org/show_bug.cgi?id=51135
3488
3489         r74136 breaks chromium canary bots because some tests are not
3490         rebaselined correctly to resolve EOL differences (Requested by
3491         jianli on #webkit).
3492
3493         * Scripts/webkitpy/layout_tests/port/base.py:
3494         * Scripts/webkitpy/layout_tests/port/test.py:
3495         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3496
3497 2010-12-15  Adam Roben  <aroben@apple.com>
3498
3499         Teach check-webkit-style to check .vcproj and .vsprops files for XML
3500         syntax errors
3501
3502         Fixes <http://webkit.org/b/51103> check-webkit-style should check for
3503         XML syntax errors in .vcproj/.vsprops files
3504
3505         Reviewed by Dave Levin.
3506
3507         * Scripts/webkitpy/style/checker.py: Added lists of file extensions
3508         that should be treated as XML and that should be allowed to contain
3509         carriage returns. (These lists happen to be identical currently.)
3510         (FileType): Added a new XML type.
3511         (CheckerDispatcher.should_check_and_strip_carriage_returns): Added.
3512         Just does a simple file extension check.
3513         (CheckerDispatcher._file_type): Added a case for XML files.
3514         (CheckerDispatcher._create_checker): Ditto. We use XMLChecker for XML
3515         files (surprise!).
3516         (StyleProcessor.process): Ask the dispatcher whether we should pass the
3517         lines through the carriage checker.
3518
3519         * Scripts/webkitpy/style/checker_unittest.py:
3520         (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
3521         Added. Checks a few file names to see if carriage returns are allowed
3522         or not.
3523         (CheckerDispatcherDispatchTest.assert_checker_xml): Added. Similar to
3524         other assert_checker_* functions.
3525         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
3526         test_*_paths functions.
3527         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
3528         test_*_paths functions.
3529         (CheckerDispatcherDispatchTest.test_none_paths): Removed the vcproj
3530         file from this test case, as vcproj files now have a type.
3531         (StyleProcessor_CodeCoverageTest.MockDispatcher.should_check_and_strip_carriage_returns):
3532         Added. Similar to the other should_* functions.
3533         (StyleProcessor_CodeCoverageTest.test_process__carriage_returns_not_stripped):
3534         Added. Checks that carriage returns aren't checked for or stripped for
3535         allowed files.
3536
3537         * Scripts/webkitpy/style/checkers/xml.py: Added.
3538         (XMLChecker.__init__): Simple init method.
3539         (XMLChecker.check): Pass each line through the expat parser, and record
3540         a style error for any errors thrown by the parser.
3541
3542         * Scripts/webkitpy/style/checkers/xml_unittest.py: Added.
3543         (XMLCheckerTest.assert_no_error): Checks that the given XML does not
3544         produce a style error.
3545         (XMLCheckerTest.assert_error): Checks that the given XML produces an
3546         error of the given category on the given line.
3547         (XMLCheckerTest.mock_handle_style_error): Does nothing. Used for
3548         checking that the XMLChecker constructor works properly.
3549         (XMLCheckerTest.test_conflict_marker): Tests that conflict markers
3550         cause a style error (see, e.g., r73887).
3551         (XMLCheckerTest.test_extra_closing_tag): Tests that extra closing tags
3552         cause a style error (see, e.g., r73773).
3553         (XMLCheckerTest.test_init): Tests that the XMLChecker constructor works
3554         properly.
3555         (XMLCheckerTest.test_missing_closing_tag): Tests that missing closing
3556         tags cause a style error (see, e.g., r72795).
3557         (XMLCheckerTest.test_no_error): Tests that valid XML does not cause a
3558         style error.
3559
3560 2010-12-15  Lucas Forschler  <lforschler@apple.com>
3561
3562         Reviewed by Stephanie Lewis.
3563
3564         https://bugs.webkit.org/show_bug.cgi?id=51117
3565         Add a new leopard test bot
3566         really really commit to trunk this time.
3567
3568         * BuildSlaveSupport/build.webkit.org-config/config.json:
3569
3570 2010-12-15  Sam Weinig  <sam@webkit.org>
3571
3572         Reviewed by Anders Carlsson.
3573
3574         WebKit2: Can't add files to an <input type=file>
3575         https://bugs.webkit.org/show_bug.cgi?id=51087
3576
3577         * MiniBrowser/mac/BrowserWindowController.m:
3578         (runOpenPanel):
3579         (-[BrowserWindowController awakeFromNib]):
3580         Add simple implementation of runOpenPanel callback.
3581
3582         * MiniBrowser/win/BrowserView.cpp:
3583         (BrowserView::create):
3584         * WebKitTestRunner/TestController.cpp:
3585         (WTR::createOtherPage):
3586         (WTR::TestController::initialize):
3587         Stub out runOpenPanel callback. 
3588
3589 2010-12-14  Eric Seidel  <eric@webkit.org>
3590
3591         Reviewed by Adam Barth.
3592
3593         commit-queue should upload failure diffs when tests flake
3594         https://bugs.webkit.org/show_bug.cgi?id=51051
3595
3596         To make this testable I needed to pipe FileSystem down onto tool.
3597         We've wanted it there for a long time anyway.
3598
3599         This patch is kinda a big hack.  But we don't have a nice
3600         way to read results.html files.  I think this will need further
3601         revision before this code actually feels clean.
3602
3603         As part of testing this change, I had to make MockBugzilla.create_bug
3604         actually return an id (like it should) which required updating
3605         a few other unit test results (for the better).
3606
3607         The results_matching_keys change in layouttestresults/rebasline
3608         was an alternate path which I decided not to use in the end, but
3609         I left the change as it seemed an improvement.
3610
3611         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3612         * Scripts/webkitpy/common/net/layouttestresults.py:
3613         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3614         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3615         * Scripts/webkitpy/tool/commands/queues.py:
3616         * Scripts/webkitpy/tool/commands/rebaseline.py:
3617         * Scripts/webkitpy/tool/main.py:
3618         * Scripts/webkitpy/tool/mocktool.py:
3619
3620 2010-12-15  Cosmin Truta  <ctruta@chromium.org>
3621
3622         Reviewed by James Robinson.
3623
3624         new-run-webkit-tests ignores trailing EOL differences in text tests
3625         https://bugs.webkit.org/show_bug.cgi?id=36983
3626
3627         Changed the handling of new-line characters within new-run-webkit-tests
3628         to match old-run-webkit-tests.  Differences in leading and trailing empty
3629         lines in text expectation files are no longer ignored.
3630
3631         * Scripts/webkitpy/layout_tests/port/base.py:
3632         * Scripts/webkitpy/layout_tests/port/test.py:
3633         Added unit tests.  Removed old duplicate unit test entries.
3634         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3635
3636 2010-12-15  Ojan Vafai  <ojan@chromium.org>
3637
3638         Reviewed by Adam Barth.
3639
3640         make status-bubble white-space:nowrap so we can measure it's width without wrapping
3641         https://bugs.webkit.org/show_bug.cgi?id=51149
3642
3643         * QueueStatusServer/templates/statusbubble.html:
3644
3645 2010-12-15  Ojan Vafai  <ojan@chromium.org>
3646
3647         Reviewed by Adam Barth.
3648
3649         have the statusbubble postMessage it's metrics so that embedders can properly size the iframe
3650         https://bugs.webkit.org/show_bug.cgi?id=51125
3651
3652         * QueueStatusServer/templates/statusbubble.html:
3653
3654 2010-12-15  Darin Adler  <darin@apple.com>
3655
3656         * Scripts/webkitpy/common/net/buildbot: Added property svn:ignore.
3657
3658 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
3659
3660         Unreviewed, rolling out r74117.
3661         http://trac.webkit.org/changeset/74117
3662         https://bugs.webkit.org/show_bug.cgi?id=51113
3663
3664         This broke the GTK1 build. (Requested by mrobinson on
3665         #webkit).
3666
3667         * Scripts/webkitdirs.pm:
3668
3669 2010-12-15  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>
3670
3671         Reviewed by Martin Robinson.
3672
3673         Change generate-forwarding-headers.pl for GTK port usage 
3674         (https://bugs.webkit.org/show_bug.cgi?id=37369)
3675
3676         * Scripts/webkitdirs.pm: Added changes to build webkit2 for GTK port using build-webkit script.
3677
3678 2010-12-14  Kent Tamura  <tkent@chromium.org>
3679
3680         Reviewed by Jian Li.
3681
3682         [DRT/Chromium] Remove another unnecessary error message
3683         https://bugs.webkit.org/show_bug.cgi?id=51083
3684
3685         * DumpRenderTree/chromium/WebViewHost.cpp:
3686         (WebViewHost::didInvalidateRect):
3687
3688 2010-12-14  Lucas Forschler  <lforschler@apple.com>
3689
3690         Reviewed by Stephanie Lewis.
3691
3692         Add a new Leopard Debug Test WK2 Bot
3693
3694         * BuildSlaveSupport/build.webkit.org-config/config.json:
3695
3696 2010-12-14  Ojan Vafai  <ojan@chromium.org>
3697
3698         Fix python unittests after http://trac.webkit.org/changeset/74070.
3699
3700         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3701
3702 2010-12-14  Kent Tamura  <tkent@chromium.org>
3703
3704         Reviewed by Jian Li.
3705
3706         [DRT/Chromium] Remove a unnecessary error message
3707         https://bugs.webkit.org/show_bug.cgi?id=51069
3708
3709         * DumpRenderTree/chromium/WebViewHost.cpp:
3710         (WebViewHost::paintInvalidatedRegion):
3711
3712 2010-12-14  Benjamin Kalman  <kalman@chromium.org>
3713
3714         Reviewed by Ojan Vafai.
3715
3716         Using BUG/BUGWK in test_expectations is error prone, should use BUGCR/BUGWK
3717         https://bugs.webkit.org/show_bug.cgi?id=48926
3718
3719         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3720         Add presubmit check that BUG isn't used, either BUGCR/BUGWK/BUGV8_.
3721
3722 2010-12-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3723
3724         Reviewed by Eric Seidel.
3725
3726         [Qt] [Symbian] Do not use pkg-config on Symbian as it is not supported
3727         https://bugs.webkit.org/show_bug.cgi?id=50231
3728
3729         Guard CONFIG+=link_pkgconfig with !symbian.
3730
3731         * DumpRenderTree/qt/DumpRenderTree.pro:
3732         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3733         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3734
3735 2010-12-14  Philippe Normand  <pnormand@igalia.com>
3736
3737         Reviewed by Ojan Vafai.
3738
3739         [new-run-webkit-tests] expectations parsing is slow
3740         https://bugs.webkit.org/show_bug.cgi?id=50635
3741
3742         Avoid expensive iteration of all the tests when checking if a test
3743         file is to be skipped or not.
3744
3745         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3746         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3747         * Scripts/webkitpy/layout_tests/port/test.py:
3748
3749 2010-12-14  Mario Sanchez Prada  <msanchez@igalia.com>
3750
3751         Reviewed by Xan Lopez.
3752
3753         [Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding events for text objects
3754         https://bugs.webkit.org/show_bug.cgi?id=27048
3755
3756         Add support in DRT for checking whether an accessibility UI
3757         element is focusable and/or focused. Implemented for GTK.
3758
3759         * DumpRenderTree/AccessibilityUIElement.cpp:
3760         (getIsFocusedCallback): New.
3761         (getIsFocusableCallback): New.
3762         (AccessibilityUIElement::getJSClass): Add the new available
3763         callbacks for isFocused and isFocusable.
3764         * DumpRenderTree/AccessibilityUIElement.h:
3765         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3766         (AccessibilityUIElement::isFocused): New, implemented by checking
3767         whether the related AtkState value is in the object's state set.
3768         (AccessibilityUIElement::isFocusable): Ditto.
3769         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3770         (AccessibilityUIElement::isFocused): New, dummy implementation.
3771         (AccessibilityUIElement::isFocusable): Ditto.
3772         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3773         (AccessibilityUIElement::isFocused): Ditto.
3774         (AccessibilityUIElement::isFocusable): Ditto.
3775
3776 2010-12-14  Eric Seidel  <eric@webkit.org>
3777
3778         Reviewed by Ojan Vafai.
3779
3780         webkit-patch should warn users when they're using a 32-bit git on a 64-bit system
3781         https://bugs.webkit.org/show_bug.cgi?id=50715
3782
3783         This patch makes webkit-patch print the following:
3784
3785         Warning: This machine is 64-bit, but the git binary (/usr/local/git/bin/git) does not support 64-bit.
3786         Install a 64-bit git for better performance, see:
3787         https://lists.webkit.org/pipermail/webkit-dev/2010-December/015249.html
3788
3789         I wrote this mostly because I have approximately 8 machines that I use
3790         and making sure each one is using a good Git install seemed folly.
3791         webkit-patch makes a lot of git calls, so using a fast git can shave
3792         several seconds in every invocation.  See the webkit-dev thread for more info.
3793
3794         This message will print twice during 'webkit-patch upload',
3795         once from webkit-patch and once from check-webkit-style.
3796
3797         Unfortunately there is no good way to test this due to how machine-dependent
3798         the code is.  I considered writing a test for the log message, but it seemed not worth it.
3799
3800         * Scripts/webkitpy/common/checkout/scm.py:
3801
3802 2010-12-13  Eric Seidel  <eric@webkit.org>
3803
3804         Reviewed by Adam Barth.
3805
3806         FlakyTestReporter doesn't understand bots running from multiple email addresses
3807         https://bugs.webkit.org/show_bug.cgi?id=50960
3808
3809         This explains at least one of the dupes of:
3810         https://bugs.webkit.org/show_bug.cgi?id=50863
3811         that we saw filed by the commit-queue this morning.
3812         I think the other one was explained by my previous fix to result counting code.
3813
3814         Since this is really hard to test with a unit test, instead I
3815         create a new (possibly useful in the future) command
3816         which given a layout test path will return you
3817         the one bug which our tools would assume it the flaky test bug.
3818         If some other script wants to use bug-for-test we'll
3819         need to extend it with some options like --create-if-missing or similar.
3820
3821         * Scripts/webkitpy/common/net/bugzilla/bug.py:
3822         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3823         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3824         * Scripts/webkitpy/tool/commands/__init__.py:
3825         * Scripts/webkitpy/tool/commands/bugfortest.py: Added.
3826
3827 2010-12-13  Mihai Parparita  <mihaip@chromium.org>
3828
3829         Reviewed by James Robinson.
3830
3831         Add option to build-webkit to not build WebKit2
3832         https://bugs.webkit.org/show_bug.cgi?id=50988
3833         
3834         Add support for a --no-webkit2 option to build-webkit. It seems to save
3835         ~1 minute from clean builds and ~10 seconds from no-op builds.
3836
3837         * Scripts/build-webkit:
3838
3839 2010-12-13  Lucas Forschler  <lforschler@apple.com>
3840
3841         Reviewed by Dave Kilzer.
3842
3843         Update iexploder from 1.3.2 to 1.7.2
3844         Move 1.3.2 into its own subdir
3845         Add 1.7.2 into its own subdir
3846         update scripts to point to new 1.3.2 location (avoid breaking existing scripts)
3847
3848         * Scripts/run-iexploder-tests:
3849         * Scripts/update-iexploder-cssproperties:
3850         * iExploder/CHANGELOG.txt: Removed.
3851         * iExploder/LICENSE.txt: Removed.
3852         * iExploder/README.txt: Removed.
3853         * iExploder/htdocs: Removed.
3854         * iExploder/iexploder-1.3.2: Added.
3855         * iExploder/iexploder-1.3.2/CHANGELOG.txt: Copied from iExploder/CHANGELOG.txt.
3856         * iExploder/iexploder-1.3.2/LICENSE.txt: Copied from iExploder/LICENSE.txt.
3857         * iExploder/iexploder-1.3.2/README.txt: Copied from iExploder/README.txt.
3858         * iExploder/iexploder-1.3.2/htdocs: Added.
3859         * iExploder/iexploder-1.3.2/htdocs/config.rb: Copied from iExploder/htdocs/config.rb.
3860         * iExploder/iexploder-1.3.2/htdocs/cssproperties.in: Copied from iExploder/htdocs/cssproperties.in.
3861         * iExploder/iexploder-1.3.2/htdocs/cssvalues.in: Copied from iExploder/htdocs/cssvalues.in.
3862         * iExploder/iexploder-1.3.2/htdocs/htmlattrs.in: Copied from iExploder/htdocs/htmlattrs.in.
3863         * iExploder/iexploder-1.3.2/htdocs/htmltags.in: Copied from iExploder/htdocs/htmltags.in.
3864         * iExploder/iexploder-1.3.2/htdocs/htmlvalues.in: Copied from iExploder/htdocs/htmlvalues.in.
3865         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi: Copied from iExploder/htdocs/iexploder.cgi.
3866         * iExploder/iexploder-1.3.2/htdocs/iexploder.rb: Copied from iExploder/htdocs/iexploder.rb.
3867         * iExploder/iexploder-1.3.2/htdocs/index.html: Copied from iExploder/htdocs/index.html.
3868         * iExploder/iexploder-1.3.2/htdocs/webserver.rb: Copied from iExploder/htdocs/webserver.rb.
3869         * iExploder/iexploder-1.3.2/tools: Added.
3870         * iExploder/iexploder-1.3.2/tools/lasthit.rb: Copied from iExploder/tools/lasthit.rb.
3871         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb: Copied from iExploder/tools/osx_last_crash.rb.
3872         * iExploder/iexploder-1.3.2/tools/showtest.rb: Copied from iExploder/tools/showtest.rb.
3873         * iExploder/iexploder-1.7.2: Added.
3874         * iExploder/iexploder-1.7.2/ChangeLog.txt: Added.
3875         * iExploder/iexploder-1.7.2/LICENSE.txt: Added.
3876         * iExploder/iexploder-1.7.2/README.txt: Added.
3877         * iExploder/iexploder-1.7.2/output: Added.
3878         * iExploder/iexploder-1.7.2/src: Added.
3879         * iExploder/iexploder-1.7.2/src/browser_harness.rb: Added.
3880         * iExploder/iexploder-1.7.2/src/config.yaml: Added.
3881         * iExploder/iexploder-1.7.2/src/css-atrules: Added.
3882         * iExploder/iexploder-1.7.2/src/css-atrules/mozilla: Added.
3883         * iExploder/iexploder-1.7.2/src/css-atrules/webkit: Added.
3884         * iExploder/iexploder-1.7.2/src/css-properties: Added.
3885         * iExploder/iexploder-1.7.2/src/css-properties/dillo: Added.
3886         * iExploder/iexploder-1.7.2/src/css-properties/gtkhtml: Added.
3887         * iExploder/iexploder-1.7.2/src/css-properties/internet_explorer6: Added.
3888         * iExploder/iexploder-1.7.2/src/css-properties/mozilla: Added.
3889         * iExploder/iexploder-1.7.2/src/css-properties/webkit: Added.
3890         * iExploder/iexploder-1.7.2/src/css-pseudo: Added.
3891         * iExploder/iexploder-1.7.2/src/css-pseudo/mozilla: Added.
3892         * iExploder/iexploder-1.7.2/src/css-pseudo/webkit: Added.
3893         * iExploder/iexploder-1.7.2/src/css-values: Added.
3894         * iExploder/iexploder-1.7.2/src/css-values/dillo: Added.
3895         * iExploder/iexploder-1.7.2/src/css-values/gtkhtml: Added.
3896         * iExploder/iexploder-1.7.2/src/css-values/mozilla: Added.
3897         * iExploder/iexploder-1.7.2/src/css-values/other: Added.
3898         * iExploder/iexploder-1.7.2/src/css-values/webkit: Added.
3899         * iExploder/iexploder-1.7.2/src/headers: Added.
3900         * iExploder/iexploder-1.7.2/src/headers/dillo: Added.
3901         * iExploder/iexploder-1.7.2/src/headers/gtkhtml: Added.
3902         * iExploder/iexploder-1.7.2/src/headers/mozilla: Added.
3903         * iExploder/iexploder-1.7.2/src/headers/webkit: Added.
3904         * iExploder/iexploder-1.7.2/src/html-attrs: Added.
3905         * iExploder/iexploder-1.7.2/src/html-attrs/dillo: Added.
3906         * iExploder/iexploder-1.7.2/src/html-attrs/gtkhtml: Added.
3907         * iExploder/iexploder-1.7.2/src/html-attrs/internet_explorer6: Added.
3908         * iExploder/iexploder-1.7.2/src/html-attrs/mozilla: Added.
3909         * iExploder/iexploder-1.7.2/src/html-attrs/other: Added.
3910         * iExploder/iexploder-1.7.2/src/html-attrs/webkit: Added.
3911         * iExploder/iexploder-1.7.2/src/html-tags: Added.
3912         * iExploder/iexploder-1.7.2/src/html-tags/dillo: Added.
3913         * iExploder/iexploder-1.7.2/src/html-tags/gtkhtml: Added.
3914         * iExploder/iexploder-1.7.2/src/html-tags/mozilla: Added.
3915         * iExploder/iexploder-1.7.2/src/html-tags/other: Added.
3916         * iExploder/iexploder-1.7.2/src/html-tags/webkit: Added.
3917         * iExploder/iexploder-1.7.2/src/html-values: Added.
3918         * iExploder/iexploder-1.7.2/src/html-values/dillo: Added.
3919         * iExploder/iexploder-1.7.2/src/html-values/gtkhtml: Added.
3920         * iExploder/iexploder-1.7.2/src/html-values/mozilla: Added.
3921         * iExploder/iexploder-1.7.2/src/html-values/other: Added.
3922         * iExploder/iexploder-1.7.2/src/html-values/webkit: Added.
3923         * iExploder/iexploder-1.7.2/src/iexploder.cgi: Added.
3924         * iExploder/iexploder-1.7.2/src/iexploder.rb: Added.
3925         * iExploder/iexploder-1.7.2/src/index.html: Added.
3926         * iExploder/iexploder-1.7.2/src/media: Added.
3927         * iExploder/iexploder-1.7.2/src/media/blank.ogg: Added.
3928         * iExploder/iexploder-1.7.2/src/media/blank.snd: Added.
3929         * iExploder/iexploder-1.7.2/src/media/blank.wav: Added.
3930         * iExploder/iexploder-1.7.2/src/media/bug.bmp: Added.
3931         * iExploder/iexploder-1.7.2/src/media/bug.gif: Added.
3932         * iExploder/iexploder-1.7.2/src/media/bug.ico: Added.
3933         * iExploder/iexploder-1.7.2/src/media/bug.jng: Added.
3934         * iExploder/iexploder-1.7.2/src/media/bug.jpg: Added.
3935         * iExploder/iexploder-1.7.2/src/media/bug.png: Added.
3936         * iExploder/iexploder-1.7.2/src/media/bug.svg: Added.
3937         * iExploder/iexploder-1.7.2/src/media/bug.tiff: Added.
3938         * iExploder/iexploder-1.7.2/src/media/bug.xbm: Added.
3939         * iExploder/iexploder-1.7.2/src/media/bug.xpm: Added.
3940         * iExploder/iexploder-1.7.2/src/mime-types: Added.
3941         * iExploder/iexploder-1.7.2/src/mime-types/dillo: Added.
3942         * iExploder/iexploder-1.7.2/src/mime-types/mozilla: Added.
3943         * iExploder/iexploder-1.7.2/src/mime-types/webkit: Added.
3944         * iExploder/iexploder-1.7.2/src/protocols: Added.
3945         * iExploder/iexploder-1.7.2/src/protocols/dillo: Added.
3946         * iExploder/iexploder-1.7.2/src/protocols/gtkhtml: Added.
3947         * iExploder/iexploder-1.7.2/src/protocols/mozilla: Added.
3948         * iExploder/iexploder-1.7.2/src/protocols/webkit: Added.
3949         * iExploder/iexploder-1.7.2/src/scanner.rb: Added.
3950         * iExploder/iexploder-1.7.2/src/version.rb: Added.
3951         * iExploder/iexploder-1.7.2/src/webserver.rb: Added.
3952         * iExploder/iexploder-1.7.2/testcases: Added.
3953         * iExploder/iexploder-1.7.2/testcases/testcase-Linux_x86_64_rv2.0b6pre_Gecko-20100904_Firefox-4.0b6pre-TEST-8375-1_59.html: Added.
3954         * iExploder/iexploder-1.7.2/testcases/testcase-Opera-9.80_Linux_x86_64_en_Presto-2.6.30_Version-10.61-16704-3_108,3.html: Added.
3955         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_Chrome-7.0.529.0-TEST-611-3_36,9.html: Added.
3956         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_hrome-7.0.529.0-TEST-55313622206-3_6,0.html: Added.
3957         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-120813-8_72,56,24,8,0.html: Added.
3958         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-121240-3_81,3.html: Added.
3959         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-4800-5_80,65,15.html: Added.
3960         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-TEST-23583190347-3_15,12.html: Added.
3961         * iExploder/iexploder-1.7.2/tools: Added.
3962         * iExploder/iexploder-1.7.2/tools/lasthit.rb: Added.
3963         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb: Added.
3964         * iExploder/iexploder-1.7.2/tools/release_src.sh: Added.
3965         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added.
3966         * iExploder/tools: Removed.
3967
3968 2010-12-13  Sam Weinig  <sam@webkit.org>
3969
3970         Reviewed by Anders Carlsson.
3971
3972         Remove associated page concept from WKView constructor
3973         https://bugs.webkit.org/show_bug.cgi?id=50983
3974
3975         Step 1: Remove associate page constructors from WKView and make
3976         all views use the shared namespace for the context.
3977
3978         * TestWebKitAPI/PlatformWebView.h:
3979         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3980         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3981         * WebKitTestRunner/PlatformWebView.h:
3982         * WebKitTestRunner/TestController.cpp:
3983         (WTR::createOtherPage):
3984         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3985         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3986         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3987
3988 2010-12-13  Sam Weinig  <sam@webkit.org>
3989
3990         Reviewed by Anders Carlsson.
3991
3992         Change the WebKit2 public API so there is no explicit WKPageNamespace object
3993         https://bugs.webkit.org/show_bug.cgi?id=50898
3994
3995         * MiniBrowser/mac/AppDelegate.h:
3996         * MiniBrowser/mac/AppDelegate.m:
3997         * MiniBrowser/mac/BrowserWindowController.h:
3998         * MiniBrowser/mac/BrowserWindowController.m:
3999         * MiniBrowser/win/BrowserView.cpp:
4000         Convert MiniBrowser to not use PageNamespaces.
4001
4002         * TestWebKitAPI/PlatformWebView.h:
4003         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
4004         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
4005         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
4006         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
4007         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
4008         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
4009         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
4010         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
4011         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
4012         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
4013         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
4014         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
4015         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
4016         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
4017         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
4018         Convert TestWebKitAPI to not use PageNamespaces.
4019
4020         * WebKitTestRunner/PlatformWebView.h:
4021         * WebKitTestRunner/TestController.cpp:
4022         * WebKitTestRunner/TestController.h:
4023         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
4024         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
4025         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
4026         Convert WebKitTestRunner to not use PageNamespaces.
4027
4028 2010-12-13  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
4029
4030         Reviewed by Eric Seidel.
4031
4032         webkit-patch rollout should be able to do multi-revision rollouts
4033         https://bugs.webkit.org/show_bug.cgi?id=33336
4034
4035         Make it possible to pass more than one revision to webkit-patch.
4036
4037         * Scripts/webkitpy/common/checkout/api.py:
4038         * Scripts/webkitpy/common/checkout/changelog.py:
4039         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
4040         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
4041         * Scripts/webkitpy/tool/commands/download.py:
4042         * Scripts/webkitpy/tool/commands/download_unittest.py:
4043         * Scripts/webkitpy/tool/mocktool.py:
4044         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
4045         * Scripts/webkitpy/tool/steps/revertrevision.py:
4046
4047 2010-12-13  Eric Seidel  <eric@webkit.org>
4048
4049         Unreviewed.
4050
4051         Teach webkit-patch how to search bugzilla
4052         https://bugs.webkit.org/show_bug.cgi?id=50500
4053
4054         webkit-patch bug-search fails when there is only one result.
4055         Turns out we needed a bit more logic in our result count parsing code.
4056
4057         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
4058         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
4059
4060 2010-12-13  Antti Koivisto  <antti@apple.com>
4061
4062         Reviewed by Alexey Proskuryakov.
4063
4064         Add setSerializeHTTPLoads function to allow testing resource load order on OS X.
4065         https://bugs.webkit.org/show_bug.cgi?id=50758
4066
4067         * DumpRenderTree/LayoutTestController.cpp:
4068         (setSerializeHTTPLoadsCallback):
4069         (LayoutTestController::staticFunctions):
4070         * DumpRenderTree/LayoutTestController.h:
4071         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4072         (LayoutTestController::setSerializeHTTPLoads):
4073         * DumpRenderTree/mac/DumpRenderTree.mm:
4074         (resetDefaultsToConsistentValues):
4075         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4076         (LayoutTestController::setSerializeHTTPLoads):
4077         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4078         (LayoutTestController::setSerializeHTTPLoads):
4079
4080 2010-12-13  Dimitri Glazkov  <dglazkov@chromium.org>
4081
4082         Reviewed by Ojan Vafai.
4083
4084         Remove "use-drt" option from test step command line, since the option was removed in r73748.
4085         https://bugs.webkit.org/show_bug.cgi?id=50936
4086
4087         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed the option.
4088
4089 2010-12-13  Patrick Gansterer  <paroga@webkit.org>
4090
4091         Reviewed by Csaba Osztrogonác.
4092
4093         Add revlink to BuildBot status
4094         https://bugs.webkit.org/show_bug.cgi?id=50914
4095
4096         This adds a hyperlink to trac changeset on the revision numbers. 
4097
4098         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4099
4100 2010-12-13  Andras Becsi  <abecsi@webkit.org>
4101
4102         Reviewed by Csaba Osztrogonác.
4103
4104         [Qt][WK2] Fix build if WebKitTools are not available
4105         https://bugs.webkit.org/show_bug.cgi?id=50242
4106
4107         * MiniBrowser/qt/MiniBrowser.pro: Correct the comment.
4108         * Scripts/webkitdirs.pm: Added WebKitTools/MiniBrowser to $subdirs.
4109         * MiniBrowser/DerivedSources.pro: Added.
4110
4111 2010-12-13  Eric Seidel  <eric@webkit.org>
4112
4113         Reviewed by Adam Barth.
4114
4115         EWS Queues should remove orpahned pyc files before starting
4116         https://bugs.webkit.org/show_bug.cgi?id=50904
4117
4118         A previous check added a platform.py which caused
4119         EWS bots on some platforms to hit an import exception.
4120         The platform.py file was removed in a subsequent commit, but
4121         the EWS bots in question stayed stuck.  This change will
4122         fix those bots once restarted (and prevent this in the future).
4123
4124         I also went ahead and unified start-queue and start-commit-queue
4125         since they were nearly identical.  I also added bot_id support
4126         to both force all EWSes to have bot ids as well as get rid of the one
4127         remaining reason why I had my own copies of these scripts.
4128         Hopefully this will be enough to get all the other bot admins
4129         (ahem, Adam, ahem) to move to using these checked in copies as well.
4130
4131         * EWSTools/start-commit-queue.sh: Removed.
4132         * EWSTools/start-queue.sh:
4133
4134 2010-10-28  MORITA Hajime  <morrita@google.com>
4135
4136         Reviewed by Ojan Vafai.
4137
4138         spellcheck does not check pasted text
4139         https://bugs.webkit.org/show_bug.cgi?id=40092
4140
4141         Added LayoutTestController::setAsynchronousSpellCheckingEnabled()
4142         to control the setting.
4143
4144         * DumpRenderTree/LayoutTestController.cpp:
4145         (setAsynchronousSpellCheckingEnabledCallback):
4146         (LayoutTestController::staticFunctions):
4147         * DumpRenderTree/LayoutTestController.h:
4148         * DumpRenderTree/chromium/LayoutTestController.h:
4149         * DumpRenderTree/chromium/LayoutTestController.cpp:
4150         (LayoutTestController::LayoutTestController):
4151         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
4152         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4153         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
4154         * DumpRenderTree/mac/DumpRenderTree.mm:
4155         (resetDefaultsToConsistentValues):
4156         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4157         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
4158         * DumpRenderTree/qt/LayoutTestControllerQt.h:
4159         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4160         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
4161         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4162         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
4163         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
4164         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
4165
4166 2010-12-12  Sam Weinig  <sam@webkit.org>
4167
4168         Reviewed by Anders Carlsson.
4169
4170         Fix failing API test. It turns out that a pop-state event
4171         is sent before every fragment navigation, so we have to test
4172         for it in addition in PageLoadDidChangeLocationWithinPageForFrame.
4173
4174         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
4175         (TestWebKitAPI::didSameDocumentNavigationForFrame):
4176
4177 2010-12-12  Alejandro G. Castro  <alex@igalia.com>
4178
4179         Reviewed by Eric Seidel.
4180
4181         [GTK] Add new-run-webkit-tests support to gtk
4182         https://bugs.webkit.org/show_bug.cgi?id=50681
4183
4184         Adding the basic support to run the new-run-webkit-tests.
4185
4186         * Scripts/webkitpy/layout_tests/port/gtk.py:
4187
4188 2010-10-11  Diego Gonzalez  <diegohcg@webkit.org>
4189
4190         Reviewed by Kenneth Rohde Christiansen.
4191
4192         [Qt] Mock DeviceOrientation client for DRT
4193         https://bugs.webkit.org/show_bug.cgi?id=47490
4194
4195         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4196         (WebCore::DumpRenderTree::DumpRenderTree):
4197         (WebCore::DumpRenderTree::~DumpRenderTree):
4198         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4199         (LayoutTestController::setMockDeviceOrientation):
4200
4201 2010-12-11  Philippe Normand  <pnormand@igalia.com>
4202
4203         Reviewed by Gustavo Noronha Silva.
4204
4205         [GTK] launcher: disable the Mozilla-style fullscreen API
4206         https://bugs.webkit.org/show_bug.cgi?id=50874
4207
4208         Disabling the fullscreen API until its implementation for GTK is
4209         mature enough. The webview setting for it is already FALSE by
4210         default.
4211
4212         * GtkLauncher/main.c:
4213         (createWindow):
4214
4215 2010-12-10  Eric Seidel  <eric@webkit.org>
4216
4217         Reviewed by Adam Barth.
4218
4219         commit-queue flaky test messages show cryptic version information for mac os x
4220         https://bugs.webkit.org/show_bug.cgi?id=50864
4221
4222         Turns out platform.platform() returns kernel version information
4223         which isn't helpful, and just plain confusing on Mac
4224         (OS X 10.6.5 uses Darwin Kernel 10.5.0).
4225
4226         So I've updated PlatformInfo.display_name() to special case
4227         mac.  I also found a bad use of sys.platform in the process
4228         and fixed that.  (sys.platform always returns 'darwin' on mac).
4229
4230         * Scripts/webkitpy/common/system/platforminfo.py:
4231         * Scripts/webkitpy/common/system/user.py:
4232         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
4233         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
4234         * Scripts/webkitpy/tool/commands/queues_unittest.py:
4235
4236 2010-12-10  Eric Seidel  <eric@webkit.org>
4237
4238         Unreviewed.
4239
4240         Exception seen while reporting flaky test with commit-queue.
4241         Just a missing include.
4242
4243         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
4244         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
4245
4246 2010-12-10  Kinuko Yasuda  <kinuko@chromium.org>
4247
4248         Reviewed by Eric Seidel.
4249
4250         [Chromium] Remove old JSONResultsGenerator script that existed for backward-compatibility
4251         https://bugs.webkit.org/show_bug.cgi?id=50796
4252
4253         Also updating the test code to use JSONResultsGeneratorBase and
4254         to improve test coverage for incremental cases.
4255
4256         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
4257         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
4258
4259 2010-12-10  Joseph Pecoraro  <joepeck@webkit.org>
4260
4261         Reviewed by Darin Adler.
4262
4263         prepare-ChangeLog --help doesn't mention --bug shorthand -b
4264         https://bugs.webkit.org/show_bug.cgi?id=50835
4265
4266         * Scripts/prepare-ChangeLog: be more explicit about -b and match file style.
4267
4268 2010-12-10  Eric Seidel  <eric@webkit.org>
4269
4270         Reviewed by Adam Barth.
4271
4272         Bugs created by the commit-queue should all block on a master bug
4273         https://bugs.webkit.org/show_bug.cgi?id=50857
4274
4275         This makes all bugs created by the commit-queue block on:
4276         https://bugs.webkit.org/show_bug.cgi?id=50856
4277
4278         In the process of testing this, I found that the existing
4279         create_bug code was wrong.  I also found that existing
4280         unit tests for create-rollout used invalid values
4281         for options.blocks.  I fixed both issues and tested.
4282
4283         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
4284         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
4285         * Scripts/webkitpy/tool/commands/commandtest.py:
4286         * Scripts/webkitpy/tool/commands/download_unittest.py:
4287         * Scripts/webkitpy/tool/commands/upload_unittest.py:
4288         * Scripts/webkitpy/tool/mocktool.py:
4289         * Scripts/webkitpy/tool/steps/options.py:
4290
4291 2010-12-10  Eric Seidel  <eric@webkit.org>
4292
4293         Reviewed by Adam Barth.
4294
4295         Teach webkitpy how to follow duplicate chains when posting comments on flake bugs
4296         https://bugs.webkit.org/show_bug.cgi?id=50853
4297
4298         I also discovered when doing this that the code was posting
4299         the comment on the wrong bug, but that's fixed here too.
4300
4301         * Scripts/webkitpy/common/net/bugzilla/bug.py:
4302         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
4303         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
4304         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
4305         * Scripts/webkitpy/tool/commands/queues_unittest.py:
4306         * Scripts/webkitpy/tool/mocktool.py:
4307
4308 2010-12-10  Anders Carlsson  <andersca@apple.com>
4309
4310         Reviewed by John Sullivan.
4311
4312         Make WKContextGetStatistics gather global statistics
4313         https://bugs.webkit.org/show_bug.cgi?id=50850
4314
4315         Remove the code that gets the statistics and fills in the per context
4316         statistics information for now.
4317
4318         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
4319         (-[BrowserStatisticsWindowController refreshStatistics:]):
4320
4321 2010-12-10  Eric Seidel  <eric@webkit.org>
4322
4323         Unreviewed.
4324
4325         commit-queue should report port/platform information when commenting on flaky test bugs
4326         https://bugs.webkit.org/show_bug.cgi?id=50839
4327
4328         Renamed platform.py to platforminfo.py.  This broke import platform in executive.py
4329         which was only used by new run webkit tests (and clearly not unit tested).
4330
4331         * Scripts/webkitpy/common/system/platforminfo.py: Renamed from WebKitTools/Scripts/webkitpy/common/system/platform.py.
4332         * Scripts/webkitpy/tool/main.py:
4333         * Scripts/webkitpy/tool/mocktool.py: