Flakiness dashboard should support OS X El Capitan
[WebKit-https.git] / Tools / ChangeLog
1 2015-10-02  Aakash Jain  <aakash_jain@apple.com>
2
3         Flakiness dashboard should support OS X El Capitan
4         https://bugs.webkit.org/show_bug.cgi?id=149648
5
6         Reviewed by Alexey Proskuryakov.
7
8         * TestResultServer/static-dashboards/flakiness_dashboard.js: Fix the broken dashboard for ElCapitan.
9
10 2015-10-02  Daniel Bates  <dabates@apple.com>
11
12         Fix run-webkit-tests --ios-simulator after <http://trac.webkit.org/changeset/190515>
13         (https://bugs.webkit.org/show_bug.cgi?id=149753)
14
15         For now, pass --ios-simulator.
16
17         * Scripts/webkitpy/port/ios.py:
18         (IOSSimulatorPort._build_relay):
19
20 2015-10-02  Simon Fraser  <simon.fraser@apple.com>
21
22         Remove a "nullable" that breaks the iOS 8 build.
23
24         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
25         (-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]):
26
27 2015-10-02  Daniel Bates  <dabates@apple.com>
28
29         LayoutTestRelay is not built and archived when building for iOS Simulator
30         https://bugs.webkit.org/show_bug.cgi?id=149753
31
32         Reviewed by Alexey Proskuryakov and Andy Estes.
33
34         Towards running layout tests on the iOS Simulator test bots, we need to teach scripts build-webkit
35         and built-product-archive to build the Mac tool LayoutTestRelay and include this tool in the built
36         product archive when building for iOS Simulator, respectively.
37
38         * BuildSlaveSupport/built-product-archive:
39         (main): Pass the full platform name (options.platform) to archiveBuiltProduct() so that it can
40         differentiate between iOS device and iOS Simulator platforms.
41         (webkitBuildDirectoryForConfigurationAndPlatform): Extracted logic to run the script webkit-build-directory
42         from determineWebKitBuildDirectories() into this function so that it can be used by both
43         determineWebKitBuildDirectories() and archiveBuiltProduct().
44         (determineWebKitBuildDirectories): Moved logic to execute the script webkit-build-directory from here to
45         webkitBuildDirectoryForConfigurationAndPlatform().
46         (createZip): Added parameter embedParentDirectoryNameOnDarwin (defaults to False) to specify whether
47         we should call ditto(1) with --keepParent to embed the parent directory name in the zip archive. This
48         argument is only applicable when building on Darwin. We only pass embedParentDirectoryNameOnDarwin=True
49         when making an archive for a Mac or iOS device build. For iOS Simulator builds we archive two directories
50         and we do not want to keep the parent directory because it is a placeholder directory used as a workaround
51         for the limitation that ditto(1) can only accept a single directory to archive on its command line.
52         (archiveBuiltProduct): Modified to take the full platform name as an argument. Added logic for iOS.
53         For iOS device builds we use the same logic as for a Mac build and archive the configuration-specific
54         build directory. For iOS Simulator builds we archive the configuration-specific iOS build directory,
55         LayoutTestRelay and LayoutTestRelay.dSYM (if it exists) from the configuration-specific Mac build.
56         * Scripts/build-layouttestrelay:
57             - Remove unnecessary include of Perl module POSIX.
58             - Only build LayoutTestRelay when building for iOS Simulator (i.e. --ios-simulator is passed).
59         * Scripts/build-webkit:
60             - Invoke script build-layouttestrelay when building for iOS Simulator.
61
62 2015-10-02  Brent Fulgham  <bfulgham@apple.com>
63
64         [Win] Unreviewed test fix.
65
66         You cannot run 'run-webkit-tests' from the command line because it does not know
67         to append the binary subdirectory (bin32/bin64). We don't see this on our builders
68         because they explicitly set use the 'root' argument to provide the full path to
69         the test binaries.
70
71         * Scripts/webkitpy/port/win.py:
72         (WinPort._build_path): Added.
73
74 2015-10-02  Alex Christensen  <achristensen@webkit.org>
75
76         Reloading without content blockers doesn't apply to resource loads after the main frame finishes
77         https://bugs.webkit.org/show_bug.cgi?id=149430
78         rdar://problem/22742222
79
80         Reviewed by Geoffrey Garen.
81
82         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
83         (WTR::TestController::cocoaResetStateToConsistentValues):
84         * WebKitTestRunner/mac/TestControllerMac.mm:
85         (WTR::TestController::platformConfigureViewForTest):
86         Test what happens when you disable content blockers from the SPI.
87
88 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
89
90         [Win] Unreviewed build fix for run-api-tests
91
92         * Scripts/run-api-tests:
93         (testToolPaths): Windows run needs to specify the binary path.
94
95 2015-10-01  Daniel Bates  <dabates@apple.com>
96
97         Another attempt to fix the Windows builders after <https://trac.webkit.org/changeset/190387>
98         (https://bugs.webkit.org/show_bug.cgi?id=149695)
99
100         Following r190424 we can now rely on webkit-build-directory to return the path to
101         the correct configuration-specific build directory on Windows.
102
103         * BuildSlaveSupport/built-product-archive:
104         (archiveBuiltProduct):
105
106 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
107
108         [Win] Unreviewed build fix.
109
110         * Scripts/webkitdirs.pm:
111         (setupAppleWinEnv): Use 64-bit build tools if available
112
113 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
114
115         [Win] Fix TestWebKitAPI build under CMake.
116
117         Reviewed by Alex Christensen.
118
119         * TestWebKitAPI/PlatformWin.cmake: Add missing link command
120         for Psapi.lib.
121
122 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
123
124         [Win] Fix behavior of webkit-build-directory script
125         https://bugs.webkit.org/show_bug.cgi?id=149718
126
127         Reviewed by Alex Christensen.
128
129         * Scripts/webkitdirs.pm:
130         (determineConfigurationProductDir): Do not include the binary
131         sub-directory in the configuration product directory output.
132         (jscProductDir): Append correct binary path for Windows build.
133         (setPathForRunningWebKitApp): Include properly binary subdirectories.
134         (runSafari): Update for revised productDir behavior.
135         (runMiniBrowser): Ditto.
136
137 2015-10-01  Alexey Proskuryakov  <ap@apple.com>
138
139         Stop building LayoutTestRelay for now. It's a Mac project, but build-webkit tries to
140         use iOS SDK, like with all the others.
141
142         * Scripts/build-webkit:
143
144 2015-10-01  Daniel Bates  <dabates@apple.com>
145
146         Attempt to fix the iOS 9 Simulator testers
147
148         Add dependency DumpRenderTree.app to target All of project DumpRenderTree so that we
149         build DumpRenderTree.app, if applicable. Also, teach build-webkit to build project
150         LayoutTestRelay when building for iOS Simulator.
151
152         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
153         * Scripts/build-webkit:
154
155 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
156
157         [GTK] Websites with invalid auth header keep loading forever
158         https://bugs.webkit.org/show_bug.cgi?id=149710
159
160         Reviewed by Martin Robinson.
161
162         Add test case to check that we can authenticate sites with an
163         empty realm.
164
165         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
166         (testWebViewAuthenticationEmptyRealm):
167         (serverCallback):
168         (beforeAll):
169
170 2015-10-01  Alexey Proskuryakov  <ap@apple.com>
171
172         [Mac] Make run-api-tests work with System Integrity Protection
173         https://bugs.webkit.org/show_bug.cgi?id=149711
174         rdar://problem/22928202
175
176         Reviewed by Dan Bernstein.
177
178         * Scripts/run-api-tests:
179         (runTest):
180         (archCommandLineArgumentsForRestrictedEnvironmentVariables):
181
182 2015-10-01  Daniel Bates  <dabates@apple.com>
183
184         Attempt to fix the Windows build after <https://trac.webkit.org/changeset/190387>
185         (https://bugs.webkit.org/show_bug.cgi?id=149695)
186
187         For some reason built-product-archive hardcodes the assumption that we build for 32-bit Windows.
188         For now, use the path to the top-level WebKit build directory instead of using the configuration-
189         specific build directory.
190
191         * BuildSlaveSupport/built-product-archive:
192         (archiveBuiltProduct):
193
194 2015-10-01  Csaba Osztrogonác  <ossy@webkit.org>
195
196         [EFL] Fix the openwebrtc and gst-plugins-openwebrtc build with clang
197         https://bugs.webkit.org/show_bug.cgi?id=145837
198
199         Reviewed by Philippe Normand.
200
201         * efl/jhbuild.modules:
202         * efl/patches/openwebrtc-clang-warning-fix.patch: Added.
203         * efl/patches/openwebrtc-gst-plugins-clang-warning-fix.patch: Added.
204
205 2015-10-01  Wenson Hsieh  <wenson_hsieh@apple.com>
206
207         Unreviewed. Fix the iOS build after r190407.
208
209         * WebKitTestRunner/ios/IOKitSPI.h:
210
211 2015-10-01  Wenson Hsieh  <wenson_hsieh@apple.com>
212
213         Implement keyboard event sending for iOS in WebKitTestRunner
214         https://bugs.webkit.org/show_bug.cgi?id=149676
215
216         Reviewed by Simon Fraser.
217
218         Adds support for generating and sending key events in WebKitTestRunner. This is accomplished in a similar
219         way as touch events, using IOHIDEvent machinery. Also adds callbacks to the UIScriptController JS API that
220         allows us to run code when the keyboard is shown or hidden.
221
222         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Adds the typeCharacter JS interface.
223         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
224         (WTR::UIScriptController::setDidShowKeyboardCallback):
225         (WTR::UIScriptController::didShowKeyboardCallback):
226         (WTR::UIScriptController::setDidHideKeyboardCallback):
227         (WTR::UIScriptController::didHideKeyboardCallback):
228         (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
229         (WTR::UIScriptController::platformSetDidShowKeyboardCallback):
230         (WTR::UIScriptController::platformSetDidHideKeyboardCallback):
231         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
232         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
233         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
234         (-[TestRunnerWKWebView initWithFrame:configuration:]): Registers the TestRunnerWKWebView to listen to
235                 the notifications that the keyboard has been raised or lowered.
236         (-[TestRunnerWKWebView _keyboardDidShow:]):
237         (-[TestRunnerWKWebView _keyboardDidHide:]):
238         * WebKitTestRunner/ios/HIDEventGenerator.h:
239         * WebKitTestRunner/ios/HIDEventGenerator.m:
240         (-[HIDEventGenerator _sendIOHIDKeyboardEvent:usage:isKeyDown:]): Helper to send a HID keyboard event.
241         (shouldWrapWithShiftKeyEventForCharacter): Helper used to generate key events.
242         (hidUsageCodeForCharacter): Ditto.
243         (-[HIDEventGenerator keyDown:completionBlock:]): Synthesizes and sends HIDKeyboardEvents, triggering
244                 a keyDown event in WebKit.
245         * WebKitTestRunner/ios/IOKitSPI.h:
246         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
247
248 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
249
250         Unreviewed, rolling out r190399.
251
252         Tests are still failing even after r190362
253
254         Reverted changeset:
255
256         "Unreviewed. Unskip GTK+ user media unit tests after r190362."
257         http://trac.webkit.org/changeset/190399
258
259 2015-10-01  Csaba Osztrogonác  <ossy@webkit.org>
260
261         [jhbuild] switch to new upstream usrsctp library
262         https://bugs.webkit.org/show_bug.cgi?id=149494
263
264         Reviewed by Philippe Normand.
265
266         * efl/jhbuild.modules:
267         * gtk/jhbuild.modules:
268
269 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
270
271         Unreviewed. Unskip GTK+ user media unit tests after r190362.
272
273         They should pass now.
274
275         * Scripts/run-gtk-tests:
276         (TestRunner):
277
278 2015-09-30  Daniel Bates  <dabates@apple.com>
279
280         Another attempt to fix the build after <https://trac.webkit.org/changeset/190387>
281         (https://bugs.webkit.org/show_bug.cgi?id=149695)
282
283         * BuildSlaveSupport/built-product-archive:
284         (determineWebKitBuildDirectories): Substitute _configurationBuildDirectory for _buildDirectory.
285         (extractBuiltProduct): Substitute _topLevelBuildDirectory for _buildDirectory.
286
287 2015-09-30  Daniel Bates  <dabates@apple.com>
288
289         Attempt to fix the build after <https://trac.webkit.org/changeset/190387>
290         (https://bugs.webkit.org/show_bug.cgi?id=149695)
291
292         Actually, we need to pass --configuration to script webkit-build-directory to have
293         it return the path to the configuration-specific build directory.
294
295         * BuildSlaveSupport/built-product-archive:
296         (determineWebKitBuildDirectories):
297
298 2015-09-30  Daniel Bates  <dabates@apple.com>
299
300         built-product-archive archives incorrect build directory for iOS port
301         https://bugs.webkit.org/show_bug.cgi?id=149695
302
303         Reviewed by Darin Adler.
304
305         Fixes an issue where the script built-product-archive archives a non-existent
306         build directory for the iOS port. Without loss of generality, the script assumes
307         the path to the Release configuration build for iOS is in directory WebKitBuild/Release.
308         But the built products for this configuration are in directory WebKitBuild/Release-iphonesimulator.
309
310         Currently the script built-product-archive calls `webkit-build-directory --top-level ...`
311         to determine the top-level build directory and computes the configuration-specific
312         build directory to be the concatenation of the the top-level build directory and
313         the configuration (e.g. Release). This is incorrect. Instead we should call
314         webkit-build-directory omitting the flag --top-level to compute the path to the
315         configuration-specific build directory.
316
317         * BuildSlaveSupport/built-product-archive: Fix up the style such that we use single quoted literals.
318         (main): Renamed global variable _buildDirectory to _topLevelBuildDirectory to better describe
319         its purpose and added global variable _configurationBuildDirectory to store the path
320         to the configuration-specific build directory. Ensure that we have a non-empty string
321         for both the top-level and configuration-specific build directories.
322         (determineWebKitBuildDirectories): Formerly named determineWebKitBuildDirectory.
323         Compute the configuration-specific build directory and store it in the global variable
324         _configurationBuildDirectory.
325         (archiveBuiltProduct): Modified to use _configurationBuildDirectory.
326         (extractBuiltProduct): Modified to use _configurationBuildDirectory and _topLevelBuildDirectory
327         as needed.
328         (determineWebKitBuildDirectory): Deleted.
329
330 2015-09-30  Hunseop Jeong  <hs85.jeong@samsung.com>
331
332         [EFL] css3/device-adapt/* tests failed after r190335.
333         https://bugs.webkit.org/show_bug.cgi?id=149655
334
335         Reviewed by Simon Fraser.
336
337         device-adapt/* tests need the fixedLayout option but useFixedLayout option is
338         overwritten by updatePlatformSpecificViewOptionsForTest after r190335.
339
340         * WebKitTestRunner/efl/TestControllerEfl.cpp:
341         (WTR::shouldUseFixedLayout):
342
343 2015-09-30  Dewei Zhu  <dewei_zhu@apple.com>
344
345         Extend JetStream timeout for slow devices.
346
347         Reviewed by Chris Dumez.
348
349         Extend JetStream timeout to 20 minutes.
350
351         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
352
353 2015-09-30  Daniel Bates  <dabates@apple.com>
354
355         Rename iOS builders/testers to include version
356         https://bugs.webkit.org/show_bug.cgi?id=149685
357
358         Reviewed by Simon Fraser.
359
360         Substitute "Apple iOS 9" for "Apple iOS" in the names of iOS builders/testers so as
361         make it clear to a reader the version of iOS these builders/testers are using.
362
363         * BuildSlaveSupport/build.webkit.org-config/config.json:
364         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
365
366 2015-09-30  Daniel Bates  <dabates@apple.com>
367
368         Add iOS criterion for triggering a build
369         https://bugs.webkit.org/show_bug.cgi?id=149679
370
371         Rubber-stamped by Alexey Proskuryakov.
372
373         First pass at defining criterion for triggering an iOS build.
374
375         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
376         (_should_file_trigger_build):
377         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
378         (ShouldBuildTest):
379         (ShouldBuildTest.test_should_build):
380
381 2015-09-29  Simon Fraser  <simon.fraser@apple.com>
382
383         [iOS] Allow tests to generate user gestures for UI testing
384         https://bugs.webkit.org/show_bug.cgi?id=149653
385
386         Reviewed by Tim Horton.
387
388         Expose functionality in UIScriptController to allow for testing single- and double-tap,
389         and to listen for completion of scrolling and zooming in the WKWebView.
390         
391         Tap generation is done using synthetic IOHIDEvents, via a new HIDEventGenerator class
392         which hides the complexity of creating these events. Event dispatch is asynchronous.
393         We detect when the last event has been handled by dispatching a vendor-specific event,
394         which is detected via -_handleHIDEvent: in our UIApplication subclass.
395         
396         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Link with IOKit.
397         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Two new properties
398         for 'will begin zooming' and 'did end zooming' callbacks, and functions to dispatch
399         single and double taps.
400         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
401         (UIScriptContext::registerCallback): Used to store the callbacks for zooming.
402         Unlike the "task" callbacks, these are persistent, but we store them in the same hash map.
403         (UIScriptContext::unregisterCallback):
404         (UIScriptContext::callbackWithID):
405         (UIScriptContext::fireCallback):
406         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
407         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
408         (WTR::UIScriptController::setWillBeginZoomingCallback): Cross-platform code.
409         (WTR::UIScriptController::willBeginZoomingCallback): Ditto.
410         (WTR::UIScriptController::setDidEndZoomingCallback):
411         (WTR::UIScriptController::didEndZoomingCallback):
412         (WTR::UIScriptController::singleTapAtPoint): Non-iOS stub.
413         (WTR::UIScriptController::doubleTapAtPoint): Ditto.
414         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
415         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
416         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
417         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
418         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Properties for the zooming callbacks.
419         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
420         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]): Dispatch the zooming callback.
421         (-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]): Ditto.
422         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]): Ditto.
423         (-[TestRunnerWKWebView onDidEndZooming:]): Deleted.
424         * WebKitTestRunner/ios/HIDEventGenerator.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
425         * WebKitTestRunner/ios/HIDEventGenerator.m: Added.
426         (simpleDragCurve):
427         (calculateNextLocation):
428         (delayBetweenMove):
429         (+[HIDEventGenerator sharedHIDEventGenerator]):
430         (+[HIDEventGenerator nextEventCallbackID]):
431         (-[HIDEventGenerator init]):
432         (-[HIDEventGenerator _createIOHIDEventType:]):
433         (-[HIDEventGenerator _sendHIDEvent:]):
434         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
435         (-[HIDEventGenerator _updateTouchPoints:count:]):
436         (-[HIDEventGenerator touchDownAtPoints:touchCount:]):
437         (-[HIDEventGenerator touchDown:touchCount:]):
438         (-[HIDEventGenerator touchDown:]):
439         (-[HIDEventGenerator liftUpAtPoints:touchCount:]):
440         (-[HIDEventGenerator liftUp:touchCount:]):
441         (-[HIDEventGenerator liftUp:]):
442         (-[HIDEventGenerator moveToPoints:touchCount:duration:]):
443         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
444         (-[HIDEventGenerator tap:completionBlock:]):
445         (-[HIDEventGenerator doubleTap:completionBlock:]):
446         (-[HIDEventGenerator twoFingerTap:completionBlock:]):
447         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
448         (-[HIDEventGenerator pinchCloseWithStartPoint:endPoint:duration:completionBlock:]):
449         (-[HIDEventGenerator pinchOpenWithStartPoint:endPoint:duration:completionBlock:]):
450         (-[HIDEventGenerator markerEventReceived:]):
451         * WebKitTestRunner/ios/IOKitSPI.h: Added.
452         * WebKitTestRunner/ios/UIKitSPI.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
453         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
454         (WTR::globalToContentCoordinates):
455         (WTR::UIScriptController::singleTapAtPoint):
456         (WTR::UIScriptController::doubleTapAtPoint):
457         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
458         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
459         * WebKitTestRunner/ios/mainIOS.mm:
460         (-[WebKitTestRunnerApp _handleHIDEvent:]):
461
462 2015-09-30  Dana Burkart  <dburkart@apple.com>
463
464         git-add-reviewer should trim trailing spaces/newlines
465         https://bugs.webkit.org/show_bug.cgi?id=149513
466
467         Reviewed by Darin Adler.
468
469         * Scripts/git-add-reviewer:
470         (nonInteractive):
471
472 2015-09-30  Eric Carlson  <eric.carlson@apple.com>
473
474         REGRESSION(r190262): User media unit test failures after r190262
475         https://bugs.webkit.org/show_bug.cgi?id=149580
476
477         Reviewed by Darin Adler.
478
479         * WebKitTestRunner/TestController.cpp:
480         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Fix parameter
481           order to WKUserMediaPermissionRequestAllow.
482
483 2015-09-30  Daniel Bates  <dabates@apple.com>
484
485         Add iOS builders and testers
486         https://bugs.webkit.org/show_bug.cgi?id=149549
487
488         Reviewed by Alexey Proskuryakov.
489
490         Adds definitions for 64-bit iOS Simulator release builders and testers and a iOS device
491         builder that builds universal release binaries for armv7, armv7s and arm64 architectures.
492
493         * BuildSlaveSupport/build.webkit.org-config/config.json: Add definitions for builders and testers.
494         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Update unit tests.
495
496 2015-09-30  Timothy Hatcher  <timothy@apple.com>
497
498         Give WebKitLauncher the get-task-allow entitlement to allow it to work on El Capitan
499         https://bugs.webkit.org/show_bug.cgi?id=149674
500
501         Reviewed by Lucas Forschler.
502
503         * WebKitLauncher/WebKitLauncher.entitlements: Added.
504         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
505
506 2015-09-30  Jason Marcell  <jmarcell@apple.com>
507
508         BuildbotQueueView.prototype._appendPendingRevisionCount should skip repositories that don't
509         have an associated trac instance.
510         https://bugs.webkit.org/show_bug.cgi?id=149673
511
512         Reviewed by Alexey Proskuryakov.
513
514         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
515         (BuildbotQueueView.prototype._appendPendingRevisionCount): Skip repositories that don't
516         have an associated trac instance.
517
518 2015-09-30  Daniel Bates  <dabates@apple.com>
519
520         Prioritize testing latest build request on iOS test bots
521         https://bugs.webkit.org/show_bug.cgi?id=149669
522
523         Reviewed by Darin Adler.
524
525         We should prioritize testing of the latest build request on the iOS test bots
526         as we do for Mac and Windows test bots.
527
528         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
529         (loadBuilderConfig):
530
531 2015-09-30  Daniel Bates  <dabates@apple.com>
532
533         Add buildbot category for iOS builders and testers
534         https://bugs.webkit.org/show_bug.cgi?id=149667
535
536         Reviewed by Darin Adler.
537
538         Group iOS builders and testers under category iOS and add dashboard and console hyperlinks
539         for iOS to the build.webkit.org home page.
540
541         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
542         (loadBuilderConfig):
543         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
544
545 2015-09-30  Daniel Bates  <dabates@apple.com>
546
547         Actually fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
548         (https://bugs.webkit.org/show_bug.cgi?id=149539)
549
550         I inadvertently didn't remove the ONLY_ACTIVE_ARCH=NO flag when building on a Mac
551         in <http://trac.webkit.org/changeset/190351>.
552
553         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
554         (CompileWebKit.start):
555
556 2015-09-30  Daniel Bates  <dabates@apple.com>
557
558         Attempt to fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
559         (https://bugs.webkit.org/show_bug.cgi?id=149539)
560
561         {32, 64}-bit Mac builders should not try to build project {Plugin.64, Plugin.32},
562         respectively; only pass ONLY_ACTIVE_ARCH=NO when building for iOS.
563
564         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
565         (CompileWebKit.start):
566
567 2015-09-30  Lucas Forschler  <lforschler@apple.com>
568
569         bot210 was configured for a queue instead of bot126.
570         
571         Unreviewed config.json fix.
572         
573         * BuildSlaveSupport/build.webkit.org-config/config.json:
574
575 2015-09-30  Lucas Forschler  <lforschler@apple.com>
576
577         Bring El Capitan buildbot infrastructure online.
578         https://bugs.webkit.org/show_bug.cgi?id=149605
579         
580         Reviewed by Darin Adler.
581
582         * BuildSlaveSupport/build.webkit.org-config/config.json:
583
584 2015-09-30  Tomas Popela  <tpopela@redhat.com>
585
586         [GTK] Deprecation warnings in DOMNodeTest
587         https://bugs.webkit.org/show_bug.cgi?id=149663
588
589         After the webkit_dom_document_get_elements_by_tag_name deprecation we
590         need to update the tests to use webkit_dom_document_query_selector_all
591         to avoid compilation warnings.
592
593         Also add a new test for webkit_dom_document_get_elements_by_tag_name_as_html_collection
594         (the suggested replacement for the deprecated function).
595
596         Reviewed by Carlos Garcia Campos.
597
598         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
599         (WebKitDOMNodeTest::testTagNamesNodeList):
600         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
601         (registerTests):
602         (WebKitDOMNodeTest::testTagNames): Deleted.
603         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
604         (prepareDOMForTagNamesTests):
605         (testWebKitDOMNodeTagNamesNodeList):
606         (testWebKitDOMNodeTagNamesHTMLCollection):
607         (beforeAll):
608         (testWebKitDOMNodeTagNames): Deleted.
609
610 2015-09-29  Simon Fraser  <simon.fraser@apple.com>
611
612         WebKitTestRunner fails to apply "useFlexibleViewport" when it's specified in a file comment
613         https://bugs.webkit.org/show_bug.cgi?id=149650
614
615         Reviewed by Tim Horton.
616         
617         TestInvocation::invoke() consulted shouldMakeViewportFlexible(), but that only
618         looks at the file path, and not the custom options that come from file comments.
619         
620         Fix by computing TestOptions before making the TestInvocation, and setting them
621         as const TestInvocation data. This meant changing various call sites to take
622         the std::string pathOrURL, rather than the TestInvocation itself.
623         
624         Also initialize TestInvocation with a WKURLRef, rather than a std::string.
625
626         * WebKitTestRunner/CMakeLists.txt:
627         * WebKitTestRunner/TestController.cpp:
628         (WTR::TestController::ensureViewSupportsOptionsForTest):
629         (WTR::testPath):
630         (WTR::createTestURL):
631         (WTR::updateTestOptionsFromTestHeader):
632         (WTR::TestController::testOptionsForTest):
633         (WTR::TestController::updateWebViewSizeForTest):
634         (WTR::TestController::updateWindowScaleForTest):
635         (WTR::TestController::runTest):
636         * WebKitTestRunner/TestController.h:
637         * WebKitTestRunner/TestInvocation.cpp:
638         (WTR::TestInvocation::TestInvocation):
639         (WTR::TestInvocation::invoke):
640         (WTR::createWKURL): Deleted.
641         (WTR::TestInvocation::shouldMakeViewportFlexible): Deleted.
642         (WTR::TestInvocation::shouldUseFixedLayout): Deleted.
643         * WebKitTestRunner/TestInvocation.h:
644         (WTR::TestInvocation::options):
645         * WebKitTestRunner/TestOptions.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
646         (WTR::pathContains):
647         (WTR::shouldMakeViewportFlexible):
648         (WTR::shouldUseFixedLayout):
649         (WTR::isSVGTestPath):
650         (WTR::isHiDPITestPath):
651         (WTR::TestOptions::TestOptions):
652         * WebKitTestRunner/TestOptions.h:
653         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
654         * WebKitTestRunner/efl/TestControllerEfl.cpp:
655         (WTR::pathContains):
656         (WTR::shouldUseFixedLayout):
657         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
658         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
659         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
660         * WebKitTestRunner/ios/TestControllerIOS.mm:
661         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
662         * WebKitTestRunner/mac/TestControllerMac.mm:
663         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
664
665 2015-09-29  Aakash Jain  <aakash_jain@apple.com>
666
667         Flakiness dashboard should support OS X El Capitan
668         https://bugs.webkit.org/show_bug.cgi?id=149648
669
670         Reviewed by Alexey Proskuryakov.
671
672         * QueueStatusServer/app.yaml: We do not need to maintain SVN revision here because of 
673         difference between new appscale and old Google App Engine implementation.
674         * TestResultServer/app.yaml: Same.
675         * TestResultServer/static-dashboards/builders.jsonp: Added OSX El Capitan support.
676
677 2015-09-29  Daniel Bates  <dabates@apple.com>
678
679         configure-xcode-for-ios-development does not work with Xcode 7
680         https://bugs.webkit.org/show_bug.cgi?id=149640
681
682         Reviewed by Alexey Proskuryakov.
683
684         When Xcode 7 is installed, running configure-xcode-for-ios-development dies with an error
685         because it cannot find the Xcode specification files for iOS simulator and device. These
686         files have moved to a new location in Xcode 7 distribution. Moreover we must add the
687         relevant definitions to the Xcode 7 specification files directly as opposed to creating
688         new specification files with the added definitions (as we did in older versions of Xcode)
689         in order for Xcode 7 to honor these definitions.
690
691         * Scripts/configure-xcode-for-ios-development: Sorted forward declarations.
692         (updateXcodeSpecificationFilesForSDKIfNeeded): Added.
693         (updateXcode7SpecificationFile): Added.
694         (createLegacyXcodeSpecificationFilesForSDKIfNeeded): Formerly named createXcodeSpecificationFilesForSDKIfNeeded.
695         (writeXcodeSpecification): Moved congratulations line to caller so as to write out the
696         appropriate success message.
697         (mergeXcodeSpecificationWithSpecificationAndId): Formerly named createXcodeSpecificationFromSpecificationAndId.
698         (createXcodeSpecificationFilesForSDKIfNeeded): Deleted.
699         (createXcodeSpecificationFromSpecificationAndId): Deleted.
700
701 2015-09-29  Brent Fulgham  <bfulgham@apple.com>
702
703         [Win] Allow 'prepare-ChangeLog' to be used without Cygwin
704         https://bugs.webkit.org/show_bug.cgi?id=149639
705
706         Reviewed by Alex Christensen.
707
708         * Scripts/VCSUtils.pm:
709         (exitStatus): Use 'isWindows()' method.
710         (isSVNVersion16OrNewer): 'eval' is not needed here, and just causes
711         an error. This method could probably just go away.
712         (normalizePath): Leave Windows (or Unix) paths as platform paths, rather than
713         always changing to Unix style. 
714         (unixPath): Added. Needed so Windows can always show a Unix path in the
715         ChangeLog file.
716         (changeLogName): Work around the fact that 'getpwuid' is not available on
717         a pure Windows build of Perl.
718         * Scripts/prepare-ChangeLog:
719         (generateFunctionLists): Normalize path received from 'svn' in case it's a Unix
720         path on Windows.
721         (svnUpdateCommand): Added helper function. Needed because Windows Perl does not
722         support using arrays for 'open' arguments.
723         (resolveChangeLogsPath): Ditto.
724         (resolveConflictedChangeLogs): Use new helper functions.
725         (generateNewChangeLogs): Force Windows to use Unix paths in ChangeLog output.
726         (diffCommand): Use double-quotes for paths, since Windows doesn't understand single
727         quotes. Unix systems are happy either way.
728         (statusCommand): Ditto.
729         * Scripts/webkitdirs.pm:
730         (launcherName): Drive-by fix. WinLauncher was renamed to MiniBrowser some time ago.
731
732 2015-09-29  Brent Fulgham  <bfulgham@apple.com>
733
734         [Win] Unreviewed 64-bit build fix after switch to CMake.
735
736         * Scripts/webkitdirs.pm:
737         (determineIsWin64FromArchitecture): Added.
738
739 2015-09-16  Carlos Garcia Campos  <cgarcia@igalia.com>
740
741         printing does not use minimum page zoom factor
742         https://bugs.webkit.org/show_bug.cgi?id=108507
743
744         Reviewed by Darin Adler.
745
746         WebKitTestRunner always takes the snapshots from the UI process
747         (expect for IOS), so in the case of printing, the layout in the
748         web view is not the expected one. When printing, we need to take
749         the snapshot in the web process and ensure it's rendered with a
750         PrintContext.
751
752         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
753         (WTR::InjectedBundlePage::dump): When dumping pixels, pass
754         kWKSnapshotOptionsPrinting option to
755         WKBundlePageCreateSnapshotWithOptions() when printing.
756
757 2015-09-28  Carlos Garcia Campos  <cgarcia@igalia.com>
758
759         [WTR] Pixel tests generate the snapshots twice in Web and UI processes
760         https://bugs.webkit.org/show_bug.cgi?id=149595
761
762         Reviewed by Tim Horton.
763
764         All ports except IOS implement
765         PlatformWebView::windowSnapshotImage() to generate the snapshot
766         for the pixel tests in the UI process. But we are still generating
767         a snapshot for pixel tests in the Web process too, that is passed
768         to the UI process but ignored.
769         Whether a pixel result is needed or not, is only known by the web
770         process depending on whether the test called dumpAsText with
771         dumpPixels == true or not. Since the pixels are now dump in the UI
772         process, we need to pass that information to the UI process when
773         the test is done. For that we set a PixelResultIsPending bool
774         parameter to the Done message, and we only add the PixelResult
775         when UI process doesn't need to generate the pixels dump.
776
777         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
778         (WTR::InjectedBundle::didReceiveMessageToPage): Set
779         m_pixelResultIsPending to false on reset.
780         (WTR::InjectedBundle::done): Add PixelResultIsPending parameter to the
781         Done message, and set the PixelResult if m_pixelResultIsPending is false.
782         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
783         (WTR::InjectedBundle::setPixelResult): Set m_pixelResultIsPending to false.
784         (WTR::InjectedBundle::setNeedsPixelResult): Set m_pixelResultIsPending.
785         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
786         (WTR::InjectedBundlePage::dump): Only create a snapshot for IOS
787         port.
788         * WebKitTestRunner/TestInvocation.cpp:
789         (WTR::TestInvocation::dumpResults): Use either the pixel result
790         from the web process or generate a pixel result from the web view
791         if need it.
792         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
793         * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum
794         parameter to dumpPixelsAndCompareWithExpected, since the snapshot
795         is created by the caller now, but the CG implementation needs to
796         know if it's a Web or UI process snapshot.
797         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
798         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
799         cairo surface for the given image.
800         * WebKitTestRunner/cg/TestInvocationCG.cpp:
801         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
802         CGContext for the given image.
803
804 2015-09-28  Dean Johnson  <dean_johnson@apple.com>
805
806         Fix JS errors on dashboard metrics page
807         https://bugs.webkit.org/show_bug.cgi?id=149608
808
809         Reviewed by Alexey Proskuryakov.
810
811         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Updated to use Settings.
812         (initPlatformsByFamily): 
813         (updateHiddenPlatforms):
814         (parsePlatformFamily): Deleted.
815         (updateToggleButtons): Deleted.
816         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
817         (updateHiddenPlatforms): Added to remove errors.
818         (initPlatformsByFamily): Added to remove errors.
819         (unhiddenQueues): Updated to use Settings.
820         (documentReady): Added logic to add toggle buttons to the settings menu.
821         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
822         (Settings.prototype.parsePlatformFamily): Moved duplicate logic from Main.js and
823         MetricsMain.js to Settings.
824         (Settings.prototype.updateToggleButtons): Moved duplicate logic from Main.js and
825         MetricsMain.js to Settings.
826         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
827         (QueueView.prototype._updateHiddenState): Updated to use Settings.
828
829 2015-09-28  Aakash Jain  <aakash_jain@apple.com>
830
831         Appscale query fails because of missing index
832         https://bugs.webkit.org/show_bug.cgi?id=149609
833
834         Reviewed by Darin Adler.
835
836         * QueueStatusServer/index.yaml: Added the required index.
837
838 2015-09-28  Brent Fulgham  <bfulgham@apple.com>
839
840         [Win] Fix the 64-bit build after switch to cmake.
841
842         Reviewed by Alex Christensen.
843
844         * Scripts/webkitdirs.pm:
845         (generateBuildSystemFromCMakeProject): Use correct arguments for cmake to
846         run a 64-bit build.
847
848 2015-09-28  Brent Fulgham  <bfulgham@apple.com>
849
850         [Win] Allow Windows to run test-webkitpy without Cygwin
851         https://bugs.webkit.org/show_bug.cgi?id=149602
852
853         Reviewed by Alex Christensen.
854
855         These changes mostly shift from hard-coded paths using UNIX-style
856         separators to Python's "os.path.join" syntax that uses the correct
857         path separator for each platform.
858         
859         * Scripts/webkitpy/common/system/path.py:
860         (cygpath): Don't pass paths through Cygpath on native Windows.
861         * Scripts/webkitpy/port/win.py:
862         (WinPort._path_to_apache): Use os.path.join.
863         (WinPort._ntsd_location): Support 64-bit environment (ProgramW6432 doesn't exist
864         in 64-bit environments).
865         * Scripts/webkitpy/style/checker.py: Use os.path.join.
866         * Scripts/webkitpy/style/checker_unittest.py:
867         (GlobalVariablesTest.test_path_rules_specifier.assertNoCheck): Use os.path.join.
868         (GlobalVariablesTest.test_path_rules_specifier): Ditto.
869         (GlobalVariablesTest): Ditto.
870         (GlobalVariablesTest.test_max_reports_per_category): Ditto.
871         (CheckerDispatcherSkipTest.test_should_skip_with_warning): Ditto.
872         (CheckerDispatcherDispatchTest.test_js_paths): Ditto.
873         (CheckerDispatcherDispatchTest.test_json_paths): Ditto.
874         (CheckerDispatcherDispatchTest.test_python_paths): Ditto.
875         (CheckerDispatcherDispatchTest.test_text_paths): Ditto.
876         (CheckerDispatcherDispatchTest.test_xml_paths): Ditto.
877         (StyleProcessor_CodeCoverageTest._create_carriage_checker_class): Ditto.
878         (StyleProcessor_CodeCoverageTest): Ditto.
879         (StyleProcessor_CodeCoverageTest.test_should_process__skip_without_warning): Ditto.
880         (StyleProcessor_CodeCoverageTest.test_should_process__skip_with_warning): Ditto.
881         (StyleProcessor_CodeCoverageTest.test_should_process__true_result): Ditto.
882         * Scripts/webkitpy/w3c/test_parser_unittest.py: Uses os.path.join rather than
883         manual string concatenation of paths.
884
885 2015-09-28  Csaba Osztrogonác  <ossy@webkit.org>
886
887         Add bugzilla addresses of committers to contributors.json
888         https://bugs.webkit.org/show_bug.cgi?id=149520
889
890         Reviewed by Darin Adler.
891
892         * Scripts/webkitpy/common/config/contributors.json:
893
894 2015-09-28  Csaba Osztrogonác  <ossy@webkit.org>
895
896         validate-committer-lists -b shouldn't need edituser privileges
897         https://bugs.webkit.org/show_bug.cgi?id=149519
898
899         Reviewed by Darin Adler.
900
901         * Scripts/validate-committer-lists:
902         (CommitterListBugzillaChecker._has_invalid_bugzilla_email):
903         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
904         (BugzillaQueries.is_invalid_bugzilla_email):
905         (BugzillaQueries): Deleted.
906         (BugzillaQueries.fetch_logins_matching_substring): Deleted.
907
908 2015-09-26  Carlos Garcia Campos  <cgarcia@igalia.com>
909
910         Unreviewed. Gardening: skip media stream tests failing after r190262.
911
912         * Scripts/run-gtk-tests:
913         (TestRunner):
914
915 2015-09-25  Alexey Proskuryakov  <ap@apple.com>
916
917         [Mac] USE_INTERNAL_SDK is used undefined in tools projects
918         https://bugs.webkit.org/show_bug.cgi?id=149571
919
920         Reviewed by Dan Bernstein.
921
922         Use the same pattern as in Source directory configurations (so, also get rid of AspenFamily.xcconfig). 
923
924         * DumpRenderTree/mac/Configurations/Base.xcconfig:
925         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
926         * LayoutTestRelay/Configurations/Base.xcconfig:
927         * MiniBrowser/Configurations/Base.xcconfig:
928         * MiniBrowser/Configurations/DebugRelease.xcconfig:
929         * TestWebKitAPI/Configurations/Base.xcconfig:
930         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
931         * WebEditingTester/Configurations/Base.xcconfig:
932         * WebEditingTester/Configurations/DebugRelease.xcconfig:
933         * WebKitTestRunner/Configurations/Base.xcconfig:
934         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
935         * WebKitTestRunner/iOS.xcconfig: Removed.
936
937 2015-09-25  Eric Carlson  <eric.carlson@apple.com>
938
939         Clean up user media request internal API
940         https://bugs.webkit.org/show_bug.cgi?id=149527
941
942         Reviewed by Tim Horton.
943
944         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
945         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): Update for API changes.
946
947         * WebKitTestRunner/TestController.cpp:
948         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Ditto.
949
950 2015-09-25  Simon Fraser  <simon.fraser@apple.com>
951
952         [iOS WK2] Add viewport tests and fix runUIScript() timing issues
953         https://bugs.webkit.org/show_bug.cgi?id=149577
954
955         Reviewed by Tim Horton.
956         
957         When calling testRunner.runUIScript() from a page load event, the script could run
958         in the UI process before the current remote layer tree transaction had been handled
959         there. This meant that runUIScript() could query state which was about to change.
960         
961         Fix by delaying the execution of the UI script until a layer tree transaction has
962         been handled by the UI process, leveraging the existing DrawingAreaProxy::dispatchAfterEnsuringDrawing().
963
964         * WebKitTestRunner/TestInvocation.cpp:
965         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
966         (WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
967         * WebKitTestRunner/TestInvocation.h:
968
969 2015-09-25  Alexey Proskuryakov  <ap@apple.com>
970
971         [Mac] Media tests start to time out after a few days of bot uptime
972         https://bugs.webkit.org/show_bug.cgi?id=149468
973
974         Reviewed by Darin Adler.
975
976         Delete cache directory in addition to the temporary one. Don't delete /private/tmp/MediaCache,
977         as it's not longer used by tests. Set TMPDIR and DIRHELPER_USER_DIR_SUFFIX to make
978         all temporary and cache files go to a custom location.
979
980         * Scripts/webkitpy/port/base.py:
981         * Scripts/webkitpy/port/driver.py:
982         * Scripts/webkitpy/port/mac.py:
983         * Scripts/webkitpy/port/win.py:
984         (WinPort._driver_tempdir_for_environment): Deleted unused function.
985
986 2015-09-25  Dan Bernstein  <mitz@apple.com>
987
988         Removed MiniBrowser.entitlements.
989
990         Rubber-stamped by Anders Carlsson.
991
992         The entitlements weren’t used anyway.
993
994         * MiniBrowser/MiniBrowser.entitlements: Removed.
995         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
996
997 2015-09-24  Daniel Bates  <dabates@apple.com>
998
999         Add WebKitSystemInterface for iOS 9.0
1000         https://bugs.webkit.org/show_bug.cgi?id=149550
1001
1002         Rubber-stamped by Alexey Proskuryakov.
1003
1004         * Scripts/copy-webkitlibraries-to-product-directory:
1005
1006 2015-09-24  Daniel Bates  <dabates@apple.com>
1007
1008         Support building for arbitrary architectures
1009         https://bugs.webkit.org/show_bug.cgi?id=149539
1010
1011         Reviewed by Alexey Proskuryakov.
1012
1013         Teach buildbot to pass the architectures associated with the builder to build-webkit
1014         when building on OS X and iOS. As a side effect of this change we now support building
1015         universal binaries when multiples architectures are specified.
1016
1017         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1018         (CompileWebKit.start):
1019
1020 2015-09-24  Daniel Bates  <dabates@apple.com>
1021
1022         Fix the build after <http://trac.webkit.org/changeset/190212>
1023         (http://trac.webkit.org/changeset/190212)
1024
1025         I inadvertently did not remove the fullPlatform argument from one of the callers of archiveBuiltProduct().
1026
1027         * BuildSlaveSupport/built-product-archive:
1028         (main):
1029
1030 2015-09-24  Daniel Bates  <dabates@apple.com>
1031
1032         Support running unit tests on iOS Simulator test bot
1033         https://bugs.webkit.org/show_bug.cgi?id=149536
1034
1035         Reviewed by Alexey Proskuryakov.
1036
1037         Implements support for running unit tests on a iOS test bot. At the time of writing,
1038         the script run-api-tests supports running unit tests on Mac, Windows and iOS Simulator.
1039
1040         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1041         (RunUnitTests.start): Append appropriate command line flag when invoking script run-api-tests.
1042         (TestFactory.__init__): Add step RunUnitTests when the test bot is for the iOS Simulator platform.
1043
1044 2015-09-24  Daniel Bates  <dabates@apple.com>
1045
1046         Add support infrastructure for OpenSource iOS builders and testers
1047         https://bugs.webkit.org/show_bug.cgi?id=149534
1048
1049         Reviewed by Darin Adler.
1050
1051         Towards setting up OpenSource iOS build bots, teach buildbot and its support
1052         scripts about iOS.
1053
1054         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1055         (appendCustomBuildFlags): Require the caller to pass parameter fullPlatform and append
1056         --ios-simulator or --device for a builder/tester whose full platform name begins with
1057         "ios-simulator" or "ios", respectively.
1058         (RunJavaScriptCoreTests.start): Pass the full platform name to appendCustomBuildFlags().
1059         * BuildSlaveSupport/built-product-archive:
1060         (main): Pass the full platform name to determineWebKitBuildDirectory().
1061         (determineWebKitBuildDirectory): Call script webkit-build-directory with the appropriate
1062         command line flag when building for iOS.
1063         (archiveBuiltProduct): Use the same logic for iOS as we do for Mac. Also, remove unused
1064         parameter fullPlatform. This parameter was originally added in r125066 to support the
1065         Chromium Android port, which has since been removed from the OpenSource WebKit Project.
1066         (extractBuiltProduct): Use the same logic for iOS as we do for Mac.
1067         * BuildSlaveSupport/clean-build:
1068         (main): Call script webkit-build-directory with the appropriate command line flag when
1069         building for iOS.
1070         * BuildSlaveSupport/delete-stale-build-files:
1071         (main): Use the same logic for iOS as we do for Mac.
1072         (webkitBuildDirectory): Call script webkit-build-directory with the appropriate command line
1073         flag when building for iOS.
1074         * BuildSlaveSupport/test-result-archive:
1075         (archiveTestResults): Use the same logic for iOS as we do for Mac.
1076
1077 2015-09-24  Daniel Bates  <dabates@apple.com>
1078
1079         Remove Chromium-specific changes to script built-product-archive
1080         https://bugs.webkit.org/show_bug.cgi?id=149530
1081
1082         Rubber-stamped by Csaba Osztrogonác.
1083
1084         Reverts changes made in r113074 and r113067 to support Chromium testers. The
1085         Chromium code has long since been removed from the OpenSource WebKit Project.
1086
1087         * BuildSlaveSupport/built-product-archive:
1088         (createZipManually):
1089         (createZip):
1090         (archiveBuiltProduct):
1091
1092 2015-09-24  Dan Bernstein  <mitz@apple.com>
1093
1094         Build fix.
1095
1096         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
1097
1098 2015-09-24  Mark Lam  <mark.lam@apple.com>
1099
1100         Unreviewed. Make Lucas Forschler a WebKit reviewer.
1101
1102         * Scripts/webkitpy/common/config/contributors.json:
1103
1104 2015-09-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1105
1106         Unreviewed. Fix GObject DOM API breaks after r190120.
1107
1108         Bring back code removed in r169931 to handle documentation of
1109         deleted classes.
1110
1111         * gtk/webkitdom.py:
1112         (WebKitDOMDocGenerator):
1113         (WebKitDOMDocGenerator.write_deleted_classes):
1114         (WebKitDOMDocGenerator.generate):
1115         (write_deleted_classes):
1116         (WebKitDOMDocGeneratorSections._deleted_class):
1117         (WebKitDOMDocGeneratorSections._deleted_class.in):
1118         (WebKitDOMDocGeneratorSections.write_deleted_classes):
1119         (WebKitDOMDocGeneratorSections.write_deleted_classes.with):
1120
1121 2015-09-23  Myles C. Maxfield  <mmaxfield@apple.com>
1122
1123         [Cocoa] [Font Features] Implement font-variant-*
1124         https://bugs.webkit.org/show_bug.cgi?id=148413
1125
1126         Reviewed by Darin Adler.
1127
1128         Update test font to use "lnum" feature.
1129
1130         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
1131         (Generator::appendGSUBTable):
1132
1133 2015-09-22  Andy Estes  <aestes@apple.com>
1134
1135         ContentFiltering.AllowDownloadAfterAddData is very flaky
1136         https://bugs.webkit.org/show_bug.cgi?id=148885
1137         <rdar://problem/22729563>
1138
1139         Reviewed by Alexey Proskuryakov.
1140
1141         The AllowDownload* tests were relying on -_downloadDidStart: being called before -webView:didFinishNavigation:,
1142         but there is no guarantee of this. For tests that should allow a download, spin the runloop until
1143         -_downloadDidStart: is called. The test will now timeout on failure, but will no longer produce false failures.
1144
1145         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
1146         (downloadTest):
1147
1148 2015-09-22  Alexey Proskuryakov  <ap@apple.com>
1149
1150         Mavericks: Media tests start to time out after a few days of bot uptime
1151         https://bugs.webkit.org/show_bug.cgi?id=149468
1152
1153         Reviewed by Chris Dumez.
1154
1155         * Scripts/webkitpy/port/base.py:
1156         * Scripts/webkitpy/port/driver.py:
1157         * Scripts/webkitpy/port/mac.py:
1158
1159 2015-09-22  Nan Wang  <n_wang@apple.com>
1160
1161         Unreviewed, add myself to the committers list.
1162
1163         * Scripts/webkitpy/common/config/contributors.json:
1164
1165 2015-09-21  Simon Fraser  <simon.fraser@apple.com>
1166
1167         Remove 'nullable' to fix older iOS builds.
1168
1169         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1170         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):
1171
1172 2015-09-21  Brent Fulgham  <bfulgham@apple.com>
1173
1174         [Win] Show tiled drawing debug overlay on Windows
1175         https://bugs.webkit.org/show_bug.cgi?id=149426
1176
1177         Reviewed by Dean Jackson.
1178
1179         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Add new menu option.
1180         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Ditto.
1181         * MiniBrowser/win/Common.cpp:
1182         (::ToggleMenuItem): Recognize new menu item and toggle the 'showTiledScrollingIndicator'
1183         flag if needed.
1184         * MiniBrowser/win/MiniBrowser.h: Update to use new IWebPreferencesPrivate3 class.
1185
1186 2015-09-21  Brent Fulgham  <bfulgham@apple.com>
1187
1188         [Win] Use command-line argument to launch in regular or High DPI mode.
1189         https://bugs.webkit.org/show_bug.cgi?id=149417
1190
1191         Reviewed by Dean Jackson.
1192
1193         * MiniBrowser/win/Common.cpp:
1194         (parseCommandLine): Ignore the '--highDPI' argument. It's used at the
1195         very start of execution, before the MiniBrowser.dll is loaded.
1196         * win/DLLLauncher/DLLLauncherMain.cpp:
1197         (shouldUseHighDPI): Check for '--highDPI', and use this mode if
1198         present. On WinCairo, always use High DPI.
1199
1200 2015-09-21  Ryosuke Niwa  <rniwa@webkit.org>
1201
1202         32-bit Mac build fix attempt after r190065.
1203
1204         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1205
1206 2015-09-21  Alexey Proskuryakov  <ap@apple.com>
1207
1208         [OS X] Update for Xcode 7.0 on Yosemite
1209         https://bugs.webkit.org/show_bug.cgi?id=149389
1210
1211         Reviewed by Dan Bernstein.
1212
1213         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
1214         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
1215         Removed unneeded declarations - conforming to a protocol is sufficient.
1216
1217         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1218         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
1219         Changed the definitions to be compiled whenever the SDK requires it (so we will have
1220         dead code compiled in when building for 10.10 with 10.11 SDK, somewhat unfortunately).
1221
1222 2015-09-21  Simon Fraser  <simon.fraser@apple.com>
1223
1224         Add the ability for tests to run script in the UI process in WebKitTestRunner
1225         https://bugs.webkit.org/show_bug.cgi?id=149356
1226
1227         Reviewed by Tim Horton.
1228
1229         This change adds testRunner.runUIScript(script, callback), which allows a test
1230         to execute script in a JSContext which runs in the UI process. That context
1231         has bindings exposed through the UIScriptController interface; currently one test
1232         function, and some iOS-specific functions are included. UIScriptController can be
1233         async with a callback, and runUIScript() itself is asynchronous. When the UI 
1234         script is complete, it calls uiController.uiScriptComplete(result), where 'result'
1235         is a string passed back to the web process, and given to the runUIScript()
1236         callback function.
1237         
1238         Thanks to Gyuyoung Kim for help with the Gtk/Efl build.
1239
1240         * WebKitTestRunner/DerivedSources.make: Build UIScriptController.idl.
1241         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Add runUIScript().
1242         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1243         (WTR::InjectedBundle::didReceiveMessageToPage): When the UI-side script is
1244         complete, call back into TestRunner.
1245         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1246         (WTR::nextUIScriptCallbackID):
1247         (WTR::TestRunner::runUIScript): Post a message to the injected bundle to run the UI script.
1248         (WTR::TestRunner::runUIScriptCallback): When the UI script is done, execute its callback function.
1249         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1250         * WebKitTestRunner/PlatformWebView.h:
1251         * WebKitTestRunner/TestController.cpp:
1252         (WTR::updateTestOptionsFromTestHeader):
1253         (WTR::TestController::testOptionsForTest): Support "useFlexibleViewport" as a test argument.
1254         (WTR::shouldUseFixedLayout): Deleted. Moved to a TestInvocation function.
1255         * WebKitTestRunner/TestInvocation.cpp:
1256         (WTR::TestInvocation::shouldUseFixedLayout):
1257         (WTR::TestInvocation::shouldUseThreadedScrolling):
1258         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1259         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1260         (WTR::TestInvocation::runUISideScript): Run the UI-side script!
1261         (WTR::TestInvocation::uiScriptDidComplete): Send a message back to the injected bundle.
1262         * WebKitTestRunner/TestInvocation.h:
1263         * WebKitTestRunner/TestOptions.h:
1264         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1265         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1266         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
1267         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: Added.
1268         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]):
1269         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]):
1270         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):
1271         (-[TestRunnerWKWebView onDidEndZooming:]): Allow a test to hook into the end of zooming.
1272         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1273         (WTR::PlatformWebView::PlatformWebView): Make a TestRunnerWKWebView on iOS.
1274         * WebKitTestRunner/ios/UIScriptControllerIOS.mm: Added.
1275         (WTR::UIScriptController::doAsyncTask):
1276         (WTR::UIScriptController::zoomToScale):
1277         (WTR::UIScriptController::zoomScale):
1278         (WTR::UIScriptController::minimumZoomScale):
1279         (WTR::UIScriptController::maximumZoomScale):
1280         (WTR::UIScriptController::contentVisibleRect):
1281         * WebKitTestRunner/mac/EventSenderProxy.mm:
1282         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1283         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]): Deleted.
1284         * WebKitTestRunner/mac/TestControllerMac.mm:
1285         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
1286         (WTR::shouldUseThreadedScrolling): Deleted. Moved to TestInvocation.
1287         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
1288         * WebKitTestRunner/uiscriptcontext/UIScriptContext.cpp: Added. Owns the JS context in the UI process.
1289         (UIScriptContext::UIScriptContext):
1290         (UIScriptContext::~UIScriptContext):
1291         (UIScriptContext::runUIScript): Entrypoint to running the UI script. If the script didn't do anything
1292         asynchronous, call the callback.
1293         (UIScriptContext::nextTaskCallbackID):
1294         (UIScriptContext::prepareForAsyncTask): Do setup for one async task (i.e. a UIScriptController function
1295         that has a callback). Has to store the callbackID of the script, so code called from the completion
1296         callback knows which UI script invoked it.
1297         (UIScriptContext::asyncTaskComplete): Called when one task is finished.
1298         (UIScriptContext::uiScriptComplete):
1299         (UIScriptContext::objectFromRect): Make a JS object from a rect.
1300         * WebKitTestRunner/uiscriptcontext/UIScriptContext.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
1301         (WTR::UIScriptContext::hasOutstandingAsyncTasks):
1302         * WebKitTestRunner/uiscriptcontext/UIScriptController.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
1303         (WTR::UIScriptController::UIScriptController):
1304         (WTR::UIScriptController::makeWindowObject):
1305         (WTR::UIScriptController::wrapperClass):
1306         (WTR::UIScriptController::doAsyncTask):
1307         (WTR::UIScriptController::zoomToScale):
1308         (WTR::UIScriptController::zoomScale):
1309         (WTR::UIScriptController::minimumZoomScale):
1310         (WTR::UIScriptController::maximumZoomScale):
1311         (WTR::UIScriptController::contentVisibleRect):
1312         (WTR::UIScriptController::uiScriptComplete):
1313         * WebKitTestRunner/uiscriptcontext/UIScriptController.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
1314         (WTR::UIScriptController::create):
1315         * WebKitTestRunner/uiscriptcontext/bindings/UIScriptController.idl: Copied from Tools/WebKitTestRunner/TestOptions.h.
1316
1317 2015-09-21  Tim Horton  <timothy_horton@apple.com>
1318
1319         Turn on threaded scrolling by default in the tests
1320         https://bugs.webkit.org/show_bug.cgi?id=149377
1321
1322         Reviewed by Simon Fraser.
1323
1324         * WebKitTestRunner/mac/TestControllerMac.mm:
1325         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
1326         (WTR::shouldUseThreadedScrolling): Deleted.
1327         Turn on threaded scrolling by default.
1328
1329 2015-09-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1330
1331         [GTK] run-gtk-tests doesn't provide feedback about crashing google tests
1332         https://bugs.webkit.org/show_bug.cgi?id=149252
1333
1334         Reviewed by Darin Adler.
1335
1336         In case of glib tests the test runner notifies about tests
1337         crashing, but for google tests we don't get any feedback, which
1338         means that in case of a test crashing we get a list of **PASS**
1339         messages and at the summary we are notified that the test suite
1340         has failed, but it's impossible to know which test cases have failed.
1341
1342         * Scripts/run-gtk-tests:
1343         (TestRunner._run_google_test): Add a **CRASH** message if test
1344         case crashed.
1345
1346 2015-09-20  Alexey Proskuryakov  <ap@apple.com>
1347
1348         WebKitTestRunner can leak user content script results between tests
1349         https://bugs.webkit.org/show_bug.cgi?id=149391
1350
1351         Reviewed by Sam Weinig.
1352
1353         Move WKBundlePageRemoveAllUserContent call so that it's executed before loading
1354         about:blank, and thus about:blank doesn't have unintended side effects.
1355
1356         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1357         (WTR::InjectedBundle::beginTesting):
1358         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1359         (WTR::InjectedBundlePage::resetAfterTest):
1360
1361 2015-09-20  Alexey Proskuryakov  <ap@apple.com>
1362
1363         [Mac, iOS] AccessibilityController doesn't uninstall global notification handler
1364         https://bugs.webkit.org/show_bug.cgi?id=149384
1365
1366         Reviewed by Chris Fleizach.
1367
1368         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
1369         (AccessibilityController::addNotificationListener): Fixed a leak, and cleaned up the code.
1370         (AccessibilityController::platformResetToConsistentState): Actually remove the handler,
1371         regardless of whether someone else holds a reference (we also call -stopListening in
1372         -dealloc).
1373
1374         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1375         (AccessibilityController::platformResetToConsistentState):
1376         (AccessibilityController::addNotificationListener):
1377         Ditto.
1378
1379 2015-09-20  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1380
1381         Remove XHR_TIMEOUT compilation guard
1382         https://bugs.webkit.org/show_bug.cgi?id=149260
1383
1384         Reviewed by Benjamin Poulain.
1385
1386         * Scripts/webkitperl/FeatureList.pm:
1387
1388 2015-09-19  Dan Bernstein  <mitz@apple.com>
1389
1390         Attempted build fix.
1391
1392         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
1393
1394 2015-09-18  Commit Queue  <commit-queue@webkit.org>
1395
1396         Unreviewed, rolling out r189908.
1397         https://bugs.webkit.org/show_bug.cgi?id=149368
1398
1399         Broke run-webkit-tests --pixel (Requested by ap on #webkit).
1400
1401         Reverted changeset:
1402
1403         "printing does not use minimum page zoom factor"
1404         https://bugs.webkit.org/show_bug.cgi?id=108507
1405         http://trac.webkit.org/changeset/189908
1406
1407 2015-09-18  Andy Estes  <aestes@apple.com>
1408
1409         [iOS] did{Start,Finish}LoadForQuickLookDocumentInMainFrame is never called on WKNavigationDelegate
1410         https://bugs.webkit.org/show_bug.cgi?id=149360
1411
1412         Reviewed by Tim Horton.
1413
1414         Added an API test.
1415
1416         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1417         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm: Added.
1418         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1419         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1420         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]):
1421         (TEST):
1422         * TestWebKitAPI/ios/pages.pages: Added.
1423
1424 2015-09-18  Nan Wang  <n_wang@apple.com>
1425
1426         AX: Implement ARIA 1.1 @aria-current on iOS
1427         https://bugs.webkit.org/show_bug.cgi?id=149297
1428
1429         Reviewed by Chris Fleizach.
1430
1431         Added support to test aria-current on iOS.
1432
1433         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1434         (AccessibilityUIElement::stringAttributeValue):
1435         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1436         (WTR::AccessibilityUIElement::stringAttributeValue):
1437
1438 2015-09-18  Alexey Proskuryakov  <ap@apple.com>
1439
1440         iOS WebKitTestRunner frequently crashes in WKContextGetIconDatabase
1441         https://bugs.webkit.org/show_bug.cgi?id=149352
1442
1443         Reviewed by Simon Fraser.
1444
1445         * WebKitTestRunner/TestController.cpp: (WTR::TestController::~TestController):
1446         m_context can be null. This may indicate a bug in webkitpy too, but
1447         WebKitTestRunner should handle this situation nicely, there is nothing intrinsically
1448         wrong with opening and immediately closing it.
1449
1450 2015-09-18  Daniel Bates  <dabates@apple.com>
1451
1452         isGitSVNDirectory() returns true when Git is not installed
1453         https://bugs.webkit.org/show_bug.cgi?id=149351
1454
1455         Reviewed by Alexey Proskuryakov.
1456
1457         Fixes an issue where VCSUtils::isGitSVNDirectory() returns true for any arbitrary directory if
1458         Git is not installed on the machine.
1459
1460         * Scripts/VCSUtils.pm:
1461         (isGitSVNDirectory): Ensure that `git config --get svn-remote.svn.fetch 2>& 1` exits with
1462         status code 0 (success).
1463
1464 2015-09-18  Alex Christensen  <achristensen@webkit.org>
1465
1466         Prevent build-webkit from building four times on Windows 
1467         https://bugs.webkit.org/show_bug.cgi?id=149336
1468
1469         Reviewed by Brent Fulgham.
1470
1471         * Scripts/build-webkit:
1472         Move the Windows code out of the for loop iterating over each subdirectory to be build.
1473         They're built all at once.
1474         * Scripts/webkitdirs.pm:
1475         (buildVisualStudioProject):
1476         (cmakeGeneratedBuildfile):
1477         Don't generate the Visual Studio solution if it already exists.
1478         It will run CMake again if necessary.
1479
1480 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
1481
1482         [iOS WK2] WTR fails to set the key window in the UIKit sense
1483         https://bugs.webkit.org/show_bug.cgi?id=149325
1484
1485         Reviewed by Tim Horton.
1486
1487         -[WebKitTestRunnerWindow isKeyWindow] just returned _platformWebView->windowIsKey().
1488         This causes UIKit to bypass code that actually sets the key window, resulting in
1489         [UIAppliation sharedApplication].keyWindow always being nil.
1490
1491         Fix by PlatformWebView::setWindowIsKey() actually call -makeKeyWindow, and having
1492         -[WebKitTestRunnerWindow isKeyWindow] call super.
1493
1494         * WebKitTestRunner/PlatformWebView.h:
1495         (WTR::PlatformWebView::setWindowIsKey): Deleted.
1496         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1497         (WTR::PlatformWebView::setWindowIsKey):
1498         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1499         (WTR::PlatformWebView::setWindowIsKey):
1500         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1501         (-[WebKitTestRunnerWindow isKeyWindow]):
1502         (WTR::PlatformWebView::PlatformWebView):
1503         (WTR::PlatformWebView::~PlatformWebView):
1504         (WTR::PlatformWebView::setWindowIsKey):
1505         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1506         (WTR::PlatformWebView::setWindowIsKey):
1507
1508 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
1509
1510         [iOS WK2] When loading viewport tests, use the normal web page viewport configuration
1511         https://bugs.webkit.org/show_bug.cgi?id=149321
1512
1513         Reviewed by Tim Horton.
1514         
1515         InjectedBundlePage::platformDidStartProvisionalLoadForFrame() unconditionally 
1516         enabled the "testing" viewport configuration, which disables page scaling.
1517         
1518         If we're running viewport tests, we want the normal web page configuration.
1519         Do that by passing a flag in the dictionary sent to InjectedBundle::beginTesting(),
1520         based on whether the test is in a "viewport" directory.
1521
1522         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1523         (WTR::InjectedBundle::beginTesting):
1524         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1525         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Deleted.
1526         * WebKitTestRunner/TestInvocation.cpp:
1527         (WTR::TestInvocation::shouldLogFrameLoadDelegates):
1528         (WTR::TestInvocation::shouldLogHistoryClientCallbacks):
1529         (WTR::TestInvocation::shouldMakeViewportFlexible):
1530         (WTR::TestInvocation::invoke):
1531         * WebKitTestRunner/TestInvocation.h:
1532         * WebKitTestRunner/ios/TestControllerIOS.mm:
1533         (WTR::TestController::platformConfigureViewForTest):
1534         (WTR::shouldMakeViewportFlexible): Deleted.
1535
1536 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
1537
1538         Give iOS WebKitTestRunner a launch storyboard
1539         https://bugs.webkit.org/show_bug.cgi?id=149314
1540
1541         Reviewed by Dan Bates.
1542         
1543         Add a launch storyboard to iOS WebKitTestRunner so that Springboard recognizes
1544         that it's been built for specific device configurations, and puts the window
1545         at the top of the screen. This simplifies coordinate conversions in a future patch.
1546
1547         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1548         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
1549         * WebKitTestRunner/ios/Launch.storyboard: Added.
1550
1551 2015-09-17  Myles C. Maxfield  <mmaxfield@apple.com>
1552
1553         Update licence in r189890
1554         https://bugs.webkit.org/show_bug.cgi?id=149306
1555
1556         Reviewed by Dean Jackson.
1557
1558         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
1559         * FontWithFeatures/FontWithFeatures/FontCreator.h:
1560         * FontWithFeatures/FontWithFeatures/main.cpp:
1561
1562 2015-09-17  Mark Lam  <mark.lam@apple.com>
1563
1564         Add the ability to skip JIT stress tests in run-javascriptcore-tests.
1565         https://bugs.webkit.org/show_bug.cgi?id=149285
1566
1567         Reviewed by Saam Barati.
1568
1569         Just need to add an option to pass --no-jit to run-jsc-stress-test.
1570
1571         * Scripts/run-javascriptcore-tests:
1572         (runJSCStressTests):
1573
1574 2015-09-17  Alex Christensen  <achristensen@webkit.org>
1575
1576         Switch AppleWin build to use CMake
1577         https://bugs.webkit.org/show_bug.cgi?id=149163
1578
1579         Reviewed by Brent Fulgham.
1580
1581         * Scripts/build-webkit:
1582         * Scripts/run-api-tests:
1583         (runTest):
1584         (listAllTests):
1585         (prepareEnvironmentForRunningTestTool):
1586         (testToolPaths):
1587         (testToolPath): Deleted.
1588         Run the API tests as separate executables on Windows.
1589         It used to be TestWebKitAPI.exe, and it is now TestWTF.exe, TestWebCore.exe, and TestWebKit.exe.
1590         * Scripts/webkitdirs.pm:
1591         (checkRequiredSystemConfig):
1592         (jhbuildWrapperPrefixIfNeeded):
1593         (generateBuildSystemFromCMakeProject):
1594         Fix configuration quirks.
1595
1596 2015-09-17  Dean Johnson  <dean_johnson@apple.com>
1597
1598         Added toggle options for hiding and showing certain platform families on the dashboard.
1599         https://bugs.webkit.org/show_bug.cgi?id=148403
1600
1601         Reviewed by David Kilzer.
1602
1603         This patch removes "hiddenPlatforms" from use in the code and local storage. We also removed
1604         individual hide/show buttons for platforms because we've added toggle options to hide/show entire
1605         families. Examples of these are "mac", "ios", and "linux". "Show All Platforms" was also removed
1606         in lieu of an "all" button in the toggle menu.
1607
1608         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1609         (parsePlatformFamily): Helper function to parse out a platform family.
1610         (initPlatformsByFamily): Initializes platformsByFamily, which organizes platforms on the
1611         page by platformsByFamily[<family>] = <list of platforms belonging to that family>.
1612         (updateToggleButtons): Updates the status of the toggle buttons.
1613         (updateHiddenPlatforms): Changed to work with the new implementation of hiding/showing platforms.
1614         (documentReady): Added creation of toggle buttons.
1615         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
1616         (unhiddenQueues): Updated to search by platform family instead of the individual platform name.
1617         (documentReady): Changed hiddenPlatforms => hiddenPlatformFamilies.
1618         (updateHiddenPlatforms): Deleted. After removing the individual hide button code, 
1619         this did the exact same thing as the updateHiddenPlatforms in Scripts/Main.js so it was removed.
1620         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
1621         (QueueView): Updated to use hiddenPlatformFamilies.
1622         (QueueView.prototype._updateHiddenState): Updated to use hiddenPlatformFamilies.
1623         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
1624         (Settings.prototype.toggleHiddenPlatformFamily): Renamed function and some variables.
1625         (Settings.prototype.clearHiddenPlatformFamilies): Now uses hiddenPlatformFamilies for events.
1626         (Settings.prototype.toggleHiddenPlatform): Deleted.
1627         (Settings.prototype.clearHiddenPlatforms): Deleted.
1628         (Settings.prototype.toggleShowPlatformFamily): Deleted.
1629         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1630         (div.cellButton, div.accessibilityButton, div.platformFamilyToggleButton):
1631         (div.cellButton.unhide, div.accessibilityButton.unhide, div.platformFamilyToggleButton.unhide):
1632         (.settings-visible div.settingsWrapper.hide, .settings-visible div.settingsWrapper):
1633         (table.queue-grid tr.headers th):
1634         (div.settingsWrapper.hide):
1635         (div.settingsWrapper):
1636         (div.familyToggleWrapper):
1637         (div.platformFamilyToggleButton):
1638         (div.platformFamilyShowToggleButton:not(:last-child)):
1639         (div.familyShown):
1640         (div.accessibilityButton):
1641         (div.cellButton, div.accessibilityButton): Added platformFamilyToggleButton class.
1642         (div.cellButton.unhide, div.accessibilityButton.unhide): Added platformFamilyToggleButton class.
1643         (.settings-visible div.accessibilityButton.hide, .settings-visible div.accessibilityButton.unhide): Added
1644         platformFamilyToggleButton and settingsWrapper class.
1645         (.accessibilityButton): Deleted.
1646
1647 2015-09-17  Tim Horton  <timothy_horton@apple.com>
1648
1649         Add a test ensuring that scrolling in the middle of a page can't start a swipe gesture
1650         https://bugs.webkit.org/show_bug.cgi?id=148904
1651
1652         Reviewed by Myles Maxfield.
1653
1654         * WebKitTestRunner/TestController.cpp:
1655         (WTR::parseBooleanTestHeaderValue):
1656         (WTR::updateViewOptionsFromTestHeader):
1657         Check for the key "useThreadedScrolling".
1658         Add some code to check for "true" and "false" for boolean options.
1659
1660         (WTR::TestController::viewOptionsForTest):
1661         Apply the test's overrides last, even after the platform's.
1662
1663 2015-09-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1664
1665         printing does not use minimum page zoom factor
1666         https://bugs.webkit.org/show_bug.cgi?id=108507
1667
1668         Reviewed by Darin Adler.
1669
1670         WebKitTestRunner always takes the snapshots from the UI process
1671         (expect for IOS), so in the case of printing, the layout in the
1672         web view is not the expected one. When printing, we need to take
1673         the snapshot in the web process and ensure it's rendered with a
1674         PrintContext.
1675
1676         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1677         (WTR::InjectedBundlePage::dump): When dumping pixels, pass
1678         kWKSnapshotOptionsPrinting option to
1679         WKBundlePageCreateSnapshotWithOptions() when printing. When not
1680         printing, don't even create the snapshot, since it will be ignored
1681         by the UI process that always creates its own from the WebView (expect for IOS platform)
1682         * WebKitTestRunner/TestInvocation.cpp:
1683         (WTR::TestInvocation::dumpResults): Use always the snapshot image
1684         received from the web process if any when comparing pixel
1685         results. Now we only receive a snapshot from the web process in
1686         case of printing, or when platform is IOS. Otherwhise, generate
1687         the snapshot from the WebView as usual.
1688         * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum
1689         parameter to dumpPixelsAndCompareWithExpected, since the snapshot
1690         is created by the caller now, but the CG implementation needs to
1691         know if it's a Web or UI process snapshot.
1692         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
1693         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
1694         cairo surface for the given image.
1695         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1696         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
1697         CGContext for the given image.
1698
1699 2015-09-16  Myles C. Maxfield  <mmaxfield@apple.com>
1700
1701         Create a font which can be used for testing font features
1702         https://bugs.webkit.org/show_bug.cgi?id=149237
1703
1704         Reviewed by Simon Fraser.
1705
1706         This patch adds a new project in the Tools/ directory which generates a font which can
1707         be used for testing font features. This is a standalone project consisting of two files:
1708         1. A file which actually generates the byte vector representing the font. This file has
1709         a single public function: std::vector<uint8_t> generateFont(). This file is not platform
1710         specific, and only relies on the C++ STL.
1711         2. A file with a main() which calls generateFont() and writes out the font, as well as
1712         uses the font to render some demonstration text into a .png file. This file is platform
1713         specific.
1714
1715         The font itself only supports the following characters:
1716         ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz
1717         However, the shape of these letters are either an X or a check mark.
1718
1719         The letter "A" always is a check mark.
1720         The letter "B" always is an X.
1721         Without any font features turned on, the rest of the letters are shown as X.
1722
1723         Each font feature has an letter associated with it. When the font feature is enabled,
1724         that letter is shown as a check mark. For example, when "smcp" is enabled, "J" is shown
1725         as a check mark.
1726
1727         Here are the mappings of font features to letters:
1728         liga: C
1729         clig: D
1730         dlig: E
1731         hlig: F
1732         calt: G
1733         subs: H
1734         sups: I
1735         smcp: J
1736         c2sc: K
1737         pcap: L
1738         c2pc: M
1739         unic: N
1740         titl: O
1741         onum: P
1742         pnum: Q
1743         tnum: R
1744         frac: S
1745         afrc: T
1746         ordn: U
1747         zero: V
1748         hist: W
1749         jp78: X
1750         jp83: Y
1751         jp90: Z
1752         jp04: a
1753         smpl: b
1754         trad: c
1755         fwid: d
1756         pwid: e
1757         ruby: f
1758
1759         * FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj: Added.
1760         * FontWithFeatures/FontWithFeatures/FontCreator.cpp: Added.
1761         (integralLog2):
1762         (roundDownToPowerOfTwo):
1763         (isFourByteAligned):
1764         (clampTo):
1765         (append32):
1766         (writeCFFEncodedNumber):
1767         (CFFBuilder::CFFBuilder):
1768         (CFFBuilder::takeResult):
1769         (CFFBuilder::moveTo):
1770         (CFFBuilder::lineTo):
1771         (CFFBuilder::curveToCubic):
1772         (CFFBuilder::closePath):
1773         (CFFBuilder::writePoint):
1774         (generateBoxCharString):
1775         (generateCheckCharString):
1776         (generateXCharString):
1777         (charStringForGlyph):
1778         (Generator::generate):
1779         (Generator::Placeholder::Placeholder):
1780         (Generator::Placeholder::populate):
1781         (Generator::Placeholder::~Placeholder):
1782         (Generator::placeholder):
1783         (Generator::append16):
1784         (Generator::append32):
1785         (Generator::append32BitCode):
1786         (Generator::overwrite16):
1787         (Generator::overwrite32):
1788         (Generator::appendCFFTable):
1789         (Generator::appendSubstitutionSubtable):
1790         (Generator::appendScriptSubtable):
1791         (Generator::appendGSUBTable):
1792         (Generator::appendOS2Table):
1793         (Generator::appendFormat12CMAPTable):
1794         (Generator::appendFormat4CMAPTable):
1795         (Generator::appendCMAPTable):
1796         (Generator::appendHEADTable):
1797         (Generator::appendHHEATable):
1798         (Generator::appendHMTXTable):
1799         (Generator::appendMAXPTable):
1800         (Generator::appendNAMETable):
1801         (Generator::appendPOSTTable):
1802         (Generator::calculateChecksum):
1803         (Generator::appendTable):
1804         (generateFont):
1805         * FontWithFeatures/FontWithFeatures/FontCreator.h: Added.
1806         * FontWithFeatures/FontWithFeatures/main.cpp: Added.
1807         (drawTextWithFeature):
1808         (main):
1809
1810 2015-09-16  Commit Queue  <commit-queue@webkit.org>
1811
1812         Unreviewed, rolling out r189875 and r189878.
1813         https://bugs.webkit.org/show_bug.cgi?id=149235
1814
1815         cygwin cmake build not ready yet (Requested by alexchristensen
1816         on #webkit).
1817
1818         Reverted changesets:
1819
1820         "Switch AppleWin build to use CMake"
1821         https://bugs.webkit.org/show_bug.cgi?id=149163
1822         http://trac.webkit.org/changeset/189875
1823
1824         "Cygwin build fix after r189875"
1825         http://trac.webkit.org/changeset/189878
1826
1827 2015-09-16  Alex Christensen  <achristensen@webkit.org>
1828
1829         Cygwin build fix after r189875
1830
1831         * Scripts/build-webkit:
1832         * Scripts/webkitdirs.pm:
1833         (jhbuildWrapperPrefixIfNeeded):
1834         (generateBuildSystemFromCMakeProject):
1835         Make things work with cygwin and cmake.
1836
1837 2015-09-16  Alex Christensen  <achristensen@webkit.org>
1838
1839         Switch AppleWin build to use CMake
1840         https://bugs.webkit.org/show_bug.cgi?id=149163
1841
1842         Reviewed by Brent Fulgham.
1843
1844         * Scripts/build-webkit:
1845         Build with CMake.
1846         * Scripts/run-api-tests:
1847         (runTest):
1848         (listAllTests):
1849         (prepareEnvironmentForRunningTestTool):
1850         (testToolPaths):
1851         (testToolPath): Deleted.
1852         Run the API tests as separate executables on Windows.
1853         It used to be TestWebKitAPI.exe, and it is now TestWTF.exe, TestWebCore.exe, and TestWebKit.exe.
1854
1855 2015-09-16  Alexey Proskuryakov  <ap@apple.com>
1856
1857         Add newer build.webkit.org pages to robots.txt
1858         https://bugs.webkit.org/show_bug.cgi?id=149219
1859
1860         Reviewed by Darin Adler.
1861
1862         Indexing bot watcher's dashboard can't be good.
1863
1864         * BuildSlaveSupport/build.webkit.org-config/public_html/robots.txt:
1865
1866 2015-09-16  Alex Christensen  <achristensen@webkit.org>
1867
1868         Rollout r189851 and 189853 because they didn’t actually fix the permissions issue
1869
1870         * BuildSlaveSupport/built-product-archive:
1871         (unzipArchive):
1872
1873 2015-09-16  Csaba Osztrogonác  <ossy@webkit.org>
1874
1875         [EFL] Fix the help message of separated web process option of MiniBrowser
1876         https://bugs.webkit.org/show_bug.cgi?id=149212
1877
1878         Reviewed by Gyuyoung Kim.
1879
1880         * MiniBrowser/efl/main.c:
1881
1882 2015-09-16  Alex Christensen  <achristensen@webkit.org>
1883
1884         Fix python syntax after r189851.
1885
1886         * BuildSlaveSupport/built-product-archive:
1887         (unzipArchive):
1888         For loops need a colon.
1889
1890 2015-09-15  Alex Christensen  <achristensen@webkit.org>
1891
1892         Fix Windows test bots after changing to non-cygwin build
1893         https://bugs.webkit.org/show_bug.cgi?id=149196
1894
1895         Reviewed by Daniel Bates.
1896
1897         * BuildSlaveSupport/built-product-archive:
1898         (unzipArchive):
1899         Using different versions of python makes what I think is https://bugs.python.org/issue15795
1900         prevent us from executing files from the archive on the test bots.
1901
1902 2015-09-15  Ryosuke Niwa  <rniwa@webkit.org>
1903
1904         Add ShadowRoot interface and Element.prototype.attachShadow
1905         https://bugs.webkit.org/show_bug.cgi?id=149187
1906
1907         Reviewed by Antti Koivisto.
1908
1909         * Scripts/webkitperl/FeatureList.pm:
1910
1911 2015-09-15  Aakash Jain  <aakash_jain@apple.com>
1912
1913         Appscale queue status json output lacks bots
1914         https://bugs.webkit.org/show_bug.cgi?id=149194
1915         <rdar://problem/22171089>
1916
1917         Reviewed by Alexey Proskuryakov.
1918
1919         * QueueStatusServer/handlers/queuestatusjson.py:
1920         (QueueStatusJSON._bots): Order the results by date so as to get latest events, this was default in AppEngine.
1921         * QueueStatusServer/index.yaml: Index according to appscale requirements.
1922
1923 2015-09-15  Brent Fulgham  <bfulgham@apple.com>
1924
1925         [Win] Provide a means for viewing the layer tree
1926         https://bugs.webkit.org/show_bug.cgi?id=149165
1927
1928         Reviewed by Simon Fraser.
1929
1930         Update MiniBrowser with a new Debug menu option that will
1931         dump the current layer tree to the debug console.
1932         
1933         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc:
1934         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h:
1935         * MiniBrowser/win/Common.cpp:
1936         (WndProc): Add handler for 'Print Layer Tree' menu option.
1937         * MiniBrowser/win/MiniBrowser.cpp:
1938         (MiniBrowser::printLayerTree): Added Handler.
1939         * MiniBrowser/win/MiniBrowser.h:
1940
1941 2015-09-14  Myles C. Maxfield  <mmaxfield@apple.com>
1942
1943         WebKitTestRunner declarative language setting is broken for iOS
1944         https://bugs.webkit.org/show_bug.cgi?id=149119
1945
1946         Unreviewed.
1947
1948         In all of the patches on webkit.org/b/189669, my patch to get this working on iOS was
1949         lost in the final version which got committed. This simply implements the existing
1950         OS X behavior on iOS.
1951
1952         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
1953         (WTR::InjectedBundle::platformInitialize):
1954
1955 2015-09-14  Dewei Zhu  <dewei_zhu@apple.com>
1956
1957         Unreviewed, add myself to committers list.
1958
1959         * Scripts/webkitpy/common/config/contributors.json:
1960
1961 2015-09-12  Myles C. Maxfield  <mmaxfield@apple.com>
1962
1963         [Cocoa] Allow testing with the system language
1964         https://bugs.webkit.org/show_bug.cgi?id=148671
1965
1966         Reviewed by Anders Carlsson and Alexey Proskuryakov.
1967
1968         React to tests marked with language=lang1,lang2,etc in their header.
1969         Once this information is parsed, pass it to
1970         WKContextConfigurationSetOverrideLanguages().
1971
1972         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1973         (WTR::InjectedBundle::platformInitialize): Don't clobber the language
1974         list.
1975         * WebKitTestRunner/TestController.cpp:
1976         (WTR::TestController::createWebViewWithOptions): Call
1977         WKContextConfigurationSetOverrideLanguages().
1978         (WTR::updateTestOptionsFromTestHeader): Inspect the language option.
1979         * WebKitTestRunner/TestOptions.h:
1980         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1981         (WTR::PlatformWebView::viewSupportsOptions): Cause a differing language
1982         option to restart the web process.
1983         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1984         (WTR::PlatformWebView::viewSupportsOptions): Ditto.
1985
1986 2015-09-12  Myles C. Maxfield  <mmaxfield@apple.com>
1987
1988         [WKTR] Allow changing the WKContextConfiguration between successive tests
1989         https://bugs.webkit.org/show_bug.cgi?id=148833
1990
1991         Reviewed by Tim Horton.
1992
1993         Previously, we were creating a single WKContext and it lived for the life of the entire test runner.
1994         However, there are certain tests which require specifying options in this object. This patch makes
1995         our existing code for recreating the test runner web view also recreate the WKContext.
1996
1997         As such, our options to the view are now options to the WKContextConfiguration. This patch renames the
1998         class.
1999
2000         * WebKitTestRunner/ContextConfigurationOptions.h: Renamed from Tools/WebKitTestRunner/ViewOptions.h.
2001         * WebKitTestRunner/PlatformWebView.h:
2002         (WTR::PlatformWebView::options):
2003         * WebKitTestRunner/TestController.cpp:
2004         (WTR::TestController::initialize):
2005         (WTR::TestController::generateContextConfiguration):
2006         (WTR::TestController::generatePageConfiguration):
2007         (WTR::TestController::createWebViewWithOptions):
2008         (WTR::TestController::ensureViewSupportsOptionsForTest):
2009         (WTR::updateContextConfigurationOptionsFromTestHeader):
2010         (WTR::TestController::contextConfigurationOptionsForTest):
2011         (WTR::TestController::platformCreateWebView):
2012         (WTR::TestController::platformCreateOtherPage):
2013         (WTR::updateViewOptionsFromTestHeader): Deleted.
2014         (WTR::TestController::viewOptionsForTest): Deleted.
2015         * WebKitTestRunner/TestController.h:
2016         (WTR::TestController::injectedBundlePath):
2017         (WTR::TestController::testPluginDirectory):
2018         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2019         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2020         (WTR::TestController::platformCreateWebView):
2021         (WTR::TestController::platformCreateOtherPage):
2022         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2023         (WTR::PlatformWebView::PlatformWebView):
2024         (WTR::PlatformWebView::viewSupportsOptions):
2025         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2026         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2027         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2028         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2029         (WTR::PlatformWebView::PlatformWebView):
2030         (WTR::PlatformWebView::viewSupportsOptions):
2031         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2032         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2033         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2034         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2035         (WTR::PlatformWebView::PlatformWebView):
2036         (WTR::PlatformWebView::viewSupportsOptions):
2037         * WebKitTestRunner/ios/TestControllerIOS.mm:
2038         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2039         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2040         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2041         (WTR::PlatformWebView::PlatformWebView):
2042         (WTR::PlatformWebView::viewSupportsOptions):
2043         * WebKitTestRunner/mac/TestControllerMac.mm:
2044         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2045         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2046
2047 2015-09-11  Michael Saboff  <msaboff@apple.com>
2048
2049         LayoutTestHelper crashes if a color profile isn't set for a 3rd party monitor
2050         https://bugs.webkit.org/show_bug.cgi?id=149083
2051
2052         Reviewed by Alexey Proskuryakov.
2053
2054         Check to make sure that we have a valid factoryProfile CFDictionaryRef before using it.
2055
2056         * DumpRenderTree/mac/LayoutTestHelper.m:
2057         (colorProfileURLForDisplay):
2058
2059 2015-09-11  Saam barati  <sbarati@apple.com>
2060
2061         There should be a defaultSpotCheck-like mode that doesn't run the MaximalFlushInsertionPhase in run-jsc-stress-tests
2062         https://bugs.webkit.org/show_bug.cgi?id=149058
2063
2064         Reviewed by Geoffrey Garen.
2065
2066         * Scripts/run-jsc-stress-tests:
2067
2068 2015-09-10  Commit Queue  <commit-queue@webkit.org>
2069
2070         Unreviewed, rolling out r189595.
2071         https://bugs.webkit.org/show_bug.cgi?id=149052
2072
2073         The tests still fail (Requested by ap on #webkit).
2074
2075         Reverted changeset:
2076
2077         "Spurious output on Windows tests: AQMEIOManager::FindIOUnit:
2078         error -1"
2079         https://bugs.webkit.org/show_bug.cgi?id=142929
2080         http://trac.webkit.org/changeset/189595
2081
2082 2015-09-10  Alexey Proskuryakov  <ap@apple.com>
2083
2084         Spurious output on Windows tests: AQMEIOManager::FindIOUnit: error -1
2085         https://bugs.webkit.org/show_bug.cgi?id=142929
2086
2087         Reviewed by Brent Fulgham.
2088
2089         Silence the logging. We'll track fixing the root cause in Radar.
2090
2091         * Scripts/webkitpy/port/mac.py:
2092         (MacPort.stderr_patterns_to_strip): Added a FIXME.
2093
2094         * Scripts/webkitpy/port/win.py:
2095         (WinPort.logging_patterns_to_strip): Added.
2096
2097 2015-09-09  Andy Estes  <aestes@apple.com>
2098
2099         [iOS] Teach run-webkit-tests how to parse simulator runtimes when version numbers contain a revision
2100         https://bugs.webkit.org/show_bug.cgi?id=149022
2101
2102         Reviewed by Daniel Bates.
2103
2104         Simulator runtime versions can contain a revision number (e.g. 8.4.1), but the regex for matching runtimes
2105         did not account for this.
2106
2107         * Scripts/webkitpy/xcode/simulator.py:
2108         (Simulator): Optionally matched a revision at the end of a runtime version number.
2109         * Scripts/webkitpy/xcode/simulator_unittest.py: Added a test.
2110
2111 2015-09-09  Andy Estes  <aestes@apple.com>
2112
2113         [iOS] Teach run-webkit-tests how to parse `simctl list` when a tvOS SDK is installed
2114         https://bugs.webkit.org/show_bug.cgi?id=149029
2115         <rdar://problem/22432624>
2116
2117         Reviewed by Daniel Bates.
2118
2119         * Scripts/webkitpy/xcode/simulator.py:
2120         (Simulator): Taught to parse tvOS runtimes.
2121         * Scripts/webkitpy/xcode/simulator_unittest.py: Added tests.
2122
2123 2015-09-09  Alexey Proskuryakov  <ap@apple.com>
2124
2125         Fix bit rot on bot watcher's dashboard page
2126         https://bugs.webkit.org/show_bug.cgi?id=149012
2127
2128         Reviewed by Tim Horton.
2129
2130         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2131         The code path used by the metrics page was trying to add properties to an undefined.
2132
2133         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
2134         Silence an expection that would occur when the step has no logs. This should never
2135         happen, but it did (perhaps buildbot was misconfigured for a while).
2136
2137 2015-09-09  Alexey Proskuryakov  <ap@apple.com>
2138
2139         Update LayoutTestRelay xcconfig file.
2140
2141         Rubber-stamped by Dan Bernstein.
2142
2143         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
2144
2145 2015-09-09  Saam barati  <sbarati@apple.com>
2146
2147         DFG should have a debugging option that runs a phase that flushes all locals
2148         https://bugs.webkit.org/show_bug.cgi?id=148916
2149
2150         Reviewed by Filip Pizlo.
2151
2152         * Scripts/run-jsc-stress-tests:
2153
2154 2015-09-09  Commit Queue  <commit-queue@webkit.org>
2155
2156         Unreviewed, rolling out r189530 and r189534.
2157         https://bugs.webkit.org/show_bug.cgi?id=148996
2158
2159         Caused assertion failures on Yosemite (Requested by litherum
2160         on #webkit).
2161
2162         Reverted changesets:
2163
2164         "[WKTR] Allow changing the WKContextConfiguration between
2165         successive tests"
2166         https://bugs.webkit.org/show_bug.cgi?id=148833
2167         http://trac.webkit.org/changeset/189530
2168
2169         "[Cocoa] Fix the tests after r189530"
2170         http://trac.webkit.org/changeset/189534
2171
2172 2015-09-08  Myles C. Maxfield  <mmaxfield@apple.com>
2173
2174         [Cocoa] Fix the tests after r189530
2175
2176         Unreviewed.
2177
2178         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2179         (WTR::initializeWebViewConfiguration):
2180
2181 2015-09-08  Myles C. Maxfield  <mmaxfield@apple.com>
2182
2183         [WKTR] Allow changing the WKContextConfiguration between successive tests
2184         https://bugs.webkit.org/show_bug.cgi?id=148833
2185
2186         Reviewed by Tim Horton.
2187
2188         Previously, we were creating a single WKContext and it lived for the life of the entire test runner.
2189         However, there are certain tests which require specifying options in this object. This patch makes
2190         our existing code for recreating the test runner web view also recreate the WKContext.
2191
2192         As such, our options to the view are now options to the WKContextConfiguration. This patch renames the
2193         class.
2194
2195         * WebKitTestRunner/ContextConfigurationOptions.h: Renamed from Tools/WebKitTestRunner/ViewOptions.h.
2196         * WebKitTestRunner/PlatformWebView.h:
2197         (WTR::PlatformWebView::options):
2198         * WebKitTestRunner/TestController.cpp:
2199         (WTR::TestController::initialize):
2200         (WTR::TestController::generateContextConfiguration):
2201         (WTR::TestController::generatePageConfiguration):
2202         (WTR::TestController::createWebViewWithOptions):
2203         (WTR::TestController::ensureViewSupportsOptionsForTest):
2204         (WTR::updateContextConfigurationOptionsFromTestHeader):
2205         (WTR::TestController::contextConfigurationOptionsForTest):
2206         (WTR::TestController::platformCreateWebView):
2207         (WTR::TestController::platformCreateOtherPage):
2208         (WTR::updateViewOptionsFromTestHeader): Deleted.
2209         (WTR::TestController::viewOptionsForTest): Deleted.
2210         * WebKitTestRunner/TestController.h:
2211         (WTR::TestController::injectedBundlePath):
2212         (WTR::TestController::testPluginDirectory):
2213         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2214         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2215         (WTR::TestController::platformCreateWebView):
2216         (WTR::TestController::platformCreateOtherPage):
2217         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2218         (WTR::PlatformWebView::PlatformWebView):
2219         (WTR::PlatformWebView::viewSupportsOptions):
2220         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2221         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2222         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2223         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2224         (WTR::PlatformWebView::PlatformWebView):
2225         (WTR::PlatformWebView::viewSupportsOptions):
2226         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2227         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2228         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2229         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2230         (WTR::PlatformWebView::PlatformWebView):
2231         (WTR::PlatformWebView::viewSupportsOptions):
2232         * WebKitTestRunner/ios/TestControllerIOS.mm:
2233         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2234         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2235         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2236         (WTR::PlatformWebView::PlatformWebView):
2237         (WTR::PlatformWebView::viewSupportsOptions):
2238         * WebKitTestRunner/mac/TestControllerMac.mm:
2239         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2240         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2241
2242 2015-09-08  Daniel Bates  <dabates@apple.com>
2243
2244         [Mac] Expose Enable/Disable Accelerated Drawing in MiniBrowser
2245         https://bugs.webkit.org/show_bug.cgi?id=148980
2246
2247         Reviewed by Alexey Proskuryakov.
2248
2249         Add setting to enable/disable accelerated drawing so as to support testing
2250         this feature in MiniBrowser on Mac.
2251
2252         * MiniBrowser/mac/SettingsController.h:
2253         * MiniBrowser/mac/SettingsController.m:
2254         (-[SettingsController _populateMenu]): Add menu item.
2255         (-[SettingsController validateMenuItem:]): Update setting when menu item is toggled.
2256         (-[SettingsController toggleAcceleratedDrawingEnabled:]): Added.
2257         (-[SettingsController acceleratedDrawingEnabled]): Added.
2258         * MiniBrowser/mac/WK1BrowserWindowController.m:
2259         (-[WK1BrowserWindowController didChangeSettings]): Apply setting in WebKit1.
2260         * MiniBrowser/mac/WK2BrowserWindowController.m:
2261         (-[WK2BrowserWindowController didChangeSettings]): Apply setting in WebKit2.
2262
2263 2015-09-08  Jason Marcell  <jmarcell@apple.com>
2264
2265         Unreviewed. Added myself as a commiter in contributors.json.
2266
2267         * Scripts/webkitpy/common/config/contributors.json:
2268
2269 2015-09-08  Keith Miller  <keith_miller@apple.com>
2270
2271         Unreviewed, added myself to the list of contributors.
2272
2273         * Scripts/webkitpy/common/config/contributors.json:
2274
2275 2015-09-08  Daniel Bates  <dabates@apple.com>
2276
2277         Dashboard: Remove use of z-index for ring overlay; use DOM ordering
2278         https://bugs.webkit.org/show_bug.cgi?id=148921
2279
2280         Reviewed by Alexey Proskuryakov.
2281
2282         The ring image is positioned above the platform icon in markup and we specify the CSS
2283         property z-index for the ring image so that it is painted on top of the platform icon
2284         instead of below it (by DOM ordering). Instead we can take advantage of the transparency
2285         of the ring image, switch the order of these DOM elements and remove the use of the CSS
2286         property z-index to achieve a similar effect.
2287
2288         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2289         (documentReady): Create the platform icon image element before the ring image such that
2290         the ring image is painted on top of the platform icon.
2291         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2292         (table.queue-grid td.logo img.ring): Removed property z-index.
2293
2294 2015-09-08  Daniel Bates  <dabates@apple.com>
2295
2296         Dashboard: Remove duplicate gear icon data URLs
2297         https://bugs.webkit.org/show_bug.cgi?id=148920
2298
2299         Reviewed by Alexey Proskuryakov.
2300
2301         Currently we duplicate the SVG data URL for the gear icon up to its fill color in the CSS property
2302         background-image associated with each of the three gear icon states: collapsed (.settings), hover
2303         (.settings:hover), and expanded (.settings-visible .settings). Instead we should use the gear icon
2304         as a mask and make use of the CSS background-color to define the fill color for each of these three
2305         states.
2306
2307         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2308         (.settings): Use gear icon as mask and define CSS background-color for collapsed state. 
2309         (.settings:hover): Override CSS background-color for hover state.
2310         (.settings-visible .settings): Override CSS background-color for expanded state.
2311
2312 2015-09-07  Andy Estes  <aestes@apple.com>
2313
2314         [Mac] DebugRelease builds should link against libWebKitSystemInterfaceElCapitan.a on 10.11
2315         https://bugs.webkit.org/show_bug.cgi?id=148946
2316         <rdar://problem/22603981>
2317
2318         Reviewed by Dan Bernstein.
2319
2320         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2321         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2322
2323 2015-09-07  Hunseop Jeong  <hs85.jeong@samsung.com>
2324
2325         [EFL] Many of the css3/device-adapt/* tests failed after r188548.
2326         https://bugs.webkit.org/show_bug.cgi?id=148927
2327
2328         Reviewed by Csaba Osztrogonác.
2329
2330         device-adapt/* tests need the fixedLayout option but useFixedLayout option is
2331         overwritten by updatePlatformSpecificViewOptionsForTest after r188548.
2332
2333         * WebKitTestRunner/TestController.cpp:
2334         (WTR::shouldUseFixedLayout): Removed the unnecessary indentations.
2335         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2336         (WTR::shouldUseFixedLayout): Return true if the test is related with 'device-adapt'.
2337
2338 2015-09-07  Andy Estes  <aestes@apple.com>
2339
2340         Fix the Production build after r189455.
2341
2342         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Somehow I added the All target using the
2343         In-App Purchase template instead of the Aggregate template. Whoops.
2344
2345 2015-09-06  Andy Estes  <aestes@apple.com>
2346
2347         WebKit.xcworkspace should be be able to build iOS platforms
2348         https://bugs.webkit.org/show_bug.cgi?id=148881
2349
2350         Reviewed by Daniel Bates.
2351
2352         Since we don't want to create platform-specific schemes, all projects in the workspace's schemes need to build
2353         for all supported platforms.
2354
2355         * MiniBrowser/Configurations/Base.xcconfig: Included iphoneos and iphonesimulator in SUPPORTED_PLATFORMS.
2356         * MiniBrowser/Configurations/MiniBrowser.xcconfig: Excluded all source files on iOS, and linked Cocoa and WebKit on Mac.
2357         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Ditto.
2358         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Stopped linking frameworks in Link Binaries With Libraries.
2359
2360 2015-09-06  Andy Estes  <aestes@apple.com>
2361
2362         WebKitTestRunner should build for iOS using the default target
2363         https://bugs.webkit.org/show_bug.cgi?id=148918
2364
2365         Reviewed by Daniel Bates.
2366
2367         When WebKitTestRunner was ported to iOS, a separate target (WebKitTestRunnerApp) was created for building the
2368         iOS variant. This is annoying because (1) all tools that invoke xcodebuild need to be taught to build this
2369         non-default target, and (2) a single Xcode scheme cannot be used to build both Mac and iOS variants.
2370
2371         This change adds a new default target (All) and makes it work for both Mac and iOS. Files that were built for
2372         both WebKitTestRunner and WebKitTestRunnerApp are now built in a static library target (WebKitTestRunner (Library)),
2373         and both apps now link this library. Files that are specific to Mac or iOS are excluded on the other platform.
2374         WebKitTestRunnerApp.app (which should be renamed to WebKitTestRunner.app) is skipped when installing on Mac, and
2375         WebKitTestRunner is skipped when installing on iOS.
2376
2377         The target dependency graph now looks like this:
2378
2379             All
2380                 WebKitTestRunnerApp
2381                     WebKitTestRunner (Library)
2382                         WebKitTestRunnerInjectedBundle
2383                             Derived Sources
2384                 WebKitTestRunner
2385                     WebKitTestRunner (Library)
2386                         WebKitTestRunnerInjectedBundle
2387                             Derived Sources
2388
2389         * Scripts/build-webkit: Stopped building the WebKitTestRunnerApp target on iOS.
2390         * Scripts/build-webkittestrunner: Ditto.
2391         * WebKitTestRunner/Configurations/Base.xcconfig: Set SUPPORTED_PLATFORMS to macosx, iphoneos, and iphonesimulator.
2392         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Set INSTALL_PATH here since it is the same for all targets.
2393         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Stopped setting INSTALL_PATH.
2394         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Moved frameworks from the build phase to here,
2395         excluded iOS-only files, and skipped installing on iOS.
2396         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Moved frameworks from the build phase to here,
2397         excluded Mac-only files, and skipped installing on Mac.
2398         * WebKitTestRunner/Configurations/WebKitTestRunnerLibrary.xcconfig: Skipped installing always.
2399         * WebKitTestRunner/Makefile: Stopped building the WebKitTestRunnerApp target on iOS.
2400         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added new targets, removed frameworks from
2401         Link Binary With Libraries builds phases, moved common files to the WebKitTestRunner (Library) target, and added
2402         new configuration files.
2403
2404 2015-09-05  Joseph Pecoraro  <pecoraro@apple.com>
2405
2406         Web Inspector: Improve prepare-ChangeLog for multiple cases
2407         https://bugs.webkit.org/show_bug.cgi?id=148875
2408
2409         Reviewed by Timothy Hatcher.
2410
2411         * Scripts/prepare-ChangeLog:
2412         (get_function_line_ranges_for_javascript):
2413         - We were ignoring everything inside of an anonymous function expression,
2414           such as (function(){ ... }), which made InjectedScriptSource produce nothing.
2415           Better handle this by inserting a few tweaks.
2416         - Allow method syntax outside of classes as long as they are at the global level.
2417         - Avoid treating "get" and "set" as getter/setter functions in bad contexts.
2418
2419         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt:
2420         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js:
2421         (Foo.prototype.method1):
2422         (Foo.prototype.method2):
2423         (Foo.prototype.method3.innerFunction):
2424         (Foo.prototype.method3):
2425         (insideGlobalAnonymousFunctionExpression):
2426         (foo.insideGlobalFunctionExpression):
2427         (IssueWithMapGetAndSet.prototype.method1.nestedFunctionInsideMethod1):
2428         (IssueWithMapGetAndSet.prototype.method1):
2429         (IssueWithMapGetAndSet.prototype.method2):
2430         (IssueWithMapGetAndSet.prototype.method3):
2431         (IssueWithMapGetAndSet):
2432
2433 2015-09-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2434
2435         [ES6] Enable ES6 Module in JSC shell by default
2436         https://bugs.webkit.org/show_bug.cgi?id=148689
2437
2438         Reviewed by Geoffrey Garen.
2439
2440         * Scripts/run-javascriptcore-tests:
2441         (runJSCStressTests):
2442         * Scripts/run-jsc-stress-tests:
2443
2444 2015-09-04  Basile Clement  <basile_clement@apple.com>
2445
2446         Unreviewed, change my email address.
2447
2448         * Scripts/webkitpy/common/config/contributors.json:
2449
2450 2015-09-04  Beth Dakin  <bdakin@apple.com>
2451
2452         Should have a test to make sure links don't navigate after a cancelled force 
2453         click
2454         https://bugs.webkit.org/show_bug.cgi?id=148846
2455
2456         Reviewed by Tim Horton.
2457
2458         New EventSender function for a started then cancelled force click.
2459         * WebKitTestRunner/EventSenderProxy.h:
2460         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2461         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2462         (WTR::EventSendingController::mouseForceClick):
2463         (WTR::EventSendingController::startAndCancelMouseForceClick):
2464         (WTR::EventSendingController::mouseForceDown):
2465         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2466         * WebKitTestRunner/TestController.cpp:
2467         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2468         * WebKitTestRunner/mac/EventSenderProxy.mm:
2469         (WTR::EventSenderProxy::mouseForceClick):
2470         (WTR::EventSenderProxy::startAndCancelMouseForceClick):
2471         (WTR::EventSenderProxy::mouseForceDown):
2472         (WTR::EventSenderProxy::mouseMoveTo):
2473
2474 2015-09-04  Tim Horton  <timothy_horton@apple.com>
2475
2476         Add a test for r179736 (programmatic navigation during swipe causing a crash)
2477         https://bugs.webkit.org/show_bug.cgi?id=148830
2478
2479         Reviewed by Beth Dakin.
2480
2481         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2482         (WTR::InjectedBundle::beginTesting):
2483         Make sure that TestRunner callbacks don't leak between tests!
2484
2485 2015-09-04  Anders Carlsson  <andersca@apple.com>
2486
2487         It should be possible to pass relative HTTP test paths to DumpRenderTree
2488         https://bugs.webkit.org/show_bug.cgi?id=148825
2489         <rdar://problem/22583866>
2490
2491         Reviewed by Tim Horton.
2492
2493         Convert the path to an absolute path if needed.
2494
2495         * DumpRenderTree/mac/DumpRenderTree.mm:
2496         (computeTestURL):
2497
2498 2015-09-04  Jason Marcell  <jmarcell@apple.com>
2499
2500         Fix Swift unit tests for prepare-ChangeLog.
2501         https://bugs.webkit.org/show_bug.cgi?id=148817
2502
2503         Reviewed by Alexey Proskuryakov.
2504
2505         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests-expected.txt: Fixed
2506         Swift unit tests for prepare-ChangeLog.
2507
2508 2015-09-04  Lucas Forschler  <lforschler@apple.com>
2509
2510         Modifications to the webkit-nightly logic.
2511         
2512         * WebKitLauncher/WebKitNightlyEnablerSparkle.m:
2513         (updateAlertPanel):
2514         * WebKitLauncher/main.m:
2515         (displayErrorAndQuit):
2516
2517 2015-09-04  Beth Dakin  <bdakin@apple.com>
2518
2519         Speculative build fix.
2520
2521         * WebKitTestRunner/mac/EventSenderProxy.mm:
2522
2523 2015-09-04  Brian Burg  <bburg@apple.com>
2524
2525         Web Inspector: InspectorController should support multiple frontend channels
2526         https://bugs.webkit.org/show_bug.cgi?id=148538
2527
2528         Reviewed by Joseph Pecoraro.
2529
2530         InspectorClients must explicitly disconnect their frontend channel(s) from the
2531         inspected page's InspectorController.
2532
2533         To make this possible, DumpRenderTree should not destroy non-primary views until
2534         it has tried to close any abandoned Web Inspector instances. Performing teardown
2535         in the reverse order prevents disconnection of the frontend channel because that
2536         prematurely destroys the inspector frontend client.
2537
2538         * DumpRenderTree/mac/DumpRenderTree.mm:
2539         (runTest):
2540         * DumpRenderTree/win/DumpRenderTree.cpp:
2541         (runTest):
2542
2543 2015-09-04  Beth Dakin  <bdakin@apple.com>
2544
2545         Need to be able to test default behaviors on force click
2546         https://bugs.webkit.org/show_bug.cgi?id=148758
2547
2548         Reviewed by Tim Horton.
2549
2550         This patch adds a new eventSender method to do a full, completed force click, 
2551         and it re-works all of the existing force methods to dispatch their events in 
2552         such a way that they will trigger the NSImmediateAction gesture recognizer. 
2553         To do this, first we need to send the events to the app rather than straight 
2554         to the view, and also needed to tweak some state and send the events in a 
2555         delayed fashion.
2556
2557         New public function mouseForceClick() and private helper functions to make 
2558         NSEvents.
2559         * WebKitTestRunner/EventSenderProxy.h:
2560
2561         New public function mouseForceClick().
2562         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2563         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2564         (WTR::EventSendingController::mouseMoveTo):
2565         (WTR::EventSendingController::mouseForceClick):
2566         (WTR::EventSendingController::mouseForceDown):
2567         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2568         * WebKitTestRunner/TestController.cpp:
2569         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2570
2571         initPressureEventAtLocation needs to take a stageTransition and a window.
2572         * WebKitTestRunner/mac/EventSenderProxy.mm:
2573         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
2574         (-[EventSenderSyntheticEvent stageTransition]):
2575         (-[EventSenderSyntheticEvent timestamp]):
2576         (-[EventSenderSyntheticEvent _cgsEventRecord]):
2577         (-[EventSenderSyntheticEvent window]):
2578
2579         In order to enter the gesture recognizer, we need to start with a mouse down 
2580         that has a NSEventMaskPressure modifier.
2581         (WTR::EventSenderProxy::sendMouseDownToStartPressureEvents):
2582
2583         This ensures that the events queue properly for the force monitor in AppKit.
2584         (WTR::spinRunLoopForForce):
2585
2586          We need to start the pressure change events with a began.
2587         (WTR::EventSenderProxy::beginPressureEvent):
2588
2589         These functions can be used to create the NSEvent for a pressure change every 
2590         time we need one.
2591         (WTR::EventSenderProxy::pressureChangeEvent):
2592
2593         Send the right series of events to emulate a full, completed force click.
2594         (WTR::EventSenderProxy::mouseForceClick):
2595
2596         Use all of the new things for these existing functions.
2597         (WTR::EventSenderProxy::mouseForceDown):
2598         (WTR::EventSenderProxy::mouseForceUp):
2599         (WTR::EventSenderProxy::mouseForceChanged):
2600
2601         Set NSFakeForceTouchDevice to YES.
2602         * WebKitTestRunner/mac/main.mm:
2603         (setDefaultsToConsistentValuesForTesting):
2604
2605 2015-09-04  Jason Marcell  <jmarcell@apple.com>
2606
2607         prepare-ChangeLog needs to know how to parse Swift files.
2608         https://bugs.webkit.org/show_bug.cgi?id=148784
2609         <rdar://problem/22510062>
2610
2611         Reviewed by Darin Adler.
2612
2613         * Scripts/prepare-ChangeLog:
2614         (get_function_line_ranges): Added entry for get_function_line_ranges_for_swift.
2615         (get_function_line_ranges_for_swift): Added function that knows how to parse Swift code.
2616         (parseSwiftFunctionArgs): Added function that knows how to parse Swift function arguments.
2617         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl: Added.
2618         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests-expected.txt: Ditto.
2619         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests.swift: Ditto.
2620         (freeFunction): Ditto.
2621         (MyClass.function): Ditto.
2622         (MyClass.functionWithArgument(_:)): Ditto.
2623         (MyClass.functionWithMoreArguments(_:arg2:)): Ditto.
2624         (MyClass.functionWithNamedFirstArgument(argument:)): Ditto.
2625         (MyClass.functionWithNamedFirstAndSecondArgument(first:second:)): Ditto.
2626         (MyClass.classFunction): Ditto.
2627         (MyClass.readWriteComputedVariable): Ditto.
2628         (MyClass.readOnlyComputedVariable): Ditto.
2629
2630 2015-09-04  Ryosuke Niwa  <rniwa@webkit.org>
2631
2632         Import css/css-color-3
2633         https://bugs.webkit.org/show_bug.cgi?id=148803
2634
2635         Reviewed by Chris Dumez.
2636
2637         Fixed a bug that the imported reference files used the same extention as tests.
2638         This would result in parsing errors if the tests were XML and references were HTML and vice versa.
2639
2640         * Scripts/webkitpy/w3c/test_importer.py:
2641         (TestImporter.find_importable_tests):
2642
2643 2015-09-03  Commit Queue  <commit-queue@webkit.org>
2644
2645         Unreviewed, rolling out r189338.
2646         https://bugs.webkit.org/show_bug.cgi?id=148785
2647
2648         Caused tons of crashes (Requested by cdumez on #webkit).
2649
2650         Reverted changeset:
2651
2652         "Web Inspector: InspectorController should support multiple
2653         frontend channels"
2654         https://bugs.webkit.org/show_bug.cgi?id=148538
2655         http://trac.webkit.org/changeset/189338
2656
2657 2015-09-03  Brian Burg  <bburg@apple.com>
2658
2659         Web Inspector: InspectorController should support multiple frontend channels
2660         https://bugs.webkit.org/show_bug.cgi?id=148538
2661
2662         Reviewed by Joseph Pecoraro.
2663
2664         InspectorClients must explicitly disconnect their frontend channel(s) from the
2665         inspected page's InspectorController.
2666
2667         To make this possible, DumpRenderTree should not destroy non-primary views until
2668         it has tried to close any abandoned Web Inspector instances. Performing teardown
2669         in the reverse order prevents disconnection of the frontend channel because that
2670         prematurely destroys the inspector frontend client.
2671
2672         * DumpRenderTree/mac/DumpRenderTree.mm:
2673         (runTest):
2674         * DumpRenderTree/win/DumpRenderTree.cpp:
2675         (runTest):
2676
2677 2015-09-03  Timothy Hatcher  <timothy@apple.com>
2678
2679         Update WebKit nightly icon to be more like Safari
2680         https://bugs.webkit.org/show_bug.cgi?id=148768
2681
2682         Reviewed by Joseph Pecoraro.
2683
2684         * WebKitLauncher/webkit.icns:
2685
2686 2015-09-03  Geoffrey Garen  <ggaren@apple.com>
2687
2688         JavaScriptCore should have some ES6 conformance tests
2689         https://bugs.webkit.org/show_bug.cgi?id=148771
2690
2691         Reviewed by Chris Dumez.
2692
2693         * Scripts/run-javascriptcore-tests:
2694         (runJSCStressTests): Added es6 as a test suite.
2695
2696         * Scripts/run-jsc-stress-tests: Added es6 as a test suite.
2697
2698         Some of these tests currently fail, so I also added a way to expect
2699         failure for now. We'll migrate failing tests to expected passes as we
2700         fix them.
2701
2702 2015-09-03  Tim Horton  <timothy_horton@apple.com>
2703
2704         Add a test for swipe-start hysteresis
2705         https://bugs.webkit.org/show_bug.cgi?id=148756
2706
2707         Reviewed by Anders Carlsson.
2708
2709         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2710         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2711         (WTR::cacheTestRunnerCallback):
2712         (WTR::TestRunner::clearTestRunnerCallbacks):
2713         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2714         Make sure that we log if a client tries to install a callback twice
2715         (since we use .add, the second call would not work).
2716
2717         Also, add clearTestRunnerCallbacks so tests can swap out installed
2718         callbacks.
2719
2720 2015-09-03  Anders Carlsson  <andersca@apple.com>
2721
2722         DumpRenderTree should automatically compute HTTP URLs for HTTP tests
2723         https://bugs.webkit.org/show_bug.cgi?id=148746
2724         rdar://problem/22568073
2725
2726         Reviewed by Tim Horton.
2727
2728         * DumpRenderTree/mac/DumpRenderTree.mm:
2729         (computeTestURL):
2730         Compute the test URL from the passed in path or URL. Special-case paths that contain /LayoutTests/http/tests. 
2731
2732         (runTest):
2733         Call computeTestURL.
2734
2735         (testPathFromURL):
2736         Get rid of this; computeTestURL does this for us now.
2737
2738         * Scripts/webkitpy/port/driver.py:
2739         (Driver._command_from_driver_input):
2740         Don't convert HTTP test paths to URLS before passing them to DumpRenderTree on Mac. That's handled by DRT itself now.
2741
2742 2015-09-03  Tim Horton  <timothy_horton@apple.com>
2743
2744         Swipe tests fail on Mavericks
2745         https://bugs.webkit.org/show_bug.cgi?id=148752
2746
2747         Reviewed by Beth Dakin.
2748
2749         * WebKitTestRunner/mac/EventSenderProxy.mm:
2750
2751 2015-09-03  Tim Horton  <timothy_horton@apple.com>
2752
2753         Fix the 32-bit build
2754
2755         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2756         (WTR::PlatformWebView::setNavigationGesturesEnabled):
2757
2758 2015-09-03  Tim Horton  <timothy_horton@apple.com>
2759
2760         Remove some logging that wasn't meant to be in the tree
2761
2762         * WebKitTestRunner/mac/EventSenderProxy.mm:
2763         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
2764
2765 2015-09-03  Tim Horton  <timothy_horton@apple.com>
2766
2767         [Mac] Add support for testing swipes
2768         https://bugs.webkit.org/show_bug.cgi?id=148700
2769
2770         Reviewed by Beth Dakin.
2771
2772         * WebKitTestRunner/EventSenderProxy.h:
2773         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2774         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2775         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2776         (WTR::cgEventPhaseFromString):
2777         (WTR::cgEventMomentumPhaseFromString):
2778         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
2779         (WTR::EventSendingController::swipeGestureWithWheelAndMomentumPhases):
2780         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2781         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2782         (WTR::InjectedBundle::didReceiveMessageToPage):
2783         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2784         (WTR::TestRunner::installDidBeginSwipeCallback):
2785         (WTR::TestRunner::installWillEndSwipeCallback):
2786         (WTR::TestRunner::installDidEndSwipeCallback):
2787         (WTR::TestRunner::installDidRemoveSwipeSnapshotCallback):
2788         (WTR::TestRunner::callDidBeginSwipeCallback):
2789         (WTR::TestRunner::callWillEndSwipeCallback):
2790         (WTR::TestRunner::callDidEndSwipeCallback):
2791         (WTR::TestRunner::callDidRemoveSwipeSnapshotCallback):
2792         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2793         * WebKitTestRunner/TestController.cpp:
2794         (WTR::TestController::createOtherPage):
2795         (WTR::TestController::createWebViewWithOptions):
2796         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2797         (WTR::TestController::didBeginNavigationGesture):
2798         (WTR::TestController::willEndNavigationGesture):
2799         (WTR::TestController::didEndNavigationGesture):
2800         (WTR::TestController::didRemoveNavigationGestureSnapshot):
2801         * WebKitTestRunner/TestController.h:
2802         * WebKitTestRunner/TestInvocation.cpp:
2803         (WTR::TestInvocation::didBeginSwipe):
2804         (WTR::TestInvocation::willEndSwipe):
2805         (WTR::TestInvocation::didEndSwipe):
2806         (WTR::TestInvocation::didRemoveSwipeSnapshot):
2807         * WebKitTestRunner/TestInvocation.h:
2808         Add callbacks when navigation gestures didBegin/willEnd/didEnd, and
2809         when the snapshot is removed.
2810
2811         Add swipeGestureWithWheelAndMomentumPhases, just like the equivalent
2812         mouseScrollBy function.
2813
2814         * WebKitTestRunner/mac/EventSenderProxy.mm:
2815         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
2816         (-[EventSenderSyntheticEvent type]):
2817         (-[EventSenderSyntheticEvent subtype]):
2818         (-[EventSenderSyntheticEvent locationInWindow]):
2819         (-[EventSenderSyntheticEvent location]):
2820         (-[EventSenderSyntheticEvent momentumPhase]):
2821         (-[EventSenderSyntheticEvent _isTouchesEnded]):
2822         (-[EventSenderSyntheticEvent _cgsEventRecord]):
2823         Rename EventSenderPressureEvent to EventSenderSyntheticEvent and add some
2824         more adjustable values.
2825
2826         (WTR::EventSenderProxy::mouseForceDown):
2827         (WTR::EventSenderProxy::mouseForceUp):
2828         (WTR::EventSenderProxy::mouseForceChanged):
2829         Adopt EventSenderSyntheticEvent.
2830
2831         (WTR::nsEventPhaseFromCGEventPhase):
2832         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
2833         Make use of EventSenderSyntheticEvent to synthesize swipe gesture events.
2834
2835         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2836         (WTR::PlatformWebView::PlatformWebView):
2837         Enable swipe.
2838
2839 2015-09-03  Myles C. Maxfield  <mmaxfield@apple.com>
2840
2841         [WK2] Allow tagging tests with metadata which needs to be known at web process creation time
2842         https://bugs.webkit.org/show_bug.cgi?id=148723
2843
2844         Reviewed by Anders Carlsson.
2845
2846         * WebKitTestRunner/TestController.cpp:
2847         (WTR::testPath):
2848         (WTR::updateViewOptionsFromTestHeader):
2849         (WTR::TestController::viewOptionsForTest):
2850
2851 2015-09-03  Lucas Forschler  <lforschler@apple.com>
2852
2853         Test commit.
2854
2855 2015-09-02  Tim Horton  <timothy_horton@apple.com>
2856
2857         Add a modern API way to know that the navigation gesture snapshot was removed, for WebKitTestRunner
2858         https://bugs.webkit.org/show_bug.cgi?id=148693
2859
2860         Reviewed by Anders Carlsson.
2861
2862         * WebKitTestRunner/TestController.cpp:
2863         (WTR::TestController::createOtherPage):
2864         (WTR::TestController::createWebViewWithOptions):
2865
2866 2015-09-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2867
2868         REGRESSION(r188548): Some tests crash after r188548 because injected bundle messages are received after the test finishes
2869         https://bugs.webkit.org/show_bug.cgi?id=148529
2870
2871         Reviewed by Darin Adler.
2872
2873         When there are pending EventSender messages after a test finishes,
2874         they could be processed in the main loop started by the
2875         resetStateToConsistentValues(), but the old EventSender has been
2876         replaced by a new one at that point. The new Eventsender can crash
2877         when processing messages that were sent to the old one. To avoid
2878         this, we return early when receiving an EventSender message and
2879         the TestController state is not RunningTest.
2880
2881         * WebKitTestRunner/TestController.cpp:
2882         (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle):
2883         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2884
2885 2015-09-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2886
2887         REGRESSION(r188548): TestController state is Resseting while tests are running after r188548
2888         https://bugs.webkit.org/show_bug.cgi?id=148528
2889
2890         Reviewed by Darin Adler.
2891
2892         Before r188548 resetStateToConsistentValues() was called in
2893         TestController::run(), before tests are run, but now it's called
2894         for every test in TestInvocation::invoke(), after m_status has
2895         changed to RunningTest.
2896
2897         * WebKitTestRunner/TestController.cpp:
2898         (WTR::TestController::resetStateToConsistentValues): Use
2899         TemporaryChange to reset m_state ot its previous value after reset
2900         is done.
2901
2902 2015-08-31  Jason Marcell  <jmarcell@apple.com>
2903
2904         Modify prepare-Changelog to be aware of files that are marked as tests as well as files
2905         that are marked as requiring corresponding tests.
2906         https://bugs.webkit.org/show_bug.cgi?id=148498
2907         <rdar://problem/21555314>
2908
2909         Reviewed by Dan Bernstein and David Kilzer.
2910
2911         * Scripts/prepare-ChangeLog: Added "attributeCache" to cache Subversion properties in order to
2912         simulate Git's attribute behevaior.
2913         (main): Added "requiresTests" array to contain files that require tests.
2914         (generateNewChangeLogs): Checks "requiresTests" array to determine whether to inject "tests"
2915         section in ChangeLog.
2916         (attributeCommand): Queries a given file for a given Git attribute value. If using Subversion,
2917         however, we check if the file or any containing folder has the given property set to "1" and
2918         return 1 if so; return 0 otherwise.
2919         (generateFileList): Adds files to "requiresTests" array if Git attribute is set to "1". Also
2920         adds files to "addedRegressionTests" array if "test" attribute is set to "1".
2921
2922 2015-08-26  Andy Estes  <aestes@apple.com>
2923
2924         [Content Filtering] Determine navigation and content policy before continuing to filter a load
2925         https://bugs.webkit.org/show_bug.cgi?id=148506
2926
2927         Reviewed by Brady Eidson.
2928
2929         Added download API tests covering every decision and decision point.
2930         Removed _WKDownload.AsynchronousDownloadPolicy in favor of these new tests.
2931
2932         * TestWebKitAPI/Configurations/Base.xcconfig: Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to the header search path.
2933         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Removed it from here.
2934         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
2935         (-[BundleParametersPlugIn observeValueForKeyPath:ofObject:change:context:]): Called -valueForKeyPath:, which
2936         returns an id, instead of -valueForKey:, which always returns an NSString even if the object is of another type.
2937         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Added a class that can send a MockContentFilter
2938         decision and decision point as a bundle parameter.
2939         (+[MockContentFilterEnabler supportsSecureCoding]):
2940         (-[MockContentFilterEnabler copyWithZone:]):
2941         (-[MockContentFilterEnabler initWithCoder:]):
2942         (-[MockContentFilterEnabler initWithDecision:decisionPoint:]):
2943         (-[MockContentFilterEnabler encodeWithCoder:]):
2944         (configurationWithContentFilterSettings): Added a helper function to create a WKWebViewConfiguration with MockConentFilter settings.
2945         (TEST): Renamed ContentFiltering.ServerRedirect to ContentFiltering.URLAfterServerRedirect.
2946         (-[BecomeDownloadDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Decided _WKNavigationResponsePolicyBecomeDownload.
2947         (-[BecomeDownloadDelegate webView:didFailProvisionalNavigation:withError:]): Set isDone to true.
2948         (-[BecomeDownloadDelegate webView:didFinishNavigation:]): Ditto.
2949         (-[ContentFilteringDownloadDelegate _downloadDidStart:]): Set downloadDidStart to true.
2950         (downloadTest): Added a helper function to test downloads with a given decision and decision point.
2951         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Added a corresponding bundle class that decodes
2952         the MockContentFilter decision and decision point, and sets these values in the MockContentFilterSettings
2953         singleton. This class is duplicated in the bundle to prevent TestWebKitAPI from having to link to WebCoreTestSupport.
2954         (+[MockContentFilterEnabler supportsSecureCoding]):
2955         (-[MockContentFilterEnabler copyWithZone:]):
2956         (-[MockContentFilterEnabler initWithCoder:]):
2957         (-[MockContentFilterEnabler dealloc]):
2958         (-[MockContentFilterEnabler encodeWithCoder:]):
2959         (-[ContentFilteringPlugIn webProcessPlugIn:initializeWithObject:]): Start observing changes to the MockContentFilterEnabler key path.
2960         (-[ContentFilteringPlugIn dealloc]): Stop observing.
2961         (-[ContentFilteringPlugIn observeValueForKeyPath:ofObject:change:context:]): Store a MockContentFilterEnabler in _contentFilterEnabler.
2962         (+[ServerRedirectPlugIn initialize]): Deleted.
2963         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2964         (-[AsynchronousDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
2965         (-[AsynchronousDownloadDelegate _downloadDidStart:]): Deleted.
2966         (TEST): Deleted.
2967
2968 2015-08-31  Filip Pizlo  <fpizlo@apple.com>
2969
2970         Skip slow lock tests on Windows/debug
2971         https://bugs.webkit.org/show_bug.cgi?id=148643
2972
2973         Reviewed by Alexey Proskuryakov.
2974
2975         The lock tests simulate a critical section by doing some floating point math, and then either
2976         make those critical sections very long or invoke them many times. This appears to be
2977         particularly slow on Windows in debug mode, maybe because Visual Studio's debug build makes
2978         that kind of computation slow.
2979
2980         These tests are almost as useful in release as they are in debug, so it's probably better to
2981         just skip the in debug on platforms where this causes timeouts.
2982
2983         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2984         (TestWebKitAPI::runLockTest):
2985         (TestWebKitAPI::skipSlow):
2986         (TestWebKitAPI::TEST):
2987
2988 2015-08-29  Chris Fleizach  <cfleizach@apple.com>
2989
2990         AX: When navigating the elements of a scrollable element with VoiceOver, the scrollTop() position of the element does not permanently change
2991         https://bugs.webkit.org/show_bug.cgi?id=125720
2992
2993         Reviewed by Daniel Bates.
2994
2995         Add support for scrollToMakeVisibleWithSubFocus and scrollToGlobalPoint.
2996
2997         * DumpRenderTree/AccessibilityUIElement.cpp:
2998         (pressCallback):
2999         (scrollToMakeVisibleWithSubFocusCallback):
3000         (scrollToGlobalPointCallback):
3001         (scrollToMakeVisibleCallback):
3002         (AccessibilityUIElement::getJSClass):
3003         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3004         (AccessibilityUIElement::scrollToMakeVisible):
3005         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3006         (AccessibilityUIElement::scrollToGlobalPoint):
3007         (AccessibilityUIElement::selectedTextRange):
3008         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3009         (AccessibilityUIElement::AccessibilityUIElement):
3010         (AccessibilityUIElement::mathPrescriptsDescription):
3011         (AccessibilityUIElement::scrollToMakeVisible):
3012         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3013         (AccessibilityUIElement::scrollToGlobalPoint):
3014         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3015         (WTR::AccessibilityUIElement::isTextMarkerValid):
3016         (WTR::AccessibilityUIElement::textMarkerForIndex):
3017         (WTR::AccessibilityUIElement::scrollToMakeVisible):
3018         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
3019         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3020         (WTR::AccessibilityUIElement::supportedActions):
3021         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
3022         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
3023         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3024         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3025         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3026         (WTR::AccessibilityUIElement::scrollToMakeVisible):
3027         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
3028         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3029         (WTR::AccessibilityUIElement::selectedTextRange):
3030         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3031         (WTR::AccessibilityUIElement::scrollToMakeVisible):
3032         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
3033         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3034         (WTR::AccessibilityUIElement::selectedTextRange):
3035
3036 2015-08-28  Timothy Horton  <timothy_horton@apple.com>
3037
3038         Add a mysteriously nonproblematic missing comma.
3039
3040         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3041         (TestExpectationParser._collect_matching_tests):
3042         (TestExpectationParser):
3043
3044 2015-08-28  Timothy Horton  <timothy_horton@apple.com>
3045
3046         Remove an old temporary script that has served its purpose
3047
3048         * Scripts/convert-test-expectations: Removed.
3049
3050 2015-08-28  Jer Noble  <jer.noble@apple.com>
3051
3052         [iOS] Add WebKit/WebKit2 settings to control automatic data loading
3053         https://bugs.webkit.org/show_bug.cgi?id=148579
3054
3055         Reviewed by Anders Carlsson.
3056
3057         In DumpRenderTree, set the new mediaDataLoadsAutomatically preference to YES.
3058
3059         In WebKitTestRunner, do the same for the new _mediaDataLoadsAutomatically configuration property,
3060         and also set the existing requiresUserActionForMediaPlayback configuration property to NO.
3061
3062         * DumpRenderTree/mac/DumpRenderTree.mm:
3063         (resetWebPreferencesToConsistentValues):
3064         (resetWebViewToConsistentStateBeforeTesting): 
3065         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3066         (WTR::initializeWebViewConfiguration):
3067
3068 2015-08-28  Alexey Proskuryakov  <ap@apple.com>
3069
3070         Fix run-webkit-tests --additional-env-var="DYLD_INSERT_LIBRARIES=..."
3071         https://bugs.webkit.org/show_bug.cgi?id=148592
3072
3073         Reviewed by Tim Horton.
3074
3075         * Scripts/webkitpy/port/base.py:
3076         (Port.to.setup_environ_for_server):
3077         (Port.to):
3078         (Port.to._append_value_colon_separated):
3079         (Port.to.show_results_html_file):
3080         * Scripts/webkitpy/port/ios.py:
3081         (IOSSimulatorPort.setup_environ_for_server):
3082         * Scripts/webkitpy/port/mac.py:
3083         (MacPort.setup_environ_for_server):
3084
3085 2015-08-28  Filip Pizlo  <fpizlo@apple.com>
3086
3087         LICM should be sound even if the CFG has changed
3088         https://bugs.webkit.org/show_bug.cgi?id=148259
3089
3090         Reviewed by Benjamin Poulain.
3091
3092         Add a utility for creating tests that set some uncommon option.
3093
3094         * Scripts/run-jsc-stress-tests:
3095
3096 2015-08-28  Brent Fulgham  <bfulgham@apple.com>
3097
3098         [Win] Unreviewed EWS correction.
3099
3100         * EWSTools/start-queue-win.sh: Update settings to point to VS2015.
3101
3102 2015-08-28  Jer Noble  <jer.noble@apple.com>
3103
3104         [iOS] Make the AllowsInlineMediaPlayback preference work in WebKit / WebKit2.
3105         https://bugs.webkit.org/show_bug.cgi?id=147512
3106
3107         Reviewed by Anders Carlsson.
3108
3109         Set the value of WebKitAllowsInlineMediaPlayback / WKPreferencesSetMediaPlaybackAllowsInline()
3110         to a consistent (true) value.
3111
3112         * DumpRenderTree/mac/DumpRenderTree.mm:
3113         (setDefaultsToConsistentValuesForTesting):
3114         * WebKitTestRunner/TestController.cpp:
3115         (WTR::TestController::resetPreferencesToConsistentValues):
3116
3117 2015-08-28  Tim Horton  <timothy_horton@apple.com>
3118
3119         Add navigation gesture callbacks to WKPageNavigationClient
3120         https://bugs.webkit.org/show_bug.cgi?id=148568
3121         <rdar://problem/22371346>
3122
3123         Reviewed by Anders Carlsson.
3124
3125         * WebKitTestRunner/TestController.cpp:
3126         (WTR::TestController::createOtherPage):
3127         (WTR::TestController::createWebViewWithOptions):
3128         Add some zeroes.
3129
3130 2015-08-28  Alexey Proskuryakov  <ap@apple.com>
3131
3132         [Mac] kill-old-processes should kill more processes
3133         https://bugs.webkit.org/show_bug.cgi?id=148577
3134
3135         Reviewed by Tim Horton.
3136
3137         * BuildSlaveSupport/kill-old-processes:
3138
3139 2015-08-28  Jason Marcell  <jmarcell@apple.com>
3140
3141         The status message for combined builder queues should say "all builds succeeded" if everything
3142         built correctly.
3143         https://bugs.webkit.org/show_bug.cgi?id=148535
3144
3145         Reviewed by David Kilzer and Alexey Proskuryakov.
3146
3147         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
3148         (BuildbotCombinedQueueView.prototype.update): Make status message for combined builder queues
3149         say "all builds succeeded" if everything built correctly.
3150
3151 2015-08-28  Carlos Garcia Campos  <cgarcia@igalia.com>
3152
3153         [GTK] Simplify the internal API to create a WebView
3154         https://bugs.webkit.org/show_bug.cgi?id=148570
3155
3156         Reviewed by Žan Doberšek.
3157
3158         * TestWebKitAPI/PlatformWebView.h: Add initialize method for GTK+ too.
3159         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
3160         (TestWebKitAPI::PlatformWebView::PlatformWebView): Implement all
3161         PlatformWebView constructors that end up calling initialize with a PageConfiguration.
3162         (TestWebKitAPI::PlatformWebView::initialize): Create the WebView
3163         passing the received PageConfiguration.
3164         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3165         (WTR::PlatformWebView::PlatformWebView): Create the WebView
3166         passing the received PageConfiguration.
3167
3168 2015-08-27  Aakash Jain  <aakash_jain@apple.com>
3169
3170         iOS Simulator API tests fails as Simulator is not running
3171         https://bugs.webkit.org/show_bug.cgi?id=148501
3172         rdar://problem/22447525
3173
3174         Reviewed by Daniel Bates.
3175
3176         This change is a workaround for <rdar://problem/22388812>.
3177
3178          * Scripts/run-api-tests: Launch the iOS Simulator before starting the API Tests
3179          and quit it on program termination when running tests on the iOS port.
3180          * Scripts/webkitdirs.pm: Store string "For WebKit Development" in constant
3181          SIMULATOR_DEVICE_SUFFIX_FOR_WEBKIT_DEVELOPMENT to make it consistently reusable.
3182
3183 2015-08-27  Alex Christensen  <achristensen@webkit.org>
3184
3185         Make DLLLauncherMain executables dependent on dll
3186         https://bugs.webkit.org/show_bug.cgi?id=148548
3187
3188         Reviewed by Brent Fulgham.
3189
3190         * DumpRenderTree/CMakeLists.txt:
3191         * DumpRenderTree/PlatformWin.cmake:
3192         * MiniBrowser/win/CMakeLists.txt:
3193         * TestWebKitAPI/CMakeLists.txt:
3194         * TestWebKitAPI/PlatformWin.cmake:
3195
3196 2015-08-27  Lucas Forschler  <lforschler@apple.com>
3197
3198         Remove Mac slaves 188/189 after being replaced with 400/401.
3199         
3200         Unreviewed.
3201         
3202         * BuildSlaveSupport/build.webkit.org-config/config.json:
3203
3204 2015-08-27  Lucas Forschler  <lforschler@apple.com>
3205
3206         Add two bots to the Mac Yosemite queue.
3207         This is to eventually replace bots188/189, which will be removed after 400/401 are vetted.
3208         
3209         Unreviewed.
3210         
3211         * BuildSlaveSupport/build.webkit.org-config/config.json:
3212
3213 2015-08-27  Alex Christensen  <achristensen@webkit.org>
3214
3215         [Win CMake] Fix incremental build after r188673
3216         https://bugs.webkit.org/show_bug.cgi?id=148539
3217
3218         Reviewed by Brent Fulgham.
3219
3220         * TestWebKitAPI/PlatformWin.cmake:
3221         Copy forwarding headers from WebCore before building in case that was not yet done.
3222         It used to be done when running CMake, but now it's a build step.
3223
3224 2015-08-27  Nan Wang  <n_wang@apple.com>
3225
3226         AX: Fix accessibility/select-element-at-index.html test
3227         https://bugs.webkit.org/show_bug.cgi?id=148516
3228
3229         Reviewed by Chris Fleizach.
3230
3231         Implemented setSelectedChildAtIndex and removeSelectionAtIndex for mac.
3232
3233         * DumpRenderTree/AccessibilityUIElement.cpp:
3234         (setSelectedChildCallback):
3235         (setSelectedChildAtIndexCallback):
3236         (removeSelectionAtIndexCallback):
3237         (elementAtPointCallback):
3238         (sentenceAtOffsetCallback):
3239         (stringForSelectionCallback):
3240         (AccessibilityUIElement::getJSClass):
3241         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3242         (AccessibilityUIElement::setSelectedChild):
3243         (AccessibilityUIElement::setSelectedChildAtIndex):
3244         (AccessibilityUIElement::removeSelectionAtIndex):
3245         (AccessibilityUIElement::accessibilityValue):
3246         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3247         (WTR::AccessibilityUIElement::wordAtOffset):
3248         (WTR::AccessibilityUIElement::lineAtOffset):
3249         (WTR::AccessibilityUIElement::sentenceAtOffset):
3250         (WTR::AccessibilityUIElement::isSelectable):
3251         (WTR::AccessibilityUIElement::isMultiSelectable):
3252         (WTR::AccessibilityUIElement::setSelectedChild):
3253         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
3254         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
3255         (WTR::AccessibilityUIElement::selectedChildrenCount):
3256         (WTR::AccessibilityUIElement::selectedChildAtIndex):
3257         (WTR::AccessibilityUIElement::isExpanded):
3258         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3259         (WTR::AccessibilityUIElement::setSelectedChild):
3260         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
3261         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
3262         (WTR::AccessibilityUIElement::accessibilityValue):
3263
3264 2015-08-27  Alex Christensen  <achristensen@webkit.org>
3265
3266         Build fix after r188982
3267
3268         * MiniBrowser/win/CMakeLists.txt:
3269         The directory structure changed in the move.
3270
3271 2015-08-27  Michael Catanzaro  <mcatanzaro@igalia.com>
3272
3273         [GTK] Unreviewed, install-dependencies should install geoclue2 on Fedora
3274
3275         geoclue-devel is for obsolete geoclue. Install geoclue2-devel instead.
3276
3277         * gtk/install-dependencies:
3278
3279 2015-08-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3280
3281         Unreviewed. Mark WTF_WordLock.ContendedShortSection as slow too.
3282
3283         * Scripts/run-gtk-tests:
3284         (TestRunner):
3285
3286 2015-08-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3287
3288         Fix GTK+ WTR crashes in initializeMainRunLoop()
3289
3290         Rubber-stamped by Žan Doberšek.
3291
3292         Initialize threading and main thread before
3293         RunLoop::initializeMainRunLoop(), since the GLib implementation of
3294         the RunLoop uses isMainThread() to decide whether to create a new
3295         GMainContext or use the default one. Also use RunLoop::run() and
3296         ::stop() instead of gtk_main/quit.
3297
3298         * WebKitTestRunner/TestController.cpp:
3299         (WTR::TestController::initialize):
3300         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3301         (WTR::TestController::notifyDone):
3302         (WTR::TestController::platformRunUntil):
3303
3304 2015-08-27  Filip Pizlo  <fpizlo@apple.com>
3305
3306         Unreviewed, further shorten a test that times out because it's very long
3307         running.
3308
3309         I've locally run these tests on repeat for 24 hours and found no genuine
3310         failures, like deadlocks. So, the timeouts are probably because the test
3311         machine is slow and debug is slow. We should just run this test for fewer
3312         iterations.
3313
3314         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3315         (TestWebKitAPI::TEST):
3316
3317 2015-08-26  Ryuan Choi  <ryuan.choi@navercorp.com>
3318
3319         Unreviewed build fix attempt on EFL
3320
3321         * WebKitTestRunner/PlatformEfl.cmake:
3322
3323 2015-08-26  Alex Christensen  <achristensen@webkit.org>
3324
3325         Build fix after r188982
3326
3327         * MiniBrowser/win/CMakeLists.txt:
3328         Find .rc files in correct directory.
3329
3330 2015-08-26  Ryuan Choi  <ryuan.choi@navercorp.com>
3331
3332         [EFL] Bump cairo version to 1.14.2
3333         https://bugs.webkit.org/show_bug.cgi?id=148474
3334
3335         Reviewed by Csaba Osztrogonác.
3336
3337         * efl/jhbuild.modules:
3338
3339 2015-08-26  Andy Estes  <aestes@apple.com>
3340
3341         Crash when following a Google search link to Twitter with Limit Adult Content enabled
3342         https://bugs.webkit.org/show_bug.cgi?id=147651
3343
3344         Rubber-stamped by Brady Eidson.
3345
3346         Taught TestRunner how to decide the navigation policy after a delay.
3347
3348         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3349         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3350         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
3351         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3352         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
3353         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3354         (WTR::TestRunner::shouldDecideNavigationPolicyAfterDelay):
3355         * WebKitTestRunner/TestController.cpp:
3356         (WTR::TestController::initialize):
3357         (WTR::TestController::resetStateToConsistentValues):
3358         (WTR::TestController::decidePolicyForNavigationAction):
3359         * WebKitTestRunner/TestController.h:
3360         (WTR::TestController::setShouldDecideNavigationPolicyAfterDelay):
3361         * WebKitTestRunner/TestInvocation.cpp:
3362         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3363
3364 2015-08-26  Brent Fulgham  <bfulgham@apple.com>
3365
3366         [Win] Rename 'WinLauncher' to 'MiniBrowser'
3367         https://bugs.webkit.org/show_bug.cgi?id=148485
3368
3369         Reviewed by Alex Christensen
3370
3371         Move the WinLauncher project and source files to a subdirectory
3372         of MiniBrowser. Globally change WinLauncher -> MiniBrowser in the
3373         source code and project files.
3374         
3375         * MiniBrowser/MiniBrowser.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj.
3376         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.ico: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.ico.
3377         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.rc: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.rc.
3378         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.
3379         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj.filters: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters.
3380         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCF.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props.
3381         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCFLite.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props.
3382         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCommon.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props.
3383         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserDebug.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props.
3384         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc.
3385         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.
3386         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj.filters: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters.
3387         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibCommon.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props.
3388         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibDebug.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props.
3389         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPostBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd.
3390         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPreBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd.
3391         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibProduction.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props.
3392         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibRelease.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props.
3393         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h.
3394         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPostBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherPostBuild.cmd.
3395         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPreBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd.
3396         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserProduction.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props.
3397         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserRelease.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props.
3398         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserResource.h: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h.
3399         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.ico: Removed.
3400         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.rc: Removed.
3401         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.vcxproj: Removed.
3402         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.vcxproj.filters: Removed.
3403         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCF.props: Removed.
3404         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCFLite.props: Removed.
3405         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCommon.props: Removed.
3406         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherDebug.props: Removed.
3407         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.rc: Removed.
3408         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.vcxproj: Removed.
3409         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
3410         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibCommon.props: Removed.
3411         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibDebug.props: Removed.
3412         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
3413         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
3414         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibProduction.props: Removed.
3415         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibRelease.props: Removed.
3416         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibResource.h: Removed.
3417         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherPostBuild.cmd: Removed.
3418         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherPreBuild.cmd: Removed.
3419         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherProduction.props: Removed.
3420         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherRelease.props: Removed.
3421         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherResource.h: Removed.
3422         * MiniBrowser/win: Copied from WinLauncher.
3423         * MiniBrowser/win/Common.cpp:
3424         * MiniBrowser/win/MiniBrowser.cpp: Copied from WinLauncher/WinLauncher.cpp.
3425         * MiniBrowser/win/MiniBrowser.h: Copied from WinLauncher/WinLauncher.h.
3426         * MiniBrowser/win/MiniBrowserReplace.h: Copied from WinLauncher/WinLauncherReplace.h.
3427         * MiniBrowser/win/MiniBrowserWebHost.cpp: Copied from WinLauncher/WinLauncherWebHost.cpp.
3428         * MiniBrowser/win/MiniBrowserWebHost.h: Copied from WinLauncher/WinLauncherWebHost.h.
3429         * MiniBrowser/win/PageLoadTestClient.cpp:
3430         * MiniBrowser/win/PageLoadTestClient.h:
3431         * MiniBrowser/win/ResourceLoadDelegate.cpp:
3432         * MiniBrowser/win/ResourceLoadDelegate.h:
3433         * MiniBrowser/win/WinLauncher.cpp: Removed.
3434         * MiniBrowser/win/WinLauncher.h: Removed.
3435         * MiniBrowser/win/WinLauncher.vcxproj: Removed.
3436         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.ico: Removed.
3437         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.rc: Removed.
3438         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.vcxproj: Removed.
3439         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Removed.
3440         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCF.props: Removed.
3441         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCFLite.props: Removed.
3442         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCommon.props: Removed.
3443         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherDebug.props: Removed.
3444         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.rc: Removed.
3445         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Removed.
3446         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
3447         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibCommon.props: Removed.
3448         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibDebug.props: Removed.
3449         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
3450         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
3451         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibProduction.props: Removed.
3452         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibRelease.props: Removed.
3453         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibResource.h: Removed.
3454         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherPostBuild.cmd: Removed.
3455         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherPreBuild.cmd: Removed.
3456         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherProduction.props: Removed.
3457         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherRelease.props: Removed.
3458         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherResource.h: Removed.
3459         * MiniBrowser/win/WinLauncher.vcxproj/small.ico: Removed.
3460         * MiniBrowser/win/WinLauncherReplace.h: Removed.
3461         * MiniBrowser/win/WinLauncherWebHost.cpp: Removed.
3462         * MiniBrowser/win/WinLauncherWebHost.h: Removed.
3463         * MiniBrowser/win/WinMain.cpp:
3464         * WinLauncher: Removed.
3465         * WinLauncher/AccessibilityDelegate.cpp: Removed.
3466         * WinLauncher/AccessibilityDelegate.h: Removed.
3467         * WinLauncher/CMakeLists.txt: Removed.
3468         * WinLauncher/Common.cpp: Removed.
3469         * WinLauncher/DOMDefaultImpl.cpp: Removed.
3470         * WinLauncher/DOMDefaultImpl.h: Removed.
3471         * WinLauncher/PageLoadTestClient.cpp: Removed.
3472         * WinLauncher/PageLoadTestClient.h: Removed.
3473         * WinLauncher/PrintWebUIDelegate.cpp: Removed.
3474         * WinLauncher/PrintWebUIDelegate.h: Removed.
3475         * WinLauncher/ResourceLoadDelegate.cpp: Removed.
3476         * WinLauncher/ResourceLoadDelegate.h: Removed.
3477         * WinLauncher/WebDownloadDelegate.cpp: Removed.
3478         * WinLauncher/WebDownloadDelegate.h: Removed.
3479         * WinLauncher/WinLauncher.cpp: Removed.
3480         * WinLauncher/WinLauncher.h: Removed.
3481         * WinLauncher/WinLauncher.vcxproj: Removed.
3482         * WinLauncher/WinLauncher.vcxproj/WinLauncher.ico: Removed.
3483         * WinLauncher/WinLauncher.vcxproj/WinLauncher.rc: Removed.
3484         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Removed.
3485         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Removed.
3486         * WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props: Removed.
3487         * WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props: Removed.
3488         * WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props: Removed.
3489         * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props: Removed.
3490         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Removed.
3491         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Removed.
3492         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
3493         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Removed.
3494         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props: Removed.
3495         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
3496         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
3497         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props: Removed.
3498         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props: Removed.
3499         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Removed.
3500         * WinLauncher/WinLauncher.vcxproj/WinLauncherPostBuild.cmd: Removed.
3501         * WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd: Removed.
3502         * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props: Removed.
3503         * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props: Removed.
3504         * WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h: Removed.
3505         * WinLauncher/WinLauncher.vcxproj/small.ico: Removed.
3506         * WinLauncher/WinLauncherReplace.h: Removed.
3507         * WinLauncher/WinLauncherWebHost.cpp: Removed.
3508         * WinLauncher/WinLauncherWebHost.h: Removed.
3509         * WinLauncher/WinMain.cpp: Removed.
3510         * WinLauncher/resource.h: Removed.
3511         * WinLauncher/stdafx.cpp: Removed.
3512         * WinLauncher/stdafx.h: Removed.
3513         * win/AssembleBuildLogs/AssembleLogs.cmd:
3514
3515 2015-08-26  Brent Fulgham  <bfulgham@apple.com>
3516
3517         [Win] Simplify menu handling code in WinLauncher
3518         https://bugs.webkit.org/show_bug.cgi?id=148461
3519
3520         Reviewed by Zalan Bujtas.
3521
3522         Revise 'ToggleMenuItem' to return a boolean value indicating if
3523         it handled the message. Revise WndProc to use this to decide if it
3524         should pass the message on to the default handler, rather than
3525         duplicating the logic in both places.
3526         
3527         * WinLauncher/Common.cpp:
3528         (ToggleMenuItem): Return true if the menu item message was handled.
3529         (WndProc): If 'ToggleMenuItem' did not handle the message, pass
3530         the message tothe default handler.
3531
3532 2015-08-26  Csaba Osztrogonác  <ossy@webkit.org>
3533
3534         Remove unused code after r188948
3535         https://bugs.webkit.org/show_bug.cgi?id=148467
3536
3537         Reviewed by Gyuyoung Kim.
3538
3539         * WebKitTestRunner/TestController.cpp:
3540         (WTR::TestController::platformPreferences): Deleted.
3541
3542 2015-08-26  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3543
3544         [EFL][GTK] REGRESSION(r188828): All performance tests and almost all layout tests crash
3545         https://bugs.webkit.org/show_bug.cgi?id=148377
3546
3547         Reviewed by Carlos Garcia Campos.
3548
3549         EFL and GTK don't support TestController::platformPreferences() yet which was introduced by r188828.
3550         It caused all crashes of layout test and performance test on EFL and GTK. So this patch implements
3551         TestController::platformPreferences() using WKPageGroupGetPreferences() which was previous thing for